Merge from gnulib.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ce811ad9
EZ
12012-07-15 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
4 (bidi_paragraph_init): Use it to limit search forward for a strong
5 directional character in abnormally large paragraphs full of
6 neutral or weak characters. (Bug#11943)
7
c9adfeaa
SF
82012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
9
10 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
11 the toolbar (Bug#9451).
12 (xg_make_tool_item): Give the widget event box a transparent
13 background.
14
fff62aa9
DA
152012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
16
17 Cleanup basic allocation variables and functions.
18 * alloc.c (ignore_warnings, init_intervals, init_float)
19 (init_cons, init_symbol, init_marker): Remove.
20 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
21 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
22 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
23 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
24 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
25 (staticidx, init_alloc_once, init_strings, free_ablock):
26 Remove redundant initialization.
27 * fns.c (init_weak_hash_tables): Remove.
28 * lisp.h (init_weak_hash_tables): Remove prototype.
29
9730daca
DA
302012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
31
32 Use zero_vector where appropriate.
33 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
34 accordingly.
35 * lisp.h (zero_vector): New declaration.
36 * font.c (null_vector): Remove.
37 (syms_of_font): Remove initialization and staticpro.
38 (font_list_entities, font_find_for_lface): Change to use zero_vector.
39 * keymap.c (Faccessible_keymaps): Likewise.
40
2e2d2a13
LL
412012-07-15 Leo Liu <sdl.web@gmail.com>
42
43 * fringe.c: Fix typo in comments.
44
cd276f6e
LL
452012-07-14 Leo Liu <sdl.web@gmail.com>
46
47 * fringe.c: Add a new bitmap exclamation-mark.
48
5a1131d9
EZ
492012-07-14 Eli Zaretskii <eliz@gnu.org>
50
51 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
52
53 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
54 (HAVE_MENUS): Don't define, defined by editing config.in with
55 msdos/sed2v2.inp.
56 (GMALLOC_INHIBIT_VALLOC): Don't define.
57 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
58
22e983b7
JB
592012-07-14 Juanma Barranquero <lekktu@gmail.com>
60
61 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
62
5b3f250f
GM
632012-07-14 Glenn Morris <rgm@gnu.org>
64
65 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
66 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
67 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
68
33d63ff4
GM
692012-07-13 Glenn Morris <rgm@gnu.org>
70
5b633342
GM
71 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
72
33d63ff4
GM
73 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
74 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
75
b55b9f85
JD
762012-07-13 Jan Djärv <jan.h.d@swipnet.se>
77
0dc8cf50
JD
78 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
79 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
80 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
81 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
82 where appropriate.
83 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
84 as boolean expression.
85 (x_set_window_size): Remove unused variable toolbar.
86 (ns_get_color_default, ns_mod_to_lisp): Remove.
87 (ns_mouse_position): Remove unused variables xchar and ychar.
88 (ns_compute_glyph_string_overhangs): Remove unused variable face.
89 (ns_set_vertical_scroll_bar): Remove unused variable count.
90 (ns_delete_terminal): Remove unused variable i.
91 (ns_term_init): Remove unused variables r, g and b.
92 (mouseDown): Remove unused variable window.
93 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
94 (initFrameFromEmacs): Remove unused variable vbextra.
95 (mouseEntered): Remove unused variables p and dpyinfo.
96 (mouseExited): Remove unused variables p and r.
97 (ns_define_frame_cursor, ns_clear_frame_area)
98 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
99 (menuDown): Assign [sender tag] to variable and cast the variable.
100
101 * nsterm.h (menuDown): Add id as type to argument sender.
102 (ns_display_info_for_name): Add Lisp_Object argument.
103 (ns_term_init): Add Lisp_Object argument.
104 (ns_map_event_to_object): Add void argument.
105 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
106 prototype with arguments and only declare if __OBJC__.
107 (nxatoms_of_nsselect): Add void argument.
108 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
109 (ns_alloc_autorelease_pool): Add void argument.
110 (ns_release_autorelease_pool): Add void* argument.
111 (ns_get_defaults_value): Add const char* argument.
112
113 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
114 (initFromContents): Use SSDATA where appropriate.
115 (ns_update_menubar): Add braces to ambigous if-else.
116 (initWithTitle): Put () around assignment in if statement.
117 (ns_menu_show): Remove unused variables window and keymap.
118 (update_frame_tool_bar): Remove unused variable selected_p.
119 (initWithContentRect): Remove unused variable this_cmd_name.
120
121 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
122 appropriate.
123 (setXBMColor): Remove unused variable len.
124 (setPixmapData): Put () around assignment in loop statement.
125
126 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
127 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
128 where appropriate.
129 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
130 around assignment in loop statement.
131 (nsfont_open): Remove unused variable i.
132 (nsfont_open): Remove unused variable len.
133 (nsfont_draw): Remove unused variable cs.
134
135 * nsfns.m (x_set_icon_name, ns_set_name_internal)
136 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
137 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
138 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
139 (Fns_font_name, Fns_perform_service)
140 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
141 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
142 (ns_set_name): Remove unused variable view.
143 (x_set_menu_bar_lines): Remove unused variable olines.
144 (x_set_tool_bar_lines): Remove unused variable root_window.
145 (Fns_list_colors): Put () around assignment in while statement.
146 (Fns_perform_service): Remove unused variable len.
147 (Fns_display_usable_bounds): Remove unused variable top.
148 (syms_of_nsfns): Remove unused variable i.
149
b55b9f85
JD
150 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
151 memcpy (Bug#11907).
152
ed9265fc 1532012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
154
155 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
156 and free it with DestroyExceptionInfo (Bug#11558).
157
ef099b57
JB
1582012-07-13 Juanma Barranquero <lekktu@gmail.com>
159
160 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
161 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
162 Set here, not in nt/config.nt.
163
ea814a5d
EZ
1642012-07-13 Eli Zaretskii <eliz@gnu.org>
165
166 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
167 cursor overflow into the last glyph on display line when the right
168 fringe is off. (Bug#11832)
169
1a952767
PE
1702012-07-13 Paul Eggert <eggert@cs.ucla.edu>
171
172 * xdisp.c (produce_special_glyphs): Now static.
173 * dispextern.h (produce_special_glyphs): Remove decl.
174
983188fd
GM
1752012-07-13 Glenn Morris <rgm@gnu.org>
176
32fb4bb6
GM
177 * s/bsd-common, s/cygwin.h: Remove empty files.
178 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
179
983188fd
GM
180 * s/usg5-4-common.h (USG, USG5):
181 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
182 * s/sol2-6.h (SOLARIS2):
183 * s/irix6-5.h (IRIX6_5):
184 * s/hpux10-20.h (USG, USG5, HPUX):
185 * s/gnu-linux.h (USG, GNU_LINUX):
186 * s/freebsd.h (BSD_SYSTEM):
187 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
188 * s/cygwin.h (CYGWIN):
189 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
190 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
191
d1e68667 1922012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
193
194 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 195
6de0e799
GM
1962012-07-13 Glenn Morris <rgm@gnu.org>
197
739ae010
GM
198 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
199
dbee5793
GM
200 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
201
6de0e799
GM
202 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
203 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
204
b82da769
GM
2052012-07-12 Glenn Morris <rgm@gnu.org>
206
4fae5a7a 207 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
208
209 * process.c (init_process_emacs): Rename from init_process.
210 The old name is also the name of a Mach system call.
211 * lisp.h, emacs.c: Update for this name change.
212 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
213 longer needed.
214
5a979817
EZ
2152012-07-12 Eli Zaretskii <eliz@gnu.org>
216
217 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
218 memmove call that removes glyphs covered by the left truncation
219 glyph. Improve commentary.
220 (display_line): Fix display of continuation glyphs on GUI frames
221 when the right fringe is turned off and variable-size fonts are
222 used in the window. Move the code that appends a stretch glyph to
223 produce_special_glyphs, so that it could be used for truncation
224 and continuation glyphs alike.
225 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
226 glyph of a suitably computed width, to align the special glyphs at
227 the window margin. Code moved from display_line. (Bug#11832)
228
3e91a053
GM
2292012-07-12 Glenn Morris <rgm@gnu.org>
230
ba9e4b84
GM
231 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
232
233 * s/gnu-linux.h, s/hpux10-20.h:
234 Do not unconditionally define HAVE_XRMSETDATABASE.
235
3e91a053
GM
236 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
237
b300b1f4
PE
2382012-07-12 Paul Eggert <eggert@cs.ucla.edu>
239
240 Fix typos that broke OS X build.
241 Reported by Randal L. Schwartz in
242 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
243 * nsterm.m (ns_timeout): Add missing local decl.
244 (ns_get_color): snprintf -> sprintf, to fix typo.
245
6e777848
GM
2462012-07-12 Glenn Morris <rgm@gnu.org>
247
3f922c37
GM
248 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
249 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
250 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
251 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
252
0ab7b23a
GM
253 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
254 Move PTY_OPEN to configure.
255
6e777848
GM
256 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
257 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
258 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
259
4a7edc24
DA
2602012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
261
262 Use empty_unibyte_string where applicable.
263 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
264 * lread.c (read1): Likewise.
265 * xsettings.c (syms_of_xsettings): Likewise.
266
308aab79
GM
2672012-07-12 Glenn Morris <rgm@gnu.org>
268
42bd1719
GM
269 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
270 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
271 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
272 * s/hpux10-20.h (RUN_TIME_REMAP):
273 * s/bsd-common.h (TABDLY): Move to configure.
274
275 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
276
277 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
278
ea0bbd17 279 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 280 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
281
282 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 283
308aab79
GM
284 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
285 * s/template.h: Move NARROWPROTO to configure.
286
ee1cf5cf
GM
2872012-07-11 Glenn Morris <rgm@gnu.org>
288
30fe9bf4
GM
289 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
290 unused since 2011-01-17 change to systty.h.
291
ee1cf5cf
GM
292 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
293 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
294 Move HAVE_PTYS and HAVE_SOCKETS to configure.
295
63e47e07
PE
2962012-07-11 Paul Eggert <eggert@cs.ucla.edu>
297
298 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
299
c43fb4c3
GM
3002012-07-11 Glenn Morris <rgm@gnu.org>
301
302 * s/darwin.h, s/gnu-linux.h, s/template.h:
303 Move INTERRUPT_INPUT to configure.
304
e8df9267
DA
3052012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
306
307 Minor adjustments to interning code.
308 * lisp.h (intern, intern_c_string): Redefine as static inline
309 wrappers for intern_1 and intern_c_string_1, respectively.
310 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
311 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
312 Vobarray checking.
e8df9267
DA
313 * font.c (font_intern_prop): Likewise. Adjust comment.
314 * w32font.c (intern_font_name): Likewise.
315
34348bd4
AS
3162012-07-11 Andreas Schwab <schwab@linux-m68k.org>
317
d96a1e0c
AS
318 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
319
34348bd4
AS
320 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
321 of Fcar/Fcdr if possible.
322 * font.c (check_otf_features): Likewise.
323 * fontset.c (Fnew_fontset): Likewise.
324 * gnutls.c (Fgnutls_boot): Likewise.
325 * minibuf.c (read_minibuf): Likewise.
326 * msdos.c (IT_set_frame_parameters): Likewise.
327 * xmenu.c (Fx_popup_dialog): Likewise.
328 * w32menu.c (Fx_popup_dialog): Likewise.
329
c8add24e
GM
3302012-07-11 Glenn Morris <rgm@gnu.org>
331
4b575b3c
GM
332 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
333 since nothing has defined it on these platforms.
334
09f4e3b0
GM
335 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
336 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
337
172bedef
GM
338 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
339 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
340 Move CLASH_DETECTION to configure.
341
249685df
GM
342 * s/gnu.h: Remove file, which is now empty.
343
c8add24e
GM
344 * s/gnu.h, s/gnu-linux.h:
345 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
346
b41253a3
JW
3472012-07-11 John Wiegley <johnw@newartisans.com>
348
349 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
350 function attribute, so we only use it if it exists in the
351 compiler.
352
d923b542
DA
3532012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
354
355 Avoid call to strlen in fast_c_string_match_ignore_case.
356 * search.c (fast_c_string_match_ignore_case): Change to use
357 length argument. Adjust users accordingly.
358 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
359
5ebbef1d
PE
3602012-07-11 Paul Eggert <eggert@cs.ucla.edu>
361
bb352260
PE
362 Assume mkdir, rmdir.
363 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
364 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
365
57054ddd
PE
366 Assume rename.
367 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
368
b747d3f7
PE
369 Assume perror.
370 * s/hpux10-20.h (HAVE_PERROR): Remove.
371 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
372 Remove dummy definition, as this problem was obsolete long ago.
373
5ebbef1d
PE
374 Assume strerror.
375 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
376
984e7f30
DA
3772012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
378
379 Avoid calls to strlen in font processing functions.
380 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 381 (font_open_by_name): Change to use length argument. Adjust
984e7f30 382 users accordingly.
d923b542
DA
383 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
384 Adjust prototypes.
385 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
386 Change to return ptrdiff_t.
984e7f30
DA
387 (xfont_list_pattern, xfont_match): Use length returned by
388 xfont_decode_coding_xlfd.
389 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
390
20e94fdd
GM
3912012-07-11 Glenn Morris <rgm@gnu.org>
392
9d596af3
GM
393 * s/darwin.h, s/freebsd.h, s/netbsd.h:
394 Move DONT_REOPEN_PTY to configure.
395
20e94fdd
GM
396 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
397 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
398
e99a530f
PE
3992012-07-10 Paul Eggert <eggert@cs.ucla.edu>
400
22ffb973
PE
401 Remove "#define unix" that is no longer needed (Bug#11905).
402 * s/aix4-2.h (unix): Remove; no longer needed.
403
e9a9ae03
PE
404 EMACS_TIME simplification (Bug#11875).
405 This replaces macros (which typically do not work in GDB)
406 with functions, typedefs and enums, making the code easier to debug.
407 The functional style also makes code easier to read and maintain.
408 * systime.h: Include <sys/time.h> on all hosts, not just if
409 WINDOWSNT, since 'struct timeval' is needed in general.
410 (EMACS_TIME): Now a typedef, not a macro.
411 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
412 not macros.
413 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
414 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
415 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
416 (EMACS_TIME_LE): Now functions, not macros.
417 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
418 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
419 which are not functions. All uses rewritten to use:
420 (make_emacs_time): New function.
421 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
422 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
423 not functions. All uses rewritten to use the following, respectively:
424 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
425 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 426 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
427 * fileio.c (Fcopy_file):
428 * xterm.c (XTflash): Get the current time closer to when it's used.
429 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
430
ffacb126
PE
431 * bytecode.c (targets): Suppress -Woverride-init warnings.
432
e99a530f
PE
433 Simplify by avoiding confusing use of strncpy etc.
434 * doc.c (Fsnarf_documentation):
435 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
436 * frame.c (Fmake_terminal_frame):
437 * gtkutil.c (get_utf8_string):
438 * lread.c (openp):
439 * nsmenu.m (ns_update_menubar):
440 * regex.c (regerror):
441 Prefer memcpy to strncpy and strncat when either will do.
442 * fileio.c (Fsubstitute_in_file_name):
443 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
444 (menu_separator_name_p):
445 * nsmenu.m (ns_update_menubar):
446 Prefer memcmp to strncmp when either will do.
447 * nsterm.m: Include <ftoastr.h>.
448 (ns_get_color):
449 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
450 Prefer snprintf to strncpy.
451 * nsterm.m (ns_term_init):
452 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
453 * nsterm.m (ns_term_init):
454 Avoid the need for strncpy, by using build_string or
455 make_unibyte_string directly. Use dtoastr, not snprintf.
456 * process.c (Fmake_network_process): Diagnose service names that
457 are too long, rather than silently truncating them or creating
458 non-null-terminated names.
459 (Fnetwork_interface_info): Likewise, for interface names.
460 * sysdep.c (system_process_attributes) [GNU_LINUX]:
461 Prefer sprintf to strncat.
462 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
463 Prefer vsnprintf to vsprintf + strncpy.
464
c59592b3
GM
4652012-07-10 Glenn Morris <rgm@gnu.org>
466
467 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
468 Clarify fallback case.
469
7d7bbefd
DA
4702012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
473 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
474 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 475 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
476 where argument type is known to be a Lisp_Cons.
477
3a4c8000
TT
4782012-07-10 Tom Tromey <tromey@redhat.com>
479
480 * bytecode.c (BYTE_CODE_THREADED): New macro.
481 (BYTE_CODES): New macro. Replaces all old byte-code defines.
482 (enum byte_code_op): New type.
483 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
484 (exec_byte_code): Use them. Use token threading when applicable.
485
2a0213a6
DA
4862012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Optimize pure C strings initialization.
489 * lisp.h (make_pure_string): Fix prototype.
490 (build_pure_c_string): New function, defined as static inline. This
491 provides a better opportunity to optimize away calls to strlen when
492 the function is called with compile-time constant argument.
493 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
494 argument, adjust users accordingly. Use build_pure_c_string where
495 appropriate.
496 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
497 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
498 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
499
cb1caeaf
DA
5002012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
501
502 Avoid calls to strlen in miscellaneous functions.
503 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
504 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
505 * lread.c (openp): Likewise.
506
c293e30c
DA
5072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
508
509 Avoid calls to strlen in path processing functions.
510 * fileio.c (file_name_as_directory): Add comment. Change to add
511 srclen argument and return the length of result. Adjust users
512 accordingly.
513 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 514 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
515 users accordingly.
516 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
517
9e059e3f
GM
5182012-07-10 Glenn Morris <rgm@gnu.org>
519
d02eb359
GM
520 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
521 Move PENDING_OUTPUT_COUNT definition to configure.
522
882cf227
GM
523 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
524 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
525 * s/gnu.h (DATA_START): Move definitions to configure.
526
af6e839f
GM
527 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
528 We include usg5-4-common.h, which defines them both.
529
40289a12
GM
530 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
531 O_RDONLY already includes it).
532
9e059e3f
GM
533 Stop ns builds setting the EMACSLOADPATH environment variable.
534 * nsterm.m (ns_load_path): Rename from ns_init_paths.
535 Now it does not set EMACSLOADPATH, just returns the load-path string.
536 * nsterm.h: Update accordingly.
537 * lread.c [HAVE_NS]: Include nsterm.h.
538 (init_lread) [HAVE_NS]: Use ns_load_path.
539 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
540
7c4e8ec0
GM
5412012-07-09 Glenn Morris <rgm@gnu.org>
542
d4f600ff
GM
543 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
544 since the included bsd-common.h does so.
545
cbb31951
GM
546 Stop ns builds setting the EMACSPATH environment variable.
547 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
548 (ns_init_paths): Do not set EMACSPATH.
549 * nsterm.h (ns_exec_path): Add it.
550 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
551 Use ns_exec_path.
552
7c4e8ec0
GM
553 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
554
26bccfae
PE
5552012-07-09 Paul Eggert <eggert@cs.ucla.edu>
556
a0bee46f
PE
557 * process.c (wait_reading_process_output): 'waitchannels' was unset
558 when read_kbd || !NILP (wait_for_cell); fix this.
559
5994c183
PE
560 Add GCC-style 'const' attribute to functions that can use it.
561 * character.h (char_resolve_modifier_mask):
562 * keyboard.h (make_ctrl_char):
563 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
564 (init_character_once, next_almost_prime, init_fns, init_image)
565 (flush_pending_output, init_sound):
566 * mem-limits.h (start_of_data):
567 * menu.h (finish_menu_items):
568 Add ATTRIBUTE_CONST.
569 * emacs.c (DEFINE_DUMMY_FUNCTION):
570 Declare the dummy function with ATTRIBUTE_CONST.
571 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
572 Add decls with ATTRIBUTE_CONST.
573
26bccfae
PE
574 Minor improvements to make_formatted_string.
575 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
576 where int is good enough, as vsprintf returns an int.
577 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
578
a8290ec3
DA
5792012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
580
581 Use make_formatted_string to avoid double length calculation.
582 * lisp.h (make_formatted_string): New prototype.
583 * alloc.c (make_formatted_string): New function.
584 * buffer.c (Fgenerate_new_buffer_name): Use it.
585 * dbus.c (syms_of_dbusbind): Likewise.
586 * editfns.c (Fcurrent_time_zone): Likewise.
587 * filelock.c (get_boot_time): Likewise.
588 * frame.c (make_terminal_frame, set_term_frame_name)
589 (x_report_frame_params): Likewise.
590 * image.c (gs_load): Likewise.
591 * minibuf.c (get_minibuffer): Likewise.
592 * msdos.c (dos_set_window_size): Likewise.
593 * process.c (make_process): Likewise.
594 * xdisp.c (ensure_echo_area_buffers): Likewise.
595 * xsettings.c (apply_xft_settings): Likewise.
596
d01ba2f1
GM
5972012-07-09 Glenn Morris <rgm@gnu.org>
598
599 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
600 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
601 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
602 * nsterm.h (ns_etc_directory): Add it.
603 * callproc.c [HAVE_NS]: Include nsterm.h.
604 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
605
f1f924b6
DA
6062012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
607
608 Move marker debugging code under MARKER_DEBUG.
609 * marker.c (MARKER_DEBUG): Move marker debugging code under
610 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
611 for bootstrap with --enable-checking (~3x slowdown reported
612 by Juanma Barranquero <lekktu@gmail.com>).
613 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
614
ab531b66
PE
6152012-07-08 Paul Eggert <eggert@cs.ucla.edu>
616
617 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
618 See <http://bugs.gnu.org/11825#29>.
619
c4b3bc8a
EZ
6202012-07-08 Eli Zaretskii <eliz@gnu.org>
621
622 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
623 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
624 (display_line): Add commentary about displaying truncation glyphs
625 on GUI frames.
626 (produce_special_glyphs): Move here from term.c.
627
628 * term.c (produce_special_glyphs): Move to xdisp.c.
629
630 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
631 section.
c4b3bc8a 632
b676b881
AS
6332012-07-07 Andreas Schwab <schwab@linux-m68k.org>
634
f17c5273
AS
635 * xdisp.c (display_line): Avoid warning about implicit declaration
636 of FRAME_FONT.
637
298819b9
AS
638 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
639
b676b881
AS
640 * lisp.h: Remove empty conditional.
641
6045c4fd
PE
6422012-07-07 Paul Eggert <eggert@cs.ucla.edu>
643
b3350bf9
PE
644 * lread.c (load_path_check): Now static.
645
6045c4fd
PE
646 Fix some minor --with-ns problems found by static checking.
647 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
648 (x_set_font) [!HAVE_X_WINDOWS]:
649 * image.c (xpm_load_image) [HAVE_NS]:
650 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
651 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
652 Remove unused local.
653 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
654 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
655 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
656 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
657 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
658 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
659 Fix pointer signedness problem.
660 * xfaces.c (FRAME_X_FONT_TABLE):
661 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
662
929e7845
GM
6632012-07-07 Glenn Morris <rgm@gnu.org>
664
665 * lread.c (load_path_check): New function, split from init_lread.
666 (init_lread): Reorganize. Motivation:
667 If EMACSLOADPATH is set, check/warn about that rather than the
668 defaults, which we are not going to use. Hence we can remove
669 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
670 Don't warn if site-lisp directories are missing.
671 If not installed, start from a blank load-path, since
672 PATH_LOADSEARCH refers to the eventual installation directories.
673
58dd0aa4
EZ
6742012-07-07 Eli Zaretskii <eliz@gnu.org>
675
676 Support truncation and continuation glyphs on GUI frames, when
677 fringes are disabled. (Bug#11832)
678 * xdisp.c (init_iterator): Get dimensions of truncation and
679 continuation glyphs even if on GUI frames. Adjust
680 it->last_visible_x on GUI frames when the left or right fringes,
681 or both, are absent.
682 (start_display, move_it_in_display_line_to): Handle the case of a
683 GUI frame without a fringe to display continuation or truncation
684 glyphs.
685 (insert_left_trunc_glyphs): Support GUI frames: make sure
686 truncation glyphs overwrite enough glyphs from the current line to
687 have sufficient space in pixels.
688 (display_line): Support truncation and continuation glyphs on GUI
689 frames. If some spare pixels are left on the line after inserting
690 the truncation glyphs, fill that space with a stretch glyph of a
691 suitably computed width.
692
693 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
694 produce_glyphs, to support GUI sessions.
695
31571fd7
PE
6962012-07-07 Paul Eggert <eggert@cs.ucla.edu>
697
5a16b9bc
PE
698 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
699
f3047c75
PE
700 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
701
31571fd7
PE
702 Do not require float-time's arg to fit in time_t (Bug#11825).
703 This works better on hosts where time_t is unsigned, and where
704 float-time is applied to the (negative) difference between two times.
705 * editfns.c (decode_time_components): Last arg is now double *,
706 not int *, and means to store all the result as a double, without
707 worrying about whether the seconds part fits in time_t.
708 All callers changed.
709 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
710 All callers changed.
711 (Ffloat_time): Do not fail merely because the specified time falls
712 outside of time_t range.
713
4516fbef
GM
7142012-07-07 Glenn Morris <rgm@gnu.org>
715
716 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
717 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
718 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
719
07adc2c6
JB
7202012-07-07 Juanma Barranquero <lekktu@gmail.com>
721
722 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
723 Update dependencies.
724
725 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
726
fd573f31
PE
7272012-07-06 Paul Eggert <eggert@cs.ucla.edu>
728
fee5959d
PE
729 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
730 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
731 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
732 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
733 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
734 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
735
fd573f31
PE
736 * xfont.c (compare_font_names): Redo to omit the need for casts.
737
ddadbc0e
AS
7382012-07-06 Andreas Schwab <schwab@linux-m68k.org>
739
fca8d6b6
AS
740 * xfns.c (Fx_change_window_property): Doc fix.
741 * w32fns.c (Fx_change_window_property): Doc fix.
742
ddadbc0e
AS
743 * w32fns.c (Fx_window_property): Accept the same arguments as the
744 X Windows version. Doc fix.
745 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
746
ed9265fc 7472012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
748 Eli Zaretskii <eliz@gnu.org>
749
750 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
751 Windows-specific code from nt/config.nt moved here.
752 Obsolete settings removed.
753
216ee680
PE
7542012-07-06 Paul Eggert <eggert@cs.ucla.edu>
755
756 * process.c: Avoid unnecessary calls to gettime.
757 (wait_reading_process_output): Don't get the time of day
758 when gobbling data immediately and not waiting, as there's no need
759 for it in that case. This removes a FIXME.
760
bdd091e4
JD
7612012-07-06 Jan Djärv <jan.h.d@swipnet.se>
762
763 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
764 is defined (Bug#11768).
765
9d44f8ce
DA
7662012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
767
768 Fix marker debugging code.
769 * marker.c (byte_char_debug_check): Do not perform the check
770 if buffer is not multibyte.
090bd7cb
JB
771 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
772 Call byte_char_debug_check with correct arguments.
9d44f8ce 773
90fc4786
DA
7742012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
775
776 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
777 * marker.c (byte_char_debug_check, count_markers):
778 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
779 (byte_debug_flag): Remove.
780 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
781 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
782
7b7ae965
DA
7832012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
784
4e57b342
DA
785 Avoid code repetition in marker-related functions.
786 * marker.c (attach_marker): New function.
787 (Fset_marker, set_marker_restricted, set_marker_both)
788 (set_marker_restricted_both): Use it.
789 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
790 Consistently rename charno to charpos.
791 (marker_position): Add eassert.
792 (marker_byte_position): Convert to eassert.
793
7942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
795
796 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 797 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 798 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 799
657924ff
DA
8002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
801
802 Introduce fast path for the widely used marker operation.
803 * alloc.c (build_marker): New function.
804 * lisp.h (build_marker): New prototype.
805 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
806 * composite.c (autocmp_chars): Likewise.
807 * editfns.c (buildmark): Remove.
808 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
809 (save_restriction_save): Use build_marker.
810 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
811 * window.c (save_window_save): Likewise.
812
041a49a6
DA
8132012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
814
815 Do not use Fdelete_overlay in delete_all_overlays
816 to avoid redundant calls to unchain_overlay.
817 * buffer.c (drop_overlay): New function.
818 (delete_all_overlays, Fdelete_overlay): Use it.
819 * minibuf.c (get_minibuffer): Fix comment.
820
7dca65a4
PE
8212012-07-06 Paul Eggert <eggert@cs.ucla.edu>
822
823 Port to OpenBSD 5.1 amd64.
824 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
825 This is needed for OpenBSD, and should be harmless on all BSD systems.
826 Also, include <sys/sysctl.h>, as it should be available on all
827 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
828 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
829 use p_pid member, not kp_proc.pid.
830
8eb876e2
GM
8312012-07-06 Glenn Morris <rgm@gnu.org>
832
833 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
834
38182d90
PE
8352012-07-05 Paul Eggert <eggert@cs.ucla.edu>
836
837 More xmalloc and related cleanup.
838 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
839 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
840 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
841 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
842 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
843 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
844 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
845 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
846 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
847 * xterm.c:
848 Omit needless casts involving void * pointers and allocation.
849 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
850 as the former is more robust if P's type is changed.
851 Prefer xzalloc to xmalloc + memset 0.
852 Simplify malloc-or-realloc to realloc.
853 Don't worry about xmalloc returning a null pointer.
854 Prefer xstrdup to xmalloc + strcpy.
855 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
856 growing it.
857 * keyboard.c (apply_modifiers_uncached): Prefer local array to
858 alloca of a constant.
859
6dd5a677
EZ
8602012-07-05 Eli Zaretskii <eliz@gnu.org>
861
862 * xdisp.c (display_line): Fix horizontal pixel coordinates when
863 hscroll is larger than the line width. Fixes long and futile
864 looping inside extend_face_to_end_of_line (on a TTY) producing
865 glyphs that are not needed and thrown away.
866
6b312f0f
DA
8672012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
868
869 * marker.c (set_marker_restricted_both): Simplify by using
870 clip_to_bounds.
871
f520ef9b
PE
8722012-07-05 Paul Eggert <eggert@cs.ucla.edu>
873
874 * editfns.c (region_limit): Simplify by using clip_to_bounds.
875
383b7c95
JD
8762012-07-05 Jan Djärv <jan.h.d@swipnet.se>
877
878 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
879 not defined (Bug#11768).
880 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
881 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
882 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
883 followed by gtk_box_set_homogeneous (Bug#11768).
884 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
885 (update_theme_scrollbar_width, xg_create_scroll_bar):
886 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
887 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
888 (is_box_type): New function (Bug#11768).
889 (xg_tool_item_stale_p): Call is_box_type.
5293d758 890 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
891 with default display (Bug#11768).
892
d6e7bf45
EZ
8932012-07-05 Eli Zaretskii <eliz@gnu.org>
894
895 * xdisp.c (window_hscroll_limited): New function.
896 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
897 coordinates when window's hscroll is set to insanely large
898 values. (Bug#11857)
899
431391ec
JB
9002012-07-05 Juanma Barranquero <lekktu@gmail.com>
901
902 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
903 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
904
23f86fce
DA
9052012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
906
907 Cleanup xmalloc.
908 * lisp.h (xzalloc): New prototype. Omit needless casts.
909 * alloc.c (xzalloc): New function. Omit needless casts.
910 * charset.c: Omit needless casts. Convert all calls to
911 xmalloc with following memset to xzalloc.
912 * dispnew.c: Likewise.
913 * fringe.c: Likewise.
914 * image.c: Likewise.
915 * sound.c: Likewise.
916 * term.c: Likewise.
917 * w32fns.c: Likewise.
918 * w32font.c: Likewise.
919 * w32term.c: Likewise.
920 * xfaces.c: Likewise.
921 * xfns.c: Likewise.
922 * xterm.c: Likewise.
923 * atimer.c: Omit needless casts.
924 * buffer.c: Likewise.
925 * callproc.c: Likewise.
926 * ccl.c: Likewise.
927 * coding.c: Likewise.
928 * composite.c: Likewise.
929 * doc.c: Likewise.
930 * doprnt.c: Likewise.
931 * editfns.c: Likewise.
932 * emacs.c: Likewise.
933 * eval.c: Likewise.
934 * filelock.c: Likewise.
935 * fns.c: Likewise.
936 * gtkutil.c: Likewise.
937 * keyboard.c: Likewise.
938 * lisp.h: Likewise.
939 * lread.c: Likewise.
940 * minibuf.c: Likewise.
941 * msdos.c: Likewise.
942 * print.c: Likewise.
943 * process.c: Likewise.
944 * region-cache.c: Likewise.
945 * search.c: Likewise.
946 * sysdep.c: Likewise.
947 * termcap.c: Likewise.
948 * terminal.c: Likewise.
949 * tparam.c: Likewise.
950 * w16select.c: Likewise.
951 * w32.c: Likewise.
952 * w32reg.c: Likewise.
953 * w32select.c: Likewise.
954 * w32uniscribe.c: Likewise.
955 * widget.c: Likewise.
956 * xdisp.c: Likewise.
957 * xmenu.c: Likewise.
958 * xrdb.c: Likewise.
959 * xselect.c: Likewise.
960
0497dc44
PE
9612012-07-05 Paul Eggert <eggert@cs.ucla.edu>
962
963 * fileio.c (time_error_value): Check the right error number.
964 Problem reported by Troels Nielsen in
965 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
966
356e7178
PE
9672012-07-04 Paul Eggert <eggert@cs.ucla.edu>
968
4e71fd89
PE
969 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
970 This should be fixed in a better way; see Eli Zaretskii in
971 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
972 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
973
f0941253
PE
974 * fileio.c (time_error_value): Rename from special_mtime.
975 The old name's problems were noted by Eli Zaretskii in
976 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
977
065c9eb4
PE
978 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
979 This variable's comment says Emacs needs at least one GDB-visible
980 symbol of type enum pvec_type, to work around GDB problems.
981 The symbol's value doesn't matter.
982
356e7178
PE
983 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
984 that causes compilation to fail on pre-C99 compilers.
985
ed9265fc 9862012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
987
988 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
989 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
990
3884d954
DA
9912012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
992
d209e2fb 993 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
994 headers for buffer_defaults and buffer_local_symbols.
995 Reported by Juanma Barranquero <lekktu@gmail.com>.
996
ee28be33
SM
9972012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
998
999 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1000 * lisp.h (enum pvec_type): Use fewer bits.
1001 (PSEUDOVECTOR_SIZE_BITS): New constant.
1002 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1003 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1004 change in pvec_type.
1005 (PSEUDOVECTOR_TYPEP): New macro.
1006 (TYPED_PSEUDOVECTORP): Use it.
1007 * fns.c (internal_equal): Adapt code to extract pvectype.
1008 * emacs.c (gdb_pvec_type): Update type.
1009 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1010 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1011 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1012 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1013 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1014 abusing vector->header.next.nbytes.
1015 (live_vector_p): Use PVEC_TYPE.
1016 (mark_object): Adapt code to extract pvectype. Use switch.
1017
c7f2cd7f
PE
10182012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1021 Tighten new eassert a bit.
1022
8ce70ed2
DA
10232012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1024
1025 Fix compilation with --enable-gcc-warnings and -O1
1026 optimization level.
1027 * doprnt.c (doprnt): Change type of tem to int, initialize
1028 to avoid compiler warning. Add eassert.
1029 * search.c (simple_search): Initialize match_byte to avoid
1030 compiler warning. Add eassert.
1031
dea7f1e5
PE
10322012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1033
24a212eb
PE
1034 Avoid weird behavior with large horizontal scrolls.
1035 Without this change, for example, large hscroll values would
1036 mess up Emacs's display on Fedora 15 x86, presumably due to
1037 overflows in int calculations in the display code.
1038 Also, if buffers had long lines, Emacs would freeze.
1039 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1040 (set_window_hscroll): New function, containing the old guts of
1041 Fset_window_hscroll. Return the clipped value.
1042 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1043 This avoids the need to check against PTRDIFF_MAX.
1044
dea7f1e5
PE
1045 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1046
76046526
DA
10472012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1048
1049 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1050
39adff0d
PE
10512012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1052
63807d47
PE
1053 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1054 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1055 since GCC 4.4.6 issues a bogus warning for them.
1056
39adff0d
PE
1057 Fix bugs in file timestamp newness comparisons.
1058 * fileio.c (Ffile_newer_than_file_p):
1059 * lread.c (Fload): Use full timestamp resolution of files,
1060 not just the 1-second resolution, so that files that are only
1061 slightly newer still count as newer.
1062 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1063 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1064
dbeed9a6
PE
10652012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 * fileio.c: Improve handling of file time marker. (Bug#11852)
1068 (special_mtime): New function.
1069 (Finsert_file_contents, Fverify_visited_file_modtime):
1070 Use it to set special mtime values consistently.
1071
636334d6
AS
10722012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1073
1074 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1075 marker for non-existing file. (Bug#11852)
1076
e2017fe2
GM
10772012-07-03 Glenn Morris <rgm@gnu.org>
1078
1079 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1080 and did not make it into globals.h).
1081
404dbd37
TT
10822012-07-03 Tom Tromey <tromey@redhat.com>
1083
1084 * window.c (Fset_window_margins, Fset_window_fringes)
1085 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1086 * textprop.c (Fprevious_property_change): No longer static.
1087 * syntax.c (Fsyntax_table_p): No longer static.
1088 * process.c (Fget_process, Fprocess_datagram_address): No longer
1089 static.
1090 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1091 * keyboard.c (Fcommand_execute): No longer static.
1092 Remove EXFUN.
1093 * insdel.c (Fcombine_after_change_execute): No longer static.
1094 * image.c (Finit_image_library): No longer static.
1095 * fileio.c (Fmake_symbolic_link): No longer static.
1096 * eval.c (Ffetch_bytecode): No longer static.
1097 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1098 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1099 No longer static.
404dbd37
TT
1100 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1101 static.
1102 * dired.c (Ffile_attributes): No longer static.
1103 * composite.c (Fcomposition_get_gstring): No longer static.
1104 * callproc.c (Fgetenv_internal): No longer static.
1105
1106 * ccl.h: Remove EXFUNs.
1107 * buffer.h: Remove EXFUNs.
1108 * dispextern.h: Remove EXFUNs.
1109 * intervals.h: Remove EXFUNs.
1110 * fontset.h: Remove EXFUN.
1111 * font.h: Remove EXFUNs.
1112 * dosfns.c (system_process_attributes): Remove EXFUN.
1113 * keymap.h: Remove EXFUNs.
1114 * lisp.h: Remove EXFUNs.
1115 * w32term.h: Remove EXFUNs.
1116 * window.h: Remove EXFUNs.
1117 * xsettings.h: Remove EXFUN.
1118 * xterm.h: Remove EXFUN.
1119
8e4fd1e1
GM
11202012-07-03 Glenn Morris <rgm@gnu.org>
1121
1122 * lisp.h (Frandom): Make it visible to C.
1123 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1124 buffer for invisible buffers. (Bug#1229)
1125
ca95b3eb
DA
11262012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1127
1128 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1129 values which aren't power of 2.
1130 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1131 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1132 accordingly.
1133
7555c33f
SM
11342012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1137
1138 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1139
d12e8f5a
DA
11402012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1141
1142 * alloc.c (allocate_vector_block): Remove redundant
1143 calls to mallopt if DOUG_LEA_MALLOC is defined.
1144 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1145 avoid calls to mallopt if zero_vector is returned.
1146
296094c3
DA
11472012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1148
1149 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1150 is enabled, avoid dereferencing NULL current_sblock if
1151 running undumped.
1152
36429c89
DA
11532012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 Cleanup basic buffer management.
1156 * buffer.h (struct buffer): Change layout to use generic vector
1157 marking code. Fix some comments. Change type of 'clip_changed'
1158 to bitfield. Remove unused #ifndef old.
1159 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1160 (GET_OVERLAYS_AT): Fix indentation.
1161 (for_each_per_buffer_object_at): New macro.
1162 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1163 (Fbuffer_local_variables): Use it.
1164 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1165 * alloc.c (allocate_buffer): Adjust to match new layout of
1166 struct buffer. Fix comment.
1167 (mark_overlay): New function.
1168 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1169 Lisp area of struct buffer.
1170 (mark_object): Use it. Adjust marking of misc objects
1171 and related comments.
1172
3b3e4cac
PE
11732012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1176 wrapper that is not needed because the wrapped code is a no-op (zero
1177 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1178 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1179
cf5c0175
DA
11802012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1181
1182 * alloc.c (mark_buffer): Simplify. Remove prototype.
1183 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1184 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1185 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1186 redundant calls to mark_vectorlike for bool vectors.
1187
ca26824c
GM
11882012-06-30 Glenn Morris <rgm@gnu.org>
1189
2e4c5312
GM
1190 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1191
ca26824c
GM
1192 * epaths.in (PATH_SITELOADSEARCH): New.
1193 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1194 This is rather than relying on --enable-locallisppath elements
1195 having "site-lisp" in their names. (Bug#10208#25, 11658)
1196
0d23c240
EZ
11972012-06-30 Eli Zaretskii <eliz@gnu.org>
1198
c9240d7a
EZ
1199 * w32proc.c (sys_select): Accept and ignore one more argument.
1200
1201 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1202
0d23c240 1203 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1204 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1205
1206 * sysdep.c: Don't include dos.h and dosfns.h.
1207
1208 * process.c (sys_select):
1209 * msdos.c (sys_select): Accept one more argument and ignore it.
1210
1211 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1212 adapt data types and code to that.
1213
1214 * dosfns.c:
1215 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1216 which clashes with the gnulib function of the same name.
1217
af5a5a98
AS
12182012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1219
c5e4379c
AS
1220 * font.c (font_style_to_value, font_style_symbolic)
1221 (font_prop_validate_style): Add type checks for values in
1222 font_style_table.
1223
af5a5a98
AS
1224 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1225 argument.
1226 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1227 uses.
1228
8d38f461
EZ
12292012-06-29 Eli Zaretskii <eliz@gnu.org>
1230
2e5a6631
EZ
1231 * xdisp.c (try_window_id): Undo last change.
1232
8d38f461
EZ
1233 * w32.c (getwd): Adjust commentary about startup_dir.
1234 (init_environment): Always call sys_access, even in non-MSVC
1235 builds. Don't chdir to the directory of the Emacs executable.
1236 This undoes code from 1997 which was justified by the need to
1237 "avoid conflicts when removing and renaming directories". But its
1238 downside was that every relative file name was being interpreted
1239 relative to the directory of the Emacs executable, which can never
1240 be TRT. In particular, it broke sys_access when called with
1241 relative file names.
1242 (sys_access): Map GetLastError to errno.
1243
2af3565e
DA
12442012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1245
1246 * window.h (struct window): Change type of 'fringes_outside_margins'
1247 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1248 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1249 Adjust comment.
1250 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1251 to ptrdiff_t.
1252
c8d3a25c 12532012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1254
c8d3a25c
GM
1255 * gnutls.c (emacs_gnutls_handshake):
1256 Add QUIT to make the loop interruptible.
57570cd3 1257
c8d3a25c 12582012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1259
c8d3a25c
GM
1260 * charset.c (init_charset): Make lack of etc/charsets fatal.
1261
3e984ee8
DA
12622012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1263
1264 * editfns.c (region_limit): Fix type mismatch.
1265
ef884f23
DA
12662012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1267
1268 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1269 undefined. Convert from xassert to eassert.
1270 * nsmenu.m: Convert from xassert to eassert.
1271 * nsterm.m: Likewise.
1272
7d7e0027
SM
12732012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1274
1275 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1276
aa754e6a
PE
12772012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1278
1279 Avoid integer overflow on scroll-left and scroll-right.
1280 * window.c (HSCROLL_MAX): New macro.
1281 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1282 overflow when requested scroll falls outside ptrdiff_t range.
1283
80b00b08
DA
12842012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1285
1286 * window.h (struct window): Change type of 'hscroll',
1287 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1288 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1289 Adjust users accordingly.
1290 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1291 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1292 from EMACS_INT to ptrdiff_t.
1293 (make_window): Omit redundant initialization.
1294
62b2bcf6
JB
12952012-06-28 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1298
45942c7d
DA
12992012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 * window.h (struct window): Change type of 'use_time' and
1302 'sequence_number' from Lisp_Object to int.
1303 * frame.c (make_frame): Adjust users accordingly.
1304 * print.c (print_object): Likewise.
1305 * window.c (select_window, Fwindow_use_time, make_parent_window)
1306 (make_window): Likewise.
1307
e509cfa6
DA
13082012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1309
1310 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1311 enabled with --enable-checking=[all,glyphs] configure option.
1312 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1313 adjust comments accordingly.
1314 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1315 undefined, adjust comments accordingly.
1316 * image.c: Likewise.
1317 * scroll.c: Likewise.
1318 * w32fns.c: Likewise.
1319 * w32term.c: Likewise.
1320 * xdisp.c: Likewise.
1321 * xfaces.c: Likewise.
1322 * xfns.c: Likewise.
1323 * xterm.c: Likewise.
1324
a54e2c05
DA
13252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1326
1327 Generalize run-time debugging checks.
1328 * dispextern.h (XASSERTS): Remove.
1329 * fontset.c (xassert): Remove.
1330 Convert from xassert to eassert.
1331 * alloc.c: Convert from xassert to eassert.
1332 * bidi.c: Likewise.
1333 * dispnew.c: Likewise.
1334 * fns.c: Likewise.
1335 * fringe.c: Likewise.
1336 * ftfont.c: Likewise.
1337 * gtkutil.c: Likewise.
1338 * image.c: Likewise.
1339 * keyboard.c: Likewise.
1340 * menu.c: Likewise.
1341 * process.c: Likewise.
1342 * scroll.c: Likewise.
1343 * sound.c: Likewise.
1344 * term.c: Likewise.
1345 * w32console.c: Likewise.
1346 * w32fns.c: Likewise.
1347 * w32term.c: Likewise.
1348 * window.c: Likewise.
1349 * xdisp.c: Likewise.
1350 * xfaces.c: Likewise.
1351 * xfns.c: Likewise.
1352 * xselect.c: Likewise.
1353 * xterm.c: Likewise.
1354
1ec4b7b2
SM
13552012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1356
1357 * fns.c (maybe_resize_hash_table): Output message when growing the
1358 purify-hashtable.
1359
2014308a
DA
13602012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 * alloc.c (allocate_string_data): Remove dead code.
1363 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1364 avoid GCC warning about unused macro.
1365
246155eb
DA
13662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1367
1368 * alloc.c (allocate_string): Omit intervals initialization.
1369 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1370 as in make_pure_string and make_pure_c_string.
1371
43184b7b
DA
13722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1373
d209e2fb 1374 * alloc.c (allocate_string): Fix last change.
43184b7b 1375
3fe6dd74
DA
13762012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1377
d209e2fb 1378 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1379 to memset, add explicit initialization where appropriate.
1380
1ba6038a
GM
13812012-06-27 Glenn Morris <rgm@gnu.org>
1382
1383 * lisp.mk (lisp): Remove paths.elc.
1384
c89926a5
CY
13852012-06-27 Chong Yidong <cyd@gnu.org>
1386
1387 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1388
ed6b3510
JW
13892012-06-26 John Wiegley <johnw@newartisans.com>
1390
1ec4b7b2 1391 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1392 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1393
ed6b3510
JW
1394 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1395 when building with Clang.
1396
8edd4a2b
SM
13972012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1398
1399 * eval.c (Fapply): Allow calling it with a single argument.
1400
f6f62d1b
EZ
14012012-06-26 Eli Zaretskii <eliz@gnu.org>
1402
1403 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1404 _stricmp and _strnicmp.
1405 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1406
62efea5e
DA
14072012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1408
1409 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1410 allocated window.
1411 (allocate_process): Likewise for new process.
8edd4a2b 1412 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1413 (allocate_frame): Likewise.
1414 * frame.c (make_frame): Omit redundant initialization.
1415 * window.c (make_parent_window): Use memset.
1416 (make_window): Omit redundant initialization.
1417 * process.c (make_process): Omit redundant initialization.
1418 * terminal.c (create_terminal): Likewise.
1419
42997f4d
DA
14202012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1421
1422 * term.c (delete_tty): Remove redundant call to memset.
1423
1130ecfc
DA
14242012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1425
1426 * alloc.c: Remove build_string.
1427 * lisp.h: Define build_string as static inline. This provides
1428 a better opportunity to optimize away calls to strlen when the
1429 function is called with compile-time constant argument.
1430 * image.c (imagemagick_error): Convert to build_string.
1431 * w32proc.c (sys_spawnve): Likewise.
1432 * xterm.c (x_term_init): Likewise.
1433
cf38a720
PE
14342012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1435
99027bdd
PE
1436 Use sprintf return value instead of invoking strlen on result.
1437 In the old days this wasn't portable, since some sprintf
1438 implementations returned char *. But they died out years ago and
1439 Emacs already assumes sprintf returns int.
1440 Similarly for float_to_string.
1441 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1442 * ccl.c (ccl_driver):
1443 * character.c (string_escape_byte8):
1444 * data.c (Fnumber_to_string):
1445 * doprnt.c (doprnt):
1446 * print.c (print_object):
1447 * xdisp.c (message_dolog):
1448 * xfns.c (syms_of_xfns):
1449 Use sprintf or float_to_string result to avoid need to call strlen.
1450 * data.c (Fnumber_to_string):
1451 Use make_unibyte_string, since the string must be ASCII.
1452 * lisp.h, print.c (float_to_string): Now returns int length.
1453 * term.c (produce_glyphless_glyph):
1454 Use sprintf result rather than recomputing it.
1455
cf38a720
PE
1456 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1457 * Makefile.in (ALL_CFLAGS):
1458 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1459 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1460
3511c784
DA
14612012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1462
0a08eb21 1463 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1464 strcasecmp if available.
1465 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1466
fb7da12e
AS
14672012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1468
1469 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1470 Avoid comma operator.
1471 * menu.c (push_submenu_start, push_submenu_end)
1472 (push_left_right_boundary, push_menu_pane): Likewise.
1473 * msdos.c (dos_rawgetc): Likewise.
1474
afa2ffd8
DA
14752012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 * xfns.c (xic_create_fontsetname): Remove redundant calls
1478 to memset.
1479
b3b4476b
PE
14802012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1481
4495ff38
PE
1482 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1483 sprintf already null-terminates its output.
1484
b3b4476b
PE
1485 * xfns.c (x_window): Remove redundant cast.
1486
b00876c9
DA
14872012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1488
1489 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1490 `const char *' to `char *' to avoid compiler warning.
1491
d188e26b
PE
14922012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1493
885d1d74
PE
1494 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1495 instead of truncating it to 63 (admittedly a generous limit).
1496
d188e26b
PE
1497 * process.c: Fix spelling and caps in comments.
1498
e2f560b1
DN
14992012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1500
e86db54b 1501 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1502 * sysdep.c (setpgrp): Remove definition, not used in this file.
1503
7583a3a1
JB
15042012-06-24 Juanma Barranquero <lekktu@gmail.com>
1505
1506 * makefile.w32-in: Update dependencies.
1507
696056c2
EZ
15082012-06-24 Eli Zaretskii <eliz@gnu.org>
1509
1510 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1511 (SYSTIME_H): Add nt/inc/sys/time.h.
1512
1513 * systime.h [WINDOWSNT]: Include sys/time.h.
1514
1515 * s/ms-w32.h (struct timespec): Definition moved from
1516 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1517
845ca893
PE
15182012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1521 * buffer.h (buffer_slot_type_mismatch):
1522 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1523 * eval.c (unwind_to_catch):
1524 * image.c (my_png_error, my_error_exit):
1525 * keyboard.c (quit_throw_to_read_char, user_error)
1526 (Fexit_recursive_edit, Fabort_recursive_edit):
1527 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1528 (wrong_type_argument, buffer_overflow, __executable_start)
1529 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1530 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1531 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1532 (fatal):
1533 (child_setup) [!DOS_NT]:
1534 * lread.c (end_of_file_error, invalid_syntax):
1535 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1536 * puresize.h (pure_write_error):
1537 * search.c (matcher_overflow):
1538 * sound.c (sound_perror, alsa_sound_perror):
1539 * sysdep.c, syssignal.h (croak):
1540 * term.c (maybe_fatal, vfatal):
1541 * textprop.c (text_read_only):
1542 * undo.c (user_error):
1543 * unexmacosx.c (unexec_error):
1544 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1545 Use _Noreturn rather than NO_RETURN.
1546 No need for separate decl merely because of _Noreturn.
1547 * sound.c (sound_warning, parse_sound):
1548 Remove unnecessary forward decls.
1549
f1dd8073
PE
15502012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1551
1552 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1553 * lisp.h (WAIT_READING_MAX): New macro.
1554 * dispnew.c (Fsleep_for, sit_for):
1555 * keyboard.c (kbd_buffer_get_event):
1556 * process.c (Faccept_process_output):
1557 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1558 This improves on the previous patch, which introduced a bug
1559 when time_t is unsigned and as wide as intmax_t.
1560 See <http://bugs.gnu.org/9000#51>.
1561
b82c1755
EZ
15622012-06-23 Eli Zaretskii <eliz@gnu.org>
1563
1564 * dispnew.c (sit_for, Fsleep_for):
1565 * keyboard.c (kbd_buffer_get_event):
1566 * process.c (Faccept_process_output): Avoid compiler warnings when
1567 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1568
ca300656
JB
15692012-06-23 Juanma Barranquero <lekktu@gmail.com>
1570
049ec95b
JB
1571 * makefile.w32-in: Update dependencies.
1572
ca300656
JB
1573 * w32.c (ltime): Add return type and declare static.
1574 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1575
db7b8d06
PE
15762012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1579 Privately reported by Herbert J. Skuhra.
1580 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1581 All uses changed.
1582 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1583 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1584
0bd8297f
EZ
15852012-06-23 Eli Zaretskii <eliz@gnu.org>
1586
96512555
EZ
1587 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1588 last argument of make_unibyte_string.
1589
0bd8297f
EZ
1590 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1591 language ID in the event parameters.
1592
1593 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1594 event.code, not the obscure "character set ID".
1595
63def6b6
CY
15962012-06-23 Chong Yidong <cyd@gnu.org>
1597
1598 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1599
e8a02204
EZ
16002012-06-23 Eli Zaretskii <eliz@gnu.org>
1601
388cdec0
EZ
1602 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1603 * w32.c (fdutimens): New function.
1604
1605 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1606
1607 * s/ms-w32.h (pselect): Redirect to sys_select.
1608
1609 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1610
e8a02204
EZ
1611 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1612 in the logic of incrementing and decrementing the value of
1613 use_relocatable_buffers.
1614
d054f3fb
PE
16152012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1616
1617 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1618 Privately reported by Herbert J. Skuhra.
1619 [__FreeBSD__]: Remove "*/" typo after "#include".
1620 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1621 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1622 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1623 Don't assume EMACS_TIME and struct timeval are the same type.
1624
d35af63c
PE
16252012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 Support higher-resolution time stamps (Bug#9000).
1628 The time stamps are only nanosecond-resolution at the C level,
1629 since that's the best that any real-world system supports now.
1630 But they are picosecond-resolution at the Lisp level, as that's
1631 easy, and leaves room for future OS improvements.
1632
1633 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1634 (LIBES): Use it.
1635
1636 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1637 Don't get current time unless it's needed.
1638
1639 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1640 now provides it if it's absent.
1641 (start_atimer): Port to higher-res time stamps.
1642 Check for time stamp overflow. Don't get current time more
1643 often than is needed.
1644
1645 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1646 Include systime.h, not time.h.
1647 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1648
1649 * dired.c: Include stat-time.h.
1650 (Ffile-attributes): File times now have higher resolution.
1651
1652 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1653 (struct image): Timestamp now has higher resolution.
1654
1655 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1656 has at least microseconds now. All uses removed.
1657 (update_frame, update_single_window, update_window, update_frame_1)
1658 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1659
1660 * editfns.c (time_overflow): Now extern.
1661 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1662 (float-time, Fformat_time_string, Fcurrent_time_string)
1663 (Fcurrent_time_zone): Accept and generate higher-resolution
1664 time stamps.
1665 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1666 (decode_time_components, lisp_seconds_argument): New functions.
1667 (make_time): Now static.
1668 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1669 Report an error if the time is invalid, rather than having the caller
1670 do that.
1671
1672 * fileio.c: Include <stat-time.h>
1673 (Fcopy_file): Copy higher-resolution time stamps.
1674 Prefer to set the time stamp via a file descriptor if that works.
1675 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1676 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1677 (Fvisited_file_modtime, Fset_visited_file_modtime):
1678 Support higher-resolution time stamps.
1679
1680 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1681
1682 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1683
1684 * image.c (prepare_image_for_display, clear_image_cache)
1685 (lookup_image): Port to higer-resolution time stamps.
1686
1687 * keyboard.c (start_polling, bind_polling_period):
1688 Check for time stamp overflow.
1689 (read_char, kbd_buffer_get_event, timer_start_idle)
1690 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1691 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1692 Port to higher-resolution time stamps. Do not assume time_t is signed.
1693 (decode_timer): New function. Timers are now vectors of length 9,
1694 not 8, to accommodate the picosecond component.
1695 (timer_check_2): Use it.
1696
1697 * nsterm.m (select_timeout, timeval_subtract): Remove.
1698 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1699 as they're a bit more accurate and handle overflow better.
1700 (ns_select): Change prototype to be compatible with pselect.
1701 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1702 * nsterm.h (ns_select): Adjust prototype.
1703
1704 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1705 us-resolution time stamps.
1706 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1707
1708 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1709
1710 * lisp.h (time_overflow): New decl.
1711 (wait_reading_process_output): First arg is now intmax_t, not int,
1712 to accommodate larger waits.
1713
1714 * process.h (struct Lisp_Process.read_output_delay):
1715 Now counts nanoseconds, not microseconds.
1716 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1717 EMACS_HAS_USECS.
1718 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1719 (wait_reading_process_output):
1720 Port to ns-resolution time stamps.
1721 (Faccept_process_output, wait_reading_process_output):
1722 Check for time stamp overflow. Do not assume time_t is signed.
1723 (select_wrapper): Remove; we now use pselect.
1724 (Fprocess_attributes): Now generates ns-resolution time stamps.
1725
1726 * sysdep.c: Include utimens.h. Don't include utime.h
1727 or worry about struct utimbuf; gnulib does that for us now.
1728 (gettimeofday): Remove; gnulib provides a substitute.
1729 (make_timeval): New function.
1730 (set_file_times): Now sets ns-resolution time stamps.
1731 New arg FD; all uses changed.
1732 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1733 (system_process_attributes):
1734 Now returns ns-resolution time stamp. All uses changed.
1735 Check for time stamp overflow.
1736
1737 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1738 provides a substitute now.
1739
1740 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1741 since it guarantees struct timespec.
1742 (EMACS_TIME): Now struct timespec, so that we can support
1743 ns-resolution time stamps.
1744 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1745 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1746 (EMACS_USECS): Remove.
1747 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1748 so multiply the arg by 1000 before storing it.
1749 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1750 New macros.
1751 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1752 Port to ns-resolution time stamps.
1753 (EMACS_TIME_NEG_P): Remove; replaced by....
1754 (EMACS_TIME_SIGN): New macro.
1755 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1756 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1757 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1758 (make_timeval, make_lisp_time, decode_time_components): New decls.
1759 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1760 that it mishandled time_t overflow. You can't compare by subtracting!
1761 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1762 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1763
1764 * term.c: Include <sys/time.h>.
1765 (timeval_to_Time): New function, for proper overflow wraparound.
1766 (term_mouse_position, term_mouse_click): Use it.
1767
1768 * undo.c (record_first_change): Support higher-resolution time stamps
1769 in the undo buffer.
1770 (Fprimitive_undo): Use them when restoring time stamps.
1771
1772 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1773 (w32_get_internal_run_time):
1774 Port to higher-resolution Emacs time stamps.
1775 (ltime): Now accepts single 64-bit integer, as that's more convenient
1776 for callers.
1777
1778 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1779
1780 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1781 for compatibility with pselect. Support ns-resolution time stamps.
1782
1783 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1784
1785 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1786 Check for time stamp overflow, and support ns-resolution time stamps.
1787
1788 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1789 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1790 (timeval_subtract): Remove; no longer needed.
1791 (XTflash, XTring_bell, x_wait_for_event):
1792 Port to ns-resolution time stamps. Don't assume time_t is signed.
1793
b6a92dfe
CY
17942012-06-22 Chong Yidong <cyd@gnu.org>
1795
1796 * xdisp.c (x_consider_frame_title): Revert last change.
1797
d251c37c
EZ
17982012-06-22 Eli Zaretskii <eliz@gnu.org>
1799
1800 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1801 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1802 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1803 staticidx goes up to 1597 out of 1600 = 0x640.)
1804
f10deafb
PE
18052012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1808 Otherwise, the umask might be mistakenly 0 while handling input signals.
1809
ec6de1e2
SM
18102012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1811
1812 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1813
28be1ada
DA
18142012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1815
1816 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1817 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1818 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1819 access to `contents' member of Lisp_Vector objects with AREF and ASET
1820 where appropriate.
1821
c6bf3022
CY
18222012-06-19 Chong Yidong <cyd@gnu.org>
1823
1824 * frame.c (delete_frame): When selecting a frame on a different
1825 text terminal, do not alter the terminal's top-frame.
1826
1827 * xdisp.c (format_mode_line_unwind_data): Record the target
1828 frame's selected window and its terminal's top-frame.
1829 (unwind_format_mode_line): Restore them.
1830 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1831 Callers changed.
1832 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1833 since tty frames can be explicitly named.
1834 (prepare_menu_bars): Likewise.
1835
1836 * term.c (Ftty_top_frame): New function.
1837
defd4196
PE
18382012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 Port byte-code-meter to modern targets.
1841 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1842 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1843 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1844 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1845 (METER_1, METER_2): Simplify.
1846
1053a871
SM
18472012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1848
1849 * data.c (Fdefalias): Return `symbol' (bug#11686).
1850
b7e8d081
MR
18512012-06-18 Martin Rudalics <rudalics@gmx.at>
1852
1853 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1854 gets killed during executing of this function (Bug#11665).
1855 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1856 (Vkill_buffer_query_functions): In doc-string say that functions
1857 run by this hook should not change the current buffer.
1858
7ea2b339
PE
18592012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 Fix recently-introduced process.c problems found by static checking.
1862 * process.c (write_queue_push, write_queue_pop, send_process):
1863 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1864 (write_queue_pop): Fix pointer signedness problem.
1865 (send_process): Remove unused local.
1866
96a313a1
CY
18672012-06-17 Chong Yidong <cyd@gnu.org>
1868
1869 * xdisp.c (redisplay_internal): No need to redisplay terminal
1870 frames that are not on top.
1871
20ca2e94
TN
18722012-06-17 Troels Nielsen <bn.troels@gmail.com>
1873
1874 * process.c (make_process): Initialize write_queue.
1875 (write_queue_push, write_queue_pop): New functions.
1876 (send_process): Use them to maintain correct ordering of process
1877 writes (Bug#10815).
1878
9a900ca9
PE
18792012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1880
310fbfa8
PE
1881 * lisp.h (eassert): Assume C89 or later.
1882 This removes the need for CHECK.
1883 (CHECK): Remove. Its comments about always evaluating its
1884 argument were confusing, as 'eassert' typically does not evaluate
1885 its argument.
1886
27bb1ca4
PE
1887 * coding.c (produce_chars): Use ptrdiff_t, not int.
1888
9a900ca9
PE
1889 * xterm.c (x_draw_underwave): Check for integer overflow.
1890 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1891
41b7f8bc 18922012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1893
1894 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1895 referenced (Bug#11583).
1896
9b0e3eba
AA
18972012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1898
1899 Implement wave-style variant of underlining.
1900 * dispextern.h (face_underline_type): New enum.
1901 (face): Add field for underline type.
1902 * nsterm.m (ns_draw_underwave): New function.
1903 (ns_draw_text_decoration): Use it.
1904 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1905 New functions.
1906 (x_draw_glyph_string): Use them.
1907 * xfaces.c (Qline, Qwave): New Lisp objects.
1908 (check_lface_attrs, merge_face_ref)
1053a871
SM
1909 (Finternal_set_lisp_face_attribute, realize_x_face):
1910 Handle wave-style underline face attributes.
9b0e3eba
AA
1911 * xterm.c (x_draw_underwave): New function.
1912 (x_draw_glyph_string): Use it.
1913
0fb52f11
JB
19142012-06-16 Juanma Barranquero <lekktu@gmail.com>
1915
1916 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1917 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1918 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1919 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1920 ($(BLD)/w32select.$(O)): Update dependencies.
1921
e5560ff7
AS
19222012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1923
1924 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1925 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1926 * character.c (_fetch_multibyte_char_p): Remove.
1927 * alloc.c: Include "character.h" before "buffer.h".
1928 * bidi.c: Likewise.
1929 * buffer.c: Likewise.
1930 * bytecode.c: Likewise.
1931 * callint.c: Likewise.
1932 * callproc.c: Likewise.
1933 * casefiddle.c: Likewise.
1934 * casetab.c: Likewise.
1935 * category.c: Likewise.
1936 * cmds.c: Likewise.
1937 * coding.c: Likewise.
1938 * composite.c: Likewise.
1939 * dired.c: Likewise.
1940 * dispnew.c: Likewise.
1941 * doc.c: Likewise.
1942 * dosfns.c: Likewise.
1943 * editfns.c: Likewise.
1944 * emacs.c: Likewise.
1945 * fileio.c: Likewise.
1946 * filelock.c: Likewise.
1947 * font.c: Likewise.
1948 * fontset.c: Likewise.
1949 * fringe.c: Likewise.
1950 * indent.c: Likewise.
1951 * insdel.c: Likewise.
1952 * intervals.c: Likewise.
1953 * keyboard.c: Likewise.
1954 * keymap.c: Likewise.
1955 * lread.c: Likewise.
1956 * macros.c: Likewise.
1957 * marker.c: Likewise.
1958 * minibuf.c: Likewise.
1959 * nsfns.m: Likewise.
1960 * nsmenu.m: Likewise.
1961 * print.c: Likewise.
1962 * process.c: Likewise.
1963 * regex.c: Likewise.
1964 * region-cache.c: Likewise.
1965 * search.c: Likewise.
1966 * syntax.c: Likewise.
1967 * term.c: Likewise.
1968 * textprop.c: Likewise.
1969 * undo.c: Likewise.
1970 * unexsol.c: Likewise.
1971 * w16select.c: Likewise.
1972 * w32fns.c: Likewise.
1973 * w32menu.c: Likewise.
1974 * window.c: Likewise.
1975 * xdisp.c: Likewise.
1976 * xfns.c: Likewise.
1977 * xmenu.c: Likewise.
1978 * xml.c: Likewise.
1979 * xselect.c: Likewise.
1980
2f07e6af
EZ
19812012-06-16 Eli Zaretskii <eliz@gnu.org>
1982
1053a871
SM
1983 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1984 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1985 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1986 row.
1987 (handle_face_prop): Use chunk-relative overlay string index when
1988 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1989 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1990 the rightmost. (Bug#11720)
2f07e6af 1991
29b83cec
AS
19922012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1993
1994 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1995 (CATEGORY_MEMBER): Enforce 1/0 value.
1996 * category.c (_temp_category_set): Remove.
1997
4c5501e9
EZ
19982012-06-16 Eli Zaretskii <eliz@gnu.org>
1999
2000 * window.c (Fdelete_other_windows_internal)
2001 (Fdelete_window_internal): Don't access frame's mouse highlight
2002 info of the initial frame. (Bug#11677)
2003
2b570124
PE
20042012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2005
e93864f9
PE
2006 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2007 Assume USE_2_TAGS_FOR_INTS.
2008 (xreload): Adjust $tagmask width to match recent lisp.h change.
2009
2b570124
PE
2010 Simplify lisp.h in minor ways that should not affect code.
2011 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2012 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2013 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2014 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2015 (INTTYPEBITS): New macro, for clarity.
2016 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2017 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2018 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2019 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2020 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2021
81755f69
JB
20222012-06-13 Juanma Barranquero <lekktu@gmail.com>
2023
2024 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2025
16192a57
GM
20262012-06-13 Glenn Morris <rgm@gnu.org>
2027
2028 * s/bsd-common.h (BSD4_3):
2029 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2030
646b5f55
AS
20312012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2032
2033 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2034 instead of union.
2035 (XLI, XIL): Define.
1053a871
SM
2036 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2037 Use them.
2038 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2039 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2040 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2041 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2042 * frame.c (delete_frame): Remove outdated comment.
2043 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2044 USE_LISP_UNION_TYPE.
2045 (Fw32_unregister_hot_key): Likewise.
2046 (Fw32_toggle_lock_key): Likewise.
2047 * w32menu.c (add_menu_item): Likewise.
2048 (w32_menu_display_help): Use XIL instead of checking
2049 USE_LISP_UNION_TYPE.
2050 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2051 (init_heap): Likewise.
2052 * w32term.c (w32_read_socket): Update comment.
2053
1d3823c9
GM
20542012-06-13 Glenn Morris <rgm@gnu.org>
2055
c62ff706
GM
2056 * s/usg5-4-common.h, src/s/unixware.h:
2057 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2058
1d3823c9
GM
2059 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2060
bfe3e0a2
PE
20612012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2064 * alloc.c (make_number) [!defined make_number]:
2065 Remove, as lisp.h always defines this now.
2066 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2067 (roundup_size): Verify that it is a power of 2.
2068 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2069 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2070 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2071 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2072 USE_LSB_TAG now is always defined to be either 0 or 1.
2073 All uses changed.
2074 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2075 code works fine either way, and efficiency is not a concern here,
2076 as the union type is for debugging, not for production.
2077 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2078 Use an inline function on all platforms when using the union type,
2079 since this is simpler and 'static inline' can be used portably
2080 within Emacs now.
2081 (LISP_INITIALLY_ZERO): New macro.
2082 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2083 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2084
45fa9c0f
GM
20852012-06-12 Glenn Morris <rgm@gnu.org>
2086
b4492cba
GM
2087 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2088
2089 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2090
45fa9c0f
GM
2091 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2092 Move BROKEN_SIGIO to configure.
2093
2094 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2095 Move NO_TERMIO to configure.
2096
0e25d334
CY
20972012-06-12 Chong Yidong <cyd@gnu.org>
2098
2099 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2100 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2101 MagickExportImagePixels is undefined.
2102
43682bb6
PE
21032012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 * image.c (imagemagick_load_image): Remove unused label.
2106
a9be7d2b
GM
21072012-06-11 Glenn Morris <rgm@gnu.org>
2108
2109 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2110 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2111 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2112 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2113
3017f87f
SM
21142012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2115
2116 * alloc.c (make_byte_code): New function.
2117 (Fmake_byte_code): Use it. Don't purify here.
2118 * lread.c (read1): Use it as well to avoid extra allocation.
2119
1b9b4cf4
CY
21202012-06-11 Chong Yidong <cyd@gnu.org>
2121
2122 * image.c (imagemagick_load_image): Implement transparency.
2123
95988fcf
AS
21242012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2125
2126 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2127 account for preceding backslashes. (Bug#11663)
2128
cd4eb164
CY
21292012-06-09 Chong Yidong <cyd@gnu.org>
2130
2131 * term.c: Support italics in capable terminals (Bug#9652).
2132 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2133 (turn_on_face): Output using TS_enter_italic_mode if available.
2134 Don't handle unused blinking and alt-charset cases.
2135 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2136 and tty_alt_charset_p cases.
2137 (tty_capable_p, init_tty): Support italics.
2138
2139 * termchar.h (struct tty_display_info): Add field for italics.
2140 Remove unused blink field.
2141
2142 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2143 Handle slant.
2144
2145 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2146 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2147 tty_alt_charset_p. Add tty_italic_p.
2148
ff88beb8
MA
21492012-06-09 Michael Albinus <michael.albinus@gmx.de>
2150
2151 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2152 dbus_type_is_basic if available.
2153 (xd_extract_signed, xd_extract_unsigned): Rename from
2154 extract_signed and extract_unsigned, respectively. Adapt callers.
2155
44286096
CY
21562012-06-09 Chong Yidong <cyd@gnu.org>
2157
1682701f
CY
2158 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2159
44286096
CY
2160 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2161 case (Bug#9752).
2162
d86feb17
PE
21632012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 * xdisp.c (vmessage): Treat frame message as multibyte.
2166 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2167 would generate the diagnostic "Making \302\247 buffer-local while
2168 let-bound!".
2169
d5c20fe8
EZ
21702012-06-08 Eli Zaretskii <eliz@gnu.org>
2171
2172 * dispnew.c (showing_window_margins_p): Undo last change, which
2173 was done due to an inadvertent commit.
2174 (adjust_frame_glyphs_for_frame_redisplay): Do call
2175 showing_window_margins_p.
2176
513749ee
SM
21772012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2178
2179 * eval.c (Fmake_var_non_special): New primitive.
2180 (syms_of_eval): Defsubr it.
2181 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2182
d4a8f5c1
JB
21832012-06-08 Juanma Barranquero <lekktu@gmail.com>
2184
2185 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2186 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2187
8bbbc977
EZ
21882012-06-08 Eli Zaretskii <eliz@gnu.org>
2189
2190 * alloc.c (allocate_vectorlike): Fix last change.
2191
f3372c87
DA
21922012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2193
2194 Block-based vector allocation of small vectors.
2195 * lisp.h (struct vectorlike_header): New field `nbytes',
2196 adjust comment accordingly.
2197 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2198 to denote vector blocks. Adjust users (live_vector_p,
2199 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2200 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2201 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2202 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2203 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2204 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2205 (roundup_size): New constant.
2206 (struct vector_block): New data type.
2207 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2208 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2209 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2210 (sweep_vectors): New functions.
2211 (allocate_vectorlike): Return `zero_vector' as the only vector of
2212 0 items. Allocate new vector from block if vector size is less than
2213 or equal to VBLOCK_BYTES_MAX.
2214 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2215 (init_alloc_once): Add call to init_vectors.
2216
4f18a4ed
SM
22172012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2218
2219 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2220
86f158bc
PE
22212012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 * doprnt.c (doprnt): Truncate multibyte char correctly.
2224 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2225 would mishandle a string argument "Xc" if X was a multibyte
2226 character of length 2: it would truncate after X's first byte
2227 rather than including all of X.
2228
c5cfcbe0
CY
22292012-06-06 Chong Yidong <cyd@gnu.org>
2230
2231 * buffer.c (word_wrap): Doc fix.
2232
c05cf390
PE
22332012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2236
0c3461de
GM
22372012-06-03 Glenn Morris <rgm@gnu.org>
2238
2239 * xdisp.c (tool-bar-style): Doc fix.
2240
c71232db
UM
22412012-06-03 Ulrich Müller <ulm@gentoo.org>
2242
2243 * Makefile.in (PAXCTL): Define.
2244 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2245 binary via PaX flags if the paxctl utility is available.
2246 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2247 Restore PaX flags to their default. (Bug#11398)
2248
383f7350
CY
22492012-06-03 Chong Yidong <cyd@gnu.org>
2250
2251 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2252 buffer (Bug#11226).
2253
5f2c76c6
CY
22542012-06-03 Chong Yidong <cyd@gnu.org>
2255
2256 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2257 (note_mode_line_or_margin_highlight): If there is no help echo,
2258 use mode-line-default-help-echo. Handle the case where the mouse
2259 position is past the end of the mode line string.
2260
2261 * buffer.c (buffer_local_value_1): New function, split from
2262 Fbuffer_local_value; can return Qunbound.
2263 (Fbuffer_local_value): Use it.
2264 (Vmode_line_format): Docstring tweaks.
2265
773d47f6
PE
22662012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2267
2268 * sysdep.c (system_process_attributes): Improve comment.
2269
f2d6a3df
SM
22702012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2271
2272 * keyboard.c: Export real-this-command to Elisp.
2273 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2274 and DEFVAR it. Update all users.
2275
63810350
PE
22762012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2277
7bd5c1f4
PE
2278 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2279
63810350
PE
2280 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2281 Convert pctcpu and pctmem to Lisp float properly.
2282 Let the compiler fold better, as 100.0/0x8000 is exact.
2283
a2821611
AS
22842012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2285
2286 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2287 cons_block.
2288
5fceba1d
PE
22892012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2292
c98ff5dd
DA
22932012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2294
2295 For a 'struct window', replace some Lisp_Object fields to
2296 bitfields where appropriate, remove unused fields.
2297 * window.h (struct window): Remove unused 'last_mark_x' and
2298 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2299 change it's type from Lisp_Object to bitfield.
2300 Change type of 'force_start', 'optional_new_start',
2301 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2302 fields from Lisp_Object to bitfield. Adjust users accordingly.
2303
ca34e0be
PE
23042012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 Pacify gcc -Wdouble-precision when using Xaw.
2307 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2308 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2309 Use 'float' consistently, rather than 'float' in most places
2310 and 'double' in a couple of places.
2311
efc00ab1 23122012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2313
2314 * xdisp.c (handle_stop): Detect whether we have overlay strings
2315 loaded by testing it->current.overlay_string_index to be
2316 non-negative, instead of checking whether n_overlay_strings is
2317 positive. (Bug#11587)
2318
efc00ab1 23192012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2320
2321 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2322
2323 * doc.c (Fsubstitute_command_keys): Doc fix.
2324
efc00ab1 23252012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2326
2327 * search.c (search_buffer): Remove calls to
2328 r_alloc_inhibit_buffer_relocation, as it is now called by
2329 maybe_unify_char, which was the cause of relocation of buffer text
2330 in bug#11519.
2331
efc00ab1 23322012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2333
2334 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2335 for the duration of call to load_charset, to avoid problems with
2336 callers of maybe_unify_char that access buffer text through C
2337 pointers.
2338
2339 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2340 decrement the inhibition flag, instead of just setting or
2341 resetting it.
2342
ba93a187
PE
23432012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2344
2345 Remove obsolete '#define static' cruft.
2346 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2347 This #undef was "temporary" in 2000; it is no longer needed
2348 now that '#define static' has gone away.
2349 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2350 (gray_bitmap_bits): Remove; no longer needed.
2351 All uses replaced with definiens.
2352 * xterm.c: Include "bitmaps/gray.xbm".
2353
9e4bf381
PE
23542012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 Clean up __executable_start, monstartup when --enable-profiling.
2357 The following changes affect the code only when profiling.
2358 * dispnew.c (__executable_start): Rename from safe_bcopy.
2359 Define only on platforms that need it.
2360 * emacs.c: Include <sys/gmon.h> when profiling.
2361 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2362 (__executable_start): Remove decl, since lisp.h does it now.
2363 (safe_bcopy): Remove decl; no longer has that name.
2364 (main): Coalesce #if into single bit of code, for simplicity.
2365 Cast pointers to uintptr_t, since standard libraries want integers
2366 and not pointers.
2367 * lisp.h (__executable_start): New decl.
2368
32d72c2f
GM
23692012-05-31 Glenn Morris <rgm@gnu.org>
2370
2371 * image.c (Fimagemagick_types): Doc fix.
2372
baac5bc7
JM
23732012-05-30 Jim Meyering <meyering@redhat.com>
2374
2375 * callproc.c (Fcall_process_region): Include directory component
2376 in mkstemp error message (Bug#11586).
2377
72cb32cf
PE
23782012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 * alloc.c, lisp.h (make_pure_vector): Now static.
2381
61b108cc
SM
23822012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2383
2384 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2385 Move to byte-run.el.
2386 (Fautoload): Do the hash-doc more carefully.
2387 * data.c (Fdefalias): Purify definition, except for keymaps.
2388 (Qdefun): Move from eval.c.
2389 * lisp.h (Qdefun): Remove.
2390 * lread.c (read1): Tiny simplification.
2391
471fe23d
TN
23922012-05-29 Troels Nielsen <bn.troels@gmail.com>
2393
934f3f58 2394 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2395 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2396 Bug#9642, but explicitly check that the buffer the overlay would
2397 be moved to is live and rearrange lines to make sure that errors
2398 will not put the overlay in an inconsistent state.
2399 (Fdelete_overlay): Cosmetics.
2400
85d0efd1
EZ
24012012-05-28 Eli Zaretskii <eliz@gnu.org>
2402
2403 * w32term.c (my_bring_window_to_top): New function.
2404 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2405 could be different from the original one.
2406 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2407 (Bug#11513)
2408
2409 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2410 by calling BringWindowToTop.
2411
2412 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2413 (WM_EMACS_END): Increase by one.
2414
da92a98c
PE
24152012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2418 This avoids undefined behavior that might cause the eassert
2419 to not catch an out-of-range value.
2420
74d1f848
JB
24212012-05-28 Juanma Barranquero <lekktu@gmail.com>
2422
2423 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2424 Update dependencies.
2425
9e1a06fc
EZ
24262012-05-27 Eli Zaretskii <eliz@gnu.org>
2427
2428 * bidi.c (bidi_mirror_char): Fix last change.
2429
f3dd7312
AS
24302012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2431
2432 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2433 when referring to sectname field in printf format.
2434
81899c91
PE
24352012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2436
57b81a9f
PE
2437 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2438 Only r_alloc_inhibit_buffer_relocation needed to be added;
2439 the others were already declared.
2440
81899c91
PE
2441 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2442 before checking whether it's out of range. Put the check inside
2443 eassert. See
2444 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2445
33017faf 24462012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2447
2448 * callproc.c (Fcall_process): Restore a line that was accidentally
2449 commented out in the 2011-02-13 change (bug#11547).
2450
33017faf 24512012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2452
2453 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2454 defined on ralloc.c.
2455
2456 * buffer.c [REL_ALLOC]: Remove prototypes of
2457 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2458 they are now on lisp.h.
2459
2460 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2461
2462 * search.c (search_buffer): Use it to inhibit relocation of buffer
2463 text while re_search_2 is doing its job, because re_search_2 is
2464 passed C pointers to buffer text. (Bug#11519)
2465
23415acf
EZ
2466 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2467 Update value to 24.
2468
44e27368
EZ
2469 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2470 state after an additional call to move_it_in_display_line_to, keep
2471 the values of it->max_ascent and it->max_descent found for the
2472 entire line.
2473 (pos_visible_p): Revert the comparison against bottom_y to what it
2474 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2475 (Bug#11464)
2476
c1892f11
PE
24772012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2478
2479 Fix coding-related core dumps with gcc -ftrapv.
2480 The code was computing A - B, where A and B are pointers, and B is
2481 random garbage. This can lead to core dumps on platforms that
2482 have special pointer registers, and it also leads to core dumps on
2483 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2484 A - B only when B is initialized properly.
2485 * coding.c (coding_set_source, coding_set_destination): Return void.
2486 (coding_change_source, coding_change_destinations): New functions,
2487 with the old behaviors of coding_set_source and coding_set_destination.
2488 All callers that need an offset changed to use these new functions.
2489
eb7afdad
GM
24902012-05-26 Glenn Morris <rgm@gnu.org>
2491
2492 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2493
f12fdf02
EZ
24942012-05-26 Eli Zaretskii <eliz@gnu.org>
2495
53a63be6 2496 Extend mouse support on W32 text-mode console.
61b108cc
SM
2497 * xdisp.c (draw_row_with_mouse_face):
2498 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2499
eb3f6f01 2500 * w32console.c: Include window.h.
61b108cc
SM
2501 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2502 New functions.
eb3f6f01
EZ
2503 (initialize_w32_display): Initialize mouse-highlight data.
2504
53a63be6
EZ
2505 * w32inevt.c: Include termchar.h and window.h.
2506 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2507 moves, call note_mouse_highlight. If help_echo changed, call
2508 gen_help_event to produce help-echo message in the echo area.
2509 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2510 highlight info.
2511
4cfd81f6
PE
25122012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2513
2514 * lread.c (read1): Simplify slightly to avoid an overflow warning
2515 with GCC 4.7.0 on x86-64.
2516
4446092a
EZ
25172012-05-26 Eli Zaretskii <eliz@gnu.org>
2518
2519 * bidi.c (bidi_mirror_char): Revert last change: an int is
2520 definitely wide enough here.
2521
42b2a986 25222012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2523
42b2a986 2524 Fix integer width and related bugs (Bug#9874).
eb106a49 2525 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2526 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2527 (string_bytes, check_sblock, allocate_string_data):
2528 (compact_small_strings, Fmake_bool_vector, make_string)
2529 (make_unibyte_string, make_multibyte_string)
2530 (make_string_from_bytes, make_specified_string)
2531 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2532 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2533 (mark_vectorlike):
2534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2535 (allocate_pseudovector):
2536 Use int, not EMACS_INT, where int is wide enough.
2537 (inhibit_garbage_collection, Fgarbage_collect):
2538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2539 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2540 int might not be wide enough.
2541 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2542 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2543 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2544 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2545 (bidi_level_of_next_char, bidi_move_to_visually_next):
2546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2547 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2548 (Fkill_buffer, Fset_buffer_major_mode)
2549 (advance_to_char_boundary, Fbuffer_swap_text)
2550 (Fset_buffer_multibyte, overlays_at, overlays_in)
2551 (overlay_touches_p, struct sortvec, record_overlay_string)
2552 (overlay_strings, recenter_overlay_lists)
2553 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2554 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2555 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2556 (Foverlay_recenter, last_overlay_modification_hooks_used)
2557 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2559 (validate_region): Omit unnecessary test for b <= e,
2560 since that's guaranteed by the previous test.
d311d28c
PE
2561 (adjust_overlays_for_delete): Avoid pos + length overflow.
2562 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2563 (report_overlay_modification):
2564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2565 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2566 Omit pointer cast, which isn't needed anyway, and doesn't work
2567 after the EMACS_INT -> ptrdiff_t change.
02481186 2568 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2569 * buffer.h: Adjust decls to match defn changes elsewhere.
2570 (struct buffer_text, struct buffer):
2571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2572 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2573 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2574 not int, to avoid needless 32-bit limit on 64-bit hosts.
2575 (exec_byte_code): Use tighter memory-full test, one that checks
2576 for alloca overflow. Don't compute the address of the object just
2577 before an array, as that's not portable. Use EMACS_INT, not
2578 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2579 * callint.c (Fcall_interactively):
2580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2581 * callproc.c (call_process_kill, Fcall_process):
2582 Don't assume pid_t fits into an Emacs fixnum.
2583 (call_process_cleanup, Fcall_process, child_setup):
2584 Don't assume pid_t fits into int.
2585 (call_process_cleanup, Fcall_process, delete_temp_file)
2586 (Fcall_process_region):
2587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2588 (Fcall_process): Simplify handling of volatile integers.
2589 Use int, not EMACS_INT, where int will do.
2590 * casefiddle.c (casify_object, casify_region, operate_on_word)
2591 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2593 (casify_object): Avoid integer overflow when overallocating buffer.
2594 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2595 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2596 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2597 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2598 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2599 integers are now checked earlier. All uses replaced with XINT.
2600 (ccl_driver):
2601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2602 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2603 (ccl_driver, Fregister_code_conversion_map):
2604 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2605 (resolve_symbol_ccl_program): Check that vector header is in range.
2606 Always copy the vector, so that we can check its contents reliably
2607 now rather than having to recheck each instruction as it's being
2608 executed. Check that vector words fit in 'int'.
2609 (ccl_get_compiled_code, Fregister_ccl_program)
2610 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2611 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2612 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2613 contents are in range.
2614 (Fccl_execute_on_string): Check that status is in range.
2615 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2616 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2617 Accept and return EMACS_INT, not int, because callers can pass values
2618 out of 'int' range.
2619 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2620 (multibyte_chars_in_text, parse_str_as_multibyte)
2621 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2622 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2623 (string_escape_byte8, Fget_byte):
2624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2625 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2626 avoid mishandling large integers.
2627 * character.h: Adjust decls to match defn changes elsewhere.
2628 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2629 (Ffind_charset_region):
2630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2631 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2632 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2633 Don't assume fixnum fits in int.
d311d28c
PE
2634 (load_charset_map_from_vector, Fmap_charset_chars):
2635 Remove now-unnecessary CHECK_NATNUMs.
2636 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2637 Don't rely on undefined behavior with signed left shift overflow.
2638 Don't assume unsigned int fits into fixnum, or that fixnum fits
2639 into unsigned int. Don't require max_code to be a valid fixnum;
2640 that's not true for gb10830 4-byte on a 32-bit host. Allow
2641 invalid_code to be a cons, for the same reason. Require code_offset
2642 to be a character. Avoid int overflow if max_char is close
2643 to INT_MAX.
2644 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2645 this is intended anyway and avoids some undefined behavior.
2646 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2647 INDEX_TO_CODE_POINT, as that's what it expects.
2648 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2649 * charset.h (DECODE_CHAR): Return int, not unsigned;
2650 this is what was intended anyway, and it avoids undefined behavior.
2651 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2652 integer-overflow issues.
2653 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2654 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2655 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2656 * chartab.c (Fmake_char_table, Fset_char_table_range)
2657 (uniprop_get_decoder, uniprop_get_encoder):
2658 Don't assume fixnum fits in int.
2659 * cmds.c (move_point): New function, that does the gist of
2660 Fforward_char and Fbackward_char, but does so while checking
2661 for integer overflow more accurately.
c96e5d6a 2662 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2663 (Fforward_line, Fend_of_line, internal_self_insert)
2664 (internal_self_insert):
2665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2666 Fix a FIXME, by checking for integer overflow when calculating
2667 target_clm and actual_clm.
2668 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2669 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2670 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2671 (coding_alloc_by_making_gap, alloc_destination)
2672 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2673 (encode_coding_utf_16, detect_coding_emacs_mule)
2674 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2675 (detect_coding_iso_2022, decode_coding_iso_2022)
2676 (encode_invocation_designation, encode_designation_at_bol)
2677 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2678 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2679 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2680 (encode_coding_ccl, encode_coding_raw_text)
2681 (detect_coding_charset, decode_coding_charset)
2682 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2683 (produce_composition, produce_charset, produce_annotation)
2684 (decode_coding, handle_composition_annotation)
2685 (handle_charset_annotation, consume_chars, decode_coding_gap)
2686 (decode_coding_object, encode_coding_object, detect_coding_system)
2687 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2688 (code_convert_region, code_convert_string)
8f50130c
PE
2689 (Fdefine_coding_system_internal)
2690 (coding_set_source, coding_set_destination):
d311d28c
PE
2691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2692 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2693 (Fdefine_coding_system_internal):
2694 Don't assume fixnums fit in int.
2695 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2696 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2697 (Funencodable_char_position, Fcheck_coding_systems_region)
2698 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2700 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2701 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2702 Don't access memory outside of the args array.
d311d28c 2703 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2704 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2705 result of ENCODE_CHAR.
d311d28c
PE
2706 * coding.h: Adjust decls to match defn changes elsewhere.
2707 (struct coding_system):
2708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2709 * composite.c (get_composition_id, find_composition)
2710 (run_composition_function, update_compositions)
2711 (compose_text, composition_gstring_put_cache)
2712 (composition_gstring_p, composition_gstring_width)
2713 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2714 (composition_compute_stop_pos, composition_reseat_it)
2715 (composition_update_it, struct position_record)
2716 (find_automatic_composition, composition_adjust_point)
2717 (Fcomposition_get_gstring, Ffind_composition_internal):
2718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2719 (update_compositions):
2720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2721 * composite.h: Adjust decls to match defn changes elsewhere.
2722 (struct composition):
2723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2724 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2725 Do not attempt to compute the address of the object just before a
2726 buffer; this is not portable.
2727 (Faref, Faset):
2728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2729 (Faset): Use int, not EMACS_INT, where int is wide enough.
2730 (Fstring_to_number): Don't assume fixnums fit in int.
2731 (Frem): Don't assume arg is nonnegative.
2732 * dbusbind.c (xd_append_arg): Check for integers out of range.
2733 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2734 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2735 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2736 (xd_get_connection_references): Return ptrdiff_t, not int.
2737 All uses changed.
2738 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2739 (xd_read_message_1):
2740 Use int, not unsigned, where the dbus API uses int.
2741 (Fdbus_message_internal): Don't overflow mtype.
2742 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2743 * dired.c (directory_files_internal, file_name_completion, scmp)
2744 (file_name_completion_stat):
2745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2746 (file_name_completion): Don't overflow matchcount.
2747 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2748 * dispextern.h: Adjust decls to match defn changes elsewhere.
2749 (struct text_pos, struct glyph, struct bidi_saved_info)
2750 (struct bidi_string_data, struct bidi_it, struct composition_it)
2751 (struct it):
2752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2753 (struct display_pos, struct composition_it, struct it):
2754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2755 * dispnew.c (increment_matrix_positions)
2756 (increment_row_positions, mode_line_string)
2757 (marginal_area_string):
2758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2759 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2761 (duration_to_sec_usec): New function, to check for overflow better.
2762 (Fsleep_for, sit_for): Use it.
2763 * doc.c (get_doc_string, store_function_docstring):
2764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2765 (get_doc_string, Fsnarf_documentation):
2766 Use int, not EMACS_INT, where int is wide enough.
2767 (get_doc_string):
2768 Use SAFE_ALLOCA, not alloca.
2769 Check for overflow when converting EMACS_INT to off_t.
2770 * doprnt.c (doprnt):
2771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2772 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2773 Don't assume uid_t fits into fixnum.
2774 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2775 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2776 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2777 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2778 (general_insert_function)
2779 (Finsert_char, make_buffer_string, make_buffer_string_both)
2780 (update_buffer_properties, Fbuffer_substring)
2781 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2782 (Fsubst_char_in_region, check_translation)
2783 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2784 (transpose_markers, Ftranspose_regions):
2785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2786 (clip_to_bounds): Move to lisp.h as an inline function).
2787 (Fconstrain_to_field): Don't assume integers are nonnegative.
2788 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2789 (Fsubst_char_in_region, Fsave_restriction):
2790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2791 (Femacs_pid): Don't assume pid_t fits into fixnum.
2792 (lo_time): Use int, not EMACS_INT, when int suffices.
2793 (lisp_time_argument): Check for usec out of range.
2794 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2795 (Fuser_login_name, Fuser_full_name): Signal an error
2796 if a uid argument is out of range, rather than relying on
2797 undefined behavior.
c8d5c857
PE
2798 (Fformat_time_string): Remove now-unnecessary check.
2799 lisp_time_argument checks for out-of-range usec now.
243e0530 2800 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2801 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2802 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2803 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2804 (init_cmdargs, Fdump_emacs):
2805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2806 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2807 the bottom (typically) 32 bits of the fixnum.
2808 * eval.c (specpdl_size, call_debugger):
2809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2810 (when_entered_debugger, Fbacktrace_debug):
2811 Don't assume fixnum can fit in int.
2812 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2813 the object just before a buffer; this is not portable.
2814 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2815 (grow_specpdl, unbind_to):
2816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2817 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2818 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2819 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2820 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2821 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2823 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2824 (a_write, e_write):
2825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2826 (Fcopy_file, non_regular_nbytes, read_non_regular)
2827 (Finsert_file_contents):
2828 Use int, not EMACS_INT, where int is wide enough.
2829 (READ_BUF_SIZE): Verify that it fits in int.
2830 (Finsert_file_contents): Check that counts are in proper range,
2831 rather than assuming fixnums fit into ptrdiff_t etc.
2832 Don't assume fixnums fit into int.
125b3835 2833 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2834 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2835 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2836 (string_char_to_byte, string_byte_to_char)
2837 (string_make_multibyte, string_to_multibyte)
2838 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2839 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2840 (substring_both, Fdelete, internal_equal, Ffillarray)
2841 (Fclear_string, mapcar1)
2842 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2843 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2844 (larger_vector, make_hash_table, maybe_resize_hash_table)
2845 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2846 (Fmaphash, secure_hash):
2847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2848 (concat): Check for string index and length overflow.
2849 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2850 (Frequire):
2851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2852 (larger_vector): New API (vec, incr_min, size_max) replaces old
2853 one (vec, new_size, init). This catches size overflow.
2854 INIT was removed because it was always Qnil.
2855 All callers changed.
2856 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2857 the upper bound on a hash table index size.
2858 (make_hash_table, maybe_resize_hash_table): Use it.
2859 (secure_hash): Computer start_byte and end_byte only after
2860 they're known to be in ptrdiff_t range.
2861 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2862 (Ffont_get_glyphs, Ffont_at):
2863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2864 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2865 (Flist_fonts, Fopen_font):
2866 Don't assume fixnum can fit in int.
2867 (check_gstring): Don't assume index can fit in int.
2868 (font_match_p): Check that fixnum is a character, not a nonnegative
2869 fixnum, since the later code needs to stuff it into an int.
2870 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2871 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2872 conversion overflow issues.
2873 (Fopen_font): Check for integer out of range.
2874 (Ffont_get_glyphs): Don't assume index can fit in int.
2875 * font.h: Adjust decls to match defn changes elsewhere.
2876 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2877 integer overflow.
2878 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2879 printmax_t, where ptrdiff_t is wide enough.
2880 (Finternal_char_font):
2881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2882 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2883 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2884 (Fset_frame_position, x_set_frame_parameters)
2885 (x_set_line_spacing, x_set_border_width)
2886 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2887 Check that fixnums are in proper range for system types.
2888 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2890 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2891 Use SAFE_ALLOCA_LISP, not alloca.
2892 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2893 intptr_t is wide enough.
2894 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2895 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2896 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2897 Check for fixnum out of range.
2898 * ftfont.c (ftfont_list): Don't assume index fits in int.
2899 Check that fixnums are in proper range for system types.
2900 (ftfont_shape_by_flt):
2901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2902 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2904 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2905 Check that fixnums are in proper range for system types.
2906 * gnutls.h: Adjust decls to match defn changes elsewhere.
2907 * gtkutil.c (xg_dialog_run):
2908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2909 (update_frame_tool_bar):
2910 Check that fixnums are in proper range for system types.
2911 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2912 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2913 * indent.c (last_known_column, last_known_column_point):
2914 (current_column_bol_cache):
2915 (skip_invisible, current_column, check_display_width):
2916 (check_display_width, scan_for_column, current_column_1)
2917 (Findent_to, Fcurrent_indentation, position_indentation)
2918 (indented_beyond_p, Fmove_to_column, compute_motion):
2919 (Fcompute_motion, Fvertical_motion):
2920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2921 (last_known_column_modified): Use EMACS_INT, not int.
2922 (check_display_width):
2923 (Fcompute_motion):
2924 Check that fixnums and floats are in proper range for system types.
2925 (compute_motion): Don't assume index or fixnum fits in int.
2926 (compute_motion, Fcompute_motion):
2927 Use int, not EMACS_INT, when it is wide enough.
2928 (vmotion): Omit local var start_hpos that is always 0; that way
2929 we don't need to worry about overflow in expressions involving it.
2930 * indent.h: Adjust decls to match defn changes elsewhere.
2931 (struct position):
2932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2933 Use int, not EMACS_INT, where int is wide enough.
2934 Remove unused members ovstring_chars_done and tab_offset;
2935 all uses removed.
2936 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2937 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2938 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2939 (make_gap, copy_text, insert, insert_and_inherit)
2940 (insert_before_markers, insert_before_markers_and_inherit)
2941 (insert_1, count_combining_before, count_combining_after)
2942 (insert_1_both, insert_from_string)
2943 (insert_from_string_before_markers, insert_from_string_1)
2944 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2945 (adjust_after_replace, adjust_after_insert, replace_range)
2946 (replace_range_2, del_range, del_range_1, del_range_byte)
2947 (del_range_both, del_range_2, modify_region)
2948 (prepare_to_modify_buffer, signal_before_change)
2949 (signal_after_change, Fcombine_after_change_execute):
2950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2951 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2952 (balance_an_interval, split_interval_right, split_interval_left)
2953 (find_interval, next_interval, update_interval)
2954 (adjust_intervals_for_insertion, delete_node, delete_interval)
2955 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2956 (static_offset_intervals, offset_intervals)
2957 (merge_interval_right, merge_interval_left, make_new_interval)
2958 (graft_intervals_into_buffer, temp_set_point_both)
2959 (temp_set_point, set_point, adjust_for_invis_intang)
2960 (set_point_both, move_if_not_intangible, get_property_and_range)
2961 (get_local_map, copy_intervals, copy_intervals_to_string)
2962 (compare_string_intervals, set_intervals_multibyte_1):
2963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2964 * intervals.h: Adjust decls to match defn changes elsewhere.
2965 (struct interval):
2966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2967 * keyboard.c (this_command_key_count, this_single_command_key_start)
2968 (before_command_key_count, before_command_echo_length, echo_now)
2969 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2970 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2971 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2972 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2974 (last_non_minibuf_size, last_point_position, echo_truncate)
2975 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2976 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2977 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2978 (stuff_buffered_input):
2979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2980 (last_auto_save, command_loop_1, read_char):
2981 Use EMACS_INT, not int, to avoid integer overflow.
2982 (record_char): Avoid overflow in total_keys computation.
2983 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2984 * keyboard.h: Adjust decls to match defn changes elsewhere.
2985 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2986 (Fkey_description, Fdescribe_vector, Flookup_key):
2987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2988 (click_position): New function, to check that positions are in range.
2989 (Fcurrent_active_maps):
2990 (describe_command):
2991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2992 (Faccessible_keymaps, Fkey_description):
2993 (preferred_sequence_p):
2994 Don't assume fixnum can fit into int.
2995 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2996 Check for integer overflow in size calculations.
2997 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2998 avoid mishandling large integers.
2999 * lisp.h: Adjust decls to match defn changes elsewhere.
3000 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3001 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3002 (struct Lisp_Marker):
3003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3004 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3005 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3006 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3007 All callers changed.
3008 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3009 Assume the arg has valid form, since it always does.
3010 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3011 unsigned integer system type.
3012 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3013 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3015 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3016 (duration_to_sec_usec): New decl.
3017 * lread.c (read_from_string_index, read_from_string_index_byte)
3018 (read_from_string_limit, readchar, unreadchar, openp)
3019 (read_internal_start, read1, oblookup):
3020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3021 (Fload, readevalloop, Feval_buffer, Feval_region):
3022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3023 (openp): Check for out-of-range argument to 'access'.
3024 (read1): Use int, not EMACS_INT, where int is wide enough.
3025 Don't assume fixnum fits into int.
6efdadfd 3026 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3027 (read_filtered_event): Use duration_to_sec_usec
3028 to do proper overflow checking on durations.
d311d28c
PE
3029 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3030 in size calculation.
3031 (Fexecute_kbd_macro):
3032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3033 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3034 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3035 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3036 (set_marker_both, set_marker_restricted_both, marker_position)
3037 (marker_byte_position, Fbuffer_has_markers_at):
3038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3039 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3040 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3041 It now merely ensures that the menu is large enough, without
3042 necessarily growing it, as this avoids some integer overflow issues.
3043 All callers changed.
3044 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3045 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3046 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3047 Use SAFE_ALLOCA_LISP, not alloca.
3048 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3049 to EMACS_INT. Check that fixnums are in proper range for system types.
3050 * minibuf.c (minibuf_prompt_width, string_to_object)
3051 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3052 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3054 (get_minibuffer, read_minibuf_unwind):
3055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3056 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3057 this simplifies overflow checking. All callers changed.
3058 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3059 (Ftest_completion):
3060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3061 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3062 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3063 Check that fixnums are in proper range for system types.
3064 (Fx_create_frame, Fx_show_tip):
3065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3066 * nsfont.m (ns_findfonts, nsfont_list_family):
3067 Don't assume fixnum fits in long.
3068 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3070 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3071 wide enough.
17fdb222 3072 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3074 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3075 (PRINTDECLARE, PRINTPREPARE):
3076 (strout, print_string):
3077 (print, print_preprocess, print_check_string_charset_prop)
3078 (print_object):
3079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3080 (PRINTDECLARE):
3081 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3083 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3084 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3085 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3086 (print_error_message): Use SAFE_ALLOCA, not alloca.
3087 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3088 (print_depth, new_backquote_output, print_number_index):
3089 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3090 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3091 (Fset_process_window_size, Fformat_network_address)
3092 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3093 (sigchld_handler):
d311d28c 3094 Check that fixnums are in proper range for system types.
d44287d4 3095 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3096 Check for process-ids out of pid_t range rather than relying on
3097 undefined behavior.
e4d81efc 3098 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3099 (Fformat_network_address, read_process_output, send_process)
3100 (Fprocess_send_region, status_notify):
3101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3102 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3103 (wait_reading_process_output, read_process_output, exec_sentinel):
3104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3105 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3106 (Faccept_process_output): Use duration_to_sec_usec to do proper
3107 overflow checking on durations.
dde14581
PE
3108 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3109 Don't assume pid_t fits in int.
02481186
PE
3110 * process.h (struct Lisp_Process): Members tick and update_tick
3111 are now of type EMACS_INT, not int.
b62b53e8
PE
3112 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3113 configured --with-wide-int.
d311d28c
PE
3114 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3115 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3116 * search.c (looking_at_1, string_match_1):
3117 (fast_string_match, fast_c_string_match_ignore_case)
3118 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3119 (scan_newline, find_before_next_newline, search_command)
3120 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3121 (set_search_regs, wordify):
3122 (Freplace_match):
3123 (Fmatch_data):
3124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3125 (string_match_1, search_buffer, set_search_regs):
3126 (Fmatch_data):
3127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3128 (wordify): Check for overflow in size calculation.
3129 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3130 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3131 Check that fixnums are in proper range for system types.
3132 * sound.c (struct sound_device)
3133 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3135 (Fplay_sound_internal):
3136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3137 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3138 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3139 (Fparse_partial_sexp):
3140 Don't assume fixnums can fit in int.
3141 (struct lisp_parse_state, find_start_pos, find_start_value)
3142 (find_start_value_byte, find_start_begv)
3143 (update_syntax_table, char_quoted, dec_bytepos)
3144 (find_defun_start, prev_char_comend_first, back_comment):
3145 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3146 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3148 (Finternal_describe_syntax_value): Check that match_lisp is a
3149 character, not an integer, since the code stuffs it into int.
3150 (scan_words, scan_sexps_forward):
3151 Check that fixnums are in proper range for system types.
3152 (Fforward_word):
3153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3154 (scan_sexps_forward):
3155 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3156 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3157 * syntax.h: Adjust decls to match defn changes elsewhere.
3158 (struct gl_state_s):
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3160 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3161 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3162 * sysdep.c (wait_for_termination_1, wait_for_termination)
3163 (interruptible_wait_for_termination, mkdir):
3164 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3165 (emacs_read, emacs_write):
3166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3167 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3168 and double all fit in int.
d311d28c
PE
3169 * term.c (set_tty_color_mode):
3170 Check that fixnums are in proper range for system types.
3171 * termhooks.h (struct input_event):
3172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3173 * textprop.c (validate_interval_range, interval_of)
3174 (Fadd_text_properties, set_text_properties_1)
3175 (Fremove_text_properties, Fremove_list_of_text_properties)
3176 (Ftext_property_any, Ftext_property_not_all)
3177 (copy_text_properties, text_property_list, extend_property_ranges)
3178 (verify_interval_modification):
3179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3180 (Fnext_single_char_property_change)
3181 (Fprevious_single_char_property_change):
3182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3183 (copy_text_properties):
3184 Check for integer overflow in index calculation.
d311d28c
PE
3185 * undo.c (last_boundary_position, record_point, record_insert)
3186 (record_delete, record_marker_adjustment, record_change)
3187 (record_property_change):
3188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3189 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3191 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3192 (Fx_hide_tip, Fx_file_dialog):
3193 * w32menu.c (set_frame_menubar):
3194 Use ptrdiff_t, not int, for consistency with rest of code.
3195 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3196 (select_window, Fdelete_other_windows_internal)
3197 (window_scroll_pixel_based, window_scroll_line_based)
3198 (Frecenter, Fset_window_configuration):
3199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3200 (Fset_window_hscroll, run_window_configuration_change_hook)
3201 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3202 (Fscroll_other_window, Frecenter):
d311d28c
PE
3203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3204 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3205 Don't assume fixnum fits in int.
3206 (Fset_window_scroll_bars):
3207 Check that fixnums are in proper range for system types.
3208 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3209 (string_pos, c_string_pos, number_of_chars, init_iterator)
3210 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3211 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3212 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3213 (face_before_or_after_it_pos, handle_invisible_prop)
3214 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3215 (display_prop_intangible_p, string_buffer_position_lim)
3216 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3217 (get_overlay_strings_1, get_overlay_strings)
3218 (iterate_out_of_display_property, forward_to_next_line_start)
3219 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3220 (get_next_display_element, set_iterator_to_next)
3221 (get_visually_first_element, compute_stop_pos_backwards)
3222 (handle_stop_backwards, next_element_from_buffer)
3223 (move_it_in_display_line_to, move_it_in_display_line)
3224 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3225 (add_to_log, message_dolog, message_log_check_duplicate)
3226 (message2, message2_nolog, message3, message3_nolog
3227 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3228 (current_message_1, truncate_echo_area, truncate_message_1)
3229 (set_message, set_message_1, store_mode_line_noprop)
3230 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3231 (text_outside_line_unchanged_p, check_point_in_composition)
3232 (reconsider_clip_changes)
3233 (redisplay_internal, set_cursor_from_row, try_scrolling)
3234 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3235 (redisplay_window, find_last_unchanged_at_beg_row)
3236 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3237 (trailing_whitespace_p, find_row_edges, display_line)
3238 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3239 (display_mode_element, store_mode_line_string)
3240 (pint2str, pint2hrstr, decode_mode_spec)
3241 (display_count_lines, display_string, draw_glyphs)
3242 (x_produce_glyphs, x_insert_glyphs)
3243 (rows_from_pos_range, mouse_face_from_buffer_pos)
3244 (fast_find_string_pos, mouse_face_from_string_pos)
3245 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3247 (safe_call, init_from_display_pos, handle_fontified_prop)
3248 (handle_single_display_spec, load_overlay_strings)
3249 (with_echo_area_buffer, setup_echo_area_for_printing)
3250 (display_echo_area, echo_area_display)
3251 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3252 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3253 (redisplay_window, dump_glyph_row, display_mode_line)
3254 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3255 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3257 (handle_single_display_spec, build_desired_tool_bar_string)
3258 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3259 (get_specified_cursor_type):
3260 Check that fixnums are in proper range for system types.
3261 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3262 (Flookup_image_map):
3263 Don't assume fixnums fit in int.
3264 (compare_overlay_entries):
3265 Avoid mishandling comparisons due to subtraction overflow.
3266 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3267 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3268 (handle_tool_bar_click):
3269 Use int, not unsigned, since we prefer signed and the signedness
3270 doesn't matter here.
3271 (get_next_display_element, next_element_from_display_vector):
3272 Use int, not EMACS_INT, when int is wide enough.
3273 (start_hourglass): Use duration_to_sec_usec to do proper
3274 overflow checking on durations.
3275 * xfaces.c (Fbitmap_spec_p):
3276 Check that fixnums are in proper range for system types.
3277 (compare_fonts_by_sort_order):
3278 Avoid mishandling comparisons due to subtraction overflow.
3279 (Fx_family_fonts, realize_basic_faces):
3280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3281 (Fx_family_fonts):
3282 Don't assume fixnum fits in int.
3283 Use SAFE_ALLOCA_LISP, not alloca.
3284 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3285 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3286 (face_at_buffer_position, face_for_overlay_string)
3287 (face_at_string_position):
3288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3289 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3290 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3291 (Fx_show_tip):
3292 Check that fixnums are in proper range for system types.
3293 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3294 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3296 (Fx_change_window_property): Don't assume fixnums fit in int.
3297 * xfont.c (xfont_chars_supported):
3298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3299 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3300 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3302 * xml.c (parse_region):
3303 * xrdb.c (magic_file_p):
3304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3305 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3306 (x_get_local_selection, x_reply_selection_request)
3307 (x_handle_selection_request, wait_for_property_change):
3308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3309 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3310 short is wide enough.
3311 (x_send_client_event): Don't assume fixnum fits in int.
3312 * xterm.c (x_x_to_emacs_modifiers):
3313 Don't assume EMACS_INT overflows nicely into int.
3314 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3315 may come from Lisp.
3316 (handle_one_xevent): NATNUMP can eval its arg twice.
3317 (x_connection_closed):
3318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3319 * xterm.h: Adjust decls to match defn changes elsewhere.
3320 (struct scroll_bar): Use struct vectorlike_header
3321 rather than rolling our own approximation.
3322 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3323
c6574eb5
GM
33242012-05-25 Glenn Morris <rgm@gnu.org>
3325
3326 * lisp.mk (lisp): Update for more files being compiled now.
3327
e8d32c7e
SM
33282012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3329
48def666
SM
3330 * lread.c: Remove `read_pure' which makes no difference.
3331 (read_pure): Remove var.
3332 (unreadpure): Remove function.
3333 (readevalloop): Don't call read_list with -1 flag.
3334 (read1, read_vector): Don't test read_pure any more.
3335 (read_list): Simplify.
3336
e8d32c7e
SM
3337 * fileio.c, character.h: Minor style tweaks.
3338
4b2addb7
DA
33392012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3340
3341 * window.h (clip_changed): Remove useless declaration.
3342
584461b2
JB
33432012-05-22 Juanma Barranquero <lekktu@gmail.com>
3344
3345 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3346 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3347
34374650
PE
33482012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 Remove src/m/*.
3351 This directory predates autoconf and is no longer needed nowadays.
3352 Move its few remaining bits of functionality to where they're needed.
3353 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3354 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3355 * m/template.h: Remove.
3356 * Makefile.in (M_FILE): Remove. All uses removed.
3357 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3358 * lisp.h (USE_LSB_TAG):
3359 * mem-limits.h (EXCEEDS_LISP_PTR):
3360 Use VAL_MAX, not VALBITS, in #if.
3361 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3362 (EMACS_UINT): Define unconditionally now.
3363 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3364 (BITS_PER_EMACS_INT): New constants, replacing
3365 what used to be in config.h, but not useful in #if.
3366 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3367 define them any more.
3368 (VAL_MAX): New macro.
3369 (VALMASK): Use it.
3370 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3371 BITS_PER_EMACS_INT, in #if.
3372 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3373 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3374 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3375 * s/ms-w32.h (DATA_START):
3376 Move here from removed file m/intel386.h.
3377 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3378 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3379
261cb4bb
PE
33802012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 Assume C89 or later.
3383 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3384 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3385 (xrealloc):
3386 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3387 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3388 * textprop.c, tparam.c (NULL): Remove.
3389 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3390 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3391 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3392 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3393 * xterm.c (input_signal_count): Assume volatile works.
3394
ff23cd9f
KB
33952012-05-21 Ken Brown <kbrown@cornell.edu>
3396
3397 * xgselect.c (xg_select): Fix first argument in call to 'select'
3398 (bug#11508).
3399
1b170bc6
KB
34002012-05-20 Ken Brown <kbrown@cornell.edu>
3401
3402 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3403 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3404
b2f4d39f
KB
34052012-05-19 Ken Brown <kbrown@cornell.edu>
3406
3407 * xfns.c (x_in_use): Remove `static' qualifier.
3408 * xterm.h (x_in_use): Declare.
3409 * xgselect.c: Include xterm.h.
3410 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3411 and `display_arg' (bug#9754).
3412
003fdae2
PE
34132012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3414
9232a6d9
PE
3415 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3416
003fdae2
PE
3417 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3418 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3419
784b56e2
EZ
34202012-05-18 Eli Zaretskii <eliz@gnu.org>
3421
3422 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3423
3424 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3425 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3426
3427 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3428 reference to image_cache->refcount.
3429 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3430
a0a79cde
JL
34312012-05-17 Juri Linkov <juri@jurta.org>
3432
3433 * search.c (Fword_search_regexp, Fword_search_backward)
3434 (Fword_search_forward, Fword_search_backward_lax)
3435 (Fword_search_forward_lax): Move functions to isearch.el
3436 (bug#10145, bug#11381).
3437
b0572523
PE
34382012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3439
3440 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3441
9660f5fc
SM
34422012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3443
3444 * lread.c (init_obarray): Declare Qt and Qnil as special.
3445
4374de83
GM
34462012-05-14 Glenn Morris <rgm@gnu.org>
3447
3448 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3449 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3450
dc44c39a
PE
34512012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3452
078c97cb
PE
3453 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3454
dc44c39a
PE
3455 * unexaix.c: Port to more-recent AIX compilers.
3456 (report_error, report_error_1, make_hdr, copy_sym)
3457 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3458 Make arguments const char *, not char *, to avoid violations of C
3459 standard and to fix some AIX warnings reported by Gilles Pion.
3460
e18afed7 34612012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3462
3463 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3464 already have overlays loaded.
3465 (handle_single_display_spec): Before returning without displaying
3466 fringe bitmap, synchronize the bidi iterator with the main display
3467 iterator, by calling iterate_out_of_display_property.
3468 (iterate_out_of_display_property): Detect buffer iteration by
3469 testing that it->string is a Lisp string.
3470 (get_next_display_element): When the current object is exhausted,
3471 and there's something on it->stack, call set_iterator_to_next to
3472 proceed with what's on the stack, instead of returning zero.
3473 (set_iterator_to_next): If called at the end of a Lisp string,
3474 proceed to consider_string_end without incrementing string
3475 position. Don't increment display vector index past the end of
3476 the display vector. (Bug#11417)
c8fb9dc6
EZ
3477 (pos_visible_p): Don't report a position visible when move_it_to
3478 stopped at the last line of window, which happens to be scanned
3479 backwards by the bidi iteration. (Bug#11464)
ac268e67 3480
e18afed7 34812012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3482
3483 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3484 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3485 are on a TTY, and thus unable to display on the fringes.
3486 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3487 so we need to signal to the caller that this is a "replacing"
3488 display spec. This fixes display when the spec is invalid or we
3489 are on a TTY.
3490
e18afed7 34912012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3492
3493 * unexaix.c (make_hdr): Fix typo in prototype.
3494 This bug broke the build on AIX. Problem reported by Gilles Pion.
3495
9d0a235a
MA
34962012-05-14 Michael Albinus <michael.albinus@gmx.de>
3497
3498 * keyboard.c (kbd_buffer_get_event): Read special events also in
3499 batch mode. (Bug#11415)
3500
9e6b06ed
GM
35012012-05-12 Glenn Morris <rgm@gnu.org>
3502
3503 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3504
c1a1d7a3
EZ
35052012-05-12 Eli Zaretskii <eliz@gnu.org>
3506
3507 * lisp.mk (lisp): Add newcomment.elc.
3508
3fe7cdc8
GM
35092012-05-12 Glenn Morris <rgm@gnu.org>
3510
3511 * Makefile.in (MKDIR_P): New, set by configure.
3512 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3513
53f7d2c0
PE
35142012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3515
3516 Remove unused function hourglass_started.
3517 * dispextern.h (hourglass_started):
3518 * w32fns.c (hourglass_started):
3519 * xdisp.c (hourglass_started): Remove.
3520
75aafb17
JB
35212012-05-10 Juanma Barranquero <lekktu@gmail.com>
3522
3523 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3524 Update dependencies.
3525
12959e8e
PE
35262012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3527
97107e2e
PE
3528 * xgselect.c (xg_select): Put maxfds+1 into a var.
3529 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3530
12959e8e
PE
3531 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3532
836d29b3
DA
35332012-05-10 Dave Abrahams <dave@boostpro.com>
3534
3535 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3536 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3537
5cb67954
MA
35382012-05-09 Michael Albinus <michael.albinus@gmx.de>
3539
3540 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3541 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3542 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3543 Initialize xd_registered_buses.
3544
3478ec45
PE
35452012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3546
b263a6b0
PE
3547 Untag more efficiently if USE_LSB_TAG.
3548 This is based on a proposal by YAMAMOTO Mitsuharu in
3549 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3550 For an admittedly artificial (nth 8000 longlist) benchmark on
3551 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3552 Emacs's overall text size by 1%.
3553 * lisp.h (XUNTAG): New macro.
3554 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3555 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3556 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3557 * eval.c (Fautoload):
3558 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3559 * frame.h (XFRAME): Use XUNTAG.
3560
3478ec45
PE
3561 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3562 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3563 Remove unportable assumptions about print widths of types like
3564 dbus_uint32_t.
3565 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3566 intptr_t when converting between pointer and integer, to avoid GCC
3567 warnings about wrong width.
3568
666b903b 35692012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3570
3571 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3572 stack for each reader_thread, instead of defaulting to 8MB
3573 determined by the linker. This avoids failures in creating
3574 subprocesses on Windows 7, see the discussion in this thread:
3575 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3576
b120cc17
JC
35772012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3578
3579 Fix up display of the *Minibuf-0* buffer in the mini window.
3580 * keyboard.c (read_char): Don't clear the echo area if there's no
3581 message to clear.
3582 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3583 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3584
9a4b36f8
MA
35852012-05-07 Michael Albinus <michael.albinus@gmx.de>
3586
3587 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3588 batch mode.
3589
e5f9458f
CY
35902012-05-06 Chong Yidong <cyd@gnu.org>
3591
3592 * lisp.mk (lisp): Update.
3593
eceeb5fc 35942012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3595
3596 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3597
71873e2b
SM
35982012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3599
3600 * data.c (PUT_ERROR): New macro.
3601 (syms_of_data): Use it. Add new error type `user-error'.
3602 * undo.c (user_error): New function.
3603 (Fprimitive_undo): Use it.
3604 * print.c (print_error_message): Adjust print style for `user-error'.
3605 * keyboard.c (user_error): New function.
3606 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3607
ab0fa4e4
PE
36082012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3609
3610 Do not limit current-time-string to years 1000..9999.
3611 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3612 (Fcurrent_time_string): Support any year that is supported by the
3613 underlying localtime representation. Don't use asctime, as it
3614 has undefined behavior for years outside the range -999..9999.
3615
7ed806a7
PE
36162012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 Fix race conditions involving setenv, gmtime, localtime, asctime.
3619 Without this fix, interrupts could mess up code that uses these
3620 nonreentrant functions, since setting TZ invalidates existing
3621 tm_zone or tzname values, and since most of these functions return
3622 pointers to static storage.
3623 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3624 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3625 Grow the critical sections to include not just invoking
3626 localtime/gmtime, but also accessing these functions' results
3627 including their tm_zone values if any, and any related TZ setting.
3628 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3629 so that the struct tm is saved in the critical section.
3630 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3631 motivated by the fact that memory allocation needs to be outside
3632 the critical section.
3633
0c16dfed
DA
36342012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3635
3636 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3637 with RESET_INTERVAL.
3638
3639 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3640 Remove duplicated buffer name initialization.
3641
3f83ace8
JM
36422012-05-02 Jim Meyering <jim@meyering.net>
3643
3644 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3645
c7b8541e
JM
3646 * xfns.c (x_window): Use xstrdup (Bug#11375).
3647
90207a15 36482012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3649
3650 * xdisp.c (pos_visible_p): If already at a newline from the
3651 display string before the 'while' loop, don't walk back the glyphs
3652 from it3.glyph_row. Solves assertion violation when the display
3653 string begins with a newline (egg.el). (Bug#11367)
3654
b593d6a9
AH
36552012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3656
3657 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3658 Move to simple.el.
3659
4737362e
GM
36602012-05-01 Glenn Morris <rgm@gnu.org>
3661
99cf43f9
GM
3662 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3663 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3664 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3665 All were removed before 23.1.
3666
9311dcff
GM
3667 * dispnew.c: Remove HAVE_LIBNCURSES test;
3668 it is always true on relevant platforms.
3669
4d5c6349
GM
3670 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3671 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3672
4737362e
GM
3673 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3674
74dd3a6b
AS
36752012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3676
3677 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3678 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3679 Remove.
3680
13c379ee
PE
36812012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 Do not avoid creating empty evaporating overlays (Bug#9642).
3684 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3685 That is, do not delete an evaporating overlay if it becomes
3686 empty after its bounds are adjusted to fit within its buffer.
3687 This fix caused other problems, and I'm reverting it until we get
3688 to the bottom of them.
3689
a8e7d6d7 36902012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3691
3692 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3693
a8e7d6d7 36942012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3695
3696 * xdisp.c (pos_visible_p): If the window start position is beyond
3697 ZV, start the display from buffer beginning. Prevents assertion
3698 violation in init_iterator when the minibuffer window is scrolled
3699 via the scroll bar.
3700
3701 * window.c (window_scroll_pixel_based): Likewise.
3702
a8e7d6d7 37032012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3704
3705 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3706
a8e7d6d7 37072012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3708
3709 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3710 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3711
a8e7d6d7 37122012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3713
b593d6a9
AH
3714 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3715 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3716
1c6900d9
EZ
37172012-04-26 Eli Zaretskii <eliz@gnu.org>
3718
4c3fa1d9
EZ
3719 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3720 display element, check also the underlying string or buffer
3721 character. (Bug#11341)
3722
1c6900d9
EZ
3723 * w32menu.c: Include w32heap.h.
3724 (add_menu_item): If the call to AppendMenuW (via
3725 unicode_append_menu) fails, disable Unicode menus only if we are
3726 running on Windows 9X/Me.
3727
42bf8205
AS
37282012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3729
3730 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3731 (xgetint): Add missing shift for LSB tags.
3732
b1bac16e
MR
37332012-04-24 Martin Rudalics <rudalics@gmx.at>
3734
3735 * keyboard.c (read_char): Don't wipe echo area for select window
3736 events: These might get delayed via `mouse-autoselect-window'
3737 (Bug#11304).
3738
d69621cc
JB
37392012-04-24 Juanma Barranquero <lekktu@gmail.com>
3740
3741 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3742 manipulation of :loaded-from data.
3743
02fd101b
JB
37442012-04-23 Juanma Barranquero <lekktu@gmail.com>
3745
3746 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3747 now a cons (bug#11311).
3748
888bec30
PE
37492012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3750
89a438bd
PE
3751 Do not create empty overlays with the evaporate property (Bug#9642).
3752 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3753 if it becomes empty after its bounds are adjusted to fit within
3754 its buffer. Without this fix, in a nonempty buffer (let ((o
3755 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3756 yields an empty overlay that has the evaporate property, which is
3757 not supposed to happen.
3758
1068fe4d
PE
3759 Fix minor GTK3 problems found by static checking.
3760 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3761 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3762 (struct _EmacsFixedClass, emacs_fixed_get_type):
3763 Move decls here from emacsgtkfixed.h, since they needn't be public.
3764 (emacs_fixed_get_type): Now static.
3765 (emacs_fixed_class_init): Omit unused local.
3766 (emacs_fixed_child_type): Remove; unused.
3767 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3768 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3769 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3770 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3771 (EMACS_FIXED_GET_CLASS): Remove; unused.
3772 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3773
888bec30
PE
3774 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3775 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3776
de85e130
PE
37772012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3778
d0baac98 3779 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3780 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3781 (__malloc_size_t, __malloc_ptrdiff_t):
3782 Remove. All uses removed, replaced by the definiens if needed,
3783 since we can assume C89 or better now.
3784 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3785 (protect_malloc_state, align, get_contiguous_space)
3786 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3787 (malloc_atfork_handler_child, malloc_enable_thread)
3788 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3789 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3790 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3791 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3792 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3793 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3794 Define using prototypes, not old style.
3795 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3796 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3797 (align): Don't assume that signed integer overflow wraps around.
3798 Omit unused local var.
3799 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3800 (_free_internal_nolock, memalign, mallochook, reallochook):
3801 Omit no-longer-needed casts.
3802 (valloc): Use getpagesize, not __getpagesize.
3803 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3804 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3805
de85e130
PE
3806 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3807
dcbf5805
MA
38082012-04-22 Michael Albinus <michael.albinus@gmx.de>
3809
3810 Move functions from C to Lisp. Make non-blocking method calls
3811 the default. Implement further D-Bus standard interfaces.
3812
3813 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3814 (QCdbus_request_name_allow_replacement)
3815 (QCdbus_request_name_replace_existing)
3816 (QCdbus_request_name_do_not_queue)
3817 (QCdbus_request_name_reply_primary_owner)
3818 (QCdbus_request_name_reply_in_queue)
3819 (QCdbus_request_name_reply_exists)
3820 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3821 (QCdbus_registered_serial, QCdbus_registered_method)
3822 (QCdbus_registered_signal): New Lisp objects.
3823 (XD_DEBUG_MESSAGE): Use sizeof.
3824 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3825 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3826 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3827 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3828 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3829 (xd_signature, xd_append_arg): Allow float for integer types.
3830 (xd_get_connection_references): New function.
b593d6a9
AH
3831 (xd_get_connection_address): Rename from xd_initialize.
3832 Return cached address.
dcbf5805
MA
3833 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3834 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3835 level.
3836 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3837 Return number of refcounts.
dcbf5805
MA
3838 (Fdbus_get_unique_name): Make stronger parameter check.
3839 (Fdbus_message_internal): New defun.
3840 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3841 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3842 (Fdbus_send_signal, Fdbus_register_service)
3843 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3844 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3845 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3846 (Vdbus_compiled_version, Vdbus_runtime_version)
3847 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3848 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3849 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3850 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3851 Adapt docstring.
dcbf5805 3852
52828e02
PE
38532012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3854
da05bc4c
PE
3855 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3856 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3857 Do not assume ptrdiff_t is the same width as 'int'.
3858
52828e02
PE
3859 * alloc.c: Handle unusual debugging option combinations.
3860 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3861 since the two debugging options are incompatible.
3862 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3863 is defined.
3864 (mem_init, mem_insert, mem_insert_fixup):
3865 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3866 (NEED_MEM_INSERT): Remove; no longer needed.
3867
f01769f9
LL
38682012-04-22 Leo Liu <sdl.web@gmail.com>
3869
3870 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3871
5790543d
PE
38722012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3873
3874 * sysdep.c [__FreeBSD__]: Minor cleanups.
3875 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3876 Use Emacs indenting style more consistently. Avoid some casts.
3877 Use 'double' consistently rather than mixing 'float' and 'double'.
3878
b91b7e4d
EW
38792012-04-21 Eduard Wiebe <usenet@pusto.de>
3880
b593d6a9
AH
3881 * sysdep.c (list_system_processes, system_process_attributes):
3882 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3883
6114eb15
AS
38842012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3885
3886 * lisp.mk (lisp): Update.
3887
2f38dff7
PE
38882012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3889
3890 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3891 It is never used otherwise.
3892
4ae29f89
SM
38932012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3894
3895 * print.c (print_preprocess): Only check print_depth if print-circle
3896 is nil.
3897 (print_object): Check for cycles even when print-circle is nil and
3898 print-gensym is t, but only check print_depth if print-circle is nil.
3899
f30d612a
CY
39002012-04-20 Chong Yidong <cyd@gnu.org>
3901
3902 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3903 set the status to "failed" and ensure that sentinel is run.
3904
c07a4c0b 39052012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3906
3907 * process.c (Fset_process_inherit_coding_system_flag)
3908 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3909 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3910
c07a4c0b 39112012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3912
3913 * xdisp.c (string_buffer_position_lim): Limit starting position to
3914 BEGV.
3915 (set_cursor_from_row): If called for a mode-line or header-line
3916 row, return zero immediately.
3917 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3918 farther than the first row after the header line, if any.
3919 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3920 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3921
c07a4c0b 39222012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3923
4ae29f89
SM
3924 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3925 (bug#11238).
ad3a2b41 3926
c07a4c0b 39272012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 39282012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3929
3930 configure: new option --enable-gcc-warnings (Bug#11207)
3931 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3932 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3933 (ALL_CFLAGS): Use new macros rather than old.
3934 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3935 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3936 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3937 -Wunused-result, -Wunused-variable. This should go away once
3938 the Emacs and Gnulib regex code is merged.
3939 (xmalloc, xrealloc): Now static.
3940
aba027e8
PE
39412012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 * dired.c (Fsystem_groups): Remove unused local.
3944
e5a36063
GM
39452012-04-17 Glenn Morris <rgm@gnu.org>
3946
3947 * dired.c (Fsystem_users): Doc fix.
3948
316411f0
DA
39492012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3950
3951 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3952 (syms_of_dired): Add them.
3953
9426aba4
PE
39542012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3955
b62a57be
PE
3956 Fix minor alloc.c problems found by static checking.
3957 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3958 New extern decls, to avoid calling undeclared functions.
3959 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3960 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3961 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3962 (NEED_MEM_INSERT): New macro.
3963 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3964 Remove one incorrect comment and fix another.
b62a57be 3965
3539f31f
PE
3966 Fix minor ralloc.c problems found by static checking.
3967 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3968 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3969 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3970 (r_alloc_sbrk): Now static.
3971
a041960a
PE
3972 Improve ralloc.c interface checking.
3973 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3974 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3975 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3976 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3977 [REL_ALLOC]: ... to here, to check interface.
3978 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3979 Remove decls. This fixes an "It stinks!".
3980
9426aba4
PE
3981 * alloc.c (which_symbols): Fix alignment issue / type clash.
3982
d55c12ed
AS
39832012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3984
3985 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3986 (struct Lisp_Misc_Any): Likewise.
3987 (struct Lisp_Free): Likewise.
3988 * alloc.c (union aligned_Lisp_Symbol): Define.
3989 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3990 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3991 (union aligned_Lisp_Misc): Define.
3992 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3993 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3994 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3995
b948ce8b
PE
39962012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3999 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4000 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4001 * s/netbsd.h, s/sol2-6.h:
4002 Remove definition of GC_MARK_STACK, since the default now works.
4003 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4004 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4005 no longer the default.
4006 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4007
35dc09a1 40082012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4009
35dc09a1
GM
4010 * lread.c (lisp_file_lexically_bound_p):
4011 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4012
35dc09a1
GM
40132012-04-14 Eli Zaretskii <eliz@gnu.org>
4014
4015 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4016 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4017
40182012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4019
4020 * nsterm.m (constrainFrameRect): Always constrain when there is only
4021 one screen (Bug#10962).
4022
bcd86815
KB
40232012-04-13 Ken Brown <kbrown@cornell.edu>
4024
4025 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4026
c25df26e
RT
40272012-04-13 Reuben Thomas <rrt@sc3d.org>
4028
4029 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4030
0fc59f1e
DC
40312012-04-11 Daniel Colascione <dancol@dancol.org>
4032
4033 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4034 against is gone. It's better to use vfork now so that when Cygwin
4035 gains a new, working vfork, we use it automatically (bug#10398).
4036
de8c03dc
SM
40372012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4038
4039 * window.c (save_window_save): Obey window-point-insertion-type.
4040
2f097256
GM
40412012-04-11 Glenn Morris <rgm@gnu.org>
4042
4043 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4044
453b951e
SM
40452012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4046
4047 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4048
75f1671a 40492012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4050
4051 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4052 (force_quit_count): New var.
4053 (handle_interrupt): Use it.
4054
2a8ce227
JB
40552012-04-10 Juanma Barranquero <lekktu@gmail.com>
4056
4057 * w32.c (w32_delayed_load): Record the full path of the library
4058 being loaded (bug#10424).
4059
935396c0
GM
40602012-04-09 Glenn Morris <rgm@gnu.org>
4061
05920a43
GM
4062 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4063 not just in the obarray, before snarfing them. (Bug#11036)
4064
935396c0
GM
4065 * Makefile.in ($(leimdir)/leim-list.el):
4066 Pass EMACS rather than BUILT_EMACS.
4067
a18ecafa
TZ
40682012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4069
4070 * process.c (make_process):
4071 * process.h: Add integer `gnutls_handshakes_tried' member to
4072 process struct.
4073
6bbef4e5
JC
4074 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4075 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4076
4077 * gnutls.c (gnutls_log_function2i): Convenience log function.
4078 (emacs_gnutls_read): Use new log functions,
4079 `gnutls_handshakes_tried' process member, and
4080 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4081 attempts per process (connection).
4082
b4d3bc10
CY
40832012-04-09 Chong Yidong <cyd@gnu.org>
4084
4085 * eval.c (Fuser_variable_p, user_variable_p_eh)
4086 (lisp_indirect_variable): Functions deleted.
4087 (Fdefvar): Caller changed.
4088
4089 * callint.c (Finteractive, Fcall_interactively):
4090 * minibuf.c (Fread_variable): Callers changed.
4091
70f4d973
EZ
40922012-04-09 Eli Zaretskii <eliz@gnu.org>
4093
4094 * xdisp.c (set_cursor_from_row): If the display string appears in
4095 the buffer at position that is closer to point than the position
4096 after the display string, display the cursor on the first glyph of
4097 the display string. Fixes cursor display when a 'display' text
4098 property immediately follows invisible text. (Bug#11094)
4099
cb3c2e3e
PE
41002012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4101
4102 composite.c: use 'double' consistently
4103 * composite.c (get_composition_id): Use 'double' consistently
4104 instead of converting 'float' to 'double' and vice versa; this is
4105 easier to understand and avoids a GCC warning.
4106
fd06db5d
GM
41072012-04-09 Glenn Morris <rgm@gnu.org>
4108
50fe702a
GM
4109 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4110 preparation for dumping it with emacs. (Bug#4789)
4111 (leimdir): New variable.
4112 ($(leimdir)/leim-list.el): New rule.
4113 (emacs$(EXEEXT)): Depend on leim-list.el.
4114
fd06db5d
GM
4115 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4116 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4117 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4118
55c131ee
AS
41192012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4120
4121 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4122 proper alignment.
4123
9209588f
JB
41242012-04-07 Juanma Barranquero <lekktu@gmail.com>
4125
4126 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4127 Remove unused local variable.
4128
e3fb2efb
PE
41292012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4132 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4133 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4134 objects, as mark_maybe_pointer will catch them otherwise.
4135 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4136 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4137
b5385551
PE
41382012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 Fix typo that broke non-Windows builds.
4141 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4142
9078ead6
EZ
41432012-04-07 Eli Zaretskii <eliz@gnu.org>
4144
4145 Support building on MS-Windows with libxml2.
4146
4147 * makefile.w32-in (OBJ2): Add xml.$(O).
4148 (GLOBAL_SOURCES): Add xml.c.
4149 ($(BLD)/xml.$(O)): New dependency list.
4150
4151 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4152 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4153 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4154 [!WINDOWSNT]: New macros.
4155 (init_libxml2_functions, libxml2_loaded_p): New functions.
4156 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4157 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4158 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4159 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4160 linked in).
6bbef4e5
JC
4161 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4162 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4163 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4164
4165 * emacs.c: Don't include libxml/parser.h.
4166 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4167 xmlCleanupParser directly.
4168
4169 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4170
3811fdf3
EZ
41712012-04-07 Eli Zaretskii <eliz@gnu.org>
4172
4173 * indent.c (Fvertical_motion): If there is a display string at
4174 point, use it.vpos to compute how many lines to backtrack after
4175 move_it_to point. (Bug#11133)
4176
2f8e16b2
EZ
41772012-04-06 Eli Zaretskii <eliz@gnu.org>
4178
4179 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4180 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4181 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4182 macros related to unification of CJK characters. For the details,
4183 see the discussion following the message here:
4184 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4185
3d439cd1
CY
41862012-04-04 Chong Yidong <cyd@gnu.org>
4187
4188 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4189
8bc53d00
EZ
41902012-04-01 Eli Zaretskii <eliz@gnu.org>
4191
4192 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4193 instead of alloca. (Bug#11138)
4194
3b0512a3
AS
41952012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4196
4197 * w32menu.c (is_simple_dialog): Properly check lisp types.
4198 (Bug#11141)
4199
8427ddd2
EZ
42002012-03-31 Eli Zaretskii <eliz@gnu.org>
4201
979022ef
EZ
4202 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4203 position we get to after a call to move_it_to fails the
4204 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4205 only if we wind up in a string from display property. (Bug#11063)
4206
a6b1c7cc
EZ
4207 * window.c (Fdelete_other_windows_internal): Invalidate the row
4208 and column information about mouse highlight, so that redisplay
4209 restores it after reallocating the glyph matrices. (Bug#7464)
4210
8427ddd2
EZ
4211 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4212 string comes from a `display' text property, use the buffer
4213 position of that property as if we actually saw that position in
4214 the row's glyphs.
697ba24b
EZ
4215 (move_it_by_lines): Remove the assertion that
4216 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4217 violated when there's a before-string at the beginning of a line.
4218 (Bug#11063)
8427ddd2 4219
65a0a738
EZ
42202012-03-30 Eli Zaretskii <eliz@gnu.org>
4221
4222 * xdisp.c (append_space_for_newline): If the default face was
4223 remapped, use the remapped face for the appended newline.
4224 (extend_face_to_end_of_line): Use the remapped default face for
4225 extending the face to the end of the line.
4226 (display_line): Call extend_face_to_end_of_line when the default
4227 face was remapped. (Bug#11068)
4228
581355cc
EZ
42292012-03-29 Eli Zaretskii <eliz@gnu.org>
4230
4231 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4232
e8fc049f
SM
42332012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4234
4235 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4236
4fb9a543
GM
42372012-03-27 Glenn Morris <rgm@gnu.org>
4238
4239 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4240 Doc fixes.
4241
679910f1
KH
42422012-03-26 Kenichi Handa <handa@m17n.org>
4243
4244 * dispextern.h (struct glyph): Fix previous change. Change the
4245 bit length of glyphless.ch to 25 (Bug#11082).
4246
90d49b7f
CY
42472012-03-26 Chong Yidong <cyd@gnu.org>
4248
4249 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4250 (command_loop_1): Use it; inhibit selection update for
4251 handle-select-window too (Bug#8996).
4252
f514f6f0
FP
42532012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4254
e8fc049f 4255 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4256
bf43fa51
KH
42572012-03-25 Kenichi Handa <handa@m17n.org>
4258
4259 * dispextern.h (struct glyph): Change the bit length of
4260 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4261
8a0c01dd
EZ
42622012-03-24 Eli Zaretskii <eliz@gnu.org>
4263
4264 * s/ms-w32.h (tzname): Include time.h before redirecting to
4265 _tzname. Fixes the MSVC build. (Bug#9960)
4266
7d1c3a76
AS
42672012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4268
8ed79523
AS
4269 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4270 characters.
4271
7d1c3a76
AS
4272 * xterm.c (XTread_socket): Only modify handling_signal if
4273 !SYNC_INPUT. (Bug#11080)
4274
e99a9b8b
EZ
42752012-03-23 Eli Zaretskii <eliz@gnu.org>
4276
4277 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4278 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4279 when fetching a multibyte character consumes more bytes than
4280 CHAR_BYTES returns, due to unification of CJK characters in
4281 string_char. (Bug#11073)
4282
5063c0e1
TN
42832012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4284
4285 * process.c (wait_reading_process_output): Handle pty disconnect
4286 by refraining from sending oneself a SIGCHLD (bug#10933).
4287
9f851fbd
CY
42882012-03-22 Chong Yidong <cyd@gnu.org>
4289
4290 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4291
5063c0e1 4292 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4293 Mark string as coming from a prefix property.
4294 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4295 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4296
fb5b8aca
CY
42972012-03-21 Chong Yidong <cyd@gnu.org>
4298
4299 * xfaces.c (Vface_remapping_alist): Doc fix.
4300
62356a1b
EZ
43012012-03-20 Eli Zaretskii <eliz@gnu.org>
4302
4303 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4304 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4305 Doc fixes.
62356a1b 4306
025de85b
CY
43072012-03-20 Chong Yidong <cyd@gnu.org>
4308
4309 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4310 to reflect default non-nil value of redisplay-dont-pause.
4311
4827f94e
KH
43122012-03-19 Kenichi Handa <handa@m17n.org>
4313
4314 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4315 it fit in a valid range (Bug#11003).
4316
e50a24a2
EZ
43172012-03-18 Eli Zaretskii <eliz@gnu.org>
4318
4319 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4320 that is not from display property, accept the row as a "cursor
4321 row" if one of the string's character has a non-nil `cursor'
4322 property. Fixes cursor positioning when there are newlines in
4323 overlay strings, e.g. in icomplete.el. (Bug#11035)
4324
9af5ed87
PE
43252012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4326
4327 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4328
d1f55f16
CY
43292012-03-12 Chong Yidong <cyd@gnu.org>
4330
4331 * eval.c (inhibit_lisp_code): Rename from
4332 inhibit_window_configuration_change_hook; move from window.c.
4333
4334 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4335 * window.c (run_window_configuration_change_hook)
4336 (syms_of_window): Callers changed.
4337
66c5eebd
CY
43382012-03-11 Chong Yidong <cyd@gnu.org>
4339
413df973
CY
4340 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4341
66c5eebd
CY
4342 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4343
1de11f56
CY
43442012-03-10 Chong Yidong <cyd@gnu.org>
4345
4346 * frame.c (other_visible_frames): Don't assume the selected frame
4347 is visible (Bug#10955).
4348
cae07000
SM
43492012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4350
4351 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4352
89c94350
JD
43532012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4354
4355 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4356 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4357 zero (Bug#10954).
4358
999dd333
GM
43592012-03-03 Glenn Morris <rgm@gnu.org>
4360
01a6dcc8 4361 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4362
de0100f2
EZ
43632012-03-02 Eli Zaretskii <eliz@gnu.org>
4364
4365 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4366 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4367 (redisplay_window, next_element_from_string): Fix typos in
4368 comments.
3e441275
EZ
4369 (redisplay_window): Pass to move_it_vertically the margin in
4370 pixels, not in screen lines.
de0100f2 4371
96a72ee9
GM
43722012-03-02 Glenn Morris <rgm@gnu.org>
4373
4374 * buffer.c (buffer-list-update-hook): Doc fix.
4375
312508d7
EZ
43762012-02-29 Eli Zaretskii <eliz@gnu.org>
4377
4378 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4379 push_it before setting up the iterator for the first overlay
4380 string, even if we have an empty string loaded.
4381 (next_overlay_string): If there's an empty string on the iterator
4382 stack, pop the stack. (Bug#10903)
4383
27f3c637
PE
43842012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4387 Suggested by Stefan Monnier in
4388 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4389 * alloc.c (widen_to_Lisp_Object): New static function.
4390 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4391 and widening them to Lisp_Objects. This would work even if
4392 USE_LSB_TAG is defined and wide integers are used, which might
4393 happen in a future version of Emacs.
4394
3c9dfce6
CY
43952012-02-25 Chong Yidong <cyd@gnu.org>
4396
fa74b241
CY
4397 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4398 Doc fix.
4399
3c9dfce6
CY
4400 * xselect.c (Fx_selection_exists_p): Doc fix.
4401 (x_clipboard_manager_save_all): Print an informative message
4402 before saving to clipboard manager.
4403
9486df08
CY
44042012-02-24 Chong Yidong <cyd@gnu.org>
4405
4406 * keyboard.c (process_special_events): Handle all X selection
4407 requests in kbd_buffer, not just the next one (Bug#8869).
4408
f01d3321
CY
44092012-02-23 Chong Yidong <cyd@gnu.org>
4410
4411 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4412 call when setting menu-bar-lines and tool-bar-lines parameters.
4413 (unwind_create_frame_1): New helper function.
4414
4415 * window.c (inhibit_window_configuration_change_hook): New var.
4416 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4417 (syms_of_window): Initialize it.
f01d3321 4418
86b847b6
CY
44192012-02-22 Chong Yidong <cyd@gnu.org>
4420
4421 * xterm.c (x_draw_image_relief): Add missing type check for
4422 Vtool_bar_button_margin (Bug#10743).
4423
a59225b1
CY
44242012-02-21 Chong Yidong <cyd@gnu.org>
4425
4426 * fileio.c (Vfile_name_handler_alist): Doc fix.
4427
4428 * buffer.c (Fget_file_buffer): Protect against invalid file
4429 handler return value.
4430
310f5bd4
PE
44312012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4432
cb3a28cc
PE
4433 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4434 when computing $valmask.
4435
310f5bd4
PE
4436 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4437 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4438 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4439 It's useless in that case, and it can cause problems on hosts
4440 that allocate halves of EMACS_INT values separately.
4441 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4442 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4443 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4444 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4445 it avoids undefined behavior on hosts where shifting right by more
4446 than the word width has undefined behavior.
4447
2375c96a
CY
44482012-02-19 Chong Yidong <cyd@gnu.org>
4449
4450 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4451 (Funhandled_file_name_directory, Ffile_name_as_directory)
4452 (Fdirectory_file_name, Fexpand_file_name)
4453 (Fsubstitute_in_file_name): Protect against invalid file handler
4454 return values (Bug#10845).
4455
3eb49e71
EZ
44562012-02-18 Eli Zaretskii <eliz@gnu.org>
4457
4458 * .gdbinit (pitx): Fix incorrect references to fields of the
4459 iterator stack.
4460
7b926f3f
CY
44612012-02-17 Chong Yidong <cyd@gnu.org>
4462
4463 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4464
11273115
PE
44652012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4466
4467 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4468 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4469
c3a70e2b
CY
44702012-02-15 Chong Yidong <cyd@gnu.org>
4471
4472 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4473 marked as special. Also, starting docstrings with * is obsolete.
4474
0ca43699
AS
44752012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4476
4477 * gnutls.c (emacs_gnutls_write): Fix last change.
4478
2e8f3c56
LI
44792012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4480
4481 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4482 send_process.
4483
af70074f
SM
44842012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4485
4486 * keymap.c (Fsingle_key_description): Handle char ranges.
4487
95986d52
CY
44882012-02-12 Chong Yidong <cyd@gnu.org>
4489
afd83bd1
CY
4490 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4491 as that creates a dangerous corner case.
4492
95986d52
CY
4493 * window.c (Fdelete_window_internal): Invalidate the mouse
4494 highlight (Bug#9904).
4495
bd7da63e
GM
44962012-02-12 Glenn Morris <rgm@gnu.org>
4497
4498 * xselect.c (Fx_own_selection_internal)
4499 (Fx_get_selection_internal, Fx_disown_selection_internal)
4500 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4501 * nsselect.m (Fx_own_selection_internal)
4502 (Fx_disown_selection_internal, Fx_selection_exists_p)
4503 (Fx_selection_owner_p, Fx_get_selection_internal):
4504 Sync docs and argument specs with the xselect.c versions.
4505
77abcbc2
LI
45062012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4507
4508 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4509
90b671e2
EZ
45102012-02-11 Eli Zaretskii <eliz@gnu.org>
4511
1c0ca0b7
EZ
4512 * w32select.c (Fx_selection_exists_p): Sync doc string and
4513 argument list with xselect.c. (Bug#10783)
4514
4515 * w16select.c (Fx_selection_exists_p): Sync doc string and
4516 argument list with xselect.c. (Bug#10783)
90b671e2 4517
49241268
GM
45182012-02-10 Glenn Morris <rgm@gnu.org>
4519
4520 * fns.c (Fsecure_hash): Doc fix.
4521
f998bbe7 45222012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4523
4524 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4525
0992bd9c
CY
45262012-02-07 Chong Yidong <cyd@gnu.org>
4527
4528 * buffer.c (Fbuffer_local_variables)
4529 (buffer_lisp_local_variables): Handle unbound vars correctly;
4530 don't let Qunbound leak into Lisp.
4531
af008560
GM
45322012-02-07 Glenn Morris <rgm@gnu.org>
4533
dd605cc4
GM
4534 * image.c (Fimagemagick_types): Doc fix.
4535
af008560
GM
4536 * image.c (imagemagick-render-type): Change it from a lisp object
4537 to an integer. Move the doc here from the lisp manual.
4538 Treat all values not equal to 0 the same.
4539
1449fa1d
CY
45402012-02-06 Chong Yidong <cyd@gnu.org>
4541
4542 * doc.c (store_function_docstring): Avoid applying docstring of
4543 alias to base function (Bug#2603).
4544
3723ec07
AS
45452012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4546
4547 * .gdbinit (pp1, pv1): Remove redundant defines.
4548 (pr): Use pp.
4549
79c1cc1e
CY
45502012-02-04 Chong Yidong <cyd@gnu.org>
4551
4552 * nsterm.m: Declare a global (Bug#10694).
4553
d7f29f8e
EZ
45542012-02-04 Eli Zaretskii <eliz@gnu.org>
4555
cae07000
SM
4556 * w32.c (get_emacs_configuration_options):
4557 Include --enable-checking, if specified, in the return value.
d7f29f8e 4558
3b95a6f9
MR
45592012-02-04 Martin Rudalics <rudalics@gmx.at>
4560
4561 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4562 after rounding frame sizes. (Bug#9723)
4563
d6fa96a6
EZ
45642012-02-04 Eli Zaretskii <eliz@gnu.org>
4565
4566 * keyboard.c (adjust_point_for_property): Don't position point
4567 before BEGV. (Bug#10696)
4568
df0b2940
PE
45692012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 Handle overflow when computing char display width (Bug#9496).
4572 * character.c (char_width): Return EMACS_INT, not int.
4573 (char_width, c_string_width): Check for overflow when
4574 computing the width; this is possible now that individual
4575 characters can have unbounded width. Problem introduced
4576 by merge from Emacs 23 on 2012-01-19.
4577
6bee44d6
MA
45782012-02-02 Michael Albinus <michael.albinus@gmx.de>
4579
4580 * dbusbind.c (Fdbus_register_method): Mention the return value
4581 :ignore in the docstring.
4582
44f92739
GM
45832012-02-02 Glenn Morris <rgm@gnu.org>
4584
1b9f60cc
GM
4585 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4586
44f92739
GM
4587 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4588 Unconditionally set to t. (Bug#10673)
4589 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4590 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4591 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4592
c5d3843c
KH
45932012-02-02 Kenichi Handa <handa@m17n.org>
4594
4595 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4596 0, do not call append_composite_glyph.
4597
159462d4 45982012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4599
4600 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4601 NULL (Bug#6988).
4602 (x_produce_glyphs): If the component of a composition is a null
4603 string, set it->pixel_width to 1 to avoid zero-width glyph.
4604
78cef877
EZ
46052012-02-01 Eli Zaretskii <eliz@gnu.org>
4606
4607 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4608 first 2 arguments are identical. This makes inserting large
4609 output from a subprocess an order of magnitude faster on
4610 MS-Windows, where all sbrk'ed memory is always contiguous.
4611
97897668
GM
46122012-01-31 Glenn Morris <rgm@gnu.org>
4613
4614 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4615 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4616 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4617
31fd3586
GM
46182012-01-29 Glenn Morris <rgm@gnu.org>
4619
4620 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4621
0e24a8b2
CY
46222012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4623
4624 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4625
cc0adcb0
CY
46262012-01-28 Chong Yidong <cyd@gnu.org>
4627
4628 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4629
acc28cb9
CY
46302012-01-26 Chong Yidong <cyd@gnu.org>
4631
9c69cfb7
CY
4632 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4633
acc28cb9
CY
4634 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4635 repeat counts (Bug#10507).
4636
48da7392
GM
46372012-01-26 Glenn Morris <rgm@gnu.org>
4638
4639 * lread.c (syms_of_lread): Doc fix.
4640
14af5f7f
CY
46412012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4642
4643 * coding.c (encode_designation_at_bol): Change return value to
4644 EMACS_INT.
4645
0b21c100
CY
46462012-01-25 Chong Yidong <cyd@gnu.org>
4647
4648 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4649
3c2907f7
CY
46502012-01-21 Chong Yidong <cyd@gnu.org>
4651
4652 * floatfns.c (Fcopysign): Make the second argument non-optional,
4653 since nil is not allowed anyway.
4654
959ad23f
AS
46552012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4656
4657 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4658 (send_process): Likewise.
4659
34a02f46
MR
46602012-01-19 Martin Rudalics <rudalics@gmx.at>
4661
4662 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4663 (Vwindow_persistent_parameters): Do not use Qstate.
4664 Rewrite doc-strings.
34a02f46 4665
1259009a 46662012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4667
4668 * character.c (char_width): New function.
70d4fdf6
GM
4669 (Fchar_width, c_string_width, lisp_string_width):
4670 Use char_width (Bug#9496).
25ed9e61 4671
6a6ee00d
MR
46722012-01-16 Martin Rudalics <rudalics@gmx.at>
4673
4674 * window.c (Vwindow_persistent_parameters): New variable.
4675 (Fset_window_configuration, save_window_save): Handle persistent
4676 window parameters.
4677
c85efaf7
EZ
46782012-01-14 Eli Zaretskii <eliz@gnu.org>
4679
4680 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4681 thrashing the stack of the thread. (Bug#9087)
4682
5944709e
PE
46832012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4686
e71f5d99
EZ
46872012-01-11 Eli Zaretskii <eliz@gnu.org>
4688
4689 * xdisp.c (rows_from_pos_range): Handle the case where the
4690 highlight ends on a newline. (Bug#10464)
4691 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4692 he end column for display of highlight that ends on a newline
4693 before a R2L line.
4694
ce316182
GM
46952012-01-11 Glenn Morris <rgm@gnu.org>
4696
4697 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4698 from load-path also when installation-directory is nil. (Bug#10208)
4699
5b43da69
GM
47002012-01-10 Glenn Morris <rgm@gnu.org>
4701
74cc8ff9
GM
4702 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4703
7d8d6e4e
GM
4704 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4705 Update template values to be closer to their typical values these days.
5b43da69 4706
a0db8d43
EZ
47072012-01-09 Eli Zaretskii <eliz@gnu.org>
4708
4709 * xdisp.c (rows_from_pos_range): Accept additional argument
4710 DISP_STRING, and accept any glyph in a row whose object is that
4711 string as eligible for mouse highlight. Fixes mouse highlight of
4712 display strings from overlays. (Bug#10464)
4713
9a0115ab 47142012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4715
b9110d6a 4716 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4717 * fileio.c (auto_saving_dir_umask): New static var.
4718 (Fmake_directory_internal): Use it.
4719 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4720 creating the directory. The old code temporarily assigns
4721 too-generous permissions to the directory.
4722 (do_auto_save_eh): Clear it.
b9110d6a 4723 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4724 that the var is always cleared.
4725
6c1bd3f3
EZ
47262012-01-07 Eli Zaretskii <eliz@gnu.org>
4727
4728 * search.c (scan_buffer): Pass character positions to
4729 know_region_cache, not byte positions. (Bug#6540)
4730
069d2b50
L
47312012-01-07 LynX <_LynX@bk.ru> (tiny change)
4732
4733 * w32.c (sys_rename): Report EXDEV when rename of a directory
4734 fails because the target is on another logical disk. (Bug#10284)
4735
75bf0d33
DB
47362012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4737
4738 * xterm.c (x_embed_request_focus): New function.
4739
4740 * xterm.h: Add prototype.
4741
4742 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4743
1c6e5a32
GM
47442012-01-05 Glenn Morris <rgm@gnu.org>
4745
4746 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4747
651e947e
EZ
47482012-01-01 Eli Zaretskii <eliz@gnu.org>
4749
4750 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4751 Load gnutls_transport_set_lowat only if GnuTLS version is below
4752 2.11.1.
4753 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4754 GnuTLS versions below 2.11.1.
4755
3778cdd8
AL
47562011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4757
4758 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4759 to the doc string advising against its use for altering the way
4760 windows are scrolled.
4761
0e5317f7
KH
47622011-12-28 Kenichi Handa <handa@m17n.org>
4763
4764 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4765 coding-system ASCII compatible only when it does not produce BOM
4766 on encoding (Bug#10383).
4767
93d5ca1f
JD
47682011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4769
4770 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4771 can scroll.
4772 (create_and_show_popup_menu): Always use menu_position_func for
4773 Gtk3 (Bug#10361).
4774
ca22b785
AS
47752011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4776
4777 * callint.c (Fcall_interactively): Don't truncate prompt string.
4778
d048e1e6
EZ
47792011-12-23 Eli Zaretskii <eliz@gnu.org>
4780
4781 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4782 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4783 resumed from there (after widening). (Bug#10360)
d048e1e6 4784
5ccaba1f
JD
47852011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4786
4787 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4788
204ee57f
JD
47892011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4790
b81d40f0
JB
4791 * nsterm.m (x_free_frame_resources):
4792 Release f->output_data.ns->miniimage.
204ee57f
JD
4793 (ns_index_color): Fix indentation. Do not retain
4794 color_table->colors[i].
4795
4796 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4797 before returning.
4798
4799 * nsfns.m (x_set_background_color): Assign return value from
4800 ns_index_color to face-background instead of NSColor*.
4801 (ns_implicitly_set_icon_type): Fix indentation.
4802 Change assignment in for loop to comparison.
4803
4804 * emacs.c (ns_pool): New variable.
4805 (main): Assign ns_pool.
4806 (Fkill_emacs): Call ns_release_autorelease_pool.
4807
4808 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4809 autorelease fdesc, release fdAttrs and tdict.
4810 (ns_get_covering_families): Release charset.
4811 (ns_findfonts): Release NSFontDescriptor created with new.
4812 (ns_uni_to_glyphs): Fix indentation.
4813 (setString): Release attrStr before assigning new value.
4814
c803b2b7
JD
48152011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4816
678f4426
JD
4817 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4818 and NS_IMPL_COCOA.
4819 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4820 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4821
cd394be1 48222011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4823
5fecd5fc
JD
4824 * nsterm.m (ns_term_init): Subscribe for notifications
4825 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4826 to method trackingNotification in EmacsMenu.
4827
4828 * nsmenu.m (trackingMenu): New variable.
3771cb17 4829 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4830 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4831 from Aquamacs (Bug#7030).
678f4426
JD
4832
48332011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4834
c803b2b7
JD
4835 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4836 (symbol_to_nsstring): Fix indentation.
4837 (ns_symbol_to_pb): New function.
cae07000
SM
4838 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4839 (Fns_rotate_cut_buffers_internal): Remove.
4840 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4841 Fns_store_cut_buffer_internal.
4842 (ns_get_foreign_selection, Fx_own_selection_internal)
4843 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4844 (Fns_get_selection_internal, Fns_store_selection_internal):
4845 Use ns_symbol_to_pb and check if return value is nil.
4846 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4847 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4848 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4849 renamed to Sns_store_selection_internal.
4850 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4851 and remove this function.
4852 (ns_handle_selection_clear): Remove, never used.
4853 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4854 here.
4855
e1b01a3a
KB
48562011-12-17 Ken Brown <kbrown@cornell.edu>
4857
4858 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4859 GID is unknown (Bug#10257).
4860
2adb6e85
PE
48612011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4862
4863 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4864 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4865 which caused a build failure on GNU/Linux IA-64. This problem was
4866 introduced by my 2011-10-07 patch.
4867
d1d7b339
JL
48682011-12-15 Juri Linkov <juri@jurta.org>
4869
4870 * image.c (imagemagick_error): New function. (Bug#10112)
4871 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4872 Use `imagemagick_error' where ImageMagick functions return
4873 `MagickFalse'.
4874 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4875 proper order.
4876
100d5755
KH
48772011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4878
4879 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4880 fill background (Bug#8992).
4881
454592a6
MR
48822011-12-13 Martin Rudalics <rudalics@gmx.at>
4883
4884 * window.c (Vwindow_combination_resize)
4885 (Vwindow_combination_limit): Use t instead of non-nil in
4886 doc-strings.
61d4b438
MR
4887 (Vrecenter_redisplay): Add first sentence of doc-string on
4888 separate line.
53524d93 4889 (Frecenter): Fix doc-string typo.
454592a6 4890
3633e3aa
KH
48912011-12-11 Kenichi Handa <handa@m17n.org>
4892
4893 * coding.c (Funencodable_char_position): Pay attention to the
4894 buffer text relocation (Bug#9389).
4895
7b9d523a 48962011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4897
7b9d523a
JD
4898 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4899 gtk_init (Bug#10100).
4900
b73189c6
EZ
49012011-12-10 Eli Zaretskii <eliz@gnu.org>
4902
4903 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4904 IT->string is nil. (Bug#10263)
4905
f7dfe5d6
JD
49062011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4907
83faebb4
JD
4908 * nsterm.h (x_free_frame_resources): Declare.
4909
f7dfe5d6
JD
4910 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4911 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4912
4913 * nsterm.h (ns_get_defaults_value): Declare.
4914
4915 * nsterm.m (ns_default): Call ns_get_defaults_value.
4916
7cd4e72c
EZ
49172011-12-09 Eli Zaretskii <eliz@gnu.org>
4918
4919 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4920 (Bug#10170)
4921
b34d7317
YM
49222011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4923
4924 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4925 that where the value of an _OBJC_* symbol points to is in the .bss
4926 section (Bug#10240).
4927
76470ad1
KH
49282011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4929
4930 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4931 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4932
745fff94
KH
49332011-12-08 Kenichi Handa <handa@m17n.org>
4934
4935 * ftfont.c (get_adstyle_property): Fix previous change
4936 (Bug#10233).
4937
6e44397c
JB
49382011-12-07 Juanma Barranquero <lekktu@gmail.com>
4939
4940 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4941 dirs from the default value of EMACSLOADPATH (bug#10208).
4942
7efa6272
GM
49432011-12-07 Glenn Morris <rgm@gnu.org>
4944
4945 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4946 installation and source directories as well. (Bug#10208)
4947
f6fc4d87
CY
49482011-12-06 Chong Yidong <cyd@gnu.org>
4949
4950 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4951
2bf26180
GM
49522011-12-06 Glenn Morris <rgm@gnu.org>
4953
4954 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4955 as an error, not just -1. (Bug#10217)
4956
3a6ad4f0
CY
49572011-12-05 Chong Yidong <cyd@gnu.org>
4958
4959 * keyboard.c (process_special_events): New function.
4960 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4961
75a3b399
PE
49622011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4963
4964 * coding.c (encode_designation_at_bol): Don't use uninitialized
4965 local variable (Bug#9318).
4966
c3c9e25e
KH
49672011-12-05 Kenichi Handa <handa@m17n.org>
4968
4969 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4970 return Qnil (Bug#8046, Bug#10193).
4971
5eb05ea3
KH
49722011-12-05 Kenichi Handa <handa@m17n.org>
4973
4974 * coding.c (encode_designation_at_bol): New args charbuf_end and
4975 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4976 (coding_set_source): Return how many bytes coding->source was
4977 relocated.
4978 (coding_set_destination): Return how many bytes
4979 coding->destination was relocated.
4980 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4981 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4982
49832011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4984
4985 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4986 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4987 macro (Bug#9318).
4988
49892011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4990
4991 The following changes are to fix Bug#9318.
4992
a79703f5 4993 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4994 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4995 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4996 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4997
7dbda6df
JB
49982011-12-05 Juanma Barranquero <lekktu@gmail.com>
4999
5000 * lisp.h (process_quit_flag): Fix external declaration.
5001
6d5eb5b0
SM
50022011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5003
5004 Don't macro-inline non-performance-critical code.
5005 * eval.c (process_quit_flag): New function.
5006 * lisp.h (QUIT): Use it.
5007
a0c3fad0
JD
50082011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5009
5010 * nsfns.m (get_geometry_from_preferences): New function.
5011 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5012
6c07aac2
AS
50132011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5014
5015 * emacs.c (Qkill_emacs): Define.
5016 (syms_of_emacs): Initialize it.
5017 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5018 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5019 (quit_throw_to_read_char): Add parameter `from_signal'.
5020 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5021 * lisp.h (QUIT): Call Fkill_emacs if requested.
5022
c052ead4
JD
50232011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5024
5025 * widget.c (update_wm_hints): Return if wmshell is null.
5026 (widget_update_wm_size_hints): New function.
5027
5028 * widget.h (widget_update_wm_size_hints): Declare.
5029
5030 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5031 widget_update_wm_size_hints (Bug#10104).
5032
9e49252b
EZ
50332011-12-03 Eli Zaretskii <eliz@gnu.org>
5034
5035 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5036 before a newline, prepare the bidi iterator for consuming the
5037 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5038 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5039
02b16839
JL
50402011-12-02 Juri Linkov <juri@jurta.org>
5041
5042 * search.c (Fword_search_regexp): New Lisp function created from
5043 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5044 (Fword_search_backward, Fword_search_forward)
5045 (Fword_search_backward_lax, Fword_search_forward_lax):
5046 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5047 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5048
0068070e
SM
50492011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5050
5051 * fileio.c (Finsert_file_contents): Move after-change-function call
5052 to before the "handled:" label, since all "goto handled" appear in
5053 cases where the *-change-functions have already been properly called
5054 (bug#10117).
5055
3360a3fc
AS
50562011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5057
5058 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5059 waiting for input. (Bug#10169)
5060
73d6c093
EZ
50612011-11-30 Eli Zaretskii <eliz@gnu.org>
5062
5063 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5064 verifies glyph row's hash code--we have just reallocated the
5065 glyphs, so their contents can be complete garbage. (Bug#10164)
5066
febe6bea
JB
50672011-11-30 Juanma Barranquero <lekktu@gmail.com>
5068
5069 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5070
801a4313
EZ
50712011-11-30 Eli Zaretskii <eliz@gnu.org>
5072
5073 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5074 attributes are tested _before_ calling verify_row_hash, to protect
5075 against GCC re-ordering of the tests. (Bug#10164)
5076
2b56b87e
JD
50772011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5078
5079 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5080
5081 * xterm.c (handle_one_xevent): Only set async_visible and friends
5082 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5083 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5084 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5085
dbf31225
PE
50862011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5087
5088 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5089 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5090 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5091 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5092 All uses changed to use GCPRO1 etc.
5093 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5094 Revert to old implementation (i.e., before 2011-03-11).
5095
1305621b
YM
50962011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5097
5098 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5099 of scroll runs so as to avoid assigning disabled bogus rows and
5100 unnecessary graphics copy operations.
5101
8c9afb46
EZ
51022011-11-27 Eli Zaretskii <eliz@gnu.org>
5103
5104 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5105 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5106 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5107 (malloc, free, realloc, calloc): Redirect to e_* only when
5108 compiling Emacs.
5109
5110 * lisp.h (GCTYPEBITS): Move before first use.
5111 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5112 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5113 this macro definition.
5114
5115 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5116 _MSC_VER.
5117
54e9e3bf
JD
51182011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5119
6d5eb5b0
SM
5120 * gtkutil.c (xg_create_frame_widgets):
5121 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5122 present with Gtk+ 2.0.
5123
83aca1cb
PE
51242011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5125
5126 * fileio.c (Finsert_file_contents): Undo previous change; see
5127 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5128
5b76caa4
PE
51292011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5130
5131 Rename locals to avoid shadowing.
5132 * fileio.c (Finsert_file_contents):
5133 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5134 * process.c (wait_reading_process_output):
5135 Rename inner 'proc' to 'p' to avoid shadowing.
5136 Indent for consistency with usual Emacs style.
5137
8c535114
EZ
51382011-11-25 Eli Zaretskii <eliz@gnu.org>
5139
5140 * xdisp.c (redisplay_window): If cursor row is not fully visible
5141 after recentering, and scroll-conservatively is set to a large
5142 number, scroll window by a few more lines to make the cursor fully
5143 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5144 (start_display): Don't move to the next line if the display should
5145 start at a newline that is part of a display vector or an overlay
5146 string. (Bug#10119)
8c535114 5147
fa4fdb5c
JL
51482011-11-24 Juri Linkov <juri@jurta.org>
5149
5150 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5151 after the `MagickPingImage' call. (Bug#10112)
5152
90ec88df
CY
51532011-11-23 Chong Yidong <cyd@gnu.org>
5154
5155 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5156
56e2e794
MR
51572011-11-23 Martin Rudalics <rudalics@gmx.at>
5158
5159 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5160 making another buffer current. (Bug#10114)
5161
b6e64c41
GM
51622011-11-23 Glenn Morris <rgm@gnu.org>
5163
5164 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5165
6b21de18
CY
51662011-11-23 Chong Yidong <cyd@gnu.org>
5167
5168 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5169 using it (Bug#5984).
5170
b12cd789
EZ
51712011-11-22 Eli Zaretskii <eliz@gnu.org>
5172
5173 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5174 and header-lines, as they don't have one computed for them.
5175 (Bug#10098)
5176
5177 * .gdbinit (prow): Make displayed values more self-explaining.
5178 Add row's hash code.
5179
261b6fd4
LMI
51802011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5181
5182 * process.c (wait_reading_process_output): Fix asynchrounous
5183 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5184 (wait_reading_process_output): Add comment and URL.
261b6fd4 5185
e7cfd277
JD
51862011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5187
5188 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5189
a9b9b7f5
CY
51902011-11-21 Chong Yidong <cyd@gnu.org>
5191
5192 * window.c (Fnext_window, Fprevious_window): Doc fix.
5193
b0d15b4f
SM
51942011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5195
5196 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5197
fe7a3057
JB
51982011-11-20 Juanma Barranquero <lekktu@gmail.com>
5199
5200 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5201
d2999b1a
MR
52022011-11-20 Martin Rudalics <rudalics@gmx.at>
5203
5204 * window.c (Fset_window_combination_limit): Rename argument
5205 STATUS to LIMIT.
5206 (Vwindow_combination_limit): Remove "status" from doc-string.
5207
d5ff9cd0
AS
52082011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5209
5210 * m/ibms390.h: Remove.
5211 * m/ibms390x.h: Don't include "ibms390.h".
5212
a5bb9bd3
SM
52132011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5214
5215 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5216 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5217
cd1181db
JB
52182011-11-20 Juanma Barranquero <lekktu@gmail.com>
5219
5220 * casetab.c (Fset_case_table):
5221 * charset.c (Fcharset_after): Fix typos.
5222
615a3b8d 52232011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5224
17e845af
PE
5225 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5226 Otherwise, valgrind does not work on some platforms.
5227 Problem reported by Andreas Schwab in
6a0bf43d
PE
5228 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5229 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5230 is set, removing the need for VIRT_ADDRESS_VARIES.
5231 (PURE_P): Use a more-efficient implementation that needs just one
5232 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5233 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5234 to 4 (xorl, subq, cmpq, setbe).
5235 * alloc.c (pure): Always extern now, since that's the
5236 VIRT_ADDR_VARIES behavior.
5237 (PURE_POINTER_P): Use a single comparison, not two, for
5238 consistency with the new puresize.h.
5239 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5240 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5241 Remove VIRT_ADDR_VARIES no longer needed.
5242
f8fe6f96
EZ
52432011-11-19 Eli Zaretskii <eliz@gnu.org>
5244
5245 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5246 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5247 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5248 behave as if the cursor position were at the window margin.
5249
5250 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5251 and the cursor position is out of bounds, behave as if the cursor
5252 position were at the window margin. (Bug#10075)
5253
df05a53c
CY
52542011-11-18 Chong Yidong <cyd@gnu.org>
5255
5256 * window.c (Fwindow_combination_limit): Make first argument
5257 non-optional, since it is meaningless for live windows like the
5258 selected window.
61ccba97 5259
2071918e
DA
52602011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5261
5262 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5263
b50a28de
SM
52642011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5265
5266 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5267 (graft_intervals_into_buffer): Simplify.
5268
015137db
EZ
52692011-11-18 Eli Zaretskii <eliz@gnu.org>
5270
5271 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5272 hash values of the two rows.
5273 (copy_row_except_pointers): Preserve the used[] arrays and the
5274 hash values of the two rows. (Bug#10035)
68c95424 5275 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5276
5277 * xdisp.c (row_hash): New function, body extracted from
5278 compute_line_metrics.
5279 (compute_line_metrics): Call row_hash, instead of computing the
5280 hash code inline.
5281
5282 * dispnew.c (verify_row_hash): Call row_hash for computing the
5283 hash code of a row, instead of duplicating code from xdisp.c.
5284
5285 * dispextern.h (row_hash): Add prototype.
5286
a2addb04
TH
52872011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5288
5289 * frame.c (delete_frame): Don't delete the terminal when the last
5290 X frame is closed if emacs is built with GTK toolkit.
5291
df85d315
JB
52922011-11-17 Juanma Barranquero <lekktu@gmail.com>
5293
5294 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5295
a0c2d0ae
MR
52962011-11-17 Martin Rudalics <rudalics@gmx.at>
5297
5298 * window.c (Vwindow_splits): Rename to
5299 Vwindow_combination_resize. Suggested by Juri Linkov.
5300 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5301 of Vwindow_splits.
5302
58179cce
JB
53032011-11-16 Juanma Barranquero <lekktu@gmail.com>
5304
7877f373
JB
5305 * nsfns.m (Fns_font_name):
5306 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5307
b6f67890
MR
53082011-11-16 Martin Rudalics <rudalics@gmx.at>
5309
5310 * window.h (window): Rename slot "nest" to "combination_limit".
5311 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5312 (Fset_window_nest): Rename to Fset_window_combination_limit.
5313 (Vwindow_nest): Rename to Vwindow_combination_limit.
5314 (recombine_windows, make_parent_window, make_window)
5315 (Fsplit_window_internal, saved_window)
5316 (Fset_window_configuration, save_window_save): Rename all
5317 occurrences of window_nest to window_combination_limit.
5318
c7015153
JB
53192011-11-15 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * image.c (imagemagick_load_image): Fix typo.
5322
322ad6ec
EZ
53232011-11-14 Eli Zaretskii <eliz@gnu.org>
5324
5325 * xdisp.c (display_line): Move the call to
5326 highlight_trailing_whitespace before the call to
5327 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5328 faces of all the glyphs to compute ROW's hash value.
5329 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5330
f067b8ec
JB
53312011-11-14 Juanma Barranquero <lekktu@gmail.com>
5332
5333 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5334 just return (bug#10044).
5335
1e5b2111
EZ
53362011-11-12 Eli Zaretskii <eliz@gnu.org>
5337
7ef3cbd5
EZ
5338 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5339 with user-defined heap size. Bump the default size of the temacs
5340 heap to 27MB, to avoid memory warning when running temacs.
5341 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5342
1e5b2111
EZ
5343 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5344 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5345 (verify_row_hash) [XASSERTS]: New function.
5346 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5347 that the hash value of glyph rows is correct.
1e5b2111 5348
89d61221
MR
53492011-11-12 Martin Rudalics <rudalics@gmx.at>
5350
5351 * window.h (window): Remove splits slot.
5352 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5353 (Fdelete_other_windows_internal, make_parent_window)
5354 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5355 (Fset_window_configuration, save_window_save): Don't deal with
5356 split status of windows.
5357 (saved_window): Remove splits slot.
5358 (Vwindow_splits): Rewrite doc-string.
5359
97f18cc8
JD
53602011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5361
5362 * xfns.c (unwind_create_frame):
5363 * nsfns.m (unwind_create_frame):
5364 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5365 Vframe_list (Bug#9999).
5366
22a648b4
DA
53672011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5368
0b381c7e 5369 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5370
659afede
KH
53712011-11-11 Kenichi Handa <handa@m17n.org>
5372
5373 * callproc.c (Fcall_process): Set the member dst_multibyte of
5374 process_coding.
5375
9ac0394b
KH
53762011-11-11 Johan Bockgård <bojohan@gnu.org>
5377
5378 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5379 avoid a crash (bug#9496).
5380
2fbdc249
CY
53812011-11-09 Chong Yidong <cyd@gnu.org>
5382
5383 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5384 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5385
ac6b1f81
PE
53862011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5387
5388 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5389
09db192c
PE
53902011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5391
5392 Avoid some portability problems by eschewing 'extern inline' functions.
5393 The trivial performance wins aren't worth the portability hassles; see
5394 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5395 et seq.
5396 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5397 (window_box_width, window_box_left, window_box_left_offset)
5398 (window_box_right, window_box_right_offset): Undo previous change,
5399 by removing the "extern"s.
5400 * intervals.c (adjust_intervals_for_insertion)
5401 (adjust_intervals_for_deletion): Undo previous change,
5402 making these static again.
5403 (offset_intervals, temp_set_point_both, temp_set_point)
5404 (copy_intervals_to_string): No longer inline.
5405 * xdisp.c (window_text_bottom_y, window_box_width)
5406 (window_box_height, window_box_left_offset)
5407 (window_box_right_offset, window_box_left, window_box_right)
5408 (window_box): No longer inline.
5409
105216ed
CY
54102011-11-08 Chong Yidong <cyd@gnu.org>
5411
5412 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5413 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5414 Signal an error if not a live window.
105216ed
CY
5415 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5416 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5417
ae9e237f
JB
54182011-11-07 Juanma Barranquero <lekktu@gmail.com>
5419
5420 * lisp.h (syms_of_abbrev): Remove declaration.
5421 Reported by CHENG Gao <chenggao@royau.me>.
5422
c7aa8333
EZ
54232011-11-07 Eli Zaretskii <eliz@gnu.org>
5424
5425 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5426 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5427 of temacs in GUI mode.
5428
be7f5545
MR
54292011-11-07 Martin Rudalics <rudalics@gmx.at>
5430
5431 * window.h: Declare delete_all_child_windows instead of
5432 delete_all_subwindows.
5433 * window.c (Fwindow_nest, Fset_window_nest)
5434 (Fset_window_new_total, Fset_window_new_normal)
5435 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5436 (delete_all_subwindows): Rename to delete_all_child_windows.
5437 (Fdelete_other_windows_internal, Fset_window_configuration):
5438 Call delete_all_child_windows instead of delete_all_subwindows.
5439 * frame.c (delete_frame): Call delete_all_child_windows instead
5440 of delete_all_subwindows.
5441
ca78dc43
PE
54422011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5445 This is also needed for porting to any host where GC_MARK_STACK is
5446 not GC_MAKE_GCPROS_NOOPS.
5447 (which_symbols): Use it.
5448
a0241d01
KH
54492011-11-07 Kenichi Handa <handa@m17n.org>
5450
5451 * coding.c (coding_set_destination): Check coding->src_pos only
5452 when coding->src_object is a buffer (bug#9910).
5453
5454 * process.c (send_process): Set the member src_multibyte of coding
5455 to 0 (bug#9911) when sending a unibyte text.
5456
5457 * callproc.c (Fcall_process): Set the member src_multibyte of
5458 process_coding to 0 (bug#9912).
5459
a64bfdfa 54602011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5461
5462 * xmenu.c (cleanup_widget_value_tree): New function.
5463 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5464 calling free_menubar_widget_value_tree directly (Bug#9830).
5465
cb41b32a
PE
54662011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5467
5468 Fix some portability problems with 'inline'.
5469 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5470 (window_box_width, window_box_left, window_box_left_offset)
5471 (window_box_right, window_box_right_offset): Declare extern.
5472 Otherwise, these inline functions do not conform to C99 and
5473 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5474 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5475 * intervals.c (adjust_intervals_for_insertion)
5476 (adjust_intervals_for_deletion): Now extern, because otherwise the
5477 extern inline functions 'offset_intervals' couldn't refer to it.
5478 (static_offset_intervals): Remove.
5479 (offset_intervals): Rewrite using the old contents of
5480 static_offset_intervals. The old version didn't conform to C99
5481 because an extern inline function contained a reference to an
5482 identifier with static linkage.
5483
b7041366
AS
54842011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5485
5486 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5487 GC.
5488
88a37c4d
EZ
54892011-11-06 Eli Zaretskii <eliz@gnu.org>
5490
5491 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5492 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5493 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5494 return Qleft_to_right.
5495
49745b39
CY
54962011-11-06 Chong Yidong <cyd@gnu.org>
5497
5498 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5499 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5500 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5501 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5502 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5503 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5504 (Fwindow_vscroll): Doc fix.
5505 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5506 argument, since it makes no sense to pass a live window and for
5507 consistency with window-child.
5508
1f05cd82
CS
55092011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5510
5511 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5512 support MSVC.
5513
22610910
JR
55142011-11-05 Jason Rumney <jasonr@gnu.org>
5515
5516 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5517 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5518 fonts (Bug#6029).
5519 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5520 bitwise arithmetic preventing use of unicode-sip and non-truetype
5521 opentype fonts.
5522
a06776b2
EZ
55232011-11-05 Eli Zaretskii <eliz@gnu.org>
5524
3ad924ba
EZ
5525 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5526 "emacs"-only part.
5527
a06776b2
EZ
5528 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5529 initialization code to keep similarity to xfns.c after changes
5530 from 2011-11-05.
5531
c9e7db78
JD
55322011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5533
a97f8f3f
JD
5534 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5535 (unwind_create_frame): New function (Bug#9943).
5536 (Fx_create_frame): Restructure code to be more similar to the one in
5537 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5538 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5539 Move terminal->reference_count++ just before making the frame official
5540 (Bug#9943).
5541
5542 * nsterm.m (x_free_frame_resources): New function.
5543 (x_destroy_window): Move code to x_free_frame_resources.
5544
c9e7db78 5545 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5546 (Fx_create_frame, x_create_tip_frame):
5547 Move terminal->reference_count++ just before making the frame
75f1671a 5548 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5549 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5550
a6fc3b5c
EZ
55512011-11-05 Eli Zaretskii <eliz@gnu.org>
5552
5553 Support MSVC build with newer versions of Visual Studio.
5554 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5555 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5556 nt/gmake.defs.
5557
5558 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5559 which are not supported by MSVC.
5560 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5561 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5562 bitfields.
5563 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5564 types in bitfields.
5565 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5566
5567 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5568
58179cce 55692011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5570
5571 Support MSVC build with newer versions of Visual Studio.
5572 * w32.c: Don't include w32api.h for MSVC.
5573 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5574
5575 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5576 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5577 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5578 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5579 e_* cousins.
5580 (alloca) [_MSC_VER]: Define to _alloca.
5581
5582 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5583
5584 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5585
a58c13ed
EZ
55862011-11-04 Eli Zaretskii <eliz@gnu.org>
5587
5588 * xdisp.c (note_mouse_highlight): If either of
5589 previous/next-single-property-change returns nil, treat that as
5590 the beginning or the end of the buffer. (Bug#9955)
5591
fe0b6370
JD
55922011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5593
a58c13ed 5594 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5595 label is not null (Bug#9951).
5596 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5597 may be NULL.
5598
89bd5ee1
EZ
55992011-11-04 Eli Zaretskii <eliz@gnu.org>
5600
5601 * window.c (Fwindow_body_size): Mention in the doc string that the
5602 return value is in frame's canonical units. (Bug#9949)
5603
84c3edb9
EZ
56042011-11-03 Eli Zaretskii <eliz@gnu.org>
5605
4e2fb5c7
EZ
5606 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5607
84c3edb9 5608 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5609 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5610 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5611
bc17a887
EZ
56122011-11-01 Eli Zaretskii <eliz@gnu.org>
5613
5614 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5615 Don't stop backward scan on the continuation glyph, even though
5616 its CHARPOS is positive.
6d5eb5b0
SM
5617 (mouse_face_from_buffer_pos, note_mouse_highlight):
5618 Rename cover_string to disp_string.
bc17a887 5619
4ee88440
MR
56202011-11-01 Martin Rudalics <rudalics@gmx.at>
5621
5622 * window.c (temp_output_buffer_show): Don't use
5623 Vtemp_buffer_show_specifiers.
5624 (Vtemp_buffer_show_specifiers): Remove unused variable.
5625
c2ff3c02
EZ
56262011-10-30 Eli Zaretskii <eliz@gnu.org>
5627
5628 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5629 past the beginning of the current glyph matrix.
5630
58179cce 56312011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5632
5633 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5634 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5635 HAVE_GTK3 (Bug#9869).
b77a6a7f 5636
3b574623
JD
5637 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5638 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5639
b77a6a7f
JD
5640 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5641
5642 * xterm.c: Declare x_handle_net_wm_state to return int.
5643 (handle_one_xevent): Check if we are iconified but don't have
5644 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5645 (get_current_wm_state): Return non-zero if not hidden,
5646 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5647 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5648 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5649 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5650
196e41e4
PE
56512011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5652
5653 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5654 so that this new function doesn't get optimized away by a
5655 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5656
021f2e1a
AS
56572011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5658
5659 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5660
8b058d44
EZ
56612011-10-29 Eli Zaretskii <eliz@gnu.org>
5662
5663 Fix the `xbytecode' command.
5664 * .gdbinit (xprintbytestr): New command.
b50a28de 5665 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5666 (xbytecode): Print the byte-code string as well.
5667
4452fb80
EZ
56682011-10-29 Kim Storm <storm@cua.dk>
5669
8b058d44
EZ
5670 * alloc.c (which_symbols): New function.
5671
21b72067
AS
56722011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5673
5674 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5675 line. (Bug#9903)
5676
83ed7b5c
GM
56772011-10-29 Glenn Morris <rgm@gnu.org>
5678
5679 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5680 Not clear what it was for, and it causes various bugs. (Bug#9839)
5681
5a7a728b
EZ
56822011-10-28 Eli Zaretskii <eliz@gnu.org>
5683
5684 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5685 possible random value that matches one of those tested as
5686 condition to clear the mouse face.
5687
d3d0842f
CY
56882011-10-28 Chong Yidong <cyd@gnu.org>
5689
5690 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5691
31b39d13
DN
56922011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5693
5694 * window.c (make_window): Initialize phys_cursor_on_p.
5695
9aba6043
SM
56962011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5697
5698 * lisp.h (struct Lisp_Symbol): Update comments.
5699
c20992f4
JB
57002011-10-28 Juanma Barranquero <lekktu@gmail.com>
5701
5702 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5703
db4f02f2
EZ
57042011-10-28 Eli Zaretskii <eliz@gnu.org>
5705
5706 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5707 <oslsachem@gmail.com> for helping to debug this.
5708
5709 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5710 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5711 (g_b_init_get_glyph_outline_w): New static variables.
5712 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5713 (GetGlyphOutlineW_Proc): New typedefs.
5714 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5715 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5716 New functions.
5717 (w32font_open_internal, compute_metrics):
5718 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5719 instead of calling the "wide" APIs directly.
5720
5721 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5722
5723 * w32.h (syms_of_w32font): Add prototype.
5724
87e68db4
JB
57252011-10-27 Juanma Barranquero <lekktu@gmail.com>
5726
5727 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5728 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5729 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5730 (Fmove_to_window_line): Doc fix.
5731
435c1d67
CY
57322011-10-27 Chong Yidong <cyd@gnu.org>
5733
5734 * process.c (make_process): Set gnutls_state to NULL.
5735
5736 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5737 non-NULL, regardless of GNUTLS_INITSTAGE.
5738 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5739 an error. Set process slots as soon as we allocate them.
5740
5741 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5742
9c6c6f49
CY
57432011-10-27 Chong Yidong <cyd@gnu.org>
5744
9aba6043
SM
5745 * gnutls.c (emacs_gnutls_deinit): New function.
5746 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5747 (Fgnutls_deinit, Fgnutls_boot): Use it.
5748
5749 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5750 (deactivate_process): Call emacs_gnutls_deinit.
5751
657d08d3
JB
57522011-10-27 Juanma Barranquero <lekktu@gmail.com>
5753
5754 * image.c (x_create_x_image_and_pixmap):
5755 * w32.c (sys_rename, w32_delayed_load):
5756 * w32font.c (fill_in_logfont):
5757 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5758
5430d399
JB
57592011-10-26 Juanma Barranquero <lekktu@gmail.com>
5760
5761 * w32fns.c (w32_default_color_map): New function,
5762 extracted from Fw32_default_color_map.
a7ef684b 5763 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5764
fe0055fa
PE
57652011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5768
e6346438
SM
57692011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5770
5771 * keyboard.c (test_undefined): New function (bug#9751).
5772 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5773
e112cc37
ET
57742011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5775
5776 * sysdep.c (init_sys_modes): Fix the check for the controlling
5777 terminal (Bug#6649).
5778
7b5d6677
EZ
57792011-10-20 Eli Zaretskii <eliz@gnu.org>
5780
5781 * dispextern.h (struct bidi_it): New member next_en_type.
5782
5783 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5784 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5785 current character, check also for next_en_type being WEAK_EN.
5786 (bidi_resolve_weak): Don't enter the expensive loop if the current
5787 position is before next_en_pos. Record the bidi type of the first
5788 non-ET, non-BN character we find, in addition to its position.
5789 (bidi_level_of_next_char): Invalidate next_en_type when
5790 next_en_pos is over-stepped.
5791
7da0b018
PE
57922011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5793
5794 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5795 * editfns.c: Rewrite current-time-zone so that it invokes
5796 the equivalent of (format-time-string "%Z") to get the time zone name.
5797 This fixes a bug when the time zone name contains characters that
5798 need converting from the system time locale to Emacs internal format.
5799 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5800 that patch fixed format-time-string to do the conversion, but
5801 I forgot to fix current-time-zone.
5802 (format_time_string): New function, containing most of
5803 what Fformat_time_string used to contain.
5804 (Fformat_time_string): Rewrite in terms of format_time_string.
5805 This doesn't change this function's behavior.
5806 (current-time-zone): Rewrite to use format_time_string.
5807 This fixes the bug reported by Michael Schierl in
5808 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5809 Jason Rumney's 2007-06-07 change worked around this bug, but
5810 didn't fix it.
5811 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5812
8547b010
EZ
58132011-10-19 Eli Zaretskii <eliz@gnu.org>
5814
5815 * xdisp.c (start_display): If the character at POS is displayed
5816 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5817 (try_window_reusing_current_matrix): If a line ends in a display
5818 vector or the next line starts in a display vector, continue
5819 redrawing the window even though the character position of
5820 start_row was reached.
8547b010
EZ
5821 (Bug#9771, part 2)
5822
4e948d15
CY
58232011-10-18 Chong Yidong <cyd@gnu.org>
5824
5825 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5826 with nobreak-char-display too.
5827
4787455f
EZ
58282011-10-18 Eli Zaretskii <eliz@gnu.org>
5829
5830 Fix part 3 of bug#9771.
5831 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5832 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5833 non-neutral characters if the current character is a paragraph
5834 separator (a.k.a. Newline). This avoids running the same
5835 expensive loop twice, once when we consume the preceding newline
5836 and the other time when the line actually needs to be displayed.
5837 Avoid the loop when we see neutrals on the base embedding level
5838 following a character whose directionality is the same as the
5839 paragraph's. This avoids running the expensive loop when a line
5840 ends in a long sequence of neutrals, like control characters.
5841 Add assertion against STRONG_AL type. Slightly rearrange code
5842 that determines the type of a neutral given the first non-neutral
5843 that follows it.
5844 (bidi_level_of_next_char): Set next_en_pos to zero when
5845 invalidating its info.
5846
2c91f553
EZ
58472011-10-17 Eli Zaretskii <eliz@gnu.org>
5848
5849 * xdisp.c (push_display_prop): Determine whether to record string
5850 or buffer position by IT->string, not by IT->method. Allow
5851 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5852 (move_it_vertically_backward): Don't look for character position
5853 immediately after the newline when in a continuation line.
5854 (Bug#9771, part 1)
2c91f553 5855
c7b08b0d
MR
58562011-10-15 Martin Rudalics <rudalics@gmx.at>
5857
5858 * window.c (coordinates_in_window): Rewrite and delabelize
5859 vertical border check. (Bug#5357) (Bug#9618)
5860
6b02f655
SM
58612011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5862
5863 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5864 errors in XSetWindowBorder (bug#9310).
5865
81d40c92
DA
58662011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5867
5868 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5869 avoid crash when xmalloc overrun checking is enabled.
5870
d4172c3b
EZ
58712011-10-13 Eli Zaretskii <eliz@gnu.org>
5872
5873 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5874 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5875 cursor motion with <left> and <right> arrow keys.
5876
5877 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5878 some callers set that themselves.
5879
b00eea75
EZ
58802011-10-12 Eli Zaretskii <eliz@gnu.org>
5881
5882 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5883 display string and the previous row comes from the same string and
5884 is empty. (Bug#9739) (Bug#9738)
5885
8fe012c4
SM
58862011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5887
5888 * doc.c (get_doc_string): Encode file name (bug#9735).
5889
0074aef2
EZ
58902011-10-12 Eli Zaretskii <eliz@gnu.org>
5891
79beb178
EZ
5892 * bidi.c (bidi_level_of_next_char):
5893 * xdisp.c (get_visually_first_element): Remove old incorrect
5894 comments regarding the Unicode Line Separator character.
5895
0074aef2
EZ
5896 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5897
6e4b3fbe
DA
58982011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5899
5900 * alloc.c (Fgc_status): Do not access beyond zombies array
5901 boundary if nzombies > MAX_ZOMBIES.
5902 * alloc.c (dump_zombies): Add missing format specifier.
5903
0324f3af
PE
59042011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5905
b5525cac
PE
5906 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5907 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5908
0324f3af
PE
5909 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5910 Some packages use them to denote characters with modifiers.
5911
e9b5f888
AS
59122011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5913
5914 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5915 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5916 matching a pp-number. Rename parameter var to var1.
5917
127827c0
SM
59182011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5919
5920 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5921
c8fd3bd0
GM
59222011-10-08 Glenn Morris <rgm@gnu.org>
5923
5924 * callint.c (Fcall_interactively): Give a more explicit error for the
5925 'c' case with a non-character input. (Bug#8479)
5926
352ec8ff
EZ
59272011-10-08 Eli Zaretskii <eliz@gnu.org>
5928
03669ccb
EZ
5929 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5930 lines.
7061c986
EZ
5931 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5932 lines that are hscrolled on the left.
03669ccb 5933
352ec8ff
EZ
5934 * dispnew.c (buffer_posn_from_coords): Account for a possible
5935 presence of header-line. (Bug#4426)
5936
a66cfb1c
SM
59372011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5938
6b02f655
SM
5939 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5940 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5941
7c5ee88e
PE
59422011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5943
5944 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5945 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5946 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5947 this makes Emacs dump core during garbage collection on rare
5948 occasions. sizeof is obviously inferior to offsetof here, so
5949 stick with offsetof.
5950 (GC_POINTER_ALIGNMENT): New macro.
5951 (mark_memory): Omit 3rd (offset) arg; caller changed.
5952 Don't assume EMACS_INT alignment is the same as pointer alignment.
5953
df1bbe5b
SM
59542011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5955
5956 * keyboard.c (read_key_sequence_remapped): New var.
5957 (read_key_sequence): Compute remapping in the right buffer.
5958 (command_loop_1): Use read_key_sequence's remapping directly.
5959
51553db6
SM
59602011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5961
32c1fffd
SM
5962 * dired.c (file_name_completion): Don't expand file name.
5963 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5964 before checking file name handler.
5965
51553db6
SM
5966 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5967 they've been requested explicitly (bug#9591).
5968
b6bd1599 59692011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5970
5971 * keymap.c (Fsingle_key_description): Use make_specified_string
5972 instead of build_string to build string from push_key_description.
5973 (Bug#5193)
5974
f701dc2a
PE
59752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5976
4222c55d
PE
5977 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5978 This fixes a Y2038 bug on 64-bit hosts.
5979 * buffer.c (reset_buffer):
5980 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5981 (Fclear_buffer_auto_save_failure):
5982 Use 0, not -1, to represent an unset failure time, since time_t
5983 might not be signed.
5984
f701dc2a
PE
5985 Remove dependency on glibc malloc internals.
5986 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5987 Move back here from lisp.h, but with their new implementations.
5988 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5989 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5990 * charset.c (charset_table_init): New static var.
5991 (syms_of_charset): Use it instead of xmalloc. This removes a
5992 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5993 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5994 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5995 Move back to alloc.c.
5996 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5997 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5998
9ceebf39
JD
59992011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6000
6001 * nsterm.m (windowDidResize): Call x_set_window_size only when
6002 ns_in_resize is true. Otherwise set pixelwidth/height and
6003 call change_frame_size (Bug#9628).
6004
cb993c58
PE
60052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6006
3930c88b
PE
6007 Port --enable-checking=all to Fedora 14 x86-64.
6008 * charset.c (syms_of_charset): Also account for glibc malloc's
6009 internal overhead when calculating the initial malloc maximum.
6010
cb993c58
PE
6011 Port --enable-checking=all to Fedora 14 x86.
6012 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6013 Move to lisp.h.
6014 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6015 (overrun_check_realloc, overrun_check_free):
6016 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6017 That way, xmalloc returns a properly-aligned pointer even if
6018 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6019 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6020 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6021 into account when calculating the initial malloc maximum.
6022 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6023 Move here from alloc.c, so that charset.c can use it too.
6024 Properly align; the old code wasn't right for common 32-bit hosts
6025 when configured with --enable-checking=all.
6026 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6027 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6028
31bed486
EZ
60292011-09-29 Eli Zaretskii <eliz@gnu.org>
6030
04c70788 6031 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6032 use EDOM.
6033
fbcaa2f3
EZ
60342011-09-28 Eli Zaretskii <eliz@gnu.org>
6035
6036 * xdisp.c (compute_display_string_end): If there's no display
6037 string at CHARPOS, return -1.
6038
6039 * bidi.c (bidi_fetch_char): When compute_display_string_end
6040 returns a negative value, treat the character as a normal
6041 character not covered by a display string. (Bug#9624)
6042
a239d4e9
JB
60432011-09-28 Juanma Barranquero <lekktu@gmail.com>
6044
6045 * lread.c (Fread_from_string): Fix typo in docstring.
6046
88652fd5
EZ
60472011-09-27 Eli Zaretskii <eliz@gnu.org>
6048
6049 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6050 newline, reseat the iterator instead of bidi-iterating there one
6051 character at a time. (Bug#9610)
32c1fffd
SM
6052 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6053 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6054
ed497dd4
AS
60552011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6056
6057 * lread.c (readevalloop): Use correct code for NBSP.
6058 (read1): Likewise. (Bug#9608)
6059
b2bf61aa
MA
60602011-09-25 Michael Albinus <michael.albinus@gmx.de>
6061
6062 * dbusbind.c (Fdbus_register_signal): When service is not
6063 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6064
32bbb17c
GM
60652011-09-25 Glenn Morris <rgm@gnu.org>
6066
6067 * buffer.c (truncate-lines): Doc fix.
6068
94e0933e
CY
60692011-09-24 Chong Yidong <cyd@stupidchicken.com>
6070
6071 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6072 (Fset_window_next_buffers): Doc fix.
6073
cddde921
GM
60742011-09-24 Glenn Morris <rgm@gnu.org>
6075
6076 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6077
1260aef1
PE
60782011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6079
25b4bfa0
PE
6080 Fix minor problems found by static checking.
6081 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6082 * indent.c (Fvertical_motion): Fix == vs = typo.
6083
e3cbd34b
EZ
60842011-09-24 Eli Zaretskii <eliz@gnu.org>
6085
a66cfb1c
SM
6086 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6087 Default value is now t. Doc fix.
6bf7006f 6088
e3cbd34b 6089 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6090 logic when moving up, not only when moving down. Fix the
e3cbd34b 6091 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6092 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6093
6094 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6095 CHARPOS is covered by a display string which includes newlines.
6096 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6097 is covered by a display string with embedded newlines.
6098
a3de0cbd
MA
60992011-09-24 Michael Albinus <michael.albinus@gmx.de>
6100
6101 * dbusbind.c (Fdbus_register_signal): Add match rule to
6102 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6103 (Fdbus_register_method, Vdbus_registered_objects_table):
6104 Fix docstring.
a3de0cbd 6105
b260039d
JM
61062011-09-24 Jim Meyering <meyering@redhat.com>
6107
32c1fffd 6108 do not ignore write error for any output size
b260039d
JM
6109 The previous change was incomplete.
6110 While it makes emacs --batch detect the vast majority of stdout
6111 write failures, errors were still ignored whenever the output size is
6112 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6113 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6114 && echo FAIL: ignored write error
6115 FAIL: ignored write error
6116 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6117 && echo FAIL: ignored write error
6118 FAIL: ignored write error
6119 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6120
8eca8a7c
AS
61212011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6122
6123 * emacs.c (Fkill_emacs): In noninteractive mode exit
6124 non-successfully if a write error occurred on stdout. (Bug#9574)
6125
3341db62
EZ
61262011-09-21 Eli Zaretskii <eliz@gnu.org>
6127
6128 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6129 the xassert test.
6130
6131 * dispextern.h (struct it): Update the comment documenting what
6132 can it->OBJECT be.
6133
8c203dbf
EZ
61342011-09-20 Eli Zaretskii <eliz@gnu.org>
6135
6136 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6137 a display string, extend search for cursor position to end of row.
6138 (find_row_edges): If the row ends in a newline from a display
6139 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6140 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6141 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6142 non-empty line. Fixes confusing cursor motion with arrow keys at
6143 the beginning of a line that starts with whitespace.
8c203dbf 6144
a4824228
LMI
61452011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6146
6147 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6148 (bug#9493).
6149
33ed493b
CY
61502011-09-18 Chong Yidong <cyd@stupidchicken.com>
6151
6152 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6153 boolean (Bug#9154).
6154
56cd55c8
EZ
61552011-09-18 Eli Zaretskii <eliz@gnu.org>
6156
6157 * xdisp.c (display_line): Record maximum and minimum buffer
6158 positions even if no glyphs were produced (e.g., by a zero-width
6159 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6160 buffer positions that will be removed from the glyph row because
6161 they don't fit.
c02dcedf
EZ
6162 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6163 column is beyond frame width: don't subtract 1 "pixel" when
6164 computing width of the stretch.
3e62b7e0
EZ
6165 (reseat_at_next_visible_line_start): Undo the change made on
6166 2011-09-17 that saved paragraph information and restored it after
6167 the call to `reseat'. (Bug#9545)
56cd55c8 6168
5ed99d36 61692011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6170
6171 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6172 and turn window cursor on if cleared (Bug#9415).
6173
5ed99d36 61742011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6175
6176 * search.c (boyer_moore): Take unibyte characters from pattern
6177 literally. (Bug#9458)
6178
9bade7b2
EZ
61792011-09-18 Eli Zaretskii <eliz@gnu.org>
6180
6181 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6182
e5e9d610
PE
61832011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6184
87e4427a
PE
6185 Fix minor problem found by static checking.
6186 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6187 initialized, to pacify gcc -Wuninitialized.
6188
e5e9d610
PE
6189 * fileio.c: Report proper errno when syscall falls.
6190 (Finsert_file_contents): Save and restore errno,
6191 so that report_file_error outputs the correct diagnostic.
6192 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6193
a1674f0b
EZ
61942011-09-18 Eli Zaretskii <eliz@gnu.org>
6195
6196 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6197
fbfb6dd4
EZ
61982011-09-17 Eli Zaretskii <eliz@gnu.org>
6199
6200 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6201 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6202
bb187662
EZ
62032011-09-17 Eli Zaretskii <eliz@gnu.org>
6204
1137e8b8 6205 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6206 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6207
6208 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6209 (bidi_find_paragraph_start): Search back for paragraph beginning
6210 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6211 (bidi_move_to_visually_next): Only trigger paragraph-related
6212 computations when the last character is a newline or at EOB, not
6213 just any NEUTRAL_B. (Bug#9470)
6214
bb187662
EZ
6215 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6216 truncated lines if point is covered by a display string. (Bug#9524)
6217
2e621251
PE
62182011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6219
6220 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6221 (cons_to_x_long): New function.
6222 (lisp_data_to_selection_data): Use it. Correct the test for
6223 short-versus-long data; it was negated. Break out of vector
6224 loop, for efficiency, when a long datum is discovered.
6225
91a15bc6
SM
62262011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6227
6228 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6229
b41c3a35
EZ
62302011-09-16 Eli Zaretskii <eliz@gnu.org>
6231
6232 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6233 GCC PR/17406) by declaring this function with external scope.
6234
7812ba2d
PE
62352011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6236
6237 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6238 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6239
cf7edc2a
AS
62402011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6241
6242 * editfns.c (Fformat): Correctly handle text properties on "%%".
6243
bd01620e
EZ
62442011-09-15 Eli Zaretskii <eliz@gnu.org>
6245
6246 * xterm.c (x_draw_composite_glyph_string_foreground):
6247 * w32term.c (x_draw_composite_glyph_string_foreground):
6248 * term.c (encode_terminal_code):
6249 * composite.c (composition_update_it, get_composition_id):
6250 * xdisp.c (get_next_display_element)
6251 (fill_composite_glyph_string): Add comments about special meaning
6252 of TAB characters in a composition.
6253
a02719a3
PE
62542011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6255
6256 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6257 This occurs when processing a multibyte format.
6258 Problem reported by Wolfgang Jenker.
a02719a3 6259
72589a3c
JB
62602011-09-15 Johan Bockgård <bojohan@gnu.org>
6261
6262 * xdisp.c (try_cursor_movement): Only check for exact match if
6263 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6264
1c14176c
PE
62652011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6266
6267 Remove unused external symbols.
6268 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6269 * xdisp.c (calc_pixel_width_or_height): Now static.
6270 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6271 * indent.c (check_display_width):
6272 * w32term.c: Fix comment to match code.
6273 * xterm.c, xterm.h (x_catching_errors): Remove.
6274
d2eea5b5
PE
62752011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6276
6277 * xselect.c: Use signed conversions more consistently (Bug#9498).
6278 (selection_data_to_lisp_data): Assume incoming selection data are
6279 signed integers, not unsigned. This is to be consistent with
6280 outgoing selection data, which was modified to use signed integers
6281 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6282 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6283 expects long, not unsigned long.
6284
46888499
EZ
62852011-09-14 Eli Zaretskii <eliz@gnu.org>
6286
6287 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6288 computation of loop end. Reported by Johan Bockgård
6289 <bojohan@gnu.org>.
6290
ef8ef9fb
CY
62912011-09-13 Chong Yidong <cyd@stupidchicken.com>
6292
6293 * frame.c (Fother_visible_frames_p): Function deleted.
6294
fa819fed
EZ
62952011-09-12 Eli Zaretskii <eliz@gnu.org>
6296
6297 * indent.c (compute_motion): Process display vector front to back
6298 rather than the other way around. (Bug#2496)
6299
2ba8e008
SM
63002011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6301
6302 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6303
20f53c69
CY
63042011-09-11 Chong Yidong <cyd@stupidchicken.com>
6305
6306 * minibuf.c (Fread_from_minibuffer): Doc fix.
6307
d562d7a4
EZ
63082011-09-11 Eli Zaretskii <eliz@gnu.org>
6309
6310 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6311 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6312
1c4d7f3d
LMI
63132011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6314
6315 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6316 value for non-existent files.
6317
b885bf36
EZ
63182011-09-11 Eli Zaretskii <eliz@gnu.org>
6319
6320 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6321 set its "size" to -1. This will set the modtime_size field of
6322 the corresponding buffer to -1, which is what
6323 verify-visited-file-modtime expects for files that do not exist.
6324 (Bug#9139)
6325
6612f0bf
PE
63262011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6327
6328 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6329 here ...
6330 * lisp.h: ... from here. push_key_description is no longer
6331 defined in keyboard.c, so its declaration should not be in
6332 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6333 logically belongs with push_key_description.
6334
dfb3f755
PE
63352011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6336
6337 * buffer.h: Include <sys/types.h> instead of <time.h>.
6338 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6339 Problem reported by Herbert J. Skuhra.
6340
3134906c
LMI
63412011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6342
6343 * xml.c (parse_region): Make the parsing work for
6344 non-comment-starting XML files again (bug#9144).
6345
8d903f4e
AS
63462011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6347
6348 * image.c (gif_load): Fix calculation of bottom and right corner.
6349 (Bug#9468)
6350
80ad64f4
EZ
63512011-09-10 Eli Zaretskii <eliz@gnu.org>
6352
6353 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6354 redisplay in small windows.
6355
208a048d
EZ
63562011-09-09 Eli Zaretskii <eliz@gnu.org>
6357
6358 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6359
9b1c252e
MR
63602011-09-08 Martin Rudalics <rudalics@gmx.at>
6361
6362 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6363 Operate on live windows only.
6364
2949f33b
JB
63652011-09-08 Juanma Barranquero <lekktu@gmail.com>
6366
6367 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6368
e08dcafd
EZ
63692011-09-07 Eli Zaretskii <eliz@gnu.org>
6370
6371 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6372 only under bidi iteration.
6373
115b96bd
JD
63742011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6375
6376 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6377
c8199d0f
PE
63782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6379
6380 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6381 Without this fix, the command to link temacs failed due to an
6382 undefined symbol __builtin_isnan. This is because
6383 /usr/include/iso/math_c99.h #defines isnan(x) to
6384 __builtin_isnan(x), but the bundled gcc, which identifies itself
6385 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6386 a __builtin_isnan.
6387 * floatfns.c (isnan): #undef, and then #define to a clone of
6388 what's in data.c.
6389 (Fisnan): Always define, since it's always available now.
6390 (syms_of_floatfns): Always define isnan at the Lisp level.
6391
e39b275c 63922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6393
6394 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6395
b2db44d9 63962011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6397
f4af5137 6398 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6399 The previous code assumed that file offsets (off_t values) fit in
6400 EMACS_INT variables, which is not true on typical 32-bit hosts.
6401 The code messed up by falsely reporting buffer overflow in cases
6402 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6403 when "big" contains more than 2**29 bytes, even though this
6404 inserts just one byte and does not overflow the buffer.
6405 (Finsert_file_contents): Store file offsets as off_t
6406 values, not as EMACS_INT values. Check for overflow when
6407 converting between EMACS_INT and off_t. When checking for
6408 buffer overflow or for overlap, take the offsets into account.
6409 Don't use EMACS_INT for small values where int suffices.
6410 When checking for overlap, fix a typo: ZV was used where
6411 ZV_BYTE was intended.
6412 (Fwrite_region): Don't assume off_t fits into 'long'.
6413 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6414
ecfc0a49
MA
64152011-09-05 Michael Albinus <michael.albinus@gmx.de>
6416
6417 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6418
6511acf2 64192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6420
0999621a 6421 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6422
6423 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6424 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6425 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6426 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6427 (modify_event_symbol): Do not assume that the length of
6428 name_alist_or_stem is safe to alloca and fits in int.
6429 (Fexecute_extended_command): Likewise for function name and binding.
6430 (Frecursion_depth): Wrap around reliably on integer overflow.
6431 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6432 since some callers pass EMACS_INT values.
6433 (Fsingle_key_description): Don't crash if symbol name contains more
6434 than MAX_ALLOCA bytes.
6435 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6436 (get_minibuffer): Arg is now EMACS_INT, not int.
6437 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6438 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6439 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6440
2be7d702
PE
6441 * dbusbind.c (signature_cat): New function.
6442 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6443 Do not overrun buffer; instead, report string overflow.
6444
9d1df220
PE
6445 * dispnew.c (add_window_display_history): Don't overrun buffer.
6446 Truncate instead; this is OK since it's just a log.
6447
33ef5c64
PE
6448 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6449 even if the time zone offset is outlandishly large.
6450 Don't mishandle offset == INT_MIN.
6451
66c6fdd5
PE
6452 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6453 when creating daemon; the previous buffer-overflow check was incorrect.
6454
d749b01b
PE
6455 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6456 which has the guts of the old verror function.
6457
b5cd1905
PE
6458 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6459 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6460
6e1a67fb
PE
6461 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6462 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6463 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6464 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6465 length of string rather than counting it via multiple sprintfs;
6466 that's simpler and more reliable.
c21721cc
PE
6467 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6468 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6469 sprintf, in case result does not fit in int.
6470
c57b67fc
PE
6471 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6472 (fontset_from_font): Print it.
6473
8a401434
PE
6474 * frame.c (tty_frame_count): Now printmax_t, not int.
6475 (make_terminal_frame, set_term_frame_name): Print it.
6476 (x_report_frame_params): In X, window IDs are unsigned long,
6477 not signed long, so print them as unsigned.
6478 (validate_x_resource_name): Check for implausibly long names,
6479 and don't assume name length fits in 'int'.
6480 (x_get_resource_string): Don't blindly alloca invocation name;
6481 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6482 not fit in int.
6483
6e1a67fb
PE
6484 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6485 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6486 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6487
0df02bf3
PE
6488 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6489 Use esprintf, not sprintf, in case result does not fit in int.
6490
48e30793
PE
6491 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6492 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6493 it as a large positive number.
6494 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6495 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6496
a66ff6d8
PE
6497 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6498 in case result does not fit in int.
6499
aca216ff
PE
6500 * print.c (float_to_string): Detect width overflow more reliably.
6501 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6502 buffer overrun. Don't assume list length fits in 'int'. Treat
6503 print length of 0 as 0, not as infinity; to be consistent with other
6504 uses of print length in this function. Don't overflow print length
6505 index. Don't assume hash table size fits in 'long', or that
6506 vectorlike size fits in 'unsigned long'.
6507
31c286f7
PE
6508 * process.c (make_process): Use printmax_t, not int, to format
6509 process-name gensyms.
6510
55e5faa1
PE
6511 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6512
80f2e268
PE
6513 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6514 to avoid potential buffer overrun.
6515
670741ab
PE
6516 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6517 if X resource line is longer than 512 bytes.
6518
b7163a50
PE
6519 * xfns.c (x_window): Make sprintf buffer a bit bigger
6520 to avoid potential buffer overrun.
6521
ae58ff1f
PE
6522 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6523
c43c8a6a
PE
6524 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6525
3f8236f4
PE
65262011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6527
53e9fe90 6528 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6529 Without these, Emacs silently mishandles large integers sometimes.
6530 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6531 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6532
6511acf2
PE
6533 * xdisp.c (try_window_id): Check Emacs fixnum range before
6534 converting to 'int'.
806add1d 6535
6511acf2 6536 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6537 Check that an Emacs fixnum is in range before assigning it to 'int'.
6538 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6539 values converted from Emacs fixnums.
6540 (Frecenter): Don't wrap around a line count if it is out of 'int'
6541 range; instead, treat it as an extreme value.
6542 (Fset_window_configuration, compare_window_configurations):
6543 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6544
6511acf2
PE
6545 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6546 that can exceed INT_MAX. Check that EMACS_INT value is in range
6547 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6548 (match_limit): Don't assume that a fixnum can fit in 'int'.
6549
6511acf2 6550 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6551 exceed INT_MAX.
6552
6511acf2 6553 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6554 (Fvertical_motion): Don't wrap around LINES values that don't fit
6555 in 'int'. Instead, treat them as extreme values. This is good
6556 enough for windows, which can't have more than INT_MAX lines anyway.
6557
fcb901a7
LMI
65582011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6559
0f2f6b6d
LMI
6560 * Require libxml/parser.h to avoid compilation warning.
6561
fcb901a7
LMI
6562 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6563
6564 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6565 since this reportedly can destroy thread storage.
6566
6e20a0d4
CY
65672011-08-30 Chong Yidong <cyd@stupidchicken.com>
6568
6569 * syntax.c (find_defun_start): Update all cache variables if
6570 exiting early (Bug#9401).
6571
148ae00e
EZ
65722011-08-30 Eli Zaretskii <eliz@gnu.org>
6573
f6cfbd8f
EZ
6574 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6575
148ae00e
EZ
6576 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6577 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6578 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6579
6580 * term.c (tty_append_glyph): New function.
6581 (produce_stretch_glyph): Static function and its prototype deleted.
6582
a66cfb1c
SM
6583 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6584 Add prototypes.
148ae00e 6585
c4a07a4c
PE
65862011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6587
6588 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6589 when checking :margin (Bug#9390).
6590 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6591 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6592 so that the name doesn't mislead. All uses changed.
6593
6bc8cd65
JB
65942011-08-28 Johan Bockgård <bojohan@gnu.org>
6595
6596 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6597 set_tty_hooks.
6598
dca4927e
EZ
65992011-08-27 Eli Zaretskii <eliz@gnu.org>
6600
6601 * xdisp.c (move_it_to): Don't bail out early when reaching
6602 position beyond to_charpos, if we are scanning backwards.
6603 (move_it_vertically_backward): When DY == 0, make sure we get to
6604 the first character in the line after the newline.
6605
f2cad773
PE
66062011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6607
6608 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6609 (ccl_driver): Do not generate an out-of-range pointer.
6610 (Fccl_execute_on_string): Remove unnecessary check for
6611 integer overflow, noted by Stefan Monnier in
6612 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6613 Remove a FIXME that didn't need fixing.
6614 Simplify the newly-introduced buffer reallocation code.
6615
0cae2cdb
JB
66162011-08-27 Juanma Barranquero <lekktu@gmail.com>
6617
6618 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6619
5fc295a4 66202011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6621
70c60eb2 6622 Integer and memory overflow issues (Bug#9196).
726e0ab1 6623
d31850da
PE
6624 * doc.c (get_doc_string): Rework so that
6625 get_doc_string_buffer_size is the actual buffer size, rather than
6626 being 1 less than the actual buffer size; this makes xpalloc more
6627 convenient.
6628
a69fbedb
PE
6629 * image.c (x_allocate_bitmap_record, cache_image):
6630 * xselect.c (Fx_register_dnd_atom):
6631 Simplify previous changes by using xpalloc.
6632
fe5c5d37
PE
6633 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6634 since either will do and ptrdiff_t is convenient with xpalloc.
6635
0065d054
PE
6636 * charset.c (charset_table_size)
6637 (struct charset_sort_data.priority): Now ptrdiff_t.
6638 (charset_compare): Don't overflow if priorities differ greatly.
6639 (Fsort_charsets): Don't assume list length fits in int.
6640 Check for size-calculation overflow when allocating sort data.
6641 (syms_of_charset): Allocate an initial charset table that is
6642 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6643
6644 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6645
6646 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6647 The actual value is always <= INT_MAX, and leaving it unsigned made
6648 overflow checking harder.
6649
6650 * dispextern.h (struct glyph_matrix.rows_allocated)
6651 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6652 with xpalloc. The values are still always <= INT_MAX.
6653
6654 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6655
6656 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6657 (SAFE_NALLOCA): New macro.
6658
6659 * region-cache.c (struct boundary.pos, find_cache_boundary)
6660 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6661 (set_cache_region, invalidate_region_cache)
6662 (revalidate_region_cache, know_region_cache, region_cache_forward)
6663 (region_cache_backward, pp_cache):
6664 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6665 so that ptrdiff_t * can be passed to xpalloc.
6666 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6667 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6668 (pp_cache): Don't assume cache_len fits in int.
6669 * region-cache.h: Adjust extern decls to match.
6670
6671 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6672 EMACS_INT, since either will do, for xpalloc.
6673
6674 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6675 (xnmalloc, xnrealloc, xpalloc): New functions.
6676
726e0ab1
PE
6677 * bidi.c (bidi_shelve_header_size): New constant.
6678 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6679 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6680
51f30bc5 6681 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6682 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6683 (overlay_strings):
6684 Don't update size of array until after memory allocation succeeds,
6685 because xmalloc/xrealloc may not return.
0065d054
PE
6686 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6687 now that we have proper integer overflow checking.
6688 (record_overlay_string, overlay_strings): Catch overflows when
6689 calculating size of overlay_str_buf.
726e0ab1 6690
0065d054
PE
6691 * callproc.c (Fcall_process): Check for size overflow when
6692 calculating size of args2.
6693 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6694 Normally we prefer signed values, but sticking with ptrdiff_t would
6695 require adding more-complicated checks.
726e0ab1
PE
6696
6697 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6698 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6699 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6700 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6701
6702 * character.c (Fstring): Check for size-calculation overflow.
6703
6704 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6705 unnecessary integer overflow. Check for size overflow.
6706 (encode_coding_object): Don't update size until xmalloc succeeds.
6707
6708 * composite.c (get_composition_id): Check for overflow in glyph
6709 length calculations.
6710
6711 Integer and memory overflow fixes for display code.
6712 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6713 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6714 (scrolling_window): Check for overflow in size calculations.
6715 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6716 Don't assume glyph table len fits in int.
6717 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6718 (row_table_size): Now ptrdiff_t, not int.
6719 (scrolling_window): Avoid overflow in size calculations.
6720 Don't update size until allocation succeeds.
6721 * fns.c (concat): Check for overflow in size calculations.
6722 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6723 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6724 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6725
6726 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6727 (get_doc_string): Check for size calculation overflow.
6728 Don't update size until allocation succeeds.
6729 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6730 EMACS_INT, where ptrdiff_t will do.
6731 (Fsubstitute_command_keys): Check for string overflow.
6732
6733 * editfns.c (set_time_zone_rule): Don't assume environment length
6734 fits in int.
6735 (message_length): Now ptrdiff_t, not int.
6736 (Fmessage_box): Don't update size until allocation succeeds.
6737 Don't assume message length fits in int.
6738 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6739
0065d054
PE
6740 * emacs.c (main): Do not reallocate argv, since there is a null at
6741 the end that can be overwritten, and this way there's no need to
6742 worry about size-calculation overflow.
6743 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6744
6745 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6746 alloc succeeds.
6747 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6748
6749 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6750 (x_set_scroll_bar_width, x_figure_window_size):
6751 Check for integer overflow.
6752 (x_set_alpha): Do not assume XINT fits in int.
6753
6754 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6755 This is for the members text_lines, text_cols, total_lines, total_cols,
6756 where the system imposes an 'int' limit.
6757
6758 * fringe.c (Fdefine_fringe_bitmap):
6759 Don't update size until alloc works.
6760
6761 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6762 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6763
6764 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6765 Check for size-calculation overflow.
6766 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6767 do, as we prefer signed integers.
6768 (id_to_widget.max_size, id_to_widget.used)
6769 (xg_store_widget_in_map, xg_remove_widget_from_map)
6770 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6771 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6772 Use and return ptrdiff_t, not int.
6773 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6774 * gtkutil.h: Change prototypes to match the above.
6775
6776 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6777 are duplicate now that they've been promoted to lisp.h.
6778 (x_allocate_bitmap_record, x_alloc_image_color)
6779 (make_image_cache, cache_image, xpm_load):
6780 Don't update size until alloc is done.
6781 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6782 (x_detect_edges):
3256efce 6783 Check for size calculation overflow.
726e0ab1
PE
6784 (ct_colors_allocated_max): New constant.
6785 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6786 overflow.
3256efce 6787
726e0ab1
PE
6788 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6789 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6790 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6791 Use ptrdiff_t, not int, to count maps.
6792 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6793 calculations. Don't update size until allocation succeeds.
6794 Redo calculations to avoid overflow.
726e0ab1
PE
6795 * keyboard.h: Change prototypes to match the above.
6796
6797 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6798 to count maps.
6799 (current_minor_maps): Check for size calculation overflow.
6800 * keymap.h: Change prototypes to match the above.
6801
6802 * lread.c (read1, init_obarray): Don't update size until alloc done.
6803
6804 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6805 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6806
726e0ab1
PE
6807 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6808 Now ptrdiff_t, not int.
6809 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6810 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6811
6812 * process.c (Fnetwork_interface_list): Check for overflow
6813 in size calculation.
6814
6815 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6816
6817 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6818 overflow. Don't bother calling xmalloc when xrealloc will do.
6819
6820 * search.c (Freplace_match): Check for size calculation overflow.
6821 (Fset_match_data): Don't assume list lengths fit in 'int'.
6822
6823 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6824 for command line length. Do not attempt to address one before the
6825 beginning of an array, as that's not portable.
6826
6827 * term.c (max_frame_lines): Remove; unused.
6828 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6829 not int.
6830 (encode_terminal_code, calculate_costs): Check for size
6831 calculation overflow.
6832 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6833 table lengths and related sizes. Don't update size until alloc
6834 done. Redo calculations to avoid overflow.
6835 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6836
6837 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6838 subtracting pointers.
6839 (gobble_line): Check for overflow more carefully. Don't update size
6840 until alloc done.
6841
6842 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6843 Don't update size until alloc done.
6844 Redo size calculations to avoid overflow.
6845 Check for size calculation overflow.
0065d054 6846 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6847
6848 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6849 Use ptrdiff_t, not int, for sizes.
6850 (store_mode_line_noprop_char): Don't update size until alloc done.
6851
0065d054
PE
6852 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6853 Use ptrdiff_t, not int, for sizes.
6854 (Finternal_make_lisp_face, cache_face):
6855 Check for size calculation overflow.
6856 (cache_face): Treat size calculation overflows as if they were
6857 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6858
6859 * xfns.c (x_encode_text, x_set_name_internal)
6860 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6861 sizes, since they can exceed INT_MAX in size. Check for size
6862 calculation overflow.
6863
0065d054
PE
6864 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6865 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6866 Don't update size until alloc done.
6867
0065d054 6868 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6869 as sprintf is limited to int lengths.
1d526e2f 6870
252c5ee1
PE
6871 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6872 (X_LONG_MIN): New macros.
864d7ce7
PE
6873 Use them to make the following changes clearer.
6874 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6875 This change doesn't affect the value now, but it may help remind
6876 future maintainers not to raise the value too much later.
6877 (SELECTION_QUANTUM): Remove, replacing with ...
6878 (selection_quantum): ... new function, which avoids overflow.
6879 All uses changed.
6880 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6881 assumption that selection length fits in 'int'.
6882 (x_reply_selection_request, x_handle_selection_request)
6883 (x_get_window_property, receive_incremental_selection)
6884 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6885 (lisp_data_to_selection_data, clean_local_selection_data):
6886 Use ptrdiff_t, not int, to record length of selection.
6887 (x_reply_selection_request, x_get_window_property)
6888 (receive_incremental_selection, x_property_data_to_lisp):
6889 Redo calculations to avoid overflow.
6890 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6891 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6892 something.
6893 (x_get_window_property, receive_incremental_selection)
6894 (lisp_data_to_selection_data, x_property_data_to_lisp):
6895 Check for size-calculation overflow.
6896 (x_get_window_property, receive_incremental_selection)
6897 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6898 Don't store size until memory allocation succeeds.
6899 (x_get_window_property): Plug memory leak on memory exhaustion.
6900 Don't double-block input; malloc is safe here. Don't assume 2**34
6901 - 4 fits in unsigned long. Add an xassert to check
6902 XGetWindowProperty overflow. Be more careful about overflow
6903 calculations, and distinguish size from memory overflow better.
6904 (receive_incremental_selection): When tracing, don't assume
6905 unsigned int is less than INT_MAX.
6906 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6907 harmful) conversions of unsigned short to int.
6908 (lisp_data_to_selection_data): Don't assume that integers
6909 in the range -65535 through -1 fit in an X unsigned short.
6910 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6911 result parameters unless successful. Rely on cons_to_unsigned
6912 to report problems with elements; the old code wasn't right anyway.
6913 (x_check_property_data): Check for int overflow; we cannot use
6914 a wider type due to X limits.
6915 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6916
726e0ab1 6917 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6918
0065d054
PE
6919 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6920 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6921 (x_color_cells): Don't store size until memory allocation succeeds.
6922 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6923 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6924 (x_term_init): Don't assume length fits in int (sprintf is limited
6925 to int size).
bc18e09d 6926
ebfa62c0
PE
6927 Use ptrdiff_t for composition IDs.
6928 * character.c (lisp_string_width):
6929 * composite.c (composition_table_size, n_compositions)
6930 (get_composition_id, composition_gstring_from_id):
6931 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6932 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6933 * window.c (Frecenter):
6934 Use ptrdiff_t, not int, for composition IDs.
6935 * composite.c (get_composition_id): Check for integer overflow.
6936 * composite.h: Adjust prototypes to match the above changes.
6937
d3411f89
PE
6938 Use ptrdiff_t for hash table indexes.
6939 * category.c (hash_get_category_set):
6940 * ccl.c (ccl_driver):
6941 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6942 * coding.c (coding_system_charset_list, detect_coding_system):
6943 * coding.h (struct coding_system.id):
6944 * composite.c (get_composition_id, gstring_lookup_cache):
6945 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6946 * image.c (xpm_get_color_table_h):
6947 * lisp.h (hash_lookup, hash_put):
6948 * minibuf.c (Ftest_completion):
6949 Use ptrdiff_t for hash table indexes, not int (which is too
6950 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6951 32-bit --with-wide-int hosts).
6952
e097a6fa
PE
6953 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6954 Add a FIXME comment about memory leaks.
6955 (syms_of_charset): Don't assume xmalloc returns.
6956
5637687f
PE
6957 Don't assume that stated character widths fit in int.
6958 * character.c (Fchar_width, c_string_width, lisp_string_width):
6959 * character.h (CHAR_WIDTH):
6960 * indent.c (MULTIBYTE_BYTES_WIDTH):
6961 Use sanitize_char_width to avoid undefined and/or bad behavior
6962 with outlandish widths.
a66cfb1c 6963 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6964 now that we have two such functions. All uses changed.
6965 (sanitize_char_width): New inline function.
6966
a2271ba2
PE
6967 Don't assume that tab-width fits in int.
6968 * character.h (sanitize_width): New inline function.
6969 (SANE_TAB_WIDTH): New macro.
6970 (ASCII_CHAR_WIDTH): Use it.
6971 * indent.c (sane_tab_width): Remove. All uses replaced by
6972 SANE_TAB_WIDTH (current_buffer).
6973 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6974
18c52557
PE
6975 * fileio.c: Integer overflow issues with file modes.
6976 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6977
caeeedc1
PE
6978 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6979 Remove unreachable code.
6980 (read_hex, load_charset_map_from_file): Check for integer overflow.
6981
6df6ae42 6982 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6983 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6984 (x_send_scroll_bar_event): Likewise. Check that the size does not
6985 exceed limits imposed by XClientMessageEvent, as well as the usual
6986 ptrdiff_t and size_t limits.
6987
b13995db
PE
6988 * keyboard.c: Overflow, signedness and related fixes.
6989 (make_lispy_movement): Use same integer type in forward decl
6990 that is used in the definition.
6991 (read_key_sequence, keyremap_step):
6992 Change bufsize argument back to int, undoing my 2011-03-30 change.
6993 We prefer signed types, and int is wide enough here.
6994 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6995 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6996 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6997 length, not size_t. Use ptrdiff_t for index, not int.
6998 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6999 possibility of integer overflow.
7000
13464394
PE
7001 Overflow, signedness and related fixes for images.
7002
7003 * dispextern.h (struct it.stack[0].u.image.image_id)
7004 (struct_it.image_id, struct image.id, struct image_cache.size)
7005 (struct image_cache.used, struct image_cache.ref_count):
7006 * gtkutil.c (update_frame_tool_bar):
7007 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7008 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7009 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7010 * nsmenu.m (update_frame_tool_bar):
7011 * xdisp.c (calc_pixel_width_or_height):
7012 * xfns.c (image_cache_refcount):
7013 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7014 on typical 64-bit hosts.
7015
7016 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7017 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7018 Omit unnecessary casts to int.
7019 (parse_image_spec): Check that integers fall into 'int' range
7020 when the callers expect that.
7021 (image_ascent): Redo ascent calculation to avoid int overflow.
7022 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7023 (lookup_image): Remove unnecessary tests.
7024 (xbm_image_p): Locals are now of int, not EMACS_INT,
7025 since parse_image_check makes sure they fit into int.
7026 (png_load, gif_load, svg_load_image):
7027 Prefer int to unsigned where either will do.
7028 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7029 old tiff_error_handler and tiff_warning_handler.
7030 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7031 stack buffer overflows. It uses only the features of vsnprintf
7032 that are common to both POSIX and native Microsoft.
7033 (tiff_error_handler, tiff_warning_handler): Use it.
7034 (tiff_load, gif_load, imagemagick_load_image):
7035 Don't assume :index value fits in 'int'.
7036 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7037 (imagemagick_load_image): Check that crop parameters fit into
7038 the integer types that MagickCropImage accepts. Don't assume
7039 Vimagemagick_render_type has a nonnegative value. Don't assume
7040 size_t fits in 'long'.
7041 (gs_load): Use printmax_t to print the widest integers possible.
7042 Check for integer overflow when computing image height and width.
7043
c11821d4
EZ
70442011-08-26 Eli Zaretskii <eliz@gnu.org>
7045
7046 * xdisp.c (redisplay_window): Don't force window start if point
7047 will be invisible in the resulting window. (Bug#9324)
7048
0c95fcf7
EZ
70492011-08-25 Eli Zaretskii <eliz@gnu.org>
7050
7051 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7052 the display spec is of the form `(space ...)'.
7053 (handle_display_spec): Return the value returned by
7054 handle_single_display_spec, not just 1 or zero.
7055 (handle_single_display_spec): If the display spec is of the form
7056 `(space ...)', and specifies display in the text area, return 2
7057 rather than 1.
fee65a97 7058 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7059 accurately, and prefer exact match for point under bidi.
7060 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7061
7062 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7063 into disp_prop; all users changed.
7064
7065 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7066 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7067 for the text covered by the display property.
7068
e4ed06f1
CY
70692011-08-25 Chong Yidong <cyd@stupidchicken.com>
7070
7071 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7072 Change return value to nil.
7073 (Frecord_buffer): Delete unused function.
7074
f67cdd7f
EZ
70752011-08-24 Eli Zaretskii <eliz@gnu.org>
7076
5980d4c6
EZ
7077 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7078 buffers, return left-to-right.
8610fe8b
EZ
7079 (set_cursor_from_row): Consider candidate row a win if its glyph
7080 represents a newline and point is on that newline. Fixes cursor
7081 positioning on the newline at EOL of R2L text within L2R
7082 paragraph, and vice versa.
7083 (try_cursor_movement): Check continued rows, in addition to
7084 continuation rows. Fixes unwarranted scroll when point enters a
7085 continued line of R2L text within an L2R paragraph, or vice versa.
7086 (cursor_row_p): Consider the case of point being equal to
7087 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7088 from the end of a short line to the beginning of a continued line
7089 of R2L text within L2R paragraph.
7090 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7091 composed characters.
5980d4c6 7092
f67cdd7f
EZ
7093 * bidi.c (bidi_check_type): Use xassert.
7094 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7095 members.
7096
bca633fb
EZ
70972011-08-23 Eli Zaretskii <eliz@gnu.org>
7098
7099 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7100 a character.
7101
4a5885a7
CY
71022011-08-23 Chong Yidong <cyd@stupidchicken.com>
7103
7104 * nsfont.m (ns_otf_to_script): Fix typo.
7105
0902a04e
KH
71062011-08-22 Kenichi Handa <handa@m17n.org>
7107
7108 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7109 extra slot even if the purpose is char-code-property-table.
7110
1a2e6670
EZ
71112011-08-23 Eli Zaretskii <eliz@gnu.org>
7112
8ddde651
EZ
7113 * xdisp.c (redisplay_window): When computing centering_position,
7114 account for the height of the header line. (Bug#8874)
7115
425cc014
EZ
7116 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7117 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7118 candidate is selected by the mouse, and that candidate has a
7119 composed character under the mouse.
7120
1a2e6670
EZ
7121 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7122 coordinates reported by pos-visible-in-window-p for a composed
7123 character in column zero.
7124
8b76d6f8
SM
71252011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7126
7127 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7128
dac347dd
EZ
71292011-08-22 Eli Zaretskii <eliz@gnu.org>
7130
7131 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7132 consider it a hit if to_charpos is anywhere in the range of the
7133 composed buffer positions.
7134
e013fb34
CY
71352011-08-22 Chong Yidong <cyd@stupidchicken.com>
7136
7137 * image.c (gif_load): Don't assume that each subimage has the same
7138 dimensions as the base image. Handle disposal method that is
7139 "undefined" by the gif spec (Bug#9335).
7140
bd1ba3e8
CY
71412011-08-20 Chong Yidong <cyd@stupidchicken.com>
7142
7143 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7144 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7145
54a1215b
EZ
71462011-08-19 Eli Zaretskii <eliz@gnu.org>
7147
823564e5
EZ
7148 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7149 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7150 from an Org mode buffer to a Speedbar frame.
7151
54a1215b
EZ
7152 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7153 a composition, take its buffer position from IT->cmp_it.charpos.
7154 Fixes cursor positioning at the beginning of a line that begins
7155 with a composed character.
7156
9778ebcc
EZ
71572011-08-18 Eli Zaretskii <eliz@gnu.org>
7158
0be6ee06
EZ
7159 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7160 character bidirectional type, use STRONG_L instead. Fixes crashes
7161 in a buffer produced by `describe-categories'.
7162
9778ebcc
EZ
7163 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7164 members before the level stack, so they would be saved and
7165 restored when copying iterator state. Fixes incorrect reordering
7166 around TABs covered by display properties.
7167
156bffbe
AS
71682011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7169
6b02f655 7170 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7171
72ad093b
CY
71722011-08-17 Chong Yidong <cyd@stupidchicken.com>
7173
7174 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7175 (internal_condition_case_2, internal_condition_case_n):
7176 Remove unnecessary aborts (Bug#9081).
72ad093b 7177
35774242
EZ
71782011-08-17 Eli Zaretskii <eliz@gnu.org>
7179
7180 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7181 has no `load' handler, try opening the file locally. (Bug#9311)
7182
db76dd85
KB
71832011-08-16 Ken Brown <kbrown@cornell.edu>
7184
7185 * gmalloc.c: Expand comment.
7186
b215eee5
EZ
71872011-08-16 Eli Zaretskii <eliz@gnu.org>
7188
7189 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7190 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7191
a4579d33
KB
71922011-08-16 Ken Brown <kbrown@cornell.edu>
7193
7194 Fix memory allocation problems in Cygwin build (Bug#9273).
7195
7196 * unexcw.c ( __malloc_initialized): Declare external variable.
7197 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7198
8b76d6f8
SM
7199 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7200 New variables.
a4579d33
KB
7201 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7202 dumped emacs.
7203 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7204 in the static heap.
7205 [CYGWIN] (special_realloc): New function.
7206 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7207 requests to realloc storage in the static heap.
7208
3ebec551
PE
72092011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7210
7211 * bidi.c (bidi_initialize): Remove unused local.
7212
9fd8be00
EZ
72132011-08-15 Eli Zaretskii <eliz@gnu.org>
7214
6b02f655
SM
7215 * bidimirror.h:
7216 * biditype.h: Remove file.
7217 * makefile.w32-in ($(BLD)/bidi.$(O)):
7218 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7219
7220 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7221
7222 * chartab.c: Improve commentary for the uniprop_table API.
7223
32413314
EZ
7224 * bidi.c (bidi_paragraph_init): Support zero value of
7225 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7226 (bidi_initialize): Use uniprop_table instead of including
7227 biditype.h and bidimirror.h.
32413314 7228
9fd8be00
EZ
7229 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7230 coordinates of the iterator when restoring from ppos_it.
7231 (Bug#9296)
7232
5cf2b69b
KH
72332011-08-14 Kenichi Handa <handa@m17n.org>
7234
7235 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7236 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7237
daf17d00
EZ
72382011-08-14 Eli Zaretskii <eliz@gnu.org>
7239
7240 * xdisp.c (move_it_in_display_line_to): Don't invoke
7241 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7242 ppos_it. Fixes vertical cursor motion when line beginning is
7243 covered by an image. (Bug#9296)
7244
08e3161a
JD
72452011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7246
7247 * nsterm.h (ns_run_ascript): Declare.
7248 (NSAPP_DATA2_RUNASSCRIPT): Define.
7249
7250 * nsfns.m (as_script, as_result, as_status): New static variables.
7251 (ns_run_ascript): New function.
5e617bc2 7252 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7253 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7254 the event loop. Get status from as_status (Bug#7276).
7255
7256 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7257 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7258 the event loop (Bug#7276).
7259
a3720aa2
AS
72602011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7261
7262 * gnutls.c (QCgnutls_bootprop_priority)
7263 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7264 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7265 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7266 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7267 (QCgnutls_bootprop_verify_hostname_error)
7268 (QCgnutls_bootprop_callbacks_verify): Rename from
7269 Qgnutls_bootprop_..., all uses changed.
7270
7271 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7272 uses changed.
7273
0a0d27fb
PE
72742011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7275
19d5c50c
PE
7276 * xfaces.c (Qframe_set_background_mode): Now static.
7277 * dispextern.h (Qframe_set_background_mode): Remove decl.
7278
0a0d27fb
PE
7279 * process.c (Fnetwork_interface_info): Declare local only if needed.
7280
377538cb
JD
72812011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7282
7283 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7284 (Fnetwork_interface_list): Allocate in increments of bytes instead
7285 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7286 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7287 sockaddr.
7288 (struct ifflag_def): notrailers is smart on OSX.
7289 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7290 Get hardware address with getifaddrs if available.
7291
08fff70c
EZ
72922011-08-12 Eli Zaretskii <eliz@gnu.org>
7293
7294 * xdisp.c (iterate_out_of_display_property): xassert that
7295 IT->position is set to within IT->object's boundaries. Break from
7296 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7297 when IT->position is set up wrongly due to some bug.
7298 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7299 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7300 entry. Force push_it to save on the stack the current
7301 buffer/string position, to be restored by pop_it. Fix flags in
7302 the iterator structure wrt the object coming from a display
7303 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7304 properties. (Bug#9284)
7305
7be1c708 73062011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7307
7be1c708
CY
7308 * fontset.c (fontset_get_font_group): Add proper type checks.
7309 (Bug#9172)
aac0c6e3 7310
7be1c708 73112011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7312
7be1c708
CY
7313 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7314 and LC_VERSION_MIN_MACOSX.
7315 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7316 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7317
97bb72a6
EZ
73182011-08-08 Eli Zaretskii <eliz@gnu.org>
7319
7320 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7321 no-display-properties-and-no-overlays under bidi display.
7322 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7323 properties and overlays.
97bb72a6 7324
d5617611
CY
73252011-08-08 Chong Yidong <cyd@stupidchicken.com>
7326
37e11a63
CY
7327 * editfns.c (Fset_time_zone_rule): Document relationship with the
7328 setenv function.
7329
d5617611
CY
7330 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7331 the font entity extracted from the cache (Bug#8109).
7332
58872834
CY
73332011-08-07 Chong Yidong <cyd@stupidchicken.com>
7334
7335 * composite.c (autocmp_chars): Don't reset point. That is done by
7336 restore_point_unwind (Bug#5984).
7337
75bfc667
JL
73382011-08-07 Juri Linkov <juri@jurta.org>
7339
7340 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7341 to show the arg `TIME' instead of `TIMEVAL'.
7342
d1410150
EZ
73432011-08-06 Eli Zaretskii <eliz@gnu.org>
7344
7345 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7346 display property strides EOL and includes a newline, as in
7347 longlines-mode. (Bug#9254)
75b771e4
EZ
7348 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7349 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7350
7351 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7352 is non-zero, even if the data buffer is NULL. Fixes a crash in
7353 vertical-motion with longlines-mode. (Bug#9254)
7354
35928349
EZ
73552011-08-05 Eli Zaretskii <eliz@gnu.org>
7356
ec7cc85b
EZ
7357 * bidi.c <bidi_cache_total_alloc>: Now static.
7358 (bidi_initialize): Initialize bidi_cache_total_alloc.
7359
8b76d6f8 7360 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7361 cache. (Bug#9221)
7362
7363 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7364 amount allocated this far in `bidi_cache_total_alloc'.
7365 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7366 non-zero, only free the data buffer without restoring the cache
7367 contents. All callers changed.
7368
7369 * dispextern.h (bidi_unshelve_cache): Update prototype.
7370
7371 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7372 (move_it_in_display_line, move_it_to)
7373 (move_it_vertically_backward, move_it_by_lines): Replace the call
7374 to xfree to an equivalent call to bidi_unshelve_cache.
7375 (move_it_in_display_line_to): Fix logic of returning
412b6358 7376 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7377
e2e2423b
EZ
73782011-08-05 Eli Zaretskii <eliz@gnu.org>
7379
7380 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7381 came from a string character with a `cursor' property. (Bug#9229)
7382
ae9e757a
JD
73832011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7384
7385 * Makefile.in (LIB_PTHREAD): New variable.
7386 (LIBES): Add LIB_PTHREAD (Bug#9216).
7387
7388 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7389 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7390
213bd7f2
AS
73912011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7392
6b02f655 7393 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7394
99aaf75f
JD
73952011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7396
7397 * xterm.c (x_find_topmost_parent): New function.
7398 (x_set_frame_alpha): Find topmost parent window with
7399 x_find_topmost_parent and set the property there also (bug#9181).
7400 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7401
c74e9d86
PE
74022011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7403
7404 * callproc.c (Fcall_process): Avoid vfork clobbering
7405 the local vars buffer, coding_systems, current_dir.
7406
640c8776
SM
74072011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7408
7409 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7410
f26d0e4c
PE
74112011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7412
8a10d76c
PE
7413 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7414 so that it is not optimized away.
7415
f26d0e4c
PE
7416 * xdisp.c (compute_display_string_pos): Remove unused local.
7417
55439c61
EZ
74182011-08-02 Eli Zaretskii <eliz@gnu.org>
7419
7420 Fix slow cursor motion and scrolling in large buffers with
7421 selective display, like Org Mode buffers. (Bug#9218)
7422
7423 * dispextern.h (struct bidi_it): New member disp_prop_p.
7424
7425 * xdisp.c: Remove one-slot cache of display string positions.
7426 (compute_display_string_pos): Accept an additional argument
5e617bc2 7427 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7428 for a display string or property. If found, set DISP_PROP_P
7429 non-zero.
7430
7431 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7432 DISP_PROP_P, and pass it to compute_display_string_pos.
7433 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7434 non-zero. All callers of bidi_fetch_char changed.
7435
fb33fa43
SM
74362011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7437
7438 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7439
b099e063
DM
74402010-12-03 Don March <don@ohspite.net>
7441
7442 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7443 last character M-[char] is translated to ESC [char] (bug#7541).
7444
5cc7f7af
KH
74452011-08-02 Kenichi Handa <handa@m17n.org>
7446
d0fffa3f 7447 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7448
7449 * chartab.c (uniprop_table): Make it non-static.
7450
525d5e6e
EZ
74512011-08-01 Eli Zaretskii <eliz@gnu.org>
7452
7453 * xdisp.c (forward_to_next_line_start): Accept additional argument
7454 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7455 on the newline.
7456 (reseat_at_next_visible_line_start): Use the bidi iterator state
7457 returned by forward_to_next_line_start to restore the state of
7458 it->bidi_it after backing up to previous newline. (Bug#9212)
7459
31011111
AS
74602011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7461
7462 * regex.c (re_comp): Protoize.
7463 (re_exec): Fix return type.
7464 (regexec): Fix type of `ret'. (Bug#9203)
7465
476371c4
PE
74662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7467
e5d76069
PE
7468 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7469 This is needed if max-image-size is a floating-point number.
7470
9a79b20c
AS
74712011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7472
7473 * print.c (print_object): Print empty symbol as ##.
7474
7475 * lread.c (read1): Read ## as empty symbol.
7476
d8c2fa78
AA
74772011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7478
7479 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7480 setting frame foreground color (Bug#9175).
7481 (x_set_background_color): Likewise.
7482
ffe57a7a
AA
7483 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7484 contents (Bug#9176).
7485 (EmacsTooltip -init): Remove bezels and add shadows to
7486 tooltip windows.
7487
bf3492a5
AA
7488 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7489 or scroll bar (Bug#8470).
7490
d55e9c53
AA
7491 * nsfont.m (nsfont_open): Remove assignment to voffset and
7492 unnecessary vars hshink, expand, hd, full_height, min_height.
7493 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7494
7495 * nsterm.h (nsfont_info): Remove voffset field.
7496
d8c2fa78 74972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7498
7499 Implement strike-through and overline on NextStep (Bug#8863).
7500
7501 * nsfont.m (nsfont_open): Use underline position provided by font,
7502 instead of hard-coded value of 2.
7503 (nsfont_draw): Call ns_draw_text_decoration instead.
7504
7505 * nsterm.h: Add declaration for ns_draw_text_decoration.
7506
7507 * nsterm.m (ns_draw_text_decoration): New function for drawing
7508 underline, overline, and strike-through.
7509 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7510 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7511 accommodate underlining, etc.
4843aac3 7512
4cc60b9b
EZ
75132011-07-28 Eli Zaretskii <eliz@gnu.org>
7514
bc7ece87
EZ
7515 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7516 default.
4cc60b9b 7517
476371c4
PE
75182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7519
66606eea
PE
7520 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7521 Without this fix, if a signal arrives just after memory fills up,
7522 'malloc' might be invoked reentrantly.
7523
476371c4
PE
7524 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7525 In other words, assume that every image size is allowed, on non-X
7526 hosts. This assumption is probably wrong, but it lets Emacs compile.
7527
f3fcc40d
AS
75282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7529
7530 * regex.c (re_iswctype): Convert return values to boolean.
7531
350c992f
EZ
75322011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7533
7534 * xdisp.c (compute_display_string_pos): Don't use cached display
7535 string position if the buffer had its restriction changed.
7536 (Bug#9184)
7537
5266b4bb
PE
75382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7539
7540 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7541
2573a837 75422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7543
41f55ccd 7544 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7545
39e378da
PE
7546 * bidi.c: Integer size and overflow fixes.
7547 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7548 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7549 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7550 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7551 (bidi_find_other_level_edge):
7552 Use ptrdiff_t instead of EMACS_INT where either will do.
7553 This works better on 32-bit hosts configured --with-wide-int.
7554 (bidi_cache_ensure_space): Check for size-calculation overflow.
7555 Use % rather than repeated addition, for better worst-case speed.
7556 Don't set bidi_cache_size until after xrealloc returns, because it
7557 might not return.
7558 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7559 (bidi_cache_ensure_space): Also check that the bidi cache size
7560 does not exceed that of the largest Lisp string or buffer. See Eli
7561 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7562
5e927815
PE
7563 * alloc.c (__malloc_size_t): Remove.
7564 All uses replaced by size_t. See Andreas Schwab's note
7565 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7566
ca4aa935
PE
7567 * image.c: Improve checking for integer overflow.
7568 (check_image_size): Assume that f is nonnull, since
7569 it is always nonnull in practice. This is one less thing to
7570 worry about when checking for integer overflow later.
7571 (x_check_image_size): New function, which checks for integer
7572 overflow issues inside X.
7573 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7574 This removes the need for a memory_full check.
7575 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7576 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7577 (xbm_read_bitmap_data): Change locals back to 'int', since
7578 their values must fit in 'int'.
7579 (xpm_load_image, png_load, tiff_load):
7580 Invoke x_create_x_image_and_pixmap earlier,
7581 to avoid much needless work if the image is too large.
7582 (tiff_load): Treat overly large images as if
7583 x_create_x_image_and_pixmap failed, not as malloc failures.
7584 (gs_load): Use x_check_image_size.
7585
5f8f9cc2
PE
7586 * gtkutil.c: Omit integer casts.
7587 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7588 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7589
5adf60bc
PE
7590 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7591
c8907a93
PE
7592 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7593 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7594 would wrongly return t on a 64-bit host.
7595
e3c25c68
PE
7596 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7597 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7598 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7599 and therefore cause GCC to emit a bogus diagnostic in some cases.
7600
3f791afe
PE
7601 * image.c: Integer signedness and overflow and related fixes.
7602 This is not an exhaustive set of fixes, but it's time to
7603 record what I've got.
7604 (lookup_pixel_color, check_image_size): Remove redundant decls.
7605 (check_image_size): Don't assume that arbitrary EMACS_INT values
7606 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7607 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7608 (tiff_load, imagemagick_load_image):
7609 Check for overflow in size calculations.
7610 (x_create_x_image_and_pixmap): Remove unnecessary test for
7611 xmalloc returning NULL; that can't happen.
7612 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7613 (xpm_color_bucket): Use better integer hashing function.
7614 (xpm_cache_color): Don't possibly over-allocate memory.
7615 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7616 (gif_memory_source):
7617 Use ptrdiff_t, not int or size_t, to record sizes.
7618 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7619 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7620 either works, as we prefer signed integers.
7621 (tiff_read_from_memory, tiff_write_from_memory):
7622 Return tsize_t, not size_t, since that's what the TIFF API wants.
7623 (tiff_read_from_memory): Don't fail simply because the read would
7624 go past EOF; instead, return a short read.
7625 (tiff_load): Omit no-longer-needed casts.
7626 (Fimagemagick_types): Don't assume size fits into 'int'.
7627
3cc5a532
PE
7628 Improve hashing quality when configured --with-wide-int.
7629 * fns.c (hash_string): New function, taken from sxhash_string.
7630 Do not discard information about ASCII character case; this
7631 discarding is no longer needed.
7632 (sxhash-string): Use it. Change sig to match it. Caller changed.
7633 * lisp.h: Declare it.
7634 * lread.c (hash_string): Remove, since we now use fns.c's version.
7635 The fns.c version returns a wider integer if --with-wide-int is
7636 specified, so this should help the quality of the hashing a bit.
7637
b312a492
PE
7638 * emacs.c: Integer overflow minor fix.
7639 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7640 Define only if GNU_LINUX.
7641 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7642
dfd153ae
PE
7643 * dispnew.c: Integer signedness and overflow fixes.
7644 Remove unnecessary forward decls, that were a maintenance hassle.
7645 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7646 All uses changed.
7647 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7648 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7649 (prepare_desired_row, line_draw_cost):
7650 Use int, not unsigned, where either works.
7651 (save_current_matrix, restore_current_matrix):
7652 Use ptrdiff_t, not size_t, where either works.
7653 (init_display): Check for overflow more accurately, and without
7654 relying on undefined behavior.
7655
a81d11a3
PE
7656 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7657 Remove, replacing with the new symbols in lisp.h. All uses changed.
7658 * fileio.c (make_temp_name):
7659 * filelock.c (lock_file_1, lock_file):
7660 * xdisp.c (message_dolog):
7661 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7662 Use pMd etc. instead.
7663 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7664 replacing the pWIDE etc. symbols removed from editfns.c.
7665
3300e6fd
PE
7666 * keyboard.h (num_input_events): Now uintmax_t.
7667 This is (very slightly) less likely to mess up due to wraparound.
7668 All uses changed.
7669
fd05c7e9
PE
7670 * buffer.c: Integer signedness fixes.
7671 (alloc_buffer_text, enlarge_buffer_text):
7672 Use ptrdiff_t rather than size_t when either will do, as we prefer
7673 signed integers.
7674
903fe15d
PE
7675 * alloc.c: Integer signedness and overflow fixes.
7676 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7677 (__malloc_size_t): Default to size_t, not to int.
7678 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7679 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7680 Prefer ptrdiff_t to size_t when either would do, as we prefer
7681 signed integers.
7682 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7683 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7684 Now const. Initialize with values that are in range even if char
7685 is signed.
7686 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7687 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7688 These functions do the right thing with sizes > 2**32.
7689 (check_depth): Now ptrdiff_t, not int.
7690 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7691 Adjust to new way of storing sizes. Check for size overflow bugs
7692 in rest of code.
7693 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7694 slightly wrong anyway, as it missed one instance of
7695 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7696 (refill_memory_reserve): Omit needless cast to size_t.
7697 (mark_object_loop_halt): Mark as externally visible.
7698
ac82cc6a
PE
7699 * xselect.c: Integer signedness and overflow fixes.
7700 (Fx_register_dnd_atom, x_handle_dnd_message):
7701 Use ptrdiff_t, not size_t, since we prefer signed.
7702 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7703 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7704 x_dnd_atoms_size and x_dnd_atoms_length.
7705
c2d1e36d
PE
7706 * doprnt.c: Prefer signed to unsigned when either works.
7707 * eval.c (verror):
7708 * doprnt.c (doprnt):
7709 * lisp.h (doprnt):
7710 * xdisp.c (vmessage):
7711 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7712 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7713 prefer signed arithmetic to avoid comparison confusion.
7714 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7715 but is a bit tricky.
7716
0e926e56
PE
7717 Assume freestanding C89 headers, string.h, stdlib.h.
7718 * data.c, doprnt.c, floatfns.c, print.c:
7719 Include float.h unconditionally.
7720 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7721 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7722 * regex.c: Likewise for stddef.h, string.h.
7723 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7724 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7725 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7726 (STDC_HEADERS): Remove obsolete defines.
7727 * sysdep.c: Include limits.h unconditionally.
7728
9cfdb3ec
PE
7729 Assume support for memcmp, memcpy, memmove, memset.
7730 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7731 * regex.c (memcmp, memcpy):
7732 Remove; we assume C89 now.
7733
7734 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7735 (__malloc_safe_bcopy): Remove; no longer needed.
7736
cf950e6b 7737 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7738 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7739 well either way, and we prefer signed to unsigned.
7740
dbf38e02
LMI
77412011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7742
7743 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7744 closes the connection while we're reading (bug#9182).
7745
d6f0886c 77462011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7747
d6f0886c
JD
7748 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7749 are specified (Bug#9168).
24e0f6b1 7750
2eb1f9e6
PE
77512011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7752
7753 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7754 Found by GCC static checking and --with-wide-int on a 32-bit host.
7755
22381272 77562011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7757
7758 * xdisp.c (compute_display_string_pos): Fix logic of caching
7759 previous display string position. Initialize cached_prev_pos to
7760 -1. Fixes slow-down at the beginning of a buffer.
7761
f25e39b4
EZ
77622011-07-24 Eli Zaretskii <eliz@gnu.org>
7763
7764 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7765 for attrs[LFACE_FONTSET_INDEX].
7766
04c4b52e
PE
77672011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7768
7769 * xml.c (parse_region): Remove unused local
7770 that was recently introduced.
7771
c1734fbd
EZ
77722011-07-23 Eli Zaretskii <eliz@gnu.org>
7773
be18c5a5
EZ
7774 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7775 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7776
c1734fbd
EZ
7777 * xdisp.c (move_it_in_display_line_to): Record the best matching
7778 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7779 exit if none of the characters scanned was an exact match.
7780 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7781 when exact match is impossible due to invisible text, and the
7782 lines are truncated.
7783
a258d627
JD
77842011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7785
7786 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7787 for OSX >= 10.7.
7788
b6d5a689
EZ
77892011-07-22 Eli Zaretskii <eliz@gnu.org>
7790
0f74f785
EZ
7791 Fix a significant slow-down of cursor motion with C-n, C-p,
7792 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7793 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7794 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7795 (next_element_from_buffer): Call compute_stop_pos_backwards to
7796 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7797 base_level_stop.
7798 (reseat): Don't look for prev_stop, as that could mean a very long
7799 run.
7800 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7801 <cached_disp_overlay_modiff>: Cache for last found display string
7802 position.
551918c1 7803 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7804 about the same buffer in the same area of character positions, and
7805 the buffer wasn't changed since the time the display string
7806 position was cached.
551918c1 7807
b2d0c91a
EZ
78082011-07-22 Eli Zaretskii <eliz@gnu.org>
7809
7810 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7811 is an integer, which is important for empty lines. (Bug#9149)
7812
043604ee
CY
78132011-07-22 Chong Yidong <cyd@stupidchicken.com>
7814
7815 * frame.c (Fmodify_frame_parameters): In tty case, update the
7816 default face if necessary (Bug#4238).
7817
da4adb04
CY
78182011-07-21 Chong Yidong <cyd@stupidchicken.com>
7819
7820 * editfns.c (Fstring_to_char): No need to explain what a character
7821 is in the docstring (Bug#6576).
7822
9abd0532
LMI
78232011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7824
7825 * xml.c (parse_region): Make sure we always return a tree.
7826
36881d16
HK
78272011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7828
7829 * xml.c (parse_region): If a document contains only comments,
7830 return that, too.
7831
1e98674d
LMI
78322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7833
7834 * xml.c (make_dom): Return comments, too.
7835
590bd467
PE
78362011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7837
7838 Port to OpenBSD.
7839 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7840 and the surrounding thread.
7841 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7842 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7843 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7844 timer goes off.
7845 * s/openbsd.h (BROKEN_SIGIO): Define.
7846 * unexelf.c (unexec) [__OpenBSD__]:
7847 Don't update the .mdebug section of the Alpha COFF symbol table.
7848
f41628b2
LMI
78492011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7850
7851 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7852 (bug#8460).
7853
b59b67c5
PE
78542011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7855
15e3a074
PE
7856 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7857 This fixes some race conditions on the permissions of any newly
7858 created file.
7859
41bed37d
PE
7860 * alloc.c (valid_pointer_p): Use pipe, not open.
7861 This fixes some permissions issues when debugging.
7862
b59b67c5
PE
7863 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7864 If fchown fails to set both uid and gid, try to set just gid,
7865 as that is sometimes allowed. Adjust the file's mode to eliminate
7866 setuid or setgid bits that are inappropriate if fchown fails.
7867
925a6be7
SM
78682011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7869
7870 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7871 to compare Lisp_Objects.
7872 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7873 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7874 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7875
52968808
AS
78762011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7877
0a6a104b
AS
7878 * lread.c (read_integer): Unread even EOF character.
7879 (read1): Likewise. Properly record start position of symbol.
7880
52968808
AS
7881 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7882 symbol character follows.
7883
9e381cdd
PE
78842011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7885
7886 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7887 This works around a problem with the previous change to Fcopy_file.
7888 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7889 and without this change, GCC might complain about discarding
7890 fchown's return value.
7891
b5641435
JB
78922011-07-16 Juanma Barranquero <lekktu@gmail.com>
7893
7894 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7895
a8031457
PE
78962011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7897
7898 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7899
dd889327
LMI
79002011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7901
750c33f7
LMI
7902 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7903 it's used from the C level.
7904
dd889327
LMI
7905 * process.c: Use the same condition for POLL_FOR_INPUT in both
7906 keyboard.c and process.c (bug#1858).
7907
87e86684
LM
79082011-07-09 Lawrence Mitchell <wence@gmx.li>
7909
7910 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7911 (Fgnutls_boot): Use it.
7912
64348f40
AS
79132011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7914
7915 * doc.c (Fsubstitute_command_keys): Revert last change.
7916
1d698799
LMI
79172011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7918
f863868c
LMI
7919 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7920 quotes the next character, and doesn't affect other longer
7921 sequences (bug#8935).
7922
1d698799
LMI
7923 * lread.c (syms_of_lread): Clarify that is isn't only
7924 `eval-buffer' and `eval-defun' that's affected by
7925 `lexical-binding' (bug#8460).
7926
aa4b6df6
EZ
79272011-07-15 Eli Zaretskii <eliz@gnu.org>
7928
7929 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7930 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7931
5d856da6
PE
79322011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7933
ad6042bb
PE
7934 Fix minor problems found by static checking.
7935 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7936 (elsz): Now a signed constant, not a size_t var. We prefer signed
7937 types to unsigned, to avoid integer comparison confusion. Without
7938 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7939 "cannot optimize loop, the loop counter may overflow", a symptom
7940 of the confusion.
f00bbb22 7941 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7942 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7943
6468f31c
LMI
79442011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7945
49080b10
LMI
7946 * search.c (Fre_search_backward): Mention `case-fold-search' in
7947 all the re_search_* functions (bug#8138).
7948
6468f31c
LMI
7949 * keyboard.c (Fopen_dribble_file): Document when the file is
7950 closed (bug#8056).
7951
c965adc5
EZ
79522011-07-14 Eli Zaretskii <eliz@gnu.org>
7953
df9733bf
EZ
7954 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7955 bidi_cache_idx.
7956
0bb23927
EZ
7957 Support bidi reordering of display and overlay strings.
7958 * xdisp.c (compute_display_string_pos)
7959 (compute_display_string_end): Accept additional argument STRING.
7960 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7961 (reseat_to_string): Initialize bidi_it->string.s and
7962 bidi_it->string.schars.
7963 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7964 NULL (avoids a crash in bidi_paragraph_init).
7965 Initialize itb.string.lstring.
0bb23927
EZ
7966 (init_iterator): Call bidi_init_it only of a valid
7967 buffer position was specified. Initialize paragraph_embedding to
7968 L2R.
7969 (reseat_to_string): Initialize the bidi iterator.
7970 (display_string): If we need to ignore text properties of
7971 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7972 original value of -1 will not work with bidi.)
7973 (compute_display_string_pos): First arg is now struct
7974 `text_pos *'; all callers changed. Support display properties on
7975 Lisp strings.
7976 (compute_display_string_end): Support display properties on Lisp
7977 strings.
7978 (init_iterator, reseat_1, reseat_to_string): Initialize the
7979 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7980 when iterating on a string not from display properties).
640c8776
SM
7981 (compute_display_string_pos, compute_display_string_end):
7982 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7983 arrow keys.
7984 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7985 base_level_stop; instead, set base_level_stop to BEGV.
7986 Fixes crashes in vertical-motion.
0bb23927
EZ
7987 (next_element_from_buffer): Improve commentary for when
7988 the iterator is before prev_stop.
7989 (init_iterator): Initialize bidi_p from the default value of
7990 bidi-display-reordering, not from buffer-local value. Use the
7991 buffer-local value only if initializing for buffer iteration.
7992 (handle_invisible_prop): Support invisible properties on strings
7993 that are being bidi-reordered.
7994 (set_iterator_to_next): Support bidi reordering of C strings and
7995 Lisp strings.
7996 (next_element_from_string): Support bidi reordering of Lisp
7997 strings.
7998 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7999 (display_string): Support display of R2L glyph rows.
8000 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8001 (init_iterator): Don't initialize it->bidi_p for strings
8002 here.
8003 (reseat_to_string): Initialize it->bidi_p for strings here.
8004 (next_element_from_string, next_element_from_c_string)
8005 (next_element_from_buffer): Add xassert's for correspondence
8006 between IT's object being iterated and it->bidi_it.string
8007 structure.
8008 (face_before_or_after_it_pos): Support bidi iteration.
8009 (next_element_from_c_string): Handle the case of the first string
8010 character that is not the first one in the visual order.
8011 (get_visually_first_element): New function, refactored from common
8012 parts of next_element_from_buffer, next_element_from_string, and
8013 next_element_from_c_string.
8014 (tool_bar_lines_needed, redisplay_tool_bar)
8015 (display_menu_bar): Force left-to-right direction. Add a FIXME
8016 comment for making that be controlled by a user option.
8017 (push_it, pop_it): Save and restore the state of the
8018 bidi iterator. Save and restore the bidi_p flag.
8019 (pop_it): Iterate out of display property for string iteration as
8020 well.
8021 (iterate_out_of_display_property): Support iteration over strings.
8022 (handle_single_display_spec): Set up it->bidi_it for iteration
8023 over a display string, and call bidi_init_it.
8024 (handle_single_display_spec, next_overlay_string)
8025 (get_overlay_strings_1, push_display_prop): Set up the bidi
8026 iterator for displaying display or overlay strings.
8027 (forward_to_next_line_start): Don't use the shortcut if
8028 bidi-iterating.
8029 (back_to_previous_visible_line_start): If handle_display_prop
8030 pushed the iterator stack, restore the internal state of the bidi
8031 iterator by calling bidi_pop_it same number of times.
8032 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8033 and we are bidi-iterating, don't decrement the iterator position;
8034 instead, set the first_elt flag in the bidi iterator, to produce
8035 the same effect.
8036 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8037 (push_display_prop): xassert that we are iterating a buffer.
8038 (push_it, pop_it): Save and restore paragraph_embedding member.
8039 (handle_single_display_spec, next_overlay_string)
8040 (get_overlay_strings_1, reseat_1, reseat_to_string)
8041 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8042 correctly. Don't assume unibyte strings are not bidi-reordered.
8043 (compute_display_string_pos)
8044 (compute_display_string_end): Fix handling the case of C string.
8045 (push_it, pop_it): Save and restore from_disp_prop_p.
8046 (handle_single_display_spec, push_display_prop): Set the
8047 from_disp_prop_p flag.
8048 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8049 (pop_it): Call iterate_out_of_display_property only if we are
8050 popping after iteration over a string that came from a display
8051 property. Fix a typo in popping stretch info. Add an assertion
8052 for verifying that the iterator position is in sync with the bidi
8053 iterator.
8054 (handle_single_display_spec, get_overlay_strings_1)
8055 (push_display_prop): Fix initialization of paragraph direction for
8056 string when that of the parent object is not yet determined.
8057 (reseat_1): Call bidi_init_it to resync the bidi
8058 iterator with IT's position. (Bug#7616)
8059 (find_row_edges): If ROW->start.pos gives position
8060 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8061 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8062 Reset the from_disp_prop_p flag.
8063 (SAVE_IT, RESTORE_IT): New macros.
8064 (pos_visible_p, face_before_or_after_it_pos)
8065 (back_to_previous_visible_line_start)
8066 (move_it_in_display_line_to, move_it_in_display_line)
8067 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8068 (try_scrolling, redisplay_window, display_line): Use them when
8069 saving a temporary copy of the iterator and restoring it back.
8070 (back_to_previous_visible_line_start, reseat_1)
8071 (init_iterator): Empty the bidi cache "stack".
8072 (move_it_in_display_line_to): If iterator ended up at
8073 EOL, but we never saw any buffer positions smaller than
8074 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8075 motion in bidi-reordered lines.
8076 (move_it_in_display_line_to): Record prev_method and prev_pos
8077 immediately before the call to set_iterator_to_next. Fixes cursor
8078 motion in bidi-reordered lines with stretch glyphs and strings
8079 displayed in margins. (Bug#8133) (Bug#8867)
8080 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8081 TO_CHARPOS.
640c8776
SM
8082 (pos_visible_p): Support positions in bidi-reordered lines.
8083 Save and restore bidi cache.
0bb23927
EZ
8084
8085 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8086 (bidi_paragraph_info): Delete unused struct.
8087 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8088 (bidi_cache_start): New variable.
8089 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8090 to zero.
8091 (bidi_cache_fetch_state, bidi_cache_search)
8092 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8093 (bidi_cache_find, bidi_peek_at_next_level)
8094 (bidi_level_of_next_char, bidi_find_other_level_edge)
8095 (bidi_move_to_visually_next): Compare cache index with
8096 bidi_cache_start rather than with zero.
8097 (bidi_fetch_char): Accept new argument STRING; all callers
8098 changed. Support iteration over a string. Support strings with
8099 display properties. Support unibyte strings. Fix the type of
8100 `len' according to what STRING_CHAR_AND_LENGTH expects.
8101 (bidi_paragraph_init, bidi_resolve_explicit_1)
8102 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8103 (bidi_level_of_next_char, bidi_move_to_visually_next):
8104 Support iteration over a string.
0bb23927
EZ
8105 (bidi_set_sor_type, bidi_resolve_explicit_1)
8106 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8107 can now be zero (for strings); special values 0 and -1 were
8108 changed to -1 and -2, respectively.
8109 (bidi_char_at_pos): New function.
8110 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8111 Call it instead of FETCH_MULTIBYTE_CHAR.
8112 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8113 initialized to valid values.
8114 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8115 values.
8116 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8117 the test for valid cached positions. Fix the logic for looking up
8118 the sentinel state in the cache. GCPRO the Lisp string we are
8119 iterating.
8120 (bidi_push_it, bidi_pop_it): New functions.
8121 (bidi_initialize): Initialize the bidi cache start stack pointer.
8122 (bidi_cache_ensure_space): New function, refactored from part of
8123 bidi_cache_iterator_state. Don't assume the required size is just
8124 one BIDI_CACHE_CHUNK away.
8125 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8126 (bidi_count_bytes, bidi_char_at_pos): New functions.
8127 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8128 always valid if bidi_cache_idx is valid.
8129 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8130 is valid if it's going to be used.
8131 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8132 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8133 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8134 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8135 (bidi_find_other_level_edge, bidi_cache_start_stack):
8136 All variables related to cache indices are now EMACS_INT.
c965adc5 8137
0bb23927
EZ
8138 * dispextern.h (struct bidi_string_data): New structure.
8139 (struct bidi_it): New member `string'. Make flag members be 1-bit
8140 fields, and put them last in the struct.
640c8776
SM
8141 (compute_display_string_pos, compute_display_string_end):
8142 Update prototypes.
0bb23927
EZ
8143 (bidi_push_it, bidi_pop_it): Add prototypes.
8144 (struct iterator_stack_entry): New members bidi_p,
8145 paragraph_embedding, and from_disp_prop_p.
8146 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8147 (bidi_shelve_cache, bidi_unshelve_cache):
8148 Declare prototypes.
0bb23927
EZ
8149
8150 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8151 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8152 and vector-like objects.
8153
8154 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8155 cache around display iteration.
8156
8157 * window.c (Fwindow_end, window_scroll_pixel_based)
8158 (displayed_window_lines, Frecenter): Save and restore the bidi
8159 cache around display iteration.
8160
3bbd2265
LMI
81612011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8162
8163 * editfns.c (Fdelete_region): Clarify the use of the named
8164 parameters (bug#6788).
8165
adc47434
MR
81662011-07-14 Martin Rudalics <rudalics@gmx.at>
8167
8168 * indent.c (Fvertical_motion): Set and restore w->pointm when
8169 saving and restoring the window's buffer (Bug#9006).
8170
837c31f8
LMI
81712011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8172
8173 * editfns.c (Fstring_to_char): Clarify just what is returned
8174 (bug#6576). Text by Eli Zaretskii.
8175
ac389d0c
JB
81762011-07-13 Juanma Barranquero <lekktu@gmail.com>
8177
8178 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8179
0be0ce47
EZ
81802011-07-13 Eli Zaretskii <eliz@gnu.org>
8181
8182 * buffer.c (mmap_find): Fix a typo.
8183
cd18e7e3
JB
81842011-07-13 Johan Bockgård <bojohan@gnu.org>
8185
8186 Fix execution of x selection hooks.
8187 * xselect.c (Qx_lost_selection_functions)
8188 (Qx_sent_selection_functions): New vars.
8189 (syms_of_xselect): DEFSYM them.
8190 (x_handle_selection_request): Pass Qx_sent_selection_functions
8191 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8192 (x_handle_selection_clear,x_clear_frame_selections):
8193 Pass Qx_lost_selection_functions rather than
8194 Vx_lost_selection_functions to Frun_hook_with_args.
8195
47ea7f44
PE
81962011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8197
ac389d0c 8198 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8199 The old code sometimes used this field without initializing it.
8200
47ea7f44
PE
8201 * alloc.c (gc_sweep): Don't read past end of array.
8202 In theory, the old code could also have corrupted Emacs internals,
8203 though it'd be very unlikely.
8204
bc985c87
AS
82052011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8206
8207 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8208 argument. (Bug#4026)
bc985c87 8209
0cf34688
LMI
82102011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8211
b3dadd76
LMI
8212 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8213 key" (bug#4257).
8214
0cf34688
LMI
8215 * window.c (Fset_window_start): Doc fix (bug#4199).
8216 (Fset_window_hscroll): Ditto.
8217
270768cd
PE
82182011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8219
077e3dda 8220 Fix minor new problems caught by GCC 4.6.1.
270768cd 8221 * term.c (init_tty): Remove unused local.
490011a6 8222 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8223 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8224 not used otherwise.
270768cd 8225
b1f58454
CY
82262011-07-12 Chong Yidong <cyd@stupidchicken.com>
8227
8228 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8229
22b9578d
LMI
82302011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8231
6e70ab07
LMI
8232 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8233 are the mini-buffer and the echo area (bug#3320).
8234
22b9578d
LMI
8235 * term.c (init_tty): Remove support for supdup, c10 and perq
8236 terminals, which are no longer supported (bug#1482).
8237
8974cc9f
JB
82382011-07-10 Johan Bockgård <bojohan@gnu.org>
8239
8240 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8241
a560d974
JD
82422011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8243
8244 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8245 for non-popups (Bug#3642).
8246
1dae0f0a
AS
82472011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8248
268c2c36 8249 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8250 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8251 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8252 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8253 * data.c (fmod): Likewise.
8254 * dispnew.c (swap_glyphs_in_rows): Likewise.
8255 * emacs.c (memory_warning_signal): Likewise.
8256 * floatfns.c (float_error): Likewise.
8257 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8258 (otf_open, font_otf_capability, generate_otf_features)
8259 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8260 Likewise.
8261 * image.c (pbm_read_file): Likewise.
8262 * indent.c (string_display_width): Likewise.
8263 * intervals.c (check_for_interval, search_for_interval)
8264 (inc_interval_count, count_intervals, root_interval)
8265 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8266 * lread.c (defalias): Likewise.
268c2c36 8267 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8268 * regex.c (set_image_of_range_1, set_image_of_range)
8269 (regex_grow_registers): Likewise.
8270 * sysdep.c (strerror): Likewise.
8271 * termcap.c (valid_filename_p, tprint, main): Likewise.
8272 * tparam.c (main): Likewise.
8273 * unexhp9k800.c (run_time_remap, save_data_space)
8274 (update_file_ptrs, read_header, write_header, calculate_checksum)
8275 (copy_file, copy_rest, display_header): Likewise.
8276 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8277 Likewise.
8278 * xdisp.c (check_it): Likewise.
8279 * xfaces.c (register_color, unregister_color, unregister_colors):
8280 Likewise.
8281 * xfns.c (print_fontset_result): Likewise.
8282 * xrdb.c (member, fatal, main): Likewise.
8283
99033785
PE
82842011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8285
8286 Fix minor problems found by static checking (Bug#9031).
8287 * chartab.c (char_table_set_range, map_sub_char_table):
8288 Remove unused locals.
8289 (uniprop_table): Now static.
8290 * composite.c (_work_char): Remove unused static var.
8291
9cb2ac56
JB
82922011-07-09 Juanma Barranquero <lekktu@gmail.com>
8293
8294 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8295
f25661f0
JD
82962011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8297
8298 * gtkutil.c (qttip_cb): Remove code without function.
8299
8278c4fe
EZ
83002011-07-09 Eli Zaretskii <eliz@gnu.org>
8301
8302 * w32.c (pthread_sigmask): New stub.
8303
1692ae2d 83042011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8305
8a6ebd58 8306 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8307 sigprocmask is portable only for single-threaded applications, and
8308 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8309 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8310 (LIBES): Use it.
8311 * callproc.c (Fcall_process):
8312 * process.c (create_process):
8313 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8314 Use pthread_sigmask, not sigprocmask.
123403e4 8315
1b854618
JD
83162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8317
8318 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8319 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8320 wrong (Bug#8591).
8321
3fe4b549
JD
83222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8323
0ce7e563
JD
8324 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8325 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8326 (xg_hide_tooltip): Fix comment.
8327
3fe4b549
JD
8328 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8329 in registerServicesMenuSendTypes.
8330 (validRequestorForSendType): Don't check ns_return_types.
8331
8332 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8333 ns_return_type.
8334
5df75e47
JR
83352011-07-08 Jason Rumney <jasonr@gnu.org>
8336
22610910
JR
8337 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8338 SH_SHOW for hidden windows (Bug#5482).
8339
5df75e47
JR
8340 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8341 frame struct members of non-existent frames (Bug#6284).
8342
699c10bd
JD
83432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8344
4393663b
JD
8345 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8346 variable firstTime not needed on OSX >= 10.6.
8347 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8348 >= 10.5. Use setKnobProportion, setDoubleValue.
8349
8350 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8351 (MAC_OS_X_VERSION_10_5): Define if not defined.
8352 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8353 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8354 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8355
8356 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8357 cString and lossyCString on OSX >= 10.4.
4393663b 8358
58179cce 8359 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8360 sizeToFit on OSX >= 10.2.
8361
8362 * nsimage.m (allocInitFromFile): Don't use deprecated method
8363 bestRepresentationForDevice on OSX >= 10.6.
8364
8365 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8366 to avoid warning.
8367
8368 * emacs.c: Declare unexec_init_emacs_zone.
8369
a63e0781
JD
8370 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8371
699c10bd
JD
8372 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8373
8374 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8375 on svcsMenu (Bug#8842).
8376
8377 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8378 ns_return_types.
8379 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8380
8381 * nsterm.m (QUTF8_STRING): Declare.
8382 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8383 (validRequestorForSendType): Return type is (id).
8384 Change indexOfObjectIdenticalTo to indexOfObject.
8385 Check if we have local selection before returning self (Bug#8842).
8386 (writeSelectionToPasteboard): Put local selection into paste board
8387 if we have a local selection (Bug#8842).
8388 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8389
8390 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8391 (ns_get_local_selection): Declare.
8392
54e10184
LMI
83932011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8394
9888ff71
LMI
8395 * keymap.c (describe_map_tree): Don't insert a double newline at
8396 the end of the buffer (bug#1169) and return whether we inserted
8397 something.
8398
54e10184
LMI
8399 * callint.c (Fcall_interactively): Change "reading args" to
8400 "providing args" to try to clarify what it does (bug#1010).
8401
15fa4783
KH
84022011-07-07 Kenichi Handa <handa@m17n.org>
8403
8404 * composite.c (composition_compute_stop_pos): Ignore a static
8405 composition starting before CHARPOS (Bug#8915).
8406
8407 * xdisp.c (handle_composition_prop): Likewise.
8408
a8815b00
EZ
84092011-07-07 Eli Zaretskii <eliz@gnu.org>
8410
8411 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8412 (Bug#9015)
8413
ef7b981d 84142011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8415
8416 * character.h (unicode_category_t): New enum type.
8417
8418 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8419 (Qchar_code_property_table): New variable.
8420 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8421 (UNIPROP_COMPRESSED_FORM_P): New macros.
8422 (char_table_ascii): Uncompress the compressed values.
8423 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8424 Uncompress the compressed values.
ac389d0c 8425 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8426 (char_table_ref_and_range): Uncompress the compressed values.
8427 (sub_char_table_set): New arg is_uniprop. Callers changed.
8428 Uncompress the compressed values.
8429 (sub_char_table_set_range): Args changed. Callers changed.
8430 (char_table_set_range): Adjuted for the above change.
8431 (map_sub_char_table): Delete args default_val and parent. Add arg
8432 top. Give decoded values to a Lisp function.
640c8776 8433 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8434 values to a Lisp function. Gcpro more variables.
8435 (uniprop_table_uncompress)
8436 (uniprop_decode_value_run_length): New functions.
8437 (uniprop_decoder, uniprop_decoder_count): New variables.
8438 (uniprop_get_decoder, uniprop_encode_value_character)
8439 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8440 New functions.
8441 (uniprop_encoder, uniprop_encoder_count): New variables.
8442 (uniprop_get_encoder, uniprop_table)
8443 (Funicode_property_table_internal, Fget_unicode_property_internal)
8444 (Fput_unicode_property_internal): New functions.
8445 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8446 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8447 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8448 char-code-property-alist.
8449
640c8776 8450 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8451 Vunicode_category_table.
8452
640c8776 8453 * font.c (font_range): Adjust for the change of
c805dec0
KH
8454 Vunicode_category_table.
8455
76b397fb
DN
84562011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8457
8458 * m/iris4d.h: Remove file, move contents ...
8459 * s/irix6-5.h: ... here.
8460
22b4128e
PE
84612011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8462
8463 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8464 * alloc.c (mark_buffer):
8465 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8466 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8467 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8468 This isn't true in general, and it's particularly not true
8469 if Emacs is configured with --with-wide-int.
8470 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8471 New macros, used in the buffer.c change.
8472
869795d6
JD
84732011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8474
8475 * xsettings.c: Use both GConf and GSettings if both are available.
8476 (store_config_changed_event): Add comment.
8477 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8478 (store_tool_bar_style_changed): New functions.
5e617bc2 8479 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8480 (struct xsettings): Move font inside HAVE_XFT.
8481 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8482 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8483 Move inside HAVE_XFT.
640c8776 8484 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8485 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8486 also.
8487 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8488 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8489 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8490 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8491 (parse_settings): Move check for font inside HAVE_XFT.
8492 (read_settings, apply_xft_settings): Add comment.
8493 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8494 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8495 call store_font_name_changed.
8496 (xft_settings_event): Add comment.
8497 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8498 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8499 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8500 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8501 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8502 (xsettings_get_system_font, xsettings_get_system_normal_font):
8503 Add comment.
869795d6 8504
d8ed26bd
PE
85052011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8506
8507 Random fixes. E.g., (random) never returned negative values.
8508 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8509 subseconds part to the entropy, as that's a bit more random.
8510 Prefer signed to unsigned, since the signedness doesn't matter and
8511 in general we prefer signed. When given a limit, use a
8512 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8513 latter isn't right if USE_2_TAGS_FOR_INTS.
8514 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8515 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8516
cabf1cac
SM
85172011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8518
8519 * textprop.c (text_property_stickiness):
8520 Obey Vtext_property_default_nonsticky.
8521 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8522 * w32fns.c (syms_of_w32fns):
8523 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8524
6e9b2be9
PE
85252011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8526
8527 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8528 This is more efficient than Ffile_directory_p and avoids a minor race.
8529
90186c68
LMI
85302011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8531
7c301272
LMI
8532 * buffer.c (Foverlay_put): Say what the return value is
8533 (bug#7835).
8534
c4f2d8d4
LMI
8535 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8536 is a directory before asking whether to use the file name
8537 (bug#7564).
ad637907
LMI
8538 (barf_or_query_if_file_exists): Make the "File is a directory"
8539 error be more correct.
c4f2d8d4 8540
90186c68
LMI
8541 * fns.c (Frequire): Remove the mention of the .gz files, since
8542 that's installation-specific, but keep the mention of
8543 `get-load-suffixes'.
8544
da64016e
PE
85452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8546
8547 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8548 Report string overflow if the output is too long.
8549
7d47b580
JB
85502011-07-04 Juanma Barranquero <lekktu@gmail.com>
8551
a555cb87
JB
8552 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8553 (syms_of_gnutls): Remove duplicate DEFSYM for
8554 Qgnutls_bootprop_verify_hostname_error, an error for
8555 Qgnutls_bootprop_verify_error (which is no longer used).
8556
7d47b580
JB
8557 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8558 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8559 Also (re)move comments that are misplaced or no longer relevant.
8560
1e49bfab
LMI
85612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8562
8563 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8564
1485f4c0
CY
85652011-07-03 Chong Yidong <cyd@stupidchicken.com>
8566
8567 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8568 and background color parameters if they have been changed.
8569
a9ab721e
LMI
85702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8571
8572 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8573
cf7cff57
PE
85742011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8575
2e13213d
PE
8576 * xsettings.c (SYSTEM_FONT): Define only when used.
8577 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8578
cf7cff57
PE
8579 * keymap.c (access_keymap_1): Now static.
8580
7a8e04f7
CY
85812011-07-02 Chong Yidong <cyd@stupidchicken.com>
8582
8583 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8584 leave any prefix arg for the up event (Bug#1586).
8585
61352f62
LMI
85862011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8587
69bb1ef7
LMI
8588 * lread.c (syms_of_lread): Mention single symbols defined by
8589 `defvar' or `defconst' (bug#7154).
8590
61352f62 8591 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8592 (Frequire): Mention get-load-suffixes.
61352f62 8593
28545e04
MR
85942011-07-02 Martin Rudalics <rudalics@gmx.at>
8595
8596 * window.h (window): Remove clone_number slot.
8597 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8598 Remove.
8599 (make_parent_window, make_window, saved_window)
8600 (Fset_window_configuration, save_window_save): Don't deal with
8601 clone numbers.
8602 * buffer.c (Qclone_number): Remove declaration.
8603 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8604
3349e122
SM
86052011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8606
8607 Add multiple inheritance to keymaps.
8608 * keymap.c (Fmake_composed_keymap): New function.
8609 (Fset_keymap_parent): Simplify.
8610 (fix_submap_inheritance): Remove.
8611 (access_keymap_1): New function extracted from access_keymap to handle
8612 embedded parents and handle lists of maps.
8613 (access_keymap): Use it.
8614 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8615 (Fcopy_keymap): Handle embedded parents.
8616 (Fcommand_remapping, define_as_prefix): Simplify.
8617 (Fkey_binding): Simplify.
8618 (syms_of_keymap): Move minibuffer-local-completion-map,
8619 minibuffer-local-filename-completion-map,
8620 minibuffer-local-must-match-map, and
8621 minibuffer-local-filename-must-match-map to Elisp.
8622 (syms_of_keymap): Defsubr make-composed-keymap.
8623 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8624 (parse_menu_item): Trivial simplification.
8625
3279eb87
GM
86262011-07-01 Glenn Morris <rgm@gnu.org>
8627
8628 * Makefile.in (SETTINGS_LIBS): Fix typo.
8629
4550efdf
KI
86302011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8631
8632 * coding.c (Fencode_coding_string): Record the last coding system
8633 used, as the function doc string says (bug#8738).
8634
0949d2b6
JD
86352011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8636
8637 * xsettings.c (store_monospaced_changed): Take new font as arg and
8638 check for change against current_mono_font.
8639 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8640 (emacs_settings_constructor, emacs_settings_get_property)
8641 (emacs_settings_set_property, emacs_settings_class_init)
8642 (emacs_settings_init, gsettings_obj): Remove.
8643 (something_changedCB): New function for HAVE_GSETTINGS.
8644 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8645 with value as argument.
8646 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8647 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8648 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8649 "changed".
8650
8651 * xgselect.c: Add defined (HAVE_GSETTINGS).
8652 (xgselect_initialize): Ditto.
8653
8654 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8655 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8656 xg_select.
8657
bbc6b304
PE
86582011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8659
8660 * eval.c (struct backtrace): Simplify and port the data structure.
8661 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8662 signed bit field, as this assumption is not portable and it makes
8663 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8664 "char debug_on_exit : 1" as this is not portable either; instead,
8665 use the portable "unsigned int debug_on_exit : 1". Remove unused
8666 member evalargs. Remove obsolete comments about cc bombing out.
8667
9851bfc5
JD
86682011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8669
51bb811f 8670 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8671 Let HAVE_GSETTINGS override HAVE_GCONF.
8672 (store_monospaced_changed): New function.
8673 (EMACS_SETTINGS): A new type derived from GObject to handle
8674 GSettings notifications.
8675 (emacs_settings_constructor, emacs_settings_get_property)
8676 (emacs_settings_set_property, emacs_settings_class_init):
8677 New functions.
8678 (gsettings_client, gsettings_obj): New variables.
8679 (GSETTINGS_SCHEMA): New define.
8680 (something_changedCB): Call store_monospaced_changed.
8681 (init_gsettings): New function.
8682 (xsettings_initialize): Call init_gsettings.
8683 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8684 to NULL.
8685
640c8776 8686 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8687 GCONF_CFLAGS/LIBS.
8688
5386012d
MR
86892011-06-29 Martin Rudalics <rudalics@gmx.at>
8690
8691 * window.c (resize_root_window, grow_mini_window)
8692 (shrink_mini_window): Rename Qresize_root_window to
8693 Qwindow_resize_root_window and Qresize_root_window_vertically to
8694 Qwindow_resize_root_window_vertically.
8695
f13e0b08
PE
86962011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8697
8698 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8699
94515237
JB
87002011-06-27 Juanma Barranquero <lekktu@gmail.com>
8701
8702 * makefile.w32-in: Redesign dependencies so they reflect more
8703 clearly which files are directly included by each source file,
8704 and not through other includes.
8705
e43b6e43
MR
87062011-06-27 Martin Rudalics <rudalics@gmx.at>
8707
8708 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8709 (sort_overlays, overlay_strings): When an overlay's clone number
8710 matches the window's clone number process the overlay even if
8711 the overlay's window property doesn't match the current window.
8712
d68443dc
MR
8713 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8714 (Fwindow_hchild): Rename to Fwindow_left_child.
8715 (Fwindow_next): Rename to Fwindow_next_sibling.
8716 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8717 (resize_window_check): Rename to window_resize_check.
8718 (resize_window_apply): Rename to window_resize_apply.
8719 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8720 (Fdelete_other_windows_internal, resize_frame_windows)
8721 (Fsplit_window_internal, Fdelete_window_internal)
8722 (grow_mini_window, shrink_mini_window)
8723 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8724
c7e73be5
JD
87252011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8726
8727 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8728 (emacs_fixed_set_min_size): Remove.
8729 (emacs_fixed_new): Take frame as argument.
8730
8731 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8732 (_EmacsFixedPrivate): Remove minwidth/height.
8733 Add struct frame *f.
8734 (emacs_fixed_init): Initialize priv->f.
8735 (get_parent_class, emacs_fixed_set_min_size): Remove.
8736 (emacs_fixed_new): Set priv->f to argument.
8737 (emacs_fixed_get_preferred_width)
8738 (emacs_fixed_get_preferred_height): Use min_width/height from
8739 frames size_hint to set minimum and natural (Bug#8919).
8740 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8741 and use min_width/height from frames size_hint to set
8742 min_width/height (Bug#8919).
8743
8744 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8745 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8746 Fix indentation.
c7e73be5 8747
cf99dcf8
EZ
87482011-06-26 Eli Zaretskii <eliz@gnu.org>
8749
8750 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8751 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8752 called at ZV.
8753
029529ac
CY
87542011-06-26 Chong Yidong <cyd@stupidchicken.com>
8755
8756 * process.c (wait_reading_process_output): Bypass select if
8757 waiting for a cell while ignoring keyboard input, and input is
8758 pending. Suggested by Jan Djärv (Bug#8869).
8759
7a7ef429
PE
87602011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8761
8762 Use gnulib's dup2 module instead of rolling our own.
8763 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8764
11fdef7d 87652011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8766
8767 * dispnew.c (scrolling_window): Before scrolling, turn off a
8768 mouse-highlight in the window being scrolled.
8769
cd3520a4
JB
87702011-06-24 Juanma Barranquero <lekktu@gmail.com>
8771
8772 Move DEFSYM to lisp.h and use everywhere.
8773
8774 * character.h (DEFSYM): Move declaration...
8775 * lisp.h (DEFSYM): ...here.
8776
8777 * gnutls.c:
8778 * minibuf.c:
8779 * w32menu.c:
8780 * w32proc.c:
8781 * w32select.c: Don't include character.h.
8782
8783 * alloc.c (syms_of_alloc):
8784 * buffer.c (syms_of_buffer):
8785 * bytecode.c (syms_of_bytecode):
8786 * callint.c (syms_of_callint):
8787 * casefiddle.c (syms_of_casefiddle):
8788 * casetab.c (init_casetab_once):
8789 * category.c (init_category_once, syms_of_category):
8790 * ccl.c (syms_of_ccl):
8791 * cmds.c (syms_of_cmds):
8792 * composite.c (syms_of_composite):
8793 * dbusbind.c (syms_of_dbusbind):
8794 * dired.c (syms_of_dired):
8795 * dispnew.c (syms_of_display):
8796 * doc.c (syms_of_doc):
8797 * editfns.c (syms_of_editfns):
8798 * emacs.c (syms_of_emacs):
8799 * eval.c (syms_of_eval):
8800 * fileio.c (syms_of_fileio):
8801 * fns.c (syms_of_fns):
8802 * frame.c (syms_of_frame):
8803 * fringe.c (syms_of_fringe):
8804 * insdel.c (syms_of_insdel):
8805 * keymap.c (syms_of_keymap):
8806 * lread.c (init_obarray, syms_of_lread):
8807 * macros.c (syms_of_macros):
8808 * msdos.c (syms_of_msdos):
8809 * print.c (syms_of_print):
8810 * process.c (syms_of_process):
8811 * search.c (syms_of_search):
8812 * sound.c (syms_of_sound):
8813 * syntax.c (init_syntax_once, syms_of_syntax):
8814 * terminal.c (syms_of_terminal):
8815 * textprop.c (syms_of_textprop):
8816 * undo.c (syms_of_undo):
8817 * w32.c (globals_of_w32):
8818 * window.c (syms_of_window):
8819 * xdisp.c (syms_of_xdisp):
8820 * xfaces.c (syms_of_xfaces):
8821 * xfns.c (syms_of_xfns):
8822 * xmenu.c (syms_of_xmenu):
8823 * xsettings.c (syms_of_xsettings):
8824 * xterm.c (syms_of_xterm): Use DEFSYM.
8825
4228cf16
TZ
88262011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8827
cd3520a4 8828 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8829
7fcccf1e
PE
88302011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8831
7efb4e0e
PE
8832 Integer and buffer overflow fixes (Bug#8873).
8833
ff5844ad
PE
8834 * print.c (printchar, strout): Check for string overflow.
8835 (PRINTPREPARE, printchar, strout):
8836 Don't set size unless allocation succeeds.
8837
90532f02
PE
8838 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8839 for sizes. Check for string overflow more accurately.
8840 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8841
6d84508d
PE
8842 * macros.c: Integer and buffer overflow fixes.
8843 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8844 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8845 Use ptrdiff_t, not int, for sizes.
8846 Don't increment bufsize until after realloc succeeds.
8847 Check for size-calculation overflow.
8848 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8849
437b2cb4
PE
8850 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8851
8b9ac8b4
PE
8852 * lread.c: Integer overflow fixes.
8853 (read_integer): Radix is now EMACS_INT, not int,
8854 to improve quality of diagnostics for out-of-range radices.
8855 Calculate buffer size correctly for out-of-range radices.
8856 (read1): Check for integer overflow in radices, and in
8857 read-circle numbers.
82cb60d3
PE
8858 (read_escape): Avoid int overflow.
8859 (Fload, openp, read_buffer_size, read1)
8860 (substitute_object_recurse, read_vector, read_list, map_obarray):
8861 Use ptrdiff_t, not int, for sizes.
8862 (read1): Use EMACS_INT, not int, for sizes.
20270765 8863 Check for size overflow.
8b9ac8b4 8864
7fcccf1e
PE
8865 * image.c (cache_image): Check for size arithmetic overflow.
8866
bfbbd7e7
PE
8867 * lread.c: Integer overflow issues.
8868 (saved_doc_string_size, saved_doc_string_length)
8869 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8870 Now ptrdiff_t, not int.
8871 (read1): Don't assume doc string length fits in int. Check for
8872 out-of-range doc string lengths.
8873 (read_list): Don't assume file position fits in int.
39019e54 8874 (read_escape): Check for hex character overflow.
bfbbd7e7 8875
4e323265
LL
88762011-06-22 Leo Liu <sdl.web@gmail.com>
8877
8878 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8879 Move to minibuffer.el.
8880
85fece3e
PE
88812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8882
20b84ce9 8883 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8884 The following patches are for when GLYPH_DEBUG && !XASSERT.
8885 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8886 * dispnew.c (flush_stdout):
8887 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8888 Mark as externally visible.
8889 * dispnew.c (check_window_matrix_pointers): Now static.
8890 * dispnew.c (window_to_frame_vpos):
8891 * xfns.c (unwind_create_frame):
8892 * xterm.c (x_check_font): Remove unused local.
8893 * scroll.c (CHECK_BOUNDS):
8894 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8895 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8896 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8897 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8898 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8899 Now static.
8900 (debug_method_add): Use va_list and vsprintf rather than relying
8901 on undefined behavior with wrong number of arguments.
8902 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8903 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8904 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8905 since we're not interested in debugging glyphs with old libraries.
8906 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8907 GCC 4.6.0's static checking.
8908
0766b489
PE
89092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8910
31fd4b32
PE
8911 Integer overflow and signedness fixes (Bug#8873).
8912 A few related buffer overrun fixes, too.
8913
b79e8648
PE
8914 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8915
0766b489
PE
8916 * dispextern.h (struct face.stipple):
8917 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8918 (x_bitmap_mask, x_allocate_bitmap_record)
8919 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8920 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8921 (x_create_bitmap_from_xpm_data):
8922 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8923 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8924 (.bitmaps_last):
8925 * xfaces.c (load_pixmap):
8926 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8927 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8928 (.bitmaps_last, struct x_output.icon_bitmap):
8929 Use ptrdiff_t, not int, for bitmap indexes.
8930 (x_allocate_bitmap_record): Check for size overflow.
8931 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8932
b081724f
PE
8933 Use ptrdiff_t, not int, for overlay counts.
8934 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8935 * editfns.c (overlays_around, get_pos_property):
8936 * textprop.c (get_char_property_and_overlay):
8937 * xdisp.c (next_overlay_change, note_mouse_highlight):
8938 * xfaces.c (face_at_buffer_position):
21514da7
PE
8939 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8940 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8941 (Fnext_overlay_change, Fprevious_overlay_change)
8942 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8943 Use ptrdiff_t, not int, for sizes.
21514da7 8944 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8945
3de73e5e
PE
8946 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8947
2606c57b
PE
8948 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8949 (x_session_initialize): Do not assume string length fits in int.
8950
aaafe47a
PE
8951 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8952 This is unlikely, but can occur if DPI is outlandish.
8953
2674ddc8 8954 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8955 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8956
28154962
PE
8957 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8958 * xrdb.c (magic_file_p, search_magic_path):
8959 Omit last arg SUFFIX; it was always 0. All callers changed.
8960 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8961
7de51af5
PE
8962 * xfont.c (xfont_match): Avoid need for strlen.
8963
25ed6cc3
PE
8964 * xfns.c: Don't assume strlen fits in int.
8965 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8966
4eab31dd
PE
8967 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8968 not unsigned long, as we prefer signed integers. All callers changed.
8969 Detect integer overflow in repeat count.
8970 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8971 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8972
171e2a58
PE
8973 * termcap.c: Don't assume sizes fit in int and never overflow.
8974 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8975 (gobble_line): Check for size-calculation overflow.
8976
ad39faca 8977 * minibuf.c (Fread_buffer):
6e5bb2dc 8978 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8979 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8980 Don't assume string length fits in int.
8981
52c61c22 8982 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8983 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8984
b5b8c9e5
PE
8985 * font.c: Don't assume string length fits in int.
8986 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8987 Use ptrdiff_t, not int.
ccd6111c
PE
8988 (font_intern_prop): Don't assume string length fits in int.
8989 Don't assume integer property fits in fixnum.
8990 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8991
882f0d81 8992 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8993 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8994 Reformulate so as not to need the command string.
8995 Invoke gzip -cd rather than gunzip, as it's more portable.
8996 (lock_info_type, lock_file_1, lock_file):
8997 Don't assume pid_t and time_t fit in unsigned long.
8998 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8999 (current_lock_owner): Prefer signed type for sizes.
9000 Use memcpy, not strncpy, where memcpy is what is really wanted.
9001 Don't assume (via atoi) that time_t and pid_t fit in int.
9002 Check for time_t and/or pid_t out of range, e.g., via a network share.
9003 Don't alloca where an auto var works fine.
9004
93f4cf88
PE
9005 * fileio.c: Fix some integer overflow issues.
9006 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9007 Don't assume string length fits in int.
9008 (directory_file_name): Don't assume string length fits in long.
9009 (make_temp_name): Don't assume pid fits in int, or that its print
9010 length is less than 20.
9011
f3e92b69
PE
9012 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9013
1bfdaf10
PE
9014 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9015
35016e9a
PE
9016 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9017
3d1e65a1
PE
9018 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9019 We prefer signed integers, even for size calculations.
9020
0b963a93
PE
9021 * emacs.c: Don't assume string length fits in 'int'.
9022 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9023 (main): Don't invoke strlen when not needed.
9024
573f4b54
PE
9025 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9026 (XD_DEBUG_MESSAGE): Don't waste a byte.
9027
989f33ba
PE
9028 * callproc.c (getenv_internal_1, getenv_internal)
9029 (Fgetenv_internal):
965d34eb
PE
9030 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9031
e4d29b33
PE
9032 * lread.c (invalid_syntax): Omit length argument.
9033 All uses changed. This doesn't fix a bug, but it simplifies the
9034 code away from its former Hollerith-constant appearance, and it's
9035 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9036 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9037
eb49b136
PE
9038 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9039 This didn't break anything, but it didn't help either.
9040 It's confusing to put a bogus integer in a place where the actual
9041 value does not matter.
9f62aeb1 9042 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9043 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9044
15375a22
PE
9045 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9046 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9047 implementation.
b61cc01c
PE
9048 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9049 We prefer signed types, and the value cannot exceed the EMACS_INT
9050 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9051 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9052 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9053 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9054
53b2623d
PE
9055 * indent.c (sane_tab_width): New function.
9056 (current_column, scan_for_column, Findent_to, position_indentation)
9057 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9058 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9059
51cab52b 9060 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9061
f2ed8a70
PE
9062 * lisp.h (lint_assume): New macro.
9063 * composite.c (composition_gstring_put_cache):
9064 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9065
abe80cc6
PE
9066 * editfns.c, insdel.c:
9067 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9068
b02c740e
PE
9069 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9070
ebc96716
PE
9071 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9072
b4e50fa0 9073 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9074 Use much-faster test for byte-length change.
311d5d7c 9075 Don't assume string byte-length fits in 'int'.
a4cf38e4 9076 Check that character arg fits in 'int'.
85461888 9077 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9078
c0c1ee9f
PE
9079 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9080
a498d7f4
PE
9081 * fns.c (concat): Catch string overflow earlier.
9082 Do not rely on integer wraparound.
9083
51cab52b
PE
9084 * dispextern.h (struct it.overlay_strings_charpos)
9085 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9086 * xdisp.c (forward_to_next_line_start)
9087 (back_to_previous_visible_line_start)
9088 (reseat_at_next_visible_line_start, next_element_from_buffer):
9089 Don't arbitrarily truncate the value of 'selective' to int.
9090
76031fad
PE
9091 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9092
5eb55db9
PE
9093 * composite.c: Don't truncate sizes to 'int'.
9094 (composition_gstring_p, composition_reseat_it)
9095 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9096 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9097 not EMACS_UINT, for indexes.
5eb55db9 9098
0703a717
PE
9099 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9100
d6202519
PE
9101 * buffer.c: Include <verify.h>.
9102 (struct sortvec.priority, struct sortstr.priority):
8961a454 9103 Now EMACS_INT, not int.
c20998a7 9104 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9105 (struct sortstr.size, record_overlay_string)
9106 (struct sortstrlist.size, struct sortlist.used):
9107 Don't truncate size to int.
9108 (record_overlay_string): Check for size-calculation overflow.
d6202519 9109 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9110
d5a19415
JM
91112011-06-22 Jim Meyering <meyering@redhat.com>
9112
029529ac 9113 Don't leak an XBM-image-sized buffer
d5a19415
JM
9114 * image.c (xbm_load): Free the image buffer after using it.
9115
a9041e6c
PE
91162011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9117
9118 Port to Sun C.
9119 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9120 that Sun C diagnosed.
9121 * fns.c (secure_hash): Fix pointer signedness issue.
9122 * intervals.c (static_offset_intervals): New function.
9123 (offset_intervals): Use it.
9124
7f3f739f
LL
91252011-06-21 Leo Liu <sdl.web@gmail.com>
9126
9127 * deps.mk (fns.o):
9128 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9129 sha512.h.
9130
9131 * fns.c (secure_hash): Rename from crypto_hash_function and change
9132 the first arg to accept symbols.
5b66d427 9133 (Fsecure_hash): New primitive.
7f3f739f
LL
9134 (syms_of_fns): New symbols.
9135
76147d94
DD
91362011-06-20 Deniz Dogan <deniz@dogan.se>
9137
9138 * process.c (Fset_process_buffer): Clarify return value in
9139 docstring.
9140
7d7d0045
CY
91412011-06-18 Chong Yidong <cyd@stupidchicken.com>
9142
9143 * dispnew.c (add_window_display_history): Use BVAR.
9144
9145 * xdisp.c (debug_method_add): Use BVAR.
9146 (check_window_end, dump_glyph_matrix, dump_glyph)
9147 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9148
9149 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9150 Likewise.
9151
9152 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9153 check till after the cache is created in init_frame_faces.
9154
ff2bc410
SM
91552011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9156
9157 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9158
28177add
PE
91592011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9160
dd3482fe
PE
9161 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9162 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9163 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9164
393d71f3 9165 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9166 * fileio.c (Finsert_file_contents):
9167 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9168 Remove the old (too-loose) buffer overflow checks.
9169 They weren't needed, since make_gap checks for buffer overflow.
9170 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9171 The old code merely checked for Emacs fixnum overflow, and relied
9172 on undefined (wraparound) behavior. The new code avoids undefined
9173 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9174
2e6813b0 9175 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9176 Tune. Don't use wider integers than needed. Don't use alloca.
9177 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9178
599a9e4f
PE
9179 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9180
99561444
PE
9181 * insdel.c, lisp.h (buffer_overflow): New function.
9182 (insert_from_buffer_1, replace_range, replace_range_2):
9183 * insdel.c (make_gap_larger):
9184 * editfns.c (Finsert_char):
9185 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9186
28177add
PE
9187 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9188
e69dafad
PE
91892011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9190
4baa020d 9191 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9192
b1c46f02
PE
9193 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9194 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9195
e69dafad
PE
9196 * fileio.c: Don't assume EMACS_INT fits in off_t.
9197 (emacs_lseek): New static function.
9198 (Finsert_file_contents, Fwrite_region): Use it.
9199 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9200
566684ea
PE
9201 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9202
e6966cd6
PE
9203 * fns.c: Don't overflow int when computing a list length.
9204 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9205 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9206 truncation on 64-bit hosts. Check for QUIT every
9207 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9208 faster and is responsive enough.
9209 (Flength): Report an error instead of overflowing an integer.
9210 (Fsafe_length): Return a float if the value is not representable
9211 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9212 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9213 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9214
dd0b0efb
PE
9215 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9216 (header_size, word_size): New constants.
9217 (allocate_vectorlike): Don't check size overflow here.
9218 (allocate_vector): Check it here instead, since this is the only
9219 caller of allocate_vectorlike that could cause overflow.
9220 Check that the new vector's length is representable as a fixnum.
9221
86fe5cfe
PE
9222 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9223 The previous code was bogus. For example, next_almost_prime (32)
9224 returned 39, which is undesirable as it is a multiple of 3; and
9225 next_almost_prime (24) returned 25, which is a multiple of 5 so
9226 why was the code bothering to check for multiples of 7?
9227
80e88859
PE
9228 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9229
4a2f0ad6
PE
9230 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9231
f66c7cf8
PE
9232 Variadic C functions now count arguments with ptrdiff_t.
9233 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9234 Back then I didn't know that the Emacs coding style prefers signed int.
9235 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9236 were being counted with int, which may truncate counts on 64-bit
9237 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9238 * lisp.h (struct Lisp_Subr.function.aMANY)
9239 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9240 Arg counts are now ptrdiff_t, not size_t.
9241 All variadic functions and their callers changed accordingly.
9242 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9243 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9244 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9245 * callint.c (Fcall_interactively): Check arg count for overflow,
9246 to avoid potential buffer overrun. Use signed char, not 'int',
9247 for 'varies' array, so that we needn't bother to check its size
9248 calculation for overflow.
9249 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9250 * eval.c (apply_lambda):
9251 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9252 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9253 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9254
a1759b76
PE
9255 * callint.c (Fcall_interactively): Don't use index var as event count.
9256
d96be9fc
PE
9257 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9258 * mem-limits.h (SIZE): Remove; no longer used.
9259
a690a978 9260 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9261
578c21e6
PE
9262 Remove unnecessary casts.
9263 * xterm.c (x_term_init):
9264 * xfns.c (x_set_border_pixel):
9265 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9266 These aren't needed now that we assume ANSI C.
9267
96f53c6c
PE
9268 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9269 It's more likely to cause problems (due to unsigned overflow)
9270 than to cure them.
9271
83c77d31
PE
9272 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9273
ee2079f1
PE
9274 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9275
6da65536
PE
9276 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9277
7147c4a4
PE
9278 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9279
193e32d9
PE
9280 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9281
e5533da6
PE
9282 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9283
9910e595
PE
9284 GLYPH_CODE_FACE returns EMACS_INT, not int.
9285 * dispextern.h (merge_faces):
9286 * xfaces.c (merge_faces):
01103c44
PE
9287 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9288 Don't assume EMACS_INT fits in int.
9910e595 9289
2638320e
PE
9290 * character.h (CHAR_VALID_P): Remove unused parameter.
9291 * fontset.c, lisp.h, xdisp.c: All uses changed.
9292
045eb8d9
PE
9293 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9294
c1f134b5
PE
9295 * fns.c (concat): Minor tuning based on overflow analysis.
9296 This doesn't fix any bugs. Use int to hold character, instead
9297 of constantly refetching from Emacs object. Use XFASTINT, not
9298 XINT, for value known to be a character. Don't bother comparing
9299 a single byte to 0400, as it's always less.
9300
395fcb93 9301 * floatfns.c (Fexpt):
327eeec8
PE
9302 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9303
abbd3d23
PE
9304 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9305 for characters.
9306
684a03ef
PE
9307 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9308
0fed43f3
PE
9309 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9310 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9311 incorrectly succeed when S was a string, because 4294967386 was
9312 truncated before it was used.
9313
8fd02eb7
PE
9314 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9315 Otherwise, an out-of-range integer could cause undefined behavior
9316 on a 64-bit host.
9317
f8c86b69
PE
9318 * composite.c: Use int, not EMACS_INT, for characters.
9319 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9320 EMACS_INT, for values that are known to be in character range.
9321 This doesn't fix any bugs but is the usual style inside Emacs and
9322 may generate better code on 32-bit machines.
9323
34206dd2
PE
9324 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9325 This is for reasons similar to the recent CHAR_STRING fix.
9326 * charset.c (Fencode_char): Check that character arg is actually
9327 a character. Pass an int to ENCODE_CHAR.
9328 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9329 wider than 'int', as a compile-time check to prevent future regressions
9330 in this area.
9331
c5958d4c 9332 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9333
9334 Make sure a 64-bit char is never passed to CHAR_STRING.
9335 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9336 by silently ignoring the top 32 bits, allowing some values
9337 that were far too large to be valid characters.
9338 * character.h: Include <verify.h>.
9339 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9340 arguments are no wider than unsigned, as a compile-time check
9341 to prevent future regressions in this area.
9342 * data.c (Faset):
01103c44 9343 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9344 (Fsubst_char_in_region):
9345 * fns.c (concat):
9346 * xdisp.c (decode_mode_spec_coding):
9347 Adjust to CHAR_STRING's new requirement.
9348 * editfns.c (Finsert_char, Fsubst_char_in_region):
9349 * fns.c (concat): Check that character args are actually
9350 characters. Without this test, these functions did the wrong
9351 thing with wildly out-of-range values on 64-bit hosts.
9352
d37ca623
PE
9353 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9354 These casts should not be needed on 32-bit hosts, either.
9355 * keyboard.c (read_char):
9356 * lread.c (Fload): Remove casts to unsigned.
9357
ea204efb
PE
9358 * lisp.h (UNSIGNED_CMP): New macro.
9359 This fixes comparison bugs on 64-bit hosts.
9360 (ASCII_CHAR_P): Use it.
9361 * casefiddle.c (casify_object):
01103c44 9362 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9363 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9364 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9365 * dispextern.h (FACE_FROM_ID):
9366 * keyboard.c (read_char): Use UNSIGNED_CMP.
9367
41cb286c
PE
9368 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9369 not to EMACS_INT, to avoid GCC warning.
9370
4a1b9832
PE
9371 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9372
55daad71
PE
9373 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9374 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9375 isn't needed on 32-bit machines.
8f95c75c 9376
01103c44
PE
9377 * buffer.c (Fgenerate_new_buffer_name):
9378 Use EMACS_INT for count, not int.
0ceccced 9379 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9380
9381 * data.c (Qcompiled_function): Now static.
9382
c6f072e7
PE
9383 * window.c (window_body_lines): Now static.
9384
20ce5912
PE
9385 * image.c (gif_load): Rename local to avoid shadowing.
9386
9c4c5f81
PE
9387 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9388 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9389 * alloc.c (make_save_value): Integer argument is now of type
9390 ptrdiff_t, not int.
9391 (mark_object): Use ptrdiff_t, not int.
9392 * lisp.h (pD): New macro.
9393 * print.c (print_object): Use it.
9394
c0c5c8ae
PE
9395 * alloc.c: Use EMACS_INT, not int, to count objects.
9396 (total_conses, total_markers, total_symbols, total_vector_size)
9397 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9398 (total_free_floats, total_floats, total_free_intervals)
9399 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9400 Now EMACS_INT, not int. All uses changed.
9401 (Fgarbage_collect): Compute overall total using a double, so that
9402 integer overflow is less likely to be a problem. Check for overflow
9403 when converting back to an integer.
5a25e253
PE
9404 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9405 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9406 These were 'int' variables that could overflow on 64-bit hosts;
9407 they were never used, so remove them instead of repairing them.
211a0b2a 9408 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9409 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9410 Previously, this ceilinged at INT_MAX, but that doesn't work on
9411 64-bit machines.
e46bb31a 9412 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9413
c78baabf 9414 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9415 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9416 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9417 when a (possibly-narrower) signed value would do just as well.
9418 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9419
c9d624c6
PE
9420 * alloc.c: Catch some string size overflows that we were missing.
9421 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9422 for convenience in STRING_BYTES_MAX.
9423 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9424 The definition here is exact; the one in lisp.h was approximate.
9425 (allocate_string_data): Check for string overflow. This catches
9426 some instances we weren't catching before. Also, it catches
9427 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9428 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9429 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9430
c9d624c6
PE
9431 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9432 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9433 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9434
353032ce
PE
9435 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9436
2bccce07
PE
9437 * alloc.c (Fmake_string): Check for out-of-range init.
9438
0ac30604
SM
94392011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9440
9441 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9442
c195f2de
JD
94432011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9444
9445 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9446 xg_get_default_scrollbar_width.
9447
9448 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9449 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9450 (style_changed_cb): Call update_theme_scrollbar_width and call
9451 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9452 all frames (Bug#8505).
9453 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9454 Call gtk_window_set_resizable if HAVE_GTK3.
9455 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9456 and height if HAVE_GTK3 (Bug#8505).
9457 (scroll_bar_width_for_theme): New variable.
9458 (update_theme_scrollbar_width): New function.
9459 (xg_get_default_scrollbar_width): Move code to
9460 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9461 (xg_initialize): Call update_theme_scrollbar_width.
9462
9463 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9464
9465 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9466
e10ac9f1
MR
94672011-06-12 Martin Rudalics <rudalics@gmx.at>
9468
9469 * frame.c (make_frame): Call other_buffer_safely instead of
9470 other_buffer.
9471
9472 * window.c (temp_output_buffer_show): Call display_buffer with
9473 second argument Vtemp_buffer_show_specifiers and reset latter
9474 immediately after the call.
9475 (Vtemp_buffer_show_specifiers): New variable.
9476 (auto_window_vscroll_p, next_screen_context_lines)
9477 (Vscroll_preserve_screen_position): Remove leading asterisks from
9478 doc-strings.
9479
2d3c217e 94802011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9481
7b7f97e8 9482 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9483 * buffer.c (Qclone_number): Remove for now, as it's unused.
9484 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9485 (record_buffer): Remove unused local.
9486 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9487 (set_frame_buffer_list): Remove; unused.
9488 * frame.h (other_visible_frames): Remove decl.
9489 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9490 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9491 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9492 if HAVE_GPM.
9493 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9494 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9495 Define only if HAVE_GPM.
9496 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9497 (update_hints_inhibit): Remove; never set. All uses removed.
9498 * widgetprv.h (emacsFrameClassRec): Remove decl.
9499 * window.c (delete_deletable_window): Now returns void, since it
9500 wasn't returning anything.
9501 (compare_window_configurations): Remove unused locals.
9502 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9503 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9504 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9505 the same widths as pointers. This follows up on the 2011-05-06 patch.
9506 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9507 * xterm.h: Likewise.
9508 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9509
1384b89e
JB
95102011-06-12 Juanma Barranquero <lekktu@gmail.com>
9511
9512 * makefile.w32-in: Update dependencies.
9513 (LISP_H): Add lib/intprops.h.
9514
1100a63c
CY
95152011-06-11 Chong Yidong <cyd@stupidchicken.com>
9516
9517 * image.c (gif_load): Add animation frame delay to the metadata.
9518 (syms_of_image): Use DEFSYM. New symbol `delay'.
9519
6198ccd0
MR
95202011-06-11 Martin Rudalics <rudalics@gmx.at>
9521
9522 * window.c (delete_deletable_window): Re-add.
9523 (Fset_window_configuration): Rewrite to handle dead buffers and
9524 consequently deletable windows.
9525 (window_tree, Fwindow_tree): Remove. Supply functionality in
9526 window.el.
9527 (compare_window_configurations): Simplify code.
9528
b6e3633c
AS
95292011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9530
1ab0dee5
AS
9531 * image.c (imagemagick_load_image): Fix type mismatch.
9532 (Fimagemagick_types): Likewise.
9533
b6e3633c
AS
9534 * window.h (replace_buffer_in_windows): Declare.
9535
9397e56f
MR
95362011-06-11 Martin Rudalics <rudalics@gmx.at>
9537
9538 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9539 Qclone_number. Remove external declaration of Qdelete_window.
9540 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9541 code.
640c8776
SM
9542 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9543 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9544 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9545 buffer list implementation.
9546 (other_buffer_safely): New function.
9547 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9548 calls to replace_buffer_in_windows and
9549 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9550 if allowed.
9551 (record_buffer): Inhibit quitting and rewrite using quittable
9552 functions. Run Qbuffer_list_update_hook if allowed.
9553 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9554 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9555 Move switch-to-buffer to window.el.
9397e56f
MR
9556 (bury-buffer): Move to window.el.
9557 (Vbuffer_list_update_hook): New variable.
9558
9559 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9560 section.
9561
9562 * window.h (resize_frame_windows): Move up in code.
9563 (Fwindow_frame): Remove EXFUN.
9564 (replace_buffer_in_all_windows): Remove prototype.
9565 (replace_buffer_in_windows_safely): Add prototype.
9566
9567 * window.c: Declare Qdelete_window static again. Move down
9568 declaration of select_count.
9569 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9570 (Fother_window): Move to window.el.
9571 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9572 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9573 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9574 window.el.
9575 (replace_buffer_in_windows): Implement by calling
9576 Qreplace_buffer_in_windows.
9577 (replace_buffer_in_all_windows): Remove with some functionality
9578 moved into replace_buffer_in_windows_safely.
9579 (replace_buffer_in_windows_safely): New function.
9580 (select_window_norecord, select_frame_norecord): Move in front
9581 of run_window_configuration_change_hook. Remove now obsolete
9582 declarations.
640c8776
SM
9583 (Fset_window_buffer): Rewrite doc-string.
9584 Call Qrecord_window_buffer.
9397e56f
MR
9585 (keys_of_window): Move binding for other-window to window.el.
9586
b50691aa
CY
95872011-06-11 Chong Yidong <cyd@stupidchicken.com>
9588
9589 * dispextern.h (struct image): Replace data member, whose int_val
9590 and ptr_val fields were not used by anything, with a single
9591 lisp_val object.
9592
9593 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9594 (gif_clear_image, gif_load, imagemagick_load_image)
9595 (gs_clear_image, gs_load): Callers changed.
9596
3f754b86
PE
95972011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9598
cca69397
PE
9599 * buffer.h: Include <time.h>, for time_t.
9600 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9601
109e28d0
PE
9602 Fix minor problems found by static checking.
9603
60737f02
PE
9604 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9605
4b66faf3
PE
9606 Make identifiers static if they are not used in other modules.
9607 * data.c (Qcompiled_function, Qframe, Qvector):
9608 * image.c (QimageMagick, Qsvg):
9609 * minibuf.c (Qmetadata):
9610 * window.c (resize_window_check, resize_root_window): Now static.
9611 * window.h (resize_window_check, resize_root_window): Remove decls.
9612
109e28d0
PE
9613 * window.c (window_deletion_count, delete_deletable_window):
9614 Remove; unused.
46a4ce9e
PE
9615 (window_body_lines): Now static.
9616 (Fdelete_other_windows_internal): Mark vars as initialized.
9617 Make sure 'resize_failed' is initialized.
9618 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9619 (resize_window_apply): Remove unused local.
9620 * window.h (delete_deletable_window): Remove decl.
9621
109e28d0 9622 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9623 (imagemagick_load_image): Fix pointer signedness problem by changing
9624 last arg from unsigned char * to char *. All uses changed.
9625 Also, fix a local for similar reasons.
9626 Remove unused locals. Remove locals to avoid shadowing.
9627 (fn_rsvg_handle_free): Remove; unused.
9628 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9629 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9630
3f754b86
PE
9631 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9632
2547adb1
CY
96332011-06-10 Chong Yidong <cyd@stupidchicken.com>
9634
9635 * image.c (gif_load): Fix omitted cast error introduced by
9636 2011-06-06 change.
9637
2c8e37d4
MR
96382011-06-10 Martin Rudalics <rudalics@gmx.at>
9639
9640 * window.h (resize_proportionally, orig_total_lines)
9641 (orig_top_line): Remove from window structure.
9642 (set_window_height, set_window_width, change_window_heights)
9643 (Fdelete_window): Remove prototypes.
9644 (resize_frame_windows): Remove duplicate declaration.
9645
440a42e3
EZ
96462011-06-10 Eli Zaretskii <eliz@gnu.org>
9647
9648 * window.h (resize_frame_windows, resize_window_check)
9649 (delete_deletable_window, resize_root_window)
9650 (resize_frame_windows): Declare prototypes.
9651
9652 * window.c (resize_window_apply): Make definition be "static" to
9653 match the prototype.
9654
562dd5e9
MR
96552011-06-10 Martin Rudalics <rudalics@gmx.at>
9656
9657 * window.c: Remove declarations of Qwindow_size_fixed,
9658 window_min_size_1, window_min_size_2, window_min_size,
9659 size_window, window_fixed_size_p, enlarge_window, delete_window.
9660 Remove static from declaration of Qdelete_window, it's
9661 temporarily needed by Fbury_buffer.
9662 (replace_window): Don't assign orig_top_line and
9663 orig_total_lines.
9664 (Fdelete_window, delete_window): Remove. Window deletion is
9665 handled by window.el.
640c8776
SM
9666 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9667 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9668 (Fdelete_other_windows): Remove. Deleting other windows is
9669 handled by window.el.
9670 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9671 handled in window.el.
9672 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9673 Window minimum sizes are handled in window.el.
9674 (shrink_windows, size_window, set_window_height)
9675 (set_window_width, change_window_heights, window_height)
9676 (window_width, CURBEG, CURSIZE, enlarge_window)
9677 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9678 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9679 handled in window.el.
9680 (make_dummy_parent): Rename to make_parent_window and give it a
9681 second argument horflag.
9682 (make_window): Don't set resize_proportionally any more.
9683 (Fsplit_window): Remove. Windows are split in window.el.
9684 (save_restore_action, save_restore_orig_size)
9685 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9686 Resize mini windows in window.el.
9687 (grow_mini_window, shrink_mini_window): Implement by calling
9688 Qresize_root_window_vertically, resize_window_check and
9689 resize_window_apply.
640c8776
SM
9690 (saved_window, Fset_window_configuration, save_window_save):
9691 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9692 resize_proportionally.
9693 (window_min_height, window_min_width): Move to window.el.
9694 (keys_of_window): Move bindings for delete-other-windows,
9695 split-window, delete-window and enlarge-window to window.el.
9696
9697 * buffer.c: Temporarily extern Qdelete_window.
9698 (Fbury_buffer): Temporarily call Qdelete_window instead of
9699 Fdelete_window (Fbury_buffer will move to window.el soon).
9700
9701 * frame.c (set_menu_bar_lines_1): Remove code handling
9702 orig_top_line and orig_total_lines.
9703
9704 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9705 set_window_height but set heights directly.
9706 (change_frame_size_1): Use resize_frame_windows.
9707
9708 * xdisp.c (init_xdisp): Don't use set_window_height but set
9709 heights directly.
9710
640c8776
SM
9711 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9712 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9713 run_window_configuration_change_hook.
9714
9715 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9716 instead of change_window_heights and run
9717 run_window_configuration_change_hook.
9718
1a13852e
MR
97192011-06-09 Martin Rudalics <rudalics@gmx.at>
9720
9721 * window.c (replace_window): Rename second argument REPLACEMENT to
9722 NEW. New third argument SETFLAG. Rewrite.
9723 (delete_window, make_dummy_parent): Call replace_window with
9724 third argument 1.
9725 (window_list_1): Move down in code.
9726 (run_window_configuration_change_hook): Move set_buffer part
9727 before select_frame_norecord part in order to unwind correctly.
9728 Rename count1 to count.
9729 (recombine_windows, delete_deletable_window, resize_root_window)
9730 (Fdelete_other_windows_internal)
9731 (Frun_window_configuration_change_hook, make_parent_window)
9732 (resize_window_check, resize_window_apply, Fresize_window_apply)
9733 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9734 (Fdelete_window_internal, Fresize_mini_window_internal):
9735 New functions.
1a13852e
MR
9736 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9737
f3d1777e
MR
97382011-06-08 Martin Rudalics <rudalics@gmx.at>
9739
496e208e
MR
9740 * window.h (window): Add some new members to window structure -
9741 normal_lines, normal_cols, new_total, new_normal, clone_number,
9742 splits, nest, prev_buffers, next_buffers.
9743 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9744 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9745
f3d1777e
MR
9746 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9747 Remove.
496e208e
MR
9748 (make_dummy_parent): Set new members of windows structure.
9749 (make_window): Move down in code. Handle new members of window
9750 structure.
9751 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9752 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9753 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9754 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9755 (Fset_window_next_buffers, Fset_window_clone_number):
9756 New functions.
496e208e
MR
9757 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9758 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9759 Doc-string fixes.
9760 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9761 Argument WINDOW can be now internal window too.
9762 (Fwindow_use_time): Move up in code.
9763 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9764 Rewrite doc-string.
9765 (Fset_window_configuration, saved_window)
9766 (Fcurrent_window_configuration, save_window_save): Handle new
9767 members of window structure.
b9e809c2
MR
9768 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9769 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9770 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9771 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9772 Qget_mru_window, Qresize_root_window,
9773 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9774 Qauto_buffer_name; staticpro them.
f3d1777e 9775
abde8f8c
MR
97762011-06-07 Martin Rudalics <rudalics@gmx.at>
9777
9778 * window.c (Fwindow_total_size, Fwindow_left_column)
9779 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9780 (Fwindow_list_1): New functions.
9781 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9782 (Fwindow_width, Fscroll_left, Fscroll_right):
9783 Use window_body_cols instead of window_box_text_cols.
9784 (delete_window, Fset_window_configuration):
9785 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9786 (delete_all_subwindows): Take a window as argument and not a
9787 structure. Rewrite.
190b47e6
MR
9788 (window_loop): Remove handling of GET_LRU_WINDOW and
9789 GET_LARGEST_WINDOW.
9790 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9791
9792 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9793 window_box_text_cols. delete_all_subwindows now takes a
9794 Lisp_Object as argument.
abde8f8c 9795
640c8776
SM
9796 * indent.c (compute_motion, Fcompute_motion):
9797 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9798
fa8a67e6
MR
9799 * frame.c (delete_frame): Call delete_all_subwindows with root
9800 window as argument.
9801
a54e3482
DC
98022011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9803
9804 * fns.c (Fputhash): Document return value.
9805
60002bf5
CY
98062011-06-06 Chong Yidong <cyd@stupidchicken.com>
9807
9808 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9809
0c671da6 98102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9811
b862a52a 9812 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9813
be44ca6c
PE
9814 Check for overflow when converting integer to cons and back.
9815 * charset.c (Fdefine_charset_internal, Fdecode_char):
9816 Use cons_to_unsigned to catch overflow.
9817 (Fencode_char): Use INTEGER_TO_CONS.
9818 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9819 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9820 * data.c (long_to_cons, cons_to_long): Remove.
9821 (cons_to_unsigned, cons_to_signed): New functions.
9822 These signal an error for invalid or out-of-range values.
9823 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9824 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9825 * font.c (Ffont_variation_glyphs):
9826 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9827 * lisp.h: Include <intprops.h>.
9828 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9829 (cons_to_signed, cons_to_unsigned): New decls.
9830 (long_to_cons, cons_to_long): Remove decls.
9831 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9832 (Fprimitive_undo): Use CONS_TO_INTEGER.
9833 * xfns.c (Fx_window_property): Likewise.
9834 * xselect.c: Include <limits.h>.
9835 (x_own_selection, selection_data_to_lisp_data):
9836 Use INTEGER_TO_CONS.
9837 (x_handle_selection_request, x_handle_selection_clear)
9838 (x_get_foreign_selection, Fx_disown_selection_internal)
9839 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9840 (lisp_data_to_selection_data): Use cons_to_unsigned.
9841 (x_fill_property_data): Use cons_to_signed.
9842 Report values out of range.
9843
d1f3d2af
PE
9844 Check for buffer and string overflow more precisely.
9845 * buffer.h (BUF_BYTES_MAX): New macro.
9846 * lisp.h (STRING_BYTES_MAX): New macro.
9847 * alloc.c (Fmake_string):
9848 * character.c (string_escape_byte8):
9849 * coding.c (coding_alloc_by_realloc):
9850 * doprnt.c (doprnt):
9851 * editfns.c (Fformat):
9852 * eval.c (verror):
9853 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9854 since they may not be the same number.
9855 * editfns.c (Finsert_char):
9856 * fileio.c (Finsert_file_contents):
9857 Likewise for BUF_BYTES_MAX.
9858
dd52fcea
PE
9859 * image.c: Use ptrdiff_t, not int, for sizes.
9860 (slurp_file): Switch from int to ptrdiff_t.
9861 All uses changed.
9862 (slurp_file): Check that file size fits in both size_t (for
9863 malloc) and ptrdiff_t (for sanity and safety).
9864
7f9bbdbb
PE
9865 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9866 if b->modtime has its maximal value.
9867
dfe18f82
PE
9868 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9869
84acfcf0
PE
9870 Don't assume time_t can fit into int.
9871 * buffer.h (struct buffer.modtime): Now time_t, not int.
9872 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9873 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9874
ccd9a01a
PE
9875 Minor fixes for signed vs unsigned integers.
9876 * character.h (MAYBE_UNIFY_CHAR):
9877 * charset.c (maybe_unify_char):
9878 * keyboard.c (read_char, reorder_modifiers):
9879 XINT -> XFASTINT, since the integer must be nonnegative.
9880 * ftfont.c (ftfont_spec_pattern):
9881 * keymap.c (access_keymap, silly_event_symbol_error):
9882 XUINT -> XFASTINT, since the integer must be nonnegative.
9883 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9884 since it makes no difference and we prefer signed.
9885 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9886 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9887 nonnegative.
9888
d6d100dd
SM
98892011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9890
9891 * window.h (Fwindow_frame): Declare.
9892
2b6148e4
PE
98932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9894
9895 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9896 (SPARE_MEMORY): Always define.
9897 (LARGE_REQUEST): Remove.
9898 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9899
f230ecc9
MR
99002011-06-06 Martin Rudalics <rudalics@gmx.at>
9901
727e958e
MR
9902 * lisp.h: Move EXFUNS for Fframe_root_window,
9903 Fframe_first_window and Fset_frame_selected_window to window.h.
9904
9905 * window.h: Move EXFUNS for Fframe_root_window,
9906 Fframe_first_window and Fset_frame_selected_window here from
9907 lisp.h.
9908
9909 * frame.c (Fwindow_frame, Fframe_first_window)
9910 (Fframe_root_window, Fframe_selected_window)
9911 (Fset_frame_selected_window): Move to window.c.
9912 (Factive_minibuffer_window): Move to minibuf.c.
9913 (Fother_visible_frames_p): New function.
9914
9915 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9916
f230ecc9
MR
9917 * window.c (decode_window, decode_any_window): Move up in code.
9918 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9919 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9920 (Fwindow_buffer): Move up and rewrite doc-string.
9921 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9922 (Fwindow_prev): New functions.
727e958e
MR
9923 (Fwindow_frame): Move here from frame.c. Accept any window as
9924 argument.
9925 (Fframe_root_window, Fframe_first_window)
9926 (Fframe_selected_window): Move here from frame.c. Accept frame
9927 or arbitrary window as argument. Update doc-strings.
9928 (Fminibuffer_window): Move up in code.
9929 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9930 (Fset_frame_selected_window): Move here from frame.c.
9931 Marginal rewrite.
727e958e
MR
9932 (Fselected_window, select_window, Fselect_window): Move up in
9933 code. Minor doc-string fixes.
f230ecc9 9934
4d09bcf6
PE
99352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9936
9937 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9938 Do not assume that spare memory exists; that assumption is valid
9939 only if SYSTEM_MALLOC.
9940 (LARGE_REQUEST): New macro, so that the issue of large requests
9941 is separated from the issue of spare memory.
9942
810928a2
AS
99432011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9944
172418ad
AS
9945 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9946 format. (Bug#8806)
9947
43f862f7
AS
9948 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9949
810928a2
AS
9950 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9951 before statements.
9952
a059fe24
JD
99532011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9954
9955 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9956
9957 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9958
9959 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9960 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9961
989bf368
JB
99622011-06-05 Juanma Barranquero <lekktu@gmail.com>
9963
9964 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9965
4b80f674
CY
99662011-06-04 Chong Yidong <cyd@stupidchicken.com>
9967
9968 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9969 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9970 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9971 New error handlers.
4b80f674
CY
9972 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9973 Obey Vx_select_enable_clipboard_manager. Catch errors in
9974 x_clipboard_manager_save (Bug#8779).
9975 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9976 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9977
99a33b77 99782011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9979
9980 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9981
99a33b77 99822011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9983
9984 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9985 in the current matrix if keep_current_p is non-zero.
9986
8264569d
EZ
99872011-06-04 Eli Zaretskii <eliz@gnu.org>
9988
9989 * bidi.c (bidi_level_of_next_char): Fix last change.
9990
57f97249
EZ
99912011-06-03 Eli Zaretskii <eliz@gnu.org>
9992
fec2107c 9993 Support bidi reordering of text covered by display properties.
57f97249 9994
fec2107c
EZ
9995 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9996 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9997 (bidi_cache_search, bidi_cache_iterator_state)
9998 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9999 (bidi_level_of_next_char, bidi_move_to_visually_next):
10000 Support character positions inside a run of characters covered by a
fec2107c
EZ
10001 display string.
10002 (bidi_paragraph_init, bidi_resolve_explicit_1)
10003 (bidi_level_of_next_char): Call bidi_fetch_char and
10004 bidi_fetch_char_advance instead of FETCH_CHAR and
10005 FETCH_CHAR_ADVANCE.
10006 (bidi_init_it): Initialize new members.
10007 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10008 definitions.
10009 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10010 instead of using explicit *_CHAR codes.
d6d100dd
SM
10011 (bidi_resolve_explicit, bidi_resolve_weak):
10012 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10013 bidirectional text is supported only in multibyte buffers.
10014 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10015 it to initialize the frame_window_p member of struct bidi_it.
10016 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10017 (bidi_resolve_explicit, bidi_resolve_weak)
10018 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10019 bidi_it->nchars is non-positive.
10020 (bidi_level_of_next_char): Don't try to lookup the cache for the
10021 next/previous character if nothing is cached there yet, or if we
10022 were just reseat()'ed to a new position.
c40e2fb2 10023
0e14fe90
EZ
10024 * xdisp.c (set_cursor_from_row): Set start and stop points
10025 according to the row's direction when priming the loop that looks
10026 for the glyph on which to display cursor.
10027 (single_display_spec_intangible_p): Function deleted.
10028 (display_prop_intangible_p): Reimplement to call
10029 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10030 Accept 3 additional arguments needed by handle_display_spec.
10031 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10032 values: lists, `(when COND...)' forms, etc.
10033 (single_display_spec_string_p): Support property values that are
10034 lists with the argument STRING its top-level element.
10035 (display_prop_string_p): Fix the condition for processing a
10036 property that is a list to be consistent with handle_display_spec.
fec2107c 10037 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10038 last portion of handle_display_prop.
10039 (compute_display_string_pos): Accept additional argument
10040 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10041 value of a `display' property is a "replacing spec".
10042 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10043 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10044 the display property, but just return a value indicating whether
10045 the display property will replace the characters it covers.
10046 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10047 frame_window_p members of struct bidi_it.
d6d100dd
SM
10048 (compute_display_string_pos, compute_display_string_end):
10049 New functions.
fec2107c
EZ
10050 (push_it): Accept second argument POSITION, where pop_it should
10051 jump to continue iteration.
10052 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10053
fec2107c
EZ
10054 * keyboard.c (adjust_point_for_property): Adjust the call to
10055 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10056
10057 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10058 (bidi_init_it): Update prototypes.
10059 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10060 (compute_display_string_pos, compute_display_string_end):
10061 Declare prototypes.
fec2107c
EZ
10062 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10063 EMACS_INT.
fc6f18ce 10064
40087514 100652011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10066
57f53182
PE
10067 Malloc failure behavior now depends on size of allocation.
10068 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10069 * lisp.h: Change signatures accordingly.
10070 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10071 All callers changed. (Bug#8762)
10072
10073 * gnutls.c: Use Emacs's memory allocators.
10074 Without this change, the gnutls library would invoke malloc etc.
10075 directly, which causes problems on non-SYNC_INPUT hosts, and which
10076 runs afoul of improving memory_full behavior. (Bug#8761)
10077 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10078 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10079 xfree instead of the default malloc, realloc, free.
10080 (Fgnutls_boot): No need to check for memory allocation failure,
10081 since xmalloc does that for us.
10082
ac32cd99 10083 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10084 * category.c (hash_get_category_set):
10085 * ccl.c (ccl_driver):
10086 * charset.c (Fdefine_charset_internal):
10087 * charset.h (struct charset.hash_index):
10088 * composite.c (get_composition_id, gstring_lookup_cache)
10089 (composition_gstring_put_cache):
10090 * composite.h (struct composition.hash_index):
10091 * dispextern.h (struct image.hash):
10092 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10093 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10094 (hashfn_equal, hashfn_user_defined, make_hash_table)
10095 (maybe_resize_hash_table, hash_lookup, hash_put)
10096 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10097 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10098 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10099 * image.c (make_image, search_image_cache, lookup_image)
10100 (xpm_put_color_table_h):
10101 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10102 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10103 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10104 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10105 * alloc.c (allocate_vectorlike):
10106 Check for overflow in vector size calculations.
10107 * ccl.c (ccl_driver):
10108 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10109 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10110 need to be updated by these changes.
40087514
PE
10111 * fns.c (make_hash_table, maybe_resize_hash_table):
10112 Check for integer overflow with large hash tables.
0de4bb68
PE
10113 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10114 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10115 (SXHASH_REDUCE): New macro.
10116 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10117 Use it instead of discarding useful hash info with large hash values.
10118 (sxhash_float): New function.
10119 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10120 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10121 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10122 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10123 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10124 Adjust signatures to match updated version of code.
10125 (consing_since_gc): Now EMACS_INT, since a single hash table can
10126 use more than INT_MAX bytes.
10127
698d32e2
DN
101282011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10129
10130 Make it possible to build with GCC-4.6+ -O2 -flto.
10131
10132 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10133
fd6fa53f
SM
101342011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10135
10136 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10137 Call minibuffer-inactive-mode.
10138
864db017
JB
101392011-05-31 Juanma Barranquero <lekktu@gmail.com>
10140
10141 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10142 Update dependencies.
10143
2ad0baf4
DN
101442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10145
10146 * data.c (init_data): Remove code for UTS, this system is not
10147 supported anymore.
10148
4fcc2638
DN
101492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10150
10151 Don't force ./temacs to start in terminal mode.
10152
10153 * frame.c (make_initial_frame): Initialize faces in all cases, not
10154 only when CANNOT_DUMP is defined.
10155 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10156
c56e0fd5
DN
101572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10158
10159 * dispnew.c (add_window_display_history): Use const for the string
10160 pointer. Remove declaration, not needed.
10161
333d54da 101622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10163
55d4c1b2 10164 Use 'inline', not 'INLINE'.
333d54da 10165 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10166 * alloc.c, fontset.c (INLINE): Remove.
10167 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10168 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10169 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10170 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10171 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10172
738db178
DN
101732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10174
10175 Make it possible to run ./temacs.
10176
10177 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10178 syms_of_callproc does the same thing. Remove test for
10179 "initialized", do it in the caller.
10180 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10181
620c53a6
SM
101822011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10183
10184 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10185 (read_minibuf): Use get_minibuffer.
10186 (syms_of_minibuf): Use DEFSYM.
10187 (Qmetadata): New var.
10188 * data.c (Qbuffer): Don't make it static.
10189 (syms_of_data): Use DEFSYM.
10190
e003a292
PE
101912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10192
10193 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10194 (CCL_CODE_MIN): New macro.
10195
ed008a6d
PE
101962011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10197
3687c2ef
PE
10198 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10199
ed008a6d
PE
10200 * eval.c (Qdebug): Now static.
10201 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10202 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10203 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10204
d66c4c7c
CY
102052011-05-29 Chong Yidong <cyd@stupidchicken.com>
10206
10207 * image.c: Various fixes to ImageMagick code comments.
10208 (Fimagemagick_types): Doc fix.
10209
5fbc2025
PE
102102011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10211
0196f88a
PE
10212 Minor fixes prompted by GCC 4.6.0 warnings.
10213
10214 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10215
5fbc2025
PE
10216 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10217 (x_clipboard_manager_save_all): Move extern decl to ...
10218 * xterm.h: ... here, so that it can be checked for consistency.
10219
1dd3c2d9
CY
102202011-05-29 Chong Yidong <cyd@stupidchicken.com>
10221
10222 * xselect.c (x_clipboard_manager_save_frame)
10223 (x_clipboard_manager_save_all): New functions.
10224 (Fx_clipboard_manager_save): Lisp function deleted.
10225
10226 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10227 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10228
10229 * xterm.h: Update prototype.
10230
5ba6571d
WX
102312011-05-28 William Xu <william.xwl@gmail.com>
10232
10233 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10234 exiting (Bug#8239).
10235
3eaff834
JM
102362011-05-28 Jim Meyering <meyering@redhat.com>
10237
e1900994 10238 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10239 * fns.c (to_uchar): Define.
10240 (crypto_hash_function): Use it to convert some newly-signed
10241 variables to unsigned, to avoid sign-extension bugs. For example,
10242 without this change, (md5 "truc") would evaluate to
10243 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10244 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10245 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10246
0f6990a7
PE
102472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10248
10249 Integer overflow fixes.
c8a9ca5a 10250
08686060
PE
10251 * dbusbind.c: Serial number integer overflow fixes.
10252 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10253 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10254 to hold a serial number that is too large for a fixnum.
10255 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10256 Check for serial numbers out of range. Decode any serial number
59568bf0 10257 that was so large that it became a float. (Bug#8722)
08686060 10258
2d1fc3c7
PE
10259 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10260 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10261 Use XFASTINT rather than XUINT when numbers are nonnegative.
10262 (xd_append_arg, Fdbus_method_return_internal):
10263 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10264 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10265 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10266 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10267 (Bug#8722)
2d1fc3c7 10268
c8a9ca5a
PE
10269 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10270
519e1d69
PE
10271 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10272
6df6ae42 10273 ccl: Add integer overflow checks.
30569699
PE
10274 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10275 (IN_INT_RANGE): New macros.
10276 (ccl_driver): Use them to check for integer overflow when
10277 decoding a CCL program. Many of the new checks are whether XINT (x)
10278 fits in int; it doesn't always, on 64-bit hosts. The new version
10279 doesn't catch all possible integer overflows, but it's an
847044ea 10280 improvement. (Bug#8719)
30569699 10281
c11285dc
PE
10282 * alloc.c (make_event_array): Use XINT, not XUINT.
10283 There's no need for unsigned here.
10284
fdccd48e
PE
10285 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10286 This follows up to the 2011-05-06 change that substituted uintptr_t
10287 for EMACS_INT. This case wasn't caught back then.
10288
37910ab2
PE
10289 Rework Fformat to avoid integer overflow issues.
10290 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10291 now (part of C89). Include <verify.h>.
10292 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10293 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10294 (Fformat): Avoid the prepass trying to compute sizes; it was only
10295 approximate and thus did not catch overflow reliably. Instead, walk
10296 through the format just once, formatting and computing sizes as we go,
10297 checking for integer overflow at every step, and allocating a larger
10298 buffer as needed. Keep track separately whether the format is
10299 multibyte. Keep only the most-recently calculated precision, rather
10300 than them all. Record whether each argument has been converted to
10301 string. Use EMACS_INT, not int, for byte and char and arg counts.
10302 Support field widths and precisions larger than INT_MAX. Avoid
10303 sprintf's undefined behavior with conversion specifications such as %#d
10304 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10305 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10306 formatting out-of-range floating point numbers with int
9173deec 10307 formats. (Bug#8668)
37910ab2 10308
2e6578fb
PE
10309 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10310
0ae6bdee
PE
10311 * data.c: Avoid integer truncation in expressions involving floats.
10312 * data.c: Include <intprops.h>.
10313 (arith_driver): When there's an integer overflow in an expression
10314 involving floating point, convert the integers to floating point
10315 so that the resulting value does not suffer from catastrophic
10316 integer truncation. For example, on a 64-bit host (* 4
10317 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10318 Do not rely on undefined behavior after integer overflow.
10319
de883a70
PE
10320 merge count_size_as_multibyte, parse_str_to_multibyte
10321 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10322 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10323 Check for integer overflow.
10324 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10325 since it's now a duplicate of the other. This is more of
10326 a character than a buffer op, so better that it's in character.c.
10327 * fns.c, print.c: Adjust to above changes.
10328
2ff916cb
PE
103292011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10330
10331 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10332
f1b54466
PE
103332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10334
fb1ac845
PE
10335 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10336 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10337 (x_clipboard_manager_save): Now static.
10338 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10339
f1b54466
PE
10340 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10341 (crypto_hash_function): Now static.
10342 Fix pointer signedness problems. Avoid unnecessary initializations.
10343
a9f737ee
CY
103442011-05-27 Chong Yidong <cyd@stupidchicken.com>
10345
10346 * termhooks.h (Vselection_alist): Make it terminal-local.
10347
10348 * terminal.c (create_terminal): Initialize it.
10349
10350 * xselect.c: Support for clipboard managers.
10351 (Vselection_alist): Move to termhooks.h as terminal-local var.
10352 (LOCAL_SELECTION): New macro.
10353 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10354 (symbol_to_x_atom): Remove gratuitous arg.
10355 (x_handle_selection_request, lisp_data_to_selection_data)
10356 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10357 (x_own_selection, x_get_local_selection, x_convert_selection):
10358 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10359 (some_frame_on_display): Delete unused function.
10360 (Fx_own_selection_internal, Fx_get_selection_internal)
10361 (Fx_disown_selection_internal, Fx_selection_owner_p)
10362 (Fx_selection_exists_p): New optional frame arg.
10363 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10364 (x_handle_selection_clear): Don't treat other terminals with the
10365 same keyboard specially. Use the terminal-local Vselection_alist.
10366 (x_clear_frame_selections): Use Frun_hook_with_args.
10367
10368 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10369
10370 * xterm.h: Add support for those atoms.
10371
e067f0c1
CY
103722011-05-26 Chong Yidong <cyd@stupidchicken.com>
10373
10374 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10375 (converted_selections, conversion_fail_tag): New global variables.
10376 (x_selection_request_lisp_error): Free the above.
10377 (x_get_local_selection): Remove unnecessary code.
10378 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10379 of converted selections stored in converted_selections.
10380 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10381 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10382 (x_convert_selection): New function.
10383 (x_handle_selection_event): Simplify.
10384 (x_get_foreign_selection): Don't ignore incoming requests while
10385 waiting for an answer; this will fail when we implement
10386 SAVE_TARGETS, and seems unnecessary anyway.
10387 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10388 (Vx_sent_selection_functions): Doc fix.
10389
0f4aebc0
LL
103902011-05-26 Leo Liu <sdl.web@gmail.com>
10391
10392 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10393
e61124cd
YM
103942011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10395
10396 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10397
10398 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10399 for fringe update if it has periodic bitmap.
ac389d0c 10400 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10401 and fringe_bitmap_periodic_p.
10402
10403 * fringe.c (get_fringe_bitmap_data): New function.
10404 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10405 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10406 row. Mark glyph row for fringe update if periodicity changed.
10407
10408 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10409 for fringe update unless it has periodic bitmap.
10410
f16d9837
KH
104112011-05-25 Kenichi Handa <handa@m17n.org>
10412
10413 * xdisp.c (get_next_display_element): Set correct it->face_id for
10414 a static composition.
10415
e1b90ef6
LL
104162011-05-24 Leo Liu <sdl.web@gmail.com>
10417
10418 * deps.mk (fns.o):
10419 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10420
10421 * fns.c (crypto_hash_function, Fsha1): New function.
10422 (Fmd5): Use crypto_hash_function.
10423 (syms_of_fns): Add Ssha1.
10424
7400048f
PE
104252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10426
10427 * gnutls.c: Remove unused macros.
10428 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10429 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10430 Remove macros that are defined and never used.
10431 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10432
abb71cf4
CY
104332011-05-22 Chong Yidong <cyd@stupidchicken.com>
10434
10435 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10436 (Fx_get_selection_internal): Minor cleanup.
10437 (Fx_own_selection_internal): Rename arguments for consistency with
10438 select.el.
10439
6307db39
PE
104402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10441
10442 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10443
f3d4e0a4
CY
104442011-05-22 Chong Yidong <cyd@stupidchicken.com>
10445
10446 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10447
4d8ade89
YM
104482011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10449
10450 * dispnew.c (scrolling_window): Don't exclude the case that the
10451 last enabled row in the desired matrix touches the bottom boundary.
10452
32078c8d
GM
104532011-05-21 Glenn Morris <rgm@gnu.org>
10454
10455 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10456 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10457 and add some more files.
32078c8d 10458
7285dc67
EZ
104592011-05-20 Eli Zaretskii <eliz@gnu.org>
10460
10461 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10462 report_file_error introduced by the change from 2011-05-07.
10463
89d1bd22
PE
104642011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10465
10466 * systime.h (Time): Define only if emacs is defined.
10467 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10468 where the include path doesn't have X11/X.h by default. See
10469 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10470
cd394be1 104712011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10472
10473 * composite.c (find_automatic_composition): Fix previous change.
10474
b9704ad9
GM
104752011-05-20 Glenn Morris <rgm@gnu.org>
10476
10477 * lisp.mk: New file, split from Makefile.in.
10478 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10479 (shortlisp): Remove.
10480 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10481
4a720484
GM
104822011-05-19 Glenn Morris <rgm@gnu.org>
10483
10484 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10485 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10486 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10487 (lisp): Set the order to that of loadup.el.
10488 (shortlisp): Make it a copy of $lisp.
10489 (SOME_MACHINE_LISP): Remove.
10490 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10491 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10492
a28d4396
KH
104932011-05-18 Kenichi Handa <handa@m17n.org>
10494
10495 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10496 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10497 (find_automatic_composition): Mostly rewrite for efficiency.
10498
a2b1fa8e
JB
104992011-05-18 Juanma Barranquero <lekktu@gmail.com>
10500
10501 * makefile.w32-in: Update dependencies.
10502
8e1f5610
CS
105032011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10504
10505 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10506 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10507
7025ee00 105082011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10509
cdfa6eab
PE
10510 Fix some integer overflow issues, such as string length overflow.
10511
06d6db33
PE
10512 * insdel.c (count_size_as_multibyte): Check for string overflow.
10513
2b4560a8
PE
10514 * character.c (lisp_string_width): Check for string overflow.
10515 Use EMACS_INT, not int, for string indexes and lengths; in
10516 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10517 the resulting string length overflows an EMACS_INT; instead,
10518 report a string overflow if no precision given. When checking for
10519 precision exhaustion, use a check that cannot possibly have
10520 integer overflow. (Bug#8675)
10521 * character.h (lisp_string_width): Adjust to new signature.
10522
cb93f9be
PE
10523 * alloc.c (string_overflow): New function.
10524 (Fmake_string): Use it. This doesn't change behavior, but saves
10525 a few bytes and will simplify future changes.
10526 * character.c (string_escape_byte8): Likewise.
10527 * lisp.h (string_overflow): New decl.
10528
1a1f3366
PE
10529 Fixups, following up to the user-interface timestamp change.
10530 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10531 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10532 * msdos.c (mouse_get_pos): Likewise.
10533 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10534 * w32gui.h (Time): Define by including "systime.h" rather than by
10535 declaring it ourselves. (Bug#8664)
10536
d4e3e4d3
PE
10537 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10538 * image.c (clear_image_cache): Likewise.
10539
f6a24d19
PE
10540 * term.c (term_mouse_position): Don't assume time_t wraparound.
10541
08dc5ae6
PE
10542 Be more systematic about user-interface timestamps.
10543 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10544 and sometimes 'EMACS_UINT', to represent these timestamps.
10545 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10546 This makes the code easier to follow, and makes it easier to catch
10547 integer overflow bugs such as Bug#8664.
10548 * frame.c (Fmouse_position, Fmouse_pixel_position):
10549 Use Time, not unsigned long, for user-interface timestamps.
10550 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10551 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10552 * keyboard.h (last_event_timestamp): Likewise.
10553 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10554 * menu.h (xmenu_show): Likewise.
10555 * term.c (term_mouse_position): Likewise.
10556 * termhooks.h (struct input_event.timestamp): Likewise.
10557 (struct terminal.mouse_position_hook): Likewise.
10558 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10559 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10560 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10561 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10562 what it was before.
10563 * menu.h, termhooks.h: Include "systime.h", for Time.
10564
8e55734a
PE
10565 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10566 Don't assume that the difference between two unsigned long values
10567 can fit into an integer. At this point, we know button_down_time
10568 <= event->timestamp, so the difference must be nonnegative, so
10569 there's no need to cast the result if double-click-time is
10570 nonnegative, as it should be; check that it's nonnegative, just in
10571 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10572 apart (about 25 days). (Bug#8664)
8e55734a 10573
841f1b75 10574 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10575 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10576
3e26f69c
PE
10577 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10578 that always fit in int. Use a sentinel instead of a counter, to
10579 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10580 * frame.h (struct frame): Use int for menu_bar_items_used
10581 instead of EMACS_INT, since it always fits in int.
3e26f69c 10582
5cc152c0
PE
10583 * menu.c (grow_menu_items): Check for int overflow.
10584
d89eb65e
PE
10585 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10586
5235bd3e
PE
10587 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10588 Before, the code was not consistent. These values cannot exceed
10589 2**31 - 1 so there's no need to make them unsigned.
10590 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10591 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10592 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10593 as modifiers.
10594 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10595
bc827e23
PE
10596 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10597 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10598 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10599 presumably because the widths might not match.
10600
78eb494e
PE
10601 * window.c (size_window): Avoid needless test at loop start.
10602
04f2d78b
CB
106032011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10604
10605 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10606
d2fc7e3d 106072011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10608
10609 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10610
d2fc7e3d 106112011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10612
10613 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10614 `width' to `bar_area_x' and `bar_area_width', respectively.
10615 (x_scroll_run): Take account of fringe background extension.
10616
04f2d78b
CB
10617 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10618 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10619 `bar_area_width', respectively.
10620 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10621 background extension.
10622
79b70037
GM
106232011-05-10 Jim Meyering <meyering@redhat.com>
10624
10625 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10626
2f142cc5
JB
106272011-05-10 Juanma Barranquero <lekktu@gmail.com>
10628
10629 * image.c (Finit_image_library): Return t for built-in image types,
10630 like pbm and xbm. (Bug#8640)
10631
57679c86
AS
106322011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10633
10634 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10635
888c9e86
EZ
106362011-05-07 Eli Zaretskii <eliz@gnu.org>
10637
b0512a1d
EZ
10638 * w32console.c (Fset_screen_color): Doc fix.
10639 (Fget_screen_color): New function.
10640 (syms_of_ntterm): Defsubr it.
10641
7285dc67
EZ
10642 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10643 unlink the temporary file if Fcall_process didn't create it in the
10644 first place.
10645 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10646 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10647 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10648 cue to call_process_cleanup not to close that handle.
10649
4d3fcc8e
BK
106502011-05-07 Ben Key <bkey76@gmail.com>
10651
10652 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10653 one of two shell specific rules, either bootstrap-temacs-CMD or
10654 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10655 to the previous implementation of the bootstrap-temacs rule.
10656 The bootstrap-temacs-CMD rule is similar to the previous
10657 implementation of the bootstrap-temacs rule except that it
10658 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10659 variable.
10660
10661 These changes, along with some changes to nt/configure.bat,
10662 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10663 earlier fix to add support for --cflags and --ldflags options
10664 that include quotes so that it works whether make uses cmd or
10665 sh as the shell.
10666
b4289b64
MA
106672011-05-06 Michael Albinus <michael.albinus@gmx.de>
10668
10669 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10670 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10671 is a constant.
10672 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10673 a string. Handle both cases.
10674 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10675 (Fdbus_register_method): Use Qinvalid_function.
10676
af4c0e28
JB
106772011-05-06 Juanma Barranquero <lekktu@gmail.com>
10678
10679 * makefile.w32-in: Update dependencies.
10680 (LISP_H): Add inttypes.h and stdin.h.
10681 (PROCESS_H): Add unistd.h.
10682
c51453d9
EZ
106832011-05-06 Eli Zaretskii <eliz@gnu.org>
10684
10685 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10686 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10687
8ff0ac3c 106882011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10689
4c4b566b
PE
10690 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10691
aab2b9b5
PE
10692 * term.c (vfatal): Remove stray call to va_end.
10693 It's not needed and the C Standard doesn't allow it here anyway.
10694
c378da0b
PE
10695 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10696 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10697
288b08c7
PE
10698 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10699 bytes.
10700
e3601888
PE
10701 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10702
db6c0e74
PE
10703 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10704
dd5963ea
PE
10705 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10706
88c9450f
PE
10707 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10708
2f9442b8
PE
10709 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10710
c032b5f8
PE
10711 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10712 * charset.c (Fdefine_charset_internal): Don't initialize
10713 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10714 32-bit int (Bug#8600).
a108c10b
PE
10715
10716 * lread.c (read_integer): Be more consistent with string-to-number.
10717 Use string_to_number to do the actual conversion; this avoids
10718 rounding errors and fixes some other screwups. Without this fix,
10719 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10720 (digit_to_number): Move earlier, for benefit of read_integer.
10721 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10722 not a digit in any supported base. (Bug#8602)
a108c10b 10723
ad5f9eea
PE
10724 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10725
aec1708a
PE
10726 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10727 to match comment at start of function. This also removes a
10728 GCC warning about overflow in a 32+64-bit port.
10729
47be4ab5
PE
10730 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10731
371cac43
PE
10732 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10733 Reported by Stefan Monnier in
10734 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10735 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10736 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10737
d01a7826
PE
10738 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10739 (EMACS_UINTPTR): Likewise, with uintptr_t.
10740
7fd47d5c
PE
10741 * lisp.h: Prefer 64-bit EMACS_INT if available.
10742 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10743 on 32-bit hosts that have 64-bit int, so that they can access
10744 large files.
122b0c86
PE
10745 However, temporarily disable this change unless the temporary
10746 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10747
8727937b
PE
10748 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10749
8ac068ac
PE
10750 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10751 This removes an assumption that EMACS_INT and long are the same
10752 width as pointers. The assumption is true for Emacs porting targets
10753 now, but we want to make other targets possible.
10754 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10755 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10756 In the rest of the code, change types of integers that hold casted
10757 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10758 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10759 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10760 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10761 No need to cast type when ORing.
10762 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10763 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10764 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10765 assume EMACS_INT is the same width as char *.
10766 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10767 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10768 Remove no-longer-needed casts.
10769 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10770 (xg_tool_bar_help_callback, xg_make_tool_item):
10771 Use EMACS_INTPTR to hold an integer
10772 that will be cast to void *; this can avoid a GCC warning
10773 if EMACS_INT is not the same width as void *.
10774 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10775 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10776 (current_message_1, set_message_1):
10777 Use a local to convert to proper width without a cast.
10778 * xmenu.c (dialog_selection_callback): Likewise.
10779
ede49d71
PE
10780 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10781 Also, don't assume VALBITS / RAND_BITS is less than 5,
10782 and don't rely on undefined behavior when shifting a 1 left into
10783 the sign bit.
10784 * lisp.h (get_random): Change signature to match.
10785
2f30ecd0
PE
10786 * lread.c (hash_string): Use size_t, not int, for hash computation.
10787 Normally we prefer signed values; but hashing is special, because
10788 it's better to use unsigned division on hash table sizes so that
10789 the remainder is nonnegative. Also, size_t is the natural width
10790 for hashing into memory. The previous code used 'int', which doesn't
10791 retain enough info to hash well into very large tables.
10792 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10793
2a866e7b
PE
10794 * dbusbind.c: Don't possibly lose pointer info when converting.
10795 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10796 Use XPNTR rather than XHASH, so that the high-order bits of
10797 the pointer aren't lost when converting through void *.
10798
51639eac
PE
10799 * eval.c (Fautoload): Don't double-shift a pointer.
10800
92394119
PE
10801 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10802
dbdb9a7c
JB
108032011-05-06 Juanma Barranquero <lekktu@gmail.com>
10804
10805 * gnutls.c (DEF_GNUTLS_FN):
10806 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10807
db7a0b4f
AS
108082011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10809
10810 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10811 marker. (Bug#8610)
10812
cd394be1 108132011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10814
10815 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10816 New version that can reserve upto 2GB of heap space.
10817
f7ff1b0f 108182011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10819
10820 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10821
639c109b
TZ
108222011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10823
10824 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10825 `gnutls_certificate_set_x509_key_file'.
10826
d2127135
JB
108272011-05-05 Juanma Barranquero <lekktu@gmail.com>
10828
10829 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10830 Update dependencies.
10831
e968f4f3
JB
108322011-05-04 Juanma Barranquero <lekktu@gmail.com>
10833
10834 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10835 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10836 Remove unused parameter `fildes'.
10837 * process.c (read_process_output, send_process): Don't pass it.
10838
84d358f0
JB
108392011-05-04 Juanma Barranquero <lekktu@gmail.com>
10840
10841 Fix previous change: the library cache is defined in w32.c.
10842 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10843 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10844
0898ca10
JB
108452011-05-04 Juanma Barranquero <lekktu@gmail.com>
10846
10847 Implement dynamic loading of GnuTLS on Windows.
10848
10849 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10850 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10851 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10852 Declare.
10853
10854 * gnutls.c (Qgnutls_dll): Define.
10855 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10856 (gnutls_*): Declare function pointers.
10857 (init_gnutls_functions): New function to initialize function pointers.
10858 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10859 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10860 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10861 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10862 (emacs_gnutls_write, emacs_gnutls_read)
10863 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10864 (Fgnutls_available_p): New function.
10865 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10866 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10867 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10868
10869 * image.c: Include w32.h.
10870 (Vimage_type_cache): Delete.
10871 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10872 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10873 (w32_delayed_load): Move to w32.c.
10874
10875 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10876
10877 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10878 (w32_delayed_load): Move from image.c. When loading a library, record
10879 its filename in the :loaded-from property of the library id.
10880 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10881 Initialize and staticpro them.
10882 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10883
10884 * process.c: Include lisp.h before w32.h, not after.
10885 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10886 instead of gnutls_record_check_pending.
10887
10888 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10889
ff4de4aa
TZ
108902011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10891
10892 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10893 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10894 as passed in.
10895
abe95abb
JD
108962011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10897
10898 * xterm.c (x_set_frame_alpha): Do not set property on anything
10899 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10900
e16e55d4
JB
109012011-05-02 Juanma Barranquero <lekktu@gmail.com>
10902
10903 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10904
bafcf6a5
JB
109052011-05-02 Juanma Barranquero <lekktu@gmail.com>
10906
10907 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10908 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10909 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10910 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10911 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10912 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10913 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10914 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10915 (Qgnutls_bootprop_callbacks_verify): Make static.
10916
e7a6747f
AS
109172011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10918
19ed11ba
AS
10919 * callproc.c: Indentation fixup.
10920
e7a6747f 10921 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10922 (wait_for_termination, interruptible_wait_for_termination):
10923 Move after wait_for_termination_1.
e7a6747f 10924
1ef14cb4
LMI
109252011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10926
10927 * sysdep.c (interruptible_wait_for_termination): New function
10928 which is like wait_for_termination, but allows keyboard
10929 interruptions.
10930
10931 * callproc.c (Fcall_process): Add (:file "file") as an option for
10932 the STDOUT buffer.
10933 (Fcall_process_region): Ditto.
10934
330d880c
EZ
109352011-04-30 Eli Zaretskii <eliz@gnu.org>
10936
8db90b73
EZ
10937 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10938 rather than `XVECTOR (FOO)->size'.
10939
330d880c
EZ
10940 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10941 inttypes.h, as a gnulib replacement is used if it not available in
10942 system headers.
10943
15cbd324
EZ
109442011-04-21 Eli Zaretskii <eliz@gnu.org>
10945
10946 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10947 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10948 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10949
10950 * coding.c (coding_alloc_by_realloc): Error out if destination
10951 will grow beyond MOST_POSITIVE_FIXNUM.
10952 (decode_coding_emacs_mule): Abort if there isn't enough place in
10953 charbuf for the composition carryover bytes. Reserve an extra
10954 space for up to 2 characters produced in a loop.
10955 (decode_coding_iso_2022): Abort if there isn't enough place in
10956 charbuf for the composition carryover bytes.
10957
109582011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10959
ae940cca
EZ
10960 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10961 aborting when %lld or %lll format is passed.
10962 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10963 %llo or %llx format is passed. (Bug#8545)
10964
03ab8921
EZ
10965 * window.c (window_scroll_line_based): Use a marker instead of
10966 simple variables to record original value of point. (Bug#7952)
10967
afda1437
EZ
10968 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10969 produced by %s or %c overflows available buffer space. (Bug#8545)
10970
f76dee0c
PE
109712011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10972
10973 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10974 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10975
fdc5744d
JB
109762011-04-28 Juanma Barranquero <lekktu@gmail.com>
10977
10978 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10979
638f053a
JB
109802011-04-28 Juanma Barranquero <lekktu@gmail.com>
10981
10982 * keyboard.c (Qdelayed_warnings_hook): Define.
10983 (command_loop_1): Run `delayed-warnings-hook'
10984 if Vdelayed_warnings_list is non-nil.
10985 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10986 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10987
d178f871
EZ
109882011-04-28 Eli Zaretskii <eliz@gnu.org>
10989
10990 * doprnt.c (doprnt): Don't return value smaller than the buffer
10991 size if the message was truncated. (Bug#8545).
10992
b124fd93
JB
109932011-04-28 Juanma Barranquero <lekktu@gmail.com>
10994
10995 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10996 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10997
e810457d
PE
109982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10999
11000 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11001
ea51cceb
JB
110022011-04-27 Juanma Barranquero <lekktu@gmail.com>
11003
11004 * makefile.w32-in: Update dependencies.
11005
94dcfacf
EZ
110062011-04-27 Eli Zaretskii <eliz@gnu.org>
11007
11008 Improve `doprnt' and its usage. (Bug#8545)
11009 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11010 `format_end'. Remove support for %l as a conversion specifier.
11011 Don't use xrealloc. Improve diagnostics when the %l size modifier
11012 is used. Update the commentary.
11013
11014 * eval.c (verror): Simplify calculation of size_t.
11015
11016 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11017 messages.
11018
f61f41d7
PE
110192011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11020
11021 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11022 change.
11023
96fb4434
PE
110242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11025
11026 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11027 This makes this file independent of the recent pseudovector change.
11028
671875da 110292011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11030
69e9b5a3
PE
11031 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11032
b5f869a7 11033 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11034 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11035 Remove unused local.
c8926152 11036 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11037
841a1577 11038 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11039 GCC 4.6.0 optimizes based on type-based alias analysis.
11040 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11041 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11042 != &v->size, and therefore "v->size = 1; b->size = 2; return
11043 v->size;" must therefore return 1. This assumption is incorrect
11044 for Emacs, since it type-puns struct Lisp_Vector * with many other
11045 types. To fix this problem, this patch adds a new type struct
f904488f 11046 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11047 and pseudovectors, and helps optimizing compilers not get fooled
11048 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11049 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11050 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11051 the size member.
eab3844f
PE
11052 (XSETPVECTYPE): Rewrite in terms of new macro.
11053 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11054 This is a bit clearer, and further avoids the possibility of
11055 undesirable aliasing.
11056 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11057 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11058 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11059 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11060 (ASIZE): Now uses header.size rather than size.
11061 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11062 to avoid the hassle of writing XVECTOR (foo)->header.size.
11063 (struct vectorlike_header): New type.
eab3844f
PE
11064 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11065 object, to help avoid aliasing.
11066 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11067 (SUBRP): Likewise, since Lisp_Subr is a special case.
11068 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11069 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11070 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11071 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11072 changed to be "header.size" and "header.next".
11073 * buffer.h (struct buffer): Likewise.
11074 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11075 * frame.h (struct frame): Likewise.
11076 * process.h (struct Lisp_Process): Likewise.
11077 * termhooks.h (struct terminal): Likewise.
11078 * window.c (struct save_window_data, struct saved_window): Likewise.
11079 * window.h (struct window): Likewise.
11080 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11081 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11082 * buffer.c (init_buffer_once): Likewise.
11083 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11084 special case.
11085 * process.c (Fformat_network_address): Use local var for size,
11086 for brevity.
11087
0df1eac5
PE
11088 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11089
847ab9d1 11090 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11091 * data.c (atof): Remove decl; no longer used or needed.
11092 (digit_to_number): Move to lread.c.
11093 (Fstring_to_number): Use new string_to_number function, to be
11094 consistent with how the Lisp reader treats infinities and NaNs.
11095 Do not assume that floating-point numbers represent EMACS_INT
11096 without losing information; this is not true on most 64-bit hosts.
11097 Avoid double-rounding errors, by insisting on integers when
11098 parsing non-base-10 numbers, as the documentation specifies.
11099 * lisp.h (string_to_number): New decl, replacing ...
11100 (isfloat_string): Remove.
bc0a5c13 11101 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11102 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11103 appears to have been a coding error. Similarly, do not accept
11104 strings like +-1e0 as floating point numbers. Do not report
11105 overflow for integer overflows unless the base is not 10 which
11106 means we have no simple and reliable way to continue.
11107 Break out the floating-point parsing into a new
11108 function string_to_number, so that Fstring_to_number parses
11109 floating point numbers consistently with the Lisp reader.
04f2d78b 11110 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11111 (E_CHAR, EXP_INT): Remove, replacing with ...
11112 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11113 (string_to_number): New function, replacing isfloat_string.
11114 This function checks for valid syntax and produces the resulting
11115 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11116 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11117 so that overflow for non-base-10 numbers is reported only when
11118 there's no portable and simple way to convert to floating point.
452f4150 11119
67769ffc
PE
11120 * textprop.c (set_text_properties_1): Rewrite for clarity,
11121 and to avoid GCC warning about integer overflow.
11122
c20db43f
PE
11123 * intervals.h (struct interval): Use EMACS_INT for members
11124 where EMACS_UINT might cause problems. See
11125 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11126 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11127 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11128 All uses changed.
37aa2f85
PE
11129 (offset_intervals): Tell GCC not to worry about length overflow
11130 when negating a negative length.
c20db43f 11131
2538aa2f
PE
11132 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11133 (overrun_check_free): Likewise.
11134
f2d3008d
PE
11135 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11136 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11137 word size.
11138
ec8df744
PE
11139 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11140 (gnutls_make_error): Rename local to avoid shadowing.
11141 (gnutls_emacs_global_deinit): ifdef out; not used.
11142 (Fgnutls_boot): Use const for pointer to readonly storage.
11143 Comment out unused local. Fix pointer signedness problems.
11144
640ee02d
PE
11145 * lread.c (openp): Don't stuff size_t into an 'int'.
11146 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11147 about possible signed overflow.
11148
6048fb2a
PE
11149 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11150 (GDK_KEY_g): Don't define if already defined.
11151 (xg_prepare_tooltip): Avoid pointer signedness problem.
11152 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11153
fa3c87e1
PE
11154 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11155 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11156
2172544b
PE
11157 * xfns.c (Fx_window_property): Simplify a bit,
11158 to make a bit faster and to avoid GCC 4.6.0 warning.
11159 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11160
9b821a21
PE
11161 * fns.c (internal_equal): Don't assume size_t fits in int.
11162
3c616cfa
PE
11163 * alloc.c (compact_small_strings): Tighten assertion a little.
11164
c2982e87
PE
11165 Replace pEd with more-general pI, and fix some printf arg casts.
11166 * lisp.h (pI): New macro, generalizing old pEd macro to other
11167 conversion specifiers. For example, use "...%"pI"d..." rather
11168 than "...%"pEd"...".
11169 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11170 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11171 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11172 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11173 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11174 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11175 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11176 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11177 64-bit hosts.
11178 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11179 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11180 * print.c (safe_debug_print, print_object): Likewise.
11181 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11182 to int.
6f04d126
PE
11183 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11184 avoiding the 0 flag, which is not portable.
c2982e87
PE
11185 * process.c (Fmake_network_process): Use pI to avoid cast.
11186 * region-cache.c (pp_cache): Likewise.
11187 * xdisp.c (decode_mode_spec): Likewise.
11188 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11189 behavior on 64-bit hosts with printf arg.
6f04d126 11190 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11191 (x_stop_queuing_selection_requests): Likewise.
11192 (x_get_window_property): Don't truncate byte count to an 'int'
11193 when tracing.
0b432f21 11194
5e073ec7
PE
11195 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11196 here, since it parses constructs like leading '-' and spaces,
11197 which are not wanted; and it overflows with large numbers.
11198 Instead, simply match F[0-9]+, which is what is wanted anyway.
11199
36372bf9
PE
11200 * alloc.c: Remove unportable assumptions about struct layout.
11201 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11202 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11203 (allocate_vectorlike, make_pure_vector): Use the new macros,
11204 plus offsetof, to remove unportable assumptions about struct layout.
11205 These assumptions hold on all porting targets that I know of, but
11206 they are not guaranteed, they're easy to remove, and removing them
11207 makes further changes easier.
11208
0b432f21
PE
11209 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11210 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11211 (string_overrun_cookie): Now const. Use initializers that
11212 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11213 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11214 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11215 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11216 multiple of sizeof (EMACS_INT); it need not be, if
11217 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11218 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11219
895009e1
JB
112202011-04-26 Juanma Barranquero <lekktu@gmail.com>
11221
11222 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11223
6a7a1b0b
TZ
112242011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11225
11226 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11227 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11228 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11229
841a1577 112302011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11231
11232 * lisp.h (Qdebug): List symbol.
895009e1 11233 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11234 * keyboard.c (debug-on-event): New variable.
11235 (handle_user_signal): Break into debugger when debug-on-event
11236 matches the current signal symbol.
11237
f2d3ba6f
DN
112382011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11239
11240 * alloc.c (check_sblock, check_string_bytes)
11241 (check_string_free_list): Convert to standard C.
11242
42ce4c63
TZ
112432011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11244
11245 * w32.c (emacs_gnutls_push): Fix typo.
11246
825cd63c
EZ
112472011-04-25 Eli Zaretskii <eliz@gnu.org>
11248
fb11d64d
EZ
11249 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11250 "cast to pointer from integer of different size".
11251
825cd63c
EZ
11252 Improve doprnt and its use in verror. (Bug#8545)
11253 * doprnt.c (doprnt): Document the set of format control sequences
11254 supported by the function. Use SAFE_ALLOCA instead of always
11255 using `alloca'.
11256
11257 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11258 is one byte too soon. Don't use xrealloc; instead xfree and
11259 xmalloc anew.
11260
e061a11b
TZ
112612011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11262
11263 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11264 callbacks stage.
11265
11266 * gnutls.c: Renamed global_initialized to
11267 gnutls_global_initialized. Added internals for the
11268 :verify-hostname-error, :verify-error, and :verify-flags
11269 parameters of `gnutls-boot' and documented those parameters in the
11270 docstring. Start callback support.
9173deec
JB
11271 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11272 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11273 on error. Return error code.
e061a11b
TZ
11274 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11275 (emacs_gnutls_read): Likewise.
11276 (Fgnutls_boot): Return handshake error code.
11277 (emacs_gnutls_handle_error): New function.
11278 (wsaerror_to_errno): Likewise.
11279
11280 * w32.h (emacs_gnutls_pull): Add prototype.
11281 (emacs_gnutls_push): Likewise.
11282
11283 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11284 (emacs_gnutls_push): Likewise.
11285
112862011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11287
11288 * process.c (wait_reading_process_output): Check if GnuTLS
11289 buffered some data internally if no FDs are set for TLS
11290 connections.
11291
11292 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11293 (LIBS): Link to USER_LIBS.
11294 ($(BLD)/gnutls.$(0)): New target.
11295
fa6996bc
EZ
112962011-04-24 Eli Zaretskii <eliz@gnu.org>
11297
eb35682e
EZ
11298 * xdisp.c (handle_single_display_spec): Rename the
11299 display_replaced_before_p argument into display_replaced_p, to
11300 make it consistent with the commentary. Fix typos in the
11301 commentary.
11302
e2ad650c
EZ
11303 * textprop.c (syms_of_textprop): Remove dead code.
11304 (copy_text_properties): Delete obsolete commentary about an
11305 interface that was deleted long ago. Fix typos in the description
11306 of arguments.
11307
1b2de274
EZ
11308 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11309 to changes in oldXMenu/XMenu.h from 2011-04-16.
11310 <menu_help_message, prev_menu_help_message>: Constify.
11311 (IT_menu_make_room): menu->help_text is now `const char **';
11312 adjust.
11313
11314 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11315 to changes in oldXMenu/XMenu.h from 2011-04-16.
11316 (struct XMenu): Declare `help_text' `const char **'.
11317
11318 * xfaces.c <Qunspecified>: Make extern again.
11319
11320 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11321 required by POSIX.
1b2de274 11322
762b15be
EZ
11323 * doc.c (get_doc_string): Improve the format passed to `error'.
11324
11325 * doprnt.c (doprnt): Improve commentary.
11326
11327 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11328
11329 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11330 them with etags.
11331
f1052e5d
EZ
11332 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11333 changes in globals.h immediately force recompilation.
762b15be
EZ
11334 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11335 $(CURDIR)/s/ms-w32.h.
11336 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11337
fa6996bc
EZ
11338 * character.c (Fchar_direction): Function deleted.
11339 (syms_of_character): Don't defsubr it.
11340 <char-direction-table>: Deleted.
11341
e6c3da20
EZ
113422011-04-23 Eli Zaretskii <eliz@gnu.org>
11343
11344 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11345 * doprnt.c: Include limits.h.
11346 (SIZE_MAX): New macro.
04f2d78b
CB
11347 (doprnt): Return a size_t value. 2nd arg is now size_t.
11348 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11349 Improve overflow protection. Support `l' modifier for integer
11350 conversions. Support %l conversion. Don't assume an EMACS_INT
11351 argument for integer conversions and for %c.
11352
11353 * lisp.h (doprnt): Restore prototype.
11354
11355 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11356 $(SRC)/character.h.
11357
11358 * Makefile.in (base_obj): Add back doprnt.o.
11359
11360 * deps.mk (doprnt.o): Add back prerequisites.
11361 (callint.o): Depend on character.h.
11362
11363 * eval.c (internal_lisp_condition_case): Include the handler
11364 representation in the error message.
11365 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11366 when breaking from the loop.
11367
11368 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11369
11370 * callint.c (Fcall_interactively): When displaying error message
11371 about invalid control letter, pass the character's codepoint, not
11372 a pointer to its multibyte form. Improve display of the character
11373 in octal and display also its hex code.
11374
11375 * character.c (char_string): Use %x to display the (unsigned)
11376 codepoint of an invalid character, to avoid displaying a bogus
11377 negative value.
11378
11379 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11380 `error', not SYMBOL_NAME itself.
11381
11382 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11383 character arguments to `error'.
11384
11385 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11386 to `error' in error message about FINAL_CHAR argument. Make sure
11387 FINAL_CHAR is a character, and use %c when it is passed as
11388 argument to `error'.
11389
4ffd0d6b 113902011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11391
11392 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11393
11394 * w32.c: Include <time.h>.
11395 (sys_localtime): New function.
11396
4ffd0d6b 113972011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11398
11399 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11400
4ffd0d6b 11401 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11402
4ffd0d6b 114032011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11404
4ffd0d6b
GM
11405 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11406 zombies (Bug#8467).
aac0c6e3 11407
04c56954
EZ
114082011-04-19 Eli Zaretskii <eliz@gnu.org>
11409
11410 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11411 gl_state.e_property when gl_state.object is Qt.
11412
11413 * insdel.c (make_gap_larger): Remove limitation of buffer size
11414 to <= INT_MAX.
11415
16a43933
CY
114162011-04-18 Chong Yidong <cyd@stupidchicken.com>
11417
11418 * xdisp.c (lookup_glyphless_char_display)
11419 (produce_glyphless_glyph): Handle cons cell entry in
11420 glyphless-char-display.
11421 (Vglyphless_char_display): Document it.
11422
11423 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11424 glyphless-char-display.
11425
4581706e
CY
114262011-04-17 Chong Yidong <cyd@stupidchicken.com>
11427
11428 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11429
11430 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11431
11432 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11433 definition for no-X builds.
11434
4887c6e2 114352011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11436
fd35b6f9
PE
11437 Static checks with GCC 4.6.0 and non-default toolkits.
11438
5c1ccb01
PE
11439 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11440
006c5daa
PE
11441 * process.c (keyboard_bit_set): Define only if SIGIO.
11442 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11443 (send_process): Repair possible setjmp clobbering.
11444
efc736d3
PE
11445 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11446
4e2fe2e6
PE
11447 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11448
f97334a2
PE
11449 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11450
4e75f29d
PE
11451 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11452 Define only if needed.
11453
90efadd1
PE
11454 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11455 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11456 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11457
3c647824
PE
11458 * dispextern.h (struct redisplay_interface): Rename param
11459 to avoid shadowing.
e264f262 11460 * termhooks.h (struct terminal): Likewise.
761383f4 11461 * xterm.c (xembed_send_message): Likewise.
3c647824 11462
b58c5c4a
PE
11463 * insdel.c (make_gap_smaller): Define only if
11464 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11465
cad59032
PE
11466 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11467 it.
11468
c339dc2e
PE
11469 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11470 so that we aren't warned about unused symbols.
11471
91a3e27b
PE
11472 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11473
399c71d3 11474 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11475
8ffc96f5
PE
11476 * xfns.c (x_real_positions): Mark locals as initialized.
11477
eef9bc79
PE
11478 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11479
098db9dd
PE
11480 * xterm.c: Fix problems found by static analysis with other toolkits.
11481 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11482 (x_dispatch_event): Declare static if USE_GTK, and
11483 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11484 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11485 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11486 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11487 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11488
eb18f6cc
PE
11489 * xmenu.c (menu_help_callback): Pointer type fixes.
11490 Use const pointers when pointing at readonly data. Avoid pointer
11491 signedness clashes.
11492 (FALSE): Remove unused macro.
11493 (update_frame_menubar): Remove unused decl.
11494
1fe72bf8
PE
11495 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11496
60d9e1db
PE
11497 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11498 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11499 (single_menu_item): Rename local to avoid shadowing.
11500
39261c26
PE
11501 * keyboard.c (make_lispy_event): Remove unused local var.
11502
018c5e19
PE
11503 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11504 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11505
63d2b86e
PE
11506 * bitmaps: Change bitmaps from unsigned char back to the X11
11507 compatible char. Avoid the old compiler warnings about
11508 out-of-range initializers by using, for example, '\xab' rather
11509 than 0xab.
11510
aefd87e1
PE
11511 * xgselect.c (xgselect_initialize): Check vs interface
11512 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11513
bf501fb9
PE
11514 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11515
e9829fdf
PE
11516 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11517 to read-only memory.
11518
1086c095
PE
11519 * fns.c (vector): Remove; this old hack is no longer needed.
11520
2baccd04 11521 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11522 Remove unused var.
dde42981 11523 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11524
72391843 11525 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11526
436c16df 11527 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11528 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11529 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11530
92bb796d 11531 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11532 (x_term_init): Remove local to avoid shadowing.
92bb796d 11533
764430a3 11534 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11535
11536 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11537 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11538
d1dfb56c
EZ
115392011-04-16 Eli Zaretskii <eliz@gnu.org>
11540
c4354cb4
EZ
11541 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11542
d1dfb56c
EZ
11543 Fix regex.c, syntax.c and friends for buffers > 2GB.
11544 * syntax.h (struct gl_state_s): Declare character position members
11545 EMACS_INT.
11546
11547 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11548
04f2d78b
CB
11549 * textprop.c (verify_interval_modification, interval_of):
11550 Declare arguments EMACS_INT.
d1dfb56c
EZ
11551
11552 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11553 EMACS_INT.
11554
11555 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11556
11557 * indent.c (Fvertical_motion): Local variable it_start is now
11558 EMACS_INT.
11559
11560 * regex.c (re_match, re_match_2, re_match_2_internal)
11561 (bcmp_translate, regcomp, regexec, print_double_string)
11562 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11563 (re_compile_pattern, re_exec): Declare arguments and local
11564 variables `size_t' and `ssize_t' and return values `regoff_t', as
11565 appropriate.
11566 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11567 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11568 <compile_stack_type>: `size' and `avail' are now `size_t'.
11569
11570 * regex.h <regoff_t>: Use ssize_t, not int.
11571 (re_search, re_search_2, re_match, re_match_2): Arguments that
11572 specify buffer/string position and length are now ssize_t and
11573 size_t. Return type is regoff_t.
11574
613052cd
BK
115752011-04-16 Ben Key <bkey76@gmail.com>
11576
11577 * nsfont.m: Fixed bugs in ns_get_family and
11578 ns_descriptor_to_entity that were caused by using free to
11579 deallocate memory blocks that were allocated by xmalloc (via
11580 xstrdup). This caused Emacs to crash when compiled with
11581 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11582 --enable-checking=xmallocoverrun). xfree is now used to
11583 deallocate these memory blocks.
11584
4170f62f 115852011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11586
71b41406
PE
11587 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11588
9587a89d
PE
11589 emacs_write: Accept and return EMACS_INT for sizes.
11590 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11591 et seq.
11592 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11593 Accept and return EMACS_INT.
11594 (emacs_gnutls_write): Return the number of bytes written on
11595 partial writes.
11596 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11597 (emacs_read, emacs_write): Remove check for negative size, as the
11598 Emacs source code has been audited now.
9587a89d
PE
11599 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11600 (emacs_read, emacs_write): Use it.
273a5f82
PE
11601 * process.c (send_process): Adjust to the new signatures of
11602 emacs_write and emacs_gnutls_write. Do not attempt to store
11603 a byte offset into an 'int'; it might overflow.
9587a89d 11604 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11605
3e047f51
PE
11606 * sound.c: Don't assume sizes fit in 'int'.
11607 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11608 Return EMACS_INT, not int.
3e047f51 11609 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11610 Accept EMACS_INT, not int.
11611 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11612 record read return values.
11613
cc39a9db
BK
116142011-04-15 Ben Key <bkey76@gmail.com>
11615
c9d0ec6d
JB
11616 * keyboard.c (Qundefined): Don't declare static since it is used
11617 in nsfns.m.
11618 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11619 static since they are used in nsfont.m.
cc39a9db 11620
6c60eb9f
SM
116212011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11622
11623 * process.c (Qprocessp): Don't declare static.
11624 * lisp.h (Qprocessp): Declare again.
11625
7990b61a
JB
116262011-04-15 Juanma Barranquero <lekktu@gmail.com>
11627
11628 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11629
5d4cb038
PE
116302011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11631
8bd7b830 11632 Improve C-level modularity by making more things 'static'.
cd64ea1d 11633
e3b27b31
PE
11634 Don't publish debugger-only interfaces to other modules.
11635 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11636 (verify_bytepos, count_markers): Move decls to the only modules
11637 that need them.
11638 * region-cache.h (pp_cache): Likewise.
11639 * window.h (check_all_windows): Likewise.
11640 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11641
5d4cb038
PE
11642 * sysdep.c (croak): Now static, if
11643 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11644 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11645
11646 * alloc.c (refill_memory_reserve): Now static if
11647 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11648 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11649
e87b6180
PE
11650 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11651 Define only if USE_LUCID.
11652
ac64929e
PE
11653 * xrdb.c (x_customization_string, x_rm_string): Now static.
11654
6f37259d
PE
11655 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11656 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11657
1683e3ab
PE
11658 * xdisp.c (draw_row_with_mouse_face): Now static.
11659 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11660
de9c2632
PE
11661 * window.h (check_all_windows): Mark externally visible.
11662
2b96acb7
PE
11663 * window.c (window_deletion_count): Now static.
11664
11665 * undo.c: Make symbols static if they're not exported.
11666 (last_undo_buffer, last_boundary_position, pending_boundary):
11667 Now static.
11668
50436f33
PE
11669 * textprop.c (interval_insert_behind_hooks): Now static.
11670 (interval_insert_in_front_hooks): Likewise.
11671
64520e5c
PE
11672 * term.c: Make symbols static if they're not exported.
11673 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11674 (max_frame_lines, tty_set_terminal_modes):
11675 (tty_reset_terminal_modes, tty_turn_off_highlight):
11676 (get_tty_terminal): Now static.
11677 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11678 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11679 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11680 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11681 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11682
1fa53021
PE
11683 * sysdep.c: Make symbols static if they're not exported.
11684 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11685 Now static.
11686 (sigprocmask_set, full_mask): Remove; unused.
11687 (wait_debugging): Mark as visible.
11688 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11689 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11690
d4b43b22
PE
11691 * syntax.c (syntax_temp): Define only if !__GNUC__.
11692
b7c513d0
PE
11693 * sound.c (current_sound_device, current_sound): Now static.
11694
989b29ad
PE
11695 * search.c (searchbufs, searchbuf_head): Now static.
11696
13a55a78
PE
11697 * scroll.c (scroll_cost): Remove; unused.
11698 * dispextern.h (scroll_cost): Remove decl.
11699
de68a1fc
PE
11700 * region-cache.h (pp_cache): Mark as externally visible.
11701
40ccffa6
PE
11702 * process.c: Make symbols static if they're not exported.
11703 (process_tick, update_tick, create_process, chan_process):
11704 (Vprocess_alist, proc_buffered_char, datagram_access):
11705 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11706 (deactivate_process): Mark defn as static, as well as decl.
11707 * lisp.h (create_process): Remove decl.
11708 * process.h (chan_process, Vprocess_alist): Remove decls.
11709
ad64fc97
PE
11710 * print.c: Make symbols static if they're not exported.
11711 (print_depth, new_backquote_output, being_printed, print_buffer):
11712 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11713 (print_interval, print_number_index, initial_stderr_stream):
11714 Now static.
11715 * lisp.h (Fprinc): Remove decl.
11716 (debug_output_compilation_hack): Mark as externally visible.
11717
adddb265
PE
11718 * sysdep.c (croak): Move decl from here to syssignal.h.
11719 * syssignal.h (croak): Put it here, so the API can be checked when
11720 'croak' is called from dissociate_if_controlling_tty.
11721
1717ede2
PE
11722 * minibuf.c: Make symbols static if they're not exported.
11723 (minibuf_save_list, choose_minibuf_frame): Now static.
11724 * lisp.h (choose_minibuf_frame): Remove decl.
11725
fa5fb2bc
PE
11726 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11727
1e3890d1
PE
11728 * lread.c: Make symbols static if they're not exported.
11729 (read_objects, initial_obarray, oblookup_last_bucket_number):
11730 Now static.
11731 (make_symbol): Remove; unused.
11732 * lisp.h (initial_obarray, make_symbol): Remove decls.
11733
8a1414fa
PE
11734 * keyboard.c: Make symbols static if they're not exported.
11735 (single_kboard, recent_keys_index, total_keys, recent_keys):
11736 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11737 (this_single_command_key_start, echoing, last_auto_save):
11738 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11739 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11740 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11741 (Vlispy_mouse_stem, double_click_count):
11742 Now static.
11743 (force_auto_save_soon): Define only if SIGDANGER.
11744 (ignore_mouse_drag_p): Now static if
11745 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11746 (print_help): Remove; unused.
11747 (stop_character, last_timer_event): Mark as externally visible.
11748 * keyboard.h (ignore_mouse_drag_p): Declare only if
11749 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11750 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11751 * lisp.h (echoing): Remove decl.
11752 (force_auto_save_soon): Declare only if SIGDANGER.
11753 * xdisp.c (redisplay_window): Simplify code, to make it more
11754 obvious that ignore_mouse_drag_p is not accessed if !defined
11755 USE_GTK && !defined HAVE_NS.
11756
93ea6e8f
PE
11757 * intervals.c: Make symbols static if they're not exported.
11758 (merge_properties_sticky, merge_interval_right, delete_interval):
11759 Now static.
11760 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11761
77382fcc
PE
11762 * insdel.c: Make symbols static if they're not exported.
11763 However, leave prepare_to_modify_buffer alone. It's never
11764 called from outside this function, but that appears to be a bug.
11765 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11766 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11767 (adjust_after_replace_noundo): Remove; unused.
11768 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11769 (signal_before_change): Remove decls.
77382fcc 11770
9306c32e
PE
11771 * indent.c (val_compute_motion, val_vmotion): Now static.
11772
cd44d2eb
PE
11773 * image.c: Make symbols static if they're not exported.
11774 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11775 if USE_GTK.
11776 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11777 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11778
ad9a7a06
PE
11779 * fringe.c (standard_bitmaps): Now static.
11780 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11781
81626931
PE
11782 * frame.c: Make symbols static if they're not exported.
11783 (x_report_frame_params, make_terminal_frame): Now static.
11784 (get_frame_param): Now static, unless HAVE_NS.
11785 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11786 (x_get_resource_string): Remove; not used.
11787 * frame.h (make_terminal_frame, x_report_frame_params):
11788 (x_get_resource_string); Remove decls.
11789 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11790 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11791
239f9db9
PE
11792 * font.c, fontset.c: Make symbols static if they're not exported.
11793 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11794 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11795 * font.c (font_close_object): Now static.
11796 * font.h (font_close_object): Remove.
11797 * fontset.c (FONTSET_OBJLIST): Remove.
11798 (free_realized_fontset) #if-0 the body, which does nothing.
11799 (face_suitable_for_char_p): #if-0, as it's never called.
11800 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11801 * xfaces.c (face_at_string_position):
11802 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11803 since 0 is always ASCII.
11804
dfcf3579
PE
11805 * fns.c (weak_hash_tables): Now static.
11806
5045092b
PE
11807 * fileio.c: Make symbols static if they're not exported.
11808 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11809 (Vwrite_region_annotation_buffers): Now static.
11810
57a96f5c
PE
11811 * eval.c: Make symbols static if they're not exported.
11812 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11813 * lisp.h (backtrace_list): Remove decl.
11814
35f08c38
PE
11815 * emacs.c: Make symbols static if they're not exported.
11816 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11817 (fatal_error_code, fatal_error_signal_hook, standard_args):
11818 Now static.
11819 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11820 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11821 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11822 * lisp.h (fatal_error_signal_hook): Remove decl.
11823 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11824
f44bd759
PE
11825 * editfns.c: Move a (normally-unused) function to its only use.
11826 * editfns.c, lisp.h (get_operating_system_release): Remove.
11827 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11828 worth the hassle of breaking this out.
11829
b532497d
PE
11830 * xterm.c: Make symbols static if they're not exported.
11831 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11832 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11833 (x_destroy_window, x_delete_display):
11834 Now static.
11835 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11836 (x_mouse_leave): Remove; unused.
11837 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11838 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11839 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11840 Remove decls.
11841 (x_mouse_leave): Declare only if WINDOWSNT.
11842 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11843 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11844 USE_X_TOOLKIT.
11845
1675728f
PE
11846 * ftxfont.c: Make symbols static if they're not exported.
11847 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11848 HAVE_FREETYPE.
11849 * font.h (ftxfont_driver): Likewise.
11850
e4cebfca
PE
11851 * xfns.c: Make symbols static if they're not exported.
11852 (x_last_font_name, x_display_info_for_name):
11853 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11854 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11855 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11856 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11857 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11858 (last_show_tip_args): Now static.
11859 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11860 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11861 (x_screen_planes): Remove; unused.
11862 * dispextern.h (x_screen_planes): Remove decl.
11863
5bf46f05
PE
11864 * dispnew.c: Make symbols static if they're not exported.
11865 * dispextern.h (redraw_garbaged_frames, scrolling):
11866 (increment_row_positions): Remove.
11867 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11868 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11869 Now static.
11870 (redraw_garbaged_frames): Remove; unused.
11871
435f4c28
PE
11872 * xfaces.c: Make symbols static if they're not exported.
11873 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11874 Remove decls.
11875 * xterm.h (defined_color): Remove decls.
11876 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11877 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11878 (menu_face_changed_default, defined_color, free_realized_face):
11879 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11880 (ascii_face_of_lisp_face): Remove; unused.
11881
8524aef3
PE
11882 * xdisp.c: Make symbols static if they're not exported.
11883 * dispextern.h (scratch_glyph_row, window_box_edges):
11884 (glyph_to_pixel_coords, set_cursor_from_row):
11885 (get_next_display_element, set_iterator_to_next):
11886 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11887 (show_mouse_face): Remove decls
11888 * frame.h (message_buf_print): Likewise.
11889 * lisp.h (pop_message, set_message, check_point_in_composition):
11890 Likewise.
11891 * xterm.h (set_vertical_scroll_bar): Likewise.
11892 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11893 (message_buf_print, scratch_glyph_row, displayed_buffer):
11894 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11895 (get_next_display_element, show_mouse_face, window_box_edges):
11896 (frame_to_window_pixel_xy, check_point_in_composition):
11897 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11898 (glyph_to_pixel_coords): Remove; unused.
11899
16390cd2
PE
11900 * dired.c (file_name_completion): Now static.
11901
11902 * dbusbind.c (xd_in_read_queued_messages): Now static.
11903
a25f4dfa
PE
11904 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11905 * data.c (circular_list_error): Remove.
11906
14a9c8df
PE
11907 * commands.h (last_point_position, last_point_position_buffer):
11908 (last_point_position_window): Remove decls.
11909 * keyboard.c: Make these variables static.
11910
04f2d78b
CB
11911 * coding.h (coding, code_convert_region, encode_coding_gap):
11912 Remove decls.
74ab6df5
PE
11913 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11914 (iso_code_class, detect_coding, code_convert_region): Now static.
11915 (encode_coding_gap): Remove; unused.
11916
38dfbee1
PE
11917 * chartab.c (chartab_chars, chartab_bits): Now static.
11918
a2cb4e63
PE
11919 * charset.h (charset_iso_8859_1): Remove decl.
11920 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11921 Now static.
11922
127198fd
PE
11923 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11924 * ccl.c (Vccl_program_table): Now static.
11925 (check_ccl_update): Remove; unused.
11926
d85b608f
PE
11927 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11928 * category.h: ... from here.
11929 * category.c (check_category_table, set_category_set): Now static.
11930
31cd66f3
PE
11931 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11932 * lisp.h: Remove these decls.
11933
c358e587
PE
11934 * buffer.c (buffer_count): Remove unused var.
11935
e78aecca
PE
11936 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11937 so that it's not optimized away.
11938 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11939 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11940 exported only to the debugger.
11941
e192d7d3 11942 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11943 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11944
92470028
PE
11945 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11946 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11947 was inaccessible from Lisp.
11948 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11949 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11950
244ed907
PE
11951 alloc.c: Import and export fewer symbols, and remove unused items.
11952 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11953 is defined.
11954 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11955 it's not optimized away by whole-program optimization.
11956 (message_enable_multibyte, free_misc): Remove.
11957 (catchlist, handlerlist, mark_backtrace):
11958 Declare only if BYTE_MARK_STACK.
11959 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11960 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11961 (message_enable_multibyte): Remove decl.
11962 (free_misc, interval_free_list, float_block, float_block_index):
11963 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11964 (cons_free_list, last_marked_index):
11965 Now static.
11966 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11967 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11968 (mark_backtrace): Define only if BYTE_MARK_STACK.
11969 * xdisp.c (message_enable_multibyte): Now static.
11970
61c2b50e 11971 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11972 This makes it easier for human readers (and static analyzers)
11973 to see whether these variables are used from other modules.
11974 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11975 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11976 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11977 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11978 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11979 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11980 * xmenu.c, xselect.c:
11981 Declare Q* vars static if they are not used in other modules.
11982 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11983 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11984 Remove decls of unexported vars.
11985 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11986
95c82688
PE
11987 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11988
16a97296
PE
11989 Make Emacs functions such as Fatom 'static' by default.
11990 This makes it easier for human readers (and static analyzers)
11991 to see whether these functions can be called from other modules.
11992 DEFUN now defines a static function. To make the function external
11993 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11994 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11995 (Finit_image_library):
16a97296
PE
11996 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11997 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11998 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11999 Remove decls, since these functions are now static.
12000 (Funintern, Fget_internal_run_time): New decls, since these functions
12001 were already external.
95c82688 12002
16a97296
PE
12003 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12004 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12005 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12006 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12007 * keyboard.c, keymap.c, lread.c:
12008 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12009 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12010 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12011 Mark functions with DEFUE instead of DEFUN,
12012 if they are used in other modules.
12013 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12014 decls for now-static functions.
12015 * buffer.h (Fdelete_overlay): Remove decl.
12016 * callproc.c (Fgetenv_internal): Mark as internal.
12017 * composite.c (Fremove_list_of_text_properties): Remove decl.
12018 (Fcomposition_get_gstring): New forward static decl.
12019 * composite.h (Fcomposite_get_gstring): Remove decl.
12020 * dired.c (Ffile_attributes): New forward static decl.
12021 * doc.c (Fdocumntation_property): New forward static decl.
12022 * eval.c (Ffetch_bytecode): New forward static decl.
12023 (Funintern): Remove extern decl; now in .h file where it belongs.
12024 * fileio.c (Fmake_symbolic_link): New forward static decl.
12025 * image.c (Finit_image_library): New forward static decl.
12026 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12027 * intervals.h (Fprevious_property_change):
12028 (Fremove_list_of_text_properties): Remove decls.
12029 * keyboard.c (Fthis_command_keys): Remove decl.
12030 (Fcommand_execute): New forward static decl.
12031 * keymap.c (Flookup_key): New forward static decl.
12032 (Fcopy_keymap): Now static.
12033 * keymap.h (Flookup_key): Remove decl.
12034 * process.c (Fget_process): New forward static decl.
12035 (Fprocess_datagram_address): Mark as internal.
12036 * syntax.c (Fsyntax_table_p): New forward static decl.
12037 (skip_chars): Remove duplicate decl.
12038 * textprop.c (Fprevious_property_change): New forward static decl.
12039 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12040 Now internal.
12041 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12042 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12043
785bbd42
PE
12044 * editfns.c (Fformat): Remove unreachable code.
12045
8b913b57
AS
120462011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12047
12048 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12049 change. (Bug#8496)
12050
a6744a35
EZ
120512011-04-13 Eli Zaretskii <eliz@gnu.org>
12052
12053 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12054 when at ZV. (Bug#8487)
12055
e7974947
AS
120562011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12057
baad03f0
AS
12058 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12059 (Bug#8437)
12060 * keyboard.c (parse_tool_bar_item): Likewise.
12061 * sound.c (sound_cleanup, alsa_close): Likewise.
12062 * termcap.c (tgetent): Likewise.
12063 * xfns.c (x_default_font_parameter): Likewise.
12064 * xsettings.c (read_and_apply_settings): Likewise.
12065
e7974947
AS
12066 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12067 (overrun_check_free): Protoize.
12068
28272684
PE
120692011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12070
12071 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12072 since callers should never pass a negative size.
12073 Change the signature to match that of plain 'read' and 'write'; see
12074 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12075 * lisp.h: Update prototypes of emacs_write and emacs_read.
12076
11997c76
EZ
120772011-04-11 Eli Zaretskii <eliz@gnu.org>
12078
12079 * xdisp.c (redisplay_window): Don't try to determine the character
12080 position of the scroll margin if the window start point w->startp
e896f03c 12081 is outside the buffer's accessible region. (Bug#8468)
11997c76 12082
8a2cbd72
EZ
120832011-04-10 Eli Zaretskii <eliz@gnu.org>
12084
12085 Fix write-region and its subroutines for buffers > 2GB.
12086 * fileio.c (a_write, e_write): Modify declaration of arguments and
12087 local variables to support buffers larger than 2GB.
12088 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12089
12090 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12091 argument, local variables, and return value.
12092
12093 * lisp.h: Update prototypes of emacs_write and emacs_read.
12094
12095 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12096
4073e537 120972011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12098
1ebfdcb6
PE
12099 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12100
b2ded58d
PE
12101 Fix more problems found by GCC 4.6.0's static checks.
12102
7d66342c
PE
12103 * xdisp.c (vmessage): Use a better test for character truncation.
12104
bbf47d44
PE
12105 * charset.c (load_charset_map): <, not <=, for optimization,
12106 and to avoid potential problems with integer overflow.
9248994d 12107 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12108 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12109 * editfns.c (Fformat): Likewise.
1e69125e 12110 * syntax.c (skip_chars): Likewise.
3befa583 12111
e3019616
PE
12112 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12113 This also lets GCC 4.6.0 generate slightly better loop code.
12114
becfa255
PE
12115 * callint.c (Fcall_interactively): <, not <=, for optimization.
12116 (Fcall_interactively): Count the number of arguments produced,
12117 not the number of arguments given. This is simpler and lets GCC
12118 4.6.0 generate slightly better code.
12119
dae0cd48
PE
12120 * ftfont.c: Distingish more carefully between FcChar8 and char.
12121 The previous code passed unsigned char * to a functions like
12122 strlen and xstrcasecmp that expect char *, which does not
12123 conform to the C standard.
12124 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12125 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12126 char * when the C standard requires it.
12127
76032d70
PE
12128 * keyboard.c (read_char): Remove unused var.
12129
eb3f1cc8
PE
12130 * eval.c: Port to Windows vsnprintf (Bug#8435).
12131 Include <limits.h>.
12132 (SIZE_MAX): Define if the headers do not.
12133 (verror): Do not give up if vsnprintf returns a negative count.
12134 Instead, grow the buffer. This ports to Windows vsnprintf, which
12135 does not conform to C99. Problem reported by Eli Zaretskii.
12136 Also, simplify the allocation scheme, by avoiding the need for
12137 calling realloc, and removing the ALLOCATED variable.
12138
70476b54
PE
12139 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12140
12020a9e
PE
12141 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12142 But keep the doprint source code for now, as we might revamp it
12143 and use it again (Bug#8435).
ea6c7ae6
PE
12144 * lisp.h (doprnt): Remove.
12145 * Makefile.in (base_obj): Remove doprnt.o.
12146 * deps.mk (doprnt.o): Remove.
12147
5fdb398c
PE
12148 error: Print 32- and 64-bit integers portably (Bug#8435).
12149 Without this change, on typical 64-bit hosts error ("...%d...", N)
12150 was used to print both 32- and 64-bit integers N, which relied on
12151 undefined behavior.
61bdb816 12152 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12153 * lisp.h (error, verror): Mark as printf-like functions.
12154 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12155 Report overflow in size calculations when allocating printf buffer.
12156 Do not truncate output string at its first null byte.
12157 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12158 Truncate the output at a character boundary, since vsnprintf does not
12159 do that.
12160 * charset.c (check_iso_charset_parameter): Convert internal
12161 character to string before calling 'error', since %c now has the
12162 printf meaning.
12163 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12164 overflow when computing char to be passed to 'error'. Do not
12165 pass Lisp_Object to 'error'; pass the integer instead.
12166 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12167 formatted with plain %d.
12168
b189fa66
PE
12169 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12170
bff87ef0
PE
12171 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12172
7e2cac20
PE
12173 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12174
ce4d90b5
PE
12175 * xterm.c (x_catch_errors): Remove duplicate declaration.
12176
266c9547
PE
12177 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12178
79c49ad2
PE
12179 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12180
368f4090
JM
121812011-04-10 Jim Meyering <meyering@redhat.com>
12182
12183 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12184 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12185 return ssize_t not "int", and use size_t as the buffer length.
12186 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12187 * gnutls.h: Update declarations.
12188 * process.c (read_process_output): Use ssize_t, to match.
12189 (send_process): Likewise.
12190
a32d4040
CY
121912011-04-09 Chong Yidong <cyd@stupidchicken.com>
12192
12193 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12194
8546720e 121952011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12196
04f2d78b
CB
12197 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12198 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12199
8546720e
GM
12200 * xterm.c (handle_one_xevent):
12201 * xmenu.c (create_and_show_popup_menu):
12202 * xselect.c (x_decline_selection_request)
12203 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12204
0a2f5c1a 122052011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12206
12207 Fix some uses of `int' instead of EMACS_INT.
12208 * search.c (string_match_1, fast_string_match)
12209 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12210 (scan_buffer, find_next_newline_no_quit)
12211 (find_before_next_newline, search_command, Freplace_match)
12212 (Fmatch_data): Make some `int' variables be EMACS_INT.
12213
12214 * xdisp.c (display_count_lines): 3rd argument and return value now
12215 EMACS_INT. All callers changed.
12216 (pint2hrstr): Last argument is now EMACS_INT.
12217
12218 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12219 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12220 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12221 (decode_coding_utf_16, decode_coding_emacs_mule)
12222 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12223 (decode_coding_ccl, decode_coding_charset)
12224 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12225 (decode_coding_iso_2022, decode_coding_emacs_mule)
12226 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12227 <char_offset, last_offset>: Declare EMACS_INT.
12228 (encode_coding_utf_8, encode_coding_utf_16)
12229 (encode_coding_emacs_mule, encode_invocation_designation)
12230 (encode_designation_at_bol, encode_coding_iso_2022)
12231 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12232 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12233 Declare EMACS_INT.
12234 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12235 (encode_invocation_designation): Last argument P_NCHARS is now
12236 EMACS_INT.
12237 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12238 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12239
12240 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12241 All users changed.
12242
12243 * ccl.c (Fccl_execute_on_string): Declare some variables
12244 EMACS_INT.
12245
8546720e 122462011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12247
12248 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12249
4e19a977
CS
122502011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12251
12252 * process.c (Fformat_network_address): Doc fix.
12253
87302331
R
122542011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12255
ee7683eb 12256 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12257
cbb59342
CY
122582011-04-08 Chong Yidong <cyd@stupidchicken.com>
12259
12260 * keyboard.c (read_char): Call Lisp function help-form-show,
12261 instead of using internal_with_output_to_temp_buffer.
12262 (Qhelp_form_show): New var.
e0d38eeb 12263 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12264
12265 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12266
12267 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12268
e67a13ab
CY
122692011-04-06 Chong Yidong <cyd@stupidchicken.com>
12270
04f2d78b
CB
12271 * process.c (Flist_processes): Remove to Lisp.
12272 (list_processes_1): Delete.
e67a13ab 12273
973f782d
EZ
122742011-04-06 Eli Zaretskii <eliz@gnu.org>
12275
7c106b1e
EZ
12276 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12277
973f782d
EZ
12278 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12279
41cf7d1a 122802011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12281
ca23cc88
PE
12282 Fix more problems found by GCC 4.6.0's static checks.
12283
f390e2d5
PE
12284 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12285
42eea0d0
PE
12286 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12287
b69769da 12288 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12289
f9541e84
PE
12290 * xdisp.c (vmessage): Mark as a printf-like function.
12291
13841b55
PE
12292 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12293
c136c10f
PE
12294 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12295
5e2d4a30
PE
12296 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12297 printf-like functions.
12298 (tiff_load): Add casts to remove these marks before passing them
12299 to system-supplied API.
12300
583f48b9
PE
12301 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12302
b25d760e
PE
12303 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12304 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12305 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12306 directly, rather than having caller test rule sign. This avoids
12307 some unnecessary tests.
12308 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12309 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12310 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12311
bc7b6697 12312 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12313 (xfont_open): Avoid unnecessary tests.
bc7b6697 12314
27ccc379
PE
12315 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12316
dcd5c89a
PE
12317 * composite.h, composite.c (composition_gstring_put_cache):
12318 Use EMACS_INT, not int, for length.
12319
b13a45c6
PE
12320 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12321 breaking out part of COMPOSITION_DECODE_RULE.
12322 (COMPOSITION_DECODE_RULE): Use it.
12323 * composite.c (get_composition_id): Remove unused local vars,
12324 by using the new macro.
12325
1e792e4d
PE
12326 * textprop.c (set_text_properties_1): Change while to do-while,
12327 since the condition is always true at first.
12328
dc6c6455 12329 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12330 (interval_deletion_adjustment): Return unsigned value.
12331 All uses changed.
dc6c6455 12332
aba7731a
PE
12333 * process.c (list_processes_1, create_pty, read_process_output):
12334 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12335 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12336 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12337 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12338 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12339
fdfc4bf3
PE
12340 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12341
fca8fe46 12342 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12343 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12344
06a0259a 12345 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12346 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12347 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12348
e7b9e80f
PE
12349 * print.c (print_error_message): Avoid int overflow.
12350
56201685
PE
12351 * font.c (font_list_entities): Redo for clarity,
12352 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12353
78834453 12354 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12355 (font_score): Avoid potential overflow in diff calculation.
78834453 12356
0bc0b309 12357 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12358 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12359
e610eaca
PE
12360 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12361
b895abce
PE
12362 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12363 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12364 can always succeed if overflow has undefined behavior.
12365
1f1d9321 12366 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12367 (wordify): Omit three unnecessary tests.
1f1d9321 12368
c59478bc
PE
12369 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12370 All callers changed. This avoids the need for an unused var.
12371
79b73827
PE
12372 * casefiddle.c (casify_region): Remove var that is set but not used.
12373
a4db5dfe
PE
12374 * dired.c (file_name_completion): Remove var that is set but not used.
12375
43aae36e
PE
12376 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12377
2a47c44d 12378 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12379 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12380
a37c69bf
PE
12381 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12382 Check for integer overflow on size calculations.
12383
328ab8e7
PE
12384 * buffer.c (Fprevious_overlay_change): Remove var that is set
12385 but not used.
12386
e5a2a5cb
PE
12387 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12388 Remove vars that are set but not used.
8d84a6eb 12389 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12390 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12391
a60e5f68
PE
12392 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12393
f661cb61 12394 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12395 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12396
f0397f5a
PE
12397 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12398 that are set but not used.
12399
8664db06 12400 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12401 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12402
6abdaa4a
PE
12403 * xselect.c (x_get_local_selection, x_handle_property_notify):
12404 Remove vars that are set but not used.
12405
0ce7538d 12406 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12407 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12408
9ae848fc
PE
12409 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12410 Remove var that is set but not used.
0b918413
PE
12411 (scroll_bar_windows_size): Now size_t, not int.
12412 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12413 Check for overflow.
9ae848fc 12414
a5a62657
PE
12415 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12416 (map_tty_color) [!defined MSDOS]: Likewise.
12417
5c5cdd39
PE
12418 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12419
66ebf983
PE
12420 * coding.c: Remove vars that are set but not used.
12421 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12422 All callers changed.
12423 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12424 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12425 (decode_coding_charset): Remove vars that are set but not used.
12426
1be4d761
PE
12427 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12428 that is set but not used.
12429
47553fa8
PE
12430 * print.c (print_object): Remove var that is set but not used.
12431
1f7196bf 12432 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12433 The gnulib version avoids calling malloc in the usual case,
12434 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12435 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12436 * filelock.c (current_lock_owner): Likewise.
12437 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12438 * sysdep.c: Include allocator.h, careadlinkat.h.
12439 (emacs_no_realloc_allocator): New static constant.
12440 (emacs_readlink): New function.
fdb61804
PE
12441 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12442 ../lib/careadlinkat.h.
d1fdcab7 12443
f84c17c7
SM
124442011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12445
12446 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12447 first non-nil return value).
12448
ef3862ad
JD
124492011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12450
12451 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12452 if not defined (Bug#8403).
12453
376a7006
JB
124542011-04-02 Juanma Barranquero <lekktu@gmail.com>
12455
12456 * xdisp.c (display_count_lines): Remove parameter `start',
12457 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12458 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12459 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12460 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12461 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12462 and thereabouts. All callers changed.
12463 (get_per_char_metric): Remove parameter `f', unused since
12464 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12465
6ca3801d
JM
124662011-04-02 Jim Meyering <meyering@redhat.com>
12467
12468 do not dereference NULL upon failed strdup
12469 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12470 (ns_get_family): Likewise.
12471
d8e2b5ba
JB
124722011-04-02 Juanma Barranquero <lekktu@gmail.com>
12473
12474 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12475
8c74fcbd
JD
124762011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12477
12478 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12479 later (Bug#8403).
12480
7200d79c
SM
124812011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12482
03408648 12483 Add lexical binding.
7200d79c 12484
03408648
SM
12485 * window.c (Ftemp_output_buffer_show): New fun.
12486 (Fsave_window_excursion):
12487 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12488
12489 * lread.c (lisp_file_lexically_bound_p): New function.
12490 (Fload): Bind Qlexical_binding.
12491 (readevalloop): Remove `evalfun' arg.
12492 Bind Qinternal_interpreter_environment.
12493 (Feval_buffer): Bind Qlexical_binding.
12494 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12495 Mark as dynamic.
12496 (syms_of_lread): Declare `lexical-binding'.
12497
12498 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12499
12500 * keyboard.c (eval_dyn): New fun.
12501 (menu_item_eval_property): Use it.
ca105506
SM
12502
12503 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12504
03408648
SM
12505 * fns.c (concat, mapcar1): Accept byte-code-functions.
12506
12507 * eval.c (Fsetq): Handle lexical vars.
12508 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12509 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12510 (FletX, Flet): Obey lexical binding.
12511 (Fcommandp): Handle closures.
12512 (Feval): New `lexical' arg.
12513 (eval_sub): New function extracted from Feval. Use it almost
12514 everywhere where Feval was used. Look up vars in lexical env.
12515 Handle closures.
12516 (Ffunctionp): Move from subr.el.
12517 (Ffuncall): Handle closures.
12518 (apply_lambda): Remove `eval_flags'.
12519 (funcall_lambda): Handle closures and new byte-code-functions.
12520 (Fspecial_variable_p): New function.
12521 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12522 but without exporting it to Lisp.
23aba0ea 12523
23aba0ea 12524 * doc.c (Fdocumentation, store_function_docstring):
03408648 12525 * data.c (Finteractive_form): Handle closures.
23aba0ea 12526
03408648
SM
12527 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12528 interactive spec.
ba83908c 12529
04f2d78b
CB
12530 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12531 New byte-codes.
03408648
SM
12532 (exec_byte_code): New function extracted from Fbyte_code to handle new
12533 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12534
03408648 12535 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12536
03408648 12537 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12538
e2abce01
JB
125392011-03-31 Juanma Barranquero <lekktu@gmail.com>
12540
12541 * xdisp.c (redisplay_internal): Fix prototype.
12542
63696a73 125432011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12544
63696a73 12545 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12546 (try_scrolling): Use it when setting scroll_limit.
12547 Limit scrolling to 100 screen lines.
63696a73
EZ
12548 (redisplay_window): Even when falling back on "recentering",
12549 position point in the window according to scroll-conservatively,
12550 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12551
12552 (try_scrolling): When point is above the window, allow searching
12553 as far as scroll_max, or one screenful, to compute vertical
12554 distance from PT to the scroll margin position. This prevents
12555 try_scrolling from unnecessarily failing when
12556 scroll-conservatively is set to a value slightly larger than the
12557 window height. Clean up the case of PT below the margin at bottom
12558 of window: scroll_max can no longer be INT_MAX. When aggressive
12559 scrolling is in use, don't let point enter the opposite scroll
12560 margin as result of the scroll.
12561 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12562 threshold of 100 lines for never-recentering scrolling.
12563
e4cc2dfc
JB
125642011-03-31 Juanma Barranquero <lekktu@gmail.com>
12565
12566 * dispextern.h (move_it_by_lines):
12567 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12568 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12569 (message_log_check_duplicate): Remove parameters `prev_bol' and
12570 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12571 (redisplay_internal): Remove parameter `preserve_echo_area',
12572 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12573
12574 * indent.c (Fvertical_motion):
12575 * window.c (window_scroll_pixel_based, Frecenter):
12576 Don't pass `need_y_p' to `move_it_by_lines'.
12577
1c470562
SM
125782011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12579
44f230aa
SM
12580 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12581 steal a few bits to be more compact.
12582 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12583 Remove unneeded casts.
12584
1c470562
SM
12585 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12586
888adce9
ZK
125872011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12588
12589 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12590 binding" message (bug#7967).
12591
f838ed7b
PE
125922011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12593
77861b95
PE
12594 Fix more problems found by GCC 4.6.0's static checks.
12595
de6dbc14
PE
12596 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12597 Remove unused local var.
12598
f838ed7b
PE
12599 * editfns.c (Fmessage_box): Remove unused local var.
12600
792c7b2b
PE
12601 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12602 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12603 Omit unused local vars.
c499e557 12604 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12605 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12606 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12607 Omit unused local var.
12608
ba0165e1
PE
12609 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12610 Don't assume string length fits in int.
32ad8845 12611 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12612 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12613
3c59b4c9
PE
12614 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12615 instead of alloca (Bug#8344).
12616
a3eed478 12617 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12618 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12619
eb4d412d
PE
12620 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12621
1658b401
PE
12622 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12623 concerns.
12624
12625 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12626
12627 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12628
9a2c6e05
PE
12629 * keyboard.c (syms_of_keyboard): Use the same style as later
12630 in this function when indexing through an array. This also
12631 works around GCC bug 48267.
12632
03d0a109
PE
12633 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12634
44f730c8
PE
12635 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12636
fe75f926
PE
12637 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12638 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12639
ffa8c828
PE
12640 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12641 This avoids undefined behavior on integer overflow, and is a bit
12642 more convenient anyway since it is compared to a size_t variable.
12643
c5101a77
PE
12644 Variadic C functions now count arguments with size_t, not int.
12645 This avoids an unnecessary limitation on 64-bit machines, which
12646 caused (substring ...) to crash on large vectors (Bug#8344).
12647 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12648 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12649 All variadic functions and their callers changed accordingly.
c5101a77
PE
12650 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12651 * data.c (arith_driver, float_arith_driver): Likewise.
12652 * editfns.c (general_insert_function): Likewise.
12653 * eval.c (struct backtrace.nargs, interactive_p)
12654 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12655 (funcall_lambda, mark_backtrace): Likewise.
12656 * fns.c (concat): Likewise.
12657 * frame.c (x_set_frame_parameters): Likewise.
12658 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12659 0 if not found, not -1. All callers changed.
12660
dd3f25f7
PE
12661 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12662 (stack_copy_size): Now size_t, not int.
12663 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12664
461c2ab9
JB
126652011-03-28 Juanma Barranquero <lekktu@gmail.com>
12666
12667 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12668 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12669 All callers changed.
12670
12671 * lisp.h (multibyte_char_to_unibyte):
12672 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12673 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12674 * character.h (CHAR_TO_BYTE8):
12675 * cmds.c (internal_self_insert):
12676 * editfns.c (general_insert_function):
12677 * keymap.c (push_key_description):
12678 * search.c (Freplace_match):
12679 * xdisp.c (message_dolog, set_message_1): All callers changed.
12680
f6d62986
SM
126812011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12682
12683 * keyboard.c (safe_run_hook_funcall): New function.
12684 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12685 don't set the hook to nil, but remove the offending function instead.
12686 (Qcommand_hook_internal): Remove, unused.
12687 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12688 Vcommand_hook_internal.
12689
12690 * eval.c (enum run_hooks_condition): Remove.
12691 (funcall_nil, funcall_not): New functions.
12692 (run_hook_with_args): Call each function through a `funcall' argument.
12693 Remove `cond' argument, now redundant.
12694 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12695 (Frun_hook_with_args_until_failure): Adjust accordingly.
12696 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12697
1db5b1ad
JB
126982011-03-28 Juanma Barranquero <lekktu@gmail.com>
12699
12700 * dispextern.h (string_buffer_position): Remove declaration.
12701
12702 * print.c (strout): Remove parameter `multibyte', unused since
12703 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12704
12705 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12706 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12707 All callers changed.
12708
12709 * w32.c (_wsa_errlist): Use braces for struct initializers.
12710
12711 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12712 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12713 All callers changed.
12714 (string_buffer_position): Likewise. Also, make static (it's never
12715 used outside xdisp.c).
12716 (cursor_row_p): Remove parameter `w', unused since
12717 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12718 (decode_mode_spec): Remove parameter `precision', introduced during
12719 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12720 All callers changed.
12721
5ffb62aa
JD
127222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12723
12724 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12725
461c2ab9 127262011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12727
12728 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12729 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12730 (ns_update_auto_hide_menu_bar): New functions.
12731 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12732 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12733 ns_constrain_all_frames.
12734 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12735 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12736
5c380ffb
JD
127372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12738
12739 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12740
9af30bdf
GM
127412011-03-27 Glenn Morris <rgm@gnu.org>
12742
12743 * syssignal.h: Replace RETSIGTYPE with void.
12744 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12745 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12746 Replace SIGTYPE with void everywhere.
12747 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12748 * s/template.h (SIGTYPE): Remove commented out definition.
12749
e2abce01
JB
127502011-03-26 Eli Zaretskii <eliz@gnu.org>
12751
12752 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12753 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12754
f868cd8a
JB
127552011-03-26 Juanma Barranquero <lekktu@gmail.com>
12756
59eb0929
JB
12757 * w32.c (read_unc_volume): Use parameter `henum', instead of
12758 global variable `wget_enum_handle'.
12759
12760 * keymap.c (describe_vector): Remove parameters `indices' and
12761 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12762 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12763
f868cd8a
JB
12764 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12765
12766 * keyboard.c (timer_check): Remove parameter `do_it_now',
12767 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12768 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12769 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12770
12771 * keyboard.c (read_char):
12772 * w32menu.c (w32_menu_display_help):
12773 * xmenu.c (show_help_event, menu_help_callback):
12774 Adjust calls to `show_help_echo'.
12775
12776 * gtkutil.c (xg_maybe_add_timer):
12777 * keyboard.c (readable_events):
12778 * process.c (wait_reading_process_output):
12779 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12780
12781 * insdel.c (adjust_markers_gap_motion):
12782 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12783 (gap_left, gap_right): Don't call it.
12784
2ecf6fdb
CY
127852011-03-25 Chong Yidong <cyd@stupidchicken.com>
12786
12787 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12788 incurred during fontification.
12789
6b1f9ba4
JB
127902011-03-25 Juanma Barranquero <lekktu@gmail.com>
12791
12792 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12793 (DEFVAR_PER_BUFFER): Don't pass it.
12794
12795 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12796 (scrolling_window): Don't pass it.
12797
0f4a96b5
JB
127982011-03-25 Juanma Barranquero <lekktu@gmail.com>
12799
12800 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12801
12802 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12803 and `suffix'.
12804 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12805 of variables specific to SELinux and computation of `encoded_absname'.
12806
12807 * image.c (XPutPixel): Remove unused variable `height'.
12808
12809 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12810
12811 * unexw32.c (get_section_info): Remove unused variable `section'.
12812
12813 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12814 (system_process_attributes): Remove unused variable `sess'.
12815 (sys_read): Remove unused variable `err'.
12816
12817 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12818 (w32_wnd_proc): Remove unused variable `isdead'.
12819 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12820 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12821 (x_create_tip_frame): Remove unused variable `tem'.
12822
12823 * w32inevt.c (w32_console_read_socket):
12824 Remove unused variable `no_events'.
12825
12826 * w32term.c (x_draw_composite_glyph_string_foreground):
12827 Remove unused variable `width'.
12828
1149507c
JB
128292011-03-24 Juanma Barranquero <lekktu@gmail.com>
12830
12831 * w32term.c (x_set_glyph_string_clipping):
12832 Don't pass uninitialized region to CombineRgn.
12833
9c88f339
JB
128342011-03-23 Juanma Barranquero <lekktu@gmail.com>
12835
12836 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12837 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12838 (Fx_close_connection): Remove unused variable `i'.
12839
12840 * w32font.c (w32font_draw): Return number of glyphs.
12841 (w32font_open_internal): Remove unused variable `i'.
12842 (w32font_driver): Add missing initializer.
12843
12844 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12845 (fill_in_menu): Remove unused variable `items_added'.
12846
12847 * w32term.c (last_mouse_press_frame): Remove static global variable.
12848 (w32_clip_to_row): Remove unused variable `f'.
12849 (x_delete_terminal): Remove unused variable `i'.
12850
12851 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12852 (NOTHING): Remove unused static global variable.
12853 (uniscribe_check_otf): Remove unused variable `table'.
12854 (uniscribe_font_driver): Add missing initializers.
12855
dee091a3
JD
128562011-03-23 Julien Danjou <julien@danjou.info>
12857
12858 * term.c (Fsuspend_tty, Fresume_tty):
12859 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12860 * window.c (temp_output_buffer_show):
12861 * insdel.c (signal_before_change):
12862 * frame.c (Fhandle_switch_frame):
12863 * fileio.c (Fdo_auto_save):
12864 * emacs.c (Fkill_emacs):
12865 * editfns.c (save_excursion_restore):
12866 * cmds.c (internal_self_insert):
12867 * callint.c (Fcall_interactively):
12868 * buffer.c (Fkill_all_local_variables):
12869 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12870 Use Frun_hooks.
0f4a96b5 12871 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12872 unconditionally since it does the check itself.
dee091a3 12873
2c520ab5 128742011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12875
c9c49752
PE
12876 Fix more problems found by GCC 4.5.2's static checks.
12877
8abc3f12
PE
12878 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12879 the first time through the loop, since we know p0 < p1 then.
12880 This also avoids a gcc -Wstrict-overflow warning.
12881
a2d26660
PE
12882 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12883 leading to a memory leak, possible in functions like
12884 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12885 of objects (Bug#8318).
a2d26660 12886
916c72e9
PE
12887 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12888 that could (at least in theory) be that large.
12889
19ab8a18
PE
12890 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12891 This is less likely to overflow, and avoids undefined behavior if
12892 overflow does occur. All callers changed. Use strtoul to scan
12893 for the unsigned long integer.
b7cbbd6f
PE
12894 (pint2hrstr): Simplify and tune code slightly.
12895 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12896
f0641eff
PE
12897 * scroll.c (do_scrolling): Work around GCC bug 48228.
12898 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12899
7f650bb9
PE
12900 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12901 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12902 (validate_x_resource_name): Simplify count usage.
12903 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12904
37dd57d1
PE
12905 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12906 fail (Bug#8306).
81e56e61 12907
699979fc 12908 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12909
401bf9b4
PE
12910 * process.c (Fmake_network_process): Use socklen_t, not int,
12911 where POSIX says socklen_t is required in portable programs.
12912 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12913 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12914 (Fmake_network_process, server_accept_connection):
12915 (wait_reading_process_output, read_process_output):
12916 Likewise.
12917
b93aacde
PE
12918 * process.c: Rename or move locals to avoid shadowing.
12919 (list_processes_1, Fmake_network_process):
12920 (read_process_output_error_handler, exec_sentinel_error_handler):
12921 Rename or move locals.
4dc343ee 12922 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12923 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12924 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12925 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12926 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12927
af8a867c 12928 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12929 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12930 Include tparam.h instead, since it declares them.
af8a867c
PE
12931 * cm.h (PC): Remove extern decl; tparam.h now does this.
12932 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12933 * terminfo.c: Include tparam.h, to check interfaces.
12934 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12935 (tparam): Adjust signature to match interface in tparam.h;
12936 this removes some undefined behavior. Check that outstring and len
12937 are zero, which they always are with Emacs.
12938 * tparam.h (PC, BC, UP): New extern decls.
12939
0248044d 12940 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12941 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12942
8ff096c1 12943 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12944 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12945 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12946 (ftfont_list): Remove unused local.
49eaafba
PE
12947 (get_adstyle_property, ftfont_pattern_entity):
12948 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12949 Rename locals to avoid shadowing.
8ff096c1 12950
e2be39f6
PE
12951 * xfont.c (xfont_list_family): Mark var as initialized.
12952
c9735e30
PE
12953 * xml.c (make_dom): Now static.
12954
8f5201ae
PE
12955 * composite.c (composition_compute_stop_pos): Rename local to
12956 avoid shadowing.
b246f932
PE
12957 (composition_reseat_it): Remove unused locals.
12958 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12959 (composition_update_it): Mark var as initialized.
11b61122
PE
12960 (find_automatic_composition): Mark vars as initialized,
12961 with a FIXME (Bug#8290).
8f5201ae 12962
760fbc2c
PE
12963 character.h: Rename locals to avoid shadowing.
12964 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12965 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12966 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12967 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12968 to avoid shadowing.
12969
ff08eb85
PE
12970 * textprop.c (property_change_between_p): Remove; unused.
12971
fc7bf025
PE
12972 * intervals.c (interval_start_pos): Now static.
12973
235d7abc
PE
12974 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12975
44f230aa
SM
12976 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12977 Rename locals to avoid shadowing.
3e7d6594 12978
50060332
PE
12979 * sound.c (wav_play, au_play, Fplay_sound_internal):
12980 Fix pointer signedness.
d01f234b 12981 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12982 (wav_play): Initialize a variable to 0, to prevent undefined
12983 behavior (Bug#8278).
50060332 12984
c4fc4e30
PE
12985 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12986
918436ed
PE
12987 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12988
c939f91b
PE
12989 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12990 clobbering (Bug#8298).
b9c7f648
PE
12991 * sysdep.c (sys_subshell): Likewise.
12992 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12993
6bd8c144
PE
12994 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12995 This should get cleaned up, so that child_setup has the
12996 same signature on all platforms.
12997
7710357c 12998 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12999 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13000
c59da222
CY
130012011-03-22 Chong Yidong <cyd@stupidchicken.com>
13002
13003 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13004 not to be necessary, and produces flickering.
13005
66b87493
GM
130062011-03-20 Glenn Morris <rgm@gnu.org>
13007
13008 * config.in: Remove file.
13009
45b6f6d5
JB
130102011-03-20 Juanma Barranquero <lekktu@gmail.com>
13011
13012 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13013 are now in src/globals.h.
13014 (syms_of_minibuf): Remove spurious & from previous change.
13015
cd394be1 130162011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13017
13018 * minibuf.c (completing-read-function): New variable.
13019 (completing-read-default): Rename from completing-read.
13020 (completing-read): Call completing-read-function.
13021
b14e3e21
CY
130222011-03-19 Juanma Barranquero <lekktu@gmail.com>
13023
13024 * xfaces.c (Fx_load_color_file):
13025 Read color file from absolute filename (bug#8250).
13026
f2b726e6
JB
130272011-03-19 Juanma Barranquero <lekktu@gmail.com>
13028
13029 * makefile.w32-in: Update dependencies.
13030
09f6ff02
EZ
130312011-03-17 Eli Zaretskii <eliz@gnu.org>
13032
13033 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13034
29a6015a
PE
130352011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13036
a3a6c54e
PE
13037 Fix more problems found by GCC 4.5.2's static checks.
13038
b766f867
PE
13039 * process.c (make_serial_process_unwind, send_process_trap):
13040 (sigchld_handler): Now static.
13041
be02381c
PE
13042 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13043 That way, the code declares only the vars that it needs.
13044 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13045 * s/cygwin.h (PTY_ITERATION): Likewise.
13046 * s/darwin.h (PTY_ITERATION): Likewise.
13047 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13048
57048744
PE
13049 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13050 * process.c (allocate_pty): Don't declare stb unless it's needed.
13051
7914961c 13052 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13053 (CONSTANTLIM): Remove; unused.
13054 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13055 Define only if needed.
7914961c 13056
b3967b18
PE
13057 * unexelf.c (unexec): Name an expression,
13058 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13059 Use a different way to cause a compilation error if anyone uses
13060 n rather than nn, a way that does not involve shadowing.
73366a00 13061 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13062
29a6015a
PE
13063 * deps.mk (unexalpha.o): Remove; unused.
13064
43cfc33e 13065 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13066 * unexec.h: New file.
ce701a33
PE
13067 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13068 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13069 Depend on unexec.h.
13070 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13071 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13072 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13073 Change as necessary to match prototype in unexec.h.
ce701a33 13074
01f44d5a
PE
13075 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13076 shadowing.
4f63c6bb 13077 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13078
a6670b0b
PE
13079 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13080 Rename locals to avoid shadowing.
13081
cef2010d 13082 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13083 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13084
d4d7173a
PE
13085 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13086
f08b802a
PE
13087 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13088 warning when compiling print.c.
13089
3ddb0639
PE
13090 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13091 instead of using an uninitialized var.
5ad03b97 13092 (font_sort_entities): Mark var as initialized.
3ddb0639 13093
170a2692
PE
13094 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13095
e663c700
PE
13096 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13097 pointers to constants.
89bc529a 13098 (font_parse_fcname): Remove unused vars.
7b81e2d0 13099 (font_delete_unmatched): Now static.
ea838e10 13100 (font_get_spec): Remove; unused.
13a547c6
PE
13101 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13102 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13103 Rename or move locals to avoid shadowing.
e663c700 13104
2a80c887 13105 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13106 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13107
1384fa33 13108 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13109 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13110
8b2c52e9
PE
13111 * alloc.c (mark_backtrace): Move decl from here ...
13112 * lisp.h: ... to here, so that it can be checked.
13113
475545b5 13114 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13115 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13116 (lisp_indirect_variable): Name an expression,
13117 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13118 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13119
b1349114 13120 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13121 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13122 Use const pointer when appropriate.
b1349114 13123
a2928364
PE
13124 * lisp.h (get_system_name, get_operating_system_release):
13125 Move decls here, to check interfaces.
13126 * process.c (get_operating_system_release): Move decl to lisp.h.
13127 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13128 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13129 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13130 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13131 (Fformat_time_string, Fencode_time, Finsert_char):
13132 (Ftranslate_region_internal, Fformat):
13133 Rename or remove local vars to avoid shadowing.
9710023e 13134 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13135
a415e694
PE
13136 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13137 avoid shadowing.
13138
8ef4622d
PE
13139 * lisp.h (eassert): Check that the argument compiles, even if
13140 ENABLE_CHECKING is not defined.
13141
946f9a5b
PE
13142 * data.c (Findirect_variable): Name an expression, to avoid
13143 gcc -Wbad-function-cast warning.
112396d6 13144 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13145 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13146 (Fmake_variable_buffer_local, Fmake_local_variable):
13147 Mark variables as initialized.
52746918 13148 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13149
e5aab7e7 13150 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13151 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13152 Rename locals to avoid shadowing.
dff45157
PE
13153 (mark_stack): Move local variables into the #ifdef region where
13154 they're used.
7bc26fdb
PE
13155 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13156 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13157 needed otherwise.
13158 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13159 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13160 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13161
e5aab7e7
PE
13162 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13163 avoids undefined behavior in theory.
13164
4da60324
PE
13165 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13166
88043301
PE
13167 Use functions, not macros, for up- and down-casing (Bug#8254).
13168 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13169 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13170 to use the following functions instead of these macros.
13171 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13172 EMACS_INT, since callers assume the returned value fits in int.
13173 (upcase1): Likewise, for UPCASE_TABLE.
13174 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13175 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13176 the race-condition problem in the old DOWNCASE.
88043301 13177
19ed5445
PE
13178 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13179 Rename locals to avoid shadowing.
13180 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13181 (regex_compile, re_search_2, re_match_2_internal):
13182 Remove unused local vars.
952db0d7
PE
13183 (FREE_VAR): Rewrite so as not to use empty "else",
13184 which gcc can warn about.
da053e48 13185 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13186 (RETALLOC_IF): Define only if needed.
13187 (WORDCHAR_P): Likewise. This one is never needed, but is used
13188 only in a comment talking about a compiler bug, so put inside
13189 the #if 0 of that comment.
13190 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13191 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13192 Remove; unused.
19ed5445 13193
1f3561e4 13194 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13195 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13196 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13197
ded6f8f7
PE
13198 * search.c (simple_search): Remove unused var.
13199
dbd37a95
PE
13200 * dired.c (compile_pattern): Move decl from here ...
13201 * lisp.h: ... to here, so that it can be checked.
13202 (struct re_registers): New forward decl.
13203
7e47afad
PE
13204 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13205
85f24f61
PE
13206 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13207 All uses changed.
13208 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13209 Rename locals to avoid shadowing.
5671df8f 13210 (Fvertical_motion): Mark locals as initialized.
85f24f61 13211
181aa2be 13212 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13213 (casify_region): Mark local as initialized.
181aa2be 13214
930d429c
PE
13215 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13216
7082eac6
PE
13217 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13218 New macros, so that the caller can use some names other than
13219 gcpro1, gcpro2, etc.
13220 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13221 of the new macros.
13222 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13223 argument, for consistency with GCPRO2_VAR, etc: it is now the
13224 prefix of the variable, not the variable itself. All uses
13225 changed.
38b2c076
PE
13226 * dired.c (directory_files_internal, file_name_completion):
13227 Rename locals to avoid shadowing.
13228
15206ed9
PE
13229 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13230 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13231 dired.c's scmp function, had undefined behavior.
13232 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13233 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13234 * buffer.h: ... to here, because these macros use current_buffer,
13235 and the new implementation with inline functions needs to have
13236 current_buffer in scope now, rather than later when the macros
13237 are used.
13238 (downcase, upcase1): New static inline functions.
13239 (DOWNCASE, UPCASE1): Reimplement using these functions.
13240 This avoids undefined behavior in expressions like
13241 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13242 from race conditions in accessing the global variables
13243 case_temp1 and case_temp2.
13244 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13245 * lisp.h (case_temp1, case_temp2): Remove their decls.
13246 * character.h (ASCII_CHAR_P): Move from here ...
13247 * lisp.h: ... to here, so that the inline functions mentioned
13248 above can use them.
13249
4a6bea26
PE
13250 * dired.c (directory_files_internal_unwind): Now static.
13251
f14b7e14
PE
13252 * fileio.c (file_name_as_directory, directory_file_name):
13253 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13254 Now static.
2893f146
PE
13255 (file_name_as_directory): Use const pointers when appropriate.
13256 (Fexpand_file_name): Likewise. In particular, newdir might
13257 point at constant storage, so make it a const pointer.
fd4ead52 13258 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13259 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13260 signedness issues.
f839df0c
PE
13261 (Fset_file_times, Finsert_file_contents, auto_save_error):
13262 Rename locals to avoid shadowing.
f14b7e14 13263
5716756e 13264 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13265 (Ftry_completion, Fall_completions): Rename or remove locals
13266 to avoid shadowing.
5716756e 13267
b4c3046a
PE
13268 * marker.c (bytepos_to_charpos): Remove; unused.
13269
b45db522
PE
13270 * lisp.h (verify_bytepos, count_markers): New decls,
13271 so that gcc does not warn that these functions aren't declared.
13272
85876d07
PE
13273 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13274 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13275 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13276 (copy_text): Remove unused local var.
85876d07 13277
03d78a21 13278 * filelock.c (within_one_second): Now static.
b3dd38ab 13279 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13280
5df8f01b
PE
13281 * buffer.c (fix_overlays_before): Mark locals as initialized.
13282 (fix_start_end_in_overlays): Likewise. This function should be
13283 simplified by using pointers-to-pointers, but that's a different
13284 matter.
b1d876f1 13285 (switch_to_buffer_1): Now static.
8f54f30a
PE
13286 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13287 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13288
a70072c9 13289 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13290 Fix pointer signedness issue.
edced198
PE
13291 (sys_subshell): Mark local as volatile if checking for lint,
13292 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13293 (MAXPATHLEN): Define only if needed.
a70072c9 13294
a0977c44
PE
13295 * process.c (serial_open, serial_configure): Move decls from here ...
13296 * systty.h: ... to here, so that they can be checked.
13297
a884fdcc
PE
13298 * fns.c (get_random, seed_random): Move extern decls from here ...
13299 * lisp.h: ... to here, so that they can be checked.
13300
604efe86 13301 * sysdep.c (reset_io): Now static.
b8950c94 13302 (wait_for_termination_signal): Remove; unused.
604efe86 13303
38fc62d9
PE
13304 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13305 (copy_keymap_item, append_key, push_text_char_description):
13306 Now static.
1004a21a 13307 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13308 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13309 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13310 (describe_map_tree):
13311 Rename locals to avoid shadowing.
38fc62d9 13312
2f2650da
PE
13313 * keyboard.c: Declare functions static if they are not used elsewhere.
13314 (echo_char, echo_dash, cmd_error, top_level_2):
13315 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13316 (read_char, kbd_buffer_get_event, make_lispy_position):
13317 (make_lispy_event, make_lispy_movement, apply_modifiers):
13318 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13319 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13320 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13321 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13322 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13323
a053e86c 13324 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13325 (mark_kboards): Move decl here ...
13326 * alloc.c (mark_kboards): ... from here.
a053e86c 13327
4752793e
PE
13328 * lisp.h (force_auto_save_soon): New decl.
13329
74f10ca7 13330 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13331 (DEFINE_DUMMY_FUNCTION): New macro.
13332 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13333 Use it.
c03cd23f
PE
13334 (main): Add casts to avoid warnings
13335 if GCC considers string literals to be constants.
74f10ca7 13336
022e70d4
PE
13337 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13338
59d6fe83
PE
13339 * dbusbind.c: Pointer signedness fixes.
13340 (xd_signature, xd_append_arg, xd_initialize):
13341 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13342 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13343 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13344 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13345
78320123
PE
13346 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13347 if GCC considers string literals to be constants.
49cebcca 13348 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13349
35ac2a97
SM
133502011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13351
fb103ca9
SM
13352 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13353 (print_preprocess, print_object): New macro to fix last change.
13354
35ac2a97
SM
13355 * print.c (print_preprocess): Don't forget font objects.
13356
62973b41
JB
133572011-03-16 Juanma Barranquero <lekktu@gmail.com>
13358
13359 * emacs.c (USAGE3): Doc fixes.
13360
0e48bb22
AS
133612011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13362
13363 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13364 structure.
13365
7684e57b
JB
133662011-03-14 Juanma Barranquero <lekktu@gmail.com>
13367
13368 * lisp.h (VWindow_system, Qfile_name_history):
13369 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13370 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13371 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13372
13373 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13374 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13375
13376 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13377 * w32console.c (detect_input_pending, read_input_pending)
13378 (encode_terminal_code):
13379 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13380 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13381 (w32_system_caret_y, Qfile_name_history):
13382 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13383 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13384 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13385 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13386 * w32proc.c (Qlocal, report_file_error):
13387 * w32term.c (Vwindow_system, updating_frame):
13388 * w32uniscribe.c (initialized, uniscribe_font_driver):
13389 Remove unneeded extern declarations.
13390
2aa46d6c
CY
133912011-03-14 Chong Yidong <cyd@stupidchicken.com>
13392
c96bbc66 13393 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13394
cffc6f3b
CY
133952011-03-13 Chong Yidong <cyd@stupidchicken.com>
13396
13397 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13398 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13399 These macros can no longer be used for assignment.
13400
44f230aa
SM
13401 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13402 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13403 (record_buffer_markers, fetch_buffer_markers): New functions for
13404 recording and fetching special buffer markers.
13405 (set_buffer_internal_1, set_buffer_temp): Use them.
13406
13407 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13408
13409 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13410
13411 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13412 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13413
13414 * xdisp.c (hscroll_window_tree):
13415 (reconsider_clip_changes): Use PT instead of BUF_PT.
13416
d251f04b
EZ
134172011-03-13 Eli Zaretskii <eliz@gnu.org>
13418
13419 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13420 $(EMACS_ROOT)/lib/intprops.h.
13421
f0c77cd1
PE
134222011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13423
3eca4629
PE
13424 Fix more problems found by GCC 4.5.2's static checks.
13425
7c86ee98
PE
13426 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13427 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13428 (xg_free_frame_widgets): Make it clear that a local variable is
13429 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13430 (gdk_window_get_screen): Make it clear that this macro is needed
13431 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13432 (int_gtk_range_get_value): New function, which avoids a diagnostic
13433 from gcc -Wbad-function-cast.
13434 (xg_set_toolkit_scroll_bar_thumb): Use it.
13435 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13436 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13437 (get_utf8_string, xg_get_file_with_chooser):
13438 Rename locals to avoid shadowing.
13439 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13440
41729b81
PE
13441 * xgselect.c (xg_select): Remove unused var.
13442
f0c77cd1
PE
13443 * image.c (four_corners_best): Mark locals as initialized.
13444 (gif_load): Initialize transparent_p to zero (Bug#8238).
13445 Mark another local as initialized.
ec6cf4c6 13446 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13447
ce0ad53d 13448 * image.c (clear_image_cache): Now static.
d5d5a617 13449 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13450 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13451 (x_edge_detection): Remove unnecessary cast that
13452 gcc -Wbad-function-cast diagnoses.
2037898d 13453 (gif_load): Fix pointer signedness.
6ae141d6
PE
13454 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13455 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13456
33383987 134572011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13458
d32df629
PE
13459 Improve quality of tests for time stamp overflow.
13460 For example, without this patch (encode-time 0 0 0 1 1
13461 1152921504606846976) returns the obviously-bogus value (-948597
13462 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13463 reports time overflow. See
13464 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13465 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13466 * editfns.c: Include limits.h and intprops.h.
13467 (TIME_T_MIN, TIME_T_MAX): New macros.
13468 (time_overflow): Move earlier, to before first use.
13469 (hi_time, lo_time): New functions, for an accurate test for
13470 out-of-range times.
13471 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13472 (Fget_internal_run_time): Don't assume time_t fits in int.
13473 (make_time): Use list2 instead of Fcons twice.
13474 (Fdecode_time): More accurate test for out-of-range times.
13475 (check_tm_member): New function.
13476 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13477 (lisp_time_argument): Don't rely on undefined left-shift and
13478 right-shift behavior when checking for time stamp overflow.
8be6f318 13479
fe31d94c
PE
13480 * editfns.c (time_overflow): New function, refactoring common code.
13481 (Fformat_time_string, Fdecode_time, Fencode_time):
13482 (Fcurrent_time_string): Use it.
13483
8be6f318
PE
13484 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13485 * dired.c (make_time): Move to ...
13486 * editfns.c (make_time): ... here.
13487 * systime.h: Note the move.
13488
09d9db2c 134892011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13490
126bc0dc
YM
13491 * fringe.c (update_window_fringes): Remove unused variables.
13492
c47cbdfd
YM
13493 * unexmacosx.c (copy_data_segment): Also copy __got section.
13494 (Bug#8223)
13495
7ac80be9
EZ
134962011-03-12 Eli Zaretskii <eliz@gnu.org>
13497
c96bbc66 13498 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13499 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13500 Constify `char *' arguments and their references according to
13501 prototypes in tparam.h.
13502
ecb0f94d 13503 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13504
7ac80be9
EZ
13505 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13506 Adapt all references accordingly.
13507
13508 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13509
ef1fd07e
TT
135102011-03-11 Tom Tromey <tromey@redhat.com>
13511
13512 * buffer.c (syms_of_buffer): Remove obsolete comment.
13513
7ef4b50c
EZ
135142011-03-11 Eli Zaretskii <eliz@gnu.org>
13515
13516 * termhooks.h (encode_terminal_code): Declare prototype.
13517
13518 * msdos.c (encode_terminal_code): Don't declare prototype.
13519
13520 * term.c (encode_terminal_code): Now external again, used by
13521 w32console.c and msdos.c.
13522
44f230aa
SM
13523 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13524 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13525
4b1ec863 135262011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13527
1714f52b 13528 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13529
4b1ec863
PE
13530 * fringe.c (update_window_fringes): Mark locals as initialized
13531 (Bug#8227).
13532 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13533
524c7aa6
PE
13534 * alloc.c (mark_fringe_data): Move decl from here ...
13535 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13536 to check its interface.
13537 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13538
a5c0af81 13539 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13540 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13541 (fontset_font): Mark local as initialized.
a9a06e0b 13542 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13543
b4716021
PE
13544 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13545
811e9bac 13546 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13547 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13548 (x_own_selection, Fx_disown_selection_internal): Rename locals
13549 to avoid shadowing.
13550 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13551
7e3ab302
PE
13552 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13553 so that the caller can use some name other than gcpro1.
13554 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13555 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13556 (Fx_backspace_delete_keys_p):
13557 Use them to avoid shadowing, and rename vars to avoid shadowing.
13558 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13559 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13560 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13561 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13562 Remove unused locals.
7e3ab302
PE
13563 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13564 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13565 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13566 macros.
f78faa98 13567
e2b13473
PE
13568 * xterm.h (x_mouse_leave): New decl.
13569
77f23912
PE
13570 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13571 Remove unused functions.
cdf4ba58
PE
13572 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13573 (x_calc_absolute_position): Now static.
7411c686 13574 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13575 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13576 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13577 unless they are used.
38d0b34a
PE
13578 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13579 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13580 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13581 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13582 (x_error_catcher, x_connection_closed, x_error_handler):
13583 (x_error_quitter, xembed_send_message, x_iconify_frame):
13584 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13585 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13586 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13587
44f230aa
SM
13588 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13589 Rename or move locals to avoid shadowing.
6b463e58 13590 (tty_defined_color, merge_face_heights): Now static.
5967d051 13591 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13592 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13593 does not deduce is never used uninitialized.
73719eba
PE
13594 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13595 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13596
426994c3 13597 * terminal.c (store_terminal_param): Now static.
5489860b 13598
032f1620 13599 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13600 (set_frame_menubar): Remove unused local.
d4323972 13601 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13602 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13603 since they might point to immutable storage.
281585b0
PE
13604 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13605 since it's unused otherwise.
032f1620 13606
367c19e5 13607 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13608 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13609 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13610 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13611 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13612 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13613 does not deduce are never used uninitialized.
70739cbe 13614
07b48fa9
PE
13615 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13616
8868a238 13617 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13618 * window.c (window_loop, size_window):
13619 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13620
7e5cf297 13621 * window.c (display_buffer): Now static.
d6550a9f
PE
13622 (size_window): Mark variables that gcc -Wuninitialized
13623 does not deduce are never used uninitialized.
a586633d
PE
13624 * window.h (check_all_windows): New decl, to forestall
13625 gcc -Wmissing-prototypes diagnostic.
5b555da1 13626 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13627
f6095868
PE
13628 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13629 shadowing.
13630 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13631 Include <limits.h>.
13632 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13633 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13634 (load_charset_map): Mark variables that gcc -Wuninitialized
13635 does not deduce are never used uninitialized.
53df7c11 13636 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13637
f38b440c
PE
13638 * coding.c (coding_set_source, coding_set_destination):
13639 Use "else { /* comment */ }" rather than "else /* comment */;"
13640 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13641 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13642 a block, when the outer 'i' will do.
13643 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13644 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13645 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13646 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13647 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13648 Rename locals to avoid shadowing.
13649 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13650 * coding.c (emacs_mule_char, encode_invocation_designation):
13651 Now static, since they're not used elsewhere.
413bb2db 13652 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13653 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13654 (decode_coding_emacs_mule): Mark variables that gcc
13655 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13656 (detect_coding_iso_2022): Initialize a local variable that might
13657 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13658 this initialization is needed. (Bug#8211)
5f58e762
PE
13659 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13660 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13661 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13662 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13663 Remove unused macros.
f38b440c 13664
232b38b9 13665 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13666 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13667 * character.c (string_count_byte8): Likewise.
232b38b9 13668
fb90da1b
PE
13669 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13670 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13671
fb93dbc2
PE
13672 * chartab.c (copy_sub_char_table): Now static, since it's not used
13673 elsewhere.
5c156ace
PE
13674 (sub_char_table_ref_and_range, char_table_ref_and_range):
13675 Rename locals to avoid shadowing.
bbcd0949 13676 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13677
7d3b3862 13678 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13679 (BIDI_BOB): Remove unused macro.
7d3b3862 13680
6be7d3da
PE
13681 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13682 deduce are never used uninitialized.
c2ed9c8b 13683 * term.c (encode_terminal_code): Likewise.
6be7d3da 13684
75f8807f 13685 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13686
50938595
PE
13687 * tparam.h: New file.
13688 * term.c, tparam.h: Include it.
13689 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13690 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13691 Move these decls to tparam.h, and make them agree with what
13692 is actually in tparam.c. The previous trick of using incompatible
13693 decls in different modules does not conform to the C standard.
13694 All callers of tparam changed to use tparam's actual API.
13695 * tparam.c (tparam1, tparam, tgoto):
13696 Use const pointers where appropriate.
13697
fbceeba2
PE
13698 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13699 * cm.h (struct cm): Likewise.
13700 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13701 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13702 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13703 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13704 (turn_on_face, init_tty): Likewise.
13705 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13706
7f3f1250
PE
13707 * term.c (term_mouse_position): Rename local to avoid shadowing.
13708
e6ca6543
PE
13709 * alloc.c (mark_ttys): Move decl from here ...
13710 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13711
c40f8d15
AS
137122011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13713
13714 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13715
cfe0661d
JB
137162011-03-09 Juanma Barranquero <lekktu@gmail.com>
13717
13718 * search.c (compile_pattern_1): Remove argument regp, unused since
13719 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13720 (compile_pattern): Don't pass it.
13721
0afb4571
J
137222011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13723
13724 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13725 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13726 for ! HAVE_GTK3.
13727 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13728
13729 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13730
13731 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13732 gdk_window_get_screen, gdk_window_get_geometry,
13733 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13734 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13735 (xg_get_pixbuf_from_pixmap): New function.
13736 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13737 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13738 Call xg_get_pixbuf_from_pixmap instead of
13739 gdk_pixbuf_get_from_drawable.
13740 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13741 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13742 (xg_check_special_colors): Use GtkStyleContext and its functions
13743 for HAVE_GTK3.
13744 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13745 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13746 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13747 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13748 Call gtk_widget_get_preferred_size.
0afb4571
J
13749 (xg_frame_resized): gdk_window_get_geometry only takes 5
13750 parameters.
44f230aa
SM
13751 (xg_win_to_widget, xg_event_is_for_menubar):
13752 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13753 (xg_set_widget_bg): New function.
13754 (delete_cb): New function.
895009e1 13755 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13756 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13757 (xg_set_background_color): Call xg_set_widget_bg.
13758 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13759 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13760 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13761 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13762 if ! HAVE_GTK3.
13763 (update_frame_tool_bar): Call gtk_widget_hide.
13764 (xg_initialize): Use GDK_KEY_g.
13765
13766 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13767 if ! HAVE_GTK3
13768 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13769
13770 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13771 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13772 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13773
1c2cc4ef
JB
137742011-03-08 Juanma Barranquero <lekktu@gmail.com>
13775
13776 * w32xfns.c (select_palette): Check success of RealizePalette against
13777 GDI_ERROR, not zero.
13778
33383987 13779See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13780
13781;; Local Variables:
13782;; coding: utf-8
aac0c6e3
MR
13783;; End:
13784
2f097256 13785 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13786
13787 This file is part of GNU Emacs.
13788
13789 GNU Emacs is free software: you can redistribute it and/or modify
13790 it under the terms of the GNU General Public License as published by
13791 the Free Software Foundation, either version 3 of the License, or
13792 (at your option) any later version.
13793
13794 GNU Emacs is distributed in the hope that it will be useful,
13795 but WITHOUT ANY WARRANTY; without even the implied warranty of
13796 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13797 GNU General Public License for more details.
13798
13799 You should have received a copy of the GNU General Public License
13800 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.