* Makefile.in (BIG_STACK_DEPTH): Enlarge to 2200.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cd4eb164
CY
12012-06-09 Chong Yidong <cyd@gnu.org>
2
3 * term.c: Support italics in capable terminals (Bug#9652).
4 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
5 (turn_on_face): Output using TS_enter_italic_mode if available.
6 Don't handle unused blinking and alt-charset cases.
7 (turn_off_face): Handle italic case; discard unused tty_blinking_p
8 and tty_alt_charset_p cases.
9 (tty_capable_p, init_tty): Support italics.
10
11 * termchar.h (struct tty_display_info): Add field for italics.
12 Remove unused blink field.
13
14 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
15 Handle slant.
16
17 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
18 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
19 tty_alt_charset_p. Add tty_italic_p.
20
ff88beb8
MA
212012-06-09 Michael Albinus <michael.albinus@gmx.de>
22
23 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
24 dbus_type_is_basic if available.
25 (xd_extract_signed, xd_extract_unsigned): Rename from
26 extract_signed and extract_unsigned, respectively. Adapt callers.
27
44286096
CY
282012-06-09 Chong Yidong <cyd@gnu.org>
29
1682701f
CY
30 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
31
44286096
CY
32 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
33 case (Bug#9752).
34
d86feb17
PE
352012-06-08 Paul Eggert <eggert@cs.ucla.edu>
36
37 * xdisp.c (vmessage): Treat frame message as multibyte.
38 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
39 would generate the diagnostic "Making \302\247 buffer-local while
40 let-bound!".
41
d5c20fe8
EZ
422012-06-08 Eli Zaretskii <eliz@gnu.org>
43
44 * dispnew.c (showing_window_margins_p): Undo last change, which
45 was done due to an inadvertent commit.
46 (adjust_frame_glyphs_for_frame_redisplay): Do call
47 showing_window_margins_p.
48
513749ee
SM
492012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
50
51 * eval.c (Fmake_var_non_special): New primitive.
52 (syms_of_eval): Defsubr it.
53 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
54
d4a8f5c1
JB
552012-06-08 Juanma Barranquero <lekktu@gmail.com>
56
57 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
58 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
59
8bbbc977
EZ
602012-06-08 Eli Zaretskii <eliz@gnu.org>
61
62 * alloc.c (allocate_vectorlike): Fix last change.
63
f3372c87
DA
642012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
65
66 Block-based vector allocation of small vectors.
67 * lisp.h (struct vectorlike_header): New field `nbytes',
68 adjust comment accordingly.
69 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
70 to denote vector blocks. Adjust users (live_vector_p,
71 mark_maybe_pointer, valid_lisp_object_p) accordingly.
72 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
73 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
74 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
75 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
76 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
77 (roundup_size): New constant.
78 (struct vector_block): New data type.
79 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 80 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
81 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
82 (sweep_vectors): New functions.
83 (allocate_vectorlike): Return `zero_vector' as the only vector of
84 0 items. Allocate new vector from block if vector size is less than
85 or equal to VBLOCK_BYTES_MAX.
86 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
87 (init_alloc_once): Add call to init_vectors.
88
4f18a4ed
SM
892012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
90
91 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
92
86f158bc
PE
932012-06-07 Paul Eggert <eggert@cs.ucla.edu>
94
95 * doprnt.c (doprnt): Truncate multibyte char correctly.
96 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
97 would mishandle a string argument "Xc" if X was a multibyte
98 character of length 2: it would truncate after X's first byte
99 rather than including all of X.
100
c5cfcbe0
CY
1012012-06-06 Chong Yidong <cyd@gnu.org>
102
103 * buffer.c (word_wrap): Doc fix.
104
c05cf390
PE
1052012-06-04 Paul Eggert <eggert@cs.ucla.edu>
106
107 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
108
0c3461de
GM
1092012-06-03 Glenn Morris <rgm@gnu.org>
110
111 * xdisp.c (tool-bar-style): Doc fix.
112
c71232db
UM
1132012-06-03 Ulrich Müller <ulm@gentoo.org>
114
115 * Makefile.in (PAXCTL): Define.
116 (temacs$(EXEEXT)): Disable memory randomization for the temacs
117 binary via PaX flags if the paxctl utility is available.
118 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
119 Restore PaX flags to their default. (Bug#11398)
120
383f7350
CY
1212012-06-03 Chong Yidong <cyd@gnu.org>
122
123 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
124 buffer (Bug#11226).
125
5f2c76c6
CY
1262012-06-03 Chong Yidong <cyd@gnu.org>
127
128 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
129 (note_mode_line_or_margin_highlight): If there is no help echo,
130 use mode-line-default-help-echo. Handle the case where the mouse
131 position is past the end of the mode line string.
132
133 * buffer.c (buffer_local_value_1): New function, split from
134 Fbuffer_local_value; can return Qunbound.
135 (Fbuffer_local_value): Use it.
136 (Vmode_line_format): Docstring tweaks.
137
773d47f6
PE
1382012-06-02 Paul Eggert <eggert@cs.ucla.edu>
139
140 * sysdep.c (system_process_attributes): Improve comment.
141
f2d6a3df
SM
1422012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
143
144 * keyboard.c: Export real-this-command to Elisp.
145 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
146 and DEFVAR it. Update all users.
147
63810350
PE
1482012-06-02 Paul Eggert <eggert@cs.ucla.edu>
149
7bd5c1f4
PE
150 * minibuf.c (Fassoc_string): Remove duplicate declaration.
151
63810350
PE
152 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
153 Convert pctcpu and pctmem to Lisp float properly.
154 Let the compiler fold better, as 100.0/0x8000 is exact.
155
a2821611
AS
1562012-06-02 Andreas Schwab <schwab@linux-m68k.org>
157
158 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
159 cons_block.
160
5fceba1d
PE
1612012-06-01 Paul Eggert <eggert@cs.ucla.edu>
162
163 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
164
c98ff5dd
DA
1652012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
166
167 For a 'struct window', replace some Lisp_Object fields to
168 bitfields where appropriate, remove unused fields.
169 * window.h (struct window): Remove unused 'last_mark_x' and
170 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
171 change it's type from Lisp_Object to bitfield.
172 Change type of 'force_start', 'optional_new_start',
173 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
174 fields from Lisp_Object to bitfield. Adjust users accordingly.
175
ca34e0be
PE
1762012-05-31 Paul Eggert <eggert@cs.ucla.edu>
177
178 Pacify gcc -Wdouble-precision when using Xaw.
179 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
180 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
181 Use 'float' consistently, rather than 'float' in most places
182 and 'double' in a couple of places.
183
efc00ab1 1842012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
185
186 * xdisp.c (handle_stop): Detect whether we have overlay strings
187 loaded by testing it->current.overlay_string_index to be
188 non-negative, instead of checking whether n_overlay_strings is
189 positive. (Bug#11587)
190
efc00ab1 1912012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
192
193 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
194
195 * doc.c (Fsubstitute_command_keys): Doc fix.
196
efc00ab1 1972012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
198
199 * search.c (search_buffer): Remove calls to
200 r_alloc_inhibit_buffer_relocation, as it is now called by
201 maybe_unify_char, which was the cause of relocation of buffer text
202 in bug#11519.
203
efc00ab1 2042012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
205
206 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
207 for the duration of call to load_charset, to avoid problems with
208 callers of maybe_unify_char that access buffer text through C
209 pointers.
210
211 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
212 decrement the inhibition flag, instead of just setting or
213 resetting it.
214
ba93a187
PE
2152012-05-31 Paul Eggert <eggert@cs.ucla.edu>
216
217 Remove obsolete '#define static' cruft.
218 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
219 This #undef was "temporary" in 2000; it is no longer needed
220 now that '#define static' has gone away.
221 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
222 (gray_bitmap_bits): Remove; no longer needed.
223 All uses replaced with definiens.
224 * xterm.c: Include "bitmaps/gray.xbm".
225
9e4bf381
PE
2262012-05-30 Paul Eggert <eggert@cs.ucla.edu>
227
228 Clean up __executable_start, monstartup when --enable-profiling.
229 The following changes affect the code only when profiling.
230 * dispnew.c (__executable_start): Rename from safe_bcopy.
231 Define only on platforms that need it.
232 * emacs.c: Include <sys/gmon.h> when profiling.
233 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
234 (__executable_start): Remove decl, since lisp.h does it now.
235 (safe_bcopy): Remove decl; no longer has that name.
236 (main): Coalesce #if into single bit of code, for simplicity.
237 Cast pointers to uintptr_t, since standard libraries want integers
238 and not pointers.
239 * lisp.h (__executable_start): New decl.
240
32d72c2f
GM
2412012-05-31 Glenn Morris <rgm@gnu.org>
242
243 * image.c (Fimagemagick_types): Doc fix.
244
baac5bc7
JM
2452012-05-30 Jim Meyering <meyering@redhat.com>
246
247 * callproc.c (Fcall_process_region): Include directory component
248 in mkstemp error message (Bug#11586).
249
72cb32cf
PE
2502012-05-30 Paul Eggert <eggert@cs.ucla.edu>
251
252 * alloc.c, lisp.h (make_pure_vector): Now static.
253
61b108cc
SM
2542012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
255
256 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
257 Move to byte-run.el.
258 (Fautoload): Do the hash-doc more carefully.
259 * data.c (Fdefalias): Purify definition, except for keymaps.
260 (Qdefun): Move from eval.c.
261 * lisp.h (Qdefun): Remove.
262 * lread.c (read1): Tiny simplification.
263
471fe23d
TN
2642012-05-29 Troels Nielsen <bn.troels@gmail.com>
265
934f3f58 266 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
267 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
268 Bug#9642, but explicitly check that the buffer the overlay would
269 be moved to is live and rearrange lines to make sure that errors
270 will not put the overlay in an inconsistent state.
271 (Fdelete_overlay): Cosmetics.
272
85d0efd1
EZ
2732012-05-28 Eli Zaretskii <eliz@gnu.org>
274
275 * w32term.c (my_bring_window_to_top): New function.
276 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
277 could be different from the original one.
278 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
279 (Bug#11513)
280
281 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
282 by calling BringWindowToTop.
283
284 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
285 (WM_EMACS_END): Increase by one.
286
da92a98c
PE
2872012-05-28 Paul Eggert <eggert@cs.ucla.edu>
288
289 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
290 This avoids undefined behavior that might cause the eassert
291 to not catch an out-of-range value.
292
74d1f848
JB
2932012-05-28 Juanma Barranquero <lekktu@gmail.com>
294
295 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
296 Update dependencies.
297
9e1a06fc
EZ
2982012-05-27 Eli Zaretskii <eliz@gnu.org>
299
300 * bidi.c (bidi_mirror_char): Fix last change.
301
f3dd7312
AS
3022012-05-27 Andreas Schwab <schwab@linux-m68k.org>
303
304 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
305 when referring to sectname field in printf format.
306
81899c91
PE
3072012-05-27 Paul Eggert <eggert@cs.ucla.edu>
308
57b81a9f
PE
309 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
310 Only r_alloc_inhibit_buffer_relocation needed to be added;
311 the others were already declared.
312
81899c91
PE
313 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
314 before checking whether it's out of range. Put the check inside
315 eassert. See
316 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
317
33017faf 3182012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
319
320 * callproc.c (Fcall_process): Restore a line that was accidentally
321 commented out in the 2011-02-13 change (bug#11547).
322
33017faf 3232012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
324
325 * lisp.h [REL_ALLOC]: Add prototypes for external functions
326 defined on ralloc.c.
327
328 * buffer.c [REL_ALLOC]: Remove prototypes of
329 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
330 they are now on lisp.h.
331
332 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
333
334 * search.c (search_buffer): Use it to inhibit relocation of buffer
335 text while re_search_2 is doing its job, because re_search_2 is
336 passed C pointers to buffer text. (Bug#11519)
337
23415acf
EZ
338 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
339 Update value to 24.
340
44e27368
EZ
341 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
342 state after an additional call to move_it_in_display_line_to, keep
343 the values of it->max_ascent and it->max_descent found for the
344 entire line.
345 (pos_visible_p): Revert the comparison against bottom_y to what it
346 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
347 (Bug#11464)
348
c1892f11
PE
3492012-05-26 Paul Eggert <eggert@cs.ucla.edu>
350
351 Fix coding-related core dumps with gcc -ftrapv.
352 The code was computing A - B, where A and B are pointers, and B is
353 random garbage. This can lead to core dumps on platforms that
354 have special pointer registers, and it also leads to core dumps on
355 x86-64 when compiled with gcc -ftrapv. The fix is to compute
356 A - B only when B is initialized properly.
357 * coding.c (coding_set_source, coding_set_destination): Return void.
358 (coding_change_source, coding_change_destinations): New functions,
359 with the old behaviors of coding_set_source and coding_set_destination.
360 All callers that need an offset changed to use these new functions.
361
eb7afdad
GM
3622012-05-26 Glenn Morris <rgm@gnu.org>
363
364 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
365
f12fdf02
EZ
3662012-05-26 Eli Zaretskii <eliz@gnu.org>
367
53a63be6 368 Extend mouse support on W32 text-mode console.
61b108cc
SM
369 * xdisp.c (draw_row_with_mouse_face):
370 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 371
eb3f6f01 372 * w32console.c: Include window.h.
61b108cc
SM
373 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
374 New functions.
eb3f6f01
EZ
375 (initialize_w32_display): Initialize mouse-highlight data.
376
53a63be6
EZ
377 * w32inevt.c: Include termchar.h and window.h.
378 (do_mouse_event): Support mouse-autoselect-window. When the mouse
379 moves, call note_mouse_highlight. If help_echo changed, call
380 gen_help_event to produce help-echo message in the echo area.
381 Call clear_mouse_face if mouse_face_hidden is set in the mouse
382 highlight info.
383
4cfd81f6
PE
3842012-05-26 Paul Eggert <eggert@cs.ucla.edu>
385
386 * lread.c (read1): Simplify slightly to avoid an overflow warning
387 with GCC 4.7.0 on x86-64.
388
4446092a
EZ
3892012-05-26 Eli Zaretskii <eliz@gnu.org>
390
391 * bidi.c (bidi_mirror_char): Revert last change: an int is
392 definitely wide enough here.
393
42b2a986 3942012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 395
42b2a986 396 Fix integer width and related bugs (Bug#9874).
eb106a49 397 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
398 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
399 (string_bytes, check_sblock, allocate_string_data):
400 (compact_small_strings, Fmake_bool_vector, make_string)
401 (make_unibyte_string, make_multibyte_string)
402 (make_string_from_bytes, make_specified_string)
403 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
404 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
405 (mark_vectorlike):
406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
407 (allocate_pseudovector):
408 Use int, not EMACS_INT, where int is wide enough.
409 (inhibit_garbage_collection, Fgarbage_collect):
410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
411 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
412 int might not be wide enough.
413 (bidi_cache_search, bidi_cache_find, bidi_init_it)
414 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
415 (bidi_at_paragraph_end, bidi_find_paragraph_start)
416 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
417 (bidi_level_of_next_char, bidi_move_to_visually_next):
418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
419 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
420 (Fkill_buffer, Fset_buffer_major_mode)
421 (advance_to_char_boundary, Fbuffer_swap_text)
422 (Fset_buffer_multibyte, overlays_at, overlays_in)
423 (overlay_touches_p, struct sortvec, record_overlay_string)
424 (overlay_strings, recenter_overlay_lists)
425 (adjust_overlays_for_insert, adjust_overlays_for_delete)
426 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
427 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
428 (Foverlay_recenter, last_overlay_modification_hooks_used)
429 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
431 (validate_region): Omit unnecessary test for b <= e,
432 since that's guaranteed by the previous test.
d311d28c
PE
433 (adjust_overlays_for_delete): Avoid pos + length overflow.
434 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
435 (report_overlay_modification):
436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
437 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
438 Omit pointer cast, which isn't needed anyway, and doesn't work
439 after the EMACS_INT -> ptrdiff_t change.
02481186 440 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
441 * buffer.h: Adjust decls to match defn changes elsewhere.
442 (struct buffer_text, struct buffer):
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
444 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
445 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
446 not int, to avoid needless 32-bit limit on 64-bit hosts.
447 (exec_byte_code): Use tighter memory-full test, one that checks
448 for alloca overflow. Don't compute the address of the object just
449 before an array, as that's not portable. Use EMACS_INT, not
450 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
451 * callint.c (Fcall_interactively):
452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
453 * callproc.c (call_process_kill, Fcall_process):
454 Don't assume pid_t fits into an Emacs fixnum.
455 (call_process_cleanup, Fcall_process, child_setup):
456 Don't assume pid_t fits into int.
457 (call_process_cleanup, Fcall_process, delete_temp_file)
458 (Fcall_process_region):
459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
460 (Fcall_process): Simplify handling of volatile integers.
461 Use int, not EMACS_INT, where int will do.
462 * casefiddle.c (casify_object, casify_region, operate_on_word)
463 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
465 (casify_object): Avoid integer overflow when overallocating buffer.
466 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 467 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
468 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
469 * category.h (CATEGORYP): Don't assume arg is nonnegative.
470 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
471 integers are now checked earlier. All uses replaced with XINT.
472 (ccl_driver):
473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
474 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
475 (ccl_driver, Fregister_code_conversion_map):
476 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
477 (resolve_symbol_ccl_program): Check that vector header is in range.
478 Always copy the vector, so that we can check its contents reliably
479 now rather than having to recheck each instruction as it's being
480 executed. Check that vector words fit in 'int'.
481 (ccl_get_compiled_code, Fregister_ccl_program)
482 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
483 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
484 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
485 contents are in range.
486 (Fccl_execute_on_string): Check that status is in range.
487 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
488 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
489 Accept and return EMACS_INT, not int, because callers can pass values
490 out of 'int' range.
491 (c_string_width, strwidth, lisp_string_width, chars_in_text)
492 (multibyte_chars_in_text, parse_str_as_multibyte)
493 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
494 (str_as_unibyte, str_to_unibyte, string_count_byte8)
495 (string_escape_byte8, Fget_byte):
496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 497 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
498 avoid mishandling large integers.
499 * character.h: Adjust decls to match defn changes elsewhere.
500 * charset.c (load_charset_map_from_file, find_charsets_in_text)
501 (Ffind_charset_region):
502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
503 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
504 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 505 Don't assume fixnum fits in int.
d311d28c
PE
506 (load_charset_map_from_vector, Fmap_charset_chars):
507 Remove now-unnecessary CHECK_NATNUMs.
508 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
509 Don't rely on undefined behavior with signed left shift overflow.
510 Don't assume unsigned int fits into fixnum, or that fixnum fits
511 into unsigned int. Don't require max_code to be a valid fixnum;
512 that's not true for gb10830 4-byte on a 32-bit host. Allow
513 invalid_code to be a cons, for the same reason. Require code_offset
514 to be a character. Avoid int overflow if max_char is close
515 to INT_MAX.
516 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
517 this is intended anyway and avoids some undefined behavior.
518 (load_charset_map): Pass unsigned, not int, as 2nd arg of
519 INDEX_TO_CODE_POINT, as that's what it expects.
520 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
521 * charset.h (DECODE_CHAR): Return int, not unsigned;
522 this is what was intended anyway, and it avoids undefined behavior.
523 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
524 integer-overflow issues.
525 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
526 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
527 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
528 * chartab.c (Fmake_char_table, Fset_char_table_range)
529 (uniprop_get_decoder, uniprop_get_encoder):
530 Don't assume fixnum fits in int.
531 * cmds.c (move_point): New function, that does the gist of
532 Fforward_char and Fbackward_char, but does so while checking
533 for integer overflow more accurately.
c96e5d6a 534 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
535 (Fforward_line, Fend_of_line, internal_self_insert)
536 (internal_self_insert):
537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
538 Fix a FIXME, by checking for integer overflow when calculating
539 target_clm and actual_clm.
540 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 541 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
542 (ASSURE_DESTINATION, coding_alloc_by_realloc)
543 (coding_alloc_by_making_gap, alloc_destination)
544 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
545 (encode_coding_utf_16, detect_coding_emacs_mule)
546 (decode_coding_emacs_mule, encode_coding_emacs_mule)
547 (detect_coding_iso_2022, decode_coding_iso_2022)
548 (encode_invocation_designation, encode_designation_at_bol)
549 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
550 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
551 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
552 (encode_coding_ccl, encode_coding_raw_text)
553 (detect_coding_charset, decode_coding_charset)
554 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
555 (produce_composition, produce_charset, produce_annotation)
556 (decode_coding, handle_composition_annotation)
557 (handle_charset_annotation, consume_chars, decode_coding_gap)
558 (decode_coding_object, encode_coding_object, detect_coding_system)
559 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
560 (code_convert_region, code_convert_string)
8f50130c
PE
561 (Fdefine_coding_system_internal)
562 (coding_set_source, coding_set_destination):
d311d28c
PE
563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
564 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
565 (Fdefine_coding_system_internal):
566 Don't assume fixnums fit in int.
567 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 568 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
569 (Funencodable_char_position, Fcheck_coding_systems_region)
570 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 572 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 573 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 574 Don't access memory outside of the args array.
d311d28c 575 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
576 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
577 result of ENCODE_CHAR.
d311d28c
PE
578 * coding.h: Adjust decls to match defn changes elsewhere.
579 (struct coding_system):
580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
581 * composite.c (get_composition_id, find_composition)
582 (run_composition_function, update_compositions)
583 (compose_text, composition_gstring_put_cache)
584 (composition_gstring_p, composition_gstring_width)
585 (fill_gstring_header, fill_gstring_body, autocmp_chars)
586 (composition_compute_stop_pos, composition_reseat_it)
587 (composition_update_it, struct position_record)
588 (find_automatic_composition, composition_adjust_point)
589 (Fcomposition_get_gstring, Ffind_composition_internal):
590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
591 (update_compositions):
592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
593 * composite.h: Adjust decls to match defn changes elsewhere.
594 (struct composition):
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
597 Do not attempt to compute the address of the object just before a
598 buffer; this is not portable.
599 (Faref, Faset):
600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
601 (Faset): Use int, not EMACS_INT, where int is wide enough.
602 (Fstring_to_number): Don't assume fixnums fit in int.
603 (Frem): Don't assume arg is nonnegative.
604 * dbusbind.c (xd_append_arg): Check for integers out of range.
605 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 606 (extract_signed, extract_unsigned): New functions.
243e0530
PE
607 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
608 (xd_get_connection_references): Return ptrdiff_t, not int.
609 All uses changed.
610 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
611 (xd_read_message_1):
612 Use int, not unsigned, where the dbus API uses int.
613 (Fdbus_message_internal): Don't overflow mtype.
614 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
615 * dired.c (directory_files_internal, file_name_completion, scmp)
616 (file_name_completion_stat):
617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
618 (file_name_completion): Don't overflow matchcount.
619 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
620 * dispextern.h: Adjust decls to match defn changes elsewhere.
621 (struct text_pos, struct glyph, struct bidi_saved_info)
622 (struct bidi_string_data, struct bidi_it, struct composition_it)
623 (struct it):
624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
625 (struct display_pos, struct composition_it, struct it):
626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
627 * dispnew.c (increment_matrix_positions)
628 (increment_row_positions, mode_line_string)
629 (marginal_area_string):
630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 631 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
633 (duration_to_sec_usec): New function, to check for overflow better.
634 (Fsleep_for, sit_for): Use it.
635 * doc.c (get_doc_string, store_function_docstring):
636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
637 (get_doc_string, Fsnarf_documentation):
638 Use int, not EMACS_INT, where int is wide enough.
639 (get_doc_string):
640 Use SAFE_ALLOCA, not alloca.
641 Check for overflow when converting EMACS_INT to off_t.
642 * doprnt.c (doprnt):
643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
644 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
645 Don't assume uid_t fits into fixnum.
646 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
647 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
648 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
649 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
650 (general_insert_function)
651 (Finsert_char, make_buffer_string, make_buffer_string_both)
652 (update_buffer_properties, Fbuffer_substring)
653 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
654 (Fsubst_char_in_region, check_translation)
655 (Ftranslate_region_internal, save_restriction_restore, Fformat)
656 (transpose_markers, Ftranspose_regions):
657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
658 (clip_to_bounds): Move to lisp.h as an inline function).
659 (Fconstrain_to_field): Don't assume integers are nonnegative.
660 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
661 (Fsubst_char_in_region, Fsave_restriction):
662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
663 (Femacs_pid): Don't assume pid_t fits into fixnum.
664 (lo_time): Use int, not EMACS_INT, when int suffices.
665 (lisp_time_argument): Check for usec out of range.
666 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
667 (Fuser_login_name, Fuser_full_name): Signal an error
668 if a uid argument is out of range, rather than relying on
669 undefined behavior.
c8d5c857
PE
670 (Fformat_time_string): Remove now-unnecessary check.
671 lisp_time_argument checks for out-of-range usec now.
243e0530 672 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
673 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
674 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
675 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
676 (init_cmdargs, Fdump_emacs):
677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
678 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
679 the bottom (typically) 32 bits of the fixnum.
680 * eval.c (specpdl_size, call_debugger):
681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
682 (when_entered_debugger, Fbacktrace_debug):
683 Don't assume fixnum can fit in int.
684 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
685 the object just before a buffer; this is not portable.
686 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
687 (grow_specpdl, unbind_to):
688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
689 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
690 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 691 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
692 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
693 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
695 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
696 (a_write, e_write):
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 (Fcopy_file, non_regular_nbytes, read_non_regular)
699 (Finsert_file_contents):
700 Use int, not EMACS_INT, where int is wide enough.
701 (READ_BUF_SIZE): Verify that it fits in int.
702 (Finsert_file_contents): Check that counts are in proper range,
703 rather than assuming fixnums fit into ptrdiff_t etc.
704 Don't assume fixnums fit into int.
125b3835 705 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
706 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
707 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
708 (string_char_to_byte, string_byte_to_char)
709 (string_make_multibyte, string_to_multibyte)
710 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
711 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
712 (substring_both, Fdelete, internal_equal, Ffillarray)
713 (Fclear_string, mapcar1)
714 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
715 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
716 (larger_vector, make_hash_table, maybe_resize_hash_table)
717 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
718 (Fmaphash, secure_hash):
719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
720 (concat): Check for string index and length overflow.
721 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
722 (Frequire):
723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
724 (larger_vector): New API (vec, incr_min, size_max) replaces old
725 one (vec, new_size, init). This catches size overflow.
726 INIT was removed because it was always Qnil.
727 All callers changed.
728 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
729 the upper bound on a hash table index size.
730 (make_hash_table, maybe_resize_hash_table): Use it.
731 (secure_hash): Computer start_byte and end_byte only after
732 they're known to be in ptrdiff_t range.
733 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
734 (Ffont_get_glyphs, Ffont_at):
735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
736 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
737 (Flist_fonts, Fopen_font):
738 Don't assume fixnum can fit in int.
739 (check_gstring): Don't assume index can fit in int.
740 (font_match_p): Check that fixnum is a character, not a nonnegative
741 fixnum, since the later code needs to stuff it into an int.
742 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
743 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
744 conversion overflow issues.
745 (Fopen_font): Check for integer out of range.
746 (Ffont_get_glyphs): Don't assume index can fit in int.
747 * font.h: Adjust decls to match defn changes elsewhere.
748 * fontset.c (reorder_font_vector): Redo score calculation to avoid
749 integer overflow.
750 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
751 printmax_t, where ptrdiff_t is wide enough.
752 (Finternal_char_font):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
755 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
756 (Fset_frame_position, x_set_frame_parameters)
757 (x_set_line_spacing, x_set_border_width)
758 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
759 Check that fixnums are in proper range for system types.
760 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
763 Use SAFE_ALLOCA_LISP, not alloca.
764 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
765 intptr_t is wide enough.
766 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
767 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
768 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
769 Check for fixnum out of range.
770 * ftfont.c (ftfont_list): Don't assume index fits in int.
771 Check that fixnums are in proper range for system types.
772 (ftfont_shape_by_flt):
773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
774 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
776 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
777 Check that fixnums are in proper range for system types.
778 * gnutls.h: Adjust decls to match defn changes elsewhere.
779 * gtkutil.c (xg_dialog_run):
780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
781 (update_frame_tool_bar):
782 Check that fixnums are in proper range for system types.
783 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 784 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
785 * indent.c (last_known_column, last_known_column_point):
786 (current_column_bol_cache):
787 (skip_invisible, current_column, check_display_width):
788 (check_display_width, scan_for_column, current_column_1)
789 (Findent_to, Fcurrent_indentation, position_indentation)
790 (indented_beyond_p, Fmove_to_column, compute_motion):
791 (Fcompute_motion, Fvertical_motion):
792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
793 (last_known_column_modified): Use EMACS_INT, not int.
794 (check_display_width):
795 (Fcompute_motion):
796 Check that fixnums and floats are in proper range for system types.
797 (compute_motion): Don't assume index or fixnum fits in int.
798 (compute_motion, Fcompute_motion):
799 Use int, not EMACS_INT, when it is wide enough.
800 (vmotion): Omit local var start_hpos that is always 0; that way
801 we don't need to worry about overflow in expressions involving it.
802 * indent.h: Adjust decls to match defn changes elsewhere.
803 (struct position):
804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
805 Use int, not EMACS_INT, where int is wide enough.
806 Remove unused members ovstring_chars_done and tab_offset;
807 all uses removed.
808 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
809 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
810 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
811 (make_gap, copy_text, insert, insert_and_inherit)
812 (insert_before_markers, insert_before_markers_and_inherit)
813 (insert_1, count_combining_before, count_combining_after)
814 (insert_1_both, insert_from_string)
815 (insert_from_string_before_markers, insert_from_string_1)
816 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
817 (adjust_after_replace, adjust_after_insert, replace_range)
818 (replace_range_2, del_range, del_range_1, del_range_byte)
819 (del_range_both, del_range_2, modify_region)
820 (prepare_to_modify_buffer, signal_before_change)
821 (signal_after_change, Fcombine_after_change_execute):
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 * intervals.c (traverse_intervals, rotate_right, rotate_left)
824 (balance_an_interval, split_interval_right, split_interval_left)
825 (find_interval, next_interval, update_interval)
826 (adjust_intervals_for_insertion, delete_node, delete_interval)
827 (interval_deletion_adjustment, adjust_intervals_for_deletion)
828 (static_offset_intervals, offset_intervals)
829 (merge_interval_right, merge_interval_left, make_new_interval)
830 (graft_intervals_into_buffer, temp_set_point_both)
831 (temp_set_point, set_point, adjust_for_invis_intang)
832 (set_point_both, move_if_not_intangible, get_property_and_range)
833 (get_local_map, copy_intervals, copy_intervals_to_string)
834 (compare_string_intervals, set_intervals_multibyte_1):
835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
836 * intervals.h: Adjust decls to match defn changes elsewhere.
837 (struct interval):
838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
839 * keyboard.c (this_command_key_count, this_single_command_key_start)
840 (before_command_key_count, before_command_echo_length, echo_now)
841 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
842 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
843 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
844 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
846 (last_non_minibuf_size, last_point_position, echo_truncate)
847 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
848 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
849 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
850 (stuff_buffered_input):
851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
852 (last_auto_save, command_loop_1, read_char):
853 Use EMACS_INT, not int, to avoid integer overflow.
854 (record_char): Avoid overflow in total_keys computation.
855 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
856 * keyboard.h: Adjust decls to match defn changes elsewhere.
857 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
858 (Fkey_description, Fdescribe_vector, Flookup_key):
859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
860 (click_position): New function, to check that positions are in range.
861 (Fcurrent_active_maps):
862 (describe_command):
863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
864 (Faccessible_keymaps, Fkey_description):
865 (preferred_sequence_p):
866 Don't assume fixnum can fit into int.
867 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
868 Check for integer overflow in size calculations.
869 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
870 avoid mishandling large integers.
871 * lisp.h: Adjust decls to match defn changes elsewhere.
872 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
873 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
874 (struct Lisp_Marker):
875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
876 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
877 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
878 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
879 All callers changed.
880 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
881 Assume the arg has valid form, since it always does.
882 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
883 unsigned integer system type.
884 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
885 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
887 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
888 (duration_to_sec_usec): New decl.
889 * lread.c (read_from_string_index, read_from_string_index_byte)
890 (read_from_string_limit, readchar, unreadchar, openp)
891 (read_internal_start, read1, oblookup):
892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
893 (Fload, readevalloop, Feval_buffer, Feval_region):
894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
895 (openp): Check for out-of-range argument to 'access'.
896 (read1): Use int, not EMACS_INT, where int is wide enough.
897 Don't assume fixnum fits into int.
6efdadfd 898 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
899 (read_filtered_event): Use duration_to_sec_usec
900 to do proper overflow checking on durations.
d311d28c
PE
901 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
902 in size calculation.
903 (Fexecute_kbd_macro):
904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
905 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
906 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
907 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
908 (set_marker_both, set_marker_restricted_both, marker_position)
909 (marker_byte_position, Fbuffer_has_markers_at):
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 912 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
913 It now merely ensures that the menu is large enough, without
914 necessarily growing it, as this avoids some integer overflow issues.
915 All callers changed.
916 (keymap_panes, parse_single_submenu, Fx_popup_menu):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
919 Use SAFE_ALLOCA_LISP, not alloca.
920 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
921 to EMACS_INT. Check that fixnums are in proper range for system types.
922 * minibuf.c (minibuf_prompt_width, string_to_object)
923 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
924 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
926 (get_minibuffer, read_minibuf_unwind):
927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
928 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
929 this simplifies overflow checking. All callers changed.
930 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
931 (Ftest_completion):
932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
933 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
934 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
935 Check that fixnums are in proper range for system types.
936 (Fx_create_frame, Fx_show_tip):
937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
938 * nsfont.m (ns_findfonts, nsfont_list_family):
939 Don't assume fixnum fits in long.
940 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
942 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
943 wide enough.
17fdb222 944 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
946 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
947 (PRINTDECLARE, PRINTPREPARE):
948 (strout, print_string):
949 (print, print_preprocess, print_check_string_charset_prop)
950 (print_object):
951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
952 (PRINTDECLARE):
953 (temp_output_buffer_setup, Fprin1_to_string, print_object):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 956 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 957 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
958 (print_error_message): Use SAFE_ALLOCA, not alloca.
959 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
960 (print_depth, new_backquote_output, print_number_index):
961 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
962 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
963 (Fset_process_window_size, Fformat_network_address)
964 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 965 (sigchld_handler):
d311d28c 966 Check that fixnums are in proper range for system types.
d44287d4 967 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
968 Check for process-ids out of pid_t range rather than relying on
969 undefined behavior.
e4d81efc 970 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
971 (Fformat_network_address, read_process_output, send_process)
972 (Fprocess_send_region, status_notify):
973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
974 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
975 (wait_reading_process_output, read_process_output, exec_sentinel):
976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
978 (Faccept_process_output): Use duration_to_sec_usec to do proper
979 overflow checking on durations.
dde14581
PE
980 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
981 Don't assume pid_t fits in int.
02481186
PE
982 * process.h (struct Lisp_Process): Members tick and update_tick
983 are now of type EMACS_INT, not int.
b62b53e8
PE
984 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
985 configured --with-wide-int.
d311d28c
PE
986 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
987 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
988 * search.c (looking_at_1, string_match_1):
989 (fast_string_match, fast_c_string_match_ignore_case)
990 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
991 (scan_newline, find_before_next_newline, search_command)
992 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
993 (set_search_regs, wordify):
994 (Freplace_match):
995 (Fmatch_data):
996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
997 (string_match_1, search_buffer, set_search_regs):
998 (Fmatch_data):
999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1000 (wordify): Check for overflow in size calculation.
1001 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1002 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1003 Check that fixnums are in proper range for system types.
1004 * sound.c (struct sound_device)
1005 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1007 (Fplay_sound_internal):
1008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1009 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1010 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1011 (Fparse_partial_sexp):
1012 Don't assume fixnums can fit in int.
1013 (struct lisp_parse_state, find_start_pos, find_start_value)
1014 (find_start_value_byte, find_start_begv)
1015 (update_syntax_table, char_quoted, dec_bytepos)
1016 (find_defun_start, prev_char_comend_first, back_comment):
1017 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1018 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1020 (Finternal_describe_syntax_value): Check that match_lisp is a
1021 character, not an integer, since the code stuffs it into int.
1022 (scan_words, scan_sexps_forward):
1023 Check that fixnums are in proper range for system types.
1024 (Fforward_word):
1025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1026 (scan_sexps_forward):
1027 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1028 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1029 * syntax.h: Adjust decls to match defn changes elsewhere.
1030 (struct gl_state_s):
1031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1032 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1033 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1034 * sysdep.c (wait_for_termination_1, wait_for_termination)
1035 (interruptible_wait_for_termination, mkdir):
1036 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1037 (emacs_read, emacs_write):
1038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1039 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1040 and double all fit in int.
d311d28c
PE
1041 * term.c (set_tty_color_mode):
1042 Check that fixnums are in proper range for system types.
1043 * termhooks.h (struct input_event):
1044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1045 * textprop.c (validate_interval_range, interval_of)
1046 (Fadd_text_properties, set_text_properties_1)
1047 (Fremove_text_properties, Fremove_list_of_text_properties)
1048 (Ftext_property_any, Ftext_property_not_all)
1049 (copy_text_properties, text_property_list, extend_property_ranges)
1050 (verify_interval_modification):
1051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1052 (Fnext_single_char_property_change)
1053 (Fprevious_single_char_property_change):
1054 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1055 (copy_text_properties):
1056 Check for integer overflow in index calculation.
d311d28c
PE
1057 * undo.c (last_boundary_position, record_point, record_insert)
1058 (record_delete, record_marker_adjustment, record_change)
1059 (record_property_change):
1060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1061 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1063 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1064 (Fx_hide_tip, Fx_file_dialog):
1065 * w32menu.c (set_frame_menubar):
1066 Use ptrdiff_t, not int, for consistency with rest of code.
1067 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1068 (select_window, Fdelete_other_windows_internal)
1069 (window_scroll_pixel_based, window_scroll_line_based)
1070 (Frecenter, Fset_window_configuration):
1071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1072 (Fset_window_hscroll, run_window_configuration_change_hook)
1073 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1074 (Fscroll_other_window, Frecenter):
d311d28c
PE
1075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1076 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1077 Don't assume fixnum fits in int.
1078 (Fset_window_scroll_bars):
1079 Check that fixnums are in proper range for system types.
1080 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1081 (string_pos, c_string_pos, number_of_chars, init_iterator)
1082 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1083 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1084 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1085 (face_before_or_after_it_pos, handle_invisible_prop)
1086 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1087 (display_prop_intangible_p, string_buffer_position_lim)
1088 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1089 (get_overlay_strings_1, get_overlay_strings)
1090 (iterate_out_of_display_property, forward_to_next_line_start)
1091 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1092 (get_next_display_element, set_iterator_to_next)
1093 (get_visually_first_element, compute_stop_pos_backwards)
1094 (handle_stop_backwards, next_element_from_buffer)
1095 (move_it_in_display_line_to, move_it_in_display_line)
1096 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1097 (add_to_log, message_dolog, message_log_check_duplicate)
1098 (message2, message2_nolog, message3, message3_nolog
1099 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1100 (current_message_1, truncate_echo_area, truncate_message_1)
1101 (set_message, set_message_1, store_mode_line_noprop)
1102 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1103 (text_outside_line_unchanged_p, check_point_in_composition)
1104 (reconsider_clip_changes)
1105 (redisplay_internal, set_cursor_from_row, try_scrolling)
1106 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1107 (redisplay_window, find_last_unchanged_at_beg_row)
1108 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1109 (trailing_whitespace_p, find_row_edges, display_line)
1110 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1111 (display_mode_element, store_mode_line_string)
1112 (pint2str, pint2hrstr, decode_mode_spec)
1113 (display_count_lines, display_string, draw_glyphs)
1114 (x_produce_glyphs, x_insert_glyphs)
1115 (rows_from_pos_range, mouse_face_from_buffer_pos)
1116 (fast_find_string_pos, mouse_face_from_string_pos)
1117 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1119 (safe_call, init_from_display_pos, handle_fontified_prop)
1120 (handle_single_display_spec, load_overlay_strings)
1121 (with_echo_area_buffer, setup_echo_area_for_printing)
1122 (display_echo_area, echo_area_display)
1123 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1124 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1125 (redisplay_window, dump_glyph_row, display_mode_line)
1126 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1127 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1129 (handle_single_display_spec, build_desired_tool_bar_string)
1130 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1131 (get_specified_cursor_type):
1132 Check that fixnums are in proper range for system types.
1133 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1134 (Flookup_image_map):
1135 Don't assume fixnums fit in int.
1136 (compare_overlay_entries):
1137 Avoid mishandling comparisons due to subtraction overflow.
1138 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1139 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1140 (handle_tool_bar_click):
1141 Use int, not unsigned, since we prefer signed and the signedness
1142 doesn't matter here.
1143 (get_next_display_element, next_element_from_display_vector):
1144 Use int, not EMACS_INT, when int is wide enough.
1145 (start_hourglass): Use duration_to_sec_usec to do proper
1146 overflow checking on durations.
1147 * xfaces.c (Fbitmap_spec_p):
1148 Check that fixnums are in proper range for system types.
1149 (compare_fonts_by_sort_order):
1150 Avoid mishandling comparisons due to subtraction overflow.
1151 (Fx_family_fonts, realize_basic_faces):
1152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1153 (Fx_family_fonts):
1154 Don't assume fixnum fits in int.
1155 Use SAFE_ALLOCA_LISP, not alloca.
1156 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1157 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1158 (face_at_buffer_position, face_for_overlay_string)
1159 (face_at_string_position):
1160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1161 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1162 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1163 (Fx_show_tip):
1164 Check that fixnums are in proper range for system types.
1165 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1166 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1168 (Fx_change_window_property): Don't assume fixnums fit in int.
1169 * xfont.c (xfont_chars_supported):
1170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1171 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1172 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1174 * xml.c (parse_region):
1175 * xrdb.c (magic_file_p):
1176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1177 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1178 (x_get_local_selection, x_reply_selection_request)
1179 (x_handle_selection_request, wait_for_property_change):
1180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1181 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1182 short is wide enough.
1183 (x_send_client_event): Don't assume fixnum fits in int.
1184 * xterm.c (x_x_to_emacs_modifiers):
1185 Don't assume EMACS_INT overflows nicely into int.
1186 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1187 may come from Lisp.
1188 (handle_one_xevent): NATNUMP can eval its arg twice.
1189 (x_connection_closed):
1190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1191 * xterm.h: Adjust decls to match defn changes elsewhere.
1192 (struct scroll_bar): Use struct vectorlike_header
1193 rather than rolling our own approximation.
1194 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1195
c6574eb5
GM
11962012-05-25 Glenn Morris <rgm@gnu.org>
1197
1198 * lisp.mk (lisp): Update for more files being compiled now.
1199
e8d32c7e
SM
12002012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1201
48def666
SM
1202 * lread.c: Remove `read_pure' which makes no difference.
1203 (read_pure): Remove var.
1204 (unreadpure): Remove function.
1205 (readevalloop): Don't call read_list with -1 flag.
1206 (read1, read_vector): Don't test read_pure any more.
1207 (read_list): Simplify.
1208
e8d32c7e
SM
1209 * fileio.c, character.h: Minor style tweaks.
1210
4b2addb7
DA
12112012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1212
1213 * window.h (clip_changed): Remove useless declaration.
1214
584461b2
JB
12152012-05-22 Juanma Barranquero <lekktu@gmail.com>
1216
1217 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1218 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1219
34374650
PE
12202012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 Remove src/m/*.
1223 This directory predates autoconf and is no longer needed nowadays.
1224 Move its few remaining bits of functionality to where they're needed.
1225 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1226 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1227 * m/template.h: Remove.
1228 * Makefile.in (M_FILE): Remove. All uses removed.
1229 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1230 * lisp.h (USE_LSB_TAG):
1231 * mem-limits.h (EXCEEDS_LISP_PTR):
1232 Use VAL_MAX, not VALBITS, in #if.
1233 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1234 (EMACS_UINT): Define unconditionally now.
1235 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1236 (BITS_PER_EMACS_INT): New constants, replacing
1237 what used to be in config.h, but not useful in #if.
1238 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1239 define them any more.
1240 (VAL_MAX): New macro.
1241 (VALMASK): Use it.
1242 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1243 BITS_PER_EMACS_INT, in #if.
1244 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1245 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1246 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1247 * s/ms-w32.h (DATA_START):
1248 Move here from removed file m/intel386.h.
1249 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1250 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1251
261cb4bb
PE
12522012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1253
1254 Assume C89 or later.
1255 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1256 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1257 (xrealloc):
1258 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1259 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1260 * textprop.c, tparam.c (NULL): Remove.
1261 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1262 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1263 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1264 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1265 * xterm.c (input_signal_count): Assume volatile works.
1266
ff23cd9f
KB
12672012-05-21 Ken Brown <kbrown@cornell.edu>
1268
1269 * xgselect.c (xg_select): Fix first argument in call to 'select'
1270 (bug#11508).
1271
1b170bc6
KB
12722012-05-20 Ken Brown <kbrown@cornell.edu>
1273
1274 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1275 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1276
b2f4d39f
KB
12772012-05-19 Ken Brown <kbrown@cornell.edu>
1278
1279 * xfns.c (x_in_use): Remove `static' qualifier.
1280 * xterm.h (x_in_use): Declare.
1281 * xgselect.c: Include xterm.h.
1282 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1283 and `display_arg' (bug#9754).
1284
003fdae2
PE
12852012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1286
9232a6d9
PE
1287 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1288
003fdae2
PE
1289 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1290 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1291
784b56e2
EZ
12922012-05-18 Eli Zaretskii <eliz@gnu.org>
1293
1294 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1295
1296 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1297 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1298
1299 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1300 reference to image_cache->refcount.
1301 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1302
a0a79cde
JL
13032012-05-17 Juri Linkov <juri@jurta.org>
1304
1305 * search.c (Fword_search_regexp, Fword_search_backward)
1306 (Fword_search_forward, Fword_search_backward_lax)
1307 (Fword_search_forward_lax): Move functions to isearch.el
1308 (bug#10145, bug#11381).
1309
b0572523
PE
13102012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1313
9660f5fc
SM
13142012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1315
1316 * lread.c (init_obarray): Declare Qt and Qnil as special.
1317
4374de83
GM
13182012-05-14 Glenn Morris <rgm@gnu.org>
1319
1320 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1321 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1322
dc44c39a
PE
13232012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1324
078c97cb
PE
1325 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1326
dc44c39a
PE
1327 * unexaix.c: Port to more-recent AIX compilers.
1328 (report_error, report_error_1, make_hdr, copy_sym)
1329 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1330 Make arguments const char *, not char *, to avoid violations of C
1331 standard and to fix some AIX warnings reported by Gilles Pion.
1332
e18afed7 13332012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1334
1335 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1336 already have overlays loaded.
1337 (handle_single_display_spec): Before returning without displaying
1338 fringe bitmap, synchronize the bidi iterator with the main display
1339 iterator, by calling iterate_out_of_display_property.
1340 (iterate_out_of_display_property): Detect buffer iteration by
1341 testing that it->string is a Lisp string.
1342 (get_next_display_element): When the current object is exhausted,
1343 and there's something on it->stack, call set_iterator_to_next to
1344 proceed with what's on the stack, instead of returning zero.
1345 (set_iterator_to_next): If called at the end of a Lisp string,
1346 proceed to consider_string_end without incrementing string
1347 position. Don't increment display vector index past the end of
1348 the display vector. (Bug#11417)
c8fb9dc6
EZ
1349 (pos_visible_p): Don't report a position visible when move_it_to
1350 stopped at the last line of window, which happens to be scanned
1351 backwards by the bidi iteration. (Bug#11464)
ac268e67 1352
e18afed7 13532012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1354
1355 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1356 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1357 are on a TTY, and thus unable to display on the fringes.
1358 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1359 so we need to signal to the caller that this is a "replacing"
1360 display spec. This fixes display when the spec is invalid or we
1361 are on a TTY.
1362
e18afed7 13632012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1364
1365 * unexaix.c (make_hdr): Fix typo in prototype.
1366 This bug broke the build on AIX. Problem reported by Gilles Pion.
1367
9d0a235a
MA
13682012-05-14 Michael Albinus <michael.albinus@gmx.de>
1369
1370 * keyboard.c (kbd_buffer_get_event): Read special events also in
1371 batch mode. (Bug#11415)
1372
9e6b06ed
GM
13732012-05-12 Glenn Morris <rgm@gnu.org>
1374
1375 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1376
c1a1d7a3
EZ
13772012-05-12 Eli Zaretskii <eliz@gnu.org>
1378
1379 * lisp.mk (lisp): Add newcomment.elc.
1380
3fe7cdc8
GM
13812012-05-12 Glenn Morris <rgm@gnu.org>
1382
1383 * Makefile.in (MKDIR_P): New, set by configure.
1384 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1385
53f7d2c0
PE
13862012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 Remove unused function hourglass_started.
1389 * dispextern.h (hourglass_started):
1390 * w32fns.c (hourglass_started):
1391 * xdisp.c (hourglass_started): Remove.
1392
75aafb17
JB
13932012-05-10 Juanma Barranquero <lekktu@gmail.com>
1394
1395 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1396 Update dependencies.
1397
12959e8e
PE
13982012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1399
97107e2e
PE
1400 * xgselect.c (xg_select): Put maxfds+1 into a var.
1401 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1402
12959e8e
PE
1403 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1404
836d29b3
DA
14052012-05-10 Dave Abrahams <dave@boostpro.com>
1406
1407 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1408 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1409
5cb67954
MA
14102012-05-09 Michael Albinus <michael.albinus@gmx.de>
1411
1412 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1413 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1414 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1415 Initialize xd_registered_buses.
1416
3478ec45
PE
14172012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1418
b263a6b0
PE
1419 Untag more efficiently if USE_LSB_TAG.
1420 This is based on a proposal by YAMAMOTO Mitsuharu in
1421 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1422 For an admittedly artificial (nth 8000 longlist) benchmark on
1423 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1424 Emacs's overall text size by 1%.
1425 * lisp.h (XUNTAG): New macro.
1426 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1427 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1428 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1429 * eval.c (Fautoload):
1430 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1431 * frame.h (XFRAME): Use XUNTAG.
1432
3478ec45
PE
1433 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1434 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1435 Remove unportable assumptions about print widths of types like
1436 dbus_uint32_t.
1437 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1438 intptr_t when converting between pointer and integer, to avoid GCC
1439 warnings about wrong width.
1440
666b903b 14412012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1442
1443 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1444 stack for each reader_thread, instead of defaulting to 8MB
1445 determined by the linker. This avoids failures in creating
1446 subprocesses on Windows 7, see the discussion in this thread:
1447 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1448
b120cc17
JC
14492012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1450
1451 Fix up display of the *Minibuf-0* buffer in the mini window.
1452 * keyboard.c (read_char): Don't clear the echo area if there's no
1453 message to clear.
1454 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1455 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1456
9a4b36f8
MA
14572012-05-07 Michael Albinus <michael.albinus@gmx.de>
1458
1459 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1460 batch mode.
1461
e5f9458f
CY
14622012-05-06 Chong Yidong <cyd@gnu.org>
1463
1464 * lisp.mk (lisp): Update.
1465
eceeb5fc 14662012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1467
1468 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1469
71873e2b
SM
14702012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1471
1472 * data.c (PUT_ERROR): New macro.
1473 (syms_of_data): Use it. Add new error type `user-error'.
1474 * undo.c (user_error): New function.
1475 (Fprimitive_undo): Use it.
1476 * print.c (print_error_message): Adjust print style for `user-error'.
1477 * keyboard.c (user_error): New function.
1478 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1479
ab0fa4e4
PE
14802012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 Do not limit current-time-string to years 1000..9999.
1483 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1484 (Fcurrent_time_string): Support any year that is supported by the
1485 underlying localtime representation. Don't use asctime, as it
1486 has undefined behavior for years outside the range -999..9999.
1487
7ed806a7
PE
14882012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 Fix race conditions involving setenv, gmtime, localtime, asctime.
1491 Without this fix, interrupts could mess up code that uses these
1492 nonreentrant functions, since setting TZ invalidates existing
1493 tm_zone or tzname values, and since most of these functions return
1494 pointers to static storage.
1495 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1496 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1497 Grow the critical sections to include not just invoking
1498 localtime/gmtime, but also accessing these functions' results
1499 including their tm_zone values if any, and any related TZ setting.
1500 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1501 so that the struct tm is saved in the critical section.
1502 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1503 motivated by the fact that memory allocation needs to be outside
1504 the critical section.
1505
0c16dfed
DA
15062012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1507
1508 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1509 with RESET_INTERVAL.
1510
1511 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1512 Remove duplicated buffer name initialization.
1513
3f83ace8
JM
15142012-05-02 Jim Meyering <jim@meyering.net>
1515
1516 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1517
c7b8541e
JM
1518 * xfns.c (x_window): Use xstrdup (Bug#11375).
1519
90207a15 15202012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1521
1522 * xdisp.c (pos_visible_p): If already at a newline from the
1523 display string before the 'while' loop, don't walk back the glyphs
1524 from it3.glyph_row. Solves assertion violation when the display
1525 string begins with a newline (egg.el). (Bug#11367)
1526
b593d6a9
AH
15272012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1528
1529 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1530 Move to simple.el.
1531
4737362e
GM
15322012-05-01 Glenn Morris <rgm@gnu.org>
1533
99cf43f9
GM
1534 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1535 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1536 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1537 All were removed before 23.1.
1538
9311dcff
GM
1539 * dispnew.c: Remove HAVE_LIBNCURSES test;
1540 it is always true on relevant platforms.
1541
4d5c6349
GM
1542 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1543 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1544
4737362e
GM
1545 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1546
74dd3a6b
AS
15472012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1548
1549 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1550 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1551 Remove.
1552
13c379ee
PE
15532012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 Do not avoid creating empty evaporating overlays (Bug#9642).
1556 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1557 That is, do not delete an evaporating overlay if it becomes
1558 empty after its bounds are adjusted to fit within its buffer.
1559 This fix caused other problems, and I'm reverting it until we get
1560 to the bottom of them.
1561
a8e7d6d7 15622012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1563
1564 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1565
a8e7d6d7 15662012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1567
1568 * xdisp.c (pos_visible_p): If the window start position is beyond
1569 ZV, start the display from buffer beginning. Prevents assertion
1570 violation in init_iterator when the minibuffer window is scrolled
1571 via the scroll bar.
1572
1573 * window.c (window_scroll_pixel_based): Likewise.
1574
a8e7d6d7 15752012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1576
1577 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1578
a8e7d6d7 15792012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1580
1581 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1582 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1583
a8e7d6d7 15842012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1585
b593d6a9
AH
1586 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1587 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1588
1c6900d9
EZ
15892012-04-26 Eli Zaretskii <eliz@gnu.org>
1590
4c3fa1d9
EZ
1591 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1592 display element, check also the underlying string or buffer
1593 character. (Bug#11341)
1594
1c6900d9
EZ
1595 * w32menu.c: Include w32heap.h.
1596 (add_menu_item): If the call to AppendMenuW (via
1597 unicode_append_menu) fails, disable Unicode menus only if we are
1598 running on Windows 9X/Me.
1599
42bf8205
AS
16002012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1601
1602 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1603 (xgetint): Add missing shift for LSB tags.
1604
b1bac16e
MR
16052012-04-24 Martin Rudalics <rudalics@gmx.at>
1606
1607 * keyboard.c (read_char): Don't wipe echo area for select window
1608 events: These might get delayed via `mouse-autoselect-window'
1609 (Bug#11304).
1610
d69621cc
JB
16112012-04-24 Juanma Barranquero <lekktu@gmail.com>
1612
1613 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1614 manipulation of :loaded-from data.
1615
02fd101b
JB
16162012-04-23 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1619 now a cons (bug#11311).
1620
888bec30
PE
16212012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1622
89a438bd
PE
1623 Do not create empty overlays with the evaporate property (Bug#9642).
1624 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1625 if it becomes empty after its bounds are adjusted to fit within
1626 its buffer. Without this fix, in a nonempty buffer (let ((o
1627 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1628 yields an empty overlay that has the evaporate property, which is
1629 not supposed to happen.
1630
1068fe4d
PE
1631 Fix minor GTK3 problems found by static checking.
1632 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1633 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1634 (struct _EmacsFixedClass, emacs_fixed_get_type):
1635 Move decls here from emacsgtkfixed.h, since they needn't be public.
1636 (emacs_fixed_get_type): Now static.
1637 (emacs_fixed_class_init): Omit unused local.
1638 (emacs_fixed_child_type): Remove; unused.
1639 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1640 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1641 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1642 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1643 (EMACS_FIXED_GET_CLASS): Remove; unused.
1644 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1645
888bec30
PE
1646 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1647 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1648
de85e130
PE
16492012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1650
d0baac98 1651 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1652 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1653 (__malloc_size_t, __malloc_ptrdiff_t):
1654 Remove. All uses removed, replaced by the definiens if needed,
1655 since we can assume C89 or better now.
1656 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1657 (protect_malloc_state, align, get_contiguous_space)
1658 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1659 (malloc_atfork_handler_child, malloc_enable_thread)
1660 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1661 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1662 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1663 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1664 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1665 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1666 Define using prototypes, not old style.
1667 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1668 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1669 (align): Don't assume that signed integer overflow wraps around.
1670 Omit unused local var.
1671 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1672 (_free_internal_nolock, memalign, mallochook, reallochook):
1673 Omit no-longer-needed casts.
1674 (valloc): Use getpagesize, not __getpagesize.
1675 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1676 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1677
de85e130
PE
1678 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1679
dcbf5805
MA
16802012-04-22 Michael Albinus <michael.albinus@gmx.de>
1681
1682 Move functions from C to Lisp. Make non-blocking method calls
1683 the default. Implement further D-Bus standard interfaces.
1684
1685 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1686 (QCdbus_request_name_allow_replacement)
1687 (QCdbus_request_name_replace_existing)
1688 (QCdbus_request_name_do_not_queue)
1689 (QCdbus_request_name_reply_primary_owner)
1690 (QCdbus_request_name_reply_in_queue)
1691 (QCdbus_request_name_reply_exists)
1692 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1693 (QCdbus_registered_serial, QCdbus_registered_method)
1694 (QCdbus_registered_signal): New Lisp objects.
1695 (XD_DEBUG_MESSAGE): Use sizeof.
1696 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1697 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1698 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1699 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1700 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1701 (xd_signature, xd_append_arg): Allow float for integer types.
1702 (xd_get_connection_references): New function.
b593d6a9
AH
1703 (xd_get_connection_address): Rename from xd_initialize.
1704 Return cached address.
dcbf5805
MA
1705 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1706 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1707 level.
1708 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1709 Return number of refcounts.
dcbf5805
MA
1710 (Fdbus_get_unique_name): Make stronger parameter check.
1711 (Fdbus_message_internal): New defun.
1712 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1713 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1714 (Fdbus_send_signal, Fdbus_register_service)
1715 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1716 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1717 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1718 (Vdbus_compiled_version, Vdbus_runtime_version)
1719 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1720 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1721 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1722 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1723 Adapt docstring.
dcbf5805 1724
52828e02
PE
17252012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1726
da05bc4c
PE
1727 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1728 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1729 Do not assume ptrdiff_t is the same width as 'int'.
1730
52828e02
PE
1731 * alloc.c: Handle unusual debugging option combinations.
1732 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1733 since the two debugging options are incompatible.
1734 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1735 is defined.
1736 (mem_init, mem_insert, mem_insert_fixup):
1737 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1738 (NEED_MEM_INSERT): Remove; no longer needed.
1739
f01769f9
LL
17402012-04-22 Leo Liu <sdl.web@gmail.com>
1741
1742 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1743
5790543d
PE
17442012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 * sysdep.c [__FreeBSD__]: Minor cleanups.
1747 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1748 Use Emacs indenting style more consistently. Avoid some casts.
1749 Use 'double' consistently rather than mixing 'float' and 'double'.
1750
b91b7e4d
EW
17512012-04-21 Eduard Wiebe <usenet@pusto.de>
1752
b593d6a9
AH
1753 * sysdep.c (list_system_processes, system_process_attributes):
1754 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1755
6114eb15
AS
17562012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1757
1758 * lisp.mk (lisp): Update.
1759
2f38dff7
PE
17602012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1763 It is never used otherwise.
1764
4ae29f89
SM
17652012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1766
1767 * print.c (print_preprocess): Only check print_depth if print-circle
1768 is nil.
1769 (print_object): Check for cycles even when print-circle is nil and
1770 print-gensym is t, but only check print_depth if print-circle is nil.
1771
f30d612a
CY
17722012-04-20 Chong Yidong <cyd@gnu.org>
1773
1774 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1775 set the status to "failed" and ensure that sentinel is run.
1776
c07a4c0b 17772012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1778
1779 * process.c (Fset_process_inherit_coding_system_flag)
1780 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1781 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1782
c07a4c0b 17832012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1784
1785 * xdisp.c (string_buffer_position_lim): Limit starting position to
1786 BEGV.
1787 (set_cursor_from_row): If called for a mode-line or header-line
1788 row, return zero immediately.
1789 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1790 farther than the first row after the header line, if any.
1791 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1792 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1793
c07a4c0b 17942012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1795
4ae29f89
SM
1796 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1797 (bug#11238).
ad3a2b41 1798
c07a4c0b 17992012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 18002012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1801
1802 configure: new option --enable-gcc-warnings (Bug#11207)
1803 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1804 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1805 (ALL_CFLAGS): Use new macros rather than old.
1806 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1807 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1808 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1809 -Wunused-result, -Wunused-variable. This should go away once
1810 the Emacs and Gnulib regex code is merged.
1811 (xmalloc, xrealloc): Now static.
1812
aba027e8
PE
18132012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1814
1815 * dired.c (Fsystem_groups): Remove unused local.
1816
e5a36063
GM
18172012-04-17 Glenn Morris <rgm@gnu.org>
1818
1819 * dired.c (Fsystem_users): Doc fix.
1820
316411f0
DA
18212012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1822
1823 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1824 (syms_of_dired): Add them.
1825
9426aba4
PE
18262012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1827
b62a57be
PE
1828 Fix minor alloc.c problems found by static checking.
1829 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1830 New extern decls, to avoid calling undeclared functions.
1831 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1832 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1833 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1834 (NEED_MEM_INSERT): New macro.
1835 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1836 Remove one incorrect comment and fix another.
b62a57be 1837
3539f31f
PE
1838 Fix minor ralloc.c problems found by static checking.
1839 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1840 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1841 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1842 (r_alloc_sbrk): Now static.
1843
a041960a
PE
1844 Improve ralloc.c interface checking.
1845 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1846 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1847 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1848 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1849 [REL_ALLOC]: ... to here, to check interface.
1850 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1851 Remove decls. This fixes an "It stinks!".
1852
9426aba4
PE
1853 * alloc.c (which_symbols): Fix alignment issue / type clash.
1854
d55c12ed
AS
18552012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1856
1857 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1858 (struct Lisp_Misc_Any): Likewise.
1859 (struct Lisp_Free): Likewise.
1860 * alloc.c (union aligned_Lisp_Symbol): Define.
1861 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1862 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1863 (union aligned_Lisp_Misc): Define.
1864 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1865 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1866 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1867
b948ce8b
PE
18682012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1871 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1872 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1873 * s/netbsd.h, s/sol2-6.h:
1874 Remove definition of GC_MARK_STACK, since the default now works.
1875 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1876 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1877 no longer the default.
1878 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1879
35dc09a1 18802012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1881
35dc09a1
GM
1882 * lread.c (lisp_file_lexically_bound_p):
1883 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1884
35dc09a1
GM
18852012-04-14 Eli Zaretskii <eliz@gnu.org>
1886
1887 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1888 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1889
18902012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1891
1892 * nsterm.m (constrainFrameRect): Always constrain when there is only
1893 one screen (Bug#10962).
1894
bcd86815
KB
18952012-04-13 Ken Brown <kbrown@cornell.edu>
1896
1897 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1898
c25df26e
RT
18992012-04-13 Reuben Thomas <rrt@sc3d.org>
1900
1901 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1902
0fc59f1e
DC
19032012-04-11 Daniel Colascione <dancol@dancol.org>
1904
1905 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1906 against is gone. It's better to use vfork now so that when Cygwin
1907 gains a new, working vfork, we use it automatically (bug#10398).
1908
de8c03dc
SM
19092012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1910
1911 * window.c (save_window_save): Obey window-point-insertion-type.
1912
2f097256
GM
19132012-04-11 Glenn Morris <rgm@gnu.org>
1914
1915 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1916
453b951e
SM
19172012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1918
1919 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1920
75f1671a 19212012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1922
1923 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1924 (force_quit_count): New var.
1925 (handle_interrupt): Use it.
1926
2a8ce227
JB
19272012-04-10 Juanma Barranquero <lekktu@gmail.com>
1928
1929 * w32.c (w32_delayed_load): Record the full path of the library
1930 being loaded (bug#10424).
1931
935396c0
GM
19322012-04-09 Glenn Morris <rgm@gnu.org>
1933
05920a43
GM
1934 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1935 not just in the obarray, before snarfing them. (Bug#11036)
1936
935396c0
GM
1937 * Makefile.in ($(leimdir)/leim-list.el):
1938 Pass EMACS rather than BUILT_EMACS.
1939
a18ecafa
TZ
19402012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1941
1942 * process.c (make_process):
1943 * process.h: Add integer `gnutls_handshakes_tried' member to
1944 process struct.
1945
6bbef4e5
JC
1946 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1947 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1948
1949 * gnutls.c (gnutls_log_function2i): Convenience log function.
1950 (emacs_gnutls_read): Use new log functions,
1951 `gnutls_handshakes_tried' process member, and
1952 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1953 attempts per process (connection).
1954
b4d3bc10
CY
19552012-04-09 Chong Yidong <cyd@gnu.org>
1956
1957 * eval.c (Fuser_variable_p, user_variable_p_eh)
1958 (lisp_indirect_variable): Functions deleted.
1959 (Fdefvar): Caller changed.
1960
1961 * callint.c (Finteractive, Fcall_interactively):
1962 * minibuf.c (Fread_variable): Callers changed.
1963
70f4d973
EZ
19642012-04-09 Eli Zaretskii <eliz@gnu.org>
1965
1966 * xdisp.c (set_cursor_from_row): If the display string appears in
1967 the buffer at position that is closer to point than the position
1968 after the display string, display the cursor on the first glyph of
1969 the display string. Fixes cursor display when a 'display' text
1970 property immediately follows invisible text. (Bug#11094)
1971
cb3c2e3e
PE
19722012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 composite.c: use 'double' consistently
1975 * composite.c (get_composition_id): Use 'double' consistently
1976 instead of converting 'float' to 'double' and vice versa; this is
1977 easier to understand and avoids a GCC warning.
1978
fd06db5d
GM
19792012-04-09 Glenn Morris <rgm@gnu.org>
1980
50fe702a
GM
1981 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1982 preparation for dumping it with emacs. (Bug#4789)
1983 (leimdir): New variable.
1984 ($(leimdir)/leim-list.el): New rule.
1985 (emacs$(EXEEXT)): Depend on leim-list.el.
1986
fd06db5d
GM
1987 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1988 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1989 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1990
55c131ee
AS
19912012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1992
1993 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1994 proper alignment.
1995
9209588f
JB
19962012-04-07 Juanma Barranquero <lekktu@gmail.com>
1997
1998 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1999 Remove unused local variable.
2000
e3fb2efb
PE
20012012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2004 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2005 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2006 objects, as mark_maybe_pointer will catch them otherwise.
2007 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2008 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2009
b5385551
PE
20102012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 Fix typo that broke non-Windows builds.
2013 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2014
9078ead6
EZ
20152012-04-07 Eli Zaretskii <eliz@gnu.org>
2016
2017 Support building on MS-Windows with libxml2.
2018
2019 * makefile.w32-in (OBJ2): Add xml.$(O).
2020 (GLOBAL_SOURCES): Add xml.c.
2021 ($(BLD)/xml.$(O)): New dependency list.
2022
2023 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2024 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2025 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2026 [!WINDOWSNT]: New macros.
2027 (init_libxml2_functions, libxml2_loaded_p): New functions.
2028 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2029 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2030 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2031 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2032 linked in).
6bbef4e5
JC
2033 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2034 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2035 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2036
2037 * emacs.c: Don't include libxml/parser.h.
2038 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2039 xmlCleanupParser directly.
2040
2041 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2042
3811fdf3
EZ
20432012-04-07 Eli Zaretskii <eliz@gnu.org>
2044
2045 * indent.c (Fvertical_motion): If there is a display string at
2046 point, use it.vpos to compute how many lines to backtrack after
2047 move_it_to point. (Bug#11133)
2048
2f8e16b2
EZ
20492012-04-06 Eli Zaretskii <eliz@gnu.org>
2050
2051 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2052 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2053 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2054 macros related to unification of CJK characters. For the details,
2055 see the discussion following the message here:
2056 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2057
3d439cd1
CY
20582012-04-04 Chong Yidong <cyd@gnu.org>
2059
2060 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2061
8bc53d00
EZ
20622012-04-01 Eli Zaretskii <eliz@gnu.org>
2063
2064 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2065 instead of alloca. (Bug#11138)
2066
3b0512a3
AS
20672012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2068
2069 * w32menu.c (is_simple_dialog): Properly check lisp types.
2070 (Bug#11141)
2071
8427ddd2
EZ
20722012-03-31 Eli Zaretskii <eliz@gnu.org>
2073
979022ef
EZ
2074 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2075 position we get to after a call to move_it_to fails the
2076 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2077 only if we wind up in a string from display property. (Bug#11063)
2078
a6b1c7cc
EZ
2079 * window.c (Fdelete_other_windows_internal): Invalidate the row
2080 and column information about mouse highlight, so that redisplay
2081 restores it after reallocating the glyph matrices. (Bug#7464)
2082
8427ddd2
EZ
2083 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2084 string comes from a `display' text property, use the buffer
2085 position of that property as if we actually saw that position in
2086 the row's glyphs.
697ba24b
EZ
2087 (move_it_by_lines): Remove the assertion that
2088 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2089 violated when there's a before-string at the beginning of a line.
2090 (Bug#11063)
8427ddd2 2091
65a0a738
EZ
20922012-03-30 Eli Zaretskii <eliz@gnu.org>
2093
2094 * xdisp.c (append_space_for_newline): If the default face was
2095 remapped, use the remapped face for the appended newline.
2096 (extend_face_to_end_of_line): Use the remapped default face for
2097 extending the face to the end of the line.
2098 (display_line): Call extend_face_to_end_of_line when the default
2099 face was remapped. (Bug#11068)
2100
581355cc
EZ
21012012-03-29 Eli Zaretskii <eliz@gnu.org>
2102
2103 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2104
e8fc049f
SM
21052012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2106
2107 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2108
4fb9a543
GM
21092012-03-27 Glenn Morris <rgm@gnu.org>
2110
2111 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2112 Doc fixes.
2113
679910f1
KH
21142012-03-26 Kenichi Handa <handa@m17n.org>
2115
2116 * dispextern.h (struct glyph): Fix previous change. Change the
2117 bit length of glyphless.ch to 25 (Bug#11082).
2118
90d49b7f
CY
21192012-03-26 Chong Yidong <cyd@gnu.org>
2120
2121 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2122 (command_loop_1): Use it; inhibit selection update for
2123 handle-select-window too (Bug#8996).
2124
f514f6f0
FP
21252012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2126
e8fc049f 2127 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2128
bf43fa51
KH
21292012-03-25 Kenichi Handa <handa@m17n.org>
2130
2131 * dispextern.h (struct glyph): Change the bit length of
2132 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2133
8a0c01dd
EZ
21342012-03-24 Eli Zaretskii <eliz@gnu.org>
2135
2136 * s/ms-w32.h (tzname): Include time.h before redirecting to
2137 _tzname. Fixes the MSVC build. (Bug#9960)
2138
7d1c3a76
AS
21392012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2140
8ed79523
AS
2141 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2142 characters.
2143
7d1c3a76
AS
2144 * xterm.c (XTread_socket): Only modify handling_signal if
2145 !SYNC_INPUT. (Bug#11080)
2146
e99a9b8b
EZ
21472012-03-23 Eli Zaretskii <eliz@gnu.org>
2148
2149 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2150 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2151 when fetching a multibyte character consumes more bytes than
2152 CHAR_BYTES returns, due to unification of CJK characters in
2153 string_char. (Bug#11073)
2154
5063c0e1
TN
21552012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2156
2157 * process.c (wait_reading_process_output): Handle pty disconnect
2158 by refraining from sending oneself a SIGCHLD (bug#10933).
2159
9f851fbd
CY
21602012-03-22 Chong Yidong <cyd@gnu.org>
2161
2162 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2163
5063c0e1 2164 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2165 Mark string as coming from a prefix property.
2166 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2167 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2168
fb5b8aca
CY
21692012-03-21 Chong Yidong <cyd@gnu.org>
2170
2171 * xfaces.c (Vface_remapping_alist): Doc fix.
2172
62356a1b
EZ
21732012-03-20 Eli Zaretskii <eliz@gnu.org>
2174
2175 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2176 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2177 Doc fixes.
62356a1b 2178
025de85b
CY
21792012-03-20 Chong Yidong <cyd@gnu.org>
2180
2181 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2182 to reflect default non-nil value of redisplay-dont-pause.
2183
4827f94e
KH
21842012-03-19 Kenichi Handa <handa@m17n.org>
2185
2186 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2187 it fit in a valid range (Bug#11003).
2188
e50a24a2
EZ
21892012-03-18 Eli Zaretskii <eliz@gnu.org>
2190
2191 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2192 that is not from display property, accept the row as a "cursor
2193 row" if one of the string's character has a non-nil `cursor'
2194 property. Fixes cursor positioning when there are newlines in
2195 overlay strings, e.g. in icomplete.el. (Bug#11035)
2196
9af5ed87
PE
21972012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2200
d1f55f16
CY
22012012-03-12 Chong Yidong <cyd@gnu.org>
2202
2203 * eval.c (inhibit_lisp_code): Rename from
2204 inhibit_window_configuration_change_hook; move from window.c.
2205
2206 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2207 * window.c (run_window_configuration_change_hook)
2208 (syms_of_window): Callers changed.
2209
66c5eebd
CY
22102012-03-11 Chong Yidong <cyd@gnu.org>
2211
413df973
CY
2212 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2213
66c5eebd
CY
2214 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2215
1de11f56
CY
22162012-03-10 Chong Yidong <cyd@gnu.org>
2217
2218 * frame.c (other_visible_frames): Don't assume the selected frame
2219 is visible (Bug#10955).
2220
cae07000
SM
22212012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2222
2223 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2224
89c94350
JD
22252012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2226
2227 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2228 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2229 zero (Bug#10954).
2230
999dd333
GM
22312012-03-03 Glenn Morris <rgm@gnu.org>
2232
01a6dcc8 2233 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2234
de0100f2
EZ
22352012-03-02 Eli Zaretskii <eliz@gnu.org>
2236
2237 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2238 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2239 (redisplay_window, next_element_from_string): Fix typos in
2240 comments.
3e441275
EZ
2241 (redisplay_window): Pass to move_it_vertically the margin in
2242 pixels, not in screen lines.
de0100f2 2243
96a72ee9
GM
22442012-03-02 Glenn Morris <rgm@gnu.org>
2245
2246 * buffer.c (buffer-list-update-hook): Doc fix.
2247
312508d7
EZ
22482012-02-29 Eli Zaretskii <eliz@gnu.org>
2249
2250 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2251 push_it before setting up the iterator for the first overlay
2252 string, even if we have an empty string loaded.
2253 (next_overlay_string): If there's an empty string on the iterator
2254 stack, pop the stack. (Bug#10903)
2255
27f3c637
PE
22562012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2257
2258 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2259 Suggested by Stefan Monnier in
2260 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2261 * alloc.c (widen_to_Lisp_Object): New static function.
2262 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2263 and widening them to Lisp_Objects. This would work even if
2264 USE_LSB_TAG is defined and wide integers are used, which might
2265 happen in a future version of Emacs.
2266
3c9dfce6
CY
22672012-02-25 Chong Yidong <cyd@gnu.org>
2268
fa74b241
CY
2269 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2270 Doc fix.
2271
3c9dfce6
CY
2272 * xselect.c (Fx_selection_exists_p): Doc fix.
2273 (x_clipboard_manager_save_all): Print an informative message
2274 before saving to clipboard manager.
2275
9486df08
CY
22762012-02-24 Chong Yidong <cyd@gnu.org>
2277
2278 * keyboard.c (process_special_events): Handle all X selection
2279 requests in kbd_buffer, not just the next one (Bug#8869).
2280
f01d3321
CY
22812012-02-23 Chong Yidong <cyd@gnu.org>
2282
2283 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2284 call when setting menu-bar-lines and tool-bar-lines parameters.
2285 (unwind_create_frame_1): New helper function.
2286
2287 * window.c (inhibit_window_configuration_change_hook): New var.
2288 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2289 (syms_of_window): Initialize it.
f01d3321 2290
86b847b6
CY
22912012-02-22 Chong Yidong <cyd@gnu.org>
2292
2293 * xterm.c (x_draw_image_relief): Add missing type check for
2294 Vtool_bar_button_margin (Bug#10743).
2295
a59225b1
CY
22962012-02-21 Chong Yidong <cyd@gnu.org>
2297
2298 * fileio.c (Vfile_name_handler_alist): Doc fix.
2299
2300 * buffer.c (Fget_file_buffer): Protect against invalid file
2301 handler return value.
2302
310f5bd4
PE
23032012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2304
cb3a28cc
PE
2305 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2306 when computing $valmask.
2307
310f5bd4
PE
2308 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2309 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2310 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2311 It's useless in that case, and it can cause problems on hosts
2312 that allocate halves of EMACS_INT values separately.
2313 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2314 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2315 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2316 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2317 it avoids undefined behavior on hosts where shifting right by more
2318 than the word width has undefined behavior.
2319
2375c96a
CY
23202012-02-19 Chong Yidong <cyd@gnu.org>
2321
2322 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2323 (Funhandled_file_name_directory, Ffile_name_as_directory)
2324 (Fdirectory_file_name, Fexpand_file_name)
2325 (Fsubstitute_in_file_name): Protect against invalid file handler
2326 return values (Bug#10845).
2327
3eb49e71
EZ
23282012-02-18 Eli Zaretskii <eliz@gnu.org>
2329
2330 * .gdbinit (pitx): Fix incorrect references to fields of the
2331 iterator stack.
2332
7b926f3f
CY
23332012-02-17 Chong Yidong <cyd@gnu.org>
2334
2335 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2336
11273115
PE
23372012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2338
2339 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2340 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2341
c3a70e2b
CY
23422012-02-15 Chong Yidong <cyd@gnu.org>
2343
2344 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2345 marked as special. Also, starting docstrings with * is obsolete.
2346
0ca43699
AS
23472012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2348
2349 * gnutls.c (emacs_gnutls_write): Fix last change.
2350
2e8f3c56
LI
23512012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2352
2353 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2354 send_process.
2355
af70074f
SM
23562012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2357
2358 * keymap.c (Fsingle_key_description): Handle char ranges.
2359
95986d52
CY
23602012-02-12 Chong Yidong <cyd@gnu.org>
2361
afd83bd1
CY
2362 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2363 as that creates a dangerous corner case.
2364
95986d52
CY
2365 * window.c (Fdelete_window_internal): Invalidate the mouse
2366 highlight (Bug#9904).
2367
bd7da63e
GM
23682012-02-12 Glenn Morris <rgm@gnu.org>
2369
2370 * xselect.c (Fx_own_selection_internal)
2371 (Fx_get_selection_internal, Fx_disown_selection_internal)
2372 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2373 * nsselect.m (Fx_own_selection_internal)
2374 (Fx_disown_selection_internal, Fx_selection_exists_p)
2375 (Fx_selection_owner_p, Fx_get_selection_internal):
2376 Sync docs and argument specs with the xselect.c versions.
2377
77abcbc2
LI
23782012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2379
2380 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2381
90b671e2
EZ
23822012-02-11 Eli Zaretskii <eliz@gnu.org>
2383
1c0ca0b7
EZ
2384 * w32select.c (Fx_selection_exists_p): Sync doc string and
2385 argument list with xselect.c. (Bug#10783)
2386
2387 * w16select.c (Fx_selection_exists_p): Sync doc string and
2388 argument list with xselect.c. (Bug#10783)
90b671e2 2389
49241268
GM
23902012-02-10 Glenn Morris <rgm@gnu.org>
2391
2392 * fns.c (Fsecure_hash): Doc fix.
2393
f998bbe7 23942012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2395
2396 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2397
0992bd9c
CY
23982012-02-07 Chong Yidong <cyd@gnu.org>
2399
2400 * buffer.c (Fbuffer_local_variables)
2401 (buffer_lisp_local_variables): Handle unbound vars correctly;
2402 don't let Qunbound leak into Lisp.
2403
af008560
GM
24042012-02-07 Glenn Morris <rgm@gnu.org>
2405
dd605cc4
GM
2406 * image.c (Fimagemagick_types): Doc fix.
2407
af008560
GM
2408 * image.c (imagemagick-render-type): Change it from a lisp object
2409 to an integer. Move the doc here from the lisp manual.
2410 Treat all values not equal to 0 the same.
2411
1449fa1d
CY
24122012-02-06 Chong Yidong <cyd@gnu.org>
2413
2414 * doc.c (store_function_docstring): Avoid applying docstring of
2415 alias to base function (Bug#2603).
2416
3723ec07
AS
24172012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2418
2419 * .gdbinit (pp1, pv1): Remove redundant defines.
2420 (pr): Use pp.
2421
79c1cc1e
CY
24222012-02-04 Chong Yidong <cyd@gnu.org>
2423
2424 * nsterm.m: Declare a global (Bug#10694).
2425
d7f29f8e
EZ
24262012-02-04 Eli Zaretskii <eliz@gnu.org>
2427
cae07000
SM
2428 * w32.c (get_emacs_configuration_options):
2429 Include --enable-checking, if specified, in the return value.
d7f29f8e 2430
3b95a6f9
MR
24312012-02-04 Martin Rudalics <rudalics@gmx.at>
2432
2433 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2434 after rounding frame sizes. (Bug#9723)
2435
d6fa96a6
EZ
24362012-02-04 Eli Zaretskii <eliz@gnu.org>
2437
2438 * keyboard.c (adjust_point_for_property): Don't position point
2439 before BEGV. (Bug#10696)
2440
df0b2940
PE
24412012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2442
2443 Handle overflow when computing char display width (Bug#9496).
2444 * character.c (char_width): Return EMACS_INT, not int.
2445 (char_width, c_string_width): Check for overflow when
2446 computing the width; this is possible now that individual
2447 characters can have unbounded width. Problem introduced
2448 by merge from Emacs 23 on 2012-01-19.
2449
6bee44d6
MA
24502012-02-02 Michael Albinus <michael.albinus@gmx.de>
2451
2452 * dbusbind.c (Fdbus_register_method): Mention the return value
2453 :ignore in the docstring.
2454
44f92739
GM
24552012-02-02 Glenn Morris <rgm@gnu.org>
2456
1b9f60cc
GM
2457 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2458
44f92739
GM
2459 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2460 Unconditionally set to t. (Bug#10673)
2461 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2462 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2463 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2464
c5d3843c
KH
24652012-02-02 Kenichi Handa <handa@m17n.org>
2466
2467 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2468 0, do not call append_composite_glyph.
2469
159462d4 24702012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2471
2472 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2473 NULL (Bug#6988).
2474 (x_produce_glyphs): If the component of a composition is a null
2475 string, set it->pixel_width to 1 to avoid zero-width glyph.
2476
78cef877
EZ
24772012-02-01 Eli Zaretskii <eliz@gnu.org>
2478
2479 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2480 first 2 arguments are identical. This makes inserting large
2481 output from a subprocess an order of magnitude faster on
2482 MS-Windows, where all sbrk'ed memory is always contiguous.
2483
97897668
GM
24842012-01-31 Glenn Morris <rgm@gnu.org>
2485
2486 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2487 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2488 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2489
31fd3586
GM
24902012-01-29 Glenn Morris <rgm@gnu.org>
2491
2492 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2493
0e24a8b2
CY
24942012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2495
2496 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2497
cc0adcb0
CY
24982012-01-28 Chong Yidong <cyd@gnu.org>
2499
2500 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2501
acc28cb9
CY
25022012-01-26 Chong Yidong <cyd@gnu.org>
2503
9c69cfb7
CY
2504 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2505
acc28cb9
CY
2506 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2507 repeat counts (Bug#10507).
2508
48da7392
GM
25092012-01-26 Glenn Morris <rgm@gnu.org>
2510
2511 * lread.c (syms_of_lread): Doc fix.
2512
14af5f7f
CY
25132012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2514
2515 * coding.c (encode_designation_at_bol): Change return value to
2516 EMACS_INT.
2517
0b21c100
CY
25182012-01-25 Chong Yidong <cyd@gnu.org>
2519
2520 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2521
3c2907f7
CY
25222012-01-21 Chong Yidong <cyd@gnu.org>
2523
2524 * floatfns.c (Fcopysign): Make the second argument non-optional,
2525 since nil is not allowed anyway.
2526
959ad23f
AS
25272012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2528
2529 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2530 (send_process): Likewise.
2531
34a02f46
MR
25322012-01-19 Martin Rudalics <rudalics@gmx.at>
2533
2534 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2535 (Vwindow_persistent_parameters): Do not use Qstate.
2536 Rewrite doc-strings.
34a02f46 2537
1259009a 25382012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2539
2540 * character.c (char_width): New function.
70d4fdf6
GM
2541 (Fchar_width, c_string_width, lisp_string_width):
2542 Use char_width (Bug#9496).
25ed9e61 2543
6a6ee00d
MR
25442012-01-16 Martin Rudalics <rudalics@gmx.at>
2545
2546 * window.c (Vwindow_persistent_parameters): New variable.
2547 (Fset_window_configuration, save_window_save): Handle persistent
2548 window parameters.
2549
c85efaf7
EZ
25502012-01-14 Eli Zaretskii <eliz@gnu.org>
2551
2552 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2553 thrashing the stack of the thread. (Bug#9087)
2554
5944709e
PE
25552012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2558
e71f5d99
EZ
25592012-01-11 Eli Zaretskii <eliz@gnu.org>
2560
2561 * xdisp.c (rows_from_pos_range): Handle the case where the
2562 highlight ends on a newline. (Bug#10464)
2563 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2564 he end column for display of highlight that ends on a newline
2565 before a R2L line.
2566
ce316182
GM
25672012-01-11 Glenn Morris <rgm@gnu.org>
2568
2569 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2570 from load-path also when installation-directory is nil. (Bug#10208)
2571
5b43da69
GM
25722012-01-10 Glenn Morris <rgm@gnu.org>
2573
74cc8ff9
GM
2574 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2575
7d8d6e4e
GM
2576 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2577 Update template values to be closer to their typical values these days.
5b43da69 2578
a0db8d43
EZ
25792012-01-09 Eli Zaretskii <eliz@gnu.org>
2580
2581 * xdisp.c (rows_from_pos_range): Accept additional argument
2582 DISP_STRING, and accept any glyph in a row whose object is that
2583 string as eligible for mouse highlight. Fixes mouse highlight of
2584 display strings from overlays. (Bug#10464)
2585
9a0115ab 25862012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2587
b9110d6a 2588 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2589 * fileio.c (auto_saving_dir_umask): New static var.
2590 (Fmake_directory_internal): Use it.
2591 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2592 creating the directory. The old code temporarily assigns
2593 too-generous permissions to the directory.
2594 (do_auto_save_eh): Clear it.
b9110d6a 2595 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2596 that the var is always cleared.
2597
6c1bd3f3
EZ
25982012-01-07 Eli Zaretskii <eliz@gnu.org>
2599
2600 * search.c (scan_buffer): Pass character positions to
2601 know_region_cache, not byte positions. (Bug#6540)
2602
069d2b50
L
26032012-01-07 LynX <_LynX@bk.ru> (tiny change)
2604
2605 * w32.c (sys_rename): Report EXDEV when rename of a directory
2606 fails because the target is on another logical disk. (Bug#10284)
2607
75bf0d33
DB
26082012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2609
2610 * xterm.c (x_embed_request_focus): New function.
2611
2612 * xterm.h: Add prototype.
2613
2614 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2615
1c6e5a32
GM
26162012-01-05 Glenn Morris <rgm@gnu.org>
2617
2618 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2619
651e947e
EZ
26202012-01-01 Eli Zaretskii <eliz@gnu.org>
2621
2622 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2623 Load gnutls_transport_set_lowat only if GnuTLS version is below
2624 2.11.1.
2625 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2626 GnuTLS versions below 2.11.1.
2627
3778cdd8
AL
26282011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2629
2630 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2631 to the doc string advising against its use for altering the way
2632 windows are scrolled.
2633
0e5317f7
KH
26342011-12-28 Kenichi Handa <handa@m17n.org>
2635
2636 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2637 coding-system ASCII compatible only when it does not produce BOM
2638 on encoding (Bug#10383).
2639
93d5ca1f
JD
26402011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2641
2642 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2643 can scroll.
2644 (create_and_show_popup_menu): Always use menu_position_func for
2645 Gtk3 (Bug#10361).
2646
ca22b785
AS
26472011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2648
2649 * callint.c (Fcall_interactively): Don't truncate prompt string.
2650
d048e1e6
EZ
26512011-12-23 Eli Zaretskii <eliz@gnu.org>
2652
2653 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2654 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2655 resumed from there (after widening). (Bug#10360)
d048e1e6 2656
5ccaba1f
JD
26572011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2658
2659 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2660
204ee57f
JD
26612011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2662
b81d40f0
JB
2663 * nsterm.m (x_free_frame_resources):
2664 Release f->output_data.ns->miniimage.
204ee57f
JD
2665 (ns_index_color): Fix indentation. Do not retain
2666 color_table->colors[i].
2667
2668 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2669 before returning.
2670
2671 * nsfns.m (x_set_background_color): Assign return value from
2672 ns_index_color to face-background instead of NSColor*.
2673 (ns_implicitly_set_icon_type): Fix indentation.
2674 Change assignment in for loop to comparison.
2675
2676 * emacs.c (ns_pool): New variable.
2677 (main): Assign ns_pool.
2678 (Fkill_emacs): Call ns_release_autorelease_pool.
2679
2680 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2681 autorelease fdesc, release fdAttrs and tdict.
2682 (ns_get_covering_families): Release charset.
2683 (ns_findfonts): Release NSFontDescriptor created with new.
2684 (ns_uni_to_glyphs): Fix indentation.
2685 (setString): Release attrStr before assigning new value.
2686
c803b2b7
JD
26872011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2688
678f4426
JD
2689 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2690 and NS_IMPL_COCOA.
2691 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2692 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2693
cd394be1 26942011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2695
5fecd5fc
JD
2696 * nsterm.m (ns_term_init): Subscribe for notifications
2697 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2698 to method trackingNotification in EmacsMenu.
2699
2700 * nsmenu.m (trackingMenu): New variable.
3771cb17 2701 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2702 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2703 from Aquamacs (Bug#7030).
678f4426
JD
2704
27052011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2706
c803b2b7
JD
2707 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2708 (symbol_to_nsstring): Fix indentation.
2709 (ns_symbol_to_pb): New function.
cae07000
SM
2710 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2711 (Fns_rotate_cut_buffers_internal): Remove.
2712 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2713 Fns_store_cut_buffer_internal.
2714 (ns_get_foreign_selection, Fx_own_selection_internal)
2715 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2716 (Fns_get_selection_internal, Fns_store_selection_internal):
2717 Use ns_symbol_to_pb and check if return value is nil.
2718 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2719 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2720 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2721 renamed to Sns_store_selection_internal.
2722 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2723 and remove this function.
2724 (ns_handle_selection_clear): Remove, never used.
2725 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2726 here.
2727
e1b01a3a
KB
27282011-12-17 Ken Brown <kbrown@cornell.edu>
2729
2730 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2731 GID is unknown (Bug#10257).
2732
2adb6e85
PE
27332011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2734
2735 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2736 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2737 which caused a build failure on GNU/Linux IA-64. This problem was
2738 introduced by my 2011-10-07 patch.
2739
d1d7b339
JL
27402011-12-15 Juri Linkov <juri@jurta.org>
2741
2742 * image.c (imagemagick_error): New function. (Bug#10112)
2743 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2744 Use `imagemagick_error' where ImageMagick functions return
2745 `MagickFalse'.
2746 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2747 proper order.
2748
100d5755
KH
27492011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2750
2751 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2752 fill background (Bug#8992).
2753
454592a6
MR
27542011-12-13 Martin Rudalics <rudalics@gmx.at>
2755
2756 * window.c (Vwindow_combination_resize)
2757 (Vwindow_combination_limit): Use t instead of non-nil in
2758 doc-strings.
61d4b438
MR
2759 (Vrecenter_redisplay): Add first sentence of doc-string on
2760 separate line.
53524d93 2761 (Frecenter): Fix doc-string typo.
454592a6 2762
3633e3aa
KH
27632011-12-11 Kenichi Handa <handa@m17n.org>
2764
2765 * coding.c (Funencodable_char_position): Pay attention to the
2766 buffer text relocation (Bug#9389).
2767
7b9d523a 27682011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2769
7b9d523a
JD
2770 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2771 gtk_init (Bug#10100).
2772
b73189c6
EZ
27732011-12-10 Eli Zaretskii <eliz@gnu.org>
2774
2775 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2776 IT->string is nil. (Bug#10263)
2777
f7dfe5d6
JD
27782011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2779
83faebb4
JD
2780 * nsterm.h (x_free_frame_resources): Declare.
2781
f7dfe5d6
JD
2782 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2783 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2784
2785 * nsterm.h (ns_get_defaults_value): Declare.
2786
2787 * nsterm.m (ns_default): Call ns_get_defaults_value.
2788
7cd4e72c
EZ
27892011-12-09 Eli Zaretskii <eliz@gnu.org>
2790
2791 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2792 (Bug#10170)
2793
b34d7317
YM
27942011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2795
2796 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2797 that where the value of an _OBJC_* symbol points to is in the .bss
2798 section (Bug#10240).
2799
76470ad1
KH
28002011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2801
2802 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2803 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2804
745fff94
KH
28052011-12-08 Kenichi Handa <handa@m17n.org>
2806
2807 * ftfont.c (get_adstyle_property): Fix previous change
2808 (Bug#10233).
2809
6e44397c
JB
28102011-12-07 Juanma Barranquero <lekktu@gmail.com>
2811
2812 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2813 dirs from the default value of EMACSLOADPATH (bug#10208).
2814
7efa6272
GM
28152011-12-07 Glenn Morris <rgm@gnu.org>
2816
2817 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2818 installation and source directories as well. (Bug#10208)
2819
f6fc4d87
CY
28202011-12-06 Chong Yidong <cyd@gnu.org>
2821
2822 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2823
2bf26180
GM
28242011-12-06 Glenn Morris <rgm@gnu.org>
2825
2826 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2827 as an error, not just -1. (Bug#10217)
2828
3a6ad4f0
CY
28292011-12-05 Chong Yidong <cyd@gnu.org>
2830
2831 * keyboard.c (process_special_events): New function.
2832 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2833
75a3b399
PE
28342011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 * coding.c (encode_designation_at_bol): Don't use uninitialized
2837 local variable (Bug#9318).
2838
c3c9e25e
KH
28392011-12-05 Kenichi Handa <handa@m17n.org>
2840
2841 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2842 return Qnil (Bug#8046, Bug#10193).
2843
5eb05ea3
KH
28442011-12-05 Kenichi Handa <handa@m17n.org>
2845
2846 * coding.c (encode_designation_at_bol): New args charbuf_end and
2847 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2848 (coding_set_source): Return how many bytes coding->source was
2849 relocated.
2850 (coding_set_destination): Return how many bytes
2851 coding->destination was relocated.
2852 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2853 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2854
28552011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2856
2857 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2858 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2859 macro (Bug#9318).
2860
28612011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2862
2863 The following changes are to fix Bug#9318.
2864
a79703f5 2865 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2866 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2867 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2868 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2869
7dbda6df
JB
28702011-12-05 Juanma Barranquero <lekktu@gmail.com>
2871
2872 * lisp.h (process_quit_flag): Fix external declaration.
2873
6d5eb5b0
SM
28742011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2875
2876 Don't macro-inline non-performance-critical code.
2877 * eval.c (process_quit_flag): New function.
2878 * lisp.h (QUIT): Use it.
2879
a0c3fad0
JD
28802011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2881
2882 * nsfns.m (get_geometry_from_preferences): New function.
2883 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2884
6c07aac2
AS
28852011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2886
2887 * emacs.c (Qkill_emacs): Define.
2888 (syms_of_emacs): Initialize it.
2889 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2890 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2891 (quit_throw_to_read_char): Add parameter `from_signal'.
2892 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2893 * lisp.h (QUIT): Call Fkill_emacs if requested.
2894
c052ead4
JD
28952011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2896
2897 * widget.c (update_wm_hints): Return if wmshell is null.
2898 (widget_update_wm_size_hints): New function.
2899
2900 * widget.h (widget_update_wm_size_hints): Declare.
2901
2902 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2903 widget_update_wm_size_hints (Bug#10104).
2904
9e49252b
EZ
29052011-12-03 Eli Zaretskii <eliz@gnu.org>
2906
2907 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2908 before a newline, prepare the bidi iterator for consuming the
2909 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2910 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2911
02b16839
JL
29122011-12-02 Juri Linkov <juri@jurta.org>
2913
2914 * search.c (Fword_search_regexp): New Lisp function created from
2915 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2916 (Fword_search_backward, Fword_search_forward)
2917 (Fword_search_backward_lax, Fword_search_forward_lax):
2918 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2919 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2920
0068070e
SM
29212011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2922
2923 * fileio.c (Finsert_file_contents): Move after-change-function call
2924 to before the "handled:" label, since all "goto handled" appear in
2925 cases where the *-change-functions have already been properly called
2926 (bug#10117).
2927
3360a3fc
AS
29282011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2929
2930 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2931 waiting for input. (Bug#10169)
2932
73d6c093
EZ
29332011-11-30 Eli Zaretskii <eliz@gnu.org>
2934
2935 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2936 verifies glyph row's hash code--we have just reallocated the
2937 glyphs, so their contents can be complete garbage. (Bug#10164)
2938
febe6bea
JB
29392011-11-30 Juanma Barranquero <lekktu@gmail.com>
2940
2941 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2942
801a4313
EZ
29432011-11-30 Eli Zaretskii <eliz@gnu.org>
2944
2945 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2946 attributes are tested _before_ calling verify_row_hash, to protect
2947 against GCC re-ordering of the tests. (Bug#10164)
2948
2b56b87e
JD
29492011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2950
2951 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2952
2953 * xterm.c (handle_one_xevent): Only set async_visible and friends
2954 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2955 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2956 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2957
dbf31225
PE
29582011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2959
2960 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2961 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2962 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2963 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2964 All uses changed to use GCPRO1 etc.
2965 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2966 Revert to old implementation (i.e., before 2011-03-11).
2967
1305621b
YM
29682011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2969
2970 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2971 of scroll runs so as to avoid assigning disabled bogus rows and
2972 unnecessary graphics copy operations.
2973
8c9afb46
EZ
29742011-11-27 Eli Zaretskii <eliz@gnu.org>
2975
2976 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2977 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2978 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2979 (malloc, free, realloc, calloc): Redirect to e_* only when
2980 compiling Emacs.
2981
2982 * lisp.h (GCTYPEBITS): Move before first use.
2983 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2984 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2985 this macro definition.
2986
2987 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2988 _MSC_VER.
2989
54e9e3bf
JD
29902011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2991
6d5eb5b0
SM
2992 * gtkutil.c (xg_create_frame_widgets):
2993 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2994 present with Gtk+ 2.0.
2995
83aca1cb
PE
29962011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2997
2998 * fileio.c (Finsert_file_contents): Undo previous change; see
2999 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3000
5b76caa4
PE
30012011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 Rename locals to avoid shadowing.
3004 * fileio.c (Finsert_file_contents):
3005 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3006 * process.c (wait_reading_process_output):
3007 Rename inner 'proc' to 'p' to avoid shadowing.
3008 Indent for consistency with usual Emacs style.
3009
8c535114
EZ
30102011-11-25 Eli Zaretskii <eliz@gnu.org>
3011
3012 * xdisp.c (redisplay_window): If cursor row is not fully visible
3013 after recentering, and scroll-conservatively is set to a large
3014 number, scroll window by a few more lines to make the cursor fully
3015 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3016 (start_display): Don't move to the next line if the display should
3017 start at a newline that is part of a display vector or an overlay
3018 string. (Bug#10119)
8c535114 3019
fa4fdb5c
JL
30202011-11-24 Juri Linkov <juri@jurta.org>
3021
3022 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3023 after the `MagickPingImage' call. (Bug#10112)
3024
90ec88df
CY
30252011-11-23 Chong Yidong <cyd@gnu.org>
3026
3027 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3028
56e2e794
MR
30292011-11-23 Martin Rudalics <rudalics@gmx.at>
3030
3031 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3032 making another buffer current. (Bug#10114)
3033
b6e64c41
GM
30342011-11-23 Glenn Morris <rgm@gnu.org>
3035
3036 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3037
6b21de18
CY
30382011-11-23 Chong Yidong <cyd@gnu.org>
3039
3040 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3041 using it (Bug#5984).
3042
b12cd789
EZ
30432011-11-22 Eli Zaretskii <eliz@gnu.org>
3044
3045 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3046 and header-lines, as they don't have one computed for them.
3047 (Bug#10098)
3048
3049 * .gdbinit (prow): Make displayed values more self-explaining.
3050 Add row's hash code.
3051
261b6fd4
LMI
30522011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3053
3054 * process.c (wait_reading_process_output): Fix asynchrounous
3055 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3056 (wait_reading_process_output): Add comment and URL.
261b6fd4 3057
e7cfd277
JD
30582011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3059
3060 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3061
a9b9b7f5
CY
30622011-11-21 Chong Yidong <cyd@gnu.org>
3063
3064 * window.c (Fnext_window, Fprevious_window): Doc fix.
3065
b0d15b4f
SM
30662011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3067
3068 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3069
fe7a3057
JB
30702011-11-20 Juanma Barranquero <lekktu@gmail.com>
3071
3072 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3073
d2999b1a
MR
30742011-11-20 Martin Rudalics <rudalics@gmx.at>
3075
3076 * window.c (Fset_window_combination_limit): Rename argument
3077 STATUS to LIMIT.
3078 (Vwindow_combination_limit): Remove "status" from doc-string.
3079
d5ff9cd0
AS
30802011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3081
3082 * m/ibms390.h: Remove.
3083 * m/ibms390x.h: Don't include "ibms390.h".
3084
a5bb9bd3
SM
30852011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3086
3087 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3088 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3089
cd1181db
JB
30902011-11-20 Juanma Barranquero <lekktu@gmail.com>
3091
3092 * casetab.c (Fset_case_table):
3093 * charset.c (Fcharset_after): Fix typos.
3094
615a3b8d 30952011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3096
17e845af
PE
3097 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3098 Otherwise, valgrind does not work on some platforms.
3099 Problem reported by Andreas Schwab in
6a0bf43d
PE
3100 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3101 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3102 is set, removing the need for VIRT_ADDRESS_VARIES.
3103 (PURE_P): Use a more-efficient implementation that needs just one
3104 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3105 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3106 to 4 (xorl, subq, cmpq, setbe).
3107 * alloc.c (pure): Always extern now, since that's the
3108 VIRT_ADDR_VARIES behavior.
3109 (PURE_POINTER_P): Use a single comparison, not two, for
3110 consistency with the new puresize.h.
3111 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3112 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3113 Remove VIRT_ADDR_VARIES no longer needed.
3114
f8fe6f96
EZ
31152011-11-19 Eli Zaretskii <eliz@gnu.org>
3116
3117 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3118 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3119 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3120 behave as if the cursor position were at the window margin.
3121
3122 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3123 and the cursor position is out of bounds, behave as if the cursor
3124 position were at the window margin. (Bug#10075)
3125
df05a53c
CY
31262011-11-18 Chong Yidong <cyd@gnu.org>
3127
3128 * window.c (Fwindow_combination_limit): Make first argument
3129 non-optional, since it is meaningless for live windows like the
3130 selected window.
61ccba97 3131
2071918e
DA
31322011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3133
3134 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3135
b50a28de
SM
31362011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3137
3138 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3139 (graft_intervals_into_buffer): Simplify.
3140
015137db
EZ
31412011-11-18 Eli Zaretskii <eliz@gnu.org>
3142
3143 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3144 hash values of the two rows.
3145 (copy_row_except_pointers): Preserve the used[] arrays and the
3146 hash values of the two rows. (Bug#10035)
68c95424 3147 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3148
3149 * xdisp.c (row_hash): New function, body extracted from
3150 compute_line_metrics.
3151 (compute_line_metrics): Call row_hash, instead of computing the
3152 hash code inline.
3153
3154 * dispnew.c (verify_row_hash): Call row_hash for computing the
3155 hash code of a row, instead of duplicating code from xdisp.c.
3156
3157 * dispextern.h (row_hash): Add prototype.
3158
a2addb04
TH
31592011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3160
3161 * frame.c (delete_frame): Don't delete the terminal when the last
3162 X frame is closed if emacs is built with GTK toolkit.
3163
df85d315
JB
31642011-11-17 Juanma Barranquero <lekktu@gmail.com>
3165
3166 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3167
a0c2d0ae
MR
31682011-11-17 Martin Rudalics <rudalics@gmx.at>
3169
3170 * window.c (Vwindow_splits): Rename to
3171 Vwindow_combination_resize. Suggested by Juri Linkov.
3172 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3173 of Vwindow_splits.
3174
58179cce
JB
31752011-11-16 Juanma Barranquero <lekktu@gmail.com>
3176
7877f373
JB
3177 * nsfns.m (Fns_font_name):
3178 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3179
b6f67890
MR
31802011-11-16 Martin Rudalics <rudalics@gmx.at>
3181
3182 * window.h (window): Rename slot "nest" to "combination_limit".
3183 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3184 (Fset_window_nest): Rename to Fset_window_combination_limit.
3185 (Vwindow_nest): Rename to Vwindow_combination_limit.
3186 (recombine_windows, make_parent_window, make_window)
3187 (Fsplit_window_internal, saved_window)
3188 (Fset_window_configuration, save_window_save): Rename all
3189 occurrences of window_nest to window_combination_limit.
3190
c7015153
JB
31912011-11-15 Juanma Barranquero <lekktu@gmail.com>
3192
3193 * image.c (imagemagick_load_image): Fix typo.
3194
322ad6ec
EZ
31952011-11-14 Eli Zaretskii <eliz@gnu.org>
3196
3197 * xdisp.c (display_line): Move the call to
3198 highlight_trailing_whitespace before the call to
3199 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3200 faces of all the glyphs to compute ROW's hash value.
3201 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3202
f067b8ec
JB
32032011-11-14 Juanma Barranquero <lekktu@gmail.com>
3204
3205 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3206 just return (bug#10044).
3207
1e5b2111
EZ
32082011-11-12 Eli Zaretskii <eliz@gnu.org>
3209
7ef3cbd5
EZ
3210 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3211 with user-defined heap size. Bump the default size of the temacs
3212 heap to 27MB, to avoid memory warning when running temacs.
3213 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3214
1e5b2111
EZ
3215 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3216 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3217 (verify_row_hash) [XASSERTS]: New function.
3218 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3219 that the hash value of glyph rows is correct.
1e5b2111 3220
89d61221
MR
32212011-11-12 Martin Rudalics <rudalics@gmx.at>
3222
3223 * window.h (window): Remove splits slot.
3224 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3225 (Fdelete_other_windows_internal, make_parent_window)
3226 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3227 (Fset_window_configuration, save_window_save): Don't deal with
3228 split status of windows.
3229 (saved_window): Remove splits slot.
3230 (Vwindow_splits): Rewrite doc-string.
3231
97f18cc8
JD
32322011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3233
3234 * xfns.c (unwind_create_frame):
3235 * nsfns.m (unwind_create_frame):
3236 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3237 Vframe_list (Bug#9999).
3238
22a648b4
DA
32392011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3240
0b381c7e 3241 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3242
659afede
KH
32432011-11-11 Kenichi Handa <handa@m17n.org>
3244
3245 * callproc.c (Fcall_process): Set the member dst_multibyte of
3246 process_coding.
3247
9ac0394b
KH
32482011-11-11 Johan Bockgård <bojohan@gnu.org>
3249
3250 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3251 avoid a crash (bug#9496).
3252
2fbdc249
CY
32532011-11-09 Chong Yidong <cyd@gnu.org>
3254
3255 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3256 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3257
ac6b1f81
PE
32582011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3261
09db192c
PE
32622011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 Avoid some portability problems by eschewing 'extern inline' functions.
3265 The trivial performance wins aren't worth the portability hassles; see
3266 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3267 et seq.
3268 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3269 (window_box_width, window_box_left, window_box_left_offset)
3270 (window_box_right, window_box_right_offset): Undo previous change,
3271 by removing the "extern"s.
3272 * intervals.c (adjust_intervals_for_insertion)
3273 (adjust_intervals_for_deletion): Undo previous change,
3274 making these static again.
3275 (offset_intervals, temp_set_point_both, temp_set_point)
3276 (copy_intervals_to_string): No longer inline.
3277 * xdisp.c (window_text_bottom_y, window_box_width)
3278 (window_box_height, window_box_left_offset)
3279 (window_box_right_offset, window_box_left, window_box_right)
3280 (window_box): No longer inline.
3281
105216ed
CY
32822011-11-08 Chong Yidong <cyd@gnu.org>
3283
3284 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3285 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3286 Signal an error if not a live window.
105216ed
CY
3287 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3288 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3289
ae9e237f
JB
32902011-11-07 Juanma Barranquero <lekktu@gmail.com>
3291
3292 * lisp.h (syms_of_abbrev): Remove declaration.
3293 Reported by CHENG Gao <chenggao@royau.me>.
3294
c7aa8333
EZ
32952011-11-07 Eli Zaretskii <eliz@gnu.org>
3296
3297 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3298 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3299 of temacs in GUI mode.
3300
be7f5545
MR
33012011-11-07 Martin Rudalics <rudalics@gmx.at>
3302
3303 * window.h: Declare delete_all_child_windows instead of
3304 delete_all_subwindows.
3305 * window.c (Fwindow_nest, Fset_window_nest)
3306 (Fset_window_new_total, Fset_window_new_normal)
3307 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3308 (delete_all_subwindows): Rename to delete_all_child_windows.
3309 (Fdelete_other_windows_internal, Fset_window_configuration):
3310 Call delete_all_child_windows instead of delete_all_subwindows.
3311 * frame.c (delete_frame): Call delete_all_child_windows instead
3312 of delete_all_subwindows.
3313
ca78dc43
PE
33142011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3317 This is also needed for porting to any host where GC_MARK_STACK is
3318 not GC_MAKE_GCPROS_NOOPS.
3319 (which_symbols): Use it.
3320
a0241d01
KH
33212011-11-07 Kenichi Handa <handa@m17n.org>
3322
3323 * coding.c (coding_set_destination): Check coding->src_pos only
3324 when coding->src_object is a buffer (bug#9910).
3325
3326 * process.c (send_process): Set the member src_multibyte of coding
3327 to 0 (bug#9911) when sending a unibyte text.
3328
3329 * callproc.c (Fcall_process): Set the member src_multibyte of
3330 process_coding to 0 (bug#9912).
3331
a64bfdfa 33322011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3333
3334 * xmenu.c (cleanup_widget_value_tree): New function.
3335 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3336 calling free_menubar_widget_value_tree directly (Bug#9830).
3337
cb41b32a
PE
33382011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3339
3340 Fix some portability problems with 'inline'.
3341 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3342 (window_box_width, window_box_left, window_box_left_offset)
3343 (window_box_right, window_box_right_offset): Declare extern.
3344 Otherwise, these inline functions do not conform to C99 and
3345 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3347 * intervals.c (adjust_intervals_for_insertion)
3348 (adjust_intervals_for_deletion): Now extern, because otherwise the
3349 extern inline functions 'offset_intervals' couldn't refer to it.
3350 (static_offset_intervals): Remove.
3351 (offset_intervals): Rewrite using the old contents of
3352 static_offset_intervals. The old version didn't conform to C99
3353 because an extern inline function contained a reference to an
3354 identifier with static linkage.
3355
b7041366
AS
33562011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3357
3358 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3359 GC.
3360
88a37c4d
EZ
33612011-11-06 Eli Zaretskii <eliz@gnu.org>
3362
3363 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3364 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3365 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3366 return Qleft_to_right.
3367
49745b39
CY
33682011-11-06 Chong Yidong <cyd@gnu.org>
3369
3370 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3371 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3372 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3373 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3374 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3375 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3376 (Fwindow_vscroll): Doc fix.
3377 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3378 argument, since it makes no sense to pass a live window and for
3379 consistency with window-child.
3380
1f05cd82
CS
33812011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3382
3383 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3384 support MSVC.
3385
22610910
JR
33862011-11-05 Jason Rumney <jasonr@gnu.org>
3387
3388 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3389 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3390 fonts (Bug#6029).
3391 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3392 bitwise arithmetic preventing use of unicode-sip and non-truetype
3393 opentype fonts.
3394
a06776b2
EZ
33952011-11-05 Eli Zaretskii <eliz@gnu.org>
3396
3ad924ba
EZ
3397 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3398 "emacs"-only part.
3399
a06776b2
EZ
3400 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3401 initialization code to keep similarity to xfns.c after changes
3402 from 2011-11-05.
3403
c9e7db78
JD
34042011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3405
a97f8f3f
JD
3406 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3407 (unwind_create_frame): New function (Bug#9943).
3408 (Fx_create_frame): Restructure code to be more similar to the one in
3409 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3410 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3411 Move terminal->reference_count++ just before making the frame official
3412 (Bug#9943).
3413
3414 * nsterm.m (x_free_frame_resources): New function.
3415 (x_destroy_window): Move code to x_free_frame_resources.
3416
c9e7db78 3417 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3418 (Fx_create_frame, x_create_tip_frame):
3419 Move terminal->reference_count++ just before making the frame
75f1671a 3420 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3421 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3422
a6fc3b5c
EZ
34232011-11-05 Eli Zaretskii <eliz@gnu.org>
3424
3425 Support MSVC build with newer versions of Visual Studio.
3426 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3427 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3428 nt/gmake.defs.
3429
3430 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3431 which are not supported by MSVC.
3432 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3433 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3434 bitfields.
3435 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3436 types in bitfields.
3437 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3438
3439 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3440
58179cce 34412011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3442
3443 Support MSVC build with newer versions of Visual Studio.
3444 * w32.c: Don't include w32api.h for MSVC.
3445 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3446
3447 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3448 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3449 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3450 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3451 e_* cousins.
3452 (alloca) [_MSC_VER]: Define to _alloca.
3453
3454 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3455
3456 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3457
a58c13ed
EZ
34582011-11-04 Eli Zaretskii <eliz@gnu.org>
3459
3460 * xdisp.c (note_mouse_highlight): If either of
3461 previous/next-single-property-change returns nil, treat that as
3462 the beginning or the end of the buffer. (Bug#9955)
3463
fe0b6370
JD
34642011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3465
a58c13ed 3466 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3467 label is not null (Bug#9951).
3468 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3469 may be NULL.
3470
89bd5ee1
EZ
34712011-11-04 Eli Zaretskii <eliz@gnu.org>
3472
3473 * window.c (Fwindow_body_size): Mention in the doc string that the
3474 return value is in frame's canonical units. (Bug#9949)
3475
84c3edb9
EZ
34762011-11-03 Eli Zaretskii <eliz@gnu.org>
3477
4e2fb5c7
EZ
3478 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3479
84c3edb9 3480 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3481 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3482 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3483
bc17a887
EZ
34842011-11-01 Eli Zaretskii <eliz@gnu.org>
3485
3486 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3487 Don't stop backward scan on the continuation glyph, even though
3488 its CHARPOS is positive.
6d5eb5b0
SM
3489 (mouse_face_from_buffer_pos, note_mouse_highlight):
3490 Rename cover_string to disp_string.
bc17a887 3491
4ee88440
MR
34922011-11-01 Martin Rudalics <rudalics@gmx.at>
3493
3494 * window.c (temp_output_buffer_show): Don't use
3495 Vtemp_buffer_show_specifiers.
3496 (Vtemp_buffer_show_specifiers): Remove unused variable.
3497
c2ff3c02
EZ
34982011-10-30 Eli Zaretskii <eliz@gnu.org>
3499
3500 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3501 past the beginning of the current glyph matrix.
3502
58179cce 35032011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3504
3505 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3506 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3507 HAVE_GTK3 (Bug#9869).
b77a6a7f 3508
3b574623
JD
3509 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3510 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3511
b77a6a7f
JD
3512 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3513
3514 * xterm.c: Declare x_handle_net_wm_state to return int.
3515 (handle_one_xevent): Check if we are iconified but don't have
3516 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3517 (get_current_wm_state): Return non-zero if not hidden,
3518 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3519 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3520 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3521 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3522
196e41e4
PE
35232011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3526 so that this new function doesn't get optimized away by a
3527 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3528
021f2e1a
AS
35292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3530
3531 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3532
8b058d44
EZ
35332011-10-29 Eli Zaretskii <eliz@gnu.org>
3534
3535 Fix the `xbytecode' command.
3536 * .gdbinit (xprintbytestr): New command.
b50a28de 3537 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3538 (xbytecode): Print the byte-code string as well.
3539
4452fb80
EZ
35402011-10-29 Kim Storm <storm@cua.dk>
3541
8b058d44
EZ
3542 * alloc.c (which_symbols): New function.
3543
21b72067
AS
35442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3545
3546 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3547 line. (Bug#9903)
3548
83ed7b5c
GM
35492011-10-29 Glenn Morris <rgm@gnu.org>
3550
3551 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3552 Not clear what it was for, and it causes various bugs. (Bug#9839)
3553
5a7a728b
EZ
35542011-10-28 Eli Zaretskii <eliz@gnu.org>
3555
3556 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3557 possible random value that matches one of those tested as
3558 condition to clear the mouse face.
3559
d3d0842f
CY
35602011-10-28 Chong Yidong <cyd@gnu.org>
3561
3562 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3563
31b39d13
DN
35642011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3565
3566 * window.c (make_window): Initialize phys_cursor_on_p.
3567
9aba6043
SM
35682011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3569
3570 * lisp.h (struct Lisp_Symbol): Update comments.
3571
c20992f4
JB
35722011-10-28 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3575
db4f02f2
EZ
35762011-10-28 Eli Zaretskii <eliz@gnu.org>
3577
3578 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3579 <oslsachem@gmail.com> for helping to debug this.
3580
3581 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3582 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3583 (g_b_init_get_glyph_outline_w): New static variables.
3584 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3585 (GetGlyphOutlineW_Proc): New typedefs.
3586 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3587 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3588 New functions.
3589 (w32font_open_internal, compute_metrics):
3590 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3591 instead of calling the "wide" APIs directly.
3592
3593 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3594
3595 * w32.h (syms_of_w32font): Add prototype.
3596
87e68db4
JB
35972011-10-27 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3600 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3601 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3602 (Fmove_to_window_line): Doc fix.
3603
435c1d67
CY
36042011-10-27 Chong Yidong <cyd@gnu.org>
3605
3606 * process.c (make_process): Set gnutls_state to NULL.
3607
3608 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3609 non-NULL, regardless of GNUTLS_INITSTAGE.
3610 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3611 an error. Set process slots as soon as we allocate them.
3612
3613 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3614
9c6c6f49
CY
36152011-10-27 Chong Yidong <cyd@gnu.org>
3616
9aba6043
SM
3617 * gnutls.c (emacs_gnutls_deinit): New function.
3618 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3619 (Fgnutls_deinit, Fgnutls_boot): Use it.
3620
3621 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3622 (deactivate_process): Call emacs_gnutls_deinit.
3623
657d08d3
JB
36242011-10-27 Juanma Barranquero <lekktu@gmail.com>
3625
3626 * image.c (x_create_x_image_and_pixmap):
3627 * w32.c (sys_rename, w32_delayed_load):
3628 * w32font.c (fill_in_logfont):
3629 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3630
5430d399
JB
36312011-10-26 Juanma Barranquero <lekktu@gmail.com>
3632
3633 * w32fns.c (w32_default_color_map): New function,
3634 extracted from Fw32_default_color_map.
a7ef684b 3635 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3636
fe0055fa
PE
36372011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3640
e6346438
SM
36412011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3642
3643 * keyboard.c (test_undefined): New function (bug#9751).
3644 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3645
e112cc37
ET
36462011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3647
3648 * sysdep.c (init_sys_modes): Fix the check for the controlling
3649 terminal (Bug#6649).
3650
7b5d6677
EZ
36512011-10-20 Eli Zaretskii <eliz@gnu.org>
3652
3653 * dispextern.h (struct bidi_it): New member next_en_type.
3654
3655 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3656 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3657 current character, check also for next_en_type being WEAK_EN.
3658 (bidi_resolve_weak): Don't enter the expensive loop if the current
3659 position is before next_en_pos. Record the bidi type of the first
3660 non-ET, non-BN character we find, in addition to its position.
3661 (bidi_level_of_next_char): Invalidate next_en_type when
3662 next_en_pos is over-stepped.
3663
7da0b018
PE
36642011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3665
3666 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3667 * editfns.c: Rewrite current-time-zone so that it invokes
3668 the equivalent of (format-time-string "%Z") to get the time zone name.
3669 This fixes a bug when the time zone name contains characters that
3670 need converting from the system time locale to Emacs internal format.
3671 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3672 that patch fixed format-time-string to do the conversion, but
3673 I forgot to fix current-time-zone.
3674 (format_time_string): New function, containing most of
3675 what Fformat_time_string used to contain.
3676 (Fformat_time_string): Rewrite in terms of format_time_string.
3677 This doesn't change this function's behavior.
3678 (current-time-zone): Rewrite to use format_time_string.
3679 This fixes the bug reported by Michael Schierl in
3680 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3681 Jason Rumney's 2007-06-07 change worked around this bug, but
3682 didn't fix it.
3683 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3684
8547b010
EZ
36852011-10-19 Eli Zaretskii <eliz@gnu.org>
3686
3687 * xdisp.c (start_display): If the character at POS is displayed
3688 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3689 (try_window_reusing_current_matrix): If a line ends in a display
3690 vector or the next line starts in a display vector, continue
3691 redrawing the window even though the character position of
3692 start_row was reached.
8547b010
EZ
3693 (Bug#9771, part 2)
3694
4e948d15
CY
36952011-10-18 Chong Yidong <cyd@gnu.org>
3696
3697 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3698 with nobreak-char-display too.
3699
4787455f
EZ
37002011-10-18 Eli Zaretskii <eliz@gnu.org>
3701
3702 Fix part 3 of bug#9771.
3703 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3704 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3705 non-neutral characters if the current character is a paragraph
3706 separator (a.k.a. Newline). This avoids running the same
3707 expensive loop twice, once when we consume the preceding newline
3708 and the other time when the line actually needs to be displayed.
3709 Avoid the loop when we see neutrals on the base embedding level
3710 following a character whose directionality is the same as the
3711 paragraph's. This avoids running the expensive loop when a line
3712 ends in a long sequence of neutrals, like control characters.
3713 Add assertion against STRONG_AL type. Slightly rearrange code
3714 that determines the type of a neutral given the first non-neutral
3715 that follows it.
3716 (bidi_level_of_next_char): Set next_en_pos to zero when
3717 invalidating its info.
3718
2c91f553
EZ
37192011-10-17 Eli Zaretskii <eliz@gnu.org>
3720
3721 * xdisp.c (push_display_prop): Determine whether to record string
3722 or buffer position by IT->string, not by IT->method. Allow
3723 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3724 (move_it_vertically_backward): Don't look for character position
3725 immediately after the newline when in a continuation line.
3726 (Bug#9771, part 1)
2c91f553 3727
c7b08b0d
MR
37282011-10-15 Martin Rudalics <rudalics@gmx.at>
3729
3730 * window.c (coordinates_in_window): Rewrite and delabelize
3731 vertical border check. (Bug#5357) (Bug#9618)
3732
6b02f655
SM
37332011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3734
3735 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3736 errors in XSetWindowBorder (bug#9310).
3737
81d40c92
DA
37382011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3739
3740 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3741 avoid crash when xmalloc overrun checking is enabled.
3742
d4172c3b
EZ
37432011-10-13 Eli Zaretskii <eliz@gnu.org>
3744
3745 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3746 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3747 cursor motion with <left> and <right> arrow keys.
3748
3749 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3750 some callers set that themselves.
3751
b00eea75
EZ
37522011-10-12 Eli Zaretskii <eliz@gnu.org>
3753
3754 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3755 display string and the previous row comes from the same string and
3756 is empty. (Bug#9739) (Bug#9738)
3757
8fe012c4
SM
37582011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3759
3760 * doc.c (get_doc_string): Encode file name (bug#9735).
3761
0074aef2
EZ
37622011-10-12 Eli Zaretskii <eliz@gnu.org>
3763
79beb178
EZ
3764 * bidi.c (bidi_level_of_next_char):
3765 * xdisp.c (get_visually_first_element): Remove old incorrect
3766 comments regarding the Unicode Line Separator character.
3767
0074aef2
EZ
3768 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3769
6e4b3fbe
DA
37702011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3771
3772 * alloc.c (Fgc_status): Do not access beyond zombies array
3773 boundary if nzombies > MAX_ZOMBIES.
3774 * alloc.c (dump_zombies): Add missing format specifier.
3775
0324f3af
PE
37762011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3777
b5525cac
PE
3778 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3779 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3780
0324f3af
PE
3781 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3782 Some packages use them to denote characters with modifiers.
3783
e9b5f888
AS
37842011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3785
3786 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3787 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3788 matching a pp-number. Rename parameter var to var1.
3789
127827c0
SM
37902011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3791
3792 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3793
c8fd3bd0
GM
37942011-10-08 Glenn Morris <rgm@gnu.org>
3795
3796 * callint.c (Fcall_interactively): Give a more explicit error for the
3797 'c' case with a non-character input. (Bug#8479)
3798
352ec8ff
EZ
37992011-10-08 Eli Zaretskii <eliz@gnu.org>
3800
03669ccb
EZ
3801 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3802 lines.
7061c986
EZ
3803 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3804 lines that are hscrolled on the left.
03669ccb 3805
352ec8ff
EZ
3806 * dispnew.c (buffer_posn_from_coords): Account for a possible
3807 presence of header-line. (Bug#4426)
3808
a66cfb1c
SM
38092011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3810
6b02f655
SM
3811 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3812 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3813
7c5ee88e
PE
38142011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3817 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3818 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3819 this makes Emacs dump core during garbage collection on rare
3820 occasions. sizeof is obviously inferior to offsetof here, so
3821 stick with offsetof.
3822 (GC_POINTER_ALIGNMENT): New macro.
3823 (mark_memory): Omit 3rd (offset) arg; caller changed.
3824 Don't assume EMACS_INT alignment is the same as pointer alignment.
3825
df1bbe5b
SM
38262011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3827
3828 * keyboard.c (read_key_sequence_remapped): New var.
3829 (read_key_sequence): Compute remapping in the right buffer.
3830 (command_loop_1): Use read_key_sequence's remapping directly.
3831
51553db6
SM
38322011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3833
32c1fffd
SM
3834 * dired.c (file_name_completion): Don't expand file name.
3835 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3836 before checking file name handler.
3837
51553db6
SM
3838 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3839 they've been requested explicitly (bug#9591).
3840
b6bd1599 38412011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3842
3843 * keymap.c (Fsingle_key_description): Use make_specified_string
3844 instead of build_string to build string from push_key_description.
3845 (Bug#5193)
3846
f701dc2a
PE
38472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3848
4222c55d
PE
3849 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3850 This fixes a Y2038 bug on 64-bit hosts.
3851 * buffer.c (reset_buffer):
3852 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3853 (Fclear_buffer_auto_save_failure):
3854 Use 0, not -1, to represent an unset failure time, since time_t
3855 might not be signed.
3856
f701dc2a
PE
3857 Remove dependency on glibc malloc internals.
3858 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3859 Move back here from lisp.h, but with their new implementations.
3860 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3861 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3862 * charset.c (charset_table_init): New static var.
3863 (syms_of_charset): Use it instead of xmalloc. This removes a
3864 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3865 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3866 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3867 Move back to alloc.c.
3868 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3869 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3870
9ceebf39
JD
38712011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3872
3873 * nsterm.m (windowDidResize): Call x_set_window_size only when
3874 ns_in_resize is true. Otherwise set pixelwidth/height and
3875 call change_frame_size (Bug#9628).
3876
cb993c58
PE
38772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3878
3930c88b
PE
3879 Port --enable-checking=all to Fedora 14 x86-64.
3880 * charset.c (syms_of_charset): Also account for glibc malloc's
3881 internal overhead when calculating the initial malloc maximum.
3882
cb993c58
PE
3883 Port --enable-checking=all to Fedora 14 x86.
3884 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3885 Move to lisp.h.
3886 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3887 (overrun_check_realloc, overrun_check_free):
3888 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3889 That way, xmalloc returns a properly-aligned pointer even if
3890 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3891 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3892 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3893 into account when calculating the initial malloc maximum.
3894 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3895 Move here from alloc.c, so that charset.c can use it too.
3896 Properly align; the old code wasn't right for common 32-bit hosts
3897 when configured with --enable-checking=all.
3898 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3899 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3900
31bed486
EZ
39012011-09-29 Eli Zaretskii <eliz@gnu.org>
3902
04c70788 3903 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3904 use EDOM.
3905
fbcaa2f3
EZ
39062011-09-28 Eli Zaretskii <eliz@gnu.org>
3907
3908 * xdisp.c (compute_display_string_end): If there's no display
3909 string at CHARPOS, return -1.
3910
3911 * bidi.c (bidi_fetch_char): When compute_display_string_end
3912 returns a negative value, treat the character as a normal
3913 character not covered by a display string. (Bug#9624)
3914
a239d4e9
JB
39152011-09-28 Juanma Barranquero <lekktu@gmail.com>
3916
3917 * lread.c (Fread_from_string): Fix typo in docstring.
3918
88652fd5
EZ
39192011-09-27 Eli Zaretskii <eliz@gnu.org>
3920
3921 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3922 newline, reseat the iterator instead of bidi-iterating there one
3923 character at a time. (Bug#9610)
32c1fffd
SM
3924 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3925 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3926
ed497dd4
AS
39272011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3928
3929 * lread.c (readevalloop): Use correct code for NBSP.
3930 (read1): Likewise. (Bug#9608)
3931
b2bf61aa
MA
39322011-09-25 Michael Albinus <michael.albinus@gmx.de>
3933
3934 * dbusbind.c (Fdbus_register_signal): When service is not
3935 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3936
32bbb17c
GM
39372011-09-25 Glenn Morris <rgm@gnu.org>
3938
3939 * buffer.c (truncate-lines): Doc fix.
3940
94e0933e
CY
39412011-09-24 Chong Yidong <cyd@stupidchicken.com>
3942
3943 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3944 (Fset_window_next_buffers): Doc fix.
3945
cddde921
GM
39462011-09-24 Glenn Morris <rgm@gnu.org>
3947
3948 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3949
1260aef1
PE
39502011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3951
25b4bfa0
PE
3952 Fix minor problems found by static checking.
3953 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3954 * indent.c (Fvertical_motion): Fix == vs = typo.
3955
e3cbd34b
EZ
39562011-09-24 Eli Zaretskii <eliz@gnu.org>
3957
a66cfb1c
SM
3958 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3959 Default value is now t. Doc fix.
6bf7006f 3960
e3cbd34b 3961 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3962 logic when moving up, not only when moving down. Fix the
e3cbd34b 3963 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3964 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3965
3966 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3967 CHARPOS is covered by a display string which includes newlines.
3968 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3969 is covered by a display string with embedded newlines.
3970
a3de0cbd
MA
39712011-09-24 Michael Albinus <michael.albinus@gmx.de>
3972
3973 * dbusbind.c (Fdbus_register_signal): Add match rule to
3974 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3975 (Fdbus_register_method, Vdbus_registered_objects_table):
3976 Fix docstring.
a3de0cbd 3977
b260039d
JM
39782011-09-24 Jim Meyering <meyering@redhat.com>
3979
32c1fffd 3980 do not ignore write error for any output size
b260039d
JM
3981 The previous change was incomplete.
3982 While it makes emacs --batch detect the vast majority of stdout
3983 write failures, errors were still ignored whenever the output size is
3984 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3985 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3986 && echo FAIL: ignored write error
3987 FAIL: ignored write error
3988 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3989 && echo FAIL: ignored write error
3990 FAIL: ignored write error
3991 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3992
8eca8a7c
AS
39932011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3994
3995 * emacs.c (Fkill_emacs): In noninteractive mode exit
3996 non-successfully if a write error occurred on stdout. (Bug#9574)
3997
3341db62
EZ
39982011-09-21 Eli Zaretskii <eliz@gnu.org>
3999
4000 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4001 the xassert test.
4002
4003 * dispextern.h (struct it): Update the comment documenting what
4004 can it->OBJECT be.
4005
8c203dbf
EZ
40062011-09-20 Eli Zaretskii <eliz@gnu.org>
4007
4008 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4009 a display string, extend search for cursor position to end of row.
4010 (find_row_edges): If the row ends in a newline from a display
4011 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4012 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4013 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4014 non-empty line. Fixes confusing cursor motion with arrow keys at
4015 the beginning of a line that starts with whitespace.
8c203dbf 4016
a4824228
LMI
40172011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4018
4019 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4020 (bug#9493).
4021
33ed493b
CY
40222011-09-18 Chong Yidong <cyd@stupidchicken.com>
4023
4024 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4025 boolean (Bug#9154).
4026
56cd55c8
EZ
40272011-09-18 Eli Zaretskii <eliz@gnu.org>
4028
4029 * xdisp.c (display_line): Record maximum and minimum buffer
4030 positions even if no glyphs were produced (e.g., by a zero-width
4031 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4032 buffer positions that will be removed from the glyph row because
4033 they don't fit.
c02dcedf
EZ
4034 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4035 column is beyond frame width: don't subtract 1 "pixel" when
4036 computing width of the stretch.
3e62b7e0
EZ
4037 (reseat_at_next_visible_line_start): Undo the change made on
4038 2011-09-17 that saved paragraph information and restored it after
4039 the call to `reseat'. (Bug#9545)
56cd55c8 4040
5ed99d36 40412011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4042
4043 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4044 and turn window cursor on if cleared (Bug#9415).
4045
5ed99d36 40462011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4047
4048 * search.c (boyer_moore): Take unibyte characters from pattern
4049 literally. (Bug#9458)
4050
9bade7b2
EZ
40512011-09-18 Eli Zaretskii <eliz@gnu.org>
4052
4053 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4054
e5e9d610
PE
40552011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4056
87e4427a
PE
4057 Fix minor problem found by static checking.
4058 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4059 initialized, to pacify gcc -Wuninitialized.
4060
e5e9d610
PE
4061 * fileio.c: Report proper errno when syscall falls.
4062 (Finsert_file_contents): Save and restore errno,
4063 so that report_file_error outputs the correct diagnostic.
4064 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4065
a1674f0b
EZ
40662011-09-18 Eli Zaretskii <eliz@gnu.org>
4067
4068 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4069
fbfb6dd4
EZ
40702011-09-17 Eli Zaretskii <eliz@gnu.org>
4071
4072 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4073 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4074
bb187662
EZ
40752011-09-17 Eli Zaretskii <eliz@gnu.org>
4076
1137e8b8 4077 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4078 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4079
4080 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4081 (bidi_find_paragraph_start): Search back for paragraph beginning
4082 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4083 (bidi_move_to_visually_next): Only trigger paragraph-related
4084 computations when the last character is a newline or at EOB, not
4085 just any NEUTRAL_B. (Bug#9470)
4086
bb187662
EZ
4087 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4088 truncated lines if point is covered by a display string. (Bug#9524)
4089
2e621251
PE
40902011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4091
4092 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4093 (cons_to_x_long): New function.
4094 (lisp_data_to_selection_data): Use it. Correct the test for
4095 short-versus-long data; it was negated. Break out of vector
4096 loop, for efficiency, when a long datum is discovered.
4097
91a15bc6
SM
40982011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4099
4100 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4101
b41c3a35
EZ
41022011-09-16 Eli Zaretskii <eliz@gnu.org>
4103
4104 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4105 GCC PR/17406) by declaring this function with external scope.
4106
7812ba2d
PE
41072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4108
4109 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4110 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4111
cf7edc2a
AS
41122011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4113
4114 * editfns.c (Fformat): Correctly handle text properties on "%%".
4115
bd01620e
EZ
41162011-09-15 Eli Zaretskii <eliz@gnu.org>
4117
4118 * xterm.c (x_draw_composite_glyph_string_foreground):
4119 * w32term.c (x_draw_composite_glyph_string_foreground):
4120 * term.c (encode_terminal_code):
4121 * composite.c (composition_update_it, get_composition_id):
4122 * xdisp.c (get_next_display_element)
4123 (fill_composite_glyph_string): Add comments about special meaning
4124 of TAB characters in a composition.
4125
a02719a3
PE
41262011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4127
4128 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4129 This occurs when processing a multibyte format.
4130 Problem reported by Wolfgang Jenker.
a02719a3 4131
72589a3c
JB
41322011-09-15 Johan Bockgård <bojohan@gnu.org>
4133
4134 * xdisp.c (try_cursor_movement): Only check for exact match if
4135 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4136
1c14176c
PE
41372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4138
4139 Remove unused external symbols.
4140 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4141 * xdisp.c (calc_pixel_width_or_height): Now static.
4142 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4143 * indent.c (check_display_width):
4144 * w32term.c: Fix comment to match code.
4145 * xterm.c, xterm.h (x_catching_errors): Remove.
4146
d2eea5b5
PE
41472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4148
4149 * xselect.c: Use signed conversions more consistently (Bug#9498).
4150 (selection_data_to_lisp_data): Assume incoming selection data are
4151 signed integers, not unsigned. This is to be consistent with
4152 outgoing selection data, which was modified to use signed integers
4153 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4154 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4155 expects long, not unsigned long.
4156
46888499
EZ
41572011-09-14 Eli Zaretskii <eliz@gnu.org>
4158
4159 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4160 computation of loop end. Reported by Johan Bockgård
4161 <bojohan@gnu.org>.
4162
ef8ef9fb
CY
41632011-09-13 Chong Yidong <cyd@stupidchicken.com>
4164
4165 * frame.c (Fother_visible_frames_p): Function deleted.
4166
fa819fed
EZ
41672011-09-12 Eli Zaretskii <eliz@gnu.org>
4168
4169 * indent.c (compute_motion): Process display vector front to back
4170 rather than the other way around. (Bug#2496)
4171
2ba8e008
SM
41722011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4173
4174 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4175
20f53c69
CY
41762011-09-11 Chong Yidong <cyd@stupidchicken.com>
4177
4178 * minibuf.c (Fread_from_minibuffer): Doc fix.
4179
d562d7a4
EZ
41802011-09-11 Eli Zaretskii <eliz@gnu.org>
4181
4182 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4183 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4184
1c4d7f3d
LMI
41852011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4186
4187 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4188 value for non-existent files.
4189
b885bf36
EZ
41902011-09-11 Eli Zaretskii <eliz@gnu.org>
4191
4192 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4193 set its "size" to -1. This will set the modtime_size field of
4194 the corresponding buffer to -1, which is what
4195 verify-visited-file-modtime expects for files that do not exist.
4196 (Bug#9139)
4197
6612f0bf
PE
41982011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4199
4200 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4201 here ...
4202 * lisp.h: ... from here. push_key_description is no longer
4203 defined in keyboard.c, so its declaration should not be in
4204 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4205 logically belongs with push_key_description.
4206
dfb3f755
PE
42072011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4208
4209 * buffer.h: Include <sys/types.h> instead of <time.h>.
4210 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4211 Problem reported by Herbert J. Skuhra.
4212
3134906c
LMI
42132011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4214
4215 * xml.c (parse_region): Make the parsing work for
4216 non-comment-starting XML files again (bug#9144).
4217
8d903f4e
AS
42182011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4219
4220 * image.c (gif_load): Fix calculation of bottom and right corner.
4221 (Bug#9468)
4222
80ad64f4
EZ
42232011-09-10 Eli Zaretskii <eliz@gnu.org>
4224
4225 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4226 redisplay in small windows.
4227
208a048d
EZ
42282011-09-09 Eli Zaretskii <eliz@gnu.org>
4229
4230 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4231
9b1c252e
MR
42322011-09-08 Martin Rudalics <rudalics@gmx.at>
4233
4234 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4235 Operate on live windows only.
4236
2949f33b
JB
42372011-09-08 Juanma Barranquero <lekktu@gmail.com>
4238
4239 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4240
e08dcafd
EZ
42412011-09-07 Eli Zaretskii <eliz@gnu.org>
4242
4243 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4244 only under bidi iteration.
4245
115b96bd
JD
42462011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4247
4248 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4249
c8199d0f
PE
42502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4253 Without this fix, the command to link temacs failed due to an
4254 undefined symbol __builtin_isnan. This is because
4255 /usr/include/iso/math_c99.h #defines isnan(x) to
4256 __builtin_isnan(x), but the bundled gcc, which identifies itself
4257 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4258 a __builtin_isnan.
4259 * floatfns.c (isnan): #undef, and then #define to a clone of
4260 what's in data.c.
4261 (Fisnan): Always define, since it's always available now.
4262 (syms_of_floatfns): Always define isnan at the Lisp level.
4263
e39b275c 42642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4265
4266 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4267
b2db44d9 42682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4269
f4af5137 4270 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4271 The previous code assumed that file offsets (off_t values) fit in
4272 EMACS_INT variables, which is not true on typical 32-bit hosts.
4273 The code messed up by falsely reporting buffer overflow in cases
4274 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4275 when "big" contains more than 2**29 bytes, even though this
4276 inserts just one byte and does not overflow the buffer.
4277 (Finsert_file_contents): Store file offsets as off_t
4278 values, not as EMACS_INT values. Check for overflow when
4279 converting between EMACS_INT and off_t. When checking for
4280 buffer overflow or for overlap, take the offsets into account.
4281 Don't use EMACS_INT for small values where int suffices.
4282 When checking for overlap, fix a typo: ZV was used where
4283 ZV_BYTE was intended.
4284 (Fwrite_region): Don't assume off_t fits into 'long'.
4285 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4286
ecfc0a49
MA
42872011-09-05 Michael Albinus <michael.albinus@gmx.de>
4288
4289 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4290
6511acf2 42912011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4292
0999621a 4293 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4294
4295 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4296 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4297 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4298 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4299 (modify_event_symbol): Do not assume that the length of
4300 name_alist_or_stem is safe to alloca and fits in int.
4301 (Fexecute_extended_command): Likewise for function name and binding.
4302 (Frecursion_depth): Wrap around reliably on integer overflow.
4303 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4304 since some callers pass EMACS_INT values.
4305 (Fsingle_key_description): Don't crash if symbol name contains more
4306 than MAX_ALLOCA bytes.
4307 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4308 (get_minibuffer): Arg is now EMACS_INT, not int.
4309 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4310 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4311 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4312
2be7d702
PE
4313 * dbusbind.c (signature_cat): New function.
4314 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4315 Do not overrun buffer; instead, report string overflow.
4316
9d1df220
PE
4317 * dispnew.c (add_window_display_history): Don't overrun buffer.
4318 Truncate instead; this is OK since it's just a log.
4319
33ef5c64
PE
4320 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4321 even if the time zone offset is outlandishly large.
4322 Don't mishandle offset == INT_MIN.
4323
66c6fdd5
PE
4324 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4325 when creating daemon; the previous buffer-overflow check was incorrect.
4326
d749b01b
PE
4327 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4328 which has the guts of the old verror function.
4329
b5cd1905
PE
4330 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4331 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4332
6e1a67fb
PE
4333 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4334 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4335 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4336 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4337 length of string rather than counting it via multiple sprintfs;
4338 that's simpler and more reliable.
c21721cc
PE
4339 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4340 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4341 sprintf, in case result does not fit in int.
4342
c57b67fc
PE
4343 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4344 (fontset_from_font): Print it.
4345
8a401434
PE
4346 * frame.c (tty_frame_count): Now printmax_t, not int.
4347 (make_terminal_frame, set_term_frame_name): Print it.
4348 (x_report_frame_params): In X, window IDs are unsigned long,
4349 not signed long, so print them as unsigned.
4350 (validate_x_resource_name): Check for implausibly long names,
4351 and don't assume name length fits in 'int'.
4352 (x_get_resource_string): Don't blindly alloca invocation name;
4353 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4354 not fit in int.
4355
6e1a67fb
PE
4356 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4357 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4358 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4359
0df02bf3
PE
4360 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4361 Use esprintf, not sprintf, in case result does not fit in int.
4362
48e30793
PE
4363 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4364 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4365 it as a large positive number.
4366 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4367 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4368
a66ff6d8
PE
4369 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4370 in case result does not fit in int.
4371
aca216ff
PE
4372 * print.c (float_to_string): Detect width overflow more reliably.
4373 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4374 buffer overrun. Don't assume list length fits in 'int'. Treat
4375 print length of 0 as 0, not as infinity; to be consistent with other
4376 uses of print length in this function. Don't overflow print length
4377 index. Don't assume hash table size fits in 'long', or that
4378 vectorlike size fits in 'unsigned long'.
4379
31c286f7
PE
4380 * process.c (make_process): Use printmax_t, not int, to format
4381 process-name gensyms.
4382
55e5faa1
PE
4383 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4384
80f2e268
PE
4385 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4386 to avoid potential buffer overrun.
4387
670741ab
PE
4388 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4389 if X resource line is longer than 512 bytes.
4390
b7163a50
PE
4391 * xfns.c (x_window): Make sprintf buffer a bit bigger
4392 to avoid potential buffer overrun.
4393
ae58ff1f
PE
4394 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4395
c43c8a6a
PE
4396 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4397
3f8236f4
PE
43982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4399
53e9fe90 4400 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4401 Without these, Emacs silently mishandles large integers sometimes.
4402 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4403 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4404
6511acf2
PE
4405 * xdisp.c (try_window_id): Check Emacs fixnum range before
4406 converting to 'int'.
806add1d 4407
6511acf2 4408 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4409 Check that an Emacs fixnum is in range before assigning it to 'int'.
4410 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4411 values converted from Emacs fixnums.
4412 (Frecenter): Don't wrap around a line count if it is out of 'int'
4413 range; instead, treat it as an extreme value.
4414 (Fset_window_configuration, compare_window_configurations):
4415 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4416
6511acf2
PE
4417 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4418 that can exceed INT_MAX. Check that EMACS_INT value is in range
4419 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4420 (match_limit): Don't assume that a fixnum can fit in 'int'.
4421
6511acf2 4422 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4423 exceed INT_MAX.
4424
6511acf2 4425 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4426 (Fvertical_motion): Don't wrap around LINES values that don't fit
4427 in 'int'. Instead, treat them as extreme values. This is good
4428 enough for windows, which can't have more than INT_MAX lines anyway.
4429
fcb901a7
LMI
44302011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4431
0f2f6b6d
LMI
4432 * Require libxml/parser.h to avoid compilation warning.
4433
fcb901a7
LMI
4434 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4435
4436 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4437 since this reportedly can destroy thread storage.
4438
6e20a0d4
CY
44392011-08-30 Chong Yidong <cyd@stupidchicken.com>
4440
4441 * syntax.c (find_defun_start): Update all cache variables if
4442 exiting early (Bug#9401).
4443
148ae00e
EZ
44442011-08-30 Eli Zaretskii <eliz@gnu.org>
4445
f6cfbd8f
EZ
4446 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4447
148ae00e
EZ
4448 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4449 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4450 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4451
4452 * term.c (tty_append_glyph): New function.
4453 (produce_stretch_glyph): Static function and its prototype deleted.
4454
a66cfb1c
SM
4455 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4456 Add prototypes.
148ae00e 4457
c4a07a4c
PE
44582011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4459
4460 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4461 when checking :margin (Bug#9390).
4462 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4463 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4464 so that the name doesn't mislead. All uses changed.
4465
6bc8cd65
JB
44662011-08-28 Johan Bockgård <bojohan@gnu.org>
4467
4468 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4469 set_tty_hooks.
4470
dca4927e
EZ
44712011-08-27 Eli Zaretskii <eliz@gnu.org>
4472
4473 * xdisp.c (move_it_to): Don't bail out early when reaching
4474 position beyond to_charpos, if we are scanning backwards.
4475 (move_it_vertically_backward): When DY == 0, make sure we get to
4476 the first character in the line after the newline.
4477
f2cad773
PE
44782011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4479
4480 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4481 (ccl_driver): Do not generate an out-of-range pointer.
4482 (Fccl_execute_on_string): Remove unnecessary check for
4483 integer overflow, noted by Stefan Monnier in
4484 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4485 Remove a FIXME that didn't need fixing.
4486 Simplify the newly-introduced buffer reallocation code.
4487
0cae2cdb
JB
44882011-08-27 Juanma Barranquero <lekktu@gmail.com>
4489
4490 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4491
5fc295a4 44922011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4493
70c60eb2 4494 Integer and memory overflow issues (Bug#9196).
726e0ab1 4495
d31850da
PE
4496 * doc.c (get_doc_string): Rework so that
4497 get_doc_string_buffer_size is the actual buffer size, rather than
4498 being 1 less than the actual buffer size; this makes xpalloc more
4499 convenient.
4500
a69fbedb
PE
4501 * image.c (x_allocate_bitmap_record, cache_image):
4502 * xselect.c (Fx_register_dnd_atom):
4503 Simplify previous changes by using xpalloc.
4504
fe5c5d37
PE
4505 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4506 since either will do and ptrdiff_t is convenient with xpalloc.
4507
0065d054
PE
4508 * charset.c (charset_table_size)
4509 (struct charset_sort_data.priority): Now ptrdiff_t.
4510 (charset_compare): Don't overflow if priorities differ greatly.
4511 (Fsort_charsets): Don't assume list length fits in int.
4512 Check for size-calculation overflow when allocating sort data.
4513 (syms_of_charset): Allocate an initial charset table that is
4514 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4515
4516 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4517
4518 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4519 The actual value is always <= INT_MAX, and leaving it unsigned made
4520 overflow checking harder.
4521
4522 * dispextern.h (struct glyph_matrix.rows_allocated)
4523 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4524 with xpalloc. The values are still always <= INT_MAX.
4525
4526 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4527
4528 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4529 (SAFE_NALLOCA): New macro.
4530
4531 * region-cache.c (struct boundary.pos, find_cache_boundary)
4532 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4533 (set_cache_region, invalidate_region_cache)
4534 (revalidate_region_cache, know_region_cache, region_cache_forward)
4535 (region_cache_backward, pp_cache):
4536 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4537 so that ptrdiff_t * can be passed to xpalloc.
4538 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4539 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4540 (pp_cache): Don't assume cache_len fits in int.
4541 * region-cache.h: Adjust extern decls to match.
4542
4543 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4544 EMACS_INT, since either will do, for xpalloc.
4545
4546 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4547 (xnmalloc, xnrealloc, xpalloc): New functions.
4548
726e0ab1
PE
4549 * bidi.c (bidi_shelve_header_size): New constant.
4550 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4551 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4552
51f30bc5 4553 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4554 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4555 (overlay_strings):
4556 Don't update size of array until after memory allocation succeeds,
4557 because xmalloc/xrealloc may not return.
0065d054
PE
4558 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4559 now that we have proper integer overflow checking.
4560 (record_overlay_string, overlay_strings): Catch overflows when
4561 calculating size of overlay_str_buf.
726e0ab1 4562
0065d054
PE
4563 * callproc.c (Fcall_process): Check for size overflow when
4564 calculating size of args2.
4565 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4566 Normally we prefer signed values, but sticking with ptrdiff_t would
4567 require adding more-complicated checks.
726e0ab1
PE
4568
4569 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4570 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4571 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4572 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4573
4574 * character.c (Fstring): Check for size-calculation overflow.
4575
4576 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4577 unnecessary integer overflow. Check for size overflow.
4578 (encode_coding_object): Don't update size until xmalloc succeeds.
4579
4580 * composite.c (get_composition_id): Check for overflow in glyph
4581 length calculations.
4582
4583 Integer and memory overflow fixes for display code.
4584 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4585 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4586 (scrolling_window): Check for overflow in size calculations.
4587 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4588 Don't assume glyph table len fits in int.
4589 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4590 (row_table_size): Now ptrdiff_t, not int.
4591 (scrolling_window): Avoid overflow in size calculations.
4592 Don't update size until allocation succeeds.
4593 * fns.c (concat): Check for overflow in size calculations.
4594 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4595 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4596 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4597
4598 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4599 (get_doc_string): Check for size calculation overflow.
4600 Don't update size until allocation succeeds.
4601 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4602 EMACS_INT, where ptrdiff_t will do.
4603 (Fsubstitute_command_keys): Check for string overflow.
4604
4605 * editfns.c (set_time_zone_rule): Don't assume environment length
4606 fits in int.
4607 (message_length): Now ptrdiff_t, not int.
4608 (Fmessage_box): Don't update size until allocation succeeds.
4609 Don't assume message length fits in int.
4610 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4611
0065d054
PE
4612 * emacs.c (main): Do not reallocate argv, since there is a null at
4613 the end that can be overwritten, and this way there's no need to
4614 worry about size-calculation overflow.
4615 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4616
4617 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4618 alloc succeeds.
4619 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4620
4621 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4622 (x_set_scroll_bar_width, x_figure_window_size):
4623 Check for integer overflow.
4624 (x_set_alpha): Do not assume XINT fits in int.
4625
4626 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4627 This is for the members text_lines, text_cols, total_lines, total_cols,
4628 where the system imposes an 'int' limit.
4629
4630 * fringe.c (Fdefine_fringe_bitmap):
4631 Don't update size until alloc works.
4632
4633 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4634 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4635
4636 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4637 Check for size-calculation overflow.
4638 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4639 do, as we prefer signed integers.
4640 (id_to_widget.max_size, id_to_widget.used)
4641 (xg_store_widget_in_map, xg_remove_widget_from_map)
4642 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4643 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4644 Use and return ptrdiff_t, not int.
4645 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4646 * gtkutil.h: Change prototypes to match the above.
4647
4648 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4649 are duplicate now that they've been promoted to lisp.h.
4650 (x_allocate_bitmap_record, x_alloc_image_color)
4651 (make_image_cache, cache_image, xpm_load):
4652 Don't update size until alloc is done.
4653 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4654 (x_detect_edges):
3256efce 4655 Check for size calculation overflow.
726e0ab1
PE
4656 (ct_colors_allocated_max): New constant.
4657 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4658 overflow.
3256efce 4659
726e0ab1
PE
4660 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4661 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4662 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4663 Use ptrdiff_t, not int, to count maps.
4664 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4665 calculations. Don't update size until allocation succeeds.
4666 Redo calculations to avoid overflow.
726e0ab1
PE
4667 * keyboard.h: Change prototypes to match the above.
4668
4669 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4670 to count maps.
4671 (current_minor_maps): Check for size calculation overflow.
4672 * keymap.h: Change prototypes to match the above.
4673
4674 * lread.c (read1, init_obarray): Don't update size until alloc done.
4675
4676 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4677 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4678
726e0ab1
PE
4679 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4680 Now ptrdiff_t, not int.
4681 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4682 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4683
4684 * process.c (Fnetwork_interface_list): Check for overflow
4685 in size calculation.
4686
4687 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4688
4689 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4690 overflow. Don't bother calling xmalloc when xrealloc will do.
4691
4692 * search.c (Freplace_match): Check for size calculation overflow.
4693 (Fset_match_data): Don't assume list lengths fit in 'int'.
4694
4695 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4696 for command line length. Do not attempt to address one before the
4697 beginning of an array, as that's not portable.
4698
4699 * term.c (max_frame_lines): Remove; unused.
4700 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4701 not int.
4702 (encode_terminal_code, calculate_costs): Check for size
4703 calculation overflow.
4704 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4705 table lengths and related sizes. Don't update size until alloc
4706 done. Redo calculations to avoid overflow.
4707 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4708
4709 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4710 subtracting pointers.
4711 (gobble_line): Check for overflow more carefully. Don't update size
4712 until alloc done.
4713
4714 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4715 Don't update size until alloc done.
4716 Redo size calculations to avoid overflow.
4717 Check for size calculation overflow.
0065d054 4718 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4719
4720 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4721 Use ptrdiff_t, not int, for sizes.
4722 (store_mode_line_noprop_char): Don't update size until alloc done.
4723
0065d054
PE
4724 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4725 Use ptrdiff_t, not int, for sizes.
4726 (Finternal_make_lisp_face, cache_face):
4727 Check for size calculation overflow.
4728 (cache_face): Treat size calculation overflows as if they were
4729 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4730
4731 * xfns.c (x_encode_text, x_set_name_internal)
4732 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4733 sizes, since they can exceed INT_MAX in size. Check for size
4734 calculation overflow.
4735
0065d054
PE
4736 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4737 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4738 Don't update size until alloc done.
4739
0065d054 4740 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4741 as sprintf is limited to int lengths.
1d526e2f 4742
252c5ee1
PE
4743 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4744 (X_LONG_MIN): New macros.
864d7ce7
PE
4745 Use them to make the following changes clearer.
4746 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4747 This change doesn't affect the value now, but it may help remind
4748 future maintainers not to raise the value too much later.
4749 (SELECTION_QUANTUM): Remove, replacing with ...
4750 (selection_quantum): ... new function, which avoids overflow.
4751 All uses changed.
4752 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4753 assumption that selection length fits in 'int'.
4754 (x_reply_selection_request, x_handle_selection_request)
4755 (x_get_window_property, receive_incremental_selection)
4756 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4757 (lisp_data_to_selection_data, clean_local_selection_data):
4758 Use ptrdiff_t, not int, to record length of selection.
4759 (x_reply_selection_request, x_get_window_property)
4760 (receive_incremental_selection, x_property_data_to_lisp):
4761 Redo calculations to avoid overflow.
4762 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4763 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4764 something.
4765 (x_get_window_property, receive_incremental_selection)
4766 (lisp_data_to_selection_data, x_property_data_to_lisp):
4767 Check for size-calculation overflow.
4768 (x_get_window_property, receive_incremental_selection)
4769 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4770 Don't store size until memory allocation succeeds.
4771 (x_get_window_property): Plug memory leak on memory exhaustion.
4772 Don't double-block input; malloc is safe here. Don't assume 2**34
4773 - 4 fits in unsigned long. Add an xassert to check
4774 XGetWindowProperty overflow. Be more careful about overflow
4775 calculations, and distinguish size from memory overflow better.
4776 (receive_incremental_selection): When tracing, don't assume
4777 unsigned int is less than INT_MAX.
4778 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4779 harmful) conversions of unsigned short to int.
4780 (lisp_data_to_selection_data): Don't assume that integers
4781 in the range -65535 through -1 fit in an X unsigned short.
4782 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4783 result parameters unless successful. Rely on cons_to_unsigned
4784 to report problems with elements; the old code wasn't right anyway.
4785 (x_check_property_data): Check for int overflow; we cannot use
4786 a wider type due to X limits.
4787 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4788
726e0ab1 4789 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4790
0065d054
PE
4791 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4792 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4793 (x_color_cells): Don't store size until memory allocation succeeds.
4794 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4795 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4796 (x_term_init): Don't assume length fits in int (sprintf is limited
4797 to int size).
bc18e09d 4798
ebfa62c0
PE
4799 Use ptrdiff_t for composition IDs.
4800 * character.c (lisp_string_width):
4801 * composite.c (composition_table_size, n_compositions)
4802 (get_composition_id, composition_gstring_from_id):
4803 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4804 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4805 * window.c (Frecenter):
4806 Use ptrdiff_t, not int, for composition IDs.
4807 * composite.c (get_composition_id): Check for integer overflow.
4808 * composite.h: Adjust prototypes to match the above changes.
4809
d3411f89
PE
4810 Use ptrdiff_t for hash table indexes.
4811 * category.c (hash_get_category_set):
4812 * ccl.c (ccl_driver):
4813 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4814 * coding.c (coding_system_charset_list, detect_coding_system):
4815 * coding.h (struct coding_system.id):
4816 * composite.c (get_composition_id, gstring_lookup_cache):
4817 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4818 * image.c (xpm_get_color_table_h):
4819 * lisp.h (hash_lookup, hash_put):
4820 * minibuf.c (Ftest_completion):
4821 Use ptrdiff_t for hash table indexes, not int (which is too
4822 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4823 32-bit --with-wide-int hosts).
4824
e097a6fa
PE
4825 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4826 Add a FIXME comment about memory leaks.
4827 (syms_of_charset): Don't assume xmalloc returns.
4828
5637687f
PE
4829 Don't assume that stated character widths fit in int.
4830 * character.c (Fchar_width, c_string_width, lisp_string_width):
4831 * character.h (CHAR_WIDTH):
4832 * indent.c (MULTIBYTE_BYTES_WIDTH):
4833 Use sanitize_char_width to avoid undefined and/or bad behavior
4834 with outlandish widths.
a66cfb1c 4835 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4836 now that we have two such functions. All uses changed.
4837 (sanitize_char_width): New inline function.
4838
a2271ba2
PE
4839 Don't assume that tab-width fits in int.
4840 * character.h (sanitize_width): New inline function.
4841 (SANE_TAB_WIDTH): New macro.
4842 (ASCII_CHAR_WIDTH): Use it.
4843 * indent.c (sane_tab_width): Remove. All uses replaced by
4844 SANE_TAB_WIDTH (current_buffer).
4845 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4846
18c52557
PE
4847 * fileio.c: Integer overflow issues with file modes.
4848 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4849
caeeedc1
PE
4850 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4851 Remove unreachable code.
4852 (read_hex, load_charset_map_from_file): Check for integer overflow.
4853
6df6ae42 4854 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4855 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4856 (x_send_scroll_bar_event): Likewise. Check that the size does not
4857 exceed limits imposed by XClientMessageEvent, as well as the usual
4858 ptrdiff_t and size_t limits.
4859
b13995db
PE
4860 * keyboard.c: Overflow, signedness and related fixes.
4861 (make_lispy_movement): Use same integer type in forward decl
4862 that is used in the definition.
4863 (read_key_sequence, keyremap_step):
4864 Change bufsize argument back to int, undoing my 2011-03-30 change.
4865 We prefer signed types, and int is wide enough here.
4866 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4867 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4868 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4869 length, not size_t. Use ptrdiff_t for index, not int.
4870 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4871 possibility of integer overflow.
4872
13464394
PE
4873 Overflow, signedness and related fixes for images.
4874
4875 * dispextern.h (struct it.stack[0].u.image.image_id)
4876 (struct_it.image_id, struct image.id, struct image_cache.size)
4877 (struct image_cache.used, struct image_cache.ref_count):
4878 * gtkutil.c (update_frame_tool_bar):
4879 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4880 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4881 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4882 * nsmenu.m (update_frame_tool_bar):
4883 * xdisp.c (calc_pixel_width_or_height):
4884 * xfns.c (image_cache_refcount):
4885 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4886 on typical 64-bit hosts.
4887
4888 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4889 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4890 Omit unnecessary casts to int.
4891 (parse_image_spec): Check that integers fall into 'int' range
4892 when the callers expect that.
4893 (image_ascent): Redo ascent calculation to avoid int overflow.
4894 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4895 (lookup_image): Remove unnecessary tests.
4896 (xbm_image_p): Locals are now of int, not EMACS_INT,
4897 since parse_image_check makes sure they fit into int.
4898 (png_load, gif_load, svg_load_image):
4899 Prefer int to unsigned where either will do.
4900 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4901 old tiff_error_handler and tiff_warning_handler.
4902 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4903 stack buffer overflows. It uses only the features of vsnprintf
4904 that are common to both POSIX and native Microsoft.
4905 (tiff_error_handler, tiff_warning_handler): Use it.
4906 (tiff_load, gif_load, imagemagick_load_image):
4907 Don't assume :index value fits in 'int'.
4908 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4909 (imagemagick_load_image): Check that crop parameters fit into
4910 the integer types that MagickCropImage accepts. Don't assume
4911 Vimagemagick_render_type has a nonnegative value. Don't assume
4912 size_t fits in 'long'.
4913 (gs_load): Use printmax_t to print the widest integers possible.
4914 Check for integer overflow when computing image height and width.
4915
c11821d4
EZ
49162011-08-26 Eli Zaretskii <eliz@gnu.org>
4917
4918 * xdisp.c (redisplay_window): Don't force window start if point
4919 will be invisible in the resulting window. (Bug#9324)
4920
0c95fcf7
EZ
49212011-08-25 Eli Zaretskii <eliz@gnu.org>
4922
4923 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4924 the display spec is of the form `(space ...)'.
4925 (handle_display_spec): Return the value returned by
4926 handle_single_display_spec, not just 1 or zero.
4927 (handle_single_display_spec): If the display spec is of the form
4928 `(space ...)', and specifies display in the text area, return 2
4929 rather than 1.
fee65a97 4930 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4931 accurately, and prefer exact match for point under bidi.
4932 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4933
4934 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4935 into disp_prop; all users changed.
4936
4937 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4938 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4939 for the text covered by the display property.
4940
e4ed06f1
CY
49412011-08-25 Chong Yidong <cyd@stupidchicken.com>
4942
4943 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4944 Change return value to nil.
4945 (Frecord_buffer): Delete unused function.
4946
f67cdd7f
EZ
49472011-08-24 Eli Zaretskii <eliz@gnu.org>
4948
5980d4c6
EZ
4949 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4950 buffers, return left-to-right.
8610fe8b
EZ
4951 (set_cursor_from_row): Consider candidate row a win if its glyph
4952 represents a newline and point is on that newline. Fixes cursor
4953 positioning on the newline at EOL of R2L text within L2R
4954 paragraph, and vice versa.
4955 (try_cursor_movement): Check continued rows, in addition to
4956 continuation rows. Fixes unwarranted scroll when point enters a
4957 continued line of R2L text within an L2R paragraph, or vice versa.
4958 (cursor_row_p): Consider the case of point being equal to
4959 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4960 from the end of a short line to the beginning of a continued line
4961 of R2L text within L2R paragraph.
4962 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4963 composed characters.
5980d4c6 4964
f67cdd7f
EZ
4965 * bidi.c (bidi_check_type): Use xassert.
4966 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4967 members.
4968
bca633fb
EZ
49692011-08-23 Eli Zaretskii <eliz@gnu.org>
4970
4971 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4972 a character.
4973
4a5885a7
CY
49742011-08-23 Chong Yidong <cyd@stupidchicken.com>
4975
4976 * nsfont.m (ns_otf_to_script): Fix typo.
4977
0902a04e
KH
49782011-08-22 Kenichi Handa <handa@m17n.org>
4979
4980 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4981 extra slot even if the purpose is char-code-property-table.
4982
1a2e6670
EZ
49832011-08-23 Eli Zaretskii <eliz@gnu.org>
4984
8ddde651
EZ
4985 * xdisp.c (redisplay_window): When computing centering_position,
4986 account for the height of the header line. (Bug#8874)
4987
425cc014
EZ
4988 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4989 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4990 candidate is selected by the mouse, and that candidate has a
4991 composed character under the mouse.
4992
1a2e6670
EZ
4993 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4994 coordinates reported by pos-visible-in-window-p for a composed
4995 character in column zero.
4996
8b76d6f8
SM
49972011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4998
4999 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5000
dac347dd
EZ
50012011-08-22 Eli Zaretskii <eliz@gnu.org>
5002
5003 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5004 consider it a hit if to_charpos is anywhere in the range of the
5005 composed buffer positions.
5006
e013fb34
CY
50072011-08-22 Chong Yidong <cyd@stupidchicken.com>
5008
5009 * image.c (gif_load): Don't assume that each subimage has the same
5010 dimensions as the base image. Handle disposal method that is
5011 "undefined" by the gif spec (Bug#9335).
5012
bd1ba3e8
CY
50132011-08-20 Chong Yidong <cyd@stupidchicken.com>
5014
5015 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5016 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5017
54a1215b
EZ
50182011-08-19 Eli Zaretskii <eliz@gnu.org>
5019
823564e5
EZ
5020 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5021 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5022 from an Org mode buffer to a Speedbar frame.
5023
54a1215b
EZ
5024 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5025 a composition, take its buffer position from IT->cmp_it.charpos.
5026 Fixes cursor positioning at the beginning of a line that begins
5027 with a composed character.
5028
9778ebcc
EZ
50292011-08-18 Eli Zaretskii <eliz@gnu.org>
5030
0be6ee06
EZ
5031 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5032 character bidirectional type, use STRONG_L instead. Fixes crashes
5033 in a buffer produced by `describe-categories'.
5034
9778ebcc
EZ
5035 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5036 members before the level stack, so they would be saved and
5037 restored when copying iterator state. Fixes incorrect reordering
5038 around TABs covered by display properties.
5039
156bffbe
AS
50402011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5041
6b02f655 5042 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5043
72ad093b
CY
50442011-08-17 Chong Yidong <cyd@stupidchicken.com>
5045
5046 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5047 (internal_condition_case_2, internal_condition_case_n):
5048 Remove unnecessary aborts (Bug#9081).
72ad093b 5049
35774242
EZ
50502011-08-17 Eli Zaretskii <eliz@gnu.org>
5051
5052 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5053 has no `load' handler, try opening the file locally. (Bug#9311)
5054
db76dd85
KB
50552011-08-16 Ken Brown <kbrown@cornell.edu>
5056
5057 * gmalloc.c: Expand comment.
5058
b215eee5
EZ
50592011-08-16 Eli Zaretskii <eliz@gnu.org>
5060
5061 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5062 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5063
a4579d33
KB
50642011-08-16 Ken Brown <kbrown@cornell.edu>
5065
5066 Fix memory allocation problems in Cygwin build (Bug#9273).
5067
5068 * unexcw.c ( __malloc_initialized): Declare external variable.
5069 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5070
8b76d6f8
SM
5071 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5072 New variables.
a4579d33
KB
5073 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5074 dumped emacs.
5075 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5076 in the static heap.
5077 [CYGWIN] (special_realloc): New function.
5078 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5079 requests to realloc storage in the static heap.
5080
3ebec551
PE
50812011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5082
5083 * bidi.c (bidi_initialize): Remove unused local.
5084
9fd8be00
EZ
50852011-08-15 Eli Zaretskii <eliz@gnu.org>
5086
6b02f655
SM
5087 * bidimirror.h:
5088 * biditype.h: Remove file.
5089 * makefile.w32-in ($(BLD)/bidi.$(O)):
5090 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5091
5092 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5093
5094 * chartab.c: Improve commentary for the uniprop_table API.
5095
32413314
EZ
5096 * bidi.c (bidi_paragraph_init): Support zero value of
5097 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5098 (bidi_initialize): Use uniprop_table instead of including
5099 biditype.h and bidimirror.h.
32413314 5100
9fd8be00
EZ
5101 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5102 coordinates of the iterator when restoring from ppos_it.
5103 (Bug#9296)
5104
5cf2b69b
KH
51052011-08-14 Kenichi Handa <handa@m17n.org>
5106
5107 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5108 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5109
daf17d00
EZ
51102011-08-14 Eli Zaretskii <eliz@gnu.org>
5111
5112 * xdisp.c (move_it_in_display_line_to): Don't invoke
5113 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5114 ppos_it. Fixes vertical cursor motion when line beginning is
5115 covered by an image. (Bug#9296)
5116
08e3161a
JD
51172011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5118
5119 * nsterm.h (ns_run_ascript): Declare.
5120 (NSAPP_DATA2_RUNASSCRIPT): Define.
5121
5122 * nsfns.m (as_script, as_result, as_status): New static variables.
5123 (ns_run_ascript): New function.
5e617bc2 5124 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5125 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5126 the event loop. Get status from as_status (Bug#7276).
5127
5128 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5129 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5130 the event loop (Bug#7276).
5131
a3720aa2
AS
51322011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5133
5134 * gnutls.c (QCgnutls_bootprop_priority)
5135 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5136 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5137 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5138 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5139 (QCgnutls_bootprop_verify_hostname_error)
5140 (QCgnutls_bootprop_callbacks_verify): Rename from
5141 Qgnutls_bootprop_..., all uses changed.
5142
5143 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5144 uses changed.
5145
0a0d27fb
PE
51462011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5147
19d5c50c
PE
5148 * xfaces.c (Qframe_set_background_mode): Now static.
5149 * dispextern.h (Qframe_set_background_mode): Remove decl.
5150
0a0d27fb
PE
5151 * process.c (Fnetwork_interface_info): Declare local only if needed.
5152
377538cb
JD
51532011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5154
5155 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5156 (Fnetwork_interface_list): Allocate in increments of bytes instead
5157 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5158 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5159 sockaddr.
5160 (struct ifflag_def): notrailers is smart on OSX.
5161 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5162 Get hardware address with getifaddrs if available.
5163
08fff70c
EZ
51642011-08-12 Eli Zaretskii <eliz@gnu.org>
5165
5166 * xdisp.c (iterate_out_of_display_property): xassert that
5167 IT->position is set to within IT->object's boundaries. Break from
5168 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5169 when IT->position is set up wrongly due to some bug.
5170 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5171 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5172 entry. Force push_it to save on the stack the current
5173 buffer/string position, to be restored by pop_it. Fix flags in
5174 the iterator structure wrt the object coming from a display
5175 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5176 properties. (Bug#9284)
5177
7be1c708 51782011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5179
7be1c708
CY
5180 * fontset.c (fontset_get_font_group): Add proper type checks.
5181 (Bug#9172)
aac0c6e3 5182
7be1c708 51832011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5184
7be1c708
CY
5185 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5186 and LC_VERSION_MIN_MACOSX.
5187 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5188 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5189
97bb72a6
EZ
51902011-08-08 Eli Zaretskii <eliz@gnu.org>
5191
5192 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5193 no-display-properties-and-no-overlays under bidi display.
5194 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5195 properties and overlays.
97bb72a6 5196
d5617611
CY
51972011-08-08 Chong Yidong <cyd@stupidchicken.com>
5198
37e11a63
CY
5199 * editfns.c (Fset_time_zone_rule): Document relationship with the
5200 setenv function.
5201
d5617611
CY
5202 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5203 the font entity extracted from the cache (Bug#8109).
5204
58872834
CY
52052011-08-07 Chong Yidong <cyd@stupidchicken.com>
5206
5207 * composite.c (autocmp_chars): Don't reset point. That is done by
5208 restore_point_unwind (Bug#5984).
5209
75bfc667
JL
52102011-08-07 Juri Linkov <juri@jurta.org>
5211
5212 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5213 to show the arg `TIME' instead of `TIMEVAL'.
5214
d1410150
EZ
52152011-08-06 Eli Zaretskii <eliz@gnu.org>
5216
5217 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5218 display property strides EOL and includes a newline, as in
5219 longlines-mode. (Bug#9254)
75b771e4
EZ
5220 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5221 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5222
5223 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5224 is non-zero, even if the data buffer is NULL. Fixes a crash in
5225 vertical-motion with longlines-mode. (Bug#9254)
5226
35928349
EZ
52272011-08-05 Eli Zaretskii <eliz@gnu.org>
5228
ec7cc85b
EZ
5229 * bidi.c <bidi_cache_total_alloc>: Now static.
5230 (bidi_initialize): Initialize bidi_cache_total_alloc.
5231
8b76d6f8 5232 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5233 cache. (Bug#9221)
5234
5235 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5236 amount allocated this far in `bidi_cache_total_alloc'.
5237 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5238 non-zero, only free the data buffer without restoring the cache
5239 contents. All callers changed.
5240
5241 * dispextern.h (bidi_unshelve_cache): Update prototype.
5242
5243 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5244 (move_it_in_display_line, move_it_to)
5245 (move_it_vertically_backward, move_it_by_lines): Replace the call
5246 to xfree to an equivalent call to bidi_unshelve_cache.
5247 (move_it_in_display_line_to): Fix logic of returning
412b6358 5248 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5249
e2e2423b
EZ
52502011-08-05 Eli Zaretskii <eliz@gnu.org>
5251
5252 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5253 came from a string character with a `cursor' property. (Bug#9229)
5254
ae9e757a
JD
52552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5256
5257 * Makefile.in (LIB_PTHREAD): New variable.
5258 (LIBES): Add LIB_PTHREAD (Bug#9216).
5259
5260 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5261 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5262
213bd7f2
AS
52632011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5264
6b02f655 5265 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5266
99aaf75f
JD
52672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5268
5269 * xterm.c (x_find_topmost_parent): New function.
5270 (x_set_frame_alpha): Find topmost parent window with
5271 x_find_topmost_parent and set the property there also (bug#9181).
5272 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5273
c74e9d86
PE
52742011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5275
5276 * callproc.c (Fcall_process): Avoid vfork clobbering
5277 the local vars buffer, coding_systems, current_dir.
5278
640c8776
SM
52792011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5280
5281 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5282
f26d0e4c
PE
52832011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5284
8a10d76c
PE
5285 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5286 so that it is not optimized away.
5287
f26d0e4c
PE
5288 * xdisp.c (compute_display_string_pos): Remove unused local.
5289
55439c61
EZ
52902011-08-02 Eli Zaretskii <eliz@gnu.org>
5291
5292 Fix slow cursor motion and scrolling in large buffers with
5293 selective display, like Org Mode buffers. (Bug#9218)
5294
5295 * dispextern.h (struct bidi_it): New member disp_prop_p.
5296
5297 * xdisp.c: Remove one-slot cache of display string positions.
5298 (compute_display_string_pos): Accept an additional argument
5e617bc2 5299 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5300 for a display string or property. If found, set DISP_PROP_P
5301 non-zero.
5302
5303 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5304 DISP_PROP_P, and pass it to compute_display_string_pos.
5305 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5306 non-zero. All callers of bidi_fetch_char changed.
5307
fb33fa43
SM
53082011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5309
5310 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5311
b099e063
DM
53122010-12-03 Don March <don@ohspite.net>
5313
5314 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5315 last character M-[char] is translated to ESC [char] (bug#7541).
5316
5cc7f7af
KH
53172011-08-02 Kenichi Handa <handa@m17n.org>
5318
d0fffa3f 5319 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5320
5321 * chartab.c (uniprop_table): Make it non-static.
5322
525d5e6e
EZ
53232011-08-01 Eli Zaretskii <eliz@gnu.org>
5324
5325 * xdisp.c (forward_to_next_line_start): Accept additional argument
5326 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5327 on the newline.
5328 (reseat_at_next_visible_line_start): Use the bidi iterator state
5329 returned by forward_to_next_line_start to restore the state of
5330 it->bidi_it after backing up to previous newline. (Bug#9212)
5331
31011111
AS
53322011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5333
5334 * regex.c (re_comp): Protoize.
5335 (re_exec): Fix return type.
5336 (regexec): Fix type of `ret'. (Bug#9203)
5337
476371c4
PE
53382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5339
e5d76069
PE
5340 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5341 This is needed if max-image-size is a floating-point number.
5342
9a79b20c
AS
53432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5344
5345 * print.c (print_object): Print empty symbol as ##.
5346
5347 * lread.c (read1): Read ## as empty symbol.
5348
d8c2fa78
AA
53492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5350
5351 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5352 setting frame foreground color (Bug#9175).
5353 (x_set_background_color): Likewise.
5354
ffe57a7a
AA
5355 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5356 contents (Bug#9176).
5357 (EmacsTooltip -init): Remove bezels and add shadows to
5358 tooltip windows.
5359
bf3492a5
AA
5360 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5361 or scroll bar (Bug#8470).
5362
d55e9c53
AA
5363 * nsfont.m (nsfont_open): Remove assignment to voffset and
5364 unnecessary vars hshink, expand, hd, full_height, min_height.
5365 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5366
5367 * nsterm.h (nsfont_info): Remove voffset field.
5368
d8c2fa78 53692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5370
5371 Implement strike-through and overline on NextStep (Bug#8863).
5372
5373 * nsfont.m (nsfont_open): Use underline position provided by font,
5374 instead of hard-coded value of 2.
5375 (nsfont_draw): Call ns_draw_text_decoration instead.
5376
5377 * nsterm.h: Add declaration for ns_draw_text_decoration.
5378
5379 * nsterm.m (ns_draw_text_decoration): New function for drawing
5380 underline, overline, and strike-through.
5381 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5382 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5383 accommodate underlining, etc.
4843aac3 5384
4cc60b9b
EZ
53852011-07-28 Eli Zaretskii <eliz@gnu.org>
5386
bc7ece87
EZ
5387 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5388 default.
4cc60b9b 5389
476371c4
PE
53902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5391
66606eea
PE
5392 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5393 Without this fix, if a signal arrives just after memory fills up,
5394 'malloc' might be invoked reentrantly.
5395
476371c4
PE
5396 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5397 In other words, assume that every image size is allowed, on non-X
5398 hosts. This assumption is probably wrong, but it lets Emacs compile.
5399
f3fcc40d
AS
54002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5401
5402 * regex.c (re_iswctype): Convert return values to boolean.
5403
350c992f
EZ
54042011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5405
5406 * xdisp.c (compute_display_string_pos): Don't use cached display
5407 string position if the buffer had its restriction changed.
5408 (Bug#9184)
5409
5266b4bb
PE
54102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5411
5412 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5413
2573a837 54142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5415
41f55ccd 5416 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5417
39e378da
PE
5418 * bidi.c: Integer size and overflow fixes.
5419 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5420 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5421 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5422 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5423 (bidi_find_other_level_edge):
5424 Use ptrdiff_t instead of EMACS_INT where either will do.
5425 This works better on 32-bit hosts configured --with-wide-int.
5426 (bidi_cache_ensure_space): Check for size-calculation overflow.
5427 Use % rather than repeated addition, for better worst-case speed.
5428 Don't set bidi_cache_size until after xrealloc returns, because it
5429 might not return.
5430 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5431 (bidi_cache_ensure_space): Also check that the bidi cache size
5432 does not exceed that of the largest Lisp string or buffer. See Eli
5433 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5434
5e927815
PE
5435 * alloc.c (__malloc_size_t): Remove.
5436 All uses replaced by size_t. See Andreas Schwab's note
5437 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5438
ca4aa935
PE
5439 * image.c: Improve checking for integer overflow.
5440 (check_image_size): Assume that f is nonnull, since
5441 it is always nonnull in practice. This is one less thing to
5442 worry about when checking for integer overflow later.
5443 (x_check_image_size): New function, which checks for integer
5444 overflow issues inside X.
5445 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5446 This removes the need for a memory_full check.
5447 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5448 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5449 (xbm_read_bitmap_data): Change locals back to 'int', since
5450 their values must fit in 'int'.
5451 (xpm_load_image, png_load, tiff_load):
5452 Invoke x_create_x_image_and_pixmap earlier,
5453 to avoid much needless work if the image is too large.
5454 (tiff_load): Treat overly large images as if
5455 x_create_x_image_and_pixmap failed, not as malloc failures.
5456 (gs_load): Use x_check_image_size.
5457
5f8f9cc2
PE
5458 * gtkutil.c: Omit integer casts.
5459 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5460 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5461
5adf60bc
PE
5462 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5463
c8907a93
PE
5464 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5465 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5466 would wrongly return t on a 64-bit host.
5467
e3c25c68
PE
5468 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5469 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5470 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5471 and therefore cause GCC to emit a bogus diagnostic in some cases.
5472
3f791afe
PE
5473 * image.c: Integer signedness and overflow and related fixes.
5474 This is not an exhaustive set of fixes, but it's time to
5475 record what I've got.
5476 (lookup_pixel_color, check_image_size): Remove redundant decls.
5477 (check_image_size): Don't assume that arbitrary EMACS_INT values
5478 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5479 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5480 (tiff_load, imagemagick_load_image):
5481 Check for overflow in size calculations.
5482 (x_create_x_image_and_pixmap): Remove unnecessary test for
5483 xmalloc returning NULL; that can't happen.
5484 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5485 (xpm_color_bucket): Use better integer hashing function.
5486 (xpm_cache_color): Don't possibly over-allocate memory.
5487 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5488 (gif_memory_source):
5489 Use ptrdiff_t, not int or size_t, to record sizes.
5490 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5491 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5492 either works, as we prefer signed integers.
5493 (tiff_read_from_memory, tiff_write_from_memory):
5494 Return tsize_t, not size_t, since that's what the TIFF API wants.
5495 (tiff_read_from_memory): Don't fail simply because the read would
5496 go past EOF; instead, return a short read.
5497 (tiff_load): Omit no-longer-needed casts.
5498 (Fimagemagick_types): Don't assume size fits into 'int'.
5499
3cc5a532
PE
5500 Improve hashing quality when configured --with-wide-int.
5501 * fns.c (hash_string): New function, taken from sxhash_string.
5502 Do not discard information about ASCII character case; this
5503 discarding is no longer needed.
5504 (sxhash-string): Use it. Change sig to match it. Caller changed.
5505 * lisp.h: Declare it.
5506 * lread.c (hash_string): Remove, since we now use fns.c's version.
5507 The fns.c version returns a wider integer if --with-wide-int is
5508 specified, so this should help the quality of the hashing a bit.
5509
b312a492
PE
5510 * emacs.c: Integer overflow minor fix.
5511 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5512 Define only if GNU_LINUX.
5513 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5514
dfd153ae
PE
5515 * dispnew.c: Integer signedness and overflow fixes.
5516 Remove unnecessary forward decls, that were a maintenance hassle.
5517 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5518 All uses changed.
5519 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5520 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5521 (prepare_desired_row, line_draw_cost):
5522 Use int, not unsigned, where either works.
5523 (save_current_matrix, restore_current_matrix):
5524 Use ptrdiff_t, not size_t, where either works.
5525 (init_display): Check for overflow more accurately, and without
5526 relying on undefined behavior.
5527
a81d11a3
PE
5528 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5529 Remove, replacing with the new symbols in lisp.h. All uses changed.
5530 * fileio.c (make_temp_name):
5531 * filelock.c (lock_file_1, lock_file):
5532 * xdisp.c (message_dolog):
5533 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5534 Use pMd etc. instead.
5535 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5536 replacing the pWIDE etc. symbols removed from editfns.c.
5537
3300e6fd
PE
5538 * keyboard.h (num_input_events): Now uintmax_t.
5539 This is (very slightly) less likely to mess up due to wraparound.
5540 All uses changed.
5541
fd05c7e9
PE
5542 * buffer.c: Integer signedness fixes.
5543 (alloc_buffer_text, enlarge_buffer_text):
5544 Use ptrdiff_t rather than size_t when either will do, as we prefer
5545 signed integers.
5546
903fe15d
PE
5547 * alloc.c: Integer signedness and overflow fixes.
5548 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5549 (__malloc_size_t): Default to size_t, not to int.
5550 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5551 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5552 Prefer ptrdiff_t to size_t when either would do, as we prefer
5553 signed integers.
5554 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5555 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5556 Now const. Initialize with values that are in range even if char
5557 is signed.
5558 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5559 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5560 These functions do the right thing with sizes > 2**32.
5561 (check_depth): Now ptrdiff_t, not int.
5562 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5563 Adjust to new way of storing sizes. Check for size overflow bugs
5564 in rest of code.
5565 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5566 slightly wrong anyway, as it missed one instance of
5567 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5568 (refill_memory_reserve): Omit needless cast to size_t.
5569 (mark_object_loop_halt): Mark as externally visible.
5570
ac82cc6a
PE
5571 * xselect.c: Integer signedness and overflow fixes.
5572 (Fx_register_dnd_atom, x_handle_dnd_message):
5573 Use ptrdiff_t, not size_t, since we prefer signed.
5574 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5575 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5576 x_dnd_atoms_size and x_dnd_atoms_length.
5577
c2d1e36d
PE
5578 * doprnt.c: Prefer signed to unsigned when either works.
5579 * eval.c (verror):
5580 * doprnt.c (doprnt):
5581 * lisp.h (doprnt):
5582 * xdisp.c (vmessage):
5583 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5584 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5585 prefer signed arithmetic to avoid comparison confusion.
5586 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5587 but is a bit tricky.
5588
0e926e56
PE
5589 Assume freestanding C89 headers, string.h, stdlib.h.
5590 * data.c, doprnt.c, floatfns.c, print.c:
5591 Include float.h unconditionally.
5592 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5593 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5594 * regex.c: Likewise for stddef.h, string.h.
5595 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5596 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5597 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5598 (STDC_HEADERS): Remove obsolete defines.
5599 * sysdep.c: Include limits.h unconditionally.
5600
9cfdb3ec
PE
5601 Assume support for memcmp, memcpy, memmove, memset.
5602 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5603 * regex.c (memcmp, memcpy):
5604 Remove; we assume C89 now.
5605
5606 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5607 (__malloc_safe_bcopy): Remove; no longer needed.
5608
cf950e6b 5609 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5610 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5611 well either way, and we prefer signed to unsigned.
5612
dbf38e02
LMI
56132011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5614
5615 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5616 closes the connection while we're reading (bug#9182).
5617
d6f0886c 56182011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5619
d6f0886c
JD
5620 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5621 are specified (Bug#9168).
24e0f6b1 5622
2eb1f9e6
PE
56232011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5624
5625 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5626 Found by GCC static checking and --with-wide-int on a 32-bit host.
5627
22381272 56282011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5629
5630 * xdisp.c (compute_display_string_pos): Fix logic of caching
5631 previous display string position. Initialize cached_prev_pos to
5632 -1. Fixes slow-down at the beginning of a buffer.
5633
f25e39b4
EZ
56342011-07-24 Eli Zaretskii <eliz@gnu.org>
5635
5636 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5637 for attrs[LFACE_FONTSET_INDEX].
5638
04c4b52e
PE
56392011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5640
5641 * xml.c (parse_region): Remove unused local
5642 that was recently introduced.
5643
c1734fbd
EZ
56442011-07-23 Eli Zaretskii <eliz@gnu.org>
5645
be18c5a5
EZ
5646 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5647 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5648
c1734fbd
EZ
5649 * xdisp.c (move_it_in_display_line_to): Record the best matching
5650 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5651 exit if none of the characters scanned was an exact match.
5652 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5653 when exact match is impossible due to invisible text, and the
5654 lines are truncated.
5655
a258d627
JD
56562011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5657
5658 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5659 for OSX >= 10.7.
5660
b6d5a689
EZ
56612011-07-22 Eli Zaretskii <eliz@gnu.org>
5662
0f74f785
EZ
5663 Fix a significant slow-down of cursor motion with C-n, C-p,
5664 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5665 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5666 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5667 (next_element_from_buffer): Call compute_stop_pos_backwards to
5668 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5669 base_level_stop.
5670 (reseat): Don't look for prev_stop, as that could mean a very long
5671 run.
5672 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5673 <cached_disp_overlay_modiff>: Cache for last found display string
5674 position.
551918c1 5675 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5676 about the same buffer in the same area of character positions, and
5677 the buffer wasn't changed since the time the display string
5678 position was cached.
551918c1 5679
b2d0c91a
EZ
56802011-07-22 Eli Zaretskii <eliz@gnu.org>
5681
5682 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5683 is an integer, which is important for empty lines. (Bug#9149)
5684
043604ee
CY
56852011-07-22 Chong Yidong <cyd@stupidchicken.com>
5686
5687 * frame.c (Fmodify_frame_parameters): In tty case, update the
5688 default face if necessary (Bug#4238).
5689
da4adb04
CY
56902011-07-21 Chong Yidong <cyd@stupidchicken.com>
5691
5692 * editfns.c (Fstring_to_char): No need to explain what a character
5693 is in the docstring (Bug#6576).
5694
9abd0532
LMI
56952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5696
5697 * xml.c (parse_region): Make sure we always return a tree.
5698
36881d16
HK
56992011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5700
5701 * xml.c (parse_region): If a document contains only comments,
5702 return that, too.
5703
1e98674d
LMI
57042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5705
5706 * xml.c (make_dom): Return comments, too.
5707
590bd467
PE
57082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5709
5710 Port to OpenBSD.
5711 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5712 and the surrounding thread.
5713 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5714 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5715 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5716 timer goes off.
5717 * s/openbsd.h (BROKEN_SIGIO): Define.
5718 * unexelf.c (unexec) [__OpenBSD__]:
5719 Don't update the .mdebug section of the Alpha COFF symbol table.
5720
f41628b2
LMI
57212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5722
5723 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5724 (bug#8460).
5725
b59b67c5
PE
57262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5727
15e3a074
PE
5728 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5729 This fixes some race conditions on the permissions of any newly
5730 created file.
5731
41bed37d
PE
5732 * alloc.c (valid_pointer_p): Use pipe, not open.
5733 This fixes some permissions issues when debugging.
5734
b59b67c5
PE
5735 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5736 If fchown fails to set both uid and gid, try to set just gid,
5737 as that is sometimes allowed. Adjust the file's mode to eliminate
5738 setuid or setgid bits that are inappropriate if fchown fails.
5739
925a6be7
SM
57402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5741
5742 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5743 to compare Lisp_Objects.
5744 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5745 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5746 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5747
52968808
AS
57482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5749
0a6a104b
AS
5750 * lread.c (read_integer): Unread even EOF character.
5751 (read1): Likewise. Properly record start position of symbol.
5752
52968808
AS
5753 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5754 symbol character follows.
5755
9e381cdd
PE
57562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5757
5758 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5759 This works around a problem with the previous change to Fcopy_file.
5760 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5761 and without this change, GCC might complain about discarding
5762 fchown's return value.
5763
b5641435
JB
57642011-07-16 Juanma Barranquero <lekktu@gmail.com>
5765
5766 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5767
a8031457
PE
57682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5769
5770 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5771
dd889327
LMI
57722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5773
750c33f7
LMI
5774 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5775 it's used from the C level.
5776
dd889327
LMI
5777 * process.c: Use the same condition for POLL_FOR_INPUT in both
5778 keyboard.c and process.c (bug#1858).
5779
87e86684
LM
57802011-07-09 Lawrence Mitchell <wence@gmx.li>
5781
5782 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5783 (Fgnutls_boot): Use it.
5784
64348f40
AS
57852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5786
5787 * doc.c (Fsubstitute_command_keys): Revert last change.
5788
1d698799
LMI
57892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5790
f863868c
LMI
5791 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5792 quotes the next character, and doesn't affect other longer
5793 sequences (bug#8935).
5794
1d698799
LMI
5795 * lread.c (syms_of_lread): Clarify that is isn't only
5796 `eval-buffer' and `eval-defun' that's affected by
5797 `lexical-binding' (bug#8460).
5798
aa4b6df6
EZ
57992011-07-15 Eli Zaretskii <eliz@gnu.org>
5800
5801 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5802 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5803
5d856da6
PE
58042011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5805
ad6042bb
PE
5806 Fix minor problems found by static checking.
5807 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5808 (elsz): Now a signed constant, not a size_t var. We prefer signed
5809 types to unsigned, to avoid integer comparison confusion. Without
5810 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5811 "cannot optimize loop, the loop counter may overflow", a symptom
5812 of the confusion.
f00bbb22 5813 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5814 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5815
6468f31c
LMI
58162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5817
49080b10
LMI
5818 * search.c (Fre_search_backward): Mention `case-fold-search' in
5819 all the re_search_* functions (bug#8138).
5820
6468f31c
LMI
5821 * keyboard.c (Fopen_dribble_file): Document when the file is
5822 closed (bug#8056).
5823
c965adc5
EZ
58242011-07-14 Eli Zaretskii <eliz@gnu.org>
5825
df9733bf
EZ
5826 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5827 bidi_cache_idx.
5828
0bb23927
EZ
5829 Support bidi reordering of display and overlay strings.
5830 * xdisp.c (compute_display_string_pos)
5831 (compute_display_string_end): Accept additional argument STRING.
5832 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5833 (reseat_to_string): Initialize bidi_it->string.s and
5834 bidi_it->string.schars.
5835 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5836 NULL (avoids a crash in bidi_paragraph_init).
5837 Initialize itb.string.lstring.
0bb23927
EZ
5838 (init_iterator): Call bidi_init_it only of a valid
5839 buffer position was specified. Initialize paragraph_embedding to
5840 L2R.
5841 (reseat_to_string): Initialize the bidi iterator.
5842 (display_string): If we need to ignore text properties of
5843 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5844 original value of -1 will not work with bidi.)
5845 (compute_display_string_pos): First arg is now struct
5846 `text_pos *'; all callers changed. Support display properties on
5847 Lisp strings.
5848 (compute_display_string_end): Support display properties on Lisp
5849 strings.
5850 (init_iterator, reseat_1, reseat_to_string): Initialize the
5851 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5852 when iterating on a string not from display properties).
640c8776
SM
5853 (compute_display_string_pos, compute_display_string_end):
5854 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5855 arrow keys.
5856 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5857 base_level_stop; instead, set base_level_stop to BEGV.
5858 Fixes crashes in vertical-motion.
0bb23927
EZ
5859 (next_element_from_buffer): Improve commentary for when
5860 the iterator is before prev_stop.
5861 (init_iterator): Initialize bidi_p from the default value of
5862 bidi-display-reordering, not from buffer-local value. Use the
5863 buffer-local value only if initializing for buffer iteration.
5864 (handle_invisible_prop): Support invisible properties on strings
5865 that are being bidi-reordered.
5866 (set_iterator_to_next): Support bidi reordering of C strings and
5867 Lisp strings.
5868 (next_element_from_string): Support bidi reordering of Lisp
5869 strings.
5870 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5871 (display_string): Support display of R2L glyph rows.
5872 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5873 (init_iterator): Don't initialize it->bidi_p for strings
5874 here.
5875 (reseat_to_string): Initialize it->bidi_p for strings here.
5876 (next_element_from_string, next_element_from_c_string)
5877 (next_element_from_buffer): Add xassert's for correspondence
5878 between IT's object being iterated and it->bidi_it.string
5879 structure.
5880 (face_before_or_after_it_pos): Support bidi iteration.
5881 (next_element_from_c_string): Handle the case of the first string
5882 character that is not the first one in the visual order.
5883 (get_visually_first_element): New function, refactored from common
5884 parts of next_element_from_buffer, next_element_from_string, and
5885 next_element_from_c_string.
5886 (tool_bar_lines_needed, redisplay_tool_bar)
5887 (display_menu_bar): Force left-to-right direction. Add a FIXME
5888 comment for making that be controlled by a user option.
5889 (push_it, pop_it): Save and restore the state of the
5890 bidi iterator. Save and restore the bidi_p flag.
5891 (pop_it): Iterate out of display property for string iteration as
5892 well.
5893 (iterate_out_of_display_property): Support iteration over strings.
5894 (handle_single_display_spec): Set up it->bidi_it for iteration
5895 over a display string, and call bidi_init_it.
5896 (handle_single_display_spec, next_overlay_string)
5897 (get_overlay_strings_1, push_display_prop): Set up the bidi
5898 iterator for displaying display or overlay strings.
5899 (forward_to_next_line_start): Don't use the shortcut if
5900 bidi-iterating.
5901 (back_to_previous_visible_line_start): If handle_display_prop
5902 pushed the iterator stack, restore the internal state of the bidi
5903 iterator by calling bidi_pop_it same number of times.
5904 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5905 and we are bidi-iterating, don't decrement the iterator position;
5906 instead, set the first_elt flag in the bidi iterator, to produce
5907 the same effect.
5908 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5909 (push_display_prop): xassert that we are iterating a buffer.
5910 (push_it, pop_it): Save and restore paragraph_embedding member.
5911 (handle_single_display_spec, next_overlay_string)
5912 (get_overlay_strings_1, reseat_1, reseat_to_string)
5913 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5914 correctly. Don't assume unibyte strings are not bidi-reordered.
5915 (compute_display_string_pos)
5916 (compute_display_string_end): Fix handling the case of C string.
5917 (push_it, pop_it): Save and restore from_disp_prop_p.
5918 (handle_single_display_spec, push_display_prop): Set the
5919 from_disp_prop_p flag.
5920 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5921 (pop_it): Call iterate_out_of_display_property only if we are
5922 popping after iteration over a string that came from a display
5923 property. Fix a typo in popping stretch info. Add an assertion
5924 for verifying that the iterator position is in sync with the bidi
5925 iterator.
5926 (handle_single_display_spec, get_overlay_strings_1)
5927 (push_display_prop): Fix initialization of paragraph direction for
5928 string when that of the parent object is not yet determined.
5929 (reseat_1): Call bidi_init_it to resync the bidi
5930 iterator with IT's position. (Bug#7616)
5931 (find_row_edges): If ROW->start.pos gives position
5932 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5933 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5934 Reset the from_disp_prop_p flag.
5935 (SAVE_IT, RESTORE_IT): New macros.
5936 (pos_visible_p, face_before_or_after_it_pos)
5937 (back_to_previous_visible_line_start)
5938 (move_it_in_display_line_to, move_it_in_display_line)
5939 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5940 (try_scrolling, redisplay_window, display_line): Use them when
5941 saving a temporary copy of the iterator and restoring it back.
5942 (back_to_previous_visible_line_start, reseat_1)
5943 (init_iterator): Empty the bidi cache "stack".
5944 (move_it_in_display_line_to): If iterator ended up at
5945 EOL, but we never saw any buffer positions smaller than
5946 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5947 motion in bidi-reordered lines.
5948 (move_it_in_display_line_to): Record prev_method and prev_pos
5949 immediately before the call to set_iterator_to_next. Fixes cursor
5950 motion in bidi-reordered lines with stretch glyphs and strings
5951 displayed in margins. (Bug#8133) (Bug#8867)
5952 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5953 TO_CHARPOS.
640c8776
SM
5954 (pos_visible_p): Support positions in bidi-reordered lines.
5955 Save and restore bidi cache.
0bb23927
EZ
5956
5957 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5958 (bidi_paragraph_info): Delete unused struct.
5959 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5960 (bidi_cache_start): New variable.
5961 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5962 to zero.
5963 (bidi_cache_fetch_state, bidi_cache_search)
5964 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5965 (bidi_cache_find, bidi_peek_at_next_level)
5966 (bidi_level_of_next_char, bidi_find_other_level_edge)
5967 (bidi_move_to_visually_next): Compare cache index with
5968 bidi_cache_start rather than with zero.
5969 (bidi_fetch_char): Accept new argument STRING; all callers
5970 changed. Support iteration over a string. Support strings with
5971 display properties. Support unibyte strings. Fix the type of
5972 `len' according to what STRING_CHAR_AND_LENGTH expects.
5973 (bidi_paragraph_init, bidi_resolve_explicit_1)
5974 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5975 (bidi_level_of_next_char, bidi_move_to_visually_next):
5976 Support iteration over a string.
0bb23927
EZ
5977 (bidi_set_sor_type, bidi_resolve_explicit_1)
5978 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5979 can now be zero (for strings); special values 0 and -1 were
5980 changed to -1 and -2, respectively.
5981 (bidi_char_at_pos): New function.
5982 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5983 Call it instead of FETCH_MULTIBYTE_CHAR.
5984 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5985 initialized to valid values.
5986 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5987 values.
5988 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5989 the test for valid cached positions. Fix the logic for looking up
5990 the sentinel state in the cache. GCPRO the Lisp string we are
5991 iterating.
5992 (bidi_push_it, bidi_pop_it): New functions.
5993 (bidi_initialize): Initialize the bidi cache start stack pointer.
5994 (bidi_cache_ensure_space): New function, refactored from part of
5995 bidi_cache_iterator_state. Don't assume the required size is just
5996 one BIDI_CACHE_CHUNK away.
5997 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5998 (bidi_count_bytes, bidi_char_at_pos): New functions.
5999 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6000 always valid if bidi_cache_idx is valid.
6001 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6002 is valid if it's going to be used.
6003 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6004 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6005 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6006 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6007 (bidi_find_other_level_edge, bidi_cache_start_stack):
6008 All variables related to cache indices are now EMACS_INT.
c965adc5 6009
0bb23927
EZ
6010 * dispextern.h (struct bidi_string_data): New structure.
6011 (struct bidi_it): New member `string'. Make flag members be 1-bit
6012 fields, and put them last in the struct.
640c8776
SM
6013 (compute_display_string_pos, compute_display_string_end):
6014 Update prototypes.
0bb23927
EZ
6015 (bidi_push_it, bidi_pop_it): Add prototypes.
6016 (struct iterator_stack_entry): New members bidi_p,
6017 paragraph_embedding, and from_disp_prop_p.
6018 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6019 (bidi_shelve_cache, bidi_unshelve_cache):
6020 Declare prototypes.
0bb23927
EZ
6021
6022 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6023 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6024 and vector-like objects.
6025
6026 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6027 cache around display iteration.
6028
6029 * window.c (Fwindow_end, window_scroll_pixel_based)
6030 (displayed_window_lines, Frecenter): Save and restore the bidi
6031 cache around display iteration.
6032
3bbd2265
LMI
60332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6034
6035 * editfns.c (Fdelete_region): Clarify the use of the named
6036 parameters (bug#6788).
6037
adc47434
MR
60382011-07-14 Martin Rudalics <rudalics@gmx.at>
6039
6040 * indent.c (Fvertical_motion): Set and restore w->pointm when
6041 saving and restoring the window's buffer (Bug#9006).
6042
837c31f8
LMI
60432011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6044
6045 * editfns.c (Fstring_to_char): Clarify just what is returned
6046 (bug#6576). Text by Eli Zaretskii.
6047
ac389d0c
JB
60482011-07-13 Juanma Barranquero <lekktu@gmail.com>
6049
6050 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6051
0be0ce47
EZ
60522011-07-13 Eli Zaretskii <eliz@gnu.org>
6053
6054 * buffer.c (mmap_find): Fix a typo.
6055
cd18e7e3
JB
60562011-07-13 Johan Bockgård <bojohan@gnu.org>
6057
6058 Fix execution of x selection hooks.
6059 * xselect.c (Qx_lost_selection_functions)
6060 (Qx_sent_selection_functions): New vars.
6061 (syms_of_xselect): DEFSYM them.
6062 (x_handle_selection_request): Pass Qx_sent_selection_functions
6063 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6064 (x_handle_selection_clear,x_clear_frame_selections):
6065 Pass Qx_lost_selection_functions rather than
6066 Vx_lost_selection_functions to Frun_hook_with_args.
6067
47ea7f44
PE
60682011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6069
ac389d0c 6070 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6071 The old code sometimes used this field without initializing it.
6072
47ea7f44
PE
6073 * alloc.c (gc_sweep): Don't read past end of array.
6074 In theory, the old code could also have corrupted Emacs internals,
6075 though it'd be very unlikely.
6076
bc985c87
AS
60772011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6078
6079 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6080 argument. (Bug#4026)
bc985c87 6081
0cf34688
LMI
60822011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6083
b3dadd76
LMI
6084 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6085 key" (bug#4257).
6086
0cf34688
LMI
6087 * window.c (Fset_window_start): Doc fix (bug#4199).
6088 (Fset_window_hscroll): Ditto.
6089
270768cd
PE
60902011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6091
077e3dda 6092 Fix minor new problems caught by GCC 4.6.1.
270768cd 6093 * term.c (init_tty): Remove unused local.
490011a6 6094 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6095 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6096 not used otherwise.
270768cd 6097
b1f58454
CY
60982011-07-12 Chong Yidong <cyd@stupidchicken.com>
6099
6100 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6101
22b9578d
LMI
61022011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6103
6e70ab07
LMI
6104 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6105 are the mini-buffer and the echo area (bug#3320).
6106
22b9578d
LMI
6107 * term.c (init_tty): Remove support for supdup, c10 and perq
6108 terminals, which are no longer supported (bug#1482).
6109
8974cc9f
JB
61102011-07-10 Johan Bockgård <bojohan@gnu.org>
6111
6112 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6113
a560d974
JD
61142011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6115
6116 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6117 for non-popups (Bug#3642).
6118
1dae0f0a
AS
61192011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6120
268c2c36 6121 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6122 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6123 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6124 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6125 * data.c (fmod): Likewise.
6126 * dispnew.c (swap_glyphs_in_rows): Likewise.
6127 * emacs.c (memory_warning_signal): Likewise.
6128 * floatfns.c (float_error): Likewise.
6129 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6130 (otf_open, font_otf_capability, generate_otf_features)
6131 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6132 Likewise.
6133 * image.c (pbm_read_file): Likewise.
6134 * indent.c (string_display_width): Likewise.
6135 * intervals.c (check_for_interval, search_for_interval)
6136 (inc_interval_count, count_intervals, root_interval)
6137 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6138 * lread.c (defalias): Likewise.
268c2c36 6139 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6140 * regex.c (set_image_of_range_1, set_image_of_range)
6141 (regex_grow_registers): Likewise.
6142 * sysdep.c (strerror): Likewise.
6143 * termcap.c (valid_filename_p, tprint, main): Likewise.
6144 * tparam.c (main): Likewise.
6145 * unexhp9k800.c (run_time_remap, save_data_space)
6146 (update_file_ptrs, read_header, write_header, calculate_checksum)
6147 (copy_file, copy_rest, display_header): Likewise.
6148 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6149 Likewise.
6150 * xdisp.c (check_it): Likewise.
6151 * xfaces.c (register_color, unregister_color, unregister_colors):
6152 Likewise.
6153 * xfns.c (print_fontset_result): Likewise.
6154 * xrdb.c (member, fatal, main): Likewise.
6155
99033785
PE
61562011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6157
6158 Fix minor problems found by static checking (Bug#9031).
6159 * chartab.c (char_table_set_range, map_sub_char_table):
6160 Remove unused locals.
6161 (uniprop_table): Now static.
6162 * composite.c (_work_char): Remove unused static var.
6163
9cb2ac56
JB
61642011-07-09 Juanma Barranquero <lekktu@gmail.com>
6165
6166 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6167
f25661f0
JD
61682011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6169
6170 * gtkutil.c (qttip_cb): Remove code without function.
6171
8278c4fe
EZ
61722011-07-09 Eli Zaretskii <eliz@gnu.org>
6173
6174 * w32.c (pthread_sigmask): New stub.
6175
1692ae2d 61762011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6177
8a6ebd58 6178 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6179 sigprocmask is portable only for single-threaded applications, and
6180 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6181 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6182 (LIBES): Use it.
6183 * callproc.c (Fcall_process):
6184 * process.c (create_process):
6185 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6186 Use pthread_sigmask, not sigprocmask.
123403e4 6187
1b854618
JD
61882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6189
6190 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6191 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6192 wrong (Bug#8591).
6193
3fe4b549
JD
61942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6195
0ce7e563
JD
6196 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6197 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6198 (xg_hide_tooltip): Fix comment.
6199
3fe4b549
JD
6200 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6201 in registerServicesMenuSendTypes.
6202 (validRequestorForSendType): Don't check ns_return_types.
6203
6204 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6205 ns_return_type.
6206
5df75e47
JR
62072011-07-08 Jason Rumney <jasonr@gnu.org>
6208
22610910
JR
6209 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6210 SH_SHOW for hidden windows (Bug#5482).
6211
5df75e47
JR
6212 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6213 frame struct members of non-existent frames (Bug#6284).
6214
699c10bd
JD
62152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6216
4393663b
JD
6217 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6218 variable firstTime not needed on OSX >= 10.6.
6219 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6220 >= 10.5. Use setKnobProportion, setDoubleValue.
6221
6222 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6223 (MAC_OS_X_VERSION_10_5): Define if not defined.
6224 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6225 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6226 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6227
6228 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6229 cString and lossyCString on OSX >= 10.4
6230
58179cce 6231 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6232 sizeToFit on OSX >= 10.2.
6233
6234 * nsimage.m (allocInitFromFile): Don't use deprecated method
6235 bestRepresentationForDevice on OSX >= 10.6.
6236
6237 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6238 to avoid warning.
6239
6240 * emacs.c: Declare unexec_init_emacs_zone.
6241
a63e0781
JD
6242 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6243
699c10bd
JD
6244 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6245
6246 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6247 on svcsMenu (Bug#8842).
6248
6249 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6250 ns_return_types.
6251 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6252
6253 * nsterm.m (QUTF8_STRING): Declare.
6254 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6255 (validRequestorForSendType): Return type is (id).
6256 Change indexOfObjectIdenticalTo to indexOfObject.
6257 Check if we have local selection before returning self (Bug#8842).
6258 (writeSelectionToPasteboard): Put local selection into paste board
6259 if we have a local selection (Bug#8842).
6260 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6261
6262 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6263 (ns_get_local_selection): Declare.
6264
54e10184
LMI
62652011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6266
9888ff71
LMI
6267 * keymap.c (describe_map_tree): Don't insert a double newline at
6268 the end of the buffer (bug#1169) and return whether we inserted
6269 something.
6270
54e10184
LMI
6271 * callint.c (Fcall_interactively): Change "reading args" to
6272 "providing args" to try to clarify what it does (bug#1010).
6273
15fa4783
KH
62742011-07-07 Kenichi Handa <handa@m17n.org>
6275
6276 * composite.c (composition_compute_stop_pos): Ignore a static
6277 composition starting before CHARPOS (Bug#8915).
6278
6279 * xdisp.c (handle_composition_prop): Likewise.
6280
a8815b00
EZ
62812011-07-07 Eli Zaretskii <eliz@gnu.org>
6282
6283 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6284 (Bug#9015)
6285
ef7b981d 62862011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6287
6288 * character.h (unicode_category_t): New enum type.
6289
6290 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6291 (Qchar_code_property_table): New variable.
6292 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6293 (UNIPROP_COMPRESSED_FORM_P): New macros.
6294 (char_table_ascii): Uncompress the compressed values.
6295 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6296 Uncompress the compressed values.
ac389d0c 6297 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6298 (char_table_ref_and_range): Uncompress the compressed values.
6299 (sub_char_table_set): New arg is_uniprop. Callers changed.
6300 Uncompress the compressed values.
6301 (sub_char_table_set_range): Args changed. Callers changed.
6302 (char_table_set_range): Adjuted for the above change.
6303 (map_sub_char_table): Delete args default_val and parent. Add arg
6304 top. Give decoded values to a Lisp function.
640c8776 6305 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6306 values to a Lisp function. Gcpro more variables.
6307 (uniprop_table_uncompress)
6308 (uniprop_decode_value_run_length): New functions.
6309 (uniprop_decoder, uniprop_decoder_count): New variables.
6310 (uniprop_get_decoder, uniprop_encode_value_character)
6311 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6312 New functions.
6313 (uniprop_encoder, uniprop_encoder_count): New variables.
6314 (uniprop_get_encoder, uniprop_table)
6315 (Funicode_property_table_internal, Fget_unicode_property_internal)
6316 (Fput_unicode_property_internal): New functions.
6317 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6318 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6319 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6320 char-code-property-alist.
6321
640c8776 6322 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6323 Vunicode_category_table.
6324
640c8776 6325 * font.c (font_range): Adjust for the change of
c805dec0
KH
6326 Vunicode_category_table.
6327
76b397fb
DN
63282011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6329
6330 * m/iris4d.h: Remove file, move contents ...
6331 * s/irix6-5.h: ... here.
6332
22b4128e
PE
63332011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6334
6335 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6336 * alloc.c (mark_buffer):
6337 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6338 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6339 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6340 This isn't true in general, and it's particularly not true
6341 if Emacs is configured with --with-wide-int.
6342 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6343 New macros, used in the buffer.c change.
6344
869795d6
JD
63452011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6346
6347 * xsettings.c: Use both GConf and GSettings if both are available.
6348 (store_config_changed_event): Add comment.
6349 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6350 (store_tool_bar_style_changed): New functions.
5e617bc2 6351 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6352 (struct xsettings): Move font inside HAVE_XFT.
6353 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6354 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6355 Move inside HAVE_XFT.
640c8776 6356 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6357 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6358 also.
6359 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6360 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6361 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6362 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6363 (parse_settings): Move check for font inside HAVE_XFT.
6364 (read_settings, apply_xft_settings): Add comment.
6365 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6366 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6367 call store_font_name_changed.
6368 (xft_settings_event): Add comment.
6369 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6370 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6371 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6372 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6373 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6374 (xsettings_get_system_font, xsettings_get_system_normal_font):
6375 Add comment.
869795d6 6376
d8ed26bd
PE
63772011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6378
6379 Random fixes. E.g., (random) never returned negative values.
6380 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6381 subseconds part to the entropy, as that's a bit more random.
6382 Prefer signed to unsigned, since the signedness doesn't matter and
6383 in general we prefer signed. When given a limit, use a
6384 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6385 latter isn't right if USE_2_TAGS_FOR_INTS.
6386 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6387 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6388
cabf1cac
SM
63892011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6390
6391 * textprop.c (text_property_stickiness):
6392 Obey Vtext_property_default_nonsticky.
6393 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6394 * w32fns.c (syms_of_w32fns):
6395 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6396
6e9b2be9
PE
63972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6398
6399 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6400 This is more efficient than Ffile_directory_p and avoids a minor race.
6401
90186c68
LMI
64022011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6403
7c301272
LMI
6404 * buffer.c (Foverlay_put): Say what the return value is
6405 (bug#7835).
6406
c4f2d8d4
LMI
6407 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6408 is a directory before asking whether to use the file name
6409 (bug#7564).
ad637907
LMI
6410 (barf_or_query_if_file_exists): Make the "File is a directory"
6411 error be more correct.
c4f2d8d4 6412
90186c68
LMI
6413 * fns.c (Frequire): Remove the mention of the .gz files, since
6414 that's installation-specific, but keep the mention of
6415 `get-load-suffixes'.
6416
da64016e
PE
64172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6418
6419 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6420 Report string overflow if the output is too long.
6421
7d47b580
JB
64222011-07-04 Juanma Barranquero <lekktu@gmail.com>
6423
a555cb87
JB
6424 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6425 (syms_of_gnutls): Remove duplicate DEFSYM for
6426 Qgnutls_bootprop_verify_hostname_error, an error for
6427 Qgnutls_bootprop_verify_error (which is no longer used).
6428
7d47b580
JB
6429 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6430 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6431 Also (re)move comments that are misplaced or no longer relevant.
6432
1e49bfab
LMI
64332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6434
6435 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6436
1485f4c0
CY
64372011-07-03 Chong Yidong <cyd@stupidchicken.com>
6438
6439 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6440 and background color parameters if they have been changed.
6441
a9ab721e
LMI
64422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6443
6444 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6445
cf7cff57
PE
64462011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6447
2e13213d
PE
6448 * xsettings.c (SYSTEM_FONT): Define only when used.
6449 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6450
cf7cff57
PE
6451 * keymap.c (access_keymap_1): Now static.
6452
7a8e04f7
CY
64532011-07-02 Chong Yidong <cyd@stupidchicken.com>
6454
6455 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6456 leave any prefix arg for the up event (Bug#1586).
6457
61352f62
LMI
64582011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6459
69bb1ef7
LMI
6460 * lread.c (syms_of_lread): Mention single symbols defined by
6461 `defvar' or `defconst' (bug#7154).
6462
61352f62 6463 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6464 (Frequire): Mention get-load-suffixes.
61352f62 6465
28545e04
MR
64662011-07-02 Martin Rudalics <rudalics@gmx.at>
6467
6468 * window.h (window): Remove clone_number slot.
6469 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6470 Remove.
6471 (make_parent_window, make_window, saved_window)
6472 (Fset_window_configuration, save_window_save): Don't deal with
6473 clone numbers.
6474 * buffer.c (Qclone_number): Remove declaration.
6475 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6476
3349e122
SM
64772011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6478
6479 Add multiple inheritance to keymaps.
6480 * keymap.c (Fmake_composed_keymap): New function.
6481 (Fset_keymap_parent): Simplify.
6482 (fix_submap_inheritance): Remove.
6483 (access_keymap_1): New function extracted from access_keymap to handle
6484 embedded parents and handle lists of maps.
6485 (access_keymap): Use it.
6486 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6487 (Fcopy_keymap): Handle embedded parents.
6488 (Fcommand_remapping, define_as_prefix): Simplify.
6489 (Fkey_binding): Simplify.
6490 (syms_of_keymap): Move minibuffer-local-completion-map,
6491 minibuffer-local-filename-completion-map,
6492 minibuffer-local-must-match-map, and
6493 minibuffer-local-filename-must-match-map to Elisp.
6494 (syms_of_keymap): Defsubr make-composed-keymap.
6495 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6496 (parse_menu_item): Trivial simplification.
6497
3279eb87
GM
64982011-07-01 Glenn Morris <rgm@gnu.org>
6499
6500 * Makefile.in (SETTINGS_LIBS): Fix typo.
6501
4550efdf
KI
65022011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6503
6504 * coding.c (Fencode_coding_string): Record the last coding system
6505 used, as the function doc string says (bug#8738).
6506
0949d2b6
JD
65072011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6508
6509 * xsettings.c (store_monospaced_changed): Take new font as arg and
6510 check for change against current_mono_font.
6511 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6512 (emacs_settings_constructor, emacs_settings_get_property)
6513 (emacs_settings_set_property, emacs_settings_class_init)
6514 (emacs_settings_init, gsettings_obj): Remove.
6515 (something_changedCB): New function for HAVE_GSETTINGS.
6516 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6517 with value as argument.
6518 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6519 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6520 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6521 "changed".
6522
6523 * xgselect.c: Add defined (HAVE_GSETTINGS).
6524 (xgselect_initialize): Ditto.
6525
6526 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6527 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6528 xg_select.
6529
bbc6b304
PE
65302011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6531
6532 * eval.c (struct backtrace): Simplify and port the data structure.
6533 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6534 signed bit field, as this assumption is not portable and it makes
6535 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6536 "char debug_on_exit : 1" as this is not portable either; instead,
6537 use the portable "unsigned int debug_on_exit : 1". Remove unused
6538 member evalargs. Remove obsolete comments about cc bombing out.
6539
9851bfc5
JD
65402011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6541
51bb811f 6542 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6543 Let HAVE_GSETTINGS override HAVE_GCONF.
6544 (store_monospaced_changed): New function.
6545 (EMACS_SETTINGS): A new type derived from GObject to handle
6546 GSettings notifications.
6547 (emacs_settings_constructor, emacs_settings_get_property)
6548 (emacs_settings_set_property, emacs_settings_class_init):
6549 New functions.
6550 (gsettings_client, gsettings_obj): New variables.
6551 (GSETTINGS_SCHEMA): New define.
6552 (something_changedCB): Call store_monospaced_changed.
6553 (init_gsettings): New function.
6554 (xsettings_initialize): Call init_gsettings.
6555 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6556 to NULL.
6557
640c8776 6558 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6559 GCONF_CFLAGS/LIBS.
6560
5386012d
MR
65612011-06-29 Martin Rudalics <rudalics@gmx.at>
6562
6563 * window.c (resize_root_window, grow_mini_window)
6564 (shrink_mini_window): Rename Qresize_root_window to
6565 Qwindow_resize_root_window and Qresize_root_window_vertically to
6566 Qwindow_resize_root_window_vertically.
6567
f13e0b08
PE
65682011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6571
94515237
JB
65722011-06-27 Juanma Barranquero <lekktu@gmail.com>
6573
6574 * makefile.w32-in: Redesign dependencies so they reflect more
6575 clearly which files are directly included by each source file,
6576 and not through other includes.
6577
e43b6e43
MR
65782011-06-27 Martin Rudalics <rudalics@gmx.at>
6579
6580 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6581 (sort_overlays, overlay_strings): When an overlay's clone number
6582 matches the window's clone number process the overlay even if
6583 the overlay's window property doesn't match the current window.
6584
d68443dc
MR
6585 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6586 (Fwindow_hchild): Rename to Fwindow_left_child.
6587 (Fwindow_next): Rename to Fwindow_next_sibling.
6588 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6589 (resize_window_check): Rename to window_resize_check.
6590 (resize_window_apply): Rename to window_resize_apply.
6591 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6592 (Fdelete_other_windows_internal, resize_frame_windows)
6593 (Fsplit_window_internal, Fdelete_window_internal)
6594 (grow_mini_window, shrink_mini_window)
6595 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6596
c7e73be5
JD
65972011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6598
6599 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6600 (emacs_fixed_set_min_size): Remove.
6601 (emacs_fixed_new): Take frame as argument.
6602
6603 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6604 (_EmacsFixedPrivate): Remove minwidth/height.
6605 Add struct frame *f.
6606 (emacs_fixed_init): Initialize priv->f.
6607 (get_parent_class, emacs_fixed_set_min_size): Remove.
6608 (emacs_fixed_new): Set priv->f to argument.
6609 (emacs_fixed_get_preferred_width)
6610 (emacs_fixed_get_preferred_height): Use min_width/height from
6611 frames size_hint to set minimum and natural (Bug#8919).
6612 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6613 and use min_width/height from frames size_hint to set
6614 min_width/height (Bug#8919).
6615
6616 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6617 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6618 Fix indentation.
c7e73be5 6619
cf99dcf8
EZ
66202011-06-26 Eli Zaretskii <eliz@gnu.org>
6621
6622 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6623 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6624 called at ZV.
6625
029529ac
CY
66262011-06-26 Chong Yidong <cyd@stupidchicken.com>
6627
6628 * process.c (wait_reading_process_output): Bypass select if
6629 waiting for a cell while ignoring keyboard input, and input is
6630 pending. Suggested by Jan Djärv (Bug#8869).
6631
7a7ef429
PE
66322011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6633
6634 Use gnulib's dup2 module instead of rolling our own.
6635 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6636
11fdef7d 66372011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6638
6639 * dispnew.c (scrolling_window): Before scrolling, turn off a
6640 mouse-highlight in the window being scrolled.
6641
cd3520a4
JB
66422011-06-24 Juanma Barranquero <lekktu@gmail.com>
6643
6644 Move DEFSYM to lisp.h and use everywhere.
6645
6646 * character.h (DEFSYM): Move declaration...
6647 * lisp.h (DEFSYM): ...here.
6648
6649 * gnutls.c:
6650 * minibuf.c:
6651 * w32menu.c:
6652 * w32proc.c:
6653 * w32select.c: Don't include character.h.
6654
6655 * alloc.c (syms_of_alloc):
6656 * buffer.c (syms_of_buffer):
6657 * bytecode.c (syms_of_bytecode):
6658 * callint.c (syms_of_callint):
6659 * casefiddle.c (syms_of_casefiddle):
6660 * casetab.c (init_casetab_once):
6661 * category.c (init_category_once, syms_of_category):
6662 * ccl.c (syms_of_ccl):
6663 * cmds.c (syms_of_cmds):
6664 * composite.c (syms_of_composite):
6665 * dbusbind.c (syms_of_dbusbind):
6666 * dired.c (syms_of_dired):
6667 * dispnew.c (syms_of_display):
6668 * doc.c (syms_of_doc):
6669 * editfns.c (syms_of_editfns):
6670 * emacs.c (syms_of_emacs):
6671 * eval.c (syms_of_eval):
6672 * fileio.c (syms_of_fileio):
6673 * fns.c (syms_of_fns):
6674 * frame.c (syms_of_frame):
6675 * fringe.c (syms_of_fringe):
6676 * insdel.c (syms_of_insdel):
6677 * keymap.c (syms_of_keymap):
6678 * lread.c (init_obarray, syms_of_lread):
6679 * macros.c (syms_of_macros):
6680 * msdos.c (syms_of_msdos):
6681 * print.c (syms_of_print):
6682 * process.c (syms_of_process):
6683 * search.c (syms_of_search):
6684 * sound.c (syms_of_sound):
6685 * syntax.c (init_syntax_once, syms_of_syntax):
6686 * terminal.c (syms_of_terminal):
6687 * textprop.c (syms_of_textprop):
6688 * undo.c (syms_of_undo):
6689 * w32.c (globals_of_w32):
6690 * window.c (syms_of_window):
6691 * xdisp.c (syms_of_xdisp):
6692 * xfaces.c (syms_of_xfaces):
6693 * xfns.c (syms_of_xfns):
6694 * xmenu.c (syms_of_xmenu):
6695 * xsettings.c (syms_of_xsettings):
6696 * xterm.c (syms_of_xterm): Use DEFSYM.
6697
4228cf16
TZ
66982011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6699
cd3520a4 6700 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6701
7fcccf1e
PE
67022011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6703
7efb4e0e
PE
6704 Integer and buffer overflow fixes (Bug#8873).
6705
ff5844ad
PE
6706 * print.c (printchar, strout): Check for string overflow.
6707 (PRINTPREPARE, printchar, strout):
6708 Don't set size unless allocation succeeds.
6709
90532f02
PE
6710 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6711 for sizes. Check for string overflow more accurately.
6712 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6713
6d84508d
PE
6714 * macros.c: Integer and buffer overflow fixes.
6715 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6716 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6717 Use ptrdiff_t, not int, for sizes.
6718 Don't increment bufsize until after realloc succeeds.
6719 Check for size-calculation overflow.
6720 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6721
437b2cb4
PE
6722 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6723
8b9ac8b4
PE
6724 * lread.c: Integer overflow fixes.
6725 (read_integer): Radix is now EMACS_INT, not int,
6726 to improve quality of diagnostics for out-of-range radices.
6727 Calculate buffer size correctly for out-of-range radices.
6728 (read1): Check for integer overflow in radices, and in
6729 read-circle numbers.
82cb60d3
PE
6730 (read_escape): Avoid int overflow.
6731 (Fload, openp, read_buffer_size, read1)
6732 (substitute_object_recurse, read_vector, read_list, map_obarray):
6733 Use ptrdiff_t, not int, for sizes.
6734 (read1): Use EMACS_INT, not int, for sizes.
20270765 6735 Check for size overflow.
8b9ac8b4 6736
7fcccf1e
PE
6737 * image.c (cache_image): Check for size arithmetic overflow.
6738
bfbbd7e7
PE
6739 * lread.c: Integer overflow issues.
6740 (saved_doc_string_size, saved_doc_string_length)
6741 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6742 Now ptrdiff_t, not int.
6743 (read1): Don't assume doc string length fits in int. Check for
6744 out-of-range doc string lengths.
6745 (read_list): Don't assume file position fits in int.
39019e54 6746 (read_escape): Check for hex character overflow.
bfbbd7e7 6747
4e323265
LL
67482011-06-22 Leo Liu <sdl.web@gmail.com>
6749
6750 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6751 Move to minibuffer.el.
6752
85fece3e
PE
67532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6754
20b84ce9 6755 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6756 The following patches are for when GLYPH_DEBUG && !XASSERT.
6757 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6758 * dispnew.c (flush_stdout):
6759 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6760 Mark as externally visible.
6761 * dispnew.c (check_window_matrix_pointers): Now static.
6762 * dispnew.c (window_to_frame_vpos):
6763 * xfns.c (unwind_create_frame):
6764 * xterm.c (x_check_font): Remove unused local.
6765 * scroll.c (CHECK_BOUNDS):
6766 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6767 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6768 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6769 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6770 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6771 Now static.
6772 (debug_method_add): Use va_list and vsprintf rather than relying
6773 on undefined behavior with wrong number of arguments.
6774 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6775 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6776 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6777 since we're not interested in debugging glyphs with old libraries.
6778 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6779 GCC 4.6.0's static checking.
6780
0766b489
PE
67812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6782
31fd4b32
PE
6783 Integer overflow and signedness fixes (Bug#8873).
6784 A few related buffer overrun fixes, too.
6785
b79e8648
PE
6786 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6787
0766b489
PE
6788 * dispextern.h (struct face.stipple):
6789 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6790 (x_bitmap_mask, x_allocate_bitmap_record)
6791 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6792 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6793 (x_create_bitmap_from_xpm_data):
6794 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6795 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6796 (.bitmaps_last):
6797 * xfaces.c (load_pixmap):
6798 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6799 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6800 (.bitmaps_last, struct x_output.icon_bitmap):
6801 Use ptrdiff_t, not int, for bitmap indexes.
6802 (x_allocate_bitmap_record): Check for size overflow.
6803 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6804
b081724f
PE
6805 Use ptrdiff_t, not int, for overlay counts.
6806 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6807 * editfns.c (overlays_around, get_pos_property):
6808 * textprop.c (get_char_property_and_overlay):
6809 * xdisp.c (next_overlay_change, note_mouse_highlight):
6810 * xfaces.c (face_at_buffer_position):
21514da7
PE
6811 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6812 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6813 (Fnext_overlay_change, Fprevious_overlay_change)
6814 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6815 Use ptrdiff_t, not int, for sizes.
21514da7 6816 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6817
3de73e5e
PE
6818 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6819
2606c57b
PE
6820 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6821 (x_session_initialize): Do not assume string length fits in int.
6822
aaafe47a
PE
6823 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6824 This is unlikely, but can occur if DPI is outlandish.
6825
2674ddc8 6826 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6827 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6828
28154962
PE
6829 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6830 * xrdb.c (magic_file_p, search_magic_path):
6831 Omit last arg SUFFIX; it was always 0. All callers changed.
6832 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6833
7de51af5
PE
6834 * xfont.c (xfont_match): Avoid need for strlen.
6835
25ed6cc3
PE
6836 * xfns.c: Don't assume strlen fits in int.
6837 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6838
4eab31dd
PE
6839 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6840 not unsigned long, as we prefer signed integers. All callers changed.
6841 Detect integer overflow in repeat count.
6842 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6843 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6844
171e2a58
PE
6845 * termcap.c: Don't assume sizes fit in int and never overflow.
6846 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6847 (gobble_line): Check for size-calculation overflow.
6848
ad39faca 6849 * minibuf.c (Fread_buffer):
6e5bb2dc 6850 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6851 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6852 Don't assume string length fits in int.
6853
52c61c22 6854 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6855 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6856
b5b8c9e5
PE
6857 * font.c: Don't assume string length fits in int.
6858 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6859 Use ptrdiff_t, not int.
ccd6111c
PE
6860 (font_intern_prop): Don't assume string length fits in int.
6861 Don't assume integer property fits in fixnum.
6862 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6863
882f0d81 6864 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6865 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6866 Reformulate so as not to need the command string.
6867 Invoke gzip -cd rather than gunzip, as it's more portable.
6868 (lock_info_type, lock_file_1, lock_file):
6869 Don't assume pid_t and time_t fit in unsigned long.
6870 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6871 (current_lock_owner): Prefer signed type for sizes.
6872 Use memcpy, not strncpy, where memcpy is what is really wanted.
6873 Don't assume (via atoi) that time_t and pid_t fit in int.
6874 Check for time_t and/or pid_t out of range, e.g., via a network share.
6875 Don't alloca where an auto var works fine.
6876
93f4cf88
PE
6877 * fileio.c: Fix some integer overflow issues.
6878 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6879 Don't assume string length fits in int.
6880 (directory_file_name): Don't assume string length fits in long.
6881 (make_temp_name): Don't assume pid fits in int, or that its print
6882 length is less than 20.
6883
f3e92b69
PE
6884 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6885
1bfdaf10
PE
6886 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6887
35016e9a
PE
6888 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6889
3d1e65a1
PE
6890 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6891 We prefer signed integers, even for size calculations.
6892
0b963a93
PE
6893 * emacs.c: Don't assume string length fits in 'int'.
6894 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6895 (main): Don't invoke strlen when not needed.
6896
573f4b54
PE
6897 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6898 (XD_DEBUG_MESSAGE): Don't waste a byte.
6899
989f33ba
PE
6900 * callproc.c (getenv_internal_1, getenv_internal)
6901 (Fgetenv_internal):
965d34eb
PE
6902 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6903
e4d29b33
PE
6904 * lread.c (invalid_syntax): Omit length argument.
6905 All uses changed. This doesn't fix a bug, but it simplifies the
6906 code away from its former Hollerith-constant appearance, and it's
6907 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6908 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6909
eb49b136
PE
6910 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6911 This didn't break anything, but it didn't help either.
6912 It's confusing to put a bogus integer in a place where the actual
6913 value does not matter.
9f62aeb1 6914 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6915 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6916
15375a22
PE
6917 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6918 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6919 implementation.
b61cc01c
PE
6920 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6921 We prefer signed types, and the value cannot exceed the EMACS_INT
6922 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6923 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6924 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6925 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6926
53b2623d
PE
6927 * indent.c (sane_tab_width): New function.
6928 (current_column, scan_for_column, Findent_to, position_indentation)
6929 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6930 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6931
51cab52b 6932 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6933
f2ed8a70
PE
6934 * lisp.h (lint_assume): New macro.
6935 * composite.c (composition_gstring_put_cache):
6936 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6937
abe80cc6
PE
6938 * editfns.c, insdel.c:
6939 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6940
b02c740e
PE
6941 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6942
ebc96716
PE
6943 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6944
b4e50fa0 6945 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6946 Use much-faster test for byte-length change.
311d5d7c 6947 Don't assume string byte-length fits in 'int'.
a4cf38e4 6948 Check that character arg fits in 'int'.
85461888 6949 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6950
c0c1ee9f
PE
6951 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6952
a498d7f4
PE
6953 * fns.c (concat): Catch string overflow earlier.
6954 Do not rely on integer wraparound.
6955
51cab52b
PE
6956 * dispextern.h (struct it.overlay_strings_charpos)
6957 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6958 * xdisp.c (forward_to_next_line_start)
6959 (back_to_previous_visible_line_start)
6960 (reseat_at_next_visible_line_start, next_element_from_buffer):
6961 Don't arbitrarily truncate the value of 'selective' to int.
6962
76031fad
PE
6963 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6964
5eb55db9
PE
6965 * composite.c: Don't truncate sizes to 'int'.
6966 (composition_gstring_p, composition_reseat_it)
6967 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6968 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6969 not EMACS_UINT, for indexes.
5eb55db9 6970
0703a717
PE
6971 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6972
d6202519
PE
6973 * buffer.c: Include <verify.h>.
6974 (struct sortvec.priority, struct sortstr.priority):
8961a454 6975 Now EMACS_INT, not int.
c20998a7 6976 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6977 (struct sortstr.size, record_overlay_string)
6978 (struct sortstrlist.size, struct sortlist.used):
6979 Don't truncate size to int.
6980 (record_overlay_string): Check for size-calculation overflow.
d6202519 6981 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6982
d5a19415
JM
69832011-06-22 Jim Meyering <meyering@redhat.com>
6984
029529ac 6985 Don't leak an XBM-image-sized buffer
d5a19415
JM
6986 * image.c (xbm_load): Free the image buffer after using it.
6987
a9041e6c
PE
69882011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6989
6990 Port to Sun C.
6991 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6992 that Sun C diagnosed.
6993 * fns.c (secure_hash): Fix pointer signedness issue.
6994 * intervals.c (static_offset_intervals): New function.
6995 (offset_intervals): Use it.
6996
7f3f739f
LL
69972011-06-21 Leo Liu <sdl.web@gmail.com>
6998
6999 * deps.mk (fns.o):
7000 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7001 sha512.h.
7002
7003 * fns.c (secure_hash): Rename from crypto_hash_function and change
7004 the first arg to accept symbols.
5b66d427 7005 (Fsecure_hash): New primitive.
7f3f739f
LL
7006 (syms_of_fns): New symbols.
7007
76147d94
DD
70082011-06-20 Deniz Dogan <deniz@dogan.se>
7009
7010 * process.c (Fset_process_buffer): Clarify return value in
7011 docstring.
7012
7d7d0045
CY
70132011-06-18 Chong Yidong <cyd@stupidchicken.com>
7014
7015 * dispnew.c (add_window_display_history): Use BVAR.
7016
7017 * xdisp.c (debug_method_add): Use BVAR.
7018 (check_window_end, dump_glyph_matrix, dump_glyph)
7019 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7020
7021 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7022 Likewise.
7023
7024 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7025 check till after the cache is created in init_frame_faces.
7026
ff2bc410
SM
70272011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7028
7029 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7030
28177add
PE
70312011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7032
dd3482fe
PE
7033 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7034 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7035 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7036
393d71f3 7037 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7038 * fileio.c (Finsert_file_contents):
7039 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7040 Remove the old (too-loose) buffer overflow checks.
7041 They weren't needed, since make_gap checks for buffer overflow.
7042 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7043 The old code merely checked for Emacs fixnum overflow, and relied
7044 on undefined (wraparound) behavior. The new code avoids undefined
7045 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7046
2e6813b0 7047 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7048 Tune. Don't use wider integers than needed. Don't use alloca.
7049 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7050
599a9e4f
PE
7051 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7052
99561444
PE
7053 * insdel.c, lisp.h (buffer_overflow): New function.
7054 (insert_from_buffer_1, replace_range, replace_range_2):
7055 * insdel.c (make_gap_larger):
7056 * editfns.c (Finsert_char):
7057 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7058
28177add
PE
7059 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7060
e69dafad
PE
70612011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7062
4baa020d 7063 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7064
b1c46f02
PE
7065 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7066 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7067
e69dafad
PE
7068 * fileio.c: Don't assume EMACS_INT fits in off_t.
7069 (emacs_lseek): New static function.
7070 (Finsert_file_contents, Fwrite_region): Use it.
7071 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7072
566684ea
PE
7073 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7074
e6966cd6
PE
7075 * fns.c: Don't overflow int when computing a list length.
7076 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7077 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7078 truncation on 64-bit hosts. Check for QUIT every
7079 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7080 faster and is responsive enough.
7081 (Flength): Report an error instead of overflowing an integer.
7082 (Fsafe_length): Return a float if the value is not representable
7083 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7084 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7085 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7086
dd0b0efb
PE
7087 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7088 (header_size, word_size): New constants.
7089 (allocate_vectorlike): Don't check size overflow here.
7090 (allocate_vector): Check it here instead, since this is the only
7091 caller of allocate_vectorlike that could cause overflow.
7092 Check that the new vector's length is representable as a fixnum.
7093
86fe5cfe
PE
7094 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7095 The previous code was bogus. For example, next_almost_prime (32)
7096 returned 39, which is undesirable as it is a multiple of 3; and
7097 next_almost_prime (24) returned 25, which is a multiple of 5 so
7098 why was the code bothering to check for multiples of 7?
7099
80e88859
PE
7100 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7101
4a2f0ad6
PE
7102 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7103
f66c7cf8
PE
7104 Variadic C functions now count arguments with ptrdiff_t.
7105 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7106 Back then I didn't know that the Emacs coding style prefers signed int.
7107 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7108 were being counted with int, which may truncate counts on 64-bit
7109 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7110 * lisp.h (struct Lisp_Subr.function.aMANY)
7111 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7112 Arg counts are now ptrdiff_t, not size_t.
7113 All variadic functions and their callers changed accordingly.
7114 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7115 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7116 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7117 * callint.c (Fcall_interactively): Check arg count for overflow,
7118 to avoid potential buffer overrun. Use signed char, not 'int',
7119 for 'varies' array, so that we needn't bother to check its size
7120 calculation for overflow.
7121 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7122 * eval.c (apply_lambda):
7123 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7124 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7125 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7126
a1759b76
PE
7127 * callint.c (Fcall_interactively): Don't use index var as event count.
7128
d96be9fc
PE
7129 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7130 * mem-limits.h (SIZE): Remove; no longer used.
7131
a690a978 7132 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7133
578c21e6
PE
7134 Remove unnecessary casts.
7135 * xterm.c (x_term_init):
7136 * xfns.c (x_set_border_pixel):
7137 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7138 These aren't needed now that we assume ANSI C.
7139
96f53c6c
PE
7140 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7141 It's more likely to cause problems (due to unsigned overflow)
7142 than to cure them.
7143
83c77d31
PE
7144 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7145
ee2079f1
PE
7146 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7147
6da65536
PE
7148 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7149
7147c4a4
PE
7150 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7151
193e32d9
PE
7152 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7153
e5533da6
PE
7154 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7155
9910e595
PE
7156 GLYPH_CODE_FACE returns EMACS_INT, not int.
7157 * dispextern.h (merge_faces):
7158 * xfaces.c (merge_faces):
01103c44
PE
7159 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7160 Don't assume EMACS_INT fits in int.
9910e595 7161
2638320e
PE
7162 * character.h (CHAR_VALID_P): Remove unused parameter.
7163 * fontset.c, lisp.h, xdisp.c: All uses changed.
7164
045eb8d9
PE
7165 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7166
c1f134b5
PE
7167 * fns.c (concat): Minor tuning based on overflow analysis.
7168 This doesn't fix any bugs. Use int to hold character, instead
7169 of constantly refetching from Emacs object. Use XFASTINT, not
7170 XINT, for value known to be a character. Don't bother comparing
7171 a single byte to 0400, as it's always less.
7172
395fcb93 7173 * floatfns.c (Fexpt):
327eeec8
PE
7174 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7175
abbd3d23
PE
7176 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7177 for characters.
7178
684a03ef
PE
7179 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7180
0fed43f3
PE
7181 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7182 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7183 incorrectly succeed when S was a string, because 4294967386 was
7184 truncated before it was used.
7185
8fd02eb7
PE
7186 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7187 Otherwise, an out-of-range integer could cause undefined behavior
7188 on a 64-bit host.
7189
f8c86b69
PE
7190 * composite.c: Use int, not EMACS_INT, for characters.
7191 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7192 EMACS_INT, for values that are known to be in character range.
7193 This doesn't fix any bugs but is the usual style inside Emacs and
7194 may generate better code on 32-bit machines.
7195
34206dd2
PE
7196 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7197 This is for reasons similar to the recent CHAR_STRING fix.
7198 * charset.c (Fencode_char): Check that character arg is actually
7199 a character. Pass an int to ENCODE_CHAR.
7200 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7201 wider than 'int', as a compile-time check to prevent future regressions
7202 in this area.
7203
c5958d4c 7204 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7205
7206 Make sure a 64-bit char is never passed to CHAR_STRING.
7207 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7208 by silently ignoring the top 32 bits, allowing some values
7209 that were far too large to be valid characters.
7210 * character.h: Include <verify.h>.
7211 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7212 arguments are no wider than unsigned, as a compile-time check
7213 to prevent future regressions in this area.
7214 * data.c (Faset):
01103c44 7215 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7216 (Fsubst_char_in_region):
7217 * fns.c (concat):
7218 * xdisp.c (decode_mode_spec_coding):
7219 Adjust to CHAR_STRING's new requirement.
7220 * editfns.c (Finsert_char, Fsubst_char_in_region):
7221 * fns.c (concat): Check that character args are actually
7222 characters. Without this test, these functions did the wrong
7223 thing with wildly out-of-range values on 64-bit hosts.
7224
d37ca623
PE
7225 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7226 These casts should not be needed on 32-bit hosts, either.
7227 * keyboard.c (read_char):
7228 * lread.c (Fload): Remove casts to unsigned.
7229
ea204efb
PE
7230 * lisp.h (UNSIGNED_CMP): New macro.
7231 This fixes comparison bugs on 64-bit hosts.
7232 (ASCII_CHAR_P): Use it.
7233 * casefiddle.c (casify_object):
01103c44 7234 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7235 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7236 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7237 * dispextern.h (FACE_FROM_ID):
7238 * keyboard.c (read_char): Use UNSIGNED_CMP.
7239
41cb286c
PE
7240 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7241 not to EMACS_INT, to avoid GCC warning.
7242
4a1b9832
PE
7243 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7244
55daad71
PE
7245 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7246 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7247 isn't needed on 32-bit machines.
8f95c75c 7248
01103c44
PE
7249 * buffer.c (Fgenerate_new_buffer_name):
7250 Use EMACS_INT for count, not int.
0ceccced 7251 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7252
7253 * data.c (Qcompiled_function): Now static.
7254
c6f072e7
PE
7255 * window.c (window_body_lines): Now static.
7256
20ce5912
PE
7257 * image.c (gif_load): Rename local to avoid shadowing.
7258
9c4c5f81
PE
7259 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7260 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7261 * alloc.c (make_save_value): Integer argument is now of type
7262 ptrdiff_t, not int.
7263 (mark_object): Use ptrdiff_t, not int.
7264 * lisp.h (pD): New macro.
7265 * print.c (print_object): Use it.
7266
c0c5c8ae
PE
7267 * alloc.c: Use EMACS_INT, not int, to count objects.
7268 (total_conses, total_markers, total_symbols, total_vector_size)
7269 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7270 (total_free_floats, total_floats, total_free_intervals)
7271 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7272 Now EMACS_INT, not int. All uses changed.
7273 (Fgarbage_collect): Compute overall total using a double, so that
7274 integer overflow is less likely to be a problem. Check for overflow
7275 when converting back to an integer.
5a25e253
PE
7276 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7277 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7278 These were 'int' variables that could overflow on 64-bit hosts;
7279 they were never used, so remove them instead of repairing them.
211a0b2a 7280 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7281 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7282 Previously, this ceilinged at INT_MAX, but that doesn't work on
7283 64-bit machines.
e46bb31a 7284 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7285
c78baabf 7286 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7287 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7288 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7289 when a (possibly-narrower) signed value would do just as well.
7290 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7291
c9d624c6
PE
7292 * alloc.c: Catch some string size overflows that we were missing.
7293 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7294 for convenience in STRING_BYTES_MAX.
7295 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7296 The definition here is exact; the one in lisp.h was approximate.
7297 (allocate_string_data): Check for string overflow. This catches
7298 some instances we weren't catching before. Also, it catches
7299 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7300 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7301 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7302
c9d624c6
PE
7303 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7304 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7305 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7306
353032ce
PE
7307 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7308
2bccce07
PE
7309 * alloc.c (Fmake_string): Check for out-of-range init.
7310
0ac30604
SM
73112011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7312
7313 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7314
c195f2de
JD
73152011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7316
7317 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7318 xg_get_default_scrollbar_width.
7319
7320 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7321 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7322 (style_changed_cb): Call update_theme_scrollbar_width and call
7323 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7324 all frames (Bug#8505).
7325 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7326 Call gtk_window_set_resizable if HAVE_GTK3.
7327 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7328 and height if HAVE_GTK3 (Bug#8505).
7329 (scroll_bar_width_for_theme): New variable.
7330 (update_theme_scrollbar_width): New function.
7331 (xg_get_default_scrollbar_width): Move code to
7332 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7333 (xg_initialize): Call update_theme_scrollbar_width.
7334
7335 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7336
7337 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7338
e10ac9f1
MR
73392011-06-12 Martin Rudalics <rudalics@gmx.at>
7340
7341 * frame.c (make_frame): Call other_buffer_safely instead of
7342 other_buffer.
7343
7344 * window.c (temp_output_buffer_show): Call display_buffer with
7345 second argument Vtemp_buffer_show_specifiers and reset latter
7346 immediately after the call.
7347 (Vtemp_buffer_show_specifiers): New variable.
7348 (auto_window_vscroll_p, next_screen_context_lines)
7349 (Vscroll_preserve_screen_position): Remove leading asterisks from
7350 doc-strings.
7351
2d3c217e 73522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7353
7b7f97e8 7354 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7355 * buffer.c (Qclone_number): Remove for now, as it's unused.
7356 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7357 (record_buffer): Remove unused local.
7358 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7359 (set_frame_buffer_list): Remove; unused.
7360 * frame.h (other_visible_frames): Remove decl.
7361 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7362 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7363 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7364 if HAVE_GPM.
7365 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7366 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7367 Define only if HAVE_GPM.
7368 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7369 (update_hints_inhibit): Remove; never set. All uses removed.
7370 * widgetprv.h (emacsFrameClassRec): Remove decl.
7371 * window.c (delete_deletable_window): Now returns void, since it
7372 wasn't returning anything.
7373 (compare_window_configurations): Remove unused locals.
7374 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7375 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7376 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7377 the same widths as pointers. This follows up on the 2011-05-06 patch.
7378 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7379 * xterm.h: Likewise.
7380 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7381
1384b89e
JB
73822011-06-12 Juanma Barranquero <lekktu@gmail.com>
7383
7384 * makefile.w32-in: Update dependencies.
7385 (LISP_H): Add lib/intprops.h.
7386
1100a63c
CY
73872011-06-11 Chong Yidong <cyd@stupidchicken.com>
7388
7389 * image.c (gif_load): Add animation frame delay to the metadata.
7390 (syms_of_image): Use DEFSYM. New symbol `delay'.
7391
6198ccd0
MR
73922011-06-11 Martin Rudalics <rudalics@gmx.at>
7393
7394 * window.c (delete_deletable_window): Re-add.
7395 (Fset_window_configuration): Rewrite to handle dead buffers and
7396 consequently deletable windows.
7397 (window_tree, Fwindow_tree): Remove. Supply functionality in
7398 window.el.
7399 (compare_window_configurations): Simplify code.
7400
b6e3633c
AS
74012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7402
1ab0dee5
AS
7403 * image.c (imagemagick_load_image): Fix type mismatch.
7404 (Fimagemagick_types): Likewise.
7405
b6e3633c
AS
7406 * window.h (replace_buffer_in_windows): Declare.
7407
9397e56f
MR
74082011-06-11 Martin Rudalics <rudalics@gmx.at>
7409
7410 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7411 Qclone_number. Remove external declaration of Qdelete_window.
7412 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7413 code.
640c8776
SM
7414 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7415 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7416 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7417 buffer list implementation.
7418 (other_buffer_safely): New function.
7419 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7420 calls to replace_buffer_in_windows and
7421 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7422 if allowed.
7423 (record_buffer): Inhibit quitting and rewrite using quittable
7424 functions. Run Qbuffer_list_update_hook if allowed.
7425 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7426 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7427 Move switch-to-buffer to window.el.
9397e56f
MR
7428 (bury-buffer): Move to window.el.
7429 (Vbuffer_list_update_hook): New variable.
7430
7431 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7432 section.
7433
7434 * window.h (resize_frame_windows): Move up in code.
7435 (Fwindow_frame): Remove EXFUN.
7436 (replace_buffer_in_all_windows): Remove prototype.
7437 (replace_buffer_in_windows_safely): Add prototype.
7438
7439 * window.c: Declare Qdelete_window static again. Move down
7440 declaration of select_count.
7441 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7442 (Fother_window): Move to window.el.
7443 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7444 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7445 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7446 window.el.
7447 (replace_buffer_in_windows): Implement by calling
7448 Qreplace_buffer_in_windows.
7449 (replace_buffer_in_all_windows): Remove with some functionality
7450 moved into replace_buffer_in_windows_safely.
7451 (replace_buffer_in_windows_safely): New function.
7452 (select_window_norecord, select_frame_norecord): Move in front
7453 of run_window_configuration_change_hook. Remove now obsolete
7454 declarations.
640c8776
SM
7455 (Fset_window_buffer): Rewrite doc-string.
7456 Call Qrecord_window_buffer.
9397e56f
MR
7457 (keys_of_window): Move binding for other-window to window.el.
7458
b50691aa
CY
74592011-06-11 Chong Yidong <cyd@stupidchicken.com>
7460
7461 * dispextern.h (struct image): Replace data member, whose int_val
7462 and ptr_val fields were not used by anything, with a single
7463 lisp_val object.
7464
7465 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7466 (gif_clear_image, gif_load, imagemagick_load_image)
7467 (gs_clear_image, gs_load): Callers changed.
7468
3f754b86
PE
74692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7470
cca69397
PE
7471 * buffer.h: Include <time.h>, for time_t.
7472 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7473
109e28d0
PE
7474 Fix minor problems found by static checking.
7475
60737f02
PE
7476 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7477
4b66faf3
PE
7478 Make identifiers static if they are not used in other modules.
7479 * data.c (Qcompiled_function, Qframe, Qvector):
7480 * image.c (QimageMagick, Qsvg):
7481 * minibuf.c (Qmetadata):
7482 * window.c (resize_window_check, resize_root_window): Now static.
7483 * window.h (resize_window_check, resize_root_window): Remove decls.
7484
109e28d0
PE
7485 * window.c (window_deletion_count, delete_deletable_window):
7486 Remove; unused.
46a4ce9e
PE
7487 (window_body_lines): Now static.
7488 (Fdelete_other_windows_internal): Mark vars as initialized.
7489 Make sure 'resize_failed' is initialized.
7490 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7491 (resize_window_apply): Remove unused local.
7492 * window.h (delete_deletable_window): Remove decl.
7493
109e28d0 7494 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7495 (imagemagick_load_image): Fix pointer signedness problem by changing
7496 last arg from unsigned char * to char *. All uses changed.
7497 Also, fix a local for similar reasons.
7498 Remove unused locals. Remove locals to avoid shadowing.
7499 (fn_rsvg_handle_free): Remove; unused.
7500 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7501 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7502
3f754b86
PE
7503 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7504
2547adb1
CY
75052011-06-10 Chong Yidong <cyd@stupidchicken.com>
7506
7507 * image.c (gif_load): Fix omitted cast error introduced by
7508 2011-06-06 change.
7509
2c8e37d4
MR
75102011-06-10 Martin Rudalics <rudalics@gmx.at>
7511
7512 * window.h (resize_proportionally, orig_total_lines)
7513 (orig_top_line): Remove from window structure.
7514 (set_window_height, set_window_width, change_window_heights)
7515 (Fdelete_window): Remove prototypes.
7516 (resize_frame_windows): Remove duplicate declaration.
7517
440a42e3
EZ
75182011-06-10 Eli Zaretskii <eliz@gnu.org>
7519
7520 * window.h (resize_frame_windows, resize_window_check)
7521 (delete_deletable_window, resize_root_window)
7522 (resize_frame_windows): Declare prototypes.
7523
7524 * window.c (resize_window_apply): Make definition be "static" to
7525 match the prototype.
7526
562dd5e9
MR
75272011-06-10 Martin Rudalics <rudalics@gmx.at>
7528
7529 * window.c: Remove declarations of Qwindow_size_fixed,
7530 window_min_size_1, window_min_size_2, window_min_size,
7531 size_window, window_fixed_size_p, enlarge_window, delete_window.
7532 Remove static from declaration of Qdelete_window, it's
7533 temporarily needed by Fbury_buffer.
7534 (replace_window): Don't assign orig_top_line and
7535 orig_total_lines.
7536 (Fdelete_window, delete_window): Remove. Window deletion is
7537 handled by window.el.
640c8776
SM
7538 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7539 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7540 (Fdelete_other_windows): Remove. Deleting other windows is
7541 handled by window.el.
7542 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7543 handled in window.el.
7544 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7545 Window minimum sizes are handled in window.el.
7546 (shrink_windows, size_window, set_window_height)
7547 (set_window_width, change_window_heights, window_height)
7548 (window_width, CURBEG, CURSIZE, enlarge_window)
7549 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7550 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7551 handled in window.el.
7552 (make_dummy_parent): Rename to make_parent_window and give it a
7553 second argument horflag.
7554 (make_window): Don't set resize_proportionally any more.
7555 (Fsplit_window): Remove. Windows are split in window.el.
7556 (save_restore_action, save_restore_orig_size)
7557 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7558 Resize mini windows in window.el.
7559 (grow_mini_window, shrink_mini_window): Implement by calling
7560 Qresize_root_window_vertically, resize_window_check and
7561 resize_window_apply.
640c8776
SM
7562 (saved_window, Fset_window_configuration, save_window_save):
7563 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7564 resize_proportionally.
7565 (window_min_height, window_min_width): Move to window.el.
7566 (keys_of_window): Move bindings for delete-other-windows,
7567 split-window, delete-window and enlarge-window to window.el.
7568
7569 * buffer.c: Temporarily extern Qdelete_window.
7570 (Fbury_buffer): Temporarily call Qdelete_window instead of
7571 Fdelete_window (Fbury_buffer will move to window.el soon).
7572
7573 * frame.c (set_menu_bar_lines_1): Remove code handling
7574 orig_top_line and orig_total_lines.
7575
7576 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7577 set_window_height but set heights directly.
7578 (change_frame_size_1): Use resize_frame_windows.
7579
7580 * xdisp.c (init_xdisp): Don't use set_window_height but set
7581 heights directly.
7582
640c8776
SM
7583 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7584 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7585 run_window_configuration_change_hook.
7586
7587 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7588 instead of change_window_heights and run
7589 run_window_configuration_change_hook.
7590
1a13852e
MR
75912011-06-09 Martin Rudalics <rudalics@gmx.at>
7592
7593 * window.c (replace_window): Rename second argument REPLACEMENT to
7594 NEW. New third argument SETFLAG. Rewrite.
7595 (delete_window, make_dummy_parent): Call replace_window with
7596 third argument 1.
7597 (window_list_1): Move down in code.
7598 (run_window_configuration_change_hook): Move set_buffer part
7599 before select_frame_norecord part in order to unwind correctly.
7600 Rename count1 to count.
7601 (recombine_windows, delete_deletable_window, resize_root_window)
7602 (Fdelete_other_windows_internal)
7603 (Frun_window_configuration_change_hook, make_parent_window)
7604 (resize_window_check, resize_window_apply, Fresize_window_apply)
7605 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7606 (Fdelete_window_internal, Fresize_mini_window_internal):
7607 New functions.
1a13852e
MR
7608 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7609
f3d1777e
MR
76102011-06-08 Martin Rudalics <rudalics@gmx.at>
7611
496e208e
MR
7612 * window.h (window): Add some new members to window structure -
7613 normal_lines, normal_cols, new_total, new_normal, clone_number,
7614 splits, nest, prev_buffers, next_buffers.
7615 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7616 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7617
f3d1777e
MR
7618 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7619 Remove.
496e208e
MR
7620 (make_dummy_parent): Set new members of windows structure.
7621 (make_window): Move down in code. Handle new members of window
7622 structure.
7623 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7624 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7625 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7626 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7627 (Fset_window_next_buffers, Fset_window_clone_number):
7628 New functions.
496e208e
MR
7629 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7630 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7631 Doc-string fixes.
7632 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7633 Argument WINDOW can be now internal window too.
7634 (Fwindow_use_time): Move up in code.
7635 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7636 Rewrite doc-string.
7637 (Fset_window_configuration, saved_window)
7638 (Fcurrent_window_configuration, save_window_save): Handle new
7639 members of window structure.
b9e809c2
MR
7640 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7641 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7642 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7643 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7644 Qget_mru_window, Qresize_root_window,
7645 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7646 Qauto_buffer_name; staticpro them.
f3d1777e 7647
abde8f8c
MR
76482011-06-07 Martin Rudalics <rudalics@gmx.at>
7649
7650 * window.c (Fwindow_total_size, Fwindow_left_column)
7651 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7652 (Fwindow_list_1): New functions.
7653 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7654 (Fwindow_width, Fscroll_left, Fscroll_right):
7655 Use window_body_cols instead of window_box_text_cols.
7656 (delete_window, Fset_window_configuration):
7657 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7658 (delete_all_subwindows): Take a window as argument and not a
7659 structure. Rewrite.
190b47e6
MR
7660 (window_loop): Remove handling of GET_LRU_WINDOW and
7661 GET_LARGEST_WINDOW.
7662 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7663
7664 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7665 window_box_text_cols. delete_all_subwindows now takes a
7666 Lisp_Object as argument.
abde8f8c 7667
640c8776
SM
7668 * indent.c (compute_motion, Fcompute_motion):
7669 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7670
fa8a67e6
MR
7671 * frame.c (delete_frame): Call delete_all_subwindows with root
7672 window as argument.
7673
a54e3482
DC
76742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7675
7676 * fns.c (Fputhash): Document return value.
7677
60002bf5
CY
76782011-06-06 Chong Yidong <cyd@stupidchicken.com>
7679
7680 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7681
0c671da6 76822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7683
b862a52a 7684 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7685
be44ca6c
PE
7686 Check for overflow when converting integer to cons and back.
7687 * charset.c (Fdefine_charset_internal, Fdecode_char):
7688 Use cons_to_unsigned to catch overflow.
7689 (Fencode_char): Use INTEGER_TO_CONS.
7690 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7691 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7692 * data.c (long_to_cons, cons_to_long): Remove.
7693 (cons_to_unsigned, cons_to_signed): New functions.
7694 These signal an error for invalid or out-of-range values.
7695 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7696 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7697 * font.c (Ffont_variation_glyphs):
7698 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7699 * lisp.h: Include <intprops.h>.
7700 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7701 (cons_to_signed, cons_to_unsigned): New decls.
7702 (long_to_cons, cons_to_long): Remove decls.
7703 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7704 (Fprimitive_undo): Use CONS_TO_INTEGER.
7705 * xfns.c (Fx_window_property): Likewise.
7706 * xselect.c: Include <limits.h>.
7707 (x_own_selection, selection_data_to_lisp_data):
7708 Use INTEGER_TO_CONS.
7709 (x_handle_selection_request, x_handle_selection_clear)
7710 (x_get_foreign_selection, Fx_disown_selection_internal)
7711 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7712 (lisp_data_to_selection_data): Use cons_to_unsigned.
7713 (x_fill_property_data): Use cons_to_signed.
7714 Report values out of range.
7715
d1f3d2af
PE
7716 Check for buffer and string overflow more precisely.
7717 * buffer.h (BUF_BYTES_MAX): New macro.
7718 * lisp.h (STRING_BYTES_MAX): New macro.
7719 * alloc.c (Fmake_string):
7720 * character.c (string_escape_byte8):
7721 * coding.c (coding_alloc_by_realloc):
7722 * doprnt.c (doprnt):
7723 * editfns.c (Fformat):
7724 * eval.c (verror):
7725 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7726 since they may not be the same number.
7727 * editfns.c (Finsert_char):
7728 * fileio.c (Finsert_file_contents):
7729 Likewise for BUF_BYTES_MAX.
7730
dd52fcea
PE
7731 * image.c: Use ptrdiff_t, not int, for sizes.
7732 (slurp_file): Switch from int to ptrdiff_t.
7733 All uses changed.
7734 (slurp_file): Check that file size fits in both size_t (for
7735 malloc) and ptrdiff_t (for sanity and safety).
7736
7f9bbdbb
PE
7737 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7738 if b->modtime has its maximal value.
7739
dfe18f82
PE
7740 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7741
84acfcf0
PE
7742 Don't assume time_t can fit into int.
7743 * buffer.h (struct buffer.modtime): Now time_t, not int.
7744 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7745 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7746
ccd9a01a
PE
7747 Minor fixes for signed vs unsigned integers.
7748 * character.h (MAYBE_UNIFY_CHAR):
7749 * charset.c (maybe_unify_char):
7750 * keyboard.c (read_char, reorder_modifiers):
7751 XINT -> XFASTINT, since the integer must be nonnegative.
7752 * ftfont.c (ftfont_spec_pattern):
7753 * keymap.c (access_keymap, silly_event_symbol_error):
7754 XUINT -> XFASTINT, since the integer must be nonnegative.
7755 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7756 since it makes no difference and we prefer signed.
7757 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7758 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7759 nonnegative.
7760
d6d100dd
SM
77612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7762
7763 * window.h (Fwindow_frame): Declare.
7764
2b6148e4
PE
77652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7766
7767 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7768 (SPARE_MEMORY): Always define.
7769 (LARGE_REQUEST): Remove.
7770 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7771
f230ecc9
MR
77722011-06-06 Martin Rudalics <rudalics@gmx.at>
7773
727e958e
MR
7774 * lisp.h: Move EXFUNS for Fframe_root_window,
7775 Fframe_first_window and Fset_frame_selected_window to window.h.
7776
7777 * window.h: Move EXFUNS for Fframe_root_window,
7778 Fframe_first_window and Fset_frame_selected_window here from
7779 lisp.h.
7780
7781 * frame.c (Fwindow_frame, Fframe_first_window)
7782 (Fframe_root_window, Fframe_selected_window)
7783 (Fset_frame_selected_window): Move to window.c.
7784 (Factive_minibuffer_window): Move to minibuf.c.
7785 (Fother_visible_frames_p): New function.
7786
7787 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7788
f230ecc9
MR
7789 * window.c (decode_window, decode_any_window): Move up in code.
7790 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7791 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7792 (Fwindow_buffer): Move up and rewrite doc-string.
7793 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7794 (Fwindow_prev): New functions.
727e958e
MR
7795 (Fwindow_frame): Move here from frame.c. Accept any window as
7796 argument.
7797 (Fframe_root_window, Fframe_first_window)
7798 (Fframe_selected_window): Move here from frame.c. Accept frame
7799 or arbitrary window as argument. Update doc-strings.
7800 (Fminibuffer_window): Move up in code.
7801 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7802 (Fset_frame_selected_window): Move here from frame.c.
7803 Marginal rewrite.
727e958e
MR
7804 (Fselected_window, select_window, Fselect_window): Move up in
7805 code. Minor doc-string fixes.
f230ecc9 7806
4d09bcf6
PE
78072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7808
7809 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7810 Do not assume that spare memory exists; that assumption is valid
7811 only if SYSTEM_MALLOC.
7812 (LARGE_REQUEST): New macro, so that the issue of large requests
7813 is separated from the issue of spare memory.
7814
810928a2
AS
78152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7816
172418ad
AS
7817 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7818 format. (Bug#8806)
7819
43f862f7
AS
7820 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7821
810928a2
AS
7822 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7823 before statements.
7824
a059fe24
JD
78252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7826
7827 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7828
7829 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7830
7831 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7832 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7833
989bf368
JB
78342011-06-05 Juanma Barranquero <lekktu@gmail.com>
7835
7836 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7837
4b80f674
CY
78382011-06-04 Chong Yidong <cyd@stupidchicken.com>
7839
7840 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7841 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7842 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7843 New error handlers.
4b80f674
CY
7844 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7845 Obey Vx_select_enable_clipboard_manager. Catch errors in
7846 x_clipboard_manager_save (Bug#8779).
7847 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7848 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7849
99a33b77 78502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7851
7852 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7853
99a33b77 78542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7855
7856 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7857 in the current matrix if keep_current_p is non-zero.
7858
8264569d
EZ
78592011-06-04 Eli Zaretskii <eliz@gnu.org>
7860
7861 * bidi.c (bidi_level_of_next_char): Fix last change.
7862
57f97249
EZ
78632011-06-03 Eli Zaretskii <eliz@gnu.org>
7864
fec2107c 7865 Support bidi reordering of text covered by display properties.
57f97249 7866
fec2107c
EZ
7867 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7868 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7869 (bidi_cache_search, bidi_cache_iterator_state)
7870 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7871 (bidi_level_of_next_char, bidi_move_to_visually_next):
7872 Support character positions inside a run of characters covered by a
fec2107c
EZ
7873 display string.
7874 (bidi_paragraph_init, bidi_resolve_explicit_1)
7875 (bidi_level_of_next_char): Call bidi_fetch_char and
7876 bidi_fetch_char_advance instead of FETCH_CHAR and
7877 FETCH_CHAR_ADVANCE.
7878 (bidi_init_it): Initialize new members.
7879 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7880 definitions.
7881 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7882 instead of using explicit *_CHAR codes.
d6d100dd
SM
7883 (bidi_resolve_explicit, bidi_resolve_weak):
7884 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7885 bidirectional text is supported only in multibyte buffers.
7886 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7887 it to initialize the frame_window_p member of struct bidi_it.
7888 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7889 (bidi_resolve_explicit, bidi_resolve_weak)
7890 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7891 bidi_it->nchars is non-positive.
7892 (bidi_level_of_next_char): Don't try to lookup the cache for the
7893 next/previous character if nothing is cached there yet, or if we
7894 were just reseat()'ed to a new position.
c40e2fb2 7895
0e14fe90
EZ
7896 * xdisp.c (set_cursor_from_row): Set start and stop points
7897 according to the row's direction when priming the loop that looks
7898 for the glyph on which to display cursor.
7899 (single_display_spec_intangible_p): Function deleted.
7900 (display_prop_intangible_p): Reimplement to call
7901 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7902 Accept 3 additional arguments needed by handle_display_spec.
7903 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7904 values: lists, `(when COND...)' forms, etc.
7905 (single_display_spec_string_p): Support property values that are
7906 lists with the argument STRING its top-level element.
7907 (display_prop_string_p): Fix the condition for processing a
7908 property that is a list to be consistent with handle_display_spec.
fec2107c 7909 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7910 last portion of handle_display_prop.
7911 (compute_display_string_pos): Accept additional argument
7912 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7913 value of a `display' property is a "replacing spec".
7914 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7915 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7916 the display property, but just return a value indicating whether
7917 the display property will replace the characters it covers.
7918 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7919 frame_window_p members of struct bidi_it.
d6d100dd
SM
7920 (compute_display_string_pos, compute_display_string_end):
7921 New functions.
fec2107c
EZ
7922 (push_it): Accept second argument POSITION, where pop_it should
7923 jump to continue iteration.
7924 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7925
fec2107c
EZ
7926 * keyboard.c (adjust_point_for_property): Adjust the call to
7927 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7928
7929 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7930 (bidi_init_it): Update prototypes.
7931 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7932 (compute_display_string_pos, compute_display_string_end):
7933 Declare prototypes.
fec2107c
EZ
7934 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7935 EMACS_INT.
fc6f18ce 7936
40087514 79372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7938
57f53182
PE
7939 Malloc failure behavior now depends on size of allocation.
7940 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7941 * lisp.h: Change signatures accordingly.
7942 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7943 All callers changed. (Bug#8762)
7944
7945 * gnutls.c: Use Emacs's memory allocators.
7946 Without this change, the gnutls library would invoke malloc etc.
7947 directly, which causes problems on non-SYNC_INPUT hosts, and which
7948 runs afoul of improving memory_full behavior. (Bug#8761)
7949 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7950 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7951 xfree instead of the default malloc, realloc, free.
7952 (Fgnutls_boot): No need to check for memory allocation failure,
7953 since xmalloc does that for us.
7954
ac32cd99 7955 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7956 * category.c (hash_get_category_set):
7957 * ccl.c (ccl_driver):
7958 * charset.c (Fdefine_charset_internal):
7959 * charset.h (struct charset.hash_index):
7960 * composite.c (get_composition_id, gstring_lookup_cache)
7961 (composition_gstring_put_cache):
7962 * composite.h (struct composition.hash_index):
7963 * dispextern.h (struct image.hash):
7964 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7965 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7966 (hashfn_equal, hashfn_user_defined, make_hash_table)
7967 (maybe_resize_hash_table, hash_lookup, hash_put)
7968 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7969 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7970 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7971 * image.c (make_image, search_image_cache, lookup_image)
7972 (xpm_put_color_table_h):
7973 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7974 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7975 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7976 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7977 * alloc.c (allocate_vectorlike):
7978 Check for overflow in vector size calculations.
7979 * ccl.c (ccl_driver):
7980 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7981 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7982 need to be updated by these changes.
40087514
PE
7983 * fns.c (make_hash_table, maybe_resize_hash_table):
7984 Check for integer overflow with large hash tables.
0de4bb68
PE
7985 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7986 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7987 (SXHASH_REDUCE): New macro.
7988 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7989 Use it instead of discarding useful hash info with large hash values.
7990 (sxhash_float): New function.
7991 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7992 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7993 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7994 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7995 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7996 Adjust signatures to match updated version of code.
7997 (consing_since_gc): Now EMACS_INT, since a single hash table can
7998 use more than INT_MAX bytes.
7999
698d32e2
DN
80002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8001
8002 Make it possible to build with GCC-4.6+ -O2 -flto.
8003
8004 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8005
fd6fa53f
SM
80062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8007
8008 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8009 Call minibuffer-inactive-mode.
8010
864db017
JB
80112011-05-31 Juanma Barranquero <lekktu@gmail.com>
8012
8013 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8014 Update dependencies.
8015
2ad0baf4
DN
80162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8017
8018 * data.c (init_data): Remove code for UTS, this system is not
8019 supported anymore.
8020
4fcc2638
DN
80212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8022
8023 Don't force ./temacs to start in terminal mode.
8024
8025 * frame.c (make_initial_frame): Initialize faces in all cases, not
8026 only when CANNOT_DUMP is defined.
8027 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8028
c56e0fd5
DN
80292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8030
8031 * dispnew.c (add_window_display_history): Use const for the string
8032 pointer. Remove declaration, not needed.
8033
333d54da 80342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8035
55d4c1b2 8036 Use 'inline', not 'INLINE'.
333d54da 8037 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8038 * alloc.c, fontset.c (INLINE): Remove.
8039 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8040 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8041 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8042 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8043 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8044
738db178
DN
80452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8046
8047 Make it possible to run ./temacs.
8048
8049 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8050 syms_of_callproc does the same thing. Remove test for
8051 "initialized", do it in the caller.
8052 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8053
620c53a6
SM
80542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8055
8056 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8057 (read_minibuf): Use get_minibuffer.
8058 (syms_of_minibuf): Use DEFSYM.
8059 (Qmetadata): New var.
8060 * data.c (Qbuffer): Don't make it static.
8061 (syms_of_data): Use DEFSYM.
8062
e003a292
PE
80632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8064
8065 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8066 (CCL_CODE_MIN): New macro.
8067
ed008a6d
PE
80682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8069
3687c2ef
PE
8070 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8071
ed008a6d
PE
8072 * eval.c (Qdebug): Now static.
8073 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8074 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8075 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8076
d66c4c7c
CY
80772011-05-29 Chong Yidong <cyd@stupidchicken.com>
8078
8079 * image.c: Various fixes to ImageMagick code comments.
8080 (Fimagemagick_types): Doc fix.
8081
5fbc2025
PE
80822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8083
0196f88a
PE
8084 Minor fixes prompted by GCC 4.6.0 warnings.
8085
8086 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8087
5fbc2025
PE
8088 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8089 (x_clipboard_manager_save_all): Move extern decl to ...
8090 * xterm.h: ... here, so that it can be checked for consistency.
8091
1dd3c2d9
CY
80922011-05-29 Chong Yidong <cyd@stupidchicken.com>
8093
8094 * xselect.c (x_clipboard_manager_save_frame)
8095 (x_clipboard_manager_save_all): New functions.
8096 (Fx_clipboard_manager_save): Lisp function deleted.
8097
8098 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8099 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8100
8101 * xterm.h: Update prototype.
8102
5ba6571d
WX
81032011-05-28 William Xu <william.xwl@gmail.com>
8104
8105 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8106 exiting (Bug#8239).
8107
3eaff834
JM
81082011-05-28 Jim Meyering <meyering@redhat.com>
8109
e1900994 8110 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8111 * fns.c (to_uchar): Define.
8112 (crypto_hash_function): Use it to convert some newly-signed
8113 variables to unsigned, to avoid sign-extension bugs. For example,
8114 without this change, (md5 "truc") would evaluate to
8115 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8116 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8117 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8118
0f6990a7
PE
81192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8120
8121 Integer overflow fixes.
c8a9ca5a 8122
08686060
PE
8123 * dbusbind.c: Serial number integer overflow fixes.
8124 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8125 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8126 to hold a serial number that is too large for a fixnum.
8127 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8128 Check for serial numbers out of range. Decode any serial number
59568bf0 8129 that was so large that it became a float. (Bug#8722)
08686060 8130
2d1fc3c7
PE
8131 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8132 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8133 Use XFASTINT rather than XUINT when numbers are nonnegative.
8134 (xd_append_arg, Fdbus_method_return_internal):
8135 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8136 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8137 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8138 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8139 (Bug#8722)
2d1fc3c7 8140
c8a9ca5a
PE
8141 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8142
519e1d69
PE
8143 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8144
6df6ae42 8145 ccl: Add integer overflow checks.
30569699
PE
8146 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8147 (IN_INT_RANGE): New macros.
8148 (ccl_driver): Use them to check for integer overflow when
8149 decoding a CCL program. Many of the new checks are whether XINT (x)
8150 fits in int; it doesn't always, on 64-bit hosts. The new version
8151 doesn't catch all possible integer overflows, but it's an
847044ea 8152 improvement. (Bug#8719)
30569699 8153
c11285dc
PE
8154 * alloc.c (make_event_array): Use XINT, not XUINT.
8155 There's no need for unsigned here.
8156
fdccd48e
PE
8157 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8158 This follows up to the 2011-05-06 change that substituted uintptr_t
8159 for EMACS_INT. This case wasn't caught back then.
8160
37910ab2
PE
8161 Rework Fformat to avoid integer overflow issues.
8162 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8163 now (part of C89). Include <verify.h>.
8164 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8165 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8166 (Fformat): Avoid the prepass trying to compute sizes; it was only
8167 approximate and thus did not catch overflow reliably. Instead, walk
8168 through the format just once, formatting and computing sizes as we go,
8169 checking for integer overflow at every step, and allocating a larger
8170 buffer as needed. Keep track separately whether the format is
8171 multibyte. Keep only the most-recently calculated precision, rather
8172 than them all. Record whether each argument has been converted to
8173 string. Use EMACS_INT, not int, for byte and char and arg counts.
8174 Support field widths and precisions larger than INT_MAX. Avoid
8175 sprintf's undefined behavior with conversion specifications such as %#d
8176 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8177 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8178 formatting out-of-range floating point numbers with int
9173deec 8179 formats. (Bug#8668)
37910ab2 8180
2e6578fb
PE
8181 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8182
0ae6bdee
PE
8183 * data.c: Avoid integer truncation in expressions involving floats.
8184 * data.c: Include <intprops.h>.
8185 (arith_driver): When there's an integer overflow in an expression
8186 involving floating point, convert the integers to floating point
8187 so that the resulting value does not suffer from catastrophic
8188 integer truncation. For example, on a 64-bit host (* 4
8189 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8190 Do not rely on undefined behavior after integer overflow.
8191
de883a70
PE
8192 merge count_size_as_multibyte, parse_str_to_multibyte
8193 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8194 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8195 Check for integer overflow.
8196 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8197 since it's now a duplicate of the other. This is more of
8198 a character than a buffer op, so better that it's in character.c.
8199 * fns.c, print.c: Adjust to above changes.
8200
2ff916cb
PE
82012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8202
8203 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8204
f1b54466
PE
82052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8206
fb1ac845
PE
8207 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8208 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8209 (x_clipboard_manager_save): Now static.
8210 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8211
f1b54466
PE
8212 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8213 (crypto_hash_function): Now static.
8214 Fix pointer signedness problems. Avoid unnecessary initializations.
8215
a9f737ee
CY
82162011-05-27 Chong Yidong <cyd@stupidchicken.com>
8217
8218 * termhooks.h (Vselection_alist): Make it terminal-local.
8219
8220 * terminal.c (create_terminal): Initialize it.
8221
8222 * xselect.c: Support for clipboard managers.
8223 (Vselection_alist): Move to termhooks.h as terminal-local var.
8224 (LOCAL_SELECTION): New macro.
8225 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8226 (symbol_to_x_atom): Remove gratuitous arg.
8227 (x_handle_selection_request, lisp_data_to_selection_data)
8228 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8229 (x_own_selection, x_get_local_selection, x_convert_selection):
8230 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8231 (some_frame_on_display): Delete unused function.
8232 (Fx_own_selection_internal, Fx_get_selection_internal)
8233 (Fx_disown_selection_internal, Fx_selection_owner_p)
8234 (Fx_selection_exists_p): New optional frame arg.
8235 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8236 (x_handle_selection_clear): Don't treat other terminals with the
8237 same keyboard specially. Use the terminal-local Vselection_alist.
8238 (x_clear_frame_selections): Use Frun_hook_with_args.
8239
8240 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8241
8242 * xterm.h: Add support for those atoms.
8243
e067f0c1
CY
82442011-05-26 Chong Yidong <cyd@stupidchicken.com>
8245
8246 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8247 (converted_selections, conversion_fail_tag): New global variables.
8248 (x_selection_request_lisp_error): Free the above.
8249 (x_get_local_selection): Remove unnecessary code.
8250 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8251 of converted selections stored in converted_selections.
8252 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8253 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8254 (x_convert_selection): New function.
8255 (x_handle_selection_event): Simplify.
8256 (x_get_foreign_selection): Don't ignore incoming requests while
8257 waiting for an answer; this will fail when we implement
8258 SAVE_TARGETS, and seems unnecessary anyway.
8259 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8260 (Vx_sent_selection_functions): Doc fix.
8261
0f4aebc0
LL
82622011-05-26 Leo Liu <sdl.web@gmail.com>
8263
8264 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8265
e61124cd
YM
82662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8267
8268 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8269
8270 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8271 for fringe update if it has periodic bitmap.
ac389d0c 8272 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8273 and fringe_bitmap_periodic_p.
8274
8275 * fringe.c (get_fringe_bitmap_data): New function.
8276 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8277 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8278 row. Mark glyph row for fringe update if periodicity changed.
8279
8280 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8281 for fringe update unless it has periodic bitmap.
8282
f16d9837
KH
82832011-05-25 Kenichi Handa <handa@m17n.org>
8284
8285 * xdisp.c (get_next_display_element): Set correct it->face_id for
8286 a static composition.
8287
e1b90ef6
LL
82882011-05-24 Leo Liu <sdl.web@gmail.com>
8289
8290 * deps.mk (fns.o):
8291 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8292
8293 * fns.c (crypto_hash_function, Fsha1): New function.
8294 (Fmd5): Use crypto_hash_function.
8295 (syms_of_fns): Add Ssha1.
8296
7400048f
PE
82972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8298
8299 * gnutls.c: Remove unused macros.
8300 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8301 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8302 Remove macros that are defined and never used.
8303 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8304
abb71cf4
CY
83052011-05-22 Chong Yidong <cyd@stupidchicken.com>
8306
8307 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8308 (Fx_get_selection_internal): Minor cleanup.
8309 (Fx_own_selection_internal): Rename arguments for consistency with
8310 select.el.
8311
6307db39
PE
83122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8313
8314 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8315
f3d4e0a4
CY
83162011-05-22 Chong Yidong <cyd@stupidchicken.com>
8317
8318 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8319
4d8ade89
YM
83202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8321
8322 * dispnew.c (scrolling_window): Don't exclude the case that the
8323 last enabled row in the desired matrix touches the bottom boundary.
8324
32078c8d
GM
83252011-05-21 Glenn Morris <rgm@gnu.org>
8326
8327 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8328 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8329 and add some more files.
32078c8d 8330
7285dc67
EZ
83312011-05-20 Eli Zaretskii <eliz@gnu.org>
8332
8333 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8334 report_file_error introduced by the change from 2011-05-07.
8335
89d1bd22
PE
83362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8337
8338 * systime.h (Time): Define only if emacs is defined.
8339 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8340 where the include path doesn't have X11/X.h by default. See
8341 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8342
cd394be1 83432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8344
8345 * composite.c (find_automatic_composition): Fix previous change.
8346
b9704ad9
GM
83472011-05-20 Glenn Morris <rgm@gnu.org>
8348
8349 * lisp.mk: New file, split from Makefile.in.
8350 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8351 (shortlisp): Remove.
8352 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8353
4a720484
GM
83542011-05-19 Glenn Morris <rgm@gnu.org>
8355
8356 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8357 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8358 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8359 (lisp): Set the order to that of loadup.el.
8360 (shortlisp): Make it a copy of $lisp.
8361 (SOME_MACHINE_LISP): Remove.
8362 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8363 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8364
a28d4396
KH
83652011-05-18 Kenichi Handa <handa@m17n.org>
8366
8367 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8368 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8369 (find_automatic_composition): Mostly rewrite for efficiency.
8370
a2b1fa8e
JB
83712011-05-18 Juanma Barranquero <lekktu@gmail.com>
8372
8373 * makefile.w32-in: Update dependencies.
8374
8e1f5610
CS
83752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8376
8377 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8378 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8379
7025ee00 83802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8381
cdfa6eab
PE
8382 Fix some integer overflow issues, such as string length overflow.
8383
06d6db33
PE
8384 * insdel.c (count_size_as_multibyte): Check for string overflow.
8385
2b4560a8
PE
8386 * character.c (lisp_string_width): Check for string overflow.
8387 Use EMACS_INT, not int, for string indexes and lengths; in
8388 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8389 the resulting string length overflows an EMACS_INT; instead,
8390 report a string overflow if no precision given. When checking for
8391 precision exhaustion, use a check that cannot possibly have
8392 integer overflow. (Bug#8675)
8393 * character.h (lisp_string_width): Adjust to new signature.
8394
cb93f9be
PE
8395 * alloc.c (string_overflow): New function.
8396 (Fmake_string): Use it. This doesn't change behavior, but saves
8397 a few bytes and will simplify future changes.
8398 * character.c (string_escape_byte8): Likewise.
8399 * lisp.h (string_overflow): New decl.
8400
1a1f3366
PE
8401 Fixups, following up to the user-interface timestamp change.
8402 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8403 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8404 * msdos.c (mouse_get_pos): Likewise.
8405 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8406 * w32gui.h (Time): Define by including "systime.h" rather than by
8407 declaring it ourselves. (Bug#8664)
8408
d4e3e4d3
PE
8409 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8410 * image.c (clear_image_cache): Likewise.
8411
f6a24d19
PE
8412 * term.c (term_mouse_position): Don't assume time_t wraparound.
8413
08dc5ae6
PE
8414 Be more systematic about user-interface timestamps.
8415 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8416 and sometimes 'EMACS_UINT', to represent these timestamps.
8417 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8418 This makes the code easier to follow, and makes it easier to catch
8419 integer overflow bugs such as Bug#8664.
8420 * frame.c (Fmouse_position, Fmouse_pixel_position):
8421 Use Time, not unsigned long, for user-interface timestamps.
8422 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8423 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8424 * keyboard.h (last_event_timestamp): Likewise.
8425 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8426 * menu.h (xmenu_show): Likewise.
8427 * term.c (term_mouse_position): Likewise.
8428 * termhooks.h (struct input_event.timestamp): Likewise.
8429 (struct terminal.mouse_position_hook): Likewise.
8430 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8431 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8432 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8433 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8434 what it was before.
8435 * menu.h, termhooks.h: Include "systime.h", for Time.
8436
8e55734a
PE
8437 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8438 Don't assume that the difference between two unsigned long values
8439 can fit into an integer. At this point, we know button_down_time
8440 <= event->timestamp, so the difference must be nonnegative, so
8441 there's no need to cast the result if double-click-time is
8442 nonnegative, as it should be; check that it's nonnegative, just in
8443 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8444 apart (about 25 days). (Bug#8664)
8e55734a 8445
841f1b75 8446 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8447 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8448
3e26f69c
PE
8449 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8450 that always fit in int. Use a sentinel instead of a counter, to
8451 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8452 * frame.h (struct frame): Use int for menu_bar_items_used
8453 instead of EMACS_INT, since it always fits in int.
3e26f69c 8454
5cc152c0
PE
8455 * menu.c (grow_menu_items): Check for int overflow.
8456
d89eb65e
PE
8457 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8458
5235bd3e
PE
8459 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8460 Before, the code was not consistent. These values cannot exceed
8461 2**31 - 1 so there's no need to make them unsigned.
8462 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8463 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8464 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8465 as modifiers.
8466 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8467
bc827e23
PE
8468 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8469 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8470 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8471 presumably because the widths might not match.
8472
78eb494e
PE
8473 * window.c (size_window): Avoid needless test at loop start.
8474
04f2d78b
CB
84752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8476
8477 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8478
d2fc7e3d 84792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8480
8481 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8482
d2fc7e3d 84832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8484
8485 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8486 `width' to `bar_area_x' and `bar_area_width', respectively.
8487 (x_scroll_run): Take account of fringe background extension.
8488
04f2d78b
CB
8489 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8490 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8491 `bar_area_width', respectively.
8492 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8493 background extension.
8494
79b70037
GM
84952011-05-10 Jim Meyering <meyering@redhat.com>
8496
8497 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8498
2f142cc5
JB
84992011-05-10 Juanma Barranquero <lekktu@gmail.com>
8500
8501 * image.c (Finit_image_library): Return t for built-in image types,
8502 like pbm and xbm. (Bug#8640)
8503
57679c86
AS
85042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8505
8506 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8507
888c9e86
EZ
85082011-05-07 Eli Zaretskii <eliz@gnu.org>
8509
b0512a1d
EZ
8510 * w32console.c (Fset_screen_color): Doc fix.
8511 (Fget_screen_color): New function.
8512 (syms_of_ntterm): Defsubr it.
8513
7285dc67
EZ
8514 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8515 unlink the temporary file if Fcall_process didn't create it in the
8516 first place.
8517 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8518 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8519 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8520 cue to call_process_cleanup not to close that handle.
8521
4d3fcc8e
BK
85222011-05-07 Ben Key <bkey76@gmail.com>
8523
8524 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8525 one of two shell specific rules, either bootstrap-temacs-CMD or
8526 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8527 to the previous implementation of the bootstrap-temacs rule.
8528 The bootstrap-temacs-CMD rule is similar to the previous
8529 implementation of the bootstrap-temacs rule except that it
8530 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8531 variable.
8532
8533 These changes, along with some changes to nt/configure.bat,
8534 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8535 earlier fix to add support for --cflags and --ldflags options
8536 that include quotes so that it works whether make uses cmd or
8537 sh as the shell.
8538
b4289b64
MA
85392011-05-06 Michael Albinus <michael.albinus@gmx.de>
8540
8541 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8542 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8543 is a constant.
8544 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8545 a string. Handle both cases.
8546 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8547 (Fdbus_register_method): Use Qinvalid_function.
8548
af4c0e28
JB
85492011-05-06 Juanma Barranquero <lekktu@gmail.com>
8550
8551 * makefile.w32-in: Update dependencies.
8552 (LISP_H): Add inttypes.h and stdin.h.
8553 (PROCESS_H): Add unistd.h.
8554
c51453d9
EZ
85552011-05-06 Eli Zaretskii <eliz@gnu.org>
8556
8557 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8558 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8559
8ff0ac3c 85602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8561
4c4b566b
PE
8562 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8563
aab2b9b5
PE
8564 * term.c (vfatal): Remove stray call to va_end.
8565 It's not needed and the C Standard doesn't allow it here anyway.
8566
c378da0b
PE
8567 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8568 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8569
288b08c7
PE
8570 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8571 bytes.
8572
e3601888
PE
8573 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8574
db6c0e74
PE
8575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8576
dd5963ea
PE
8577 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8578
88c9450f
PE
8579 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8580
2f9442b8
PE
8581 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8582
c032b5f8
PE
8583 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8584 * charset.c (Fdefine_charset_internal): Don't initialize
8585 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8586 32-bit int (Bug#8600).
a108c10b
PE
8587
8588 * lread.c (read_integer): Be more consistent with string-to-number.
8589 Use string_to_number to do the actual conversion; this avoids
8590 rounding errors and fixes some other screwups. Without this fix,
8591 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8592 (digit_to_number): Move earlier, for benefit of read_integer.
8593 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8594 not a digit in any supported base. (Bug#8602)
a108c10b 8595
ad5f9eea
PE
8596 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8597
aec1708a
PE
8598 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8599 to match comment at start of function. This also removes a
8600 GCC warning about overflow in a 32+64-bit port.
8601
47be4ab5
PE
8602 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8603
371cac43
PE
8604 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8605 Reported by Stefan Monnier in
8606 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8607 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8608 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8609
d01a7826
PE
8610 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8611 (EMACS_UINTPTR): Likewise, with uintptr_t.
8612
7fd47d5c
PE
8613 * lisp.h: Prefer 64-bit EMACS_INT if available.
8614 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8615 on 32-bit hosts that have 64-bit int, so that they can access
8616 large files.
122b0c86
PE
8617 However, temporarily disable this change unless the temporary
8618 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8619
8727937b
PE
8620 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8621
8ac068ac
PE
8622 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8623 This removes an assumption that EMACS_INT and long are the same
8624 width as pointers. The assumption is true for Emacs porting targets
8625 now, but we want to make other targets possible.
8626 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8627 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8628 In the rest of the code, change types of integers that hold casted
8629 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8630 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8631 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8632 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8633 No need to cast type when ORing.
8634 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8635 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8636 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8637 assume EMACS_INT is the same width as char *.
8638 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8639 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8640 Remove no-longer-needed casts.
8641 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8642 (xg_tool_bar_help_callback, xg_make_tool_item):
8643 Use EMACS_INTPTR to hold an integer
8644 that will be cast to void *; this can avoid a GCC warning
8645 if EMACS_INT is not the same width as void *.
8646 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8647 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8648 (current_message_1, set_message_1):
8649 Use a local to convert to proper width without a cast.
8650 * xmenu.c (dialog_selection_callback): Likewise.
8651
ede49d71
PE
8652 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8653 Also, don't assume VALBITS / RAND_BITS is less than 5,
8654 and don't rely on undefined behavior when shifting a 1 left into
8655 the sign bit.
8656 * lisp.h (get_random): Change signature to match.
8657
2f30ecd0
PE
8658 * lread.c (hash_string): Use size_t, not int, for hash computation.
8659 Normally we prefer signed values; but hashing is special, because
8660 it's better to use unsigned division on hash table sizes so that
8661 the remainder is nonnegative. Also, size_t is the natural width
8662 for hashing into memory. The previous code used 'int', which doesn't
8663 retain enough info to hash well into very large tables.
8664 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8665
2a866e7b
PE
8666 * dbusbind.c: Don't possibly lose pointer info when converting.
8667 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8668 Use XPNTR rather than XHASH, so that the high-order bits of
8669 the pointer aren't lost when converting through void *.
8670
51639eac
PE
8671 * eval.c (Fautoload): Don't double-shift a pointer.
8672
92394119
PE
8673 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8674
dbdb9a7c
JB
86752011-05-06 Juanma Barranquero <lekktu@gmail.com>
8676
8677 * gnutls.c (DEF_GNUTLS_FN):
8678 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8679
db7a0b4f
AS
86802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8681
8682 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8683 marker. (Bug#8610)
8684
cd394be1 86852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8686
8687 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8688 New version that can reserve upto 2GB of heap space.
8689
f7ff1b0f 86902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8691
8692 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8693
639c109b
TZ
86942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8695
8696 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8697 `gnutls_certificate_set_x509_key_file'.
8698
d2127135
JB
86992011-05-05 Juanma Barranquero <lekktu@gmail.com>
8700
8701 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8702 Update dependencies.
8703
e968f4f3
JB
87042011-05-04 Juanma Barranquero <lekktu@gmail.com>
8705
8706 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8707 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8708 Remove unused parameter `fildes'.
8709 * process.c (read_process_output, send_process): Don't pass it.
8710
84d358f0
JB
87112011-05-04 Juanma Barranquero <lekktu@gmail.com>
8712
8713 Fix previous change: the library cache is defined in w32.c.
8714 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8715 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8716
0898ca10
JB
87172011-05-04 Juanma Barranquero <lekktu@gmail.com>
8718
8719 Implement dynamic loading of GnuTLS on Windows.
8720
8721 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8722 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8723 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8724 Declare.
8725
8726 * gnutls.c (Qgnutls_dll): Define.
8727 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8728 (gnutls_*): Declare function pointers.
8729 (init_gnutls_functions): New function to initialize function pointers.
8730 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8731 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8732 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8733 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8734 (emacs_gnutls_write, emacs_gnutls_read)
8735 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8736 (Fgnutls_available_p): New function.
8737 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8738 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8739 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8740
8741 * image.c: Include w32.h.
8742 (Vimage_type_cache): Delete.
8743 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8744 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8745 (w32_delayed_load): Move to w32.c.
8746
8747 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8748
8749 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8750 (w32_delayed_load): Move from image.c. When loading a library, record
8751 its filename in the :loaded-from property of the library id.
8752 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8753 Initialize and staticpro them.
8754 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8755
8756 * process.c: Include lisp.h before w32.h, not after.
8757 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8758 instead of gnutls_record_check_pending.
8759
8760 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8761
ff4de4aa
TZ
87622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8763
8764 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8765 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8766 as passed in.
8767
abe95abb
JD
87682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8769
8770 * xterm.c (x_set_frame_alpha): Do not set property on anything
8771 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8772
e16e55d4
JB
87732011-05-02 Juanma Barranquero <lekktu@gmail.com>
8774
8775 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8776
bafcf6a5
JB
87772011-05-02 Juanma Barranquero <lekktu@gmail.com>
8778
8779 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8780 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8781 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8782 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8783 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8784 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8785 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8786 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8787 (Qgnutls_bootprop_callbacks_verify): Make static.
8788
e7a6747f
AS
87892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8790
19ed11ba
AS
8791 * callproc.c: Indentation fixup.
8792
e7a6747f 8793 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8794 (wait_for_termination, interruptible_wait_for_termination):
8795 Move after wait_for_termination_1.
e7a6747f 8796
1ef14cb4
LMI
87972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8798
8799 * sysdep.c (interruptible_wait_for_termination): New function
8800 which is like wait_for_termination, but allows keyboard
8801 interruptions.
8802
8803 * callproc.c (Fcall_process): Add (:file "file") as an option for
8804 the STDOUT buffer.
8805 (Fcall_process_region): Ditto.
8806
330d880c
EZ
88072011-04-30 Eli Zaretskii <eliz@gnu.org>
8808
8db90b73
EZ
8809 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8810 rather than `XVECTOR (FOO)->size'.
8811
330d880c
EZ
8812 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8813 inttypes.h, as a gnulib replacement is used if it not available in
8814 system headers.
8815
15cbd324
EZ
88162011-04-21 Eli Zaretskii <eliz@gnu.org>
8817
8818 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8819 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8820 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8821
8822 * coding.c (coding_alloc_by_realloc): Error out if destination
8823 will grow beyond MOST_POSITIVE_FIXNUM.
8824 (decode_coding_emacs_mule): Abort if there isn't enough place in
8825 charbuf for the composition carryover bytes. Reserve an extra
8826 space for up to 2 characters produced in a loop.
8827 (decode_coding_iso_2022): Abort if there isn't enough place in
8828 charbuf for the composition carryover bytes.
8829
88302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8831
ae940cca
EZ
8832 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8833 aborting when %lld or %lll format is passed.
8834 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8835 %llo or %llx format is passed. (Bug#8545)
8836
03ab8921
EZ
8837 * window.c (window_scroll_line_based): Use a marker instead of
8838 simple variables to record original value of point. (Bug#7952)
8839
afda1437
EZ
8840 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8841 produced by %s or %c overflows available buffer space. (Bug#8545)
8842
f76dee0c
PE
88432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8844
8845 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8846 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8847
fdc5744d
JB
88482011-04-28 Juanma Barranquero <lekktu@gmail.com>
8849
8850 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8851
638f053a
JB
88522011-04-28 Juanma Barranquero <lekktu@gmail.com>
8853
8854 * keyboard.c (Qdelayed_warnings_hook): Define.
8855 (command_loop_1): Run `delayed-warnings-hook'
8856 if Vdelayed_warnings_list is non-nil.
8857 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8858 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8859
d178f871
EZ
88602011-04-28 Eli Zaretskii <eliz@gnu.org>
8861
8862 * doprnt.c (doprnt): Don't return value smaller than the buffer
8863 size if the message was truncated. (Bug#8545).
8864
b124fd93
JB
88652011-04-28 Juanma Barranquero <lekktu@gmail.com>
8866
8867 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8868 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8869
e810457d
PE
88702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8871
8872 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8873
ea51cceb
JB
88742011-04-27 Juanma Barranquero <lekktu@gmail.com>
8875
8876 * makefile.w32-in: Update dependencies.
8877
94dcfacf
EZ
88782011-04-27 Eli Zaretskii <eliz@gnu.org>
8879
8880 Improve `doprnt' and its usage. (Bug#8545)
8881 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8882 `format_end'. Remove support for %l as a conversion specifier.
8883 Don't use xrealloc. Improve diagnostics when the %l size modifier
8884 is used. Update the commentary.
8885
8886 * eval.c (verror): Simplify calculation of size_t.
8887
8888 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8889 messages.
8890
f61f41d7
PE
88912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8892
8893 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8894 change.
8895
96fb4434
PE
88962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8897
8898 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8899 This makes this file independent of the recent pseudovector change.
8900
671875da 89012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8902
69e9b5a3
PE
8903 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8904
b5f869a7 8905 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8906 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8907 Remove unused local.
c8926152 8908 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8909
841a1577 8910 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8911 GCC 4.6.0 optimizes based on type-based alias analysis.
8912 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8913 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8914 != &v->size, and therefore "v->size = 1; b->size = 2; return
8915 v->size;" must therefore return 1. This assumption is incorrect
8916 for Emacs, since it type-puns struct Lisp_Vector * with many other
8917 types. To fix this problem, this patch adds a new type struct
f904488f 8918 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8919 and pseudovectors, and helps optimizing compilers not get fooled
8920 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8921 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8922 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8923 the size member.
eab3844f
PE
8924 (XSETPVECTYPE): Rewrite in terms of new macro.
8925 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8926 This is a bit clearer, and further avoids the possibility of
8927 undesirable aliasing.
8928 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8929 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8930 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8931 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8932 (ASIZE): Now uses header.size rather than size.
8933 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8934 to avoid the hassle of writing XVECTOR (foo)->header.size.
8935 (struct vectorlike_header): New type.
eab3844f
PE
8936 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8937 object, to help avoid aliasing.
8938 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8939 (SUBRP): Likewise, since Lisp_Subr is a special case.
8940 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8941 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8942 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8943 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8944 changed to be "header.size" and "header.next".
8945 * buffer.h (struct buffer): Likewise.
8946 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8947 * frame.h (struct frame): Likewise.
8948 * process.h (struct Lisp_Process): Likewise.
8949 * termhooks.h (struct terminal): Likewise.
8950 * window.c (struct save_window_data, struct saved_window): Likewise.
8951 * window.h (struct window): Likewise.
8952 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8953 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8954 * buffer.c (init_buffer_once): Likewise.
8955 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8956 special case.
8957 * process.c (Fformat_network_address): Use local var for size,
8958 for brevity.
8959
0df1eac5
PE
8960 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8961
847ab9d1 8962 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8963 * data.c (atof): Remove decl; no longer used or needed.
8964 (digit_to_number): Move to lread.c.
8965 (Fstring_to_number): Use new string_to_number function, to be
8966 consistent with how the Lisp reader treats infinities and NaNs.
8967 Do not assume that floating-point numbers represent EMACS_INT
8968 without losing information; this is not true on most 64-bit hosts.
8969 Avoid double-rounding errors, by insisting on integers when
8970 parsing non-base-10 numbers, as the documentation specifies.
8971 * lisp.h (string_to_number): New decl, replacing ...
8972 (isfloat_string): Remove.
bc0a5c13 8973 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8974 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8975 appears to have been a coding error. Similarly, do not accept
8976 strings like +-1e0 as floating point numbers. Do not report
8977 overflow for integer overflows unless the base is not 10 which
8978 means we have no simple and reliable way to continue.
8979 Break out the floating-point parsing into a new
8980 function string_to_number, so that Fstring_to_number parses
8981 floating point numbers consistently with the Lisp reader.
04f2d78b 8982 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8983 (E_CHAR, EXP_INT): Remove, replacing with ...
8984 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8985 (string_to_number): New function, replacing isfloat_string.
8986 This function checks for valid syntax and produces the resulting
8987 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8988 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8989 so that overflow for non-base-10 numbers is reported only when
8990 there's no portable and simple way to convert to floating point.
452f4150 8991
67769ffc
PE
8992 * textprop.c (set_text_properties_1): Rewrite for clarity,
8993 and to avoid GCC warning about integer overflow.
8994
c20db43f
PE
8995 * intervals.h (struct interval): Use EMACS_INT for members
8996 where EMACS_UINT might cause problems. See
8997 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8998 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8999 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9000 All uses changed.
37aa2f85
PE
9001 (offset_intervals): Tell GCC not to worry about length overflow
9002 when negating a negative length.
c20db43f 9003
2538aa2f
PE
9004 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9005 (overrun_check_free): Likewise.
9006
f2d3008d
PE
9007 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9008 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9009 word size.
9010
ec8df744
PE
9011 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9012 (gnutls_make_error): Rename local to avoid shadowing.
9013 (gnutls_emacs_global_deinit): ifdef out; not used.
9014 (Fgnutls_boot): Use const for pointer to readonly storage.
9015 Comment out unused local. Fix pointer signedness problems.
9016
640ee02d
PE
9017 * lread.c (openp): Don't stuff size_t into an 'int'.
9018 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9019 about possible signed overflow.
9020
6048fb2a
PE
9021 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9022 (GDK_KEY_g): Don't define if already defined.
9023 (xg_prepare_tooltip): Avoid pointer signedness problem.
9024 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9025
fa3c87e1
PE
9026 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9027 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9028
2172544b
PE
9029 * xfns.c (Fx_window_property): Simplify a bit,
9030 to make a bit faster and to avoid GCC 4.6.0 warning.
9031 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9032
9b821a21
PE
9033 * fns.c (internal_equal): Don't assume size_t fits in int.
9034
3c616cfa
PE
9035 * alloc.c (compact_small_strings): Tighten assertion a little.
9036
c2982e87
PE
9037 Replace pEd with more-general pI, and fix some printf arg casts.
9038 * lisp.h (pI): New macro, generalizing old pEd macro to other
9039 conversion specifiers. For example, use "...%"pI"d..." rather
9040 than "...%"pEd"...".
9041 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9042 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9043 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9044 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9045 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9046 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9047 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9048 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9049 64-bit hosts.
9050 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9051 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9052 * print.c (safe_debug_print, print_object): Likewise.
9053 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9054 to int.
6f04d126
PE
9055 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9056 avoiding the 0 flag, which is not portable.
c2982e87
PE
9057 * process.c (Fmake_network_process): Use pI to avoid cast.
9058 * region-cache.c (pp_cache): Likewise.
9059 * xdisp.c (decode_mode_spec): Likewise.
9060 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9061 behavior on 64-bit hosts with printf arg.
6f04d126 9062 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9063 (x_stop_queuing_selection_requests): Likewise.
9064 (x_get_window_property): Don't truncate byte count to an 'int'
9065 when tracing.
0b432f21 9066
5e073ec7
PE
9067 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9068 here, since it parses constructs like leading '-' and spaces,
9069 which are not wanted; and it overflows with large numbers.
9070 Instead, simply match F[0-9]+, which is what is wanted anyway.
9071
36372bf9
PE
9072 * alloc.c: Remove unportable assumptions about struct layout.
9073 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9074 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9075 (allocate_vectorlike, make_pure_vector): Use the new macros,
9076 plus offsetof, to remove unportable assumptions about struct layout.
9077 These assumptions hold on all porting targets that I know of, but
9078 they are not guaranteed, they're easy to remove, and removing them
9079 makes further changes easier.
9080
0b432f21
PE
9081 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9082 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9083 (string_overrun_cookie): Now const. Use initializers that
9084 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9085 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9086 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9087 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9088 multiple of sizeof (EMACS_INT); it need not be, if
9089 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9090 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9091
895009e1
JB
90922011-04-26 Juanma Barranquero <lekktu@gmail.com>
9093
9094 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9095
6a7a1b0b
TZ
90962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9097
9098 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9099 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9100 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9101
841a1577 91022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9103
9104 * lisp.h (Qdebug): List symbol.
895009e1 9105 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9106 * keyboard.c (debug-on-event): New variable.
9107 (handle_user_signal): Break into debugger when debug-on-event
9108 matches the current signal symbol.
9109
f2d3ba6f
DN
91102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9111
9112 * alloc.c (check_sblock, check_string_bytes)
9113 (check_string_free_list): Convert to standard C.
9114
42ce4c63
TZ
91152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9116
9117 * w32.c (emacs_gnutls_push): Fix typo.
9118
825cd63c
EZ
91192011-04-25 Eli Zaretskii <eliz@gnu.org>
9120
fb11d64d
EZ
9121 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9122 "cast to pointer from integer of different size".
9123
825cd63c
EZ
9124 Improve doprnt and its use in verror. (Bug#8545)
9125 * doprnt.c (doprnt): Document the set of format control sequences
9126 supported by the function. Use SAFE_ALLOCA instead of always
9127 using `alloca'.
9128
9129 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9130 is one byte too soon. Don't use xrealloc; instead xfree and
9131 xmalloc anew.
9132
e061a11b
TZ
91332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9134
9135 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9136 callbacks stage.
9137
9138 * gnutls.c: Renamed global_initialized to
9139 gnutls_global_initialized. Added internals for the
9140 :verify-hostname-error, :verify-error, and :verify-flags
9141 parameters of `gnutls-boot' and documented those parameters in the
9142 docstring. Start callback support.
9173deec
JB
9143 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9144 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9145 on error. Return error code.
e061a11b
TZ
9146 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9147 (emacs_gnutls_read): Likewise.
9148 (Fgnutls_boot): Return handshake error code.
9149 (emacs_gnutls_handle_error): New function.
9150 (wsaerror_to_errno): Likewise.
9151
9152 * w32.h (emacs_gnutls_pull): Add prototype.
9153 (emacs_gnutls_push): Likewise.
9154
9155 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9156 (emacs_gnutls_push): Likewise.
9157
91582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9159
9160 * process.c (wait_reading_process_output): Check if GnuTLS
9161 buffered some data internally if no FDs are set for TLS
9162 connections.
9163
9164 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9165 (LIBS): Link to USER_LIBS.
9166 ($(BLD)/gnutls.$(0)): New target.
9167
fa6996bc
EZ
91682011-04-24 Eli Zaretskii <eliz@gnu.org>
9169
eb35682e
EZ
9170 * xdisp.c (handle_single_display_spec): Rename the
9171 display_replaced_before_p argument into display_replaced_p, to
9172 make it consistent with the commentary. Fix typos in the
9173 commentary.
9174
e2ad650c
EZ
9175 * textprop.c (syms_of_textprop): Remove dead code.
9176 (copy_text_properties): Delete obsolete commentary about an
9177 interface that was deleted long ago. Fix typos in the description
9178 of arguments.
9179
1b2de274
EZ
9180 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9181 to changes in oldXMenu/XMenu.h from 2011-04-16.
9182 <menu_help_message, prev_menu_help_message>: Constify.
9183 (IT_menu_make_room): menu->help_text is now `const char **';
9184 adjust.
9185
9186 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9187 to changes in oldXMenu/XMenu.h from 2011-04-16.
9188 (struct XMenu): Declare `help_text' `const char **'.
9189
9190 * xfaces.c <Qunspecified>: Make extern again.
9191
9192 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9193 required by POSIX.
1b2de274 9194
762b15be
EZ
9195 * doc.c (get_doc_string): Improve the format passed to `error'.
9196
9197 * doprnt.c (doprnt): Improve commentary.
9198
9199 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9200
9201 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9202 them with etags.
9203
f1052e5d
EZ
9204 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9205 changes in globals.h immediately force recompilation.
762b15be
EZ
9206 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9207 $(CURDIR)/s/ms-w32.h.
9208 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9209
fa6996bc
EZ
9210 * character.c (Fchar_direction): Function deleted.
9211 (syms_of_character): Don't defsubr it.
9212 <char-direction-table>: Deleted.
9213
e6c3da20
EZ
92142011-04-23 Eli Zaretskii <eliz@gnu.org>
9215
9216 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9217 * doprnt.c: Include limits.h.
9218 (SIZE_MAX): New macro.
04f2d78b
CB
9219 (doprnt): Return a size_t value. 2nd arg is now size_t.
9220 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9221 Improve overflow protection. Support `l' modifier for integer
9222 conversions. Support %l conversion. Don't assume an EMACS_INT
9223 argument for integer conversions and for %c.
9224
9225 * lisp.h (doprnt): Restore prototype.
9226
9227 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9228 $(SRC)/character.h.
9229
9230 * Makefile.in (base_obj): Add back doprnt.o.
9231
9232 * deps.mk (doprnt.o): Add back prerequisites.
9233 (callint.o): Depend on character.h.
9234
9235 * eval.c (internal_lisp_condition_case): Include the handler
9236 representation in the error message.
9237 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9238 when breaking from the loop.
9239
9240 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9241
9242 * callint.c (Fcall_interactively): When displaying error message
9243 about invalid control letter, pass the character's codepoint, not
9244 a pointer to its multibyte form. Improve display of the character
9245 in octal and display also its hex code.
9246
9247 * character.c (char_string): Use %x to display the (unsigned)
9248 codepoint of an invalid character, to avoid displaying a bogus
9249 negative value.
9250
9251 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9252 `error', not SYMBOL_NAME itself.
9253
9254 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9255 character arguments to `error'.
9256
9257 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9258 to `error' in error message about FINAL_CHAR argument. Make sure
9259 FINAL_CHAR is a character, and use %c when it is passed as
9260 argument to `error'.
9261
4ffd0d6b 92622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9263
9264 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9265
9266 * w32.c: Include <time.h>.
9267 (sys_localtime): New function.
9268
4ffd0d6b 92692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9270
9271 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9272
4ffd0d6b 9273 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9274
4ffd0d6b 92752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9276
4ffd0d6b
GM
9277 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9278 zombies (Bug#8467).
aac0c6e3 9279
04c56954
EZ
92802011-04-19 Eli Zaretskii <eliz@gnu.org>
9281
9282 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9283 gl_state.e_property when gl_state.object is Qt.
9284
9285 * insdel.c (make_gap_larger): Remove limitation of buffer size
9286 to <= INT_MAX.
9287
16a43933
CY
92882011-04-18 Chong Yidong <cyd@stupidchicken.com>
9289
9290 * xdisp.c (lookup_glyphless_char_display)
9291 (produce_glyphless_glyph): Handle cons cell entry in
9292 glyphless-char-display.
9293 (Vglyphless_char_display): Document it.
9294
9295 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9296 glyphless-char-display.
9297
4581706e
CY
92982011-04-17 Chong Yidong <cyd@stupidchicken.com>
9299
9300 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9301
9302 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9303
9304 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9305 definition for no-X builds.
9306
4887c6e2 93072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9308
fd35b6f9
PE
9309 Static checks with GCC 4.6.0 and non-default toolkits.
9310
5c1ccb01
PE
9311 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9312
006c5daa
PE
9313 * process.c (keyboard_bit_set): Define only if SIGIO.
9314 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9315 (send_process): Repair possible setjmp clobbering.
9316
efc736d3
PE
9317 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9318
4e2fe2e6
PE
9319 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9320
f97334a2
PE
9321 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9322
4e75f29d
PE
9323 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9324 Define only if needed.
9325
90efadd1
PE
9326 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9327 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9328 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9329
3c647824
PE
9330 * dispextern.h (struct redisplay_interface): Rename param
9331 to avoid shadowing.
e264f262 9332 * termhooks.h (struct terminal): Likewise.
761383f4 9333 * xterm.c (xembed_send_message): Likewise.
3c647824 9334
b58c5c4a
PE
9335 * insdel.c (make_gap_smaller): Define only if
9336 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9337
cad59032
PE
9338 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9339 it.
9340
c339dc2e
PE
9341 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9342 so that we aren't warned about unused symbols.
9343
91a3e27b
PE
9344 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9345
399c71d3 9346 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9347
8ffc96f5
PE
9348 * xfns.c (x_real_positions): Mark locals as initialized.
9349
eef9bc79
PE
9350 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9351
098db9dd
PE
9352 * xterm.c: Fix problems found by static analysis with other toolkits.
9353 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9354 (x_dispatch_event): Declare static if USE_GTK, and
9355 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9356 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9357 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9358 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9359 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9360
eb18f6cc
PE
9361 * xmenu.c (menu_help_callback): Pointer type fixes.
9362 Use const pointers when pointing at readonly data. Avoid pointer
9363 signedness clashes.
9364 (FALSE): Remove unused macro.
9365 (update_frame_menubar): Remove unused decl.
9366
1fe72bf8
PE
9367 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9368
60d9e1db
PE
9369 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9370 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9371 (single_menu_item): Rename local to avoid shadowing.
9372
39261c26
PE
9373 * keyboard.c (make_lispy_event): Remove unused local var.
9374
018c5e19
PE
9375 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9376 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9377
63d2b86e
PE
9378 * bitmaps: Change bitmaps from unsigned char back to the X11
9379 compatible char. Avoid the old compiler warnings about
9380 out-of-range initializers by using, for example, '\xab' rather
9381 than 0xab.
9382
aefd87e1
PE
9383 * xgselect.c (xgselect_initialize): Check vs interface
9384 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9385
bf501fb9
PE
9386 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9387
e9829fdf
PE
9388 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9389 to read-only memory.
9390
1086c095
PE
9391 * fns.c (vector): Remove; this old hack is no longer needed.
9392
2baccd04 9393 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9394 Remove unused var.
dde42981 9395 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9396
72391843 9397 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9398
436c16df 9399 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9400 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9401 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9402
92bb796d 9403 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9404 (x_term_init): Remove local to avoid shadowing.
92bb796d 9405
764430a3 9406 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9407
9408 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9409 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9410
d1dfb56c
EZ
94112011-04-16 Eli Zaretskii <eliz@gnu.org>
9412
c4354cb4
EZ
9413 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9414
d1dfb56c
EZ
9415 Fix regex.c, syntax.c and friends for buffers > 2GB.
9416 * syntax.h (struct gl_state_s): Declare character position members
9417 EMACS_INT.
9418
9419 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9420
04f2d78b
CB
9421 * textprop.c (verify_interval_modification, interval_of):
9422 Declare arguments EMACS_INT.
d1dfb56c
EZ
9423
9424 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9425 EMACS_INT.
9426
9427 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9428
9429 * indent.c (Fvertical_motion): Local variable it_start is now
9430 EMACS_INT.
9431
9432 * regex.c (re_match, re_match_2, re_match_2_internal)
9433 (bcmp_translate, regcomp, regexec, print_double_string)
9434 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9435 (re_compile_pattern, re_exec): Declare arguments and local
9436 variables `size_t' and `ssize_t' and return values `regoff_t', as
9437 appropriate.
9438 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9439 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9440 <compile_stack_type>: `size' and `avail' are now `size_t'.
9441
9442 * regex.h <regoff_t>: Use ssize_t, not int.
9443 (re_search, re_search_2, re_match, re_match_2): Arguments that
9444 specify buffer/string position and length are now ssize_t and
9445 size_t. Return type is regoff_t.
9446
613052cd
BK
94472011-04-16 Ben Key <bkey76@gmail.com>
9448
9449 * nsfont.m: Fixed bugs in ns_get_family and
9450 ns_descriptor_to_entity that were caused by using free to
9451 deallocate memory blocks that were allocated by xmalloc (via
9452 xstrdup). This caused Emacs to crash when compiled with
9453 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9454 --enable-checking=xmallocoverrun). xfree is now used to
9455 deallocate these memory blocks.
9456
4170f62f 94572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9458
71b41406
PE
9459 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9460
9587a89d
PE
9461 emacs_write: Accept and return EMACS_INT for sizes.
9462 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9463 et seq.
9464 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9465 Accept and return EMACS_INT.
9466 (emacs_gnutls_write): Return the number of bytes written on
9467 partial writes.
9468 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9469 (emacs_read, emacs_write): Remove check for negative size, as the
9470 Emacs source code has been audited now.
9587a89d
PE
9471 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9472 (emacs_read, emacs_write): Use it.
273a5f82
PE
9473 * process.c (send_process): Adjust to the new signatures of
9474 emacs_write and emacs_gnutls_write. Do not attempt to store
9475 a byte offset into an 'int'; it might overflow.
9587a89d 9476 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9477
3e047f51
PE
9478 * sound.c: Don't assume sizes fit in 'int'.
9479 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9480 Return EMACS_INT, not int.
3e047f51 9481 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9482 Accept EMACS_INT, not int.
9483 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9484 record read return values.
9485
cc39a9db
BK
94862011-04-15 Ben Key <bkey76@gmail.com>
9487
c9d0ec6d
JB
9488 * keyboard.c (Qundefined): Don't declare static since it is used
9489 in nsfns.m.
9490 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9491 static since they are used in nsfont.m.
cc39a9db 9492
6c60eb9f
SM
94932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9494
9495 * process.c (Qprocessp): Don't declare static.
9496 * lisp.h (Qprocessp): Declare again.
9497
7990b61a
JB
94982011-04-15 Juanma Barranquero <lekktu@gmail.com>
9499
9500 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9501
5d4cb038
PE
95022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9503
8bd7b830 9504 Improve C-level modularity by making more things 'static'.
cd64ea1d 9505
e3b27b31
PE
9506 Don't publish debugger-only interfaces to other modules.
9507 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9508 (verify_bytepos, count_markers): Move decls to the only modules
9509 that need them.
9510 * region-cache.h (pp_cache): Likewise.
9511 * window.h (check_all_windows): Likewise.
9512 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9513
5d4cb038
PE
9514 * sysdep.c (croak): Now static, if
9515 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9516 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9517
9518 * alloc.c (refill_memory_reserve): Now static if
9519 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9520 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9521
e87b6180
PE
9522 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9523 Define only if USE_LUCID.
9524
ac64929e
PE
9525 * xrdb.c (x_customization_string, x_rm_string): Now static.
9526
6f37259d
PE
9527 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9528 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9529
1683e3ab
PE
9530 * xdisp.c (draw_row_with_mouse_face): Now static.
9531 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9532
de9c2632
PE
9533 * window.h (check_all_windows): Mark externally visible.
9534
2b96acb7
PE
9535 * window.c (window_deletion_count): Now static.
9536
9537 * undo.c: Make symbols static if they're not exported.
9538 (last_undo_buffer, last_boundary_position, pending_boundary):
9539 Now static.
9540
50436f33
PE
9541 * textprop.c (interval_insert_behind_hooks): Now static.
9542 (interval_insert_in_front_hooks): Likewise.
9543
64520e5c
PE
9544 * term.c: Make symbols static if they're not exported.
9545 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9546 (max_frame_lines, tty_set_terminal_modes):
9547 (tty_reset_terminal_modes, tty_turn_off_highlight):
9548 (get_tty_terminal): Now static.
9549 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9550 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9551 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9552 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9553 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9554
1fa53021
PE
9555 * sysdep.c: Make symbols static if they're not exported.
9556 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9557 Now static.
9558 (sigprocmask_set, full_mask): Remove; unused.
9559 (wait_debugging): Mark as visible.
9560 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9561 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9562
d4b43b22
PE
9563 * syntax.c (syntax_temp): Define only if !__GNUC__.
9564
b7c513d0
PE
9565 * sound.c (current_sound_device, current_sound): Now static.
9566
989b29ad
PE
9567 * search.c (searchbufs, searchbuf_head): Now static.
9568
13a55a78
PE
9569 * scroll.c (scroll_cost): Remove; unused.
9570 * dispextern.h (scroll_cost): Remove decl.
9571
de68a1fc
PE
9572 * region-cache.h (pp_cache): Mark as externally visible.
9573
40ccffa6
PE
9574 * process.c: Make symbols static if they're not exported.
9575 (process_tick, update_tick, create_process, chan_process):
9576 (Vprocess_alist, proc_buffered_char, datagram_access):
9577 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9578 (deactivate_process): Mark defn as static, as well as decl.
9579 * lisp.h (create_process): Remove decl.
9580 * process.h (chan_process, Vprocess_alist): Remove decls.
9581
ad64fc97
PE
9582 * print.c: Make symbols static if they're not exported.
9583 (print_depth, new_backquote_output, being_printed, print_buffer):
9584 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9585 (print_interval, print_number_index, initial_stderr_stream):
9586 Now static.
9587 * lisp.h (Fprinc): Remove decl.
9588 (debug_output_compilation_hack): Mark as externally visible.
9589
adddb265
PE
9590 * sysdep.c (croak): Move decl from here to syssignal.h.
9591 * syssignal.h (croak): Put it here, so the API can be checked when
9592 'croak' is called from dissociate_if_controlling_tty.
9593
1717ede2
PE
9594 * minibuf.c: Make symbols static if they're not exported.
9595 (minibuf_save_list, choose_minibuf_frame): Now static.
9596 * lisp.h (choose_minibuf_frame): Remove decl.
9597
fa5fb2bc
PE
9598 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9599
1e3890d1
PE
9600 * lread.c: Make symbols static if they're not exported.
9601 (read_objects, initial_obarray, oblookup_last_bucket_number):
9602 Now static.
9603 (make_symbol): Remove; unused.
9604 * lisp.h (initial_obarray, make_symbol): Remove decls.
9605
8a1414fa
PE
9606 * keyboard.c: Make symbols static if they're not exported.
9607 (single_kboard, recent_keys_index, total_keys, recent_keys):
9608 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9609 (this_single_command_key_start, echoing, last_auto_save):
9610 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9611 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9612 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9613 (Vlispy_mouse_stem, double_click_count):
9614 Now static.
9615 (force_auto_save_soon): Define only if SIGDANGER.
9616 (ignore_mouse_drag_p): Now static if
9617 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9618 (print_help): Remove; unused.
9619 (stop_character, last_timer_event): Mark as externally visible.
9620 * keyboard.h (ignore_mouse_drag_p): Declare only if
9621 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9622 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9623 * lisp.h (echoing): Remove decl.
9624 (force_auto_save_soon): Declare only if SIGDANGER.
9625 * xdisp.c (redisplay_window): Simplify code, to make it more
9626 obvious that ignore_mouse_drag_p is not accessed if !defined
9627 USE_GTK && !defined HAVE_NS.
9628
93ea6e8f
PE
9629 * intervals.c: Make symbols static if they're not exported.
9630 (merge_properties_sticky, merge_interval_right, delete_interval):
9631 Now static.
9632 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9633
77382fcc
PE
9634 * insdel.c: Make symbols static if they're not exported.
9635 However, leave prepare_to_modify_buffer alone. It's never
9636 called from outside this function, but that appears to be a bug.
9637 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9638 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9639 (adjust_after_replace_noundo): Remove; unused.
9640 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9641 (signal_before_change): Remove decls.
77382fcc 9642
9306c32e
PE
9643 * indent.c (val_compute_motion, val_vmotion): Now static.
9644
cd44d2eb
PE
9645 * image.c: Make symbols static if they're not exported.
9646 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9647 if USE_GTK.
9648 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9649 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9650
ad9a7a06
PE
9651 * fringe.c (standard_bitmaps): Now static.
9652 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9653
81626931
PE
9654 * frame.c: Make symbols static if they're not exported.
9655 (x_report_frame_params, make_terminal_frame): Now static.
9656 (get_frame_param): Now static, unless HAVE_NS.
9657 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9658 (x_get_resource_string): Remove; not used.
9659 * frame.h (make_terminal_frame, x_report_frame_params):
9660 (x_get_resource_string); Remove decls.
9661 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9662 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9663
239f9db9
PE
9664 * font.c, fontset.c: Make symbols static if they're not exported.
9665 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9666 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9667 * font.c (font_close_object): Now static.
9668 * font.h (font_close_object): Remove.
9669 * fontset.c (FONTSET_OBJLIST): Remove.
9670 (free_realized_fontset) #if-0 the body, which does nothing.
9671 (face_suitable_for_char_p): #if-0, as it's never called.
9672 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9673 * xfaces.c (face_at_string_position):
9674 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9675 since 0 is always ASCII.
9676
dfcf3579
PE
9677 * fns.c (weak_hash_tables): Now static.
9678
5045092b
PE
9679 * fileio.c: Make symbols static if they're not exported.
9680 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9681 (Vwrite_region_annotation_buffers): Now static.
9682
57a96f5c
PE
9683 * eval.c: Make symbols static if they're not exported.
9684 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9685 * lisp.h (backtrace_list): Remove decl.
9686
35f08c38
PE
9687 * emacs.c: Make symbols static if they're not exported.
9688 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9689 (fatal_error_code, fatal_error_signal_hook, standard_args):
9690 Now static.
9691 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9692 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9693 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9694 * lisp.h (fatal_error_signal_hook): Remove decl.
9695 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9696
f44bd759
PE
9697 * editfns.c: Move a (normally-unused) function to its only use.
9698 * editfns.c, lisp.h (get_operating_system_release): Remove.
9699 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9700 worth the hassle of breaking this out.
9701
b532497d
PE
9702 * xterm.c: Make symbols static if they're not exported.
9703 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9704 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9705 (x_destroy_window, x_delete_display):
9706 Now static.
9707 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9708 (x_mouse_leave): Remove; unused.
9709 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9710 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9711 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9712 Remove decls.
9713 (x_mouse_leave): Declare only if WINDOWSNT.
9714 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9715 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9716 USE_X_TOOLKIT.
9717
1675728f
PE
9718 * ftxfont.c: Make symbols static if they're not exported.
9719 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9720 HAVE_FREETYPE.
9721 * font.h (ftxfont_driver): Likewise.
9722
e4cebfca
PE
9723 * xfns.c: Make symbols static if they're not exported.
9724 (x_last_font_name, x_display_info_for_name):
9725 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9726 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9727 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9728 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9729 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9730 (last_show_tip_args): Now static.
9731 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9732 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9733 (x_screen_planes): Remove; unused.
9734 * dispextern.h (x_screen_planes): Remove decl.
9735
5bf46f05
PE
9736 * dispnew.c: Make symbols static if they're not exported.
9737 * dispextern.h (redraw_garbaged_frames, scrolling):
9738 (increment_row_positions): Remove.
9739 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9740 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9741 Now static.
9742 (redraw_garbaged_frames): Remove; unused.
9743
435f4c28
PE
9744 * xfaces.c: Make symbols static if they're not exported.
9745 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9746 Remove decls.
9747 * xterm.h (defined_color): Remove decls.
9748 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9749 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9750 (menu_face_changed_default, defined_color, free_realized_face):
9751 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9752 (ascii_face_of_lisp_face): Remove; unused.
9753
8524aef3
PE
9754 * xdisp.c: Make symbols static if they're not exported.
9755 * dispextern.h (scratch_glyph_row, window_box_edges):
9756 (glyph_to_pixel_coords, set_cursor_from_row):
9757 (get_next_display_element, set_iterator_to_next):
9758 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9759 (show_mouse_face): Remove decls
9760 * frame.h (message_buf_print): Likewise.
9761 * lisp.h (pop_message, set_message, check_point_in_composition):
9762 Likewise.
9763 * xterm.h (set_vertical_scroll_bar): Likewise.
9764 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9765 (message_buf_print, scratch_glyph_row, displayed_buffer):
9766 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9767 (get_next_display_element, show_mouse_face, window_box_edges):
9768 (frame_to_window_pixel_xy, check_point_in_composition):
9769 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9770 (glyph_to_pixel_coords): Remove; unused.
9771
16390cd2
PE
9772 * dired.c (file_name_completion): Now static.
9773
9774 * dbusbind.c (xd_in_read_queued_messages): Now static.
9775
a25f4dfa
PE
9776 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9777 * data.c (circular_list_error): Remove.
9778
14a9c8df
PE
9779 * commands.h (last_point_position, last_point_position_buffer):
9780 (last_point_position_window): Remove decls.
9781 * keyboard.c: Make these variables static.
9782
04f2d78b
CB
9783 * coding.h (coding, code_convert_region, encode_coding_gap):
9784 Remove decls.
74ab6df5
PE
9785 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9786 (iso_code_class, detect_coding, code_convert_region): Now static.
9787 (encode_coding_gap): Remove; unused.
9788
38dfbee1
PE
9789 * chartab.c (chartab_chars, chartab_bits): Now static.
9790
a2cb4e63
PE
9791 * charset.h (charset_iso_8859_1): Remove decl.
9792 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9793 Now static.
9794
127198fd
PE
9795 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9796 * ccl.c (Vccl_program_table): Now static.
9797 (check_ccl_update): Remove; unused.
9798
d85b608f
PE
9799 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9800 * category.h: ... from here.
9801 * category.c (check_category_table, set_category_set): Now static.
9802
31cd66f3
PE
9803 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9804 * lisp.h: Remove these decls.
9805
c358e587
PE
9806 * buffer.c (buffer_count): Remove unused var.
9807
e78aecca
PE
9808 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9809 so that it's not optimized away.
9810 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9811 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9812 exported only to the debugger.
9813
e192d7d3 9814 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9815 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9816
92470028
PE
9817 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9818 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9819 was inaccessible from Lisp.
9820 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9821 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9822
244ed907
PE
9823 alloc.c: Import and export fewer symbols, and remove unused items.
9824 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9825 is defined.
9826 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9827 it's not optimized away by whole-program optimization.
9828 (message_enable_multibyte, free_misc): Remove.
9829 (catchlist, handlerlist, mark_backtrace):
9830 Declare only if BYTE_MARK_STACK.
9831 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9832 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9833 (message_enable_multibyte): Remove decl.
9834 (free_misc, interval_free_list, float_block, float_block_index):
9835 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9836 (cons_free_list, last_marked_index):
9837 Now static.
9838 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9839 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9840 (mark_backtrace): Define only if BYTE_MARK_STACK.
9841 * xdisp.c (message_enable_multibyte): Now static.
9842
61c2b50e 9843 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9844 This makes it easier for human readers (and static analyzers)
9845 to see whether these variables are used from other modules.
9846 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9847 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9848 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9849 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9850 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9851 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9852 * xmenu.c, xselect.c:
9853 Declare Q* vars static if they are not used in other modules.
9854 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9855 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9856 Remove decls of unexported vars.
9857 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9858
95c82688
PE
9859 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9860
16a97296
PE
9861 Make Emacs functions such as Fatom 'static' by default.
9862 This makes it easier for human readers (and static analyzers)
9863 to see whether these functions can be called from other modules.
9864 DEFUN now defines a static function. To make the function external
9865 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9866 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9867 (Finit_image_library):
16a97296
PE
9868 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9869 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9870 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9871 Remove decls, since these functions are now static.
9872 (Funintern, Fget_internal_run_time): New decls, since these functions
9873 were already external.
95c82688 9874
16a97296
PE
9875 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9876 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9877 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9878 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9879 * keyboard.c, keymap.c, lread.c:
9880 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9881 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9882 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9883 Mark functions with DEFUE instead of DEFUN,
9884 if they are used in other modules.
9885 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9886 decls for now-static functions.
9887 * buffer.h (Fdelete_overlay): Remove decl.
9888 * callproc.c (Fgetenv_internal): Mark as internal.
9889 * composite.c (Fremove_list_of_text_properties): Remove decl.
9890 (Fcomposition_get_gstring): New forward static decl.
9891 * composite.h (Fcomposite_get_gstring): Remove decl.
9892 * dired.c (Ffile_attributes): New forward static decl.
9893 * doc.c (Fdocumntation_property): New forward static decl.
9894 * eval.c (Ffetch_bytecode): New forward static decl.
9895 (Funintern): Remove extern decl; now in .h file where it belongs.
9896 * fileio.c (Fmake_symbolic_link): New forward static decl.
9897 * image.c (Finit_image_library): New forward static decl.
9898 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9899 * intervals.h (Fprevious_property_change):
9900 (Fremove_list_of_text_properties): Remove decls.
9901 * keyboard.c (Fthis_command_keys): Remove decl.
9902 (Fcommand_execute): New forward static decl.
9903 * keymap.c (Flookup_key): New forward static decl.
9904 (Fcopy_keymap): Now static.
9905 * keymap.h (Flookup_key): Remove decl.
9906 * process.c (Fget_process): New forward static decl.
9907 (Fprocess_datagram_address): Mark as internal.
9908 * syntax.c (Fsyntax_table_p): New forward static decl.
9909 (skip_chars): Remove duplicate decl.
9910 * textprop.c (Fprevious_property_change): New forward static decl.
9911 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9912 Now internal.
9913 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9914 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9915
785bbd42
PE
9916 * editfns.c (Fformat): Remove unreachable code.
9917
8b913b57
AS
99182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9919
9920 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9921 change. (Bug#8496)
9922
a6744a35
EZ
99232011-04-13 Eli Zaretskii <eliz@gnu.org>
9924
9925 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9926 when at ZV. (Bug#8487)
9927
e7974947
AS
99282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9929
baad03f0
AS
9930 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9931 (Bug#8437)
9932 * keyboard.c (parse_tool_bar_item): Likewise.
9933 * sound.c (sound_cleanup, alsa_close): Likewise.
9934 * termcap.c (tgetent): Likewise.
9935 * xfns.c (x_default_font_parameter): Likewise.
9936 * xsettings.c (read_and_apply_settings): Likewise.
9937
e7974947
AS
9938 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9939 (overrun_check_free): Protoize.
9940
28272684
PE
99412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9942
9943 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9944 since callers should never pass a negative size.
9945 Change the signature to match that of plain 'read' and 'write'; see
9946 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9947 * lisp.h: Update prototypes of emacs_write and emacs_read.
9948
11997c76
EZ
99492011-04-11 Eli Zaretskii <eliz@gnu.org>
9950
9951 * xdisp.c (redisplay_window): Don't try to determine the character
9952 position of the scroll margin if the window start point w->startp
e896f03c 9953 is outside the buffer's accessible region. (Bug#8468)
11997c76 9954
8a2cbd72
EZ
99552011-04-10 Eli Zaretskii <eliz@gnu.org>
9956
9957 Fix write-region and its subroutines for buffers > 2GB.
9958 * fileio.c (a_write, e_write): Modify declaration of arguments and
9959 local variables to support buffers larger than 2GB.
9960 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9961
9962 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9963 argument, local variables, and return value.
9964
9965 * lisp.h: Update prototypes of emacs_write and emacs_read.
9966
9967 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9968
4073e537 99692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9970
1ebfdcb6
PE
9971 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9972
b2ded58d
PE
9973 Fix more problems found by GCC 4.6.0's static checks.
9974
7d66342c
PE
9975 * xdisp.c (vmessage): Use a better test for character truncation.
9976
bbf47d44
PE
9977 * charset.c (load_charset_map): <, not <=, for optimization,
9978 and to avoid potential problems with integer overflow.
9248994d 9979 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9980 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9981 * editfns.c (Fformat): Likewise.
1e69125e 9982 * syntax.c (skip_chars): Likewise.
3befa583 9983
e3019616
PE
9984 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9985 This also lets GCC 4.6.0 generate slightly better loop code.
9986
becfa255
PE
9987 * callint.c (Fcall_interactively): <, not <=, for optimization.
9988 (Fcall_interactively): Count the number of arguments produced,
9989 not the number of arguments given. This is simpler and lets GCC
9990 4.6.0 generate slightly better code.
9991
dae0cd48
PE
9992 * ftfont.c: Distingish more carefully between FcChar8 and char.
9993 The previous code passed unsigned char * to a functions like
9994 strlen and xstrcasecmp that expect char *, which does not
9995 conform to the C standard.
9996 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9997 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9998 char * when the C standard requires it.
9999
76032d70
PE
10000 * keyboard.c (read_char): Remove unused var.
10001
eb3f1cc8
PE
10002 * eval.c: Port to Windows vsnprintf (Bug#8435).
10003 Include <limits.h>.
10004 (SIZE_MAX): Define if the headers do not.
10005 (verror): Do not give up if vsnprintf returns a negative count.
10006 Instead, grow the buffer. This ports to Windows vsnprintf, which
10007 does not conform to C99. Problem reported by Eli Zaretskii.
10008 Also, simplify the allocation scheme, by avoiding the need for
10009 calling realloc, and removing the ALLOCATED variable.
10010
70476b54
PE
10011 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10012
12020a9e
PE
10013 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10014 But keep the doprint source code for now, as we might revamp it
10015 and use it again (Bug#8435).
ea6c7ae6
PE
10016 * lisp.h (doprnt): Remove.
10017 * Makefile.in (base_obj): Remove doprnt.o.
10018 * deps.mk (doprnt.o): Remove.
10019
5fdb398c
PE
10020 error: Print 32- and 64-bit integers portably (Bug#8435).
10021 Without this change, on typical 64-bit hosts error ("...%d...", N)
10022 was used to print both 32- and 64-bit integers N, which relied on
10023 undefined behavior.
61bdb816 10024 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10025 * lisp.h (error, verror): Mark as printf-like functions.
10026 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10027 Report overflow in size calculations when allocating printf buffer.
10028 Do not truncate output string at its first null byte.
10029 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10030 Truncate the output at a character boundary, since vsnprintf does not
10031 do that.
10032 * charset.c (check_iso_charset_parameter): Convert internal
10033 character to string before calling 'error', since %c now has the
10034 printf meaning.
10035 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10036 overflow when computing char to be passed to 'error'. Do not
10037 pass Lisp_Object to 'error'; pass the integer instead.
10038 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10039 formatted with plain %d.
10040
b189fa66
PE
10041 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10042
bff87ef0
PE
10043 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10044
7e2cac20
PE
10045 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10046
ce4d90b5
PE
10047 * xterm.c (x_catch_errors): Remove duplicate declaration.
10048
266c9547
PE
10049 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10050
79c49ad2
PE
10051 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10052
368f4090
JM
100532011-04-10 Jim Meyering <meyering@redhat.com>
10054
10055 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10056 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10057 return ssize_t not "int", and use size_t as the buffer length.
10058 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10059 * gnutls.h: Update declarations.
10060 * process.c (read_process_output): Use ssize_t, to match.
10061 (send_process): Likewise.
10062
a32d4040
CY
100632011-04-09 Chong Yidong <cyd@stupidchicken.com>
10064
10065 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10066
8546720e 100672011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10068
04f2d78b
CB
10069 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10070 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10071
8546720e
GM
10072 * xterm.c (handle_one_xevent):
10073 * xmenu.c (create_and_show_popup_menu):
10074 * xselect.c (x_decline_selection_request)
10075 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10076
0a2f5c1a 100772011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10078
10079 Fix some uses of `int' instead of EMACS_INT.
10080 * search.c (string_match_1, fast_string_match)
10081 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10082 (scan_buffer, find_next_newline_no_quit)
10083 (find_before_next_newline, search_command, Freplace_match)
10084 (Fmatch_data): Make some `int' variables be EMACS_INT.
10085
10086 * xdisp.c (display_count_lines): 3rd argument and return value now
10087 EMACS_INT. All callers changed.
10088 (pint2hrstr): Last argument is now EMACS_INT.
10089
10090 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10091 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10092 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10093 (decode_coding_utf_16, decode_coding_emacs_mule)
10094 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10095 (decode_coding_ccl, decode_coding_charset)
10096 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10097 (decode_coding_iso_2022, decode_coding_emacs_mule)
10098 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10099 <char_offset, last_offset>: Declare EMACS_INT.
10100 (encode_coding_utf_8, encode_coding_utf_16)
10101 (encode_coding_emacs_mule, encode_invocation_designation)
10102 (encode_designation_at_bol, encode_coding_iso_2022)
10103 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10104 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10105 Declare EMACS_INT.
10106 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10107 (encode_invocation_designation): Last argument P_NCHARS is now
10108 EMACS_INT.
10109 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10110 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10111
10112 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10113 All users changed.
10114
10115 * ccl.c (Fccl_execute_on_string): Declare some variables
10116 EMACS_INT.
10117
8546720e 101182011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10119
10120 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10121
4e19a977
CS
101222011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10123
10124 * process.c (Fformat_network_address): Doc fix.
10125
87302331
R
101262011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10127
ee7683eb 10128 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10129
cbb59342
CY
101302011-04-08 Chong Yidong <cyd@stupidchicken.com>
10131
10132 * keyboard.c (read_char): Call Lisp function help-form-show,
10133 instead of using internal_with_output_to_temp_buffer.
10134 (Qhelp_form_show): New var.
e0d38eeb 10135 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10136
10137 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10138
10139 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10140
e67a13ab
CY
101412011-04-06 Chong Yidong <cyd@stupidchicken.com>
10142
04f2d78b
CB
10143 * process.c (Flist_processes): Remove to Lisp.
10144 (list_processes_1): Delete.
e67a13ab 10145
973f782d
EZ
101462011-04-06 Eli Zaretskii <eliz@gnu.org>
10147
7c106b1e
EZ
10148 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10149
973f782d
EZ
10150 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10151
41cf7d1a 101522011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10153
ca23cc88
PE
10154 Fix more problems found by GCC 4.6.0's static checks.
10155
f390e2d5
PE
10156 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10157
42eea0d0
PE
10158 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10159
b69769da 10160 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10161
f9541e84
PE
10162 * xdisp.c (vmessage): Mark as a printf-like function.
10163
13841b55
PE
10164 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10165
c136c10f
PE
10166 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10167
5e2d4a30
PE
10168 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10169 printf-like functions.
10170 (tiff_load): Add casts to remove these marks before passing them
10171 to system-supplied API.
10172
583f48b9
PE
10173 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10174
b25d760e
PE
10175 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10176 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10177 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10178 directly, rather than having caller test rule sign. This avoids
10179 some unnecessary tests.
10180 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10181 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10182 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10183
bc7b6697 10184 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10185 (xfont_open): Avoid unnecessary tests.
bc7b6697 10186
27ccc379
PE
10187 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10188
dcd5c89a
PE
10189 * composite.h, composite.c (composition_gstring_put_cache):
10190 Use EMACS_INT, not int, for length.
10191
b13a45c6
PE
10192 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10193 breaking out part of COMPOSITION_DECODE_RULE.
10194 (COMPOSITION_DECODE_RULE): Use it.
10195 * composite.c (get_composition_id): Remove unused local vars,
10196 by using the new macro.
10197
1e792e4d
PE
10198 * textprop.c (set_text_properties_1): Change while to do-while,
10199 since the condition is always true at first.
10200
dc6c6455 10201 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10202 (interval_deletion_adjustment): Return unsigned value.
10203 All uses changed.
dc6c6455 10204
aba7731a
PE
10205 * process.c (list_processes_1, create_pty, read_process_output):
10206 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10207 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10208 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10209 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10210 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10211
fdfc4bf3
PE
10212 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10213
fca8fe46 10214 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10215 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10216
06a0259a 10217 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10218 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10219 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10220
e7b9e80f
PE
10221 * print.c (print_error_message): Avoid int overflow.
10222
56201685
PE
10223 * font.c (font_list_entities): Redo for clarity,
10224 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10225
78834453 10226 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10227 (font_score): Avoid potential overflow in diff calculation.
78834453 10228
0bc0b309 10229 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10230 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10231
e610eaca
PE
10232 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10233
b895abce
PE
10234 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10235 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10236 can always succeed if overflow has undefined behavior.
10237
1f1d9321 10238 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10239 (wordify): Omit three unnecessary tests.
1f1d9321 10240
c59478bc
PE
10241 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10242 All callers changed. This avoids the need for an unused var.
10243
79b73827
PE
10244 * casefiddle.c (casify_region): Remove var that is set but not used.
10245
a4db5dfe
PE
10246 * dired.c (file_name_completion): Remove var that is set but not used.
10247
43aae36e
PE
10248 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10249
2a47c44d 10250 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10251 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10252
a37c69bf
PE
10253 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10254 Check for integer overflow on size calculations.
10255
328ab8e7
PE
10256 * buffer.c (Fprevious_overlay_change): Remove var that is set
10257 but not used.
10258
e5a2a5cb
PE
10259 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10260 Remove vars that are set but not used.
8d84a6eb 10261 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10262 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10263
a60e5f68
PE
10264 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10265
f661cb61 10266 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10267 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10268
f0397f5a
PE
10269 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10270 that are set but not used.
10271
8664db06 10272 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10273 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10274
6abdaa4a
PE
10275 * xselect.c (x_get_local_selection, x_handle_property_notify):
10276 Remove vars that are set but not used.
10277
0ce7538d 10278 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10279 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10280
9ae848fc
PE
10281 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10282 Remove var that is set but not used.
0b918413
PE
10283 (scroll_bar_windows_size): Now size_t, not int.
10284 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10285 Check for overflow.
9ae848fc 10286
a5a62657
PE
10287 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10288 (map_tty_color) [!defined MSDOS]: Likewise.
10289
5c5cdd39
PE
10290 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10291
66ebf983
PE
10292 * coding.c: Remove vars that are set but not used.
10293 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10294 All callers changed.
10295 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10296 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10297 (decode_coding_charset): Remove vars that are set but not used.
10298
1be4d761
PE
10299 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10300 that is set but not used.
10301
47553fa8
PE
10302 * print.c (print_object): Remove var that is set but not used.
10303
1f7196bf 10304 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10305 The gnulib version avoids calling malloc in the usual case,
10306 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10307 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10308 * filelock.c (current_lock_owner): Likewise.
10309 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10310 * sysdep.c: Include allocator.h, careadlinkat.h.
10311 (emacs_no_realloc_allocator): New static constant.
10312 (emacs_readlink): New function.
fdb61804
PE
10313 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10314 ../lib/careadlinkat.h.
d1fdcab7 10315
f84c17c7
SM
103162011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10317
10318 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10319 first non-nil return value).
10320
ef3862ad
JD
103212011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10322
10323 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10324 if not defined (Bug#8403).
10325
376a7006
JB
103262011-04-02 Juanma Barranquero <lekktu@gmail.com>
10327
10328 * xdisp.c (display_count_lines): Remove parameter `start',
10329 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10330 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10331 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10332 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10333 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10334 and thereabouts. All callers changed.
10335 (get_per_char_metric): Remove parameter `f', unused since
10336 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10337
6ca3801d
JM
103382011-04-02 Jim Meyering <meyering@redhat.com>
10339
10340 do not dereference NULL upon failed strdup
10341 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10342 (ns_get_family): Likewise.
10343
d8e2b5ba
JB
103442011-04-02 Juanma Barranquero <lekktu@gmail.com>
10345
10346 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10347
8c74fcbd
JD
103482011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10349
10350 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10351 later (Bug#8403).
10352
7200d79c
SM
103532011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10354
03408648 10355 Add lexical binding.
7200d79c 10356
03408648
SM
10357 * window.c (Ftemp_output_buffer_show): New fun.
10358 (Fsave_window_excursion):
10359 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10360
10361 * lread.c (lisp_file_lexically_bound_p): New function.
10362 (Fload): Bind Qlexical_binding.
10363 (readevalloop): Remove `evalfun' arg.
10364 Bind Qinternal_interpreter_environment.
10365 (Feval_buffer): Bind Qlexical_binding.
10366 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10367 Mark as dynamic.
10368 (syms_of_lread): Declare `lexical-binding'.
10369
10370 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10371
10372 * keyboard.c (eval_dyn): New fun.
10373 (menu_item_eval_property): Use it.
ca105506
SM
10374
10375 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10376
03408648
SM
10377 * fns.c (concat, mapcar1): Accept byte-code-functions.
10378
10379 * eval.c (Fsetq): Handle lexical vars.
10380 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10381 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10382 (FletX, Flet): Obey lexical binding.
10383 (Fcommandp): Handle closures.
10384 (Feval): New `lexical' arg.
10385 (eval_sub): New function extracted from Feval. Use it almost
10386 everywhere where Feval was used. Look up vars in lexical env.
10387 Handle closures.
10388 (Ffunctionp): Move from subr.el.
10389 (Ffuncall): Handle closures.
10390 (apply_lambda): Remove `eval_flags'.
10391 (funcall_lambda): Handle closures and new byte-code-functions.
10392 (Fspecial_variable_p): New function.
10393 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10394 but without exporting it to Lisp.
23aba0ea 10395
23aba0ea 10396 * doc.c (Fdocumentation, store_function_docstring):
03408648 10397 * data.c (Finteractive_form): Handle closures.
23aba0ea 10398
03408648
SM
10399 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10400 interactive spec.
ba83908c 10401
04f2d78b
CB
10402 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10403 New byte-codes.
03408648
SM
10404 (exec_byte_code): New function extracted from Fbyte_code to handle new
10405 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10406
03408648 10407 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10408
03408648 10409 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10410
e2abce01
JB
104112011-03-31 Juanma Barranquero <lekktu@gmail.com>
10412
10413 * xdisp.c (redisplay_internal): Fix prototype.
10414
63696a73 104152011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10416
63696a73 10417 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10418 (try_scrolling): Use it when setting scroll_limit.
10419 Limit scrolling to 100 screen lines.
63696a73
EZ
10420 (redisplay_window): Even when falling back on "recentering",
10421 position point in the window according to scroll-conservatively,
10422 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10423
10424 (try_scrolling): When point is above the window, allow searching
10425 as far as scroll_max, or one screenful, to compute vertical
10426 distance from PT to the scroll margin position. This prevents
10427 try_scrolling from unnecessarily failing when
10428 scroll-conservatively is set to a value slightly larger than the
10429 window height. Clean up the case of PT below the margin at bottom
10430 of window: scroll_max can no longer be INT_MAX. When aggressive
10431 scrolling is in use, don't let point enter the opposite scroll
10432 margin as result of the scroll.
10433 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10434 threshold of 100 lines for never-recentering scrolling.
10435
e4cc2dfc
JB
104362011-03-31 Juanma Barranquero <lekktu@gmail.com>
10437
10438 * dispextern.h (move_it_by_lines):
10439 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10440 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10441 (message_log_check_duplicate): Remove parameters `prev_bol' and
10442 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10443 (redisplay_internal): Remove parameter `preserve_echo_area',
10444 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10445
10446 * indent.c (Fvertical_motion):
10447 * window.c (window_scroll_pixel_based, Frecenter):
10448 Don't pass `need_y_p' to `move_it_by_lines'.
10449
1c470562
SM
104502011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10451
44f230aa
SM
10452 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10453 steal a few bits to be more compact.
10454 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10455 Remove unneeded casts.
10456
1c470562
SM
10457 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10458
888adce9
ZK
104592011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10460
10461 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10462 binding" message (bug#7967).
10463
f838ed7b
PE
104642011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10465
77861b95
PE
10466 Fix more problems found by GCC 4.6.0's static checks.
10467
de6dbc14
PE
10468 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10469 Remove unused local var.
10470
f838ed7b
PE
10471 * editfns.c (Fmessage_box): Remove unused local var.
10472
792c7b2b
PE
10473 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10474 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10475 Omit unused local vars.
c499e557 10476 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10477 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10478 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10479 Omit unused local var.
10480
ba0165e1
PE
10481 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10482 Don't assume string length fits in int.
32ad8845 10483 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10484 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10485
3c59b4c9
PE
10486 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10487 instead of alloca (Bug#8344).
10488
a3eed478 10489 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10490 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10491
eb4d412d
PE
10492 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10493
1658b401
PE
10494 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10495 concerns.
10496
10497 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10498
10499 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10500
9a2c6e05
PE
10501 * keyboard.c (syms_of_keyboard): Use the same style as later
10502 in this function when indexing through an array. This also
10503 works around GCC bug 48267.
10504
03d0a109
PE
10505 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10506
44f730c8
PE
10507 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10508
fe75f926
PE
10509 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10510 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10511
ffa8c828
PE
10512 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10513 This avoids undefined behavior on integer overflow, and is a bit
10514 more convenient anyway since it is compared to a size_t variable.
10515
c5101a77
PE
10516 Variadic C functions now count arguments with size_t, not int.
10517 This avoids an unnecessary limitation on 64-bit machines, which
10518 caused (substring ...) to crash on large vectors (Bug#8344).
10519 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10520 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10521 All variadic functions and their callers changed accordingly.
c5101a77
PE
10522 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10523 * data.c (arith_driver, float_arith_driver): Likewise.
10524 * editfns.c (general_insert_function): Likewise.
10525 * eval.c (struct backtrace.nargs, interactive_p)
10526 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10527 (funcall_lambda, mark_backtrace): Likewise.
10528 * fns.c (concat): Likewise.
10529 * frame.c (x_set_frame_parameters): Likewise.
10530 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10531 0 if not found, not -1. All callers changed.
10532
dd3f25f7
PE
10533 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10534 (stack_copy_size): Now size_t, not int.
10535 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10536
461c2ab9
JB
105372011-03-28 Juanma Barranquero <lekktu@gmail.com>
10538
10539 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10540 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10541 All callers changed.
10542
10543 * lisp.h (multibyte_char_to_unibyte):
10544 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10545 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10546 * character.h (CHAR_TO_BYTE8):
10547 * cmds.c (internal_self_insert):
10548 * editfns.c (general_insert_function):
10549 * keymap.c (push_key_description):
10550 * search.c (Freplace_match):
10551 * xdisp.c (message_dolog, set_message_1): All callers changed.
10552
f6d62986
SM
105532011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10554
10555 * keyboard.c (safe_run_hook_funcall): New function.
10556 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10557 don't set the hook to nil, but remove the offending function instead.
10558 (Qcommand_hook_internal): Remove, unused.
10559 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10560 Vcommand_hook_internal.
10561
10562 * eval.c (enum run_hooks_condition): Remove.
10563 (funcall_nil, funcall_not): New functions.
10564 (run_hook_with_args): Call each function through a `funcall' argument.
10565 Remove `cond' argument, now redundant.
10566 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10567 (Frun_hook_with_args_until_failure): Adjust accordingly.
10568 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10569
1db5b1ad
JB
105702011-03-28 Juanma Barranquero <lekktu@gmail.com>
10571
10572 * dispextern.h (string_buffer_position): Remove declaration.
10573
10574 * print.c (strout): Remove parameter `multibyte', unused since
10575 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10576
10577 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10578 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10579 All callers changed.
10580
10581 * w32.c (_wsa_errlist): Use braces for struct initializers.
10582
10583 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10584 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10585 All callers changed.
10586 (string_buffer_position): Likewise. Also, make static (it's never
10587 used outside xdisp.c).
10588 (cursor_row_p): Remove parameter `w', unused since
10589 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10590 (decode_mode_spec): Remove parameter `precision', introduced during
10591 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10592 All callers changed.
10593
5ffb62aa
JD
105942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10595
10596 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10597
461c2ab9 105982011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10599
10600 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10601 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10602 (ns_update_auto_hide_menu_bar): New functions.
10603 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10604 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10605 ns_constrain_all_frames.
10606 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10607 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10608
5c380ffb
JD
106092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10610
10611 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10612
9af30bdf
GM
106132011-03-27 Glenn Morris <rgm@gnu.org>
10614
10615 * syssignal.h: Replace RETSIGTYPE with void.
10616 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10617 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10618 Replace SIGTYPE with void everywhere.
10619 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10620 * s/template.h (SIGTYPE): Remove commented out definition.
10621
e2abce01
JB
106222011-03-26 Eli Zaretskii <eliz@gnu.org>
10623
10624 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10625 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10626
f868cd8a
JB
106272011-03-26 Juanma Barranquero <lekktu@gmail.com>
10628
59eb0929
JB
10629 * w32.c (read_unc_volume): Use parameter `henum', instead of
10630 global variable `wget_enum_handle'.
10631
10632 * keymap.c (describe_vector): Remove parameters `indices' and
10633 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10634 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10635
f868cd8a
JB
10636 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10637
10638 * keyboard.c (timer_check): Remove parameter `do_it_now',
10639 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10640 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10641 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10642
10643 * keyboard.c (read_char):
10644 * w32menu.c (w32_menu_display_help):
10645 * xmenu.c (show_help_event, menu_help_callback):
10646 Adjust calls to `show_help_echo'.
10647
10648 * gtkutil.c (xg_maybe_add_timer):
10649 * keyboard.c (readable_events):
10650 * process.c (wait_reading_process_output):
10651 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10652
10653 * insdel.c (adjust_markers_gap_motion):
10654 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10655 (gap_left, gap_right): Don't call it.
10656
2ecf6fdb
CY
106572011-03-25 Chong Yidong <cyd@stupidchicken.com>
10658
10659 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10660 incurred during fontification.
10661
6b1f9ba4
JB
106622011-03-25 Juanma Barranquero <lekktu@gmail.com>
10663
10664 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10665 (DEFVAR_PER_BUFFER): Don't pass it.
10666
10667 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10668 (scrolling_window): Don't pass it.
10669
0f4a96b5
JB
106702011-03-25 Juanma Barranquero <lekktu@gmail.com>
10671
10672 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10673
10674 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10675 and `suffix'.
10676 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10677 of variables specific to SELinux and computation of `encoded_absname'.
10678
10679 * image.c (XPutPixel): Remove unused variable `height'.
10680
10681 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10682
10683 * unexw32.c (get_section_info): Remove unused variable `section'.
10684
10685 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10686 (system_process_attributes): Remove unused variable `sess'.
10687 (sys_read): Remove unused variable `err'.
10688
10689 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10690 (w32_wnd_proc): Remove unused variable `isdead'.
10691 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10692 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10693 (x_create_tip_frame): Remove unused variable `tem'.
10694
10695 * w32inevt.c (w32_console_read_socket):
10696 Remove unused variable `no_events'.
10697
10698 * w32term.c (x_draw_composite_glyph_string_foreground):
10699 Remove unused variable `width'.
10700
1149507c
JB
107012011-03-24 Juanma Barranquero <lekktu@gmail.com>
10702
10703 * w32term.c (x_set_glyph_string_clipping):
10704 Don't pass uninitialized region to CombineRgn.
10705
9c88f339
JB
107062011-03-23 Juanma Barranquero <lekktu@gmail.com>
10707
10708 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10709 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10710 (Fx_close_connection): Remove unused variable `i'.
10711
10712 * w32font.c (w32font_draw): Return number of glyphs.
10713 (w32font_open_internal): Remove unused variable `i'.
10714 (w32font_driver): Add missing initializer.
10715
10716 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10717 (fill_in_menu): Remove unused variable `items_added'.
10718
10719 * w32term.c (last_mouse_press_frame): Remove static global variable.
10720 (w32_clip_to_row): Remove unused variable `f'.
10721 (x_delete_terminal): Remove unused variable `i'.
10722
10723 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10724 (NOTHING): Remove unused static global variable.
10725 (uniscribe_check_otf): Remove unused variable `table'.
10726 (uniscribe_font_driver): Add missing initializers.
10727
dee091a3
JD
107282011-03-23 Julien Danjou <julien@danjou.info>
10729
10730 * term.c (Fsuspend_tty, Fresume_tty):
10731 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10732 * window.c (temp_output_buffer_show):
10733 * insdel.c (signal_before_change):
10734 * frame.c (Fhandle_switch_frame):
10735 * fileio.c (Fdo_auto_save):
10736 * emacs.c (Fkill_emacs):
10737 * editfns.c (save_excursion_restore):
10738 * cmds.c (internal_self_insert):
10739 * callint.c (Fcall_interactively):
10740 * buffer.c (Fkill_all_local_variables):
10741 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10742 Use Frun_hooks.
0f4a96b5 10743 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10744 unconditionally since it does the check itself.
dee091a3 10745
2c520ab5 107462011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10747
c9c49752
PE
10748 Fix more problems found by GCC 4.5.2's static checks.
10749
8abc3f12
PE
10750 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10751 the first time through the loop, since we know p0 < p1 then.
10752 This also avoids a gcc -Wstrict-overflow warning.
10753
a2d26660
PE
10754 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10755 leading to a memory leak, possible in functions like
10756 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10757 of objects (Bug#8318).
a2d26660 10758
916c72e9
PE
10759 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10760 that could (at least in theory) be that large.
10761
19ab8a18
PE
10762 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10763 This is less likely to overflow, and avoids undefined behavior if
10764 overflow does occur. All callers changed. Use strtoul to scan
10765 for the unsigned long integer.
b7cbbd6f
PE
10766 (pint2hrstr): Simplify and tune code slightly.
10767 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10768
f0641eff
PE
10769 * scroll.c (do_scrolling): Work around GCC bug 48228.
10770 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10771
7f650bb9
PE
10772 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10773 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10774 (validate_x_resource_name): Simplify count usage.
10775 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10776
37dd57d1
PE
10777 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10778 fail (Bug#8306).
81e56e61 10779
699979fc 10780 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10781
401bf9b4
PE
10782 * process.c (Fmake_network_process): Use socklen_t, not int,
10783 where POSIX says socklen_t is required in portable programs.
10784 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10785 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10786 (Fmake_network_process, server_accept_connection):
10787 (wait_reading_process_output, read_process_output):
10788 Likewise.
10789
b93aacde
PE
10790 * process.c: Rename or move locals to avoid shadowing.
10791 (list_processes_1, Fmake_network_process):
10792 (read_process_output_error_handler, exec_sentinel_error_handler):
10793 Rename or move locals.
4dc343ee 10794 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10795 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10796 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10797 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10798 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10799
af8a867c 10800 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10801 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10802 Include tparam.h instead, since it declares them.
af8a867c
PE
10803 * cm.h (PC): Remove extern decl; tparam.h now does this.
10804 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10805 * terminfo.c: Include tparam.h, to check interfaces.
10806 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10807 (tparam): Adjust signature to match interface in tparam.h;
10808 this removes some undefined behavior. Check that outstring and len
10809 are zero, which they always are with Emacs.
10810 * tparam.h (PC, BC, UP): New extern decls.
10811
0248044d 10812 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10813 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10814
8ff096c1 10815 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10816 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10817 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10818 (ftfont_list): Remove unused local.
49eaafba
PE
10819 (get_adstyle_property, ftfont_pattern_entity):
10820 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10821 Rename locals to avoid shadowing.
8ff096c1 10822
e2be39f6
PE
10823 * xfont.c (xfont_list_family): Mark var as initialized.
10824
c9735e30
PE
10825 * xml.c (make_dom): Now static.
10826
8f5201ae
PE
10827 * composite.c (composition_compute_stop_pos): Rename local to
10828 avoid shadowing.
b246f932
PE
10829 (composition_reseat_it): Remove unused locals.
10830 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10831 (composition_update_it): Mark var as initialized.
11b61122
PE
10832 (find_automatic_composition): Mark vars as initialized,
10833 with a FIXME (Bug#8290).
8f5201ae 10834
760fbc2c
PE
10835 character.h: Rename locals to avoid shadowing.
10836 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10837 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10838 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10839 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10840 to avoid shadowing.
10841
ff08eb85
PE
10842 * textprop.c (property_change_between_p): Remove; unused.
10843
fc7bf025
PE
10844 * intervals.c (interval_start_pos): Now static.
10845
235d7abc
PE
10846 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10847
44f230aa
SM
10848 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10849 Rename locals to avoid shadowing.
3e7d6594 10850
50060332
PE
10851 * sound.c (wav_play, au_play, Fplay_sound_internal):
10852 Fix pointer signedness.
d01f234b 10853 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10854 (wav_play): Initialize a variable to 0, to prevent undefined
10855 behavior (Bug#8278).
50060332 10856
c4fc4e30
PE
10857 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10858
918436ed
PE
10859 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10860
c939f91b
PE
10861 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10862 clobbering (Bug#8298).
b9c7f648
PE
10863 * sysdep.c (sys_subshell): Likewise.
10864 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10865
6bd8c144
PE
10866 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10867 This should get cleaned up, so that child_setup has the
10868 same signature on all platforms.
10869
7710357c 10870 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10871 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10872
c59da222
CY
108732011-03-22 Chong Yidong <cyd@stupidchicken.com>
10874
10875 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10876 not to be necessary, and produces flickering.
10877
66b87493
GM
108782011-03-20 Glenn Morris <rgm@gnu.org>
10879
10880 * config.in: Remove file.
10881
45b6f6d5
JB
108822011-03-20 Juanma Barranquero <lekktu@gmail.com>
10883
10884 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10885 are now in src/globals.h.
10886 (syms_of_minibuf): Remove spurious & from previous change.
10887
cd394be1 108882011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10889
10890 * minibuf.c (completing-read-function): New variable.
10891 (completing-read-default): Rename from completing-read.
10892 (completing-read): Call completing-read-function.
10893
b14e3e21
CY
108942011-03-19 Juanma Barranquero <lekktu@gmail.com>
10895
10896 * xfaces.c (Fx_load_color_file):
10897 Read color file from absolute filename (bug#8250).
10898
f2b726e6
JB
108992011-03-19 Juanma Barranquero <lekktu@gmail.com>
10900
10901 * makefile.w32-in: Update dependencies.
10902
09f6ff02
EZ
109032011-03-17 Eli Zaretskii <eliz@gnu.org>
10904
10905 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10906
29a6015a
PE
109072011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10908
a3a6c54e
PE
10909 Fix more problems found by GCC 4.5.2's static checks.
10910
b766f867
PE
10911 * process.c (make_serial_process_unwind, send_process_trap):
10912 (sigchld_handler): Now static.
10913
be02381c
PE
10914 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10915 That way, the code declares only the vars that it needs.
10916 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10917 * s/cygwin.h (PTY_ITERATION): Likewise.
10918 * s/darwin.h (PTY_ITERATION): Likewise.
10919 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10920
57048744
PE
10921 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10922 * process.c (allocate_pty): Don't declare stb unless it's needed.
10923
7914961c 10924 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10925 (CONSTANTLIM): Remove; unused.
10926 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10927 Define only if needed.
7914961c 10928
b3967b18
PE
10929 * unexelf.c (unexec): Name an expression,
10930 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10931 Use a different way to cause a compilation error if anyone uses
10932 n rather than nn, a way that does not involve shadowing.
73366a00 10933 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10934
29a6015a
PE
10935 * deps.mk (unexalpha.o): Remove; unused.
10936
43cfc33e 10937 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10938 * unexec.h: New file.
ce701a33
PE
10939 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10940 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10941 Depend on unexec.h.
10942 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10943 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10944 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10945 Change as necessary to match prototype in unexec.h.
ce701a33 10946
01f44d5a
PE
10947 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10948 shadowing.
4f63c6bb 10949 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10950
a6670b0b
PE
10951 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10952 Rename locals to avoid shadowing.
10953
cef2010d 10954 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10955 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10956
d4d7173a
PE
10957 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10958
f08b802a
PE
10959 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10960 warning when compiling print.c.
10961
3ddb0639
PE
10962 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10963 instead of using an uninitialized var.
5ad03b97 10964 (font_sort_entities): Mark var as initialized.
3ddb0639 10965
170a2692
PE
10966 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10967
e663c700
PE
10968 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10969 pointers to constants.
89bc529a 10970 (font_parse_fcname): Remove unused vars.
7b81e2d0 10971 (font_delete_unmatched): Now static.
ea838e10 10972 (font_get_spec): Remove; unused.
13a547c6
PE
10973 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10974 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10975 Rename or move locals to avoid shadowing.
e663c700 10976
2a80c887 10977 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10978 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10979
1384fa33 10980 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10981 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10982
8b2c52e9
PE
10983 * alloc.c (mark_backtrace): Move decl from here ...
10984 * lisp.h: ... to here, so that it can be checked.
10985
475545b5 10986 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10987 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10988 (lisp_indirect_variable): Name an expression,
10989 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10990 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10991
b1349114 10992 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10993 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10994 Use const pointer when appropriate.
b1349114 10995
a2928364
PE
10996 * lisp.h (get_system_name, get_operating_system_release):
10997 Move decls here, to check interfaces.
10998 * process.c (get_operating_system_release): Move decl to lisp.h.
10999 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11000 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11001 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11002 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11003 (Fformat_time_string, Fencode_time, Finsert_char):
11004 (Ftranslate_region_internal, Fformat):
11005 Rename or remove local vars to avoid shadowing.
9710023e 11006 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11007
a415e694
PE
11008 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11009 avoid shadowing.
11010
8ef4622d
PE
11011 * lisp.h (eassert): Check that the argument compiles, even if
11012 ENABLE_CHECKING is not defined.
11013
946f9a5b
PE
11014 * data.c (Findirect_variable): Name an expression, to avoid
11015 gcc -Wbad-function-cast warning.
112396d6 11016 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11017 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11018 (Fmake_variable_buffer_local, Fmake_local_variable):
11019 Mark variables as initialized.
52746918 11020 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11021
e5aab7e7 11022 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11023 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11024 Rename locals to avoid shadowing.
dff45157
PE
11025 (mark_stack): Move local variables into the #ifdef region where
11026 they're used.
7bc26fdb
PE
11027 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11028 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11029 needed otherwise.
11030 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11031 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11032 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11033
e5aab7e7
PE
11034 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11035 avoids undefined behavior in theory.
11036
4da60324
PE
11037 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11038
88043301
PE
11039 Use functions, not macros, for up- and down-casing (Bug#8254).
11040 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11041 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11042 to use the following functions instead of these macros.
11043 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11044 EMACS_INT, since callers assume the returned value fits in int.
11045 (upcase1): Likewise, for UPCASE_TABLE.
11046 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11047 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11048 the race-condition problem in the old DOWNCASE.
88043301 11049
19ed5445
PE
11050 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11051 Rename locals to avoid shadowing.
11052 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11053 (regex_compile, re_search_2, re_match_2_internal):
11054 Remove unused local vars.
952db0d7
PE
11055 (FREE_VAR): Rewrite so as not to use empty "else",
11056 which gcc can warn about.
da053e48 11057 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11058 (RETALLOC_IF): Define only if needed.
11059 (WORDCHAR_P): Likewise. This one is never needed, but is used
11060 only in a comment talking about a compiler bug, so put inside
11061 the #if 0 of that comment.
11062 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11063 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11064 Remove; unused.
19ed5445 11065
1f3561e4 11066 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11067 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11068 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11069
ded6f8f7
PE
11070 * search.c (simple_search): Remove unused var.
11071
dbd37a95
PE
11072 * dired.c (compile_pattern): Move decl from here ...
11073 * lisp.h: ... to here, so that it can be checked.
11074 (struct re_registers): New forward decl.
11075
7e47afad
PE
11076 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11077
85f24f61
PE
11078 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11079 All uses changed.
11080 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11081 Rename locals to avoid shadowing.
5671df8f 11082 (Fvertical_motion): Mark locals as initialized.
85f24f61 11083
181aa2be 11084 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11085 (casify_region): Mark local as initialized.
181aa2be 11086
930d429c
PE
11087 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11088
7082eac6
PE
11089 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11090 New macros, so that the caller can use some names other than
11091 gcpro1, gcpro2, etc.
11092 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11093 of the new macros.
11094 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11095 argument, for consistency with GCPRO2_VAR, etc: it is now the
11096 prefix of the variable, not the variable itself. All uses
11097 changed.
38b2c076
PE
11098 * dired.c (directory_files_internal, file_name_completion):
11099 Rename locals to avoid shadowing.
11100
15206ed9
PE
11101 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11102 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11103 dired.c's scmp function, had undefined behavior.
11104 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11105 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11106 * buffer.h: ... to here, because these macros use current_buffer,
11107 and the new implementation with inline functions needs to have
11108 current_buffer in scope now, rather than later when the macros
11109 are used.
11110 (downcase, upcase1): New static inline functions.
11111 (DOWNCASE, UPCASE1): Reimplement using these functions.
11112 This avoids undefined behavior in expressions like
11113 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11114 from race conditions in accessing the global variables
11115 case_temp1 and case_temp2.
11116 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11117 * lisp.h (case_temp1, case_temp2): Remove their decls.
11118 * character.h (ASCII_CHAR_P): Move from here ...
11119 * lisp.h: ... to here, so that the inline functions mentioned
11120 above can use them.
11121
4a6bea26
PE
11122 * dired.c (directory_files_internal_unwind): Now static.
11123
f14b7e14
PE
11124 * fileio.c (file_name_as_directory, directory_file_name):
11125 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11126 Now static.
2893f146
PE
11127 (file_name_as_directory): Use const pointers when appropriate.
11128 (Fexpand_file_name): Likewise. In particular, newdir might
11129 point at constant storage, so make it a const pointer.
fd4ead52 11130 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11131 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11132 signedness issues.
f839df0c
PE
11133 (Fset_file_times, Finsert_file_contents, auto_save_error):
11134 Rename locals to avoid shadowing.
f14b7e14 11135
5716756e 11136 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11137 (Ftry_completion, Fall_completions): Rename or remove locals
11138 to avoid shadowing.
5716756e 11139
b4c3046a
PE
11140 * marker.c (bytepos_to_charpos): Remove; unused.
11141
b45db522
PE
11142 * lisp.h (verify_bytepos, count_markers): New decls,
11143 so that gcc does not warn that these functions aren't declared.
11144
85876d07
PE
11145 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11146 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11147 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11148 (copy_text): Remove unused local var.
85876d07 11149
03d78a21 11150 * filelock.c (within_one_second): Now static.
b3dd38ab 11151 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11152
5df8f01b
PE
11153 * buffer.c (fix_overlays_before): Mark locals as initialized.
11154 (fix_start_end_in_overlays): Likewise. This function should be
11155 simplified by using pointers-to-pointers, but that's a different
11156 matter.
b1d876f1 11157 (switch_to_buffer_1): Now static.
8f54f30a
PE
11158 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11159 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11160
a70072c9 11161 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11162 Fix pointer signedness issue.
edced198
PE
11163 (sys_subshell): Mark local as volatile if checking for lint,
11164 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11165 (MAXPATHLEN): Define only if needed.
a70072c9 11166
a0977c44
PE
11167 * process.c (serial_open, serial_configure): Move decls from here ...
11168 * systty.h: ... to here, so that they can be checked.
11169
a884fdcc
PE
11170 * fns.c (get_random, seed_random): Move extern decls from here ...
11171 * lisp.h: ... to here, so that they can be checked.
11172
604efe86 11173 * sysdep.c (reset_io): Now static.
b8950c94 11174 (wait_for_termination_signal): Remove; unused.
604efe86 11175
38fc62d9
PE
11176 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11177 (copy_keymap_item, append_key, push_text_char_description):
11178 Now static.
1004a21a 11179 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11180 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11181 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11182 (describe_map_tree):
11183 Rename locals to avoid shadowing.
38fc62d9 11184
2f2650da
PE
11185 * keyboard.c: Declare functions static if they are not used elsewhere.
11186 (echo_char, echo_dash, cmd_error, top_level_2):
11187 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11188 (read_char, kbd_buffer_get_event, make_lispy_position):
11189 (make_lispy_event, make_lispy_movement, apply_modifiers):
11190 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11191 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11192 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11193 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11194 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11195
a053e86c 11196 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11197 (mark_kboards): Move decl here ...
11198 * alloc.c (mark_kboards): ... from here.
a053e86c 11199
4752793e
PE
11200 * lisp.h (force_auto_save_soon): New decl.
11201
74f10ca7 11202 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11203 (DEFINE_DUMMY_FUNCTION): New macro.
11204 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11205 Use it.
c03cd23f
PE
11206 (main): Add casts to avoid warnings
11207 if GCC considers string literals to be constants.
74f10ca7 11208
022e70d4
PE
11209 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11210
59d6fe83
PE
11211 * dbusbind.c: Pointer signedness fixes.
11212 (xd_signature, xd_append_arg, xd_initialize):
11213 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11214 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11215 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11216 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11217
78320123
PE
11218 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11219 if GCC considers string literals to be constants.
49cebcca 11220 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11221
35ac2a97
SM
112222011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11223
fb103ca9
SM
11224 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11225 (print_preprocess, print_object): New macro to fix last change.
11226
35ac2a97
SM
11227 * print.c (print_preprocess): Don't forget font objects.
11228
62973b41
JB
112292011-03-16 Juanma Barranquero <lekktu@gmail.com>
11230
11231 * emacs.c (USAGE3): Doc fixes.
11232
0e48bb22
AS
112332011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11234
11235 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11236 structure.
11237
7684e57b
JB
112382011-03-14 Juanma Barranquero <lekktu@gmail.com>
11239
11240 * lisp.h (VWindow_system, Qfile_name_history):
11241 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11242 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11243 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11244
11245 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11246 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11247
11248 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11249 * w32console.c (detect_input_pending, read_input_pending)
11250 (encode_terminal_code):
11251 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11252 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11253 (w32_system_caret_y, Qfile_name_history):
11254 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11255 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11256 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11257 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11258 * w32proc.c (Qlocal, report_file_error):
11259 * w32term.c (Vwindow_system, updating_frame):
11260 * w32uniscribe.c (initialized, uniscribe_font_driver):
11261 Remove unneeded extern declarations.
11262
2aa46d6c
CY
112632011-03-14 Chong Yidong <cyd@stupidchicken.com>
11264
c96bbc66 11265 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11266
cffc6f3b
CY
112672011-03-13 Chong Yidong <cyd@stupidchicken.com>
11268
11269 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11270 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11271 These macros can no longer be used for assignment.
11272
44f230aa
SM
11273 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11274 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11275 (record_buffer_markers, fetch_buffer_markers): New functions for
11276 recording and fetching special buffer markers.
11277 (set_buffer_internal_1, set_buffer_temp): Use them.
11278
11279 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11280
11281 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11282
11283 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11284 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11285
11286 * xdisp.c (hscroll_window_tree):
11287 (reconsider_clip_changes): Use PT instead of BUF_PT.
11288
d251f04b
EZ
112892011-03-13 Eli Zaretskii <eliz@gnu.org>
11290
11291 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11292 $(EMACS_ROOT)/lib/intprops.h.
11293
f0c77cd1
PE
112942011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11295
3eca4629
PE
11296 Fix more problems found by GCC 4.5.2's static checks.
11297
7c86ee98
PE
11298 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11299 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11300 (xg_free_frame_widgets): Make it clear that a local variable is
11301 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11302 (gdk_window_get_screen): Make it clear that this macro is needed
11303 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11304 (int_gtk_range_get_value): New function, which avoids a diagnostic
11305 from gcc -Wbad-function-cast.
11306 (xg_set_toolkit_scroll_bar_thumb): Use it.
11307 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11308 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11309 (get_utf8_string, xg_get_file_with_chooser):
11310 Rename locals to avoid shadowing.
11311 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11312
41729b81
PE
11313 * xgselect.c (xg_select): Remove unused var.
11314
f0c77cd1
PE
11315 * image.c (four_corners_best): Mark locals as initialized.
11316 (gif_load): Initialize transparent_p to zero (Bug#8238).
11317 Mark another local as initialized.
ec6cf4c6 11318 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11319
ce0ad53d 11320 * image.c (clear_image_cache): Now static.
d5d5a617 11321 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11322 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11323 (x_edge_detection): Remove unnecessary cast that
11324 gcc -Wbad-function-cast diagnoses.
2037898d 11325 (gif_load): Fix pointer signedness.
6ae141d6
PE
11326 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11327 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11328
33383987 113292011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11330
d32df629
PE
11331 Improve quality of tests for time stamp overflow.
11332 For example, without this patch (encode-time 0 0 0 1 1
11333 1152921504606846976) returns the obviously-bogus value (-948597
11334 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11335 reports time overflow. See
11336 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11337 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11338 * editfns.c: Include limits.h and intprops.h.
11339 (TIME_T_MIN, TIME_T_MAX): New macros.
11340 (time_overflow): Move earlier, to before first use.
11341 (hi_time, lo_time): New functions, for an accurate test for
11342 out-of-range times.
11343 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11344 (Fget_internal_run_time): Don't assume time_t fits in int.
11345 (make_time): Use list2 instead of Fcons twice.
11346 (Fdecode_time): More accurate test for out-of-range times.
11347 (check_tm_member): New function.
11348 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11349 (lisp_time_argument): Don't rely on undefined left-shift and
11350 right-shift behavior when checking for time stamp overflow.
8be6f318 11351
fe31d94c
PE
11352 * editfns.c (time_overflow): New function, refactoring common code.
11353 (Fformat_time_string, Fdecode_time, Fencode_time):
11354 (Fcurrent_time_string): Use it.
11355
8be6f318
PE
11356 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11357 * dired.c (make_time): Move to ...
11358 * editfns.c (make_time): ... here.
11359 * systime.h: Note the move.
11360
09d9db2c 113612011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11362
126bc0dc
YM
11363 * fringe.c (update_window_fringes): Remove unused variables.
11364
c47cbdfd
YM
11365 * unexmacosx.c (copy_data_segment): Also copy __got section.
11366 (Bug#8223)
11367
7ac80be9
EZ
113682011-03-12 Eli Zaretskii <eliz@gnu.org>
11369
c96bbc66 11370 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11371 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11372 Constify `char *' arguments and their references according to
11373 prototypes in tparam.h.
11374
ecb0f94d 11375 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11376
7ac80be9
EZ
11377 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11378 Adapt all references accordingly.
11379
11380 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11381
ef1fd07e
TT
113822011-03-11 Tom Tromey <tromey@redhat.com>
11383
11384 * buffer.c (syms_of_buffer): Remove obsolete comment.
11385
7ef4b50c
EZ
113862011-03-11 Eli Zaretskii <eliz@gnu.org>
11387
11388 * termhooks.h (encode_terminal_code): Declare prototype.
11389
11390 * msdos.c (encode_terminal_code): Don't declare prototype.
11391
11392 * term.c (encode_terminal_code): Now external again, used by
11393 w32console.c and msdos.c.
11394
44f230aa
SM
11395 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11396 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11397
4b1ec863 113982011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11399
1714f52b 11400 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11401
4b1ec863
PE
11402 * fringe.c (update_window_fringes): Mark locals as initialized
11403 (Bug#8227).
11404 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11405
524c7aa6
PE
11406 * alloc.c (mark_fringe_data): Move decl from here ...
11407 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11408 to check its interface.
11409 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11410
a5c0af81 11411 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11412 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11413 (fontset_font): Mark local as initialized.
a9a06e0b 11414 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11415
b4716021
PE
11416 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11417
811e9bac 11418 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11419 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11420 (x_own_selection, Fx_disown_selection_internal): Rename locals
11421 to avoid shadowing.
11422 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11423
7e3ab302
PE
11424 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11425 so that the caller can use some name other than gcpro1.
11426 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11427 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11428 (Fx_backspace_delete_keys_p):
11429 Use them to avoid shadowing, and rename vars to avoid shadowing.
11430 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11431 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11432 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11433 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11434 Remove unused locals.
7e3ab302
PE
11435 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11436 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11437 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11438 macros.
f78faa98 11439
e2b13473
PE
11440 * xterm.h (x_mouse_leave): New decl.
11441
77f23912
PE
11442 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11443 Remove unused functions.
cdf4ba58
PE
11444 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11445 (x_calc_absolute_position): Now static.
7411c686 11446 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11447 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11448 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11449 unless they are used.
38d0b34a
PE
11450 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11451 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11452 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11453 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11454 (x_error_catcher, x_connection_closed, x_error_handler):
11455 (x_error_quitter, xembed_send_message, x_iconify_frame):
11456 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11457 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11458 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11459
44f230aa
SM
11460 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11461 Rename or move locals to avoid shadowing.
6b463e58 11462 (tty_defined_color, merge_face_heights): Now static.
5967d051 11463 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11464 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11465 does not deduce is never used uninitialized.
73719eba
PE
11466 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11467 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11468
426994c3 11469 * terminal.c (store_terminal_param): Now static.
5489860b 11470
032f1620 11471 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11472 (set_frame_menubar): Remove unused local.
d4323972 11473 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11474 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11475 since they might point to immutable storage.
281585b0
PE
11476 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11477 since it's unused otherwise.
032f1620 11478
367c19e5 11479 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11480 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11481 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11482 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11483 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11484 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11485 does not deduce are never used uninitialized.
70739cbe 11486
07b48fa9
PE
11487 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11488
8868a238 11489 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11490 * window.c (window_loop, size_window):
11491 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11492
7e5cf297 11493 * window.c (display_buffer): Now static.
d6550a9f
PE
11494 (size_window): Mark variables that gcc -Wuninitialized
11495 does not deduce are never used uninitialized.
a586633d
PE
11496 * window.h (check_all_windows): New decl, to forestall
11497 gcc -Wmissing-prototypes diagnostic.
5b555da1 11498 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11499
f6095868
PE
11500 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11501 shadowing.
11502 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11503 Include <limits.h>.
11504 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11505 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11506 (load_charset_map): Mark variables that gcc -Wuninitialized
11507 does not deduce are never used uninitialized.
53df7c11 11508 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11509
f38b440c
PE
11510 * coding.c (coding_set_source, coding_set_destination):
11511 Use "else { /* comment */ }" rather than "else /* comment */;"
11512 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11513 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11514 a block, when the outer 'i' will do.
11515 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11516 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11517 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11518 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11519 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11520 Rename locals to avoid shadowing.
11521 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11522 * coding.c (emacs_mule_char, encode_invocation_designation):
11523 Now static, since they're not used elsewhere.
413bb2db 11524 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11525 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11526 (decode_coding_emacs_mule): Mark variables that gcc
11527 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11528 (detect_coding_iso_2022): Initialize a local variable that might
11529 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11530 this initialization is needed. (Bug#8211)
5f58e762
PE
11531 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11532 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11533 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11534 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11535 Remove unused macros.
f38b440c 11536
232b38b9 11537 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11538 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11539 * character.c (string_count_byte8): Likewise.
232b38b9 11540
fb90da1b
PE
11541 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11542 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11543
fb93dbc2
PE
11544 * chartab.c (copy_sub_char_table): Now static, since it's not used
11545 elsewhere.
5c156ace
PE
11546 (sub_char_table_ref_and_range, char_table_ref_and_range):
11547 Rename locals to avoid shadowing.
bbcd0949 11548 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11549
7d3b3862 11550 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11551 (BIDI_BOB): Remove unused macro.
7d3b3862 11552
6be7d3da
PE
11553 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11554 deduce are never used uninitialized.
c2ed9c8b 11555 * term.c (encode_terminal_code): Likewise.
6be7d3da 11556
75f8807f 11557 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11558
50938595
PE
11559 * tparam.h: New file.
11560 * term.c, tparam.h: Include it.
11561 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11562 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11563 Move these decls to tparam.h, and make them agree with what
11564 is actually in tparam.c. The previous trick of using incompatible
11565 decls in different modules does not conform to the C standard.
11566 All callers of tparam changed to use tparam's actual API.
11567 * tparam.c (tparam1, tparam, tgoto):
11568 Use const pointers where appropriate.
11569
fbceeba2
PE
11570 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11571 * cm.h (struct cm): Likewise.
11572 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11573 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11574 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11575 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11576 (turn_on_face, init_tty): Likewise.
11577 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11578
7f3f1250
PE
11579 * term.c (term_mouse_position): Rename local to avoid shadowing.
11580
e6ca6543
PE
11581 * alloc.c (mark_ttys): Move decl from here ...
11582 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11583
c40f8d15
AS
115842011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11585
11586 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11587
cfe0661d
JB
115882011-03-09 Juanma Barranquero <lekktu@gmail.com>
11589
11590 * search.c (compile_pattern_1): Remove argument regp, unused since
11591 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11592 (compile_pattern): Don't pass it.
11593
0afb4571
J
115942011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11595
11596 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11597 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11598 for ! HAVE_GTK3.
11599 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11600
11601 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11602
11603 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11604 gdk_window_get_screen, gdk_window_get_geometry,
11605 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11606 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11607 (xg_get_pixbuf_from_pixmap): New function.
11608 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11609 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11610 Call xg_get_pixbuf_from_pixmap instead of
11611 gdk_pixbuf_get_from_drawable.
11612 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11613 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11614 (xg_check_special_colors): Use GtkStyleContext and its functions
11615 for HAVE_GTK3.
11616 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11617 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11618 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11619 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11620 Call gtk_widget_get_preferred_size.
0afb4571
J
11621 (xg_frame_resized): gdk_window_get_geometry only takes 5
11622 parameters.
44f230aa
SM
11623 (xg_win_to_widget, xg_event_is_for_menubar):
11624 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11625 (xg_set_widget_bg): New function.
11626 (delete_cb): New function.
895009e1 11627 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11628 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11629 (xg_set_background_color): Call xg_set_widget_bg.
11630 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11631 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11632 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11633 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11634 if ! HAVE_GTK3.
11635 (update_frame_tool_bar): Call gtk_widget_hide.
11636 (xg_initialize): Use GDK_KEY_g.
11637
11638 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11639 if ! HAVE_GTK3
11640 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11641
11642 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11643 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11644 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11645
1c2cc4ef
JB
116462011-03-08 Juanma Barranquero <lekktu@gmail.com>
11647
11648 * w32xfns.c (select_palette): Check success of RealizePalette against
11649 GDI_ERROR, not zero.
11650
33383987 11651See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11652
11653;; Local Variables:
11654;; coding: utf-8
aac0c6e3
MR
11655;; End:
11656
2f097256 11657 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11658
11659 This file is part of GNU Emacs.
11660
11661 GNU Emacs is free software: you can redistribute it and/or modify
11662 it under the terms of the GNU General Public License as published by
11663 the Free Software Foundation, either version 3 of the License, or
11664 (at your option) any later version.
11665
11666 GNU Emacs is distributed in the hope that it will be useful,
11667 but WITHOUT ANY WARRANTY; without even the implied warranty of
11668 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11669 GNU General Public License for more details.
11670
11671 You should have received a copy of the GNU General Public License
11672 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.