(xg_make_tool_item): Insert comment about eventbox.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
115b96bd
JD
12011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4
c8199d0f
PE
52011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6
7 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8 Without this fix, the command to link temacs failed due to an
9 undefined symbol __builtin_isnan. This is because
10 /usr/include/iso/math_c99.h #defines isnan(x) to
11 __builtin_isnan(x), but the bundled gcc, which identifies itself
12 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
13 a __builtin_isnan.
14 * floatfns.c (isnan): #undef, and then #define to a clone of
15 what's in data.c.
16 (Fisnan): Always define, since it's always available now.
17 (syms_of_floatfns): Always define isnan at the Lisp level.
18
e39b275c 192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
20
21 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
22
b2db44d9 232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 24
f4af5137 25 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
26 The previous code assumed that file offsets (off_t values) fit in
27 EMACS_INT variables, which is not true on typical 32-bit hosts.
28 The code messed up by falsely reporting buffer overflow in cases
29 such as (insert-file-contents "big" nil 1 2) into an empty buffer
30 when "big" contains more than 2**29 bytes, even though this
31 inserts just one byte and does not overflow the buffer.
32 (Finsert_file_contents): Store file offsets as off_t
33 values, not as EMACS_INT values. Check for overflow when
34 converting between EMACS_INT and off_t. When checking for
35 buffer overflow or for overlap, take the offsets into account.
36 Don't use EMACS_INT for small values where int suffices.
37 When checking for overlap, fix a typo: ZV was used where
38 ZV_BYTE was intended.
39 (Fwrite_region): Don't assume off_t fits into 'long'.
40 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
41
ecfc0a49
MA
422011-09-05 Michael Albinus <michael.albinus@gmx.de>
43
44 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
45
6511acf2 462011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 47
0999621a 48 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
49
50 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 51 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
52 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
53 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
54 (modify_event_symbol): Do not assume that the length of
55 name_alist_or_stem is safe to alloca and fits in int.
56 (Fexecute_extended_command): Likewise for function name and binding.
57 (Frecursion_depth): Wrap around reliably on integer overflow.
58 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
59 since some callers pass EMACS_INT values.
60 (Fsingle_key_description): Don't crash if symbol name contains more
61 than MAX_ALLOCA bytes.
62 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
63 (get_minibuffer): Arg is now EMACS_INT, not int.
64 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 65 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
66 * window.h (command_loop_level, minibuf_level): Reflect API changes.
67
2be7d702
PE
68 * dbusbind.c (signature_cat): New function.
69 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
70 Do not overrun buffer; instead, report string overflow.
71
9d1df220
PE
72 * dispnew.c (add_window_display_history): Don't overrun buffer.
73 Truncate instead; this is OK since it's just a log.
74
33ef5c64
PE
75 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
76 even if the time zone offset is outlandishly large.
77 Don't mishandle offset == INT_MIN.
78
66c6fdd5
PE
79 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
80 when creating daemon; the previous buffer-overflow check was incorrect.
81
d749b01b
PE
82 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
83 which has the guts of the old verror function.
84
b5cd1905
PE
85 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
86 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
87
6e1a67fb
PE
88 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
89 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 90 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 91 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
92 length of string rather than counting it via multiple sprintfs;
93 that's simpler and more reliable.
c21721cc
PE
94 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
95 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
96 sprintf, in case result does not fit in int.
97
c57b67fc
PE
98 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
99 (fontset_from_font): Print it.
100
8a401434
PE
101 * frame.c (tty_frame_count): Now printmax_t, not int.
102 (make_terminal_frame, set_term_frame_name): Print it.
103 (x_report_frame_params): In X, window IDs are unsigned long,
104 not signed long, so print them as unsigned.
105 (validate_x_resource_name): Check for implausibly long names,
106 and don't assume name length fits in 'int'.
107 (x_get_resource_string): Don't blindly alloca invocation name;
108 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
109 not fit in int.
110
6e1a67fb
PE
111 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
112 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
113 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
114
0df02bf3
PE
115 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
116 Use esprintf, not sprintf, in case result does not fit in int.
117
48e30793
PE
118 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
119 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
120 it as a large positive number.
121 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
122 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
123
a66ff6d8
PE
124 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
125 in case result does not fit in int.
126
aca216ff
PE
127 * print.c (float_to_string): Detect width overflow more reliably.
128 (print_object): Make sprintf buffer a bit bigger, to avoid potential
129 buffer overrun. Don't assume list length fits in 'int'. Treat
130 print length of 0 as 0, not as infinity; to be consistent with other
131 uses of print length in this function. Don't overflow print length
132 index. Don't assume hash table size fits in 'long', or that
133 vectorlike size fits in 'unsigned long'.
134
31c286f7
PE
135 * process.c (make_process): Use printmax_t, not int, to format
136 process-name gensyms.
137
55e5faa1
PE
138 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
139
80f2e268
PE
140 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
141 to avoid potential buffer overrun.
142
670741ab
PE
143 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
144 if X resource line is longer than 512 bytes.
145
b7163a50
PE
146 * xfns.c (x_window): Make sprintf buffer a bit bigger
147 to avoid potential buffer overrun.
148
ae58ff1f
PE
149 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
150
c43c8a6a
PE
151 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
152
3f8236f4
PE
1532011-09-04 Paul Eggert <eggert@cs.ucla.edu>
154
53e9fe90 155 Integer overflow fixes for scrolling, etc.
6511acf2
PE
156 Without these, Emacs silently mishandles large integers sometimes.
157 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
158 it were "C-u 1 M-x recenter" on a typical 64-bit host.
159
6511acf2
PE
160 * xdisp.c (try_window_id): Check Emacs fixnum range before
161 converting to 'int'.
806add1d 162
6511acf2 163 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
164 Check that an Emacs fixnum is in range before assigning it to 'int'.
165 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
166 values converted from Emacs fixnums.
167 (Frecenter): Don't wrap around a line count if it is out of 'int'
168 range; instead, treat it as an extreme value.
169 (Fset_window_configuration, compare_window_configurations):
170 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
171
6511acf2
PE
172 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
173 that can exceed INT_MAX. Check that EMACS_INT value is in range
174 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
175 (match_limit): Don't assume that a fixnum can fit in 'int'.
176
6511acf2 177 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
178 exceed INT_MAX.
179
6511acf2 180 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
181 (Fvertical_motion): Don't wrap around LINES values that don't fit
182 in 'int'. Instead, treat them as extreme values. This is good
183 enough for windows, which can't have more than INT_MAX lines anyway.
184
fcb901a7
LMI
1852011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
186
0f2f6b6d
LMI
187 * Require libxml/parser.h to avoid compilation warning.
188
fcb901a7
LMI
189 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
190
191 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
192 since this reportedly can destroy thread storage.
193
6e20a0d4
CY
1942011-08-30 Chong Yidong <cyd@stupidchicken.com>
195
196 * syntax.c (find_defun_start): Update all cache variables if
197 exiting early (Bug#9401).
198
148ae00e
EZ
1992011-08-30 Eli Zaretskii <eliz@gnu.org>
200
f6cfbd8f
EZ
201 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
202
148ae00e
EZ
203 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
204 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
205 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
206
207 * term.c (tty_append_glyph): New function.
208 (produce_stretch_glyph): Static function and its prototype deleted.
209
210 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
211 prototypes.
212
c4a07a4c
PE
2132011-08-29 Paul Eggert <eggert@cs.ucla.edu>
214
215 * image.c (parse_image_spec): Check for nonnegative, not for positive,
216 when checking :margin (Bug#9390).
217 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
218 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
219 so that the name doesn't mislead. All uses changed.
220
6bc8cd65
JB
2212011-08-28 Johan Bockgård <bojohan@gnu.org>
222
223 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
224 set_tty_hooks.
225
dca4927e
EZ
2262011-08-27 Eli Zaretskii <eliz@gnu.org>
227
228 * xdisp.c (move_it_to): Don't bail out early when reaching
229 position beyond to_charpos, if we are scanning backwards.
230 (move_it_vertically_backward): When DY == 0, make sure we get to
231 the first character in the line after the newline.
232
f2cad773
PE
2332011-08-27 Paul Eggert <eggert@cs.ucla.edu>
234
235 * ccl.c: Improve and simplify overflow checking (Bug#9196).
236 (ccl_driver): Do not generate an out-of-range pointer.
237 (Fccl_execute_on_string): Remove unnecessary check for
238 integer overflow, noted by Stefan Monnier in
239 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
240 Remove a FIXME that didn't need fixing.
241 Simplify the newly-introduced buffer reallocation code.
242
0cae2cdb
JB
2432011-08-27 Juanma Barranquero <lekktu@gmail.com>
244
245 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
246
5fc295a4 2472011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 248
70c60eb2 249 Integer and memory overflow issues (Bug#9196).
726e0ab1 250
d31850da
PE
251 * doc.c (get_doc_string): Rework so that
252 get_doc_string_buffer_size is the actual buffer size, rather than
253 being 1 less than the actual buffer size; this makes xpalloc more
254 convenient.
255
a69fbedb
PE
256 * image.c (x_allocate_bitmap_record, cache_image):
257 * xselect.c (Fx_register_dnd_atom):
258 Simplify previous changes by using xpalloc.
259
fe5c5d37
PE
260 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
261 since either will do and ptrdiff_t is convenient with xpalloc.
262
0065d054
PE
263 * charset.c (charset_table_size)
264 (struct charset_sort_data.priority): Now ptrdiff_t.
265 (charset_compare): Don't overflow if priorities differ greatly.
266 (Fsort_charsets): Don't assume list length fits in int.
267 Check for size-calculation overflow when allocating sort data.
268 (syms_of_charset): Allocate an initial charset table that is
269 just under 64 KiB, to avoid problems with glibc malloc and mmap.
270
271 * cmds.c (internal_self_insert): Check for size-calculation overflow.
272
273 * composite.h (struct composition.glyph_len): Now int, not unsigned.
274 The actual value is always <= INT_MAX, and leaving it unsigned made
275 overflow checking harder.
276
277 * dispextern.h (struct glyph_matrix.rows_allocated)
278 (struct face_cache.size): Now ptrdiff_t, for convenience in use
279 with xpalloc. The values are still always <= INT_MAX.
280
281 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
282
283 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
284 (SAFE_NALLOCA): New macro.
285
286 * region-cache.c (struct boundary.pos, find_cache_boundary)
287 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
288 (set_cache_region, invalidate_region_cache)
289 (revalidate_region_cache, know_region_cache, region_cache_forward)
290 (region_cache_backward, pp_cache):
291 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
292 so that ptrdiff_t * can be passed to xpalloc.
293 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
294 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
295 (pp_cache): Don't assume cache_len fits in int.
296 * region-cache.h: Adjust extern decls to match.
297
298 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
299 EMACS_INT, since either will do, for xpalloc.
300
301 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
302 (xnmalloc, xnrealloc, xpalloc): New functions.
303
726e0ab1
PE
304 * bidi.c (bidi_shelve_header_size): New constant.
305 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
306 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
307
51f30bc5 308 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
309 * buffer.c (overlays_at, overlays_in, record_overlay_string)
310 (overlay_strings):
311 Don't update size of array until after memory allocation succeeds,
312 because xmalloc/xrealloc may not return.
0065d054
PE
313 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
314 now that we have proper integer overflow checking.
315 (record_overlay_string, overlay_strings): Catch overflows when
316 calculating size of overlay_str_buf.
726e0ab1 317
0065d054
PE
318 * callproc.c (Fcall_process): Check for size overflow when
319 calculating size of args2.
320 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
321 Normally we prefer signed values, but sticking with ptrdiff_t would
322 require adding more-complicated checks.
726e0ab1
PE
323
324 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
325 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
326 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 327 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
328
329 * character.c (Fstring): Check for size-calculation overflow.
330
331 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
332 unnecessary integer overflow. Check for size overflow.
333 (encode_coding_object): Don't update size until xmalloc succeeds.
334
335 * composite.c (get_composition_id): Check for overflow in glyph
336 length calculations.
337
338 Integer and memory overflow fixes for display code.
339 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
340 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
341 (scrolling_window): Check for overflow in size calculations.
342 (line_draw_cost, realloc_glyph_pool, add_row_entry):
343 Don't assume glyph table len fits in int.
344 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
345 (row_table_size): Now ptrdiff_t, not int.
346 (scrolling_window): Avoid overflow in size calculations.
347 Don't update size until allocation succeeds.
348 * fns.c (concat): Check for overflow in size calculations.
349 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
350 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
351 (NEXT_ALMOST_PRIME_LIMIT): New constant.
352
353 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
354 (get_doc_string): Check for size calculation overflow.
355 Don't update size until allocation succeeds.
356 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
357 EMACS_INT, where ptrdiff_t will do.
358 (Fsubstitute_command_keys): Check for string overflow.
359
360 * editfns.c (set_time_zone_rule): Don't assume environment length
361 fits in int.
362 (message_length): Now ptrdiff_t, not int.
363 (Fmessage_box): Don't update size until allocation succeeds.
364 Don't assume message length fits in int.
365 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
366
0065d054
PE
367 * emacs.c (main): Do not reallocate argv, since there is a null at
368 the end that can be overwritten, and this way there's no need to
369 worry about size-calculation overflow.
370 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
371
372 * eval.c (init_eval_once, grow_specpdl): Don't update size until
373 alloc succeeds.
374 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
375
376 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
377 (x_set_scroll_bar_width, x_figure_window_size):
378 Check for integer overflow.
379 (x_set_alpha): Do not assume XINT fits in int.
380
381 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
382 This is for the members text_lines, text_cols, total_lines, total_cols,
383 where the system imposes an 'int' limit.
384
385 * fringe.c (Fdefine_fringe_bitmap):
386 Don't update size until alloc works.
387
388 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
389 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
390
391 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
392 Check for size-calculation overflow.
393 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
394 do, as we prefer signed integers.
395 (id_to_widget.max_size, id_to_widget.used)
396 (xg_store_widget_in_map, xg_remove_widget_from_map)
397 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
398 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
399 Use and return ptrdiff_t, not int.
400 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
401 * gtkutil.h: Change prototypes to match the above.
402
403 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
404 are duplicate now that they've been promoted to lisp.h.
405 (x_allocate_bitmap_record, x_alloc_image_color)
406 (make_image_cache, cache_image, xpm_load):
407 Don't update size until alloc is done.
408 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
409 (x_detect_edges):
3256efce 410 Check for size calculation overflow.
726e0ab1
PE
411 (ct_colors_allocated_max): New constant.
412 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
413 overflow.
3256efce 414
726e0ab1
PE
415 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
416 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
417 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
418 Use ptrdiff_t, not int, to count maps.
419 (read_char_minibuf_menu_prompt): Check for overflow in size
420 calculations. Don't update size until allocation succeeds. Redo
421 calculations to avoid overflow.
422 * keyboard.h: Change prototypes to match the above.
423
424 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
425 to count maps.
426 (current_minor_maps): Check for size calculation overflow.
427 * keymap.h: Change prototypes to match the above.
428
429 * lread.c (read1, init_obarray): Don't update size until alloc done.
430
431 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
432 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
433
726e0ab1
PE
434 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
435 Now ptrdiff_t, not int.
436 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
437 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
438
439 * process.c (Fnetwork_interface_list): Check for overflow
440 in size calculation.
441
442 * region-cache.c (move_cache_gap): Check for size calculation overflow.
443
444 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
445 overflow. Don't bother calling xmalloc when xrealloc will do.
446
447 * search.c (Freplace_match): Check for size calculation overflow.
448 (Fset_match_data): Don't assume list lengths fit in 'int'.
449
450 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
451 for command line length. Do not attempt to address one before the
452 beginning of an array, as that's not portable.
453
454 * term.c (max_frame_lines): Remove; unused.
455 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
456 not int.
457 (encode_terminal_code, calculate_costs): Check for size
458 calculation overflow.
459 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
460 table lengths and related sizes. Don't update size until alloc
461 done. Redo calculations to avoid overflow.
462 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
463
464 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
465 subtracting pointers.
466 (gobble_line): Check for overflow more carefully. Don't update size
467 until alloc done.
468
469 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
470 Don't update size until alloc done.
471 Redo size calculations to avoid overflow.
472 Check for size calculation overflow.
0065d054 473 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
474
475 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
476 Use ptrdiff_t, not int, for sizes.
477 (store_mode_line_noprop_char): Don't update size until alloc done.
478
0065d054
PE
479 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
480 Use ptrdiff_t, not int, for sizes.
481 (Finternal_make_lisp_face, cache_face):
482 Check for size calculation overflow.
483 (cache_face): Treat size calculation overflows as if they were
484 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
485
486 * xfns.c (x_encode_text, x_set_name_internal)
487 (Fx_change_window_property): Use ptrdiff_t, not int, to count
488 sizes, since they can exceed INT_MAX in size. Check for size
489 calculation overflow.
490
0065d054
PE
491 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
492 (xg_select): Check for size calculation overflow.
726e0ab1
PE
493 Don't update size until alloc done.
494
0065d054 495 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 496 as sprintf is limited to int lengths.
1d526e2f 497
252c5ee1
PE
498 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
499 (X_LONG_MIN): New macros.
864d7ce7
PE
500 Use them to make the following changes clearer.
501 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
502 This change doesn't affect the value now, but it may help remind
503 future maintainers not to raise the value too much later.
504 (SELECTION_QUANTUM): Remove, replacing with ...
505 (selection_quantum): ... new function, which avoids overflow.
506 All uses changed.
507 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
508 assumption that selection length fits in 'int'.
509 (x_reply_selection_request, x_handle_selection_request)
510 (x_get_window_property, receive_incremental_selection)
511 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
512 (lisp_data_to_selection_data, clean_local_selection_data):
513 Use ptrdiff_t, not int, to record length of selection.
514 (x_reply_selection_request, x_get_window_property)
515 (receive_incremental_selection, x_property_data_to_lisp):
516 Redo calculations to avoid overflow.
517 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 518 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
519 something.
520 (x_get_window_property, receive_incremental_selection)
521 (lisp_data_to_selection_data, x_property_data_to_lisp):
522 Check for size-calculation overflow.
523 (x_get_window_property, receive_incremental_selection)
524 (lisp_data_to_selection_data, Fx_register_dnd_atom):
525 Don't store size until memory allocation succeeds.
526 (x_get_window_property): Plug memory leak on memory exhaustion.
527 Don't double-block input; malloc is safe here. Don't assume 2**34
528 - 4 fits in unsigned long. Add an xassert to check
529 XGetWindowProperty overflow. Be more careful about overflow
530 calculations, and distinguish size from memory overflow better.
531 (receive_incremental_selection): When tracing, don't assume
532 unsigned int is less than INT_MAX.
533 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
534 harmful) conversions of unsigned short to int.
535 (lisp_data_to_selection_data): Don't assume that integers
536 in the range -65535 through -1 fit in an X unsigned short.
537 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
538 result parameters unless successful. Rely on cons_to_unsigned
539 to report problems with elements; the old code wasn't right anyway.
540 (x_check_property_data): Check for int overflow; we cannot use
541 a wider type due to X limits.
542 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
543
726e0ab1 544 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 545
0065d054
PE
546 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
547 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
548 (x_color_cells): Don't store size until memory allocation succeeds.
549 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 550 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
551 (x_term_init): Don't assume length fits in int (sprintf is limited
552 to int size).
bc18e09d 553
ebfa62c0
PE
554 Use ptrdiff_t for composition IDs.
555 * character.c (lisp_string_width):
556 * composite.c (composition_table_size, n_compositions)
557 (get_composition_id, composition_gstring_from_id):
558 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
559 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
560 * window.c (Frecenter):
561 Use ptrdiff_t, not int, for composition IDs.
562 * composite.c (get_composition_id): Check for integer overflow.
563 * composite.h: Adjust prototypes to match the above changes.
564
d3411f89
PE
565 Use ptrdiff_t for hash table indexes.
566 * category.c (hash_get_category_set):
567 * ccl.c (ccl_driver):
568 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
569 * coding.c (coding_system_charset_list, detect_coding_system):
570 * coding.h (struct coding_system.id):
571 * composite.c (get_composition_id, gstring_lookup_cache):
572 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
573 * image.c (xpm_get_color_table_h):
574 * lisp.h (hash_lookup, hash_put):
575 * minibuf.c (Ftest_completion):
576 Use ptrdiff_t for hash table indexes, not int (which is too
577 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
578 32-bit --with-wide-int hosts).
579
e097a6fa
PE
580 * charset.c (Fdefine_charset_internal): Check for integer overflow.
581 Add a FIXME comment about memory leaks.
582 (syms_of_charset): Don't assume xmalloc returns.
583
5637687f
PE
584 Don't assume that stated character widths fit in int.
585 * character.c (Fchar_width, c_string_width, lisp_string_width):
586 * character.h (CHAR_WIDTH):
587 * indent.c (MULTIBYTE_BYTES_WIDTH):
588 Use sanitize_char_width to avoid undefined and/or bad behavior
589 with outlandish widths.
590 * character.h (sanitize_tab_width): Renamed from sanitize_width,
591 now that we have two such functions. All uses changed.
592 (sanitize_char_width): New inline function.
593
a2271ba2
PE
594 Don't assume that tab-width fits in int.
595 * character.h (sanitize_width): New inline function.
596 (SANE_TAB_WIDTH): New macro.
597 (ASCII_CHAR_WIDTH): Use it.
598 * indent.c (sane_tab_width): Remove. All uses replaced by
599 SANE_TAB_WIDTH (current_buffer).
600 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
601
18c52557
PE
602 * fileio.c: Integer overflow issues with file modes.
603 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
604
caeeedc1
PE
605 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
606 Remove unreachable code.
607 (read_hex, load_charset_map_from_file): Check for integer overflow.
608
50849c52
PE
609 * xterm.c: don't go over XClientMessageEvent limit
610 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
611 (x_send_scroll_bar_event): Likewise. Check that the size does not
612 exceed limits imposed by XClientMessageEvent, as well as the usual
613 ptrdiff_t and size_t limits.
614
b13995db
PE
615 * keyboard.c: Overflow, signedness and related fixes.
616 (make_lispy_movement): Use same integer type in forward decl
617 that is used in the definition.
618 (read_key_sequence, keyremap_step):
619 Change bufsize argument back to int, undoing my 2011-03-30 change.
620 We prefer signed types, and int is wide enough here.
621 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
622 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
623 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
624 length, not size_t. Use ptrdiff_t for index, not int.
625 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
626 possibility of integer overflow.
627
13464394
PE
628 Overflow, signedness and related fixes for images.
629
630 * dispextern.h (struct it.stack[0].u.image.image_id)
631 (struct_it.image_id, struct image.id, struct image_cache.size)
632 (struct image_cache.used, struct image_cache.ref_count):
633 * gtkutil.c (update_frame_tool_bar):
634 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
635 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
636 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
637 * nsmenu.m (update_frame_tool_bar):
638 * xdisp.c (calc_pixel_width_or_height):
639 * xfns.c (image_cache_refcount):
640 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
641 on typical 64-bit hosts.
642
643 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
644 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
645 Omit unnecessary casts to int.
646 (parse_image_spec): Check that integers fall into 'int' range
647 when the callers expect that.
648 (image_ascent): Redo ascent calculation to avoid int overflow.
649 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
650 (lookup_image): Remove unnecessary tests.
651 (xbm_image_p): Locals are now of int, not EMACS_INT,
652 since parse_image_check makes sure they fit into int.
653 (png_load, gif_load, svg_load_image):
654 Prefer int to unsigned where either will do.
655 (tiff_handler): New function, combining the cores of the
656 old tiff_error_handler and tiff_warning_handler. This
657 function is rewritten to use vsnprintf and thereby avoid
658 stack buffer overflows. It uses only the features of vsnprintf
659 that are common to both POSIX and native Microsoft.
660 (tiff_error_handler, tiff_warning_handler): Use it.
661 (tiff_load, gif_load, imagemagick_load_image):
662 Don't assume :index value fits in 'int'.
663 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
664 (imagemagick_load_image): Check that crop parameters fit into
665 the integer types that MagickCropImage accepts. Don't assume
666 Vimagemagick_render_type has a nonnegative value. Don't assume
667 size_t fits in 'long'.
668 (gs_load): Use printmax_t to print the widest integers possible.
669 Check for integer overflow when computing image height and width.
670
c11821d4
EZ
6712011-08-26 Eli Zaretskii <eliz@gnu.org>
672
673 * xdisp.c (redisplay_window): Don't force window start if point
674 will be invisible in the resulting window. (Bug#9324)
675
0c95fcf7
EZ
6762011-08-25 Eli Zaretskii <eliz@gnu.org>
677
678 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
679 the display spec is of the form `(space ...)'.
680 (handle_display_spec): Return the value returned by
681 handle_single_display_spec, not just 1 or zero.
682 (handle_single_display_spec): If the display spec is of the form
683 `(space ...)', and specifies display in the text area, return 2
684 rather than 1.
fee65a97 685 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
686 accurately, and prefer exact match for point under bidi. Don't
687 advance `row' beyond the last row of the window.
0c95fcf7
EZ
688
689 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
690 into disp_prop; all users changed.
691
692 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
693 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
694 for the text covered by the display property.
695
e4ed06f1
CY
6962011-08-25 Chong Yidong <cyd@stupidchicken.com>
697
698 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
699 Change return value to nil.
700 (Frecord_buffer): Delete unused function.
701
f67cdd7f
EZ
7022011-08-24 Eli Zaretskii <eliz@gnu.org>
703
5980d4c6
EZ
704 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
705 buffers, return left-to-right.
8610fe8b
EZ
706 (set_cursor_from_row): Consider candidate row a win if its glyph
707 represents a newline and point is on that newline. Fixes cursor
708 positioning on the newline at EOL of R2L text within L2R
709 paragraph, and vice versa.
710 (try_cursor_movement): Check continued rows, in addition to
711 continuation rows. Fixes unwarranted scroll when point enters a
712 continued line of R2L text within an L2R paragraph, or vice versa.
713 (cursor_row_p): Consider the case of point being equal to
714 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
715 from the end of a short line to the beginning of a continued line
716 of R2L text within L2R paragraph.
717 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
718 composed characters.
5980d4c6 719
f67cdd7f
EZ
720 * bidi.c (bidi_check_type): Use xassert.
721 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
722 members.
723
bca633fb
EZ
7242011-08-23 Eli Zaretskii <eliz@gnu.org>
725
726 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
727 a character.
728
4a5885a7
CY
7292011-08-23 Chong Yidong <cyd@stupidchicken.com>
730
731 * nsfont.m (ns_otf_to_script): Fix typo.
732
0902a04e
KH
7332011-08-22 Kenichi Handa <handa@m17n.org>
734
735 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
736 extra slot even if the purpose is char-code-property-table.
737
1a2e6670
EZ
7382011-08-23 Eli Zaretskii <eliz@gnu.org>
739
8ddde651
EZ
740 * xdisp.c (redisplay_window): When computing centering_position,
741 account for the height of the header line. (Bug#8874)
742
425cc014
EZ
743 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
744 instead of CHAR_TO_BYTE. Fixes a crash when a completion
745 candidate is selected by the mouse, and that candidate has a
746 composed character under the mouse.
747
1a2e6670
EZ
748 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
749 coordinates reported by pos-visible-in-window-p for a composed
750 character in column zero.
751
8b76d6f8
SM
7522011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
753
754 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
755
dac347dd
EZ
7562011-08-22 Eli Zaretskii <eliz@gnu.org>
757
758 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
759 consider it a hit if to_charpos is anywhere in the range of the
760 composed buffer positions.
761
e013fb34
CY
7622011-08-22 Chong Yidong <cyd@stupidchicken.com>
763
764 * image.c (gif_load): Don't assume that each subimage has the same
765 dimensions as the base image. Handle disposal method that is
766 "undefined" by the gif spec (Bug#9335).
767
bd1ba3e8
CY
7682011-08-20 Chong Yidong <cyd@stupidchicken.com>
769
770 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 771 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 772
54a1215b
EZ
7732011-08-19 Eli Zaretskii <eliz@gnu.org>
774
823564e5
EZ
775 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
776 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
777 from an Org mode buffer to a Speedbar frame.
778
54a1215b
EZ
779 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
780 a composition, take its buffer position from IT->cmp_it.charpos.
781 Fixes cursor positioning at the beginning of a line that begins
782 with a composed character.
783
9778ebcc
EZ
7842011-08-18 Eli Zaretskii <eliz@gnu.org>
785
0be6ee06
EZ
786 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
787 character bidirectional type, use STRONG_L instead. Fixes crashes
788 in a buffer produced by `describe-categories'.
789
9778ebcc
EZ
790 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
791 members before the level stack, so they would be saved and
792 restored when copying iterator state. Fixes incorrect reordering
793 around TABs covered by display properties.
794
156bffbe
AS
7952011-08-18 Andreas Schwab <schwab@linux-m68k.org>
796
797 * process.c (Fnetwork_interface_list): Correctly determine buffer
798 size.
799
72ad093b
CY
8002011-08-17 Chong Yidong <cyd@stupidchicken.com>
801
802 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
803 (internal_condition_case_2, internal_condition_case_n):
804 Remove unnecessary aborts (Bug#9081).
72ad093b 805
35774242
EZ
8062011-08-17 Eli Zaretskii <eliz@gnu.org>
807
808 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
809 has no `load' handler, try opening the file locally. (Bug#9311)
810
db76dd85
KB
8112011-08-16 Ken Brown <kbrown@cornell.edu>
812
813 * gmalloc.c: Expand comment.
814
b215eee5
EZ
8152011-08-16 Eli Zaretskii <eliz@gnu.org>
816
817 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
818 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
819
a4579d33
KB
8202011-08-16 Ken Brown <kbrown@cornell.edu>
821
822 Fix memory allocation problems in Cygwin build (Bug#9273).
823
824 * unexcw.c ( __malloc_initialized): Declare external variable.
825 (fixup_executable): Force the dumped emacs to reinitialize malloc.
826
8b76d6f8
SM
827 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
828 New variables.
a4579d33
KB
829 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
830 dumped emacs.
831 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
832 in the static heap.
833 [CYGWIN] (special_realloc): New function.
834 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
835 requests to realloc storage in the static heap.
836
3ebec551
PE
8372011-08-15 Paul Eggert <eggert@cs.ucla.edu>
838
839 * bidi.c (bidi_initialize): Remove unused local.
840
9fd8be00
EZ
8412011-08-15 Eli Zaretskii <eliz@gnu.org>
842
474a8465
EZ
843 * biditype.h: File removed.
844
845 * bidimirror.h: File removed.
846
847 * deps.mk (bidi.o): Remove biditype.h and
848 bidimirror.h.
849
850 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
851 bidimirror.h.
852
853 * dispextern.h: Fix a typo in the comment to bidi_type_t.
854
855 * chartab.c: Improve commentary for the uniprop_table API.
856
32413314
EZ
857 * bidi.c (bidi_paragraph_init): Support zero value of
858 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
859 (bidi_initialize): Use uniprop_table instead of including
860 biditype.h and bidimirror.h.
32413314 861
9fd8be00
EZ
862 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
863 coordinates of the iterator when restoring from ppos_it.
864 (Bug#9296)
865
5cf2b69b
KH
8662011-08-14 Kenichi Handa <handa@m17n.org>
867
868 * process.c (create_process): Call setup_process_coding_systems
72ad093b 869 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 870
daf17d00
EZ
8712011-08-14 Eli Zaretskii <eliz@gnu.org>
872
873 * xdisp.c (move_it_in_display_line_to): Don't invoke
874 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
875 ppos_it. Fixes vertical cursor motion when line beginning is
876 covered by an image. (Bug#9296)
877
08e3161a
JD
8782011-08-14 Jan Djärv <jan.h.d@swipnet.se>
879
880 * nsterm.h (ns_run_ascript): Declare.
881 (NSAPP_DATA2_RUNASSCRIPT): Define.
882
883 * nsfns.m (as_script, as_result, as_status): New static variables.
884 (ns_run_ascript): New function.
885 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
886 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
887 the event loop. Get status from as_status (Bug#7276).
888
889 * nsterm.m (sendEvent): If event is NSApplicationDefined and
890 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
891 the event loop (Bug#7276).
892
a3720aa2
AS
8932011-08-14 Andreas Schwab <schwab@linux-m68k.org>
894
895 * gnutls.c (QCgnutls_bootprop_priority)
896 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
897 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
898 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
899 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
900 (QCgnutls_bootprop_verify_hostname_error)
901 (QCgnutls_bootprop_callbacks_verify): Rename from
902 Qgnutls_bootprop_..., all uses changed.
903
904 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
905 uses changed.
906
0a0d27fb
PE
9072011-08-14 Paul Eggert <eggert@cs.ucla.edu>
908
19d5c50c
PE
909 * xfaces.c (Qframe_set_background_mode): Now static.
910 * dispextern.h (Qframe_set_background_mode): Remove decl.
911
0a0d27fb
PE
912 * process.c (Fnetwork_interface_info): Declare local only if needed.
913
377538cb
JD
9142011-08-13 Jan Djärv <jan.h.d@swipnet.se>
915
916 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
917 (Fnetwork_interface_list): Allocate in increments of bytes instead
918 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
919 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
920 sockaddr.
921 (struct ifflag_def): notrailers is smart on OSX.
922 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
923 Get hardware address with getifaddrs if available.
924
08fff70c
EZ
9252011-08-12 Eli Zaretskii <eliz@gnu.org>
926
927 * xdisp.c (iterate_out_of_display_property): xassert that
928 IT->position is set to within IT->object's boundaries. Break from
929 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
930 when IT->position is set up wrongly due to some bug.
931 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
932 (push_display_prop): Allow GET_FROM_STRING as IT->method on
933 entry. Force push_it to save on the stack the current
934 buffer/string position, to be restored by pop_it. Fix flags in
935 the iterator structure wrt the object coming from a display
936 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
937 properties. (Bug#9284)
938
7be1c708 9392011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 940
7be1c708
CY
941 * fontset.c (fontset_get_font_group): Add proper type checks.
942 (Bug#9172)
aac0c6e3 943
7be1c708 9442011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 945
7be1c708
CY
946 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
947 and LC_VERSION_MIN_MACOSX.
948 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
949 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 950
97bb72a6
EZ
9512011-08-08 Eli Zaretskii <eliz@gnu.org>
952
953 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
954 no-display-properties-and-no-overlays under bidi display.
955 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 956 properties and overlays.
97bb72a6 957
d5617611
CY
9582011-08-08 Chong Yidong <cyd@stupidchicken.com>
959
37e11a63
CY
960 * editfns.c (Fset_time_zone_rule): Document relationship with the
961 setenv function.
962
d5617611
CY
963 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
964 the font entity extracted from the cache (Bug#8109).
965
58872834
CY
9662011-08-07 Chong Yidong <cyd@stupidchicken.com>
967
968 * composite.c (autocmp_chars): Don't reset point. That is done by
969 restore_point_unwind (Bug#5984).
970
75bfc667
JL
9712011-08-07 Juri Linkov <juri@jurta.org>
972
973 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
974 to show the arg `TIME' instead of `TIMEVAL'.
975
d1410150
EZ
9762011-08-06 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
979 display property strides EOL and includes a newline, as in
980 longlines-mode. (Bug#9254)
75b771e4
EZ
981 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
982 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
983
984 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
985 is non-zero, even if the data buffer is NULL. Fixes a crash in
986 vertical-motion with longlines-mode. (Bug#9254)
987
35928349
EZ
9882011-08-05 Eli Zaretskii <eliz@gnu.org>
989
ec7cc85b
EZ
990 * bidi.c <bidi_cache_total_alloc>: Now static.
991 (bidi_initialize): Initialize bidi_cache_total_alloc.
992
8b76d6f8 993 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
994 cache. (Bug#9221)
995
996 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
997 amount allocated this far in `bidi_cache_total_alloc'.
998 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
999 non-zero, only free the data buffer without restoring the cache
1000 contents. All callers changed.
1001
1002 * dispextern.h (bidi_unshelve_cache): Update prototype.
1003
1004 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1005 (move_it_in_display_line, move_it_to)
1006 (move_it_vertically_backward, move_it_by_lines): Replace the call
1007 to xfree to an equivalent call to bidi_unshelve_cache.
1008 (move_it_in_display_line_to): Fix logic of returning
412b6358 1009 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1010
e2e2423b
EZ
10112011-08-05 Eli Zaretskii <eliz@gnu.org>
1012
1013 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1014 came from a string character with a `cursor' property. (Bug#9229)
1015
ae9e757a
JD
10162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1017
1018 * Makefile.in (LIB_PTHREAD): New variable.
1019 (LIBES): Add LIB_PTHREAD (Bug#9216).
1020
1021 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1022 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1023
213bd7f2
AS
10242011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1025
1026 * regex.c (re_iswctype): Remove some redundant boolean
1027 conversions.
1028
99aaf75f
JD
10292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1030
1031 * xterm.c (x_find_topmost_parent): New function.
1032 (x_set_frame_alpha): Find topmost parent window with
1033 x_find_topmost_parent and set the property there also (bug#9181).
1034 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1035
c74e9d86
PE
10362011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 * callproc.c (Fcall_process): Avoid vfork clobbering
1039 the local vars buffer, coding_systems, current_dir.
1040
640c8776
SM
10412011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1042
1043 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1044
f26d0e4c
PE
10452011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1046
8a10d76c
PE
1047 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1048 so that it is not optimized away.
1049
f26d0e4c
PE
1050 * xdisp.c (compute_display_string_pos): Remove unused local.
1051
55439c61
EZ
10522011-08-02 Eli Zaretskii <eliz@gnu.org>
1053
1054 Fix slow cursor motion and scrolling in large buffers with
1055 selective display, like Org Mode buffers. (Bug#9218)
1056
1057 * dispextern.h (struct bidi_it): New member disp_prop_p.
1058
1059 * xdisp.c: Remove one-slot cache of display string positions.
1060 (compute_display_string_pos): Accept an additional argument
1061 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1062 for a display string or property. If found, set DISP_PROP_P
1063 non-zero.
1064
1065 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1066 DISP_PROP_P, and pass it to compute_display_string_pos.
1067 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1068 non-zero. All callers of bidi_fetch_char changed.
1069
fb33fa43
SM
10702011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1071
1072 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1073
b099e063
DM
10742010-12-03 Don March <don@ohspite.net>
1075
1076 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1077 last character M-[char] is translated to ESC [char] (bug#7541).
1078
5cc7f7af
KH
10792011-08-02 Kenichi Handa <handa@m17n.org>
1080
d0fffa3f 1081 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1082
1083 * chartab.c (uniprop_table): Make it non-static.
1084
525d5e6e
EZ
10852011-08-01 Eli Zaretskii <eliz@gnu.org>
1086
1087 * xdisp.c (forward_to_next_line_start): Accept additional argument
1088 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1089 on the newline.
1090 (reseat_at_next_visible_line_start): Use the bidi iterator state
1091 returned by forward_to_next_line_start to restore the state of
1092 it->bidi_it after backing up to previous newline. (Bug#9212)
1093
31011111
AS
10942011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1095
1096 * regex.c (re_comp): Protoize.
1097 (re_exec): Fix return type.
1098 (regexec): Fix type of `ret'. (Bug#9203)
1099
476371c4
PE
11002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1101
e5d76069
PE
1102 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1103 This is needed if max-image-size is a floating-point number.
1104
9a79b20c
AS
11052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1106
1107 * print.c (print_object): Print empty symbol as ##.
1108
1109 * lread.c (read1): Read ## as empty symbol.
1110
d8c2fa78
AA
11112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1112
1113 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1114 setting frame foreground color (Bug#9175).
1115 (x_set_background_color): Likewise.
1116
ffe57a7a
AA
1117 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1118 contents (Bug#9176).
1119 (EmacsTooltip -init): Remove bezels and add shadows to
1120 tooltip windows.
1121
bf3492a5
AA
1122 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1123 or scroll bar (Bug#8470).
1124
d55e9c53
AA
1125 * nsfont.m (nsfont_open): Remove assignment to voffset and
1126 unnecessary vars hshink, expand, hd, full_height, min_height.
1127 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1128
1129 * nsterm.h (nsfont_info): Remove voffset field.
1130
d8c2fa78 11312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1132
1133 Implement strike-through and overline on NextStep (Bug#8863).
1134
1135 * nsfont.m (nsfont_open): Use underline position provided by font,
1136 instead of hard-coded value of 2.
1137 (nsfont_draw): Call ns_draw_text_decoration instead.
1138
1139 * nsterm.h: Add declaration for ns_draw_text_decoration.
1140
1141 * nsterm.m (ns_draw_text_decoration): New function for drawing
1142 underline, overline, and strike-through.
1143 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1144 ns_draw_text_decoration. Change treatment of cursor drawing to
1145 accomodate underlining, etc.
1146
4cc60b9b
EZ
11472011-07-28 Eli Zaretskii <eliz@gnu.org>
1148
bc7ece87
EZ
1149 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1150 default.
4cc60b9b 1151
476371c4
PE
11522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1153
66606eea
PE
1154 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1155 Without this fix, if a signal arrives just after memory fills up,
1156 'malloc' might be invoked reentrantly.
1157
476371c4
PE
1158 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1159 In other words, assume that every image size is allowed, on non-X
1160 hosts. This assumption is probably wrong, but it lets Emacs compile.
1161
f3fcc40d
AS
11622011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1163
1164 * regex.c (re_iswctype): Convert return values to boolean.
1165
350c992f
EZ
11662011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1167
1168 * xdisp.c (compute_display_string_pos): Don't use cached display
1169 string position if the buffer had its restriction changed.
1170 (Bug#9184)
1171
5266b4bb
PE
11722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1173
1174 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1175
2573a837 11762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1177
41f55ccd 1178 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1179
39e378da
PE
1180 * bidi.c: Integer size and overflow fixes.
1181 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1182 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1183 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1184 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1185 (bidi_find_other_level_edge):
1186 Use ptrdiff_t instead of EMACS_INT where either will do.
1187 This works better on 32-bit hosts configured --with-wide-int.
1188 (bidi_cache_ensure_space): Check for size-calculation overflow.
1189 Use % rather than repeated addition, for better worst-case speed.
1190 Don't set bidi_cache_size until after xrealloc returns, because it
1191 might not return.
1192 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1193 (bidi_cache_ensure_space): Also check that the bidi cache size
1194 does not exceed that of the largest Lisp string or buffer. See Eli
1195 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1196
5e927815
PE
1197 * alloc.c (__malloc_size_t): Remove.
1198 All uses replaced by size_t. See Andreas Schwab's note
1199 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1200
ca4aa935
PE
1201 * image.c: Improve checking for integer overflow.
1202 (check_image_size): Assume that f is nonnull, since
1203 it is always nonnull in practice. This is one less thing to
1204 worry about when checking for integer overflow later.
1205 (x_check_image_size): New function, which checks for integer
1206 overflow issues inside X.
1207 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1208 This removes the need for a memory_full check.
1209 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1210 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1211 (xbm_read_bitmap_data): Change locals back to 'int', since
1212 their values must fit in 'int'.
1213 (xpm_load_image, png_load, tiff_load):
1214 Invoke x_create_x_image_and_pixmap earlier,
1215 to avoid much needless work if the image is too large.
1216 (tiff_load): Treat overly large images as if
1217 x_create_x_image_and_pixmap failed, not as malloc failures.
1218 (gs_load): Use x_check_image_size.
1219
5f8f9cc2
PE
1220 * gtkutil.c: Omit integer casts.
1221 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1222 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1223
5adf60bc
PE
1224 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1225
c8907a93
PE
1226 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1227 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1228 would wrongly return t on a 64-bit host.
1229
e3c25c68
PE
1230 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1231 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1232 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1233 and therefore cause GCC to emit a bogus diagnostic in some cases.
1234
3f791afe
PE
1235 * image.c: Integer signedness and overflow and related fixes.
1236 This is not an exhaustive set of fixes, but it's time to
1237 record what I've got.
1238 (lookup_pixel_color, check_image_size): Remove redundant decls.
1239 (check_image_size): Don't assume that arbitrary EMACS_INT values
1240 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1241 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1242 (tiff_load, imagemagick_load_image):
1243 Check for overflow in size calculations.
1244 (x_create_x_image_and_pixmap): Remove unnecessary test for
1245 xmalloc returning NULL; that can't happen.
1246 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1247 (xpm_color_bucket): Use better integer hashing function.
1248 (xpm_cache_color): Don't possibly over-allocate memory.
1249 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1250 (gif_memory_source):
1251 Use ptrdiff_t, not int or size_t, to record sizes.
1252 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1253 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1254 either works, as we prefer signed integers.
1255 (tiff_read_from_memory, tiff_write_from_memory):
1256 Return tsize_t, not size_t, since that's what the TIFF API wants.
1257 (tiff_read_from_memory): Don't fail simply because the read would
1258 go past EOF; instead, return a short read.
1259 (tiff_load): Omit no-longer-needed casts.
1260 (Fimagemagick_types): Don't assume size fits into 'int'.
1261
3cc5a532
PE
1262 Improve hashing quality when configured --with-wide-int.
1263 * fns.c (hash_string): New function, taken from sxhash_string.
1264 Do not discard information about ASCII character case; this
1265 discarding is no longer needed.
1266 (sxhash-string): Use it. Change sig to match it. Caller changed.
1267 * lisp.h: Declare it.
1268 * lread.c (hash_string): Remove, since we now use fns.c's version.
1269 The fns.c version returns a wider integer if --with-wide-int is
1270 specified, so this should help the quality of the hashing a bit.
1271
b312a492
PE
1272 * emacs.c: Integer overflow minor fix.
1273 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1274 Define only if GNU_LINUX.
1275 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1276
dfd153ae
PE
1277 * dispnew.c: Integer signedness and overflow fixes.
1278 Remove unnecessary forward decls, that were a maintenance hassle.
1279 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1280 All uses changed.
1281 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1282 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1283 (prepare_desired_row, line_draw_cost):
1284 Use int, not unsigned, where either works.
1285 (save_current_matrix, restore_current_matrix):
1286 Use ptrdiff_t, not size_t, where either works.
1287 (init_display): Check for overflow more accurately, and without
1288 relying on undefined behavior.
1289
a81d11a3
PE
1290 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1291 Remove, replacing with the new symbols in lisp.h. All uses changed.
1292 * fileio.c (make_temp_name):
1293 * filelock.c (lock_file_1, lock_file):
1294 * xdisp.c (message_dolog):
1295 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1296 Use pMd etc. instead.
1297 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1298 replacing the pWIDE etc. symbols removed from editfns.c.
1299
3300e6fd
PE
1300 * keyboard.h (num_input_events): Now uintmax_t.
1301 This is (very slightly) less likely to mess up due to wraparound.
1302 All uses changed.
1303
fd05c7e9
PE
1304 * buffer.c: Integer signedness fixes.
1305 (alloc_buffer_text, enlarge_buffer_text):
1306 Use ptrdiff_t rather than size_t when either will do, as we prefer
1307 signed integers.
1308
903fe15d
PE
1309 * alloc.c: Integer signedness and overflow fixes.
1310 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1311 (__malloc_size_t): Default to size_t, not to int.
1312 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1313 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1314 Prefer ptrdiff_t to size_t when either would do, as we prefer
1315 signed integers.
1316 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1317 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1318 Now const. Initialize with values that are in range even if char
1319 is signed.
1320 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1321 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1322 These functions do the right thing with sizes > 2**32.
1323 (check_depth): Now ptrdiff_t, not int.
1324 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1325 Adjust to new way of storing sizes. Check for size overflow bugs
1326 in rest of code.
1327 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1328 slightly wrong anyway, as it missed one instance of
1329 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1330 (refill_memory_reserve): Omit needless cast to size_t.
1331 (mark_object_loop_halt): Mark as externally visible.
1332
ac82cc6a
PE
1333 * xselect.c: Integer signedness and overflow fixes.
1334 (Fx_register_dnd_atom, x_handle_dnd_message):
1335 Use ptrdiff_t, not size_t, since we prefer signed.
1336 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1337 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1338 x_dnd_atoms_size and x_dnd_atoms_length.
1339
c2d1e36d
PE
1340 * doprnt.c: Prefer signed to unsigned when either works.
1341 * eval.c (verror):
1342 * doprnt.c (doprnt):
1343 * lisp.h (doprnt):
1344 * xdisp.c (vmessage):
1345 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1346 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1347 prefer signed arithmetic to avoid comparison confusion.
1348 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1349 but is a bit tricky.
1350
0e926e56
PE
1351 Assume freestanding C89 headers, string.h, stdlib.h.
1352 * data.c, doprnt.c, floatfns.c, print.c:
1353 Include float.h unconditionally.
1354 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1355 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1356 * regex.c: Likewise for stddef.h, string.h.
1357 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1358 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1359 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1360 (STDC_HEADERS): Remove obsolete defines.
1361 * sysdep.c: Include limits.h unconditionally.
1362
9cfdb3ec
PE
1363 Assume support for memcmp, memcpy, memmove, memset.
1364 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1365 * regex.c (memcmp, memcpy):
1366 Remove; we assume C89 now.
1367
1368 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1369 (__malloc_safe_bcopy): Remove; no longer needed.
1370
cf950e6b 1371 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1372 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1373 well either way, and we prefer signed to unsigned.
1374
dbf38e02
LMI
13752011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1376
1377 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1378 closes the connection while we're reading (bug#9182).
1379
d6f0886c 13802011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1381
d6f0886c
JD
1382 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1383 are specified (Bug#9168).
24e0f6b1 1384
2eb1f9e6
PE
13852011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1388 Found by GCC static checking and --with-wide-int on a 32-bit host.
1389
22381272 13902011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1391
1392 * xdisp.c (compute_display_string_pos): Fix logic of caching
1393 previous display string position. Initialize cached_prev_pos to
1394 -1. Fixes slow-down at the beginning of a buffer.
1395
f25e39b4
EZ
13962011-07-24 Eli Zaretskii <eliz@gnu.org>
1397
1398 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1399 for attrs[LFACE_FONTSET_INDEX].
1400
04c4b52e
PE
14012011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * xml.c (parse_region): Remove unused local
1404 that was recently introduced.
1405
c1734fbd
EZ
14062011-07-23 Eli Zaretskii <eliz@gnu.org>
1407
be18c5a5
EZ
1408 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1409 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1410
c1734fbd
EZ
1411 * xdisp.c (move_it_in_display_line_to): Record the best matching
1412 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1413 exit if none of the characters scanned was an exact match.
1414 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1415 when exact match is impossible due to invisible text, and the
1416 lines are truncated.
1417
a258d627
JD
14182011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1419
1420 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1421 for OSX >= 10.7.
1422
b6d5a689
EZ
14232011-07-22 Eli Zaretskii <eliz@gnu.org>
1424
0f74f785
EZ
1425 Fix a significant slow-down of cursor motion with C-n, C-p,
1426 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1427 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1428 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1429 (next_element_from_buffer): Call compute_stop_pos_backwards to
1430 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1431 base_level_stop.
1432 (reseat): Don't look for prev_stop, as that could mean a very long
1433 run.
1434 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1435 <cached_disp_overlay_modiff>: Cache for last found display string
1436 position.
551918c1 1437 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1438 about the same buffer in the same area of character positions, and
1439 the buffer wasn't changed since the time the display string
1440 position was cached.
551918c1 1441
b2d0c91a
EZ
14422011-07-22 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1445 is an integer, which is important for empty lines. (Bug#9149)
1446
043604ee
CY
14472011-07-22 Chong Yidong <cyd@stupidchicken.com>
1448
1449 * frame.c (Fmodify_frame_parameters): In tty case, update the
1450 default face if necessary (Bug#4238).
1451
da4adb04
CY
14522011-07-21 Chong Yidong <cyd@stupidchicken.com>
1453
1454 * editfns.c (Fstring_to_char): No need to explain what a character
1455 is in the docstring (Bug#6576).
1456
9abd0532
LMI
14572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1458
1459 * xml.c (parse_region): Make sure we always return a tree.
1460
36881d16
HK
14612011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1462
1463 * xml.c (parse_region): If a document contains only comments,
1464 return that, too.
1465
1e98674d
LMI
14662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1467
1468 * xml.c (make_dom): Return comments, too.
1469
590bd467
PE
14702011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 Port to OpenBSD.
1473 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1474 and the surrounding thread.
1475 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1476 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1477 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1478 timer goes off.
1479 * s/openbsd.h (BROKEN_SIGIO): Define.
1480 * unexelf.c (unexec) [__OpenBSD__]:
1481 Don't update the .mdebug section of the Alpha COFF symbol table.
1482
f41628b2
LMI
14832011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1484
1485 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1486 (bug#8460).
1487
b59b67c5
PE
14882011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1489
15e3a074
PE
1490 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1491 This fixes some race conditions on the permissions of any newly
1492 created file.
1493
41bed37d
PE
1494 * alloc.c (valid_pointer_p): Use pipe, not open.
1495 This fixes some permissions issues when debugging.
1496
b59b67c5
PE
1497 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1498 If fchown fails to set both uid and gid, try to set just gid,
1499 as that is sometimes allowed. Adjust the file's mode to eliminate
1500 setuid or setgid bits that are inappropriate if fchown fails.
1501
925a6be7
SM
15022011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1503
1504 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1505 to compare Lisp_Objects.
1506 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1507 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1508 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1509
52968808
AS
15102011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1511
0a6a104b
AS
1512 * lread.c (read_integer): Unread even EOF character.
1513 (read1): Likewise. Properly record start position of symbol.
1514
52968808
AS
1515 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1516 symbol character follows.
1517
9e381cdd
PE
15182011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1521 This works around a problem with the previous change to Fcopy_file.
1522 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1523 and without this change, GCC might complain about discarding
1524 fchown's return value.
1525
b5641435
JB
15262011-07-16 Juanma Barranquero <lekktu@gmail.com>
1527
1528 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1529
a8031457
PE
15302011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1531
1532 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1533
dd889327
LMI
15342011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1535
750c33f7
LMI
1536 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1537 it's used from the C level.
1538
dd889327
LMI
1539 * process.c: Use the same condition for POLL_FOR_INPUT in both
1540 keyboard.c and process.c (bug#1858).
1541
87e86684
LM
15422011-07-09 Lawrence Mitchell <wence@gmx.li>
1543
1544 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1545 (Fgnutls_boot): Use it.
1546
64348f40
AS
15472011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1548
1549 * doc.c (Fsubstitute_command_keys): Revert last change.
1550
1d698799
LMI
15512011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1552
f863868c
LMI
1553 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1554 quotes the next character, and doesn't affect other longer
1555 sequences (bug#8935).
1556
1d698799
LMI
1557 * lread.c (syms_of_lread): Clarify that is isn't only
1558 `eval-buffer' and `eval-defun' that's affected by
1559 `lexical-binding' (bug#8460).
1560
aa4b6df6
EZ
15612011-07-15 Eli Zaretskii <eliz@gnu.org>
1562
1563 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1564 bidi redisplay when a line includes both an image and is
1565 truncated.
1566
5d856da6
PE
15672011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1568
ad6042bb
PE
1569 Fix minor problems found by static checking.
1570 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1571 (elsz): Now a signed constant, not a size_t var. We prefer signed
1572 types to unsigned, to avoid integer comparison confusion. Without
1573 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1574 "cannot optimize loop, the loop counter may overflow", a symptom
1575 of the confusion.
f00bbb22 1576 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1577 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1578
6468f31c
LMI
15792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1580
49080b10
LMI
1581 * search.c (Fre_search_backward): Mention `case-fold-search' in
1582 all the re_search_* functions (bug#8138).
1583
6468f31c
LMI
1584 * keyboard.c (Fopen_dribble_file): Document when the file is
1585 closed (bug#8056).
1586
c965adc5
EZ
15872011-07-14 Eli Zaretskii <eliz@gnu.org>
1588
df9733bf
EZ
1589 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1590 bidi_cache_idx.
1591
0bb23927
EZ
1592 Support bidi reordering of display and overlay strings.
1593 * xdisp.c (compute_display_string_pos)
1594 (compute_display_string_end): Accept additional argument STRING.
1595 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1596 (reseat_to_string): Initialize bidi_it->string.s and
1597 bidi_it->string.schars.
1598 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1599 NULL (avoids a crash in bidi_paragraph_init).
1600 Initialize itb.string.lstring.
0bb23927
EZ
1601 (init_iterator): Call bidi_init_it only of a valid
1602 buffer position was specified. Initialize paragraph_embedding to
1603 L2R.
1604 (reseat_to_string): Initialize the bidi iterator.
1605 (display_string): If we need to ignore text properties of
1606 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1607 original value of -1 will not work with bidi.)
1608 (compute_display_string_pos): First arg is now struct
1609 `text_pos *'; all callers changed. Support display properties on
1610 Lisp strings.
1611 (compute_display_string_end): Support display properties on Lisp
1612 strings.
1613 (init_iterator, reseat_1, reseat_to_string): Initialize the
1614 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1615 when iterating on a string not from display properties).
640c8776
SM
1616 (compute_display_string_pos, compute_display_string_end):
1617 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1618 arrow keys.
1619 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1620 base_level_stop; instead, set base_level_stop to BEGV.
1621 Fixes crashes in vertical-motion.
0bb23927
EZ
1622 (next_element_from_buffer): Improve commentary for when
1623 the iterator is before prev_stop.
1624 (init_iterator): Initialize bidi_p from the default value of
1625 bidi-display-reordering, not from buffer-local value. Use the
1626 buffer-local value only if initializing for buffer iteration.
1627 (handle_invisible_prop): Support invisible properties on strings
1628 that are being bidi-reordered.
1629 (set_iterator_to_next): Support bidi reordering of C strings and
1630 Lisp strings.
1631 (next_element_from_string): Support bidi reordering of Lisp
1632 strings.
1633 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1634 (display_string): Support display of R2L glyph rows.
1635 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1636 (init_iterator): Don't initialize it->bidi_p for strings
1637 here.
1638 (reseat_to_string): Initialize it->bidi_p for strings here.
1639 (next_element_from_string, next_element_from_c_string)
1640 (next_element_from_buffer): Add xassert's for correspondence
1641 between IT's object being iterated and it->bidi_it.string
1642 structure.
1643 (face_before_or_after_it_pos): Support bidi iteration.
1644 (next_element_from_c_string): Handle the case of the first string
1645 character that is not the first one in the visual order.
1646 (get_visually_first_element): New function, refactored from common
1647 parts of next_element_from_buffer, next_element_from_string, and
1648 next_element_from_c_string.
1649 (tool_bar_lines_needed, redisplay_tool_bar)
1650 (display_menu_bar): Force left-to-right direction. Add a FIXME
1651 comment for making that be controlled by a user option.
1652 (push_it, pop_it): Save and restore the state of the
1653 bidi iterator. Save and restore the bidi_p flag.
1654 (pop_it): Iterate out of display property for string iteration as
1655 well.
1656 (iterate_out_of_display_property): Support iteration over strings.
1657 (handle_single_display_spec): Set up it->bidi_it for iteration
1658 over a display string, and call bidi_init_it.
1659 (handle_single_display_spec, next_overlay_string)
1660 (get_overlay_strings_1, push_display_prop): Set up the bidi
1661 iterator for displaying display or overlay strings.
1662 (forward_to_next_line_start): Don't use the shortcut if
1663 bidi-iterating.
1664 (back_to_previous_visible_line_start): If handle_display_prop
1665 pushed the iterator stack, restore the internal state of the bidi
1666 iterator by calling bidi_pop_it same number of times.
1667 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1668 and we are bidi-iterating, don't decrement the iterator position;
1669 instead, set the first_elt flag in the bidi iterator, to produce
1670 the same effect.
1671 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1672 (push_display_prop): xassert that we are iterating a buffer.
1673 (push_it, pop_it): Save and restore paragraph_embedding member.
1674 (handle_single_display_spec, next_overlay_string)
1675 (get_overlay_strings_1, reseat_1, reseat_to_string)
1676 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1677 correctly. Don't assume unibyte strings are not bidi-reordered.
1678 (compute_display_string_pos)
1679 (compute_display_string_end): Fix handling the case of C string.
1680 (push_it, pop_it): Save and restore from_disp_prop_p.
1681 (handle_single_display_spec, push_display_prop): Set the
1682 from_disp_prop_p flag.
1683 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1684 (pop_it): Call iterate_out_of_display_property only if we are
1685 popping after iteration over a string that came from a display
1686 property. Fix a typo in popping stretch info. Add an assertion
1687 for verifying that the iterator position is in sync with the bidi
1688 iterator.
1689 (handle_single_display_spec, get_overlay_strings_1)
1690 (push_display_prop): Fix initialization of paragraph direction for
1691 string when that of the parent object is not yet determined.
1692 (reseat_1): Call bidi_init_it to resync the bidi
1693 iterator with IT's position. (Bug#7616)
1694 (find_row_edges): If ROW->start.pos gives position
1695 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1696 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1697 Reset the from_disp_prop_p flag.
1698 (SAVE_IT, RESTORE_IT): New macros.
1699 (pos_visible_p, face_before_or_after_it_pos)
1700 (back_to_previous_visible_line_start)
1701 (move_it_in_display_line_to, move_it_in_display_line)
1702 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1703 (try_scrolling, redisplay_window, display_line): Use them when
1704 saving a temporary copy of the iterator and restoring it back.
1705 (back_to_previous_visible_line_start, reseat_1)
1706 (init_iterator): Empty the bidi cache "stack".
1707 (move_it_in_display_line_to): If iterator ended up at
1708 EOL, but we never saw any buffer positions smaller than
1709 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1710 motion in bidi-reordered lines.
1711 (move_it_in_display_line_to): Record prev_method and prev_pos
1712 immediately before the call to set_iterator_to_next. Fixes cursor
1713 motion in bidi-reordered lines with stretch glyphs and strings
1714 displayed in margins. (Bug#8133) (Bug#8867)
1715 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1716 TO_CHARPOS.
640c8776
SM
1717 (pos_visible_p): Support positions in bidi-reordered lines.
1718 Save and restore bidi cache.
0bb23927
EZ
1719
1720 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1721 (bidi_paragraph_info): Delete unused struct.
1722 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1723 (bidi_cache_start): New variable.
1724 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1725 to zero.
1726 (bidi_cache_fetch_state, bidi_cache_search)
1727 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1728 (bidi_cache_find, bidi_peek_at_next_level)
1729 (bidi_level_of_next_char, bidi_find_other_level_edge)
1730 (bidi_move_to_visually_next): Compare cache index with
1731 bidi_cache_start rather than with zero.
1732 (bidi_fetch_char): Accept new argument STRING; all callers
1733 changed. Support iteration over a string. Support strings with
1734 display properties. Support unibyte strings. Fix the type of
1735 `len' according to what STRING_CHAR_AND_LENGTH expects.
1736 (bidi_paragraph_init, bidi_resolve_explicit_1)
1737 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1738 (bidi_level_of_next_char, bidi_move_to_visually_next):
1739 Support iteration over a string.
0bb23927
EZ
1740 (bidi_set_sor_type, bidi_resolve_explicit_1)
1741 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1742 can now be zero (for strings); special values 0 and -1 were
1743 changed to -1 and -2, respectively.
1744 (bidi_char_at_pos): New function.
1745 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1746 Call it instead of FETCH_MULTIBYTE_CHAR.
1747 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1748 initialized to valid values.
1749 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1750 values.
1751 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1752 the test for valid cached positions. Fix the logic for looking up
1753 the sentinel state in the cache. GCPRO the Lisp string we are
1754 iterating.
1755 (bidi_push_it, bidi_pop_it): New functions.
1756 (bidi_initialize): Initialize the bidi cache start stack pointer.
1757 (bidi_cache_ensure_space): New function, refactored from part of
1758 bidi_cache_iterator_state. Don't assume the required size is just
1759 one BIDI_CACHE_CHUNK away.
1760 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1761 (bidi_count_bytes, bidi_char_at_pos): New functions.
1762 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1763 always valid if bidi_cache_idx is valid.
1764 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1765 is valid if it's going to be used.
1766 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1767 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1768 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1769 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1770 (bidi_find_other_level_edge, bidi_cache_start_stack):
1771 All variables related to cache indices are now EMACS_INT.
c965adc5 1772
0bb23927
EZ
1773 * dispextern.h (struct bidi_string_data): New structure.
1774 (struct bidi_it): New member `string'. Make flag members be 1-bit
1775 fields, and put them last in the struct.
640c8776
SM
1776 (compute_display_string_pos, compute_display_string_end):
1777 Update prototypes.
0bb23927
EZ
1778 (bidi_push_it, bidi_pop_it): Add prototypes.
1779 (struct iterator_stack_entry): New members bidi_p,
1780 paragraph_embedding, and from_disp_prop_p.
1781 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1782 (bidi_shelve_cache, bidi_unshelve_cache):
1783 Declare prototypes.
0bb23927
EZ
1784
1785 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1786 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1787 and vector-like objects.
1788
1789 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1790 cache around display iteration.
1791
1792 * window.c (Fwindow_end, window_scroll_pixel_based)
1793 (displayed_window_lines, Frecenter): Save and restore the bidi
1794 cache around display iteration.
1795
3bbd2265
LMI
17962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1797
1798 * editfns.c (Fdelete_region): Clarify the use of the named
1799 parameters (bug#6788).
1800
adc47434
MR
18012011-07-14 Martin Rudalics <rudalics@gmx.at>
1802
1803 * indent.c (Fvertical_motion): Set and restore w->pointm when
1804 saving and restoring the window's buffer (Bug#9006).
1805
837c31f8
LMI
18062011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1807
1808 * editfns.c (Fstring_to_char): Clarify just what is returned
1809 (bug#6576). Text by Eli Zaretskii.
1810
ac389d0c
JB
18112011-07-13 Juanma Barranquero <lekktu@gmail.com>
1812
1813 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1814
0be0ce47
EZ
18152011-07-13 Eli Zaretskii <eliz@gnu.org>
1816
1817 * buffer.c (mmap_find): Fix a typo.
1818
cd18e7e3
JB
18192011-07-13 Johan Bockgård <bojohan@gnu.org>
1820
1821 Fix execution of x selection hooks.
1822 * xselect.c (Qx_lost_selection_functions)
1823 (Qx_sent_selection_functions): New vars.
1824 (syms_of_xselect): DEFSYM them.
1825 (x_handle_selection_request): Pass Qx_sent_selection_functions
1826 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1827 (x_handle_selection_clear,x_clear_frame_selections):
1828 Pass Qx_lost_selection_functions rather than
1829 Vx_lost_selection_functions to Frun_hook_with_args.
1830
47ea7f44
PE
18312011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1832
ac389d0c 1833 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1834 The old code sometimes used this field without initializing it.
1835
47ea7f44
PE
1836 * alloc.c (gc_sweep): Don't read past end of array.
1837 In theory, the old code could also have corrupted Emacs internals,
1838 though it'd be very unlikely.
1839
bc985c87
AS
18402011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1841
1842 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1843 argument. (Bug#4026)
bc985c87 1844
0cf34688
LMI
18452011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1846
b3dadd76
LMI
1847 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1848 key" (bug#4257).
1849
0cf34688
LMI
1850 * window.c (Fset_window_start): Doc fix (bug#4199).
1851 (Fset_window_hscroll): Ditto.
1852
270768cd
PE
18532011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1854
077e3dda 1855 Fix minor new problems caught by GCC 4.6.1.
270768cd 1856 * term.c (init_tty): Remove unused local.
490011a6 1857 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1858 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1859 not used otherwise.
270768cd 1860
b1f58454
CY
18612011-07-12 Chong Yidong <cyd@stupidchicken.com>
1862
1863 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1864
22b9578d
LMI
18652011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1866
6e70ab07
LMI
1867 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1868 are the mini-buffer and the echo area (bug#3320).
1869
22b9578d
LMI
1870 * term.c (init_tty): Remove support for supdup, c10 and perq
1871 terminals, which are no longer supported (bug#1482).
1872
8974cc9f
JB
18732011-07-10 Johan Bockgård <bojohan@gnu.org>
1874
1875 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1876
a560d974
JD
18772011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1878
1879 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1880 for non-popups (Bug#3642).
1881
1dae0f0a
AS
18822011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1883
268c2c36 1884 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1885 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1886 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1887 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1888 * data.c (fmod): Likewise.
1889 * dispnew.c (swap_glyphs_in_rows): Likewise.
1890 * emacs.c (memory_warning_signal): Likewise.
1891 * floatfns.c (float_error): Likewise.
1892 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1893 (otf_open, font_otf_capability, generate_otf_features)
1894 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1895 Likewise.
1896 * image.c (pbm_read_file): Likewise.
1897 * indent.c (string_display_width): Likewise.
1898 * intervals.c (check_for_interval, search_for_interval)
1899 (inc_interval_count, count_intervals, root_interval)
1900 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1901 * lread.c (defalias): Likewise.
268c2c36 1902 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1903 * regex.c (set_image_of_range_1, set_image_of_range)
1904 (regex_grow_registers): Likewise.
1905 * sysdep.c (strerror): Likewise.
1906 * termcap.c (valid_filename_p, tprint, main): Likewise.
1907 * tparam.c (main): Likewise.
1908 * unexhp9k800.c (run_time_remap, save_data_space)
1909 (update_file_ptrs, read_header, write_header, calculate_checksum)
1910 (copy_file, copy_rest, display_header): Likewise.
1911 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1912 Likewise.
1913 * xdisp.c (check_it): Likewise.
1914 * xfaces.c (register_color, unregister_color, unregister_colors):
1915 Likewise.
1916 * xfns.c (print_fontset_result): Likewise.
1917 * xrdb.c (member, fatal, main): Likewise.
1918
99033785
PE
19192011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 Fix minor problems found by static checking (Bug#9031).
1922 * chartab.c (char_table_set_range, map_sub_char_table):
1923 Remove unused locals.
1924 (uniprop_table): Now static.
1925 * composite.c (_work_char): Remove unused static var.
1926
9cb2ac56
JB
19272011-07-09 Juanma Barranquero <lekktu@gmail.com>
1928
1929 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1930
f25661f0
JD
19312011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1932
1933 * gtkutil.c (qttip_cb): Remove code without function.
1934
8278c4fe
EZ
19352011-07-09 Eli Zaretskii <eliz@gnu.org>
1936
1937 * w32.c (pthread_sigmask): New stub.
1938
1692ae2d 19392011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1940
8a6ebd58 1941 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1942 sigprocmask is portable only for single-threaded applications, and
1943 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1944 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1945 (LIBES): Use it.
1946 * callproc.c (Fcall_process):
1947 * process.c (create_process):
1948 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1949 Use pthread_sigmask, not sigprocmask.
123403e4 1950
1b854618
JD
19512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1952
1953 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1954 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1955 wrong (Bug#8591).
1956
3fe4b549
JD
19572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1958
0ce7e563
JD
1959 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1960 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1961 (xg_hide_tooltip): Fix comment.
1962
3fe4b549
JD
1963 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1964 in registerServicesMenuSendTypes.
1965 (validRequestorForSendType): Don't check ns_return_types.
1966
1967 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1968 ns_return_type.
1969
5df75e47
JR
19702011-07-08 Jason Rumney <jasonr@gnu.org>
1971
1972 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1973 frame struct members of non-existent frames (Bug#6284).
1974
699c10bd
JD
19752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1976
4393663b
JD
1977 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1978 variable firstTime not needed on OSX >= 10.6.
1979 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1980 >= 10.5. Use setKnobProportion, setDoubleValue.
1981
1982 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1983 (MAC_OS_X_VERSION_10_5): Define if not defined.
1984 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1985 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1986 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1987
1988 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1989 cString and lossyCString on OSX >= 10.4
1990
1991 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1992 sizeToFit on OSX >= 10.2.
1993
1994 * nsimage.m (allocInitFromFile): Don't use deprecated method
1995 bestRepresentationForDevice on OSX >= 10.6.
1996
1997 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1998 to avoid warning.
1999
2000 * emacs.c: Declare unexec_init_emacs_zone.
2001
a63e0781
JD
2002 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2003
699c10bd
JD
2004 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2005
2006 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2007 on svcsMenu (Bug#8842).
2008
2009 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2010 ns_return_types.
2011 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2012
2013 * nsterm.m (QUTF8_STRING): Declare.
2014 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2015 (validRequestorForSendType): Return type is (id).
2016 Change indexOfObjectIdenticalTo to indexOfObject.
2017 Check if we have local selection before returning self (Bug#8842).
2018 (writeSelectionToPasteboard): Put local selection into paste board
2019 if we have a local selection (Bug#8842).
2020 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2021
2022 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2023 (ns_get_local_selection): Declare.
2024
54e10184
LMI
20252011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2026
9888ff71
LMI
2027 * keymap.c (describe_map_tree): Don't insert a double newline at
2028 the end of the buffer (bug#1169) and return whether we inserted
2029 something.
2030
54e10184
LMI
2031 * callint.c (Fcall_interactively): Change "reading args" to
2032 "providing args" to try to clarify what it does (bug#1010).
2033
15fa4783
KH
20342011-07-07 Kenichi Handa <handa@m17n.org>
2035
2036 * composite.c (composition_compute_stop_pos): Ignore a static
2037 composition starting before CHARPOS (Bug#8915).
2038
2039 * xdisp.c (handle_composition_prop): Likewise.
2040
a8815b00
EZ
20412011-07-07 Eli Zaretskii <eliz@gnu.org>
2042
2043 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2044 (Bug#9015)
2045
ef7b981d 20462011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2047
2048 * character.h (unicode_category_t): New enum type.
2049
2050 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2051 (Qchar_code_property_table): New variable.
2052 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2053 (UNIPROP_COMPRESSED_FORM_P): New macros.
2054 (char_table_ascii): Uncompress the compressed values.
2055 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2056 Uncompress the compressed values.
ac389d0c 2057 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2058 (char_table_ref_and_range): Uncompress the compressed values.
2059 (sub_char_table_set): New arg is_uniprop. Callers changed.
2060 Uncompress the compressed values.
2061 (sub_char_table_set_range): Args changed. Callers changed.
2062 (char_table_set_range): Adjuted for the above change.
2063 (map_sub_char_table): Delete args default_val and parent. Add arg
2064 top. Give decoded values to a Lisp function.
640c8776 2065 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2066 values to a Lisp function. Gcpro more variables.
2067 (uniprop_table_uncompress)
2068 (uniprop_decode_value_run_length): New functions.
2069 (uniprop_decoder, uniprop_decoder_count): New variables.
2070 (uniprop_get_decoder, uniprop_encode_value_character)
2071 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2072 New functions.
2073 (uniprop_encoder, uniprop_encoder_count): New variables.
2074 (uniprop_get_encoder, uniprop_table)
2075 (Funicode_property_table_internal, Fget_unicode_property_internal)
2076 (Fput_unicode_property_internal): New functions.
2077 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2078 Sunicode_property_table_internal, Sget_unicode_property_internal,
2079 and Sput_unicode_property_internal. Defvar_lisp
2080 char-code-property-alist.
2081
640c8776 2082 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2083 Vunicode_category_table.
2084
640c8776 2085 * font.c (font_range): Adjust for the change of
c805dec0
KH
2086 Vunicode_category_table.
2087
76b397fb
DN
20882011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2089
2090 * m/iris4d.h: Remove file, move contents ...
2091 * s/irix6-5.h: ... here.
2092
22b4128e
PE
20932011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2094
2095 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2096 * alloc.c (mark_buffer):
2097 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2098 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2099 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2100 This isn't true in general, and it's particularly not true
2101 if Emacs is configured with --with-wide-int.
2102 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2103 New macros, used in the buffer.c change.
2104
869795d6
JD
21052011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * xsettings.c: Use both GConf and GSettings if both are available.
2108 (store_config_changed_event): Add comment.
2109 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2110 (store_tool_bar_style_changed): New functions.
2111 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2112 (struct xsettings): Move font inside HAVE_XFT.
2113 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2114 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2115 Move inside HAVE_XFT.
640c8776 2116 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2117 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2118 also.
2119 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
2120 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2121 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2122 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2123 (parse_settings): Move check for font inside HAVE_XFT.
2124 (read_settings, apply_xft_settings): Add comment.
2125 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2126 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2127 call store_font_name_changed.
2128 (xft_settings_event): Add comment.
2129 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2130 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2131 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2132 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2133 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2134 (xsettings_get_system_font, xsettings_get_system_normal_font):
2135 Add comment.
869795d6 2136
d8ed26bd
PE
21372011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 Random fixes. E.g., (random) never returned negative values.
2140 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2141 subseconds part to the entropy, as that's a bit more random.
2142 Prefer signed to unsigned, since the signedness doesn't matter and
2143 in general we prefer signed. When given a limit, use a
2144 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2145 latter isn't right if USE_2_TAGS_FOR_INTS.
2146 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2147 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2148
cabf1cac
SM
21492011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2150
2151 * textprop.c (text_property_stickiness):
2152 Obey Vtext_property_default_nonsticky.
2153 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2154 * w32fns.c (syms_of_w32fns):
2155 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2156
6e9b2be9
PE
21572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2158
2159 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2160 This is more efficient than Ffile_directory_p and avoids a minor race.
2161
90186c68
LMI
21622011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2163
7c301272
LMI
2164 * buffer.c (Foverlay_put): Say what the return value is
2165 (bug#7835).
2166
c4f2d8d4
LMI
2167 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2168 is a directory before asking whether to use the file name
2169 (bug#7564).
ad637907
LMI
2170 (barf_or_query_if_file_exists): Make the "File is a directory"
2171 error be more correct.
c4f2d8d4 2172
90186c68
LMI
2173 * fns.c (Frequire): Remove the mention of the .gz files, since
2174 that's installation-specific, but keep the mention of
2175 `get-load-suffixes'.
2176
da64016e
PE
21772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2180 Report string overflow if the output is too long.
2181
7d47b580
JB
21822011-07-04 Juanma Barranquero <lekktu@gmail.com>
2183
a555cb87
JB
2184 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2185 (syms_of_gnutls): Remove duplicate DEFSYM for
2186 Qgnutls_bootprop_verify_hostname_error, an error for
2187 Qgnutls_bootprop_verify_error (which is no longer used).
2188
7d47b580
JB
2189 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2190 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2191 Also (re)move comments that are misplaced or no longer relevant.
2192
1e49bfab
LMI
21932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2194
2195 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2196
1485f4c0
CY
21972011-07-03 Chong Yidong <cyd@stupidchicken.com>
2198
2199 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2200 and background color parameters if they have been changed.
2201
a9ab721e
LMI
22022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2203
2204 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2205
cf7cff57
PE
22062011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2207
2e13213d
PE
2208 * xsettings.c (SYSTEM_FONT): Define only when used.
2209 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2210
cf7cff57
PE
2211 * keymap.c (access_keymap_1): Now static.
2212
7a8e04f7
CY
22132011-07-02 Chong Yidong <cyd@stupidchicken.com>
2214
2215 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2216 leave any prefix arg for the up event (Bug#1586).
2217
61352f62
LMI
22182011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2219
69bb1ef7
LMI
2220 * lread.c (syms_of_lread): Mention single symbols defined by
2221 `defvar' or `defconst' (bug#7154).
2222
61352f62 2223 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2224 (Frequire): Mention get-load-suffixes.
61352f62 2225
28545e04
MR
22262011-07-02 Martin Rudalics <rudalics@gmx.at>
2227
2228 * window.h (window): Remove clone_number slot.
2229 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2230 Remove.
2231 (make_parent_window, make_window, saved_window)
2232 (Fset_window_configuration, save_window_save): Don't deal with
2233 clone numbers.
2234 * buffer.c (Qclone_number): Remove declaration.
2235 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2236
3349e122
SM
22372011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2238
2239 Add multiple inheritance to keymaps.
2240 * keymap.c (Fmake_composed_keymap): New function.
2241 (Fset_keymap_parent): Simplify.
2242 (fix_submap_inheritance): Remove.
2243 (access_keymap_1): New function extracted from access_keymap to handle
2244 embedded parents and handle lists of maps.
2245 (access_keymap): Use it.
2246 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2247 (Fcopy_keymap): Handle embedded parents.
2248 (Fcommand_remapping, define_as_prefix): Simplify.
2249 (Fkey_binding): Simplify.
2250 (syms_of_keymap): Move minibuffer-local-completion-map,
2251 minibuffer-local-filename-completion-map,
2252 minibuffer-local-must-match-map, and
2253 minibuffer-local-filename-must-match-map to Elisp.
2254 (syms_of_keymap): Defsubr make-composed-keymap.
2255 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2256 (parse_menu_item): Trivial simplification.
2257
3279eb87
GM
22582011-07-01 Glenn Morris <rgm@gnu.org>
2259
2260 * Makefile.in (SETTINGS_LIBS): Fix typo.
2261
4550efdf
KI
22622011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2263
2264 * coding.c (Fencode_coding_string): Record the last coding system
2265 used, as the function doc string says (bug#8738).
2266
0949d2b6
JD
22672011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2268
2269 * xsettings.c (store_monospaced_changed): Take new font as arg and
2270 check for change against current_mono_font.
2271 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2272 (emacs_settings_constructor, emacs_settings_get_property)
2273 (emacs_settings_set_property, emacs_settings_class_init)
2274 (emacs_settings_init, gsettings_obj): Remove.
2275 (something_changedCB): New function for HAVE_GSETTINGS.
2276 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2277 with value as argument.
2278 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2279 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2280 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2281 "changed".
2282
2283 * xgselect.c: Add defined (HAVE_GSETTINGS).
2284 (xgselect_initialize): Ditto.
2285
2286 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2287 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2288 xg_select.
2289
bbc6b304
PE
22902011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2291
2292 * eval.c (struct backtrace): Simplify and port the data structure.
2293 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2294 signed bit field, as this assumption is not portable and it makes
2295 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2296 "char debug_on_exit : 1" as this is not portable either; instead,
2297 use the portable "unsigned int debug_on_exit : 1". Remove unused
2298 member evalargs. Remove obsolete comments about cc bombing out.
2299
9851bfc5
JD
23002011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2301
51bb811f 2302 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2303 Let HAVE_GSETTINGS override HAVE_GCONF.
2304 (store_monospaced_changed): New function.
2305 (EMACS_SETTINGS): A new type derived from GObject to handle
2306 GSettings notifications.
2307 (emacs_settings_constructor, emacs_settings_get_property)
2308 (emacs_settings_set_property, emacs_settings_class_init):
2309 New functions.
2310 (gsettings_client, gsettings_obj): New variables.
2311 (GSETTINGS_SCHEMA): New define.
2312 (something_changedCB): Call store_monospaced_changed.
2313 (init_gsettings): New function.
2314 (xsettings_initialize): Call init_gsettings.
2315 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2316 to NULL.
2317
640c8776 2318 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2319 GCONF_CFLAGS/LIBS.
2320
5386012d
MR
23212011-06-29 Martin Rudalics <rudalics@gmx.at>
2322
2323 * window.c (resize_root_window, grow_mini_window)
2324 (shrink_mini_window): Rename Qresize_root_window to
2325 Qwindow_resize_root_window and Qresize_root_window_vertically to
2326 Qwindow_resize_root_window_vertically.
2327
f13e0b08
PE
23282011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2329
2330 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2331
94515237
JB
23322011-06-27 Juanma Barranquero <lekktu@gmail.com>
2333
2334 * makefile.w32-in: Redesign dependencies so they reflect more
2335 clearly which files are directly included by each source file,
2336 and not through other includes.
2337
e43b6e43
MR
23382011-06-27 Martin Rudalics <rudalics@gmx.at>
2339
2340 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2341 (sort_overlays, overlay_strings): When an overlay's clone number
2342 matches the window's clone number process the overlay even if
2343 the overlay's window property doesn't match the current window.
2344
d68443dc
MR
2345 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2346 (Fwindow_hchild): Rename to Fwindow_left_child.
2347 (Fwindow_next): Rename to Fwindow_next_sibling.
2348 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2349 (resize_window_check): Rename to window_resize_check.
2350 (resize_window_apply): Rename to window_resize_apply.
2351 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2352 (Fdelete_other_windows_internal, resize_frame_windows)
2353 (Fsplit_window_internal, Fdelete_window_internal)
2354 (grow_mini_window, shrink_mini_window)
2355 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2356
c7e73be5
JD
23572011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2358
2359 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2360 (emacs_fixed_set_min_size): Remove.
2361 (emacs_fixed_new): Take frame as argument.
2362
2363 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2364 (_EmacsFixedPrivate): Remove minwidth/height.
2365 Add struct frame *f.
2366 (emacs_fixed_init): Initialize priv->f.
2367 (get_parent_class, emacs_fixed_set_min_size): Remove.
2368 (emacs_fixed_new): Set priv->f to argument.
2369 (emacs_fixed_get_preferred_width)
2370 (emacs_fixed_get_preferred_height): Use min_width/height from
2371 frames size_hint to set minimum and natural (Bug#8919).
2372 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2373 and use min_width/height from frames size_hint to set
2374 min_width/height (Bug#8919).
2375
2376 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2377 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2378 Fix indentation.
c7e73be5 2379
cf99dcf8
EZ
23802011-06-26 Eli Zaretskii <eliz@gnu.org>
2381
2382 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2383 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2384 called at ZV.
2385
029529ac
CY
23862011-06-26 Chong Yidong <cyd@stupidchicken.com>
2387
2388 * process.c (wait_reading_process_output): Bypass select if
2389 waiting for a cell while ignoring keyboard input, and input is
2390 pending. Suggested by Jan Djärv (Bug#8869).
2391
7a7ef429
PE
23922011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 Use gnulib's dup2 module instead of rolling our own.
2395 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2396
11fdef7d 23972011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2398
2399 * dispnew.c (scrolling_window): Before scrolling, turn off a
2400 mouse-highlight in the window being scrolled.
2401
cd3520a4
JB
24022011-06-24 Juanma Barranquero <lekktu@gmail.com>
2403
2404 Move DEFSYM to lisp.h and use everywhere.
2405
2406 * character.h (DEFSYM): Move declaration...
2407 * lisp.h (DEFSYM): ...here.
2408
2409 * gnutls.c:
2410 * minibuf.c:
2411 * w32menu.c:
2412 * w32proc.c:
2413 * w32select.c: Don't include character.h.
2414
2415 * alloc.c (syms_of_alloc):
2416 * buffer.c (syms_of_buffer):
2417 * bytecode.c (syms_of_bytecode):
2418 * callint.c (syms_of_callint):
2419 * casefiddle.c (syms_of_casefiddle):
2420 * casetab.c (init_casetab_once):
2421 * category.c (init_category_once, syms_of_category):
2422 * ccl.c (syms_of_ccl):
2423 * cmds.c (syms_of_cmds):
2424 * composite.c (syms_of_composite):
2425 * dbusbind.c (syms_of_dbusbind):
2426 * dired.c (syms_of_dired):
2427 * dispnew.c (syms_of_display):
2428 * doc.c (syms_of_doc):
2429 * editfns.c (syms_of_editfns):
2430 * emacs.c (syms_of_emacs):
2431 * eval.c (syms_of_eval):
2432 * fileio.c (syms_of_fileio):
2433 * fns.c (syms_of_fns):
2434 * frame.c (syms_of_frame):
2435 * fringe.c (syms_of_fringe):
2436 * insdel.c (syms_of_insdel):
2437 * keymap.c (syms_of_keymap):
2438 * lread.c (init_obarray, syms_of_lread):
2439 * macros.c (syms_of_macros):
2440 * msdos.c (syms_of_msdos):
2441 * print.c (syms_of_print):
2442 * process.c (syms_of_process):
2443 * search.c (syms_of_search):
2444 * sound.c (syms_of_sound):
2445 * syntax.c (init_syntax_once, syms_of_syntax):
2446 * terminal.c (syms_of_terminal):
2447 * textprop.c (syms_of_textprop):
2448 * undo.c (syms_of_undo):
2449 * w32.c (globals_of_w32):
2450 * window.c (syms_of_window):
2451 * xdisp.c (syms_of_xdisp):
2452 * xfaces.c (syms_of_xfaces):
2453 * xfns.c (syms_of_xfns):
2454 * xmenu.c (syms_of_xmenu):
2455 * xsettings.c (syms_of_xsettings):
2456 * xterm.c (syms_of_xterm): Use DEFSYM.
2457
4228cf16
TZ
24582011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2459
cd3520a4 2460 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2461
7fcccf1e
PE
24622011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2463
7efb4e0e
PE
2464 Integer and buffer overflow fixes (Bug#8873).
2465
ff5844ad
PE
2466 * print.c (printchar, strout): Check for string overflow.
2467 (PRINTPREPARE, printchar, strout):
2468 Don't set size unless allocation succeeds.
2469
90532f02
PE
2470 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2471 for sizes. Check for string overflow more accurately.
2472 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2473
6d84508d
PE
2474 * macros.c: Integer and buffer overflow fixes.
2475 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2476 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2477 Use ptrdiff_t, not int, for sizes.
2478 Don't increment bufsize until after realloc succeeds.
2479 Check for size-calculation overflow.
2480 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2481
437b2cb4
PE
2482 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2483
8b9ac8b4
PE
2484 * lread.c: Integer overflow fixes.
2485 (read_integer): Radix is now EMACS_INT, not int,
2486 to improve quality of diagnostics for out-of-range radices.
2487 Calculate buffer size correctly for out-of-range radices.
2488 (read1): Check for integer overflow in radices, and in
2489 read-circle numbers.
82cb60d3
PE
2490 (read_escape): Avoid int overflow.
2491 (Fload, openp, read_buffer_size, read1)
2492 (substitute_object_recurse, read_vector, read_list, map_obarray):
2493 Use ptrdiff_t, not int, for sizes.
2494 (read1): Use EMACS_INT, not int, for sizes.
20270765 2495 Check for size overflow.
8b9ac8b4 2496
7fcccf1e
PE
2497 * image.c (cache_image): Check for size arithmetic overflow.
2498
bfbbd7e7
PE
2499 * lread.c: Integer overflow issues.
2500 (saved_doc_string_size, saved_doc_string_length)
2501 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2502 Now ptrdiff_t, not int.
2503 (read1): Don't assume doc string length fits in int. Check for
2504 out-of-range doc string lengths.
2505 (read_list): Don't assume file position fits in int.
39019e54 2506 (read_escape): Check for hex character overflow.
bfbbd7e7 2507
4e323265
LL
25082011-06-22 Leo Liu <sdl.web@gmail.com>
2509
2510 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2511 Move to minibuffer.el.
2512
85fece3e
PE
25132011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2514
20b84ce9 2515 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2516 The following patches are for when GLYPH_DEBUG && !XASSERT.
2517 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2518 * dispnew.c (flush_stdout):
2519 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2520 Mark as externally visible.
2521 * dispnew.c (check_window_matrix_pointers): Now static.
2522 * dispnew.c (window_to_frame_vpos):
2523 * xfns.c (unwind_create_frame):
2524 * xterm.c (x_check_font): Remove unused local.
2525 * scroll.c (CHECK_BOUNDS):
2526 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2527 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2528 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2529 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2530 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2531 Now static.
2532 (debug_method_add): Use va_list and vsprintf rather than relying
2533 on undefined behavior with wrong number of arguments.
2534 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2535 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2536 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2537 since we're not interested in debugging glyphs with old libraries.
2538 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2539 GCC 4.6.0's static checking.
2540
0766b489
PE
25412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2542
31fd4b32
PE
2543 Integer overflow and signedness fixes (Bug#8873).
2544 A few related buffer overrun fixes, too.
2545
b79e8648
PE
2546 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2547
0766b489
PE
2548 * dispextern.h (struct face.stipple):
2549 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2550 (x_bitmap_mask, x_allocate_bitmap_record)
2551 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2552 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2553 (x_create_bitmap_from_xpm_data):
2554 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2555 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2556 (.bitmaps_last):
2557 * xfaces.c (load_pixmap):
2558 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2559 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2560 (.bitmaps_last, struct x_output.icon_bitmap):
2561 Use ptrdiff_t, not int, for bitmap indexes.
2562 (x_allocate_bitmap_record): Check for size overflow.
2563 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2564
b081724f
PE
2565 Use ptrdiff_t, not int, for overlay counts.
2566 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2567 * editfns.c (overlays_around, get_pos_property):
2568 * textprop.c (get_char_property_and_overlay):
2569 * xdisp.c (next_overlay_change, note_mouse_highlight):
2570 * xfaces.c (face_at_buffer_position):
21514da7
PE
2571 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2572 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2573 (Fnext_overlay_change, Fprevious_overlay_change)
2574 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2575 Use ptrdiff_t, not int, for sizes.
21514da7 2576 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2577
3de73e5e
PE
2578 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2579
2606c57b
PE
2580 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2581 (x_session_initialize): Do not assume string length fits in int.
2582
aaafe47a
PE
2583 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2584 This is unlikely, but can occur if DPI is outlandish.
2585
2674ddc8 2586 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2587 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2588
28154962
PE
2589 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2590 * xrdb.c (magic_file_p, search_magic_path):
2591 Omit last arg SUFFIX; it was always 0. All callers changed.
2592 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2593
7de51af5
PE
2594 * xfont.c (xfont_match): Avoid need for strlen.
2595
25ed6cc3
PE
2596 * xfns.c: Don't assume strlen fits in int.
2597 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2598
4eab31dd
PE
2599 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2600 not unsigned long, as we prefer signed integers. All callers changed.
2601 Detect integer overflow in repeat count.
2602 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2603 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2604
171e2a58
PE
2605 * termcap.c: Don't assume sizes fit in int and never overflow.
2606 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2607 (gobble_line): Check for size-calculation overflow.
2608
ad39faca 2609 * minibuf.c (Fread_buffer):
6e5bb2dc 2610 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2611 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2612 Don't assume string length fits in int.
2613
52c61c22 2614 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2615 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2616
b5b8c9e5
PE
2617 * font.c: Don't assume string length fits in int.
2618 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2619 Use ptrdiff_t, not int.
ccd6111c
PE
2620 (font_intern_prop): Don't assume string length fits in int.
2621 Don't assume integer property fits in fixnum.
2622 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2623
882f0d81 2624 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2625 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2626 Reformulate so as not to need the command string.
2627 Invoke gzip -cd rather than gunzip, as it's more portable.
2628 (lock_info_type, lock_file_1, lock_file):
2629 Don't assume pid_t and time_t fit in unsigned long.
2630 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2631 (current_lock_owner): Prefer signed type for sizes.
2632 Use memcpy, not strncpy, where memcpy is what is really wanted.
2633 Don't assume (via atoi) that time_t and pid_t fit in int.
2634 Check for time_t and/or pid_t out of range, e.g., via a network share.
2635 Don't alloca where an auto var works fine.
2636
93f4cf88
PE
2637 * fileio.c: Fix some integer overflow issues.
2638 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2639 Don't assume string length fits in int.
2640 (directory_file_name): Don't assume string length fits in long.
2641 (make_temp_name): Don't assume pid fits in int, or that its print
2642 length is less than 20.
2643
f3e92b69
PE
2644 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2645
1bfdaf10
PE
2646 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2647
35016e9a
PE
2648 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2649
3d1e65a1
PE
2650 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2651 We prefer signed integers, even for size calculations.
2652
0b963a93
PE
2653 * emacs.c: Don't assume string length fits in 'int'.
2654 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2655 (main): Don't invoke strlen when not needed.
2656
573f4b54
PE
2657 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2658 (XD_DEBUG_MESSAGE): Don't waste a byte.
2659
989f33ba
PE
2660 * callproc.c (getenv_internal_1, getenv_internal)
2661 (Fgetenv_internal):
965d34eb
PE
2662 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2663
e4d29b33
PE
2664 * lread.c (invalid_syntax): Omit length argument.
2665 All uses changed. This doesn't fix a bug, but it simplifies the
2666 code away from its former Hollerith-constant appearance, and it's
2667 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2668 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2669
eb49b136
PE
2670 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2671 This didn't break anything, but it didn't help either.
2672 It's confusing to put a bogus integer in a place where the actual
2673 value does not matter.
9f62aeb1 2674 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2675 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2676
15375a22
PE
2677 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2678 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2679 implementation.
b61cc01c
PE
2680 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2681 We prefer signed types, and the value cannot exceed the EMACS_INT
2682 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2683 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2684 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2685 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2686
53b2623d
PE
2687 * indent.c (sane_tab_width): New function.
2688 (current_column, scan_for_column, Findent_to, position_indentation)
2689 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2690 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2691
51cab52b 2692 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2693
f2ed8a70
PE
2694 * lisp.h (lint_assume): New macro.
2695 * composite.c (composition_gstring_put_cache):
2696 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2697
abe80cc6
PE
2698 * editfns.c, insdel.c:
2699 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2700
b02c740e
PE
2701 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2702
ebc96716
PE
2703 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2704
b4e50fa0 2705 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2706 Use much-faster test for byte-length change.
311d5d7c 2707 Don't assume string byte-length fits in 'int'.
a4cf38e4 2708 Check that character arg fits in 'int'.
85461888 2709 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2710
c0c1ee9f
PE
2711 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2712
a498d7f4
PE
2713 * fns.c (concat): Catch string overflow earlier.
2714 Do not rely on integer wraparound.
2715
51cab52b
PE
2716 * dispextern.h (struct it.overlay_strings_charpos)
2717 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2718 * xdisp.c (forward_to_next_line_start)
2719 (back_to_previous_visible_line_start)
2720 (reseat_at_next_visible_line_start, next_element_from_buffer):
2721 Don't arbitrarily truncate the value of 'selective' to int.
2722
76031fad
PE
2723 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2724
5eb55db9
PE
2725 * composite.c: Don't truncate sizes to 'int'.
2726 (composition_gstring_p, composition_reseat_it)
2727 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2728 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2729 not EMACS_UINT, for indexes.
5eb55db9 2730
0703a717
PE
2731 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2732
d6202519
PE
2733 * buffer.c: Include <verify.h>.
2734 (struct sortvec.priority, struct sortstr.priority):
8961a454 2735 Now EMACS_INT, not int.
c20998a7 2736 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2737 (struct sortstr.size, record_overlay_string)
2738 (struct sortstrlist.size, struct sortlist.used):
2739 Don't truncate size to int.
2740 (record_overlay_string): Check for size-calculation overflow.
d6202519 2741 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2742
d5a19415
JM
27432011-06-22 Jim Meyering <meyering@redhat.com>
2744
029529ac 2745 Don't leak an XBM-image-sized buffer
d5a19415
JM
2746 * image.c (xbm_load): Free the image buffer after using it.
2747
a9041e6c
PE
27482011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2749
2750 Port to Sun C.
2751 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2752 that Sun C diagnosed.
2753 * fns.c (secure_hash): Fix pointer signedness issue.
2754 * intervals.c (static_offset_intervals): New function.
2755 (offset_intervals): Use it.
2756
7f3f739f
LL
27572011-06-21 Leo Liu <sdl.web@gmail.com>
2758
2759 * deps.mk (fns.o):
2760 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2761 sha512.h.
2762
2763 * fns.c (secure_hash): Rename from crypto_hash_function and change
2764 the first arg to accept symbols.
5b66d427 2765 (Fsecure_hash): New primitive.
7f3f739f
LL
2766 (syms_of_fns): New symbols.
2767
76147d94
DD
27682011-06-20 Deniz Dogan <deniz@dogan.se>
2769
2770 * process.c (Fset_process_buffer): Clarify return value in
2771 docstring.
2772
7d7d0045
CY
27732011-06-18 Chong Yidong <cyd@stupidchicken.com>
2774
2775 * dispnew.c (add_window_display_history): Use BVAR.
2776
2777 * xdisp.c (debug_method_add): Use BVAR.
2778 (check_window_end, dump_glyph_matrix, dump_glyph)
2779 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2780
2781 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2782 Likewise.
2783
2784 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2785 check till after the cache is created in init_frame_faces.
2786
ff2bc410
SM
27872011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2788
2789 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2790
28177add
PE
27912011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2792
dd3482fe
PE
2793 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2794 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2795 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2796
393d71f3 2797 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2798 * fileio.c (Finsert_file_contents):
2799 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2800 Remove the old (too-loose) buffer overflow checks.
2801 They weren't needed, since make_gap checks for buffer overflow.
2802 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2803 The old code merely checked for Emacs fixnum overflow, and relied
2804 on undefined (wraparound) behavior. The new code avoids undefined
2805 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2806
2e6813b0 2807 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2808 Tune. Don't use wider integers than needed. Don't use alloca.
2809 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2810
599a9e4f
PE
2811 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2812
99561444
PE
2813 * insdel.c, lisp.h (buffer_overflow): New function.
2814 (insert_from_buffer_1, replace_range, replace_range_2):
2815 * insdel.c (make_gap_larger):
2816 * editfns.c (Finsert_char):
2817 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2818
28177add
PE
2819 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2820
e69dafad
PE
28212011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2822
a7af7fde 2823 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2824
b1c46f02
PE
2825 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2826 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2827
e69dafad
PE
2828 * fileio.c: Don't assume EMACS_INT fits in off_t.
2829 (emacs_lseek): New static function.
2830 (Finsert_file_contents, Fwrite_region): Use it.
2831 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2832
566684ea
PE
2833 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2834
e6966cd6
PE
2835 * fns.c: Don't overflow int when computing a list length.
2836 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2837 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2838 truncation on 64-bit hosts. Check for QUIT every
2839 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2840 faster and is responsive enough.
2841 (Flength): Report an error instead of overflowing an integer.
2842 (Fsafe_length): Return a float if the value is not representable
2843 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2844 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2845 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2846
dd0b0efb
PE
2847 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2848 (header_size, word_size): New constants.
2849 (allocate_vectorlike): Don't check size overflow here.
2850 (allocate_vector): Check it here instead, since this is the only
2851 caller of allocate_vectorlike that could cause overflow.
2852 Check that the new vector's length is representable as a fixnum.
2853
86fe5cfe
PE
2854 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2855 The previous code was bogus. For example, next_almost_prime (32)
2856 returned 39, which is undesirable as it is a multiple of 3; and
2857 next_almost_prime (24) returned 25, which is a multiple of 5 so
2858 why was the code bothering to check for multiples of 7?
2859
80e88859
PE
2860 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2861
4a2f0ad6
PE
2862 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2863
f66c7cf8
PE
2864 Variadic C functions now count arguments with ptrdiff_t.
2865 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2866 Back then I didn't know that the Emacs coding style prefers signed int.
2867 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2868 were being counted with int, which may truncate counts on 64-bit
2869 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2870 * lisp.h (struct Lisp_Subr.function.aMANY)
2871 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2872 Arg counts are now ptrdiff_t, not size_t.
2873 All variadic functions and their callers changed accordingly.
2874 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2875 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2876 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2877 * callint.c (Fcall_interactively): Check arg count for overflow,
2878 to avoid potential buffer overrun. Use signed char, not 'int',
2879 for 'varies' array, so that we needn't bother to check its size
2880 calculation for overflow.
2881 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2882 * eval.c (apply_lambda):
2883 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2884 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2885 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2886
a1759b76
PE
2887 * callint.c (Fcall_interactively): Don't use index var as event count.
2888
d96be9fc
PE
2889 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2890 * mem-limits.h (SIZE): Remove; no longer used.
2891
a690a978 2892 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2893
578c21e6
PE
2894 Remove unnecessary casts.
2895 * xterm.c (x_term_init):
2896 * xfns.c (x_set_border_pixel):
2897 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2898 These aren't needed now that we assume ANSI C.
2899
96f53c6c
PE
2900 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2901 It's more likely to cause problems (due to unsigned overflow)
2902 than to cure them.
2903
83c77d31
PE
2904 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2905
ee2079f1
PE
2906 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2907
6da65536
PE
2908 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2909
7147c4a4
PE
2910 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2911
193e32d9
PE
2912 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2913
e5533da6
PE
2914 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2915
9910e595
PE
2916 GLYPH_CODE_FACE returns EMACS_INT, not int.
2917 * dispextern.h (merge_faces):
2918 * xfaces.c (merge_faces):
01103c44
PE
2919 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2920 Don't assume EMACS_INT fits in int.
9910e595 2921
2638320e
PE
2922 * character.h (CHAR_VALID_P): Remove unused parameter.
2923 * fontset.c, lisp.h, xdisp.c: All uses changed.
2924
045eb8d9
PE
2925 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2926
c1f134b5
PE
2927 * fns.c (concat): Minor tuning based on overflow analysis.
2928 This doesn't fix any bugs. Use int to hold character, instead
2929 of constantly refetching from Emacs object. Use XFASTINT, not
2930 XINT, for value known to be a character. Don't bother comparing
2931 a single byte to 0400, as it's always less.
2932
395fcb93 2933 * floatfns.c (Fexpt):
327eeec8
PE
2934 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2935
abbd3d23
PE
2936 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2937 for characters.
2938
684a03ef
PE
2939 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2940
0fed43f3
PE
2941 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2942 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2943 incorrectly succeed when S was a string, because 4294967386 was
2944 truncated before it was used.
2945
8fd02eb7
PE
2946 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2947 Otherwise, an out-of-range integer could cause undefined behavior
2948 on a 64-bit host.
2949
f8c86b69
PE
2950 * composite.c: Use int, not EMACS_INT, for characters.
2951 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2952 EMACS_INT, for values that are known to be in character range.
2953 This doesn't fix any bugs but is the usual style inside Emacs and
2954 may generate better code on 32-bit machines.
2955
34206dd2
PE
2956 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2957 This is for reasons similar to the recent CHAR_STRING fix.
2958 * charset.c (Fencode_char): Check that character arg is actually
2959 a character. Pass an int to ENCODE_CHAR.
2960 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2961 wider than 'int', as a compile-time check to prevent future regressions
2962 in this area.
2963
c5958d4c 2964 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2965
2966 Make sure a 64-bit char is never passed to CHAR_STRING.
2967 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2968 by silently ignoring the top 32 bits, allowing some values
2969 that were far too large to be valid characters.
2970 * character.h: Include <verify.h>.
2971 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2972 arguments are no wider than unsigned, as a compile-time check
2973 to prevent future regressions in this area.
2974 * data.c (Faset):
01103c44 2975 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2976 (Fsubst_char_in_region):
2977 * fns.c (concat):
2978 * xdisp.c (decode_mode_spec_coding):
2979 Adjust to CHAR_STRING's new requirement.
2980 * editfns.c (Finsert_char, Fsubst_char_in_region):
2981 * fns.c (concat): Check that character args are actually
2982 characters. Without this test, these functions did the wrong
2983 thing with wildly out-of-range values on 64-bit hosts.
2984
d37ca623
PE
2985 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2986 These casts should not be needed on 32-bit hosts, either.
2987 * keyboard.c (read_char):
2988 * lread.c (Fload): Remove casts to unsigned.
2989
ea204efb
PE
2990 * lisp.h (UNSIGNED_CMP): New macro.
2991 This fixes comparison bugs on 64-bit hosts.
2992 (ASCII_CHAR_P): Use it.
2993 * casefiddle.c (casify_object):
01103c44 2994 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2995 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2996 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2997 * dispextern.h (FACE_FROM_ID):
2998 * keyboard.c (read_char): Use UNSIGNED_CMP.
2999
41cb286c
PE
3000 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3001 not to EMACS_INT, to avoid GCC warning.
3002
4a1b9832
PE
3003 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3004
55daad71
PE
3005 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3006 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3007 isn't needed on 32-bit machines.
8f95c75c 3008
01103c44
PE
3009 * buffer.c (Fgenerate_new_buffer_name):
3010 Use EMACS_INT for count, not int.
0ceccced 3011 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3012
3013 * data.c (Qcompiled_function): Now static.
3014
c6f072e7
PE
3015 * window.c (window_body_lines): Now static.
3016
20ce5912
PE
3017 * image.c (gif_load): Rename local to avoid shadowing.
3018
9c4c5f81
PE
3019 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3020 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3021 * alloc.c (make_save_value): Integer argument is now of type
3022 ptrdiff_t, not int.
3023 (mark_object): Use ptrdiff_t, not int.
3024 * lisp.h (pD): New macro.
3025 * print.c (print_object): Use it.
3026
c0c5c8ae
PE
3027 * alloc.c: Use EMACS_INT, not int, to count objects.
3028 (total_conses, total_markers, total_symbols, total_vector_size)
3029 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3030 (total_free_floats, total_floats, total_free_intervals)
3031 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3032 Now EMACS_INT, not int. All uses changed.
3033 (Fgarbage_collect): Compute overall total using a double, so that
3034 integer overflow is less likely to be a problem. Check for overflow
3035 when converting back to an integer.
5a25e253
PE
3036 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3037 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3038 These were 'int' variables that could overflow on 64-bit hosts;
3039 they were never used, so remove them instead of repairing them.
211a0b2a 3040 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3041 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3042 Previously, this ceilinged at INT_MAX, but that doesn't work on
3043 64-bit machines.
e46bb31a 3044 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3045
c78baabf 3046 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3047 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3048 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3049 when a (possibly-narrower) signed value would do just as well.
3050 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3051
c9d624c6
PE
3052 * alloc.c: Catch some string size overflows that we were missing.
3053 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3054 for convenience in STRING_BYTES_MAX.
3055 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3056 The definition here is exact; the one in lisp.h was approximate.
3057 (allocate_string_data): Check for string overflow. This catches
3058 some instances we weren't catching before. Also, it catches
3059 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3060 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3061 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3062
c9d624c6
PE
3063 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3064 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3065 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3066
353032ce
PE
3067 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3068
2bccce07
PE
3069 * alloc.c (Fmake_string): Check for out-of-range init.
3070
0ac30604
SM
30712011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3072
3073 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3074
c195f2de
JD
30752011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3076
3077 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3078 xg_get_default_scrollbar_width.
3079
3080 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3081 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3082 (style_changed_cb): Call update_theme_scrollbar_width and call
3083 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3084 all frames (Bug#8505).
3085 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3086 Call gtk_window_set_resizable if HAVE_GTK3.
3087 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3088 and height if HAVE_GTK3 (Bug#8505).
3089 (scroll_bar_width_for_theme): New variable.
3090 (update_theme_scrollbar_width): New function.
3091 (xg_get_default_scrollbar_width): Move code to
3092 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3093 (xg_initialize): Call update_theme_scrollbar_width.
3094
3095 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3096
3097 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3098
e10ac9f1
MR
30992011-06-12 Martin Rudalics <rudalics@gmx.at>
3100
3101 * frame.c (make_frame): Call other_buffer_safely instead of
3102 other_buffer.
3103
3104 * window.c (temp_output_buffer_show): Call display_buffer with
3105 second argument Vtemp_buffer_show_specifiers and reset latter
3106 immediately after the call.
3107 (Vtemp_buffer_show_specifiers): New variable.
3108 (auto_window_vscroll_p, next_screen_context_lines)
3109 (Vscroll_preserve_screen_position): Remove leading asterisks from
3110 doc-strings.
3111
2d3c217e 31122011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3113
7b7f97e8 3114 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3115 * buffer.c (Qclone_number): Remove for now, as it's unused.
3116 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3117 (record_buffer): Remove unused local.
3118 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3119 (set_frame_buffer_list): Remove; unused.
3120 * frame.h (other_visible_frames): Remove decl.
3121 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3122 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3123 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3124 if HAVE_GPM.
3125 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3126 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3127 Define only if HAVE_GPM.
3128 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3129 (update_hints_inhibit): Remove; never set. All uses removed.
3130 * widgetprv.h (emacsFrameClassRec): Remove decl.
3131 * window.c (delete_deletable_window): Now returns void, since it
3132 wasn't returning anything.
3133 (compare_window_configurations): Remove unused locals.
3134 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3135 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3136 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3137 the same widths as pointers. This follows up on the 2011-05-06 patch.
3138 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3139 * xterm.h: Likewise.
3140 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3141
1384b89e
JB
31422011-06-12 Juanma Barranquero <lekktu@gmail.com>
3143
3144 * makefile.w32-in: Update dependencies.
3145 (LISP_H): Add lib/intprops.h.
3146
1100a63c
CY
31472011-06-11 Chong Yidong <cyd@stupidchicken.com>
3148
3149 * image.c (gif_load): Add animation frame delay to the metadata.
3150 (syms_of_image): Use DEFSYM. New symbol `delay'.
3151
6198ccd0
MR
31522011-06-11 Martin Rudalics <rudalics@gmx.at>
3153
3154 * window.c (delete_deletable_window): Re-add.
3155 (Fset_window_configuration): Rewrite to handle dead buffers and
3156 consequently deletable windows.
3157 (window_tree, Fwindow_tree): Remove. Supply functionality in
3158 window.el.
3159 (compare_window_configurations): Simplify code.
3160
b6e3633c
AS
31612011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3162
1ab0dee5
AS
3163 * image.c (imagemagick_load_image): Fix type mismatch.
3164 (Fimagemagick_types): Likewise.
3165
b6e3633c
AS
3166 * window.h (replace_buffer_in_windows): Declare.
3167
9397e56f
MR
31682011-06-11 Martin Rudalics <rudalics@gmx.at>
3169
3170 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3171 Qclone_number. Remove external declaration of Qdelete_window.
3172 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3173 code.
640c8776
SM
3174 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3175 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3176 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3177 buffer list implementation.
3178 (other_buffer_safely): New function.
3179 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3180 calls to replace_buffer_in_windows and
3181 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3182 if allowed.
3183 (record_buffer): Inhibit quitting and rewrite using quittable
3184 functions. Run Qbuffer_list_update_hook if allowed.
3185 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3186 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3187 Move switch-to-buffer to window.el.
9397e56f
MR
3188 (bury-buffer): Move to window.el.
3189 (Vbuffer_list_update_hook): New variable.
3190
3191 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3192 section.
3193
3194 * window.h (resize_frame_windows): Move up in code.
3195 (Fwindow_frame): Remove EXFUN.
3196 (replace_buffer_in_all_windows): Remove prototype.
3197 (replace_buffer_in_windows_safely): Add prototype.
3198
3199 * window.c: Declare Qdelete_window static again. Move down
3200 declaration of select_count.
3201 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3202 (Fother_window): Move to window.el.
3203 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3204 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3205 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3206 window.el.
3207 (replace_buffer_in_windows): Implement by calling
3208 Qreplace_buffer_in_windows.
3209 (replace_buffer_in_all_windows): Remove with some functionality
3210 moved into replace_buffer_in_windows_safely.
3211 (replace_buffer_in_windows_safely): New function.
3212 (select_window_norecord, select_frame_norecord): Move in front
3213 of run_window_configuration_change_hook. Remove now obsolete
3214 declarations.
640c8776
SM
3215 (Fset_window_buffer): Rewrite doc-string.
3216 Call Qrecord_window_buffer.
9397e56f
MR
3217 (keys_of_window): Move binding for other-window to window.el.
3218
b50691aa
CY
32192011-06-11 Chong Yidong <cyd@stupidchicken.com>
3220
3221 * dispextern.h (struct image): Replace data member, whose int_val
3222 and ptr_val fields were not used by anything, with a single
3223 lisp_val object.
3224
3225 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3226 (gif_clear_image, gif_load, imagemagick_load_image)
3227 (gs_clear_image, gs_load): Callers changed.
3228
3f754b86
PE
32292011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3230
cca69397
PE
3231 * buffer.h: Include <time.h>, for time_t.
3232 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3233
109e28d0
PE
3234 Fix minor problems found by static checking.
3235
60737f02
PE
3236 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3237
4b66faf3
PE
3238 Make identifiers static if they are not used in other modules.
3239 * data.c (Qcompiled_function, Qframe, Qvector):
3240 * image.c (QimageMagick, Qsvg):
3241 * minibuf.c (Qmetadata):
3242 * window.c (resize_window_check, resize_root_window): Now static.
3243 * window.h (resize_window_check, resize_root_window): Remove decls.
3244
109e28d0
PE
3245 * window.c (window_deletion_count, delete_deletable_window):
3246 Remove; unused.
46a4ce9e
PE
3247 (window_body_lines): Now static.
3248 (Fdelete_other_windows_internal): Mark vars as initialized.
3249 Make sure 'resize_failed' is initialized.
3250 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3251 (resize_window_apply): Remove unused local.
3252 * window.h (delete_deletable_window): Remove decl.
3253
109e28d0 3254 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3255 (imagemagick_load_image): Fix pointer signedness problem by changing
3256 last arg from unsigned char * to char *. All uses changed.
3257 Also, fix a local for similar reasons.
3258 Remove unused locals. Remove locals to avoid shadowing.
3259 (fn_rsvg_handle_free): Remove; unused.
3260 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3261 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3262
3f754b86
PE
3263 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3264
2547adb1
CY
32652011-06-10 Chong Yidong <cyd@stupidchicken.com>
3266
3267 * image.c (gif_load): Fix omitted cast error introduced by
3268 2011-06-06 change.
3269
2c8e37d4
MR
32702011-06-10 Martin Rudalics <rudalics@gmx.at>
3271
3272 * window.h (resize_proportionally, orig_total_lines)
3273 (orig_top_line): Remove from window structure.
3274 (set_window_height, set_window_width, change_window_heights)
3275 (Fdelete_window): Remove prototypes.
3276 (resize_frame_windows): Remove duplicate declaration.
3277
440a42e3
EZ
32782011-06-10 Eli Zaretskii <eliz@gnu.org>
3279
3280 * window.h (resize_frame_windows, resize_window_check)
3281 (delete_deletable_window, resize_root_window)
3282 (resize_frame_windows): Declare prototypes.
3283
3284 * window.c (resize_window_apply): Make definition be "static" to
3285 match the prototype.
3286
562dd5e9
MR
32872011-06-10 Martin Rudalics <rudalics@gmx.at>
3288
3289 * window.c: Remove declarations of Qwindow_size_fixed,
3290 window_min_size_1, window_min_size_2, window_min_size,
3291 size_window, window_fixed_size_p, enlarge_window, delete_window.
3292 Remove static from declaration of Qdelete_window, it's
3293 temporarily needed by Fbury_buffer.
3294 (replace_window): Don't assign orig_top_line and
3295 orig_total_lines.
3296 (Fdelete_window, delete_window): Remove. Window deletion is
3297 handled by window.el.
640c8776
SM
3298 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3299 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3300 (Fdelete_other_windows): Remove. Deleting other windows is
3301 handled by window.el.
3302 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3303 handled in window.el.
3304 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3305 Window minimum sizes are handled in window.el.
3306 (shrink_windows, size_window, set_window_height)
3307 (set_window_width, change_window_heights, window_height)
3308 (window_width, CURBEG, CURSIZE, enlarge_window)
3309 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3310 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3311 handled in window.el.
3312 (make_dummy_parent): Rename to make_parent_window and give it a
3313 second argument horflag.
3314 (make_window): Don't set resize_proportionally any more.
3315 (Fsplit_window): Remove. Windows are split in window.el.
3316 (save_restore_action, save_restore_orig_size)
3317 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3318 Resize mini windows in window.el.
3319 (grow_mini_window, shrink_mini_window): Implement by calling
3320 Qresize_root_window_vertically, resize_window_check and
3321 resize_window_apply.
640c8776
SM
3322 (saved_window, Fset_window_configuration, save_window_save):
3323 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3324 resize_proportionally.
3325 (window_min_height, window_min_width): Move to window.el.
3326 (keys_of_window): Move bindings for delete-other-windows,
3327 split-window, delete-window and enlarge-window to window.el.
3328
3329 * buffer.c: Temporarily extern Qdelete_window.
3330 (Fbury_buffer): Temporarily call Qdelete_window instead of
3331 Fdelete_window (Fbury_buffer will move to window.el soon).
3332
3333 * frame.c (set_menu_bar_lines_1): Remove code handling
3334 orig_top_line and orig_total_lines.
3335
3336 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3337 set_window_height but set heights directly.
3338 (change_frame_size_1): Use resize_frame_windows.
3339
3340 * xdisp.c (init_xdisp): Don't use set_window_height but set
3341 heights directly.
3342
640c8776
SM
3343 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3344 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3345 run_window_configuration_change_hook.
3346
3347 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3348 instead of change_window_heights and run
3349 run_window_configuration_change_hook.
3350
1a13852e
MR
33512011-06-09 Martin Rudalics <rudalics@gmx.at>
3352
3353 * window.c (replace_window): Rename second argument REPLACEMENT to
3354 NEW. New third argument SETFLAG. Rewrite.
3355 (delete_window, make_dummy_parent): Call replace_window with
3356 third argument 1.
3357 (window_list_1): Move down in code.
3358 (run_window_configuration_change_hook): Move set_buffer part
3359 before select_frame_norecord part in order to unwind correctly.
3360 Rename count1 to count.
3361 (recombine_windows, delete_deletable_window, resize_root_window)
3362 (Fdelete_other_windows_internal)
3363 (Frun_window_configuration_change_hook, make_parent_window)
3364 (resize_window_check, resize_window_apply, Fresize_window_apply)
3365 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3366 (Fdelete_window_internal, Fresize_mini_window_internal):
3367 New functions.
1a13852e
MR
3368 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3369
f3d1777e
MR
33702011-06-08 Martin Rudalics <rudalics@gmx.at>
3371
496e208e
MR
3372 * window.h (window): Add some new members to window structure -
3373 normal_lines, normal_cols, new_total, new_normal, clone_number,
3374 splits, nest, prev_buffers, next_buffers.
3375 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3376 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3377
f3d1777e
MR
3378 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3379 Remove.
496e208e
MR
3380 (make_dummy_parent): Set new members of windows structure.
3381 (make_window): Move down in code. Handle new members of window
3382 structure.
3383 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3384 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3385 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3386 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3387 (Fset_window_next_buffers, Fset_window_clone_number):
3388 New functions.
496e208e
MR
3389 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3390 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3391 Doc-string fixes.
3392 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3393 Argument WINDOW can be now internal window too.
3394 (Fwindow_use_time): Move up in code.
3395 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3396 Rewrite doc-string.
3397 (Fset_window_configuration, saved_window)
3398 (Fcurrent_window_configuration, save_window_save): Handle new
3399 members of window structure.
b9e809c2
MR
3400 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3401 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3402 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3403 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3404 Qget_mru_window, Qresize_root_window,
3405 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3406 Qauto_buffer_name; staticpro them.
f3d1777e 3407
abde8f8c
MR
34082011-06-07 Martin Rudalics <rudalics@gmx.at>
3409
3410 * window.c (Fwindow_total_size, Fwindow_left_column)
3411 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3412 (Fwindow_list_1): New functions.
3413 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3414 (Fwindow_width, Fscroll_left, Fscroll_right):
3415 Use window_body_cols instead of window_box_text_cols.
3416 (delete_window, Fset_window_configuration):
3417 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3418 (delete_all_subwindows): Take a window as argument and not a
3419 structure. Rewrite.
190b47e6
MR
3420 (window_loop): Remove handling of GET_LRU_WINDOW and
3421 GET_LARGEST_WINDOW.
3422 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3423
3424 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3425 window_box_text_cols. delete_all_subwindows now takes a
3426 Lisp_Object as argument.
abde8f8c 3427
640c8776
SM
3428 * indent.c (compute_motion, Fcompute_motion):
3429 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3430
fa8a67e6
MR
3431 * frame.c (delete_frame): Call delete_all_subwindows with root
3432 window as argument.
3433
a54e3482
DC
34342011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3435
3436 * fns.c (Fputhash): Document return value.
3437
60002bf5
CY
34382011-06-06 Chong Yidong <cyd@stupidchicken.com>
3439
3440 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3441
0c671da6 34422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3443
b862a52a 3444 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3445
be44ca6c
PE
3446 Check for overflow when converting integer to cons and back.
3447 * charset.c (Fdefine_charset_internal, Fdecode_char):
3448 Use cons_to_unsigned to catch overflow.
3449 (Fencode_char): Use INTEGER_TO_CONS.
3450 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3451 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3452 * data.c (long_to_cons, cons_to_long): Remove.
3453 (cons_to_unsigned, cons_to_signed): New functions.
3454 These signal an error for invalid or out-of-range values.
3455 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3456 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3457 * font.c (Ffont_variation_glyphs):
3458 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3459 * lisp.h: Include <intprops.h>.
3460 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3461 (cons_to_signed, cons_to_unsigned): New decls.
3462 (long_to_cons, cons_to_long): Remove decls.
3463 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3464 (Fprimitive_undo): Use CONS_TO_INTEGER.
3465 * xfns.c (Fx_window_property): Likewise.
3466 * xselect.c: Include <limits.h>.
3467 (x_own_selection, selection_data_to_lisp_data):
3468 Use INTEGER_TO_CONS.
3469 (x_handle_selection_request, x_handle_selection_clear)
3470 (x_get_foreign_selection, Fx_disown_selection_internal)
3471 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3472 (lisp_data_to_selection_data): Use cons_to_unsigned.
3473 (x_fill_property_data): Use cons_to_signed.
3474 Report values out of range.
3475
d1f3d2af
PE
3476 Check for buffer and string overflow more precisely.
3477 * buffer.h (BUF_BYTES_MAX): New macro.
3478 * lisp.h (STRING_BYTES_MAX): New macro.
3479 * alloc.c (Fmake_string):
3480 * character.c (string_escape_byte8):
3481 * coding.c (coding_alloc_by_realloc):
3482 * doprnt.c (doprnt):
3483 * editfns.c (Fformat):
3484 * eval.c (verror):
3485 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3486 since they may not be the same number.
3487 * editfns.c (Finsert_char):
3488 * fileio.c (Finsert_file_contents):
3489 Likewise for BUF_BYTES_MAX.
3490
dd52fcea
PE
3491 * image.c: Use ptrdiff_t, not int, for sizes.
3492 (slurp_file): Switch from int to ptrdiff_t.
3493 All uses changed.
3494 (slurp_file): Check that file size fits in both size_t (for
3495 malloc) and ptrdiff_t (for sanity and safety).
3496
7f9bbdbb
PE
3497 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3498 if b->modtime has its maximal value.
3499
dfe18f82
PE
3500 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3501
84acfcf0
PE
3502 Don't assume time_t can fit into int.
3503 * buffer.h (struct buffer.modtime): Now time_t, not int.
3504 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3505 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3506
ccd9a01a
PE
3507 Minor fixes for signed vs unsigned integers.
3508 * character.h (MAYBE_UNIFY_CHAR):
3509 * charset.c (maybe_unify_char):
3510 * keyboard.c (read_char, reorder_modifiers):
3511 XINT -> XFASTINT, since the integer must be nonnegative.
3512 * ftfont.c (ftfont_spec_pattern):
3513 * keymap.c (access_keymap, silly_event_symbol_error):
3514 XUINT -> XFASTINT, since the integer must be nonnegative.
3515 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3516 since it makes no difference and we prefer signed.
3517 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3518 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3519 nonnegative.
3520
d6d100dd
SM
35212011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3522
3523 * window.h (Fwindow_frame): Declare.
3524
2b6148e4
PE
35252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3528 (SPARE_MEMORY): Always define.
3529 (LARGE_REQUEST): Remove.
3530 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3531
f230ecc9
MR
35322011-06-06 Martin Rudalics <rudalics@gmx.at>
3533
727e958e
MR
3534 * lisp.h: Move EXFUNS for Fframe_root_window,
3535 Fframe_first_window and Fset_frame_selected_window to window.h.
3536
3537 * window.h: Move EXFUNS for Fframe_root_window,
3538 Fframe_first_window and Fset_frame_selected_window here from
3539 lisp.h.
3540
3541 * frame.c (Fwindow_frame, Fframe_first_window)
3542 (Fframe_root_window, Fframe_selected_window)
3543 (Fset_frame_selected_window): Move to window.c.
3544 (Factive_minibuffer_window): Move to minibuf.c.
3545 (Fother_visible_frames_p): New function.
3546
3547 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3548
f230ecc9
MR
3549 * window.c (decode_window, decode_any_window): Move up in code.
3550 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3551 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3552 (Fwindow_buffer): Move up and rewrite doc-string.
3553 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3554 (Fwindow_prev): New functions.
727e958e
MR
3555 (Fwindow_frame): Move here from frame.c. Accept any window as
3556 argument.
3557 (Fframe_root_window, Fframe_first_window)
3558 (Fframe_selected_window): Move here from frame.c. Accept frame
3559 or arbitrary window as argument. Update doc-strings.
3560 (Fminibuffer_window): Move up in code.
3561 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3562 (Fset_frame_selected_window): Move here from frame.c.
3563 Marginal rewrite.
727e958e
MR
3564 (Fselected_window, select_window, Fselect_window): Move up in
3565 code. Minor doc-string fixes.
f230ecc9 3566
4d09bcf6
PE
35672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3568
3569 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3570 Do not assume that spare memory exists; that assumption is valid
3571 only if SYSTEM_MALLOC.
3572 (LARGE_REQUEST): New macro, so that the issue of large requests
3573 is separated from the issue of spare memory.
3574
810928a2
AS
35752011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3576
172418ad
AS
3577 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3578 format. (Bug#8806)
3579
43f862f7
AS
3580 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3581
810928a2
AS
3582 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3583 before statements.
3584
a059fe24
JD
35852011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3586
3587 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3588
3589 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3590
3591 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3592 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3593
989bf368
JB
35942011-06-05 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3597
4b80f674
CY
35982011-06-04 Chong Yidong <cyd@stupidchicken.com>
3599
3600 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3601 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3602 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3603 New error handlers.
4b80f674
CY
3604 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3605 Obey Vx_select_enable_clipboard_manager. Catch errors in
3606 x_clipboard_manager_save (Bug#8779).
3607 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3608 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3609
99a33b77 36102011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3611
3612 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3613
99a33b77 36142011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3615
3616 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3617 in the current matrix if keep_current_p is non-zero.
3618
8264569d
EZ
36192011-06-04 Eli Zaretskii <eliz@gnu.org>
3620
3621 * bidi.c (bidi_level_of_next_char): Fix last change.
3622
57f97249
EZ
36232011-06-03 Eli Zaretskii <eliz@gnu.org>
3624
fec2107c 3625 Support bidi reordering of text covered by display properties.
57f97249 3626
fec2107c
EZ
3627 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3628 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3629 (bidi_cache_search, bidi_cache_iterator_state)
3630 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3631 (bidi_level_of_next_char, bidi_move_to_visually_next):
3632 Support character positions inside a run of characters covered by a
fec2107c
EZ
3633 display string.
3634 (bidi_paragraph_init, bidi_resolve_explicit_1)
3635 (bidi_level_of_next_char): Call bidi_fetch_char and
3636 bidi_fetch_char_advance instead of FETCH_CHAR and
3637 FETCH_CHAR_ADVANCE.
3638 (bidi_init_it): Initialize new members.
3639 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3640 definitions.
3641 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3642 instead of using explicit *_CHAR codes.
d6d100dd
SM
3643 (bidi_resolve_explicit, bidi_resolve_weak):
3644 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3645 bidirectional text is supported only in multibyte buffers.
3646 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3647 it to initialize the frame_window_p member of struct bidi_it.
3648 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3649 (bidi_resolve_explicit, bidi_resolve_weak)
3650 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3651 bidi_it->nchars is non-positive.
3652 (bidi_level_of_next_char): Don't try to lookup the cache for the
3653 next/previous character if nothing is cached there yet, or if we
3654 were just reseat()'ed to a new position.
c40e2fb2 3655
0e14fe90
EZ
3656 * xdisp.c (set_cursor_from_row): Set start and stop points
3657 according to the row's direction when priming the loop that looks
3658 for the glyph on which to display cursor.
3659 (single_display_spec_intangible_p): Function deleted.
3660 (display_prop_intangible_p): Reimplement to call
3661 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3662 Accept 3 additional arguments needed by handle_display_spec.
3663 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3664 values: lists, `(when COND...)' forms, etc.
3665 (single_display_spec_string_p): Support property values that are
3666 lists with the argument STRING its top-level element.
3667 (display_prop_string_p): Fix the condition for processing a
3668 property that is a list to be consistent with handle_display_spec.
fec2107c 3669 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3670 last portion of handle_display_prop.
3671 (compute_display_string_pos): Accept additional argument
3672 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3673 value of a `display' property is a "replacing spec".
3674 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3675 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3676 the display property, but just return a value indicating whether
3677 the display property will replace the characters it covers.
3678 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3679 frame_window_p members of struct bidi_it.
d6d100dd
SM
3680 (compute_display_string_pos, compute_display_string_end):
3681 New functions.
fec2107c
EZ
3682 (push_it): Accept second argument POSITION, where pop_it should
3683 jump to continue iteration.
3684 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3685
fec2107c
EZ
3686 * keyboard.c (adjust_point_for_property): Adjust the call to
3687 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3688
3689 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3690 (bidi_init_it): Update prototypes.
3691 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3692 (compute_display_string_pos, compute_display_string_end):
3693 Declare prototypes.
fec2107c
EZ
3694 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3695 EMACS_INT.
fc6f18ce 3696
40087514 36972011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3698
57f53182
PE
3699 Malloc failure behavior now depends on size of allocation.
3700 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3701 * lisp.h: Change signatures accordingly.
3702 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3703 All callers changed. (Bug#8762)
3704
3705 * gnutls.c: Use Emacs's memory allocators.
3706 Without this change, the gnutls library would invoke malloc etc.
3707 directly, which causes problems on non-SYNC_INPUT hosts, and which
3708 runs afoul of improving memory_full behavior. (Bug#8761)
3709 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3710 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3711 xfree instead of the default malloc, realloc, free.
3712 (Fgnutls_boot): No need to check for memory allocation failure,
3713 since xmalloc does that for us.
3714
ac32cd99 3715 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3716 * category.c (hash_get_category_set):
3717 * ccl.c (ccl_driver):
3718 * charset.c (Fdefine_charset_internal):
3719 * charset.h (struct charset.hash_index):
3720 * composite.c (get_composition_id, gstring_lookup_cache)
3721 (composition_gstring_put_cache):
3722 * composite.h (struct composition.hash_index):
3723 * dispextern.h (struct image.hash):
3724 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3725 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3726 (hashfn_equal, hashfn_user_defined, make_hash_table)
3727 (maybe_resize_hash_table, hash_lookup, hash_put)
3728 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3729 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3730 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3731 * image.c (make_image, search_image_cache, lookup_image)
3732 (xpm_put_color_table_h):
3733 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3734 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3735 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3736 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3737 * alloc.c (allocate_vectorlike):
3738 Check for overflow in vector size calculations.
3739 * ccl.c (ccl_driver):
3740 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3741 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3742 need to be updated by these changes.
40087514
PE
3743 * fns.c (make_hash_table, maybe_resize_hash_table):
3744 Check for integer overflow with large hash tables.
0de4bb68
PE
3745 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3746 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3747 (SXHASH_REDUCE): New macro.
3748 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3749 Use it instead of discarding useful hash info with large hash values.
3750 (sxhash_float): New function.
3751 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3752 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3753 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3754 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3755 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3756 Adjust signatures to match updated version of code.
3757 (consing_since_gc): Now EMACS_INT, since a single hash table can
3758 use more than INT_MAX bytes.
3759
698d32e2
DN
37602011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3761
3762 Make it possible to build with GCC-4.6+ -O2 -flto.
3763
3764 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3765
fd6fa53f
SM
37662011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3767
3768 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3769 Call minibuffer-inactive-mode.
3770
864db017
JB
37712011-05-31 Juanma Barranquero <lekktu@gmail.com>
3772
3773 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3774 Update dependencies.
3775
2ad0baf4
DN
37762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3777
3778 * data.c (init_data): Remove code for UTS, this system is not
3779 supported anymore.
3780
4fcc2638
DN
37812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3782
3783 Don't force ./temacs to start in terminal mode.
3784
3785 * frame.c (make_initial_frame): Initialize faces in all cases, not
3786 only when CANNOT_DUMP is defined.
3787 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3788
c56e0fd5
DN
37892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3790
3791 * dispnew.c (add_window_display_history): Use const for the string
3792 pointer. Remove declaration, not needed.
3793
333d54da 37942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3795
55d4c1b2 3796 Use 'inline', not 'INLINE'.
333d54da 3797 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3798 * alloc.c, fontset.c (INLINE): Remove.
3799 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3800 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3801 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3802 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3803 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3804
738db178
DN
38052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3806
3807 Make it possible to run ./temacs.
3808
3809 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3810 syms_of_callproc does the same thing. Remove test for
3811 "initialized", do it in the caller.
3812 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3813
620c53a6
SM
38142011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3815
3816 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3817 (read_minibuf): Use get_minibuffer.
3818 (syms_of_minibuf): Use DEFSYM.
3819 (Qmetadata): New var.
3820 * data.c (Qbuffer): Don't make it static.
3821 (syms_of_data): Use DEFSYM.
3822
e003a292
PE
38232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3824
3825 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3826 (CCL_CODE_MIN): New macro.
3827
ed008a6d
PE
38282011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3829
3687c2ef
PE
3830 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3831
ed008a6d
PE
3832 * eval.c (Qdebug): Now static.
3833 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3834 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3835 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3836
d66c4c7c
CY
38372011-05-29 Chong Yidong <cyd@stupidchicken.com>
3838
3839 * image.c: Various fixes to ImageMagick code comments.
3840 (Fimagemagick_types): Doc fix.
3841
5fbc2025
PE
38422011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3843
0196f88a
PE
3844 Minor fixes prompted by GCC 4.6.0 warnings.
3845
3846 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3847
5fbc2025
PE
3848 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3849 (x_clipboard_manager_save_all): Move extern decl to ...
3850 * xterm.h: ... here, so that it can be checked for consistency.
3851
1dd3c2d9
CY
38522011-05-29 Chong Yidong <cyd@stupidchicken.com>
3853
3854 * xselect.c (x_clipboard_manager_save_frame)
3855 (x_clipboard_manager_save_all): New functions.
3856 (Fx_clipboard_manager_save): Lisp function deleted.
3857
3858 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3859 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3860
3861 * xterm.h: Update prototype.
3862
5ba6571d
WX
38632011-05-28 William Xu <william.xwl@gmail.com>
3864
3865 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3866 exiting (Bug#8239).
3867
3eaff834
JM
38682011-05-28 Jim Meyering <meyering@redhat.com>
3869
e1900994 3870 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3871 * fns.c (to_uchar): Define.
3872 (crypto_hash_function): Use it to convert some newly-signed
3873 variables to unsigned, to avoid sign-extension bugs. For example,
3874 without this change, (md5 "truc") would evaluate to
3875 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3876 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3877 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3878
0f6990a7
PE
38792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 Integer overflow fixes.
c8a9ca5a 3882
08686060
PE
3883 * dbusbind.c: Serial number integer overflow fixes.
3884 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3885 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3886 to hold a serial number that is too large for a fixnum.
3887 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3888 Check for serial numbers out of range. Decode any serial number
59568bf0 3889 that was so large that it became a float. (Bug#8722)
08686060 3890
2d1fc3c7
PE
3891 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3892 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3893 Use XFASTINT rather than XUINT when numbers are nonnegative.
3894 (xd_append_arg, Fdbus_method_return_internal):
3895 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3896 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3897 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3898 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3899 (Bug#8722)
2d1fc3c7 3900
c8a9ca5a
PE
3901 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3902
519e1d69
PE
3903 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3904
30569699
PE
3905 ccl: add integer overflow checks
3906 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3907 (IN_INT_RANGE): New macros.
3908 (ccl_driver): Use them to check for integer overflow when
3909 decoding a CCL program. Many of the new checks are whether XINT (x)
3910 fits in int; it doesn't always, on 64-bit hosts. The new version
3911 doesn't catch all possible integer overflows, but it's an
847044ea 3912 improvement. (Bug#8719)
30569699 3913
c11285dc
PE
3914 * alloc.c (make_event_array): Use XINT, not XUINT.
3915 There's no need for unsigned here.
3916
fdccd48e
PE
3917 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3918 This follows up to the 2011-05-06 change that substituted uintptr_t
3919 for EMACS_INT. This case wasn't caught back then.
3920
37910ab2
PE
3921 Rework Fformat to avoid integer overflow issues.
3922 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3923 now (part of C89). Include <verify.h>.
3924 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3925 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3926 (Fformat): Avoid the prepass trying to compute sizes; it was only
3927 approximate and thus did not catch overflow reliably. Instead, walk
3928 through the format just once, formatting and computing sizes as we go,
3929 checking for integer overflow at every step, and allocating a larger
3930 buffer as needed. Keep track separately whether the format is
3931 multibyte. Keep only the most-recently calculated precision, rather
3932 than them all. Record whether each argument has been converted to
3933 string. Use EMACS_INT, not int, for byte and char and arg counts.
3934 Support field widths and precisions larger than INT_MAX. Avoid
3935 sprintf's undefined behavior with conversion specifications such as %#d
3936 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3937 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3938 formatting out-of-range floating point numbers with int
9173deec 3939 formats. (Bug#8668)
37910ab2 3940
2e6578fb
PE
3941 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3942
0ae6bdee
PE
3943 * data.c: Avoid integer truncation in expressions involving floats.
3944 * data.c: Include <intprops.h>.
3945 (arith_driver): When there's an integer overflow in an expression
3946 involving floating point, convert the integers to floating point
3947 so that the resulting value does not suffer from catastrophic
3948 integer truncation. For example, on a 64-bit host (* 4
3949 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3950 Do not rely on undefined behavior after integer overflow.
3951
de883a70
PE
3952 merge count_size_as_multibyte, parse_str_to_multibyte
3953 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3954 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3955 Check for integer overflow.
3956 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3957 since it's now a duplicate of the other. This is more of
3958 a character than a buffer op, so better that it's in character.c.
3959 * fns.c, print.c: Adjust to above changes.
3960
2ff916cb
PE
39612011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3962
3963 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3964
f1b54466
PE
39652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3966
fb1ac845
PE
3967 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3968 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3969 (x_clipboard_manager_save): Now static.
3970 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3971
f1b54466
PE
3972 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3973 (crypto_hash_function): Now static.
3974 Fix pointer signedness problems. Avoid unnecessary initializations.
3975
a9f737ee
CY
39762011-05-27 Chong Yidong <cyd@stupidchicken.com>
3977
3978 * termhooks.h (Vselection_alist): Make it terminal-local.
3979
3980 * terminal.c (create_terminal): Initialize it.
3981
3982 * xselect.c: Support for clipboard managers.
3983 (Vselection_alist): Move to termhooks.h as terminal-local var.
3984 (LOCAL_SELECTION): New macro.
3985 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3986 (symbol_to_x_atom): Remove gratuitous arg.
3987 (x_handle_selection_request, lisp_data_to_selection_data)
3988 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3989 (x_own_selection, x_get_local_selection, x_convert_selection):
3990 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3991 (some_frame_on_display): Delete unused function.
3992 (Fx_own_selection_internal, Fx_get_selection_internal)
3993 (Fx_disown_selection_internal, Fx_selection_owner_p)
3994 (Fx_selection_exists_p): New optional frame arg.
3995 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3996 (x_handle_selection_clear): Don't treat other terminals with the
3997 same keyboard specially. Use the terminal-local Vselection_alist.
3998 (x_clear_frame_selections): Use Frun_hook_with_args.
3999
4000 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4001
4002 * xterm.h: Add support for those atoms.
4003
e067f0c1
CY
40042011-05-26 Chong Yidong <cyd@stupidchicken.com>
4005
4006 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4007 (converted_selections, conversion_fail_tag): New global variables.
4008 (x_selection_request_lisp_error): Free the above.
4009 (x_get_local_selection): Remove unnecessary code.
4010 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4011 of converted selections stored in converted_selections.
4012 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4013 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4014 (x_convert_selection): New function.
4015 (x_handle_selection_event): Simplify.
4016 (x_get_foreign_selection): Don't ignore incoming requests while
4017 waiting for an answer; this will fail when we implement
4018 SAVE_TARGETS, and seems unnecessary anyway.
4019 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4020 (Vx_sent_selection_functions): Doc fix.
4021
0f4aebc0
LL
40222011-05-26 Leo Liu <sdl.web@gmail.com>
4023
4024 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4025
e61124cd
YM
40262011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4027
4028 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4029
4030 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4031 for fringe update if it has periodic bitmap.
ac389d0c 4032 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4033 and fringe_bitmap_periodic_p.
4034
4035 * fringe.c (get_fringe_bitmap_data): New function.
4036 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4037 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4038 row. Mark glyph row for fringe update if periodicity changed.
4039
4040 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4041 for fringe update unless it has periodic bitmap.
4042
f16d9837
KH
40432011-05-25 Kenichi Handa <handa@m17n.org>
4044
4045 * xdisp.c (get_next_display_element): Set correct it->face_id for
4046 a static composition.
4047
e1b90ef6
LL
40482011-05-24 Leo Liu <sdl.web@gmail.com>
4049
4050 * deps.mk (fns.o):
4051 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4052
4053 * fns.c (crypto_hash_function, Fsha1): New function.
4054 (Fmd5): Use crypto_hash_function.
4055 (syms_of_fns): Add Ssha1.
4056
7400048f
PE
40572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4058
4059 * gnutls.c: Remove unused macros.
4060 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4061 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4062 Remove macros that are defined and never used.
4063 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4064
abb71cf4
CY
40652011-05-22 Chong Yidong <cyd@stupidchicken.com>
4066
4067 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4068 (Fx_get_selection_internal): Minor cleanup.
4069 (Fx_own_selection_internal): Rename arguments for consistency with
4070 select.el.
4071
6307db39
PE
40722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4073
4074 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4075
f3d4e0a4
CY
40762011-05-22 Chong Yidong <cyd@stupidchicken.com>
4077
4078 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4079
4d8ade89
YM
40802011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4081
4082 * dispnew.c (scrolling_window): Don't exclude the case that the
4083 last enabled row in the desired matrix touches the bottom boundary.
4084
32078c8d
GM
40852011-05-21 Glenn Morris <rgm@gnu.org>
4086
4087 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4088 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4089 and add some more files.
32078c8d 4090
7285dc67
EZ
40912011-05-20 Eli Zaretskii <eliz@gnu.org>
4092
4093 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4094 report_file_error introduced by the change from 2011-05-07.
4095
89d1bd22
PE
40962011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4097
4098 * systime.h (Time): Define only if emacs is defined.
4099 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4100 where the include path doesn't have X11/X.h by default. See
4101 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4102
e23640bb 41032011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4104
4105 * composite.c (find_automatic_composition): Fix previous change.
4106
b9704ad9
GM
41072011-05-20 Glenn Morris <rgm@gnu.org>
4108
4109 * lisp.mk: New file, split from Makefile.in.
4110 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4111 (shortlisp): Remove.
4112 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4113
4a720484
GM
41142011-05-19 Glenn Morris <rgm@gnu.org>
4115
4116 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4117 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4118 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4119 (lisp): Set the order to that of loadup.el.
4120 (shortlisp): Make it a copy of $lisp.
4121 (SOME_MACHINE_LISP): Remove.
4122 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4123 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4124
a28d4396
KH
41252011-05-18 Kenichi Handa <handa@m17n.org>
4126
4127 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4128 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4129 (find_automatic_composition): Mostly rewrite for efficiency.
4130
a2b1fa8e
JB
41312011-05-18 Juanma Barranquero <lekktu@gmail.com>
4132
4133 * makefile.w32-in: Update dependencies.
4134
8e1f5610
CS
41352011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4136
4137 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4138 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4139
7025ee00 41402011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4141
cdfa6eab
PE
4142 Fix some integer overflow issues, such as string length overflow.
4143
06d6db33
PE
4144 * insdel.c (count_size_as_multibyte): Check for string overflow.
4145
2b4560a8
PE
4146 * character.c (lisp_string_width): Check for string overflow.
4147 Use EMACS_INT, not int, for string indexes and lengths; in
4148 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4149 the resulting string length overflows an EMACS_INT; instead,
4150 report a string overflow if no precision given. When checking for
4151 precision exhaustion, use a check that cannot possibly have
4152 integer overflow. (Bug#8675)
4153 * character.h (lisp_string_width): Adjust to new signature.
4154
cb93f9be
PE
4155 * alloc.c (string_overflow): New function.
4156 (Fmake_string): Use it. This doesn't change behavior, but saves
4157 a few bytes and will simplify future changes.
4158 * character.c (string_escape_byte8): Likewise.
4159 * lisp.h (string_overflow): New decl.
4160
1a1f3366
PE
4161 Fixups, following up to the user-interface timestamp change.
4162 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4163 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4164 * msdos.c (mouse_get_pos): Likewise.
4165 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4166 * w32gui.h (Time): Define by including "systime.h" rather than by
4167 declaring it ourselves. (Bug#8664)
4168
d4e3e4d3
PE
4169 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4170 * image.c (clear_image_cache): Likewise.
4171
f6a24d19
PE
4172 * term.c (term_mouse_position): Don't assume time_t wraparound.
4173
08dc5ae6
PE
4174 Be more systematic about user-interface timestamps.
4175 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4176 and sometimes 'EMACS_UINT', to represent these timestamps.
4177 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4178 This makes the code easier to follow, and makes it easier to catch
4179 integer overflow bugs such as Bug#8664.
4180 * frame.c (Fmouse_position, Fmouse_pixel_position):
4181 Use Time, not unsigned long, for user-interface timestamps.
4182 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4183 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4184 * keyboard.h (last_event_timestamp): Likewise.
4185 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4186 * menu.h (xmenu_show): Likewise.
4187 * term.c (term_mouse_position): Likewise.
4188 * termhooks.h (struct input_event.timestamp): Likewise.
4189 (struct terminal.mouse_position_hook): Likewise.
4190 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4191 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4192 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4193 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4194 what it was before.
4195 * menu.h, termhooks.h: Include "systime.h", for Time.
4196
8e55734a
PE
4197 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4198 Don't assume that the difference between two unsigned long values
4199 can fit into an integer. At this point, we know button_down_time
4200 <= event->timestamp, so the difference must be nonnegative, so
4201 there's no need to cast the result if double-click-time is
4202 nonnegative, as it should be; check that it's nonnegative, just in
4203 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4204 apart (about 25 days). (Bug#8664)
8e55734a 4205
841f1b75 4206 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4207 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4208
3e26f69c
PE
4209 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4210 that always fit in int. Use a sentinel instead of a counter, to
4211 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4212 * frame.h (struct frame): Use int for menu_bar_items_used
4213 instead of EMACS_INT, since it always fits in int.
3e26f69c 4214
5cc152c0
PE
4215 * menu.c (grow_menu_items): Check for int overflow.
4216
d89eb65e
PE
4217 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4218
5235bd3e
PE
4219 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4220 Before, the code was not consistent. These values cannot exceed
4221 2**31 - 1 so there's no need to make them unsigned.
4222 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4223 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4224 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4225 as modifiers.
4226 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4227
bc827e23
PE
4228 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4229 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4230 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4231 presumably because the widths might not match.
4232
78eb494e
PE
4233 * window.c (size_window): Avoid needless test at loop start.
4234
04f2d78b
CB
42352011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4236
4237 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4238
d2fc7e3d 42392011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4240
4241 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4242
d2fc7e3d 42432011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4244
4245 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4246 `width' to `bar_area_x' and `bar_area_width', respectively.
4247 (x_scroll_run): Take account of fringe background extension.
4248
04f2d78b
CB
4249 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4250 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4251 `bar_area_width', respectively.
4252 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4253 background extension.
4254
79b70037
GM
42552011-05-10 Jim Meyering <meyering@redhat.com>
4256
4257 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4258
2f142cc5
JB
42592011-05-10 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * image.c (Finit_image_library): Return t for built-in image types,
4262 like pbm and xbm. (Bug#8640)
4263
57679c86
AS
42642011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4265
4266 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4267
888c9e86
EZ
42682011-05-07 Eli Zaretskii <eliz@gnu.org>
4269
b0512a1d
EZ
4270 * w32console.c (Fset_screen_color): Doc fix.
4271 (Fget_screen_color): New function.
4272 (syms_of_ntterm): Defsubr it.
4273
7285dc67
EZ
4274 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4275 unlink the temporary file if Fcall_process didn't create it in the
4276 first place.
4277 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4278 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4279 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4280 cue to call_process_cleanup not to close that handle.
4281
4d3fcc8e
BK
42822011-05-07 Ben Key <bkey76@gmail.com>
4283
4284 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4285 one of two shell specific rules, either bootstrap-temacs-CMD or
4286 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4287 to the previous implementation of the bootstrap-temacs rule.
4288 The bootstrap-temacs-CMD rule is similar to the previous
4289 implementation of the bootstrap-temacs rule except that it
4290 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4291 variable.
4292
4293 These changes, along with some changes to nt/configure.bat,
4294 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4295 earlier fix to add support for --cflags and --ldflags options
4296 that include quotes so that it works whether make uses cmd or
4297 sh as the shell.
4298
b4289b64
MA
42992011-05-06 Michael Albinus <michael.albinus@gmx.de>
4300
4301 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4302 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4303 is a constant.
4304 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4305 a string. Handle both cases.
4306 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4307 (Fdbus_register_method): Use Qinvalid_function.
4308
af4c0e28
JB
43092011-05-06 Juanma Barranquero <lekktu@gmail.com>
4310
4311 * makefile.w32-in: Update dependencies.
4312 (LISP_H): Add inttypes.h and stdin.h.
4313 (PROCESS_H): Add unistd.h.
4314
c51453d9
EZ
43152011-05-06 Eli Zaretskii <eliz@gnu.org>
4316
4317 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4318 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4319
8ff0ac3c 43202011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4321
4c4b566b
PE
4322 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4323
aab2b9b5
PE
4324 * term.c (vfatal): Remove stray call to va_end.
4325 It's not needed and the C Standard doesn't allow it here anyway.
4326
c378da0b
PE
4327 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4328 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4329
288b08c7
PE
4330 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4331 bytes.
4332
e3601888
PE
4333 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4334
db6c0e74
PE
4335 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4336
dd5963ea
PE
4337 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4338
88c9450f
PE
4339 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4340
2f9442b8
PE
4341 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4342
c032b5f8
PE
4343 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4344 * charset.c (Fdefine_charset_internal): Don't initialize
4345 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4346 32-bit int (Bug#8600).
a108c10b
PE
4347
4348 * lread.c (read_integer): Be more consistent with string-to-number.
4349 Use string_to_number to do the actual conversion; this avoids
4350 rounding errors and fixes some other screwups. Without this fix,
4351 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4352 (digit_to_number): Move earlier, for benefit of read_integer.
4353 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4354 not a digit in any supported base. (Bug#8602)
a108c10b 4355
ad5f9eea
PE
4356 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4357
aec1708a
PE
4358 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4359 to match comment at start of function. This also removes a
4360 GCC warning about overflow in a 32+64-bit port.
4361
47be4ab5
PE
4362 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4363
371cac43
PE
4364 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4365 Reported by Stefan Monnier in
4366 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4367 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4368 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4369
d01a7826
PE
4370 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4371 (EMACS_UINTPTR): Likewise, with uintptr_t.
4372
7fd47d5c
PE
4373 * lisp.h: Prefer 64-bit EMACS_INT if available.
4374 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4375 on 32-bit hosts that have 64-bit int, so that they can access
4376 large files.
122b0c86
PE
4377 However, temporarily disable this change unless the temporary
4378 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4379
8727937b
PE
4380 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4381
8ac068ac
PE
4382 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4383 This removes an assumption that EMACS_INT and long are the same
4384 width as pointers. The assumption is true for Emacs porting targets
4385 now, but we want to make other targets possible.
4386 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4387 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4388 In the rest of the code, change types of integers that hold casted
4389 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4390 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4391 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4392 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4393 No need to cast type when ORing.
4394 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4395 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4396 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4397 assume EMACS_INT is the same width as char *.
4398 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4399 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4400 Remove no-longer-needed casts.
4401 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4402 (xg_tool_bar_help_callback, xg_make_tool_item):
4403 Use EMACS_INTPTR to hold an integer
4404 that will be cast to void *; this can avoid a GCC warning
4405 if EMACS_INT is not the same width as void *.
4406 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4407 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4408 (current_message_1, set_message_1):
4409 Use a local to convert to proper width without a cast.
4410 * xmenu.c (dialog_selection_callback): Likewise.
4411
ede49d71
PE
4412 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4413 Also, don't assume VALBITS / RAND_BITS is less than 5,
4414 and don't rely on undefined behavior when shifting a 1 left into
4415 the sign bit.
4416 * lisp.h (get_random): Change signature to match.
4417
2f30ecd0
PE
4418 * lread.c (hash_string): Use size_t, not int, for hash computation.
4419 Normally we prefer signed values; but hashing is special, because
4420 it's better to use unsigned division on hash table sizes so that
4421 the remainder is nonnegative. Also, size_t is the natural width
4422 for hashing into memory. The previous code used 'int', which doesn't
4423 retain enough info to hash well into very large tables.
4424 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4425
2a866e7b
PE
4426 * dbusbind.c: Don't possibly lose pointer info when converting.
4427 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4428 Use XPNTR rather than XHASH, so that the high-order bits of
4429 the pointer aren't lost when converting through void *.
4430
51639eac
PE
4431 * eval.c (Fautoload): Don't double-shift a pointer.
4432
92394119
PE
4433 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4434
dbdb9a7c
JB
44352011-05-06 Juanma Barranquero <lekktu@gmail.com>
4436
4437 * gnutls.c (DEF_GNUTLS_FN):
4438 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4439
db7a0b4f
AS
44402011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4441
4442 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4443 marker. (Bug#8610)
4444
f7ff1b0f 44452011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4446
4447 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4448 New version that can reserve upto 2GB of heap space.
4449
f7ff1b0f 44502011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4451
4452 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4453
639c109b
TZ
44542011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4455
4456 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4457 `gnutls_certificate_set_x509_key_file'.
4458
d2127135
JB
44592011-05-05 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4462 Update dependencies.
4463
e968f4f3
JB
44642011-05-04 Juanma Barranquero <lekktu@gmail.com>
4465
4466 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4467 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4468 Remove unused parameter `fildes'.
4469 * process.c (read_process_output, send_process): Don't pass it.
4470
84d358f0
JB
44712011-05-04 Juanma Barranquero <lekktu@gmail.com>
4472
4473 Fix previous change: the library cache is defined in w32.c.
4474 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4475 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4476
0898ca10
JB
44772011-05-04 Juanma Barranquero <lekktu@gmail.com>
4478
4479 Implement dynamic loading of GnuTLS on Windows.
4480
4481 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4482 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4483 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4484 Declare.
4485
4486 * gnutls.c (Qgnutls_dll): Define.
4487 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4488 (gnutls_*): Declare function pointers.
4489 (init_gnutls_functions): New function to initialize function pointers.
4490 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4491 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4492 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4493 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4494 (emacs_gnutls_write, emacs_gnutls_read)
4495 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4496 (Fgnutls_available_p): New function.
4497 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4498 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4499 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4500
4501 * image.c: Include w32.h.
4502 (Vimage_type_cache): Delete.
4503 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4504 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4505 (w32_delayed_load): Move to w32.c.
4506
4507 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4508
4509 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4510 (w32_delayed_load): Move from image.c. When loading a library, record
4511 its filename in the :loaded-from property of the library id.
4512 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4513 Initialize and staticpro them.
4514 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4515
4516 * process.c: Include lisp.h before w32.h, not after.
4517 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4518 instead of gnutls_record_check_pending.
4519
4520 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4521
ff4de4aa
TZ
45222011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4523
4524 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4525 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4526 as passed in.
4527
abe95abb
JD
45282011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4529
4530 * xterm.c (x_set_frame_alpha): Do not set property on anything
4531 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4532
e16e55d4
JB
45332011-05-02 Juanma Barranquero <lekktu@gmail.com>
4534
4535 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4536
bafcf6a5
JB
45372011-05-02 Juanma Barranquero <lekktu@gmail.com>
4538
4539 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4540 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4541 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4542 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4543 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4544 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4545 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4546 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4547 (Qgnutls_bootprop_callbacks_verify): Make static.
4548
e7a6747f
AS
45492011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4550
19ed11ba
AS
4551 * callproc.c: Indentation fixup.
4552
e7a6747f 4553 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4554 (wait_for_termination, interruptible_wait_for_termination):
4555 Move after wait_for_termination_1.
e7a6747f 4556
1ef14cb4
LMI
45572011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4558
4559 * sysdep.c (interruptible_wait_for_termination): New function
4560 which is like wait_for_termination, but allows keyboard
4561 interruptions.
4562
4563 * callproc.c (Fcall_process): Add (:file "file") as an option for
4564 the STDOUT buffer.
4565 (Fcall_process_region): Ditto.
4566
330d880c
EZ
45672011-04-30 Eli Zaretskii <eliz@gnu.org>
4568
8db90b73
EZ
4569 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4570 rather than `XVECTOR (FOO)->size'.
4571
330d880c
EZ
4572 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4573 inttypes.h, as a gnulib replacement is used if it not available in
4574 system headers.
4575
15cbd324
EZ
45762011-04-21 Eli Zaretskii <eliz@gnu.org>
4577
4578 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4579 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4580 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4581
4582 * coding.c (coding_alloc_by_realloc): Error out if destination
4583 will grow beyond MOST_POSITIVE_FIXNUM.
4584 (decode_coding_emacs_mule): Abort if there isn't enough place in
4585 charbuf for the composition carryover bytes. Reserve an extra
4586 space for up to 2 characters produced in a loop.
4587 (decode_coding_iso_2022): Abort if there isn't enough place in
4588 charbuf for the composition carryover bytes.
4589
45902011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4591
ae940cca
EZ
4592 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4593 aborting when %lld or %lll format is passed.
4594 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4595 %llo or %llx format is passed. (Bug#8545)
4596
03ab8921
EZ
4597 * window.c (window_scroll_line_based): Use a marker instead of
4598 simple variables to record original value of point. (Bug#7952)
4599
afda1437
EZ
4600 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4601 produced by %s or %c overflows available buffer space. (Bug#8545)
4602
f76dee0c
PE
46032011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4604
4605 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4606 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4607
fdc5744d
JB
46082011-04-28 Juanma Barranquero <lekktu@gmail.com>
4609
4610 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4611
638f053a
JB
46122011-04-28 Juanma Barranquero <lekktu@gmail.com>
4613
4614 * keyboard.c (Qdelayed_warnings_hook): Define.
4615 (command_loop_1): Run `delayed-warnings-hook'
4616 if Vdelayed_warnings_list is non-nil.
4617 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4618 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4619
d178f871
EZ
46202011-04-28 Eli Zaretskii <eliz@gnu.org>
4621
4622 * doprnt.c (doprnt): Don't return value smaller than the buffer
4623 size if the message was truncated. (Bug#8545).
4624
b124fd93
JB
46252011-04-28 Juanma Barranquero <lekktu@gmail.com>
4626
4627 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4628 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4629
e810457d
PE
46302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4631
4632 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4633
ea51cceb
JB
46342011-04-27 Juanma Barranquero <lekktu@gmail.com>
4635
4636 * makefile.w32-in: Update dependencies.
4637
94dcfacf
EZ
46382011-04-27 Eli Zaretskii <eliz@gnu.org>
4639
4640 Improve `doprnt' and its usage. (Bug#8545)
4641 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4642 `format_end'. Remove support for %l as a conversion specifier.
4643 Don't use xrealloc. Improve diagnostics when the %l size modifier
4644 is used. Update the commentary.
4645
4646 * eval.c (verror): Simplify calculation of size_t.
4647
4648 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4649 messages.
4650
f61f41d7
PE
46512011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4652
4653 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4654 change.
4655
96fb4434
PE
46562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4657
4658 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4659 This makes this file independent of the recent pseudovector change.
4660
671875da 46612011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4662
69e9b5a3
PE
4663 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4664
b5f869a7 4665 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4666 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4667 Remove unused local.
c8926152 4668 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4669
841a1577 4670 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4671 GCC 4.6.0 optimizes based on type-based alias analysis.
4672 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4673 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4674 != &v->size, and therefore "v->size = 1; b->size = 2; return
4675 v->size;" must therefore return 1. This assumption is incorrect
4676 for Emacs, since it type-puns struct Lisp_Vector * with many other
4677 types. To fix this problem, this patch adds a new type struct
f904488f 4678 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4679 and pseudovectors, and helps optimizing compilers not get fooled
4680 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4681 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4682 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4683 the size member.
eab3844f
PE
4684 (XSETPVECTYPE): Rewrite in terms of new macro.
4685 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4686 This is a bit clearer, and further avoids the possibility of
4687 undesirable aliasing.
4688 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4689 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4690 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4691 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4692 (ASIZE): Now uses header.size rather than size.
4693 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4694 to avoid the hassle of writing XVECTOR (foo)->header.size.
4695 (struct vectorlike_header): New type.
eab3844f
PE
4696 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4697 object, to help avoid aliasing.
4698 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4699 (SUBRP): Likewise, since Lisp_Subr is a special case.
4700 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4701 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4702 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4703 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4704 changed to be "header.size" and "header.next".
4705 * buffer.h (struct buffer): Likewise.
4706 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4707 * frame.h (struct frame): Likewise.
4708 * process.h (struct Lisp_Process): Likewise.
4709 * termhooks.h (struct terminal): Likewise.
4710 * window.c (struct save_window_data, struct saved_window): Likewise.
4711 * window.h (struct window): Likewise.
4712 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4713 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4714 * buffer.c (init_buffer_once): Likewise.
4715 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4716 special case.
4717 * process.c (Fformat_network_address): Use local var for size,
4718 for brevity.
4719
0df1eac5
PE
4720 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4721
847ab9d1 4722 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4723 * data.c (atof): Remove decl; no longer used or needed.
4724 (digit_to_number): Move to lread.c.
4725 (Fstring_to_number): Use new string_to_number function, to be
4726 consistent with how the Lisp reader treats infinities and NaNs.
4727 Do not assume that floating-point numbers represent EMACS_INT
4728 without losing information; this is not true on most 64-bit hosts.
4729 Avoid double-rounding errors, by insisting on integers when
4730 parsing non-base-10 numbers, as the documentation specifies.
4731 * lisp.h (string_to_number): New decl, replacing ...
4732 (isfloat_string): Remove.
bc0a5c13 4733 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4734 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4735 appears to have been a coding error. Similarly, do not accept
4736 strings like +-1e0 as floating point numbers. Do not report
4737 overflow for integer overflows unless the base is not 10 which
4738 means we have no simple and reliable way to continue.
4739 Break out the floating-point parsing into a new
4740 function string_to_number, so that Fstring_to_number parses
4741 floating point numbers consistently with the Lisp reader.
04f2d78b 4742 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4743 (E_CHAR, EXP_INT): Remove, replacing with ...
4744 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4745 (string_to_number): New function, replacing isfloat_string.
4746 This function checks for valid syntax and produces the resulting
4747 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4748 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4749 so that overflow for non-base-10 numbers is reported only when
4750 there's no portable and simple way to convert to floating point.
452f4150 4751
67769ffc
PE
4752 * textprop.c (set_text_properties_1): Rewrite for clarity,
4753 and to avoid GCC warning about integer overflow.
4754
c20db43f
PE
4755 * intervals.h (struct interval): Use EMACS_INT for members
4756 where EMACS_UINT might cause problems. See
4757 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4758 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4759 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4760 All uses changed.
37aa2f85
PE
4761 (offset_intervals): Tell GCC not to worry about length overflow
4762 when negating a negative length.
c20db43f 4763
2538aa2f
PE
4764 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4765 (overrun_check_free): Likewise.
4766
f2d3008d
PE
4767 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4768 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4769 word size.
4770
ec8df744
PE
4771 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4772 (gnutls_make_error): Rename local to avoid shadowing.
4773 (gnutls_emacs_global_deinit): ifdef out; not used.
4774 (Fgnutls_boot): Use const for pointer to readonly storage.
4775 Comment out unused local. Fix pointer signedness problems.
4776
640ee02d
PE
4777 * lread.c (openp): Don't stuff size_t into an 'int'.
4778 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4779 about possible signed overflow.
4780
6048fb2a
PE
4781 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4782 (GDK_KEY_g): Don't define if already defined.
4783 (xg_prepare_tooltip): Avoid pointer signedness problem.
4784 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4785
fa3c87e1
PE
4786 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4787 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4788
2172544b
PE
4789 * xfns.c (Fx_window_property): Simplify a bit,
4790 to make a bit faster and to avoid GCC 4.6.0 warning.
4791 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4792
9b821a21
PE
4793 * fns.c (internal_equal): Don't assume size_t fits in int.
4794
3c616cfa
PE
4795 * alloc.c (compact_small_strings): Tighten assertion a little.
4796
c2982e87
PE
4797 Replace pEd with more-general pI, and fix some printf arg casts.
4798 * lisp.h (pI): New macro, generalizing old pEd macro to other
4799 conversion specifiers. For example, use "...%"pI"d..." rather
4800 than "...%"pEd"...".
4801 (pEd): Remove. All uses replaced with similar uses of pI.
4802 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4803 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4804 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4805 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4806 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4807 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4808 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4809 64-bit hosts.
4810 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4811 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4812 * print.c (safe_debug_print, print_object): Likewise.
4813 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4814 to int.
6f04d126
PE
4815 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4816 avoiding the 0 flag, which is not portable.
c2982e87
PE
4817 * process.c (Fmake_network_process): Use pI to avoid cast.
4818 * region-cache.c (pp_cache): Likewise.
4819 * xdisp.c (decode_mode_spec): Likewise.
4820 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4821 behavior on 64-bit hosts with printf arg.
6f04d126 4822 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4823 (x_stop_queuing_selection_requests): Likewise.
4824 (x_get_window_property): Don't truncate byte count to an 'int'
4825 when tracing.
0b432f21 4826
5e073ec7
PE
4827 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4828 here, since it parses constructs like leading '-' and spaces,
4829 which are not wanted; and it overflows with large numbers.
4830 Instead, simply match F[0-9]+, which is what is wanted anyway.
4831
36372bf9
PE
4832 * alloc.c: Remove unportable assumptions about struct layout.
4833 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4834 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4835 (allocate_vectorlike, make_pure_vector): Use the new macros,
4836 plus offsetof, to remove unportable assumptions about struct layout.
4837 These assumptions hold on all porting targets that I know of, but
4838 they are not guaranteed, they're easy to remove, and removing them
4839 makes further changes easier.
4840
0b432f21
PE
4841 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4842 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4843 (string_overrun_cookie): Now const. Use initializers that
4844 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4845 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4846 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4847 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4848 multiple of sizeof (EMACS_INT); it need not be, if
4849 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4850 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4851
895009e1
JB
48522011-04-26 Juanma Barranquero <lekktu@gmail.com>
4853
4854 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4855
6a7a1b0b
TZ
48562011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4857
4858 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4859 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4860 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4861
841a1577 48622011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4863
4864 * lisp.h (Qdebug): List symbol.
895009e1 4865 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4866 * keyboard.c (debug-on-event): New variable.
4867 (handle_user_signal): Break into debugger when debug-on-event
4868 matches the current signal symbol.
4869
f2d3ba6f
DN
48702011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4871
4872 * alloc.c (check_sblock, check_string_bytes)
4873 (check_string_free_list): Convert to standard C.
4874
42ce4c63
TZ
48752011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4876
4877 * w32.c (emacs_gnutls_push): Fix typo.
4878
825cd63c
EZ
48792011-04-25 Eli Zaretskii <eliz@gnu.org>
4880
fb11d64d
EZ
4881 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4882 "cast to pointer from integer of different size".
4883
825cd63c
EZ
4884 Improve doprnt and its use in verror. (Bug#8545)
4885 * doprnt.c (doprnt): Document the set of format control sequences
4886 supported by the function. Use SAFE_ALLOCA instead of always
4887 using `alloca'.
4888
4889 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4890 is one byte too soon. Don't use xrealloc; instead xfree and
4891 xmalloc anew.
4892
e061a11b
TZ
48932011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4894
4895 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4896 callbacks stage.
4897
4898 * gnutls.c: Renamed global_initialized to
4899 gnutls_global_initialized. Added internals for the
4900 :verify-hostname-error, :verify-error, and :verify-flags
4901 parameters of `gnutls-boot' and documented those parameters in the
4902 docstring. Start callback support.
9173deec
JB
4903 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4904 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4905 on error. Return error code.
e061a11b
TZ
4906 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4907 (emacs_gnutls_read): Likewise.
4908 (Fgnutls_boot): Return handshake error code.
4909 (emacs_gnutls_handle_error): New function.
4910 (wsaerror_to_errno): Likewise.
4911
4912 * w32.h (emacs_gnutls_pull): Add prototype.
4913 (emacs_gnutls_push): Likewise.
4914
4915 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4916 (emacs_gnutls_push): Likewise.
4917
49182011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4919
4920 * process.c (wait_reading_process_output): Check if GnuTLS
4921 buffered some data internally if no FDs are set for TLS
4922 connections.
4923
4924 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4925 (LIBS): Link to USER_LIBS.
4926 ($(BLD)/gnutls.$(0)): New target.
4927
fa6996bc
EZ
49282011-04-24 Eli Zaretskii <eliz@gnu.org>
4929
eb35682e
EZ
4930 * xdisp.c (handle_single_display_spec): Rename the
4931 display_replaced_before_p argument into display_replaced_p, to
4932 make it consistent with the commentary. Fix typos in the
4933 commentary.
4934
e2ad650c
EZ
4935 * textprop.c (syms_of_textprop): Remove dead code.
4936 (copy_text_properties): Delete obsolete commentary about an
4937 interface that was deleted long ago. Fix typos in the description
4938 of arguments.
4939
1b2de274
EZ
4940 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4941 to changes in oldXMenu/XMenu.h from 2011-04-16.
4942 <menu_help_message, prev_menu_help_message>: Constify.
4943 (IT_menu_make_room): menu->help_text is now `const char **';
4944 adjust.
4945
4946 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4947 to changes in oldXMenu/XMenu.h from 2011-04-16.
4948 (struct XMenu): Declare `help_text' `const char **'.
4949
4950 * xfaces.c <Qunspecified>: Make extern again.
4951
4952 * syntax.c: Include sys/types.h before including regex.h, as
4953 required by Posix.
4954
762b15be
EZ
4955 * doc.c (get_doc_string): Improve the format passed to `error'.
4956
4957 * doprnt.c (doprnt): Improve commentary.
4958
4959 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4960
4961 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4962 them with etags.
4963
f1052e5d
EZ
4964 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4965 changes in globals.h immediately force recompilation.
762b15be
EZ
4966 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4967 $(CURDIR)/s/ms-w32.h.
4968 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4969
fa6996bc
EZ
4970 * character.c (Fchar_direction): Function deleted.
4971 (syms_of_character): Don't defsubr it.
4972 <char-direction-table>: Deleted.
4973
e6c3da20
EZ
49742011-04-23 Eli Zaretskii <eliz@gnu.org>
4975
4976 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4977 * doprnt.c: Include limits.h.
4978 (SIZE_MAX): New macro.
04f2d78b
CB
4979 (doprnt): Return a size_t value. 2nd arg is now size_t.
4980 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4981 Improve overflow protection. Support `l' modifier for integer
4982 conversions. Support %l conversion. Don't assume an EMACS_INT
4983 argument for integer conversions and for %c.
4984
4985 * lisp.h (doprnt): Restore prototype.
4986
4987 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4988 $(SRC)/character.h.
4989
4990 * Makefile.in (base_obj): Add back doprnt.o.
4991
4992 * deps.mk (doprnt.o): Add back prerequisites.
4993 (callint.o): Depend on character.h.
4994
4995 * eval.c (internal_lisp_condition_case): Include the handler
4996 representation in the error message.
4997 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4998 when breaking from the loop.
4999
5000 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5001
5002 * callint.c (Fcall_interactively): When displaying error message
5003 about invalid control letter, pass the character's codepoint, not
5004 a pointer to its multibyte form. Improve display of the character
5005 in octal and display also its hex code.
5006
5007 * character.c (char_string): Use %x to display the (unsigned)
5008 codepoint of an invalid character, to avoid displaying a bogus
5009 negative value.
5010
5011 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5012 `error', not SYMBOL_NAME itself.
5013
5014 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5015 character arguments to `error'.
5016
5017 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5018 to `error' in error message about FINAL_CHAR argument. Make sure
5019 FINAL_CHAR is a character, and use %c when it is passed as
5020 argument to `error'.
5021
4ffd0d6b 50222011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5023
5024 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5025
5026 * w32.c: Include <time.h>.
5027 (sys_localtime): New function.
5028
4ffd0d6b 50292011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5030
5031 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5032
4ffd0d6b 5033 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5034
4ffd0d6b 50352011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5036
4ffd0d6b
GM
5037 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5038 zombies (Bug#8467).
aac0c6e3 5039
04c56954
EZ
50402011-04-19 Eli Zaretskii <eliz@gnu.org>
5041
5042 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5043 gl_state.e_property when gl_state.object is Qt.
5044
5045 * insdel.c (make_gap_larger): Remove limitation of buffer size
5046 to <= INT_MAX.
5047
16a43933
CY
50482011-04-18 Chong Yidong <cyd@stupidchicken.com>
5049
5050 * xdisp.c (lookup_glyphless_char_display)
5051 (produce_glyphless_glyph): Handle cons cell entry in
5052 glyphless-char-display.
5053 (Vglyphless_char_display): Document it.
5054
5055 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5056 glyphless-char-display.
5057
4581706e
CY
50582011-04-17 Chong Yidong <cyd@stupidchicken.com>
5059
5060 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5061
5062 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5063
5064 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5065 definition for no-X builds.
5066
4887c6e2 50672011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5068
fd35b6f9
PE
5069 Static checks with GCC 4.6.0 and non-default toolkits.
5070
5c1ccb01
PE
5071 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5072
006c5daa
PE
5073 * process.c (keyboard_bit_set): Define only if SIGIO.
5074 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5075 (send_process): Repair possible setjmp clobbering.
5076
efc736d3
PE
5077 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5078
4e2fe2e6
PE
5079 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5080
f97334a2
PE
5081 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5082
4e75f29d
PE
5083 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5084 Define only if needed.
5085
90efadd1
PE
5086 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5087 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5088 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5089
3c647824
PE
5090 * dispextern.h (struct redisplay_interface): Rename param
5091 to avoid shadowing.
e264f262 5092 * termhooks.h (struct terminal): Likewise.
761383f4 5093 * xterm.c (xembed_send_message): Likewise.
3c647824 5094
b58c5c4a
PE
5095 * insdel.c (make_gap_smaller): Define only if
5096 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5097
cad59032
PE
5098 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5099 it.
5100
c339dc2e
PE
5101 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5102 so that we aren't warned about unused symbols.
5103
91a3e27b
PE
5104 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5105
399c71d3 5106 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5107
8ffc96f5
PE
5108 * xfns.c (x_real_positions): Mark locals as initialized.
5109
eef9bc79
PE
5110 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5111
098db9dd
PE
5112 * xterm.c: Fix problems found by static analysis with other toolkits.
5113 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5114 (x_dispatch_event): Declare static if USE_GTK, and
5115 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5116 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5117 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5118 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5119 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5120
eb18f6cc
PE
5121 * xmenu.c (menu_help_callback): Pointer type fixes.
5122 Use const pointers when pointing at readonly data. Avoid pointer
5123 signedness clashes.
5124 (FALSE): Remove unused macro.
5125 (update_frame_menubar): Remove unused decl.
5126
1fe72bf8
PE
5127 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5128
60d9e1db
PE
5129 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5130 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5131 (single_menu_item): Rename local to avoid shadowing.
5132
39261c26
PE
5133 * keyboard.c (make_lispy_event): Remove unused local var.
5134
018c5e19
PE
5135 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5136 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5137
63d2b86e
PE
5138 * bitmaps: Change bitmaps from unsigned char back to the X11
5139 compatible char. Avoid the old compiler warnings about
5140 out-of-range initializers by using, for example, '\xab' rather
5141 than 0xab.
5142
aefd87e1
PE
5143 * xgselect.c (xgselect_initialize): Check vs interface
5144 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5145
bf501fb9
PE
5146 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5147
e9829fdf
PE
5148 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5149 to read-only memory.
5150
1086c095
PE
5151 * fns.c (vector): Remove; this old hack is no longer needed.
5152
2baccd04 5153 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5154 Remove unused var.
dde42981 5155 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5156
72391843 5157 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5158
436c16df 5159 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5160 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5161 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5162
92bb796d 5163 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5164 (x_term_init): Remove local to avoid shadowing.
92bb796d 5165
764430a3 5166 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5167
5168 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5169 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5170
d1dfb56c
EZ
51712011-04-16 Eli Zaretskii <eliz@gnu.org>
5172
c4354cb4
EZ
5173 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5174
d1dfb56c
EZ
5175 Fix regex.c, syntax.c and friends for buffers > 2GB.
5176 * syntax.h (struct gl_state_s): Declare character position members
5177 EMACS_INT.
5178
5179 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5180
04f2d78b
CB
5181 * textprop.c (verify_interval_modification, interval_of):
5182 Declare arguments EMACS_INT.
d1dfb56c
EZ
5183
5184 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5185 EMACS_INT.
5186
5187 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5188
5189 * indent.c (Fvertical_motion): Local variable it_start is now
5190 EMACS_INT.
5191
5192 * regex.c (re_match, re_match_2, re_match_2_internal)
5193 (bcmp_translate, regcomp, regexec, print_double_string)
5194 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5195 (re_compile_pattern, re_exec): Declare arguments and local
5196 variables `size_t' and `ssize_t' and return values `regoff_t', as
5197 appropriate.
5198 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5199 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5200 <compile_stack_type>: `size' and `avail' are now `size_t'.
5201
5202 * regex.h <regoff_t>: Use ssize_t, not int.
5203 (re_search, re_search_2, re_match, re_match_2): Arguments that
5204 specify buffer/string position and length are now ssize_t and
5205 size_t. Return type is regoff_t.
5206
613052cd
BK
52072011-04-16 Ben Key <bkey76@gmail.com>
5208
5209 * nsfont.m: Fixed bugs in ns_get_family and
5210 ns_descriptor_to_entity that were caused by using free to
5211 deallocate memory blocks that were allocated by xmalloc (via
5212 xstrdup). This caused Emacs to crash when compiled with
5213 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5214 --enable-checking=xmallocoverrun). xfree is now used to
5215 deallocate these memory blocks.
5216
4170f62f 52172011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5218
71b41406
PE
5219 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5220
9587a89d
PE
5221 emacs_write: Accept and return EMACS_INT for sizes.
5222 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5223 et seq.
5224 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5225 Accept and return EMACS_INT.
5226 (emacs_gnutls_write): Return the number of bytes written on
5227 partial writes.
5228 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5229 (emacs_read, emacs_write): Remove check for negative size, as the
5230 Emacs source code has been audited now.
9587a89d
PE
5231 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5232 (emacs_read, emacs_write): Use it.
273a5f82
PE
5233 * process.c (send_process): Adjust to the new signatures of
5234 emacs_write and emacs_gnutls_write. Do not attempt to store
5235 a byte offset into an 'int'; it might overflow.
9587a89d 5236 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5237
3e047f51
PE
5238 * sound.c: Don't assume sizes fit in 'int'.
5239 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5240 Return EMACS_INT, not int.
3e047f51 5241 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5242 Accept EMACS_INT, not int.
5243 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5244 record read return values.
5245
cc39a9db
BK
52462011-04-15 Ben Key <bkey76@gmail.com>
5247
c9d0ec6d
JB
5248 * keyboard.c (Qundefined): Don't declare static since it is used
5249 in nsfns.m.
5250 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5251 static since they are used in nsfont.m.
cc39a9db 5252
6c60eb9f
SM
52532011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5254
5255 * process.c (Qprocessp): Don't declare static.
5256 * lisp.h (Qprocessp): Declare again.
5257
7990b61a
JB
52582011-04-15 Juanma Barranquero <lekktu@gmail.com>
5259
5260 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5261
5d4cb038
PE
52622011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5263
8bd7b830 5264 Improve C-level modularity by making more things 'static'.
cd64ea1d 5265
e3b27b31
PE
5266 Don't publish debugger-only interfaces to other modules.
5267 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5268 (verify_bytepos, count_markers): Move decls to the only modules
5269 that need them.
5270 * region-cache.h (pp_cache): Likewise.
5271 * window.h (check_all_windows): Likewise.
5272 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5273
5d4cb038
PE
5274 * sysdep.c (croak): Now static, if
5275 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5276 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5277
5278 * alloc.c (refill_memory_reserve): Now static if
5279 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5280 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5281
e87b6180
PE
5282 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5283 Define only if USE_LUCID.
5284
ac64929e
PE
5285 * xrdb.c (x_customization_string, x_rm_string): Now static.
5286
6f37259d
PE
5287 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5288 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5289
1683e3ab
PE
5290 * xdisp.c (draw_row_with_mouse_face): Now static.
5291 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5292
de9c2632
PE
5293 * window.h (check_all_windows): Mark externally visible.
5294
2b96acb7
PE
5295 * window.c (window_deletion_count): Now static.
5296
5297 * undo.c: Make symbols static if they're not exported.
5298 (last_undo_buffer, last_boundary_position, pending_boundary):
5299 Now static.
5300
50436f33
PE
5301 * textprop.c (interval_insert_behind_hooks): Now static.
5302 (interval_insert_in_front_hooks): Likewise.
5303
64520e5c
PE
5304 * term.c: Make symbols static if they're not exported.
5305 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5306 (max_frame_lines, tty_set_terminal_modes):
5307 (tty_reset_terminal_modes, tty_turn_off_highlight):
5308 (get_tty_terminal): Now static.
5309 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5310 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5311 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5312 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5313 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5314
1fa53021
PE
5315 * sysdep.c: Make symbols static if they're not exported.
5316 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5317 Now static.
5318 (sigprocmask_set, full_mask): Remove; unused.
5319 (wait_debugging): Mark as visible.
5320 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5321 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5322
d4b43b22
PE
5323 * syntax.c (syntax_temp): Define only if !__GNUC__.
5324
b7c513d0
PE
5325 * sound.c (current_sound_device, current_sound): Now static.
5326
989b29ad
PE
5327 * search.c (searchbufs, searchbuf_head): Now static.
5328
13a55a78
PE
5329 * scroll.c (scroll_cost): Remove; unused.
5330 * dispextern.h (scroll_cost): Remove decl.
5331
de68a1fc
PE
5332 * region-cache.h (pp_cache): Mark as externally visible.
5333
40ccffa6
PE
5334 * process.c: Make symbols static if they're not exported.
5335 (process_tick, update_tick, create_process, chan_process):
5336 (Vprocess_alist, proc_buffered_char, datagram_access):
5337 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5338 (deactivate_process): Mark defn as static, as well as decl.
5339 * lisp.h (create_process): Remove decl.
5340 * process.h (chan_process, Vprocess_alist): Remove decls.
5341
ad64fc97
PE
5342 * print.c: Make symbols static if they're not exported.
5343 (print_depth, new_backquote_output, being_printed, print_buffer):
5344 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5345 (print_interval, print_number_index, initial_stderr_stream):
5346 Now static.
5347 * lisp.h (Fprinc): Remove decl.
5348 (debug_output_compilation_hack): Mark as externally visible.
5349
adddb265
PE
5350 * sysdep.c (croak): Move decl from here to syssignal.h.
5351 * syssignal.h (croak): Put it here, so the API can be checked when
5352 'croak' is called from dissociate_if_controlling_tty.
5353
1717ede2
PE
5354 * minibuf.c: Make symbols static if they're not exported.
5355 (minibuf_save_list, choose_minibuf_frame): Now static.
5356 * lisp.h (choose_minibuf_frame): Remove decl.
5357
fa5fb2bc
PE
5358 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5359
1e3890d1
PE
5360 * lread.c: Make symbols static if they're not exported.
5361 (read_objects, initial_obarray, oblookup_last_bucket_number):
5362 Now static.
5363 (make_symbol): Remove; unused.
5364 * lisp.h (initial_obarray, make_symbol): Remove decls.
5365
8a1414fa
PE
5366 * keyboard.c: Make symbols static if they're not exported.
5367 (single_kboard, recent_keys_index, total_keys, recent_keys):
5368 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5369 (this_single_command_key_start, echoing, last_auto_save):
5370 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5371 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5372 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5373 (Vlispy_mouse_stem, double_click_count):
5374 Now static.
5375 (force_auto_save_soon): Define only if SIGDANGER.
5376 (ignore_mouse_drag_p): Now static if
5377 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5378 (print_help): Remove; unused.
5379 (stop_character, last_timer_event): Mark as externally visible.
5380 * keyboard.h (ignore_mouse_drag_p): Declare only if
5381 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5382 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5383 * lisp.h (echoing): Remove decl.
5384 (force_auto_save_soon): Declare only if SIGDANGER.
5385 * xdisp.c (redisplay_window): Simplify code, to make it more
5386 obvious that ignore_mouse_drag_p is not accessed if !defined
5387 USE_GTK && !defined HAVE_NS.
5388
93ea6e8f
PE
5389 * intervals.c: Make symbols static if they're not exported.
5390 (merge_properties_sticky, merge_interval_right, delete_interval):
5391 Now static.
5392 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5393
77382fcc
PE
5394 * insdel.c: Make symbols static if they're not exported.
5395 However, leave prepare_to_modify_buffer alone. It's never
5396 called from outside this function, but that appears to be a bug.
5397 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5398 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5399 (adjust_after_replace_noundo): Remove; unused.
5400 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5401 (signal_before_change): Remove decls.
77382fcc 5402
9306c32e
PE
5403 * indent.c (val_compute_motion, val_vmotion): Now static.
5404
cd44d2eb
PE
5405 * image.c: Make symbols static if they're not exported.
5406 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5407 if USE_GTK.
5408 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5409 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5410
ad9a7a06
PE
5411 * fringe.c (standard_bitmaps): Now static.
5412 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5413
81626931
PE
5414 * frame.c: Make symbols static if they're not exported.
5415 (x_report_frame_params, make_terminal_frame): Now static.
5416 (get_frame_param): Now static, unless HAVE_NS.
5417 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5418 (x_get_resource_string): Remove; not used.
5419 * frame.h (make_terminal_frame, x_report_frame_params):
5420 (x_get_resource_string); Remove decls.
5421 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5422 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5423
239f9db9
PE
5424 * font.c, fontset.c: Make symbols static if they're not exported.
5425 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5426 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5427 * font.c (font_close_object): Now static.
5428 * font.h (font_close_object): Remove.
5429 * fontset.c (FONTSET_OBJLIST): Remove.
5430 (free_realized_fontset) #if-0 the body, which does nothing.
5431 (face_suitable_for_char_p): #if-0, as it's never called.
5432 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5433 * xfaces.c (face_at_string_position):
5434 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5435 since 0 is always ASCII.
5436
dfcf3579
PE
5437 * fns.c (weak_hash_tables): Now static.
5438
5045092b
PE
5439 * fileio.c: Make symbols static if they're not exported.
5440 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5441 (Vwrite_region_annotation_buffers): Now static.
5442
57a96f5c
PE
5443 * eval.c: Make symbols static if they're not exported.
5444 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5445 * lisp.h (backtrace_list): Remove decl.
5446
35f08c38
PE
5447 * emacs.c: Make symbols static if they're not exported.
5448 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5449 (fatal_error_code, fatal_error_signal_hook, standard_args):
5450 Now static.
5451 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5452 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5453 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5454 * lisp.h (fatal_error_signal_hook): Remove decl.
5455 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5456
f44bd759
PE
5457 * editfns.c: Move a (normally-unused) function to its only use.
5458 * editfns.c, lisp.h (get_operating_system_release): Remove.
5459 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5460 worth the hassle of breaking this out.
5461
b532497d
PE
5462 * xterm.c: Make symbols static if they're not exported.
5463 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5464 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5465 (x_destroy_window, x_delete_display):
5466 Now static.
5467 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5468 (x_mouse_leave): Remove; unused.
5469 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5470 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5471 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5472 Remove decls.
5473 (x_mouse_leave): Declare only if WINDOWSNT.
5474 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5475 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5476 USE_X_TOOLKIT.
5477
1675728f
PE
5478 * ftxfont.c: Make symbols static if they're not exported.
5479 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5480 HAVE_FREETYPE.
5481 * font.h (ftxfont_driver): Likewise.
5482
e4cebfca
PE
5483 * xfns.c: Make symbols static if they're not exported.
5484 (x_last_font_name, x_display_info_for_name):
5485 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5486 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5487 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5488 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5489 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5490 (last_show_tip_args): Now static.
5491 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5492 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5493 (x_screen_planes): Remove; unused.
5494 * dispextern.h (x_screen_planes): Remove decl.
5495
5bf46f05
PE
5496 * dispnew.c: Make symbols static if they're not exported.
5497 * dispextern.h (redraw_garbaged_frames, scrolling):
5498 (increment_row_positions): Remove.
5499 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5500 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5501 Now static.
5502 (redraw_garbaged_frames): Remove; unused.
5503
435f4c28
PE
5504 * xfaces.c: Make symbols static if they're not exported.
5505 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5506 Remove decls.
5507 * xterm.h (defined_color): Remove decls.
5508 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5509 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5510 (menu_face_changed_default, defined_color, free_realized_face):
5511 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5512 (ascii_face_of_lisp_face): Remove; unused.
5513
8524aef3
PE
5514 * xdisp.c: Make symbols static if they're not exported.
5515 * dispextern.h (scratch_glyph_row, window_box_edges):
5516 (glyph_to_pixel_coords, set_cursor_from_row):
5517 (get_next_display_element, set_iterator_to_next):
5518 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5519 (show_mouse_face): Remove decls
5520 * frame.h (message_buf_print): Likewise.
5521 * lisp.h (pop_message, set_message, check_point_in_composition):
5522 Likewise.
5523 * xterm.h (set_vertical_scroll_bar): Likewise.
5524 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5525 (message_buf_print, scratch_glyph_row, displayed_buffer):
5526 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5527 (get_next_display_element, show_mouse_face, window_box_edges):
5528 (frame_to_window_pixel_xy, check_point_in_composition):
5529 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5530 (glyph_to_pixel_coords): Remove; unused.
5531
16390cd2
PE
5532 * dired.c (file_name_completion): Now static.
5533
5534 * dbusbind.c (xd_in_read_queued_messages): Now static.
5535
a25f4dfa
PE
5536 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5537 * data.c (circular_list_error): Remove.
5538
14a9c8df
PE
5539 * commands.h (last_point_position, last_point_position_buffer):
5540 (last_point_position_window): Remove decls.
5541 * keyboard.c: Make these variables static.
5542
04f2d78b
CB
5543 * coding.h (coding, code_convert_region, encode_coding_gap):
5544 Remove decls.
74ab6df5
PE
5545 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5546 (iso_code_class, detect_coding, code_convert_region): Now static.
5547 (encode_coding_gap): Remove; unused.
5548
38dfbee1
PE
5549 * chartab.c (chartab_chars, chartab_bits): Now static.
5550
a2cb4e63
PE
5551 * charset.h (charset_iso_8859_1): Remove decl.
5552 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5553 Now static.
5554
127198fd
PE
5555 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5556 * ccl.c (Vccl_program_table): Now static.
5557 (check_ccl_update): Remove; unused.
5558
d85b608f
PE
5559 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5560 * category.h: ... from here.
5561 * category.c (check_category_table, set_category_set): Now static.
5562
31cd66f3
PE
5563 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5564 * lisp.h: Remove these decls.
5565
c358e587
PE
5566 * buffer.c (buffer_count): Remove unused var.
5567
e78aecca
PE
5568 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5569 so that it's not optimized away.
5570 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5571 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5572 exported only to the debugger.
5573
e192d7d3 5574 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5575 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5576
92470028
PE
5577 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5578 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5579 was inaccessible from Lisp.
5580 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5581 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5582
244ed907
PE
5583 alloc.c: Import and export fewer symbols, and remove unused items.
5584 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5585 is defined.
5586 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5587 it's not optimized away by whole-program optimization.
5588 (message_enable_multibyte, free_misc): Remove.
5589 (catchlist, handlerlist, mark_backtrace):
5590 Declare only if BYTE_MARK_STACK.
5591 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5592 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5593 (message_enable_multibyte): Remove decl.
5594 (free_misc, interval_free_list, float_block, float_block_index):
5595 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5596 (cons_free_list, last_marked_index):
5597 Now static.
5598 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5599 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5600 (mark_backtrace): Define only if BYTE_MARK_STACK.
5601 * xdisp.c (message_enable_multibyte): Now static.
5602
61c2b50e 5603 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5604 This makes it easier for human readers (and static analyzers)
5605 to see whether these variables are used from other modules.
5606 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5607 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5608 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5609 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5610 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5611 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5612 * xmenu.c, xselect.c:
5613 Declare Q* vars static if they are not used in other modules.
5614 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5615 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5616 Remove decls of unexported vars.
5617 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5618
95c82688
PE
5619 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5620
16a97296
PE
5621 Make Emacs functions such as Fatom 'static' by default.
5622 This makes it easier for human readers (and static analyzers)
5623 to see whether these functions can be called from other modules.
5624 DEFUN now defines a static function. To make the function external
5625 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5626 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5627 (Finit_image_library):
16a97296
PE
5628 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5629 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5630 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5631 Remove decls, since these functions are now static.
5632 (Funintern, Fget_internal_run_time): New decls, since these functions
5633 were already external.
95c82688 5634
16a97296
PE
5635 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5636 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5637 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5638 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5639 * keyboard.c, keymap.c, lread.c:
5640 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5641 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5642 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5643 Mark functions with DEFUE instead of DEFUN,
5644 if they are used in other modules.
5645 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5646 decls for now-static functions.
5647 * buffer.h (Fdelete_overlay): Remove decl.
5648 * callproc.c (Fgetenv_internal): Mark as internal.
5649 * composite.c (Fremove_list_of_text_properties): Remove decl.
5650 (Fcomposition_get_gstring): New forward static decl.
5651 * composite.h (Fcomposite_get_gstring): Remove decl.
5652 * dired.c (Ffile_attributes): New forward static decl.
5653 * doc.c (Fdocumntation_property): New forward static decl.
5654 * eval.c (Ffetch_bytecode): New forward static decl.
5655 (Funintern): Remove extern decl; now in .h file where it belongs.
5656 * fileio.c (Fmake_symbolic_link): New forward static decl.
5657 * image.c (Finit_image_library): New forward static decl.
5658 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5659 * intervals.h (Fprevious_property_change):
5660 (Fremove_list_of_text_properties): Remove decls.
5661 * keyboard.c (Fthis_command_keys): Remove decl.
5662 (Fcommand_execute): New forward static decl.
5663 * keymap.c (Flookup_key): New forward static decl.
5664 (Fcopy_keymap): Now static.
5665 * keymap.h (Flookup_key): Remove decl.
5666 * process.c (Fget_process): New forward static decl.
5667 (Fprocess_datagram_address): Mark as internal.
5668 * syntax.c (Fsyntax_table_p): New forward static decl.
5669 (skip_chars): Remove duplicate decl.
5670 * textprop.c (Fprevious_property_change): New forward static decl.
5671 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5672 Now internal.
5673 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5674 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5675
785bbd42
PE
5676 * editfns.c (Fformat): Remove unreachable code.
5677
8b913b57
AS
56782011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5679
5680 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5681 change. (Bug#8496)
5682
a6744a35
EZ
56832011-04-13 Eli Zaretskii <eliz@gnu.org>
5684
5685 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5686 when at ZV. (Bug#8487)
5687
e7974947
AS
56882011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5689
baad03f0
AS
5690 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5691 (Bug#8437)
5692 * keyboard.c (parse_tool_bar_item): Likewise.
5693 * sound.c (sound_cleanup, alsa_close): Likewise.
5694 * termcap.c (tgetent): Likewise.
5695 * xfns.c (x_default_font_parameter): Likewise.
5696 * xsettings.c (read_and_apply_settings): Likewise.
5697
e7974947
AS
5698 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5699 (overrun_check_free): Protoize.
5700
28272684
PE
57012011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5702
5703 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5704 since callers should never pass a negative size.
5705 Change the signature to match that of plain 'read' and 'write'; see
5706 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5707 * lisp.h: Update prototypes of emacs_write and emacs_read.
5708
11997c76
EZ
57092011-04-11 Eli Zaretskii <eliz@gnu.org>
5710
5711 * xdisp.c (redisplay_window): Don't try to determine the character
5712 position of the scroll margin if the window start point w->startp
e896f03c 5713 is outside the buffer's accessible region. (Bug#8468)
11997c76 5714
8a2cbd72
EZ
57152011-04-10 Eli Zaretskii <eliz@gnu.org>
5716
5717 Fix write-region and its subroutines for buffers > 2GB.
5718 * fileio.c (a_write, e_write): Modify declaration of arguments and
5719 local variables to support buffers larger than 2GB.
5720 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5721
5722 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5723 argument, local variables, and return value.
5724
5725 * lisp.h: Update prototypes of emacs_write and emacs_read.
5726
5727 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5728
4073e537 57292011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5730
1ebfdcb6
PE
5731 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5732
b2ded58d
PE
5733 Fix more problems found by GCC 4.6.0's static checks.
5734
7d66342c
PE
5735 * xdisp.c (vmessage): Use a better test for character truncation.
5736
bbf47d44
PE
5737 * charset.c (load_charset_map): <, not <=, for optimization,
5738 and to avoid potential problems with integer overflow.
9248994d 5739 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5740 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5741 * editfns.c (Fformat): Likewise.
1e69125e 5742 * syntax.c (skip_chars): Likewise.
3befa583 5743
e3019616
PE
5744 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5745 This also lets GCC 4.6.0 generate slightly better loop code.
5746
becfa255
PE
5747 * callint.c (Fcall_interactively): <, not <=, for optimization.
5748 (Fcall_interactively): Count the number of arguments produced,
5749 not the number of arguments given. This is simpler and lets GCC
5750 4.6.0 generate slightly better code.
5751
dae0cd48
PE
5752 * ftfont.c: Distingish more carefully between FcChar8 and char.
5753 The previous code passed unsigned char * to a functions like
5754 strlen and xstrcasecmp that expect char *, which does not
5755 conform to the C standard.
5756 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5757 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5758 char * when the C standard requires it.
5759
76032d70
PE
5760 * keyboard.c (read_char): Remove unused var.
5761
eb3f1cc8
PE
5762 * eval.c: Port to Windows vsnprintf (Bug#8435).
5763 Include <limits.h>.
5764 (SIZE_MAX): Define if the headers do not.
5765 (verror): Do not give up if vsnprintf returns a negative count.
5766 Instead, grow the buffer. This ports to Windows vsnprintf, which
5767 does not conform to C99. Problem reported by Eli Zaretskii.
5768 Also, simplify the allocation scheme, by avoiding the need for
5769 calling realloc, and removing the ALLOCATED variable.
5770
70476b54
PE
5771 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5772
12020a9e
PE
5773 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5774 But keep the doprint source code for now, as we might revamp it
5775 and use it again (Bug#8435).
ea6c7ae6
PE
5776 * lisp.h (doprnt): Remove.
5777 * Makefile.in (base_obj): Remove doprnt.o.
5778 * deps.mk (doprnt.o): Remove.
5779
5fdb398c
PE
5780 error: Print 32- and 64-bit integers portably (Bug#8435).
5781 Without this change, on typical 64-bit hosts error ("...%d...", N)
5782 was used to print both 32- and 64-bit integers N, which relied on
5783 undefined behavior.
5784 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5785 New macro.
5786 * lisp.h (error, verror): Mark as printf-like functions.
5787 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5788 Report overflow in size calculations when allocating printf buffer.
5789 Do not truncate output string at its first null byte.
5790 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5791 Truncate the output at a character boundary, since vsnprintf does not
5792 do that.
5793 * charset.c (check_iso_charset_parameter): Convert internal
5794 character to string before calling 'error', since %c now has the
5795 printf meaning.
5796 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5797 overflow when computing char to be passed to 'error'. Do not
5798 pass Lisp_Object to 'error'; pass the integer instead.
5799 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5800 formatted with plain %d.
5801
b189fa66
PE
5802 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5803
bff87ef0
PE
5804 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5805
7e2cac20
PE
5806 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5807
ce4d90b5
PE
5808 * xterm.c (x_catch_errors): Remove duplicate declaration.
5809
266c9547
PE
5810 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5811
79c49ad2
PE
5812 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5813
368f4090
JM
58142011-04-10 Jim Meyering <meyering@redhat.com>
5815
5816 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5817 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5818 return ssize_t not "int", and use size_t as the buffer length.
5819 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5820 * gnutls.h: Update declarations.
5821 * process.c (read_process_output): Use ssize_t, to match.
5822 (send_process): Likewise.
5823
a32d4040
CY
58242011-04-09 Chong Yidong <cyd@stupidchicken.com>
5825
5826 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5827
8546720e 58282011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5829
04f2d78b
CB
5830 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5831 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5832
8546720e
GM
5833 * xterm.c (handle_one_xevent):
5834 * xmenu.c (create_and_show_popup_menu):
5835 * xselect.c (x_decline_selection_request)
5836 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5837
0a2f5c1a 58382011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5839
5840 Fix some uses of `int' instead of EMACS_INT.
5841 * search.c (string_match_1, fast_string_match)
5842 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5843 (scan_buffer, find_next_newline_no_quit)
5844 (find_before_next_newline, search_command, Freplace_match)
5845 (Fmatch_data): Make some `int' variables be EMACS_INT.
5846
5847 * xdisp.c (display_count_lines): 3rd argument and return value now
5848 EMACS_INT. All callers changed.
5849 (pint2hrstr): Last argument is now EMACS_INT.
5850
5851 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5852 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5853 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5854 (decode_coding_utf_16, decode_coding_emacs_mule)
5855 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5856 (decode_coding_ccl, decode_coding_charset)
5857 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5858 (decode_coding_iso_2022, decode_coding_emacs_mule)
5859 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5860 <char_offset, last_offset>: Declare EMACS_INT.
5861 (encode_coding_utf_8, encode_coding_utf_16)
5862 (encode_coding_emacs_mule, encode_invocation_designation)
5863 (encode_designation_at_bol, encode_coding_iso_2022)
5864 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5865 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5866 Declare EMACS_INT.
5867 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5868 (encode_invocation_designation): Last argument P_NCHARS is now
5869 EMACS_INT.
5870 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5871 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5872
5873 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5874 All users changed.
5875
5876 * ccl.c (Fccl_execute_on_string): Declare some variables
5877 EMACS_INT.
5878
8546720e 58792011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5880
5881 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5882
4e19a977
CS
58832011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5884
5885 * process.c (Fformat_network_address): Doc fix.
5886
87302331
R
58872011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5888
5889 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5890
cbb59342
CY
58912011-04-08 Chong Yidong <cyd@stupidchicken.com>
5892
5893 * keyboard.c (read_char): Call Lisp function help-form-show,
5894 instead of using internal_with_output_to_temp_buffer.
5895 (Qhelp_form_show): New var.
e0d38eeb 5896 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5897
5898 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5899
5900 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5901
e67a13ab
CY
59022011-04-06 Chong Yidong <cyd@stupidchicken.com>
5903
04f2d78b
CB
5904 * process.c (Flist_processes): Remove to Lisp.
5905 (list_processes_1): Delete.
e67a13ab 5906
973f782d
EZ
59072011-04-06 Eli Zaretskii <eliz@gnu.org>
5908
7c106b1e
EZ
5909 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5910
973f782d
EZ
5911 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5912
41cf7d1a 59132011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5914
ca23cc88
PE
5915 Fix more problems found by GCC 4.6.0's static checks.
5916
f390e2d5
PE
5917 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5918
42eea0d0
PE
5919 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5920
b69769da 5921 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5922
f9541e84
PE
5923 * xdisp.c (vmessage): Mark as a printf-like function.
5924
13841b55
PE
5925 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5926
c136c10f
PE
5927 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5928
5e2d4a30
PE
5929 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5930 printf-like functions.
5931 (tiff_load): Add casts to remove these marks before passing them
5932 to system-supplied API.
5933
583f48b9
PE
5934 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5935
b25d760e
PE
5936 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5937 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5938 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5939 directly, rather than having caller test rule sign. This avoids
5940 some unnecessary tests.
5941 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5942 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5943 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5944
bc7b6697 5945 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5946 (xfont_open): Avoid unnecessary tests.
bc7b6697 5947
27ccc379
PE
5948 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5949
dcd5c89a
PE
5950 * composite.h, composite.c (composition_gstring_put_cache):
5951 Use EMACS_INT, not int, for length.
5952
b13a45c6
PE
5953 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5954 breaking out part of COMPOSITION_DECODE_RULE.
5955 (COMPOSITION_DECODE_RULE): Use it.
5956 * composite.c (get_composition_id): Remove unused local vars,
5957 by using the new macro.
5958
1e792e4d
PE
5959 * textprop.c (set_text_properties_1): Change while to do-while,
5960 since the condition is always true at first.
5961
dc6c6455 5962 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5963 (interval_deletion_adjustment): Return unsigned value.
5964 All uses changed.
dc6c6455 5965
aba7731a
PE
5966 * process.c (list_processes_1, create_pty, read_process_output):
5967 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5968 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5969 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5970 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5971 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5972
fdfc4bf3
PE
5973 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5974
fca8fe46 5975 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5976 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5977
06a0259a 5978 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5979 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5980 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5981
e7b9e80f
PE
5982 * print.c (print_error_message): Avoid int overflow.
5983
56201685
PE
5984 * font.c (font_list_entities): Redo for clarity,
5985 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5986
78834453 5987 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5988 (font_score): Avoid potential overflow in diff calculation.
78834453 5989
0bc0b309 5990 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5991 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5992
e610eaca
PE
5993 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5994
b895abce
PE
5995 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5996 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5997 can always succeed if overflow has undefined behavior.
5998
1f1d9321 5999 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6000 (wordify): Omit three unnecessary tests.
1f1d9321 6001
c59478bc
PE
6002 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6003 All callers changed. This avoids the need for an unused var.
6004
79b73827
PE
6005 * casefiddle.c (casify_region): Remove var that is set but not used.
6006
a4db5dfe
PE
6007 * dired.c (file_name_completion): Remove var that is set but not used.
6008
43aae36e
PE
6009 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6010
2a47c44d 6011 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6012 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6013
a37c69bf
PE
6014 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6015 Check for integer overflow on size calculations.
6016
328ab8e7
PE
6017 * buffer.c (Fprevious_overlay_change): Remove var that is set
6018 but not used.
6019
e5a2a5cb
PE
6020 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6021 Remove vars that are set but not used.
8d84a6eb 6022 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6023 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6024
a60e5f68
PE
6025 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6026
f661cb61 6027 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6028 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6029
f0397f5a
PE
6030 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6031 that are set but not used.
6032
8664db06 6033 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6034 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6035
6abdaa4a
PE
6036 * xselect.c (x_get_local_selection, x_handle_property_notify):
6037 Remove vars that are set but not used.
6038
0ce7538d 6039 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6040 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6041
9ae848fc
PE
6042 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6043 Remove var that is set but not used.
0b918413
PE
6044 (scroll_bar_windows_size): Now size_t, not int.
6045 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6046 Check for overflow.
9ae848fc 6047
a5a62657
PE
6048 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6049 (map_tty_color) [!defined MSDOS]: Likewise.
6050
5c5cdd39
PE
6051 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6052
66ebf983
PE
6053 * coding.c: Remove vars that are set but not used.
6054 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6055 All callers changed.
6056 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6057 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6058 (decode_coding_charset): Remove vars that are set but not used.
6059
1be4d761
PE
6060 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6061 that is set but not used.
6062
47553fa8
PE
6063 * print.c (print_object): Remove var that is set but not used.
6064
1f7196bf 6065 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6066 The gnulib version avoids calling malloc in the usual case,
6067 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6068 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6069 * filelock.c (current_lock_owner): Likewise.
6070 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6071 * sysdep.c: Include allocator.h, careadlinkat.h.
6072 (emacs_no_realloc_allocator): New static constant.
6073 (emacs_readlink): New function.
fdb61804
PE
6074 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6075 ../lib/careadlinkat.h.
d1fdcab7 6076
f84c17c7
SM
60772011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6078
6079 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6080 first non-nil return value).
6081
ef3862ad
JD
60822011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6083
6084 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6085 if not defined (Bug#8403).
6086
376a7006
JB
60872011-04-02 Juanma Barranquero <lekktu@gmail.com>
6088
6089 * xdisp.c (display_count_lines): Remove parameter `start',
6090 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6091 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6092 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6093 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6094 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6095 and thereabouts. All callers changed.
6096 (get_per_char_metric): Remove parameter `f', unused since
6097 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6098
6ca3801d
JM
60992011-04-02 Jim Meyering <meyering@redhat.com>
6100
6101 do not dereference NULL upon failed strdup
6102 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6103 (ns_get_family): Likewise.
6104
d8e2b5ba
JB
61052011-04-02 Juanma Barranquero <lekktu@gmail.com>
6106
6107 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6108
8c74fcbd
JD
61092011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6110
6111 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6112 later (Bug#8403).
6113
7200d79c
SM
61142011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6115
03408648 6116 Add lexical binding.
7200d79c 6117
03408648
SM
6118 * window.c (Ftemp_output_buffer_show): New fun.
6119 (Fsave_window_excursion):
6120 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6121
6122 * lread.c (lisp_file_lexically_bound_p): New function.
6123 (Fload): Bind Qlexical_binding.
6124 (readevalloop): Remove `evalfun' arg.
6125 Bind Qinternal_interpreter_environment.
6126 (Feval_buffer): Bind Qlexical_binding.
6127 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6128 Mark as dynamic.
6129 (syms_of_lread): Declare `lexical-binding'.
6130
6131 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6132
6133 * keyboard.c (eval_dyn): New fun.
6134 (menu_item_eval_property): Use it.
ca105506
SM
6135
6136 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6137
03408648
SM
6138 * fns.c (concat, mapcar1): Accept byte-code-functions.
6139
6140 * eval.c (Fsetq): Handle lexical vars.
6141 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6142 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6143 (FletX, Flet): Obey lexical binding.
6144 (Fcommandp): Handle closures.
6145 (Feval): New `lexical' arg.
6146 (eval_sub): New function extracted from Feval. Use it almost
6147 everywhere where Feval was used. Look up vars in lexical env.
6148 Handle closures.
6149 (Ffunctionp): Move from subr.el.
6150 (Ffuncall): Handle closures.
6151 (apply_lambda): Remove `eval_flags'.
6152 (funcall_lambda): Handle closures and new byte-code-functions.
6153 (Fspecial_variable_p): New function.
6154 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6155 but without exporting it to Lisp.
23aba0ea 6156
23aba0ea 6157 * doc.c (Fdocumentation, store_function_docstring):
03408648 6158 * data.c (Finteractive_form): Handle closures.
23aba0ea 6159
03408648
SM
6160 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6161 interactive spec.
ba83908c 6162
04f2d78b
CB
6163 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6164 New byte-codes.
03408648
SM
6165 (exec_byte_code): New function extracted from Fbyte_code to handle new
6166 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6167
03408648 6168 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6169
03408648 6170 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6171
e2abce01
JB
61722011-03-31 Juanma Barranquero <lekktu@gmail.com>
6173
6174 * xdisp.c (redisplay_internal): Fix prototype.
6175
63696a73 61762011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6177
63696a73 6178 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6179 (try_scrolling): Use it when setting scroll_limit.
6180 Limit scrolling to 100 screen lines.
63696a73
EZ
6181 (redisplay_window): Even when falling back on "recentering",
6182 position point in the window according to scroll-conservatively,
6183 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6184
6185 (try_scrolling): When point is above the window, allow searching
6186 as far as scroll_max, or one screenful, to compute vertical
6187 distance from PT to the scroll margin position. This prevents
6188 try_scrolling from unnecessarily failing when
6189 scroll-conservatively is set to a value slightly larger than the
6190 window height. Clean up the case of PT below the margin at bottom
6191 of window: scroll_max can no longer be INT_MAX. When aggressive
6192 scrolling is in use, don't let point enter the opposite scroll
6193 margin as result of the scroll.
6194 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6195 threshold of 100 lines for never-recentering scrolling.
6196
e4cc2dfc
JB
61972011-03-31 Juanma Barranquero <lekktu@gmail.com>
6198
6199 * dispextern.h (move_it_by_lines):
6200 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6201 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6202 (message_log_check_duplicate): Remove parameters `prev_bol' and
6203 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6204 (redisplay_internal): Remove parameter `preserve_echo_area',
6205 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6206
6207 * indent.c (Fvertical_motion):
6208 * window.c (window_scroll_pixel_based, Frecenter):
6209 Don't pass `need_y_p' to `move_it_by_lines'.
6210
1c470562
SM
62112011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6212
44f230aa
SM
6213 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6214 steal a few bits to be more compact.
6215 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6216 Remove unneeded casts.
6217
1c470562
SM
6218 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6219
888adce9
ZK
62202011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6221
6222 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6223 binding" message (bug#7967).
6224
f838ed7b
PE
62252011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6226
77861b95
PE
6227 Fix more problems found by GCC 4.6.0's static checks.
6228
de6dbc14
PE
6229 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6230 Remove unused local var.
6231
f838ed7b
PE
6232 * editfns.c (Fmessage_box): Remove unused local var.
6233
792c7b2b
PE
6234 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6235 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6236 Omit unused local vars.
c499e557 6237 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6238 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6239 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6240 Omit unused local var.
6241
ba0165e1
PE
6242 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6243 Don't assume string length fits in int.
32ad8845 6244 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6245 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6246
3c59b4c9
PE
6247 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6248 instead of alloca (Bug#8344).
6249
a3eed478 6250 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6251 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6252
eb4d412d
PE
6253 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6254
1658b401
PE
6255 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6256 concerns.
6257
6258 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6259
6260 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6261
9a2c6e05
PE
6262 * keyboard.c (syms_of_keyboard): Use the same style as later
6263 in this function when indexing through an array. This also
6264 works around GCC bug 48267.
6265
03d0a109
PE
6266 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6267
44f730c8
PE
6268 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6269
fe75f926
PE
6270 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6271 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6272
ffa8c828
PE
6273 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6274 This avoids undefined behavior on integer overflow, and is a bit
6275 more convenient anyway since it is compared to a size_t variable.
6276
c5101a77
PE
6277 Variadic C functions now count arguments with size_t, not int.
6278 This avoids an unnecessary limitation on 64-bit machines, which
6279 caused (substring ...) to crash on large vectors (Bug#8344).
6280 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6281 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6282 All variadic functions and their callers changed accordingly.
c5101a77
PE
6283 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6284 * data.c (arith_driver, float_arith_driver): Likewise.
6285 * editfns.c (general_insert_function): Likewise.
6286 * eval.c (struct backtrace.nargs, interactive_p)
6287 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6288 (funcall_lambda, mark_backtrace): Likewise.
6289 * fns.c (concat): Likewise.
6290 * frame.c (x_set_frame_parameters): Likewise.
6291 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6292 0 if not found, not -1. All callers changed.
6293
dd3f25f7
PE
6294 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6295 (stack_copy_size): Now size_t, not int.
6296 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6297
461c2ab9
JB
62982011-03-28 Juanma Barranquero <lekktu@gmail.com>
6299
6300 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6301 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6302 All callers changed.
6303
6304 * lisp.h (multibyte_char_to_unibyte):
6305 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6306 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6307 * character.h (CHAR_TO_BYTE8):
6308 * cmds.c (internal_self_insert):
6309 * editfns.c (general_insert_function):
6310 * keymap.c (push_key_description):
6311 * search.c (Freplace_match):
6312 * xdisp.c (message_dolog, set_message_1): All callers changed.
6313
f6d62986
SM
63142011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6315
6316 * keyboard.c (safe_run_hook_funcall): New function.
6317 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6318 don't set the hook to nil, but remove the offending function instead.
6319 (Qcommand_hook_internal): Remove, unused.
6320 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6321 Vcommand_hook_internal.
6322
6323 * eval.c (enum run_hooks_condition): Remove.
6324 (funcall_nil, funcall_not): New functions.
6325 (run_hook_with_args): Call each function through a `funcall' argument.
6326 Remove `cond' argument, now redundant.
6327 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6328 (Frun_hook_with_args_until_failure): Adjust accordingly.
6329 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6330
1db5b1ad
JB
63312011-03-28 Juanma Barranquero <lekktu@gmail.com>
6332
6333 * dispextern.h (string_buffer_position): Remove declaration.
6334
6335 * print.c (strout): Remove parameter `multibyte', unused since
6336 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6337
6338 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6339 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6340 All callers changed.
6341
6342 * w32.c (_wsa_errlist): Use braces for struct initializers.
6343
6344 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6345 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6346 All callers changed.
6347 (string_buffer_position): Likewise. Also, make static (it's never
6348 used outside xdisp.c).
6349 (cursor_row_p): Remove parameter `w', unused since
6350 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6351 (decode_mode_spec): Remove parameter `precision', introduced during
6352 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6353 All callers changed.
6354
5ffb62aa
JD
63552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6356
6357 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6358
461c2ab9 63592011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6360
6361 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6362 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6363 (ns_update_auto_hide_menu_bar): New functions.
6364 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6365 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6366 ns_constrain_all_frames.
6367 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6368 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6369
5c380ffb
JD
63702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6371
6372 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6373
9af30bdf
GM
63742011-03-27 Glenn Morris <rgm@gnu.org>
6375
6376 * syssignal.h: Replace RETSIGTYPE with void.
6377 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6378 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6379 Replace SIGTYPE with void everywhere.
6380 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6381 * s/template.h (SIGTYPE): Remove commented out definition.
6382
e2abce01
JB
63832011-03-26 Eli Zaretskii <eliz@gnu.org>
6384
6385 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6386 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6387
f868cd8a
JB
63882011-03-26 Juanma Barranquero <lekktu@gmail.com>
6389
59eb0929
JB
6390 * w32.c (read_unc_volume): Use parameter `henum', instead of
6391 global variable `wget_enum_handle'.
6392
6393 * keymap.c (describe_vector): Remove parameters `indices' and
6394 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6395 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6396
f868cd8a
JB
6397 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6398
6399 * keyboard.c (timer_check): Remove parameter `do_it_now',
6400 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6401 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6402 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6403
6404 * keyboard.c (read_char):
6405 * w32menu.c (w32_menu_display_help):
6406 * xmenu.c (show_help_event, menu_help_callback):
6407 Adjust calls to `show_help_echo'.
6408
6409 * gtkutil.c (xg_maybe_add_timer):
6410 * keyboard.c (readable_events):
6411 * process.c (wait_reading_process_output):
6412 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6413
6414 * insdel.c (adjust_markers_gap_motion):
6415 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6416 (gap_left, gap_right): Don't call it.
6417
2ecf6fdb
CY
64182011-03-25 Chong Yidong <cyd@stupidchicken.com>
6419
6420 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6421 incurred during fontification.
6422
6b1f9ba4
JB
64232011-03-25 Juanma Barranquero <lekktu@gmail.com>
6424
6425 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6426 (DEFVAR_PER_BUFFER): Don't pass it.
6427
6428 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6429 (scrolling_window): Don't pass it.
6430
0f4a96b5
JB
64312011-03-25 Juanma Barranquero <lekktu@gmail.com>
6432
6433 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6434
6435 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6436 and `suffix'.
6437 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6438 of variables specific to SELinux and computation of `encoded_absname'.
6439
6440 * image.c (XPutPixel): Remove unused variable `height'.
6441
6442 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6443
6444 * unexw32.c (get_section_info): Remove unused variable `section'.
6445
6446 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6447 (system_process_attributes): Remove unused variable `sess'.
6448 (sys_read): Remove unused variable `err'.
6449
6450 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6451 (w32_wnd_proc): Remove unused variable `isdead'.
6452 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6453 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6454 (x_create_tip_frame): Remove unused variable `tem'.
6455
6456 * w32inevt.c (w32_console_read_socket):
6457 Remove unused variable `no_events'.
6458
6459 * w32term.c (x_draw_composite_glyph_string_foreground):
6460 Remove unused variable `width'.
6461
1149507c
JB
64622011-03-24 Juanma Barranquero <lekktu@gmail.com>
6463
6464 * w32term.c (x_set_glyph_string_clipping):
6465 Don't pass uninitialized region to CombineRgn.
6466
9c88f339
JB
64672011-03-23 Juanma Barranquero <lekktu@gmail.com>
6468
6469 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6470 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6471 (Fx_close_connection): Remove unused variable `i'.
6472
6473 * w32font.c (w32font_draw): Return number of glyphs.
6474 (w32font_open_internal): Remove unused variable `i'.
6475 (w32font_driver): Add missing initializer.
6476
6477 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6478 (fill_in_menu): Remove unused variable `items_added'.
6479
6480 * w32term.c (last_mouse_press_frame): Remove static global variable.
6481 (w32_clip_to_row): Remove unused variable `f'.
6482 (x_delete_terminal): Remove unused variable `i'.
6483
6484 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6485 (NOTHING): Remove unused static global variable.
6486 (uniscribe_check_otf): Remove unused variable `table'.
6487 (uniscribe_font_driver): Add missing initializers.
6488
dee091a3
JD
64892011-03-23 Julien Danjou <julien@danjou.info>
6490
6491 * term.c (Fsuspend_tty, Fresume_tty):
6492 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6493 * window.c (temp_output_buffer_show):
6494 * insdel.c (signal_before_change):
6495 * frame.c (Fhandle_switch_frame):
6496 * fileio.c (Fdo_auto_save):
6497 * emacs.c (Fkill_emacs):
6498 * editfns.c (save_excursion_restore):
6499 * cmds.c (internal_self_insert):
6500 * callint.c (Fcall_interactively):
6501 * buffer.c (Fkill_all_local_variables):
6502 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6503 Use Frun_hooks.
0f4a96b5 6504 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6505 unconditionnaly since it does the check itself.
6506
2c520ab5 65072011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6508
c9c49752
PE
6509 Fix more problems found by GCC 4.5.2's static checks.
6510
8abc3f12
PE
6511 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6512 the first time through the loop, since we know p0 < p1 then.
6513 This also avoids a gcc -Wstrict-overflow warning.
6514
a2d26660
PE
6515 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6516 leading to a memory leak, possible in functions like
6517 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6518 of objects (Bug#8318).
a2d26660 6519
916c72e9
PE
6520 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6521 that could (at least in theory) be that large.
6522
19ab8a18
PE
6523 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6524 This is less likely to overflow, and avoids undefined behavior if
6525 overflow does occur. All callers changed. Use strtoul to scan
6526 for the unsigned long integer.
b7cbbd6f
PE
6527 (pint2hrstr): Simplify and tune code slightly.
6528 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6529
f0641eff
PE
6530 * scroll.c (do_scrolling): Work around GCC bug 48228.
6531 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6532
7f650bb9
PE
6533 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6534 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6535 (validate_x_resource_name): Simplify count usage.
6536 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6537
37dd57d1
PE
6538 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6539 fail (Bug#8306).
81e56e61 6540
699979fc 6541 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6542
401bf9b4
PE
6543 * process.c (Fmake_network_process): Use socklen_t, not int,
6544 where POSIX says socklen_t is required in portable programs.
6545 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6546 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6547 (Fmake_network_process, server_accept_connection):
6548 (wait_reading_process_output, read_process_output):
6549 Likewise.
6550
b93aacde
PE
6551 * process.c: Rename or move locals to avoid shadowing.
6552 (list_processes_1, Fmake_network_process):
6553 (read_process_output_error_handler, exec_sentinel_error_handler):
6554 Rename or move locals.
4dc343ee 6555 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6556 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6557 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6558 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6559 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6560
af8a867c 6561 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6562 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6563 Include tparam.h instead, since it declares them.
af8a867c
PE
6564 * cm.h (PC): Remove extern decl; tparam.h now does this.
6565 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6566 * terminfo.c: Include tparam.h, to check interfaces.
6567 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6568 (tparam): Adjust signature to match interface in tparam.h;
6569 this removes some undefined behavior. Check that outstring and len
6570 are zero, which they always are with Emacs.
6571 * tparam.h (PC, BC, UP): New extern decls.
6572
0248044d 6573 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6574 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6575
8ff096c1 6576 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6577 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6578 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6579 (ftfont_list): Remove unused local.
49eaafba
PE
6580 (get_adstyle_property, ftfont_pattern_entity):
6581 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6582 Rename locals to avoid shadowing.
8ff096c1 6583
e2be39f6
PE
6584 * xfont.c (xfont_list_family): Mark var as initialized.
6585
c9735e30
PE
6586 * xml.c (make_dom): Now static.
6587
8f5201ae
PE
6588 * composite.c (composition_compute_stop_pos): Rename local to
6589 avoid shadowing.
b246f932
PE
6590 (composition_reseat_it): Remove unused locals.
6591 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6592 (composition_update_it): Mark var as initialized.
11b61122
PE
6593 (find_automatic_composition): Mark vars as initialized,
6594 with a FIXME (Bug#8290).
8f5201ae 6595
760fbc2c
PE
6596 character.h: Rename locals to avoid shadowing.
6597 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6598 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6599 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6600 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6601 to avoid shadowing.
6602
ff08eb85
PE
6603 * textprop.c (property_change_between_p): Remove; unused.
6604
fc7bf025
PE
6605 * intervals.c (interval_start_pos): Now static.
6606
235d7abc
PE
6607 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6608
44f230aa
SM
6609 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6610 Rename locals to avoid shadowing.
3e7d6594 6611
50060332
PE
6612 * sound.c (wav_play, au_play, Fplay_sound_internal):
6613 Fix pointer signedness.
d01f234b 6614 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6615 (wav_play): Initialize a variable to 0, to prevent undefined
6616 behavior (Bug#8278).
50060332 6617
c4fc4e30
PE
6618 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6619
918436ed
PE
6620 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6621
c939f91b
PE
6622 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6623 clobbering (Bug#8298).
b9c7f648
PE
6624 * sysdep.c (sys_subshell): Likewise.
6625 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6626
6bd8c144
PE
6627 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6628 This should get cleaned up, so that child_setup has the
6629 same signature on all platforms.
6630
7710357c 6631 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6632 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6633
c59da222
CY
66342011-03-22 Chong Yidong <cyd@stupidchicken.com>
6635
6636 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6637 not to be necessary, and produces flickering.
6638
66b87493
GM
66392011-03-20 Glenn Morris <rgm@gnu.org>
6640
6641 * config.in: Remove file.
6642
45b6f6d5
JB
66432011-03-20 Juanma Barranquero <lekktu@gmail.com>
6644
6645 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6646 are now in src/globals.h.
6647 (syms_of_minibuf): Remove spurious & from previous change.
6648
3ec03f7e
LL
66492011-03-20 Leo <sdl.web@gmail.com>
6650
6651 * minibuf.c (completing-read-function): New variable.
6652 (completing-read-default): Rename from completing-read.
6653 (completing-read): Call completing-read-function.
6654
b14e3e21
CY
66552011-03-19 Juanma Barranquero <lekktu@gmail.com>
6656
6657 * xfaces.c (Fx_load_color_file):
6658 Read color file from absolute filename (bug#8250).
6659
f2b726e6
JB
66602011-03-19 Juanma Barranquero <lekktu@gmail.com>
6661
6662 * makefile.w32-in: Update dependencies.
6663
09f6ff02
EZ
66642011-03-17 Eli Zaretskii <eliz@gnu.org>
6665
6666 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6667
29a6015a
PE
66682011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6669
a3a6c54e
PE
6670 Fix more problems found by GCC 4.5.2's static checks.
6671
b766f867
PE
6672 * process.c (make_serial_process_unwind, send_process_trap):
6673 (sigchld_handler): Now static.
6674
be02381c
PE
6675 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6676 That way, the code declares only the vars that it needs.
6677 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6678 * s/cygwin.h (PTY_ITERATION): Likewise.
6679 * s/darwin.h (PTY_ITERATION): Likewise.
6680 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6681
57048744
PE
6682 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6683 * process.c (allocate_pty): Don't declare stb unless it's needed.
6684
7914961c 6685 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6686 (CONSTANTLIM): Remove; unused.
6687 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6688 Define only if needed.
7914961c 6689
b3967b18
PE
6690 * unexelf.c (unexec): Name an expression,
6691 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6692 Use a different way to cause a compilation error if anyone uses
6693 n rather than nn, a way that does not involve shadowing.
73366a00 6694 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6695
29a6015a
PE
6696 * deps.mk (unexalpha.o): Remove; unused.
6697
43cfc33e 6698 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6699 * unexec.h: New file.
ce701a33
PE
6700 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6701 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6702 Depend on unexec.h.
6703 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6704 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6705 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6706 Change as necessary to match prototype in unexec.h.
ce701a33 6707
01f44d5a
PE
6708 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6709 shadowing.
4f63c6bb 6710 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6711
a6670b0b
PE
6712 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6713 Rename locals to avoid shadowing.
6714
cef2010d 6715 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6716 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6717
d4d7173a
PE
6718 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6719
f08b802a
PE
6720 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6721 warning when compiling print.c.
6722
3ddb0639
PE
6723 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6724 instead of using an uninitialized var.
5ad03b97 6725 (font_sort_entities): Mark var as initialized.
3ddb0639 6726
170a2692
PE
6727 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6728
e663c700
PE
6729 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6730 pointers to constants.
89bc529a 6731 (font_parse_fcname): Remove unused vars.
7b81e2d0 6732 (font_delete_unmatched): Now static.
ea838e10 6733 (font_get_spec): Remove; unused.
13a547c6
PE
6734 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6735 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6736 Rename or move locals to avoid shadowing.
e663c700 6737
2a80c887 6738 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6739 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6740
1384fa33 6741 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6742 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6743
8b2c52e9
PE
6744 * alloc.c (mark_backtrace): Move decl from here ...
6745 * lisp.h: ... to here, so that it can be checked.
6746
475545b5 6747 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6748 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6749 (lisp_indirect_variable): Name an expression,
6750 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6751 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6752
b1349114 6753 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6754 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6755 Use const pointer when appropriate.
b1349114 6756
a2928364
PE
6757 * lisp.h (get_system_name, get_operating_system_release):
6758 Move decls here, to check interfaces.
6759 * process.c (get_operating_system_release): Move decl to lisp.h.
6760 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6761 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6762 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6763 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6764 (Fformat_time_string, Fencode_time, Finsert_char):
6765 (Ftranslate_region_internal, Fformat):
6766 Rename or remove local vars to avoid shadowing.
9710023e 6767 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6768
a415e694
PE
6769 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6770 avoid shadowing.
6771
8ef4622d
PE
6772 * lisp.h (eassert): Check that the argument compiles, even if
6773 ENABLE_CHECKING is not defined.
6774
946f9a5b
PE
6775 * data.c (Findirect_variable): Name an expression, to avoid
6776 gcc -Wbad-function-cast warning.
112396d6 6777 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6778 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6779 (Fmake_variable_buffer_local, Fmake_local_variable):
6780 Mark variables as initialized.
52746918 6781 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6782
e5aab7e7 6783 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6784 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6785 Rename locals to avoid shadowing.
dff45157
PE
6786 (mark_stack): Move local variables into the #ifdef region where
6787 they're used.
7bc26fdb
PE
6788 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6789 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6790 needed otherwise.
6791 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6792 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6793 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6794
e5aab7e7
PE
6795 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6796 avoids undefined behavior in theory.
6797
4da60324
PE
6798 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6799
88043301
PE
6800 Use functions, not macros, for up- and down-casing (Bug#8254).
6801 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6802 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6803 to use the following functions instead of these macros.
6804 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6805 EMACS_INT, since callers assume the returned value fits in int.
6806 (upcase1): Likewise, for UPCASE_TABLE.
6807 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6808 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6809 the race-condition problem in the old DOWNCASE.
88043301 6810
19ed5445
PE
6811 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6812 Rename locals to avoid shadowing.
6813 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6814 (regex_compile, re_search_2, re_match_2_internal):
6815 Remove unused local vars.
952db0d7
PE
6816 (FREE_VAR): Rewrite so as not to use empty "else",
6817 which gcc can warn about.
da053e48 6818 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6819 (RETALLOC_IF): Define only if needed.
6820 (WORDCHAR_P): Likewise. This one is never needed, but is used
6821 only in a comment talking about a compiler bug, so put inside
6822 the #if 0 of that comment.
6823 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6824 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6825 Remove; unused.
19ed5445 6826
1f3561e4 6827 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6828 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6829 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6830
ded6f8f7
PE
6831 * search.c (simple_search): Remove unused var.
6832
dbd37a95
PE
6833 * dired.c (compile_pattern): Move decl from here ...
6834 * lisp.h: ... to here, so that it can be checked.
6835 (struct re_registers): New forward decl.
6836
7e47afad
PE
6837 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6838
85f24f61
PE
6839 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6840 All uses changed.
6841 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6842 Rename locals to avoid shadowing.
5671df8f 6843 (Fvertical_motion): Mark locals as initialized.
85f24f61 6844
181aa2be 6845 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6846 (casify_region): Mark local as initialized.
181aa2be 6847
930d429c
PE
6848 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6849
7082eac6
PE
6850 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6851 New macros, so that the caller can use some names other than
6852 gcpro1, gcpro2, etc.
6853 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6854 of the new macros.
6855 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6856 argument, for consistency with GCPRO2_VAR, etc: it is now the
6857 prefix of the variable, not the variable itself. All uses
6858 changed.
38b2c076
PE
6859 * dired.c (directory_files_internal, file_name_completion):
6860 Rename locals to avoid shadowing.
6861
15206ed9
PE
6862 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6863 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6864 dired.c's scmp function, had undefined behavior.
6865 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6866 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6867 * buffer.h: ... to here, because these macros use current_buffer,
6868 and the new implementation with inline functions needs to have
6869 current_buffer in scope now, rather than later when the macros
6870 are used.
6871 (downcase, upcase1): New static inline functions.
6872 (DOWNCASE, UPCASE1): Reimplement using these functions.
6873 This avoids undefined behavior in expressions like
6874 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6875 from race conditions in accessing the global variables
6876 case_temp1 and case_temp2.
6877 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6878 * lisp.h (case_temp1, case_temp2): Remove their decls.
6879 * character.h (ASCII_CHAR_P): Move from here ...
6880 * lisp.h: ... to here, so that the inline functions mentioned
6881 above can use them.
6882
4a6bea26
PE
6883 * dired.c (directory_files_internal_unwind): Now static.
6884
f14b7e14
PE
6885 * fileio.c (file_name_as_directory, directory_file_name):
6886 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6887 Now static.
2893f146
PE
6888 (file_name_as_directory): Use const pointers when appropriate.
6889 (Fexpand_file_name): Likewise. In particular, newdir might
6890 point at constant storage, so make it a const pointer.
fd4ead52 6891 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6892 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6893 signedness issues.
f839df0c
PE
6894 (Fset_file_times, Finsert_file_contents, auto_save_error):
6895 Rename locals to avoid shadowing.
f14b7e14 6896
5716756e 6897 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6898 (Ftry_completion, Fall_completions): Rename or remove locals
6899 to avoid shadowing.
5716756e 6900
b4c3046a
PE
6901 * marker.c (bytepos_to_charpos): Remove; unused.
6902
b45db522
PE
6903 * lisp.h (verify_bytepos, count_markers): New decls,
6904 so that gcc does not warn that these functions aren't declared.
6905
85876d07
PE
6906 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6907 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6908 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6909 (copy_text): Remove unused local var.
85876d07 6910
03d78a21 6911 * filelock.c (within_one_second): Now static.
b3dd38ab 6912 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6913
5df8f01b
PE
6914 * buffer.c (fix_overlays_before): Mark locals as initialized.
6915 (fix_start_end_in_overlays): Likewise. This function should be
6916 simplified by using pointers-to-pointers, but that's a different
6917 matter.
b1d876f1 6918 (switch_to_buffer_1): Now static.
8f54f30a
PE
6919 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6920 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6921
a70072c9 6922 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6923 Fix pointer signedness issue.
edced198
PE
6924 (sys_subshell): Mark local as volatile if checking for lint,
6925 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6926 (MAXPATHLEN): Define only if needed.
a70072c9 6927
a0977c44
PE
6928 * process.c (serial_open, serial_configure): Move decls from here ...
6929 * systty.h: ... to here, so that they can be checked.
6930
a884fdcc
PE
6931 * fns.c (get_random, seed_random): Move extern decls from here ...
6932 * lisp.h: ... to here, so that they can be checked.
6933
604efe86 6934 * sysdep.c (reset_io): Now static.
b8950c94 6935 (wait_for_termination_signal): Remove; unused.
604efe86 6936
38fc62d9
PE
6937 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6938 (copy_keymap_item, append_key, push_text_char_description):
6939 Now static.
1004a21a 6940 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6941 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6942 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6943 (describe_map_tree):
6944 Rename locals to avoid shadowing.
38fc62d9 6945
2f2650da
PE
6946 * keyboard.c: Declare functions static if they are not used elsewhere.
6947 (echo_char, echo_dash, cmd_error, top_level_2):
6948 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6949 (read_char, kbd_buffer_get_event, make_lispy_position):
6950 (make_lispy_event, make_lispy_movement, apply_modifiers):
6951 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6952 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6953 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6954 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6955 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6956
a053e86c 6957 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6958 (mark_kboards): Move decl here ...
6959 * alloc.c (mark_kboards): ... from here.
a053e86c 6960
4752793e
PE
6961 * lisp.h (force_auto_save_soon): New decl.
6962
74f10ca7 6963 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6964 (DEFINE_DUMMY_FUNCTION): New macro.
6965 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6966 Use it.
c03cd23f
PE
6967 (main): Add casts to avoid warnings
6968 if GCC considers string literals to be constants.
74f10ca7 6969
022e70d4
PE
6970 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6971
59d6fe83
PE
6972 * dbusbind.c: Pointer signedness fixes.
6973 (xd_signature, xd_append_arg, xd_initialize):
6974 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6975 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6976 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6977 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6978
78320123
PE
6979 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6980 if GCC considers string literals to be constants.
49cebcca 6981 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6982
35ac2a97
SM
69832011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6984
fb103ca9
SM
6985 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6986 (print_preprocess, print_object): New macro to fix last change.
6987
35ac2a97
SM
6988 * print.c (print_preprocess): Don't forget font objects.
6989
62973b41
JB
69902011-03-16 Juanma Barranquero <lekktu@gmail.com>
6991
6992 * emacs.c (USAGE3): Doc fixes.
6993
0e48bb22
AS
69942011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6995
6996 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6997 structure.
6998
7684e57b
JB
69992011-03-14 Juanma Barranquero <lekktu@gmail.com>
7000
7001 * lisp.h (VWindow_system, Qfile_name_history):
7002 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7003 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7004 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7005
7006 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7007 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7008
7009 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7010 * w32console.c (detect_input_pending, read_input_pending)
7011 (encode_terminal_code):
7012 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7013 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7014 (w32_system_caret_y, Qfile_name_history):
7015 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7016 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7017 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7018 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7019 * w32proc.c (Qlocal, report_file_error):
7020 * w32term.c (Vwindow_system, updating_frame):
7021 * w32uniscribe.c (initialized, uniscribe_font_driver):
7022 Remove unneeded extern declarations.
7023
2aa46d6c
CY
70242011-03-14 Chong Yidong <cyd@stupidchicken.com>
7025
c96bbc66 7026 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7027
cffc6f3b
CY
70282011-03-13 Chong Yidong <cyd@stupidchicken.com>
7029
7030 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7031 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7032 These macros can no longer be used for assignment.
7033
44f230aa
SM
7034 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7035 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7036 (record_buffer_markers, fetch_buffer_markers): New functions for
7037 recording and fetching special buffer markers.
7038 (set_buffer_internal_1, set_buffer_temp): Use them.
7039
7040 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7041
7042 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7043
7044 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7045 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7046
7047 * xdisp.c (hscroll_window_tree):
7048 (reconsider_clip_changes): Use PT instead of BUF_PT.
7049
d251f04b
EZ
70502011-03-13 Eli Zaretskii <eliz@gnu.org>
7051
7052 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7053 $(EMACS_ROOT)/lib/intprops.h.
7054
f0c77cd1
PE
70552011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7056
3eca4629
PE
7057 Fix more problems found by GCC 4.5.2's static checks.
7058
7c86ee98
PE
7059 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7060 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7061 (xg_free_frame_widgets): Make it clear that a local variable is
7062 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7063 (gdk_window_get_screen): Make it clear that this macro is needed
7064 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7065 (int_gtk_range_get_value): New function, which avoids a diagnostic
7066 from gcc -Wbad-function-cast.
7067 (xg_set_toolkit_scroll_bar_thumb): Use it.
7068 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7069 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7070 (get_utf8_string, xg_get_file_with_chooser):
7071 Rename locals to avoid shadowing.
7072 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7073
41729b81
PE
7074 * xgselect.c (xg_select): Remove unused var.
7075
f0c77cd1
PE
7076 * image.c (four_corners_best): Mark locals as initialized.
7077 (gif_load): Initialize transparent_p to zero (Bug#8238).
7078 Mark another local as initialized.
ec6cf4c6 7079 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7080
ce0ad53d 7081 * image.c (clear_image_cache): Now static.
d5d5a617 7082 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7083 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7084 (x_edge_detection): Remove unnecessary cast that
7085 gcc -Wbad-function-cast diagnoses.
2037898d 7086 (gif_load): Fix pointer signedness.
6ae141d6
PE
7087 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7088 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7089
33383987 70902011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7091
d32df629
PE
7092 Improve quality of tests for time stamp overflow.
7093 For example, without this patch (encode-time 0 0 0 1 1
7094 1152921504606846976) returns the obviously-bogus value (-948597
7095 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7096 reports time overflow. See
7097 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7098 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7099 * editfns.c: Include limits.h and intprops.h.
7100 (TIME_T_MIN, TIME_T_MAX): New macros.
7101 (time_overflow): Move earlier, to before first use.
7102 (hi_time, lo_time): New functions, for an accurate test for
7103 out-of-range times.
7104 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7105 (Fget_internal_run_time): Don't assume time_t fits in int.
7106 (make_time): Use list2 instead of Fcons twice.
7107 (Fdecode_time): More accurate test for out-of-range times.
7108 (check_tm_member): New function.
7109 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7110 (lisp_time_argument): Don't rely on undefined left-shift and
7111 right-shift behavior when checking for time stamp overflow.
8be6f318 7112
fe31d94c
PE
7113 * editfns.c (time_overflow): New function, refactoring common code.
7114 (Fformat_time_string, Fdecode_time, Fencode_time):
7115 (Fcurrent_time_string): Use it.
7116
8be6f318
PE
7117 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7118 * dired.c (make_time): Move to ...
7119 * editfns.c (make_time): ... here.
7120 * systime.h: Note the move.
7121
09d9db2c 71222011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7123
126bc0dc
YM
7124 * fringe.c (update_window_fringes): Remove unused variables.
7125
c47cbdfd
YM
7126 * unexmacosx.c (copy_data_segment): Also copy __got section.
7127 (Bug#8223)
7128
7ac80be9
EZ
71292011-03-12 Eli Zaretskii <eliz@gnu.org>
7130
c96bbc66 7131 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7132 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7133 Constify `char *' arguments and their references according to
7134 prototypes in tparam.h.
7135
ecb0f94d 7136 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7137
7ac80be9
EZ
7138 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7139 Adapt all references accordingly.
7140
7141 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7142
ef1fd07e
TT
71432011-03-11 Tom Tromey <tromey@redhat.com>
7144
7145 * buffer.c (syms_of_buffer): Remove obsolete comment.
7146
7ef4b50c
EZ
71472011-03-11 Eli Zaretskii <eliz@gnu.org>
7148
7149 * termhooks.h (encode_terminal_code): Declare prototype.
7150
7151 * msdos.c (encode_terminal_code): Don't declare prototype.
7152
7153 * term.c (encode_terminal_code): Now external again, used by
7154 w32console.c and msdos.c.
7155
44f230aa
SM
7156 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7157 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7158
4b1ec863 71592011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7160
1714f52b 7161 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7162
4b1ec863
PE
7163 * fringe.c (update_window_fringes): Mark locals as initialized
7164 (Bug#8227).
7165 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7166
524c7aa6
PE
7167 * alloc.c (mark_fringe_data): Move decl from here ...
7168 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7169 to check its interface.
7170 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7171
a5c0af81 7172 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7173 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7174 (fontset_font): Mark local as initialized.
a9a06e0b 7175 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7176
b4716021
PE
7177 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7178
811e9bac 7179 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7180 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7181 (x_own_selection, Fx_disown_selection_internal): Rename locals
7182 to avoid shadowing.
7183 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7184
7e3ab302
PE
7185 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7186 so that the caller can use some name other than gcpro1.
7187 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7188 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7189 (Fx_backspace_delete_keys_p):
7190 Use them to avoid shadowing, and rename vars to avoid shadowing.
7191 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7192 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7193 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7194 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7195 Remove unused locals.
7e3ab302
PE
7196 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7197 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7198 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7199 macros.
f78faa98 7200
e2b13473
PE
7201 * xterm.h (x_mouse_leave): New decl.
7202
77f23912
PE
7203 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7204 Remove unused functions.
cdf4ba58
PE
7205 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7206 (x_calc_absolute_position): Now static.
7411c686 7207 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7208 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7209 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7210 unless they are used.
38d0b34a
PE
7211 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7212 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7213 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7214 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7215 (x_error_catcher, x_connection_closed, x_error_handler):
7216 (x_error_quitter, xembed_send_message, x_iconify_frame):
7217 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7218 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7219 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7220
44f230aa
SM
7221 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7222 Rename or move locals to avoid shadowing.
6b463e58 7223 (tty_defined_color, merge_face_heights): Now static.
5967d051 7224 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7225 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7226 does not deduce is never used uninitialized.
73719eba
PE
7227 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7228 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7229
426994c3 7230 * terminal.c (store_terminal_param): Now static.
5489860b 7231
032f1620 7232 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7233 (set_frame_menubar): Remove unused local.
d4323972 7234 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7235 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7236 since they might point to immutable storage.
281585b0
PE
7237 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7238 since it's unused otherwise.
032f1620 7239
367c19e5 7240 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7241 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7242 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7243 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7244 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7245 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7246 does not deduce are never used uninitialized.
70739cbe 7247
07b48fa9
PE
7248 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7249
8868a238 7250 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7251 * window.c (window_loop, size_window):
7252 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7253
7e5cf297 7254 * window.c (display_buffer): Now static.
d6550a9f
PE
7255 (size_window): Mark variables that gcc -Wuninitialized
7256 does not deduce are never used uninitialized.
a586633d
PE
7257 * window.h (check_all_windows): New decl, to forestall
7258 gcc -Wmissing-prototypes diagnostic.
5b555da1 7259 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7260
f6095868
PE
7261 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7262 shadowing.
7263 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7264 Include <limits.h>.
7265 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7266 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7267 (load_charset_map): Mark variables that gcc -Wuninitialized
7268 does not deduce are never used uninitialized.
53df7c11 7269 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7270
f38b440c
PE
7271 * coding.c (coding_set_source, coding_set_destination):
7272 Use "else { /* comment */ }" rather than "else /* comment */;"
7273 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7274 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7275 a block, when the outer 'i' will do.
7276 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7277 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7278 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7279 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7280 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7281 Rename locals to avoid shadowing.
7282 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7283 * coding.c (emacs_mule_char, encode_invocation_designation):
7284 Now static, since they're not used elsewhere.
413bb2db 7285 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7286 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7287 (decode_coding_emacs_mule): Mark variables that gcc
7288 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7289 (detect_coding_iso_2022): Initialize a local variable that might
7290 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7291 this initialization is needed. (Bug#8211)
5f58e762
PE
7292 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7293 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7294 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7295 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7296 Remove unused macros.
f38b440c 7297
232b38b9 7298 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7299 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7300 * character.c (string_count_byte8): Likewise.
232b38b9 7301
fb90da1b
PE
7302 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7303 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7304
fb93dbc2
PE
7305 * chartab.c (copy_sub_char_table): Now static, since it's not used
7306 elsewhere.
5c156ace
PE
7307 (sub_char_table_ref_and_range, char_table_ref_and_range):
7308 Rename locals to avoid shadowing.
bbcd0949 7309 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7310
7d3b3862 7311 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7312 (BIDI_BOB): Remove unused macro.
7d3b3862 7313
6be7d3da
PE
7314 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7315 deduce are never used uninitialized.
c2ed9c8b 7316 * term.c (encode_terminal_code): Likewise.
6be7d3da 7317
75f8807f 7318 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7319
50938595
PE
7320 * tparam.h: New file.
7321 * term.c, tparam.h: Include it.
7322 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7323 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7324 Move these decls to tparam.h, and make them agree with what
7325 is actually in tparam.c. The previous trick of using incompatible
7326 decls in different modules does not conform to the C standard.
7327 All callers of tparam changed to use tparam's actual API.
7328 * tparam.c (tparam1, tparam, tgoto):
7329 Use const pointers where appropriate.
7330
fbceeba2
PE
7331 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7332 * cm.h (struct cm): Likewise.
7333 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7334 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7335 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7336 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7337 (turn_on_face, init_tty): Likewise.
7338 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7339
7f3f1250
PE
7340 * term.c (term_mouse_position): Rename local to avoid shadowing.
7341
e6ca6543
PE
7342 * alloc.c (mark_ttys): Move decl from here ...
7343 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7344
c40f8d15
AS
73452011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7346
7347 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7348
cfe0661d
JB
73492011-03-09 Juanma Barranquero <lekktu@gmail.com>
7350
7351 * search.c (compile_pattern_1): Remove argument regp, unused since
7352 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7353 (compile_pattern): Don't pass it.
7354
0afb4571
J
73552011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7356
7357 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7358 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7359 for ! HAVE_GTK3.
7360 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7361
7362 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7363
7364 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7365 gdk_window_get_screen, gdk_window_get_geometry,
7366 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7367 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7368 (xg_get_pixbuf_from_pixmap): New function.
7369 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7370 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7371 Call xg_get_pixbuf_from_pixmap instead of
7372 gdk_pixbuf_get_from_drawable.
7373 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7374 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7375 (xg_check_special_colors): Use GtkStyleContext and its functions
7376 for HAVE_GTK3.
7377 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7378 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7379 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7380 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7381 Call gtk_widget_get_preferred_size.
0afb4571
J
7382 (xg_frame_resized): gdk_window_get_geometry only takes 5
7383 parameters.
44f230aa
SM
7384 (xg_win_to_widget, xg_event_is_for_menubar):
7385 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7386 (xg_set_widget_bg): New function.
7387 (delete_cb): New function.
895009e1 7388 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7389 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7390 (xg_set_background_color): Call xg_set_widget_bg.
7391 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7392 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7393 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7394 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7395 if ! HAVE_GTK3.
7396 (update_frame_tool_bar): Call gtk_widget_hide.
7397 (xg_initialize): Use GDK_KEY_g.
7398
7399 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7400 if ! HAVE_GTK3
7401 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7402
7403 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7404 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7405 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7406
1c2cc4ef
JB
74072011-03-08 Juanma Barranquero <lekktu@gmail.com>
7408
7409 * w32xfns.c (select_palette): Check success of RealizePalette against
7410 GDI_ERROR, not zero.
7411
33383987 7412See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7413
7414;; Local Variables:
7415;; coding: utf-8
aac0c6e3
MR
7416;; End:
7417
33383987 7418 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7419
7420 This file is part of GNU Emacs.
7421
7422 GNU Emacs is free software: you can redistribute it and/or modify
7423 it under the terms of the GNU General Public License as published by
7424 the Free Software Foundation, either version 3 of the License, or
7425 (at your option) any later version.
7426
7427 GNU Emacs is distributed in the hope that it will be useful,
7428 but WITHOUT ANY WARRANTY; without even the implied warranty of
7429 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7430 GNU General Public License for more details.
7431
7432 You should have received a copy of the GNU General Public License
7433 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.