* xsmfns.c (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
2baccd04 3 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4 Remove unused var.
dde42981 5 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6
3565b346
PE
7 * xrdb.c (x_load_resources) [!USE_MOTIF]: Omit unused local.
8
436c16df 9 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12
92bb796d 13 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14 (x_term_init): Remove local to avoid shadowing.
92bb796d 15
764430a3 16 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
17
18 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
19 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
20
4170f62f 212011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 22
71b41406
PE
23 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
24
9587a89d
PE
25 emacs_write: Accept and return EMACS_INT for sizes.
26 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
27 et seq.
28 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
29 Accept and return EMACS_INT.
30 (emacs_gnutls_write): Return the number of bytes written on
31 partial writes.
32 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
33 (emacs_read, emacs_write): Remove check for negative size, as the
34 Emacs source code has been audited now.
9587a89d
PE
35 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
36 (emacs_read, emacs_write): Use it.
273a5f82
PE
37 * process.c (send_process): Adjust to the new signatures of
38 emacs_write and emacs_gnutls_write. Do not attempt to store
39 a byte offset into an 'int'; it might overflow.
9587a89d 40 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 41
3e047f51
PE
42 * sound.c: Don't assume sizes fit in 'int'.
43 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 44 Return EMACS_INT, not int.
3e047f51 45 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
46 Accept EMACS_INT, not int.
47 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
48 record read return values.
49
cc39a9db
BK
502011-04-15 Ben Key <bkey76@gmail.com>
51
52 * keyboard.c (Qundefined): Don't declare static since it is
53 used in nsfns.m.
54 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
55 declare static since they are used in nsfont.m.
56
6c60eb9f
SM
572011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
58
59 * process.c (Qprocessp): Don't declare static.
60 * lisp.h (Qprocessp): Declare again.
61
7990b61a
JB
622011-04-15 Juanma Barranquero <lekktu@gmail.com>
63
64 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
65
5d4cb038
PE
662011-04-14 Paul Eggert <eggert@cs.ucla.edu>
67
8bd7b830 68 Improve C-level modularity by making more things 'static'.
cd64ea1d 69
e3b27b31
PE
70 Don't publish debugger-only interfaces to other modules.
71 * lisp.h (safe_debug_print, debug_output_compilation_hack):
72 (verify_bytepos, count_markers): Move decls to the only modules
73 that need them.
74 * region-cache.h (pp_cache): Likewise.
75 * window.h (check_all_windows): Likewise.
76 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
77
5d4cb038
PE
78 * sysdep.c (croak): Now static, if
79 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
80 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
81
82 * alloc.c (refill_memory_reserve): Now static if
83 !defined REL_ALLOC || defined SYSTEM_MALLOC.
84 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 85
e87b6180
PE
86 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
87 Define only if USE_LUCID.
88
ac64929e
PE
89 * xrdb.c (x_customization_string, x_rm_string): Now static.
90
6f37259d
PE
91 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
92 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
93
1683e3ab
PE
94 * xdisp.c (draw_row_with_mouse_face): Now static.
95 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
96
de9c2632
PE
97 * window.h (check_all_windows): Mark externally visible.
98
2b96acb7
PE
99 * window.c (window_deletion_count): Now static.
100
101 * undo.c: Make symbols static if they're not exported.
102 (last_undo_buffer, last_boundary_position, pending_boundary):
103 Now static.
104
50436f33
PE
105 * textprop.c (interval_insert_behind_hooks): Now static.
106 (interval_insert_in_front_hooks): Likewise.
107
64520e5c
PE
108 * term.c: Make symbols static if they're not exported.
109 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
110 (max_frame_lines, tty_set_terminal_modes):
111 (tty_reset_terminal_modes, tty_turn_off_highlight):
112 (get_tty_terminal): Now static.
113 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
114 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 115 HAVE_WINDOW_SYSTEM.
64520e5c
PE
116 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
117 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
118
1fa53021
PE
119 * sysdep.c: Make symbols static if they're not exported.
120 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
121 Now static.
122 (sigprocmask_set, full_mask): Remove; unused.
123 (wait_debugging): Mark as visible.
124 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
125 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
126
d4b43b22
PE
127 * syntax.c (syntax_temp): Define only if !__GNUC__.
128
b7c513d0
PE
129 * sound.c (current_sound_device, current_sound): Now static.
130
989b29ad
PE
131 * search.c (searchbufs, searchbuf_head): Now static.
132
13a55a78
PE
133 * scroll.c (scroll_cost): Remove; unused.
134 * dispextern.h (scroll_cost): Remove decl.
135
de68a1fc
PE
136 * region-cache.h (pp_cache): Mark as externally visible.
137
40ccffa6
PE
138 * process.c: Make symbols static if they're not exported.
139 (process_tick, update_tick, create_process, chan_process):
140 (Vprocess_alist, proc_buffered_char, datagram_access):
141 (fd_callback_data, send_process_frame, process_sent_to): Now static.
142 (deactivate_process): Mark defn as static, as well as decl.
143 * lisp.h (create_process): Remove decl.
144 * process.h (chan_process, Vprocess_alist): Remove decls.
145
ad64fc97
PE
146 * print.c: Make symbols static if they're not exported.
147 (print_depth, new_backquote_output, being_printed, print_buffer):
148 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
149 (print_interval, print_number_index, initial_stderr_stream):
150 Now static.
151 * lisp.h (Fprinc): Remove decl.
152 (debug_output_compilation_hack): Mark as externally visible.
153
adddb265
PE
154 * sysdep.c (croak): Move decl from here to syssignal.h.
155 * syssignal.h (croak): Put it here, so the API can be checked when
156 'croak' is called from dissociate_if_controlling_tty.
157
1717ede2
PE
158 * minibuf.c: Make symbols static if they're not exported.
159 (minibuf_save_list, choose_minibuf_frame): Now static.
160 * lisp.h (choose_minibuf_frame): Remove decl.
161
fa5fb2bc
PE
162 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
163
1e3890d1
PE
164 * lread.c: Make symbols static if they're not exported.
165 (read_objects, initial_obarray, oblookup_last_bucket_number):
166 Now static.
167 (make_symbol): Remove; unused.
168 * lisp.h (initial_obarray, make_symbol): Remove decls.
169
8a1414fa
PE
170 * keyboard.c: Make symbols static if they're not exported.
171 (single_kboard, recent_keys_index, total_keys, recent_keys):
172 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
173 (this_single_command_key_start, echoing, last_auto_save):
174 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
175 (command_loop, echo_now, keyboard_init_hook, help_char_p):
176 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
177 (Vlispy_mouse_stem, double_click_count):
178 Now static.
179 (force_auto_save_soon): Define only if SIGDANGER.
180 (ignore_mouse_drag_p): Now static if
181 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
182 (print_help): Remove; unused.
183 (stop_character, last_timer_event): Mark as externally visible.
184 * keyboard.h (ignore_mouse_drag_p): Declare only if
185 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
186 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
187 * lisp.h (echoing): Remove decl.
188 (force_auto_save_soon): Declare only if SIGDANGER.
189 * xdisp.c (redisplay_window): Simplify code, to make it more
190 obvious that ignore_mouse_drag_p is not accessed if !defined
191 USE_GTK && !defined HAVE_NS.
192
93ea6e8f
PE
193 * intervals.c: Make symbols static if they're not exported.
194 (merge_properties_sticky, merge_interval_right, delete_interval):
195 Now static.
196 * intervals.h (merge_interval_right, delete_interval): Remove decls.
197
77382fcc
PE
198 * insdel.c: Make symbols static if they're not exported.
199 However, leave prepare_to_modify_buffer alone. It's never
200 called from outside this function, but that appears to be a bug.
201 (combine_after_change_list, combine_after_change_buffer):
4889fc82 202 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
203 (adjust_after_replace_noundo): Remove; unused.
204 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 205 (signal_before_change): Remove decls.
77382fcc 206
9306c32e
PE
207 * indent.c (val_compute_motion, val_vmotion): Now static.
208
cd44d2eb
PE
209 * image.c: Make symbols static if they're not exported.
210 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
211 if USE_GTK.
212 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
213 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
214
ad9a7a06
PE
215 * fringe.c (standard_bitmaps): Now static.
216 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
217
81626931
PE
218 * frame.c: Make symbols static if they're not exported.
219 (x_report_frame_params, make_terminal_frame): Now static.
220 (get_frame_param): Now static, unless HAVE_NS.
221 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
222 (x_get_resource_string): Remove; not used.
223 * frame.h (make_terminal_frame, x_report_frame_params):
224 (x_get_resource_string); Remove decls.
225 (x_fullscreen_adjust): Declare only if WINDOWSNT.
226 * lisp.h (get_frame_param): Declare only if HAVE_NS.
227
239f9db9
PE
228 * font.c, fontset.c: Make symbols static if they're not exported.
229 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
230 (FACE_SUITABLE_FOR_CHAR_P): Use it.
231 * font.c (font_close_object): Now static.
232 * font.h (font_close_object): Remove.
233 * fontset.c (FONTSET_OBJLIST): Remove.
234 (free_realized_fontset) #if-0 the body, which does nothing.
235 (face_suitable_for_char_p): #if-0, as it's never called.
236 * fontset.h (face_suitable_for_char_p): Remove decl.
237 * xfaces.c (face_at_string_position): Use
238 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239 since 0 is always ASCII.
240
dfcf3579
PE
241 * fns.c (weak_hash_tables): Now static.
242
5045092b
PE
243 * fileio.c: Make symbols static if they're not exported.
244 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
245 (Vwrite_region_annotation_buffers): Now static.
246
57a96f5c
PE
247 * eval.c: Make symbols static if they're not exported.
248 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
249 * lisp.h (backtrace_list): Remove decl.
250
35f08c38
PE
251 * emacs.c: Make symbols static if they're not exported.
252 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
253 (fatal_error_code, fatal_error_signal_hook, standard_args):
254 Now static.
255 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
256 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
257 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
258 * lisp.h (fatal_error_signal_hook): Remove decl.
259 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
260
f44bd759
PE
261 * editfns.c: Move a (normally-unused) function to its only use.
262 * editfns.c, lisp.h (get_operating_system_release): Remove.
263 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
264 worth the hassle of breaking this out.
265
b532497d
PE
266 * xterm.c: Make symbols static if they're not exported.
267 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
268 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
269 (x_destroy_window, x_delete_display):
270 Now static.
271 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
272 (x_mouse_leave): Remove; unused.
273 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
274 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
275 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
276 Remove decls.
277 (x_mouse_leave): Declare only if WINDOWSNT.
278 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
279 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
280 USE_X_TOOLKIT.
281
1675728f
PE
282 * ftxfont.c: Make symbols static if they're not exported.
283 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
284 HAVE_FREETYPE.
285 * font.h (ftxfont_driver): Likewise.
286
e4cebfca
PE
287 * xfns.c: Make symbols static if they're not exported.
288 (x_last_font_name, x_display_info_for_name):
289 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
290 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
291 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
292 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
293 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
294 (last_show_tip_args): Now static.
295 (xic_defaut_fontset, xic_create_fontsetname): Define only if
296 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
297 (x_screen_planes): Remove; unused.
298 * dispextern.h (x_screen_planes): Remove decl.
299
5bf46f05
PE
300 * dispnew.c: Make symbols static if they're not exported.
301 * dispextern.h (redraw_garbaged_frames, scrolling):
302 (increment_row_positions): Remove.
303 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
304 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
305 Now static.
306 (redraw_garbaged_frames): Remove; unused.
307
435f4c28
PE
308 * xfaces.c: Make symbols static if they're not exported.
309 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
310 Remove decls.
311 * xterm.h (defined_color): Remove decls.
312 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
313 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
314 (menu_face_changed_default, defined_color, free_realized_face):
315 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
316 (ascii_face_of_lisp_face): Remove; unused.
317
8524aef3
PE
318 * xdisp.c: Make symbols static if they're not exported.
319 * dispextern.h (scratch_glyph_row, window_box_edges):
320 (glyph_to_pixel_coords, set_cursor_from_row):
321 (get_next_display_element, set_iterator_to_next):
322 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
323 (show_mouse_face): Remove decls
324 * frame.h (message_buf_print): Likewise.
325 * lisp.h (pop_message, set_message, check_point_in_composition):
326 Likewise.
327 * xterm.h (set_vertical_scroll_bar): Likewise.
328 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
329 (message_buf_print, scratch_glyph_row, displayed_buffer):
330 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
331 (get_next_display_element, show_mouse_face, window_box_edges):
332 (frame_to_window_pixel_xy, check_point_in_composition):
333 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
334 (glyph_to_pixel_coords): Remove; unused.
335
16390cd2
PE
336 * dired.c (file_name_completion): Now static.
337
338 * dbusbind.c (xd_in_read_queued_messages): Now static.
339
a25f4dfa
PE
340 * lisp.h (circular_list_error, FOREACH): Remove; unused.
341 * data.c (circular_list_error): Remove.
342
14a9c8df
PE
343 * commands.h (last_point_position, last_point_position_buffer):
344 (last_point_position_window): Remove decls.
345 * keyboard.c: Make these variables static.
346
74ab6df5
PE
347 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
348 decls.
349 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
350 (iso_code_class, detect_coding, code_convert_region): Now static.
351 (encode_coding_gap): Remove; unused.
352
38dfbee1
PE
353 * chartab.c (chartab_chars, chartab_bits): Now static.
354
a2cb4e63
PE
355 * charset.h (charset_iso_8859_1): Remove decl.
356 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
357 Now static.
358
127198fd
PE
359 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
360 * ccl.c (Vccl_program_table): Now static.
361 (check_ccl_update): Remove; unused.
362
d85b608f
PE
363 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
364 * category.h: ... from here.
365 * category.c (check_category_table, set_category_set): Now static.
366
31cd66f3
PE
367 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
368 * lisp.h: Remove these decls.
369
c358e587
PE
370 * buffer.c (buffer_count): Remove unused var.
371
e78aecca
PE
372 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
373 so that it's not optimized away.
374 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
375 * dispextern.h (bidi_dump_cached_states): Remove, since it's
376 exported only to the debugger.
377
e192d7d3
PE
378 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
379 * atimer.h (run_all_atimers): Removed; not exported.
380
92470028
PE
381 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
382 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
383 was inaccessible from Lisp.
384 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
385 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
386
244ed907
PE
387 alloc.c: Import and export fewer symbols, and remove unused items.
388 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
389 is defined.
390 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
391 it's not optimized away by whole-program optimization.
392 (message_enable_multibyte, free_misc): Remove.
393 (catchlist, handlerlist, mark_backtrace):
394 Declare only if BYTE_MARK_STACK.
395 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
396 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
397 (message_enable_multibyte): Remove decl.
398 (free_misc, interval_free_list, float_block, float_block_index):
399 (n_float_blocks, float_free_list, cons_block, cons_block_index):
400 (cons_free_list, last_marked_index):
401 Now static.
402 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
403 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
404 (mark_backtrace): Define only if BYTE_MARK_STACK.
405 * xdisp.c (message_enable_multibyte): Now static.
406
955cbe7b
PE
407 Declare Lisp_Object Q* variables to be 'static' if not exproted.
408 This makes it easier for human readers (and static analyzers)
409 to see whether these variables are used from other modules.
410 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
411 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
412 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
413 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
414 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
415 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
416 * xmenu.c, xselect.c:
417 Declare Q* vars static if they are not used in other modules.
418 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
419 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
420 Remove decls of unexported vars.
421 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
422
95c82688
PE
423 * lisp.h (DEFINE_FUNC): Make sname 'static'.
424
16a97296
PE
425 Make Emacs functions such as Fatom 'static' by default.
426 This makes it easier for human readers (and static analyzers)
427 to see whether these functions can be called from other modules.
428 DEFUN now defines a static function. To make the function external
429 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
430 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
431 (Finit_image_library):
16a97296
PE
432 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
433 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
434 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
435 Remove decls, since these functions are now static.
436 (Funintern, Fget_internal_run_time): New decls, since these functions
437 were already external.
95c82688 438
16a97296
PE
439 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
440 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
441 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
442 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
443 * keyboard.c, keymap.c, lread.c:
444 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
445 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
446 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
447 Mark functions with DEFUE instead of DEFUN,
448 if they are used in other modules.
449 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
450 decls for now-static functions.
451 * buffer.h (Fdelete_overlay): Remove decl.
452 * callproc.c (Fgetenv_internal): Mark as internal.
453 * composite.c (Fremove_list_of_text_properties): Remove decl.
454 (Fcomposition_get_gstring): New forward static decl.
455 * composite.h (Fcomposite_get_gstring): Remove decl.
456 * dired.c (Ffile_attributes): New forward static decl.
457 * doc.c (Fdocumntation_property): New forward static decl.
458 * eval.c (Ffetch_bytecode): New forward static decl.
459 (Funintern): Remove extern decl; now in .h file where it belongs.
460 * fileio.c (Fmake_symbolic_link): New forward static decl.
461 * image.c (Finit_image_library): New forward static decl.
462 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
463 * intervals.h (Fprevious_property_change):
464 (Fremove_list_of_text_properties): Remove decls.
465 * keyboard.c (Fthis_command_keys): Remove decl.
466 (Fcommand_execute): New forward static decl.
467 * keymap.c (Flookup_key): New forward static decl.
468 (Fcopy_keymap): Now static.
469 * keymap.h (Flookup_key): Remove decl.
470 * process.c (Fget_process): New forward static decl.
471 (Fprocess_datagram_address): Mark as internal.
472 * syntax.c (Fsyntax_table_p): New forward static decl.
473 (skip_chars): Remove duplicate decl.
474 * textprop.c (Fprevious_property_change): New forward static decl.
475 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
476 Now internal.
477 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
478 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
479
785bbd42
PE
480 * editfns.c (Fformat): Remove unreachable code.
481
8b913b57
AS
4822011-04-14 Andreas Schwab <schwab@linux-m68k.org>
483
484 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
485 change. (Bug#8496)
486
a6744a35
EZ
4872011-04-13 Eli Zaretskii <eliz@gnu.org>
488
489 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
490 when at ZV. (Bug#8487)
491
e7974947
AS
4922011-04-12 Andreas Schwab <schwab@linux-m68k.org>
493
baad03f0
AS
494 * charset.c (Fclear_charset_maps): Use xfree instead of free.
495 (Bug#8437)
496 * keyboard.c (parse_tool_bar_item): Likewise.
497 * sound.c (sound_cleanup, alsa_close): Likewise.
498 * termcap.c (tgetent): Likewise.
499 * xfns.c (x_default_font_parameter): Likewise.
500 * xsettings.c (read_and_apply_settings): Likewise.
501
e7974947
AS
502 * alloc.c (overrun_check_malloc, overrun_check_realloc)
503 (overrun_check_free): Protoize.
504
28272684
PE
5052011-04-12 Paul Eggert <eggert@cs.ucla.edu>
506
507 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
508 since callers should never pass a negative size.
509 Change the signature to match that of plain 'read' and 'write'; see
510 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
511 * lisp.h: Update prototypes of emacs_write and emacs_read.
512
11997c76
EZ
5132011-04-11 Eli Zaretskii <eliz@gnu.org>
514
515 * xdisp.c (redisplay_window): Don't try to determine the character
516 position of the scroll margin if the window start point w->startp
e896f03c 517 is outside the buffer's accessible region. (Bug#8468)
11997c76 518
8a2cbd72
EZ
5192011-04-10 Eli Zaretskii <eliz@gnu.org>
520
521 Fix write-region and its subroutines for buffers > 2GB.
522 * fileio.c (a_write, e_write): Modify declaration of arguments and
523 local variables to support buffers larger than 2GB.
524 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
525
526 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
527 argument, local variables, and return value.
528
529 * lisp.h: Update prototypes of emacs_write and emacs_read.
530
531 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
532
4073e537 5332011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 534
1ebfdcb6
PE
535 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
536
b2ded58d
PE
537 Fix more problems found by GCC 4.6.0's static checks.
538
7d66342c
PE
539 * xdisp.c (vmessage): Use a better test for character truncation.
540
bbf47d44
PE
541 * charset.c (load_charset_map): <, not <=, for optimization,
542 and to avoid potential problems with integer overflow.
9248994d 543 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 544 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 545 * editfns.c (Fformat): Likewise.
1e69125e 546 * syntax.c (skip_chars): Likewise.
3befa583 547
e3019616
PE
548 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
549 This also lets GCC 4.6.0 generate slightly better loop code.
550
becfa255
PE
551 * callint.c (Fcall_interactively): <, not <=, for optimization.
552 (Fcall_interactively): Count the number of arguments produced,
553 not the number of arguments given. This is simpler and lets GCC
554 4.6.0 generate slightly better code.
555
dae0cd48
PE
556 * ftfont.c: Distingish more carefully between FcChar8 and char.
557 The previous code passed unsigned char * to a functions like
558 strlen and xstrcasecmp that expect char *, which does not
559 conform to the C standard.
560 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
561 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
562 char * when the C standard requires it.
563
76032d70
PE
564 * keyboard.c (read_char): Remove unused var.
565
eb3f1cc8
PE
566 * eval.c: Port to Windows vsnprintf (Bug#8435).
567 Include <limits.h>.
568 (SIZE_MAX): Define if the headers do not.
569 (verror): Do not give up if vsnprintf returns a negative count.
570 Instead, grow the buffer. This ports to Windows vsnprintf, which
571 does not conform to C99. Problem reported by Eli Zaretskii.
572 Also, simplify the allocation scheme, by avoiding the need for
573 calling realloc, and removing the ALLOCATED variable.
574
70476b54
PE
575 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
576
12020a9e
PE
577 Remove invocations of doprnt, as Emacs now uses vsnprintf.
578 But keep the doprint source code for now, as we might revamp it
579 and use it again (Bug#8435).
ea6c7ae6
PE
580 * lisp.h (doprnt): Remove.
581 * Makefile.in (base_obj): Remove doprnt.o.
582 * deps.mk (doprnt.o): Remove.
583
5fdb398c
PE
584 error: Print 32- and 64-bit integers portably (Bug#8435).
585 Without this change, on typical 64-bit hosts error ("...%d...", N)
586 was used to print both 32- and 64-bit integers N, which relied on
587 undefined behavior.
588 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
589 New macro.
590 * lisp.h (error, verror): Mark as printf-like functions.
591 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
592 Report overflow in size calculations when allocating printf buffer.
593 Do not truncate output string at its first null byte.
594 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
595 Truncate the output at a character boundary, since vsnprintf does not
596 do that.
597 * charset.c (check_iso_charset_parameter): Convert internal
598 character to string before calling 'error', since %c now has the
599 printf meaning.
600 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
601 overflow when computing char to be passed to 'error'. Do not
602 pass Lisp_Object to 'error'; pass the integer instead.
603 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
604 formatted with plain %d.
605
b189fa66
PE
606 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
607
bff87ef0
PE
608 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
609
7e2cac20
PE
610 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
611
ce4d90b5
PE
612 * xterm.c (x_catch_errors): Remove duplicate declaration.
613
266c9547
PE
614 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
615
79c49ad2
PE
616 * xdisp.c, lisp.h (message_nolog): Remove; unused.
617
368f4090
JM
6182011-04-10 Jim Meyering <meyering@redhat.com>
619
620 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
621 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
622 return ssize_t not "int", and use size_t as the buffer length.
623 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
624 * gnutls.h: Update declarations.
625 * process.c (read_process_output): Use ssize_t, to match.
626 (send_process): Likewise.
627
a32d4040
CY
6282011-04-09 Chong Yidong <cyd@stupidchicken.com>
629
630 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
631
8546720e 6322011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 633
8546720e
GM
634 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
635 unsigned char, to match FcChar8 type definition.
aac0c6e3 636
8546720e
GM
637 * xterm.c (handle_one_xevent):
638 * xmenu.c (create_and_show_popup_menu):
639 * xselect.c (x_decline_selection_request)
640 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 641
0a2f5c1a 6422011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
643
644 Fix some uses of `int' instead of EMACS_INT.
645 * search.c (string_match_1, fast_string_match)
646 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
647 (scan_buffer, find_next_newline_no_quit)
648 (find_before_next_newline, search_command, Freplace_match)
649 (Fmatch_data): Make some `int' variables be EMACS_INT.
650
651 * xdisp.c (display_count_lines): 3rd argument and return value now
652 EMACS_INT. All callers changed.
653 (pint2hrstr): Last argument is now EMACS_INT.
654
655 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
656 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
657 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
658 (decode_coding_utf_16, decode_coding_emacs_mule)
659 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
660 (decode_coding_ccl, decode_coding_charset)
661 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
662 (decode_coding_iso_2022, decode_coding_emacs_mule)
663 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
664 <char_offset, last_offset>: Declare EMACS_INT.
665 (encode_coding_utf_8, encode_coding_utf_16)
666 (encode_coding_emacs_mule, encode_invocation_designation)
667 (encode_designation_at_bol, encode_coding_iso_2022)
668 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
669 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
670 Declare EMACS_INT.
671 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
672 (encode_invocation_designation): Last argument P_NCHARS is now
673 EMACS_INT.
674 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
675 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
676
677 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
678 All users changed.
679
680 * ccl.c (Fccl_execute_on_string): Declare some variables
681 EMACS_INT.
682
8546720e 6832011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
684
685 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
686
4e19a977
CS
6872011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
688
689 * process.c (Fformat_network_address): Doc fix.
690
87302331
R
6912011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
692
693 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
694
cbb59342
CY
6952011-04-08 Chong Yidong <cyd@stupidchicken.com>
696
697 * keyboard.c (read_char): Call Lisp function help-form-show,
698 instead of using internal_with_output_to_temp_buffer.
699 (Qhelp_form_show): New var.
e0d38eeb 700 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
701
702 * print.c (internal_with_output_to_temp_buffer): Function deleted.
703
704 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
705
e67a13ab
CY
7062011-04-06 Chong Yidong <cyd@stupidchicken.com>
707
708 * process.c (Flist_processes): Removed to Lisp.
709 (list_processes_1): Deleted.
710
973f782d
EZ
7112011-04-06 Eli Zaretskii <eliz@gnu.org>
712
7c106b1e
EZ
713 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
714
973f782d
EZ
715 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
716
41cf7d1a 7172011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 718
ca23cc88
PE
719 Fix more problems found by GCC 4.6.0's static checks.
720
f390e2d5
PE
721 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
722
42eea0d0
PE
723 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
724
b69769da 725 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 726
f9541e84
PE
727 * xdisp.c (vmessage): Mark as a printf-like function.
728
13841b55
PE
729 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
730
c136c10f
PE
731 * sound.c (sound_warning): Don't crash if arg contains a printf format.
732
5e2d4a30
PE
733 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
734 printf-like functions.
735 (tiff_load): Add casts to remove these marks before passing them
736 to system-supplied API.
737
583f48b9
PE
738 * eval.c (Fsignal): Remove excess argument to 'fatal'.
739
b25d760e
PE
740 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
741 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
742 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
743 directly, rather than having caller test rule sign. This avoids
744 some unnecessary tests.
745 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
746 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
747 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 748
bc7b6697 749 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 750 (xfont_open): Avoid unnecessary tests.
bc7b6697 751
27ccc379
PE
752 * composite.c (composition_gstring_put_cache): Use unsigned integer.
753
dcd5c89a
PE
754 * composite.h, composite.c (composition_gstring_put_cache):
755 Use EMACS_INT, not int, for length.
756
b13a45c6
PE
757 * composite.h (COMPOSITION_DECODE_REFS): New macro,
758 breaking out part of COMPOSITION_DECODE_RULE.
759 (COMPOSITION_DECODE_RULE): Use it.
760 * composite.c (get_composition_id): Remove unused local vars,
761 by using the new macro.
762
1e792e4d
PE
763 * textprop.c (set_text_properties_1): Change while to do-while,
764 since the condition is always true at first.
765
dc6c6455 766 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
767 (interval_deletion_adjustment): Return unsigned value.
768 All uses changed.
dc6c6455 769
aba7731a
PE
770 * process.c (list_processes_1, create_pty, read_process_output):
771 (exec_sentinel): Remove vars that were set but not used.
afd4052b 772 (create_pty): Remove unnecessary "volatile"s.
bc57d757 773 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 774 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 775 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 776
fdfc4bf3
PE
777 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
778
fca8fe46 779 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 780 (update_syntax_table): Use unsigned instead of int.
fca8fe46 781
06a0259a 782 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 783 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 784 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 785
e7b9e80f
PE
786 * print.c (print_error_message): Avoid int overflow.
787
56201685
PE
788 * font.c (font_list_entities): Redo for clarity,
789 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
790
78834453 791 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 792 (font_score): Avoid potential overflow in diff calculation.
78834453 793
0bc0b309 794 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 795 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 796
e610eaca
PE
797 * eval.c (funcall_lambda): Rename local to avoid shadowing.
798
b895abce
PE
799 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
800 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
801 can always succeed if overflow has undefined behavior.
802
1f1d9321 803 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 804 (wordify): Omit three unnecessary tests.
1f1d9321 805
c59478bc
PE
806 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
807 All callers changed. This avoids the need for an unused var.
808
79b73827
PE
809 * casefiddle.c (casify_region): Remove var that is set but not used.
810
a4db5dfe
PE
811 * dired.c (file_name_completion): Remove var that is set but not used.
812
43aae36e
PE
813 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
814
2a47c44d 815 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 816 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 817
a37c69bf
PE
818 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
819 Check for integer overflow on size calculations.
820
328ab8e7
PE
821 * buffer.c (Fprevious_overlay_change): Remove var that is set
822 but not used.
823
e5a2a5cb
PE
824 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
825 Remove vars that are set but not used.
8d84a6eb 826 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 827 (timer_check_2): Mark vars as initialized.
e5a2a5cb 828
a60e5f68
PE
829 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
830
f661cb61 831 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 832 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 833
f0397f5a
PE
834 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
835 that are set but not used.
836
8664db06 837 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 838 if XCreateBitmapFromData fails (Bug#8410).
8664db06 839
6abdaa4a
PE
840 * xselect.c (x_get_local_selection, x_handle_property_notify):
841 Remove vars that are set but not used.
842
0ce7538d 843 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 844 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 845
9ae848fc
PE
846 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
847 Remove var that is set but not used.
0b918413
PE
848 (scroll_bar_windows_size): Now size_t, not int.
849 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
850 Check for overflow.
9ae848fc 851
a5a62657
PE
852 * xfaces.c (realize_named_face): Remove vars that are set but not used.
853 (map_tty_color) [!defined MSDOS]: Likewise.
854
5c5cdd39
PE
855 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
856
66ebf983
PE
857 * coding.c: Remove vars that are set but not used.
858 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
859 All callers changed.
860 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
861 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
862 (decode_coding_charset): Remove vars that are set but not used.
863
1be4d761
PE
864 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
865 that is set but not used.
866
47553fa8
PE
867 * print.c (print_object): Remove var that is set but not used.
868
1f7196bf 869 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
870 The gnulib version avoids calling malloc in the usual case,
871 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
872 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
873 * filelock.c (current_lock_owner): Likewise.
874 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
875 * sysdep.c: Include allocator.h, careadlinkat.h.
876 (emacs_no_realloc_allocator): New static constant.
877 (emacs_readlink): New function.
fdb61804
PE
878 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
879 ../lib/careadlinkat.h.
d1fdcab7 880
f84c17c7
SM
8812011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
882
883 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
884 first non-nil return value).
885
ef3862ad
JD
8862011-04-03 Jan Djärv <jan.h.d@swipnet.se>
887
888 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
889 if not defined (Bug#8403).
890
376a7006
JB
8912011-04-02 Juanma Barranquero <lekktu@gmail.com>
892
893 * xdisp.c (display_count_lines): Remove parameter `start',
894 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
895 (get_char_face_and_encoding): Remove parameter `multibyte_p',
896 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
897 (fill_stretch_glyph_string): Remove parameters `row' and `area',
898 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
899 and thereabouts. All callers changed.
900 (get_per_char_metric): Remove parameter `f', unused since
901 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
902
6ca3801d
JM
9032011-04-02 Jim Meyering <meyering@redhat.com>
904
905 do not dereference NULL upon failed strdup
906 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
907 (ns_get_family): Likewise.
908
d8e2b5ba
JB
9092011-04-02 Juanma Barranquero <lekktu@gmail.com>
910
911 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
912
8c74fcbd
JD
9132011-04-02 Jan Djärv <jan.h.d@swipnet.se>
914
915 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
916 later (Bug#8403).
917
7200d79c
SM
9182011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
919
03408648 920 Add lexical binding.
7200d79c 921
03408648
SM
922 * window.c (Ftemp_output_buffer_show): New fun.
923 (Fsave_window_excursion):
924 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
925
926 * lread.c (lisp_file_lexically_bound_p): New function.
927 (Fload): Bind Qlexical_binding.
928 (readevalloop): Remove `evalfun' arg.
929 Bind Qinternal_interpreter_environment.
930 (Feval_buffer): Bind Qlexical_binding.
931 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
932 Mark as dynamic.
933 (syms_of_lread): Declare `lexical-binding'.
934
935 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
936
937 * keyboard.c (eval_dyn): New fun.
938 (menu_item_eval_property): Use it.
ca105506
SM
939
940 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 941
03408648
SM
942 * fns.c (concat, mapcar1): Accept byte-code-functions.
943
944 * eval.c (Fsetq): Handle lexical vars.
945 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
946 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
947 (FletX, Flet): Obey lexical binding.
948 (Fcommandp): Handle closures.
949 (Feval): New `lexical' arg.
950 (eval_sub): New function extracted from Feval. Use it almost
951 everywhere where Feval was used. Look up vars in lexical env.
952 Handle closures.
953 (Ffunctionp): Move from subr.el.
954 (Ffuncall): Handle closures.
955 (apply_lambda): Remove `eval_flags'.
956 (funcall_lambda): Handle closures and new byte-code-functions.
957 (Fspecial_variable_p): New function.
958 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
959 but without exporting it to Lisp.
23aba0ea 960
23aba0ea 961 * doc.c (Fdocumentation, store_function_docstring):
03408648 962 * data.c (Finteractive_form): Handle closures.
23aba0ea 963
03408648
SM
964 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
965 interactive spec.
ba83908c 966
03408648
SM
967 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
968 byte-codes.
969 (exec_byte_code): New function extracted from Fbyte_code to handle new
970 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 971
03408648 972 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 973
03408648 974 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 975
e2abce01
JB
9762011-03-31 Juanma Barranquero <lekktu@gmail.com>
977
978 * xdisp.c (redisplay_internal): Fix prototype.
979
63696a73 9802011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 981
63696a73
EZ
982 * xdisp.c (SCROLL_LIMIT): New macro.
983 (try_scrolling): Use it when setting scroll_limit. Limit
984 scrolling to 100 screen lines.
985 (redisplay_window): Even when falling back on "recentering",
986 position point in the window according to scroll-conservatively,
987 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
988
989 (try_scrolling): When point is above the window, allow searching
990 as far as scroll_max, or one screenful, to compute vertical
991 distance from PT to the scroll margin position. This prevents
992 try_scrolling from unnecessarily failing when
993 scroll-conservatively is set to a value slightly larger than the
994 window height. Clean up the case of PT below the margin at bottom
995 of window: scroll_max can no longer be INT_MAX. When aggressive
996 scrolling is in use, don't let point enter the opposite scroll
997 margin as result of the scroll.
998 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
999 threshold of 100 lines for never-recentering scrolling.
1000
e4cc2dfc
JB
10012011-03-31 Juanma Barranquero <lekktu@gmail.com>
1002
1003 * dispextern.h (move_it_by_lines):
1004 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1005 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1006 (message_log_check_duplicate): Remove parameters `prev_bol' and
1007 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1008 (redisplay_internal): Remove parameter `preserve_echo_area',
1009 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1010
1011 * indent.c (Fvertical_motion):
1012 * window.c (window_scroll_pixel_based, Frecenter):
1013 Don't pass `need_y_p' to `move_it_by_lines'.
1014
1c470562
SM
10152011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1016
44f230aa
SM
1017 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1018 steal a few bits to be more compact.
1019 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1020 Remove unneeded casts.
1021
1c470562
SM
1022 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1023
888adce9
ZK
10242011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1025
1026 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1027 binding" message (bug#7967).
1028
f838ed7b
PE
10292011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1030
77861b95
PE
1031 Fix more problems found by GCC 4.6.0's static checks.
1032
de6dbc14
PE
1033 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1034 Remove unused local var.
1035
f838ed7b
PE
1036 * editfns.c (Fmessage_box): Remove unused local var.
1037
792c7b2b
PE
1038 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1039 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1040 Omit unused local vars.
c499e557 1041 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1042 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1043 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1044 Omit unused local var.
1045
ba0165e1
PE
1046 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1047 Don't assume string length fits in int.
32ad8845 1048 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1049 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1050
3c59b4c9
PE
1051 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1052 instead of alloca (Bug#8344).
1053
a3eed478 1054 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1055 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1056
eb4d412d
PE
1057 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1058
1658b401
PE
1059 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1060 concerns.
1061
1062 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1063
1064 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1065
9a2c6e05
PE
1066 * keyboard.c (syms_of_keyboard): Use the same style as later
1067 in this function when indexing through an array. This also
1068 works around GCC bug 48267.
1069
03d0a109
PE
1070 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1071
44f730c8
PE
1072 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1073
fe75f926
PE
1074 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1075 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1076
ffa8c828
PE
1077 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1078 This avoids undefined behavior on integer overflow, and is a bit
1079 more convenient anyway since it is compared to a size_t variable.
1080
c5101a77
PE
1081 Variadic C functions now count arguments with size_t, not int.
1082 This avoids an unnecessary limitation on 64-bit machines, which
1083 caused (substring ...) to crash on large vectors (Bug#8344).
1084 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1085 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1086 All variadic functions and their callers changed accordingly.
c5101a77
PE
1087 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1088 * data.c (arith_driver, float_arith_driver): Likewise.
1089 * editfns.c (general_insert_function): Likewise.
1090 * eval.c (struct backtrace.nargs, interactive_p)
1091 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1092 (funcall_lambda, mark_backtrace): Likewise.
1093 * fns.c (concat): Likewise.
1094 * frame.c (x_set_frame_parameters): Likewise.
1095 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1096 0 if not found, not -1. All callers changed.
1097
dd3f25f7
PE
1098 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1099 (stack_copy_size): Now size_t, not int.
1100 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1101
461c2ab9
JB
11022011-03-28 Juanma Barranquero <lekktu@gmail.com>
1103
1104 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1105 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1106 All callers changed.
1107
1108 * lisp.h (multibyte_char_to_unibyte):
1109 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1110 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1111 * character.h (CHAR_TO_BYTE8):
1112 * cmds.c (internal_self_insert):
1113 * editfns.c (general_insert_function):
1114 * keymap.c (push_key_description):
1115 * search.c (Freplace_match):
1116 * xdisp.c (message_dolog, set_message_1): All callers changed.
1117
f6d62986
SM
11182011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1119
1120 * keyboard.c (safe_run_hook_funcall): New function.
1121 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1122 don't set the hook to nil, but remove the offending function instead.
1123 (Qcommand_hook_internal): Remove, unused.
1124 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1125 Vcommand_hook_internal.
1126
1127 * eval.c (enum run_hooks_condition): Remove.
1128 (funcall_nil, funcall_not): New functions.
1129 (run_hook_with_args): Call each function through a `funcall' argument.
1130 Remove `cond' argument, now redundant.
1131 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1132 (Frun_hook_with_args_until_failure): Adjust accordingly.
1133 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1134
1db5b1ad
JB
11352011-03-28 Juanma Barranquero <lekktu@gmail.com>
1136
1137 * dispextern.h (string_buffer_position): Remove declaration.
1138
1139 * print.c (strout): Remove parameter `multibyte', unused since
1140 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1141
1142 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1143 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1144 All callers changed.
1145
1146 * w32.c (_wsa_errlist): Use braces for struct initializers.
1147
1148 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1149 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1150 All callers changed.
1151 (string_buffer_position): Likewise. Also, make static (it's never
1152 used outside xdisp.c).
1153 (cursor_row_p): Remove parameter `w', unused since
1154 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1155 (decode_mode_spec): Remove parameter `precision', introduced during
1156 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1157 All callers changed.
1158
5ffb62aa
JD
11592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1160
1161 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1162
461c2ab9 11632011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1164
1165 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1166 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1167 (ns_update_auto_hide_menu_bar): New functions.
1168 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1169 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1170 ns_constrain_all_frames.
1171 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1172 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1173
5c380ffb
JD
11742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1175
1176 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1177
9af30bdf
GM
11782011-03-27 Glenn Morris <rgm@gnu.org>
1179
1180 * syssignal.h: Replace RETSIGTYPE with void.
1181 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1182 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1183 Replace SIGTYPE with void everywhere.
1184 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1185 * s/template.h (SIGTYPE): Remove commented out definition.
1186
e2abce01
JB
11872011-03-26 Eli Zaretskii <eliz@gnu.org>
1188
1189 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1190 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1191
f868cd8a
JB
11922011-03-26 Juanma Barranquero <lekktu@gmail.com>
1193
59eb0929
JB
1194 * w32.c (read_unc_volume): Use parameter `henum', instead of
1195 global variable `wget_enum_handle'.
1196
1197 * keymap.c (describe_vector): Remove parameters `indices' and
1198 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1199 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1200
f868cd8a
JB
1201 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1202
1203 * keyboard.c (timer_check): Remove parameter `do_it_now',
1204 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1205 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1206 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1207
1208 * keyboard.c (read_char):
1209 * w32menu.c (w32_menu_display_help):
1210 * xmenu.c (show_help_event, menu_help_callback):
1211 Adjust calls to `show_help_echo'.
1212
1213 * gtkutil.c (xg_maybe_add_timer):
1214 * keyboard.c (readable_events):
1215 * process.c (wait_reading_process_output):
1216 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1217
1218 * insdel.c (adjust_markers_gap_motion):
1219 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1220 (gap_left, gap_right): Don't call it.
1221
2ecf6fdb
CY
12222011-03-25 Chong Yidong <cyd@stupidchicken.com>
1223
1224 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1225 incurred during fontification.
1226
6b1f9ba4
JB
12272011-03-25 Juanma Barranquero <lekktu@gmail.com>
1228
1229 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1230 (DEFVAR_PER_BUFFER): Don't pass it.
1231
1232 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1233 (scrolling_window): Don't pass it.
1234
0f4a96b5
JB
12352011-03-25 Juanma Barranquero <lekktu@gmail.com>
1236
1237 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1238
1239 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1240 and `suffix'.
1241 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1242 of variables specific to SELinux and computation of `encoded_absname'.
1243
1244 * image.c (XPutPixel): Remove unused variable `height'.
1245
1246 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1247
1248 * unexw32.c (get_section_info): Remove unused variable `section'.
1249
1250 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1251 (system_process_attributes): Remove unused variable `sess'.
1252 (sys_read): Remove unused variable `err'.
1253
1254 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1255 (w32_wnd_proc): Remove unused variable `isdead'.
1256 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1257 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1258 (x_create_tip_frame): Remove unused variable `tem'.
1259
1260 * w32inevt.c (w32_console_read_socket):
1261 Remove unused variable `no_events'.
1262
1263 * w32term.c (x_draw_composite_glyph_string_foreground):
1264 Remove unused variable `width'.
1265
1149507c
JB
12662011-03-24 Juanma Barranquero <lekktu@gmail.com>
1267
1268 * w32term.c (x_set_glyph_string_clipping):
1269 Don't pass uninitialized region to CombineRgn.
1270
9c88f339
JB
12712011-03-23 Juanma Barranquero <lekktu@gmail.com>
1272
1273 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1274 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1275 (Fx_close_connection): Remove unused variable `i'.
1276
1277 * w32font.c (w32font_draw): Return number of glyphs.
1278 (w32font_open_internal): Remove unused variable `i'.
1279 (w32font_driver): Add missing initializer.
1280
1281 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1282 (fill_in_menu): Remove unused variable `items_added'.
1283
1284 * w32term.c (last_mouse_press_frame): Remove static global variable.
1285 (w32_clip_to_row): Remove unused variable `f'.
1286 (x_delete_terminal): Remove unused variable `i'.
1287
1288 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1289 (NOTHING): Remove unused static global variable.
1290 (uniscribe_check_otf): Remove unused variable `table'.
1291 (uniscribe_font_driver): Add missing initializers.
1292
dee091a3
JD
12932011-03-23 Julien Danjou <julien@danjou.info>
1294
1295 * term.c (Fsuspend_tty, Fresume_tty):
1296 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1297 * window.c (temp_output_buffer_show):
1298 * insdel.c (signal_before_change):
1299 * frame.c (Fhandle_switch_frame):
1300 * fileio.c (Fdo_auto_save):
1301 * emacs.c (Fkill_emacs):
1302 * editfns.c (save_excursion_restore):
1303 * cmds.c (internal_self_insert):
1304 * callint.c (Fcall_interactively):
1305 * buffer.c (Fkill_all_local_variables):
1306 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1307 Use Frun_hooks.
0f4a96b5 1308 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1309 unconditionnaly since it does the check itself.
1310
2c520ab5 13112011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1312
c9c49752
PE
1313 Fix more problems found by GCC 4.5.2's static checks.
1314
8abc3f12
PE
1315 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1316 the first time through the loop, since we know p0 < p1 then.
1317 This also avoids a gcc -Wstrict-overflow warning.
1318
a2d26660
PE
1319 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1320 leading to a memory leak, possible in functions like
1321 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1322 of objects (Bug#8318).
a2d26660 1323
916c72e9
PE
1324 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1325 that could (at least in theory) be that large.
1326
19ab8a18
PE
1327 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1328 This is less likely to overflow, and avoids undefined behavior if
1329 overflow does occur. All callers changed. Use strtoul to scan
1330 for the unsigned long integer.
b7cbbd6f
PE
1331 (pint2hrstr): Simplify and tune code slightly.
1332 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1333
f0641eff
PE
1334 * scroll.c (do_scrolling): Work around GCC bug 48228.
1335 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1336
7f650bb9
PE
1337 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1338 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1339 (validate_x_resource_name): Simplify count usage.
1340 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1341
37dd57d1
PE
1342 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1343 fail (Bug#8306).
81e56e61 1344
699979fc 1345 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1346
401bf9b4
PE
1347 * process.c (Fmake_network_process): Use socklen_t, not int,
1348 where POSIX says socklen_t is required in portable programs.
1349 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1350 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1351 (Fmake_network_process, server_accept_connection):
1352 (wait_reading_process_output, read_process_output):
1353 Likewise.
1354
b93aacde
PE
1355 * process.c: Rename or move locals to avoid shadowing.
1356 (list_processes_1, Fmake_network_process):
1357 (read_process_output_error_handler, exec_sentinel_error_handler):
1358 Rename or move locals.
4dc343ee 1359 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1360 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1361 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1362 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1363 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1364
af8a867c 1365 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1366 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1367 Include tparam.h instead, since it declares them.
af8a867c
PE
1368 * cm.h (PC): Remove extern decl; tparam.h now does this.
1369 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1370 * terminfo.c: Include tparam.h, to check interfaces.
1371 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1372 (tparam): Adjust signature to match interface in tparam.h;
1373 this removes some undefined behavior. Check that outstring and len
1374 are zero, which they always are with Emacs.
1375 * tparam.h (PC, BC, UP): New extern decls.
1376
0248044d 1377 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1378 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1379
8ff096c1 1380 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1381 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1382 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1383 (ftfont_list): Remove unused local.
49eaafba
PE
1384 (get_adstyle_property, ftfont_pattern_entity):
1385 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1386 Rename locals to avoid shadowing.
8ff096c1 1387
e2be39f6
PE
1388 * xfont.c (xfont_list_family): Mark var as initialized.
1389
c9735e30
PE
1390 * xml.c (make_dom): Now static.
1391
8f5201ae
PE
1392 * composite.c (composition_compute_stop_pos): Rename local to
1393 avoid shadowing.
b246f932
PE
1394 (composition_reseat_it): Remove unused locals.
1395 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1396 (composition_update_it): Mark var as initialized.
11b61122
PE
1397 (find_automatic_composition): Mark vars as initialized,
1398 with a FIXME (Bug#8290).
8f5201ae 1399
760fbc2c
PE
1400 character.h: Rename locals to avoid shadowing.
1401 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1402 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1403 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1404 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1405 to avoid shadowing.
1406
ff08eb85
PE
1407 * textprop.c (property_change_between_p): Remove; unused.
1408
fc7bf025
PE
1409 * intervals.c (interval_start_pos): Now static.
1410
235d7abc
PE
1411 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1412
44f230aa
SM
1413 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1414 Rename locals to avoid shadowing.
3e7d6594 1415
50060332
PE
1416 * sound.c (wav_play, au_play, Fplay_sound_internal):
1417 Fix pointer signedness.
d01f234b 1418 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1419 (wav_play): Initialize a variable to 0, to prevent undefined
1420 behavior (Bug#8278).
50060332 1421
c4fc4e30
PE
1422 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1423
918436ed
PE
1424 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1425
c939f91b
PE
1426 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1427 clobbering (Bug#8298).
b9c7f648
PE
1428 * sysdep.c (sys_subshell): Likewise.
1429 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1430
6bd8c144
PE
1431 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1432 This should get cleaned up, so that child_setup has the
1433 same signature on all platforms.
1434
7710357c 1435 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1436 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1437
c59da222
CY
14382011-03-22 Chong Yidong <cyd@stupidchicken.com>
1439
1440 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1441 not to be necessary, and produces flickering.
1442
66b87493
GM
14432011-03-20 Glenn Morris <rgm@gnu.org>
1444
1445 * config.in: Remove file.
1446
45b6f6d5
JB
14472011-03-20 Juanma Barranquero <lekktu@gmail.com>
1448
1449 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1450 are now in src/globals.h.
1451 (syms_of_minibuf): Remove spurious & from previous change.
1452
3ec03f7e
LL
14532011-03-20 Leo <sdl.web@gmail.com>
1454
1455 * minibuf.c (completing-read-function): New variable.
1456 (completing-read-default): Rename from completing-read.
1457 (completing-read): Call completing-read-function.
1458
b14e3e21
CY
14592011-03-19 Juanma Barranquero <lekktu@gmail.com>
1460
1461 * xfaces.c (Fx_load_color_file):
1462 Read color file from absolute filename (bug#8250).
1463
f2b726e6
JB
14642011-03-19 Juanma Barranquero <lekktu@gmail.com>
1465
1466 * makefile.w32-in: Update dependencies.
1467
09f6ff02
EZ
14682011-03-17 Eli Zaretskii <eliz@gnu.org>
1469
1470 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1471
29a6015a
PE
14722011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1473
a3a6c54e
PE
1474 Fix more problems found by GCC 4.5.2's static checks.
1475
b766f867
PE
1476 * process.c (make_serial_process_unwind, send_process_trap):
1477 (sigchld_handler): Now static.
1478
be02381c
PE
1479 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1480 That way, the code declares only the vars that it needs.
1481 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1482 * s/cygwin.h (PTY_ITERATION): Likewise.
1483 * s/darwin.h (PTY_ITERATION): Likewise.
1484 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1485
57048744
PE
1486 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1487 * process.c (allocate_pty): Don't declare stb unless it's needed.
1488
7914961c 1489 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1490 (CONSTANTLIM): Remove; unused.
1491 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1492 Define only if needed.
7914961c 1493
b3967b18
PE
1494 * unexelf.c (unexec): Name an expression,
1495 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1496 Use a different way to cause a compilation error if anyone uses
1497 n rather than nn, a way that does not involve shadowing.
73366a00 1498 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1499
29a6015a
PE
1500 * deps.mk (unexalpha.o): Remove; unused.
1501
43cfc33e 1502 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1503 * unexec.h: New file.
ce701a33
PE
1504 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1505 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1506 Depend on unexec.h.
1507 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1508 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1509 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1510 Change as necessary to match prototype in unexec.h.
ce701a33 1511
01f44d5a
PE
1512 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1513 shadowing.
4f63c6bb 1514 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1515
a6670b0b
PE
1516 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1517 Rename locals to avoid shadowing.
1518
cef2010d 1519 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1520 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1521
d4d7173a
PE
1522 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1523
f08b802a
PE
1524 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1525 warning when compiling print.c.
1526
3ddb0639
PE
1527 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1528 instead of using an uninitialized var.
5ad03b97 1529 (font_sort_entities): Mark var as initialized.
3ddb0639 1530
170a2692
PE
1531 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1532
e663c700
PE
1533 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1534 pointers to constants.
89bc529a 1535 (font_parse_fcname): Remove unused vars.
7b81e2d0 1536 (font_delete_unmatched): Now static.
ea838e10 1537 (font_get_spec): Remove; unused.
13a547c6
PE
1538 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1539 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1540 Rename or move locals to avoid shadowing.
e663c700 1541
2a80c887 1542 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1543 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1544
1384fa33 1545 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1546 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1547
8b2c52e9
PE
1548 * alloc.c (mark_backtrace): Move decl from here ...
1549 * lisp.h: ... to here, so that it can be checked.
1550
475545b5 1551 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1552 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1553 (lisp_indirect_variable): Name an expression,
1554 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1555 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1556
b1349114 1557 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1558 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1559 Use const pointer when appropriate.
b1349114 1560
a2928364
PE
1561 * lisp.h (get_system_name, get_operating_system_release):
1562 Move decls here, to check interfaces.
1563 * process.c (get_operating_system_release): Move decl to lisp.h.
1564 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1565 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1566 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1567 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1568 (Fformat_time_string, Fencode_time, Finsert_char):
1569 (Ftranslate_region_internal, Fformat):
1570 Rename or remove local vars to avoid shadowing.
9710023e 1571 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1572
a415e694
PE
1573 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1574 avoid shadowing.
1575
8ef4622d
PE
1576 * lisp.h (eassert): Check that the argument compiles, even if
1577 ENABLE_CHECKING is not defined.
1578
946f9a5b
PE
1579 * data.c (Findirect_variable): Name an expression, to avoid
1580 gcc -Wbad-function-cast warning.
112396d6 1581 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1582 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1583 (Fmake_variable_buffer_local, Fmake_local_variable):
1584 Mark variables as initialized.
52746918 1585 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1586
e5aab7e7 1587 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1588 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1589 Rename locals to avoid shadowing.
dff45157
PE
1590 (mark_stack): Move local variables into the #ifdef region where
1591 they're used.
7bc26fdb
PE
1592 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1593 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1594 needed otherwise.
1595 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1596 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1597 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1598
e5aab7e7
PE
1599 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1600 avoids undefined behavior in theory.
1601
4da60324
PE
1602 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1603
88043301
PE
1604 Use functions, not macros, for up- and down-casing (Bug#8254).
1605 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1606 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1607 to use the following functions instead of these macros.
1608 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1609 EMACS_INT, since callers assume the returned value fits in int.
1610 (upcase1): Likewise, for UPCASE_TABLE.
1611 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1612 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1613 the race-condition problem in the old DOWNCASE.
88043301 1614
19ed5445
PE
1615 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1616 Rename locals to avoid shadowing.
1617 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1618 (regex_compile, re_search_2, re_match_2_internal):
1619 Remove unused local vars.
952db0d7
PE
1620 (FREE_VAR): Rewrite so as not to use empty "else",
1621 which gcc can warn about.
da053e48 1622 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1623 (RETALLOC_IF): Define only if needed.
1624 (WORDCHAR_P): Likewise. This one is never needed, but is used
1625 only in a comment talking about a compiler bug, so put inside
1626 the #if 0 of that comment.
1627 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1628 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1629 Remove; unused.
19ed5445 1630
1f3561e4 1631 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1632 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1633 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1634
ded6f8f7
PE
1635 * search.c (simple_search): Remove unused var.
1636
dbd37a95
PE
1637 * dired.c (compile_pattern): Move decl from here ...
1638 * lisp.h: ... to here, so that it can be checked.
1639 (struct re_registers): New forward decl.
1640
7e47afad
PE
1641 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1642
85f24f61
PE
1643 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1644 All uses changed.
1645 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1646 Rename locals to avoid shadowing.
5671df8f 1647 (Fvertical_motion): Mark locals as initialized.
85f24f61 1648
181aa2be 1649 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1650 (casify_region): Mark local as initialized.
181aa2be 1651
930d429c
PE
1652 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1653
7082eac6
PE
1654 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1655 New macros, so that the caller can use some names other than
1656 gcpro1, gcpro2, etc.
1657 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1658 of the new macros.
1659 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1660 argument, for consistency with GCPRO2_VAR, etc: it is now the
1661 prefix of the variable, not the variable itself. All uses
1662 changed.
38b2c076
PE
1663 * dired.c (directory_files_internal, file_name_completion):
1664 Rename locals to avoid shadowing.
1665
15206ed9
PE
1666 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1667 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1668 dired.c's scmp function, had undefined behavior.
1669 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1670 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1671 * buffer.h: ... to here, because these macros use current_buffer,
1672 and the new implementation with inline functions needs to have
1673 current_buffer in scope now, rather than later when the macros
1674 are used.
1675 (downcase, upcase1): New static inline functions.
1676 (DOWNCASE, UPCASE1): Reimplement using these functions.
1677 This avoids undefined behavior in expressions like
1678 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1679 from race conditions in accessing the global variables
1680 case_temp1 and case_temp2.
1681 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1682 * lisp.h (case_temp1, case_temp2): Remove their decls.
1683 * character.h (ASCII_CHAR_P): Move from here ...
1684 * lisp.h: ... to here, so that the inline functions mentioned
1685 above can use them.
1686
4a6bea26
PE
1687 * dired.c (directory_files_internal_unwind): Now static.
1688
f14b7e14
PE
1689 * fileio.c (file_name_as_directory, directory_file_name):
1690 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1691 Now static.
2893f146
PE
1692 (file_name_as_directory): Use const pointers when appropriate.
1693 (Fexpand_file_name): Likewise. In particular, newdir might
1694 point at constant storage, so make it a const pointer.
fd4ead52 1695 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1696 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1697 signedness issues.
f839df0c
PE
1698 (Fset_file_times, Finsert_file_contents, auto_save_error):
1699 Rename locals to avoid shadowing.
f14b7e14 1700
5716756e 1701 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1702 (Ftry_completion, Fall_completions): Rename or remove locals
1703 to avoid shadowing.
5716756e 1704
b4c3046a
PE
1705 * marker.c (bytepos_to_charpos): Remove; unused.
1706
b45db522
PE
1707 * lisp.h (verify_bytepos, count_markers): New decls,
1708 so that gcc does not warn that these functions aren't declared.
1709
85876d07
PE
1710 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1711 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1712 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1713 (copy_text): Remove unused local var.
85876d07 1714
03d78a21 1715 * filelock.c (within_one_second): Now static.
b3dd38ab 1716 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1717
5df8f01b
PE
1718 * buffer.c (fix_overlays_before): Mark locals as initialized.
1719 (fix_start_end_in_overlays): Likewise. This function should be
1720 simplified by using pointers-to-pointers, but that's a different
1721 matter.
b1d876f1 1722 (switch_to_buffer_1): Now static.
8f54f30a
PE
1723 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1724 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1725
a70072c9 1726 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1727 Fix pointer signedness issue.
edced198
PE
1728 (sys_subshell): Mark local as volatile if checking for lint,
1729 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1730 (MAXPATHLEN): Define only if needed.
a70072c9 1731
a0977c44
PE
1732 * process.c (serial_open, serial_configure): Move decls from here ...
1733 * systty.h: ... to here, so that they can be checked.
1734
a884fdcc
PE
1735 * fns.c (get_random, seed_random): Move extern decls from here ...
1736 * lisp.h: ... to here, so that they can be checked.
1737
604efe86 1738 * sysdep.c (reset_io): Now static.
b8950c94 1739 (wait_for_termination_signal): Remove; unused.
604efe86 1740
38fc62d9
PE
1741 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1742 (copy_keymap_item, append_key, push_text_char_description):
1743 Now static.
1004a21a 1744 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1745 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1746 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1747 (describe_map_tree):
1748 Rename locals to avoid shadowing.
38fc62d9 1749
2f2650da
PE
1750 * keyboard.c: Declare functions static if they are not used elsewhere.
1751 (echo_char, echo_dash, cmd_error, top_level_2):
1752 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1753 (read_char, kbd_buffer_get_event, make_lispy_position):
1754 (make_lispy_event, make_lispy_movement, apply_modifiers):
1755 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1756 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1757 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1758 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1759 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1760
a053e86c 1761 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1762 (mark_kboards): Move decl here ...
1763 * alloc.c (mark_kboards): ... from here.
a053e86c 1764
4752793e
PE
1765 * lisp.h (force_auto_save_soon): New decl.
1766
74f10ca7 1767 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1768 (DEFINE_DUMMY_FUNCTION): New macro.
1769 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1770 Use it.
c03cd23f
PE
1771 (main): Add casts to avoid warnings
1772 if GCC considers string literals to be constants.
74f10ca7 1773
022e70d4
PE
1774 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1775
59d6fe83
PE
1776 * dbusbind.c: Pointer signedness fixes.
1777 (xd_signature, xd_append_arg, xd_initialize):
1778 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1779 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1780 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1781 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1782
78320123
PE
1783 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1784 if GCC considers string literals to be constants.
49cebcca 1785 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1786
35ac2a97
SM
17872011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1788
fb103ca9
SM
1789 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1790 (print_preprocess, print_object): New macro to fix last change.
1791
35ac2a97
SM
1792 * print.c (print_preprocess): Don't forget font objects.
1793
62973b41
JB
17942011-03-16 Juanma Barranquero <lekktu@gmail.com>
1795
1796 * emacs.c (USAGE3): Doc fixes.
1797
0e48bb22
AS
17982011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1799
1800 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1801 structure.
1802
7684e57b
JB
18032011-03-14 Juanma Barranquero <lekktu@gmail.com>
1804
1805 * lisp.h (VWindow_system, Qfile_name_history):
1806 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1807 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1808 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1809
1810 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1811 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1812
1813 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1814 * w32console.c (detect_input_pending, read_input_pending)
1815 (encode_terminal_code):
1816 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1817 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1818 (w32_system_caret_y, Qfile_name_history):
1819 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1820 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1821 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1822 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1823 * w32proc.c (Qlocal, report_file_error):
1824 * w32term.c (Vwindow_system, updating_frame):
1825 * w32uniscribe.c (initialized, uniscribe_font_driver):
1826 Remove unneeded extern declarations.
1827
2aa46d6c
CY
18282011-03-14 Chong Yidong <cyd@stupidchicken.com>
1829
c96bbc66 1830 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1831
cffc6f3b
CY
18322011-03-13 Chong Yidong <cyd@stupidchicken.com>
1833
1834 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1835 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1836 These macros can no longer be used for assignment.
1837
44f230aa
SM
1838 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1839 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1840 (record_buffer_markers, fetch_buffer_markers): New functions for
1841 recording and fetching special buffer markers.
1842 (set_buffer_internal_1, set_buffer_temp): Use them.
1843
1844 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1845
1846 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1847
1848 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1849 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1850
1851 * xdisp.c (hscroll_window_tree):
1852 (reconsider_clip_changes): Use PT instead of BUF_PT.
1853
d251f04b
EZ
18542011-03-13 Eli Zaretskii <eliz@gnu.org>
1855
1856 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1857 $(EMACS_ROOT)/lib/intprops.h.
1858
f0c77cd1
PE
18592011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1860
3eca4629
PE
1861 Fix more problems found by GCC 4.5.2's static checks.
1862
7c86ee98
PE
1863 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1864 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1865 (xg_free_frame_widgets): Make it clear that a local variable is
1866 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1867 (gdk_window_get_screen): Make it clear that this macro is needed
1868 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1869 (int_gtk_range_get_value): New function, which avoids a diagnostic
1870 from gcc -Wbad-function-cast.
1871 (xg_set_toolkit_scroll_bar_thumb): Use it.
1872 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1873 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1874 (get_utf8_string, xg_get_file_with_chooser):
1875 Rename locals to avoid shadowing.
1876 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1877
41729b81
PE
1878 * xgselect.c (xg_select): Remove unused var.
1879
f0c77cd1
PE
1880 * image.c (four_corners_best): Mark locals as initialized.
1881 (gif_load): Initialize transparent_p to zero (Bug#8238).
1882 Mark another local as initialized.
ec6cf4c6 1883 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1884
ce0ad53d 1885 * image.c (clear_image_cache): Now static.
d5d5a617 1886 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1887 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1888 (x_edge_detection): Remove unnecessary cast that
1889 gcc -Wbad-function-cast diagnoses.
2037898d 1890 (gif_load): Fix pointer signedness.
6ae141d6
PE
1891 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1892 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1893
33383987 18942011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1895
d32df629
PE
1896 Improve quality of tests for time stamp overflow.
1897 For example, without this patch (encode-time 0 0 0 1 1
1898 1152921504606846976) returns the obviously-bogus value (-948597
1899 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1900 reports time overflow. See
1901 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1902 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1903 * editfns.c: Include limits.h and intprops.h.
1904 (TIME_T_MIN, TIME_T_MAX): New macros.
1905 (time_overflow): Move earlier, to before first use.
1906 (hi_time, lo_time): New functions, for an accurate test for
1907 out-of-range times.
1908 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1909 (Fget_internal_run_time): Don't assume time_t fits in int.
1910 (make_time): Use list2 instead of Fcons twice.
1911 (Fdecode_time): More accurate test for out-of-range times.
1912 (check_tm_member): New function.
1913 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1914 (lisp_time_argument): Don't rely on undefined left-shift and
1915 right-shift behavior when checking for time stamp overflow.
8be6f318 1916
fe31d94c
PE
1917 * editfns.c (time_overflow): New function, refactoring common code.
1918 (Fformat_time_string, Fdecode_time, Fencode_time):
1919 (Fcurrent_time_string): Use it.
1920
8be6f318
PE
1921 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1922 * dired.c (make_time): Move to ...
1923 * editfns.c (make_time): ... here.
1924 * systime.h: Note the move.
1925
09d9db2c 19262011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1927
126bc0dc
YM
1928 * fringe.c (update_window_fringes): Remove unused variables.
1929
c47cbdfd
YM
1930 * unexmacosx.c (copy_data_segment): Also copy __got section.
1931 (Bug#8223)
1932
7ac80be9
EZ
19332011-03-12 Eli Zaretskii <eliz@gnu.org>
1934
c96bbc66 1935 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1936 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1937 Constify `char *' arguments and their references according to
1938 prototypes in tparam.h.
1939
ecb0f94d 1940 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1941
7ac80be9
EZ
1942 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1943 Adapt all references accordingly.
1944
1945 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1946
ef1fd07e
TT
19472011-03-11 Tom Tromey <tromey@redhat.com>
1948
1949 * buffer.c (syms_of_buffer): Remove obsolete comment.
1950
7ef4b50c
EZ
19512011-03-11 Eli Zaretskii <eliz@gnu.org>
1952
1953 * termhooks.h (encode_terminal_code): Declare prototype.
1954
1955 * msdos.c (encode_terminal_code): Don't declare prototype.
1956
1957 * term.c (encode_terminal_code): Now external again, used by
1958 w32console.c and msdos.c.
1959
44f230aa
SM
1960 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1961 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1962
4b1ec863 19632011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1964
1714f52b 1965 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1966
4b1ec863
PE
1967 * fringe.c (update_window_fringes): Mark locals as initialized
1968 (Bug#8227).
1969 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1970
524c7aa6
PE
1971 * alloc.c (mark_fringe_data): Move decl from here ...
1972 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1973 to check its interface.
1974 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1975
a5c0af81 1976 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1977 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1978 (fontset_font): Mark local as initialized.
a9a06e0b 1979 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1980
b4716021
PE
1981 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1982
811e9bac 1983 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1984 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1985 (x_own_selection, Fx_disown_selection_internal): Rename locals
1986 to avoid shadowing.
1987 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1988
7e3ab302
PE
1989 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1990 so that the caller can use some name other than gcpro1.
1991 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1992 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1993 (Fx_backspace_delete_keys_p):
1994 Use them to avoid shadowing, and rename vars to avoid shadowing.
1995 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1996 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1997 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1998 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1999 Remove unused locals.
7e3ab302
PE
2000 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2001 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2002 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2003 macros.
f78faa98 2004
e2b13473
PE
2005 * xterm.h (x_mouse_leave): New decl.
2006
77f23912
PE
2007 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2008 Remove unused functions.
cdf4ba58
PE
2009 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2010 (x_calc_absolute_position): Now static.
7411c686 2011 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2012 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2013 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2014 unless they are used.
38d0b34a
PE
2015 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2016 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2017 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2018 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2019 (x_error_catcher, x_connection_closed, x_error_handler):
2020 (x_error_quitter, xembed_send_message, x_iconify_frame):
2021 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2022 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2023 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2024
44f230aa
SM
2025 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2026 Rename or move locals to avoid shadowing.
6b463e58 2027 (tty_defined_color, merge_face_heights): Now static.
5967d051 2028 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2029 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2030 does not deduce is never used uninitialized.
73719eba
PE
2031 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2032 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2033
426994c3 2034 * terminal.c (store_terminal_param): Now static.
5489860b 2035
032f1620 2036 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2037 (set_frame_menubar): Remove unused local.
d4323972 2038 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2039 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2040 since they might point to immutable storage.
281585b0
PE
2041 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2042 since it's unused otherwise.
032f1620 2043
367c19e5 2044 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2045 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2046 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2047 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2048 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2049 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2050 does not deduce are never used uninitialized.
70739cbe 2051
07b48fa9
PE
2052 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2053
8868a238 2054 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2055 * window.c (window_loop, size_window):
2056 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2057
7e5cf297 2058 * window.c (display_buffer): Now static.
d6550a9f
PE
2059 (size_window): Mark variables that gcc -Wuninitialized
2060 does not deduce are never used uninitialized.
a586633d
PE
2061 * window.h (check_all_windows): New decl, to forestall
2062 gcc -Wmissing-prototypes diagnostic.
5b555da1 2063 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2064
f6095868
PE
2065 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2066 shadowing.
2067 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2068 Include <limits.h>.
2069 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2070 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2071 (load_charset_map): Mark variables that gcc -Wuninitialized
2072 does not deduce are never used uninitialized.
53df7c11 2073 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2074
f38b440c
PE
2075 * coding.c (coding_set_source, coding_set_destination):
2076 Use "else { /* comment */ }" rather than "else /* comment */;"
2077 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2078 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2079 a block, when the outer 'i' will do.
2080 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2081 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2082 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2083 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2084 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2085 Rename locals to avoid shadowing.
2086 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2087 * coding.c (emacs_mule_char, encode_invocation_designation):
2088 Now static, since they're not used elsewhere.
413bb2db 2089 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2090 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2091 (decode_coding_emacs_mule): Mark variables that gcc
2092 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2093 (detect_coding_iso_2022): Initialize a local variable that might
2094 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2095 this initialization is needed. (Bug#8211)
5f58e762
PE
2096 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2097 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2098 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2099 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2100 Remove unused macros.
f38b440c 2101
232b38b9 2102 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2103 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2104 * character.c (string_count_byte8): Likewise.
232b38b9 2105
fb90da1b
PE
2106 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2107 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2108
fb93dbc2
PE
2109 * chartab.c (copy_sub_char_table): Now static, since it's not used
2110 elsewhere.
5c156ace
PE
2111 (sub_char_table_ref_and_range, char_table_ref_and_range):
2112 Rename locals to avoid shadowing.
bbcd0949 2113 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2114
7d3b3862 2115 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2116 (BIDI_BOB): Remove unused macro.
7d3b3862 2117
6be7d3da
PE
2118 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2119 deduce are never used uninitialized.
c2ed9c8b 2120 * term.c (encode_terminal_code): Likewise.
6be7d3da 2121
75f8807f 2122 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2123
50938595
PE
2124 * tparam.h: New file.
2125 * term.c, tparam.h: Include it.
2126 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2127 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2128 Move these decls to tparam.h, and make them agree with what
2129 is actually in tparam.c. The previous trick of using incompatible
2130 decls in different modules does not conform to the C standard.
2131 All callers of tparam changed to use tparam's actual API.
2132 * tparam.c (tparam1, tparam, tgoto):
2133 Use const pointers where appropriate.
2134
fbceeba2
PE
2135 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2136 * cm.h (struct cm): Likewise.
2137 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2138 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2139 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2140 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2141 (turn_on_face, init_tty): Likewise.
2142 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2143
7f3f1250
PE
2144 * term.c (term_mouse_position): Rename local to avoid shadowing.
2145
e6ca6543
PE
2146 * alloc.c (mark_ttys): Move decl from here ...
2147 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2148
c40f8d15
AS
21492011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2150
2151 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2152
cfe0661d
JB
21532011-03-09 Juanma Barranquero <lekktu@gmail.com>
2154
2155 * search.c (compile_pattern_1): Remove argument regp, unused since
2156 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2157 (compile_pattern): Don't pass it.
2158
0afb4571
J
21592011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2160
2161 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2162 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2163 for ! HAVE_GTK3.
2164 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2165
2166 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2167
2168 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2169 gdk_window_get_screen, gdk_window_get_geometry,
2170 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2171 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2172 (xg_get_pixbuf_from_pixmap): New function.
2173 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2174 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2175 Call xg_get_pixbuf_from_pixmap instead of
2176 gdk_pixbuf_get_from_drawable.
2177 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2178 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2179 (xg_check_special_colors): Use GtkStyleContext and its functions
2180 for HAVE_GTK3.
2181 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2182 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2183 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2184 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2185 Call gtk_widget_get_preferred_size.
0afb4571
J
2186 (xg_frame_resized): gdk_window_get_geometry only takes 5
2187 parameters.
44f230aa
SM
2188 (xg_win_to_widget, xg_event_is_for_menubar):
2189 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2190 (xg_set_widget_bg): New function.
2191 (delete_cb): New function.
2192 (xg_create_frame_widgets): connect delete-event to delete_cb.
2193 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2194 (xg_set_background_color): Call xg_set_widget_bg.
2195 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2196 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2197 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2198 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2199 if ! HAVE_GTK3.
2200 (update_frame_tool_bar): Call gtk_widget_hide.
2201 (xg_initialize): Use GDK_KEY_g.
2202
2203 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2204 if ! HAVE_GTK3
2205 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2206
2207 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2208 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2209 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2210
1c2cc4ef
JB
22112011-03-08 Juanma Barranquero <lekktu@gmail.com>
2212
2213 * w32xfns.c (select_palette): Check success of RealizePalette against
2214 GDI_ERROR, not zero.
2215
33383987 2216See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2217
2218;; Local Variables:
2219;; coding: utf-8
aac0c6e3
MR
2220;; End:
2221
33383987 2222 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2223
2224 This file is part of GNU Emacs.
2225
2226 GNU Emacs is free software: you can redistribute it and/or modify
2227 it under the terms of the GNU General Public License as published by
2228 the Free Software Foundation, either version 3 of the License, or
2229 (at your option) any later version.
2230
2231 GNU Emacs is distributed in the hope that it will be useful,
2232 but WITHOUT ANY WARRANTY; without even the implied warranty of
2233 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2234 GNU General Public License for more details.
2235
2236 You should have received a copy of the GNU General Public License
2237 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.