Doc fixes and improvements for syntax tables.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
02676e5d
CY
12012-08-04 Chong Yidong <cyd@gnu.org>
2
3 * syntax.c (Fmodify_syntax_entry): Doc fix.
4
97147da9
EZ
52012-08-04 Eli Zaretskii <eliz@gnu.org>
6
76151e2c
EZ
7 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
8 * w32.c (init_environment): Change the default values of many
9 environment variables in dflt_envvars[] to NULL, to avoid pushing
10 them into environment when they were not already defined. Remove
11 the code that deletes site-lisp subdirectories from the default
12 value of EMACSLOADPATH, as it is no longer needed.
13 (check_windows_init_file): Now external, not static. Use
14 Vload_path as is, without adding anything, as this function is now
15 called when Vload_path is already set up.
16
17 * w32.h (check_windows_init_file): Add prototype.
18
19 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
20 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
21 compatibility with Posix platforms.
22 (main): Move the call to check_windows_init_file to here from
23 w32.c.
24 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
25 any, in the DEFALT argument into the root of the Emacs build or
26 installation tree, as appropriate.
27
28 * callproc.c (init_callproc_1): Call decode_env_path instead of
29 doing its equivalent by hand.
30 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
31 the code that sets Vexec_path run on MS-Windows.
32
33 * lread.c (init_lread): Add comments to #ifdef's.
34
97147da9
EZ
35 * msdos.c (dos_set_window_size, IT_update_begin)
36 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
37 instead of direct references.
38
185ee146
PE
392012-08-04 Paul Eggert <eggert@cs.ucla.edu>
40
41 Export DEFAULT_REHASH_* to GDB.
42 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
43 Now constants, not macros.
44
8834c57a
PE
452012-08-03 Paul Eggert <eggert@cs.ucla.edu>
46
98c6f1e3
PE
47 Remove unnecessary casts involving pointers.
48 These casts are no longer needed now that we assume C89 or later,
49 since they involve casting to or from void *.
50 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
51 (make_pure_float, make_pure_vector):
52 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
53 * macros.c (Fstart_kbd_macro):
54 * menu.c (find_and_return_menu_selection):
55 * minibuf.c (read_minibuf_noninteractive):
56 * sysdep.c (closedir):
57 * xdisp.c (x_produce_glyphs):
58 * xfaces.c (compare_fonts_by_sort_order):
59 * xfns.c (x_real_positions, select_visual):
60 * xselect.c (x_stop_queuing_selection_requests)
61 (x_get_window_property, x_get_window_property_as_lisp_data):
62 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
63 Remove unnecessary pointer casts.
64 * alloc.c (record_xmalloc): New function.
65 * lisp.h (record_xmalloc): New decl.
66 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
67 more like a function. This is because the pointer cast is not
68 needed. All uses changed.
69 * print.c (print_string, print_error_message): Avoid length recalc.
70
8834c57a
PE
71 Improve fix for macroexp crash with debugging (Bug#12118).
72 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
73 ARRAY_MARK_FLAG when checking subscripts, because ASET is
74 not supposed to be invoked from the garbage collector.
75 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
76 (gc_aset): New function, which is like ASET but can be
77 used in the garbage collector.
78 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
79 (set_hash_index): Use it instead of ASET.
80
6dad7178
EZ
812012-08-03 Eli Zaretskii <eliz@gnu.org>
82
83 Support symlinks on latest versions of MS-Windows.
84 * w32.c: Include winioctl.h and aclapi.h.
85 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
86 (revert_to_self): Forward declarations of static functions.
87 <static BOOL g_b_init_get_security_info>:
88 <g_b_init_create_symbolic_link>: New static flags.
89 (globals_of_w32): Initialize them to zero.
90 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
91 (map_w32_filename): Improve commentary. Simplify switch.
92 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
93 headers (most versions of MinGW w32api don't).
94 (get_security_info, create_symbolic_link)
95 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
96 New functions.
97 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
98 in the argument file name.
99 (sys_access): Call unc_volume_file_attributes only if
100 GetFileAttributes fails with network-related error codes.
101 (sys_rename): Diagnose renaming of a symlink when the user doesn't
102 have the required privileges.
103 (get_file_security_desc_by_name): Renamed from
104 get_file_security_desc.
105 (stat_worker): New function, with most of the guts of 'stat', and
106 with addition of handling of symlinks and support for 'lstat'. If
107 possible, get file's attributes and security information by
108 handle, not by name. Produce S_IFLNK bit for symlinks, when
109 called from 'lstat'.
110 (stat, lstat): New functions, call 'stat_worker'.
111 (symlink, readlink, careadlinkat): Rewritten to create and resolve
112 symlinks when the underlying filesystem supports them.
113
f162bcc3
PE
1142012-08-02 Paul Eggert <eggert@cs.ucla.edu>
115
79ea6c20
PE
116 Fix macroexp crash on Windows with debugging (Bug#12118).
117 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
118 checking subscripts; problem introduced with the recent
119 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
120 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
121 since it's used in non-static inline functions now.
122
c0ce93fd
PE
123 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
124 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 125
f162bcc3
PE
126 Use C99-style 'extern inline' if available.
127 * buffer.h (BUFFER_INLINE):
128 * category.h (CATEGORY_INLINE):
129 * character.h (CHARACTER_INLINE):
130 * charset.h (CHARSET_INLINE):
131 * composite.h (COMPOSITE_INLINE):
132 * dispextern.h (DISPEXTERN_INLINE):
133 * lisp.h (LISP_INLINE):
134 * systime.h (SYSTIME_INLINE):
135 New macro, replacing 'static inline' in this header.
136 * buffer.h, category.h, character.h, charset.h, composite.h:
137 * dispextern.h, lisp.h, systime.h:
138 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
139 * alloc.c (LISP_INLINE):
140 * buffer.c (BUFFER_INLINE):
141 * category.c (CATEGORY_INLINE):
142 * character.c (CHARACTER_INLINE):
143 * charset.c (CHARSET_INLINE):
144 * composite.c (COMPOSITE_INLINE):
145 * dispnew.c (DISPEXTERN_INLINE):
146 * sysdep.c (SYSTIME_INLINE):
147 Define to EXTERN_INLINE, so that the corresponding functions
148 are compiled into code.
149 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
150 (INLINE_HEADER_END): New macros.
151 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
152 since it's used in non-static inline functions now.
a8333d03 153 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 154
837b365b
GM
1552012-08-02 Glenn Morris <rgm@gnu.org>
156
d66b744d
GM
157 * s/: Remove empty directory.
158
837b365b
GM
159 * s/ms-w32.h: Move to ../nt/inc.
160 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
161 Update for new ms-w32.h location.
162
13294f95
PE
1632012-08-02 Paul Eggert <eggert@cs.ucla.edu>
164
165 Port to Solaris 8.
166 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
167
90df0db3
GM
1682012-08-02 Glenn Morris <rgm@gnu.org>
169
170 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
171 hard-coding the path separator.
172
4939150c
PE
1732012-08-01 Paul Eggert <eggert@cs.ucla.edu>
174
175 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
176 This how ASET and AREF are supposed to work, and makes
177 it easier to think about future improvements. See
178 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
179 * charset.h (set_charset_attr): New function.
180 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
181 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
182 (aref_addr): New function. All uses of &AREF(...) changed.
183 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
184 (set_hash_index): New functions. All lvalue-style uses of
185 HASH_KEY etc. changed.
186 * keyboard.c (set_prop): New function. All lvalue-style uses
187 of PROP changed.
188
947b2afd
AA
1892012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
190
191 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
192 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
193 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
194 * nsfns.m (ns_set_name_as_filename): Likewise.
195 * nsmenu.m (ns_update_menubar): Likewise.
196 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
197
4f5d0325
EZ
1982012-08-01 Eli Zaretskii <eliz@gnu.org>
199
2008beae
EZ
200 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
201 Adapt to latest changes in field names of the corresponding Lisp
288479f6 202 objects.
2008beae 203
4f5d0325
EZ
204 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
205
fe3cc771
GM
2062012-08-01 Glenn Morris <rgm@gnu.org>
207
208 * s/msdos.h: Remove file.
209 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
210 * Makefile.in (S_FILE): Remove.
211 (config_h): Remove S_FILE.
212
c90acc54
JB
2132012-08-01 Juanma Barranquero <lekktu@gmail.com>
214
215 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
216 Remove; moved to nt/config.nt.
217
d8a05828
DA
2182012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
219
220 Use INTERNAL_FIELD for conses and overlays.
221 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
222 Remove obsolete comment.
223 (MVAR): New macro.
224 (struct Lisp_Overlay): Use INTERNAL_FIELD.
225 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
226
8271d590
DA
2272012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
228
229 Use INTERNAL_FIELD for symbols.
230 * lisp.h (SVAR): New macro. Adjust users.
231 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
232 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
233
3193acd2
DA
2342012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
235
236 Use INTERNAL_FIELD for processes.
237 * process.h (PVAR): New macro. Adjust style.
238 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
239 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
240
3a45383a
DA
2412012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
242
243 Use INTERNAL_FIELD for windows.
244 * window.h (WVAR): New macro.
245 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
246 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
247 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
248 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
249 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
250 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
251
c1dbc63c
PE
2522012-08-01 Paul Eggert <eggert@cs.ucla.edu>
253
254 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
255
5c0c0e8a
GM
2562012-08-01 Glenn Morris <rgm@gnu.org>
257
258 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
259 Move to configure.ac.
260
552a99b4
JB
2612012-08-01 Juanma Barranquero <lekktu@gmail.com>
262
263 * makefile.w32-in (CONFIG_H): Update dependencies.
264 (CONF_POST_H): New macro.
265
266 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
267
8d8e2dfe
GM
2682012-07-31 Glenn Morris <rgm@gnu.org>
269
bc96620a
GM
270 * Makefile.in (S_FILE): No longer set by configure.
271
476b1b2d
GM
272 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
273 is available.
274 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
275
b2c7a106
GM
276 * process.h (NULL_DEVICE):
277 * emacs.c (SEPCHAR):
278 * editfns.c (USER_FULL_NAME): Let configure set them.
279
d53d062a
GM
280 * s/README, s/template.h: Remove files.
281
4515017f
GM
282 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
283
8d8e2dfe
GM
284 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
285 Move to configure.ac.
286
5b20b3cc
EZ
2872012-07-31 Eli Zaretskii <eliz@gnu.org>
288
1e0afd9a
EZ
289 * .gdbinit (xframe): Adapt to introduction of FVAR and the
290 resulting renaming of 'struct frame' members.
291
5b20b3cc
EZ
292 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
293
294 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
295 after introduction of FVAR.
296
f1310128
JD
2972012-07-31 Jan Djärv <jan.h.d@swipnet.se>
298
79e721e0
JD
299 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
300
301 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
302 instead of compositeToPoint.
303 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
304
8d7c7eed 305 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 306
e34f7f79
DA
3072012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
308
309 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
310 * lisp.h (INTERNAL_FIELD): New macro.
311 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
312 (BVAR): Change to use INTERNAL_FIELD.
313 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
314 (KVAR): Change to use INTERNAL_FIELD.
315 * frame.h (FVAR): New macro.
316 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
317 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
318 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
319 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
320 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
321
c09bfb2f
DA
3222012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
323
324 Miscellaneous fixes for non-default X toolkits.
325 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
326 * xterm.c (x_frame_of_widget): Remove redundant prototype.
327 Move under #ifdef USE_LUCID.
328 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
329 definition and usage to avoid warnings.
330
14c114ae
JD
3312012-07-31 Jan Djärv <jan.h.d@swipnet.se>
332
333 * nsterm.m (openFiles): Fix previous checkin.
334
3bd21e82
PE
3352012-07-31 Paul Eggert <eggert@cs.ucla.edu>
336
337 * indent.c (compute_motion): Remove unused local.
338
c1529ded
GM
3392012-07-31 Glenn Morris <rgm@gnu.org>
340
400d5621
GM
341 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
342
268e2432
GM
343 * conf_post.h [USG5_4]:
344 Move remaining contents of s/usg5-4-common.h here.
345 * s/usg5-4-common.h: Remove file.
346
7552f3ee
GM
347 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
348 * s/irix6-5.h: Remove file.
349
6a381852
GM
350 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
351 * s/darwin.h: Remove file.
352
c1529ded
GM
353 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
354 * s/hpux10-20.h: Remove file, which is now empty.
355
b429a4ee
GM
3562012-07-30 Glenn Morris <rgm@gnu.org>
357
358 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
359 * Makefile.in (config_h): Add conf_post.h.
360 * makefile.w32-in (CONFIG_H): Add conf_post.h.
361
adff3182
JD
3622012-07-30 Jan Djärv <jan.h.d@swipnet.se>
363
364 * nsterm.m (ns_do_open_file): New variable.
b9031d69 365 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
366 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
367 files only if ns_do_open_file.
368
c32af1e4
PE
3692012-07-30 Paul Eggert <eggert@cs.ucla.edu>
370
7393bcbb
PE
371 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
372 This no-op macro hasn't been needed for many years.
373 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
374
c32af1e4
PE
375 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
376 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
377 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
378 gdb_make_enums_visible.
379 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
380 (DIRECTORY_SEP): Now a constant, not a macro.
381
302fc036
EZ
3822012-07-30 Eli Zaretskii <eliz@gnu.org>
383
384 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
385 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
386
387 * w32term.c <w32_keyboard_codepage>: Renamed from
388 keyboard_codepage and now external. All users changed.
389
390 * w32term.h: Add declaration of w32_keyboard_codepage.
391
392 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
393 the codepage to translate keys to Unicode. If this argument is
394 -1, use the value returned by GetConsoleCP. All callers changed.
395
88fb40b4
PE
3962012-07-30 Paul Eggert <eggert@cs.ucla.edu>
397
0aee6912
PE
398 Update .PHONY listings in makefiles.
399 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
400 bootstrap-clean, distclean, maintainer-clean, versioclean,
401 extraclean, frc.
402
88fb40b4
PE
403 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
404 This is a bit clearer. Fix some commentary typos.
405
0a763bd1
GM
4062012-07-30 Glenn Morris <rgm@gnu.org>
407
32bac6d6
GM
408 * s/netbsd.h: Let configure include signal.h if needed.
409 Remove file, which is now empty.
410
b65e7c46
GM
411 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
412 Let configure set them.
413 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
414 No more need to undefine.
0a763bd1 415
169304bd
AS
4162012-07-30 Andreas Schwab <schwab@linux-m68k.org>
417
418 * keymap.c (Fkey_description): Don't remove 0x80 bit from
419 non-single-byte char when adding meta modifier. (Bug#12090)
420
6cd7a139
DA
4212012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
422
423 Convert safe_call to use variable number of arguments.
424 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
425 (safe_call2): Fix comment.
426 * lisp.h (safe_call): Adjust prototype.
427 * coding.c (encode_coding_object): Change to use safe_call2.
428 * xfaces.c (merge_face_heights): Change to use safe_call1.
429
d34d6ffc
GM
4302012-07-30 Glenn Morris <rgm@gnu.org>
431
7b8a48e4 432 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 433 does that unconditionally. Remove file, which is now empty.
7b8a48e4 434
d34d6ffc
GM
435 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
436 Remove empty files.
437
03a660a6
PE
4382012-07-30 Paul Eggert <eggert@cs.ucla.edu>
439
440 Export to GDB most of lisp.h's remaining object-like macros.
441 * lisp.h (min, max): Move earlier, because they're used earlier now.
442 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
443 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
444 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
445 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
446 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
447 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
448 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
449 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
450 Now constants, for GDB. They need not be macros.
451 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
452 Now constants, for GDB, as well as macros, for static initializers.
453 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
454 Move to after the definition of struct Lisp_Char_Table,
455 since the former now needs that type defined.
456 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
457 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
458 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
459 New enums, for gdb_make_enums_visible.
460 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 461 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
462 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
463 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
464 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
465 enum maxargs, enum MAX_ALLOCA.
466 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
467 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
468 no longer needed, now that they are done in lisp.h.
469
e499d0ee
DA
4702012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Cleanup string bytes checking.
473 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
474 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
475 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
476 (check_sblock, compact_small_strings): Simplify.
477
d5040d2d
PE
4782012-07-29 Paul Eggert <eggert@cs.ucla.edu>
479
480 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
481 These macros are confusing and no longer need to be defined, as
482 the enum values now suffice. All uses replaced with definiens.
483 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
484
7f259ae6
JB
4852012-07-29 Juanma Barranquero <lekktu@gmail.com>
486
487 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
488 ($(BLD)/w32console.$(O)): Update dependencies.
489
7e63e0c3
DA
4902012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
491
492 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
493 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
494 time. Adjust users.
495 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
496
ffd817eb
JD
4972012-07-29 Jan Djärv <jan.h.d@swipnet.se>
498
499 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
500 setting sitelisp (Bug#12010).
501
417a7a0e
EZ
5022012-07-29 Eli Zaretskii <eliz@gnu.org>
503
504 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
505
506 * w32heap.c (cache_system_info):
507 * w32.c (sys_rename):
508 * w32proc.c (find_child_console, sys_kill): All users changed.
509
387d4d92
PE
5102012-07-29 Paul Eggert <eggert@cs.ucla.edu>
511
512 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
513
55a6cca6
EZ
5142012-07-29 Eli Zaretskii <eliz@gnu.org>
515
516 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
517
dbcf001c
DA
5182012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Cleanup statistics calculation in Fgarbage_collect.
521 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
522 zombies percentage calculation. Simplify elapsed time calculation.
523
e2688e4a
DA
5242012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
525
526 Generalize marker debugging code under MARKER_DEBUG and use eassert.
527 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
528 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
529 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
530 (replace_range, replace_range_2, del_range_2): Change to eassert.
531 * marker.c (byte_char_debug_check): Adjust style.
532
b46a6a83
PE
5332012-07-29 Paul Eggert <eggert@cs.ucla.edu>
534
535 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
536 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
537 long-ago-commented-out code that talks about "WIN32".
538 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
539 All uses changed.
540
e32a5799
PE
5412012-07-28 Paul Eggert <eggert@cs.ucla.edu>
542
543 Use Gnulib stdalign module (Bug#9772, Bug#9960).
544 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
545 Simplify by using alignof.
546 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
547 * lisp.h: Include <stdalign.h>.
548 (GCALIGNMENT): New macro and constant.
549 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
550 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
551 (stdalign): New macro, if not already defined.
552
df81cd29
EZ
5532012-07-28 Eli Zaretskii <eliz@gnu.org>
554
01bd1b0d
EZ
555 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
556 * w32inevt.c: Include w32inevt.h.
557 (w32_read_console_input): New inline function, calls either
558 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
559 w32_console_unicode_input.
560 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
561 (w32_kbd_patch_key, key_event): Use the codepage returned by
562 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
563 (key_event): use uChar.UnicodeChar only if
564 w32_console_unicode_input is non-zero.
565
566 * w32console.c: Include w32heap.h.
567 <w32_console_unicode_input>: New global variable.
568 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
569 family of Windows, zero otherwise.
570
571 * w32inevt.h: Declare w32_console_unicode_input.
572
df81cd29
EZ
573 * xdisp.c (init_iterator): Don't reference tip_frame in a build
574 --without-x. (Bug#11742)
575
c20fdd9e
PE
5762012-07-27 Paul Eggert <eggert@cs.ucla.edu>
577
578 Adjust GDB to reflect pvec_type changes (Bug#12036).
579 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
580 2012-07-04 changes to pseudovector representation. Problem
581 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
582
32770973 5832012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
584
585 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
586 bus address.
587 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
588
3438fe21
EZ
5892012-07-27 Eli Zaretskii <eliz@gnu.org>
590
bcfbc9de
EZ
591 * alloc.c (listn): Fix the order the arguments are consed onto the
592 list.
593
3438fe21
EZ
594 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
595 enumeration constants, as PURE and HEAP are too general, and clash
596 with other headers and sources, such as gmalloc.c and the
597 MS-Windows system headers. All users changed.
598
eeaea515
DA
5992012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Revert last save_excursion_save and save_excursion_restore changes.
602 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
603 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
604
073c88c2
DA
6052012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
606
607 Fix recently-introduced typos in Windows port.
608 Reported by Martin Rudalics <rudalics@gmx.at>.
609 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 610 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 611
4706125e
PE
6122012-07-27 Paul Eggert <eggert@cs.ucla.edu>
613
614 Improve GDB symbol export (Bug#12036).
615 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
616 arms of an 'if', not using conditional expressions; otherwise GDB
617 complains about the types in the unevaluated arm when the argument
618 is an integer literal.
619 (xgetint): Simplify expression.
620 * alloc.c (gdb_make_enums_visible): New constant. This ports to
621 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
622 Zaretskii in <http://bugs.gnu.org/12036#13>.
623 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
624 needed now that we have gdb_make_enums_visible.
625 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
626 (enum enum_USE_LSB_TAG):
627 New enum types, packaging up enums that need to be exported to GDB.
628
694b6c97
DA
6292012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
630
631 Utility function to make a list from specified amount of objects.
632 * lisp.h (enum constype): New datatype.
633 (listn): New prototype.
634 * alloc.c (listn): New function.
635 (Fmemory_use_count, syms_of_alloc): Use it.
636 * buffer.c (syms_of_buffer): Likewise.
637 * callint.c (syms_of_callint): Likewise.
638 * charset.c (define_charset_internal): Likewise.
639 * coding.c (syms_of_coding): Likewise.
640 * keymap.c (syms_of_keymap): Likewise.
641 * search.c (syms_of_search): Likewise.
642 * syntax.c (syms_of_syntax): Likewise.
643 * w32.c (init_environment): Likewise.
644 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
645 * xdisp.c (syms_of_xdisp): Likewise.
646 * xfns.c (syms_of_xfns): Likewise.
647
6195f384
DA
6482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
649
650 Fast save_excursion_save and save_excursion_restore.
651 * lisp.h (struct Lisp_Excursion): New data type.
652 (PVEC_EXCURSION): New pseudovector type.
653 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
654 to deal with it. Adjust comments.
655 (init_marker, attach_marker): New prototype.
656 (unchain_marker): Adjust prototype.
657 * marker.c (attach_marker): Change to global.
658 (init_marker): New function.
659 * alloc.c (Fmake_marker, build_marker): Use it.
660 (build_marker): More easserts.
661 (mark_object): Handle struct Lisp_Excursion.
662 * editfns.c (save_excursion_save, save_excursion_restore):
663 Reimplement to use struct Lisp_Excursion. Add comments.
664
5eceb8fb
PE
6652012-07-26 Paul Eggert <eggert@cs.ucla.edu>
666
667 Fix export of symbols to GDB (Bug#12036).
668 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
669 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
670 emacs.c, as this is a more-suitable home. Had this been done earlier
671 the fix for 12036 would have avoided some of the problems noted in
672 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
673 would have been more obvious.
562157c8
PE
674 * emacs.c: Do not include <verify.h>; no longer needed.
675 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
676 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
677 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
678 Remove; now done in lisp.h.
679 * lisp.h (PUBLISH_TO_GDB): New macro.
680 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
681 (DATA_SEG_BITS): Use it.
682 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
683 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
684 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
685 not be usable in #if. This simplifies things.
686
d6749401
JB
6872012-07-26 Juanma Barranquero <lekktu@gmail.com>
688
689 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
690
1781b9e9
PE
6912012-07-26 Paul Eggert <eggert@cs.ucla.edu>
692
d89518db 693 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
694 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
695 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
696 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
697 Adjust to changes in lisp.h and emacs.c, by using
698 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
699 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
700 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
701 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
702 instead of gdb_valbits.
703 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
704 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
705 instead of gdb_array_mark_flag.
706 (xboolvector): Get size from $->size, not $->header.size.
707 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
708 (xreload, hook-run, hookpost-run): Remove.
709 * emacs.c: Include <verify.h>.
710 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
711 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
712 Remove.
713 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
714 (gdb_USE_LSB_TAG): New enum constants.
715 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
716 Also define these as enum constants, so they're visible to GDB.
717 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
718 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
719 as constants, so they're visible to GDB.
720 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
721 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
722 Now enum constants, not macros, so they're visible to GDB.
723 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
724 more convenient now. All uses changed.
725 (VALMASK) [USE_LSB_TAG]: Also define in this case.
726 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
727
3628596a
DA
7282012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Explicitly free restriction data that are not needed anymore.
731 * editfns.c (save_restriction_restore): Free restriction data.
732
7abaf5cc
SM
7332012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
736 add argument, tune behavior, and adjust all callers.
737
71f88e00
PE
7382012-07-25 Paul Eggert <eggert@cs.ucla.edu>
739
740 Use typedef for EMACS_INT, EMACS_UINT.
741 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
742 than macros. This simplifies debugging in the usual case, since
743 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
744 and it allows expressions involving EMACS_INT casts.
745 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
746
57ec3034
JD
7472012-07-25 Jan Djärv <jan.h.d@swipnet.se>
748
749 * nsterm.m (ns_read_socket): Return early if there is a modal
750 window (Bug#12043).
751
8137e7b3
MR
7522012-07-25 Martin Rudalics <rudalics@gmx.at>
753
754 * frame.c (Fredirect_frame_focus): In doc-string don't mention
755 that FOCUS-FRAME can be omitted.
756
04e9897c
DA
7572012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
758
759 Adjust buffer text indirection counters at the end of Fkill_buffer.
760 * buffer.c (Fkill_buffer): Adjust indirection counters when the
761 buffer is definitely dead. This should really fix an issue reported
762 by Christoph Scholtes again. (Bug#12007).
763 (init_buffer_once): Initialize indirection counters of
764 buffer_defaults and buffer_local_symbols (for sanity and safety).
765
8a0484e1
EZ
7662012-07-24 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (init_iterator): Don't compute dimensions of truncation
769 and continuation glyphs on tooltip frames, leave them at zero.
770 Avoids continued lines in tooltips. (Bug#11832)
771
fa691a83
DA
7722012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
773
774 Simplify copy_overlay.
04e9897c 775 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
776 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
777
436bc8e0
EZ
7782012-07-23 Eli Zaretskii <eliz@gnu.org>
779
780 * print.c (print_object): Don't crash when a frame's name is nil
781 or invalid. (Bug#12025)
782
783 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
784 it signals an error when a tooltip frame is being created.
785
d7a7fda3
DA
7862012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Cleanup miscellaneous objects allocation and initialization.
789 * alloc.c (allocate_misc): Change to static. Add argument to
790 specify the subtype. Adjust comment and users.
791 (build_overlay): New function.
792 * buffer.c (copy_overlays, Fmake_overlay): Use it.
793 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
794 (allocate_misc): Remove prototype.
795 (build_overlay): Add prototype.
796
7972012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
798
799 Swap buffer text indirection counters in Fbuffer_swap_text.
800 * buffer.c (Fbuffer_swap_text): Swap indirections too.
801 This avoids crash reported by Christoph Scholtes at
802 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
803
9d7fa573
JD
8042012-07-22 Jan Djärv <jan.h.d@swipnet.se>
805
806 * nsmenu.m (Popdown_data): New struct.
807 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
808 free Popdown_data.
809 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
810 (initWithContentRect): Make imgView and contentView non-static
811 and autorelease them. Also autorelease img and matrix (Bug#12005).
812 (dealloc): Remove (Bug#12005).
813
0dd6d66d
DA
8142012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
815
816 Adjust consing_since_gc when objects are explicitly freed.
817 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
818 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
819 (free_cons, free_misc): Subtract object size from consing_since_gc.
820
d36d71df
DA
8212012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
822
823 Simplify and cleanup markers positioning code.
824 * marker.c (attach_marker): More useful eassert.
825 (live_buffer, set_marker_internal): New function.
826 (Fset_marker, set_marker_restricted): Use set_marker_internal.
827 (set_marker_both, set_marker_restricted_both): Use live_buffer.
828
fb9ea40f
PE
8292012-07-22 Paul Eggert <eggert@cs.ucla.edu>
830
831 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
832 as it's limited by the amount of memory, not by INT_MAX.
833
2d5c5f7d
EZ
8342012-07-21 Eli Zaretskii <eliz@gnu.org>
835
07fb592e
EZ
836 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
837 in special-event-map. See the discussion at
838 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
839 for the reasons.
840
37a9eac8 841 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
842 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
843 Fabrice Popineau <fabrice.popineau@supelec.fr>.
844
c4328746
JD
8452012-07-21 Jan Djärv <jan.h.d@swipnet.se>
846
847 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 848 (conversationIdentifier): Return value is NSInteger.
784051c4 849 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 850
6e5d1c12
CY
8512012-07-21 Chong Yidong <cyd@gnu.org>
852
853 * window.c (decode_any_window): Signal an error if the window is
854 on a dead frame (Bug#11984).
855
9928463d
DA
8562012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
857
858 Add indirection counting to speed up Fkill_buffer.
859 * buffer.h (struct buffer): New member.
860 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
861 (Fmake_indirect_buffer): Set indirection counter to -1, increment
862 base buffer indirection counter.
863 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
864 (Fkill_buffer): Adjust indirection counters as needed, don't walk
865 through buffer list if indirection counter is 0.
866
f8643a6b
DA
8672012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
868
869 Extend the value returned by Fgarbage_collect with heap statistics.
870 * alloc.c (Qheap): New symbol.
871 (syms_of_alloc): DEFSYM it.
872 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
873 (Fmemory_free): Remove.
874 (syms_of_alloc): Don't defsubr it.
875 * buffer.c (Fcompact_buffer): Remove.
876 (syms_of_buffer): Don't defsubr it.
877
dac616ff
DA
8782012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
879
880 Make maybe_gc inline.
881 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
882 * lisp.h (consing_since_gc, gc_relative_threshold)
883 (memory_full_cons_threshold): Revert declaration.
884 (maybe_gc): Remove prototype, define as inline.
885 * alloc.c: Remove old commented-out code.
886 (consing_since_gc, gc_relative_threshold)
887 (memory_full_cons_threshold): Revert to global.
888 (maybe_gc): Remove.
889
d7ea76b4
DA
8902012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
891
892 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
893 * lisp.h (build_unibyte_string): New function.
894 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
895 * sysdep.c, w32fns.c, xfns.c: Use it.
896 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
897 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
898 Adjust users accordingly.
899 * font.h (font_open_by_name): Adjust prototype.
900
765e61e3
DA
9012012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
902
903 Cleanup calls to Fgarbage_collect.
904 * lisp.h (maybe_gc): New prototype.
905 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
906 Remove declarations.
907 * alloc.c (maybe_gc): New function.
908 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
909 Make them static.
910 * bytecode.c (MAYBE_GC): Use maybe_gc.
911 * eval.c (eval_sub, Ffuncall): Likewise.
912 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
913 to avoid dependency from auto-save feature.
914
52b852c7
PE
9152012-07-19 Paul Eggert <eggert@cs.ucla.edu>
916
917 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
918 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
919 'for_each_per_buffer_object_at'.
920 All uses changed. It's better to use upper-case for macros that
921 cannot be implemented as functions, to give the reader a clue
922 that they're special.
923
5db81e33
SM
9242012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
925
926 * alloc.c (Fgarbage_collect): Tweak docstring.
927
5b835e1d
DA
9282012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
929
930 Tweak the value returned from Fgarbage_collect again.
931 * alloc.c (Fgarbage_collect): New return value, as confirmed in
932 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
933 Adjust documentation.
934 (total_vector_bytes): Rename to total_vector_slots, adjust
935 accounting.
936 (total_free_vector_bytes): Rename to total_free_vector_slots,
937 adjust accounting.
938 (Qstring_bytes, Qvector_slots): New symbols.
939 (syms_of_alloc): DEFSYM them.
940
9cd47b72
DA
9412012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
942
943 Buffer compaction primitive which may be used from Lisp.
944 * buffer.c (compact_buffer, Fcompact_buffer): New function.
945 (syms_of_buffer): Register Fcompact_buffer.
946 * alloc.c (Fgarbage_collect): Use compact_buffer.
947 * buffer.h (compact_buffer): New prototype.
948 (struct buffer_text): New member.
949
d17337e5
DA
9502012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
951
952 New macro to iterate over all buffers, miscellaneous cleanups.
953 * lisp.h (all_buffers): Remove declaration.
954 * buffer.h (all_buffers): Add declaration, with comment.
955 (for_each_buffer): New macro.
956 * alloc.c (Fgarbage_collect, mark_object): Use it.
957 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
958 (init_buffer): Likewise.
959 * data.c (Fset_default): Likewise.
960 * coding.c (code_conversion_restore): Remove redundant check
961 for dead buffer.
962 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
963
60cfd278
AS
9642012-07-18 Andreas Schwab <schwab@linux-m68k.org>
965
966 Fix bug that created negative-length intervals.
967 * intervals.c (merge_interval_right, merge_interval_left):
968 Do not zero out this interval if it is absorbed by its children,
969 as this interval's total length doesn't change in that case. See
970 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
971
d06714cb
PE
9722012-07-18 Paul Eggert <eggert@cs.ucla.edu>
973
83713154
PE
974 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
975 when invoking (make-bool-vector N t) and N is a positive
976 multiple of 8 -- the last 8 bits were mistakenly cleared.
977
d06714cb
PE
978 Remove some struct layout assumptions in bool vectors.
979 * alloc.c (bool_header_size): New constant.
980 (header_size, word_size): Move earlier, as they're now used earlier.
981 Use 'word_size' in a few more places, where it's appropriate.
982 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
983 padding before the data member of a bool vector.
984 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
985 than doing the check by hand with an abort ().
986
464d5a5e
SM
9872012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
988
5fbc0409
SM
989 * eval.c (Fdefvar): Don't check constants since we only set the var if
990 it's not yet defined anyway (bug#11904).
991
464d5a5e
SM
992 * lisp.h (last_undo_boundary): Declare new var.
993 * keyboard.c (command_loop_1): Set it.
994 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
995 were auto-added by the command loop (bug#11774).
996
8dc2e44a
AS
9972012-07-18 Andreas Schwab <schwab@linux-m68k.org>
998
999 * w32font.c (Qsymbol): Remove local definition.
1000 (syms_of_w32font): Don't DEFSYM it.
1001
169925ec
DA
10022012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1003
1004 Fix sweep_vectors to handle large bool vectors correctly.
1005 * alloc.c (sweep_vectors): Account total_vector_bytes for
1006 bool vectors larger than VBLOCK_BYTES_MAX.
1007
5fbfb018
CY
10082012-07-18 Chong Yidong <cyd@gnu.org>
1009
1010 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1011 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1012
3ab6e069
DA
10132012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1014
1015 Return more descriptive data from Fgarbage_collect.
1016 Suggested by Stefan Monnier in
1017 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1018 * alloc.c (bounded_number): New function.
1019 (total_buffers, total_vectors): New variable.
1020 (total_string_size): Rename to total_string_bytes, adjust users.
1021 (total_vector_size): Rename to total_vector_bytes, adjust users.
1022 (sweep_vectors): Account total_vectors and total_vector_bytes.
1023 (Fgarbage_collect): New return value. Adjust documentation.
1024 (gc_sweep): Account total_buffers.
1025 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1026 (VECTOR_SIZE): Remove.
1027 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1028 (Qinterval, Qmisc): New symbols.
1029 (syms_of_data): Initialize them.
1030 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1031 (Qcons, Qbuffer): New declarations.
1032
6d02fe5b
PE
10332012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1036 Round up, not down. Improve doc.
1037
b7ffe040
DA
10382012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1039
1040 Restore old code in allocate_string_data to avoid Faset breakage.
1041 Reported by Julien Danjou <julien@danjou.info> in
1042 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1043 * alloc.c (allocate_string_data): Restore old code with minor
1044 adjustments, fix comment to explain this subtle issue.
1045
4dc7c8d5
SM
10462012-07-17 Eli Zaretskii <eliz@gnu.org>
1047
1048 Remove FILE_SYSTEM_CASE.
1049 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1050
1051 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1052 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1053 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1054 call-process-region passes it through expand-file-name.
1055
1056 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1057
10582012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1059
1060 Fix crash when creating indirect buffer (Bug#11917)
1061 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1062 Don't handle unbound variables specially if non-zero.
1063 (Fbuffer_local_variables): Pass zero.
1064 (clone_per_buffer_values): Pass non-zero.
1065
10662012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1067
1068 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1069 to make the loop interruptible.
1070
10712012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1072
1073 * gnutls.c (emacs_gnutls_handshake): Only retry if
1074 GNUTLS_E_INTERRUPTED.
1075
cce7fefc
DA
10762012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 Cleanup and convert miscellaneous checks to eassert.
1079 * alloc.c (mark_interval): Fix comment, partially rephrase
1080 old comment from intervals.h (see below).
1081 * intervals.c (find_interval, adjust_intervals_for_insertion)
1082 (delete_interval, adjust_intervals_for_deletion)
1083 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1084 Convert to eassert.
1085 (adjust_intervals_for_insertion, make_new_interval):
1086 Remove obsolete and unused code.
1087 * intervals.h (struct interval): Remove obsolete comment.
1088 * textprotp.c (erase_properties): Remove unused code.
1089 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1090 (Fremove_list_of_text_properties): Convert to eassert.
1091
9ea10cc3
CY
10922012-07-17 Chong Yidong <cyd@gnu.org>
1093
1094 * editfns.c (Finsert_char): Doc fix.
1095
3900d5de
DA
10962012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1097
1098 Fix previous change to make Fmemory_free always accurate.
1099 * alloc.c (make_interval): Update total_free_intervals.
1100 (make_float): Likewise for total_free_floats.
1101 (free_cons, Fcons): Likewise for total_free_conses.
1102 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1103 Likewise for total_free_vector_bytes.
1104 (Fmake_symbol): Likewise for total_free_symbols.
1105 (bytes_free): Remove.
1106
7098646f
DA
11072012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1108
1109 Simple free memory accounting feature.
1110 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1111 (sweep_vectors): Accumulate size of free vectors.
1112 (Fgarbage_collect): Setup bytes_free.
1113 (Fmemory_free): New function.
1114 (syms_of_alloc): Register it.
1115
22657b40
DA
11162012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1117
1118 Cleanup overlays checking.
1119 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1120 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1121 eassert and OVERLAYP.
1122 (sort_overlays): Change to use OVERLAYP.
1123
ddfc8813
RK
11242012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1125
1126 * editfns.c (Finsert_char): Make it interactive, and make the
1127 second arg optional. Copy interactive spec and docstring from
1128 ucs-insert.
1129
7c26cf3c
PE
11302012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1131
1132 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1133 Unlike the other wrapped functions, fabs has an unspecified
1134 effect on errno.
1135
5d127af9
JD
11362012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1137
1138 * nsterm.m (keyDown): Interpret flags without left/right bits
1139 as the left key (Bug#11670).
1140
6a0dd1d7
DA
11412012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1142
1143 Remove empty and useless init functions.
1144 * lisp.h (init_character_once, init_fns, init_image)
1145 (init_filelock, init_sound): Remove prototype.
1146 * character.c (init_character_once): Remove.
1147 * filelock.c (init_filelock): Likewise.
1148 * fns.c (init_fns): Likewise.
1149 * image.c (init_image): Likewise.
1150 * sound.c (init_sound): Likewise.
1151 * emacs.c (main): Adjust accordingly.
1152
7a6136fd
DA
11532012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 * gtkutil.h: Tiny cleanups.
1156 (use_old_gtk_file_dialog): Remove useless declaration.
1157 (xg_uses_old_file_dialog): Add suggested const attribute.
1158
ce811ad9
EZ
11592012-07-15 Eli Zaretskii <eliz@gnu.org>
1160
1161 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1162 (bidi_paragraph_init): Use it to limit search forward for a strong
1163 directional character in abnormally large paragraphs full of
1164 neutral or weak characters. (Bug#11943)
1165
c9adfeaa
SF
11662012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1167
1168 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1169 the toolbar (Bug#9451).
1170 (xg_make_tool_item): Give the widget event box a transparent
1171 background.
1172
fff62aa9
DA
11732012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1174
1175 Cleanup basic allocation variables and functions.
1176 * alloc.c (ignore_warnings, init_intervals, init_float)
1177 (init_cons, init_symbol, init_marker): Remove.
1178 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1179 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1180 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1181 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1182 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1183 (staticidx, init_alloc_once, init_strings, free_ablock):
1184 Remove redundant initialization.
1185 * fns.c (init_weak_hash_tables): Remove.
1186 * lisp.h (init_weak_hash_tables): Remove prototype.
1187
9730daca
DA
11882012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1189
1190 Use zero_vector where appropriate.
1191 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1192 accordingly.
1193 * lisp.h (zero_vector): New declaration.
1194 * font.c (null_vector): Remove.
1195 (syms_of_font): Remove initialization and staticpro.
1196 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1197 * keymap.c (Faccessible_keymaps): Likewise.
1198
2e2d2a13
LL
11992012-07-15 Leo Liu <sdl.web@gmail.com>
1200
1201 * fringe.c: Fix typo in comments.
1202
cd276f6e
LL
12032012-07-14 Leo Liu <sdl.web@gmail.com>
1204
1205 * fringe.c: Add a new bitmap exclamation-mark.
1206
5a1131d9
EZ
12072012-07-14 Eli Zaretskii <eliz@gnu.org>
1208
1209 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1210
1211 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1212 (HAVE_MENUS): Don't define, defined by editing config.in with
1213 msdos/sed2v2.inp.
1214 (GMALLOC_INHIBIT_VALLOC): Don't define.
1215 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1216
22e983b7
JB
12172012-07-14 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1220
5b3f250f
GM
12212012-07-14 Glenn Morris <rgm@gnu.org>
1222
1223 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1224 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1225 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1226
33d63ff4
GM
12272012-07-13 Glenn Morris <rgm@gnu.org>
1228
5b633342
GM
1229 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1230
33d63ff4
GM
1231 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1232 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1233
b55b9f85
JD
12342012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1235
0dc8cf50
JD
1236 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1237 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1238 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1239 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1240 where appropriate.
1241 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1242 as boolean expression.
1243 (x_set_window_size): Remove unused variable toolbar.
1244 (ns_get_color_default, ns_mod_to_lisp): Remove.
1245 (ns_mouse_position): Remove unused variables xchar and ychar.
1246 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1247 (ns_set_vertical_scroll_bar): Remove unused variable count.
1248 (ns_delete_terminal): Remove unused variable i.
1249 (ns_term_init): Remove unused variables r, g and b.
1250 (mouseDown): Remove unused variable window.
1251 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1252 (initFrameFromEmacs): Remove unused variable vbextra.
1253 (mouseEntered): Remove unused variables p and dpyinfo.
1254 (mouseExited): Remove unused variables p and r.
1255 (ns_define_frame_cursor, ns_clear_frame_area)
1256 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1257 (menuDown): Assign [sender tag] to variable and cast the variable.
1258
1259 * nsterm.h (menuDown): Add id as type to argument sender.
1260 (ns_display_info_for_name): Add Lisp_Object argument.
1261 (ns_term_init): Add Lisp_Object argument.
1262 (ns_map_event_to_object): Add void argument.
1263 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1264 prototype with arguments and only declare if __OBJC__.
1265 (nxatoms_of_nsselect): Add void argument.
1266 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1267 (ns_alloc_autorelease_pool): Add void argument.
1268 (ns_release_autorelease_pool): Add void* argument.
1269 (ns_get_defaults_value): Add const char* argument.
1270
1271 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1272 (initFromContents): Use SSDATA where appropriate.
1273 (ns_update_menubar): Add braces to ambigous if-else.
1274 (initWithTitle): Put () around assignment in if statement.
1275 (ns_menu_show): Remove unused variables window and keymap.
1276 (update_frame_tool_bar): Remove unused variable selected_p.
1277 (initWithContentRect): Remove unused variable this_cmd_name.
1278
1279 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1280 appropriate.
1281 (setXBMColor): Remove unused variable len.
1282 (setPixmapData): Put () around assignment in loop statement.
1283
1284 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1285 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1286 where appropriate.
1287 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1288 around assignment in loop statement.
1289 (nsfont_open): Remove unused variable i.
1290 (nsfont_open): Remove unused variable len.
1291 (nsfont_draw): Remove unused variable cs.
1292
1293 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1294 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1295 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1296 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1297 (Fns_font_name, Fns_perform_service)
1298 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1299 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1300 (ns_set_name): Remove unused variable view.
1301 (x_set_menu_bar_lines): Remove unused variable olines.
1302 (x_set_tool_bar_lines): Remove unused variable root_window.
1303 (Fns_list_colors): Put () around assignment in while statement.
1304 (Fns_perform_service): Remove unused variable len.
1305 (Fns_display_usable_bounds): Remove unused variable top.
1306 (syms_of_nsfns): Remove unused variable i.
1307
b55b9f85
JD
1308 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1309 memcpy (Bug#11907).
1310
ed9265fc 13112012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1312
1313 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1314 and free it with DestroyExceptionInfo (Bug#11558).
1315
ef099b57
JB
13162012-07-13 Juanma Barranquero <lekktu@gmail.com>
1317
1318 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1319 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1320 Set here, not in nt/config.nt.
1321
ea814a5d
EZ
13222012-07-13 Eli Zaretskii <eliz@gnu.org>
1323
1324 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1325 cursor overflow into the last glyph on display line when the right
1326 fringe is off. (Bug#11832)
1327
1a952767
PE
13282012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 * xdisp.c (produce_special_glyphs): Now static.
1331 * dispextern.h (produce_special_glyphs): Remove decl.
1332
983188fd
GM
13332012-07-13 Glenn Morris <rgm@gnu.org>
1334
8d7c7eed 1335 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1336 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1337
983188fd
GM
1338 * s/usg5-4-common.h (USG, USG5):
1339 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1340 * s/sol2-6.h (SOLARIS2):
1341 * s/irix6-5.h (IRIX6_5):
1342 * s/hpux10-20.h (USG, USG5, HPUX):
1343 * s/gnu-linux.h (USG, GNU_LINUX):
1344 * s/freebsd.h (BSD_SYSTEM):
1345 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1346 * s/cygwin.h (CYGWIN):
1347 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1348 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1349
d1e68667 13502012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1351
1352 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1353
6de0e799
GM
13542012-07-13 Glenn Morris <rgm@gnu.org>
1355
739ae010
GM
1356 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1357
dbee5793
GM
1358 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1359
6de0e799
GM
1360 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1361 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1362
b82da769
GM
13632012-07-12 Glenn Morris <rgm@gnu.org>
1364
4fae5a7a 1365 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1366
1367 * process.c (init_process_emacs): Rename from init_process.
1368 The old name is also the name of a Mach system call.
1369 * lisp.h, emacs.c: Update for this name change.
1370 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1371 longer needed.
1372
5a979817
EZ
13732012-07-12 Eli Zaretskii <eliz@gnu.org>
1374
1375 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1376 memmove call that removes glyphs covered by the left truncation
1377 glyph. Improve commentary.
1378 (display_line): Fix display of continuation glyphs on GUI frames
1379 when the right fringe is turned off and variable-size fonts are
1380 used in the window. Move the code that appends a stretch glyph to
1381 produce_special_glyphs, so that it could be used for truncation
1382 and continuation glyphs alike.
1383 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1384 glyph of a suitably computed width, to align the special glyphs at
1385 the window margin. Code moved from display_line. (Bug#11832)
1386
3e91a053
GM
13872012-07-12 Glenn Morris <rgm@gnu.org>
1388
ba9e4b84
GM
1389 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1390
1391 * s/gnu-linux.h, s/hpux10-20.h:
1392 Do not unconditionally define HAVE_XRMSETDATABASE.
1393
3e91a053
GM
1394 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1395
b300b1f4
PE
13962012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1397
1398 Fix typos that broke OS X build.
1399 Reported by Randal L. Schwartz in
1400 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1401 * nsterm.m (ns_timeout): Add missing local decl.
1402 (ns_get_color): snprintf -> sprintf, to fix typo.
1403
6e777848
GM
14042012-07-12 Glenn Morris <rgm@gnu.org>
1405
3f922c37
GM
1406 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1407 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1408 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1409 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1410
0ab7b23a
GM
1411 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1412 Move PTY_OPEN to configure.
1413
6e777848
GM
1414 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1415 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1416 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1417
4a7edc24
DA
14182012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1419
1420 Use empty_unibyte_string where applicable.
1421 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1422 * lread.c (read1): Likewise.
1423 * xsettings.c (syms_of_xsettings): Likewise.
1424
308aab79
GM
14252012-07-12 Glenn Morris <rgm@gnu.org>
1426
42bd1719
GM
1427 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1428 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1429 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1430 * s/hpux10-20.h (RUN_TIME_REMAP):
1431 * s/bsd-common.h (TABDLY): Move to configure.
1432
1433 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1434
1435 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1436
ea0bbd17 1437 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1438 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1439
1440 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1441
308aab79
GM
1442 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1443 * s/template.h: Move NARROWPROTO to configure.
1444
ee1cf5cf
GM
14452012-07-11 Glenn Morris <rgm@gnu.org>
1446
30fe9bf4
GM
1447 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1448 unused since 2011-01-17 change to systty.h.
1449
ee1cf5cf
GM
1450 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1451 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1452 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1453
63e47e07
PE
14542012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1457
c43fb4c3
GM
14582012-07-11 Glenn Morris <rgm@gnu.org>
1459
1460 * s/darwin.h, s/gnu-linux.h, s/template.h:
1461 Move INTERRUPT_INPUT to configure.
1462
e8df9267
DA
14632012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1464
1465 Minor adjustments to interning code.
1466 * lisp.h (intern, intern_c_string): Redefine as static inline
1467 wrappers for intern_1 and intern_c_string_1, respectively.
1468 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1469 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1470 Vobarray checking.
e8df9267
DA
1471 * font.c (font_intern_prop): Likewise. Adjust comment.
1472 * w32font.c (intern_font_name): Likewise.
1473
34348bd4
AS
14742012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1475
d96a1e0c
AS
1476 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1477
34348bd4
AS
1478 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1479 of Fcar/Fcdr if possible.
1480 * font.c (check_otf_features): Likewise.
1481 * fontset.c (Fnew_fontset): Likewise.
1482 * gnutls.c (Fgnutls_boot): Likewise.
1483 * minibuf.c (read_minibuf): Likewise.
1484 * msdos.c (IT_set_frame_parameters): Likewise.
1485 * xmenu.c (Fx_popup_dialog): Likewise.
1486 * w32menu.c (Fx_popup_dialog): Likewise.
1487
c8add24e
GM
14882012-07-11 Glenn Morris <rgm@gnu.org>
1489
4b575b3c
GM
1490 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1491 since nothing has defined it on these platforms.
1492
09f4e3b0
GM
1493 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1494 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1495
172bedef
GM
1496 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1497 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1498 Move CLASH_DETECTION to configure.
1499
249685df
GM
1500 * s/gnu.h: Remove file, which is now empty.
1501
c8add24e
GM
1502 * s/gnu.h, s/gnu-linux.h:
1503 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1504
b41253a3
JW
15052012-07-11 John Wiegley <johnw@newartisans.com>
1506
1507 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1508 function attribute, so we only use it if it exists in the
1509 compiler.
1510
d923b542
DA
15112012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1512
1513 Avoid call to strlen in fast_c_string_match_ignore_case.
1514 * search.c (fast_c_string_match_ignore_case): Change to use
1515 length argument. Adjust users accordingly.
1516 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1517
5ebbef1d
PE
15182012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1519
bb352260
PE
1520 Assume mkdir, rmdir.
1521 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1522 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1523
57054ddd
PE
1524 Assume rename.
1525 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1526
b747d3f7
PE
1527 Assume perror.
1528 * s/hpux10-20.h (HAVE_PERROR): Remove.
1529 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1530 Remove dummy definition, as this problem was obsolete long ago.
1531
5ebbef1d
PE
1532 Assume strerror.
1533 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1534
984e7f30
DA
15352012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1536
1537 Avoid calls to strlen in font processing functions.
1538 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1539 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1540 users accordingly.
d923b542
DA
1541 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1542 Adjust prototypes.
1543 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1544 Change to return ptrdiff_t.
984e7f30
DA
1545 (xfont_list_pattern, xfont_match): Use length returned by
1546 xfont_decode_coding_xlfd.
1547 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1548
20e94fdd
GM
15492012-07-11 Glenn Morris <rgm@gnu.org>
1550
9d596af3
GM
1551 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1552 Move DONT_REOPEN_PTY to configure.
1553
20e94fdd
GM
1554 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1555 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1556
e99a530f
PE
15572012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1558
22ffb973
PE
1559 Remove "#define unix" that is no longer needed (Bug#11905).
1560 * s/aix4-2.h (unix): Remove; no longer needed.
1561
e9a9ae03
PE
1562 EMACS_TIME simplification (Bug#11875).
1563 This replaces macros (which typically do not work in GDB)
1564 with functions, typedefs and enums, making the code easier to debug.
1565 The functional style also makes code easier to read and maintain.
1566 * systime.h: Include <sys/time.h> on all hosts, not just if
1567 WINDOWSNT, since 'struct timeval' is needed in general.
1568 (EMACS_TIME): Now a typedef, not a macro.
1569 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1570 not macros.
1571 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1572 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1573 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1574 (EMACS_TIME_LE): Now functions, not macros.
1575 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1576 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1577 which are not functions. All uses rewritten to use:
1578 (make_emacs_time): New function.
1579 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1580 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1581 not functions. All uses rewritten to use the following, respectively:
1582 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1583 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1584 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1585 * fileio.c (Fcopy_file):
1586 * xterm.c (XTflash): Get the current time closer to when it's used.
1587 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1588
ffacb126
PE
1589 * bytecode.c (targets): Suppress -Woverride-init warnings.
1590
e99a530f
PE
1591 Simplify by avoiding confusing use of strncpy etc.
1592 * doc.c (Fsnarf_documentation):
1593 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1594 * frame.c (Fmake_terminal_frame):
1595 * gtkutil.c (get_utf8_string):
1596 * lread.c (openp):
1597 * nsmenu.m (ns_update_menubar):
1598 * regex.c (regerror):
1599 Prefer memcpy to strncpy and strncat when either will do.
1600 * fileio.c (Fsubstitute_in_file_name):
1601 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1602 (menu_separator_name_p):
1603 * nsmenu.m (ns_update_menubar):
1604 Prefer memcmp to strncmp when either will do.
1605 * nsterm.m: Include <ftoastr.h>.
1606 (ns_get_color):
1607 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1608 Prefer snprintf to strncpy.
1609 * nsterm.m (ns_term_init):
1610 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1611 * nsterm.m (ns_term_init):
1612 Avoid the need for strncpy, by using build_string or
1613 make_unibyte_string directly. Use dtoastr, not snprintf.
1614 * process.c (Fmake_network_process): Diagnose service names that
1615 are too long, rather than silently truncating them or creating
1616 non-null-terminated names.
1617 (Fnetwork_interface_info): Likewise, for interface names.
1618 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1619 Prefer sprintf to strncat.
1620 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1621 Prefer vsnprintf to vsprintf + strncpy.
1622
c59592b3
GM
16232012-07-10 Glenn Morris <rgm@gnu.org>
1624
1625 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1626 Clarify fallback case.
1627
7d7bbefd
DA
16282012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1629
1630 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1631 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1632 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1633 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1634 where argument type is known to be a Lisp_Cons.
1635
3a4c8000
TT
16362012-07-10 Tom Tromey <tromey@redhat.com>
1637
1638 * bytecode.c (BYTE_CODE_THREADED): New macro.
1639 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1640 (enum byte_code_op): New type.
1641 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1642 (exec_byte_code): Use them. Use token threading when applicable.
1643
2a0213a6
DA
16442012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1645
1646 Optimize pure C strings initialization.
1647 * lisp.h (make_pure_string): Fix prototype.
1648 (build_pure_c_string): New function, defined as static inline. This
1649 provides a better opportunity to optimize away calls to strlen when
1650 the function is called with compile-time constant argument.
1651 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1652 argument, adjust users accordingly. Use build_pure_c_string where
1653 appropriate.
1654 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1655 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1656 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1657
cb1caeaf
DA
16582012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1659
1660 Avoid calls to strlen in miscellaneous functions.
1661 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1662 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1663 * lread.c (openp): Likewise.
1664
c293e30c
DA
16652012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 Avoid calls to strlen in path processing functions.
1668 * fileio.c (file_name_as_directory): Add comment. Change to add
1669 srclen argument and return the length of result. Adjust users
1670 accordingly.
1671 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1672 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1673 users accordingly.
1674 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1675
9e059e3f
GM
16762012-07-10 Glenn Morris <rgm@gnu.org>
1677
d02eb359
GM
1678 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1679 Move PENDING_OUTPUT_COUNT definition to configure.
1680
882cf227
GM
1681 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1682 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1683 * s/gnu.h (DATA_START): Move definitions to configure.
1684
af6e839f
GM
1685 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1686 We include usg5-4-common.h, which defines them both.
1687
40289a12
GM
1688 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1689 O_RDONLY already includes it).
1690
9e059e3f
GM
1691 Stop ns builds setting the EMACSLOADPATH environment variable.
1692 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1693 Now it does not set EMACSLOADPATH, just returns the load-path string.
1694 * nsterm.h: Update accordingly.
1695 * lread.c [HAVE_NS]: Include nsterm.h.
1696 (init_lread) [HAVE_NS]: Use ns_load_path.
1697 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1698
7c4e8ec0
GM
16992012-07-09 Glenn Morris <rgm@gnu.org>
1700
d4f600ff
GM
1701 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1702 since the included bsd-common.h does so.
1703
cbb31951
GM
1704 Stop ns builds setting the EMACSPATH environment variable.
1705 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1706 (ns_init_paths): Do not set EMACSPATH.
1707 * nsterm.h (ns_exec_path): Add it.
1708 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1709 Use ns_exec_path.
1710
7c4e8ec0
GM
1711 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1712
26bccfae
PE
17132012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1714
a0bee46f
PE
1715 * process.c (wait_reading_process_output): 'waitchannels' was unset
1716 when read_kbd || !NILP (wait_for_cell); fix this.
1717
5994c183
PE
1718 Add GCC-style 'const' attribute to functions that can use it.
1719 * character.h (char_resolve_modifier_mask):
1720 * keyboard.h (make_ctrl_char):
1721 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1722 (init_character_once, next_almost_prime, init_fns, init_image)
1723 (flush_pending_output, init_sound):
1724 * mem-limits.h (start_of_data):
1725 * menu.h (finish_menu_items):
1726 Add ATTRIBUTE_CONST.
1727 * emacs.c (DEFINE_DUMMY_FUNCTION):
1728 Declare the dummy function with ATTRIBUTE_CONST.
1729 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1730 Add decls with ATTRIBUTE_CONST.
1731
26bccfae
PE
1732 Minor improvements to make_formatted_string.
1733 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1734 where int is good enough, as vsprintf returns an int.
1735 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1736
a8290ec3
DA
17372012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1738
1739 Use make_formatted_string to avoid double length calculation.
1740 * lisp.h (make_formatted_string): New prototype.
1741 * alloc.c (make_formatted_string): New function.
1742 * buffer.c (Fgenerate_new_buffer_name): Use it.
1743 * dbus.c (syms_of_dbusbind): Likewise.
1744 * editfns.c (Fcurrent_time_zone): Likewise.
1745 * filelock.c (get_boot_time): Likewise.
1746 * frame.c (make_terminal_frame, set_term_frame_name)
1747 (x_report_frame_params): Likewise.
1748 * image.c (gs_load): Likewise.
1749 * minibuf.c (get_minibuffer): Likewise.
1750 * msdos.c (dos_set_window_size): Likewise.
1751 * process.c (make_process): Likewise.
1752 * xdisp.c (ensure_echo_area_buffers): Likewise.
1753 * xsettings.c (apply_xft_settings): Likewise.
1754
d01ba2f1
GM
17552012-07-09 Glenn Morris <rgm@gnu.org>
1756
1757 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1758 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1759 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1760 * nsterm.h (ns_etc_directory): Add it.
1761 * callproc.c [HAVE_NS]: Include nsterm.h.
1762 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1763
f1f924b6
DA
17642012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1765
1766 Move marker debugging code under MARKER_DEBUG.
1767 * marker.c (MARKER_DEBUG): Move marker debugging code under
1768 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1769 for bootstrap with --enable-checking (~3x slowdown reported
1770 by Juanma Barranquero <lekktu@gmail.com>).
1771 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1772
ab531b66
PE
17732012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1776 See <http://bugs.gnu.org/11825#29>.
1777
c4b3bc8a
EZ
17782012-07-08 Eli Zaretskii <eliz@gnu.org>
1779
1780 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1781 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1782 (display_line): Add commentary about displaying truncation glyphs
1783 on GUI frames.
1784 (produce_special_glyphs): Move here from term.c.
1785
1786 * term.c (produce_special_glyphs): Move to xdisp.c.
1787
1788 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1789 section.
c4b3bc8a 1790
b676b881
AS
17912012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1792
f17c5273
AS
1793 * xdisp.c (display_line): Avoid warning about implicit declaration
1794 of FRAME_FONT.
1795
298819b9
AS
1796 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1797
b676b881
AS
1798 * lisp.h: Remove empty conditional.
1799
6045c4fd
PE
18002012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1801
b3350bf9
PE
1802 * lread.c (load_path_check): Now static.
1803
6045c4fd
PE
1804 Fix some minor --with-ns problems found by static checking.
1805 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1806 (x_set_font) [!HAVE_X_WINDOWS]:
1807 * image.c (xpm_load_image) [HAVE_NS]:
1808 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1809 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1810 Remove unused local.
1811 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1812 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1813 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1814 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1815 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1816 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1817 Fix pointer signedness problem.
1818 * xfaces.c (FRAME_X_FONT_TABLE):
1819 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1820
929e7845
GM
18212012-07-07 Glenn Morris <rgm@gnu.org>
1822
1823 * lread.c (load_path_check): New function, split from init_lread.
1824 (init_lread): Reorganize. Motivation:
1825 If EMACSLOADPATH is set, check/warn about that rather than the
1826 defaults, which we are not going to use. Hence we can remove
1827 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1828 Don't warn if site-lisp directories are missing.
1829 If not installed, start from a blank load-path, since
1830 PATH_LOADSEARCH refers to the eventual installation directories.
1831
58dd0aa4
EZ
18322012-07-07 Eli Zaretskii <eliz@gnu.org>
1833
1834 Support truncation and continuation glyphs on GUI frames, when
1835 fringes are disabled. (Bug#11832)
1836 * xdisp.c (init_iterator): Get dimensions of truncation and
1837 continuation glyphs even if on GUI frames. Adjust
1838 it->last_visible_x on GUI frames when the left or right fringes,
1839 or both, are absent.
1840 (start_display, move_it_in_display_line_to): Handle the case of a
1841 GUI frame without a fringe to display continuation or truncation
1842 glyphs.
1843 (insert_left_trunc_glyphs): Support GUI frames: make sure
1844 truncation glyphs overwrite enough glyphs from the current line to
1845 have sufficient space in pixels.
1846 (display_line): Support truncation and continuation glyphs on GUI
1847 frames. If some spare pixels are left on the line after inserting
1848 the truncation glyphs, fill that space with a stretch glyph of a
1849 suitably computed width.
1850
1851 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1852 produce_glyphs, to support GUI sessions.
1853
31571fd7
PE
18542012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1855
5a16b9bc
PE
1856 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1857
f3047c75
PE
1858 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1859
31571fd7
PE
1860 Do not require float-time's arg to fit in time_t (Bug#11825).
1861 This works better on hosts where time_t is unsigned, and where
1862 float-time is applied to the (negative) difference between two times.
1863 * editfns.c (decode_time_components): Last arg is now double *,
1864 not int *, and means to store all the result as a double, without
1865 worrying about whether the seconds part fits in time_t.
1866 All callers changed.
1867 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1868 All callers changed.
1869 (Ffloat_time): Do not fail merely because the specified time falls
1870 outside of time_t range.
1871
4516fbef
GM
18722012-07-07 Glenn Morris <rgm@gnu.org>
1873
1874 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1875 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1876 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1877
07adc2c6
JB
18782012-07-07 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1881 Update dependencies.
1882
1883 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1884
fd573f31
PE
18852012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1886
fee5959d
PE
1887 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1888 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1889 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1890 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1891 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1892 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1893
fd573f31
PE
1894 * xfont.c (compare_font_names): Redo to omit the need for casts.
1895
ddadbc0e
AS
18962012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1897
fca8d6b6
AS
1898 * xfns.c (Fx_change_window_property): Doc fix.
1899 * w32fns.c (Fx_change_window_property): Doc fix.
1900
ddadbc0e
AS
1901 * w32fns.c (Fx_window_property): Accept the same arguments as the
1902 X Windows version. Doc fix.
1903 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1904
ed9265fc 19052012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1906 Eli Zaretskii <eliz@gnu.org>
1907
1908 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1909 Windows-specific code from nt/config.nt moved here.
1910 Obsolete settings removed.
1911
216ee680
PE
19122012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 * process.c: Avoid unnecessary calls to gettime.
1915 (wait_reading_process_output): Don't get the time of day
1916 when gobbling data immediately and not waiting, as there's no need
1917 for it in that case. This removes a FIXME.
1918
bdd091e4
JD
19192012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1920
1921 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1922 is defined (Bug#11768).
1923
9d44f8ce
DA
19242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1925
1926 Fix marker debugging code.
1927 * marker.c (byte_char_debug_check): Do not perform the check
1928 if buffer is not multibyte.
090bd7cb
JB
1929 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1930 Call byte_char_debug_check with correct arguments.
9d44f8ce 1931
90fc4786
DA
19322012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1933
1934 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1935 * marker.c (byte_char_debug_check, count_markers):
1936 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1937 (byte_debug_flag): Remove.
1938 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1939 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1940
7b7ae965
DA
19412012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1942
4e57b342
DA
1943 Avoid code repetition in marker-related functions.
1944 * marker.c (attach_marker): New function.
1945 (Fset_marker, set_marker_restricted, set_marker_both)
1946 (set_marker_restricted_both): Use it.
1947 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1948 Consistently rename charno to charpos.
1949 (marker_position): Add eassert.
1950 (marker_byte_position): Convert to eassert.
1951
19522012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1953
1954 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1955 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1956 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1957
657924ff
DA
19582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1959
1960 Introduce fast path for the widely used marker operation.
1961 * alloc.c (build_marker): New function.
1962 * lisp.h (build_marker): New prototype.
1963 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1964 * composite.c (autocmp_chars): Likewise.
1965 * editfns.c (buildmark): Remove.
1966 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1967 (save_restriction_save): Use build_marker.
1968 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1969 * window.c (save_window_save): Likewise.
1970
041a49a6
DA
19712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1972
1973 Do not use Fdelete_overlay in delete_all_overlays
1974 to avoid redundant calls to unchain_overlay.
1975 * buffer.c (drop_overlay): New function.
1976 (delete_all_overlays, Fdelete_overlay): Use it.
1977 * minibuf.c (get_minibuffer): Fix comment.
1978
7dca65a4
PE
19792012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1980
1981 Port to OpenBSD 5.1 amd64.
1982 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1983 This is needed for OpenBSD, and should be harmless on all BSD systems.
1984 Also, include <sys/sysctl.h>, as it should be available on all
1985 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1986 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1987 use p_pid member, not kp_proc.pid.
1988
8eb876e2
GM
19892012-07-06 Glenn Morris <rgm@gnu.org>
1990
1991 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1992
38182d90
PE
19932012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 More xmalloc and related cleanup.
1996 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1997 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1998 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1999 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2000 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2001 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2002 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2003 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2004 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2005 * xterm.c:
2006 Omit needless casts involving void * pointers and allocation.
2007 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2008 as the former is more robust if P's type is changed.
2009 Prefer xzalloc to xmalloc + memset 0.
2010 Simplify malloc-or-realloc to realloc.
2011 Don't worry about xmalloc returning a null pointer.
2012 Prefer xstrdup to xmalloc + strcpy.
2013 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2014 growing it.
2015 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2016 alloca of a constant.
2017
6dd5a677
EZ
20182012-07-05 Eli Zaretskii <eliz@gnu.org>
2019
2020 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2021 hscroll is larger than the line width. Fixes long and futile
2022 looping inside extend_face_to_end_of_line (on a TTY) producing
2023 glyphs that are not needed and thrown away.
2024
6b312f0f
DA
20252012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2026
2027 * marker.c (set_marker_restricted_both): Simplify by using
2028 clip_to_bounds.
2029
f520ef9b
PE
20302012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2033
383b7c95
JD
20342012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2035
2036 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2037 not defined (Bug#11768).
2038 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2039 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2040 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2041 followed by gtk_box_set_homogeneous (Bug#11768).
2042 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2043 (update_theme_scrollbar_width, xg_create_scroll_bar):
2044 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2045 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2046 (is_box_type): New function (Bug#11768).
2047 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2048 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2049 with default display (Bug#11768).
2050
d6e7bf45
EZ
20512012-07-05 Eli Zaretskii <eliz@gnu.org>
2052
2053 * xdisp.c (window_hscroll_limited): New function.
2054 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2055 coordinates when window's hscroll is set to insanely large
2056 values. (Bug#11857)
2057
431391ec
JB
20582012-07-05 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2061 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2062
23f86fce
DA
20632012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2064
2065 Cleanup xmalloc.
2066 * lisp.h (xzalloc): New prototype. Omit needless casts.
2067 * alloc.c (xzalloc): New function. Omit needless casts.
2068 * charset.c: Omit needless casts. Convert all calls to
2069 xmalloc with following memset to xzalloc.
2070 * dispnew.c: Likewise.
2071 * fringe.c: Likewise.
2072 * image.c: Likewise.
2073 * sound.c: Likewise.
2074 * term.c: Likewise.
2075 * w32fns.c: Likewise.
2076 * w32font.c: Likewise.
2077 * w32term.c: Likewise.
2078 * xfaces.c: Likewise.
2079 * xfns.c: Likewise.
2080 * xterm.c: Likewise.
2081 * atimer.c: Omit needless casts.
2082 * buffer.c: Likewise.
2083 * callproc.c: Likewise.
2084 * ccl.c: Likewise.
2085 * coding.c: Likewise.
2086 * composite.c: Likewise.
2087 * doc.c: Likewise.
2088 * doprnt.c: Likewise.
2089 * editfns.c: Likewise.
2090 * emacs.c: Likewise.
2091 * eval.c: Likewise.
2092 * filelock.c: Likewise.
2093 * fns.c: Likewise.
2094 * gtkutil.c: Likewise.
2095 * keyboard.c: Likewise.
2096 * lisp.h: Likewise.
2097 * lread.c: Likewise.
2098 * minibuf.c: Likewise.
2099 * msdos.c: Likewise.
2100 * print.c: Likewise.
2101 * process.c: Likewise.
2102 * region-cache.c: Likewise.
2103 * search.c: Likewise.
2104 * sysdep.c: Likewise.
2105 * termcap.c: Likewise.
2106 * terminal.c: Likewise.
2107 * tparam.c: Likewise.
2108 * w16select.c: Likewise.
2109 * w32.c: Likewise.
2110 * w32reg.c: Likewise.
2111 * w32select.c: Likewise.
2112 * w32uniscribe.c: Likewise.
2113 * widget.c: Likewise.
2114 * xdisp.c: Likewise.
2115 * xmenu.c: Likewise.
2116 * xrdb.c: Likewise.
2117 * xselect.c: Likewise.
2118
0497dc44
PE
21192012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 * fileio.c (time_error_value): Check the right error number.
2122 Problem reported by Troels Nielsen in
2123 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2124
356e7178
PE
21252012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2126
4e71fd89
PE
2127 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2128 This should be fixed in a better way; see Eli Zaretskii in
2129 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2130 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2131
f0941253
PE
2132 * fileio.c (time_error_value): Rename from special_mtime.
2133 The old name's problems were noted by Eli Zaretskii in
2134 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2135
065c9eb4
PE
2136 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2137 This variable's comment says Emacs needs at least one GDB-visible
2138 symbol of type enum pvec_type, to work around GDB problems.
2139 The symbol's value doesn't matter.
2140
356e7178
PE
2141 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2142 that causes compilation to fail on pre-C99 compilers.
2143
ed9265fc 21442012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2145
2146 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2147 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2148
3884d954
DA
21492012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2150
d209e2fb 2151 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2152 headers for buffer_defaults and buffer_local_symbols.
2153 Reported by Juanma Barranquero <lekktu@gmail.com>.
2154
ee28be33
SM
21552012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2156
2157 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2158 * lisp.h (enum pvec_type): Use fewer bits.
2159 (PSEUDOVECTOR_SIZE_BITS): New constant.
2160 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2161 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2162 change in pvec_type.
2163 (PSEUDOVECTOR_TYPEP): New macro.
2164 (TYPED_PSEUDOVECTORP): Use it.
2165 * fns.c (internal_equal): Adapt code to extract pvectype.
2166 * emacs.c (gdb_pvec_type): Update type.
2167 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2168 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2169 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2170 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2171 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2172 abusing vector->header.next.nbytes.
2173 (live_vector_p): Use PVEC_TYPE.
2174 (mark_object): Adapt code to extract pvectype. Use switch.
2175
c7f2cd7f
PE
21762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2179 Tighten new eassert a bit.
2180
8ce70ed2
DA
21812012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2182
2183 Fix compilation with --enable-gcc-warnings and -O1
2184 optimization level.
2185 * doprnt.c (doprnt): Change type of tem to int, initialize
2186 to avoid compiler warning. Add eassert.
2187 * search.c (simple_search): Initialize match_byte to avoid
2188 compiler warning. Add eassert.
2189
dea7f1e5
PE
21902012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2191
24a212eb
PE
2192 Avoid weird behavior with large horizontal scrolls.
2193 Without this change, for example, large hscroll values would
2194 mess up Emacs's display on Fedora 15 x86, presumably due to
2195 overflows in int calculations in the display code.
2196 Also, if buffers had long lines, Emacs would freeze.
2197 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2198 (set_window_hscroll): New function, containing the old guts of
2199 Fset_window_hscroll. Return the clipped value.
2200 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2201 This avoids the need to check against PTRDIFF_MAX.
2202
dea7f1e5
PE
2203 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2204
76046526
DA
22052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2206
2207 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2208
39adff0d
PE
22092012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2210
63807d47
PE
2211 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2212 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2213 since GCC 4.4.6 issues a bogus warning for them.
2214
39adff0d
PE
2215 Fix bugs in file timestamp newness comparisons.
2216 * fileio.c (Ffile_newer_than_file_p):
2217 * lread.c (Fload): Use full timestamp resolution of files,
2218 not just the 1-second resolution, so that files that are only
2219 slightly newer still count as newer.
2220 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2221 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2222
dbeed9a6
PE
22232012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 * fileio.c: Improve handling of file time marker. (Bug#11852)
2226 (special_mtime): New function.
2227 (Finsert_file_contents, Fverify_visited_file_modtime):
2228 Use it to set special mtime values consistently.
2229
636334d6
AS
22302012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2231
2232 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2233 marker for non-existing file. (Bug#11852)
2234
e2017fe2
GM
22352012-07-03 Glenn Morris <rgm@gnu.org>
2236
2237 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2238 and did not make it into globals.h).
2239
404dbd37
TT
22402012-07-03 Tom Tromey <tromey@redhat.com>
2241
2242 * window.c (Fset_window_margins, Fset_window_fringes)
2243 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2244 * textprop.c (Fprevious_property_change): No longer static.
2245 * syntax.c (Fsyntax_table_p): No longer static.
2246 * process.c (Fget_process, Fprocess_datagram_address): No longer
2247 static.
2248 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2249 * keyboard.c (Fcommand_execute): No longer static.
2250 Remove EXFUN.
2251 * insdel.c (Fcombine_after_change_execute): No longer static.
2252 * image.c (Finit_image_library): No longer static.
2253 * fileio.c (Fmake_symbolic_link): No longer static.
2254 * eval.c (Ffetch_bytecode): No longer static.
2255 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2256 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2257 No longer static.
404dbd37
TT
2258 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2259 static.
2260 * dired.c (Ffile_attributes): No longer static.
2261 * composite.c (Fcomposition_get_gstring): No longer static.
2262 * callproc.c (Fgetenv_internal): No longer static.
2263
2264 * ccl.h: Remove EXFUNs.
2265 * buffer.h: Remove EXFUNs.
2266 * dispextern.h: Remove EXFUNs.
2267 * intervals.h: Remove EXFUNs.
2268 * fontset.h: Remove EXFUN.
2269 * font.h: Remove EXFUNs.
2270 * dosfns.c (system_process_attributes): Remove EXFUN.
2271 * keymap.h: Remove EXFUNs.
2272 * lisp.h: Remove EXFUNs.
2273 * w32term.h: Remove EXFUNs.
2274 * window.h: Remove EXFUNs.
2275 * xsettings.h: Remove EXFUN.
2276 * xterm.h: Remove EXFUN.
2277
8e4fd1e1
GM
22782012-07-03 Glenn Morris <rgm@gnu.org>
2279
2280 * lisp.h (Frandom): Make it visible to C.
2281 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2282 buffer for invisible buffers. (Bug#1229)
2283
ca95b3eb
DA
22842012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2285
2286 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2287 values which aren't power of 2.
2288 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2289 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2290 accordingly.
2291
7555c33f
SM
22922012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2293
2294 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2295
2296 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2297
d12e8f5a
DA
22982012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2299
2300 * alloc.c (allocate_vector_block): Remove redundant
2301 calls to mallopt if DOUG_LEA_MALLOC is defined.
2302 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2303 avoid calls to mallopt if zero_vector is returned.
2304
296094c3
DA
23052012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2306
2307 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2308 is enabled, avoid dereferencing NULL current_sblock if
2309 running undumped.
2310
36429c89
DA
23112012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2312
2313 Cleanup basic buffer management.
2314 * buffer.h (struct buffer): Change layout to use generic vector
2315 marking code. Fix some comments. Change type of 'clip_changed'
2316 to bitfield. Remove unused #ifndef old.
2317 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2318 (GET_OVERLAYS_AT): Fix indentation.
2319 (for_each_per_buffer_object_at): New macro.
2320 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2321 (Fbuffer_local_variables): Use it.
2322 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2323 * alloc.c (allocate_buffer): Adjust to match new layout of
2324 struct buffer. Fix comment.
2325 (mark_overlay): New function.
2326 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2327 Lisp area of struct buffer.
2328 (mark_object): Use it. Adjust marking of misc objects
2329 and related comments.
2330
3b3e4cac
PE
23312012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2334 wrapper that is not needed because the wrapped code is a no-op (zero
2335 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2336 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2337
cf5c0175
DA
23382012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2339
2340 * alloc.c (mark_buffer): Simplify. Remove prototype.
2341 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2342 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2343 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2344 redundant calls to mark_vectorlike for bool vectors.
2345
ca26824c
GM
23462012-06-30 Glenn Morris <rgm@gnu.org>
2347
2e4c5312
GM
2348 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2349
ca26824c
GM
2350 * epaths.in (PATH_SITELOADSEARCH): New.
2351 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2352 This is rather than relying on --enable-locallisppath elements
2353 having "site-lisp" in their names. (Bug#10208#25, 11658)
2354
0d23c240
EZ
23552012-06-30 Eli Zaretskii <eliz@gnu.org>
2356
c9240d7a
EZ
2357 * w32proc.c (sys_select): Accept and ignore one more argument.
2358
2359 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2360
0d23c240 2361 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2362 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2363
2364 * sysdep.c: Don't include dos.h and dosfns.h.
2365
2366 * process.c (sys_select):
2367 * msdos.c (sys_select): Accept one more argument and ignore it.
2368
2369 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2370 adapt data types and code to that.
2371
2372 * dosfns.c:
2373 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2374 which clashes with the gnulib function of the same name.
2375
af5a5a98
AS
23762012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2377
c5e4379c
AS
2378 * font.c (font_style_to_value, font_style_symbolic)
2379 (font_prop_validate_style): Add type checks for values in
2380 font_style_table.
2381
af5a5a98
AS
2382 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2383 argument.
2384 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2385 uses.
2386
8d38f461
EZ
23872012-06-29 Eli Zaretskii <eliz@gnu.org>
2388
2e5a6631
EZ
2389 * xdisp.c (try_window_id): Undo last change.
2390
8d38f461
EZ
2391 * w32.c (getwd): Adjust commentary about startup_dir.
2392 (init_environment): Always call sys_access, even in non-MSVC
2393 builds. Don't chdir to the directory of the Emacs executable.
2394 This undoes code from 1997 which was justified by the need to
2395 "avoid conflicts when removing and renaming directories". But its
2396 downside was that every relative file name was being interpreted
2397 relative to the directory of the Emacs executable, which can never
2398 be TRT. In particular, it broke sys_access when called with
2399 relative file names.
2400 (sys_access): Map GetLastError to errno.
2401
2af3565e
DA
24022012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2403
2404 * window.h (struct window): Change type of 'fringes_outside_margins'
2405 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2406 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2407 Adjust comment.
2408 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2409 to ptrdiff_t.
2410
c8d3a25c 24112012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2412
c8d3a25c
GM
2413 * gnutls.c (emacs_gnutls_handshake):
2414 Add QUIT to make the loop interruptible.
57570cd3 2415
c8d3a25c 24162012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2417
c8d3a25c
GM
2418 * charset.c (init_charset): Make lack of etc/charsets fatal.
2419
3e984ee8
DA
24202012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2421
2422 * editfns.c (region_limit): Fix type mismatch.
2423
ef884f23
DA
24242012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2425
2426 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2427 undefined. Convert from xassert to eassert.
2428 * nsmenu.m: Convert from xassert to eassert.
2429 * nsterm.m: Likewise.
2430
7d7e0027
SM
24312012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2432
2433 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2434
aa754e6a
PE
24352012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 Avoid integer overflow on scroll-left and scroll-right.
2438 * window.c (HSCROLL_MAX): New macro.
2439 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2440 overflow when requested scroll falls outside ptrdiff_t range.
2441
80b00b08
DA
24422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2443
2444 * window.h (struct window): Change type of 'hscroll',
2445 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2446 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2447 Adjust users accordingly.
2448 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2449 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2450 from EMACS_INT to ptrdiff_t.
2451 (make_window): Omit redundant initialization.
2452
62b2bcf6
JB
24532012-06-28 Juanma Barranquero <lekktu@gmail.com>
2454
2455 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2456
45942c7d
DA
24572012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2458
2459 * window.h (struct window): Change type of 'use_time' and
2460 'sequence_number' from Lisp_Object to int.
2461 * frame.c (make_frame): Adjust users accordingly.
2462 * print.c (print_object): Likewise.
2463 * window.c (select_window, Fwindow_use_time, make_parent_window)
2464 (make_window): Likewise.
2465
e509cfa6
DA
24662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2467
2468 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2469 enabled with --enable-checking=[all,glyphs] configure option.
2470 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2471 adjust comments accordingly.
2472 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2473 undefined, adjust comments accordingly.
2474 * image.c: Likewise.
2475 * scroll.c: Likewise.
2476 * w32fns.c: Likewise.
2477 * w32term.c: Likewise.
2478 * xdisp.c: Likewise.
2479 * xfaces.c: Likewise.
2480 * xfns.c: Likewise.
2481 * xterm.c: Likewise.
2482
a54e2c05
DA
24832012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2484
2485 Generalize run-time debugging checks.
2486 * dispextern.h (XASSERTS): Remove.
2487 * fontset.c (xassert): Remove.
2488 Convert from xassert to eassert.
2489 * alloc.c: Convert from xassert to eassert.
2490 * bidi.c: Likewise.
2491 * dispnew.c: Likewise.
2492 * fns.c: Likewise.
2493 * fringe.c: Likewise.
2494 * ftfont.c: Likewise.
2495 * gtkutil.c: Likewise.
2496 * image.c: Likewise.
2497 * keyboard.c: Likewise.
2498 * menu.c: Likewise.
2499 * process.c: Likewise.
2500 * scroll.c: Likewise.
2501 * sound.c: Likewise.
2502 * term.c: Likewise.
2503 * w32console.c: Likewise.
2504 * w32fns.c: Likewise.
2505 * w32term.c: Likewise.
2506 * window.c: Likewise.
2507 * xdisp.c: Likewise.
2508 * xfaces.c: Likewise.
2509 * xfns.c: Likewise.
2510 * xselect.c: Likewise.
2511 * xterm.c: Likewise.
2512
1ec4b7b2
SM
25132012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2514
2515 * fns.c (maybe_resize_hash_table): Output message when growing the
2516 purify-hashtable.
2517
2014308a
DA
25182012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2519
2520 * alloc.c (allocate_string_data): Remove dead code.
2521 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2522 avoid GCC warning about unused macro.
2523
246155eb
DA
25242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2525
2526 * alloc.c (allocate_string): Omit intervals initialization.
2527 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2528 as in make_pure_string and make_pure_c_string.
2529
43184b7b
DA
25302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2531
d209e2fb 2532 * alloc.c (allocate_string): Fix last change.
43184b7b 2533
3fe6dd74
DA
25342012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2535
d209e2fb 2536 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2537 to memset, add explicit initialization where appropriate.
2538
1ba6038a
GM
25392012-06-27 Glenn Morris <rgm@gnu.org>
2540
2541 * lisp.mk (lisp): Remove paths.elc.
2542
c89926a5
CY
25432012-06-27 Chong Yidong <cyd@gnu.org>
2544
2545 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2546
ed6b3510
JW
25472012-06-26 John Wiegley <johnw@newartisans.com>
2548
1ec4b7b2 2549 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2550 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2551
ed6b3510
JW
2552 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2553 when building with Clang.
2554
8edd4a2b
SM
25552012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2556
2557 * eval.c (Fapply): Allow calling it with a single argument.
2558
f6f62d1b
EZ
25592012-06-26 Eli Zaretskii <eliz@gnu.org>
2560
2561 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2562 _stricmp and _strnicmp.
2563 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2564
62efea5e
DA
25652012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2566
2567 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2568 allocated window.
2569 (allocate_process): Likewise for new process.
8edd4a2b 2570 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2571 (allocate_frame): Likewise.
2572 * frame.c (make_frame): Omit redundant initialization.
2573 * window.c (make_parent_window): Use memset.
2574 (make_window): Omit redundant initialization.
2575 * process.c (make_process): Omit redundant initialization.
2576 * terminal.c (create_terminal): Likewise.
2577
42997f4d
DA
25782012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2579
2580 * term.c (delete_tty): Remove redundant call to memset.
2581
1130ecfc
DA
25822012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2583
2584 * alloc.c: Remove build_string.
2585 * lisp.h: Define build_string as static inline. This provides
2586 a better opportunity to optimize away calls to strlen when the
2587 function is called with compile-time constant argument.
2588 * image.c (imagemagick_error): Convert to build_string.
2589 * w32proc.c (sys_spawnve): Likewise.
2590 * xterm.c (x_term_init): Likewise.
2591
cf38a720
PE
25922012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2593
99027bdd
PE
2594 Use sprintf return value instead of invoking strlen on result.
2595 In the old days this wasn't portable, since some sprintf
2596 implementations returned char *. But they died out years ago and
2597 Emacs already assumes sprintf returns int.
2598 Similarly for float_to_string.
2599 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2600 * ccl.c (ccl_driver):
2601 * character.c (string_escape_byte8):
2602 * data.c (Fnumber_to_string):
2603 * doprnt.c (doprnt):
2604 * print.c (print_object):
2605 * xdisp.c (message_dolog):
2606 * xfns.c (syms_of_xfns):
2607 Use sprintf or float_to_string result to avoid need to call strlen.
2608 * data.c (Fnumber_to_string):
2609 Use make_unibyte_string, since the string must be ASCII.
2610 * lisp.h, print.c (float_to_string): Now returns int length.
2611 * term.c (produce_glyphless_glyph):
2612 Use sprintf result rather than recomputing it.
2613
cf38a720
PE
2614 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2615 * Makefile.in (ALL_CFLAGS):
2616 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2617 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2618
3511c784
DA
26192012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2620
0a08eb21 2621 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2622 strcasecmp if available.
2623 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2624
fb7da12e
AS
26252012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2626
2627 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2628 Avoid comma operator.
2629 * menu.c (push_submenu_start, push_submenu_end)
2630 (push_left_right_boundary, push_menu_pane): Likewise.
2631 * msdos.c (dos_rawgetc): Likewise.
2632
afa2ffd8
DA
26332012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2634
2635 * xfns.c (xic_create_fontsetname): Remove redundant calls
2636 to memset.
2637
b3b4476b
PE
26382012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2639
4495ff38
PE
2640 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2641 sprintf already null-terminates its output.
2642
b3b4476b
PE
2643 * xfns.c (x_window): Remove redundant cast.
2644
b00876c9
DA
26452012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2646
2647 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2648 `const char *' to `char *' to avoid compiler warning.
2649
d188e26b
PE
26502012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2651
885d1d74
PE
2652 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2653 instead of truncating it to 63 (admittedly a generous limit).
2654
d188e26b
PE
2655 * process.c: Fix spelling and caps in comments.
2656
e2f560b1
DN
26572012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2658
e86db54b 2659 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2660 * sysdep.c (setpgrp): Remove definition, not used in this file.
2661
7583a3a1
JB
26622012-06-24 Juanma Barranquero <lekktu@gmail.com>
2663
2664 * makefile.w32-in: Update dependencies.
2665
696056c2
EZ
26662012-06-24 Eli Zaretskii <eliz@gnu.org>
2667
2668 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2669 (SYSTIME_H): Add nt/inc/sys/time.h.
2670
2671 * systime.h [WINDOWSNT]: Include sys/time.h.
2672
2673 * s/ms-w32.h (struct timespec): Definition moved from
2674 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2675
845ca893
PE
26762012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2679 * buffer.h (buffer_slot_type_mismatch):
2680 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2681 * eval.c (unwind_to_catch):
2682 * image.c (my_png_error, my_error_exit):
2683 * keyboard.c (quit_throw_to_read_char, user_error)
2684 (Fexit_recursive_edit, Fabort_recursive_edit):
2685 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2686 (wrong_type_argument, buffer_overflow, __executable_start)
2687 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2688 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2689 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2690 (fatal):
2691 (child_setup) [!DOS_NT]:
2692 * lread.c (end_of_file_error, invalid_syntax):
2693 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2694 * puresize.h (pure_write_error):
2695 * search.c (matcher_overflow):
2696 * sound.c (sound_perror, alsa_sound_perror):
2697 * sysdep.c, syssignal.h (croak):
2698 * term.c (maybe_fatal, vfatal):
2699 * textprop.c (text_read_only):
2700 * undo.c (user_error):
2701 * unexmacosx.c (unexec_error):
2702 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2703 Use _Noreturn rather than NO_RETURN.
2704 No need for separate decl merely because of _Noreturn.
2705 * sound.c (sound_warning, parse_sound):
2706 Remove unnecessary forward decls.
2707
f1dd8073
PE
27082012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2709
2710 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2711 * lisp.h (WAIT_READING_MAX): New macro.
2712 * dispnew.c (Fsleep_for, sit_for):
2713 * keyboard.c (kbd_buffer_get_event):
2714 * process.c (Faccept_process_output):
2715 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2716 This improves on the previous patch, which introduced a bug
2717 when time_t is unsigned and as wide as intmax_t.
2718 See <http://bugs.gnu.org/9000#51>.
2719
b82c1755
EZ
27202012-06-23 Eli Zaretskii <eliz@gnu.org>
2721
2722 * dispnew.c (sit_for, Fsleep_for):
2723 * keyboard.c (kbd_buffer_get_event):
2724 * process.c (Faccept_process_output): Avoid compiler warnings when
2725 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2726
ca300656
JB
27272012-06-23 Juanma Barranquero <lekktu@gmail.com>
2728
049ec95b
JB
2729 * makefile.w32-in: Update dependencies.
2730
ca300656
JB
2731 * w32.c (ltime): Add return type and declare static.
2732 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2733
db7b8d06
PE
27342012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2735
2736 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2737 Privately reported by Herbert J. Skuhra.
2738 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2739 All uses changed.
2740 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2741 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2742
0bd8297f
EZ
27432012-06-23 Eli Zaretskii <eliz@gnu.org>
2744
96512555
EZ
2745 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2746 last argument of make_unibyte_string.
2747
0bd8297f
EZ
2748 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2749 language ID in the event parameters.
2750
2751 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2752 event.code, not the obscure "character set ID".
2753
63def6b6
CY
27542012-06-23 Chong Yidong <cyd@gnu.org>
2755
2756 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2757
e8a02204
EZ
27582012-06-23 Eli Zaretskii <eliz@gnu.org>
2759
388cdec0
EZ
2760 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2761 * w32.c (fdutimens): New function.
2762
2763 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2764
2765 * s/ms-w32.h (pselect): Redirect to sys_select.
2766
2767 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2768
e8a02204
EZ
2769 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2770 in the logic of incrementing and decrementing the value of
2771 use_relocatable_buffers.
2772
d054f3fb
PE
27732012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2774
2775 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2776 Privately reported by Herbert J. Skuhra.
2777 [__FreeBSD__]: Remove "*/" typo after "#include".
2778 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2779 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2780 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2781 Don't assume EMACS_TIME and struct timeval are the same type.
2782
d35af63c
PE
27832012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2784
2785 Support higher-resolution time stamps (Bug#9000).
2786 The time stamps are only nanosecond-resolution at the C level,
2787 since that's the best that any real-world system supports now.
2788 But they are picosecond-resolution at the Lisp level, as that's
2789 easy, and leaves room for future OS improvements.
2790
2791 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2792 (LIBES): Use it.
2793
2794 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2795 Don't get current time unless it's needed.
2796
2797 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2798 now provides it if it's absent.
2799 (start_atimer): Port to higher-res time stamps.
2800 Check for time stamp overflow. Don't get current time more
2801 often than is needed.
2802
2803 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2804 Include systime.h, not time.h.
2805 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2806
2807 * dired.c: Include stat-time.h.
2808 (Ffile-attributes): File times now have higher resolution.
2809
2810 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2811 (struct image): Timestamp now has higher resolution.
2812
2813 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2814 has at least microseconds now. All uses removed.
2815 (update_frame, update_single_window, update_window, update_frame_1)
2816 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2817
2818 * editfns.c (time_overflow): Now extern.
2819 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2820 (float-time, Fformat_time_string, Fcurrent_time_string)
2821 (Fcurrent_time_zone): Accept and generate higher-resolution
2822 time stamps.
2823 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2824 (decode_time_components, lisp_seconds_argument): New functions.
2825 (make_time): Now static.
2826 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2827 Report an error if the time is invalid, rather than having the caller
2828 do that.
2829
2830 * fileio.c: Include <stat-time.h>
2831 (Fcopy_file): Copy higher-resolution time stamps.
2832 Prefer to set the time stamp via a file descriptor if that works.
2833 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2834 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2835 (Fvisited_file_modtime, Fset_visited_file_modtime):
2836 Support higher-resolution time stamps.
2837
2838 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2839
2840 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2841
2842 * image.c (prepare_image_for_display, clear_image_cache)
2843 (lookup_image): Port to higer-resolution time stamps.
2844
2845 * keyboard.c (start_polling, bind_polling_period):
2846 Check for time stamp overflow.
2847 (read_char, kbd_buffer_get_event, timer_start_idle)
2848 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2849 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2850 Port to higher-resolution time stamps. Do not assume time_t is signed.
2851 (decode_timer): New function. Timers are now vectors of length 9,
2852 not 8, to accommodate the picosecond component.
2853 (timer_check_2): Use it.
2854
2855 * nsterm.m (select_timeout, timeval_subtract): Remove.
2856 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2857 as they're a bit more accurate and handle overflow better.
2858 (ns_select): Change prototype to be compatible with pselect.
2859 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2860 * nsterm.h (ns_select): Adjust prototype.
2861
2862 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2863 us-resolution time stamps.
2864 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2865
2866 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2867
2868 * lisp.h (time_overflow): New decl.
2869 (wait_reading_process_output): First arg is now intmax_t, not int,
2870 to accommodate larger waits.
2871
2872 * process.h (struct Lisp_Process.read_output_delay):
2873 Now counts nanoseconds, not microseconds.
2874 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2875 EMACS_HAS_USECS.
2876 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2877 (wait_reading_process_output):
2878 Port to ns-resolution time stamps.
2879 (Faccept_process_output, wait_reading_process_output):
2880 Check for time stamp overflow. Do not assume time_t is signed.
2881 (select_wrapper): Remove; we now use pselect.
2882 (Fprocess_attributes): Now generates ns-resolution time stamps.
2883
2884 * sysdep.c: Include utimens.h. Don't include utime.h
2885 or worry about struct utimbuf; gnulib does that for us now.
2886 (gettimeofday): Remove; gnulib provides a substitute.
2887 (make_timeval): New function.
2888 (set_file_times): Now sets ns-resolution time stamps.
2889 New arg FD; all uses changed.
2890 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2891 (system_process_attributes):
2892 Now returns ns-resolution time stamp. All uses changed.
2893 Check for time stamp overflow.
2894
2895 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2896 provides a substitute now.
2897
2898 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2899 since it guarantees struct timespec.
2900 (EMACS_TIME): Now struct timespec, so that we can support
2901 ns-resolution time stamps.
2902 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2903 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2904 (EMACS_USECS): Remove.
2905 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2906 so multiply the arg by 1000 before storing it.
2907 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2908 New macros.
2909 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2910 Port to ns-resolution time stamps.
2911 (EMACS_TIME_NEG_P): Remove; replaced by....
2912 (EMACS_TIME_SIGN): New macro.
2913 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2914 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2915 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2916 (make_timeval, make_lisp_time, decode_time_components): New decls.
2917 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2918 that it mishandled time_t overflow. You can't compare by subtracting!
2919 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2920 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2921
2922 * term.c: Include <sys/time.h>.
2923 (timeval_to_Time): New function, for proper overflow wraparound.
2924 (term_mouse_position, term_mouse_click): Use it.
2925
2926 * undo.c (record_first_change): Support higher-resolution time stamps
2927 in the undo buffer.
2928 (Fprimitive_undo): Use them when restoring time stamps.
2929
2930 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2931 (w32_get_internal_run_time):
2932 Port to higher-resolution Emacs time stamps.
2933 (ltime): Now accepts single 64-bit integer, as that's more convenient
2934 for callers.
2935
2936 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2937
2938 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2939 for compatibility with pselect. Support ns-resolution time stamps.
2940
2941 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2942
2943 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2944 Check for time stamp overflow, and support ns-resolution time stamps.
2945
2946 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2947 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2948 (timeval_subtract): Remove; no longer needed.
2949 (XTflash, XTring_bell, x_wait_for_event):
2950 Port to ns-resolution time stamps. Don't assume time_t is signed.
2951
b6a92dfe
CY
29522012-06-22 Chong Yidong <cyd@gnu.org>
2953
2954 * xdisp.c (x_consider_frame_title): Revert last change.
2955
d251c37c
EZ
29562012-06-22 Eli Zaretskii <eliz@gnu.org>
2957
2958 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2959 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2960 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2961 staticidx goes up to 1597 out of 1600 = 0x640.)
2962
f10deafb
PE
29632012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2964
2965 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2966 Otherwise, the umask might be mistakenly 0 while handling input signals.
2967
ec6de1e2
SM
29682012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2969
2970 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2971
28be1ada
DA
29722012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2973
2974 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2975 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2976 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2977 access to `contents' member of Lisp_Vector objects with AREF and ASET
2978 where appropriate.
2979
c6bf3022
CY
29802012-06-19 Chong Yidong <cyd@gnu.org>
2981
2982 * frame.c (delete_frame): When selecting a frame on a different
2983 text terminal, do not alter the terminal's top-frame.
2984
2985 * xdisp.c (format_mode_line_unwind_data): Record the target
2986 frame's selected window and its terminal's top-frame.
2987 (unwind_format_mode_line): Restore them.
2988 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2989 Callers changed.
2990 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2991 since tty frames can be explicitly named.
2992 (prepare_menu_bars): Likewise.
2993
2994 * term.c (Ftty_top_frame): New function.
2995
defd4196
PE
29962012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2997
2998 Port byte-code-meter to modern targets.
2999 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3000 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3001 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3002 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3003 (METER_1, METER_2): Simplify.
3004
1053a871
SM
30052012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3006
3007 * data.c (Fdefalias): Return `symbol' (bug#11686).
3008
b7e8d081
MR
30092012-06-18 Martin Rudalics <rudalics@gmx.at>
3010
3011 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3012 gets killed during executing of this function (Bug#11665).
3013 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3014 (Vkill_buffer_query_functions): In doc-string say that functions
3015 run by this hook should not change the current buffer.
3016
7ea2b339
PE
30172012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 Fix recently-introduced process.c problems found by static checking.
3020 * process.c (write_queue_push, write_queue_pop, send_process):
3021 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3022 (write_queue_pop): Fix pointer signedness problem.
3023 (send_process): Remove unused local.
3024
96a313a1
CY
30252012-06-17 Chong Yidong <cyd@gnu.org>
3026
3027 * xdisp.c (redisplay_internal): No need to redisplay terminal
3028 frames that are not on top.
3029
20ca2e94
TN
30302012-06-17 Troels Nielsen <bn.troels@gmail.com>
3031
3032 * process.c (make_process): Initialize write_queue.
3033 (write_queue_push, write_queue_pop): New functions.
3034 (send_process): Use them to maintain correct ordering of process
3035 writes (Bug#10815).
3036
9a900ca9
PE
30372012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3038
310fbfa8
PE
3039 * lisp.h (eassert): Assume C89 or later.
3040 This removes the need for CHECK.
3041 (CHECK): Remove. Its comments about always evaluating its
3042 argument were confusing, as 'eassert' typically does not evaluate
3043 its argument.
3044
27bb1ca4
PE
3045 * coding.c (produce_chars): Use ptrdiff_t, not int.
3046
9a900ca9
PE
3047 * xterm.c (x_draw_underwave): Check for integer overflow.
3048 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3049
41b7f8bc 30502012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3051
3052 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3053 referenced (Bug#11583).
3054
9b0e3eba
AA
30552012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3056
3057 Implement wave-style variant of underlining.
3058 * dispextern.h (face_underline_type): New enum.
3059 (face): Add field for underline type.
3060 * nsterm.m (ns_draw_underwave): New function.
3061 (ns_draw_text_decoration): Use it.
3062 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3063 New functions.
3064 (x_draw_glyph_string): Use them.
3065 * xfaces.c (Qline, Qwave): New Lisp objects.
3066 (check_lface_attrs, merge_face_ref)
1053a871
SM
3067 (Finternal_set_lisp_face_attribute, realize_x_face):
3068 Handle wave-style underline face attributes.
9b0e3eba
AA
3069 * xterm.c (x_draw_underwave): New function.
3070 (x_draw_glyph_string): Use it.
3071
0fb52f11
JB
30722012-06-16 Juanma Barranquero <lekktu@gmail.com>
3073
3074 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3075 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3076 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3077 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3078 ($(BLD)/w32select.$(O)): Update dependencies.
3079
e5560ff7
AS
30802012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3081
3082 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3083 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3084 * character.c (_fetch_multibyte_char_p): Remove.
3085 * alloc.c: Include "character.h" before "buffer.h".
3086 * bidi.c: Likewise.
3087 * buffer.c: Likewise.
3088 * bytecode.c: Likewise.
3089 * callint.c: Likewise.
3090 * callproc.c: Likewise.
3091 * casefiddle.c: Likewise.
3092 * casetab.c: Likewise.
3093 * category.c: Likewise.
3094 * cmds.c: Likewise.
3095 * coding.c: Likewise.
3096 * composite.c: Likewise.
3097 * dired.c: Likewise.
3098 * dispnew.c: Likewise.
3099 * doc.c: Likewise.
3100 * dosfns.c: Likewise.
3101 * editfns.c: Likewise.
3102 * emacs.c: Likewise.
3103 * fileio.c: Likewise.
3104 * filelock.c: Likewise.
3105 * font.c: Likewise.
3106 * fontset.c: Likewise.
3107 * fringe.c: Likewise.
3108 * indent.c: Likewise.
3109 * insdel.c: Likewise.
3110 * intervals.c: Likewise.
3111 * keyboard.c: Likewise.
3112 * keymap.c: Likewise.
3113 * lread.c: Likewise.
3114 * macros.c: Likewise.
3115 * marker.c: Likewise.
3116 * minibuf.c: Likewise.
3117 * nsfns.m: Likewise.
3118 * nsmenu.m: Likewise.
3119 * print.c: Likewise.
3120 * process.c: Likewise.
3121 * regex.c: Likewise.
3122 * region-cache.c: Likewise.
3123 * search.c: Likewise.
3124 * syntax.c: Likewise.
3125 * term.c: Likewise.
3126 * textprop.c: Likewise.
3127 * undo.c: Likewise.
3128 * unexsol.c: Likewise.
3129 * w16select.c: Likewise.
3130 * w32fns.c: Likewise.
3131 * w32menu.c: Likewise.
3132 * window.c: Likewise.
3133 * xdisp.c: Likewise.
3134 * xfns.c: Likewise.
3135 * xmenu.c: Likewise.
3136 * xml.c: Likewise.
3137 * xselect.c: Likewise.
3138
2f07e6af
EZ
31392012-06-16 Eli Zaretskii <eliz@gnu.org>
3140
1053a871
SM
3141 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3142 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3143 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3144 row.
3145 (handle_face_prop): Use chunk-relative overlay string index when
3146 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3147 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3148 the rightmost. (Bug#11720)
2f07e6af 3149
29b83cec
AS
31502012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3151
3152 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3153 (CATEGORY_MEMBER): Enforce 1/0 value.
3154 * category.c (_temp_category_set): Remove.
3155
4c5501e9
EZ
31562012-06-16 Eli Zaretskii <eliz@gnu.org>
3157
3158 * window.c (Fdelete_other_windows_internal)
3159 (Fdelete_window_internal): Don't access frame's mouse highlight
3160 info of the initial frame. (Bug#11677)
3161
2b570124
PE
31622012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3163
e93864f9
PE
3164 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3165 Assume USE_2_TAGS_FOR_INTS.
3166 (xreload): Adjust $tagmask width to match recent lisp.h change.
3167
2b570124
PE
3168 Simplify lisp.h in minor ways that should not affect code.
3169 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3170 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3171 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3172 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3173 (INTTYPEBITS): New macro, for clarity.
3174 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3175 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3176 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3177 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3178 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3179
81755f69
JB
31802012-06-13 Juanma Barranquero <lekktu@gmail.com>
3181
3182 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3183
16192a57
GM
31842012-06-13 Glenn Morris <rgm@gnu.org>
3185
3186 * s/bsd-common.h (BSD4_3):
3187 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3188
646b5f55
AS
31892012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3190
3191 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3192 instead of union.
3193 (XLI, XIL): Define.
1053a871
SM
3194 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3195 Use them.
3196 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3197 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3198 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3199 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3200 * frame.c (delete_frame): Remove outdated comment.
3201 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3202 USE_LISP_UNION_TYPE.
3203 (Fw32_unregister_hot_key): Likewise.
3204 (Fw32_toggle_lock_key): Likewise.
3205 * w32menu.c (add_menu_item): Likewise.
3206 (w32_menu_display_help): Use XIL instead of checking
3207 USE_LISP_UNION_TYPE.
3208 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3209 (init_heap): Likewise.
3210 * w32term.c (w32_read_socket): Update comment.
3211
1d3823c9
GM
32122012-06-13 Glenn Morris <rgm@gnu.org>
3213
c62ff706
GM
3214 * s/usg5-4-common.h, src/s/unixware.h:
3215 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3216
1d3823c9
GM
3217 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3218
bfe3e0a2
PE
32192012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3220
3221 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3222 * alloc.c (make_number) [!defined make_number]:
3223 Remove, as lisp.h always defines this now.
3224 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3225 (roundup_size): Verify that it is a power of 2.
3226 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3227 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3228 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3229 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3230 USE_LSB_TAG now is always defined to be either 0 or 1.
3231 All uses changed.
3232 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3233 code works fine either way, and efficiency is not a concern here,
3234 as the union type is for debugging, not for production.
3235 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3236 Use an inline function on all platforms when using the union type,
3237 since this is simpler and 'static inline' can be used portably
3238 within Emacs now.
3239 (LISP_INITIALLY_ZERO): New macro.
3240 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3241 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3242
45fa9c0f
GM
32432012-06-12 Glenn Morris <rgm@gnu.org>
3244
b4492cba
GM
3245 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3246
3247 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3248
45fa9c0f
GM
3249 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3250 Move BROKEN_SIGIO to configure.
3251
3252 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3253 Move NO_TERMIO to configure.
3254
0e25d334
CY
32552012-06-12 Chong Yidong <cyd@gnu.org>
3256
3257 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3258 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3259 MagickExportImagePixels is undefined.
3260
43682bb6
PE
32612012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 * image.c (imagemagick_load_image): Remove unused label.
3264
a9be7d2b
GM
32652012-06-11 Glenn Morris <rgm@gnu.org>
3266
3267 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3268 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3269 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3270 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3271
3017f87f
SM
32722012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3273
3274 * alloc.c (make_byte_code): New function.
3275 (Fmake_byte_code): Use it. Don't purify here.
3276 * lread.c (read1): Use it as well to avoid extra allocation.
3277
1b9b4cf4
CY
32782012-06-11 Chong Yidong <cyd@gnu.org>
3279
3280 * image.c (imagemagick_load_image): Implement transparency.
3281
95988fcf
AS
32822012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3283
3284 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3285 account for preceding backslashes. (Bug#11663)
3286
cd4eb164
CY
32872012-06-09 Chong Yidong <cyd@gnu.org>
3288
3289 * term.c: Support italics in capable terminals (Bug#9652).
3290 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3291 (turn_on_face): Output using TS_enter_italic_mode if available.
3292 Don't handle unused blinking and alt-charset cases.
3293 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3294 and tty_alt_charset_p cases.
3295 (tty_capable_p, init_tty): Support italics.
3296
3297 * termchar.h (struct tty_display_info): Add field for italics.
3298 Remove unused blink field.
3299
3300 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3301 Handle slant.
3302
3303 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3304 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3305 tty_alt_charset_p. Add tty_italic_p.
3306
ff88beb8
MA
33072012-06-09 Michael Albinus <michael.albinus@gmx.de>
3308
3309 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3310 dbus_type_is_basic if available.
3311 (xd_extract_signed, xd_extract_unsigned): Rename from
3312 extract_signed and extract_unsigned, respectively. Adapt callers.
3313
44286096
CY
33142012-06-09 Chong Yidong <cyd@gnu.org>
3315
1682701f
CY
3316 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3317
44286096
CY
3318 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3319 case (Bug#9752).
3320
d86feb17
PE
33212012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3322
3323 * xdisp.c (vmessage): Treat frame message as multibyte.
3324 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3325 would generate the diagnostic "Making \302\247 buffer-local while
3326 let-bound!".
3327
d5c20fe8
EZ
33282012-06-08 Eli Zaretskii <eliz@gnu.org>
3329
3330 * dispnew.c (showing_window_margins_p): Undo last change, which
3331 was done due to an inadvertent commit.
3332 (adjust_frame_glyphs_for_frame_redisplay): Do call
3333 showing_window_margins_p.
3334
513749ee
SM
33352012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3336
3337 * eval.c (Fmake_var_non_special): New primitive.
3338 (syms_of_eval): Defsubr it.
3339 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3340
d4a8f5c1
JB
33412012-06-08 Juanma Barranquero <lekktu@gmail.com>
3342
3343 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3344 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3345
8bbbc977
EZ
33462012-06-08 Eli Zaretskii <eliz@gnu.org>
3347
3348 * alloc.c (allocate_vectorlike): Fix last change.
3349
f3372c87
DA
33502012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3351
3352 Block-based vector allocation of small vectors.
3353 * lisp.h (struct vectorlike_header): New field `nbytes',
3354 adjust comment accordingly.
3355 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3356 to denote vector blocks. Adjust users (live_vector_p,
3357 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3358 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3359 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3360 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3361 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3362 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3363 (roundup_size): New constant.
3364 (struct vector_block): New data type.
3365 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3366 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3367 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3368 (sweep_vectors): New functions.
3369 (allocate_vectorlike): Return `zero_vector' as the only vector of
3370 0 items. Allocate new vector from block if vector size is less than
3371 or equal to VBLOCK_BYTES_MAX.
3372 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3373 (init_alloc_once): Add call to init_vectors.
3374
4f18a4ed
SM
33752012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3376
3377 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3378
86f158bc
PE
33792012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3380
3381 * doprnt.c (doprnt): Truncate multibyte char correctly.
3382 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3383 would mishandle a string argument "Xc" if X was a multibyte
3384 character of length 2: it would truncate after X's first byte
3385 rather than including all of X.
3386
c5cfcbe0
CY
33872012-06-06 Chong Yidong <cyd@gnu.org>
3388
3389 * buffer.c (word_wrap): Doc fix.
3390
c05cf390
PE
33912012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3392
3393 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3394
0c3461de
GM
33952012-06-03 Glenn Morris <rgm@gnu.org>
3396
3397 * xdisp.c (tool-bar-style): Doc fix.
3398
c71232db
UM
33992012-06-03 Ulrich Müller <ulm@gentoo.org>
3400
3401 * Makefile.in (PAXCTL): Define.
3402 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3403 binary via PaX flags if the paxctl utility is available.
3404 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3405 Restore PaX flags to their default. (Bug#11398)
3406
383f7350
CY
34072012-06-03 Chong Yidong <cyd@gnu.org>
3408
3409 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3410 buffer (Bug#11226).
3411
5f2c76c6
CY
34122012-06-03 Chong Yidong <cyd@gnu.org>
3413
3414 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3415 (note_mode_line_or_margin_highlight): If there is no help echo,
3416 use mode-line-default-help-echo. Handle the case where the mouse
3417 position is past the end of the mode line string.
3418
3419 * buffer.c (buffer_local_value_1): New function, split from
3420 Fbuffer_local_value; can return Qunbound.
3421 (Fbuffer_local_value): Use it.
3422 (Vmode_line_format): Docstring tweaks.
3423
773d47f6
PE
34242012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 * sysdep.c (system_process_attributes): Improve comment.
3427
f2d6a3df
SM
34282012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3429
3430 * keyboard.c: Export real-this-command to Elisp.
3431 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3432 and DEFVAR it. Update all users.
3433
63810350
PE
34342012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3435
7bd5c1f4
PE
3436 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3437
63810350
PE
3438 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3439 Convert pctcpu and pctmem to Lisp float properly.
3440 Let the compiler fold better, as 100.0/0x8000 is exact.
3441
a2821611
AS
34422012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3443
3444 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3445 cons_block.
3446
5fceba1d
PE
34472012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3448
3449 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3450
c98ff5dd
DA
34512012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3452
3453 For a 'struct window', replace some Lisp_Object fields to
3454 bitfields where appropriate, remove unused fields.
3455 * window.h (struct window): Remove unused 'last_mark_x' and
3456 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3457 change it's type from Lisp_Object to bitfield.
3458 Change type of 'force_start', 'optional_new_start',
3459 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3460 fields from Lisp_Object to bitfield. Adjust users accordingly.
3461
ca34e0be
PE
34622012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3463
3464 Pacify gcc -Wdouble-precision when using Xaw.
3465 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3466 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3467 Use 'float' consistently, rather than 'float' in most places
3468 and 'double' in a couple of places.
3469
efc00ab1 34702012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3471
3472 * xdisp.c (handle_stop): Detect whether we have overlay strings
3473 loaded by testing it->current.overlay_string_index to be
3474 non-negative, instead of checking whether n_overlay_strings is
3475 positive. (Bug#11587)
3476
efc00ab1 34772012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3478
3479 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3480
3481 * doc.c (Fsubstitute_command_keys): Doc fix.
3482
efc00ab1 34832012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3484
3485 * search.c (search_buffer): Remove calls to
3486 r_alloc_inhibit_buffer_relocation, as it is now called by
3487 maybe_unify_char, which was the cause of relocation of buffer text
3488 in bug#11519.
3489
efc00ab1 34902012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3491
3492 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3493 for the duration of call to load_charset, to avoid problems with
3494 callers of maybe_unify_char that access buffer text through C
3495 pointers.
3496
3497 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3498 decrement the inhibition flag, instead of just setting or
3499 resetting it.
3500
ba93a187
PE
35012012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3502
3503 Remove obsolete '#define static' cruft.
3504 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3505 This #undef was "temporary" in 2000; it is no longer needed
3506 now that '#define static' has gone away.
3507 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3508 (gray_bitmap_bits): Remove; no longer needed.
3509 All uses replaced with definiens.
3510 * xterm.c: Include "bitmaps/gray.xbm".
3511
9e4bf381
PE
35122012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 Clean up __executable_start, monstartup when --enable-profiling.
3515 The following changes affect the code only when profiling.
3516 * dispnew.c (__executable_start): Rename from safe_bcopy.
3517 Define only on platforms that need it.
3518 * emacs.c: Include <sys/gmon.h> when profiling.
3519 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3520 (__executable_start): Remove decl, since lisp.h does it now.
3521 (safe_bcopy): Remove decl; no longer has that name.
3522 (main): Coalesce #if into single bit of code, for simplicity.
3523 Cast pointers to uintptr_t, since standard libraries want integers
3524 and not pointers.
3525 * lisp.h (__executable_start): New decl.
3526
32d72c2f
GM
35272012-05-31 Glenn Morris <rgm@gnu.org>
3528
3529 * image.c (Fimagemagick_types): Doc fix.
3530
baac5bc7
JM
35312012-05-30 Jim Meyering <meyering@redhat.com>
3532
3533 * callproc.c (Fcall_process_region): Include directory component
3534 in mkstemp error message (Bug#11586).
3535
72cb32cf
PE
35362012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3537
3538 * alloc.c, lisp.h (make_pure_vector): Now static.
3539
61b108cc
SM
35402012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3541
3542 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3543 Move to byte-run.el.
3544 (Fautoload): Do the hash-doc more carefully.
3545 * data.c (Fdefalias): Purify definition, except for keymaps.
3546 (Qdefun): Move from eval.c.
3547 * lisp.h (Qdefun): Remove.
3548 * lread.c (read1): Tiny simplification.
3549
471fe23d
TN
35502012-05-29 Troels Nielsen <bn.troels@gmail.com>
3551
934f3f58 3552 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3553 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3554 Bug#9642, but explicitly check that the buffer the overlay would
3555 be moved to is live and rearrange lines to make sure that errors
3556 will not put the overlay in an inconsistent state.
3557 (Fdelete_overlay): Cosmetics.
3558
85d0efd1
EZ
35592012-05-28 Eli Zaretskii <eliz@gnu.org>
3560
3561 * w32term.c (my_bring_window_to_top): New function.
3562 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3563 could be different from the original one.
3564 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3565 (Bug#11513)
3566
3567 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3568 by calling BringWindowToTop.
3569
3570 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3571 (WM_EMACS_END): Increase by one.
3572
da92a98c
PE
35732012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3576 This avoids undefined behavior that might cause the eassert
3577 to not catch an out-of-range value.
3578
74d1f848
JB
35792012-05-28 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3582 Update dependencies.
3583
9e1a06fc
EZ
35842012-05-27 Eli Zaretskii <eliz@gnu.org>
3585
3586 * bidi.c (bidi_mirror_char): Fix last change.
3587
f3dd7312
AS
35882012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3589
3590 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3591 when referring to sectname field in printf format.
3592
81899c91
PE
35932012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3594
57b81a9f
PE
3595 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3596 Only r_alloc_inhibit_buffer_relocation needed to be added;
3597 the others were already declared.
3598
81899c91
PE
3599 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3600 before checking whether it's out of range. Put the check inside
3601 eassert. See
3602 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3603
33017faf 36042012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3605
3606 * callproc.c (Fcall_process): Restore a line that was accidentally
3607 commented out in the 2011-02-13 change (bug#11547).
3608
33017faf 36092012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3610
3611 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3612 defined on ralloc.c.
3613
3614 * buffer.c [REL_ALLOC]: Remove prototypes of
3615 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3616 they are now on lisp.h.
3617
3618 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3619
3620 * search.c (search_buffer): Use it to inhibit relocation of buffer
3621 text while re_search_2 is doing its job, because re_search_2 is
3622 passed C pointers to buffer text. (Bug#11519)
3623
23415acf
EZ
3624 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3625 Update value to 24.
3626
44e27368
EZ
3627 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3628 state after an additional call to move_it_in_display_line_to, keep
3629 the values of it->max_ascent and it->max_descent found for the
3630 entire line.
3631 (pos_visible_p): Revert the comparison against bottom_y to what it
3632 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3633 (Bug#11464)
3634
c1892f11
PE
36352012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3636
3637 Fix coding-related core dumps with gcc -ftrapv.
3638 The code was computing A - B, where A and B are pointers, and B is
3639 random garbage. This can lead to core dumps on platforms that
3640 have special pointer registers, and it also leads to core dumps on
3641 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3642 A - B only when B is initialized properly.
3643 * coding.c (coding_set_source, coding_set_destination): Return void.
3644 (coding_change_source, coding_change_destinations): New functions,
3645 with the old behaviors of coding_set_source and coding_set_destination.
3646 All callers that need an offset changed to use these new functions.
3647
eb7afdad
GM
36482012-05-26 Glenn Morris <rgm@gnu.org>
3649
3650 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3651
f12fdf02
EZ
36522012-05-26 Eli Zaretskii <eliz@gnu.org>
3653
53a63be6 3654 Extend mouse support on W32 text-mode console.
61b108cc
SM
3655 * xdisp.c (draw_row_with_mouse_face):
3656 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3657
eb3f6f01 3658 * w32console.c: Include window.h.
61b108cc
SM
3659 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3660 New functions.
eb3f6f01
EZ
3661 (initialize_w32_display): Initialize mouse-highlight data.
3662
53a63be6
EZ
3663 * w32inevt.c: Include termchar.h and window.h.
3664 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3665 moves, call note_mouse_highlight. If help_echo changed, call
3666 gen_help_event to produce help-echo message in the echo area.
3667 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3668 highlight info.
3669
4cfd81f6
PE
36702012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3671
3672 * lread.c (read1): Simplify slightly to avoid an overflow warning
3673 with GCC 4.7.0 on x86-64.
3674
4446092a
EZ
36752012-05-26 Eli Zaretskii <eliz@gnu.org>
3676
3677 * bidi.c (bidi_mirror_char): Revert last change: an int is
3678 definitely wide enough here.
3679
42b2a986 36802012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3681
42b2a986 3682 Fix integer width and related bugs (Bug#9874).
eb106a49 3683 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3684 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3685 (string_bytes, check_sblock, allocate_string_data):
3686 (compact_small_strings, Fmake_bool_vector, make_string)
3687 (make_unibyte_string, make_multibyte_string)
3688 (make_string_from_bytes, make_specified_string)
3689 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3690 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3691 (mark_vectorlike):
3692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3693 (allocate_pseudovector):
3694 Use int, not EMACS_INT, where int is wide enough.
3695 (inhibit_garbage_collection, Fgarbage_collect):
3696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3697 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3698 int might not be wide enough.
3699 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3700 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3701 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3702 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3703 (bidi_level_of_next_char, bidi_move_to_visually_next):
3704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3705 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3706 (Fkill_buffer, Fset_buffer_major_mode)
3707 (advance_to_char_boundary, Fbuffer_swap_text)
3708 (Fset_buffer_multibyte, overlays_at, overlays_in)
3709 (overlay_touches_p, struct sortvec, record_overlay_string)
3710 (overlay_strings, recenter_overlay_lists)
3711 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3712 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3713 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3714 (Foverlay_recenter, last_overlay_modification_hooks_used)
3715 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3717 (validate_region): Omit unnecessary test for b <= e,
3718 since that's guaranteed by the previous test.
d311d28c
PE
3719 (adjust_overlays_for_delete): Avoid pos + length overflow.
3720 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3721 (report_overlay_modification):
3722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3723 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3724 Omit pointer cast, which isn't needed anyway, and doesn't work
3725 after the EMACS_INT -> ptrdiff_t change.
02481186 3726 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3727 * buffer.h: Adjust decls to match defn changes elsewhere.
3728 (struct buffer_text, struct buffer):
3729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3730 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3731 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3732 not int, to avoid needless 32-bit limit on 64-bit hosts.
3733 (exec_byte_code): Use tighter memory-full test, one that checks
3734 for alloca overflow. Don't compute the address of the object just
3735 before an array, as that's not portable. Use EMACS_INT, not
3736 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3737 * callint.c (Fcall_interactively):
3738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3739 * callproc.c (call_process_kill, Fcall_process):
3740 Don't assume pid_t fits into an Emacs fixnum.
3741 (call_process_cleanup, Fcall_process, child_setup):
3742 Don't assume pid_t fits into int.
3743 (call_process_cleanup, Fcall_process, delete_temp_file)
3744 (Fcall_process_region):
3745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3746 (Fcall_process): Simplify handling of volatile integers.
3747 Use int, not EMACS_INT, where int will do.
3748 * casefiddle.c (casify_object, casify_region, operate_on_word)
3749 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3751 (casify_object): Avoid integer overflow when overallocating buffer.
3752 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3753 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3754 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3755 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3756 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3757 integers are now checked earlier. All uses replaced with XINT.
3758 (ccl_driver):
3759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3760 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3761 (ccl_driver, Fregister_code_conversion_map):
3762 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3763 (resolve_symbol_ccl_program): Check that vector header is in range.
3764 Always copy the vector, so that we can check its contents reliably
3765 now rather than having to recheck each instruction as it's being
3766 executed. Check that vector words fit in 'int'.
3767 (ccl_get_compiled_code, Fregister_ccl_program)
3768 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3769 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3770 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3771 contents are in range.
3772 (Fccl_execute_on_string): Check that status is in range.
3773 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3774 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3775 Accept and return EMACS_INT, not int, because callers can pass values
3776 out of 'int' range.
3777 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3778 (multibyte_chars_in_text, parse_str_as_multibyte)
3779 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3780 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3781 (string_escape_byte8, Fget_byte):
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3783 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3784 avoid mishandling large integers.
3785 * character.h: Adjust decls to match defn changes elsewhere.
3786 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3787 (Ffind_charset_region):
3788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3789 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3790 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3791 Don't assume fixnum fits in int.
d311d28c
PE
3792 (load_charset_map_from_vector, Fmap_charset_chars):
3793 Remove now-unnecessary CHECK_NATNUMs.
3794 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3795 Don't rely on undefined behavior with signed left shift overflow.
3796 Don't assume unsigned int fits into fixnum, or that fixnum fits
3797 into unsigned int. Don't require max_code to be a valid fixnum;
3798 that's not true for gb10830 4-byte on a 32-bit host. Allow
3799 invalid_code to be a cons, for the same reason. Require code_offset
3800 to be a character. Avoid int overflow if max_char is close
3801 to INT_MAX.
3802 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3803 this is intended anyway and avoids some undefined behavior.
3804 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3805 INDEX_TO_CODE_POINT, as that's what it expects.
3806 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3807 * charset.h (DECODE_CHAR): Return int, not unsigned;
3808 this is what was intended anyway, and it avoids undefined behavior.
3809 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3810 integer-overflow issues.
3811 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3812 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3813 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3814 * chartab.c (Fmake_char_table, Fset_char_table_range)
3815 (uniprop_get_decoder, uniprop_get_encoder):
3816 Don't assume fixnum fits in int.
3817 * cmds.c (move_point): New function, that does the gist of
3818 Fforward_char and Fbackward_char, but does so while checking
3819 for integer overflow more accurately.
c96e5d6a 3820 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3821 (Fforward_line, Fend_of_line, internal_self_insert)
3822 (internal_self_insert):
3823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3824 Fix a FIXME, by checking for integer overflow when calculating
3825 target_clm and actual_clm.
3826 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3827 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3828 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3829 (coding_alloc_by_making_gap, alloc_destination)
3830 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3831 (encode_coding_utf_16, detect_coding_emacs_mule)
3832 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3833 (detect_coding_iso_2022, decode_coding_iso_2022)
3834 (encode_invocation_designation, encode_designation_at_bol)
3835 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3836 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3837 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3838 (encode_coding_ccl, encode_coding_raw_text)
3839 (detect_coding_charset, decode_coding_charset)
3840 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3841 (produce_composition, produce_charset, produce_annotation)
3842 (decode_coding, handle_composition_annotation)
3843 (handle_charset_annotation, consume_chars, decode_coding_gap)
3844 (decode_coding_object, encode_coding_object, detect_coding_system)
3845 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3846 (code_convert_region, code_convert_string)
8f50130c
PE
3847 (Fdefine_coding_system_internal)
3848 (coding_set_source, coding_set_destination):
d311d28c
PE
3849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3850 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3851 (Fdefine_coding_system_internal):
3852 Don't assume fixnums fit in int.
3853 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3854 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3855 (Funencodable_char_position, Fcheck_coding_systems_region)
3856 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3858 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3859 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3860 Don't access memory outside of the args array.
d311d28c 3861 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3862 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3863 result of ENCODE_CHAR.
d311d28c
PE
3864 * coding.h: Adjust decls to match defn changes elsewhere.
3865 (struct coding_system):
3866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3867 * composite.c (get_composition_id, find_composition)
3868 (run_composition_function, update_compositions)
3869 (compose_text, composition_gstring_put_cache)
3870 (composition_gstring_p, composition_gstring_width)
3871 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3872 (composition_compute_stop_pos, composition_reseat_it)
3873 (composition_update_it, struct position_record)
3874 (find_automatic_composition, composition_adjust_point)
3875 (Fcomposition_get_gstring, Ffind_composition_internal):
3876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3877 (update_compositions):
3878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3879 * composite.h: Adjust decls to match defn changes elsewhere.
3880 (struct composition):
3881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3882 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3883 Do not attempt to compute the address of the object just before a
3884 buffer; this is not portable.
3885 (Faref, Faset):
3886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3887 (Faset): Use int, not EMACS_INT, where int is wide enough.
3888 (Fstring_to_number): Don't assume fixnums fit in int.
3889 (Frem): Don't assume arg is nonnegative.
3890 * dbusbind.c (xd_append_arg): Check for integers out of range.
3891 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3892 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3893 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3894 (xd_get_connection_references): Return ptrdiff_t, not int.
3895 All uses changed.
3896 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3897 (xd_read_message_1):
3898 Use int, not unsigned, where the dbus API uses int.
3899 (Fdbus_message_internal): Don't overflow mtype.
3900 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3901 * dired.c (directory_files_internal, file_name_completion, scmp)
3902 (file_name_completion_stat):
3903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3904 (file_name_completion): Don't overflow matchcount.
3905 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3906 * dispextern.h: Adjust decls to match defn changes elsewhere.
3907 (struct text_pos, struct glyph, struct bidi_saved_info)
3908 (struct bidi_string_data, struct bidi_it, struct composition_it)
3909 (struct it):
3910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3911 (struct display_pos, struct composition_it, struct it):
3912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3913 * dispnew.c (increment_matrix_positions)
3914 (increment_row_positions, mode_line_string)
3915 (marginal_area_string):
3916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3917 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3919 (duration_to_sec_usec): New function, to check for overflow better.
3920 (Fsleep_for, sit_for): Use it.
3921 * doc.c (get_doc_string, store_function_docstring):
3922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3923 (get_doc_string, Fsnarf_documentation):
3924 Use int, not EMACS_INT, where int is wide enough.
3925 (get_doc_string):
3926 Use SAFE_ALLOCA, not alloca.
3927 Check for overflow when converting EMACS_INT to off_t.
3928 * doprnt.c (doprnt):
3929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3930 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3931 Don't assume uid_t fits into fixnum.
3932 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3933 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3934 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3935 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3936 (general_insert_function)
3937 (Finsert_char, make_buffer_string, make_buffer_string_both)
3938 (update_buffer_properties, Fbuffer_substring)
3939 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3940 (Fsubst_char_in_region, check_translation)
3941 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3942 (transpose_markers, Ftranspose_regions):
3943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3944 (clip_to_bounds): Move to lisp.h as an inline function).
3945 (Fconstrain_to_field): Don't assume integers are nonnegative.
3946 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3947 (Fsubst_char_in_region, Fsave_restriction):
3948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3949 (Femacs_pid): Don't assume pid_t fits into fixnum.
3950 (lo_time): Use int, not EMACS_INT, when int suffices.
3951 (lisp_time_argument): Check for usec out of range.
3952 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3953 (Fuser_login_name, Fuser_full_name): Signal an error
3954 if a uid argument is out of range, rather than relying on
3955 undefined behavior.
c8d5c857
PE
3956 (Fformat_time_string): Remove now-unnecessary check.
3957 lisp_time_argument checks for out-of-range usec now.
243e0530 3958 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3959 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3960 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3961 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3962 (init_cmdargs, Fdump_emacs):
3963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3964 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3965 the bottom (typically) 32 bits of the fixnum.
3966 * eval.c (specpdl_size, call_debugger):
3967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3968 (when_entered_debugger, Fbacktrace_debug):
3969 Don't assume fixnum can fit in int.
3970 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3971 the object just before a buffer; this is not portable.
3972 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3973 (grow_specpdl, unbind_to):
3974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3975 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3976 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3977 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3978 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3979 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3981 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3982 (a_write, e_write):
3983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3984 (Fcopy_file, non_regular_nbytes, read_non_regular)
3985 (Finsert_file_contents):
3986 Use int, not EMACS_INT, where int is wide enough.
3987 (READ_BUF_SIZE): Verify that it fits in int.
3988 (Finsert_file_contents): Check that counts are in proper range,
3989 rather than assuming fixnums fit into ptrdiff_t etc.
3990 Don't assume fixnums fit into int.
125b3835 3991 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3992 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3993 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3994 (string_char_to_byte, string_byte_to_char)
3995 (string_make_multibyte, string_to_multibyte)
3996 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3997 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3998 (substring_both, Fdelete, internal_equal, Ffillarray)
3999 (Fclear_string, mapcar1)
4000 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4001 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4002 (larger_vector, make_hash_table, maybe_resize_hash_table)
4003 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4004 (Fmaphash, secure_hash):
4005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4006 (concat): Check for string index and length overflow.
4007 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4008 (Frequire):
4009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4010 (larger_vector): New API (vec, incr_min, size_max) replaces old
4011 one (vec, new_size, init). This catches size overflow.
4012 INIT was removed because it was always Qnil.
4013 All callers changed.
4014 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4015 the upper bound on a hash table index size.
4016 (make_hash_table, maybe_resize_hash_table): Use it.
4017 (secure_hash): Computer start_byte and end_byte only after
4018 they're known to be in ptrdiff_t range.
4019 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4020 (Ffont_get_glyphs, Ffont_at):
4021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4022 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4023 (Flist_fonts, Fopen_font):
4024 Don't assume fixnum can fit in int.
4025 (check_gstring): Don't assume index can fit in int.
4026 (font_match_p): Check that fixnum is a character, not a nonnegative
4027 fixnum, since the later code needs to stuff it into an int.
4028 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4029 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4030 conversion overflow issues.
4031 (Fopen_font): Check for integer out of range.
4032 (Ffont_get_glyphs): Don't assume index can fit in int.
4033 * font.h: Adjust decls to match defn changes elsewhere.
4034 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4035 integer overflow.
4036 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4037 printmax_t, where ptrdiff_t is wide enough.
4038 (Finternal_char_font):
4039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4040 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4041 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4042 (Fset_frame_position, x_set_frame_parameters)
4043 (x_set_line_spacing, x_set_border_width)
4044 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4045 Check that fixnums are in proper range for system types.
4046 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4048 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4049 Use SAFE_ALLOCA_LISP, not alloca.
4050 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4051 intptr_t is wide enough.
4052 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4053 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4054 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4055 Check for fixnum out of range.
4056 * ftfont.c (ftfont_list): Don't assume index fits in int.
4057 Check that fixnums are in proper range for system types.
4058 (ftfont_shape_by_flt):
4059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4060 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4062 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4063 Check that fixnums are in proper range for system types.
4064 * gnutls.h: Adjust decls to match defn changes elsewhere.
4065 * gtkutil.c (xg_dialog_run):
4066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4067 (update_frame_tool_bar):
4068 Check that fixnums are in proper range for system types.
4069 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4070 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4071 * indent.c (last_known_column, last_known_column_point):
4072 (current_column_bol_cache):
4073 (skip_invisible, current_column, check_display_width):
4074 (check_display_width, scan_for_column, current_column_1)
4075 (Findent_to, Fcurrent_indentation, position_indentation)
4076 (indented_beyond_p, Fmove_to_column, compute_motion):
4077 (Fcompute_motion, Fvertical_motion):
4078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4079 (last_known_column_modified): Use EMACS_INT, not int.
4080 (check_display_width):
4081 (Fcompute_motion):
4082 Check that fixnums and floats are in proper range for system types.
4083 (compute_motion): Don't assume index or fixnum fits in int.
4084 (compute_motion, Fcompute_motion):
4085 Use int, not EMACS_INT, when it is wide enough.
4086 (vmotion): Omit local var start_hpos that is always 0; that way
4087 we don't need to worry about overflow in expressions involving it.
4088 * indent.h: Adjust decls to match defn changes elsewhere.
4089 (struct position):
4090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4091 Use int, not EMACS_INT, where int is wide enough.
4092 Remove unused members ovstring_chars_done and tab_offset;
4093 all uses removed.
4094 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4095 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4096 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4097 (make_gap, copy_text, insert, insert_and_inherit)
4098 (insert_before_markers, insert_before_markers_and_inherit)
4099 (insert_1, count_combining_before, count_combining_after)
4100 (insert_1_both, insert_from_string)
4101 (insert_from_string_before_markers, insert_from_string_1)
4102 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4103 (adjust_after_replace, adjust_after_insert, replace_range)
4104 (replace_range_2, del_range, del_range_1, del_range_byte)
4105 (del_range_both, del_range_2, modify_region)
4106 (prepare_to_modify_buffer, signal_before_change)
4107 (signal_after_change, Fcombine_after_change_execute):
4108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4109 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4110 (balance_an_interval, split_interval_right, split_interval_left)
4111 (find_interval, next_interval, update_interval)
4112 (adjust_intervals_for_insertion, delete_node, delete_interval)
4113 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4114 (static_offset_intervals, offset_intervals)
4115 (merge_interval_right, merge_interval_left, make_new_interval)
4116 (graft_intervals_into_buffer, temp_set_point_both)
4117 (temp_set_point, set_point, adjust_for_invis_intang)
4118 (set_point_both, move_if_not_intangible, get_property_and_range)
4119 (get_local_map, copy_intervals, copy_intervals_to_string)
4120 (compare_string_intervals, set_intervals_multibyte_1):
4121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4122 * intervals.h: Adjust decls to match defn changes elsewhere.
4123 (struct interval):
4124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4125 * keyboard.c (this_command_key_count, this_single_command_key_start)
4126 (before_command_key_count, before_command_echo_length, echo_now)
4127 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4128 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4129 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4130 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4132 (last_non_minibuf_size, last_point_position, echo_truncate)
4133 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4134 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4135 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4136 (stuff_buffered_input):
4137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4138 (last_auto_save, command_loop_1, read_char):
4139 Use EMACS_INT, not int, to avoid integer overflow.
4140 (record_char): Avoid overflow in total_keys computation.
4141 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4142 * keyboard.h: Adjust decls to match defn changes elsewhere.
4143 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4144 (Fkey_description, Fdescribe_vector, Flookup_key):
4145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4146 (click_position): New function, to check that positions are in range.
4147 (Fcurrent_active_maps):
4148 (describe_command):
4149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4150 (Faccessible_keymaps, Fkey_description):
4151 (preferred_sequence_p):
4152 Don't assume fixnum can fit into int.
4153 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4154 Check for integer overflow in size calculations.
4155 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4156 avoid mishandling large integers.
4157 * lisp.h: Adjust decls to match defn changes elsewhere.
4158 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4159 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4160 (struct Lisp_Marker):
4161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4162 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4163 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4164 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4165 All callers changed.
4166 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4167 Assume the arg has valid form, since it always does.
4168 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4169 unsigned integer system type.
4170 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4171 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4174 (duration_to_sec_usec): New decl.
4175 * lread.c (read_from_string_index, read_from_string_index_byte)
4176 (read_from_string_limit, readchar, unreadchar, openp)
4177 (read_internal_start, read1, oblookup):
4178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4179 (Fload, readevalloop, Feval_buffer, Feval_region):
4180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4181 (openp): Check for out-of-range argument to 'access'.
4182 (read1): Use int, not EMACS_INT, where int is wide enough.
4183 Don't assume fixnum fits into int.
6efdadfd 4184 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4185 (read_filtered_event): Use duration_to_sec_usec
4186 to do proper overflow checking on durations.
d311d28c
PE
4187 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4188 in size calculation.
4189 (Fexecute_kbd_macro):
4190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4191 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4192 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4193 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4194 (set_marker_both, set_marker_restricted_both, marker_position)
4195 (marker_byte_position, Fbuffer_has_markers_at):
4196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4197 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4198 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4199 It now merely ensures that the menu is large enough, without
4200 necessarily growing it, as this avoids some integer overflow issues.
4201 All callers changed.
4202 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4204 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4205 Use SAFE_ALLOCA_LISP, not alloca.
4206 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4207 to EMACS_INT. Check that fixnums are in proper range for system types.
4208 * minibuf.c (minibuf_prompt_width, string_to_object)
4209 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4210 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4212 (get_minibuffer, read_minibuf_unwind):
4213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4214 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4215 this simplifies overflow checking. All callers changed.
4216 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4217 (Ftest_completion):
4218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4219 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4220 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4221 Check that fixnums are in proper range for system types.
4222 (Fx_create_frame, Fx_show_tip):
4223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4224 * nsfont.m (ns_findfonts, nsfont_list_family):
4225 Don't assume fixnum fits in long.
4226 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4228 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4229 wide enough.
17fdb222 4230 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4232 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4233 (PRINTDECLARE, PRINTPREPARE):
4234 (strout, print_string):
4235 (print, print_preprocess, print_check_string_charset_prop)
4236 (print_object):
4237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4238 (PRINTDECLARE):
4239 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4241 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4242 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4243 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4244 (print_error_message): Use SAFE_ALLOCA, not alloca.
4245 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4246 (print_depth, new_backquote_output, print_number_index):
4247 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4248 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4249 (Fset_process_window_size, Fformat_network_address)
4250 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4251 (sigchld_handler):
d311d28c 4252 Check that fixnums are in proper range for system types.
d44287d4 4253 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4254 Check for process-ids out of pid_t range rather than relying on
4255 undefined behavior.
e4d81efc 4256 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4257 (Fformat_network_address, read_process_output, send_process)
4258 (Fprocess_send_region, status_notify):
4259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4260 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4261 (wait_reading_process_output, read_process_output, exec_sentinel):
4262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4263 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4264 (Faccept_process_output): Use duration_to_sec_usec to do proper
4265 overflow checking on durations.
dde14581
PE
4266 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4267 Don't assume pid_t fits in int.
02481186
PE
4268 * process.h (struct Lisp_Process): Members tick and update_tick
4269 are now of type EMACS_INT, not int.
b62b53e8
PE
4270 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4271 configured --with-wide-int.
d311d28c
PE
4272 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4273 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4274 * search.c (looking_at_1, string_match_1):
4275 (fast_string_match, fast_c_string_match_ignore_case)
4276 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4277 (scan_newline, find_before_next_newline, search_command)
4278 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4279 (set_search_regs, wordify):
4280 (Freplace_match):
4281 (Fmatch_data):
4282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4283 (string_match_1, search_buffer, set_search_regs):
4284 (Fmatch_data):
4285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4286 (wordify): Check for overflow in size calculation.
4287 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4288 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4289 Check that fixnums are in proper range for system types.
4290 * sound.c (struct sound_device)
4291 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4293 (Fplay_sound_internal):
4294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4295 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4296 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4297 (Fparse_partial_sexp):
4298 Don't assume fixnums can fit in int.
4299 (struct lisp_parse_state, find_start_pos, find_start_value)
4300 (find_start_value_byte, find_start_begv)
4301 (update_syntax_table, char_quoted, dec_bytepos)
4302 (find_defun_start, prev_char_comend_first, back_comment):
4303 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4304 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4306 (Finternal_describe_syntax_value): Check that match_lisp is a
4307 character, not an integer, since the code stuffs it into int.
4308 (scan_words, scan_sexps_forward):
4309 Check that fixnums are in proper range for system types.
4310 (Fforward_word):
4311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4312 (scan_sexps_forward):
4313 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4314 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4315 * syntax.h: Adjust decls to match defn changes elsewhere.
4316 (struct gl_state_s):
4317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4318 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4319 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4320 * sysdep.c (wait_for_termination_1, wait_for_termination)
4321 (interruptible_wait_for_termination, mkdir):
4322 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4323 (emacs_read, emacs_write):
4324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4325 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4326 and double all fit in int.
d311d28c
PE
4327 * term.c (set_tty_color_mode):
4328 Check that fixnums are in proper range for system types.
4329 * termhooks.h (struct input_event):
4330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4331 * textprop.c (validate_interval_range, interval_of)
4332 (Fadd_text_properties, set_text_properties_1)
4333 (Fremove_text_properties, Fremove_list_of_text_properties)
4334 (Ftext_property_any, Ftext_property_not_all)
4335 (copy_text_properties, text_property_list, extend_property_ranges)
4336 (verify_interval_modification):
4337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4338 (Fnext_single_char_property_change)
4339 (Fprevious_single_char_property_change):
4340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4341 (copy_text_properties):
4342 Check for integer overflow in index calculation.
d311d28c
PE
4343 * undo.c (last_boundary_position, record_point, record_insert)
4344 (record_delete, record_marker_adjustment, record_change)
4345 (record_property_change):
4346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4347 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4349 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4350 (Fx_hide_tip, Fx_file_dialog):
4351 * w32menu.c (set_frame_menubar):
4352 Use ptrdiff_t, not int, for consistency with rest of code.
4353 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4354 (select_window, Fdelete_other_windows_internal)
4355 (window_scroll_pixel_based, window_scroll_line_based)
4356 (Frecenter, Fset_window_configuration):
4357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4358 (Fset_window_hscroll, run_window_configuration_change_hook)
4359 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4360 (Fscroll_other_window, Frecenter):
d311d28c
PE
4361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4362 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4363 Don't assume fixnum fits in int.
4364 (Fset_window_scroll_bars):
4365 Check that fixnums are in proper range for system types.
4366 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4367 (string_pos, c_string_pos, number_of_chars, init_iterator)
4368 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4369 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4370 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4371 (face_before_or_after_it_pos, handle_invisible_prop)
4372 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4373 (display_prop_intangible_p, string_buffer_position_lim)
4374 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4375 (get_overlay_strings_1, get_overlay_strings)
4376 (iterate_out_of_display_property, forward_to_next_line_start)
4377 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4378 (get_next_display_element, set_iterator_to_next)
4379 (get_visually_first_element, compute_stop_pos_backwards)
4380 (handle_stop_backwards, next_element_from_buffer)
4381 (move_it_in_display_line_to, move_it_in_display_line)
4382 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4383 (add_to_log, message_dolog, message_log_check_duplicate)
4384 (message2, message2_nolog, message3, message3_nolog
4385 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4386 (current_message_1, truncate_echo_area, truncate_message_1)
4387 (set_message, set_message_1, store_mode_line_noprop)
4388 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4389 (text_outside_line_unchanged_p, check_point_in_composition)
4390 (reconsider_clip_changes)
4391 (redisplay_internal, set_cursor_from_row, try_scrolling)
4392 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4393 (redisplay_window, find_last_unchanged_at_beg_row)
4394 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4395 (trailing_whitespace_p, find_row_edges, display_line)
4396 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4397 (display_mode_element, store_mode_line_string)
4398 (pint2str, pint2hrstr, decode_mode_spec)
4399 (display_count_lines, display_string, draw_glyphs)
4400 (x_produce_glyphs, x_insert_glyphs)
4401 (rows_from_pos_range, mouse_face_from_buffer_pos)
4402 (fast_find_string_pos, mouse_face_from_string_pos)
4403 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4405 (safe_call, init_from_display_pos, handle_fontified_prop)
4406 (handle_single_display_spec, load_overlay_strings)
4407 (with_echo_area_buffer, setup_echo_area_for_printing)
4408 (display_echo_area, echo_area_display)
4409 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4410 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4411 (redisplay_window, dump_glyph_row, display_mode_line)
4412 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4413 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4415 (handle_single_display_spec, build_desired_tool_bar_string)
4416 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4417 (get_specified_cursor_type):
4418 Check that fixnums are in proper range for system types.
4419 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4420 (Flookup_image_map):
4421 Don't assume fixnums fit in int.
4422 (compare_overlay_entries):
4423 Avoid mishandling comparisons due to subtraction overflow.
4424 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4425 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4426 (handle_tool_bar_click):
4427 Use int, not unsigned, since we prefer signed and the signedness
4428 doesn't matter here.
4429 (get_next_display_element, next_element_from_display_vector):
4430 Use int, not EMACS_INT, when int is wide enough.
4431 (start_hourglass): Use duration_to_sec_usec to do proper
4432 overflow checking on durations.
4433 * xfaces.c (Fbitmap_spec_p):
4434 Check that fixnums are in proper range for system types.
4435 (compare_fonts_by_sort_order):
4436 Avoid mishandling comparisons due to subtraction overflow.
4437 (Fx_family_fonts, realize_basic_faces):
4438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4439 (Fx_family_fonts):
4440 Don't assume fixnum fits in int.
4441 Use SAFE_ALLOCA_LISP, not alloca.
4442 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4443 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4444 (face_at_buffer_position, face_for_overlay_string)
4445 (face_at_string_position):
4446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4447 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4448 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4449 (Fx_show_tip):
4450 Check that fixnums are in proper range for system types.
4451 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4452 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4454 (Fx_change_window_property): Don't assume fixnums fit in int.
4455 * xfont.c (xfont_chars_supported):
4456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4457 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4458 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4460 * xml.c (parse_region):
4461 * xrdb.c (magic_file_p):
4462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4463 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4464 (x_get_local_selection, x_reply_selection_request)
4465 (x_handle_selection_request, wait_for_property_change):
4466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4467 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4468 short is wide enough.
4469 (x_send_client_event): Don't assume fixnum fits in int.
4470 * xterm.c (x_x_to_emacs_modifiers):
4471 Don't assume EMACS_INT overflows nicely into int.
4472 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4473 may come from Lisp.
4474 (handle_one_xevent): NATNUMP can eval its arg twice.
4475 (x_connection_closed):
4476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4477 * xterm.h: Adjust decls to match defn changes elsewhere.
4478 (struct scroll_bar): Use struct vectorlike_header
4479 rather than rolling our own approximation.
4480 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4481
c6574eb5
GM
44822012-05-25 Glenn Morris <rgm@gnu.org>
4483
4484 * lisp.mk (lisp): Update for more files being compiled now.
4485
e8d32c7e
SM
44862012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4487
48def666
SM
4488 * lread.c: Remove `read_pure' which makes no difference.
4489 (read_pure): Remove var.
4490 (unreadpure): Remove function.
4491 (readevalloop): Don't call read_list with -1 flag.
4492 (read1, read_vector): Don't test read_pure any more.
4493 (read_list): Simplify.
4494
e8d32c7e
SM
4495 * fileio.c, character.h: Minor style tweaks.
4496
4b2addb7
DA
44972012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4498
4499 * window.h (clip_changed): Remove useless declaration.
4500
584461b2
JB
45012012-05-22 Juanma Barranquero <lekktu@gmail.com>
4502
4503 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4504 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4505
34374650
PE
45062012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4507
4508 Remove src/m/*.
4509 This directory predates autoconf and is no longer needed nowadays.
4510 Move its few remaining bits of functionality to where they're needed.
4511 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4512 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4513 * m/template.h: Remove.
4514 * Makefile.in (M_FILE): Remove. All uses removed.
4515 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4516 * lisp.h (USE_LSB_TAG):
4517 * mem-limits.h (EXCEEDS_LISP_PTR):
4518 Use VAL_MAX, not VALBITS, in #if.
4519 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4520 (EMACS_UINT): Define unconditionally now.
4521 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4522 (BITS_PER_EMACS_INT): New constants, replacing
4523 what used to be in config.h, but not useful in #if.
4524 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4525 define them any more.
4526 (VAL_MAX): New macro.
4527 (VALMASK): Use it.
4528 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4529 BITS_PER_EMACS_INT, in #if.
4530 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4531 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4532 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4533 * s/ms-w32.h (DATA_START):
4534 Move here from removed file m/intel386.h.
4535 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4536 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4537
261cb4bb
PE
45382012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 Assume C89 or later.
4541 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4542 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4543 (xrealloc):
4544 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4545 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4546 * textprop.c, tparam.c (NULL): Remove.
4547 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4548 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4549 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4550 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4551 * xterm.c (input_signal_count): Assume volatile works.
4552
ff23cd9f
KB
45532012-05-21 Ken Brown <kbrown@cornell.edu>
4554
4555 * xgselect.c (xg_select): Fix first argument in call to 'select'
4556 (bug#11508).
4557
1b170bc6
KB
45582012-05-20 Ken Brown <kbrown@cornell.edu>
4559
4560 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4561 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4562
b2f4d39f
KB
45632012-05-19 Ken Brown <kbrown@cornell.edu>
4564
4565 * xfns.c (x_in_use): Remove `static' qualifier.
4566 * xterm.h (x_in_use): Declare.
4567 * xgselect.c: Include xterm.h.
4568 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4569 and `display_arg' (bug#9754).
4570
003fdae2
PE
45712012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4572
9232a6d9
PE
4573 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4574
003fdae2
PE
4575 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4576 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4577
784b56e2
EZ
45782012-05-18 Eli Zaretskii <eliz@gnu.org>
4579
4580 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4581
4582 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4583 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4584
4585 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4586 reference to image_cache->refcount.
4587 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4588
a0a79cde
JL
45892012-05-17 Juri Linkov <juri@jurta.org>
4590
4591 * search.c (Fword_search_regexp, Fword_search_backward)
4592 (Fword_search_forward, Fword_search_backward_lax)
4593 (Fword_search_forward_lax): Move functions to isearch.el
4594 (bug#10145, bug#11381).
4595
b0572523
PE
45962012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4597
4598 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4599
9660f5fc
SM
46002012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4601
4602 * lread.c (init_obarray): Declare Qt and Qnil as special.
4603
4374de83
GM
46042012-05-14 Glenn Morris <rgm@gnu.org>
4605
4606 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4607 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4608
dc44c39a
PE
46092012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4610
078c97cb
PE
4611 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4612
dc44c39a
PE
4613 * unexaix.c: Port to more-recent AIX compilers.
4614 (report_error, report_error_1, make_hdr, copy_sym)
4615 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4616 Make arguments const char *, not char *, to avoid violations of C
4617 standard and to fix some AIX warnings reported by Gilles Pion.
4618
e18afed7 46192012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4620
4621 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4622 already have overlays loaded.
4623 (handle_single_display_spec): Before returning without displaying
4624 fringe bitmap, synchronize the bidi iterator with the main display
4625 iterator, by calling iterate_out_of_display_property.
4626 (iterate_out_of_display_property): Detect buffer iteration by
4627 testing that it->string is a Lisp string.
4628 (get_next_display_element): When the current object is exhausted,
4629 and there's something on it->stack, call set_iterator_to_next to
4630 proceed with what's on the stack, instead of returning zero.
4631 (set_iterator_to_next): If called at the end of a Lisp string,
4632 proceed to consider_string_end without incrementing string
4633 position. Don't increment display vector index past the end of
4634 the display vector. (Bug#11417)
c8fb9dc6
EZ
4635 (pos_visible_p): Don't report a position visible when move_it_to
4636 stopped at the last line of window, which happens to be scanned
4637 backwards by the bidi iteration. (Bug#11464)
ac268e67 4638
e18afed7 46392012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4640
4641 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4642 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4643 are on a TTY, and thus unable to display on the fringes.
4644 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4645 so we need to signal to the caller that this is a "replacing"
4646 display spec. This fixes display when the spec is invalid or we
4647 are on a TTY.
4648
e18afed7 46492012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4650
4651 * unexaix.c (make_hdr): Fix typo in prototype.
4652 This bug broke the build on AIX. Problem reported by Gilles Pion.
4653
9d0a235a
MA
46542012-05-14 Michael Albinus <michael.albinus@gmx.de>
4655
4656 * keyboard.c (kbd_buffer_get_event): Read special events also in
4657 batch mode. (Bug#11415)
4658
9e6b06ed
GM
46592012-05-12 Glenn Morris <rgm@gnu.org>
4660
4661 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4662
c1a1d7a3
EZ
46632012-05-12 Eli Zaretskii <eliz@gnu.org>
4664
4665 * lisp.mk (lisp): Add newcomment.elc.
4666
3fe7cdc8
GM
46672012-05-12 Glenn Morris <rgm@gnu.org>
4668
4669 * Makefile.in (MKDIR_P): New, set by configure.
4670 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4671
53f7d2c0
PE
46722012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4673
4674 Remove unused function hourglass_started.
4675 * dispextern.h (hourglass_started):
4676 * w32fns.c (hourglass_started):
4677 * xdisp.c (hourglass_started): Remove.
4678
75aafb17
JB
46792012-05-10 Juanma Barranquero <lekktu@gmail.com>
4680
4681 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4682 Update dependencies.
4683
12959e8e
PE
46842012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4685
97107e2e
PE
4686 * xgselect.c (xg_select): Put maxfds+1 into a var.
4687 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4688
12959e8e
PE
4689 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4690
836d29b3
DA
46912012-05-10 Dave Abrahams <dave@boostpro.com>
4692
4693 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4694 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4695
5cb67954
MA
46962012-05-09 Michael Albinus <michael.albinus@gmx.de>
4697
4698 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4699 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4700 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4701 Initialize xd_registered_buses.
4702
3478ec45
PE
47032012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4704
b263a6b0
PE
4705 Untag more efficiently if USE_LSB_TAG.
4706 This is based on a proposal by YAMAMOTO Mitsuharu in
4707 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4708 For an admittedly artificial (nth 8000 longlist) benchmark on
4709 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4710 Emacs's overall text size by 1%.
4711 * lisp.h (XUNTAG): New macro.
4712 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4713 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4714 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4715 * eval.c (Fautoload):
4716 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4717 * frame.h (XFRAME): Use XUNTAG.
4718
3478ec45
PE
4719 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4720 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4721 Remove unportable assumptions about print widths of types like
4722 dbus_uint32_t.
4723 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4724 intptr_t when converting between pointer and integer, to avoid GCC
4725 warnings about wrong width.
4726
666b903b 47272012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4728
4729 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4730 stack for each reader_thread, instead of defaulting to 8MB
4731 determined by the linker. This avoids failures in creating
4732 subprocesses on Windows 7, see the discussion in this thread:
4733 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4734
b120cc17
JC
47352012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4736
4737 Fix up display of the *Minibuf-0* buffer in the mini window.
4738 * keyboard.c (read_char): Don't clear the echo area if there's no
4739 message to clear.
4740 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4741 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4742
9a4b36f8
MA
47432012-05-07 Michael Albinus <michael.albinus@gmx.de>
4744
4745 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4746 batch mode.
4747
e5f9458f
CY
47482012-05-06 Chong Yidong <cyd@gnu.org>
4749
4750 * lisp.mk (lisp): Update.
4751
eceeb5fc 47522012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4753
4754 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4755
71873e2b
SM
47562012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4757
4758 * data.c (PUT_ERROR): New macro.
4759 (syms_of_data): Use it. Add new error type `user-error'.
4760 * undo.c (user_error): New function.
4761 (Fprimitive_undo): Use it.
4762 * print.c (print_error_message): Adjust print style for `user-error'.
4763 * keyboard.c (user_error): New function.
4764 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4765
ab0fa4e4
PE
47662012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4767
4768 Do not limit current-time-string to years 1000..9999.
4769 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4770 (Fcurrent_time_string): Support any year that is supported by the
4771 underlying localtime representation. Don't use asctime, as it
4772 has undefined behavior for years outside the range -999..9999.
4773
7ed806a7
PE
47742012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4775
4776 Fix race conditions involving setenv, gmtime, localtime, asctime.
4777 Without this fix, interrupts could mess up code that uses these
4778 nonreentrant functions, since setting TZ invalidates existing
4779 tm_zone or tzname values, and since most of these functions return
4780 pointers to static storage.
4781 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4782 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4783 Grow the critical sections to include not just invoking
4784 localtime/gmtime, but also accessing these functions' results
4785 including their tm_zone values if any, and any related TZ setting.
4786 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4787 so that the struct tm is saved in the critical section.
4788 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4789 motivated by the fact that memory allocation needs to be outside
4790 the critical section.
4791
0c16dfed
DA
47922012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4793
4794 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4795 with RESET_INTERVAL.
4796
4797 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4798 Remove duplicated buffer name initialization.
4799
3f83ace8
JM
48002012-05-02 Jim Meyering <jim@meyering.net>
4801
4802 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4803
c7b8541e
JM
4804 * xfns.c (x_window): Use xstrdup (Bug#11375).
4805
90207a15 48062012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4807
4808 * xdisp.c (pos_visible_p): If already at a newline from the
4809 display string before the 'while' loop, don't walk back the glyphs
4810 from it3.glyph_row. Solves assertion violation when the display
4811 string begins with a newline (egg.el). (Bug#11367)
4812
b593d6a9
AH
48132012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4814
4815 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4816 Move to simple.el.
4817
4737362e
GM
48182012-05-01 Glenn Morris <rgm@gnu.org>
4819
99cf43f9
GM
4820 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4821 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4822 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4823 All were removed before 23.1.
4824
9311dcff
GM
4825 * dispnew.c: Remove HAVE_LIBNCURSES test;
4826 it is always true on relevant platforms.
4827
4d5c6349
GM
4828 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4829 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4830
4737362e
GM
4831 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4832
74dd3a6b
AS
48332012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4834
4835 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4836 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4837 Remove.
4838
13c379ee
PE
48392012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4840
4841 Do not avoid creating empty evaporating overlays (Bug#9642).
4842 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4843 That is, do not delete an evaporating overlay if it becomes
4844 empty after its bounds are adjusted to fit within its buffer.
4845 This fix caused other problems, and I'm reverting it until we get
4846 to the bottom of them.
4847
a8e7d6d7 48482012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4849
4850 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4851
a8e7d6d7 48522012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4853
4854 * xdisp.c (pos_visible_p): If the window start position is beyond
4855 ZV, start the display from buffer beginning. Prevents assertion
4856 violation in init_iterator when the minibuffer window is scrolled
4857 via the scroll bar.
4858
4859 * window.c (window_scroll_pixel_based): Likewise.
4860
a8e7d6d7 48612012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4862
4863 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4864
a8e7d6d7 48652012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4866
4867 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4868 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4869
a8e7d6d7 48702012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4871
b593d6a9
AH
4872 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4873 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4874
1c6900d9
EZ
48752012-04-26 Eli Zaretskii <eliz@gnu.org>
4876
4c3fa1d9
EZ
4877 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4878 display element, check also the underlying string or buffer
4879 character. (Bug#11341)
4880
1c6900d9
EZ
4881 * w32menu.c: Include w32heap.h.
4882 (add_menu_item): If the call to AppendMenuW (via
4883 unicode_append_menu) fails, disable Unicode menus only if we are
4884 running on Windows 9X/Me.
4885
42bf8205
AS
48862012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4887
4888 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4889 (xgetint): Add missing shift for LSB tags.
4890
b1bac16e
MR
48912012-04-24 Martin Rudalics <rudalics@gmx.at>
4892
4893 * keyboard.c (read_char): Don't wipe echo area for select window
4894 events: These might get delayed via `mouse-autoselect-window'
4895 (Bug#11304).
4896
d69621cc
JB
48972012-04-24 Juanma Barranquero <lekktu@gmail.com>
4898
4899 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4900 manipulation of :loaded-from data.
4901
02fd101b
JB
49022012-04-23 Juanma Barranquero <lekktu@gmail.com>
4903
4904 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4905 now a cons (bug#11311).
4906
888bec30
PE
49072012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4908
89a438bd
PE
4909 Do not create empty overlays with the evaporate property (Bug#9642).
4910 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4911 if it becomes empty after its bounds are adjusted to fit within
4912 its buffer. Without this fix, in a nonempty buffer (let ((o
4913 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4914 yields an empty overlay that has the evaporate property, which is
4915 not supposed to happen.
4916
1068fe4d
PE
4917 Fix minor GTK3 problems found by static checking.
4918 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4919 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4920 (struct _EmacsFixedClass, emacs_fixed_get_type):
4921 Move decls here from emacsgtkfixed.h, since they needn't be public.
4922 (emacs_fixed_get_type): Now static.
4923 (emacs_fixed_class_init): Omit unused local.
4924 (emacs_fixed_child_type): Remove; unused.
4925 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4926 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4927 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4928 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4929 (EMACS_FIXED_GET_CLASS): Remove; unused.
4930 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4931
888bec30
PE
4932 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4933 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4934
de85e130
PE
49352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4936
d0baac98 4937 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4938 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4939 (__malloc_size_t, __malloc_ptrdiff_t):
4940 Remove. All uses removed, replaced by the definiens if needed,
4941 since we can assume C89 or better now.
4942 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4943 (protect_malloc_state, align, get_contiguous_space)
4944 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4945 (malloc_atfork_handler_child, malloc_enable_thread)
4946 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4947 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4948 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4949 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4950 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4951 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4952 Define using prototypes, not old style.
4953 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4954 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4955 (align): Don't assume that signed integer overflow wraps around.
4956 Omit unused local var.
4957 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4958 (_free_internal_nolock, memalign, mallochook, reallochook):
4959 Omit no-longer-needed casts.
4960 (valloc): Use getpagesize, not __getpagesize.
4961 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4962 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4963
de85e130
PE
4964 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4965
dcbf5805
MA
49662012-04-22 Michael Albinus <michael.albinus@gmx.de>
4967
4968 Move functions from C to Lisp. Make non-blocking method calls
4969 the default. Implement further D-Bus standard interfaces.
4970
4971 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4972 (QCdbus_request_name_allow_replacement)
4973 (QCdbus_request_name_replace_existing)
4974 (QCdbus_request_name_do_not_queue)
4975 (QCdbus_request_name_reply_primary_owner)
4976 (QCdbus_request_name_reply_in_queue)
4977 (QCdbus_request_name_reply_exists)
4978 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4979 (QCdbus_registered_serial, QCdbus_registered_method)
4980 (QCdbus_registered_signal): New Lisp objects.
4981 (XD_DEBUG_MESSAGE): Use sizeof.
4982 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4983 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4984 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4985 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4986 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4987 (xd_signature, xd_append_arg): Allow float for integer types.
4988 (xd_get_connection_references): New function.
b593d6a9
AH
4989 (xd_get_connection_address): Rename from xd_initialize.
4990 Return cached address.
dcbf5805
MA
4991 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4992 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4993 level.
4994 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4995 Return number of refcounts.
dcbf5805
MA
4996 (Fdbus_get_unique_name): Make stronger parameter check.
4997 (Fdbus_message_internal): New defun.
4998 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4999 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5000 (Fdbus_send_signal, Fdbus_register_service)
5001 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5002 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5003 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5004 (Vdbus_compiled_version, Vdbus_runtime_version)
5005 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5006 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5007 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5008 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5009 Adapt docstring.
dcbf5805 5010
52828e02
PE
50112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5012
da05bc4c
PE
5013 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5014 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5015 Do not assume ptrdiff_t is the same width as 'int'.
5016
52828e02
PE
5017 * alloc.c: Handle unusual debugging option combinations.
5018 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5019 since the two debugging options are incompatible.
5020 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5021 is defined.
5022 (mem_init, mem_insert, mem_insert_fixup):
5023 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5024 (NEED_MEM_INSERT): Remove; no longer needed.
5025
f01769f9
LL
50262012-04-22 Leo Liu <sdl.web@gmail.com>
5027
5028 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5029
5790543d
PE
50302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5031
5032 * sysdep.c [__FreeBSD__]: Minor cleanups.
5033 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5034 Use Emacs indenting style more consistently. Avoid some casts.
5035 Use 'double' consistently rather than mixing 'float' and 'double'.
5036
b91b7e4d
EW
50372012-04-21 Eduard Wiebe <usenet@pusto.de>
5038
b593d6a9
AH
5039 * sysdep.c (list_system_processes, system_process_attributes):
5040 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5041
6114eb15
AS
50422012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5043
5044 * lisp.mk (lisp): Update.
5045
2f38dff7
PE
50462012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5047
5048 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5049 It is never used otherwise.
5050
4ae29f89
SM
50512012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5052
5053 * print.c (print_preprocess): Only check print_depth if print-circle
5054 is nil.
5055 (print_object): Check for cycles even when print-circle is nil and
5056 print-gensym is t, but only check print_depth if print-circle is nil.
5057
f30d612a
CY
50582012-04-20 Chong Yidong <cyd@gnu.org>
5059
5060 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5061 set the status to "failed" and ensure that sentinel is run.
5062
c07a4c0b 50632012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5064
5065 * process.c (Fset_process_inherit_coding_system_flag)
5066 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5067 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5068
c07a4c0b 50692012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5070
5071 * xdisp.c (string_buffer_position_lim): Limit starting position to
5072 BEGV.
5073 (set_cursor_from_row): If called for a mode-line or header-line
5074 row, return zero immediately.
5075 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5076 farther than the first row after the header line, if any.
5077 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5078 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5079
c07a4c0b 50802012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5081
4ae29f89
SM
5082 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5083 (bug#11238).
ad3a2b41 5084
c07a4c0b 50852012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 50862012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5087
5088 configure: new option --enable-gcc-warnings (Bug#11207)
5089 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5090 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5091 (ALL_CFLAGS): Use new macros rather than old.
5092 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5093 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5094 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5095 -Wunused-result, -Wunused-variable. This should go away once
5096 the Emacs and Gnulib regex code is merged.
5097 (xmalloc, xrealloc): Now static.
5098
aba027e8
PE
50992012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 * dired.c (Fsystem_groups): Remove unused local.
5102
e5a36063
GM
51032012-04-17 Glenn Morris <rgm@gnu.org>
5104
5105 * dired.c (Fsystem_users): Doc fix.
5106
316411f0
DA
51072012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5108
5109 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5110 (syms_of_dired): Add them.
5111
9426aba4
PE
51122012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5113
b62a57be
PE
5114 Fix minor alloc.c problems found by static checking.
5115 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5116 New extern decls, to avoid calling undeclared functions.
5117 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5118 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5119 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5120 (NEED_MEM_INSERT): New macro.
5121 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5122 Remove one incorrect comment and fix another.
b62a57be 5123
3539f31f
PE
5124 Fix minor ralloc.c problems found by static checking.
5125 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5126 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5127 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5128 (r_alloc_sbrk): Now static.
5129
a041960a
PE
5130 Improve ralloc.c interface checking.
5131 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5132 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5133 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5134 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5135 [REL_ALLOC]: ... to here, to check interface.
5136 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5137 Remove decls. This fixes an "It stinks!".
5138
9426aba4
PE
5139 * alloc.c (which_symbols): Fix alignment issue / type clash.
5140
d55c12ed
AS
51412012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5142
5143 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5144 (struct Lisp_Misc_Any): Likewise.
5145 (struct Lisp_Free): Likewise.
5146 * alloc.c (union aligned_Lisp_Symbol): Define.
5147 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5148 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5149 (union aligned_Lisp_Misc): Define.
5150 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5151 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5152 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5153
b948ce8b
PE
51542012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5155
5156 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5157 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5158 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5159 * s/netbsd.h, s/sol2-6.h:
5160 Remove definition of GC_MARK_STACK, since the default now works.
5161 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5162 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5163 no longer the default.
5164 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5165
35dc09a1 51662012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5167
35dc09a1
GM
5168 * lread.c (lisp_file_lexically_bound_p):
5169 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5170
35dc09a1
GM
51712012-04-14 Eli Zaretskii <eliz@gnu.org>
5172
5173 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5174 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5175
51762012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5177
5178 * nsterm.m (constrainFrameRect): Always constrain when there is only
5179 one screen (Bug#10962).
5180
bcd86815
KB
51812012-04-13 Ken Brown <kbrown@cornell.edu>
5182
5183 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5184
c25df26e
RT
51852012-04-13 Reuben Thomas <rrt@sc3d.org>
5186
5187 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5188
0fc59f1e
DC
51892012-04-11 Daniel Colascione <dancol@dancol.org>
5190
5191 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5192 against is gone. It's better to use vfork now so that when Cygwin
5193 gains a new, working vfork, we use it automatically (bug#10398).
5194
de8c03dc
SM
51952012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5196
5197 * window.c (save_window_save): Obey window-point-insertion-type.
5198
2f097256
GM
51992012-04-11 Glenn Morris <rgm@gnu.org>
5200
5201 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5202
453b951e
SM
52032012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5204
5205 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5206
75f1671a 52072012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5208
5209 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5210 (force_quit_count): New var.
5211 (handle_interrupt): Use it.
5212
2a8ce227
JB
52132012-04-10 Juanma Barranquero <lekktu@gmail.com>
5214
5215 * w32.c (w32_delayed_load): Record the full path of the library
5216 being loaded (bug#10424).
5217
935396c0
GM
52182012-04-09 Glenn Morris <rgm@gnu.org>
5219
05920a43
GM
5220 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5221 not just in the obarray, before snarfing them. (Bug#11036)
5222
935396c0
GM
5223 * Makefile.in ($(leimdir)/leim-list.el):
5224 Pass EMACS rather than BUILT_EMACS.
5225
a18ecafa
TZ
52262012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5227
5228 * process.c (make_process):
5229 * process.h: Add integer `gnutls_handshakes_tried' member to
5230 process struct.
5231
6bbef4e5
JC
5232 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5233 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5234
5235 * gnutls.c (gnutls_log_function2i): Convenience log function.
5236 (emacs_gnutls_read): Use new log functions,
5237 `gnutls_handshakes_tried' process member, and
5238 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5239 attempts per process (connection).
5240
b4d3bc10
CY
52412012-04-09 Chong Yidong <cyd@gnu.org>
5242
5243 * eval.c (Fuser_variable_p, user_variable_p_eh)
5244 (lisp_indirect_variable): Functions deleted.
5245 (Fdefvar): Caller changed.
5246
5247 * callint.c (Finteractive, Fcall_interactively):
5248 * minibuf.c (Fread_variable): Callers changed.
5249
70f4d973
EZ
52502012-04-09 Eli Zaretskii <eliz@gnu.org>
5251
5252 * xdisp.c (set_cursor_from_row): If the display string appears in
5253 the buffer at position that is closer to point than the position
5254 after the display string, display the cursor on the first glyph of
5255 the display string. Fixes cursor display when a 'display' text
5256 property immediately follows invisible text. (Bug#11094)
5257
cb3c2e3e
PE
52582012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5259
5260 composite.c: use 'double' consistently
5261 * composite.c (get_composition_id): Use 'double' consistently
5262 instead of converting 'float' to 'double' and vice versa; this is
5263 easier to understand and avoids a GCC warning.
5264
fd06db5d
GM
52652012-04-09 Glenn Morris <rgm@gnu.org>
5266
50fe702a
GM
5267 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5268 preparation for dumping it with emacs. (Bug#4789)
5269 (leimdir): New variable.
5270 ($(leimdir)/leim-list.el): New rule.
5271 (emacs$(EXEEXT)): Depend on leim-list.el.
5272
fd06db5d
GM
5273 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5274 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5275 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5276
55c131ee
AS
52772012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5278
5279 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5280 proper alignment.
5281
9209588f
JB
52822012-04-07 Juanma Barranquero <lekktu@gmail.com>
5283
5284 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5285 Remove unused local variable.
5286
e3fb2efb
PE
52872012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5288
5289 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5290 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5291 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5292 objects, as mark_maybe_pointer will catch them otherwise.
5293 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5294 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5295
b5385551
PE
52962012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 Fix typo that broke non-Windows builds.
5299 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5300
9078ead6
EZ
53012012-04-07 Eli Zaretskii <eliz@gnu.org>
5302
5303 Support building on MS-Windows with libxml2.
5304
5305 * makefile.w32-in (OBJ2): Add xml.$(O).
5306 (GLOBAL_SOURCES): Add xml.c.
5307 ($(BLD)/xml.$(O)): New dependency list.
5308
5309 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5310 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5311 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5312 [!WINDOWSNT]: New macros.
5313 (init_libxml2_functions, libxml2_loaded_p): New functions.
5314 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5315 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5316 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5317 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5318 linked in).
6bbef4e5
JC
5319 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5320 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5321 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5322
5323 * emacs.c: Don't include libxml/parser.h.
5324 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5325 xmlCleanupParser directly.
5326
5327 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5328
3811fdf3
EZ
53292012-04-07 Eli Zaretskii <eliz@gnu.org>
5330
5331 * indent.c (Fvertical_motion): If there is a display string at
5332 point, use it.vpos to compute how many lines to backtrack after
5333 move_it_to point. (Bug#11133)
5334
2f8e16b2
EZ
53352012-04-06 Eli Zaretskii <eliz@gnu.org>
5336
5337 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5338 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5339 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5340 macros related to unification of CJK characters. For the details,
5341 see the discussion following the message here:
5342 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5343
3d439cd1
CY
53442012-04-04 Chong Yidong <cyd@gnu.org>
5345
5346 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5347
8bc53d00
EZ
53482012-04-01 Eli Zaretskii <eliz@gnu.org>
5349
5350 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5351 instead of alloca. (Bug#11138)
5352
3b0512a3
AS
53532012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5354
5355 * w32menu.c (is_simple_dialog): Properly check lisp types.
5356 (Bug#11141)
5357
8427ddd2
EZ
53582012-03-31 Eli Zaretskii <eliz@gnu.org>
5359
979022ef
EZ
5360 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5361 position we get to after a call to move_it_to fails the
5362 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5363 only if we wind up in a string from display property. (Bug#11063)
5364
a6b1c7cc
EZ
5365 * window.c (Fdelete_other_windows_internal): Invalidate the row
5366 and column information about mouse highlight, so that redisplay
5367 restores it after reallocating the glyph matrices. (Bug#7464)
5368
8427ddd2
EZ
5369 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5370 string comes from a `display' text property, use the buffer
5371 position of that property as if we actually saw that position in
5372 the row's glyphs.
697ba24b
EZ
5373 (move_it_by_lines): Remove the assertion that
5374 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5375 violated when there's a before-string at the beginning of a line.
5376 (Bug#11063)
8427ddd2 5377
65a0a738
EZ
53782012-03-30 Eli Zaretskii <eliz@gnu.org>
5379
5380 * xdisp.c (append_space_for_newline): If the default face was
5381 remapped, use the remapped face for the appended newline.
5382 (extend_face_to_end_of_line): Use the remapped default face for
5383 extending the face to the end of the line.
5384 (display_line): Call extend_face_to_end_of_line when the default
5385 face was remapped. (Bug#11068)
5386
581355cc
EZ
53872012-03-29 Eli Zaretskii <eliz@gnu.org>
5388
5389 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5390
e8fc049f
SM
53912012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5392
5393 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5394
4fb9a543
GM
53952012-03-27 Glenn Morris <rgm@gnu.org>
5396
5397 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5398 Doc fixes.
5399
679910f1
KH
54002012-03-26 Kenichi Handa <handa@m17n.org>
5401
5402 * dispextern.h (struct glyph): Fix previous change. Change the
5403 bit length of glyphless.ch to 25 (Bug#11082).
5404
90d49b7f
CY
54052012-03-26 Chong Yidong <cyd@gnu.org>
5406
5407 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5408 (command_loop_1): Use it; inhibit selection update for
5409 handle-select-window too (Bug#8996).
5410
f514f6f0
FP
54112012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5412
e8fc049f 5413 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5414
bf43fa51
KH
54152012-03-25 Kenichi Handa <handa@m17n.org>
5416
5417 * dispextern.h (struct glyph): Change the bit length of
5418 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5419
8a0c01dd
EZ
54202012-03-24 Eli Zaretskii <eliz@gnu.org>
5421
5422 * s/ms-w32.h (tzname): Include time.h before redirecting to
5423 _tzname. Fixes the MSVC build. (Bug#9960)
5424
7d1c3a76
AS
54252012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5426
8ed79523
AS
5427 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5428 characters.
5429
7d1c3a76
AS
5430 * xterm.c (XTread_socket): Only modify handling_signal if
5431 !SYNC_INPUT. (Bug#11080)
5432
e99a9b8b
EZ
54332012-03-23 Eli Zaretskii <eliz@gnu.org>
5434
5435 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5436 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5437 when fetching a multibyte character consumes more bytes than
5438 CHAR_BYTES returns, due to unification of CJK characters in
5439 string_char. (Bug#11073)
5440
5063c0e1
TN
54412012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5442
5443 * process.c (wait_reading_process_output): Handle pty disconnect
5444 by refraining from sending oneself a SIGCHLD (bug#10933).
5445
9f851fbd
CY
54462012-03-22 Chong Yidong <cyd@gnu.org>
5447
5448 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5449
5063c0e1 5450 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5451 Mark string as coming from a prefix property.
5452 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5453 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5454
fb5b8aca
CY
54552012-03-21 Chong Yidong <cyd@gnu.org>
5456
5457 * xfaces.c (Vface_remapping_alist): Doc fix.
5458
62356a1b
EZ
54592012-03-20 Eli Zaretskii <eliz@gnu.org>
5460
5461 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5462 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5463 Doc fixes.
62356a1b 5464
025de85b
CY
54652012-03-20 Chong Yidong <cyd@gnu.org>
5466
5467 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5468 to reflect default non-nil value of redisplay-dont-pause.
5469
4827f94e
KH
54702012-03-19 Kenichi Handa <handa@m17n.org>
5471
5472 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5473 it fit in a valid range (Bug#11003).
5474
e50a24a2
EZ
54752012-03-18 Eli Zaretskii <eliz@gnu.org>
5476
5477 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5478 that is not from display property, accept the row as a "cursor
5479 row" if one of the string's character has a non-nil `cursor'
5480 property. Fixes cursor positioning when there are newlines in
5481 overlay strings, e.g. in icomplete.el. (Bug#11035)
5482
9af5ed87
PE
54832012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5484
5485 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5486
d1f55f16
CY
54872012-03-12 Chong Yidong <cyd@gnu.org>
5488
5489 * eval.c (inhibit_lisp_code): Rename from
5490 inhibit_window_configuration_change_hook; move from window.c.
5491
5492 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5493 * window.c (run_window_configuration_change_hook)
5494 (syms_of_window): Callers changed.
5495
66c5eebd
CY
54962012-03-11 Chong Yidong <cyd@gnu.org>
5497
413df973
CY
5498 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5499
66c5eebd
CY
5500 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5501
1de11f56
CY
55022012-03-10 Chong Yidong <cyd@gnu.org>
5503
5504 * frame.c (other_visible_frames): Don't assume the selected frame
5505 is visible (Bug#10955).
5506
cae07000
SM
55072012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5508
5509 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5510
89c94350
JD
55112012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5512
5513 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5514 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5515 zero (Bug#10954).
5516
999dd333
GM
55172012-03-03 Glenn Morris <rgm@gnu.org>
5518
01a6dcc8 5519 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5520
de0100f2
EZ
55212012-03-02 Eli Zaretskii <eliz@gnu.org>
5522
5523 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5524 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5525 (redisplay_window, next_element_from_string): Fix typos in
5526 comments.
3e441275
EZ
5527 (redisplay_window): Pass to move_it_vertically the margin in
5528 pixels, not in screen lines.
de0100f2 5529
96a72ee9
GM
55302012-03-02 Glenn Morris <rgm@gnu.org>
5531
5532 * buffer.c (buffer-list-update-hook): Doc fix.
5533
312508d7
EZ
55342012-02-29 Eli Zaretskii <eliz@gnu.org>
5535
5536 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5537 push_it before setting up the iterator for the first overlay
5538 string, even if we have an empty string loaded.
5539 (next_overlay_string): If there's an empty string on the iterator
5540 stack, pop the stack. (Bug#10903)
5541
27f3c637
PE
55422012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5543
5544 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5545 Suggested by Stefan Monnier in
5546 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5547 * alloc.c (widen_to_Lisp_Object): New static function.
5548 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5549 and widening them to Lisp_Objects. This would work even if
5550 USE_LSB_TAG is defined and wide integers are used, which might
5551 happen in a future version of Emacs.
5552
3c9dfce6
CY
55532012-02-25 Chong Yidong <cyd@gnu.org>
5554
fa74b241
CY
5555 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5556 Doc fix.
5557
3c9dfce6
CY
5558 * xselect.c (Fx_selection_exists_p): Doc fix.
5559 (x_clipboard_manager_save_all): Print an informative message
5560 before saving to clipboard manager.
5561
9486df08
CY
55622012-02-24 Chong Yidong <cyd@gnu.org>
5563
5564 * keyboard.c (process_special_events): Handle all X selection
5565 requests in kbd_buffer, not just the next one (Bug#8869).
5566
f01d3321
CY
55672012-02-23 Chong Yidong <cyd@gnu.org>
5568
5569 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5570 call when setting menu-bar-lines and tool-bar-lines parameters.
5571 (unwind_create_frame_1): New helper function.
5572
5573 * window.c (inhibit_window_configuration_change_hook): New var.
5574 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5575 (syms_of_window): Initialize it.
f01d3321 5576
86b847b6
CY
55772012-02-22 Chong Yidong <cyd@gnu.org>
5578
5579 * xterm.c (x_draw_image_relief): Add missing type check for
5580 Vtool_bar_button_margin (Bug#10743).
5581
a59225b1
CY
55822012-02-21 Chong Yidong <cyd@gnu.org>
5583
5584 * fileio.c (Vfile_name_handler_alist): Doc fix.
5585
5586 * buffer.c (Fget_file_buffer): Protect against invalid file
5587 handler return value.
5588
310f5bd4
PE
55892012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5590
cb3a28cc
PE
5591 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5592 when computing $valmask.
5593
310f5bd4
PE
5594 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5595 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5596 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5597 It's useless in that case, and it can cause problems on hosts
5598 that allocate halves of EMACS_INT values separately.
5599 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5600 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5601 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5602 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5603 it avoids undefined behavior on hosts where shifting right by more
5604 than the word width has undefined behavior.
5605
2375c96a
CY
56062012-02-19 Chong Yidong <cyd@gnu.org>
5607
5608 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5609 (Funhandled_file_name_directory, Ffile_name_as_directory)
5610 (Fdirectory_file_name, Fexpand_file_name)
5611 (Fsubstitute_in_file_name): Protect against invalid file handler
5612 return values (Bug#10845).
5613
3eb49e71
EZ
56142012-02-18 Eli Zaretskii <eliz@gnu.org>
5615
5616 * .gdbinit (pitx): Fix incorrect references to fields of the
5617 iterator stack.
5618
7b926f3f
CY
56192012-02-17 Chong Yidong <cyd@gnu.org>
5620
5621 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5622
11273115
PE
56232012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5624
5625 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5626 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5627
c3a70e2b
CY
56282012-02-15 Chong Yidong <cyd@gnu.org>
5629
5630 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5631 marked as special. Also, starting docstrings with * is obsolete.
5632
0ca43699
AS
56332012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5634
5635 * gnutls.c (emacs_gnutls_write): Fix last change.
5636
2e8f3c56
LI
56372012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5638
5639 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5640 send_process.
5641
af70074f
SM
56422012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5643
5644 * keymap.c (Fsingle_key_description): Handle char ranges.
5645
95986d52
CY
56462012-02-12 Chong Yidong <cyd@gnu.org>
5647
afd83bd1
CY
5648 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5649 as that creates a dangerous corner case.
5650
95986d52
CY
5651 * window.c (Fdelete_window_internal): Invalidate the mouse
5652 highlight (Bug#9904).
5653
bd7da63e
GM
56542012-02-12 Glenn Morris <rgm@gnu.org>
5655
5656 * xselect.c (Fx_own_selection_internal)
5657 (Fx_get_selection_internal, Fx_disown_selection_internal)
5658 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5659 * nsselect.m (Fx_own_selection_internal)
5660 (Fx_disown_selection_internal, Fx_selection_exists_p)
5661 (Fx_selection_owner_p, Fx_get_selection_internal):
5662 Sync docs and argument specs with the xselect.c versions.
5663
77abcbc2
LI
56642012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5665
5666 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5667
90b671e2
EZ
56682012-02-11 Eli Zaretskii <eliz@gnu.org>
5669
1c0ca0b7
EZ
5670 * w32select.c (Fx_selection_exists_p): Sync doc string and
5671 argument list with xselect.c. (Bug#10783)
5672
5673 * w16select.c (Fx_selection_exists_p): Sync doc string and
5674 argument list with xselect.c. (Bug#10783)
90b671e2 5675
49241268
GM
56762012-02-10 Glenn Morris <rgm@gnu.org>
5677
5678 * fns.c (Fsecure_hash): Doc fix.
5679
f998bbe7 56802012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5681
5682 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5683
0992bd9c
CY
56842012-02-07 Chong Yidong <cyd@gnu.org>
5685
5686 * buffer.c (Fbuffer_local_variables)
5687 (buffer_lisp_local_variables): Handle unbound vars correctly;
5688 don't let Qunbound leak into Lisp.
5689
af008560
GM
56902012-02-07 Glenn Morris <rgm@gnu.org>
5691
dd605cc4
GM
5692 * image.c (Fimagemagick_types): Doc fix.
5693
af008560
GM
5694 * image.c (imagemagick-render-type): Change it from a lisp object
5695 to an integer. Move the doc here from the lisp manual.
5696 Treat all values not equal to 0 the same.
5697
1449fa1d
CY
56982012-02-06 Chong Yidong <cyd@gnu.org>
5699
5700 * doc.c (store_function_docstring): Avoid applying docstring of
5701 alias to base function (Bug#2603).
5702
3723ec07
AS
57032012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5704
5705 * .gdbinit (pp1, pv1): Remove redundant defines.
5706 (pr): Use pp.
5707
79c1cc1e
CY
57082012-02-04 Chong Yidong <cyd@gnu.org>
5709
5710 * nsterm.m: Declare a global (Bug#10694).
5711
d7f29f8e
EZ
57122012-02-04 Eli Zaretskii <eliz@gnu.org>
5713
cae07000
SM
5714 * w32.c (get_emacs_configuration_options):
5715 Include --enable-checking, if specified, in the return value.
d7f29f8e 5716
3b95a6f9
MR
57172012-02-04 Martin Rudalics <rudalics@gmx.at>
5718
5719 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5720 after rounding frame sizes. (Bug#9723)
5721
d6fa96a6
EZ
57222012-02-04 Eli Zaretskii <eliz@gnu.org>
5723
5724 * keyboard.c (adjust_point_for_property): Don't position point
5725 before BEGV. (Bug#10696)
5726
df0b2940
PE
57272012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 Handle overflow when computing char display width (Bug#9496).
5730 * character.c (char_width): Return EMACS_INT, not int.
5731 (char_width, c_string_width): Check for overflow when
5732 computing the width; this is possible now that individual
5733 characters can have unbounded width. Problem introduced
5734 by merge from Emacs 23 on 2012-01-19.
5735
6bee44d6
MA
57362012-02-02 Michael Albinus <michael.albinus@gmx.de>
5737
5738 * dbusbind.c (Fdbus_register_method): Mention the return value
5739 :ignore in the docstring.
5740
44f92739
GM
57412012-02-02 Glenn Morris <rgm@gnu.org>
5742
1b9f60cc
GM
5743 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5744
44f92739
GM
5745 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5746 Unconditionally set to t. (Bug#10673)
5747 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5748 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5749 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5750
c5d3843c
KH
57512012-02-02 Kenichi Handa <handa@m17n.org>
5752
5753 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5754 0, do not call append_composite_glyph.
5755
159462d4 57562012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5757
5758 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5759 NULL (Bug#6988).
5760 (x_produce_glyphs): If the component of a composition is a null
5761 string, set it->pixel_width to 1 to avoid zero-width glyph.
5762
78cef877
EZ
57632012-02-01 Eli Zaretskii <eliz@gnu.org>
5764
5765 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5766 first 2 arguments are identical. This makes inserting large
5767 output from a subprocess an order of magnitude faster on
5768 MS-Windows, where all sbrk'ed memory is always contiguous.
5769
97897668
GM
57702012-01-31 Glenn Morris <rgm@gnu.org>
5771
5772 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5773 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5774 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5775
31fd3586
GM
57762012-01-29 Glenn Morris <rgm@gnu.org>
5777
5778 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5779
0e24a8b2
CY
57802012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5781
5782 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5783
cc0adcb0
CY
57842012-01-28 Chong Yidong <cyd@gnu.org>
5785
5786 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5787
acc28cb9
CY
57882012-01-26 Chong Yidong <cyd@gnu.org>
5789
9c69cfb7
CY
5790 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5791
acc28cb9
CY
5792 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5793 repeat counts (Bug#10507).
5794
48da7392
GM
57952012-01-26 Glenn Morris <rgm@gnu.org>
5796
5797 * lread.c (syms_of_lread): Doc fix.
5798
14af5f7f
CY
57992012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5800
5801 * coding.c (encode_designation_at_bol): Change return value to
5802 EMACS_INT.
5803
0b21c100
CY
58042012-01-25 Chong Yidong <cyd@gnu.org>
5805
5806 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5807
3c2907f7
CY
58082012-01-21 Chong Yidong <cyd@gnu.org>
5809
5810 * floatfns.c (Fcopysign): Make the second argument non-optional,
5811 since nil is not allowed anyway.
5812
959ad23f
AS
58132012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5814
5815 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5816 (send_process): Likewise.
5817
34a02f46
MR
58182012-01-19 Martin Rudalics <rudalics@gmx.at>
5819
5820 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5821 (Vwindow_persistent_parameters): Do not use Qstate.
5822 Rewrite doc-strings.
34a02f46 5823
1259009a 58242012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5825
5826 * character.c (char_width): New function.
70d4fdf6
GM
5827 (Fchar_width, c_string_width, lisp_string_width):
5828 Use char_width (Bug#9496).
25ed9e61 5829
6a6ee00d
MR
58302012-01-16 Martin Rudalics <rudalics@gmx.at>
5831
5832 * window.c (Vwindow_persistent_parameters): New variable.
5833 (Fset_window_configuration, save_window_save): Handle persistent
5834 window parameters.
5835
c85efaf7
EZ
58362012-01-14 Eli Zaretskii <eliz@gnu.org>
5837
5838 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5839 thrashing the stack of the thread. (Bug#9087)
5840
5944709e
PE
58412012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5842
5843 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5844
e71f5d99
EZ
58452012-01-11 Eli Zaretskii <eliz@gnu.org>
5846
5847 * xdisp.c (rows_from_pos_range): Handle the case where the
5848 highlight ends on a newline. (Bug#10464)
5849 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5850 he end column for display of highlight that ends on a newline
5851 before a R2L line.
5852
ce316182
GM
58532012-01-11 Glenn Morris <rgm@gnu.org>
5854
5855 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5856 from load-path also when installation-directory is nil. (Bug#10208)
5857
5b43da69
GM
58582012-01-10 Glenn Morris <rgm@gnu.org>
5859
74cc8ff9
GM
5860 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5861
7d8d6e4e
GM
5862 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5863 Update template values to be closer to their typical values these days.
5b43da69 5864
a0db8d43
EZ
58652012-01-09 Eli Zaretskii <eliz@gnu.org>
5866
5867 * xdisp.c (rows_from_pos_range): Accept additional argument
5868 DISP_STRING, and accept any glyph in a row whose object is that
5869 string as eligible for mouse highlight. Fixes mouse highlight of
5870 display strings from overlays. (Bug#10464)
5871
9a0115ab 58722012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5873
b9110d6a 5874 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5875 * fileio.c (auto_saving_dir_umask): New static var.
5876 (Fmake_directory_internal): Use it.
5877 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5878 creating the directory. The old code temporarily assigns
5879 too-generous permissions to the directory.
5880 (do_auto_save_eh): Clear it.
b9110d6a 5881 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5882 that the var is always cleared.
5883
6c1bd3f3
EZ
58842012-01-07 Eli Zaretskii <eliz@gnu.org>
5885
5886 * search.c (scan_buffer): Pass character positions to
5887 know_region_cache, not byte positions. (Bug#6540)
5888
069d2b50
L
58892012-01-07 LynX <_LynX@bk.ru> (tiny change)
5890
5891 * w32.c (sys_rename): Report EXDEV when rename of a directory
5892 fails because the target is on another logical disk. (Bug#10284)
5893
75bf0d33
DB
58942012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5895
5896 * xterm.c (x_embed_request_focus): New function.
5897
5898 * xterm.h: Add prototype.
5899
5900 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5901
1c6e5a32
GM
59022012-01-05 Glenn Morris <rgm@gnu.org>
5903
5904 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5905
651e947e
EZ
59062012-01-01 Eli Zaretskii <eliz@gnu.org>
5907
5908 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5909 Load gnutls_transport_set_lowat only if GnuTLS version is below
5910 2.11.1.
5911 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5912 GnuTLS versions below 2.11.1.
5913
3778cdd8
AL
59142011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5915
5916 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5917 to the doc string advising against its use for altering the way
5918 windows are scrolled.
5919
0e5317f7
KH
59202011-12-28 Kenichi Handa <handa@m17n.org>
5921
5922 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5923 coding-system ASCII compatible only when it does not produce BOM
5924 on encoding (Bug#10383).
5925
93d5ca1f
JD
59262011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5927
5928 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5929 can scroll.
5930 (create_and_show_popup_menu): Always use menu_position_func for
5931 Gtk3 (Bug#10361).
5932
ca22b785
AS
59332011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5934
5935 * callint.c (Fcall_interactively): Don't truncate prompt string.
5936
d048e1e6
EZ
59372011-12-23 Eli Zaretskii <eliz@gnu.org>
5938
5939 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5940 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5941 resumed from there (after widening). (Bug#10360)
d048e1e6 5942
5ccaba1f
JD
59432011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5944
5945 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5946
204ee57f
JD
59472011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5948
b81d40f0
JB
5949 * nsterm.m (x_free_frame_resources):
5950 Release f->output_data.ns->miniimage.
204ee57f
JD
5951 (ns_index_color): Fix indentation. Do not retain
5952 color_table->colors[i].
5953
5954 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5955 before returning.
5956
5957 * nsfns.m (x_set_background_color): Assign return value from
5958 ns_index_color to face-background instead of NSColor*.
5959 (ns_implicitly_set_icon_type): Fix indentation.
5960 Change assignment in for loop to comparison.
5961
5962 * emacs.c (ns_pool): New variable.
5963 (main): Assign ns_pool.
5964 (Fkill_emacs): Call ns_release_autorelease_pool.
5965
5966 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5967 autorelease fdesc, release fdAttrs and tdict.
5968 (ns_get_covering_families): Release charset.
5969 (ns_findfonts): Release NSFontDescriptor created with new.
5970 (ns_uni_to_glyphs): Fix indentation.
5971 (setString): Release attrStr before assigning new value.
5972
c803b2b7
JD
59732011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5974
678f4426
JD
5975 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5976 and NS_IMPL_COCOA.
5977 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5978 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5979
cd394be1 59802011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5981
5fecd5fc
JD
5982 * nsterm.m (ns_term_init): Subscribe for notifications
5983 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5984 to method trackingNotification in EmacsMenu.
5985
5986 * nsmenu.m (trackingMenu): New variable.
3771cb17 5987 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5988 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5989 from Aquamacs (Bug#7030).
678f4426
JD
5990
59912011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5992
c803b2b7
JD
5993 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5994 (symbol_to_nsstring): Fix indentation.
5995 (ns_symbol_to_pb): New function.
cae07000
SM
5996 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5997 (Fns_rotate_cut_buffers_internal): Remove.
5998 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5999 Fns_store_cut_buffer_internal.
6000 (ns_get_foreign_selection, Fx_own_selection_internal)
6001 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6002 (Fns_get_selection_internal, Fns_store_selection_internal):
6003 Use ns_symbol_to_pb and check if return value is nil.
6004 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6005 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6006 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6007 renamed to Sns_store_selection_internal.
6008 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6009 and remove this function.
6010 (ns_handle_selection_clear): Remove, never used.
6011 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6012 here.
6013
e1b01a3a
KB
60142011-12-17 Ken Brown <kbrown@cornell.edu>
6015
6016 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6017 GID is unknown (Bug#10257).
6018
2adb6e85
PE
60192011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6020
6021 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6022 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6023 which caused a build failure on GNU/Linux IA-64. This problem was
6024 introduced by my 2011-10-07 patch.
6025
d1d7b339
JL
60262011-12-15 Juri Linkov <juri@jurta.org>
6027
6028 * image.c (imagemagick_error): New function. (Bug#10112)
6029 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6030 Use `imagemagick_error' where ImageMagick functions return
6031 `MagickFalse'.
6032 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6033 proper order.
6034
100d5755
KH
60352011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6036
6037 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6038 fill background (Bug#8992).
6039
454592a6
MR
60402011-12-13 Martin Rudalics <rudalics@gmx.at>
6041
6042 * window.c (Vwindow_combination_resize)
6043 (Vwindow_combination_limit): Use t instead of non-nil in
6044 doc-strings.
61d4b438
MR
6045 (Vrecenter_redisplay): Add first sentence of doc-string on
6046 separate line.
53524d93 6047 (Frecenter): Fix doc-string typo.
454592a6 6048
3633e3aa
KH
60492011-12-11 Kenichi Handa <handa@m17n.org>
6050
6051 * coding.c (Funencodable_char_position): Pay attention to the
6052 buffer text relocation (Bug#9389).
6053
7b9d523a 60542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6055
7b9d523a
JD
6056 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6057 gtk_init (Bug#10100).
6058
b73189c6
EZ
60592011-12-10 Eli Zaretskii <eliz@gnu.org>
6060
6061 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6062 IT->string is nil. (Bug#10263)
6063
f7dfe5d6
JD
60642011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6065
83faebb4
JD
6066 * nsterm.h (x_free_frame_resources): Declare.
6067
f7dfe5d6
JD
6068 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6069 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6070
6071 * nsterm.h (ns_get_defaults_value): Declare.
6072
6073 * nsterm.m (ns_default): Call ns_get_defaults_value.
6074
7cd4e72c
EZ
60752011-12-09 Eli Zaretskii <eliz@gnu.org>
6076
6077 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6078 (Bug#10170)
6079
b34d7317
YM
60802011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6081
6082 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6083 that where the value of an _OBJC_* symbol points to is in the .bss
6084 section (Bug#10240).
6085
76470ad1
KH
60862011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6087
6088 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6089 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6090
745fff94
KH
60912011-12-08 Kenichi Handa <handa@m17n.org>
6092
6093 * ftfont.c (get_adstyle_property): Fix previous change
6094 (Bug#10233).
6095
6e44397c
JB
60962011-12-07 Juanma Barranquero <lekktu@gmail.com>
6097
6098 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6099 dirs from the default value of EMACSLOADPATH (bug#10208).
6100
7efa6272
GM
61012011-12-07 Glenn Morris <rgm@gnu.org>
6102
6103 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6104 installation and source directories as well. (Bug#10208)
6105
f6fc4d87
CY
61062011-12-06 Chong Yidong <cyd@gnu.org>
6107
6108 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6109
2bf26180
GM
61102011-12-06 Glenn Morris <rgm@gnu.org>
6111
6112 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6113 as an error, not just -1. (Bug#10217)
6114
3a6ad4f0
CY
61152011-12-05 Chong Yidong <cyd@gnu.org>
6116
6117 * keyboard.c (process_special_events): New function.
6118 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6119
75a3b399
PE
61202011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6121
6122 * coding.c (encode_designation_at_bol): Don't use uninitialized
6123 local variable (Bug#9318).
6124
c3c9e25e
KH
61252011-12-05 Kenichi Handa <handa@m17n.org>
6126
6127 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6128 return Qnil (Bug#8046, Bug#10193).
6129
5eb05ea3
KH
61302011-12-05 Kenichi Handa <handa@m17n.org>
6131
6132 * coding.c (encode_designation_at_bol): New args charbuf_end and
6133 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6134 (coding_set_source): Return how many bytes coding->source was
6135 relocated.
6136 (coding_set_destination): Return how many bytes
6137 coding->destination was relocated.
6138 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6139 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6140
61412011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6142
6143 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6144 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6145 macro (Bug#9318).
6146
61472011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6148
6149 The following changes are to fix Bug#9318.
6150
a79703f5 6151 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6152 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6153 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6154 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6155
7dbda6df
JB
61562011-12-05 Juanma Barranquero <lekktu@gmail.com>
6157
6158 * lisp.h (process_quit_flag): Fix external declaration.
6159
6d5eb5b0
SM
61602011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6161
6162 Don't macro-inline non-performance-critical code.
6163 * eval.c (process_quit_flag): New function.
6164 * lisp.h (QUIT): Use it.
6165
a0c3fad0
JD
61662011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6167
6168 * nsfns.m (get_geometry_from_preferences): New function.
6169 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6170
6c07aac2
AS
61712011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6172
6173 * emacs.c (Qkill_emacs): Define.
6174 (syms_of_emacs): Initialize it.
6175 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6176 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6177 (quit_throw_to_read_char): Add parameter `from_signal'.
6178 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6179 * lisp.h (QUIT): Call Fkill_emacs if requested.
6180
c052ead4
JD
61812011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6182
6183 * widget.c (update_wm_hints): Return if wmshell is null.
6184 (widget_update_wm_size_hints): New function.
6185
6186 * widget.h (widget_update_wm_size_hints): Declare.
6187
6188 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6189 widget_update_wm_size_hints (Bug#10104).
6190
9e49252b
EZ
61912011-12-03 Eli Zaretskii <eliz@gnu.org>
6192
6193 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6194 before a newline, prepare the bidi iterator for consuming the
6195 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6196 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6197
02b16839
JL
61982011-12-02 Juri Linkov <juri@jurta.org>
6199
6200 * search.c (Fword_search_regexp): New Lisp function created from
6201 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6202 (Fword_search_backward, Fword_search_forward)
6203 (Fword_search_backward_lax, Fword_search_forward_lax):
6204 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6205 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6206
0068070e
SM
62072011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6208
6209 * fileio.c (Finsert_file_contents): Move after-change-function call
6210 to before the "handled:" label, since all "goto handled" appear in
6211 cases where the *-change-functions have already been properly called
6212 (bug#10117).
6213
3360a3fc
AS
62142011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6215
6216 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6217 waiting for input. (Bug#10169)
6218
73d6c093
EZ
62192011-11-30 Eli Zaretskii <eliz@gnu.org>
6220
6221 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6222 verifies glyph row's hash code--we have just reallocated the
6223 glyphs, so their contents can be complete garbage. (Bug#10164)
6224
febe6bea
JB
62252011-11-30 Juanma Barranquero <lekktu@gmail.com>
6226
6227 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6228
801a4313
EZ
62292011-11-30 Eli Zaretskii <eliz@gnu.org>
6230
6231 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6232 attributes are tested _before_ calling verify_row_hash, to protect
6233 against GCC re-ordering of the tests. (Bug#10164)
6234
2b56b87e
JD
62352011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6236
6237 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6238
6239 * xterm.c (handle_one_xevent): Only set async_visible and friends
6240 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6241 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6242 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6243
dbf31225
PE
62442011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6245
6246 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6247 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6248 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6249 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6250 All uses changed to use GCPRO1 etc.
6251 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6252 Revert to old implementation (i.e., before 2011-03-11).
6253
1305621b
YM
62542011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6255
6256 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6257 of scroll runs so as to avoid assigning disabled bogus rows and
6258 unnecessary graphics copy operations.
6259
8c9afb46
EZ
62602011-11-27 Eli Zaretskii <eliz@gnu.org>
6261
6262 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6263 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6264 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6265 (malloc, free, realloc, calloc): Redirect to e_* only when
6266 compiling Emacs.
6267
6268 * lisp.h (GCTYPEBITS): Move before first use.
6269 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6270 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6271 this macro definition.
6272
6273 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6274 _MSC_VER.
6275
54e9e3bf
JD
62762011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6277
6d5eb5b0
SM
6278 * gtkutil.c (xg_create_frame_widgets):
6279 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6280 present with Gtk+ 2.0.
6281
83aca1cb
PE
62822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6283
6284 * fileio.c (Finsert_file_contents): Undo previous change; see
6285 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6286
5b76caa4
PE
62872011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6288
6289 Rename locals to avoid shadowing.
6290 * fileio.c (Finsert_file_contents):
6291 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6292 * process.c (wait_reading_process_output):
6293 Rename inner 'proc' to 'p' to avoid shadowing.
6294 Indent for consistency with usual Emacs style.
6295
8c535114
EZ
62962011-11-25 Eli Zaretskii <eliz@gnu.org>
6297
6298 * xdisp.c (redisplay_window): If cursor row is not fully visible
6299 after recentering, and scroll-conservatively is set to a large
6300 number, scroll window by a few more lines to make the cursor fully
6301 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6302 (start_display): Don't move to the next line if the display should
6303 start at a newline that is part of a display vector or an overlay
6304 string. (Bug#10119)
8c535114 6305
fa4fdb5c
JL
63062011-11-24 Juri Linkov <juri@jurta.org>
6307
6308 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6309 after the `MagickPingImage' call. (Bug#10112)
6310
90ec88df
CY
63112011-11-23 Chong Yidong <cyd@gnu.org>
6312
6313 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6314
56e2e794
MR
63152011-11-23 Martin Rudalics <rudalics@gmx.at>
6316
6317 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6318 making another buffer current. (Bug#10114)
6319
b6e64c41
GM
63202011-11-23 Glenn Morris <rgm@gnu.org>
6321
6322 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6323
6b21de18
CY
63242011-11-23 Chong Yidong <cyd@gnu.org>
6325
6326 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6327 using it (Bug#5984).
6328
b12cd789
EZ
63292011-11-22 Eli Zaretskii <eliz@gnu.org>
6330
6331 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6332 and header-lines, as they don't have one computed for them.
6333 (Bug#10098)
6334
6335 * .gdbinit (prow): Make displayed values more self-explaining.
6336 Add row's hash code.
6337
261b6fd4
LMI
63382011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6339
6340 * process.c (wait_reading_process_output): Fix asynchrounous
6341 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6342 (wait_reading_process_output): Add comment and URL.
261b6fd4 6343
e7cfd277
JD
63442011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6345
6346 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6347
a9b9b7f5
CY
63482011-11-21 Chong Yidong <cyd@gnu.org>
6349
6350 * window.c (Fnext_window, Fprevious_window): Doc fix.
6351
b0d15b4f
SM
63522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6353
6354 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6355
fe7a3057
JB
63562011-11-20 Juanma Barranquero <lekktu@gmail.com>
6357
6358 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6359
d2999b1a
MR
63602011-11-20 Martin Rudalics <rudalics@gmx.at>
6361
6362 * window.c (Fset_window_combination_limit): Rename argument
6363 STATUS to LIMIT.
6364 (Vwindow_combination_limit): Remove "status" from doc-string.
6365
d5ff9cd0
AS
63662011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6367
6368 * m/ibms390.h: Remove.
6369 * m/ibms390x.h: Don't include "ibms390.h".
6370
a5bb9bd3
SM
63712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6372
6373 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6374 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6375
cd1181db
JB
63762011-11-20 Juanma Barranquero <lekktu@gmail.com>
6377
6378 * casetab.c (Fset_case_table):
6379 * charset.c (Fcharset_after): Fix typos.
6380
615a3b8d 63812011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6382
17e845af
PE
6383 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6384 Otherwise, valgrind does not work on some platforms.
6385 Problem reported by Andreas Schwab in
6a0bf43d
PE
6386 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6387 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6388 is set, removing the need for VIRT_ADDRESS_VARIES.
6389 (PURE_P): Use a more-efficient implementation that needs just one
6390 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6391 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6392 to 4 (xorl, subq, cmpq, setbe).
6393 * alloc.c (pure): Always extern now, since that's the
6394 VIRT_ADDR_VARIES behavior.
6395 (PURE_POINTER_P): Use a single comparison, not two, for
6396 consistency with the new puresize.h.
6397 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6398 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6399 Remove VIRT_ADDR_VARIES no longer needed.
6400
f8fe6f96
EZ
64012011-11-19 Eli Zaretskii <eliz@gnu.org>
6402
6403 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6404 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6405 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6406 behave as if the cursor position were at the window margin.
6407
6408 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6409 and the cursor position is out of bounds, behave as if the cursor
6410 position were at the window margin. (Bug#10075)
6411
df05a53c
CY
64122011-11-18 Chong Yidong <cyd@gnu.org>
6413
6414 * window.c (Fwindow_combination_limit): Make first argument
6415 non-optional, since it is meaningless for live windows like the
6416 selected window.
61ccba97 6417
2071918e
DA
64182011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6419
6420 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6421
b50a28de
SM
64222011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6423
6424 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6425 (graft_intervals_into_buffer): Simplify.
6426
015137db
EZ
64272011-11-18 Eli Zaretskii <eliz@gnu.org>
6428
6429 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6430 hash values of the two rows.
6431 (copy_row_except_pointers): Preserve the used[] arrays and the
6432 hash values of the two rows. (Bug#10035)
68c95424 6433 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6434
6435 * xdisp.c (row_hash): New function, body extracted from
6436 compute_line_metrics.
6437 (compute_line_metrics): Call row_hash, instead of computing the
6438 hash code inline.
6439
6440 * dispnew.c (verify_row_hash): Call row_hash for computing the
6441 hash code of a row, instead of duplicating code from xdisp.c.
6442
6443 * dispextern.h (row_hash): Add prototype.
6444
a2addb04
TH
64452011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6446
6447 * frame.c (delete_frame): Don't delete the terminal when the last
6448 X frame is closed if emacs is built with GTK toolkit.
6449
df85d315
JB
64502011-11-17 Juanma Barranquero <lekktu@gmail.com>
6451
6452 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6453
a0c2d0ae
MR
64542011-11-17 Martin Rudalics <rudalics@gmx.at>
6455
6456 * window.c (Vwindow_splits): Rename to
6457 Vwindow_combination_resize. Suggested by Juri Linkov.
6458 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6459 of Vwindow_splits.
6460
58179cce
JB
64612011-11-16 Juanma Barranquero <lekktu@gmail.com>
6462
7877f373
JB
6463 * nsfns.m (Fns_font_name):
6464 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6465
b6f67890
MR
64662011-11-16 Martin Rudalics <rudalics@gmx.at>
6467
6468 * window.h (window): Rename slot "nest" to "combination_limit".
6469 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6470 (Fset_window_nest): Rename to Fset_window_combination_limit.
6471 (Vwindow_nest): Rename to Vwindow_combination_limit.
6472 (recombine_windows, make_parent_window, make_window)
6473 (Fsplit_window_internal, saved_window)
6474 (Fset_window_configuration, save_window_save): Rename all
6475 occurrences of window_nest to window_combination_limit.
6476
c7015153
JB
64772011-11-15 Juanma Barranquero <lekktu@gmail.com>
6478
6479 * image.c (imagemagick_load_image): Fix typo.
6480
322ad6ec
EZ
64812011-11-14 Eli Zaretskii <eliz@gnu.org>
6482
6483 * xdisp.c (display_line): Move the call to
6484 highlight_trailing_whitespace before the call to
6485 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6486 faces of all the glyphs to compute ROW's hash value.
6487 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6488
f067b8ec
JB
64892011-11-14 Juanma Barranquero <lekktu@gmail.com>
6490
6491 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6492 just return (bug#10044).
6493
1e5b2111
EZ
64942011-11-12 Eli Zaretskii <eliz@gnu.org>
6495
7ef3cbd5
EZ
6496 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6497 with user-defined heap size. Bump the default size of the temacs
6498 heap to 27MB, to avoid memory warning when running temacs.
6499 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6500
1e5b2111
EZ
6501 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6502 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6503 (verify_row_hash) [XASSERTS]: New function.
6504 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6505 that the hash value of glyph rows is correct.
1e5b2111 6506
89d61221
MR
65072011-11-12 Martin Rudalics <rudalics@gmx.at>
6508
6509 * window.h (window): Remove splits slot.
6510 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6511 (Fdelete_other_windows_internal, make_parent_window)
6512 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6513 (Fset_window_configuration, save_window_save): Don't deal with
6514 split status of windows.
6515 (saved_window): Remove splits slot.
6516 (Vwindow_splits): Rewrite doc-string.
6517
97f18cc8
JD
65182011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6519
6520 * xfns.c (unwind_create_frame):
6521 * nsfns.m (unwind_create_frame):
6522 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6523 Vframe_list (Bug#9999).
6524
22a648b4
DA
65252011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6526
0b381c7e 6527 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6528
659afede
KH
65292011-11-11 Kenichi Handa <handa@m17n.org>
6530
6531 * callproc.c (Fcall_process): Set the member dst_multibyte of
6532 process_coding.
6533
9ac0394b
KH
65342011-11-11 Johan Bockgård <bojohan@gnu.org>
6535
6536 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6537 avoid a crash (bug#9496).
6538
2fbdc249
CY
65392011-11-09 Chong Yidong <cyd@gnu.org>
6540
6541 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6542 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6543
ac6b1f81
PE
65442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6545
6546 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6547
09db192c
PE
65482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6549
6550 Avoid some portability problems by eschewing 'extern inline' functions.
6551 The trivial performance wins aren't worth the portability hassles; see
6552 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6553 et seq.
6554 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6555 (window_box_width, window_box_left, window_box_left_offset)
6556 (window_box_right, window_box_right_offset): Undo previous change,
6557 by removing the "extern"s.
6558 * intervals.c (adjust_intervals_for_insertion)
6559 (adjust_intervals_for_deletion): Undo previous change,
6560 making these static again.
6561 (offset_intervals, temp_set_point_both, temp_set_point)
6562 (copy_intervals_to_string): No longer inline.
6563 * xdisp.c (window_text_bottom_y, window_box_width)
6564 (window_box_height, window_box_left_offset)
6565 (window_box_right_offset, window_box_left, window_box_right)
6566 (window_box): No longer inline.
6567
105216ed
CY
65682011-11-08 Chong Yidong <cyd@gnu.org>
6569
6570 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6571 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6572 Signal an error if not a live window.
105216ed
CY
6573 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6574 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6575
ae9e237f
JB
65762011-11-07 Juanma Barranquero <lekktu@gmail.com>
6577
6578 * lisp.h (syms_of_abbrev): Remove declaration.
6579 Reported by CHENG Gao <chenggao@royau.me>.
6580
c7aa8333
EZ
65812011-11-07 Eli Zaretskii <eliz@gnu.org>
6582
6583 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6584 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6585 of temacs in GUI mode.
6586
be7f5545
MR
65872011-11-07 Martin Rudalics <rudalics@gmx.at>
6588
6589 * window.h: Declare delete_all_child_windows instead of
6590 delete_all_subwindows.
6591 * window.c (Fwindow_nest, Fset_window_nest)
6592 (Fset_window_new_total, Fset_window_new_normal)
6593 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6594 (delete_all_subwindows): Rename to delete_all_child_windows.
6595 (Fdelete_other_windows_internal, Fset_window_configuration):
6596 Call delete_all_child_windows instead of delete_all_subwindows.
6597 * frame.c (delete_frame): Call delete_all_child_windows instead
6598 of delete_all_subwindows.
6599
ca78dc43
PE
66002011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6601
6602 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6603 This is also needed for porting to any host where GC_MARK_STACK is
6604 not GC_MAKE_GCPROS_NOOPS.
6605 (which_symbols): Use it.
6606
a0241d01
KH
66072011-11-07 Kenichi Handa <handa@m17n.org>
6608
6609 * coding.c (coding_set_destination): Check coding->src_pos only
6610 when coding->src_object is a buffer (bug#9910).
6611
6612 * process.c (send_process): Set the member src_multibyte of coding
6613 to 0 (bug#9911) when sending a unibyte text.
6614
6615 * callproc.c (Fcall_process): Set the member src_multibyte of
6616 process_coding to 0 (bug#9912).
6617
a64bfdfa 66182011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6619
6620 * xmenu.c (cleanup_widget_value_tree): New function.
6621 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6622 calling free_menubar_widget_value_tree directly (Bug#9830).
6623
cb41b32a
PE
66242011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6625
6626 Fix some portability problems with 'inline'.
6627 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6628 (window_box_width, window_box_left, window_box_left_offset)
6629 (window_box_right, window_box_right_offset): Declare extern.
6630 Otherwise, these inline functions do not conform to C99 and
6631 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6632 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6633 * intervals.c (adjust_intervals_for_insertion)
6634 (adjust_intervals_for_deletion): Now extern, because otherwise the
6635 extern inline functions 'offset_intervals' couldn't refer to it.
6636 (static_offset_intervals): Remove.
6637 (offset_intervals): Rewrite using the old contents of
6638 static_offset_intervals. The old version didn't conform to C99
6639 because an extern inline function contained a reference to an
6640 identifier with static linkage.
6641
b7041366
AS
66422011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6643
6644 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6645 GC.
6646
88a37c4d
EZ
66472011-11-06 Eli Zaretskii <eliz@gnu.org>
6648
6649 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6650 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6651 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6652 return Qleft_to_right.
6653
49745b39
CY
66542011-11-06 Chong Yidong <cyd@gnu.org>
6655
6656 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6657 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6658 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6659 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6660 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6661 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6662 (Fwindow_vscroll): Doc fix.
6663 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6664 argument, since it makes no sense to pass a live window and for
6665 consistency with window-child.
6666
1f05cd82
CS
66672011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6668
6669 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6670 support MSVC.
6671
22610910
JR
66722011-11-05 Jason Rumney <jasonr@gnu.org>
6673
6674 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6675 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6676 fonts (Bug#6029).
6677 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6678 bitwise arithmetic preventing use of unicode-sip and non-truetype
6679 opentype fonts.
6680
a06776b2
EZ
66812011-11-05 Eli Zaretskii <eliz@gnu.org>
6682
3ad924ba
EZ
6683 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6684 "emacs"-only part.
6685
a06776b2
EZ
6686 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6687 initialization code to keep similarity to xfns.c after changes
6688 from 2011-11-05.
6689
c9e7db78
JD
66902011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6691
a97f8f3f
JD
6692 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6693 (unwind_create_frame): New function (Bug#9943).
6694 (Fx_create_frame): Restructure code to be more similar to the one in
6695 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6696 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6697 Move terminal->reference_count++ just before making the frame official
6698 (Bug#9943).
6699
6700 * nsterm.m (x_free_frame_resources): New function.
6701 (x_destroy_window): Move code to x_free_frame_resources.
6702
c9e7db78 6703 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6704 (Fx_create_frame, x_create_tip_frame):
6705 Move terminal->reference_count++ just before making the frame
75f1671a 6706 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6707 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6708
a6fc3b5c
EZ
67092011-11-05 Eli Zaretskii <eliz@gnu.org>
6710
6711 Support MSVC build with newer versions of Visual Studio.
6712 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6713 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6714 nt/gmake.defs.
6715
6716 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6717 which are not supported by MSVC.
6718 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6719 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6720 bitfields.
6721 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6722 types in bitfields.
6723 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6724
6725 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6726
58179cce 67272011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6728
6729 Support MSVC build with newer versions of Visual Studio.
6730 * w32.c: Don't include w32api.h for MSVC.
6731 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6732
6733 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6734 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6735 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6736 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6737 e_* cousins.
6738 (alloca) [_MSC_VER]: Define to _alloca.
6739
6740 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6741
6742 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6743
a58c13ed
EZ
67442011-11-04 Eli Zaretskii <eliz@gnu.org>
6745
6746 * xdisp.c (note_mouse_highlight): If either of
6747 previous/next-single-property-change returns nil, treat that as
6748 the beginning or the end of the buffer. (Bug#9955)
6749
fe0b6370
JD
67502011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6751
a58c13ed 6752 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6753 label is not null (Bug#9951).
6754 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6755 may be NULL.
6756
89bd5ee1
EZ
67572011-11-04 Eli Zaretskii <eliz@gnu.org>
6758
6759 * window.c (Fwindow_body_size): Mention in the doc string that the
6760 return value is in frame's canonical units. (Bug#9949)
6761
84c3edb9
EZ
67622011-11-03 Eli Zaretskii <eliz@gnu.org>
6763
4e2fb5c7
EZ
6764 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6765
84c3edb9 6766 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6767 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6768 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6769
bc17a887
EZ
67702011-11-01 Eli Zaretskii <eliz@gnu.org>
6771
6772 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6773 Don't stop backward scan on the continuation glyph, even though
6774 its CHARPOS is positive.
6d5eb5b0
SM
6775 (mouse_face_from_buffer_pos, note_mouse_highlight):
6776 Rename cover_string to disp_string.
bc17a887 6777
4ee88440
MR
67782011-11-01 Martin Rudalics <rudalics@gmx.at>
6779
6780 * window.c (temp_output_buffer_show): Don't use
6781 Vtemp_buffer_show_specifiers.
6782 (Vtemp_buffer_show_specifiers): Remove unused variable.
6783
c2ff3c02
EZ
67842011-10-30 Eli Zaretskii <eliz@gnu.org>
6785
6786 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6787 past the beginning of the current glyph matrix.
6788
58179cce 67892011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6790
6791 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6792 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6793 HAVE_GTK3 (Bug#9869).
b77a6a7f 6794
3b574623
JD
6795 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6796 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6797
b77a6a7f
JD
6798 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6799
6800 * xterm.c: Declare x_handle_net_wm_state to return int.
6801 (handle_one_xevent): Check if we are iconified but don't have
6802 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6803 (get_current_wm_state): Return non-zero if not hidden,
6804 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6805 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6806 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6807 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6808
196e41e4
PE
68092011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6810
6811 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6812 so that this new function doesn't get optimized away by a
6813 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6814
021f2e1a
AS
68152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6816
6817 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6818
8b058d44
EZ
68192011-10-29 Eli Zaretskii <eliz@gnu.org>
6820
6821 Fix the `xbytecode' command.
6822 * .gdbinit (xprintbytestr): New command.
b50a28de 6823 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6824 (xbytecode): Print the byte-code string as well.
6825
4452fb80
EZ
68262011-10-29 Kim Storm <storm@cua.dk>
6827
8b058d44
EZ
6828 * alloc.c (which_symbols): New function.
6829
21b72067
AS
68302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6831
6832 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6833 line. (Bug#9903)
6834
83ed7b5c
GM
68352011-10-29 Glenn Morris <rgm@gnu.org>
6836
6837 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6838 Not clear what it was for, and it causes various bugs. (Bug#9839)
6839
5a7a728b
EZ
68402011-10-28 Eli Zaretskii <eliz@gnu.org>
6841
6842 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6843 possible random value that matches one of those tested as
6844 condition to clear the mouse face.
6845
d3d0842f
CY
68462011-10-28 Chong Yidong <cyd@gnu.org>
6847
6848 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6849
31b39d13
DN
68502011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6851
6852 * window.c (make_window): Initialize phys_cursor_on_p.
6853
9aba6043
SM
68542011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6855
6856 * lisp.h (struct Lisp_Symbol): Update comments.
6857
c20992f4
JB
68582011-10-28 Juanma Barranquero <lekktu@gmail.com>
6859
6860 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6861
db4f02f2
EZ
68622011-10-28 Eli Zaretskii <eliz@gnu.org>
6863
6864 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6865 <oslsachem@gmail.com> for helping to debug this.
6866
6867 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6868 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6869 (g_b_init_get_glyph_outline_w): New static variables.
6870 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6871 (GetGlyphOutlineW_Proc): New typedefs.
6872 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6873 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6874 New functions.
6875 (w32font_open_internal, compute_metrics):
6876 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6877 instead of calling the "wide" APIs directly.
6878
6879 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6880
6881 * w32.h (syms_of_w32font): Add prototype.
6882
87e68db4
JB
68832011-10-27 Juanma Barranquero <lekktu@gmail.com>
6884
6885 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6886 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6887 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6888 (Fmove_to_window_line): Doc fix.
6889
435c1d67
CY
68902011-10-27 Chong Yidong <cyd@gnu.org>
6891
6892 * process.c (make_process): Set gnutls_state to NULL.
6893
6894 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6895 non-NULL, regardless of GNUTLS_INITSTAGE.
6896 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6897 an error. Set process slots as soon as we allocate them.
6898
6899 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6900
9c6c6f49
CY
69012011-10-27 Chong Yidong <cyd@gnu.org>
6902
9aba6043
SM
6903 * gnutls.c (emacs_gnutls_deinit): New function.
6904 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6905 (Fgnutls_deinit, Fgnutls_boot): Use it.
6906
6907 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6908 (deactivate_process): Call emacs_gnutls_deinit.
6909
657d08d3
JB
69102011-10-27 Juanma Barranquero <lekktu@gmail.com>
6911
6912 * image.c (x_create_x_image_and_pixmap):
6913 * w32.c (sys_rename, w32_delayed_load):
6914 * w32font.c (fill_in_logfont):
6915 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6916
5430d399
JB
69172011-10-26 Juanma Barranquero <lekktu@gmail.com>
6918
6919 * w32fns.c (w32_default_color_map): New function,
6920 extracted from Fw32_default_color_map.
a7ef684b 6921 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6922
fe0055fa
PE
69232011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6924
6925 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6926
e6346438
SM
69272011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6928
6929 * keyboard.c (test_undefined): New function (bug#9751).
6930 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6931
e112cc37
ET
69322011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6933
6934 * sysdep.c (init_sys_modes): Fix the check for the controlling
6935 terminal (Bug#6649).
6936
7b5d6677
EZ
69372011-10-20 Eli Zaretskii <eliz@gnu.org>
6938
6939 * dispextern.h (struct bidi_it): New member next_en_type.
6940
6941 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6942 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6943 current character, check also for next_en_type being WEAK_EN.
6944 (bidi_resolve_weak): Don't enter the expensive loop if the current
6945 position is before next_en_pos. Record the bidi type of the first
6946 non-ET, non-BN character we find, in addition to its position.
6947 (bidi_level_of_next_char): Invalidate next_en_type when
6948 next_en_pos is over-stepped.
6949
7da0b018
PE
69502011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6951
6952 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6953 * editfns.c: Rewrite current-time-zone so that it invokes
6954 the equivalent of (format-time-string "%Z") to get the time zone name.
6955 This fixes a bug when the time zone name contains characters that
6956 need converting from the system time locale to Emacs internal format.
6957 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6958 that patch fixed format-time-string to do the conversion, but
6959 I forgot to fix current-time-zone.
6960 (format_time_string): New function, containing most of
6961 what Fformat_time_string used to contain.
6962 (Fformat_time_string): Rewrite in terms of format_time_string.
6963 This doesn't change this function's behavior.
6964 (current-time-zone): Rewrite to use format_time_string.
6965 This fixes the bug reported by Michael Schierl in
6966 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6967 Jason Rumney's 2007-06-07 change worked around this bug, but
6968 didn't fix it.
6969 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6970
8547b010
EZ
69712011-10-19 Eli Zaretskii <eliz@gnu.org>
6972
6973 * xdisp.c (start_display): If the character at POS is displayed
6974 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6975 (try_window_reusing_current_matrix): If a line ends in a display
6976 vector or the next line starts in a display vector, continue
6977 redrawing the window even though the character position of
6978 start_row was reached.
8547b010
EZ
6979 (Bug#9771, part 2)
6980
4e948d15
CY
69812011-10-18 Chong Yidong <cyd@gnu.org>
6982
6983 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6984 with nobreak-char-display too.
6985
4787455f
EZ
69862011-10-18 Eli Zaretskii <eliz@gnu.org>
6987
6988 Fix part 3 of bug#9771.
6989 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6990 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6991 non-neutral characters if the current character is a paragraph
6992 separator (a.k.a. Newline). This avoids running the same
6993 expensive loop twice, once when we consume the preceding newline
6994 and the other time when the line actually needs to be displayed.
6995 Avoid the loop when we see neutrals on the base embedding level
6996 following a character whose directionality is the same as the
6997 paragraph's. This avoids running the expensive loop when a line
6998 ends in a long sequence of neutrals, like control characters.
6999 Add assertion against STRONG_AL type. Slightly rearrange code
7000 that determines the type of a neutral given the first non-neutral
7001 that follows it.
7002 (bidi_level_of_next_char): Set next_en_pos to zero when
7003 invalidating its info.
7004
2c91f553
EZ
70052011-10-17 Eli Zaretskii <eliz@gnu.org>
7006
7007 * xdisp.c (push_display_prop): Determine whether to record string
7008 or buffer position by IT->string, not by IT->method. Allow
7009 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7010 (move_it_vertically_backward): Don't look for character position
7011 immediately after the newline when in a continuation line.
7012 (Bug#9771, part 1)
2c91f553 7013
c7b08b0d
MR
70142011-10-15 Martin Rudalics <rudalics@gmx.at>
7015
7016 * window.c (coordinates_in_window): Rewrite and delabelize
7017 vertical border check. (Bug#5357) (Bug#9618)
7018
6b02f655
SM
70192011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7020
7021 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7022 errors in XSetWindowBorder (bug#9310).
7023
81d40c92
DA
70242011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7025
7026 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7027 avoid crash when xmalloc overrun checking is enabled.
7028
d4172c3b
EZ
70292011-10-13 Eli Zaretskii <eliz@gnu.org>
7030
7031 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7032 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7033 cursor motion with <left> and <right> arrow keys.
7034
7035 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7036 some callers set that themselves.
7037
b00eea75
EZ
70382011-10-12 Eli Zaretskii <eliz@gnu.org>
7039
7040 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7041 display string and the previous row comes from the same string and
7042 is empty. (Bug#9739) (Bug#9738)
7043
8fe012c4
SM
70442011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7045
7046 * doc.c (get_doc_string): Encode file name (bug#9735).
7047
0074aef2
EZ
70482011-10-12 Eli Zaretskii <eliz@gnu.org>
7049
79beb178
EZ
7050 * bidi.c (bidi_level_of_next_char):
7051 * xdisp.c (get_visually_first_element): Remove old incorrect
7052 comments regarding the Unicode Line Separator character.
7053
0074aef2
EZ
7054 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7055
6e4b3fbe
DA
70562011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7057
7058 * alloc.c (Fgc_status): Do not access beyond zombies array
7059 boundary if nzombies > MAX_ZOMBIES.
7060 * alloc.c (dump_zombies): Add missing format specifier.
7061
0324f3af
PE
70622011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7063
b5525cac
PE
7064 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7065 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7066
0324f3af
PE
7067 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7068 Some packages use them to denote characters with modifiers.
7069
e9b5f888
AS
70702011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7071
7072 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7073 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7074 matching a pp-number. Rename parameter var to var1.
7075
127827c0
SM
70762011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7077
7078 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7079
c8fd3bd0
GM
70802011-10-08 Glenn Morris <rgm@gnu.org>
7081
7082 * callint.c (Fcall_interactively): Give a more explicit error for the
7083 'c' case with a non-character input. (Bug#8479)
7084
352ec8ff
EZ
70852011-10-08 Eli Zaretskii <eliz@gnu.org>
7086
03669ccb
EZ
7087 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7088 lines.
7061c986
EZ
7089 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7090 lines that are hscrolled on the left.
03669ccb 7091
352ec8ff
EZ
7092 * dispnew.c (buffer_posn_from_coords): Account for a possible
7093 presence of header-line. (Bug#4426)
7094
a66cfb1c
SM
70952011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7096
6b02f655
SM
7097 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7098 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7099
7c5ee88e
PE
71002011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7101
7102 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7103 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7104 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7105 this makes Emacs dump core during garbage collection on rare
7106 occasions. sizeof is obviously inferior to offsetof here, so
7107 stick with offsetof.
7108 (GC_POINTER_ALIGNMENT): New macro.
7109 (mark_memory): Omit 3rd (offset) arg; caller changed.
7110 Don't assume EMACS_INT alignment is the same as pointer alignment.
7111
df1bbe5b
SM
71122011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7113
7114 * keyboard.c (read_key_sequence_remapped): New var.
7115 (read_key_sequence): Compute remapping in the right buffer.
7116 (command_loop_1): Use read_key_sequence's remapping directly.
7117
51553db6
SM
71182011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7119
32c1fffd
SM
7120 * dired.c (file_name_completion): Don't expand file name.
7121 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7122 before checking file name handler.
7123
51553db6
SM
7124 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7125 they've been requested explicitly (bug#9591).
7126
b6bd1599 71272011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7128
7129 * keymap.c (Fsingle_key_description): Use make_specified_string
7130 instead of build_string to build string from push_key_description.
7131 (Bug#5193)
7132
f701dc2a
PE
71332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7134
4222c55d
PE
7135 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7136 This fixes a Y2038 bug on 64-bit hosts.
7137 * buffer.c (reset_buffer):
7138 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7139 (Fclear_buffer_auto_save_failure):
7140 Use 0, not -1, to represent an unset failure time, since time_t
7141 might not be signed.
7142
f701dc2a
PE
7143 Remove dependency on glibc malloc internals.
7144 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7145 Move back here from lisp.h, but with their new implementations.
7146 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7147 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7148 * charset.c (charset_table_init): New static var.
7149 (syms_of_charset): Use it instead of xmalloc. This removes a
7150 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7151 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7152 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7153 Move back to alloc.c.
7154 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7155 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7156
9ceebf39
JD
71572011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7158
7159 * nsterm.m (windowDidResize): Call x_set_window_size only when
7160 ns_in_resize is true. Otherwise set pixelwidth/height and
7161 call change_frame_size (Bug#9628).
7162
cb993c58
PE
71632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7164
3930c88b
PE
7165 Port --enable-checking=all to Fedora 14 x86-64.
7166 * charset.c (syms_of_charset): Also account for glibc malloc's
7167 internal overhead when calculating the initial malloc maximum.
7168
cb993c58
PE
7169 Port --enable-checking=all to Fedora 14 x86.
7170 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7171 Move to lisp.h.
7172 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7173 (overrun_check_realloc, overrun_check_free):
7174 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7175 That way, xmalloc returns a properly-aligned pointer even if
7176 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7177 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7178 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7179 into account when calculating the initial malloc maximum.
7180 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7181 Move here from alloc.c, so that charset.c can use it too.
7182 Properly align; the old code wasn't right for common 32-bit hosts
7183 when configured with --enable-checking=all.
7184 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7185 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7186
31bed486
EZ
71872011-09-29 Eli Zaretskii <eliz@gnu.org>
7188
04c70788 7189 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7190 use EDOM.
7191
fbcaa2f3
EZ
71922011-09-28 Eli Zaretskii <eliz@gnu.org>
7193
7194 * xdisp.c (compute_display_string_end): If there's no display
7195 string at CHARPOS, return -1.
7196
7197 * bidi.c (bidi_fetch_char): When compute_display_string_end
7198 returns a negative value, treat the character as a normal
7199 character not covered by a display string. (Bug#9624)
7200
a239d4e9
JB
72012011-09-28 Juanma Barranquero <lekktu@gmail.com>
7202
7203 * lread.c (Fread_from_string): Fix typo in docstring.
7204
88652fd5
EZ
72052011-09-27 Eli Zaretskii <eliz@gnu.org>
7206
7207 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7208 newline, reseat the iterator instead of bidi-iterating there one
7209 character at a time. (Bug#9610)
32c1fffd
SM
7210 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7211 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7212
ed497dd4
AS
72132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7214
7215 * lread.c (readevalloop): Use correct code for NBSP.
7216 (read1): Likewise. (Bug#9608)
7217
b2bf61aa
MA
72182011-09-25 Michael Albinus <michael.albinus@gmx.de>
7219
7220 * dbusbind.c (Fdbus_register_signal): When service is not
7221 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7222
32bbb17c
GM
72232011-09-25 Glenn Morris <rgm@gnu.org>
7224
7225 * buffer.c (truncate-lines): Doc fix.
7226
94e0933e
CY
72272011-09-24 Chong Yidong <cyd@stupidchicken.com>
7228
7229 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7230 (Fset_window_next_buffers): Doc fix.
7231
cddde921
GM
72322011-09-24 Glenn Morris <rgm@gnu.org>
7233
7234 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7235
1260aef1
PE
72362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7237
25b4bfa0
PE
7238 Fix minor problems found by static checking.
7239 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7240 * indent.c (Fvertical_motion): Fix == vs = typo.
7241
e3cbd34b
EZ
72422011-09-24 Eli Zaretskii <eliz@gnu.org>
7243
a66cfb1c
SM
7244 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7245 Default value is now t. Doc fix.
6bf7006f 7246
e3cbd34b 7247 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7248 logic when moving up, not only when moving down. Fix the
e3cbd34b 7249 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7250 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7251
7252 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7253 CHARPOS is covered by a display string which includes newlines.
7254 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7255 is covered by a display string with embedded newlines.
7256
a3de0cbd
MA
72572011-09-24 Michael Albinus <michael.albinus@gmx.de>
7258
7259 * dbusbind.c (Fdbus_register_signal): Add match rule to
7260 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7261 (Fdbus_register_method, Vdbus_registered_objects_table):
7262 Fix docstring.
a3de0cbd 7263
b260039d
JM
72642011-09-24 Jim Meyering <meyering@redhat.com>
7265
32c1fffd 7266 do not ignore write error for any output size
b260039d
JM
7267 The previous change was incomplete.
7268 While it makes emacs --batch detect the vast majority of stdout
7269 write failures, errors were still ignored whenever the output size is
7270 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7271 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7272 && echo FAIL: ignored write error
7273 FAIL: ignored write error
7274 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7275 && echo FAIL: ignored write error
7276 FAIL: ignored write error
7277 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7278
8eca8a7c
AS
72792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7280
7281 * emacs.c (Fkill_emacs): In noninteractive mode exit
7282 non-successfully if a write error occurred on stdout. (Bug#9574)
7283
3341db62
EZ
72842011-09-21 Eli Zaretskii <eliz@gnu.org>
7285
7286 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7287 the xassert test.
7288
7289 * dispextern.h (struct it): Update the comment documenting what
7290 can it->OBJECT be.
7291
8c203dbf
EZ
72922011-09-20 Eli Zaretskii <eliz@gnu.org>
7293
7294 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7295 a display string, extend search for cursor position to end of row.
7296 (find_row_edges): If the row ends in a newline from a display
7297 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7298 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7299 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7300 non-empty line. Fixes confusing cursor motion with arrow keys at
7301 the beginning of a line that starts with whitespace.
8c203dbf 7302
a4824228
LMI
73032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7304
7305 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7306 (bug#9493).
7307
33ed493b
CY
73082011-09-18 Chong Yidong <cyd@stupidchicken.com>
7309
7310 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7311 boolean (Bug#9154).
7312
56cd55c8
EZ
73132011-09-18 Eli Zaretskii <eliz@gnu.org>
7314
7315 * xdisp.c (display_line): Record maximum and minimum buffer
7316 positions even if no glyphs were produced (e.g., by a zero-width
7317 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7318 buffer positions that will be removed from the glyph row because
7319 they don't fit.
c02dcedf
EZ
7320 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7321 column is beyond frame width: don't subtract 1 "pixel" when
7322 computing width of the stretch.
3e62b7e0
EZ
7323 (reseat_at_next_visible_line_start): Undo the change made on
7324 2011-09-17 that saved paragraph information and restored it after
7325 the call to `reseat'. (Bug#9545)
56cd55c8 7326
5ed99d36 73272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7328
7329 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7330 and turn window cursor on if cleared (Bug#9415).
7331
5ed99d36 73322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7333
7334 * search.c (boyer_moore): Take unibyte characters from pattern
7335 literally. (Bug#9458)
7336
9bade7b2
EZ
73372011-09-18 Eli Zaretskii <eliz@gnu.org>
7338
7339 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7340
e5e9d610
PE
73412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7342
87e4427a
PE
7343 Fix minor problem found by static checking.
7344 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7345 initialized, to pacify gcc -Wuninitialized.
7346
e5e9d610
PE
7347 * fileio.c: Report proper errno when syscall falls.
7348 (Finsert_file_contents): Save and restore errno,
7349 so that report_file_error outputs the correct diagnostic.
7350 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7351
a1674f0b
EZ
73522011-09-18 Eli Zaretskii <eliz@gnu.org>
7353
7354 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7355
fbfb6dd4
EZ
73562011-09-17 Eli Zaretskii <eliz@gnu.org>
7357
7358 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7359 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7360
bb187662
EZ
73612011-09-17 Eli Zaretskii <eliz@gnu.org>
7362
1137e8b8 7363 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7364 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7365
7366 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7367 (bidi_find_paragraph_start): Search back for paragraph beginning
7368 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7369 (bidi_move_to_visually_next): Only trigger paragraph-related
7370 computations when the last character is a newline or at EOB, not
7371 just any NEUTRAL_B. (Bug#9470)
7372
bb187662
EZ
7373 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7374 truncated lines if point is covered by a display string. (Bug#9524)
7375
2e621251
PE
73762011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7377
7378 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7379 (cons_to_x_long): New function.
7380 (lisp_data_to_selection_data): Use it. Correct the test for
7381 short-versus-long data; it was negated. Break out of vector
7382 loop, for efficiency, when a long datum is discovered.
7383
91a15bc6
SM
73842011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7385
7386 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7387
b41c3a35
EZ
73882011-09-16 Eli Zaretskii <eliz@gnu.org>
7389
7390 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7391 GCC PR/17406) by declaring this function with external scope.
7392
7812ba2d
PE
73932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7394
7395 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7396 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7397
cf7edc2a
AS
73982011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7399
7400 * editfns.c (Fformat): Correctly handle text properties on "%%".
7401
bd01620e
EZ
74022011-09-15 Eli Zaretskii <eliz@gnu.org>
7403
7404 * xterm.c (x_draw_composite_glyph_string_foreground):
7405 * w32term.c (x_draw_composite_glyph_string_foreground):
7406 * term.c (encode_terminal_code):
7407 * composite.c (composition_update_it, get_composition_id):
7408 * xdisp.c (get_next_display_element)
7409 (fill_composite_glyph_string): Add comments about special meaning
7410 of TAB characters in a composition.
7411
a02719a3
PE
74122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7413
7414 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7415 This occurs when processing a multibyte format.
7416 Problem reported by Wolfgang Jenker.
a02719a3 7417
72589a3c
JB
74182011-09-15 Johan Bockgård <bojohan@gnu.org>
7419
7420 * xdisp.c (try_cursor_movement): Only check for exact match if
7421 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7422
1c14176c
PE
74232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7424
7425 Remove unused external symbols.
7426 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7427 * xdisp.c (calc_pixel_width_or_height): Now static.
7428 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7429 * indent.c (check_display_width):
7430 * w32term.c: Fix comment to match code.
7431 * xterm.c, xterm.h (x_catching_errors): Remove.
7432
d2eea5b5
PE
74332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7434
7435 * xselect.c: Use signed conversions more consistently (Bug#9498).
7436 (selection_data_to_lisp_data): Assume incoming selection data are
7437 signed integers, not unsigned. This is to be consistent with
7438 outgoing selection data, which was modified to use signed integers
7439 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7440 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7441 expects long, not unsigned long.
7442
46888499
EZ
74432011-09-14 Eli Zaretskii <eliz@gnu.org>
7444
7445 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7446 computation of loop end. Reported by Johan Bockgård
7447 <bojohan@gnu.org>.
7448
ef8ef9fb
CY
74492011-09-13 Chong Yidong <cyd@stupidchicken.com>
7450
7451 * frame.c (Fother_visible_frames_p): Function deleted.
7452
fa819fed
EZ
74532011-09-12 Eli Zaretskii <eliz@gnu.org>
7454
7455 * indent.c (compute_motion): Process display vector front to back
7456 rather than the other way around. (Bug#2496)
7457
2ba8e008
SM
74582011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7459
7460 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7461
20f53c69
CY
74622011-09-11 Chong Yidong <cyd@stupidchicken.com>
7463
7464 * minibuf.c (Fread_from_minibuffer): Doc fix.
7465
d562d7a4
EZ
74662011-09-11 Eli Zaretskii <eliz@gnu.org>
7467
7468 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7469 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7470
1c4d7f3d
LMI
74712011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7472
7473 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7474 value for non-existent files.
7475
b885bf36
EZ
74762011-09-11 Eli Zaretskii <eliz@gnu.org>
7477
7478 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7479 set its "size" to -1. This will set the modtime_size field of
7480 the corresponding buffer to -1, which is what
7481 verify-visited-file-modtime expects for files that do not exist.
7482 (Bug#9139)
7483
6612f0bf
PE
74842011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7485
7486 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7487 here ...
7488 * lisp.h: ... from here. push_key_description is no longer
7489 defined in keyboard.c, so its declaration should not be in
7490 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7491 logically belongs with push_key_description.
7492
dfb3f755
PE
74932011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7494
7495 * buffer.h: Include <sys/types.h> instead of <time.h>.
7496 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7497 Problem reported by Herbert J. Skuhra.
7498
3134906c
LMI
74992011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7500
7501 * xml.c (parse_region): Make the parsing work for
7502 non-comment-starting XML files again (bug#9144).
7503
8d903f4e
AS
75042011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7505
7506 * image.c (gif_load): Fix calculation of bottom and right corner.
7507 (Bug#9468)
7508
80ad64f4
EZ
75092011-09-10 Eli Zaretskii <eliz@gnu.org>
7510
7511 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7512 redisplay in small windows.
7513
208a048d
EZ
75142011-09-09 Eli Zaretskii <eliz@gnu.org>
7515
7516 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7517
9b1c252e
MR
75182011-09-08 Martin Rudalics <rudalics@gmx.at>
7519
7520 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7521 Operate on live windows only.
7522
2949f33b
JB
75232011-09-08 Juanma Barranquero <lekktu@gmail.com>
7524
7525 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7526
e08dcafd
EZ
75272011-09-07 Eli Zaretskii <eliz@gnu.org>
7528
7529 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7530 only under bidi iteration.
7531
115b96bd
JD
75322011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7533
7534 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7535
c8199d0f
PE
75362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7537
7538 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7539 Without this fix, the command to link temacs failed due to an
7540 undefined symbol __builtin_isnan. This is because
7541 /usr/include/iso/math_c99.h #defines isnan(x) to
7542 __builtin_isnan(x), but the bundled gcc, which identifies itself
7543 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7544 a __builtin_isnan.
7545 * floatfns.c (isnan): #undef, and then #define to a clone of
7546 what's in data.c.
7547 (Fisnan): Always define, since it's always available now.
7548 (syms_of_floatfns): Always define isnan at the Lisp level.
7549
e39b275c 75502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7551
7552 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7553
b2db44d9 75542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7555
f4af5137 7556 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7557 The previous code assumed that file offsets (off_t values) fit in
7558 EMACS_INT variables, which is not true on typical 32-bit hosts.
7559 The code messed up by falsely reporting buffer overflow in cases
7560 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7561 when "big" contains more than 2**29 bytes, even though this
7562 inserts just one byte and does not overflow the buffer.
7563 (Finsert_file_contents): Store file offsets as off_t
7564 values, not as EMACS_INT values. Check for overflow when
7565 converting between EMACS_INT and off_t. When checking for
7566 buffer overflow or for overlap, take the offsets into account.
7567 Don't use EMACS_INT for small values where int suffices.
7568 When checking for overlap, fix a typo: ZV was used where
7569 ZV_BYTE was intended.
7570 (Fwrite_region): Don't assume off_t fits into 'long'.
7571 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7572
ecfc0a49
MA
75732011-09-05 Michael Albinus <michael.albinus@gmx.de>
7574
7575 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7576
6511acf2 75772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7578
0999621a 7579 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7580
7581 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7582 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7583 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7584 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7585 (modify_event_symbol): Do not assume that the length of
7586 name_alist_or_stem is safe to alloca and fits in int.
7587 (Fexecute_extended_command): Likewise for function name and binding.
7588 (Frecursion_depth): Wrap around reliably on integer overflow.
7589 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7590 since some callers pass EMACS_INT values.
7591 (Fsingle_key_description): Don't crash if symbol name contains more
7592 than MAX_ALLOCA bytes.
7593 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7594 (get_minibuffer): Arg is now EMACS_INT, not int.
7595 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7596 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7597 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7598
2be7d702
PE
7599 * dbusbind.c (signature_cat): New function.
7600 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7601 Do not overrun buffer; instead, report string overflow.
7602
9d1df220
PE
7603 * dispnew.c (add_window_display_history): Don't overrun buffer.
7604 Truncate instead; this is OK since it's just a log.
7605
33ef5c64
PE
7606 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7607 even if the time zone offset is outlandishly large.
7608 Don't mishandle offset == INT_MIN.
7609
66c6fdd5
PE
7610 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7611 when creating daemon; the previous buffer-overflow check was incorrect.
7612
d749b01b
PE
7613 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7614 which has the guts of the old verror function.
7615
b5cd1905
PE
7616 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7617 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7618
6e1a67fb
PE
7619 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7620 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7621 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7622 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7623 length of string rather than counting it via multiple sprintfs;
7624 that's simpler and more reliable.
c21721cc
PE
7625 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7626 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7627 sprintf, in case result does not fit in int.
7628
c57b67fc
PE
7629 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7630 (fontset_from_font): Print it.
7631
8a401434
PE
7632 * frame.c (tty_frame_count): Now printmax_t, not int.
7633 (make_terminal_frame, set_term_frame_name): Print it.
7634 (x_report_frame_params): In X, window IDs are unsigned long,
7635 not signed long, so print them as unsigned.
7636 (validate_x_resource_name): Check for implausibly long names,
7637 and don't assume name length fits in 'int'.
7638 (x_get_resource_string): Don't blindly alloca invocation name;
7639 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7640 not fit in int.
7641
6e1a67fb
PE
7642 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7643 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7644 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7645
0df02bf3
PE
7646 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7647 Use esprintf, not sprintf, in case result does not fit in int.
7648
48e30793
PE
7649 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7650 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7651 it as a large positive number.
7652 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7653 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7654
a66ff6d8
PE
7655 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7656 in case result does not fit in int.
7657
aca216ff
PE
7658 * print.c (float_to_string): Detect width overflow more reliably.
7659 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7660 buffer overrun. Don't assume list length fits in 'int'. Treat
7661 print length of 0 as 0, not as infinity; to be consistent with other
7662 uses of print length in this function. Don't overflow print length
7663 index. Don't assume hash table size fits in 'long', or that
7664 vectorlike size fits in 'unsigned long'.
7665
31c286f7
PE
7666 * process.c (make_process): Use printmax_t, not int, to format
7667 process-name gensyms.
7668
55e5faa1
PE
7669 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7670
80f2e268
PE
7671 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7672 to avoid potential buffer overrun.
7673
670741ab
PE
7674 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7675 if X resource line is longer than 512 bytes.
7676
b7163a50
PE
7677 * xfns.c (x_window): Make sprintf buffer a bit bigger
7678 to avoid potential buffer overrun.
7679
ae58ff1f
PE
7680 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7681
c43c8a6a
PE
7682 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7683
3f8236f4
PE
76842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7685
53e9fe90 7686 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7687 Without these, Emacs silently mishandles large integers sometimes.
7688 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7689 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7690
6511acf2
PE
7691 * xdisp.c (try_window_id): Check Emacs fixnum range before
7692 converting to 'int'.
806add1d 7693
6511acf2 7694 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7695 Check that an Emacs fixnum is in range before assigning it to 'int'.
7696 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7697 values converted from Emacs fixnums.
7698 (Frecenter): Don't wrap around a line count if it is out of 'int'
7699 range; instead, treat it as an extreme value.
7700 (Fset_window_configuration, compare_window_configurations):
7701 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7702
6511acf2
PE
7703 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7704 that can exceed INT_MAX. Check that EMACS_INT value is in range
7705 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7706 (match_limit): Don't assume that a fixnum can fit in 'int'.
7707
6511acf2 7708 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7709 exceed INT_MAX.
7710
6511acf2 7711 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7712 (Fvertical_motion): Don't wrap around LINES values that don't fit
7713 in 'int'. Instead, treat them as extreme values. This is good
7714 enough for windows, which can't have more than INT_MAX lines anyway.
7715
fcb901a7
LMI
77162011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7717
0f2f6b6d
LMI
7718 * Require libxml/parser.h to avoid compilation warning.
7719
fcb901a7
LMI
7720 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7721
7722 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7723 since this reportedly can destroy thread storage.
7724
6e20a0d4
CY
77252011-08-30 Chong Yidong <cyd@stupidchicken.com>
7726
7727 * syntax.c (find_defun_start): Update all cache variables if
7728 exiting early (Bug#9401).
7729
148ae00e
EZ
77302011-08-30 Eli Zaretskii <eliz@gnu.org>
7731
f6cfbd8f
EZ
7732 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7733
148ae00e
EZ
7734 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7735 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7736 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7737
7738 * term.c (tty_append_glyph): New function.
7739 (produce_stretch_glyph): Static function and its prototype deleted.
7740
a66cfb1c
SM
7741 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7742 Add prototypes.
148ae00e 7743
c4a07a4c
PE
77442011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7745
7746 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7747 when checking :margin (Bug#9390).
7748 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7749 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7750 so that the name doesn't mislead. All uses changed.
7751
6bc8cd65
JB
77522011-08-28 Johan Bockgård <bojohan@gnu.org>
7753
7754 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7755 set_tty_hooks.
7756
dca4927e
EZ
77572011-08-27 Eli Zaretskii <eliz@gnu.org>
7758
7759 * xdisp.c (move_it_to): Don't bail out early when reaching
7760 position beyond to_charpos, if we are scanning backwards.
7761 (move_it_vertically_backward): When DY == 0, make sure we get to
7762 the first character in the line after the newline.
7763
f2cad773
PE
77642011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7765
7766 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7767 (ccl_driver): Do not generate an out-of-range pointer.
7768 (Fccl_execute_on_string): Remove unnecessary check for
7769 integer overflow, noted by Stefan Monnier in
7770 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7771 Remove a FIXME that didn't need fixing.
7772 Simplify the newly-introduced buffer reallocation code.
7773
0cae2cdb
JB
77742011-08-27 Juanma Barranquero <lekktu@gmail.com>
7775
7776 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7777
5fc295a4 77782011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7779
70c60eb2 7780 Integer and memory overflow issues (Bug#9196).
726e0ab1 7781
d31850da
PE
7782 * doc.c (get_doc_string): Rework so that
7783 get_doc_string_buffer_size is the actual buffer size, rather than
7784 being 1 less than the actual buffer size; this makes xpalloc more
7785 convenient.
7786
a69fbedb
PE
7787 * image.c (x_allocate_bitmap_record, cache_image):
7788 * xselect.c (Fx_register_dnd_atom):
7789 Simplify previous changes by using xpalloc.
7790
fe5c5d37
PE
7791 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7792 since either will do and ptrdiff_t is convenient with xpalloc.
7793
0065d054
PE
7794 * charset.c (charset_table_size)
7795 (struct charset_sort_data.priority): Now ptrdiff_t.
7796 (charset_compare): Don't overflow if priorities differ greatly.
7797 (Fsort_charsets): Don't assume list length fits in int.
7798 Check for size-calculation overflow when allocating sort data.
7799 (syms_of_charset): Allocate an initial charset table that is
7800 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7801
7802 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7803
7804 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7805 The actual value is always <= INT_MAX, and leaving it unsigned made
7806 overflow checking harder.
7807
7808 * dispextern.h (struct glyph_matrix.rows_allocated)
7809 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7810 with xpalloc. The values are still always <= INT_MAX.
7811
7812 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7813
7814 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7815 (SAFE_NALLOCA): New macro.
7816
7817 * region-cache.c (struct boundary.pos, find_cache_boundary)
7818 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7819 (set_cache_region, invalidate_region_cache)
7820 (revalidate_region_cache, know_region_cache, region_cache_forward)
7821 (region_cache_backward, pp_cache):
7822 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7823 so that ptrdiff_t * can be passed to xpalloc.
7824 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7825 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7826 (pp_cache): Don't assume cache_len fits in int.
7827 * region-cache.h: Adjust extern decls to match.
7828
7829 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7830 EMACS_INT, since either will do, for xpalloc.
7831
7832 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7833 (xnmalloc, xnrealloc, xpalloc): New functions.
7834
726e0ab1
PE
7835 * bidi.c (bidi_shelve_header_size): New constant.
7836 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7837 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7838
51f30bc5 7839 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7840 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7841 (overlay_strings):
7842 Don't update size of array until after memory allocation succeeds,
7843 because xmalloc/xrealloc may not return.
0065d054
PE
7844 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7845 now that we have proper integer overflow checking.
7846 (record_overlay_string, overlay_strings): Catch overflows when
7847 calculating size of overlay_str_buf.
726e0ab1 7848
0065d054
PE
7849 * callproc.c (Fcall_process): Check for size overflow when
7850 calculating size of args2.
7851 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7852 Normally we prefer signed values, but sticking with ptrdiff_t would
7853 require adding more-complicated checks.
726e0ab1
PE
7854
7855 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7856 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7857 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7858 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7859
7860 * character.c (Fstring): Check for size-calculation overflow.
7861
7862 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7863 unnecessary integer overflow. Check for size overflow.
7864 (encode_coding_object): Don't update size until xmalloc succeeds.
7865
7866 * composite.c (get_composition_id): Check for overflow in glyph
7867 length calculations.
7868
7869 Integer and memory overflow fixes for display code.
7870 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7871 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7872 (scrolling_window): Check for overflow in size calculations.
7873 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7874 Don't assume glyph table len fits in int.
7875 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7876 (row_table_size): Now ptrdiff_t, not int.
7877 (scrolling_window): Avoid overflow in size calculations.
7878 Don't update size until allocation succeeds.
7879 * fns.c (concat): Check for overflow in size calculations.
7880 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7881 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7882 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7883
7884 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7885 (get_doc_string): Check for size calculation overflow.
7886 Don't update size until allocation succeeds.
7887 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7888 EMACS_INT, where ptrdiff_t will do.
7889 (Fsubstitute_command_keys): Check for string overflow.
7890
7891 * editfns.c (set_time_zone_rule): Don't assume environment length
7892 fits in int.
7893 (message_length): Now ptrdiff_t, not int.
7894 (Fmessage_box): Don't update size until allocation succeeds.
7895 Don't assume message length fits in int.
7896 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7897
0065d054
PE
7898 * emacs.c (main): Do not reallocate argv, since there is a null at
7899 the end that can be overwritten, and this way there's no need to
7900 worry about size-calculation overflow.
7901 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7902
7903 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7904 alloc succeeds.
7905 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7906
7907 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7908 (x_set_scroll_bar_width, x_figure_window_size):
7909 Check for integer overflow.
7910 (x_set_alpha): Do not assume XINT fits in int.
7911
7912 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7913 This is for the members text_lines, text_cols, total_lines, total_cols,
7914 where the system imposes an 'int' limit.
7915
7916 * fringe.c (Fdefine_fringe_bitmap):
7917 Don't update size until alloc works.
7918
7919 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7920 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7921
7922 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7923 Check for size-calculation overflow.
7924 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7925 do, as we prefer signed integers.
7926 (id_to_widget.max_size, id_to_widget.used)
7927 (xg_store_widget_in_map, xg_remove_widget_from_map)
7928 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7929 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7930 Use and return ptrdiff_t, not int.
7931 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7932 * gtkutil.h: Change prototypes to match the above.
7933
7934 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7935 are duplicate now that they've been promoted to lisp.h.
7936 (x_allocate_bitmap_record, x_alloc_image_color)
7937 (make_image_cache, cache_image, xpm_load):
7938 Don't update size until alloc is done.
7939 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7940 (x_detect_edges):
3256efce 7941 Check for size calculation overflow.
726e0ab1
PE
7942 (ct_colors_allocated_max): New constant.
7943 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7944 overflow.
3256efce 7945
726e0ab1
PE
7946 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7947 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7948 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7949 Use ptrdiff_t, not int, to count maps.
7950 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7951 calculations. Don't update size until allocation succeeds.
7952 Redo calculations to avoid overflow.
726e0ab1
PE
7953 * keyboard.h: Change prototypes to match the above.
7954
7955 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7956 to count maps.
7957 (current_minor_maps): Check for size calculation overflow.
7958 * keymap.h: Change prototypes to match the above.
7959
7960 * lread.c (read1, init_obarray): Don't update size until alloc done.
7961
7962 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7963 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7964
726e0ab1
PE
7965 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7966 Now ptrdiff_t, not int.
7967 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7968 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7969
7970 * process.c (Fnetwork_interface_list): Check for overflow
7971 in size calculation.
7972
7973 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7974
7975 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7976 overflow. Don't bother calling xmalloc when xrealloc will do.
7977
7978 * search.c (Freplace_match): Check for size calculation overflow.
7979 (Fset_match_data): Don't assume list lengths fit in 'int'.
7980
7981 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7982 for command line length. Do not attempt to address one before the
7983 beginning of an array, as that's not portable.
7984
7985 * term.c (max_frame_lines): Remove; unused.
7986 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7987 not int.
7988 (encode_terminal_code, calculate_costs): Check for size
7989 calculation overflow.
7990 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7991 table lengths and related sizes. Don't update size until alloc
7992 done. Redo calculations to avoid overflow.
7993 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7994
7995 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7996 subtracting pointers.
7997 (gobble_line): Check for overflow more carefully. Don't update size
7998 until alloc done.
7999
8000 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8001 Don't update size until alloc done.
8002 Redo size calculations to avoid overflow.
8003 Check for size calculation overflow.
0065d054 8004 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8005
8006 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8007 Use ptrdiff_t, not int, for sizes.
8008 (store_mode_line_noprop_char): Don't update size until alloc done.
8009
0065d054
PE
8010 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8011 Use ptrdiff_t, not int, for sizes.
8012 (Finternal_make_lisp_face, cache_face):
8013 Check for size calculation overflow.
8014 (cache_face): Treat size calculation overflows as if they were
8015 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8016
8017 * xfns.c (x_encode_text, x_set_name_internal)
8018 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8019 sizes, since they can exceed INT_MAX in size. Check for size
8020 calculation overflow.
8021
0065d054
PE
8022 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8023 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8024 Don't update size until alloc done.
8025
0065d054 8026 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8027 as sprintf is limited to int lengths.
1d526e2f 8028
252c5ee1
PE
8029 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8030 (X_LONG_MIN): New macros.
864d7ce7
PE
8031 Use them to make the following changes clearer.
8032 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8033 This change doesn't affect the value now, but it may help remind
8034 future maintainers not to raise the value too much later.
8035 (SELECTION_QUANTUM): Remove, replacing with ...
8036 (selection_quantum): ... new function, which avoids overflow.
8037 All uses changed.
8038 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8039 assumption that selection length fits in 'int'.
8040 (x_reply_selection_request, x_handle_selection_request)
8041 (x_get_window_property, receive_incremental_selection)
8042 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8043 (lisp_data_to_selection_data, clean_local_selection_data):
8044 Use ptrdiff_t, not int, to record length of selection.
8045 (x_reply_selection_request, x_get_window_property)
8046 (receive_incremental_selection, x_property_data_to_lisp):
8047 Redo calculations to avoid overflow.
8048 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8049 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8050 something.
8051 (x_get_window_property, receive_incremental_selection)
8052 (lisp_data_to_selection_data, x_property_data_to_lisp):
8053 Check for size-calculation overflow.
8054 (x_get_window_property, receive_incremental_selection)
8055 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8056 Don't store size until memory allocation succeeds.
8057 (x_get_window_property): Plug memory leak on memory exhaustion.
8058 Don't double-block input; malloc is safe here. Don't assume 2**34
8059 - 4 fits in unsigned long. Add an xassert to check
8060 XGetWindowProperty overflow. Be more careful about overflow
8061 calculations, and distinguish size from memory overflow better.
8062 (receive_incremental_selection): When tracing, don't assume
8063 unsigned int is less than INT_MAX.
8064 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8065 harmful) conversions of unsigned short to int.
8066 (lisp_data_to_selection_data): Don't assume that integers
8067 in the range -65535 through -1 fit in an X unsigned short.
8068 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8069 result parameters unless successful. Rely on cons_to_unsigned
8070 to report problems with elements; the old code wasn't right anyway.
8071 (x_check_property_data): Check for int overflow; we cannot use
8072 a wider type due to X limits.
8073 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8074
726e0ab1 8075 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8076
0065d054
PE
8077 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8078 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8079 (x_color_cells): Don't store size until memory allocation succeeds.
8080 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8081 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8082 (x_term_init): Don't assume length fits in int (sprintf is limited
8083 to int size).
bc18e09d 8084
ebfa62c0
PE
8085 Use ptrdiff_t for composition IDs.
8086 * character.c (lisp_string_width):
8087 * composite.c (composition_table_size, n_compositions)
8088 (get_composition_id, composition_gstring_from_id):
8089 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8090 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8091 * window.c (Frecenter):
8092 Use ptrdiff_t, not int, for composition IDs.
8093 * composite.c (get_composition_id): Check for integer overflow.
8094 * composite.h: Adjust prototypes to match the above changes.
8095
d3411f89
PE
8096 Use ptrdiff_t for hash table indexes.
8097 * category.c (hash_get_category_set):
8098 * ccl.c (ccl_driver):
8099 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8100 * coding.c (coding_system_charset_list, detect_coding_system):
8101 * coding.h (struct coding_system.id):
8102 * composite.c (get_composition_id, gstring_lookup_cache):
8103 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8104 * image.c (xpm_get_color_table_h):
8105 * lisp.h (hash_lookup, hash_put):
8106 * minibuf.c (Ftest_completion):
8107 Use ptrdiff_t for hash table indexes, not int (which is too
8108 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8109 32-bit --with-wide-int hosts).
8110
e097a6fa
PE
8111 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8112 Add a FIXME comment about memory leaks.
8113 (syms_of_charset): Don't assume xmalloc returns.
8114
5637687f
PE
8115 Don't assume that stated character widths fit in int.
8116 * character.c (Fchar_width, c_string_width, lisp_string_width):
8117 * character.h (CHAR_WIDTH):
8118 * indent.c (MULTIBYTE_BYTES_WIDTH):
8119 Use sanitize_char_width to avoid undefined and/or bad behavior
8120 with outlandish widths.
a66cfb1c 8121 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8122 now that we have two such functions. All uses changed.
8123 (sanitize_char_width): New inline function.
8124
a2271ba2
PE
8125 Don't assume that tab-width fits in int.
8126 * character.h (sanitize_width): New inline function.
8127 (SANE_TAB_WIDTH): New macro.
8128 (ASCII_CHAR_WIDTH): Use it.
8129 * indent.c (sane_tab_width): Remove. All uses replaced by
8130 SANE_TAB_WIDTH (current_buffer).
8131 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8132
18c52557
PE
8133 * fileio.c: Integer overflow issues with file modes.
8134 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8135
caeeedc1
PE
8136 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8137 Remove unreachable code.
8138 (read_hex, load_charset_map_from_file): Check for integer overflow.
8139
6df6ae42 8140 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8141 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8142 (x_send_scroll_bar_event): Likewise. Check that the size does not
8143 exceed limits imposed by XClientMessageEvent, as well as the usual
8144 ptrdiff_t and size_t limits.
8145
b13995db
PE
8146 * keyboard.c: Overflow, signedness and related fixes.
8147 (make_lispy_movement): Use same integer type in forward decl
8148 that is used in the definition.
8149 (read_key_sequence, keyremap_step):
8150 Change bufsize argument back to int, undoing my 2011-03-30 change.
8151 We prefer signed types, and int is wide enough here.
8152 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8153 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8154 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8155 length, not size_t. Use ptrdiff_t for index, not int.
8156 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8157 possibility of integer overflow.
8158
13464394
PE
8159 Overflow, signedness and related fixes for images.
8160
8161 * dispextern.h (struct it.stack[0].u.image.image_id)
8162 (struct_it.image_id, struct image.id, struct image_cache.size)
8163 (struct image_cache.used, struct image_cache.ref_count):
8164 * gtkutil.c (update_frame_tool_bar):
8165 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8166 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8167 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8168 * nsmenu.m (update_frame_tool_bar):
8169 * xdisp.c (calc_pixel_width_or_height):
8170 * xfns.c (image_cache_refcount):
8171 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8172 on typical 64-bit hosts.
8173
8174 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8175 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8176 Omit unnecessary casts to int.
8177 (parse_image_spec): Check that integers fall into 'int' range
8178 when the callers expect that.
8179 (image_ascent): Redo ascent calculation to avoid int overflow.
8180 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8181 (lookup_image): Remove unnecessary tests.
8182 (xbm_image_p): Locals are now of int, not EMACS_INT,
8183 since parse_image_check makes sure they fit into int.
8184 (png_load, gif_load, svg_load_image):
8185 Prefer int to unsigned where either will do.
8186 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8187 old tiff_error_handler and tiff_warning_handler.
8188 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8189 stack buffer overflows. It uses only the features of vsnprintf
8190 that are common to both POSIX and native Microsoft.
8191 (tiff_error_handler, tiff_warning_handler): Use it.
8192 (tiff_load, gif_load, imagemagick_load_image):
8193 Don't assume :index value fits in 'int'.
8194 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8195 (imagemagick_load_image): Check that crop parameters fit into
8196 the integer types that MagickCropImage accepts. Don't assume
8197 Vimagemagick_render_type has a nonnegative value. Don't assume
8198 size_t fits in 'long'.
8199 (gs_load): Use printmax_t to print the widest integers possible.
8200 Check for integer overflow when computing image height and width.
8201
c11821d4
EZ
82022011-08-26 Eli Zaretskii <eliz@gnu.org>
8203
8204 * xdisp.c (redisplay_window): Don't force window start if point
8205 will be invisible in the resulting window. (Bug#9324)
8206
0c95fcf7
EZ
82072011-08-25 Eli Zaretskii <eliz@gnu.org>
8208
8209 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8210 the display spec is of the form `(space ...)'.
8211 (handle_display_spec): Return the value returned by
8212 handle_single_display_spec, not just 1 or zero.
8213 (handle_single_display_spec): If the display spec is of the form
8214 `(space ...)', and specifies display in the text area, return 2
8215 rather than 1.
fee65a97 8216 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8217 accurately, and prefer exact match for point under bidi.
8218 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8219
8220 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8221 into disp_prop; all users changed.
8222
8223 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8224 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8225 for the text covered by the display property.
8226
e4ed06f1
CY
82272011-08-25 Chong Yidong <cyd@stupidchicken.com>
8228
8229 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8230 Change return value to nil.
8231 (Frecord_buffer): Delete unused function.
8232
f67cdd7f
EZ
82332011-08-24 Eli Zaretskii <eliz@gnu.org>
8234
5980d4c6
EZ
8235 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8236 buffers, return left-to-right.
8610fe8b
EZ
8237 (set_cursor_from_row): Consider candidate row a win if its glyph
8238 represents a newline and point is on that newline. Fixes cursor
8239 positioning on the newline at EOL of R2L text within L2R
8240 paragraph, and vice versa.
8241 (try_cursor_movement): Check continued rows, in addition to
8242 continuation rows. Fixes unwarranted scroll when point enters a
8243 continued line of R2L text within an L2R paragraph, or vice versa.
8244 (cursor_row_p): Consider the case of point being equal to
8245 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8246 from the end of a short line to the beginning of a continued line
8247 of R2L text within L2R paragraph.
8248 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8249 composed characters.
5980d4c6 8250
f67cdd7f
EZ
8251 * bidi.c (bidi_check_type): Use xassert.
8252 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8253 members.
8254
bca633fb
EZ
82552011-08-23 Eli Zaretskii <eliz@gnu.org>
8256
8257 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8258 a character.
8259
4a5885a7
CY
82602011-08-23 Chong Yidong <cyd@stupidchicken.com>
8261
8262 * nsfont.m (ns_otf_to_script): Fix typo.
8263
0902a04e
KH
82642011-08-22 Kenichi Handa <handa@m17n.org>
8265
8266 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8267 extra slot even if the purpose is char-code-property-table.
8268
1a2e6670
EZ
82692011-08-23 Eli Zaretskii <eliz@gnu.org>
8270
8ddde651
EZ
8271 * xdisp.c (redisplay_window): When computing centering_position,
8272 account for the height of the header line. (Bug#8874)
8273
425cc014
EZ
8274 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8275 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8276 candidate is selected by the mouse, and that candidate has a
8277 composed character under the mouse.
8278
1a2e6670
EZ
8279 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8280 coordinates reported by pos-visible-in-window-p for a composed
8281 character in column zero.
8282
8b76d6f8
SM
82832011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8284
8285 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8286
dac347dd
EZ
82872011-08-22 Eli Zaretskii <eliz@gnu.org>
8288
8289 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8290 consider it a hit if to_charpos is anywhere in the range of the
8291 composed buffer positions.
8292
e013fb34
CY
82932011-08-22 Chong Yidong <cyd@stupidchicken.com>
8294
8295 * image.c (gif_load): Don't assume that each subimage has the same
8296 dimensions as the base image. Handle disposal method that is
8297 "undefined" by the gif spec (Bug#9335).
8298
bd1ba3e8
CY
82992011-08-20 Chong Yidong <cyd@stupidchicken.com>
8300
8301 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8302 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8303
54a1215b
EZ
83042011-08-19 Eli Zaretskii <eliz@gnu.org>
8305
823564e5
EZ
8306 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8307 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8308 from an Org mode buffer to a Speedbar frame.
8309
54a1215b
EZ
8310 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8311 a composition, take its buffer position from IT->cmp_it.charpos.
8312 Fixes cursor positioning at the beginning of a line that begins
8313 with a composed character.
8314
9778ebcc
EZ
83152011-08-18 Eli Zaretskii <eliz@gnu.org>
8316
0be6ee06
EZ
8317 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8318 character bidirectional type, use STRONG_L instead. Fixes crashes
8319 in a buffer produced by `describe-categories'.
8320
9778ebcc
EZ
8321 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8322 members before the level stack, so they would be saved and
8323 restored when copying iterator state. Fixes incorrect reordering
8324 around TABs covered by display properties.
8325
156bffbe
AS
83262011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8327
6b02f655 8328 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8329
72ad093b
CY
83302011-08-17 Chong Yidong <cyd@stupidchicken.com>
8331
8332 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8333 (internal_condition_case_2, internal_condition_case_n):
8334 Remove unnecessary aborts (Bug#9081).
72ad093b 8335
35774242
EZ
83362011-08-17 Eli Zaretskii <eliz@gnu.org>
8337
8338 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8339 has no `load' handler, try opening the file locally. (Bug#9311)
8340
db76dd85
KB
83412011-08-16 Ken Brown <kbrown@cornell.edu>
8342
8343 * gmalloc.c: Expand comment.
8344
b215eee5
EZ
83452011-08-16 Eli Zaretskii <eliz@gnu.org>
8346
8347 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8348 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8349
a4579d33
KB
83502011-08-16 Ken Brown <kbrown@cornell.edu>
8351
8352 Fix memory allocation problems in Cygwin build (Bug#9273).
8353
8354 * unexcw.c ( __malloc_initialized): Declare external variable.
8355 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8356
8b76d6f8
SM
8357 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8358 New variables.
a4579d33
KB
8359 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8360 dumped emacs.
8361 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8362 in the static heap.
8363 [CYGWIN] (special_realloc): New function.
8364 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8365 requests to realloc storage in the static heap.
8366
3ebec551
PE
83672011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8368
8369 * bidi.c (bidi_initialize): Remove unused local.
8370
9fd8be00
EZ
83712011-08-15 Eli Zaretskii <eliz@gnu.org>
8372
6b02f655
SM
8373 * bidimirror.h:
8374 * biditype.h: Remove file.
8375 * makefile.w32-in ($(BLD)/bidi.$(O)):
8376 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8377
8378 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8379
8380 * chartab.c: Improve commentary for the uniprop_table API.
8381
32413314
EZ
8382 * bidi.c (bidi_paragraph_init): Support zero value of
8383 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8384 (bidi_initialize): Use uniprop_table instead of including
8385 biditype.h and bidimirror.h.
32413314 8386
9fd8be00
EZ
8387 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8388 coordinates of the iterator when restoring from ppos_it.
8389 (Bug#9296)
8390
5cf2b69b
KH
83912011-08-14 Kenichi Handa <handa@m17n.org>
8392
8393 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8394 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8395
daf17d00
EZ
83962011-08-14 Eli Zaretskii <eliz@gnu.org>
8397
8398 * xdisp.c (move_it_in_display_line_to): Don't invoke
8399 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8400 ppos_it. Fixes vertical cursor motion when line beginning is
8401 covered by an image. (Bug#9296)
8402
08e3161a
JD
84032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8404
8405 * nsterm.h (ns_run_ascript): Declare.
8406 (NSAPP_DATA2_RUNASSCRIPT): Define.
8407
8408 * nsfns.m (as_script, as_result, as_status): New static variables.
8409 (ns_run_ascript): New function.
5e617bc2 8410 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8411 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8412 the event loop. Get status from as_status (Bug#7276).
8413
8414 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8415 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8416 the event loop (Bug#7276).
8417
a3720aa2
AS
84182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8419
8420 * gnutls.c (QCgnutls_bootprop_priority)
8421 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8422 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8423 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8424 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8425 (QCgnutls_bootprop_verify_hostname_error)
8426 (QCgnutls_bootprop_callbacks_verify): Rename from
8427 Qgnutls_bootprop_..., all uses changed.
8428
8429 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8430 uses changed.
8431
0a0d27fb
PE
84322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8433
19d5c50c
PE
8434 * xfaces.c (Qframe_set_background_mode): Now static.
8435 * dispextern.h (Qframe_set_background_mode): Remove decl.
8436
0a0d27fb
PE
8437 * process.c (Fnetwork_interface_info): Declare local only if needed.
8438
377538cb
JD
84392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8440
8441 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8442 (Fnetwork_interface_list): Allocate in increments of bytes instead
8443 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8444 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8445 sockaddr.
8446 (struct ifflag_def): notrailers is smart on OSX.
8447 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8448 Get hardware address with getifaddrs if available.
8449
08fff70c
EZ
84502011-08-12 Eli Zaretskii <eliz@gnu.org>
8451
8452 * xdisp.c (iterate_out_of_display_property): xassert that
8453 IT->position is set to within IT->object's boundaries. Break from
8454 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8455 when IT->position is set up wrongly due to some bug.
8456 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8457 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8458 entry. Force push_it to save on the stack the current
8459 buffer/string position, to be restored by pop_it. Fix flags in
8460 the iterator structure wrt the object coming from a display
8461 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8462 properties. (Bug#9284)
8463
7be1c708 84642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8465
7be1c708
CY
8466 * fontset.c (fontset_get_font_group): Add proper type checks.
8467 (Bug#9172)
aac0c6e3 8468
7be1c708 84692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8470
7be1c708
CY
8471 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8472 and LC_VERSION_MIN_MACOSX.
8473 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8474 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8475
97bb72a6
EZ
84762011-08-08 Eli Zaretskii <eliz@gnu.org>
8477
8478 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8479 no-display-properties-and-no-overlays under bidi display.
8480 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8481 properties and overlays.
97bb72a6 8482
d5617611
CY
84832011-08-08 Chong Yidong <cyd@stupidchicken.com>
8484
37e11a63
CY
8485 * editfns.c (Fset_time_zone_rule): Document relationship with the
8486 setenv function.
8487
d5617611
CY
8488 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8489 the font entity extracted from the cache (Bug#8109).
8490
58872834
CY
84912011-08-07 Chong Yidong <cyd@stupidchicken.com>
8492
8493 * composite.c (autocmp_chars): Don't reset point. That is done by
8494 restore_point_unwind (Bug#5984).
8495
75bfc667
JL
84962011-08-07 Juri Linkov <juri@jurta.org>
8497
8498 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8499 to show the arg `TIME' instead of `TIMEVAL'.
8500
d1410150
EZ
85012011-08-06 Eli Zaretskii <eliz@gnu.org>
8502
8503 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8504 display property strides EOL and includes a newline, as in
8505 longlines-mode. (Bug#9254)
75b771e4
EZ
8506 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8507 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8508
8509 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8510 is non-zero, even if the data buffer is NULL. Fixes a crash in
8511 vertical-motion with longlines-mode. (Bug#9254)
8512
35928349
EZ
85132011-08-05 Eli Zaretskii <eliz@gnu.org>
8514
ec7cc85b
EZ
8515 * bidi.c <bidi_cache_total_alloc>: Now static.
8516 (bidi_initialize): Initialize bidi_cache_total_alloc.
8517
8b76d6f8 8518 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8519 cache. (Bug#9221)
8520
8521 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8522 amount allocated this far in `bidi_cache_total_alloc'.
8523 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8524 non-zero, only free the data buffer without restoring the cache
8525 contents. All callers changed.
8526
8527 * dispextern.h (bidi_unshelve_cache): Update prototype.
8528
8529 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8530 (move_it_in_display_line, move_it_to)
8531 (move_it_vertically_backward, move_it_by_lines): Replace the call
8532 to xfree to an equivalent call to bidi_unshelve_cache.
8533 (move_it_in_display_line_to): Fix logic of returning
412b6358 8534 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8535
e2e2423b
EZ
85362011-08-05 Eli Zaretskii <eliz@gnu.org>
8537
8538 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8539 came from a string character with a `cursor' property. (Bug#9229)
8540
ae9e757a
JD
85412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8542
8543 * Makefile.in (LIB_PTHREAD): New variable.
8544 (LIBES): Add LIB_PTHREAD (Bug#9216).
8545
8546 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8547 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8548
213bd7f2
AS
85492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8550
6b02f655 8551 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8552
99aaf75f
JD
85532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8554
8555 * xterm.c (x_find_topmost_parent): New function.
8556 (x_set_frame_alpha): Find topmost parent window with
8557 x_find_topmost_parent and set the property there also (bug#9181).
8558 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8559
c74e9d86
PE
85602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8561
8562 * callproc.c (Fcall_process): Avoid vfork clobbering
8563 the local vars buffer, coding_systems, current_dir.
8564
640c8776
SM
85652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8566
8567 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8568
f26d0e4c
PE
85692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8570
8a10d76c
PE
8571 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8572 so that it is not optimized away.
8573
f26d0e4c
PE
8574 * xdisp.c (compute_display_string_pos): Remove unused local.
8575
55439c61
EZ
85762011-08-02 Eli Zaretskii <eliz@gnu.org>
8577
8578 Fix slow cursor motion and scrolling in large buffers with
8579 selective display, like Org Mode buffers. (Bug#9218)
8580
8581 * dispextern.h (struct bidi_it): New member disp_prop_p.
8582
8583 * xdisp.c: Remove one-slot cache of display string positions.
8584 (compute_display_string_pos): Accept an additional argument
5e617bc2 8585 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8586 for a display string or property. If found, set DISP_PROP_P
8587 non-zero.
8588
8589 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8590 DISP_PROP_P, and pass it to compute_display_string_pos.
8591 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8592 non-zero. All callers of bidi_fetch_char changed.
8593
fb33fa43
SM
85942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8595
8596 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8597
b099e063
DM
85982010-12-03 Don March <don@ohspite.net>
8599
8600 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8601 last character M-[char] is translated to ESC [char] (bug#7541).
8602
5cc7f7af
KH
86032011-08-02 Kenichi Handa <handa@m17n.org>
8604
d0fffa3f 8605 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8606
8607 * chartab.c (uniprop_table): Make it non-static.
8608
525d5e6e
EZ
86092011-08-01 Eli Zaretskii <eliz@gnu.org>
8610
8611 * xdisp.c (forward_to_next_line_start): Accept additional argument
8612 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8613 on the newline.
8614 (reseat_at_next_visible_line_start): Use the bidi iterator state
8615 returned by forward_to_next_line_start to restore the state of
8616 it->bidi_it after backing up to previous newline. (Bug#9212)
8617
31011111
AS
86182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8619
8620 * regex.c (re_comp): Protoize.
8621 (re_exec): Fix return type.
8622 (regexec): Fix type of `ret'. (Bug#9203)
8623
476371c4
PE
86242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8625
e5d76069
PE
8626 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8627 This is needed if max-image-size is a floating-point number.
8628
9a79b20c
AS
86292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8630
8631 * print.c (print_object): Print empty symbol as ##.
8632
8633 * lread.c (read1): Read ## as empty symbol.
8634
d8c2fa78
AA
86352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8636
8637 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8638 setting frame foreground color (Bug#9175).
8639 (x_set_background_color): Likewise.
8640
ffe57a7a
AA
8641 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8642 contents (Bug#9176).
8643 (EmacsTooltip -init): Remove bezels and add shadows to
8644 tooltip windows.
8645
bf3492a5
AA
8646 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8647 or scroll bar (Bug#8470).
8648
d55e9c53
AA
8649 * nsfont.m (nsfont_open): Remove assignment to voffset and
8650 unnecessary vars hshink, expand, hd, full_height, min_height.
8651 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8652
8653 * nsterm.h (nsfont_info): Remove voffset field.
8654
d8c2fa78 86552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8656
8657 Implement strike-through and overline on NextStep (Bug#8863).
8658
8659 * nsfont.m (nsfont_open): Use underline position provided by font,
8660 instead of hard-coded value of 2.
8661 (nsfont_draw): Call ns_draw_text_decoration instead.
8662
8663 * nsterm.h: Add declaration for ns_draw_text_decoration.
8664
8665 * nsterm.m (ns_draw_text_decoration): New function for drawing
8666 underline, overline, and strike-through.
8667 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8668 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8669 accommodate underlining, etc.
4843aac3 8670
4cc60b9b
EZ
86712011-07-28 Eli Zaretskii <eliz@gnu.org>
8672
bc7ece87
EZ
8673 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8674 default.
4cc60b9b 8675
476371c4
PE
86762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8677
66606eea
PE
8678 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8679 Without this fix, if a signal arrives just after memory fills up,
8680 'malloc' might be invoked reentrantly.
8681
476371c4
PE
8682 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8683 In other words, assume that every image size is allowed, on non-X
8684 hosts. This assumption is probably wrong, but it lets Emacs compile.
8685
f3fcc40d
AS
86862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8687
8688 * regex.c (re_iswctype): Convert return values to boolean.
8689
350c992f
EZ
86902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8691
8692 * xdisp.c (compute_display_string_pos): Don't use cached display
8693 string position if the buffer had its restriction changed.
8694 (Bug#9184)
8695
5266b4bb
PE
86962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8697
8698 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8699
2573a837 87002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8701
41f55ccd 8702 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8703
39e378da
PE
8704 * bidi.c: Integer size and overflow fixes.
8705 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8706 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8707 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8708 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8709 (bidi_find_other_level_edge):
8710 Use ptrdiff_t instead of EMACS_INT where either will do.
8711 This works better on 32-bit hosts configured --with-wide-int.
8712 (bidi_cache_ensure_space): Check for size-calculation overflow.
8713 Use % rather than repeated addition, for better worst-case speed.
8714 Don't set bidi_cache_size until after xrealloc returns, because it
8715 might not return.
8716 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8717 (bidi_cache_ensure_space): Also check that the bidi cache size
8718 does not exceed that of the largest Lisp string or buffer. See Eli
8719 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8720
5e927815
PE
8721 * alloc.c (__malloc_size_t): Remove.
8722 All uses replaced by size_t. See Andreas Schwab's note
8723 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8724
ca4aa935
PE
8725 * image.c: Improve checking for integer overflow.
8726 (check_image_size): Assume that f is nonnull, since
8727 it is always nonnull in practice. This is one less thing to
8728 worry about when checking for integer overflow later.
8729 (x_check_image_size): New function, which checks for integer
8730 overflow issues inside X.
8731 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8732 This removes the need for a memory_full check.
8733 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8734 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8735 (xbm_read_bitmap_data): Change locals back to 'int', since
8736 their values must fit in 'int'.
8737 (xpm_load_image, png_load, tiff_load):
8738 Invoke x_create_x_image_and_pixmap earlier,
8739 to avoid much needless work if the image is too large.
8740 (tiff_load): Treat overly large images as if
8741 x_create_x_image_and_pixmap failed, not as malloc failures.
8742 (gs_load): Use x_check_image_size.
8743
5f8f9cc2
PE
8744 * gtkutil.c: Omit integer casts.
8745 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8746 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8747
5adf60bc
PE
8748 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8749
c8907a93
PE
8750 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8751 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8752 would wrongly return t on a 64-bit host.
8753
e3c25c68
PE
8754 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8755 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8756 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8757 and therefore cause GCC to emit a bogus diagnostic in some cases.
8758
3f791afe
PE
8759 * image.c: Integer signedness and overflow and related fixes.
8760 This is not an exhaustive set of fixes, but it's time to
8761 record what I've got.
8762 (lookup_pixel_color, check_image_size): Remove redundant decls.
8763 (check_image_size): Don't assume that arbitrary EMACS_INT values
8764 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8765 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8766 (tiff_load, imagemagick_load_image):
8767 Check for overflow in size calculations.
8768 (x_create_x_image_and_pixmap): Remove unnecessary test for
8769 xmalloc returning NULL; that can't happen.
8770 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8771 (xpm_color_bucket): Use better integer hashing function.
8772 (xpm_cache_color): Don't possibly over-allocate memory.
8773 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8774 (gif_memory_source):
8775 Use ptrdiff_t, not int or size_t, to record sizes.
8776 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8777 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8778 either works, as we prefer signed integers.
8779 (tiff_read_from_memory, tiff_write_from_memory):
8780 Return tsize_t, not size_t, since that's what the TIFF API wants.
8781 (tiff_read_from_memory): Don't fail simply because the read would
8782 go past EOF; instead, return a short read.
8783 (tiff_load): Omit no-longer-needed casts.
8784 (Fimagemagick_types): Don't assume size fits into 'int'.
8785
3cc5a532
PE
8786 Improve hashing quality when configured --with-wide-int.
8787 * fns.c (hash_string): New function, taken from sxhash_string.
8788 Do not discard information about ASCII character case; this
8789 discarding is no longer needed.
8790 (sxhash-string): Use it. Change sig to match it. Caller changed.
8791 * lisp.h: Declare it.
8792 * lread.c (hash_string): Remove, since we now use fns.c's version.
8793 The fns.c version returns a wider integer if --with-wide-int is
8794 specified, so this should help the quality of the hashing a bit.
8795
b312a492
PE
8796 * emacs.c: Integer overflow minor fix.
8797 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8798 Define only if GNU_LINUX.
8799 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8800
dfd153ae
PE
8801 * dispnew.c: Integer signedness and overflow fixes.
8802 Remove unnecessary forward decls, that were a maintenance hassle.
8803 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8804 All uses changed.
8805 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8806 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8807 (prepare_desired_row, line_draw_cost):
8808 Use int, not unsigned, where either works.
8809 (save_current_matrix, restore_current_matrix):
8810 Use ptrdiff_t, not size_t, where either works.
8811 (init_display): Check for overflow more accurately, and without
8812 relying on undefined behavior.
8813
a81d11a3
PE
8814 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8815 Remove, replacing with the new symbols in lisp.h. All uses changed.
8816 * fileio.c (make_temp_name):
8817 * filelock.c (lock_file_1, lock_file):
8818 * xdisp.c (message_dolog):
8819 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8820 Use pMd etc. instead.
8821 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8822 replacing the pWIDE etc. symbols removed from editfns.c.
8823
3300e6fd
PE
8824 * keyboard.h (num_input_events): Now uintmax_t.
8825 This is (very slightly) less likely to mess up due to wraparound.
8826 All uses changed.
8827
fd05c7e9
PE
8828 * buffer.c: Integer signedness fixes.
8829 (alloc_buffer_text, enlarge_buffer_text):
8830 Use ptrdiff_t rather than size_t when either will do, as we prefer
8831 signed integers.
8832
903fe15d
PE
8833 * alloc.c: Integer signedness and overflow fixes.
8834 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8835 (__malloc_size_t): Default to size_t, not to int.
8836 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8837 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8838 Prefer ptrdiff_t to size_t when either would do, as we prefer
8839 signed integers.
8840 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8841 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8842 Now const. Initialize with values that are in range even if char
8843 is signed.
8844 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8845 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8846 These functions do the right thing with sizes > 2**32.
8847 (check_depth): Now ptrdiff_t, not int.
8848 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8849 Adjust to new way of storing sizes. Check for size overflow bugs
8850 in rest of code.
8851 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8852 slightly wrong anyway, as it missed one instance of
8853 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8854 (refill_memory_reserve): Omit needless cast to size_t.
8855 (mark_object_loop_halt): Mark as externally visible.
8856
ac82cc6a
PE
8857 * xselect.c: Integer signedness and overflow fixes.
8858 (Fx_register_dnd_atom, x_handle_dnd_message):
8859 Use ptrdiff_t, not size_t, since we prefer signed.
8860 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8861 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8862 x_dnd_atoms_size and x_dnd_atoms_length.
8863
c2d1e36d
PE
8864 * doprnt.c: Prefer signed to unsigned when either works.
8865 * eval.c (verror):
8866 * doprnt.c (doprnt):
8867 * lisp.h (doprnt):
8868 * xdisp.c (vmessage):
8869 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8870 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8871 prefer signed arithmetic to avoid comparison confusion.
8872 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8873 but is a bit tricky.
8874
0e926e56
PE
8875 Assume freestanding C89 headers, string.h, stdlib.h.
8876 * data.c, doprnt.c, floatfns.c, print.c:
8877 Include float.h unconditionally.
8878 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8879 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8880 * regex.c: Likewise for stddef.h, string.h.
8881 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8882 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8883 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8884 (STDC_HEADERS): Remove obsolete defines.
8885 * sysdep.c: Include limits.h unconditionally.
8886
9cfdb3ec
PE
8887 Assume support for memcmp, memcpy, memmove, memset.
8888 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8889 * regex.c (memcmp, memcpy):
8890 Remove; we assume C89 now.
8891
8892 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8893 (__malloc_safe_bcopy): Remove; no longer needed.
8894
cf950e6b 8895 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8896 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8897 well either way, and we prefer signed to unsigned.
8898
dbf38e02
LMI
88992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8900
8901 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8902 closes the connection while we're reading (bug#9182).
8903
d6f0886c 89042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8905
d6f0886c
JD
8906 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8907 are specified (Bug#9168).
24e0f6b1 8908
2eb1f9e6
PE
89092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8910
8911 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8912 Found by GCC static checking and --with-wide-int on a 32-bit host.
8913
22381272 89142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8915
8916 * xdisp.c (compute_display_string_pos): Fix logic of caching
8917 previous display string position. Initialize cached_prev_pos to
8918 -1. Fixes slow-down at the beginning of a buffer.
8919
f25e39b4
EZ
89202011-07-24 Eli Zaretskii <eliz@gnu.org>
8921
8922 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8923 for attrs[LFACE_FONTSET_INDEX].
8924
04c4b52e
PE
89252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8926
8927 * xml.c (parse_region): Remove unused local
8928 that was recently introduced.
8929
c1734fbd
EZ
89302011-07-23 Eli Zaretskii <eliz@gnu.org>
8931
be18c5a5
EZ
8932 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8933 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8934
c1734fbd
EZ
8935 * xdisp.c (move_it_in_display_line_to): Record the best matching
8936 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8937 exit if none of the characters scanned was an exact match.
8938 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8939 when exact match is impossible due to invisible text, and the
8940 lines are truncated.
8941
a258d627
JD
89422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8943
8944 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8945 for OSX >= 10.7.
8946
b6d5a689
EZ
89472011-07-22 Eli Zaretskii <eliz@gnu.org>
8948
0f74f785
EZ
8949 Fix a significant slow-down of cursor motion with C-n, C-p,
8950 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8951 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8952 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8953 (next_element_from_buffer): Call compute_stop_pos_backwards to
8954 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8955 base_level_stop.
8956 (reseat): Don't look for prev_stop, as that could mean a very long
8957 run.
8958 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8959 <cached_disp_overlay_modiff>: Cache for last found display string
8960 position.
551918c1 8961 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8962 about the same buffer in the same area of character positions, and
8963 the buffer wasn't changed since the time the display string
8964 position was cached.
551918c1 8965
b2d0c91a
EZ
89662011-07-22 Eli Zaretskii <eliz@gnu.org>
8967
8968 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8969 is an integer, which is important for empty lines. (Bug#9149)
8970
043604ee
CY
89712011-07-22 Chong Yidong <cyd@stupidchicken.com>
8972
8973 * frame.c (Fmodify_frame_parameters): In tty case, update the
8974 default face if necessary (Bug#4238).
8975
da4adb04
CY
89762011-07-21 Chong Yidong <cyd@stupidchicken.com>
8977
8978 * editfns.c (Fstring_to_char): No need to explain what a character
8979 is in the docstring (Bug#6576).
8980
9abd0532
LMI
89812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8982
8983 * xml.c (parse_region): Make sure we always return a tree.
8984
36881d16
HK
89852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8986
8987 * xml.c (parse_region): If a document contains only comments,
8988 return that, too.
8989
1e98674d
LMI
89902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8991
8992 * xml.c (make_dom): Return comments, too.
8993
590bd467
PE
89942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8995
8996 Port to OpenBSD.
8997 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8998 and the surrounding thread.
8999 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9000 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9001 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9002 timer goes off.
9003 * s/openbsd.h (BROKEN_SIGIO): Define.
9004 * unexelf.c (unexec) [__OpenBSD__]:
9005 Don't update the .mdebug section of the Alpha COFF symbol table.
9006
f41628b2
LMI
90072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9008
9009 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9010 (bug#8460).
9011
b59b67c5
PE
90122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9013
15e3a074
PE
9014 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9015 This fixes some race conditions on the permissions of any newly
9016 created file.
9017
41bed37d
PE
9018 * alloc.c (valid_pointer_p): Use pipe, not open.
9019 This fixes some permissions issues when debugging.
9020
b59b67c5
PE
9021 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9022 If fchown fails to set both uid and gid, try to set just gid,
9023 as that is sometimes allowed. Adjust the file's mode to eliminate
9024 setuid or setgid bits that are inappropriate if fchown fails.
9025
925a6be7
SM
90262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9027
9028 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9029 to compare Lisp_Objects.
9030 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9031 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9032 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9033
52968808
AS
90342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9035
0a6a104b
AS
9036 * lread.c (read_integer): Unread even EOF character.
9037 (read1): Likewise. Properly record start position of symbol.
9038
52968808
AS
9039 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9040 symbol character follows.
9041
9e381cdd
PE
90422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9043
9044 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9045 This works around a problem with the previous change to Fcopy_file.
9046 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9047 and without this change, GCC might complain about discarding
9048 fchown's return value.
9049
b5641435
JB
90502011-07-16 Juanma Barranquero <lekktu@gmail.com>
9051
9052 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9053
a8031457
PE
90542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9055
9056 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9057
dd889327
LMI
90582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9059
750c33f7
LMI
9060 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9061 it's used from the C level.
9062
dd889327
LMI
9063 * process.c: Use the same condition for POLL_FOR_INPUT in both
9064 keyboard.c and process.c (bug#1858).
9065
87e86684
LM
90662011-07-09 Lawrence Mitchell <wence@gmx.li>
9067
9068 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9069 (Fgnutls_boot): Use it.
9070
64348f40
AS
90712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9072
9073 * doc.c (Fsubstitute_command_keys): Revert last change.
9074
1d698799
LMI
90752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9076
f863868c
LMI
9077 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9078 quotes the next character, and doesn't affect other longer
9079 sequences (bug#8935).
9080
1d698799
LMI
9081 * lread.c (syms_of_lread): Clarify that is isn't only
9082 `eval-buffer' and `eval-defun' that's affected by
9083 `lexical-binding' (bug#8460).
9084
aa4b6df6
EZ
90852011-07-15 Eli Zaretskii <eliz@gnu.org>
9086
9087 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9088 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9089
5d856da6
PE
90902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9091
ad6042bb
PE
9092 Fix minor problems found by static checking.
9093 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9094 (elsz): Now a signed constant, not a size_t var. We prefer signed
9095 types to unsigned, to avoid integer comparison confusion. Without
9096 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9097 "cannot optimize loop, the loop counter may overflow", a symptom
9098 of the confusion.
f00bbb22 9099 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9100 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9101
6468f31c
LMI
91022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9103
49080b10
LMI
9104 * search.c (Fre_search_backward): Mention `case-fold-search' in
9105 all the re_search_* functions (bug#8138).
9106
6468f31c
LMI
9107 * keyboard.c (Fopen_dribble_file): Document when the file is
9108 closed (bug#8056).
9109
c965adc5
EZ
91102011-07-14 Eli Zaretskii <eliz@gnu.org>
9111
df9733bf
EZ
9112 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9113 bidi_cache_idx.
9114
0bb23927
EZ
9115 Support bidi reordering of display and overlay strings.
9116 * xdisp.c (compute_display_string_pos)
9117 (compute_display_string_end): Accept additional argument STRING.
9118 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9119 (reseat_to_string): Initialize bidi_it->string.s and
9120 bidi_it->string.schars.
9121 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9122 NULL (avoids a crash in bidi_paragraph_init).
9123 Initialize itb.string.lstring.
0bb23927
EZ
9124 (init_iterator): Call bidi_init_it only of a valid
9125 buffer position was specified. Initialize paragraph_embedding to
9126 L2R.
9127 (reseat_to_string): Initialize the bidi iterator.
9128 (display_string): If we need to ignore text properties of
9129 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9130 original value of -1 will not work with bidi.)
9131 (compute_display_string_pos): First arg is now struct
9132 `text_pos *'; all callers changed. Support display properties on
9133 Lisp strings.
9134 (compute_display_string_end): Support display properties on Lisp
9135 strings.
9136 (init_iterator, reseat_1, reseat_to_string): Initialize the
9137 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9138 when iterating on a string not from display properties).
640c8776
SM
9139 (compute_display_string_pos, compute_display_string_end):
9140 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9141 arrow keys.
9142 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9143 base_level_stop; instead, set base_level_stop to BEGV.
9144 Fixes crashes in vertical-motion.
0bb23927
EZ
9145 (next_element_from_buffer): Improve commentary for when
9146 the iterator is before prev_stop.
9147 (init_iterator): Initialize bidi_p from the default value of
9148 bidi-display-reordering, not from buffer-local value. Use the
9149 buffer-local value only if initializing for buffer iteration.
9150 (handle_invisible_prop): Support invisible properties on strings
9151 that are being bidi-reordered.
9152 (set_iterator_to_next): Support bidi reordering of C strings and
9153 Lisp strings.
9154 (next_element_from_string): Support bidi reordering of Lisp
9155 strings.
9156 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9157 (display_string): Support display of R2L glyph rows.
9158 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9159 (init_iterator): Don't initialize it->bidi_p for strings
9160 here.
9161 (reseat_to_string): Initialize it->bidi_p for strings here.
9162 (next_element_from_string, next_element_from_c_string)
9163 (next_element_from_buffer): Add xassert's for correspondence
9164 between IT's object being iterated and it->bidi_it.string
9165 structure.
9166 (face_before_or_after_it_pos): Support bidi iteration.
9167 (next_element_from_c_string): Handle the case of the first string
9168 character that is not the first one in the visual order.
9169 (get_visually_first_element): New function, refactored from common
9170 parts of next_element_from_buffer, next_element_from_string, and
9171 next_element_from_c_string.
9172 (tool_bar_lines_needed, redisplay_tool_bar)
9173 (display_menu_bar): Force left-to-right direction. Add a FIXME
9174 comment for making that be controlled by a user option.
9175 (push_it, pop_it): Save and restore the state of the
9176 bidi iterator. Save and restore the bidi_p flag.
9177 (pop_it): Iterate out of display property for string iteration as
9178 well.
9179 (iterate_out_of_display_property): Support iteration over strings.
9180 (handle_single_display_spec): Set up it->bidi_it for iteration
9181 over a display string, and call bidi_init_it.
9182 (handle_single_display_spec, next_overlay_string)
9183 (get_overlay_strings_1, push_display_prop): Set up the bidi
9184 iterator for displaying display or overlay strings.
9185 (forward_to_next_line_start): Don't use the shortcut if
9186 bidi-iterating.
9187 (back_to_previous_visible_line_start): If handle_display_prop
9188 pushed the iterator stack, restore the internal state of the bidi
9189 iterator by calling bidi_pop_it same number of times.
9190 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9191 and we are bidi-iterating, don't decrement the iterator position;
9192 instead, set the first_elt flag in the bidi iterator, to produce
9193 the same effect.
9194 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9195 (push_display_prop): xassert that we are iterating a buffer.
9196 (push_it, pop_it): Save and restore paragraph_embedding member.
9197 (handle_single_display_spec, next_overlay_string)
9198 (get_overlay_strings_1, reseat_1, reseat_to_string)
9199 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9200 correctly. Don't assume unibyte strings are not bidi-reordered.
9201 (compute_display_string_pos)
9202 (compute_display_string_end): Fix handling the case of C string.
9203 (push_it, pop_it): Save and restore from_disp_prop_p.
9204 (handle_single_display_spec, push_display_prop): Set the
9205 from_disp_prop_p flag.
9206 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9207 (pop_it): Call iterate_out_of_display_property only if we are
9208 popping after iteration over a string that came from a display
9209 property. Fix a typo in popping stretch info. Add an assertion
9210 for verifying that the iterator position is in sync with the bidi
9211 iterator.
9212 (handle_single_display_spec, get_overlay_strings_1)
9213 (push_display_prop): Fix initialization of paragraph direction for
9214 string when that of the parent object is not yet determined.
9215 (reseat_1): Call bidi_init_it to resync the bidi
9216 iterator with IT's position. (Bug#7616)
9217 (find_row_edges): If ROW->start.pos gives position
9218 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9219 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9220 Reset the from_disp_prop_p flag.
9221 (SAVE_IT, RESTORE_IT): New macros.
9222 (pos_visible_p, face_before_or_after_it_pos)
9223 (back_to_previous_visible_line_start)
9224 (move_it_in_display_line_to, move_it_in_display_line)
9225 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9226 (try_scrolling, redisplay_window, display_line): Use them when
9227 saving a temporary copy of the iterator and restoring it back.
9228 (back_to_previous_visible_line_start, reseat_1)
9229 (init_iterator): Empty the bidi cache "stack".
9230 (move_it_in_display_line_to): If iterator ended up at
9231 EOL, but we never saw any buffer positions smaller than
9232 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9233 motion in bidi-reordered lines.
9234 (move_it_in_display_line_to): Record prev_method and prev_pos
9235 immediately before the call to set_iterator_to_next. Fixes cursor
9236 motion in bidi-reordered lines with stretch glyphs and strings
9237 displayed in margins. (Bug#8133) (Bug#8867)
9238 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9239 TO_CHARPOS.
640c8776
SM
9240 (pos_visible_p): Support positions in bidi-reordered lines.
9241 Save and restore bidi cache.
0bb23927
EZ
9242
9243 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9244 (bidi_paragraph_info): Delete unused struct.
9245 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9246 (bidi_cache_start): New variable.
9247 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9248 to zero.
9249 (bidi_cache_fetch_state, bidi_cache_search)
9250 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9251 (bidi_cache_find, bidi_peek_at_next_level)
9252 (bidi_level_of_next_char, bidi_find_other_level_edge)
9253 (bidi_move_to_visually_next): Compare cache index with
9254 bidi_cache_start rather than with zero.
9255 (bidi_fetch_char): Accept new argument STRING; all callers
9256 changed. Support iteration over a string. Support strings with
9257 display properties. Support unibyte strings. Fix the type of
9258 `len' according to what STRING_CHAR_AND_LENGTH expects.
9259 (bidi_paragraph_init, bidi_resolve_explicit_1)
9260 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9261 (bidi_level_of_next_char, bidi_move_to_visually_next):
9262 Support iteration over a string.
0bb23927
EZ
9263 (bidi_set_sor_type, bidi_resolve_explicit_1)
9264 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9265 can now be zero (for strings); special values 0 and -1 were
9266 changed to -1 and -2, respectively.
9267 (bidi_char_at_pos): New function.
9268 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9269 Call it instead of FETCH_MULTIBYTE_CHAR.
9270 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9271 initialized to valid values.
9272 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9273 values.
9274 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9275 the test for valid cached positions. Fix the logic for looking up
9276 the sentinel state in the cache. GCPRO the Lisp string we are
9277 iterating.
9278 (bidi_push_it, bidi_pop_it): New functions.
9279 (bidi_initialize): Initialize the bidi cache start stack pointer.
9280 (bidi_cache_ensure_space): New function, refactored from part of
9281 bidi_cache_iterator_state. Don't assume the required size is just
9282 one BIDI_CACHE_CHUNK away.
9283 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9284 (bidi_count_bytes, bidi_char_at_pos): New functions.
9285 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9286 always valid if bidi_cache_idx is valid.
9287 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9288 is valid if it's going to be used.
9289 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9290 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9291 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9292 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9293 (bidi_find_other_level_edge, bidi_cache_start_stack):
9294 All variables related to cache indices are now EMACS_INT.
c965adc5 9295
0bb23927
EZ
9296 * dispextern.h (struct bidi_string_data): New structure.
9297 (struct bidi_it): New member `string'. Make flag members be 1-bit
9298 fields, and put them last in the struct.
640c8776
SM
9299 (compute_display_string_pos, compute_display_string_end):
9300 Update prototypes.
0bb23927
EZ
9301 (bidi_push_it, bidi_pop_it): Add prototypes.
9302 (struct iterator_stack_entry): New members bidi_p,
9303 paragraph_embedding, and from_disp_prop_p.
9304 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9305 (bidi_shelve_cache, bidi_unshelve_cache):
9306 Declare prototypes.
0bb23927
EZ
9307
9308 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9309 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9310 and vector-like objects.
9311
9312 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9313 cache around display iteration.
9314
9315 * window.c (Fwindow_end, window_scroll_pixel_based)
9316 (displayed_window_lines, Frecenter): Save and restore the bidi
9317 cache around display iteration.
9318
3bbd2265
LMI
93192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9320
9321 * editfns.c (Fdelete_region): Clarify the use of the named
9322 parameters (bug#6788).
9323
adc47434
MR
93242011-07-14 Martin Rudalics <rudalics@gmx.at>
9325
9326 * indent.c (Fvertical_motion): Set and restore w->pointm when
9327 saving and restoring the window's buffer (Bug#9006).
9328
837c31f8
LMI
93292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9330
9331 * editfns.c (Fstring_to_char): Clarify just what is returned
9332 (bug#6576). Text by Eli Zaretskii.
9333
ac389d0c
JB
93342011-07-13 Juanma Barranquero <lekktu@gmail.com>
9335
9336 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9337
0be0ce47
EZ
93382011-07-13 Eli Zaretskii <eliz@gnu.org>
9339
9340 * buffer.c (mmap_find): Fix a typo.
9341
cd18e7e3
JB
93422011-07-13 Johan Bockgård <bojohan@gnu.org>
9343
9344 Fix execution of x selection hooks.
9345 * xselect.c (Qx_lost_selection_functions)
9346 (Qx_sent_selection_functions): New vars.
9347 (syms_of_xselect): DEFSYM them.
9348 (x_handle_selection_request): Pass Qx_sent_selection_functions
9349 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9350 (x_handle_selection_clear,x_clear_frame_selections):
9351 Pass Qx_lost_selection_functions rather than
9352 Vx_lost_selection_functions to Frun_hook_with_args.
9353
47ea7f44
PE
93542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9355
ac389d0c 9356 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9357 The old code sometimes used this field without initializing it.
9358
47ea7f44
PE
9359 * alloc.c (gc_sweep): Don't read past end of array.
9360 In theory, the old code could also have corrupted Emacs internals,
9361 though it'd be very unlikely.
9362
bc985c87
AS
93632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9364
9365 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9366 argument. (Bug#4026)
bc985c87 9367
0cf34688
LMI
93682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9369
b3dadd76
LMI
9370 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9371 key" (bug#4257).
9372
0cf34688
LMI
9373 * window.c (Fset_window_start): Doc fix (bug#4199).
9374 (Fset_window_hscroll): Ditto.
9375
270768cd
PE
93762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9377
077e3dda 9378 Fix minor new problems caught by GCC 4.6.1.
270768cd 9379 * term.c (init_tty): Remove unused local.
490011a6 9380 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9381 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9382 not used otherwise.
270768cd 9383
b1f58454
CY
93842011-07-12 Chong Yidong <cyd@stupidchicken.com>
9385
9386 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9387
22b9578d
LMI
93882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9389
6e70ab07
LMI
9390 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9391 are the mini-buffer and the echo area (bug#3320).
9392
22b9578d
LMI
9393 * term.c (init_tty): Remove support for supdup, c10 and perq
9394 terminals, which are no longer supported (bug#1482).
9395
8974cc9f
JB
93962011-07-10 Johan Bockgård <bojohan@gnu.org>
9397
9398 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9399
a560d974
JD
94002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9401
9402 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9403 for non-popups (Bug#3642).
9404
1dae0f0a
AS
94052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9406
268c2c36 9407 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9408 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9409 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9410 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9411 * data.c (fmod): Likewise.
9412 * dispnew.c (swap_glyphs_in_rows): Likewise.
9413 * emacs.c (memory_warning_signal): Likewise.
9414 * floatfns.c (float_error): Likewise.
9415 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9416 (otf_open, font_otf_capability, generate_otf_features)
9417 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9418 Likewise.
9419 * image.c (pbm_read_file): Likewise.
9420 * indent.c (string_display_width): Likewise.
9421 * intervals.c (check_for_interval, search_for_interval)
9422 (inc_interval_count, count_intervals, root_interval)
9423 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9424 * lread.c (defalias): Likewise.
268c2c36 9425 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9426 * regex.c (set_image_of_range_1, set_image_of_range)
9427 (regex_grow_registers): Likewise.
9428 * sysdep.c (strerror): Likewise.
9429 * termcap.c (valid_filename_p, tprint, main): Likewise.
9430 * tparam.c (main): Likewise.
9431 * unexhp9k800.c (run_time_remap, save_data_space)
9432 (update_file_ptrs, read_header, write_header, calculate_checksum)
9433 (copy_file, copy_rest, display_header): Likewise.
9434 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9435 Likewise.
9436 * xdisp.c (check_it): Likewise.
9437 * xfaces.c (register_color, unregister_color, unregister_colors):
9438 Likewise.
9439 * xfns.c (print_fontset_result): Likewise.
9440 * xrdb.c (member, fatal, main): Likewise.
9441
99033785
PE
94422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9443
9444 Fix minor problems found by static checking (Bug#9031).
9445 * chartab.c (char_table_set_range, map_sub_char_table):
9446 Remove unused locals.
9447 (uniprop_table): Now static.
9448 * composite.c (_work_char): Remove unused static var.
9449
9cb2ac56
JB
94502011-07-09 Juanma Barranquero <lekktu@gmail.com>
9451
9452 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9453
f25661f0
JD
94542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9455
9456 * gtkutil.c (qttip_cb): Remove code without function.
9457
8278c4fe
EZ
94582011-07-09 Eli Zaretskii <eliz@gnu.org>
9459
9460 * w32.c (pthread_sigmask): New stub.
9461
1692ae2d 94622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9463
8a6ebd58 9464 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9465 sigprocmask is portable only for single-threaded applications, and
9466 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9467 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9468 (LIBES): Use it.
9469 * callproc.c (Fcall_process):
9470 * process.c (create_process):
9471 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9472 Use pthread_sigmask, not sigprocmask.
123403e4 9473
1b854618
JD
94742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9475
9476 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9477 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9478 wrong (Bug#8591).
9479
3fe4b549
JD
94802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9481
0ce7e563
JD
9482 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9483 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9484 (xg_hide_tooltip): Fix comment.
9485
3fe4b549
JD
9486 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9487 in registerServicesMenuSendTypes.
9488 (validRequestorForSendType): Don't check ns_return_types.
9489
9490 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9491 ns_return_type.
9492
5df75e47
JR
94932011-07-08 Jason Rumney <jasonr@gnu.org>
9494
22610910
JR
9495 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9496 SH_SHOW for hidden windows (Bug#5482).
9497
5df75e47
JR
9498 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9499 frame struct members of non-existent frames (Bug#6284).
9500
699c10bd
JD
95012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9502
4393663b
JD
9503 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9504 variable firstTime not needed on OSX >= 10.6.
9505 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9506 >= 10.5. Use setKnobProportion, setDoubleValue.
9507
9508 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9509 (MAC_OS_X_VERSION_10_5): Define if not defined.
9510 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9511 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9512 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9513
9514 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9515 cString and lossyCString on OSX >= 10.4.
4393663b 9516
58179cce 9517 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9518 sizeToFit on OSX >= 10.2.
9519
9520 * nsimage.m (allocInitFromFile): Don't use deprecated method
9521 bestRepresentationForDevice on OSX >= 10.6.
9522
9523 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9524 to avoid warning.
9525
9526 * emacs.c: Declare unexec_init_emacs_zone.
9527
a63e0781
JD
9528 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9529
699c10bd
JD
9530 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9531
9532 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9533 on svcsMenu (Bug#8842).
9534
9535 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9536 ns_return_types.
9537 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9538
9539 * nsterm.m (QUTF8_STRING): Declare.
9540 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9541 (validRequestorForSendType): Return type is (id).
9542 Change indexOfObjectIdenticalTo to indexOfObject.
9543 Check if we have local selection before returning self (Bug#8842).
9544 (writeSelectionToPasteboard): Put local selection into paste board
9545 if we have a local selection (Bug#8842).
9546 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9547
9548 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9549 (ns_get_local_selection): Declare.
9550
54e10184
LMI
95512011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9552
9888ff71
LMI
9553 * keymap.c (describe_map_tree): Don't insert a double newline at
9554 the end of the buffer (bug#1169) and return whether we inserted
9555 something.
9556
54e10184
LMI
9557 * callint.c (Fcall_interactively): Change "reading args" to
9558 "providing args" to try to clarify what it does (bug#1010).
9559
15fa4783
KH
95602011-07-07 Kenichi Handa <handa@m17n.org>
9561
9562 * composite.c (composition_compute_stop_pos): Ignore a static
9563 composition starting before CHARPOS (Bug#8915).
9564
9565 * xdisp.c (handle_composition_prop): Likewise.
9566
a8815b00
EZ
95672011-07-07 Eli Zaretskii <eliz@gnu.org>
9568
9569 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9570 (Bug#9015)
9571
ef7b981d 95722011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9573
9574 * character.h (unicode_category_t): New enum type.
9575
9576 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9577 (Qchar_code_property_table): New variable.
9578 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9579 (UNIPROP_COMPRESSED_FORM_P): New macros.
9580 (char_table_ascii): Uncompress the compressed values.
9581 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9582 Uncompress the compressed values.
ac389d0c 9583 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9584 (char_table_ref_and_range): Uncompress the compressed values.
9585 (sub_char_table_set): New arg is_uniprop. Callers changed.
9586 Uncompress the compressed values.
9587 (sub_char_table_set_range): Args changed. Callers changed.
9588 (char_table_set_range): Adjuted for the above change.
9589 (map_sub_char_table): Delete args default_val and parent. Add arg
9590 top. Give decoded values to a Lisp function.
640c8776 9591 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9592 values to a Lisp function. Gcpro more variables.
9593 (uniprop_table_uncompress)
9594 (uniprop_decode_value_run_length): New functions.
9595 (uniprop_decoder, uniprop_decoder_count): New variables.
9596 (uniprop_get_decoder, uniprop_encode_value_character)
9597 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9598 New functions.
9599 (uniprop_encoder, uniprop_encoder_count): New variables.
9600 (uniprop_get_encoder, uniprop_table)
9601 (Funicode_property_table_internal, Fget_unicode_property_internal)
9602 (Fput_unicode_property_internal): New functions.
9603 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9604 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9605 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9606 char-code-property-alist.
9607
640c8776 9608 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9609 Vunicode_category_table.
9610
640c8776 9611 * font.c (font_range): Adjust for the change of
c805dec0
KH
9612 Vunicode_category_table.
9613
76b397fb
DN
96142011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9615
9616 * m/iris4d.h: Remove file, move contents ...
9617 * s/irix6-5.h: ... here.
9618
22b4128e
PE
96192011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9620
9621 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9622 * alloc.c (mark_buffer):
9623 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9624 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9625 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9626 This isn't true in general, and it's particularly not true
9627 if Emacs is configured with --with-wide-int.
9628 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9629 New macros, used in the buffer.c change.
9630
869795d6
JD
96312011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9632
9633 * xsettings.c: Use both GConf and GSettings if both are available.
9634 (store_config_changed_event): Add comment.
9635 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9636 (store_tool_bar_style_changed): New functions.
5e617bc2 9637 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9638 (struct xsettings): Move font inside HAVE_XFT.
9639 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9640 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9641 Move inside HAVE_XFT.
640c8776 9642 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9643 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9644 also.
9645 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9646 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9647 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9648 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9649 (parse_settings): Move check for font inside HAVE_XFT.
9650 (read_settings, apply_xft_settings): Add comment.
9651 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9652 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9653 call store_font_name_changed.
9654 (xft_settings_event): Add comment.
9655 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9656 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9657 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9658 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9659 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9660 (xsettings_get_system_font, xsettings_get_system_normal_font):
9661 Add comment.
869795d6 9662
d8ed26bd
PE
96632011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9664
9665 Random fixes. E.g., (random) never returned negative values.
9666 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9667 subseconds part to the entropy, as that's a bit more random.
9668 Prefer signed to unsigned, since the signedness doesn't matter and
9669 in general we prefer signed. When given a limit, use a
9670 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9671 latter isn't right if USE_2_TAGS_FOR_INTS.
9672 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9673 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9674
cabf1cac
SM
96752011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9676
9677 * textprop.c (text_property_stickiness):
9678 Obey Vtext_property_default_nonsticky.
9679 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9680 * w32fns.c (syms_of_w32fns):
9681 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9682
6e9b2be9
PE
96832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9684
9685 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9686 This is more efficient than Ffile_directory_p and avoids a minor race.
9687
90186c68
LMI
96882011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9689
7c301272
LMI
9690 * buffer.c (Foverlay_put): Say what the return value is
9691 (bug#7835).
9692
c4f2d8d4
LMI
9693 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9694 is a directory before asking whether to use the file name
9695 (bug#7564).
ad637907
LMI
9696 (barf_or_query_if_file_exists): Make the "File is a directory"
9697 error be more correct.
c4f2d8d4 9698
90186c68
LMI
9699 * fns.c (Frequire): Remove the mention of the .gz files, since
9700 that's installation-specific, but keep the mention of
9701 `get-load-suffixes'.
9702
da64016e
PE
97032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9704
9705 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9706 Report string overflow if the output is too long.
9707
7d47b580
JB
97082011-07-04 Juanma Barranquero <lekktu@gmail.com>
9709
a555cb87
JB
9710 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9711 (syms_of_gnutls): Remove duplicate DEFSYM for
9712 Qgnutls_bootprop_verify_hostname_error, an error for
9713 Qgnutls_bootprop_verify_error (which is no longer used).
9714
7d47b580
JB
9715 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9716 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9717 Also (re)move comments that are misplaced or no longer relevant.
9718
1e49bfab
LMI
97192011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9720
9721 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9722
1485f4c0
CY
97232011-07-03 Chong Yidong <cyd@stupidchicken.com>
9724
9725 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9726 and background color parameters if they have been changed.
9727
a9ab721e
LMI
97282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9729
9730 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9731
cf7cff57
PE
97322011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9733
2e13213d
PE
9734 * xsettings.c (SYSTEM_FONT): Define only when used.
9735 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9736
cf7cff57
PE
9737 * keymap.c (access_keymap_1): Now static.
9738
7a8e04f7
CY
97392011-07-02 Chong Yidong <cyd@stupidchicken.com>
9740
9741 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9742 leave any prefix arg for the up event (Bug#1586).
9743
61352f62
LMI
97442011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9745
69bb1ef7
LMI
9746 * lread.c (syms_of_lread): Mention single symbols defined by
9747 `defvar' or `defconst' (bug#7154).
9748
61352f62 9749 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9750 (Frequire): Mention get-load-suffixes.
61352f62 9751
28545e04
MR
97522011-07-02 Martin Rudalics <rudalics@gmx.at>
9753
9754 * window.h (window): Remove clone_number slot.
9755 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9756 Remove.
9757 (make_parent_window, make_window, saved_window)
9758 (Fset_window_configuration, save_window_save): Don't deal with
9759 clone numbers.
9760 * buffer.c (Qclone_number): Remove declaration.
9761 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9762
3349e122
SM
97632011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9764
9765 Add multiple inheritance to keymaps.
9766 * keymap.c (Fmake_composed_keymap): New function.
9767 (Fset_keymap_parent): Simplify.
9768 (fix_submap_inheritance): Remove.
9769 (access_keymap_1): New function extracted from access_keymap to handle
9770 embedded parents and handle lists of maps.
9771 (access_keymap): Use it.
9772 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9773 (Fcopy_keymap): Handle embedded parents.
9774 (Fcommand_remapping, define_as_prefix): Simplify.
9775 (Fkey_binding): Simplify.
9776 (syms_of_keymap): Move minibuffer-local-completion-map,
9777 minibuffer-local-filename-completion-map,
9778 minibuffer-local-must-match-map, and
9779 minibuffer-local-filename-must-match-map to Elisp.
9780 (syms_of_keymap): Defsubr make-composed-keymap.
9781 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9782 (parse_menu_item): Trivial simplification.
9783
3279eb87
GM
97842011-07-01 Glenn Morris <rgm@gnu.org>
9785
9786 * Makefile.in (SETTINGS_LIBS): Fix typo.
9787
4550efdf
KI
97882011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9789
9790 * coding.c (Fencode_coding_string): Record the last coding system
9791 used, as the function doc string says (bug#8738).
9792
0949d2b6
JD
97932011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9794
9795 * xsettings.c (store_monospaced_changed): Take new font as arg and
9796 check for change against current_mono_font.
9797 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9798 (emacs_settings_constructor, emacs_settings_get_property)
9799 (emacs_settings_set_property, emacs_settings_class_init)
9800 (emacs_settings_init, gsettings_obj): Remove.
9801 (something_changedCB): New function for HAVE_GSETTINGS.
9802 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9803 with value as argument.
9804 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9805 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9806 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9807 "changed".
9808
9809 * xgselect.c: Add defined (HAVE_GSETTINGS).
9810 (xgselect_initialize): Ditto.
9811
9812 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9813 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9814 xg_select.
9815
bbc6b304
PE
98162011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9817
9818 * eval.c (struct backtrace): Simplify and port the data structure.
9819 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9820 signed bit field, as this assumption is not portable and it makes
9821 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9822 "char debug_on_exit : 1" as this is not portable either; instead,
9823 use the portable "unsigned int debug_on_exit : 1". Remove unused
9824 member evalargs. Remove obsolete comments about cc bombing out.
9825
9851bfc5
JD
98262011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9827
51bb811f 9828 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9829 Let HAVE_GSETTINGS override HAVE_GCONF.
9830 (store_monospaced_changed): New function.
9831 (EMACS_SETTINGS): A new type derived from GObject to handle
9832 GSettings notifications.
9833 (emacs_settings_constructor, emacs_settings_get_property)
9834 (emacs_settings_set_property, emacs_settings_class_init):
9835 New functions.
9836 (gsettings_client, gsettings_obj): New variables.
9837 (GSETTINGS_SCHEMA): New define.
9838 (something_changedCB): Call store_monospaced_changed.
9839 (init_gsettings): New function.
9840 (xsettings_initialize): Call init_gsettings.
9841 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9842 to NULL.
9843
640c8776 9844 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9845 GCONF_CFLAGS/LIBS.
9846
5386012d
MR
98472011-06-29 Martin Rudalics <rudalics@gmx.at>
9848
9849 * window.c (resize_root_window, grow_mini_window)
9850 (shrink_mini_window): Rename Qresize_root_window to
9851 Qwindow_resize_root_window and Qresize_root_window_vertically to
9852 Qwindow_resize_root_window_vertically.
9853
f13e0b08
PE
98542011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9855
9856 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9857
94515237
JB
98582011-06-27 Juanma Barranquero <lekktu@gmail.com>
9859
9860 * makefile.w32-in: Redesign dependencies so they reflect more
9861 clearly which files are directly included by each source file,
9862 and not through other includes.
9863
e43b6e43
MR
98642011-06-27 Martin Rudalics <rudalics@gmx.at>
9865
9866 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9867 (sort_overlays, overlay_strings): When an overlay's clone number
9868 matches the window's clone number process the overlay even if
9869 the overlay's window property doesn't match the current window.
9870
d68443dc
MR
9871 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9872 (Fwindow_hchild): Rename to Fwindow_left_child.
9873 (Fwindow_next): Rename to Fwindow_next_sibling.
9874 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9875 (resize_window_check): Rename to window_resize_check.
9876 (resize_window_apply): Rename to window_resize_apply.
9877 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9878 (Fdelete_other_windows_internal, resize_frame_windows)
9879 (Fsplit_window_internal, Fdelete_window_internal)
9880 (grow_mini_window, shrink_mini_window)
9881 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9882
c7e73be5
JD
98832011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9884
9885 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9886 (emacs_fixed_set_min_size): Remove.
9887 (emacs_fixed_new): Take frame as argument.
9888
9889 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9890 (_EmacsFixedPrivate): Remove minwidth/height.
9891 Add struct frame *f.
9892 (emacs_fixed_init): Initialize priv->f.
9893 (get_parent_class, emacs_fixed_set_min_size): Remove.
9894 (emacs_fixed_new): Set priv->f to argument.
9895 (emacs_fixed_get_preferred_width)
9896 (emacs_fixed_get_preferred_height): Use min_width/height from
9897 frames size_hint to set minimum and natural (Bug#8919).
9898 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9899 and use min_width/height from frames size_hint to set
9900 min_width/height (Bug#8919).
9901
9902 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9903 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9904 Fix indentation.
c7e73be5 9905
cf99dcf8
EZ
99062011-06-26 Eli Zaretskii <eliz@gnu.org>
9907
9908 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9909 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9910 called at ZV.
9911
029529ac
CY
99122011-06-26 Chong Yidong <cyd@stupidchicken.com>
9913
9914 * process.c (wait_reading_process_output): Bypass select if
9915 waiting for a cell while ignoring keyboard input, and input is
9916 pending. Suggested by Jan Djärv (Bug#8869).
9917
7a7ef429
PE
99182011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9919
9920 Use gnulib's dup2 module instead of rolling our own.
9921 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9922
11fdef7d 99232011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9924
9925 * dispnew.c (scrolling_window): Before scrolling, turn off a
9926 mouse-highlight in the window being scrolled.
9927
cd3520a4
JB
99282011-06-24 Juanma Barranquero <lekktu@gmail.com>
9929
9930 Move DEFSYM to lisp.h and use everywhere.
9931
9932 * character.h (DEFSYM): Move declaration...
9933 * lisp.h (DEFSYM): ...here.
9934
9935 * gnutls.c:
9936 * minibuf.c:
9937 * w32menu.c:
9938 * w32proc.c:
9939 * w32select.c: Don't include character.h.
9940
9941 * alloc.c (syms_of_alloc):
9942 * buffer.c (syms_of_buffer):
9943 * bytecode.c (syms_of_bytecode):
9944 * callint.c (syms_of_callint):
9945 * casefiddle.c (syms_of_casefiddle):
9946 * casetab.c (init_casetab_once):
9947 * category.c (init_category_once, syms_of_category):
9948 * ccl.c (syms_of_ccl):
9949 * cmds.c (syms_of_cmds):
9950 * composite.c (syms_of_composite):
9951 * dbusbind.c (syms_of_dbusbind):
9952 * dired.c (syms_of_dired):
9953 * dispnew.c (syms_of_display):
9954 * doc.c (syms_of_doc):
9955 * editfns.c (syms_of_editfns):
9956 * emacs.c (syms_of_emacs):
9957 * eval.c (syms_of_eval):
9958 * fileio.c (syms_of_fileio):
9959 * fns.c (syms_of_fns):
9960 * frame.c (syms_of_frame):
9961 * fringe.c (syms_of_fringe):
9962 * insdel.c (syms_of_insdel):
9963 * keymap.c (syms_of_keymap):
9964 * lread.c (init_obarray, syms_of_lread):
9965 * macros.c (syms_of_macros):
9966 * msdos.c (syms_of_msdos):
9967 * print.c (syms_of_print):
9968 * process.c (syms_of_process):
9969 * search.c (syms_of_search):
9970 * sound.c (syms_of_sound):
9971 * syntax.c (init_syntax_once, syms_of_syntax):
9972 * terminal.c (syms_of_terminal):
9973 * textprop.c (syms_of_textprop):
9974 * undo.c (syms_of_undo):
9975 * w32.c (globals_of_w32):
9976 * window.c (syms_of_window):
9977 * xdisp.c (syms_of_xdisp):
9978 * xfaces.c (syms_of_xfaces):
9979 * xfns.c (syms_of_xfns):
9980 * xmenu.c (syms_of_xmenu):
9981 * xsettings.c (syms_of_xsettings):
9982 * xterm.c (syms_of_xterm): Use DEFSYM.
9983
4228cf16
TZ
99842011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9985
cd3520a4 9986 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9987
7fcccf1e
PE
99882011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9989
7efb4e0e
PE
9990 Integer and buffer overflow fixes (Bug#8873).
9991
ff5844ad
PE
9992 * print.c (printchar, strout): Check for string overflow.
9993 (PRINTPREPARE, printchar, strout):
9994 Don't set size unless allocation succeeds.
9995
90532f02
PE
9996 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9997 for sizes. Check for string overflow more accurately.
9998 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9999
6d84508d
PE
10000 * macros.c: Integer and buffer overflow fixes.
10001 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10002 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10003 Use ptrdiff_t, not int, for sizes.
10004 Don't increment bufsize until after realloc succeeds.
10005 Check for size-calculation overflow.
10006 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10007
437b2cb4
PE
10008 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10009
8b9ac8b4
PE
10010 * lread.c: Integer overflow fixes.
10011 (read_integer): Radix is now EMACS_INT, not int,
10012 to improve quality of diagnostics for out-of-range radices.
10013 Calculate buffer size correctly for out-of-range radices.
10014 (read1): Check for integer overflow in radices, and in
10015 read-circle numbers.
82cb60d3
PE
10016 (read_escape): Avoid int overflow.
10017 (Fload, openp, read_buffer_size, read1)
10018 (substitute_object_recurse, read_vector, read_list, map_obarray):
10019 Use ptrdiff_t, not int, for sizes.
10020 (read1): Use EMACS_INT, not int, for sizes.
20270765 10021 Check for size overflow.
8b9ac8b4 10022
7fcccf1e
PE
10023 * image.c (cache_image): Check for size arithmetic overflow.
10024
bfbbd7e7
PE
10025 * lread.c: Integer overflow issues.
10026 (saved_doc_string_size, saved_doc_string_length)
10027 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10028 Now ptrdiff_t, not int.
10029 (read1): Don't assume doc string length fits in int. Check for
10030 out-of-range doc string lengths.
10031 (read_list): Don't assume file position fits in int.
39019e54 10032 (read_escape): Check for hex character overflow.
bfbbd7e7 10033
4e323265
LL
100342011-06-22 Leo Liu <sdl.web@gmail.com>
10035
10036 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10037 Move to minibuffer.el.
10038
85fece3e
PE
100392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10040
20b84ce9 10041 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10042 The following patches are for when GLYPH_DEBUG && !XASSERT.
10043 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10044 * dispnew.c (flush_stdout):
10045 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10046 Mark as externally visible.
10047 * dispnew.c (check_window_matrix_pointers): Now static.
10048 * dispnew.c (window_to_frame_vpos):
10049 * xfns.c (unwind_create_frame):
10050 * xterm.c (x_check_font): Remove unused local.
10051 * scroll.c (CHECK_BOUNDS):
10052 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10053 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10054 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10055 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10056 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10057 Now static.
10058 (debug_method_add): Use va_list and vsprintf rather than relying
10059 on undefined behavior with wrong number of arguments.
10060 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10061 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10062 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10063 since we're not interested in debugging glyphs with old libraries.
10064 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10065 GCC 4.6.0's static checking.
10066
0766b489
PE
100672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10068
31fd4b32
PE
10069 Integer overflow and signedness fixes (Bug#8873).
10070 A few related buffer overrun fixes, too.
10071
b79e8648
PE
10072 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10073
0766b489
PE
10074 * dispextern.h (struct face.stipple):
10075 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10076 (x_bitmap_mask, x_allocate_bitmap_record)
10077 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10078 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10079 (x_create_bitmap_from_xpm_data):
10080 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10081 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10082 (.bitmaps_last):
10083 * xfaces.c (load_pixmap):
10084 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10085 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10086 (.bitmaps_last, struct x_output.icon_bitmap):
10087 Use ptrdiff_t, not int, for bitmap indexes.
10088 (x_allocate_bitmap_record): Check for size overflow.
10089 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10090
b081724f
PE
10091 Use ptrdiff_t, not int, for overlay counts.
10092 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10093 * editfns.c (overlays_around, get_pos_property):
10094 * textprop.c (get_char_property_and_overlay):
10095 * xdisp.c (next_overlay_change, note_mouse_highlight):
10096 * xfaces.c (face_at_buffer_position):
21514da7
PE
10097 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10098 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10099 (Fnext_overlay_change, Fprevious_overlay_change)
10100 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10101 Use ptrdiff_t, not int, for sizes.
21514da7 10102 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10103
3de73e5e
PE
10104 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10105
2606c57b
PE
10106 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10107 (x_session_initialize): Do not assume string length fits in int.
10108
aaafe47a
PE
10109 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10110 This is unlikely, but can occur if DPI is outlandish.
10111
2674ddc8 10112 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10113 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10114
28154962
PE
10115 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10116 * xrdb.c (magic_file_p, search_magic_path):
10117 Omit last arg SUFFIX; it was always 0. All callers changed.
10118 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10119
7de51af5
PE
10120 * xfont.c (xfont_match): Avoid need for strlen.
10121
25ed6cc3
PE
10122 * xfns.c: Don't assume strlen fits in int.
10123 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10124
4eab31dd
PE
10125 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10126 not unsigned long, as we prefer signed integers. All callers changed.
10127 Detect integer overflow in repeat count.
10128 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10129 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10130
171e2a58
PE
10131 * termcap.c: Don't assume sizes fit in int and never overflow.
10132 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10133 (gobble_line): Check for size-calculation overflow.
10134
ad39faca 10135 * minibuf.c (Fread_buffer):
6e5bb2dc 10136 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10137 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10138 Don't assume string length fits in int.
10139
52c61c22 10140 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10141 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10142
b5b8c9e5
PE
10143 * font.c: Don't assume string length fits in int.
10144 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10145 Use ptrdiff_t, not int.
ccd6111c
PE
10146 (font_intern_prop): Don't assume string length fits in int.
10147 Don't assume integer property fits in fixnum.
10148 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10149
882f0d81 10150 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10151 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10152 Reformulate so as not to need the command string.
10153 Invoke gzip -cd rather than gunzip, as it's more portable.
10154 (lock_info_type, lock_file_1, lock_file):
10155 Don't assume pid_t and time_t fit in unsigned long.
10156 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10157 (current_lock_owner): Prefer signed type for sizes.
10158 Use memcpy, not strncpy, where memcpy is what is really wanted.
10159 Don't assume (via atoi) that time_t and pid_t fit in int.
10160 Check for time_t and/or pid_t out of range, e.g., via a network share.
10161 Don't alloca where an auto var works fine.
10162
93f4cf88
PE
10163 * fileio.c: Fix some integer overflow issues.
10164 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10165 Don't assume string length fits in int.
10166 (directory_file_name): Don't assume string length fits in long.
10167 (make_temp_name): Don't assume pid fits in int, or that its print
10168 length is less than 20.
10169
f3e92b69
PE
10170 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10171
1bfdaf10
PE
10172 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10173
35016e9a
PE
10174 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10175
3d1e65a1
PE
10176 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10177 We prefer signed integers, even for size calculations.
10178
0b963a93
PE
10179 * emacs.c: Don't assume string length fits in 'int'.
10180 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10181 (main): Don't invoke strlen when not needed.
10182
573f4b54
PE
10183 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10184 (XD_DEBUG_MESSAGE): Don't waste a byte.
10185
989f33ba
PE
10186 * callproc.c (getenv_internal_1, getenv_internal)
10187 (Fgetenv_internal):
965d34eb
PE
10188 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10189
e4d29b33
PE
10190 * lread.c (invalid_syntax): Omit length argument.
10191 All uses changed. This doesn't fix a bug, but it simplifies the
10192 code away from its former Hollerith-constant appearance, and it's
10193 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10194 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10195
eb49b136
PE
10196 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10197 This didn't break anything, but it didn't help either.
10198 It's confusing to put a bogus integer in a place where the actual
10199 value does not matter.
9f62aeb1 10200 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10201 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10202
15375a22
PE
10203 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10204 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10205 implementation.
b61cc01c
PE
10206 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10207 We prefer signed types, and the value cannot exceed the EMACS_INT
10208 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10209 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10210 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10211 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10212
53b2623d
PE
10213 * indent.c (sane_tab_width): New function.
10214 (current_column, scan_for_column, Findent_to, position_indentation)
10215 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10216 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10217
51cab52b 10218 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10219
f2ed8a70
PE
10220 * lisp.h (lint_assume): New macro.
10221 * composite.c (composition_gstring_put_cache):
10222 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10223
abe80cc6
PE
10224 * editfns.c, insdel.c:
10225 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10226
b02c740e
PE
10227 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10228
ebc96716
PE
10229 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10230
b4e50fa0 10231 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10232 Use much-faster test for byte-length change.
311d5d7c 10233 Don't assume string byte-length fits in 'int'.
a4cf38e4 10234 Check that character arg fits in 'int'.
85461888 10235 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10236
c0c1ee9f
PE
10237 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10238
a498d7f4
PE
10239 * fns.c (concat): Catch string overflow earlier.
10240 Do not rely on integer wraparound.
10241
51cab52b
PE
10242 * dispextern.h (struct it.overlay_strings_charpos)
10243 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10244 * xdisp.c (forward_to_next_line_start)
10245 (back_to_previous_visible_line_start)
10246 (reseat_at_next_visible_line_start, next_element_from_buffer):
10247 Don't arbitrarily truncate the value of 'selective' to int.
10248
76031fad
PE
10249 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10250
5eb55db9
PE
10251 * composite.c: Don't truncate sizes to 'int'.
10252 (composition_gstring_p, composition_reseat_it)
10253 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10254 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10255 not EMACS_UINT, for indexes.
5eb55db9 10256
0703a717
PE
10257 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10258
d6202519
PE
10259 * buffer.c: Include <verify.h>.
10260 (struct sortvec.priority, struct sortstr.priority):
8961a454 10261 Now EMACS_INT, not int.
c20998a7 10262 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10263 (struct sortstr.size, record_overlay_string)
10264 (struct sortstrlist.size, struct sortlist.used):
10265 Don't truncate size to int.
10266 (record_overlay_string): Check for size-calculation overflow.
d6202519 10267 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10268
d5a19415
JM
102692011-06-22 Jim Meyering <meyering@redhat.com>
10270
029529ac 10271 Don't leak an XBM-image-sized buffer
d5a19415
JM
10272 * image.c (xbm_load): Free the image buffer after using it.
10273
a9041e6c
PE
102742011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10275
10276 Port to Sun C.
10277 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10278 that Sun C diagnosed.
10279 * fns.c (secure_hash): Fix pointer signedness issue.
10280 * intervals.c (static_offset_intervals): New function.
10281 (offset_intervals): Use it.
10282
7f3f739f
LL
102832011-06-21 Leo Liu <sdl.web@gmail.com>
10284
10285 * deps.mk (fns.o):
10286 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10287 sha512.h.
10288
10289 * fns.c (secure_hash): Rename from crypto_hash_function and change
10290 the first arg to accept symbols.
5b66d427 10291 (Fsecure_hash): New primitive.
7f3f739f
LL
10292 (syms_of_fns): New symbols.
10293
76147d94
DD
102942011-06-20 Deniz Dogan <deniz@dogan.se>
10295
10296 * process.c (Fset_process_buffer): Clarify return value in
10297 docstring.
10298
7d7d0045
CY
102992011-06-18 Chong Yidong <cyd@stupidchicken.com>
10300
10301 * dispnew.c (add_window_display_history): Use BVAR.
10302
10303 * xdisp.c (debug_method_add): Use BVAR.
10304 (check_window_end, dump_glyph_matrix, dump_glyph)
10305 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10306
10307 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10308 Likewise.
10309
10310 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10311 check till after the cache is created in init_frame_faces.
10312
ff2bc410
SM
103132011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10314
10315 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10316
28177add
PE
103172011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10318
dd3482fe
PE
10319 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10320 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10321 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10322
393d71f3 10323 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10324 * fileio.c (Finsert_file_contents):
10325 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10326 Remove the old (too-loose) buffer overflow checks.
10327 They weren't needed, since make_gap checks for buffer overflow.
10328 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10329 The old code merely checked for Emacs fixnum overflow, and relied
10330 on undefined (wraparound) behavior. The new code avoids undefined
10331 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10332
2e6813b0 10333 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10334 Tune. Don't use wider integers than needed. Don't use alloca.
10335 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10336
599a9e4f
PE
10337 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10338
99561444
PE
10339 * insdel.c, lisp.h (buffer_overflow): New function.
10340 (insert_from_buffer_1, replace_range, replace_range_2):
10341 * insdel.c (make_gap_larger):
10342 * editfns.c (Finsert_char):
10343 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10344
28177add
PE
10345 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10346
e69dafad
PE
103472011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10348
4baa020d 10349 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10350
b1c46f02
PE
10351 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10352 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10353
e69dafad
PE
10354 * fileio.c: Don't assume EMACS_INT fits in off_t.
10355 (emacs_lseek): New static function.
10356 (Finsert_file_contents, Fwrite_region): Use it.
10357 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10358
566684ea
PE
10359 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10360
e6966cd6
PE
10361 * fns.c: Don't overflow int when computing a list length.
10362 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10363 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10364 truncation on 64-bit hosts. Check for QUIT every
10365 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10366 faster and is responsive enough.
10367 (Flength): Report an error instead of overflowing an integer.
10368 (Fsafe_length): Return a float if the value is not representable
10369 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10370 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10371 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10372
dd0b0efb
PE
10373 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10374 (header_size, word_size): New constants.
10375 (allocate_vectorlike): Don't check size overflow here.
10376 (allocate_vector): Check it here instead, since this is the only
10377 caller of allocate_vectorlike that could cause overflow.
10378 Check that the new vector's length is representable as a fixnum.
10379
86fe5cfe
PE
10380 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10381 The previous code was bogus. For example, next_almost_prime (32)
10382 returned 39, which is undesirable as it is a multiple of 3; and
10383 next_almost_prime (24) returned 25, which is a multiple of 5 so
10384 why was the code bothering to check for multiples of 7?
10385
80e88859
PE
10386 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10387
4a2f0ad6
PE
10388 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10389
f66c7cf8
PE
10390 Variadic C functions now count arguments with ptrdiff_t.
10391 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10392 Back then I didn't know that the Emacs coding style prefers signed int.
10393 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10394 were being counted with int, which may truncate counts on 64-bit
10395 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10396 * lisp.h (struct Lisp_Subr.function.aMANY)
10397 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10398 Arg counts are now ptrdiff_t, not size_t.
10399 All variadic functions and their callers changed accordingly.
10400 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10401 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10402 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10403 * callint.c (Fcall_interactively): Check arg count for overflow,
10404 to avoid potential buffer overrun. Use signed char, not 'int',
10405 for 'varies' array, so that we needn't bother to check its size
10406 calculation for overflow.
10407 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10408 * eval.c (apply_lambda):
10409 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10410 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10411 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10412
a1759b76
PE
10413 * callint.c (Fcall_interactively): Don't use index var as event count.
10414
d96be9fc
PE
10415 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10416 * mem-limits.h (SIZE): Remove; no longer used.
10417
a690a978 10418 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10419
578c21e6
PE
10420 Remove unnecessary casts.
10421 * xterm.c (x_term_init):
10422 * xfns.c (x_set_border_pixel):
10423 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10424 These aren't needed now that we assume ANSI C.
10425
96f53c6c
PE
10426 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10427 It's more likely to cause problems (due to unsigned overflow)
10428 than to cure them.
10429
83c77d31
PE
10430 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10431
ee2079f1
PE
10432 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10433
6da65536
PE
10434 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10435
7147c4a4
PE
10436 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10437
193e32d9
PE
10438 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10439
e5533da6
PE
10440 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10441
9910e595
PE
10442 GLYPH_CODE_FACE returns EMACS_INT, not int.
10443 * dispextern.h (merge_faces):
10444 * xfaces.c (merge_faces):
01103c44
PE
10445 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10446 Don't assume EMACS_INT fits in int.
9910e595 10447
2638320e
PE
10448 * character.h (CHAR_VALID_P): Remove unused parameter.
10449 * fontset.c, lisp.h, xdisp.c: All uses changed.
10450
045eb8d9
PE
10451 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10452
c1f134b5
PE
10453 * fns.c (concat): Minor tuning based on overflow analysis.
10454 This doesn't fix any bugs. Use int to hold character, instead
10455 of constantly refetching from Emacs object. Use XFASTINT, not
10456 XINT, for value known to be a character. Don't bother comparing
10457 a single byte to 0400, as it's always less.
10458
395fcb93 10459 * floatfns.c (Fexpt):
327eeec8
PE
10460 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10461
abbd3d23
PE
10462 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10463 for characters.
10464
684a03ef
PE
10465 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10466
0fed43f3
PE
10467 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10468 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10469 incorrectly succeed when S was a string, because 4294967386 was
10470 truncated before it was used.
10471
8fd02eb7
PE
10472 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10473 Otherwise, an out-of-range integer could cause undefined behavior
10474 on a 64-bit host.
10475
f8c86b69
PE
10476 * composite.c: Use int, not EMACS_INT, for characters.
10477 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10478 EMACS_INT, for values that are known to be in character range.
10479 This doesn't fix any bugs but is the usual style inside Emacs and
10480 may generate better code on 32-bit machines.
10481
34206dd2
PE
10482 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10483 This is for reasons similar to the recent CHAR_STRING fix.
10484 * charset.c (Fencode_char): Check that character arg is actually
10485 a character. Pass an int to ENCODE_CHAR.
10486 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10487 wider than 'int', as a compile-time check to prevent future regressions
10488 in this area.
10489
c5958d4c 10490 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10491
10492 Make sure a 64-bit char is never passed to CHAR_STRING.
10493 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10494 by silently ignoring the top 32 bits, allowing some values
10495 that were far too large to be valid characters.
10496 * character.h: Include <verify.h>.
10497 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10498 arguments are no wider than unsigned, as a compile-time check
10499 to prevent future regressions in this area.
10500 * data.c (Faset):
01103c44 10501 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10502 (Fsubst_char_in_region):
10503 * fns.c (concat):
10504 * xdisp.c (decode_mode_spec_coding):
10505 Adjust to CHAR_STRING's new requirement.
10506 * editfns.c (Finsert_char, Fsubst_char_in_region):
10507 * fns.c (concat): Check that character args are actually
10508 characters. Without this test, these functions did the wrong
10509 thing with wildly out-of-range values on 64-bit hosts.
10510
d37ca623
PE
10511 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10512 These casts should not be needed on 32-bit hosts, either.
10513 * keyboard.c (read_char):
10514 * lread.c (Fload): Remove casts to unsigned.
10515
ea204efb
PE
10516 * lisp.h (UNSIGNED_CMP): New macro.
10517 This fixes comparison bugs on 64-bit hosts.
10518 (ASCII_CHAR_P): Use it.
10519 * casefiddle.c (casify_object):
01103c44 10520 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10521 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10522 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10523 * dispextern.h (FACE_FROM_ID):
10524 * keyboard.c (read_char): Use UNSIGNED_CMP.
10525
41cb286c
PE
10526 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10527 not to EMACS_INT, to avoid GCC warning.
10528
4a1b9832
PE
10529 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10530
55daad71
PE
10531 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10532 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10533 isn't needed on 32-bit machines.
8f95c75c 10534
01103c44
PE
10535 * buffer.c (Fgenerate_new_buffer_name):
10536 Use EMACS_INT for count, not int.
0ceccced 10537 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10538
10539 * data.c (Qcompiled_function): Now static.
10540
c6f072e7
PE
10541 * window.c (window_body_lines): Now static.
10542
20ce5912
PE
10543 * image.c (gif_load): Rename local to avoid shadowing.
10544
9c4c5f81
PE
10545 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10546 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10547 * alloc.c (make_save_value): Integer argument is now of type
10548 ptrdiff_t, not int.
10549 (mark_object): Use ptrdiff_t, not int.
10550 * lisp.h (pD): New macro.
10551 * print.c (print_object): Use it.
10552
c0c5c8ae
PE
10553 * alloc.c: Use EMACS_INT, not int, to count objects.
10554 (total_conses, total_markers, total_symbols, total_vector_size)
10555 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10556 (total_free_floats, total_floats, total_free_intervals)
10557 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10558 Now EMACS_INT, not int. All uses changed.
10559 (Fgarbage_collect): Compute overall total using a double, so that
10560 integer overflow is less likely to be a problem. Check for overflow
10561 when converting back to an integer.
5a25e253
PE
10562 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10563 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10564 These were 'int' variables that could overflow on 64-bit hosts;
10565 they were never used, so remove them instead of repairing them.
211a0b2a 10566 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10567 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10568 Previously, this ceilinged at INT_MAX, but that doesn't work on
10569 64-bit machines.
e46bb31a 10570 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10571
c78baabf 10572 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10573 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10574 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10575 when a (possibly-narrower) signed value would do just as well.
10576 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10577
c9d624c6
PE
10578 * alloc.c: Catch some string size overflows that we were missing.
10579 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10580 for convenience in STRING_BYTES_MAX.
10581 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10582 The definition here is exact; the one in lisp.h was approximate.
10583 (allocate_string_data): Check for string overflow. This catches
10584 some instances we weren't catching before. Also, it catches
10585 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10586 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10587 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10588
c9d624c6
PE
10589 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10590 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10591 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10592
353032ce
PE
10593 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10594
2bccce07
PE
10595 * alloc.c (Fmake_string): Check for out-of-range init.
10596
0ac30604
SM
105972011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10598
10599 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10600
c195f2de
JD
106012011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10602
10603 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10604 xg_get_default_scrollbar_width.
10605
10606 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10607 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10608 (style_changed_cb): Call update_theme_scrollbar_width and call
10609 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10610 all frames (Bug#8505).
10611 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10612 Call gtk_window_set_resizable if HAVE_GTK3.
10613 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10614 and height if HAVE_GTK3 (Bug#8505).
10615 (scroll_bar_width_for_theme): New variable.
10616 (update_theme_scrollbar_width): New function.
10617 (xg_get_default_scrollbar_width): Move code to
10618 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10619 (xg_initialize): Call update_theme_scrollbar_width.
10620
10621 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10622
10623 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10624
e10ac9f1
MR
106252011-06-12 Martin Rudalics <rudalics@gmx.at>
10626
10627 * frame.c (make_frame): Call other_buffer_safely instead of
10628 other_buffer.
10629
10630 * window.c (temp_output_buffer_show): Call display_buffer with
10631 second argument Vtemp_buffer_show_specifiers and reset latter
10632 immediately after the call.
10633 (Vtemp_buffer_show_specifiers): New variable.
10634 (auto_window_vscroll_p, next_screen_context_lines)
10635 (Vscroll_preserve_screen_position): Remove leading asterisks from
10636 doc-strings.
10637
2d3c217e 106382011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10639
7b7f97e8 10640 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10641 * buffer.c (Qclone_number): Remove for now, as it's unused.
10642 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10643 (record_buffer): Remove unused local.
10644 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10645 (set_frame_buffer_list): Remove; unused.
10646 * frame.h (other_visible_frames): Remove decl.
10647 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10648 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10649 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10650 if HAVE_GPM.
10651 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10652 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10653 Define only if HAVE_GPM.
10654 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10655 (update_hints_inhibit): Remove; never set. All uses removed.
10656 * widgetprv.h (emacsFrameClassRec): Remove decl.
10657 * window.c (delete_deletable_window): Now returns void, since it
10658 wasn't returning anything.
10659 (compare_window_configurations): Remove unused locals.
10660 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10661 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10662 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10663 the same widths as pointers. This follows up on the 2011-05-06 patch.
10664 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10665 * xterm.h: Likewise.
10666 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10667
1384b89e
JB
106682011-06-12 Juanma Barranquero <lekktu@gmail.com>
10669
10670 * makefile.w32-in: Update dependencies.
10671 (LISP_H): Add lib/intprops.h.
10672
1100a63c
CY
106732011-06-11 Chong Yidong <cyd@stupidchicken.com>
10674
10675 * image.c (gif_load): Add animation frame delay to the metadata.
10676 (syms_of_image): Use DEFSYM. New symbol `delay'.
10677
6198ccd0
MR
106782011-06-11 Martin Rudalics <rudalics@gmx.at>
10679
10680 * window.c (delete_deletable_window): Re-add.
10681 (Fset_window_configuration): Rewrite to handle dead buffers and
10682 consequently deletable windows.
10683 (window_tree, Fwindow_tree): Remove. Supply functionality in
10684 window.el.
10685 (compare_window_configurations): Simplify code.
10686
b6e3633c
AS
106872011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10688
1ab0dee5
AS
10689 * image.c (imagemagick_load_image): Fix type mismatch.
10690 (Fimagemagick_types): Likewise.
10691
b6e3633c
AS
10692 * window.h (replace_buffer_in_windows): Declare.
10693
9397e56f
MR
106942011-06-11 Martin Rudalics <rudalics@gmx.at>
10695
10696 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10697 Qclone_number. Remove external declaration of Qdelete_window.
10698 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10699 code.
640c8776
SM
10700 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10701 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10702 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10703 buffer list implementation.
10704 (other_buffer_safely): New function.
10705 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10706 calls to replace_buffer_in_windows and
10707 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10708 if allowed.
10709 (record_buffer): Inhibit quitting and rewrite using quittable
10710 functions. Run Qbuffer_list_update_hook if allowed.
10711 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10712 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10713 Move switch-to-buffer to window.el.
9397e56f
MR
10714 (bury-buffer): Move to window.el.
10715 (Vbuffer_list_update_hook): New variable.
10716
10717 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10718 section.
10719
10720 * window.h (resize_frame_windows): Move up in code.
10721 (Fwindow_frame): Remove EXFUN.
10722 (replace_buffer_in_all_windows): Remove prototype.
10723 (replace_buffer_in_windows_safely): Add prototype.
10724
10725 * window.c: Declare Qdelete_window static again. Move down
10726 declaration of select_count.
10727 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10728 (Fother_window): Move to window.el.
10729 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10730 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10731 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10732 window.el.
10733 (replace_buffer_in_windows): Implement by calling
10734 Qreplace_buffer_in_windows.
10735 (replace_buffer_in_all_windows): Remove with some functionality
10736 moved into replace_buffer_in_windows_safely.
10737 (replace_buffer_in_windows_safely): New function.
10738 (select_window_norecord, select_frame_norecord): Move in front
10739 of run_window_configuration_change_hook. Remove now obsolete
10740 declarations.
640c8776
SM
10741 (Fset_window_buffer): Rewrite doc-string.
10742 Call Qrecord_window_buffer.
9397e56f
MR
10743 (keys_of_window): Move binding for other-window to window.el.
10744
b50691aa
CY
107452011-06-11 Chong Yidong <cyd@stupidchicken.com>
10746
10747 * dispextern.h (struct image): Replace data member, whose int_val
10748 and ptr_val fields were not used by anything, with a single
10749 lisp_val object.
10750
10751 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10752 (gif_clear_image, gif_load, imagemagick_load_image)
10753 (gs_clear_image, gs_load): Callers changed.
10754
3f754b86
PE
107552011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10756
cca69397
PE
10757 * buffer.h: Include <time.h>, for time_t.
10758 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10759
109e28d0
PE
10760 Fix minor problems found by static checking.
10761
60737f02
PE
10762 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10763
4b66faf3
PE
10764 Make identifiers static if they are not used in other modules.
10765 * data.c (Qcompiled_function, Qframe, Qvector):
10766 * image.c (QimageMagick, Qsvg):
10767 * minibuf.c (Qmetadata):
10768 * window.c (resize_window_check, resize_root_window): Now static.
10769 * window.h (resize_window_check, resize_root_window): Remove decls.
10770
109e28d0
PE
10771 * window.c (window_deletion_count, delete_deletable_window):
10772 Remove; unused.
46a4ce9e
PE
10773 (window_body_lines): Now static.
10774 (Fdelete_other_windows_internal): Mark vars as initialized.
10775 Make sure 'resize_failed' is initialized.
10776 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10777 (resize_window_apply): Remove unused local.
10778 * window.h (delete_deletable_window): Remove decl.
10779
109e28d0 10780 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10781 (imagemagick_load_image): Fix pointer signedness problem by changing
10782 last arg from unsigned char * to char *. All uses changed.
10783 Also, fix a local for similar reasons.
10784 Remove unused locals. Remove locals to avoid shadowing.
10785 (fn_rsvg_handle_free): Remove; unused.
10786 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10787 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10788
3f754b86
PE
10789 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10790
2547adb1
CY
107912011-06-10 Chong Yidong <cyd@stupidchicken.com>
10792
10793 * image.c (gif_load): Fix omitted cast error introduced by
10794 2011-06-06 change.
10795
2c8e37d4
MR
107962011-06-10 Martin Rudalics <rudalics@gmx.at>
10797
10798 * window.h (resize_proportionally, orig_total_lines)
10799 (orig_top_line): Remove from window structure.
10800 (set_window_height, set_window_width, change_window_heights)
10801 (Fdelete_window): Remove prototypes.
10802 (resize_frame_windows): Remove duplicate declaration.
10803
440a42e3
EZ
108042011-06-10 Eli Zaretskii <eliz@gnu.org>
10805
10806 * window.h (resize_frame_windows, resize_window_check)
10807 (delete_deletable_window, resize_root_window)
10808 (resize_frame_windows): Declare prototypes.
10809
10810 * window.c (resize_window_apply): Make definition be "static" to
10811 match the prototype.
10812
562dd5e9
MR
108132011-06-10 Martin Rudalics <rudalics@gmx.at>
10814
10815 * window.c: Remove declarations of Qwindow_size_fixed,
10816 window_min_size_1, window_min_size_2, window_min_size,
10817 size_window, window_fixed_size_p, enlarge_window, delete_window.
10818 Remove static from declaration of Qdelete_window, it's
10819 temporarily needed by Fbury_buffer.
10820 (replace_window): Don't assign orig_top_line and
10821 orig_total_lines.
10822 (Fdelete_window, delete_window): Remove. Window deletion is
10823 handled by window.el.
640c8776
SM
10824 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10825 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10826 (Fdelete_other_windows): Remove. Deleting other windows is
10827 handled by window.el.
10828 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10829 handled in window.el.
10830 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10831 Window minimum sizes are handled in window.el.
10832 (shrink_windows, size_window, set_window_height)
10833 (set_window_width, change_window_heights, window_height)
10834 (window_width, CURBEG, CURSIZE, enlarge_window)
10835 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10836 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10837 handled in window.el.
10838 (make_dummy_parent): Rename to make_parent_window and give it a
10839 second argument horflag.
10840 (make_window): Don't set resize_proportionally any more.
10841 (Fsplit_window): Remove. Windows are split in window.el.
10842 (save_restore_action, save_restore_orig_size)
10843 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10844 Resize mini windows in window.el.
10845 (grow_mini_window, shrink_mini_window): Implement by calling
10846 Qresize_root_window_vertically, resize_window_check and
10847 resize_window_apply.
640c8776
SM
10848 (saved_window, Fset_window_configuration, save_window_save):
10849 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10850 resize_proportionally.
10851 (window_min_height, window_min_width): Move to window.el.
10852 (keys_of_window): Move bindings for delete-other-windows,
10853 split-window, delete-window and enlarge-window to window.el.
10854
10855 * buffer.c: Temporarily extern Qdelete_window.
10856 (Fbury_buffer): Temporarily call Qdelete_window instead of
10857 Fdelete_window (Fbury_buffer will move to window.el soon).
10858
10859 * frame.c (set_menu_bar_lines_1): Remove code handling
10860 orig_top_line and orig_total_lines.
10861
10862 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10863 set_window_height but set heights directly.
10864 (change_frame_size_1): Use resize_frame_windows.
10865
10866 * xdisp.c (init_xdisp): Don't use set_window_height but set
10867 heights directly.
10868
640c8776
SM
10869 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10870 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10871 run_window_configuration_change_hook.
10872
10873 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10874 instead of change_window_heights and run
10875 run_window_configuration_change_hook.
10876
1a13852e
MR
108772011-06-09 Martin Rudalics <rudalics@gmx.at>
10878
10879 * window.c (replace_window): Rename second argument REPLACEMENT to
10880 NEW. New third argument SETFLAG. Rewrite.
10881 (delete_window, make_dummy_parent): Call replace_window with
10882 third argument 1.
10883 (window_list_1): Move down in code.
10884 (run_window_configuration_change_hook): Move set_buffer part
10885 before select_frame_norecord part in order to unwind correctly.
10886 Rename count1 to count.
10887 (recombine_windows, delete_deletable_window, resize_root_window)
10888 (Fdelete_other_windows_internal)
10889 (Frun_window_configuration_change_hook, make_parent_window)
10890 (resize_window_check, resize_window_apply, Fresize_window_apply)
10891 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10892 (Fdelete_window_internal, Fresize_mini_window_internal):
10893 New functions.
1a13852e
MR
10894 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10895
f3d1777e
MR
108962011-06-08 Martin Rudalics <rudalics@gmx.at>
10897
496e208e
MR
10898 * window.h (window): Add some new members to window structure -
10899 normal_lines, normal_cols, new_total, new_normal, clone_number,
10900 splits, nest, prev_buffers, next_buffers.
10901 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10902 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10903
f3d1777e
MR
10904 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10905 Remove.
496e208e
MR
10906 (make_dummy_parent): Set new members of windows structure.
10907 (make_window): Move down in code. Handle new members of window
10908 structure.
10909 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10910 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10911 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10912 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10913 (Fset_window_next_buffers, Fset_window_clone_number):
10914 New functions.
496e208e
MR
10915 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10916 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10917 Doc-string fixes.
10918 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10919 Argument WINDOW can be now internal window too.
10920 (Fwindow_use_time): Move up in code.
10921 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10922 Rewrite doc-string.
10923 (Fset_window_configuration, saved_window)
10924 (Fcurrent_window_configuration, save_window_save): Handle new
10925 members of window structure.
b9e809c2
MR
10926 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10927 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10928 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10929 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10930 Qget_mru_window, Qresize_root_window,
10931 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10932 Qauto_buffer_name; staticpro them.
f3d1777e 10933
abde8f8c
MR
109342011-06-07 Martin Rudalics <rudalics@gmx.at>
10935
10936 * window.c (Fwindow_total_size, Fwindow_left_column)
10937 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10938 (Fwindow_list_1): New functions.
10939 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10940 (Fwindow_width, Fscroll_left, Fscroll_right):
10941 Use window_body_cols instead of window_box_text_cols.
10942 (delete_window, Fset_window_configuration):
10943 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10944 (delete_all_subwindows): Take a window as argument and not a
10945 structure. Rewrite.
190b47e6
MR
10946 (window_loop): Remove handling of GET_LRU_WINDOW and
10947 GET_LARGEST_WINDOW.
10948 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10949
10950 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10951 window_box_text_cols. delete_all_subwindows now takes a
10952 Lisp_Object as argument.
abde8f8c 10953
640c8776
SM
10954 * indent.c (compute_motion, Fcompute_motion):
10955 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10956
fa8a67e6
MR
10957 * frame.c (delete_frame): Call delete_all_subwindows with root
10958 window as argument.
10959
a54e3482
DC
109602011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10961
10962 * fns.c (Fputhash): Document return value.
10963
60002bf5
CY
109642011-06-06 Chong Yidong <cyd@stupidchicken.com>
10965
10966 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10967
0c671da6 109682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10969
b862a52a 10970 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10971
be44ca6c
PE
10972 Check for overflow when converting integer to cons and back.
10973 * charset.c (Fdefine_charset_internal, Fdecode_char):
10974 Use cons_to_unsigned to catch overflow.
10975 (Fencode_char): Use INTEGER_TO_CONS.
10976 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10977 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10978 * data.c (long_to_cons, cons_to_long): Remove.
10979 (cons_to_unsigned, cons_to_signed): New functions.
10980 These signal an error for invalid or out-of-range values.
10981 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10982 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10983 * font.c (Ffont_variation_glyphs):
10984 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10985 * lisp.h: Include <intprops.h>.
10986 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10987 (cons_to_signed, cons_to_unsigned): New decls.
10988 (long_to_cons, cons_to_long): Remove decls.
10989 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10990 (Fprimitive_undo): Use CONS_TO_INTEGER.
10991 * xfns.c (Fx_window_property): Likewise.
10992 * xselect.c: Include <limits.h>.
10993 (x_own_selection, selection_data_to_lisp_data):
10994 Use INTEGER_TO_CONS.
10995 (x_handle_selection_request, x_handle_selection_clear)
10996 (x_get_foreign_selection, Fx_disown_selection_internal)
10997 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10998 (lisp_data_to_selection_data): Use cons_to_unsigned.
10999 (x_fill_property_data): Use cons_to_signed.
11000 Report values out of range.
11001
d1f3d2af
PE
11002 Check for buffer and string overflow more precisely.
11003 * buffer.h (BUF_BYTES_MAX): New macro.
11004 * lisp.h (STRING_BYTES_MAX): New macro.
11005 * alloc.c (Fmake_string):
11006 * character.c (string_escape_byte8):
11007 * coding.c (coding_alloc_by_realloc):
11008 * doprnt.c (doprnt):
11009 * editfns.c (Fformat):
11010 * eval.c (verror):
11011 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11012 since they may not be the same number.
11013 * editfns.c (Finsert_char):
11014 * fileio.c (Finsert_file_contents):
11015 Likewise for BUF_BYTES_MAX.
11016
dd52fcea
PE
11017 * image.c: Use ptrdiff_t, not int, for sizes.
11018 (slurp_file): Switch from int to ptrdiff_t.
11019 All uses changed.
11020 (slurp_file): Check that file size fits in both size_t (for
11021 malloc) and ptrdiff_t (for sanity and safety).
11022
7f9bbdbb
PE
11023 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11024 if b->modtime has its maximal value.
11025
dfe18f82
PE
11026 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11027
84acfcf0
PE
11028 Don't assume time_t can fit into int.
11029 * buffer.h (struct buffer.modtime): Now time_t, not int.
11030 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11031 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11032
ccd9a01a
PE
11033 Minor fixes for signed vs unsigned integers.
11034 * character.h (MAYBE_UNIFY_CHAR):
11035 * charset.c (maybe_unify_char):
11036 * keyboard.c (read_char, reorder_modifiers):
11037 XINT -> XFASTINT, since the integer must be nonnegative.
11038 * ftfont.c (ftfont_spec_pattern):
11039 * keymap.c (access_keymap, silly_event_symbol_error):
11040 XUINT -> XFASTINT, since the integer must be nonnegative.
11041 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11042 since it makes no difference and we prefer signed.
11043 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11044 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11045 nonnegative.
11046
d6d100dd
SM
110472011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11048
11049 * window.h (Fwindow_frame): Declare.
11050
2b6148e4
PE
110512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11052
11053 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11054 (SPARE_MEMORY): Always define.
11055 (LARGE_REQUEST): Remove.
11056 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11057
f230ecc9
MR
110582011-06-06 Martin Rudalics <rudalics@gmx.at>
11059
727e958e
MR
11060 * lisp.h: Move EXFUNS for Fframe_root_window,
11061 Fframe_first_window and Fset_frame_selected_window to window.h.
11062
11063 * window.h: Move EXFUNS for Fframe_root_window,
11064 Fframe_first_window and Fset_frame_selected_window here from
11065 lisp.h.
11066
11067 * frame.c (Fwindow_frame, Fframe_first_window)
11068 (Fframe_root_window, Fframe_selected_window)
11069 (Fset_frame_selected_window): Move to window.c.
11070 (Factive_minibuffer_window): Move to minibuf.c.
11071 (Fother_visible_frames_p): New function.
11072
11073 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11074
f230ecc9
MR
11075 * window.c (decode_window, decode_any_window): Move up in code.
11076 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11077 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11078 (Fwindow_buffer): Move up and rewrite doc-string.
11079 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11080 (Fwindow_prev): New functions.
727e958e
MR
11081 (Fwindow_frame): Move here from frame.c. Accept any window as
11082 argument.
11083 (Fframe_root_window, Fframe_first_window)
11084 (Fframe_selected_window): Move here from frame.c. Accept frame
11085 or arbitrary window as argument. Update doc-strings.
11086 (Fminibuffer_window): Move up in code.
11087 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11088 (Fset_frame_selected_window): Move here from frame.c.
11089 Marginal rewrite.
727e958e
MR
11090 (Fselected_window, select_window, Fselect_window): Move up in
11091 code. Minor doc-string fixes.
f230ecc9 11092
4d09bcf6
PE
110932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11094
11095 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11096 Do not assume that spare memory exists; that assumption is valid
11097 only if SYSTEM_MALLOC.
11098 (LARGE_REQUEST): New macro, so that the issue of large requests
11099 is separated from the issue of spare memory.
11100
810928a2
AS
111012011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11102
172418ad
AS
11103 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11104 format. (Bug#8806)
11105
43f862f7
AS
11106 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11107
810928a2
AS
11108 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11109 before statements.
11110
a059fe24
JD
111112011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11112
11113 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11114
11115 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11116
11117 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11118 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11119
989bf368
JB
111202011-06-05 Juanma Barranquero <lekktu@gmail.com>
11121
11122 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11123
4b80f674
CY
111242011-06-04 Chong Yidong <cyd@stupidchicken.com>
11125
11126 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11127 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11128 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11129 New error handlers.
4b80f674
CY
11130 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11131 Obey Vx_select_enable_clipboard_manager. Catch errors in
11132 x_clipboard_manager_save (Bug#8779).
11133 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11134 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11135
99a33b77 111362011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11137
11138 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11139
99a33b77 111402011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11141
11142 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11143 in the current matrix if keep_current_p is non-zero.
11144
8264569d
EZ
111452011-06-04 Eli Zaretskii <eliz@gnu.org>
11146
11147 * bidi.c (bidi_level_of_next_char): Fix last change.
11148
57f97249
EZ
111492011-06-03 Eli Zaretskii <eliz@gnu.org>
11150
fec2107c 11151 Support bidi reordering of text covered by display properties.
57f97249 11152
fec2107c
EZ
11153 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11154 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11155 (bidi_cache_search, bidi_cache_iterator_state)
11156 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11157 (bidi_level_of_next_char, bidi_move_to_visually_next):
11158 Support character positions inside a run of characters covered by a
fec2107c
EZ
11159 display string.
11160 (bidi_paragraph_init, bidi_resolve_explicit_1)
11161 (bidi_level_of_next_char): Call bidi_fetch_char and
11162 bidi_fetch_char_advance instead of FETCH_CHAR and
11163 FETCH_CHAR_ADVANCE.
11164 (bidi_init_it): Initialize new members.
11165 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11166 definitions.
11167 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11168 instead of using explicit *_CHAR codes.
d6d100dd
SM
11169 (bidi_resolve_explicit, bidi_resolve_weak):
11170 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11171 bidirectional text is supported only in multibyte buffers.
11172 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11173 it to initialize the frame_window_p member of struct bidi_it.
11174 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11175 (bidi_resolve_explicit, bidi_resolve_weak)
11176 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11177 bidi_it->nchars is non-positive.
11178 (bidi_level_of_next_char): Don't try to lookup the cache for the
11179 next/previous character if nothing is cached there yet, or if we
11180 were just reseat()'ed to a new position.
c40e2fb2 11181
0e14fe90
EZ
11182 * xdisp.c (set_cursor_from_row): Set start and stop points
11183 according to the row's direction when priming the loop that looks
11184 for the glyph on which to display cursor.
11185 (single_display_spec_intangible_p): Function deleted.
11186 (display_prop_intangible_p): Reimplement to call
11187 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11188 Accept 3 additional arguments needed by handle_display_spec.
11189 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11190 values: lists, `(when COND...)' forms, etc.
11191 (single_display_spec_string_p): Support property values that are
11192 lists with the argument STRING its top-level element.
11193 (display_prop_string_p): Fix the condition for processing a
11194 property that is a list to be consistent with handle_display_spec.
fec2107c 11195 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11196 last portion of handle_display_prop.
11197 (compute_display_string_pos): Accept additional argument
11198 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11199 value of a `display' property is a "replacing spec".
11200 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11201 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11202 the display property, but just return a value indicating whether
11203 the display property will replace the characters it covers.
11204 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11205 frame_window_p members of struct bidi_it.
d6d100dd
SM
11206 (compute_display_string_pos, compute_display_string_end):
11207 New functions.
fec2107c
EZ
11208 (push_it): Accept second argument POSITION, where pop_it should
11209 jump to continue iteration.
11210 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11211
fec2107c
EZ
11212 * keyboard.c (adjust_point_for_property): Adjust the call to
11213 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11214
11215 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11216 (bidi_init_it): Update prototypes.
11217 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11218 (compute_display_string_pos, compute_display_string_end):
11219 Declare prototypes.
fec2107c
EZ
11220 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11221 EMACS_INT.
fc6f18ce 11222
40087514 112232011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11224
57f53182
PE
11225 Malloc failure behavior now depends on size of allocation.
11226 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11227 * lisp.h: Change signatures accordingly.
11228 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11229 All callers changed. (Bug#8762)
11230
11231 * gnutls.c: Use Emacs's memory allocators.
11232 Without this change, the gnutls library would invoke malloc etc.
11233 directly, which causes problems on non-SYNC_INPUT hosts, and which
11234 runs afoul of improving memory_full behavior. (Bug#8761)
11235 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11236 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11237 xfree instead of the default malloc, realloc, free.
11238 (Fgnutls_boot): No need to check for memory allocation failure,
11239 since xmalloc does that for us.
11240
ac32cd99 11241 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11242 * category.c (hash_get_category_set):
11243 * ccl.c (ccl_driver):
11244 * charset.c (Fdefine_charset_internal):
11245 * charset.h (struct charset.hash_index):
11246 * composite.c (get_composition_id, gstring_lookup_cache)
11247 (composition_gstring_put_cache):
11248 * composite.h (struct composition.hash_index):
11249 * dispextern.h (struct image.hash):
11250 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11251 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11252 (hashfn_equal, hashfn_user_defined, make_hash_table)
11253 (maybe_resize_hash_table, hash_lookup, hash_put)
11254 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11255 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11256 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11257 * image.c (make_image, search_image_cache, lookup_image)
11258 (xpm_put_color_table_h):
11259 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11260 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11261 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11262 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11263 * alloc.c (allocate_vectorlike):
11264 Check for overflow in vector size calculations.
11265 * ccl.c (ccl_driver):
11266 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11267 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11268 need to be updated by these changes.
40087514
PE
11269 * fns.c (make_hash_table, maybe_resize_hash_table):
11270 Check for integer overflow with large hash tables.
0de4bb68
PE
11271 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11272 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11273 (SXHASH_REDUCE): New macro.
11274 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11275 Use it instead of discarding useful hash info with large hash values.
11276 (sxhash_float): New function.
11277 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11278 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11279 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11280 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11281 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11282 Adjust signatures to match updated version of code.
11283 (consing_since_gc): Now EMACS_INT, since a single hash table can
11284 use more than INT_MAX bytes.
11285
698d32e2
DN
112862011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11287
11288 Make it possible to build with GCC-4.6+ -O2 -flto.
11289
11290 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11291
fd6fa53f
SM
112922011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11293
11294 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11295 Call minibuffer-inactive-mode.
11296
864db017
JB
112972011-05-31 Juanma Barranquero <lekktu@gmail.com>
11298
11299 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11300 Update dependencies.
11301
2ad0baf4
DN
113022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11303
11304 * data.c (init_data): Remove code for UTS, this system is not
11305 supported anymore.
11306
4fcc2638
DN
113072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11308
11309 Don't force ./temacs to start in terminal mode.
11310
11311 * frame.c (make_initial_frame): Initialize faces in all cases, not
11312 only when CANNOT_DUMP is defined.
11313 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11314
c56e0fd5
DN
113152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11316
11317 * dispnew.c (add_window_display_history): Use const for the string
11318 pointer. Remove declaration, not needed.
11319
333d54da 113202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11321
55d4c1b2 11322 Use 'inline', not 'INLINE'.
333d54da 11323 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11324 * alloc.c, fontset.c (INLINE): Remove.
11325 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11326 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11327 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11328 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11329 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11330
738db178
DN
113312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11332
11333 Make it possible to run ./temacs.
11334
11335 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11336 syms_of_callproc does the same thing. Remove test for
11337 "initialized", do it in the caller.
11338 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11339
620c53a6
SM
113402011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11341
11342 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11343 (read_minibuf): Use get_minibuffer.
11344 (syms_of_minibuf): Use DEFSYM.
11345 (Qmetadata): New var.
11346 * data.c (Qbuffer): Don't make it static.
11347 (syms_of_data): Use DEFSYM.
11348
e003a292
PE
113492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11350
11351 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11352 (CCL_CODE_MIN): New macro.
11353
ed008a6d
PE
113542011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11355
3687c2ef
PE
11356 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11357
ed008a6d
PE
11358 * eval.c (Qdebug): Now static.
11359 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11360 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11361 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11362
d66c4c7c
CY
113632011-05-29 Chong Yidong <cyd@stupidchicken.com>
11364
11365 * image.c: Various fixes to ImageMagick code comments.
11366 (Fimagemagick_types): Doc fix.
11367
5fbc2025
PE
113682011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11369
0196f88a
PE
11370 Minor fixes prompted by GCC 4.6.0 warnings.
11371
11372 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11373
5fbc2025
PE
11374 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11375 (x_clipboard_manager_save_all): Move extern decl to ...
11376 * xterm.h: ... here, so that it can be checked for consistency.
11377
1dd3c2d9
CY
113782011-05-29 Chong Yidong <cyd@stupidchicken.com>
11379
11380 * xselect.c (x_clipboard_manager_save_frame)
11381 (x_clipboard_manager_save_all): New functions.
11382 (Fx_clipboard_manager_save): Lisp function deleted.
11383
11384 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11385 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11386
11387 * xterm.h: Update prototype.
11388
5ba6571d
WX
113892011-05-28 William Xu <william.xwl@gmail.com>
11390
11391 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11392 exiting (Bug#8239).
11393
3eaff834
JM
113942011-05-28 Jim Meyering <meyering@redhat.com>
11395
e1900994 11396 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11397 * fns.c (to_uchar): Define.
11398 (crypto_hash_function): Use it to convert some newly-signed
11399 variables to unsigned, to avoid sign-extension bugs. For example,
11400 without this change, (md5 "truc") would evaluate to
11401 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11402 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11403 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11404
0f6990a7
PE
114052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11406
11407 Integer overflow fixes.
c8a9ca5a 11408
08686060
PE
11409 * dbusbind.c: Serial number integer overflow fixes.
11410 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11411 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11412 to hold a serial number that is too large for a fixnum.
11413 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11414 Check for serial numbers out of range. Decode any serial number
59568bf0 11415 that was so large that it became a float. (Bug#8722)
08686060 11416
2d1fc3c7
PE
11417 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11418 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11419 Use XFASTINT rather than XUINT when numbers are nonnegative.
11420 (xd_append_arg, Fdbus_method_return_internal):
11421 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11422 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11423 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11424 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11425 (Bug#8722)
2d1fc3c7 11426
c8a9ca5a
PE
11427 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11428
519e1d69
PE
11429 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11430
6df6ae42 11431 ccl: Add integer overflow checks.
30569699
PE
11432 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11433 (IN_INT_RANGE): New macros.
11434 (ccl_driver): Use them to check for integer overflow when
11435 decoding a CCL program. Many of the new checks are whether XINT (x)
11436 fits in int; it doesn't always, on 64-bit hosts. The new version
11437 doesn't catch all possible integer overflows, but it's an
847044ea 11438 improvement. (Bug#8719)
30569699 11439
c11285dc
PE
11440 * alloc.c (make_event_array): Use XINT, not XUINT.
11441 There's no need for unsigned here.
11442
fdccd48e
PE
11443 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11444 This follows up to the 2011-05-06 change that substituted uintptr_t
11445 for EMACS_INT. This case wasn't caught back then.
11446
37910ab2
PE
11447 Rework Fformat to avoid integer overflow issues.
11448 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11449 now (part of C89). Include <verify.h>.
11450 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11451 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11452 (Fformat): Avoid the prepass trying to compute sizes; it was only
11453 approximate and thus did not catch overflow reliably. Instead, walk
11454 through the format just once, formatting and computing sizes as we go,
11455 checking for integer overflow at every step, and allocating a larger
11456 buffer as needed. Keep track separately whether the format is
11457 multibyte. Keep only the most-recently calculated precision, rather
11458 than them all. Record whether each argument has been converted to
11459 string. Use EMACS_INT, not int, for byte and char and arg counts.
11460 Support field widths and precisions larger than INT_MAX. Avoid
11461 sprintf's undefined behavior with conversion specifications such as %#d
11462 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11463 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11464 formatting out-of-range floating point numbers with int
9173deec 11465 formats. (Bug#8668)
37910ab2 11466
2e6578fb
PE
11467 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11468
0ae6bdee
PE
11469 * data.c: Avoid integer truncation in expressions involving floats.
11470 * data.c: Include <intprops.h>.
11471 (arith_driver): When there's an integer overflow in an expression
11472 involving floating point, convert the integers to floating point
11473 so that the resulting value does not suffer from catastrophic
11474 integer truncation. For example, on a 64-bit host (* 4
11475 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11476 Do not rely on undefined behavior after integer overflow.
11477
de883a70
PE
11478 merge count_size_as_multibyte, parse_str_to_multibyte
11479 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11480 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11481 Check for integer overflow.
11482 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11483 since it's now a duplicate of the other. This is more of
11484 a character than a buffer op, so better that it's in character.c.
11485 * fns.c, print.c: Adjust to above changes.
11486
2ff916cb
PE
114872011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11488
11489 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11490
f1b54466
PE
114912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11492
fb1ac845
PE
11493 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11494 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11495 (x_clipboard_manager_save): Now static.
11496 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11497
f1b54466
PE
11498 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11499 (crypto_hash_function): Now static.
11500 Fix pointer signedness problems. Avoid unnecessary initializations.
11501
a9f737ee
CY
115022011-05-27 Chong Yidong <cyd@stupidchicken.com>
11503
11504 * termhooks.h (Vselection_alist): Make it terminal-local.
11505
11506 * terminal.c (create_terminal): Initialize it.
11507
11508 * xselect.c: Support for clipboard managers.
11509 (Vselection_alist): Move to termhooks.h as terminal-local var.
11510 (LOCAL_SELECTION): New macro.
11511 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11512 (symbol_to_x_atom): Remove gratuitous arg.
11513 (x_handle_selection_request, lisp_data_to_selection_data)
11514 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11515 (x_own_selection, x_get_local_selection, x_convert_selection):
11516 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11517 (some_frame_on_display): Delete unused function.
11518 (Fx_own_selection_internal, Fx_get_selection_internal)
11519 (Fx_disown_selection_internal, Fx_selection_owner_p)
11520 (Fx_selection_exists_p): New optional frame arg.
11521 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11522 (x_handle_selection_clear): Don't treat other terminals with the
11523 same keyboard specially. Use the terminal-local Vselection_alist.
11524 (x_clear_frame_selections): Use Frun_hook_with_args.
11525
11526 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11527
11528 * xterm.h: Add support for those atoms.
11529
e067f0c1
CY
115302011-05-26 Chong Yidong <cyd@stupidchicken.com>
11531
11532 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11533 (converted_selections, conversion_fail_tag): New global variables.
11534 (x_selection_request_lisp_error): Free the above.
11535 (x_get_local_selection): Remove unnecessary code.
11536 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11537 of converted selections stored in converted_selections.
11538 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11539 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11540 (x_convert_selection): New function.
11541 (x_handle_selection_event): Simplify.
11542 (x_get_foreign_selection): Don't ignore incoming requests while
11543 waiting for an answer; this will fail when we implement
11544 SAVE_TARGETS, and seems unnecessary anyway.
11545 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11546 (Vx_sent_selection_functions): Doc fix.
11547
0f4aebc0
LL
115482011-05-26 Leo Liu <sdl.web@gmail.com>
11549
11550 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11551
e61124cd
YM
115522011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11553
11554 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11555
11556 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11557 for fringe update if it has periodic bitmap.
ac389d0c 11558 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11559 and fringe_bitmap_periodic_p.
11560
11561 * fringe.c (get_fringe_bitmap_data): New function.
11562 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11563 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11564 row. Mark glyph row for fringe update if periodicity changed.
11565
11566 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11567 for fringe update unless it has periodic bitmap.
11568
f16d9837
KH
115692011-05-25 Kenichi Handa <handa@m17n.org>
11570
11571 * xdisp.c (get_next_display_element): Set correct it->face_id for
11572 a static composition.
11573
e1b90ef6
LL
115742011-05-24 Leo Liu <sdl.web@gmail.com>
11575
11576 * deps.mk (fns.o):
11577 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11578
11579 * fns.c (crypto_hash_function, Fsha1): New function.
11580 (Fmd5): Use crypto_hash_function.
11581 (syms_of_fns): Add Ssha1.
11582
7400048f
PE
115832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11584
11585 * gnutls.c: Remove unused macros.
11586 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11587 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11588 Remove macros that are defined and never used.
11589 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11590
abb71cf4
CY
115912011-05-22 Chong Yidong <cyd@stupidchicken.com>
11592
11593 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11594 (Fx_get_selection_internal): Minor cleanup.
11595 (Fx_own_selection_internal): Rename arguments for consistency with
11596 select.el.
11597
6307db39
PE
115982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11599
11600 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11601
f3d4e0a4
CY
116022011-05-22 Chong Yidong <cyd@stupidchicken.com>
11603
11604 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11605
4d8ade89
YM
116062011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11607
11608 * dispnew.c (scrolling_window): Don't exclude the case that the
11609 last enabled row in the desired matrix touches the bottom boundary.
11610
32078c8d
GM
116112011-05-21 Glenn Morris <rgm@gnu.org>
11612
11613 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11614 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11615 and add some more files.
32078c8d 11616
7285dc67
EZ
116172011-05-20 Eli Zaretskii <eliz@gnu.org>
11618
11619 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11620 report_file_error introduced by the change from 2011-05-07.
11621
89d1bd22
PE
116222011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11623
11624 * systime.h (Time): Define only if emacs is defined.
11625 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11626 where the include path doesn't have X11/X.h by default. See
11627 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11628
cd394be1 116292011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11630
11631 * composite.c (find_automatic_composition): Fix previous change.
11632
b9704ad9
GM
116332011-05-20 Glenn Morris <rgm@gnu.org>
11634
11635 * lisp.mk: New file, split from Makefile.in.
11636 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11637 (shortlisp): Remove.
11638 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11639
4a720484
GM
116402011-05-19 Glenn Morris <rgm@gnu.org>
11641
11642 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11643 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11644 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11645 (lisp): Set the order to that of loadup.el.
11646 (shortlisp): Make it a copy of $lisp.
11647 (SOME_MACHINE_LISP): Remove.
11648 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11649 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11650
a28d4396
KH
116512011-05-18 Kenichi Handa <handa@m17n.org>
11652
11653 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11654 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11655 (find_automatic_composition): Mostly rewrite for efficiency.
11656
a2b1fa8e
JB
116572011-05-18 Juanma Barranquero <lekktu@gmail.com>
11658
11659 * makefile.w32-in: Update dependencies.
11660
8e1f5610
CS
116612011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11662
11663 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11664 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11665
7025ee00 116662011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11667
cdfa6eab
PE
11668 Fix some integer overflow issues, such as string length overflow.
11669
06d6db33
PE
11670 * insdel.c (count_size_as_multibyte): Check for string overflow.
11671
2b4560a8
PE
11672 * character.c (lisp_string_width): Check for string overflow.
11673 Use EMACS_INT, not int, for string indexes and lengths; in
11674 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11675 the resulting string length overflows an EMACS_INT; instead,
11676 report a string overflow if no precision given. When checking for
11677 precision exhaustion, use a check that cannot possibly have
11678 integer overflow. (Bug#8675)
11679 * character.h (lisp_string_width): Adjust to new signature.
11680
cb93f9be
PE
11681 * alloc.c (string_overflow): New function.
11682 (Fmake_string): Use it. This doesn't change behavior, but saves
11683 a few bytes and will simplify future changes.
11684 * character.c (string_escape_byte8): Likewise.
11685 * lisp.h (string_overflow): New decl.
11686
1a1f3366
PE
11687 Fixups, following up to the user-interface timestamp change.
11688 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11689 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11690 * msdos.c (mouse_get_pos): Likewise.
11691 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11692 * w32gui.h (Time): Define by including "systime.h" rather than by
11693 declaring it ourselves. (Bug#8664)
11694
d4e3e4d3
PE
11695 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11696 * image.c (clear_image_cache): Likewise.
11697
f6a24d19
PE
11698 * term.c (term_mouse_position): Don't assume time_t wraparound.
11699
08dc5ae6
PE
11700 Be more systematic about user-interface timestamps.
11701 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11702 and sometimes 'EMACS_UINT', to represent these timestamps.
11703 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11704 This makes the code easier to follow, and makes it easier to catch
11705 integer overflow bugs such as Bug#8664.
11706 * frame.c (Fmouse_position, Fmouse_pixel_position):
11707 Use Time, not unsigned long, for user-interface timestamps.
11708 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11709 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11710 * keyboard.h (last_event_timestamp): Likewise.
11711 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11712 * menu.h (xmenu_show): Likewise.
11713 * term.c (term_mouse_position): Likewise.
11714 * termhooks.h (struct input_event.timestamp): Likewise.
11715 (struct terminal.mouse_position_hook): Likewise.
11716 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11717 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11718 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11719 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11720 what it was before.
11721 * menu.h, termhooks.h: Include "systime.h", for Time.
11722
8e55734a
PE
11723 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11724 Don't assume that the difference between two unsigned long values
11725 can fit into an integer. At this point, we know button_down_time
11726 <= event->timestamp, so the difference must be nonnegative, so
11727 there's no need to cast the result if double-click-time is
11728 nonnegative, as it should be; check that it's nonnegative, just in
11729 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11730 apart (about 25 days). (Bug#8664)
8e55734a 11731
841f1b75 11732 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11733 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11734
3e26f69c
PE
11735 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11736 that always fit in int. Use a sentinel instead of a counter, to
11737 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11738 * frame.h (struct frame): Use int for menu_bar_items_used
11739 instead of EMACS_INT, since it always fits in int.
3e26f69c 11740
5cc152c0
PE
11741 * menu.c (grow_menu_items): Check for int overflow.
11742
d89eb65e
PE
11743 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11744
5235bd3e
PE
11745 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11746 Before, the code was not consistent. These values cannot exceed
11747 2**31 - 1 so there's no need to make them unsigned.
11748 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11749 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11750 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11751 as modifiers.
11752 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11753
bc827e23
PE
11754 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11755 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11756 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11757 presumably because the widths might not match.
11758
78eb494e
PE
11759 * window.c (size_window): Avoid needless test at loop start.
11760
04f2d78b
CB
117612011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11762
11763 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11764
d2fc7e3d 117652011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11766
11767 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11768
d2fc7e3d 117692011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11770
11771 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11772 `width' to `bar_area_x' and `bar_area_width', respectively.
11773 (x_scroll_run): Take account of fringe background extension.
11774
04f2d78b
CB
11775 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11776 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11777 `bar_area_width', respectively.
11778 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11779 background extension.
11780
79b70037
GM
117812011-05-10 Jim Meyering <meyering@redhat.com>
11782
11783 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11784
2f142cc5
JB
117852011-05-10 Juanma Barranquero <lekktu@gmail.com>
11786
11787 * image.c (Finit_image_library): Return t for built-in image types,
11788 like pbm and xbm. (Bug#8640)
11789
57679c86
AS
117902011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11791
11792 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11793
888c9e86
EZ
117942011-05-07 Eli Zaretskii <eliz@gnu.org>
11795
b0512a1d
EZ
11796 * w32console.c (Fset_screen_color): Doc fix.
11797 (Fget_screen_color): New function.
11798 (syms_of_ntterm): Defsubr it.
11799
7285dc67
EZ
11800 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11801 unlink the temporary file if Fcall_process didn't create it in the
11802 first place.
11803 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11804 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11805 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11806 cue to call_process_cleanup not to close that handle.
11807
4d3fcc8e
BK
118082011-05-07 Ben Key <bkey76@gmail.com>
11809
11810 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11811 one of two shell specific rules, either bootstrap-temacs-CMD or
11812 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11813 to the previous implementation of the bootstrap-temacs rule.
11814 The bootstrap-temacs-CMD rule is similar to the previous
11815 implementation of the bootstrap-temacs rule except that it
11816 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11817 variable.
11818
11819 These changes, along with some changes to nt/configure.bat,
11820 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11821 earlier fix to add support for --cflags and --ldflags options
11822 that include quotes so that it works whether make uses cmd or
11823 sh as the shell.
11824
b4289b64
MA
118252011-05-06 Michael Albinus <michael.albinus@gmx.de>
11826
11827 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11828 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11829 is a constant.
11830 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11831 a string. Handle both cases.
11832 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11833 (Fdbus_register_method): Use Qinvalid_function.
11834
af4c0e28
JB
118352011-05-06 Juanma Barranquero <lekktu@gmail.com>
11836
11837 * makefile.w32-in: Update dependencies.
11838 (LISP_H): Add inttypes.h and stdin.h.
11839 (PROCESS_H): Add unistd.h.
11840
c51453d9
EZ
118412011-05-06 Eli Zaretskii <eliz@gnu.org>
11842
11843 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11844 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11845
8ff0ac3c 118462011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11847
4c4b566b
PE
11848 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11849
aab2b9b5
PE
11850 * term.c (vfatal): Remove stray call to va_end.
11851 It's not needed and the C Standard doesn't allow it here anyway.
11852
c378da0b
PE
11853 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11854 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11855
288b08c7
PE
11856 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11857 bytes.
11858
e3601888
PE
11859 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11860
db6c0e74
PE
11861 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11862
dd5963ea
PE
11863 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11864
88c9450f
PE
11865 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11866
2f9442b8
PE
11867 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11868
c032b5f8
PE
11869 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11870 * charset.c (Fdefine_charset_internal): Don't initialize
11871 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11872 32-bit int (Bug#8600).
a108c10b
PE
11873
11874 * lread.c (read_integer): Be more consistent with string-to-number.
11875 Use string_to_number to do the actual conversion; this avoids
11876 rounding errors and fixes some other screwups. Without this fix,
11877 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11878 (digit_to_number): Move earlier, for benefit of read_integer.
11879 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11880 not a digit in any supported base. (Bug#8602)
a108c10b 11881
ad5f9eea
PE
11882 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11883
aec1708a
PE
11884 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11885 to match comment at start of function. This also removes a
11886 GCC warning about overflow in a 32+64-bit port.
11887
47be4ab5
PE
11888 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11889
371cac43
PE
11890 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11891 Reported by Stefan Monnier in
11892 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11893 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11894 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11895
d01a7826
PE
11896 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11897 (EMACS_UINTPTR): Likewise, with uintptr_t.
11898
7fd47d5c
PE
11899 * lisp.h: Prefer 64-bit EMACS_INT if available.
11900 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11901 on 32-bit hosts that have 64-bit int, so that they can access
11902 large files.
122b0c86
PE
11903 However, temporarily disable this change unless the temporary
11904 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11905
8727937b
PE
11906 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11907
8ac068ac
PE
11908 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11909 This removes an assumption that EMACS_INT and long are the same
11910 width as pointers. The assumption is true for Emacs porting targets
11911 now, but we want to make other targets possible.
11912 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11913 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11914 In the rest of the code, change types of integers that hold casted
11915 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11916 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11917 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11918 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11919 No need to cast type when ORing.
11920 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11921 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11922 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11923 assume EMACS_INT is the same width as char *.
11924 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11925 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11926 Remove no-longer-needed casts.
11927 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11928 (xg_tool_bar_help_callback, xg_make_tool_item):
11929 Use EMACS_INTPTR to hold an integer
11930 that will be cast to void *; this can avoid a GCC warning
11931 if EMACS_INT is not the same width as void *.
11932 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11933 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11934 (current_message_1, set_message_1):
11935 Use a local to convert to proper width without a cast.
11936 * xmenu.c (dialog_selection_callback): Likewise.
11937
ede49d71
PE
11938 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11939 Also, don't assume VALBITS / RAND_BITS is less than 5,
11940 and don't rely on undefined behavior when shifting a 1 left into
11941 the sign bit.
11942 * lisp.h (get_random): Change signature to match.
11943
2f30ecd0
PE
11944 * lread.c (hash_string): Use size_t, not int, for hash computation.
11945 Normally we prefer signed values; but hashing is special, because
11946 it's better to use unsigned division on hash table sizes so that
11947 the remainder is nonnegative. Also, size_t is the natural width
11948 for hashing into memory. The previous code used 'int', which doesn't
11949 retain enough info to hash well into very large tables.
11950 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11951
2a866e7b
PE
11952 * dbusbind.c: Don't possibly lose pointer info when converting.
11953 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11954 Use XPNTR rather than XHASH, so that the high-order bits of
11955 the pointer aren't lost when converting through void *.
11956
51639eac
PE
11957 * eval.c (Fautoload): Don't double-shift a pointer.
11958
92394119
PE
11959 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11960
dbdb9a7c
JB
119612011-05-06 Juanma Barranquero <lekktu@gmail.com>
11962
11963 * gnutls.c (DEF_GNUTLS_FN):
11964 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11965
db7a0b4f
AS
119662011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11967
11968 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11969 marker. (Bug#8610)
11970
cd394be1 119712011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11972
11973 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11974 New version that can reserve upto 2GB of heap space.
11975
f7ff1b0f 119762011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11977
11978 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11979
639c109b
TZ
119802011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11981
11982 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11983 `gnutls_certificate_set_x509_key_file'.
11984
d2127135
JB
119852011-05-05 Juanma Barranquero <lekktu@gmail.com>
11986
11987 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11988 Update dependencies.
11989
e968f4f3
JB
119902011-05-04 Juanma Barranquero <lekktu@gmail.com>
11991
11992 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11993 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11994 Remove unused parameter `fildes'.
11995 * process.c (read_process_output, send_process): Don't pass it.
11996
84d358f0
JB
119972011-05-04 Juanma Barranquero <lekktu@gmail.com>
11998
11999 Fix previous change: the library cache is defined in w32.c.
12000 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12001 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12002
0898ca10
JB
120032011-05-04 Juanma Barranquero <lekktu@gmail.com>
12004
12005 Implement dynamic loading of GnuTLS on Windows.
12006
12007 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12008 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12009 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12010 Declare.
12011
12012 * gnutls.c (Qgnutls_dll): Define.
12013 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12014 (gnutls_*): Declare function pointers.
12015 (init_gnutls_functions): New function to initialize function pointers.
12016 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12017 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12018 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12019 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12020 (emacs_gnutls_write, emacs_gnutls_read)
12021 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12022 (Fgnutls_available_p): New function.
12023 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12024 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12025 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12026
12027 * image.c: Include w32.h.
12028 (Vimage_type_cache): Delete.
12029 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12030 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12031 (w32_delayed_load): Move to w32.c.
12032
12033 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12034
12035 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12036 (w32_delayed_load): Move from image.c. When loading a library, record
12037 its filename in the :loaded-from property of the library id.
12038 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12039 Initialize and staticpro them.
12040 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12041
12042 * process.c: Include lisp.h before w32.h, not after.
12043 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12044 instead of gnutls_record_check_pending.
12045
12046 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12047
ff4de4aa
TZ
120482011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12049
12050 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12051 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12052 as passed in.
12053
abe95abb
JD
120542011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12055
12056 * xterm.c (x_set_frame_alpha): Do not set property on anything
12057 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12058
e16e55d4
JB
120592011-05-02 Juanma Barranquero <lekktu@gmail.com>
12060
12061 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12062
bafcf6a5
JB
120632011-05-02 Juanma Barranquero <lekktu@gmail.com>
12064
12065 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12066 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12067 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12068 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12069 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12070 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12071 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12072 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12073 (Qgnutls_bootprop_callbacks_verify): Make static.
12074
e7a6747f
AS
120752011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12076
19ed11ba
AS
12077 * callproc.c: Indentation fixup.
12078
e7a6747f 12079 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12080 (wait_for_termination, interruptible_wait_for_termination):
12081 Move after wait_for_termination_1.
e7a6747f 12082
1ef14cb4
LMI
120832011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12084
12085 * sysdep.c (interruptible_wait_for_termination): New function
12086 which is like wait_for_termination, but allows keyboard
12087 interruptions.
12088
12089 * callproc.c (Fcall_process): Add (:file "file") as an option for
12090 the STDOUT buffer.
12091 (Fcall_process_region): Ditto.
12092
330d880c
EZ
120932011-04-30 Eli Zaretskii <eliz@gnu.org>
12094
8db90b73
EZ
12095 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12096 rather than `XVECTOR (FOO)->size'.
12097
330d880c
EZ
12098 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12099 inttypes.h, as a gnulib replacement is used if it not available in
12100 system headers.
12101
15cbd324
EZ
121022011-04-21 Eli Zaretskii <eliz@gnu.org>
12103
12104 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12105 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12106 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12107
12108 * coding.c (coding_alloc_by_realloc): Error out if destination
12109 will grow beyond MOST_POSITIVE_FIXNUM.
12110 (decode_coding_emacs_mule): Abort if there isn't enough place in
12111 charbuf for the composition carryover bytes. Reserve an extra
12112 space for up to 2 characters produced in a loop.
12113 (decode_coding_iso_2022): Abort if there isn't enough place in
12114 charbuf for the composition carryover bytes.
12115
121162011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12117
ae940cca
EZ
12118 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12119 aborting when %lld or %lll format is passed.
12120 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12121 %llo or %llx format is passed. (Bug#8545)
12122
03ab8921
EZ
12123 * window.c (window_scroll_line_based): Use a marker instead of
12124 simple variables to record original value of point. (Bug#7952)
12125
afda1437
EZ
12126 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12127 produced by %s or %c overflows available buffer space. (Bug#8545)
12128
f76dee0c
PE
121292011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12130
12131 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12132 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12133
fdc5744d
JB
121342011-04-28 Juanma Barranquero <lekktu@gmail.com>
12135
12136 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12137
638f053a
JB
121382011-04-28 Juanma Barranquero <lekktu@gmail.com>
12139
12140 * keyboard.c (Qdelayed_warnings_hook): Define.
12141 (command_loop_1): Run `delayed-warnings-hook'
12142 if Vdelayed_warnings_list is non-nil.
12143 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12144 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12145
d178f871
EZ
121462011-04-28 Eli Zaretskii <eliz@gnu.org>
12147
12148 * doprnt.c (doprnt): Don't return value smaller than the buffer
12149 size if the message was truncated. (Bug#8545).
12150
b124fd93
JB
121512011-04-28 Juanma Barranquero <lekktu@gmail.com>
12152
12153 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12154 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12155
e810457d
PE
121562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12157
12158 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12159
ea51cceb
JB
121602011-04-27 Juanma Barranquero <lekktu@gmail.com>
12161
12162 * makefile.w32-in: Update dependencies.
12163
94dcfacf
EZ
121642011-04-27 Eli Zaretskii <eliz@gnu.org>
12165
12166 Improve `doprnt' and its usage. (Bug#8545)
12167 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12168 `format_end'. Remove support for %l as a conversion specifier.
12169 Don't use xrealloc. Improve diagnostics when the %l size modifier
12170 is used. Update the commentary.
12171
12172 * eval.c (verror): Simplify calculation of size_t.
12173
12174 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12175 messages.
12176
f61f41d7
PE
121772011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12178
12179 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12180 change.
12181
96fb4434
PE
121822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12183
12184 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12185 This makes this file independent of the recent pseudovector change.
12186
671875da 121872011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12188
69e9b5a3
PE
12189 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12190
b5f869a7 12191 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12192 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12193 Remove unused local.
c8926152 12194 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12195
841a1577 12196 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12197 GCC 4.6.0 optimizes based on type-based alias analysis.
12198 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12199 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12200 != &v->size, and therefore "v->size = 1; b->size = 2; return
12201 v->size;" must therefore return 1. This assumption is incorrect
12202 for Emacs, since it type-puns struct Lisp_Vector * with many other
12203 types. To fix this problem, this patch adds a new type struct
f904488f 12204 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12205 and pseudovectors, and helps optimizing compilers not get fooled
12206 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12207 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12208 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12209 the size member.
eab3844f
PE
12210 (XSETPVECTYPE): Rewrite in terms of new macro.
12211 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12212 This is a bit clearer, and further avoids the possibility of
12213 undesirable aliasing.
12214 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12215 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12216 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12217 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12218 (ASIZE): Now uses header.size rather than size.
12219 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12220 to avoid the hassle of writing XVECTOR (foo)->header.size.
12221 (struct vectorlike_header): New type.
eab3844f
PE
12222 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12223 object, to help avoid aliasing.
12224 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12225 (SUBRP): Likewise, since Lisp_Subr is a special case.
12226 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12227 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12228 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12229 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12230 changed to be "header.size" and "header.next".
12231 * buffer.h (struct buffer): Likewise.
12232 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12233 * frame.h (struct frame): Likewise.
12234 * process.h (struct Lisp_Process): Likewise.
12235 * termhooks.h (struct terminal): Likewise.
12236 * window.c (struct save_window_data, struct saved_window): Likewise.
12237 * window.h (struct window): Likewise.
12238 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12239 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12240 * buffer.c (init_buffer_once): Likewise.
12241 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12242 special case.
12243 * process.c (Fformat_network_address): Use local var for size,
12244 for brevity.
12245
0df1eac5
PE
12246 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12247
847ab9d1 12248 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12249 * data.c (atof): Remove decl; no longer used or needed.
12250 (digit_to_number): Move to lread.c.
12251 (Fstring_to_number): Use new string_to_number function, to be
12252 consistent with how the Lisp reader treats infinities and NaNs.
12253 Do not assume that floating-point numbers represent EMACS_INT
12254 without losing information; this is not true on most 64-bit hosts.
12255 Avoid double-rounding errors, by insisting on integers when
12256 parsing non-base-10 numbers, as the documentation specifies.
12257 * lisp.h (string_to_number): New decl, replacing ...
12258 (isfloat_string): Remove.
bc0a5c13 12259 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12260 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12261 appears to have been a coding error. Similarly, do not accept
12262 strings like +-1e0 as floating point numbers. Do not report
12263 overflow for integer overflows unless the base is not 10 which
12264 means we have no simple and reliable way to continue.
12265 Break out the floating-point parsing into a new
12266 function string_to_number, so that Fstring_to_number parses
12267 floating point numbers consistently with the Lisp reader.
04f2d78b 12268 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12269 (E_CHAR, EXP_INT): Remove, replacing with ...
12270 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12271 (string_to_number): New function, replacing isfloat_string.
12272 This function checks for valid syntax and produces the resulting
12273 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12274 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12275 so that overflow for non-base-10 numbers is reported only when
12276 there's no portable and simple way to convert to floating point.
452f4150 12277
67769ffc
PE
12278 * textprop.c (set_text_properties_1): Rewrite for clarity,
12279 and to avoid GCC warning about integer overflow.
12280
c20db43f
PE
12281 * intervals.h (struct interval): Use EMACS_INT for members
12282 where EMACS_UINT might cause problems. See
12283 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12284 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12285 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12286 All uses changed.
37aa2f85
PE
12287 (offset_intervals): Tell GCC not to worry about length overflow
12288 when negating a negative length.
c20db43f 12289
2538aa2f
PE
12290 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12291 (overrun_check_free): Likewise.
12292
f2d3008d
PE
12293 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12294 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12295 word size.
12296
ec8df744
PE
12297 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12298 (gnutls_make_error): Rename local to avoid shadowing.
12299 (gnutls_emacs_global_deinit): ifdef out; not used.
12300 (Fgnutls_boot): Use const for pointer to readonly storage.
12301 Comment out unused local. Fix pointer signedness problems.
12302
640ee02d
PE
12303 * lread.c (openp): Don't stuff size_t into an 'int'.
12304 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12305 about possible signed overflow.
12306
6048fb2a
PE
12307 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12308 (GDK_KEY_g): Don't define if already defined.
12309 (xg_prepare_tooltip): Avoid pointer signedness problem.
12310 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12311
fa3c87e1
PE
12312 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12313 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12314
2172544b
PE
12315 * xfns.c (Fx_window_property): Simplify a bit,
12316 to make a bit faster and to avoid GCC 4.6.0 warning.
12317 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12318
9b821a21
PE
12319 * fns.c (internal_equal): Don't assume size_t fits in int.
12320
3c616cfa
PE
12321 * alloc.c (compact_small_strings): Tighten assertion a little.
12322
c2982e87
PE
12323 Replace pEd with more-general pI, and fix some printf arg casts.
12324 * lisp.h (pI): New macro, generalizing old pEd macro to other
12325 conversion specifiers. For example, use "...%"pI"d..." rather
12326 than "...%"pEd"...".
12327 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12328 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12329 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12330 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12331 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12332 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12333 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12334 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12335 64-bit hosts.
12336 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12337 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12338 * print.c (safe_debug_print, print_object): Likewise.
12339 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12340 to int.
6f04d126
PE
12341 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12342 avoiding the 0 flag, which is not portable.
c2982e87
PE
12343 * process.c (Fmake_network_process): Use pI to avoid cast.
12344 * region-cache.c (pp_cache): Likewise.
12345 * xdisp.c (decode_mode_spec): Likewise.
12346 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12347 behavior on 64-bit hosts with printf arg.
6f04d126 12348 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12349 (x_stop_queuing_selection_requests): Likewise.
12350 (x_get_window_property): Don't truncate byte count to an 'int'
12351 when tracing.
0b432f21 12352
5e073ec7
PE
12353 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12354 here, since it parses constructs like leading '-' and spaces,
12355 which are not wanted; and it overflows with large numbers.
12356 Instead, simply match F[0-9]+, which is what is wanted anyway.
12357
36372bf9
PE
12358 * alloc.c: Remove unportable assumptions about struct layout.
12359 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12360 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12361 (allocate_vectorlike, make_pure_vector): Use the new macros,
12362 plus offsetof, to remove unportable assumptions about struct layout.
12363 These assumptions hold on all porting targets that I know of, but
12364 they are not guaranteed, they're easy to remove, and removing them
12365 makes further changes easier.
12366
0b432f21
PE
12367 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12368 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12369 (string_overrun_cookie): Now const. Use initializers that
12370 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12371 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12372 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12373 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12374 multiple of sizeof (EMACS_INT); it need not be, if
12375 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12376 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12377
895009e1
JB
123782011-04-26 Juanma Barranquero <lekktu@gmail.com>
12379
12380 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12381
6a7a1b0b
TZ
123822011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12383
12384 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12385 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12386 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12387
841a1577 123882011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12389
12390 * lisp.h (Qdebug): List symbol.
895009e1 12391 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12392 * keyboard.c (debug-on-event): New variable.
12393 (handle_user_signal): Break into debugger when debug-on-event
12394 matches the current signal symbol.
12395
f2d3ba6f
DN
123962011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12397
12398 * alloc.c (check_sblock, check_string_bytes)
12399 (check_string_free_list): Convert to standard C.
12400
42ce4c63
TZ
124012011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12402
12403 * w32.c (emacs_gnutls_push): Fix typo.
12404
825cd63c
EZ
124052011-04-25 Eli Zaretskii <eliz@gnu.org>
12406
fb11d64d
EZ
12407 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12408 "cast to pointer from integer of different size".
12409
825cd63c
EZ
12410 Improve doprnt and its use in verror. (Bug#8545)
12411 * doprnt.c (doprnt): Document the set of format control sequences
12412 supported by the function. Use SAFE_ALLOCA instead of always
12413 using `alloca'.
12414
12415 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12416 is one byte too soon. Don't use xrealloc; instead xfree and
12417 xmalloc anew.
12418
e061a11b
TZ
124192011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12420
12421 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12422 callbacks stage.
12423
12424 * gnutls.c: Renamed global_initialized to
12425 gnutls_global_initialized. Added internals for the
12426 :verify-hostname-error, :verify-error, and :verify-flags
12427 parameters of `gnutls-boot' and documented those parameters in the
12428 docstring. Start callback support.
9173deec
JB
12429 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12430 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12431 on error. Return error code.
e061a11b
TZ
12432 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12433 (emacs_gnutls_read): Likewise.
12434 (Fgnutls_boot): Return handshake error code.
12435 (emacs_gnutls_handle_error): New function.
12436 (wsaerror_to_errno): Likewise.
12437
12438 * w32.h (emacs_gnutls_pull): Add prototype.
12439 (emacs_gnutls_push): Likewise.
12440
12441 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12442 (emacs_gnutls_push): Likewise.
12443
124442011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12445
12446 * process.c (wait_reading_process_output): Check if GnuTLS
12447 buffered some data internally if no FDs are set for TLS
12448 connections.
12449
12450 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12451 (LIBS): Link to USER_LIBS.
12452 ($(BLD)/gnutls.$(0)): New target.
12453
fa6996bc
EZ
124542011-04-24 Eli Zaretskii <eliz@gnu.org>
12455
eb35682e
EZ
12456 * xdisp.c (handle_single_display_spec): Rename the
12457 display_replaced_before_p argument into display_replaced_p, to
12458 make it consistent with the commentary. Fix typos in the
12459 commentary.
12460
e2ad650c
EZ
12461 * textprop.c (syms_of_textprop): Remove dead code.
12462 (copy_text_properties): Delete obsolete commentary about an
12463 interface that was deleted long ago. Fix typos in the description
12464 of arguments.
12465
1b2de274
EZ
12466 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12467 to changes in oldXMenu/XMenu.h from 2011-04-16.
12468 <menu_help_message, prev_menu_help_message>: Constify.
12469 (IT_menu_make_room): menu->help_text is now `const char **';
12470 adjust.
12471
12472 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12473 to changes in oldXMenu/XMenu.h from 2011-04-16.
12474 (struct XMenu): Declare `help_text' `const char **'.
12475
12476 * xfaces.c <Qunspecified>: Make extern again.
12477
12478 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12479 required by POSIX.
1b2de274 12480
762b15be
EZ
12481 * doc.c (get_doc_string): Improve the format passed to `error'.
12482
12483 * doprnt.c (doprnt): Improve commentary.
12484
12485 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12486
12487 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12488 them with etags.
12489
f1052e5d
EZ
12490 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12491 changes in globals.h immediately force recompilation.
762b15be
EZ
12492 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12493 $(CURDIR)/s/ms-w32.h.
12494 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12495
fa6996bc
EZ
12496 * character.c (Fchar_direction): Function deleted.
12497 (syms_of_character): Don't defsubr it.
12498 <char-direction-table>: Deleted.
12499
e6c3da20
EZ
125002011-04-23 Eli Zaretskii <eliz@gnu.org>
12501
12502 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12503 * doprnt.c: Include limits.h.
12504 (SIZE_MAX): New macro.
04f2d78b
CB
12505 (doprnt): Return a size_t value. 2nd arg is now size_t.
12506 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12507 Improve overflow protection. Support `l' modifier for integer
12508 conversions. Support %l conversion. Don't assume an EMACS_INT
12509 argument for integer conversions and for %c.
12510
12511 * lisp.h (doprnt): Restore prototype.
12512
12513 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12514 $(SRC)/character.h.
12515
12516 * Makefile.in (base_obj): Add back doprnt.o.
12517
12518 * deps.mk (doprnt.o): Add back prerequisites.
12519 (callint.o): Depend on character.h.
12520
12521 * eval.c (internal_lisp_condition_case): Include the handler
12522 representation in the error message.
12523 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12524 when breaking from the loop.
12525
12526 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12527
12528 * callint.c (Fcall_interactively): When displaying error message
12529 about invalid control letter, pass the character's codepoint, not
12530 a pointer to its multibyte form. Improve display of the character
12531 in octal and display also its hex code.
12532
12533 * character.c (char_string): Use %x to display the (unsigned)
12534 codepoint of an invalid character, to avoid displaying a bogus
12535 negative value.
12536
12537 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12538 `error', not SYMBOL_NAME itself.
12539
12540 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12541 character arguments to `error'.
12542
12543 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12544 to `error' in error message about FINAL_CHAR argument. Make sure
12545 FINAL_CHAR is a character, and use %c when it is passed as
12546 argument to `error'.
12547
4ffd0d6b 125482011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12549
12550 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12551
12552 * w32.c: Include <time.h>.
12553 (sys_localtime): New function.
12554
4ffd0d6b 125552011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12556
12557 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12558
4ffd0d6b 12559 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12560
4ffd0d6b 125612011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12562
4ffd0d6b
GM
12563 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12564 zombies (Bug#8467).
aac0c6e3 12565
04c56954
EZ
125662011-04-19 Eli Zaretskii <eliz@gnu.org>
12567
12568 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12569 gl_state.e_property when gl_state.object is Qt.
12570
12571 * insdel.c (make_gap_larger): Remove limitation of buffer size
12572 to <= INT_MAX.
12573
16a43933
CY
125742011-04-18 Chong Yidong <cyd@stupidchicken.com>
12575
12576 * xdisp.c (lookup_glyphless_char_display)
12577 (produce_glyphless_glyph): Handle cons cell entry in
12578 glyphless-char-display.
12579 (Vglyphless_char_display): Document it.
12580
12581 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12582 glyphless-char-display.
12583
4581706e
CY
125842011-04-17 Chong Yidong <cyd@stupidchicken.com>
12585
12586 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12587
12588 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12589
12590 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12591 definition for no-X builds.
12592
4887c6e2 125932011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12594
fd35b6f9
PE
12595 Static checks with GCC 4.6.0 and non-default toolkits.
12596
5c1ccb01
PE
12597 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12598
006c5daa
PE
12599 * process.c (keyboard_bit_set): Define only if SIGIO.
12600 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12601 (send_process): Repair possible setjmp clobbering.
12602
efc736d3
PE
12603 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12604
4e2fe2e6
PE
12605 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12606
f97334a2
PE
12607 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12608
4e75f29d
PE
12609 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12610 Define only if needed.
12611
90efadd1
PE
12612 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12613 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12614 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12615
3c647824
PE
12616 * dispextern.h (struct redisplay_interface): Rename param
12617 to avoid shadowing.
e264f262 12618 * termhooks.h (struct terminal): Likewise.
761383f4 12619 * xterm.c (xembed_send_message): Likewise.
3c647824 12620
b58c5c4a
PE
12621 * insdel.c (make_gap_smaller): Define only if
12622 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12623
cad59032
PE
12624 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12625 it.
12626
c339dc2e
PE
12627 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12628 so that we aren't warned about unused symbols.
12629
91a3e27b
PE
12630 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12631
399c71d3 12632 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12633
8ffc96f5
PE
12634 * xfns.c (x_real_positions): Mark locals as initialized.
12635
eef9bc79
PE
12636 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12637
098db9dd
PE
12638 * xterm.c: Fix problems found by static analysis with other toolkits.
12639 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12640 (x_dispatch_event): Declare static if USE_GTK, and
12641 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12642 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12643 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12644 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12645 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12646
eb18f6cc
PE
12647 * xmenu.c (menu_help_callback): Pointer type fixes.
12648 Use const pointers when pointing at readonly data. Avoid pointer
12649 signedness clashes.
12650 (FALSE): Remove unused macro.
12651 (update_frame_menubar): Remove unused decl.
12652
1fe72bf8
PE
12653 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12654
60d9e1db
PE
12655 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12656 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12657 (single_menu_item): Rename local to avoid shadowing.
12658
39261c26
PE
12659 * keyboard.c (make_lispy_event): Remove unused local var.
12660
018c5e19
PE
12661 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12662 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12663
63d2b86e
PE
12664 * bitmaps: Change bitmaps from unsigned char back to the X11
12665 compatible char. Avoid the old compiler warnings about
12666 out-of-range initializers by using, for example, '\xab' rather
12667 than 0xab.
12668
aefd87e1
PE
12669 * xgselect.c (xgselect_initialize): Check vs interface
12670 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12671
bf501fb9
PE
12672 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12673
e9829fdf
PE
12674 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12675 to read-only memory.
12676
1086c095
PE
12677 * fns.c (vector): Remove; this old hack is no longer needed.
12678
2baccd04 12679 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12680 Remove unused var.
dde42981 12681 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12682
72391843 12683 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12684
436c16df 12685 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12686 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12687 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12688
92bb796d 12689 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12690 (x_term_init): Remove local to avoid shadowing.
92bb796d 12691
764430a3 12692 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12693
12694 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12695 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12696
d1dfb56c
EZ
126972011-04-16 Eli Zaretskii <eliz@gnu.org>
12698
c4354cb4
EZ
12699 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12700
d1dfb56c
EZ
12701 Fix regex.c, syntax.c and friends for buffers > 2GB.
12702 * syntax.h (struct gl_state_s): Declare character position members
12703 EMACS_INT.
12704
12705 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12706
04f2d78b
CB
12707 * textprop.c (verify_interval_modification, interval_of):
12708 Declare arguments EMACS_INT.
d1dfb56c
EZ
12709
12710 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12711 EMACS_INT.
12712
12713 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12714
12715 * indent.c (Fvertical_motion): Local variable it_start is now
12716 EMACS_INT.
12717
12718 * regex.c (re_match, re_match_2, re_match_2_internal)
12719 (bcmp_translate, regcomp, regexec, print_double_string)
12720 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12721 (re_compile_pattern, re_exec): Declare arguments and local
12722 variables `size_t' and `ssize_t' and return values `regoff_t', as
12723 appropriate.
12724 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12725 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12726 <compile_stack_type>: `size' and `avail' are now `size_t'.
12727
12728 * regex.h <regoff_t>: Use ssize_t, not int.
12729 (re_search, re_search_2, re_match, re_match_2): Arguments that
12730 specify buffer/string position and length are now ssize_t and
12731 size_t. Return type is regoff_t.
12732
613052cd
BK
127332011-04-16 Ben Key <bkey76@gmail.com>
12734
12735 * nsfont.m: Fixed bugs in ns_get_family and
12736 ns_descriptor_to_entity that were caused by using free to
12737 deallocate memory blocks that were allocated by xmalloc (via
12738 xstrdup). This caused Emacs to crash when compiled with
12739 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12740 --enable-checking=xmallocoverrun). xfree is now used to
12741 deallocate these memory blocks.
12742
4170f62f 127432011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12744
71b41406
PE
12745 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12746
9587a89d
PE
12747 emacs_write: Accept and return EMACS_INT for sizes.
12748 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12749 et seq.
12750 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12751 Accept and return EMACS_INT.
12752 (emacs_gnutls_write): Return the number of bytes written on
12753 partial writes.
12754 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12755 (emacs_read, emacs_write): Remove check for negative size, as the
12756 Emacs source code has been audited now.
9587a89d
PE
12757 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12758 (emacs_read, emacs_write): Use it.
273a5f82
PE
12759 * process.c (send_process): Adjust to the new signatures of
12760 emacs_write and emacs_gnutls_write. Do not attempt to store
12761 a byte offset into an 'int'; it might overflow.
9587a89d 12762 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12763
3e047f51
PE
12764 * sound.c: Don't assume sizes fit in 'int'.
12765 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12766 Return EMACS_INT, not int.
3e047f51 12767 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12768 Accept EMACS_INT, not int.
12769 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12770 record read return values.
12771
cc39a9db
BK
127722011-04-15 Ben Key <bkey76@gmail.com>
12773
c9d0ec6d
JB
12774 * keyboard.c (Qundefined): Don't declare static since it is used
12775 in nsfns.m.
12776 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12777 static since they are used in nsfont.m.
cc39a9db 12778
6c60eb9f
SM
127792011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12780
12781 * process.c (Qprocessp): Don't declare static.
12782 * lisp.h (Qprocessp): Declare again.
12783
7990b61a
JB
127842011-04-15 Juanma Barranquero <lekktu@gmail.com>
12785
12786 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12787
5d4cb038
PE
127882011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12789
8bd7b830 12790 Improve C-level modularity by making more things 'static'.
cd64ea1d 12791
e3b27b31
PE
12792 Don't publish debugger-only interfaces to other modules.
12793 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12794 (verify_bytepos, count_markers): Move decls to the only modules
12795 that need them.
12796 * region-cache.h (pp_cache): Likewise.
12797 * window.h (check_all_windows): Likewise.
12798 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12799
5d4cb038
PE
12800 * sysdep.c (croak): Now static, if
12801 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12802 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12803
12804 * alloc.c (refill_memory_reserve): Now static if
12805 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12806 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12807
e87b6180
PE
12808 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12809 Define only if USE_LUCID.
12810
ac64929e
PE
12811 * xrdb.c (x_customization_string, x_rm_string): Now static.
12812
6f37259d
PE
12813 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12814 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12815
1683e3ab
PE
12816 * xdisp.c (draw_row_with_mouse_face): Now static.
12817 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12818
de9c2632
PE
12819 * window.h (check_all_windows): Mark externally visible.
12820
2b96acb7
PE
12821 * window.c (window_deletion_count): Now static.
12822
12823 * undo.c: Make symbols static if they're not exported.
12824 (last_undo_buffer, last_boundary_position, pending_boundary):
12825 Now static.
12826
50436f33
PE
12827 * textprop.c (interval_insert_behind_hooks): Now static.
12828 (interval_insert_in_front_hooks): Likewise.
12829
64520e5c
PE
12830 * term.c: Make symbols static if they're not exported.
12831 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12832 (max_frame_lines, tty_set_terminal_modes):
12833 (tty_reset_terminal_modes, tty_turn_off_highlight):
12834 (get_tty_terminal): Now static.
12835 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12836 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12837 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12838 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12839 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12840
1fa53021
PE
12841 * sysdep.c: Make symbols static if they're not exported.
12842 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12843 Now static.
12844 (sigprocmask_set, full_mask): Remove; unused.
12845 (wait_debugging): Mark as visible.
12846 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12847 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12848
d4b43b22
PE
12849 * syntax.c (syntax_temp): Define only if !__GNUC__.
12850
b7c513d0
PE
12851 * sound.c (current_sound_device, current_sound): Now static.
12852
989b29ad
PE
12853 * search.c (searchbufs, searchbuf_head): Now static.
12854
13a55a78
PE
12855 * scroll.c (scroll_cost): Remove; unused.
12856 * dispextern.h (scroll_cost): Remove decl.
12857
de68a1fc
PE
12858 * region-cache.h (pp_cache): Mark as externally visible.
12859
40ccffa6
PE
12860 * process.c: Make symbols static if they're not exported.
12861 (process_tick, update_tick, create_process, chan_process):
12862 (Vprocess_alist, proc_buffered_char, datagram_access):
12863 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12864 (deactivate_process): Mark defn as static, as well as decl.
12865 * lisp.h (create_process): Remove decl.
12866 * process.h (chan_process, Vprocess_alist): Remove decls.
12867
ad64fc97
PE
12868 * print.c: Make symbols static if they're not exported.
12869 (print_depth, new_backquote_output, being_printed, print_buffer):
12870 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12871 (print_interval, print_number_index, initial_stderr_stream):
12872 Now static.
12873 * lisp.h (Fprinc): Remove decl.
12874 (debug_output_compilation_hack): Mark as externally visible.
12875
adddb265
PE
12876 * sysdep.c (croak): Move decl from here to syssignal.h.
12877 * syssignal.h (croak): Put it here, so the API can be checked when
12878 'croak' is called from dissociate_if_controlling_tty.
12879
1717ede2
PE
12880 * minibuf.c: Make symbols static if they're not exported.
12881 (minibuf_save_list, choose_minibuf_frame): Now static.
12882 * lisp.h (choose_minibuf_frame): Remove decl.
12883
fa5fb2bc
PE
12884 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12885
1e3890d1
PE
12886 * lread.c: Make symbols static if they're not exported.
12887 (read_objects, initial_obarray, oblookup_last_bucket_number):
12888 Now static.
12889 (make_symbol): Remove; unused.
12890 * lisp.h (initial_obarray, make_symbol): Remove decls.
12891
8a1414fa
PE
12892 * keyboard.c: Make symbols static if they're not exported.
12893 (single_kboard, recent_keys_index, total_keys, recent_keys):
12894 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12895 (this_single_command_key_start, echoing, last_auto_save):
12896 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12897 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12898 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12899 (Vlispy_mouse_stem, double_click_count):
12900 Now static.
12901 (force_auto_save_soon): Define only if SIGDANGER.
12902 (ignore_mouse_drag_p): Now static if
12903 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12904 (print_help): Remove; unused.
12905 (stop_character, last_timer_event): Mark as externally visible.
12906 * keyboard.h (ignore_mouse_drag_p): Declare only if
12907 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12908 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12909 * lisp.h (echoing): Remove decl.
12910 (force_auto_save_soon): Declare only if SIGDANGER.
12911 * xdisp.c (redisplay_window): Simplify code, to make it more
12912 obvious that ignore_mouse_drag_p is not accessed if !defined
12913 USE_GTK && !defined HAVE_NS.
12914
93ea6e8f
PE
12915 * intervals.c: Make symbols static if they're not exported.
12916 (merge_properties_sticky, merge_interval_right, delete_interval):
12917 Now static.
12918 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12919
77382fcc
PE
12920 * insdel.c: Make symbols static if they're not exported.
12921 However, leave prepare_to_modify_buffer alone. It's never
12922 called from outside this function, but that appears to be a bug.
12923 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12924 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12925 (adjust_after_replace_noundo): Remove; unused.
12926 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12927 (signal_before_change): Remove decls.
77382fcc 12928
9306c32e
PE
12929 * indent.c (val_compute_motion, val_vmotion): Now static.
12930
cd44d2eb
PE
12931 * image.c: Make symbols static if they're not exported.
12932 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12933 if USE_GTK.
12934 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12935 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12936
ad9a7a06
PE
12937 * fringe.c (standard_bitmaps): Now static.
12938 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12939
81626931
PE
12940 * frame.c: Make symbols static if they're not exported.
12941 (x_report_frame_params, make_terminal_frame): Now static.
12942 (get_frame_param): Now static, unless HAVE_NS.
12943 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12944 (x_get_resource_string): Remove; not used.
12945 * frame.h (make_terminal_frame, x_report_frame_params):
12946 (x_get_resource_string); Remove decls.
12947 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12948 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12949
239f9db9
PE
12950 * font.c, fontset.c: Make symbols static if they're not exported.
12951 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12952 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12953 * font.c (font_close_object): Now static.
12954 * font.h (font_close_object): Remove.
12955 * fontset.c (FONTSET_OBJLIST): Remove.
12956 (free_realized_fontset) #if-0 the body, which does nothing.
12957 (face_suitable_for_char_p): #if-0, as it's never called.
12958 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12959 * xfaces.c (face_at_string_position):
12960 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12961 since 0 is always ASCII.
12962
dfcf3579
PE
12963 * fns.c (weak_hash_tables): Now static.
12964
5045092b
PE
12965 * fileio.c: Make symbols static if they're not exported.
12966 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12967 (Vwrite_region_annotation_buffers): Now static.
12968
57a96f5c
PE
12969 * eval.c: Make symbols static if they're not exported.
12970 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12971 * lisp.h (backtrace_list): Remove decl.
12972
35f08c38
PE
12973 * emacs.c: Make symbols static if they're not exported.
12974 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12975 (fatal_error_code, fatal_error_signal_hook, standard_args):
12976 Now static.
12977 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12978 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12979 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12980 * lisp.h (fatal_error_signal_hook): Remove decl.
12981 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12982
f44bd759
PE
12983 * editfns.c: Move a (normally-unused) function to its only use.
12984 * editfns.c, lisp.h (get_operating_system_release): Remove.
12985 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12986 worth the hassle of breaking this out.
12987
b532497d
PE
12988 * xterm.c: Make symbols static if they're not exported.
12989 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12990 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12991 (x_destroy_window, x_delete_display):
12992 Now static.
12993 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12994 (x_mouse_leave): Remove; unused.
12995 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12996 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12997 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12998 Remove decls.
12999 (x_mouse_leave): Declare only if WINDOWSNT.
13000 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13001 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13002 USE_X_TOOLKIT.
13003
1675728f
PE
13004 * ftxfont.c: Make symbols static if they're not exported.
13005 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13006 HAVE_FREETYPE.
13007 * font.h (ftxfont_driver): Likewise.
13008
e4cebfca
PE
13009 * xfns.c: Make symbols static if they're not exported.
13010 (x_last_font_name, x_display_info_for_name):
13011 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13012 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13013 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13014 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13015 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13016 (last_show_tip_args): Now static.
13017 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13018 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13019 (x_screen_planes): Remove; unused.
13020 * dispextern.h (x_screen_planes): Remove decl.
13021
5bf46f05
PE
13022 * dispnew.c: Make symbols static if they're not exported.
13023 * dispextern.h (redraw_garbaged_frames, scrolling):
13024 (increment_row_positions): Remove.
13025 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13026 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13027 Now static.
13028 (redraw_garbaged_frames): Remove; unused.
13029
435f4c28
PE
13030 * xfaces.c: Make symbols static if they're not exported.
13031 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13032 Remove decls.
13033 * xterm.h (defined_color): Remove decls.
13034 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13035 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13036 (menu_face_changed_default, defined_color, free_realized_face):
13037 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13038 (ascii_face_of_lisp_face): Remove; unused.
13039
8524aef3
PE
13040 * xdisp.c: Make symbols static if they're not exported.
13041 * dispextern.h (scratch_glyph_row, window_box_edges):
13042 (glyph_to_pixel_coords, set_cursor_from_row):
13043 (get_next_display_element, set_iterator_to_next):
13044 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13045 (show_mouse_face): Remove decls
13046 * frame.h (message_buf_print): Likewise.
13047 * lisp.h (pop_message, set_message, check_point_in_composition):
13048 Likewise.
13049 * xterm.h (set_vertical_scroll_bar): Likewise.
13050 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13051 (message_buf_print, scratch_glyph_row, displayed_buffer):
13052 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13053 (get_next_display_element, show_mouse_face, window_box_edges):
13054 (frame_to_window_pixel_xy, check_point_in_composition):
13055 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13056 (glyph_to_pixel_coords): Remove; unused.
13057
16390cd2
PE
13058 * dired.c (file_name_completion): Now static.
13059
13060 * dbusbind.c (xd_in_read_queued_messages): Now static.
13061
a25f4dfa
PE
13062 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13063 * data.c (circular_list_error): Remove.
13064
14a9c8df
PE
13065 * commands.h (last_point_position, last_point_position_buffer):
13066 (last_point_position_window): Remove decls.
13067 * keyboard.c: Make these variables static.
13068
04f2d78b
CB
13069 * coding.h (coding, code_convert_region, encode_coding_gap):
13070 Remove decls.
74ab6df5
PE
13071 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13072 (iso_code_class, detect_coding, code_convert_region): Now static.
13073 (encode_coding_gap): Remove; unused.
13074
38dfbee1
PE
13075 * chartab.c (chartab_chars, chartab_bits): Now static.
13076
a2cb4e63
PE
13077 * charset.h (charset_iso_8859_1): Remove decl.
13078 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13079 Now static.
13080
127198fd
PE
13081 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13082 * ccl.c (Vccl_program_table): Now static.
13083 (check_ccl_update): Remove; unused.
13084
d85b608f
PE
13085 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13086 * category.h: ... from here.
13087 * category.c (check_category_table, set_category_set): Now static.
13088
31cd66f3
PE
13089 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13090 * lisp.h: Remove these decls.
13091
c358e587
PE
13092 * buffer.c (buffer_count): Remove unused var.
13093
e78aecca
PE
13094 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13095 so that it's not optimized away.
13096 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13097 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13098 exported only to the debugger.
13099
e192d7d3 13100 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13101 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13102
92470028
PE
13103 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13104 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13105 was inaccessible from Lisp.
13106 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13107 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13108
244ed907
PE
13109 alloc.c: Import and export fewer symbols, and remove unused items.
13110 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13111 is defined.
13112 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13113 it's not optimized away by whole-program optimization.
13114 (message_enable_multibyte, free_misc): Remove.
13115 (catchlist, handlerlist, mark_backtrace):
13116 Declare only if BYTE_MARK_STACK.
13117 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13118 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13119 (message_enable_multibyte): Remove decl.
13120 (free_misc, interval_free_list, float_block, float_block_index):
13121 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13122 (cons_free_list, last_marked_index):
13123 Now static.
13124 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13125 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13126 (mark_backtrace): Define only if BYTE_MARK_STACK.
13127 * xdisp.c (message_enable_multibyte): Now static.
13128
61c2b50e 13129 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13130 This makes it easier for human readers (and static analyzers)
13131 to see whether these variables are used from other modules.
13132 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13133 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13134 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13135 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13136 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13137 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13138 * xmenu.c, xselect.c:
13139 Declare Q* vars static if they are not used in other modules.
13140 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13141 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13142 Remove decls of unexported vars.
13143 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13144
95c82688
PE
13145 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13146
16a97296
PE
13147 Make Emacs functions such as Fatom 'static' by default.
13148 This makes it easier for human readers (and static analyzers)
13149 to see whether these functions can be called from other modules.
13150 DEFUN now defines a static function. To make the function external
13151 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13152 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13153 (Finit_image_library):
16a97296
PE
13154 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13155 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13156 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13157 Remove decls, since these functions are now static.
13158 (Funintern, Fget_internal_run_time): New decls, since these functions
13159 were already external.
95c82688 13160
16a97296
PE
13161 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13162 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13163 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13164 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13165 * keyboard.c, keymap.c, lread.c:
13166 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13167 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13168 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13169 Mark functions with DEFUE instead of DEFUN,
13170 if they are used in other modules.
13171 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13172 decls for now-static functions.
13173 * buffer.h (Fdelete_overlay): Remove decl.
13174 * callproc.c (Fgetenv_internal): Mark as internal.
13175 * composite.c (Fremove_list_of_text_properties): Remove decl.
13176 (Fcomposition_get_gstring): New forward static decl.
13177 * composite.h (Fcomposite_get_gstring): Remove decl.
13178 * dired.c (Ffile_attributes): New forward static decl.
13179 * doc.c (Fdocumntation_property): New forward static decl.
13180 * eval.c (Ffetch_bytecode): New forward static decl.
13181 (Funintern): Remove extern decl; now in .h file where it belongs.
13182 * fileio.c (Fmake_symbolic_link): New forward static decl.
13183 * image.c (Finit_image_library): New forward static decl.
13184 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13185 * intervals.h (Fprevious_property_change):
13186 (Fremove_list_of_text_properties): Remove decls.
13187 * keyboard.c (Fthis_command_keys): Remove decl.
13188 (Fcommand_execute): New forward static decl.
13189 * keymap.c (Flookup_key): New forward static decl.
13190 (Fcopy_keymap): Now static.
13191 * keymap.h (Flookup_key): Remove decl.
13192 * process.c (Fget_process): New forward static decl.
13193 (Fprocess_datagram_address): Mark as internal.
13194 * syntax.c (Fsyntax_table_p): New forward static decl.
13195 (skip_chars): Remove duplicate decl.
13196 * textprop.c (Fprevious_property_change): New forward static decl.
13197 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13198 Now internal.
13199 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13200 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13201
785bbd42
PE
13202 * editfns.c (Fformat): Remove unreachable code.
13203
8b913b57
AS
132042011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13205
13206 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13207 change. (Bug#8496)
13208
a6744a35
EZ
132092011-04-13 Eli Zaretskii <eliz@gnu.org>
13210
13211 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13212 when at ZV. (Bug#8487)
13213
e7974947
AS
132142011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13215
baad03f0
AS
13216 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13217 (Bug#8437)
13218 * keyboard.c (parse_tool_bar_item): Likewise.
13219 * sound.c (sound_cleanup, alsa_close): Likewise.
13220 * termcap.c (tgetent): Likewise.
13221 * xfns.c (x_default_font_parameter): Likewise.
13222 * xsettings.c (read_and_apply_settings): Likewise.
13223
e7974947
AS
13224 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13225 (overrun_check_free): Protoize.
13226
28272684
PE
132272011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13228
13229 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13230 since callers should never pass a negative size.
13231 Change the signature to match that of plain 'read' and 'write'; see
13232 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13233 * lisp.h: Update prototypes of emacs_write and emacs_read.
13234
11997c76
EZ
132352011-04-11 Eli Zaretskii <eliz@gnu.org>
13236
13237 * xdisp.c (redisplay_window): Don't try to determine the character
13238 position of the scroll margin if the window start point w->startp
e896f03c 13239 is outside the buffer's accessible region. (Bug#8468)
11997c76 13240
8a2cbd72
EZ
132412011-04-10 Eli Zaretskii <eliz@gnu.org>
13242
13243 Fix write-region and its subroutines for buffers > 2GB.
13244 * fileio.c (a_write, e_write): Modify declaration of arguments and
13245 local variables to support buffers larger than 2GB.
13246 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13247
13248 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13249 argument, local variables, and return value.
13250
13251 * lisp.h: Update prototypes of emacs_write and emacs_read.
13252
13253 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13254
4073e537 132552011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13256
1ebfdcb6
PE
13257 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13258
b2ded58d
PE
13259 Fix more problems found by GCC 4.6.0's static checks.
13260
7d66342c
PE
13261 * xdisp.c (vmessage): Use a better test for character truncation.
13262
bbf47d44
PE
13263 * charset.c (load_charset_map): <, not <=, for optimization,
13264 and to avoid potential problems with integer overflow.
9248994d 13265 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13266 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13267 * editfns.c (Fformat): Likewise.
1e69125e 13268 * syntax.c (skip_chars): Likewise.
3befa583 13269
e3019616
PE
13270 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13271 This also lets GCC 4.6.0 generate slightly better loop code.
13272
becfa255
PE
13273 * callint.c (Fcall_interactively): <, not <=, for optimization.
13274 (Fcall_interactively): Count the number of arguments produced,
13275 not the number of arguments given. This is simpler and lets GCC
13276 4.6.0 generate slightly better code.
13277
dae0cd48
PE
13278 * ftfont.c: Distingish more carefully between FcChar8 and char.
13279 The previous code passed unsigned char * to a functions like
13280 strlen and xstrcasecmp that expect char *, which does not
13281 conform to the C standard.
13282 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13283 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13284 char * when the C standard requires it.
13285
76032d70
PE
13286 * keyboard.c (read_char): Remove unused var.
13287
eb3f1cc8
PE
13288 * eval.c: Port to Windows vsnprintf (Bug#8435).
13289 Include <limits.h>.
13290 (SIZE_MAX): Define if the headers do not.
13291 (verror): Do not give up if vsnprintf returns a negative count.
13292 Instead, grow the buffer. This ports to Windows vsnprintf, which
13293 does not conform to C99. Problem reported by Eli Zaretskii.
13294 Also, simplify the allocation scheme, by avoiding the need for
13295 calling realloc, and removing the ALLOCATED variable.
13296
70476b54
PE
13297 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13298
12020a9e
PE
13299 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13300 But keep the doprint source code for now, as we might revamp it
13301 and use it again (Bug#8435).
ea6c7ae6
PE
13302 * lisp.h (doprnt): Remove.
13303 * Makefile.in (base_obj): Remove doprnt.o.
13304 * deps.mk (doprnt.o): Remove.
13305
5fdb398c
PE
13306 error: Print 32- and 64-bit integers portably (Bug#8435).
13307 Without this change, on typical 64-bit hosts error ("...%d...", N)
13308 was used to print both 32- and 64-bit integers N, which relied on
13309 undefined behavior.
61bdb816 13310 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13311 * lisp.h (error, verror): Mark as printf-like functions.
13312 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13313 Report overflow in size calculations when allocating printf buffer.
13314 Do not truncate output string at its first null byte.
13315 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13316 Truncate the output at a character boundary, since vsnprintf does not
13317 do that.
13318 * charset.c (check_iso_charset_parameter): Convert internal
13319 character to string before calling 'error', since %c now has the
13320 printf meaning.
13321 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13322 overflow when computing char to be passed to 'error'. Do not
13323 pass Lisp_Object to 'error'; pass the integer instead.
13324 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13325 formatted with plain %d.
13326
b189fa66
PE
13327 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13328
bff87ef0
PE
13329 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13330
7e2cac20
PE
13331 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13332
ce4d90b5
PE
13333 * xterm.c (x_catch_errors): Remove duplicate declaration.
13334
266c9547
PE
13335 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13336
79c49ad2
PE
13337 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13338
368f4090
JM
133392011-04-10 Jim Meyering <meyering@redhat.com>
13340
13341 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13342 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13343 return ssize_t not "int", and use size_t as the buffer length.
13344 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13345 * gnutls.h: Update declarations.
13346 * process.c (read_process_output): Use ssize_t, to match.
13347 (send_process): Likewise.
13348
a32d4040
CY
133492011-04-09 Chong Yidong <cyd@stupidchicken.com>
13350
13351 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13352
8546720e 133532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13354
04f2d78b
CB
13355 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13356 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13357
8546720e
GM
13358 * xterm.c (handle_one_xevent):
13359 * xmenu.c (create_and_show_popup_menu):
13360 * xselect.c (x_decline_selection_request)
13361 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13362
0a2f5c1a 133632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13364
13365 Fix some uses of `int' instead of EMACS_INT.
13366 * search.c (string_match_1, fast_string_match)
13367 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13368 (scan_buffer, find_next_newline_no_quit)
13369 (find_before_next_newline, search_command, Freplace_match)
13370 (Fmatch_data): Make some `int' variables be EMACS_INT.
13371
13372 * xdisp.c (display_count_lines): 3rd argument and return value now
13373 EMACS_INT. All callers changed.
13374 (pint2hrstr): Last argument is now EMACS_INT.
13375
13376 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13377 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13378 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13379 (decode_coding_utf_16, decode_coding_emacs_mule)
13380 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13381 (decode_coding_ccl, decode_coding_charset)
13382 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13383 (decode_coding_iso_2022, decode_coding_emacs_mule)
13384 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13385 <char_offset, last_offset>: Declare EMACS_INT.
13386 (encode_coding_utf_8, encode_coding_utf_16)
13387 (encode_coding_emacs_mule, encode_invocation_designation)
13388 (encode_designation_at_bol, encode_coding_iso_2022)
13389 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13390 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13391 Declare EMACS_INT.
13392 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13393 (encode_invocation_designation): Last argument P_NCHARS is now
13394 EMACS_INT.
13395 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13396 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13397
13398 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13399 All users changed.
13400
13401 * ccl.c (Fccl_execute_on_string): Declare some variables
13402 EMACS_INT.
13403
8546720e 134042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13405
13406 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13407
4e19a977
CS
134082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13409
13410 * process.c (Fformat_network_address): Doc fix.
13411
87302331
R
134122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13413
ee7683eb 13414 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13415
cbb59342
CY
134162011-04-08 Chong Yidong <cyd@stupidchicken.com>
13417
13418 * keyboard.c (read_char): Call Lisp function help-form-show,
13419 instead of using internal_with_output_to_temp_buffer.
13420 (Qhelp_form_show): New var.
e0d38eeb 13421 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13422
13423 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13424
13425 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13426
e67a13ab
CY
134272011-04-06 Chong Yidong <cyd@stupidchicken.com>
13428
04f2d78b
CB
13429 * process.c (Flist_processes): Remove to Lisp.
13430 (list_processes_1): Delete.
e67a13ab 13431
973f782d
EZ
134322011-04-06 Eli Zaretskii <eliz@gnu.org>
13433
7c106b1e
EZ
13434 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13435
973f782d
EZ
13436 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13437
41cf7d1a 134382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13439
ca23cc88
PE
13440 Fix more problems found by GCC 4.6.0's static checks.
13441
f390e2d5
PE
13442 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13443
42eea0d0
PE
13444 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13445
b69769da 13446 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13447
f9541e84
PE
13448 * xdisp.c (vmessage): Mark as a printf-like function.
13449
13841b55
PE
13450 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13451
c136c10f
PE
13452 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13453
5e2d4a30
PE
13454 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13455 printf-like functions.
13456 (tiff_load): Add casts to remove these marks before passing them
13457 to system-supplied API.
13458
583f48b9
PE
13459 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13460
b25d760e
PE
13461 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13462 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13463 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13464 directly, rather than having caller test rule sign. This avoids
13465 some unnecessary tests.
13466 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13467 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13468 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13469
bc7b6697 13470 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13471 (xfont_open): Avoid unnecessary tests.
bc7b6697 13472
27ccc379
PE
13473 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13474
dcd5c89a
PE
13475 * composite.h, composite.c (composition_gstring_put_cache):
13476 Use EMACS_INT, not int, for length.
13477
b13a45c6
PE
13478 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13479 breaking out part of COMPOSITION_DECODE_RULE.
13480 (COMPOSITION_DECODE_RULE): Use it.
13481 * composite.c (get_composition_id): Remove unused local vars,
13482 by using the new macro.
13483
1e792e4d
PE
13484 * textprop.c (set_text_properties_1): Change while to do-while,
13485 since the condition is always true at first.
13486
dc6c6455 13487 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13488 (interval_deletion_adjustment): Return unsigned value.
13489 All uses changed.
dc6c6455 13490
aba7731a
PE
13491 * process.c (list_processes_1, create_pty, read_process_output):
13492 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13493 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13494 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13495 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13496 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13497
fdfc4bf3
PE
13498 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13499
fca8fe46 13500 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13501 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13502
06a0259a 13503 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13504 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13505 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13506
e7b9e80f
PE
13507 * print.c (print_error_message): Avoid int overflow.
13508
56201685
PE
13509 * font.c (font_list_entities): Redo for clarity,
13510 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13511
78834453 13512 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13513 (font_score): Avoid potential overflow in diff calculation.
78834453 13514
0bc0b309 13515 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13516 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13517
e610eaca
PE
13518 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13519
b895abce
PE
13520 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13521 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13522 can always succeed if overflow has undefined behavior.
13523
1f1d9321 13524 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13525 (wordify): Omit three unnecessary tests.
1f1d9321 13526
c59478bc
PE
13527 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13528 All callers changed. This avoids the need for an unused var.
13529
79b73827
PE
13530 * casefiddle.c (casify_region): Remove var that is set but not used.
13531
a4db5dfe
PE
13532 * dired.c (file_name_completion): Remove var that is set but not used.
13533
43aae36e
PE
13534 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13535
2a47c44d 13536 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13537 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13538
a37c69bf
PE
13539 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13540 Check for integer overflow on size calculations.
13541
328ab8e7
PE
13542 * buffer.c (Fprevious_overlay_change): Remove var that is set
13543 but not used.
13544
e5a2a5cb
PE
13545 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13546 Remove vars that are set but not used.
8d84a6eb 13547 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13548 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13549
a60e5f68
PE
13550 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13551
f661cb61 13552 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13553 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13554
f0397f5a
PE
13555 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13556 that are set but not used.
13557
8664db06 13558 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13559 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13560
6abdaa4a
PE
13561 * xselect.c (x_get_local_selection, x_handle_property_notify):
13562 Remove vars that are set but not used.
13563
0ce7538d 13564 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13565 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13566
9ae848fc
PE
13567 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13568 Remove var that is set but not used.
0b918413
PE
13569 (scroll_bar_windows_size): Now size_t, not int.
13570 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13571 Check for overflow.
9ae848fc 13572
a5a62657
PE
13573 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13574 (map_tty_color) [!defined MSDOS]: Likewise.
13575
5c5cdd39
PE
13576 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13577
66ebf983
PE
13578 * coding.c: Remove vars that are set but not used.
13579 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13580 All callers changed.
13581 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13582 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13583 (decode_coding_charset): Remove vars that are set but not used.
13584
1be4d761
PE
13585 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13586 that is set but not used.
13587
47553fa8
PE
13588 * print.c (print_object): Remove var that is set but not used.
13589
1f7196bf 13590 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13591 The gnulib version avoids calling malloc in the usual case,
13592 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13593 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13594 * filelock.c (current_lock_owner): Likewise.
13595 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13596 * sysdep.c: Include allocator.h, careadlinkat.h.
13597 (emacs_no_realloc_allocator): New static constant.
13598 (emacs_readlink): New function.
fdb61804
PE
13599 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13600 ../lib/careadlinkat.h.
d1fdcab7 13601
f84c17c7
SM
136022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13603
13604 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13605 first non-nil return value).
13606
ef3862ad
JD
136072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13608
13609 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13610 if not defined (Bug#8403).
13611
376a7006
JB
136122011-04-02 Juanma Barranquero <lekktu@gmail.com>
13613
13614 * xdisp.c (display_count_lines): Remove parameter `start',
13615 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13616 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13617 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13618 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13619 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13620 and thereabouts. All callers changed.
13621 (get_per_char_metric): Remove parameter `f', unused since
13622 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13623
6ca3801d
JM
136242011-04-02 Jim Meyering <meyering@redhat.com>
13625
13626 do not dereference NULL upon failed strdup
13627 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13628 (ns_get_family): Likewise.
13629
d8e2b5ba
JB
136302011-04-02 Juanma Barranquero <lekktu@gmail.com>
13631
13632 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13633
8c74fcbd
JD
136342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13635
13636 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13637 later (Bug#8403).
13638
7200d79c
SM
136392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13640
03408648 13641 Add lexical binding.
7200d79c 13642
03408648
SM
13643 * window.c (Ftemp_output_buffer_show): New fun.
13644 (Fsave_window_excursion):
13645 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13646
13647 * lread.c (lisp_file_lexically_bound_p): New function.
13648 (Fload): Bind Qlexical_binding.
13649 (readevalloop): Remove `evalfun' arg.
13650 Bind Qinternal_interpreter_environment.
13651 (Feval_buffer): Bind Qlexical_binding.
13652 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13653 Mark as dynamic.
13654 (syms_of_lread): Declare `lexical-binding'.
13655
13656 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13657
13658 * keyboard.c (eval_dyn): New fun.
13659 (menu_item_eval_property): Use it.
ca105506
SM
13660
13661 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13662
03408648
SM
13663 * fns.c (concat, mapcar1): Accept byte-code-functions.
13664
13665 * eval.c (Fsetq): Handle lexical vars.
13666 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13667 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13668 (FletX, Flet): Obey lexical binding.
13669 (Fcommandp): Handle closures.
13670 (Feval): New `lexical' arg.
13671 (eval_sub): New function extracted from Feval. Use it almost
13672 everywhere where Feval was used. Look up vars in lexical env.
13673 Handle closures.
13674 (Ffunctionp): Move from subr.el.
13675 (Ffuncall): Handle closures.
13676 (apply_lambda): Remove `eval_flags'.
13677 (funcall_lambda): Handle closures and new byte-code-functions.
13678 (Fspecial_variable_p): New function.
13679 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13680 but without exporting it to Lisp.
23aba0ea 13681
23aba0ea 13682 * doc.c (Fdocumentation, store_function_docstring):
03408648 13683 * data.c (Finteractive_form): Handle closures.
23aba0ea 13684
03408648
SM
13685 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13686 interactive spec.
ba83908c 13687
04f2d78b
CB
13688 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13689 New byte-codes.
03408648
SM
13690 (exec_byte_code): New function extracted from Fbyte_code to handle new
13691 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13692
03408648 13693 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13694
03408648 13695 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13696
e2abce01
JB
136972011-03-31 Juanma Barranquero <lekktu@gmail.com>
13698
13699 * xdisp.c (redisplay_internal): Fix prototype.
13700
63696a73 137012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13702
63696a73 13703 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13704 (try_scrolling): Use it when setting scroll_limit.
13705 Limit scrolling to 100 screen lines.
63696a73
EZ
13706 (redisplay_window): Even when falling back on "recentering",
13707 position point in the window according to scroll-conservatively,
13708 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13709
13710 (try_scrolling): When point is above the window, allow searching
13711 as far as scroll_max, or one screenful, to compute vertical
13712 distance from PT to the scroll margin position. This prevents
13713 try_scrolling from unnecessarily failing when
13714 scroll-conservatively is set to a value slightly larger than the
13715 window height. Clean up the case of PT below the margin at bottom
13716 of window: scroll_max can no longer be INT_MAX. When aggressive
13717 scrolling is in use, don't let point enter the opposite scroll
13718 margin as result of the scroll.
13719 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13720 threshold of 100 lines for never-recentering scrolling.
13721
e4cc2dfc
JB
137222011-03-31 Juanma Barranquero <lekktu@gmail.com>
13723
13724 * dispextern.h (move_it_by_lines):
13725 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13726 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13727 (message_log_check_duplicate): Remove parameters `prev_bol' and
13728 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13729 (redisplay_internal): Remove parameter `preserve_echo_area',
13730 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13731
13732 * indent.c (Fvertical_motion):
13733 * window.c (window_scroll_pixel_based, Frecenter):
13734 Don't pass `need_y_p' to `move_it_by_lines'.
13735
1c470562
SM
137362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13737
44f230aa
SM
13738 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13739 steal a few bits to be more compact.
13740 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13741 Remove unneeded casts.
13742
1c470562
SM
13743 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13744
888adce9
ZK
137452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13746
13747 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13748 binding" message (bug#7967).
13749
f838ed7b
PE
137502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13751
77861b95
PE
13752 Fix more problems found by GCC 4.6.0's static checks.
13753
de6dbc14
PE
13754 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13755 Remove unused local var.
13756
f838ed7b
PE
13757 * editfns.c (Fmessage_box): Remove unused local var.
13758
792c7b2b
PE
13759 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13760 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13761 Omit unused local vars.
c499e557 13762 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13763 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13764 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13765 Omit unused local var.
13766
ba0165e1
PE
13767 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13768 Don't assume string length fits in int.
32ad8845 13769 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13770 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13771
3c59b4c9
PE
13772 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13773 instead of alloca (Bug#8344).
13774
a3eed478 13775 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13776 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13777
eb4d412d
PE
13778 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13779
1658b401
PE
13780 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13781 concerns.
13782
13783 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13784
13785 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13786
9a2c6e05
PE
13787 * keyboard.c (syms_of_keyboard): Use the same style as later
13788 in this function when indexing through an array. This also
13789 works around GCC bug 48267.
13790
03d0a109
PE
13791 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13792
44f730c8
PE
13793 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13794
fe75f926
PE
13795 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13796 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13797
ffa8c828
PE
13798 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13799 This avoids undefined behavior on integer overflow, and is a bit
13800 more convenient anyway since it is compared to a size_t variable.
13801
c5101a77
PE
13802 Variadic C functions now count arguments with size_t, not int.
13803 This avoids an unnecessary limitation on 64-bit machines, which
13804 caused (substring ...) to crash on large vectors (Bug#8344).
13805 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13806 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13807 All variadic functions and their callers changed accordingly.
c5101a77
PE
13808 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13809 * data.c (arith_driver, float_arith_driver): Likewise.
13810 * editfns.c (general_insert_function): Likewise.
13811 * eval.c (struct backtrace.nargs, interactive_p)
13812 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13813 (funcall_lambda, mark_backtrace): Likewise.
13814 * fns.c (concat): Likewise.
13815 * frame.c (x_set_frame_parameters): Likewise.
13816 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13817 0 if not found, not -1. All callers changed.
13818
dd3f25f7
PE
13819 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13820 (stack_copy_size): Now size_t, not int.
13821 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13822
461c2ab9
JB
138232011-03-28 Juanma Barranquero <lekktu@gmail.com>
13824
13825 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13826 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13827 All callers changed.
13828
13829 * lisp.h (multibyte_char_to_unibyte):
13830 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13831 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13832 * character.h (CHAR_TO_BYTE8):
13833 * cmds.c (internal_self_insert):
13834 * editfns.c (general_insert_function):
13835 * keymap.c (push_key_description):
13836 * search.c (Freplace_match):
13837 * xdisp.c (message_dolog, set_message_1): All callers changed.
13838
f6d62986
SM
138392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13840
13841 * keyboard.c (safe_run_hook_funcall): New function.
13842 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13843 don't set the hook to nil, but remove the offending function instead.
13844 (Qcommand_hook_internal): Remove, unused.
13845 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13846 Vcommand_hook_internal.
13847
13848 * eval.c (enum run_hooks_condition): Remove.
13849 (funcall_nil, funcall_not): New functions.
13850 (run_hook_with_args): Call each function through a `funcall' argument.
13851 Remove `cond' argument, now redundant.
13852 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13853 (Frun_hook_with_args_until_failure): Adjust accordingly.
13854 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13855
1db5b1ad
JB
138562011-03-28 Juanma Barranquero <lekktu@gmail.com>
13857
13858 * dispextern.h (string_buffer_position): Remove declaration.
13859
13860 * print.c (strout): Remove parameter `multibyte', unused since
13861 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13862
13863 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13864 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13865 All callers changed.
13866
13867 * w32.c (_wsa_errlist): Use braces for struct initializers.
13868
13869 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13870 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13871 All callers changed.
13872 (string_buffer_position): Likewise. Also, make static (it's never
13873 used outside xdisp.c).
13874 (cursor_row_p): Remove parameter `w', unused since
13875 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13876 (decode_mode_spec): Remove parameter `precision', introduced during
13877 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13878 All callers changed.
13879
5ffb62aa
JD
138802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13881
13882 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13883
461c2ab9 138842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13885
13886 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13887 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13888 (ns_update_auto_hide_menu_bar): New functions.
13889 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13890 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13891 ns_constrain_all_frames.
13892 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13893 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13894
5c380ffb
JD
138952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13896
13897 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13898
9af30bdf
GM
138992011-03-27 Glenn Morris <rgm@gnu.org>
13900
13901 * syssignal.h: Replace RETSIGTYPE with void.
13902 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13903 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13904 Replace SIGTYPE with void everywhere.
13905 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13906 * s/template.h (SIGTYPE): Remove commented out definition.
13907
e2abce01
JB
139082011-03-26 Eli Zaretskii <eliz@gnu.org>
13909
13910 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13911 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13912
f868cd8a
JB
139132011-03-26 Juanma Barranquero <lekktu@gmail.com>
13914
59eb0929
JB
13915 * w32.c (read_unc_volume): Use parameter `henum', instead of
13916 global variable `wget_enum_handle'.
13917
13918 * keymap.c (describe_vector): Remove parameters `indices' and
13919 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13920 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13921
f868cd8a
JB
13922 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13923
13924 * keyboard.c (timer_check): Remove parameter `do_it_now',
13925 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13926 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13927 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13928
13929 * keyboard.c (read_char):
13930 * w32menu.c (w32_menu_display_help):
13931 * xmenu.c (show_help_event, menu_help_callback):
13932 Adjust calls to `show_help_echo'.
13933
13934 * gtkutil.c (xg_maybe_add_timer):
13935 * keyboard.c (readable_events):
13936 * process.c (wait_reading_process_output):
13937 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13938
13939 * insdel.c (adjust_markers_gap_motion):
13940 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13941 (gap_left, gap_right): Don't call it.
13942
2ecf6fdb
CY
139432011-03-25 Chong Yidong <cyd@stupidchicken.com>
13944
13945 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13946 incurred during fontification.
13947
6b1f9ba4
JB
139482011-03-25 Juanma Barranquero <lekktu@gmail.com>
13949
13950 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13951 (DEFVAR_PER_BUFFER): Don't pass it.
13952
13953 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13954 (scrolling_window): Don't pass it.
13955
0f4a96b5
JB
139562011-03-25 Juanma Barranquero <lekktu@gmail.com>
13957
13958 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13959
13960 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13961 and `suffix'.
13962 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13963 of variables specific to SELinux and computation of `encoded_absname'.
13964
13965 * image.c (XPutPixel): Remove unused variable `height'.
13966
13967 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13968
13969 * unexw32.c (get_section_info): Remove unused variable `section'.
13970
13971 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13972 (system_process_attributes): Remove unused variable `sess'.
13973 (sys_read): Remove unused variable `err'.
13974
13975 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13976 (w32_wnd_proc): Remove unused variable `isdead'.
13977 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13978 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13979 (x_create_tip_frame): Remove unused variable `tem'.
13980
13981 * w32inevt.c (w32_console_read_socket):
13982 Remove unused variable `no_events'.
13983
13984 * w32term.c (x_draw_composite_glyph_string_foreground):
13985 Remove unused variable `width'.
13986
1149507c
JB
139872011-03-24 Juanma Barranquero <lekktu@gmail.com>
13988
13989 * w32term.c (x_set_glyph_string_clipping):
13990 Don't pass uninitialized region to CombineRgn.
13991
9c88f339
JB
139922011-03-23 Juanma Barranquero <lekktu@gmail.com>
13993
13994 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13995 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13996 (Fx_close_connection): Remove unused variable `i'.
13997
13998 * w32font.c (w32font_draw): Return number of glyphs.
13999 (w32font_open_internal): Remove unused variable `i'.
14000 (w32font_driver): Add missing initializer.
14001
14002 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14003 (fill_in_menu): Remove unused variable `items_added'.
14004
14005 * w32term.c (last_mouse_press_frame): Remove static global variable.
14006 (w32_clip_to_row): Remove unused variable `f'.
14007 (x_delete_terminal): Remove unused variable `i'.
14008
14009 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14010 (NOTHING): Remove unused static global variable.
14011 (uniscribe_check_otf): Remove unused variable `table'.
14012 (uniscribe_font_driver): Add missing initializers.
14013
dee091a3
JD
140142011-03-23 Julien Danjou <julien@danjou.info>
14015
14016 * term.c (Fsuspend_tty, Fresume_tty):
14017 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14018 * window.c (temp_output_buffer_show):
14019 * insdel.c (signal_before_change):
14020 * frame.c (Fhandle_switch_frame):
14021 * fileio.c (Fdo_auto_save):
14022 * emacs.c (Fkill_emacs):
14023 * editfns.c (save_excursion_restore):
14024 * cmds.c (internal_self_insert):
14025 * callint.c (Fcall_interactively):
14026 * buffer.c (Fkill_all_local_variables):
14027 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14028 Use Frun_hooks.
0f4a96b5 14029 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14030 unconditionally since it does the check itself.
dee091a3 14031
2c520ab5 140322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14033
c9c49752
PE
14034 Fix more problems found by GCC 4.5.2's static checks.
14035
8abc3f12
PE
14036 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14037 the first time through the loop, since we know p0 < p1 then.
14038 This also avoids a gcc -Wstrict-overflow warning.
14039
a2d26660
PE
14040 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14041 leading to a memory leak, possible in functions like
14042 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14043 of objects (Bug#8318).
a2d26660 14044
916c72e9
PE
14045 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14046 that could (at least in theory) be that large.
14047
19ab8a18
PE
14048 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14049 This is less likely to overflow, and avoids undefined behavior if
14050 overflow does occur. All callers changed. Use strtoul to scan
14051 for the unsigned long integer.
b7cbbd6f
PE
14052 (pint2hrstr): Simplify and tune code slightly.
14053 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14054
f0641eff
PE
14055 * scroll.c (do_scrolling): Work around GCC bug 48228.
14056 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14057
7f650bb9
PE
14058 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14059 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14060 (validate_x_resource_name): Simplify count usage.
14061 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14062
37dd57d1
PE
14063 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14064 fail (Bug#8306).
81e56e61 14065
699979fc 14066 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14067
401bf9b4
PE
14068 * process.c (Fmake_network_process): Use socklen_t, not int,
14069 where POSIX says socklen_t is required in portable programs.
14070 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14071 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14072 (Fmake_network_process, server_accept_connection):
14073 (wait_reading_process_output, read_process_output):
14074 Likewise.
14075
b93aacde
PE
14076 * process.c: Rename or move locals to avoid shadowing.
14077 (list_processes_1, Fmake_network_process):
14078 (read_process_output_error_handler, exec_sentinel_error_handler):
14079 Rename or move locals.
4dc343ee 14080 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14081 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14082 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14083 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14084 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14085
af8a867c 14086 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14087 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14088 Include tparam.h instead, since it declares them.
af8a867c
PE
14089 * cm.h (PC): Remove extern decl; tparam.h now does this.
14090 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14091 * terminfo.c: Include tparam.h, to check interfaces.
14092 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14093 (tparam): Adjust signature to match interface in tparam.h;
14094 this removes some undefined behavior. Check that outstring and len
14095 are zero, which they always are with Emacs.
14096 * tparam.h (PC, BC, UP): New extern decls.
14097
0248044d 14098 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14099 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14100
8ff096c1 14101 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14102 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14103 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14104 (ftfont_list): Remove unused local.
49eaafba
PE
14105 (get_adstyle_property, ftfont_pattern_entity):
14106 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14107 Rename locals to avoid shadowing.
8ff096c1 14108
e2be39f6
PE
14109 * xfont.c (xfont_list_family): Mark var as initialized.
14110
c9735e30
PE
14111 * xml.c (make_dom): Now static.
14112
8f5201ae
PE
14113 * composite.c (composition_compute_stop_pos): Rename local to
14114 avoid shadowing.
b246f932
PE
14115 (composition_reseat_it): Remove unused locals.
14116 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14117 (composition_update_it): Mark var as initialized.
11b61122
PE
14118 (find_automatic_composition): Mark vars as initialized,
14119 with a FIXME (Bug#8290).
8f5201ae 14120
760fbc2c
PE
14121 character.h: Rename locals to avoid shadowing.
14122 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14123 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14124 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14125 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14126 to avoid shadowing.
14127
ff08eb85
PE
14128 * textprop.c (property_change_between_p): Remove; unused.
14129
fc7bf025
PE
14130 * intervals.c (interval_start_pos): Now static.
14131
235d7abc
PE
14132 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14133
44f230aa
SM
14134 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14135 Rename locals to avoid shadowing.
3e7d6594 14136
50060332
PE
14137 * sound.c (wav_play, au_play, Fplay_sound_internal):
14138 Fix pointer signedness.
d01f234b 14139 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14140 (wav_play): Initialize a variable to 0, to prevent undefined
14141 behavior (Bug#8278).
50060332 14142
c4fc4e30
PE
14143 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14144
918436ed
PE
14145 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14146
c939f91b
PE
14147 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14148 clobbering (Bug#8298).
b9c7f648
PE
14149 * sysdep.c (sys_subshell): Likewise.
14150 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14151
6bd8c144
PE
14152 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14153 This should get cleaned up, so that child_setup has the
14154 same signature on all platforms.
14155
7710357c 14156 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14157 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14158
c59da222
CY
141592011-03-22 Chong Yidong <cyd@stupidchicken.com>
14160
14161 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14162 not to be necessary, and produces flickering.
14163
66b87493
GM
141642011-03-20 Glenn Morris <rgm@gnu.org>
14165
14166 * config.in: Remove file.
14167
45b6f6d5
JB
141682011-03-20 Juanma Barranquero <lekktu@gmail.com>
14169
14170 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14171 are now in src/globals.h.
14172 (syms_of_minibuf): Remove spurious & from previous change.
14173
cd394be1 141742011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14175
14176 * minibuf.c (completing-read-function): New variable.
14177 (completing-read-default): Rename from completing-read.
14178 (completing-read): Call completing-read-function.
14179
b14e3e21
CY
141802011-03-19 Juanma Barranquero <lekktu@gmail.com>
14181
14182 * xfaces.c (Fx_load_color_file):
14183 Read color file from absolute filename (bug#8250).
14184
f2b726e6
JB
141852011-03-19 Juanma Barranquero <lekktu@gmail.com>
14186
14187 * makefile.w32-in: Update dependencies.
14188
09f6ff02
EZ
141892011-03-17 Eli Zaretskii <eliz@gnu.org>
14190
14191 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14192
29a6015a
PE
141932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14194
a3a6c54e
PE
14195 Fix more problems found by GCC 4.5.2's static checks.
14196
b766f867
PE
14197 * process.c (make_serial_process_unwind, send_process_trap):
14198 (sigchld_handler): Now static.
14199
be02381c
PE
14200 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14201 That way, the code declares only the vars that it needs.
14202 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14203 * s/cygwin.h (PTY_ITERATION): Likewise.
14204 * s/darwin.h (PTY_ITERATION): Likewise.
14205 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14206
57048744
PE
14207 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14208 * process.c (allocate_pty): Don't declare stb unless it's needed.
14209
7914961c 14210 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14211 (CONSTANTLIM): Remove; unused.
14212 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14213 Define only if needed.
7914961c 14214
b3967b18
PE
14215 * unexelf.c (unexec): Name an expression,
14216 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14217 Use a different way to cause a compilation error if anyone uses
14218 n rather than nn, a way that does not involve shadowing.
73366a00 14219 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14220
29a6015a
PE
14221 * deps.mk (unexalpha.o): Remove; unused.
14222
43cfc33e 14223 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14224 * unexec.h: New file.
ce701a33
PE
14225 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14226 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14227 Depend on unexec.h.
14228 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14229 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14230 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14231 Change as necessary to match prototype in unexec.h.
ce701a33 14232
01f44d5a
PE
14233 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14234 shadowing.
4f63c6bb 14235 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14236
a6670b0b
PE
14237 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14238 Rename locals to avoid shadowing.
14239
cef2010d 14240 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14241 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14242
d4d7173a
PE
14243 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14244
f08b802a
PE
14245 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14246 warning when compiling print.c.
14247
3ddb0639
PE
14248 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14249 instead of using an uninitialized var.
5ad03b97 14250 (font_sort_entities): Mark var as initialized.
3ddb0639 14251
170a2692
PE
14252 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14253
e663c700
PE
14254 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14255 pointers to constants.
89bc529a 14256 (font_parse_fcname): Remove unused vars.
7b81e2d0 14257 (font_delete_unmatched): Now static.
ea838e10 14258 (font_get_spec): Remove; unused.
13a547c6
PE
14259 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14260 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14261 Rename or move locals to avoid shadowing.
e663c700 14262
2a80c887 14263 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14264 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14265
1384fa33 14266 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14267 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14268
8b2c52e9
PE
14269 * alloc.c (mark_backtrace): Move decl from here ...
14270 * lisp.h: ... to here, so that it can be checked.
14271
475545b5 14272 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14273 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14274 (lisp_indirect_variable): Name an expression,
14275 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14276 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14277
b1349114 14278 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14279 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14280 Use const pointer when appropriate.
b1349114 14281
a2928364
PE
14282 * lisp.h (get_system_name, get_operating_system_release):
14283 Move decls here, to check interfaces.
14284 * process.c (get_operating_system_release): Move decl to lisp.h.
14285 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14286 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14287 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14288 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14289 (Fformat_time_string, Fencode_time, Finsert_char):
14290 (Ftranslate_region_internal, Fformat):
14291 Rename or remove local vars to avoid shadowing.
9710023e 14292 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14293
a415e694
PE
14294 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14295 avoid shadowing.
14296
8ef4622d
PE
14297 * lisp.h (eassert): Check that the argument compiles, even if
14298 ENABLE_CHECKING is not defined.
14299
946f9a5b
PE
14300 * data.c (Findirect_variable): Name an expression, to avoid
14301 gcc -Wbad-function-cast warning.
112396d6 14302 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14303 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14304 (Fmake_variable_buffer_local, Fmake_local_variable):
14305 Mark variables as initialized.
52746918 14306 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14307
e5aab7e7 14308 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14309 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14310 Rename locals to avoid shadowing.
dff45157
PE
14311 (mark_stack): Move local variables into the #ifdef region where
14312 they're used.
7bc26fdb
PE
14313 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14314 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14315 needed otherwise.
14316 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14317 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14318 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14319
e5aab7e7
PE
14320 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14321 avoids undefined behavior in theory.
14322
4da60324
PE
14323 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14324
88043301
PE
14325 Use functions, not macros, for up- and down-casing (Bug#8254).
14326 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14327 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14328 to use the following functions instead of these macros.
14329 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14330 EMACS_INT, since callers assume the returned value fits in int.
14331 (upcase1): Likewise, for UPCASE_TABLE.
14332 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14333 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14334 the race-condition problem in the old DOWNCASE.
88043301 14335
19ed5445
PE
14336 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14337 Rename locals to avoid shadowing.
14338 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14339 (regex_compile, re_search_2, re_match_2_internal):
14340 Remove unused local vars.
952db0d7
PE
14341 (FREE_VAR): Rewrite so as not to use empty "else",
14342 which gcc can warn about.
da053e48 14343 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14344 (RETALLOC_IF): Define only if needed.
14345 (WORDCHAR_P): Likewise. This one is never needed, but is used
14346 only in a comment talking about a compiler bug, so put inside
14347 the #if 0 of that comment.
14348 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14349 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14350 Remove; unused.
19ed5445 14351
1f3561e4 14352 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14353 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14354 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14355
ded6f8f7
PE
14356 * search.c (simple_search): Remove unused var.
14357
dbd37a95
PE
14358 * dired.c (compile_pattern): Move decl from here ...
14359 * lisp.h: ... to here, so that it can be checked.
14360 (struct re_registers): New forward decl.
14361
7e47afad
PE
14362 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14363
85f24f61
PE
14364 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14365 All uses changed.
14366 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14367 Rename locals to avoid shadowing.
5671df8f 14368 (Fvertical_motion): Mark locals as initialized.
85f24f61 14369
181aa2be 14370 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14371 (casify_region): Mark local as initialized.
181aa2be 14372
930d429c
PE
14373 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14374
7082eac6
PE
14375 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14376 New macros, so that the caller can use some names other than
14377 gcpro1, gcpro2, etc.
14378 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14379 of the new macros.
14380 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14381 argument, for consistency with GCPRO2_VAR, etc: it is now the
14382 prefix of the variable, not the variable itself. All uses
14383 changed.
38b2c076
PE
14384 * dired.c (directory_files_internal, file_name_completion):
14385 Rename locals to avoid shadowing.
14386
15206ed9
PE
14387 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14388 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14389 dired.c's scmp function, had undefined behavior.
14390 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14391 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14392 * buffer.h: ... to here, because these macros use current_buffer,
14393 and the new implementation with inline functions needs to have
14394 current_buffer in scope now, rather than later when the macros
14395 are used.
14396 (downcase, upcase1): New static inline functions.
14397 (DOWNCASE, UPCASE1): Reimplement using these functions.
14398 This avoids undefined behavior in expressions like
14399 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14400 from race conditions in accessing the global variables
14401 case_temp1 and case_temp2.
14402 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14403 * lisp.h (case_temp1, case_temp2): Remove their decls.
14404 * character.h (ASCII_CHAR_P): Move from here ...
14405 * lisp.h: ... to here, so that the inline functions mentioned
14406 above can use them.
14407
4a6bea26
PE
14408 * dired.c (directory_files_internal_unwind): Now static.
14409
f14b7e14
PE
14410 * fileio.c (file_name_as_directory, directory_file_name):
14411 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14412 Now static.
2893f146
PE
14413 (file_name_as_directory): Use const pointers when appropriate.
14414 (Fexpand_file_name): Likewise. In particular, newdir might
14415 point at constant storage, so make it a const pointer.
fd4ead52 14416 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14417 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14418 signedness issues.
f839df0c
PE
14419 (Fset_file_times, Finsert_file_contents, auto_save_error):
14420 Rename locals to avoid shadowing.
f14b7e14 14421
5716756e 14422 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14423 (Ftry_completion, Fall_completions): Rename or remove locals
14424 to avoid shadowing.
5716756e 14425
b4c3046a
PE
14426 * marker.c (bytepos_to_charpos): Remove; unused.
14427
b45db522
PE
14428 * lisp.h (verify_bytepos, count_markers): New decls,
14429 so that gcc does not warn that these functions aren't declared.
14430
85876d07
PE
14431 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14432 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14433 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14434 (copy_text): Remove unused local var.
85876d07 14435
03d78a21 14436 * filelock.c (within_one_second): Now static.
b3dd38ab 14437 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14438
5df8f01b
PE
14439 * buffer.c (fix_overlays_before): Mark locals as initialized.
14440 (fix_start_end_in_overlays): Likewise. This function should be
14441 simplified by using pointers-to-pointers, but that's a different
14442 matter.
b1d876f1 14443 (switch_to_buffer_1): Now static.
8f54f30a
PE
14444 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14445 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14446
a70072c9 14447 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14448 Fix pointer signedness issue.
edced198
PE
14449 (sys_subshell): Mark local as volatile if checking for lint,
14450 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14451 (MAXPATHLEN): Define only if needed.
a70072c9 14452
a0977c44
PE
14453 * process.c (serial_open, serial_configure): Move decls from here ...
14454 * systty.h: ... to here, so that they can be checked.
14455
a884fdcc
PE
14456 * fns.c (get_random, seed_random): Move extern decls from here ...
14457 * lisp.h: ... to here, so that they can be checked.
14458
604efe86 14459 * sysdep.c (reset_io): Now static.
b8950c94 14460 (wait_for_termination_signal): Remove; unused.
604efe86 14461
38fc62d9
PE
14462 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14463 (copy_keymap_item, append_key, push_text_char_description):
14464 Now static.
1004a21a 14465 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14466 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14467 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14468 (describe_map_tree):
14469 Rename locals to avoid shadowing.
38fc62d9 14470
2f2650da
PE
14471 * keyboard.c: Declare functions static if they are not used elsewhere.
14472 (echo_char, echo_dash, cmd_error, top_level_2):
14473 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14474 (read_char, kbd_buffer_get_event, make_lispy_position):
14475 (make_lispy_event, make_lispy_movement, apply_modifiers):
14476 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14477 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14478 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14479 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14480 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14481
a053e86c 14482 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14483 (mark_kboards): Move decl here ...
14484 * alloc.c (mark_kboards): ... from here.
a053e86c 14485
4752793e
PE
14486 * lisp.h (force_auto_save_soon): New decl.
14487
74f10ca7 14488 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14489 (DEFINE_DUMMY_FUNCTION): New macro.
14490 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14491 Use it.
c03cd23f
PE
14492 (main): Add casts to avoid warnings
14493 if GCC considers string literals to be constants.
74f10ca7 14494
022e70d4
PE
14495 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14496
59d6fe83
PE
14497 * dbusbind.c: Pointer signedness fixes.
14498 (xd_signature, xd_append_arg, xd_initialize):
14499 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14500 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14501 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14502 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14503
78320123
PE
14504 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14505 if GCC considers string literals to be constants.
49cebcca 14506 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14507
35ac2a97
SM
145082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14509
fb103ca9
SM
14510 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14511 (print_preprocess, print_object): New macro to fix last change.
14512
35ac2a97
SM
14513 * print.c (print_preprocess): Don't forget font objects.
14514
62973b41
JB
145152011-03-16 Juanma Barranquero <lekktu@gmail.com>
14516
14517 * emacs.c (USAGE3): Doc fixes.
14518
0e48bb22
AS
145192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14520
14521 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14522 structure.
14523
7684e57b
JB
145242011-03-14 Juanma Barranquero <lekktu@gmail.com>
14525
14526 * lisp.h (VWindow_system, Qfile_name_history):
14527 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14528 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14529 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14530
14531 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14532 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14533
14534 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14535 * w32console.c (detect_input_pending, read_input_pending)
14536 (encode_terminal_code):
14537 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14538 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14539 (w32_system_caret_y, Qfile_name_history):
14540 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14541 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14542 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14543 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14544 * w32proc.c (Qlocal, report_file_error):
14545 * w32term.c (Vwindow_system, updating_frame):
14546 * w32uniscribe.c (initialized, uniscribe_font_driver):
14547 Remove unneeded extern declarations.
14548
2aa46d6c
CY
145492011-03-14 Chong Yidong <cyd@stupidchicken.com>
14550
c96bbc66 14551 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14552
cffc6f3b
CY
145532011-03-13 Chong Yidong <cyd@stupidchicken.com>
14554
14555 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14556 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14557 These macros can no longer be used for assignment.
14558
44f230aa
SM
14559 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14560 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14561 (record_buffer_markers, fetch_buffer_markers): New functions for
14562 recording and fetching special buffer markers.
14563 (set_buffer_internal_1, set_buffer_temp): Use them.
14564
14565 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14566
14567 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14568
14569 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14570 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14571
14572 * xdisp.c (hscroll_window_tree):
14573 (reconsider_clip_changes): Use PT instead of BUF_PT.
14574
d251f04b
EZ
145752011-03-13 Eli Zaretskii <eliz@gnu.org>
14576
14577 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14578 $(EMACS_ROOT)/lib/intprops.h.
14579
f0c77cd1
PE
145802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14581
3eca4629
PE
14582 Fix more problems found by GCC 4.5.2's static checks.
14583
7c86ee98
PE
14584 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14585 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14586 (xg_free_frame_widgets): Make it clear that a local variable is
14587 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14588 (gdk_window_get_screen): Make it clear that this macro is needed
14589 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14590 (int_gtk_range_get_value): New function, which avoids a diagnostic
14591 from gcc -Wbad-function-cast.
14592 (xg_set_toolkit_scroll_bar_thumb): Use it.
14593 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14594 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14595 (get_utf8_string, xg_get_file_with_chooser):
14596 Rename locals to avoid shadowing.
14597 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14598
41729b81
PE
14599 * xgselect.c (xg_select): Remove unused var.
14600
f0c77cd1
PE
14601 * image.c (four_corners_best): Mark locals as initialized.
14602 (gif_load): Initialize transparent_p to zero (Bug#8238).
14603 Mark another local as initialized.
ec6cf4c6 14604 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14605
ce0ad53d 14606 * image.c (clear_image_cache): Now static.
d5d5a617 14607 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14608 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14609 (x_edge_detection): Remove unnecessary cast that
14610 gcc -Wbad-function-cast diagnoses.
2037898d 14611 (gif_load): Fix pointer signedness.
6ae141d6
PE
14612 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14613 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14614
33383987 146152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14616
d32df629
PE
14617 Improve quality of tests for time stamp overflow.
14618 For example, without this patch (encode-time 0 0 0 1 1
14619 1152921504606846976) returns the obviously-bogus value (-948597
14620 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14621 reports time overflow. See
14622 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14623 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14624 * editfns.c: Include limits.h and intprops.h.
14625 (TIME_T_MIN, TIME_T_MAX): New macros.
14626 (time_overflow): Move earlier, to before first use.
14627 (hi_time, lo_time): New functions, for an accurate test for
14628 out-of-range times.
14629 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14630 (Fget_internal_run_time): Don't assume time_t fits in int.
14631 (make_time): Use list2 instead of Fcons twice.
14632 (Fdecode_time): More accurate test for out-of-range times.
14633 (check_tm_member): New function.
14634 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14635 (lisp_time_argument): Don't rely on undefined left-shift and
14636 right-shift behavior when checking for time stamp overflow.
8be6f318 14637
fe31d94c
PE
14638 * editfns.c (time_overflow): New function, refactoring common code.
14639 (Fformat_time_string, Fdecode_time, Fencode_time):
14640 (Fcurrent_time_string): Use it.
14641
8be6f318
PE
14642 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14643 * dired.c (make_time): Move to ...
14644 * editfns.c (make_time): ... here.
14645 * systime.h: Note the move.
14646
09d9db2c 146472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14648
126bc0dc
YM
14649 * fringe.c (update_window_fringes): Remove unused variables.
14650
c47cbdfd
YM
14651 * unexmacosx.c (copy_data_segment): Also copy __got section.
14652 (Bug#8223)
14653
7ac80be9
EZ
146542011-03-12 Eli Zaretskii <eliz@gnu.org>
14655
c96bbc66 14656 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14657 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14658 Constify `char *' arguments and their references according to
14659 prototypes in tparam.h.
14660
ecb0f94d 14661 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14662
7ac80be9
EZ
14663 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14664 Adapt all references accordingly.
14665
14666 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14667
ef1fd07e
TT
146682011-03-11 Tom Tromey <tromey@redhat.com>
14669
14670 * buffer.c (syms_of_buffer): Remove obsolete comment.
14671
7ef4b50c
EZ
146722011-03-11 Eli Zaretskii <eliz@gnu.org>
14673
14674 * termhooks.h (encode_terminal_code): Declare prototype.
14675
14676 * msdos.c (encode_terminal_code): Don't declare prototype.
14677
14678 * term.c (encode_terminal_code): Now external again, used by
14679 w32console.c and msdos.c.
14680
44f230aa
SM
14681 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14682 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14683
4b1ec863 146842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14685
1714f52b 14686 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14687
4b1ec863
PE
14688 * fringe.c (update_window_fringes): Mark locals as initialized
14689 (Bug#8227).
14690 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14691
524c7aa6
PE
14692 * alloc.c (mark_fringe_data): Move decl from here ...
14693 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14694 to check its interface.
14695 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14696
a5c0af81 14697 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14698 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14699 (fontset_font): Mark local as initialized.
a9a06e0b 14700 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14701
b4716021
PE
14702 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14703
811e9bac 14704 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14705 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14706 (x_own_selection, Fx_disown_selection_internal): Rename locals
14707 to avoid shadowing.
14708 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14709
7e3ab302
PE
14710 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14711 so that the caller can use some name other than gcpro1.
14712 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14713 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14714 (Fx_backspace_delete_keys_p):
14715 Use them to avoid shadowing, and rename vars to avoid shadowing.
14716 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14717 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14718 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14719 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14720 Remove unused locals.
7e3ab302
PE
14721 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14722 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14723 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14724 macros.
f78faa98 14725
e2b13473
PE
14726 * xterm.h (x_mouse_leave): New decl.
14727
77f23912
PE
14728 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14729 Remove unused functions.
cdf4ba58
PE
14730 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14731 (x_calc_absolute_position): Now static.
7411c686 14732 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14733 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14734 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14735 unless they are used.
38d0b34a
PE
14736 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14737 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14738 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14739 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14740 (x_error_catcher, x_connection_closed, x_error_handler):
14741 (x_error_quitter, xembed_send_message, x_iconify_frame):
14742 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14743 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14744 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14745
44f230aa
SM
14746 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14747 Rename or move locals to avoid shadowing.
6b463e58 14748 (tty_defined_color, merge_face_heights): Now static.
5967d051 14749 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14750 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14751 does not deduce is never used uninitialized.
73719eba
PE
14752 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14753 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14754
426994c3 14755 * terminal.c (store_terminal_param): Now static.
5489860b 14756
032f1620 14757 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14758 (set_frame_menubar): Remove unused local.
d4323972 14759 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14760 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14761 since they might point to immutable storage.
281585b0
PE
14762 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14763 since it's unused otherwise.
032f1620 14764
367c19e5 14765 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14766 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14767 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14768 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14769 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14770 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14771 does not deduce are never used uninitialized.
70739cbe 14772
07b48fa9
PE
14773 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14774
8868a238 14775 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14776 * window.c (window_loop, size_window):
14777 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14778
7e5cf297 14779 * window.c (display_buffer): Now static.
d6550a9f
PE
14780 (size_window): Mark variables that gcc -Wuninitialized
14781 does not deduce are never used uninitialized.
a586633d
PE
14782 * window.h (check_all_windows): New decl, to forestall
14783 gcc -Wmissing-prototypes diagnostic.
5b555da1 14784 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14785
f6095868
PE
14786 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14787 shadowing.
14788 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14789 Include <limits.h>.
14790 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14791 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14792 (load_charset_map): Mark variables that gcc -Wuninitialized
14793 does not deduce are never used uninitialized.
53df7c11 14794 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14795
f38b440c
PE
14796 * coding.c (coding_set_source, coding_set_destination):
14797 Use "else { /* comment */ }" rather than "else /* comment */;"
14798 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14799 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14800 a block, when the outer 'i' will do.
14801 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14802 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14803 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14804 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14805 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14806 Rename locals to avoid shadowing.
14807 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14808 * coding.c (emacs_mule_char, encode_invocation_designation):
14809 Now static, since they're not used elsewhere.
413bb2db 14810 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14811 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14812 (decode_coding_emacs_mule): Mark variables that gcc
14813 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14814 (detect_coding_iso_2022): Initialize a local variable that might
14815 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14816 this initialization is needed. (Bug#8211)
5f58e762
PE
14817 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14818 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14819 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14820 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14821 Remove unused macros.
f38b440c 14822
232b38b9 14823 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14824 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14825 * character.c (string_count_byte8): Likewise.
232b38b9 14826
fb90da1b
PE
14827 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14828 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14829
fb93dbc2
PE
14830 * chartab.c (copy_sub_char_table): Now static, since it's not used
14831 elsewhere.
5c156ace
PE
14832 (sub_char_table_ref_and_range, char_table_ref_and_range):
14833 Rename locals to avoid shadowing.
bbcd0949 14834 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14835
7d3b3862 14836 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14837 (BIDI_BOB): Remove unused macro.
7d3b3862 14838
6be7d3da
PE
14839 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14840 deduce are never used uninitialized.
c2ed9c8b 14841 * term.c (encode_terminal_code): Likewise.
6be7d3da 14842
75f8807f 14843 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14844
50938595
PE
14845 * tparam.h: New file.
14846 * term.c, tparam.h: Include it.
14847 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14848 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14849 Move these decls to tparam.h, and make them agree with what
14850 is actually in tparam.c. The previous trick of using incompatible
14851 decls in different modules does not conform to the C standard.
14852 All callers of tparam changed to use tparam's actual API.
14853 * tparam.c (tparam1, tparam, tgoto):
14854 Use const pointers where appropriate.
14855
fbceeba2
PE
14856 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14857 * cm.h (struct cm): Likewise.
14858 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14859 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14860 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14861 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14862 (turn_on_face, init_tty): Likewise.
14863 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14864
7f3f1250
PE
14865 * term.c (term_mouse_position): Rename local to avoid shadowing.
14866
e6ca6543
PE
14867 * alloc.c (mark_ttys): Move decl from here ...
14868 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14869
c40f8d15
AS
148702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14871
14872 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14873
cfe0661d
JB
148742011-03-09 Juanma Barranquero <lekktu@gmail.com>
14875
14876 * search.c (compile_pattern_1): Remove argument regp, unused since
14877 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14878 (compile_pattern): Don't pass it.
14879
0afb4571
J
148802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14881
14882 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14883 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14884 for ! HAVE_GTK3.
14885 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14886
14887 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14888
14889 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14890 gdk_window_get_screen, gdk_window_get_geometry,
14891 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14892 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14893 (xg_get_pixbuf_from_pixmap): New function.
14894 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14895 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14896 Call xg_get_pixbuf_from_pixmap instead of
14897 gdk_pixbuf_get_from_drawable.
14898 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14899 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14900 (xg_check_special_colors): Use GtkStyleContext and its functions
14901 for HAVE_GTK3.
14902 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14903 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14904 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14905 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14906 Call gtk_widget_get_preferred_size.
0afb4571
J
14907 (xg_frame_resized): gdk_window_get_geometry only takes 5
14908 parameters.
44f230aa
SM
14909 (xg_win_to_widget, xg_event_is_for_menubar):
14910 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14911 (xg_set_widget_bg): New function.
14912 (delete_cb): New function.
895009e1 14913 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14914 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14915 (xg_set_background_color): Call xg_set_widget_bg.
14916 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14917 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14918 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14919 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14920 if ! HAVE_GTK3.
14921 (update_frame_tool_bar): Call gtk_widget_hide.
14922 (xg_initialize): Use GDK_KEY_g.
14923
14924 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14925 if ! HAVE_GTK3
14926 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14927
14928 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14929 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14930 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14931
1c2cc4ef
JB
149322011-03-08 Juanma Barranquero <lekktu@gmail.com>
14933
14934 * w32xfns.c (select_palette): Check success of RealizePalette against
14935 GDI_ERROR, not zero.
14936
33383987 14937See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14938
14939;; Local Variables:
14940;; coding: utf-8
aac0c6e3
MR
14941;; End:
14942
2f097256 14943 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14944
14945 This file is part of GNU Emacs.
14946
14947 GNU Emacs is free software: you can redistribute it and/or modify
14948 it under the terms of the GNU General Public License as published by
14949 the Free Software Foundation, either version 3 of the License, or
14950 (at your option) any later version.
14951
14952 GNU Emacs is distributed in the hope that it will be useful,
14953 but WITHOUT ANY WARRANTY; without even the implied warranty of
14954 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14955 GNU General Public License for more details.
14956
14957 You should have received a copy of the GNU General Public License
14958 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.