Try to document filter-buffer-substring changes
[bpt/emacs.git] / src / ChangeLog
CommitLineData
79c1cc1e
CY
12012-02-04 Chong Yidong <cyd@gnu.org>
2
3 * nsterm.m: Declare a global (Bug#10694).
4
d7f29f8e
EZ
52012-02-04 Eli Zaretskii <eliz@gnu.org>
6
7 * w32.c (get_emacs_configuration_options): Include
8 --enable-checking, if specified, in the return value.
9
3b95a6f9
MR
102012-02-04 Martin Rudalics <rudalics@gmx.at>
11
12 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
13 after rounding frame sizes. (Bug#9723)
14
d6fa96a6
EZ
152012-02-04 Eli Zaretskii <eliz@gnu.org>
16
17 * keyboard.c (adjust_point_for_property): Don't position point
18 before BEGV. (Bug#10696)
19
df0b2940
PE
202012-02-03 Paul Eggert <eggert@cs.ucla.edu>
21
22 Handle overflow when computing char display width (Bug#9496).
23 * character.c (char_width): Return EMACS_INT, not int.
24 (char_width, c_string_width): Check for overflow when
25 computing the width; this is possible now that individual
26 characters can have unbounded width. Problem introduced
27 by merge from Emacs 23 on 2012-01-19.
28
6bee44d6
MA
292012-02-02 Michael Albinus <michael.albinus@gmx.de>
30
31 * dbusbind.c (Fdbus_register_method): Mention the return value
32 :ignore in the docstring.
33
44f92739
GM
342012-02-02 Glenn Morris <rgm@gnu.org>
35
1b9f60cc
GM
36 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
37
44f92739
GM
38 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
39 Unconditionally set to t. (Bug#10673)
40 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
41 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
42 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
43
c5d3843c
KH
442012-02-02 Kenichi Handa <handa@m17n.org>
45
46 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
47 0, do not call append_composite_glyph.
48
159462d4 492012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
50
51 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
52 NULL (Bug#6988).
53 (x_produce_glyphs): If the component of a composition is a null
54 string, set it->pixel_width to 1 to avoid zero-width glyph.
55
78cef877
EZ
562012-02-01 Eli Zaretskii <eliz@gnu.org>
57
58 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
59 first 2 arguments are identical. This makes inserting large
60 output from a subprocess an order of magnitude faster on
61 MS-Windows, where all sbrk'ed memory is always contiguous.
62
97897668
GM
632012-01-31 Glenn Morris <rgm@gnu.org>
64
65 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 66 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
67 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
68
31fd3586
GM
692012-01-29 Glenn Morris <rgm@gnu.org>
70
71 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
72
0e24a8b2
CY
732012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
74
75 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
76
cc0adcb0
CY
772012-01-28 Chong Yidong <cyd@gnu.org>
78
79 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
80
acc28cb9
CY
812012-01-26 Chong Yidong <cyd@gnu.org>
82
9c69cfb7
CY
83 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
84
acc28cb9
CY
85 * search.c (Fsearch_forward, Fsearch_backward): Document negative
86 repeat counts (Bug#10507).
87
48da7392
GM
882012-01-26 Glenn Morris <rgm@gnu.org>
89
90 * lread.c (syms_of_lread): Doc fix.
91
14af5f7f
CY
922012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
93
94 * coding.c (encode_designation_at_bol): Change return value to
95 EMACS_INT.
96
0b21c100
CY
972012-01-25 Chong Yidong <cyd@gnu.org>
98
99 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
100
3c2907f7
CY
1012012-01-21 Chong Yidong <cyd@gnu.org>
102
103 * floatfns.c (Fcopysign): Make the second argument non-optional,
104 since nil is not allowed anyway.
105
959ad23f
AS
1062012-01-21 Andreas Schwab <schwab@linux-m68k.org>
107
108 * process.c (read_process_output): Use p instead of XPROCESS (proc).
109 (send_process): Likewise.
110
34a02f46
MR
1112012-01-19 Martin Rudalics <rudalics@gmx.at>
112
113 * window.c (save_window_save, Fcurrent_window_configuration)
114 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
115 doc-strings.
116
1259009a 1172012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
118
119 * character.c (char_width): New function.
70d4fdf6
GM
120 (Fchar_width, c_string_width, lisp_string_width):
121 Use char_width (Bug#9496).
25ed9e61 122
6a6ee00d
MR
1232012-01-16 Martin Rudalics <rudalics@gmx.at>
124
125 * window.c (Vwindow_persistent_parameters): New variable.
126 (Fset_window_configuration, save_window_save): Handle persistent
127 window parameters.
128
c85efaf7
EZ
1292012-01-14 Eli Zaretskii <eliz@gnu.org>
130
131 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
132 thrashing the stack of the thread. (Bug#9087)
133
5944709e
PE
1342012-01-12 Paul Eggert <eggert@cs.ucla.edu>
135
136 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
137
e71f5d99
EZ
1382012-01-11 Eli Zaretskii <eliz@gnu.org>
139
140 * xdisp.c (rows_from_pos_range): Handle the case where the
141 highlight ends on a newline. (Bug#10464)
142 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
143 he end column for display of highlight that ends on a newline
144 before a R2L line.
145
ce316182
GM
1462012-01-11 Glenn Morris <rgm@gnu.org>
147
148 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
149 from load-path also when installation-directory is nil. (Bug#10208)
150
5b43da69
GM
1512012-01-10 Glenn Morris <rgm@gnu.org>
152
74cc8ff9
GM
153 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
154
7d8d6e4e
GM
155 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
156 Update template values to be closer to their typical values these days.
5b43da69 157
a0db8d43
EZ
1582012-01-09 Eli Zaretskii <eliz@gnu.org>
159
160 * xdisp.c (rows_from_pos_range): Accept additional argument
161 DISP_STRING, and accept any glyph in a row whose object is that
162 string as eligible for mouse highlight. Fixes mouse highlight of
163 display strings from overlays. (Bug#10464)
164
9a0115ab 1652012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 166
b9110d6a 167 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
168 * fileio.c (auto_saving_dir_umask): New static var.
169 (Fmake_directory_internal): Use it.
170 (do_auto_save_make_dir): Set it, instead of invoking chmod after
171 creating the directory. The old code temporarily assigns
172 too-generous permissions to the directory.
173 (do_auto_save_eh): Clear it.
b9110d6a 174 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
175 that the var is always cleared.
176
6c1bd3f3
EZ
1772012-01-07 Eli Zaretskii <eliz@gnu.org>
178
179 * search.c (scan_buffer): Pass character positions to
180 know_region_cache, not byte positions. (Bug#6540)
181
069d2b50
L
1822012-01-07 LynX <_LynX@bk.ru> (tiny change)
183
184 * w32.c (sys_rename): Report EXDEV when rename of a directory
185 fails because the target is on another logical disk. (Bug#10284)
186
75bf0d33
DB
1872012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
188
189 * xterm.c (x_embed_request_focus): New function.
190
191 * xterm.h: Add prototype.
192
193 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
194
1c6e5a32
GM
1952012-01-05 Glenn Morris <rgm@gnu.org>
196
197 * emacs.c (emacs_copyright): Update short copyright year to 2012.
198
651e947e
EZ
1992012-01-01 Eli Zaretskii <eliz@gnu.org>
200
201 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
202 Load gnutls_transport_set_lowat only if GnuTLS version is below
203 2.11.1.
204 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
205 GnuTLS versions below 2.11.1.
206
3778cdd8
AL
2072011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
208
209 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
210 to the doc string advising against its use for altering the way
211 windows are scrolled.
212
0e5317f7
KH
2132011-12-28 Kenichi Handa <handa@m17n.org>
214
215 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
216 coding-system ASCII compatible only when it does not produce BOM
217 on encoding (Bug#10383).
218
93d5ca1f
JD
2192011-12-26 Jan Djärv <jan.h.d@swipnet.se>
220
221 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
222 can scroll.
223 (create_and_show_popup_menu): Always use menu_position_func for
224 Gtk3 (Bug#10361).
225
ca22b785
AS
2262011-12-24 Andreas Schwab <schwab@linux-m68k.org>
227
228 * callint.c (Fcall_interactively): Don't truncate prompt string.
229
d048e1e6
EZ
2302011-12-23 Eli Zaretskii <eliz@gnu.org>
231
232 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
233 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 234 resumed from there (after widening). (Bug#10360)
d048e1e6 235
5ccaba1f
JD
2362011-12-22 Jan Djärv <jan.h.d@swipnet.se>
237
238 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
239
204ee57f
JD
2402011-12-21 Jan Djärv <jan.h.d@swipnet.se>
241
b81d40f0
JB
242 * nsterm.m (x_free_frame_resources):
243 Release f->output_data.ns->miniimage.
204ee57f
JD
244 (ns_index_color): Fix indentation. Do not retain
245 color_table->colors[i].
246
247 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
248 before returning.
249
250 * nsfns.m (x_set_background_color): Assign return value from
251 ns_index_color to face-background instead of NSColor*.
252 (ns_implicitly_set_icon_type): Fix indentation.
253 Change assignment in for loop to comparison.
254
255 * emacs.c (ns_pool): New variable.
256 (main): Assign ns_pool.
257 (Fkill_emacs): Call ns_release_autorelease_pool.
258
259 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
260 autorelease fdesc, release fdAttrs and tdict.
261 (ns_get_covering_families): Release charset.
262 (ns_findfonts): Release NSFontDescriptor created with new.
263 (ns_uni_to_glyphs): Fix indentation.
264 (setString): Release attrStr before assigning new value.
265
c803b2b7
JD
2662011-12-18 Jan Djärv <jan.h.d@swipnet.se>
267
678f4426
JD
268 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
269 and NS_IMPL_COCOA.
270 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
271 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
272
cd394be1 2732011-12-18 David Reitter <reitter@cmu.edu>
678f4426 274
5fecd5fc
JD
275 * nsterm.m (ns_term_init): Subscribe for notifications
276 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
277 to method trackingNotification in EmacsMenu.
278
279 * nsmenu.m (trackingMenu): New variable.
3771cb17 280 (trackingNotification): New method (from Aquamacs).
5fecd5fc 281 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 282 from Aquamacs (Bug#7030).
678f4426
JD
283
2842011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 285
c803b2b7
JD
286 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
287 (symbol_to_nsstring): Fix indentation.
288 (ns_symbol_to_pb): New function.
289 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
290 (Fns_rotate_cut_buffers_internal): Removed.
291 (Fns_store_selection_internal): Renamed from
292 Fns_store_cut_buffer_internal.
293 (ns_get_foreign_selection, Fx_own_selection_internal)
294 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
295 (Fns_get_selection_internal, Fns_store_selection_internal):
296 Use ns_symbol_to_pb and check if return value is nil.
297 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
298 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
299 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
300 renamed to Sns_store_selection_internal.
301 (ns_handle_selection_request): Move code to Fx_own_selection_internal
302 and remove this function.
303 (ns_handle_selection_clear): Remove, never used.
304 (Fx_own_selection_internal): Move code from ns_handle_selection_request
305 here.
306
e1b01a3a
KB
3072011-12-17 Ken Brown <kbrown@cornell.edu>
308
309 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
310 GID is unknown (Bug#10257).
311
2adb6e85
PE
3122011-12-17 Paul Eggert <eggert@cs.ucla.edu>
313
314 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
315 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
316 which caused a build failure on GNU/Linux IA-64. This problem was
317 introduced by my 2011-10-07 patch.
318
d1d7b339
JL
3192011-12-15 Juri Linkov <juri@jurta.org>
320
321 * image.c (imagemagick_error): New function. (Bug#10112)
322 (imagemagick_load_image): Comment out `MagickSetResolution' call.
323 Use `imagemagick_error' where ImageMagick functions return
324 `MagickFalse'.
325 (Fimagemagick_types): Add `Fnreverse' to return the list in the
326 proper order.
327
100d5755
KH
3282011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
329
330 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
331 fill background (Bug#8992).
332
454592a6
MR
3332011-12-13 Martin Rudalics <rudalics@gmx.at>
334
335 * window.c (Vwindow_combination_resize)
336 (Vwindow_combination_limit): Use t instead of non-nil in
337 doc-strings.
61d4b438
MR
338 (Vrecenter_redisplay): Add first sentence of doc-string on
339 separate line.
53524d93 340 (Frecenter): Fix doc-string typo.
454592a6 341
3633e3aa
KH
3422011-12-11 Kenichi Handa <handa@m17n.org>
343
344 * coding.c (Funencodable_char_position): Pay attention to the
345 buffer text relocation (Bug#9389).
346
7b9d523a
JD
3472011-12-10 Jan Djärv <jan.h.d@swipnet.se>
348
349 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
350 gtk_init (Bug#10100).
351
b73189c6
EZ
3522011-12-10 Eli Zaretskii <eliz@gnu.org>
353
354 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
355 IT->string is nil. (Bug#10263)
356
f7dfe5d6
JD
3572011-12-10 Jan Djärv <jan.h.d@swipnet.se>
358
83faebb4
JD
359 * nsterm.h (x_free_frame_resources): Declare.
360
f7dfe5d6
JD
361 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
362 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
363
364 * nsterm.h (ns_get_defaults_value): Declare.
365
366 * nsterm.m (ns_default): Call ns_get_defaults_value.
367
7cd4e72c
EZ
3682011-12-09 Eli Zaretskii <eliz@gnu.org>
369
370 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
371 (Bug#10170)
372
b34d7317
YM
3732011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
374
375 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
376 that where the value of an _OBJC_* symbol points to is in the .bss
377 section (Bug#10240).
378
76470ad1
KH
3792011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
380
381 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 382 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 383
745fff94
KH
3842011-12-08 Kenichi Handa <handa@m17n.org>
385
386 * ftfont.c (get_adstyle_property): Fix previous change
387 (Bug#10233).
388
6e44397c
JB
3892011-12-07 Juanma Barranquero <lekktu@gmail.com>
390
391 * w32.c (init_environment): If no_site_lisp, remove site-lisp
392 dirs from the default value of EMACSLOADPATH (bug#10208).
393
7efa6272
GM
3942011-12-07 Glenn Morris <rgm@gnu.org>
395
396 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
397 installation and source directories as well. (Bug#10208)
398
f6fc4d87
CY
3992011-12-06 Chong Yidong <cyd@gnu.org>
400
401 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
402
2bf26180
GM
4032011-12-06 Glenn Morris <rgm@gnu.org>
404
405 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
406 as an error, not just -1. (Bug#10217)
407
3a6ad4f0
CY
4082011-12-05 Chong Yidong <cyd@gnu.org>
409
410 * keyboard.c (process_special_events): New function.
411 (swallow_events, Finput_pending_p): Use it (Bug#10195).
412
75a3b399
PE
4132011-12-05 Paul Eggert <eggert@cs.ucla.edu>
414
415 * coding.c (encode_designation_at_bol): Don't use uninitialized
416 local variable (Bug#9318).
417
c3c9e25e
KH
4182011-12-05 Kenichi Handa <handa@m17n.org>
419
420 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
421 return Qnil (Bug#8046, Bug#10193).
422
5eb05ea3
KH
4232011-12-05 Kenichi Handa <handa@m17n.org>
424
425 * coding.c (encode_designation_at_bol): New args charbuf_end and
426 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
427 (coding_set_source): Return how many bytes coding->source was
428 relocated.
429 (coding_set_destination): Return how many bytes
430 coding->destination was relocated.
431 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
432 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
433
4342011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
435
436 * coding.c (CODING_CHAR_CHARSET_P): New macro.
437 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
438 macro (Bug#9318).
439
4402011-12-05 Andreas Schwab <schwab@linux-m68k.org>
441
442 The following changes are to fix Bug#9318.
443
a79703f5 444 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
445 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
446 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 447 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 448
7dbda6df
JB
4492011-12-05 Juanma Barranquero <lekktu@gmail.com>
450
451 * lisp.h (process_quit_flag): Fix external declaration.
452
6d5eb5b0
SM
4532011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
454
455 Don't macro-inline non-performance-critical code.
456 * eval.c (process_quit_flag): New function.
457 * lisp.h (QUIT): Use it.
458
a0c3fad0
JD
4592011-12-04 Jan Djärv <jan.h.d@swipnet.se>
460
461 * nsfns.m (get_geometry_from_preferences): New function.
462 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
463
6c07aac2
AS
4642011-12-04 Andreas Schwab <schwab@linux-m68k.org>
465
466 * emacs.c (Qkill_emacs): Define.
467 (syms_of_emacs): Initialize it.
468 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
469 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
470 (quit_throw_to_read_char): Add parameter `from_signal'.
471 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
472 * lisp.h (QUIT): Call Fkill_emacs if requested.
473
c052ead4
JD
4742011-12-03 Jan Djärv <jan.h.d@swipnet.se>
475
476 * widget.c (update_wm_hints): Return if wmshell is null.
477 (widget_update_wm_size_hints): New function.
478
479 * widget.h (widget_update_wm_size_hints): Declare.
480
481 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
482 widget_update_wm_size_hints (Bug#10104).
483
9e49252b
EZ
4842011-12-03 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (handle_invisible_prop): If the invisible text ends just
487 before a newline, prepare the bidi iterator for consuming the
488 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 489 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 490
02b16839
JL
4912011-12-02 Juri Linkov <juri@jurta.org>
492
493 * search.c (Fword_search_regexp): New Lisp function created from
494 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
495 (Fword_search_backward, Fword_search_forward)
496 (Fword_search_backward_lax, Fword_search_forward_lax):
497 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
498 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
499
0068070e
SM
5002011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
501
502 * fileio.c (Finsert_file_contents): Move after-change-function call
503 to before the "handled:" label, since all "goto handled" appear in
504 cases where the *-change-functions have already been properly called
505 (bug#10117).
506
3360a3fc
AS
5072011-12-01 Andreas Schwab <schwab@linux-m68k.org>
508
509 * keyboard.c (interrupt_signal): Don't call kill-emacs when
510 waiting for input. (Bug#10169)
511
73d6c093
EZ
5122011-11-30 Eli Zaretskii <eliz@gnu.org>
513
514 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
515 verifies glyph row's hash code--we have just reallocated the
516 glyphs, so their contents can be complete garbage. (Bug#10164)
517
febe6bea
JB
5182011-11-30 Juanma Barranquero <lekktu@gmail.com>
519
520 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
521
801a4313
EZ
5222011-11-30 Eli Zaretskii <eliz@gnu.org>
523
524 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
525 attributes are tested _before_ calling verify_row_hash, to protect
526 against GCC re-ordering of the tests. (Bug#10164)
527
2b56b87e
JD
5282011-11-29 Jan Djärv <jan.h.d@swipnet.se>
529
530 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
531
532 * xterm.c (handle_one_xevent): Only set async_visible and friends
533 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 534 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
535 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
536
dbf31225
PE
5372011-11-28 Paul Eggert <eggert@cs.ucla.edu>
538
539 Remove GCPRO-related macros that exist only to avoid shadowing locals.
540 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
541 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
542 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
543 All uses changed to use GCPRO1 etc.
544 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
545 Revert to old implementation (i.e., before 2011-03-11).
546
1305621b
YM
5472011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
548
549 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
550 of scroll runs so as to avoid assigning disabled bogus rows and
551 unnecessary graphics copy operations.
552
8c9afb46
EZ
5532011-11-27 Eli Zaretskii <eliz@gnu.org>
554
555 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
556 (snprintf) [_MSC_VER]: Redirect to _snprintf.
557 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
558 (malloc, free, realloc, calloc): Redirect to e_* only when
559 compiling Emacs.
560
561 * lisp.h (GCTYPEBITS): Move before first use.
562 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
563 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
564 this macro definition.
565
566 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
567 _MSC_VER.
568
54e9e3bf
JD
5692011-11-27 Jan Djärv <jan.h.d@swipnet.se>
570
6d5eb5b0
SM
571 * gtkutil.c (xg_create_frame_widgets):
572 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
573 present with Gtk+ 2.0.
574
83aca1cb
PE
5752011-11-26 Paul Eggert <eggert@cs.ucla.edu>
576
577 * fileio.c (Finsert_file_contents): Undo previous change; see
578 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
579
5b76caa4
PE
5802011-11-26 Paul Eggert <eggert@cs.ucla.edu>
581
582 Rename locals to avoid shadowing.
583 * fileio.c (Finsert_file_contents):
584 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
585 * process.c (wait_reading_process_output):
586 Rename inner 'proc' to 'p' to avoid shadowing.
587 Indent for consistency with usual Emacs style.
588
8c535114
EZ
5892011-11-25 Eli Zaretskii <eliz@gnu.org>
590
591 * xdisp.c (redisplay_window): If cursor row is not fully visible
592 after recentering, and scroll-conservatively is set to a large
593 number, scroll window by a few more lines to make the cursor fully
594 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
595 (start_display): Don't move to the next line if the display should
596 start at a newline that is part of a display vector or an overlay
597 string. (Bug#10119)
8c535114 598
fa4fdb5c
JL
5992011-11-24 Juri Linkov <juri@jurta.org>
600
601 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
602 after the `MagickPingImage' call. (Bug#10112)
603
90ec88df
CY
6042011-11-23 Chong Yidong <cyd@gnu.org>
605
606 * window.c (Fcoordinates_in_window_p): Accept only live windows.
607
56e2e794
MR
6082011-11-23 Martin Rudalics <rudalics@gmx.at>
609
610 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
611 making another buffer current. (Bug#10114)
612
b6e64c41
GM
6132011-11-23 Glenn Morris <rgm@gnu.org>
614
615 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
616
6b21de18
CY
6172011-11-23 Chong Yidong <cyd@gnu.org>
618
619 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
620 using it (Bug#5984).
621
b12cd789
EZ
6222011-11-22 Eli Zaretskii <eliz@gnu.org>
623
624 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
625 and header-lines, as they don't have one computed for them.
626 (Bug#10098)
627
628 * .gdbinit (prow): Make displayed values more self-explaining.
629 Add row's hash code.
630
261b6fd4
LMI
6312011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
632
633 * process.c (wait_reading_process_output): Fix asynchrounous
634 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 635 (wait_reading_process_output): Add comment and URL.
261b6fd4 636
e7cfd277
JD
6372011-11-21 Jan Djärv <jan.h.d@swipnet.se>
638
639 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
640
a9b9b7f5
CY
6412011-11-21 Chong Yidong <cyd@gnu.org>
642
643 * window.c (Fnext_window, Fprevious_window): Doc fix.
644
b0d15b4f
SM
6452011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
646
647 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
648
fe7a3057
JB
6492011-11-20 Juanma Barranquero <lekktu@gmail.com>
650
651 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
652
d2999b1a
MR
6532011-11-20 Martin Rudalics <rudalics@gmx.at>
654
655 * window.c (Fset_window_combination_limit): Rename argument
656 STATUS to LIMIT.
657 (Vwindow_combination_limit): Remove "status" from doc-string.
658
d5ff9cd0
AS
6592011-11-20 Andreas Schwab <schwab@linux-m68k.org>
660
661 * m/ibms390.h: Remove.
662 * m/ibms390x.h: Don't include "ibms390.h".
663
a5bb9bd3
SM
6642011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
665
666 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
667 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
668
cd1181db
JB
6692011-11-20 Juanma Barranquero <lekktu@gmail.com>
670
671 * casetab.c (Fset_case_table):
672 * charset.c (Fcharset_after): Fix typos.
673
615a3b8d 6742011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 675
17e845af
PE
676 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
677 Otherwise, valgrind does not work on some platforms.
678 Problem reported by Andreas Schwab in
6a0bf43d
PE
679 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
680 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
681 is set, removing the need for VIRT_ADDRESS_VARIES.
682 (PURE_P): Use a more-efficient implementation that needs just one
683 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
684 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
685 to 4 (xorl, subq, cmpq, setbe).
686 * alloc.c (pure): Always extern now, since that's the
687 VIRT_ADDR_VARIES behavior.
688 (PURE_POINTER_P): Use a single comparison, not two, for
689 consistency with the new puresize.h.
690 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
691 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
692 Remove VIRT_ADDR_VARIES no longer needed.
693
f8fe6f96
EZ
6942011-11-19 Eli Zaretskii <eliz@gnu.org>
695
696 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
697 (erase_phys_cursor, update_window_cursor, show_mouse_face)
698 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
699 behave as if the cursor position were at the window margin.
700
701 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
702 and the cursor position is out of bounds, behave as if the cursor
703 position were at the window margin. (Bug#10075)
704
df05a53c
CY
7052011-11-18 Chong Yidong <cyd@gnu.org>
706
707 * window.c (Fwindow_combination_limit): Make first argument
708 non-optional, since it is meaningless for live windows like the
709 selected window.
710
2071918e
DA
7112011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
712
713 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
714
b50a28de
SM
7152011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
716
717 * intervals.c: Fix grafting over the whole buffer (bug#10071).
718 (graft_intervals_into_buffer): Simplify.
719
015137db
EZ
7202011-11-18 Eli Zaretskii <eliz@gnu.org>
721
722 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
723 hash values of the two rows.
724 (copy_row_except_pointers): Preserve the used[] arrays and the
725 hash values of the two rows. (Bug#10035)
68c95424 726 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
727
728 * xdisp.c (row_hash): New function, body extracted from
729 compute_line_metrics.
730 (compute_line_metrics): Call row_hash, instead of computing the
731 hash code inline.
732
733 * dispnew.c (verify_row_hash): Call row_hash for computing the
734 hash code of a row, instead of duplicating code from xdisp.c.
735
736 * dispextern.h (row_hash): Add prototype.
737
a2addb04
TH
7382011-11-18 Tassilo Horn <tassilo@member.fsf.org>
739
740 * frame.c (delete_frame): Don't delete the terminal when the last
741 X frame is closed if emacs is built with GTK toolkit.
742
df85d315
JB
7432011-11-17 Juanma Barranquero <lekktu@gmail.com>
744
745 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
746
a0c2d0ae
MR
7472011-11-17 Martin Rudalics <rudalics@gmx.at>
748
749 * window.c (Vwindow_splits): Rename to
750 Vwindow_combination_resize. Suggested by Juri Linkov.
751 (Fsplit_window_internal): Use Vwindow_combination_resize instead
752 of Vwindow_splits.
753
58179cce
JB
7542011-11-16 Juanma Barranquero <lekktu@gmail.com>
755
7877f373
JB
756 * nsfns.m (Fns_font_name):
757 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 758
b6f67890
MR
7592011-11-16 Martin Rudalics <rudalics@gmx.at>
760
761 * window.h (window): Rename slot "nest" to "combination_limit".
762 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
763 (Fset_window_nest): Rename to Fset_window_combination_limit.
764 (Vwindow_nest): Rename to Vwindow_combination_limit.
765 (recombine_windows, make_parent_window, make_window)
766 (Fsplit_window_internal, saved_window)
767 (Fset_window_configuration, save_window_save): Rename all
768 occurrences of window_nest to window_combination_limit.
769
c7015153
JB
7702011-11-15 Juanma Barranquero <lekktu@gmail.com>
771
772 * image.c (imagemagick_load_image): Fix typo.
773
322ad6ec
EZ
7742011-11-14 Eli Zaretskii <eliz@gnu.org>
775
776 * xdisp.c (display_line): Move the call to
777 highlight_trailing_whitespace before the call to
778 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
779 faces of all the glyphs to compute ROW's hash value.
780 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 781
f067b8ec
JB
7822011-11-14 Juanma Barranquero <lekktu@gmail.com>
783
784 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
785 just return (bug#10044).
786
1e5b2111
EZ
7872011-11-12 Eli Zaretskii <eliz@gnu.org>
788
7ef3cbd5
EZ
789 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
790 with user-defined heap size. Bump the default size of the temacs
791 heap to 27MB, to avoid memory warning when running temacs.
792 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
793
1e5b2111
EZ
794 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
795 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
796 (verify_row_hash) [XASSERTS]: New function.
797 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
798 that the hash value of glyph rows is correct.
1e5b2111 799
89d61221
MR
8002011-11-12 Martin Rudalics <rudalics@gmx.at>
801
802 * window.h (window): Remove splits slot.
803 * window.c (Fwindow_splits, Fset_window_splits): Remove.
804 (Fdelete_other_windows_internal, make_parent_window)
805 (make_window, Fsplit_window_internal, Fdelete_window_internal)
806 (Fset_window_configuration, save_window_save): Don't deal with
807 split status of windows.
808 (saved_window): Remove splits slot.
809 (Vwindow_splits): Rewrite doc-string.
810
97f18cc8
JD
8112011-11-11 Jan Djärv <jan.h.d@swipnet.se>
812
813 * xfns.c (unwind_create_frame):
814 * nsfns.m (unwind_create_frame):
815 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
816 Vframe_list (Bug#9999).
817
22a648b4
DA
8182011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
819
0b381c7e 820 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 821
659afede
KH
8222011-11-11 Kenichi Handa <handa@m17n.org>
823
824 * callproc.c (Fcall_process): Set the member dst_multibyte of
825 process_coding.
826
9ac0394b
KH
8272011-11-11 Johan Bockgård <bojohan@gnu.org>
828
829 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
830 avoid a crash (bug#9496).
831
2fbdc249
CY
8322011-11-09 Chong Yidong <cyd@gnu.org>
833
834 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
835 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
836
ac6b1f81
PE
8372011-11-08 Paul Eggert <eggert@cs.ucla.edu>
838
839 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
840
09db192c
PE
8412011-11-08 Paul Eggert <eggert@cs.ucla.edu>
842
843 Avoid some portability problems by eschewing 'extern inline' functions.
844 The trivial performance wins aren't worth the portability hassles; see
845 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
846 et seq.
847 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
848 (window_box_width, window_box_left, window_box_left_offset)
849 (window_box_right, window_box_right_offset): Undo previous change,
850 by removing the "extern"s.
851 * intervals.c (adjust_intervals_for_insertion)
852 (adjust_intervals_for_deletion): Undo previous change,
853 making these static again.
854 (offset_intervals, temp_set_point_both, temp_set_point)
855 (copy_intervals_to_string): No longer inline.
856 * xdisp.c (window_text_bottom_y, window_box_width)
857 (window_box_height, window_box_left_offset)
858 (window_box_right_offset, window_box_left, window_box_right)
859 (window_box): No longer inline.
860
105216ed
CY
8612011-11-08 Chong Yidong <cyd@gnu.org>
862
863 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
864 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
865 Signal an error if not a live window.
105216ed
CY
866 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
867 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
868
ae9e237f
JB
8692011-11-07 Juanma Barranquero <lekktu@gmail.com>
870
871 * lisp.h (syms_of_abbrev): Remove declaration.
872 Reported by CHENG Gao <chenggao@royau.me>.
873
c7aa8333
EZ
8742011-11-07 Eli Zaretskii <eliz@gnu.org>
875
876 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
877 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
878 of temacs in GUI mode.
879
be7f5545
MR
8802011-11-07 Martin Rudalics <rudalics@gmx.at>
881
882 * window.h: Declare delete_all_child_windows instead of
883 delete_all_subwindows.
884 * window.c (Fwindow_nest, Fset_window_nest)
885 (Fset_window_new_total, Fset_window_new_normal)
886 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
887 (delete_all_subwindows): Rename to delete_all_child_windows.
888 (Fdelete_other_windows_internal, Fset_window_configuration):
889 Call delete_all_child_windows instead of delete_all_subwindows.
890 * frame.c (delete_frame): Call delete_all_child_windows instead
891 of delete_all_subwindows.
892
ca78dc43
PE
8932011-11-07 Paul Eggert <eggert@cs.ucla.edu>
894
895 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
896 This is also needed for porting to any host where GC_MARK_STACK is
897 not GC_MAKE_GCPROS_NOOPS.
898 (which_symbols): Use it.
899
a0241d01
KH
9002011-11-07 Kenichi Handa <handa@m17n.org>
901
902 * coding.c (coding_set_destination): Check coding->src_pos only
903 when coding->src_object is a buffer (bug#9910).
904
905 * process.c (send_process): Set the member src_multibyte of coding
906 to 0 (bug#9911) when sending a unibyte text.
907
908 * callproc.c (Fcall_process): Set the member src_multibyte of
909 process_coding to 0 (bug#9912).
910
a64bfdfa 9112011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
912
913 * xmenu.c (cleanup_widget_value_tree): New function.
914 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
915 calling free_menubar_widget_value_tree directly (Bug#9830).
916
cb41b32a
PE
9172011-11-06 Paul Eggert <eggert@cs.ucla.edu>
918
919 Fix some portability problems with 'inline'.
920 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
921 (window_box_width, window_box_left, window_box_left_offset)
922 (window_box_right, window_box_right_offset): Declare extern.
923 Otherwise, these inline functions do not conform to C99 and
924 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
925 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
926 * intervals.c (adjust_intervals_for_insertion)
927 (adjust_intervals_for_deletion): Now extern, because otherwise the
928 extern inline functions 'offset_intervals' couldn't refer to it.
929 (static_offset_intervals): Remove.
930 (offset_intervals): Rewrite using the old contents of
931 static_offset_intervals. The old version didn't conform to C99
932 because an extern inline function contained a reference to an
933 identifier with static linkage.
934
b7041366
AS
9352011-11-06 Andreas Schwab <schwab@linux-m68k.org>
936
937 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
938 GC.
939
88a37c4d
EZ
9402011-11-06 Eli Zaretskii <eliz@gnu.org>
941
942 * xdisp.c (init_iterator, reseat_to_string): Don't set the
943 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
944 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
945 return Qleft_to_right.
946
49745b39
CY
9472011-11-06 Chong Yidong <cyd@gnu.org>
948
949 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
950 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
951 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
952 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
953 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
954 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
955 (Fwindow_vscroll): Doc fix.
956 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
957 argument, since it makes no sense to pass a live window and for
958 consistency with window-child.
959
1f05cd82
CS
9602011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
961
962 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
963 support MSVC.
964
22610910
JR
9652011-11-05 Jason Rumney <jasonr@gnu.org>
966
967 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
968 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
969 fonts (Bug#6029).
970 (add_font_entity_to_list): Fix logic errors in mixed boolean and
971 bitwise arithmetic preventing use of unicode-sip and non-truetype
972 opentype fonts.
973
a06776b2
EZ
9742011-11-05 Eli Zaretskii <eliz@gnu.org>
975
3ad924ba
EZ
976 * s/ms-w32.h (fstat, stat, utime): Move redirections to
977 "emacs"-only part.
978
a06776b2
EZ
979 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
980 initialization code to keep similarity to xfns.c after changes
981 from 2011-11-05.
982
c9e7db78
JD
9832011-11-05 Jan Djärv <jan.h.d@swipnet.se>
984
a97f8f3f
JD
985 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
986 (unwind_create_frame): New function (Bug#9943).
987 (Fx_create_frame): Restructure code to be more similar to the one in
988 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
989 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
990 Move terminal->reference_count++ just before making the frame official
991 (Bug#9943).
992
993 * nsterm.m (x_free_frame_resources): New function.
994 (x_destroy_window): Move code to x_free_frame_resources.
995
c9e7db78 996 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
997 (Fx_create_frame, x_create_tip_frame):
998 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
999 official. Move initialization of image_cache_refcount and
1000 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1001
a6fc3b5c
EZ
10022011-11-05 Eli Zaretskii <eliz@gnu.org>
1003
1004 Support MSVC build with newer versions of Visual Studio.
1005 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1006 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1007 nt/gmake.defs.
1008
1009 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1010 which are not supported by MSVC.
1011 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1012 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1013 bitfields.
1014 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1015 types in bitfields.
1016 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1017
1018 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1019
58179cce 10202011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1021
1022 Support MSVC build with newer versions of Visual Studio.
1023 * w32.c: Don't include w32api.h for MSVC.
1024 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1025
1026 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1027 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1028 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1029 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1030 e_* cousins.
1031 (alloca) [_MSC_VER]: Define to _alloca.
1032
1033 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1034
1035 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1036
a58c13ed
EZ
10372011-11-04 Eli Zaretskii <eliz@gnu.org>
1038
1039 * xdisp.c (note_mouse_highlight): If either of
1040 previous/next-single-property-change returns nil, treat that as
1041 the beginning or the end of the buffer. (Bug#9955)
1042
fe0b6370
JD
10432011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1044
a58c13ed 1045 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1046 label is not null (Bug#9951).
1047 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1048 may be NULL.
1049
89bd5ee1
EZ
10502011-11-04 Eli Zaretskii <eliz@gnu.org>
1051
1052 * window.c (Fwindow_body_size): Mention in the doc string that the
1053 return value is in frame's canonical units. (Bug#9949)
1054
84c3edb9
EZ
10552011-11-03 Eli Zaretskii <eliz@gnu.org>
1056
4e2fb5c7
EZ
1057 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1058
84c3edb9 1059 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1060 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1061 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1062
bc17a887
EZ
10632011-11-01 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1066 Don't stop backward scan on the continuation glyph, even though
1067 its CHARPOS is positive.
6d5eb5b0
SM
1068 (mouse_face_from_buffer_pos, note_mouse_highlight):
1069 Rename cover_string to disp_string.
bc17a887 1070
4ee88440
MR
10712011-11-01 Martin Rudalics <rudalics@gmx.at>
1072
1073 * window.c (temp_output_buffer_show): Don't use
1074 Vtemp_buffer_show_specifiers.
1075 (Vtemp_buffer_show_specifiers): Remove unused variable.
1076
c2ff3c02
EZ
10772011-10-30 Eli Zaretskii <eliz@gnu.org>
1078
1079 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1080 past the beginning of the current glyph matrix.
1081
58179cce 10822011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1083
1084 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1085 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1086 HAVE_GTK3 (Bug#9869).
b77a6a7f 1087
3b574623
JD
1088 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1089 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1090
b77a6a7f
JD
1091 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1092
1093 * xterm.c: Declare x_handle_net_wm_state to return int.
1094 (handle_one_xevent): Check if we are iconified but don't have
1095 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1096 (get_current_wm_state): Return non-zero if not hidden,
1097 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1098 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1099 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1100 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1101
196e41e4
PE
11022011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1105 so that this new function doesn't get optimized away by a
1106 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1107
021f2e1a
AS
11082011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1109
1110 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1111
8b058d44
EZ
11122011-10-29 Eli Zaretskii <eliz@gnu.org>
1113
1114 Fix the `xbytecode' command.
1115 * .gdbinit (xprintbytestr): New command.
b50a28de 1116 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1117 (xbytecode): Print the byte-code string as well.
1118
4452fb80
EZ
11192011-10-29 Kim Storm <storm@cua.dk>
1120
8b058d44
EZ
1121 * alloc.c (which_symbols): New function.
1122
21b72067
AS
11232011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1124
1125 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1126 line. (Bug#9903)
1127
83ed7b5c
GM
11282011-10-29 Glenn Morris <rgm@gnu.org>
1129
1130 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1131 Not clear what it was for, and it causes various bugs. (Bug#9839)
1132
5a7a728b
EZ
11332011-10-28 Eli Zaretskii <eliz@gnu.org>
1134
1135 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1136 possible random value that matches one of those tested as
1137 condition to clear the mouse face.
1138
d3d0842f
CY
11392011-10-28 Chong Yidong <cyd@gnu.org>
1140
1141 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1142
31b39d13
DN
11432011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1144
1145 * window.c (make_window): Initialize phys_cursor_on_p.
1146
9aba6043
SM
11472011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1148
1149 * lisp.h (struct Lisp_Symbol): Update comments.
1150
c20992f4
JB
11512011-10-28 Juanma Barranquero <lekktu@gmail.com>
1152
1153 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1154
db4f02f2
EZ
11552011-10-28 Eli Zaretskii <eliz@gnu.org>
1156
1157 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1158 <oslsachem@gmail.com> for helping to debug this.
1159
1160 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1161 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1162 (g_b_init_get_glyph_outline_w): New static variables.
1163 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1164 (GetGlyphOutlineW_Proc): New typedefs.
1165 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1166 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1167 New functions.
1168 (w32font_open_internal, compute_metrics):
1169 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1170 instead of calling the "wide" APIs directly.
1171
1172 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1173
1174 * w32.h (syms_of_w32font): Add prototype.
1175
87e68db4
JB
11762011-10-27 Juanma Barranquero <lekktu@gmail.com>
1177
1178 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1179 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1180 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1181 (Fmove_to_window_line): Doc fix.
1182
435c1d67
CY
11832011-10-27 Chong Yidong <cyd@gnu.org>
1184
1185 * process.c (make_process): Set gnutls_state to NULL.
1186
1187 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1188 non-NULL, regardless of GNUTLS_INITSTAGE.
1189 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1190 an error. Set process slots as soon as we allocate them.
1191
1192 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1193
9c6c6f49
CY
11942011-10-27 Chong Yidong <cyd@gnu.org>
1195
9aba6043
SM
1196 * gnutls.c (emacs_gnutls_deinit): New function.
1197 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1198 (Fgnutls_deinit, Fgnutls_boot): Use it.
1199
1200 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1201 (deactivate_process): Call emacs_gnutls_deinit.
1202
657d08d3
JB
12032011-10-27 Juanma Barranquero <lekktu@gmail.com>
1204
1205 * image.c (x_create_x_image_and_pixmap):
1206 * w32.c (sys_rename, w32_delayed_load):
1207 * w32font.c (fill_in_logfont):
1208 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1209
5430d399
JB
12102011-10-26 Juanma Barranquero <lekktu@gmail.com>
1211
1212 * w32fns.c (w32_default_color_map): New function,
1213 extracted from Fw32_default_color_map.
a7ef684b 1214 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1215
fe0055fa
PE
12162011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1217
1218 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1219
e6346438
SM
12202011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1221
1222 * keyboard.c (test_undefined): New function (bug#9751).
1223 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1224
e112cc37
ET
12252011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1226
1227 * sysdep.c (init_sys_modes): Fix the check for the controlling
1228 terminal (Bug#6649).
1229
7b5d6677
EZ
12302011-10-20 Eli Zaretskii <eliz@gnu.org>
1231
1232 * dispextern.h (struct bidi_it): New member next_en_type.
1233
1234 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1235 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1236 current character, check also for next_en_type being WEAK_EN.
1237 (bidi_resolve_weak): Don't enter the expensive loop if the current
1238 position is before next_en_pos. Record the bidi type of the first
1239 non-ET, non-BN character we find, in addition to its position.
1240 (bidi_level_of_next_char): Invalidate next_en_type when
1241 next_en_pos is over-stepped.
1242
7da0b018
PE
12432011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1246 * editfns.c: Rewrite current-time-zone so that it invokes
1247 the equivalent of (format-time-string "%Z") to get the time zone name.
1248 This fixes a bug when the time zone name contains characters that
1249 need converting from the system time locale to Emacs internal format.
1250 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1251 that patch fixed format-time-string to do the conversion, but
1252 I forgot to fix current-time-zone.
1253 (format_time_string): New function, containing most of
1254 what Fformat_time_string used to contain.
1255 (Fformat_time_string): Rewrite in terms of format_time_string.
1256 This doesn't change this function's behavior.
1257 (current-time-zone): Rewrite to use format_time_string.
1258 This fixes the bug reported by Michael Schierl in
1259 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1260 Jason Rumney's 2007-06-07 change worked around this bug, but
1261 didn't fix it.
1262 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1263
8547b010
EZ
12642011-10-19 Eli Zaretskii <eliz@gnu.org>
1265
1266 * xdisp.c (start_display): If the character at POS is displayed
1267 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1268 (try_window_reusing_current_matrix): If a line ends in a display
1269 vector or the next line starts in a display vector, continue
1270 redrawing the window even though the character position of
1271 start_row was reached.
8547b010
EZ
1272 (Bug#9771, part 2)
1273
4e948d15
CY
12742011-10-18 Chong Yidong <cyd@gnu.org>
1275
1276 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1277 with nobreak-char-display too.
1278
4787455f
EZ
12792011-10-18 Eli Zaretskii <eliz@gnu.org>
1280
1281 Fix part 3 of bug#9771.
1282 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1283 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1284 non-neutral characters if the current character is a paragraph
1285 separator (a.k.a. Newline). This avoids running the same
1286 expensive loop twice, once when we consume the preceding newline
1287 and the other time when the line actually needs to be displayed.
1288 Avoid the loop when we see neutrals on the base embedding level
1289 following a character whose directionality is the same as the
1290 paragraph's. This avoids running the expensive loop when a line
1291 ends in a long sequence of neutrals, like control characters.
1292 Add assertion against STRONG_AL type. Slightly rearrange code
1293 that determines the type of a neutral given the first non-neutral
1294 that follows it.
1295 (bidi_level_of_next_char): Set next_en_pos to zero when
1296 invalidating its info.
1297
2c91f553
EZ
12982011-10-17 Eli Zaretskii <eliz@gnu.org>
1299
1300 * xdisp.c (push_display_prop): Determine whether to record string
1301 or buffer position by IT->string, not by IT->method. Allow
1302 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1303 (move_it_vertically_backward): Don't look for character position
1304 immediately after the newline when in a continuation line.
1305 (Bug#9771, part 1)
2c91f553 1306
c7b08b0d
MR
13072011-10-15 Martin Rudalics <rudalics@gmx.at>
1308
1309 * window.c (coordinates_in_window): Rewrite and delabelize
1310 vertical border check. (Bug#5357) (Bug#9618)
1311
6b02f655
SM
13122011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1313
1314 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1315 errors in XSetWindowBorder (bug#9310).
1316
81d40c92
DA
13172011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1318
1319 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1320 avoid crash when xmalloc overrun checking is enabled.
1321
d4172c3b
EZ
13222011-10-13 Eli Zaretskii <eliz@gnu.org>
1323
1324 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1325 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1326 cursor motion with <left> and <right> arrow keys.
1327
1328 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1329 some callers set that themselves.
1330
b00eea75
EZ
13312011-10-12 Eli Zaretskii <eliz@gnu.org>
1332
1333 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1334 display string and the previous row comes from the same string and
1335 is empty. (Bug#9739) (Bug#9738)
1336
8fe012c4
SM
13372011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1338
1339 * doc.c (get_doc_string): Encode file name (bug#9735).
1340
0074aef2
EZ
13412011-10-12 Eli Zaretskii <eliz@gnu.org>
1342
79beb178
EZ
1343 * bidi.c (bidi_level_of_next_char):
1344 * xdisp.c (get_visually_first_element): Remove old incorrect
1345 comments regarding the Unicode Line Separator character.
1346
0074aef2
EZ
1347 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1348
6e4b3fbe
DA
13492011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 * alloc.c (Fgc_status): Do not access beyond zombies array
1352 boundary if nzombies > MAX_ZOMBIES.
1353 * alloc.c (dump_zombies): Add missing format specifier.
1354
0324f3af
PE
13552011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1356
b5525cac
PE
1357 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1358 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1359
0324f3af
PE
1360 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1361 Some packages use them to denote characters with modifiers.
1362
e9b5f888
AS
13632011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1364
1365 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1366 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1367 matching a pp-number. Rename parameter var to var1.
1368
127827c0
SM
13692011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1370
1371 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1372
c8fd3bd0
GM
13732011-10-08 Glenn Morris <rgm@gnu.org>
1374
1375 * callint.c (Fcall_interactively): Give a more explicit error for the
1376 'c' case with a non-character input. (Bug#8479)
1377
352ec8ff
EZ
13782011-10-08 Eli Zaretskii <eliz@gnu.org>
1379
03669ccb
EZ
1380 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1381 lines.
7061c986
EZ
1382 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1383 lines that are hscrolled on the left.
03669ccb 1384
352ec8ff
EZ
1385 * dispnew.c (buffer_posn_from_coords): Account for a possible
1386 presence of header-line. (Bug#4426)
1387
a66cfb1c
SM
13882011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1389
6b02f655
SM
1390 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1391 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1392
7c5ee88e
PE
13932011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1394
1395 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1396 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1397 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1398 this makes Emacs dump core during garbage collection on rare
1399 occasions. sizeof is obviously inferior to offsetof here, so
1400 stick with offsetof.
1401 (GC_POINTER_ALIGNMENT): New macro.
1402 (mark_memory): Omit 3rd (offset) arg; caller changed.
1403 Don't assume EMACS_INT alignment is the same as pointer alignment.
1404
df1bbe5b
SM
14052011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1406
1407 * keyboard.c (read_key_sequence_remapped): New var.
1408 (read_key_sequence): Compute remapping in the right buffer.
1409 (command_loop_1): Use read_key_sequence's remapping directly.
1410
51553db6
SM
14112011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1412
32c1fffd
SM
1413 * dired.c (file_name_completion): Don't expand file name.
1414 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1415 before checking file name handler.
1416
51553db6
SM
1417 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1418 they've been requested explicitly (bug#9591).
1419
b6bd1599 14202011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1421
1422 * keymap.c (Fsingle_key_description): Use make_specified_string
1423 instead of build_string to build string from push_key_description.
1424 (Bug#5193)
1425
f701dc2a
PE
14262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1427
4222c55d
PE
1428 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1429 This fixes a Y2038 bug on 64-bit hosts.
1430 * buffer.c (reset_buffer):
1431 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1432 (Fclear_buffer_auto_save_failure):
1433 Use 0, not -1, to represent an unset failure time, since time_t
1434 might not be signed.
1435
f701dc2a
PE
1436 Remove dependency on glibc malloc internals.
1437 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1438 Move back here from lisp.h, but with their new implementations.
1439 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1440 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1441 * charset.c (charset_table_init): New static var.
1442 (syms_of_charset): Use it instead of xmalloc. This removes a
1443 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1444 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1445 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1446 Move back to alloc.c.
1447 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1448 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1449
9ceebf39
JD
14502011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1451
1452 * nsterm.m (windowDidResize): Call x_set_window_size only when
1453 ns_in_resize is true. Otherwise set pixelwidth/height and
1454 call change_frame_size (Bug#9628).
1455
cb993c58
PE
14562011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1457
3930c88b
PE
1458 Port --enable-checking=all to Fedora 14 x86-64.
1459 * charset.c (syms_of_charset): Also account for glibc malloc's
1460 internal overhead when calculating the initial malloc maximum.
1461
cb993c58
PE
1462 Port --enable-checking=all to Fedora 14 x86.
1463 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1464 Move to lisp.h.
1465 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1466 (overrun_check_realloc, overrun_check_free):
1467 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1468 That way, xmalloc returns a properly-aligned pointer even if
1469 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1470 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1471 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1472 into account when calculating the initial malloc maximum.
1473 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1474 Move here from alloc.c, so that charset.c can use it too.
1475 Properly align; the old code wasn't right for common 32-bit hosts
1476 when configured with --enable-checking=all.
1477 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1478 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1479
31bed486
EZ
14802011-09-29 Eli Zaretskii <eliz@gnu.org>
1481
04c70788 1482 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1483 use EDOM.
1484
fbcaa2f3
EZ
14852011-09-28 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xdisp.c (compute_display_string_end): If there's no display
1488 string at CHARPOS, return -1.
1489
1490 * bidi.c (bidi_fetch_char): When compute_display_string_end
1491 returns a negative value, treat the character as a normal
1492 character not covered by a display string. (Bug#9624)
1493
a239d4e9
JB
14942011-09-28 Juanma Barranquero <lekktu@gmail.com>
1495
1496 * lread.c (Fread_from_string): Fix typo in docstring.
1497
88652fd5
EZ
14982011-09-27 Eli Zaretskii <eliz@gnu.org>
1499
1500 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1501 newline, reseat the iterator instead of bidi-iterating there one
1502 character at a time. (Bug#9610)
32c1fffd
SM
1503 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1504 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1505
ed497dd4
AS
15062011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1507
1508 * lread.c (readevalloop): Use correct code for NBSP.
1509 (read1): Likewise. (Bug#9608)
1510
b2bf61aa
MA
15112011-09-25 Michael Albinus <michael.albinus@gmx.de>
1512
1513 * dbusbind.c (Fdbus_register_signal): When service is not
1514 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1515
32bbb17c
GM
15162011-09-25 Glenn Morris <rgm@gnu.org>
1517
1518 * buffer.c (truncate-lines): Doc fix.
1519
94e0933e
CY
15202011-09-24 Chong Yidong <cyd@stupidchicken.com>
1521
1522 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1523 (Fset_window_next_buffers): Doc fix.
1524
cddde921
GM
15252011-09-24 Glenn Morris <rgm@gnu.org>
1526
1527 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1528
1260aef1
PE
15292011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1530
25b4bfa0
PE
1531 Fix minor problems found by static checking.
1532 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1533 * indent.c (Fvertical_motion): Fix == vs = typo.
1534
e3cbd34b
EZ
15352011-09-24 Eli Zaretskii <eliz@gnu.org>
1536
a66cfb1c
SM
1537 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1538 Default value is now t. Doc fix.
6bf7006f 1539
e3cbd34b 1540 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1541 logic when moving up, not only when moving down. Fix the
e3cbd34b 1542 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1543 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1544
1545 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1546 CHARPOS is covered by a display string which includes newlines.
1547 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1548 is covered by a display string with embedded newlines.
1549
a3de0cbd
MA
15502011-09-24 Michael Albinus <michael.albinus@gmx.de>
1551
1552 * dbusbind.c (Fdbus_register_signal): Add match rule to
1553 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1554 (Fdbus_register_method, Vdbus_registered_objects_table):
1555 Fix docstring.
a3de0cbd 1556
b260039d
JM
15572011-09-24 Jim Meyering <meyering@redhat.com>
1558
32c1fffd 1559 do not ignore write error for any output size
b260039d
JM
1560 The previous change was incomplete.
1561 While it makes emacs --batch detect the vast majority of stdout
1562 write failures, errors were still ignored whenever the output size is
1563 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1564 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1565 && echo FAIL: ignored write error
1566 FAIL: ignored write error
1567 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1568 && echo FAIL: ignored write error
1569 FAIL: ignored write error
1570 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1571
8eca8a7c
AS
15722011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1573
1574 * emacs.c (Fkill_emacs): In noninteractive mode exit
1575 non-successfully if a write error occurred on stdout. (Bug#9574)
1576
3341db62
EZ
15772011-09-21 Eli Zaretskii <eliz@gnu.org>
1578
1579 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1580 the xassert test.
1581
1582 * dispextern.h (struct it): Update the comment documenting what
1583 can it->OBJECT be.
1584
8c203dbf
EZ
15852011-09-20 Eli Zaretskii <eliz@gnu.org>
1586
1587 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1588 a display string, extend search for cursor position to end of row.
1589 (find_row_edges): If the row ends in a newline from a display
1590 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1591 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1592 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1593 non-empty line. Fixes confusing cursor motion with arrow keys at
1594 the beginning of a line that starts with whitespace.
8c203dbf 1595
a4824228
LMI
15962011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1597
1598 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1599 (bug#9493).
1600
33ed493b
CY
16012011-09-18 Chong Yidong <cyd@stupidchicken.com>
1602
1603 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1604 boolean (Bug#9154).
1605
56cd55c8
EZ
16062011-09-18 Eli Zaretskii <eliz@gnu.org>
1607
1608 * xdisp.c (display_line): Record maximum and minimum buffer
1609 positions even if no glyphs were produced (e.g., by a zero-width
1610 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1611 buffer positions that will be removed from the glyph row because
1612 they don't fit.
c02dcedf
EZ
1613 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1614 column is beyond frame width: don't subtract 1 "pixel" when
1615 computing width of the stretch.
3e62b7e0
EZ
1616 (reseat_at_next_visible_line_start): Undo the change made on
1617 2011-09-17 that saved paragraph information and restored it after
1618 the call to `reseat'. (Bug#9545)
56cd55c8 1619
5ed99d36 16202011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1621
1622 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1623 and turn window cursor on if cleared (Bug#9415).
1624
5ed99d36 16252011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1626
1627 * search.c (boyer_moore): Take unibyte characters from pattern
1628 literally. (Bug#9458)
1629
9bade7b2
EZ
16302011-09-18 Eli Zaretskii <eliz@gnu.org>
1631
1632 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1633
e5e9d610
PE
16342011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1635
87e4427a
PE
1636 Fix minor problem found by static checking.
1637 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1638 initialized, to pacify gcc -Wuninitialized.
1639
e5e9d610
PE
1640 * fileio.c: Report proper errno when syscall falls.
1641 (Finsert_file_contents): Save and restore errno,
1642 so that report_file_error outputs the correct diagnostic.
1643 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1644
a1674f0b
EZ
16452011-09-18 Eli Zaretskii <eliz@gnu.org>
1646
1647 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1648
fbfb6dd4
EZ
16492011-09-17 Eli Zaretskii <eliz@gnu.org>
1650
1651 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1652 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1653
bb187662
EZ
16542011-09-17 Eli Zaretskii <eliz@gnu.org>
1655
1137e8b8 1656 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1657 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1658
1659 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1660 (bidi_find_paragraph_start): Search back for paragraph beginning
1661 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1662 (bidi_move_to_visually_next): Only trigger paragraph-related
1663 computations when the last character is a newline or at EOB, not
1664 just any NEUTRAL_B. (Bug#9470)
1665
bb187662
EZ
1666 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1667 truncated lines if point is covered by a display string. (Bug#9524)
1668
2e621251
PE
16692011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1670
1671 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1672 (cons_to_x_long): New function.
1673 (lisp_data_to_selection_data): Use it. Correct the test for
1674 short-versus-long data; it was negated. Break out of vector
1675 loop, for efficiency, when a long datum is discovered.
1676
91a15bc6
SM
16772011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1678
1679 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1680
b41c3a35
EZ
16812011-09-16 Eli Zaretskii <eliz@gnu.org>
1682
1683 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1684 GCC PR/17406) by declaring this function with external scope.
1685
7812ba2d
PE
16862011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1689 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1690
cf7edc2a
AS
16912011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1692
1693 * editfns.c (Fformat): Correctly handle text properties on "%%".
1694
bd01620e
EZ
16952011-09-15 Eli Zaretskii <eliz@gnu.org>
1696
1697 * xterm.c (x_draw_composite_glyph_string_foreground):
1698 * w32term.c (x_draw_composite_glyph_string_foreground):
1699 * term.c (encode_terminal_code):
1700 * composite.c (composition_update_it, get_composition_id):
1701 * xdisp.c (get_next_display_element)
1702 (fill_composite_glyph_string): Add comments about special meaning
1703 of TAB characters in a composition.
1704
a02719a3
PE
17052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1708 This occurs when processing a multibyte format.
1709 Problem reported by Wolfgang Jenker.
a02719a3 1710
72589a3c
JB
17112011-09-15 Johan Bockgård <bojohan@gnu.org>
1712
1713 * xdisp.c (try_cursor_movement): Only check for exact match if
1714 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1715
1c14176c
PE
17162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 Remove unused external symbols.
1719 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1720 * xdisp.c (calc_pixel_width_or_height): Now static.
1721 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1722 * indent.c (check_display_width):
1723 * w32term.c: Fix comment to match code.
1724 * xterm.c, xterm.h (x_catching_errors): Remove.
1725
d2eea5b5
PE
17262011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * xselect.c: Use signed conversions more consistently (Bug#9498).
1729 (selection_data_to_lisp_data): Assume incoming selection data are
1730 signed integers, not unsigned. This is to be consistent with
1731 outgoing selection data, which was modified to use signed integers
1732 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1733 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1734 expects long, not unsigned long.
1735
46888499
EZ
17362011-09-14 Eli Zaretskii <eliz@gnu.org>
1737
1738 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1739 computation of loop end. Reported by Johan Bockgård
1740 <bojohan@gnu.org>.
1741
ef8ef9fb
CY
17422011-09-13 Chong Yidong <cyd@stupidchicken.com>
1743
1744 * frame.c (Fother_visible_frames_p): Function deleted.
1745
fa819fed
EZ
17462011-09-12 Eli Zaretskii <eliz@gnu.org>
1747
1748 * indent.c (compute_motion): Process display vector front to back
1749 rather than the other way around. (Bug#2496)
1750
2ba8e008
SM
17512011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1752
1753 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1754
20f53c69
CY
17552011-09-11 Chong Yidong <cyd@stupidchicken.com>
1756
1757 * minibuf.c (Fread_from_minibuffer): Doc fix.
1758
d562d7a4
EZ
17592011-09-11 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1762 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1763
1c4d7f3d
LMI
17642011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1765
1766 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1767 value for non-existent files.
1768
b885bf36
EZ
17692011-09-11 Eli Zaretskii <eliz@gnu.org>
1770
1771 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1772 set its "size" to -1. This will set the modtime_size field of
1773 the corresponding buffer to -1, which is what
1774 verify-visited-file-modtime expects for files that do not exist.
1775 (Bug#9139)
1776
6612f0bf
PE
17772011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1780 here ...
1781 * lisp.h: ... from here. push_key_description is no longer
1782 defined in keyboard.c, so its declaration should not be in
1783 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1784 logically belongs with push_key_description.
1785
dfb3f755
PE
17862011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * buffer.h: Include <sys/types.h> instead of <time.h>.
1789 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1790 Problem reported by Herbert J. Skuhra.
1791
3134906c
LMI
17922011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1793
1794 * xml.c (parse_region): Make the parsing work for
1795 non-comment-starting XML files again (bug#9144).
1796
8d903f4e
AS
17972011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1798
1799 * image.c (gif_load): Fix calculation of bottom and right corner.
1800 (Bug#9468)
1801
80ad64f4
EZ
18022011-09-10 Eli Zaretskii <eliz@gnu.org>
1803
1804 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1805 redisplay in small windows.
1806
208a048d
EZ
18072011-09-09 Eli Zaretskii <eliz@gnu.org>
1808
1809 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1810
9b1c252e
MR
18112011-09-08 Martin Rudalics <rudalics@gmx.at>
1812
1813 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1814 Operate on live windows only.
1815
2949f33b
JB
18162011-09-08 Juanma Barranquero <lekktu@gmail.com>
1817
1818 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1819
e08dcafd
EZ
18202011-09-07 Eli Zaretskii <eliz@gnu.org>
1821
1822 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1823 only under bidi iteration.
1824
115b96bd
JD
18252011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1826
1827 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1828
c8199d0f
PE
18292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1830
1831 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1832 Without this fix, the command to link temacs failed due to an
1833 undefined symbol __builtin_isnan. This is because
1834 /usr/include/iso/math_c99.h #defines isnan(x) to
1835 __builtin_isnan(x), but the bundled gcc, which identifies itself
1836 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1837 a __builtin_isnan.
1838 * floatfns.c (isnan): #undef, and then #define to a clone of
1839 what's in data.c.
1840 (Fisnan): Always define, since it's always available now.
1841 (syms_of_floatfns): Always define isnan at the Lisp level.
1842
e39b275c 18432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1844
1845 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1846
b2db44d9 18472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1848
f4af5137 1849 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1850 The previous code assumed that file offsets (off_t values) fit in
1851 EMACS_INT variables, which is not true on typical 32-bit hosts.
1852 The code messed up by falsely reporting buffer overflow in cases
1853 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1854 when "big" contains more than 2**29 bytes, even though this
1855 inserts just one byte and does not overflow the buffer.
1856 (Finsert_file_contents): Store file offsets as off_t
1857 values, not as EMACS_INT values. Check for overflow when
1858 converting between EMACS_INT and off_t. When checking for
1859 buffer overflow or for overlap, take the offsets into account.
1860 Don't use EMACS_INT for small values where int suffices.
1861 When checking for overlap, fix a typo: ZV was used where
1862 ZV_BYTE was intended.
1863 (Fwrite_region): Don't assume off_t fits into 'long'.
1864 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1865
ecfc0a49
MA
18662011-09-05 Michael Albinus <michael.albinus@gmx.de>
1867
1868 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1869
6511acf2 18702011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1871
0999621a 1872 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1873
1874 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1875 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1876 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1877 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1878 (modify_event_symbol): Do not assume that the length of
1879 name_alist_or_stem is safe to alloca and fits in int.
1880 (Fexecute_extended_command): Likewise for function name and binding.
1881 (Frecursion_depth): Wrap around reliably on integer overflow.
1882 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1883 since some callers pass EMACS_INT values.
1884 (Fsingle_key_description): Don't crash if symbol name contains more
1885 than MAX_ALLOCA bytes.
1886 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1887 (get_minibuffer): Arg is now EMACS_INT, not int.
1888 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1889 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1890 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1891
2be7d702
PE
1892 * dbusbind.c (signature_cat): New function.
1893 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1894 Do not overrun buffer; instead, report string overflow.
1895
9d1df220
PE
1896 * dispnew.c (add_window_display_history): Don't overrun buffer.
1897 Truncate instead; this is OK since it's just a log.
1898
33ef5c64
PE
1899 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1900 even if the time zone offset is outlandishly large.
1901 Don't mishandle offset == INT_MIN.
1902
66c6fdd5
PE
1903 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1904 when creating daemon; the previous buffer-overflow check was incorrect.
1905
d749b01b
PE
1906 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1907 which has the guts of the old verror function.
1908
b5cd1905
PE
1909 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1910 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1911
6e1a67fb
PE
1912 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1913 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1914 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1915 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1916 length of string rather than counting it via multiple sprintfs;
1917 that's simpler and more reliable.
c21721cc
PE
1918 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1919 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1920 sprintf, in case result does not fit in int.
1921
c57b67fc
PE
1922 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1923 (fontset_from_font): Print it.
1924
8a401434
PE
1925 * frame.c (tty_frame_count): Now printmax_t, not int.
1926 (make_terminal_frame, set_term_frame_name): Print it.
1927 (x_report_frame_params): In X, window IDs are unsigned long,
1928 not signed long, so print them as unsigned.
1929 (validate_x_resource_name): Check for implausibly long names,
1930 and don't assume name length fits in 'int'.
1931 (x_get_resource_string): Don't blindly alloca invocation name;
1932 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1933 not fit in int.
1934
6e1a67fb
PE
1935 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1936 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1937 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1938
0df02bf3
PE
1939 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1940 Use esprintf, not sprintf, in case result does not fit in int.
1941
48e30793
PE
1942 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1943 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1944 it as a large positive number.
1945 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1946 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1947
a66ff6d8
PE
1948 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1949 in case result does not fit in int.
1950
aca216ff
PE
1951 * print.c (float_to_string): Detect width overflow more reliably.
1952 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1953 buffer overrun. Don't assume list length fits in 'int'. Treat
1954 print length of 0 as 0, not as infinity; to be consistent with other
1955 uses of print length in this function. Don't overflow print length
1956 index. Don't assume hash table size fits in 'long', or that
1957 vectorlike size fits in 'unsigned long'.
1958
31c286f7
PE
1959 * process.c (make_process): Use printmax_t, not int, to format
1960 process-name gensyms.
1961
55e5faa1
PE
1962 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1963
80f2e268
PE
1964 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1965 to avoid potential buffer overrun.
1966
670741ab
PE
1967 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1968 if X resource line is longer than 512 bytes.
1969
b7163a50
PE
1970 * xfns.c (x_window): Make sprintf buffer a bit bigger
1971 to avoid potential buffer overrun.
1972
ae58ff1f
PE
1973 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1974
c43c8a6a
PE
1975 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1976
3f8236f4
PE
19772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1978
53e9fe90 1979 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1980 Without these, Emacs silently mishandles large integers sometimes.
1981 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1982 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1983
6511acf2
PE
1984 * xdisp.c (try_window_id): Check Emacs fixnum range before
1985 converting to 'int'.
806add1d 1986
6511acf2 1987 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1988 Check that an Emacs fixnum is in range before assigning it to 'int'.
1989 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1990 values converted from Emacs fixnums.
1991 (Frecenter): Don't wrap around a line count if it is out of 'int'
1992 range; instead, treat it as an extreme value.
1993 (Fset_window_configuration, compare_window_configurations):
1994 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1995
6511acf2
PE
1996 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1997 that can exceed INT_MAX. Check that EMACS_INT value is in range
1998 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1999 (match_limit): Don't assume that a fixnum can fit in 'int'.
2000
6511acf2 2001 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2002 exceed INT_MAX.
2003
6511acf2 2004 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2005 (Fvertical_motion): Don't wrap around LINES values that don't fit
2006 in 'int'. Instead, treat them as extreme values. This is good
2007 enough for windows, which can't have more than INT_MAX lines anyway.
2008
fcb901a7
LMI
20092011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2010
0f2f6b6d
LMI
2011 * Require libxml/parser.h to avoid compilation warning.
2012
fcb901a7
LMI
2013 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2014
2015 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2016 since this reportedly can destroy thread storage.
2017
6e20a0d4
CY
20182011-08-30 Chong Yidong <cyd@stupidchicken.com>
2019
2020 * syntax.c (find_defun_start): Update all cache variables if
2021 exiting early (Bug#9401).
2022
148ae00e
EZ
20232011-08-30 Eli Zaretskii <eliz@gnu.org>
2024
f6cfbd8f
EZ
2025 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2026
148ae00e
EZ
2027 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2028 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2029 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2030
2031 * term.c (tty_append_glyph): New function.
2032 (produce_stretch_glyph): Static function and its prototype deleted.
2033
a66cfb1c
SM
2034 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2035 Add prototypes.
148ae00e 2036
c4a07a4c
PE
20372011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2040 when checking :margin (Bug#9390).
2041 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2042 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2043 so that the name doesn't mislead. All uses changed.
2044
6bc8cd65
JB
20452011-08-28 Johan Bockgård <bojohan@gnu.org>
2046
2047 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2048 set_tty_hooks.
2049
dca4927e
EZ
20502011-08-27 Eli Zaretskii <eliz@gnu.org>
2051
2052 * xdisp.c (move_it_to): Don't bail out early when reaching
2053 position beyond to_charpos, if we are scanning backwards.
2054 (move_it_vertically_backward): When DY == 0, make sure we get to
2055 the first character in the line after the newline.
2056
f2cad773
PE
20572011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2058
2059 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2060 (ccl_driver): Do not generate an out-of-range pointer.
2061 (Fccl_execute_on_string): Remove unnecessary check for
2062 integer overflow, noted by Stefan Monnier in
2063 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2064 Remove a FIXME that didn't need fixing.
2065 Simplify the newly-introduced buffer reallocation code.
2066
0cae2cdb
JB
20672011-08-27 Juanma Barranquero <lekktu@gmail.com>
2068
2069 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2070
5fc295a4 20712011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2072
70c60eb2 2073 Integer and memory overflow issues (Bug#9196).
726e0ab1 2074
d31850da
PE
2075 * doc.c (get_doc_string): Rework so that
2076 get_doc_string_buffer_size is the actual buffer size, rather than
2077 being 1 less than the actual buffer size; this makes xpalloc more
2078 convenient.
2079
a69fbedb
PE
2080 * image.c (x_allocate_bitmap_record, cache_image):
2081 * xselect.c (Fx_register_dnd_atom):
2082 Simplify previous changes by using xpalloc.
2083
fe5c5d37
PE
2084 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2085 since either will do and ptrdiff_t is convenient with xpalloc.
2086
0065d054
PE
2087 * charset.c (charset_table_size)
2088 (struct charset_sort_data.priority): Now ptrdiff_t.
2089 (charset_compare): Don't overflow if priorities differ greatly.
2090 (Fsort_charsets): Don't assume list length fits in int.
2091 Check for size-calculation overflow when allocating sort data.
2092 (syms_of_charset): Allocate an initial charset table that is
2093 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2094
2095 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2096
2097 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2098 The actual value is always <= INT_MAX, and leaving it unsigned made
2099 overflow checking harder.
2100
2101 * dispextern.h (struct glyph_matrix.rows_allocated)
2102 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2103 with xpalloc. The values are still always <= INT_MAX.
2104
2105 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2106
2107 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2108 (SAFE_NALLOCA): New macro.
2109
2110 * region-cache.c (struct boundary.pos, find_cache_boundary)
2111 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2112 (set_cache_region, invalidate_region_cache)
2113 (revalidate_region_cache, know_region_cache, region_cache_forward)
2114 (region_cache_backward, pp_cache):
2115 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2116 so that ptrdiff_t * can be passed to xpalloc.
2117 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2118 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2119 (pp_cache): Don't assume cache_len fits in int.
2120 * region-cache.h: Adjust extern decls to match.
2121
2122 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2123 EMACS_INT, since either will do, for xpalloc.
2124
2125 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2126 (xnmalloc, xnrealloc, xpalloc): New functions.
2127
726e0ab1
PE
2128 * bidi.c (bidi_shelve_header_size): New constant.
2129 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2130 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2131
51f30bc5 2132 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2133 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2134 (overlay_strings):
2135 Don't update size of array until after memory allocation succeeds,
2136 because xmalloc/xrealloc may not return.
0065d054
PE
2137 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2138 now that we have proper integer overflow checking.
2139 (record_overlay_string, overlay_strings): Catch overflows when
2140 calculating size of overlay_str_buf.
726e0ab1 2141
0065d054
PE
2142 * callproc.c (Fcall_process): Check for size overflow when
2143 calculating size of args2.
2144 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2145 Normally we prefer signed values, but sticking with ptrdiff_t would
2146 require adding more-complicated checks.
726e0ab1
PE
2147
2148 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2149 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2150 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2151 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2152
2153 * character.c (Fstring): Check for size-calculation overflow.
2154
2155 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2156 unnecessary integer overflow. Check for size overflow.
2157 (encode_coding_object): Don't update size until xmalloc succeeds.
2158
2159 * composite.c (get_composition_id): Check for overflow in glyph
2160 length calculations.
2161
2162 Integer and memory overflow fixes for display code.
2163 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2164 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2165 (scrolling_window): Check for overflow in size calculations.
2166 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2167 Don't assume glyph table len fits in int.
2168 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2169 (row_table_size): Now ptrdiff_t, not int.
2170 (scrolling_window): Avoid overflow in size calculations.
2171 Don't update size until allocation succeeds.
2172 * fns.c (concat): Check for overflow in size calculations.
2173 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2174 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2175 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2176
2177 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2178 (get_doc_string): Check for size calculation overflow.
2179 Don't update size until allocation succeeds.
2180 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2181 EMACS_INT, where ptrdiff_t will do.
2182 (Fsubstitute_command_keys): Check for string overflow.
2183
2184 * editfns.c (set_time_zone_rule): Don't assume environment length
2185 fits in int.
2186 (message_length): Now ptrdiff_t, not int.
2187 (Fmessage_box): Don't update size until allocation succeeds.
2188 Don't assume message length fits in int.
2189 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2190
0065d054
PE
2191 * emacs.c (main): Do not reallocate argv, since there is a null at
2192 the end that can be overwritten, and this way there's no need to
2193 worry about size-calculation overflow.
2194 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2195
2196 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2197 alloc succeeds.
2198 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2199
2200 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2201 (x_set_scroll_bar_width, x_figure_window_size):
2202 Check for integer overflow.
2203 (x_set_alpha): Do not assume XINT fits in int.
2204
2205 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2206 This is for the members text_lines, text_cols, total_lines, total_cols,
2207 where the system imposes an 'int' limit.
2208
2209 * fringe.c (Fdefine_fringe_bitmap):
2210 Don't update size until alloc works.
2211
2212 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2213 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2214
2215 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2216 Check for size-calculation overflow.
2217 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2218 do, as we prefer signed integers.
2219 (id_to_widget.max_size, id_to_widget.used)
2220 (xg_store_widget_in_map, xg_remove_widget_from_map)
2221 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2222 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2223 Use and return ptrdiff_t, not int.
2224 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2225 * gtkutil.h: Change prototypes to match the above.
2226
2227 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2228 are duplicate now that they've been promoted to lisp.h.
2229 (x_allocate_bitmap_record, x_alloc_image_color)
2230 (make_image_cache, cache_image, xpm_load):
2231 Don't update size until alloc is done.
2232 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2233 (x_detect_edges):
3256efce 2234 Check for size calculation overflow.
726e0ab1
PE
2235 (ct_colors_allocated_max): New constant.
2236 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2237 overflow.
3256efce 2238
726e0ab1
PE
2239 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2240 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2241 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2242 Use ptrdiff_t, not int, to count maps.
2243 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2244 calculations. Don't update size until allocation succeeds.
2245 Redo calculations to avoid overflow.
726e0ab1
PE
2246 * keyboard.h: Change prototypes to match the above.
2247
2248 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2249 to count maps.
2250 (current_minor_maps): Check for size calculation overflow.
2251 * keymap.h: Change prototypes to match the above.
2252
2253 * lread.c (read1, init_obarray): Don't update size until alloc done.
2254
2255 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2256 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2257
726e0ab1
PE
2258 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2259 Now ptrdiff_t, not int.
2260 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2261 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2262
2263 * process.c (Fnetwork_interface_list): Check for overflow
2264 in size calculation.
2265
2266 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2267
2268 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2269 overflow. Don't bother calling xmalloc when xrealloc will do.
2270
2271 * search.c (Freplace_match): Check for size calculation overflow.
2272 (Fset_match_data): Don't assume list lengths fit in 'int'.
2273
2274 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2275 for command line length. Do not attempt to address one before the
2276 beginning of an array, as that's not portable.
2277
2278 * term.c (max_frame_lines): Remove; unused.
2279 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2280 not int.
2281 (encode_terminal_code, calculate_costs): Check for size
2282 calculation overflow.
2283 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2284 table lengths and related sizes. Don't update size until alloc
2285 done. Redo calculations to avoid overflow.
2286 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2287
2288 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2289 subtracting pointers.
2290 (gobble_line): Check for overflow more carefully. Don't update size
2291 until alloc done.
2292
2293 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2294 Don't update size until alloc done.
2295 Redo size calculations to avoid overflow.
2296 Check for size calculation overflow.
0065d054 2297 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2298
2299 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2300 Use ptrdiff_t, not int, for sizes.
2301 (store_mode_line_noprop_char): Don't update size until alloc done.
2302
0065d054
PE
2303 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2304 Use ptrdiff_t, not int, for sizes.
2305 (Finternal_make_lisp_face, cache_face):
2306 Check for size calculation overflow.
2307 (cache_face): Treat size calculation overflows as if they were
2308 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2309
2310 * xfns.c (x_encode_text, x_set_name_internal)
2311 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2312 sizes, since they can exceed INT_MAX in size. Check for size
2313 calculation overflow.
2314
0065d054
PE
2315 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2316 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2317 Don't update size until alloc done.
2318
0065d054 2319 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2320 as sprintf is limited to int lengths.
1d526e2f 2321
252c5ee1
PE
2322 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2323 (X_LONG_MIN): New macros.
864d7ce7
PE
2324 Use them to make the following changes clearer.
2325 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2326 This change doesn't affect the value now, but it may help remind
2327 future maintainers not to raise the value too much later.
2328 (SELECTION_QUANTUM): Remove, replacing with ...
2329 (selection_quantum): ... new function, which avoids overflow.
2330 All uses changed.
2331 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2332 assumption that selection length fits in 'int'.
2333 (x_reply_selection_request, x_handle_selection_request)
2334 (x_get_window_property, receive_incremental_selection)
2335 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2336 (lisp_data_to_selection_data, clean_local_selection_data):
2337 Use ptrdiff_t, not int, to record length of selection.
2338 (x_reply_selection_request, x_get_window_property)
2339 (receive_incremental_selection, x_property_data_to_lisp):
2340 Redo calculations to avoid overflow.
2341 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2342 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2343 something.
2344 (x_get_window_property, receive_incremental_selection)
2345 (lisp_data_to_selection_data, x_property_data_to_lisp):
2346 Check for size-calculation overflow.
2347 (x_get_window_property, receive_incremental_selection)
2348 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2349 Don't store size until memory allocation succeeds.
2350 (x_get_window_property): Plug memory leak on memory exhaustion.
2351 Don't double-block input; malloc is safe here. Don't assume 2**34
2352 - 4 fits in unsigned long. Add an xassert to check
2353 XGetWindowProperty overflow. Be more careful about overflow
2354 calculations, and distinguish size from memory overflow better.
2355 (receive_incremental_selection): When tracing, don't assume
2356 unsigned int is less than INT_MAX.
2357 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2358 harmful) conversions of unsigned short to int.
2359 (lisp_data_to_selection_data): Don't assume that integers
2360 in the range -65535 through -1 fit in an X unsigned short.
2361 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2362 result parameters unless successful. Rely on cons_to_unsigned
2363 to report problems with elements; the old code wasn't right anyway.
2364 (x_check_property_data): Check for int overflow; we cannot use
2365 a wider type due to X limits.
2366 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2367
726e0ab1 2368 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2369
0065d054
PE
2370 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2371 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2372 (x_color_cells): Don't store size until memory allocation succeeds.
2373 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2374 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2375 (x_term_init): Don't assume length fits in int (sprintf is limited
2376 to int size).
bc18e09d 2377
ebfa62c0
PE
2378 Use ptrdiff_t for composition IDs.
2379 * character.c (lisp_string_width):
2380 * composite.c (composition_table_size, n_compositions)
2381 (get_composition_id, composition_gstring_from_id):
2382 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2383 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2384 * window.c (Frecenter):
2385 Use ptrdiff_t, not int, for composition IDs.
2386 * composite.c (get_composition_id): Check for integer overflow.
2387 * composite.h: Adjust prototypes to match the above changes.
2388
d3411f89
PE
2389 Use ptrdiff_t for hash table indexes.
2390 * category.c (hash_get_category_set):
2391 * ccl.c (ccl_driver):
2392 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2393 * coding.c (coding_system_charset_list, detect_coding_system):
2394 * coding.h (struct coding_system.id):
2395 * composite.c (get_composition_id, gstring_lookup_cache):
2396 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2397 * image.c (xpm_get_color_table_h):
2398 * lisp.h (hash_lookup, hash_put):
2399 * minibuf.c (Ftest_completion):
2400 Use ptrdiff_t for hash table indexes, not int (which is too
2401 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2402 32-bit --with-wide-int hosts).
2403
e097a6fa
PE
2404 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2405 Add a FIXME comment about memory leaks.
2406 (syms_of_charset): Don't assume xmalloc returns.
2407
5637687f
PE
2408 Don't assume that stated character widths fit in int.
2409 * character.c (Fchar_width, c_string_width, lisp_string_width):
2410 * character.h (CHAR_WIDTH):
2411 * indent.c (MULTIBYTE_BYTES_WIDTH):
2412 Use sanitize_char_width to avoid undefined and/or bad behavior
2413 with outlandish widths.
a66cfb1c 2414 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2415 now that we have two such functions. All uses changed.
2416 (sanitize_char_width): New inline function.
2417
a2271ba2
PE
2418 Don't assume that tab-width fits in int.
2419 * character.h (sanitize_width): New inline function.
2420 (SANE_TAB_WIDTH): New macro.
2421 (ASCII_CHAR_WIDTH): Use it.
2422 * indent.c (sane_tab_width): Remove. All uses replaced by
2423 SANE_TAB_WIDTH (current_buffer).
2424 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2425
18c52557
PE
2426 * fileio.c: Integer overflow issues with file modes.
2427 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2428
caeeedc1
PE
2429 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2430 Remove unreachable code.
2431 (read_hex, load_charset_map_from_file): Check for integer overflow.
2432
6df6ae42 2433 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2434 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2435 (x_send_scroll_bar_event): Likewise. Check that the size does not
2436 exceed limits imposed by XClientMessageEvent, as well as the usual
2437 ptrdiff_t and size_t limits.
2438
b13995db
PE
2439 * keyboard.c: Overflow, signedness and related fixes.
2440 (make_lispy_movement): Use same integer type in forward decl
2441 that is used in the definition.
2442 (read_key_sequence, keyremap_step):
2443 Change bufsize argument back to int, undoing my 2011-03-30 change.
2444 We prefer signed types, and int is wide enough here.
2445 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2446 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2447 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2448 length, not size_t. Use ptrdiff_t for index, not int.
2449 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2450 possibility of integer overflow.
2451
13464394
PE
2452 Overflow, signedness and related fixes for images.
2453
2454 * dispextern.h (struct it.stack[0].u.image.image_id)
2455 (struct_it.image_id, struct image.id, struct image_cache.size)
2456 (struct image_cache.used, struct image_cache.ref_count):
2457 * gtkutil.c (update_frame_tool_bar):
2458 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2459 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2460 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2461 * nsmenu.m (update_frame_tool_bar):
2462 * xdisp.c (calc_pixel_width_or_height):
2463 * xfns.c (image_cache_refcount):
2464 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2465 on typical 64-bit hosts.
2466
2467 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2468 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2469 Omit unnecessary casts to int.
2470 (parse_image_spec): Check that integers fall into 'int' range
2471 when the callers expect that.
2472 (image_ascent): Redo ascent calculation to avoid int overflow.
2473 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2474 (lookup_image): Remove unnecessary tests.
2475 (xbm_image_p): Locals are now of int, not EMACS_INT,
2476 since parse_image_check makes sure they fit into int.
2477 (png_load, gif_load, svg_load_image):
2478 Prefer int to unsigned where either will do.
2479 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2480 old tiff_error_handler and tiff_warning_handler.
2481 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2482 stack buffer overflows. It uses only the features of vsnprintf
2483 that are common to both POSIX and native Microsoft.
2484 (tiff_error_handler, tiff_warning_handler): Use it.
2485 (tiff_load, gif_load, imagemagick_load_image):
2486 Don't assume :index value fits in 'int'.
2487 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2488 (imagemagick_load_image): Check that crop parameters fit into
2489 the integer types that MagickCropImage accepts. Don't assume
2490 Vimagemagick_render_type has a nonnegative value. Don't assume
2491 size_t fits in 'long'.
2492 (gs_load): Use printmax_t to print the widest integers possible.
2493 Check for integer overflow when computing image height and width.
2494
c11821d4
EZ
24952011-08-26 Eli Zaretskii <eliz@gnu.org>
2496
2497 * xdisp.c (redisplay_window): Don't force window start if point
2498 will be invisible in the resulting window. (Bug#9324)
2499
0c95fcf7
EZ
25002011-08-25 Eli Zaretskii <eliz@gnu.org>
2501
2502 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2503 the display spec is of the form `(space ...)'.
2504 (handle_display_spec): Return the value returned by
2505 handle_single_display_spec, not just 1 or zero.
2506 (handle_single_display_spec): If the display spec is of the form
2507 `(space ...)', and specifies display in the text area, return 2
2508 rather than 1.
fee65a97 2509 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2510 accurately, and prefer exact match for point under bidi.
2511 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2512
2513 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2514 into disp_prop; all users changed.
2515
2516 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2517 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2518 for the text covered by the display property.
2519
e4ed06f1
CY
25202011-08-25 Chong Yidong <cyd@stupidchicken.com>
2521
2522 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2523 Change return value to nil.
2524 (Frecord_buffer): Delete unused function.
2525
f67cdd7f
EZ
25262011-08-24 Eli Zaretskii <eliz@gnu.org>
2527
5980d4c6
EZ
2528 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2529 buffers, return left-to-right.
8610fe8b
EZ
2530 (set_cursor_from_row): Consider candidate row a win if its glyph
2531 represents a newline and point is on that newline. Fixes cursor
2532 positioning on the newline at EOL of R2L text within L2R
2533 paragraph, and vice versa.
2534 (try_cursor_movement): Check continued rows, in addition to
2535 continuation rows. Fixes unwarranted scroll when point enters a
2536 continued line of R2L text within an L2R paragraph, or vice versa.
2537 (cursor_row_p): Consider the case of point being equal to
2538 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2539 from the end of a short line to the beginning of a continued line
2540 of R2L text within L2R paragraph.
2541 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2542 composed characters.
5980d4c6 2543
f67cdd7f
EZ
2544 * bidi.c (bidi_check_type): Use xassert.
2545 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2546 members.
2547
bca633fb
EZ
25482011-08-23 Eli Zaretskii <eliz@gnu.org>
2549
2550 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2551 a character.
2552
4a5885a7
CY
25532011-08-23 Chong Yidong <cyd@stupidchicken.com>
2554
2555 * nsfont.m (ns_otf_to_script): Fix typo.
2556
0902a04e
KH
25572011-08-22 Kenichi Handa <handa@m17n.org>
2558
2559 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2560 extra slot even if the purpose is char-code-property-table.
2561
1a2e6670
EZ
25622011-08-23 Eli Zaretskii <eliz@gnu.org>
2563
8ddde651
EZ
2564 * xdisp.c (redisplay_window): When computing centering_position,
2565 account for the height of the header line. (Bug#8874)
2566
425cc014
EZ
2567 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2568 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2569 candidate is selected by the mouse, and that candidate has a
2570 composed character under the mouse.
2571
1a2e6670
EZ
2572 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2573 coordinates reported by pos-visible-in-window-p for a composed
2574 character in column zero.
2575
8b76d6f8
SM
25762011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2577
2578 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2579
dac347dd
EZ
25802011-08-22 Eli Zaretskii <eliz@gnu.org>
2581
2582 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2583 consider it a hit if to_charpos is anywhere in the range of the
2584 composed buffer positions.
2585
e013fb34
CY
25862011-08-22 Chong Yidong <cyd@stupidchicken.com>
2587
2588 * image.c (gif_load): Don't assume that each subimage has the same
2589 dimensions as the base image. Handle disposal method that is
2590 "undefined" by the gif spec (Bug#9335).
2591
bd1ba3e8
CY
25922011-08-20 Chong Yidong <cyd@stupidchicken.com>
2593
2594 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2595 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2596
54a1215b
EZ
25972011-08-19 Eli Zaretskii <eliz@gnu.org>
2598
823564e5
EZ
2599 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2600 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2601 from an Org mode buffer to a Speedbar frame.
2602
54a1215b
EZ
2603 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2604 a composition, take its buffer position from IT->cmp_it.charpos.
2605 Fixes cursor positioning at the beginning of a line that begins
2606 with a composed character.
2607
9778ebcc
EZ
26082011-08-18 Eli Zaretskii <eliz@gnu.org>
2609
0be6ee06
EZ
2610 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2611 character bidirectional type, use STRONG_L instead. Fixes crashes
2612 in a buffer produced by `describe-categories'.
2613
9778ebcc
EZ
2614 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2615 members before the level stack, so they would be saved and
2616 restored when copying iterator state. Fixes incorrect reordering
2617 around TABs covered by display properties.
2618
156bffbe
AS
26192011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2620
6b02f655 2621 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2622
72ad093b
CY
26232011-08-17 Chong Yidong <cyd@stupidchicken.com>
2624
2625 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2626 (internal_condition_case_2, internal_condition_case_n):
2627 Remove unnecessary aborts (Bug#9081).
72ad093b 2628
35774242
EZ
26292011-08-17 Eli Zaretskii <eliz@gnu.org>
2630
2631 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2632 has no `load' handler, try opening the file locally. (Bug#9311)
2633
db76dd85
KB
26342011-08-16 Ken Brown <kbrown@cornell.edu>
2635
2636 * gmalloc.c: Expand comment.
2637
b215eee5
EZ
26382011-08-16 Eli Zaretskii <eliz@gnu.org>
2639
2640 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2641 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2642
a4579d33
KB
26432011-08-16 Ken Brown <kbrown@cornell.edu>
2644
2645 Fix memory allocation problems in Cygwin build (Bug#9273).
2646
2647 * unexcw.c ( __malloc_initialized): Declare external variable.
2648 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2649
8b76d6f8
SM
2650 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2651 New variables.
a4579d33
KB
2652 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2653 dumped emacs.
2654 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2655 in the static heap.
2656 [CYGWIN] (special_realloc): New function.
2657 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2658 requests to realloc storage in the static heap.
2659
3ebec551
PE
26602011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2661
2662 * bidi.c (bidi_initialize): Remove unused local.
2663
9fd8be00
EZ
26642011-08-15 Eli Zaretskii <eliz@gnu.org>
2665
6b02f655
SM
2666 * bidimirror.h:
2667 * biditype.h: Remove file.
2668 * makefile.w32-in ($(BLD)/bidi.$(O)):
2669 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2670
2671 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2672
2673 * chartab.c: Improve commentary for the uniprop_table API.
2674
32413314
EZ
2675 * bidi.c (bidi_paragraph_init): Support zero value of
2676 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2677 (bidi_initialize): Use uniprop_table instead of including
2678 biditype.h and bidimirror.h.
32413314 2679
9fd8be00
EZ
2680 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2681 coordinates of the iterator when restoring from ppos_it.
2682 (Bug#9296)
2683
5cf2b69b
KH
26842011-08-14 Kenichi Handa <handa@m17n.org>
2685
2686 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2687 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2688
daf17d00
EZ
26892011-08-14 Eli Zaretskii <eliz@gnu.org>
2690
2691 * xdisp.c (move_it_in_display_line_to): Don't invoke
2692 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2693 ppos_it. Fixes vertical cursor motion when line beginning is
2694 covered by an image. (Bug#9296)
2695
08e3161a
JD
26962011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2697
2698 * nsterm.h (ns_run_ascript): Declare.
2699 (NSAPP_DATA2_RUNASSCRIPT): Define.
2700
2701 * nsfns.m (as_script, as_result, as_status): New static variables.
2702 (ns_run_ascript): New function.
5e617bc2 2703 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2704 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2705 the event loop. Get status from as_status (Bug#7276).
2706
2707 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2708 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2709 the event loop (Bug#7276).
2710
a3720aa2
AS
27112011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2712
2713 * gnutls.c (QCgnutls_bootprop_priority)
2714 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2715 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2716 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2717 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2718 (QCgnutls_bootprop_verify_hostname_error)
2719 (QCgnutls_bootprop_callbacks_verify): Rename from
2720 Qgnutls_bootprop_..., all uses changed.
2721
2722 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2723 uses changed.
2724
0a0d27fb
PE
27252011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2726
19d5c50c
PE
2727 * xfaces.c (Qframe_set_background_mode): Now static.
2728 * dispextern.h (Qframe_set_background_mode): Remove decl.
2729
0a0d27fb
PE
2730 * process.c (Fnetwork_interface_info): Declare local only if needed.
2731
377538cb
JD
27322011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2733
2734 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2735 (Fnetwork_interface_list): Allocate in increments of bytes instead
2736 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2737 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2738 sockaddr.
2739 (struct ifflag_def): notrailers is smart on OSX.
2740 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2741 Get hardware address with getifaddrs if available.
2742
08fff70c
EZ
27432011-08-12 Eli Zaretskii <eliz@gnu.org>
2744
2745 * xdisp.c (iterate_out_of_display_property): xassert that
2746 IT->position is set to within IT->object's boundaries. Break from
2747 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2748 when IT->position is set up wrongly due to some bug.
2749 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2750 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2751 entry. Force push_it to save on the stack the current
2752 buffer/string position, to be restored by pop_it. Fix flags in
2753 the iterator structure wrt the object coming from a display
2754 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2755 properties. (Bug#9284)
2756
7be1c708 27572011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2758
7be1c708
CY
2759 * fontset.c (fontset_get_font_group): Add proper type checks.
2760 (Bug#9172)
aac0c6e3 2761
7be1c708 27622011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2763
7be1c708
CY
2764 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2765 and LC_VERSION_MIN_MACOSX.
2766 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2767 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2768
97bb72a6
EZ
27692011-08-08 Eli Zaretskii <eliz@gnu.org>
2770
2771 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2772 no-display-properties-and-no-overlays under bidi display.
2773 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2774 properties and overlays.
97bb72a6 2775
d5617611
CY
27762011-08-08 Chong Yidong <cyd@stupidchicken.com>
2777
37e11a63
CY
2778 * editfns.c (Fset_time_zone_rule): Document relationship with the
2779 setenv function.
2780
d5617611
CY
2781 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2782 the font entity extracted from the cache (Bug#8109).
2783
58872834
CY
27842011-08-07 Chong Yidong <cyd@stupidchicken.com>
2785
2786 * composite.c (autocmp_chars): Don't reset point. That is done by
2787 restore_point_unwind (Bug#5984).
2788
75bfc667
JL
27892011-08-07 Juri Linkov <juri@jurta.org>
2790
2791 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2792 to show the arg `TIME' instead of `TIMEVAL'.
2793
d1410150
EZ
27942011-08-06 Eli Zaretskii <eliz@gnu.org>
2795
2796 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2797 display property strides EOL and includes a newline, as in
2798 longlines-mode. (Bug#9254)
75b771e4
EZ
2799 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2800 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2801
2802 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2803 is non-zero, even if the data buffer is NULL. Fixes a crash in
2804 vertical-motion with longlines-mode. (Bug#9254)
2805
35928349
EZ
28062011-08-05 Eli Zaretskii <eliz@gnu.org>
2807
ec7cc85b
EZ
2808 * bidi.c <bidi_cache_total_alloc>: Now static.
2809 (bidi_initialize): Initialize bidi_cache_total_alloc.
2810
8b76d6f8 2811 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2812 cache. (Bug#9221)
2813
2814 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2815 amount allocated this far in `bidi_cache_total_alloc'.
2816 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2817 non-zero, only free the data buffer without restoring the cache
2818 contents. All callers changed.
2819
2820 * dispextern.h (bidi_unshelve_cache): Update prototype.
2821
2822 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2823 (move_it_in_display_line, move_it_to)
2824 (move_it_vertically_backward, move_it_by_lines): Replace the call
2825 to xfree to an equivalent call to bidi_unshelve_cache.
2826 (move_it_in_display_line_to): Fix logic of returning
412b6358 2827 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2828
e2e2423b
EZ
28292011-08-05 Eli Zaretskii <eliz@gnu.org>
2830
2831 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2832 came from a string character with a `cursor' property. (Bug#9229)
2833
ae9e757a
JD
28342011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2835
2836 * Makefile.in (LIB_PTHREAD): New variable.
2837 (LIBES): Add LIB_PTHREAD (Bug#9216).
2838
2839 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2840 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2841
213bd7f2
AS
28422011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2843
6b02f655 2844 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2845
99aaf75f
JD
28462011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2847
2848 * xterm.c (x_find_topmost_parent): New function.
2849 (x_set_frame_alpha): Find topmost parent window with
2850 x_find_topmost_parent and set the property there also (bug#9181).
2851 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2852
c74e9d86
PE
28532011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2854
2855 * callproc.c (Fcall_process): Avoid vfork clobbering
2856 the local vars buffer, coding_systems, current_dir.
2857
640c8776
SM
28582011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2861
f26d0e4c
PE
28622011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2863
8a10d76c
PE
2864 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2865 so that it is not optimized away.
2866
f26d0e4c
PE
2867 * xdisp.c (compute_display_string_pos): Remove unused local.
2868
55439c61
EZ
28692011-08-02 Eli Zaretskii <eliz@gnu.org>
2870
2871 Fix slow cursor motion and scrolling in large buffers with
2872 selective display, like Org Mode buffers. (Bug#9218)
2873
2874 * dispextern.h (struct bidi_it): New member disp_prop_p.
2875
2876 * xdisp.c: Remove one-slot cache of display string positions.
2877 (compute_display_string_pos): Accept an additional argument
5e617bc2 2878 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2879 for a display string or property. If found, set DISP_PROP_P
2880 non-zero.
2881
2882 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2883 DISP_PROP_P, and pass it to compute_display_string_pos.
2884 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2885 non-zero. All callers of bidi_fetch_char changed.
2886
fb33fa43
SM
28872011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2888
2889 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2890
b099e063
DM
28912010-12-03 Don March <don@ohspite.net>
2892
2893 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2894 last character M-[char] is translated to ESC [char] (bug#7541).
2895
5cc7f7af
KH
28962011-08-02 Kenichi Handa <handa@m17n.org>
2897
d0fffa3f 2898 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2899
2900 * chartab.c (uniprop_table): Make it non-static.
2901
525d5e6e
EZ
29022011-08-01 Eli Zaretskii <eliz@gnu.org>
2903
2904 * xdisp.c (forward_to_next_line_start): Accept additional argument
2905 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2906 on the newline.
2907 (reseat_at_next_visible_line_start): Use the bidi iterator state
2908 returned by forward_to_next_line_start to restore the state of
2909 it->bidi_it after backing up to previous newline. (Bug#9212)
2910
31011111
AS
29112011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2912
2913 * regex.c (re_comp): Protoize.
2914 (re_exec): Fix return type.
2915 (regexec): Fix type of `ret'. (Bug#9203)
2916
476371c4
PE
29172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2918
e5d76069
PE
2919 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2920 This is needed if max-image-size is a floating-point number.
2921
9a79b20c
AS
29222011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2923
2924 * print.c (print_object): Print empty symbol as ##.
2925
2926 * lread.c (read1): Read ## as empty symbol.
2927
d8c2fa78
AA
29282011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2929
2930 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2931 setting frame foreground color (Bug#9175).
2932 (x_set_background_color): Likewise.
2933
ffe57a7a
AA
2934 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2935 contents (Bug#9176).
2936 (EmacsTooltip -init): Remove bezels and add shadows to
2937 tooltip windows.
2938
bf3492a5
AA
2939 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2940 or scroll bar (Bug#8470).
2941
d55e9c53
AA
2942 * nsfont.m (nsfont_open): Remove assignment to voffset and
2943 unnecessary vars hshink, expand, hd, full_height, min_height.
2944 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2945
2946 * nsterm.h (nsfont_info): Remove voffset field.
2947
d8c2fa78 29482011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2949
2950 Implement strike-through and overline on NextStep (Bug#8863).
2951
2952 * nsfont.m (nsfont_open): Use underline position provided by font,
2953 instead of hard-coded value of 2.
2954 (nsfont_draw): Call ns_draw_text_decoration instead.
2955
2956 * nsterm.h: Add declaration for ns_draw_text_decoration.
2957
2958 * nsterm.m (ns_draw_text_decoration): New function for drawing
2959 underline, overline, and strike-through.
2960 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2961 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2962 accommodate underlining, etc.
4843aac3 2963
4cc60b9b
EZ
29642011-07-28 Eli Zaretskii <eliz@gnu.org>
2965
bc7ece87
EZ
2966 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2967 default.
4cc60b9b 2968
476371c4
PE
29692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2970
66606eea
PE
2971 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2972 Without this fix, if a signal arrives just after memory fills up,
2973 'malloc' might be invoked reentrantly.
2974
476371c4
PE
2975 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2976 In other words, assume that every image size is allowed, on non-X
2977 hosts. This assumption is probably wrong, but it lets Emacs compile.
2978
f3fcc40d
AS
29792011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2980
2981 * regex.c (re_iswctype): Convert return values to boolean.
2982
350c992f
EZ
29832011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2984
2985 * xdisp.c (compute_display_string_pos): Don't use cached display
2986 string position if the buffer had its restriction changed.
2987 (Bug#9184)
2988
5266b4bb
PE
29892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2992
2573a837 29932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2994
41f55ccd 2995 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2996
39e378da
PE
2997 * bidi.c: Integer size and overflow fixes.
2998 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2999 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3000 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3001 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3002 (bidi_find_other_level_edge):
3003 Use ptrdiff_t instead of EMACS_INT where either will do.
3004 This works better on 32-bit hosts configured --with-wide-int.
3005 (bidi_cache_ensure_space): Check for size-calculation overflow.
3006 Use % rather than repeated addition, for better worst-case speed.
3007 Don't set bidi_cache_size until after xrealloc returns, because it
3008 might not return.
3009 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3010 (bidi_cache_ensure_space): Also check that the bidi cache size
3011 does not exceed that of the largest Lisp string or buffer. See Eli
3012 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3013
5e927815
PE
3014 * alloc.c (__malloc_size_t): Remove.
3015 All uses replaced by size_t. See Andreas Schwab's note
3016 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3017
ca4aa935
PE
3018 * image.c: Improve checking for integer overflow.
3019 (check_image_size): Assume that f is nonnull, since
3020 it is always nonnull in practice. This is one less thing to
3021 worry about when checking for integer overflow later.
3022 (x_check_image_size): New function, which checks for integer
3023 overflow issues inside X.
3024 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3025 This removes the need for a memory_full check.
3026 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3027 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3028 (xbm_read_bitmap_data): Change locals back to 'int', since
3029 their values must fit in 'int'.
3030 (xpm_load_image, png_load, tiff_load):
3031 Invoke x_create_x_image_and_pixmap earlier,
3032 to avoid much needless work if the image is too large.
3033 (tiff_load): Treat overly large images as if
3034 x_create_x_image_and_pixmap failed, not as malloc failures.
3035 (gs_load): Use x_check_image_size.
3036
5f8f9cc2
PE
3037 * gtkutil.c: Omit integer casts.
3038 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3039 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3040
5adf60bc
PE
3041 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3042
c8907a93
PE
3043 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3044 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3045 would wrongly return t on a 64-bit host.
3046
e3c25c68
PE
3047 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3048 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3049 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3050 and therefore cause GCC to emit a bogus diagnostic in some cases.
3051
3f791afe
PE
3052 * image.c: Integer signedness and overflow and related fixes.
3053 This is not an exhaustive set of fixes, but it's time to
3054 record what I've got.
3055 (lookup_pixel_color, check_image_size): Remove redundant decls.
3056 (check_image_size): Don't assume that arbitrary EMACS_INT values
3057 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3058 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3059 (tiff_load, imagemagick_load_image):
3060 Check for overflow in size calculations.
3061 (x_create_x_image_and_pixmap): Remove unnecessary test for
3062 xmalloc returning NULL; that can't happen.
3063 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3064 (xpm_color_bucket): Use better integer hashing function.
3065 (xpm_cache_color): Don't possibly over-allocate memory.
3066 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3067 (gif_memory_source):
3068 Use ptrdiff_t, not int or size_t, to record sizes.
3069 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3070 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3071 either works, as we prefer signed integers.
3072 (tiff_read_from_memory, tiff_write_from_memory):
3073 Return tsize_t, not size_t, since that's what the TIFF API wants.
3074 (tiff_read_from_memory): Don't fail simply because the read would
3075 go past EOF; instead, return a short read.
3076 (tiff_load): Omit no-longer-needed casts.
3077 (Fimagemagick_types): Don't assume size fits into 'int'.
3078
3cc5a532
PE
3079 Improve hashing quality when configured --with-wide-int.
3080 * fns.c (hash_string): New function, taken from sxhash_string.
3081 Do not discard information about ASCII character case; this
3082 discarding is no longer needed.
3083 (sxhash-string): Use it. Change sig to match it. Caller changed.
3084 * lisp.h: Declare it.
3085 * lread.c (hash_string): Remove, since we now use fns.c's version.
3086 The fns.c version returns a wider integer if --with-wide-int is
3087 specified, so this should help the quality of the hashing a bit.
3088
b312a492
PE
3089 * emacs.c: Integer overflow minor fix.
3090 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3091 Define only if GNU_LINUX.
3092 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3093
dfd153ae
PE
3094 * dispnew.c: Integer signedness and overflow fixes.
3095 Remove unnecessary forward decls, that were a maintenance hassle.
3096 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3097 All uses changed.
3098 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3099 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3100 (prepare_desired_row, line_draw_cost):
3101 Use int, not unsigned, where either works.
3102 (save_current_matrix, restore_current_matrix):
3103 Use ptrdiff_t, not size_t, where either works.
3104 (init_display): Check for overflow more accurately, and without
3105 relying on undefined behavior.
3106
a81d11a3
PE
3107 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3108 Remove, replacing with the new symbols in lisp.h. All uses changed.
3109 * fileio.c (make_temp_name):
3110 * filelock.c (lock_file_1, lock_file):
3111 * xdisp.c (message_dolog):
3112 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3113 Use pMd etc. instead.
3114 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3115 replacing the pWIDE etc. symbols removed from editfns.c.
3116
3300e6fd
PE
3117 * keyboard.h (num_input_events): Now uintmax_t.
3118 This is (very slightly) less likely to mess up due to wraparound.
3119 All uses changed.
3120
fd05c7e9
PE
3121 * buffer.c: Integer signedness fixes.
3122 (alloc_buffer_text, enlarge_buffer_text):
3123 Use ptrdiff_t rather than size_t when either will do, as we prefer
3124 signed integers.
3125
903fe15d
PE
3126 * alloc.c: Integer signedness and overflow fixes.
3127 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3128 (__malloc_size_t): Default to size_t, not to int.
3129 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3130 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3131 Prefer ptrdiff_t to size_t when either would do, as we prefer
3132 signed integers.
3133 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3134 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3135 Now const. Initialize with values that are in range even if char
3136 is signed.
3137 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3138 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3139 These functions do the right thing with sizes > 2**32.
3140 (check_depth): Now ptrdiff_t, not int.
3141 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3142 Adjust to new way of storing sizes. Check for size overflow bugs
3143 in rest of code.
3144 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3145 slightly wrong anyway, as it missed one instance of
3146 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3147 (refill_memory_reserve): Omit needless cast to size_t.
3148 (mark_object_loop_halt): Mark as externally visible.
3149
ac82cc6a
PE
3150 * xselect.c: Integer signedness and overflow fixes.
3151 (Fx_register_dnd_atom, x_handle_dnd_message):
3152 Use ptrdiff_t, not size_t, since we prefer signed.
3153 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3154 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3155 x_dnd_atoms_size and x_dnd_atoms_length.
3156
c2d1e36d
PE
3157 * doprnt.c: Prefer signed to unsigned when either works.
3158 * eval.c (verror):
3159 * doprnt.c (doprnt):
3160 * lisp.h (doprnt):
3161 * xdisp.c (vmessage):
3162 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3163 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3164 prefer signed arithmetic to avoid comparison confusion.
3165 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3166 but is a bit tricky.
3167
0e926e56
PE
3168 Assume freestanding C89 headers, string.h, stdlib.h.
3169 * data.c, doprnt.c, floatfns.c, print.c:
3170 Include float.h unconditionally.
3171 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3172 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3173 * regex.c: Likewise for stddef.h, string.h.
3174 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3175 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3176 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3177 (STDC_HEADERS): Remove obsolete defines.
3178 * sysdep.c: Include limits.h unconditionally.
3179
9cfdb3ec
PE
3180 Assume support for memcmp, memcpy, memmove, memset.
3181 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3182 * regex.c (memcmp, memcpy):
3183 Remove; we assume C89 now.
3184
3185 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3186 (__malloc_safe_bcopy): Remove; no longer needed.
3187
cf950e6b 3188 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3189 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3190 well either way, and we prefer signed to unsigned.
3191
dbf38e02
LMI
31922011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3193
3194 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3195 closes the connection while we're reading (bug#9182).
3196
d6f0886c 31972011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3198
d6f0886c
JD
3199 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3200 are specified (Bug#9168).
24e0f6b1 3201
2eb1f9e6
PE
32022011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3203
3204 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3205 Found by GCC static checking and --with-wide-int on a 32-bit host.
3206
22381272 32072011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3208
3209 * xdisp.c (compute_display_string_pos): Fix logic of caching
3210 previous display string position. Initialize cached_prev_pos to
3211 -1. Fixes slow-down at the beginning of a buffer.
3212
f25e39b4
EZ
32132011-07-24 Eli Zaretskii <eliz@gnu.org>
3214
3215 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3216 for attrs[LFACE_FONTSET_INDEX].
3217
04c4b52e
PE
32182011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 * xml.c (parse_region): Remove unused local
3221 that was recently introduced.
3222
c1734fbd
EZ
32232011-07-23 Eli Zaretskii <eliz@gnu.org>
3224
be18c5a5
EZ
3225 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3226 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3227
c1734fbd
EZ
3228 * xdisp.c (move_it_in_display_line_to): Record the best matching
3229 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3230 exit if none of the characters scanned was an exact match.
3231 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3232 when exact match is impossible due to invisible text, and the
3233 lines are truncated.
3234
a258d627
JD
32352011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3236
3237 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3238 for OSX >= 10.7.
3239
b6d5a689
EZ
32402011-07-22 Eli Zaretskii <eliz@gnu.org>
3241
0f74f785
EZ
3242 Fix a significant slow-down of cursor motion with C-n, C-p,
3243 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3244 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3245 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3246 (next_element_from_buffer): Call compute_stop_pos_backwards to
3247 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3248 base_level_stop.
3249 (reseat): Don't look for prev_stop, as that could mean a very long
3250 run.
3251 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3252 <cached_disp_overlay_modiff>: Cache for last found display string
3253 position.
551918c1 3254 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3255 about the same buffer in the same area of character positions, and
3256 the buffer wasn't changed since the time the display string
3257 position was cached.
551918c1 3258
b2d0c91a
EZ
32592011-07-22 Eli Zaretskii <eliz@gnu.org>
3260
3261 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3262 is an integer, which is important for empty lines. (Bug#9149)
3263
043604ee
CY
32642011-07-22 Chong Yidong <cyd@stupidchicken.com>
3265
3266 * frame.c (Fmodify_frame_parameters): In tty case, update the
3267 default face if necessary (Bug#4238).
3268
da4adb04
CY
32692011-07-21 Chong Yidong <cyd@stupidchicken.com>
3270
3271 * editfns.c (Fstring_to_char): No need to explain what a character
3272 is in the docstring (Bug#6576).
3273
9abd0532
LMI
32742011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3275
3276 * xml.c (parse_region): Make sure we always return a tree.
3277
36881d16
HK
32782011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3279
3280 * xml.c (parse_region): If a document contains only comments,
3281 return that, too.
3282
1e98674d
LMI
32832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3284
3285 * xml.c (make_dom): Return comments, too.
3286
590bd467
PE
32872011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3288
3289 Port to OpenBSD.
3290 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3291 and the surrounding thread.
3292 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3293 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3294 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3295 timer goes off.
3296 * s/openbsd.h (BROKEN_SIGIO): Define.
3297 * unexelf.c (unexec) [__OpenBSD__]:
3298 Don't update the .mdebug section of the Alpha COFF symbol table.
3299
f41628b2
LMI
33002011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3301
3302 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3303 (bug#8460).
3304
b59b67c5
PE
33052011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3306
15e3a074
PE
3307 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3308 This fixes some race conditions on the permissions of any newly
3309 created file.
3310
41bed37d
PE
3311 * alloc.c (valid_pointer_p): Use pipe, not open.
3312 This fixes some permissions issues when debugging.
3313
b59b67c5
PE
3314 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3315 If fchown fails to set both uid and gid, try to set just gid,
3316 as that is sometimes allowed. Adjust the file's mode to eliminate
3317 setuid or setgid bits that are inappropriate if fchown fails.
3318
925a6be7
SM
33192011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3320
3321 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3322 to compare Lisp_Objects.
3323 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3324 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3325 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3326
52968808
AS
33272011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3328
0a6a104b
AS
3329 * lread.c (read_integer): Unread even EOF character.
3330 (read1): Likewise. Properly record start position of symbol.
3331
52968808
AS
3332 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3333 symbol character follows.
3334
9e381cdd
PE
33352011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3336
3337 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3338 This works around a problem with the previous change to Fcopy_file.
3339 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3340 and without this change, GCC might complain about discarding
3341 fchown's return value.
3342
b5641435
JB
33432011-07-16 Juanma Barranquero <lekktu@gmail.com>
3344
3345 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3346
a8031457
PE
33472011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3348
3349 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3350
dd889327
LMI
33512011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3352
750c33f7
LMI
3353 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3354 it's used from the C level.
3355
dd889327
LMI
3356 * process.c: Use the same condition for POLL_FOR_INPUT in both
3357 keyboard.c and process.c (bug#1858).
3358
87e86684
LM
33592011-07-09 Lawrence Mitchell <wence@gmx.li>
3360
3361 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3362 (Fgnutls_boot): Use it.
3363
64348f40
AS
33642011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3365
3366 * doc.c (Fsubstitute_command_keys): Revert last change.
3367
1d698799
LMI
33682011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3369
f863868c
LMI
3370 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3371 quotes the next character, and doesn't affect other longer
3372 sequences (bug#8935).
3373
1d698799
LMI
3374 * lread.c (syms_of_lread): Clarify that is isn't only
3375 `eval-buffer' and `eval-defun' that's affected by
3376 `lexical-binding' (bug#8460).
3377
aa4b6df6
EZ
33782011-07-15 Eli Zaretskii <eliz@gnu.org>
3379
3380 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3381 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3382
5d856da6
PE
33832011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3384
ad6042bb
PE
3385 Fix minor problems found by static checking.
3386 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3387 (elsz): Now a signed constant, not a size_t var. We prefer signed
3388 types to unsigned, to avoid integer comparison confusion. Without
3389 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3390 "cannot optimize loop, the loop counter may overflow", a symptom
3391 of the confusion.
f00bbb22 3392 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3393 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3394
6468f31c
LMI
33952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3396
49080b10
LMI
3397 * search.c (Fre_search_backward): Mention `case-fold-search' in
3398 all the re_search_* functions (bug#8138).
3399
6468f31c
LMI
3400 * keyboard.c (Fopen_dribble_file): Document when the file is
3401 closed (bug#8056).
3402
c965adc5
EZ
34032011-07-14 Eli Zaretskii <eliz@gnu.org>
3404
df9733bf
EZ
3405 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3406 bidi_cache_idx.
3407
0bb23927
EZ
3408 Support bidi reordering of display and overlay strings.
3409 * xdisp.c (compute_display_string_pos)
3410 (compute_display_string_end): Accept additional argument STRING.
3411 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3412 (reseat_to_string): Initialize bidi_it->string.s and
3413 bidi_it->string.schars.
3414 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3415 NULL (avoids a crash in bidi_paragraph_init).
3416 Initialize itb.string.lstring.
0bb23927
EZ
3417 (init_iterator): Call bidi_init_it only of a valid
3418 buffer position was specified. Initialize paragraph_embedding to
3419 L2R.
3420 (reseat_to_string): Initialize the bidi iterator.
3421 (display_string): If we need to ignore text properties of
3422 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3423 original value of -1 will not work with bidi.)
3424 (compute_display_string_pos): First arg is now struct
3425 `text_pos *'; all callers changed. Support display properties on
3426 Lisp strings.
3427 (compute_display_string_end): Support display properties on Lisp
3428 strings.
3429 (init_iterator, reseat_1, reseat_to_string): Initialize the
3430 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3431 when iterating on a string not from display properties).
640c8776
SM
3432 (compute_display_string_pos, compute_display_string_end):
3433 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3434 arrow keys.
3435 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3436 base_level_stop; instead, set base_level_stop to BEGV.
3437 Fixes crashes in vertical-motion.
0bb23927
EZ
3438 (next_element_from_buffer): Improve commentary for when
3439 the iterator is before prev_stop.
3440 (init_iterator): Initialize bidi_p from the default value of
3441 bidi-display-reordering, not from buffer-local value. Use the
3442 buffer-local value only if initializing for buffer iteration.
3443 (handle_invisible_prop): Support invisible properties on strings
3444 that are being bidi-reordered.
3445 (set_iterator_to_next): Support bidi reordering of C strings and
3446 Lisp strings.
3447 (next_element_from_string): Support bidi reordering of Lisp
3448 strings.
3449 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3450 (display_string): Support display of R2L glyph rows.
3451 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3452 (init_iterator): Don't initialize it->bidi_p for strings
3453 here.
3454 (reseat_to_string): Initialize it->bidi_p for strings here.
3455 (next_element_from_string, next_element_from_c_string)
3456 (next_element_from_buffer): Add xassert's for correspondence
3457 between IT's object being iterated and it->bidi_it.string
3458 structure.
3459 (face_before_or_after_it_pos): Support bidi iteration.
3460 (next_element_from_c_string): Handle the case of the first string
3461 character that is not the first one in the visual order.
3462 (get_visually_first_element): New function, refactored from common
3463 parts of next_element_from_buffer, next_element_from_string, and
3464 next_element_from_c_string.
3465 (tool_bar_lines_needed, redisplay_tool_bar)
3466 (display_menu_bar): Force left-to-right direction. Add a FIXME
3467 comment for making that be controlled by a user option.
3468 (push_it, pop_it): Save and restore the state of the
3469 bidi iterator. Save and restore the bidi_p flag.
3470 (pop_it): Iterate out of display property for string iteration as
3471 well.
3472 (iterate_out_of_display_property): Support iteration over strings.
3473 (handle_single_display_spec): Set up it->bidi_it for iteration
3474 over a display string, and call bidi_init_it.
3475 (handle_single_display_spec, next_overlay_string)
3476 (get_overlay_strings_1, push_display_prop): Set up the bidi
3477 iterator for displaying display or overlay strings.
3478 (forward_to_next_line_start): Don't use the shortcut if
3479 bidi-iterating.
3480 (back_to_previous_visible_line_start): If handle_display_prop
3481 pushed the iterator stack, restore the internal state of the bidi
3482 iterator by calling bidi_pop_it same number of times.
3483 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3484 and we are bidi-iterating, don't decrement the iterator position;
3485 instead, set the first_elt flag in the bidi iterator, to produce
3486 the same effect.
3487 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3488 (push_display_prop): xassert that we are iterating a buffer.
3489 (push_it, pop_it): Save and restore paragraph_embedding member.
3490 (handle_single_display_spec, next_overlay_string)
3491 (get_overlay_strings_1, reseat_1, reseat_to_string)
3492 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3493 correctly. Don't assume unibyte strings are not bidi-reordered.
3494 (compute_display_string_pos)
3495 (compute_display_string_end): Fix handling the case of C string.
3496 (push_it, pop_it): Save and restore from_disp_prop_p.
3497 (handle_single_display_spec, push_display_prop): Set the
3498 from_disp_prop_p flag.
3499 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3500 (pop_it): Call iterate_out_of_display_property only if we are
3501 popping after iteration over a string that came from a display
3502 property. Fix a typo in popping stretch info. Add an assertion
3503 for verifying that the iterator position is in sync with the bidi
3504 iterator.
3505 (handle_single_display_spec, get_overlay_strings_1)
3506 (push_display_prop): Fix initialization of paragraph direction for
3507 string when that of the parent object is not yet determined.
3508 (reseat_1): Call bidi_init_it to resync the bidi
3509 iterator with IT's position. (Bug#7616)
3510 (find_row_edges): If ROW->start.pos gives position
3511 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3512 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3513 Reset the from_disp_prop_p flag.
3514 (SAVE_IT, RESTORE_IT): New macros.
3515 (pos_visible_p, face_before_or_after_it_pos)
3516 (back_to_previous_visible_line_start)
3517 (move_it_in_display_line_to, move_it_in_display_line)
3518 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3519 (try_scrolling, redisplay_window, display_line): Use them when
3520 saving a temporary copy of the iterator and restoring it back.
3521 (back_to_previous_visible_line_start, reseat_1)
3522 (init_iterator): Empty the bidi cache "stack".
3523 (move_it_in_display_line_to): If iterator ended up at
3524 EOL, but we never saw any buffer positions smaller than
3525 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3526 motion in bidi-reordered lines.
3527 (move_it_in_display_line_to): Record prev_method and prev_pos
3528 immediately before the call to set_iterator_to_next. Fixes cursor
3529 motion in bidi-reordered lines with stretch glyphs and strings
3530 displayed in margins. (Bug#8133) (Bug#8867)
3531 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3532 TO_CHARPOS.
640c8776
SM
3533 (pos_visible_p): Support positions in bidi-reordered lines.
3534 Save and restore bidi cache.
0bb23927
EZ
3535
3536 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3537 (bidi_paragraph_info): Delete unused struct.
3538 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3539 (bidi_cache_start): New variable.
3540 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3541 to zero.
3542 (bidi_cache_fetch_state, bidi_cache_search)
3543 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3544 (bidi_cache_find, bidi_peek_at_next_level)
3545 (bidi_level_of_next_char, bidi_find_other_level_edge)
3546 (bidi_move_to_visually_next): Compare cache index with
3547 bidi_cache_start rather than with zero.
3548 (bidi_fetch_char): Accept new argument STRING; all callers
3549 changed. Support iteration over a string. Support strings with
3550 display properties. Support unibyte strings. Fix the type of
3551 `len' according to what STRING_CHAR_AND_LENGTH expects.
3552 (bidi_paragraph_init, bidi_resolve_explicit_1)
3553 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3554 (bidi_level_of_next_char, bidi_move_to_visually_next):
3555 Support iteration over a string.
0bb23927
EZ
3556 (bidi_set_sor_type, bidi_resolve_explicit_1)
3557 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3558 can now be zero (for strings); special values 0 and -1 were
3559 changed to -1 and -2, respectively.
3560 (bidi_char_at_pos): New function.
3561 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3562 Call it instead of FETCH_MULTIBYTE_CHAR.
3563 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3564 initialized to valid values.
3565 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3566 values.
3567 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3568 the test for valid cached positions. Fix the logic for looking up
3569 the sentinel state in the cache. GCPRO the Lisp string we are
3570 iterating.
3571 (bidi_push_it, bidi_pop_it): New functions.
3572 (bidi_initialize): Initialize the bidi cache start stack pointer.
3573 (bidi_cache_ensure_space): New function, refactored from part of
3574 bidi_cache_iterator_state. Don't assume the required size is just
3575 one BIDI_CACHE_CHUNK away.
3576 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3577 (bidi_count_bytes, bidi_char_at_pos): New functions.
3578 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3579 always valid if bidi_cache_idx is valid.
3580 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3581 is valid if it's going to be used.
3582 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3583 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3584 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3585 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3586 (bidi_find_other_level_edge, bidi_cache_start_stack):
3587 All variables related to cache indices are now EMACS_INT.
c965adc5 3588
0bb23927
EZ
3589 * dispextern.h (struct bidi_string_data): New structure.
3590 (struct bidi_it): New member `string'. Make flag members be 1-bit
3591 fields, and put them last in the struct.
640c8776
SM
3592 (compute_display_string_pos, compute_display_string_end):
3593 Update prototypes.
0bb23927
EZ
3594 (bidi_push_it, bidi_pop_it): Add prototypes.
3595 (struct iterator_stack_entry): New members bidi_p,
3596 paragraph_embedding, and from_disp_prop_p.
3597 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3598 (bidi_shelve_cache, bidi_unshelve_cache):
3599 Declare prototypes.
0bb23927
EZ
3600
3601 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3602 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3603 and vector-like objects.
3604
3605 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3606 cache around display iteration.
3607
3608 * window.c (Fwindow_end, window_scroll_pixel_based)
3609 (displayed_window_lines, Frecenter): Save and restore the bidi
3610 cache around display iteration.
3611
3bbd2265
LMI
36122011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3613
3614 * editfns.c (Fdelete_region): Clarify the use of the named
3615 parameters (bug#6788).
3616
adc47434
MR
36172011-07-14 Martin Rudalics <rudalics@gmx.at>
3618
3619 * indent.c (Fvertical_motion): Set and restore w->pointm when
3620 saving and restoring the window's buffer (Bug#9006).
3621
837c31f8
LMI
36222011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3623
3624 * editfns.c (Fstring_to_char): Clarify just what is returned
3625 (bug#6576). Text by Eli Zaretskii.
3626
ac389d0c
JB
36272011-07-13 Juanma Barranquero <lekktu@gmail.com>
3628
3629 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3630
0be0ce47
EZ
36312011-07-13 Eli Zaretskii <eliz@gnu.org>
3632
3633 * buffer.c (mmap_find): Fix a typo.
3634
cd18e7e3
JB
36352011-07-13 Johan Bockgård <bojohan@gnu.org>
3636
3637 Fix execution of x selection hooks.
3638 * xselect.c (Qx_lost_selection_functions)
3639 (Qx_sent_selection_functions): New vars.
3640 (syms_of_xselect): DEFSYM them.
3641 (x_handle_selection_request): Pass Qx_sent_selection_functions
3642 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3643 (x_handle_selection_clear,x_clear_frame_selections):
3644 Pass Qx_lost_selection_functions rather than
3645 Vx_lost_selection_functions to Frun_hook_with_args.
3646
47ea7f44
PE
36472011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3648
ac389d0c 3649 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3650 The old code sometimes used this field without initializing it.
3651
47ea7f44
PE
3652 * alloc.c (gc_sweep): Don't read past end of array.
3653 In theory, the old code could also have corrupted Emacs internals,
3654 though it'd be very unlikely.
3655
bc985c87
AS
36562011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3657
3658 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3659 argument. (Bug#4026)
bc985c87 3660
0cf34688
LMI
36612011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3662
b3dadd76
LMI
3663 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3664 key" (bug#4257).
3665
0cf34688
LMI
3666 * window.c (Fset_window_start): Doc fix (bug#4199).
3667 (Fset_window_hscroll): Ditto.
3668
270768cd
PE
36692011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3670
077e3dda 3671 Fix minor new problems caught by GCC 4.6.1.
270768cd 3672 * term.c (init_tty): Remove unused local.
490011a6 3673 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3674 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3675 not used otherwise.
270768cd 3676
b1f58454
CY
36772011-07-12 Chong Yidong <cyd@stupidchicken.com>
3678
3679 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3680
22b9578d
LMI
36812011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3682
6e70ab07
LMI
3683 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3684 are the mini-buffer and the echo area (bug#3320).
3685
22b9578d
LMI
3686 * term.c (init_tty): Remove support for supdup, c10 and perq
3687 terminals, which are no longer supported (bug#1482).
3688
8974cc9f
JB
36892011-07-10 Johan Bockgård <bojohan@gnu.org>
3690
3691 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3692
a560d974
JD
36932011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3694
3695 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3696 for non-popups (Bug#3642).
3697
1dae0f0a
AS
36982011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3699
268c2c36 3700 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3701 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3702 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3703 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3704 * data.c (fmod): Likewise.
3705 * dispnew.c (swap_glyphs_in_rows): Likewise.
3706 * emacs.c (memory_warning_signal): Likewise.
3707 * floatfns.c (float_error): Likewise.
3708 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3709 (otf_open, font_otf_capability, generate_otf_features)
3710 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3711 Likewise.
3712 * image.c (pbm_read_file): Likewise.
3713 * indent.c (string_display_width): Likewise.
3714 * intervals.c (check_for_interval, search_for_interval)
3715 (inc_interval_count, count_intervals, root_interval)
3716 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3717 * lread.c (defalias): Likewise.
268c2c36 3718 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3719 * regex.c (set_image_of_range_1, set_image_of_range)
3720 (regex_grow_registers): Likewise.
3721 * sysdep.c (strerror): Likewise.
3722 * termcap.c (valid_filename_p, tprint, main): Likewise.
3723 * tparam.c (main): Likewise.
3724 * unexhp9k800.c (run_time_remap, save_data_space)
3725 (update_file_ptrs, read_header, write_header, calculate_checksum)
3726 (copy_file, copy_rest, display_header): Likewise.
3727 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3728 Likewise.
3729 * xdisp.c (check_it): Likewise.
3730 * xfaces.c (register_color, unregister_color, unregister_colors):
3731 Likewise.
3732 * xfns.c (print_fontset_result): Likewise.
3733 * xrdb.c (member, fatal, main): Likewise.
3734
99033785
PE
37352011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 Fix minor problems found by static checking (Bug#9031).
3738 * chartab.c (char_table_set_range, map_sub_char_table):
3739 Remove unused locals.
3740 (uniprop_table): Now static.
3741 * composite.c (_work_char): Remove unused static var.
3742
9cb2ac56
JB
37432011-07-09 Juanma Barranquero <lekktu@gmail.com>
3744
3745 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3746
f25661f0
JD
37472011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3748
3749 * gtkutil.c (qttip_cb): Remove code without function.
3750
8278c4fe
EZ
37512011-07-09 Eli Zaretskii <eliz@gnu.org>
3752
3753 * w32.c (pthread_sigmask): New stub.
3754
1692ae2d 37552011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3756
8a6ebd58 3757 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3758 sigprocmask is portable only for single-threaded applications, and
3759 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3760 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3761 (LIBES): Use it.
3762 * callproc.c (Fcall_process):
3763 * process.c (create_process):
3764 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3765 Use pthread_sigmask, not sigprocmask.
123403e4 3766
1b854618
JD
37672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3768
3769 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3770 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3771 wrong (Bug#8591).
3772
3fe4b549
JD
37732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3774
0ce7e563
JD
3775 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3776 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3777 (xg_hide_tooltip): Fix comment.
3778
3fe4b549
JD
3779 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3780 in registerServicesMenuSendTypes.
3781 (validRequestorForSendType): Don't check ns_return_types.
3782
3783 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3784 ns_return_type.
3785
5df75e47
JR
37862011-07-08 Jason Rumney <jasonr@gnu.org>
3787
22610910
JR
3788 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3789 SH_SHOW for hidden windows (Bug#5482).
3790
5df75e47
JR
3791 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3792 frame struct members of non-existent frames (Bug#6284).
3793
699c10bd
JD
37942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3795
4393663b
JD
3796 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3797 variable firstTime not needed on OSX >= 10.6.
3798 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3799 >= 10.5. Use setKnobProportion, setDoubleValue.
3800
3801 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3802 (MAC_OS_X_VERSION_10_5): Define if not defined.
3803 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3804 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3805 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3806
3807 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3808 cString and lossyCString on OSX >= 10.4
3809
58179cce 3810 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3811 sizeToFit on OSX >= 10.2.
3812
3813 * nsimage.m (allocInitFromFile): Don't use deprecated method
3814 bestRepresentationForDevice on OSX >= 10.6.
3815
3816 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3817 to avoid warning.
3818
3819 * emacs.c: Declare unexec_init_emacs_zone.
3820
a63e0781
JD
3821 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3822
699c10bd
JD
3823 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3824
3825 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3826 on svcsMenu (Bug#8842).
3827
3828 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3829 ns_return_types.
3830 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3831
3832 * nsterm.m (QUTF8_STRING): Declare.
3833 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3834 (validRequestorForSendType): Return type is (id).
3835 Change indexOfObjectIdenticalTo to indexOfObject.
3836 Check if we have local selection before returning self (Bug#8842).
3837 (writeSelectionToPasteboard): Put local selection into paste board
3838 if we have a local selection (Bug#8842).
3839 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3840
3841 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3842 (ns_get_local_selection): Declare.
3843
54e10184
LMI
38442011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3845
9888ff71
LMI
3846 * keymap.c (describe_map_tree): Don't insert a double newline at
3847 the end of the buffer (bug#1169) and return whether we inserted
3848 something.
3849
54e10184
LMI
3850 * callint.c (Fcall_interactively): Change "reading args" to
3851 "providing args" to try to clarify what it does (bug#1010).
3852
15fa4783
KH
38532011-07-07 Kenichi Handa <handa@m17n.org>
3854
3855 * composite.c (composition_compute_stop_pos): Ignore a static
3856 composition starting before CHARPOS (Bug#8915).
3857
3858 * xdisp.c (handle_composition_prop): Likewise.
3859
a8815b00
EZ
38602011-07-07 Eli Zaretskii <eliz@gnu.org>
3861
3862 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3863 (Bug#9015)
3864
ef7b981d 38652011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3866
3867 * character.h (unicode_category_t): New enum type.
3868
3869 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3870 (Qchar_code_property_table): New variable.
3871 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3872 (UNIPROP_COMPRESSED_FORM_P): New macros.
3873 (char_table_ascii): Uncompress the compressed values.
3874 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3875 Uncompress the compressed values.
ac389d0c 3876 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3877 (char_table_ref_and_range): Uncompress the compressed values.
3878 (sub_char_table_set): New arg is_uniprop. Callers changed.
3879 Uncompress the compressed values.
3880 (sub_char_table_set_range): Args changed. Callers changed.
3881 (char_table_set_range): Adjuted for the above change.
3882 (map_sub_char_table): Delete args default_val and parent. Add arg
3883 top. Give decoded values to a Lisp function.
640c8776 3884 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3885 values to a Lisp function. Gcpro more variables.
3886 (uniprop_table_uncompress)
3887 (uniprop_decode_value_run_length): New functions.
3888 (uniprop_decoder, uniprop_decoder_count): New variables.
3889 (uniprop_get_decoder, uniprop_encode_value_character)
3890 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3891 New functions.
3892 (uniprop_encoder, uniprop_encoder_count): New variables.
3893 (uniprop_get_encoder, uniprop_table)
3894 (Funicode_property_table_internal, Fget_unicode_property_internal)
3895 (Fput_unicode_property_internal): New functions.
3896 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3897 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3898 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3899 char-code-property-alist.
3900
640c8776 3901 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3902 Vunicode_category_table.
3903
640c8776 3904 * font.c (font_range): Adjust for the change of
c805dec0
KH
3905 Vunicode_category_table.
3906
76b397fb
DN
39072011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3908
3909 * m/iris4d.h: Remove file, move contents ...
3910 * s/irix6-5.h: ... here.
3911
22b4128e
PE
39122011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3913
3914 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3915 * alloc.c (mark_buffer):
3916 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3917 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3918 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3919 This isn't true in general, and it's particularly not true
3920 if Emacs is configured with --with-wide-int.
3921 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3922 New macros, used in the buffer.c change.
3923
869795d6
JD
39242011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3925
3926 * xsettings.c: Use both GConf and GSettings if both are available.
3927 (store_config_changed_event): Add comment.
3928 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3929 (store_tool_bar_style_changed): New functions.
5e617bc2 3930 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3931 (struct xsettings): Move font inside HAVE_XFT.
3932 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3933 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3934 Move inside HAVE_XFT.
640c8776 3935 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3936 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3937 also.
3938 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3939 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3940 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3941 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3942 (parse_settings): Move check for font inside HAVE_XFT.
3943 (read_settings, apply_xft_settings): Add comment.
3944 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3945 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3946 call store_font_name_changed.
3947 (xft_settings_event): Add comment.
3948 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3949 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3950 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3951 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3952 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3953 (xsettings_get_system_font, xsettings_get_system_normal_font):
3954 Add comment.
869795d6 3955
d8ed26bd
PE
39562011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Random fixes. E.g., (random) never returned negative values.
3959 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3960 subseconds part to the entropy, as that's a bit more random.
3961 Prefer signed to unsigned, since the signedness doesn't matter and
3962 in general we prefer signed. When given a limit, use a
3963 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3964 latter isn't right if USE_2_TAGS_FOR_INTS.
3965 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3966 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3967
cabf1cac
SM
39682011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3969
3970 * textprop.c (text_property_stickiness):
3971 Obey Vtext_property_default_nonsticky.
3972 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3973 * w32fns.c (syms_of_w32fns):
3974 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3975
6e9b2be9
PE
39762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3977
3978 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3979 This is more efficient than Ffile_directory_p and avoids a minor race.
3980
90186c68
LMI
39812011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3982
7c301272
LMI
3983 * buffer.c (Foverlay_put): Say what the return value is
3984 (bug#7835).
3985
c4f2d8d4
LMI
3986 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3987 is a directory before asking whether to use the file name
3988 (bug#7564).
ad637907
LMI
3989 (barf_or_query_if_file_exists): Make the "File is a directory"
3990 error be more correct.
c4f2d8d4 3991
90186c68
LMI
3992 * fns.c (Frequire): Remove the mention of the .gz files, since
3993 that's installation-specific, but keep the mention of
3994 `get-load-suffixes'.
3995
da64016e
PE
39962011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3999 Report string overflow if the output is too long.
4000
7d47b580
JB
40012011-07-04 Juanma Barranquero <lekktu@gmail.com>
4002
a555cb87
JB
4003 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4004 (syms_of_gnutls): Remove duplicate DEFSYM for
4005 Qgnutls_bootprop_verify_hostname_error, an error for
4006 Qgnutls_bootprop_verify_error (which is no longer used).
4007
7d47b580
JB
4008 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4009 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4010 Also (re)move comments that are misplaced or no longer relevant.
4011
1e49bfab
LMI
40122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4013
4014 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4015
1485f4c0
CY
40162011-07-03 Chong Yidong <cyd@stupidchicken.com>
4017
4018 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4019 and background color parameters if they have been changed.
4020
a9ab721e
LMI
40212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4022
4023 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4024
cf7cff57
PE
40252011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4026
2e13213d
PE
4027 * xsettings.c (SYSTEM_FONT): Define only when used.
4028 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4029
cf7cff57
PE
4030 * keymap.c (access_keymap_1): Now static.
4031
7a8e04f7
CY
40322011-07-02 Chong Yidong <cyd@stupidchicken.com>
4033
4034 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4035 leave any prefix arg for the up event (Bug#1586).
4036
61352f62
LMI
40372011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4038
69bb1ef7
LMI
4039 * lread.c (syms_of_lread): Mention single symbols defined by
4040 `defvar' or `defconst' (bug#7154).
4041
61352f62 4042 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4043 (Frequire): Mention get-load-suffixes.
61352f62 4044
28545e04
MR
40452011-07-02 Martin Rudalics <rudalics@gmx.at>
4046
4047 * window.h (window): Remove clone_number slot.
4048 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4049 Remove.
4050 (make_parent_window, make_window, saved_window)
4051 (Fset_window_configuration, save_window_save): Don't deal with
4052 clone numbers.
4053 * buffer.c (Qclone_number): Remove declaration.
4054 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4055
3349e122
SM
40562011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4057
4058 Add multiple inheritance to keymaps.
4059 * keymap.c (Fmake_composed_keymap): New function.
4060 (Fset_keymap_parent): Simplify.
4061 (fix_submap_inheritance): Remove.
4062 (access_keymap_1): New function extracted from access_keymap to handle
4063 embedded parents and handle lists of maps.
4064 (access_keymap): Use it.
4065 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4066 (Fcopy_keymap): Handle embedded parents.
4067 (Fcommand_remapping, define_as_prefix): Simplify.
4068 (Fkey_binding): Simplify.
4069 (syms_of_keymap): Move minibuffer-local-completion-map,
4070 minibuffer-local-filename-completion-map,
4071 minibuffer-local-must-match-map, and
4072 minibuffer-local-filename-must-match-map to Elisp.
4073 (syms_of_keymap): Defsubr make-composed-keymap.
4074 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4075 (parse_menu_item): Trivial simplification.
4076
3279eb87
GM
40772011-07-01 Glenn Morris <rgm@gnu.org>
4078
4079 * Makefile.in (SETTINGS_LIBS): Fix typo.
4080
4550efdf
KI
40812011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4082
4083 * coding.c (Fencode_coding_string): Record the last coding system
4084 used, as the function doc string says (bug#8738).
4085
0949d2b6
JD
40862011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4087
4088 * xsettings.c (store_monospaced_changed): Take new font as arg and
4089 check for change against current_mono_font.
4090 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4091 (emacs_settings_constructor, emacs_settings_get_property)
4092 (emacs_settings_set_property, emacs_settings_class_init)
4093 (emacs_settings_init, gsettings_obj): Remove.
4094 (something_changedCB): New function for HAVE_GSETTINGS.
4095 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4096 with value as argument.
4097 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4098 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4099 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4100 "changed".
4101
4102 * xgselect.c: Add defined (HAVE_GSETTINGS).
4103 (xgselect_initialize): Ditto.
4104
4105 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4106 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4107 xg_select.
4108
bbc6b304
PE
41092011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 * eval.c (struct backtrace): Simplify and port the data structure.
4112 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4113 signed bit field, as this assumption is not portable and it makes
4114 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4115 "char debug_on_exit : 1" as this is not portable either; instead,
4116 use the portable "unsigned int debug_on_exit : 1". Remove unused
4117 member evalargs. Remove obsolete comments about cc bombing out.
4118
9851bfc5
JD
41192011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4120
51bb811f 4121 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4122 Let HAVE_GSETTINGS override HAVE_GCONF.
4123 (store_monospaced_changed): New function.
4124 (EMACS_SETTINGS): A new type derived from GObject to handle
4125 GSettings notifications.
4126 (emacs_settings_constructor, emacs_settings_get_property)
4127 (emacs_settings_set_property, emacs_settings_class_init):
4128 New functions.
4129 (gsettings_client, gsettings_obj): New variables.
4130 (GSETTINGS_SCHEMA): New define.
4131 (something_changedCB): Call store_monospaced_changed.
4132 (init_gsettings): New function.
4133 (xsettings_initialize): Call init_gsettings.
4134 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4135 to NULL.
4136
640c8776 4137 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4138 GCONF_CFLAGS/LIBS.
4139
5386012d
MR
41402011-06-29 Martin Rudalics <rudalics@gmx.at>
4141
4142 * window.c (resize_root_window, grow_mini_window)
4143 (shrink_mini_window): Rename Qresize_root_window to
4144 Qwindow_resize_root_window and Qresize_root_window_vertically to
4145 Qwindow_resize_root_window_vertically.
4146
f13e0b08
PE
41472011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4148
4149 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4150
94515237
JB
41512011-06-27 Juanma Barranquero <lekktu@gmail.com>
4152
4153 * makefile.w32-in: Redesign dependencies so they reflect more
4154 clearly which files are directly included by each source file,
4155 and not through other includes.
4156
e43b6e43
MR
41572011-06-27 Martin Rudalics <rudalics@gmx.at>
4158
4159 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4160 (sort_overlays, overlay_strings): When an overlay's clone number
4161 matches the window's clone number process the overlay even if
4162 the overlay's window property doesn't match the current window.
4163
d68443dc
MR
4164 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4165 (Fwindow_hchild): Rename to Fwindow_left_child.
4166 (Fwindow_next): Rename to Fwindow_next_sibling.
4167 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4168 (resize_window_check): Rename to window_resize_check.
4169 (resize_window_apply): Rename to window_resize_apply.
4170 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4171 (Fdelete_other_windows_internal, resize_frame_windows)
4172 (Fsplit_window_internal, Fdelete_window_internal)
4173 (grow_mini_window, shrink_mini_window)
4174 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4175
c7e73be5
JD
41762011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4177
4178 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4179 (emacs_fixed_set_min_size): Remove.
4180 (emacs_fixed_new): Take frame as argument.
4181
4182 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4183 (_EmacsFixedPrivate): Remove minwidth/height.
4184 Add struct frame *f.
4185 (emacs_fixed_init): Initialize priv->f.
4186 (get_parent_class, emacs_fixed_set_min_size): Remove.
4187 (emacs_fixed_new): Set priv->f to argument.
4188 (emacs_fixed_get_preferred_width)
4189 (emacs_fixed_get_preferred_height): Use min_width/height from
4190 frames size_hint to set minimum and natural (Bug#8919).
4191 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4192 and use min_width/height from frames size_hint to set
4193 min_width/height (Bug#8919).
4194
4195 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4196 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4197 Fix indentation.
c7e73be5 4198
cf99dcf8
EZ
41992011-06-26 Eli Zaretskii <eliz@gnu.org>
4200
4201 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4202 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4203 called at ZV.
4204
029529ac
CY
42052011-06-26 Chong Yidong <cyd@stupidchicken.com>
4206
4207 * process.c (wait_reading_process_output): Bypass select if
4208 waiting for a cell while ignoring keyboard input, and input is
4209 pending. Suggested by Jan Djärv (Bug#8869).
4210
7a7ef429
PE
42112011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 Use gnulib's dup2 module instead of rolling our own.
4214 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4215
11fdef7d 42162011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4217
4218 * dispnew.c (scrolling_window): Before scrolling, turn off a
4219 mouse-highlight in the window being scrolled.
4220
cd3520a4
JB
42212011-06-24 Juanma Barranquero <lekktu@gmail.com>
4222
4223 Move DEFSYM to lisp.h and use everywhere.
4224
4225 * character.h (DEFSYM): Move declaration...
4226 * lisp.h (DEFSYM): ...here.
4227
4228 * gnutls.c:
4229 * minibuf.c:
4230 * w32menu.c:
4231 * w32proc.c:
4232 * w32select.c: Don't include character.h.
4233
4234 * alloc.c (syms_of_alloc):
4235 * buffer.c (syms_of_buffer):
4236 * bytecode.c (syms_of_bytecode):
4237 * callint.c (syms_of_callint):
4238 * casefiddle.c (syms_of_casefiddle):
4239 * casetab.c (init_casetab_once):
4240 * category.c (init_category_once, syms_of_category):
4241 * ccl.c (syms_of_ccl):
4242 * cmds.c (syms_of_cmds):
4243 * composite.c (syms_of_composite):
4244 * dbusbind.c (syms_of_dbusbind):
4245 * dired.c (syms_of_dired):
4246 * dispnew.c (syms_of_display):
4247 * doc.c (syms_of_doc):
4248 * editfns.c (syms_of_editfns):
4249 * emacs.c (syms_of_emacs):
4250 * eval.c (syms_of_eval):
4251 * fileio.c (syms_of_fileio):
4252 * fns.c (syms_of_fns):
4253 * frame.c (syms_of_frame):
4254 * fringe.c (syms_of_fringe):
4255 * insdel.c (syms_of_insdel):
4256 * keymap.c (syms_of_keymap):
4257 * lread.c (init_obarray, syms_of_lread):
4258 * macros.c (syms_of_macros):
4259 * msdos.c (syms_of_msdos):
4260 * print.c (syms_of_print):
4261 * process.c (syms_of_process):
4262 * search.c (syms_of_search):
4263 * sound.c (syms_of_sound):
4264 * syntax.c (init_syntax_once, syms_of_syntax):
4265 * terminal.c (syms_of_terminal):
4266 * textprop.c (syms_of_textprop):
4267 * undo.c (syms_of_undo):
4268 * w32.c (globals_of_w32):
4269 * window.c (syms_of_window):
4270 * xdisp.c (syms_of_xdisp):
4271 * xfaces.c (syms_of_xfaces):
4272 * xfns.c (syms_of_xfns):
4273 * xmenu.c (syms_of_xmenu):
4274 * xsettings.c (syms_of_xsettings):
4275 * xterm.c (syms_of_xterm): Use DEFSYM.
4276
4228cf16
TZ
42772011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4278
cd3520a4 4279 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4280
7fcccf1e
PE
42812011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4282
7efb4e0e
PE
4283 Integer and buffer overflow fixes (Bug#8873).
4284
ff5844ad
PE
4285 * print.c (printchar, strout): Check for string overflow.
4286 (PRINTPREPARE, printchar, strout):
4287 Don't set size unless allocation succeeds.
4288
90532f02
PE
4289 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4290 for sizes. Check for string overflow more accurately.
4291 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4292
6d84508d
PE
4293 * macros.c: Integer and buffer overflow fixes.
4294 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4295 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4296 Use ptrdiff_t, not int, for sizes.
4297 Don't increment bufsize until after realloc succeeds.
4298 Check for size-calculation overflow.
4299 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4300
437b2cb4
PE
4301 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4302
8b9ac8b4
PE
4303 * lread.c: Integer overflow fixes.
4304 (read_integer): Radix is now EMACS_INT, not int,
4305 to improve quality of diagnostics for out-of-range radices.
4306 Calculate buffer size correctly for out-of-range radices.
4307 (read1): Check for integer overflow in radices, and in
4308 read-circle numbers.
82cb60d3
PE
4309 (read_escape): Avoid int overflow.
4310 (Fload, openp, read_buffer_size, read1)
4311 (substitute_object_recurse, read_vector, read_list, map_obarray):
4312 Use ptrdiff_t, not int, for sizes.
4313 (read1): Use EMACS_INT, not int, for sizes.
20270765 4314 Check for size overflow.
8b9ac8b4 4315
7fcccf1e
PE
4316 * image.c (cache_image): Check for size arithmetic overflow.
4317
bfbbd7e7
PE
4318 * lread.c: Integer overflow issues.
4319 (saved_doc_string_size, saved_doc_string_length)
4320 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4321 Now ptrdiff_t, not int.
4322 (read1): Don't assume doc string length fits in int. Check for
4323 out-of-range doc string lengths.
4324 (read_list): Don't assume file position fits in int.
39019e54 4325 (read_escape): Check for hex character overflow.
bfbbd7e7 4326
4e323265
LL
43272011-06-22 Leo Liu <sdl.web@gmail.com>
4328
4329 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4330 Move to minibuffer.el.
4331
85fece3e
PE
43322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4333
20b84ce9 4334 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4335 The following patches are for when GLYPH_DEBUG && !XASSERT.
4336 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4337 * dispnew.c (flush_stdout):
4338 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4339 Mark as externally visible.
4340 * dispnew.c (check_window_matrix_pointers): Now static.
4341 * dispnew.c (window_to_frame_vpos):
4342 * xfns.c (unwind_create_frame):
4343 * xterm.c (x_check_font): Remove unused local.
4344 * scroll.c (CHECK_BOUNDS):
4345 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4346 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4347 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4348 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4349 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4350 Now static.
4351 (debug_method_add): Use va_list and vsprintf rather than relying
4352 on undefined behavior with wrong number of arguments.
4353 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4354 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4355 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4356 since we're not interested in debugging glyphs with old libraries.
4357 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4358 GCC 4.6.0's static checking.
4359
0766b489
PE
43602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4361
31fd4b32
PE
4362 Integer overflow and signedness fixes (Bug#8873).
4363 A few related buffer overrun fixes, too.
4364
b79e8648
PE
4365 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4366
0766b489
PE
4367 * dispextern.h (struct face.stipple):
4368 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4369 (x_bitmap_mask, x_allocate_bitmap_record)
4370 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4371 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4372 (x_create_bitmap_from_xpm_data):
4373 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4374 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4375 (.bitmaps_last):
4376 * xfaces.c (load_pixmap):
4377 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4378 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4379 (.bitmaps_last, struct x_output.icon_bitmap):
4380 Use ptrdiff_t, not int, for bitmap indexes.
4381 (x_allocate_bitmap_record): Check for size overflow.
4382 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4383
b081724f
PE
4384 Use ptrdiff_t, not int, for overlay counts.
4385 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4386 * editfns.c (overlays_around, get_pos_property):
4387 * textprop.c (get_char_property_and_overlay):
4388 * xdisp.c (next_overlay_change, note_mouse_highlight):
4389 * xfaces.c (face_at_buffer_position):
21514da7
PE
4390 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4391 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4392 (Fnext_overlay_change, Fprevious_overlay_change)
4393 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4394 Use ptrdiff_t, not int, for sizes.
21514da7 4395 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4396
3de73e5e
PE
4397 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4398
2606c57b
PE
4399 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4400 (x_session_initialize): Do not assume string length fits in int.
4401
aaafe47a
PE
4402 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4403 This is unlikely, but can occur if DPI is outlandish.
4404
2674ddc8 4405 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4406 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4407
28154962
PE
4408 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4409 * xrdb.c (magic_file_p, search_magic_path):
4410 Omit last arg SUFFIX; it was always 0. All callers changed.
4411 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4412
7de51af5
PE
4413 * xfont.c (xfont_match): Avoid need for strlen.
4414
25ed6cc3
PE
4415 * xfns.c: Don't assume strlen fits in int.
4416 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4417
4eab31dd
PE
4418 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4419 not unsigned long, as we prefer signed integers. All callers changed.
4420 Detect integer overflow in repeat count.
4421 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4422 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4423
171e2a58
PE
4424 * termcap.c: Don't assume sizes fit in int and never overflow.
4425 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4426 (gobble_line): Check for size-calculation overflow.
4427
ad39faca 4428 * minibuf.c (Fread_buffer):
6e5bb2dc 4429 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4430 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4431 Don't assume string length fits in int.
4432
52c61c22 4433 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4434 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4435
b5b8c9e5
PE
4436 * font.c: Don't assume string length fits in int.
4437 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4438 Use ptrdiff_t, not int.
ccd6111c
PE
4439 (font_intern_prop): Don't assume string length fits in int.
4440 Don't assume integer property fits in fixnum.
4441 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4442
882f0d81 4443 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4444 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4445 Reformulate so as not to need the command string.
4446 Invoke gzip -cd rather than gunzip, as it's more portable.
4447 (lock_info_type, lock_file_1, lock_file):
4448 Don't assume pid_t and time_t fit in unsigned long.
4449 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4450 (current_lock_owner): Prefer signed type for sizes.
4451 Use memcpy, not strncpy, where memcpy is what is really wanted.
4452 Don't assume (via atoi) that time_t and pid_t fit in int.
4453 Check for time_t and/or pid_t out of range, e.g., via a network share.
4454 Don't alloca where an auto var works fine.
4455
93f4cf88
PE
4456 * fileio.c: Fix some integer overflow issues.
4457 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4458 Don't assume string length fits in int.
4459 (directory_file_name): Don't assume string length fits in long.
4460 (make_temp_name): Don't assume pid fits in int, or that its print
4461 length is less than 20.
4462
f3e92b69
PE
4463 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4464
1bfdaf10
PE
4465 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4466
35016e9a
PE
4467 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4468
3d1e65a1
PE
4469 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4470 We prefer signed integers, even for size calculations.
4471
0b963a93
PE
4472 * emacs.c: Don't assume string length fits in 'int'.
4473 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4474 (main): Don't invoke strlen when not needed.
4475
573f4b54
PE
4476 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4477 (XD_DEBUG_MESSAGE): Don't waste a byte.
4478
989f33ba
PE
4479 * callproc.c (getenv_internal_1, getenv_internal)
4480 (Fgetenv_internal):
965d34eb
PE
4481 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4482
e4d29b33
PE
4483 * lread.c (invalid_syntax): Omit length argument.
4484 All uses changed. This doesn't fix a bug, but it simplifies the
4485 code away from its former Hollerith-constant appearance, and it's
4486 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4487 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4488
eb49b136
PE
4489 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4490 This didn't break anything, but it didn't help either.
4491 It's confusing to put a bogus integer in a place where the actual
4492 value does not matter.
9f62aeb1 4493 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4494 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4495
15375a22
PE
4496 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4497 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4498 implementation.
b61cc01c
PE
4499 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4500 We prefer signed types, and the value cannot exceed the EMACS_INT
4501 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4502 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4503 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4504 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4505
53b2623d
PE
4506 * indent.c (sane_tab_width): New function.
4507 (current_column, scan_for_column, Findent_to, position_indentation)
4508 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4509 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4510
51cab52b 4511 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4512
f2ed8a70
PE
4513 * lisp.h (lint_assume): New macro.
4514 * composite.c (composition_gstring_put_cache):
4515 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4516
abe80cc6
PE
4517 * editfns.c, insdel.c:
4518 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4519
b02c740e
PE
4520 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4521
ebc96716
PE
4522 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4523
b4e50fa0 4524 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4525 Use much-faster test for byte-length change.
311d5d7c 4526 Don't assume string byte-length fits in 'int'.
a4cf38e4 4527 Check that character arg fits in 'int'.
85461888 4528 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4529
c0c1ee9f
PE
4530 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4531
a498d7f4
PE
4532 * fns.c (concat): Catch string overflow earlier.
4533 Do not rely on integer wraparound.
4534
51cab52b
PE
4535 * dispextern.h (struct it.overlay_strings_charpos)
4536 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4537 * xdisp.c (forward_to_next_line_start)
4538 (back_to_previous_visible_line_start)
4539 (reseat_at_next_visible_line_start, next_element_from_buffer):
4540 Don't arbitrarily truncate the value of 'selective' to int.
4541
76031fad
PE
4542 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4543
5eb55db9
PE
4544 * composite.c: Don't truncate sizes to 'int'.
4545 (composition_gstring_p, composition_reseat_it)
4546 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4547 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4548 not EMACS_UINT, for indexes.
5eb55db9 4549
0703a717
PE
4550 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4551
d6202519
PE
4552 * buffer.c: Include <verify.h>.
4553 (struct sortvec.priority, struct sortstr.priority):
8961a454 4554 Now EMACS_INT, not int.
c20998a7 4555 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4556 (struct sortstr.size, record_overlay_string)
4557 (struct sortstrlist.size, struct sortlist.used):
4558 Don't truncate size to int.
4559 (record_overlay_string): Check for size-calculation overflow.
d6202519 4560 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4561
d5a19415
JM
45622011-06-22 Jim Meyering <meyering@redhat.com>
4563
029529ac 4564 Don't leak an XBM-image-sized buffer
d5a19415
JM
4565 * image.c (xbm_load): Free the image buffer after using it.
4566
a9041e6c
PE
45672011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 Port to Sun C.
4570 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4571 that Sun C diagnosed.
4572 * fns.c (secure_hash): Fix pointer signedness issue.
4573 * intervals.c (static_offset_intervals): New function.
4574 (offset_intervals): Use it.
4575
7f3f739f
LL
45762011-06-21 Leo Liu <sdl.web@gmail.com>
4577
4578 * deps.mk (fns.o):
4579 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4580 sha512.h.
4581
4582 * fns.c (secure_hash): Rename from crypto_hash_function and change
4583 the first arg to accept symbols.
5b66d427 4584 (Fsecure_hash): New primitive.
7f3f739f
LL
4585 (syms_of_fns): New symbols.
4586
76147d94
DD
45872011-06-20 Deniz Dogan <deniz@dogan.se>
4588
4589 * process.c (Fset_process_buffer): Clarify return value in
4590 docstring.
4591
7d7d0045
CY
45922011-06-18 Chong Yidong <cyd@stupidchicken.com>
4593
4594 * dispnew.c (add_window_display_history): Use BVAR.
4595
4596 * xdisp.c (debug_method_add): Use BVAR.
4597 (check_window_end, dump_glyph_matrix, dump_glyph)
4598 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4599
4600 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4601 Likewise.
4602
4603 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4604 check till after the cache is created in init_frame_faces.
4605
ff2bc410
SM
46062011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4607
4608 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4609
28177add
PE
46102011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4611
dd3482fe
PE
4612 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4613 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4614 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4615
393d71f3 4616 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4617 * fileio.c (Finsert_file_contents):
4618 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4619 Remove the old (too-loose) buffer overflow checks.
4620 They weren't needed, since make_gap checks for buffer overflow.
4621 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4622 The old code merely checked for Emacs fixnum overflow, and relied
4623 on undefined (wraparound) behavior. The new code avoids undefined
4624 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4625
2e6813b0 4626 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4627 Tune. Don't use wider integers than needed. Don't use alloca.
4628 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4629
599a9e4f
PE
4630 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4631
99561444
PE
4632 * insdel.c, lisp.h (buffer_overflow): New function.
4633 (insert_from_buffer_1, replace_range, replace_range_2):
4634 * insdel.c (make_gap_larger):
4635 * editfns.c (Finsert_char):
4636 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4637
28177add
PE
4638 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4639
e69dafad
PE
46402011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4641
4baa020d 4642 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4643
b1c46f02
PE
4644 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4645 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4646
e69dafad
PE
4647 * fileio.c: Don't assume EMACS_INT fits in off_t.
4648 (emacs_lseek): New static function.
4649 (Finsert_file_contents, Fwrite_region): Use it.
4650 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4651
566684ea
PE
4652 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4653
e6966cd6
PE
4654 * fns.c: Don't overflow int when computing a list length.
4655 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4656 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4657 truncation on 64-bit hosts. Check for QUIT every
4658 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4659 faster and is responsive enough.
4660 (Flength): Report an error instead of overflowing an integer.
4661 (Fsafe_length): Return a float if the value is not representable
4662 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4663 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4664 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4665
dd0b0efb
PE
4666 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4667 (header_size, word_size): New constants.
4668 (allocate_vectorlike): Don't check size overflow here.
4669 (allocate_vector): Check it here instead, since this is the only
4670 caller of allocate_vectorlike that could cause overflow.
4671 Check that the new vector's length is representable as a fixnum.
4672
86fe5cfe
PE
4673 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4674 The previous code was bogus. For example, next_almost_prime (32)
4675 returned 39, which is undesirable as it is a multiple of 3; and
4676 next_almost_prime (24) returned 25, which is a multiple of 5 so
4677 why was the code bothering to check for multiples of 7?
4678
80e88859
PE
4679 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4680
4a2f0ad6
PE
4681 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4682
f66c7cf8
PE
4683 Variadic C functions now count arguments with ptrdiff_t.
4684 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4685 Back then I didn't know that the Emacs coding style prefers signed int.
4686 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4687 were being counted with int, which may truncate counts on 64-bit
4688 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4689 * lisp.h (struct Lisp_Subr.function.aMANY)
4690 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4691 Arg counts are now ptrdiff_t, not size_t.
4692 All variadic functions and their callers changed accordingly.
4693 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4694 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4695 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4696 * callint.c (Fcall_interactively): Check arg count for overflow,
4697 to avoid potential buffer overrun. Use signed char, not 'int',
4698 for 'varies' array, so that we needn't bother to check its size
4699 calculation for overflow.
4700 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4701 * eval.c (apply_lambda):
4702 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4703 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4704 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4705
a1759b76
PE
4706 * callint.c (Fcall_interactively): Don't use index var as event count.
4707
d96be9fc
PE
4708 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4709 * mem-limits.h (SIZE): Remove; no longer used.
4710
a690a978 4711 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4712
578c21e6
PE
4713 Remove unnecessary casts.
4714 * xterm.c (x_term_init):
4715 * xfns.c (x_set_border_pixel):
4716 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4717 These aren't needed now that we assume ANSI C.
4718
96f53c6c
PE
4719 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4720 It's more likely to cause problems (due to unsigned overflow)
4721 than to cure them.
4722
83c77d31
PE
4723 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4724
ee2079f1
PE
4725 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4726
6da65536
PE
4727 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4728
7147c4a4
PE
4729 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4730
193e32d9
PE
4731 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4732
e5533da6
PE
4733 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4734
9910e595
PE
4735 GLYPH_CODE_FACE returns EMACS_INT, not int.
4736 * dispextern.h (merge_faces):
4737 * xfaces.c (merge_faces):
01103c44
PE
4738 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4739 Don't assume EMACS_INT fits in int.
9910e595 4740
2638320e
PE
4741 * character.h (CHAR_VALID_P): Remove unused parameter.
4742 * fontset.c, lisp.h, xdisp.c: All uses changed.
4743
045eb8d9
PE
4744 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4745
c1f134b5
PE
4746 * fns.c (concat): Minor tuning based on overflow analysis.
4747 This doesn't fix any bugs. Use int to hold character, instead
4748 of constantly refetching from Emacs object. Use XFASTINT, not
4749 XINT, for value known to be a character. Don't bother comparing
4750 a single byte to 0400, as it's always less.
4751
395fcb93 4752 * floatfns.c (Fexpt):
327eeec8
PE
4753 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4754
abbd3d23
PE
4755 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4756 for characters.
4757
684a03ef
PE
4758 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4759
0fed43f3
PE
4760 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4761 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4762 incorrectly succeed when S was a string, because 4294967386 was
4763 truncated before it was used.
4764
8fd02eb7
PE
4765 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4766 Otherwise, an out-of-range integer could cause undefined behavior
4767 on a 64-bit host.
4768
f8c86b69
PE
4769 * composite.c: Use int, not EMACS_INT, for characters.
4770 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4771 EMACS_INT, for values that are known to be in character range.
4772 This doesn't fix any bugs but is the usual style inside Emacs and
4773 may generate better code on 32-bit machines.
4774
34206dd2
PE
4775 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4776 This is for reasons similar to the recent CHAR_STRING fix.
4777 * charset.c (Fencode_char): Check that character arg is actually
4778 a character. Pass an int to ENCODE_CHAR.
4779 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4780 wider than 'int', as a compile-time check to prevent future regressions
4781 in this area.
4782
c5958d4c 4783 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4784
4785 Make sure a 64-bit char is never passed to CHAR_STRING.
4786 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4787 by silently ignoring the top 32 bits, allowing some values
4788 that were far too large to be valid characters.
4789 * character.h: Include <verify.h>.
4790 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4791 arguments are no wider than unsigned, as a compile-time check
4792 to prevent future regressions in this area.
4793 * data.c (Faset):
01103c44 4794 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4795 (Fsubst_char_in_region):
4796 * fns.c (concat):
4797 * xdisp.c (decode_mode_spec_coding):
4798 Adjust to CHAR_STRING's new requirement.
4799 * editfns.c (Finsert_char, Fsubst_char_in_region):
4800 * fns.c (concat): Check that character args are actually
4801 characters. Without this test, these functions did the wrong
4802 thing with wildly out-of-range values on 64-bit hosts.
4803
d37ca623
PE
4804 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4805 These casts should not be needed on 32-bit hosts, either.
4806 * keyboard.c (read_char):
4807 * lread.c (Fload): Remove casts to unsigned.
4808
ea204efb
PE
4809 * lisp.h (UNSIGNED_CMP): New macro.
4810 This fixes comparison bugs on 64-bit hosts.
4811 (ASCII_CHAR_P): Use it.
4812 * casefiddle.c (casify_object):
01103c44 4813 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4814 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4815 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4816 * dispextern.h (FACE_FROM_ID):
4817 * keyboard.c (read_char): Use UNSIGNED_CMP.
4818
41cb286c
PE
4819 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4820 not to EMACS_INT, to avoid GCC warning.
4821
4a1b9832
PE
4822 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4823
55daad71
PE
4824 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4825 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4826 isn't needed on 32-bit machines.
8f95c75c 4827
01103c44
PE
4828 * buffer.c (Fgenerate_new_buffer_name):
4829 Use EMACS_INT for count, not int.
0ceccced 4830 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4831
4832 * data.c (Qcompiled_function): Now static.
4833
c6f072e7
PE
4834 * window.c (window_body_lines): Now static.
4835
20ce5912
PE
4836 * image.c (gif_load): Rename local to avoid shadowing.
4837
9c4c5f81
PE
4838 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4839 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4840 * alloc.c (make_save_value): Integer argument is now of type
4841 ptrdiff_t, not int.
4842 (mark_object): Use ptrdiff_t, not int.
4843 * lisp.h (pD): New macro.
4844 * print.c (print_object): Use it.
4845
c0c5c8ae
PE
4846 * alloc.c: Use EMACS_INT, not int, to count objects.
4847 (total_conses, total_markers, total_symbols, total_vector_size)
4848 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4849 (total_free_floats, total_floats, total_free_intervals)
4850 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4851 Now EMACS_INT, not int. All uses changed.
4852 (Fgarbage_collect): Compute overall total using a double, so that
4853 integer overflow is less likely to be a problem. Check for overflow
4854 when converting back to an integer.
5a25e253
PE
4855 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4856 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4857 These were 'int' variables that could overflow on 64-bit hosts;
4858 they were never used, so remove them instead of repairing them.
211a0b2a 4859 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4860 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4861 Previously, this ceilinged at INT_MAX, but that doesn't work on
4862 64-bit machines.
e46bb31a 4863 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4864
c78baabf 4865 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4866 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4867 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4868 when a (possibly-narrower) signed value would do just as well.
4869 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4870
c9d624c6
PE
4871 * alloc.c: Catch some string size overflows that we were missing.
4872 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4873 for convenience in STRING_BYTES_MAX.
4874 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4875 The definition here is exact; the one in lisp.h was approximate.
4876 (allocate_string_data): Check for string overflow. This catches
4877 some instances we weren't catching before. Also, it catches
4878 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4879 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4880 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4881
c9d624c6
PE
4882 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4883 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4884 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4885
353032ce
PE
4886 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4887
2bccce07
PE
4888 * alloc.c (Fmake_string): Check for out-of-range init.
4889
0ac30604
SM
48902011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4891
4892 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4893
c195f2de
JD
48942011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4895
4896 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4897 xg_get_default_scrollbar_width.
4898
4899 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4900 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4901 (style_changed_cb): Call update_theme_scrollbar_width and call
4902 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4903 all frames (Bug#8505).
4904 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4905 Call gtk_window_set_resizable if HAVE_GTK3.
4906 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4907 and height if HAVE_GTK3 (Bug#8505).
4908 (scroll_bar_width_for_theme): New variable.
4909 (update_theme_scrollbar_width): New function.
4910 (xg_get_default_scrollbar_width): Move code to
4911 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4912 (xg_initialize): Call update_theme_scrollbar_width.
4913
4914 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4915
4916 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4917
e10ac9f1
MR
49182011-06-12 Martin Rudalics <rudalics@gmx.at>
4919
4920 * frame.c (make_frame): Call other_buffer_safely instead of
4921 other_buffer.
4922
4923 * window.c (temp_output_buffer_show): Call display_buffer with
4924 second argument Vtemp_buffer_show_specifiers and reset latter
4925 immediately after the call.
4926 (Vtemp_buffer_show_specifiers): New variable.
4927 (auto_window_vscroll_p, next_screen_context_lines)
4928 (Vscroll_preserve_screen_position): Remove leading asterisks from
4929 doc-strings.
4930
2d3c217e 49312011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4932
7b7f97e8 4933 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4934 * buffer.c (Qclone_number): Remove for now, as it's unused.
4935 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4936 (record_buffer): Remove unused local.
4937 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4938 (set_frame_buffer_list): Remove; unused.
4939 * frame.h (other_visible_frames): Remove decl.
4940 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4941 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4942 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4943 if HAVE_GPM.
4944 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4945 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4946 Define only if HAVE_GPM.
4947 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4948 (update_hints_inhibit): Remove; never set. All uses removed.
4949 * widgetprv.h (emacsFrameClassRec): Remove decl.
4950 * window.c (delete_deletable_window): Now returns void, since it
4951 wasn't returning anything.
4952 (compare_window_configurations): Remove unused locals.
4953 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4954 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4955 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4956 the same widths as pointers. This follows up on the 2011-05-06 patch.
4957 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4958 * xterm.h: Likewise.
4959 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4960
1384b89e
JB
49612011-06-12 Juanma Barranquero <lekktu@gmail.com>
4962
4963 * makefile.w32-in: Update dependencies.
4964 (LISP_H): Add lib/intprops.h.
4965
1100a63c
CY
49662011-06-11 Chong Yidong <cyd@stupidchicken.com>
4967
4968 * image.c (gif_load): Add animation frame delay to the metadata.
4969 (syms_of_image): Use DEFSYM. New symbol `delay'.
4970
6198ccd0
MR
49712011-06-11 Martin Rudalics <rudalics@gmx.at>
4972
4973 * window.c (delete_deletable_window): Re-add.
4974 (Fset_window_configuration): Rewrite to handle dead buffers and
4975 consequently deletable windows.
4976 (window_tree, Fwindow_tree): Remove. Supply functionality in
4977 window.el.
4978 (compare_window_configurations): Simplify code.
4979
b6e3633c
AS
49802011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4981
1ab0dee5
AS
4982 * image.c (imagemagick_load_image): Fix type mismatch.
4983 (Fimagemagick_types): Likewise.
4984
b6e3633c
AS
4985 * window.h (replace_buffer_in_windows): Declare.
4986
9397e56f
MR
49872011-06-11 Martin Rudalics <rudalics@gmx.at>
4988
4989 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4990 Qclone_number. Remove external declaration of Qdelete_window.
4991 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4992 code.
640c8776
SM
4993 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4994 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4995 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4996 buffer list implementation.
4997 (other_buffer_safely): New function.
4998 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4999 calls to replace_buffer_in_windows and
5000 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5001 if allowed.
5002 (record_buffer): Inhibit quitting and rewrite using quittable
5003 functions. Run Qbuffer_list_update_hook if allowed.
5004 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5005 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5006 Move switch-to-buffer to window.el.
9397e56f
MR
5007 (bury-buffer): Move to window.el.
5008 (Vbuffer_list_update_hook): New variable.
5009
5010 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5011 section.
5012
5013 * window.h (resize_frame_windows): Move up in code.
5014 (Fwindow_frame): Remove EXFUN.
5015 (replace_buffer_in_all_windows): Remove prototype.
5016 (replace_buffer_in_windows_safely): Add prototype.
5017
5018 * window.c: Declare Qdelete_window static again. Move down
5019 declaration of select_count.
5020 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5021 (Fother_window): Move to window.el.
5022 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5023 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5024 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5025 window.el.
5026 (replace_buffer_in_windows): Implement by calling
5027 Qreplace_buffer_in_windows.
5028 (replace_buffer_in_all_windows): Remove with some functionality
5029 moved into replace_buffer_in_windows_safely.
5030 (replace_buffer_in_windows_safely): New function.
5031 (select_window_norecord, select_frame_norecord): Move in front
5032 of run_window_configuration_change_hook. Remove now obsolete
5033 declarations.
640c8776
SM
5034 (Fset_window_buffer): Rewrite doc-string.
5035 Call Qrecord_window_buffer.
9397e56f
MR
5036 (keys_of_window): Move binding for other-window to window.el.
5037
b50691aa
CY
50382011-06-11 Chong Yidong <cyd@stupidchicken.com>
5039
5040 * dispextern.h (struct image): Replace data member, whose int_val
5041 and ptr_val fields were not used by anything, with a single
5042 lisp_val object.
5043
5044 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5045 (gif_clear_image, gif_load, imagemagick_load_image)
5046 (gs_clear_image, gs_load): Callers changed.
5047
3f754b86
PE
50482011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5049
cca69397
PE
5050 * buffer.h: Include <time.h>, for time_t.
5051 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5052
109e28d0
PE
5053 Fix minor problems found by static checking.
5054
60737f02
PE
5055 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5056
4b66faf3
PE
5057 Make identifiers static if they are not used in other modules.
5058 * data.c (Qcompiled_function, Qframe, Qvector):
5059 * image.c (QimageMagick, Qsvg):
5060 * minibuf.c (Qmetadata):
5061 * window.c (resize_window_check, resize_root_window): Now static.
5062 * window.h (resize_window_check, resize_root_window): Remove decls.
5063
109e28d0
PE
5064 * window.c (window_deletion_count, delete_deletable_window):
5065 Remove; unused.
46a4ce9e
PE
5066 (window_body_lines): Now static.
5067 (Fdelete_other_windows_internal): Mark vars as initialized.
5068 Make sure 'resize_failed' is initialized.
5069 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5070 (resize_window_apply): Remove unused local.
5071 * window.h (delete_deletable_window): Remove decl.
5072
109e28d0 5073 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5074 (imagemagick_load_image): Fix pointer signedness problem by changing
5075 last arg from unsigned char * to char *. All uses changed.
5076 Also, fix a local for similar reasons.
5077 Remove unused locals. Remove locals to avoid shadowing.
5078 (fn_rsvg_handle_free): Remove; unused.
5079 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5080 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5081
3f754b86
PE
5082 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5083
2547adb1
CY
50842011-06-10 Chong Yidong <cyd@stupidchicken.com>
5085
5086 * image.c (gif_load): Fix omitted cast error introduced by
5087 2011-06-06 change.
5088
2c8e37d4
MR
50892011-06-10 Martin Rudalics <rudalics@gmx.at>
5090
5091 * window.h (resize_proportionally, orig_total_lines)
5092 (orig_top_line): Remove from window structure.
5093 (set_window_height, set_window_width, change_window_heights)
5094 (Fdelete_window): Remove prototypes.
5095 (resize_frame_windows): Remove duplicate declaration.
5096
440a42e3
EZ
50972011-06-10 Eli Zaretskii <eliz@gnu.org>
5098
5099 * window.h (resize_frame_windows, resize_window_check)
5100 (delete_deletable_window, resize_root_window)
5101 (resize_frame_windows): Declare prototypes.
5102
5103 * window.c (resize_window_apply): Make definition be "static" to
5104 match the prototype.
5105
562dd5e9
MR
51062011-06-10 Martin Rudalics <rudalics@gmx.at>
5107
5108 * window.c: Remove declarations of Qwindow_size_fixed,
5109 window_min_size_1, window_min_size_2, window_min_size,
5110 size_window, window_fixed_size_p, enlarge_window, delete_window.
5111 Remove static from declaration of Qdelete_window, it's
5112 temporarily needed by Fbury_buffer.
5113 (replace_window): Don't assign orig_top_line and
5114 orig_total_lines.
5115 (Fdelete_window, delete_window): Remove. Window deletion is
5116 handled by window.el.
640c8776
SM
5117 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5118 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5119 (Fdelete_other_windows): Remove. Deleting other windows is
5120 handled by window.el.
5121 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5122 handled in window.el.
5123 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5124 Window minimum sizes are handled in window.el.
5125 (shrink_windows, size_window, set_window_height)
5126 (set_window_width, change_window_heights, window_height)
5127 (window_width, CURBEG, CURSIZE, enlarge_window)
5128 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5129 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5130 handled in window.el.
5131 (make_dummy_parent): Rename to make_parent_window and give it a
5132 second argument horflag.
5133 (make_window): Don't set resize_proportionally any more.
5134 (Fsplit_window): Remove. Windows are split in window.el.
5135 (save_restore_action, save_restore_orig_size)
5136 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5137 Resize mini windows in window.el.
5138 (grow_mini_window, shrink_mini_window): Implement by calling
5139 Qresize_root_window_vertically, resize_window_check and
5140 resize_window_apply.
640c8776
SM
5141 (saved_window, Fset_window_configuration, save_window_save):
5142 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5143 resize_proportionally.
5144 (window_min_height, window_min_width): Move to window.el.
5145 (keys_of_window): Move bindings for delete-other-windows,
5146 split-window, delete-window and enlarge-window to window.el.
5147
5148 * buffer.c: Temporarily extern Qdelete_window.
5149 (Fbury_buffer): Temporarily call Qdelete_window instead of
5150 Fdelete_window (Fbury_buffer will move to window.el soon).
5151
5152 * frame.c (set_menu_bar_lines_1): Remove code handling
5153 orig_top_line and orig_total_lines.
5154
5155 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5156 set_window_height but set heights directly.
5157 (change_frame_size_1): Use resize_frame_windows.
5158
5159 * xdisp.c (init_xdisp): Don't use set_window_height but set
5160 heights directly.
5161
640c8776
SM
5162 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5163 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5164 run_window_configuration_change_hook.
5165
5166 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5167 instead of change_window_heights and run
5168 run_window_configuration_change_hook.
5169
1a13852e
MR
51702011-06-09 Martin Rudalics <rudalics@gmx.at>
5171
5172 * window.c (replace_window): Rename second argument REPLACEMENT to
5173 NEW. New third argument SETFLAG. Rewrite.
5174 (delete_window, make_dummy_parent): Call replace_window with
5175 third argument 1.
5176 (window_list_1): Move down in code.
5177 (run_window_configuration_change_hook): Move set_buffer part
5178 before select_frame_norecord part in order to unwind correctly.
5179 Rename count1 to count.
5180 (recombine_windows, delete_deletable_window, resize_root_window)
5181 (Fdelete_other_windows_internal)
5182 (Frun_window_configuration_change_hook, make_parent_window)
5183 (resize_window_check, resize_window_apply, Fresize_window_apply)
5184 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5185 (Fdelete_window_internal, Fresize_mini_window_internal):
5186 New functions.
1a13852e
MR
5187 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5188
f3d1777e
MR
51892011-06-08 Martin Rudalics <rudalics@gmx.at>
5190
496e208e
MR
5191 * window.h (window): Add some new members to window structure -
5192 normal_lines, normal_cols, new_total, new_normal, clone_number,
5193 splits, nest, prev_buffers, next_buffers.
5194 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5195 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5196
f3d1777e
MR
5197 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5198 Remove.
496e208e
MR
5199 (make_dummy_parent): Set new members of windows structure.
5200 (make_window): Move down in code. Handle new members of window
5201 structure.
5202 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5203 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5204 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5205 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5206 (Fset_window_next_buffers, Fset_window_clone_number):
5207 New functions.
496e208e
MR
5208 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5209 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5210 Doc-string fixes.
5211 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5212 Argument WINDOW can be now internal window too.
5213 (Fwindow_use_time): Move up in code.
5214 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5215 Rewrite doc-string.
5216 (Fset_window_configuration, saved_window)
5217 (Fcurrent_window_configuration, save_window_save): Handle new
5218 members of window structure.
b9e809c2
MR
5219 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5220 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5221 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5222 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5223 Qget_mru_window, Qresize_root_window,
5224 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5225 Qauto_buffer_name; staticpro them.
f3d1777e 5226
abde8f8c
MR
52272011-06-07 Martin Rudalics <rudalics@gmx.at>
5228
5229 * window.c (Fwindow_total_size, Fwindow_left_column)
5230 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5231 (Fwindow_list_1): New functions.
5232 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5233 (Fwindow_width, Fscroll_left, Fscroll_right):
5234 Use window_body_cols instead of window_box_text_cols.
5235 (delete_window, Fset_window_configuration):
5236 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5237 (delete_all_subwindows): Take a window as argument and not a
5238 structure. Rewrite.
190b47e6
MR
5239 (window_loop): Remove handling of GET_LRU_WINDOW and
5240 GET_LARGEST_WINDOW.
5241 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5242
5243 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5244 window_box_text_cols. delete_all_subwindows now takes a
5245 Lisp_Object as argument.
abde8f8c 5246
640c8776
SM
5247 * indent.c (compute_motion, Fcompute_motion):
5248 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5249
fa8a67e6
MR
5250 * frame.c (delete_frame): Call delete_all_subwindows with root
5251 window as argument.
5252
a54e3482
DC
52532011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5254
5255 * fns.c (Fputhash): Document return value.
5256
60002bf5
CY
52572011-06-06 Chong Yidong <cyd@stupidchicken.com>
5258
5259 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5260
0c671da6 52612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5262
b862a52a 5263 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5264
be44ca6c
PE
5265 Check for overflow when converting integer to cons and back.
5266 * charset.c (Fdefine_charset_internal, Fdecode_char):
5267 Use cons_to_unsigned to catch overflow.
5268 (Fencode_char): Use INTEGER_TO_CONS.
5269 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5270 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5271 * data.c (long_to_cons, cons_to_long): Remove.
5272 (cons_to_unsigned, cons_to_signed): New functions.
5273 These signal an error for invalid or out-of-range values.
5274 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5275 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5276 * font.c (Ffont_variation_glyphs):
5277 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5278 * lisp.h: Include <intprops.h>.
5279 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5280 (cons_to_signed, cons_to_unsigned): New decls.
5281 (long_to_cons, cons_to_long): Remove decls.
5282 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5283 (Fprimitive_undo): Use CONS_TO_INTEGER.
5284 * xfns.c (Fx_window_property): Likewise.
5285 * xselect.c: Include <limits.h>.
5286 (x_own_selection, selection_data_to_lisp_data):
5287 Use INTEGER_TO_CONS.
5288 (x_handle_selection_request, x_handle_selection_clear)
5289 (x_get_foreign_selection, Fx_disown_selection_internal)
5290 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5291 (lisp_data_to_selection_data): Use cons_to_unsigned.
5292 (x_fill_property_data): Use cons_to_signed.
5293 Report values out of range.
5294
d1f3d2af
PE
5295 Check for buffer and string overflow more precisely.
5296 * buffer.h (BUF_BYTES_MAX): New macro.
5297 * lisp.h (STRING_BYTES_MAX): New macro.
5298 * alloc.c (Fmake_string):
5299 * character.c (string_escape_byte8):
5300 * coding.c (coding_alloc_by_realloc):
5301 * doprnt.c (doprnt):
5302 * editfns.c (Fformat):
5303 * eval.c (verror):
5304 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5305 since they may not be the same number.
5306 * editfns.c (Finsert_char):
5307 * fileio.c (Finsert_file_contents):
5308 Likewise for BUF_BYTES_MAX.
5309
dd52fcea
PE
5310 * image.c: Use ptrdiff_t, not int, for sizes.
5311 (slurp_file): Switch from int to ptrdiff_t.
5312 All uses changed.
5313 (slurp_file): Check that file size fits in both size_t (for
5314 malloc) and ptrdiff_t (for sanity and safety).
5315
7f9bbdbb
PE
5316 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5317 if b->modtime has its maximal value.
5318
dfe18f82
PE
5319 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5320
84acfcf0
PE
5321 Don't assume time_t can fit into int.
5322 * buffer.h (struct buffer.modtime): Now time_t, not int.
5323 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5324 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5325
ccd9a01a
PE
5326 Minor fixes for signed vs unsigned integers.
5327 * character.h (MAYBE_UNIFY_CHAR):
5328 * charset.c (maybe_unify_char):
5329 * keyboard.c (read_char, reorder_modifiers):
5330 XINT -> XFASTINT, since the integer must be nonnegative.
5331 * ftfont.c (ftfont_spec_pattern):
5332 * keymap.c (access_keymap, silly_event_symbol_error):
5333 XUINT -> XFASTINT, since the integer must be nonnegative.
5334 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5335 since it makes no difference and we prefer signed.
5336 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5337 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5338 nonnegative.
5339
d6d100dd
SM
53402011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5341
5342 * window.h (Fwindow_frame): Declare.
5343
2b6148e4
PE
53442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5345
5346 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5347 (SPARE_MEMORY): Always define.
5348 (LARGE_REQUEST): Remove.
5349 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5350
f230ecc9
MR
53512011-06-06 Martin Rudalics <rudalics@gmx.at>
5352
727e958e
MR
5353 * lisp.h: Move EXFUNS for Fframe_root_window,
5354 Fframe_first_window and Fset_frame_selected_window to window.h.
5355
5356 * window.h: Move EXFUNS for Fframe_root_window,
5357 Fframe_first_window and Fset_frame_selected_window here from
5358 lisp.h.
5359
5360 * frame.c (Fwindow_frame, Fframe_first_window)
5361 (Fframe_root_window, Fframe_selected_window)
5362 (Fset_frame_selected_window): Move to window.c.
5363 (Factive_minibuffer_window): Move to minibuf.c.
5364 (Fother_visible_frames_p): New function.
5365
5366 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5367
f230ecc9
MR
5368 * window.c (decode_window, decode_any_window): Move up in code.
5369 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5370 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5371 (Fwindow_buffer): Move up and rewrite doc-string.
5372 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5373 (Fwindow_prev): New functions.
727e958e
MR
5374 (Fwindow_frame): Move here from frame.c. Accept any window as
5375 argument.
5376 (Fframe_root_window, Fframe_first_window)
5377 (Fframe_selected_window): Move here from frame.c. Accept frame
5378 or arbitrary window as argument. Update doc-strings.
5379 (Fminibuffer_window): Move up in code.
5380 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5381 (Fset_frame_selected_window): Move here from frame.c.
5382 Marginal rewrite.
727e958e
MR
5383 (Fselected_window, select_window, Fselect_window): Move up in
5384 code. Minor doc-string fixes.
f230ecc9 5385
4d09bcf6
PE
53862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5387
5388 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5389 Do not assume that spare memory exists; that assumption is valid
5390 only if SYSTEM_MALLOC.
5391 (LARGE_REQUEST): New macro, so that the issue of large requests
5392 is separated from the issue of spare memory.
5393
810928a2
AS
53942011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5395
172418ad
AS
5396 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5397 format. (Bug#8806)
5398
43f862f7
AS
5399 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5400
810928a2
AS
5401 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5402 before statements.
5403
a059fe24
JD
54042011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5405
5406 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5407
5408 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5409
5410 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5411 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5412
989bf368
JB
54132011-06-05 Juanma Barranquero <lekktu@gmail.com>
5414
5415 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5416
4b80f674
CY
54172011-06-04 Chong Yidong <cyd@stupidchicken.com>
5418
5419 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5420 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5421 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5422 New error handlers.
4b80f674
CY
5423 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5424 Obey Vx_select_enable_clipboard_manager. Catch errors in
5425 x_clipboard_manager_save (Bug#8779).
5426 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5427 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5428
99a33b77 54292011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5430
5431 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5432
99a33b77 54332011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5434
5435 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5436 in the current matrix if keep_current_p is non-zero.
5437
8264569d
EZ
54382011-06-04 Eli Zaretskii <eliz@gnu.org>
5439
5440 * bidi.c (bidi_level_of_next_char): Fix last change.
5441
57f97249
EZ
54422011-06-03 Eli Zaretskii <eliz@gnu.org>
5443
fec2107c 5444 Support bidi reordering of text covered by display properties.
57f97249 5445
fec2107c
EZ
5446 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5447 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5448 (bidi_cache_search, bidi_cache_iterator_state)
5449 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5450 (bidi_level_of_next_char, bidi_move_to_visually_next):
5451 Support character positions inside a run of characters covered by a
fec2107c
EZ
5452 display string.
5453 (bidi_paragraph_init, bidi_resolve_explicit_1)
5454 (bidi_level_of_next_char): Call bidi_fetch_char and
5455 bidi_fetch_char_advance instead of FETCH_CHAR and
5456 FETCH_CHAR_ADVANCE.
5457 (bidi_init_it): Initialize new members.
5458 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5459 definitions.
5460 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5461 instead of using explicit *_CHAR codes.
d6d100dd
SM
5462 (bidi_resolve_explicit, bidi_resolve_weak):
5463 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5464 bidirectional text is supported only in multibyte buffers.
5465 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5466 it to initialize the frame_window_p member of struct bidi_it.
5467 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5468 (bidi_resolve_explicit, bidi_resolve_weak)
5469 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5470 bidi_it->nchars is non-positive.
5471 (bidi_level_of_next_char): Don't try to lookup the cache for the
5472 next/previous character if nothing is cached there yet, or if we
5473 were just reseat()'ed to a new position.
c40e2fb2 5474
0e14fe90
EZ
5475 * xdisp.c (set_cursor_from_row): Set start and stop points
5476 according to the row's direction when priming the loop that looks
5477 for the glyph on which to display cursor.
5478 (single_display_spec_intangible_p): Function deleted.
5479 (display_prop_intangible_p): Reimplement to call
5480 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5481 Accept 3 additional arguments needed by handle_display_spec.
5482 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5483 values: lists, `(when COND...)' forms, etc.
5484 (single_display_spec_string_p): Support property values that are
5485 lists with the argument STRING its top-level element.
5486 (display_prop_string_p): Fix the condition for processing a
5487 property that is a list to be consistent with handle_display_spec.
fec2107c 5488 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5489 last portion of handle_display_prop.
5490 (compute_display_string_pos): Accept additional argument
5491 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5492 value of a `display' property is a "replacing spec".
5493 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5494 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5495 the display property, but just return a value indicating whether
5496 the display property will replace the characters it covers.
5497 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5498 frame_window_p members of struct bidi_it.
d6d100dd
SM
5499 (compute_display_string_pos, compute_display_string_end):
5500 New functions.
fec2107c
EZ
5501 (push_it): Accept second argument POSITION, where pop_it should
5502 jump to continue iteration.
5503 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5504
fec2107c
EZ
5505 * keyboard.c (adjust_point_for_property): Adjust the call to
5506 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5507
5508 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5509 (bidi_init_it): Update prototypes.
5510 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5511 (compute_display_string_pos, compute_display_string_end):
5512 Declare prototypes.
fec2107c
EZ
5513 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5514 EMACS_INT.
fc6f18ce 5515
40087514 55162011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5517
57f53182
PE
5518 Malloc failure behavior now depends on size of allocation.
5519 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5520 * lisp.h: Change signatures accordingly.
5521 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5522 All callers changed. (Bug#8762)
5523
5524 * gnutls.c: Use Emacs's memory allocators.
5525 Without this change, the gnutls library would invoke malloc etc.
5526 directly, which causes problems on non-SYNC_INPUT hosts, and which
5527 runs afoul of improving memory_full behavior. (Bug#8761)
5528 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5529 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5530 xfree instead of the default malloc, realloc, free.
5531 (Fgnutls_boot): No need to check for memory allocation failure,
5532 since xmalloc does that for us.
5533
ac32cd99 5534 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5535 * category.c (hash_get_category_set):
5536 * ccl.c (ccl_driver):
5537 * charset.c (Fdefine_charset_internal):
5538 * charset.h (struct charset.hash_index):
5539 * composite.c (get_composition_id, gstring_lookup_cache)
5540 (composition_gstring_put_cache):
5541 * composite.h (struct composition.hash_index):
5542 * dispextern.h (struct image.hash):
5543 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5544 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5545 (hashfn_equal, hashfn_user_defined, make_hash_table)
5546 (maybe_resize_hash_table, hash_lookup, hash_put)
5547 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5548 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5549 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5550 * image.c (make_image, search_image_cache, lookup_image)
5551 (xpm_put_color_table_h):
5552 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5553 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5554 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5555 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5556 * alloc.c (allocate_vectorlike):
5557 Check for overflow in vector size calculations.
5558 * ccl.c (ccl_driver):
5559 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5560 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5561 need to be updated by these changes.
40087514
PE
5562 * fns.c (make_hash_table, maybe_resize_hash_table):
5563 Check for integer overflow with large hash tables.
0de4bb68
PE
5564 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5565 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5566 (SXHASH_REDUCE): New macro.
5567 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5568 Use it instead of discarding useful hash info with large hash values.
5569 (sxhash_float): New function.
5570 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5571 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5572 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5573 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5574 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5575 Adjust signatures to match updated version of code.
5576 (consing_since_gc): Now EMACS_INT, since a single hash table can
5577 use more than INT_MAX bytes.
5578
698d32e2
DN
55792011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5580
5581 Make it possible to build with GCC-4.6+ -O2 -flto.
5582
5583 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5584
fd6fa53f
SM
55852011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5586
5587 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5588 Call minibuffer-inactive-mode.
5589
864db017
JB
55902011-05-31 Juanma Barranquero <lekktu@gmail.com>
5591
5592 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5593 Update dependencies.
5594
2ad0baf4
DN
55952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5596
5597 * data.c (init_data): Remove code for UTS, this system is not
5598 supported anymore.
5599
4fcc2638
DN
56002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5601
5602 Don't force ./temacs to start in terminal mode.
5603
5604 * frame.c (make_initial_frame): Initialize faces in all cases, not
5605 only when CANNOT_DUMP is defined.
5606 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5607
c56e0fd5
DN
56082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5609
5610 * dispnew.c (add_window_display_history): Use const for the string
5611 pointer. Remove declaration, not needed.
5612
333d54da 56132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5614
55d4c1b2 5615 Use 'inline', not 'INLINE'.
333d54da 5616 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5617 * alloc.c, fontset.c (INLINE): Remove.
5618 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5619 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5620 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5621 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5622 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5623
738db178
DN
56242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5625
5626 Make it possible to run ./temacs.
5627
5628 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5629 syms_of_callproc does the same thing. Remove test for
5630 "initialized", do it in the caller.
5631 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5632
620c53a6
SM
56332011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5634
5635 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5636 (read_minibuf): Use get_minibuffer.
5637 (syms_of_minibuf): Use DEFSYM.
5638 (Qmetadata): New var.
5639 * data.c (Qbuffer): Don't make it static.
5640 (syms_of_data): Use DEFSYM.
5641
e003a292
PE
56422011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5643
5644 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5645 (CCL_CODE_MIN): New macro.
5646
ed008a6d
PE
56472011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5648
3687c2ef
PE
5649 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5650
ed008a6d
PE
5651 * eval.c (Qdebug): Now static.
5652 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5653 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5654 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5655
d66c4c7c
CY
56562011-05-29 Chong Yidong <cyd@stupidchicken.com>
5657
5658 * image.c: Various fixes to ImageMagick code comments.
5659 (Fimagemagick_types): Doc fix.
5660
5fbc2025
PE
56612011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5662
0196f88a
PE
5663 Minor fixes prompted by GCC 4.6.0 warnings.
5664
5665 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5666
5fbc2025
PE
5667 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5668 (x_clipboard_manager_save_all): Move extern decl to ...
5669 * xterm.h: ... here, so that it can be checked for consistency.
5670
1dd3c2d9
CY
56712011-05-29 Chong Yidong <cyd@stupidchicken.com>
5672
5673 * xselect.c (x_clipboard_manager_save_frame)
5674 (x_clipboard_manager_save_all): New functions.
5675 (Fx_clipboard_manager_save): Lisp function deleted.
5676
5677 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5678 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5679
5680 * xterm.h: Update prototype.
5681
5ba6571d
WX
56822011-05-28 William Xu <william.xwl@gmail.com>
5683
5684 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5685 exiting (Bug#8239).
5686
3eaff834
JM
56872011-05-28 Jim Meyering <meyering@redhat.com>
5688
e1900994 5689 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5690 * fns.c (to_uchar): Define.
5691 (crypto_hash_function): Use it to convert some newly-signed
5692 variables to unsigned, to avoid sign-extension bugs. For example,
5693 without this change, (md5 "truc") would evaluate to
5694 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5695 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5696 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5697
0f6990a7
PE
56982011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5699
5700 Integer overflow fixes.
c8a9ca5a 5701
08686060
PE
5702 * dbusbind.c: Serial number integer overflow fixes.
5703 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5704 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5705 to hold a serial number that is too large for a fixnum.
5706 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5707 Check for serial numbers out of range. Decode any serial number
59568bf0 5708 that was so large that it became a float. (Bug#8722)
08686060 5709
2d1fc3c7
PE
5710 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5711 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5712 Use XFASTINT rather than XUINT when numbers are nonnegative.
5713 (xd_append_arg, Fdbus_method_return_internal):
5714 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5715 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5716 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5717 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5718 (Bug#8722)
2d1fc3c7 5719
c8a9ca5a
PE
5720 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5721
519e1d69
PE
5722 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5723
6df6ae42 5724 ccl: Add integer overflow checks.
30569699
PE
5725 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5726 (IN_INT_RANGE): New macros.
5727 (ccl_driver): Use them to check for integer overflow when
5728 decoding a CCL program. Many of the new checks are whether XINT (x)
5729 fits in int; it doesn't always, on 64-bit hosts. The new version
5730 doesn't catch all possible integer overflows, but it's an
847044ea 5731 improvement. (Bug#8719)
30569699 5732
c11285dc
PE
5733 * alloc.c (make_event_array): Use XINT, not XUINT.
5734 There's no need for unsigned here.
5735
fdccd48e
PE
5736 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5737 This follows up to the 2011-05-06 change that substituted uintptr_t
5738 for EMACS_INT. This case wasn't caught back then.
5739
37910ab2
PE
5740 Rework Fformat to avoid integer overflow issues.
5741 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5742 now (part of C89). Include <verify.h>.
5743 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5744 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5745 (Fformat): Avoid the prepass trying to compute sizes; it was only
5746 approximate and thus did not catch overflow reliably. Instead, walk
5747 through the format just once, formatting and computing sizes as we go,
5748 checking for integer overflow at every step, and allocating a larger
5749 buffer as needed. Keep track separately whether the format is
5750 multibyte. Keep only the most-recently calculated precision, rather
5751 than them all. Record whether each argument has been converted to
5752 string. Use EMACS_INT, not int, for byte and char and arg counts.
5753 Support field widths and precisions larger than INT_MAX. Avoid
5754 sprintf's undefined behavior with conversion specifications such as %#d
5755 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5756 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5757 formatting out-of-range floating point numbers with int
9173deec 5758 formats. (Bug#8668)
37910ab2 5759
2e6578fb
PE
5760 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5761
0ae6bdee
PE
5762 * data.c: Avoid integer truncation in expressions involving floats.
5763 * data.c: Include <intprops.h>.
5764 (arith_driver): When there's an integer overflow in an expression
5765 involving floating point, convert the integers to floating point
5766 so that the resulting value does not suffer from catastrophic
5767 integer truncation. For example, on a 64-bit host (* 4
5768 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5769 Do not rely on undefined behavior after integer overflow.
5770
de883a70
PE
5771 merge count_size_as_multibyte, parse_str_to_multibyte
5772 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5773 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5774 Check for integer overflow.
5775 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5776 since it's now a duplicate of the other. This is more of
5777 a character than a buffer op, so better that it's in character.c.
5778 * fns.c, print.c: Adjust to above changes.
5779
2ff916cb
PE
57802011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5781
5782 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5783
f1b54466
PE
57842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5785
fb1ac845
PE
5786 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5787 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5788 (x_clipboard_manager_save): Now static.
5789 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5790
f1b54466
PE
5791 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5792 (crypto_hash_function): Now static.
5793 Fix pointer signedness problems. Avoid unnecessary initializations.
5794
a9f737ee
CY
57952011-05-27 Chong Yidong <cyd@stupidchicken.com>
5796
5797 * termhooks.h (Vselection_alist): Make it terminal-local.
5798
5799 * terminal.c (create_terminal): Initialize it.
5800
5801 * xselect.c: Support for clipboard managers.
5802 (Vselection_alist): Move to termhooks.h as terminal-local var.
5803 (LOCAL_SELECTION): New macro.
5804 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5805 (symbol_to_x_atom): Remove gratuitous arg.
5806 (x_handle_selection_request, lisp_data_to_selection_data)
5807 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5808 (x_own_selection, x_get_local_selection, x_convert_selection):
5809 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5810 (some_frame_on_display): Delete unused function.
5811 (Fx_own_selection_internal, Fx_get_selection_internal)
5812 (Fx_disown_selection_internal, Fx_selection_owner_p)
5813 (Fx_selection_exists_p): New optional frame arg.
5814 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5815 (x_handle_selection_clear): Don't treat other terminals with the
5816 same keyboard specially. Use the terminal-local Vselection_alist.
5817 (x_clear_frame_selections): Use Frun_hook_with_args.
5818
5819 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5820
5821 * xterm.h: Add support for those atoms.
5822
e067f0c1
CY
58232011-05-26 Chong Yidong <cyd@stupidchicken.com>
5824
5825 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5826 (converted_selections, conversion_fail_tag): New global variables.
5827 (x_selection_request_lisp_error): Free the above.
5828 (x_get_local_selection): Remove unnecessary code.
5829 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5830 of converted selections stored in converted_selections.
5831 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5832 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5833 (x_convert_selection): New function.
5834 (x_handle_selection_event): Simplify.
5835 (x_get_foreign_selection): Don't ignore incoming requests while
5836 waiting for an answer; this will fail when we implement
5837 SAVE_TARGETS, and seems unnecessary anyway.
5838 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5839 (Vx_sent_selection_functions): Doc fix.
5840
0f4aebc0
LL
58412011-05-26 Leo Liu <sdl.web@gmail.com>
5842
5843 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5844
e61124cd
YM
58452011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5846
5847 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5848
5849 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5850 for fringe update if it has periodic bitmap.
ac389d0c 5851 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5852 and fringe_bitmap_periodic_p.
5853
5854 * fringe.c (get_fringe_bitmap_data): New function.
5855 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5856 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5857 row. Mark glyph row for fringe update if periodicity changed.
5858
5859 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5860 for fringe update unless it has periodic bitmap.
5861
f16d9837
KH
58622011-05-25 Kenichi Handa <handa@m17n.org>
5863
5864 * xdisp.c (get_next_display_element): Set correct it->face_id for
5865 a static composition.
5866
e1b90ef6
LL
58672011-05-24 Leo Liu <sdl.web@gmail.com>
5868
5869 * deps.mk (fns.o):
5870 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5871
5872 * fns.c (crypto_hash_function, Fsha1): New function.
5873 (Fmd5): Use crypto_hash_function.
5874 (syms_of_fns): Add Ssha1.
5875
7400048f
PE
58762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5877
5878 * gnutls.c: Remove unused macros.
5879 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5880 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5881 Remove macros that are defined and never used.
5882 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5883
abb71cf4
CY
58842011-05-22 Chong Yidong <cyd@stupidchicken.com>
5885
5886 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5887 (Fx_get_selection_internal): Minor cleanup.
5888 (Fx_own_selection_internal): Rename arguments for consistency with
5889 select.el.
5890
6307db39
PE
58912011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5892
5893 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5894
f3d4e0a4
CY
58952011-05-22 Chong Yidong <cyd@stupidchicken.com>
5896
5897 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5898
4d8ade89
YM
58992011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5900
5901 * dispnew.c (scrolling_window): Don't exclude the case that the
5902 last enabled row in the desired matrix touches the bottom boundary.
5903
32078c8d
GM
59042011-05-21 Glenn Morris <rgm@gnu.org>
5905
5906 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5907 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5908 and add some more files.
32078c8d 5909
7285dc67
EZ
59102011-05-20 Eli Zaretskii <eliz@gnu.org>
5911
5912 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5913 report_file_error introduced by the change from 2011-05-07.
5914
89d1bd22
PE
59152011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5916
5917 * systime.h (Time): Define only if emacs is defined.
5918 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5919 where the include path doesn't have X11/X.h by default. See
5920 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5921
cd394be1 59222011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5923
5924 * composite.c (find_automatic_composition): Fix previous change.
5925
b9704ad9
GM
59262011-05-20 Glenn Morris <rgm@gnu.org>
5927
5928 * lisp.mk: New file, split from Makefile.in.
5929 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5930 (shortlisp): Remove.
5931 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5932
4a720484
GM
59332011-05-19 Glenn Morris <rgm@gnu.org>
5934
5935 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5936 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5937 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5938 (lisp): Set the order to that of loadup.el.
5939 (shortlisp): Make it a copy of $lisp.
5940 (SOME_MACHINE_LISP): Remove.
5941 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5942 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5943
a28d4396
KH
59442011-05-18 Kenichi Handa <handa@m17n.org>
5945
5946 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5947 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5948 (find_automatic_composition): Mostly rewrite for efficiency.
5949
a2b1fa8e
JB
59502011-05-18 Juanma Barranquero <lekktu@gmail.com>
5951
5952 * makefile.w32-in: Update dependencies.
5953
8e1f5610
CS
59542011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5955
5956 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5957 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5958
7025ee00 59592011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5960
cdfa6eab
PE
5961 Fix some integer overflow issues, such as string length overflow.
5962
06d6db33
PE
5963 * insdel.c (count_size_as_multibyte): Check for string overflow.
5964
2b4560a8
PE
5965 * character.c (lisp_string_width): Check for string overflow.
5966 Use EMACS_INT, not int, for string indexes and lengths; in
5967 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5968 the resulting string length overflows an EMACS_INT; instead,
5969 report a string overflow if no precision given. When checking for
5970 precision exhaustion, use a check that cannot possibly have
5971 integer overflow. (Bug#8675)
5972 * character.h (lisp_string_width): Adjust to new signature.
5973
cb93f9be
PE
5974 * alloc.c (string_overflow): New function.
5975 (Fmake_string): Use it. This doesn't change behavior, but saves
5976 a few bytes and will simplify future changes.
5977 * character.c (string_escape_byte8): Likewise.
5978 * lisp.h (string_overflow): New decl.
5979
1a1f3366
PE
5980 Fixups, following up to the user-interface timestamp change.
5981 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5982 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5983 * msdos.c (mouse_get_pos): Likewise.
5984 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5985 * w32gui.h (Time): Define by including "systime.h" rather than by
5986 declaring it ourselves. (Bug#8664)
5987
d4e3e4d3
PE
5988 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5989 * image.c (clear_image_cache): Likewise.
5990
f6a24d19
PE
5991 * term.c (term_mouse_position): Don't assume time_t wraparound.
5992
08dc5ae6
PE
5993 Be more systematic about user-interface timestamps.
5994 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5995 and sometimes 'EMACS_UINT', to represent these timestamps.
5996 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5997 This makes the code easier to follow, and makes it easier to catch
5998 integer overflow bugs such as Bug#8664.
5999 * frame.c (Fmouse_position, Fmouse_pixel_position):
6000 Use Time, not unsigned long, for user-interface timestamps.
6001 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6002 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6003 * keyboard.h (last_event_timestamp): Likewise.
6004 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6005 * menu.h (xmenu_show): Likewise.
6006 * term.c (term_mouse_position): Likewise.
6007 * termhooks.h (struct input_event.timestamp): Likewise.
6008 (struct terminal.mouse_position_hook): Likewise.
6009 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6010 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6011 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6012 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6013 what it was before.
6014 * menu.h, termhooks.h: Include "systime.h", for Time.
6015
8e55734a
PE
6016 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6017 Don't assume that the difference between two unsigned long values
6018 can fit into an integer. At this point, we know button_down_time
6019 <= event->timestamp, so the difference must be nonnegative, so
6020 there's no need to cast the result if double-click-time is
6021 nonnegative, as it should be; check that it's nonnegative, just in
6022 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6023 apart (about 25 days). (Bug#8664)
8e55734a 6024
841f1b75 6025 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6026 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6027
3e26f69c
PE
6028 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6029 that always fit in int. Use a sentinel instead of a counter, to
6030 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6031 * frame.h (struct frame): Use int for menu_bar_items_used
6032 instead of EMACS_INT, since it always fits in int.
3e26f69c 6033
5cc152c0
PE
6034 * menu.c (grow_menu_items): Check for int overflow.
6035
d89eb65e
PE
6036 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6037
5235bd3e
PE
6038 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6039 Before, the code was not consistent. These values cannot exceed
6040 2**31 - 1 so there's no need to make them unsigned.
6041 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6042 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6043 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6044 as modifiers.
6045 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6046
bc827e23
PE
6047 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6048 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6049 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6050 presumably because the widths might not match.
6051
78eb494e
PE
6052 * window.c (size_window): Avoid needless test at loop start.
6053
04f2d78b
CB
60542011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6055
6056 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6057
d2fc7e3d 60582011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6059
6060 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6061
d2fc7e3d 60622011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6063
6064 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6065 `width' to `bar_area_x' and `bar_area_width', respectively.
6066 (x_scroll_run): Take account of fringe background extension.
6067
04f2d78b
CB
6068 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6069 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6070 `bar_area_width', respectively.
6071 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6072 background extension.
6073
79b70037
GM
60742011-05-10 Jim Meyering <meyering@redhat.com>
6075
6076 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6077
2f142cc5
JB
60782011-05-10 Juanma Barranquero <lekktu@gmail.com>
6079
6080 * image.c (Finit_image_library): Return t for built-in image types,
6081 like pbm and xbm. (Bug#8640)
6082
57679c86
AS
60832011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6084
6085 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6086
888c9e86
EZ
60872011-05-07 Eli Zaretskii <eliz@gnu.org>
6088
b0512a1d
EZ
6089 * w32console.c (Fset_screen_color): Doc fix.
6090 (Fget_screen_color): New function.
6091 (syms_of_ntterm): Defsubr it.
6092
7285dc67
EZ
6093 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6094 unlink the temporary file if Fcall_process didn't create it in the
6095 first place.
6096 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6097 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6098 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6099 cue to call_process_cleanup not to close that handle.
6100
4d3fcc8e
BK
61012011-05-07 Ben Key <bkey76@gmail.com>
6102
6103 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6104 one of two shell specific rules, either bootstrap-temacs-CMD or
6105 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6106 to the previous implementation of the bootstrap-temacs rule.
6107 The bootstrap-temacs-CMD rule is similar to the previous
6108 implementation of the bootstrap-temacs rule except that it
6109 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6110 variable.
6111
6112 These changes, along with some changes to nt/configure.bat,
6113 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6114 earlier fix to add support for --cflags and --ldflags options
6115 that include quotes so that it works whether make uses cmd or
6116 sh as the shell.
6117
b4289b64
MA
61182011-05-06 Michael Albinus <michael.albinus@gmx.de>
6119
6120 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6121 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6122 is a constant.
6123 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6124 a string. Handle both cases.
6125 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6126 (Fdbus_register_method): Use Qinvalid_function.
6127
af4c0e28
JB
61282011-05-06 Juanma Barranquero <lekktu@gmail.com>
6129
6130 * makefile.w32-in: Update dependencies.
6131 (LISP_H): Add inttypes.h and stdin.h.
6132 (PROCESS_H): Add unistd.h.
6133
c51453d9
EZ
61342011-05-06 Eli Zaretskii <eliz@gnu.org>
6135
6136 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6137 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6138
8ff0ac3c 61392011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6140
4c4b566b
PE
6141 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6142
aab2b9b5
PE
6143 * term.c (vfatal): Remove stray call to va_end.
6144 It's not needed and the C Standard doesn't allow it here anyway.
6145
c378da0b
PE
6146 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6147 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6148
288b08c7
PE
6149 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6150 bytes.
6151
e3601888
PE
6152 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6153
db6c0e74
PE
6154 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6155
dd5963ea
PE
6156 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6157
88c9450f
PE
6158 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6159
2f9442b8
PE
6160 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6161
c032b5f8
PE
6162 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6163 * charset.c (Fdefine_charset_internal): Don't initialize
6164 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6165 32-bit int (Bug#8600).
a108c10b
PE
6166
6167 * lread.c (read_integer): Be more consistent with string-to-number.
6168 Use string_to_number to do the actual conversion; this avoids
6169 rounding errors and fixes some other screwups. Without this fix,
6170 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6171 (digit_to_number): Move earlier, for benefit of read_integer.
6172 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6173 not a digit in any supported base. (Bug#8602)
a108c10b 6174
ad5f9eea
PE
6175 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6176
aec1708a
PE
6177 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6178 to match comment at start of function. This also removes a
6179 GCC warning about overflow in a 32+64-bit port.
6180
47be4ab5
PE
6181 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6182
371cac43
PE
6183 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6184 Reported by Stefan Monnier in
6185 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6186 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6187 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6188
d01a7826
PE
6189 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6190 (EMACS_UINTPTR): Likewise, with uintptr_t.
6191
7fd47d5c
PE
6192 * lisp.h: Prefer 64-bit EMACS_INT if available.
6193 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6194 on 32-bit hosts that have 64-bit int, so that they can access
6195 large files.
122b0c86
PE
6196 However, temporarily disable this change unless the temporary
6197 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6198
8727937b
PE
6199 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6200
8ac068ac
PE
6201 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6202 This removes an assumption that EMACS_INT and long are the same
6203 width as pointers. The assumption is true for Emacs porting targets
6204 now, but we want to make other targets possible.
6205 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6206 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6207 In the rest of the code, change types of integers that hold casted
6208 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6209 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6210 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6211 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6212 No need to cast type when ORing.
6213 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6214 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6215 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6216 assume EMACS_INT is the same width as char *.
6217 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6218 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6219 Remove no-longer-needed casts.
6220 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6221 (xg_tool_bar_help_callback, xg_make_tool_item):
6222 Use EMACS_INTPTR to hold an integer
6223 that will be cast to void *; this can avoid a GCC warning
6224 if EMACS_INT is not the same width as void *.
6225 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6226 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6227 (current_message_1, set_message_1):
6228 Use a local to convert to proper width without a cast.
6229 * xmenu.c (dialog_selection_callback): Likewise.
6230
ede49d71
PE
6231 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6232 Also, don't assume VALBITS / RAND_BITS is less than 5,
6233 and don't rely on undefined behavior when shifting a 1 left into
6234 the sign bit.
6235 * lisp.h (get_random): Change signature to match.
6236
2f30ecd0
PE
6237 * lread.c (hash_string): Use size_t, not int, for hash computation.
6238 Normally we prefer signed values; but hashing is special, because
6239 it's better to use unsigned division on hash table sizes so that
6240 the remainder is nonnegative. Also, size_t is the natural width
6241 for hashing into memory. The previous code used 'int', which doesn't
6242 retain enough info to hash well into very large tables.
6243 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6244
2a866e7b
PE
6245 * dbusbind.c: Don't possibly lose pointer info when converting.
6246 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6247 Use XPNTR rather than XHASH, so that the high-order bits of
6248 the pointer aren't lost when converting through void *.
6249
51639eac
PE
6250 * eval.c (Fautoload): Don't double-shift a pointer.
6251
92394119
PE
6252 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6253
dbdb9a7c
JB
62542011-05-06 Juanma Barranquero <lekktu@gmail.com>
6255
6256 * gnutls.c (DEF_GNUTLS_FN):
6257 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6258
db7a0b4f
AS
62592011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6260
6261 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6262 marker. (Bug#8610)
6263
cd394be1 62642011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6265
6266 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6267 New version that can reserve upto 2GB of heap space.
6268
f7ff1b0f 62692011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6270
6271 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6272
639c109b
TZ
62732011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6274
6275 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6276 `gnutls_certificate_set_x509_key_file'.
6277
d2127135
JB
62782011-05-05 Juanma Barranquero <lekktu@gmail.com>
6279
6280 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6281 Update dependencies.
6282
e968f4f3
JB
62832011-05-04 Juanma Barranquero <lekktu@gmail.com>
6284
6285 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6286 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6287 Remove unused parameter `fildes'.
6288 * process.c (read_process_output, send_process): Don't pass it.
6289
84d358f0
JB
62902011-05-04 Juanma Barranquero <lekktu@gmail.com>
6291
6292 Fix previous change: the library cache is defined in w32.c.
6293 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6294 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6295
0898ca10
JB
62962011-05-04 Juanma Barranquero <lekktu@gmail.com>
6297
6298 Implement dynamic loading of GnuTLS on Windows.
6299
6300 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6301 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6302 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6303 Declare.
6304
6305 * gnutls.c (Qgnutls_dll): Define.
6306 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6307 (gnutls_*): Declare function pointers.
6308 (init_gnutls_functions): New function to initialize function pointers.
6309 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6310 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6311 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6312 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6313 (emacs_gnutls_write, emacs_gnutls_read)
6314 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6315 (Fgnutls_available_p): New function.
6316 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6317 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6318 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6319
6320 * image.c: Include w32.h.
6321 (Vimage_type_cache): Delete.
6322 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6323 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6324 (w32_delayed_load): Move to w32.c.
6325
6326 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6327
6328 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6329 (w32_delayed_load): Move from image.c. When loading a library, record
6330 its filename in the :loaded-from property of the library id.
6331 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6332 Initialize and staticpro them.
6333 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6334
6335 * process.c: Include lisp.h before w32.h, not after.
6336 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6337 instead of gnutls_record_check_pending.
6338
6339 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6340
ff4de4aa
TZ
63412011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6342
6343 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6344 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6345 as passed in.
6346
abe95abb
JD
63472011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6348
6349 * xterm.c (x_set_frame_alpha): Do not set property on anything
6350 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6351
e16e55d4
JB
63522011-05-02 Juanma Barranquero <lekktu@gmail.com>
6353
6354 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6355
bafcf6a5
JB
63562011-05-02 Juanma Barranquero <lekktu@gmail.com>
6357
6358 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6359 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6360 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6361 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6362 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6363 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6364 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6365 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6366 (Qgnutls_bootprop_callbacks_verify): Make static.
6367
e7a6747f
AS
63682011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6369
19ed11ba
AS
6370 * callproc.c: Indentation fixup.
6371
e7a6747f 6372 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6373 (wait_for_termination, interruptible_wait_for_termination):
6374 Move after wait_for_termination_1.
e7a6747f 6375
1ef14cb4
LMI
63762011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6377
6378 * sysdep.c (interruptible_wait_for_termination): New function
6379 which is like wait_for_termination, but allows keyboard
6380 interruptions.
6381
6382 * callproc.c (Fcall_process): Add (:file "file") as an option for
6383 the STDOUT buffer.
6384 (Fcall_process_region): Ditto.
6385
330d880c
EZ
63862011-04-30 Eli Zaretskii <eliz@gnu.org>
6387
8db90b73
EZ
6388 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6389 rather than `XVECTOR (FOO)->size'.
6390
330d880c
EZ
6391 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6392 inttypes.h, as a gnulib replacement is used if it not available in
6393 system headers.
6394
15cbd324
EZ
63952011-04-21 Eli Zaretskii <eliz@gnu.org>
6396
6397 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6398 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6399 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6400
6401 * coding.c (coding_alloc_by_realloc): Error out if destination
6402 will grow beyond MOST_POSITIVE_FIXNUM.
6403 (decode_coding_emacs_mule): Abort if there isn't enough place in
6404 charbuf for the composition carryover bytes. Reserve an extra
6405 space for up to 2 characters produced in a loop.
6406 (decode_coding_iso_2022): Abort if there isn't enough place in
6407 charbuf for the composition carryover bytes.
6408
64092011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6410
ae940cca
EZ
6411 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6412 aborting when %lld or %lll format is passed.
6413 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6414 %llo or %llx format is passed. (Bug#8545)
6415
03ab8921
EZ
6416 * window.c (window_scroll_line_based): Use a marker instead of
6417 simple variables to record original value of point. (Bug#7952)
6418
afda1437
EZ
6419 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6420 produced by %s or %c overflows available buffer space. (Bug#8545)
6421
f76dee0c
PE
64222011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6423
6424 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6425 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6426
fdc5744d
JB
64272011-04-28 Juanma Barranquero <lekktu@gmail.com>
6428
6429 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6430
638f053a
JB
64312011-04-28 Juanma Barranquero <lekktu@gmail.com>
6432
6433 * keyboard.c (Qdelayed_warnings_hook): Define.
6434 (command_loop_1): Run `delayed-warnings-hook'
6435 if Vdelayed_warnings_list is non-nil.
6436 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6437 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6438
d178f871
EZ
64392011-04-28 Eli Zaretskii <eliz@gnu.org>
6440
6441 * doprnt.c (doprnt): Don't return value smaller than the buffer
6442 size if the message was truncated. (Bug#8545).
6443
b124fd93
JB
64442011-04-28 Juanma Barranquero <lekktu@gmail.com>
6445
6446 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6447 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6448
e810457d
PE
64492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6450
6451 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6452
ea51cceb
JB
64532011-04-27 Juanma Barranquero <lekktu@gmail.com>
6454
6455 * makefile.w32-in: Update dependencies.
6456
94dcfacf
EZ
64572011-04-27 Eli Zaretskii <eliz@gnu.org>
6458
6459 Improve `doprnt' and its usage. (Bug#8545)
6460 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6461 `format_end'. Remove support for %l as a conversion specifier.
6462 Don't use xrealloc. Improve diagnostics when the %l size modifier
6463 is used. Update the commentary.
6464
6465 * eval.c (verror): Simplify calculation of size_t.
6466
6467 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6468 messages.
6469
f61f41d7
PE
64702011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6471
6472 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6473 change.
6474
96fb4434
PE
64752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6476
6477 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6478 This makes this file independent of the recent pseudovector change.
6479
671875da 64802011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6481
69e9b5a3
PE
6482 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6483
b5f869a7 6484 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6485 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6486 Remove unused local.
c8926152 6487 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6488
841a1577 6489 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6490 GCC 4.6.0 optimizes based on type-based alias analysis.
6491 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6492 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6493 != &v->size, and therefore "v->size = 1; b->size = 2; return
6494 v->size;" must therefore return 1. This assumption is incorrect
6495 for Emacs, since it type-puns struct Lisp_Vector * with many other
6496 types. To fix this problem, this patch adds a new type struct
f904488f 6497 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6498 and pseudovectors, and helps optimizing compilers not get fooled
6499 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6500 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6501 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6502 the size member.
eab3844f
PE
6503 (XSETPVECTYPE): Rewrite in terms of new macro.
6504 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6505 This is a bit clearer, and further avoids the possibility of
6506 undesirable aliasing.
6507 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6508 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6509 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6510 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6511 (ASIZE): Now uses header.size rather than size.
6512 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6513 to avoid the hassle of writing XVECTOR (foo)->header.size.
6514 (struct vectorlike_header): New type.
eab3844f
PE
6515 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6516 object, to help avoid aliasing.
6517 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6518 (SUBRP): Likewise, since Lisp_Subr is a special case.
6519 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6520 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6521 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6522 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6523 changed to be "header.size" and "header.next".
6524 * buffer.h (struct buffer): Likewise.
6525 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6526 * frame.h (struct frame): Likewise.
6527 * process.h (struct Lisp_Process): Likewise.
6528 * termhooks.h (struct terminal): Likewise.
6529 * window.c (struct save_window_data, struct saved_window): Likewise.
6530 * window.h (struct window): Likewise.
6531 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6532 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6533 * buffer.c (init_buffer_once): Likewise.
6534 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6535 special case.
6536 * process.c (Fformat_network_address): Use local var for size,
6537 for brevity.
6538
0df1eac5
PE
6539 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6540
847ab9d1 6541 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6542 * data.c (atof): Remove decl; no longer used or needed.
6543 (digit_to_number): Move to lread.c.
6544 (Fstring_to_number): Use new string_to_number function, to be
6545 consistent with how the Lisp reader treats infinities and NaNs.
6546 Do not assume that floating-point numbers represent EMACS_INT
6547 without losing information; this is not true on most 64-bit hosts.
6548 Avoid double-rounding errors, by insisting on integers when
6549 parsing non-base-10 numbers, as the documentation specifies.
6550 * lisp.h (string_to_number): New decl, replacing ...
6551 (isfloat_string): Remove.
bc0a5c13 6552 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6553 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6554 appears to have been a coding error. Similarly, do not accept
6555 strings like +-1e0 as floating point numbers. Do not report
6556 overflow for integer overflows unless the base is not 10 which
6557 means we have no simple and reliable way to continue.
6558 Break out the floating-point parsing into a new
6559 function string_to_number, so that Fstring_to_number parses
6560 floating point numbers consistently with the Lisp reader.
04f2d78b 6561 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6562 (E_CHAR, EXP_INT): Remove, replacing with ...
6563 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6564 (string_to_number): New function, replacing isfloat_string.
6565 This function checks for valid syntax and produces the resulting
6566 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6567 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6568 so that overflow for non-base-10 numbers is reported only when
6569 there's no portable and simple way to convert to floating point.
452f4150 6570
67769ffc
PE
6571 * textprop.c (set_text_properties_1): Rewrite for clarity,
6572 and to avoid GCC warning about integer overflow.
6573
c20db43f
PE
6574 * intervals.h (struct interval): Use EMACS_INT for members
6575 where EMACS_UINT might cause problems. See
6576 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6577 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6578 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6579 All uses changed.
37aa2f85
PE
6580 (offset_intervals): Tell GCC not to worry about length overflow
6581 when negating a negative length.
c20db43f 6582
2538aa2f
PE
6583 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6584 (overrun_check_free): Likewise.
6585
f2d3008d
PE
6586 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6587 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6588 word size.
6589
ec8df744
PE
6590 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6591 (gnutls_make_error): Rename local to avoid shadowing.
6592 (gnutls_emacs_global_deinit): ifdef out; not used.
6593 (Fgnutls_boot): Use const for pointer to readonly storage.
6594 Comment out unused local. Fix pointer signedness problems.
6595
640ee02d
PE
6596 * lread.c (openp): Don't stuff size_t into an 'int'.
6597 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6598 about possible signed overflow.
6599
6048fb2a
PE
6600 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6601 (GDK_KEY_g): Don't define if already defined.
6602 (xg_prepare_tooltip): Avoid pointer signedness problem.
6603 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6604
fa3c87e1
PE
6605 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6606 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6607
2172544b
PE
6608 * xfns.c (Fx_window_property): Simplify a bit,
6609 to make a bit faster and to avoid GCC 4.6.0 warning.
6610 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6611
9b821a21
PE
6612 * fns.c (internal_equal): Don't assume size_t fits in int.
6613
3c616cfa
PE
6614 * alloc.c (compact_small_strings): Tighten assertion a little.
6615
c2982e87
PE
6616 Replace pEd with more-general pI, and fix some printf arg casts.
6617 * lisp.h (pI): New macro, generalizing old pEd macro to other
6618 conversion specifiers. For example, use "...%"pI"d..." rather
6619 than "...%"pEd"...".
6620 (pEd): Remove. All uses replaced with similar uses of pI.
6621 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6622 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6623 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6624 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6625 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6626 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6627 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6628 64-bit hosts.
6629 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6630 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6631 * print.c (safe_debug_print, print_object): Likewise.
6632 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6633 to int.
6f04d126
PE
6634 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6635 avoiding the 0 flag, which is not portable.
c2982e87
PE
6636 * process.c (Fmake_network_process): Use pI to avoid cast.
6637 * region-cache.c (pp_cache): Likewise.
6638 * xdisp.c (decode_mode_spec): Likewise.
6639 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6640 behavior on 64-bit hosts with printf arg.
6f04d126 6641 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6642 (x_stop_queuing_selection_requests): Likewise.
6643 (x_get_window_property): Don't truncate byte count to an 'int'
6644 when tracing.
0b432f21 6645
5e073ec7
PE
6646 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6647 here, since it parses constructs like leading '-' and spaces,
6648 which are not wanted; and it overflows with large numbers.
6649 Instead, simply match F[0-9]+, which is what is wanted anyway.
6650
36372bf9
PE
6651 * alloc.c: Remove unportable assumptions about struct layout.
6652 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6653 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6654 (allocate_vectorlike, make_pure_vector): Use the new macros,
6655 plus offsetof, to remove unportable assumptions about struct layout.
6656 These assumptions hold on all porting targets that I know of, but
6657 they are not guaranteed, they're easy to remove, and removing them
6658 makes further changes easier.
6659
0b432f21
PE
6660 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6661 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6662 (string_overrun_cookie): Now const. Use initializers that
6663 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6664 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6665 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6666 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6667 multiple of sizeof (EMACS_INT); it need not be, if
6668 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6669 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6670
895009e1
JB
66712011-04-26 Juanma Barranquero <lekktu@gmail.com>
6672
6673 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6674
6a7a1b0b
TZ
66752011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6676
6677 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6678 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6679 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6680
841a1577 66812011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6682
6683 * lisp.h (Qdebug): List symbol.
895009e1 6684 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6685 * keyboard.c (debug-on-event): New variable.
6686 (handle_user_signal): Break into debugger when debug-on-event
6687 matches the current signal symbol.
6688
f2d3ba6f
DN
66892011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6690
6691 * alloc.c (check_sblock, check_string_bytes)
6692 (check_string_free_list): Convert to standard C.
6693
42ce4c63
TZ
66942011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6695
6696 * w32.c (emacs_gnutls_push): Fix typo.
6697
825cd63c
EZ
66982011-04-25 Eli Zaretskii <eliz@gnu.org>
6699
fb11d64d
EZ
6700 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6701 "cast to pointer from integer of different size".
6702
825cd63c
EZ
6703 Improve doprnt and its use in verror. (Bug#8545)
6704 * doprnt.c (doprnt): Document the set of format control sequences
6705 supported by the function. Use SAFE_ALLOCA instead of always
6706 using `alloca'.
6707
6708 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6709 is one byte too soon. Don't use xrealloc; instead xfree and
6710 xmalloc anew.
6711
e061a11b
TZ
67122011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6713
6714 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6715 callbacks stage.
6716
6717 * gnutls.c: Renamed global_initialized to
6718 gnutls_global_initialized. Added internals for the
6719 :verify-hostname-error, :verify-error, and :verify-flags
6720 parameters of `gnutls-boot' and documented those parameters in the
6721 docstring. Start callback support.
9173deec
JB
6722 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6723 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6724 on error. Return error code.
e061a11b
TZ
6725 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6726 (emacs_gnutls_read): Likewise.
6727 (Fgnutls_boot): Return handshake error code.
6728 (emacs_gnutls_handle_error): New function.
6729 (wsaerror_to_errno): Likewise.
6730
6731 * w32.h (emacs_gnutls_pull): Add prototype.
6732 (emacs_gnutls_push): Likewise.
6733
6734 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6735 (emacs_gnutls_push): Likewise.
6736
67372011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6738
6739 * process.c (wait_reading_process_output): Check if GnuTLS
6740 buffered some data internally if no FDs are set for TLS
6741 connections.
6742
6743 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6744 (LIBS): Link to USER_LIBS.
6745 ($(BLD)/gnutls.$(0)): New target.
6746
fa6996bc
EZ
67472011-04-24 Eli Zaretskii <eliz@gnu.org>
6748
eb35682e
EZ
6749 * xdisp.c (handle_single_display_spec): Rename the
6750 display_replaced_before_p argument into display_replaced_p, to
6751 make it consistent with the commentary. Fix typos in the
6752 commentary.
6753
e2ad650c
EZ
6754 * textprop.c (syms_of_textprop): Remove dead code.
6755 (copy_text_properties): Delete obsolete commentary about an
6756 interface that was deleted long ago. Fix typos in the description
6757 of arguments.
6758
1b2de274
EZ
6759 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6760 to changes in oldXMenu/XMenu.h from 2011-04-16.
6761 <menu_help_message, prev_menu_help_message>: Constify.
6762 (IT_menu_make_room): menu->help_text is now `const char **';
6763 adjust.
6764
6765 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6766 to changes in oldXMenu/XMenu.h from 2011-04-16.
6767 (struct XMenu): Declare `help_text' `const char **'.
6768
6769 * xfaces.c <Qunspecified>: Make extern again.
6770
6771 * syntax.c: Include sys/types.h before including regex.h, as
6772 required by Posix.
6773
762b15be
EZ
6774 * doc.c (get_doc_string): Improve the format passed to `error'.
6775
6776 * doprnt.c (doprnt): Improve commentary.
6777
6778 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6779
6780 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6781 them with etags.
6782
f1052e5d
EZ
6783 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6784 changes in globals.h immediately force recompilation.
762b15be
EZ
6785 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6786 $(CURDIR)/s/ms-w32.h.
6787 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6788
fa6996bc
EZ
6789 * character.c (Fchar_direction): Function deleted.
6790 (syms_of_character): Don't defsubr it.
6791 <char-direction-table>: Deleted.
6792
e6c3da20
EZ
67932011-04-23 Eli Zaretskii <eliz@gnu.org>
6794
6795 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6796 * doprnt.c: Include limits.h.
6797 (SIZE_MAX): New macro.
04f2d78b
CB
6798 (doprnt): Return a size_t value. 2nd arg is now size_t.
6799 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6800 Improve overflow protection. Support `l' modifier for integer
6801 conversions. Support %l conversion. Don't assume an EMACS_INT
6802 argument for integer conversions and for %c.
6803
6804 * lisp.h (doprnt): Restore prototype.
6805
6806 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6807 $(SRC)/character.h.
6808
6809 * Makefile.in (base_obj): Add back doprnt.o.
6810
6811 * deps.mk (doprnt.o): Add back prerequisites.
6812 (callint.o): Depend on character.h.
6813
6814 * eval.c (internal_lisp_condition_case): Include the handler
6815 representation in the error message.
6816 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6817 when breaking from the loop.
6818
6819 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6820
6821 * callint.c (Fcall_interactively): When displaying error message
6822 about invalid control letter, pass the character's codepoint, not
6823 a pointer to its multibyte form. Improve display of the character
6824 in octal and display also its hex code.
6825
6826 * character.c (char_string): Use %x to display the (unsigned)
6827 codepoint of an invalid character, to avoid displaying a bogus
6828 negative value.
6829
6830 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6831 `error', not SYMBOL_NAME itself.
6832
6833 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6834 character arguments to `error'.
6835
6836 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6837 to `error' in error message about FINAL_CHAR argument. Make sure
6838 FINAL_CHAR is a character, and use %c when it is passed as
6839 argument to `error'.
6840
4ffd0d6b 68412011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6842
6843 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6844
6845 * w32.c: Include <time.h>.
6846 (sys_localtime): New function.
6847
4ffd0d6b 68482011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6849
6850 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6851
4ffd0d6b 6852 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6853
4ffd0d6b 68542011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6855
4ffd0d6b
GM
6856 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6857 zombies (Bug#8467).
aac0c6e3 6858
04c56954
EZ
68592011-04-19 Eli Zaretskii <eliz@gnu.org>
6860
6861 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6862 gl_state.e_property when gl_state.object is Qt.
6863
6864 * insdel.c (make_gap_larger): Remove limitation of buffer size
6865 to <= INT_MAX.
6866
16a43933
CY
68672011-04-18 Chong Yidong <cyd@stupidchicken.com>
6868
6869 * xdisp.c (lookup_glyphless_char_display)
6870 (produce_glyphless_glyph): Handle cons cell entry in
6871 glyphless-char-display.
6872 (Vglyphless_char_display): Document it.
6873
6874 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6875 glyphless-char-display.
6876
4581706e
CY
68772011-04-17 Chong Yidong <cyd@stupidchicken.com>
6878
6879 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6880
6881 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6882
6883 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6884 definition for no-X builds.
6885
4887c6e2 68862011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6887
fd35b6f9
PE
6888 Static checks with GCC 4.6.0 and non-default toolkits.
6889
5c1ccb01
PE
6890 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6891
006c5daa
PE
6892 * process.c (keyboard_bit_set): Define only if SIGIO.
6893 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6894 (send_process): Repair possible setjmp clobbering.
6895
efc736d3
PE
6896 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6897
4e2fe2e6
PE
6898 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6899
f97334a2
PE
6900 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6901
4e75f29d
PE
6902 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6903 Define only if needed.
6904
90efadd1
PE
6905 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6906 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6907 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6908
3c647824
PE
6909 * dispextern.h (struct redisplay_interface): Rename param
6910 to avoid shadowing.
e264f262 6911 * termhooks.h (struct terminal): Likewise.
761383f4 6912 * xterm.c (xembed_send_message): Likewise.
3c647824 6913
b58c5c4a
PE
6914 * insdel.c (make_gap_smaller): Define only if
6915 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6916
cad59032
PE
6917 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6918 it.
6919
c339dc2e
PE
6920 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6921 so that we aren't warned about unused symbols.
6922
91a3e27b
PE
6923 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6924
399c71d3 6925 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6926
8ffc96f5
PE
6927 * xfns.c (x_real_positions): Mark locals as initialized.
6928
eef9bc79
PE
6929 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6930
098db9dd
PE
6931 * xterm.c: Fix problems found by static analysis with other toolkits.
6932 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6933 (x_dispatch_event): Declare static if USE_GTK, and
6934 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6935 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6936 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6937 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6938 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6939
eb18f6cc
PE
6940 * xmenu.c (menu_help_callback): Pointer type fixes.
6941 Use const pointers when pointing at readonly data. Avoid pointer
6942 signedness clashes.
6943 (FALSE): Remove unused macro.
6944 (update_frame_menubar): Remove unused decl.
6945
1fe72bf8
PE
6946 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6947
60d9e1db
PE
6948 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6949 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6950 (single_menu_item): Rename local to avoid shadowing.
6951
39261c26
PE
6952 * keyboard.c (make_lispy_event): Remove unused local var.
6953
018c5e19
PE
6954 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6955 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6956
63d2b86e
PE
6957 * bitmaps: Change bitmaps from unsigned char back to the X11
6958 compatible char. Avoid the old compiler warnings about
6959 out-of-range initializers by using, for example, '\xab' rather
6960 than 0xab.
6961
aefd87e1
PE
6962 * xgselect.c (xgselect_initialize): Check vs interface
6963 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6964
bf501fb9
PE
6965 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6966
e9829fdf
PE
6967 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6968 to read-only memory.
6969
1086c095
PE
6970 * fns.c (vector): Remove; this old hack is no longer needed.
6971
2baccd04 6972 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6973 Remove unused var.
dde42981 6974 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6975
72391843 6976 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6977
436c16df 6978 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6979 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6980 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6981
92bb796d 6982 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6983 (x_term_init): Remove local to avoid shadowing.
92bb796d 6984
764430a3 6985 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6986
6987 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6988 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6989
d1dfb56c
EZ
69902011-04-16 Eli Zaretskii <eliz@gnu.org>
6991
c4354cb4
EZ
6992 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6993
d1dfb56c
EZ
6994 Fix regex.c, syntax.c and friends for buffers > 2GB.
6995 * syntax.h (struct gl_state_s): Declare character position members
6996 EMACS_INT.
6997
6998 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6999
04f2d78b
CB
7000 * textprop.c (verify_interval_modification, interval_of):
7001 Declare arguments EMACS_INT.
d1dfb56c
EZ
7002
7003 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7004 EMACS_INT.
7005
7006 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7007
7008 * indent.c (Fvertical_motion): Local variable it_start is now
7009 EMACS_INT.
7010
7011 * regex.c (re_match, re_match_2, re_match_2_internal)
7012 (bcmp_translate, regcomp, regexec, print_double_string)
7013 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7014 (re_compile_pattern, re_exec): Declare arguments and local
7015 variables `size_t' and `ssize_t' and return values `regoff_t', as
7016 appropriate.
7017 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7018 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7019 <compile_stack_type>: `size' and `avail' are now `size_t'.
7020
7021 * regex.h <regoff_t>: Use ssize_t, not int.
7022 (re_search, re_search_2, re_match, re_match_2): Arguments that
7023 specify buffer/string position and length are now ssize_t and
7024 size_t. Return type is regoff_t.
7025
613052cd
BK
70262011-04-16 Ben Key <bkey76@gmail.com>
7027
7028 * nsfont.m: Fixed bugs in ns_get_family and
7029 ns_descriptor_to_entity that were caused by using free to
7030 deallocate memory blocks that were allocated by xmalloc (via
7031 xstrdup). This caused Emacs to crash when compiled with
7032 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7033 --enable-checking=xmallocoverrun). xfree is now used to
7034 deallocate these memory blocks.
7035
4170f62f 70362011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7037
71b41406
PE
7038 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7039
9587a89d
PE
7040 emacs_write: Accept and return EMACS_INT for sizes.
7041 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7042 et seq.
7043 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7044 Accept and return EMACS_INT.
7045 (emacs_gnutls_write): Return the number of bytes written on
7046 partial writes.
7047 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7048 (emacs_read, emacs_write): Remove check for negative size, as the
7049 Emacs source code has been audited now.
9587a89d
PE
7050 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7051 (emacs_read, emacs_write): Use it.
273a5f82
PE
7052 * process.c (send_process): Adjust to the new signatures of
7053 emacs_write and emacs_gnutls_write. Do not attempt to store
7054 a byte offset into an 'int'; it might overflow.
9587a89d 7055 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7056
3e047f51
PE
7057 * sound.c: Don't assume sizes fit in 'int'.
7058 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7059 Return EMACS_INT, not int.
3e047f51 7060 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7061 Accept EMACS_INT, not int.
7062 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7063 record read return values.
7064
cc39a9db
BK
70652011-04-15 Ben Key <bkey76@gmail.com>
7066
c9d0ec6d
JB
7067 * keyboard.c (Qundefined): Don't declare static since it is used
7068 in nsfns.m.
7069 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7070 static since they are used in nsfont.m.
cc39a9db 7071
6c60eb9f
SM
70722011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7073
7074 * process.c (Qprocessp): Don't declare static.
7075 * lisp.h (Qprocessp): Declare again.
7076
7990b61a
JB
70772011-04-15 Juanma Barranquero <lekktu@gmail.com>
7078
7079 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7080
5d4cb038
PE
70812011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7082
8bd7b830 7083 Improve C-level modularity by making more things 'static'.
cd64ea1d 7084
e3b27b31
PE
7085 Don't publish debugger-only interfaces to other modules.
7086 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7087 (verify_bytepos, count_markers): Move decls to the only modules
7088 that need them.
7089 * region-cache.h (pp_cache): Likewise.
7090 * window.h (check_all_windows): Likewise.
7091 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7092
5d4cb038
PE
7093 * sysdep.c (croak): Now static, if
7094 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7095 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7096
7097 * alloc.c (refill_memory_reserve): Now static if
7098 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7099 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7100
e87b6180
PE
7101 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7102 Define only if USE_LUCID.
7103
ac64929e
PE
7104 * xrdb.c (x_customization_string, x_rm_string): Now static.
7105
6f37259d
PE
7106 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7107 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7108
1683e3ab
PE
7109 * xdisp.c (draw_row_with_mouse_face): Now static.
7110 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7111
de9c2632
PE
7112 * window.h (check_all_windows): Mark externally visible.
7113
2b96acb7
PE
7114 * window.c (window_deletion_count): Now static.
7115
7116 * undo.c: Make symbols static if they're not exported.
7117 (last_undo_buffer, last_boundary_position, pending_boundary):
7118 Now static.
7119
50436f33
PE
7120 * textprop.c (interval_insert_behind_hooks): Now static.
7121 (interval_insert_in_front_hooks): Likewise.
7122
64520e5c
PE
7123 * term.c: Make symbols static if they're not exported.
7124 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7125 (max_frame_lines, tty_set_terminal_modes):
7126 (tty_reset_terminal_modes, tty_turn_off_highlight):
7127 (get_tty_terminal): Now static.
7128 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7129 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7130 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7131 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7132 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7133
1fa53021
PE
7134 * sysdep.c: Make symbols static if they're not exported.
7135 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7136 Now static.
7137 (sigprocmask_set, full_mask): Remove; unused.
7138 (wait_debugging): Mark as visible.
7139 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7140 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7141
d4b43b22
PE
7142 * syntax.c (syntax_temp): Define only if !__GNUC__.
7143
b7c513d0
PE
7144 * sound.c (current_sound_device, current_sound): Now static.
7145
989b29ad
PE
7146 * search.c (searchbufs, searchbuf_head): Now static.
7147
13a55a78
PE
7148 * scroll.c (scroll_cost): Remove; unused.
7149 * dispextern.h (scroll_cost): Remove decl.
7150
de68a1fc
PE
7151 * region-cache.h (pp_cache): Mark as externally visible.
7152
40ccffa6
PE
7153 * process.c: Make symbols static if they're not exported.
7154 (process_tick, update_tick, create_process, chan_process):
7155 (Vprocess_alist, proc_buffered_char, datagram_access):
7156 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7157 (deactivate_process): Mark defn as static, as well as decl.
7158 * lisp.h (create_process): Remove decl.
7159 * process.h (chan_process, Vprocess_alist): Remove decls.
7160
ad64fc97
PE
7161 * print.c: Make symbols static if they're not exported.
7162 (print_depth, new_backquote_output, being_printed, print_buffer):
7163 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7164 (print_interval, print_number_index, initial_stderr_stream):
7165 Now static.
7166 * lisp.h (Fprinc): Remove decl.
7167 (debug_output_compilation_hack): Mark as externally visible.
7168
adddb265
PE
7169 * sysdep.c (croak): Move decl from here to syssignal.h.
7170 * syssignal.h (croak): Put it here, so the API can be checked when
7171 'croak' is called from dissociate_if_controlling_tty.
7172
1717ede2
PE
7173 * minibuf.c: Make symbols static if they're not exported.
7174 (minibuf_save_list, choose_minibuf_frame): Now static.
7175 * lisp.h (choose_minibuf_frame): Remove decl.
7176
fa5fb2bc
PE
7177 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7178
1e3890d1
PE
7179 * lread.c: Make symbols static if they're not exported.
7180 (read_objects, initial_obarray, oblookup_last_bucket_number):
7181 Now static.
7182 (make_symbol): Remove; unused.
7183 * lisp.h (initial_obarray, make_symbol): Remove decls.
7184
8a1414fa
PE
7185 * keyboard.c: Make symbols static if they're not exported.
7186 (single_kboard, recent_keys_index, total_keys, recent_keys):
7187 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7188 (this_single_command_key_start, echoing, last_auto_save):
7189 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7190 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7191 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7192 (Vlispy_mouse_stem, double_click_count):
7193 Now static.
7194 (force_auto_save_soon): Define only if SIGDANGER.
7195 (ignore_mouse_drag_p): Now static if
7196 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7197 (print_help): Remove; unused.
7198 (stop_character, last_timer_event): Mark as externally visible.
7199 * keyboard.h (ignore_mouse_drag_p): Declare only if
7200 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7201 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7202 * lisp.h (echoing): Remove decl.
7203 (force_auto_save_soon): Declare only if SIGDANGER.
7204 * xdisp.c (redisplay_window): Simplify code, to make it more
7205 obvious that ignore_mouse_drag_p is not accessed if !defined
7206 USE_GTK && !defined HAVE_NS.
7207
93ea6e8f
PE
7208 * intervals.c: Make symbols static if they're not exported.
7209 (merge_properties_sticky, merge_interval_right, delete_interval):
7210 Now static.
7211 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7212
77382fcc
PE
7213 * insdel.c: Make symbols static if they're not exported.
7214 However, leave prepare_to_modify_buffer alone. It's never
7215 called from outside this function, but that appears to be a bug.
7216 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7217 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7218 (adjust_after_replace_noundo): Remove; unused.
7219 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7220 (signal_before_change): Remove decls.
77382fcc 7221
9306c32e
PE
7222 * indent.c (val_compute_motion, val_vmotion): Now static.
7223
cd44d2eb
PE
7224 * image.c: Make symbols static if they're not exported.
7225 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7226 if USE_GTK.
7227 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7228 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7229
ad9a7a06
PE
7230 * fringe.c (standard_bitmaps): Now static.
7231 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7232
81626931
PE
7233 * frame.c: Make symbols static if they're not exported.
7234 (x_report_frame_params, make_terminal_frame): Now static.
7235 (get_frame_param): Now static, unless HAVE_NS.
7236 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7237 (x_get_resource_string): Remove; not used.
7238 * frame.h (make_terminal_frame, x_report_frame_params):
7239 (x_get_resource_string); Remove decls.
7240 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7241 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7242
239f9db9
PE
7243 * font.c, fontset.c: Make symbols static if they're not exported.
7244 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7245 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7246 * font.c (font_close_object): Now static.
7247 * font.h (font_close_object): Remove.
7248 * fontset.c (FONTSET_OBJLIST): Remove.
7249 (free_realized_fontset) #if-0 the body, which does nothing.
7250 (face_suitable_for_char_p): #if-0, as it's never called.
7251 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7252 * xfaces.c (face_at_string_position):
7253 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7254 since 0 is always ASCII.
7255
dfcf3579
PE
7256 * fns.c (weak_hash_tables): Now static.
7257
5045092b
PE
7258 * fileio.c: Make symbols static if they're not exported.
7259 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7260 (Vwrite_region_annotation_buffers): Now static.
7261
57a96f5c
PE
7262 * eval.c: Make symbols static if they're not exported.
7263 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7264 * lisp.h (backtrace_list): Remove decl.
7265
35f08c38
PE
7266 * emacs.c: Make symbols static if they're not exported.
7267 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7268 (fatal_error_code, fatal_error_signal_hook, standard_args):
7269 Now static.
7270 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7271 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7272 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7273 * lisp.h (fatal_error_signal_hook): Remove decl.
7274 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7275
f44bd759
PE
7276 * editfns.c: Move a (normally-unused) function to its only use.
7277 * editfns.c, lisp.h (get_operating_system_release): Remove.
7278 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7279 worth the hassle of breaking this out.
7280
b532497d
PE
7281 * xterm.c: Make symbols static if they're not exported.
7282 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7283 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7284 (x_destroy_window, x_delete_display):
7285 Now static.
7286 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7287 (x_mouse_leave): Remove; unused.
7288 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7289 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7290 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7291 Remove decls.
7292 (x_mouse_leave): Declare only if WINDOWSNT.
7293 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7294 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7295 USE_X_TOOLKIT.
7296
1675728f
PE
7297 * ftxfont.c: Make symbols static if they're not exported.
7298 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7299 HAVE_FREETYPE.
7300 * font.h (ftxfont_driver): Likewise.
7301
e4cebfca
PE
7302 * xfns.c: Make symbols static if they're not exported.
7303 (x_last_font_name, x_display_info_for_name):
7304 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7305 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7306 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7307 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7308 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7309 (last_show_tip_args): Now static.
7310 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7311 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7312 (x_screen_planes): Remove; unused.
7313 * dispextern.h (x_screen_planes): Remove decl.
7314
5bf46f05
PE
7315 * dispnew.c: Make symbols static if they're not exported.
7316 * dispextern.h (redraw_garbaged_frames, scrolling):
7317 (increment_row_positions): Remove.
7318 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7319 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7320 Now static.
7321 (redraw_garbaged_frames): Remove; unused.
7322
435f4c28
PE
7323 * xfaces.c: Make symbols static if they're not exported.
7324 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7325 Remove decls.
7326 * xterm.h (defined_color): Remove decls.
7327 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7328 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7329 (menu_face_changed_default, defined_color, free_realized_face):
7330 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7331 (ascii_face_of_lisp_face): Remove; unused.
7332
8524aef3
PE
7333 * xdisp.c: Make symbols static if they're not exported.
7334 * dispextern.h (scratch_glyph_row, window_box_edges):
7335 (glyph_to_pixel_coords, set_cursor_from_row):
7336 (get_next_display_element, set_iterator_to_next):
7337 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7338 (show_mouse_face): Remove decls
7339 * frame.h (message_buf_print): Likewise.
7340 * lisp.h (pop_message, set_message, check_point_in_composition):
7341 Likewise.
7342 * xterm.h (set_vertical_scroll_bar): Likewise.
7343 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7344 (message_buf_print, scratch_glyph_row, displayed_buffer):
7345 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7346 (get_next_display_element, show_mouse_face, window_box_edges):
7347 (frame_to_window_pixel_xy, check_point_in_composition):
7348 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7349 (glyph_to_pixel_coords): Remove; unused.
7350
16390cd2
PE
7351 * dired.c (file_name_completion): Now static.
7352
7353 * dbusbind.c (xd_in_read_queued_messages): Now static.
7354
a25f4dfa
PE
7355 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7356 * data.c (circular_list_error): Remove.
7357
14a9c8df
PE
7358 * commands.h (last_point_position, last_point_position_buffer):
7359 (last_point_position_window): Remove decls.
7360 * keyboard.c: Make these variables static.
7361
04f2d78b
CB
7362 * coding.h (coding, code_convert_region, encode_coding_gap):
7363 Remove decls.
74ab6df5
PE
7364 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7365 (iso_code_class, detect_coding, code_convert_region): Now static.
7366 (encode_coding_gap): Remove; unused.
7367
38dfbee1
PE
7368 * chartab.c (chartab_chars, chartab_bits): Now static.
7369
a2cb4e63
PE
7370 * charset.h (charset_iso_8859_1): Remove decl.
7371 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7372 Now static.
7373
127198fd
PE
7374 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7375 * ccl.c (Vccl_program_table): Now static.
7376 (check_ccl_update): Remove; unused.
7377
d85b608f
PE
7378 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7379 * category.h: ... from here.
7380 * category.c (check_category_table, set_category_set): Now static.
7381
31cd66f3
PE
7382 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7383 * lisp.h: Remove these decls.
7384
c358e587
PE
7385 * buffer.c (buffer_count): Remove unused var.
7386
e78aecca
PE
7387 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7388 so that it's not optimized away.
7389 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7390 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7391 exported only to the debugger.
7392
e192d7d3 7393 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7394 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7395
92470028
PE
7396 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7397 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7398 was inaccessible from Lisp.
7399 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7400 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7401
244ed907
PE
7402 alloc.c: Import and export fewer symbols, and remove unused items.
7403 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7404 is defined.
7405 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7406 it's not optimized away by whole-program optimization.
7407 (message_enable_multibyte, free_misc): Remove.
7408 (catchlist, handlerlist, mark_backtrace):
7409 Declare only if BYTE_MARK_STACK.
7410 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7411 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7412 (message_enable_multibyte): Remove decl.
7413 (free_misc, interval_free_list, float_block, float_block_index):
7414 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7415 (cons_free_list, last_marked_index):
7416 Now static.
7417 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7418 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7419 (mark_backtrace): Define only if BYTE_MARK_STACK.
7420 * xdisp.c (message_enable_multibyte): Now static.
7421
61c2b50e 7422 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7423 This makes it easier for human readers (and static analyzers)
7424 to see whether these variables are used from other modules.
7425 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7426 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7427 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7428 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7429 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7430 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7431 * xmenu.c, xselect.c:
7432 Declare Q* vars static if they are not used in other modules.
7433 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7434 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7435 Remove decls of unexported vars.
7436 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7437
95c82688
PE
7438 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7439
16a97296
PE
7440 Make Emacs functions such as Fatom 'static' by default.
7441 This makes it easier for human readers (and static analyzers)
7442 to see whether these functions can be called from other modules.
7443 DEFUN now defines a static function. To make the function external
7444 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7445 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7446 (Finit_image_library):
16a97296
PE
7447 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7448 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7449 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7450 Remove decls, since these functions are now static.
7451 (Funintern, Fget_internal_run_time): New decls, since these functions
7452 were already external.
95c82688 7453
16a97296
PE
7454 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7455 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7456 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7457 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7458 * keyboard.c, keymap.c, lread.c:
7459 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7460 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7461 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7462 Mark functions with DEFUE instead of DEFUN,
7463 if they are used in other modules.
7464 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7465 decls for now-static functions.
7466 * buffer.h (Fdelete_overlay): Remove decl.
7467 * callproc.c (Fgetenv_internal): Mark as internal.
7468 * composite.c (Fremove_list_of_text_properties): Remove decl.
7469 (Fcomposition_get_gstring): New forward static decl.
7470 * composite.h (Fcomposite_get_gstring): Remove decl.
7471 * dired.c (Ffile_attributes): New forward static decl.
7472 * doc.c (Fdocumntation_property): New forward static decl.
7473 * eval.c (Ffetch_bytecode): New forward static decl.
7474 (Funintern): Remove extern decl; now in .h file where it belongs.
7475 * fileio.c (Fmake_symbolic_link): New forward static decl.
7476 * image.c (Finit_image_library): New forward static decl.
7477 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7478 * intervals.h (Fprevious_property_change):
7479 (Fremove_list_of_text_properties): Remove decls.
7480 * keyboard.c (Fthis_command_keys): Remove decl.
7481 (Fcommand_execute): New forward static decl.
7482 * keymap.c (Flookup_key): New forward static decl.
7483 (Fcopy_keymap): Now static.
7484 * keymap.h (Flookup_key): Remove decl.
7485 * process.c (Fget_process): New forward static decl.
7486 (Fprocess_datagram_address): Mark as internal.
7487 * syntax.c (Fsyntax_table_p): New forward static decl.
7488 (skip_chars): Remove duplicate decl.
7489 * textprop.c (Fprevious_property_change): New forward static decl.
7490 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7491 Now internal.
7492 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7493 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7494
785bbd42
PE
7495 * editfns.c (Fformat): Remove unreachable code.
7496
8b913b57
AS
74972011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7498
7499 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7500 change. (Bug#8496)
7501
a6744a35
EZ
75022011-04-13 Eli Zaretskii <eliz@gnu.org>
7503
7504 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7505 when at ZV. (Bug#8487)
7506
e7974947
AS
75072011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7508
baad03f0
AS
7509 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7510 (Bug#8437)
7511 * keyboard.c (parse_tool_bar_item): Likewise.
7512 * sound.c (sound_cleanup, alsa_close): Likewise.
7513 * termcap.c (tgetent): Likewise.
7514 * xfns.c (x_default_font_parameter): Likewise.
7515 * xsettings.c (read_and_apply_settings): Likewise.
7516
e7974947
AS
7517 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7518 (overrun_check_free): Protoize.
7519
28272684
PE
75202011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7521
7522 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7523 since callers should never pass a negative size.
7524 Change the signature to match that of plain 'read' and 'write'; see
7525 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7526 * lisp.h: Update prototypes of emacs_write and emacs_read.
7527
11997c76
EZ
75282011-04-11 Eli Zaretskii <eliz@gnu.org>
7529
7530 * xdisp.c (redisplay_window): Don't try to determine the character
7531 position of the scroll margin if the window start point w->startp
e896f03c 7532 is outside the buffer's accessible region. (Bug#8468)
11997c76 7533
8a2cbd72
EZ
75342011-04-10 Eli Zaretskii <eliz@gnu.org>
7535
7536 Fix write-region and its subroutines for buffers > 2GB.
7537 * fileio.c (a_write, e_write): Modify declaration of arguments and
7538 local variables to support buffers larger than 2GB.
7539 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7540
7541 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7542 argument, local variables, and return value.
7543
7544 * lisp.h: Update prototypes of emacs_write and emacs_read.
7545
7546 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7547
4073e537 75482011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7549
1ebfdcb6
PE
7550 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7551
b2ded58d
PE
7552 Fix more problems found by GCC 4.6.0's static checks.
7553
7d66342c
PE
7554 * xdisp.c (vmessage): Use a better test for character truncation.
7555
bbf47d44
PE
7556 * charset.c (load_charset_map): <, not <=, for optimization,
7557 and to avoid potential problems with integer overflow.
9248994d 7558 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7559 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7560 * editfns.c (Fformat): Likewise.
1e69125e 7561 * syntax.c (skip_chars): Likewise.
3befa583 7562
e3019616
PE
7563 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7564 This also lets GCC 4.6.0 generate slightly better loop code.
7565
becfa255
PE
7566 * callint.c (Fcall_interactively): <, not <=, for optimization.
7567 (Fcall_interactively): Count the number of arguments produced,
7568 not the number of arguments given. This is simpler and lets GCC
7569 4.6.0 generate slightly better code.
7570
dae0cd48
PE
7571 * ftfont.c: Distingish more carefully between FcChar8 and char.
7572 The previous code passed unsigned char * to a functions like
7573 strlen and xstrcasecmp that expect char *, which does not
7574 conform to the C standard.
7575 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7576 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7577 char * when the C standard requires it.
7578
76032d70
PE
7579 * keyboard.c (read_char): Remove unused var.
7580
eb3f1cc8
PE
7581 * eval.c: Port to Windows vsnprintf (Bug#8435).
7582 Include <limits.h>.
7583 (SIZE_MAX): Define if the headers do not.
7584 (verror): Do not give up if vsnprintf returns a negative count.
7585 Instead, grow the buffer. This ports to Windows vsnprintf, which
7586 does not conform to C99. Problem reported by Eli Zaretskii.
7587 Also, simplify the allocation scheme, by avoiding the need for
7588 calling realloc, and removing the ALLOCATED variable.
7589
70476b54
PE
7590 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7591
12020a9e
PE
7592 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7593 But keep the doprint source code for now, as we might revamp it
7594 and use it again (Bug#8435).
ea6c7ae6
PE
7595 * lisp.h (doprnt): Remove.
7596 * Makefile.in (base_obj): Remove doprnt.o.
7597 * deps.mk (doprnt.o): Remove.
7598
5fdb398c
PE
7599 error: Print 32- and 64-bit integers portably (Bug#8435).
7600 Without this change, on typical 64-bit hosts error ("...%d...", N)
7601 was used to print both 32- and 64-bit integers N, which relied on
7602 undefined behavior.
7603 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7604 New macro.
7605 * lisp.h (error, verror): Mark as printf-like functions.
7606 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7607 Report overflow in size calculations when allocating printf buffer.
7608 Do not truncate output string at its first null byte.
7609 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7610 Truncate the output at a character boundary, since vsnprintf does not
7611 do that.
7612 * charset.c (check_iso_charset_parameter): Convert internal
7613 character to string before calling 'error', since %c now has the
7614 printf meaning.
7615 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7616 overflow when computing char to be passed to 'error'. Do not
7617 pass Lisp_Object to 'error'; pass the integer instead.
7618 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7619 formatted with plain %d.
7620
b189fa66
PE
7621 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7622
bff87ef0
PE
7623 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7624
7e2cac20
PE
7625 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7626
ce4d90b5
PE
7627 * xterm.c (x_catch_errors): Remove duplicate declaration.
7628
266c9547
PE
7629 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7630
79c49ad2
PE
7631 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7632
368f4090
JM
76332011-04-10 Jim Meyering <meyering@redhat.com>
7634
7635 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7636 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7637 return ssize_t not "int", and use size_t as the buffer length.
7638 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7639 * gnutls.h: Update declarations.
7640 * process.c (read_process_output): Use ssize_t, to match.
7641 (send_process): Likewise.
7642
a32d4040
CY
76432011-04-09 Chong Yidong <cyd@stupidchicken.com>
7644
7645 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7646
8546720e 76472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7648
04f2d78b
CB
7649 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7650 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7651
8546720e
GM
7652 * xterm.c (handle_one_xevent):
7653 * xmenu.c (create_and_show_popup_menu):
7654 * xselect.c (x_decline_selection_request)
7655 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7656
0a2f5c1a 76572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7658
7659 Fix some uses of `int' instead of EMACS_INT.
7660 * search.c (string_match_1, fast_string_match)
7661 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7662 (scan_buffer, find_next_newline_no_quit)
7663 (find_before_next_newline, search_command, Freplace_match)
7664 (Fmatch_data): Make some `int' variables be EMACS_INT.
7665
7666 * xdisp.c (display_count_lines): 3rd argument and return value now
7667 EMACS_INT. All callers changed.
7668 (pint2hrstr): Last argument is now EMACS_INT.
7669
7670 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7671 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7672 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7673 (decode_coding_utf_16, decode_coding_emacs_mule)
7674 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7675 (decode_coding_ccl, decode_coding_charset)
7676 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7677 (decode_coding_iso_2022, decode_coding_emacs_mule)
7678 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7679 <char_offset, last_offset>: Declare EMACS_INT.
7680 (encode_coding_utf_8, encode_coding_utf_16)
7681 (encode_coding_emacs_mule, encode_invocation_designation)
7682 (encode_designation_at_bol, encode_coding_iso_2022)
7683 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7684 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7685 Declare EMACS_INT.
7686 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7687 (encode_invocation_designation): Last argument P_NCHARS is now
7688 EMACS_INT.
7689 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7690 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7691
7692 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7693 All users changed.
7694
7695 * ccl.c (Fccl_execute_on_string): Declare some variables
7696 EMACS_INT.
7697
8546720e 76982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7699
7700 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7701
4e19a977
CS
77022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7703
7704 * process.c (Fformat_network_address): Doc fix.
7705
87302331
R
77062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7707
ee7683eb 7708 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7709
cbb59342
CY
77102011-04-08 Chong Yidong <cyd@stupidchicken.com>
7711
7712 * keyboard.c (read_char): Call Lisp function help-form-show,
7713 instead of using internal_with_output_to_temp_buffer.
7714 (Qhelp_form_show): New var.
e0d38eeb 7715 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7716
7717 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7718
7719 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7720
e67a13ab
CY
77212011-04-06 Chong Yidong <cyd@stupidchicken.com>
7722
04f2d78b
CB
7723 * process.c (Flist_processes): Remove to Lisp.
7724 (list_processes_1): Delete.
e67a13ab 7725
973f782d
EZ
77262011-04-06 Eli Zaretskii <eliz@gnu.org>
7727
7c106b1e
EZ
7728 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7729
973f782d
EZ
7730 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7731
41cf7d1a 77322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7733
ca23cc88
PE
7734 Fix more problems found by GCC 4.6.0's static checks.
7735
f390e2d5
PE
7736 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7737
42eea0d0
PE
7738 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7739
b69769da 7740 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7741
f9541e84
PE
7742 * xdisp.c (vmessage): Mark as a printf-like function.
7743
13841b55
PE
7744 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7745
c136c10f
PE
7746 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7747
5e2d4a30
PE
7748 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7749 printf-like functions.
7750 (tiff_load): Add casts to remove these marks before passing them
7751 to system-supplied API.
7752
583f48b9
PE
7753 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7754
b25d760e
PE
7755 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7756 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7757 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7758 directly, rather than having caller test rule sign. This avoids
7759 some unnecessary tests.
7760 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7761 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7762 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7763
bc7b6697 7764 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7765 (xfont_open): Avoid unnecessary tests.
bc7b6697 7766
27ccc379
PE
7767 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7768
dcd5c89a
PE
7769 * composite.h, composite.c (composition_gstring_put_cache):
7770 Use EMACS_INT, not int, for length.
7771
b13a45c6
PE
7772 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7773 breaking out part of COMPOSITION_DECODE_RULE.
7774 (COMPOSITION_DECODE_RULE): Use it.
7775 * composite.c (get_composition_id): Remove unused local vars,
7776 by using the new macro.
7777
1e792e4d
PE
7778 * textprop.c (set_text_properties_1): Change while to do-while,
7779 since the condition is always true at first.
7780
dc6c6455 7781 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7782 (interval_deletion_adjustment): Return unsigned value.
7783 All uses changed.
dc6c6455 7784
aba7731a
PE
7785 * process.c (list_processes_1, create_pty, read_process_output):
7786 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7787 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7788 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7789 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7790 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7791
fdfc4bf3
PE
7792 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7793
fca8fe46 7794 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7795 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7796
06a0259a 7797 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7798 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7799 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7800
e7b9e80f
PE
7801 * print.c (print_error_message): Avoid int overflow.
7802
56201685
PE
7803 * font.c (font_list_entities): Redo for clarity,
7804 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7805
78834453 7806 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7807 (font_score): Avoid potential overflow in diff calculation.
78834453 7808
0bc0b309 7809 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7810 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7811
e610eaca
PE
7812 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7813
b895abce
PE
7814 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7815 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7816 can always succeed if overflow has undefined behavior.
7817
1f1d9321 7818 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7819 (wordify): Omit three unnecessary tests.
1f1d9321 7820
c59478bc
PE
7821 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7822 All callers changed. This avoids the need for an unused var.
7823
79b73827
PE
7824 * casefiddle.c (casify_region): Remove var that is set but not used.
7825
a4db5dfe
PE
7826 * dired.c (file_name_completion): Remove var that is set but not used.
7827
43aae36e
PE
7828 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7829
2a47c44d 7830 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7831 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7832
a37c69bf
PE
7833 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7834 Check for integer overflow on size calculations.
7835
328ab8e7
PE
7836 * buffer.c (Fprevious_overlay_change): Remove var that is set
7837 but not used.
7838
e5a2a5cb
PE
7839 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7840 Remove vars that are set but not used.
8d84a6eb 7841 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7842 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7843
a60e5f68
PE
7844 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7845
f661cb61 7846 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7847 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7848
f0397f5a
PE
7849 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7850 that are set but not used.
7851
8664db06 7852 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7853 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7854
6abdaa4a
PE
7855 * xselect.c (x_get_local_selection, x_handle_property_notify):
7856 Remove vars that are set but not used.
7857
0ce7538d 7858 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7859 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7860
9ae848fc
PE
7861 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7862 Remove var that is set but not used.
0b918413
PE
7863 (scroll_bar_windows_size): Now size_t, not int.
7864 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7865 Check for overflow.
9ae848fc 7866
a5a62657
PE
7867 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7868 (map_tty_color) [!defined MSDOS]: Likewise.
7869
5c5cdd39
PE
7870 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7871
66ebf983
PE
7872 * coding.c: Remove vars that are set but not used.
7873 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7874 All callers changed.
7875 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7876 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7877 (decode_coding_charset): Remove vars that are set but not used.
7878
1be4d761
PE
7879 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7880 that is set but not used.
7881
47553fa8
PE
7882 * print.c (print_object): Remove var that is set but not used.
7883
1f7196bf 7884 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7885 The gnulib version avoids calling malloc in the usual case,
7886 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7887 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7888 * filelock.c (current_lock_owner): Likewise.
7889 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7890 * sysdep.c: Include allocator.h, careadlinkat.h.
7891 (emacs_no_realloc_allocator): New static constant.
7892 (emacs_readlink): New function.
fdb61804
PE
7893 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7894 ../lib/careadlinkat.h.
d1fdcab7 7895
f84c17c7
SM
78962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7897
7898 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7899 first non-nil return value).
7900
ef3862ad
JD
79012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7902
7903 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7904 if not defined (Bug#8403).
7905
376a7006
JB
79062011-04-02 Juanma Barranquero <lekktu@gmail.com>
7907
7908 * xdisp.c (display_count_lines): Remove parameter `start',
7909 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7910 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7911 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7912 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7913 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7914 and thereabouts. All callers changed.
7915 (get_per_char_metric): Remove parameter `f', unused since
7916 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7917
6ca3801d
JM
79182011-04-02 Jim Meyering <meyering@redhat.com>
7919
7920 do not dereference NULL upon failed strdup
7921 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7922 (ns_get_family): Likewise.
7923
d8e2b5ba
JB
79242011-04-02 Juanma Barranquero <lekktu@gmail.com>
7925
7926 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7927
8c74fcbd
JD
79282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7929
7930 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7931 later (Bug#8403).
7932
7200d79c
SM
79332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7934
03408648 7935 Add lexical binding.
7200d79c 7936
03408648
SM
7937 * window.c (Ftemp_output_buffer_show): New fun.
7938 (Fsave_window_excursion):
7939 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7940
7941 * lread.c (lisp_file_lexically_bound_p): New function.
7942 (Fload): Bind Qlexical_binding.
7943 (readevalloop): Remove `evalfun' arg.
7944 Bind Qinternal_interpreter_environment.
7945 (Feval_buffer): Bind Qlexical_binding.
7946 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7947 Mark as dynamic.
7948 (syms_of_lread): Declare `lexical-binding'.
7949
7950 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7951
7952 * keyboard.c (eval_dyn): New fun.
7953 (menu_item_eval_property): Use it.
ca105506
SM
7954
7955 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7956
03408648
SM
7957 * fns.c (concat, mapcar1): Accept byte-code-functions.
7958
7959 * eval.c (Fsetq): Handle lexical vars.
7960 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7961 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7962 (FletX, Flet): Obey lexical binding.
7963 (Fcommandp): Handle closures.
7964 (Feval): New `lexical' arg.
7965 (eval_sub): New function extracted from Feval. Use it almost
7966 everywhere where Feval was used. Look up vars in lexical env.
7967 Handle closures.
7968 (Ffunctionp): Move from subr.el.
7969 (Ffuncall): Handle closures.
7970 (apply_lambda): Remove `eval_flags'.
7971 (funcall_lambda): Handle closures and new byte-code-functions.
7972 (Fspecial_variable_p): New function.
7973 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7974 but without exporting it to Lisp.
23aba0ea 7975
23aba0ea 7976 * doc.c (Fdocumentation, store_function_docstring):
03408648 7977 * data.c (Finteractive_form): Handle closures.
23aba0ea 7978
03408648
SM
7979 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7980 interactive spec.
ba83908c 7981
04f2d78b
CB
7982 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7983 New byte-codes.
03408648
SM
7984 (exec_byte_code): New function extracted from Fbyte_code to handle new
7985 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7986
03408648 7987 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7988
03408648 7989 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7990
e2abce01
JB
79912011-03-31 Juanma Barranquero <lekktu@gmail.com>
7992
7993 * xdisp.c (redisplay_internal): Fix prototype.
7994
63696a73 79952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7996
63696a73 7997 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7998 (try_scrolling): Use it when setting scroll_limit.
7999 Limit scrolling to 100 screen lines.
63696a73
EZ
8000 (redisplay_window): Even when falling back on "recentering",
8001 position point in the window according to scroll-conservatively,
8002 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8003
8004 (try_scrolling): When point is above the window, allow searching
8005 as far as scroll_max, or one screenful, to compute vertical
8006 distance from PT to the scroll margin position. This prevents
8007 try_scrolling from unnecessarily failing when
8008 scroll-conservatively is set to a value slightly larger than the
8009 window height. Clean up the case of PT below the margin at bottom
8010 of window: scroll_max can no longer be INT_MAX. When aggressive
8011 scrolling is in use, don't let point enter the opposite scroll
8012 margin as result of the scroll.
8013 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8014 threshold of 100 lines for never-recentering scrolling.
8015
e4cc2dfc
JB
80162011-03-31 Juanma Barranquero <lekktu@gmail.com>
8017
8018 * dispextern.h (move_it_by_lines):
8019 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8020 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8021 (message_log_check_duplicate): Remove parameters `prev_bol' and
8022 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8023 (redisplay_internal): Remove parameter `preserve_echo_area',
8024 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8025
8026 * indent.c (Fvertical_motion):
8027 * window.c (window_scroll_pixel_based, Frecenter):
8028 Don't pass `need_y_p' to `move_it_by_lines'.
8029
1c470562
SM
80302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8031
44f230aa
SM
8032 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8033 steal a few bits to be more compact.
8034 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8035 Remove unneeded casts.
8036
1c470562
SM
8037 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8038
888adce9
ZK
80392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8040
8041 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8042 binding" message (bug#7967).
8043
f838ed7b
PE
80442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8045
77861b95
PE
8046 Fix more problems found by GCC 4.6.0's static checks.
8047
de6dbc14
PE
8048 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8049 Remove unused local var.
8050
f838ed7b
PE
8051 * editfns.c (Fmessage_box): Remove unused local var.
8052
792c7b2b
PE
8053 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8054 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8055 Omit unused local vars.
c499e557 8056 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8057 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8058 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8059 Omit unused local var.
8060
ba0165e1
PE
8061 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8062 Don't assume string length fits in int.
32ad8845 8063 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8064 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8065
3c59b4c9
PE
8066 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8067 instead of alloca (Bug#8344).
8068
a3eed478 8069 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8070 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8071
eb4d412d
PE
8072 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8073
1658b401
PE
8074 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8075 concerns.
8076
8077 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8078
8079 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8080
9a2c6e05
PE
8081 * keyboard.c (syms_of_keyboard): Use the same style as later
8082 in this function when indexing through an array. This also
8083 works around GCC bug 48267.
8084
03d0a109
PE
8085 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8086
44f730c8
PE
8087 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8088
fe75f926
PE
8089 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8090 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8091
ffa8c828
PE
8092 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8093 This avoids undefined behavior on integer overflow, and is a bit
8094 more convenient anyway since it is compared to a size_t variable.
8095
c5101a77
PE
8096 Variadic C functions now count arguments with size_t, not int.
8097 This avoids an unnecessary limitation on 64-bit machines, which
8098 caused (substring ...) to crash on large vectors (Bug#8344).
8099 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8100 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8101 All variadic functions and their callers changed accordingly.
c5101a77
PE
8102 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8103 * data.c (arith_driver, float_arith_driver): Likewise.
8104 * editfns.c (general_insert_function): Likewise.
8105 * eval.c (struct backtrace.nargs, interactive_p)
8106 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8107 (funcall_lambda, mark_backtrace): Likewise.
8108 * fns.c (concat): Likewise.
8109 * frame.c (x_set_frame_parameters): Likewise.
8110 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8111 0 if not found, not -1. All callers changed.
8112
dd3f25f7
PE
8113 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8114 (stack_copy_size): Now size_t, not int.
8115 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8116
461c2ab9
JB
81172011-03-28 Juanma Barranquero <lekktu@gmail.com>
8118
8119 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8120 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8121 All callers changed.
8122
8123 * lisp.h (multibyte_char_to_unibyte):
8124 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8125 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8126 * character.h (CHAR_TO_BYTE8):
8127 * cmds.c (internal_self_insert):
8128 * editfns.c (general_insert_function):
8129 * keymap.c (push_key_description):
8130 * search.c (Freplace_match):
8131 * xdisp.c (message_dolog, set_message_1): All callers changed.
8132
f6d62986
SM
81332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8134
8135 * keyboard.c (safe_run_hook_funcall): New function.
8136 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8137 don't set the hook to nil, but remove the offending function instead.
8138 (Qcommand_hook_internal): Remove, unused.
8139 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8140 Vcommand_hook_internal.
8141
8142 * eval.c (enum run_hooks_condition): Remove.
8143 (funcall_nil, funcall_not): New functions.
8144 (run_hook_with_args): Call each function through a `funcall' argument.
8145 Remove `cond' argument, now redundant.
8146 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8147 (Frun_hook_with_args_until_failure): Adjust accordingly.
8148 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8149
1db5b1ad
JB
81502011-03-28 Juanma Barranquero <lekktu@gmail.com>
8151
8152 * dispextern.h (string_buffer_position): Remove declaration.
8153
8154 * print.c (strout): Remove parameter `multibyte', unused since
8155 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8156
8157 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8158 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8159 All callers changed.
8160
8161 * w32.c (_wsa_errlist): Use braces for struct initializers.
8162
8163 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8164 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8165 All callers changed.
8166 (string_buffer_position): Likewise. Also, make static (it's never
8167 used outside xdisp.c).
8168 (cursor_row_p): Remove parameter `w', unused since
8169 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8170 (decode_mode_spec): Remove parameter `precision', introduced during
8171 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8172 All callers changed.
8173
5ffb62aa
JD
81742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8175
8176 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8177
461c2ab9 81782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8179
8180 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8181 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8182 (ns_update_auto_hide_menu_bar): New functions.
8183 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8184 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8185 ns_constrain_all_frames.
8186 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8187 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8188
5c380ffb
JD
81892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8190
8191 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8192
9af30bdf
GM
81932011-03-27 Glenn Morris <rgm@gnu.org>
8194
8195 * syssignal.h: Replace RETSIGTYPE with void.
8196 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8197 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8198 Replace SIGTYPE with void everywhere.
8199 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8200 * s/template.h (SIGTYPE): Remove commented out definition.
8201
e2abce01
JB
82022011-03-26 Eli Zaretskii <eliz@gnu.org>
8203
8204 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8205 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8206
f868cd8a
JB
82072011-03-26 Juanma Barranquero <lekktu@gmail.com>
8208
59eb0929
JB
8209 * w32.c (read_unc_volume): Use parameter `henum', instead of
8210 global variable `wget_enum_handle'.
8211
8212 * keymap.c (describe_vector): Remove parameters `indices' and
8213 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8214 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8215
f868cd8a
JB
8216 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8217
8218 * keyboard.c (timer_check): Remove parameter `do_it_now',
8219 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8220 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8221 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8222
8223 * keyboard.c (read_char):
8224 * w32menu.c (w32_menu_display_help):
8225 * xmenu.c (show_help_event, menu_help_callback):
8226 Adjust calls to `show_help_echo'.
8227
8228 * gtkutil.c (xg_maybe_add_timer):
8229 * keyboard.c (readable_events):
8230 * process.c (wait_reading_process_output):
8231 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8232
8233 * insdel.c (adjust_markers_gap_motion):
8234 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8235 (gap_left, gap_right): Don't call it.
8236
2ecf6fdb
CY
82372011-03-25 Chong Yidong <cyd@stupidchicken.com>
8238
8239 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8240 incurred during fontification.
8241
6b1f9ba4
JB
82422011-03-25 Juanma Barranquero <lekktu@gmail.com>
8243
8244 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8245 (DEFVAR_PER_BUFFER): Don't pass it.
8246
8247 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8248 (scrolling_window): Don't pass it.
8249
0f4a96b5
JB
82502011-03-25 Juanma Barranquero <lekktu@gmail.com>
8251
8252 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8253
8254 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8255 and `suffix'.
8256 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8257 of variables specific to SELinux and computation of `encoded_absname'.
8258
8259 * image.c (XPutPixel): Remove unused variable `height'.
8260
8261 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8262
8263 * unexw32.c (get_section_info): Remove unused variable `section'.
8264
8265 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8266 (system_process_attributes): Remove unused variable `sess'.
8267 (sys_read): Remove unused variable `err'.
8268
8269 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8270 (w32_wnd_proc): Remove unused variable `isdead'.
8271 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8272 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8273 (x_create_tip_frame): Remove unused variable `tem'.
8274
8275 * w32inevt.c (w32_console_read_socket):
8276 Remove unused variable `no_events'.
8277
8278 * w32term.c (x_draw_composite_glyph_string_foreground):
8279 Remove unused variable `width'.
8280
1149507c
JB
82812011-03-24 Juanma Barranquero <lekktu@gmail.com>
8282
8283 * w32term.c (x_set_glyph_string_clipping):
8284 Don't pass uninitialized region to CombineRgn.
8285
9c88f339
JB
82862011-03-23 Juanma Barranquero <lekktu@gmail.com>
8287
8288 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8289 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8290 (Fx_close_connection): Remove unused variable `i'.
8291
8292 * w32font.c (w32font_draw): Return number of glyphs.
8293 (w32font_open_internal): Remove unused variable `i'.
8294 (w32font_driver): Add missing initializer.
8295
8296 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8297 (fill_in_menu): Remove unused variable `items_added'.
8298
8299 * w32term.c (last_mouse_press_frame): Remove static global variable.
8300 (w32_clip_to_row): Remove unused variable `f'.
8301 (x_delete_terminal): Remove unused variable `i'.
8302
8303 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8304 (NOTHING): Remove unused static global variable.
8305 (uniscribe_check_otf): Remove unused variable `table'.
8306 (uniscribe_font_driver): Add missing initializers.
8307
dee091a3
JD
83082011-03-23 Julien Danjou <julien@danjou.info>
8309
8310 * term.c (Fsuspend_tty, Fresume_tty):
8311 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8312 * window.c (temp_output_buffer_show):
8313 * insdel.c (signal_before_change):
8314 * frame.c (Fhandle_switch_frame):
8315 * fileio.c (Fdo_auto_save):
8316 * emacs.c (Fkill_emacs):
8317 * editfns.c (save_excursion_restore):
8318 * cmds.c (internal_self_insert):
8319 * callint.c (Fcall_interactively):
8320 * buffer.c (Fkill_all_local_variables):
8321 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8322 Use Frun_hooks.
0f4a96b5 8323 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8324 unconditionally since it does the check itself.
dee091a3 8325
2c520ab5 83262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8327
c9c49752
PE
8328 Fix more problems found by GCC 4.5.2's static checks.
8329
8abc3f12
PE
8330 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8331 the first time through the loop, since we know p0 < p1 then.
8332 This also avoids a gcc -Wstrict-overflow warning.
8333
a2d26660
PE
8334 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8335 leading to a memory leak, possible in functions like
8336 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8337 of objects (Bug#8318).
a2d26660 8338
916c72e9
PE
8339 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8340 that could (at least in theory) be that large.
8341
19ab8a18
PE
8342 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8343 This is less likely to overflow, and avoids undefined behavior if
8344 overflow does occur. All callers changed. Use strtoul to scan
8345 for the unsigned long integer.
b7cbbd6f
PE
8346 (pint2hrstr): Simplify and tune code slightly.
8347 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8348
f0641eff
PE
8349 * scroll.c (do_scrolling): Work around GCC bug 48228.
8350 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8351
7f650bb9
PE
8352 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8353 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8354 (validate_x_resource_name): Simplify count usage.
8355 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8356
37dd57d1
PE
8357 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8358 fail (Bug#8306).
81e56e61 8359
699979fc 8360 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8361
401bf9b4
PE
8362 * process.c (Fmake_network_process): Use socklen_t, not int,
8363 where POSIX says socklen_t is required in portable programs.
8364 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8365 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8366 (Fmake_network_process, server_accept_connection):
8367 (wait_reading_process_output, read_process_output):
8368 Likewise.
8369
b93aacde
PE
8370 * process.c: Rename or move locals to avoid shadowing.
8371 (list_processes_1, Fmake_network_process):
8372 (read_process_output_error_handler, exec_sentinel_error_handler):
8373 Rename or move locals.
4dc343ee 8374 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8375 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8376 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8377 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8378 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8379
af8a867c 8380 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8381 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8382 Include tparam.h instead, since it declares them.
af8a867c
PE
8383 * cm.h (PC): Remove extern decl; tparam.h now does this.
8384 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8385 * terminfo.c: Include tparam.h, to check interfaces.
8386 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8387 (tparam): Adjust signature to match interface in tparam.h;
8388 this removes some undefined behavior. Check that outstring and len
8389 are zero, which they always are with Emacs.
8390 * tparam.h (PC, BC, UP): New extern decls.
8391
0248044d 8392 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8393 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8394
8ff096c1 8395 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8396 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8397 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8398 (ftfont_list): Remove unused local.
49eaafba
PE
8399 (get_adstyle_property, ftfont_pattern_entity):
8400 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8401 Rename locals to avoid shadowing.
8ff096c1 8402
e2be39f6
PE
8403 * xfont.c (xfont_list_family): Mark var as initialized.
8404
c9735e30
PE
8405 * xml.c (make_dom): Now static.
8406
8f5201ae
PE
8407 * composite.c (composition_compute_stop_pos): Rename local to
8408 avoid shadowing.
b246f932
PE
8409 (composition_reseat_it): Remove unused locals.
8410 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8411 (composition_update_it): Mark var as initialized.
11b61122
PE
8412 (find_automatic_composition): Mark vars as initialized,
8413 with a FIXME (Bug#8290).
8f5201ae 8414
760fbc2c
PE
8415 character.h: Rename locals to avoid shadowing.
8416 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8417 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8418 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8419 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8420 to avoid shadowing.
8421
ff08eb85
PE
8422 * textprop.c (property_change_between_p): Remove; unused.
8423
fc7bf025
PE
8424 * intervals.c (interval_start_pos): Now static.
8425
235d7abc
PE
8426 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8427
44f230aa
SM
8428 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8429 Rename locals to avoid shadowing.
3e7d6594 8430
50060332
PE
8431 * sound.c (wav_play, au_play, Fplay_sound_internal):
8432 Fix pointer signedness.
d01f234b 8433 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8434 (wav_play): Initialize a variable to 0, to prevent undefined
8435 behavior (Bug#8278).
50060332 8436
c4fc4e30
PE
8437 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8438
918436ed
PE
8439 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8440
c939f91b
PE
8441 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8442 clobbering (Bug#8298).
b9c7f648
PE
8443 * sysdep.c (sys_subshell): Likewise.
8444 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8445
6bd8c144
PE
8446 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8447 This should get cleaned up, so that child_setup has the
8448 same signature on all platforms.
8449
7710357c 8450 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8451 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8452
c59da222
CY
84532011-03-22 Chong Yidong <cyd@stupidchicken.com>
8454
8455 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8456 not to be necessary, and produces flickering.
8457
66b87493
GM
84582011-03-20 Glenn Morris <rgm@gnu.org>
8459
8460 * config.in: Remove file.
8461
45b6f6d5
JB
84622011-03-20 Juanma Barranquero <lekktu@gmail.com>
8463
8464 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8465 are now in src/globals.h.
8466 (syms_of_minibuf): Remove spurious & from previous change.
8467
cd394be1 84682011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8469
8470 * minibuf.c (completing-read-function): New variable.
8471 (completing-read-default): Rename from completing-read.
8472 (completing-read): Call completing-read-function.
8473
b14e3e21
CY
84742011-03-19 Juanma Barranquero <lekktu@gmail.com>
8475
8476 * xfaces.c (Fx_load_color_file):
8477 Read color file from absolute filename (bug#8250).
8478
f2b726e6
JB
84792011-03-19 Juanma Barranquero <lekktu@gmail.com>
8480
8481 * makefile.w32-in: Update dependencies.
8482
09f6ff02
EZ
84832011-03-17 Eli Zaretskii <eliz@gnu.org>
8484
8485 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8486
29a6015a
PE
84872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8488
a3a6c54e
PE
8489 Fix more problems found by GCC 4.5.2's static checks.
8490
b766f867
PE
8491 * process.c (make_serial_process_unwind, send_process_trap):
8492 (sigchld_handler): Now static.
8493
be02381c
PE
8494 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8495 That way, the code declares only the vars that it needs.
8496 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8497 * s/cygwin.h (PTY_ITERATION): Likewise.
8498 * s/darwin.h (PTY_ITERATION): Likewise.
8499 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8500
57048744
PE
8501 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8502 * process.c (allocate_pty): Don't declare stb unless it's needed.
8503
7914961c 8504 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8505 (CONSTANTLIM): Remove; unused.
8506 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8507 Define only if needed.
7914961c 8508
b3967b18
PE
8509 * unexelf.c (unexec): Name an expression,
8510 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8511 Use a different way to cause a compilation error if anyone uses
8512 n rather than nn, a way that does not involve shadowing.
73366a00 8513 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8514
29a6015a
PE
8515 * deps.mk (unexalpha.o): Remove; unused.
8516
43cfc33e 8517 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8518 * unexec.h: New file.
ce701a33
PE
8519 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8520 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8521 Depend on unexec.h.
8522 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8523 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8524 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8525 Change as necessary to match prototype in unexec.h.
ce701a33 8526
01f44d5a
PE
8527 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8528 shadowing.
4f63c6bb 8529 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8530
a6670b0b
PE
8531 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8532 Rename locals to avoid shadowing.
8533
cef2010d 8534 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8535 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8536
d4d7173a
PE
8537 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8538
f08b802a
PE
8539 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8540 warning when compiling print.c.
8541
3ddb0639
PE
8542 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8543 instead of using an uninitialized var.
5ad03b97 8544 (font_sort_entities): Mark var as initialized.
3ddb0639 8545
170a2692
PE
8546 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8547
e663c700
PE
8548 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8549 pointers to constants.
89bc529a 8550 (font_parse_fcname): Remove unused vars.
7b81e2d0 8551 (font_delete_unmatched): Now static.
ea838e10 8552 (font_get_spec): Remove; unused.
13a547c6
PE
8553 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8554 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8555 Rename or move locals to avoid shadowing.
e663c700 8556
2a80c887 8557 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8558 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8559
1384fa33 8560 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8561 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8562
8b2c52e9
PE
8563 * alloc.c (mark_backtrace): Move decl from here ...
8564 * lisp.h: ... to here, so that it can be checked.
8565
475545b5 8566 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8567 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8568 (lisp_indirect_variable): Name an expression,
8569 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8570 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8571
b1349114 8572 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8573 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8574 Use const pointer when appropriate.
b1349114 8575
a2928364
PE
8576 * lisp.h (get_system_name, get_operating_system_release):
8577 Move decls here, to check interfaces.
8578 * process.c (get_operating_system_release): Move decl to lisp.h.
8579 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8580 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8581 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8582 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8583 (Fformat_time_string, Fencode_time, Finsert_char):
8584 (Ftranslate_region_internal, Fformat):
8585 Rename or remove local vars to avoid shadowing.
9710023e 8586 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8587
a415e694
PE
8588 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8589 avoid shadowing.
8590
8ef4622d
PE
8591 * lisp.h (eassert): Check that the argument compiles, even if
8592 ENABLE_CHECKING is not defined.
8593
946f9a5b
PE
8594 * data.c (Findirect_variable): Name an expression, to avoid
8595 gcc -Wbad-function-cast warning.
112396d6 8596 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8597 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8598 (Fmake_variable_buffer_local, Fmake_local_variable):
8599 Mark variables as initialized.
52746918 8600 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8601
e5aab7e7 8602 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8603 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8604 Rename locals to avoid shadowing.
dff45157
PE
8605 (mark_stack): Move local variables into the #ifdef region where
8606 they're used.
7bc26fdb
PE
8607 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8608 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8609 needed otherwise.
8610 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8611 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8612 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8613
e5aab7e7
PE
8614 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8615 avoids undefined behavior in theory.
8616
4da60324
PE
8617 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8618
88043301
PE
8619 Use functions, not macros, for up- and down-casing (Bug#8254).
8620 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8621 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8622 to use the following functions instead of these macros.
8623 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8624 EMACS_INT, since callers assume the returned value fits in int.
8625 (upcase1): Likewise, for UPCASE_TABLE.
8626 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8627 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8628 the race-condition problem in the old DOWNCASE.
88043301 8629
19ed5445
PE
8630 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8631 Rename locals to avoid shadowing.
8632 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8633 (regex_compile, re_search_2, re_match_2_internal):
8634 Remove unused local vars.
952db0d7
PE
8635 (FREE_VAR): Rewrite so as not to use empty "else",
8636 which gcc can warn about.
da053e48 8637 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8638 (RETALLOC_IF): Define only if needed.
8639 (WORDCHAR_P): Likewise. This one is never needed, but is used
8640 only in a comment talking about a compiler bug, so put inside
8641 the #if 0 of that comment.
8642 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8643 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8644 Remove; unused.
19ed5445 8645
1f3561e4 8646 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8647 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8648 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8649
ded6f8f7
PE
8650 * search.c (simple_search): Remove unused var.
8651
dbd37a95
PE
8652 * dired.c (compile_pattern): Move decl from here ...
8653 * lisp.h: ... to here, so that it can be checked.
8654 (struct re_registers): New forward decl.
8655
7e47afad
PE
8656 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8657
85f24f61
PE
8658 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8659 All uses changed.
8660 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8661 Rename locals to avoid shadowing.
5671df8f 8662 (Fvertical_motion): Mark locals as initialized.
85f24f61 8663
181aa2be 8664 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8665 (casify_region): Mark local as initialized.
181aa2be 8666
930d429c
PE
8667 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8668
7082eac6
PE
8669 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8670 New macros, so that the caller can use some names other than
8671 gcpro1, gcpro2, etc.
8672 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8673 of the new macros.
8674 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8675 argument, for consistency with GCPRO2_VAR, etc: it is now the
8676 prefix of the variable, not the variable itself. All uses
8677 changed.
38b2c076
PE
8678 * dired.c (directory_files_internal, file_name_completion):
8679 Rename locals to avoid shadowing.
8680
15206ed9
PE
8681 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8682 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8683 dired.c's scmp function, had undefined behavior.
8684 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8685 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8686 * buffer.h: ... to here, because these macros use current_buffer,
8687 and the new implementation with inline functions needs to have
8688 current_buffer in scope now, rather than later when the macros
8689 are used.
8690 (downcase, upcase1): New static inline functions.
8691 (DOWNCASE, UPCASE1): Reimplement using these functions.
8692 This avoids undefined behavior in expressions like
8693 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8694 from race conditions in accessing the global variables
8695 case_temp1 and case_temp2.
8696 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8697 * lisp.h (case_temp1, case_temp2): Remove their decls.
8698 * character.h (ASCII_CHAR_P): Move from here ...
8699 * lisp.h: ... to here, so that the inline functions mentioned
8700 above can use them.
8701
4a6bea26
PE
8702 * dired.c (directory_files_internal_unwind): Now static.
8703
f14b7e14
PE
8704 * fileio.c (file_name_as_directory, directory_file_name):
8705 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8706 Now static.
2893f146
PE
8707 (file_name_as_directory): Use const pointers when appropriate.
8708 (Fexpand_file_name): Likewise. In particular, newdir might
8709 point at constant storage, so make it a const pointer.
fd4ead52 8710 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8711 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8712 signedness issues.
f839df0c
PE
8713 (Fset_file_times, Finsert_file_contents, auto_save_error):
8714 Rename locals to avoid shadowing.
f14b7e14 8715
5716756e 8716 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8717 (Ftry_completion, Fall_completions): Rename or remove locals
8718 to avoid shadowing.
5716756e 8719
b4c3046a
PE
8720 * marker.c (bytepos_to_charpos): Remove; unused.
8721
b45db522
PE
8722 * lisp.h (verify_bytepos, count_markers): New decls,
8723 so that gcc does not warn that these functions aren't declared.
8724
85876d07
PE
8725 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8726 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8727 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8728 (copy_text): Remove unused local var.
85876d07 8729
03d78a21 8730 * filelock.c (within_one_second): Now static.
b3dd38ab 8731 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8732
5df8f01b
PE
8733 * buffer.c (fix_overlays_before): Mark locals as initialized.
8734 (fix_start_end_in_overlays): Likewise. This function should be
8735 simplified by using pointers-to-pointers, but that's a different
8736 matter.
b1d876f1 8737 (switch_to_buffer_1): Now static.
8f54f30a
PE
8738 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8739 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8740
a70072c9 8741 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8742 Fix pointer signedness issue.
edced198
PE
8743 (sys_subshell): Mark local as volatile if checking for lint,
8744 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8745 (MAXPATHLEN): Define only if needed.
a70072c9 8746
a0977c44
PE
8747 * process.c (serial_open, serial_configure): Move decls from here ...
8748 * systty.h: ... to here, so that they can be checked.
8749
a884fdcc
PE
8750 * fns.c (get_random, seed_random): Move extern decls from here ...
8751 * lisp.h: ... to here, so that they can be checked.
8752
604efe86 8753 * sysdep.c (reset_io): Now static.
b8950c94 8754 (wait_for_termination_signal): Remove; unused.
604efe86 8755
38fc62d9
PE
8756 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8757 (copy_keymap_item, append_key, push_text_char_description):
8758 Now static.
1004a21a 8759 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8760 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8761 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8762 (describe_map_tree):
8763 Rename locals to avoid shadowing.
38fc62d9 8764
2f2650da
PE
8765 * keyboard.c: Declare functions static if they are not used elsewhere.
8766 (echo_char, echo_dash, cmd_error, top_level_2):
8767 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8768 (read_char, kbd_buffer_get_event, make_lispy_position):
8769 (make_lispy_event, make_lispy_movement, apply_modifiers):
8770 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8771 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8772 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8773 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8774 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8775
a053e86c 8776 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8777 (mark_kboards): Move decl here ...
8778 * alloc.c (mark_kboards): ... from here.
a053e86c 8779
4752793e
PE
8780 * lisp.h (force_auto_save_soon): New decl.
8781
74f10ca7 8782 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8783 (DEFINE_DUMMY_FUNCTION): New macro.
8784 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8785 Use it.
c03cd23f
PE
8786 (main): Add casts to avoid warnings
8787 if GCC considers string literals to be constants.
74f10ca7 8788
022e70d4
PE
8789 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8790
59d6fe83
PE
8791 * dbusbind.c: Pointer signedness fixes.
8792 (xd_signature, xd_append_arg, xd_initialize):
8793 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8794 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8795 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8796 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8797
78320123
PE
8798 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8799 if GCC considers string literals to be constants.
49cebcca 8800 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8801
35ac2a97
SM
88022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8803
fb103ca9
SM
8804 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8805 (print_preprocess, print_object): New macro to fix last change.
8806
35ac2a97
SM
8807 * print.c (print_preprocess): Don't forget font objects.
8808
62973b41
JB
88092011-03-16 Juanma Barranquero <lekktu@gmail.com>
8810
8811 * emacs.c (USAGE3): Doc fixes.
8812
0e48bb22
AS
88132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8814
8815 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8816 structure.
8817
7684e57b
JB
88182011-03-14 Juanma Barranquero <lekktu@gmail.com>
8819
8820 * lisp.h (VWindow_system, Qfile_name_history):
8821 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8822 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8823 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8824
8825 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8826 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8827
8828 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8829 * w32console.c (detect_input_pending, read_input_pending)
8830 (encode_terminal_code):
8831 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8832 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8833 (w32_system_caret_y, Qfile_name_history):
8834 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8835 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8836 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8837 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8838 * w32proc.c (Qlocal, report_file_error):
8839 * w32term.c (Vwindow_system, updating_frame):
8840 * w32uniscribe.c (initialized, uniscribe_font_driver):
8841 Remove unneeded extern declarations.
8842
2aa46d6c
CY
88432011-03-14 Chong Yidong <cyd@stupidchicken.com>
8844
c96bbc66 8845 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8846
cffc6f3b
CY
88472011-03-13 Chong Yidong <cyd@stupidchicken.com>
8848
8849 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8850 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8851 These macros can no longer be used for assignment.
8852
44f230aa
SM
8853 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8854 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8855 (record_buffer_markers, fetch_buffer_markers): New functions for
8856 recording and fetching special buffer markers.
8857 (set_buffer_internal_1, set_buffer_temp): Use them.
8858
8859 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8860
8861 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8862
8863 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8864 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8865
8866 * xdisp.c (hscroll_window_tree):
8867 (reconsider_clip_changes): Use PT instead of BUF_PT.
8868
d251f04b
EZ
88692011-03-13 Eli Zaretskii <eliz@gnu.org>
8870
8871 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8872 $(EMACS_ROOT)/lib/intprops.h.
8873
f0c77cd1
PE
88742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8875
3eca4629
PE
8876 Fix more problems found by GCC 4.5.2's static checks.
8877
7c86ee98
PE
8878 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8879 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8880 (xg_free_frame_widgets): Make it clear that a local variable is
8881 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8882 (gdk_window_get_screen): Make it clear that this macro is needed
8883 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8884 (int_gtk_range_get_value): New function, which avoids a diagnostic
8885 from gcc -Wbad-function-cast.
8886 (xg_set_toolkit_scroll_bar_thumb): Use it.
8887 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8888 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8889 (get_utf8_string, xg_get_file_with_chooser):
8890 Rename locals to avoid shadowing.
8891 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8892
41729b81
PE
8893 * xgselect.c (xg_select): Remove unused var.
8894
f0c77cd1
PE
8895 * image.c (four_corners_best): Mark locals as initialized.
8896 (gif_load): Initialize transparent_p to zero (Bug#8238).
8897 Mark another local as initialized.
ec6cf4c6 8898 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8899
ce0ad53d 8900 * image.c (clear_image_cache): Now static.
d5d5a617 8901 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8902 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8903 (x_edge_detection): Remove unnecessary cast that
8904 gcc -Wbad-function-cast diagnoses.
2037898d 8905 (gif_load): Fix pointer signedness.
6ae141d6
PE
8906 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8907 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8908
33383987 89092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8910
d32df629
PE
8911 Improve quality of tests for time stamp overflow.
8912 For example, without this patch (encode-time 0 0 0 1 1
8913 1152921504606846976) returns the obviously-bogus value (-948597
8914 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8915 reports time overflow. See
8916 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8917 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8918 * editfns.c: Include limits.h and intprops.h.
8919 (TIME_T_MIN, TIME_T_MAX): New macros.
8920 (time_overflow): Move earlier, to before first use.
8921 (hi_time, lo_time): New functions, for an accurate test for
8922 out-of-range times.
8923 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8924 (Fget_internal_run_time): Don't assume time_t fits in int.
8925 (make_time): Use list2 instead of Fcons twice.
8926 (Fdecode_time): More accurate test for out-of-range times.
8927 (check_tm_member): New function.
8928 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8929 (lisp_time_argument): Don't rely on undefined left-shift and
8930 right-shift behavior when checking for time stamp overflow.
8be6f318 8931
fe31d94c
PE
8932 * editfns.c (time_overflow): New function, refactoring common code.
8933 (Fformat_time_string, Fdecode_time, Fencode_time):
8934 (Fcurrent_time_string): Use it.
8935
8be6f318
PE
8936 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8937 * dired.c (make_time): Move to ...
8938 * editfns.c (make_time): ... here.
8939 * systime.h: Note the move.
8940
09d9db2c 89412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8942
126bc0dc
YM
8943 * fringe.c (update_window_fringes): Remove unused variables.
8944
c47cbdfd
YM
8945 * unexmacosx.c (copy_data_segment): Also copy __got section.
8946 (Bug#8223)
8947
7ac80be9
EZ
89482011-03-12 Eli Zaretskii <eliz@gnu.org>
8949
c96bbc66 8950 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8951 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8952 Constify `char *' arguments and their references according to
8953 prototypes in tparam.h.
8954
ecb0f94d 8955 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8956
7ac80be9
EZ
8957 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8958 Adapt all references accordingly.
8959
8960 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8961
ef1fd07e
TT
89622011-03-11 Tom Tromey <tromey@redhat.com>
8963
8964 * buffer.c (syms_of_buffer): Remove obsolete comment.
8965
7ef4b50c
EZ
89662011-03-11 Eli Zaretskii <eliz@gnu.org>
8967
8968 * termhooks.h (encode_terminal_code): Declare prototype.
8969
8970 * msdos.c (encode_terminal_code): Don't declare prototype.
8971
8972 * term.c (encode_terminal_code): Now external again, used by
8973 w32console.c and msdos.c.
8974
44f230aa
SM
8975 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8976 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8977
4b1ec863 89782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8979
1714f52b 8980 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8981
4b1ec863
PE
8982 * fringe.c (update_window_fringes): Mark locals as initialized
8983 (Bug#8227).
8984 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8985
524c7aa6
PE
8986 * alloc.c (mark_fringe_data): Move decl from here ...
8987 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8988 to check its interface.
8989 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8990
a5c0af81 8991 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8992 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8993 (fontset_font): Mark local as initialized.
a9a06e0b 8994 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8995
b4716021
PE
8996 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8997
811e9bac 8998 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8999 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9000 (x_own_selection, Fx_disown_selection_internal): Rename locals
9001 to avoid shadowing.
9002 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9003
7e3ab302
PE
9004 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9005 so that the caller can use some name other than gcpro1.
9006 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9007 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9008 (Fx_backspace_delete_keys_p):
9009 Use them to avoid shadowing, and rename vars to avoid shadowing.
9010 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9011 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9012 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9013 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9014 Remove unused locals.
7e3ab302
PE
9015 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9016 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9017 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9018 macros.
f78faa98 9019
e2b13473
PE
9020 * xterm.h (x_mouse_leave): New decl.
9021
77f23912
PE
9022 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9023 Remove unused functions.
cdf4ba58
PE
9024 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9025 (x_calc_absolute_position): Now static.
7411c686 9026 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9027 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9028 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9029 unless they are used.
38d0b34a
PE
9030 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9031 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9032 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9033 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9034 (x_error_catcher, x_connection_closed, x_error_handler):
9035 (x_error_quitter, xembed_send_message, x_iconify_frame):
9036 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9037 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9038 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9039
44f230aa
SM
9040 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9041 Rename or move locals to avoid shadowing.
6b463e58 9042 (tty_defined_color, merge_face_heights): Now static.
5967d051 9043 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9044 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9045 does not deduce is never used uninitialized.
73719eba
PE
9046 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9047 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9048
426994c3 9049 * terminal.c (store_terminal_param): Now static.
5489860b 9050
032f1620 9051 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9052 (set_frame_menubar): Remove unused local.
d4323972 9053 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9054 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9055 since they might point to immutable storage.
281585b0
PE
9056 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9057 since it's unused otherwise.
032f1620 9058
367c19e5 9059 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9060 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9061 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9062 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9063 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9064 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9065 does not deduce are never used uninitialized.
70739cbe 9066
07b48fa9
PE
9067 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9068
8868a238 9069 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9070 * window.c (window_loop, size_window):
9071 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9072
7e5cf297 9073 * window.c (display_buffer): Now static.
d6550a9f
PE
9074 (size_window): Mark variables that gcc -Wuninitialized
9075 does not deduce are never used uninitialized.
a586633d
PE
9076 * window.h (check_all_windows): New decl, to forestall
9077 gcc -Wmissing-prototypes diagnostic.
5b555da1 9078 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9079
f6095868
PE
9080 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9081 shadowing.
9082 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9083 Include <limits.h>.
9084 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9085 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9086 (load_charset_map): Mark variables that gcc -Wuninitialized
9087 does not deduce are never used uninitialized.
53df7c11 9088 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9089
f38b440c
PE
9090 * coding.c (coding_set_source, coding_set_destination):
9091 Use "else { /* comment */ }" rather than "else /* comment */;"
9092 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9093 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9094 a block, when the outer 'i' will do.
9095 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9096 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9097 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9098 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9099 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9100 Rename locals to avoid shadowing.
9101 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9102 * coding.c (emacs_mule_char, encode_invocation_designation):
9103 Now static, since they're not used elsewhere.
413bb2db 9104 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9105 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9106 (decode_coding_emacs_mule): Mark variables that gcc
9107 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9108 (detect_coding_iso_2022): Initialize a local variable that might
9109 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9110 this initialization is needed. (Bug#8211)
5f58e762
PE
9111 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9112 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9113 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9114 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9115 Remove unused macros.
f38b440c 9116
232b38b9 9117 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9118 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9119 * character.c (string_count_byte8): Likewise.
232b38b9 9120
fb90da1b
PE
9121 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9122 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9123
fb93dbc2
PE
9124 * chartab.c (copy_sub_char_table): Now static, since it's not used
9125 elsewhere.
5c156ace
PE
9126 (sub_char_table_ref_and_range, char_table_ref_and_range):
9127 Rename locals to avoid shadowing.
bbcd0949 9128 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9129
7d3b3862 9130 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9131 (BIDI_BOB): Remove unused macro.
7d3b3862 9132
6be7d3da
PE
9133 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9134 deduce are never used uninitialized.
c2ed9c8b 9135 * term.c (encode_terminal_code): Likewise.
6be7d3da 9136
75f8807f 9137 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9138
50938595
PE
9139 * tparam.h: New file.
9140 * term.c, tparam.h: Include it.
9141 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9142 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9143 Move these decls to tparam.h, and make them agree with what
9144 is actually in tparam.c. The previous trick of using incompatible
9145 decls in different modules does not conform to the C standard.
9146 All callers of tparam changed to use tparam's actual API.
9147 * tparam.c (tparam1, tparam, tgoto):
9148 Use const pointers where appropriate.
9149
fbceeba2
PE
9150 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9151 * cm.h (struct cm): Likewise.
9152 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9153 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9154 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9155 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9156 (turn_on_face, init_tty): Likewise.
9157 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9158
7f3f1250
PE
9159 * term.c (term_mouse_position): Rename local to avoid shadowing.
9160
e6ca6543
PE
9161 * alloc.c (mark_ttys): Move decl from here ...
9162 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9163
c40f8d15
AS
91642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9165
9166 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9167
cfe0661d
JB
91682011-03-09 Juanma Barranquero <lekktu@gmail.com>
9169
9170 * search.c (compile_pattern_1): Remove argument regp, unused since
9171 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9172 (compile_pattern): Don't pass it.
9173
0afb4571
J
91742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9175
9176 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9177 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9178 for ! HAVE_GTK3.
9179 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9180
9181 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9182
9183 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9184 gdk_window_get_screen, gdk_window_get_geometry,
9185 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9186 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9187 (xg_get_pixbuf_from_pixmap): New function.
9188 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9189 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9190 Call xg_get_pixbuf_from_pixmap instead of
9191 gdk_pixbuf_get_from_drawable.
9192 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9193 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9194 (xg_check_special_colors): Use GtkStyleContext and its functions
9195 for HAVE_GTK3.
9196 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9197 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9198 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9199 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9200 Call gtk_widget_get_preferred_size.
0afb4571
J
9201 (xg_frame_resized): gdk_window_get_geometry only takes 5
9202 parameters.
44f230aa
SM
9203 (xg_win_to_widget, xg_event_is_for_menubar):
9204 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9205 (xg_set_widget_bg): New function.
9206 (delete_cb): New function.
895009e1 9207 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9208 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9209 (xg_set_background_color): Call xg_set_widget_bg.
9210 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9211 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9212 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9213 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9214 if ! HAVE_GTK3.
9215 (update_frame_tool_bar): Call gtk_widget_hide.
9216 (xg_initialize): Use GDK_KEY_g.
9217
9218 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9219 if ! HAVE_GTK3
9220 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9221
9222 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9223 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9224 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9225
1c2cc4ef
JB
92262011-03-08 Juanma Barranquero <lekktu@gmail.com>
9227
9228 * w32xfns.c (select_palette): Check success of RealizePalette against
9229 GDI_ERROR, not zero.
9230
33383987 9231See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9232
9233;; Local Variables:
9234;; coding: utf-8
aac0c6e3
MR
9235;; End:
9236
acaf905b 9237 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9238
9239 This file is part of GNU Emacs.
9240
9241 GNU Emacs is free software: you can redistribute it and/or modify
9242 it under the terms of the GNU General Public License as published by
9243 the Free Software Foundation, either version 3 of the License, or
9244 (at your option) any later version.
9245
9246 GNU Emacs is distributed in the hope that it will be useful,
9247 but WITHOUT ANY WARRANTY; without even the implied warranty of
9248 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9249 GNU General Public License for more details.
9250
9251 You should have received a copy of the GNU General Public License
9252 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.