Clarify documentation of wrap-prefix and line-prefix.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5b76caa4
PE
12011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2
3 Rename locals to avoid shadowing.
4 * fileio.c (Finsert_file_contents):
5 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6 * process.c (wait_reading_process_output):
7 Rename inner 'proc' to 'p' to avoid shadowing.
8 Indent for consistency with usual Emacs style.
9
8c535114
EZ
102011-11-25 Eli Zaretskii <eliz@gnu.org>
11
12 * xdisp.c (redisplay_window): If cursor row is not fully visible
13 after recentering, and scroll-conservatively is set to a large
14 number, scroll window by a few more lines to make the cursor fully
15 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
16 (start_display): Don't move to the next line if the display should
17 start at a newline that is part of a display vector or an overlay
18 string. (Bug#10119)
8c535114 19
fa4fdb5c
JL
202011-11-24 Juri Linkov <juri@jurta.org>
21
22 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
23 after the `MagickPingImage' call. (Bug#10112)
24
90ec88df
CY
252011-11-23 Chong Yidong <cyd@gnu.org>
26
27 * window.c (Fcoordinates_in_window_p): Accept only live windows.
28
56e2e794
MR
292011-11-23 Martin Rudalics <rudalics@gmx.at>
30
31 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
32 making another buffer current. (Bug#10114)
33
b6e64c41
GM
342011-11-23 Glenn Morris <rgm@gnu.org>
35
36 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
37
6b21de18
CY
382011-11-23 Chong Yidong <cyd@gnu.org>
39
40 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
41 using it (Bug#5984).
42
b12cd789
EZ
432011-11-22 Eli Zaretskii <eliz@gnu.org>
44
45 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
46 and header-lines, as they don't have one computed for them.
47 (Bug#10098)
48
49 * .gdbinit (prow): Make displayed values more self-explaining.
50 Add row's hash code.
51
261b6fd4
LMI
522011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
53
54 * process.c (wait_reading_process_output): Fix asynchrounous
55 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 56 (wait_reading_process_output): Add comment and URL.
261b6fd4 57
e7cfd277
JD
582011-11-21 Jan Djärv <jan.h.d@swipnet.se>
59
60 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
61
a9b9b7f5
CY
622011-11-21 Chong Yidong <cyd@gnu.org>
63
64 * window.c (Fnext_window, Fprevious_window): Doc fix.
65
b0d15b4f
SM
662011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
67
68 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
69
fe7a3057
JB
702011-11-20 Juanma Barranquero <lekktu@gmail.com>
71
72 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
73
d2999b1a
MR
742011-11-20 Martin Rudalics <rudalics@gmx.at>
75
76 * window.c (Fset_window_combination_limit): Rename argument
77 STATUS to LIMIT.
78 (Vwindow_combination_limit): Remove "status" from doc-string.
79
d5ff9cd0
AS
802011-11-20 Andreas Schwab <schwab@linux-m68k.org>
81
82 * m/ibms390.h: Remove.
83 * m/ibms390x.h: Don't include "ibms390.h".
84
a5bb9bd3
SM
852011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
86
87 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
88 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
89
cd1181db
JB
902011-11-20 Juanma Barranquero <lekktu@gmail.com>
91
92 * casetab.c (Fset_case_table):
93 * charset.c (Fcharset_after): Fix typos.
94
615a3b8d 952011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 96
17e845af
PE
97 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
98 Otherwise, valgrind does not work on some platforms.
99 Problem reported by Andreas Schwab in
6a0bf43d
PE
100 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
101 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
102 is set, removing the need for VIRT_ADDRESS_VARIES.
103 (PURE_P): Use a more-efficient implementation that needs just one
104 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
105 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
106 to 4 (xorl, subq, cmpq, setbe).
107 * alloc.c (pure): Always extern now, since that's the
108 VIRT_ADDR_VARIES behavior.
109 (PURE_POINTER_P): Use a single comparison, not two, for
110 consistency with the new puresize.h.
111 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
112 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
113 Remove VIRT_ADDR_VARIES no longer needed.
114
f8fe6f96
EZ
1152011-11-19 Eli Zaretskii <eliz@gnu.org>
116
117 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
118 (erase_phys_cursor, update_window_cursor, show_mouse_face)
119 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
120 behave as if the cursor position were at the window margin.
121
122 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
123 and the cursor position is out of bounds, behave as if the cursor
124 position were at the window margin. (Bug#10075)
125
df05a53c
CY
1262011-11-18 Chong Yidong <cyd@gnu.org>
127
128 * window.c (Fwindow_combination_limit): Make first argument
129 non-optional, since it is meaningless for live windows like the
130 selected window.
131
2071918e
DA
1322011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
133
134 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
135
b50a28de
SM
1362011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
137
138 * intervals.c: Fix grafting over the whole buffer (bug#10071).
139 (graft_intervals_into_buffer): Simplify.
140
015137db
EZ
1412011-11-18 Eli Zaretskii <eliz@gnu.org>
142
143 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
144 hash values of the two rows.
145 (copy_row_except_pointers): Preserve the used[] arrays and the
146 hash values of the two rows. (Bug#10035)
68c95424 147 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
148
149 * xdisp.c (row_hash): New function, body extracted from
150 compute_line_metrics.
151 (compute_line_metrics): Call row_hash, instead of computing the
152 hash code inline.
153
154 * dispnew.c (verify_row_hash): Call row_hash for computing the
155 hash code of a row, instead of duplicating code from xdisp.c.
156
157 * dispextern.h (row_hash): Add prototype.
158
a2addb04
TH
1592011-11-18 Tassilo Horn <tassilo@member.fsf.org>
160
161 * frame.c (delete_frame): Don't delete the terminal when the last
162 X frame is closed if emacs is built with GTK toolkit.
163
df85d315
JB
1642011-11-17 Juanma Barranquero <lekktu@gmail.com>
165
166 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
167
a0c2d0ae
MR
1682011-11-17 Martin Rudalics <rudalics@gmx.at>
169
170 * window.c (Vwindow_splits): Rename to
171 Vwindow_combination_resize. Suggested by Juri Linkov.
172 (Fsplit_window_internal): Use Vwindow_combination_resize instead
173 of Vwindow_splits.
174
58179cce
JB
1752011-11-16 Juanma Barranquero <lekktu@gmail.com>
176
7877f373
JB
177 * nsfns.m (Fns_font_name):
178 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 179
b6f67890
MR
1802011-11-16 Martin Rudalics <rudalics@gmx.at>
181
182 * window.h (window): Rename slot "nest" to "combination_limit".
183 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
184 (Fset_window_nest): Rename to Fset_window_combination_limit.
185 (Vwindow_nest): Rename to Vwindow_combination_limit.
186 (recombine_windows, make_parent_window, make_window)
187 (Fsplit_window_internal, saved_window)
188 (Fset_window_configuration, save_window_save): Rename all
189 occurrences of window_nest to window_combination_limit.
190
c7015153
JB
1912011-11-15 Juanma Barranquero <lekktu@gmail.com>
192
193 * image.c (imagemagick_load_image): Fix typo.
194
322ad6ec
EZ
1952011-11-14 Eli Zaretskii <eliz@gnu.org>
196
197 * xdisp.c (display_line): Move the call to
198 highlight_trailing_whitespace before the call to
199 compute_line_metrics, since the latter needs to see the final
200 faces of all the glyphs to compute ROW's hash value. Fixes
201 assertion violations in row_equal_p. (Bug#10035)
202
f067b8ec
JB
2032011-11-14 Juanma Barranquero <lekktu@gmail.com>
204
205 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
206 just return (bug#10044).
207
1e5b2111
EZ
2082011-11-12 Eli Zaretskii <eliz@gnu.org>
209
7ef3cbd5
EZ
210 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
211 with user-defined heap size. Bump the default size of the temacs
212 heap to 27MB, to avoid memory warning when running temacs.
213 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
214
1e5b2111
EZ
215 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
216 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
217 (verify_row_hash) [XASSERTS]: New function.
218 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
219 that the hash value of glyph rows is correct.
1e5b2111 220
89d61221
MR
2212011-11-12 Martin Rudalics <rudalics@gmx.at>
222
223 * window.h (window): Remove splits slot.
224 * window.c (Fwindow_splits, Fset_window_splits): Remove.
225 (Fdelete_other_windows_internal, make_parent_window)
226 (make_window, Fsplit_window_internal, Fdelete_window_internal)
227 (Fset_window_configuration, save_window_save): Don't deal with
228 split status of windows.
229 (saved_window): Remove splits slot.
230 (Vwindow_splits): Rewrite doc-string.
231
97f18cc8
JD
2322011-11-11 Jan Djärv <jan.h.d@swipnet.se>
233
234 * xfns.c (unwind_create_frame):
235 * nsfns.m (unwind_create_frame):
236 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
237 Vframe_list (Bug#9999).
238
22a648b4
DA
2392011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
240
0b381c7e 241 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 242
659afede
KH
2432011-11-11 Kenichi Handa <handa@m17n.org>
244
245 * callproc.c (Fcall_process): Set the member dst_multibyte of
246 process_coding.
247
9ac0394b
KH
2482011-11-11 Johan Bockgård <bojohan@gnu.org>
249
250 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
251 avoid a crash (bug#9496).
252
2fbdc249
CY
2532011-11-09 Chong Yidong <cyd@gnu.org>
254
255 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
256 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
257
ac6b1f81
PE
2582011-11-08 Paul Eggert <eggert@cs.ucla.edu>
259
260 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
261
09db192c
PE
2622011-11-08 Paul Eggert <eggert@cs.ucla.edu>
263
264 Avoid some portability problems by eschewing 'extern inline' functions.
265 The trivial performance wins aren't worth the portability hassles; see
266 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
267 et seq.
268 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
269 (window_box_width, window_box_left, window_box_left_offset)
270 (window_box_right, window_box_right_offset): Undo previous change,
271 by removing the "extern"s.
272 * intervals.c (adjust_intervals_for_insertion)
273 (adjust_intervals_for_deletion): Undo previous change,
274 making these static again.
275 (offset_intervals, temp_set_point_both, temp_set_point)
276 (copy_intervals_to_string): No longer inline.
277 * xdisp.c (window_text_bottom_y, window_box_width)
278 (window_box_height, window_box_left_offset)
279 (window_box_right_offset, window_box_left, window_box_right)
280 (window_box): No longer inline.
281
105216ed
CY
2822011-11-08 Chong Yidong <cyd@gnu.org>
283
284 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
285 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
286 an error if not a live window.
287 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
288 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
289
ae9e237f
JB
2902011-11-07 Juanma Barranquero <lekktu@gmail.com>
291
292 * lisp.h (syms_of_abbrev): Remove declaration.
293 Reported by CHENG Gao <chenggao@royau.me>.
294
c7aa8333
EZ
2952011-11-07 Eli Zaretskii <eliz@gnu.org>
296
297 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
298 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
299 of temacs in GUI mode.
300
be7f5545
MR
3012011-11-07 Martin Rudalics <rudalics@gmx.at>
302
303 * window.h: Declare delete_all_child_windows instead of
304 delete_all_subwindows.
305 * window.c (Fwindow_nest, Fset_window_nest)
306 (Fset_window_new_total, Fset_window_new_normal)
307 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
308 (delete_all_subwindows): Rename to delete_all_child_windows.
309 (Fdelete_other_windows_internal, Fset_window_configuration):
310 Call delete_all_child_windows instead of delete_all_subwindows.
311 * frame.c (delete_frame): Call delete_all_child_windows instead
312 of delete_all_subwindows.
313
ca78dc43
PE
3142011-11-07 Paul Eggert <eggert@cs.ucla.edu>
315
316 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
317 This is also needed for porting to any host where GC_MARK_STACK is
318 not GC_MAKE_GCPROS_NOOPS.
319 (which_symbols): Use it.
320
a0241d01
KH
3212011-11-07 Kenichi Handa <handa@m17n.org>
322
323 * coding.c (coding_set_destination): Check coding->src_pos only
324 when coding->src_object is a buffer (bug#9910).
325
326 * process.c (send_process): Set the member src_multibyte of coding
327 to 0 (bug#9911) when sending a unibyte text.
328
329 * callproc.c (Fcall_process): Set the member src_multibyte of
330 process_coding to 0 (bug#9912).
331
a64bfdfa 3322011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
333
334 * xmenu.c (cleanup_widget_value_tree): New function.
335 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
336 calling free_menubar_widget_value_tree directly (Bug#9830).
337
cb41b32a
PE
3382011-11-06 Paul Eggert <eggert@cs.ucla.edu>
339
340 Fix some portability problems with 'inline'.
341 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
342 (window_box_width, window_box_left, window_box_left_offset)
343 (window_box_right, window_box_right_offset): Declare extern.
344 Otherwise, these inline functions do not conform to C99 and
345 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
347 * intervals.c (adjust_intervals_for_insertion)
348 (adjust_intervals_for_deletion): Now extern, because otherwise the
349 extern inline functions 'offset_intervals' couldn't refer to it.
350 (static_offset_intervals): Remove.
351 (offset_intervals): Rewrite using the old contents of
352 static_offset_intervals. The old version didn't conform to C99
353 because an extern inline function contained a reference to an
354 identifier with static linkage.
355
b7041366
AS
3562011-11-06 Andreas Schwab <schwab@linux-m68k.org>
357
358 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
359 GC.
360
88a37c4d
EZ
3612011-11-06 Eli Zaretskii <eliz@gnu.org>
362
363 * xdisp.c (init_iterator, reseat_to_string): Don't set the
364 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
365 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
366 return Qleft_to_right.
367
49745b39
CY
3682011-11-06 Chong Yidong <cyd@gnu.org>
369
370 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
371 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
372 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
373 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
374 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
375 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
376 (Fwindow_vscroll): Doc fix.
377 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
378 argument, since it makes no sense to pass a live window and for
379 consistency with window-child.
380
1f05cd82
CS
3812011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
382
383 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
384 support MSVC.
385
22610910
JR
3862011-11-05 Jason Rumney <jasonr@gnu.org>
387
388 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
389 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
390 fonts (Bug#6029).
391 (add_font_entity_to_list): Fix logic errors in mixed boolean and
392 bitwise arithmetic preventing use of unicode-sip and non-truetype
393 opentype fonts.
394
a06776b2
EZ
3952011-11-05 Eli Zaretskii <eliz@gnu.org>
396
3ad924ba
EZ
397 * s/ms-w32.h (fstat, stat, utime): Move redirections to
398 "emacs"-only part.
399
a06776b2
EZ
400 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
401 initialization code to keep similarity to xfns.c after changes
402 from 2011-11-05.
403
c9e7db78
JD
4042011-11-05 Jan Djärv <jan.h.d@swipnet.se>
405
a97f8f3f
JD
406 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
407 (unwind_create_frame): New function (Bug#9943).
408 (Fx_create_frame): Restructure code to be more similar to the one in
409 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
410 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
411 Move terminal->reference_count++ just before making the frame official
412 (Bug#9943).
413
414 * nsterm.m (x_free_frame_resources): New function.
415 (x_destroy_window): Move code to x_free_frame_resources.
416
c9e7db78
JD
417 * xfns.c (unwind_create_frame): Fix comment.
418 (Fx_create_frame, x_create_tip_frame): Move
419 terminal->reference_count++ just before making the frame
420 official. Move initialization of image_cache_refcount and
421 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
422
a6fc3b5c
EZ
4232011-11-05 Eli Zaretskii <eliz@gnu.org>
424
425 Support MSVC build with newer versions of Visual Studio.
426 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
427 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
428 nt/gmake.defs.
429
430 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
431 which are not supported by MSVC.
432 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
433 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
434 bitfields.
435 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
436 types in bitfields.
437 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
438
439 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
440
58179cce 4412011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
442
443 Support MSVC build with newer versions of Visual Studio.
444 * w32.c: Don't include w32api.h for MSVC.
445 (init_environment) [_MSC_VER]: Call sys_access, not _access.
446
447 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
448 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
449 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
450 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
451 e_* cousins.
452 (alloca) [_MSC_VER]: Define to _alloca.
453
454 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
455
456 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
457
a58c13ed
EZ
4582011-11-04 Eli Zaretskii <eliz@gnu.org>
459
460 * xdisp.c (note_mouse_highlight): If either of
461 previous/next-single-property-change returns nil, treat that as
462 the beginning or the end of the buffer. (Bug#9955)
463
fe0b6370
JD
4642011-11-04 Jan Djärv <jan.h.d@swipnet.se>
465
a58c13ed 466 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
467 label is not null (Bug#9951).
468 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
469 may be NULL.
470
89bd5ee1
EZ
4712011-11-04 Eli Zaretskii <eliz@gnu.org>
472
473 * window.c (Fwindow_body_size): Mention in the doc string that the
474 return value is in frame's canonical units. (Bug#9949)
475
84c3edb9
EZ
4762011-11-03 Eli Zaretskii <eliz@gnu.org>
477
4e2fb5c7
EZ
478 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
479
84c3edb9 480 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 481 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 482 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 483
bc17a887
EZ
4842011-11-01 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
487 Don't stop backward scan on the continuation glyph, even though
488 its CHARPOS is positive.
26b46e51
EZ
489 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
490 cover_string to disp_string.
bc17a887 491
4ee88440
MR
4922011-11-01 Martin Rudalics <rudalics@gmx.at>
493
494 * window.c (temp_output_buffer_show): Don't use
495 Vtemp_buffer_show_specifiers.
496 (Vtemp_buffer_show_specifiers): Remove unused variable.
497
c2ff3c02
EZ
4982011-10-30 Eli Zaretskii <eliz@gnu.org>
499
500 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
501 past the beginning of the current glyph matrix.
502
58179cce 5032011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
504
505 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
506 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
507 HAVE_GTK3 (Bug#9869).
b77a6a7f 508
3b574623
JD
509 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
510 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
511
b77a6a7f
JD
512 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
513
514 * xterm.c: Declare x_handle_net_wm_state to return int.
515 (handle_one_xevent): Check if we are iconified but don't have
516 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
517 (get_current_wm_state): Return non-zero if not hidden,
518 check for _NET_WM_STATE_HIDDEN (Bug#9893).
519 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
520 (x_handle_net_wm_state): Return what get_current_wm_state returns.
521 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
522
196e41e4
PE
5232011-10-29 Paul Eggert <eggert@cs.ucla.edu>
524
525 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
526 so that this new function doesn't get optimized away by a
527 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
528
021f2e1a
AS
5292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
530
531 * frame.h (MOUSE_HL_INFO): Remove excess parens.
532
8b058d44
EZ
5332011-10-29 Eli Zaretskii <eliz@gnu.org>
534
535 Fix the `xbytecode' command.
536 * .gdbinit (xprintbytestr): New command.
b50a28de 537 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
538 (xbytecode): Print the byte-code string as well.
539
4452fb80
EZ
5402011-10-29 Kim Storm <storm@cua.dk>
541
8b058d44
EZ
542 * alloc.c (which_symbols): New function.
543
21b72067
AS
5442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
545
546 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
547 line. (Bug#9903)
548
83ed7b5c
GM
5492011-10-29 Glenn Morris <rgm@gnu.org>
550
551 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
552 Not clear what it was for, and it causes various bugs. (Bug#9839)
553
5a7a728b
EZ
5542011-10-28 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
557 possible random value that matches one of those tested as
558 condition to clear the mouse face.
559
d3d0842f
CY
5602011-10-28 Chong Yidong <cyd@gnu.org>
561
562 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
563
31b39d13
DN
5642011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
565
566 * window.c (make_window): Initialize phys_cursor_on_p.
567
9aba6043
SM
5682011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
569
570 * lisp.h (struct Lisp_Symbol): Update comments.
571
c20992f4
JB
5722011-10-28 Juanma Barranquero <lekktu@gmail.com>
573
574 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
575
db4f02f2
EZ
5762011-10-28 Eli Zaretskii <eliz@gnu.org>
577
578 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
579 <oslsachem@gmail.com> for helping to debug this.
580
581 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
582 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
583 (g_b_init_get_glyph_outline_w): New static variables.
584 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
585 (GetGlyphOutlineW_Proc): New typedefs.
586 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
587 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
588 New functions.
589 (w32font_open_internal, compute_metrics):
590 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
591 instead of calling the "wide" APIs directly.
592
593 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
594
595 * w32.h (syms_of_w32font): Add prototype.
596
87e68db4
JB
5972011-10-27 Juanma Barranquero <lekktu@gmail.com>
598
599 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
600 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
601 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
602 (Fmove_to_window_line): Doc fix.
603
435c1d67
CY
6042011-10-27 Chong Yidong <cyd@gnu.org>
605
606 * process.c (make_process): Set gnutls_state to NULL.
607
608 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
609 non-NULL, regardless of GNUTLS_INITSTAGE.
610 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
611 an error. Set process slots as soon as we allocate them.
612
613 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
614
9c6c6f49
CY
6152011-10-27 Chong Yidong <cyd@gnu.org>
616
9aba6043
SM
617 * gnutls.c (emacs_gnutls_deinit): New function.
618 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
619 (Fgnutls_deinit, Fgnutls_boot): Use it.
620
621 * process.c (make_process): Initialize GnuTLS credentials to NULL.
622 (deactivate_process): Call emacs_gnutls_deinit.
623
657d08d3
JB
6242011-10-27 Juanma Barranquero <lekktu@gmail.com>
625
626 * image.c (x_create_x_image_and_pixmap):
627 * w32.c (sys_rename, w32_delayed_load):
628 * w32font.c (fill_in_logfont):
629 * w32reg.c (x_get_string_resource): Silence compiler warnings.
630
5430d399
JB
6312011-10-26 Juanma Barranquero <lekktu@gmail.com>
632
633 * w32fns.c (w32_default_color_map): New function,
634 extracted from Fw32_default_color_map.
a7ef684b 635 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 636
fe0055fa
PE
6372011-10-25 Paul Eggert <eggert@cs.ucla.edu>
638
639 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
640
e6346438
SM
6412011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
642
643 * keyboard.c (test_undefined): New function (bug#9751).
644 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
645
e112cc37
ET
6462011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
647
648 * sysdep.c (init_sys_modes): Fix the check for the controlling
649 terminal (Bug#6649).
650
7b5d6677
EZ
6512011-10-20 Eli Zaretskii <eliz@gnu.org>
652
653 * dispextern.h (struct bidi_it): New member next_en_type.
654
655 * bidi.c (bidi_line_init): Initialize the next_en_type member.
656 (bidi_resolve_explicit_1): When next_en_pos is valid for the
657 current character, check also for next_en_type being WEAK_EN.
658 (bidi_resolve_weak): Don't enter the expensive loop if the current
659 position is before next_en_pos. Record the bidi type of the first
660 non-ET, non-BN character we find, in addition to its position.
661 (bidi_level_of_next_char): Invalidate next_en_type when
662 next_en_pos is over-stepped.
663
7da0b018
PE
6642011-10-20 Paul Eggert <eggert@cs.ucla.edu>
665
666 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
667 * editfns.c: Rewrite current-time-zone so that it invokes
668 the equivalent of (format-time-string "%Z") to get the time zone name.
669 This fixes a bug when the time zone name contains characters that
670 need converting from the system time locale to Emacs internal format.
671 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
672 that patch fixed format-time-string to do the conversion, but
673 I forgot to fix current-time-zone.
674 (format_time_string): New function, containing most of
675 what Fformat_time_string used to contain.
676 (Fformat_time_string): Rewrite in terms of format_time_string.
677 This doesn't change this function's behavior.
678 (current-time-zone): Rewrite to use format_time_string.
679 This fixes the bug reported by Michael Schierl in
680 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
681 Jason Rumney's 2007-06-07 change worked around this bug, but
682 didn't fix it.
683 * systime.h (tzname, timezone): Remove no-longer-used declarations.
684
8547b010
EZ
6852011-10-19 Eli Zaretskii <eliz@gnu.org>
686
687 * xdisp.c (start_display): If the character at POS is displayed
688 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
689 (try_window_reusing_current_matrix): If a line ends in a display
690 vector or the next line starts in a display vector, continue
691 redrawing the window even though the character position of
692 start_row was reached.
8547b010
EZ
693 (Bug#9771, part 2)
694
4e948d15
CY
6952011-10-18 Chong Yidong <cyd@gnu.org>
696
697 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
698 with nobreak-char-display too.
699
4787455f
EZ
7002011-10-18 Eli Zaretskii <eliz@gnu.org>
701
702 Fix part 3 of bug#9771.
703 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
704 (bidi_resolve_neutral): Don't enter the expensive loop looking for
705 non-neutral characters if the current character is a paragraph
706 separator (a.k.a. Newline). This avoids running the same
707 expensive loop twice, once when we consume the preceding newline
708 and the other time when the line actually needs to be displayed.
709 Avoid the loop when we see neutrals on the base embedding level
710 following a character whose directionality is the same as the
711 paragraph's. This avoids running the expensive loop when a line
712 ends in a long sequence of neutrals, like control characters.
713 Add assertion against STRONG_AL type. Slightly rearrange code
714 that determines the type of a neutral given the first non-neutral
715 that follows it.
716 (bidi_level_of_next_char): Set next_en_pos to zero when
717 invalidating its info.
718
2c91f553
EZ
7192011-10-17 Eli Zaretskii <eliz@gnu.org>
720
721 * xdisp.c (push_display_prop): Determine whether to record string
722 or buffer position by IT->string, not by IT->method. Allow
723 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
724 (move_it_vertically_backward): Don't look for character position
725 immediately after the newline when in a continuation line.
726 (Bug#9771, part 1)
2c91f553 727
c7b08b0d
MR
7282011-10-15 Martin Rudalics <rudalics@gmx.at>
729
730 * window.c (coordinates_in_window): Rewrite and delabelize
731 vertical border check. (Bug#5357) (Bug#9618)
732
6b02f655
SM
7332011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
736 errors in XSetWindowBorder (bug#9310).
737
81d40c92
DA
7382011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
739
740 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
741 avoid crash when xmalloc overrun checking is enabled.
742
d4172c3b
EZ
7432011-10-13 Eli Zaretskii <eliz@gnu.org>
744
745 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
746 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
747 cursor motion with <left> and <right> arrow keys.
748
749 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
750 some callers set that themselves.
751
b00eea75
EZ
7522011-10-12 Eli Zaretskii <eliz@gnu.org>
753
754 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
755 display string and the previous row comes from the same string and
756 is empty. (Bug#9739) (Bug#9738)
757
8fe012c4
SM
7582011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
759
760 * doc.c (get_doc_string): Encode file name (bug#9735).
761
0074aef2
EZ
7622011-10-12 Eli Zaretskii <eliz@gnu.org>
763
79beb178
EZ
764 * bidi.c (bidi_level_of_next_char):
765 * xdisp.c (get_visually_first_element): Remove old incorrect
766 comments regarding the Unicode Line Separator character.
767
0074aef2
EZ
768 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
769
6e4b3fbe
DA
7702011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
771
772 * alloc.c (Fgc_status): Do not access beyond zombies array
773 boundary if nzombies > MAX_ZOMBIES.
774 * alloc.c (dump_zombies): Add missing format specifier.
775
0324f3af
PE
7762011-10-12 Paul Eggert <eggert@cs.ucla.edu>
777
b5525cac
PE
778 * xdisp.c (set_cursor_from_row): Simplify conditionals,
779 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
780
0324f3af
PE
781 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
782 Some packages use them to denote characters with modifiers.
783
e9b5f888
AS
7842011-10-11 Andreas Schwab <schwab@linux-m68k.org>
785
786 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
787 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
788 matching a pp-number. Rename parameter var to var1.
789
127827c0
SM
7902011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
791
792 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
793
c8fd3bd0
GM
7942011-10-08 Glenn Morris <rgm@gnu.org>
795
796 * callint.c (Fcall_interactively): Give a more explicit error for the
797 'c' case with a non-character input. (Bug#8479)
798
352ec8ff
EZ
7992011-10-08 Eli Zaretskii <eliz@gnu.org>
800
03669ccb
EZ
801 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
802 lines.
7061c986
EZ
803 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
804 lines that are hscrolled on the left.
03669ccb 805
352ec8ff
EZ
806 * dispnew.c (buffer_posn_from_coords): Account for a possible
807 presence of header-line. (Bug#4426)
808
a66cfb1c
SM
8092011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
810
6b02f655
SM
811 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
812 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 813
7c5ee88e
PE
8142011-10-07 Paul Eggert <eggert@cs.ucla.edu>
815
816 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
817 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
818 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
819 this makes Emacs dump core during garbage collection on rare
820 occasions. sizeof is obviously inferior to offsetof here, so
821 stick with offsetof.
822 (GC_POINTER_ALIGNMENT): New macro.
823 (mark_memory): Omit 3rd (offset) arg; caller changed.
824 Don't assume EMACS_INT alignment is the same as pointer alignment.
825
df1bbe5b
SM
8262011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
827
828 * keyboard.c (read_key_sequence_remapped): New var.
829 (read_key_sequence): Compute remapping in the right buffer.
830 (command_loop_1): Use read_key_sequence's remapping directly.
831
51553db6
SM
8322011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
833
32c1fffd
SM
834 * dired.c (file_name_completion): Don't expand file name.
835 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
836 before checking file name handler.
837
51553db6
SM
838 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
839 they've been requested explicitly (bug#9591).
840
b6bd1599 8412011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
842
843 * keymap.c (Fsingle_key_description): Use make_specified_string
844 instead of build_string to build string from push_key_description.
845 (Bug#5193)
846
f701dc2a
PE
8472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
848
4222c55d
PE
849 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
850 This fixes a Y2038 bug on 64-bit hosts.
851 * buffer.c (reset_buffer):
852 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
853 (Fclear_buffer_auto_save_failure):
854 Use 0, not -1, to represent an unset failure time, since time_t
855 might not be signed.
856
f701dc2a
PE
857 Remove dependency on glibc malloc internals.
858 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
859 Move back here from lisp.h, but with their new implementations.
860 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
861 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
862 * charset.c (charset_table_init): New static var.
863 (syms_of_charset): Use it instead of xmalloc. This removes a
864 dependency on glibc malloc internals. See Eli Zaretskii's comment in
865 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
866 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
867 Move back to alloc.c.
868 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
869 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
870
9ceebf39
JD
8712011-09-30 Jan Djärv <jan.h.d@swipnet.se>
872
873 * nsterm.m (windowDidResize): Call x_set_window_size only when
874 ns_in_resize is true. Otherwise set pixelwidth/height and
875 call change_frame_size (Bug#9628).
876
cb993c58
PE
8772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
878
3930c88b
PE
879 Port --enable-checking=all to Fedora 14 x86-64.
880 * charset.c (syms_of_charset): Also account for glibc malloc's
881 internal overhead when calculating the initial malloc maximum.
882
cb993c58
PE
883 Port --enable-checking=all to Fedora 14 x86.
884 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
885 Move to lisp.h.
886 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
887 (overrun_check_realloc, overrun_check_free):
888 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
889 That way, xmalloc returns a properly-aligned pointer even if
890 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
891 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
892 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
893 into account when calculating the initial malloc maximum.
894 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
895 Move here from alloc.c, so that charset.c can use it too.
896 Properly align; the old code wasn't right for common 32-bit hosts
897 when configured with --enable-checking=all.
898 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
899 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
900
31bed486
EZ
9012011-09-29 Eli Zaretskii <eliz@gnu.org>
902
04c70788 903 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
904 use EDOM.
905
fbcaa2f3
EZ
9062011-09-28 Eli Zaretskii <eliz@gnu.org>
907
908 * xdisp.c (compute_display_string_end): If there's no display
909 string at CHARPOS, return -1.
910
911 * bidi.c (bidi_fetch_char): When compute_display_string_end
912 returns a negative value, treat the character as a normal
913 character not covered by a display string. (Bug#9624)
914
a239d4e9
JB
9152011-09-28 Juanma Barranquero <lekktu@gmail.com>
916
917 * lread.c (Fread_from_string): Fix typo in docstring.
918
88652fd5
EZ
9192011-09-27 Eli Zaretskii <eliz@gnu.org>
920
921 * xdisp.c (handle_invisible_prop): If invisible text ends on a
922 newline, reseat the iterator instead of bidi-iterating there one
923 character at a time. (Bug#9610)
32c1fffd
SM
924 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
925 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 926
ed497dd4
AS
9272011-09-27 Andreas Schwab <schwab@linux-m68k.org>
928
929 * lread.c (readevalloop): Use correct code for NBSP.
930 (read1): Likewise. (Bug#9608)
931
b2bf61aa
MA
9322011-09-25 Michael Albinus <michael.albinus@gmx.de>
933
934 * dbusbind.c (Fdbus_register_signal): When service is not
935 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
936
32bbb17c
GM
9372011-09-25 Glenn Morris <rgm@gnu.org>
938
939 * buffer.c (truncate-lines): Doc fix.
940
94e0933e
CY
9412011-09-24 Chong Yidong <cyd@stupidchicken.com>
942
943 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
944 (Fset_window_next_buffers): Doc fix.
945
cddde921
GM
9462011-09-24 Glenn Morris <rgm@gnu.org>
947
948 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
949
1260aef1
PE
9502011-09-24 Paul Eggert <eggert@cs.ucla.edu>
951
25b4bfa0
PE
952 Fix minor problems found by static checking.
953 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
954 * indent.c (Fvertical_motion): Fix == vs = typo.
955
e3cbd34b
EZ
9562011-09-24 Eli Zaretskii <eliz@gnu.org>
957
a66cfb1c
SM
958 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
959 Default value is now t. Doc fix.
6bf7006f 960
e3cbd34b 961 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 962 logic when moving up, not only when moving down. Fix the
e3cbd34b 963 confusing name and values of the it_overshoot_expected variable;
32c1fffd 964 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
965
966 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
967 CHARPOS is covered by a display string which includes newlines.
968 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
969 is covered by a display string with embedded newlines.
970
a3de0cbd
MA
9712011-09-24 Michael Albinus <michael.albinus@gmx.de>
972
973 * dbusbind.c (Fdbus_register_signal): Add match rule to
974 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
975 (Fdbus_register_method, Vdbus_registered_objects_table):
976 Fix docstring.
a3de0cbd 977
b260039d
JM
9782011-09-24 Jim Meyering <meyering@redhat.com>
979
32c1fffd 980 do not ignore write error for any output size
b260039d
JM
981 The previous change was incomplete.
982 While it makes emacs --batch detect the vast majority of stdout
983 write failures, errors were still ignored whenever the output size is
984 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
985 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
986 && echo FAIL: ignored write error
987 FAIL: ignored write error
988 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
989 && echo FAIL: ignored write error
990 FAIL: ignored write error
991 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
992
8eca8a7c
AS
9932011-09-23 Andreas Schwab <schwab@linux-m68k.org>
994
995 * emacs.c (Fkill_emacs): In noninteractive mode exit
996 non-successfully if a write error occurred on stdout. (Bug#9574)
997
3341db62
EZ
9982011-09-21 Eli Zaretskii <eliz@gnu.org>
999
1000 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1001 the xassert test.
1002
1003 * dispextern.h (struct it): Update the comment documenting what
1004 can it->OBJECT be.
1005
8c203dbf
EZ
10062011-09-20 Eli Zaretskii <eliz@gnu.org>
1007
1008 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1009 a display string, extend search for cursor position to end of row.
1010 (find_row_edges): If the row ends in a newline from a display
1011 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1012 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1013 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1014 non-empty line. Fixes confusing cursor motion with arrow keys at
1015 the beginning of a line that starts with whitespace.
8c203dbf 1016
a4824228
LMI
10172011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1018
1019 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1020 (bug#9493).
1021
33ed493b
CY
10222011-09-18 Chong Yidong <cyd@stupidchicken.com>
1023
1024 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1025 boolean (Bug#9154).
1026
56cd55c8
EZ
10272011-09-18 Eli Zaretskii <eliz@gnu.org>
1028
1029 * xdisp.c (display_line): Record maximum and minimum buffer
1030 positions even if no glyphs were produced (e.g., by a zero-width
1031 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1032 buffer positions that will be removed from the glyph row because
1033 they don't fit.
c02dcedf
EZ
1034 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1035 column is beyond frame width: don't subtract 1 "pixel" when
1036 computing width of the stretch.
3e62b7e0
EZ
1037 (reseat_at_next_visible_line_start): Undo the change made on
1038 2011-09-17 that saved paragraph information and restored it after
1039 the call to `reseat'. (Bug#9545)
56cd55c8 1040
5ed99d36 10412011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1042
1043 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1044 and turn window cursor on if cleared (Bug#9415).
1045
5ed99d36 10462011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1047
1048 * search.c (boyer_moore): Take unibyte characters from pattern
1049 literally. (Bug#9458)
1050
9bade7b2
EZ
10512011-09-18 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1054
e5e9d610
PE
10552011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1056
87e4427a
PE
1057 Fix minor problem found by static checking.
1058 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1059 initialized, to pacify gcc -Wuninitialized.
1060
e5e9d610
PE
1061 * fileio.c: Report proper errno when syscall falls.
1062 (Finsert_file_contents): Save and restore errno,
1063 so that report_file_error outputs the correct diagnostic.
1064 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1065
a1674f0b
EZ
10662011-09-18 Eli Zaretskii <eliz@gnu.org>
1067
1068 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1069
fbfb6dd4
EZ
10702011-09-17 Eli Zaretskii <eliz@gnu.org>
1071
1072 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1073 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1074
bb187662
EZ
10752011-09-17 Eli Zaretskii <eliz@gnu.org>
1076
1137e8b8 1077 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1078 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1079
1080 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1081 (bidi_find_paragraph_start): Search back for paragraph beginning
1082 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1083 (bidi_move_to_visually_next): Only trigger paragraph-related
1084 computations when the last character is a newline or at EOB, not
1085 just any NEUTRAL_B. (Bug#9470)
1086
bb187662
EZ
1087 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1088 truncated lines if point is covered by a display string. (Bug#9524)
1089
2e621251
PE
10902011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1093 (cons_to_x_long): New function.
1094 (lisp_data_to_selection_data): Use it. Correct the test for
1095 short-versus-long data; it was negated. Break out of vector
1096 loop, for efficiency, when a long datum is discovered.
1097
91a15bc6
SM
10982011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1099
1100 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1101
b41c3a35
EZ
11022011-09-16 Eli Zaretskii <eliz@gnu.org>
1103
1104 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1105 GCC PR/17406) by declaring this function with external scope.
1106
7812ba2d
PE
11072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1110 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1111
cf7edc2a
AS
11122011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1113
1114 * editfns.c (Fformat): Correctly handle text properties on "%%".
1115
bd01620e
EZ
11162011-09-15 Eli Zaretskii <eliz@gnu.org>
1117
1118 * xterm.c (x_draw_composite_glyph_string_foreground):
1119 * w32term.c (x_draw_composite_glyph_string_foreground):
1120 * term.c (encode_terminal_code):
1121 * composite.c (composition_update_it, get_composition_id):
1122 * xdisp.c (get_next_display_element)
1123 (fill_composite_glyph_string): Add comments about special meaning
1124 of TAB characters in a composition.
1125
a02719a3
PE
11262011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1129 This occurs when processing a multibyte format.
1130 Problem reported by Wolfgang Jenker.
a02719a3 1131
72589a3c
JB
11322011-09-15 Johan Bockgård <bojohan@gnu.org>
1133
1134 * xdisp.c (try_cursor_movement): Only check for exact match if
1135 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1136
1c14176c
PE
11372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 Remove unused external symbols.
1140 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1141 * xdisp.c (calc_pixel_width_or_height): Now static.
1142 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1143 * indent.c (check_display_width):
1144 * w32term.c: Fix comment to match code.
1145 * xterm.c, xterm.h (x_catching_errors): Remove.
1146
d2eea5b5
PE
11472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1148
1149 * xselect.c: Use signed conversions more consistently (Bug#9498).
1150 (selection_data_to_lisp_data): Assume incoming selection data are
1151 signed integers, not unsigned. This is to be consistent with
1152 outgoing selection data, which was modified to use signed integers
1153 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1154 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1155 expects long, not unsigned long.
1156
46888499
EZ
11572011-09-14 Eli Zaretskii <eliz@gnu.org>
1158
1159 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1160 computation of loop end. Reported by Johan Bockgård
1161 <bojohan@gnu.org>.
1162
ef8ef9fb
CY
11632011-09-13 Chong Yidong <cyd@stupidchicken.com>
1164
1165 * frame.c (Fother_visible_frames_p): Function deleted.
1166
fa819fed
EZ
11672011-09-12 Eli Zaretskii <eliz@gnu.org>
1168
1169 * indent.c (compute_motion): Process display vector front to back
1170 rather than the other way around. (Bug#2496)
1171
2ba8e008
SM
11722011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1173
1174 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1175
20f53c69
CY
11762011-09-11 Chong Yidong <cyd@stupidchicken.com>
1177
1178 * minibuf.c (Fread_from_minibuffer): Doc fix.
1179
d562d7a4
EZ
11802011-09-11 Eli Zaretskii <eliz@gnu.org>
1181
1182 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1183 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1184
1c4d7f3d
LMI
11852011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1186
1187 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1188 value for non-existent files.
1189
b885bf36
EZ
11902011-09-11 Eli Zaretskii <eliz@gnu.org>
1191
1192 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1193 set its "size" to -1. This will set the modtime_size field of
1194 the corresponding buffer to -1, which is what
1195 verify-visited-file-modtime expects for files that do not exist.
1196 (Bug#9139)
1197
6612f0bf
PE
11982011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1201 here ...
1202 * lisp.h: ... from here. push_key_description is no longer
1203 defined in keyboard.c, so its declaration should not be in
1204 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1205 logically belongs with push_key_description.
1206
dfb3f755
PE
12072011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1208
1209 * buffer.h: Include <sys/types.h> instead of <time.h>.
1210 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1211 Problem reported by Herbert J. Skuhra.
1212
3134906c
LMI
12132011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1214
1215 * xml.c (parse_region): Make the parsing work for
1216 non-comment-starting XML files again (bug#9144).
1217
8d903f4e
AS
12182011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1219
1220 * image.c (gif_load): Fix calculation of bottom and right corner.
1221 (Bug#9468)
1222
80ad64f4
EZ
12232011-09-10 Eli Zaretskii <eliz@gnu.org>
1224
1225 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1226 redisplay in small windows.
1227
208a048d
EZ
12282011-09-09 Eli Zaretskii <eliz@gnu.org>
1229
1230 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1231
9b1c252e
MR
12322011-09-08 Martin Rudalics <rudalics@gmx.at>
1233
1234 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1235 Operate on live windows only.
1236
2949f33b
JB
12372011-09-08 Juanma Barranquero <lekktu@gmail.com>
1238
1239 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1240
e08dcafd
EZ
12412011-09-07 Eli Zaretskii <eliz@gnu.org>
1242
1243 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1244 only under bidi iteration.
1245
115b96bd
JD
12462011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1247
1248 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1249
c8199d0f
PE
12502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1253 Without this fix, the command to link temacs failed due to an
1254 undefined symbol __builtin_isnan. This is because
1255 /usr/include/iso/math_c99.h #defines isnan(x) to
1256 __builtin_isnan(x), but the bundled gcc, which identifies itself
1257 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1258 a __builtin_isnan.
1259 * floatfns.c (isnan): #undef, and then #define to a clone of
1260 what's in data.c.
1261 (Fisnan): Always define, since it's always available now.
1262 (syms_of_floatfns): Always define isnan at the Lisp level.
1263
e39b275c 12642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1265
1266 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1267
b2db44d9 12682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1269
f4af5137 1270 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1271 The previous code assumed that file offsets (off_t values) fit in
1272 EMACS_INT variables, which is not true on typical 32-bit hosts.
1273 The code messed up by falsely reporting buffer overflow in cases
1274 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1275 when "big" contains more than 2**29 bytes, even though this
1276 inserts just one byte and does not overflow the buffer.
1277 (Finsert_file_contents): Store file offsets as off_t
1278 values, not as EMACS_INT values. Check for overflow when
1279 converting between EMACS_INT and off_t. When checking for
1280 buffer overflow or for overlap, take the offsets into account.
1281 Don't use EMACS_INT for small values where int suffices.
1282 When checking for overlap, fix a typo: ZV was used where
1283 ZV_BYTE was intended.
1284 (Fwrite_region): Don't assume off_t fits into 'long'.
1285 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1286
ecfc0a49
MA
12872011-09-05 Michael Albinus <michael.albinus@gmx.de>
1288
1289 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1290
6511acf2 12912011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1292
0999621a 1293 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1294
1295 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1296 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1297 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1298 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1299 (modify_event_symbol): Do not assume that the length of
1300 name_alist_or_stem is safe to alloca and fits in int.
1301 (Fexecute_extended_command): Likewise for function name and binding.
1302 (Frecursion_depth): Wrap around reliably on integer overflow.
1303 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1304 since some callers pass EMACS_INT values.
1305 (Fsingle_key_description): Don't crash if symbol name contains more
1306 than MAX_ALLOCA bytes.
1307 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1308 (get_minibuffer): Arg is now EMACS_INT, not int.
1309 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1310 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1311 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1312
2be7d702
PE
1313 * dbusbind.c (signature_cat): New function.
1314 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1315 Do not overrun buffer; instead, report string overflow.
1316
9d1df220
PE
1317 * dispnew.c (add_window_display_history): Don't overrun buffer.
1318 Truncate instead; this is OK since it's just a log.
1319
33ef5c64
PE
1320 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1321 even if the time zone offset is outlandishly large.
1322 Don't mishandle offset == INT_MIN.
1323
66c6fdd5
PE
1324 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1325 when creating daemon; the previous buffer-overflow check was incorrect.
1326
d749b01b
PE
1327 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1328 which has the guts of the old verror function.
1329
b5cd1905
PE
1330 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1331 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1332
6e1a67fb
PE
1333 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1334 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1335 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1336 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1337 length of string rather than counting it via multiple sprintfs;
1338 that's simpler and more reliable.
c21721cc
PE
1339 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1340 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1341 sprintf, in case result does not fit in int.
1342
c57b67fc
PE
1343 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1344 (fontset_from_font): Print it.
1345
8a401434
PE
1346 * frame.c (tty_frame_count): Now printmax_t, not int.
1347 (make_terminal_frame, set_term_frame_name): Print it.
1348 (x_report_frame_params): In X, window IDs are unsigned long,
1349 not signed long, so print them as unsigned.
1350 (validate_x_resource_name): Check for implausibly long names,
1351 and don't assume name length fits in 'int'.
1352 (x_get_resource_string): Don't blindly alloca invocation name;
1353 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1354 not fit in int.
1355
6e1a67fb
PE
1356 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1357 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1358 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1359
0df02bf3
PE
1360 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1361 Use esprintf, not sprintf, in case result does not fit in int.
1362
48e30793
PE
1363 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1364 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1365 it as a large positive number.
1366 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1367 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1368
a66ff6d8
PE
1369 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1370 in case result does not fit in int.
1371
aca216ff
PE
1372 * print.c (float_to_string): Detect width overflow more reliably.
1373 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1374 buffer overrun. Don't assume list length fits in 'int'. Treat
1375 print length of 0 as 0, not as infinity; to be consistent with other
1376 uses of print length in this function. Don't overflow print length
1377 index. Don't assume hash table size fits in 'long', or that
1378 vectorlike size fits in 'unsigned long'.
1379
31c286f7
PE
1380 * process.c (make_process): Use printmax_t, not int, to format
1381 process-name gensyms.
1382
55e5faa1
PE
1383 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1384
80f2e268
PE
1385 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1386 to avoid potential buffer overrun.
1387
670741ab
PE
1388 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1389 if X resource line is longer than 512 bytes.
1390
b7163a50
PE
1391 * xfns.c (x_window): Make sprintf buffer a bit bigger
1392 to avoid potential buffer overrun.
1393
ae58ff1f
PE
1394 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1395
c43c8a6a
PE
1396 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1397
3f8236f4
PE
13982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1399
53e9fe90 1400 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1401 Without these, Emacs silently mishandles large integers sometimes.
1402 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1403 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1404
6511acf2
PE
1405 * xdisp.c (try_window_id): Check Emacs fixnum range before
1406 converting to 'int'.
806add1d 1407
6511acf2 1408 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1409 Check that an Emacs fixnum is in range before assigning it to 'int'.
1410 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1411 values converted from Emacs fixnums.
1412 (Frecenter): Don't wrap around a line count if it is out of 'int'
1413 range; instead, treat it as an extreme value.
1414 (Fset_window_configuration, compare_window_configurations):
1415 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1416
6511acf2
PE
1417 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1418 that can exceed INT_MAX. Check that EMACS_INT value is in range
1419 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1420 (match_limit): Don't assume that a fixnum can fit in 'int'.
1421
6511acf2 1422 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1423 exceed INT_MAX.
1424
6511acf2 1425 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1426 (Fvertical_motion): Don't wrap around LINES values that don't fit
1427 in 'int'. Instead, treat them as extreme values. This is good
1428 enough for windows, which can't have more than INT_MAX lines anyway.
1429
fcb901a7
LMI
14302011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1431
0f2f6b6d
LMI
1432 * Require libxml/parser.h to avoid compilation warning.
1433
fcb901a7
LMI
1434 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1435
1436 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1437 since this reportedly can destroy thread storage.
1438
6e20a0d4
CY
14392011-08-30 Chong Yidong <cyd@stupidchicken.com>
1440
1441 * syntax.c (find_defun_start): Update all cache variables if
1442 exiting early (Bug#9401).
1443
148ae00e
EZ
14442011-08-30 Eli Zaretskii <eliz@gnu.org>
1445
f6cfbd8f
EZ
1446 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1447
148ae00e
EZ
1448 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1449 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1450 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1451
1452 * term.c (tty_append_glyph): New function.
1453 (produce_stretch_glyph): Static function and its prototype deleted.
1454
a66cfb1c
SM
1455 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1456 Add prototypes.
148ae00e 1457
c4a07a4c
PE
14582011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1459
1460 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1461 when checking :margin (Bug#9390).
1462 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1463 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1464 so that the name doesn't mislead. All uses changed.
1465
6bc8cd65
JB
14662011-08-28 Johan Bockgård <bojohan@gnu.org>
1467
1468 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1469 set_tty_hooks.
1470
dca4927e
EZ
14712011-08-27 Eli Zaretskii <eliz@gnu.org>
1472
1473 * xdisp.c (move_it_to): Don't bail out early when reaching
1474 position beyond to_charpos, if we are scanning backwards.
1475 (move_it_vertically_backward): When DY == 0, make sure we get to
1476 the first character in the line after the newline.
1477
f2cad773
PE
14782011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1481 (ccl_driver): Do not generate an out-of-range pointer.
1482 (Fccl_execute_on_string): Remove unnecessary check for
1483 integer overflow, noted by Stefan Monnier in
1484 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1485 Remove a FIXME that didn't need fixing.
1486 Simplify the newly-introduced buffer reallocation code.
1487
0cae2cdb
JB
14882011-08-27 Juanma Barranquero <lekktu@gmail.com>
1489
1490 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1491
5fc295a4 14922011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1493
70c60eb2 1494 Integer and memory overflow issues (Bug#9196).
726e0ab1 1495
d31850da
PE
1496 * doc.c (get_doc_string): Rework so that
1497 get_doc_string_buffer_size is the actual buffer size, rather than
1498 being 1 less than the actual buffer size; this makes xpalloc more
1499 convenient.
1500
a69fbedb
PE
1501 * image.c (x_allocate_bitmap_record, cache_image):
1502 * xselect.c (Fx_register_dnd_atom):
1503 Simplify previous changes by using xpalloc.
1504
fe5c5d37
PE
1505 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1506 since either will do and ptrdiff_t is convenient with xpalloc.
1507
0065d054
PE
1508 * charset.c (charset_table_size)
1509 (struct charset_sort_data.priority): Now ptrdiff_t.
1510 (charset_compare): Don't overflow if priorities differ greatly.
1511 (Fsort_charsets): Don't assume list length fits in int.
1512 Check for size-calculation overflow when allocating sort data.
1513 (syms_of_charset): Allocate an initial charset table that is
1514 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1515
1516 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1517
1518 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1519 The actual value is always <= INT_MAX, and leaving it unsigned made
1520 overflow checking harder.
1521
1522 * dispextern.h (struct glyph_matrix.rows_allocated)
1523 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1524 with xpalloc. The values are still always <= INT_MAX.
1525
1526 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1527
1528 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1529 (SAFE_NALLOCA): New macro.
1530
1531 * region-cache.c (struct boundary.pos, find_cache_boundary)
1532 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1533 (set_cache_region, invalidate_region_cache)
1534 (revalidate_region_cache, know_region_cache, region_cache_forward)
1535 (region_cache_backward, pp_cache):
1536 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1537 so that ptrdiff_t * can be passed to xpalloc.
1538 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1539 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1540 (pp_cache): Don't assume cache_len fits in int.
1541 * region-cache.h: Adjust extern decls to match.
1542
1543 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1544 EMACS_INT, since either will do, for xpalloc.
1545
1546 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1547 (xnmalloc, xnrealloc, xpalloc): New functions.
1548
726e0ab1
PE
1549 * bidi.c (bidi_shelve_header_size): New constant.
1550 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1551 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1552
51f30bc5 1553 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1554 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1555 (overlay_strings):
1556 Don't update size of array until after memory allocation succeeds,
1557 because xmalloc/xrealloc may not return.
0065d054
PE
1558 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1559 now that we have proper integer overflow checking.
1560 (record_overlay_string, overlay_strings): Catch overflows when
1561 calculating size of overlay_str_buf.
726e0ab1 1562
0065d054
PE
1563 * callproc.c (Fcall_process): Check for size overflow when
1564 calculating size of args2.
1565 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1566 Normally we prefer signed values, but sticking with ptrdiff_t would
1567 require adding more-complicated checks.
726e0ab1
PE
1568
1569 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1570 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1571 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1572 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1573
1574 * character.c (Fstring): Check for size-calculation overflow.
1575
1576 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1577 unnecessary integer overflow. Check for size overflow.
1578 (encode_coding_object): Don't update size until xmalloc succeeds.
1579
1580 * composite.c (get_composition_id): Check for overflow in glyph
1581 length calculations.
1582
1583 Integer and memory overflow fixes for display code.
1584 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1585 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1586 (scrolling_window): Check for overflow in size calculations.
1587 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1588 Don't assume glyph table len fits in int.
1589 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1590 (row_table_size): Now ptrdiff_t, not int.
1591 (scrolling_window): Avoid overflow in size calculations.
1592 Don't update size until allocation succeeds.
1593 * fns.c (concat): Check for overflow in size calculations.
1594 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1595 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1596 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1597
1598 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1599 (get_doc_string): Check for size calculation overflow.
1600 Don't update size until allocation succeeds.
1601 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1602 EMACS_INT, where ptrdiff_t will do.
1603 (Fsubstitute_command_keys): Check for string overflow.
1604
1605 * editfns.c (set_time_zone_rule): Don't assume environment length
1606 fits in int.
1607 (message_length): Now ptrdiff_t, not int.
1608 (Fmessage_box): Don't update size until allocation succeeds.
1609 Don't assume message length fits in int.
1610 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1611
0065d054
PE
1612 * emacs.c (main): Do not reallocate argv, since there is a null at
1613 the end that can be overwritten, and this way there's no need to
1614 worry about size-calculation overflow.
1615 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1616
1617 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1618 alloc succeeds.
1619 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1620
1621 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1622 (x_set_scroll_bar_width, x_figure_window_size):
1623 Check for integer overflow.
1624 (x_set_alpha): Do not assume XINT fits in int.
1625
1626 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1627 This is for the members text_lines, text_cols, total_lines, total_cols,
1628 where the system imposes an 'int' limit.
1629
1630 * fringe.c (Fdefine_fringe_bitmap):
1631 Don't update size until alloc works.
1632
1633 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1634 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1635
1636 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1637 Check for size-calculation overflow.
1638 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1639 do, as we prefer signed integers.
1640 (id_to_widget.max_size, id_to_widget.used)
1641 (xg_store_widget_in_map, xg_remove_widget_from_map)
1642 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1643 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1644 Use and return ptrdiff_t, not int.
1645 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1646 * gtkutil.h: Change prototypes to match the above.
1647
1648 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1649 are duplicate now that they've been promoted to lisp.h.
1650 (x_allocate_bitmap_record, x_alloc_image_color)
1651 (make_image_cache, cache_image, xpm_load):
1652 Don't update size until alloc is done.
1653 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1654 (x_detect_edges):
3256efce 1655 Check for size calculation overflow.
726e0ab1
PE
1656 (ct_colors_allocated_max): New constant.
1657 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1658 overflow.
3256efce 1659
726e0ab1
PE
1660 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1661 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1662 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1663 Use ptrdiff_t, not int, to count maps.
1664 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1665 calculations. Don't update size until allocation succeeds.
1666 Redo calculations to avoid overflow.
726e0ab1
PE
1667 * keyboard.h: Change prototypes to match the above.
1668
1669 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1670 to count maps.
1671 (current_minor_maps): Check for size calculation overflow.
1672 * keymap.h: Change prototypes to match the above.
1673
1674 * lread.c (read1, init_obarray): Don't update size until alloc done.
1675
1676 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1677 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1678
726e0ab1
PE
1679 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1680 Now ptrdiff_t, not int.
1681 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1682 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1683
1684 * process.c (Fnetwork_interface_list): Check for overflow
1685 in size calculation.
1686
1687 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1688
1689 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1690 overflow. Don't bother calling xmalloc when xrealloc will do.
1691
1692 * search.c (Freplace_match): Check for size calculation overflow.
1693 (Fset_match_data): Don't assume list lengths fit in 'int'.
1694
1695 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1696 for command line length. Do not attempt to address one before the
1697 beginning of an array, as that's not portable.
1698
1699 * term.c (max_frame_lines): Remove; unused.
1700 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1701 not int.
1702 (encode_terminal_code, calculate_costs): Check for size
1703 calculation overflow.
1704 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1705 table lengths and related sizes. Don't update size until alloc
1706 done. Redo calculations to avoid overflow.
1707 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1708
1709 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1710 subtracting pointers.
1711 (gobble_line): Check for overflow more carefully. Don't update size
1712 until alloc done.
1713
1714 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1715 Don't update size until alloc done.
1716 Redo size calculations to avoid overflow.
1717 Check for size calculation overflow.
0065d054 1718 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1719
1720 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1721 Use ptrdiff_t, not int, for sizes.
1722 (store_mode_line_noprop_char): Don't update size until alloc done.
1723
0065d054
PE
1724 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1725 Use ptrdiff_t, not int, for sizes.
1726 (Finternal_make_lisp_face, cache_face):
1727 Check for size calculation overflow.
1728 (cache_face): Treat size calculation overflows as if they were
1729 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1730
1731 * xfns.c (x_encode_text, x_set_name_internal)
1732 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1733 sizes, since they can exceed INT_MAX in size. Check for size
1734 calculation overflow.
1735
0065d054
PE
1736 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1737 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1738 Don't update size until alloc done.
1739
0065d054 1740 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1741 as sprintf is limited to int lengths.
1d526e2f 1742
252c5ee1
PE
1743 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1744 (X_LONG_MIN): New macros.
864d7ce7
PE
1745 Use them to make the following changes clearer.
1746 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1747 This change doesn't affect the value now, but it may help remind
1748 future maintainers not to raise the value too much later.
1749 (SELECTION_QUANTUM): Remove, replacing with ...
1750 (selection_quantum): ... new function, which avoids overflow.
1751 All uses changed.
1752 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1753 assumption that selection length fits in 'int'.
1754 (x_reply_selection_request, x_handle_selection_request)
1755 (x_get_window_property, receive_incremental_selection)
1756 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1757 (lisp_data_to_selection_data, clean_local_selection_data):
1758 Use ptrdiff_t, not int, to record length of selection.
1759 (x_reply_selection_request, x_get_window_property)
1760 (receive_incremental_selection, x_property_data_to_lisp):
1761 Redo calculations to avoid overflow.
1762 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1763 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1764 something.
1765 (x_get_window_property, receive_incremental_selection)
1766 (lisp_data_to_selection_data, x_property_data_to_lisp):
1767 Check for size-calculation overflow.
1768 (x_get_window_property, receive_incremental_selection)
1769 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1770 Don't store size until memory allocation succeeds.
1771 (x_get_window_property): Plug memory leak on memory exhaustion.
1772 Don't double-block input; malloc is safe here. Don't assume 2**34
1773 - 4 fits in unsigned long. Add an xassert to check
1774 XGetWindowProperty overflow. Be more careful about overflow
1775 calculations, and distinguish size from memory overflow better.
1776 (receive_incremental_selection): When tracing, don't assume
1777 unsigned int is less than INT_MAX.
1778 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1779 harmful) conversions of unsigned short to int.
1780 (lisp_data_to_selection_data): Don't assume that integers
1781 in the range -65535 through -1 fit in an X unsigned short.
1782 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1783 result parameters unless successful. Rely on cons_to_unsigned
1784 to report problems with elements; the old code wasn't right anyway.
1785 (x_check_property_data): Check for int overflow; we cannot use
1786 a wider type due to X limits.
1787 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1788
726e0ab1 1789 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1790
0065d054
PE
1791 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1792 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1793 (x_color_cells): Don't store size until memory allocation succeeds.
1794 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1795 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1796 (x_term_init): Don't assume length fits in int (sprintf is limited
1797 to int size).
bc18e09d 1798
ebfa62c0
PE
1799 Use ptrdiff_t for composition IDs.
1800 * character.c (lisp_string_width):
1801 * composite.c (composition_table_size, n_compositions)
1802 (get_composition_id, composition_gstring_from_id):
1803 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1804 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1805 * window.c (Frecenter):
1806 Use ptrdiff_t, not int, for composition IDs.
1807 * composite.c (get_composition_id): Check for integer overflow.
1808 * composite.h: Adjust prototypes to match the above changes.
1809
d3411f89
PE
1810 Use ptrdiff_t for hash table indexes.
1811 * category.c (hash_get_category_set):
1812 * ccl.c (ccl_driver):
1813 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1814 * coding.c (coding_system_charset_list, detect_coding_system):
1815 * coding.h (struct coding_system.id):
1816 * composite.c (get_composition_id, gstring_lookup_cache):
1817 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1818 * image.c (xpm_get_color_table_h):
1819 * lisp.h (hash_lookup, hash_put):
1820 * minibuf.c (Ftest_completion):
1821 Use ptrdiff_t for hash table indexes, not int (which is too
1822 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1823 32-bit --with-wide-int hosts).
1824
e097a6fa
PE
1825 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1826 Add a FIXME comment about memory leaks.
1827 (syms_of_charset): Don't assume xmalloc returns.
1828
5637687f
PE
1829 Don't assume that stated character widths fit in int.
1830 * character.c (Fchar_width, c_string_width, lisp_string_width):
1831 * character.h (CHAR_WIDTH):
1832 * indent.c (MULTIBYTE_BYTES_WIDTH):
1833 Use sanitize_char_width to avoid undefined and/or bad behavior
1834 with outlandish widths.
a66cfb1c 1835 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1836 now that we have two such functions. All uses changed.
1837 (sanitize_char_width): New inline function.
1838
a2271ba2
PE
1839 Don't assume that tab-width fits in int.
1840 * character.h (sanitize_width): New inline function.
1841 (SANE_TAB_WIDTH): New macro.
1842 (ASCII_CHAR_WIDTH): Use it.
1843 * indent.c (sane_tab_width): Remove. All uses replaced by
1844 SANE_TAB_WIDTH (current_buffer).
1845 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1846
18c52557
PE
1847 * fileio.c: Integer overflow issues with file modes.
1848 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1849
caeeedc1
PE
1850 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1851 Remove unreachable code.
1852 (read_hex, load_charset_map_from_file): Check for integer overflow.
1853
50849c52
PE
1854 * xterm.c: don't go over XClientMessageEvent limit
1855 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1856 (x_send_scroll_bar_event): Likewise. Check that the size does not
1857 exceed limits imposed by XClientMessageEvent, as well as the usual
1858 ptrdiff_t and size_t limits.
1859
b13995db
PE
1860 * keyboard.c: Overflow, signedness and related fixes.
1861 (make_lispy_movement): Use same integer type in forward decl
1862 that is used in the definition.
1863 (read_key_sequence, keyremap_step):
1864 Change bufsize argument back to int, undoing my 2011-03-30 change.
1865 We prefer signed types, and int is wide enough here.
1866 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1867 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1868 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1869 length, not size_t. Use ptrdiff_t for index, not int.
1870 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1871 possibility of integer overflow.
1872
13464394
PE
1873 Overflow, signedness and related fixes for images.
1874
1875 * dispextern.h (struct it.stack[0].u.image.image_id)
1876 (struct_it.image_id, struct image.id, struct image_cache.size)
1877 (struct image_cache.used, struct image_cache.ref_count):
1878 * gtkutil.c (update_frame_tool_bar):
1879 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1880 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1881 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1882 * nsmenu.m (update_frame_tool_bar):
1883 * xdisp.c (calc_pixel_width_or_height):
1884 * xfns.c (image_cache_refcount):
1885 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1886 on typical 64-bit hosts.
1887
1888 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1889 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1890 Omit unnecessary casts to int.
1891 (parse_image_spec): Check that integers fall into 'int' range
1892 when the callers expect that.
1893 (image_ascent): Redo ascent calculation to avoid int overflow.
1894 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1895 (lookup_image): Remove unnecessary tests.
1896 (xbm_image_p): Locals are now of int, not EMACS_INT,
1897 since parse_image_check makes sure they fit into int.
1898 (png_load, gif_load, svg_load_image):
1899 Prefer int to unsigned where either will do.
1900 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1901 old tiff_error_handler and tiff_warning_handler.
1902 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1903 stack buffer overflows. It uses only the features of vsnprintf
1904 that are common to both POSIX and native Microsoft.
1905 (tiff_error_handler, tiff_warning_handler): Use it.
1906 (tiff_load, gif_load, imagemagick_load_image):
1907 Don't assume :index value fits in 'int'.
1908 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1909 (imagemagick_load_image): Check that crop parameters fit into
1910 the integer types that MagickCropImage accepts. Don't assume
1911 Vimagemagick_render_type has a nonnegative value. Don't assume
1912 size_t fits in 'long'.
1913 (gs_load): Use printmax_t to print the widest integers possible.
1914 Check for integer overflow when computing image height and width.
1915
c11821d4
EZ
19162011-08-26 Eli Zaretskii <eliz@gnu.org>
1917
1918 * xdisp.c (redisplay_window): Don't force window start if point
1919 will be invisible in the resulting window. (Bug#9324)
1920
0c95fcf7
EZ
19212011-08-25 Eli Zaretskii <eliz@gnu.org>
1922
1923 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1924 the display spec is of the form `(space ...)'.
1925 (handle_display_spec): Return the value returned by
1926 handle_single_display_spec, not just 1 or zero.
1927 (handle_single_display_spec): If the display spec is of the form
1928 `(space ...)', and specifies display in the text area, return 2
1929 rather than 1.
fee65a97 1930 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1931 accurately, and prefer exact match for point under bidi.
1932 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1933
1934 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1935 into disp_prop; all users changed.
1936
1937 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1938 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1939 for the text covered by the display property.
1940
e4ed06f1
CY
19412011-08-25 Chong Yidong <cyd@stupidchicken.com>
1942
1943 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1944 Change return value to nil.
1945 (Frecord_buffer): Delete unused function.
1946
f67cdd7f
EZ
19472011-08-24 Eli Zaretskii <eliz@gnu.org>
1948
5980d4c6
EZ
1949 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1950 buffers, return left-to-right.
8610fe8b
EZ
1951 (set_cursor_from_row): Consider candidate row a win if its glyph
1952 represents a newline and point is on that newline. Fixes cursor
1953 positioning on the newline at EOL of R2L text within L2R
1954 paragraph, and vice versa.
1955 (try_cursor_movement): Check continued rows, in addition to
1956 continuation rows. Fixes unwarranted scroll when point enters a
1957 continued line of R2L text within an L2R paragraph, or vice versa.
1958 (cursor_row_p): Consider the case of point being equal to
1959 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1960 from the end of a short line to the beginning of a continued line
1961 of R2L text within L2R paragraph.
1962 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1963 composed characters.
5980d4c6 1964
f67cdd7f
EZ
1965 * bidi.c (bidi_check_type): Use xassert.
1966 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1967 members.
1968
bca633fb
EZ
19692011-08-23 Eli Zaretskii <eliz@gnu.org>
1970
1971 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1972 a character.
1973
4a5885a7
CY
19742011-08-23 Chong Yidong <cyd@stupidchicken.com>
1975
1976 * nsfont.m (ns_otf_to_script): Fix typo.
1977
0902a04e
KH
19782011-08-22 Kenichi Handa <handa@m17n.org>
1979
1980 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1981 extra slot even if the purpose is char-code-property-table.
1982
1a2e6670
EZ
19832011-08-23 Eli Zaretskii <eliz@gnu.org>
1984
8ddde651
EZ
1985 * xdisp.c (redisplay_window): When computing centering_position,
1986 account for the height of the header line. (Bug#8874)
1987
425cc014
EZ
1988 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1989 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1990 candidate is selected by the mouse, and that candidate has a
1991 composed character under the mouse.
1992
1a2e6670
EZ
1993 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1994 coordinates reported by pos-visible-in-window-p for a composed
1995 character in column zero.
1996
8b76d6f8
SM
19972011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1998
1999 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2000
dac347dd
EZ
20012011-08-22 Eli Zaretskii <eliz@gnu.org>
2002
2003 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2004 consider it a hit if to_charpos is anywhere in the range of the
2005 composed buffer positions.
2006
e013fb34
CY
20072011-08-22 Chong Yidong <cyd@stupidchicken.com>
2008
2009 * image.c (gif_load): Don't assume that each subimage has the same
2010 dimensions as the base image. Handle disposal method that is
2011 "undefined" by the gif spec (Bug#9335).
2012
bd1ba3e8
CY
20132011-08-20 Chong Yidong <cyd@stupidchicken.com>
2014
2015 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2016 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2017
54a1215b
EZ
20182011-08-19 Eli Zaretskii <eliz@gnu.org>
2019
823564e5
EZ
2020 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2021 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2022 from an Org mode buffer to a Speedbar frame.
2023
54a1215b
EZ
2024 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2025 a composition, take its buffer position from IT->cmp_it.charpos.
2026 Fixes cursor positioning at the beginning of a line that begins
2027 with a composed character.
2028
9778ebcc
EZ
20292011-08-18 Eli Zaretskii <eliz@gnu.org>
2030
0be6ee06
EZ
2031 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2032 character bidirectional type, use STRONG_L instead. Fixes crashes
2033 in a buffer produced by `describe-categories'.
2034
9778ebcc
EZ
2035 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2036 members before the level stack, so they would be saved and
2037 restored when copying iterator state. Fixes incorrect reordering
2038 around TABs covered by display properties.
2039
156bffbe
AS
20402011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2041
6b02f655 2042 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2043
72ad093b
CY
20442011-08-17 Chong Yidong <cyd@stupidchicken.com>
2045
2046 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2047 (internal_condition_case_2, internal_condition_case_n):
2048 Remove unnecessary aborts (Bug#9081).
72ad093b 2049
35774242
EZ
20502011-08-17 Eli Zaretskii <eliz@gnu.org>
2051
2052 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2053 has no `load' handler, try opening the file locally. (Bug#9311)
2054
db76dd85
KB
20552011-08-16 Ken Brown <kbrown@cornell.edu>
2056
2057 * gmalloc.c: Expand comment.
2058
b215eee5
EZ
20592011-08-16 Eli Zaretskii <eliz@gnu.org>
2060
2061 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2062 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2063
a4579d33
KB
20642011-08-16 Ken Brown <kbrown@cornell.edu>
2065
2066 Fix memory allocation problems in Cygwin build (Bug#9273).
2067
2068 * unexcw.c ( __malloc_initialized): Declare external variable.
2069 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2070
8b76d6f8
SM
2071 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2072 New variables.
a4579d33
KB
2073 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2074 dumped emacs.
2075 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2076 in the static heap.
2077 [CYGWIN] (special_realloc): New function.
2078 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2079 requests to realloc storage in the static heap.
2080
3ebec551
PE
20812011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 * bidi.c (bidi_initialize): Remove unused local.
2084
9fd8be00
EZ
20852011-08-15 Eli Zaretskii <eliz@gnu.org>
2086
6b02f655
SM
2087 * bidimirror.h:
2088 * biditype.h: Remove file.
2089 * makefile.w32-in ($(BLD)/bidi.$(O)):
2090 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2091
2092 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2093
2094 * chartab.c: Improve commentary for the uniprop_table API.
2095
32413314
EZ
2096 * bidi.c (bidi_paragraph_init): Support zero value of
2097 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2098 (bidi_initialize): Use uniprop_table instead of including
2099 biditype.h and bidimirror.h.
32413314 2100
9fd8be00
EZ
2101 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2102 coordinates of the iterator when restoring from ppos_it.
2103 (Bug#9296)
2104
5cf2b69b
KH
21052011-08-14 Kenichi Handa <handa@m17n.org>
2106
2107 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2108 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2109
daf17d00
EZ
21102011-08-14 Eli Zaretskii <eliz@gnu.org>
2111
2112 * xdisp.c (move_it_in_display_line_to): Don't invoke
2113 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2114 ppos_it. Fixes vertical cursor motion when line beginning is
2115 covered by an image. (Bug#9296)
2116
08e3161a
JD
21172011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2118
2119 * nsterm.h (ns_run_ascript): Declare.
2120 (NSAPP_DATA2_RUNASSCRIPT): Define.
2121
2122 * nsfns.m (as_script, as_result, as_status): New static variables.
2123 (ns_run_ascript): New function.
5e617bc2 2124 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2125 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2126 the event loop. Get status from as_status (Bug#7276).
2127
2128 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2129 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2130 the event loop (Bug#7276).
2131
a3720aa2
AS
21322011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2133
2134 * gnutls.c (QCgnutls_bootprop_priority)
2135 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2136 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2137 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2138 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2139 (QCgnutls_bootprop_verify_hostname_error)
2140 (QCgnutls_bootprop_callbacks_verify): Rename from
2141 Qgnutls_bootprop_..., all uses changed.
2142
2143 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2144 uses changed.
2145
0a0d27fb
PE
21462011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2147
19d5c50c
PE
2148 * xfaces.c (Qframe_set_background_mode): Now static.
2149 * dispextern.h (Qframe_set_background_mode): Remove decl.
2150
0a0d27fb
PE
2151 * process.c (Fnetwork_interface_info): Declare local only if needed.
2152
377538cb
JD
21532011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2154
2155 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2156 (Fnetwork_interface_list): Allocate in increments of bytes instead
2157 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2158 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2159 sockaddr.
2160 (struct ifflag_def): notrailers is smart on OSX.
2161 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2162 Get hardware address with getifaddrs if available.
2163
08fff70c
EZ
21642011-08-12 Eli Zaretskii <eliz@gnu.org>
2165
2166 * xdisp.c (iterate_out_of_display_property): xassert that
2167 IT->position is set to within IT->object's boundaries. Break from
2168 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2169 when IT->position is set up wrongly due to some bug.
2170 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2171 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2172 entry. Force push_it to save on the stack the current
2173 buffer/string position, to be restored by pop_it. Fix flags in
2174 the iterator structure wrt the object coming from a display
2175 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2176 properties. (Bug#9284)
2177
7be1c708 21782011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2179
7be1c708
CY
2180 * fontset.c (fontset_get_font_group): Add proper type checks.
2181 (Bug#9172)
aac0c6e3 2182
7be1c708 21832011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2184
7be1c708
CY
2185 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2186 and LC_VERSION_MIN_MACOSX.
2187 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2188 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2189
97bb72a6
EZ
21902011-08-08 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2193 no-display-properties-and-no-overlays under bidi display.
2194 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2195 properties and overlays.
97bb72a6 2196
d5617611
CY
21972011-08-08 Chong Yidong <cyd@stupidchicken.com>
2198
37e11a63
CY
2199 * editfns.c (Fset_time_zone_rule): Document relationship with the
2200 setenv function.
2201
d5617611
CY
2202 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2203 the font entity extracted from the cache (Bug#8109).
2204
58872834
CY
22052011-08-07 Chong Yidong <cyd@stupidchicken.com>
2206
2207 * composite.c (autocmp_chars): Don't reset point. That is done by
2208 restore_point_unwind (Bug#5984).
2209
75bfc667
JL
22102011-08-07 Juri Linkov <juri@jurta.org>
2211
2212 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2213 to show the arg `TIME' instead of `TIMEVAL'.
2214
d1410150
EZ
22152011-08-06 Eli Zaretskii <eliz@gnu.org>
2216
2217 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2218 display property strides EOL and includes a newline, as in
2219 longlines-mode. (Bug#9254)
75b771e4
EZ
2220 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2221 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2222
2223 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2224 is non-zero, even if the data buffer is NULL. Fixes a crash in
2225 vertical-motion with longlines-mode. (Bug#9254)
2226
35928349
EZ
22272011-08-05 Eli Zaretskii <eliz@gnu.org>
2228
ec7cc85b
EZ
2229 * bidi.c <bidi_cache_total_alloc>: Now static.
2230 (bidi_initialize): Initialize bidi_cache_total_alloc.
2231
8b76d6f8 2232 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2233 cache. (Bug#9221)
2234
2235 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2236 amount allocated this far in `bidi_cache_total_alloc'.
2237 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2238 non-zero, only free the data buffer without restoring the cache
2239 contents. All callers changed.
2240
2241 * dispextern.h (bidi_unshelve_cache): Update prototype.
2242
2243 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2244 (move_it_in_display_line, move_it_to)
2245 (move_it_vertically_backward, move_it_by_lines): Replace the call
2246 to xfree to an equivalent call to bidi_unshelve_cache.
2247 (move_it_in_display_line_to): Fix logic of returning
412b6358 2248 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2249
e2e2423b
EZ
22502011-08-05 Eli Zaretskii <eliz@gnu.org>
2251
2252 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2253 came from a string character with a `cursor' property. (Bug#9229)
2254
ae9e757a
JD
22552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2256
2257 * Makefile.in (LIB_PTHREAD): New variable.
2258 (LIBES): Add LIB_PTHREAD (Bug#9216).
2259
2260 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2261 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2262
213bd7f2
AS
22632011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2264
6b02f655 2265 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2266
99aaf75f
JD
22672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2268
2269 * xterm.c (x_find_topmost_parent): New function.
2270 (x_set_frame_alpha): Find topmost parent window with
2271 x_find_topmost_parent and set the property there also (bug#9181).
2272 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2273
c74e9d86
PE
22742011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 * callproc.c (Fcall_process): Avoid vfork clobbering
2277 the local vars buffer, coding_systems, current_dir.
2278
640c8776
SM
22792011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2280
2281 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2282
f26d0e4c
PE
22832011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2284
8a10d76c
PE
2285 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2286 so that it is not optimized away.
2287
f26d0e4c
PE
2288 * xdisp.c (compute_display_string_pos): Remove unused local.
2289
55439c61
EZ
22902011-08-02 Eli Zaretskii <eliz@gnu.org>
2291
2292 Fix slow cursor motion and scrolling in large buffers with
2293 selective display, like Org Mode buffers. (Bug#9218)
2294
2295 * dispextern.h (struct bidi_it): New member disp_prop_p.
2296
2297 * xdisp.c: Remove one-slot cache of display string positions.
2298 (compute_display_string_pos): Accept an additional argument
5e617bc2 2299 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2300 for a display string or property. If found, set DISP_PROP_P
2301 non-zero.
2302
2303 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2304 DISP_PROP_P, and pass it to compute_display_string_pos.
2305 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2306 non-zero. All callers of bidi_fetch_char changed.
2307
fb33fa43
SM
23082011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2309
2310 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2311
b099e063
DM
23122010-12-03 Don March <don@ohspite.net>
2313
2314 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2315 last character M-[char] is translated to ESC [char] (bug#7541).
2316
5cc7f7af
KH
23172011-08-02 Kenichi Handa <handa@m17n.org>
2318
d0fffa3f 2319 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2320
2321 * chartab.c (uniprop_table): Make it non-static.
2322
525d5e6e
EZ
23232011-08-01 Eli Zaretskii <eliz@gnu.org>
2324
2325 * xdisp.c (forward_to_next_line_start): Accept additional argument
2326 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2327 on the newline.
2328 (reseat_at_next_visible_line_start): Use the bidi iterator state
2329 returned by forward_to_next_line_start to restore the state of
2330 it->bidi_it after backing up to previous newline. (Bug#9212)
2331
31011111
AS
23322011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2333
2334 * regex.c (re_comp): Protoize.
2335 (re_exec): Fix return type.
2336 (regexec): Fix type of `ret'. (Bug#9203)
2337
476371c4
PE
23382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2339
e5d76069
PE
2340 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2341 This is needed if max-image-size is a floating-point number.
2342
9a79b20c
AS
23432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2344
2345 * print.c (print_object): Print empty symbol as ##.
2346
2347 * lread.c (read1): Read ## as empty symbol.
2348
d8c2fa78
AA
23492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2350
2351 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2352 setting frame foreground color (Bug#9175).
2353 (x_set_background_color): Likewise.
2354
ffe57a7a
AA
2355 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2356 contents (Bug#9176).
2357 (EmacsTooltip -init): Remove bezels and add shadows to
2358 tooltip windows.
2359
bf3492a5
AA
2360 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2361 or scroll bar (Bug#8470).
2362
d55e9c53
AA
2363 * nsfont.m (nsfont_open): Remove assignment to voffset and
2364 unnecessary vars hshink, expand, hd, full_height, min_height.
2365 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2366
2367 * nsterm.h (nsfont_info): Remove voffset field.
2368
d8c2fa78 23692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2370
2371 Implement strike-through and overline on NextStep (Bug#8863).
2372
2373 * nsfont.m (nsfont_open): Use underline position provided by font,
2374 instead of hard-coded value of 2.
2375 (nsfont_draw): Call ns_draw_text_decoration instead.
2376
2377 * nsterm.h: Add declaration for ns_draw_text_decoration.
2378
2379 * nsterm.m (ns_draw_text_decoration): New function for drawing
2380 underline, overline, and strike-through.
2381 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2382 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2383 accommodate underlining, etc.
4843aac3 2384
4cc60b9b
EZ
23852011-07-28 Eli Zaretskii <eliz@gnu.org>
2386
bc7ece87
EZ
2387 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2388 default.
4cc60b9b 2389
476371c4
PE
23902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2391
66606eea
PE
2392 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2393 Without this fix, if a signal arrives just after memory fills up,
2394 'malloc' might be invoked reentrantly.
2395
476371c4
PE
2396 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2397 In other words, assume that every image size is allowed, on non-X
2398 hosts. This assumption is probably wrong, but it lets Emacs compile.
2399
f3fcc40d
AS
24002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2401
2402 * regex.c (re_iswctype): Convert return values to boolean.
2403
350c992f
EZ
24042011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2405
2406 * xdisp.c (compute_display_string_pos): Don't use cached display
2407 string position if the buffer had its restriction changed.
2408 (Bug#9184)
2409
5266b4bb
PE
24102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2413
2573a837 24142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2415
41f55ccd 2416 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2417
39e378da
PE
2418 * bidi.c: Integer size and overflow fixes.
2419 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2420 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2421 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2422 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2423 (bidi_find_other_level_edge):
2424 Use ptrdiff_t instead of EMACS_INT where either will do.
2425 This works better on 32-bit hosts configured --with-wide-int.
2426 (bidi_cache_ensure_space): Check for size-calculation overflow.
2427 Use % rather than repeated addition, for better worst-case speed.
2428 Don't set bidi_cache_size until after xrealloc returns, because it
2429 might not return.
2430 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2431 (bidi_cache_ensure_space): Also check that the bidi cache size
2432 does not exceed that of the largest Lisp string or buffer. See Eli
2433 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2434
5e927815
PE
2435 * alloc.c (__malloc_size_t): Remove.
2436 All uses replaced by size_t. See Andreas Schwab's note
2437 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2438
ca4aa935
PE
2439 * image.c: Improve checking for integer overflow.
2440 (check_image_size): Assume that f is nonnull, since
2441 it is always nonnull in practice. This is one less thing to
2442 worry about when checking for integer overflow later.
2443 (x_check_image_size): New function, which checks for integer
2444 overflow issues inside X.
2445 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2446 This removes the need for a memory_full check.
2447 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2448 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2449 (xbm_read_bitmap_data): Change locals back to 'int', since
2450 their values must fit in 'int'.
2451 (xpm_load_image, png_load, tiff_load):
2452 Invoke x_create_x_image_and_pixmap earlier,
2453 to avoid much needless work if the image is too large.
2454 (tiff_load): Treat overly large images as if
2455 x_create_x_image_and_pixmap failed, not as malloc failures.
2456 (gs_load): Use x_check_image_size.
2457
5f8f9cc2
PE
2458 * gtkutil.c: Omit integer casts.
2459 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2460 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2461
5adf60bc
PE
2462 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2463
c8907a93
PE
2464 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2465 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2466 would wrongly return t on a 64-bit host.
2467
e3c25c68
PE
2468 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2469 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2470 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2471 and therefore cause GCC to emit a bogus diagnostic in some cases.
2472
3f791afe
PE
2473 * image.c: Integer signedness and overflow and related fixes.
2474 This is not an exhaustive set of fixes, but it's time to
2475 record what I've got.
2476 (lookup_pixel_color, check_image_size): Remove redundant decls.
2477 (check_image_size): Don't assume that arbitrary EMACS_INT values
2478 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2479 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2480 (tiff_load, imagemagick_load_image):
2481 Check for overflow in size calculations.
2482 (x_create_x_image_and_pixmap): Remove unnecessary test for
2483 xmalloc returning NULL; that can't happen.
2484 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2485 (xpm_color_bucket): Use better integer hashing function.
2486 (xpm_cache_color): Don't possibly over-allocate memory.
2487 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2488 (gif_memory_source):
2489 Use ptrdiff_t, not int or size_t, to record sizes.
2490 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2491 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2492 either works, as we prefer signed integers.
2493 (tiff_read_from_memory, tiff_write_from_memory):
2494 Return tsize_t, not size_t, since that's what the TIFF API wants.
2495 (tiff_read_from_memory): Don't fail simply because the read would
2496 go past EOF; instead, return a short read.
2497 (tiff_load): Omit no-longer-needed casts.
2498 (Fimagemagick_types): Don't assume size fits into 'int'.
2499
3cc5a532
PE
2500 Improve hashing quality when configured --with-wide-int.
2501 * fns.c (hash_string): New function, taken from sxhash_string.
2502 Do not discard information about ASCII character case; this
2503 discarding is no longer needed.
2504 (sxhash-string): Use it. Change sig to match it. Caller changed.
2505 * lisp.h: Declare it.
2506 * lread.c (hash_string): Remove, since we now use fns.c's version.
2507 The fns.c version returns a wider integer if --with-wide-int is
2508 specified, so this should help the quality of the hashing a bit.
2509
b312a492
PE
2510 * emacs.c: Integer overflow minor fix.
2511 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2512 Define only if GNU_LINUX.
2513 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2514
dfd153ae
PE
2515 * dispnew.c: Integer signedness and overflow fixes.
2516 Remove unnecessary forward decls, that were a maintenance hassle.
2517 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2518 All uses changed.
2519 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2520 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2521 (prepare_desired_row, line_draw_cost):
2522 Use int, not unsigned, where either works.
2523 (save_current_matrix, restore_current_matrix):
2524 Use ptrdiff_t, not size_t, where either works.
2525 (init_display): Check for overflow more accurately, and without
2526 relying on undefined behavior.
2527
a81d11a3
PE
2528 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2529 Remove, replacing with the new symbols in lisp.h. All uses changed.
2530 * fileio.c (make_temp_name):
2531 * filelock.c (lock_file_1, lock_file):
2532 * xdisp.c (message_dolog):
2533 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2534 Use pMd etc. instead.
2535 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2536 replacing the pWIDE etc. symbols removed from editfns.c.
2537
3300e6fd
PE
2538 * keyboard.h (num_input_events): Now uintmax_t.
2539 This is (very slightly) less likely to mess up due to wraparound.
2540 All uses changed.
2541
fd05c7e9
PE
2542 * buffer.c: Integer signedness fixes.
2543 (alloc_buffer_text, enlarge_buffer_text):
2544 Use ptrdiff_t rather than size_t when either will do, as we prefer
2545 signed integers.
2546
903fe15d
PE
2547 * alloc.c: Integer signedness and overflow fixes.
2548 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2549 (__malloc_size_t): Default to size_t, not to int.
2550 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2551 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2552 Prefer ptrdiff_t to size_t when either would do, as we prefer
2553 signed integers.
2554 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2555 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2556 Now const. Initialize with values that are in range even if char
2557 is signed.
2558 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2559 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2560 These functions do the right thing with sizes > 2**32.
2561 (check_depth): Now ptrdiff_t, not int.
2562 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2563 Adjust to new way of storing sizes. Check for size overflow bugs
2564 in rest of code.
2565 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2566 slightly wrong anyway, as it missed one instance of
2567 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2568 (refill_memory_reserve): Omit needless cast to size_t.
2569 (mark_object_loop_halt): Mark as externally visible.
2570
ac82cc6a
PE
2571 * xselect.c: Integer signedness and overflow fixes.
2572 (Fx_register_dnd_atom, x_handle_dnd_message):
2573 Use ptrdiff_t, not size_t, since we prefer signed.
2574 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2575 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2576 x_dnd_atoms_size and x_dnd_atoms_length.
2577
c2d1e36d
PE
2578 * doprnt.c: Prefer signed to unsigned when either works.
2579 * eval.c (verror):
2580 * doprnt.c (doprnt):
2581 * lisp.h (doprnt):
2582 * xdisp.c (vmessage):
2583 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2584 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2585 prefer signed arithmetic to avoid comparison confusion.
2586 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2587 but is a bit tricky.
2588
0e926e56
PE
2589 Assume freestanding C89 headers, string.h, stdlib.h.
2590 * data.c, doprnt.c, floatfns.c, print.c:
2591 Include float.h unconditionally.
2592 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2593 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2594 * regex.c: Likewise for stddef.h, string.h.
2595 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2596 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2597 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2598 (STDC_HEADERS): Remove obsolete defines.
2599 * sysdep.c: Include limits.h unconditionally.
2600
9cfdb3ec
PE
2601 Assume support for memcmp, memcpy, memmove, memset.
2602 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2603 * regex.c (memcmp, memcpy):
2604 Remove; we assume C89 now.
2605
2606 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2607 (__malloc_safe_bcopy): Remove; no longer needed.
2608
cf950e6b 2609 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2610 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2611 well either way, and we prefer signed to unsigned.
2612
dbf38e02
LMI
26132011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2614
2615 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2616 closes the connection while we're reading (bug#9182).
2617
d6f0886c 26182011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2619
d6f0886c
JD
2620 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2621 are specified (Bug#9168).
24e0f6b1 2622
2eb1f9e6
PE
26232011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2626 Found by GCC static checking and --with-wide-int on a 32-bit host.
2627
22381272 26282011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2629
2630 * xdisp.c (compute_display_string_pos): Fix logic of caching
2631 previous display string position. Initialize cached_prev_pos to
2632 -1. Fixes slow-down at the beginning of a buffer.
2633
f25e39b4
EZ
26342011-07-24 Eli Zaretskii <eliz@gnu.org>
2635
2636 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2637 for attrs[LFACE_FONTSET_INDEX].
2638
04c4b52e
PE
26392011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2640
2641 * xml.c (parse_region): Remove unused local
2642 that was recently introduced.
2643
c1734fbd
EZ
26442011-07-23 Eli Zaretskii <eliz@gnu.org>
2645
be18c5a5
EZ
2646 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2647 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2648
c1734fbd
EZ
2649 * xdisp.c (move_it_in_display_line_to): Record the best matching
2650 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2651 exit if none of the characters scanned was an exact match.
2652 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2653 when exact match is impossible due to invisible text, and the
2654 lines are truncated.
2655
a258d627
JD
26562011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2657
2658 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2659 for OSX >= 10.7.
2660
b6d5a689
EZ
26612011-07-22 Eli Zaretskii <eliz@gnu.org>
2662
0f74f785
EZ
2663 Fix a significant slow-down of cursor motion with C-n, C-p,
2664 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2665 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2666 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2667 (next_element_from_buffer): Call compute_stop_pos_backwards to
2668 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2669 base_level_stop.
2670 (reseat): Don't look for prev_stop, as that could mean a very long
2671 run.
2672 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2673 <cached_disp_overlay_modiff>: Cache for last found display string
2674 position.
551918c1 2675 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2676 about the same buffer in the same area of character positions, and
2677 the buffer wasn't changed since the time the display string
2678 position was cached.
551918c1 2679
b2d0c91a
EZ
26802011-07-22 Eli Zaretskii <eliz@gnu.org>
2681
2682 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2683 is an integer, which is important for empty lines. (Bug#9149)
2684
043604ee
CY
26852011-07-22 Chong Yidong <cyd@stupidchicken.com>
2686
2687 * frame.c (Fmodify_frame_parameters): In tty case, update the
2688 default face if necessary (Bug#4238).
2689
da4adb04
CY
26902011-07-21 Chong Yidong <cyd@stupidchicken.com>
2691
2692 * editfns.c (Fstring_to_char): No need to explain what a character
2693 is in the docstring (Bug#6576).
2694
9abd0532
LMI
26952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2696
2697 * xml.c (parse_region): Make sure we always return a tree.
2698
36881d16
HK
26992011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2700
2701 * xml.c (parse_region): If a document contains only comments,
2702 return that, too.
2703
1e98674d
LMI
27042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2705
2706 * xml.c (make_dom): Return comments, too.
2707
590bd467
PE
27082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2709
2710 Port to OpenBSD.
2711 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2712 and the surrounding thread.
2713 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2714 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2715 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2716 timer goes off.
2717 * s/openbsd.h (BROKEN_SIGIO): Define.
2718 * unexelf.c (unexec) [__OpenBSD__]:
2719 Don't update the .mdebug section of the Alpha COFF symbol table.
2720
f41628b2
LMI
27212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2722
2723 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2724 (bug#8460).
2725
b59b67c5
PE
27262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2727
15e3a074
PE
2728 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2729 This fixes some race conditions on the permissions of any newly
2730 created file.
2731
41bed37d
PE
2732 * alloc.c (valid_pointer_p): Use pipe, not open.
2733 This fixes some permissions issues when debugging.
2734
b59b67c5
PE
2735 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2736 If fchown fails to set both uid and gid, try to set just gid,
2737 as that is sometimes allowed. Adjust the file's mode to eliminate
2738 setuid or setgid bits that are inappropriate if fchown fails.
2739
925a6be7
SM
27402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2741
2742 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2743 to compare Lisp_Objects.
2744 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2745 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2746 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2747
52968808
AS
27482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2749
0a6a104b
AS
2750 * lread.c (read_integer): Unread even EOF character.
2751 (read1): Likewise. Properly record start position of symbol.
2752
52968808
AS
2753 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2754 symbol character follows.
2755
9e381cdd
PE
27562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2757
2758 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2759 This works around a problem with the previous change to Fcopy_file.
2760 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2761 and without this change, GCC might complain about discarding
2762 fchown's return value.
2763
b5641435
JB
27642011-07-16 Juanma Barranquero <lekktu@gmail.com>
2765
2766 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2767
a8031457
PE
27682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2769
2770 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2771
dd889327
LMI
27722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2773
750c33f7
LMI
2774 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2775 it's used from the C level.
2776
dd889327
LMI
2777 * process.c: Use the same condition for POLL_FOR_INPUT in both
2778 keyboard.c and process.c (bug#1858).
2779
87e86684
LM
27802011-07-09 Lawrence Mitchell <wence@gmx.li>
2781
2782 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2783 (Fgnutls_boot): Use it.
2784
64348f40
AS
27852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2786
2787 * doc.c (Fsubstitute_command_keys): Revert last change.
2788
1d698799
LMI
27892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2790
f863868c
LMI
2791 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2792 quotes the next character, and doesn't affect other longer
2793 sequences (bug#8935).
2794
1d698799
LMI
2795 * lread.c (syms_of_lread): Clarify that is isn't only
2796 `eval-buffer' and `eval-defun' that's affected by
2797 `lexical-binding' (bug#8460).
2798
aa4b6df6
EZ
27992011-07-15 Eli Zaretskii <eliz@gnu.org>
2800
2801 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2802 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2803
5d856da6
PE
28042011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2805
ad6042bb
PE
2806 Fix minor problems found by static checking.
2807 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2808 (elsz): Now a signed constant, not a size_t var. We prefer signed
2809 types to unsigned, to avoid integer comparison confusion. Without
2810 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2811 "cannot optimize loop, the loop counter may overflow", a symptom
2812 of the confusion.
f00bbb22 2813 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2814 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2815
6468f31c
LMI
28162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2817
49080b10
LMI
2818 * search.c (Fre_search_backward): Mention `case-fold-search' in
2819 all the re_search_* functions (bug#8138).
2820
6468f31c
LMI
2821 * keyboard.c (Fopen_dribble_file): Document when the file is
2822 closed (bug#8056).
2823
c965adc5
EZ
28242011-07-14 Eli Zaretskii <eliz@gnu.org>
2825
df9733bf
EZ
2826 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2827 bidi_cache_idx.
2828
0bb23927
EZ
2829 Support bidi reordering of display and overlay strings.
2830 * xdisp.c (compute_display_string_pos)
2831 (compute_display_string_end): Accept additional argument STRING.
2832 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2833 (reseat_to_string): Initialize bidi_it->string.s and
2834 bidi_it->string.schars.
2835 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2836 NULL (avoids a crash in bidi_paragraph_init).
2837 Initialize itb.string.lstring.
0bb23927
EZ
2838 (init_iterator): Call bidi_init_it only of a valid
2839 buffer position was specified. Initialize paragraph_embedding to
2840 L2R.
2841 (reseat_to_string): Initialize the bidi iterator.
2842 (display_string): If we need to ignore text properties of
2843 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2844 original value of -1 will not work with bidi.)
2845 (compute_display_string_pos): First arg is now struct
2846 `text_pos *'; all callers changed. Support display properties on
2847 Lisp strings.
2848 (compute_display_string_end): Support display properties on Lisp
2849 strings.
2850 (init_iterator, reseat_1, reseat_to_string): Initialize the
2851 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2852 when iterating on a string not from display properties).
640c8776
SM
2853 (compute_display_string_pos, compute_display_string_end):
2854 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2855 arrow keys.
2856 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2857 base_level_stop; instead, set base_level_stop to BEGV.
2858 Fixes crashes in vertical-motion.
0bb23927
EZ
2859 (next_element_from_buffer): Improve commentary for when
2860 the iterator is before prev_stop.
2861 (init_iterator): Initialize bidi_p from the default value of
2862 bidi-display-reordering, not from buffer-local value. Use the
2863 buffer-local value only if initializing for buffer iteration.
2864 (handle_invisible_prop): Support invisible properties on strings
2865 that are being bidi-reordered.
2866 (set_iterator_to_next): Support bidi reordering of C strings and
2867 Lisp strings.
2868 (next_element_from_string): Support bidi reordering of Lisp
2869 strings.
2870 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2871 (display_string): Support display of R2L glyph rows.
2872 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2873 (init_iterator): Don't initialize it->bidi_p for strings
2874 here.
2875 (reseat_to_string): Initialize it->bidi_p for strings here.
2876 (next_element_from_string, next_element_from_c_string)
2877 (next_element_from_buffer): Add xassert's for correspondence
2878 between IT's object being iterated and it->bidi_it.string
2879 structure.
2880 (face_before_or_after_it_pos): Support bidi iteration.
2881 (next_element_from_c_string): Handle the case of the first string
2882 character that is not the first one in the visual order.
2883 (get_visually_first_element): New function, refactored from common
2884 parts of next_element_from_buffer, next_element_from_string, and
2885 next_element_from_c_string.
2886 (tool_bar_lines_needed, redisplay_tool_bar)
2887 (display_menu_bar): Force left-to-right direction. Add a FIXME
2888 comment for making that be controlled by a user option.
2889 (push_it, pop_it): Save and restore the state of the
2890 bidi iterator. Save and restore the bidi_p flag.
2891 (pop_it): Iterate out of display property for string iteration as
2892 well.
2893 (iterate_out_of_display_property): Support iteration over strings.
2894 (handle_single_display_spec): Set up it->bidi_it for iteration
2895 over a display string, and call bidi_init_it.
2896 (handle_single_display_spec, next_overlay_string)
2897 (get_overlay_strings_1, push_display_prop): Set up the bidi
2898 iterator for displaying display or overlay strings.
2899 (forward_to_next_line_start): Don't use the shortcut if
2900 bidi-iterating.
2901 (back_to_previous_visible_line_start): If handle_display_prop
2902 pushed the iterator stack, restore the internal state of the bidi
2903 iterator by calling bidi_pop_it same number of times.
2904 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2905 and we are bidi-iterating, don't decrement the iterator position;
2906 instead, set the first_elt flag in the bidi iterator, to produce
2907 the same effect.
2908 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2909 (push_display_prop): xassert that we are iterating a buffer.
2910 (push_it, pop_it): Save and restore paragraph_embedding member.
2911 (handle_single_display_spec, next_overlay_string)
2912 (get_overlay_strings_1, reseat_1, reseat_to_string)
2913 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2914 correctly. Don't assume unibyte strings are not bidi-reordered.
2915 (compute_display_string_pos)
2916 (compute_display_string_end): Fix handling the case of C string.
2917 (push_it, pop_it): Save and restore from_disp_prop_p.
2918 (handle_single_display_spec, push_display_prop): Set the
2919 from_disp_prop_p flag.
2920 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2921 (pop_it): Call iterate_out_of_display_property only if we are
2922 popping after iteration over a string that came from a display
2923 property. Fix a typo in popping stretch info. Add an assertion
2924 for verifying that the iterator position is in sync with the bidi
2925 iterator.
2926 (handle_single_display_spec, get_overlay_strings_1)
2927 (push_display_prop): Fix initialization of paragraph direction for
2928 string when that of the parent object is not yet determined.
2929 (reseat_1): Call bidi_init_it to resync the bidi
2930 iterator with IT's position. (Bug#7616)
2931 (find_row_edges): If ROW->start.pos gives position
2932 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2933 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2934 Reset the from_disp_prop_p flag.
2935 (SAVE_IT, RESTORE_IT): New macros.
2936 (pos_visible_p, face_before_or_after_it_pos)
2937 (back_to_previous_visible_line_start)
2938 (move_it_in_display_line_to, move_it_in_display_line)
2939 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2940 (try_scrolling, redisplay_window, display_line): Use them when
2941 saving a temporary copy of the iterator and restoring it back.
2942 (back_to_previous_visible_line_start, reseat_1)
2943 (init_iterator): Empty the bidi cache "stack".
2944 (move_it_in_display_line_to): If iterator ended up at
2945 EOL, but we never saw any buffer positions smaller than
2946 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2947 motion in bidi-reordered lines.
2948 (move_it_in_display_line_to): Record prev_method and prev_pos
2949 immediately before the call to set_iterator_to_next. Fixes cursor
2950 motion in bidi-reordered lines with stretch glyphs and strings
2951 displayed in margins. (Bug#8133) (Bug#8867)
2952 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2953 TO_CHARPOS.
640c8776
SM
2954 (pos_visible_p): Support positions in bidi-reordered lines.
2955 Save and restore bidi cache.
0bb23927
EZ
2956
2957 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2958 (bidi_paragraph_info): Delete unused struct.
2959 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2960 (bidi_cache_start): New variable.
2961 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2962 to zero.
2963 (bidi_cache_fetch_state, bidi_cache_search)
2964 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2965 (bidi_cache_find, bidi_peek_at_next_level)
2966 (bidi_level_of_next_char, bidi_find_other_level_edge)
2967 (bidi_move_to_visually_next): Compare cache index with
2968 bidi_cache_start rather than with zero.
2969 (bidi_fetch_char): Accept new argument STRING; all callers
2970 changed. Support iteration over a string. Support strings with
2971 display properties. Support unibyte strings. Fix the type of
2972 `len' according to what STRING_CHAR_AND_LENGTH expects.
2973 (bidi_paragraph_init, bidi_resolve_explicit_1)
2974 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2975 (bidi_level_of_next_char, bidi_move_to_visually_next):
2976 Support iteration over a string.
0bb23927
EZ
2977 (bidi_set_sor_type, bidi_resolve_explicit_1)
2978 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2979 can now be zero (for strings); special values 0 and -1 were
2980 changed to -1 and -2, respectively.
2981 (bidi_char_at_pos): New function.
2982 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2983 Call it instead of FETCH_MULTIBYTE_CHAR.
2984 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2985 initialized to valid values.
2986 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2987 values.
2988 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2989 the test for valid cached positions. Fix the logic for looking up
2990 the sentinel state in the cache. GCPRO the Lisp string we are
2991 iterating.
2992 (bidi_push_it, bidi_pop_it): New functions.
2993 (bidi_initialize): Initialize the bidi cache start stack pointer.
2994 (bidi_cache_ensure_space): New function, refactored from part of
2995 bidi_cache_iterator_state. Don't assume the required size is just
2996 one BIDI_CACHE_CHUNK away.
2997 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2998 (bidi_count_bytes, bidi_char_at_pos): New functions.
2999 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3000 always valid if bidi_cache_idx is valid.
3001 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3002 is valid if it's going to be used.
3003 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3004 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3005 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3006 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3007 (bidi_find_other_level_edge, bidi_cache_start_stack):
3008 All variables related to cache indices are now EMACS_INT.
c965adc5 3009
0bb23927
EZ
3010 * dispextern.h (struct bidi_string_data): New structure.
3011 (struct bidi_it): New member `string'. Make flag members be 1-bit
3012 fields, and put them last in the struct.
640c8776
SM
3013 (compute_display_string_pos, compute_display_string_end):
3014 Update prototypes.
0bb23927
EZ
3015 (bidi_push_it, bidi_pop_it): Add prototypes.
3016 (struct iterator_stack_entry): New members bidi_p,
3017 paragraph_embedding, and from_disp_prop_p.
3018 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3019 (bidi_shelve_cache, bidi_unshelve_cache):
3020 Declare prototypes.
0bb23927
EZ
3021
3022 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3023 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3024 and vector-like objects.
3025
3026 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3027 cache around display iteration.
3028
3029 * window.c (Fwindow_end, window_scroll_pixel_based)
3030 (displayed_window_lines, Frecenter): Save and restore the bidi
3031 cache around display iteration.
3032
3bbd2265
LMI
30332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3034
3035 * editfns.c (Fdelete_region): Clarify the use of the named
3036 parameters (bug#6788).
3037
adc47434
MR
30382011-07-14 Martin Rudalics <rudalics@gmx.at>
3039
3040 * indent.c (Fvertical_motion): Set and restore w->pointm when
3041 saving and restoring the window's buffer (Bug#9006).
3042
837c31f8
LMI
30432011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3044
3045 * editfns.c (Fstring_to_char): Clarify just what is returned
3046 (bug#6576). Text by Eli Zaretskii.
3047
ac389d0c
JB
30482011-07-13 Juanma Barranquero <lekktu@gmail.com>
3049
3050 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3051
0be0ce47
EZ
30522011-07-13 Eli Zaretskii <eliz@gnu.org>
3053
3054 * buffer.c (mmap_find): Fix a typo.
3055
cd18e7e3
JB
30562011-07-13 Johan Bockgård <bojohan@gnu.org>
3057
3058 Fix execution of x selection hooks.
3059 * xselect.c (Qx_lost_selection_functions)
3060 (Qx_sent_selection_functions): New vars.
3061 (syms_of_xselect): DEFSYM them.
3062 (x_handle_selection_request): Pass Qx_sent_selection_functions
3063 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3064 (x_handle_selection_clear,x_clear_frame_selections):
3065 Pass Qx_lost_selection_functions rather than
3066 Vx_lost_selection_functions to Frun_hook_with_args.
3067
47ea7f44
PE
30682011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3069
ac389d0c 3070 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3071 The old code sometimes used this field without initializing it.
3072
47ea7f44
PE
3073 * alloc.c (gc_sweep): Don't read past end of array.
3074 In theory, the old code could also have corrupted Emacs internals,
3075 though it'd be very unlikely.
3076
bc985c87
AS
30772011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3078
3079 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3080 argument. (Bug#4026)
bc985c87 3081
0cf34688
LMI
30822011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3083
b3dadd76
LMI
3084 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3085 key" (bug#4257).
3086
0cf34688
LMI
3087 * window.c (Fset_window_start): Doc fix (bug#4199).
3088 (Fset_window_hscroll): Ditto.
3089
270768cd
PE
30902011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3091
077e3dda 3092 Fix minor new problems caught by GCC 4.6.1.
270768cd 3093 * term.c (init_tty): Remove unused local.
490011a6 3094 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3095 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3096 not used otherwise.
270768cd 3097
b1f58454
CY
30982011-07-12 Chong Yidong <cyd@stupidchicken.com>
3099
3100 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3101
22b9578d
LMI
31022011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3103
6e70ab07
LMI
3104 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3105 are the mini-buffer and the echo area (bug#3320).
3106
22b9578d
LMI
3107 * term.c (init_tty): Remove support for supdup, c10 and perq
3108 terminals, which are no longer supported (bug#1482).
3109
8974cc9f
JB
31102011-07-10 Johan Bockgård <bojohan@gnu.org>
3111
3112 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3113
a560d974
JD
31142011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3115
3116 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3117 for non-popups (Bug#3642).
3118
1dae0f0a
AS
31192011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3120
268c2c36 3121 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3122 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3123 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3124 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3125 * data.c (fmod): Likewise.
3126 * dispnew.c (swap_glyphs_in_rows): Likewise.
3127 * emacs.c (memory_warning_signal): Likewise.
3128 * floatfns.c (float_error): Likewise.
3129 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3130 (otf_open, font_otf_capability, generate_otf_features)
3131 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3132 Likewise.
3133 * image.c (pbm_read_file): Likewise.
3134 * indent.c (string_display_width): Likewise.
3135 * intervals.c (check_for_interval, search_for_interval)
3136 (inc_interval_count, count_intervals, root_interval)
3137 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3138 * lread.c (defalias): Likewise.
268c2c36 3139 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3140 * regex.c (set_image_of_range_1, set_image_of_range)
3141 (regex_grow_registers): Likewise.
3142 * sysdep.c (strerror): Likewise.
3143 * termcap.c (valid_filename_p, tprint, main): Likewise.
3144 * tparam.c (main): Likewise.
3145 * unexhp9k800.c (run_time_remap, save_data_space)
3146 (update_file_ptrs, read_header, write_header, calculate_checksum)
3147 (copy_file, copy_rest, display_header): Likewise.
3148 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3149 Likewise.
3150 * xdisp.c (check_it): Likewise.
3151 * xfaces.c (register_color, unregister_color, unregister_colors):
3152 Likewise.
3153 * xfns.c (print_fontset_result): Likewise.
3154 * xrdb.c (member, fatal, main): Likewise.
3155
99033785
PE
31562011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3157
3158 Fix minor problems found by static checking (Bug#9031).
3159 * chartab.c (char_table_set_range, map_sub_char_table):
3160 Remove unused locals.
3161 (uniprop_table): Now static.
3162 * composite.c (_work_char): Remove unused static var.
3163
9cb2ac56
JB
31642011-07-09 Juanma Barranquero <lekktu@gmail.com>
3165
3166 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3167
f25661f0
JD
31682011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3169
3170 * gtkutil.c (qttip_cb): Remove code without function.
3171
8278c4fe
EZ
31722011-07-09 Eli Zaretskii <eliz@gnu.org>
3173
3174 * w32.c (pthread_sigmask): New stub.
3175
1692ae2d 31762011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3177
8a6ebd58 3178 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3179 sigprocmask is portable only for single-threaded applications, and
3180 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3181 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3182 (LIBES): Use it.
3183 * callproc.c (Fcall_process):
3184 * process.c (create_process):
3185 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3186 Use pthread_sigmask, not sigprocmask.
123403e4 3187
1b854618
JD
31882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3189
3190 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3191 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3192 wrong (Bug#8591).
3193
3fe4b549
JD
31942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3195
0ce7e563
JD
3196 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3197 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3198 (xg_hide_tooltip): Fix comment.
3199
3fe4b549
JD
3200 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3201 in registerServicesMenuSendTypes.
3202 (validRequestorForSendType): Don't check ns_return_types.
3203
3204 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3205 ns_return_type.
3206
5df75e47
JR
32072011-07-08 Jason Rumney <jasonr@gnu.org>
3208
22610910
JR
3209 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3210 SH_SHOW for hidden windows (Bug#5482).
3211
5df75e47
JR
3212 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3213 frame struct members of non-existent frames (Bug#6284).
3214
699c10bd
JD
32152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3216
4393663b
JD
3217 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3218 variable firstTime not needed on OSX >= 10.6.
3219 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3220 >= 10.5. Use setKnobProportion, setDoubleValue.
3221
3222 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3223 (MAC_OS_X_VERSION_10_5): Define if not defined.
3224 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3225 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3226 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3227
3228 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3229 cString and lossyCString on OSX >= 10.4
3230
58179cce 3231 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3232 sizeToFit on OSX >= 10.2.
3233
3234 * nsimage.m (allocInitFromFile): Don't use deprecated method
3235 bestRepresentationForDevice on OSX >= 10.6.
3236
3237 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3238 to avoid warning.
3239
3240 * emacs.c: Declare unexec_init_emacs_zone.
3241
a63e0781
JD
3242 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3243
699c10bd
JD
3244 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3245
3246 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3247 on svcsMenu (Bug#8842).
3248
3249 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3250 ns_return_types.
3251 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3252
3253 * nsterm.m (QUTF8_STRING): Declare.
3254 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3255 (validRequestorForSendType): Return type is (id).
3256 Change indexOfObjectIdenticalTo to indexOfObject.
3257 Check if we have local selection before returning self (Bug#8842).
3258 (writeSelectionToPasteboard): Put local selection into paste board
3259 if we have a local selection (Bug#8842).
3260 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3261
3262 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3263 (ns_get_local_selection): Declare.
3264
54e10184
LMI
32652011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3266
9888ff71
LMI
3267 * keymap.c (describe_map_tree): Don't insert a double newline at
3268 the end of the buffer (bug#1169) and return whether we inserted
3269 something.
3270
54e10184
LMI
3271 * callint.c (Fcall_interactively): Change "reading args" to
3272 "providing args" to try to clarify what it does (bug#1010).
3273
15fa4783
KH
32742011-07-07 Kenichi Handa <handa@m17n.org>
3275
3276 * composite.c (composition_compute_stop_pos): Ignore a static
3277 composition starting before CHARPOS (Bug#8915).
3278
3279 * xdisp.c (handle_composition_prop): Likewise.
3280
a8815b00
EZ
32812011-07-07 Eli Zaretskii <eliz@gnu.org>
3282
3283 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3284 (Bug#9015)
3285
ef7b981d 32862011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3287
3288 * character.h (unicode_category_t): New enum type.
3289
3290 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3291 (Qchar_code_property_table): New variable.
3292 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3293 (UNIPROP_COMPRESSED_FORM_P): New macros.
3294 (char_table_ascii): Uncompress the compressed values.
3295 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3296 Uncompress the compressed values.
ac389d0c 3297 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3298 (char_table_ref_and_range): Uncompress the compressed values.
3299 (sub_char_table_set): New arg is_uniprop. Callers changed.
3300 Uncompress the compressed values.
3301 (sub_char_table_set_range): Args changed. Callers changed.
3302 (char_table_set_range): Adjuted for the above change.
3303 (map_sub_char_table): Delete args default_val and parent. Add arg
3304 top. Give decoded values to a Lisp function.
640c8776 3305 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3306 values to a Lisp function. Gcpro more variables.
3307 (uniprop_table_uncompress)
3308 (uniprop_decode_value_run_length): New functions.
3309 (uniprop_decoder, uniprop_decoder_count): New variables.
3310 (uniprop_get_decoder, uniprop_encode_value_character)
3311 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3312 New functions.
3313 (uniprop_encoder, uniprop_encoder_count): New variables.
3314 (uniprop_get_encoder, uniprop_table)
3315 (Funicode_property_table_internal, Fget_unicode_property_internal)
3316 (Fput_unicode_property_internal): New functions.
3317 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3318 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3319 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3320 char-code-property-alist.
3321
640c8776 3322 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3323 Vunicode_category_table.
3324
640c8776 3325 * font.c (font_range): Adjust for the change of
c805dec0
KH
3326 Vunicode_category_table.
3327
76b397fb
DN
33282011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3329
3330 * m/iris4d.h: Remove file, move contents ...
3331 * s/irix6-5.h: ... here.
3332
22b4128e
PE
33332011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3334
3335 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3336 * alloc.c (mark_buffer):
3337 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3338 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3339 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3340 This isn't true in general, and it's particularly not true
3341 if Emacs is configured with --with-wide-int.
3342 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3343 New macros, used in the buffer.c change.
3344
869795d6
JD
33452011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3346
3347 * xsettings.c: Use both GConf and GSettings if both are available.
3348 (store_config_changed_event): Add comment.
3349 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3350 (store_tool_bar_style_changed): New functions.
5e617bc2 3351 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3352 (struct xsettings): Move font inside HAVE_XFT.
3353 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3354 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3355 Move inside HAVE_XFT.
640c8776 3356 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3357 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3358 also.
3359 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3360 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3361 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3362 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3363 (parse_settings): Move check for font inside HAVE_XFT.
3364 (read_settings, apply_xft_settings): Add comment.
3365 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3366 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3367 call store_font_name_changed.
3368 (xft_settings_event): Add comment.
3369 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3370 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3371 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3372 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3373 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3374 (xsettings_get_system_font, xsettings_get_system_normal_font):
3375 Add comment.
869795d6 3376
d8ed26bd
PE
33772011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 Random fixes. E.g., (random) never returned negative values.
3380 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3381 subseconds part to the entropy, as that's a bit more random.
3382 Prefer signed to unsigned, since the signedness doesn't matter and
3383 in general we prefer signed. When given a limit, use a
3384 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3385 latter isn't right if USE_2_TAGS_FOR_INTS.
3386 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3387 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3388
cabf1cac
SM
33892011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3390
3391 * textprop.c (text_property_stickiness):
3392 Obey Vtext_property_default_nonsticky.
3393 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3394 * w32fns.c (syms_of_w32fns):
3395 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3396
6e9b2be9
PE
33972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3398
3399 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3400 This is more efficient than Ffile_directory_p and avoids a minor race.
3401
90186c68
LMI
34022011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3403
7c301272
LMI
3404 * buffer.c (Foverlay_put): Say what the return value is
3405 (bug#7835).
3406
c4f2d8d4
LMI
3407 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3408 is a directory before asking whether to use the file name
3409 (bug#7564).
ad637907
LMI
3410 (barf_or_query_if_file_exists): Make the "File is a directory"
3411 error be more correct.
c4f2d8d4 3412
90186c68
LMI
3413 * fns.c (Frequire): Remove the mention of the .gz files, since
3414 that's installation-specific, but keep the mention of
3415 `get-load-suffixes'.
3416
da64016e
PE
34172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3420 Report string overflow if the output is too long.
3421
7d47b580
JB
34222011-07-04 Juanma Barranquero <lekktu@gmail.com>
3423
a555cb87
JB
3424 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3425 (syms_of_gnutls): Remove duplicate DEFSYM for
3426 Qgnutls_bootprop_verify_hostname_error, an error for
3427 Qgnutls_bootprop_verify_error (which is no longer used).
3428
7d47b580
JB
3429 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3430 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3431 Also (re)move comments that are misplaced or no longer relevant.
3432
1e49bfab
LMI
34332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3434
3435 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3436
1485f4c0
CY
34372011-07-03 Chong Yidong <cyd@stupidchicken.com>
3438
3439 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3440 and background color parameters if they have been changed.
3441
a9ab721e
LMI
34422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3443
3444 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3445
cf7cff57
PE
34462011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3447
2e13213d
PE
3448 * xsettings.c (SYSTEM_FONT): Define only when used.
3449 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3450
cf7cff57
PE
3451 * keymap.c (access_keymap_1): Now static.
3452
7a8e04f7
CY
34532011-07-02 Chong Yidong <cyd@stupidchicken.com>
3454
3455 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3456 leave any prefix arg for the up event (Bug#1586).
3457
61352f62
LMI
34582011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3459
69bb1ef7
LMI
3460 * lread.c (syms_of_lread): Mention single symbols defined by
3461 `defvar' or `defconst' (bug#7154).
3462
61352f62 3463 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3464 (Frequire): Mention get-load-suffixes.
61352f62 3465
28545e04
MR
34662011-07-02 Martin Rudalics <rudalics@gmx.at>
3467
3468 * window.h (window): Remove clone_number slot.
3469 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3470 Remove.
3471 (make_parent_window, make_window, saved_window)
3472 (Fset_window_configuration, save_window_save): Don't deal with
3473 clone numbers.
3474 * buffer.c (Qclone_number): Remove declaration.
3475 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3476
3349e122
SM
34772011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3478
3479 Add multiple inheritance to keymaps.
3480 * keymap.c (Fmake_composed_keymap): New function.
3481 (Fset_keymap_parent): Simplify.
3482 (fix_submap_inheritance): Remove.
3483 (access_keymap_1): New function extracted from access_keymap to handle
3484 embedded parents and handle lists of maps.
3485 (access_keymap): Use it.
3486 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3487 (Fcopy_keymap): Handle embedded parents.
3488 (Fcommand_remapping, define_as_prefix): Simplify.
3489 (Fkey_binding): Simplify.
3490 (syms_of_keymap): Move minibuffer-local-completion-map,
3491 minibuffer-local-filename-completion-map,
3492 minibuffer-local-must-match-map, and
3493 minibuffer-local-filename-must-match-map to Elisp.
3494 (syms_of_keymap): Defsubr make-composed-keymap.
3495 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3496 (parse_menu_item): Trivial simplification.
3497
3279eb87
GM
34982011-07-01 Glenn Morris <rgm@gnu.org>
3499
3500 * Makefile.in (SETTINGS_LIBS): Fix typo.
3501
4550efdf
KI
35022011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3503
3504 * coding.c (Fencode_coding_string): Record the last coding system
3505 used, as the function doc string says (bug#8738).
3506
0949d2b6
JD
35072011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3508
3509 * xsettings.c (store_monospaced_changed): Take new font as arg and
3510 check for change against current_mono_font.
3511 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3512 (emacs_settings_constructor, emacs_settings_get_property)
3513 (emacs_settings_set_property, emacs_settings_class_init)
3514 (emacs_settings_init, gsettings_obj): Remove.
3515 (something_changedCB): New function for HAVE_GSETTINGS.
3516 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3517 with value as argument.
3518 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3519 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3520 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3521 "changed".
3522
3523 * xgselect.c: Add defined (HAVE_GSETTINGS).
3524 (xgselect_initialize): Ditto.
3525
3526 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3527 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3528 xg_select.
3529
bbc6b304
PE
35302011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3531
3532 * eval.c (struct backtrace): Simplify and port the data structure.
3533 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3534 signed bit field, as this assumption is not portable and it makes
3535 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3536 "char debug_on_exit : 1" as this is not portable either; instead,
3537 use the portable "unsigned int debug_on_exit : 1". Remove unused
3538 member evalargs. Remove obsolete comments about cc bombing out.
3539
9851bfc5
JD
35402011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3541
51bb811f 3542 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3543 Let HAVE_GSETTINGS override HAVE_GCONF.
3544 (store_monospaced_changed): New function.
3545 (EMACS_SETTINGS): A new type derived from GObject to handle
3546 GSettings notifications.
3547 (emacs_settings_constructor, emacs_settings_get_property)
3548 (emacs_settings_set_property, emacs_settings_class_init):
3549 New functions.
3550 (gsettings_client, gsettings_obj): New variables.
3551 (GSETTINGS_SCHEMA): New define.
3552 (something_changedCB): Call store_monospaced_changed.
3553 (init_gsettings): New function.
3554 (xsettings_initialize): Call init_gsettings.
3555 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3556 to NULL.
3557
640c8776 3558 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3559 GCONF_CFLAGS/LIBS.
3560
5386012d
MR
35612011-06-29 Martin Rudalics <rudalics@gmx.at>
3562
3563 * window.c (resize_root_window, grow_mini_window)
3564 (shrink_mini_window): Rename Qresize_root_window to
3565 Qwindow_resize_root_window and Qresize_root_window_vertically to
3566 Qwindow_resize_root_window_vertically.
3567
f13e0b08
PE
35682011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3571
94515237
JB
35722011-06-27 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * makefile.w32-in: Redesign dependencies so they reflect more
3575 clearly which files are directly included by each source file,
3576 and not through other includes.
3577
e43b6e43
MR
35782011-06-27 Martin Rudalics <rudalics@gmx.at>
3579
3580 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3581 (sort_overlays, overlay_strings): When an overlay's clone number
3582 matches the window's clone number process the overlay even if
3583 the overlay's window property doesn't match the current window.
3584
d68443dc
MR
3585 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3586 (Fwindow_hchild): Rename to Fwindow_left_child.
3587 (Fwindow_next): Rename to Fwindow_next_sibling.
3588 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3589 (resize_window_check): Rename to window_resize_check.
3590 (resize_window_apply): Rename to window_resize_apply.
3591 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3592 (Fdelete_other_windows_internal, resize_frame_windows)
3593 (Fsplit_window_internal, Fdelete_window_internal)
3594 (grow_mini_window, shrink_mini_window)
3595 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3596
c7e73be5
JD
35972011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3598
3599 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3600 (emacs_fixed_set_min_size): Remove.
3601 (emacs_fixed_new): Take frame as argument.
3602
3603 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3604 (_EmacsFixedPrivate): Remove minwidth/height.
3605 Add struct frame *f.
3606 (emacs_fixed_init): Initialize priv->f.
3607 (get_parent_class, emacs_fixed_set_min_size): Remove.
3608 (emacs_fixed_new): Set priv->f to argument.
3609 (emacs_fixed_get_preferred_width)
3610 (emacs_fixed_get_preferred_height): Use min_width/height from
3611 frames size_hint to set minimum and natural (Bug#8919).
3612 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3613 and use min_width/height from frames size_hint to set
3614 min_width/height (Bug#8919).
3615
3616 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3617 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3618 Fix indentation.
c7e73be5 3619
cf99dcf8
EZ
36202011-06-26 Eli Zaretskii <eliz@gnu.org>
3621
3622 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3623 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3624 called at ZV.
3625
029529ac
CY
36262011-06-26 Chong Yidong <cyd@stupidchicken.com>
3627
3628 * process.c (wait_reading_process_output): Bypass select if
3629 waiting for a cell while ignoring keyboard input, and input is
3630 pending. Suggested by Jan Djärv (Bug#8869).
3631
7a7ef429
PE
36322011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3633
3634 Use gnulib's dup2 module instead of rolling our own.
3635 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3636
11fdef7d 36372011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3638
3639 * dispnew.c (scrolling_window): Before scrolling, turn off a
3640 mouse-highlight in the window being scrolled.
3641
cd3520a4
JB
36422011-06-24 Juanma Barranquero <lekktu@gmail.com>
3643
3644 Move DEFSYM to lisp.h and use everywhere.
3645
3646 * character.h (DEFSYM): Move declaration...
3647 * lisp.h (DEFSYM): ...here.
3648
3649 * gnutls.c:
3650 * minibuf.c:
3651 * w32menu.c:
3652 * w32proc.c:
3653 * w32select.c: Don't include character.h.
3654
3655 * alloc.c (syms_of_alloc):
3656 * buffer.c (syms_of_buffer):
3657 * bytecode.c (syms_of_bytecode):
3658 * callint.c (syms_of_callint):
3659 * casefiddle.c (syms_of_casefiddle):
3660 * casetab.c (init_casetab_once):
3661 * category.c (init_category_once, syms_of_category):
3662 * ccl.c (syms_of_ccl):
3663 * cmds.c (syms_of_cmds):
3664 * composite.c (syms_of_composite):
3665 * dbusbind.c (syms_of_dbusbind):
3666 * dired.c (syms_of_dired):
3667 * dispnew.c (syms_of_display):
3668 * doc.c (syms_of_doc):
3669 * editfns.c (syms_of_editfns):
3670 * emacs.c (syms_of_emacs):
3671 * eval.c (syms_of_eval):
3672 * fileio.c (syms_of_fileio):
3673 * fns.c (syms_of_fns):
3674 * frame.c (syms_of_frame):
3675 * fringe.c (syms_of_fringe):
3676 * insdel.c (syms_of_insdel):
3677 * keymap.c (syms_of_keymap):
3678 * lread.c (init_obarray, syms_of_lread):
3679 * macros.c (syms_of_macros):
3680 * msdos.c (syms_of_msdos):
3681 * print.c (syms_of_print):
3682 * process.c (syms_of_process):
3683 * search.c (syms_of_search):
3684 * sound.c (syms_of_sound):
3685 * syntax.c (init_syntax_once, syms_of_syntax):
3686 * terminal.c (syms_of_terminal):
3687 * textprop.c (syms_of_textprop):
3688 * undo.c (syms_of_undo):
3689 * w32.c (globals_of_w32):
3690 * window.c (syms_of_window):
3691 * xdisp.c (syms_of_xdisp):
3692 * xfaces.c (syms_of_xfaces):
3693 * xfns.c (syms_of_xfns):
3694 * xmenu.c (syms_of_xmenu):
3695 * xsettings.c (syms_of_xsettings):
3696 * xterm.c (syms_of_xterm): Use DEFSYM.
3697
4228cf16
TZ
36982011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3699
cd3520a4 3700 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3701
7fcccf1e
PE
37022011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3703
7efb4e0e
PE
3704 Integer and buffer overflow fixes (Bug#8873).
3705
ff5844ad
PE
3706 * print.c (printchar, strout): Check for string overflow.
3707 (PRINTPREPARE, printchar, strout):
3708 Don't set size unless allocation succeeds.
3709
90532f02
PE
3710 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3711 for sizes. Check for string overflow more accurately.
3712 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3713
6d84508d
PE
3714 * macros.c: Integer and buffer overflow fixes.
3715 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3716 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3717 Use ptrdiff_t, not int, for sizes.
3718 Don't increment bufsize until after realloc succeeds.
3719 Check for size-calculation overflow.
3720 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3721
437b2cb4
PE
3722 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3723
8b9ac8b4
PE
3724 * lread.c: Integer overflow fixes.
3725 (read_integer): Radix is now EMACS_INT, not int,
3726 to improve quality of diagnostics for out-of-range radices.
3727 Calculate buffer size correctly for out-of-range radices.
3728 (read1): Check for integer overflow in radices, and in
3729 read-circle numbers.
82cb60d3
PE
3730 (read_escape): Avoid int overflow.
3731 (Fload, openp, read_buffer_size, read1)
3732 (substitute_object_recurse, read_vector, read_list, map_obarray):
3733 Use ptrdiff_t, not int, for sizes.
3734 (read1): Use EMACS_INT, not int, for sizes.
20270765 3735 Check for size overflow.
8b9ac8b4 3736
7fcccf1e
PE
3737 * image.c (cache_image): Check for size arithmetic overflow.
3738
bfbbd7e7
PE
3739 * lread.c: Integer overflow issues.
3740 (saved_doc_string_size, saved_doc_string_length)
3741 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3742 Now ptrdiff_t, not int.
3743 (read1): Don't assume doc string length fits in int. Check for
3744 out-of-range doc string lengths.
3745 (read_list): Don't assume file position fits in int.
39019e54 3746 (read_escape): Check for hex character overflow.
bfbbd7e7 3747
4e323265
LL
37482011-06-22 Leo Liu <sdl.web@gmail.com>
3749
3750 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3751 Move to minibuffer.el.
3752
85fece3e
PE
37532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3754
20b84ce9 3755 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3756 The following patches are for when GLYPH_DEBUG && !XASSERT.
3757 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3758 * dispnew.c (flush_stdout):
3759 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3760 Mark as externally visible.
3761 * dispnew.c (check_window_matrix_pointers): Now static.
3762 * dispnew.c (window_to_frame_vpos):
3763 * xfns.c (unwind_create_frame):
3764 * xterm.c (x_check_font): Remove unused local.
3765 * scroll.c (CHECK_BOUNDS):
3766 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3767 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3768 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3769 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3770 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3771 Now static.
3772 (debug_method_add): Use va_list and vsprintf rather than relying
3773 on undefined behavior with wrong number of arguments.
3774 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3775 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3776 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3777 since we're not interested in debugging glyphs with old libraries.
3778 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3779 GCC 4.6.0's static checking.
3780
0766b489
PE
37812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3782
31fd4b32
PE
3783 Integer overflow and signedness fixes (Bug#8873).
3784 A few related buffer overrun fixes, too.
3785
b79e8648
PE
3786 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3787
0766b489
PE
3788 * dispextern.h (struct face.stipple):
3789 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3790 (x_bitmap_mask, x_allocate_bitmap_record)
3791 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3792 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3793 (x_create_bitmap_from_xpm_data):
3794 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3795 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3796 (.bitmaps_last):
3797 * xfaces.c (load_pixmap):
3798 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3799 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3800 (.bitmaps_last, struct x_output.icon_bitmap):
3801 Use ptrdiff_t, not int, for bitmap indexes.
3802 (x_allocate_bitmap_record): Check for size overflow.
3803 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3804
b081724f
PE
3805 Use ptrdiff_t, not int, for overlay counts.
3806 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3807 * editfns.c (overlays_around, get_pos_property):
3808 * textprop.c (get_char_property_and_overlay):
3809 * xdisp.c (next_overlay_change, note_mouse_highlight):
3810 * xfaces.c (face_at_buffer_position):
21514da7
PE
3811 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3812 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3813 (Fnext_overlay_change, Fprevious_overlay_change)
3814 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3815 Use ptrdiff_t, not int, for sizes.
21514da7 3816 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3817
3de73e5e
PE
3818 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3819
2606c57b
PE
3820 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3821 (x_session_initialize): Do not assume string length fits in int.
3822
aaafe47a
PE
3823 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3824 This is unlikely, but can occur if DPI is outlandish.
3825
2674ddc8 3826 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3827 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3828
28154962
PE
3829 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3830 * xrdb.c (magic_file_p, search_magic_path):
3831 Omit last arg SUFFIX; it was always 0. All callers changed.
3832 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3833
7de51af5
PE
3834 * xfont.c (xfont_match): Avoid need for strlen.
3835
25ed6cc3
PE
3836 * xfns.c: Don't assume strlen fits in int.
3837 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3838
4eab31dd
PE
3839 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3840 not unsigned long, as we prefer signed integers. All callers changed.
3841 Detect integer overflow in repeat count.
3842 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3843 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3844
171e2a58
PE
3845 * termcap.c: Don't assume sizes fit in int and never overflow.
3846 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3847 (gobble_line): Check for size-calculation overflow.
3848
ad39faca 3849 * minibuf.c (Fread_buffer):
6e5bb2dc 3850 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3851 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3852 Don't assume string length fits in int.
3853
52c61c22 3854 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3855 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3856
b5b8c9e5
PE
3857 * font.c: Don't assume string length fits in int.
3858 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3859 Use ptrdiff_t, not int.
ccd6111c
PE
3860 (font_intern_prop): Don't assume string length fits in int.
3861 Don't assume integer property fits in fixnum.
3862 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3863
882f0d81 3864 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3865 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3866 Reformulate so as not to need the command string.
3867 Invoke gzip -cd rather than gunzip, as it's more portable.
3868 (lock_info_type, lock_file_1, lock_file):
3869 Don't assume pid_t and time_t fit in unsigned long.
3870 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3871 (current_lock_owner): Prefer signed type for sizes.
3872 Use memcpy, not strncpy, where memcpy is what is really wanted.
3873 Don't assume (via atoi) that time_t and pid_t fit in int.
3874 Check for time_t and/or pid_t out of range, e.g., via a network share.
3875 Don't alloca where an auto var works fine.
3876
93f4cf88
PE
3877 * fileio.c: Fix some integer overflow issues.
3878 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3879 Don't assume string length fits in int.
3880 (directory_file_name): Don't assume string length fits in long.
3881 (make_temp_name): Don't assume pid fits in int, or that its print
3882 length is less than 20.
3883
f3e92b69
PE
3884 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3885
1bfdaf10
PE
3886 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3887
35016e9a
PE
3888 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3889
3d1e65a1
PE
3890 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3891 We prefer signed integers, even for size calculations.
3892
0b963a93
PE
3893 * emacs.c: Don't assume string length fits in 'int'.
3894 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3895 (main): Don't invoke strlen when not needed.
3896
573f4b54
PE
3897 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3898 (XD_DEBUG_MESSAGE): Don't waste a byte.
3899
989f33ba
PE
3900 * callproc.c (getenv_internal_1, getenv_internal)
3901 (Fgetenv_internal):
965d34eb
PE
3902 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3903
e4d29b33
PE
3904 * lread.c (invalid_syntax): Omit length argument.
3905 All uses changed. This doesn't fix a bug, but it simplifies the
3906 code away from its former Hollerith-constant appearance, and it's
3907 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3908 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3909
eb49b136
PE
3910 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3911 This didn't break anything, but it didn't help either.
3912 It's confusing to put a bogus integer in a place where the actual
3913 value does not matter.
9f62aeb1 3914 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3915 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3916
15375a22
PE
3917 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3918 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3919 implementation.
b61cc01c
PE
3920 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3921 We prefer signed types, and the value cannot exceed the EMACS_INT
3922 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3923 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3924 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3925 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3926
53b2623d
PE
3927 * indent.c (sane_tab_width): New function.
3928 (current_column, scan_for_column, Findent_to, position_indentation)
3929 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3930 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3931
51cab52b 3932 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3933
f2ed8a70
PE
3934 * lisp.h (lint_assume): New macro.
3935 * composite.c (composition_gstring_put_cache):
3936 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3937
abe80cc6
PE
3938 * editfns.c, insdel.c:
3939 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3940
b02c740e
PE
3941 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3942
ebc96716
PE
3943 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3944
b4e50fa0 3945 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3946 Use much-faster test for byte-length change.
311d5d7c 3947 Don't assume string byte-length fits in 'int'.
a4cf38e4 3948 Check that character arg fits in 'int'.
85461888 3949 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3950
c0c1ee9f
PE
3951 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3952
a498d7f4
PE
3953 * fns.c (concat): Catch string overflow earlier.
3954 Do not rely on integer wraparound.
3955
51cab52b
PE
3956 * dispextern.h (struct it.overlay_strings_charpos)
3957 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3958 * xdisp.c (forward_to_next_line_start)
3959 (back_to_previous_visible_line_start)
3960 (reseat_at_next_visible_line_start, next_element_from_buffer):
3961 Don't arbitrarily truncate the value of 'selective' to int.
3962
76031fad
PE
3963 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3964
5eb55db9
PE
3965 * composite.c: Don't truncate sizes to 'int'.
3966 (composition_gstring_p, composition_reseat_it)
3967 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3968 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3969 not EMACS_UINT, for indexes.
5eb55db9 3970
0703a717
PE
3971 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3972
d6202519
PE
3973 * buffer.c: Include <verify.h>.
3974 (struct sortvec.priority, struct sortstr.priority):
8961a454 3975 Now EMACS_INT, not int.
c20998a7 3976 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3977 (struct sortstr.size, record_overlay_string)
3978 (struct sortstrlist.size, struct sortlist.used):
3979 Don't truncate size to int.
3980 (record_overlay_string): Check for size-calculation overflow.
d6202519 3981 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3982
d5a19415
JM
39832011-06-22 Jim Meyering <meyering@redhat.com>
3984
029529ac 3985 Don't leak an XBM-image-sized buffer
d5a19415
JM
3986 * image.c (xbm_load): Free the image buffer after using it.
3987
a9041e6c
PE
39882011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3989
3990 Port to Sun C.
3991 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3992 that Sun C diagnosed.
3993 * fns.c (secure_hash): Fix pointer signedness issue.
3994 * intervals.c (static_offset_intervals): New function.
3995 (offset_intervals): Use it.
3996
7f3f739f
LL
39972011-06-21 Leo Liu <sdl.web@gmail.com>
3998
3999 * deps.mk (fns.o):
4000 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4001 sha512.h.
4002
4003 * fns.c (secure_hash): Rename from crypto_hash_function and change
4004 the first arg to accept symbols.
5b66d427 4005 (Fsecure_hash): New primitive.
7f3f739f
LL
4006 (syms_of_fns): New symbols.
4007
76147d94
DD
40082011-06-20 Deniz Dogan <deniz@dogan.se>
4009
4010 * process.c (Fset_process_buffer): Clarify return value in
4011 docstring.
4012
7d7d0045
CY
40132011-06-18 Chong Yidong <cyd@stupidchicken.com>
4014
4015 * dispnew.c (add_window_display_history): Use BVAR.
4016
4017 * xdisp.c (debug_method_add): Use BVAR.
4018 (check_window_end, dump_glyph_matrix, dump_glyph)
4019 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4020
4021 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4022 Likewise.
4023
4024 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4025 check till after the cache is created in init_frame_faces.
4026
ff2bc410
SM
40272011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4028
4029 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4030
28177add
PE
40312011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4032
dd3482fe
PE
4033 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4034 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4035 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4036
393d71f3 4037 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4038 * fileio.c (Finsert_file_contents):
4039 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4040 Remove the old (too-loose) buffer overflow checks.
4041 They weren't needed, since make_gap checks for buffer overflow.
4042 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4043 The old code merely checked for Emacs fixnum overflow, and relied
4044 on undefined (wraparound) behavior. The new code avoids undefined
4045 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4046
2e6813b0 4047 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4048 Tune. Don't use wider integers than needed. Don't use alloca.
4049 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4050
599a9e4f
PE
4051 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4052
99561444
PE
4053 * insdel.c, lisp.h (buffer_overflow): New function.
4054 (insert_from_buffer_1, replace_range, replace_range_2):
4055 * insdel.c (make_gap_larger):
4056 * editfns.c (Finsert_char):
4057 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4058
28177add
PE
4059 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4060
e69dafad
PE
40612011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4062
a7af7fde 4063 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4064
b1c46f02
PE
4065 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4066 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4067
e69dafad
PE
4068 * fileio.c: Don't assume EMACS_INT fits in off_t.
4069 (emacs_lseek): New static function.
4070 (Finsert_file_contents, Fwrite_region): Use it.
4071 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4072
566684ea
PE
4073 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4074
e6966cd6
PE
4075 * fns.c: Don't overflow int when computing a list length.
4076 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4077 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4078 truncation on 64-bit hosts. Check for QUIT every
4079 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4080 faster and is responsive enough.
4081 (Flength): Report an error instead of overflowing an integer.
4082 (Fsafe_length): Return a float if the value is not representable
4083 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4084 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4085 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4086
dd0b0efb
PE
4087 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4088 (header_size, word_size): New constants.
4089 (allocate_vectorlike): Don't check size overflow here.
4090 (allocate_vector): Check it here instead, since this is the only
4091 caller of allocate_vectorlike that could cause overflow.
4092 Check that the new vector's length is representable as a fixnum.
4093
86fe5cfe
PE
4094 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4095 The previous code was bogus. For example, next_almost_prime (32)
4096 returned 39, which is undesirable as it is a multiple of 3; and
4097 next_almost_prime (24) returned 25, which is a multiple of 5 so
4098 why was the code bothering to check for multiples of 7?
4099
80e88859
PE
4100 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4101
4a2f0ad6
PE
4102 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4103
f66c7cf8
PE
4104 Variadic C functions now count arguments with ptrdiff_t.
4105 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4106 Back then I didn't know that the Emacs coding style prefers signed int.
4107 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4108 were being counted with int, which may truncate counts on 64-bit
4109 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4110 * lisp.h (struct Lisp_Subr.function.aMANY)
4111 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4112 Arg counts are now ptrdiff_t, not size_t.
4113 All variadic functions and their callers changed accordingly.
4114 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4115 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4116 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4117 * callint.c (Fcall_interactively): Check arg count for overflow,
4118 to avoid potential buffer overrun. Use signed char, not 'int',
4119 for 'varies' array, so that we needn't bother to check its size
4120 calculation for overflow.
4121 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4122 * eval.c (apply_lambda):
4123 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4124 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4125 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4126
a1759b76
PE
4127 * callint.c (Fcall_interactively): Don't use index var as event count.
4128
d96be9fc
PE
4129 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4130 * mem-limits.h (SIZE): Remove; no longer used.
4131
a690a978 4132 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4133
578c21e6
PE
4134 Remove unnecessary casts.
4135 * xterm.c (x_term_init):
4136 * xfns.c (x_set_border_pixel):
4137 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4138 These aren't needed now that we assume ANSI C.
4139
96f53c6c
PE
4140 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4141 It's more likely to cause problems (due to unsigned overflow)
4142 than to cure them.
4143
83c77d31
PE
4144 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4145
ee2079f1
PE
4146 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4147
6da65536
PE
4148 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4149
7147c4a4
PE
4150 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4151
193e32d9
PE
4152 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4153
e5533da6
PE
4154 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4155
9910e595
PE
4156 GLYPH_CODE_FACE returns EMACS_INT, not int.
4157 * dispextern.h (merge_faces):
4158 * xfaces.c (merge_faces):
01103c44
PE
4159 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4160 Don't assume EMACS_INT fits in int.
9910e595 4161
2638320e
PE
4162 * character.h (CHAR_VALID_P): Remove unused parameter.
4163 * fontset.c, lisp.h, xdisp.c: All uses changed.
4164
045eb8d9
PE
4165 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4166
c1f134b5
PE
4167 * fns.c (concat): Minor tuning based on overflow analysis.
4168 This doesn't fix any bugs. Use int to hold character, instead
4169 of constantly refetching from Emacs object. Use XFASTINT, not
4170 XINT, for value known to be a character. Don't bother comparing
4171 a single byte to 0400, as it's always less.
4172
395fcb93 4173 * floatfns.c (Fexpt):
327eeec8
PE
4174 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4175
abbd3d23
PE
4176 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4177 for characters.
4178
684a03ef
PE
4179 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4180
0fed43f3
PE
4181 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4182 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4183 incorrectly succeed when S was a string, because 4294967386 was
4184 truncated before it was used.
4185
8fd02eb7
PE
4186 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4187 Otherwise, an out-of-range integer could cause undefined behavior
4188 on a 64-bit host.
4189
f8c86b69
PE
4190 * composite.c: Use int, not EMACS_INT, for characters.
4191 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4192 EMACS_INT, for values that are known to be in character range.
4193 This doesn't fix any bugs but is the usual style inside Emacs and
4194 may generate better code on 32-bit machines.
4195
34206dd2
PE
4196 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4197 This is for reasons similar to the recent CHAR_STRING fix.
4198 * charset.c (Fencode_char): Check that character arg is actually
4199 a character. Pass an int to ENCODE_CHAR.
4200 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4201 wider than 'int', as a compile-time check to prevent future regressions
4202 in this area.
4203
c5958d4c 4204 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4205
4206 Make sure a 64-bit char is never passed to CHAR_STRING.
4207 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4208 by silently ignoring the top 32 bits, allowing some values
4209 that were far too large to be valid characters.
4210 * character.h: Include <verify.h>.
4211 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4212 arguments are no wider than unsigned, as a compile-time check
4213 to prevent future regressions in this area.
4214 * data.c (Faset):
01103c44 4215 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4216 (Fsubst_char_in_region):
4217 * fns.c (concat):
4218 * xdisp.c (decode_mode_spec_coding):
4219 Adjust to CHAR_STRING's new requirement.
4220 * editfns.c (Finsert_char, Fsubst_char_in_region):
4221 * fns.c (concat): Check that character args are actually
4222 characters. Without this test, these functions did the wrong
4223 thing with wildly out-of-range values on 64-bit hosts.
4224
d37ca623
PE
4225 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4226 These casts should not be needed on 32-bit hosts, either.
4227 * keyboard.c (read_char):
4228 * lread.c (Fload): Remove casts to unsigned.
4229
ea204efb
PE
4230 * lisp.h (UNSIGNED_CMP): New macro.
4231 This fixes comparison bugs on 64-bit hosts.
4232 (ASCII_CHAR_P): Use it.
4233 * casefiddle.c (casify_object):
01103c44 4234 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4235 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4236 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4237 * dispextern.h (FACE_FROM_ID):
4238 * keyboard.c (read_char): Use UNSIGNED_CMP.
4239
41cb286c
PE
4240 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4241 not to EMACS_INT, to avoid GCC warning.
4242
4a1b9832
PE
4243 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4244
55daad71
PE
4245 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4246 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4247 isn't needed on 32-bit machines.
8f95c75c 4248
01103c44
PE
4249 * buffer.c (Fgenerate_new_buffer_name):
4250 Use EMACS_INT for count, not int.
0ceccced 4251 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4252
4253 * data.c (Qcompiled_function): Now static.
4254
c6f072e7
PE
4255 * window.c (window_body_lines): Now static.
4256
20ce5912
PE
4257 * image.c (gif_load): Rename local to avoid shadowing.
4258
9c4c5f81
PE
4259 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4260 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4261 * alloc.c (make_save_value): Integer argument is now of type
4262 ptrdiff_t, not int.
4263 (mark_object): Use ptrdiff_t, not int.
4264 * lisp.h (pD): New macro.
4265 * print.c (print_object): Use it.
4266
c0c5c8ae
PE
4267 * alloc.c: Use EMACS_INT, not int, to count objects.
4268 (total_conses, total_markers, total_symbols, total_vector_size)
4269 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4270 (total_free_floats, total_floats, total_free_intervals)
4271 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4272 Now EMACS_INT, not int. All uses changed.
4273 (Fgarbage_collect): Compute overall total using a double, so that
4274 integer overflow is less likely to be a problem. Check for overflow
4275 when converting back to an integer.
5a25e253
PE
4276 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4277 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4278 These were 'int' variables that could overflow on 64-bit hosts;
4279 they were never used, so remove them instead of repairing them.
211a0b2a 4280 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4281 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4282 Previously, this ceilinged at INT_MAX, but that doesn't work on
4283 64-bit machines.
e46bb31a 4284 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4285
c78baabf 4286 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4287 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4288 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4289 when a (possibly-narrower) signed value would do just as well.
4290 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4291
c9d624c6
PE
4292 * alloc.c: Catch some string size overflows that we were missing.
4293 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4294 for convenience in STRING_BYTES_MAX.
4295 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4296 The definition here is exact; the one in lisp.h was approximate.
4297 (allocate_string_data): Check for string overflow. This catches
4298 some instances we weren't catching before. Also, it catches
4299 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4300 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4301 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4302
c9d624c6
PE
4303 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4304 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4305 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4306
353032ce
PE
4307 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4308
2bccce07
PE
4309 * alloc.c (Fmake_string): Check for out-of-range init.
4310
0ac30604
SM
43112011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4312
4313 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4314
c195f2de
JD
43152011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4316
4317 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4318 xg_get_default_scrollbar_width.
4319
4320 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4321 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4322 (style_changed_cb): Call update_theme_scrollbar_width and call
4323 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4324 all frames (Bug#8505).
4325 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4326 Call gtk_window_set_resizable if HAVE_GTK3.
4327 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4328 and height if HAVE_GTK3 (Bug#8505).
4329 (scroll_bar_width_for_theme): New variable.
4330 (update_theme_scrollbar_width): New function.
4331 (xg_get_default_scrollbar_width): Move code to
4332 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4333 (xg_initialize): Call update_theme_scrollbar_width.
4334
4335 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4336
4337 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4338
e10ac9f1
MR
43392011-06-12 Martin Rudalics <rudalics@gmx.at>
4340
4341 * frame.c (make_frame): Call other_buffer_safely instead of
4342 other_buffer.
4343
4344 * window.c (temp_output_buffer_show): Call display_buffer with
4345 second argument Vtemp_buffer_show_specifiers and reset latter
4346 immediately after the call.
4347 (Vtemp_buffer_show_specifiers): New variable.
4348 (auto_window_vscroll_p, next_screen_context_lines)
4349 (Vscroll_preserve_screen_position): Remove leading asterisks from
4350 doc-strings.
4351
2d3c217e 43522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4353
7b7f97e8 4354 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4355 * buffer.c (Qclone_number): Remove for now, as it's unused.
4356 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4357 (record_buffer): Remove unused local.
4358 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4359 (set_frame_buffer_list): Remove; unused.
4360 * frame.h (other_visible_frames): Remove decl.
4361 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4362 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4363 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4364 if HAVE_GPM.
4365 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4366 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4367 Define only if HAVE_GPM.
4368 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4369 (update_hints_inhibit): Remove; never set. All uses removed.
4370 * widgetprv.h (emacsFrameClassRec): Remove decl.
4371 * window.c (delete_deletable_window): Now returns void, since it
4372 wasn't returning anything.
4373 (compare_window_configurations): Remove unused locals.
4374 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4375 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4376 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4377 the same widths as pointers. This follows up on the 2011-05-06 patch.
4378 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4379 * xterm.h: Likewise.
4380 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4381
1384b89e
JB
43822011-06-12 Juanma Barranquero <lekktu@gmail.com>
4383
4384 * makefile.w32-in: Update dependencies.
4385 (LISP_H): Add lib/intprops.h.
4386
1100a63c
CY
43872011-06-11 Chong Yidong <cyd@stupidchicken.com>
4388
4389 * image.c (gif_load): Add animation frame delay to the metadata.
4390 (syms_of_image): Use DEFSYM. New symbol `delay'.
4391
6198ccd0
MR
43922011-06-11 Martin Rudalics <rudalics@gmx.at>
4393
4394 * window.c (delete_deletable_window): Re-add.
4395 (Fset_window_configuration): Rewrite to handle dead buffers and
4396 consequently deletable windows.
4397 (window_tree, Fwindow_tree): Remove. Supply functionality in
4398 window.el.
4399 (compare_window_configurations): Simplify code.
4400
b6e3633c
AS
44012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4402
1ab0dee5
AS
4403 * image.c (imagemagick_load_image): Fix type mismatch.
4404 (Fimagemagick_types): Likewise.
4405
b6e3633c
AS
4406 * window.h (replace_buffer_in_windows): Declare.
4407
9397e56f
MR
44082011-06-11 Martin Rudalics <rudalics@gmx.at>
4409
4410 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4411 Qclone_number. Remove external declaration of Qdelete_window.
4412 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4413 code.
640c8776
SM
4414 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4415 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4416 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4417 buffer list implementation.
4418 (other_buffer_safely): New function.
4419 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4420 calls to replace_buffer_in_windows and
4421 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4422 if allowed.
4423 (record_buffer): Inhibit quitting and rewrite using quittable
4424 functions. Run Qbuffer_list_update_hook if allowed.
4425 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4426 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4427 Move switch-to-buffer to window.el.
9397e56f
MR
4428 (bury-buffer): Move to window.el.
4429 (Vbuffer_list_update_hook): New variable.
4430
4431 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4432 section.
4433
4434 * window.h (resize_frame_windows): Move up in code.
4435 (Fwindow_frame): Remove EXFUN.
4436 (replace_buffer_in_all_windows): Remove prototype.
4437 (replace_buffer_in_windows_safely): Add prototype.
4438
4439 * window.c: Declare Qdelete_window static again. Move down
4440 declaration of select_count.
4441 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4442 (Fother_window): Move to window.el.
4443 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4444 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4445 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4446 window.el.
4447 (replace_buffer_in_windows): Implement by calling
4448 Qreplace_buffer_in_windows.
4449 (replace_buffer_in_all_windows): Remove with some functionality
4450 moved into replace_buffer_in_windows_safely.
4451 (replace_buffer_in_windows_safely): New function.
4452 (select_window_norecord, select_frame_norecord): Move in front
4453 of run_window_configuration_change_hook. Remove now obsolete
4454 declarations.
640c8776
SM
4455 (Fset_window_buffer): Rewrite doc-string.
4456 Call Qrecord_window_buffer.
9397e56f
MR
4457 (keys_of_window): Move binding for other-window to window.el.
4458
b50691aa
CY
44592011-06-11 Chong Yidong <cyd@stupidchicken.com>
4460
4461 * dispextern.h (struct image): Replace data member, whose int_val
4462 and ptr_val fields were not used by anything, with a single
4463 lisp_val object.
4464
4465 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4466 (gif_clear_image, gif_load, imagemagick_load_image)
4467 (gs_clear_image, gs_load): Callers changed.
4468
3f754b86
PE
44692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4470
cca69397
PE
4471 * buffer.h: Include <time.h>, for time_t.
4472 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4473
109e28d0
PE
4474 Fix minor problems found by static checking.
4475
60737f02
PE
4476 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4477
4b66faf3
PE
4478 Make identifiers static if they are not used in other modules.
4479 * data.c (Qcompiled_function, Qframe, Qvector):
4480 * image.c (QimageMagick, Qsvg):
4481 * minibuf.c (Qmetadata):
4482 * window.c (resize_window_check, resize_root_window): Now static.
4483 * window.h (resize_window_check, resize_root_window): Remove decls.
4484
109e28d0
PE
4485 * window.c (window_deletion_count, delete_deletable_window):
4486 Remove; unused.
46a4ce9e
PE
4487 (window_body_lines): Now static.
4488 (Fdelete_other_windows_internal): Mark vars as initialized.
4489 Make sure 'resize_failed' is initialized.
4490 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4491 (resize_window_apply): Remove unused local.
4492 * window.h (delete_deletable_window): Remove decl.
4493
109e28d0 4494 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4495 (imagemagick_load_image): Fix pointer signedness problem by changing
4496 last arg from unsigned char * to char *. All uses changed.
4497 Also, fix a local for similar reasons.
4498 Remove unused locals. Remove locals to avoid shadowing.
4499 (fn_rsvg_handle_free): Remove; unused.
4500 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4501 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4502
3f754b86
PE
4503 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4504
2547adb1
CY
45052011-06-10 Chong Yidong <cyd@stupidchicken.com>
4506
4507 * image.c (gif_load): Fix omitted cast error introduced by
4508 2011-06-06 change.
4509
2c8e37d4
MR
45102011-06-10 Martin Rudalics <rudalics@gmx.at>
4511
4512 * window.h (resize_proportionally, orig_total_lines)
4513 (orig_top_line): Remove from window structure.
4514 (set_window_height, set_window_width, change_window_heights)
4515 (Fdelete_window): Remove prototypes.
4516 (resize_frame_windows): Remove duplicate declaration.
4517
440a42e3
EZ
45182011-06-10 Eli Zaretskii <eliz@gnu.org>
4519
4520 * window.h (resize_frame_windows, resize_window_check)
4521 (delete_deletable_window, resize_root_window)
4522 (resize_frame_windows): Declare prototypes.
4523
4524 * window.c (resize_window_apply): Make definition be "static" to
4525 match the prototype.
4526
562dd5e9
MR
45272011-06-10 Martin Rudalics <rudalics@gmx.at>
4528
4529 * window.c: Remove declarations of Qwindow_size_fixed,
4530 window_min_size_1, window_min_size_2, window_min_size,
4531 size_window, window_fixed_size_p, enlarge_window, delete_window.
4532 Remove static from declaration of Qdelete_window, it's
4533 temporarily needed by Fbury_buffer.
4534 (replace_window): Don't assign orig_top_line and
4535 orig_total_lines.
4536 (Fdelete_window, delete_window): Remove. Window deletion is
4537 handled by window.el.
640c8776
SM
4538 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4539 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4540 (Fdelete_other_windows): Remove. Deleting other windows is
4541 handled by window.el.
4542 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4543 handled in window.el.
4544 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4545 Window minimum sizes are handled in window.el.
4546 (shrink_windows, size_window, set_window_height)
4547 (set_window_width, change_window_heights, window_height)
4548 (window_width, CURBEG, CURSIZE, enlarge_window)
4549 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4550 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4551 handled in window.el.
4552 (make_dummy_parent): Rename to make_parent_window and give it a
4553 second argument horflag.
4554 (make_window): Don't set resize_proportionally any more.
4555 (Fsplit_window): Remove. Windows are split in window.el.
4556 (save_restore_action, save_restore_orig_size)
4557 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4558 Resize mini windows in window.el.
4559 (grow_mini_window, shrink_mini_window): Implement by calling
4560 Qresize_root_window_vertically, resize_window_check and
4561 resize_window_apply.
640c8776
SM
4562 (saved_window, Fset_window_configuration, save_window_save):
4563 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4564 resize_proportionally.
4565 (window_min_height, window_min_width): Move to window.el.
4566 (keys_of_window): Move bindings for delete-other-windows,
4567 split-window, delete-window and enlarge-window to window.el.
4568
4569 * buffer.c: Temporarily extern Qdelete_window.
4570 (Fbury_buffer): Temporarily call Qdelete_window instead of
4571 Fdelete_window (Fbury_buffer will move to window.el soon).
4572
4573 * frame.c (set_menu_bar_lines_1): Remove code handling
4574 orig_top_line and orig_total_lines.
4575
4576 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4577 set_window_height but set heights directly.
4578 (change_frame_size_1): Use resize_frame_windows.
4579
4580 * xdisp.c (init_xdisp): Don't use set_window_height but set
4581 heights directly.
4582
640c8776
SM
4583 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4584 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4585 run_window_configuration_change_hook.
4586
4587 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4588 instead of change_window_heights and run
4589 run_window_configuration_change_hook.
4590
1a13852e
MR
45912011-06-09 Martin Rudalics <rudalics@gmx.at>
4592
4593 * window.c (replace_window): Rename second argument REPLACEMENT to
4594 NEW. New third argument SETFLAG. Rewrite.
4595 (delete_window, make_dummy_parent): Call replace_window with
4596 third argument 1.
4597 (window_list_1): Move down in code.
4598 (run_window_configuration_change_hook): Move set_buffer part
4599 before select_frame_norecord part in order to unwind correctly.
4600 Rename count1 to count.
4601 (recombine_windows, delete_deletable_window, resize_root_window)
4602 (Fdelete_other_windows_internal)
4603 (Frun_window_configuration_change_hook, make_parent_window)
4604 (resize_window_check, resize_window_apply, Fresize_window_apply)
4605 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4606 (Fdelete_window_internal, Fresize_mini_window_internal):
4607 New functions.
1a13852e
MR
4608 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4609
f3d1777e
MR
46102011-06-08 Martin Rudalics <rudalics@gmx.at>
4611
496e208e
MR
4612 * window.h (window): Add some new members to window structure -
4613 normal_lines, normal_cols, new_total, new_normal, clone_number,
4614 splits, nest, prev_buffers, next_buffers.
4615 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4616 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4617
f3d1777e
MR
4618 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4619 Remove.
496e208e
MR
4620 (make_dummy_parent): Set new members of windows structure.
4621 (make_window): Move down in code. Handle new members of window
4622 structure.
4623 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4624 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4625 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4626 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4627 (Fset_window_next_buffers, Fset_window_clone_number):
4628 New functions.
496e208e
MR
4629 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4630 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4631 Doc-string fixes.
4632 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4633 Argument WINDOW can be now internal window too.
4634 (Fwindow_use_time): Move up in code.
4635 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4636 Rewrite doc-string.
4637 (Fset_window_configuration, saved_window)
4638 (Fcurrent_window_configuration, save_window_save): Handle new
4639 members of window structure.
b9e809c2
MR
4640 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4641 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4642 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4643 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4644 Qget_mru_window, Qresize_root_window,
4645 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4646 Qauto_buffer_name; staticpro them.
f3d1777e 4647
abde8f8c
MR
46482011-06-07 Martin Rudalics <rudalics@gmx.at>
4649
4650 * window.c (Fwindow_total_size, Fwindow_left_column)
4651 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4652 (Fwindow_list_1): New functions.
4653 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4654 (Fwindow_width, Fscroll_left, Fscroll_right):
4655 Use window_body_cols instead of window_box_text_cols.
4656 (delete_window, Fset_window_configuration):
4657 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4658 (delete_all_subwindows): Take a window as argument and not a
4659 structure. Rewrite.
190b47e6
MR
4660 (window_loop): Remove handling of GET_LRU_WINDOW and
4661 GET_LARGEST_WINDOW.
4662 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4663
4664 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4665 window_box_text_cols. delete_all_subwindows now takes a
4666 Lisp_Object as argument.
abde8f8c 4667
640c8776
SM
4668 * indent.c (compute_motion, Fcompute_motion):
4669 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4670
fa8a67e6
MR
4671 * frame.c (delete_frame): Call delete_all_subwindows with root
4672 window as argument.
4673
a54e3482
DC
46742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4675
4676 * fns.c (Fputhash): Document return value.
4677
60002bf5
CY
46782011-06-06 Chong Yidong <cyd@stupidchicken.com>
4679
4680 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4681
0c671da6 46822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4683
b862a52a 4684 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4685
be44ca6c
PE
4686 Check for overflow when converting integer to cons and back.
4687 * charset.c (Fdefine_charset_internal, Fdecode_char):
4688 Use cons_to_unsigned to catch overflow.
4689 (Fencode_char): Use INTEGER_TO_CONS.
4690 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4691 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4692 * data.c (long_to_cons, cons_to_long): Remove.
4693 (cons_to_unsigned, cons_to_signed): New functions.
4694 These signal an error for invalid or out-of-range values.
4695 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4696 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4697 * font.c (Ffont_variation_glyphs):
4698 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4699 * lisp.h: Include <intprops.h>.
4700 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4701 (cons_to_signed, cons_to_unsigned): New decls.
4702 (long_to_cons, cons_to_long): Remove decls.
4703 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4704 (Fprimitive_undo): Use CONS_TO_INTEGER.
4705 * xfns.c (Fx_window_property): Likewise.
4706 * xselect.c: Include <limits.h>.
4707 (x_own_selection, selection_data_to_lisp_data):
4708 Use INTEGER_TO_CONS.
4709 (x_handle_selection_request, x_handle_selection_clear)
4710 (x_get_foreign_selection, Fx_disown_selection_internal)
4711 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4712 (lisp_data_to_selection_data): Use cons_to_unsigned.
4713 (x_fill_property_data): Use cons_to_signed.
4714 Report values out of range.
4715
d1f3d2af
PE
4716 Check for buffer and string overflow more precisely.
4717 * buffer.h (BUF_BYTES_MAX): New macro.
4718 * lisp.h (STRING_BYTES_MAX): New macro.
4719 * alloc.c (Fmake_string):
4720 * character.c (string_escape_byte8):
4721 * coding.c (coding_alloc_by_realloc):
4722 * doprnt.c (doprnt):
4723 * editfns.c (Fformat):
4724 * eval.c (verror):
4725 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4726 since they may not be the same number.
4727 * editfns.c (Finsert_char):
4728 * fileio.c (Finsert_file_contents):
4729 Likewise for BUF_BYTES_MAX.
4730
dd52fcea
PE
4731 * image.c: Use ptrdiff_t, not int, for sizes.
4732 (slurp_file): Switch from int to ptrdiff_t.
4733 All uses changed.
4734 (slurp_file): Check that file size fits in both size_t (for
4735 malloc) and ptrdiff_t (for sanity and safety).
4736
7f9bbdbb
PE
4737 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4738 if b->modtime has its maximal value.
4739
dfe18f82
PE
4740 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4741
84acfcf0
PE
4742 Don't assume time_t can fit into int.
4743 * buffer.h (struct buffer.modtime): Now time_t, not int.
4744 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4745 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4746
ccd9a01a
PE
4747 Minor fixes for signed vs unsigned integers.
4748 * character.h (MAYBE_UNIFY_CHAR):
4749 * charset.c (maybe_unify_char):
4750 * keyboard.c (read_char, reorder_modifiers):
4751 XINT -> XFASTINT, since the integer must be nonnegative.
4752 * ftfont.c (ftfont_spec_pattern):
4753 * keymap.c (access_keymap, silly_event_symbol_error):
4754 XUINT -> XFASTINT, since the integer must be nonnegative.
4755 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4756 since it makes no difference and we prefer signed.
4757 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4758 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4759 nonnegative.
4760
d6d100dd
SM
47612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4762
4763 * window.h (Fwindow_frame): Declare.
4764
2b6148e4
PE
47652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4768 (SPARE_MEMORY): Always define.
4769 (LARGE_REQUEST): Remove.
4770 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4771
f230ecc9
MR
47722011-06-06 Martin Rudalics <rudalics@gmx.at>
4773
727e958e
MR
4774 * lisp.h: Move EXFUNS for Fframe_root_window,
4775 Fframe_first_window and Fset_frame_selected_window to window.h.
4776
4777 * window.h: Move EXFUNS for Fframe_root_window,
4778 Fframe_first_window and Fset_frame_selected_window here from
4779 lisp.h.
4780
4781 * frame.c (Fwindow_frame, Fframe_first_window)
4782 (Fframe_root_window, Fframe_selected_window)
4783 (Fset_frame_selected_window): Move to window.c.
4784 (Factive_minibuffer_window): Move to minibuf.c.
4785 (Fother_visible_frames_p): New function.
4786
4787 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4788
f230ecc9
MR
4789 * window.c (decode_window, decode_any_window): Move up in code.
4790 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4791 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4792 (Fwindow_buffer): Move up and rewrite doc-string.
4793 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4794 (Fwindow_prev): New functions.
727e958e
MR
4795 (Fwindow_frame): Move here from frame.c. Accept any window as
4796 argument.
4797 (Fframe_root_window, Fframe_first_window)
4798 (Fframe_selected_window): Move here from frame.c. Accept frame
4799 or arbitrary window as argument. Update doc-strings.
4800 (Fminibuffer_window): Move up in code.
4801 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4802 (Fset_frame_selected_window): Move here from frame.c.
4803 Marginal rewrite.
727e958e
MR
4804 (Fselected_window, select_window, Fselect_window): Move up in
4805 code. Minor doc-string fixes.
f230ecc9 4806
4d09bcf6
PE
48072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4808
4809 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4810 Do not assume that spare memory exists; that assumption is valid
4811 only if SYSTEM_MALLOC.
4812 (LARGE_REQUEST): New macro, so that the issue of large requests
4813 is separated from the issue of spare memory.
4814
810928a2
AS
48152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4816
172418ad
AS
4817 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4818 format. (Bug#8806)
4819
43f862f7
AS
4820 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4821
810928a2
AS
4822 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4823 before statements.
4824
a059fe24
JD
48252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4826
4827 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4828
4829 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4830
4831 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4832 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4833
989bf368
JB
48342011-06-05 Juanma Barranquero <lekktu@gmail.com>
4835
4836 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4837
4b80f674
CY
48382011-06-04 Chong Yidong <cyd@stupidchicken.com>
4839
4840 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4841 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4842 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4843 New error handlers.
4b80f674
CY
4844 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4845 Obey Vx_select_enable_clipboard_manager. Catch errors in
4846 x_clipboard_manager_save (Bug#8779).
4847 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4848 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4849
99a33b77 48502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4851
4852 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4853
99a33b77 48542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4855
4856 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4857 in the current matrix if keep_current_p is non-zero.
4858
8264569d
EZ
48592011-06-04 Eli Zaretskii <eliz@gnu.org>
4860
4861 * bidi.c (bidi_level_of_next_char): Fix last change.
4862
57f97249
EZ
48632011-06-03 Eli Zaretskii <eliz@gnu.org>
4864
fec2107c 4865 Support bidi reordering of text covered by display properties.
57f97249 4866
fec2107c
EZ
4867 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4868 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4869 (bidi_cache_search, bidi_cache_iterator_state)
4870 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4871 (bidi_level_of_next_char, bidi_move_to_visually_next):
4872 Support character positions inside a run of characters covered by a
fec2107c
EZ
4873 display string.
4874 (bidi_paragraph_init, bidi_resolve_explicit_1)
4875 (bidi_level_of_next_char): Call bidi_fetch_char and
4876 bidi_fetch_char_advance instead of FETCH_CHAR and
4877 FETCH_CHAR_ADVANCE.
4878 (bidi_init_it): Initialize new members.
4879 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4880 definitions.
4881 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4882 instead of using explicit *_CHAR codes.
d6d100dd
SM
4883 (bidi_resolve_explicit, bidi_resolve_weak):
4884 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4885 bidirectional text is supported only in multibyte buffers.
4886 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4887 it to initialize the frame_window_p member of struct bidi_it.
4888 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4889 (bidi_resolve_explicit, bidi_resolve_weak)
4890 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4891 bidi_it->nchars is non-positive.
4892 (bidi_level_of_next_char): Don't try to lookup the cache for the
4893 next/previous character if nothing is cached there yet, or if we
4894 were just reseat()'ed to a new position.
c40e2fb2 4895
0e14fe90
EZ
4896 * xdisp.c (set_cursor_from_row): Set start and stop points
4897 according to the row's direction when priming the loop that looks
4898 for the glyph on which to display cursor.
4899 (single_display_spec_intangible_p): Function deleted.
4900 (display_prop_intangible_p): Reimplement to call
4901 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4902 Accept 3 additional arguments needed by handle_display_spec.
4903 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4904 values: lists, `(when COND...)' forms, etc.
4905 (single_display_spec_string_p): Support property values that are
4906 lists with the argument STRING its top-level element.
4907 (display_prop_string_p): Fix the condition for processing a
4908 property that is a list to be consistent with handle_display_spec.
fec2107c 4909 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4910 last portion of handle_display_prop.
4911 (compute_display_string_pos): Accept additional argument
4912 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4913 value of a `display' property is a "replacing spec".
4914 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4915 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4916 the display property, but just return a value indicating whether
4917 the display property will replace the characters it covers.
4918 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4919 frame_window_p members of struct bidi_it.
d6d100dd
SM
4920 (compute_display_string_pos, compute_display_string_end):
4921 New functions.
fec2107c
EZ
4922 (push_it): Accept second argument POSITION, where pop_it should
4923 jump to continue iteration.
4924 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4925
fec2107c
EZ
4926 * keyboard.c (adjust_point_for_property): Adjust the call to
4927 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4928
4929 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4930 (bidi_init_it): Update prototypes.
4931 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4932 (compute_display_string_pos, compute_display_string_end):
4933 Declare prototypes.
fec2107c
EZ
4934 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4935 EMACS_INT.
fc6f18ce 4936
40087514 49372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4938
57f53182
PE
4939 Malloc failure behavior now depends on size of allocation.
4940 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4941 * lisp.h: Change signatures accordingly.
4942 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4943 All callers changed. (Bug#8762)
4944
4945 * gnutls.c: Use Emacs's memory allocators.
4946 Without this change, the gnutls library would invoke malloc etc.
4947 directly, which causes problems on non-SYNC_INPUT hosts, and which
4948 runs afoul of improving memory_full behavior. (Bug#8761)
4949 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4950 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4951 xfree instead of the default malloc, realloc, free.
4952 (Fgnutls_boot): No need to check for memory allocation failure,
4953 since xmalloc does that for us.
4954
ac32cd99 4955 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4956 * category.c (hash_get_category_set):
4957 * ccl.c (ccl_driver):
4958 * charset.c (Fdefine_charset_internal):
4959 * charset.h (struct charset.hash_index):
4960 * composite.c (get_composition_id, gstring_lookup_cache)
4961 (composition_gstring_put_cache):
4962 * composite.h (struct composition.hash_index):
4963 * dispextern.h (struct image.hash):
4964 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4965 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4966 (hashfn_equal, hashfn_user_defined, make_hash_table)
4967 (maybe_resize_hash_table, hash_lookup, hash_put)
4968 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4969 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4970 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4971 * image.c (make_image, search_image_cache, lookup_image)
4972 (xpm_put_color_table_h):
4973 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4974 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4975 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4976 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4977 * alloc.c (allocate_vectorlike):
4978 Check for overflow in vector size calculations.
4979 * ccl.c (ccl_driver):
4980 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4981 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4982 need to be updated by these changes.
40087514
PE
4983 * fns.c (make_hash_table, maybe_resize_hash_table):
4984 Check for integer overflow with large hash tables.
0de4bb68
PE
4985 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4986 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4987 (SXHASH_REDUCE): New macro.
4988 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4989 Use it instead of discarding useful hash info with large hash values.
4990 (sxhash_float): New function.
4991 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4992 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4993 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4994 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4995 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4996 Adjust signatures to match updated version of code.
4997 (consing_since_gc): Now EMACS_INT, since a single hash table can
4998 use more than INT_MAX bytes.
4999
698d32e2
DN
50002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5001
5002 Make it possible to build with GCC-4.6+ -O2 -flto.
5003
5004 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5005
fd6fa53f
SM
50062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5007
5008 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5009 Call minibuffer-inactive-mode.
5010
864db017
JB
50112011-05-31 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5014 Update dependencies.
5015
2ad0baf4
DN
50162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5017
5018 * data.c (init_data): Remove code for UTS, this system is not
5019 supported anymore.
5020
4fcc2638
DN
50212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5022
5023 Don't force ./temacs to start in terminal mode.
5024
5025 * frame.c (make_initial_frame): Initialize faces in all cases, not
5026 only when CANNOT_DUMP is defined.
5027 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5028
c56e0fd5
DN
50292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5030
5031 * dispnew.c (add_window_display_history): Use const for the string
5032 pointer. Remove declaration, not needed.
5033
333d54da 50342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5035
55d4c1b2 5036 Use 'inline', not 'INLINE'.
333d54da 5037 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5038 * alloc.c, fontset.c (INLINE): Remove.
5039 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5040 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5041 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5042 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5043 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5044
738db178
DN
50452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5046
5047 Make it possible to run ./temacs.
5048
5049 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5050 syms_of_callproc does the same thing. Remove test for
5051 "initialized", do it in the caller.
5052 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5053
620c53a6
SM
50542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5055
5056 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5057 (read_minibuf): Use get_minibuffer.
5058 (syms_of_minibuf): Use DEFSYM.
5059 (Qmetadata): New var.
5060 * data.c (Qbuffer): Don't make it static.
5061 (syms_of_data): Use DEFSYM.
5062
e003a292
PE
50632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5064
5065 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5066 (CCL_CODE_MIN): New macro.
5067
ed008a6d
PE
50682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5069
3687c2ef
PE
5070 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5071
ed008a6d
PE
5072 * eval.c (Qdebug): Now static.
5073 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5074 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5075 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5076
d66c4c7c
CY
50772011-05-29 Chong Yidong <cyd@stupidchicken.com>
5078
5079 * image.c: Various fixes to ImageMagick code comments.
5080 (Fimagemagick_types): Doc fix.
5081
5fbc2025
PE
50822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5083
0196f88a
PE
5084 Minor fixes prompted by GCC 4.6.0 warnings.
5085
5086 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5087
5fbc2025
PE
5088 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5089 (x_clipboard_manager_save_all): Move extern decl to ...
5090 * xterm.h: ... here, so that it can be checked for consistency.
5091
1dd3c2d9
CY
50922011-05-29 Chong Yidong <cyd@stupidchicken.com>
5093
5094 * xselect.c (x_clipboard_manager_save_frame)
5095 (x_clipboard_manager_save_all): New functions.
5096 (Fx_clipboard_manager_save): Lisp function deleted.
5097
5098 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5099 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5100
5101 * xterm.h: Update prototype.
5102
5ba6571d
WX
51032011-05-28 William Xu <william.xwl@gmail.com>
5104
5105 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5106 exiting (Bug#8239).
5107
3eaff834
JM
51082011-05-28 Jim Meyering <meyering@redhat.com>
5109
e1900994 5110 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5111 * fns.c (to_uchar): Define.
5112 (crypto_hash_function): Use it to convert some newly-signed
5113 variables to unsigned, to avoid sign-extension bugs. For example,
5114 without this change, (md5 "truc") would evaluate to
5115 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5116 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5117 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5118
0f6990a7
PE
51192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5120
5121 Integer overflow fixes.
c8a9ca5a 5122
08686060
PE
5123 * dbusbind.c: Serial number integer overflow fixes.
5124 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5125 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5126 to hold a serial number that is too large for a fixnum.
5127 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5128 Check for serial numbers out of range. Decode any serial number
59568bf0 5129 that was so large that it became a float. (Bug#8722)
08686060 5130
2d1fc3c7
PE
5131 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5132 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5133 Use XFASTINT rather than XUINT when numbers are nonnegative.
5134 (xd_append_arg, Fdbus_method_return_internal):
5135 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5136 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5137 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5138 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5139 (Bug#8722)
2d1fc3c7 5140
c8a9ca5a
PE
5141 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5142
519e1d69
PE
5143 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5144
30569699
PE
5145 ccl: add integer overflow checks
5146 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5147 (IN_INT_RANGE): New macros.
5148 (ccl_driver): Use them to check for integer overflow when
5149 decoding a CCL program. Many of the new checks are whether XINT (x)
5150 fits in int; it doesn't always, on 64-bit hosts. The new version
5151 doesn't catch all possible integer overflows, but it's an
847044ea 5152 improvement. (Bug#8719)
30569699 5153
c11285dc
PE
5154 * alloc.c (make_event_array): Use XINT, not XUINT.
5155 There's no need for unsigned here.
5156
fdccd48e
PE
5157 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5158 This follows up to the 2011-05-06 change that substituted uintptr_t
5159 for EMACS_INT. This case wasn't caught back then.
5160
37910ab2
PE
5161 Rework Fformat to avoid integer overflow issues.
5162 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5163 now (part of C89). Include <verify.h>.
5164 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5165 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5166 (Fformat): Avoid the prepass trying to compute sizes; it was only
5167 approximate and thus did not catch overflow reliably. Instead, walk
5168 through the format just once, formatting and computing sizes as we go,
5169 checking for integer overflow at every step, and allocating a larger
5170 buffer as needed. Keep track separately whether the format is
5171 multibyte. Keep only the most-recently calculated precision, rather
5172 than them all. Record whether each argument has been converted to
5173 string. Use EMACS_INT, not int, for byte and char and arg counts.
5174 Support field widths and precisions larger than INT_MAX. Avoid
5175 sprintf's undefined behavior with conversion specifications such as %#d
5176 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5177 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5178 formatting out-of-range floating point numbers with int
9173deec 5179 formats. (Bug#8668)
37910ab2 5180
2e6578fb
PE
5181 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5182
0ae6bdee
PE
5183 * data.c: Avoid integer truncation in expressions involving floats.
5184 * data.c: Include <intprops.h>.
5185 (arith_driver): When there's an integer overflow in an expression
5186 involving floating point, convert the integers to floating point
5187 so that the resulting value does not suffer from catastrophic
5188 integer truncation. For example, on a 64-bit host (* 4
5189 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5190 Do not rely on undefined behavior after integer overflow.
5191
de883a70
PE
5192 merge count_size_as_multibyte, parse_str_to_multibyte
5193 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5194 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5195 Check for integer overflow.
5196 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5197 since it's now a duplicate of the other. This is more of
5198 a character than a buffer op, so better that it's in character.c.
5199 * fns.c, print.c: Adjust to above changes.
5200
2ff916cb
PE
52012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5202
5203 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5204
f1b54466
PE
52052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5206
fb1ac845
PE
5207 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5208 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5209 (x_clipboard_manager_save): Now static.
5210 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5211
f1b54466
PE
5212 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5213 (crypto_hash_function): Now static.
5214 Fix pointer signedness problems. Avoid unnecessary initializations.
5215
a9f737ee
CY
52162011-05-27 Chong Yidong <cyd@stupidchicken.com>
5217
5218 * termhooks.h (Vselection_alist): Make it terminal-local.
5219
5220 * terminal.c (create_terminal): Initialize it.
5221
5222 * xselect.c: Support for clipboard managers.
5223 (Vselection_alist): Move to termhooks.h as terminal-local var.
5224 (LOCAL_SELECTION): New macro.
5225 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5226 (symbol_to_x_atom): Remove gratuitous arg.
5227 (x_handle_selection_request, lisp_data_to_selection_data)
5228 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5229 (x_own_selection, x_get_local_selection, x_convert_selection):
5230 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5231 (some_frame_on_display): Delete unused function.
5232 (Fx_own_selection_internal, Fx_get_selection_internal)
5233 (Fx_disown_selection_internal, Fx_selection_owner_p)
5234 (Fx_selection_exists_p): New optional frame arg.
5235 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5236 (x_handle_selection_clear): Don't treat other terminals with the
5237 same keyboard specially. Use the terminal-local Vselection_alist.
5238 (x_clear_frame_selections): Use Frun_hook_with_args.
5239
5240 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5241
5242 * xterm.h: Add support for those atoms.
5243
e067f0c1
CY
52442011-05-26 Chong Yidong <cyd@stupidchicken.com>
5245
5246 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5247 (converted_selections, conversion_fail_tag): New global variables.
5248 (x_selection_request_lisp_error): Free the above.
5249 (x_get_local_selection): Remove unnecessary code.
5250 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5251 of converted selections stored in converted_selections.
5252 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5253 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5254 (x_convert_selection): New function.
5255 (x_handle_selection_event): Simplify.
5256 (x_get_foreign_selection): Don't ignore incoming requests while
5257 waiting for an answer; this will fail when we implement
5258 SAVE_TARGETS, and seems unnecessary anyway.
5259 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5260 (Vx_sent_selection_functions): Doc fix.
5261
0f4aebc0
LL
52622011-05-26 Leo Liu <sdl.web@gmail.com>
5263
5264 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5265
e61124cd
YM
52662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5267
5268 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5269
5270 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5271 for fringe update if it has periodic bitmap.
ac389d0c 5272 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5273 and fringe_bitmap_periodic_p.
5274
5275 * fringe.c (get_fringe_bitmap_data): New function.
5276 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5277 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5278 row. Mark glyph row for fringe update if periodicity changed.
5279
5280 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5281 for fringe update unless it has periodic bitmap.
5282
f16d9837
KH
52832011-05-25 Kenichi Handa <handa@m17n.org>
5284
5285 * xdisp.c (get_next_display_element): Set correct it->face_id for
5286 a static composition.
5287
e1b90ef6
LL
52882011-05-24 Leo Liu <sdl.web@gmail.com>
5289
5290 * deps.mk (fns.o):
5291 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5292
5293 * fns.c (crypto_hash_function, Fsha1): New function.
5294 (Fmd5): Use crypto_hash_function.
5295 (syms_of_fns): Add Ssha1.
5296
7400048f
PE
52972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5298
5299 * gnutls.c: Remove unused macros.
5300 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5301 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5302 Remove macros that are defined and never used.
5303 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5304
abb71cf4
CY
53052011-05-22 Chong Yidong <cyd@stupidchicken.com>
5306
5307 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5308 (Fx_get_selection_internal): Minor cleanup.
5309 (Fx_own_selection_internal): Rename arguments for consistency with
5310 select.el.
5311
6307db39
PE
53122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5313
5314 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5315
f3d4e0a4
CY
53162011-05-22 Chong Yidong <cyd@stupidchicken.com>
5317
5318 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5319
4d8ade89
YM
53202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5321
5322 * dispnew.c (scrolling_window): Don't exclude the case that the
5323 last enabled row in the desired matrix touches the bottom boundary.
5324
32078c8d
GM
53252011-05-21 Glenn Morris <rgm@gnu.org>
5326
5327 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5328 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5329 and add some more files.
32078c8d 5330
7285dc67
EZ
53312011-05-20 Eli Zaretskii <eliz@gnu.org>
5332
5333 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5334 report_file_error introduced by the change from 2011-05-07.
5335
89d1bd22
PE
53362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5337
5338 * systime.h (Time): Define only if emacs is defined.
5339 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5340 where the include path doesn't have X11/X.h by default. See
5341 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5342
e23640bb 53432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5344
5345 * composite.c (find_automatic_composition): Fix previous change.
5346
b9704ad9
GM
53472011-05-20 Glenn Morris <rgm@gnu.org>
5348
5349 * lisp.mk: New file, split from Makefile.in.
5350 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5351 (shortlisp): Remove.
5352 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5353
4a720484
GM
53542011-05-19 Glenn Morris <rgm@gnu.org>
5355
5356 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5357 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5358 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5359 (lisp): Set the order to that of loadup.el.
5360 (shortlisp): Make it a copy of $lisp.
5361 (SOME_MACHINE_LISP): Remove.
5362 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5363 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5364
a28d4396
KH
53652011-05-18 Kenichi Handa <handa@m17n.org>
5366
5367 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5368 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5369 (find_automatic_composition): Mostly rewrite for efficiency.
5370
a2b1fa8e
JB
53712011-05-18 Juanma Barranquero <lekktu@gmail.com>
5372
5373 * makefile.w32-in: Update dependencies.
5374
8e1f5610
CS
53752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5376
5377 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5378 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5379
7025ee00 53802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5381
cdfa6eab
PE
5382 Fix some integer overflow issues, such as string length overflow.
5383
06d6db33
PE
5384 * insdel.c (count_size_as_multibyte): Check for string overflow.
5385
2b4560a8
PE
5386 * character.c (lisp_string_width): Check for string overflow.
5387 Use EMACS_INT, not int, for string indexes and lengths; in
5388 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5389 the resulting string length overflows an EMACS_INT; instead,
5390 report a string overflow if no precision given. When checking for
5391 precision exhaustion, use a check that cannot possibly have
5392 integer overflow. (Bug#8675)
5393 * character.h (lisp_string_width): Adjust to new signature.
5394
cb93f9be
PE
5395 * alloc.c (string_overflow): New function.
5396 (Fmake_string): Use it. This doesn't change behavior, but saves
5397 a few bytes and will simplify future changes.
5398 * character.c (string_escape_byte8): Likewise.
5399 * lisp.h (string_overflow): New decl.
5400
1a1f3366
PE
5401 Fixups, following up to the user-interface timestamp change.
5402 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5403 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5404 * msdos.c (mouse_get_pos): Likewise.
5405 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5406 * w32gui.h (Time): Define by including "systime.h" rather than by
5407 declaring it ourselves. (Bug#8664)
5408
d4e3e4d3
PE
5409 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5410 * image.c (clear_image_cache): Likewise.
5411
f6a24d19
PE
5412 * term.c (term_mouse_position): Don't assume time_t wraparound.
5413
08dc5ae6
PE
5414 Be more systematic about user-interface timestamps.
5415 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5416 and sometimes 'EMACS_UINT', to represent these timestamps.
5417 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5418 This makes the code easier to follow, and makes it easier to catch
5419 integer overflow bugs such as Bug#8664.
5420 * frame.c (Fmouse_position, Fmouse_pixel_position):
5421 Use Time, not unsigned long, for user-interface timestamps.
5422 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5423 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5424 * keyboard.h (last_event_timestamp): Likewise.
5425 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5426 * menu.h (xmenu_show): Likewise.
5427 * term.c (term_mouse_position): Likewise.
5428 * termhooks.h (struct input_event.timestamp): Likewise.
5429 (struct terminal.mouse_position_hook): Likewise.
5430 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5431 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5432 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5433 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5434 what it was before.
5435 * menu.h, termhooks.h: Include "systime.h", for Time.
5436
8e55734a
PE
5437 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5438 Don't assume that the difference between two unsigned long values
5439 can fit into an integer. At this point, we know button_down_time
5440 <= event->timestamp, so the difference must be nonnegative, so
5441 there's no need to cast the result if double-click-time is
5442 nonnegative, as it should be; check that it's nonnegative, just in
5443 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5444 apart (about 25 days). (Bug#8664)
8e55734a 5445
841f1b75 5446 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5447 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5448
3e26f69c
PE
5449 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5450 that always fit in int. Use a sentinel instead of a counter, to
5451 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5452 * frame.h (struct frame): Use int for menu_bar_items_used
5453 instead of EMACS_INT, since it always fits in int.
3e26f69c 5454
5cc152c0
PE
5455 * menu.c (grow_menu_items): Check for int overflow.
5456
d89eb65e
PE
5457 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5458
5235bd3e
PE
5459 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5460 Before, the code was not consistent. These values cannot exceed
5461 2**31 - 1 so there's no need to make them unsigned.
5462 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5463 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5464 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5465 as modifiers.
5466 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5467
bc827e23
PE
5468 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5469 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5470 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5471 presumably because the widths might not match.
5472
78eb494e
PE
5473 * window.c (size_window): Avoid needless test at loop start.
5474
04f2d78b
CB
54752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5476
5477 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5478
d2fc7e3d 54792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5480
5481 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5482
d2fc7e3d 54832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5484
5485 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5486 `width' to `bar_area_x' and `bar_area_width', respectively.
5487 (x_scroll_run): Take account of fringe background extension.
5488
04f2d78b
CB
5489 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5490 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5491 `bar_area_width', respectively.
5492 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5493 background extension.
5494
79b70037
GM
54952011-05-10 Jim Meyering <meyering@redhat.com>
5496
5497 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5498
2f142cc5
JB
54992011-05-10 Juanma Barranquero <lekktu@gmail.com>
5500
5501 * image.c (Finit_image_library): Return t for built-in image types,
5502 like pbm and xbm. (Bug#8640)
5503
57679c86
AS
55042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5505
5506 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5507
888c9e86
EZ
55082011-05-07 Eli Zaretskii <eliz@gnu.org>
5509
b0512a1d
EZ
5510 * w32console.c (Fset_screen_color): Doc fix.
5511 (Fget_screen_color): New function.
5512 (syms_of_ntterm): Defsubr it.
5513
7285dc67
EZ
5514 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5515 unlink the temporary file if Fcall_process didn't create it in the
5516 first place.
5517 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5518 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5519 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5520 cue to call_process_cleanup not to close that handle.
5521
4d3fcc8e
BK
55222011-05-07 Ben Key <bkey76@gmail.com>
5523
5524 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5525 one of two shell specific rules, either bootstrap-temacs-CMD or
5526 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5527 to the previous implementation of the bootstrap-temacs rule.
5528 The bootstrap-temacs-CMD rule is similar to the previous
5529 implementation of the bootstrap-temacs rule except that it
5530 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5531 variable.
5532
5533 These changes, along with some changes to nt/configure.bat,
5534 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5535 earlier fix to add support for --cflags and --ldflags options
5536 that include quotes so that it works whether make uses cmd or
5537 sh as the shell.
5538
b4289b64
MA
55392011-05-06 Michael Albinus <michael.albinus@gmx.de>
5540
5541 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5542 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5543 is a constant.
5544 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5545 a string. Handle both cases.
5546 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5547 (Fdbus_register_method): Use Qinvalid_function.
5548
af4c0e28
JB
55492011-05-06 Juanma Barranquero <lekktu@gmail.com>
5550
5551 * makefile.w32-in: Update dependencies.
5552 (LISP_H): Add inttypes.h and stdin.h.
5553 (PROCESS_H): Add unistd.h.
5554
c51453d9
EZ
55552011-05-06 Eli Zaretskii <eliz@gnu.org>
5556
5557 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5558 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5559
8ff0ac3c 55602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5561
4c4b566b
PE
5562 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5563
aab2b9b5
PE
5564 * term.c (vfatal): Remove stray call to va_end.
5565 It's not needed and the C Standard doesn't allow it here anyway.
5566
c378da0b
PE
5567 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5568 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5569
288b08c7
PE
5570 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5571 bytes.
5572
e3601888
PE
5573 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5574
db6c0e74
PE
5575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5576
dd5963ea
PE
5577 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5578
88c9450f
PE
5579 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5580
2f9442b8
PE
5581 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5582
c032b5f8
PE
5583 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5584 * charset.c (Fdefine_charset_internal): Don't initialize
5585 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5586 32-bit int (Bug#8600).
a108c10b
PE
5587
5588 * lread.c (read_integer): Be more consistent with string-to-number.
5589 Use string_to_number to do the actual conversion; this avoids
5590 rounding errors and fixes some other screwups. Without this fix,
5591 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5592 (digit_to_number): Move earlier, for benefit of read_integer.
5593 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5594 not a digit in any supported base. (Bug#8602)
a108c10b 5595
ad5f9eea
PE
5596 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5597
aec1708a
PE
5598 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5599 to match comment at start of function. This also removes a
5600 GCC warning about overflow in a 32+64-bit port.
5601
47be4ab5
PE
5602 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5603
371cac43
PE
5604 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5605 Reported by Stefan Monnier in
5606 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5607 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5608 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5609
d01a7826
PE
5610 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5611 (EMACS_UINTPTR): Likewise, with uintptr_t.
5612
7fd47d5c
PE
5613 * lisp.h: Prefer 64-bit EMACS_INT if available.
5614 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5615 on 32-bit hosts that have 64-bit int, so that they can access
5616 large files.
122b0c86
PE
5617 However, temporarily disable this change unless the temporary
5618 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5619
8727937b
PE
5620 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5621
8ac068ac
PE
5622 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5623 This removes an assumption that EMACS_INT and long are the same
5624 width as pointers. The assumption is true for Emacs porting targets
5625 now, but we want to make other targets possible.
5626 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5627 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5628 In the rest of the code, change types of integers that hold casted
5629 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5630 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5631 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5632 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5633 No need to cast type when ORing.
5634 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5635 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5636 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5637 assume EMACS_INT is the same width as char *.
5638 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5639 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5640 Remove no-longer-needed casts.
5641 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5642 (xg_tool_bar_help_callback, xg_make_tool_item):
5643 Use EMACS_INTPTR to hold an integer
5644 that will be cast to void *; this can avoid a GCC warning
5645 if EMACS_INT is not the same width as void *.
5646 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5647 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5648 (current_message_1, set_message_1):
5649 Use a local to convert to proper width without a cast.
5650 * xmenu.c (dialog_selection_callback): Likewise.
5651
ede49d71
PE
5652 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5653 Also, don't assume VALBITS / RAND_BITS is less than 5,
5654 and don't rely on undefined behavior when shifting a 1 left into
5655 the sign bit.
5656 * lisp.h (get_random): Change signature to match.
5657
2f30ecd0
PE
5658 * lread.c (hash_string): Use size_t, not int, for hash computation.
5659 Normally we prefer signed values; but hashing is special, because
5660 it's better to use unsigned division on hash table sizes so that
5661 the remainder is nonnegative. Also, size_t is the natural width
5662 for hashing into memory. The previous code used 'int', which doesn't
5663 retain enough info to hash well into very large tables.
5664 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5665
2a866e7b
PE
5666 * dbusbind.c: Don't possibly lose pointer info when converting.
5667 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5668 Use XPNTR rather than XHASH, so that the high-order bits of
5669 the pointer aren't lost when converting through void *.
5670
51639eac
PE
5671 * eval.c (Fautoload): Don't double-shift a pointer.
5672
92394119
PE
5673 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5674
dbdb9a7c
JB
56752011-05-06 Juanma Barranquero <lekktu@gmail.com>
5676
5677 * gnutls.c (DEF_GNUTLS_FN):
5678 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5679
db7a0b4f
AS
56802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5681
5682 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5683 marker. (Bug#8610)
5684
f7ff1b0f 56852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5686
5687 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5688 New version that can reserve upto 2GB of heap space.
5689
f7ff1b0f 56902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5691
5692 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5693
639c109b
TZ
56942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5695
5696 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5697 `gnutls_certificate_set_x509_key_file'.
5698
d2127135
JB
56992011-05-05 Juanma Barranquero <lekktu@gmail.com>
5700
5701 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5702 Update dependencies.
5703
e968f4f3
JB
57042011-05-04 Juanma Barranquero <lekktu@gmail.com>
5705
5706 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5707 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5708 Remove unused parameter `fildes'.
5709 * process.c (read_process_output, send_process): Don't pass it.
5710
84d358f0
JB
57112011-05-04 Juanma Barranquero <lekktu@gmail.com>
5712
5713 Fix previous change: the library cache is defined in w32.c.
5714 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5715 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5716
0898ca10
JB
57172011-05-04 Juanma Barranquero <lekktu@gmail.com>
5718
5719 Implement dynamic loading of GnuTLS on Windows.
5720
5721 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5722 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5723 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5724 Declare.
5725
5726 * gnutls.c (Qgnutls_dll): Define.
5727 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5728 (gnutls_*): Declare function pointers.
5729 (init_gnutls_functions): New function to initialize function pointers.
5730 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5731 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5732 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5733 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5734 (emacs_gnutls_write, emacs_gnutls_read)
5735 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5736 (Fgnutls_available_p): New function.
5737 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5738 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5739 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5740
5741 * image.c: Include w32.h.
5742 (Vimage_type_cache): Delete.
5743 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5744 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5745 (w32_delayed_load): Move to w32.c.
5746
5747 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5748
5749 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5750 (w32_delayed_load): Move from image.c. When loading a library, record
5751 its filename in the :loaded-from property of the library id.
5752 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5753 Initialize and staticpro them.
5754 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5755
5756 * process.c: Include lisp.h before w32.h, not after.
5757 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5758 instead of gnutls_record_check_pending.
5759
5760 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5761
ff4de4aa
TZ
57622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5763
5764 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5765 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5766 as passed in.
5767
abe95abb
JD
57682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5769
5770 * xterm.c (x_set_frame_alpha): Do not set property on anything
5771 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5772
e16e55d4
JB
57732011-05-02 Juanma Barranquero <lekktu@gmail.com>
5774
5775 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5776
bafcf6a5
JB
57772011-05-02 Juanma Barranquero <lekktu@gmail.com>
5778
5779 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5780 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5781 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5782 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5783 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5784 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5785 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5786 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5787 (Qgnutls_bootprop_callbacks_verify): Make static.
5788
e7a6747f
AS
57892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5790
19ed11ba
AS
5791 * callproc.c: Indentation fixup.
5792
e7a6747f 5793 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5794 (wait_for_termination, interruptible_wait_for_termination):
5795 Move after wait_for_termination_1.
e7a6747f 5796
1ef14cb4
LMI
57972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5798
5799 * sysdep.c (interruptible_wait_for_termination): New function
5800 which is like wait_for_termination, but allows keyboard
5801 interruptions.
5802
5803 * callproc.c (Fcall_process): Add (:file "file") as an option for
5804 the STDOUT buffer.
5805 (Fcall_process_region): Ditto.
5806
330d880c
EZ
58072011-04-30 Eli Zaretskii <eliz@gnu.org>
5808
8db90b73
EZ
5809 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5810 rather than `XVECTOR (FOO)->size'.
5811
330d880c
EZ
5812 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5813 inttypes.h, as a gnulib replacement is used if it not available in
5814 system headers.
5815
15cbd324
EZ
58162011-04-21 Eli Zaretskii <eliz@gnu.org>
5817
5818 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5819 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5820 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5821
5822 * coding.c (coding_alloc_by_realloc): Error out if destination
5823 will grow beyond MOST_POSITIVE_FIXNUM.
5824 (decode_coding_emacs_mule): Abort if there isn't enough place in
5825 charbuf for the composition carryover bytes. Reserve an extra
5826 space for up to 2 characters produced in a loop.
5827 (decode_coding_iso_2022): Abort if there isn't enough place in
5828 charbuf for the composition carryover bytes.
5829
58302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5831
ae940cca
EZ
5832 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5833 aborting when %lld or %lll format is passed.
5834 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5835 %llo or %llx format is passed. (Bug#8545)
5836
03ab8921
EZ
5837 * window.c (window_scroll_line_based): Use a marker instead of
5838 simple variables to record original value of point. (Bug#7952)
5839
afda1437
EZ
5840 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5841 produced by %s or %c overflows available buffer space. (Bug#8545)
5842
f76dee0c
PE
58432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5844
5845 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5846 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5847
fdc5744d
JB
58482011-04-28 Juanma Barranquero <lekktu@gmail.com>
5849
5850 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5851
638f053a
JB
58522011-04-28 Juanma Barranquero <lekktu@gmail.com>
5853
5854 * keyboard.c (Qdelayed_warnings_hook): Define.
5855 (command_loop_1): Run `delayed-warnings-hook'
5856 if Vdelayed_warnings_list is non-nil.
5857 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5858 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5859
d178f871
EZ
58602011-04-28 Eli Zaretskii <eliz@gnu.org>
5861
5862 * doprnt.c (doprnt): Don't return value smaller than the buffer
5863 size if the message was truncated. (Bug#8545).
5864
b124fd93
JB
58652011-04-28 Juanma Barranquero <lekktu@gmail.com>
5866
5867 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5868 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5869
e810457d
PE
58702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5871
5872 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5873
ea51cceb
JB
58742011-04-27 Juanma Barranquero <lekktu@gmail.com>
5875
5876 * makefile.w32-in: Update dependencies.
5877
94dcfacf
EZ
58782011-04-27 Eli Zaretskii <eliz@gnu.org>
5879
5880 Improve `doprnt' and its usage. (Bug#8545)
5881 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5882 `format_end'. Remove support for %l as a conversion specifier.
5883 Don't use xrealloc. Improve diagnostics when the %l size modifier
5884 is used. Update the commentary.
5885
5886 * eval.c (verror): Simplify calculation of size_t.
5887
5888 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5889 messages.
5890
f61f41d7
PE
58912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5892
5893 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5894 change.
5895
96fb4434
PE
58962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5897
5898 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5899 This makes this file independent of the recent pseudovector change.
5900
671875da 59012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5902
69e9b5a3
PE
5903 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5904
b5f869a7 5905 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5906 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5907 Remove unused local.
c8926152 5908 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5909
841a1577 5910 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5911 GCC 4.6.0 optimizes based on type-based alias analysis.
5912 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5913 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5914 != &v->size, and therefore "v->size = 1; b->size = 2; return
5915 v->size;" must therefore return 1. This assumption is incorrect
5916 for Emacs, since it type-puns struct Lisp_Vector * with many other
5917 types. To fix this problem, this patch adds a new type struct
f904488f 5918 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5919 and pseudovectors, and helps optimizing compilers not get fooled
5920 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5921 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5922 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5923 the size member.
eab3844f
PE
5924 (XSETPVECTYPE): Rewrite in terms of new macro.
5925 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5926 This is a bit clearer, and further avoids the possibility of
5927 undesirable aliasing.
5928 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5929 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5930 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5931 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5932 (ASIZE): Now uses header.size rather than size.
5933 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5934 to avoid the hassle of writing XVECTOR (foo)->header.size.
5935 (struct vectorlike_header): New type.
eab3844f
PE
5936 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5937 object, to help avoid aliasing.
5938 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5939 (SUBRP): Likewise, since Lisp_Subr is a special case.
5940 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5941 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5942 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5943 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5944 changed to be "header.size" and "header.next".
5945 * buffer.h (struct buffer): Likewise.
5946 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5947 * frame.h (struct frame): Likewise.
5948 * process.h (struct Lisp_Process): Likewise.
5949 * termhooks.h (struct terminal): Likewise.
5950 * window.c (struct save_window_data, struct saved_window): Likewise.
5951 * window.h (struct window): Likewise.
5952 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5953 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5954 * buffer.c (init_buffer_once): Likewise.
5955 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5956 special case.
5957 * process.c (Fformat_network_address): Use local var for size,
5958 for brevity.
5959
0df1eac5
PE
5960 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5961
847ab9d1 5962 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5963 * data.c (atof): Remove decl; no longer used or needed.
5964 (digit_to_number): Move to lread.c.
5965 (Fstring_to_number): Use new string_to_number function, to be
5966 consistent with how the Lisp reader treats infinities and NaNs.
5967 Do not assume that floating-point numbers represent EMACS_INT
5968 without losing information; this is not true on most 64-bit hosts.
5969 Avoid double-rounding errors, by insisting on integers when
5970 parsing non-base-10 numbers, as the documentation specifies.
5971 * lisp.h (string_to_number): New decl, replacing ...
5972 (isfloat_string): Remove.
bc0a5c13 5973 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5974 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5975 appears to have been a coding error. Similarly, do not accept
5976 strings like +-1e0 as floating point numbers. Do not report
5977 overflow for integer overflows unless the base is not 10 which
5978 means we have no simple and reliable way to continue.
5979 Break out the floating-point parsing into a new
5980 function string_to_number, so that Fstring_to_number parses
5981 floating point numbers consistently with the Lisp reader.
04f2d78b 5982 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5983 (E_CHAR, EXP_INT): Remove, replacing with ...
5984 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5985 (string_to_number): New function, replacing isfloat_string.
5986 This function checks for valid syntax and produces the resulting
5987 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5988 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5989 so that overflow for non-base-10 numbers is reported only when
5990 there's no portable and simple way to convert to floating point.
452f4150 5991
67769ffc
PE
5992 * textprop.c (set_text_properties_1): Rewrite for clarity,
5993 and to avoid GCC warning about integer overflow.
5994
c20db43f
PE
5995 * intervals.h (struct interval): Use EMACS_INT for members
5996 where EMACS_UINT might cause problems. See
5997 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5998 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5999 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6000 All uses changed.
37aa2f85
PE
6001 (offset_intervals): Tell GCC not to worry about length overflow
6002 when negating a negative length.
c20db43f 6003
2538aa2f
PE
6004 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6005 (overrun_check_free): Likewise.
6006
f2d3008d
PE
6007 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6008 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6009 word size.
6010
ec8df744
PE
6011 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6012 (gnutls_make_error): Rename local to avoid shadowing.
6013 (gnutls_emacs_global_deinit): ifdef out; not used.
6014 (Fgnutls_boot): Use const for pointer to readonly storage.
6015 Comment out unused local. Fix pointer signedness problems.
6016
640ee02d
PE
6017 * lread.c (openp): Don't stuff size_t into an 'int'.
6018 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6019 about possible signed overflow.
6020
6048fb2a
PE
6021 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6022 (GDK_KEY_g): Don't define if already defined.
6023 (xg_prepare_tooltip): Avoid pointer signedness problem.
6024 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6025
fa3c87e1
PE
6026 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6027 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6028
2172544b
PE
6029 * xfns.c (Fx_window_property): Simplify a bit,
6030 to make a bit faster and to avoid GCC 4.6.0 warning.
6031 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6032
9b821a21
PE
6033 * fns.c (internal_equal): Don't assume size_t fits in int.
6034
3c616cfa
PE
6035 * alloc.c (compact_small_strings): Tighten assertion a little.
6036
c2982e87
PE
6037 Replace pEd with more-general pI, and fix some printf arg casts.
6038 * lisp.h (pI): New macro, generalizing old pEd macro to other
6039 conversion specifiers. For example, use "...%"pI"d..." rather
6040 than "...%"pEd"...".
6041 (pEd): Remove. All uses replaced with similar uses of pI.
6042 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6043 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6044 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6045 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6046 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6047 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6048 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6049 64-bit hosts.
6050 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6051 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6052 * print.c (safe_debug_print, print_object): Likewise.
6053 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6054 to int.
6f04d126
PE
6055 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6056 avoiding the 0 flag, which is not portable.
c2982e87
PE
6057 * process.c (Fmake_network_process): Use pI to avoid cast.
6058 * region-cache.c (pp_cache): Likewise.
6059 * xdisp.c (decode_mode_spec): Likewise.
6060 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6061 behavior on 64-bit hosts with printf arg.
6f04d126 6062 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6063 (x_stop_queuing_selection_requests): Likewise.
6064 (x_get_window_property): Don't truncate byte count to an 'int'
6065 when tracing.
0b432f21 6066
5e073ec7
PE
6067 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6068 here, since it parses constructs like leading '-' and spaces,
6069 which are not wanted; and it overflows with large numbers.
6070 Instead, simply match F[0-9]+, which is what is wanted anyway.
6071
36372bf9
PE
6072 * alloc.c: Remove unportable assumptions about struct layout.
6073 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6074 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6075 (allocate_vectorlike, make_pure_vector): Use the new macros,
6076 plus offsetof, to remove unportable assumptions about struct layout.
6077 These assumptions hold on all porting targets that I know of, but
6078 they are not guaranteed, they're easy to remove, and removing them
6079 makes further changes easier.
6080
0b432f21
PE
6081 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6082 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6083 (string_overrun_cookie): Now const. Use initializers that
6084 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6085 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6086 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6087 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6088 multiple of sizeof (EMACS_INT); it need not be, if
6089 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6090 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6091
895009e1
JB
60922011-04-26 Juanma Barranquero <lekktu@gmail.com>
6093
6094 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6095
6a7a1b0b
TZ
60962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6097
6098 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6099 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6100 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6101
841a1577 61022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6103
6104 * lisp.h (Qdebug): List symbol.
895009e1 6105 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6106 * keyboard.c (debug-on-event): New variable.
6107 (handle_user_signal): Break into debugger when debug-on-event
6108 matches the current signal symbol.
6109
f2d3ba6f
DN
61102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6111
6112 * alloc.c (check_sblock, check_string_bytes)
6113 (check_string_free_list): Convert to standard C.
6114
42ce4c63
TZ
61152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6116
6117 * w32.c (emacs_gnutls_push): Fix typo.
6118
825cd63c
EZ
61192011-04-25 Eli Zaretskii <eliz@gnu.org>
6120
fb11d64d
EZ
6121 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6122 "cast to pointer from integer of different size".
6123
825cd63c
EZ
6124 Improve doprnt and its use in verror. (Bug#8545)
6125 * doprnt.c (doprnt): Document the set of format control sequences
6126 supported by the function. Use SAFE_ALLOCA instead of always
6127 using `alloca'.
6128
6129 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6130 is one byte too soon. Don't use xrealloc; instead xfree and
6131 xmalloc anew.
6132
e061a11b
TZ
61332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6134
6135 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6136 callbacks stage.
6137
6138 * gnutls.c: Renamed global_initialized to
6139 gnutls_global_initialized. Added internals for the
6140 :verify-hostname-error, :verify-error, and :verify-flags
6141 parameters of `gnutls-boot' and documented those parameters in the
6142 docstring. Start callback support.
9173deec
JB
6143 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6144 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6145 on error. Return error code.
e061a11b
TZ
6146 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6147 (emacs_gnutls_read): Likewise.
6148 (Fgnutls_boot): Return handshake error code.
6149 (emacs_gnutls_handle_error): New function.
6150 (wsaerror_to_errno): Likewise.
6151
6152 * w32.h (emacs_gnutls_pull): Add prototype.
6153 (emacs_gnutls_push): Likewise.
6154
6155 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6156 (emacs_gnutls_push): Likewise.
6157
61582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6159
6160 * process.c (wait_reading_process_output): Check if GnuTLS
6161 buffered some data internally if no FDs are set for TLS
6162 connections.
6163
6164 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6165 (LIBS): Link to USER_LIBS.
6166 ($(BLD)/gnutls.$(0)): New target.
6167
fa6996bc
EZ
61682011-04-24 Eli Zaretskii <eliz@gnu.org>
6169
eb35682e
EZ
6170 * xdisp.c (handle_single_display_spec): Rename the
6171 display_replaced_before_p argument into display_replaced_p, to
6172 make it consistent with the commentary. Fix typos in the
6173 commentary.
6174
e2ad650c
EZ
6175 * textprop.c (syms_of_textprop): Remove dead code.
6176 (copy_text_properties): Delete obsolete commentary about an
6177 interface that was deleted long ago. Fix typos in the description
6178 of arguments.
6179
1b2de274
EZ
6180 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6181 to changes in oldXMenu/XMenu.h from 2011-04-16.
6182 <menu_help_message, prev_menu_help_message>: Constify.
6183 (IT_menu_make_room): menu->help_text is now `const char **';
6184 adjust.
6185
6186 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6187 to changes in oldXMenu/XMenu.h from 2011-04-16.
6188 (struct XMenu): Declare `help_text' `const char **'.
6189
6190 * xfaces.c <Qunspecified>: Make extern again.
6191
6192 * syntax.c: Include sys/types.h before including regex.h, as
6193 required by Posix.
6194
762b15be
EZ
6195 * doc.c (get_doc_string): Improve the format passed to `error'.
6196
6197 * doprnt.c (doprnt): Improve commentary.
6198
6199 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6200
6201 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6202 them with etags.
6203
f1052e5d
EZ
6204 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6205 changes in globals.h immediately force recompilation.
762b15be
EZ
6206 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6207 $(CURDIR)/s/ms-w32.h.
6208 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6209
fa6996bc
EZ
6210 * character.c (Fchar_direction): Function deleted.
6211 (syms_of_character): Don't defsubr it.
6212 <char-direction-table>: Deleted.
6213
e6c3da20
EZ
62142011-04-23 Eli Zaretskii <eliz@gnu.org>
6215
6216 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6217 * doprnt.c: Include limits.h.
6218 (SIZE_MAX): New macro.
04f2d78b
CB
6219 (doprnt): Return a size_t value. 2nd arg is now size_t.
6220 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6221 Improve overflow protection. Support `l' modifier for integer
6222 conversions. Support %l conversion. Don't assume an EMACS_INT
6223 argument for integer conversions and for %c.
6224
6225 * lisp.h (doprnt): Restore prototype.
6226
6227 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6228 $(SRC)/character.h.
6229
6230 * Makefile.in (base_obj): Add back doprnt.o.
6231
6232 * deps.mk (doprnt.o): Add back prerequisites.
6233 (callint.o): Depend on character.h.
6234
6235 * eval.c (internal_lisp_condition_case): Include the handler
6236 representation in the error message.
6237 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6238 when breaking from the loop.
6239
6240 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6241
6242 * callint.c (Fcall_interactively): When displaying error message
6243 about invalid control letter, pass the character's codepoint, not
6244 a pointer to its multibyte form. Improve display of the character
6245 in octal and display also its hex code.
6246
6247 * character.c (char_string): Use %x to display the (unsigned)
6248 codepoint of an invalid character, to avoid displaying a bogus
6249 negative value.
6250
6251 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6252 `error', not SYMBOL_NAME itself.
6253
6254 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6255 character arguments to `error'.
6256
6257 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6258 to `error' in error message about FINAL_CHAR argument. Make sure
6259 FINAL_CHAR is a character, and use %c when it is passed as
6260 argument to `error'.
6261
4ffd0d6b 62622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6263
6264 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6265
6266 * w32.c: Include <time.h>.
6267 (sys_localtime): New function.
6268
4ffd0d6b 62692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6270
6271 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6272
4ffd0d6b 6273 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6274
4ffd0d6b 62752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6276
4ffd0d6b
GM
6277 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6278 zombies (Bug#8467).
aac0c6e3 6279
04c56954
EZ
62802011-04-19 Eli Zaretskii <eliz@gnu.org>
6281
6282 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6283 gl_state.e_property when gl_state.object is Qt.
6284
6285 * insdel.c (make_gap_larger): Remove limitation of buffer size
6286 to <= INT_MAX.
6287
16a43933
CY
62882011-04-18 Chong Yidong <cyd@stupidchicken.com>
6289
6290 * xdisp.c (lookup_glyphless_char_display)
6291 (produce_glyphless_glyph): Handle cons cell entry in
6292 glyphless-char-display.
6293 (Vglyphless_char_display): Document it.
6294
6295 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6296 glyphless-char-display.
6297
4581706e
CY
62982011-04-17 Chong Yidong <cyd@stupidchicken.com>
6299
6300 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6301
6302 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6303
6304 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6305 definition for no-X builds.
6306
4887c6e2 63072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6308
fd35b6f9
PE
6309 Static checks with GCC 4.6.0 and non-default toolkits.
6310
5c1ccb01
PE
6311 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6312
006c5daa
PE
6313 * process.c (keyboard_bit_set): Define only if SIGIO.
6314 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6315 (send_process): Repair possible setjmp clobbering.
6316
efc736d3
PE
6317 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6318
4e2fe2e6
PE
6319 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6320
f97334a2
PE
6321 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6322
4e75f29d
PE
6323 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6324 Define only if needed.
6325
90efadd1
PE
6326 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6327 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6328 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6329
3c647824
PE
6330 * dispextern.h (struct redisplay_interface): Rename param
6331 to avoid shadowing.
e264f262 6332 * termhooks.h (struct terminal): Likewise.
761383f4 6333 * xterm.c (xembed_send_message): Likewise.
3c647824 6334
b58c5c4a
PE
6335 * insdel.c (make_gap_smaller): Define only if
6336 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6337
cad59032
PE
6338 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6339 it.
6340
c339dc2e
PE
6341 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6342 so that we aren't warned about unused symbols.
6343
91a3e27b
PE
6344 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6345
399c71d3 6346 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6347
8ffc96f5
PE
6348 * xfns.c (x_real_positions): Mark locals as initialized.
6349
eef9bc79
PE
6350 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6351
098db9dd
PE
6352 * xterm.c: Fix problems found by static analysis with other toolkits.
6353 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6354 (x_dispatch_event): Declare static if USE_GTK, and
6355 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6356 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6357 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6358 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6359 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6360
eb18f6cc
PE
6361 * xmenu.c (menu_help_callback): Pointer type fixes.
6362 Use const pointers when pointing at readonly data. Avoid pointer
6363 signedness clashes.
6364 (FALSE): Remove unused macro.
6365 (update_frame_menubar): Remove unused decl.
6366
1fe72bf8
PE
6367 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6368
60d9e1db
PE
6369 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6370 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6371 (single_menu_item): Rename local to avoid shadowing.
6372
39261c26
PE
6373 * keyboard.c (make_lispy_event): Remove unused local var.
6374
018c5e19
PE
6375 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6376 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6377
63d2b86e
PE
6378 * bitmaps: Change bitmaps from unsigned char back to the X11
6379 compatible char. Avoid the old compiler warnings about
6380 out-of-range initializers by using, for example, '\xab' rather
6381 than 0xab.
6382
aefd87e1
PE
6383 * xgselect.c (xgselect_initialize): Check vs interface
6384 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6385
bf501fb9
PE
6386 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6387
e9829fdf
PE
6388 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6389 to read-only memory.
6390
1086c095
PE
6391 * fns.c (vector): Remove; this old hack is no longer needed.
6392
2baccd04 6393 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6394 Remove unused var.
dde42981 6395 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6396
72391843 6397 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6398
436c16df 6399 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6400 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6401 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6402
92bb796d 6403 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6404 (x_term_init): Remove local to avoid shadowing.
92bb796d 6405
764430a3 6406 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6407
6408 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6409 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6410
d1dfb56c
EZ
64112011-04-16 Eli Zaretskii <eliz@gnu.org>
6412
c4354cb4
EZ
6413 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6414
d1dfb56c
EZ
6415 Fix regex.c, syntax.c and friends for buffers > 2GB.
6416 * syntax.h (struct gl_state_s): Declare character position members
6417 EMACS_INT.
6418
6419 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6420
04f2d78b
CB
6421 * textprop.c (verify_interval_modification, interval_of):
6422 Declare arguments EMACS_INT.
d1dfb56c
EZ
6423
6424 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6425 EMACS_INT.
6426
6427 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6428
6429 * indent.c (Fvertical_motion): Local variable it_start is now
6430 EMACS_INT.
6431
6432 * regex.c (re_match, re_match_2, re_match_2_internal)
6433 (bcmp_translate, regcomp, regexec, print_double_string)
6434 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6435 (re_compile_pattern, re_exec): Declare arguments and local
6436 variables `size_t' and `ssize_t' and return values `regoff_t', as
6437 appropriate.
6438 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6439 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6440 <compile_stack_type>: `size' and `avail' are now `size_t'.
6441
6442 * regex.h <regoff_t>: Use ssize_t, not int.
6443 (re_search, re_search_2, re_match, re_match_2): Arguments that
6444 specify buffer/string position and length are now ssize_t and
6445 size_t. Return type is regoff_t.
6446
613052cd
BK
64472011-04-16 Ben Key <bkey76@gmail.com>
6448
6449 * nsfont.m: Fixed bugs in ns_get_family and
6450 ns_descriptor_to_entity that were caused by using free to
6451 deallocate memory blocks that were allocated by xmalloc (via
6452 xstrdup). This caused Emacs to crash when compiled with
6453 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6454 --enable-checking=xmallocoverrun). xfree is now used to
6455 deallocate these memory blocks.
6456
4170f62f 64572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6458
71b41406
PE
6459 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6460
9587a89d
PE
6461 emacs_write: Accept and return EMACS_INT for sizes.
6462 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6463 et seq.
6464 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6465 Accept and return EMACS_INT.
6466 (emacs_gnutls_write): Return the number of bytes written on
6467 partial writes.
6468 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6469 (emacs_read, emacs_write): Remove check for negative size, as the
6470 Emacs source code has been audited now.
9587a89d
PE
6471 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6472 (emacs_read, emacs_write): Use it.
273a5f82
PE
6473 * process.c (send_process): Adjust to the new signatures of
6474 emacs_write and emacs_gnutls_write. Do not attempt to store
6475 a byte offset into an 'int'; it might overflow.
9587a89d 6476 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6477
3e047f51
PE
6478 * sound.c: Don't assume sizes fit in 'int'.
6479 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6480 Return EMACS_INT, not int.
3e047f51 6481 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6482 Accept EMACS_INT, not int.
6483 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6484 record read return values.
6485
cc39a9db
BK
64862011-04-15 Ben Key <bkey76@gmail.com>
6487
c9d0ec6d
JB
6488 * keyboard.c (Qundefined): Don't declare static since it is used
6489 in nsfns.m.
6490 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6491 static since they are used in nsfont.m.
cc39a9db 6492
6c60eb9f
SM
64932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6494
6495 * process.c (Qprocessp): Don't declare static.
6496 * lisp.h (Qprocessp): Declare again.
6497
7990b61a
JB
64982011-04-15 Juanma Barranquero <lekktu@gmail.com>
6499
6500 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6501
5d4cb038
PE
65022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6503
8bd7b830 6504 Improve C-level modularity by making more things 'static'.
cd64ea1d 6505
e3b27b31
PE
6506 Don't publish debugger-only interfaces to other modules.
6507 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6508 (verify_bytepos, count_markers): Move decls to the only modules
6509 that need them.
6510 * region-cache.h (pp_cache): Likewise.
6511 * window.h (check_all_windows): Likewise.
6512 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6513
5d4cb038
PE
6514 * sysdep.c (croak): Now static, if
6515 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6516 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6517
6518 * alloc.c (refill_memory_reserve): Now static if
6519 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6520 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6521
e87b6180
PE
6522 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6523 Define only if USE_LUCID.
6524
ac64929e
PE
6525 * xrdb.c (x_customization_string, x_rm_string): Now static.
6526
6f37259d
PE
6527 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6528 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6529
1683e3ab
PE
6530 * xdisp.c (draw_row_with_mouse_face): Now static.
6531 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6532
de9c2632
PE
6533 * window.h (check_all_windows): Mark externally visible.
6534
2b96acb7
PE
6535 * window.c (window_deletion_count): Now static.
6536
6537 * undo.c: Make symbols static if they're not exported.
6538 (last_undo_buffer, last_boundary_position, pending_boundary):
6539 Now static.
6540
50436f33
PE
6541 * textprop.c (interval_insert_behind_hooks): Now static.
6542 (interval_insert_in_front_hooks): Likewise.
6543
64520e5c
PE
6544 * term.c: Make symbols static if they're not exported.
6545 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6546 (max_frame_lines, tty_set_terminal_modes):
6547 (tty_reset_terminal_modes, tty_turn_off_highlight):
6548 (get_tty_terminal): Now static.
6549 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6550 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6551 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6552 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6553 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6554
1fa53021
PE
6555 * sysdep.c: Make symbols static if they're not exported.
6556 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6557 Now static.
6558 (sigprocmask_set, full_mask): Remove; unused.
6559 (wait_debugging): Mark as visible.
6560 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6561 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6562
d4b43b22
PE
6563 * syntax.c (syntax_temp): Define only if !__GNUC__.
6564
b7c513d0
PE
6565 * sound.c (current_sound_device, current_sound): Now static.
6566
989b29ad
PE
6567 * search.c (searchbufs, searchbuf_head): Now static.
6568
13a55a78
PE
6569 * scroll.c (scroll_cost): Remove; unused.
6570 * dispextern.h (scroll_cost): Remove decl.
6571
de68a1fc
PE
6572 * region-cache.h (pp_cache): Mark as externally visible.
6573
40ccffa6
PE
6574 * process.c: Make symbols static if they're not exported.
6575 (process_tick, update_tick, create_process, chan_process):
6576 (Vprocess_alist, proc_buffered_char, datagram_access):
6577 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6578 (deactivate_process): Mark defn as static, as well as decl.
6579 * lisp.h (create_process): Remove decl.
6580 * process.h (chan_process, Vprocess_alist): Remove decls.
6581
ad64fc97
PE
6582 * print.c: Make symbols static if they're not exported.
6583 (print_depth, new_backquote_output, being_printed, print_buffer):
6584 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6585 (print_interval, print_number_index, initial_stderr_stream):
6586 Now static.
6587 * lisp.h (Fprinc): Remove decl.
6588 (debug_output_compilation_hack): Mark as externally visible.
6589
adddb265
PE
6590 * sysdep.c (croak): Move decl from here to syssignal.h.
6591 * syssignal.h (croak): Put it here, so the API can be checked when
6592 'croak' is called from dissociate_if_controlling_tty.
6593
1717ede2
PE
6594 * minibuf.c: Make symbols static if they're not exported.
6595 (minibuf_save_list, choose_minibuf_frame): Now static.
6596 * lisp.h (choose_minibuf_frame): Remove decl.
6597
fa5fb2bc
PE
6598 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6599
1e3890d1
PE
6600 * lread.c: Make symbols static if they're not exported.
6601 (read_objects, initial_obarray, oblookup_last_bucket_number):
6602 Now static.
6603 (make_symbol): Remove; unused.
6604 * lisp.h (initial_obarray, make_symbol): Remove decls.
6605
8a1414fa
PE
6606 * keyboard.c: Make symbols static if they're not exported.
6607 (single_kboard, recent_keys_index, total_keys, recent_keys):
6608 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6609 (this_single_command_key_start, echoing, last_auto_save):
6610 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6611 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6612 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6613 (Vlispy_mouse_stem, double_click_count):
6614 Now static.
6615 (force_auto_save_soon): Define only if SIGDANGER.
6616 (ignore_mouse_drag_p): Now static if
6617 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6618 (print_help): Remove; unused.
6619 (stop_character, last_timer_event): Mark as externally visible.
6620 * keyboard.h (ignore_mouse_drag_p): Declare only if
6621 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6622 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6623 * lisp.h (echoing): Remove decl.
6624 (force_auto_save_soon): Declare only if SIGDANGER.
6625 * xdisp.c (redisplay_window): Simplify code, to make it more
6626 obvious that ignore_mouse_drag_p is not accessed if !defined
6627 USE_GTK && !defined HAVE_NS.
6628
93ea6e8f
PE
6629 * intervals.c: Make symbols static if they're not exported.
6630 (merge_properties_sticky, merge_interval_right, delete_interval):
6631 Now static.
6632 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6633
77382fcc
PE
6634 * insdel.c: Make symbols static if they're not exported.
6635 However, leave prepare_to_modify_buffer alone. It's never
6636 called from outside this function, but that appears to be a bug.
6637 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6638 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6639 (adjust_after_replace_noundo): Remove; unused.
6640 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6641 (signal_before_change): Remove decls.
77382fcc 6642
9306c32e
PE
6643 * indent.c (val_compute_motion, val_vmotion): Now static.
6644
cd44d2eb
PE
6645 * image.c: Make symbols static if they're not exported.
6646 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6647 if USE_GTK.
6648 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6649 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6650
ad9a7a06
PE
6651 * fringe.c (standard_bitmaps): Now static.
6652 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6653
81626931
PE
6654 * frame.c: Make symbols static if they're not exported.
6655 (x_report_frame_params, make_terminal_frame): Now static.
6656 (get_frame_param): Now static, unless HAVE_NS.
6657 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6658 (x_get_resource_string): Remove; not used.
6659 * frame.h (make_terminal_frame, x_report_frame_params):
6660 (x_get_resource_string); Remove decls.
6661 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6662 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6663
239f9db9
PE
6664 * font.c, fontset.c: Make symbols static if they're not exported.
6665 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6666 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6667 * font.c (font_close_object): Now static.
6668 * font.h (font_close_object): Remove.
6669 * fontset.c (FONTSET_OBJLIST): Remove.
6670 (free_realized_fontset) #if-0 the body, which does nothing.
6671 (face_suitable_for_char_p): #if-0, as it's never called.
6672 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6673 * xfaces.c (face_at_string_position):
6674 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6675 since 0 is always ASCII.
6676
dfcf3579
PE
6677 * fns.c (weak_hash_tables): Now static.
6678
5045092b
PE
6679 * fileio.c: Make symbols static if they're not exported.
6680 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6681 (Vwrite_region_annotation_buffers): Now static.
6682
57a96f5c
PE
6683 * eval.c: Make symbols static if they're not exported.
6684 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6685 * lisp.h (backtrace_list): Remove decl.
6686
35f08c38
PE
6687 * emacs.c: Make symbols static if they're not exported.
6688 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6689 (fatal_error_code, fatal_error_signal_hook, standard_args):
6690 Now static.
6691 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6692 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6693 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6694 * lisp.h (fatal_error_signal_hook): Remove decl.
6695 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6696
f44bd759
PE
6697 * editfns.c: Move a (normally-unused) function to its only use.
6698 * editfns.c, lisp.h (get_operating_system_release): Remove.
6699 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6700 worth the hassle of breaking this out.
6701
b532497d
PE
6702 * xterm.c: Make symbols static if they're not exported.
6703 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6704 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6705 (x_destroy_window, x_delete_display):
6706 Now static.
6707 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6708 (x_mouse_leave): Remove; unused.
6709 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6710 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6711 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6712 Remove decls.
6713 (x_mouse_leave): Declare only if WINDOWSNT.
6714 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6715 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6716 USE_X_TOOLKIT.
6717
1675728f
PE
6718 * ftxfont.c: Make symbols static if they're not exported.
6719 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6720 HAVE_FREETYPE.
6721 * font.h (ftxfont_driver): Likewise.
6722
e4cebfca
PE
6723 * xfns.c: Make symbols static if they're not exported.
6724 (x_last_font_name, x_display_info_for_name):
6725 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6726 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6727 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6728 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6729 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6730 (last_show_tip_args): Now static.
6731 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6732 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6733 (x_screen_planes): Remove; unused.
6734 * dispextern.h (x_screen_planes): Remove decl.
6735
5bf46f05
PE
6736 * dispnew.c: Make symbols static if they're not exported.
6737 * dispextern.h (redraw_garbaged_frames, scrolling):
6738 (increment_row_positions): Remove.
6739 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6740 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6741 Now static.
6742 (redraw_garbaged_frames): Remove; unused.
6743
435f4c28
PE
6744 * xfaces.c: Make symbols static if they're not exported.
6745 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6746 Remove decls.
6747 * xterm.h (defined_color): Remove decls.
6748 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6749 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6750 (menu_face_changed_default, defined_color, free_realized_face):
6751 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6752 (ascii_face_of_lisp_face): Remove; unused.
6753
8524aef3
PE
6754 * xdisp.c: Make symbols static if they're not exported.
6755 * dispextern.h (scratch_glyph_row, window_box_edges):
6756 (glyph_to_pixel_coords, set_cursor_from_row):
6757 (get_next_display_element, set_iterator_to_next):
6758 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6759 (show_mouse_face): Remove decls
6760 * frame.h (message_buf_print): Likewise.
6761 * lisp.h (pop_message, set_message, check_point_in_composition):
6762 Likewise.
6763 * xterm.h (set_vertical_scroll_bar): Likewise.
6764 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6765 (message_buf_print, scratch_glyph_row, displayed_buffer):
6766 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6767 (get_next_display_element, show_mouse_face, window_box_edges):
6768 (frame_to_window_pixel_xy, check_point_in_composition):
6769 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6770 (glyph_to_pixel_coords): Remove; unused.
6771
16390cd2
PE
6772 * dired.c (file_name_completion): Now static.
6773
6774 * dbusbind.c (xd_in_read_queued_messages): Now static.
6775
a25f4dfa
PE
6776 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6777 * data.c (circular_list_error): Remove.
6778
14a9c8df
PE
6779 * commands.h (last_point_position, last_point_position_buffer):
6780 (last_point_position_window): Remove decls.
6781 * keyboard.c: Make these variables static.
6782
04f2d78b
CB
6783 * coding.h (coding, code_convert_region, encode_coding_gap):
6784 Remove decls.
74ab6df5
PE
6785 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6786 (iso_code_class, detect_coding, code_convert_region): Now static.
6787 (encode_coding_gap): Remove; unused.
6788
38dfbee1
PE
6789 * chartab.c (chartab_chars, chartab_bits): Now static.
6790
a2cb4e63
PE
6791 * charset.h (charset_iso_8859_1): Remove decl.
6792 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6793 Now static.
6794
127198fd
PE
6795 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6796 * ccl.c (Vccl_program_table): Now static.
6797 (check_ccl_update): Remove; unused.
6798
d85b608f
PE
6799 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6800 * category.h: ... from here.
6801 * category.c (check_category_table, set_category_set): Now static.
6802
31cd66f3
PE
6803 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6804 * lisp.h: Remove these decls.
6805
c358e587
PE
6806 * buffer.c (buffer_count): Remove unused var.
6807
e78aecca
PE
6808 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6809 so that it's not optimized away.
6810 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6811 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6812 exported only to the debugger.
6813
e192d7d3 6814 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6815 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6816
92470028
PE
6817 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6818 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6819 was inaccessible from Lisp.
6820 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6821 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6822
244ed907
PE
6823 alloc.c: Import and export fewer symbols, and remove unused items.
6824 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6825 is defined.
6826 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6827 it's not optimized away by whole-program optimization.
6828 (message_enable_multibyte, free_misc): Remove.
6829 (catchlist, handlerlist, mark_backtrace):
6830 Declare only if BYTE_MARK_STACK.
6831 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6832 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6833 (message_enable_multibyte): Remove decl.
6834 (free_misc, interval_free_list, float_block, float_block_index):
6835 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6836 (cons_free_list, last_marked_index):
6837 Now static.
6838 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6839 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6840 (mark_backtrace): Define only if BYTE_MARK_STACK.
6841 * xdisp.c (message_enable_multibyte): Now static.
6842
61c2b50e 6843 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6844 This makes it easier for human readers (and static analyzers)
6845 to see whether these variables are used from other modules.
6846 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6847 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6848 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6849 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6850 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6851 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6852 * xmenu.c, xselect.c:
6853 Declare Q* vars static if they are not used in other modules.
6854 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6855 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6856 Remove decls of unexported vars.
6857 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6858
95c82688
PE
6859 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6860
16a97296
PE
6861 Make Emacs functions such as Fatom 'static' by default.
6862 This makes it easier for human readers (and static analyzers)
6863 to see whether these functions can be called from other modules.
6864 DEFUN now defines a static function. To make the function external
6865 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6866 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6867 (Finit_image_library):
16a97296
PE
6868 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6869 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6870 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6871 Remove decls, since these functions are now static.
6872 (Funintern, Fget_internal_run_time): New decls, since these functions
6873 were already external.
95c82688 6874
16a97296
PE
6875 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6876 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6877 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6878 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6879 * keyboard.c, keymap.c, lread.c:
6880 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6881 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6882 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6883 Mark functions with DEFUE instead of DEFUN,
6884 if they are used in other modules.
6885 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6886 decls for now-static functions.
6887 * buffer.h (Fdelete_overlay): Remove decl.
6888 * callproc.c (Fgetenv_internal): Mark as internal.
6889 * composite.c (Fremove_list_of_text_properties): Remove decl.
6890 (Fcomposition_get_gstring): New forward static decl.
6891 * composite.h (Fcomposite_get_gstring): Remove decl.
6892 * dired.c (Ffile_attributes): New forward static decl.
6893 * doc.c (Fdocumntation_property): New forward static decl.
6894 * eval.c (Ffetch_bytecode): New forward static decl.
6895 (Funintern): Remove extern decl; now in .h file where it belongs.
6896 * fileio.c (Fmake_symbolic_link): New forward static decl.
6897 * image.c (Finit_image_library): New forward static decl.
6898 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6899 * intervals.h (Fprevious_property_change):
6900 (Fremove_list_of_text_properties): Remove decls.
6901 * keyboard.c (Fthis_command_keys): Remove decl.
6902 (Fcommand_execute): New forward static decl.
6903 * keymap.c (Flookup_key): New forward static decl.
6904 (Fcopy_keymap): Now static.
6905 * keymap.h (Flookup_key): Remove decl.
6906 * process.c (Fget_process): New forward static decl.
6907 (Fprocess_datagram_address): Mark as internal.
6908 * syntax.c (Fsyntax_table_p): New forward static decl.
6909 (skip_chars): Remove duplicate decl.
6910 * textprop.c (Fprevious_property_change): New forward static decl.
6911 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6912 Now internal.
6913 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6914 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6915
785bbd42
PE
6916 * editfns.c (Fformat): Remove unreachable code.
6917
8b913b57
AS
69182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6919
6920 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6921 change. (Bug#8496)
6922
a6744a35
EZ
69232011-04-13 Eli Zaretskii <eliz@gnu.org>
6924
6925 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6926 when at ZV. (Bug#8487)
6927
e7974947
AS
69282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6929
baad03f0
AS
6930 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6931 (Bug#8437)
6932 * keyboard.c (parse_tool_bar_item): Likewise.
6933 * sound.c (sound_cleanup, alsa_close): Likewise.
6934 * termcap.c (tgetent): Likewise.
6935 * xfns.c (x_default_font_parameter): Likewise.
6936 * xsettings.c (read_and_apply_settings): Likewise.
6937
e7974947
AS
6938 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6939 (overrun_check_free): Protoize.
6940
28272684
PE
69412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6942
6943 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6944 since callers should never pass a negative size.
6945 Change the signature to match that of plain 'read' and 'write'; see
6946 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6947 * lisp.h: Update prototypes of emacs_write and emacs_read.
6948
11997c76
EZ
69492011-04-11 Eli Zaretskii <eliz@gnu.org>
6950
6951 * xdisp.c (redisplay_window): Don't try to determine the character
6952 position of the scroll margin if the window start point w->startp
e896f03c 6953 is outside the buffer's accessible region. (Bug#8468)
11997c76 6954
8a2cbd72
EZ
69552011-04-10 Eli Zaretskii <eliz@gnu.org>
6956
6957 Fix write-region and its subroutines for buffers > 2GB.
6958 * fileio.c (a_write, e_write): Modify declaration of arguments and
6959 local variables to support buffers larger than 2GB.
6960 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6961
6962 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6963 argument, local variables, and return value.
6964
6965 * lisp.h: Update prototypes of emacs_write and emacs_read.
6966
6967 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6968
4073e537 69692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6970
1ebfdcb6
PE
6971 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6972
b2ded58d
PE
6973 Fix more problems found by GCC 4.6.0's static checks.
6974
7d66342c
PE
6975 * xdisp.c (vmessage): Use a better test for character truncation.
6976
bbf47d44
PE
6977 * charset.c (load_charset_map): <, not <=, for optimization,
6978 and to avoid potential problems with integer overflow.
9248994d 6979 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6980 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6981 * editfns.c (Fformat): Likewise.
1e69125e 6982 * syntax.c (skip_chars): Likewise.
3befa583 6983
e3019616
PE
6984 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6985 This also lets GCC 4.6.0 generate slightly better loop code.
6986
becfa255
PE
6987 * callint.c (Fcall_interactively): <, not <=, for optimization.
6988 (Fcall_interactively): Count the number of arguments produced,
6989 not the number of arguments given. This is simpler and lets GCC
6990 4.6.0 generate slightly better code.
6991
dae0cd48
PE
6992 * ftfont.c: Distingish more carefully between FcChar8 and char.
6993 The previous code passed unsigned char * to a functions like
6994 strlen and xstrcasecmp that expect char *, which does not
6995 conform to the C standard.
6996 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6997 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6998 char * when the C standard requires it.
6999
76032d70
PE
7000 * keyboard.c (read_char): Remove unused var.
7001
eb3f1cc8
PE
7002 * eval.c: Port to Windows vsnprintf (Bug#8435).
7003 Include <limits.h>.
7004 (SIZE_MAX): Define if the headers do not.
7005 (verror): Do not give up if vsnprintf returns a negative count.
7006 Instead, grow the buffer. This ports to Windows vsnprintf, which
7007 does not conform to C99. Problem reported by Eli Zaretskii.
7008 Also, simplify the allocation scheme, by avoiding the need for
7009 calling realloc, and removing the ALLOCATED variable.
7010
70476b54
PE
7011 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7012
12020a9e
PE
7013 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7014 But keep the doprint source code for now, as we might revamp it
7015 and use it again (Bug#8435).
ea6c7ae6
PE
7016 * lisp.h (doprnt): Remove.
7017 * Makefile.in (base_obj): Remove doprnt.o.
7018 * deps.mk (doprnt.o): Remove.
7019
5fdb398c
PE
7020 error: Print 32- and 64-bit integers portably (Bug#8435).
7021 Without this change, on typical 64-bit hosts error ("...%d...", N)
7022 was used to print both 32- and 64-bit integers N, which relied on
7023 undefined behavior.
7024 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7025 New macro.
7026 * lisp.h (error, verror): Mark as printf-like functions.
7027 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7028 Report overflow in size calculations when allocating printf buffer.
7029 Do not truncate output string at its first null byte.
7030 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7031 Truncate the output at a character boundary, since vsnprintf does not
7032 do that.
7033 * charset.c (check_iso_charset_parameter): Convert internal
7034 character to string before calling 'error', since %c now has the
7035 printf meaning.
7036 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7037 overflow when computing char to be passed to 'error'. Do not
7038 pass Lisp_Object to 'error'; pass the integer instead.
7039 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7040 formatted with plain %d.
7041
b189fa66
PE
7042 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7043
bff87ef0
PE
7044 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7045
7e2cac20
PE
7046 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7047
ce4d90b5
PE
7048 * xterm.c (x_catch_errors): Remove duplicate declaration.
7049
266c9547
PE
7050 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7051
79c49ad2
PE
7052 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7053
368f4090
JM
70542011-04-10 Jim Meyering <meyering@redhat.com>
7055
7056 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7057 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7058 return ssize_t not "int", and use size_t as the buffer length.
7059 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7060 * gnutls.h: Update declarations.
7061 * process.c (read_process_output): Use ssize_t, to match.
7062 (send_process): Likewise.
7063
a32d4040
CY
70642011-04-09 Chong Yidong <cyd@stupidchicken.com>
7065
7066 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7067
8546720e 70682011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7069
04f2d78b
CB
7070 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7071 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7072
8546720e
GM
7073 * xterm.c (handle_one_xevent):
7074 * xmenu.c (create_and_show_popup_menu):
7075 * xselect.c (x_decline_selection_request)
7076 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7077
0a2f5c1a 70782011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7079
7080 Fix some uses of `int' instead of EMACS_INT.
7081 * search.c (string_match_1, fast_string_match)
7082 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7083 (scan_buffer, find_next_newline_no_quit)
7084 (find_before_next_newline, search_command, Freplace_match)
7085 (Fmatch_data): Make some `int' variables be EMACS_INT.
7086
7087 * xdisp.c (display_count_lines): 3rd argument and return value now
7088 EMACS_INT. All callers changed.
7089 (pint2hrstr): Last argument is now EMACS_INT.
7090
7091 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7092 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7093 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7094 (decode_coding_utf_16, decode_coding_emacs_mule)
7095 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7096 (decode_coding_ccl, decode_coding_charset)
7097 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7098 (decode_coding_iso_2022, decode_coding_emacs_mule)
7099 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7100 <char_offset, last_offset>: Declare EMACS_INT.
7101 (encode_coding_utf_8, encode_coding_utf_16)
7102 (encode_coding_emacs_mule, encode_invocation_designation)
7103 (encode_designation_at_bol, encode_coding_iso_2022)
7104 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7105 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7106 Declare EMACS_INT.
7107 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7108 (encode_invocation_designation): Last argument P_NCHARS is now
7109 EMACS_INT.
7110 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7111 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7112
7113 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7114 All users changed.
7115
7116 * ccl.c (Fccl_execute_on_string): Declare some variables
7117 EMACS_INT.
7118
8546720e 71192011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7120
7121 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7122
4e19a977
CS
71232011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7124
7125 * process.c (Fformat_network_address): Doc fix.
7126
87302331
R
71272011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7128
ee7683eb 7129 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7130
cbb59342
CY
71312011-04-08 Chong Yidong <cyd@stupidchicken.com>
7132
7133 * keyboard.c (read_char): Call Lisp function help-form-show,
7134 instead of using internal_with_output_to_temp_buffer.
7135 (Qhelp_form_show): New var.
e0d38eeb 7136 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7137
7138 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7139
7140 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7141
e67a13ab
CY
71422011-04-06 Chong Yidong <cyd@stupidchicken.com>
7143
04f2d78b
CB
7144 * process.c (Flist_processes): Remove to Lisp.
7145 (list_processes_1): Delete.
e67a13ab 7146
973f782d
EZ
71472011-04-06 Eli Zaretskii <eliz@gnu.org>
7148
7c106b1e
EZ
7149 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7150
973f782d
EZ
7151 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7152
41cf7d1a 71532011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7154
ca23cc88
PE
7155 Fix more problems found by GCC 4.6.0's static checks.
7156
f390e2d5
PE
7157 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7158
42eea0d0
PE
7159 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7160
b69769da 7161 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7162
f9541e84
PE
7163 * xdisp.c (vmessage): Mark as a printf-like function.
7164
13841b55
PE
7165 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7166
c136c10f
PE
7167 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7168
5e2d4a30
PE
7169 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7170 printf-like functions.
7171 (tiff_load): Add casts to remove these marks before passing them
7172 to system-supplied API.
7173
583f48b9
PE
7174 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7175
b25d760e
PE
7176 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7177 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7178 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7179 directly, rather than having caller test rule sign. This avoids
7180 some unnecessary tests.
7181 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7182 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7183 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7184
bc7b6697 7185 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7186 (xfont_open): Avoid unnecessary tests.
bc7b6697 7187
27ccc379
PE
7188 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7189
dcd5c89a
PE
7190 * composite.h, composite.c (composition_gstring_put_cache):
7191 Use EMACS_INT, not int, for length.
7192
b13a45c6
PE
7193 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7194 breaking out part of COMPOSITION_DECODE_RULE.
7195 (COMPOSITION_DECODE_RULE): Use it.
7196 * composite.c (get_composition_id): Remove unused local vars,
7197 by using the new macro.
7198
1e792e4d
PE
7199 * textprop.c (set_text_properties_1): Change while to do-while,
7200 since the condition is always true at first.
7201
dc6c6455 7202 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7203 (interval_deletion_adjustment): Return unsigned value.
7204 All uses changed.
dc6c6455 7205
aba7731a
PE
7206 * process.c (list_processes_1, create_pty, read_process_output):
7207 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7208 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7209 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7210 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7211 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7212
fdfc4bf3
PE
7213 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7214
fca8fe46 7215 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7216 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7217
06a0259a 7218 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7219 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7220 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7221
e7b9e80f
PE
7222 * print.c (print_error_message): Avoid int overflow.
7223
56201685
PE
7224 * font.c (font_list_entities): Redo for clarity,
7225 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7226
78834453 7227 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7228 (font_score): Avoid potential overflow in diff calculation.
78834453 7229
0bc0b309 7230 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7231 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7232
e610eaca
PE
7233 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7234
b895abce
PE
7235 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7236 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7237 can always succeed if overflow has undefined behavior.
7238
1f1d9321 7239 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7240 (wordify): Omit three unnecessary tests.
1f1d9321 7241
c59478bc
PE
7242 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7243 All callers changed. This avoids the need for an unused var.
7244
79b73827
PE
7245 * casefiddle.c (casify_region): Remove var that is set but not used.
7246
a4db5dfe
PE
7247 * dired.c (file_name_completion): Remove var that is set but not used.
7248
43aae36e
PE
7249 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7250
2a47c44d 7251 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7252 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7253
a37c69bf
PE
7254 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7255 Check for integer overflow on size calculations.
7256
328ab8e7
PE
7257 * buffer.c (Fprevious_overlay_change): Remove var that is set
7258 but not used.
7259
e5a2a5cb
PE
7260 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7261 Remove vars that are set but not used.
8d84a6eb 7262 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7263 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7264
a60e5f68
PE
7265 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7266
f661cb61 7267 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7268 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7269
f0397f5a
PE
7270 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7271 that are set but not used.
7272
8664db06 7273 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7274 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7275
6abdaa4a
PE
7276 * xselect.c (x_get_local_selection, x_handle_property_notify):
7277 Remove vars that are set but not used.
7278
0ce7538d 7279 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7280 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7281
9ae848fc
PE
7282 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7283 Remove var that is set but not used.
0b918413
PE
7284 (scroll_bar_windows_size): Now size_t, not int.
7285 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7286 Check for overflow.
9ae848fc 7287
a5a62657
PE
7288 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7289 (map_tty_color) [!defined MSDOS]: Likewise.
7290
5c5cdd39
PE
7291 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7292
66ebf983
PE
7293 * coding.c: Remove vars that are set but not used.
7294 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7295 All callers changed.
7296 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7297 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7298 (decode_coding_charset): Remove vars that are set but not used.
7299
1be4d761
PE
7300 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7301 that is set but not used.
7302
47553fa8
PE
7303 * print.c (print_object): Remove var that is set but not used.
7304
1f7196bf 7305 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7306 The gnulib version avoids calling malloc in the usual case,
7307 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7308 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7309 * filelock.c (current_lock_owner): Likewise.
7310 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7311 * sysdep.c: Include allocator.h, careadlinkat.h.
7312 (emacs_no_realloc_allocator): New static constant.
7313 (emacs_readlink): New function.
fdb61804
PE
7314 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7315 ../lib/careadlinkat.h.
d1fdcab7 7316
f84c17c7
SM
73172011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7318
7319 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7320 first non-nil return value).
7321
ef3862ad
JD
73222011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7323
7324 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7325 if not defined (Bug#8403).
7326
376a7006
JB
73272011-04-02 Juanma Barranquero <lekktu@gmail.com>
7328
7329 * xdisp.c (display_count_lines): Remove parameter `start',
7330 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7331 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7332 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7333 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7334 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7335 and thereabouts. All callers changed.
7336 (get_per_char_metric): Remove parameter `f', unused since
7337 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7338
6ca3801d
JM
73392011-04-02 Jim Meyering <meyering@redhat.com>
7340
7341 do not dereference NULL upon failed strdup
7342 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7343 (ns_get_family): Likewise.
7344
d8e2b5ba
JB
73452011-04-02 Juanma Barranquero <lekktu@gmail.com>
7346
7347 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7348
8c74fcbd
JD
73492011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7350
7351 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7352 later (Bug#8403).
7353
7200d79c
SM
73542011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7355
03408648 7356 Add lexical binding.
7200d79c 7357
03408648
SM
7358 * window.c (Ftemp_output_buffer_show): New fun.
7359 (Fsave_window_excursion):
7360 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7361
7362 * lread.c (lisp_file_lexically_bound_p): New function.
7363 (Fload): Bind Qlexical_binding.
7364 (readevalloop): Remove `evalfun' arg.
7365 Bind Qinternal_interpreter_environment.
7366 (Feval_buffer): Bind Qlexical_binding.
7367 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7368 Mark as dynamic.
7369 (syms_of_lread): Declare `lexical-binding'.
7370
7371 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7372
7373 * keyboard.c (eval_dyn): New fun.
7374 (menu_item_eval_property): Use it.
ca105506
SM
7375
7376 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7377
03408648
SM
7378 * fns.c (concat, mapcar1): Accept byte-code-functions.
7379
7380 * eval.c (Fsetq): Handle lexical vars.
7381 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7382 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7383 (FletX, Flet): Obey lexical binding.
7384 (Fcommandp): Handle closures.
7385 (Feval): New `lexical' arg.
7386 (eval_sub): New function extracted from Feval. Use it almost
7387 everywhere where Feval was used. Look up vars in lexical env.
7388 Handle closures.
7389 (Ffunctionp): Move from subr.el.
7390 (Ffuncall): Handle closures.
7391 (apply_lambda): Remove `eval_flags'.
7392 (funcall_lambda): Handle closures and new byte-code-functions.
7393 (Fspecial_variable_p): New function.
7394 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7395 but without exporting it to Lisp.
23aba0ea 7396
23aba0ea 7397 * doc.c (Fdocumentation, store_function_docstring):
03408648 7398 * data.c (Finteractive_form): Handle closures.
23aba0ea 7399
03408648
SM
7400 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7401 interactive spec.
ba83908c 7402
04f2d78b
CB
7403 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7404 New byte-codes.
03408648
SM
7405 (exec_byte_code): New function extracted from Fbyte_code to handle new
7406 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7407
03408648 7408 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7409
03408648 7410 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7411
e2abce01
JB
74122011-03-31 Juanma Barranquero <lekktu@gmail.com>
7413
7414 * xdisp.c (redisplay_internal): Fix prototype.
7415
63696a73 74162011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7417
63696a73 7418 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7419 (try_scrolling): Use it when setting scroll_limit.
7420 Limit scrolling to 100 screen lines.
63696a73
EZ
7421 (redisplay_window): Even when falling back on "recentering",
7422 position point in the window according to scroll-conservatively,
7423 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7424
7425 (try_scrolling): When point is above the window, allow searching
7426 as far as scroll_max, or one screenful, to compute vertical
7427 distance from PT to the scroll margin position. This prevents
7428 try_scrolling from unnecessarily failing when
7429 scroll-conservatively is set to a value slightly larger than the
7430 window height. Clean up the case of PT below the margin at bottom
7431 of window: scroll_max can no longer be INT_MAX. When aggressive
7432 scrolling is in use, don't let point enter the opposite scroll
7433 margin as result of the scroll.
7434 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7435 threshold of 100 lines for never-recentering scrolling.
7436
e4cc2dfc
JB
74372011-03-31 Juanma Barranquero <lekktu@gmail.com>
7438
7439 * dispextern.h (move_it_by_lines):
7440 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7441 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7442 (message_log_check_duplicate): Remove parameters `prev_bol' and
7443 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7444 (redisplay_internal): Remove parameter `preserve_echo_area',
7445 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7446
7447 * indent.c (Fvertical_motion):
7448 * window.c (window_scroll_pixel_based, Frecenter):
7449 Don't pass `need_y_p' to `move_it_by_lines'.
7450
1c470562
SM
74512011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7452
44f230aa
SM
7453 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7454 steal a few bits to be more compact.
7455 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7456 Remove unneeded casts.
7457
1c470562
SM
7458 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7459
888adce9
ZK
74602011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7461
7462 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7463 binding" message (bug#7967).
7464
f838ed7b
PE
74652011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7466
77861b95
PE
7467 Fix more problems found by GCC 4.6.0's static checks.
7468
de6dbc14
PE
7469 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7470 Remove unused local var.
7471
f838ed7b
PE
7472 * editfns.c (Fmessage_box): Remove unused local var.
7473
792c7b2b
PE
7474 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7475 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7476 Omit unused local vars.
c499e557 7477 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7478 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7479 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7480 Omit unused local var.
7481
ba0165e1
PE
7482 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7483 Don't assume string length fits in int.
32ad8845 7484 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7485 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7486
3c59b4c9
PE
7487 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7488 instead of alloca (Bug#8344).
7489
a3eed478 7490 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7491 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7492
eb4d412d
PE
7493 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7494
1658b401
PE
7495 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7496 concerns.
7497
7498 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7499
7500 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7501
9a2c6e05
PE
7502 * keyboard.c (syms_of_keyboard): Use the same style as later
7503 in this function when indexing through an array. This also
7504 works around GCC bug 48267.
7505
03d0a109
PE
7506 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7507
44f730c8
PE
7508 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7509
fe75f926
PE
7510 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7511 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7512
ffa8c828
PE
7513 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7514 This avoids undefined behavior on integer overflow, and is a bit
7515 more convenient anyway since it is compared to a size_t variable.
7516
c5101a77
PE
7517 Variadic C functions now count arguments with size_t, not int.
7518 This avoids an unnecessary limitation on 64-bit machines, which
7519 caused (substring ...) to crash on large vectors (Bug#8344).
7520 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7521 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7522 All variadic functions and their callers changed accordingly.
c5101a77
PE
7523 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7524 * data.c (arith_driver, float_arith_driver): Likewise.
7525 * editfns.c (general_insert_function): Likewise.
7526 * eval.c (struct backtrace.nargs, interactive_p)
7527 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7528 (funcall_lambda, mark_backtrace): Likewise.
7529 * fns.c (concat): Likewise.
7530 * frame.c (x_set_frame_parameters): Likewise.
7531 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7532 0 if not found, not -1. All callers changed.
7533
dd3f25f7
PE
7534 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7535 (stack_copy_size): Now size_t, not int.
7536 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7537
461c2ab9
JB
75382011-03-28 Juanma Barranquero <lekktu@gmail.com>
7539
7540 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7541 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7542 All callers changed.
7543
7544 * lisp.h (multibyte_char_to_unibyte):
7545 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7546 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7547 * character.h (CHAR_TO_BYTE8):
7548 * cmds.c (internal_self_insert):
7549 * editfns.c (general_insert_function):
7550 * keymap.c (push_key_description):
7551 * search.c (Freplace_match):
7552 * xdisp.c (message_dolog, set_message_1): All callers changed.
7553
f6d62986
SM
75542011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7555
7556 * keyboard.c (safe_run_hook_funcall): New function.
7557 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7558 don't set the hook to nil, but remove the offending function instead.
7559 (Qcommand_hook_internal): Remove, unused.
7560 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7561 Vcommand_hook_internal.
7562
7563 * eval.c (enum run_hooks_condition): Remove.
7564 (funcall_nil, funcall_not): New functions.
7565 (run_hook_with_args): Call each function through a `funcall' argument.
7566 Remove `cond' argument, now redundant.
7567 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7568 (Frun_hook_with_args_until_failure): Adjust accordingly.
7569 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7570
1db5b1ad
JB
75712011-03-28 Juanma Barranquero <lekktu@gmail.com>
7572
7573 * dispextern.h (string_buffer_position): Remove declaration.
7574
7575 * print.c (strout): Remove parameter `multibyte', unused since
7576 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7577
7578 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7579 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7580 All callers changed.
7581
7582 * w32.c (_wsa_errlist): Use braces for struct initializers.
7583
7584 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7585 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7586 All callers changed.
7587 (string_buffer_position): Likewise. Also, make static (it's never
7588 used outside xdisp.c).
7589 (cursor_row_p): Remove parameter `w', unused since
7590 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7591 (decode_mode_spec): Remove parameter `precision', introduced during
7592 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7593 All callers changed.
7594
5ffb62aa
JD
75952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7596
7597 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7598
461c2ab9 75992011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7600
7601 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7602 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7603 (ns_update_auto_hide_menu_bar): New functions.
7604 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7605 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7606 ns_constrain_all_frames.
7607 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7608 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7609
5c380ffb
JD
76102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7611
7612 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7613
9af30bdf
GM
76142011-03-27 Glenn Morris <rgm@gnu.org>
7615
7616 * syssignal.h: Replace RETSIGTYPE with void.
7617 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7618 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7619 Replace SIGTYPE with void everywhere.
7620 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7621 * s/template.h (SIGTYPE): Remove commented out definition.
7622
e2abce01
JB
76232011-03-26 Eli Zaretskii <eliz@gnu.org>
7624
7625 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7626 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7627
f868cd8a
JB
76282011-03-26 Juanma Barranquero <lekktu@gmail.com>
7629
59eb0929
JB
7630 * w32.c (read_unc_volume): Use parameter `henum', instead of
7631 global variable `wget_enum_handle'.
7632
7633 * keymap.c (describe_vector): Remove parameters `indices' and
7634 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7635 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7636
f868cd8a
JB
7637 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7638
7639 * keyboard.c (timer_check): Remove parameter `do_it_now',
7640 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7641 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7642 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7643
7644 * keyboard.c (read_char):
7645 * w32menu.c (w32_menu_display_help):
7646 * xmenu.c (show_help_event, menu_help_callback):
7647 Adjust calls to `show_help_echo'.
7648
7649 * gtkutil.c (xg_maybe_add_timer):
7650 * keyboard.c (readable_events):
7651 * process.c (wait_reading_process_output):
7652 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7653
7654 * insdel.c (adjust_markers_gap_motion):
7655 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7656 (gap_left, gap_right): Don't call it.
7657
2ecf6fdb
CY
76582011-03-25 Chong Yidong <cyd@stupidchicken.com>
7659
7660 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7661 incurred during fontification.
7662
6b1f9ba4
JB
76632011-03-25 Juanma Barranquero <lekktu@gmail.com>
7664
7665 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7666 (DEFVAR_PER_BUFFER): Don't pass it.
7667
7668 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7669 (scrolling_window): Don't pass it.
7670
0f4a96b5
JB
76712011-03-25 Juanma Barranquero <lekktu@gmail.com>
7672
7673 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7674
7675 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7676 and `suffix'.
7677 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7678 of variables specific to SELinux and computation of `encoded_absname'.
7679
7680 * image.c (XPutPixel): Remove unused variable `height'.
7681
7682 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7683
7684 * unexw32.c (get_section_info): Remove unused variable `section'.
7685
7686 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7687 (system_process_attributes): Remove unused variable `sess'.
7688 (sys_read): Remove unused variable `err'.
7689
7690 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7691 (w32_wnd_proc): Remove unused variable `isdead'.
7692 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7693 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7694 (x_create_tip_frame): Remove unused variable `tem'.
7695
7696 * w32inevt.c (w32_console_read_socket):
7697 Remove unused variable `no_events'.
7698
7699 * w32term.c (x_draw_composite_glyph_string_foreground):
7700 Remove unused variable `width'.
7701
1149507c
JB
77022011-03-24 Juanma Barranquero <lekktu@gmail.com>
7703
7704 * w32term.c (x_set_glyph_string_clipping):
7705 Don't pass uninitialized region to CombineRgn.
7706
9c88f339
JB
77072011-03-23 Juanma Barranquero <lekktu@gmail.com>
7708
7709 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7710 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7711 (Fx_close_connection): Remove unused variable `i'.
7712
7713 * w32font.c (w32font_draw): Return number of glyphs.
7714 (w32font_open_internal): Remove unused variable `i'.
7715 (w32font_driver): Add missing initializer.
7716
7717 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7718 (fill_in_menu): Remove unused variable `items_added'.
7719
7720 * w32term.c (last_mouse_press_frame): Remove static global variable.
7721 (w32_clip_to_row): Remove unused variable `f'.
7722 (x_delete_terminal): Remove unused variable `i'.
7723
7724 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7725 (NOTHING): Remove unused static global variable.
7726 (uniscribe_check_otf): Remove unused variable `table'.
7727 (uniscribe_font_driver): Add missing initializers.
7728
dee091a3
JD
77292011-03-23 Julien Danjou <julien@danjou.info>
7730
7731 * term.c (Fsuspend_tty, Fresume_tty):
7732 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7733 * window.c (temp_output_buffer_show):
7734 * insdel.c (signal_before_change):
7735 * frame.c (Fhandle_switch_frame):
7736 * fileio.c (Fdo_auto_save):
7737 * emacs.c (Fkill_emacs):
7738 * editfns.c (save_excursion_restore):
7739 * cmds.c (internal_self_insert):
7740 * callint.c (Fcall_interactively):
7741 * buffer.c (Fkill_all_local_variables):
7742 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7743 Use Frun_hooks.
0f4a96b5 7744 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7745 unconditionally since it does the check itself.
dee091a3 7746
2c520ab5 77472011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7748
c9c49752
PE
7749 Fix more problems found by GCC 4.5.2's static checks.
7750
8abc3f12
PE
7751 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7752 the first time through the loop, since we know p0 < p1 then.
7753 This also avoids a gcc -Wstrict-overflow warning.
7754
a2d26660
PE
7755 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7756 leading to a memory leak, possible in functions like
7757 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7758 of objects (Bug#8318).
a2d26660 7759
916c72e9
PE
7760 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7761 that could (at least in theory) be that large.
7762
19ab8a18
PE
7763 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7764 This is less likely to overflow, and avoids undefined behavior if
7765 overflow does occur. All callers changed. Use strtoul to scan
7766 for the unsigned long integer.
b7cbbd6f
PE
7767 (pint2hrstr): Simplify and tune code slightly.
7768 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7769
f0641eff
PE
7770 * scroll.c (do_scrolling): Work around GCC bug 48228.
7771 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7772
7f650bb9
PE
7773 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7774 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7775 (validate_x_resource_name): Simplify count usage.
7776 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7777
37dd57d1
PE
7778 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7779 fail (Bug#8306).
81e56e61 7780
699979fc 7781 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7782
401bf9b4
PE
7783 * process.c (Fmake_network_process): Use socklen_t, not int,
7784 where POSIX says socklen_t is required in portable programs.
7785 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7786 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7787 (Fmake_network_process, server_accept_connection):
7788 (wait_reading_process_output, read_process_output):
7789 Likewise.
7790
b93aacde
PE
7791 * process.c: Rename or move locals to avoid shadowing.
7792 (list_processes_1, Fmake_network_process):
7793 (read_process_output_error_handler, exec_sentinel_error_handler):
7794 Rename or move locals.
4dc343ee 7795 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7796 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7797 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7798 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7799 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7800
af8a867c 7801 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7802 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7803 Include tparam.h instead, since it declares them.
af8a867c
PE
7804 * cm.h (PC): Remove extern decl; tparam.h now does this.
7805 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7806 * terminfo.c: Include tparam.h, to check interfaces.
7807 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7808 (tparam): Adjust signature to match interface in tparam.h;
7809 this removes some undefined behavior. Check that outstring and len
7810 are zero, which they always are with Emacs.
7811 * tparam.h (PC, BC, UP): New extern decls.
7812
0248044d 7813 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7814 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7815
8ff096c1 7816 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7817 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7818 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7819 (ftfont_list): Remove unused local.
49eaafba
PE
7820 (get_adstyle_property, ftfont_pattern_entity):
7821 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7822 Rename locals to avoid shadowing.
8ff096c1 7823
e2be39f6
PE
7824 * xfont.c (xfont_list_family): Mark var as initialized.
7825
c9735e30
PE
7826 * xml.c (make_dom): Now static.
7827
8f5201ae
PE
7828 * composite.c (composition_compute_stop_pos): Rename local to
7829 avoid shadowing.
b246f932
PE
7830 (composition_reseat_it): Remove unused locals.
7831 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7832 (composition_update_it): Mark var as initialized.
11b61122
PE
7833 (find_automatic_composition): Mark vars as initialized,
7834 with a FIXME (Bug#8290).
8f5201ae 7835
760fbc2c
PE
7836 character.h: Rename locals to avoid shadowing.
7837 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7838 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7839 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7840 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7841 to avoid shadowing.
7842
ff08eb85
PE
7843 * textprop.c (property_change_between_p): Remove; unused.
7844
fc7bf025
PE
7845 * intervals.c (interval_start_pos): Now static.
7846
235d7abc
PE
7847 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7848
44f230aa
SM
7849 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7850 Rename locals to avoid shadowing.
3e7d6594 7851
50060332
PE
7852 * sound.c (wav_play, au_play, Fplay_sound_internal):
7853 Fix pointer signedness.
d01f234b 7854 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7855 (wav_play): Initialize a variable to 0, to prevent undefined
7856 behavior (Bug#8278).
50060332 7857
c4fc4e30
PE
7858 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7859
918436ed
PE
7860 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7861
c939f91b
PE
7862 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7863 clobbering (Bug#8298).
b9c7f648
PE
7864 * sysdep.c (sys_subshell): Likewise.
7865 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7866
6bd8c144
PE
7867 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7868 This should get cleaned up, so that child_setup has the
7869 same signature on all platforms.
7870
7710357c 7871 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7872 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7873
c59da222
CY
78742011-03-22 Chong Yidong <cyd@stupidchicken.com>
7875
7876 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7877 not to be necessary, and produces flickering.
7878
66b87493
GM
78792011-03-20 Glenn Morris <rgm@gnu.org>
7880
7881 * config.in: Remove file.
7882
45b6f6d5
JB
78832011-03-20 Juanma Barranquero <lekktu@gmail.com>
7884
7885 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7886 are now in src/globals.h.
7887 (syms_of_minibuf): Remove spurious & from previous change.
7888
3ec03f7e
LL
78892011-03-20 Leo <sdl.web@gmail.com>
7890
7891 * minibuf.c (completing-read-function): New variable.
7892 (completing-read-default): Rename from completing-read.
7893 (completing-read): Call completing-read-function.
7894
b14e3e21
CY
78952011-03-19 Juanma Barranquero <lekktu@gmail.com>
7896
7897 * xfaces.c (Fx_load_color_file):
7898 Read color file from absolute filename (bug#8250).
7899
f2b726e6
JB
79002011-03-19 Juanma Barranquero <lekktu@gmail.com>
7901
7902 * makefile.w32-in: Update dependencies.
7903
09f6ff02
EZ
79042011-03-17 Eli Zaretskii <eliz@gnu.org>
7905
7906 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7907
29a6015a
PE
79082011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7909
a3a6c54e
PE
7910 Fix more problems found by GCC 4.5.2's static checks.
7911
b766f867
PE
7912 * process.c (make_serial_process_unwind, send_process_trap):
7913 (sigchld_handler): Now static.
7914
be02381c
PE
7915 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7916 That way, the code declares only the vars that it needs.
7917 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7918 * s/cygwin.h (PTY_ITERATION): Likewise.
7919 * s/darwin.h (PTY_ITERATION): Likewise.
7920 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7921
57048744
PE
7922 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7923 * process.c (allocate_pty): Don't declare stb unless it's needed.
7924
7914961c 7925 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7926 (CONSTANTLIM): Remove; unused.
7927 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7928 Define only if needed.
7914961c 7929
b3967b18
PE
7930 * unexelf.c (unexec): Name an expression,
7931 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7932 Use a different way to cause a compilation error if anyone uses
7933 n rather than nn, a way that does not involve shadowing.
73366a00 7934 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7935
29a6015a
PE
7936 * deps.mk (unexalpha.o): Remove; unused.
7937
43cfc33e 7938 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7939 * unexec.h: New file.
ce701a33
PE
7940 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7941 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7942 Depend on unexec.h.
7943 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7944 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7945 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7946 Change as necessary to match prototype in unexec.h.
ce701a33 7947
01f44d5a
PE
7948 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7949 shadowing.
4f63c6bb 7950 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7951
a6670b0b
PE
7952 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7953 Rename locals to avoid shadowing.
7954
cef2010d 7955 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7956 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7957
d4d7173a
PE
7958 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7959
f08b802a
PE
7960 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7961 warning when compiling print.c.
7962
3ddb0639
PE
7963 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7964 instead of using an uninitialized var.
5ad03b97 7965 (font_sort_entities): Mark var as initialized.
3ddb0639 7966
170a2692
PE
7967 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7968
e663c700
PE
7969 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7970 pointers to constants.
89bc529a 7971 (font_parse_fcname): Remove unused vars.
7b81e2d0 7972 (font_delete_unmatched): Now static.
ea838e10 7973 (font_get_spec): Remove; unused.
13a547c6
PE
7974 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7975 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7976 Rename or move locals to avoid shadowing.
e663c700 7977
2a80c887 7978 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7979 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7980
1384fa33 7981 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7982 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7983
8b2c52e9
PE
7984 * alloc.c (mark_backtrace): Move decl from here ...
7985 * lisp.h: ... to here, so that it can be checked.
7986
475545b5 7987 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7988 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7989 (lisp_indirect_variable): Name an expression,
7990 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7991 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7992
b1349114 7993 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7994 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7995 Use const pointer when appropriate.
b1349114 7996
a2928364
PE
7997 * lisp.h (get_system_name, get_operating_system_release):
7998 Move decls here, to check interfaces.
7999 * process.c (get_operating_system_release): Move decl to lisp.h.
8000 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8001 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8002 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8003 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8004 (Fformat_time_string, Fencode_time, Finsert_char):
8005 (Ftranslate_region_internal, Fformat):
8006 Rename or remove local vars to avoid shadowing.
9710023e 8007 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8008
a415e694
PE
8009 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8010 avoid shadowing.
8011
8ef4622d
PE
8012 * lisp.h (eassert): Check that the argument compiles, even if
8013 ENABLE_CHECKING is not defined.
8014
946f9a5b
PE
8015 * data.c (Findirect_variable): Name an expression, to avoid
8016 gcc -Wbad-function-cast warning.
112396d6 8017 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8018 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8019 (Fmake_variable_buffer_local, Fmake_local_variable):
8020 Mark variables as initialized.
52746918 8021 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8022
e5aab7e7 8023 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8024 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8025 Rename locals to avoid shadowing.
dff45157
PE
8026 (mark_stack): Move local variables into the #ifdef region where
8027 they're used.
7bc26fdb
PE
8028 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8029 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8030 needed otherwise.
8031 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8032 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8033 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8034
e5aab7e7
PE
8035 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8036 avoids undefined behavior in theory.
8037
4da60324
PE
8038 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8039
88043301
PE
8040 Use functions, not macros, for up- and down-casing (Bug#8254).
8041 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8042 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8043 to use the following functions instead of these macros.
8044 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8045 EMACS_INT, since callers assume the returned value fits in int.
8046 (upcase1): Likewise, for UPCASE_TABLE.
8047 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8048 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8049 the race-condition problem in the old DOWNCASE.
88043301 8050
19ed5445
PE
8051 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8052 Rename locals to avoid shadowing.
8053 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8054 (regex_compile, re_search_2, re_match_2_internal):
8055 Remove unused local vars.
952db0d7
PE
8056 (FREE_VAR): Rewrite so as not to use empty "else",
8057 which gcc can warn about.
da053e48 8058 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8059 (RETALLOC_IF): Define only if needed.
8060 (WORDCHAR_P): Likewise. This one is never needed, but is used
8061 only in a comment talking about a compiler bug, so put inside
8062 the #if 0 of that comment.
8063 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8064 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8065 Remove; unused.
19ed5445 8066
1f3561e4 8067 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8068 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8069 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8070
ded6f8f7
PE
8071 * search.c (simple_search): Remove unused var.
8072
dbd37a95
PE
8073 * dired.c (compile_pattern): Move decl from here ...
8074 * lisp.h: ... to here, so that it can be checked.
8075 (struct re_registers): New forward decl.
8076
7e47afad
PE
8077 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8078
85f24f61
PE
8079 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8080 All uses changed.
8081 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8082 Rename locals to avoid shadowing.
5671df8f 8083 (Fvertical_motion): Mark locals as initialized.
85f24f61 8084
181aa2be 8085 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8086 (casify_region): Mark local as initialized.
181aa2be 8087
930d429c
PE
8088 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8089
7082eac6
PE
8090 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8091 New macros, so that the caller can use some names other than
8092 gcpro1, gcpro2, etc.
8093 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8094 of the new macros.
8095 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8096 argument, for consistency with GCPRO2_VAR, etc: it is now the
8097 prefix of the variable, not the variable itself. All uses
8098 changed.
38b2c076
PE
8099 * dired.c (directory_files_internal, file_name_completion):
8100 Rename locals to avoid shadowing.
8101
15206ed9
PE
8102 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8103 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8104 dired.c's scmp function, had undefined behavior.
8105 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8106 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8107 * buffer.h: ... to here, because these macros use current_buffer,
8108 and the new implementation with inline functions needs to have
8109 current_buffer in scope now, rather than later when the macros
8110 are used.
8111 (downcase, upcase1): New static inline functions.
8112 (DOWNCASE, UPCASE1): Reimplement using these functions.
8113 This avoids undefined behavior in expressions like
8114 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8115 from race conditions in accessing the global variables
8116 case_temp1 and case_temp2.
8117 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8118 * lisp.h (case_temp1, case_temp2): Remove their decls.
8119 * character.h (ASCII_CHAR_P): Move from here ...
8120 * lisp.h: ... to here, so that the inline functions mentioned
8121 above can use them.
8122
4a6bea26
PE
8123 * dired.c (directory_files_internal_unwind): Now static.
8124
f14b7e14
PE
8125 * fileio.c (file_name_as_directory, directory_file_name):
8126 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8127 Now static.
2893f146
PE
8128 (file_name_as_directory): Use const pointers when appropriate.
8129 (Fexpand_file_name): Likewise. In particular, newdir might
8130 point at constant storage, so make it a const pointer.
fd4ead52 8131 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8132 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8133 signedness issues.
f839df0c
PE
8134 (Fset_file_times, Finsert_file_contents, auto_save_error):
8135 Rename locals to avoid shadowing.
f14b7e14 8136
5716756e 8137 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8138 (Ftry_completion, Fall_completions): Rename or remove locals
8139 to avoid shadowing.
5716756e 8140
b4c3046a
PE
8141 * marker.c (bytepos_to_charpos): Remove; unused.
8142
b45db522
PE
8143 * lisp.h (verify_bytepos, count_markers): New decls,
8144 so that gcc does not warn that these functions aren't declared.
8145
85876d07
PE
8146 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8147 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8148 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8149 (copy_text): Remove unused local var.
85876d07 8150
03d78a21 8151 * filelock.c (within_one_second): Now static.
b3dd38ab 8152 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8153
5df8f01b
PE
8154 * buffer.c (fix_overlays_before): Mark locals as initialized.
8155 (fix_start_end_in_overlays): Likewise. This function should be
8156 simplified by using pointers-to-pointers, but that's a different
8157 matter.
b1d876f1 8158 (switch_to_buffer_1): Now static.
8f54f30a
PE
8159 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8160 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8161
a70072c9 8162 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8163 Fix pointer signedness issue.
edced198
PE
8164 (sys_subshell): Mark local as volatile if checking for lint,
8165 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8166 (MAXPATHLEN): Define only if needed.
a70072c9 8167
a0977c44
PE
8168 * process.c (serial_open, serial_configure): Move decls from here ...
8169 * systty.h: ... to here, so that they can be checked.
8170
a884fdcc
PE
8171 * fns.c (get_random, seed_random): Move extern decls from here ...
8172 * lisp.h: ... to here, so that they can be checked.
8173
604efe86 8174 * sysdep.c (reset_io): Now static.
b8950c94 8175 (wait_for_termination_signal): Remove; unused.
604efe86 8176
38fc62d9
PE
8177 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8178 (copy_keymap_item, append_key, push_text_char_description):
8179 Now static.
1004a21a 8180 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8181 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8182 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8183 (describe_map_tree):
8184 Rename locals to avoid shadowing.
38fc62d9 8185
2f2650da
PE
8186 * keyboard.c: Declare functions static if they are not used elsewhere.
8187 (echo_char, echo_dash, cmd_error, top_level_2):
8188 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8189 (read_char, kbd_buffer_get_event, make_lispy_position):
8190 (make_lispy_event, make_lispy_movement, apply_modifiers):
8191 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8192 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8193 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8194 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8195 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8196
a053e86c 8197 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8198 (mark_kboards): Move decl here ...
8199 * alloc.c (mark_kboards): ... from here.
a053e86c 8200
4752793e
PE
8201 * lisp.h (force_auto_save_soon): New decl.
8202
74f10ca7 8203 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8204 (DEFINE_DUMMY_FUNCTION): New macro.
8205 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8206 Use it.
c03cd23f
PE
8207 (main): Add casts to avoid warnings
8208 if GCC considers string literals to be constants.
74f10ca7 8209
022e70d4
PE
8210 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8211
59d6fe83
PE
8212 * dbusbind.c: Pointer signedness fixes.
8213 (xd_signature, xd_append_arg, xd_initialize):
8214 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8215 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8216 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8217 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8218
78320123
PE
8219 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8220 if GCC considers string literals to be constants.
49cebcca 8221 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8222
35ac2a97
SM
82232011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8224
fb103ca9
SM
8225 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8226 (print_preprocess, print_object): New macro to fix last change.
8227
35ac2a97
SM
8228 * print.c (print_preprocess): Don't forget font objects.
8229
62973b41
JB
82302011-03-16 Juanma Barranquero <lekktu@gmail.com>
8231
8232 * emacs.c (USAGE3): Doc fixes.
8233
0e48bb22
AS
82342011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8235
8236 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8237 structure.
8238
7684e57b
JB
82392011-03-14 Juanma Barranquero <lekktu@gmail.com>
8240
8241 * lisp.h (VWindow_system, Qfile_name_history):
8242 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8243 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8244 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8245
8246 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8247 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8248
8249 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8250 * w32console.c (detect_input_pending, read_input_pending)
8251 (encode_terminal_code):
8252 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8253 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8254 (w32_system_caret_y, Qfile_name_history):
8255 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8256 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8257 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8258 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8259 * w32proc.c (Qlocal, report_file_error):
8260 * w32term.c (Vwindow_system, updating_frame):
8261 * w32uniscribe.c (initialized, uniscribe_font_driver):
8262 Remove unneeded extern declarations.
8263
2aa46d6c
CY
82642011-03-14 Chong Yidong <cyd@stupidchicken.com>
8265
c96bbc66 8266 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8267
cffc6f3b
CY
82682011-03-13 Chong Yidong <cyd@stupidchicken.com>
8269
8270 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8271 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8272 These macros can no longer be used for assignment.
8273
44f230aa
SM
8274 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8275 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8276 (record_buffer_markers, fetch_buffer_markers): New functions for
8277 recording and fetching special buffer markers.
8278 (set_buffer_internal_1, set_buffer_temp): Use them.
8279
8280 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8281
8282 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8283
8284 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8285 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8286
8287 * xdisp.c (hscroll_window_tree):
8288 (reconsider_clip_changes): Use PT instead of BUF_PT.
8289
d251f04b
EZ
82902011-03-13 Eli Zaretskii <eliz@gnu.org>
8291
8292 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8293 $(EMACS_ROOT)/lib/intprops.h.
8294
f0c77cd1
PE
82952011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8296
3eca4629
PE
8297 Fix more problems found by GCC 4.5.2's static checks.
8298
7c86ee98
PE
8299 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8300 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8301 (xg_free_frame_widgets): Make it clear that a local variable is
8302 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8303 (gdk_window_get_screen): Make it clear that this macro is needed
8304 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8305 (int_gtk_range_get_value): New function, which avoids a diagnostic
8306 from gcc -Wbad-function-cast.
8307 (xg_set_toolkit_scroll_bar_thumb): Use it.
8308 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8309 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8310 (get_utf8_string, xg_get_file_with_chooser):
8311 Rename locals to avoid shadowing.
8312 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8313
41729b81
PE
8314 * xgselect.c (xg_select): Remove unused var.
8315
f0c77cd1
PE
8316 * image.c (four_corners_best): Mark locals as initialized.
8317 (gif_load): Initialize transparent_p to zero (Bug#8238).
8318 Mark another local as initialized.
ec6cf4c6 8319 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8320
ce0ad53d 8321 * image.c (clear_image_cache): Now static.
d5d5a617 8322 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8323 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8324 (x_edge_detection): Remove unnecessary cast that
8325 gcc -Wbad-function-cast diagnoses.
2037898d 8326 (gif_load): Fix pointer signedness.
6ae141d6
PE
8327 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8328 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8329
33383987 83302011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8331
d32df629
PE
8332 Improve quality of tests for time stamp overflow.
8333 For example, without this patch (encode-time 0 0 0 1 1
8334 1152921504606846976) returns the obviously-bogus value (-948597
8335 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8336 reports time overflow. See
8337 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8338 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8339 * editfns.c: Include limits.h and intprops.h.
8340 (TIME_T_MIN, TIME_T_MAX): New macros.
8341 (time_overflow): Move earlier, to before first use.
8342 (hi_time, lo_time): New functions, for an accurate test for
8343 out-of-range times.
8344 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8345 (Fget_internal_run_time): Don't assume time_t fits in int.
8346 (make_time): Use list2 instead of Fcons twice.
8347 (Fdecode_time): More accurate test for out-of-range times.
8348 (check_tm_member): New function.
8349 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8350 (lisp_time_argument): Don't rely on undefined left-shift and
8351 right-shift behavior when checking for time stamp overflow.
8be6f318 8352
fe31d94c
PE
8353 * editfns.c (time_overflow): New function, refactoring common code.
8354 (Fformat_time_string, Fdecode_time, Fencode_time):
8355 (Fcurrent_time_string): Use it.
8356
8be6f318
PE
8357 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8358 * dired.c (make_time): Move to ...
8359 * editfns.c (make_time): ... here.
8360 * systime.h: Note the move.
8361
09d9db2c 83622011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8363
126bc0dc
YM
8364 * fringe.c (update_window_fringes): Remove unused variables.
8365
c47cbdfd
YM
8366 * unexmacosx.c (copy_data_segment): Also copy __got section.
8367 (Bug#8223)
8368
7ac80be9
EZ
83692011-03-12 Eli Zaretskii <eliz@gnu.org>
8370
c96bbc66 8371 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8372 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8373 Constify `char *' arguments and their references according to
8374 prototypes in tparam.h.
8375
ecb0f94d 8376 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8377
7ac80be9
EZ
8378 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8379 Adapt all references accordingly.
8380
8381 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8382
ef1fd07e
TT
83832011-03-11 Tom Tromey <tromey@redhat.com>
8384
8385 * buffer.c (syms_of_buffer): Remove obsolete comment.
8386
7ef4b50c
EZ
83872011-03-11 Eli Zaretskii <eliz@gnu.org>
8388
8389 * termhooks.h (encode_terminal_code): Declare prototype.
8390
8391 * msdos.c (encode_terminal_code): Don't declare prototype.
8392
8393 * term.c (encode_terminal_code): Now external again, used by
8394 w32console.c and msdos.c.
8395
44f230aa
SM
8396 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8397 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8398
4b1ec863 83992011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8400
1714f52b 8401 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8402
4b1ec863
PE
8403 * fringe.c (update_window_fringes): Mark locals as initialized
8404 (Bug#8227).
8405 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8406
524c7aa6
PE
8407 * alloc.c (mark_fringe_data): Move decl from here ...
8408 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8409 to check its interface.
8410 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8411
a5c0af81 8412 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8413 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8414 (fontset_font): Mark local as initialized.
a9a06e0b 8415 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8416
b4716021
PE
8417 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8418
811e9bac 8419 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8420 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8421 (x_own_selection, Fx_disown_selection_internal): Rename locals
8422 to avoid shadowing.
8423 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8424
7e3ab302
PE
8425 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8426 so that the caller can use some name other than gcpro1.
8427 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8428 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8429 (Fx_backspace_delete_keys_p):
8430 Use them to avoid shadowing, and rename vars to avoid shadowing.
8431 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8432 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8433 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8434 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8435 Remove unused locals.
7e3ab302
PE
8436 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8437 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8438 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8439 macros.
f78faa98 8440
e2b13473
PE
8441 * xterm.h (x_mouse_leave): New decl.
8442
77f23912
PE
8443 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8444 Remove unused functions.
cdf4ba58
PE
8445 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8446 (x_calc_absolute_position): Now static.
7411c686 8447 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8448 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8449 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8450 unless they are used.
38d0b34a
PE
8451 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8452 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8453 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8454 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8455 (x_error_catcher, x_connection_closed, x_error_handler):
8456 (x_error_quitter, xembed_send_message, x_iconify_frame):
8457 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8458 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8459 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8460
44f230aa
SM
8461 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8462 Rename or move locals to avoid shadowing.
6b463e58 8463 (tty_defined_color, merge_face_heights): Now static.
5967d051 8464 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8465 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8466 does not deduce is never used uninitialized.
73719eba
PE
8467 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8468 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8469
426994c3 8470 * terminal.c (store_terminal_param): Now static.
5489860b 8471
032f1620 8472 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8473 (set_frame_menubar): Remove unused local.
d4323972 8474 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8475 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8476 since they might point to immutable storage.
281585b0
PE
8477 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8478 since it's unused otherwise.
032f1620 8479
367c19e5 8480 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8481 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8482 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8483 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8484 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8485 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8486 does not deduce are never used uninitialized.
70739cbe 8487
07b48fa9
PE
8488 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8489
8868a238 8490 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8491 * window.c (window_loop, size_window):
8492 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8493
7e5cf297 8494 * window.c (display_buffer): Now static.
d6550a9f
PE
8495 (size_window): Mark variables that gcc -Wuninitialized
8496 does not deduce are never used uninitialized.
a586633d
PE
8497 * window.h (check_all_windows): New decl, to forestall
8498 gcc -Wmissing-prototypes diagnostic.
5b555da1 8499 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8500
f6095868
PE
8501 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8502 shadowing.
8503 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8504 Include <limits.h>.
8505 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8506 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8507 (load_charset_map): Mark variables that gcc -Wuninitialized
8508 does not deduce are never used uninitialized.
53df7c11 8509 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8510
f38b440c
PE
8511 * coding.c (coding_set_source, coding_set_destination):
8512 Use "else { /* comment */ }" rather than "else /* comment */;"
8513 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8514 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8515 a block, when the outer 'i' will do.
8516 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8517 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8518 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8519 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8520 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8521 Rename locals to avoid shadowing.
8522 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8523 * coding.c (emacs_mule_char, encode_invocation_designation):
8524 Now static, since they're not used elsewhere.
413bb2db 8525 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8526 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8527 (decode_coding_emacs_mule): Mark variables that gcc
8528 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8529 (detect_coding_iso_2022): Initialize a local variable that might
8530 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8531 this initialization is needed. (Bug#8211)
5f58e762
PE
8532 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8533 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8534 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8535 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8536 Remove unused macros.
f38b440c 8537
232b38b9 8538 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8539 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8540 * character.c (string_count_byte8): Likewise.
232b38b9 8541
fb90da1b
PE
8542 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8543 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8544
fb93dbc2
PE
8545 * chartab.c (copy_sub_char_table): Now static, since it's not used
8546 elsewhere.
5c156ace
PE
8547 (sub_char_table_ref_and_range, char_table_ref_and_range):
8548 Rename locals to avoid shadowing.
bbcd0949 8549 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8550
7d3b3862 8551 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8552 (BIDI_BOB): Remove unused macro.
7d3b3862 8553
6be7d3da
PE
8554 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8555 deduce are never used uninitialized.
c2ed9c8b 8556 * term.c (encode_terminal_code): Likewise.
6be7d3da 8557
75f8807f 8558 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8559
50938595
PE
8560 * tparam.h: New file.
8561 * term.c, tparam.h: Include it.
8562 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8563 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8564 Move these decls to tparam.h, and make them agree with what
8565 is actually in tparam.c. The previous trick of using incompatible
8566 decls in different modules does not conform to the C standard.
8567 All callers of tparam changed to use tparam's actual API.
8568 * tparam.c (tparam1, tparam, tgoto):
8569 Use const pointers where appropriate.
8570
fbceeba2
PE
8571 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8572 * cm.h (struct cm): Likewise.
8573 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8574 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8575 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8576 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8577 (turn_on_face, init_tty): Likewise.
8578 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8579
7f3f1250
PE
8580 * term.c (term_mouse_position): Rename local to avoid shadowing.
8581
e6ca6543
PE
8582 * alloc.c (mark_ttys): Move decl from here ...
8583 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8584
c40f8d15
AS
85852011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8586
8587 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8588
cfe0661d
JB
85892011-03-09 Juanma Barranquero <lekktu@gmail.com>
8590
8591 * search.c (compile_pattern_1): Remove argument regp, unused since
8592 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8593 (compile_pattern): Don't pass it.
8594
0afb4571
J
85952011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8596
8597 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8598 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8599 for ! HAVE_GTK3.
8600 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8601
8602 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8603
8604 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8605 gdk_window_get_screen, gdk_window_get_geometry,
8606 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8607 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8608 (xg_get_pixbuf_from_pixmap): New function.
8609 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8610 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8611 Call xg_get_pixbuf_from_pixmap instead of
8612 gdk_pixbuf_get_from_drawable.
8613 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8614 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8615 (xg_check_special_colors): Use GtkStyleContext and its functions
8616 for HAVE_GTK3.
8617 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8618 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8619 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8620 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8621 Call gtk_widget_get_preferred_size.
0afb4571
J
8622 (xg_frame_resized): gdk_window_get_geometry only takes 5
8623 parameters.
44f230aa
SM
8624 (xg_win_to_widget, xg_event_is_for_menubar):
8625 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8626 (xg_set_widget_bg): New function.
8627 (delete_cb): New function.
895009e1 8628 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8629 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8630 (xg_set_background_color): Call xg_set_widget_bg.
8631 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8632 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8633 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8634 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8635 if ! HAVE_GTK3.
8636 (update_frame_tool_bar): Call gtk_widget_hide.
8637 (xg_initialize): Use GDK_KEY_g.
8638
8639 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8640 if ! HAVE_GTK3
8641 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8642
8643 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8644 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8645 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8646
1c2cc4ef
JB
86472011-03-08 Juanma Barranquero <lekktu@gmail.com>
8648
8649 * w32xfns.c (select_palette): Check success of RealizePalette against
8650 GDI_ERROR, not zero.
8651
33383987 8652See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8653
8654;; Local Variables:
8655;; coding: utf-8
aac0c6e3
MR
8656;; End:
8657
33383987 8658 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8659
8660 This file is part of GNU Emacs.
8661
8662 GNU Emacs is free software: you can redistribute it and/or modify
8663 it under the terms of the GNU General Public License as published by
8664 the Free Software Foundation, either version 3 of the License, or
8665 (at your option) any later version.
8666
8667 GNU Emacs is distributed in the hope that it will be useful,
8668 but WITHOUT ANY WARRANTY; without even the implied warranty of
8669 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8670 GNU General Public License for more details.
8671
8672 You should have received a copy of the GNU General Public License
8673 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.