* keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
[bpt/emacs.git] / src / ChangeLog
CommitLineData
fb7da12e
AS
12012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2
3 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4 Avoid comma operator.
5 * menu.c (push_submenu_start, push_submenu_end)
6 (push_left_right_boundary, push_menu_pane): Likewise.
7 * msdos.c (dos_rawgetc): Likewise.
8
afa2ffd8
DA
92012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
10
11 * xfns.c (xic_create_fontsetname): Remove redundant calls
12 to memset.
13
b3b4476b
PE
142012-06-25 Paul Eggert <eggert@cs.ucla.edu>
15
4495ff38
PE
16 * gtkutil.c (get_utf8_string): Remove redundant assignment.
17 sprintf already null-terminates its output.
18
b3b4476b
PE
19 * xfns.c (x_window): Remove redundant cast.
20
b00876c9
DA
212012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
22
23 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
24 `const char *' to `char *' to avoid compiler warning.
25
d188e26b
PE
262012-06-24 Paul Eggert <eggert@cs.ucla.edu>
27
885d1d74
PE
28 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
29 instead of truncating it to 63 (admittedly a generous limit).
30
d188e26b
PE
31 * process.c: Fix spelling and caps in comments.
32
e2f560b1
DN
332012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
34
e86db54b 35 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
36 * sysdep.c (setpgrp): Remove definition, not used in this file.
37
7583a3a1
JB
382012-06-24 Juanma Barranquero <lekktu@gmail.com>
39
40 * makefile.w32-in: Update dependencies.
41
696056c2
EZ
422012-06-24 Eli Zaretskii <eliz@gnu.org>
43
44 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
45 (SYSTIME_H): Add nt/inc/sys/time.h.
46
47 * systime.h [WINDOWSNT]: Include sys/time.h.
48
49 * s/ms-w32.h (struct timespec): Definition moved from
50 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
51
845ca893
PE
522012-06-24 Paul Eggert <eggert@cs.ucla.edu>
53
54 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
55 * buffer.h (buffer_slot_type_mismatch):
56 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
57 * eval.c (unwind_to_catch):
58 * image.c (my_png_error, my_error_exit):
59 * keyboard.c (quit_throw_to_read_char, user_error)
60 (Fexit_recursive_edit, Fabort_recursive_edit):
61 * lisp.h (die, args_out_of_range, args_out_of_range_3)
62 (wrong_type_argument, buffer_overflow, __executable_start)
63 (memory_full, buffer_memory_full, string_overflow, Fthrow)
64 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
65 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
66 (fatal):
67 (child_setup) [!DOS_NT]:
68 * lread.c (end_of_file_error, invalid_syntax):
69 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
70 * puresize.h (pure_write_error):
71 * search.c (matcher_overflow):
72 * sound.c (sound_perror, alsa_sound_perror):
73 * sysdep.c, syssignal.h (croak):
74 * term.c (maybe_fatal, vfatal):
75 * textprop.c (text_read_only):
76 * undo.c (user_error):
77 * unexmacosx.c (unexec_error):
78 * xterm.c (x_ins_del_lines, x_delete_glyphs):
79 Use _Noreturn rather than NO_RETURN.
80 No need for separate decl merely because of _Noreturn.
81 * sound.c (sound_warning, parse_sound):
82 Remove unnecessary forward decls.
83
f1dd8073
PE
842012-06-24 Paul Eggert <eggert@cs.ucla.edu>
85
86 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
87 * lisp.h (WAIT_READING_MAX): New macro.
88 * dispnew.c (Fsleep_for, sit_for):
89 * keyboard.c (kbd_buffer_get_event):
90 * process.c (Faccept_process_output):
91 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
92 This improves on the previous patch, which introduced a bug
93 when time_t is unsigned and as wide as intmax_t.
94 See <http://bugs.gnu.org/9000#51>.
95
b82c1755
EZ
962012-06-23 Eli Zaretskii <eliz@gnu.org>
97
98 * dispnew.c (sit_for, Fsleep_for):
99 * keyboard.c (kbd_buffer_get_event):
100 * process.c (Faccept_process_output): Avoid compiler warnings when
101 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
102
ca300656
JB
1032012-06-23 Juanma Barranquero <lekktu@gmail.com>
104
049ec95b
JB
105 * makefile.w32-in: Update dependencies.
106
ca300656
JB
107 * w32.c (ltime): Add return type and declare static.
108 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
109
db7b8d06
PE
1102012-06-23 Paul Eggert <eggert@cs.ucla.edu>
111
112 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
113 Privately reported by Herbert J. Skuhra.
114 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
115 All uses changed.
116 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
117 not make_lisp_timeval, when the argument is of type EMACS_TIME.
118
0bd8297f
EZ
1192012-06-23 Eli Zaretskii <eliz@gnu.org>
120
96512555
EZ
121 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
122 last argument of make_unibyte_string.
123
0bd8297f
EZ
124 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
125 language ID in the event parameters.
126
127 * w32term.c (w32_read_socket): Put the new keyboard codepage into
128 event.code, not the obscure "character set ID".
129
63def6b6
CY
1302012-06-23 Chong Yidong <cyd@gnu.org>
131
132 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
133
e8a02204
EZ
1342012-06-23 Eli Zaretskii <eliz@gnu.org>
135
388cdec0
EZ
136 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
137 * w32.c (fdutimens): New function.
138
139 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
140
141 * s/ms-w32.h (pselect): Redirect to sys_select.
142
143 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
144
e8a02204
EZ
145 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
146 in the logic of incrementing and decrementing the value of
147 use_relocatable_buffers.
148
d054f3fb
PE
1492012-06-23 Paul Eggert <eggert@cs.ucla.edu>
150
151 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
152 Privately reported by Herbert J. Skuhra.
153 [__FreeBSD__]: Remove "*/" typo after "#include".
154 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
155 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
156 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
157 Don't assume EMACS_TIME and struct timeval are the same type.
158
d35af63c
PE
1592012-06-22 Paul Eggert <eggert@cs.ucla.edu>
160
161 Support higher-resolution time stamps (Bug#9000).
162 The time stamps are only nanosecond-resolution at the C level,
163 since that's the best that any real-world system supports now.
164 But they are picosecond-resolution at the Lisp level, as that's
165 easy, and leaves room for future OS improvements.
166
167 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
168 (LIBES): Use it.
169
170 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
171 Don't get current time unless it's needed.
172
173 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
174 now provides it if it's absent.
175 (start_atimer): Port to higher-res time stamps.
176 Check for time stamp overflow. Don't get current time more
177 often than is needed.
178
179 * buffer.h (struct buffer): Buffer modtime now has high resolution.
180 Include systime.h, not time.h.
181 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
182
183 * dired.c: Include stat-time.h.
184 (Ffile-attributes): File times now have higher resolution.
185
186 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
187 (struct image): Timestamp now has higher resolution.
188
189 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
190 has at least microseconds now. All uses removed.
191 (update_frame, update_single_window, update_window, update_frame_1)
192 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
193
194 * editfns.c (time_overflow): Now extern.
195 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
196 (float-time, Fformat_time_string, Fcurrent_time_string)
197 (Fcurrent_time_zone): Accept and generate higher-resolution
198 time stamps.
199 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
200 (decode_time_components, lisp_seconds_argument): New functions.
201 (make_time): Now static.
202 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
203 Report an error if the time is invalid, rather than having the caller
204 do that.
205
206 * fileio.c: Include <stat-time.h>
207 (Fcopy_file): Copy higher-resolution time stamps.
208 Prefer to set the time stamp via a file descriptor if that works.
209 (Fset_file_times, Finsert_file_contents, Fwrite_region)
210 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
211 (Fvisited_file_modtime, Fset_visited_file_modtime):
212 Support higher-resolution time stamps.
213
214 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
215
216 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
217
218 * image.c (prepare_image_for_display, clear_image_cache)
219 (lookup_image): Port to higer-resolution time stamps.
220
221 * keyboard.c (start_polling, bind_polling_period):
222 Check for time stamp overflow.
223 (read_char, kbd_buffer_get_event, timer_start_idle)
224 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
225 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
226 Port to higher-resolution time stamps. Do not assume time_t is signed.
227 (decode_timer): New function. Timers are now vectors of length 9,
228 not 8, to accommodate the picosecond component.
229 (timer_check_2): Use it.
230
231 * nsterm.m (select_timeout, timeval_subtract): Remove.
232 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
233 as they're a bit more accurate and handle overflow better.
234 (ns_select): Change prototype to be compatible with pselect.
235 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
236 * nsterm.h (ns_select): Adjust prototype.
237
238 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
239 us-resolution time stamps.
240 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
241
242 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
243
244 * lisp.h (time_overflow): New decl.
245 (wait_reading_process_output): First arg is now intmax_t, not int,
246 to accommodate larger waits.
247
248 * process.h (struct Lisp_Process.read_output_delay):
249 Now counts nanoseconds, not microseconds.
250 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
251 EMACS_HAS_USECS.
252 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
253 (wait_reading_process_output):
254 Port to ns-resolution time stamps.
255 (Faccept_process_output, wait_reading_process_output):
256 Check for time stamp overflow. Do not assume time_t is signed.
257 (select_wrapper): Remove; we now use pselect.
258 (Fprocess_attributes): Now generates ns-resolution time stamps.
259
260 * sysdep.c: Include utimens.h. Don't include utime.h
261 or worry about struct utimbuf; gnulib does that for us now.
262 (gettimeofday): Remove; gnulib provides a substitute.
263 (make_timeval): New function.
264 (set_file_times): Now sets ns-resolution time stamps.
265 New arg FD; all uses changed.
266 (time_from_jiffies, ltime_from_jiffies, get_up_time)
267 (system_process_attributes):
268 Now returns ns-resolution time stamp. All uses changed.
269 Check for time stamp overflow.
270
271 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
272 provides a substitute now.
273
274 * systime.h: Include timespec.h rather than sys/time.h and time.h,
275 since it guarantees struct timespec.
276 (EMACS_TIME): Now struct timespec, so that we can support
277 ns-resolution time stamps.
278 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
279 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
280 (EMACS_USECS): Remove.
281 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
282 so multiply the arg by 1000 before storing it.
283 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
284 New macros.
285 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
286 Port to ns-resolution time stamps.
287 (EMACS_TIME_NEG_P): Remove; replaced by....
288 (EMACS_TIME_SIGN): New macro.
289 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
290 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
291 (set_file_times, make_time, lisp_time_argument): Adjust signature.
292 (make_timeval, make_lisp_time, decode_time_components): New decls.
293 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
294 that it mishandled time_t overflow. You can't compare by subtracting!
295 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
296 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
297
298 * term.c: Include <sys/time.h>.
299 (timeval_to_Time): New function, for proper overflow wraparound.
300 (term_mouse_position, term_mouse_click): Use it.
301
302 * undo.c (record_first_change): Support higher-resolution time stamps
303 in the undo buffer.
304 (Fprimitive_undo): Use them when restoring time stamps.
305
306 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
307 (w32_get_internal_run_time):
308 Port to higher-resolution Emacs time stamps.
309 (ltime): Now accepts single 64-bit integer, as that's more convenient
310 for callers.
311
312 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
313
314 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
315 for compatibility with pselect. Support ns-resolution time stamps.
316
317 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
318
319 * xselect.c (wait_for_property_change, x_get_foreign_selection):
320 Check for time stamp overflow, and support ns-resolution time stamps.
321
322 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
323 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
324 (timeval_subtract): Remove; no longer needed.
325 (XTflash, XTring_bell, x_wait_for_event):
326 Port to ns-resolution time stamps. Don't assume time_t is signed.
327
b6a92dfe
CY
3282012-06-22 Chong Yidong <cyd@gnu.org>
329
330 * xdisp.c (x_consider_frame_title): Revert last change.
331
d251c37c
EZ
3322012-06-22 Eli Zaretskii <eliz@gnu.org>
333
334 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
335 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
336 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
337 staticidx goes up to 1597 out of 1600 = 0x640.)
338
f10deafb
PE
3392012-06-20 Paul Eggert <eggert@cs.ucla.edu>
340
341 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
342 Otherwise, the umask might be mistakenly 0 while handling input signals.
343
ec6de1e2
SM
3442012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
345
346 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
347
28be1ada
DA
3482012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
349
350 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
351 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
352 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
353 access to `contents' member of Lisp_Vector objects with AREF and ASET
354 where appropriate.
355
c6bf3022
CY
3562012-06-19 Chong Yidong <cyd@gnu.org>
357
358 * frame.c (delete_frame): When selecting a frame on a different
359 text terminal, do not alter the terminal's top-frame.
360
361 * xdisp.c (format_mode_line_unwind_data): Record the target
362 frame's selected window and its terminal's top-frame.
363 (unwind_format_mode_line): Restore them.
364 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
365 Callers changed.
366 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
367 since tty frames can be explicitly named.
368 (prepare_menu_bars): Likewise.
369
370 * term.c (Ftty_top_frame): New function.
371
defd4196
PE
3722012-06-18 Paul Eggert <eggert@cs.ucla.edu>
373
374 Port byte-code-meter to modern targets.
375 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
376 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 377 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
378 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
379 (METER_1, METER_2): Simplify.
380
1053a871
SM
3812012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
382
383 * data.c (Fdefalias): Return `symbol' (bug#11686).
384
b7e8d081
MR
3852012-06-18 Martin Rudalics <rudalics@gmx.at>
386
387 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
388 gets killed during executing of this function (Bug#11665).
389 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
390 (Vkill_buffer_query_functions): In doc-string say that functions
391 run by this hook should not change the current buffer.
392
7ea2b339
PE
3932012-06-18 Paul Eggert <eggert@cs.ucla.edu>
394
395 Fix recently-introduced process.c problems found by static checking.
396 * process.c (write_queue_push, write_queue_pop, send_process):
397 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
398 (write_queue_pop): Fix pointer signedness problem.
399 (send_process): Remove unused local.
400
96a313a1
CY
4012012-06-17 Chong Yidong <cyd@gnu.org>
402
403 * xdisp.c (redisplay_internal): No need to redisplay terminal
404 frames that are not on top.
405
20ca2e94
TN
4062012-06-17 Troels Nielsen <bn.troels@gmail.com>
407
408 * process.c (make_process): Initialize write_queue.
409 (write_queue_push, write_queue_pop): New functions.
410 (send_process): Use them to maintain correct ordering of process
411 writes (Bug#10815).
412
9a900ca9
PE
4132012-06-17 Paul Eggert <eggert@cs.ucla.edu>
414
310fbfa8
PE
415 * lisp.h (eassert): Assume C89 or later.
416 This removes the need for CHECK.
417 (CHECK): Remove. Its comments about always evaluating its
418 argument were confusing, as 'eassert' typically does not evaluate
419 its argument.
420
27bb1ca4
PE
421 * coding.c (produce_chars): Use ptrdiff_t, not int.
422
9a900ca9
PE
423 * xterm.c (x_draw_underwave): Check for integer overflow.
424 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
425
41b7f8bc 4262012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
427
428 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
429 referenced (Bug#11583).
430
9b0e3eba
AA
4312012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
432
433 Implement wave-style variant of underlining.
434 * dispextern.h (face_underline_type): New enum.
435 (face): Add field for underline type.
436 * nsterm.m (ns_draw_underwave): New function.
437 (ns_draw_text_decoration): Use it.
438 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
439 New functions.
440 (x_draw_glyph_string): Use them.
441 * xfaces.c (Qline, Qwave): New Lisp objects.
442 (check_lface_attrs, merge_face_ref)
1053a871
SM
443 (Finternal_set_lisp_face_attribute, realize_x_face):
444 Handle wave-style underline face attributes.
9b0e3eba
AA
445 * xterm.c (x_draw_underwave): New function.
446 (x_draw_glyph_string): Use it.
447
0fb52f11
JB
4482012-06-16 Juanma Barranquero <lekktu@gmail.com>
449
450 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
451 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
452 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
453 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
454 ($(BLD)/w32select.$(O)): Update dependencies.
455
e5560ff7
AS
4562012-06-16 Andreas Schwab <schwab@linux-m68k.org>
457
458 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
459 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
460 * character.c (_fetch_multibyte_char_p): Remove.
461 * alloc.c: Include "character.h" before "buffer.h".
462 * bidi.c: Likewise.
463 * buffer.c: Likewise.
464 * bytecode.c: Likewise.
465 * callint.c: Likewise.
466 * callproc.c: Likewise.
467 * casefiddle.c: Likewise.
468 * casetab.c: Likewise.
469 * category.c: Likewise.
470 * cmds.c: Likewise.
471 * coding.c: Likewise.
472 * composite.c: Likewise.
473 * dired.c: Likewise.
474 * dispnew.c: Likewise.
475 * doc.c: Likewise.
476 * dosfns.c: Likewise.
477 * editfns.c: Likewise.
478 * emacs.c: Likewise.
479 * fileio.c: Likewise.
480 * filelock.c: Likewise.
481 * font.c: Likewise.
482 * fontset.c: Likewise.
483 * fringe.c: Likewise.
484 * indent.c: Likewise.
485 * insdel.c: Likewise.
486 * intervals.c: Likewise.
487 * keyboard.c: Likewise.
488 * keymap.c: Likewise.
489 * lread.c: Likewise.
490 * macros.c: Likewise.
491 * marker.c: Likewise.
492 * minibuf.c: Likewise.
493 * nsfns.m: Likewise.
494 * nsmenu.m: Likewise.
495 * print.c: Likewise.
496 * process.c: Likewise.
497 * regex.c: Likewise.
498 * region-cache.c: Likewise.
499 * search.c: Likewise.
500 * syntax.c: Likewise.
501 * term.c: Likewise.
502 * textprop.c: Likewise.
503 * undo.c: Likewise.
504 * unexsol.c: Likewise.
505 * w16select.c: Likewise.
506 * w32fns.c: Likewise.
507 * w32menu.c: Likewise.
508 * window.c: Likewise.
509 * xdisp.c: Likewise.
510 * xfns.c: Likewise.
511 * xmenu.c: Likewise.
512 * xml.c: Likewise.
513 * xselect.c: Likewise.
514
2f07e6af
EZ
5152012-06-16 Eli Zaretskii <eliz@gnu.org>
516
1053a871
SM
517 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
518 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 519 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
520 row.
521 (handle_face_prop): Use chunk-relative overlay string index when
522 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
523 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
524 the rightmost. (Bug#11720)
2f07e6af 525
29b83cec
AS
5262012-06-16 Andreas Schwab <schwab@linux-m68k.org>
527
528 * category.h (CHAR_HAS_CATEGORY): Define as inline.
529 (CATEGORY_MEMBER): Enforce 1/0 value.
530 * category.c (_temp_category_set): Remove.
531
4c5501e9
EZ
5322012-06-16 Eli Zaretskii <eliz@gnu.org>
533
534 * window.c (Fdelete_other_windows_internal)
535 (Fdelete_window_internal): Don't access frame's mouse highlight
536 info of the initial frame. (Bug#11677)
537
2b570124
PE
5382012-06-14 Paul Eggert <eggert@cs.ucla.edu>
539
e93864f9
PE
540 * .gdbinit (xgetint): Fix recently-introduced paren typo.
541 Assume USE_2_TAGS_FOR_INTS.
542 (xreload): Adjust $tagmask width to match recent lisp.h change.
543
2b570124
PE
544 Simplify lisp.h in minor ways that should not affect code.
545 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
546 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
547 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
548 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
549 (INTTYPEBITS): New macro, for clarity.
550 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
551 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
552 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
553 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
554 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
555
81755f69
JB
5562012-06-13 Juanma Barranquero <lekktu@gmail.com>
557
558 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
559
16192a57
GM
5602012-06-13 Glenn Morris <rgm@gnu.org>
561
562 * s/bsd-common.h (BSD4_3):
563 * s/usg5-4-common.h (USG5_4): No longer define; unused.
564
646b5f55
AS
5652012-06-13 Andreas Schwab <schwab@linux-m68k.org>
566
567 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
568 instead of union.
569 (XLI, XIL): Define.
1053a871
SM
570 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
571 Use them.
572 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 573 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 574 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
575 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
576 * frame.c (delete_frame): Remove outdated comment.
577 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
578 USE_LISP_UNION_TYPE.
579 (Fw32_unregister_hot_key): Likewise.
580 (Fw32_toggle_lock_key): Likewise.
581 * w32menu.c (add_menu_item): Likewise.
582 (w32_menu_display_help): Use XIL instead of checking
583 USE_LISP_UNION_TYPE.
584 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
585 (init_heap): Likewise.
586 * w32term.c (w32_read_socket): Update comment.
587
1d3823c9
GM
5882012-06-13 Glenn Morris <rgm@gnu.org>
589
c62ff706
GM
590 * s/usg5-4-common.h, src/s/unixware.h:
591 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
592
1d3823c9
GM
593 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
594
bfe3e0a2
PE
5952012-06-13 Paul Eggert <eggert@cs.ucla.edu>
596
597 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
598 * alloc.c (make_number) [!defined make_number]:
599 Remove, as lisp.h always defines this now.
600 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
601 (roundup_size): Verify that it is a power of 2.
602 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
603 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
604 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
605 -DUSE_LSB_TAG=0, to override the automatically-selected default.
606 USE_LSB_TAG now is always defined to be either 0 or 1.
607 All uses changed.
608 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
609 code works fine either way, and efficiency is not a concern here,
610 as the union type is for debugging, not for production.
611 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
612 Use an inline function on all platforms when using the union type,
613 since this is simpler and 'static inline' can be used portably
614 within Emacs now.
615 (LISP_INITIALLY_ZERO): New macro.
616 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
617 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
618
45fa9c0f
GM
6192012-06-12 Glenn Morris <rgm@gnu.org>
620
b4492cba
GM
621 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
622
623 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 624
45fa9c0f
GM
625 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
626 Move BROKEN_SIGIO to configure.
627
628 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
629 Move NO_TERMIO to configure.
630
0e25d334
CY
6312012-06-12 Chong Yidong <cyd@gnu.org>
632
633 * image.c (imagemagick_load_image): Use MagickFlattenImage if
634 MagickMergeImageLayers is undefined. Use pixel pusher loop if
635 MagickExportImagePixels is undefined.
636
43682bb6
PE
6372012-06-12 Paul Eggert <eggert@cs.ucla.edu>
638
639 * image.c (imagemagick_load_image): Remove unused label.
640
a9be7d2b
GM
6412012-06-11 Glenn Morris <rgm@gnu.org>
642
643 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
644 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
645 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
646 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
647
3017f87f
SM
6482012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
649
650 * alloc.c (make_byte_code): New function.
651 (Fmake_byte_code): Use it. Don't purify here.
652 * lread.c (read1): Use it as well to avoid extra allocation.
653
1b9b4cf4
CY
6542012-06-11 Chong Yidong <cyd@gnu.org>
655
656 * image.c (imagemagick_load_image): Implement transparency.
657
95988fcf
AS
6582012-06-10 Andreas Schwab <schwab@linux-m68k.org>
659
660 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
661 account for preceding backslashes. (Bug#11663)
662
cd4eb164
CY
6632012-06-09 Chong Yidong <cyd@gnu.org>
664
665 * term.c: Support italics in capable terminals (Bug#9652).
666 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
667 (turn_on_face): Output using TS_enter_italic_mode if available.
668 Don't handle unused blinking and alt-charset cases.
669 (turn_off_face): Handle italic case; discard unused tty_blinking_p
670 and tty_alt_charset_p cases.
671 (tty_capable_p, init_tty): Support italics.
672
673 * termchar.h (struct tty_display_info): Add field for italics.
674 Remove unused blink field.
675
676 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
677 Handle slant.
678
679 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
680 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
681 tty_alt_charset_p. Add tty_italic_p.
682
ff88beb8
MA
6832012-06-09 Michael Albinus <michael.albinus@gmx.de>
684
685 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
686 dbus_type_is_basic if available.
687 (xd_extract_signed, xd_extract_unsigned): Rename from
688 extract_signed and extract_unsigned, respectively. Adapt callers.
689
44286096
CY
6902012-06-09 Chong Yidong <cyd@gnu.org>
691
1682701f
CY
692 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
693
44286096
CY
694 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
695 case (Bug#9752).
696
d86feb17
PE
6972012-06-08 Paul Eggert <eggert@cs.ucla.edu>
698
699 * xdisp.c (vmessage): Treat frame message as multibyte.
700 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
701 would generate the diagnostic "Making \302\247 buffer-local while
702 let-bound!".
703
d5c20fe8
EZ
7042012-06-08 Eli Zaretskii <eliz@gnu.org>
705
706 * dispnew.c (showing_window_margins_p): Undo last change, which
707 was done due to an inadvertent commit.
708 (adjust_frame_glyphs_for_frame_redisplay): Do call
709 showing_window_margins_p.
710
513749ee
SM
7112012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
712
713 * eval.c (Fmake_var_non_special): New primitive.
714 (syms_of_eval): Defsubr it.
715 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
716
d4a8f5c1
JB
7172012-06-08 Juanma Barranquero <lekktu@gmail.com>
718
719 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
720 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
721
8bbbc977
EZ
7222012-06-08 Eli Zaretskii <eliz@gnu.org>
723
724 * alloc.c (allocate_vectorlike): Fix last change.
725
f3372c87
DA
7262012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
727
728 Block-based vector allocation of small vectors.
729 * lisp.h (struct vectorlike_header): New field `nbytes',
730 adjust comment accordingly.
731 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
732 to denote vector blocks. Adjust users (live_vector_p,
733 mark_maybe_pointer, valid_lisp_object_p) accordingly.
734 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
735 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
736 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
737 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
738 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
739 (roundup_size): New constant.
740 (struct vector_block): New data type.
741 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 742 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
743 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
744 (sweep_vectors): New functions.
745 (allocate_vectorlike): Return `zero_vector' as the only vector of
746 0 items. Allocate new vector from block if vector size is less than
747 or equal to VBLOCK_BYTES_MAX.
748 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
749 (init_alloc_once): Add call to init_vectors.
750
4f18a4ed
SM
7512012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
752
753 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
754
86f158bc
PE
7552012-06-07 Paul Eggert <eggert@cs.ucla.edu>
756
757 * doprnt.c (doprnt): Truncate multibyte char correctly.
758 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
759 would mishandle a string argument "Xc" if X was a multibyte
760 character of length 2: it would truncate after X's first byte
761 rather than including all of X.
762
c5cfcbe0
CY
7632012-06-06 Chong Yidong <cyd@gnu.org>
764
765 * buffer.c (word_wrap): Doc fix.
766
c05cf390
PE
7672012-06-04 Paul Eggert <eggert@cs.ucla.edu>
768
769 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
770
0c3461de
GM
7712012-06-03 Glenn Morris <rgm@gnu.org>
772
773 * xdisp.c (tool-bar-style): Doc fix.
774
c71232db
UM
7752012-06-03 Ulrich Müller <ulm@gentoo.org>
776
777 * Makefile.in (PAXCTL): Define.
778 (temacs$(EXEEXT)): Disable memory randomization for the temacs
779 binary via PaX flags if the paxctl utility is available.
780 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
781 Restore PaX flags to their default. (Bug#11398)
782
383f7350
CY
7832012-06-03 Chong Yidong <cyd@gnu.org>
784
785 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
786 buffer (Bug#11226).
787
5f2c76c6
CY
7882012-06-03 Chong Yidong <cyd@gnu.org>
789
790 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
791 (note_mode_line_or_margin_highlight): If there is no help echo,
792 use mode-line-default-help-echo. Handle the case where the mouse
793 position is past the end of the mode line string.
794
795 * buffer.c (buffer_local_value_1): New function, split from
796 Fbuffer_local_value; can return Qunbound.
797 (Fbuffer_local_value): Use it.
798 (Vmode_line_format): Docstring tweaks.
799
773d47f6
PE
8002012-06-02 Paul Eggert <eggert@cs.ucla.edu>
801
802 * sysdep.c (system_process_attributes): Improve comment.
803
f2d6a3df
SM
8042012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
805
806 * keyboard.c: Export real-this-command to Elisp.
807 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
808 and DEFVAR it. Update all users.
809
63810350
PE
8102012-06-02 Paul Eggert <eggert@cs.ucla.edu>
811
7bd5c1f4
PE
812 * minibuf.c (Fassoc_string): Remove duplicate declaration.
813
63810350
PE
814 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
815 Convert pctcpu and pctmem to Lisp float properly.
816 Let the compiler fold better, as 100.0/0x8000 is exact.
817
a2821611
AS
8182012-06-02 Andreas Schwab <schwab@linux-m68k.org>
819
820 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
821 cons_block.
822
5fceba1d
PE
8232012-06-01 Paul Eggert <eggert@cs.ucla.edu>
824
825 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
826
c98ff5dd
DA
8272012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
828
829 For a 'struct window', replace some Lisp_Object fields to
830 bitfields where appropriate, remove unused fields.
831 * window.h (struct window): Remove unused 'last_mark_x' and
832 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
833 change it's type from Lisp_Object to bitfield.
834 Change type of 'force_start', 'optional_new_start',
835 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
836 fields from Lisp_Object to bitfield. Adjust users accordingly.
837
ca34e0be
PE
8382012-05-31 Paul Eggert <eggert@cs.ucla.edu>
839
840 Pacify gcc -Wdouble-precision when using Xaw.
841 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
842 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
843 Use 'float' consistently, rather than 'float' in most places
844 and 'double' in a couple of places.
845
efc00ab1 8462012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
847
848 * xdisp.c (handle_stop): Detect whether we have overlay strings
849 loaded by testing it->current.overlay_string_index to be
850 non-negative, instead of checking whether n_overlay_strings is
851 positive. (Bug#11587)
852
efc00ab1 8532012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
854
855 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
856
857 * doc.c (Fsubstitute_command_keys): Doc fix.
858
efc00ab1 8592012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
860
861 * search.c (search_buffer): Remove calls to
862 r_alloc_inhibit_buffer_relocation, as it is now called by
863 maybe_unify_char, which was the cause of relocation of buffer text
864 in bug#11519.
865
efc00ab1 8662012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
867
868 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
869 for the duration of call to load_charset, to avoid problems with
870 callers of maybe_unify_char that access buffer text through C
871 pointers.
872
873 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
874 decrement the inhibition flag, instead of just setting or
875 resetting it.
876
ba93a187
PE
8772012-05-31 Paul Eggert <eggert@cs.ucla.edu>
878
879 Remove obsolete '#define static' cruft.
880 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
881 This #undef was "temporary" in 2000; it is no longer needed
882 now that '#define static' has gone away.
883 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
884 (gray_bitmap_bits): Remove; no longer needed.
885 All uses replaced with definiens.
886 * xterm.c: Include "bitmaps/gray.xbm".
887
9e4bf381
PE
8882012-05-30 Paul Eggert <eggert@cs.ucla.edu>
889
890 Clean up __executable_start, monstartup when --enable-profiling.
891 The following changes affect the code only when profiling.
892 * dispnew.c (__executable_start): Rename from safe_bcopy.
893 Define only on platforms that need it.
894 * emacs.c: Include <sys/gmon.h> when profiling.
895 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
896 (__executable_start): Remove decl, since lisp.h does it now.
897 (safe_bcopy): Remove decl; no longer has that name.
898 (main): Coalesce #if into single bit of code, for simplicity.
899 Cast pointers to uintptr_t, since standard libraries want integers
900 and not pointers.
901 * lisp.h (__executable_start): New decl.
902
32d72c2f
GM
9032012-05-31 Glenn Morris <rgm@gnu.org>
904
905 * image.c (Fimagemagick_types): Doc fix.
906
baac5bc7
JM
9072012-05-30 Jim Meyering <meyering@redhat.com>
908
909 * callproc.c (Fcall_process_region): Include directory component
910 in mkstemp error message (Bug#11586).
911
72cb32cf
PE
9122012-05-30 Paul Eggert <eggert@cs.ucla.edu>
913
914 * alloc.c, lisp.h (make_pure_vector): Now static.
915
61b108cc
SM
9162012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
917
918 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
919 Move to byte-run.el.
920 (Fautoload): Do the hash-doc more carefully.
921 * data.c (Fdefalias): Purify definition, except for keymaps.
922 (Qdefun): Move from eval.c.
923 * lisp.h (Qdefun): Remove.
924 * lread.c (read1): Tiny simplification.
925
471fe23d
TN
9262012-05-29 Troels Nielsen <bn.troels@gmail.com>
927
934f3f58 928 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
929 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
930 Bug#9642, but explicitly check that the buffer the overlay would
931 be moved to is live and rearrange lines to make sure that errors
932 will not put the overlay in an inconsistent state.
933 (Fdelete_overlay): Cosmetics.
934
85d0efd1
EZ
9352012-05-28 Eli Zaretskii <eliz@gnu.org>
936
937 * w32term.c (my_bring_window_to_top): New function.
938 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
939 could be different from the original one.
940 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
941 (Bug#11513)
942
943 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
944 by calling BringWindowToTop.
945
946 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
947 (WM_EMACS_END): Increase by one.
948
da92a98c
PE
9492012-05-28 Paul Eggert <eggert@cs.ucla.edu>
950
951 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
952 This avoids undefined behavior that might cause the eassert
953 to not catch an out-of-range value.
954
74d1f848
JB
9552012-05-28 Juanma Barranquero <lekktu@gmail.com>
956
957 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
958 Update dependencies.
959
9e1a06fc
EZ
9602012-05-27 Eli Zaretskii <eliz@gnu.org>
961
962 * bidi.c (bidi_mirror_char): Fix last change.
963
f3dd7312
AS
9642012-05-27 Andreas Schwab <schwab@linux-m68k.org>
965
966 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
967 when referring to sectname field in printf format.
968
81899c91
PE
9692012-05-27 Paul Eggert <eggert@cs.ucla.edu>
970
57b81a9f
PE
971 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
972 Only r_alloc_inhibit_buffer_relocation needed to be added;
973 the others were already declared.
974
81899c91
PE
975 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
976 before checking whether it's out of range. Put the check inside
977 eassert. See
978 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
979
33017faf 9802012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
981
982 * callproc.c (Fcall_process): Restore a line that was accidentally
983 commented out in the 2011-02-13 change (bug#11547).
984
33017faf 9852012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
986
987 * lisp.h [REL_ALLOC]: Add prototypes for external functions
988 defined on ralloc.c.
989
990 * buffer.c [REL_ALLOC]: Remove prototypes of
991 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
992 they are now on lisp.h.
993
994 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
995
996 * search.c (search_buffer): Use it to inhibit relocation of buffer
997 text while re_search_2 is doing its job, because re_search_2 is
998 passed C pointers to buffer text. (Bug#11519)
999
23415acf
EZ
1000 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1001 Update value to 24.
1002
44e27368
EZ
1003 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1004 state after an additional call to move_it_in_display_line_to, keep
1005 the values of it->max_ascent and it->max_descent found for the
1006 entire line.
1007 (pos_visible_p): Revert the comparison against bottom_y to what it
1008 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1009 (Bug#11464)
1010
c1892f11
PE
10112012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 Fix coding-related core dumps with gcc -ftrapv.
1014 The code was computing A - B, where A and B are pointers, and B is
1015 random garbage. This can lead to core dumps on platforms that
1016 have special pointer registers, and it also leads to core dumps on
1017 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1018 A - B only when B is initialized properly.
1019 * coding.c (coding_set_source, coding_set_destination): Return void.
1020 (coding_change_source, coding_change_destinations): New functions,
1021 with the old behaviors of coding_set_source and coding_set_destination.
1022 All callers that need an offset changed to use these new functions.
1023
eb7afdad
GM
10242012-05-26 Glenn Morris <rgm@gnu.org>
1025
1026 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1027
f12fdf02
EZ
10282012-05-26 Eli Zaretskii <eliz@gnu.org>
1029
53a63be6 1030 Extend mouse support on W32 text-mode console.
61b108cc
SM
1031 * xdisp.c (draw_row_with_mouse_face):
1032 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1033
eb3f6f01 1034 * w32console.c: Include window.h.
61b108cc
SM
1035 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1036 New functions.
eb3f6f01
EZ
1037 (initialize_w32_display): Initialize mouse-highlight data.
1038
53a63be6
EZ
1039 * w32inevt.c: Include termchar.h and window.h.
1040 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1041 moves, call note_mouse_highlight. If help_echo changed, call
1042 gen_help_event to produce help-echo message in the echo area.
1043 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1044 highlight info.
1045
4cfd81f6
PE
10462012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 * lread.c (read1): Simplify slightly to avoid an overflow warning
1049 with GCC 4.7.0 on x86-64.
1050
4446092a
EZ
10512012-05-26 Eli Zaretskii <eliz@gnu.org>
1052
1053 * bidi.c (bidi_mirror_char): Revert last change: an int is
1054 definitely wide enough here.
1055
42b2a986 10562012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1057
42b2a986 1058 Fix integer width and related bugs (Bug#9874).
eb106a49 1059 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1060 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1061 (string_bytes, check_sblock, allocate_string_data):
1062 (compact_small_strings, Fmake_bool_vector, make_string)
1063 (make_unibyte_string, make_multibyte_string)
1064 (make_string_from_bytes, make_specified_string)
1065 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1066 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1067 (mark_vectorlike):
1068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1069 (allocate_pseudovector):
1070 Use int, not EMACS_INT, where int is wide enough.
1071 (inhibit_garbage_collection, Fgarbage_collect):
1072 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1073 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1074 int might not be wide enough.
1075 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1076 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1077 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1078 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1079 (bidi_level_of_next_char, bidi_move_to_visually_next):
1080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1081 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1082 (Fkill_buffer, Fset_buffer_major_mode)
1083 (advance_to_char_boundary, Fbuffer_swap_text)
1084 (Fset_buffer_multibyte, overlays_at, overlays_in)
1085 (overlay_touches_p, struct sortvec, record_overlay_string)
1086 (overlay_strings, recenter_overlay_lists)
1087 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1088 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1089 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1090 (Foverlay_recenter, last_overlay_modification_hooks_used)
1091 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1093 (validate_region): Omit unnecessary test for b <= e,
1094 since that's guaranteed by the previous test.
d311d28c
PE
1095 (adjust_overlays_for_delete): Avoid pos + length overflow.
1096 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1097 (report_overlay_modification):
1098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1099 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1100 Omit pointer cast, which isn't needed anyway, and doesn't work
1101 after the EMACS_INT -> ptrdiff_t change.
02481186 1102 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1103 * buffer.h: Adjust decls to match defn changes elsewhere.
1104 (struct buffer_text, struct buffer):
1105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1106 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1107 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1108 not int, to avoid needless 32-bit limit on 64-bit hosts.
1109 (exec_byte_code): Use tighter memory-full test, one that checks
1110 for alloca overflow. Don't compute the address of the object just
1111 before an array, as that's not portable. Use EMACS_INT, not
1112 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1113 * callint.c (Fcall_interactively):
1114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1115 * callproc.c (call_process_kill, Fcall_process):
1116 Don't assume pid_t fits into an Emacs fixnum.
1117 (call_process_cleanup, Fcall_process, child_setup):
1118 Don't assume pid_t fits into int.
1119 (call_process_cleanup, Fcall_process, delete_temp_file)
1120 (Fcall_process_region):
1121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1122 (Fcall_process): Simplify handling of volatile integers.
1123 Use int, not EMACS_INT, where int will do.
1124 * casefiddle.c (casify_object, casify_region, operate_on_word)
1125 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1127 (casify_object): Avoid integer overflow when overallocating buffer.
1128 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1129 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1130 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1131 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1132 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1133 integers are now checked earlier. All uses replaced with XINT.
1134 (ccl_driver):
1135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1136 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1137 (ccl_driver, Fregister_code_conversion_map):
1138 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1139 (resolve_symbol_ccl_program): Check that vector header is in range.
1140 Always copy the vector, so that we can check its contents reliably
1141 now rather than having to recheck each instruction as it's being
1142 executed. Check that vector words fit in 'int'.
1143 (ccl_get_compiled_code, Fregister_ccl_program)
1144 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1145 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1146 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1147 contents are in range.
1148 (Fccl_execute_on_string): Check that status is in range.
1149 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1150 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1151 Accept and return EMACS_INT, not int, because callers can pass values
1152 out of 'int' range.
1153 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1154 (multibyte_chars_in_text, parse_str_as_multibyte)
1155 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1156 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1157 (string_escape_byte8, Fget_byte):
1158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1159 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1160 avoid mishandling large integers.
1161 * character.h: Adjust decls to match defn changes elsewhere.
1162 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1163 (Ffind_charset_region):
1164 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1165 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1166 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1167 Don't assume fixnum fits in int.
d311d28c
PE
1168 (load_charset_map_from_vector, Fmap_charset_chars):
1169 Remove now-unnecessary CHECK_NATNUMs.
1170 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1171 Don't rely on undefined behavior with signed left shift overflow.
1172 Don't assume unsigned int fits into fixnum, or that fixnum fits
1173 into unsigned int. Don't require max_code to be a valid fixnum;
1174 that's not true for gb10830 4-byte on a 32-bit host. Allow
1175 invalid_code to be a cons, for the same reason. Require code_offset
1176 to be a character. Avoid int overflow if max_char is close
1177 to INT_MAX.
1178 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1179 this is intended anyway and avoids some undefined behavior.
1180 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1181 INDEX_TO_CODE_POINT, as that's what it expects.
1182 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1183 * charset.h (DECODE_CHAR): Return int, not unsigned;
1184 this is what was intended anyway, and it avoids undefined behavior.
1185 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1186 integer-overflow issues.
1187 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1188 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1189 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1190 * chartab.c (Fmake_char_table, Fset_char_table_range)
1191 (uniprop_get_decoder, uniprop_get_encoder):
1192 Don't assume fixnum fits in int.
1193 * cmds.c (move_point): New function, that does the gist of
1194 Fforward_char and Fbackward_char, but does so while checking
1195 for integer overflow more accurately.
c96e5d6a 1196 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1197 (Fforward_line, Fend_of_line, internal_self_insert)
1198 (internal_self_insert):
1199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1200 Fix a FIXME, by checking for integer overflow when calculating
1201 target_clm and actual_clm.
1202 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1203 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1204 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1205 (coding_alloc_by_making_gap, alloc_destination)
1206 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1207 (encode_coding_utf_16, detect_coding_emacs_mule)
1208 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1209 (detect_coding_iso_2022, decode_coding_iso_2022)
1210 (encode_invocation_designation, encode_designation_at_bol)
1211 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1212 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1213 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1214 (encode_coding_ccl, encode_coding_raw_text)
1215 (detect_coding_charset, decode_coding_charset)
1216 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1217 (produce_composition, produce_charset, produce_annotation)
1218 (decode_coding, handle_composition_annotation)
1219 (handle_charset_annotation, consume_chars, decode_coding_gap)
1220 (decode_coding_object, encode_coding_object, detect_coding_system)
1221 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1222 (code_convert_region, code_convert_string)
8f50130c
PE
1223 (Fdefine_coding_system_internal)
1224 (coding_set_source, coding_set_destination):
d311d28c
PE
1225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1226 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1227 (Fdefine_coding_system_internal):
1228 Don't assume fixnums fit in int.
1229 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1230 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1231 (Funencodable_char_position, Fcheck_coding_systems_region)
1232 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1234 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1235 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1236 Don't access memory outside of the args array.
d311d28c 1237 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1238 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1239 result of ENCODE_CHAR.
d311d28c
PE
1240 * coding.h: Adjust decls to match defn changes elsewhere.
1241 (struct coding_system):
1242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1243 * composite.c (get_composition_id, find_composition)
1244 (run_composition_function, update_compositions)
1245 (compose_text, composition_gstring_put_cache)
1246 (composition_gstring_p, composition_gstring_width)
1247 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1248 (composition_compute_stop_pos, composition_reseat_it)
1249 (composition_update_it, struct position_record)
1250 (find_automatic_composition, composition_adjust_point)
1251 (Fcomposition_get_gstring, Ffind_composition_internal):
1252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1253 (update_compositions):
1254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1255 * composite.h: Adjust decls to match defn changes elsewhere.
1256 (struct composition):
1257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1258 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1259 Do not attempt to compute the address of the object just before a
1260 buffer; this is not portable.
1261 (Faref, Faset):
1262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1263 (Faset): Use int, not EMACS_INT, where int is wide enough.
1264 (Fstring_to_number): Don't assume fixnums fit in int.
1265 (Frem): Don't assume arg is nonnegative.
1266 * dbusbind.c (xd_append_arg): Check for integers out of range.
1267 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1268 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1269 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1270 (xd_get_connection_references): Return ptrdiff_t, not int.
1271 All uses changed.
1272 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1273 (xd_read_message_1):
1274 Use int, not unsigned, where the dbus API uses int.
1275 (Fdbus_message_internal): Don't overflow mtype.
1276 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1277 * dired.c (directory_files_internal, file_name_completion, scmp)
1278 (file_name_completion_stat):
1279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1280 (file_name_completion): Don't overflow matchcount.
1281 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1282 * dispextern.h: Adjust decls to match defn changes elsewhere.
1283 (struct text_pos, struct glyph, struct bidi_saved_info)
1284 (struct bidi_string_data, struct bidi_it, struct composition_it)
1285 (struct it):
1286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1287 (struct display_pos, struct composition_it, struct it):
1288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1289 * dispnew.c (increment_matrix_positions)
1290 (increment_row_positions, mode_line_string)
1291 (marginal_area_string):
1292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1293 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1295 (duration_to_sec_usec): New function, to check for overflow better.
1296 (Fsleep_for, sit_for): Use it.
1297 * doc.c (get_doc_string, store_function_docstring):
1298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1299 (get_doc_string, Fsnarf_documentation):
1300 Use int, not EMACS_INT, where int is wide enough.
1301 (get_doc_string):
1302 Use SAFE_ALLOCA, not alloca.
1303 Check for overflow when converting EMACS_INT to off_t.
1304 * doprnt.c (doprnt):
1305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1306 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1307 Don't assume uid_t fits into fixnum.
1308 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1309 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1310 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1311 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1312 (general_insert_function)
1313 (Finsert_char, make_buffer_string, make_buffer_string_both)
1314 (update_buffer_properties, Fbuffer_substring)
1315 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1316 (Fsubst_char_in_region, check_translation)
1317 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1318 (transpose_markers, Ftranspose_regions):
1319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1320 (clip_to_bounds): Move to lisp.h as an inline function).
1321 (Fconstrain_to_field): Don't assume integers are nonnegative.
1322 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1323 (Fsubst_char_in_region, Fsave_restriction):
1324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1325 (Femacs_pid): Don't assume pid_t fits into fixnum.
1326 (lo_time): Use int, not EMACS_INT, when int suffices.
1327 (lisp_time_argument): Check for usec out of range.
1328 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1329 (Fuser_login_name, Fuser_full_name): Signal an error
1330 if a uid argument is out of range, rather than relying on
1331 undefined behavior.
c8d5c857
PE
1332 (Fformat_time_string): Remove now-unnecessary check.
1333 lisp_time_argument checks for out-of-range usec now.
243e0530 1334 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1335 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1336 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1337 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1338 (init_cmdargs, Fdump_emacs):
1339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1340 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1341 the bottom (typically) 32 bits of the fixnum.
1342 * eval.c (specpdl_size, call_debugger):
1343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1344 (when_entered_debugger, Fbacktrace_debug):
1345 Don't assume fixnum can fit in int.
1346 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1347 the object just before a buffer; this is not portable.
1348 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1349 (grow_specpdl, unbind_to):
1350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1351 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1352 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1353 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1354 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1355 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1357 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1358 (a_write, e_write):
1359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1360 (Fcopy_file, non_regular_nbytes, read_non_regular)
1361 (Finsert_file_contents):
1362 Use int, not EMACS_INT, where int is wide enough.
1363 (READ_BUF_SIZE): Verify that it fits in int.
1364 (Finsert_file_contents): Check that counts are in proper range,
1365 rather than assuming fixnums fit into ptrdiff_t etc.
1366 Don't assume fixnums fit into int.
125b3835 1367 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1368 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1369 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1370 (string_char_to_byte, string_byte_to_char)
1371 (string_make_multibyte, string_to_multibyte)
1372 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1373 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1374 (substring_both, Fdelete, internal_equal, Ffillarray)
1375 (Fclear_string, mapcar1)
1376 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1377 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1378 (larger_vector, make_hash_table, maybe_resize_hash_table)
1379 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1380 (Fmaphash, secure_hash):
1381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1382 (concat): Check for string index and length overflow.
1383 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1384 (Frequire):
1385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1386 (larger_vector): New API (vec, incr_min, size_max) replaces old
1387 one (vec, new_size, init). This catches size overflow.
1388 INIT was removed because it was always Qnil.
1389 All callers changed.
1390 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1391 the upper bound on a hash table index size.
1392 (make_hash_table, maybe_resize_hash_table): Use it.
1393 (secure_hash): Computer start_byte and end_byte only after
1394 they're known to be in ptrdiff_t range.
1395 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1396 (Ffont_get_glyphs, Ffont_at):
1397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1398 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1399 (Flist_fonts, Fopen_font):
1400 Don't assume fixnum can fit in int.
1401 (check_gstring): Don't assume index can fit in int.
1402 (font_match_p): Check that fixnum is a character, not a nonnegative
1403 fixnum, since the later code needs to stuff it into an int.
1404 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1405 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1406 conversion overflow issues.
1407 (Fopen_font): Check for integer out of range.
1408 (Ffont_get_glyphs): Don't assume index can fit in int.
1409 * font.h: Adjust decls to match defn changes elsewhere.
1410 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1411 integer overflow.
1412 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1413 printmax_t, where ptrdiff_t is wide enough.
1414 (Finternal_char_font):
1415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1416 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1417 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1418 (Fset_frame_position, x_set_frame_parameters)
1419 (x_set_line_spacing, x_set_border_width)
1420 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1421 Check that fixnums are in proper range for system types.
1422 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1424 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1425 Use SAFE_ALLOCA_LISP, not alloca.
1426 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1427 intptr_t is wide enough.
1428 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1429 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1430 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1431 Check for fixnum out of range.
1432 * ftfont.c (ftfont_list): Don't assume index fits in int.
1433 Check that fixnums are in proper range for system types.
1434 (ftfont_shape_by_flt):
1435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1436 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1438 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1439 Check that fixnums are in proper range for system types.
1440 * gnutls.h: Adjust decls to match defn changes elsewhere.
1441 * gtkutil.c (xg_dialog_run):
1442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1443 (update_frame_tool_bar):
1444 Check that fixnums are in proper range for system types.
1445 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1446 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1447 * indent.c (last_known_column, last_known_column_point):
1448 (current_column_bol_cache):
1449 (skip_invisible, current_column, check_display_width):
1450 (check_display_width, scan_for_column, current_column_1)
1451 (Findent_to, Fcurrent_indentation, position_indentation)
1452 (indented_beyond_p, Fmove_to_column, compute_motion):
1453 (Fcompute_motion, Fvertical_motion):
1454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1455 (last_known_column_modified): Use EMACS_INT, not int.
1456 (check_display_width):
1457 (Fcompute_motion):
1458 Check that fixnums and floats are in proper range for system types.
1459 (compute_motion): Don't assume index or fixnum fits in int.
1460 (compute_motion, Fcompute_motion):
1461 Use int, not EMACS_INT, when it is wide enough.
1462 (vmotion): Omit local var start_hpos that is always 0; that way
1463 we don't need to worry about overflow in expressions involving it.
1464 * indent.h: Adjust decls to match defn changes elsewhere.
1465 (struct position):
1466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1467 Use int, not EMACS_INT, where int is wide enough.
1468 Remove unused members ovstring_chars_done and tab_offset;
1469 all uses removed.
1470 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1471 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1472 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1473 (make_gap, copy_text, insert, insert_and_inherit)
1474 (insert_before_markers, insert_before_markers_and_inherit)
1475 (insert_1, count_combining_before, count_combining_after)
1476 (insert_1_both, insert_from_string)
1477 (insert_from_string_before_markers, insert_from_string_1)
1478 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1479 (adjust_after_replace, adjust_after_insert, replace_range)
1480 (replace_range_2, del_range, del_range_1, del_range_byte)
1481 (del_range_both, del_range_2, modify_region)
1482 (prepare_to_modify_buffer, signal_before_change)
1483 (signal_after_change, Fcombine_after_change_execute):
1484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1485 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1486 (balance_an_interval, split_interval_right, split_interval_left)
1487 (find_interval, next_interval, update_interval)
1488 (adjust_intervals_for_insertion, delete_node, delete_interval)
1489 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1490 (static_offset_intervals, offset_intervals)
1491 (merge_interval_right, merge_interval_left, make_new_interval)
1492 (graft_intervals_into_buffer, temp_set_point_both)
1493 (temp_set_point, set_point, adjust_for_invis_intang)
1494 (set_point_both, move_if_not_intangible, get_property_and_range)
1495 (get_local_map, copy_intervals, copy_intervals_to_string)
1496 (compare_string_intervals, set_intervals_multibyte_1):
1497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1498 * intervals.h: Adjust decls to match defn changes elsewhere.
1499 (struct interval):
1500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1501 * keyboard.c (this_command_key_count, this_single_command_key_start)
1502 (before_command_key_count, before_command_echo_length, echo_now)
1503 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1504 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1505 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1506 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1508 (last_non_minibuf_size, last_point_position, echo_truncate)
1509 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1510 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1511 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1512 (stuff_buffered_input):
1513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1514 (last_auto_save, command_loop_1, read_char):
1515 Use EMACS_INT, not int, to avoid integer overflow.
1516 (record_char): Avoid overflow in total_keys computation.
1517 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1518 * keyboard.h: Adjust decls to match defn changes elsewhere.
1519 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1520 (Fkey_description, Fdescribe_vector, Flookup_key):
1521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1522 (click_position): New function, to check that positions are in range.
1523 (Fcurrent_active_maps):
1524 (describe_command):
1525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1526 (Faccessible_keymaps, Fkey_description):
1527 (preferred_sequence_p):
1528 Don't assume fixnum can fit into int.
1529 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1530 Check for integer overflow in size calculations.
1531 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1532 avoid mishandling large integers.
1533 * lisp.h: Adjust decls to match defn changes elsewhere.
1534 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1535 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1536 (struct Lisp_Marker):
1537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1538 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1539 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1540 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1541 All callers changed.
1542 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1543 Assume the arg has valid form, since it always does.
1544 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1545 unsigned integer system type.
1546 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1547 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1549 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1550 (duration_to_sec_usec): New decl.
1551 * lread.c (read_from_string_index, read_from_string_index_byte)
1552 (read_from_string_limit, readchar, unreadchar, openp)
1553 (read_internal_start, read1, oblookup):
1554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1555 (Fload, readevalloop, Feval_buffer, Feval_region):
1556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1557 (openp): Check for out-of-range argument to 'access'.
1558 (read1): Use int, not EMACS_INT, where int is wide enough.
1559 Don't assume fixnum fits into int.
6efdadfd 1560 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1561 (read_filtered_event): Use duration_to_sec_usec
1562 to do proper overflow checking on durations.
d311d28c
PE
1563 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1564 in size calculation.
1565 (Fexecute_kbd_macro):
1566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1567 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1568 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1569 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1570 (set_marker_both, set_marker_restricted_both, marker_position)
1571 (marker_byte_position, Fbuffer_has_markers_at):
1572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1573 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1574 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1575 It now merely ensures that the menu is large enough, without
1576 necessarily growing it, as this avoids some integer overflow issues.
1577 All callers changed.
1578 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1580 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1581 Use SAFE_ALLOCA_LISP, not alloca.
1582 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1583 to EMACS_INT. Check that fixnums are in proper range for system types.
1584 * minibuf.c (minibuf_prompt_width, string_to_object)
1585 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1586 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1588 (get_minibuffer, read_minibuf_unwind):
1589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1590 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1591 this simplifies overflow checking. All callers changed.
1592 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1593 (Ftest_completion):
1594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1595 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1596 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1597 Check that fixnums are in proper range for system types.
1598 (Fx_create_frame, Fx_show_tip):
1599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1600 * nsfont.m (ns_findfonts, nsfont_list_family):
1601 Don't assume fixnum fits in long.
1602 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1604 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1605 wide enough.
17fdb222 1606 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1608 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1609 (PRINTDECLARE, PRINTPREPARE):
1610 (strout, print_string):
1611 (print, print_preprocess, print_check_string_charset_prop)
1612 (print_object):
1613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1614 (PRINTDECLARE):
1615 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1617 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1618 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1619 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1620 (print_error_message): Use SAFE_ALLOCA, not alloca.
1621 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1622 (print_depth, new_backquote_output, print_number_index):
1623 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1624 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1625 (Fset_process_window_size, Fformat_network_address)
1626 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1627 (sigchld_handler):
d311d28c 1628 Check that fixnums are in proper range for system types.
d44287d4 1629 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1630 Check for process-ids out of pid_t range rather than relying on
1631 undefined behavior.
e4d81efc 1632 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1633 (Fformat_network_address, read_process_output, send_process)
1634 (Fprocess_send_region, status_notify):
1635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1636 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1637 (wait_reading_process_output, read_process_output, exec_sentinel):
1638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1639 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1640 (Faccept_process_output): Use duration_to_sec_usec to do proper
1641 overflow checking on durations.
dde14581
PE
1642 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1643 Don't assume pid_t fits in int.
02481186
PE
1644 * process.h (struct Lisp_Process): Members tick and update_tick
1645 are now of type EMACS_INT, not int.
b62b53e8
PE
1646 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1647 configured --with-wide-int.
d311d28c
PE
1648 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1649 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1650 * search.c (looking_at_1, string_match_1):
1651 (fast_string_match, fast_c_string_match_ignore_case)
1652 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1653 (scan_newline, find_before_next_newline, search_command)
1654 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1655 (set_search_regs, wordify):
1656 (Freplace_match):
1657 (Fmatch_data):
1658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1659 (string_match_1, search_buffer, set_search_regs):
1660 (Fmatch_data):
1661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1662 (wordify): Check for overflow in size calculation.
1663 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1664 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1665 Check that fixnums are in proper range for system types.
1666 * sound.c (struct sound_device)
1667 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1669 (Fplay_sound_internal):
1670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1671 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1672 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1673 (Fparse_partial_sexp):
1674 Don't assume fixnums can fit in int.
1675 (struct lisp_parse_state, find_start_pos, find_start_value)
1676 (find_start_value_byte, find_start_begv)
1677 (update_syntax_table, char_quoted, dec_bytepos)
1678 (find_defun_start, prev_char_comend_first, back_comment):
1679 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1680 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1682 (Finternal_describe_syntax_value): Check that match_lisp is a
1683 character, not an integer, since the code stuffs it into int.
1684 (scan_words, scan_sexps_forward):
1685 Check that fixnums are in proper range for system types.
1686 (Fforward_word):
1687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1688 (scan_sexps_forward):
1689 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1690 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1691 * syntax.h: Adjust decls to match defn changes elsewhere.
1692 (struct gl_state_s):
1693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1694 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1695 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1696 * sysdep.c (wait_for_termination_1, wait_for_termination)
1697 (interruptible_wait_for_termination, mkdir):
1698 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1699 (emacs_read, emacs_write):
1700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1701 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1702 and double all fit in int.
d311d28c
PE
1703 * term.c (set_tty_color_mode):
1704 Check that fixnums are in proper range for system types.
1705 * termhooks.h (struct input_event):
1706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1707 * textprop.c (validate_interval_range, interval_of)
1708 (Fadd_text_properties, set_text_properties_1)
1709 (Fremove_text_properties, Fremove_list_of_text_properties)
1710 (Ftext_property_any, Ftext_property_not_all)
1711 (copy_text_properties, text_property_list, extend_property_ranges)
1712 (verify_interval_modification):
1713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1714 (Fnext_single_char_property_change)
1715 (Fprevious_single_char_property_change):
1716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1717 (copy_text_properties):
1718 Check for integer overflow in index calculation.
d311d28c
PE
1719 * undo.c (last_boundary_position, record_point, record_insert)
1720 (record_delete, record_marker_adjustment, record_change)
1721 (record_property_change):
1722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1723 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1725 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1726 (Fx_hide_tip, Fx_file_dialog):
1727 * w32menu.c (set_frame_menubar):
1728 Use ptrdiff_t, not int, for consistency with rest of code.
1729 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1730 (select_window, Fdelete_other_windows_internal)
1731 (window_scroll_pixel_based, window_scroll_line_based)
1732 (Frecenter, Fset_window_configuration):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 (Fset_window_hscroll, run_window_configuration_change_hook)
1735 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1736 (Fscroll_other_window, Frecenter):
d311d28c
PE
1737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1738 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1739 Don't assume fixnum fits in int.
1740 (Fset_window_scroll_bars):
1741 Check that fixnums are in proper range for system types.
1742 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1743 (string_pos, c_string_pos, number_of_chars, init_iterator)
1744 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1745 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1746 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1747 (face_before_or_after_it_pos, handle_invisible_prop)
1748 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1749 (display_prop_intangible_p, string_buffer_position_lim)
1750 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1751 (get_overlay_strings_1, get_overlay_strings)
1752 (iterate_out_of_display_property, forward_to_next_line_start)
1753 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1754 (get_next_display_element, set_iterator_to_next)
1755 (get_visually_first_element, compute_stop_pos_backwards)
1756 (handle_stop_backwards, next_element_from_buffer)
1757 (move_it_in_display_line_to, move_it_in_display_line)
1758 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1759 (add_to_log, message_dolog, message_log_check_duplicate)
1760 (message2, message2_nolog, message3, message3_nolog
1761 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1762 (current_message_1, truncate_echo_area, truncate_message_1)
1763 (set_message, set_message_1, store_mode_line_noprop)
1764 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1765 (text_outside_line_unchanged_p, check_point_in_composition)
1766 (reconsider_clip_changes)
1767 (redisplay_internal, set_cursor_from_row, try_scrolling)
1768 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1769 (redisplay_window, find_last_unchanged_at_beg_row)
1770 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1771 (trailing_whitespace_p, find_row_edges, display_line)
1772 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1773 (display_mode_element, store_mode_line_string)
1774 (pint2str, pint2hrstr, decode_mode_spec)
1775 (display_count_lines, display_string, draw_glyphs)
1776 (x_produce_glyphs, x_insert_glyphs)
1777 (rows_from_pos_range, mouse_face_from_buffer_pos)
1778 (fast_find_string_pos, mouse_face_from_string_pos)
1779 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1781 (safe_call, init_from_display_pos, handle_fontified_prop)
1782 (handle_single_display_spec, load_overlay_strings)
1783 (with_echo_area_buffer, setup_echo_area_for_printing)
1784 (display_echo_area, echo_area_display)
1785 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1786 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1787 (redisplay_window, dump_glyph_row, display_mode_line)
1788 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1789 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1791 (handle_single_display_spec, build_desired_tool_bar_string)
1792 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1793 (get_specified_cursor_type):
1794 Check that fixnums are in proper range for system types.
1795 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1796 (Flookup_image_map):
1797 Don't assume fixnums fit in int.
1798 (compare_overlay_entries):
1799 Avoid mishandling comparisons due to subtraction overflow.
1800 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1801 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1802 (handle_tool_bar_click):
1803 Use int, not unsigned, since we prefer signed and the signedness
1804 doesn't matter here.
1805 (get_next_display_element, next_element_from_display_vector):
1806 Use int, not EMACS_INT, when int is wide enough.
1807 (start_hourglass): Use duration_to_sec_usec to do proper
1808 overflow checking on durations.
1809 * xfaces.c (Fbitmap_spec_p):
1810 Check that fixnums are in proper range for system types.
1811 (compare_fonts_by_sort_order):
1812 Avoid mishandling comparisons due to subtraction overflow.
1813 (Fx_family_fonts, realize_basic_faces):
1814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1815 (Fx_family_fonts):
1816 Don't assume fixnum fits in int.
1817 Use SAFE_ALLOCA_LISP, not alloca.
1818 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1819 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1820 (face_at_buffer_position, face_for_overlay_string)
1821 (face_at_string_position):
1822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1823 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1824 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1825 (Fx_show_tip):
1826 Check that fixnums are in proper range for system types.
1827 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1828 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1830 (Fx_change_window_property): Don't assume fixnums fit in int.
1831 * xfont.c (xfont_chars_supported):
1832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1833 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1834 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1836 * xml.c (parse_region):
1837 * xrdb.c (magic_file_p):
1838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1839 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1840 (x_get_local_selection, x_reply_selection_request)
1841 (x_handle_selection_request, wait_for_property_change):
1842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1843 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1844 short is wide enough.
1845 (x_send_client_event): Don't assume fixnum fits in int.
1846 * xterm.c (x_x_to_emacs_modifiers):
1847 Don't assume EMACS_INT overflows nicely into int.
1848 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1849 may come from Lisp.
1850 (handle_one_xevent): NATNUMP can eval its arg twice.
1851 (x_connection_closed):
1852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1853 * xterm.h: Adjust decls to match defn changes elsewhere.
1854 (struct scroll_bar): Use struct vectorlike_header
1855 rather than rolling our own approximation.
1856 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1857
c6574eb5
GM
18582012-05-25 Glenn Morris <rgm@gnu.org>
1859
1860 * lisp.mk (lisp): Update for more files being compiled now.
1861
e8d32c7e
SM
18622012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1863
48def666
SM
1864 * lread.c: Remove `read_pure' which makes no difference.
1865 (read_pure): Remove var.
1866 (unreadpure): Remove function.
1867 (readevalloop): Don't call read_list with -1 flag.
1868 (read1, read_vector): Don't test read_pure any more.
1869 (read_list): Simplify.
1870
e8d32c7e
SM
1871 * fileio.c, character.h: Minor style tweaks.
1872
4b2addb7
DA
18732012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1874
1875 * window.h (clip_changed): Remove useless declaration.
1876
584461b2
JB
18772012-05-22 Juanma Barranquero <lekktu@gmail.com>
1878
1879 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1880 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1881
34374650
PE
18822012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 Remove src/m/*.
1885 This directory predates autoconf and is no longer needed nowadays.
1886 Move its few remaining bits of functionality to where they're needed.
1887 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1888 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1889 * m/template.h: Remove.
1890 * Makefile.in (M_FILE): Remove. All uses removed.
1891 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1892 * lisp.h (USE_LSB_TAG):
1893 * mem-limits.h (EXCEEDS_LISP_PTR):
1894 Use VAL_MAX, not VALBITS, in #if.
1895 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1896 (EMACS_UINT): Define unconditionally now.
1897 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1898 (BITS_PER_EMACS_INT): New constants, replacing
1899 what used to be in config.h, but not useful in #if.
1900 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1901 define them any more.
1902 (VAL_MAX): New macro.
1903 (VALMASK): Use it.
1904 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1905 BITS_PER_EMACS_INT, in #if.
1906 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1907 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1908 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1909 * s/ms-w32.h (DATA_START):
1910 Move here from removed file m/intel386.h.
1911 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1912 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1913
261cb4bb
PE
19142012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1915
1916 Assume C89 or later.
1917 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1918 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1919 (xrealloc):
1920 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1921 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1922 * textprop.c, tparam.c (NULL): Remove.
1923 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1924 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1925 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1926 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1927 * xterm.c (input_signal_count): Assume volatile works.
1928
ff23cd9f
KB
19292012-05-21 Ken Brown <kbrown@cornell.edu>
1930
1931 * xgselect.c (xg_select): Fix first argument in call to 'select'
1932 (bug#11508).
1933
1b170bc6
KB
19342012-05-20 Ken Brown <kbrown@cornell.edu>
1935
1936 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1937 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1938
b2f4d39f
KB
19392012-05-19 Ken Brown <kbrown@cornell.edu>
1940
1941 * xfns.c (x_in_use): Remove `static' qualifier.
1942 * xterm.h (x_in_use): Declare.
1943 * xgselect.c: Include xterm.h.
1944 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1945 and `display_arg' (bug#9754).
1946
003fdae2
PE
19472012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1948
9232a6d9
PE
1949 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1950
003fdae2
PE
1951 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1952 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1953
784b56e2
EZ
19542012-05-18 Eli Zaretskii <eliz@gnu.org>
1955
1956 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1957
1958 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1959 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1960
1961 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1962 reference to image_cache->refcount.
1963 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1964
a0a79cde
JL
19652012-05-17 Juri Linkov <juri@jurta.org>
1966
1967 * search.c (Fword_search_regexp, Fword_search_backward)
1968 (Fword_search_forward, Fword_search_backward_lax)
1969 (Fword_search_forward_lax): Move functions to isearch.el
1970 (bug#10145, bug#11381).
1971
b0572523
PE
19722012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1975
9660f5fc
SM
19762012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1977
1978 * lread.c (init_obarray): Declare Qt and Qnil as special.
1979
4374de83
GM
19802012-05-14 Glenn Morris <rgm@gnu.org>
1981
1982 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1983 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1984
dc44c39a
PE
19852012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1986
078c97cb
PE
1987 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1988
dc44c39a
PE
1989 * unexaix.c: Port to more-recent AIX compilers.
1990 (report_error, report_error_1, make_hdr, copy_sym)
1991 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1992 Make arguments const char *, not char *, to avoid violations of C
1993 standard and to fix some AIX warnings reported by Gilles Pion.
1994
e18afed7 19952012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1996
1997 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1998 already have overlays loaded.
1999 (handle_single_display_spec): Before returning without displaying
2000 fringe bitmap, synchronize the bidi iterator with the main display
2001 iterator, by calling iterate_out_of_display_property.
2002 (iterate_out_of_display_property): Detect buffer iteration by
2003 testing that it->string is a Lisp string.
2004 (get_next_display_element): When the current object is exhausted,
2005 and there's something on it->stack, call set_iterator_to_next to
2006 proceed with what's on the stack, instead of returning zero.
2007 (set_iterator_to_next): If called at the end of a Lisp string,
2008 proceed to consider_string_end without incrementing string
2009 position. Don't increment display vector index past the end of
2010 the display vector. (Bug#11417)
c8fb9dc6
EZ
2011 (pos_visible_p): Don't report a position visible when move_it_to
2012 stopped at the last line of window, which happens to be scanned
2013 backwards by the bidi iteration. (Bug#11464)
ac268e67 2014
e18afed7 20152012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2016
2017 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2018 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2019 are on a TTY, and thus unable to display on the fringes.
2020 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2021 so we need to signal to the caller that this is a "replacing"
2022 display spec. This fixes display when the spec is invalid or we
2023 are on a TTY.
2024
e18afed7 20252012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2026
2027 * unexaix.c (make_hdr): Fix typo in prototype.
2028 This bug broke the build on AIX. Problem reported by Gilles Pion.
2029
9d0a235a
MA
20302012-05-14 Michael Albinus <michael.albinus@gmx.de>
2031
2032 * keyboard.c (kbd_buffer_get_event): Read special events also in
2033 batch mode. (Bug#11415)
2034
9e6b06ed
GM
20352012-05-12 Glenn Morris <rgm@gnu.org>
2036
2037 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2038
c1a1d7a3
EZ
20392012-05-12 Eli Zaretskii <eliz@gnu.org>
2040
2041 * lisp.mk (lisp): Add newcomment.elc.
2042
3fe7cdc8
GM
20432012-05-12 Glenn Morris <rgm@gnu.org>
2044
2045 * Makefile.in (MKDIR_P): New, set by configure.
2046 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2047
53f7d2c0
PE
20482012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 Remove unused function hourglass_started.
2051 * dispextern.h (hourglass_started):
2052 * w32fns.c (hourglass_started):
2053 * xdisp.c (hourglass_started): Remove.
2054
75aafb17
JB
20552012-05-10 Juanma Barranquero <lekktu@gmail.com>
2056
2057 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2058 Update dependencies.
2059
12959e8e
PE
20602012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2061
97107e2e
PE
2062 * xgselect.c (xg_select): Put maxfds+1 into a var.
2063 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2064
12959e8e
PE
2065 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2066
836d29b3
DA
20672012-05-10 Dave Abrahams <dave@boostpro.com>
2068
2069 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2070 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2071
5cb67954
MA
20722012-05-09 Michael Albinus <michael.albinus@gmx.de>
2073
2074 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2075 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2076 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2077 Initialize xd_registered_buses.
2078
3478ec45
PE
20792012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2080
b263a6b0
PE
2081 Untag more efficiently if USE_LSB_TAG.
2082 This is based on a proposal by YAMAMOTO Mitsuharu in
2083 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2084 For an admittedly artificial (nth 8000 longlist) benchmark on
2085 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2086 Emacs's overall text size by 1%.
2087 * lisp.h (XUNTAG): New macro.
2088 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2089 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2090 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2091 * eval.c (Fautoload):
2092 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2093 * frame.h (XFRAME): Use XUNTAG.
2094
3478ec45
PE
2095 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2096 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2097 Remove unportable assumptions about print widths of types like
2098 dbus_uint32_t.
2099 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2100 intptr_t when converting between pointer and integer, to avoid GCC
2101 warnings about wrong width.
2102
666b903b 21032012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2104
2105 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2106 stack for each reader_thread, instead of defaulting to 8MB
2107 determined by the linker. This avoids failures in creating
2108 subprocesses on Windows 7, see the discussion in this thread:
2109 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2110
b120cc17
JC
21112012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2112
2113 Fix up display of the *Minibuf-0* buffer in the mini window.
2114 * keyboard.c (read_char): Don't clear the echo area if there's no
2115 message to clear.
2116 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2117 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2118
9a4b36f8
MA
21192012-05-07 Michael Albinus <michael.albinus@gmx.de>
2120
2121 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2122 batch mode.
2123
e5f9458f
CY
21242012-05-06 Chong Yidong <cyd@gnu.org>
2125
2126 * lisp.mk (lisp): Update.
2127
eceeb5fc 21282012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2129
2130 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2131
71873e2b
SM
21322012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2133
2134 * data.c (PUT_ERROR): New macro.
2135 (syms_of_data): Use it. Add new error type `user-error'.
2136 * undo.c (user_error): New function.
2137 (Fprimitive_undo): Use it.
2138 * print.c (print_error_message): Adjust print style for `user-error'.
2139 * keyboard.c (user_error): New function.
2140 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2141
ab0fa4e4
PE
21422012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 Do not limit current-time-string to years 1000..9999.
2145 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2146 (Fcurrent_time_string): Support any year that is supported by the
2147 underlying localtime representation. Don't use asctime, as it
2148 has undefined behavior for years outside the range -999..9999.
2149
7ed806a7
PE
21502012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2151
2152 Fix race conditions involving setenv, gmtime, localtime, asctime.
2153 Without this fix, interrupts could mess up code that uses these
2154 nonreentrant functions, since setting TZ invalidates existing
2155 tm_zone or tzname values, and since most of these functions return
2156 pointers to static storage.
2157 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2158 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2159 Grow the critical sections to include not just invoking
2160 localtime/gmtime, but also accessing these functions' results
2161 including their tm_zone values if any, and any related TZ setting.
2162 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2163 so that the struct tm is saved in the critical section.
2164 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2165 motivated by the fact that memory allocation needs to be outside
2166 the critical section.
2167
0c16dfed
DA
21682012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2169
2170 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2171 with RESET_INTERVAL.
2172
2173 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2174 Remove duplicated buffer name initialization.
2175
3f83ace8
JM
21762012-05-02 Jim Meyering <jim@meyering.net>
2177
2178 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2179
c7b8541e
JM
2180 * xfns.c (x_window): Use xstrdup (Bug#11375).
2181
90207a15 21822012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2183
2184 * xdisp.c (pos_visible_p): If already at a newline from the
2185 display string before the 'while' loop, don't walk back the glyphs
2186 from it3.glyph_row. Solves assertion violation when the display
2187 string begins with a newline (egg.el). (Bug#11367)
2188
b593d6a9
AH
21892012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2190
2191 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2192 Move to simple.el.
2193
4737362e
GM
21942012-05-01 Glenn Morris <rgm@gnu.org>
2195
99cf43f9
GM
2196 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2197 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2198 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2199 All were removed before 23.1.
2200
9311dcff
GM
2201 * dispnew.c: Remove HAVE_LIBNCURSES test;
2202 it is always true on relevant platforms.
2203
4d5c6349
GM
2204 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2205 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2206
4737362e
GM
2207 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2208
74dd3a6b
AS
22092012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2210
2211 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2212 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2213 Remove.
2214
13c379ee
PE
22152012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 Do not avoid creating empty evaporating overlays (Bug#9642).
2218 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2219 That is, do not delete an evaporating overlay if it becomes
2220 empty after its bounds are adjusted to fit within its buffer.
2221 This fix caused other problems, and I'm reverting it until we get
2222 to the bottom of them.
2223
a8e7d6d7 22242012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2225
2226 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2227
a8e7d6d7 22282012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2229
2230 * xdisp.c (pos_visible_p): If the window start position is beyond
2231 ZV, start the display from buffer beginning. Prevents assertion
2232 violation in init_iterator when the minibuffer window is scrolled
2233 via the scroll bar.
2234
2235 * window.c (window_scroll_pixel_based): Likewise.
2236
a8e7d6d7 22372012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2238
2239 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2240
a8e7d6d7 22412012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2242
2243 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2244 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2245
a8e7d6d7 22462012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2247
b593d6a9
AH
2248 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2249 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2250
1c6900d9
EZ
22512012-04-26 Eli Zaretskii <eliz@gnu.org>
2252
4c3fa1d9
EZ
2253 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2254 display element, check also the underlying string or buffer
2255 character. (Bug#11341)
2256
1c6900d9
EZ
2257 * w32menu.c: Include w32heap.h.
2258 (add_menu_item): If the call to AppendMenuW (via
2259 unicode_append_menu) fails, disable Unicode menus only if we are
2260 running on Windows 9X/Me.
2261
42bf8205
AS
22622012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2263
2264 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2265 (xgetint): Add missing shift for LSB tags.
2266
b1bac16e
MR
22672012-04-24 Martin Rudalics <rudalics@gmx.at>
2268
2269 * keyboard.c (read_char): Don't wipe echo area for select window
2270 events: These might get delayed via `mouse-autoselect-window'
2271 (Bug#11304).
2272
d69621cc
JB
22732012-04-24 Juanma Barranquero <lekktu@gmail.com>
2274
2275 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2276 manipulation of :loaded-from data.
2277
02fd101b
JB
22782012-04-23 Juanma Barranquero <lekktu@gmail.com>
2279
2280 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2281 now a cons (bug#11311).
2282
888bec30
PE
22832012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2284
89a438bd
PE
2285 Do not create empty overlays with the evaporate property (Bug#9642).
2286 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2287 if it becomes empty after its bounds are adjusted to fit within
2288 its buffer. Without this fix, in a nonempty buffer (let ((o
2289 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2290 yields an empty overlay that has the evaporate property, which is
2291 not supposed to happen.
2292
1068fe4d
PE
2293 Fix minor GTK3 problems found by static checking.
2294 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2295 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2296 (struct _EmacsFixedClass, emacs_fixed_get_type):
2297 Move decls here from emacsgtkfixed.h, since they needn't be public.
2298 (emacs_fixed_get_type): Now static.
2299 (emacs_fixed_class_init): Omit unused local.
2300 (emacs_fixed_child_type): Remove; unused.
2301 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2302 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2303 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2304 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2305 (EMACS_FIXED_GET_CLASS): Remove; unused.
2306 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2307
888bec30
PE
2308 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2309 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2310
de85e130
PE
23112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2312
d0baac98 2313 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2314 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2315 (__malloc_size_t, __malloc_ptrdiff_t):
2316 Remove. All uses removed, replaced by the definiens if needed,
2317 since we can assume C89 or better now.
2318 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2319 (protect_malloc_state, align, get_contiguous_space)
2320 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2321 (malloc_atfork_handler_child, malloc_enable_thread)
2322 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2323 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2324 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2325 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2326 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2327 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2328 Define using prototypes, not old style.
2329 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2330 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2331 (align): Don't assume that signed integer overflow wraps around.
2332 Omit unused local var.
2333 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2334 (_free_internal_nolock, memalign, mallochook, reallochook):
2335 Omit no-longer-needed casts.
2336 (valloc): Use getpagesize, not __getpagesize.
2337 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2338 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2339
de85e130
PE
2340 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2341
dcbf5805
MA
23422012-04-22 Michael Albinus <michael.albinus@gmx.de>
2343
2344 Move functions from C to Lisp. Make non-blocking method calls
2345 the default. Implement further D-Bus standard interfaces.
2346
2347 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2348 (QCdbus_request_name_allow_replacement)
2349 (QCdbus_request_name_replace_existing)
2350 (QCdbus_request_name_do_not_queue)
2351 (QCdbus_request_name_reply_primary_owner)
2352 (QCdbus_request_name_reply_in_queue)
2353 (QCdbus_request_name_reply_exists)
2354 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2355 (QCdbus_registered_serial, QCdbus_registered_method)
2356 (QCdbus_registered_signal): New Lisp objects.
2357 (XD_DEBUG_MESSAGE): Use sizeof.
2358 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2359 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2360 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2361 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2362 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2363 (xd_signature, xd_append_arg): Allow float for integer types.
2364 (xd_get_connection_references): New function.
b593d6a9
AH
2365 (xd_get_connection_address): Rename from xd_initialize.
2366 Return cached address.
dcbf5805
MA
2367 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2368 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2369 level.
2370 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2371 Return number of refcounts.
dcbf5805
MA
2372 (Fdbus_get_unique_name): Make stronger parameter check.
2373 (Fdbus_message_internal): New defun.
2374 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2375 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2376 (Fdbus_send_signal, Fdbus_register_service)
2377 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2378 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2379 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2380 (Vdbus_compiled_version, Vdbus_runtime_version)
2381 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2382 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2383 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2384 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2385 Adapt docstring.
dcbf5805 2386
52828e02
PE
23872012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2388
da05bc4c
PE
2389 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2390 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2391 Do not assume ptrdiff_t is the same width as 'int'.
2392
52828e02
PE
2393 * alloc.c: Handle unusual debugging option combinations.
2394 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2395 since the two debugging options are incompatible.
2396 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2397 is defined.
2398 (mem_init, mem_insert, mem_insert_fixup):
2399 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2400 (NEED_MEM_INSERT): Remove; no longer needed.
2401
f01769f9
LL
24022012-04-22 Leo Liu <sdl.web@gmail.com>
2403
2404 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2405
5790543d
PE
24062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2407
2408 * sysdep.c [__FreeBSD__]: Minor cleanups.
2409 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2410 Use Emacs indenting style more consistently. Avoid some casts.
2411 Use 'double' consistently rather than mixing 'float' and 'double'.
2412
b91b7e4d
EW
24132012-04-21 Eduard Wiebe <usenet@pusto.de>
2414
b593d6a9
AH
2415 * sysdep.c (list_system_processes, system_process_attributes):
2416 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2417
6114eb15
AS
24182012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2419
2420 * lisp.mk (lisp): Update.
2421
2f38dff7
PE
24222012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2425 It is never used otherwise.
2426
4ae29f89
SM
24272012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2428
2429 * print.c (print_preprocess): Only check print_depth if print-circle
2430 is nil.
2431 (print_object): Check for cycles even when print-circle is nil and
2432 print-gensym is t, but only check print_depth if print-circle is nil.
2433
f30d612a
CY
24342012-04-20 Chong Yidong <cyd@gnu.org>
2435
2436 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2437 set the status to "failed" and ensure that sentinel is run.
2438
c07a4c0b 24392012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2440
2441 * process.c (Fset_process_inherit_coding_system_flag)
2442 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2443 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2444
c07a4c0b 24452012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2446
2447 * xdisp.c (string_buffer_position_lim): Limit starting position to
2448 BEGV.
2449 (set_cursor_from_row): If called for a mode-line or header-line
2450 row, return zero immediately.
2451 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2452 farther than the first row after the header line, if any.
2453 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2454 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2455
c07a4c0b 24562012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2457
4ae29f89
SM
2458 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2459 (bug#11238).
ad3a2b41 2460
c07a4c0b 24612012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 24622012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2463
2464 configure: new option --enable-gcc-warnings (Bug#11207)
2465 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2466 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2467 (ALL_CFLAGS): Use new macros rather than old.
2468 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2469 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2470 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2471 -Wunused-result, -Wunused-variable. This should go away once
2472 the Emacs and Gnulib regex code is merged.
2473 (xmalloc, xrealloc): Now static.
2474
aba027e8
PE
24752012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 * dired.c (Fsystem_groups): Remove unused local.
2478
e5a36063
GM
24792012-04-17 Glenn Morris <rgm@gnu.org>
2480
2481 * dired.c (Fsystem_users): Doc fix.
2482
316411f0
DA
24832012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2484
2485 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2486 (syms_of_dired): Add them.
2487
9426aba4
PE
24882012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2489
b62a57be
PE
2490 Fix minor alloc.c problems found by static checking.
2491 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2492 New extern decls, to avoid calling undeclared functions.
2493 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2494 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2495 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2496 (NEED_MEM_INSERT): New macro.
2497 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2498 Remove one incorrect comment and fix another.
b62a57be 2499
3539f31f
PE
2500 Fix minor ralloc.c problems found by static checking.
2501 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2502 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2503 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2504 (r_alloc_sbrk): Now static.
2505
a041960a
PE
2506 Improve ralloc.c interface checking.
2507 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2508 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2509 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2510 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2511 [REL_ALLOC]: ... to here, to check interface.
2512 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2513 Remove decls. This fixes an "It stinks!".
2514
9426aba4
PE
2515 * alloc.c (which_symbols): Fix alignment issue / type clash.
2516
d55c12ed
AS
25172012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2518
2519 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2520 (struct Lisp_Misc_Any): Likewise.
2521 (struct Lisp_Free): Likewise.
2522 * alloc.c (union aligned_Lisp_Symbol): Define.
2523 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2524 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2525 (union aligned_Lisp_Misc): Define.
2526 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2527 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2528 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2529
b948ce8b
PE
25302012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2531
2532 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2533 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2534 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2535 * s/netbsd.h, s/sol2-6.h:
2536 Remove definition of GC_MARK_STACK, since the default now works.
2537 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2538 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2539 no longer the default.
2540 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2541
35dc09a1 25422012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2543
35dc09a1
GM
2544 * lread.c (lisp_file_lexically_bound_p):
2545 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2546
35dc09a1
GM
25472012-04-14 Eli Zaretskii <eliz@gnu.org>
2548
2549 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2550 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2551
25522012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2553
2554 * nsterm.m (constrainFrameRect): Always constrain when there is only
2555 one screen (Bug#10962).
2556
bcd86815
KB
25572012-04-13 Ken Brown <kbrown@cornell.edu>
2558
2559 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2560
c25df26e
RT
25612012-04-13 Reuben Thomas <rrt@sc3d.org>
2562
2563 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2564
0fc59f1e
DC
25652012-04-11 Daniel Colascione <dancol@dancol.org>
2566
2567 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2568 against is gone. It's better to use vfork now so that when Cygwin
2569 gains a new, working vfork, we use it automatically (bug#10398).
2570
de8c03dc
SM
25712012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2572
2573 * window.c (save_window_save): Obey window-point-insertion-type.
2574
2f097256
GM
25752012-04-11 Glenn Morris <rgm@gnu.org>
2576
2577 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2578
453b951e
SM
25792012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2580
2581 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2582
75f1671a 25832012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2584
2585 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2586 (force_quit_count): New var.
2587 (handle_interrupt): Use it.
2588
2a8ce227
JB
25892012-04-10 Juanma Barranquero <lekktu@gmail.com>
2590
2591 * w32.c (w32_delayed_load): Record the full path of the library
2592 being loaded (bug#10424).
2593
935396c0
GM
25942012-04-09 Glenn Morris <rgm@gnu.org>
2595
05920a43
GM
2596 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2597 not just in the obarray, before snarfing them. (Bug#11036)
2598
935396c0
GM
2599 * Makefile.in ($(leimdir)/leim-list.el):
2600 Pass EMACS rather than BUILT_EMACS.
2601
a18ecafa
TZ
26022012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2603
2604 * process.c (make_process):
2605 * process.h: Add integer `gnutls_handshakes_tried' member to
2606 process struct.
2607
6bbef4e5
JC
2608 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2609 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2610
2611 * gnutls.c (gnutls_log_function2i): Convenience log function.
2612 (emacs_gnutls_read): Use new log functions,
2613 `gnutls_handshakes_tried' process member, and
2614 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2615 attempts per process (connection).
2616
b4d3bc10
CY
26172012-04-09 Chong Yidong <cyd@gnu.org>
2618
2619 * eval.c (Fuser_variable_p, user_variable_p_eh)
2620 (lisp_indirect_variable): Functions deleted.
2621 (Fdefvar): Caller changed.
2622
2623 * callint.c (Finteractive, Fcall_interactively):
2624 * minibuf.c (Fread_variable): Callers changed.
2625
70f4d973
EZ
26262012-04-09 Eli Zaretskii <eliz@gnu.org>
2627
2628 * xdisp.c (set_cursor_from_row): If the display string appears in
2629 the buffer at position that is closer to point than the position
2630 after the display string, display the cursor on the first glyph of
2631 the display string. Fixes cursor display when a 'display' text
2632 property immediately follows invisible text. (Bug#11094)
2633
cb3c2e3e
PE
26342012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2635
2636 composite.c: use 'double' consistently
2637 * composite.c (get_composition_id): Use 'double' consistently
2638 instead of converting 'float' to 'double' and vice versa; this is
2639 easier to understand and avoids a GCC warning.
2640
fd06db5d
GM
26412012-04-09 Glenn Morris <rgm@gnu.org>
2642
50fe702a
GM
2643 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2644 preparation for dumping it with emacs. (Bug#4789)
2645 (leimdir): New variable.
2646 ($(leimdir)/leim-list.el): New rule.
2647 (emacs$(EXEEXT)): Depend on leim-list.el.
2648
fd06db5d
GM
2649 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2650 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2651 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2652
55c131ee
AS
26532012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2654
2655 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2656 proper alignment.
2657
9209588f
JB
26582012-04-07 Juanma Barranquero <lekktu@gmail.com>
2659
2660 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2661 Remove unused local variable.
2662
e3fb2efb
PE
26632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2664
2665 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2666 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2667 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2668 objects, as mark_maybe_pointer will catch them otherwise.
2669 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2670 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2671
b5385551
PE
26722012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 Fix typo that broke non-Windows builds.
2675 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2676
9078ead6
EZ
26772012-04-07 Eli Zaretskii <eliz@gnu.org>
2678
2679 Support building on MS-Windows with libxml2.
2680
2681 * makefile.w32-in (OBJ2): Add xml.$(O).
2682 (GLOBAL_SOURCES): Add xml.c.
2683 ($(BLD)/xml.$(O)): New dependency list.
2684
2685 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2686 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2687 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2688 [!WINDOWSNT]: New macros.
2689 (init_libxml2_functions, libxml2_loaded_p): New functions.
2690 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2691 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2692 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2693 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2694 linked in).
6bbef4e5
JC
2695 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2696 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2697 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2698
2699 * emacs.c: Don't include libxml/parser.h.
2700 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2701 xmlCleanupParser directly.
2702
2703 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2704
3811fdf3
EZ
27052012-04-07 Eli Zaretskii <eliz@gnu.org>
2706
2707 * indent.c (Fvertical_motion): If there is a display string at
2708 point, use it.vpos to compute how many lines to backtrack after
2709 move_it_to point. (Bug#11133)
2710
2f8e16b2
EZ
27112012-04-06 Eli Zaretskii <eliz@gnu.org>
2712
2713 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2714 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2715 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2716 macros related to unification of CJK characters. For the details,
2717 see the discussion following the message here:
2718 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2719
3d439cd1
CY
27202012-04-04 Chong Yidong <cyd@gnu.org>
2721
2722 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2723
8bc53d00
EZ
27242012-04-01 Eli Zaretskii <eliz@gnu.org>
2725
2726 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2727 instead of alloca. (Bug#11138)
2728
3b0512a3
AS
27292012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2730
2731 * w32menu.c (is_simple_dialog): Properly check lisp types.
2732 (Bug#11141)
2733
8427ddd2
EZ
27342012-03-31 Eli Zaretskii <eliz@gnu.org>
2735
979022ef
EZ
2736 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2737 position we get to after a call to move_it_to fails the
2738 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2739 only if we wind up in a string from display property. (Bug#11063)
2740
a6b1c7cc
EZ
2741 * window.c (Fdelete_other_windows_internal): Invalidate the row
2742 and column information about mouse highlight, so that redisplay
2743 restores it after reallocating the glyph matrices. (Bug#7464)
2744
8427ddd2
EZ
2745 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2746 string comes from a `display' text property, use the buffer
2747 position of that property as if we actually saw that position in
2748 the row's glyphs.
697ba24b
EZ
2749 (move_it_by_lines): Remove the assertion that
2750 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2751 violated when there's a before-string at the beginning of a line.
2752 (Bug#11063)
8427ddd2 2753
65a0a738
EZ
27542012-03-30 Eli Zaretskii <eliz@gnu.org>
2755
2756 * xdisp.c (append_space_for_newline): If the default face was
2757 remapped, use the remapped face for the appended newline.
2758 (extend_face_to_end_of_line): Use the remapped default face for
2759 extending the face to the end of the line.
2760 (display_line): Call extend_face_to_end_of_line when the default
2761 face was remapped. (Bug#11068)
2762
581355cc
EZ
27632012-03-29 Eli Zaretskii <eliz@gnu.org>
2764
2765 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2766
e8fc049f
SM
27672012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2768
2769 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2770
4fb9a543
GM
27712012-03-27 Glenn Morris <rgm@gnu.org>
2772
2773 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2774 Doc fixes.
2775
679910f1
KH
27762012-03-26 Kenichi Handa <handa@m17n.org>
2777
2778 * dispextern.h (struct glyph): Fix previous change. Change the
2779 bit length of glyphless.ch to 25 (Bug#11082).
2780
90d49b7f
CY
27812012-03-26 Chong Yidong <cyd@gnu.org>
2782
2783 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2784 (command_loop_1): Use it; inhibit selection update for
2785 handle-select-window too (Bug#8996).
2786
f514f6f0
FP
27872012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2788
e8fc049f 2789 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2790
bf43fa51
KH
27912012-03-25 Kenichi Handa <handa@m17n.org>
2792
2793 * dispextern.h (struct glyph): Change the bit length of
2794 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2795
8a0c01dd
EZ
27962012-03-24 Eli Zaretskii <eliz@gnu.org>
2797
2798 * s/ms-w32.h (tzname): Include time.h before redirecting to
2799 _tzname. Fixes the MSVC build. (Bug#9960)
2800
7d1c3a76
AS
28012012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2802
8ed79523
AS
2803 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2804 characters.
2805
7d1c3a76
AS
2806 * xterm.c (XTread_socket): Only modify handling_signal if
2807 !SYNC_INPUT. (Bug#11080)
2808
e99a9b8b
EZ
28092012-03-23 Eli Zaretskii <eliz@gnu.org>
2810
2811 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2812 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2813 when fetching a multibyte character consumes more bytes than
2814 CHAR_BYTES returns, due to unification of CJK characters in
2815 string_char. (Bug#11073)
2816
5063c0e1
TN
28172012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2818
2819 * process.c (wait_reading_process_output): Handle pty disconnect
2820 by refraining from sending oneself a SIGCHLD (bug#10933).
2821
9f851fbd
CY
28222012-03-22 Chong Yidong <cyd@gnu.org>
2823
2824 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2825
5063c0e1 2826 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2827 Mark string as coming from a prefix property.
2828 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2829 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2830
fb5b8aca
CY
28312012-03-21 Chong Yidong <cyd@gnu.org>
2832
2833 * xfaces.c (Vface_remapping_alist): Doc fix.
2834
62356a1b
EZ
28352012-03-20 Eli Zaretskii <eliz@gnu.org>
2836
2837 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2838 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2839 Doc fixes.
62356a1b 2840
025de85b
CY
28412012-03-20 Chong Yidong <cyd@gnu.org>
2842
2843 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2844 to reflect default non-nil value of redisplay-dont-pause.
2845
4827f94e
KH
28462012-03-19 Kenichi Handa <handa@m17n.org>
2847
2848 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2849 it fit in a valid range (Bug#11003).
2850
e50a24a2
EZ
28512012-03-18 Eli Zaretskii <eliz@gnu.org>
2852
2853 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2854 that is not from display property, accept the row as a "cursor
2855 row" if one of the string's character has a non-nil `cursor'
2856 property. Fixes cursor positioning when there are newlines in
2857 overlay strings, e.g. in icomplete.el. (Bug#11035)
2858
9af5ed87
PE
28592012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2862
d1f55f16
CY
28632012-03-12 Chong Yidong <cyd@gnu.org>
2864
2865 * eval.c (inhibit_lisp_code): Rename from
2866 inhibit_window_configuration_change_hook; move from window.c.
2867
2868 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2869 * window.c (run_window_configuration_change_hook)
2870 (syms_of_window): Callers changed.
2871
66c5eebd
CY
28722012-03-11 Chong Yidong <cyd@gnu.org>
2873
413df973
CY
2874 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2875
66c5eebd
CY
2876 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2877
1de11f56
CY
28782012-03-10 Chong Yidong <cyd@gnu.org>
2879
2880 * frame.c (other_visible_frames): Don't assume the selected frame
2881 is visible (Bug#10955).
2882
cae07000
SM
28832012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2884
2885 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2886
89c94350
JD
28872012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2888
2889 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2890 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2891 zero (Bug#10954).
2892
999dd333
GM
28932012-03-03 Glenn Morris <rgm@gnu.org>
2894
01a6dcc8 2895 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2896
de0100f2
EZ
28972012-03-02 Eli Zaretskii <eliz@gnu.org>
2898
2899 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2900 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2901 (redisplay_window, next_element_from_string): Fix typos in
2902 comments.
3e441275
EZ
2903 (redisplay_window): Pass to move_it_vertically the margin in
2904 pixels, not in screen lines.
de0100f2 2905
96a72ee9
GM
29062012-03-02 Glenn Morris <rgm@gnu.org>
2907
2908 * buffer.c (buffer-list-update-hook): Doc fix.
2909
312508d7
EZ
29102012-02-29 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2913 push_it before setting up the iterator for the first overlay
2914 string, even if we have an empty string loaded.
2915 (next_overlay_string): If there's an empty string on the iterator
2916 stack, pop the stack. (Bug#10903)
2917
27f3c637
PE
29182012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2919
2920 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2921 Suggested by Stefan Monnier in
2922 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2923 * alloc.c (widen_to_Lisp_Object): New static function.
2924 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2925 and widening them to Lisp_Objects. This would work even if
2926 USE_LSB_TAG is defined and wide integers are used, which might
2927 happen in a future version of Emacs.
2928
3c9dfce6
CY
29292012-02-25 Chong Yidong <cyd@gnu.org>
2930
fa74b241
CY
2931 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2932 Doc fix.
2933
3c9dfce6
CY
2934 * xselect.c (Fx_selection_exists_p): Doc fix.
2935 (x_clipboard_manager_save_all): Print an informative message
2936 before saving to clipboard manager.
2937
9486df08
CY
29382012-02-24 Chong Yidong <cyd@gnu.org>
2939
2940 * keyboard.c (process_special_events): Handle all X selection
2941 requests in kbd_buffer, not just the next one (Bug#8869).
2942
f01d3321
CY
29432012-02-23 Chong Yidong <cyd@gnu.org>
2944
2945 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2946 call when setting menu-bar-lines and tool-bar-lines parameters.
2947 (unwind_create_frame_1): New helper function.
2948
2949 * window.c (inhibit_window_configuration_change_hook): New var.
2950 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2951 (syms_of_window): Initialize it.
f01d3321 2952
86b847b6
CY
29532012-02-22 Chong Yidong <cyd@gnu.org>
2954
2955 * xterm.c (x_draw_image_relief): Add missing type check for
2956 Vtool_bar_button_margin (Bug#10743).
2957
a59225b1
CY
29582012-02-21 Chong Yidong <cyd@gnu.org>
2959
2960 * fileio.c (Vfile_name_handler_alist): Doc fix.
2961
2962 * buffer.c (Fget_file_buffer): Protect against invalid file
2963 handler return value.
2964
310f5bd4
PE
29652012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2966
cb3a28cc
PE
2967 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2968 when computing $valmask.
2969
310f5bd4
PE
2970 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2971 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2972 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2973 It's useless in that case, and it can cause problems on hosts
2974 that allocate halves of EMACS_INT values separately.
2975 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2976 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2977 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2978 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2979 it avoids undefined behavior on hosts where shifting right by more
2980 than the word width has undefined behavior.
2981
2375c96a
CY
29822012-02-19 Chong Yidong <cyd@gnu.org>
2983
2984 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2985 (Funhandled_file_name_directory, Ffile_name_as_directory)
2986 (Fdirectory_file_name, Fexpand_file_name)
2987 (Fsubstitute_in_file_name): Protect against invalid file handler
2988 return values (Bug#10845).
2989
3eb49e71
EZ
29902012-02-18 Eli Zaretskii <eliz@gnu.org>
2991
2992 * .gdbinit (pitx): Fix incorrect references to fields of the
2993 iterator stack.
2994
7b926f3f
CY
29952012-02-17 Chong Yidong <cyd@gnu.org>
2996
2997 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2998
11273115
PE
29992012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3002 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3003
c3a70e2b
CY
30042012-02-15 Chong Yidong <cyd@gnu.org>
3005
3006 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3007 marked as special. Also, starting docstrings with * is obsolete.
3008
0ca43699
AS
30092012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3010
3011 * gnutls.c (emacs_gnutls_write): Fix last change.
3012
2e8f3c56
LI
30132012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3014
3015 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3016 send_process.
3017
af70074f
SM
30182012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3019
3020 * keymap.c (Fsingle_key_description): Handle char ranges.
3021
95986d52
CY
30222012-02-12 Chong Yidong <cyd@gnu.org>
3023
afd83bd1
CY
3024 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3025 as that creates a dangerous corner case.
3026
95986d52
CY
3027 * window.c (Fdelete_window_internal): Invalidate the mouse
3028 highlight (Bug#9904).
3029
bd7da63e
GM
30302012-02-12 Glenn Morris <rgm@gnu.org>
3031
3032 * xselect.c (Fx_own_selection_internal)
3033 (Fx_get_selection_internal, Fx_disown_selection_internal)
3034 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3035 * nsselect.m (Fx_own_selection_internal)
3036 (Fx_disown_selection_internal, Fx_selection_exists_p)
3037 (Fx_selection_owner_p, Fx_get_selection_internal):
3038 Sync docs and argument specs with the xselect.c versions.
3039
77abcbc2
LI
30402012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3041
3042 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3043
90b671e2
EZ
30442012-02-11 Eli Zaretskii <eliz@gnu.org>
3045
1c0ca0b7
EZ
3046 * w32select.c (Fx_selection_exists_p): Sync doc string and
3047 argument list with xselect.c. (Bug#10783)
3048
3049 * w16select.c (Fx_selection_exists_p): Sync doc string and
3050 argument list with xselect.c. (Bug#10783)
90b671e2 3051
49241268
GM
30522012-02-10 Glenn Morris <rgm@gnu.org>
3053
3054 * fns.c (Fsecure_hash): Doc fix.
3055
f998bbe7 30562012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3057
3058 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3059
0992bd9c
CY
30602012-02-07 Chong Yidong <cyd@gnu.org>
3061
3062 * buffer.c (Fbuffer_local_variables)
3063 (buffer_lisp_local_variables): Handle unbound vars correctly;
3064 don't let Qunbound leak into Lisp.
3065
af008560
GM
30662012-02-07 Glenn Morris <rgm@gnu.org>
3067
dd605cc4
GM
3068 * image.c (Fimagemagick_types): Doc fix.
3069
af008560
GM
3070 * image.c (imagemagick-render-type): Change it from a lisp object
3071 to an integer. Move the doc here from the lisp manual.
3072 Treat all values not equal to 0 the same.
3073
1449fa1d
CY
30742012-02-06 Chong Yidong <cyd@gnu.org>
3075
3076 * doc.c (store_function_docstring): Avoid applying docstring of
3077 alias to base function (Bug#2603).
3078
3723ec07
AS
30792012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3080
3081 * .gdbinit (pp1, pv1): Remove redundant defines.
3082 (pr): Use pp.
3083
79c1cc1e
CY
30842012-02-04 Chong Yidong <cyd@gnu.org>
3085
3086 * nsterm.m: Declare a global (Bug#10694).
3087
d7f29f8e
EZ
30882012-02-04 Eli Zaretskii <eliz@gnu.org>
3089
cae07000
SM
3090 * w32.c (get_emacs_configuration_options):
3091 Include --enable-checking, if specified, in the return value.
d7f29f8e 3092
3b95a6f9
MR
30932012-02-04 Martin Rudalics <rudalics@gmx.at>
3094
3095 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3096 after rounding frame sizes. (Bug#9723)
3097
d6fa96a6
EZ
30982012-02-04 Eli Zaretskii <eliz@gnu.org>
3099
3100 * keyboard.c (adjust_point_for_property): Don't position point
3101 before BEGV. (Bug#10696)
3102
df0b2940
PE
31032012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 Handle overflow when computing char display width (Bug#9496).
3106 * character.c (char_width): Return EMACS_INT, not int.
3107 (char_width, c_string_width): Check for overflow when
3108 computing the width; this is possible now that individual
3109 characters can have unbounded width. Problem introduced
3110 by merge from Emacs 23 on 2012-01-19.
3111
6bee44d6
MA
31122012-02-02 Michael Albinus <michael.albinus@gmx.de>
3113
3114 * dbusbind.c (Fdbus_register_method): Mention the return value
3115 :ignore in the docstring.
3116
44f92739
GM
31172012-02-02 Glenn Morris <rgm@gnu.org>
3118
1b9f60cc
GM
3119 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3120
44f92739
GM
3121 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3122 Unconditionally set to t. (Bug#10673)
3123 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3124 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3125 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3126
c5d3843c
KH
31272012-02-02 Kenichi Handa <handa@m17n.org>
3128
3129 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3130 0, do not call append_composite_glyph.
3131
159462d4 31322012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3133
3134 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3135 NULL (Bug#6988).
3136 (x_produce_glyphs): If the component of a composition is a null
3137 string, set it->pixel_width to 1 to avoid zero-width glyph.
3138
78cef877
EZ
31392012-02-01 Eli Zaretskii <eliz@gnu.org>
3140
3141 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3142 first 2 arguments are identical. This makes inserting large
3143 output from a subprocess an order of magnitude faster on
3144 MS-Windows, where all sbrk'ed memory is always contiguous.
3145
97897668
GM
31462012-01-31 Glenn Morris <rgm@gnu.org>
3147
3148 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3149 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3150 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3151
31fd3586
GM
31522012-01-29 Glenn Morris <rgm@gnu.org>
3153
3154 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3155
0e24a8b2
CY
31562012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3157
3158 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3159
cc0adcb0
CY
31602012-01-28 Chong Yidong <cyd@gnu.org>
3161
3162 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3163
acc28cb9
CY
31642012-01-26 Chong Yidong <cyd@gnu.org>
3165
9c69cfb7
CY
3166 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3167
acc28cb9
CY
3168 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3169 repeat counts (Bug#10507).
3170
48da7392
GM
31712012-01-26 Glenn Morris <rgm@gnu.org>
3172
3173 * lread.c (syms_of_lread): Doc fix.
3174
14af5f7f
CY
31752012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3176
3177 * coding.c (encode_designation_at_bol): Change return value to
3178 EMACS_INT.
3179
0b21c100
CY
31802012-01-25 Chong Yidong <cyd@gnu.org>
3181
3182 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3183
3c2907f7
CY
31842012-01-21 Chong Yidong <cyd@gnu.org>
3185
3186 * floatfns.c (Fcopysign): Make the second argument non-optional,
3187 since nil is not allowed anyway.
3188
959ad23f
AS
31892012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3190
3191 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3192 (send_process): Likewise.
3193
34a02f46
MR
31942012-01-19 Martin Rudalics <rudalics@gmx.at>
3195
3196 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3197 (Vwindow_persistent_parameters): Do not use Qstate.
3198 Rewrite doc-strings.
34a02f46 3199
1259009a 32002012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3201
3202 * character.c (char_width): New function.
70d4fdf6
GM
3203 (Fchar_width, c_string_width, lisp_string_width):
3204 Use char_width (Bug#9496).
25ed9e61 3205
6a6ee00d
MR
32062012-01-16 Martin Rudalics <rudalics@gmx.at>
3207
3208 * window.c (Vwindow_persistent_parameters): New variable.
3209 (Fset_window_configuration, save_window_save): Handle persistent
3210 window parameters.
3211
c85efaf7
EZ
32122012-01-14 Eli Zaretskii <eliz@gnu.org>
3213
3214 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3215 thrashing the stack of the thread. (Bug#9087)
3216
5944709e
PE
32172012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3218
3219 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3220
e71f5d99
EZ
32212012-01-11 Eli Zaretskii <eliz@gnu.org>
3222
3223 * xdisp.c (rows_from_pos_range): Handle the case where the
3224 highlight ends on a newline. (Bug#10464)
3225 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3226 he end column for display of highlight that ends on a newline
3227 before a R2L line.
3228
ce316182
GM
32292012-01-11 Glenn Morris <rgm@gnu.org>
3230
3231 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3232 from load-path also when installation-directory is nil. (Bug#10208)
3233
5b43da69
GM
32342012-01-10 Glenn Morris <rgm@gnu.org>
3235
74cc8ff9
GM
3236 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3237
7d8d6e4e
GM
3238 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3239 Update template values to be closer to their typical values these days.
5b43da69 3240
a0db8d43
EZ
32412012-01-09 Eli Zaretskii <eliz@gnu.org>
3242
3243 * xdisp.c (rows_from_pos_range): Accept additional argument
3244 DISP_STRING, and accept any glyph in a row whose object is that
3245 string as eligible for mouse highlight. Fixes mouse highlight of
3246 display strings from overlays. (Bug#10464)
3247
9a0115ab 32482012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3249
b9110d6a 3250 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3251 * fileio.c (auto_saving_dir_umask): New static var.
3252 (Fmake_directory_internal): Use it.
3253 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3254 creating the directory. The old code temporarily assigns
3255 too-generous permissions to the directory.
3256 (do_auto_save_eh): Clear it.
b9110d6a 3257 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3258 that the var is always cleared.
3259
6c1bd3f3
EZ
32602012-01-07 Eli Zaretskii <eliz@gnu.org>
3261
3262 * search.c (scan_buffer): Pass character positions to
3263 know_region_cache, not byte positions. (Bug#6540)
3264
069d2b50
L
32652012-01-07 LynX <_LynX@bk.ru> (tiny change)
3266
3267 * w32.c (sys_rename): Report EXDEV when rename of a directory
3268 fails because the target is on another logical disk. (Bug#10284)
3269
75bf0d33
DB
32702012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3271
3272 * xterm.c (x_embed_request_focus): New function.
3273
3274 * xterm.h: Add prototype.
3275
3276 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3277
1c6e5a32
GM
32782012-01-05 Glenn Morris <rgm@gnu.org>
3279
3280 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3281
651e947e
EZ
32822012-01-01 Eli Zaretskii <eliz@gnu.org>
3283
3284 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3285 Load gnutls_transport_set_lowat only if GnuTLS version is below
3286 2.11.1.
3287 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3288 GnuTLS versions below 2.11.1.
3289
3778cdd8
AL
32902011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3291
3292 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3293 to the doc string advising against its use for altering the way
3294 windows are scrolled.
3295
0e5317f7
KH
32962011-12-28 Kenichi Handa <handa@m17n.org>
3297
3298 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3299 coding-system ASCII compatible only when it does not produce BOM
3300 on encoding (Bug#10383).
3301
93d5ca1f
JD
33022011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3303
3304 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3305 can scroll.
3306 (create_and_show_popup_menu): Always use menu_position_func for
3307 Gtk3 (Bug#10361).
3308
ca22b785
AS
33092011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3310
3311 * callint.c (Fcall_interactively): Don't truncate prompt string.
3312
d048e1e6
EZ
33132011-12-23 Eli Zaretskii <eliz@gnu.org>
3314
3315 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3316 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3317 resumed from there (after widening). (Bug#10360)
d048e1e6 3318
5ccaba1f
JD
33192011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3320
3321 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3322
204ee57f
JD
33232011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3324
b81d40f0
JB
3325 * nsterm.m (x_free_frame_resources):
3326 Release f->output_data.ns->miniimage.
204ee57f
JD
3327 (ns_index_color): Fix indentation. Do not retain
3328 color_table->colors[i].
3329
3330 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3331 before returning.
3332
3333 * nsfns.m (x_set_background_color): Assign return value from
3334 ns_index_color to face-background instead of NSColor*.
3335 (ns_implicitly_set_icon_type): Fix indentation.
3336 Change assignment in for loop to comparison.
3337
3338 * emacs.c (ns_pool): New variable.
3339 (main): Assign ns_pool.
3340 (Fkill_emacs): Call ns_release_autorelease_pool.
3341
3342 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3343 autorelease fdesc, release fdAttrs and tdict.
3344 (ns_get_covering_families): Release charset.
3345 (ns_findfonts): Release NSFontDescriptor created with new.
3346 (ns_uni_to_glyphs): Fix indentation.
3347 (setString): Release attrStr before assigning new value.
3348
c803b2b7
JD
33492011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3350
678f4426
JD
3351 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3352 and NS_IMPL_COCOA.
3353 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3354 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3355
cd394be1 33562011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3357
5fecd5fc
JD
3358 * nsterm.m (ns_term_init): Subscribe for notifications
3359 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3360 to method trackingNotification in EmacsMenu.
3361
3362 * nsmenu.m (trackingMenu): New variable.
3771cb17 3363 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3364 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3365 from Aquamacs (Bug#7030).
678f4426
JD
3366
33672011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3368
c803b2b7
JD
3369 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3370 (symbol_to_nsstring): Fix indentation.
3371 (ns_symbol_to_pb): New function.
cae07000
SM
3372 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3373 (Fns_rotate_cut_buffers_internal): Remove.
3374 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3375 Fns_store_cut_buffer_internal.
3376 (ns_get_foreign_selection, Fx_own_selection_internal)
3377 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3378 (Fns_get_selection_internal, Fns_store_selection_internal):
3379 Use ns_symbol_to_pb and check if return value is nil.
3380 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3381 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3382 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3383 renamed to Sns_store_selection_internal.
3384 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3385 and remove this function.
3386 (ns_handle_selection_clear): Remove, never used.
3387 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3388 here.
3389
e1b01a3a
KB
33902011-12-17 Ken Brown <kbrown@cornell.edu>
3391
3392 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3393 GID is unknown (Bug#10257).
3394
2adb6e85
PE
33952011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3398 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3399 which caused a build failure on GNU/Linux IA-64. This problem was
3400 introduced by my 2011-10-07 patch.
3401
d1d7b339
JL
34022011-12-15 Juri Linkov <juri@jurta.org>
3403
3404 * image.c (imagemagick_error): New function. (Bug#10112)
3405 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3406 Use `imagemagick_error' where ImageMagick functions return
3407 `MagickFalse'.
3408 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3409 proper order.
3410
100d5755
KH
34112011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3412
3413 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3414 fill background (Bug#8992).
3415
454592a6
MR
34162011-12-13 Martin Rudalics <rudalics@gmx.at>
3417
3418 * window.c (Vwindow_combination_resize)
3419 (Vwindow_combination_limit): Use t instead of non-nil in
3420 doc-strings.
61d4b438
MR
3421 (Vrecenter_redisplay): Add first sentence of doc-string on
3422 separate line.
53524d93 3423 (Frecenter): Fix doc-string typo.
454592a6 3424
3633e3aa
KH
34252011-12-11 Kenichi Handa <handa@m17n.org>
3426
3427 * coding.c (Funencodable_char_position): Pay attention to the
3428 buffer text relocation (Bug#9389).
3429
7b9d523a 34302011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3431
7b9d523a
JD
3432 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3433 gtk_init (Bug#10100).
3434
b73189c6
EZ
34352011-12-10 Eli Zaretskii <eliz@gnu.org>
3436
3437 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3438 IT->string is nil. (Bug#10263)
3439
f7dfe5d6
JD
34402011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3441
83faebb4
JD
3442 * nsterm.h (x_free_frame_resources): Declare.
3443
f7dfe5d6
JD
3444 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3445 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3446
3447 * nsterm.h (ns_get_defaults_value): Declare.
3448
3449 * nsterm.m (ns_default): Call ns_get_defaults_value.
3450
7cd4e72c
EZ
34512011-12-09 Eli Zaretskii <eliz@gnu.org>
3452
3453 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3454 (Bug#10170)
3455
b34d7317
YM
34562011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3457
3458 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3459 that where the value of an _OBJC_* symbol points to is in the .bss
3460 section (Bug#10240).
3461
76470ad1
KH
34622011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3463
3464 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3465 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3466
745fff94
KH
34672011-12-08 Kenichi Handa <handa@m17n.org>
3468
3469 * ftfont.c (get_adstyle_property): Fix previous change
3470 (Bug#10233).
3471
6e44397c
JB
34722011-12-07 Juanma Barranquero <lekktu@gmail.com>
3473
3474 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3475 dirs from the default value of EMACSLOADPATH (bug#10208).
3476
7efa6272
GM
34772011-12-07 Glenn Morris <rgm@gnu.org>
3478
3479 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3480 installation and source directories as well. (Bug#10208)
3481
f6fc4d87
CY
34822011-12-06 Chong Yidong <cyd@gnu.org>
3483
3484 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3485
2bf26180
GM
34862011-12-06 Glenn Morris <rgm@gnu.org>
3487
3488 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3489 as an error, not just -1. (Bug#10217)
3490
3a6ad4f0
CY
34912011-12-05 Chong Yidong <cyd@gnu.org>
3492
3493 * keyboard.c (process_special_events): New function.
3494 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3495
75a3b399
PE
34962011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3497
3498 * coding.c (encode_designation_at_bol): Don't use uninitialized
3499 local variable (Bug#9318).
3500
c3c9e25e
KH
35012011-12-05 Kenichi Handa <handa@m17n.org>
3502
3503 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3504 return Qnil (Bug#8046, Bug#10193).
3505
5eb05ea3
KH
35062011-12-05 Kenichi Handa <handa@m17n.org>
3507
3508 * coding.c (encode_designation_at_bol): New args charbuf_end and
3509 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3510 (coding_set_source): Return how many bytes coding->source was
3511 relocated.
3512 (coding_set_destination): Return how many bytes
3513 coding->destination was relocated.
3514 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3515 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3516
35172011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3518
3519 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3520 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3521 macro (Bug#9318).
3522
35232011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3524
3525 The following changes are to fix Bug#9318.
3526
a79703f5 3527 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3528 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3529 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3530 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3531
7dbda6df
JB
35322011-12-05 Juanma Barranquero <lekktu@gmail.com>
3533
3534 * lisp.h (process_quit_flag): Fix external declaration.
3535
6d5eb5b0
SM
35362011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3537
3538 Don't macro-inline non-performance-critical code.
3539 * eval.c (process_quit_flag): New function.
3540 * lisp.h (QUIT): Use it.
3541
a0c3fad0
JD
35422011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3543
3544 * nsfns.m (get_geometry_from_preferences): New function.
3545 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3546
6c07aac2
AS
35472011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3548
3549 * emacs.c (Qkill_emacs): Define.
3550 (syms_of_emacs): Initialize it.
3551 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3552 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3553 (quit_throw_to_read_char): Add parameter `from_signal'.
3554 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3555 * lisp.h (QUIT): Call Fkill_emacs if requested.
3556
c052ead4
JD
35572011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3558
3559 * widget.c (update_wm_hints): Return if wmshell is null.
3560 (widget_update_wm_size_hints): New function.
3561
3562 * widget.h (widget_update_wm_size_hints): Declare.
3563
3564 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3565 widget_update_wm_size_hints (Bug#10104).
3566
9e49252b
EZ
35672011-12-03 Eli Zaretskii <eliz@gnu.org>
3568
3569 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3570 before a newline, prepare the bidi iterator for consuming the
3571 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3572 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3573
02b16839
JL
35742011-12-02 Juri Linkov <juri@jurta.org>
3575
3576 * search.c (Fword_search_regexp): New Lisp function created from
3577 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3578 (Fword_search_backward, Fword_search_forward)
3579 (Fword_search_backward_lax, Fword_search_forward_lax):
3580 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3581 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3582
0068070e
SM
35832011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3584
3585 * fileio.c (Finsert_file_contents): Move after-change-function call
3586 to before the "handled:" label, since all "goto handled" appear in
3587 cases where the *-change-functions have already been properly called
3588 (bug#10117).
3589
3360a3fc
AS
35902011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3591
3592 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3593 waiting for input. (Bug#10169)
3594
73d6c093
EZ
35952011-11-30 Eli Zaretskii <eliz@gnu.org>
3596
3597 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3598 verifies glyph row's hash code--we have just reallocated the
3599 glyphs, so their contents can be complete garbage. (Bug#10164)
3600
febe6bea
JB
36012011-11-30 Juanma Barranquero <lekktu@gmail.com>
3602
3603 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3604
801a4313
EZ
36052011-11-30 Eli Zaretskii <eliz@gnu.org>
3606
3607 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3608 attributes are tested _before_ calling verify_row_hash, to protect
3609 against GCC re-ordering of the tests. (Bug#10164)
3610
2b56b87e
JD
36112011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3612
3613 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3614
3615 * xterm.c (handle_one_xevent): Only set async_visible and friends
3616 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3617 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3618 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3619
dbf31225
PE
36202011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3623 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3624 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3625 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3626 All uses changed to use GCPRO1 etc.
3627 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3628 Revert to old implementation (i.e., before 2011-03-11).
3629
1305621b
YM
36302011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3631
3632 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3633 of scroll runs so as to avoid assigning disabled bogus rows and
3634 unnecessary graphics copy operations.
3635
8c9afb46
EZ
36362011-11-27 Eli Zaretskii <eliz@gnu.org>
3637
3638 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3639 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3640 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3641 (malloc, free, realloc, calloc): Redirect to e_* only when
3642 compiling Emacs.
3643
3644 * lisp.h (GCTYPEBITS): Move before first use.
3645 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3646 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3647 this macro definition.
3648
3649 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3650 _MSC_VER.
3651
54e9e3bf
JD
36522011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3653
6d5eb5b0
SM
3654 * gtkutil.c (xg_create_frame_widgets):
3655 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3656 present with Gtk+ 2.0.
3657
83aca1cb
PE
36582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3659
3660 * fileio.c (Finsert_file_contents): Undo previous change; see
3661 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3662
5b76caa4
PE
36632011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3664
3665 Rename locals to avoid shadowing.
3666 * fileio.c (Finsert_file_contents):
3667 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3668 * process.c (wait_reading_process_output):
3669 Rename inner 'proc' to 'p' to avoid shadowing.
3670 Indent for consistency with usual Emacs style.
3671
8c535114
EZ
36722011-11-25 Eli Zaretskii <eliz@gnu.org>
3673
3674 * xdisp.c (redisplay_window): If cursor row is not fully visible
3675 after recentering, and scroll-conservatively is set to a large
3676 number, scroll window by a few more lines to make the cursor fully
3677 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3678 (start_display): Don't move to the next line if the display should
3679 start at a newline that is part of a display vector or an overlay
3680 string. (Bug#10119)
8c535114 3681
fa4fdb5c
JL
36822011-11-24 Juri Linkov <juri@jurta.org>
3683
3684 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3685 after the `MagickPingImage' call. (Bug#10112)
3686
90ec88df
CY
36872011-11-23 Chong Yidong <cyd@gnu.org>
3688
3689 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3690
56e2e794
MR
36912011-11-23 Martin Rudalics <rudalics@gmx.at>
3692
3693 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3694 making another buffer current. (Bug#10114)
3695
b6e64c41
GM
36962011-11-23 Glenn Morris <rgm@gnu.org>
3697
3698 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3699
6b21de18
CY
37002011-11-23 Chong Yidong <cyd@gnu.org>
3701
3702 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3703 using it (Bug#5984).
3704
b12cd789
EZ
37052011-11-22 Eli Zaretskii <eliz@gnu.org>
3706
3707 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3708 and header-lines, as they don't have one computed for them.
3709 (Bug#10098)
3710
3711 * .gdbinit (prow): Make displayed values more self-explaining.
3712 Add row's hash code.
3713
261b6fd4
LMI
37142011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3715
3716 * process.c (wait_reading_process_output): Fix asynchrounous
3717 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3718 (wait_reading_process_output): Add comment and URL.
261b6fd4 3719
e7cfd277
JD
37202011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3721
3722 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3723
a9b9b7f5
CY
37242011-11-21 Chong Yidong <cyd@gnu.org>
3725
3726 * window.c (Fnext_window, Fprevious_window): Doc fix.
3727
b0d15b4f
SM
37282011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3729
3730 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3731
fe7a3057
JB
37322011-11-20 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3735
d2999b1a
MR
37362011-11-20 Martin Rudalics <rudalics@gmx.at>
3737
3738 * window.c (Fset_window_combination_limit): Rename argument
3739 STATUS to LIMIT.
3740 (Vwindow_combination_limit): Remove "status" from doc-string.
3741
d5ff9cd0
AS
37422011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3743
3744 * m/ibms390.h: Remove.
3745 * m/ibms390x.h: Don't include "ibms390.h".
3746
a5bb9bd3
SM
37472011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3748
3749 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3750 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3751
cd1181db
JB
37522011-11-20 Juanma Barranquero <lekktu@gmail.com>
3753
3754 * casetab.c (Fset_case_table):
3755 * charset.c (Fcharset_after): Fix typos.
3756
615a3b8d 37572011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3758
17e845af
PE
3759 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3760 Otherwise, valgrind does not work on some platforms.
3761 Problem reported by Andreas Schwab in
6a0bf43d
PE
3762 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3763 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3764 is set, removing the need for VIRT_ADDRESS_VARIES.
3765 (PURE_P): Use a more-efficient implementation that needs just one
3766 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3767 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3768 to 4 (xorl, subq, cmpq, setbe).
3769 * alloc.c (pure): Always extern now, since that's the
3770 VIRT_ADDR_VARIES behavior.
3771 (PURE_POINTER_P): Use a single comparison, not two, for
3772 consistency with the new puresize.h.
3773 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3774 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3775 Remove VIRT_ADDR_VARIES no longer needed.
3776
f8fe6f96
EZ
37772011-11-19 Eli Zaretskii <eliz@gnu.org>
3778
3779 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3780 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3781 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3782 behave as if the cursor position were at the window margin.
3783
3784 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3785 and the cursor position is out of bounds, behave as if the cursor
3786 position were at the window margin. (Bug#10075)
3787
df05a53c
CY
37882011-11-18 Chong Yidong <cyd@gnu.org>
3789
3790 * window.c (Fwindow_combination_limit): Make first argument
3791 non-optional, since it is meaningless for live windows like the
3792 selected window.
61ccba97 3793
2071918e
DA
37942011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3795
3796 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3797
b50a28de
SM
37982011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3799
3800 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3801 (graft_intervals_into_buffer): Simplify.
3802
015137db
EZ
38032011-11-18 Eli Zaretskii <eliz@gnu.org>
3804
3805 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3806 hash values of the two rows.
3807 (copy_row_except_pointers): Preserve the used[] arrays and the
3808 hash values of the two rows. (Bug#10035)
68c95424 3809 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3810
3811 * xdisp.c (row_hash): New function, body extracted from
3812 compute_line_metrics.
3813 (compute_line_metrics): Call row_hash, instead of computing the
3814 hash code inline.
3815
3816 * dispnew.c (verify_row_hash): Call row_hash for computing the
3817 hash code of a row, instead of duplicating code from xdisp.c.
3818
3819 * dispextern.h (row_hash): Add prototype.
3820
a2addb04
TH
38212011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3822
3823 * frame.c (delete_frame): Don't delete the terminal when the last
3824 X frame is closed if emacs is built with GTK toolkit.
3825
df85d315
JB
38262011-11-17 Juanma Barranquero <lekktu@gmail.com>
3827
3828 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3829
a0c2d0ae
MR
38302011-11-17 Martin Rudalics <rudalics@gmx.at>
3831
3832 * window.c (Vwindow_splits): Rename to
3833 Vwindow_combination_resize. Suggested by Juri Linkov.
3834 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3835 of Vwindow_splits.
3836
58179cce
JB
38372011-11-16 Juanma Barranquero <lekktu@gmail.com>
3838
7877f373
JB
3839 * nsfns.m (Fns_font_name):
3840 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3841
b6f67890
MR
38422011-11-16 Martin Rudalics <rudalics@gmx.at>
3843
3844 * window.h (window): Rename slot "nest" to "combination_limit".
3845 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3846 (Fset_window_nest): Rename to Fset_window_combination_limit.
3847 (Vwindow_nest): Rename to Vwindow_combination_limit.
3848 (recombine_windows, make_parent_window, make_window)
3849 (Fsplit_window_internal, saved_window)
3850 (Fset_window_configuration, save_window_save): Rename all
3851 occurrences of window_nest to window_combination_limit.
3852
c7015153
JB
38532011-11-15 Juanma Barranquero <lekktu@gmail.com>
3854
3855 * image.c (imagemagick_load_image): Fix typo.
3856
322ad6ec
EZ
38572011-11-14 Eli Zaretskii <eliz@gnu.org>
3858
3859 * xdisp.c (display_line): Move the call to
3860 highlight_trailing_whitespace before the call to
3861 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3862 faces of all the glyphs to compute ROW's hash value.
3863 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3864
f067b8ec
JB
38652011-11-14 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3868 just return (bug#10044).
3869
1e5b2111
EZ
38702011-11-12 Eli Zaretskii <eliz@gnu.org>
3871
7ef3cbd5
EZ
3872 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3873 with user-defined heap size. Bump the default size of the temacs
3874 heap to 27MB, to avoid memory warning when running temacs.
3875 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3876
1e5b2111
EZ
3877 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3878 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3879 (verify_row_hash) [XASSERTS]: New function.
3880 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3881 that the hash value of glyph rows is correct.
1e5b2111 3882
89d61221
MR
38832011-11-12 Martin Rudalics <rudalics@gmx.at>
3884
3885 * window.h (window): Remove splits slot.
3886 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3887 (Fdelete_other_windows_internal, make_parent_window)
3888 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3889 (Fset_window_configuration, save_window_save): Don't deal with
3890 split status of windows.
3891 (saved_window): Remove splits slot.
3892 (Vwindow_splits): Rewrite doc-string.
3893
97f18cc8
JD
38942011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3895
3896 * xfns.c (unwind_create_frame):
3897 * nsfns.m (unwind_create_frame):
3898 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3899 Vframe_list (Bug#9999).
3900
22a648b4
DA
39012011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3902
0b381c7e 3903 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3904
659afede
KH
39052011-11-11 Kenichi Handa <handa@m17n.org>
3906
3907 * callproc.c (Fcall_process): Set the member dst_multibyte of
3908 process_coding.
3909
9ac0394b
KH
39102011-11-11 Johan Bockgård <bojohan@gnu.org>
3911
3912 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3913 avoid a crash (bug#9496).
3914
2fbdc249
CY
39152011-11-09 Chong Yidong <cyd@gnu.org>
3916
3917 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3918 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3919
ac6b1f81
PE
39202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3921
3922 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3923
09db192c
PE
39242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3925
3926 Avoid some portability problems by eschewing 'extern inline' functions.
3927 The trivial performance wins aren't worth the portability hassles; see
3928 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3929 et seq.
3930 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3931 (window_box_width, window_box_left, window_box_left_offset)
3932 (window_box_right, window_box_right_offset): Undo previous change,
3933 by removing the "extern"s.
3934 * intervals.c (adjust_intervals_for_insertion)
3935 (adjust_intervals_for_deletion): Undo previous change,
3936 making these static again.
3937 (offset_intervals, temp_set_point_both, temp_set_point)
3938 (copy_intervals_to_string): No longer inline.
3939 * xdisp.c (window_text_bottom_y, window_box_width)
3940 (window_box_height, window_box_left_offset)
3941 (window_box_right_offset, window_box_left, window_box_right)
3942 (window_box): No longer inline.
3943
105216ed
CY
39442011-11-08 Chong Yidong <cyd@gnu.org>
3945
3946 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3947 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3948 Signal an error if not a live window.
105216ed
CY
3949 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3950 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3951
ae9e237f
JB
39522011-11-07 Juanma Barranquero <lekktu@gmail.com>
3953
3954 * lisp.h (syms_of_abbrev): Remove declaration.
3955 Reported by CHENG Gao <chenggao@royau.me>.
3956
c7aa8333
EZ
39572011-11-07 Eli Zaretskii <eliz@gnu.org>
3958
3959 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3960 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3961 of temacs in GUI mode.
3962
be7f5545
MR
39632011-11-07 Martin Rudalics <rudalics@gmx.at>
3964
3965 * window.h: Declare delete_all_child_windows instead of
3966 delete_all_subwindows.
3967 * window.c (Fwindow_nest, Fset_window_nest)
3968 (Fset_window_new_total, Fset_window_new_normal)
3969 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3970 (delete_all_subwindows): Rename to delete_all_child_windows.
3971 (Fdelete_other_windows_internal, Fset_window_configuration):
3972 Call delete_all_child_windows instead of delete_all_subwindows.
3973 * frame.c (delete_frame): Call delete_all_child_windows instead
3974 of delete_all_subwindows.
3975
ca78dc43
PE
39762011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3977
3978 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3979 This is also needed for porting to any host where GC_MARK_STACK is
3980 not GC_MAKE_GCPROS_NOOPS.
3981 (which_symbols): Use it.
3982
a0241d01
KH
39832011-11-07 Kenichi Handa <handa@m17n.org>
3984
3985 * coding.c (coding_set_destination): Check coding->src_pos only
3986 when coding->src_object is a buffer (bug#9910).
3987
3988 * process.c (send_process): Set the member src_multibyte of coding
3989 to 0 (bug#9911) when sending a unibyte text.
3990
3991 * callproc.c (Fcall_process): Set the member src_multibyte of
3992 process_coding to 0 (bug#9912).
3993
a64bfdfa 39942011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3995
3996 * xmenu.c (cleanup_widget_value_tree): New function.
3997 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3998 calling free_menubar_widget_value_tree directly (Bug#9830).
3999
cb41b32a
PE
40002011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4001
4002 Fix some portability problems with 'inline'.
4003 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4004 (window_box_width, window_box_left, window_box_left_offset)
4005 (window_box_right, window_box_right_offset): Declare extern.
4006 Otherwise, these inline functions do not conform to C99 and
4007 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4008 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4009 * intervals.c (adjust_intervals_for_insertion)
4010 (adjust_intervals_for_deletion): Now extern, because otherwise the
4011 extern inline functions 'offset_intervals' couldn't refer to it.
4012 (static_offset_intervals): Remove.
4013 (offset_intervals): Rewrite using the old contents of
4014 static_offset_intervals. The old version didn't conform to C99
4015 because an extern inline function contained a reference to an
4016 identifier with static linkage.
4017
b7041366
AS
40182011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4019
4020 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4021 GC.
4022
88a37c4d
EZ
40232011-11-06 Eli Zaretskii <eliz@gnu.org>
4024
4025 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4026 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4027 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4028 return Qleft_to_right.
4029
49745b39
CY
40302011-11-06 Chong Yidong <cyd@gnu.org>
4031
4032 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4033 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4034 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4035 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4036 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4037 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4038 (Fwindow_vscroll): Doc fix.
4039 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4040 argument, since it makes no sense to pass a live window and for
4041 consistency with window-child.
4042
1f05cd82
CS
40432011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4044
4045 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4046 support MSVC.
4047
22610910
JR
40482011-11-05 Jason Rumney <jasonr@gnu.org>
4049
4050 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4051 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4052 fonts (Bug#6029).
4053 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4054 bitwise arithmetic preventing use of unicode-sip and non-truetype
4055 opentype fonts.
4056
a06776b2
EZ
40572011-11-05 Eli Zaretskii <eliz@gnu.org>
4058
3ad924ba
EZ
4059 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4060 "emacs"-only part.
4061
a06776b2
EZ
4062 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4063 initialization code to keep similarity to xfns.c after changes
4064 from 2011-11-05.
4065
c9e7db78
JD
40662011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4067
a97f8f3f
JD
4068 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4069 (unwind_create_frame): New function (Bug#9943).
4070 (Fx_create_frame): Restructure code to be more similar to the one in
4071 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4072 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4073 Move terminal->reference_count++ just before making the frame official
4074 (Bug#9943).
4075
4076 * nsterm.m (x_free_frame_resources): New function.
4077 (x_destroy_window): Move code to x_free_frame_resources.
4078
c9e7db78 4079 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4080 (Fx_create_frame, x_create_tip_frame):
4081 Move terminal->reference_count++ just before making the frame
75f1671a 4082 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4083 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4084
a6fc3b5c
EZ
40852011-11-05 Eli Zaretskii <eliz@gnu.org>
4086
4087 Support MSVC build with newer versions of Visual Studio.
4088 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4089 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4090 nt/gmake.defs.
4091
4092 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4093 which are not supported by MSVC.
4094 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4095 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4096 bitfields.
4097 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4098 types in bitfields.
4099 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4100
4101 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4102
58179cce 41032011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4104
4105 Support MSVC build with newer versions of Visual Studio.
4106 * w32.c: Don't include w32api.h for MSVC.
4107 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4108
4109 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4110 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4111 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4112 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4113 e_* cousins.
4114 (alloca) [_MSC_VER]: Define to _alloca.
4115
4116 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4117
4118 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4119
a58c13ed
EZ
41202011-11-04 Eli Zaretskii <eliz@gnu.org>
4121
4122 * xdisp.c (note_mouse_highlight): If either of
4123 previous/next-single-property-change returns nil, treat that as
4124 the beginning or the end of the buffer. (Bug#9955)
4125
fe0b6370
JD
41262011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4127
a58c13ed 4128 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4129 label is not null (Bug#9951).
4130 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4131 may be NULL.
4132
89bd5ee1
EZ
41332011-11-04 Eli Zaretskii <eliz@gnu.org>
4134
4135 * window.c (Fwindow_body_size): Mention in the doc string that the
4136 return value is in frame's canonical units. (Bug#9949)
4137
84c3edb9
EZ
41382011-11-03 Eli Zaretskii <eliz@gnu.org>
4139
4e2fb5c7
EZ
4140 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4141
84c3edb9 4142 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4143 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4144 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4145
bc17a887
EZ
41462011-11-01 Eli Zaretskii <eliz@gnu.org>
4147
4148 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4149 Don't stop backward scan on the continuation glyph, even though
4150 its CHARPOS is positive.
6d5eb5b0
SM
4151 (mouse_face_from_buffer_pos, note_mouse_highlight):
4152 Rename cover_string to disp_string.
bc17a887 4153
4ee88440
MR
41542011-11-01 Martin Rudalics <rudalics@gmx.at>
4155
4156 * window.c (temp_output_buffer_show): Don't use
4157 Vtemp_buffer_show_specifiers.
4158 (Vtemp_buffer_show_specifiers): Remove unused variable.
4159
c2ff3c02
EZ
41602011-10-30 Eli Zaretskii <eliz@gnu.org>
4161
4162 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4163 past the beginning of the current glyph matrix.
4164
58179cce 41652011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4166
4167 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4168 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4169 HAVE_GTK3 (Bug#9869).
b77a6a7f 4170
3b574623
JD
4171 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4172 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4173
b77a6a7f
JD
4174 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4175
4176 * xterm.c: Declare x_handle_net_wm_state to return int.
4177 (handle_one_xevent): Check if we are iconified but don't have
4178 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4179 (get_current_wm_state): Return non-zero if not hidden,
4180 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4181 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4182 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4183 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4184
196e41e4
PE
41852011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4186
4187 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4188 so that this new function doesn't get optimized away by a
4189 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4190
021f2e1a
AS
41912011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4192
4193 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4194
8b058d44
EZ
41952011-10-29 Eli Zaretskii <eliz@gnu.org>
4196
4197 Fix the `xbytecode' command.
4198 * .gdbinit (xprintbytestr): New command.
b50a28de 4199 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4200 (xbytecode): Print the byte-code string as well.
4201
4452fb80
EZ
42022011-10-29 Kim Storm <storm@cua.dk>
4203
8b058d44
EZ
4204 * alloc.c (which_symbols): New function.
4205
21b72067
AS
42062011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4207
4208 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4209 line. (Bug#9903)
4210
83ed7b5c
GM
42112011-10-29 Glenn Morris <rgm@gnu.org>
4212
4213 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4214 Not clear what it was for, and it causes various bugs. (Bug#9839)
4215
5a7a728b
EZ
42162011-10-28 Eli Zaretskii <eliz@gnu.org>
4217
4218 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4219 possible random value that matches one of those tested as
4220 condition to clear the mouse face.
4221
d3d0842f
CY
42222011-10-28 Chong Yidong <cyd@gnu.org>
4223
4224 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4225
31b39d13
DN
42262011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4227
4228 * window.c (make_window): Initialize phys_cursor_on_p.
4229
9aba6043
SM
42302011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4231
4232 * lisp.h (struct Lisp_Symbol): Update comments.
4233
c20992f4
JB
42342011-10-28 Juanma Barranquero <lekktu@gmail.com>
4235
4236 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4237
db4f02f2
EZ
42382011-10-28 Eli Zaretskii <eliz@gnu.org>
4239
4240 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4241 <oslsachem@gmail.com> for helping to debug this.
4242
4243 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4244 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4245 (g_b_init_get_glyph_outline_w): New static variables.
4246 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4247 (GetGlyphOutlineW_Proc): New typedefs.
4248 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4249 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4250 New functions.
4251 (w32font_open_internal, compute_metrics):
4252 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4253 instead of calling the "wide" APIs directly.
4254
4255 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4256
4257 * w32.h (syms_of_w32font): Add prototype.
4258
87e68db4
JB
42592011-10-27 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4262 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4263 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4264 (Fmove_to_window_line): Doc fix.
4265
435c1d67
CY
42662011-10-27 Chong Yidong <cyd@gnu.org>
4267
4268 * process.c (make_process): Set gnutls_state to NULL.
4269
4270 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4271 non-NULL, regardless of GNUTLS_INITSTAGE.
4272 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4273 an error. Set process slots as soon as we allocate them.
4274
4275 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4276
9c6c6f49
CY
42772011-10-27 Chong Yidong <cyd@gnu.org>
4278
9aba6043
SM
4279 * gnutls.c (emacs_gnutls_deinit): New function.
4280 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4281 (Fgnutls_deinit, Fgnutls_boot): Use it.
4282
4283 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4284 (deactivate_process): Call emacs_gnutls_deinit.
4285
657d08d3
JB
42862011-10-27 Juanma Barranquero <lekktu@gmail.com>
4287
4288 * image.c (x_create_x_image_and_pixmap):
4289 * w32.c (sys_rename, w32_delayed_load):
4290 * w32font.c (fill_in_logfont):
4291 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4292
5430d399
JB
42932011-10-26 Juanma Barranquero <lekktu@gmail.com>
4294
4295 * w32fns.c (w32_default_color_map): New function,
4296 extracted from Fw32_default_color_map.
a7ef684b 4297 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4298
fe0055fa
PE
42992011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4302
e6346438
SM
43032011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4304
4305 * keyboard.c (test_undefined): New function (bug#9751).
4306 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4307
e112cc37
ET
43082011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4309
4310 * sysdep.c (init_sys_modes): Fix the check for the controlling
4311 terminal (Bug#6649).
4312
7b5d6677
EZ
43132011-10-20 Eli Zaretskii <eliz@gnu.org>
4314
4315 * dispextern.h (struct bidi_it): New member next_en_type.
4316
4317 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4318 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4319 current character, check also for next_en_type being WEAK_EN.
4320 (bidi_resolve_weak): Don't enter the expensive loop if the current
4321 position is before next_en_pos. Record the bidi type of the first
4322 non-ET, non-BN character we find, in addition to its position.
4323 (bidi_level_of_next_char): Invalidate next_en_type when
4324 next_en_pos is over-stepped.
4325
7da0b018
PE
43262011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4329 * editfns.c: Rewrite current-time-zone so that it invokes
4330 the equivalent of (format-time-string "%Z") to get the time zone name.
4331 This fixes a bug when the time zone name contains characters that
4332 need converting from the system time locale to Emacs internal format.
4333 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4334 that patch fixed format-time-string to do the conversion, but
4335 I forgot to fix current-time-zone.
4336 (format_time_string): New function, containing most of
4337 what Fformat_time_string used to contain.
4338 (Fformat_time_string): Rewrite in terms of format_time_string.
4339 This doesn't change this function's behavior.
4340 (current-time-zone): Rewrite to use format_time_string.
4341 This fixes the bug reported by Michael Schierl in
4342 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4343 Jason Rumney's 2007-06-07 change worked around this bug, but
4344 didn't fix it.
4345 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4346
8547b010
EZ
43472011-10-19 Eli Zaretskii <eliz@gnu.org>
4348
4349 * xdisp.c (start_display): If the character at POS is displayed
4350 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4351 (try_window_reusing_current_matrix): If a line ends in a display
4352 vector or the next line starts in a display vector, continue
4353 redrawing the window even though the character position of
4354 start_row was reached.
8547b010
EZ
4355 (Bug#9771, part 2)
4356
4e948d15
CY
43572011-10-18 Chong Yidong <cyd@gnu.org>
4358
4359 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4360 with nobreak-char-display too.
4361
4787455f
EZ
43622011-10-18 Eli Zaretskii <eliz@gnu.org>
4363
4364 Fix part 3 of bug#9771.
4365 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4366 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4367 non-neutral characters if the current character is a paragraph
4368 separator (a.k.a. Newline). This avoids running the same
4369 expensive loop twice, once when we consume the preceding newline
4370 and the other time when the line actually needs to be displayed.
4371 Avoid the loop when we see neutrals on the base embedding level
4372 following a character whose directionality is the same as the
4373 paragraph's. This avoids running the expensive loop when a line
4374 ends in a long sequence of neutrals, like control characters.
4375 Add assertion against STRONG_AL type. Slightly rearrange code
4376 that determines the type of a neutral given the first non-neutral
4377 that follows it.
4378 (bidi_level_of_next_char): Set next_en_pos to zero when
4379 invalidating its info.
4380
2c91f553
EZ
43812011-10-17 Eli Zaretskii <eliz@gnu.org>
4382
4383 * xdisp.c (push_display_prop): Determine whether to record string
4384 or buffer position by IT->string, not by IT->method. Allow
4385 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4386 (move_it_vertically_backward): Don't look for character position
4387 immediately after the newline when in a continuation line.
4388 (Bug#9771, part 1)
2c91f553 4389
c7b08b0d
MR
43902011-10-15 Martin Rudalics <rudalics@gmx.at>
4391
4392 * window.c (coordinates_in_window): Rewrite and delabelize
4393 vertical border check. (Bug#5357) (Bug#9618)
4394
6b02f655
SM
43952011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4396
4397 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4398 errors in XSetWindowBorder (bug#9310).
4399
81d40c92
DA
44002011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4401
4402 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4403 avoid crash when xmalloc overrun checking is enabled.
4404
d4172c3b
EZ
44052011-10-13 Eli Zaretskii <eliz@gnu.org>
4406
4407 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4408 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4409 cursor motion with <left> and <right> arrow keys.
4410
4411 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4412 some callers set that themselves.
4413
b00eea75
EZ
44142011-10-12 Eli Zaretskii <eliz@gnu.org>
4415
4416 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4417 display string and the previous row comes from the same string and
4418 is empty. (Bug#9739) (Bug#9738)
4419
8fe012c4
SM
44202011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4421
4422 * doc.c (get_doc_string): Encode file name (bug#9735).
4423
0074aef2
EZ
44242011-10-12 Eli Zaretskii <eliz@gnu.org>
4425
79beb178
EZ
4426 * bidi.c (bidi_level_of_next_char):
4427 * xdisp.c (get_visually_first_element): Remove old incorrect
4428 comments regarding the Unicode Line Separator character.
4429
0074aef2
EZ
4430 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4431
6e4b3fbe
DA
44322011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4433
4434 * alloc.c (Fgc_status): Do not access beyond zombies array
4435 boundary if nzombies > MAX_ZOMBIES.
4436 * alloc.c (dump_zombies): Add missing format specifier.
4437
0324f3af
PE
44382011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4439
b5525cac
PE
4440 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4441 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4442
0324f3af
PE
4443 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4444 Some packages use them to denote characters with modifiers.
4445
e9b5f888
AS
44462011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4447
4448 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4449 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4450 matching a pp-number. Rename parameter var to var1.
4451
127827c0
SM
44522011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4453
4454 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4455
c8fd3bd0
GM
44562011-10-08 Glenn Morris <rgm@gnu.org>
4457
4458 * callint.c (Fcall_interactively): Give a more explicit error for the
4459 'c' case with a non-character input. (Bug#8479)
4460
352ec8ff
EZ
44612011-10-08 Eli Zaretskii <eliz@gnu.org>
4462
03669ccb
EZ
4463 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4464 lines.
7061c986
EZ
4465 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4466 lines that are hscrolled on the left.
03669ccb 4467
352ec8ff
EZ
4468 * dispnew.c (buffer_posn_from_coords): Account for a possible
4469 presence of header-line. (Bug#4426)
4470
a66cfb1c
SM
44712011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4472
6b02f655
SM
4473 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4474 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4475
7c5ee88e
PE
44762011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4479 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4480 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4481 this makes Emacs dump core during garbage collection on rare
4482 occasions. sizeof is obviously inferior to offsetof here, so
4483 stick with offsetof.
4484 (GC_POINTER_ALIGNMENT): New macro.
4485 (mark_memory): Omit 3rd (offset) arg; caller changed.
4486 Don't assume EMACS_INT alignment is the same as pointer alignment.
4487
df1bbe5b
SM
44882011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4489
4490 * keyboard.c (read_key_sequence_remapped): New var.
4491 (read_key_sequence): Compute remapping in the right buffer.
4492 (command_loop_1): Use read_key_sequence's remapping directly.
4493
51553db6
SM
44942011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4495
32c1fffd
SM
4496 * dired.c (file_name_completion): Don't expand file name.
4497 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4498 before checking file name handler.
4499
51553db6
SM
4500 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4501 they've been requested explicitly (bug#9591).
4502
b6bd1599 45032011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4504
4505 * keymap.c (Fsingle_key_description): Use make_specified_string
4506 instead of build_string to build string from push_key_description.
4507 (Bug#5193)
4508
f701dc2a
PE
45092011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4510
4222c55d
PE
4511 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4512 This fixes a Y2038 bug on 64-bit hosts.
4513 * buffer.c (reset_buffer):
4514 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4515 (Fclear_buffer_auto_save_failure):
4516 Use 0, not -1, to represent an unset failure time, since time_t
4517 might not be signed.
4518
f701dc2a
PE
4519 Remove dependency on glibc malloc internals.
4520 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4521 Move back here from lisp.h, but with their new implementations.
4522 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4523 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4524 * charset.c (charset_table_init): New static var.
4525 (syms_of_charset): Use it instead of xmalloc. This removes a
4526 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4527 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4528 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4529 Move back to alloc.c.
4530 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4531 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4532
9ceebf39
JD
45332011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4534
4535 * nsterm.m (windowDidResize): Call x_set_window_size only when
4536 ns_in_resize is true. Otherwise set pixelwidth/height and
4537 call change_frame_size (Bug#9628).
4538
cb993c58
PE
45392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4540
3930c88b
PE
4541 Port --enable-checking=all to Fedora 14 x86-64.
4542 * charset.c (syms_of_charset): Also account for glibc malloc's
4543 internal overhead when calculating the initial malloc maximum.
4544
cb993c58
PE
4545 Port --enable-checking=all to Fedora 14 x86.
4546 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4547 Move to lisp.h.
4548 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4549 (overrun_check_realloc, overrun_check_free):
4550 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4551 That way, xmalloc returns a properly-aligned pointer even if
4552 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4553 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4554 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4555 into account when calculating the initial malloc maximum.
4556 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4557 Move here from alloc.c, so that charset.c can use it too.
4558 Properly align; the old code wasn't right for common 32-bit hosts
4559 when configured with --enable-checking=all.
4560 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4561 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4562
31bed486
EZ
45632011-09-29 Eli Zaretskii <eliz@gnu.org>
4564
04c70788 4565 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4566 use EDOM.
4567
fbcaa2f3
EZ
45682011-09-28 Eli Zaretskii <eliz@gnu.org>
4569
4570 * xdisp.c (compute_display_string_end): If there's no display
4571 string at CHARPOS, return -1.
4572
4573 * bidi.c (bidi_fetch_char): When compute_display_string_end
4574 returns a negative value, treat the character as a normal
4575 character not covered by a display string. (Bug#9624)
4576
a239d4e9
JB
45772011-09-28 Juanma Barranquero <lekktu@gmail.com>
4578
4579 * lread.c (Fread_from_string): Fix typo in docstring.
4580
88652fd5
EZ
45812011-09-27 Eli Zaretskii <eliz@gnu.org>
4582
4583 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4584 newline, reseat the iterator instead of bidi-iterating there one
4585 character at a time. (Bug#9610)
32c1fffd
SM
4586 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4587 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4588
ed497dd4
AS
45892011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4590
4591 * lread.c (readevalloop): Use correct code for NBSP.
4592 (read1): Likewise. (Bug#9608)
4593
b2bf61aa
MA
45942011-09-25 Michael Albinus <michael.albinus@gmx.de>
4595
4596 * dbusbind.c (Fdbus_register_signal): When service is not
4597 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4598
32bbb17c
GM
45992011-09-25 Glenn Morris <rgm@gnu.org>
4600
4601 * buffer.c (truncate-lines): Doc fix.
4602
94e0933e
CY
46032011-09-24 Chong Yidong <cyd@stupidchicken.com>
4604
4605 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4606 (Fset_window_next_buffers): Doc fix.
4607
cddde921
GM
46082011-09-24 Glenn Morris <rgm@gnu.org>
4609
4610 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4611
1260aef1
PE
46122011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4613
25b4bfa0
PE
4614 Fix minor problems found by static checking.
4615 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4616 * indent.c (Fvertical_motion): Fix == vs = typo.
4617
e3cbd34b
EZ
46182011-09-24 Eli Zaretskii <eliz@gnu.org>
4619
a66cfb1c
SM
4620 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4621 Default value is now t. Doc fix.
6bf7006f 4622
e3cbd34b 4623 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4624 logic when moving up, not only when moving down. Fix the
e3cbd34b 4625 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4626 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4627
4628 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4629 CHARPOS is covered by a display string which includes newlines.
4630 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4631 is covered by a display string with embedded newlines.
4632
a3de0cbd
MA
46332011-09-24 Michael Albinus <michael.albinus@gmx.de>
4634
4635 * dbusbind.c (Fdbus_register_signal): Add match rule to
4636 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4637 (Fdbus_register_method, Vdbus_registered_objects_table):
4638 Fix docstring.
a3de0cbd 4639
b260039d
JM
46402011-09-24 Jim Meyering <meyering@redhat.com>
4641
32c1fffd 4642 do not ignore write error for any output size
b260039d
JM
4643 The previous change was incomplete.
4644 While it makes emacs --batch detect the vast majority of stdout
4645 write failures, errors were still ignored whenever the output size is
4646 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4647 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4648 && echo FAIL: ignored write error
4649 FAIL: ignored write error
4650 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4651 && echo FAIL: ignored write error
4652 FAIL: ignored write error
4653 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4654
8eca8a7c
AS
46552011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4656
4657 * emacs.c (Fkill_emacs): In noninteractive mode exit
4658 non-successfully if a write error occurred on stdout. (Bug#9574)
4659
3341db62
EZ
46602011-09-21 Eli Zaretskii <eliz@gnu.org>
4661
4662 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4663 the xassert test.
4664
4665 * dispextern.h (struct it): Update the comment documenting what
4666 can it->OBJECT be.
4667
8c203dbf
EZ
46682011-09-20 Eli Zaretskii <eliz@gnu.org>
4669
4670 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4671 a display string, extend search for cursor position to end of row.
4672 (find_row_edges): If the row ends in a newline from a display
4673 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4674 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4675 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4676 non-empty line. Fixes confusing cursor motion with arrow keys at
4677 the beginning of a line that starts with whitespace.
8c203dbf 4678
a4824228
LMI
46792011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4680
4681 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4682 (bug#9493).
4683
33ed493b
CY
46842011-09-18 Chong Yidong <cyd@stupidchicken.com>
4685
4686 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4687 boolean (Bug#9154).
4688
56cd55c8
EZ
46892011-09-18 Eli Zaretskii <eliz@gnu.org>
4690
4691 * xdisp.c (display_line): Record maximum and minimum buffer
4692 positions even if no glyphs were produced (e.g., by a zero-width
4693 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4694 buffer positions that will be removed from the glyph row because
4695 they don't fit.
c02dcedf
EZ
4696 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4697 column is beyond frame width: don't subtract 1 "pixel" when
4698 computing width of the stretch.
3e62b7e0
EZ
4699 (reseat_at_next_visible_line_start): Undo the change made on
4700 2011-09-17 that saved paragraph information and restored it after
4701 the call to `reseat'. (Bug#9545)
56cd55c8 4702
5ed99d36 47032011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4704
4705 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4706 and turn window cursor on if cleared (Bug#9415).
4707
5ed99d36 47082011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4709
4710 * search.c (boyer_moore): Take unibyte characters from pattern
4711 literally. (Bug#9458)
4712
9bade7b2
EZ
47132011-09-18 Eli Zaretskii <eliz@gnu.org>
4714
4715 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4716
e5e9d610
PE
47172011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4718
87e4427a
PE
4719 Fix minor problem found by static checking.
4720 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4721 initialized, to pacify gcc -Wuninitialized.
4722
e5e9d610
PE
4723 * fileio.c: Report proper errno when syscall falls.
4724 (Finsert_file_contents): Save and restore errno,
4725 so that report_file_error outputs the correct diagnostic.
4726 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4727
a1674f0b
EZ
47282011-09-18 Eli Zaretskii <eliz@gnu.org>
4729
4730 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4731
fbfb6dd4
EZ
47322011-09-17 Eli Zaretskii <eliz@gnu.org>
4733
4734 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4735 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4736
bb187662
EZ
47372011-09-17 Eli Zaretskii <eliz@gnu.org>
4738
1137e8b8 4739 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4740 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4741
4742 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4743 (bidi_find_paragraph_start): Search back for paragraph beginning
4744 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4745 (bidi_move_to_visually_next): Only trigger paragraph-related
4746 computations when the last character is a newline or at EOB, not
4747 just any NEUTRAL_B. (Bug#9470)
4748
bb187662
EZ
4749 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4750 truncated lines if point is covered by a display string. (Bug#9524)
4751
2e621251
PE
47522011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4753
4754 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4755 (cons_to_x_long): New function.
4756 (lisp_data_to_selection_data): Use it. Correct the test for
4757 short-versus-long data; it was negated. Break out of vector
4758 loop, for efficiency, when a long datum is discovered.
4759
91a15bc6
SM
47602011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4761
4762 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4763
b41c3a35
EZ
47642011-09-16 Eli Zaretskii <eliz@gnu.org>
4765
4766 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4767 GCC PR/17406) by declaring this function with external scope.
4768
7812ba2d
PE
47692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4770
4771 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4772 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4773
cf7edc2a
AS
47742011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4775
4776 * editfns.c (Fformat): Correctly handle text properties on "%%".
4777
bd01620e
EZ
47782011-09-15 Eli Zaretskii <eliz@gnu.org>
4779
4780 * xterm.c (x_draw_composite_glyph_string_foreground):
4781 * w32term.c (x_draw_composite_glyph_string_foreground):
4782 * term.c (encode_terminal_code):
4783 * composite.c (composition_update_it, get_composition_id):
4784 * xdisp.c (get_next_display_element)
4785 (fill_composite_glyph_string): Add comments about special meaning
4786 of TAB characters in a composition.
4787
a02719a3
PE
47882011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4791 This occurs when processing a multibyte format.
4792 Problem reported by Wolfgang Jenker.
a02719a3 4793
72589a3c
JB
47942011-09-15 Johan Bockgård <bojohan@gnu.org>
4795
4796 * xdisp.c (try_cursor_movement): Only check for exact match if
4797 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4798
1c14176c
PE
47992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4800
4801 Remove unused external symbols.
4802 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4803 * xdisp.c (calc_pixel_width_or_height): Now static.
4804 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4805 * indent.c (check_display_width):
4806 * w32term.c: Fix comment to match code.
4807 * xterm.c, xterm.h (x_catching_errors): Remove.
4808
d2eea5b5
PE
48092011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * xselect.c: Use signed conversions more consistently (Bug#9498).
4812 (selection_data_to_lisp_data): Assume incoming selection data are
4813 signed integers, not unsigned. This is to be consistent with
4814 outgoing selection data, which was modified to use signed integers
4815 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4816 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4817 expects long, not unsigned long.
4818
46888499
EZ
48192011-09-14 Eli Zaretskii <eliz@gnu.org>
4820
4821 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4822 computation of loop end. Reported by Johan Bockgård
4823 <bojohan@gnu.org>.
4824
ef8ef9fb
CY
48252011-09-13 Chong Yidong <cyd@stupidchicken.com>
4826
4827 * frame.c (Fother_visible_frames_p): Function deleted.
4828
fa819fed
EZ
48292011-09-12 Eli Zaretskii <eliz@gnu.org>
4830
4831 * indent.c (compute_motion): Process display vector front to back
4832 rather than the other way around. (Bug#2496)
4833
2ba8e008
SM
48342011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4835
4836 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4837
20f53c69
CY
48382011-09-11 Chong Yidong <cyd@stupidchicken.com>
4839
4840 * minibuf.c (Fread_from_minibuffer): Doc fix.
4841
d562d7a4
EZ
48422011-09-11 Eli Zaretskii <eliz@gnu.org>
4843
4844 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4845 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4846
1c4d7f3d
LMI
48472011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4848
4849 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4850 value for non-existent files.
4851
b885bf36
EZ
48522011-09-11 Eli Zaretskii <eliz@gnu.org>
4853
4854 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4855 set its "size" to -1. This will set the modtime_size field of
4856 the corresponding buffer to -1, which is what
4857 verify-visited-file-modtime expects for files that do not exist.
4858 (Bug#9139)
4859
6612f0bf
PE
48602011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4861
4862 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4863 here ...
4864 * lisp.h: ... from here. push_key_description is no longer
4865 defined in keyboard.c, so its declaration should not be in
4866 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4867 logically belongs with push_key_description.
4868
dfb3f755
PE
48692011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4870
4871 * buffer.h: Include <sys/types.h> instead of <time.h>.
4872 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4873 Problem reported by Herbert J. Skuhra.
4874
3134906c
LMI
48752011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4876
4877 * xml.c (parse_region): Make the parsing work for
4878 non-comment-starting XML files again (bug#9144).
4879
8d903f4e
AS
48802011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4881
4882 * image.c (gif_load): Fix calculation of bottom and right corner.
4883 (Bug#9468)
4884
80ad64f4
EZ
48852011-09-10 Eli Zaretskii <eliz@gnu.org>
4886
4887 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4888 redisplay in small windows.
4889
208a048d
EZ
48902011-09-09 Eli Zaretskii <eliz@gnu.org>
4891
4892 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4893
9b1c252e
MR
48942011-09-08 Martin Rudalics <rudalics@gmx.at>
4895
4896 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4897 Operate on live windows only.
4898
2949f33b
JB
48992011-09-08 Juanma Barranquero <lekktu@gmail.com>
4900
4901 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4902
e08dcafd
EZ
49032011-09-07 Eli Zaretskii <eliz@gnu.org>
4904
4905 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4906 only under bidi iteration.
4907
115b96bd
JD
49082011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4909
4910 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4911
c8199d0f
PE
49122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4913
4914 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4915 Without this fix, the command to link temacs failed due to an
4916 undefined symbol __builtin_isnan. This is because
4917 /usr/include/iso/math_c99.h #defines isnan(x) to
4918 __builtin_isnan(x), but the bundled gcc, which identifies itself
4919 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4920 a __builtin_isnan.
4921 * floatfns.c (isnan): #undef, and then #define to a clone of
4922 what's in data.c.
4923 (Fisnan): Always define, since it's always available now.
4924 (syms_of_floatfns): Always define isnan at the Lisp level.
4925
e39b275c 49262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4927
4928 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4929
b2db44d9 49302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4931
f4af5137 4932 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4933 The previous code assumed that file offsets (off_t values) fit in
4934 EMACS_INT variables, which is not true on typical 32-bit hosts.
4935 The code messed up by falsely reporting buffer overflow in cases
4936 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4937 when "big" contains more than 2**29 bytes, even though this
4938 inserts just one byte and does not overflow the buffer.
4939 (Finsert_file_contents): Store file offsets as off_t
4940 values, not as EMACS_INT values. Check for overflow when
4941 converting between EMACS_INT and off_t. When checking for
4942 buffer overflow or for overlap, take the offsets into account.
4943 Don't use EMACS_INT for small values where int suffices.
4944 When checking for overlap, fix a typo: ZV was used where
4945 ZV_BYTE was intended.
4946 (Fwrite_region): Don't assume off_t fits into 'long'.
4947 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4948
ecfc0a49
MA
49492011-09-05 Michael Albinus <michael.albinus@gmx.de>
4950
4951 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4952
6511acf2 49532011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4954
0999621a 4955 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4956
4957 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4958 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4959 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4960 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4961 (modify_event_symbol): Do not assume that the length of
4962 name_alist_or_stem is safe to alloca and fits in int.
4963 (Fexecute_extended_command): Likewise for function name and binding.
4964 (Frecursion_depth): Wrap around reliably on integer overflow.
4965 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4966 since some callers pass EMACS_INT values.
4967 (Fsingle_key_description): Don't crash if symbol name contains more
4968 than MAX_ALLOCA bytes.
4969 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4970 (get_minibuffer): Arg is now EMACS_INT, not int.
4971 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4972 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4973 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4974
2be7d702
PE
4975 * dbusbind.c (signature_cat): New function.
4976 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4977 Do not overrun buffer; instead, report string overflow.
4978
9d1df220
PE
4979 * dispnew.c (add_window_display_history): Don't overrun buffer.
4980 Truncate instead; this is OK since it's just a log.
4981
33ef5c64
PE
4982 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4983 even if the time zone offset is outlandishly large.
4984 Don't mishandle offset == INT_MIN.
4985
66c6fdd5
PE
4986 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4987 when creating daemon; the previous buffer-overflow check was incorrect.
4988
d749b01b
PE
4989 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4990 which has the guts of the old verror function.
4991
b5cd1905
PE
4992 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4993 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4994
6e1a67fb
PE
4995 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4996 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4997 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4998 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4999 length of string rather than counting it via multiple sprintfs;
5000 that's simpler and more reliable.
c21721cc
PE
5001 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5002 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5003 sprintf, in case result does not fit in int.
5004
c57b67fc
PE
5005 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5006 (fontset_from_font): Print it.
5007
8a401434
PE
5008 * frame.c (tty_frame_count): Now printmax_t, not int.
5009 (make_terminal_frame, set_term_frame_name): Print it.
5010 (x_report_frame_params): In X, window IDs are unsigned long,
5011 not signed long, so print them as unsigned.
5012 (validate_x_resource_name): Check for implausibly long names,
5013 and don't assume name length fits in 'int'.
5014 (x_get_resource_string): Don't blindly alloca invocation name;
5015 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5016 not fit in int.
5017
6e1a67fb
PE
5018 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5019 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5020 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5021
0df02bf3
PE
5022 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5023 Use esprintf, not sprintf, in case result does not fit in int.
5024
48e30793
PE
5025 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5026 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5027 it as a large positive number.
5028 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5029 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5030
a66ff6d8
PE
5031 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5032 in case result does not fit in int.
5033
aca216ff
PE
5034 * print.c (float_to_string): Detect width overflow more reliably.
5035 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5036 buffer overrun. Don't assume list length fits in 'int'. Treat
5037 print length of 0 as 0, not as infinity; to be consistent with other
5038 uses of print length in this function. Don't overflow print length
5039 index. Don't assume hash table size fits in 'long', or that
5040 vectorlike size fits in 'unsigned long'.
5041
31c286f7
PE
5042 * process.c (make_process): Use printmax_t, not int, to format
5043 process-name gensyms.
5044
55e5faa1
PE
5045 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5046
80f2e268
PE
5047 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5048 to avoid potential buffer overrun.
5049
670741ab
PE
5050 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5051 if X resource line is longer than 512 bytes.
5052
b7163a50
PE
5053 * xfns.c (x_window): Make sprintf buffer a bit bigger
5054 to avoid potential buffer overrun.
5055
ae58ff1f
PE
5056 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5057
c43c8a6a
PE
5058 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5059
3f8236f4
PE
50602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5061
53e9fe90 5062 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5063 Without these, Emacs silently mishandles large integers sometimes.
5064 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5065 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5066
6511acf2
PE
5067 * xdisp.c (try_window_id): Check Emacs fixnum range before
5068 converting to 'int'.
806add1d 5069
6511acf2 5070 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5071 Check that an Emacs fixnum is in range before assigning it to 'int'.
5072 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5073 values converted from Emacs fixnums.
5074 (Frecenter): Don't wrap around a line count if it is out of 'int'
5075 range; instead, treat it as an extreme value.
5076 (Fset_window_configuration, compare_window_configurations):
5077 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5078
6511acf2
PE
5079 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5080 that can exceed INT_MAX. Check that EMACS_INT value is in range
5081 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5082 (match_limit): Don't assume that a fixnum can fit in 'int'.
5083
6511acf2 5084 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5085 exceed INT_MAX.
5086
6511acf2 5087 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5088 (Fvertical_motion): Don't wrap around LINES values that don't fit
5089 in 'int'. Instead, treat them as extreme values. This is good
5090 enough for windows, which can't have more than INT_MAX lines anyway.
5091
fcb901a7
LMI
50922011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5093
0f2f6b6d
LMI
5094 * Require libxml/parser.h to avoid compilation warning.
5095
fcb901a7
LMI
5096 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5097
5098 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5099 since this reportedly can destroy thread storage.
5100
6e20a0d4
CY
51012011-08-30 Chong Yidong <cyd@stupidchicken.com>
5102
5103 * syntax.c (find_defun_start): Update all cache variables if
5104 exiting early (Bug#9401).
5105
148ae00e
EZ
51062011-08-30 Eli Zaretskii <eliz@gnu.org>
5107
f6cfbd8f
EZ
5108 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5109
148ae00e
EZ
5110 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5111 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5112 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5113
5114 * term.c (tty_append_glyph): New function.
5115 (produce_stretch_glyph): Static function and its prototype deleted.
5116
a66cfb1c
SM
5117 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5118 Add prototypes.
148ae00e 5119
c4a07a4c
PE
51202011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5121
5122 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5123 when checking :margin (Bug#9390).
5124 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5125 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5126 so that the name doesn't mislead. All uses changed.
5127
6bc8cd65
JB
51282011-08-28 Johan Bockgård <bojohan@gnu.org>
5129
5130 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5131 set_tty_hooks.
5132
dca4927e
EZ
51332011-08-27 Eli Zaretskii <eliz@gnu.org>
5134
5135 * xdisp.c (move_it_to): Don't bail out early when reaching
5136 position beyond to_charpos, if we are scanning backwards.
5137 (move_it_vertically_backward): When DY == 0, make sure we get to
5138 the first character in the line after the newline.
5139
f2cad773
PE
51402011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5141
5142 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5143 (ccl_driver): Do not generate an out-of-range pointer.
5144 (Fccl_execute_on_string): Remove unnecessary check for
5145 integer overflow, noted by Stefan Monnier in
5146 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5147 Remove a FIXME that didn't need fixing.
5148 Simplify the newly-introduced buffer reallocation code.
5149
0cae2cdb
JB
51502011-08-27 Juanma Barranquero <lekktu@gmail.com>
5151
5152 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5153
5fc295a4 51542011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5155
70c60eb2 5156 Integer and memory overflow issues (Bug#9196).
726e0ab1 5157
d31850da
PE
5158 * doc.c (get_doc_string): Rework so that
5159 get_doc_string_buffer_size is the actual buffer size, rather than
5160 being 1 less than the actual buffer size; this makes xpalloc more
5161 convenient.
5162
a69fbedb
PE
5163 * image.c (x_allocate_bitmap_record, cache_image):
5164 * xselect.c (Fx_register_dnd_atom):
5165 Simplify previous changes by using xpalloc.
5166
fe5c5d37
PE
5167 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5168 since either will do and ptrdiff_t is convenient with xpalloc.
5169
0065d054
PE
5170 * charset.c (charset_table_size)
5171 (struct charset_sort_data.priority): Now ptrdiff_t.
5172 (charset_compare): Don't overflow if priorities differ greatly.
5173 (Fsort_charsets): Don't assume list length fits in int.
5174 Check for size-calculation overflow when allocating sort data.
5175 (syms_of_charset): Allocate an initial charset table that is
5176 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5177
5178 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5179
5180 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5181 The actual value is always <= INT_MAX, and leaving it unsigned made
5182 overflow checking harder.
5183
5184 * dispextern.h (struct glyph_matrix.rows_allocated)
5185 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5186 with xpalloc. The values are still always <= INT_MAX.
5187
5188 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5189
5190 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5191 (SAFE_NALLOCA): New macro.
5192
5193 * region-cache.c (struct boundary.pos, find_cache_boundary)
5194 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5195 (set_cache_region, invalidate_region_cache)
5196 (revalidate_region_cache, know_region_cache, region_cache_forward)
5197 (region_cache_backward, pp_cache):
5198 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5199 so that ptrdiff_t * can be passed to xpalloc.
5200 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5201 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5202 (pp_cache): Don't assume cache_len fits in int.
5203 * region-cache.h: Adjust extern decls to match.
5204
5205 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5206 EMACS_INT, since either will do, for xpalloc.
5207
5208 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5209 (xnmalloc, xnrealloc, xpalloc): New functions.
5210
726e0ab1
PE
5211 * bidi.c (bidi_shelve_header_size): New constant.
5212 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5213 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5214
51f30bc5 5215 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5216 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5217 (overlay_strings):
5218 Don't update size of array until after memory allocation succeeds,
5219 because xmalloc/xrealloc may not return.
0065d054
PE
5220 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5221 now that we have proper integer overflow checking.
5222 (record_overlay_string, overlay_strings): Catch overflows when
5223 calculating size of overlay_str_buf.
726e0ab1 5224
0065d054
PE
5225 * callproc.c (Fcall_process): Check for size overflow when
5226 calculating size of args2.
5227 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5228 Normally we prefer signed values, but sticking with ptrdiff_t would
5229 require adding more-complicated checks.
726e0ab1
PE
5230
5231 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5232 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5233 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5234 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5235
5236 * character.c (Fstring): Check for size-calculation overflow.
5237
5238 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5239 unnecessary integer overflow. Check for size overflow.
5240 (encode_coding_object): Don't update size until xmalloc succeeds.
5241
5242 * composite.c (get_composition_id): Check for overflow in glyph
5243 length calculations.
5244
5245 Integer and memory overflow fixes for display code.
5246 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5247 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5248 (scrolling_window): Check for overflow in size calculations.
5249 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5250 Don't assume glyph table len fits in int.
5251 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5252 (row_table_size): Now ptrdiff_t, not int.
5253 (scrolling_window): Avoid overflow in size calculations.
5254 Don't update size until allocation succeeds.
5255 * fns.c (concat): Check for overflow in size calculations.
5256 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5257 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5258 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5259
5260 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5261 (get_doc_string): Check for size calculation overflow.
5262 Don't update size until allocation succeeds.
5263 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5264 EMACS_INT, where ptrdiff_t will do.
5265 (Fsubstitute_command_keys): Check for string overflow.
5266
5267 * editfns.c (set_time_zone_rule): Don't assume environment length
5268 fits in int.
5269 (message_length): Now ptrdiff_t, not int.
5270 (Fmessage_box): Don't update size until allocation succeeds.
5271 Don't assume message length fits in int.
5272 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5273
0065d054
PE
5274 * emacs.c (main): Do not reallocate argv, since there is a null at
5275 the end that can be overwritten, and this way there's no need to
5276 worry about size-calculation overflow.
5277 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5278
5279 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5280 alloc succeeds.
5281 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5282
5283 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5284 (x_set_scroll_bar_width, x_figure_window_size):
5285 Check for integer overflow.
5286 (x_set_alpha): Do not assume XINT fits in int.
5287
5288 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5289 This is for the members text_lines, text_cols, total_lines, total_cols,
5290 where the system imposes an 'int' limit.
5291
5292 * fringe.c (Fdefine_fringe_bitmap):
5293 Don't update size until alloc works.
5294
5295 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5296 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5297
5298 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5299 Check for size-calculation overflow.
5300 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5301 do, as we prefer signed integers.
5302 (id_to_widget.max_size, id_to_widget.used)
5303 (xg_store_widget_in_map, xg_remove_widget_from_map)
5304 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5305 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5306 Use and return ptrdiff_t, not int.
5307 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5308 * gtkutil.h: Change prototypes to match the above.
5309
5310 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5311 are duplicate now that they've been promoted to lisp.h.
5312 (x_allocate_bitmap_record, x_alloc_image_color)
5313 (make_image_cache, cache_image, xpm_load):
5314 Don't update size until alloc is done.
5315 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5316 (x_detect_edges):
3256efce 5317 Check for size calculation overflow.
726e0ab1
PE
5318 (ct_colors_allocated_max): New constant.
5319 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5320 overflow.
3256efce 5321
726e0ab1
PE
5322 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5323 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5324 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5325 Use ptrdiff_t, not int, to count maps.
5326 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5327 calculations. Don't update size until allocation succeeds.
5328 Redo calculations to avoid overflow.
726e0ab1
PE
5329 * keyboard.h: Change prototypes to match the above.
5330
5331 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5332 to count maps.
5333 (current_minor_maps): Check for size calculation overflow.
5334 * keymap.h: Change prototypes to match the above.
5335
5336 * lread.c (read1, init_obarray): Don't update size until alloc done.
5337
5338 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5339 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5340
726e0ab1
PE
5341 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5342 Now ptrdiff_t, not int.
5343 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5344 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5345
5346 * process.c (Fnetwork_interface_list): Check for overflow
5347 in size calculation.
5348
5349 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5350
5351 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5352 overflow. Don't bother calling xmalloc when xrealloc will do.
5353
5354 * search.c (Freplace_match): Check for size calculation overflow.
5355 (Fset_match_data): Don't assume list lengths fit in 'int'.
5356
5357 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5358 for command line length. Do not attempt to address one before the
5359 beginning of an array, as that's not portable.
5360
5361 * term.c (max_frame_lines): Remove; unused.
5362 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5363 not int.
5364 (encode_terminal_code, calculate_costs): Check for size
5365 calculation overflow.
5366 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5367 table lengths and related sizes. Don't update size until alloc
5368 done. Redo calculations to avoid overflow.
5369 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5370
5371 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5372 subtracting pointers.
5373 (gobble_line): Check for overflow more carefully. Don't update size
5374 until alloc done.
5375
5376 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5377 Don't update size until alloc done.
5378 Redo size calculations to avoid overflow.
5379 Check for size calculation overflow.
0065d054 5380 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5381
5382 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5383 Use ptrdiff_t, not int, for sizes.
5384 (store_mode_line_noprop_char): Don't update size until alloc done.
5385
0065d054
PE
5386 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5387 Use ptrdiff_t, not int, for sizes.
5388 (Finternal_make_lisp_face, cache_face):
5389 Check for size calculation overflow.
5390 (cache_face): Treat size calculation overflows as if they were
5391 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5392
5393 * xfns.c (x_encode_text, x_set_name_internal)
5394 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5395 sizes, since they can exceed INT_MAX in size. Check for size
5396 calculation overflow.
5397
0065d054
PE
5398 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5399 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5400 Don't update size until alloc done.
5401
0065d054 5402 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5403 as sprintf is limited to int lengths.
1d526e2f 5404
252c5ee1
PE
5405 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5406 (X_LONG_MIN): New macros.
864d7ce7
PE
5407 Use them to make the following changes clearer.
5408 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5409 This change doesn't affect the value now, but it may help remind
5410 future maintainers not to raise the value too much later.
5411 (SELECTION_QUANTUM): Remove, replacing with ...
5412 (selection_quantum): ... new function, which avoids overflow.
5413 All uses changed.
5414 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5415 assumption that selection length fits in 'int'.
5416 (x_reply_selection_request, x_handle_selection_request)
5417 (x_get_window_property, receive_incremental_selection)
5418 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5419 (lisp_data_to_selection_data, clean_local_selection_data):
5420 Use ptrdiff_t, not int, to record length of selection.
5421 (x_reply_selection_request, x_get_window_property)
5422 (receive_incremental_selection, x_property_data_to_lisp):
5423 Redo calculations to avoid overflow.
5424 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5425 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5426 something.
5427 (x_get_window_property, receive_incremental_selection)
5428 (lisp_data_to_selection_data, x_property_data_to_lisp):
5429 Check for size-calculation overflow.
5430 (x_get_window_property, receive_incremental_selection)
5431 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5432 Don't store size until memory allocation succeeds.
5433 (x_get_window_property): Plug memory leak on memory exhaustion.
5434 Don't double-block input; malloc is safe here. Don't assume 2**34
5435 - 4 fits in unsigned long. Add an xassert to check
5436 XGetWindowProperty overflow. Be more careful about overflow
5437 calculations, and distinguish size from memory overflow better.
5438 (receive_incremental_selection): When tracing, don't assume
5439 unsigned int is less than INT_MAX.
5440 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5441 harmful) conversions of unsigned short to int.
5442 (lisp_data_to_selection_data): Don't assume that integers
5443 in the range -65535 through -1 fit in an X unsigned short.
5444 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5445 result parameters unless successful. Rely on cons_to_unsigned
5446 to report problems with elements; the old code wasn't right anyway.
5447 (x_check_property_data): Check for int overflow; we cannot use
5448 a wider type due to X limits.
5449 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5450
726e0ab1 5451 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5452
0065d054
PE
5453 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5454 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5455 (x_color_cells): Don't store size until memory allocation succeeds.
5456 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5457 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5458 (x_term_init): Don't assume length fits in int (sprintf is limited
5459 to int size).
bc18e09d 5460
ebfa62c0
PE
5461 Use ptrdiff_t for composition IDs.
5462 * character.c (lisp_string_width):
5463 * composite.c (composition_table_size, n_compositions)
5464 (get_composition_id, composition_gstring_from_id):
5465 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5466 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5467 * window.c (Frecenter):
5468 Use ptrdiff_t, not int, for composition IDs.
5469 * composite.c (get_composition_id): Check for integer overflow.
5470 * composite.h: Adjust prototypes to match the above changes.
5471
d3411f89
PE
5472 Use ptrdiff_t for hash table indexes.
5473 * category.c (hash_get_category_set):
5474 * ccl.c (ccl_driver):
5475 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5476 * coding.c (coding_system_charset_list, detect_coding_system):
5477 * coding.h (struct coding_system.id):
5478 * composite.c (get_composition_id, gstring_lookup_cache):
5479 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5480 * image.c (xpm_get_color_table_h):
5481 * lisp.h (hash_lookup, hash_put):
5482 * minibuf.c (Ftest_completion):
5483 Use ptrdiff_t for hash table indexes, not int (which is too
5484 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5485 32-bit --with-wide-int hosts).
5486
e097a6fa
PE
5487 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5488 Add a FIXME comment about memory leaks.
5489 (syms_of_charset): Don't assume xmalloc returns.
5490
5637687f
PE
5491 Don't assume that stated character widths fit in int.
5492 * character.c (Fchar_width, c_string_width, lisp_string_width):
5493 * character.h (CHAR_WIDTH):
5494 * indent.c (MULTIBYTE_BYTES_WIDTH):
5495 Use sanitize_char_width to avoid undefined and/or bad behavior
5496 with outlandish widths.
a66cfb1c 5497 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5498 now that we have two such functions. All uses changed.
5499 (sanitize_char_width): New inline function.
5500
a2271ba2
PE
5501 Don't assume that tab-width fits in int.
5502 * character.h (sanitize_width): New inline function.
5503 (SANE_TAB_WIDTH): New macro.
5504 (ASCII_CHAR_WIDTH): Use it.
5505 * indent.c (sane_tab_width): Remove. All uses replaced by
5506 SANE_TAB_WIDTH (current_buffer).
5507 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5508
18c52557
PE
5509 * fileio.c: Integer overflow issues with file modes.
5510 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5511
caeeedc1
PE
5512 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5513 Remove unreachable code.
5514 (read_hex, load_charset_map_from_file): Check for integer overflow.
5515
6df6ae42 5516 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5517 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5518 (x_send_scroll_bar_event): Likewise. Check that the size does not
5519 exceed limits imposed by XClientMessageEvent, as well as the usual
5520 ptrdiff_t and size_t limits.
5521
b13995db
PE
5522 * keyboard.c: Overflow, signedness and related fixes.
5523 (make_lispy_movement): Use same integer type in forward decl
5524 that is used in the definition.
5525 (read_key_sequence, keyremap_step):
5526 Change bufsize argument back to int, undoing my 2011-03-30 change.
5527 We prefer signed types, and int is wide enough here.
5528 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5529 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5530 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5531 length, not size_t. Use ptrdiff_t for index, not int.
5532 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5533 possibility of integer overflow.
5534
13464394
PE
5535 Overflow, signedness and related fixes for images.
5536
5537 * dispextern.h (struct it.stack[0].u.image.image_id)
5538 (struct_it.image_id, struct image.id, struct image_cache.size)
5539 (struct image_cache.used, struct image_cache.ref_count):
5540 * gtkutil.c (update_frame_tool_bar):
5541 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5542 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5543 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5544 * nsmenu.m (update_frame_tool_bar):
5545 * xdisp.c (calc_pixel_width_or_height):
5546 * xfns.c (image_cache_refcount):
5547 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5548 on typical 64-bit hosts.
5549
5550 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5551 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5552 Omit unnecessary casts to int.
5553 (parse_image_spec): Check that integers fall into 'int' range
5554 when the callers expect that.
5555 (image_ascent): Redo ascent calculation to avoid int overflow.
5556 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5557 (lookup_image): Remove unnecessary tests.
5558 (xbm_image_p): Locals are now of int, not EMACS_INT,
5559 since parse_image_check makes sure they fit into int.
5560 (png_load, gif_load, svg_load_image):
5561 Prefer int to unsigned where either will do.
5562 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5563 old tiff_error_handler and tiff_warning_handler.
5564 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5565 stack buffer overflows. It uses only the features of vsnprintf
5566 that are common to both POSIX and native Microsoft.
5567 (tiff_error_handler, tiff_warning_handler): Use it.
5568 (tiff_load, gif_load, imagemagick_load_image):
5569 Don't assume :index value fits in 'int'.
5570 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5571 (imagemagick_load_image): Check that crop parameters fit into
5572 the integer types that MagickCropImage accepts. Don't assume
5573 Vimagemagick_render_type has a nonnegative value. Don't assume
5574 size_t fits in 'long'.
5575 (gs_load): Use printmax_t to print the widest integers possible.
5576 Check for integer overflow when computing image height and width.
5577
c11821d4
EZ
55782011-08-26 Eli Zaretskii <eliz@gnu.org>
5579
5580 * xdisp.c (redisplay_window): Don't force window start if point
5581 will be invisible in the resulting window. (Bug#9324)
5582
0c95fcf7
EZ
55832011-08-25 Eli Zaretskii <eliz@gnu.org>
5584
5585 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5586 the display spec is of the form `(space ...)'.
5587 (handle_display_spec): Return the value returned by
5588 handle_single_display_spec, not just 1 or zero.
5589 (handle_single_display_spec): If the display spec is of the form
5590 `(space ...)', and specifies display in the text area, return 2
5591 rather than 1.
fee65a97 5592 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5593 accurately, and prefer exact match for point under bidi.
5594 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5595
5596 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5597 into disp_prop; all users changed.
5598
5599 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5600 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5601 for the text covered by the display property.
5602
e4ed06f1
CY
56032011-08-25 Chong Yidong <cyd@stupidchicken.com>
5604
5605 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5606 Change return value to nil.
5607 (Frecord_buffer): Delete unused function.
5608
f67cdd7f
EZ
56092011-08-24 Eli Zaretskii <eliz@gnu.org>
5610
5980d4c6
EZ
5611 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5612 buffers, return left-to-right.
8610fe8b
EZ
5613 (set_cursor_from_row): Consider candidate row a win if its glyph
5614 represents a newline and point is on that newline. Fixes cursor
5615 positioning on the newline at EOL of R2L text within L2R
5616 paragraph, and vice versa.
5617 (try_cursor_movement): Check continued rows, in addition to
5618 continuation rows. Fixes unwarranted scroll when point enters a
5619 continued line of R2L text within an L2R paragraph, or vice versa.
5620 (cursor_row_p): Consider the case of point being equal to
5621 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5622 from the end of a short line to the beginning of a continued line
5623 of R2L text within L2R paragraph.
5624 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5625 composed characters.
5980d4c6 5626
f67cdd7f
EZ
5627 * bidi.c (bidi_check_type): Use xassert.
5628 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5629 members.
5630
bca633fb
EZ
56312011-08-23 Eli Zaretskii <eliz@gnu.org>
5632
5633 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5634 a character.
5635
4a5885a7
CY
56362011-08-23 Chong Yidong <cyd@stupidchicken.com>
5637
5638 * nsfont.m (ns_otf_to_script): Fix typo.
5639
0902a04e
KH
56402011-08-22 Kenichi Handa <handa@m17n.org>
5641
5642 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5643 extra slot even if the purpose is char-code-property-table.
5644
1a2e6670
EZ
56452011-08-23 Eli Zaretskii <eliz@gnu.org>
5646
8ddde651
EZ
5647 * xdisp.c (redisplay_window): When computing centering_position,
5648 account for the height of the header line. (Bug#8874)
5649
425cc014
EZ
5650 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5651 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5652 candidate is selected by the mouse, and that candidate has a
5653 composed character under the mouse.
5654
1a2e6670
EZ
5655 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5656 coordinates reported by pos-visible-in-window-p for a composed
5657 character in column zero.
5658
8b76d6f8
SM
56592011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5660
5661 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5662
dac347dd
EZ
56632011-08-22 Eli Zaretskii <eliz@gnu.org>
5664
5665 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5666 consider it a hit if to_charpos is anywhere in the range of the
5667 composed buffer positions.
5668
e013fb34
CY
56692011-08-22 Chong Yidong <cyd@stupidchicken.com>
5670
5671 * image.c (gif_load): Don't assume that each subimage has the same
5672 dimensions as the base image. Handle disposal method that is
5673 "undefined" by the gif spec (Bug#9335).
5674
bd1ba3e8
CY
56752011-08-20 Chong Yidong <cyd@stupidchicken.com>
5676
5677 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5678 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5679
54a1215b
EZ
56802011-08-19 Eli Zaretskii <eliz@gnu.org>
5681
823564e5
EZ
5682 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5683 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5684 from an Org mode buffer to a Speedbar frame.
5685
54a1215b
EZ
5686 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5687 a composition, take its buffer position from IT->cmp_it.charpos.
5688 Fixes cursor positioning at the beginning of a line that begins
5689 with a composed character.
5690
9778ebcc
EZ
56912011-08-18 Eli Zaretskii <eliz@gnu.org>
5692
0be6ee06
EZ
5693 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5694 character bidirectional type, use STRONG_L instead. Fixes crashes
5695 in a buffer produced by `describe-categories'.
5696
9778ebcc
EZ
5697 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5698 members before the level stack, so they would be saved and
5699 restored when copying iterator state. Fixes incorrect reordering
5700 around TABs covered by display properties.
5701
156bffbe
AS
57022011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5703
6b02f655 5704 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5705
72ad093b
CY
57062011-08-17 Chong Yidong <cyd@stupidchicken.com>
5707
5708 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5709 (internal_condition_case_2, internal_condition_case_n):
5710 Remove unnecessary aborts (Bug#9081).
72ad093b 5711
35774242
EZ
57122011-08-17 Eli Zaretskii <eliz@gnu.org>
5713
5714 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5715 has no `load' handler, try opening the file locally. (Bug#9311)
5716
db76dd85
KB
57172011-08-16 Ken Brown <kbrown@cornell.edu>
5718
5719 * gmalloc.c: Expand comment.
5720
b215eee5
EZ
57212011-08-16 Eli Zaretskii <eliz@gnu.org>
5722
5723 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5724 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5725
a4579d33
KB
57262011-08-16 Ken Brown <kbrown@cornell.edu>
5727
5728 Fix memory allocation problems in Cygwin build (Bug#9273).
5729
5730 * unexcw.c ( __malloc_initialized): Declare external variable.
5731 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5732
8b76d6f8
SM
5733 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5734 New variables.
a4579d33
KB
5735 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5736 dumped emacs.
5737 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5738 in the static heap.
5739 [CYGWIN] (special_realloc): New function.
5740 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5741 requests to realloc storage in the static heap.
5742
3ebec551
PE
57432011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5744
5745 * bidi.c (bidi_initialize): Remove unused local.
5746
9fd8be00
EZ
57472011-08-15 Eli Zaretskii <eliz@gnu.org>
5748
6b02f655
SM
5749 * bidimirror.h:
5750 * biditype.h: Remove file.
5751 * makefile.w32-in ($(BLD)/bidi.$(O)):
5752 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5753
5754 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5755
5756 * chartab.c: Improve commentary for the uniprop_table API.
5757
32413314
EZ
5758 * bidi.c (bidi_paragraph_init): Support zero value of
5759 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5760 (bidi_initialize): Use uniprop_table instead of including
5761 biditype.h and bidimirror.h.
32413314 5762
9fd8be00
EZ
5763 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5764 coordinates of the iterator when restoring from ppos_it.
5765 (Bug#9296)
5766
5cf2b69b
KH
57672011-08-14 Kenichi Handa <handa@m17n.org>
5768
5769 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5770 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5771
daf17d00
EZ
57722011-08-14 Eli Zaretskii <eliz@gnu.org>
5773
5774 * xdisp.c (move_it_in_display_line_to): Don't invoke
5775 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5776 ppos_it. Fixes vertical cursor motion when line beginning is
5777 covered by an image. (Bug#9296)
5778
08e3161a
JD
57792011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5780
5781 * nsterm.h (ns_run_ascript): Declare.
5782 (NSAPP_DATA2_RUNASSCRIPT): Define.
5783
5784 * nsfns.m (as_script, as_result, as_status): New static variables.
5785 (ns_run_ascript): New function.
5e617bc2 5786 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5787 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5788 the event loop. Get status from as_status (Bug#7276).
5789
5790 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5791 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5792 the event loop (Bug#7276).
5793
a3720aa2
AS
57942011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5795
5796 * gnutls.c (QCgnutls_bootprop_priority)
5797 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5798 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5799 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5800 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5801 (QCgnutls_bootprop_verify_hostname_error)
5802 (QCgnutls_bootprop_callbacks_verify): Rename from
5803 Qgnutls_bootprop_..., all uses changed.
5804
5805 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5806 uses changed.
5807
0a0d27fb
PE
58082011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5809
19d5c50c
PE
5810 * xfaces.c (Qframe_set_background_mode): Now static.
5811 * dispextern.h (Qframe_set_background_mode): Remove decl.
5812
0a0d27fb
PE
5813 * process.c (Fnetwork_interface_info): Declare local only if needed.
5814
377538cb
JD
58152011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5816
5817 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5818 (Fnetwork_interface_list): Allocate in increments of bytes instead
5819 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5820 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5821 sockaddr.
5822 (struct ifflag_def): notrailers is smart on OSX.
5823 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5824 Get hardware address with getifaddrs if available.
5825
08fff70c
EZ
58262011-08-12 Eli Zaretskii <eliz@gnu.org>
5827
5828 * xdisp.c (iterate_out_of_display_property): xassert that
5829 IT->position is set to within IT->object's boundaries. Break from
5830 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5831 when IT->position is set up wrongly due to some bug.
5832 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5833 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5834 entry. Force push_it to save on the stack the current
5835 buffer/string position, to be restored by pop_it. Fix flags in
5836 the iterator structure wrt the object coming from a display
5837 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5838 properties. (Bug#9284)
5839
7be1c708 58402011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5841
7be1c708
CY
5842 * fontset.c (fontset_get_font_group): Add proper type checks.
5843 (Bug#9172)
aac0c6e3 5844
7be1c708 58452011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5846
7be1c708
CY
5847 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5848 and LC_VERSION_MIN_MACOSX.
5849 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5850 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5851
97bb72a6
EZ
58522011-08-08 Eli Zaretskii <eliz@gnu.org>
5853
5854 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5855 no-display-properties-and-no-overlays under bidi display.
5856 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5857 properties and overlays.
97bb72a6 5858
d5617611
CY
58592011-08-08 Chong Yidong <cyd@stupidchicken.com>
5860
37e11a63
CY
5861 * editfns.c (Fset_time_zone_rule): Document relationship with the
5862 setenv function.
5863
d5617611
CY
5864 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5865 the font entity extracted from the cache (Bug#8109).
5866
58872834
CY
58672011-08-07 Chong Yidong <cyd@stupidchicken.com>
5868
5869 * composite.c (autocmp_chars): Don't reset point. That is done by
5870 restore_point_unwind (Bug#5984).
5871
75bfc667
JL
58722011-08-07 Juri Linkov <juri@jurta.org>
5873
5874 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5875 to show the arg `TIME' instead of `TIMEVAL'.
5876
d1410150
EZ
58772011-08-06 Eli Zaretskii <eliz@gnu.org>
5878
5879 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5880 display property strides EOL and includes a newline, as in
5881 longlines-mode. (Bug#9254)
75b771e4
EZ
5882 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5883 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5884
5885 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5886 is non-zero, even if the data buffer is NULL. Fixes a crash in
5887 vertical-motion with longlines-mode. (Bug#9254)
5888
35928349
EZ
58892011-08-05 Eli Zaretskii <eliz@gnu.org>
5890
ec7cc85b
EZ
5891 * bidi.c <bidi_cache_total_alloc>: Now static.
5892 (bidi_initialize): Initialize bidi_cache_total_alloc.
5893
8b76d6f8 5894 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5895 cache. (Bug#9221)
5896
5897 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5898 amount allocated this far in `bidi_cache_total_alloc'.
5899 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5900 non-zero, only free the data buffer without restoring the cache
5901 contents. All callers changed.
5902
5903 * dispextern.h (bidi_unshelve_cache): Update prototype.
5904
5905 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5906 (move_it_in_display_line, move_it_to)
5907 (move_it_vertically_backward, move_it_by_lines): Replace the call
5908 to xfree to an equivalent call to bidi_unshelve_cache.
5909 (move_it_in_display_line_to): Fix logic of returning
412b6358 5910 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5911
e2e2423b
EZ
59122011-08-05 Eli Zaretskii <eliz@gnu.org>
5913
5914 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5915 came from a string character with a `cursor' property. (Bug#9229)
5916
ae9e757a
JD
59172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5918
5919 * Makefile.in (LIB_PTHREAD): New variable.
5920 (LIBES): Add LIB_PTHREAD (Bug#9216).
5921
5922 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5923 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5924
213bd7f2
AS
59252011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5926
6b02f655 5927 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5928
99aaf75f
JD
59292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5930
5931 * xterm.c (x_find_topmost_parent): New function.
5932 (x_set_frame_alpha): Find topmost parent window with
5933 x_find_topmost_parent and set the property there also (bug#9181).
5934 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5935
c74e9d86
PE
59362011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 * callproc.c (Fcall_process): Avoid vfork clobbering
5939 the local vars buffer, coding_systems, current_dir.
5940
640c8776
SM
59412011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5942
5943 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5944
f26d0e4c
PE
59452011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5946
8a10d76c
PE
5947 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5948 so that it is not optimized away.
5949
f26d0e4c
PE
5950 * xdisp.c (compute_display_string_pos): Remove unused local.
5951
55439c61
EZ
59522011-08-02 Eli Zaretskii <eliz@gnu.org>
5953
5954 Fix slow cursor motion and scrolling in large buffers with
5955 selective display, like Org Mode buffers. (Bug#9218)
5956
5957 * dispextern.h (struct bidi_it): New member disp_prop_p.
5958
5959 * xdisp.c: Remove one-slot cache of display string positions.
5960 (compute_display_string_pos): Accept an additional argument
5e617bc2 5961 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5962 for a display string or property. If found, set DISP_PROP_P
5963 non-zero.
5964
5965 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5966 DISP_PROP_P, and pass it to compute_display_string_pos.
5967 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5968 non-zero. All callers of bidi_fetch_char changed.
5969
fb33fa43
SM
59702011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5971
5972 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5973
b099e063
DM
59742010-12-03 Don March <don@ohspite.net>
5975
5976 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5977 last character M-[char] is translated to ESC [char] (bug#7541).
5978
5cc7f7af
KH
59792011-08-02 Kenichi Handa <handa@m17n.org>
5980
d0fffa3f 5981 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5982
5983 * chartab.c (uniprop_table): Make it non-static.
5984
525d5e6e
EZ
59852011-08-01 Eli Zaretskii <eliz@gnu.org>
5986
5987 * xdisp.c (forward_to_next_line_start): Accept additional argument
5988 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5989 on the newline.
5990 (reseat_at_next_visible_line_start): Use the bidi iterator state
5991 returned by forward_to_next_line_start to restore the state of
5992 it->bidi_it after backing up to previous newline. (Bug#9212)
5993
31011111
AS
59942011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5995
5996 * regex.c (re_comp): Protoize.
5997 (re_exec): Fix return type.
5998 (regexec): Fix type of `ret'. (Bug#9203)
5999
476371c4
PE
60002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6001
e5d76069
PE
6002 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6003 This is needed if max-image-size is a floating-point number.
6004
9a79b20c
AS
60052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6006
6007 * print.c (print_object): Print empty symbol as ##.
6008
6009 * lread.c (read1): Read ## as empty symbol.
6010
d8c2fa78
AA
60112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6012
6013 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6014 setting frame foreground color (Bug#9175).
6015 (x_set_background_color): Likewise.
6016
ffe57a7a
AA
6017 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6018 contents (Bug#9176).
6019 (EmacsTooltip -init): Remove bezels and add shadows to
6020 tooltip windows.
6021
bf3492a5
AA
6022 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6023 or scroll bar (Bug#8470).
6024
d55e9c53
AA
6025 * nsfont.m (nsfont_open): Remove assignment to voffset and
6026 unnecessary vars hshink, expand, hd, full_height, min_height.
6027 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6028
6029 * nsterm.h (nsfont_info): Remove voffset field.
6030
d8c2fa78 60312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6032
6033 Implement strike-through and overline on NextStep (Bug#8863).
6034
6035 * nsfont.m (nsfont_open): Use underline position provided by font,
6036 instead of hard-coded value of 2.
6037 (nsfont_draw): Call ns_draw_text_decoration instead.
6038
6039 * nsterm.h: Add declaration for ns_draw_text_decoration.
6040
6041 * nsterm.m (ns_draw_text_decoration): New function for drawing
6042 underline, overline, and strike-through.
6043 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6044 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6045 accommodate underlining, etc.
4843aac3 6046
4cc60b9b
EZ
60472011-07-28 Eli Zaretskii <eliz@gnu.org>
6048
bc7ece87
EZ
6049 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6050 default.
4cc60b9b 6051
476371c4
PE
60522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6053
66606eea
PE
6054 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6055 Without this fix, if a signal arrives just after memory fills up,
6056 'malloc' might be invoked reentrantly.
6057
476371c4
PE
6058 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6059 In other words, assume that every image size is allowed, on non-X
6060 hosts. This assumption is probably wrong, but it lets Emacs compile.
6061
f3fcc40d
AS
60622011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6063
6064 * regex.c (re_iswctype): Convert return values to boolean.
6065
350c992f
EZ
60662011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6067
6068 * xdisp.c (compute_display_string_pos): Don't use cached display
6069 string position if the buffer had its restriction changed.
6070 (Bug#9184)
6071
5266b4bb
PE
60722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6073
6074 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6075
2573a837 60762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6077
41f55ccd 6078 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6079
39e378da
PE
6080 * bidi.c: Integer size and overflow fixes.
6081 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6082 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6083 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6084 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6085 (bidi_find_other_level_edge):
6086 Use ptrdiff_t instead of EMACS_INT where either will do.
6087 This works better on 32-bit hosts configured --with-wide-int.
6088 (bidi_cache_ensure_space): Check for size-calculation overflow.
6089 Use % rather than repeated addition, for better worst-case speed.
6090 Don't set bidi_cache_size until after xrealloc returns, because it
6091 might not return.
6092 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6093 (bidi_cache_ensure_space): Also check that the bidi cache size
6094 does not exceed that of the largest Lisp string or buffer. See Eli
6095 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6096
5e927815
PE
6097 * alloc.c (__malloc_size_t): Remove.
6098 All uses replaced by size_t. See Andreas Schwab's note
6099 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6100
ca4aa935
PE
6101 * image.c: Improve checking for integer overflow.
6102 (check_image_size): Assume that f is nonnull, since
6103 it is always nonnull in practice. This is one less thing to
6104 worry about when checking for integer overflow later.
6105 (x_check_image_size): New function, which checks for integer
6106 overflow issues inside X.
6107 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6108 This removes the need for a memory_full check.
6109 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6110 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6111 (xbm_read_bitmap_data): Change locals back to 'int', since
6112 their values must fit in 'int'.
6113 (xpm_load_image, png_load, tiff_load):
6114 Invoke x_create_x_image_and_pixmap earlier,
6115 to avoid much needless work if the image is too large.
6116 (tiff_load): Treat overly large images as if
6117 x_create_x_image_and_pixmap failed, not as malloc failures.
6118 (gs_load): Use x_check_image_size.
6119
5f8f9cc2
PE
6120 * gtkutil.c: Omit integer casts.
6121 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6122 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6123
5adf60bc
PE
6124 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6125
c8907a93
PE
6126 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6127 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6128 would wrongly return t on a 64-bit host.
6129
e3c25c68
PE
6130 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6131 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6132 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6133 and therefore cause GCC to emit a bogus diagnostic in some cases.
6134
3f791afe
PE
6135 * image.c: Integer signedness and overflow and related fixes.
6136 This is not an exhaustive set of fixes, but it's time to
6137 record what I've got.
6138 (lookup_pixel_color, check_image_size): Remove redundant decls.
6139 (check_image_size): Don't assume that arbitrary EMACS_INT values
6140 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6141 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6142 (tiff_load, imagemagick_load_image):
6143 Check for overflow in size calculations.
6144 (x_create_x_image_and_pixmap): Remove unnecessary test for
6145 xmalloc returning NULL; that can't happen.
6146 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6147 (xpm_color_bucket): Use better integer hashing function.
6148 (xpm_cache_color): Don't possibly over-allocate memory.
6149 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6150 (gif_memory_source):
6151 Use ptrdiff_t, not int or size_t, to record sizes.
6152 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6153 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6154 either works, as we prefer signed integers.
6155 (tiff_read_from_memory, tiff_write_from_memory):
6156 Return tsize_t, not size_t, since that's what the TIFF API wants.
6157 (tiff_read_from_memory): Don't fail simply because the read would
6158 go past EOF; instead, return a short read.
6159 (tiff_load): Omit no-longer-needed casts.
6160 (Fimagemagick_types): Don't assume size fits into 'int'.
6161
3cc5a532
PE
6162 Improve hashing quality when configured --with-wide-int.
6163 * fns.c (hash_string): New function, taken from sxhash_string.
6164 Do not discard information about ASCII character case; this
6165 discarding is no longer needed.
6166 (sxhash-string): Use it. Change sig to match it. Caller changed.
6167 * lisp.h: Declare it.
6168 * lread.c (hash_string): Remove, since we now use fns.c's version.
6169 The fns.c version returns a wider integer if --with-wide-int is
6170 specified, so this should help the quality of the hashing a bit.
6171
b312a492
PE
6172 * emacs.c: Integer overflow minor fix.
6173 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6174 Define only if GNU_LINUX.
6175 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6176
dfd153ae
PE
6177 * dispnew.c: Integer signedness and overflow fixes.
6178 Remove unnecessary forward decls, that were a maintenance hassle.
6179 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6180 All uses changed.
6181 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6182 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6183 (prepare_desired_row, line_draw_cost):
6184 Use int, not unsigned, where either works.
6185 (save_current_matrix, restore_current_matrix):
6186 Use ptrdiff_t, not size_t, where either works.
6187 (init_display): Check for overflow more accurately, and without
6188 relying on undefined behavior.
6189
a81d11a3
PE
6190 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6191 Remove, replacing with the new symbols in lisp.h. All uses changed.
6192 * fileio.c (make_temp_name):
6193 * filelock.c (lock_file_1, lock_file):
6194 * xdisp.c (message_dolog):
6195 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6196 Use pMd etc. instead.
6197 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6198 replacing the pWIDE etc. symbols removed from editfns.c.
6199
3300e6fd
PE
6200 * keyboard.h (num_input_events): Now uintmax_t.
6201 This is (very slightly) less likely to mess up due to wraparound.
6202 All uses changed.
6203
fd05c7e9
PE
6204 * buffer.c: Integer signedness fixes.
6205 (alloc_buffer_text, enlarge_buffer_text):
6206 Use ptrdiff_t rather than size_t when either will do, as we prefer
6207 signed integers.
6208
903fe15d
PE
6209 * alloc.c: Integer signedness and overflow fixes.
6210 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6211 (__malloc_size_t): Default to size_t, not to int.
6212 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6213 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6214 Prefer ptrdiff_t to size_t when either would do, as we prefer
6215 signed integers.
6216 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6217 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6218 Now const. Initialize with values that are in range even if char
6219 is signed.
6220 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6221 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6222 These functions do the right thing with sizes > 2**32.
6223 (check_depth): Now ptrdiff_t, not int.
6224 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6225 Adjust to new way of storing sizes. Check for size overflow bugs
6226 in rest of code.
6227 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6228 slightly wrong anyway, as it missed one instance of
6229 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6230 (refill_memory_reserve): Omit needless cast to size_t.
6231 (mark_object_loop_halt): Mark as externally visible.
6232
ac82cc6a
PE
6233 * xselect.c: Integer signedness and overflow fixes.
6234 (Fx_register_dnd_atom, x_handle_dnd_message):
6235 Use ptrdiff_t, not size_t, since we prefer signed.
6236 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6237 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6238 x_dnd_atoms_size and x_dnd_atoms_length.
6239
c2d1e36d
PE
6240 * doprnt.c: Prefer signed to unsigned when either works.
6241 * eval.c (verror):
6242 * doprnt.c (doprnt):
6243 * lisp.h (doprnt):
6244 * xdisp.c (vmessage):
6245 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6246 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6247 prefer signed arithmetic to avoid comparison confusion.
6248 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6249 but is a bit tricky.
6250
0e926e56
PE
6251 Assume freestanding C89 headers, string.h, stdlib.h.
6252 * data.c, doprnt.c, floatfns.c, print.c:
6253 Include float.h unconditionally.
6254 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6255 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6256 * regex.c: Likewise for stddef.h, string.h.
6257 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6258 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6259 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6260 (STDC_HEADERS): Remove obsolete defines.
6261 * sysdep.c: Include limits.h unconditionally.
6262
9cfdb3ec
PE
6263 Assume support for memcmp, memcpy, memmove, memset.
6264 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6265 * regex.c (memcmp, memcpy):
6266 Remove; we assume C89 now.
6267
6268 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6269 (__malloc_safe_bcopy): Remove; no longer needed.
6270
cf950e6b 6271 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6272 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6273 well either way, and we prefer signed to unsigned.
6274
dbf38e02
LMI
62752011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6276
6277 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6278 closes the connection while we're reading (bug#9182).
6279
d6f0886c 62802011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6281
d6f0886c
JD
6282 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6283 are specified (Bug#9168).
24e0f6b1 6284
2eb1f9e6
PE
62852011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6286
6287 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6288 Found by GCC static checking and --with-wide-int on a 32-bit host.
6289
22381272 62902011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6291
6292 * xdisp.c (compute_display_string_pos): Fix logic of caching
6293 previous display string position. Initialize cached_prev_pos to
6294 -1. Fixes slow-down at the beginning of a buffer.
6295
f25e39b4
EZ
62962011-07-24 Eli Zaretskii <eliz@gnu.org>
6297
6298 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6299 for attrs[LFACE_FONTSET_INDEX].
6300
04c4b52e
PE
63012011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6302
6303 * xml.c (parse_region): Remove unused local
6304 that was recently introduced.
6305
c1734fbd
EZ
63062011-07-23 Eli Zaretskii <eliz@gnu.org>
6307
be18c5a5
EZ
6308 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6309 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6310
c1734fbd
EZ
6311 * xdisp.c (move_it_in_display_line_to): Record the best matching
6312 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6313 exit if none of the characters scanned was an exact match.
6314 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6315 when exact match is impossible due to invisible text, and the
6316 lines are truncated.
6317
a258d627
JD
63182011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6319
6320 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6321 for OSX >= 10.7.
6322
b6d5a689
EZ
63232011-07-22 Eli Zaretskii <eliz@gnu.org>
6324
0f74f785
EZ
6325 Fix a significant slow-down of cursor motion with C-n, C-p,
6326 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6327 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6328 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6329 (next_element_from_buffer): Call compute_stop_pos_backwards to
6330 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6331 base_level_stop.
6332 (reseat): Don't look for prev_stop, as that could mean a very long
6333 run.
6334 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6335 <cached_disp_overlay_modiff>: Cache for last found display string
6336 position.
551918c1 6337 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6338 about the same buffer in the same area of character positions, and
6339 the buffer wasn't changed since the time the display string
6340 position was cached.
551918c1 6341
b2d0c91a
EZ
63422011-07-22 Eli Zaretskii <eliz@gnu.org>
6343
6344 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6345 is an integer, which is important for empty lines. (Bug#9149)
6346
043604ee
CY
63472011-07-22 Chong Yidong <cyd@stupidchicken.com>
6348
6349 * frame.c (Fmodify_frame_parameters): In tty case, update the
6350 default face if necessary (Bug#4238).
6351
da4adb04
CY
63522011-07-21 Chong Yidong <cyd@stupidchicken.com>
6353
6354 * editfns.c (Fstring_to_char): No need to explain what a character
6355 is in the docstring (Bug#6576).
6356
9abd0532
LMI
63572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6358
6359 * xml.c (parse_region): Make sure we always return a tree.
6360
36881d16
HK
63612011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6362
6363 * xml.c (parse_region): If a document contains only comments,
6364 return that, too.
6365
1e98674d
LMI
63662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6367
6368 * xml.c (make_dom): Return comments, too.
6369
590bd467
PE
63702011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6371
6372 Port to OpenBSD.
6373 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6374 and the surrounding thread.
6375 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6376 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6377 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6378 timer goes off.
6379 * s/openbsd.h (BROKEN_SIGIO): Define.
6380 * unexelf.c (unexec) [__OpenBSD__]:
6381 Don't update the .mdebug section of the Alpha COFF symbol table.
6382
f41628b2
LMI
63832011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6384
6385 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6386 (bug#8460).
6387
b59b67c5
PE
63882011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6389
15e3a074
PE
6390 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6391 This fixes some race conditions on the permissions of any newly
6392 created file.
6393
41bed37d
PE
6394 * alloc.c (valid_pointer_p): Use pipe, not open.
6395 This fixes some permissions issues when debugging.
6396
b59b67c5
PE
6397 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6398 If fchown fails to set both uid and gid, try to set just gid,
6399 as that is sometimes allowed. Adjust the file's mode to eliminate
6400 setuid or setgid bits that are inappropriate if fchown fails.
6401
925a6be7
SM
64022011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6403
6404 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6405 to compare Lisp_Objects.
6406 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6407 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6408 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6409
52968808
AS
64102011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6411
0a6a104b
AS
6412 * lread.c (read_integer): Unread even EOF character.
6413 (read1): Likewise. Properly record start position of symbol.
6414
52968808
AS
6415 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6416 symbol character follows.
6417
9e381cdd
PE
64182011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6419
6420 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6421 This works around a problem with the previous change to Fcopy_file.
6422 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6423 and without this change, GCC might complain about discarding
6424 fchown's return value.
6425
b5641435
JB
64262011-07-16 Juanma Barranquero <lekktu@gmail.com>
6427
6428 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6429
a8031457
PE
64302011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6431
6432 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6433
dd889327
LMI
64342011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6435
750c33f7
LMI
6436 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6437 it's used from the C level.
6438
dd889327
LMI
6439 * process.c: Use the same condition for POLL_FOR_INPUT in both
6440 keyboard.c and process.c (bug#1858).
6441
87e86684
LM
64422011-07-09 Lawrence Mitchell <wence@gmx.li>
6443
6444 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6445 (Fgnutls_boot): Use it.
6446
64348f40
AS
64472011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6448
6449 * doc.c (Fsubstitute_command_keys): Revert last change.
6450
1d698799
LMI
64512011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6452
f863868c
LMI
6453 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6454 quotes the next character, and doesn't affect other longer
6455 sequences (bug#8935).
6456
1d698799
LMI
6457 * lread.c (syms_of_lread): Clarify that is isn't only
6458 `eval-buffer' and `eval-defun' that's affected by
6459 `lexical-binding' (bug#8460).
6460
aa4b6df6
EZ
64612011-07-15 Eli Zaretskii <eliz@gnu.org>
6462
6463 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6464 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6465
5d856da6
PE
64662011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6467
ad6042bb
PE
6468 Fix minor problems found by static checking.
6469 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6470 (elsz): Now a signed constant, not a size_t var. We prefer signed
6471 types to unsigned, to avoid integer comparison confusion. Without
6472 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6473 "cannot optimize loop, the loop counter may overflow", a symptom
6474 of the confusion.
f00bbb22 6475 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6476 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6477
6468f31c
LMI
64782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6479
49080b10
LMI
6480 * search.c (Fre_search_backward): Mention `case-fold-search' in
6481 all the re_search_* functions (bug#8138).
6482
6468f31c
LMI
6483 * keyboard.c (Fopen_dribble_file): Document when the file is
6484 closed (bug#8056).
6485
c965adc5
EZ
64862011-07-14 Eli Zaretskii <eliz@gnu.org>
6487
df9733bf
EZ
6488 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6489 bidi_cache_idx.
6490
0bb23927
EZ
6491 Support bidi reordering of display and overlay strings.
6492 * xdisp.c (compute_display_string_pos)
6493 (compute_display_string_end): Accept additional argument STRING.
6494 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6495 (reseat_to_string): Initialize bidi_it->string.s and
6496 bidi_it->string.schars.
6497 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6498 NULL (avoids a crash in bidi_paragraph_init).
6499 Initialize itb.string.lstring.
0bb23927
EZ
6500 (init_iterator): Call bidi_init_it only of a valid
6501 buffer position was specified. Initialize paragraph_embedding to
6502 L2R.
6503 (reseat_to_string): Initialize the bidi iterator.
6504 (display_string): If we need to ignore text properties of
6505 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6506 original value of -1 will not work with bidi.)
6507 (compute_display_string_pos): First arg is now struct
6508 `text_pos *'; all callers changed. Support display properties on
6509 Lisp strings.
6510 (compute_display_string_end): Support display properties on Lisp
6511 strings.
6512 (init_iterator, reseat_1, reseat_to_string): Initialize the
6513 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6514 when iterating on a string not from display properties).
640c8776
SM
6515 (compute_display_string_pos, compute_display_string_end):
6516 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6517 arrow keys.
6518 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6519 base_level_stop; instead, set base_level_stop to BEGV.
6520 Fixes crashes in vertical-motion.
0bb23927
EZ
6521 (next_element_from_buffer): Improve commentary for when
6522 the iterator is before prev_stop.
6523 (init_iterator): Initialize bidi_p from the default value of
6524 bidi-display-reordering, not from buffer-local value. Use the
6525 buffer-local value only if initializing for buffer iteration.
6526 (handle_invisible_prop): Support invisible properties on strings
6527 that are being bidi-reordered.
6528 (set_iterator_to_next): Support bidi reordering of C strings and
6529 Lisp strings.
6530 (next_element_from_string): Support bidi reordering of Lisp
6531 strings.
6532 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6533 (display_string): Support display of R2L glyph rows.
6534 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6535 (init_iterator): Don't initialize it->bidi_p for strings
6536 here.
6537 (reseat_to_string): Initialize it->bidi_p for strings here.
6538 (next_element_from_string, next_element_from_c_string)
6539 (next_element_from_buffer): Add xassert's for correspondence
6540 between IT's object being iterated and it->bidi_it.string
6541 structure.
6542 (face_before_or_after_it_pos): Support bidi iteration.
6543 (next_element_from_c_string): Handle the case of the first string
6544 character that is not the first one in the visual order.
6545 (get_visually_first_element): New function, refactored from common
6546 parts of next_element_from_buffer, next_element_from_string, and
6547 next_element_from_c_string.
6548 (tool_bar_lines_needed, redisplay_tool_bar)
6549 (display_menu_bar): Force left-to-right direction. Add a FIXME
6550 comment for making that be controlled by a user option.
6551 (push_it, pop_it): Save and restore the state of the
6552 bidi iterator. Save and restore the bidi_p flag.
6553 (pop_it): Iterate out of display property for string iteration as
6554 well.
6555 (iterate_out_of_display_property): Support iteration over strings.
6556 (handle_single_display_spec): Set up it->bidi_it for iteration
6557 over a display string, and call bidi_init_it.
6558 (handle_single_display_spec, next_overlay_string)
6559 (get_overlay_strings_1, push_display_prop): Set up the bidi
6560 iterator for displaying display or overlay strings.
6561 (forward_to_next_line_start): Don't use the shortcut if
6562 bidi-iterating.
6563 (back_to_previous_visible_line_start): If handle_display_prop
6564 pushed the iterator stack, restore the internal state of the bidi
6565 iterator by calling bidi_pop_it same number of times.
6566 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6567 and we are bidi-iterating, don't decrement the iterator position;
6568 instead, set the first_elt flag in the bidi iterator, to produce
6569 the same effect.
6570 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6571 (push_display_prop): xassert that we are iterating a buffer.
6572 (push_it, pop_it): Save and restore paragraph_embedding member.
6573 (handle_single_display_spec, next_overlay_string)
6574 (get_overlay_strings_1, reseat_1, reseat_to_string)
6575 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6576 correctly. Don't assume unibyte strings are not bidi-reordered.
6577 (compute_display_string_pos)
6578 (compute_display_string_end): Fix handling the case of C string.
6579 (push_it, pop_it): Save and restore from_disp_prop_p.
6580 (handle_single_display_spec, push_display_prop): Set the
6581 from_disp_prop_p flag.
6582 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6583 (pop_it): Call iterate_out_of_display_property only if we are
6584 popping after iteration over a string that came from a display
6585 property. Fix a typo in popping stretch info. Add an assertion
6586 for verifying that the iterator position is in sync with the bidi
6587 iterator.
6588 (handle_single_display_spec, get_overlay_strings_1)
6589 (push_display_prop): Fix initialization of paragraph direction for
6590 string when that of the parent object is not yet determined.
6591 (reseat_1): Call bidi_init_it to resync the bidi
6592 iterator with IT's position. (Bug#7616)
6593 (find_row_edges): If ROW->start.pos gives position
6594 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6595 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6596 Reset the from_disp_prop_p flag.
6597 (SAVE_IT, RESTORE_IT): New macros.
6598 (pos_visible_p, face_before_or_after_it_pos)
6599 (back_to_previous_visible_line_start)
6600 (move_it_in_display_line_to, move_it_in_display_line)
6601 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6602 (try_scrolling, redisplay_window, display_line): Use them when
6603 saving a temporary copy of the iterator and restoring it back.
6604 (back_to_previous_visible_line_start, reseat_1)
6605 (init_iterator): Empty the bidi cache "stack".
6606 (move_it_in_display_line_to): If iterator ended up at
6607 EOL, but we never saw any buffer positions smaller than
6608 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6609 motion in bidi-reordered lines.
6610 (move_it_in_display_line_to): Record prev_method and prev_pos
6611 immediately before the call to set_iterator_to_next. Fixes cursor
6612 motion in bidi-reordered lines with stretch glyphs and strings
6613 displayed in margins. (Bug#8133) (Bug#8867)
6614 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6615 TO_CHARPOS.
640c8776
SM
6616 (pos_visible_p): Support positions in bidi-reordered lines.
6617 Save and restore bidi cache.
0bb23927
EZ
6618
6619 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6620 (bidi_paragraph_info): Delete unused struct.
6621 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6622 (bidi_cache_start): New variable.
6623 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6624 to zero.
6625 (bidi_cache_fetch_state, bidi_cache_search)
6626 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6627 (bidi_cache_find, bidi_peek_at_next_level)
6628 (bidi_level_of_next_char, bidi_find_other_level_edge)
6629 (bidi_move_to_visually_next): Compare cache index with
6630 bidi_cache_start rather than with zero.
6631 (bidi_fetch_char): Accept new argument STRING; all callers
6632 changed. Support iteration over a string. Support strings with
6633 display properties. Support unibyte strings. Fix the type of
6634 `len' according to what STRING_CHAR_AND_LENGTH expects.
6635 (bidi_paragraph_init, bidi_resolve_explicit_1)
6636 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6637 (bidi_level_of_next_char, bidi_move_to_visually_next):
6638 Support iteration over a string.
0bb23927
EZ
6639 (bidi_set_sor_type, bidi_resolve_explicit_1)
6640 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6641 can now be zero (for strings); special values 0 and -1 were
6642 changed to -1 and -2, respectively.
6643 (bidi_char_at_pos): New function.
6644 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6645 Call it instead of FETCH_MULTIBYTE_CHAR.
6646 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6647 initialized to valid values.
6648 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6649 values.
6650 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6651 the test for valid cached positions. Fix the logic for looking up
6652 the sentinel state in the cache. GCPRO the Lisp string we are
6653 iterating.
6654 (bidi_push_it, bidi_pop_it): New functions.
6655 (bidi_initialize): Initialize the bidi cache start stack pointer.
6656 (bidi_cache_ensure_space): New function, refactored from part of
6657 bidi_cache_iterator_state. Don't assume the required size is just
6658 one BIDI_CACHE_CHUNK away.
6659 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6660 (bidi_count_bytes, bidi_char_at_pos): New functions.
6661 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6662 always valid if bidi_cache_idx is valid.
6663 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6664 is valid if it's going to be used.
6665 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6666 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6667 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6668 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6669 (bidi_find_other_level_edge, bidi_cache_start_stack):
6670 All variables related to cache indices are now EMACS_INT.
c965adc5 6671
0bb23927
EZ
6672 * dispextern.h (struct bidi_string_data): New structure.
6673 (struct bidi_it): New member `string'. Make flag members be 1-bit
6674 fields, and put them last in the struct.
640c8776
SM
6675 (compute_display_string_pos, compute_display_string_end):
6676 Update prototypes.
0bb23927
EZ
6677 (bidi_push_it, bidi_pop_it): Add prototypes.
6678 (struct iterator_stack_entry): New members bidi_p,
6679 paragraph_embedding, and from_disp_prop_p.
6680 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6681 (bidi_shelve_cache, bidi_unshelve_cache):
6682 Declare prototypes.
0bb23927
EZ
6683
6684 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6685 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6686 and vector-like objects.
6687
6688 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6689 cache around display iteration.
6690
6691 * window.c (Fwindow_end, window_scroll_pixel_based)
6692 (displayed_window_lines, Frecenter): Save and restore the bidi
6693 cache around display iteration.
6694
3bbd2265
LMI
66952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6696
6697 * editfns.c (Fdelete_region): Clarify the use of the named
6698 parameters (bug#6788).
6699
adc47434
MR
67002011-07-14 Martin Rudalics <rudalics@gmx.at>
6701
6702 * indent.c (Fvertical_motion): Set and restore w->pointm when
6703 saving and restoring the window's buffer (Bug#9006).
6704
837c31f8
LMI
67052011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6706
6707 * editfns.c (Fstring_to_char): Clarify just what is returned
6708 (bug#6576). Text by Eli Zaretskii.
6709
ac389d0c
JB
67102011-07-13 Juanma Barranquero <lekktu@gmail.com>
6711
6712 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6713
0be0ce47
EZ
67142011-07-13 Eli Zaretskii <eliz@gnu.org>
6715
6716 * buffer.c (mmap_find): Fix a typo.
6717
cd18e7e3
JB
67182011-07-13 Johan Bockgård <bojohan@gnu.org>
6719
6720 Fix execution of x selection hooks.
6721 * xselect.c (Qx_lost_selection_functions)
6722 (Qx_sent_selection_functions): New vars.
6723 (syms_of_xselect): DEFSYM them.
6724 (x_handle_selection_request): Pass Qx_sent_selection_functions
6725 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6726 (x_handle_selection_clear,x_clear_frame_selections):
6727 Pass Qx_lost_selection_functions rather than
6728 Vx_lost_selection_functions to Frun_hook_with_args.
6729
47ea7f44
PE
67302011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6731
ac389d0c 6732 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6733 The old code sometimes used this field without initializing it.
6734
47ea7f44
PE
6735 * alloc.c (gc_sweep): Don't read past end of array.
6736 In theory, the old code could also have corrupted Emacs internals,
6737 though it'd be very unlikely.
6738
bc985c87
AS
67392011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6740
6741 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6742 argument. (Bug#4026)
bc985c87 6743
0cf34688
LMI
67442011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6745
b3dadd76
LMI
6746 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6747 key" (bug#4257).
6748
0cf34688
LMI
6749 * window.c (Fset_window_start): Doc fix (bug#4199).
6750 (Fset_window_hscroll): Ditto.
6751
270768cd
PE
67522011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6753
077e3dda 6754 Fix minor new problems caught by GCC 4.6.1.
270768cd 6755 * term.c (init_tty): Remove unused local.
490011a6 6756 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6757 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6758 not used otherwise.
270768cd 6759
b1f58454
CY
67602011-07-12 Chong Yidong <cyd@stupidchicken.com>
6761
6762 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6763
22b9578d
LMI
67642011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6765
6e70ab07
LMI
6766 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6767 are the mini-buffer and the echo area (bug#3320).
6768
22b9578d
LMI
6769 * term.c (init_tty): Remove support for supdup, c10 and perq
6770 terminals, which are no longer supported (bug#1482).
6771
8974cc9f
JB
67722011-07-10 Johan Bockgård <bojohan@gnu.org>
6773
6774 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6775
a560d974
JD
67762011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6777
6778 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6779 for non-popups (Bug#3642).
6780
1dae0f0a
AS
67812011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6782
268c2c36 6783 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6784 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6785 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6786 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6787 * data.c (fmod): Likewise.
6788 * dispnew.c (swap_glyphs_in_rows): Likewise.
6789 * emacs.c (memory_warning_signal): Likewise.
6790 * floatfns.c (float_error): Likewise.
6791 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6792 (otf_open, font_otf_capability, generate_otf_features)
6793 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6794 Likewise.
6795 * image.c (pbm_read_file): Likewise.
6796 * indent.c (string_display_width): Likewise.
6797 * intervals.c (check_for_interval, search_for_interval)
6798 (inc_interval_count, count_intervals, root_interval)
6799 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6800 * lread.c (defalias): Likewise.
268c2c36 6801 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6802 * regex.c (set_image_of_range_1, set_image_of_range)
6803 (regex_grow_registers): Likewise.
6804 * sysdep.c (strerror): Likewise.
6805 * termcap.c (valid_filename_p, tprint, main): Likewise.
6806 * tparam.c (main): Likewise.
6807 * unexhp9k800.c (run_time_remap, save_data_space)
6808 (update_file_ptrs, read_header, write_header, calculate_checksum)
6809 (copy_file, copy_rest, display_header): Likewise.
6810 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6811 Likewise.
6812 * xdisp.c (check_it): Likewise.
6813 * xfaces.c (register_color, unregister_color, unregister_colors):
6814 Likewise.
6815 * xfns.c (print_fontset_result): Likewise.
6816 * xrdb.c (member, fatal, main): Likewise.
6817
99033785
PE
68182011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6819
6820 Fix minor problems found by static checking (Bug#9031).
6821 * chartab.c (char_table_set_range, map_sub_char_table):
6822 Remove unused locals.
6823 (uniprop_table): Now static.
6824 * composite.c (_work_char): Remove unused static var.
6825
9cb2ac56
JB
68262011-07-09 Juanma Barranquero <lekktu@gmail.com>
6827
6828 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6829
f25661f0
JD
68302011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6831
6832 * gtkutil.c (qttip_cb): Remove code without function.
6833
8278c4fe
EZ
68342011-07-09 Eli Zaretskii <eliz@gnu.org>
6835
6836 * w32.c (pthread_sigmask): New stub.
6837
1692ae2d 68382011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6839
8a6ebd58 6840 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6841 sigprocmask is portable only for single-threaded applications, and
6842 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6843 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6844 (LIBES): Use it.
6845 * callproc.c (Fcall_process):
6846 * process.c (create_process):
6847 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6848 Use pthread_sigmask, not sigprocmask.
123403e4 6849
1b854618
JD
68502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6851
6852 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6853 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6854 wrong (Bug#8591).
6855
3fe4b549
JD
68562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6857
0ce7e563
JD
6858 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6859 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6860 (xg_hide_tooltip): Fix comment.
6861
3fe4b549
JD
6862 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6863 in registerServicesMenuSendTypes.
6864 (validRequestorForSendType): Don't check ns_return_types.
6865
6866 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6867 ns_return_type.
6868
5df75e47
JR
68692011-07-08 Jason Rumney <jasonr@gnu.org>
6870
22610910
JR
6871 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6872 SH_SHOW for hidden windows (Bug#5482).
6873
5df75e47
JR
6874 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6875 frame struct members of non-existent frames (Bug#6284).
6876
699c10bd
JD
68772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6878
4393663b
JD
6879 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6880 variable firstTime not needed on OSX >= 10.6.
6881 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6882 >= 10.5. Use setKnobProportion, setDoubleValue.
6883
6884 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6885 (MAC_OS_X_VERSION_10_5): Define if not defined.
6886 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6887 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6888 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6889
6890 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6891 cString and lossyCString on OSX >= 10.4
6892
58179cce 6893 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6894 sizeToFit on OSX >= 10.2.
6895
6896 * nsimage.m (allocInitFromFile): Don't use deprecated method
6897 bestRepresentationForDevice on OSX >= 10.6.
6898
6899 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6900 to avoid warning.
6901
6902 * emacs.c: Declare unexec_init_emacs_zone.
6903
a63e0781
JD
6904 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6905
699c10bd
JD
6906 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6907
6908 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6909 on svcsMenu (Bug#8842).
6910
6911 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6912 ns_return_types.
6913 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6914
6915 * nsterm.m (QUTF8_STRING): Declare.
6916 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6917 (validRequestorForSendType): Return type is (id).
6918 Change indexOfObjectIdenticalTo to indexOfObject.
6919 Check if we have local selection before returning self (Bug#8842).
6920 (writeSelectionToPasteboard): Put local selection into paste board
6921 if we have a local selection (Bug#8842).
6922 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6923
6924 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6925 (ns_get_local_selection): Declare.
6926
54e10184
LMI
69272011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6928
9888ff71
LMI
6929 * keymap.c (describe_map_tree): Don't insert a double newline at
6930 the end of the buffer (bug#1169) and return whether we inserted
6931 something.
6932
54e10184
LMI
6933 * callint.c (Fcall_interactively): Change "reading args" to
6934 "providing args" to try to clarify what it does (bug#1010).
6935
15fa4783
KH
69362011-07-07 Kenichi Handa <handa@m17n.org>
6937
6938 * composite.c (composition_compute_stop_pos): Ignore a static
6939 composition starting before CHARPOS (Bug#8915).
6940
6941 * xdisp.c (handle_composition_prop): Likewise.
6942
a8815b00
EZ
69432011-07-07 Eli Zaretskii <eliz@gnu.org>
6944
6945 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6946 (Bug#9015)
6947
ef7b981d 69482011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6949
6950 * character.h (unicode_category_t): New enum type.
6951
6952 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6953 (Qchar_code_property_table): New variable.
6954 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6955 (UNIPROP_COMPRESSED_FORM_P): New macros.
6956 (char_table_ascii): Uncompress the compressed values.
6957 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6958 Uncompress the compressed values.
ac389d0c 6959 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6960 (char_table_ref_and_range): Uncompress the compressed values.
6961 (sub_char_table_set): New arg is_uniprop. Callers changed.
6962 Uncompress the compressed values.
6963 (sub_char_table_set_range): Args changed. Callers changed.
6964 (char_table_set_range): Adjuted for the above change.
6965 (map_sub_char_table): Delete args default_val and parent. Add arg
6966 top. Give decoded values to a Lisp function.
640c8776 6967 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6968 values to a Lisp function. Gcpro more variables.
6969 (uniprop_table_uncompress)
6970 (uniprop_decode_value_run_length): New functions.
6971 (uniprop_decoder, uniprop_decoder_count): New variables.
6972 (uniprop_get_decoder, uniprop_encode_value_character)
6973 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6974 New functions.
6975 (uniprop_encoder, uniprop_encoder_count): New variables.
6976 (uniprop_get_encoder, uniprop_table)
6977 (Funicode_property_table_internal, Fget_unicode_property_internal)
6978 (Fput_unicode_property_internal): New functions.
6979 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6980 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6981 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6982 char-code-property-alist.
6983
640c8776 6984 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6985 Vunicode_category_table.
6986
640c8776 6987 * font.c (font_range): Adjust for the change of
c805dec0
KH
6988 Vunicode_category_table.
6989
76b397fb
DN
69902011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6991
6992 * m/iris4d.h: Remove file, move contents ...
6993 * s/irix6-5.h: ... here.
6994
22b4128e
PE
69952011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6996
6997 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6998 * alloc.c (mark_buffer):
6999 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7000 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7001 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7002 This isn't true in general, and it's particularly not true
7003 if Emacs is configured with --with-wide-int.
7004 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7005 New macros, used in the buffer.c change.
7006
869795d6
JD
70072011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7008
7009 * xsettings.c: Use both GConf and GSettings if both are available.
7010 (store_config_changed_event): Add comment.
7011 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7012 (store_tool_bar_style_changed): New functions.
5e617bc2 7013 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7014 (struct xsettings): Move font inside HAVE_XFT.
7015 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7016 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7017 Move inside HAVE_XFT.
640c8776 7018 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7019 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7020 also.
7021 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7022 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7023 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7024 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7025 (parse_settings): Move check for font inside HAVE_XFT.
7026 (read_settings, apply_xft_settings): Add comment.
7027 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7028 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7029 call store_font_name_changed.
7030 (xft_settings_event): Add comment.
7031 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7032 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7033 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7034 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7035 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7036 (xsettings_get_system_font, xsettings_get_system_normal_font):
7037 Add comment.
869795d6 7038
d8ed26bd
PE
70392011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7040
7041 Random fixes. E.g., (random) never returned negative values.
7042 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7043 subseconds part to the entropy, as that's a bit more random.
7044 Prefer signed to unsigned, since the signedness doesn't matter and
7045 in general we prefer signed. When given a limit, use a
7046 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7047 latter isn't right if USE_2_TAGS_FOR_INTS.
7048 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7049 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7050
cabf1cac
SM
70512011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7052
7053 * textprop.c (text_property_stickiness):
7054 Obey Vtext_property_default_nonsticky.
7055 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7056 * w32fns.c (syms_of_w32fns):
7057 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7058
6e9b2be9
PE
70592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7060
7061 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7062 This is more efficient than Ffile_directory_p and avoids a minor race.
7063
90186c68
LMI
70642011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7065
7c301272
LMI
7066 * buffer.c (Foverlay_put): Say what the return value is
7067 (bug#7835).
7068
c4f2d8d4
LMI
7069 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7070 is a directory before asking whether to use the file name
7071 (bug#7564).
ad637907
LMI
7072 (barf_or_query_if_file_exists): Make the "File is a directory"
7073 error be more correct.
c4f2d8d4 7074
90186c68
LMI
7075 * fns.c (Frequire): Remove the mention of the .gz files, since
7076 that's installation-specific, but keep the mention of
7077 `get-load-suffixes'.
7078
da64016e
PE
70792011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7080
7081 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7082 Report string overflow if the output is too long.
7083
7d47b580
JB
70842011-07-04 Juanma Barranquero <lekktu@gmail.com>
7085
a555cb87
JB
7086 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7087 (syms_of_gnutls): Remove duplicate DEFSYM for
7088 Qgnutls_bootprop_verify_hostname_error, an error for
7089 Qgnutls_bootprop_verify_error (which is no longer used).
7090
7d47b580
JB
7091 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7092 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7093 Also (re)move comments that are misplaced or no longer relevant.
7094
1e49bfab
LMI
70952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7096
7097 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7098
1485f4c0
CY
70992011-07-03 Chong Yidong <cyd@stupidchicken.com>
7100
7101 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7102 and background color parameters if they have been changed.
7103
a9ab721e
LMI
71042011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7105
7106 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7107
cf7cff57
PE
71082011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7109
2e13213d
PE
7110 * xsettings.c (SYSTEM_FONT): Define only when used.
7111 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7112
cf7cff57
PE
7113 * keymap.c (access_keymap_1): Now static.
7114
7a8e04f7
CY
71152011-07-02 Chong Yidong <cyd@stupidchicken.com>
7116
7117 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7118 leave any prefix arg for the up event (Bug#1586).
7119
61352f62
LMI
71202011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7121
69bb1ef7
LMI
7122 * lread.c (syms_of_lread): Mention single symbols defined by
7123 `defvar' or `defconst' (bug#7154).
7124
61352f62 7125 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7126 (Frequire): Mention get-load-suffixes.
61352f62 7127
28545e04
MR
71282011-07-02 Martin Rudalics <rudalics@gmx.at>
7129
7130 * window.h (window): Remove clone_number slot.
7131 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7132 Remove.
7133 (make_parent_window, make_window, saved_window)
7134 (Fset_window_configuration, save_window_save): Don't deal with
7135 clone numbers.
7136 * buffer.c (Qclone_number): Remove declaration.
7137 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7138
3349e122
SM
71392011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7140
7141 Add multiple inheritance to keymaps.
7142 * keymap.c (Fmake_composed_keymap): New function.
7143 (Fset_keymap_parent): Simplify.
7144 (fix_submap_inheritance): Remove.
7145 (access_keymap_1): New function extracted from access_keymap to handle
7146 embedded parents and handle lists of maps.
7147 (access_keymap): Use it.
7148 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7149 (Fcopy_keymap): Handle embedded parents.
7150 (Fcommand_remapping, define_as_prefix): Simplify.
7151 (Fkey_binding): Simplify.
7152 (syms_of_keymap): Move minibuffer-local-completion-map,
7153 minibuffer-local-filename-completion-map,
7154 minibuffer-local-must-match-map, and
7155 minibuffer-local-filename-must-match-map to Elisp.
7156 (syms_of_keymap): Defsubr make-composed-keymap.
7157 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7158 (parse_menu_item): Trivial simplification.
7159
3279eb87
GM
71602011-07-01 Glenn Morris <rgm@gnu.org>
7161
7162 * Makefile.in (SETTINGS_LIBS): Fix typo.
7163
4550efdf
KI
71642011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7165
7166 * coding.c (Fencode_coding_string): Record the last coding system
7167 used, as the function doc string says (bug#8738).
7168
0949d2b6
JD
71692011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7170
7171 * xsettings.c (store_monospaced_changed): Take new font as arg and
7172 check for change against current_mono_font.
7173 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7174 (emacs_settings_constructor, emacs_settings_get_property)
7175 (emacs_settings_set_property, emacs_settings_class_init)
7176 (emacs_settings_init, gsettings_obj): Remove.
7177 (something_changedCB): New function for HAVE_GSETTINGS.
7178 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7179 with value as argument.
7180 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7181 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7182 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7183 "changed".
7184
7185 * xgselect.c: Add defined (HAVE_GSETTINGS).
7186 (xgselect_initialize): Ditto.
7187
7188 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7189 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7190 xg_select.
7191
bbc6b304
PE
71922011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7193
7194 * eval.c (struct backtrace): Simplify and port the data structure.
7195 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7196 signed bit field, as this assumption is not portable and it makes
7197 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7198 "char debug_on_exit : 1" as this is not portable either; instead,
7199 use the portable "unsigned int debug_on_exit : 1". Remove unused
7200 member evalargs. Remove obsolete comments about cc bombing out.
7201
9851bfc5
JD
72022011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7203
51bb811f 7204 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7205 Let HAVE_GSETTINGS override HAVE_GCONF.
7206 (store_monospaced_changed): New function.
7207 (EMACS_SETTINGS): A new type derived from GObject to handle
7208 GSettings notifications.
7209 (emacs_settings_constructor, emacs_settings_get_property)
7210 (emacs_settings_set_property, emacs_settings_class_init):
7211 New functions.
7212 (gsettings_client, gsettings_obj): New variables.
7213 (GSETTINGS_SCHEMA): New define.
7214 (something_changedCB): Call store_monospaced_changed.
7215 (init_gsettings): New function.
7216 (xsettings_initialize): Call init_gsettings.
7217 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7218 to NULL.
7219
640c8776 7220 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7221 GCONF_CFLAGS/LIBS.
7222
5386012d
MR
72232011-06-29 Martin Rudalics <rudalics@gmx.at>
7224
7225 * window.c (resize_root_window, grow_mini_window)
7226 (shrink_mini_window): Rename Qresize_root_window to
7227 Qwindow_resize_root_window and Qresize_root_window_vertically to
7228 Qwindow_resize_root_window_vertically.
7229
f13e0b08
PE
72302011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7231
7232 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7233
94515237
JB
72342011-06-27 Juanma Barranquero <lekktu@gmail.com>
7235
7236 * makefile.w32-in: Redesign dependencies so they reflect more
7237 clearly which files are directly included by each source file,
7238 and not through other includes.
7239
e43b6e43
MR
72402011-06-27 Martin Rudalics <rudalics@gmx.at>
7241
7242 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7243 (sort_overlays, overlay_strings): When an overlay's clone number
7244 matches the window's clone number process the overlay even if
7245 the overlay's window property doesn't match the current window.
7246
d68443dc
MR
7247 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7248 (Fwindow_hchild): Rename to Fwindow_left_child.
7249 (Fwindow_next): Rename to Fwindow_next_sibling.
7250 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7251 (resize_window_check): Rename to window_resize_check.
7252 (resize_window_apply): Rename to window_resize_apply.
7253 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7254 (Fdelete_other_windows_internal, resize_frame_windows)
7255 (Fsplit_window_internal, Fdelete_window_internal)
7256 (grow_mini_window, shrink_mini_window)
7257 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7258
c7e73be5
JD
72592011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7260
7261 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7262 (emacs_fixed_set_min_size): Remove.
7263 (emacs_fixed_new): Take frame as argument.
7264
7265 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7266 (_EmacsFixedPrivate): Remove minwidth/height.
7267 Add struct frame *f.
7268 (emacs_fixed_init): Initialize priv->f.
7269 (get_parent_class, emacs_fixed_set_min_size): Remove.
7270 (emacs_fixed_new): Set priv->f to argument.
7271 (emacs_fixed_get_preferred_width)
7272 (emacs_fixed_get_preferred_height): Use min_width/height from
7273 frames size_hint to set minimum and natural (Bug#8919).
7274 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7275 and use min_width/height from frames size_hint to set
7276 min_width/height (Bug#8919).
7277
7278 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7279 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7280 Fix indentation.
c7e73be5 7281
cf99dcf8
EZ
72822011-06-26 Eli Zaretskii <eliz@gnu.org>
7283
7284 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7285 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7286 called at ZV.
7287
029529ac
CY
72882011-06-26 Chong Yidong <cyd@stupidchicken.com>
7289
7290 * process.c (wait_reading_process_output): Bypass select if
7291 waiting for a cell while ignoring keyboard input, and input is
7292 pending. Suggested by Jan Djärv (Bug#8869).
7293
7a7ef429
PE
72942011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7295
7296 Use gnulib's dup2 module instead of rolling our own.
7297 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7298
11fdef7d 72992011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7300
7301 * dispnew.c (scrolling_window): Before scrolling, turn off a
7302 mouse-highlight in the window being scrolled.
7303
cd3520a4
JB
73042011-06-24 Juanma Barranquero <lekktu@gmail.com>
7305
7306 Move DEFSYM to lisp.h and use everywhere.
7307
7308 * character.h (DEFSYM): Move declaration...
7309 * lisp.h (DEFSYM): ...here.
7310
7311 * gnutls.c:
7312 * minibuf.c:
7313 * w32menu.c:
7314 * w32proc.c:
7315 * w32select.c: Don't include character.h.
7316
7317 * alloc.c (syms_of_alloc):
7318 * buffer.c (syms_of_buffer):
7319 * bytecode.c (syms_of_bytecode):
7320 * callint.c (syms_of_callint):
7321 * casefiddle.c (syms_of_casefiddle):
7322 * casetab.c (init_casetab_once):
7323 * category.c (init_category_once, syms_of_category):
7324 * ccl.c (syms_of_ccl):
7325 * cmds.c (syms_of_cmds):
7326 * composite.c (syms_of_composite):
7327 * dbusbind.c (syms_of_dbusbind):
7328 * dired.c (syms_of_dired):
7329 * dispnew.c (syms_of_display):
7330 * doc.c (syms_of_doc):
7331 * editfns.c (syms_of_editfns):
7332 * emacs.c (syms_of_emacs):
7333 * eval.c (syms_of_eval):
7334 * fileio.c (syms_of_fileio):
7335 * fns.c (syms_of_fns):
7336 * frame.c (syms_of_frame):
7337 * fringe.c (syms_of_fringe):
7338 * insdel.c (syms_of_insdel):
7339 * keymap.c (syms_of_keymap):
7340 * lread.c (init_obarray, syms_of_lread):
7341 * macros.c (syms_of_macros):
7342 * msdos.c (syms_of_msdos):
7343 * print.c (syms_of_print):
7344 * process.c (syms_of_process):
7345 * search.c (syms_of_search):
7346 * sound.c (syms_of_sound):
7347 * syntax.c (init_syntax_once, syms_of_syntax):
7348 * terminal.c (syms_of_terminal):
7349 * textprop.c (syms_of_textprop):
7350 * undo.c (syms_of_undo):
7351 * w32.c (globals_of_w32):
7352 * window.c (syms_of_window):
7353 * xdisp.c (syms_of_xdisp):
7354 * xfaces.c (syms_of_xfaces):
7355 * xfns.c (syms_of_xfns):
7356 * xmenu.c (syms_of_xmenu):
7357 * xsettings.c (syms_of_xsettings):
7358 * xterm.c (syms_of_xterm): Use DEFSYM.
7359
4228cf16
TZ
73602011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7361
cd3520a4 7362 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7363
7fcccf1e
PE
73642011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7365
7efb4e0e
PE
7366 Integer and buffer overflow fixes (Bug#8873).
7367
ff5844ad
PE
7368 * print.c (printchar, strout): Check for string overflow.
7369 (PRINTPREPARE, printchar, strout):
7370 Don't set size unless allocation succeeds.
7371
90532f02
PE
7372 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7373 for sizes. Check for string overflow more accurately.
7374 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7375
6d84508d
PE
7376 * macros.c: Integer and buffer overflow fixes.
7377 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7378 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7379 Use ptrdiff_t, not int, for sizes.
7380 Don't increment bufsize until after realloc succeeds.
7381 Check for size-calculation overflow.
7382 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7383
437b2cb4
PE
7384 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7385
8b9ac8b4
PE
7386 * lread.c: Integer overflow fixes.
7387 (read_integer): Radix is now EMACS_INT, not int,
7388 to improve quality of diagnostics for out-of-range radices.
7389 Calculate buffer size correctly for out-of-range radices.
7390 (read1): Check for integer overflow in radices, and in
7391 read-circle numbers.
82cb60d3
PE
7392 (read_escape): Avoid int overflow.
7393 (Fload, openp, read_buffer_size, read1)
7394 (substitute_object_recurse, read_vector, read_list, map_obarray):
7395 Use ptrdiff_t, not int, for sizes.
7396 (read1): Use EMACS_INT, not int, for sizes.
20270765 7397 Check for size overflow.
8b9ac8b4 7398
7fcccf1e
PE
7399 * image.c (cache_image): Check for size arithmetic overflow.
7400
bfbbd7e7
PE
7401 * lread.c: Integer overflow issues.
7402 (saved_doc_string_size, saved_doc_string_length)
7403 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7404 Now ptrdiff_t, not int.
7405 (read1): Don't assume doc string length fits in int. Check for
7406 out-of-range doc string lengths.
7407 (read_list): Don't assume file position fits in int.
39019e54 7408 (read_escape): Check for hex character overflow.
bfbbd7e7 7409
4e323265
LL
74102011-06-22 Leo Liu <sdl.web@gmail.com>
7411
7412 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7413 Move to minibuffer.el.
7414
85fece3e
PE
74152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7416
20b84ce9 7417 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7418 The following patches are for when GLYPH_DEBUG && !XASSERT.
7419 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7420 * dispnew.c (flush_stdout):
7421 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7422 Mark as externally visible.
7423 * dispnew.c (check_window_matrix_pointers): Now static.
7424 * dispnew.c (window_to_frame_vpos):
7425 * xfns.c (unwind_create_frame):
7426 * xterm.c (x_check_font): Remove unused local.
7427 * scroll.c (CHECK_BOUNDS):
7428 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7429 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7430 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7431 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7432 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7433 Now static.
7434 (debug_method_add): Use va_list and vsprintf rather than relying
7435 on undefined behavior with wrong number of arguments.
7436 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7437 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7438 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7439 since we're not interested in debugging glyphs with old libraries.
7440 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7441 GCC 4.6.0's static checking.
7442
0766b489
PE
74432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7444
31fd4b32
PE
7445 Integer overflow and signedness fixes (Bug#8873).
7446 A few related buffer overrun fixes, too.
7447
b79e8648
PE
7448 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7449
0766b489
PE
7450 * dispextern.h (struct face.stipple):
7451 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7452 (x_bitmap_mask, x_allocate_bitmap_record)
7453 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7454 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7455 (x_create_bitmap_from_xpm_data):
7456 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7457 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7458 (.bitmaps_last):
7459 * xfaces.c (load_pixmap):
7460 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7461 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7462 (.bitmaps_last, struct x_output.icon_bitmap):
7463 Use ptrdiff_t, not int, for bitmap indexes.
7464 (x_allocate_bitmap_record): Check for size overflow.
7465 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7466
b081724f
PE
7467 Use ptrdiff_t, not int, for overlay counts.
7468 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7469 * editfns.c (overlays_around, get_pos_property):
7470 * textprop.c (get_char_property_and_overlay):
7471 * xdisp.c (next_overlay_change, note_mouse_highlight):
7472 * xfaces.c (face_at_buffer_position):
21514da7
PE
7473 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7474 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7475 (Fnext_overlay_change, Fprevious_overlay_change)
7476 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7477 Use ptrdiff_t, not int, for sizes.
21514da7 7478 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7479
3de73e5e
PE
7480 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7481
2606c57b
PE
7482 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7483 (x_session_initialize): Do not assume string length fits in int.
7484
aaafe47a
PE
7485 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7486 This is unlikely, but can occur if DPI is outlandish.
7487
2674ddc8 7488 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7489 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7490
28154962
PE
7491 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7492 * xrdb.c (magic_file_p, search_magic_path):
7493 Omit last arg SUFFIX; it was always 0. All callers changed.
7494 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7495
7de51af5
PE
7496 * xfont.c (xfont_match): Avoid need for strlen.
7497
25ed6cc3
PE
7498 * xfns.c: Don't assume strlen fits in int.
7499 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7500
4eab31dd
PE
7501 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7502 not unsigned long, as we prefer signed integers. All callers changed.
7503 Detect integer overflow in repeat count.
7504 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7505 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7506
171e2a58
PE
7507 * termcap.c: Don't assume sizes fit in int and never overflow.
7508 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7509 (gobble_line): Check for size-calculation overflow.
7510
ad39faca 7511 * minibuf.c (Fread_buffer):
6e5bb2dc 7512 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7513 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7514 Don't assume string length fits in int.
7515
52c61c22 7516 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7517 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7518
b5b8c9e5
PE
7519 * font.c: Don't assume string length fits in int.
7520 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7521 Use ptrdiff_t, not int.
ccd6111c
PE
7522 (font_intern_prop): Don't assume string length fits in int.
7523 Don't assume integer property fits in fixnum.
7524 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7525
882f0d81 7526 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7527 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7528 Reformulate so as not to need the command string.
7529 Invoke gzip -cd rather than gunzip, as it's more portable.
7530 (lock_info_type, lock_file_1, lock_file):
7531 Don't assume pid_t and time_t fit in unsigned long.
7532 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7533 (current_lock_owner): Prefer signed type for sizes.
7534 Use memcpy, not strncpy, where memcpy is what is really wanted.
7535 Don't assume (via atoi) that time_t and pid_t fit in int.
7536 Check for time_t and/or pid_t out of range, e.g., via a network share.
7537 Don't alloca where an auto var works fine.
7538
93f4cf88
PE
7539 * fileio.c: Fix some integer overflow issues.
7540 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7541 Don't assume string length fits in int.
7542 (directory_file_name): Don't assume string length fits in long.
7543 (make_temp_name): Don't assume pid fits in int, or that its print
7544 length is less than 20.
7545
f3e92b69
PE
7546 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7547
1bfdaf10
PE
7548 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7549
35016e9a
PE
7550 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7551
3d1e65a1
PE
7552 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7553 We prefer signed integers, even for size calculations.
7554
0b963a93
PE
7555 * emacs.c: Don't assume string length fits in 'int'.
7556 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7557 (main): Don't invoke strlen when not needed.
7558
573f4b54
PE
7559 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7560 (XD_DEBUG_MESSAGE): Don't waste a byte.
7561
989f33ba
PE
7562 * callproc.c (getenv_internal_1, getenv_internal)
7563 (Fgetenv_internal):
965d34eb
PE
7564 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7565
e4d29b33
PE
7566 * lread.c (invalid_syntax): Omit length argument.
7567 All uses changed. This doesn't fix a bug, but it simplifies the
7568 code away from its former Hollerith-constant appearance, and it's
7569 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7570 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7571
eb49b136
PE
7572 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7573 This didn't break anything, but it didn't help either.
7574 It's confusing to put a bogus integer in a place where the actual
7575 value does not matter.
9f62aeb1 7576 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7577 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7578
15375a22
PE
7579 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7580 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7581 implementation.
b61cc01c
PE
7582 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7583 We prefer signed types, and the value cannot exceed the EMACS_INT
7584 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7585 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7586 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7587 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7588
53b2623d
PE
7589 * indent.c (sane_tab_width): New function.
7590 (current_column, scan_for_column, Findent_to, position_indentation)
7591 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7592 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7593
51cab52b 7594 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7595
f2ed8a70
PE
7596 * lisp.h (lint_assume): New macro.
7597 * composite.c (composition_gstring_put_cache):
7598 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7599
abe80cc6
PE
7600 * editfns.c, insdel.c:
7601 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7602
b02c740e
PE
7603 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7604
ebc96716
PE
7605 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7606
b4e50fa0 7607 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7608 Use much-faster test for byte-length change.
311d5d7c 7609 Don't assume string byte-length fits in 'int'.
a4cf38e4 7610 Check that character arg fits in 'int'.
85461888 7611 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7612
c0c1ee9f
PE
7613 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7614
a498d7f4
PE
7615 * fns.c (concat): Catch string overflow earlier.
7616 Do not rely on integer wraparound.
7617
51cab52b
PE
7618 * dispextern.h (struct it.overlay_strings_charpos)
7619 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7620 * xdisp.c (forward_to_next_line_start)
7621 (back_to_previous_visible_line_start)
7622 (reseat_at_next_visible_line_start, next_element_from_buffer):
7623 Don't arbitrarily truncate the value of 'selective' to int.
7624
76031fad
PE
7625 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7626
5eb55db9
PE
7627 * composite.c: Don't truncate sizes to 'int'.
7628 (composition_gstring_p, composition_reseat_it)
7629 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7630 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7631 not EMACS_UINT, for indexes.
5eb55db9 7632
0703a717
PE
7633 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7634
d6202519
PE
7635 * buffer.c: Include <verify.h>.
7636 (struct sortvec.priority, struct sortstr.priority):
8961a454 7637 Now EMACS_INT, not int.
c20998a7 7638 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7639 (struct sortstr.size, record_overlay_string)
7640 (struct sortstrlist.size, struct sortlist.used):
7641 Don't truncate size to int.
7642 (record_overlay_string): Check for size-calculation overflow.
d6202519 7643 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7644
d5a19415
JM
76452011-06-22 Jim Meyering <meyering@redhat.com>
7646
029529ac 7647 Don't leak an XBM-image-sized buffer
d5a19415
JM
7648 * image.c (xbm_load): Free the image buffer after using it.
7649
a9041e6c
PE
76502011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7651
7652 Port to Sun C.
7653 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7654 that Sun C diagnosed.
7655 * fns.c (secure_hash): Fix pointer signedness issue.
7656 * intervals.c (static_offset_intervals): New function.
7657 (offset_intervals): Use it.
7658
7f3f739f
LL
76592011-06-21 Leo Liu <sdl.web@gmail.com>
7660
7661 * deps.mk (fns.o):
7662 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7663 sha512.h.
7664
7665 * fns.c (secure_hash): Rename from crypto_hash_function and change
7666 the first arg to accept symbols.
5b66d427 7667 (Fsecure_hash): New primitive.
7f3f739f
LL
7668 (syms_of_fns): New symbols.
7669
76147d94
DD
76702011-06-20 Deniz Dogan <deniz@dogan.se>
7671
7672 * process.c (Fset_process_buffer): Clarify return value in
7673 docstring.
7674
7d7d0045
CY
76752011-06-18 Chong Yidong <cyd@stupidchicken.com>
7676
7677 * dispnew.c (add_window_display_history): Use BVAR.
7678
7679 * xdisp.c (debug_method_add): Use BVAR.
7680 (check_window_end, dump_glyph_matrix, dump_glyph)
7681 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7682
7683 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7684 Likewise.
7685
7686 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7687 check till after the cache is created in init_frame_faces.
7688
ff2bc410
SM
76892011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7690
7691 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7692
28177add
PE
76932011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7694
dd3482fe
PE
7695 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7696 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7697 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7698
393d71f3 7699 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7700 * fileio.c (Finsert_file_contents):
7701 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7702 Remove the old (too-loose) buffer overflow checks.
7703 They weren't needed, since make_gap checks for buffer overflow.
7704 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7705 The old code merely checked for Emacs fixnum overflow, and relied
7706 on undefined (wraparound) behavior. The new code avoids undefined
7707 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7708
2e6813b0 7709 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7710 Tune. Don't use wider integers than needed. Don't use alloca.
7711 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7712
599a9e4f
PE
7713 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7714
99561444
PE
7715 * insdel.c, lisp.h (buffer_overflow): New function.
7716 (insert_from_buffer_1, replace_range, replace_range_2):
7717 * insdel.c (make_gap_larger):
7718 * editfns.c (Finsert_char):
7719 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7720
28177add
PE
7721 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7722
e69dafad
PE
77232011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7724
4baa020d 7725 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7726
b1c46f02
PE
7727 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7728 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7729
e69dafad
PE
7730 * fileio.c: Don't assume EMACS_INT fits in off_t.
7731 (emacs_lseek): New static function.
7732 (Finsert_file_contents, Fwrite_region): Use it.
7733 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7734
566684ea
PE
7735 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7736
e6966cd6
PE
7737 * fns.c: Don't overflow int when computing a list length.
7738 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7739 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7740 truncation on 64-bit hosts. Check for QUIT every
7741 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7742 faster and is responsive enough.
7743 (Flength): Report an error instead of overflowing an integer.
7744 (Fsafe_length): Return a float if the value is not representable
7745 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7746 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7747 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7748
dd0b0efb
PE
7749 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7750 (header_size, word_size): New constants.
7751 (allocate_vectorlike): Don't check size overflow here.
7752 (allocate_vector): Check it here instead, since this is the only
7753 caller of allocate_vectorlike that could cause overflow.
7754 Check that the new vector's length is representable as a fixnum.
7755
86fe5cfe
PE
7756 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7757 The previous code was bogus. For example, next_almost_prime (32)
7758 returned 39, which is undesirable as it is a multiple of 3; and
7759 next_almost_prime (24) returned 25, which is a multiple of 5 so
7760 why was the code bothering to check for multiples of 7?
7761
80e88859
PE
7762 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7763
4a2f0ad6
PE
7764 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7765
f66c7cf8
PE
7766 Variadic C functions now count arguments with ptrdiff_t.
7767 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7768 Back then I didn't know that the Emacs coding style prefers signed int.
7769 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7770 were being counted with int, which may truncate counts on 64-bit
7771 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7772 * lisp.h (struct Lisp_Subr.function.aMANY)
7773 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7774 Arg counts are now ptrdiff_t, not size_t.
7775 All variadic functions and their callers changed accordingly.
7776 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7777 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7778 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7779 * callint.c (Fcall_interactively): Check arg count for overflow,
7780 to avoid potential buffer overrun. Use signed char, not 'int',
7781 for 'varies' array, so that we needn't bother to check its size
7782 calculation for overflow.
7783 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7784 * eval.c (apply_lambda):
7785 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7786 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7787 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7788
a1759b76
PE
7789 * callint.c (Fcall_interactively): Don't use index var as event count.
7790
d96be9fc
PE
7791 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7792 * mem-limits.h (SIZE): Remove; no longer used.
7793
a690a978 7794 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7795
578c21e6
PE
7796 Remove unnecessary casts.
7797 * xterm.c (x_term_init):
7798 * xfns.c (x_set_border_pixel):
7799 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7800 These aren't needed now that we assume ANSI C.
7801
96f53c6c
PE
7802 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7803 It's more likely to cause problems (due to unsigned overflow)
7804 than to cure them.
7805
83c77d31
PE
7806 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7807
ee2079f1
PE
7808 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7809
6da65536
PE
7810 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7811
7147c4a4
PE
7812 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7813
193e32d9
PE
7814 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7815
e5533da6
PE
7816 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7817
9910e595
PE
7818 GLYPH_CODE_FACE returns EMACS_INT, not int.
7819 * dispextern.h (merge_faces):
7820 * xfaces.c (merge_faces):
01103c44
PE
7821 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7822 Don't assume EMACS_INT fits in int.
9910e595 7823
2638320e
PE
7824 * character.h (CHAR_VALID_P): Remove unused parameter.
7825 * fontset.c, lisp.h, xdisp.c: All uses changed.
7826
045eb8d9
PE
7827 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7828
c1f134b5
PE
7829 * fns.c (concat): Minor tuning based on overflow analysis.
7830 This doesn't fix any bugs. Use int to hold character, instead
7831 of constantly refetching from Emacs object. Use XFASTINT, not
7832 XINT, for value known to be a character. Don't bother comparing
7833 a single byte to 0400, as it's always less.
7834
395fcb93 7835 * floatfns.c (Fexpt):
327eeec8
PE
7836 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7837
abbd3d23
PE
7838 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7839 for characters.
7840
684a03ef
PE
7841 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7842
0fed43f3
PE
7843 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7844 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7845 incorrectly succeed when S was a string, because 4294967386 was
7846 truncated before it was used.
7847
8fd02eb7
PE
7848 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7849 Otherwise, an out-of-range integer could cause undefined behavior
7850 on a 64-bit host.
7851
f8c86b69
PE
7852 * composite.c: Use int, not EMACS_INT, for characters.
7853 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7854 EMACS_INT, for values that are known to be in character range.
7855 This doesn't fix any bugs but is the usual style inside Emacs and
7856 may generate better code on 32-bit machines.
7857
34206dd2
PE
7858 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7859 This is for reasons similar to the recent CHAR_STRING fix.
7860 * charset.c (Fencode_char): Check that character arg is actually
7861 a character. Pass an int to ENCODE_CHAR.
7862 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7863 wider than 'int', as a compile-time check to prevent future regressions
7864 in this area.
7865
c5958d4c 7866 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7867
7868 Make sure a 64-bit char is never passed to CHAR_STRING.
7869 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7870 by silently ignoring the top 32 bits, allowing some values
7871 that were far too large to be valid characters.
7872 * character.h: Include <verify.h>.
7873 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7874 arguments are no wider than unsigned, as a compile-time check
7875 to prevent future regressions in this area.
7876 * data.c (Faset):
01103c44 7877 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7878 (Fsubst_char_in_region):
7879 * fns.c (concat):
7880 * xdisp.c (decode_mode_spec_coding):
7881 Adjust to CHAR_STRING's new requirement.
7882 * editfns.c (Finsert_char, Fsubst_char_in_region):
7883 * fns.c (concat): Check that character args are actually
7884 characters. Without this test, these functions did the wrong
7885 thing with wildly out-of-range values on 64-bit hosts.
7886
d37ca623
PE
7887 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7888 These casts should not be needed on 32-bit hosts, either.
7889 * keyboard.c (read_char):
7890 * lread.c (Fload): Remove casts to unsigned.
7891
ea204efb
PE
7892 * lisp.h (UNSIGNED_CMP): New macro.
7893 This fixes comparison bugs on 64-bit hosts.
7894 (ASCII_CHAR_P): Use it.
7895 * casefiddle.c (casify_object):
01103c44 7896 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7897 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7898 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7899 * dispextern.h (FACE_FROM_ID):
7900 * keyboard.c (read_char): Use UNSIGNED_CMP.
7901
41cb286c
PE
7902 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7903 not to EMACS_INT, to avoid GCC warning.
7904
4a1b9832
PE
7905 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7906
55daad71
PE
7907 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7908 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7909 isn't needed on 32-bit machines.
8f95c75c 7910
01103c44
PE
7911 * buffer.c (Fgenerate_new_buffer_name):
7912 Use EMACS_INT for count, not int.
0ceccced 7913 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7914
7915 * data.c (Qcompiled_function): Now static.
7916
c6f072e7
PE
7917 * window.c (window_body_lines): Now static.
7918
20ce5912
PE
7919 * image.c (gif_load): Rename local to avoid shadowing.
7920
9c4c5f81
PE
7921 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7922 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7923 * alloc.c (make_save_value): Integer argument is now of type
7924 ptrdiff_t, not int.
7925 (mark_object): Use ptrdiff_t, not int.
7926 * lisp.h (pD): New macro.
7927 * print.c (print_object): Use it.
7928
c0c5c8ae
PE
7929 * alloc.c: Use EMACS_INT, not int, to count objects.
7930 (total_conses, total_markers, total_symbols, total_vector_size)
7931 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7932 (total_free_floats, total_floats, total_free_intervals)
7933 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7934 Now EMACS_INT, not int. All uses changed.
7935 (Fgarbage_collect): Compute overall total using a double, so that
7936 integer overflow is less likely to be a problem. Check for overflow
7937 when converting back to an integer.
5a25e253
PE
7938 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7939 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7940 These were 'int' variables that could overflow on 64-bit hosts;
7941 they were never used, so remove them instead of repairing them.
211a0b2a 7942 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7943 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7944 Previously, this ceilinged at INT_MAX, but that doesn't work on
7945 64-bit machines.
e46bb31a 7946 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7947
c78baabf 7948 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7949 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7950 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7951 when a (possibly-narrower) signed value would do just as well.
7952 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7953
c9d624c6
PE
7954 * alloc.c: Catch some string size overflows that we were missing.
7955 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7956 for convenience in STRING_BYTES_MAX.
7957 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7958 The definition here is exact; the one in lisp.h was approximate.
7959 (allocate_string_data): Check for string overflow. This catches
7960 some instances we weren't catching before. Also, it catches
7961 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7962 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7963 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7964
c9d624c6
PE
7965 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7966 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7967 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7968
353032ce
PE
7969 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7970
2bccce07
PE
7971 * alloc.c (Fmake_string): Check for out-of-range init.
7972
0ac30604
SM
79732011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7974
7975 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7976
c195f2de
JD
79772011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7978
7979 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7980 xg_get_default_scrollbar_width.
7981
7982 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7983 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7984 (style_changed_cb): Call update_theme_scrollbar_width and call
7985 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7986 all frames (Bug#8505).
7987 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7988 Call gtk_window_set_resizable if HAVE_GTK3.
7989 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7990 and height if HAVE_GTK3 (Bug#8505).
7991 (scroll_bar_width_for_theme): New variable.
7992 (update_theme_scrollbar_width): New function.
7993 (xg_get_default_scrollbar_width): Move code to
7994 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7995 (xg_initialize): Call update_theme_scrollbar_width.
7996
7997 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7998
7999 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8000
e10ac9f1
MR
80012011-06-12 Martin Rudalics <rudalics@gmx.at>
8002
8003 * frame.c (make_frame): Call other_buffer_safely instead of
8004 other_buffer.
8005
8006 * window.c (temp_output_buffer_show): Call display_buffer with
8007 second argument Vtemp_buffer_show_specifiers and reset latter
8008 immediately after the call.
8009 (Vtemp_buffer_show_specifiers): New variable.
8010 (auto_window_vscroll_p, next_screen_context_lines)
8011 (Vscroll_preserve_screen_position): Remove leading asterisks from
8012 doc-strings.
8013
2d3c217e 80142011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8015
7b7f97e8 8016 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8017 * buffer.c (Qclone_number): Remove for now, as it's unused.
8018 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8019 (record_buffer): Remove unused local.
8020 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8021 (set_frame_buffer_list): Remove; unused.
8022 * frame.h (other_visible_frames): Remove decl.
8023 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8024 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8025 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8026 if HAVE_GPM.
8027 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8028 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8029 Define only if HAVE_GPM.
8030 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8031 (update_hints_inhibit): Remove; never set. All uses removed.
8032 * widgetprv.h (emacsFrameClassRec): Remove decl.
8033 * window.c (delete_deletable_window): Now returns void, since it
8034 wasn't returning anything.
8035 (compare_window_configurations): Remove unused locals.
8036 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8037 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8038 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8039 the same widths as pointers. This follows up on the 2011-05-06 patch.
8040 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8041 * xterm.h: Likewise.
8042 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8043
1384b89e
JB
80442011-06-12 Juanma Barranquero <lekktu@gmail.com>
8045
8046 * makefile.w32-in: Update dependencies.
8047 (LISP_H): Add lib/intprops.h.
8048
1100a63c
CY
80492011-06-11 Chong Yidong <cyd@stupidchicken.com>
8050
8051 * image.c (gif_load): Add animation frame delay to the metadata.
8052 (syms_of_image): Use DEFSYM. New symbol `delay'.
8053
6198ccd0
MR
80542011-06-11 Martin Rudalics <rudalics@gmx.at>
8055
8056 * window.c (delete_deletable_window): Re-add.
8057 (Fset_window_configuration): Rewrite to handle dead buffers and
8058 consequently deletable windows.
8059 (window_tree, Fwindow_tree): Remove. Supply functionality in
8060 window.el.
8061 (compare_window_configurations): Simplify code.
8062
b6e3633c
AS
80632011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8064
1ab0dee5
AS
8065 * image.c (imagemagick_load_image): Fix type mismatch.
8066 (Fimagemagick_types): Likewise.
8067
b6e3633c
AS
8068 * window.h (replace_buffer_in_windows): Declare.
8069
9397e56f
MR
80702011-06-11 Martin Rudalics <rudalics@gmx.at>
8071
8072 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8073 Qclone_number. Remove external declaration of Qdelete_window.
8074 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8075 code.
640c8776
SM
8076 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8077 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8078 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8079 buffer list implementation.
8080 (other_buffer_safely): New function.
8081 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8082 calls to replace_buffer_in_windows and
8083 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8084 if allowed.
8085 (record_buffer): Inhibit quitting and rewrite using quittable
8086 functions. Run Qbuffer_list_update_hook if allowed.
8087 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8088 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8089 Move switch-to-buffer to window.el.
9397e56f
MR
8090 (bury-buffer): Move to window.el.
8091 (Vbuffer_list_update_hook): New variable.
8092
8093 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8094 section.
8095
8096 * window.h (resize_frame_windows): Move up in code.
8097 (Fwindow_frame): Remove EXFUN.
8098 (replace_buffer_in_all_windows): Remove prototype.
8099 (replace_buffer_in_windows_safely): Add prototype.
8100
8101 * window.c: Declare Qdelete_window static again. Move down
8102 declaration of select_count.
8103 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8104 (Fother_window): Move to window.el.
8105 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8106 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8107 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8108 window.el.
8109 (replace_buffer_in_windows): Implement by calling
8110 Qreplace_buffer_in_windows.
8111 (replace_buffer_in_all_windows): Remove with some functionality
8112 moved into replace_buffer_in_windows_safely.
8113 (replace_buffer_in_windows_safely): New function.
8114 (select_window_norecord, select_frame_norecord): Move in front
8115 of run_window_configuration_change_hook. Remove now obsolete
8116 declarations.
640c8776
SM
8117 (Fset_window_buffer): Rewrite doc-string.
8118 Call Qrecord_window_buffer.
9397e56f
MR
8119 (keys_of_window): Move binding for other-window to window.el.
8120
b50691aa
CY
81212011-06-11 Chong Yidong <cyd@stupidchicken.com>
8122
8123 * dispextern.h (struct image): Replace data member, whose int_val
8124 and ptr_val fields were not used by anything, with a single
8125 lisp_val object.
8126
8127 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8128 (gif_clear_image, gif_load, imagemagick_load_image)
8129 (gs_clear_image, gs_load): Callers changed.
8130
3f754b86
PE
81312011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8132
cca69397
PE
8133 * buffer.h: Include <time.h>, for time_t.
8134 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8135
109e28d0
PE
8136 Fix minor problems found by static checking.
8137
60737f02
PE
8138 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8139
4b66faf3
PE
8140 Make identifiers static if they are not used in other modules.
8141 * data.c (Qcompiled_function, Qframe, Qvector):
8142 * image.c (QimageMagick, Qsvg):
8143 * minibuf.c (Qmetadata):
8144 * window.c (resize_window_check, resize_root_window): Now static.
8145 * window.h (resize_window_check, resize_root_window): Remove decls.
8146
109e28d0
PE
8147 * window.c (window_deletion_count, delete_deletable_window):
8148 Remove; unused.
46a4ce9e
PE
8149 (window_body_lines): Now static.
8150 (Fdelete_other_windows_internal): Mark vars as initialized.
8151 Make sure 'resize_failed' is initialized.
8152 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8153 (resize_window_apply): Remove unused local.
8154 * window.h (delete_deletable_window): Remove decl.
8155
109e28d0 8156 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8157 (imagemagick_load_image): Fix pointer signedness problem by changing
8158 last arg from unsigned char * to char *. All uses changed.
8159 Also, fix a local for similar reasons.
8160 Remove unused locals. Remove locals to avoid shadowing.
8161 (fn_rsvg_handle_free): Remove; unused.
8162 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8163 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8164
3f754b86
PE
8165 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8166
2547adb1
CY
81672011-06-10 Chong Yidong <cyd@stupidchicken.com>
8168
8169 * image.c (gif_load): Fix omitted cast error introduced by
8170 2011-06-06 change.
8171
2c8e37d4
MR
81722011-06-10 Martin Rudalics <rudalics@gmx.at>
8173
8174 * window.h (resize_proportionally, orig_total_lines)
8175 (orig_top_line): Remove from window structure.
8176 (set_window_height, set_window_width, change_window_heights)
8177 (Fdelete_window): Remove prototypes.
8178 (resize_frame_windows): Remove duplicate declaration.
8179
440a42e3
EZ
81802011-06-10 Eli Zaretskii <eliz@gnu.org>
8181
8182 * window.h (resize_frame_windows, resize_window_check)
8183 (delete_deletable_window, resize_root_window)
8184 (resize_frame_windows): Declare prototypes.
8185
8186 * window.c (resize_window_apply): Make definition be "static" to
8187 match the prototype.
8188
562dd5e9
MR
81892011-06-10 Martin Rudalics <rudalics@gmx.at>
8190
8191 * window.c: Remove declarations of Qwindow_size_fixed,
8192 window_min_size_1, window_min_size_2, window_min_size,
8193 size_window, window_fixed_size_p, enlarge_window, delete_window.
8194 Remove static from declaration of Qdelete_window, it's
8195 temporarily needed by Fbury_buffer.
8196 (replace_window): Don't assign orig_top_line and
8197 orig_total_lines.
8198 (Fdelete_window, delete_window): Remove. Window deletion is
8199 handled by window.el.
640c8776
SM
8200 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8201 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8202 (Fdelete_other_windows): Remove. Deleting other windows is
8203 handled by window.el.
8204 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8205 handled in window.el.
8206 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8207 Window minimum sizes are handled in window.el.
8208 (shrink_windows, size_window, set_window_height)
8209 (set_window_width, change_window_heights, window_height)
8210 (window_width, CURBEG, CURSIZE, enlarge_window)
8211 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8212 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8213 handled in window.el.
8214 (make_dummy_parent): Rename to make_parent_window and give it a
8215 second argument horflag.
8216 (make_window): Don't set resize_proportionally any more.
8217 (Fsplit_window): Remove. Windows are split in window.el.
8218 (save_restore_action, save_restore_orig_size)
8219 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8220 Resize mini windows in window.el.
8221 (grow_mini_window, shrink_mini_window): Implement by calling
8222 Qresize_root_window_vertically, resize_window_check and
8223 resize_window_apply.
640c8776
SM
8224 (saved_window, Fset_window_configuration, save_window_save):
8225 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8226 resize_proportionally.
8227 (window_min_height, window_min_width): Move to window.el.
8228 (keys_of_window): Move bindings for delete-other-windows,
8229 split-window, delete-window and enlarge-window to window.el.
8230
8231 * buffer.c: Temporarily extern Qdelete_window.
8232 (Fbury_buffer): Temporarily call Qdelete_window instead of
8233 Fdelete_window (Fbury_buffer will move to window.el soon).
8234
8235 * frame.c (set_menu_bar_lines_1): Remove code handling
8236 orig_top_line and orig_total_lines.
8237
8238 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8239 set_window_height but set heights directly.
8240 (change_frame_size_1): Use resize_frame_windows.
8241
8242 * xdisp.c (init_xdisp): Don't use set_window_height but set
8243 heights directly.
8244
640c8776
SM
8245 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8246 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8247 run_window_configuration_change_hook.
8248
8249 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8250 instead of change_window_heights and run
8251 run_window_configuration_change_hook.
8252
1a13852e
MR
82532011-06-09 Martin Rudalics <rudalics@gmx.at>
8254
8255 * window.c (replace_window): Rename second argument REPLACEMENT to
8256 NEW. New third argument SETFLAG. Rewrite.
8257 (delete_window, make_dummy_parent): Call replace_window with
8258 third argument 1.
8259 (window_list_1): Move down in code.
8260 (run_window_configuration_change_hook): Move set_buffer part
8261 before select_frame_norecord part in order to unwind correctly.
8262 Rename count1 to count.
8263 (recombine_windows, delete_deletable_window, resize_root_window)
8264 (Fdelete_other_windows_internal)
8265 (Frun_window_configuration_change_hook, make_parent_window)
8266 (resize_window_check, resize_window_apply, Fresize_window_apply)
8267 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8268 (Fdelete_window_internal, Fresize_mini_window_internal):
8269 New functions.
1a13852e
MR
8270 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8271
f3d1777e
MR
82722011-06-08 Martin Rudalics <rudalics@gmx.at>
8273
496e208e
MR
8274 * window.h (window): Add some new members to window structure -
8275 normal_lines, normal_cols, new_total, new_normal, clone_number,
8276 splits, nest, prev_buffers, next_buffers.
8277 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8278 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8279
f3d1777e
MR
8280 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8281 Remove.
496e208e
MR
8282 (make_dummy_parent): Set new members of windows structure.
8283 (make_window): Move down in code. Handle new members of window
8284 structure.
8285 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8286 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8287 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8288 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8289 (Fset_window_next_buffers, Fset_window_clone_number):
8290 New functions.
496e208e
MR
8291 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8292 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8293 Doc-string fixes.
8294 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8295 Argument WINDOW can be now internal window too.
8296 (Fwindow_use_time): Move up in code.
8297 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8298 Rewrite doc-string.
8299 (Fset_window_configuration, saved_window)
8300 (Fcurrent_window_configuration, save_window_save): Handle new
8301 members of window structure.
b9e809c2
MR
8302 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8303 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8304 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8305 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8306 Qget_mru_window, Qresize_root_window,
8307 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8308 Qauto_buffer_name; staticpro them.
f3d1777e 8309
abde8f8c
MR
83102011-06-07 Martin Rudalics <rudalics@gmx.at>
8311
8312 * window.c (Fwindow_total_size, Fwindow_left_column)
8313 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8314 (Fwindow_list_1): New functions.
8315 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8316 (Fwindow_width, Fscroll_left, Fscroll_right):
8317 Use window_body_cols instead of window_box_text_cols.
8318 (delete_window, Fset_window_configuration):
8319 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8320 (delete_all_subwindows): Take a window as argument and not a
8321 structure. Rewrite.
190b47e6
MR
8322 (window_loop): Remove handling of GET_LRU_WINDOW and
8323 GET_LARGEST_WINDOW.
8324 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8325
8326 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8327 window_box_text_cols. delete_all_subwindows now takes a
8328 Lisp_Object as argument.
abde8f8c 8329
640c8776
SM
8330 * indent.c (compute_motion, Fcompute_motion):
8331 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8332
fa8a67e6
MR
8333 * frame.c (delete_frame): Call delete_all_subwindows with root
8334 window as argument.
8335
a54e3482
DC
83362011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8337
8338 * fns.c (Fputhash): Document return value.
8339
60002bf5
CY
83402011-06-06 Chong Yidong <cyd@stupidchicken.com>
8341
8342 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8343
0c671da6 83442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8345
b862a52a 8346 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8347
be44ca6c
PE
8348 Check for overflow when converting integer to cons and back.
8349 * charset.c (Fdefine_charset_internal, Fdecode_char):
8350 Use cons_to_unsigned to catch overflow.
8351 (Fencode_char): Use INTEGER_TO_CONS.
8352 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8353 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8354 * data.c (long_to_cons, cons_to_long): Remove.
8355 (cons_to_unsigned, cons_to_signed): New functions.
8356 These signal an error for invalid or out-of-range values.
8357 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8358 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8359 * font.c (Ffont_variation_glyphs):
8360 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8361 * lisp.h: Include <intprops.h>.
8362 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8363 (cons_to_signed, cons_to_unsigned): New decls.
8364 (long_to_cons, cons_to_long): Remove decls.
8365 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8366 (Fprimitive_undo): Use CONS_TO_INTEGER.
8367 * xfns.c (Fx_window_property): Likewise.
8368 * xselect.c: Include <limits.h>.
8369 (x_own_selection, selection_data_to_lisp_data):
8370 Use INTEGER_TO_CONS.
8371 (x_handle_selection_request, x_handle_selection_clear)
8372 (x_get_foreign_selection, Fx_disown_selection_internal)
8373 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8374 (lisp_data_to_selection_data): Use cons_to_unsigned.
8375 (x_fill_property_data): Use cons_to_signed.
8376 Report values out of range.
8377
d1f3d2af
PE
8378 Check for buffer and string overflow more precisely.
8379 * buffer.h (BUF_BYTES_MAX): New macro.
8380 * lisp.h (STRING_BYTES_MAX): New macro.
8381 * alloc.c (Fmake_string):
8382 * character.c (string_escape_byte8):
8383 * coding.c (coding_alloc_by_realloc):
8384 * doprnt.c (doprnt):
8385 * editfns.c (Fformat):
8386 * eval.c (verror):
8387 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8388 since they may not be the same number.
8389 * editfns.c (Finsert_char):
8390 * fileio.c (Finsert_file_contents):
8391 Likewise for BUF_BYTES_MAX.
8392
dd52fcea
PE
8393 * image.c: Use ptrdiff_t, not int, for sizes.
8394 (slurp_file): Switch from int to ptrdiff_t.
8395 All uses changed.
8396 (slurp_file): Check that file size fits in both size_t (for
8397 malloc) and ptrdiff_t (for sanity and safety).
8398
7f9bbdbb
PE
8399 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8400 if b->modtime has its maximal value.
8401
dfe18f82
PE
8402 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8403
84acfcf0
PE
8404 Don't assume time_t can fit into int.
8405 * buffer.h (struct buffer.modtime): Now time_t, not int.
8406 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8407 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8408
ccd9a01a
PE
8409 Minor fixes for signed vs unsigned integers.
8410 * character.h (MAYBE_UNIFY_CHAR):
8411 * charset.c (maybe_unify_char):
8412 * keyboard.c (read_char, reorder_modifiers):
8413 XINT -> XFASTINT, since the integer must be nonnegative.
8414 * ftfont.c (ftfont_spec_pattern):
8415 * keymap.c (access_keymap, silly_event_symbol_error):
8416 XUINT -> XFASTINT, since the integer must be nonnegative.
8417 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8418 since it makes no difference and we prefer signed.
8419 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8420 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8421 nonnegative.
8422
d6d100dd
SM
84232011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8424
8425 * window.h (Fwindow_frame): Declare.
8426
2b6148e4
PE
84272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8428
8429 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8430 (SPARE_MEMORY): Always define.
8431 (LARGE_REQUEST): Remove.
8432 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8433
f230ecc9
MR
84342011-06-06 Martin Rudalics <rudalics@gmx.at>
8435
727e958e
MR
8436 * lisp.h: Move EXFUNS for Fframe_root_window,
8437 Fframe_first_window and Fset_frame_selected_window to window.h.
8438
8439 * window.h: Move EXFUNS for Fframe_root_window,
8440 Fframe_first_window and Fset_frame_selected_window here from
8441 lisp.h.
8442
8443 * frame.c (Fwindow_frame, Fframe_first_window)
8444 (Fframe_root_window, Fframe_selected_window)
8445 (Fset_frame_selected_window): Move to window.c.
8446 (Factive_minibuffer_window): Move to minibuf.c.
8447 (Fother_visible_frames_p): New function.
8448
8449 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8450
f230ecc9
MR
8451 * window.c (decode_window, decode_any_window): Move up in code.
8452 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8453 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8454 (Fwindow_buffer): Move up and rewrite doc-string.
8455 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8456 (Fwindow_prev): New functions.
727e958e
MR
8457 (Fwindow_frame): Move here from frame.c. Accept any window as
8458 argument.
8459 (Fframe_root_window, Fframe_first_window)
8460 (Fframe_selected_window): Move here from frame.c. Accept frame
8461 or arbitrary window as argument. Update doc-strings.
8462 (Fminibuffer_window): Move up in code.
8463 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8464 (Fset_frame_selected_window): Move here from frame.c.
8465 Marginal rewrite.
727e958e
MR
8466 (Fselected_window, select_window, Fselect_window): Move up in
8467 code. Minor doc-string fixes.
f230ecc9 8468
4d09bcf6
PE
84692011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8470
8471 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8472 Do not assume that spare memory exists; that assumption is valid
8473 only if SYSTEM_MALLOC.
8474 (LARGE_REQUEST): New macro, so that the issue of large requests
8475 is separated from the issue of spare memory.
8476
810928a2
AS
84772011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8478
172418ad
AS
8479 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8480 format. (Bug#8806)
8481
43f862f7
AS
8482 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8483
810928a2
AS
8484 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8485 before statements.
8486
a059fe24
JD
84872011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8488
8489 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8490
8491 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8492
8493 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8494 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8495
989bf368
JB
84962011-06-05 Juanma Barranquero <lekktu@gmail.com>
8497
8498 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8499
4b80f674
CY
85002011-06-04 Chong Yidong <cyd@stupidchicken.com>
8501
8502 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8503 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8504 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8505 New error handlers.
4b80f674
CY
8506 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8507 Obey Vx_select_enable_clipboard_manager. Catch errors in
8508 x_clipboard_manager_save (Bug#8779).
8509 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8510 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8511
99a33b77 85122011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8513
8514 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8515
99a33b77 85162011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8517
8518 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8519 in the current matrix if keep_current_p is non-zero.
8520
8264569d
EZ
85212011-06-04 Eli Zaretskii <eliz@gnu.org>
8522
8523 * bidi.c (bidi_level_of_next_char): Fix last change.
8524
57f97249
EZ
85252011-06-03 Eli Zaretskii <eliz@gnu.org>
8526
fec2107c 8527 Support bidi reordering of text covered by display properties.
57f97249 8528
fec2107c
EZ
8529 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8530 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8531 (bidi_cache_search, bidi_cache_iterator_state)
8532 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8533 (bidi_level_of_next_char, bidi_move_to_visually_next):
8534 Support character positions inside a run of characters covered by a
fec2107c
EZ
8535 display string.
8536 (bidi_paragraph_init, bidi_resolve_explicit_1)
8537 (bidi_level_of_next_char): Call bidi_fetch_char and
8538 bidi_fetch_char_advance instead of FETCH_CHAR and
8539 FETCH_CHAR_ADVANCE.
8540 (bidi_init_it): Initialize new members.
8541 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8542 definitions.
8543 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8544 instead of using explicit *_CHAR codes.
d6d100dd
SM
8545 (bidi_resolve_explicit, bidi_resolve_weak):
8546 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8547 bidirectional text is supported only in multibyte buffers.
8548 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8549 it to initialize the frame_window_p member of struct bidi_it.
8550 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8551 (bidi_resolve_explicit, bidi_resolve_weak)
8552 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8553 bidi_it->nchars is non-positive.
8554 (bidi_level_of_next_char): Don't try to lookup the cache for the
8555 next/previous character if nothing is cached there yet, or if we
8556 were just reseat()'ed to a new position.
c40e2fb2 8557
0e14fe90
EZ
8558 * xdisp.c (set_cursor_from_row): Set start and stop points
8559 according to the row's direction when priming the loop that looks
8560 for the glyph on which to display cursor.
8561 (single_display_spec_intangible_p): Function deleted.
8562 (display_prop_intangible_p): Reimplement to call
8563 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8564 Accept 3 additional arguments needed by handle_display_spec.
8565 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8566 values: lists, `(when COND...)' forms, etc.
8567 (single_display_spec_string_p): Support property values that are
8568 lists with the argument STRING its top-level element.
8569 (display_prop_string_p): Fix the condition for processing a
8570 property that is a list to be consistent with handle_display_spec.
fec2107c 8571 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8572 last portion of handle_display_prop.
8573 (compute_display_string_pos): Accept additional argument
8574 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8575 value of a `display' property is a "replacing spec".
8576 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8577 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8578 the display property, but just return a value indicating whether
8579 the display property will replace the characters it covers.
8580 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8581 frame_window_p members of struct bidi_it.
d6d100dd
SM
8582 (compute_display_string_pos, compute_display_string_end):
8583 New functions.
fec2107c
EZ
8584 (push_it): Accept second argument POSITION, where pop_it should
8585 jump to continue iteration.
8586 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8587
fec2107c
EZ
8588 * keyboard.c (adjust_point_for_property): Adjust the call to
8589 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8590
8591 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8592 (bidi_init_it): Update prototypes.
8593 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8594 (compute_display_string_pos, compute_display_string_end):
8595 Declare prototypes.
fec2107c
EZ
8596 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8597 EMACS_INT.
fc6f18ce 8598
40087514 85992011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8600
57f53182
PE
8601 Malloc failure behavior now depends on size of allocation.
8602 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8603 * lisp.h: Change signatures accordingly.
8604 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8605 All callers changed. (Bug#8762)
8606
8607 * gnutls.c: Use Emacs's memory allocators.
8608 Without this change, the gnutls library would invoke malloc etc.
8609 directly, which causes problems on non-SYNC_INPUT hosts, and which
8610 runs afoul of improving memory_full behavior. (Bug#8761)
8611 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8612 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8613 xfree instead of the default malloc, realloc, free.
8614 (Fgnutls_boot): No need to check for memory allocation failure,
8615 since xmalloc does that for us.
8616
ac32cd99 8617 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8618 * category.c (hash_get_category_set):
8619 * ccl.c (ccl_driver):
8620 * charset.c (Fdefine_charset_internal):
8621 * charset.h (struct charset.hash_index):
8622 * composite.c (get_composition_id, gstring_lookup_cache)
8623 (composition_gstring_put_cache):
8624 * composite.h (struct composition.hash_index):
8625 * dispextern.h (struct image.hash):
8626 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8627 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8628 (hashfn_equal, hashfn_user_defined, make_hash_table)
8629 (maybe_resize_hash_table, hash_lookup, hash_put)
8630 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8631 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8632 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8633 * image.c (make_image, search_image_cache, lookup_image)
8634 (xpm_put_color_table_h):
8635 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8636 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8637 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8638 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8639 * alloc.c (allocate_vectorlike):
8640 Check for overflow in vector size calculations.
8641 * ccl.c (ccl_driver):
8642 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8643 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8644 need to be updated by these changes.
40087514
PE
8645 * fns.c (make_hash_table, maybe_resize_hash_table):
8646 Check for integer overflow with large hash tables.
0de4bb68
PE
8647 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8648 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8649 (SXHASH_REDUCE): New macro.
8650 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8651 Use it instead of discarding useful hash info with large hash values.
8652 (sxhash_float): New function.
8653 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8654 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8655 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8656 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8657 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8658 Adjust signatures to match updated version of code.
8659 (consing_since_gc): Now EMACS_INT, since a single hash table can
8660 use more than INT_MAX bytes.
8661
698d32e2
DN
86622011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8663
8664 Make it possible to build with GCC-4.6+ -O2 -flto.
8665
8666 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8667
fd6fa53f
SM
86682011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8669
8670 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8671 Call minibuffer-inactive-mode.
8672
864db017
JB
86732011-05-31 Juanma Barranquero <lekktu@gmail.com>
8674
8675 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8676 Update dependencies.
8677
2ad0baf4
DN
86782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8679
8680 * data.c (init_data): Remove code for UTS, this system is not
8681 supported anymore.
8682
4fcc2638
DN
86832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8684
8685 Don't force ./temacs to start in terminal mode.
8686
8687 * frame.c (make_initial_frame): Initialize faces in all cases, not
8688 only when CANNOT_DUMP is defined.
8689 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8690
c56e0fd5
DN
86912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8692
8693 * dispnew.c (add_window_display_history): Use const for the string
8694 pointer. Remove declaration, not needed.
8695
333d54da 86962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8697
55d4c1b2 8698 Use 'inline', not 'INLINE'.
333d54da 8699 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8700 * alloc.c, fontset.c (INLINE): Remove.
8701 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8702 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8703 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8704 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8705 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8706
738db178
DN
87072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8708
8709 Make it possible to run ./temacs.
8710
8711 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8712 syms_of_callproc does the same thing. Remove test for
8713 "initialized", do it in the caller.
8714 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8715
620c53a6
SM
87162011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8717
8718 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8719 (read_minibuf): Use get_minibuffer.
8720 (syms_of_minibuf): Use DEFSYM.
8721 (Qmetadata): New var.
8722 * data.c (Qbuffer): Don't make it static.
8723 (syms_of_data): Use DEFSYM.
8724
e003a292
PE
87252011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8726
8727 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8728 (CCL_CODE_MIN): New macro.
8729
ed008a6d
PE
87302011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8731
3687c2ef
PE
8732 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8733
ed008a6d
PE
8734 * eval.c (Qdebug): Now static.
8735 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8736 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8737 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8738
d66c4c7c
CY
87392011-05-29 Chong Yidong <cyd@stupidchicken.com>
8740
8741 * image.c: Various fixes to ImageMagick code comments.
8742 (Fimagemagick_types): Doc fix.
8743
5fbc2025
PE
87442011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8745
0196f88a
PE
8746 Minor fixes prompted by GCC 4.6.0 warnings.
8747
8748 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8749
5fbc2025
PE
8750 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8751 (x_clipboard_manager_save_all): Move extern decl to ...
8752 * xterm.h: ... here, so that it can be checked for consistency.
8753
1dd3c2d9
CY
87542011-05-29 Chong Yidong <cyd@stupidchicken.com>
8755
8756 * xselect.c (x_clipboard_manager_save_frame)
8757 (x_clipboard_manager_save_all): New functions.
8758 (Fx_clipboard_manager_save): Lisp function deleted.
8759
8760 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8761 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8762
8763 * xterm.h: Update prototype.
8764
5ba6571d
WX
87652011-05-28 William Xu <william.xwl@gmail.com>
8766
8767 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8768 exiting (Bug#8239).
8769
3eaff834
JM
87702011-05-28 Jim Meyering <meyering@redhat.com>
8771
e1900994 8772 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8773 * fns.c (to_uchar): Define.
8774 (crypto_hash_function): Use it to convert some newly-signed
8775 variables to unsigned, to avoid sign-extension bugs. For example,
8776 without this change, (md5 "truc") would evaluate to
8777 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8778 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8779 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8780
0f6990a7
PE
87812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8782
8783 Integer overflow fixes.
c8a9ca5a 8784
08686060
PE
8785 * dbusbind.c: Serial number integer overflow fixes.
8786 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8787 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8788 to hold a serial number that is too large for a fixnum.
8789 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8790 Check for serial numbers out of range. Decode any serial number
59568bf0 8791 that was so large that it became a float. (Bug#8722)
08686060 8792
2d1fc3c7
PE
8793 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8794 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8795 Use XFASTINT rather than XUINT when numbers are nonnegative.
8796 (xd_append_arg, Fdbus_method_return_internal):
8797 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8798 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8799 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8800 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8801 (Bug#8722)
2d1fc3c7 8802
c8a9ca5a
PE
8803 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8804
519e1d69
PE
8805 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8806
6df6ae42 8807 ccl: Add integer overflow checks.
30569699
PE
8808 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8809 (IN_INT_RANGE): New macros.
8810 (ccl_driver): Use them to check for integer overflow when
8811 decoding a CCL program. Many of the new checks are whether XINT (x)
8812 fits in int; it doesn't always, on 64-bit hosts. The new version
8813 doesn't catch all possible integer overflows, but it's an
847044ea 8814 improvement. (Bug#8719)
30569699 8815
c11285dc
PE
8816 * alloc.c (make_event_array): Use XINT, not XUINT.
8817 There's no need for unsigned here.
8818
fdccd48e
PE
8819 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8820 This follows up to the 2011-05-06 change that substituted uintptr_t
8821 for EMACS_INT. This case wasn't caught back then.
8822
37910ab2
PE
8823 Rework Fformat to avoid integer overflow issues.
8824 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8825 now (part of C89). Include <verify.h>.
8826 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8827 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8828 (Fformat): Avoid the prepass trying to compute sizes; it was only
8829 approximate and thus did not catch overflow reliably. Instead, walk
8830 through the format just once, formatting and computing sizes as we go,
8831 checking for integer overflow at every step, and allocating a larger
8832 buffer as needed. Keep track separately whether the format is
8833 multibyte. Keep only the most-recently calculated precision, rather
8834 than them all. Record whether each argument has been converted to
8835 string. Use EMACS_INT, not int, for byte and char and arg counts.
8836 Support field widths and precisions larger than INT_MAX. Avoid
8837 sprintf's undefined behavior with conversion specifications such as %#d
8838 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8839 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8840 formatting out-of-range floating point numbers with int
9173deec 8841 formats. (Bug#8668)
37910ab2 8842
2e6578fb
PE
8843 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8844
0ae6bdee
PE
8845 * data.c: Avoid integer truncation in expressions involving floats.
8846 * data.c: Include <intprops.h>.
8847 (arith_driver): When there's an integer overflow in an expression
8848 involving floating point, convert the integers to floating point
8849 so that the resulting value does not suffer from catastrophic
8850 integer truncation. For example, on a 64-bit host (* 4
8851 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8852 Do not rely on undefined behavior after integer overflow.
8853
de883a70
PE
8854 merge count_size_as_multibyte, parse_str_to_multibyte
8855 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8856 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8857 Check for integer overflow.
8858 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8859 since it's now a duplicate of the other. This is more of
8860 a character than a buffer op, so better that it's in character.c.
8861 * fns.c, print.c: Adjust to above changes.
8862
2ff916cb
PE
88632011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8864
8865 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8866
f1b54466
PE
88672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8868
fb1ac845
PE
8869 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8870 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8871 (x_clipboard_manager_save): Now static.
8872 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8873
f1b54466
PE
8874 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8875 (crypto_hash_function): Now static.
8876 Fix pointer signedness problems. Avoid unnecessary initializations.
8877
a9f737ee
CY
88782011-05-27 Chong Yidong <cyd@stupidchicken.com>
8879
8880 * termhooks.h (Vselection_alist): Make it terminal-local.
8881
8882 * terminal.c (create_terminal): Initialize it.
8883
8884 * xselect.c: Support for clipboard managers.
8885 (Vselection_alist): Move to termhooks.h as terminal-local var.
8886 (LOCAL_SELECTION): New macro.
8887 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8888 (symbol_to_x_atom): Remove gratuitous arg.
8889 (x_handle_selection_request, lisp_data_to_selection_data)
8890 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8891 (x_own_selection, x_get_local_selection, x_convert_selection):
8892 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8893 (some_frame_on_display): Delete unused function.
8894 (Fx_own_selection_internal, Fx_get_selection_internal)
8895 (Fx_disown_selection_internal, Fx_selection_owner_p)
8896 (Fx_selection_exists_p): New optional frame arg.
8897 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8898 (x_handle_selection_clear): Don't treat other terminals with the
8899 same keyboard specially. Use the terminal-local Vselection_alist.
8900 (x_clear_frame_selections): Use Frun_hook_with_args.
8901
8902 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8903
8904 * xterm.h: Add support for those atoms.
8905
e067f0c1
CY
89062011-05-26 Chong Yidong <cyd@stupidchicken.com>
8907
8908 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8909 (converted_selections, conversion_fail_tag): New global variables.
8910 (x_selection_request_lisp_error): Free the above.
8911 (x_get_local_selection): Remove unnecessary code.
8912 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8913 of converted selections stored in converted_selections.
8914 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8915 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8916 (x_convert_selection): New function.
8917 (x_handle_selection_event): Simplify.
8918 (x_get_foreign_selection): Don't ignore incoming requests while
8919 waiting for an answer; this will fail when we implement
8920 SAVE_TARGETS, and seems unnecessary anyway.
8921 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8922 (Vx_sent_selection_functions): Doc fix.
8923
0f4aebc0
LL
89242011-05-26 Leo Liu <sdl.web@gmail.com>
8925
8926 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8927
e61124cd
YM
89282011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8929
8930 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8931
8932 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8933 for fringe update if it has periodic bitmap.
ac389d0c 8934 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8935 and fringe_bitmap_periodic_p.
8936
8937 * fringe.c (get_fringe_bitmap_data): New function.
8938 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8939 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8940 row. Mark glyph row for fringe update if periodicity changed.
8941
8942 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8943 for fringe update unless it has periodic bitmap.
8944
f16d9837
KH
89452011-05-25 Kenichi Handa <handa@m17n.org>
8946
8947 * xdisp.c (get_next_display_element): Set correct it->face_id for
8948 a static composition.
8949
e1b90ef6
LL
89502011-05-24 Leo Liu <sdl.web@gmail.com>
8951
8952 * deps.mk (fns.o):
8953 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8954
8955 * fns.c (crypto_hash_function, Fsha1): New function.
8956 (Fmd5): Use crypto_hash_function.
8957 (syms_of_fns): Add Ssha1.
8958
7400048f
PE
89592011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8960
8961 * gnutls.c: Remove unused macros.
8962 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8963 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8964 Remove macros that are defined and never used.
8965 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8966
abb71cf4
CY
89672011-05-22 Chong Yidong <cyd@stupidchicken.com>
8968
8969 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8970 (Fx_get_selection_internal): Minor cleanup.
8971 (Fx_own_selection_internal): Rename arguments for consistency with
8972 select.el.
8973
6307db39
PE
89742011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8975
8976 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8977
f3d4e0a4
CY
89782011-05-22 Chong Yidong <cyd@stupidchicken.com>
8979
8980 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8981
4d8ade89
YM
89822011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8983
8984 * dispnew.c (scrolling_window): Don't exclude the case that the
8985 last enabled row in the desired matrix touches the bottom boundary.
8986
32078c8d
GM
89872011-05-21 Glenn Morris <rgm@gnu.org>
8988
8989 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8990 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8991 and add some more files.
32078c8d 8992
7285dc67
EZ
89932011-05-20 Eli Zaretskii <eliz@gnu.org>
8994
8995 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8996 report_file_error introduced by the change from 2011-05-07.
8997
89d1bd22
PE
89982011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8999
9000 * systime.h (Time): Define only if emacs is defined.
9001 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9002 where the include path doesn't have X11/X.h by default. See
9003 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9004
cd394be1 90052011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9006
9007 * composite.c (find_automatic_composition): Fix previous change.
9008
b9704ad9
GM
90092011-05-20 Glenn Morris <rgm@gnu.org>
9010
9011 * lisp.mk: New file, split from Makefile.in.
9012 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9013 (shortlisp): Remove.
9014 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9015
4a720484
GM
90162011-05-19 Glenn Morris <rgm@gnu.org>
9017
9018 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9019 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9020 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9021 (lisp): Set the order to that of loadup.el.
9022 (shortlisp): Make it a copy of $lisp.
9023 (SOME_MACHINE_LISP): Remove.
9024 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9025 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9026
a28d4396
KH
90272011-05-18 Kenichi Handa <handa@m17n.org>
9028
9029 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9030 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9031 (find_automatic_composition): Mostly rewrite for efficiency.
9032
a2b1fa8e
JB
90332011-05-18 Juanma Barranquero <lekktu@gmail.com>
9034
9035 * makefile.w32-in: Update dependencies.
9036
8e1f5610
CS
90372011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9038
9039 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9040 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9041
7025ee00 90422011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9043
cdfa6eab
PE
9044 Fix some integer overflow issues, such as string length overflow.
9045
06d6db33
PE
9046 * insdel.c (count_size_as_multibyte): Check for string overflow.
9047
2b4560a8
PE
9048 * character.c (lisp_string_width): Check for string overflow.
9049 Use EMACS_INT, not int, for string indexes and lengths; in
9050 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9051 the resulting string length overflows an EMACS_INT; instead,
9052 report a string overflow if no precision given. When checking for
9053 precision exhaustion, use a check that cannot possibly have
9054 integer overflow. (Bug#8675)
9055 * character.h (lisp_string_width): Adjust to new signature.
9056
cb93f9be
PE
9057 * alloc.c (string_overflow): New function.
9058 (Fmake_string): Use it. This doesn't change behavior, but saves
9059 a few bytes and will simplify future changes.
9060 * character.c (string_escape_byte8): Likewise.
9061 * lisp.h (string_overflow): New decl.
9062
1a1f3366
PE
9063 Fixups, following up to the user-interface timestamp change.
9064 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9065 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9066 * msdos.c (mouse_get_pos): Likewise.
9067 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9068 * w32gui.h (Time): Define by including "systime.h" rather than by
9069 declaring it ourselves. (Bug#8664)
9070
d4e3e4d3
PE
9071 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9072 * image.c (clear_image_cache): Likewise.
9073
f6a24d19
PE
9074 * term.c (term_mouse_position): Don't assume time_t wraparound.
9075
08dc5ae6
PE
9076 Be more systematic about user-interface timestamps.
9077 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9078 and sometimes 'EMACS_UINT', to represent these timestamps.
9079 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9080 This makes the code easier to follow, and makes it easier to catch
9081 integer overflow bugs such as Bug#8664.
9082 * frame.c (Fmouse_position, Fmouse_pixel_position):
9083 Use Time, not unsigned long, for user-interface timestamps.
9084 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9085 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9086 * keyboard.h (last_event_timestamp): Likewise.
9087 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9088 * menu.h (xmenu_show): Likewise.
9089 * term.c (term_mouse_position): Likewise.
9090 * termhooks.h (struct input_event.timestamp): Likewise.
9091 (struct terminal.mouse_position_hook): Likewise.
9092 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9093 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9094 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9095 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9096 what it was before.
9097 * menu.h, termhooks.h: Include "systime.h", for Time.
9098
8e55734a
PE
9099 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9100 Don't assume that the difference between two unsigned long values
9101 can fit into an integer. At this point, we know button_down_time
9102 <= event->timestamp, so the difference must be nonnegative, so
9103 there's no need to cast the result if double-click-time is
9104 nonnegative, as it should be; check that it's nonnegative, just in
9105 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9106 apart (about 25 days). (Bug#8664)
8e55734a 9107
841f1b75 9108 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9109 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9110
3e26f69c
PE
9111 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9112 that always fit in int. Use a sentinel instead of a counter, to
9113 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9114 * frame.h (struct frame): Use int for menu_bar_items_used
9115 instead of EMACS_INT, since it always fits in int.
3e26f69c 9116
5cc152c0
PE
9117 * menu.c (grow_menu_items): Check for int overflow.
9118
d89eb65e
PE
9119 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9120
5235bd3e
PE
9121 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9122 Before, the code was not consistent. These values cannot exceed
9123 2**31 - 1 so there's no need to make them unsigned.
9124 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9125 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9126 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9127 as modifiers.
9128 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9129
bc827e23
PE
9130 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9131 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9132 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9133 presumably because the widths might not match.
9134
78eb494e
PE
9135 * window.c (size_window): Avoid needless test at loop start.
9136
04f2d78b
CB
91372011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9138
9139 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9140
d2fc7e3d 91412011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9142
9143 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9144
d2fc7e3d 91452011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9146
9147 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9148 `width' to `bar_area_x' and `bar_area_width', respectively.
9149 (x_scroll_run): Take account of fringe background extension.
9150
04f2d78b
CB
9151 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9152 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9153 `bar_area_width', respectively.
9154 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9155 background extension.
9156
79b70037
GM
91572011-05-10 Jim Meyering <meyering@redhat.com>
9158
9159 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9160
2f142cc5
JB
91612011-05-10 Juanma Barranquero <lekktu@gmail.com>
9162
9163 * image.c (Finit_image_library): Return t for built-in image types,
9164 like pbm and xbm. (Bug#8640)
9165
57679c86
AS
91662011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9167
9168 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9169
888c9e86
EZ
91702011-05-07 Eli Zaretskii <eliz@gnu.org>
9171
b0512a1d
EZ
9172 * w32console.c (Fset_screen_color): Doc fix.
9173 (Fget_screen_color): New function.
9174 (syms_of_ntterm): Defsubr it.
9175
7285dc67
EZ
9176 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9177 unlink the temporary file if Fcall_process didn't create it in the
9178 first place.
9179 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9180 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9181 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9182 cue to call_process_cleanup not to close that handle.
9183
4d3fcc8e
BK
91842011-05-07 Ben Key <bkey76@gmail.com>
9185
9186 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9187 one of two shell specific rules, either bootstrap-temacs-CMD or
9188 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9189 to the previous implementation of the bootstrap-temacs rule.
9190 The bootstrap-temacs-CMD rule is similar to the previous
9191 implementation of the bootstrap-temacs rule except that it
9192 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9193 variable.
9194
9195 These changes, along with some changes to nt/configure.bat,
9196 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9197 earlier fix to add support for --cflags and --ldflags options
9198 that include quotes so that it works whether make uses cmd or
9199 sh as the shell.
9200
b4289b64
MA
92012011-05-06 Michael Albinus <michael.albinus@gmx.de>
9202
9203 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9204 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9205 is a constant.
9206 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9207 a string. Handle both cases.
9208 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9209 (Fdbus_register_method): Use Qinvalid_function.
9210
af4c0e28
JB
92112011-05-06 Juanma Barranquero <lekktu@gmail.com>
9212
9213 * makefile.w32-in: Update dependencies.
9214 (LISP_H): Add inttypes.h and stdin.h.
9215 (PROCESS_H): Add unistd.h.
9216
c51453d9
EZ
92172011-05-06 Eli Zaretskii <eliz@gnu.org>
9218
9219 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9220 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9221
8ff0ac3c 92222011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9223
4c4b566b
PE
9224 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9225
aab2b9b5
PE
9226 * term.c (vfatal): Remove stray call to va_end.
9227 It's not needed and the C Standard doesn't allow it here anyway.
9228
c378da0b
PE
9229 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9230 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9231
288b08c7
PE
9232 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9233 bytes.
9234
e3601888
PE
9235 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9236
db6c0e74
PE
9237 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9238
dd5963ea
PE
9239 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9240
88c9450f
PE
9241 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9242
2f9442b8
PE
9243 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9244
c032b5f8
PE
9245 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9246 * charset.c (Fdefine_charset_internal): Don't initialize
9247 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9248 32-bit int (Bug#8600).
a108c10b
PE
9249
9250 * lread.c (read_integer): Be more consistent with string-to-number.
9251 Use string_to_number to do the actual conversion; this avoids
9252 rounding errors and fixes some other screwups. Without this fix,
9253 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9254 (digit_to_number): Move earlier, for benefit of read_integer.
9255 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9256 not a digit in any supported base. (Bug#8602)
a108c10b 9257
ad5f9eea
PE
9258 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9259
aec1708a
PE
9260 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9261 to match comment at start of function. This also removes a
9262 GCC warning about overflow in a 32+64-bit port.
9263
47be4ab5
PE
9264 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9265
371cac43
PE
9266 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9267 Reported by Stefan Monnier in
9268 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9269 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9270 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9271
d01a7826
PE
9272 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9273 (EMACS_UINTPTR): Likewise, with uintptr_t.
9274
7fd47d5c
PE
9275 * lisp.h: Prefer 64-bit EMACS_INT if available.
9276 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9277 on 32-bit hosts that have 64-bit int, so that they can access
9278 large files.
122b0c86
PE
9279 However, temporarily disable this change unless the temporary
9280 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9281
8727937b
PE
9282 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9283
8ac068ac
PE
9284 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9285 This removes an assumption that EMACS_INT and long are the same
9286 width as pointers. The assumption is true for Emacs porting targets
9287 now, but we want to make other targets possible.
9288 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9289 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9290 In the rest of the code, change types of integers that hold casted
9291 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9292 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9293 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9294 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9295 No need to cast type when ORing.
9296 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9297 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9298 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9299 assume EMACS_INT is the same width as char *.
9300 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9301 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9302 Remove no-longer-needed casts.
9303 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9304 (xg_tool_bar_help_callback, xg_make_tool_item):
9305 Use EMACS_INTPTR to hold an integer
9306 that will be cast to void *; this can avoid a GCC warning
9307 if EMACS_INT is not the same width as void *.
9308 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9309 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9310 (current_message_1, set_message_1):
9311 Use a local to convert to proper width without a cast.
9312 * xmenu.c (dialog_selection_callback): Likewise.
9313
ede49d71
PE
9314 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9315 Also, don't assume VALBITS / RAND_BITS is less than 5,
9316 and don't rely on undefined behavior when shifting a 1 left into
9317 the sign bit.
9318 * lisp.h (get_random): Change signature to match.
9319
2f30ecd0
PE
9320 * lread.c (hash_string): Use size_t, not int, for hash computation.
9321 Normally we prefer signed values; but hashing is special, because
9322 it's better to use unsigned division on hash table sizes so that
9323 the remainder is nonnegative. Also, size_t is the natural width
9324 for hashing into memory. The previous code used 'int', which doesn't
9325 retain enough info to hash well into very large tables.
9326 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9327
2a866e7b
PE
9328 * dbusbind.c: Don't possibly lose pointer info when converting.
9329 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9330 Use XPNTR rather than XHASH, so that the high-order bits of
9331 the pointer aren't lost when converting through void *.
9332
51639eac
PE
9333 * eval.c (Fautoload): Don't double-shift a pointer.
9334
92394119
PE
9335 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9336
dbdb9a7c
JB
93372011-05-06 Juanma Barranquero <lekktu@gmail.com>
9338
9339 * gnutls.c (DEF_GNUTLS_FN):
9340 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9341
db7a0b4f
AS
93422011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9343
9344 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9345 marker. (Bug#8610)
9346
cd394be1 93472011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9348
9349 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9350 New version that can reserve upto 2GB of heap space.
9351
f7ff1b0f 93522011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9353
9354 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9355
639c109b
TZ
93562011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9357
9358 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9359 `gnutls_certificate_set_x509_key_file'.
9360
d2127135
JB
93612011-05-05 Juanma Barranquero <lekktu@gmail.com>
9362
9363 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9364 Update dependencies.
9365
e968f4f3
JB
93662011-05-04 Juanma Barranquero <lekktu@gmail.com>
9367
9368 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9369 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9370 Remove unused parameter `fildes'.
9371 * process.c (read_process_output, send_process): Don't pass it.
9372
84d358f0
JB
93732011-05-04 Juanma Barranquero <lekktu@gmail.com>
9374
9375 Fix previous change: the library cache is defined in w32.c.
9376 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9377 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9378
0898ca10
JB
93792011-05-04 Juanma Barranquero <lekktu@gmail.com>
9380
9381 Implement dynamic loading of GnuTLS on Windows.
9382
9383 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9384 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9385 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9386 Declare.
9387
9388 * gnutls.c (Qgnutls_dll): Define.
9389 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9390 (gnutls_*): Declare function pointers.
9391 (init_gnutls_functions): New function to initialize function pointers.
9392 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9393 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9394 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9395 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9396 (emacs_gnutls_write, emacs_gnutls_read)
9397 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9398 (Fgnutls_available_p): New function.
9399 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9400 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9401 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9402
9403 * image.c: Include w32.h.
9404 (Vimage_type_cache): Delete.
9405 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9406 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9407 (w32_delayed_load): Move to w32.c.
9408
9409 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9410
9411 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9412 (w32_delayed_load): Move from image.c. When loading a library, record
9413 its filename in the :loaded-from property of the library id.
9414 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9415 Initialize and staticpro them.
9416 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9417
9418 * process.c: Include lisp.h before w32.h, not after.
9419 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9420 instead of gnutls_record_check_pending.
9421
9422 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9423
ff4de4aa
TZ
94242011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9425
9426 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9427 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9428 as passed in.
9429
abe95abb
JD
94302011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9431
9432 * xterm.c (x_set_frame_alpha): Do not set property on anything
9433 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9434
e16e55d4
JB
94352011-05-02 Juanma Barranquero <lekktu@gmail.com>
9436
9437 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9438
bafcf6a5
JB
94392011-05-02 Juanma Barranquero <lekktu@gmail.com>
9440
9441 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9442 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9443 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9444 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9445 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9446 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9447 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9448 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9449 (Qgnutls_bootprop_callbacks_verify): Make static.
9450
e7a6747f
AS
94512011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9452
19ed11ba
AS
9453 * callproc.c: Indentation fixup.
9454
e7a6747f 9455 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9456 (wait_for_termination, interruptible_wait_for_termination):
9457 Move after wait_for_termination_1.
e7a6747f 9458
1ef14cb4
LMI
94592011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9460
9461 * sysdep.c (interruptible_wait_for_termination): New function
9462 which is like wait_for_termination, but allows keyboard
9463 interruptions.
9464
9465 * callproc.c (Fcall_process): Add (:file "file") as an option for
9466 the STDOUT buffer.
9467 (Fcall_process_region): Ditto.
9468
330d880c
EZ
94692011-04-30 Eli Zaretskii <eliz@gnu.org>
9470
8db90b73
EZ
9471 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9472 rather than `XVECTOR (FOO)->size'.
9473
330d880c
EZ
9474 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9475 inttypes.h, as a gnulib replacement is used if it not available in
9476 system headers.
9477
15cbd324
EZ
94782011-04-21 Eli Zaretskii <eliz@gnu.org>
9479
9480 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9481 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9482 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9483
9484 * coding.c (coding_alloc_by_realloc): Error out if destination
9485 will grow beyond MOST_POSITIVE_FIXNUM.
9486 (decode_coding_emacs_mule): Abort if there isn't enough place in
9487 charbuf for the composition carryover bytes. Reserve an extra
9488 space for up to 2 characters produced in a loop.
9489 (decode_coding_iso_2022): Abort if there isn't enough place in
9490 charbuf for the composition carryover bytes.
9491
94922011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9493
ae940cca
EZ
9494 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9495 aborting when %lld or %lll format is passed.
9496 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9497 %llo or %llx format is passed. (Bug#8545)
9498
03ab8921
EZ
9499 * window.c (window_scroll_line_based): Use a marker instead of
9500 simple variables to record original value of point. (Bug#7952)
9501
afda1437
EZ
9502 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9503 produced by %s or %c overflows available buffer space. (Bug#8545)
9504
f76dee0c
PE
95052011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9506
9507 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9508 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9509
fdc5744d
JB
95102011-04-28 Juanma Barranquero <lekktu@gmail.com>
9511
9512 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9513
638f053a
JB
95142011-04-28 Juanma Barranquero <lekktu@gmail.com>
9515
9516 * keyboard.c (Qdelayed_warnings_hook): Define.
9517 (command_loop_1): Run `delayed-warnings-hook'
9518 if Vdelayed_warnings_list is non-nil.
9519 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9520 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9521
d178f871
EZ
95222011-04-28 Eli Zaretskii <eliz@gnu.org>
9523
9524 * doprnt.c (doprnt): Don't return value smaller than the buffer
9525 size if the message was truncated. (Bug#8545).
9526
b124fd93
JB
95272011-04-28 Juanma Barranquero <lekktu@gmail.com>
9528
9529 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9530 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9531
e810457d
PE
95322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9533
9534 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9535
ea51cceb
JB
95362011-04-27 Juanma Barranquero <lekktu@gmail.com>
9537
9538 * makefile.w32-in: Update dependencies.
9539
94dcfacf
EZ
95402011-04-27 Eli Zaretskii <eliz@gnu.org>
9541
9542 Improve `doprnt' and its usage. (Bug#8545)
9543 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9544 `format_end'. Remove support for %l as a conversion specifier.
9545 Don't use xrealloc. Improve diagnostics when the %l size modifier
9546 is used. Update the commentary.
9547
9548 * eval.c (verror): Simplify calculation of size_t.
9549
9550 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9551 messages.
9552
f61f41d7
PE
95532011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9554
9555 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9556 change.
9557
96fb4434
PE
95582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9559
9560 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9561 This makes this file independent of the recent pseudovector change.
9562
671875da 95632011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9564
69e9b5a3
PE
9565 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9566
b5f869a7 9567 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9568 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9569 Remove unused local.
c8926152 9570 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9571
841a1577 9572 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9573 GCC 4.6.0 optimizes based on type-based alias analysis.
9574 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9575 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9576 != &v->size, and therefore "v->size = 1; b->size = 2; return
9577 v->size;" must therefore return 1. This assumption is incorrect
9578 for Emacs, since it type-puns struct Lisp_Vector * with many other
9579 types. To fix this problem, this patch adds a new type struct
f904488f 9580 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9581 and pseudovectors, and helps optimizing compilers not get fooled
9582 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9583 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9584 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9585 the size member.
eab3844f
PE
9586 (XSETPVECTYPE): Rewrite in terms of new macro.
9587 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9588 This is a bit clearer, and further avoids the possibility of
9589 undesirable aliasing.
9590 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9591 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9592 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9593 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9594 (ASIZE): Now uses header.size rather than size.
9595 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9596 to avoid the hassle of writing XVECTOR (foo)->header.size.
9597 (struct vectorlike_header): New type.
eab3844f
PE
9598 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9599 object, to help avoid aliasing.
9600 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9601 (SUBRP): Likewise, since Lisp_Subr is a special case.
9602 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9603 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9604 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9605 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9606 changed to be "header.size" and "header.next".
9607 * buffer.h (struct buffer): Likewise.
9608 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9609 * frame.h (struct frame): Likewise.
9610 * process.h (struct Lisp_Process): Likewise.
9611 * termhooks.h (struct terminal): Likewise.
9612 * window.c (struct save_window_data, struct saved_window): Likewise.
9613 * window.h (struct window): Likewise.
9614 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9615 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9616 * buffer.c (init_buffer_once): Likewise.
9617 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9618 special case.
9619 * process.c (Fformat_network_address): Use local var for size,
9620 for brevity.
9621
0df1eac5
PE
9622 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9623
847ab9d1 9624 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9625 * data.c (atof): Remove decl; no longer used or needed.
9626 (digit_to_number): Move to lread.c.
9627 (Fstring_to_number): Use new string_to_number function, to be
9628 consistent with how the Lisp reader treats infinities and NaNs.
9629 Do not assume that floating-point numbers represent EMACS_INT
9630 without losing information; this is not true on most 64-bit hosts.
9631 Avoid double-rounding errors, by insisting on integers when
9632 parsing non-base-10 numbers, as the documentation specifies.
9633 * lisp.h (string_to_number): New decl, replacing ...
9634 (isfloat_string): Remove.
bc0a5c13 9635 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9636 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9637 appears to have been a coding error. Similarly, do not accept
9638 strings like +-1e0 as floating point numbers. Do not report
9639 overflow for integer overflows unless the base is not 10 which
9640 means we have no simple and reliable way to continue.
9641 Break out the floating-point parsing into a new
9642 function string_to_number, so that Fstring_to_number parses
9643 floating point numbers consistently with the Lisp reader.
04f2d78b 9644 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9645 (E_CHAR, EXP_INT): Remove, replacing with ...
9646 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9647 (string_to_number): New function, replacing isfloat_string.
9648 This function checks for valid syntax and produces the resulting
9649 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9650 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9651 so that overflow for non-base-10 numbers is reported only when
9652 there's no portable and simple way to convert to floating point.
452f4150 9653
67769ffc
PE
9654 * textprop.c (set_text_properties_1): Rewrite for clarity,
9655 and to avoid GCC warning about integer overflow.
9656
c20db43f
PE
9657 * intervals.h (struct interval): Use EMACS_INT for members
9658 where EMACS_UINT might cause problems. See
9659 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9660 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9661 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9662 All uses changed.
37aa2f85
PE
9663 (offset_intervals): Tell GCC not to worry about length overflow
9664 when negating a negative length.
c20db43f 9665
2538aa2f
PE
9666 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9667 (overrun_check_free): Likewise.
9668
f2d3008d
PE
9669 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9670 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9671 word size.
9672
ec8df744
PE
9673 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9674 (gnutls_make_error): Rename local to avoid shadowing.
9675 (gnutls_emacs_global_deinit): ifdef out; not used.
9676 (Fgnutls_boot): Use const for pointer to readonly storage.
9677 Comment out unused local. Fix pointer signedness problems.
9678
640ee02d
PE
9679 * lread.c (openp): Don't stuff size_t into an 'int'.
9680 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9681 about possible signed overflow.
9682
6048fb2a
PE
9683 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9684 (GDK_KEY_g): Don't define if already defined.
9685 (xg_prepare_tooltip): Avoid pointer signedness problem.
9686 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9687
fa3c87e1
PE
9688 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9689 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9690
2172544b
PE
9691 * xfns.c (Fx_window_property): Simplify a bit,
9692 to make a bit faster and to avoid GCC 4.6.0 warning.
9693 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9694
9b821a21
PE
9695 * fns.c (internal_equal): Don't assume size_t fits in int.
9696
3c616cfa
PE
9697 * alloc.c (compact_small_strings): Tighten assertion a little.
9698
c2982e87
PE
9699 Replace pEd with more-general pI, and fix some printf arg casts.
9700 * lisp.h (pI): New macro, generalizing old pEd macro to other
9701 conversion specifiers. For example, use "...%"pI"d..." rather
9702 than "...%"pEd"...".
9703 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9704 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9705 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9706 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9707 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9708 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9709 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9710 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9711 64-bit hosts.
9712 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9713 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9714 * print.c (safe_debug_print, print_object): Likewise.
9715 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9716 to int.
6f04d126
PE
9717 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9718 avoiding the 0 flag, which is not portable.
c2982e87
PE
9719 * process.c (Fmake_network_process): Use pI to avoid cast.
9720 * region-cache.c (pp_cache): Likewise.
9721 * xdisp.c (decode_mode_spec): Likewise.
9722 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9723 behavior on 64-bit hosts with printf arg.
6f04d126 9724 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9725 (x_stop_queuing_selection_requests): Likewise.
9726 (x_get_window_property): Don't truncate byte count to an 'int'
9727 when tracing.
0b432f21 9728
5e073ec7
PE
9729 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9730 here, since it parses constructs like leading '-' and spaces,
9731 which are not wanted; and it overflows with large numbers.
9732 Instead, simply match F[0-9]+, which is what is wanted anyway.
9733
36372bf9
PE
9734 * alloc.c: Remove unportable assumptions about struct layout.
9735 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9736 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9737 (allocate_vectorlike, make_pure_vector): Use the new macros,
9738 plus offsetof, to remove unportable assumptions about struct layout.
9739 These assumptions hold on all porting targets that I know of, but
9740 they are not guaranteed, they're easy to remove, and removing them
9741 makes further changes easier.
9742
0b432f21
PE
9743 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9744 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9745 (string_overrun_cookie): Now const. Use initializers that
9746 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9747 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9748 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9749 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9750 multiple of sizeof (EMACS_INT); it need not be, if
9751 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9752 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9753
895009e1
JB
97542011-04-26 Juanma Barranquero <lekktu@gmail.com>
9755
9756 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9757
6a7a1b0b
TZ
97582011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9759
9760 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9761 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9762 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9763
841a1577 97642011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9765
9766 * lisp.h (Qdebug): List symbol.
895009e1 9767 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9768 * keyboard.c (debug-on-event): New variable.
9769 (handle_user_signal): Break into debugger when debug-on-event
9770 matches the current signal symbol.
9771
f2d3ba6f
DN
97722011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9773
9774 * alloc.c (check_sblock, check_string_bytes)
9775 (check_string_free_list): Convert to standard C.
9776
42ce4c63
TZ
97772011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9778
9779 * w32.c (emacs_gnutls_push): Fix typo.
9780
825cd63c
EZ
97812011-04-25 Eli Zaretskii <eliz@gnu.org>
9782
fb11d64d
EZ
9783 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9784 "cast to pointer from integer of different size".
9785
825cd63c
EZ
9786 Improve doprnt and its use in verror. (Bug#8545)
9787 * doprnt.c (doprnt): Document the set of format control sequences
9788 supported by the function. Use SAFE_ALLOCA instead of always
9789 using `alloca'.
9790
9791 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9792 is one byte too soon. Don't use xrealloc; instead xfree and
9793 xmalloc anew.
9794
e061a11b
TZ
97952011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9796
9797 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9798 callbacks stage.
9799
9800 * gnutls.c: Renamed global_initialized to
9801 gnutls_global_initialized. Added internals for the
9802 :verify-hostname-error, :verify-error, and :verify-flags
9803 parameters of `gnutls-boot' and documented those parameters in the
9804 docstring. Start callback support.
9173deec
JB
9805 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9806 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9807 on error. Return error code.
e061a11b
TZ
9808 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9809 (emacs_gnutls_read): Likewise.
9810 (Fgnutls_boot): Return handshake error code.
9811 (emacs_gnutls_handle_error): New function.
9812 (wsaerror_to_errno): Likewise.
9813
9814 * w32.h (emacs_gnutls_pull): Add prototype.
9815 (emacs_gnutls_push): Likewise.
9816
9817 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9818 (emacs_gnutls_push): Likewise.
9819
98202011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9821
9822 * process.c (wait_reading_process_output): Check if GnuTLS
9823 buffered some data internally if no FDs are set for TLS
9824 connections.
9825
9826 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9827 (LIBS): Link to USER_LIBS.
9828 ($(BLD)/gnutls.$(0)): New target.
9829
fa6996bc
EZ
98302011-04-24 Eli Zaretskii <eliz@gnu.org>
9831
eb35682e
EZ
9832 * xdisp.c (handle_single_display_spec): Rename the
9833 display_replaced_before_p argument into display_replaced_p, to
9834 make it consistent with the commentary. Fix typos in the
9835 commentary.
9836
e2ad650c
EZ
9837 * textprop.c (syms_of_textprop): Remove dead code.
9838 (copy_text_properties): Delete obsolete commentary about an
9839 interface that was deleted long ago. Fix typos in the description
9840 of arguments.
9841
1b2de274
EZ
9842 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9843 to changes in oldXMenu/XMenu.h from 2011-04-16.
9844 <menu_help_message, prev_menu_help_message>: Constify.
9845 (IT_menu_make_room): menu->help_text is now `const char **';
9846 adjust.
9847
9848 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9849 to changes in oldXMenu/XMenu.h from 2011-04-16.
9850 (struct XMenu): Declare `help_text' `const char **'.
9851
9852 * xfaces.c <Qunspecified>: Make extern again.
9853
9854 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9855 required by POSIX.
1b2de274 9856
762b15be
EZ
9857 * doc.c (get_doc_string): Improve the format passed to `error'.
9858
9859 * doprnt.c (doprnt): Improve commentary.
9860
9861 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9862
9863 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9864 them with etags.
9865
f1052e5d
EZ
9866 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9867 changes in globals.h immediately force recompilation.
762b15be
EZ
9868 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9869 $(CURDIR)/s/ms-w32.h.
9870 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9871
fa6996bc
EZ
9872 * character.c (Fchar_direction): Function deleted.
9873 (syms_of_character): Don't defsubr it.
9874 <char-direction-table>: Deleted.
9875
e6c3da20
EZ
98762011-04-23 Eli Zaretskii <eliz@gnu.org>
9877
9878 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9879 * doprnt.c: Include limits.h.
9880 (SIZE_MAX): New macro.
04f2d78b
CB
9881 (doprnt): Return a size_t value. 2nd arg is now size_t.
9882 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9883 Improve overflow protection. Support `l' modifier for integer
9884 conversions. Support %l conversion. Don't assume an EMACS_INT
9885 argument for integer conversions and for %c.
9886
9887 * lisp.h (doprnt): Restore prototype.
9888
9889 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9890 $(SRC)/character.h.
9891
9892 * Makefile.in (base_obj): Add back doprnt.o.
9893
9894 * deps.mk (doprnt.o): Add back prerequisites.
9895 (callint.o): Depend on character.h.
9896
9897 * eval.c (internal_lisp_condition_case): Include the handler
9898 representation in the error message.
9899 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9900 when breaking from the loop.
9901
9902 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9903
9904 * callint.c (Fcall_interactively): When displaying error message
9905 about invalid control letter, pass the character's codepoint, not
9906 a pointer to its multibyte form. Improve display of the character
9907 in octal and display also its hex code.
9908
9909 * character.c (char_string): Use %x to display the (unsigned)
9910 codepoint of an invalid character, to avoid displaying a bogus
9911 negative value.
9912
9913 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9914 `error', not SYMBOL_NAME itself.
9915
9916 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9917 character arguments to `error'.
9918
9919 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9920 to `error' in error message about FINAL_CHAR argument. Make sure
9921 FINAL_CHAR is a character, and use %c when it is passed as
9922 argument to `error'.
9923
4ffd0d6b 99242011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9925
9926 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9927
9928 * w32.c: Include <time.h>.
9929 (sys_localtime): New function.
9930
4ffd0d6b 99312011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9932
9933 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9934
4ffd0d6b 9935 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9936
4ffd0d6b 99372011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9938
4ffd0d6b
GM
9939 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9940 zombies (Bug#8467).
aac0c6e3 9941
04c56954
EZ
99422011-04-19 Eli Zaretskii <eliz@gnu.org>
9943
9944 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9945 gl_state.e_property when gl_state.object is Qt.
9946
9947 * insdel.c (make_gap_larger): Remove limitation of buffer size
9948 to <= INT_MAX.
9949
16a43933
CY
99502011-04-18 Chong Yidong <cyd@stupidchicken.com>
9951
9952 * xdisp.c (lookup_glyphless_char_display)
9953 (produce_glyphless_glyph): Handle cons cell entry in
9954 glyphless-char-display.
9955 (Vglyphless_char_display): Document it.
9956
9957 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9958 glyphless-char-display.
9959
4581706e
CY
99602011-04-17 Chong Yidong <cyd@stupidchicken.com>
9961
9962 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9963
9964 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9965
9966 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9967 definition for no-X builds.
9968
4887c6e2 99692011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9970
fd35b6f9
PE
9971 Static checks with GCC 4.6.0 and non-default toolkits.
9972
5c1ccb01
PE
9973 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9974
006c5daa
PE
9975 * process.c (keyboard_bit_set): Define only if SIGIO.
9976 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9977 (send_process): Repair possible setjmp clobbering.
9978
efc736d3
PE
9979 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9980
4e2fe2e6
PE
9981 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9982
f97334a2
PE
9983 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9984
4e75f29d
PE
9985 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9986 Define only if needed.
9987
90efadd1
PE
9988 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9989 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9990 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9991
3c647824
PE
9992 * dispextern.h (struct redisplay_interface): Rename param
9993 to avoid shadowing.
e264f262 9994 * termhooks.h (struct terminal): Likewise.
761383f4 9995 * xterm.c (xembed_send_message): Likewise.
3c647824 9996
b58c5c4a
PE
9997 * insdel.c (make_gap_smaller): Define only if
9998 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9999
cad59032
PE
10000 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10001 it.
10002
c339dc2e
PE
10003 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10004 so that we aren't warned about unused symbols.
10005
91a3e27b
PE
10006 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10007
399c71d3 10008 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10009
8ffc96f5
PE
10010 * xfns.c (x_real_positions): Mark locals as initialized.
10011
eef9bc79
PE
10012 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10013
098db9dd
PE
10014 * xterm.c: Fix problems found by static analysis with other toolkits.
10015 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10016 (x_dispatch_event): Declare static if USE_GTK, and
10017 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10018 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10019 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10020 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10021 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10022
eb18f6cc
PE
10023 * xmenu.c (menu_help_callback): Pointer type fixes.
10024 Use const pointers when pointing at readonly data. Avoid pointer
10025 signedness clashes.
10026 (FALSE): Remove unused macro.
10027 (update_frame_menubar): Remove unused decl.
10028
1fe72bf8
PE
10029 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10030
60d9e1db
PE
10031 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10032 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10033 (single_menu_item): Rename local to avoid shadowing.
10034
39261c26
PE
10035 * keyboard.c (make_lispy_event): Remove unused local var.
10036
018c5e19
PE
10037 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10038 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10039
63d2b86e
PE
10040 * bitmaps: Change bitmaps from unsigned char back to the X11
10041 compatible char. Avoid the old compiler warnings about
10042 out-of-range initializers by using, for example, '\xab' rather
10043 than 0xab.
10044
aefd87e1
PE
10045 * xgselect.c (xgselect_initialize): Check vs interface
10046 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10047
bf501fb9
PE
10048 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10049
e9829fdf
PE
10050 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10051 to read-only memory.
10052
1086c095
PE
10053 * fns.c (vector): Remove; this old hack is no longer needed.
10054
2baccd04 10055 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10056 Remove unused var.
dde42981 10057 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10058
72391843 10059 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10060
436c16df 10061 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10062 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10063 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10064
92bb796d 10065 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10066 (x_term_init): Remove local to avoid shadowing.
92bb796d 10067
764430a3 10068 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10069
10070 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10071 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10072
d1dfb56c
EZ
100732011-04-16 Eli Zaretskii <eliz@gnu.org>
10074
c4354cb4
EZ
10075 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10076
d1dfb56c
EZ
10077 Fix regex.c, syntax.c and friends for buffers > 2GB.
10078 * syntax.h (struct gl_state_s): Declare character position members
10079 EMACS_INT.
10080
10081 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10082
04f2d78b
CB
10083 * textprop.c (verify_interval_modification, interval_of):
10084 Declare arguments EMACS_INT.
d1dfb56c
EZ
10085
10086 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10087 EMACS_INT.
10088
10089 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10090
10091 * indent.c (Fvertical_motion): Local variable it_start is now
10092 EMACS_INT.
10093
10094 * regex.c (re_match, re_match_2, re_match_2_internal)
10095 (bcmp_translate, regcomp, regexec, print_double_string)
10096 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10097 (re_compile_pattern, re_exec): Declare arguments and local
10098 variables `size_t' and `ssize_t' and return values `regoff_t', as
10099 appropriate.
10100 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10101 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10102 <compile_stack_type>: `size' and `avail' are now `size_t'.
10103
10104 * regex.h <regoff_t>: Use ssize_t, not int.
10105 (re_search, re_search_2, re_match, re_match_2): Arguments that
10106 specify buffer/string position and length are now ssize_t and
10107 size_t. Return type is regoff_t.
10108
613052cd
BK
101092011-04-16 Ben Key <bkey76@gmail.com>
10110
10111 * nsfont.m: Fixed bugs in ns_get_family and
10112 ns_descriptor_to_entity that were caused by using free to
10113 deallocate memory blocks that were allocated by xmalloc (via
10114 xstrdup). This caused Emacs to crash when compiled with
10115 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10116 --enable-checking=xmallocoverrun). xfree is now used to
10117 deallocate these memory blocks.
10118
4170f62f 101192011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10120
71b41406
PE
10121 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10122
9587a89d
PE
10123 emacs_write: Accept and return EMACS_INT for sizes.
10124 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10125 et seq.
10126 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10127 Accept and return EMACS_INT.
10128 (emacs_gnutls_write): Return the number of bytes written on
10129 partial writes.
10130 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10131 (emacs_read, emacs_write): Remove check for negative size, as the
10132 Emacs source code has been audited now.
9587a89d
PE
10133 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10134 (emacs_read, emacs_write): Use it.
273a5f82
PE
10135 * process.c (send_process): Adjust to the new signatures of
10136 emacs_write and emacs_gnutls_write. Do not attempt to store
10137 a byte offset into an 'int'; it might overflow.
9587a89d 10138 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10139
3e047f51
PE
10140 * sound.c: Don't assume sizes fit in 'int'.
10141 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10142 Return EMACS_INT, not int.
3e047f51 10143 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10144 Accept EMACS_INT, not int.
10145 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10146 record read return values.
10147
cc39a9db
BK
101482011-04-15 Ben Key <bkey76@gmail.com>
10149
c9d0ec6d
JB
10150 * keyboard.c (Qundefined): Don't declare static since it is used
10151 in nsfns.m.
10152 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10153 static since they are used in nsfont.m.
cc39a9db 10154
6c60eb9f
SM
101552011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10156
10157 * process.c (Qprocessp): Don't declare static.
10158 * lisp.h (Qprocessp): Declare again.
10159
7990b61a
JB
101602011-04-15 Juanma Barranquero <lekktu@gmail.com>
10161
10162 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10163
5d4cb038
PE
101642011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10165
8bd7b830 10166 Improve C-level modularity by making more things 'static'.
cd64ea1d 10167
e3b27b31
PE
10168 Don't publish debugger-only interfaces to other modules.
10169 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10170 (verify_bytepos, count_markers): Move decls to the only modules
10171 that need them.
10172 * region-cache.h (pp_cache): Likewise.
10173 * window.h (check_all_windows): Likewise.
10174 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10175
5d4cb038
PE
10176 * sysdep.c (croak): Now static, if
10177 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10178 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10179
10180 * alloc.c (refill_memory_reserve): Now static if
10181 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10182 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10183
e87b6180
PE
10184 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10185 Define only if USE_LUCID.
10186
ac64929e
PE
10187 * xrdb.c (x_customization_string, x_rm_string): Now static.
10188
6f37259d
PE
10189 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10190 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10191
1683e3ab
PE
10192 * xdisp.c (draw_row_with_mouse_face): Now static.
10193 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10194
de9c2632
PE
10195 * window.h (check_all_windows): Mark externally visible.
10196
2b96acb7
PE
10197 * window.c (window_deletion_count): Now static.
10198
10199 * undo.c: Make symbols static if they're not exported.
10200 (last_undo_buffer, last_boundary_position, pending_boundary):
10201 Now static.
10202
50436f33
PE
10203 * textprop.c (interval_insert_behind_hooks): Now static.
10204 (interval_insert_in_front_hooks): Likewise.
10205
64520e5c
PE
10206 * term.c: Make symbols static if they're not exported.
10207 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10208 (max_frame_lines, tty_set_terminal_modes):
10209 (tty_reset_terminal_modes, tty_turn_off_highlight):
10210 (get_tty_terminal): Now static.
10211 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10212 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10213 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10214 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10215 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10216
1fa53021
PE
10217 * sysdep.c: Make symbols static if they're not exported.
10218 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10219 Now static.
10220 (sigprocmask_set, full_mask): Remove; unused.
10221 (wait_debugging): Mark as visible.
10222 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10223 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10224
d4b43b22
PE
10225 * syntax.c (syntax_temp): Define only if !__GNUC__.
10226
b7c513d0
PE
10227 * sound.c (current_sound_device, current_sound): Now static.
10228
989b29ad
PE
10229 * search.c (searchbufs, searchbuf_head): Now static.
10230
13a55a78
PE
10231 * scroll.c (scroll_cost): Remove; unused.
10232 * dispextern.h (scroll_cost): Remove decl.
10233
de68a1fc
PE
10234 * region-cache.h (pp_cache): Mark as externally visible.
10235
40ccffa6
PE
10236 * process.c: Make symbols static if they're not exported.
10237 (process_tick, update_tick, create_process, chan_process):
10238 (Vprocess_alist, proc_buffered_char, datagram_access):
10239 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10240 (deactivate_process): Mark defn as static, as well as decl.
10241 * lisp.h (create_process): Remove decl.
10242 * process.h (chan_process, Vprocess_alist): Remove decls.
10243
ad64fc97
PE
10244 * print.c: Make symbols static if they're not exported.
10245 (print_depth, new_backquote_output, being_printed, print_buffer):
10246 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10247 (print_interval, print_number_index, initial_stderr_stream):
10248 Now static.
10249 * lisp.h (Fprinc): Remove decl.
10250 (debug_output_compilation_hack): Mark as externally visible.
10251
adddb265
PE
10252 * sysdep.c (croak): Move decl from here to syssignal.h.
10253 * syssignal.h (croak): Put it here, so the API can be checked when
10254 'croak' is called from dissociate_if_controlling_tty.
10255
1717ede2
PE
10256 * minibuf.c: Make symbols static if they're not exported.
10257 (minibuf_save_list, choose_minibuf_frame): Now static.
10258 * lisp.h (choose_minibuf_frame): Remove decl.
10259
fa5fb2bc
PE
10260 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10261
1e3890d1
PE
10262 * lread.c: Make symbols static if they're not exported.
10263 (read_objects, initial_obarray, oblookup_last_bucket_number):
10264 Now static.
10265 (make_symbol): Remove; unused.
10266 * lisp.h (initial_obarray, make_symbol): Remove decls.
10267
8a1414fa
PE
10268 * keyboard.c: Make symbols static if they're not exported.
10269 (single_kboard, recent_keys_index, total_keys, recent_keys):
10270 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10271 (this_single_command_key_start, echoing, last_auto_save):
10272 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10273 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10274 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10275 (Vlispy_mouse_stem, double_click_count):
10276 Now static.
10277 (force_auto_save_soon): Define only if SIGDANGER.
10278 (ignore_mouse_drag_p): Now static if
10279 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10280 (print_help): Remove; unused.
10281 (stop_character, last_timer_event): Mark as externally visible.
10282 * keyboard.h (ignore_mouse_drag_p): Declare only if
10283 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10284 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10285 * lisp.h (echoing): Remove decl.
10286 (force_auto_save_soon): Declare only if SIGDANGER.
10287 * xdisp.c (redisplay_window): Simplify code, to make it more
10288 obvious that ignore_mouse_drag_p is not accessed if !defined
10289 USE_GTK && !defined HAVE_NS.
10290
93ea6e8f
PE
10291 * intervals.c: Make symbols static if they're not exported.
10292 (merge_properties_sticky, merge_interval_right, delete_interval):
10293 Now static.
10294 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10295
77382fcc
PE
10296 * insdel.c: Make symbols static if they're not exported.
10297 However, leave prepare_to_modify_buffer alone. It's never
10298 called from outside this function, but that appears to be a bug.
10299 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10300 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10301 (adjust_after_replace_noundo): Remove; unused.
10302 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10303 (signal_before_change): Remove decls.
77382fcc 10304
9306c32e
PE
10305 * indent.c (val_compute_motion, val_vmotion): Now static.
10306
cd44d2eb
PE
10307 * image.c: Make symbols static if they're not exported.
10308 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10309 if USE_GTK.
10310 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10311 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10312
ad9a7a06
PE
10313 * fringe.c (standard_bitmaps): Now static.
10314 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10315
81626931
PE
10316 * frame.c: Make symbols static if they're not exported.
10317 (x_report_frame_params, make_terminal_frame): Now static.
10318 (get_frame_param): Now static, unless HAVE_NS.
10319 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10320 (x_get_resource_string): Remove; not used.
10321 * frame.h (make_terminal_frame, x_report_frame_params):
10322 (x_get_resource_string); Remove decls.
10323 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10324 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10325
239f9db9
PE
10326 * font.c, fontset.c: Make symbols static if they're not exported.
10327 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10328 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10329 * font.c (font_close_object): Now static.
10330 * font.h (font_close_object): Remove.
10331 * fontset.c (FONTSET_OBJLIST): Remove.
10332 (free_realized_fontset) #if-0 the body, which does nothing.
10333 (face_suitable_for_char_p): #if-0, as it's never called.
10334 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10335 * xfaces.c (face_at_string_position):
10336 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10337 since 0 is always ASCII.
10338
dfcf3579
PE
10339 * fns.c (weak_hash_tables): Now static.
10340
5045092b
PE
10341 * fileio.c: Make symbols static if they're not exported.
10342 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10343 (Vwrite_region_annotation_buffers): Now static.
10344
57a96f5c
PE
10345 * eval.c: Make symbols static if they're not exported.
10346 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10347 * lisp.h (backtrace_list): Remove decl.
10348
35f08c38
PE
10349 * emacs.c: Make symbols static if they're not exported.
10350 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10351 (fatal_error_code, fatal_error_signal_hook, standard_args):
10352 Now static.
10353 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10354 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10355 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10356 * lisp.h (fatal_error_signal_hook): Remove decl.
10357 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10358
f44bd759
PE
10359 * editfns.c: Move a (normally-unused) function to its only use.
10360 * editfns.c, lisp.h (get_operating_system_release): Remove.
10361 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10362 worth the hassle of breaking this out.
10363
b532497d
PE
10364 * xterm.c: Make symbols static if they're not exported.
10365 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10366 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10367 (x_destroy_window, x_delete_display):
10368 Now static.
10369 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10370 (x_mouse_leave): Remove; unused.
10371 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10372 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10373 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10374 Remove decls.
10375 (x_mouse_leave): Declare only if WINDOWSNT.
10376 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10377 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10378 USE_X_TOOLKIT.
10379
1675728f
PE
10380 * ftxfont.c: Make symbols static if they're not exported.
10381 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10382 HAVE_FREETYPE.
10383 * font.h (ftxfont_driver): Likewise.
10384
e4cebfca
PE
10385 * xfns.c: Make symbols static if they're not exported.
10386 (x_last_font_name, x_display_info_for_name):
10387 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10388 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10389 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10390 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10391 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10392 (last_show_tip_args): Now static.
10393 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10394 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10395 (x_screen_planes): Remove; unused.
10396 * dispextern.h (x_screen_planes): Remove decl.
10397
5bf46f05
PE
10398 * dispnew.c: Make symbols static if they're not exported.
10399 * dispextern.h (redraw_garbaged_frames, scrolling):
10400 (increment_row_positions): Remove.
10401 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10402 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10403 Now static.
10404 (redraw_garbaged_frames): Remove; unused.
10405
435f4c28
PE
10406 * xfaces.c: Make symbols static if they're not exported.
10407 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10408 Remove decls.
10409 * xterm.h (defined_color): Remove decls.
10410 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10411 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10412 (menu_face_changed_default, defined_color, free_realized_face):
10413 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10414 (ascii_face_of_lisp_face): Remove; unused.
10415
8524aef3
PE
10416 * xdisp.c: Make symbols static if they're not exported.
10417 * dispextern.h (scratch_glyph_row, window_box_edges):
10418 (glyph_to_pixel_coords, set_cursor_from_row):
10419 (get_next_display_element, set_iterator_to_next):
10420 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10421 (show_mouse_face): Remove decls
10422 * frame.h (message_buf_print): Likewise.
10423 * lisp.h (pop_message, set_message, check_point_in_composition):
10424 Likewise.
10425 * xterm.h (set_vertical_scroll_bar): Likewise.
10426 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10427 (message_buf_print, scratch_glyph_row, displayed_buffer):
10428 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10429 (get_next_display_element, show_mouse_face, window_box_edges):
10430 (frame_to_window_pixel_xy, check_point_in_composition):
10431 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10432 (glyph_to_pixel_coords): Remove; unused.
10433
16390cd2
PE
10434 * dired.c (file_name_completion): Now static.
10435
10436 * dbusbind.c (xd_in_read_queued_messages): Now static.
10437
a25f4dfa
PE
10438 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10439 * data.c (circular_list_error): Remove.
10440
14a9c8df
PE
10441 * commands.h (last_point_position, last_point_position_buffer):
10442 (last_point_position_window): Remove decls.
10443 * keyboard.c: Make these variables static.
10444
04f2d78b
CB
10445 * coding.h (coding, code_convert_region, encode_coding_gap):
10446 Remove decls.
74ab6df5
PE
10447 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10448 (iso_code_class, detect_coding, code_convert_region): Now static.
10449 (encode_coding_gap): Remove; unused.
10450
38dfbee1
PE
10451 * chartab.c (chartab_chars, chartab_bits): Now static.
10452
a2cb4e63
PE
10453 * charset.h (charset_iso_8859_1): Remove decl.
10454 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10455 Now static.
10456
127198fd
PE
10457 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10458 * ccl.c (Vccl_program_table): Now static.
10459 (check_ccl_update): Remove; unused.
10460
d85b608f
PE
10461 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10462 * category.h: ... from here.
10463 * category.c (check_category_table, set_category_set): Now static.
10464
31cd66f3
PE
10465 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10466 * lisp.h: Remove these decls.
10467
c358e587
PE
10468 * buffer.c (buffer_count): Remove unused var.
10469
e78aecca
PE
10470 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10471 so that it's not optimized away.
10472 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10473 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10474 exported only to the debugger.
10475
e192d7d3 10476 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10477 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10478
92470028
PE
10479 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10480 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10481 was inaccessible from Lisp.
10482 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10483 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10484
244ed907
PE
10485 alloc.c: Import and export fewer symbols, and remove unused items.
10486 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10487 is defined.
10488 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10489 it's not optimized away by whole-program optimization.
10490 (message_enable_multibyte, free_misc): Remove.
10491 (catchlist, handlerlist, mark_backtrace):
10492 Declare only if BYTE_MARK_STACK.
10493 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10494 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10495 (message_enable_multibyte): Remove decl.
10496 (free_misc, interval_free_list, float_block, float_block_index):
10497 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10498 (cons_free_list, last_marked_index):
10499 Now static.
10500 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10501 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10502 (mark_backtrace): Define only if BYTE_MARK_STACK.
10503 * xdisp.c (message_enable_multibyte): Now static.
10504
61c2b50e 10505 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10506 This makes it easier for human readers (and static analyzers)
10507 to see whether these variables are used from other modules.
10508 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10509 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10510 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10511 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10512 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10513 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10514 * xmenu.c, xselect.c:
10515 Declare Q* vars static if they are not used in other modules.
10516 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10517 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10518 Remove decls of unexported vars.
10519 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10520
95c82688
PE
10521 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10522
16a97296
PE
10523 Make Emacs functions such as Fatom 'static' by default.
10524 This makes it easier for human readers (and static analyzers)
10525 to see whether these functions can be called from other modules.
10526 DEFUN now defines a static function. To make the function external
10527 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10528 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10529 (Finit_image_library):
16a97296
PE
10530 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10531 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10532 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10533 Remove decls, since these functions are now static.
10534 (Funintern, Fget_internal_run_time): New decls, since these functions
10535 were already external.
95c82688 10536
16a97296
PE
10537 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10538 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10539 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10540 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10541 * keyboard.c, keymap.c, lread.c:
10542 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10543 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10544 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10545 Mark functions with DEFUE instead of DEFUN,
10546 if they are used in other modules.
10547 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10548 decls for now-static functions.
10549 * buffer.h (Fdelete_overlay): Remove decl.
10550 * callproc.c (Fgetenv_internal): Mark as internal.
10551 * composite.c (Fremove_list_of_text_properties): Remove decl.
10552 (Fcomposition_get_gstring): New forward static decl.
10553 * composite.h (Fcomposite_get_gstring): Remove decl.
10554 * dired.c (Ffile_attributes): New forward static decl.
10555 * doc.c (Fdocumntation_property): New forward static decl.
10556 * eval.c (Ffetch_bytecode): New forward static decl.
10557 (Funintern): Remove extern decl; now in .h file where it belongs.
10558 * fileio.c (Fmake_symbolic_link): New forward static decl.
10559 * image.c (Finit_image_library): New forward static decl.
10560 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10561 * intervals.h (Fprevious_property_change):
10562 (Fremove_list_of_text_properties): Remove decls.
10563 * keyboard.c (Fthis_command_keys): Remove decl.
10564 (Fcommand_execute): New forward static decl.
10565 * keymap.c (Flookup_key): New forward static decl.
10566 (Fcopy_keymap): Now static.
10567 * keymap.h (Flookup_key): Remove decl.
10568 * process.c (Fget_process): New forward static decl.
10569 (Fprocess_datagram_address): Mark as internal.
10570 * syntax.c (Fsyntax_table_p): New forward static decl.
10571 (skip_chars): Remove duplicate decl.
10572 * textprop.c (Fprevious_property_change): New forward static decl.
10573 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10574 Now internal.
10575 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10576 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10577
785bbd42
PE
10578 * editfns.c (Fformat): Remove unreachable code.
10579
8b913b57
AS
105802011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10581
10582 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10583 change. (Bug#8496)
10584
a6744a35
EZ
105852011-04-13 Eli Zaretskii <eliz@gnu.org>
10586
10587 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10588 when at ZV. (Bug#8487)
10589
e7974947
AS
105902011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10591
baad03f0
AS
10592 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10593 (Bug#8437)
10594 * keyboard.c (parse_tool_bar_item): Likewise.
10595 * sound.c (sound_cleanup, alsa_close): Likewise.
10596 * termcap.c (tgetent): Likewise.
10597 * xfns.c (x_default_font_parameter): Likewise.
10598 * xsettings.c (read_and_apply_settings): Likewise.
10599
e7974947
AS
10600 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10601 (overrun_check_free): Protoize.
10602
28272684
PE
106032011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10604
10605 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10606 since callers should never pass a negative size.
10607 Change the signature to match that of plain 'read' and 'write'; see
10608 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10609 * lisp.h: Update prototypes of emacs_write and emacs_read.
10610
11997c76
EZ
106112011-04-11 Eli Zaretskii <eliz@gnu.org>
10612
10613 * xdisp.c (redisplay_window): Don't try to determine the character
10614 position of the scroll margin if the window start point w->startp
e896f03c 10615 is outside the buffer's accessible region. (Bug#8468)
11997c76 10616
8a2cbd72
EZ
106172011-04-10 Eli Zaretskii <eliz@gnu.org>
10618
10619 Fix write-region and its subroutines for buffers > 2GB.
10620 * fileio.c (a_write, e_write): Modify declaration of arguments and
10621 local variables to support buffers larger than 2GB.
10622 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10623
10624 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10625 argument, local variables, and return value.
10626
10627 * lisp.h: Update prototypes of emacs_write and emacs_read.
10628
10629 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10630
4073e537 106312011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10632
1ebfdcb6
PE
10633 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10634
b2ded58d
PE
10635 Fix more problems found by GCC 4.6.0's static checks.
10636
7d66342c
PE
10637 * xdisp.c (vmessage): Use a better test for character truncation.
10638
bbf47d44
PE
10639 * charset.c (load_charset_map): <, not <=, for optimization,
10640 and to avoid potential problems with integer overflow.
9248994d 10641 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10642 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10643 * editfns.c (Fformat): Likewise.
1e69125e 10644 * syntax.c (skip_chars): Likewise.
3befa583 10645
e3019616
PE
10646 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10647 This also lets GCC 4.6.0 generate slightly better loop code.
10648
becfa255
PE
10649 * callint.c (Fcall_interactively): <, not <=, for optimization.
10650 (Fcall_interactively): Count the number of arguments produced,
10651 not the number of arguments given. This is simpler and lets GCC
10652 4.6.0 generate slightly better code.
10653
dae0cd48
PE
10654 * ftfont.c: Distingish more carefully between FcChar8 and char.
10655 The previous code passed unsigned char * to a functions like
10656 strlen and xstrcasecmp that expect char *, which does not
10657 conform to the C standard.
10658 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10659 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10660 char * when the C standard requires it.
10661
76032d70
PE
10662 * keyboard.c (read_char): Remove unused var.
10663
eb3f1cc8
PE
10664 * eval.c: Port to Windows vsnprintf (Bug#8435).
10665 Include <limits.h>.
10666 (SIZE_MAX): Define if the headers do not.
10667 (verror): Do not give up if vsnprintf returns a negative count.
10668 Instead, grow the buffer. This ports to Windows vsnprintf, which
10669 does not conform to C99. Problem reported by Eli Zaretskii.
10670 Also, simplify the allocation scheme, by avoiding the need for
10671 calling realloc, and removing the ALLOCATED variable.
10672
70476b54
PE
10673 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10674
12020a9e
PE
10675 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10676 But keep the doprint source code for now, as we might revamp it
10677 and use it again (Bug#8435).
ea6c7ae6
PE
10678 * lisp.h (doprnt): Remove.
10679 * Makefile.in (base_obj): Remove doprnt.o.
10680 * deps.mk (doprnt.o): Remove.
10681
5fdb398c
PE
10682 error: Print 32- and 64-bit integers portably (Bug#8435).
10683 Without this change, on typical 64-bit hosts error ("...%d...", N)
10684 was used to print both 32- and 64-bit integers N, which relied on
10685 undefined behavior.
61bdb816 10686 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10687 * lisp.h (error, verror): Mark as printf-like functions.
10688 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10689 Report overflow in size calculations when allocating printf buffer.
10690 Do not truncate output string at its first null byte.
10691 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10692 Truncate the output at a character boundary, since vsnprintf does not
10693 do that.
10694 * charset.c (check_iso_charset_parameter): Convert internal
10695 character to string before calling 'error', since %c now has the
10696 printf meaning.
10697 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10698 overflow when computing char to be passed to 'error'. Do not
10699 pass Lisp_Object to 'error'; pass the integer instead.
10700 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10701 formatted with plain %d.
10702
b189fa66
PE
10703 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10704
bff87ef0
PE
10705 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10706
7e2cac20
PE
10707 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10708
ce4d90b5
PE
10709 * xterm.c (x_catch_errors): Remove duplicate declaration.
10710
266c9547
PE
10711 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10712
79c49ad2
PE
10713 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10714
368f4090
JM
107152011-04-10 Jim Meyering <meyering@redhat.com>
10716
10717 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10718 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10719 return ssize_t not "int", and use size_t as the buffer length.
10720 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10721 * gnutls.h: Update declarations.
10722 * process.c (read_process_output): Use ssize_t, to match.
10723 (send_process): Likewise.
10724
a32d4040
CY
107252011-04-09 Chong Yidong <cyd@stupidchicken.com>
10726
10727 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10728
8546720e 107292011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10730
04f2d78b
CB
10731 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10732 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10733
8546720e
GM
10734 * xterm.c (handle_one_xevent):
10735 * xmenu.c (create_and_show_popup_menu):
10736 * xselect.c (x_decline_selection_request)
10737 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10738
0a2f5c1a 107392011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10740
10741 Fix some uses of `int' instead of EMACS_INT.
10742 * search.c (string_match_1, fast_string_match)
10743 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10744 (scan_buffer, find_next_newline_no_quit)
10745 (find_before_next_newline, search_command, Freplace_match)
10746 (Fmatch_data): Make some `int' variables be EMACS_INT.
10747
10748 * xdisp.c (display_count_lines): 3rd argument and return value now
10749 EMACS_INT. All callers changed.
10750 (pint2hrstr): Last argument is now EMACS_INT.
10751
10752 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10753 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10754 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10755 (decode_coding_utf_16, decode_coding_emacs_mule)
10756 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10757 (decode_coding_ccl, decode_coding_charset)
10758 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10759 (decode_coding_iso_2022, decode_coding_emacs_mule)
10760 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10761 <char_offset, last_offset>: Declare EMACS_INT.
10762 (encode_coding_utf_8, encode_coding_utf_16)
10763 (encode_coding_emacs_mule, encode_invocation_designation)
10764 (encode_designation_at_bol, encode_coding_iso_2022)
10765 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10766 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10767 Declare EMACS_INT.
10768 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10769 (encode_invocation_designation): Last argument P_NCHARS is now
10770 EMACS_INT.
10771 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10772 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10773
10774 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10775 All users changed.
10776
10777 * ccl.c (Fccl_execute_on_string): Declare some variables
10778 EMACS_INT.
10779
8546720e 107802011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10781
10782 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10783
4e19a977
CS
107842011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10785
10786 * process.c (Fformat_network_address): Doc fix.
10787
87302331
R
107882011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10789
ee7683eb 10790 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10791
cbb59342
CY
107922011-04-08 Chong Yidong <cyd@stupidchicken.com>
10793
10794 * keyboard.c (read_char): Call Lisp function help-form-show,
10795 instead of using internal_with_output_to_temp_buffer.
10796 (Qhelp_form_show): New var.
e0d38eeb 10797 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10798
10799 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10800
10801 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10802
e67a13ab
CY
108032011-04-06 Chong Yidong <cyd@stupidchicken.com>
10804
04f2d78b
CB
10805 * process.c (Flist_processes): Remove to Lisp.
10806 (list_processes_1): Delete.
e67a13ab 10807
973f782d
EZ
108082011-04-06 Eli Zaretskii <eliz@gnu.org>
10809
7c106b1e
EZ
10810 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10811
973f782d
EZ
10812 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10813
41cf7d1a 108142011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10815
ca23cc88
PE
10816 Fix more problems found by GCC 4.6.0's static checks.
10817
f390e2d5
PE
10818 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10819
42eea0d0
PE
10820 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10821
b69769da 10822 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10823
f9541e84
PE
10824 * xdisp.c (vmessage): Mark as a printf-like function.
10825
13841b55
PE
10826 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10827
c136c10f
PE
10828 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10829
5e2d4a30
PE
10830 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10831 printf-like functions.
10832 (tiff_load): Add casts to remove these marks before passing them
10833 to system-supplied API.
10834
583f48b9
PE
10835 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10836
b25d760e
PE
10837 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10838 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10839 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10840 directly, rather than having caller test rule sign. This avoids
10841 some unnecessary tests.
10842 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10843 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10844 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10845
bc7b6697 10846 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10847 (xfont_open): Avoid unnecessary tests.
bc7b6697 10848
27ccc379
PE
10849 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10850
dcd5c89a
PE
10851 * composite.h, composite.c (composition_gstring_put_cache):
10852 Use EMACS_INT, not int, for length.
10853
b13a45c6
PE
10854 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10855 breaking out part of COMPOSITION_DECODE_RULE.
10856 (COMPOSITION_DECODE_RULE): Use it.
10857 * composite.c (get_composition_id): Remove unused local vars,
10858 by using the new macro.
10859
1e792e4d
PE
10860 * textprop.c (set_text_properties_1): Change while to do-while,
10861 since the condition is always true at first.
10862
dc6c6455 10863 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10864 (interval_deletion_adjustment): Return unsigned value.
10865 All uses changed.
dc6c6455 10866
aba7731a
PE
10867 * process.c (list_processes_1, create_pty, read_process_output):
10868 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10869 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10870 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10871 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10872 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10873
fdfc4bf3
PE
10874 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10875
fca8fe46 10876 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10877 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10878
06a0259a 10879 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10880 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10881 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10882
e7b9e80f
PE
10883 * print.c (print_error_message): Avoid int overflow.
10884
56201685
PE
10885 * font.c (font_list_entities): Redo for clarity,
10886 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10887
78834453 10888 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10889 (font_score): Avoid potential overflow in diff calculation.
78834453 10890
0bc0b309 10891 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10892 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10893
e610eaca
PE
10894 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10895
b895abce
PE
10896 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10897 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10898 can always succeed if overflow has undefined behavior.
10899
1f1d9321 10900 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10901 (wordify): Omit three unnecessary tests.
1f1d9321 10902
c59478bc
PE
10903 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10904 All callers changed. This avoids the need for an unused var.
10905
79b73827
PE
10906 * casefiddle.c (casify_region): Remove var that is set but not used.
10907
a4db5dfe
PE
10908 * dired.c (file_name_completion): Remove var that is set but not used.
10909
43aae36e
PE
10910 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10911
2a47c44d 10912 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10913 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10914
a37c69bf
PE
10915 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10916 Check for integer overflow on size calculations.
10917
328ab8e7
PE
10918 * buffer.c (Fprevious_overlay_change): Remove var that is set
10919 but not used.
10920
e5a2a5cb
PE
10921 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10922 Remove vars that are set but not used.
8d84a6eb 10923 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10924 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10925
a60e5f68
PE
10926 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10927
f661cb61 10928 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10929 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10930
f0397f5a
PE
10931 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10932 that are set but not used.
10933
8664db06 10934 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10935 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10936
6abdaa4a
PE
10937 * xselect.c (x_get_local_selection, x_handle_property_notify):
10938 Remove vars that are set but not used.
10939
0ce7538d 10940 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10941 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10942
9ae848fc
PE
10943 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10944 Remove var that is set but not used.
0b918413
PE
10945 (scroll_bar_windows_size): Now size_t, not int.
10946 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10947 Check for overflow.
9ae848fc 10948
a5a62657
PE
10949 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10950 (map_tty_color) [!defined MSDOS]: Likewise.
10951
5c5cdd39
PE
10952 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10953
66ebf983
PE
10954 * coding.c: Remove vars that are set but not used.
10955 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10956 All callers changed.
10957 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10958 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10959 (decode_coding_charset): Remove vars that are set but not used.
10960
1be4d761
PE
10961 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10962 that is set but not used.
10963
47553fa8
PE
10964 * print.c (print_object): Remove var that is set but not used.
10965
1f7196bf 10966 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10967 The gnulib version avoids calling malloc in the usual case,
10968 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10969 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10970 * filelock.c (current_lock_owner): Likewise.
10971 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10972 * sysdep.c: Include allocator.h, careadlinkat.h.
10973 (emacs_no_realloc_allocator): New static constant.
10974 (emacs_readlink): New function.
fdb61804
PE
10975 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10976 ../lib/careadlinkat.h.
d1fdcab7 10977
f84c17c7
SM
109782011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10979
10980 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10981 first non-nil return value).
10982
ef3862ad
JD
109832011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10984
10985 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10986 if not defined (Bug#8403).
10987
376a7006
JB
109882011-04-02 Juanma Barranquero <lekktu@gmail.com>
10989
10990 * xdisp.c (display_count_lines): Remove parameter `start',
10991 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10992 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10993 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10994 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10995 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10996 and thereabouts. All callers changed.
10997 (get_per_char_metric): Remove parameter `f', unused since
10998 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10999
6ca3801d
JM
110002011-04-02 Jim Meyering <meyering@redhat.com>
11001
11002 do not dereference NULL upon failed strdup
11003 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11004 (ns_get_family): Likewise.
11005
d8e2b5ba
JB
110062011-04-02 Juanma Barranquero <lekktu@gmail.com>
11007
11008 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11009
8c74fcbd
JD
110102011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11011
11012 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11013 later (Bug#8403).
11014
7200d79c
SM
110152011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11016
03408648 11017 Add lexical binding.
7200d79c 11018
03408648
SM
11019 * window.c (Ftemp_output_buffer_show): New fun.
11020 (Fsave_window_excursion):
11021 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11022
11023 * lread.c (lisp_file_lexically_bound_p): New function.
11024 (Fload): Bind Qlexical_binding.
11025 (readevalloop): Remove `evalfun' arg.
11026 Bind Qinternal_interpreter_environment.
11027 (Feval_buffer): Bind Qlexical_binding.
11028 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11029 Mark as dynamic.
11030 (syms_of_lread): Declare `lexical-binding'.
11031
11032 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11033
11034 * keyboard.c (eval_dyn): New fun.
11035 (menu_item_eval_property): Use it.
ca105506
SM
11036
11037 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11038
03408648
SM
11039 * fns.c (concat, mapcar1): Accept byte-code-functions.
11040
11041 * eval.c (Fsetq): Handle lexical vars.
11042 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11043 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11044 (FletX, Flet): Obey lexical binding.
11045 (Fcommandp): Handle closures.
11046 (Feval): New `lexical' arg.
11047 (eval_sub): New function extracted from Feval. Use it almost
11048 everywhere where Feval was used. Look up vars in lexical env.
11049 Handle closures.
11050 (Ffunctionp): Move from subr.el.
11051 (Ffuncall): Handle closures.
11052 (apply_lambda): Remove `eval_flags'.
11053 (funcall_lambda): Handle closures and new byte-code-functions.
11054 (Fspecial_variable_p): New function.
11055 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11056 but without exporting it to Lisp.
23aba0ea 11057
23aba0ea 11058 * doc.c (Fdocumentation, store_function_docstring):
03408648 11059 * data.c (Finteractive_form): Handle closures.
23aba0ea 11060
03408648
SM
11061 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11062 interactive spec.
ba83908c 11063
04f2d78b
CB
11064 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11065 New byte-codes.
03408648
SM
11066 (exec_byte_code): New function extracted from Fbyte_code to handle new
11067 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11068
03408648 11069 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11070
03408648 11071 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11072
e2abce01
JB
110732011-03-31 Juanma Barranquero <lekktu@gmail.com>
11074
11075 * xdisp.c (redisplay_internal): Fix prototype.
11076
63696a73 110772011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11078
63696a73 11079 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11080 (try_scrolling): Use it when setting scroll_limit.
11081 Limit scrolling to 100 screen lines.
63696a73
EZ
11082 (redisplay_window): Even when falling back on "recentering",
11083 position point in the window according to scroll-conservatively,
11084 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11085
11086 (try_scrolling): When point is above the window, allow searching
11087 as far as scroll_max, or one screenful, to compute vertical
11088 distance from PT to the scroll margin position. This prevents
11089 try_scrolling from unnecessarily failing when
11090 scroll-conservatively is set to a value slightly larger than the
11091 window height. Clean up the case of PT below the margin at bottom
11092 of window: scroll_max can no longer be INT_MAX. When aggressive
11093 scrolling is in use, don't let point enter the opposite scroll
11094 margin as result of the scroll.
11095 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11096 threshold of 100 lines for never-recentering scrolling.
11097
e4cc2dfc
JB
110982011-03-31 Juanma Barranquero <lekktu@gmail.com>
11099
11100 * dispextern.h (move_it_by_lines):
11101 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11102 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11103 (message_log_check_duplicate): Remove parameters `prev_bol' and
11104 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11105 (redisplay_internal): Remove parameter `preserve_echo_area',
11106 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11107
11108 * indent.c (Fvertical_motion):
11109 * window.c (window_scroll_pixel_based, Frecenter):
11110 Don't pass `need_y_p' to `move_it_by_lines'.
11111
1c470562
SM
111122011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11113
44f230aa
SM
11114 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11115 steal a few bits to be more compact.
11116 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11117 Remove unneeded casts.
11118
1c470562
SM
11119 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11120
888adce9
ZK
111212011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11122
11123 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11124 binding" message (bug#7967).
11125
f838ed7b
PE
111262011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11127
77861b95
PE
11128 Fix more problems found by GCC 4.6.0's static checks.
11129
de6dbc14
PE
11130 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11131 Remove unused local var.
11132
f838ed7b
PE
11133 * editfns.c (Fmessage_box): Remove unused local var.
11134
792c7b2b
PE
11135 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11136 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11137 Omit unused local vars.
c499e557 11138 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11139 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11140 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11141 Omit unused local var.
11142
ba0165e1
PE
11143 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11144 Don't assume string length fits in int.
32ad8845 11145 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11146 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11147
3c59b4c9
PE
11148 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11149 instead of alloca (Bug#8344).
11150
a3eed478 11151 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11152 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11153
eb4d412d
PE
11154 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11155
1658b401
PE
11156 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11157 concerns.
11158
11159 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11160
11161 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11162
9a2c6e05
PE
11163 * keyboard.c (syms_of_keyboard): Use the same style as later
11164 in this function when indexing through an array. This also
11165 works around GCC bug 48267.
11166
03d0a109
PE
11167 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11168
44f730c8
PE
11169 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11170
fe75f926
PE
11171 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11172 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11173
ffa8c828
PE
11174 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11175 This avoids undefined behavior on integer overflow, and is a bit
11176 more convenient anyway since it is compared to a size_t variable.
11177
c5101a77
PE
11178 Variadic C functions now count arguments with size_t, not int.
11179 This avoids an unnecessary limitation on 64-bit machines, which
11180 caused (substring ...) to crash on large vectors (Bug#8344).
11181 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11182 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11183 All variadic functions and their callers changed accordingly.
c5101a77
PE
11184 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11185 * data.c (arith_driver, float_arith_driver): Likewise.
11186 * editfns.c (general_insert_function): Likewise.
11187 * eval.c (struct backtrace.nargs, interactive_p)
11188 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11189 (funcall_lambda, mark_backtrace): Likewise.
11190 * fns.c (concat): Likewise.
11191 * frame.c (x_set_frame_parameters): Likewise.
11192 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11193 0 if not found, not -1. All callers changed.
11194
dd3f25f7
PE
11195 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11196 (stack_copy_size): Now size_t, not int.
11197 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11198
461c2ab9
JB
111992011-03-28 Juanma Barranquero <lekktu@gmail.com>
11200
11201 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11202 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11203 All callers changed.
11204
11205 * lisp.h (multibyte_char_to_unibyte):
11206 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11207 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11208 * character.h (CHAR_TO_BYTE8):
11209 * cmds.c (internal_self_insert):
11210 * editfns.c (general_insert_function):
11211 * keymap.c (push_key_description):
11212 * search.c (Freplace_match):
11213 * xdisp.c (message_dolog, set_message_1): All callers changed.
11214
f6d62986
SM
112152011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11216
11217 * keyboard.c (safe_run_hook_funcall): New function.
11218 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11219 don't set the hook to nil, but remove the offending function instead.
11220 (Qcommand_hook_internal): Remove, unused.
11221 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11222 Vcommand_hook_internal.
11223
11224 * eval.c (enum run_hooks_condition): Remove.
11225 (funcall_nil, funcall_not): New functions.
11226 (run_hook_with_args): Call each function through a `funcall' argument.
11227 Remove `cond' argument, now redundant.
11228 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11229 (Frun_hook_with_args_until_failure): Adjust accordingly.
11230 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11231
1db5b1ad
JB
112322011-03-28 Juanma Barranquero <lekktu@gmail.com>
11233
11234 * dispextern.h (string_buffer_position): Remove declaration.
11235
11236 * print.c (strout): Remove parameter `multibyte', unused since
11237 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11238
11239 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11240 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11241 All callers changed.
11242
11243 * w32.c (_wsa_errlist): Use braces for struct initializers.
11244
11245 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11246 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11247 All callers changed.
11248 (string_buffer_position): Likewise. Also, make static (it's never
11249 used outside xdisp.c).
11250 (cursor_row_p): Remove parameter `w', unused since
11251 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11252 (decode_mode_spec): Remove parameter `precision', introduced during
11253 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11254 All callers changed.
11255
5ffb62aa
JD
112562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11257
11258 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11259
461c2ab9 112602011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11261
11262 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11263 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11264 (ns_update_auto_hide_menu_bar): New functions.
11265 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11266 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11267 ns_constrain_all_frames.
11268 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11269 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11270
5c380ffb
JD
112712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11272
11273 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11274
9af30bdf
GM
112752011-03-27 Glenn Morris <rgm@gnu.org>
11276
11277 * syssignal.h: Replace RETSIGTYPE with void.
11278 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11279 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11280 Replace SIGTYPE with void everywhere.
11281 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11282 * s/template.h (SIGTYPE): Remove commented out definition.
11283
e2abce01
JB
112842011-03-26 Eli Zaretskii <eliz@gnu.org>
11285
11286 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11287 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11288
f868cd8a
JB
112892011-03-26 Juanma Barranquero <lekktu@gmail.com>
11290
59eb0929
JB
11291 * w32.c (read_unc_volume): Use parameter `henum', instead of
11292 global variable `wget_enum_handle'.
11293
11294 * keymap.c (describe_vector): Remove parameters `indices' and
11295 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11296 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11297
f868cd8a
JB
11298 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11299
11300 * keyboard.c (timer_check): Remove parameter `do_it_now',
11301 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11302 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11303 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11304
11305 * keyboard.c (read_char):
11306 * w32menu.c (w32_menu_display_help):
11307 * xmenu.c (show_help_event, menu_help_callback):
11308 Adjust calls to `show_help_echo'.
11309
11310 * gtkutil.c (xg_maybe_add_timer):
11311 * keyboard.c (readable_events):
11312 * process.c (wait_reading_process_output):
11313 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11314
11315 * insdel.c (adjust_markers_gap_motion):
11316 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11317 (gap_left, gap_right): Don't call it.
11318
2ecf6fdb
CY
113192011-03-25 Chong Yidong <cyd@stupidchicken.com>
11320
11321 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11322 incurred during fontification.
11323
6b1f9ba4
JB
113242011-03-25 Juanma Barranquero <lekktu@gmail.com>
11325
11326 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11327 (DEFVAR_PER_BUFFER): Don't pass it.
11328
11329 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11330 (scrolling_window): Don't pass it.
11331
0f4a96b5
JB
113322011-03-25 Juanma Barranquero <lekktu@gmail.com>
11333
11334 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11335
11336 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11337 and `suffix'.
11338 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11339 of variables specific to SELinux and computation of `encoded_absname'.
11340
11341 * image.c (XPutPixel): Remove unused variable `height'.
11342
11343 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11344
11345 * unexw32.c (get_section_info): Remove unused variable `section'.
11346
11347 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11348 (system_process_attributes): Remove unused variable `sess'.
11349 (sys_read): Remove unused variable `err'.
11350
11351 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11352 (w32_wnd_proc): Remove unused variable `isdead'.
11353 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11354 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11355 (x_create_tip_frame): Remove unused variable `tem'.
11356
11357 * w32inevt.c (w32_console_read_socket):
11358 Remove unused variable `no_events'.
11359
11360 * w32term.c (x_draw_composite_glyph_string_foreground):
11361 Remove unused variable `width'.
11362
1149507c
JB
113632011-03-24 Juanma Barranquero <lekktu@gmail.com>
11364
11365 * w32term.c (x_set_glyph_string_clipping):
11366 Don't pass uninitialized region to CombineRgn.
11367
9c88f339
JB
113682011-03-23 Juanma Barranquero <lekktu@gmail.com>
11369
11370 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11371 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11372 (Fx_close_connection): Remove unused variable `i'.
11373
11374 * w32font.c (w32font_draw): Return number of glyphs.
11375 (w32font_open_internal): Remove unused variable `i'.
11376 (w32font_driver): Add missing initializer.
11377
11378 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11379 (fill_in_menu): Remove unused variable `items_added'.
11380
11381 * w32term.c (last_mouse_press_frame): Remove static global variable.
11382 (w32_clip_to_row): Remove unused variable `f'.
11383 (x_delete_terminal): Remove unused variable `i'.
11384
11385 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11386 (NOTHING): Remove unused static global variable.
11387 (uniscribe_check_otf): Remove unused variable `table'.
11388 (uniscribe_font_driver): Add missing initializers.
11389
dee091a3
JD
113902011-03-23 Julien Danjou <julien@danjou.info>
11391
11392 * term.c (Fsuspend_tty, Fresume_tty):
11393 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11394 * window.c (temp_output_buffer_show):
11395 * insdel.c (signal_before_change):
11396 * frame.c (Fhandle_switch_frame):
11397 * fileio.c (Fdo_auto_save):
11398 * emacs.c (Fkill_emacs):
11399 * editfns.c (save_excursion_restore):
11400 * cmds.c (internal_self_insert):
11401 * callint.c (Fcall_interactively):
11402 * buffer.c (Fkill_all_local_variables):
11403 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11404 Use Frun_hooks.
0f4a96b5 11405 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11406 unconditionally since it does the check itself.
dee091a3 11407
2c520ab5 114082011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11409
c9c49752
PE
11410 Fix more problems found by GCC 4.5.2's static checks.
11411
8abc3f12
PE
11412 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11413 the first time through the loop, since we know p0 < p1 then.
11414 This also avoids a gcc -Wstrict-overflow warning.
11415
a2d26660
PE
11416 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11417 leading to a memory leak, possible in functions like
11418 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11419 of objects (Bug#8318).
a2d26660 11420
916c72e9
PE
11421 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11422 that could (at least in theory) be that large.
11423
19ab8a18
PE
11424 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11425 This is less likely to overflow, and avoids undefined behavior if
11426 overflow does occur. All callers changed. Use strtoul to scan
11427 for the unsigned long integer.
b7cbbd6f
PE
11428 (pint2hrstr): Simplify and tune code slightly.
11429 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11430
f0641eff
PE
11431 * scroll.c (do_scrolling): Work around GCC bug 48228.
11432 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11433
7f650bb9
PE
11434 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11435 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11436 (validate_x_resource_name): Simplify count usage.
11437 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11438
37dd57d1
PE
11439 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11440 fail (Bug#8306).
81e56e61 11441
699979fc 11442 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11443
401bf9b4
PE
11444 * process.c (Fmake_network_process): Use socklen_t, not int,
11445 where POSIX says socklen_t is required in portable programs.
11446 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11447 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11448 (Fmake_network_process, server_accept_connection):
11449 (wait_reading_process_output, read_process_output):
11450 Likewise.
11451
b93aacde
PE
11452 * process.c: Rename or move locals to avoid shadowing.
11453 (list_processes_1, Fmake_network_process):
11454 (read_process_output_error_handler, exec_sentinel_error_handler):
11455 Rename or move locals.
4dc343ee 11456 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11457 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11458 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11459 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11460 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11461
af8a867c 11462 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11463 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11464 Include tparam.h instead, since it declares them.
af8a867c
PE
11465 * cm.h (PC): Remove extern decl; tparam.h now does this.
11466 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11467 * terminfo.c: Include tparam.h, to check interfaces.
11468 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11469 (tparam): Adjust signature to match interface in tparam.h;
11470 this removes some undefined behavior. Check that outstring and len
11471 are zero, which they always are with Emacs.
11472 * tparam.h (PC, BC, UP): New extern decls.
11473
0248044d 11474 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11475 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11476
8ff096c1 11477 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11478 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11479 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11480 (ftfont_list): Remove unused local.
49eaafba
PE
11481 (get_adstyle_property, ftfont_pattern_entity):
11482 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11483 Rename locals to avoid shadowing.
8ff096c1 11484
e2be39f6
PE
11485 * xfont.c (xfont_list_family): Mark var as initialized.
11486
c9735e30
PE
11487 * xml.c (make_dom): Now static.
11488
8f5201ae
PE
11489 * composite.c (composition_compute_stop_pos): Rename local to
11490 avoid shadowing.
b246f932
PE
11491 (composition_reseat_it): Remove unused locals.
11492 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11493 (composition_update_it): Mark var as initialized.
11b61122
PE
11494 (find_automatic_composition): Mark vars as initialized,
11495 with a FIXME (Bug#8290).
8f5201ae 11496
760fbc2c
PE
11497 character.h: Rename locals to avoid shadowing.
11498 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11499 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11500 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11501 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11502 to avoid shadowing.
11503
ff08eb85
PE
11504 * textprop.c (property_change_between_p): Remove; unused.
11505
fc7bf025
PE
11506 * intervals.c (interval_start_pos): Now static.
11507
235d7abc
PE
11508 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11509
44f230aa
SM
11510 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11511 Rename locals to avoid shadowing.
3e7d6594 11512
50060332
PE
11513 * sound.c (wav_play, au_play, Fplay_sound_internal):
11514 Fix pointer signedness.
d01f234b 11515 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11516 (wav_play): Initialize a variable to 0, to prevent undefined
11517 behavior (Bug#8278).
50060332 11518
c4fc4e30
PE
11519 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11520
918436ed
PE
11521 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11522
c939f91b
PE
11523 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11524 clobbering (Bug#8298).
b9c7f648
PE
11525 * sysdep.c (sys_subshell): Likewise.
11526 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11527
6bd8c144
PE
11528 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11529 This should get cleaned up, so that child_setup has the
11530 same signature on all platforms.
11531
7710357c 11532 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11533 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11534
c59da222
CY
115352011-03-22 Chong Yidong <cyd@stupidchicken.com>
11536
11537 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11538 not to be necessary, and produces flickering.
11539
66b87493
GM
115402011-03-20 Glenn Morris <rgm@gnu.org>
11541
11542 * config.in: Remove file.
11543
45b6f6d5
JB
115442011-03-20 Juanma Barranquero <lekktu@gmail.com>
11545
11546 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11547 are now in src/globals.h.
11548 (syms_of_minibuf): Remove spurious & from previous change.
11549
cd394be1 115502011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11551
11552 * minibuf.c (completing-read-function): New variable.
11553 (completing-read-default): Rename from completing-read.
11554 (completing-read): Call completing-read-function.
11555
b14e3e21
CY
115562011-03-19 Juanma Barranquero <lekktu@gmail.com>
11557
11558 * xfaces.c (Fx_load_color_file):
11559 Read color file from absolute filename (bug#8250).
11560
f2b726e6
JB
115612011-03-19 Juanma Barranquero <lekktu@gmail.com>
11562
11563 * makefile.w32-in: Update dependencies.
11564
09f6ff02
EZ
115652011-03-17 Eli Zaretskii <eliz@gnu.org>
11566
11567 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11568
29a6015a
PE
115692011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11570
a3a6c54e
PE
11571 Fix more problems found by GCC 4.5.2's static checks.
11572
b766f867
PE
11573 * process.c (make_serial_process_unwind, send_process_trap):
11574 (sigchld_handler): Now static.
11575
be02381c
PE
11576 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11577 That way, the code declares only the vars that it needs.
11578 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11579 * s/cygwin.h (PTY_ITERATION): Likewise.
11580 * s/darwin.h (PTY_ITERATION): Likewise.
11581 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11582
57048744
PE
11583 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11584 * process.c (allocate_pty): Don't declare stb unless it's needed.
11585
7914961c 11586 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11587 (CONSTANTLIM): Remove; unused.
11588 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11589 Define only if needed.
7914961c 11590
b3967b18
PE
11591 * unexelf.c (unexec): Name an expression,
11592 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11593 Use a different way to cause a compilation error if anyone uses
11594 n rather than nn, a way that does not involve shadowing.
73366a00 11595 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11596
29a6015a
PE
11597 * deps.mk (unexalpha.o): Remove; unused.
11598
43cfc33e 11599 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11600 * unexec.h: New file.
ce701a33
PE
11601 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11602 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11603 Depend on unexec.h.
11604 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11605 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11606 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11607 Change as necessary to match prototype in unexec.h.
ce701a33 11608
01f44d5a
PE
11609 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11610 shadowing.
4f63c6bb 11611 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11612
a6670b0b
PE
11613 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11614 Rename locals to avoid shadowing.
11615
cef2010d 11616 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11617 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11618
d4d7173a
PE
11619 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11620
f08b802a
PE
11621 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11622 warning when compiling print.c.
11623
3ddb0639
PE
11624 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11625 instead of using an uninitialized var.
5ad03b97 11626 (font_sort_entities): Mark var as initialized.
3ddb0639 11627
170a2692
PE
11628 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11629
e663c700
PE
11630 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11631 pointers to constants.
89bc529a 11632 (font_parse_fcname): Remove unused vars.
7b81e2d0 11633 (font_delete_unmatched): Now static.
ea838e10 11634 (font_get_spec): Remove; unused.
13a547c6
PE
11635 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11636 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11637 Rename or move locals to avoid shadowing.
e663c700 11638
2a80c887 11639 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11640 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11641
1384fa33 11642 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11643 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11644
8b2c52e9
PE
11645 * alloc.c (mark_backtrace): Move decl from here ...
11646 * lisp.h: ... to here, so that it can be checked.
11647
475545b5 11648 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11649 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11650 (lisp_indirect_variable): Name an expression,
11651 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11652 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11653
b1349114 11654 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11655 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11656 Use const pointer when appropriate.
b1349114 11657
a2928364
PE
11658 * lisp.h (get_system_name, get_operating_system_release):
11659 Move decls here, to check interfaces.
11660 * process.c (get_operating_system_release): Move decl to lisp.h.
11661 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11662 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11663 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11664 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11665 (Fformat_time_string, Fencode_time, Finsert_char):
11666 (Ftranslate_region_internal, Fformat):
11667 Rename or remove local vars to avoid shadowing.
9710023e 11668 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11669
a415e694
PE
11670 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11671 avoid shadowing.
11672
8ef4622d
PE
11673 * lisp.h (eassert): Check that the argument compiles, even if
11674 ENABLE_CHECKING is not defined.
11675
946f9a5b
PE
11676 * data.c (Findirect_variable): Name an expression, to avoid
11677 gcc -Wbad-function-cast warning.
112396d6 11678 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11679 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11680 (Fmake_variable_buffer_local, Fmake_local_variable):
11681 Mark variables as initialized.
52746918 11682 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11683
e5aab7e7 11684 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11685 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11686 Rename locals to avoid shadowing.
dff45157
PE
11687 (mark_stack): Move local variables into the #ifdef region where
11688 they're used.
7bc26fdb
PE
11689 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11690 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11691 needed otherwise.
11692 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11693 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11694 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11695
e5aab7e7
PE
11696 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11697 avoids undefined behavior in theory.
11698
4da60324
PE
11699 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11700
88043301
PE
11701 Use functions, not macros, for up- and down-casing (Bug#8254).
11702 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11703 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11704 to use the following functions instead of these macros.
11705 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11706 EMACS_INT, since callers assume the returned value fits in int.
11707 (upcase1): Likewise, for UPCASE_TABLE.
11708 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11709 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11710 the race-condition problem in the old DOWNCASE.
88043301 11711
19ed5445
PE
11712 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11713 Rename locals to avoid shadowing.
11714 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11715 (regex_compile, re_search_2, re_match_2_internal):
11716 Remove unused local vars.
952db0d7
PE
11717 (FREE_VAR): Rewrite so as not to use empty "else",
11718 which gcc can warn about.
da053e48 11719 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11720 (RETALLOC_IF): Define only if needed.
11721 (WORDCHAR_P): Likewise. This one is never needed, but is used
11722 only in a comment talking about a compiler bug, so put inside
11723 the #if 0 of that comment.
11724 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11725 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11726 Remove; unused.
19ed5445 11727
1f3561e4 11728 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11729 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11730 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11731
ded6f8f7
PE
11732 * search.c (simple_search): Remove unused var.
11733
dbd37a95
PE
11734 * dired.c (compile_pattern): Move decl from here ...
11735 * lisp.h: ... to here, so that it can be checked.
11736 (struct re_registers): New forward decl.
11737
7e47afad
PE
11738 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11739
85f24f61
PE
11740 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11741 All uses changed.
11742 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11743 Rename locals to avoid shadowing.
5671df8f 11744 (Fvertical_motion): Mark locals as initialized.
85f24f61 11745
181aa2be 11746 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11747 (casify_region): Mark local as initialized.
181aa2be 11748
930d429c
PE
11749 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11750
7082eac6
PE
11751 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11752 New macros, so that the caller can use some names other than
11753 gcpro1, gcpro2, etc.
11754 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11755 of the new macros.
11756 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11757 argument, for consistency with GCPRO2_VAR, etc: it is now the
11758 prefix of the variable, not the variable itself. All uses
11759 changed.
38b2c076
PE
11760 * dired.c (directory_files_internal, file_name_completion):
11761 Rename locals to avoid shadowing.
11762
15206ed9
PE
11763 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11764 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11765 dired.c's scmp function, had undefined behavior.
11766 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11767 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11768 * buffer.h: ... to here, because these macros use current_buffer,
11769 and the new implementation with inline functions needs to have
11770 current_buffer in scope now, rather than later when the macros
11771 are used.
11772 (downcase, upcase1): New static inline functions.
11773 (DOWNCASE, UPCASE1): Reimplement using these functions.
11774 This avoids undefined behavior in expressions like
11775 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11776 from race conditions in accessing the global variables
11777 case_temp1 and case_temp2.
11778 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11779 * lisp.h (case_temp1, case_temp2): Remove their decls.
11780 * character.h (ASCII_CHAR_P): Move from here ...
11781 * lisp.h: ... to here, so that the inline functions mentioned
11782 above can use them.
11783
4a6bea26
PE
11784 * dired.c (directory_files_internal_unwind): Now static.
11785
f14b7e14
PE
11786 * fileio.c (file_name_as_directory, directory_file_name):
11787 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11788 Now static.
2893f146
PE
11789 (file_name_as_directory): Use const pointers when appropriate.
11790 (Fexpand_file_name): Likewise. In particular, newdir might
11791 point at constant storage, so make it a const pointer.
fd4ead52 11792 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11793 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11794 signedness issues.
f839df0c
PE
11795 (Fset_file_times, Finsert_file_contents, auto_save_error):
11796 Rename locals to avoid shadowing.
f14b7e14 11797
5716756e 11798 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11799 (Ftry_completion, Fall_completions): Rename or remove locals
11800 to avoid shadowing.
5716756e 11801
b4c3046a
PE
11802 * marker.c (bytepos_to_charpos): Remove; unused.
11803
b45db522
PE
11804 * lisp.h (verify_bytepos, count_markers): New decls,
11805 so that gcc does not warn that these functions aren't declared.
11806
85876d07
PE
11807 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11808 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11809 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11810 (copy_text): Remove unused local var.
85876d07 11811
03d78a21 11812 * filelock.c (within_one_second): Now static.
b3dd38ab 11813 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11814
5df8f01b
PE
11815 * buffer.c (fix_overlays_before): Mark locals as initialized.
11816 (fix_start_end_in_overlays): Likewise. This function should be
11817 simplified by using pointers-to-pointers, but that's a different
11818 matter.
b1d876f1 11819 (switch_to_buffer_1): Now static.
8f54f30a
PE
11820 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11821 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11822
a70072c9 11823 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11824 Fix pointer signedness issue.
edced198
PE
11825 (sys_subshell): Mark local as volatile if checking for lint,
11826 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11827 (MAXPATHLEN): Define only if needed.
a70072c9 11828
a0977c44
PE
11829 * process.c (serial_open, serial_configure): Move decls from here ...
11830 * systty.h: ... to here, so that they can be checked.
11831
a884fdcc
PE
11832 * fns.c (get_random, seed_random): Move extern decls from here ...
11833 * lisp.h: ... to here, so that they can be checked.
11834
604efe86 11835 * sysdep.c (reset_io): Now static.
b8950c94 11836 (wait_for_termination_signal): Remove; unused.
604efe86 11837
38fc62d9
PE
11838 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11839 (copy_keymap_item, append_key, push_text_char_description):
11840 Now static.
1004a21a 11841 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11842 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11843 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11844 (describe_map_tree):
11845 Rename locals to avoid shadowing.
38fc62d9 11846
2f2650da
PE
11847 * keyboard.c: Declare functions static if they are not used elsewhere.
11848 (echo_char, echo_dash, cmd_error, top_level_2):
11849 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11850 (read_char, kbd_buffer_get_event, make_lispy_position):
11851 (make_lispy_event, make_lispy_movement, apply_modifiers):
11852 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11853 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11854 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11855 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11856 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11857
a053e86c 11858 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11859 (mark_kboards): Move decl here ...
11860 * alloc.c (mark_kboards): ... from here.
a053e86c 11861
4752793e
PE
11862 * lisp.h (force_auto_save_soon): New decl.
11863
74f10ca7 11864 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11865 (DEFINE_DUMMY_FUNCTION): New macro.
11866 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11867 Use it.
c03cd23f
PE
11868 (main): Add casts to avoid warnings
11869 if GCC considers string literals to be constants.
74f10ca7 11870
022e70d4
PE
11871 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11872
59d6fe83
PE
11873 * dbusbind.c: Pointer signedness fixes.
11874 (xd_signature, xd_append_arg, xd_initialize):
11875 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11876 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11877 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11878 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11879
78320123
PE
11880 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11881 if GCC considers string literals to be constants.
49cebcca 11882 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11883
35ac2a97
SM
118842011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11885
fb103ca9
SM
11886 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11887 (print_preprocess, print_object): New macro to fix last change.
11888
35ac2a97
SM
11889 * print.c (print_preprocess): Don't forget font objects.
11890
62973b41
JB
118912011-03-16 Juanma Barranquero <lekktu@gmail.com>
11892
11893 * emacs.c (USAGE3): Doc fixes.
11894
0e48bb22
AS
118952011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11896
11897 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11898 structure.
11899
7684e57b
JB
119002011-03-14 Juanma Barranquero <lekktu@gmail.com>
11901
11902 * lisp.h (VWindow_system, Qfile_name_history):
11903 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11904 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11905 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11906
11907 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11908 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11909
11910 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11911 * w32console.c (detect_input_pending, read_input_pending)
11912 (encode_terminal_code):
11913 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11914 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11915 (w32_system_caret_y, Qfile_name_history):
11916 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11917 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11918 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11919 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11920 * w32proc.c (Qlocal, report_file_error):
11921 * w32term.c (Vwindow_system, updating_frame):
11922 * w32uniscribe.c (initialized, uniscribe_font_driver):
11923 Remove unneeded extern declarations.
11924
2aa46d6c
CY
119252011-03-14 Chong Yidong <cyd@stupidchicken.com>
11926
c96bbc66 11927 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11928
cffc6f3b
CY
119292011-03-13 Chong Yidong <cyd@stupidchicken.com>
11930
11931 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11932 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11933 These macros can no longer be used for assignment.
11934
44f230aa
SM
11935 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11936 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11937 (record_buffer_markers, fetch_buffer_markers): New functions for
11938 recording and fetching special buffer markers.
11939 (set_buffer_internal_1, set_buffer_temp): Use them.
11940
11941 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11942
11943 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11944
11945 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11946 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11947
11948 * xdisp.c (hscroll_window_tree):
11949 (reconsider_clip_changes): Use PT instead of BUF_PT.
11950
d251f04b
EZ
119512011-03-13 Eli Zaretskii <eliz@gnu.org>
11952
11953 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11954 $(EMACS_ROOT)/lib/intprops.h.
11955
f0c77cd1
PE
119562011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11957
3eca4629
PE
11958 Fix more problems found by GCC 4.5.2's static checks.
11959
7c86ee98
PE
11960 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11961 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11962 (xg_free_frame_widgets): Make it clear that a local variable is
11963 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11964 (gdk_window_get_screen): Make it clear that this macro is needed
11965 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11966 (int_gtk_range_get_value): New function, which avoids a diagnostic
11967 from gcc -Wbad-function-cast.
11968 (xg_set_toolkit_scroll_bar_thumb): Use it.
11969 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11970 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11971 (get_utf8_string, xg_get_file_with_chooser):
11972 Rename locals to avoid shadowing.
11973 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11974
41729b81
PE
11975 * xgselect.c (xg_select): Remove unused var.
11976
f0c77cd1
PE
11977 * image.c (four_corners_best): Mark locals as initialized.
11978 (gif_load): Initialize transparent_p to zero (Bug#8238).
11979 Mark another local as initialized.
ec6cf4c6 11980 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11981
ce0ad53d 11982 * image.c (clear_image_cache): Now static.
d5d5a617 11983 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11984 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11985 (x_edge_detection): Remove unnecessary cast that
11986 gcc -Wbad-function-cast diagnoses.
2037898d 11987 (gif_load): Fix pointer signedness.
6ae141d6
PE
11988 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11989 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11990
33383987 119912011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11992
d32df629
PE
11993 Improve quality of tests for time stamp overflow.
11994 For example, without this patch (encode-time 0 0 0 1 1
11995 1152921504606846976) returns the obviously-bogus value (-948597
11996 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11997 reports time overflow. See
11998 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11999 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12000 * editfns.c: Include limits.h and intprops.h.
12001 (TIME_T_MIN, TIME_T_MAX): New macros.
12002 (time_overflow): Move earlier, to before first use.
12003 (hi_time, lo_time): New functions, for an accurate test for
12004 out-of-range times.
12005 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12006 (Fget_internal_run_time): Don't assume time_t fits in int.
12007 (make_time): Use list2 instead of Fcons twice.
12008 (Fdecode_time): More accurate test for out-of-range times.
12009 (check_tm_member): New function.
12010 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12011 (lisp_time_argument): Don't rely on undefined left-shift and
12012 right-shift behavior when checking for time stamp overflow.
8be6f318 12013
fe31d94c
PE
12014 * editfns.c (time_overflow): New function, refactoring common code.
12015 (Fformat_time_string, Fdecode_time, Fencode_time):
12016 (Fcurrent_time_string): Use it.
12017
8be6f318
PE
12018 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12019 * dired.c (make_time): Move to ...
12020 * editfns.c (make_time): ... here.
12021 * systime.h: Note the move.
12022
09d9db2c 120232011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12024
126bc0dc
YM
12025 * fringe.c (update_window_fringes): Remove unused variables.
12026
c47cbdfd
YM
12027 * unexmacosx.c (copy_data_segment): Also copy __got section.
12028 (Bug#8223)
12029
7ac80be9
EZ
120302011-03-12 Eli Zaretskii <eliz@gnu.org>
12031
c96bbc66 12032 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12033 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12034 Constify `char *' arguments and their references according to
12035 prototypes in tparam.h.
12036
ecb0f94d 12037 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12038
7ac80be9
EZ
12039 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12040 Adapt all references accordingly.
12041
12042 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12043
ef1fd07e
TT
120442011-03-11 Tom Tromey <tromey@redhat.com>
12045
12046 * buffer.c (syms_of_buffer): Remove obsolete comment.
12047
7ef4b50c
EZ
120482011-03-11 Eli Zaretskii <eliz@gnu.org>
12049
12050 * termhooks.h (encode_terminal_code): Declare prototype.
12051
12052 * msdos.c (encode_terminal_code): Don't declare prototype.
12053
12054 * term.c (encode_terminal_code): Now external again, used by
12055 w32console.c and msdos.c.
12056
44f230aa
SM
12057 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12058 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12059
4b1ec863 120602011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12061
1714f52b 12062 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12063
4b1ec863
PE
12064 * fringe.c (update_window_fringes): Mark locals as initialized
12065 (Bug#8227).
12066 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12067
524c7aa6
PE
12068 * alloc.c (mark_fringe_data): Move decl from here ...
12069 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12070 to check its interface.
12071 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12072
a5c0af81 12073 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12074 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12075 (fontset_font): Mark local as initialized.
a9a06e0b 12076 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12077
b4716021
PE
12078 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12079
811e9bac 12080 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12081 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12082 (x_own_selection, Fx_disown_selection_internal): Rename locals
12083 to avoid shadowing.
12084 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12085
7e3ab302
PE
12086 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12087 so that the caller can use some name other than gcpro1.
12088 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12089 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12090 (Fx_backspace_delete_keys_p):
12091 Use them to avoid shadowing, and rename vars to avoid shadowing.
12092 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12093 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12094 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12095 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12096 Remove unused locals.
7e3ab302
PE
12097 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12098 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12099 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12100 macros.
f78faa98 12101
e2b13473
PE
12102 * xterm.h (x_mouse_leave): New decl.
12103
77f23912
PE
12104 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12105 Remove unused functions.
cdf4ba58
PE
12106 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12107 (x_calc_absolute_position): Now static.
7411c686 12108 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12109 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12110 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12111 unless they are used.
38d0b34a
PE
12112 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12113 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12114 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12115 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12116 (x_error_catcher, x_connection_closed, x_error_handler):
12117 (x_error_quitter, xembed_send_message, x_iconify_frame):
12118 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12119 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12120 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12121
44f230aa
SM
12122 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12123 Rename or move locals to avoid shadowing.
6b463e58 12124 (tty_defined_color, merge_face_heights): Now static.
5967d051 12125 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12126 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12127 does not deduce is never used uninitialized.
73719eba
PE
12128 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12129 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12130
426994c3 12131 * terminal.c (store_terminal_param): Now static.
5489860b 12132
032f1620 12133 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12134 (set_frame_menubar): Remove unused local.
d4323972 12135 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12136 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12137 since they might point to immutable storage.
281585b0
PE
12138 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12139 since it's unused otherwise.
032f1620 12140
367c19e5 12141 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12142 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12143 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12144 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12145 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12146 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12147 does not deduce are never used uninitialized.
70739cbe 12148
07b48fa9
PE
12149 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12150
8868a238 12151 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12152 * window.c (window_loop, size_window):
12153 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12154
7e5cf297 12155 * window.c (display_buffer): Now static.
d6550a9f
PE
12156 (size_window): Mark variables that gcc -Wuninitialized
12157 does not deduce are never used uninitialized.
a586633d
PE
12158 * window.h (check_all_windows): New decl, to forestall
12159 gcc -Wmissing-prototypes diagnostic.
5b555da1 12160 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12161
f6095868
PE
12162 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12163 shadowing.
12164 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12165 Include <limits.h>.
12166 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12167 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12168 (load_charset_map): Mark variables that gcc -Wuninitialized
12169 does not deduce are never used uninitialized.
53df7c11 12170 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12171
f38b440c
PE
12172 * coding.c (coding_set_source, coding_set_destination):
12173 Use "else { /* comment */ }" rather than "else /* comment */;"
12174 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12175 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12176 a block, when the outer 'i' will do.
12177 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12178 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12179 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12180 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12181 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12182 Rename locals to avoid shadowing.
12183 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12184 * coding.c (emacs_mule_char, encode_invocation_designation):
12185 Now static, since they're not used elsewhere.
413bb2db 12186 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12187 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12188 (decode_coding_emacs_mule): Mark variables that gcc
12189 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12190 (detect_coding_iso_2022): Initialize a local variable that might
12191 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12192 this initialization is needed. (Bug#8211)
5f58e762
PE
12193 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12194 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12195 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12196 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12197 Remove unused macros.
f38b440c 12198
232b38b9 12199 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12200 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12201 * character.c (string_count_byte8): Likewise.
232b38b9 12202
fb90da1b
PE
12203 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12204 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12205
fb93dbc2
PE
12206 * chartab.c (copy_sub_char_table): Now static, since it's not used
12207 elsewhere.
5c156ace
PE
12208 (sub_char_table_ref_and_range, char_table_ref_and_range):
12209 Rename locals to avoid shadowing.
bbcd0949 12210 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12211
7d3b3862 12212 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12213 (BIDI_BOB): Remove unused macro.
7d3b3862 12214
6be7d3da
PE
12215 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12216 deduce are never used uninitialized.
c2ed9c8b 12217 * term.c (encode_terminal_code): Likewise.
6be7d3da 12218
75f8807f 12219 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12220
50938595
PE
12221 * tparam.h: New file.
12222 * term.c, tparam.h: Include it.
12223 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12224 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12225 Move these decls to tparam.h, and make them agree with what
12226 is actually in tparam.c. The previous trick of using incompatible
12227 decls in different modules does not conform to the C standard.
12228 All callers of tparam changed to use tparam's actual API.
12229 * tparam.c (tparam1, tparam, tgoto):
12230 Use const pointers where appropriate.
12231
fbceeba2
PE
12232 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12233 * cm.h (struct cm): Likewise.
12234 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12235 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12236 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12237 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12238 (turn_on_face, init_tty): Likewise.
12239 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12240
7f3f1250
PE
12241 * term.c (term_mouse_position): Rename local to avoid shadowing.
12242
e6ca6543
PE
12243 * alloc.c (mark_ttys): Move decl from here ...
12244 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12245
c40f8d15
AS
122462011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12247
12248 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12249
cfe0661d
JB
122502011-03-09 Juanma Barranquero <lekktu@gmail.com>
12251
12252 * search.c (compile_pattern_1): Remove argument regp, unused since
12253 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12254 (compile_pattern): Don't pass it.
12255
0afb4571
J
122562011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12257
12258 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12259 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12260 for ! HAVE_GTK3.
12261 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12262
12263 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12264
12265 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12266 gdk_window_get_screen, gdk_window_get_geometry,
12267 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12268 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12269 (xg_get_pixbuf_from_pixmap): New function.
12270 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12271 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12272 Call xg_get_pixbuf_from_pixmap instead of
12273 gdk_pixbuf_get_from_drawable.
12274 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12275 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12276 (xg_check_special_colors): Use GtkStyleContext and its functions
12277 for HAVE_GTK3.
12278 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12279 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12280 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12281 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12282 Call gtk_widget_get_preferred_size.
0afb4571
J
12283 (xg_frame_resized): gdk_window_get_geometry only takes 5
12284 parameters.
44f230aa
SM
12285 (xg_win_to_widget, xg_event_is_for_menubar):
12286 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12287 (xg_set_widget_bg): New function.
12288 (delete_cb): New function.
895009e1 12289 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12290 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12291 (xg_set_background_color): Call xg_set_widget_bg.
12292 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12293 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12294 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12295 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12296 if ! HAVE_GTK3.
12297 (update_frame_tool_bar): Call gtk_widget_hide.
12298 (xg_initialize): Use GDK_KEY_g.
12299
12300 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12301 if ! HAVE_GTK3
12302 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12303
12304 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12305 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12306 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12307
1c2cc4ef
JB
123082011-03-08 Juanma Barranquero <lekktu@gmail.com>
12309
12310 * w32xfns.c (select_palette): Check success of RealizePalette against
12311 GDI_ERROR, not zero.
12312
33383987 12313See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12314
12315;; Local Variables:
12316;; coding: utf-8
aac0c6e3
MR
12317;; End:
12318
2f097256 12319 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12320
12321 This file is part of GNU Emacs.
12322
12323 GNU Emacs is free software: you can redistribute it and/or modify
12324 it under the terms of the GNU General Public License as published by
12325 the Free Software Foundation, either version 3 of the License, or
12326 (at your option) any later version.
12327
12328 GNU Emacs is distributed in the hope that it will be useful,
12329 but WITHOUT ANY WARRANTY; without even the implied warranty of
12330 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12331 GNU General Public License for more details.
12332
12333 You should have received a copy of the GNU General Public License
12334 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.