* gnutls.c (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
671875da 12011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2
080e5a8d
PE
3 * gnutls.c (emacs_gnutls_handshake): Don't return a garbage value.
4 Expect the caller to check whether GNUTLS_STAGE_HANDSHAKE_CANDO <=
5 proc->gnutls_initstage, if the check is needed. The check isn't
6 needed for one caller, Fgnutls_boot.
7 (emacs_gnutls_read): Do that check. This is the other caller.
0c8c7e5c 8 (emacs_gnutls_handle_error): Remove unused local.
7754e151 9 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
080e5a8d 10
eab3844f
PE
11 lisp.h: Fix a problem with aliasing and vector headers.
12 GCC 4.6.0 optimizes based on type-based alias analysis. For
13 example, if b is of type struct buffer * and v of type struct
14 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15 != &v->size, and therefore "v->size = 1; b->size = 2; return
16 v->size;" must therefore return 1. This assumption is incorrect
17 for Emacs, since it type-puns struct Lisp_Vector * with many other
18 types. To fix this problem, this patch adds a new type struct
f904488f 19 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
20 and pseudovectors, and helps optimizing compilers not get fooled
21 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
22 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
23 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
24 the size member.
eab3844f
PE
25 (XSETPVECTYPE): Rewrite in terms of new macro.
26 (XSETPVECTYPESIZE): New macro, specifying both type and size.
27 This is a bit clearer, and further avoids the possibility of
28 undesirable aliasing.
29 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 30 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
31 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
32 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
33 (ASIZE): Now uses header.size rather than size. All
34 previous uses of XVECTOR (foo)->size replaced to use this macro,
35 to avoid the hassle of writing XVECTOR (foo)->header.size.
36 (struct vectorlike_header): New type.
eab3844f
PE
37 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
38 object, to help avoid aliasing.
39 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
40 (SUBRP): Likewise, since Lisp_Subr is a special case.
41 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
42 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
43 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 44 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
45 changed to be "header.size" and "header.next".
46 * buffer.h (struct buffer): Likewise.
47 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
48 * frame.h (struct frame): Likewise.
49 * process.h (struct Lisp_Process): Likewise.
50 * termhooks.h (struct terminal): Likewise.
51 * window.c (struct save_window_data, struct saved_window): Likewise.
52 * window.h (struct window): Likewise.
53 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
54 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
55 * buffer.c (init_buffer_once): Likewise.
56 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
57 special case.
58 * process.c (Fformat_network_address): Use local var for size,
59 for brevity.
60
0df1eac5
PE
61 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
62
452f4150
PE
63 Make the Lisp reader and string-to-float more consistent.
64 * data.c (atof): Remove decl; no longer used or needed.
65 (digit_to_number): Move to lread.c.
66 (Fstring_to_number): Use new string_to_number function, to be
67 consistent with how the Lisp reader treats infinities and NaNs.
68 Do not assume that floating-point numbers represent EMACS_INT
69 without losing information; this is not true on most 64-bit hosts.
70 Avoid double-rounding errors, by insisting on integers when
71 parsing non-base-10 numbers, as the documentation specifies.
72 * lisp.h (string_to_number): New decl, replacing ...
73 (isfloat_string): Remove.
bc0a5c13 74 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 75 (read1): Do not accept +. and -. as integers; this
452f4150
PE
76 appears to have been a coding error. Similarly, do not accept
77 strings like +-1e0 as floating point numbers. Do not report
78 overflow for integer overflows unless the base is not 10 which
79 means we have no simple and reliable way to continue.
80 Break out the floating-point parsing into a new
81 function string_to_number, so that Fstring_to_number parses
82 floating point numbers consistently with the Lisp reader.
83 (digit_to_number): Moved here from data.c. Make it static inline.
84 (E_CHAR, EXP_INT): Remove, replacing with ...
85 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
86 (string_to_number): New function, replacing isfloat_string.
87 This function checks for valid syntax and produces the resulting
88 Lisp float number too. Rework it so that string-to-number
bc0a5c13 89 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
90 so that overflow for non-base-10 numbers is reported only when
91 there's no portable and simple way to convert to floating point.
452f4150 92
67769ffc
PE
93 * textprop.c (set_text_properties_1): Rewrite for clarity,
94 and to avoid GCC warning about integer overflow.
95
c20db43f
PE
96 * intervals.h (struct interval): Use EMACS_INT for members
97 where EMACS_UINT might cause problems. See
98 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
99 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
100 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
101 All uses changed.
37aa2f85
PE
102 (offset_intervals): Tell GCC not to worry about length overflow
103 when negating a negative length.
c20db43f 104
2538aa2f
PE
105 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
106 (overrun_check_free): Likewise.
107
f2d3008d
PE
108 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
109 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
110 word size.
111
ec8df744
PE
112 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
113 (gnutls_make_error): Rename local to avoid shadowing.
114 (gnutls_emacs_global_deinit): ifdef out; not used.
115 (Fgnutls_boot): Use const for pointer to readonly storage.
116 Comment out unused local. Fix pointer signedness problems.
117
640ee02d
PE
118 * lread.c (openp): Don't stuff size_t into an 'int'.
119 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
120 about possible signed overflow.
121
6048fb2a
PE
122 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
123 (GDK_KEY_g): Don't define if already defined.
124 (xg_prepare_tooltip): Avoid pointer signedness problem.
125 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
126
fa3c87e1
PE
127 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
128 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
129
2172544b
PE
130 * xfns.c (Fx_window_property): Simplify a bit,
131 to make a bit faster and to avoid GCC 4.6.0 warning.
132 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
133
9b821a21
PE
134 * fns.c (internal_equal): Don't assume size_t fits in int.
135
3c616cfa
PE
136 * alloc.c (compact_small_strings): Tighten assertion a little.
137
c2982e87
PE
138 Replace pEd with more-general pI, and fix some printf arg casts.
139 * lisp.h (pI): New macro, generalizing old pEd macro to other
140 conversion specifiers. For example, use "...%"pI"d..." rather
141 than "...%"pEd"...".
142 (pEd): Remove. All uses replaced with similar uses of pI.
143 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
144 * alloc.c (check_pure_size): Don't overflow by converting size to int.
145 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
146 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
147 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
148 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
149 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
150 64-bit hosts.
151 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
152 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
153 * print.c (safe_debug_print, print_object): Likewise.
154 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
155 to int.
6f04d126
PE
156 Use pI instead of if-then-else-abort. Use %p to avoid casts,
157 avoiding the 0 flag, which is not portable.
c2982e87
PE
158 * process.c (Fmake_network_process): Use pI to avoid cast.
159 * region-cache.c (pp_cache): Likewise.
160 * xdisp.c (decode_mode_spec): Likewise.
161 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
162 behavior on 64-bit hosts with printf arg.
6f04d126 163 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
164 (x_stop_queuing_selection_requests): Likewise.
165 (x_get_window_property): Don't truncate byte count to an 'int'
166 when tracing.
0b432f21 167
5e073ec7
PE
168 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
169 here, since it parses constructs like leading '-' and spaces,
170 which are not wanted; and it overflows with large numbers.
171 Instead, simply match F[0-9]+, which is what is wanted anyway.
172
36372bf9
PE
173 * alloc.c: Remove unportable assumptions about struct layout.
174 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
175 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
176 (allocate_vectorlike, make_pure_vector): Use the new macros,
177 plus offsetof, to remove unportable assumptions about struct layout.
178 These assumptions hold on all porting targets that I know of, but
179 they are not guaranteed, they're easy to remove, and removing them
180 makes further changes easier.
181
0b432f21
PE
182 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
183 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
184 (string_overrun_cookie): Now const. Use initializers that
185 don't formally overflow signed char, to avoid warnings.
000098c1
PE
186 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
187 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
188 (allocate_buffer): Don't assume sizeof (struct buffer) is a
189 multiple of sizeof (EMACS_INT); it need not be, if
190 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 191 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 192
f2d3ba6f
DN
1932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
194
195 * alloc.c (check_sblock, check_string_bytes)
196 (check_string_free_list): Convert to standard C.
197
42ce4c63
TZ
1982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
199
200 * w32.c (emacs_gnutls_push): Fix typo.
201
825cd63c
EZ
2022011-04-25 Eli Zaretskii <eliz@gnu.org>
203
fb11d64d
EZ
204 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
205 "cast to pointer from integer of different size".
206
825cd63c
EZ
207 Improve doprnt and its use in verror. (Bug#8545)
208 * doprnt.c (doprnt): Document the set of format control sequences
209 supported by the function. Use SAFE_ALLOCA instead of always
210 using `alloca'.
211
212 * eval.c (verror): Don't limit the buffer size at size_max-1, that
213 is one byte too soon. Don't use xrealloc; instead xfree and
214 xmalloc anew.
215
e061a11b
TZ
2162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
217
218 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
219 callbacks stage.
220
221 * gnutls.c: Renamed global_initialized to
222 gnutls_global_initialized. Added internals for the
223 :verify-hostname-error, :verify-error, and :verify-flags
224 parameters of `gnutls-boot' and documented those parameters in the
225 docstring. Start callback support.
226 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
227 unless a fatal error occured. Call gnutls_alert_send_appropriate
228 on error. Return error code.
229 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
230 (emacs_gnutls_read): Likewise.
231 (Fgnutls_boot): Return handshake error code.
232 (emacs_gnutls_handle_error): New function.
233 (wsaerror_to_errno): Likewise.
234
235 * w32.h (emacs_gnutls_pull): Add prototype.
236 (emacs_gnutls_push): Likewise.
237
238 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
239 (emacs_gnutls_push): Likewise.
240
2412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
242
243 * process.c (wait_reading_process_output): Check if GnuTLS
244 buffered some data internally if no FDs are set for TLS
245 connections.
246
247 * makefile.w32-in (OBJ2): Add gnutls.$(O).
248 (LIBS): Link to USER_LIBS.
249 ($(BLD)/gnutls.$(0)): New target.
250
fa6996bc
EZ
2512011-04-24 Eli Zaretskii <eliz@gnu.org>
252
eb35682e
EZ
253 * xdisp.c (handle_single_display_spec): Rename the
254 display_replaced_before_p argument into display_replaced_p, to
255 make it consistent with the commentary. Fix typos in the
256 commentary.
257
e2ad650c
EZ
258 * textprop.c (syms_of_textprop): Remove dead code.
259 (copy_text_properties): Delete obsolete commentary about an
260 interface that was deleted long ago. Fix typos in the description
261 of arguments.
262
1b2de274
EZ
263 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
264 to changes in oldXMenu/XMenu.h from 2011-04-16.
265 <menu_help_message, prev_menu_help_message>: Constify.
266 (IT_menu_make_room): menu->help_text is now `const char **';
267 adjust.
268
269 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
270 to changes in oldXMenu/XMenu.h from 2011-04-16.
271 (struct XMenu): Declare `help_text' `const char **'.
272
273 * xfaces.c <Qunspecified>: Make extern again.
274
275 * syntax.c: Include sys/types.h before including regex.h, as
276 required by Posix.
277
762b15be
EZ
278 * doc.c (get_doc_string): Improve the format passed to `error'.
279
280 * doprnt.c (doprnt): Improve commentary.
281
282 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
283
284 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
285 them with etags.
286
f1052e5d
EZ
287 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
288 changes in globals.h immediately force recompilation.
762b15be
EZ
289 (TAGS): Depend on $(CURDIR)/m/intel386.h and
290 $(CURDIR)/s/ms-w32.h.
291 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 292
fa6996bc
EZ
293 * character.c (Fchar_direction): Function deleted.
294 (syms_of_character): Don't defsubr it.
295 <char-direction-table>: Deleted.
296
e6c3da20
EZ
2972011-04-23 Eli Zaretskii <eliz@gnu.org>
298
299 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
300 * doprnt.c: Include limits.h.
301 (SIZE_MAX): New macro.
302 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
303 local variables are now size_t instead of int or unsigned.
304 Improve overflow protection. Support `l' modifier for integer
305 conversions. Support %l conversion. Don't assume an EMACS_INT
306 argument for integer conversions and for %c.
307
308 * lisp.h (doprnt): Restore prototype.
309
310 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
311 $(SRC)/character.h.
312
313 * Makefile.in (base_obj): Add back doprnt.o.
314
315 * deps.mk (doprnt.o): Add back prerequisites.
316 (callint.o): Depend on character.h.
317
318 * eval.c (internal_lisp_condition_case): Include the handler
319 representation in the error message.
320 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
321 when breaking from the loop.
322
323 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
324
325 * callint.c (Fcall_interactively): When displaying error message
326 about invalid control letter, pass the character's codepoint, not
327 a pointer to its multibyte form. Improve display of the character
328 in octal and display also its hex code.
329
330 * character.c (char_string): Use %x to display the (unsigned)
331 codepoint of an invalid character, to avoid displaying a bogus
332 negative value.
333
334 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
335 `error', not SYMBOL_NAME itself.
336
337 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
338 character arguments to `error'.
339
340 * charset.c (check_iso_charset_parameter): Fix incorrect argument
341 to `error' in error message about FINAL_CHAR argument. Make sure
342 FINAL_CHAR is a character, and use %c when it is passed as
343 argument to `error'.
344
4ffd0d6b 3452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
346
347 * s/ms-w32.h (localtime): Redirect to sys_localtime.
348
349 * w32.c: Include <time.h>.
350 (sys_localtime): New function.
351
4ffd0d6b 3522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
353
354 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
355
4ffd0d6b 356 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 357
4ffd0d6b 3582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 359
4ffd0d6b
GM
360 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
361 zombies (Bug#8467).
aac0c6e3 362
04c56954
EZ
3632011-04-19 Eli Zaretskii <eliz@gnu.org>
364
365 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
366 gl_state.e_property when gl_state.object is Qt.
367
368 * insdel.c (make_gap_larger): Remove limitation of buffer size
369 to <= INT_MAX.
370
16a43933
CY
3712011-04-18 Chong Yidong <cyd@stupidchicken.com>
372
373 * xdisp.c (lookup_glyphless_char_display)
374 (produce_glyphless_glyph): Handle cons cell entry in
375 glyphless-char-display.
376 (Vglyphless_char_display): Document it.
377
378 * term.c (produce_glyphless_glyph): Handle cons cell entry in
379 glyphless-char-display.
380
4581706e
CY
3812011-04-17 Chong Yidong <cyd@stupidchicken.com>
382
383 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
384
385 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
386
387 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
388 definition for no-X builds.
389
4887c6e2 3902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 391
fd35b6f9
PE
392 Static checks with GCC 4.6.0 and non-default toolkits.
393
5c1ccb01
PE
394 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
395
006c5daa
PE
396 * process.c (keyboard_bit_set): Define only if SIGIO.
397 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
398 (send_process): Repair possible setjmp clobbering.
399
efc736d3
PE
400 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
401
4e2fe2e6
PE
402 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
403
f97334a2
PE
404 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
405
4e75f29d
PE
406 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
407 Define only if needed.
408
90efadd1
PE
409 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
410 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 411 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 412
3c647824
PE
413 * dispextern.h (struct redisplay_interface): Rename param
414 to avoid shadowing.
e264f262 415 * termhooks.h (struct terminal): Likewise.
761383f4 416 * xterm.c (xembed_send_message): Likewise.
3c647824 417
b58c5c4a
PE
418 * insdel.c (make_gap_smaller): Define only if
419 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
420
cad59032
PE
421 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
422 it.
423
c339dc2e
PE
424 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
425 so that we aren't warned about unused symbols.
426
91a3e27b
PE
427 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
428
399c71d3 429 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 430
8ffc96f5
PE
431 * xfns.c (x_real_positions): Mark locals as initialized.
432
eef9bc79
PE
433 * xmenu.c (xmenu_show): Don't use uninitialized vars.
434
098db9dd
PE
435 * xterm.c: Fix problems found by static analysis with other toolkits.
436 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
437 (x_dispatch_event): Declare static if USE_GTK, and
438 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 439 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 440 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
441 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
442 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
443
eb18f6cc
PE
444 * xmenu.c (menu_help_callback): Pointer type fixes.
445 Use const pointers when pointing at readonly data. Avoid pointer
446 signedness clashes.
447 (FALSE): Remove unused macro.
448 (update_frame_menubar): Remove unused decl.
449
1fe72bf8
PE
450 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
451
60d9e1db
PE
452 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
453 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
454 (single_menu_item): Rename local to avoid shadowing.
455
39261c26
PE
456 * keyboard.c (make_lispy_event): Remove unused local var.
457
018c5e19
PE
458 * frame.c, frame.h (x_get_resource_string): Bring this back, but
459 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
460
63d2b86e
PE
461 * bitmaps: Change bitmaps from unsigned char back to the X11
462 compatible char. Avoid the old compiler warnings about
463 out-of-range initializers by using, for example, '\xab' rather
464 than 0xab.
465
aefd87e1
PE
466 * xgselect.c (xgselect_initialize): Check vs interface
467 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
468
bf501fb9
PE
469 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
470
e9829fdf
PE
471 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
472 to read-only memory.
473
1086c095
PE
474 * fns.c (vector): Remove; this old hack is no longer needed.
475
2baccd04 476 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 477 Remove unused var.
dde42981 478 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 479
72391843 480 * xrdb.c (x_load_resources): Omit unused local.
3565b346 481
436c16df 482 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 483 (x_window): Rename locals to avoid shadowing.
dc5ddd85 484 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 485
92bb796d 486 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 487 (x_term_init): Remove local to avoid shadowing.
92bb796d 488
764430a3 489 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
490
491 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
492 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
493
d1dfb56c
EZ
4942011-04-16 Eli Zaretskii <eliz@gnu.org>
495
c4354cb4
EZ
496 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
497
d1dfb56c
EZ
498 Fix regex.c, syntax.c and friends for buffers > 2GB.
499 * syntax.h (struct gl_state_s): Declare character position members
500 EMACS_INT.
501
502 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
503
504 * textprop.c (verify_interval_modification, interval_of): Declare
505 arguments EMACS_INT.
506
507 * intervals.c (adjust_intervals_for_insertion): Declare arguments
508 EMACS_INT.
509
510 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
511
512 * indent.c (Fvertical_motion): Local variable it_start is now
513 EMACS_INT.
514
515 * regex.c (re_match, re_match_2, re_match_2_internal)
516 (bcmp_translate, regcomp, regexec, print_double_string)
517 (group_in_compile_stack, re_search, re_search_2, regex_compile)
518 (re_compile_pattern, re_exec): Declare arguments and local
519 variables `size_t' and `ssize_t' and return values `regoff_t', as
520 appropriate.
521 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
522 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
523 <compile_stack_type>: `size' and `avail' are now `size_t'.
524
525 * regex.h <regoff_t>: Use ssize_t, not int.
526 (re_search, re_search_2, re_match, re_match_2): Arguments that
527 specify buffer/string position and length are now ssize_t and
528 size_t. Return type is regoff_t.
529
613052cd
BK
5302011-04-16 Ben Key <bkey76@gmail.com>
531
532 * nsfont.m: Fixed bugs in ns_get_family and
533 ns_descriptor_to_entity that were caused by using free to
534 deallocate memory blocks that were allocated by xmalloc (via
535 xstrdup). This caused Emacs to crash when compiled with
536 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
537 --enable-checking=xmallocoverrun). xfree is now used to
538 deallocate these memory blocks.
539
4170f62f 5402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 541
71b41406
PE
542 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
543
9587a89d
PE
544 emacs_write: Accept and return EMACS_INT for sizes.
545 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
546 et seq.
547 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
548 Accept and return EMACS_INT.
549 (emacs_gnutls_write): Return the number of bytes written on
550 partial writes.
551 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
552 (emacs_read, emacs_write): Remove check for negative size, as the
553 Emacs source code has been audited now.
9587a89d
PE
554 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
555 (emacs_read, emacs_write): Use it.
273a5f82
PE
556 * process.c (send_process): Adjust to the new signatures of
557 emacs_write and emacs_gnutls_write. Do not attempt to store
558 a byte offset into an 'int'; it might overflow.
9587a89d 559 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 560
3e047f51
PE
561 * sound.c: Don't assume sizes fit in 'int'.
562 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 563 Return EMACS_INT, not int.
3e047f51 564 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
565 Accept EMACS_INT, not int.
566 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
567 record read return values.
568
cc39a9db
BK
5692011-04-15 Ben Key <bkey76@gmail.com>
570
c9d0ec6d
JB
571 * keyboard.c (Qundefined): Don't declare static since it is used
572 in nsfns.m.
573 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
574 static since they are used in nsfont.m.
cc39a9db 575
6c60eb9f
SM
5762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
577
578 * process.c (Qprocessp): Don't declare static.
579 * lisp.h (Qprocessp): Declare again.
580
7990b61a
JB
5812011-04-15 Juanma Barranquero <lekktu@gmail.com>
582
583 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
584
5d4cb038
PE
5852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
586
8bd7b830 587 Improve C-level modularity by making more things 'static'.
cd64ea1d 588
e3b27b31
PE
589 Don't publish debugger-only interfaces to other modules.
590 * lisp.h (safe_debug_print, debug_output_compilation_hack):
591 (verify_bytepos, count_markers): Move decls to the only modules
592 that need them.
593 * region-cache.h (pp_cache): Likewise.
594 * window.h (check_all_windows): Likewise.
595 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
596
5d4cb038
PE
597 * sysdep.c (croak): Now static, if
598 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
599 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
600
601 * alloc.c (refill_memory_reserve): Now static if
602 !defined REL_ALLOC || defined SYSTEM_MALLOC.
603 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 604
e87b6180
PE
605 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
606 Define only if USE_LUCID.
607
ac64929e
PE
608 * xrdb.c (x_customization_string, x_rm_string): Now static.
609
6f37259d
PE
610 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
611 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
612
1683e3ab
PE
613 * xdisp.c (draw_row_with_mouse_face): Now static.
614 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
615
de9c2632
PE
616 * window.h (check_all_windows): Mark externally visible.
617
2b96acb7
PE
618 * window.c (window_deletion_count): Now static.
619
620 * undo.c: Make symbols static if they're not exported.
621 (last_undo_buffer, last_boundary_position, pending_boundary):
622 Now static.
623
50436f33
PE
624 * textprop.c (interval_insert_behind_hooks): Now static.
625 (interval_insert_in_front_hooks): Likewise.
626
64520e5c
PE
627 * term.c: Make symbols static if they're not exported.
628 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
629 (max_frame_lines, tty_set_terminal_modes):
630 (tty_reset_terminal_modes, tty_turn_off_highlight):
631 (get_tty_terminal): Now static.
632 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
633 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 634 HAVE_WINDOW_SYSTEM.
64520e5c
PE
635 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
636 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
637
1fa53021
PE
638 * sysdep.c: Make symbols static if they're not exported.
639 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
640 Now static.
641 (sigprocmask_set, full_mask): Remove; unused.
642 (wait_debugging): Mark as visible.
643 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
644 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
645
d4b43b22
PE
646 * syntax.c (syntax_temp): Define only if !__GNUC__.
647
b7c513d0
PE
648 * sound.c (current_sound_device, current_sound): Now static.
649
989b29ad
PE
650 * search.c (searchbufs, searchbuf_head): Now static.
651
13a55a78
PE
652 * scroll.c (scroll_cost): Remove; unused.
653 * dispextern.h (scroll_cost): Remove decl.
654
de68a1fc
PE
655 * region-cache.h (pp_cache): Mark as externally visible.
656
40ccffa6
PE
657 * process.c: Make symbols static if they're not exported.
658 (process_tick, update_tick, create_process, chan_process):
659 (Vprocess_alist, proc_buffered_char, datagram_access):
660 (fd_callback_data, send_process_frame, process_sent_to): Now static.
661 (deactivate_process): Mark defn as static, as well as decl.
662 * lisp.h (create_process): Remove decl.
663 * process.h (chan_process, Vprocess_alist): Remove decls.
664
ad64fc97
PE
665 * print.c: Make symbols static if they're not exported.
666 (print_depth, new_backquote_output, being_printed, print_buffer):
667 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
668 (print_interval, print_number_index, initial_stderr_stream):
669 Now static.
670 * lisp.h (Fprinc): Remove decl.
671 (debug_output_compilation_hack): Mark as externally visible.
672
adddb265
PE
673 * sysdep.c (croak): Move decl from here to syssignal.h.
674 * syssignal.h (croak): Put it here, so the API can be checked when
675 'croak' is called from dissociate_if_controlling_tty.
676
1717ede2
PE
677 * minibuf.c: Make symbols static if they're not exported.
678 (minibuf_save_list, choose_minibuf_frame): Now static.
679 * lisp.h (choose_minibuf_frame): Remove decl.
680
fa5fb2bc
PE
681 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
682
1e3890d1
PE
683 * lread.c: Make symbols static if they're not exported.
684 (read_objects, initial_obarray, oblookup_last_bucket_number):
685 Now static.
686 (make_symbol): Remove; unused.
687 * lisp.h (initial_obarray, make_symbol): Remove decls.
688
8a1414fa
PE
689 * keyboard.c: Make symbols static if they're not exported.
690 (single_kboard, recent_keys_index, total_keys, recent_keys):
691 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
692 (this_single_command_key_start, echoing, last_auto_save):
693 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
694 (command_loop, echo_now, keyboard_init_hook, help_char_p):
695 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
696 (Vlispy_mouse_stem, double_click_count):
697 Now static.
698 (force_auto_save_soon): Define only if SIGDANGER.
699 (ignore_mouse_drag_p): Now static if
700 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
701 (print_help): Remove; unused.
702 (stop_character, last_timer_event): Mark as externally visible.
703 * keyboard.h (ignore_mouse_drag_p): Declare only if
704 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
705 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
706 * lisp.h (echoing): Remove decl.
707 (force_auto_save_soon): Declare only if SIGDANGER.
708 * xdisp.c (redisplay_window): Simplify code, to make it more
709 obvious that ignore_mouse_drag_p is not accessed if !defined
710 USE_GTK && !defined HAVE_NS.
711
93ea6e8f
PE
712 * intervals.c: Make symbols static if they're not exported.
713 (merge_properties_sticky, merge_interval_right, delete_interval):
714 Now static.
715 * intervals.h (merge_interval_right, delete_interval): Remove decls.
716
77382fcc
PE
717 * insdel.c: Make symbols static if they're not exported.
718 However, leave prepare_to_modify_buffer alone. It's never
719 called from outside this function, but that appears to be a bug.
720 (combine_after_change_list, combine_after_change_buffer):
4889fc82 721 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
722 (adjust_after_replace_noundo): Remove; unused.
723 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 724 (signal_before_change): Remove decls.
77382fcc 725
9306c32e
PE
726 * indent.c (val_compute_motion, val_vmotion): Now static.
727
cd44d2eb
PE
728 * image.c: Make symbols static if they're not exported.
729 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
730 if USE_GTK.
731 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
732 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
733
ad9a7a06
PE
734 * fringe.c (standard_bitmaps): Now static.
735 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
736
81626931
PE
737 * frame.c: Make symbols static if they're not exported.
738 (x_report_frame_params, make_terminal_frame): Now static.
739 (get_frame_param): Now static, unless HAVE_NS.
740 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
741 (x_get_resource_string): Remove; not used.
742 * frame.h (make_terminal_frame, x_report_frame_params):
743 (x_get_resource_string); Remove decls.
744 (x_fullscreen_adjust): Declare only if WINDOWSNT.
745 * lisp.h (get_frame_param): Declare only if HAVE_NS.
746
239f9db9
PE
747 * font.c, fontset.c: Make symbols static if they're not exported.
748 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
749 (FACE_SUITABLE_FOR_CHAR_P): Use it.
750 * font.c (font_close_object): Now static.
751 * font.h (font_close_object): Remove.
752 * fontset.c (FONTSET_OBJLIST): Remove.
753 (free_realized_fontset) #if-0 the body, which does nothing.
754 (face_suitable_for_char_p): #if-0, as it's never called.
755 * fontset.h (face_suitable_for_char_p): Remove decl.
756 * xfaces.c (face_at_string_position): Use
757 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
758 since 0 is always ASCII.
759
dfcf3579
PE
760 * fns.c (weak_hash_tables): Now static.
761
5045092b
PE
762 * fileio.c: Make symbols static if they're not exported.
763 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
764 (Vwrite_region_annotation_buffers): Now static.
765
57a96f5c
PE
766 * eval.c: Make symbols static if they're not exported.
767 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
768 * lisp.h (backtrace_list): Remove decl.
769
35f08c38
PE
770 * emacs.c: Make symbols static if they're not exported.
771 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
772 (fatal_error_code, fatal_error_signal_hook, standard_args):
773 Now static.
774 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
775 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
776 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
777 * lisp.h (fatal_error_signal_hook): Remove decl.
778 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
779
f44bd759
PE
780 * editfns.c: Move a (normally-unused) function to its only use.
781 * editfns.c, lisp.h (get_operating_system_release): Remove.
782 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
783 worth the hassle of breaking this out.
784
b532497d
PE
785 * xterm.c: Make symbols static if they're not exported.
786 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
787 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
788 (x_destroy_window, x_delete_display):
789 Now static.
790 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
791 (x_mouse_leave): Remove; unused.
792 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
793 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
794 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
795 Remove decls.
796 (x_mouse_leave): Declare only if WINDOWSNT.
797 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
798 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
799 USE_X_TOOLKIT.
800
1675728f
PE
801 * ftxfont.c: Make symbols static if they're not exported.
802 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
803 HAVE_FREETYPE.
804 * font.h (ftxfont_driver): Likewise.
805
e4cebfca
PE
806 * xfns.c: Make symbols static if they're not exported.
807 (x_last_font_name, x_display_info_for_name):
808 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
809 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
810 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
811 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
812 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
813 (last_show_tip_args): Now static.
814 (xic_defaut_fontset, xic_create_fontsetname): Define only if
815 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
816 (x_screen_planes): Remove; unused.
817 * dispextern.h (x_screen_planes): Remove decl.
818
5bf46f05
PE
819 * dispnew.c: Make symbols static if they're not exported.
820 * dispextern.h (redraw_garbaged_frames, scrolling):
821 (increment_row_positions): Remove.
822 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
823 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
824 Now static.
825 (redraw_garbaged_frames): Remove; unused.
826
435f4c28
PE
827 * xfaces.c: Make symbols static if they're not exported.
828 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
829 Remove decls.
830 * xterm.h (defined_color): Remove decls.
831 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
832 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
833 (menu_face_changed_default, defined_color, free_realized_face):
834 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
835 (ascii_face_of_lisp_face): Remove; unused.
836
8524aef3
PE
837 * xdisp.c: Make symbols static if they're not exported.
838 * dispextern.h (scratch_glyph_row, window_box_edges):
839 (glyph_to_pixel_coords, set_cursor_from_row):
840 (get_next_display_element, set_iterator_to_next):
841 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
842 (show_mouse_face): Remove decls
843 * frame.h (message_buf_print): Likewise.
844 * lisp.h (pop_message, set_message, check_point_in_composition):
845 Likewise.
846 * xterm.h (set_vertical_scroll_bar): Likewise.
847 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
848 (message_buf_print, scratch_glyph_row, displayed_buffer):
849 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
850 (get_next_display_element, show_mouse_face, window_box_edges):
851 (frame_to_window_pixel_xy, check_point_in_composition):
852 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
853 (glyph_to_pixel_coords): Remove; unused.
854
16390cd2
PE
855 * dired.c (file_name_completion): Now static.
856
857 * dbusbind.c (xd_in_read_queued_messages): Now static.
858
a25f4dfa
PE
859 * lisp.h (circular_list_error, FOREACH): Remove; unused.
860 * data.c (circular_list_error): Remove.
861
14a9c8df
PE
862 * commands.h (last_point_position, last_point_position_buffer):
863 (last_point_position_window): Remove decls.
864 * keyboard.c: Make these variables static.
865
74ab6df5
PE
866 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
867 decls.
868 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
869 (iso_code_class, detect_coding, code_convert_region): Now static.
870 (encode_coding_gap): Remove; unused.
871
38dfbee1
PE
872 * chartab.c (chartab_chars, chartab_bits): Now static.
873
a2cb4e63
PE
874 * charset.h (charset_iso_8859_1): Remove decl.
875 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
876 Now static.
877
127198fd
PE
878 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
879 * ccl.c (Vccl_program_table): Now static.
880 (check_ccl_update): Remove; unused.
881
d85b608f
PE
882 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
883 * category.h: ... from here.
884 * category.c (check_category_table, set_category_set): Now static.
885
31cd66f3
PE
886 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
887 * lisp.h: Remove these decls.
888
c358e587
PE
889 * buffer.c (buffer_count): Remove unused var.
890
e78aecca
PE
891 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
892 so that it's not optimized away.
893 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
894 * dispextern.h (bidi_dump_cached_states): Remove, since it's
895 exported only to the debugger.
896
e192d7d3
PE
897 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
898 * atimer.h (run_all_atimers): Removed; not exported.
899
92470028
PE
900 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
901 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
902 was inaccessible from Lisp.
903 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
904 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
905
244ed907
PE
906 alloc.c: Import and export fewer symbols, and remove unused items.
907 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
908 is defined.
909 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
910 it's not optimized away by whole-program optimization.
911 (message_enable_multibyte, free_misc): Remove.
912 (catchlist, handlerlist, mark_backtrace):
913 Declare only if BYTE_MARK_STACK.
914 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
915 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
916 (message_enable_multibyte): Remove decl.
917 (free_misc, interval_free_list, float_block, float_block_index):
918 (n_float_blocks, float_free_list, cons_block, cons_block_index):
919 (cons_free_list, last_marked_index):
920 Now static.
921 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
922 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
923 (mark_backtrace): Define only if BYTE_MARK_STACK.
924 * xdisp.c (message_enable_multibyte): Now static.
925
61c2b50e 926 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
927 This makes it easier for human readers (and static analyzers)
928 to see whether these variables are used from other modules.
929 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
930 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
931 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
932 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
933 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
934 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
935 * xmenu.c, xselect.c:
936 Declare Q* vars static if they are not used in other modules.
937 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
938 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
939 Remove decls of unexported vars.
940 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
941
95c82688
PE
942 * lisp.h (DEFINE_FUNC): Make sname 'static'.
943
16a97296
PE
944 Make Emacs functions such as Fatom 'static' by default.
945 This makes it easier for human readers (and static analyzers)
946 to see whether these functions can be called from other modules.
947 DEFUN now defines a static function. To make the function external
948 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
949 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
950 (Finit_image_library):
16a97296
PE
951 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
952 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
953 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
954 Remove decls, since these functions are now static.
955 (Funintern, Fget_internal_run_time): New decls, since these functions
956 were already external.
95c82688 957
16a97296
PE
958 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
959 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
960 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
961 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
962 * keyboard.c, keymap.c, lread.c:
963 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
964 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
965 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
966 Mark functions with DEFUE instead of DEFUN,
967 if they are used in other modules.
968 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
969 decls for now-static functions.
970 * buffer.h (Fdelete_overlay): Remove decl.
971 * callproc.c (Fgetenv_internal): Mark as internal.
972 * composite.c (Fremove_list_of_text_properties): Remove decl.
973 (Fcomposition_get_gstring): New forward static decl.
974 * composite.h (Fcomposite_get_gstring): Remove decl.
975 * dired.c (Ffile_attributes): New forward static decl.
976 * doc.c (Fdocumntation_property): New forward static decl.
977 * eval.c (Ffetch_bytecode): New forward static decl.
978 (Funintern): Remove extern decl; now in .h file where it belongs.
979 * fileio.c (Fmake_symbolic_link): New forward static decl.
980 * image.c (Finit_image_library): New forward static decl.
981 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
982 * intervals.h (Fprevious_property_change):
983 (Fremove_list_of_text_properties): Remove decls.
984 * keyboard.c (Fthis_command_keys): Remove decl.
985 (Fcommand_execute): New forward static decl.
986 * keymap.c (Flookup_key): New forward static decl.
987 (Fcopy_keymap): Now static.
988 * keymap.h (Flookup_key): Remove decl.
989 * process.c (Fget_process): New forward static decl.
990 (Fprocess_datagram_address): Mark as internal.
991 * syntax.c (Fsyntax_table_p): New forward static decl.
992 (skip_chars): Remove duplicate decl.
993 * textprop.c (Fprevious_property_change): New forward static decl.
994 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
995 Now internal.
996 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
997 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
998
785bbd42
PE
999 * editfns.c (Fformat): Remove unreachable code.
1000
8b913b57
AS
10012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1002
1003 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1004 change. (Bug#8496)
1005
a6744a35
EZ
10062011-04-13 Eli Zaretskii <eliz@gnu.org>
1007
1008 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1009 when at ZV. (Bug#8487)
1010
e7974947
AS
10112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1012
baad03f0
AS
1013 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1014 (Bug#8437)
1015 * keyboard.c (parse_tool_bar_item): Likewise.
1016 * sound.c (sound_cleanup, alsa_close): Likewise.
1017 * termcap.c (tgetent): Likewise.
1018 * xfns.c (x_default_font_parameter): Likewise.
1019 * xsettings.c (read_and_apply_settings): Likewise.
1020
e7974947
AS
1021 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1022 (overrun_check_free): Protoize.
1023
28272684
PE
10242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1027 since callers should never pass a negative size.
1028 Change the signature to match that of plain 'read' and 'write'; see
1029 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1030 * lisp.h: Update prototypes of emacs_write and emacs_read.
1031
11997c76
EZ
10322011-04-11 Eli Zaretskii <eliz@gnu.org>
1033
1034 * xdisp.c (redisplay_window): Don't try to determine the character
1035 position of the scroll margin if the window start point w->startp
e896f03c 1036 is outside the buffer's accessible region. (Bug#8468)
11997c76 1037
8a2cbd72
EZ
10382011-04-10 Eli Zaretskii <eliz@gnu.org>
1039
1040 Fix write-region and its subroutines for buffers > 2GB.
1041 * fileio.c (a_write, e_write): Modify declaration of arguments and
1042 local variables to support buffers larger than 2GB.
1043 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1044
1045 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1046 argument, local variables, and return value.
1047
1048 * lisp.h: Update prototypes of emacs_write and emacs_read.
1049
1050 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1051
4073e537 10522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1053
1ebfdcb6
PE
1054 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1055
b2ded58d
PE
1056 Fix more problems found by GCC 4.6.0's static checks.
1057
7d66342c
PE
1058 * xdisp.c (vmessage): Use a better test for character truncation.
1059
bbf47d44
PE
1060 * charset.c (load_charset_map): <, not <=, for optimization,
1061 and to avoid potential problems with integer overflow.
9248994d 1062 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1063 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1064 * editfns.c (Fformat): Likewise.
1e69125e 1065 * syntax.c (skip_chars): Likewise.
3befa583 1066
e3019616
PE
1067 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1068 This also lets GCC 4.6.0 generate slightly better loop code.
1069
becfa255
PE
1070 * callint.c (Fcall_interactively): <, not <=, for optimization.
1071 (Fcall_interactively): Count the number of arguments produced,
1072 not the number of arguments given. This is simpler and lets GCC
1073 4.6.0 generate slightly better code.
1074
dae0cd48
PE
1075 * ftfont.c: Distingish more carefully between FcChar8 and char.
1076 The previous code passed unsigned char * to a functions like
1077 strlen and xstrcasecmp that expect char *, which does not
1078 conform to the C standard.
1079 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1080 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1081 char * when the C standard requires it.
1082
76032d70
PE
1083 * keyboard.c (read_char): Remove unused var.
1084
eb3f1cc8
PE
1085 * eval.c: Port to Windows vsnprintf (Bug#8435).
1086 Include <limits.h>.
1087 (SIZE_MAX): Define if the headers do not.
1088 (verror): Do not give up if vsnprintf returns a negative count.
1089 Instead, grow the buffer. This ports to Windows vsnprintf, which
1090 does not conform to C99. Problem reported by Eli Zaretskii.
1091 Also, simplify the allocation scheme, by avoiding the need for
1092 calling realloc, and removing the ALLOCATED variable.
1093
70476b54
PE
1094 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1095
12020a9e
PE
1096 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1097 But keep the doprint source code for now, as we might revamp it
1098 and use it again (Bug#8435).
ea6c7ae6
PE
1099 * lisp.h (doprnt): Remove.
1100 * Makefile.in (base_obj): Remove doprnt.o.
1101 * deps.mk (doprnt.o): Remove.
1102
5fdb398c
PE
1103 error: Print 32- and 64-bit integers portably (Bug#8435).
1104 Without this change, on typical 64-bit hosts error ("...%d...", N)
1105 was used to print both 32- and 64-bit integers N, which relied on
1106 undefined behavior.
1107 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1108 New macro.
1109 * lisp.h (error, verror): Mark as printf-like functions.
1110 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1111 Report overflow in size calculations when allocating printf buffer.
1112 Do not truncate output string at its first null byte.
1113 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1114 Truncate the output at a character boundary, since vsnprintf does not
1115 do that.
1116 * charset.c (check_iso_charset_parameter): Convert internal
1117 character to string before calling 'error', since %c now has the
1118 printf meaning.
1119 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1120 overflow when computing char to be passed to 'error'. Do not
1121 pass Lisp_Object to 'error'; pass the integer instead.
1122 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1123 formatted with plain %d.
1124
b189fa66
PE
1125 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1126
bff87ef0
PE
1127 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1128
7e2cac20
PE
1129 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1130
ce4d90b5
PE
1131 * xterm.c (x_catch_errors): Remove duplicate declaration.
1132
266c9547
PE
1133 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1134
79c49ad2
PE
1135 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1136
368f4090
JM
11372011-04-10 Jim Meyering <meyering@redhat.com>
1138
1139 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1140 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1141 return ssize_t not "int", and use size_t as the buffer length.
1142 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1143 * gnutls.h: Update declarations.
1144 * process.c (read_process_output): Use ssize_t, to match.
1145 (send_process): Likewise.
1146
a32d4040
CY
11472011-04-09 Chong Yidong <cyd@stupidchicken.com>
1148
1149 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1150
8546720e 11512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1152
8546720e
GM
1153 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1154 unsigned char, to match FcChar8 type definition.
aac0c6e3 1155
8546720e
GM
1156 * xterm.c (handle_one_xevent):
1157 * xmenu.c (create_and_show_popup_menu):
1158 * xselect.c (x_decline_selection_request)
1159 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1160
0a2f5c1a 11612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1162
1163 Fix some uses of `int' instead of EMACS_INT.
1164 * search.c (string_match_1, fast_string_match)
1165 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1166 (scan_buffer, find_next_newline_no_quit)
1167 (find_before_next_newline, search_command, Freplace_match)
1168 (Fmatch_data): Make some `int' variables be EMACS_INT.
1169
1170 * xdisp.c (display_count_lines): 3rd argument and return value now
1171 EMACS_INT. All callers changed.
1172 (pint2hrstr): Last argument is now EMACS_INT.
1173
1174 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1175 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1176 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1177 (decode_coding_utf_16, decode_coding_emacs_mule)
1178 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1179 (decode_coding_ccl, decode_coding_charset)
1180 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1181 (decode_coding_iso_2022, decode_coding_emacs_mule)
1182 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1183 <char_offset, last_offset>: Declare EMACS_INT.
1184 (encode_coding_utf_8, encode_coding_utf_16)
1185 (encode_coding_emacs_mule, encode_invocation_designation)
1186 (encode_designation_at_bol, encode_coding_iso_2022)
1187 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1188 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1189 Declare EMACS_INT.
1190 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1191 (encode_invocation_designation): Last argument P_NCHARS is now
1192 EMACS_INT.
1193 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1194 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1195
1196 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1197 All users changed.
1198
1199 * ccl.c (Fccl_execute_on_string): Declare some variables
1200 EMACS_INT.
1201
8546720e 12022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1203
1204 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1205
4e19a977
CS
12062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1207
1208 * process.c (Fformat_network_address): Doc fix.
1209
87302331
R
12102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1211
1212 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1213
cbb59342
CY
12142011-04-08 Chong Yidong <cyd@stupidchicken.com>
1215
1216 * keyboard.c (read_char): Call Lisp function help-form-show,
1217 instead of using internal_with_output_to_temp_buffer.
1218 (Qhelp_form_show): New var.
e0d38eeb 1219 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1220
1221 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1222
1223 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1224
e67a13ab
CY
12252011-04-06 Chong Yidong <cyd@stupidchicken.com>
1226
1227 * process.c (Flist_processes): Removed to Lisp.
1228 (list_processes_1): Deleted.
1229
973f782d
EZ
12302011-04-06 Eli Zaretskii <eliz@gnu.org>
1231
7c106b1e
EZ
1232 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1233
973f782d
EZ
1234 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1235
41cf7d1a 12362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1237
ca23cc88
PE
1238 Fix more problems found by GCC 4.6.0's static checks.
1239
f390e2d5
PE
1240 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1241
42eea0d0
PE
1242 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1243
b69769da 1244 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1245
f9541e84
PE
1246 * xdisp.c (vmessage): Mark as a printf-like function.
1247
13841b55
PE
1248 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1249
c136c10f
PE
1250 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1251
5e2d4a30
PE
1252 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1253 printf-like functions.
1254 (tiff_load): Add casts to remove these marks before passing them
1255 to system-supplied API.
1256
583f48b9
PE
1257 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1258
b25d760e
PE
1259 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1260 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1261 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1262 directly, rather than having caller test rule sign. This avoids
1263 some unnecessary tests.
1264 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1265 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1266 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1267
bc7b6697 1268 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1269 (xfont_open): Avoid unnecessary tests.
bc7b6697 1270
27ccc379
PE
1271 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1272
dcd5c89a
PE
1273 * composite.h, composite.c (composition_gstring_put_cache):
1274 Use EMACS_INT, not int, for length.
1275
b13a45c6
PE
1276 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1277 breaking out part of COMPOSITION_DECODE_RULE.
1278 (COMPOSITION_DECODE_RULE): Use it.
1279 * composite.c (get_composition_id): Remove unused local vars,
1280 by using the new macro.
1281
1e792e4d
PE
1282 * textprop.c (set_text_properties_1): Change while to do-while,
1283 since the condition is always true at first.
1284
dc6c6455 1285 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1286 (interval_deletion_adjustment): Return unsigned value.
1287 All uses changed.
dc6c6455 1288
aba7731a
PE
1289 * process.c (list_processes_1, create_pty, read_process_output):
1290 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1291 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1292 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1293 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1294 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1295
fdfc4bf3
PE
1296 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1297
fca8fe46 1298 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1299 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1300
06a0259a 1301 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1302 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1303 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1304
e7b9e80f
PE
1305 * print.c (print_error_message): Avoid int overflow.
1306
56201685
PE
1307 * font.c (font_list_entities): Redo for clarity,
1308 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1309
78834453 1310 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1311 (font_score): Avoid potential overflow in diff calculation.
78834453 1312
0bc0b309 1313 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1314 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1315
e610eaca
PE
1316 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1317
b895abce
PE
1318 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1319 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1320 can always succeed if overflow has undefined behavior.
1321
1f1d9321 1322 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1323 (wordify): Omit three unnecessary tests.
1f1d9321 1324
c59478bc
PE
1325 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1326 All callers changed. This avoids the need for an unused var.
1327
79b73827
PE
1328 * casefiddle.c (casify_region): Remove var that is set but not used.
1329
a4db5dfe
PE
1330 * dired.c (file_name_completion): Remove var that is set but not used.
1331
43aae36e
PE
1332 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1333
2a47c44d 1334 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1335 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1336
a37c69bf
PE
1337 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1338 Check for integer overflow on size calculations.
1339
328ab8e7
PE
1340 * buffer.c (Fprevious_overlay_change): Remove var that is set
1341 but not used.
1342
e5a2a5cb
PE
1343 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1344 Remove vars that are set but not used.
8d84a6eb 1345 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1346 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1347
a60e5f68
PE
1348 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1349
f661cb61 1350 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1351 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1352
f0397f5a
PE
1353 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1354 that are set but not used.
1355
8664db06 1356 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1357 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1358
6abdaa4a
PE
1359 * xselect.c (x_get_local_selection, x_handle_property_notify):
1360 Remove vars that are set but not used.
1361
0ce7538d 1362 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1363 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1364
9ae848fc
PE
1365 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1366 Remove var that is set but not used.
0b918413
PE
1367 (scroll_bar_windows_size): Now size_t, not int.
1368 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1369 Check for overflow.
9ae848fc 1370
a5a62657
PE
1371 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1372 (map_tty_color) [!defined MSDOS]: Likewise.
1373
5c5cdd39
PE
1374 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1375
66ebf983
PE
1376 * coding.c: Remove vars that are set but not used.
1377 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1378 All callers changed.
1379 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1380 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1381 (decode_coding_charset): Remove vars that are set but not used.
1382
1be4d761
PE
1383 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1384 that is set but not used.
1385
47553fa8
PE
1386 * print.c (print_object): Remove var that is set but not used.
1387
1f7196bf 1388 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1389 The gnulib version avoids calling malloc in the usual case,
1390 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1391 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1392 * filelock.c (current_lock_owner): Likewise.
1393 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1394 * sysdep.c: Include allocator.h, careadlinkat.h.
1395 (emacs_no_realloc_allocator): New static constant.
1396 (emacs_readlink): New function.
fdb61804
PE
1397 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1398 ../lib/careadlinkat.h.
d1fdcab7 1399
f84c17c7
SM
14002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1401
1402 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1403 first non-nil return value).
1404
ef3862ad
JD
14052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1406
1407 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1408 if not defined (Bug#8403).
1409
376a7006
JB
14102011-04-02 Juanma Barranquero <lekktu@gmail.com>
1411
1412 * xdisp.c (display_count_lines): Remove parameter `start',
1413 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1414 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1415 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1416 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1417 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1418 and thereabouts. All callers changed.
1419 (get_per_char_metric): Remove parameter `f', unused since
1420 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1421
6ca3801d
JM
14222011-04-02 Jim Meyering <meyering@redhat.com>
1423
1424 do not dereference NULL upon failed strdup
1425 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1426 (ns_get_family): Likewise.
1427
d8e2b5ba
JB
14282011-04-02 Juanma Barranquero <lekktu@gmail.com>
1429
1430 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1431
8c74fcbd
JD
14322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1433
1434 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1435 later (Bug#8403).
1436
7200d79c
SM
14372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1438
03408648 1439 Add lexical binding.
7200d79c 1440
03408648
SM
1441 * window.c (Ftemp_output_buffer_show): New fun.
1442 (Fsave_window_excursion):
1443 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1444
1445 * lread.c (lisp_file_lexically_bound_p): New function.
1446 (Fload): Bind Qlexical_binding.
1447 (readevalloop): Remove `evalfun' arg.
1448 Bind Qinternal_interpreter_environment.
1449 (Feval_buffer): Bind Qlexical_binding.
1450 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1451 Mark as dynamic.
1452 (syms_of_lread): Declare `lexical-binding'.
1453
1454 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1455
1456 * keyboard.c (eval_dyn): New fun.
1457 (menu_item_eval_property): Use it.
ca105506
SM
1458
1459 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1460
03408648
SM
1461 * fns.c (concat, mapcar1): Accept byte-code-functions.
1462
1463 * eval.c (Fsetq): Handle lexical vars.
1464 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1465 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1466 (FletX, Flet): Obey lexical binding.
1467 (Fcommandp): Handle closures.
1468 (Feval): New `lexical' arg.
1469 (eval_sub): New function extracted from Feval. Use it almost
1470 everywhere where Feval was used. Look up vars in lexical env.
1471 Handle closures.
1472 (Ffunctionp): Move from subr.el.
1473 (Ffuncall): Handle closures.
1474 (apply_lambda): Remove `eval_flags'.
1475 (funcall_lambda): Handle closures and new byte-code-functions.
1476 (Fspecial_variable_p): New function.
1477 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1478 but without exporting it to Lisp.
23aba0ea 1479
23aba0ea 1480 * doc.c (Fdocumentation, store_function_docstring):
03408648 1481 * data.c (Finteractive_form): Handle closures.
23aba0ea 1482
03408648
SM
1483 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1484 interactive spec.
ba83908c 1485
03408648
SM
1486 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1487 byte-codes.
1488 (exec_byte_code): New function extracted from Fbyte_code to handle new
1489 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1490
03408648 1491 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1492
03408648 1493 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1494
e2abce01
JB
14952011-03-31 Juanma Barranquero <lekktu@gmail.com>
1496
1497 * xdisp.c (redisplay_internal): Fix prototype.
1498
63696a73 14992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1500
63696a73
EZ
1501 * xdisp.c (SCROLL_LIMIT): New macro.
1502 (try_scrolling): Use it when setting scroll_limit. Limit
1503 scrolling to 100 screen lines.
1504 (redisplay_window): Even when falling back on "recentering",
1505 position point in the window according to scroll-conservatively,
1506 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1507
1508 (try_scrolling): When point is above the window, allow searching
1509 as far as scroll_max, or one screenful, to compute vertical
1510 distance from PT to the scroll margin position. This prevents
1511 try_scrolling from unnecessarily failing when
1512 scroll-conservatively is set to a value slightly larger than the
1513 window height. Clean up the case of PT below the margin at bottom
1514 of window: scroll_max can no longer be INT_MAX. When aggressive
1515 scrolling is in use, don't let point enter the opposite scroll
1516 margin as result of the scroll.
1517 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1518 threshold of 100 lines for never-recentering scrolling.
1519
e4cc2dfc
JB
15202011-03-31 Juanma Barranquero <lekktu@gmail.com>
1521
1522 * dispextern.h (move_it_by_lines):
1523 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1524 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1525 (message_log_check_duplicate): Remove parameters `prev_bol' and
1526 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1527 (redisplay_internal): Remove parameter `preserve_echo_area',
1528 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1529
1530 * indent.c (Fvertical_motion):
1531 * window.c (window_scroll_pixel_based, Frecenter):
1532 Don't pass `need_y_p' to `move_it_by_lines'.
1533
1c470562
SM
15342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1535
44f230aa
SM
1536 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1537 steal a few bits to be more compact.
1538 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1539 Remove unneeded casts.
1540
1c470562
SM
1541 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1542
888adce9
ZK
15432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1544
1545 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1546 binding" message (bug#7967).
1547
f838ed7b
PE
15482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1549
77861b95
PE
1550 Fix more problems found by GCC 4.6.0's static checks.
1551
de6dbc14
PE
1552 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1553 Remove unused local var.
1554
f838ed7b
PE
1555 * editfns.c (Fmessage_box): Remove unused local var.
1556
792c7b2b
PE
1557 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1558 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1559 Omit unused local vars.
c499e557 1560 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1561 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1562 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1563 Omit unused local var.
1564
ba0165e1
PE
1565 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1566 Don't assume string length fits in int.
32ad8845 1567 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1568 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1569
3c59b4c9
PE
1570 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1571 instead of alloca (Bug#8344).
1572
a3eed478 1573 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1574 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1575
eb4d412d
PE
1576 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1577
1658b401
PE
1578 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1579 concerns.
1580
1581 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1582
1583 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1584
9a2c6e05
PE
1585 * keyboard.c (syms_of_keyboard): Use the same style as later
1586 in this function when indexing through an array. This also
1587 works around GCC bug 48267.
1588
03d0a109
PE
1589 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1590
44f730c8
PE
1591 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1592
fe75f926
PE
1593 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1594 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1595
ffa8c828
PE
1596 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1597 This avoids undefined behavior on integer overflow, and is a bit
1598 more convenient anyway since it is compared to a size_t variable.
1599
c5101a77
PE
1600 Variadic C functions now count arguments with size_t, not int.
1601 This avoids an unnecessary limitation on 64-bit machines, which
1602 caused (substring ...) to crash on large vectors (Bug#8344).
1603 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1604 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1605 All variadic functions and their callers changed accordingly.
c5101a77
PE
1606 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1607 * data.c (arith_driver, float_arith_driver): Likewise.
1608 * editfns.c (general_insert_function): Likewise.
1609 * eval.c (struct backtrace.nargs, interactive_p)
1610 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1611 (funcall_lambda, mark_backtrace): Likewise.
1612 * fns.c (concat): Likewise.
1613 * frame.c (x_set_frame_parameters): Likewise.
1614 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1615 0 if not found, not -1. All callers changed.
1616
dd3f25f7
PE
1617 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1618 (stack_copy_size): Now size_t, not int.
1619 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1620
461c2ab9
JB
16212011-03-28 Juanma Barranquero <lekktu@gmail.com>
1622
1623 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1624 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1625 All callers changed.
1626
1627 * lisp.h (multibyte_char_to_unibyte):
1628 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1629 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1630 * character.h (CHAR_TO_BYTE8):
1631 * cmds.c (internal_self_insert):
1632 * editfns.c (general_insert_function):
1633 * keymap.c (push_key_description):
1634 * search.c (Freplace_match):
1635 * xdisp.c (message_dolog, set_message_1): All callers changed.
1636
f6d62986
SM
16372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1638
1639 * keyboard.c (safe_run_hook_funcall): New function.
1640 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1641 don't set the hook to nil, but remove the offending function instead.
1642 (Qcommand_hook_internal): Remove, unused.
1643 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1644 Vcommand_hook_internal.
1645
1646 * eval.c (enum run_hooks_condition): Remove.
1647 (funcall_nil, funcall_not): New functions.
1648 (run_hook_with_args): Call each function through a `funcall' argument.
1649 Remove `cond' argument, now redundant.
1650 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1651 (Frun_hook_with_args_until_failure): Adjust accordingly.
1652 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1653
1db5b1ad
JB
16542011-03-28 Juanma Barranquero <lekktu@gmail.com>
1655
1656 * dispextern.h (string_buffer_position): Remove declaration.
1657
1658 * print.c (strout): Remove parameter `multibyte', unused since
1659 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1660
1661 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1662 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1663 All callers changed.
1664
1665 * w32.c (_wsa_errlist): Use braces for struct initializers.
1666
1667 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1668 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1669 All callers changed.
1670 (string_buffer_position): Likewise. Also, make static (it's never
1671 used outside xdisp.c).
1672 (cursor_row_p): Remove parameter `w', unused since
1673 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1674 (decode_mode_spec): Remove parameter `precision', introduced during
1675 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1676 All callers changed.
1677
5ffb62aa
JD
16782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1679
1680 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1681
461c2ab9 16822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1683
1684 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1685 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1686 (ns_update_auto_hide_menu_bar): New functions.
1687 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1688 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1689 ns_constrain_all_frames.
1690 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1691 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1692
5c380ffb
JD
16932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1694
1695 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1696
9af30bdf
GM
16972011-03-27 Glenn Morris <rgm@gnu.org>
1698
1699 * syssignal.h: Replace RETSIGTYPE with void.
1700 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1701 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1702 Replace SIGTYPE with void everywhere.
1703 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1704 * s/template.h (SIGTYPE): Remove commented out definition.
1705
e2abce01
JB
17062011-03-26 Eli Zaretskii <eliz@gnu.org>
1707
1708 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1709 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1710
f868cd8a
JB
17112011-03-26 Juanma Barranquero <lekktu@gmail.com>
1712
59eb0929
JB
1713 * w32.c (read_unc_volume): Use parameter `henum', instead of
1714 global variable `wget_enum_handle'.
1715
1716 * keymap.c (describe_vector): Remove parameters `indices' and
1717 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1718 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1719
f868cd8a
JB
1720 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1721
1722 * keyboard.c (timer_check): Remove parameter `do_it_now',
1723 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1724 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1725 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1726
1727 * keyboard.c (read_char):
1728 * w32menu.c (w32_menu_display_help):
1729 * xmenu.c (show_help_event, menu_help_callback):
1730 Adjust calls to `show_help_echo'.
1731
1732 * gtkutil.c (xg_maybe_add_timer):
1733 * keyboard.c (readable_events):
1734 * process.c (wait_reading_process_output):
1735 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1736
1737 * insdel.c (adjust_markers_gap_motion):
1738 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1739 (gap_left, gap_right): Don't call it.
1740
2ecf6fdb
CY
17412011-03-25 Chong Yidong <cyd@stupidchicken.com>
1742
1743 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1744 incurred during fontification.
1745
6b1f9ba4
JB
17462011-03-25 Juanma Barranquero <lekktu@gmail.com>
1747
1748 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1749 (DEFVAR_PER_BUFFER): Don't pass it.
1750
1751 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1752 (scrolling_window): Don't pass it.
1753
0f4a96b5
JB
17542011-03-25 Juanma Barranquero <lekktu@gmail.com>
1755
1756 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1757
1758 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1759 and `suffix'.
1760 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1761 of variables specific to SELinux and computation of `encoded_absname'.
1762
1763 * image.c (XPutPixel): Remove unused variable `height'.
1764
1765 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1766
1767 * unexw32.c (get_section_info): Remove unused variable `section'.
1768
1769 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1770 (system_process_attributes): Remove unused variable `sess'.
1771 (sys_read): Remove unused variable `err'.
1772
1773 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1774 (w32_wnd_proc): Remove unused variable `isdead'.
1775 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1776 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1777 (x_create_tip_frame): Remove unused variable `tem'.
1778
1779 * w32inevt.c (w32_console_read_socket):
1780 Remove unused variable `no_events'.
1781
1782 * w32term.c (x_draw_composite_glyph_string_foreground):
1783 Remove unused variable `width'.
1784
1149507c
JB
17852011-03-24 Juanma Barranquero <lekktu@gmail.com>
1786
1787 * w32term.c (x_set_glyph_string_clipping):
1788 Don't pass uninitialized region to CombineRgn.
1789
9c88f339
JB
17902011-03-23 Juanma Barranquero <lekktu@gmail.com>
1791
1792 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1793 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1794 (Fx_close_connection): Remove unused variable `i'.
1795
1796 * w32font.c (w32font_draw): Return number of glyphs.
1797 (w32font_open_internal): Remove unused variable `i'.
1798 (w32font_driver): Add missing initializer.
1799
1800 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1801 (fill_in_menu): Remove unused variable `items_added'.
1802
1803 * w32term.c (last_mouse_press_frame): Remove static global variable.
1804 (w32_clip_to_row): Remove unused variable `f'.
1805 (x_delete_terminal): Remove unused variable `i'.
1806
1807 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1808 (NOTHING): Remove unused static global variable.
1809 (uniscribe_check_otf): Remove unused variable `table'.
1810 (uniscribe_font_driver): Add missing initializers.
1811
dee091a3
JD
18122011-03-23 Julien Danjou <julien@danjou.info>
1813
1814 * term.c (Fsuspend_tty, Fresume_tty):
1815 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1816 * window.c (temp_output_buffer_show):
1817 * insdel.c (signal_before_change):
1818 * frame.c (Fhandle_switch_frame):
1819 * fileio.c (Fdo_auto_save):
1820 * emacs.c (Fkill_emacs):
1821 * editfns.c (save_excursion_restore):
1822 * cmds.c (internal_self_insert):
1823 * callint.c (Fcall_interactively):
1824 * buffer.c (Fkill_all_local_variables):
1825 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1826 Use Frun_hooks.
0f4a96b5 1827 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1828 unconditionnaly since it does the check itself.
1829
2c520ab5 18302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1831
c9c49752
PE
1832 Fix more problems found by GCC 4.5.2's static checks.
1833
8abc3f12
PE
1834 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1835 the first time through the loop, since we know p0 < p1 then.
1836 This also avoids a gcc -Wstrict-overflow warning.
1837
a2d26660
PE
1838 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1839 leading to a memory leak, possible in functions like
1840 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1841 of objects (Bug#8318).
a2d26660 1842
916c72e9
PE
1843 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1844 that could (at least in theory) be that large.
1845
19ab8a18
PE
1846 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1847 This is less likely to overflow, and avoids undefined behavior if
1848 overflow does occur. All callers changed. Use strtoul to scan
1849 for the unsigned long integer.
b7cbbd6f
PE
1850 (pint2hrstr): Simplify and tune code slightly.
1851 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1852
f0641eff
PE
1853 * scroll.c (do_scrolling): Work around GCC bug 48228.
1854 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1855
7f650bb9
PE
1856 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1857 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1858 (validate_x_resource_name): Simplify count usage.
1859 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1860
37dd57d1
PE
1861 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1862 fail (Bug#8306).
81e56e61 1863
699979fc 1864 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1865
401bf9b4
PE
1866 * process.c (Fmake_network_process): Use socklen_t, not int,
1867 where POSIX says socklen_t is required in portable programs.
1868 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1869 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1870 (Fmake_network_process, server_accept_connection):
1871 (wait_reading_process_output, read_process_output):
1872 Likewise.
1873
b93aacde
PE
1874 * process.c: Rename or move locals to avoid shadowing.
1875 (list_processes_1, Fmake_network_process):
1876 (read_process_output_error_handler, exec_sentinel_error_handler):
1877 Rename or move locals.
4dc343ee 1878 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1879 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1880 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1881 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1882 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1883
af8a867c 1884 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1885 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1886 Include tparam.h instead, since it declares them.
af8a867c
PE
1887 * cm.h (PC): Remove extern decl; tparam.h now does this.
1888 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1889 * terminfo.c: Include tparam.h, to check interfaces.
1890 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1891 (tparam): Adjust signature to match interface in tparam.h;
1892 this removes some undefined behavior. Check that outstring and len
1893 are zero, which they always are with Emacs.
1894 * tparam.h (PC, BC, UP): New extern decls.
1895
0248044d 1896 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1897 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1898
8ff096c1 1899 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1900 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1901 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1902 (ftfont_list): Remove unused local.
49eaafba
PE
1903 (get_adstyle_property, ftfont_pattern_entity):
1904 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1905 Rename locals to avoid shadowing.
8ff096c1 1906
e2be39f6
PE
1907 * xfont.c (xfont_list_family): Mark var as initialized.
1908
c9735e30
PE
1909 * xml.c (make_dom): Now static.
1910
8f5201ae
PE
1911 * composite.c (composition_compute_stop_pos): Rename local to
1912 avoid shadowing.
b246f932
PE
1913 (composition_reseat_it): Remove unused locals.
1914 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1915 (composition_update_it): Mark var as initialized.
11b61122
PE
1916 (find_automatic_composition): Mark vars as initialized,
1917 with a FIXME (Bug#8290).
8f5201ae 1918
760fbc2c
PE
1919 character.h: Rename locals to avoid shadowing.
1920 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1921 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1922 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1923 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1924 to avoid shadowing.
1925
ff08eb85
PE
1926 * textprop.c (property_change_between_p): Remove; unused.
1927
fc7bf025
PE
1928 * intervals.c (interval_start_pos): Now static.
1929
235d7abc
PE
1930 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1931
44f230aa
SM
1932 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1933 Rename locals to avoid shadowing.
3e7d6594 1934
50060332
PE
1935 * sound.c (wav_play, au_play, Fplay_sound_internal):
1936 Fix pointer signedness.
d01f234b 1937 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1938 (wav_play): Initialize a variable to 0, to prevent undefined
1939 behavior (Bug#8278).
50060332 1940
c4fc4e30
PE
1941 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1942
918436ed
PE
1943 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1944
c939f91b
PE
1945 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1946 clobbering (Bug#8298).
b9c7f648
PE
1947 * sysdep.c (sys_subshell): Likewise.
1948 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1949
6bd8c144
PE
1950 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1951 This should get cleaned up, so that child_setup has the
1952 same signature on all platforms.
1953
7710357c 1954 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1955 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1956
c59da222
CY
19572011-03-22 Chong Yidong <cyd@stupidchicken.com>
1958
1959 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1960 not to be necessary, and produces flickering.
1961
66b87493
GM
19622011-03-20 Glenn Morris <rgm@gnu.org>
1963
1964 * config.in: Remove file.
1965
45b6f6d5
JB
19662011-03-20 Juanma Barranquero <lekktu@gmail.com>
1967
1968 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1969 are now in src/globals.h.
1970 (syms_of_minibuf): Remove spurious & from previous change.
1971
3ec03f7e
LL
19722011-03-20 Leo <sdl.web@gmail.com>
1973
1974 * minibuf.c (completing-read-function): New variable.
1975 (completing-read-default): Rename from completing-read.
1976 (completing-read): Call completing-read-function.
1977
b14e3e21
CY
19782011-03-19 Juanma Barranquero <lekktu@gmail.com>
1979
1980 * xfaces.c (Fx_load_color_file):
1981 Read color file from absolute filename (bug#8250).
1982
f2b726e6
JB
19832011-03-19 Juanma Barranquero <lekktu@gmail.com>
1984
1985 * makefile.w32-in: Update dependencies.
1986
09f6ff02
EZ
19872011-03-17 Eli Zaretskii <eliz@gnu.org>
1988
1989 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1990
29a6015a
PE
19912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1992
a3a6c54e
PE
1993 Fix more problems found by GCC 4.5.2's static checks.
1994
b766f867
PE
1995 * process.c (make_serial_process_unwind, send_process_trap):
1996 (sigchld_handler): Now static.
1997
be02381c
PE
1998 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1999 That way, the code declares only the vars that it needs.
2000 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2001 * s/cygwin.h (PTY_ITERATION): Likewise.
2002 * s/darwin.h (PTY_ITERATION): Likewise.
2003 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2004
57048744
PE
2005 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2006 * process.c (allocate_pty): Don't declare stb unless it's needed.
2007
7914961c 2008 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2009 (CONSTANTLIM): Remove; unused.
2010 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2011 Define only if needed.
7914961c 2012
b3967b18
PE
2013 * unexelf.c (unexec): Name an expression,
2014 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2015 Use a different way to cause a compilation error if anyone uses
2016 n rather than nn, a way that does not involve shadowing.
73366a00 2017 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2018
29a6015a
PE
2019 * deps.mk (unexalpha.o): Remove; unused.
2020
43cfc33e 2021 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2022 * unexec.h: New file.
ce701a33
PE
2023 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2024 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2025 Depend on unexec.h.
2026 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2027 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2028 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2029 Change as necessary to match prototype in unexec.h.
ce701a33 2030
01f44d5a
PE
2031 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2032 shadowing.
4f63c6bb 2033 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2034
a6670b0b
PE
2035 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2036 Rename locals to avoid shadowing.
2037
cef2010d 2038 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2039 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2040
d4d7173a
PE
2041 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2042
f08b802a
PE
2043 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2044 warning when compiling print.c.
2045
3ddb0639
PE
2046 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2047 instead of using an uninitialized var.
5ad03b97 2048 (font_sort_entities): Mark var as initialized.
3ddb0639 2049
170a2692
PE
2050 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2051
e663c700
PE
2052 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2053 pointers to constants.
89bc529a 2054 (font_parse_fcname): Remove unused vars.
7b81e2d0 2055 (font_delete_unmatched): Now static.
ea838e10 2056 (font_get_spec): Remove; unused.
13a547c6
PE
2057 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2058 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2059 Rename or move locals to avoid shadowing.
e663c700 2060
2a80c887 2061 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2062 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2063
1384fa33 2064 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2065 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2066
8b2c52e9
PE
2067 * alloc.c (mark_backtrace): Move decl from here ...
2068 * lisp.h: ... to here, so that it can be checked.
2069
475545b5 2070 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2071 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2072 (lisp_indirect_variable): Name an expression,
2073 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2074 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2075
b1349114 2076 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2077 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2078 Use const pointer when appropriate.
b1349114 2079
a2928364
PE
2080 * lisp.h (get_system_name, get_operating_system_release):
2081 Move decls here, to check interfaces.
2082 * process.c (get_operating_system_release): Move decl to lisp.h.
2083 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2084 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2085 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2086 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2087 (Fformat_time_string, Fencode_time, Finsert_char):
2088 (Ftranslate_region_internal, Fformat):
2089 Rename or remove local vars to avoid shadowing.
9710023e 2090 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2091
a415e694
PE
2092 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2093 avoid shadowing.
2094
8ef4622d
PE
2095 * lisp.h (eassert): Check that the argument compiles, even if
2096 ENABLE_CHECKING is not defined.
2097
946f9a5b
PE
2098 * data.c (Findirect_variable): Name an expression, to avoid
2099 gcc -Wbad-function-cast warning.
112396d6 2100 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2101 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2102 (Fmake_variable_buffer_local, Fmake_local_variable):
2103 Mark variables as initialized.
52746918 2104 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2105
e5aab7e7 2106 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2107 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2108 Rename locals to avoid shadowing.
dff45157
PE
2109 (mark_stack): Move local variables into the #ifdef region where
2110 they're used.
7bc26fdb
PE
2111 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2112 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2113 needed otherwise.
2114 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2115 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2116 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2117
e5aab7e7
PE
2118 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2119 avoids undefined behavior in theory.
2120
4da60324
PE
2121 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2122
88043301
PE
2123 Use functions, not macros, for up- and down-casing (Bug#8254).
2124 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2125 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2126 to use the following functions instead of these macros.
2127 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2128 EMACS_INT, since callers assume the returned value fits in int.
2129 (upcase1): Likewise, for UPCASE_TABLE.
2130 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2131 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2132 the race-condition problem in the old DOWNCASE.
88043301 2133
19ed5445
PE
2134 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2135 Rename locals to avoid shadowing.
2136 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2137 (regex_compile, re_search_2, re_match_2_internal):
2138 Remove unused local vars.
952db0d7
PE
2139 (FREE_VAR): Rewrite so as not to use empty "else",
2140 which gcc can warn about.
da053e48 2141 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2142 (RETALLOC_IF): Define only if needed.
2143 (WORDCHAR_P): Likewise. This one is never needed, but is used
2144 only in a comment talking about a compiler bug, so put inside
2145 the #if 0 of that comment.
2146 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2147 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2148 Remove; unused.
19ed5445 2149
1f3561e4 2150 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2151 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2152 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2153
ded6f8f7
PE
2154 * search.c (simple_search): Remove unused var.
2155
dbd37a95
PE
2156 * dired.c (compile_pattern): Move decl from here ...
2157 * lisp.h: ... to here, so that it can be checked.
2158 (struct re_registers): New forward decl.
2159
7e47afad
PE
2160 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2161
85f24f61
PE
2162 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2163 All uses changed.
2164 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2165 Rename locals to avoid shadowing.
5671df8f 2166 (Fvertical_motion): Mark locals as initialized.
85f24f61 2167
181aa2be 2168 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2169 (casify_region): Mark local as initialized.
181aa2be 2170
930d429c
PE
2171 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2172
7082eac6
PE
2173 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2174 New macros, so that the caller can use some names other than
2175 gcpro1, gcpro2, etc.
2176 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2177 of the new macros.
2178 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2179 argument, for consistency with GCPRO2_VAR, etc: it is now the
2180 prefix of the variable, not the variable itself. All uses
2181 changed.
38b2c076
PE
2182 * dired.c (directory_files_internal, file_name_completion):
2183 Rename locals to avoid shadowing.
2184
15206ed9
PE
2185 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2186 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2187 dired.c's scmp function, had undefined behavior.
2188 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2189 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2190 * buffer.h: ... to here, because these macros use current_buffer,
2191 and the new implementation with inline functions needs to have
2192 current_buffer in scope now, rather than later when the macros
2193 are used.
2194 (downcase, upcase1): New static inline functions.
2195 (DOWNCASE, UPCASE1): Reimplement using these functions.
2196 This avoids undefined behavior in expressions like
2197 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2198 from race conditions in accessing the global variables
2199 case_temp1 and case_temp2.
2200 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2201 * lisp.h (case_temp1, case_temp2): Remove their decls.
2202 * character.h (ASCII_CHAR_P): Move from here ...
2203 * lisp.h: ... to here, so that the inline functions mentioned
2204 above can use them.
2205
4a6bea26
PE
2206 * dired.c (directory_files_internal_unwind): Now static.
2207
f14b7e14
PE
2208 * fileio.c (file_name_as_directory, directory_file_name):
2209 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2210 Now static.
2893f146
PE
2211 (file_name_as_directory): Use const pointers when appropriate.
2212 (Fexpand_file_name): Likewise. In particular, newdir might
2213 point at constant storage, so make it a const pointer.
fd4ead52 2214 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2215 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2216 signedness issues.
f839df0c
PE
2217 (Fset_file_times, Finsert_file_contents, auto_save_error):
2218 Rename locals to avoid shadowing.
f14b7e14 2219
5716756e 2220 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2221 (Ftry_completion, Fall_completions): Rename or remove locals
2222 to avoid shadowing.
5716756e 2223
b4c3046a
PE
2224 * marker.c (bytepos_to_charpos): Remove; unused.
2225
b45db522
PE
2226 * lisp.h (verify_bytepos, count_markers): New decls,
2227 so that gcc does not warn that these functions aren't declared.
2228
85876d07
PE
2229 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2230 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2231 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2232 (copy_text): Remove unused local var.
85876d07 2233
03d78a21 2234 * filelock.c (within_one_second): Now static.
b3dd38ab 2235 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2236
5df8f01b
PE
2237 * buffer.c (fix_overlays_before): Mark locals as initialized.
2238 (fix_start_end_in_overlays): Likewise. This function should be
2239 simplified by using pointers-to-pointers, but that's a different
2240 matter.
b1d876f1 2241 (switch_to_buffer_1): Now static.
8f54f30a
PE
2242 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2243 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2244
a70072c9 2245 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2246 Fix pointer signedness issue.
edced198
PE
2247 (sys_subshell): Mark local as volatile if checking for lint,
2248 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2249 (MAXPATHLEN): Define only if needed.
a70072c9 2250
a0977c44
PE
2251 * process.c (serial_open, serial_configure): Move decls from here ...
2252 * systty.h: ... to here, so that they can be checked.
2253
a884fdcc
PE
2254 * fns.c (get_random, seed_random): Move extern decls from here ...
2255 * lisp.h: ... to here, so that they can be checked.
2256
604efe86 2257 * sysdep.c (reset_io): Now static.
b8950c94 2258 (wait_for_termination_signal): Remove; unused.
604efe86 2259
38fc62d9
PE
2260 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2261 (copy_keymap_item, append_key, push_text_char_description):
2262 Now static.
1004a21a 2263 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2264 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2265 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2266 (describe_map_tree):
2267 Rename locals to avoid shadowing.
38fc62d9 2268
2f2650da
PE
2269 * keyboard.c: Declare functions static if they are not used elsewhere.
2270 (echo_char, echo_dash, cmd_error, top_level_2):
2271 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2272 (read_char, kbd_buffer_get_event, make_lispy_position):
2273 (make_lispy_event, make_lispy_movement, apply_modifiers):
2274 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2275 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2276 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2277 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2278 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2279
a053e86c 2280 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2281 (mark_kboards): Move decl here ...
2282 * alloc.c (mark_kboards): ... from here.
a053e86c 2283
4752793e
PE
2284 * lisp.h (force_auto_save_soon): New decl.
2285
74f10ca7 2286 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2287 (DEFINE_DUMMY_FUNCTION): New macro.
2288 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2289 Use it.
c03cd23f
PE
2290 (main): Add casts to avoid warnings
2291 if GCC considers string literals to be constants.
74f10ca7 2292
022e70d4
PE
2293 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2294
59d6fe83
PE
2295 * dbusbind.c: Pointer signedness fixes.
2296 (xd_signature, xd_append_arg, xd_initialize):
2297 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2298 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2299 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2300 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2301
78320123
PE
2302 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2303 if GCC considers string literals to be constants.
49cebcca 2304 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2305
35ac2a97
SM
23062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2307
fb103ca9
SM
2308 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2309 (print_preprocess, print_object): New macro to fix last change.
2310
35ac2a97
SM
2311 * print.c (print_preprocess): Don't forget font objects.
2312
62973b41
JB
23132011-03-16 Juanma Barranquero <lekktu@gmail.com>
2314
2315 * emacs.c (USAGE3): Doc fixes.
2316
0e48bb22
AS
23172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2318
2319 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2320 structure.
2321
7684e57b
JB
23222011-03-14 Juanma Barranquero <lekktu@gmail.com>
2323
2324 * lisp.h (VWindow_system, Qfile_name_history):
2325 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2326 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2327 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2328
2329 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2330 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2331
2332 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2333 * w32console.c (detect_input_pending, read_input_pending)
2334 (encode_terminal_code):
2335 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2336 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2337 (w32_system_caret_y, Qfile_name_history):
2338 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2339 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2340 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2341 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2342 * w32proc.c (Qlocal, report_file_error):
2343 * w32term.c (Vwindow_system, updating_frame):
2344 * w32uniscribe.c (initialized, uniscribe_font_driver):
2345 Remove unneeded extern declarations.
2346
2aa46d6c
CY
23472011-03-14 Chong Yidong <cyd@stupidchicken.com>
2348
c96bbc66 2349 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2350
cffc6f3b
CY
23512011-03-13 Chong Yidong <cyd@stupidchicken.com>
2352
2353 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2354 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2355 These macros can no longer be used for assignment.
2356
44f230aa
SM
2357 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2358 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2359 (record_buffer_markers, fetch_buffer_markers): New functions for
2360 recording and fetching special buffer markers.
2361 (set_buffer_internal_1, set_buffer_temp): Use them.
2362
2363 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2364
2365 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2366
2367 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2368 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2369
2370 * xdisp.c (hscroll_window_tree):
2371 (reconsider_clip_changes): Use PT instead of BUF_PT.
2372
d251f04b
EZ
23732011-03-13 Eli Zaretskii <eliz@gnu.org>
2374
2375 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2376 $(EMACS_ROOT)/lib/intprops.h.
2377
f0c77cd1
PE
23782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2379
3eca4629
PE
2380 Fix more problems found by GCC 4.5.2's static checks.
2381
7c86ee98
PE
2382 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2383 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2384 (xg_free_frame_widgets): Make it clear that a local variable is
2385 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2386 (gdk_window_get_screen): Make it clear that this macro is needed
2387 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2388 (int_gtk_range_get_value): New function, which avoids a diagnostic
2389 from gcc -Wbad-function-cast.
2390 (xg_set_toolkit_scroll_bar_thumb): Use it.
2391 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2392 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2393 (get_utf8_string, xg_get_file_with_chooser):
2394 Rename locals to avoid shadowing.
2395 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2396
41729b81
PE
2397 * xgselect.c (xg_select): Remove unused var.
2398
f0c77cd1
PE
2399 * image.c (four_corners_best): Mark locals as initialized.
2400 (gif_load): Initialize transparent_p to zero (Bug#8238).
2401 Mark another local as initialized.
ec6cf4c6 2402 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2403
ce0ad53d 2404 * image.c (clear_image_cache): Now static.
d5d5a617 2405 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2406 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2407 (x_edge_detection): Remove unnecessary cast that
2408 gcc -Wbad-function-cast diagnoses.
2037898d 2409 (gif_load): Fix pointer signedness.
6ae141d6
PE
2410 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2411 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2412
33383987 24132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2414
d32df629
PE
2415 Improve quality of tests for time stamp overflow.
2416 For example, without this patch (encode-time 0 0 0 1 1
2417 1152921504606846976) returns the obviously-bogus value (-948597
2418 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2419 reports time overflow. See
2420 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2421 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2422 * editfns.c: Include limits.h and intprops.h.
2423 (TIME_T_MIN, TIME_T_MAX): New macros.
2424 (time_overflow): Move earlier, to before first use.
2425 (hi_time, lo_time): New functions, for an accurate test for
2426 out-of-range times.
2427 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2428 (Fget_internal_run_time): Don't assume time_t fits in int.
2429 (make_time): Use list2 instead of Fcons twice.
2430 (Fdecode_time): More accurate test for out-of-range times.
2431 (check_tm_member): New function.
2432 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2433 (lisp_time_argument): Don't rely on undefined left-shift and
2434 right-shift behavior when checking for time stamp overflow.
8be6f318 2435
fe31d94c
PE
2436 * editfns.c (time_overflow): New function, refactoring common code.
2437 (Fformat_time_string, Fdecode_time, Fencode_time):
2438 (Fcurrent_time_string): Use it.
2439
8be6f318
PE
2440 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2441 * dired.c (make_time): Move to ...
2442 * editfns.c (make_time): ... here.
2443 * systime.h: Note the move.
2444
09d9db2c 24452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2446
126bc0dc
YM
2447 * fringe.c (update_window_fringes): Remove unused variables.
2448
c47cbdfd
YM
2449 * unexmacosx.c (copy_data_segment): Also copy __got section.
2450 (Bug#8223)
2451
7ac80be9
EZ
24522011-03-12 Eli Zaretskii <eliz@gnu.org>
2453
c96bbc66 2454 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2455 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2456 Constify `char *' arguments and their references according to
2457 prototypes in tparam.h.
2458
ecb0f94d 2459 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2460
7ac80be9
EZ
2461 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2462 Adapt all references accordingly.
2463
2464 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2465
ef1fd07e
TT
24662011-03-11 Tom Tromey <tromey@redhat.com>
2467
2468 * buffer.c (syms_of_buffer): Remove obsolete comment.
2469
7ef4b50c
EZ
24702011-03-11 Eli Zaretskii <eliz@gnu.org>
2471
2472 * termhooks.h (encode_terminal_code): Declare prototype.
2473
2474 * msdos.c (encode_terminal_code): Don't declare prototype.
2475
2476 * term.c (encode_terminal_code): Now external again, used by
2477 w32console.c and msdos.c.
2478
44f230aa
SM
2479 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2480 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2481
4b1ec863 24822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2483
1714f52b 2484 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2485
4b1ec863
PE
2486 * fringe.c (update_window_fringes): Mark locals as initialized
2487 (Bug#8227).
2488 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2489
524c7aa6
PE
2490 * alloc.c (mark_fringe_data): Move decl from here ...
2491 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2492 to check its interface.
2493 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2494
a5c0af81 2495 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2496 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2497 (fontset_font): Mark local as initialized.
a9a06e0b 2498 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2499
b4716021
PE
2500 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2501
811e9bac 2502 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2503 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2504 (x_own_selection, Fx_disown_selection_internal): Rename locals
2505 to avoid shadowing.
2506 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2507
7e3ab302
PE
2508 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2509 so that the caller can use some name other than gcpro1.
2510 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2511 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2512 (Fx_backspace_delete_keys_p):
2513 Use them to avoid shadowing, and rename vars to avoid shadowing.
2514 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2515 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2516 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2517 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2518 Remove unused locals.
7e3ab302
PE
2519 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2520 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2521 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2522 macros.
f78faa98 2523
e2b13473
PE
2524 * xterm.h (x_mouse_leave): New decl.
2525
77f23912
PE
2526 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2527 Remove unused functions.
cdf4ba58
PE
2528 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2529 (x_calc_absolute_position): Now static.
7411c686 2530 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2531 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2532 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2533 unless they are used.
38d0b34a
PE
2534 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2535 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2536 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2537 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2538 (x_error_catcher, x_connection_closed, x_error_handler):
2539 (x_error_quitter, xembed_send_message, x_iconify_frame):
2540 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2541 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2542 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2543
44f230aa
SM
2544 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2545 Rename or move locals to avoid shadowing.
6b463e58 2546 (tty_defined_color, merge_face_heights): Now static.
5967d051 2547 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2548 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2549 does not deduce is never used uninitialized.
73719eba
PE
2550 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2551 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2552
426994c3 2553 * terminal.c (store_terminal_param): Now static.
5489860b 2554
032f1620 2555 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2556 (set_frame_menubar): Remove unused local.
d4323972 2557 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2558 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2559 since they might point to immutable storage.
281585b0
PE
2560 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2561 since it's unused otherwise.
032f1620 2562
367c19e5 2563 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2564 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2565 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2566 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2567 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2568 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2569 does not deduce are never used uninitialized.
70739cbe 2570
07b48fa9
PE
2571 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2572
8868a238 2573 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2574 * window.c (window_loop, size_window):
2575 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2576
7e5cf297 2577 * window.c (display_buffer): Now static.
d6550a9f
PE
2578 (size_window): Mark variables that gcc -Wuninitialized
2579 does not deduce are never used uninitialized.
a586633d
PE
2580 * window.h (check_all_windows): New decl, to forestall
2581 gcc -Wmissing-prototypes diagnostic.
5b555da1 2582 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2583
f6095868
PE
2584 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2585 shadowing.
2586 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2587 Include <limits.h>.
2588 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2589 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2590 (load_charset_map): Mark variables that gcc -Wuninitialized
2591 does not deduce are never used uninitialized.
53df7c11 2592 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2593
f38b440c
PE
2594 * coding.c (coding_set_source, coding_set_destination):
2595 Use "else { /* comment */ }" rather than "else /* comment */;"
2596 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2597 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2598 a block, when the outer 'i' will do.
2599 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2600 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2601 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2602 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2603 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2604 Rename locals to avoid shadowing.
2605 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2606 * coding.c (emacs_mule_char, encode_invocation_designation):
2607 Now static, since they're not used elsewhere.
413bb2db 2608 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2609 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2610 (decode_coding_emacs_mule): Mark variables that gcc
2611 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2612 (detect_coding_iso_2022): Initialize a local variable that might
2613 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2614 this initialization is needed. (Bug#8211)
5f58e762
PE
2615 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2616 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2617 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2618 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2619 Remove unused macros.
f38b440c 2620
232b38b9 2621 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2622 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2623 * character.c (string_count_byte8): Likewise.
232b38b9 2624
fb90da1b
PE
2625 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2626 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2627
fb93dbc2
PE
2628 * chartab.c (copy_sub_char_table): Now static, since it's not used
2629 elsewhere.
5c156ace
PE
2630 (sub_char_table_ref_and_range, char_table_ref_and_range):
2631 Rename locals to avoid shadowing.
bbcd0949 2632 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2633
7d3b3862 2634 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2635 (BIDI_BOB): Remove unused macro.
7d3b3862 2636
6be7d3da
PE
2637 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2638 deduce are never used uninitialized.
c2ed9c8b 2639 * term.c (encode_terminal_code): Likewise.
6be7d3da 2640
75f8807f 2641 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2642
50938595
PE
2643 * tparam.h: New file.
2644 * term.c, tparam.h: Include it.
2645 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2646 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2647 Move these decls to tparam.h, and make them agree with what
2648 is actually in tparam.c. The previous trick of using incompatible
2649 decls in different modules does not conform to the C standard.
2650 All callers of tparam changed to use tparam's actual API.
2651 * tparam.c (tparam1, tparam, tgoto):
2652 Use const pointers where appropriate.
2653
fbceeba2
PE
2654 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2655 * cm.h (struct cm): Likewise.
2656 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2657 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2658 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2659 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2660 (turn_on_face, init_tty): Likewise.
2661 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2662
7f3f1250
PE
2663 * term.c (term_mouse_position): Rename local to avoid shadowing.
2664
e6ca6543
PE
2665 * alloc.c (mark_ttys): Move decl from here ...
2666 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2667
c40f8d15
AS
26682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2669
2670 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2671
cfe0661d
JB
26722011-03-09 Juanma Barranquero <lekktu@gmail.com>
2673
2674 * search.c (compile_pattern_1): Remove argument regp, unused since
2675 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2676 (compile_pattern): Don't pass it.
2677
0afb4571
J
26782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2679
2680 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2681 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2682 for ! HAVE_GTK3.
2683 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2684
2685 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2686
2687 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2688 gdk_window_get_screen, gdk_window_get_geometry,
2689 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2690 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2691 (xg_get_pixbuf_from_pixmap): New function.
2692 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2693 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2694 Call xg_get_pixbuf_from_pixmap instead of
2695 gdk_pixbuf_get_from_drawable.
2696 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2697 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2698 (xg_check_special_colors): Use GtkStyleContext and its functions
2699 for HAVE_GTK3.
2700 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2701 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2702 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2703 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2704 Call gtk_widget_get_preferred_size.
0afb4571
J
2705 (xg_frame_resized): gdk_window_get_geometry only takes 5
2706 parameters.
44f230aa
SM
2707 (xg_win_to_widget, xg_event_is_for_menubar):
2708 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2709 (xg_set_widget_bg): New function.
2710 (delete_cb): New function.
2711 (xg_create_frame_widgets): connect delete-event to delete_cb.
2712 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2713 (xg_set_background_color): Call xg_set_widget_bg.
2714 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2715 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2716 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2717 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2718 if ! HAVE_GTK3.
2719 (update_frame_tool_bar): Call gtk_widget_hide.
2720 (xg_initialize): Use GDK_KEY_g.
2721
2722 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2723 if ! HAVE_GTK3
2724 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2725
2726 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2727 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2728 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2729
1c2cc4ef
JB
27302011-03-08 Juanma Barranquero <lekktu@gmail.com>
2731
2732 * w32xfns.c (select_palette): Check success of RealizePalette against
2733 GDI_ERROR, not zero.
2734
33383987 2735See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2736
2737;; Local Variables:
2738;; coding: utf-8
aac0c6e3
MR
2739;; End:
2740
33383987 2741 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2742
2743 This file is part of GNU Emacs.
2744
2745 GNU Emacs is free software: you can redistribute it and/or modify
2746 it under the terms of the GNU General Public License as published by
2747 the Free Software Foundation, either version 3 of the License, or
2748 (at your option) any later version.
2749
2750 GNU Emacs is distributed in the hope that it will be useful,
2751 but WITHOUT ANY WARRANTY; without even the implied warranty of
2752 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2753 GNU General Public License for more details.
2754
2755 You should have received a copy of the GNU General Public License
2756 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.