Move NO_ABORT from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
308aab79
GM
12012-07-12 Glenn Morris <rgm@gnu.org>
2
c5564388 3 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set it.
51c3b9b4 4
308aab79
GM
5 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
6 * s/template.h: Move NARROWPROTO to configure.
7
ee1cf5cf
GM
82012-07-11 Glenn Morris <rgm@gnu.org>
9
30fe9bf4
GM
10 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
11 unused since 2011-01-17 change to systty.h.
12
ee1cf5cf
GM
13 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
14 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
15 Move HAVE_PTYS and HAVE_SOCKETS to configure.
16
63e47e07
PE
172012-07-11 Paul Eggert <eggert@cs.ucla.edu>
18
19 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
20
c43fb4c3
GM
212012-07-11 Glenn Morris <rgm@gnu.org>
22
23 * s/darwin.h, s/gnu-linux.h, s/template.h:
24 Move INTERRUPT_INPUT to configure.
25
e8df9267
DA
262012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
27
28 Minor adjustments to interning code.
29 * lisp.h (intern, intern_c_string): Redefine as static inline
30 wrappers for intern_1 and intern_c_string_1, respectively.
31 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
32 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
33 Vobarray checking.
e8df9267
DA
34 * font.c (font_intern_prop): Likewise. Adjust comment.
35 * w32font.c (intern_font_name): Likewise.
36
34348bd4
AS
372012-07-11 Andreas Schwab <schwab@linux-m68k.org>
38
d96a1e0c
AS
39 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
40
34348bd4
AS
41 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
42 of Fcar/Fcdr if possible.
43 * font.c (check_otf_features): Likewise.
44 * fontset.c (Fnew_fontset): Likewise.
45 * gnutls.c (Fgnutls_boot): Likewise.
46 * minibuf.c (read_minibuf): Likewise.
47 * msdos.c (IT_set_frame_parameters): Likewise.
48 * xmenu.c (Fx_popup_dialog): Likewise.
49 * w32menu.c (Fx_popup_dialog): Likewise.
50
c8add24e
GM
512012-07-11 Glenn Morris <rgm@gnu.org>
52
4b575b3c
GM
53 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
54 since nothing has defined it on these platforms.
55
09f4e3b0
GM
56 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
57 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
58
172bedef
GM
59 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
60 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
61 Move CLASH_DETECTION to configure.
62
249685df
GM
63 * s/gnu.h: Remove file, which is now empty.
64
c8add24e
GM
65 * s/gnu.h, s/gnu-linux.h:
66 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
67
b41253a3
JW
682012-07-11 John Wiegley <johnw@newartisans.com>
69
70 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
71 function attribute, so we only use it if it exists in the
72 compiler.
73
d923b542
DA
742012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
75
76 Avoid call to strlen in fast_c_string_match_ignore_case.
77 * search.c (fast_c_string_match_ignore_case): Change to use
78 length argument. Adjust users accordingly.
79 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
80
5ebbef1d
PE
812012-07-11 Paul Eggert <eggert@cs.ucla.edu>
82
bb352260
PE
83 Assume mkdir, rmdir.
84 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
85 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
86
57054ddd
PE
87 Assume rename.
88 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
89
b747d3f7
PE
90 Assume perror.
91 * s/hpux10-20.h (HAVE_PERROR): Remove.
92 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
93 Remove dummy definition, as this problem was obsolete long ago.
94
5ebbef1d
PE
95 Assume strerror.
96 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
97
984e7f30
DA
982012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
99
100 Avoid calls to strlen in font processing functions.
101 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 102 (font_open_by_name): Change to use length argument. Adjust
984e7f30 103 users accordingly.
d923b542
DA
104 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
105 Adjust prototypes.
106 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
107 Change to return ptrdiff_t.
984e7f30
DA
108 (xfont_list_pattern, xfont_match): Use length returned by
109 xfont_decode_coding_xlfd.
110 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
111
20e94fdd
GM
1122012-07-11 Glenn Morris <rgm@gnu.org>
113
9d596af3
GM
114 * s/darwin.h, s/freebsd.h, s/netbsd.h:
115 Move DONT_REOPEN_PTY to configure.
116
20e94fdd
GM
117 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
118 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
119
e99a530f
PE
1202012-07-10 Paul Eggert <eggert@cs.ucla.edu>
121
22ffb973
PE
122 Remove "#define unix" that is no longer needed (Bug#11905).
123 * s/aix4-2.h (unix): Remove; no longer needed.
124
e9a9ae03
PE
125 EMACS_TIME simplification (Bug#11875).
126 This replaces macros (which typically do not work in GDB)
127 with functions, typedefs and enums, making the code easier to debug.
128 The functional style also makes code easier to read and maintain.
129 * systime.h: Include <sys/time.h> on all hosts, not just if
130 WINDOWSNT, since 'struct timeval' is needed in general.
131 (EMACS_TIME): Now a typedef, not a macro.
132 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
133 not macros.
134 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
135 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
136 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
137 (EMACS_TIME_LE): Now functions, not macros.
138 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
139 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
140 which are not functions. All uses rewritten to use:
141 (make_emacs_time): New function.
142 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
143 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
144 not functions. All uses rewritten to use the following, respectively:
145 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
146 (add_emacs_time, sub_emacs_time): New functions.
147 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
148 * fileio.c (Fcopy_file):
149 * xterm.c (XTflash): Get the current time closer to when it's used.
150 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
151
ffacb126
PE
152 * bytecode.c (targets): Suppress -Woverride-init warnings.
153
e99a530f
PE
154 Simplify by avoiding confusing use of strncpy etc.
155 * doc.c (Fsnarf_documentation):
156 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
157 * frame.c (Fmake_terminal_frame):
158 * gtkutil.c (get_utf8_string):
159 * lread.c (openp):
160 * nsmenu.m (ns_update_menubar):
161 * regex.c (regerror):
162 Prefer memcpy to strncpy and strncat when either will do.
163 * fileio.c (Fsubstitute_in_file_name):
164 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
165 (menu_separator_name_p):
166 * nsmenu.m (ns_update_menubar):
167 Prefer memcmp to strncmp when either will do.
168 * nsterm.m: Include <ftoastr.h>.
169 (ns_get_color):
170 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
171 Prefer snprintf to strncpy.
172 * nsterm.m (ns_term_init):
173 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
174 * nsterm.m (ns_term_init):
175 Avoid the need for strncpy, by using build_string or
176 make_unibyte_string directly. Use dtoastr, not snprintf.
177 * process.c (Fmake_network_process): Diagnose service names that
178 are too long, rather than silently truncating them or creating
179 non-null-terminated names.
180 (Fnetwork_interface_info): Likewise, for interface names.
181 * sysdep.c (system_process_attributes) [GNU_LINUX]:
182 Prefer sprintf to strncat.
183 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
184 Prefer vsnprintf to vsprintf + strncpy.
185
c59592b3
GM
1862012-07-10 Glenn Morris <rgm@gnu.org>
187
188 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
189 Clarify fallback case.
190
7d7bbefd
DA
1912012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
192
193 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
194 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
195 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 196 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
197 where argument type is known to be a Lisp_Cons.
198
3a4c8000
TT
1992012-07-10 Tom Tromey <tromey@redhat.com>
200
201 * bytecode.c (BYTE_CODE_THREADED): New macro.
202 (BYTE_CODES): New macro. Replaces all old byte-code defines.
203 (enum byte_code_op): New type.
204 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
205 (exec_byte_code): Use them. Use token threading when applicable.
206
2a0213a6
DA
2072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
208
209 Optimize pure C strings initialization.
210 * lisp.h (make_pure_string): Fix prototype.
211 (build_pure_c_string): New function, defined as static inline. This
212 provides a better opportunity to optimize away calls to strlen when
213 the function is called with compile-time constant argument.
214 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
215 argument, adjust users accordingly. Use build_pure_c_string where
216 appropriate.
217 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
218 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
219 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
220
cb1caeaf
DA
2212012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
222
223 Avoid calls to strlen in miscellaneous functions.
224 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
225 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
226 * lread.c (openp): Likewise.
227
c293e30c
DA
2282012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
229
230 Avoid calls to strlen in path processing functions.
231 * fileio.c (file_name_as_directory): Add comment. Change to add
232 srclen argument and return the length of result. Adjust users
233 accordingly.
234 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 235 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
236 users accordingly.
237 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
238
9e059e3f
GM
2392012-07-10 Glenn Morris <rgm@gnu.org>
240
d02eb359
GM
241 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
242 Move PENDING_OUTPUT_COUNT definition to configure.
243
882cf227
GM
244 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
245 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
246 * s/gnu.h (DATA_START): Move definitions to configure.
247
af6e839f
GM
248 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
249 We include usg5-4-common.h, which defines them both.
250
40289a12
GM
251 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
252 O_RDONLY already includes it).
253
9e059e3f
GM
254 Stop ns builds setting the EMACSLOADPATH environment variable.
255 * nsterm.m (ns_load_path): Rename from ns_init_paths.
256 Now it does not set EMACSLOADPATH, just returns the load-path string.
257 * nsterm.h: Update accordingly.
258 * lread.c [HAVE_NS]: Include nsterm.h.
259 (init_lread) [HAVE_NS]: Use ns_load_path.
260 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
261
7c4e8ec0
GM
2622012-07-09 Glenn Morris <rgm@gnu.org>
263
d4f600ff
GM
264 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
265 since the included bsd-common.h does so.
266
cbb31951
GM
267 Stop ns builds setting the EMACSPATH environment variable.
268 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
269 (ns_init_paths): Do not set EMACSPATH.
270 * nsterm.h (ns_exec_path): Add it.
271 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
272 Use ns_exec_path.
273
7c4e8ec0
GM
274 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
275
26bccfae
PE
2762012-07-09 Paul Eggert <eggert@cs.ucla.edu>
277
a0bee46f
PE
278 * process.c (wait_reading_process_output): 'waitchannels' was unset
279 when read_kbd || !NILP (wait_for_cell); fix this.
280
5994c183
PE
281 Add GCC-style 'const' attribute to functions that can use it.
282 * character.h (char_resolve_modifier_mask):
283 * keyboard.h (make_ctrl_char):
284 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
285 (init_character_once, next_almost_prime, init_fns, init_image)
286 (flush_pending_output, init_sound):
287 * mem-limits.h (start_of_data):
288 * menu.h (finish_menu_items):
289 Add ATTRIBUTE_CONST.
290 * emacs.c (DEFINE_DUMMY_FUNCTION):
291 Declare the dummy function with ATTRIBUTE_CONST.
292 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
293 Add decls with ATTRIBUTE_CONST.
294
26bccfae
PE
295 Minor improvements to make_formatted_string.
296 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
297 where int is good enough, as vsprintf returns an int.
298 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
299
a8290ec3
DA
3002012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
301
302 Use make_formatted_string to avoid double length calculation.
303 * lisp.h (make_formatted_string): New prototype.
304 * alloc.c (make_formatted_string): New function.
305 * buffer.c (Fgenerate_new_buffer_name): Use it.
306 * dbus.c (syms_of_dbusbind): Likewise.
307 * editfns.c (Fcurrent_time_zone): Likewise.
308 * filelock.c (get_boot_time): Likewise.
309 * frame.c (make_terminal_frame, set_term_frame_name)
310 (x_report_frame_params): Likewise.
311 * image.c (gs_load): Likewise.
312 * minibuf.c (get_minibuffer): Likewise.
313 * msdos.c (dos_set_window_size): Likewise.
314 * process.c (make_process): Likewise.
315 * xdisp.c (ensure_echo_area_buffers): Likewise.
316 * xsettings.c (apply_xft_settings): Likewise.
317
d01ba2f1
GM
3182012-07-09 Glenn Morris <rgm@gnu.org>
319
320 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
321 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
322 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
323 * nsterm.h (ns_etc_directory): Add it.
324 * callproc.c [HAVE_NS]: Include nsterm.h.
325 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
326
f1f924b6
DA
3272012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Move marker debugging code under MARKER_DEBUG.
330 * marker.c (MARKER_DEBUG): Move marker debugging code under
331 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
332 for bootstrap with --enable-checking (~3x slowdown reported
333 by Juanma Barranquero <lekktu@gmail.com>).
334 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
335
ab531b66
PE
3362012-07-08 Paul Eggert <eggert@cs.ucla.edu>
337
338 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
339 See <http://bugs.gnu.org/11825#29>.
340
c4b3bc8a
EZ
3412012-07-08 Eli Zaretskii <eliz@gnu.org>
342
343 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
344 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
345 (display_line): Add commentary about displaying truncation glyphs
346 on GUI frames.
347 (produce_special_glyphs): Move here from term.c.
348
349 * term.c (produce_special_glyphs): Move to xdisp.c.
350
351 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
352 section.
c4b3bc8a 353
b676b881
AS
3542012-07-07 Andreas Schwab <schwab@linux-m68k.org>
355
f17c5273
AS
356 * xdisp.c (display_line): Avoid warning about implicit declaration
357 of FRAME_FONT.
358
298819b9
AS
359 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
360
b676b881
AS
361 * lisp.h: Remove empty conditional.
362
6045c4fd
PE
3632012-07-07 Paul Eggert <eggert@cs.ucla.edu>
364
b3350bf9
PE
365 * lread.c (load_path_check): Now static.
366
6045c4fd
PE
367 Fix some minor --with-ns problems found by static checking.
368 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
369 (x_set_font) [!HAVE_X_WINDOWS]:
370 * image.c (xpm_load_image) [HAVE_NS]:
371 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
372 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
373 Remove unused local.
374 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
375 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
376 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
377 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
378 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
379 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
380 Fix pointer signedness problem.
381 * xfaces.c (FRAME_X_FONT_TABLE):
382 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
383
929e7845
GM
3842012-07-07 Glenn Morris <rgm@gnu.org>
385
386 * lread.c (load_path_check): New function, split from init_lread.
387 (init_lread): Reorganize. Motivation:
388 If EMACSLOADPATH is set, check/warn about that rather than the
389 defaults, which we are not going to use. Hence we can remove
390 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
391 Don't warn if site-lisp directories are missing.
392 If not installed, start from a blank load-path, since
393 PATH_LOADSEARCH refers to the eventual installation directories.
394
58dd0aa4
EZ
3952012-07-07 Eli Zaretskii <eliz@gnu.org>
396
397 Support truncation and continuation glyphs on GUI frames, when
398 fringes are disabled. (Bug#11832)
399 * xdisp.c (init_iterator): Get dimensions of truncation and
400 continuation glyphs even if on GUI frames. Adjust
401 it->last_visible_x on GUI frames when the left or right fringes,
402 or both, are absent.
403 (start_display, move_it_in_display_line_to): Handle the case of a
404 GUI frame without a fringe to display continuation or truncation
405 glyphs.
406 (insert_left_trunc_glyphs): Support GUI frames: make sure
407 truncation glyphs overwrite enough glyphs from the current line to
408 have sufficient space in pixels.
409 (display_line): Support truncation and continuation glyphs on GUI
410 frames. If some spare pixels are left on the line after inserting
411 the truncation glyphs, fill that space with a stretch glyph of a
412 suitably computed width.
413
414 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
415 produce_glyphs, to support GUI sessions.
416
31571fd7
PE
4172012-07-07 Paul Eggert <eggert@cs.ucla.edu>
418
5a16b9bc
PE
419 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
420
f3047c75
PE
421 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
422
31571fd7
PE
423 Do not require float-time's arg to fit in time_t (Bug#11825).
424 This works better on hosts where time_t is unsigned, and where
425 float-time is applied to the (negative) difference between two times.
426 * editfns.c (decode_time_components): Last arg is now double *,
427 not int *, and means to store all the result as a double, without
428 worrying about whether the seconds part fits in time_t.
429 All callers changed.
430 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
431 All callers changed.
432 (Ffloat_time): Do not fail merely because the specified time falls
433 outside of time_t range.
434
4516fbef
GM
4352012-07-07 Glenn Morris <rgm@gnu.org>
436
437 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
438 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
439 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
440
07adc2c6
JB
4412012-07-07 Juanma Barranquero <lekktu@gmail.com>
442
443 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
444 Update dependencies.
445
446 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
447
fd573f31
PE
4482012-07-06 Paul Eggert <eggert@cs.ucla.edu>
449
fee5959d
PE
450 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
451 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
452 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
453 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
454 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
455 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
456
fd573f31
PE
457 * xfont.c (compare_font_names): Redo to omit the need for casts.
458
ddadbc0e
AS
4592012-07-06 Andreas Schwab <schwab@linux-m68k.org>
460
fca8d6b6
AS
461 * xfns.c (Fx_change_window_property): Doc fix.
462 * w32fns.c (Fx_change_window_property): Doc fix.
463
ddadbc0e
AS
464 * w32fns.c (Fx_window_property): Accept the same arguments as the
465 X Windows version. Doc fix.
466 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
467
f247498e
JB
4682012-07-06 Juanma Barranquero <lekktu@gmail.com>
469 Eli Zaretskii <eliz@gnu.org>
470
471 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
472 Windows-specific code from nt/config.nt moved here.
473 Obsolete settings removed.
474
216ee680
PE
4752012-07-06 Paul Eggert <eggert@cs.ucla.edu>
476
477 * process.c: Avoid unnecessary calls to gettime.
478 (wait_reading_process_output): Don't get the time of day
479 when gobbling data immediately and not waiting, as there's no need
480 for it in that case. This removes a FIXME.
481
bdd091e4
JD
4822012-07-06 Jan Djärv <jan.h.d@swipnet.se>
483
484 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
485 is defined (Bug#11768).
486
9d44f8ce
DA
4872012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
488
489 Fix marker debugging code.
490 * marker.c (byte_char_debug_check): Do not perform the check
491 if buffer is not multibyte.
090bd7cb
JB
492 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
493 Call byte_char_debug_check with correct arguments.
9d44f8ce 494
90fc4786
DA
4952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
496
497 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
498 * marker.c (byte_char_debug_check, count_markers):
499 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
500 (byte_debug_flag): Remove.
501 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
502 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
503
7b7ae965
DA
5042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
505
4e57b342
DA
506 Avoid code repetition in marker-related functions.
507 * marker.c (attach_marker): New function.
508 (Fset_marker, set_marker_restricted, set_marker_both)
509 (set_marker_restricted_both): Use it.
510 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
511 Consistently rename charno to charpos.
512 (marker_position): Add eassert.
513 (marker_byte_position): Convert to eassert.
514
5152012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
516
517 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 518 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 519 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 520
657924ff
DA
5212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
522
523 Introduce fast path for the widely used marker operation.
524 * alloc.c (build_marker): New function.
525 * lisp.h (build_marker): New prototype.
526 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
527 * composite.c (autocmp_chars): Likewise.
528 * editfns.c (buildmark): Remove.
529 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
530 (save_restriction_save): Use build_marker.
531 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
532 * window.c (save_window_save): Likewise.
533
041a49a6
DA
5342012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
535
536 Do not use Fdelete_overlay in delete_all_overlays
537 to avoid redundant calls to unchain_overlay.
538 * buffer.c (drop_overlay): New function.
539 (delete_all_overlays, Fdelete_overlay): Use it.
540 * minibuf.c (get_minibuffer): Fix comment.
541
7dca65a4
PE
5422012-07-06 Paul Eggert <eggert@cs.ucla.edu>
543
544 Port to OpenBSD 5.1 amd64.
545 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
546 This is needed for OpenBSD, and should be harmless on all BSD systems.
547 Also, include <sys/sysctl.h>, as it should be available on all
548 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
549 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
550 use p_pid member, not kp_proc.pid.
551
8eb876e2
GM
5522012-07-06 Glenn Morris <rgm@gnu.org>
553
554 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
555
38182d90
PE
5562012-07-05 Paul Eggert <eggert@cs.ucla.edu>
557
558 More xmalloc and related cleanup.
559 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
560 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
561 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
562 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
563 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
564 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
565 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
566 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
567 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
568 * xterm.c:
569 Omit needless casts involving void * pointers and allocation.
570 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
571 as the former is more robust if P's type is changed.
572 Prefer xzalloc to xmalloc + memset 0.
573 Simplify malloc-or-realloc to realloc.
574 Don't worry about xmalloc returning a null pointer.
575 Prefer xstrdup to xmalloc + strcpy.
576 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
577 growing it.
578 * keyboard.c (apply_modifiers_uncached): Prefer local array to
579 alloca of a constant.
580
6dd5a677
EZ
5812012-07-05 Eli Zaretskii <eliz@gnu.org>
582
583 * xdisp.c (display_line): Fix horizontal pixel coordinates when
584 hscroll is larger than the line width. Fixes long and futile
585 looping inside extend_face_to_end_of_line (on a TTY) producing
586 glyphs that are not needed and thrown away.
587
6b312f0f
DA
5882012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
589
590 * marker.c (set_marker_restricted_both): Simplify by using
591 clip_to_bounds.
592
f520ef9b
PE
5932012-07-05 Paul Eggert <eggert@cs.ucla.edu>
594
595 * editfns.c (region_limit): Simplify by using clip_to_bounds.
596
383b7c95
JD
5972012-07-05 Jan Djärv <jan.h.d@swipnet.se>
598
599 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
600 not defined (Bug#11768).
601 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
602 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
603 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
604 followed by gtk_box_set_homogeneous (Bug#11768).
605 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
606 (update_theme_scrollbar_width, xg_create_scroll_bar):
607 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
608 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
609 (is_box_type): New function (Bug#11768).
610 (xg_tool_item_stale_p): Call is_box_type.
5293d758 611 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
612 with default display (Bug#11768).
613
d6e7bf45
EZ
6142012-07-05 Eli Zaretskii <eliz@gnu.org>
615
616 * xdisp.c (window_hscroll_limited): New function.
617 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
618 coordinates when window's hscroll is set to insanely large
619 values. (Bug#11857)
620
431391ec
JB
6212012-07-05 Juanma Barranquero <lekktu@gmail.com>
622
623 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
624 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
625
23f86fce
DA
6262012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
627
628 Cleanup xmalloc.
629 * lisp.h (xzalloc): New prototype. Omit needless casts.
630 * alloc.c (xzalloc): New function. Omit needless casts.
631 * charset.c: Omit needless casts. Convert all calls to
632 xmalloc with following memset to xzalloc.
633 * dispnew.c: Likewise.
634 * fringe.c: Likewise.
635 * image.c: Likewise.
636 * sound.c: Likewise.
637 * term.c: Likewise.
638 * w32fns.c: Likewise.
639 * w32font.c: Likewise.
640 * w32term.c: Likewise.
641 * xfaces.c: Likewise.
642 * xfns.c: Likewise.
643 * xterm.c: Likewise.
644 * atimer.c: Omit needless casts.
645 * buffer.c: Likewise.
646 * callproc.c: Likewise.
647 * ccl.c: Likewise.
648 * coding.c: Likewise.
649 * composite.c: Likewise.
650 * doc.c: Likewise.
651 * doprnt.c: Likewise.
652 * editfns.c: Likewise.
653 * emacs.c: Likewise.
654 * eval.c: Likewise.
655 * filelock.c: Likewise.
656 * fns.c: Likewise.
657 * gtkutil.c: Likewise.
658 * keyboard.c: Likewise.
659 * lisp.h: Likewise.
660 * lread.c: Likewise.
661 * minibuf.c: Likewise.
662 * msdos.c: Likewise.
663 * print.c: Likewise.
664 * process.c: Likewise.
665 * region-cache.c: Likewise.
666 * search.c: Likewise.
667 * sysdep.c: Likewise.
668 * termcap.c: Likewise.
669 * terminal.c: Likewise.
670 * tparam.c: Likewise.
671 * w16select.c: Likewise.
672 * w32.c: Likewise.
673 * w32reg.c: Likewise.
674 * w32select.c: Likewise.
675 * w32uniscribe.c: Likewise.
676 * widget.c: Likewise.
677 * xdisp.c: Likewise.
678 * xmenu.c: Likewise.
679 * xrdb.c: Likewise.
680 * xselect.c: Likewise.
681
0497dc44
PE
6822012-07-05 Paul Eggert <eggert@cs.ucla.edu>
683
684 * fileio.c (time_error_value): Check the right error number.
685 Problem reported by Troels Nielsen in
686 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
687
356e7178
PE
6882012-07-04 Paul Eggert <eggert@cs.ucla.edu>
689
4e71fd89
PE
690 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
691 This should be fixed in a better way; see Eli Zaretskii in
692 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
693 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
694
f0941253
PE
695 * fileio.c (time_error_value): Rename from special_mtime.
696 The old name's problems were noted by Eli Zaretskii in
697 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
698
065c9eb4
PE
699 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
700 This variable's comment says Emacs needs at least one GDB-visible
701 symbol of type enum pvec_type, to work around GDB problems.
702 The symbol's value doesn't matter.
703
356e7178
PE
704 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
705 that causes compilation to fail on pre-C99 compilers.
706
95f61aa2
JB
7072012-07-04 Juanma Barranquero <lekktu@gmail.com>
708
709 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
710 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
711
3884d954
DA
7122012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
713
d209e2fb 714 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
715 headers for buffer_defaults and buffer_local_symbols.
716 Reported by Juanma Barranquero <lekktu@gmail.com>.
717
ee28be33
SM
7182012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
719
720 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
721 * lisp.h (enum pvec_type): Use fewer bits.
722 (PSEUDOVECTOR_SIZE_BITS): New constant.
723 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
724 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
725 change in pvec_type.
726 (PSEUDOVECTOR_TYPEP): New macro.
727 (TYPED_PSEUDOVECTORP): Use it.
728 * fns.c (internal_equal): Adapt code to extract pvectype.
729 * emacs.c (gdb_pvec_type): Update type.
730 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
731 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
732 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
733 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
734 (sweep_vectors): Use it. Use local var `total_bytes' instead of
735 abusing vector->header.next.nbytes.
736 (live_vector_p): Use PVEC_TYPE.
737 (mark_object): Adapt code to extract pvectype. Use switch.
738
c7f2cd7f
PE
7392012-07-04 Paul Eggert <eggert@cs.ucla.edu>
740
741 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
742 Tighten new eassert a bit.
743
8ce70ed2
DA
7442012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
745
746 Fix compilation with --enable-gcc-warnings and -O1
747 optimization level.
748 * doprnt.c (doprnt): Change type of tem to int, initialize
749 to avoid compiler warning. Add eassert.
750 * search.c (simple_search): Initialize match_byte to avoid
751 compiler warning. Add eassert.
752
dea7f1e5
PE
7532012-07-04 Paul Eggert <eggert@cs.ucla.edu>
754
24a212eb
PE
755 Avoid weird behavior with large horizontal scrolls.
756 Without this change, for example, large hscroll values would
757 mess up Emacs's display on Fedora 15 x86, presumably due to
758 overflows in int calculations in the display code.
759 Also, if buffers had long lines, Emacs would freeze.
760 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
761 (set_window_hscroll): New function, containing the old guts of
762 Fset_window_hscroll. Return the clipped value.
763 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
764 This avoids the need to check against PTRDIFF_MAX.
765
dea7f1e5
PE
766 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
767
76046526
DA
7682012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
769
770 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
771
39adff0d
PE
7722012-07-04 Paul Eggert <eggert@cs.ucla.edu>
773
63807d47
PE
774 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
775 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
776 since GCC 4.4.6 issues a bogus warning for them.
777
39adff0d
PE
778 Fix bugs in file timestamp newness comparisons.
779 * fileio.c (Ffile_newer_than_file_p):
780 * lread.c (Fload): Use full timestamp resolution of files,
781 not just the 1-second resolution, so that files that are only
782 slightly newer still count as newer.
783 * fileio.c (Ffile_newer_than_file_p): Don't assume file
784 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
785
dbeed9a6
PE
7862012-07-03 Paul Eggert <eggert@cs.ucla.edu>
787
788 * fileio.c: Improve handling of file time marker. (Bug#11852)
789 (special_mtime): New function.
790 (Finsert_file_contents, Fverify_visited_file_modtime):
791 Use it to set special mtime values consistently.
792
636334d6
AS
7932012-07-03 Andreas Schwab <schwab@linux-m68k.org>
794
795 * fileio.c (Finsert_file_contents): Properly handle st_mtime
796 marker for non-existing file. (Bug#11852)
797
e2017fe2
GM
7982012-07-03 Glenn Morris <rgm@gnu.org>
799
800 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
801 and did not make it into globals.h).
802
404dbd37
TT
8032012-07-03 Tom Tromey <tromey@redhat.com>
804
805 * window.c (Fset_window_margins, Fset_window_fringes)
806 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
807 * textprop.c (Fprevious_property_change): No longer static.
808 * syntax.c (Fsyntax_table_p): No longer static.
809 * process.c (Fget_process, Fprocess_datagram_address): No longer
810 static.
811 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
812 * keyboard.c (Fcommand_execute): No longer static.
813 Remove EXFUN.
814 * insdel.c (Fcombine_after_change_execute): No longer static.
815 * image.c (Finit_image_library): No longer static.
816 * fileio.c (Fmake_symbolic_link): No longer static.
817 * eval.c (Ffetch_bytecode): No longer static.
818 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
819 * doc.c (Fdocumentation_property, Fsnarf_documentation):
820 No longer static.
404dbd37
TT
821 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
822 static.
823 * dired.c (Ffile_attributes): No longer static.
824 * composite.c (Fcomposition_get_gstring): No longer static.
825 * callproc.c (Fgetenv_internal): No longer static.
826
827 * ccl.h: Remove EXFUNs.
828 * buffer.h: Remove EXFUNs.
829 * dispextern.h: Remove EXFUNs.
830 * intervals.h: Remove EXFUNs.
831 * fontset.h: Remove EXFUN.
832 * font.h: Remove EXFUNs.
833 * dosfns.c (system_process_attributes): Remove EXFUN.
834 * keymap.h: Remove EXFUNs.
835 * lisp.h: Remove EXFUNs.
836 * w32term.h: Remove EXFUNs.
837 * window.h: Remove EXFUNs.
838 * xsettings.h: Remove EXFUN.
839 * xterm.h: Remove EXFUN.
840
8e4fd1e1
GM
8412012-07-03 Glenn Morris <rgm@gnu.org>
842
843 * lisp.h (Frandom): Make it visible to C.
844 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
845 buffer for invisible buffers. (Bug#1229)
846
ca95b3eb
DA
8472012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
848
849 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
850 values which aren't power of 2.
851 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
852 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
853 accordingly.
854
7555c33f
SM
8552012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
856
857 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
858
859 * alloc.c (mark_object): Revert part of last patch to use `switch'.
860
d12e8f5a
DA
8612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
862
863 * alloc.c (allocate_vector_block): Remove redundant
864 calls to mallopt if DOUG_LEA_MALLOC is defined.
865 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
866 avoid calls to mallopt if zero_vector is returned.
867
296094c3
DA
8682012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
869
870 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
871 is enabled, avoid dereferencing NULL current_sblock if
872 running undumped.
873
36429c89
DA
8742012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
875
876 Cleanup basic buffer management.
877 * buffer.h (struct buffer): Change layout to use generic vector
878 marking code. Fix some comments. Change type of 'clip_changed'
879 to bitfield. Remove unused #ifndef old.
880 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
881 (GET_OVERLAYS_AT): Fix indentation.
882 (for_each_per_buffer_object_at): New macro.
883 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
884 (Fbuffer_local_variables): Use it.
885 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
886 * alloc.c (allocate_buffer): Adjust to match new layout of
887 struct buffer. Fix comment.
888 (mark_overlay): New function.
889 (mark_buffer): Use it. Use mark_vectorlike to mark normal
890 Lisp area of struct buffer.
891 (mark_object): Use it. Adjust marking of misc objects
892 and related comments.
893
3b3e4cac
PE
8942012-07-02 Paul Eggert <eggert@cs.ucla.edu>
895
896 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
897 wrapper that is not needed because the wrapped code is a no-op (zero
898 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
899 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
900
cf5c0175
DA
9012012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
902
903 * alloc.c (mark_buffer): Simplify. Remove prototype.
904 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 905 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
906 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
907 redundant calls to mark_vectorlike for bool vectors.
908
ca26824c
GM
9092012-06-30 Glenn Morris <rgm@gnu.org>
910
2e4c5312
GM
911 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
912
ca26824c
GM
913 * epaths.in (PATH_SITELOADSEARCH): New.
914 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
915 This is rather than relying on --enable-locallisppath elements
916 having "site-lisp" in their names. (Bug#10208#25, 11658)
917
0d23c240
EZ
9182012-06-30 Eli Zaretskii <eliz@gnu.org>
919
c9240d7a
EZ
920 * w32proc.c (sys_select): Accept and ignore one more argument.
921
922 * w32.c (emacs_gnutls_pull): Call select with one more argument.
923
0d23c240 924 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 925 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
926
927 * sysdep.c: Don't include dos.h and dosfns.h.
928
929 * process.c (sys_select):
930 * msdos.c (sys_select): Accept one more argument and ignore it.
931
932 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
933 adapt data types and code to that.
934
935 * dosfns.c:
936 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
937 which clashes with the gnulib function of the same name.
938
af5a5a98
AS
9392012-06-30 Andreas Schwab <schwab@linux-m68k.org>
940
c5e4379c
AS
941 * font.c (font_style_to_value, font_style_symbolic)
942 (font_prop_validate_style): Add type checks for values in
943 font_style_table.
944
af5a5a98
AS
945 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
946 argument.
947 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
948 uses.
949
8d38f461
EZ
9502012-06-29 Eli Zaretskii <eliz@gnu.org>
951
2e5a6631
EZ
952 * xdisp.c (try_window_id): Undo last change.
953
8d38f461
EZ
954 * w32.c (getwd): Adjust commentary about startup_dir.
955 (init_environment): Always call sys_access, even in non-MSVC
956 builds. Don't chdir to the directory of the Emacs executable.
957 This undoes code from 1997 which was justified by the need to
958 "avoid conflicts when removing and renaming directories". But its
959 downside was that every relative file name was being interpreted
960 relative to the directory of the Emacs executable, which can never
961 be TRT. In particular, it broke sys_access when called with
962 relative file names.
963 (sys_access): Map GetLastError to errno.
964
2af3565e
DA
9652012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
966
967 * window.h (struct window): Change type of 'fringes_outside_margins'
968 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 969 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
970 Adjust comment.
971 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
972 to ptrdiff_t.
973
c8d3a25c 9742012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 975
c8d3a25c
GM
976 * gnutls.c (emacs_gnutls_handshake):
977 Add QUIT to make the loop interruptible.
57570cd3 978
c8d3a25c 9792012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 980
c8d3a25c
GM
981 * charset.c (init_charset): Make lack of etc/charsets fatal.
982
3e984ee8
DA
9832012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
984
985 * editfns.c (region_limit): Fix type mismatch.
986
ef884f23
DA
9872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
988
989 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
990 undefined. Convert from xassert to eassert.
991 * nsmenu.m: Convert from xassert to eassert.
992 * nsterm.m: Likewise.
993
7d7e0027
SM
9942012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
995
996 * editfns.c (region_limit): Clip to narrowing (bug#11770).
997
aa754e6a
PE
9982012-06-28 Paul Eggert <eggert@cs.ucla.edu>
999
1000 Avoid integer overflow on scroll-left and scroll-right.
1001 * window.c (HSCROLL_MAX): New macro.
1002 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1003 overflow when requested scroll falls outside ptrdiff_t range.
1004
80b00b08
DA
10052012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1006
1007 * window.h (struct window): Change type of 'hscroll',
1008 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1009 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1010 Adjust users accordingly.
1011 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1012 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1013 from EMACS_INT to ptrdiff_t.
1014 (make_window): Omit redundant initialization.
1015
62b2bcf6
JB
10162012-06-28 Juanma Barranquero <lekktu@gmail.com>
1017
1018 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1019
45942c7d
DA
10202012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1021
1022 * window.h (struct window): Change type of 'use_time' and
1023 'sequence_number' from Lisp_Object to int.
1024 * frame.c (make_frame): Adjust users accordingly.
1025 * print.c (print_object): Likewise.
1026 * window.c (select_window, Fwindow_use_time, make_parent_window)
1027 (make_window): Likewise.
1028
e509cfa6
DA
10292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1030
1031 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1032 enabled with --enable-checking=[all,glyphs] configure option.
1033 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1034 adjust comments accordingly.
1035 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1036 undefined, adjust comments accordingly.
1037 * image.c: Likewise.
1038 * scroll.c: Likewise.
1039 * w32fns.c: Likewise.
1040 * w32term.c: Likewise.
1041 * xdisp.c: Likewise.
1042 * xfaces.c: Likewise.
1043 * xfns.c: Likewise.
1044 * xterm.c: Likewise.
1045
a54e2c05
DA
10462012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 Generalize run-time debugging checks.
1049 * dispextern.h (XASSERTS): Remove.
1050 * fontset.c (xassert): Remove.
1051 Convert from xassert to eassert.
1052 * alloc.c: Convert from xassert to eassert.
1053 * bidi.c: Likewise.
1054 * dispnew.c: Likewise.
1055 * fns.c: Likewise.
1056 * fringe.c: Likewise.
1057 * ftfont.c: Likewise.
1058 * gtkutil.c: Likewise.
1059 * image.c: Likewise.
1060 * keyboard.c: Likewise.
1061 * menu.c: Likewise.
1062 * process.c: Likewise.
1063 * scroll.c: Likewise.
1064 * sound.c: Likewise.
1065 * term.c: Likewise.
1066 * w32console.c: Likewise.
1067 * w32fns.c: Likewise.
1068 * w32term.c: Likewise.
1069 * window.c: Likewise.
1070 * xdisp.c: Likewise.
1071 * xfaces.c: Likewise.
1072 * xfns.c: Likewise.
1073 * xselect.c: Likewise.
1074 * xterm.c: Likewise.
1075
1ec4b7b2
SM
10762012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1077
1078 * fns.c (maybe_resize_hash_table): Output message when growing the
1079 purify-hashtable.
1080
2014308a
DA
10812012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1082
1083 * alloc.c (allocate_string_data): Remove dead code.
1084 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1085 avoid GCC warning about unused macro.
1086
246155eb
DA
10872012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1088
1089 * alloc.c (allocate_string): Omit intervals initialization.
1090 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1091 as in make_pure_string and make_pure_c_string.
1092
43184b7b
DA
10932012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1094
d209e2fb 1095 * alloc.c (allocate_string): Fix last change.
43184b7b 1096
3fe6dd74
DA
10972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1098
d209e2fb 1099 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1100 to memset, add explicit initialization where appropriate.
1101
1ba6038a
GM
11022012-06-27 Glenn Morris <rgm@gnu.org>
1103
1104 * lisp.mk (lisp): Remove paths.elc.
1105
c89926a5
CY
11062012-06-27 Chong Yidong <cyd@gnu.org>
1107
1108 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1109
ed6b3510
JW
11102012-06-26 John Wiegley <johnw@newartisans.com>
1111
1ec4b7b2 1112 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1113 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1114
ed6b3510
JW
1115 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1116 when building with Clang.
1117
8edd4a2b
SM
11182012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1119
1120 * eval.c (Fapply): Allow calling it with a single argument.
1121
f6f62d1b
EZ
11222012-06-26 Eli Zaretskii <eliz@gnu.org>
1123
1124 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1125 _stricmp and _strnicmp.
1126 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1127
62efea5e
DA
11282012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1129
1130 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1131 allocated window.
1132 (allocate_process): Likewise for new process.
8edd4a2b 1133 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1134 (allocate_frame): Likewise.
1135 * frame.c (make_frame): Omit redundant initialization.
1136 * window.c (make_parent_window): Use memset.
1137 (make_window): Omit redundant initialization.
1138 * process.c (make_process): Omit redundant initialization.
1139 * terminal.c (create_terminal): Likewise.
1140
42997f4d
DA
11412012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1142
1143 * term.c (delete_tty): Remove redundant call to memset.
1144
1130ecfc
DA
11452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1146
1147 * alloc.c: Remove build_string.
1148 * lisp.h: Define build_string as static inline. This provides
1149 a better opportunity to optimize away calls to strlen when the
1150 function is called with compile-time constant argument.
1151 * image.c (imagemagick_error): Convert to build_string.
1152 * w32proc.c (sys_spawnve): Likewise.
1153 * xterm.c (x_term_init): Likewise.
1154
cf38a720
PE
11552012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1156
99027bdd
PE
1157 Use sprintf return value instead of invoking strlen on result.
1158 In the old days this wasn't portable, since some sprintf
1159 implementations returned char *. But they died out years ago and
1160 Emacs already assumes sprintf returns int.
1161 Similarly for float_to_string.
1162 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1163 * ccl.c (ccl_driver):
1164 * character.c (string_escape_byte8):
1165 * data.c (Fnumber_to_string):
1166 * doprnt.c (doprnt):
1167 * print.c (print_object):
1168 * xdisp.c (message_dolog):
1169 * xfns.c (syms_of_xfns):
1170 Use sprintf or float_to_string result to avoid need to call strlen.
1171 * data.c (Fnumber_to_string):
1172 Use make_unibyte_string, since the string must be ASCII.
1173 * lisp.h, print.c (float_to_string): Now returns int length.
1174 * term.c (produce_glyphless_glyph):
1175 Use sprintf result rather than recomputing it.
1176
cf38a720
PE
1177 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1178 * Makefile.in (ALL_CFLAGS):
1179 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1180 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1181
3511c784
DA
11822012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1183
0a08eb21 1184 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1185 strcasecmp if available.
1186 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1187
fb7da12e
AS
11882012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1189
1190 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1191 Avoid comma operator.
1192 * menu.c (push_submenu_start, push_submenu_end)
1193 (push_left_right_boundary, push_menu_pane): Likewise.
1194 * msdos.c (dos_rawgetc): Likewise.
1195
afa2ffd8
DA
11962012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 * xfns.c (xic_create_fontsetname): Remove redundant calls
1199 to memset.
1200
b3b4476b
PE
12012012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1202
4495ff38
PE
1203 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1204 sprintf already null-terminates its output.
1205
b3b4476b
PE
1206 * xfns.c (x_window): Remove redundant cast.
1207
b00876c9
DA
12082012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1209
1210 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1211 `const char *' to `char *' to avoid compiler warning.
1212
d188e26b
PE
12132012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1214
885d1d74
PE
1215 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1216 instead of truncating it to 63 (admittedly a generous limit).
1217
d188e26b
PE
1218 * process.c: Fix spelling and caps in comments.
1219
e2f560b1
DN
12202012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1221
e86db54b 1222 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1223 * sysdep.c (setpgrp): Remove definition, not used in this file.
1224
7583a3a1
JB
12252012-06-24 Juanma Barranquero <lekktu@gmail.com>
1226
1227 * makefile.w32-in: Update dependencies.
1228
696056c2
EZ
12292012-06-24 Eli Zaretskii <eliz@gnu.org>
1230
1231 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1232 (SYSTIME_H): Add nt/inc/sys/time.h.
1233
1234 * systime.h [WINDOWSNT]: Include sys/time.h.
1235
1236 * s/ms-w32.h (struct timespec): Definition moved from
1237 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1238
845ca893
PE
12392012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1240
1241 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1242 * buffer.h (buffer_slot_type_mismatch):
1243 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1244 * eval.c (unwind_to_catch):
1245 * image.c (my_png_error, my_error_exit):
1246 * keyboard.c (quit_throw_to_read_char, user_error)
1247 (Fexit_recursive_edit, Fabort_recursive_edit):
1248 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1249 (wrong_type_argument, buffer_overflow, __executable_start)
1250 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1251 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1252 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1253 (fatal):
1254 (child_setup) [!DOS_NT]:
1255 * lread.c (end_of_file_error, invalid_syntax):
1256 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1257 * puresize.h (pure_write_error):
1258 * search.c (matcher_overflow):
1259 * sound.c (sound_perror, alsa_sound_perror):
1260 * sysdep.c, syssignal.h (croak):
1261 * term.c (maybe_fatal, vfatal):
1262 * textprop.c (text_read_only):
1263 * undo.c (user_error):
1264 * unexmacosx.c (unexec_error):
1265 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1266 Use _Noreturn rather than NO_RETURN.
1267 No need for separate decl merely because of _Noreturn.
1268 * sound.c (sound_warning, parse_sound):
1269 Remove unnecessary forward decls.
1270
f1dd8073
PE
12712012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1274 * lisp.h (WAIT_READING_MAX): New macro.
1275 * dispnew.c (Fsleep_for, sit_for):
1276 * keyboard.c (kbd_buffer_get_event):
1277 * process.c (Faccept_process_output):
1278 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1279 This improves on the previous patch, which introduced a bug
1280 when time_t is unsigned and as wide as intmax_t.
1281 See <http://bugs.gnu.org/9000#51>.
1282
b82c1755
EZ
12832012-06-23 Eli Zaretskii <eliz@gnu.org>
1284
1285 * dispnew.c (sit_for, Fsleep_for):
1286 * keyboard.c (kbd_buffer_get_event):
1287 * process.c (Faccept_process_output): Avoid compiler warnings when
1288 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1289
ca300656
JB
12902012-06-23 Juanma Barranquero <lekktu@gmail.com>
1291
049ec95b
JB
1292 * makefile.w32-in: Update dependencies.
1293
ca300656
JB
1294 * w32.c (ltime): Add return type and declare static.
1295 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1296
db7b8d06
PE
12972012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1300 Privately reported by Herbert J. Skuhra.
1301 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1302 All uses changed.
1303 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1304 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1305
0bd8297f
EZ
13062012-06-23 Eli Zaretskii <eliz@gnu.org>
1307
96512555
EZ
1308 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1309 last argument of make_unibyte_string.
1310
0bd8297f
EZ
1311 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1312 language ID in the event parameters.
1313
1314 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1315 event.code, not the obscure "character set ID".
1316
63def6b6
CY
13172012-06-23 Chong Yidong <cyd@gnu.org>
1318
1319 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1320
e8a02204
EZ
13212012-06-23 Eli Zaretskii <eliz@gnu.org>
1322
388cdec0
EZ
1323 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1324 * w32.c (fdutimens): New function.
1325
1326 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1327
1328 * s/ms-w32.h (pselect): Redirect to sys_select.
1329
1330 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1331
e8a02204
EZ
1332 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1333 in the logic of incrementing and decrementing the value of
1334 use_relocatable_buffers.
1335
d054f3fb
PE
13362012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1339 Privately reported by Herbert J. Skuhra.
1340 [__FreeBSD__]: Remove "*/" typo after "#include".
1341 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1342 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1343 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1344 Don't assume EMACS_TIME and struct timeval are the same type.
1345
d35af63c
PE
13462012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 Support higher-resolution time stamps (Bug#9000).
1349 The time stamps are only nanosecond-resolution at the C level,
1350 since that's the best that any real-world system supports now.
1351 But they are picosecond-resolution at the Lisp level, as that's
1352 easy, and leaves room for future OS improvements.
1353
1354 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1355 (LIBES): Use it.
1356
1357 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1358 Don't get current time unless it's needed.
1359
1360 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1361 now provides it if it's absent.
1362 (start_atimer): Port to higher-res time stamps.
1363 Check for time stamp overflow. Don't get current time more
1364 often than is needed.
1365
1366 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1367 Include systime.h, not time.h.
1368 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1369
1370 * dired.c: Include stat-time.h.
1371 (Ffile-attributes): File times now have higher resolution.
1372
1373 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1374 (struct image): Timestamp now has higher resolution.
1375
1376 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1377 has at least microseconds now. All uses removed.
1378 (update_frame, update_single_window, update_window, update_frame_1)
1379 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1380
1381 * editfns.c (time_overflow): Now extern.
1382 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1383 (float-time, Fformat_time_string, Fcurrent_time_string)
1384 (Fcurrent_time_zone): Accept and generate higher-resolution
1385 time stamps.
1386 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1387 (decode_time_components, lisp_seconds_argument): New functions.
1388 (make_time): Now static.
1389 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1390 Report an error if the time is invalid, rather than having the caller
1391 do that.
1392
1393 * fileio.c: Include <stat-time.h>
1394 (Fcopy_file): Copy higher-resolution time stamps.
1395 Prefer to set the time stamp via a file descriptor if that works.
1396 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1397 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1398 (Fvisited_file_modtime, Fset_visited_file_modtime):
1399 Support higher-resolution time stamps.
1400
1401 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1402
1403 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1404
1405 * image.c (prepare_image_for_display, clear_image_cache)
1406 (lookup_image): Port to higer-resolution time stamps.
1407
1408 * keyboard.c (start_polling, bind_polling_period):
1409 Check for time stamp overflow.
1410 (read_char, kbd_buffer_get_event, timer_start_idle)
1411 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1412 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1413 Port to higher-resolution time stamps. Do not assume time_t is signed.
1414 (decode_timer): New function. Timers are now vectors of length 9,
1415 not 8, to accommodate the picosecond component.
1416 (timer_check_2): Use it.
1417
1418 * nsterm.m (select_timeout, timeval_subtract): Remove.
1419 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1420 as they're a bit more accurate and handle overflow better.
1421 (ns_select): Change prototype to be compatible with pselect.
1422 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1423 * nsterm.h (ns_select): Adjust prototype.
1424
1425 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1426 us-resolution time stamps.
1427 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1428
1429 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1430
1431 * lisp.h (time_overflow): New decl.
1432 (wait_reading_process_output): First arg is now intmax_t, not int,
1433 to accommodate larger waits.
1434
1435 * process.h (struct Lisp_Process.read_output_delay):
1436 Now counts nanoseconds, not microseconds.
1437 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1438 EMACS_HAS_USECS.
1439 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1440 (wait_reading_process_output):
1441 Port to ns-resolution time stamps.
1442 (Faccept_process_output, wait_reading_process_output):
1443 Check for time stamp overflow. Do not assume time_t is signed.
1444 (select_wrapper): Remove; we now use pselect.
1445 (Fprocess_attributes): Now generates ns-resolution time stamps.
1446
1447 * sysdep.c: Include utimens.h. Don't include utime.h
1448 or worry about struct utimbuf; gnulib does that for us now.
1449 (gettimeofday): Remove; gnulib provides a substitute.
1450 (make_timeval): New function.
1451 (set_file_times): Now sets ns-resolution time stamps.
1452 New arg FD; all uses changed.
1453 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1454 (system_process_attributes):
1455 Now returns ns-resolution time stamp. All uses changed.
1456 Check for time stamp overflow.
1457
1458 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1459 provides a substitute now.
1460
1461 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1462 since it guarantees struct timespec.
1463 (EMACS_TIME): Now struct timespec, so that we can support
1464 ns-resolution time stamps.
1465 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1466 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1467 (EMACS_USECS): Remove.
1468 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1469 so multiply the arg by 1000 before storing it.
1470 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1471 New macros.
1472 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1473 Port to ns-resolution time stamps.
1474 (EMACS_TIME_NEG_P): Remove; replaced by....
1475 (EMACS_TIME_SIGN): New macro.
1476 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1477 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1478 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1479 (make_timeval, make_lisp_time, decode_time_components): New decls.
1480 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1481 that it mishandled time_t overflow. You can't compare by subtracting!
1482 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1483 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1484
1485 * term.c: Include <sys/time.h>.
1486 (timeval_to_Time): New function, for proper overflow wraparound.
1487 (term_mouse_position, term_mouse_click): Use it.
1488
1489 * undo.c (record_first_change): Support higher-resolution time stamps
1490 in the undo buffer.
1491 (Fprimitive_undo): Use them when restoring time stamps.
1492
1493 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1494 (w32_get_internal_run_time):
1495 Port to higher-resolution Emacs time stamps.
1496 (ltime): Now accepts single 64-bit integer, as that's more convenient
1497 for callers.
1498
1499 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1500
1501 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1502 for compatibility with pselect. Support ns-resolution time stamps.
1503
1504 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1505
1506 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1507 Check for time stamp overflow, and support ns-resolution time stamps.
1508
1509 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1510 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1511 (timeval_subtract): Remove; no longer needed.
1512 (XTflash, XTring_bell, x_wait_for_event):
1513 Port to ns-resolution time stamps. Don't assume time_t is signed.
1514
b6a92dfe
CY
15152012-06-22 Chong Yidong <cyd@gnu.org>
1516
1517 * xdisp.c (x_consider_frame_title): Revert last change.
1518
d251c37c
EZ
15192012-06-22 Eli Zaretskii <eliz@gnu.org>
1520
1521 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1522 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1523 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1524 staticidx goes up to 1597 out of 1600 = 0x640.)
1525
f10deafb
PE
15262012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1529 Otherwise, the umask might be mistakenly 0 while handling input signals.
1530
ec6de1e2
SM
15312012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1532
1533 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1534
28be1ada
DA
15352012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1536
1537 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1538 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1539 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1540 access to `contents' member of Lisp_Vector objects with AREF and ASET
1541 where appropriate.
1542
c6bf3022
CY
15432012-06-19 Chong Yidong <cyd@gnu.org>
1544
1545 * frame.c (delete_frame): When selecting a frame on a different
1546 text terminal, do not alter the terminal's top-frame.
1547
1548 * xdisp.c (format_mode_line_unwind_data): Record the target
1549 frame's selected window and its terminal's top-frame.
1550 (unwind_format_mode_line): Restore them.
1551 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1552 Callers changed.
1553 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1554 since tty frames can be explicitly named.
1555 (prepare_menu_bars): Likewise.
1556
1557 * term.c (Ftty_top_frame): New function.
1558
defd4196
PE
15592012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 Port byte-code-meter to modern targets.
1562 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1563 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1564 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1565 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1566 (METER_1, METER_2): Simplify.
1567
1053a871
SM
15682012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1569
1570 * data.c (Fdefalias): Return `symbol' (bug#11686).
1571
b7e8d081
MR
15722012-06-18 Martin Rudalics <rudalics@gmx.at>
1573
1574 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1575 gets killed during executing of this function (Bug#11665).
1576 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1577 (Vkill_buffer_query_functions): In doc-string say that functions
1578 run by this hook should not change the current buffer.
1579
7ea2b339
PE
15802012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 Fix recently-introduced process.c problems found by static checking.
1583 * process.c (write_queue_push, write_queue_pop, send_process):
1584 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1585 (write_queue_pop): Fix pointer signedness problem.
1586 (send_process): Remove unused local.
1587
96a313a1
CY
15882012-06-17 Chong Yidong <cyd@gnu.org>
1589
1590 * xdisp.c (redisplay_internal): No need to redisplay terminal
1591 frames that are not on top.
1592
20ca2e94
TN
15932012-06-17 Troels Nielsen <bn.troels@gmail.com>
1594
1595 * process.c (make_process): Initialize write_queue.
1596 (write_queue_push, write_queue_pop): New functions.
1597 (send_process): Use them to maintain correct ordering of process
1598 writes (Bug#10815).
1599
9a900ca9
PE
16002012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1601
310fbfa8
PE
1602 * lisp.h (eassert): Assume C89 or later.
1603 This removes the need for CHECK.
1604 (CHECK): Remove. Its comments about always evaluating its
1605 argument were confusing, as 'eassert' typically does not evaluate
1606 its argument.
1607
27bb1ca4
PE
1608 * coding.c (produce_chars): Use ptrdiff_t, not int.
1609
9a900ca9
PE
1610 * xterm.c (x_draw_underwave): Check for integer overflow.
1611 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1612
41b7f8bc 16132012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1614
1615 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1616 referenced (Bug#11583).
1617
9b0e3eba
AA
16182012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1619
1620 Implement wave-style variant of underlining.
1621 * dispextern.h (face_underline_type): New enum.
1622 (face): Add field for underline type.
1623 * nsterm.m (ns_draw_underwave): New function.
1624 (ns_draw_text_decoration): Use it.
1625 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1626 New functions.
1627 (x_draw_glyph_string): Use them.
1628 * xfaces.c (Qline, Qwave): New Lisp objects.
1629 (check_lface_attrs, merge_face_ref)
1053a871
SM
1630 (Finternal_set_lisp_face_attribute, realize_x_face):
1631 Handle wave-style underline face attributes.
9b0e3eba
AA
1632 * xterm.c (x_draw_underwave): New function.
1633 (x_draw_glyph_string): Use it.
1634
0fb52f11
JB
16352012-06-16 Juanma Barranquero <lekktu@gmail.com>
1636
1637 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1638 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1639 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1640 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1641 ($(BLD)/w32select.$(O)): Update dependencies.
1642
e5560ff7
AS
16432012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1644
1645 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1646 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1647 * character.c (_fetch_multibyte_char_p): Remove.
1648 * alloc.c: Include "character.h" before "buffer.h".
1649 * bidi.c: Likewise.
1650 * buffer.c: Likewise.
1651 * bytecode.c: Likewise.
1652 * callint.c: Likewise.
1653 * callproc.c: Likewise.
1654 * casefiddle.c: Likewise.
1655 * casetab.c: Likewise.
1656 * category.c: Likewise.
1657 * cmds.c: Likewise.
1658 * coding.c: Likewise.
1659 * composite.c: Likewise.
1660 * dired.c: Likewise.
1661 * dispnew.c: Likewise.
1662 * doc.c: Likewise.
1663 * dosfns.c: Likewise.
1664 * editfns.c: Likewise.
1665 * emacs.c: Likewise.
1666 * fileio.c: Likewise.
1667 * filelock.c: Likewise.
1668 * font.c: Likewise.
1669 * fontset.c: Likewise.
1670 * fringe.c: Likewise.
1671 * indent.c: Likewise.
1672 * insdel.c: Likewise.
1673 * intervals.c: Likewise.
1674 * keyboard.c: Likewise.
1675 * keymap.c: Likewise.
1676 * lread.c: Likewise.
1677 * macros.c: Likewise.
1678 * marker.c: Likewise.
1679 * minibuf.c: Likewise.
1680 * nsfns.m: Likewise.
1681 * nsmenu.m: Likewise.
1682 * print.c: Likewise.
1683 * process.c: Likewise.
1684 * regex.c: Likewise.
1685 * region-cache.c: Likewise.
1686 * search.c: Likewise.
1687 * syntax.c: Likewise.
1688 * term.c: Likewise.
1689 * textprop.c: Likewise.
1690 * undo.c: Likewise.
1691 * unexsol.c: Likewise.
1692 * w16select.c: Likewise.
1693 * w32fns.c: Likewise.
1694 * w32menu.c: Likewise.
1695 * window.c: Likewise.
1696 * xdisp.c: Likewise.
1697 * xfns.c: Likewise.
1698 * xmenu.c: Likewise.
1699 * xml.c: Likewise.
1700 * xselect.c: Likewise.
1701
2f07e6af
EZ
17022012-06-16 Eli Zaretskii <eliz@gnu.org>
1703
1053a871
SM
1704 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1705 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1706 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1707 row.
1708 (handle_face_prop): Use chunk-relative overlay string index when
1709 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1710 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1711 the rightmost. (Bug#11720)
2f07e6af 1712
29b83cec
AS
17132012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1714
1715 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1716 (CATEGORY_MEMBER): Enforce 1/0 value.
1717 * category.c (_temp_category_set): Remove.
1718
4c5501e9
EZ
17192012-06-16 Eli Zaretskii <eliz@gnu.org>
1720
1721 * window.c (Fdelete_other_windows_internal)
1722 (Fdelete_window_internal): Don't access frame's mouse highlight
1723 info of the initial frame. (Bug#11677)
1724
2b570124
PE
17252012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1726
e93864f9
PE
1727 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1728 Assume USE_2_TAGS_FOR_INTS.
1729 (xreload): Adjust $tagmask width to match recent lisp.h change.
1730
2b570124
PE
1731 Simplify lisp.h in minor ways that should not affect code.
1732 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1733 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1734 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1735 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1736 (INTTYPEBITS): New macro, for clarity.
1737 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1738 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1739 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1740 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1741 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1742
81755f69
JB
17432012-06-13 Juanma Barranquero <lekktu@gmail.com>
1744
1745 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1746
16192a57
GM
17472012-06-13 Glenn Morris <rgm@gnu.org>
1748
1749 * s/bsd-common.h (BSD4_3):
1750 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1751
646b5f55
AS
17522012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1753
1754 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1755 instead of union.
1756 (XLI, XIL): Define.
1053a871
SM
1757 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1758 Use them.
1759 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1760 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1761 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1762 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1763 * frame.c (delete_frame): Remove outdated comment.
1764 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1765 USE_LISP_UNION_TYPE.
1766 (Fw32_unregister_hot_key): Likewise.
1767 (Fw32_toggle_lock_key): Likewise.
1768 * w32menu.c (add_menu_item): Likewise.
1769 (w32_menu_display_help): Use XIL instead of checking
1770 USE_LISP_UNION_TYPE.
1771 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1772 (init_heap): Likewise.
1773 * w32term.c (w32_read_socket): Update comment.
1774
1d3823c9
GM
17752012-06-13 Glenn Morris <rgm@gnu.org>
1776
c62ff706
GM
1777 * s/usg5-4-common.h, src/s/unixware.h:
1778 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1779
1d3823c9
GM
1780 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1781
bfe3e0a2
PE
17822012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1785 * alloc.c (make_number) [!defined make_number]:
1786 Remove, as lisp.h always defines this now.
1787 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1788 (roundup_size): Verify that it is a power of 2.
1789 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1790 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1791 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1792 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1793 USE_LSB_TAG now is always defined to be either 0 or 1.
1794 All uses changed.
1795 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1796 code works fine either way, and efficiency is not a concern here,
1797 as the union type is for debugging, not for production.
1798 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1799 Use an inline function on all platforms when using the union type,
1800 since this is simpler and 'static inline' can be used portably
1801 within Emacs now.
1802 (LISP_INITIALLY_ZERO): New macro.
1803 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1804 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1805
45fa9c0f
GM
18062012-06-12 Glenn Morris <rgm@gnu.org>
1807
b4492cba
GM
1808 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1809
1810 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1811
45fa9c0f
GM
1812 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1813 Move BROKEN_SIGIO to configure.
1814
1815 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1816 Move NO_TERMIO to configure.
1817
0e25d334
CY
18182012-06-12 Chong Yidong <cyd@gnu.org>
1819
1820 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1821 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1822 MagickExportImagePixels is undefined.
1823
43682bb6
PE
18242012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * image.c (imagemagick_load_image): Remove unused label.
1827
a9be7d2b
GM
18282012-06-11 Glenn Morris <rgm@gnu.org>
1829
1830 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1831 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1832 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1833 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1834
3017f87f
SM
18352012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1836
1837 * alloc.c (make_byte_code): New function.
1838 (Fmake_byte_code): Use it. Don't purify here.
1839 * lread.c (read1): Use it as well to avoid extra allocation.
1840
1b9b4cf4
CY
18412012-06-11 Chong Yidong <cyd@gnu.org>
1842
1843 * image.c (imagemagick_load_image): Implement transparency.
1844
95988fcf
AS
18452012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1846
1847 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1848 account for preceding backslashes. (Bug#11663)
1849
cd4eb164
CY
18502012-06-09 Chong Yidong <cyd@gnu.org>
1851
1852 * term.c: Support italics in capable terminals (Bug#9652).
1853 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1854 (turn_on_face): Output using TS_enter_italic_mode if available.
1855 Don't handle unused blinking and alt-charset cases.
1856 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1857 and tty_alt_charset_p cases.
1858 (tty_capable_p, init_tty): Support italics.
1859
1860 * termchar.h (struct tty_display_info): Add field for italics.
1861 Remove unused blink field.
1862
1863 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1864 Handle slant.
1865
1866 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1867 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1868 tty_alt_charset_p. Add tty_italic_p.
1869
ff88beb8
MA
18702012-06-09 Michael Albinus <michael.albinus@gmx.de>
1871
1872 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1873 dbus_type_is_basic if available.
1874 (xd_extract_signed, xd_extract_unsigned): Rename from
1875 extract_signed and extract_unsigned, respectively. Adapt callers.
1876
44286096
CY
18772012-06-09 Chong Yidong <cyd@gnu.org>
1878
1682701f
CY
1879 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1880
44286096
CY
1881 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1882 case (Bug#9752).
1883
d86feb17
PE
18842012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1885
1886 * xdisp.c (vmessage): Treat frame message as multibyte.
1887 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1888 would generate the diagnostic "Making \302\247 buffer-local while
1889 let-bound!".
1890
d5c20fe8
EZ
18912012-06-08 Eli Zaretskii <eliz@gnu.org>
1892
1893 * dispnew.c (showing_window_margins_p): Undo last change, which
1894 was done due to an inadvertent commit.
1895 (adjust_frame_glyphs_for_frame_redisplay): Do call
1896 showing_window_margins_p.
1897
513749ee
SM
18982012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1899
1900 * eval.c (Fmake_var_non_special): New primitive.
1901 (syms_of_eval): Defsubr it.
1902 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1903
d4a8f5c1
JB
19042012-06-08 Juanma Barranquero <lekktu@gmail.com>
1905
1906 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1907 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1908
8bbbc977
EZ
19092012-06-08 Eli Zaretskii <eliz@gnu.org>
1910
1911 * alloc.c (allocate_vectorlike): Fix last change.
1912
f3372c87
DA
19132012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1914
1915 Block-based vector allocation of small vectors.
1916 * lisp.h (struct vectorlike_header): New field `nbytes',
1917 adjust comment accordingly.
1918 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1919 to denote vector blocks. Adjust users (live_vector_p,
1920 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1921 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1922 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1923 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1924 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1925 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1926 (roundup_size): New constant.
1927 (struct vector_block): New data type.
1928 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1929 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1930 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1931 (sweep_vectors): New functions.
1932 (allocate_vectorlike): Return `zero_vector' as the only vector of
1933 0 items. Allocate new vector from block if vector size is less than
1934 or equal to VBLOCK_BYTES_MAX.
1935 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1936 (init_alloc_once): Add call to init_vectors.
1937
4f18a4ed
SM
19382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1939
1940 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1941
86f158bc
PE
19422012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 * doprnt.c (doprnt): Truncate multibyte char correctly.
1945 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1946 would mishandle a string argument "Xc" if X was a multibyte
1947 character of length 2: it would truncate after X's first byte
1948 rather than including all of X.
1949
c5cfcbe0
CY
19502012-06-06 Chong Yidong <cyd@gnu.org>
1951
1952 * buffer.c (word_wrap): Doc fix.
1953
c05cf390
PE
19542012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1955
1956 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1957
0c3461de
GM
19582012-06-03 Glenn Morris <rgm@gnu.org>
1959
1960 * xdisp.c (tool-bar-style): Doc fix.
1961
c71232db
UM
19622012-06-03 Ulrich Müller <ulm@gentoo.org>
1963
1964 * Makefile.in (PAXCTL): Define.
1965 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1966 binary via PaX flags if the paxctl utility is available.
1967 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1968 Restore PaX flags to their default. (Bug#11398)
1969
383f7350
CY
19702012-06-03 Chong Yidong <cyd@gnu.org>
1971
1972 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1973 buffer (Bug#11226).
1974
5f2c76c6
CY
19752012-06-03 Chong Yidong <cyd@gnu.org>
1976
1977 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1978 (note_mode_line_or_margin_highlight): If there is no help echo,
1979 use mode-line-default-help-echo. Handle the case where the mouse
1980 position is past the end of the mode line string.
1981
1982 * buffer.c (buffer_local_value_1): New function, split from
1983 Fbuffer_local_value; can return Qunbound.
1984 (Fbuffer_local_value): Use it.
1985 (Vmode_line_format): Docstring tweaks.
1986
773d47f6
PE
19872012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 * sysdep.c (system_process_attributes): Improve comment.
1990
f2d6a3df
SM
19912012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1992
1993 * keyboard.c: Export real-this-command to Elisp.
1994 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1995 and DEFVAR it. Update all users.
1996
63810350
PE
19972012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1998
7bd5c1f4
PE
1999 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2000
63810350
PE
2001 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2002 Convert pctcpu and pctmem to Lisp float properly.
2003 Let the compiler fold better, as 100.0/0x8000 is exact.
2004
a2821611
AS
20052012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2006
2007 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2008 cons_block.
2009
5fceba1d
PE
20102012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2013
c98ff5dd
DA
20142012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2015
2016 For a 'struct window', replace some Lisp_Object fields to
2017 bitfields where appropriate, remove unused fields.
2018 * window.h (struct window): Remove unused 'last_mark_x' and
2019 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2020 change it's type from Lisp_Object to bitfield.
2021 Change type of 'force_start', 'optional_new_start',
2022 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2023 fields from Lisp_Object to bitfield. Adjust users accordingly.
2024
ca34e0be
PE
20252012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 Pacify gcc -Wdouble-precision when using Xaw.
2028 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2029 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2030 Use 'float' consistently, rather than 'float' in most places
2031 and 'double' in a couple of places.
2032
efc00ab1 20332012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2034
2035 * xdisp.c (handle_stop): Detect whether we have overlay strings
2036 loaded by testing it->current.overlay_string_index to be
2037 non-negative, instead of checking whether n_overlay_strings is
2038 positive. (Bug#11587)
2039
efc00ab1 20402012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2041
2042 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2043
2044 * doc.c (Fsubstitute_command_keys): Doc fix.
2045
efc00ab1 20462012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2047
2048 * search.c (search_buffer): Remove calls to
2049 r_alloc_inhibit_buffer_relocation, as it is now called by
2050 maybe_unify_char, which was the cause of relocation of buffer text
2051 in bug#11519.
2052
efc00ab1 20532012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2054
2055 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2056 for the duration of call to load_charset, to avoid problems with
2057 callers of maybe_unify_char that access buffer text through C
2058 pointers.
2059
2060 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2061 decrement the inhibition flag, instead of just setting or
2062 resetting it.
2063
ba93a187
PE
20642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2065
2066 Remove obsolete '#define static' cruft.
2067 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2068 This #undef was "temporary" in 2000; it is no longer needed
2069 now that '#define static' has gone away.
2070 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2071 (gray_bitmap_bits): Remove; no longer needed.
2072 All uses replaced with definiens.
2073 * xterm.c: Include "bitmaps/gray.xbm".
2074
9e4bf381
PE
20752012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 Clean up __executable_start, monstartup when --enable-profiling.
2078 The following changes affect the code only when profiling.
2079 * dispnew.c (__executable_start): Rename from safe_bcopy.
2080 Define only on platforms that need it.
2081 * emacs.c: Include <sys/gmon.h> when profiling.
2082 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2083 (__executable_start): Remove decl, since lisp.h does it now.
2084 (safe_bcopy): Remove decl; no longer has that name.
2085 (main): Coalesce #if into single bit of code, for simplicity.
2086 Cast pointers to uintptr_t, since standard libraries want integers
2087 and not pointers.
2088 * lisp.h (__executable_start): New decl.
2089
32d72c2f
GM
20902012-05-31 Glenn Morris <rgm@gnu.org>
2091
2092 * image.c (Fimagemagick_types): Doc fix.
2093
baac5bc7
JM
20942012-05-30 Jim Meyering <meyering@redhat.com>
2095
2096 * callproc.c (Fcall_process_region): Include directory component
2097 in mkstemp error message (Bug#11586).
2098
72cb32cf
PE
20992012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 * alloc.c, lisp.h (make_pure_vector): Now static.
2102
61b108cc
SM
21032012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2104
2105 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2106 Move to byte-run.el.
2107 (Fautoload): Do the hash-doc more carefully.
2108 * data.c (Fdefalias): Purify definition, except for keymaps.
2109 (Qdefun): Move from eval.c.
2110 * lisp.h (Qdefun): Remove.
2111 * lread.c (read1): Tiny simplification.
2112
471fe23d
TN
21132012-05-29 Troels Nielsen <bn.troels@gmail.com>
2114
934f3f58 2115 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2116 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2117 Bug#9642, but explicitly check that the buffer the overlay would
2118 be moved to is live and rearrange lines to make sure that errors
2119 will not put the overlay in an inconsistent state.
2120 (Fdelete_overlay): Cosmetics.
2121
85d0efd1
EZ
21222012-05-28 Eli Zaretskii <eliz@gnu.org>
2123
2124 * w32term.c (my_bring_window_to_top): New function.
2125 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2126 could be different from the original one.
2127 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2128 (Bug#11513)
2129
2130 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2131 by calling BringWindowToTop.
2132
2133 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2134 (WM_EMACS_END): Increase by one.
2135
da92a98c
PE
21362012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2139 This avoids undefined behavior that might cause the eassert
2140 to not catch an out-of-range value.
2141
74d1f848
JB
21422012-05-28 Juanma Barranquero <lekktu@gmail.com>
2143
2144 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2145 Update dependencies.
2146
9e1a06fc
EZ
21472012-05-27 Eli Zaretskii <eliz@gnu.org>
2148
2149 * bidi.c (bidi_mirror_char): Fix last change.
2150
f3dd7312
AS
21512012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2152
2153 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2154 when referring to sectname field in printf format.
2155
81899c91
PE
21562012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2157
57b81a9f
PE
2158 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2159 Only r_alloc_inhibit_buffer_relocation needed to be added;
2160 the others were already declared.
2161
81899c91
PE
2162 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2163 before checking whether it's out of range. Put the check inside
2164 eassert. See
2165 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2166
33017faf 21672012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2168
2169 * callproc.c (Fcall_process): Restore a line that was accidentally
2170 commented out in the 2011-02-13 change (bug#11547).
2171
33017faf 21722012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2173
2174 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2175 defined on ralloc.c.
2176
2177 * buffer.c [REL_ALLOC]: Remove prototypes of
2178 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2179 they are now on lisp.h.
2180
2181 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2182
2183 * search.c (search_buffer): Use it to inhibit relocation of buffer
2184 text while re_search_2 is doing its job, because re_search_2 is
2185 passed C pointers to buffer text. (Bug#11519)
2186
23415acf
EZ
2187 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2188 Update value to 24.
2189
44e27368
EZ
2190 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2191 state after an additional call to move_it_in_display_line_to, keep
2192 the values of it->max_ascent and it->max_descent found for the
2193 entire line.
2194 (pos_visible_p): Revert the comparison against bottom_y to what it
2195 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2196 (Bug#11464)
2197
c1892f11
PE
21982012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 Fix coding-related core dumps with gcc -ftrapv.
2201 The code was computing A - B, where A and B are pointers, and B is
2202 random garbage. This can lead to core dumps on platforms that
2203 have special pointer registers, and it also leads to core dumps on
2204 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2205 A - B only when B is initialized properly.
2206 * coding.c (coding_set_source, coding_set_destination): Return void.
2207 (coding_change_source, coding_change_destinations): New functions,
2208 with the old behaviors of coding_set_source and coding_set_destination.
2209 All callers that need an offset changed to use these new functions.
2210
eb7afdad
GM
22112012-05-26 Glenn Morris <rgm@gnu.org>
2212
2213 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2214
f12fdf02
EZ
22152012-05-26 Eli Zaretskii <eliz@gnu.org>
2216
53a63be6 2217 Extend mouse support on W32 text-mode console.
61b108cc
SM
2218 * xdisp.c (draw_row_with_mouse_face):
2219 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2220
eb3f6f01 2221 * w32console.c: Include window.h.
61b108cc
SM
2222 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2223 New functions.
eb3f6f01
EZ
2224 (initialize_w32_display): Initialize mouse-highlight data.
2225
53a63be6
EZ
2226 * w32inevt.c: Include termchar.h and window.h.
2227 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2228 moves, call note_mouse_highlight. If help_echo changed, call
2229 gen_help_event to produce help-echo message in the echo area.
2230 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2231 highlight info.
2232
4cfd81f6
PE
22332012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 * lread.c (read1): Simplify slightly to avoid an overflow warning
2236 with GCC 4.7.0 on x86-64.
2237
4446092a
EZ
22382012-05-26 Eli Zaretskii <eliz@gnu.org>
2239
2240 * bidi.c (bidi_mirror_char): Revert last change: an int is
2241 definitely wide enough here.
2242
42b2a986 22432012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2244
42b2a986 2245 Fix integer width and related bugs (Bug#9874).
eb106a49 2246 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2247 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2248 (string_bytes, check_sblock, allocate_string_data):
2249 (compact_small_strings, Fmake_bool_vector, make_string)
2250 (make_unibyte_string, make_multibyte_string)
2251 (make_string_from_bytes, make_specified_string)
2252 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2253 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2254 (mark_vectorlike):
2255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2256 (allocate_pseudovector):
2257 Use int, not EMACS_INT, where int is wide enough.
2258 (inhibit_garbage_collection, Fgarbage_collect):
2259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2260 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2261 int might not be wide enough.
2262 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2263 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2264 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2265 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2266 (bidi_level_of_next_char, bidi_move_to_visually_next):
2267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2268 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2269 (Fkill_buffer, Fset_buffer_major_mode)
2270 (advance_to_char_boundary, Fbuffer_swap_text)
2271 (Fset_buffer_multibyte, overlays_at, overlays_in)
2272 (overlay_touches_p, struct sortvec, record_overlay_string)
2273 (overlay_strings, recenter_overlay_lists)
2274 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2275 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2276 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2277 (Foverlay_recenter, last_overlay_modification_hooks_used)
2278 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2280 (validate_region): Omit unnecessary test for b <= e,
2281 since that's guaranteed by the previous test.
d311d28c
PE
2282 (adjust_overlays_for_delete): Avoid pos + length overflow.
2283 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2284 (report_overlay_modification):
2285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2286 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2287 Omit pointer cast, which isn't needed anyway, and doesn't work
2288 after the EMACS_INT -> ptrdiff_t change.
02481186 2289 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2290 * buffer.h: Adjust decls to match defn changes elsewhere.
2291 (struct buffer_text, struct buffer):
2292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2293 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2294 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2295 not int, to avoid needless 32-bit limit on 64-bit hosts.
2296 (exec_byte_code): Use tighter memory-full test, one that checks
2297 for alloca overflow. Don't compute the address of the object just
2298 before an array, as that's not portable. Use EMACS_INT, not
2299 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2300 * callint.c (Fcall_interactively):
2301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2302 * callproc.c (call_process_kill, Fcall_process):
2303 Don't assume pid_t fits into an Emacs fixnum.
2304 (call_process_cleanup, Fcall_process, child_setup):
2305 Don't assume pid_t fits into int.
2306 (call_process_cleanup, Fcall_process, delete_temp_file)
2307 (Fcall_process_region):
2308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2309 (Fcall_process): Simplify handling of volatile integers.
2310 Use int, not EMACS_INT, where int will do.
2311 * casefiddle.c (casify_object, casify_region, operate_on_word)
2312 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 (casify_object): Avoid integer overflow when overallocating buffer.
2315 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2316 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2317 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2318 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2319 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2320 integers are now checked earlier. All uses replaced with XINT.
2321 (ccl_driver):
2322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2323 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2324 (ccl_driver, Fregister_code_conversion_map):
2325 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2326 (resolve_symbol_ccl_program): Check that vector header is in range.
2327 Always copy the vector, so that we can check its contents reliably
2328 now rather than having to recheck each instruction as it's being
2329 executed. Check that vector words fit in 'int'.
2330 (ccl_get_compiled_code, Fregister_ccl_program)
2331 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2332 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2333 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2334 contents are in range.
2335 (Fccl_execute_on_string): Check that status is in range.
2336 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2337 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2338 Accept and return EMACS_INT, not int, because callers can pass values
2339 out of 'int' range.
2340 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2341 (multibyte_chars_in_text, parse_str_as_multibyte)
2342 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2343 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2344 (string_escape_byte8, Fget_byte):
2345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2346 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2347 avoid mishandling large integers.
2348 * character.h: Adjust decls to match defn changes elsewhere.
2349 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2350 (Ffind_charset_region):
2351 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2352 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2353 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2354 Don't assume fixnum fits in int.
d311d28c
PE
2355 (load_charset_map_from_vector, Fmap_charset_chars):
2356 Remove now-unnecessary CHECK_NATNUMs.
2357 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2358 Don't rely on undefined behavior with signed left shift overflow.
2359 Don't assume unsigned int fits into fixnum, or that fixnum fits
2360 into unsigned int. Don't require max_code to be a valid fixnum;
2361 that's not true for gb10830 4-byte on a 32-bit host. Allow
2362 invalid_code to be a cons, for the same reason. Require code_offset
2363 to be a character. Avoid int overflow if max_char is close
2364 to INT_MAX.
2365 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2366 this is intended anyway and avoids some undefined behavior.
2367 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2368 INDEX_TO_CODE_POINT, as that's what it expects.
2369 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2370 * charset.h (DECODE_CHAR): Return int, not unsigned;
2371 this is what was intended anyway, and it avoids undefined behavior.
2372 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2373 integer-overflow issues.
2374 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2375 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2376 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2377 * chartab.c (Fmake_char_table, Fset_char_table_range)
2378 (uniprop_get_decoder, uniprop_get_encoder):
2379 Don't assume fixnum fits in int.
2380 * cmds.c (move_point): New function, that does the gist of
2381 Fforward_char and Fbackward_char, but does so while checking
2382 for integer overflow more accurately.
c96e5d6a 2383 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2384 (Fforward_line, Fend_of_line, internal_self_insert)
2385 (internal_self_insert):
2386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2387 Fix a FIXME, by checking for integer overflow when calculating
2388 target_clm and actual_clm.
2389 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2390 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2391 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2392 (coding_alloc_by_making_gap, alloc_destination)
2393 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2394 (encode_coding_utf_16, detect_coding_emacs_mule)
2395 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2396 (detect_coding_iso_2022, decode_coding_iso_2022)
2397 (encode_invocation_designation, encode_designation_at_bol)
2398 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2399 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2400 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2401 (encode_coding_ccl, encode_coding_raw_text)
2402 (detect_coding_charset, decode_coding_charset)
2403 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2404 (produce_composition, produce_charset, produce_annotation)
2405 (decode_coding, handle_composition_annotation)
2406 (handle_charset_annotation, consume_chars, decode_coding_gap)
2407 (decode_coding_object, encode_coding_object, detect_coding_system)
2408 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2409 (code_convert_region, code_convert_string)
8f50130c
PE
2410 (Fdefine_coding_system_internal)
2411 (coding_set_source, coding_set_destination):
d311d28c
PE
2412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2413 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2414 (Fdefine_coding_system_internal):
2415 Don't assume fixnums fit in int.
2416 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2417 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2418 (Funencodable_char_position, Fcheck_coding_systems_region)
2419 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2420 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2421 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2422 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2423 Don't access memory outside of the args array.
d311d28c 2424 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2425 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2426 result of ENCODE_CHAR.
d311d28c
PE
2427 * coding.h: Adjust decls to match defn changes elsewhere.
2428 (struct coding_system):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2430 * composite.c (get_composition_id, find_composition)
2431 (run_composition_function, update_compositions)
2432 (compose_text, composition_gstring_put_cache)
2433 (composition_gstring_p, composition_gstring_width)
2434 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2435 (composition_compute_stop_pos, composition_reseat_it)
2436 (composition_update_it, struct position_record)
2437 (find_automatic_composition, composition_adjust_point)
2438 (Fcomposition_get_gstring, Ffind_composition_internal):
2439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2440 (update_compositions):
2441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2442 * composite.h: Adjust decls to match defn changes elsewhere.
2443 (struct composition):
2444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2445 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2446 Do not attempt to compute the address of the object just before a
2447 buffer; this is not portable.
2448 (Faref, Faset):
2449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2450 (Faset): Use int, not EMACS_INT, where int is wide enough.
2451 (Fstring_to_number): Don't assume fixnums fit in int.
2452 (Frem): Don't assume arg is nonnegative.
2453 * dbusbind.c (xd_append_arg): Check for integers out of range.
2454 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2455 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2456 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2457 (xd_get_connection_references): Return ptrdiff_t, not int.
2458 All uses changed.
2459 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2460 (xd_read_message_1):
2461 Use int, not unsigned, where the dbus API uses int.
2462 (Fdbus_message_internal): Don't overflow mtype.
2463 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2464 * dired.c (directory_files_internal, file_name_completion, scmp)
2465 (file_name_completion_stat):
2466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2467 (file_name_completion): Don't overflow matchcount.
2468 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2469 * dispextern.h: Adjust decls to match defn changes elsewhere.
2470 (struct text_pos, struct glyph, struct bidi_saved_info)
2471 (struct bidi_string_data, struct bidi_it, struct composition_it)
2472 (struct it):
2473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2474 (struct display_pos, struct composition_it, struct it):
2475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2476 * dispnew.c (increment_matrix_positions)
2477 (increment_row_positions, mode_line_string)
2478 (marginal_area_string):
2479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2480 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2482 (duration_to_sec_usec): New function, to check for overflow better.
2483 (Fsleep_for, sit_for): Use it.
2484 * doc.c (get_doc_string, store_function_docstring):
2485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2486 (get_doc_string, Fsnarf_documentation):
2487 Use int, not EMACS_INT, where int is wide enough.
2488 (get_doc_string):
2489 Use SAFE_ALLOCA, not alloca.
2490 Check for overflow when converting EMACS_INT to off_t.
2491 * doprnt.c (doprnt):
2492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2493 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2494 Don't assume uid_t fits into fixnum.
2495 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2496 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2497 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2498 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2499 (general_insert_function)
2500 (Finsert_char, make_buffer_string, make_buffer_string_both)
2501 (update_buffer_properties, Fbuffer_substring)
2502 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2503 (Fsubst_char_in_region, check_translation)
2504 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2505 (transpose_markers, Ftranspose_regions):
2506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2507 (clip_to_bounds): Move to lisp.h as an inline function).
2508 (Fconstrain_to_field): Don't assume integers are nonnegative.
2509 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2510 (Fsubst_char_in_region, Fsave_restriction):
2511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2512 (Femacs_pid): Don't assume pid_t fits into fixnum.
2513 (lo_time): Use int, not EMACS_INT, when int suffices.
2514 (lisp_time_argument): Check for usec out of range.
2515 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2516 (Fuser_login_name, Fuser_full_name): Signal an error
2517 if a uid argument is out of range, rather than relying on
2518 undefined behavior.
c8d5c857
PE
2519 (Fformat_time_string): Remove now-unnecessary check.
2520 lisp_time_argument checks for out-of-range usec now.
243e0530 2521 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2522 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2523 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2524 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2525 (init_cmdargs, Fdump_emacs):
2526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2527 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2528 the bottom (typically) 32 bits of the fixnum.
2529 * eval.c (specpdl_size, call_debugger):
2530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2531 (when_entered_debugger, Fbacktrace_debug):
2532 Don't assume fixnum can fit in int.
2533 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2534 the object just before a buffer; this is not portable.
2535 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2536 (grow_specpdl, unbind_to):
2537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2538 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2539 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2540 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2541 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2542 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2544 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2545 (a_write, e_write):
2546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2547 (Fcopy_file, non_regular_nbytes, read_non_regular)
2548 (Finsert_file_contents):
2549 Use int, not EMACS_INT, where int is wide enough.
2550 (READ_BUF_SIZE): Verify that it fits in int.
2551 (Finsert_file_contents): Check that counts are in proper range,
2552 rather than assuming fixnums fit into ptrdiff_t etc.
2553 Don't assume fixnums fit into int.
125b3835 2554 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2555 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2556 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2557 (string_char_to_byte, string_byte_to_char)
2558 (string_make_multibyte, string_to_multibyte)
2559 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2560 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2561 (substring_both, Fdelete, internal_equal, Ffillarray)
2562 (Fclear_string, mapcar1)
2563 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2564 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2565 (larger_vector, make_hash_table, maybe_resize_hash_table)
2566 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2567 (Fmaphash, secure_hash):
2568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2569 (concat): Check for string index and length overflow.
2570 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2571 (Frequire):
2572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2573 (larger_vector): New API (vec, incr_min, size_max) replaces old
2574 one (vec, new_size, init). This catches size overflow.
2575 INIT was removed because it was always Qnil.
2576 All callers changed.
2577 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2578 the upper bound on a hash table index size.
2579 (make_hash_table, maybe_resize_hash_table): Use it.
2580 (secure_hash): Computer start_byte and end_byte only after
2581 they're known to be in ptrdiff_t range.
2582 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2583 (Ffont_get_glyphs, Ffont_at):
2584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2585 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2586 (Flist_fonts, Fopen_font):
2587 Don't assume fixnum can fit in int.
2588 (check_gstring): Don't assume index can fit in int.
2589 (font_match_p): Check that fixnum is a character, not a nonnegative
2590 fixnum, since the later code needs to stuff it into an int.
2591 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2592 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2593 conversion overflow issues.
2594 (Fopen_font): Check for integer out of range.
2595 (Ffont_get_glyphs): Don't assume index can fit in int.
2596 * font.h: Adjust decls to match defn changes elsewhere.
2597 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2598 integer overflow.
2599 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2600 printmax_t, where ptrdiff_t is wide enough.
2601 (Finternal_char_font):
2602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2603 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2604 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2605 (Fset_frame_position, x_set_frame_parameters)
2606 (x_set_line_spacing, x_set_border_width)
2607 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2608 Check that fixnums are in proper range for system types.
2609 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2611 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2612 Use SAFE_ALLOCA_LISP, not alloca.
2613 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2614 intptr_t is wide enough.
2615 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2616 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2617 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2618 Check for fixnum out of range.
2619 * ftfont.c (ftfont_list): Don't assume index fits in int.
2620 Check that fixnums are in proper range for system types.
2621 (ftfont_shape_by_flt):
2622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2623 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2625 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2626 Check that fixnums are in proper range for system types.
2627 * gnutls.h: Adjust decls to match defn changes elsewhere.
2628 * gtkutil.c (xg_dialog_run):
2629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2630 (update_frame_tool_bar):
2631 Check that fixnums are in proper range for system types.
2632 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2633 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2634 * indent.c (last_known_column, last_known_column_point):
2635 (current_column_bol_cache):
2636 (skip_invisible, current_column, check_display_width):
2637 (check_display_width, scan_for_column, current_column_1)
2638 (Findent_to, Fcurrent_indentation, position_indentation)
2639 (indented_beyond_p, Fmove_to_column, compute_motion):
2640 (Fcompute_motion, Fvertical_motion):
2641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2642 (last_known_column_modified): Use EMACS_INT, not int.
2643 (check_display_width):
2644 (Fcompute_motion):
2645 Check that fixnums and floats are in proper range for system types.
2646 (compute_motion): Don't assume index or fixnum fits in int.
2647 (compute_motion, Fcompute_motion):
2648 Use int, not EMACS_INT, when it is wide enough.
2649 (vmotion): Omit local var start_hpos that is always 0; that way
2650 we don't need to worry about overflow in expressions involving it.
2651 * indent.h: Adjust decls to match defn changes elsewhere.
2652 (struct position):
2653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2654 Use int, not EMACS_INT, where int is wide enough.
2655 Remove unused members ovstring_chars_done and tab_offset;
2656 all uses removed.
2657 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2658 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2659 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2660 (make_gap, copy_text, insert, insert_and_inherit)
2661 (insert_before_markers, insert_before_markers_and_inherit)
2662 (insert_1, count_combining_before, count_combining_after)
2663 (insert_1_both, insert_from_string)
2664 (insert_from_string_before_markers, insert_from_string_1)
2665 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2666 (adjust_after_replace, adjust_after_insert, replace_range)
2667 (replace_range_2, del_range, del_range_1, del_range_byte)
2668 (del_range_both, del_range_2, modify_region)
2669 (prepare_to_modify_buffer, signal_before_change)
2670 (signal_after_change, Fcombine_after_change_execute):
2671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2672 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2673 (balance_an_interval, split_interval_right, split_interval_left)
2674 (find_interval, next_interval, update_interval)
2675 (adjust_intervals_for_insertion, delete_node, delete_interval)
2676 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2677 (static_offset_intervals, offset_intervals)
2678 (merge_interval_right, merge_interval_left, make_new_interval)
2679 (graft_intervals_into_buffer, temp_set_point_both)
2680 (temp_set_point, set_point, adjust_for_invis_intang)
2681 (set_point_both, move_if_not_intangible, get_property_and_range)
2682 (get_local_map, copy_intervals, copy_intervals_to_string)
2683 (compare_string_intervals, set_intervals_multibyte_1):
2684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2685 * intervals.h: Adjust decls to match defn changes elsewhere.
2686 (struct interval):
2687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2688 * keyboard.c (this_command_key_count, this_single_command_key_start)
2689 (before_command_key_count, before_command_echo_length, echo_now)
2690 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2691 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2692 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2693 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2695 (last_non_minibuf_size, last_point_position, echo_truncate)
2696 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2697 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2698 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2699 (stuff_buffered_input):
2700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2701 (last_auto_save, command_loop_1, read_char):
2702 Use EMACS_INT, not int, to avoid integer overflow.
2703 (record_char): Avoid overflow in total_keys computation.
2704 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2705 * keyboard.h: Adjust decls to match defn changes elsewhere.
2706 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2707 (Fkey_description, Fdescribe_vector, Flookup_key):
2708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2709 (click_position): New function, to check that positions are in range.
2710 (Fcurrent_active_maps):
2711 (describe_command):
2712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2713 (Faccessible_keymaps, Fkey_description):
2714 (preferred_sequence_p):
2715 Don't assume fixnum can fit into int.
2716 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2717 Check for integer overflow in size calculations.
2718 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2719 avoid mishandling large integers.
2720 * lisp.h: Adjust decls to match defn changes elsewhere.
2721 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2722 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2723 (struct Lisp_Marker):
2724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2725 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2726 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2727 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2728 All callers changed.
2729 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2730 Assume the arg has valid form, since it always does.
2731 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2732 unsigned integer system type.
2733 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2734 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2736 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2737 (duration_to_sec_usec): New decl.
2738 * lread.c (read_from_string_index, read_from_string_index_byte)
2739 (read_from_string_limit, readchar, unreadchar, openp)
2740 (read_internal_start, read1, oblookup):
2741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2742 (Fload, readevalloop, Feval_buffer, Feval_region):
2743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2744 (openp): Check for out-of-range argument to 'access'.
2745 (read1): Use int, not EMACS_INT, where int is wide enough.
2746 Don't assume fixnum fits into int.
6efdadfd 2747 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2748 (read_filtered_event): Use duration_to_sec_usec
2749 to do proper overflow checking on durations.
d311d28c
PE
2750 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2751 in size calculation.
2752 (Fexecute_kbd_macro):
2753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2754 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2755 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2756 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2757 (set_marker_both, set_marker_restricted_both, marker_position)
2758 (marker_byte_position, Fbuffer_has_markers_at):
2759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2760 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2761 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2762 It now merely ensures that the menu is large enough, without
2763 necessarily growing it, as this avoids some integer overflow issues.
2764 All callers changed.
2765 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2767 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2768 Use SAFE_ALLOCA_LISP, not alloca.
2769 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2770 to EMACS_INT. Check that fixnums are in proper range for system types.
2771 * minibuf.c (minibuf_prompt_width, string_to_object)
2772 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2773 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2775 (get_minibuffer, read_minibuf_unwind):
2776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2777 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2778 this simplifies overflow checking. All callers changed.
2779 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2780 (Ftest_completion):
2781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2782 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2783 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2784 Check that fixnums are in proper range for system types.
2785 (Fx_create_frame, Fx_show_tip):
2786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2787 * nsfont.m (ns_findfonts, nsfont_list_family):
2788 Don't assume fixnum fits in long.
2789 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2791 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2792 wide enough.
17fdb222 2793 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2795 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2796 (PRINTDECLARE, PRINTPREPARE):
2797 (strout, print_string):
2798 (print, print_preprocess, print_check_string_charset_prop)
2799 (print_object):
2800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2801 (PRINTDECLARE):
2802 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2804 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2805 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2806 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2807 (print_error_message): Use SAFE_ALLOCA, not alloca.
2808 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2809 (print_depth, new_backquote_output, print_number_index):
2810 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2811 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2812 (Fset_process_window_size, Fformat_network_address)
2813 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2814 (sigchld_handler):
d311d28c 2815 Check that fixnums are in proper range for system types.
d44287d4 2816 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2817 Check for process-ids out of pid_t range rather than relying on
2818 undefined behavior.
e4d81efc 2819 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2820 (Fformat_network_address, read_process_output, send_process)
2821 (Fprocess_send_region, status_notify):
2822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2823 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2824 (wait_reading_process_output, read_process_output, exec_sentinel):
2825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2826 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2827 (Faccept_process_output): Use duration_to_sec_usec to do proper
2828 overflow checking on durations.
dde14581
PE
2829 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2830 Don't assume pid_t fits in int.
02481186
PE
2831 * process.h (struct Lisp_Process): Members tick and update_tick
2832 are now of type EMACS_INT, not int.
b62b53e8
PE
2833 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2834 configured --with-wide-int.
d311d28c
PE
2835 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2836 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2837 * search.c (looking_at_1, string_match_1):
2838 (fast_string_match, fast_c_string_match_ignore_case)
2839 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2840 (scan_newline, find_before_next_newline, search_command)
2841 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2842 (set_search_regs, wordify):
2843 (Freplace_match):
2844 (Fmatch_data):
2845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2846 (string_match_1, search_buffer, set_search_regs):
2847 (Fmatch_data):
2848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2849 (wordify): Check for overflow in size calculation.
2850 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2851 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2852 Check that fixnums are in proper range for system types.
2853 * sound.c (struct sound_device)
2854 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2856 (Fplay_sound_internal):
2857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2858 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2859 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2860 (Fparse_partial_sexp):
2861 Don't assume fixnums can fit in int.
2862 (struct lisp_parse_state, find_start_pos, find_start_value)
2863 (find_start_value_byte, find_start_begv)
2864 (update_syntax_table, char_quoted, dec_bytepos)
2865 (find_defun_start, prev_char_comend_first, back_comment):
2866 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2867 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2869 (Finternal_describe_syntax_value): Check that match_lisp is a
2870 character, not an integer, since the code stuffs it into int.
2871 (scan_words, scan_sexps_forward):
2872 Check that fixnums are in proper range for system types.
2873 (Fforward_word):
2874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2875 (scan_sexps_forward):
2876 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2877 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2878 * syntax.h: Adjust decls to match defn changes elsewhere.
2879 (struct gl_state_s):
2880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2881 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2882 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2883 * sysdep.c (wait_for_termination_1, wait_for_termination)
2884 (interruptible_wait_for_termination, mkdir):
2885 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2886 (emacs_read, emacs_write):
2887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2888 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2889 and double all fit in int.
d311d28c
PE
2890 * term.c (set_tty_color_mode):
2891 Check that fixnums are in proper range for system types.
2892 * termhooks.h (struct input_event):
2893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2894 * textprop.c (validate_interval_range, interval_of)
2895 (Fadd_text_properties, set_text_properties_1)
2896 (Fremove_text_properties, Fremove_list_of_text_properties)
2897 (Ftext_property_any, Ftext_property_not_all)
2898 (copy_text_properties, text_property_list, extend_property_ranges)
2899 (verify_interval_modification):
2900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2901 (Fnext_single_char_property_change)
2902 (Fprevious_single_char_property_change):
2903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2904 (copy_text_properties):
2905 Check for integer overflow in index calculation.
d311d28c
PE
2906 * undo.c (last_boundary_position, record_point, record_insert)
2907 (record_delete, record_marker_adjustment, record_change)
2908 (record_property_change):
2909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2910 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2912 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2913 (Fx_hide_tip, Fx_file_dialog):
2914 * w32menu.c (set_frame_menubar):
2915 Use ptrdiff_t, not int, for consistency with rest of code.
2916 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2917 (select_window, Fdelete_other_windows_internal)
2918 (window_scroll_pixel_based, window_scroll_line_based)
2919 (Frecenter, Fset_window_configuration):
2920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2921 (Fset_window_hscroll, run_window_configuration_change_hook)
2922 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2923 (Fscroll_other_window, Frecenter):
d311d28c
PE
2924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2925 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2926 Don't assume fixnum fits in int.
2927 (Fset_window_scroll_bars):
2928 Check that fixnums are in proper range for system types.
2929 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2930 (string_pos, c_string_pos, number_of_chars, init_iterator)
2931 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2932 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2933 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2934 (face_before_or_after_it_pos, handle_invisible_prop)
2935 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2936 (display_prop_intangible_p, string_buffer_position_lim)
2937 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2938 (get_overlay_strings_1, get_overlay_strings)
2939 (iterate_out_of_display_property, forward_to_next_line_start)
2940 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2941 (get_next_display_element, set_iterator_to_next)
2942 (get_visually_first_element, compute_stop_pos_backwards)
2943 (handle_stop_backwards, next_element_from_buffer)
2944 (move_it_in_display_line_to, move_it_in_display_line)
2945 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2946 (add_to_log, message_dolog, message_log_check_duplicate)
2947 (message2, message2_nolog, message3, message3_nolog
2948 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2949 (current_message_1, truncate_echo_area, truncate_message_1)
2950 (set_message, set_message_1, store_mode_line_noprop)
2951 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2952 (text_outside_line_unchanged_p, check_point_in_composition)
2953 (reconsider_clip_changes)
2954 (redisplay_internal, set_cursor_from_row, try_scrolling)
2955 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2956 (redisplay_window, find_last_unchanged_at_beg_row)
2957 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2958 (trailing_whitespace_p, find_row_edges, display_line)
2959 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2960 (display_mode_element, store_mode_line_string)
2961 (pint2str, pint2hrstr, decode_mode_spec)
2962 (display_count_lines, display_string, draw_glyphs)
2963 (x_produce_glyphs, x_insert_glyphs)
2964 (rows_from_pos_range, mouse_face_from_buffer_pos)
2965 (fast_find_string_pos, mouse_face_from_string_pos)
2966 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2968 (safe_call, init_from_display_pos, handle_fontified_prop)
2969 (handle_single_display_spec, load_overlay_strings)
2970 (with_echo_area_buffer, setup_echo_area_for_printing)
2971 (display_echo_area, echo_area_display)
2972 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2973 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2974 (redisplay_window, dump_glyph_row, display_mode_line)
2975 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2976 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2978 (handle_single_display_spec, build_desired_tool_bar_string)
2979 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2980 (get_specified_cursor_type):
2981 Check that fixnums are in proper range for system types.
2982 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2983 (Flookup_image_map):
2984 Don't assume fixnums fit in int.
2985 (compare_overlay_entries):
2986 Avoid mishandling comparisons due to subtraction overflow.
2987 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2988 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2989 (handle_tool_bar_click):
2990 Use int, not unsigned, since we prefer signed and the signedness
2991 doesn't matter here.
2992 (get_next_display_element, next_element_from_display_vector):
2993 Use int, not EMACS_INT, when int is wide enough.
2994 (start_hourglass): Use duration_to_sec_usec to do proper
2995 overflow checking on durations.
2996 * xfaces.c (Fbitmap_spec_p):
2997 Check that fixnums are in proper range for system types.
2998 (compare_fonts_by_sort_order):
2999 Avoid mishandling comparisons due to subtraction overflow.
3000 (Fx_family_fonts, realize_basic_faces):
3001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3002 (Fx_family_fonts):
3003 Don't assume fixnum fits in int.
3004 Use SAFE_ALLOCA_LISP, not alloca.
3005 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3006 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3007 (face_at_buffer_position, face_for_overlay_string)
3008 (face_at_string_position):
3009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3010 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3011 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3012 (Fx_show_tip):
3013 Check that fixnums are in proper range for system types.
3014 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3015 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3017 (Fx_change_window_property): Don't assume fixnums fit in int.
3018 * xfont.c (xfont_chars_supported):
3019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3020 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3021 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3023 * xml.c (parse_region):
3024 * xrdb.c (magic_file_p):
3025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3026 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3027 (x_get_local_selection, x_reply_selection_request)
3028 (x_handle_selection_request, wait_for_property_change):
3029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3030 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3031 short is wide enough.
3032 (x_send_client_event): Don't assume fixnum fits in int.
3033 * xterm.c (x_x_to_emacs_modifiers):
3034 Don't assume EMACS_INT overflows nicely into int.
3035 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3036 may come from Lisp.
3037 (handle_one_xevent): NATNUMP can eval its arg twice.
3038 (x_connection_closed):
3039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3040 * xterm.h: Adjust decls to match defn changes elsewhere.
3041 (struct scroll_bar): Use struct vectorlike_header
3042 rather than rolling our own approximation.
3043 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3044
c6574eb5
GM
30452012-05-25 Glenn Morris <rgm@gnu.org>
3046
3047 * lisp.mk (lisp): Update for more files being compiled now.
3048
e8d32c7e
SM
30492012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3050
48def666
SM
3051 * lread.c: Remove `read_pure' which makes no difference.
3052 (read_pure): Remove var.
3053 (unreadpure): Remove function.
3054 (readevalloop): Don't call read_list with -1 flag.
3055 (read1, read_vector): Don't test read_pure any more.
3056 (read_list): Simplify.
3057
e8d32c7e
SM
3058 * fileio.c, character.h: Minor style tweaks.
3059
4b2addb7
DA
30602012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3061
3062 * window.h (clip_changed): Remove useless declaration.
3063
584461b2
JB
30642012-05-22 Juanma Barranquero <lekktu@gmail.com>
3065
3066 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3067 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3068
34374650
PE
30692012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 Remove src/m/*.
3072 This directory predates autoconf and is no longer needed nowadays.
3073 Move its few remaining bits of functionality to where they're needed.
3074 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3075 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3076 * m/template.h: Remove.
3077 * Makefile.in (M_FILE): Remove. All uses removed.
3078 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3079 * lisp.h (USE_LSB_TAG):
3080 * mem-limits.h (EXCEEDS_LISP_PTR):
3081 Use VAL_MAX, not VALBITS, in #if.
3082 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3083 (EMACS_UINT): Define unconditionally now.
3084 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3085 (BITS_PER_EMACS_INT): New constants, replacing
3086 what used to be in config.h, but not useful in #if.
3087 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3088 define them any more.
3089 (VAL_MAX): New macro.
3090 (VALMASK): Use it.
3091 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3092 BITS_PER_EMACS_INT, in #if.
3093 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3094 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3095 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3096 * s/ms-w32.h (DATA_START):
3097 Move here from removed file m/intel386.h.
3098 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3099 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3100
261cb4bb
PE
31012012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3102
3103 Assume C89 or later.
3104 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3105 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3106 (xrealloc):
3107 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3108 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3109 * textprop.c, tparam.c (NULL): Remove.
3110 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3111 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3112 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3113 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3114 * xterm.c (input_signal_count): Assume volatile works.
3115
ff23cd9f
KB
31162012-05-21 Ken Brown <kbrown@cornell.edu>
3117
3118 * xgselect.c (xg_select): Fix first argument in call to 'select'
3119 (bug#11508).
3120
1b170bc6
KB
31212012-05-20 Ken Brown <kbrown@cornell.edu>
3122
3123 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3124 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3125
b2f4d39f
KB
31262012-05-19 Ken Brown <kbrown@cornell.edu>
3127
3128 * xfns.c (x_in_use): Remove `static' qualifier.
3129 * xterm.h (x_in_use): Declare.
3130 * xgselect.c: Include xterm.h.
3131 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3132 and `display_arg' (bug#9754).
3133
003fdae2
PE
31342012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3135
9232a6d9
PE
3136 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3137
003fdae2
PE
3138 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3139 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3140
784b56e2
EZ
31412012-05-18 Eli Zaretskii <eliz@gnu.org>
3142
3143 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3144
3145 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3146 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3147
3148 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3149 reference to image_cache->refcount.
3150 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3151
a0a79cde
JL
31522012-05-17 Juri Linkov <juri@jurta.org>
3153
3154 * search.c (Fword_search_regexp, Fword_search_backward)
3155 (Fword_search_forward, Fword_search_backward_lax)
3156 (Fword_search_forward_lax): Move functions to isearch.el
3157 (bug#10145, bug#11381).
3158
b0572523
PE
31592012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3162
9660f5fc
SM
31632012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3164
3165 * lread.c (init_obarray): Declare Qt and Qnil as special.
3166
4374de83
GM
31672012-05-14 Glenn Morris <rgm@gnu.org>
3168
3169 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3170 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3171
dc44c39a
PE
31722012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3173
078c97cb
PE
3174 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3175
dc44c39a
PE
3176 * unexaix.c: Port to more-recent AIX compilers.
3177 (report_error, report_error_1, make_hdr, copy_sym)
3178 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3179 Make arguments const char *, not char *, to avoid violations of C
3180 standard and to fix some AIX warnings reported by Gilles Pion.
3181
e18afed7 31822012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3183
3184 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3185 already have overlays loaded.
3186 (handle_single_display_spec): Before returning without displaying
3187 fringe bitmap, synchronize the bidi iterator with the main display
3188 iterator, by calling iterate_out_of_display_property.
3189 (iterate_out_of_display_property): Detect buffer iteration by
3190 testing that it->string is a Lisp string.
3191 (get_next_display_element): When the current object is exhausted,
3192 and there's something on it->stack, call set_iterator_to_next to
3193 proceed with what's on the stack, instead of returning zero.
3194 (set_iterator_to_next): If called at the end of a Lisp string,
3195 proceed to consider_string_end without incrementing string
3196 position. Don't increment display vector index past the end of
3197 the display vector. (Bug#11417)
c8fb9dc6
EZ
3198 (pos_visible_p): Don't report a position visible when move_it_to
3199 stopped at the last line of window, which happens to be scanned
3200 backwards by the bidi iteration. (Bug#11464)
ac268e67 3201
e18afed7 32022012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3203
3204 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3205 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3206 are on a TTY, and thus unable to display on the fringes.
3207 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3208 so we need to signal to the caller that this is a "replacing"
3209 display spec. This fixes display when the spec is invalid or we
3210 are on a TTY.
3211
e18afed7 32122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3213
3214 * unexaix.c (make_hdr): Fix typo in prototype.
3215 This bug broke the build on AIX. Problem reported by Gilles Pion.
3216
9d0a235a
MA
32172012-05-14 Michael Albinus <michael.albinus@gmx.de>
3218
3219 * keyboard.c (kbd_buffer_get_event): Read special events also in
3220 batch mode. (Bug#11415)
3221
9e6b06ed
GM
32222012-05-12 Glenn Morris <rgm@gnu.org>
3223
3224 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3225
c1a1d7a3
EZ
32262012-05-12 Eli Zaretskii <eliz@gnu.org>
3227
3228 * lisp.mk (lisp): Add newcomment.elc.
3229
3fe7cdc8
GM
32302012-05-12 Glenn Morris <rgm@gnu.org>
3231
3232 * Makefile.in (MKDIR_P): New, set by configure.
3233 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3234
53f7d2c0
PE
32352012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 Remove unused function hourglass_started.
3238 * dispextern.h (hourglass_started):
3239 * w32fns.c (hourglass_started):
3240 * xdisp.c (hourglass_started): Remove.
3241
75aafb17
JB
32422012-05-10 Juanma Barranquero <lekktu@gmail.com>
3243
3244 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3245 Update dependencies.
3246
12959e8e
PE
32472012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3248
97107e2e
PE
3249 * xgselect.c (xg_select): Put maxfds+1 into a var.
3250 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3251
12959e8e
PE
3252 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3253
836d29b3
DA
32542012-05-10 Dave Abrahams <dave@boostpro.com>
3255
3256 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3257 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3258
5cb67954
MA
32592012-05-09 Michael Albinus <michael.albinus@gmx.de>
3260
3261 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3262 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3263 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3264 Initialize xd_registered_buses.
3265
3478ec45
PE
32662012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3267
b263a6b0
PE
3268 Untag more efficiently if USE_LSB_TAG.
3269 This is based on a proposal by YAMAMOTO Mitsuharu in
3270 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3271 For an admittedly artificial (nth 8000 longlist) benchmark on
3272 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3273 Emacs's overall text size by 1%.
3274 * lisp.h (XUNTAG): New macro.
3275 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3276 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3277 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3278 * eval.c (Fautoload):
3279 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3280 * frame.h (XFRAME): Use XUNTAG.
3281
3478ec45
PE
3282 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3283 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3284 Remove unportable assumptions about print widths of types like
3285 dbus_uint32_t.
3286 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3287 intptr_t when converting between pointer and integer, to avoid GCC
3288 warnings about wrong width.
3289
666b903b 32902012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3291
3292 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3293 stack for each reader_thread, instead of defaulting to 8MB
3294 determined by the linker. This avoids failures in creating
3295 subprocesses on Windows 7, see the discussion in this thread:
3296 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3297
b120cc17
JC
32982012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3299
3300 Fix up display of the *Minibuf-0* buffer in the mini window.
3301 * keyboard.c (read_char): Don't clear the echo area if there's no
3302 message to clear.
3303 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3304 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3305
9a4b36f8
MA
33062012-05-07 Michael Albinus <michael.albinus@gmx.de>
3307
3308 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3309 batch mode.
3310
e5f9458f
CY
33112012-05-06 Chong Yidong <cyd@gnu.org>
3312
3313 * lisp.mk (lisp): Update.
3314
eceeb5fc 33152012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3316
3317 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3318
71873e2b
SM
33192012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3320
3321 * data.c (PUT_ERROR): New macro.
3322 (syms_of_data): Use it. Add new error type `user-error'.
3323 * undo.c (user_error): New function.
3324 (Fprimitive_undo): Use it.
3325 * print.c (print_error_message): Adjust print style for `user-error'.
3326 * keyboard.c (user_error): New function.
3327 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3328
ab0fa4e4
PE
33292012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3330
3331 Do not limit current-time-string to years 1000..9999.
3332 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3333 (Fcurrent_time_string): Support any year that is supported by the
3334 underlying localtime representation. Don't use asctime, as it
3335 has undefined behavior for years outside the range -999..9999.
3336
7ed806a7
PE
33372012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3338
3339 Fix race conditions involving setenv, gmtime, localtime, asctime.
3340 Without this fix, interrupts could mess up code that uses these
3341 nonreentrant functions, since setting TZ invalidates existing
3342 tm_zone or tzname values, and since most of these functions return
3343 pointers to static storage.
3344 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3345 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3346 Grow the critical sections to include not just invoking
3347 localtime/gmtime, but also accessing these functions' results
3348 including their tm_zone values if any, and any related TZ setting.
3349 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3350 so that the struct tm is saved in the critical section.
3351 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3352 motivated by the fact that memory allocation needs to be outside
3353 the critical section.
3354
0c16dfed
DA
33552012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3356
3357 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3358 with RESET_INTERVAL.
3359
3360 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3361 Remove duplicated buffer name initialization.
3362
3f83ace8
JM
33632012-05-02 Jim Meyering <jim@meyering.net>
3364
3365 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3366
c7b8541e
JM
3367 * xfns.c (x_window): Use xstrdup (Bug#11375).
3368
90207a15 33692012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3370
3371 * xdisp.c (pos_visible_p): If already at a newline from the
3372 display string before the 'while' loop, don't walk back the glyphs
3373 from it3.glyph_row. Solves assertion violation when the display
3374 string begins with a newline (egg.el). (Bug#11367)
3375
b593d6a9
AH
33762012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3377
3378 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3379 Move to simple.el.
3380
4737362e
GM
33812012-05-01 Glenn Morris <rgm@gnu.org>
3382
99cf43f9
GM
3383 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3384 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3385 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3386 All were removed before 23.1.
3387
9311dcff
GM
3388 * dispnew.c: Remove HAVE_LIBNCURSES test;
3389 it is always true on relevant platforms.
3390
4d5c6349
GM
3391 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3392 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3393
4737362e
GM
3394 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3395
74dd3a6b
AS
33962012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3397
3398 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3399 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3400 Remove.
3401
13c379ee
PE
34022012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 Do not avoid creating empty evaporating overlays (Bug#9642).
3405 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3406 That is, do not delete an evaporating overlay if it becomes
3407 empty after its bounds are adjusted to fit within its buffer.
3408 This fix caused other problems, and I'm reverting it until we get
3409 to the bottom of them.
3410
a8e7d6d7 34112012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3412
3413 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3414
a8e7d6d7 34152012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3416
3417 * xdisp.c (pos_visible_p): If the window start position is beyond
3418 ZV, start the display from buffer beginning. Prevents assertion
3419 violation in init_iterator when the minibuffer window is scrolled
3420 via the scroll bar.
3421
3422 * window.c (window_scroll_pixel_based): Likewise.
3423
a8e7d6d7 34242012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3425
3426 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3427
a8e7d6d7 34282012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3429
3430 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3431 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3432
a8e7d6d7 34332012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3434
b593d6a9
AH
3435 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3436 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3437
1c6900d9
EZ
34382012-04-26 Eli Zaretskii <eliz@gnu.org>
3439
4c3fa1d9
EZ
3440 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3441 display element, check also the underlying string or buffer
3442 character. (Bug#11341)
3443
1c6900d9
EZ
3444 * w32menu.c: Include w32heap.h.
3445 (add_menu_item): If the call to AppendMenuW (via
3446 unicode_append_menu) fails, disable Unicode menus only if we are
3447 running on Windows 9X/Me.
3448
42bf8205
AS
34492012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3450
3451 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3452 (xgetint): Add missing shift for LSB tags.
3453
b1bac16e
MR
34542012-04-24 Martin Rudalics <rudalics@gmx.at>
3455
3456 * keyboard.c (read_char): Don't wipe echo area for select window
3457 events: These might get delayed via `mouse-autoselect-window'
3458 (Bug#11304).
3459
d69621cc
JB
34602012-04-24 Juanma Barranquero <lekktu@gmail.com>
3461
3462 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3463 manipulation of :loaded-from data.
3464
02fd101b
JB
34652012-04-23 Juanma Barranquero <lekktu@gmail.com>
3466
3467 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3468 now a cons (bug#11311).
3469
888bec30
PE
34702012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3471
89a438bd
PE
3472 Do not create empty overlays with the evaporate property (Bug#9642).
3473 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3474 if it becomes empty after its bounds are adjusted to fit within
3475 its buffer. Without this fix, in a nonempty buffer (let ((o
3476 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3477 yields an empty overlay that has the evaporate property, which is
3478 not supposed to happen.
3479
1068fe4d
PE
3480 Fix minor GTK3 problems found by static checking.
3481 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3482 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3483 (struct _EmacsFixedClass, emacs_fixed_get_type):
3484 Move decls here from emacsgtkfixed.h, since they needn't be public.
3485 (emacs_fixed_get_type): Now static.
3486 (emacs_fixed_class_init): Omit unused local.
3487 (emacs_fixed_child_type): Remove; unused.
3488 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3489 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3490 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3491 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3492 (EMACS_FIXED_GET_CLASS): Remove; unused.
3493 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3494
888bec30
PE
3495 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3496 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3497
de85e130
PE
34982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3499
d0baac98 3500 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3501 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3502 (__malloc_size_t, __malloc_ptrdiff_t):
3503 Remove. All uses removed, replaced by the definiens if needed,
3504 since we can assume C89 or better now.
3505 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3506 (protect_malloc_state, align, get_contiguous_space)
3507 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3508 (malloc_atfork_handler_child, malloc_enable_thread)
3509 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3510 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3511 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3512 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3513 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3514 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3515 Define using prototypes, not old style.
3516 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3517 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3518 (align): Don't assume that signed integer overflow wraps around.
3519 Omit unused local var.
3520 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3521 (_free_internal_nolock, memalign, mallochook, reallochook):
3522 Omit no-longer-needed casts.
3523 (valloc): Use getpagesize, not __getpagesize.
3524 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3525 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3526
de85e130
PE
3527 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3528
dcbf5805
MA
35292012-04-22 Michael Albinus <michael.albinus@gmx.de>
3530
3531 Move functions from C to Lisp. Make non-blocking method calls
3532 the default. Implement further D-Bus standard interfaces.
3533
3534 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3535 (QCdbus_request_name_allow_replacement)
3536 (QCdbus_request_name_replace_existing)
3537 (QCdbus_request_name_do_not_queue)
3538 (QCdbus_request_name_reply_primary_owner)
3539 (QCdbus_request_name_reply_in_queue)
3540 (QCdbus_request_name_reply_exists)
3541 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3542 (QCdbus_registered_serial, QCdbus_registered_method)
3543 (QCdbus_registered_signal): New Lisp objects.
3544 (XD_DEBUG_MESSAGE): Use sizeof.
3545 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3546 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3547 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3548 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3549 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3550 (xd_signature, xd_append_arg): Allow float for integer types.
3551 (xd_get_connection_references): New function.
b593d6a9
AH
3552 (xd_get_connection_address): Rename from xd_initialize.
3553 Return cached address.
dcbf5805
MA
3554 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3555 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3556 level.
3557 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3558 Return number of refcounts.
dcbf5805
MA
3559 (Fdbus_get_unique_name): Make stronger parameter check.
3560 (Fdbus_message_internal): New defun.
3561 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3562 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3563 (Fdbus_send_signal, Fdbus_register_service)
3564 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3565 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3566 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3567 (Vdbus_compiled_version, Vdbus_runtime_version)
3568 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3569 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3570 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3571 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3572 Adapt docstring.
dcbf5805 3573
52828e02
PE
35742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3575
da05bc4c
PE
3576 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3577 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3578 Do not assume ptrdiff_t is the same width as 'int'.
3579
52828e02
PE
3580 * alloc.c: Handle unusual debugging option combinations.
3581 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3582 since the two debugging options are incompatible.
3583 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3584 is defined.
3585 (mem_init, mem_insert, mem_insert_fixup):
3586 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3587 (NEED_MEM_INSERT): Remove; no longer needed.
3588
f01769f9
LL
35892012-04-22 Leo Liu <sdl.web@gmail.com>
3590
3591 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3592
5790543d
PE
35932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3594
3595 * sysdep.c [__FreeBSD__]: Minor cleanups.
3596 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3597 Use Emacs indenting style more consistently. Avoid some casts.
3598 Use 'double' consistently rather than mixing 'float' and 'double'.
3599
b91b7e4d
EW
36002012-04-21 Eduard Wiebe <usenet@pusto.de>
3601
b593d6a9
AH
3602 * sysdep.c (list_system_processes, system_process_attributes):
3603 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3604
6114eb15
AS
36052012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3606
3607 * lisp.mk (lisp): Update.
3608
2f38dff7
PE
36092012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3610
3611 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3612 It is never used otherwise.
3613
4ae29f89
SM
36142012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3615
3616 * print.c (print_preprocess): Only check print_depth if print-circle
3617 is nil.
3618 (print_object): Check for cycles even when print-circle is nil and
3619 print-gensym is t, but only check print_depth if print-circle is nil.
3620
f30d612a
CY
36212012-04-20 Chong Yidong <cyd@gnu.org>
3622
3623 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3624 set the status to "failed" and ensure that sentinel is run.
3625
c07a4c0b 36262012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3627
3628 * process.c (Fset_process_inherit_coding_system_flag)
3629 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3630 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3631
c07a4c0b 36322012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3633
3634 * xdisp.c (string_buffer_position_lim): Limit starting position to
3635 BEGV.
3636 (set_cursor_from_row): If called for a mode-line or header-line
3637 row, return zero immediately.
3638 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3639 farther than the first row after the header line, if any.
3640 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3641 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3642
c07a4c0b 36432012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3644
4ae29f89
SM
3645 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3646 (bug#11238).
ad3a2b41 3647
c07a4c0b 36482012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36492012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3650
3651 configure: new option --enable-gcc-warnings (Bug#11207)
3652 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3653 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3654 (ALL_CFLAGS): Use new macros rather than old.
3655 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3656 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3657 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3658 -Wunused-result, -Wunused-variable. This should go away once
3659 the Emacs and Gnulib regex code is merged.
3660 (xmalloc, xrealloc): Now static.
3661
aba027e8
PE
36622012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3663
3664 * dired.c (Fsystem_groups): Remove unused local.
3665
e5a36063
GM
36662012-04-17 Glenn Morris <rgm@gnu.org>
3667
3668 * dired.c (Fsystem_users): Doc fix.
3669
316411f0
DA
36702012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3671
3672 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3673 (syms_of_dired): Add them.
3674
9426aba4
PE
36752012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3676
b62a57be
PE
3677 Fix minor alloc.c problems found by static checking.
3678 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3679 New extern decls, to avoid calling undeclared functions.
3680 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3681 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3682 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3683 (NEED_MEM_INSERT): New macro.
3684 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3685 Remove one incorrect comment and fix another.
b62a57be 3686
3539f31f
PE
3687 Fix minor ralloc.c problems found by static checking.
3688 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3689 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3690 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3691 (r_alloc_sbrk): Now static.
3692
a041960a
PE
3693 Improve ralloc.c interface checking.
3694 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3695 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3696 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3697 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3698 [REL_ALLOC]: ... to here, to check interface.
3699 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3700 Remove decls. This fixes an "It stinks!".
3701
9426aba4
PE
3702 * alloc.c (which_symbols): Fix alignment issue / type clash.
3703
d55c12ed
AS
37042012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3705
3706 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3707 (struct Lisp_Misc_Any): Likewise.
3708 (struct Lisp_Free): Likewise.
3709 * alloc.c (union aligned_Lisp_Symbol): Define.
3710 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3711 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3712 (union aligned_Lisp_Misc): Define.
3713 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3714 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3715 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3716
b948ce8b
PE
37172012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3718
3719 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3720 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3721 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3722 * s/netbsd.h, s/sol2-6.h:
3723 Remove definition of GC_MARK_STACK, since the default now works.
3724 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3725 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3726 no longer the default.
3727 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3728
35dc09a1 37292012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3730
35dc09a1
GM
3731 * lread.c (lisp_file_lexically_bound_p):
3732 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3733
35dc09a1
GM
37342012-04-14 Eli Zaretskii <eliz@gnu.org>
3735
3736 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3737 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3738
37392012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3740
3741 * nsterm.m (constrainFrameRect): Always constrain when there is only
3742 one screen (Bug#10962).
3743
bcd86815
KB
37442012-04-13 Ken Brown <kbrown@cornell.edu>
3745
3746 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3747
c25df26e
RT
37482012-04-13 Reuben Thomas <rrt@sc3d.org>
3749
3750 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3751
0fc59f1e
DC
37522012-04-11 Daniel Colascione <dancol@dancol.org>
3753
3754 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3755 against is gone. It's better to use vfork now so that when Cygwin
3756 gains a new, working vfork, we use it automatically (bug#10398).
3757
de8c03dc
SM
37582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3759
3760 * window.c (save_window_save): Obey window-point-insertion-type.
3761
2f097256
GM
37622012-04-11 Glenn Morris <rgm@gnu.org>
3763
3764 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3765
453b951e
SM
37662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3767
3768 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3769
75f1671a 37702012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3771
3772 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3773 (force_quit_count): New var.
3774 (handle_interrupt): Use it.
3775
2a8ce227
JB
37762012-04-10 Juanma Barranquero <lekktu@gmail.com>
3777
3778 * w32.c (w32_delayed_load): Record the full path of the library
3779 being loaded (bug#10424).
3780
935396c0
GM
37812012-04-09 Glenn Morris <rgm@gnu.org>
3782
05920a43
GM
3783 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3784 not just in the obarray, before snarfing them. (Bug#11036)
3785
935396c0
GM
3786 * Makefile.in ($(leimdir)/leim-list.el):
3787 Pass EMACS rather than BUILT_EMACS.
3788
a18ecafa
TZ
37892012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3790
3791 * process.c (make_process):
3792 * process.h: Add integer `gnutls_handshakes_tried' member to
3793 process struct.
3794
6bbef4e5
JC
3795 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3796 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3797
3798 * gnutls.c (gnutls_log_function2i): Convenience log function.
3799 (emacs_gnutls_read): Use new log functions,
3800 `gnutls_handshakes_tried' process member, and
3801 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3802 attempts per process (connection).
3803
b4d3bc10
CY
38042012-04-09 Chong Yidong <cyd@gnu.org>
3805
3806 * eval.c (Fuser_variable_p, user_variable_p_eh)
3807 (lisp_indirect_variable): Functions deleted.
3808 (Fdefvar): Caller changed.
3809
3810 * callint.c (Finteractive, Fcall_interactively):
3811 * minibuf.c (Fread_variable): Callers changed.
3812
70f4d973
EZ
38132012-04-09 Eli Zaretskii <eliz@gnu.org>
3814
3815 * xdisp.c (set_cursor_from_row): If the display string appears in
3816 the buffer at position that is closer to point than the position
3817 after the display string, display the cursor on the first glyph of
3818 the display string. Fixes cursor display when a 'display' text
3819 property immediately follows invisible text. (Bug#11094)
3820
cb3c2e3e
PE
38212012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 composite.c: use 'double' consistently
3824 * composite.c (get_composition_id): Use 'double' consistently
3825 instead of converting 'float' to 'double' and vice versa; this is
3826 easier to understand and avoids a GCC warning.
3827
fd06db5d
GM
38282012-04-09 Glenn Morris <rgm@gnu.org>
3829
50fe702a
GM
3830 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3831 preparation for dumping it with emacs. (Bug#4789)
3832 (leimdir): New variable.
3833 ($(leimdir)/leim-list.el): New rule.
3834 (emacs$(EXEEXT)): Depend on leim-list.el.
3835
fd06db5d
GM
3836 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3837 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3838 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3839
55c131ee
AS
38402012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3841
3842 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3843 proper alignment.
3844
9209588f
JB
38452012-04-07 Juanma Barranquero <lekktu@gmail.com>
3846
3847 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3848 Remove unused local variable.
3849
e3fb2efb
PE
38502012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3851
3852 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3853 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3854 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3855 objects, as mark_maybe_pointer will catch them otherwise.
3856 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3857 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3858
b5385551
PE
38592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3860
3861 Fix typo that broke non-Windows builds.
3862 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3863
9078ead6
EZ
38642012-04-07 Eli Zaretskii <eliz@gnu.org>
3865
3866 Support building on MS-Windows with libxml2.
3867
3868 * makefile.w32-in (OBJ2): Add xml.$(O).
3869 (GLOBAL_SOURCES): Add xml.c.
3870 ($(BLD)/xml.$(O)): New dependency list.
3871
3872 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3873 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3874 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3875 [!WINDOWSNT]: New macros.
3876 (init_libxml2_functions, libxml2_loaded_p): New functions.
3877 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3878 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3879 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3880 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3881 linked in).
6bbef4e5
JC
3882 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3883 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3884 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3885
3886 * emacs.c: Don't include libxml/parser.h.
3887 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3888 xmlCleanupParser directly.
3889
3890 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3891
3811fdf3
EZ
38922012-04-07 Eli Zaretskii <eliz@gnu.org>
3893
3894 * indent.c (Fvertical_motion): If there is a display string at
3895 point, use it.vpos to compute how many lines to backtrack after
3896 move_it_to point. (Bug#11133)
3897
2f8e16b2
EZ
38982012-04-06 Eli Zaretskii <eliz@gnu.org>
3899
3900 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3901 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3902 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3903 macros related to unification of CJK characters. For the details,
3904 see the discussion following the message here:
3905 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3906
3d439cd1
CY
39072012-04-04 Chong Yidong <cyd@gnu.org>
3908
3909 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3910
8bc53d00
EZ
39112012-04-01 Eli Zaretskii <eliz@gnu.org>
3912
3913 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3914 instead of alloca. (Bug#11138)
3915
3b0512a3
AS
39162012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3917
3918 * w32menu.c (is_simple_dialog): Properly check lisp types.
3919 (Bug#11141)
3920
8427ddd2
EZ
39212012-03-31 Eli Zaretskii <eliz@gnu.org>
3922
979022ef
EZ
3923 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3924 position we get to after a call to move_it_to fails the
3925 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3926 only if we wind up in a string from display property. (Bug#11063)
3927
a6b1c7cc
EZ
3928 * window.c (Fdelete_other_windows_internal): Invalidate the row
3929 and column information about mouse highlight, so that redisplay
3930 restores it after reallocating the glyph matrices. (Bug#7464)
3931
8427ddd2
EZ
3932 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3933 string comes from a `display' text property, use the buffer
3934 position of that property as if we actually saw that position in
3935 the row's glyphs.
697ba24b
EZ
3936 (move_it_by_lines): Remove the assertion that
3937 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3938 violated when there's a before-string at the beginning of a line.
3939 (Bug#11063)
8427ddd2 3940
65a0a738
EZ
39412012-03-30 Eli Zaretskii <eliz@gnu.org>
3942
3943 * xdisp.c (append_space_for_newline): If the default face was
3944 remapped, use the remapped face for the appended newline.
3945 (extend_face_to_end_of_line): Use the remapped default face for
3946 extending the face to the end of the line.
3947 (display_line): Call extend_face_to_end_of_line when the default
3948 face was remapped. (Bug#11068)
3949
581355cc
EZ
39502012-03-29 Eli Zaretskii <eliz@gnu.org>
3951
3952 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3953
e8fc049f
SM
39542012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3955
3956 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3957
4fb9a543
GM
39582012-03-27 Glenn Morris <rgm@gnu.org>
3959
3960 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3961 Doc fixes.
3962
679910f1
KH
39632012-03-26 Kenichi Handa <handa@m17n.org>
3964
3965 * dispextern.h (struct glyph): Fix previous change. Change the
3966 bit length of glyphless.ch to 25 (Bug#11082).
3967
90d49b7f
CY
39682012-03-26 Chong Yidong <cyd@gnu.org>
3969
3970 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3971 (command_loop_1): Use it; inhibit selection update for
3972 handle-select-window too (Bug#8996).
3973
f514f6f0
FP
39742012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3975
e8fc049f 3976 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3977
bf43fa51
KH
39782012-03-25 Kenichi Handa <handa@m17n.org>
3979
3980 * dispextern.h (struct glyph): Change the bit length of
3981 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3982
8a0c01dd
EZ
39832012-03-24 Eli Zaretskii <eliz@gnu.org>
3984
3985 * s/ms-w32.h (tzname): Include time.h before redirecting to
3986 _tzname. Fixes the MSVC build. (Bug#9960)
3987
7d1c3a76
AS
39882012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3989
8ed79523
AS
3990 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3991 characters.
3992
7d1c3a76
AS
3993 * xterm.c (XTread_socket): Only modify handling_signal if
3994 !SYNC_INPUT. (Bug#11080)
3995
e99a9b8b
EZ
39962012-03-23 Eli Zaretskii <eliz@gnu.org>
3997
3998 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3999 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4000 when fetching a multibyte character consumes more bytes than
4001 CHAR_BYTES returns, due to unification of CJK characters in
4002 string_char. (Bug#11073)
4003
5063c0e1
TN
40042012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4005
4006 * process.c (wait_reading_process_output): Handle pty disconnect
4007 by refraining from sending oneself a SIGCHLD (bug#10933).
4008
9f851fbd
CY
40092012-03-22 Chong Yidong <cyd@gnu.org>
4010
4011 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4012
5063c0e1 4013 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4014 Mark string as coming from a prefix property.
4015 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4016 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4017
fb5b8aca
CY
40182012-03-21 Chong Yidong <cyd@gnu.org>
4019
4020 * xfaces.c (Vface_remapping_alist): Doc fix.
4021
62356a1b
EZ
40222012-03-20 Eli Zaretskii <eliz@gnu.org>
4023
4024 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4025 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4026 Doc fixes.
62356a1b 4027
025de85b
CY
40282012-03-20 Chong Yidong <cyd@gnu.org>
4029
4030 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4031 to reflect default non-nil value of redisplay-dont-pause.
4032
4827f94e
KH
40332012-03-19 Kenichi Handa <handa@m17n.org>
4034
4035 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4036 it fit in a valid range (Bug#11003).
4037
e50a24a2
EZ
40382012-03-18 Eli Zaretskii <eliz@gnu.org>
4039
4040 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4041 that is not from display property, accept the row as a "cursor
4042 row" if one of the string's character has a non-nil `cursor'
4043 property. Fixes cursor positioning when there are newlines in
4044 overlay strings, e.g. in icomplete.el. (Bug#11035)
4045
9af5ed87
PE
40462012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4047
4048 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4049
d1f55f16
CY
40502012-03-12 Chong Yidong <cyd@gnu.org>
4051
4052 * eval.c (inhibit_lisp_code): Rename from
4053 inhibit_window_configuration_change_hook; move from window.c.
4054
4055 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4056 * window.c (run_window_configuration_change_hook)
4057 (syms_of_window): Callers changed.
4058
66c5eebd
CY
40592012-03-11 Chong Yidong <cyd@gnu.org>
4060
413df973
CY
4061 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4062
66c5eebd
CY
4063 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4064
1de11f56
CY
40652012-03-10 Chong Yidong <cyd@gnu.org>
4066
4067 * frame.c (other_visible_frames): Don't assume the selected frame
4068 is visible (Bug#10955).
4069
cae07000
SM
40702012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4071
4072 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4073
89c94350
JD
40742012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4075
4076 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4077 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4078 zero (Bug#10954).
4079
999dd333
GM
40802012-03-03 Glenn Morris <rgm@gnu.org>
4081
01a6dcc8 4082 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4083
de0100f2
EZ
40842012-03-02 Eli Zaretskii <eliz@gnu.org>
4085
4086 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4087 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4088 (redisplay_window, next_element_from_string): Fix typos in
4089 comments.
3e441275
EZ
4090 (redisplay_window): Pass to move_it_vertically the margin in
4091 pixels, not in screen lines.
de0100f2 4092
96a72ee9
GM
40932012-03-02 Glenn Morris <rgm@gnu.org>
4094
4095 * buffer.c (buffer-list-update-hook): Doc fix.
4096
312508d7
EZ
40972012-02-29 Eli Zaretskii <eliz@gnu.org>
4098
4099 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4100 push_it before setting up the iterator for the first overlay
4101 string, even if we have an empty string loaded.
4102 (next_overlay_string): If there's an empty string on the iterator
4103 stack, pop the stack. (Bug#10903)
4104
27f3c637
PE
41052012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4106
4107 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4108 Suggested by Stefan Monnier in
4109 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4110 * alloc.c (widen_to_Lisp_Object): New static function.
4111 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4112 and widening them to Lisp_Objects. This would work even if
4113 USE_LSB_TAG is defined and wide integers are used, which might
4114 happen in a future version of Emacs.
4115
3c9dfce6
CY
41162012-02-25 Chong Yidong <cyd@gnu.org>
4117
fa74b241
CY
4118 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4119 Doc fix.
4120
3c9dfce6
CY
4121 * xselect.c (Fx_selection_exists_p): Doc fix.
4122 (x_clipboard_manager_save_all): Print an informative message
4123 before saving to clipboard manager.
4124
9486df08
CY
41252012-02-24 Chong Yidong <cyd@gnu.org>
4126
4127 * keyboard.c (process_special_events): Handle all X selection
4128 requests in kbd_buffer, not just the next one (Bug#8869).
4129
f01d3321
CY
41302012-02-23 Chong Yidong <cyd@gnu.org>
4131
4132 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4133 call when setting menu-bar-lines and tool-bar-lines parameters.
4134 (unwind_create_frame_1): New helper function.
4135
4136 * window.c (inhibit_window_configuration_change_hook): New var.
4137 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4138 (syms_of_window): Initialize it.
f01d3321 4139
86b847b6
CY
41402012-02-22 Chong Yidong <cyd@gnu.org>
4141
4142 * xterm.c (x_draw_image_relief): Add missing type check for
4143 Vtool_bar_button_margin (Bug#10743).
4144
a59225b1
CY
41452012-02-21 Chong Yidong <cyd@gnu.org>
4146
4147 * fileio.c (Vfile_name_handler_alist): Doc fix.
4148
4149 * buffer.c (Fget_file_buffer): Protect against invalid file
4150 handler return value.
4151
310f5bd4
PE
41522012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4153
cb3a28cc
PE
4154 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4155 when computing $valmask.
4156
310f5bd4
PE
4157 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4158 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4159 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4160 It's useless in that case, and it can cause problems on hosts
4161 that allocate halves of EMACS_INT values separately.
4162 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4163 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4164 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4165 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4166 it avoids undefined behavior on hosts where shifting right by more
4167 than the word width has undefined behavior.
4168
2375c96a
CY
41692012-02-19 Chong Yidong <cyd@gnu.org>
4170
4171 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4172 (Funhandled_file_name_directory, Ffile_name_as_directory)
4173 (Fdirectory_file_name, Fexpand_file_name)
4174 (Fsubstitute_in_file_name): Protect against invalid file handler
4175 return values (Bug#10845).
4176
3eb49e71
EZ
41772012-02-18 Eli Zaretskii <eliz@gnu.org>
4178
4179 * .gdbinit (pitx): Fix incorrect references to fields of the
4180 iterator stack.
4181
7b926f3f
CY
41822012-02-17 Chong Yidong <cyd@gnu.org>
4183
4184 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4185
11273115
PE
41862012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4187
4188 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4189 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4190
c3a70e2b
CY
41912012-02-15 Chong Yidong <cyd@gnu.org>
4192
4193 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4194 marked as special. Also, starting docstrings with * is obsolete.
4195
0ca43699
AS
41962012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4197
4198 * gnutls.c (emacs_gnutls_write): Fix last change.
4199
2e8f3c56
LI
42002012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4201
4202 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4203 send_process.
4204
af70074f
SM
42052012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4206
4207 * keymap.c (Fsingle_key_description): Handle char ranges.
4208
95986d52
CY
42092012-02-12 Chong Yidong <cyd@gnu.org>
4210
afd83bd1
CY
4211 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4212 as that creates a dangerous corner case.
4213
95986d52
CY
4214 * window.c (Fdelete_window_internal): Invalidate the mouse
4215 highlight (Bug#9904).
4216
bd7da63e
GM
42172012-02-12 Glenn Morris <rgm@gnu.org>
4218
4219 * xselect.c (Fx_own_selection_internal)
4220 (Fx_get_selection_internal, Fx_disown_selection_internal)
4221 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4222 * nsselect.m (Fx_own_selection_internal)
4223 (Fx_disown_selection_internal, Fx_selection_exists_p)
4224 (Fx_selection_owner_p, Fx_get_selection_internal):
4225 Sync docs and argument specs with the xselect.c versions.
4226
77abcbc2
LI
42272012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4228
4229 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4230
90b671e2
EZ
42312012-02-11 Eli Zaretskii <eliz@gnu.org>
4232
1c0ca0b7
EZ
4233 * w32select.c (Fx_selection_exists_p): Sync doc string and
4234 argument list with xselect.c. (Bug#10783)
4235
4236 * w16select.c (Fx_selection_exists_p): Sync doc string and
4237 argument list with xselect.c. (Bug#10783)
90b671e2 4238
49241268
GM
42392012-02-10 Glenn Morris <rgm@gnu.org>
4240
4241 * fns.c (Fsecure_hash): Doc fix.
4242
f998bbe7 42432012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4244
4245 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4246
0992bd9c
CY
42472012-02-07 Chong Yidong <cyd@gnu.org>
4248
4249 * buffer.c (Fbuffer_local_variables)
4250 (buffer_lisp_local_variables): Handle unbound vars correctly;
4251 don't let Qunbound leak into Lisp.
4252
af008560
GM
42532012-02-07 Glenn Morris <rgm@gnu.org>
4254
dd605cc4
GM
4255 * image.c (Fimagemagick_types): Doc fix.
4256
af008560
GM
4257 * image.c (imagemagick-render-type): Change it from a lisp object
4258 to an integer. Move the doc here from the lisp manual.
4259 Treat all values not equal to 0 the same.
4260
1449fa1d
CY
42612012-02-06 Chong Yidong <cyd@gnu.org>
4262
4263 * doc.c (store_function_docstring): Avoid applying docstring of
4264 alias to base function (Bug#2603).
4265
3723ec07
AS
42662012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4267
4268 * .gdbinit (pp1, pv1): Remove redundant defines.
4269 (pr): Use pp.
4270
79c1cc1e
CY
42712012-02-04 Chong Yidong <cyd@gnu.org>
4272
4273 * nsterm.m: Declare a global (Bug#10694).
4274
d7f29f8e
EZ
42752012-02-04 Eli Zaretskii <eliz@gnu.org>
4276
cae07000
SM
4277 * w32.c (get_emacs_configuration_options):
4278 Include --enable-checking, if specified, in the return value.
d7f29f8e 4279
3b95a6f9
MR
42802012-02-04 Martin Rudalics <rudalics@gmx.at>
4281
4282 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4283 after rounding frame sizes. (Bug#9723)
4284
d6fa96a6
EZ
42852012-02-04 Eli Zaretskii <eliz@gnu.org>
4286
4287 * keyboard.c (adjust_point_for_property): Don't position point
4288 before BEGV. (Bug#10696)
4289
df0b2940
PE
42902012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 Handle overflow when computing char display width (Bug#9496).
4293 * character.c (char_width): Return EMACS_INT, not int.
4294 (char_width, c_string_width): Check for overflow when
4295 computing the width; this is possible now that individual
4296 characters can have unbounded width. Problem introduced
4297 by merge from Emacs 23 on 2012-01-19.
4298
6bee44d6
MA
42992012-02-02 Michael Albinus <michael.albinus@gmx.de>
4300
4301 * dbusbind.c (Fdbus_register_method): Mention the return value
4302 :ignore in the docstring.
4303
44f92739
GM
43042012-02-02 Glenn Morris <rgm@gnu.org>
4305
1b9f60cc
GM
4306 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4307
44f92739
GM
4308 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4309 Unconditionally set to t. (Bug#10673)
4310 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4311 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4312 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4313
c5d3843c
KH
43142012-02-02 Kenichi Handa <handa@m17n.org>
4315
4316 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4317 0, do not call append_composite_glyph.
4318
159462d4 43192012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4320
4321 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4322 NULL (Bug#6988).
4323 (x_produce_glyphs): If the component of a composition is a null
4324 string, set it->pixel_width to 1 to avoid zero-width glyph.
4325
78cef877
EZ
43262012-02-01 Eli Zaretskii <eliz@gnu.org>
4327
4328 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4329 first 2 arguments are identical. This makes inserting large
4330 output from a subprocess an order of magnitude faster on
4331 MS-Windows, where all sbrk'ed memory is always contiguous.
4332
97897668
GM
43332012-01-31 Glenn Morris <rgm@gnu.org>
4334
4335 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4336 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4337 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4338
31fd3586
GM
43392012-01-29 Glenn Morris <rgm@gnu.org>
4340
4341 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4342
0e24a8b2
CY
43432012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4344
4345 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4346
cc0adcb0
CY
43472012-01-28 Chong Yidong <cyd@gnu.org>
4348
4349 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4350
acc28cb9
CY
43512012-01-26 Chong Yidong <cyd@gnu.org>
4352
9c69cfb7
CY
4353 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4354
acc28cb9
CY
4355 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4356 repeat counts (Bug#10507).
4357
48da7392
GM
43582012-01-26 Glenn Morris <rgm@gnu.org>
4359
4360 * lread.c (syms_of_lread): Doc fix.
4361
14af5f7f
CY
43622012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4363
4364 * coding.c (encode_designation_at_bol): Change return value to
4365 EMACS_INT.
4366
0b21c100
CY
43672012-01-25 Chong Yidong <cyd@gnu.org>
4368
4369 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4370
3c2907f7
CY
43712012-01-21 Chong Yidong <cyd@gnu.org>
4372
4373 * floatfns.c (Fcopysign): Make the second argument non-optional,
4374 since nil is not allowed anyway.
4375
959ad23f
AS
43762012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4377
4378 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4379 (send_process): Likewise.
4380
34a02f46
MR
43812012-01-19 Martin Rudalics <rudalics@gmx.at>
4382
4383 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4384 (Vwindow_persistent_parameters): Do not use Qstate.
4385 Rewrite doc-strings.
34a02f46 4386
1259009a 43872012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4388
4389 * character.c (char_width): New function.
70d4fdf6
GM
4390 (Fchar_width, c_string_width, lisp_string_width):
4391 Use char_width (Bug#9496).
25ed9e61 4392
6a6ee00d
MR
43932012-01-16 Martin Rudalics <rudalics@gmx.at>
4394
4395 * window.c (Vwindow_persistent_parameters): New variable.
4396 (Fset_window_configuration, save_window_save): Handle persistent
4397 window parameters.
4398
c85efaf7
EZ
43992012-01-14 Eli Zaretskii <eliz@gnu.org>
4400
4401 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4402 thrashing the stack of the thread. (Bug#9087)
4403
5944709e
PE
44042012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4405
4406 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4407
e71f5d99
EZ
44082012-01-11 Eli Zaretskii <eliz@gnu.org>
4409
4410 * xdisp.c (rows_from_pos_range): Handle the case where the
4411 highlight ends on a newline. (Bug#10464)
4412 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4413 he end column for display of highlight that ends on a newline
4414 before a R2L line.
4415
ce316182
GM
44162012-01-11 Glenn Morris <rgm@gnu.org>
4417
4418 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4419 from load-path also when installation-directory is nil. (Bug#10208)
4420
5b43da69
GM
44212012-01-10 Glenn Morris <rgm@gnu.org>
4422
74cc8ff9
GM
4423 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4424
7d8d6e4e
GM
4425 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4426 Update template values to be closer to their typical values these days.
5b43da69 4427
a0db8d43
EZ
44282012-01-09 Eli Zaretskii <eliz@gnu.org>
4429
4430 * xdisp.c (rows_from_pos_range): Accept additional argument
4431 DISP_STRING, and accept any glyph in a row whose object is that
4432 string as eligible for mouse highlight. Fixes mouse highlight of
4433 display strings from overlays. (Bug#10464)
4434
9a0115ab 44352012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4436
b9110d6a 4437 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4438 * fileio.c (auto_saving_dir_umask): New static var.
4439 (Fmake_directory_internal): Use it.
4440 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4441 creating the directory. The old code temporarily assigns
4442 too-generous permissions to the directory.
4443 (do_auto_save_eh): Clear it.
b9110d6a 4444 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4445 that the var is always cleared.
4446
6c1bd3f3
EZ
44472012-01-07 Eli Zaretskii <eliz@gnu.org>
4448
4449 * search.c (scan_buffer): Pass character positions to
4450 know_region_cache, not byte positions. (Bug#6540)
4451
069d2b50
L
44522012-01-07 LynX <_LynX@bk.ru> (tiny change)
4453
4454 * w32.c (sys_rename): Report EXDEV when rename of a directory
4455 fails because the target is on another logical disk. (Bug#10284)
4456
75bf0d33
DB
44572012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4458
4459 * xterm.c (x_embed_request_focus): New function.
4460
4461 * xterm.h: Add prototype.
4462
4463 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4464
1c6e5a32
GM
44652012-01-05 Glenn Morris <rgm@gnu.org>
4466
4467 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4468
651e947e
EZ
44692012-01-01 Eli Zaretskii <eliz@gnu.org>
4470
4471 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4472 Load gnutls_transport_set_lowat only if GnuTLS version is below
4473 2.11.1.
4474 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4475 GnuTLS versions below 2.11.1.
4476
3778cdd8
AL
44772011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4478
4479 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4480 to the doc string advising against its use for altering the way
4481 windows are scrolled.
4482
0e5317f7
KH
44832011-12-28 Kenichi Handa <handa@m17n.org>
4484
4485 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4486 coding-system ASCII compatible only when it does not produce BOM
4487 on encoding (Bug#10383).
4488
93d5ca1f
JD
44892011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4490
4491 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4492 can scroll.
4493 (create_and_show_popup_menu): Always use menu_position_func for
4494 Gtk3 (Bug#10361).
4495
ca22b785
AS
44962011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4497
4498 * callint.c (Fcall_interactively): Don't truncate prompt string.
4499
d048e1e6
EZ
45002011-12-23 Eli Zaretskii <eliz@gnu.org>
4501
4502 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4503 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4504 resumed from there (after widening). (Bug#10360)
d048e1e6 4505
5ccaba1f
JD
45062011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4507
4508 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4509
204ee57f
JD
45102011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4511
b81d40f0
JB
4512 * nsterm.m (x_free_frame_resources):
4513 Release f->output_data.ns->miniimage.
204ee57f
JD
4514 (ns_index_color): Fix indentation. Do not retain
4515 color_table->colors[i].
4516
4517 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4518 before returning.
4519
4520 * nsfns.m (x_set_background_color): Assign return value from
4521 ns_index_color to face-background instead of NSColor*.
4522 (ns_implicitly_set_icon_type): Fix indentation.
4523 Change assignment in for loop to comparison.
4524
4525 * emacs.c (ns_pool): New variable.
4526 (main): Assign ns_pool.
4527 (Fkill_emacs): Call ns_release_autorelease_pool.
4528
4529 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4530 autorelease fdesc, release fdAttrs and tdict.
4531 (ns_get_covering_families): Release charset.
4532 (ns_findfonts): Release NSFontDescriptor created with new.
4533 (ns_uni_to_glyphs): Fix indentation.
4534 (setString): Release attrStr before assigning new value.
4535
c803b2b7
JD
45362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4537
678f4426
JD
4538 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4539 and NS_IMPL_COCOA.
4540 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4541 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4542
cd394be1 45432011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4544
5fecd5fc
JD
4545 * nsterm.m (ns_term_init): Subscribe for notifications
4546 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4547 to method trackingNotification in EmacsMenu.
4548
4549 * nsmenu.m (trackingMenu): New variable.
3771cb17 4550 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4551 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4552 from Aquamacs (Bug#7030).
678f4426
JD
4553
45542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4555
c803b2b7
JD
4556 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4557 (symbol_to_nsstring): Fix indentation.
4558 (ns_symbol_to_pb): New function.
cae07000
SM
4559 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4560 (Fns_rotate_cut_buffers_internal): Remove.
4561 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4562 Fns_store_cut_buffer_internal.
4563 (ns_get_foreign_selection, Fx_own_selection_internal)
4564 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4565 (Fns_get_selection_internal, Fns_store_selection_internal):
4566 Use ns_symbol_to_pb and check if return value is nil.
4567 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4568 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4569 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4570 renamed to Sns_store_selection_internal.
4571 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4572 and remove this function.
4573 (ns_handle_selection_clear): Remove, never used.
4574 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4575 here.
4576
e1b01a3a
KB
45772011-12-17 Ken Brown <kbrown@cornell.edu>
4578
4579 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4580 GID is unknown (Bug#10257).
4581
2adb6e85
PE
45822011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4583
4584 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4585 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4586 which caused a build failure on GNU/Linux IA-64. This problem was
4587 introduced by my 2011-10-07 patch.
4588
d1d7b339
JL
45892011-12-15 Juri Linkov <juri@jurta.org>
4590
4591 * image.c (imagemagick_error): New function. (Bug#10112)
4592 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4593 Use `imagemagick_error' where ImageMagick functions return
4594 `MagickFalse'.
4595 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4596 proper order.
4597
100d5755
KH
45982011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4599
4600 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4601 fill background (Bug#8992).
4602
454592a6
MR
46032011-12-13 Martin Rudalics <rudalics@gmx.at>
4604
4605 * window.c (Vwindow_combination_resize)
4606 (Vwindow_combination_limit): Use t instead of non-nil in
4607 doc-strings.
61d4b438
MR
4608 (Vrecenter_redisplay): Add first sentence of doc-string on
4609 separate line.
53524d93 4610 (Frecenter): Fix doc-string typo.
454592a6 4611
3633e3aa
KH
46122011-12-11 Kenichi Handa <handa@m17n.org>
4613
4614 * coding.c (Funencodable_char_position): Pay attention to the
4615 buffer text relocation (Bug#9389).
4616
7b9d523a 46172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4618
7b9d523a
JD
4619 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4620 gtk_init (Bug#10100).
4621
b73189c6
EZ
46222011-12-10 Eli Zaretskii <eliz@gnu.org>
4623
4624 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4625 IT->string is nil. (Bug#10263)
4626
f7dfe5d6
JD
46272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4628
83faebb4
JD
4629 * nsterm.h (x_free_frame_resources): Declare.
4630
f7dfe5d6
JD
4631 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4632 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4633
4634 * nsterm.h (ns_get_defaults_value): Declare.
4635
4636 * nsterm.m (ns_default): Call ns_get_defaults_value.
4637
7cd4e72c
EZ
46382011-12-09 Eli Zaretskii <eliz@gnu.org>
4639
4640 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4641 (Bug#10170)
4642
b34d7317
YM
46432011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4644
4645 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4646 that where the value of an _OBJC_* symbol points to is in the .bss
4647 section (Bug#10240).
4648
76470ad1
KH
46492011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4650
4651 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4652 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4653
745fff94
KH
46542011-12-08 Kenichi Handa <handa@m17n.org>
4655
4656 * ftfont.c (get_adstyle_property): Fix previous change
4657 (Bug#10233).
4658
6e44397c
JB
46592011-12-07 Juanma Barranquero <lekktu@gmail.com>
4660
4661 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4662 dirs from the default value of EMACSLOADPATH (bug#10208).
4663
7efa6272
GM
46642011-12-07 Glenn Morris <rgm@gnu.org>
4665
4666 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4667 installation and source directories as well. (Bug#10208)
4668
f6fc4d87
CY
46692011-12-06 Chong Yidong <cyd@gnu.org>
4670
4671 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4672
2bf26180
GM
46732011-12-06 Glenn Morris <rgm@gnu.org>
4674
4675 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4676 as an error, not just -1. (Bug#10217)
4677
3a6ad4f0
CY
46782011-12-05 Chong Yidong <cyd@gnu.org>
4679
4680 * keyboard.c (process_special_events): New function.
4681 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4682
75a3b399
PE
46832011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 * coding.c (encode_designation_at_bol): Don't use uninitialized
4686 local variable (Bug#9318).
4687
c3c9e25e
KH
46882011-12-05 Kenichi Handa <handa@m17n.org>
4689
4690 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4691 return Qnil (Bug#8046, Bug#10193).
4692
5eb05ea3
KH
46932011-12-05 Kenichi Handa <handa@m17n.org>
4694
4695 * coding.c (encode_designation_at_bol): New args charbuf_end and
4696 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4697 (coding_set_source): Return how many bytes coding->source was
4698 relocated.
4699 (coding_set_destination): Return how many bytes
4700 coding->destination was relocated.
4701 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4702 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4703
47042011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4705
4706 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4707 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4708 macro (Bug#9318).
4709
47102011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4711
4712 The following changes are to fix Bug#9318.
4713
a79703f5 4714 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4715 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4716 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4717 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4718
7dbda6df
JB
47192011-12-05 Juanma Barranquero <lekktu@gmail.com>
4720
4721 * lisp.h (process_quit_flag): Fix external declaration.
4722
6d5eb5b0
SM
47232011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4724
4725 Don't macro-inline non-performance-critical code.
4726 * eval.c (process_quit_flag): New function.
4727 * lisp.h (QUIT): Use it.
4728
a0c3fad0
JD
47292011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4730
4731 * nsfns.m (get_geometry_from_preferences): New function.
4732 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4733
6c07aac2
AS
47342011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4735
4736 * emacs.c (Qkill_emacs): Define.
4737 (syms_of_emacs): Initialize it.
4738 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4739 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4740 (quit_throw_to_read_char): Add parameter `from_signal'.
4741 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4742 * lisp.h (QUIT): Call Fkill_emacs if requested.
4743
c052ead4
JD
47442011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4745
4746 * widget.c (update_wm_hints): Return if wmshell is null.
4747 (widget_update_wm_size_hints): New function.
4748
4749 * widget.h (widget_update_wm_size_hints): Declare.
4750
4751 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4752 widget_update_wm_size_hints (Bug#10104).
4753
9e49252b
EZ
47542011-12-03 Eli Zaretskii <eliz@gnu.org>
4755
4756 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4757 before a newline, prepare the bidi iterator for consuming the
4758 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4759 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4760
02b16839
JL
47612011-12-02 Juri Linkov <juri@jurta.org>
4762
4763 * search.c (Fword_search_regexp): New Lisp function created from
4764 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4765 (Fword_search_backward, Fword_search_forward)
4766 (Fword_search_backward_lax, Fword_search_forward_lax):
4767 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4768 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4769
0068070e
SM
47702011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4771
4772 * fileio.c (Finsert_file_contents): Move after-change-function call
4773 to before the "handled:" label, since all "goto handled" appear in
4774 cases where the *-change-functions have already been properly called
4775 (bug#10117).
4776
3360a3fc
AS
47772011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4778
4779 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4780 waiting for input. (Bug#10169)
4781
73d6c093
EZ
47822011-11-30 Eli Zaretskii <eliz@gnu.org>
4783
4784 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4785 verifies glyph row's hash code--we have just reallocated the
4786 glyphs, so their contents can be complete garbage. (Bug#10164)
4787
febe6bea
JB
47882011-11-30 Juanma Barranquero <lekktu@gmail.com>
4789
4790 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4791
801a4313
EZ
47922011-11-30 Eli Zaretskii <eliz@gnu.org>
4793
4794 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4795 attributes are tested _before_ calling verify_row_hash, to protect
4796 against GCC re-ordering of the tests. (Bug#10164)
4797
2b56b87e
JD
47982011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4799
4800 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4801
4802 * xterm.c (handle_one_xevent): Only set async_visible and friends
4803 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4804 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4805 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4806
dbf31225
PE
48072011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4808
4809 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4810 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4811 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4812 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4813 All uses changed to use GCPRO1 etc.
4814 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4815 Revert to old implementation (i.e., before 2011-03-11).
4816
1305621b
YM
48172011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4818
4819 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4820 of scroll runs so as to avoid assigning disabled bogus rows and
4821 unnecessary graphics copy operations.
4822
8c9afb46
EZ
48232011-11-27 Eli Zaretskii <eliz@gnu.org>
4824
4825 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4826 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4827 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4828 (malloc, free, realloc, calloc): Redirect to e_* only when
4829 compiling Emacs.
4830
4831 * lisp.h (GCTYPEBITS): Move before first use.
4832 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4833 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4834 this macro definition.
4835
4836 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4837 _MSC_VER.
4838
54e9e3bf
JD
48392011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4840
6d5eb5b0
SM
4841 * gtkutil.c (xg_create_frame_widgets):
4842 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4843 present with Gtk+ 2.0.
4844
83aca1cb
PE
48452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4846
4847 * fileio.c (Finsert_file_contents): Undo previous change; see
4848 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4849
5b76caa4
PE
48502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4851
4852 Rename locals to avoid shadowing.
4853 * fileio.c (Finsert_file_contents):
4854 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4855 * process.c (wait_reading_process_output):
4856 Rename inner 'proc' to 'p' to avoid shadowing.
4857 Indent for consistency with usual Emacs style.
4858
8c535114
EZ
48592011-11-25 Eli Zaretskii <eliz@gnu.org>
4860
4861 * xdisp.c (redisplay_window): If cursor row is not fully visible
4862 after recentering, and scroll-conservatively is set to a large
4863 number, scroll window by a few more lines to make the cursor fully
4864 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4865 (start_display): Don't move to the next line if the display should
4866 start at a newline that is part of a display vector or an overlay
4867 string. (Bug#10119)
8c535114 4868
fa4fdb5c
JL
48692011-11-24 Juri Linkov <juri@jurta.org>
4870
4871 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4872 after the `MagickPingImage' call. (Bug#10112)
4873
90ec88df
CY
48742011-11-23 Chong Yidong <cyd@gnu.org>
4875
4876 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4877
56e2e794
MR
48782011-11-23 Martin Rudalics <rudalics@gmx.at>
4879
4880 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4881 making another buffer current. (Bug#10114)
4882
b6e64c41
GM
48832011-11-23 Glenn Morris <rgm@gnu.org>
4884
4885 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4886
6b21de18
CY
48872011-11-23 Chong Yidong <cyd@gnu.org>
4888
4889 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4890 using it (Bug#5984).
4891
b12cd789
EZ
48922011-11-22 Eli Zaretskii <eliz@gnu.org>
4893
4894 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4895 and header-lines, as they don't have one computed for them.
4896 (Bug#10098)
4897
4898 * .gdbinit (prow): Make displayed values more self-explaining.
4899 Add row's hash code.
4900
261b6fd4
LMI
49012011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4902
4903 * process.c (wait_reading_process_output): Fix asynchrounous
4904 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4905 (wait_reading_process_output): Add comment and URL.
261b6fd4 4906
e7cfd277
JD
49072011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4908
4909 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4910
a9b9b7f5
CY
49112011-11-21 Chong Yidong <cyd@gnu.org>
4912
4913 * window.c (Fnext_window, Fprevious_window): Doc fix.
4914
b0d15b4f
SM
49152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4916
4917 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4918
fe7a3057
JB
49192011-11-20 Juanma Barranquero <lekktu@gmail.com>
4920
4921 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4922
d2999b1a
MR
49232011-11-20 Martin Rudalics <rudalics@gmx.at>
4924
4925 * window.c (Fset_window_combination_limit): Rename argument
4926 STATUS to LIMIT.
4927 (Vwindow_combination_limit): Remove "status" from doc-string.
4928
d5ff9cd0
AS
49292011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4930
4931 * m/ibms390.h: Remove.
4932 * m/ibms390x.h: Don't include "ibms390.h".
4933
a5bb9bd3
SM
49342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4935
4936 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4937 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4938
cd1181db
JB
49392011-11-20 Juanma Barranquero <lekktu@gmail.com>
4940
4941 * casetab.c (Fset_case_table):
4942 * charset.c (Fcharset_after): Fix typos.
4943
615a3b8d 49442011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4945
17e845af
PE
4946 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4947 Otherwise, valgrind does not work on some platforms.
4948 Problem reported by Andreas Schwab in
6a0bf43d
PE
4949 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4950 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4951 is set, removing the need for VIRT_ADDRESS_VARIES.
4952 (PURE_P): Use a more-efficient implementation that needs just one
4953 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4954 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4955 to 4 (xorl, subq, cmpq, setbe).
4956 * alloc.c (pure): Always extern now, since that's the
4957 VIRT_ADDR_VARIES behavior.
4958 (PURE_POINTER_P): Use a single comparison, not two, for
4959 consistency with the new puresize.h.
4960 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4961 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4962 Remove VIRT_ADDR_VARIES no longer needed.
4963
f8fe6f96
EZ
49642011-11-19 Eli Zaretskii <eliz@gnu.org>
4965
4966 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4967 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4968 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4969 behave as if the cursor position were at the window margin.
4970
4971 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4972 and the cursor position is out of bounds, behave as if the cursor
4973 position were at the window margin. (Bug#10075)
4974
df05a53c
CY
49752011-11-18 Chong Yidong <cyd@gnu.org>
4976
4977 * window.c (Fwindow_combination_limit): Make first argument
4978 non-optional, since it is meaningless for live windows like the
4979 selected window.
61ccba97 4980
2071918e
DA
49812011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4982
4983 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4984
b50a28de
SM
49852011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4986
4987 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4988 (graft_intervals_into_buffer): Simplify.
4989
015137db
EZ
49902011-11-18 Eli Zaretskii <eliz@gnu.org>
4991
4992 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4993 hash values of the two rows.
4994 (copy_row_except_pointers): Preserve the used[] arrays and the
4995 hash values of the two rows. (Bug#10035)
68c95424 4996 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4997
4998 * xdisp.c (row_hash): New function, body extracted from
4999 compute_line_metrics.
5000 (compute_line_metrics): Call row_hash, instead of computing the
5001 hash code inline.
5002
5003 * dispnew.c (verify_row_hash): Call row_hash for computing the
5004 hash code of a row, instead of duplicating code from xdisp.c.
5005
5006 * dispextern.h (row_hash): Add prototype.
5007
a2addb04
TH
50082011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5009
5010 * frame.c (delete_frame): Don't delete the terminal when the last
5011 X frame is closed if emacs is built with GTK toolkit.
5012
df85d315
JB
50132011-11-17 Juanma Barranquero <lekktu@gmail.com>
5014
5015 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5016
a0c2d0ae
MR
50172011-11-17 Martin Rudalics <rudalics@gmx.at>
5018
5019 * window.c (Vwindow_splits): Rename to
5020 Vwindow_combination_resize. Suggested by Juri Linkov.
5021 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5022 of Vwindow_splits.
5023
58179cce
JB
50242011-11-16 Juanma Barranquero <lekktu@gmail.com>
5025
7877f373
JB
5026 * nsfns.m (Fns_font_name):
5027 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5028
b6f67890
MR
50292011-11-16 Martin Rudalics <rudalics@gmx.at>
5030
5031 * window.h (window): Rename slot "nest" to "combination_limit".
5032 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5033 (Fset_window_nest): Rename to Fset_window_combination_limit.
5034 (Vwindow_nest): Rename to Vwindow_combination_limit.
5035 (recombine_windows, make_parent_window, make_window)
5036 (Fsplit_window_internal, saved_window)
5037 (Fset_window_configuration, save_window_save): Rename all
5038 occurrences of window_nest to window_combination_limit.
5039
c7015153
JB
50402011-11-15 Juanma Barranquero <lekktu@gmail.com>
5041
5042 * image.c (imagemagick_load_image): Fix typo.
5043
322ad6ec
EZ
50442011-11-14 Eli Zaretskii <eliz@gnu.org>
5045
5046 * xdisp.c (display_line): Move the call to
5047 highlight_trailing_whitespace before the call to
5048 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5049 faces of all the glyphs to compute ROW's hash value.
5050 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5051
f067b8ec
JB
50522011-11-14 Juanma Barranquero <lekktu@gmail.com>
5053
5054 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5055 just return (bug#10044).
5056
1e5b2111
EZ
50572011-11-12 Eli Zaretskii <eliz@gnu.org>
5058
7ef3cbd5
EZ
5059 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5060 with user-defined heap size. Bump the default size of the temacs
5061 heap to 27MB, to avoid memory warning when running temacs.
5062 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5063
1e5b2111
EZ
5064 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5065 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5066 (verify_row_hash) [XASSERTS]: New function.
5067 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5068 that the hash value of glyph rows is correct.
1e5b2111 5069
89d61221
MR
50702011-11-12 Martin Rudalics <rudalics@gmx.at>
5071
5072 * window.h (window): Remove splits slot.
5073 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5074 (Fdelete_other_windows_internal, make_parent_window)
5075 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5076 (Fset_window_configuration, save_window_save): Don't deal with
5077 split status of windows.
5078 (saved_window): Remove splits slot.
5079 (Vwindow_splits): Rewrite doc-string.
5080
97f18cc8
JD
50812011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5082
5083 * xfns.c (unwind_create_frame):
5084 * nsfns.m (unwind_create_frame):
5085 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5086 Vframe_list (Bug#9999).
5087
22a648b4
DA
50882011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5089
0b381c7e 5090 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5091
659afede
KH
50922011-11-11 Kenichi Handa <handa@m17n.org>
5093
5094 * callproc.c (Fcall_process): Set the member dst_multibyte of
5095 process_coding.
5096
9ac0394b
KH
50972011-11-11 Johan Bockgård <bojohan@gnu.org>
5098
5099 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5100 avoid a crash (bug#9496).
5101
2fbdc249
CY
51022011-11-09 Chong Yidong <cyd@gnu.org>
5103
5104 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5105 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5106
ac6b1f81
PE
51072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5110
09db192c
PE
51112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5112
5113 Avoid some portability problems by eschewing 'extern inline' functions.
5114 The trivial performance wins aren't worth the portability hassles; see
5115 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5116 et seq.
5117 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5118 (window_box_width, window_box_left, window_box_left_offset)
5119 (window_box_right, window_box_right_offset): Undo previous change,
5120 by removing the "extern"s.
5121 * intervals.c (adjust_intervals_for_insertion)
5122 (adjust_intervals_for_deletion): Undo previous change,
5123 making these static again.
5124 (offset_intervals, temp_set_point_both, temp_set_point)
5125 (copy_intervals_to_string): No longer inline.
5126 * xdisp.c (window_text_bottom_y, window_box_width)
5127 (window_box_height, window_box_left_offset)
5128 (window_box_right_offset, window_box_left, window_box_right)
5129 (window_box): No longer inline.
5130
105216ed
CY
51312011-11-08 Chong Yidong <cyd@gnu.org>
5132
5133 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5134 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5135 Signal an error if not a live window.
105216ed
CY
5136 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5137 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5138
ae9e237f
JB
51392011-11-07 Juanma Barranquero <lekktu@gmail.com>
5140
5141 * lisp.h (syms_of_abbrev): Remove declaration.
5142 Reported by CHENG Gao <chenggao@royau.me>.
5143
c7aa8333
EZ
51442011-11-07 Eli Zaretskii <eliz@gnu.org>
5145
5146 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5147 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5148 of temacs in GUI mode.
5149
be7f5545
MR
51502011-11-07 Martin Rudalics <rudalics@gmx.at>
5151
5152 * window.h: Declare delete_all_child_windows instead of
5153 delete_all_subwindows.
5154 * window.c (Fwindow_nest, Fset_window_nest)
5155 (Fset_window_new_total, Fset_window_new_normal)
5156 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5157 (delete_all_subwindows): Rename to delete_all_child_windows.
5158 (Fdelete_other_windows_internal, Fset_window_configuration):
5159 Call delete_all_child_windows instead of delete_all_subwindows.
5160 * frame.c (delete_frame): Call delete_all_child_windows instead
5161 of delete_all_subwindows.
5162
ca78dc43
PE
51632011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5164
5165 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5166 This is also needed for porting to any host where GC_MARK_STACK is
5167 not GC_MAKE_GCPROS_NOOPS.
5168 (which_symbols): Use it.
5169
a0241d01
KH
51702011-11-07 Kenichi Handa <handa@m17n.org>
5171
5172 * coding.c (coding_set_destination): Check coding->src_pos only
5173 when coding->src_object is a buffer (bug#9910).
5174
5175 * process.c (send_process): Set the member src_multibyte of coding
5176 to 0 (bug#9911) when sending a unibyte text.
5177
5178 * callproc.c (Fcall_process): Set the member src_multibyte of
5179 process_coding to 0 (bug#9912).
5180
a64bfdfa 51812011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5182
5183 * xmenu.c (cleanup_widget_value_tree): New function.
5184 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5185 calling free_menubar_widget_value_tree directly (Bug#9830).
5186
cb41b32a
PE
51872011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 Fix some portability problems with 'inline'.
5190 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5191 (window_box_width, window_box_left, window_box_left_offset)
5192 (window_box_right, window_box_right_offset): Declare extern.
5193 Otherwise, these inline functions do not conform to C99 and
5194 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5195 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5196 * intervals.c (adjust_intervals_for_insertion)
5197 (adjust_intervals_for_deletion): Now extern, because otherwise the
5198 extern inline functions 'offset_intervals' couldn't refer to it.
5199 (static_offset_intervals): Remove.
5200 (offset_intervals): Rewrite using the old contents of
5201 static_offset_intervals. The old version didn't conform to C99
5202 because an extern inline function contained a reference to an
5203 identifier with static linkage.
5204
b7041366
AS
52052011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5206
5207 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5208 GC.
5209
88a37c4d
EZ
52102011-11-06 Eli Zaretskii <eliz@gnu.org>
5211
5212 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5213 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5214 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5215 return Qleft_to_right.
5216
49745b39
CY
52172011-11-06 Chong Yidong <cyd@gnu.org>
5218
5219 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5220 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5221 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5222 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5223 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5224 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5225 (Fwindow_vscroll): Doc fix.
5226 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5227 argument, since it makes no sense to pass a live window and for
5228 consistency with window-child.
5229
1f05cd82
CS
52302011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5231
5232 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5233 support MSVC.
5234
22610910
JR
52352011-11-05 Jason Rumney <jasonr@gnu.org>
5236
5237 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5238 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5239 fonts (Bug#6029).
5240 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5241 bitwise arithmetic preventing use of unicode-sip and non-truetype
5242 opentype fonts.
5243
a06776b2
EZ
52442011-11-05 Eli Zaretskii <eliz@gnu.org>
5245
3ad924ba
EZ
5246 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5247 "emacs"-only part.
5248
a06776b2
EZ
5249 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5250 initialization code to keep similarity to xfns.c after changes
5251 from 2011-11-05.
5252
c9e7db78
JD
52532011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5254
a97f8f3f
JD
5255 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5256 (unwind_create_frame): New function (Bug#9943).
5257 (Fx_create_frame): Restructure code to be more similar to the one in
5258 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5259 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5260 Move terminal->reference_count++ just before making the frame official
5261 (Bug#9943).
5262
5263 * nsterm.m (x_free_frame_resources): New function.
5264 (x_destroy_window): Move code to x_free_frame_resources.
5265
c9e7db78 5266 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5267 (Fx_create_frame, x_create_tip_frame):
5268 Move terminal->reference_count++ just before making the frame
75f1671a 5269 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5270 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5271
a6fc3b5c
EZ
52722011-11-05 Eli Zaretskii <eliz@gnu.org>
5273
5274 Support MSVC build with newer versions of Visual Studio.
5275 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5276 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5277 nt/gmake.defs.
5278
5279 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5280 which are not supported by MSVC.
5281 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5282 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5283 bitfields.
5284 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5285 types in bitfields.
5286 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5287
5288 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5289
58179cce 52902011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5291
5292 Support MSVC build with newer versions of Visual Studio.
5293 * w32.c: Don't include w32api.h for MSVC.
5294 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5295
5296 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5297 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5298 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5299 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5300 e_* cousins.
5301 (alloca) [_MSC_VER]: Define to _alloca.
5302
5303 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5304
5305 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5306
a58c13ed
EZ
53072011-11-04 Eli Zaretskii <eliz@gnu.org>
5308
5309 * xdisp.c (note_mouse_highlight): If either of
5310 previous/next-single-property-change returns nil, treat that as
5311 the beginning or the end of the buffer. (Bug#9955)
5312
fe0b6370
JD
53132011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5314
a58c13ed 5315 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5316 label is not null (Bug#9951).
5317 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5318 may be NULL.
5319
89bd5ee1
EZ
53202011-11-04 Eli Zaretskii <eliz@gnu.org>
5321
5322 * window.c (Fwindow_body_size): Mention in the doc string that the
5323 return value is in frame's canonical units. (Bug#9949)
5324
84c3edb9
EZ
53252011-11-03 Eli Zaretskii <eliz@gnu.org>
5326
4e2fb5c7
EZ
5327 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5328
84c3edb9 5329 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5330 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5331 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5332
bc17a887
EZ
53332011-11-01 Eli Zaretskii <eliz@gnu.org>
5334
5335 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5336 Don't stop backward scan on the continuation glyph, even though
5337 its CHARPOS is positive.
6d5eb5b0
SM
5338 (mouse_face_from_buffer_pos, note_mouse_highlight):
5339 Rename cover_string to disp_string.
bc17a887 5340
4ee88440
MR
53412011-11-01 Martin Rudalics <rudalics@gmx.at>
5342
5343 * window.c (temp_output_buffer_show): Don't use
5344 Vtemp_buffer_show_specifiers.
5345 (Vtemp_buffer_show_specifiers): Remove unused variable.
5346
c2ff3c02
EZ
53472011-10-30 Eli Zaretskii <eliz@gnu.org>
5348
5349 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5350 past the beginning of the current glyph matrix.
5351
58179cce 53522011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5353
5354 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5355 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5356 HAVE_GTK3 (Bug#9869).
b77a6a7f 5357
3b574623
JD
5358 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5359 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5360
b77a6a7f
JD
5361 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5362
5363 * xterm.c: Declare x_handle_net_wm_state to return int.
5364 (handle_one_xevent): Check if we are iconified but don't have
5365 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5366 (get_current_wm_state): Return non-zero if not hidden,
5367 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5368 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5369 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5370 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5371
196e41e4
PE
53722011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5375 so that this new function doesn't get optimized away by a
5376 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5377
021f2e1a
AS
53782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5379
5380 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5381
8b058d44
EZ
53822011-10-29 Eli Zaretskii <eliz@gnu.org>
5383
5384 Fix the `xbytecode' command.
5385 * .gdbinit (xprintbytestr): New command.
b50a28de 5386 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5387 (xbytecode): Print the byte-code string as well.
5388
4452fb80
EZ
53892011-10-29 Kim Storm <storm@cua.dk>
5390
8b058d44
EZ
5391 * alloc.c (which_symbols): New function.
5392
21b72067
AS
53932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5394
5395 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5396 line. (Bug#9903)
5397
83ed7b5c
GM
53982011-10-29 Glenn Morris <rgm@gnu.org>
5399
5400 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5401 Not clear what it was for, and it causes various bugs. (Bug#9839)
5402
5a7a728b
EZ
54032011-10-28 Eli Zaretskii <eliz@gnu.org>
5404
5405 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5406 possible random value that matches one of those tested as
5407 condition to clear the mouse face.
5408
d3d0842f
CY
54092011-10-28 Chong Yidong <cyd@gnu.org>
5410
5411 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5412
31b39d13
DN
54132011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5414
5415 * window.c (make_window): Initialize phys_cursor_on_p.
5416
9aba6043
SM
54172011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5418
5419 * lisp.h (struct Lisp_Symbol): Update comments.
5420
c20992f4
JB
54212011-10-28 Juanma Barranquero <lekktu@gmail.com>
5422
5423 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5424
db4f02f2
EZ
54252011-10-28 Eli Zaretskii <eliz@gnu.org>
5426
5427 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5428 <oslsachem@gmail.com> for helping to debug this.
5429
5430 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5431 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5432 (g_b_init_get_glyph_outline_w): New static variables.
5433 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5434 (GetGlyphOutlineW_Proc): New typedefs.
5435 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5436 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5437 New functions.
5438 (w32font_open_internal, compute_metrics):
5439 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5440 instead of calling the "wide" APIs directly.
5441
5442 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5443
5444 * w32.h (syms_of_w32font): Add prototype.
5445
87e68db4
JB
54462011-10-27 Juanma Barranquero <lekktu@gmail.com>
5447
5448 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5449 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5450 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5451 (Fmove_to_window_line): Doc fix.
5452
435c1d67
CY
54532011-10-27 Chong Yidong <cyd@gnu.org>
5454
5455 * process.c (make_process): Set gnutls_state to NULL.
5456
5457 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5458 non-NULL, regardless of GNUTLS_INITSTAGE.
5459 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5460 an error. Set process slots as soon as we allocate them.
5461
5462 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5463
9c6c6f49
CY
54642011-10-27 Chong Yidong <cyd@gnu.org>
5465
9aba6043
SM
5466 * gnutls.c (emacs_gnutls_deinit): New function.
5467 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5468 (Fgnutls_deinit, Fgnutls_boot): Use it.
5469
5470 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5471 (deactivate_process): Call emacs_gnutls_deinit.
5472
657d08d3
JB
54732011-10-27 Juanma Barranquero <lekktu@gmail.com>
5474
5475 * image.c (x_create_x_image_and_pixmap):
5476 * w32.c (sys_rename, w32_delayed_load):
5477 * w32font.c (fill_in_logfont):
5478 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5479
5430d399
JB
54802011-10-26 Juanma Barranquero <lekktu@gmail.com>
5481
5482 * w32fns.c (w32_default_color_map): New function,
5483 extracted from Fw32_default_color_map.
a7ef684b 5484 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5485
fe0055fa
PE
54862011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5487
5488 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5489
e6346438
SM
54902011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5491
5492 * keyboard.c (test_undefined): New function (bug#9751).
5493 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5494
e112cc37
ET
54952011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5496
5497 * sysdep.c (init_sys_modes): Fix the check for the controlling
5498 terminal (Bug#6649).
5499
7b5d6677
EZ
55002011-10-20 Eli Zaretskii <eliz@gnu.org>
5501
5502 * dispextern.h (struct bidi_it): New member next_en_type.
5503
5504 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5505 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5506 current character, check also for next_en_type being WEAK_EN.
5507 (bidi_resolve_weak): Don't enter the expensive loop if the current
5508 position is before next_en_pos. Record the bidi type of the first
5509 non-ET, non-BN character we find, in addition to its position.
5510 (bidi_level_of_next_char): Invalidate next_en_type when
5511 next_en_pos is over-stepped.
5512
7da0b018
PE
55132011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5514
5515 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5516 * editfns.c: Rewrite current-time-zone so that it invokes
5517 the equivalent of (format-time-string "%Z") to get the time zone name.
5518 This fixes a bug when the time zone name contains characters that
5519 need converting from the system time locale to Emacs internal format.
5520 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5521 that patch fixed format-time-string to do the conversion, but
5522 I forgot to fix current-time-zone.
5523 (format_time_string): New function, containing most of
5524 what Fformat_time_string used to contain.
5525 (Fformat_time_string): Rewrite in terms of format_time_string.
5526 This doesn't change this function's behavior.
5527 (current-time-zone): Rewrite to use format_time_string.
5528 This fixes the bug reported by Michael Schierl in
5529 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5530 Jason Rumney's 2007-06-07 change worked around this bug, but
5531 didn't fix it.
5532 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5533
8547b010
EZ
55342011-10-19 Eli Zaretskii <eliz@gnu.org>
5535
5536 * xdisp.c (start_display): If the character at POS is displayed
5537 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5538 (try_window_reusing_current_matrix): If a line ends in a display
5539 vector or the next line starts in a display vector, continue
5540 redrawing the window even though the character position of
5541 start_row was reached.
8547b010
EZ
5542 (Bug#9771, part 2)
5543
4e948d15
CY
55442011-10-18 Chong Yidong <cyd@gnu.org>
5545
5546 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5547 with nobreak-char-display too.
5548
4787455f
EZ
55492011-10-18 Eli Zaretskii <eliz@gnu.org>
5550
5551 Fix part 3 of bug#9771.
5552 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5553 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5554 non-neutral characters if the current character is a paragraph
5555 separator (a.k.a. Newline). This avoids running the same
5556 expensive loop twice, once when we consume the preceding newline
5557 and the other time when the line actually needs to be displayed.
5558 Avoid the loop when we see neutrals on the base embedding level
5559 following a character whose directionality is the same as the
5560 paragraph's. This avoids running the expensive loop when a line
5561 ends in a long sequence of neutrals, like control characters.
5562 Add assertion against STRONG_AL type. Slightly rearrange code
5563 that determines the type of a neutral given the first non-neutral
5564 that follows it.
5565 (bidi_level_of_next_char): Set next_en_pos to zero when
5566 invalidating its info.
5567
2c91f553
EZ
55682011-10-17 Eli Zaretskii <eliz@gnu.org>
5569
5570 * xdisp.c (push_display_prop): Determine whether to record string
5571 or buffer position by IT->string, not by IT->method. Allow
5572 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5573 (move_it_vertically_backward): Don't look for character position
5574 immediately after the newline when in a continuation line.
5575 (Bug#9771, part 1)
2c91f553 5576
c7b08b0d
MR
55772011-10-15 Martin Rudalics <rudalics@gmx.at>
5578
5579 * window.c (coordinates_in_window): Rewrite and delabelize
5580 vertical border check. (Bug#5357) (Bug#9618)
5581
6b02f655
SM
55822011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5583
5584 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5585 errors in XSetWindowBorder (bug#9310).
5586
81d40c92
DA
55872011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5588
5589 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5590 avoid crash when xmalloc overrun checking is enabled.
5591
d4172c3b
EZ
55922011-10-13 Eli Zaretskii <eliz@gnu.org>
5593
5594 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5595 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5596 cursor motion with <left> and <right> arrow keys.
5597
5598 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5599 some callers set that themselves.
5600
b00eea75
EZ
56012011-10-12 Eli Zaretskii <eliz@gnu.org>
5602
5603 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5604 display string and the previous row comes from the same string and
5605 is empty. (Bug#9739) (Bug#9738)
5606
8fe012c4
SM
56072011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5608
5609 * doc.c (get_doc_string): Encode file name (bug#9735).
5610
0074aef2
EZ
56112011-10-12 Eli Zaretskii <eliz@gnu.org>
5612
79beb178
EZ
5613 * bidi.c (bidi_level_of_next_char):
5614 * xdisp.c (get_visually_first_element): Remove old incorrect
5615 comments regarding the Unicode Line Separator character.
5616
0074aef2
EZ
5617 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5618
6e4b3fbe
DA
56192011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5620
5621 * alloc.c (Fgc_status): Do not access beyond zombies array
5622 boundary if nzombies > MAX_ZOMBIES.
5623 * alloc.c (dump_zombies): Add missing format specifier.
5624
0324f3af
PE
56252011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5626
b5525cac
PE
5627 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5628 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5629
0324f3af
PE
5630 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5631 Some packages use them to denote characters with modifiers.
5632
e9b5f888
AS
56332011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5634
5635 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5636 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5637 matching a pp-number. Rename parameter var to var1.
5638
127827c0
SM
56392011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5640
5641 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5642
c8fd3bd0
GM
56432011-10-08 Glenn Morris <rgm@gnu.org>
5644
5645 * callint.c (Fcall_interactively): Give a more explicit error for the
5646 'c' case with a non-character input. (Bug#8479)
5647
352ec8ff
EZ
56482011-10-08 Eli Zaretskii <eliz@gnu.org>
5649
03669ccb
EZ
5650 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5651 lines.
7061c986
EZ
5652 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5653 lines that are hscrolled on the left.
03669ccb 5654
352ec8ff
EZ
5655 * dispnew.c (buffer_posn_from_coords): Account for a possible
5656 presence of header-line. (Bug#4426)
5657
a66cfb1c
SM
56582011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5659
6b02f655
SM
5660 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5661 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5662
7c5ee88e
PE
56632011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5664
5665 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5666 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5667 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5668 this makes Emacs dump core during garbage collection on rare
5669 occasions. sizeof is obviously inferior to offsetof here, so
5670 stick with offsetof.
5671 (GC_POINTER_ALIGNMENT): New macro.
5672 (mark_memory): Omit 3rd (offset) arg; caller changed.
5673 Don't assume EMACS_INT alignment is the same as pointer alignment.
5674
df1bbe5b
SM
56752011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5676
5677 * keyboard.c (read_key_sequence_remapped): New var.
5678 (read_key_sequence): Compute remapping in the right buffer.
5679 (command_loop_1): Use read_key_sequence's remapping directly.
5680
51553db6
SM
56812011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5682
32c1fffd
SM
5683 * dired.c (file_name_completion): Don't expand file name.
5684 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5685 before checking file name handler.
5686
51553db6
SM
5687 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5688 they've been requested explicitly (bug#9591).
5689
b6bd1599 56902011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5691
5692 * keymap.c (Fsingle_key_description): Use make_specified_string
5693 instead of build_string to build string from push_key_description.
5694 (Bug#5193)
5695
f701dc2a
PE
56962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5697
4222c55d
PE
5698 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5699 This fixes a Y2038 bug on 64-bit hosts.
5700 * buffer.c (reset_buffer):
5701 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5702 (Fclear_buffer_auto_save_failure):
5703 Use 0, not -1, to represent an unset failure time, since time_t
5704 might not be signed.
5705
f701dc2a
PE
5706 Remove dependency on glibc malloc internals.
5707 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5708 Move back here from lisp.h, but with their new implementations.
5709 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5710 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5711 * charset.c (charset_table_init): New static var.
5712 (syms_of_charset): Use it instead of xmalloc. This removes a
5713 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5714 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5715 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5716 Move back to alloc.c.
5717 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5718 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5719
9ceebf39
JD
57202011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5721
5722 * nsterm.m (windowDidResize): Call x_set_window_size only when
5723 ns_in_resize is true. Otherwise set pixelwidth/height and
5724 call change_frame_size (Bug#9628).
5725
cb993c58
PE
57262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5727
3930c88b
PE
5728 Port --enable-checking=all to Fedora 14 x86-64.
5729 * charset.c (syms_of_charset): Also account for glibc malloc's
5730 internal overhead when calculating the initial malloc maximum.
5731
cb993c58
PE
5732 Port --enable-checking=all to Fedora 14 x86.
5733 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5734 Move to lisp.h.
5735 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5736 (overrun_check_realloc, overrun_check_free):
5737 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5738 That way, xmalloc returns a properly-aligned pointer even if
5739 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5740 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5741 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5742 into account when calculating the initial malloc maximum.
5743 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5744 Move here from alloc.c, so that charset.c can use it too.
5745 Properly align; the old code wasn't right for common 32-bit hosts
5746 when configured with --enable-checking=all.
5747 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5748 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5749
31bed486
EZ
57502011-09-29 Eli Zaretskii <eliz@gnu.org>
5751
04c70788 5752 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5753 use EDOM.
5754
fbcaa2f3
EZ
57552011-09-28 Eli Zaretskii <eliz@gnu.org>
5756
5757 * xdisp.c (compute_display_string_end): If there's no display
5758 string at CHARPOS, return -1.
5759
5760 * bidi.c (bidi_fetch_char): When compute_display_string_end
5761 returns a negative value, treat the character as a normal
5762 character not covered by a display string. (Bug#9624)
5763
a239d4e9
JB
57642011-09-28 Juanma Barranquero <lekktu@gmail.com>
5765
5766 * lread.c (Fread_from_string): Fix typo in docstring.
5767
88652fd5
EZ
57682011-09-27 Eli Zaretskii <eliz@gnu.org>
5769
5770 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5771 newline, reseat the iterator instead of bidi-iterating there one
5772 character at a time. (Bug#9610)
32c1fffd
SM
5773 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5774 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5775
ed497dd4
AS
57762011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5777
5778 * lread.c (readevalloop): Use correct code for NBSP.
5779 (read1): Likewise. (Bug#9608)
5780
b2bf61aa
MA
57812011-09-25 Michael Albinus <michael.albinus@gmx.de>
5782
5783 * dbusbind.c (Fdbus_register_signal): When service is not
5784 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5785
32bbb17c
GM
57862011-09-25 Glenn Morris <rgm@gnu.org>
5787
5788 * buffer.c (truncate-lines): Doc fix.
5789
94e0933e
CY
57902011-09-24 Chong Yidong <cyd@stupidchicken.com>
5791
5792 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5793 (Fset_window_next_buffers): Doc fix.
5794
cddde921
GM
57952011-09-24 Glenn Morris <rgm@gnu.org>
5796
5797 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5798
1260aef1
PE
57992011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5800
25b4bfa0
PE
5801 Fix minor problems found by static checking.
5802 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5803 * indent.c (Fvertical_motion): Fix == vs = typo.
5804
e3cbd34b
EZ
58052011-09-24 Eli Zaretskii <eliz@gnu.org>
5806
a66cfb1c
SM
5807 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5808 Default value is now t. Doc fix.
6bf7006f 5809
e3cbd34b 5810 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5811 logic when moving up, not only when moving down. Fix the
e3cbd34b 5812 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5813 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5814
5815 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5816 CHARPOS is covered by a display string which includes newlines.
5817 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5818 is covered by a display string with embedded newlines.
5819
a3de0cbd
MA
58202011-09-24 Michael Albinus <michael.albinus@gmx.de>
5821
5822 * dbusbind.c (Fdbus_register_signal): Add match rule to
5823 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5824 (Fdbus_register_method, Vdbus_registered_objects_table):
5825 Fix docstring.
a3de0cbd 5826
b260039d
JM
58272011-09-24 Jim Meyering <meyering@redhat.com>
5828
32c1fffd 5829 do not ignore write error for any output size
b260039d
JM
5830 The previous change was incomplete.
5831 While it makes emacs --batch detect the vast majority of stdout
5832 write failures, errors were still ignored whenever the output size is
5833 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5834 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5835 && echo FAIL: ignored write error
5836 FAIL: ignored write error
5837 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5838 && echo FAIL: ignored write error
5839 FAIL: ignored write error
5840 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5841
8eca8a7c
AS
58422011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5843
5844 * emacs.c (Fkill_emacs): In noninteractive mode exit
5845 non-successfully if a write error occurred on stdout. (Bug#9574)
5846
3341db62
EZ
58472011-09-21 Eli Zaretskii <eliz@gnu.org>
5848
5849 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5850 the xassert test.
5851
5852 * dispextern.h (struct it): Update the comment documenting what
5853 can it->OBJECT be.
5854
8c203dbf
EZ
58552011-09-20 Eli Zaretskii <eliz@gnu.org>
5856
5857 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5858 a display string, extend search for cursor position to end of row.
5859 (find_row_edges): If the row ends in a newline from a display
5860 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5861 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5862 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5863 non-empty line. Fixes confusing cursor motion with arrow keys at
5864 the beginning of a line that starts with whitespace.
8c203dbf 5865
a4824228
LMI
58662011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5867
5868 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5869 (bug#9493).
5870
33ed493b
CY
58712011-09-18 Chong Yidong <cyd@stupidchicken.com>
5872
5873 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5874 boolean (Bug#9154).
5875
56cd55c8
EZ
58762011-09-18 Eli Zaretskii <eliz@gnu.org>
5877
5878 * xdisp.c (display_line): Record maximum and minimum buffer
5879 positions even if no glyphs were produced (e.g., by a zero-width
5880 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5881 buffer positions that will be removed from the glyph row because
5882 they don't fit.
c02dcedf
EZ
5883 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5884 column is beyond frame width: don't subtract 1 "pixel" when
5885 computing width of the stretch.
3e62b7e0
EZ
5886 (reseat_at_next_visible_line_start): Undo the change made on
5887 2011-09-17 that saved paragraph information and restored it after
5888 the call to `reseat'. (Bug#9545)
56cd55c8 5889
5ed99d36 58902011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5891
5892 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5893 and turn window cursor on if cleared (Bug#9415).
5894
5ed99d36 58952011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5896
5897 * search.c (boyer_moore): Take unibyte characters from pattern
5898 literally. (Bug#9458)
5899
9bade7b2
EZ
59002011-09-18 Eli Zaretskii <eliz@gnu.org>
5901
5902 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5903
e5e9d610
PE
59042011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5905
87e4427a
PE
5906 Fix minor problem found by static checking.
5907 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5908 initialized, to pacify gcc -Wuninitialized.
5909
e5e9d610
PE
5910 * fileio.c: Report proper errno when syscall falls.
5911 (Finsert_file_contents): Save and restore errno,
5912 so that report_file_error outputs the correct diagnostic.
5913 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5914
a1674f0b
EZ
59152011-09-18 Eli Zaretskii <eliz@gnu.org>
5916
5917 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5918
fbfb6dd4
EZ
59192011-09-17 Eli Zaretskii <eliz@gnu.org>
5920
5921 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5922 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5923
bb187662
EZ
59242011-09-17 Eli Zaretskii <eliz@gnu.org>
5925
1137e8b8 5926 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5927 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5928
5929 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5930 (bidi_find_paragraph_start): Search back for paragraph beginning
5931 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5932 (bidi_move_to_visually_next): Only trigger paragraph-related
5933 computations when the last character is a newline or at EOB, not
5934 just any NEUTRAL_B. (Bug#9470)
5935
bb187662
EZ
5936 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5937 truncated lines if point is covered by a display string. (Bug#9524)
5938
2e621251
PE
59392011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5940
5941 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5942 (cons_to_x_long): New function.
5943 (lisp_data_to_selection_data): Use it. Correct the test for
5944 short-versus-long data; it was negated. Break out of vector
5945 loop, for efficiency, when a long datum is discovered.
5946
91a15bc6
SM
59472011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5948
5949 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5950
b41c3a35
EZ
59512011-09-16 Eli Zaretskii <eliz@gnu.org>
5952
5953 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5954 GCC PR/17406) by declaring this function with external scope.
5955
7812ba2d
PE
59562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5957
5958 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5959 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5960
cf7edc2a
AS
59612011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5962
5963 * editfns.c (Fformat): Correctly handle text properties on "%%".
5964
bd01620e
EZ
59652011-09-15 Eli Zaretskii <eliz@gnu.org>
5966
5967 * xterm.c (x_draw_composite_glyph_string_foreground):
5968 * w32term.c (x_draw_composite_glyph_string_foreground):
5969 * term.c (encode_terminal_code):
5970 * composite.c (composition_update_it, get_composition_id):
5971 * xdisp.c (get_next_display_element)
5972 (fill_composite_glyph_string): Add comments about special meaning
5973 of TAB characters in a composition.
5974
a02719a3
PE
59752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5976
5977 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5978 This occurs when processing a multibyte format.
5979 Problem reported by Wolfgang Jenker.
a02719a3 5980
72589a3c
JB
59812011-09-15 Johan Bockgård <bojohan@gnu.org>
5982
5983 * xdisp.c (try_cursor_movement): Only check for exact match if
5984 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5985
1c14176c
PE
59862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5987
5988 Remove unused external symbols.
5989 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5990 * xdisp.c (calc_pixel_width_or_height): Now static.
5991 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5992 * indent.c (check_display_width):
5993 * w32term.c: Fix comment to match code.
5994 * xterm.c, xterm.h (x_catching_errors): Remove.
5995
d2eea5b5
PE
59962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5997
5998 * xselect.c: Use signed conversions more consistently (Bug#9498).
5999 (selection_data_to_lisp_data): Assume incoming selection data are
6000 signed integers, not unsigned. This is to be consistent with
6001 outgoing selection data, which was modified to use signed integers
6002 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6003 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6004 expects long, not unsigned long.
6005
46888499
EZ
60062011-09-14 Eli Zaretskii <eliz@gnu.org>
6007
6008 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6009 computation of loop end. Reported by Johan Bockgård
6010 <bojohan@gnu.org>.
6011
ef8ef9fb
CY
60122011-09-13 Chong Yidong <cyd@stupidchicken.com>
6013
6014 * frame.c (Fother_visible_frames_p): Function deleted.
6015
fa819fed
EZ
60162011-09-12 Eli Zaretskii <eliz@gnu.org>
6017
6018 * indent.c (compute_motion): Process display vector front to back
6019 rather than the other way around. (Bug#2496)
6020
2ba8e008
SM
60212011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6022
6023 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6024
20f53c69
CY
60252011-09-11 Chong Yidong <cyd@stupidchicken.com>
6026
6027 * minibuf.c (Fread_from_minibuffer): Doc fix.
6028
d562d7a4
EZ
60292011-09-11 Eli Zaretskii <eliz@gnu.org>
6030
6031 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6032 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6033
1c4d7f3d
LMI
60342011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6035
6036 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6037 value for non-existent files.
6038
b885bf36
EZ
60392011-09-11 Eli Zaretskii <eliz@gnu.org>
6040
6041 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6042 set its "size" to -1. This will set the modtime_size field of
6043 the corresponding buffer to -1, which is what
6044 verify-visited-file-modtime expects for files that do not exist.
6045 (Bug#9139)
6046
6612f0bf
PE
60472011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6048
6049 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6050 here ...
6051 * lisp.h: ... from here. push_key_description is no longer
6052 defined in keyboard.c, so its declaration should not be in
6053 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6054 logically belongs with push_key_description.
6055
dfb3f755
PE
60562011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6057
6058 * buffer.h: Include <sys/types.h> instead of <time.h>.
6059 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6060 Problem reported by Herbert J. Skuhra.
6061
3134906c
LMI
60622011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6063
6064 * xml.c (parse_region): Make the parsing work for
6065 non-comment-starting XML files again (bug#9144).
6066
8d903f4e
AS
60672011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6068
6069 * image.c (gif_load): Fix calculation of bottom and right corner.
6070 (Bug#9468)
6071
80ad64f4
EZ
60722011-09-10 Eli Zaretskii <eliz@gnu.org>
6073
6074 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6075 redisplay in small windows.
6076
208a048d
EZ
60772011-09-09 Eli Zaretskii <eliz@gnu.org>
6078
6079 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6080
9b1c252e
MR
60812011-09-08 Martin Rudalics <rudalics@gmx.at>
6082
6083 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6084 Operate on live windows only.
6085
2949f33b
JB
60862011-09-08 Juanma Barranquero <lekktu@gmail.com>
6087
6088 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6089
e08dcafd
EZ
60902011-09-07 Eli Zaretskii <eliz@gnu.org>
6091
6092 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6093 only under bidi iteration.
6094
115b96bd
JD
60952011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6096
6097 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6098
c8199d0f
PE
60992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6100
6101 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6102 Without this fix, the command to link temacs failed due to an
6103 undefined symbol __builtin_isnan. This is because
6104 /usr/include/iso/math_c99.h #defines isnan(x) to
6105 __builtin_isnan(x), but the bundled gcc, which identifies itself
6106 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6107 a __builtin_isnan.
6108 * floatfns.c (isnan): #undef, and then #define to a clone of
6109 what's in data.c.
6110 (Fisnan): Always define, since it's always available now.
6111 (syms_of_floatfns): Always define isnan at the Lisp level.
6112
e39b275c 61132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6114
6115 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6116
b2db44d9 61172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6118
f4af5137 6119 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6120 The previous code assumed that file offsets (off_t values) fit in
6121 EMACS_INT variables, which is not true on typical 32-bit hosts.
6122 The code messed up by falsely reporting buffer overflow in cases
6123 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6124 when "big" contains more than 2**29 bytes, even though this
6125 inserts just one byte and does not overflow the buffer.
6126 (Finsert_file_contents): Store file offsets as off_t
6127 values, not as EMACS_INT values. Check for overflow when
6128 converting between EMACS_INT and off_t. When checking for
6129 buffer overflow or for overlap, take the offsets into account.
6130 Don't use EMACS_INT for small values where int suffices.
6131 When checking for overlap, fix a typo: ZV was used where
6132 ZV_BYTE was intended.
6133 (Fwrite_region): Don't assume off_t fits into 'long'.
6134 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6135
ecfc0a49
MA
61362011-09-05 Michael Albinus <michael.albinus@gmx.de>
6137
6138 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6139
6511acf2 61402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6141
0999621a 6142 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6143
6144 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6145 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6146 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6147 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6148 (modify_event_symbol): Do not assume that the length of
6149 name_alist_or_stem is safe to alloca and fits in int.
6150 (Fexecute_extended_command): Likewise for function name and binding.
6151 (Frecursion_depth): Wrap around reliably on integer overflow.
6152 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6153 since some callers pass EMACS_INT values.
6154 (Fsingle_key_description): Don't crash if symbol name contains more
6155 than MAX_ALLOCA bytes.
6156 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6157 (get_minibuffer): Arg is now EMACS_INT, not int.
6158 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6159 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6160 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6161
2be7d702
PE
6162 * dbusbind.c (signature_cat): New function.
6163 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6164 Do not overrun buffer; instead, report string overflow.
6165
9d1df220
PE
6166 * dispnew.c (add_window_display_history): Don't overrun buffer.
6167 Truncate instead; this is OK since it's just a log.
6168
33ef5c64
PE
6169 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6170 even if the time zone offset is outlandishly large.
6171 Don't mishandle offset == INT_MIN.
6172
66c6fdd5
PE
6173 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6174 when creating daemon; the previous buffer-overflow check was incorrect.
6175
d749b01b
PE
6176 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6177 which has the guts of the old verror function.
6178
b5cd1905
PE
6179 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6180 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6181
6e1a67fb
PE
6182 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6183 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6184 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6185 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6186 length of string rather than counting it via multiple sprintfs;
6187 that's simpler and more reliable.
c21721cc
PE
6188 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6189 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6190 sprintf, in case result does not fit in int.
6191
c57b67fc
PE
6192 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6193 (fontset_from_font): Print it.
6194
8a401434
PE
6195 * frame.c (tty_frame_count): Now printmax_t, not int.
6196 (make_terminal_frame, set_term_frame_name): Print it.
6197 (x_report_frame_params): In X, window IDs are unsigned long,
6198 not signed long, so print them as unsigned.
6199 (validate_x_resource_name): Check for implausibly long names,
6200 and don't assume name length fits in 'int'.
6201 (x_get_resource_string): Don't blindly alloca invocation name;
6202 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6203 not fit in int.
6204
6e1a67fb
PE
6205 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6206 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6207 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6208
0df02bf3
PE
6209 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6210 Use esprintf, not sprintf, in case result does not fit in int.
6211
48e30793
PE
6212 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6213 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6214 it as a large positive number.
6215 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6216 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6217
a66ff6d8
PE
6218 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6219 in case result does not fit in int.
6220
aca216ff
PE
6221 * print.c (float_to_string): Detect width overflow more reliably.
6222 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6223 buffer overrun. Don't assume list length fits in 'int'. Treat
6224 print length of 0 as 0, not as infinity; to be consistent with other
6225 uses of print length in this function. Don't overflow print length
6226 index. Don't assume hash table size fits in 'long', or that
6227 vectorlike size fits in 'unsigned long'.
6228
31c286f7
PE
6229 * process.c (make_process): Use printmax_t, not int, to format
6230 process-name gensyms.
6231
55e5faa1
PE
6232 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6233
80f2e268
PE
6234 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6235 to avoid potential buffer overrun.
6236
670741ab
PE
6237 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6238 if X resource line is longer than 512 bytes.
6239
b7163a50
PE
6240 * xfns.c (x_window): Make sprintf buffer a bit bigger
6241 to avoid potential buffer overrun.
6242
ae58ff1f
PE
6243 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6244
c43c8a6a
PE
6245 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6246
3f8236f4
PE
62472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6248
53e9fe90 6249 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6250 Without these, Emacs silently mishandles large integers sometimes.
6251 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6252 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6253
6511acf2
PE
6254 * xdisp.c (try_window_id): Check Emacs fixnum range before
6255 converting to 'int'.
806add1d 6256
6511acf2 6257 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6258 Check that an Emacs fixnum is in range before assigning it to 'int'.
6259 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6260 values converted from Emacs fixnums.
6261 (Frecenter): Don't wrap around a line count if it is out of 'int'
6262 range; instead, treat it as an extreme value.
6263 (Fset_window_configuration, compare_window_configurations):
6264 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6265
6511acf2
PE
6266 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6267 that can exceed INT_MAX. Check that EMACS_INT value is in range
6268 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6269 (match_limit): Don't assume that a fixnum can fit in 'int'.
6270
6511acf2 6271 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6272 exceed INT_MAX.
6273
6511acf2 6274 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6275 (Fvertical_motion): Don't wrap around LINES values that don't fit
6276 in 'int'. Instead, treat them as extreme values. This is good
6277 enough for windows, which can't have more than INT_MAX lines anyway.
6278
fcb901a7
LMI
62792011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6280
0f2f6b6d
LMI
6281 * Require libxml/parser.h to avoid compilation warning.
6282
fcb901a7
LMI
6283 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6284
6285 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6286 since this reportedly can destroy thread storage.
6287
6e20a0d4
CY
62882011-08-30 Chong Yidong <cyd@stupidchicken.com>
6289
6290 * syntax.c (find_defun_start): Update all cache variables if
6291 exiting early (Bug#9401).
6292
148ae00e
EZ
62932011-08-30 Eli Zaretskii <eliz@gnu.org>
6294
f6cfbd8f
EZ
6295 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6296
148ae00e
EZ
6297 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6298 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6299 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6300
6301 * term.c (tty_append_glyph): New function.
6302 (produce_stretch_glyph): Static function and its prototype deleted.
6303
a66cfb1c
SM
6304 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6305 Add prototypes.
148ae00e 6306
c4a07a4c
PE
63072011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6308
6309 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6310 when checking :margin (Bug#9390).
6311 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6312 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6313 so that the name doesn't mislead. All uses changed.
6314
6bc8cd65
JB
63152011-08-28 Johan Bockgård <bojohan@gnu.org>
6316
6317 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6318 set_tty_hooks.
6319
dca4927e
EZ
63202011-08-27 Eli Zaretskii <eliz@gnu.org>
6321
6322 * xdisp.c (move_it_to): Don't bail out early when reaching
6323 position beyond to_charpos, if we are scanning backwards.
6324 (move_it_vertically_backward): When DY == 0, make sure we get to
6325 the first character in the line after the newline.
6326
f2cad773
PE
63272011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6328
6329 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6330 (ccl_driver): Do not generate an out-of-range pointer.
6331 (Fccl_execute_on_string): Remove unnecessary check for
6332 integer overflow, noted by Stefan Monnier in
6333 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6334 Remove a FIXME that didn't need fixing.
6335 Simplify the newly-introduced buffer reallocation code.
6336
0cae2cdb
JB
63372011-08-27 Juanma Barranquero <lekktu@gmail.com>
6338
6339 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6340
5fc295a4 63412011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6342
70c60eb2 6343 Integer and memory overflow issues (Bug#9196).
726e0ab1 6344
d31850da
PE
6345 * doc.c (get_doc_string): Rework so that
6346 get_doc_string_buffer_size is the actual buffer size, rather than
6347 being 1 less than the actual buffer size; this makes xpalloc more
6348 convenient.
6349
a69fbedb
PE
6350 * image.c (x_allocate_bitmap_record, cache_image):
6351 * xselect.c (Fx_register_dnd_atom):
6352 Simplify previous changes by using xpalloc.
6353
fe5c5d37
PE
6354 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6355 since either will do and ptrdiff_t is convenient with xpalloc.
6356
0065d054
PE
6357 * charset.c (charset_table_size)
6358 (struct charset_sort_data.priority): Now ptrdiff_t.
6359 (charset_compare): Don't overflow if priorities differ greatly.
6360 (Fsort_charsets): Don't assume list length fits in int.
6361 Check for size-calculation overflow when allocating sort data.
6362 (syms_of_charset): Allocate an initial charset table that is
6363 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6364
6365 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6366
6367 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6368 The actual value is always <= INT_MAX, and leaving it unsigned made
6369 overflow checking harder.
6370
6371 * dispextern.h (struct glyph_matrix.rows_allocated)
6372 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6373 with xpalloc. The values are still always <= INT_MAX.
6374
6375 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6376
6377 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6378 (SAFE_NALLOCA): New macro.
6379
6380 * region-cache.c (struct boundary.pos, find_cache_boundary)
6381 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6382 (set_cache_region, invalidate_region_cache)
6383 (revalidate_region_cache, know_region_cache, region_cache_forward)
6384 (region_cache_backward, pp_cache):
6385 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6386 so that ptrdiff_t * can be passed to xpalloc.
6387 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6388 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6389 (pp_cache): Don't assume cache_len fits in int.
6390 * region-cache.h: Adjust extern decls to match.
6391
6392 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6393 EMACS_INT, since either will do, for xpalloc.
6394
6395 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6396 (xnmalloc, xnrealloc, xpalloc): New functions.
6397
726e0ab1
PE
6398 * bidi.c (bidi_shelve_header_size): New constant.
6399 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6400 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6401
51f30bc5 6402 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6403 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6404 (overlay_strings):
6405 Don't update size of array until after memory allocation succeeds,
6406 because xmalloc/xrealloc may not return.
0065d054
PE
6407 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6408 now that we have proper integer overflow checking.
6409 (record_overlay_string, overlay_strings): Catch overflows when
6410 calculating size of overlay_str_buf.
726e0ab1 6411
0065d054
PE
6412 * callproc.c (Fcall_process): Check for size overflow when
6413 calculating size of args2.
6414 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6415 Normally we prefer signed values, but sticking with ptrdiff_t would
6416 require adding more-complicated checks.
726e0ab1
PE
6417
6418 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6419 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6420 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6421 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6422
6423 * character.c (Fstring): Check for size-calculation overflow.
6424
6425 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6426 unnecessary integer overflow. Check for size overflow.
6427 (encode_coding_object): Don't update size until xmalloc succeeds.
6428
6429 * composite.c (get_composition_id): Check for overflow in glyph
6430 length calculations.
6431
6432 Integer and memory overflow fixes for display code.
6433 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6434 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6435 (scrolling_window): Check for overflow in size calculations.
6436 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6437 Don't assume glyph table len fits in int.
6438 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6439 (row_table_size): Now ptrdiff_t, not int.
6440 (scrolling_window): Avoid overflow in size calculations.
6441 Don't update size until allocation succeeds.
6442 * fns.c (concat): Check for overflow in size calculations.
6443 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6444 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6445 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6446
6447 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6448 (get_doc_string): Check for size calculation overflow.
6449 Don't update size until allocation succeeds.
6450 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6451 EMACS_INT, where ptrdiff_t will do.
6452 (Fsubstitute_command_keys): Check for string overflow.
6453
6454 * editfns.c (set_time_zone_rule): Don't assume environment length
6455 fits in int.
6456 (message_length): Now ptrdiff_t, not int.
6457 (Fmessage_box): Don't update size until allocation succeeds.
6458 Don't assume message length fits in int.
6459 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6460
0065d054
PE
6461 * emacs.c (main): Do not reallocate argv, since there is a null at
6462 the end that can be overwritten, and this way there's no need to
6463 worry about size-calculation overflow.
6464 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6465
6466 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6467 alloc succeeds.
6468 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6469
6470 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6471 (x_set_scroll_bar_width, x_figure_window_size):
6472 Check for integer overflow.
6473 (x_set_alpha): Do not assume XINT fits in int.
6474
6475 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6476 This is for the members text_lines, text_cols, total_lines, total_cols,
6477 where the system imposes an 'int' limit.
6478
6479 * fringe.c (Fdefine_fringe_bitmap):
6480 Don't update size until alloc works.
6481
6482 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6483 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6484
6485 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6486 Check for size-calculation overflow.
6487 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6488 do, as we prefer signed integers.
6489 (id_to_widget.max_size, id_to_widget.used)
6490 (xg_store_widget_in_map, xg_remove_widget_from_map)
6491 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6492 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6493 Use and return ptrdiff_t, not int.
6494 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6495 * gtkutil.h: Change prototypes to match the above.
6496
6497 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6498 are duplicate now that they've been promoted to lisp.h.
6499 (x_allocate_bitmap_record, x_alloc_image_color)
6500 (make_image_cache, cache_image, xpm_load):
6501 Don't update size until alloc is done.
6502 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6503 (x_detect_edges):
3256efce 6504 Check for size calculation overflow.
726e0ab1
PE
6505 (ct_colors_allocated_max): New constant.
6506 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6507 overflow.
3256efce 6508
726e0ab1
PE
6509 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6510 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6511 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6512 Use ptrdiff_t, not int, to count maps.
6513 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6514 calculations. Don't update size until allocation succeeds.
6515 Redo calculations to avoid overflow.
726e0ab1
PE
6516 * keyboard.h: Change prototypes to match the above.
6517
6518 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6519 to count maps.
6520 (current_minor_maps): Check for size calculation overflow.
6521 * keymap.h: Change prototypes to match the above.
6522
6523 * lread.c (read1, init_obarray): Don't update size until alloc done.
6524
6525 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6526 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6527
726e0ab1
PE
6528 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6529 Now ptrdiff_t, not int.
6530 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6531 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6532
6533 * process.c (Fnetwork_interface_list): Check for overflow
6534 in size calculation.
6535
6536 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6537
6538 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6539 overflow. Don't bother calling xmalloc when xrealloc will do.
6540
6541 * search.c (Freplace_match): Check for size calculation overflow.
6542 (Fset_match_data): Don't assume list lengths fit in 'int'.
6543
6544 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6545 for command line length. Do not attempt to address one before the
6546 beginning of an array, as that's not portable.
6547
6548 * term.c (max_frame_lines): Remove; unused.
6549 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6550 not int.
6551 (encode_terminal_code, calculate_costs): Check for size
6552 calculation overflow.
6553 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6554 table lengths and related sizes. Don't update size until alloc
6555 done. Redo calculations to avoid overflow.
6556 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6557
6558 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6559 subtracting pointers.
6560 (gobble_line): Check for overflow more carefully. Don't update size
6561 until alloc done.
6562
6563 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6564 Don't update size until alloc done.
6565 Redo size calculations to avoid overflow.
6566 Check for size calculation overflow.
0065d054 6567 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6568
6569 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6570 Use ptrdiff_t, not int, for sizes.
6571 (store_mode_line_noprop_char): Don't update size until alloc done.
6572
0065d054
PE
6573 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6574 Use ptrdiff_t, not int, for sizes.
6575 (Finternal_make_lisp_face, cache_face):
6576 Check for size calculation overflow.
6577 (cache_face): Treat size calculation overflows as if they were
6578 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6579
6580 * xfns.c (x_encode_text, x_set_name_internal)
6581 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6582 sizes, since they can exceed INT_MAX in size. Check for size
6583 calculation overflow.
6584
0065d054
PE
6585 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6586 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6587 Don't update size until alloc done.
6588
0065d054 6589 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6590 as sprintf is limited to int lengths.
1d526e2f 6591
252c5ee1
PE
6592 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6593 (X_LONG_MIN): New macros.
864d7ce7
PE
6594 Use them to make the following changes clearer.
6595 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6596 This change doesn't affect the value now, but it may help remind
6597 future maintainers not to raise the value too much later.
6598 (SELECTION_QUANTUM): Remove, replacing with ...
6599 (selection_quantum): ... new function, which avoids overflow.
6600 All uses changed.
6601 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6602 assumption that selection length fits in 'int'.
6603 (x_reply_selection_request, x_handle_selection_request)
6604 (x_get_window_property, receive_incremental_selection)
6605 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6606 (lisp_data_to_selection_data, clean_local_selection_data):
6607 Use ptrdiff_t, not int, to record length of selection.
6608 (x_reply_selection_request, x_get_window_property)
6609 (receive_incremental_selection, x_property_data_to_lisp):
6610 Redo calculations to avoid overflow.
6611 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6612 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6613 something.
6614 (x_get_window_property, receive_incremental_selection)
6615 (lisp_data_to_selection_data, x_property_data_to_lisp):
6616 Check for size-calculation overflow.
6617 (x_get_window_property, receive_incremental_selection)
6618 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6619 Don't store size until memory allocation succeeds.
6620 (x_get_window_property): Plug memory leak on memory exhaustion.
6621 Don't double-block input; malloc is safe here. Don't assume 2**34
6622 - 4 fits in unsigned long. Add an xassert to check
6623 XGetWindowProperty overflow. Be more careful about overflow
6624 calculations, and distinguish size from memory overflow better.
6625 (receive_incremental_selection): When tracing, don't assume
6626 unsigned int is less than INT_MAX.
6627 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6628 harmful) conversions of unsigned short to int.
6629 (lisp_data_to_selection_data): Don't assume that integers
6630 in the range -65535 through -1 fit in an X unsigned short.
6631 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6632 result parameters unless successful. Rely on cons_to_unsigned
6633 to report problems with elements; the old code wasn't right anyway.
6634 (x_check_property_data): Check for int overflow; we cannot use
6635 a wider type due to X limits.
6636 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6637
726e0ab1 6638 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6639
0065d054
PE
6640 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6641 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6642 (x_color_cells): Don't store size until memory allocation succeeds.
6643 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6644 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6645 (x_term_init): Don't assume length fits in int (sprintf is limited
6646 to int size).
bc18e09d 6647
ebfa62c0
PE
6648 Use ptrdiff_t for composition IDs.
6649 * character.c (lisp_string_width):
6650 * composite.c (composition_table_size, n_compositions)
6651 (get_composition_id, composition_gstring_from_id):
6652 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6653 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6654 * window.c (Frecenter):
6655 Use ptrdiff_t, not int, for composition IDs.
6656 * composite.c (get_composition_id): Check for integer overflow.
6657 * composite.h: Adjust prototypes to match the above changes.
6658
d3411f89
PE
6659 Use ptrdiff_t for hash table indexes.
6660 * category.c (hash_get_category_set):
6661 * ccl.c (ccl_driver):
6662 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6663 * coding.c (coding_system_charset_list, detect_coding_system):
6664 * coding.h (struct coding_system.id):
6665 * composite.c (get_composition_id, gstring_lookup_cache):
6666 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6667 * image.c (xpm_get_color_table_h):
6668 * lisp.h (hash_lookup, hash_put):
6669 * minibuf.c (Ftest_completion):
6670 Use ptrdiff_t for hash table indexes, not int (which is too
6671 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6672 32-bit --with-wide-int hosts).
6673
e097a6fa
PE
6674 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6675 Add a FIXME comment about memory leaks.
6676 (syms_of_charset): Don't assume xmalloc returns.
6677
5637687f
PE
6678 Don't assume that stated character widths fit in int.
6679 * character.c (Fchar_width, c_string_width, lisp_string_width):
6680 * character.h (CHAR_WIDTH):
6681 * indent.c (MULTIBYTE_BYTES_WIDTH):
6682 Use sanitize_char_width to avoid undefined and/or bad behavior
6683 with outlandish widths.
a66cfb1c 6684 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6685 now that we have two such functions. All uses changed.
6686 (sanitize_char_width): New inline function.
6687
a2271ba2
PE
6688 Don't assume that tab-width fits in int.
6689 * character.h (sanitize_width): New inline function.
6690 (SANE_TAB_WIDTH): New macro.
6691 (ASCII_CHAR_WIDTH): Use it.
6692 * indent.c (sane_tab_width): Remove. All uses replaced by
6693 SANE_TAB_WIDTH (current_buffer).
6694 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6695
18c52557
PE
6696 * fileio.c: Integer overflow issues with file modes.
6697 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6698
caeeedc1
PE
6699 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6700 Remove unreachable code.
6701 (read_hex, load_charset_map_from_file): Check for integer overflow.
6702
6df6ae42 6703 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6704 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6705 (x_send_scroll_bar_event): Likewise. Check that the size does not
6706 exceed limits imposed by XClientMessageEvent, as well as the usual
6707 ptrdiff_t and size_t limits.
6708
b13995db
PE
6709 * keyboard.c: Overflow, signedness and related fixes.
6710 (make_lispy_movement): Use same integer type in forward decl
6711 that is used in the definition.
6712 (read_key_sequence, keyremap_step):
6713 Change bufsize argument back to int, undoing my 2011-03-30 change.
6714 We prefer signed types, and int is wide enough here.
6715 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6716 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6717 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6718 length, not size_t. Use ptrdiff_t for index, not int.
6719 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6720 possibility of integer overflow.
6721
13464394
PE
6722 Overflow, signedness and related fixes for images.
6723
6724 * dispextern.h (struct it.stack[0].u.image.image_id)
6725 (struct_it.image_id, struct image.id, struct image_cache.size)
6726 (struct image_cache.used, struct image_cache.ref_count):
6727 * gtkutil.c (update_frame_tool_bar):
6728 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6729 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6730 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6731 * nsmenu.m (update_frame_tool_bar):
6732 * xdisp.c (calc_pixel_width_or_height):
6733 * xfns.c (image_cache_refcount):
6734 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6735 on typical 64-bit hosts.
6736
6737 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6738 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6739 Omit unnecessary casts to int.
6740 (parse_image_spec): Check that integers fall into 'int' range
6741 when the callers expect that.
6742 (image_ascent): Redo ascent calculation to avoid int overflow.
6743 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6744 (lookup_image): Remove unnecessary tests.
6745 (xbm_image_p): Locals are now of int, not EMACS_INT,
6746 since parse_image_check makes sure they fit into int.
6747 (png_load, gif_load, svg_load_image):
6748 Prefer int to unsigned where either will do.
6749 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6750 old tiff_error_handler and tiff_warning_handler.
6751 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6752 stack buffer overflows. It uses only the features of vsnprintf
6753 that are common to both POSIX and native Microsoft.
6754 (tiff_error_handler, tiff_warning_handler): Use it.
6755 (tiff_load, gif_load, imagemagick_load_image):
6756 Don't assume :index value fits in 'int'.
6757 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6758 (imagemagick_load_image): Check that crop parameters fit into
6759 the integer types that MagickCropImage accepts. Don't assume
6760 Vimagemagick_render_type has a nonnegative value. Don't assume
6761 size_t fits in 'long'.
6762 (gs_load): Use printmax_t to print the widest integers possible.
6763 Check for integer overflow when computing image height and width.
6764
c11821d4
EZ
67652011-08-26 Eli Zaretskii <eliz@gnu.org>
6766
6767 * xdisp.c (redisplay_window): Don't force window start if point
6768 will be invisible in the resulting window. (Bug#9324)
6769
0c95fcf7
EZ
67702011-08-25 Eli Zaretskii <eliz@gnu.org>
6771
6772 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6773 the display spec is of the form `(space ...)'.
6774 (handle_display_spec): Return the value returned by
6775 handle_single_display_spec, not just 1 or zero.
6776 (handle_single_display_spec): If the display spec is of the form
6777 `(space ...)', and specifies display in the text area, return 2
6778 rather than 1.
fee65a97 6779 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6780 accurately, and prefer exact match for point under bidi.
6781 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6782
6783 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6784 into disp_prop; all users changed.
6785
6786 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6787 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6788 for the text covered by the display property.
6789
e4ed06f1
CY
67902011-08-25 Chong Yidong <cyd@stupidchicken.com>
6791
6792 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6793 Change return value to nil.
6794 (Frecord_buffer): Delete unused function.
6795
f67cdd7f
EZ
67962011-08-24 Eli Zaretskii <eliz@gnu.org>
6797
5980d4c6
EZ
6798 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6799 buffers, return left-to-right.
8610fe8b
EZ
6800 (set_cursor_from_row): Consider candidate row a win if its glyph
6801 represents a newline and point is on that newline. Fixes cursor
6802 positioning on the newline at EOL of R2L text within L2R
6803 paragraph, and vice versa.
6804 (try_cursor_movement): Check continued rows, in addition to
6805 continuation rows. Fixes unwarranted scroll when point enters a
6806 continued line of R2L text within an L2R paragraph, or vice versa.
6807 (cursor_row_p): Consider the case of point being equal to
6808 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6809 from the end of a short line to the beginning of a continued line
6810 of R2L text within L2R paragraph.
6811 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6812 composed characters.
5980d4c6 6813
f67cdd7f
EZ
6814 * bidi.c (bidi_check_type): Use xassert.
6815 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6816 members.
6817
bca633fb
EZ
68182011-08-23 Eli Zaretskii <eliz@gnu.org>
6819
6820 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6821 a character.
6822
4a5885a7
CY
68232011-08-23 Chong Yidong <cyd@stupidchicken.com>
6824
6825 * nsfont.m (ns_otf_to_script): Fix typo.
6826
0902a04e
KH
68272011-08-22 Kenichi Handa <handa@m17n.org>
6828
6829 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6830 extra slot even if the purpose is char-code-property-table.
6831
1a2e6670
EZ
68322011-08-23 Eli Zaretskii <eliz@gnu.org>
6833
8ddde651
EZ
6834 * xdisp.c (redisplay_window): When computing centering_position,
6835 account for the height of the header line. (Bug#8874)
6836
425cc014
EZ
6837 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6838 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6839 candidate is selected by the mouse, and that candidate has a
6840 composed character under the mouse.
6841
1a2e6670
EZ
6842 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6843 coordinates reported by pos-visible-in-window-p for a composed
6844 character in column zero.
6845
8b76d6f8
SM
68462011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6847
6848 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6849
dac347dd
EZ
68502011-08-22 Eli Zaretskii <eliz@gnu.org>
6851
6852 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6853 consider it a hit if to_charpos is anywhere in the range of the
6854 composed buffer positions.
6855
e013fb34
CY
68562011-08-22 Chong Yidong <cyd@stupidchicken.com>
6857
6858 * image.c (gif_load): Don't assume that each subimage has the same
6859 dimensions as the base image. Handle disposal method that is
6860 "undefined" by the gif spec (Bug#9335).
6861
bd1ba3e8
CY
68622011-08-20 Chong Yidong <cyd@stupidchicken.com>
6863
6864 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6865 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6866
54a1215b
EZ
68672011-08-19 Eli Zaretskii <eliz@gnu.org>
6868
823564e5
EZ
6869 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6870 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6871 from an Org mode buffer to a Speedbar frame.
6872
54a1215b
EZ
6873 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6874 a composition, take its buffer position from IT->cmp_it.charpos.
6875 Fixes cursor positioning at the beginning of a line that begins
6876 with a composed character.
6877
9778ebcc
EZ
68782011-08-18 Eli Zaretskii <eliz@gnu.org>
6879
0be6ee06
EZ
6880 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6881 character bidirectional type, use STRONG_L instead. Fixes crashes
6882 in a buffer produced by `describe-categories'.
6883
9778ebcc
EZ
6884 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6885 members before the level stack, so they would be saved and
6886 restored when copying iterator state. Fixes incorrect reordering
6887 around TABs covered by display properties.
6888
156bffbe
AS
68892011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6890
6b02f655 6891 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6892
72ad093b
CY
68932011-08-17 Chong Yidong <cyd@stupidchicken.com>
6894
6895 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6896 (internal_condition_case_2, internal_condition_case_n):
6897 Remove unnecessary aborts (Bug#9081).
72ad093b 6898
35774242
EZ
68992011-08-17 Eli Zaretskii <eliz@gnu.org>
6900
6901 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6902 has no `load' handler, try opening the file locally. (Bug#9311)
6903
db76dd85
KB
69042011-08-16 Ken Brown <kbrown@cornell.edu>
6905
6906 * gmalloc.c: Expand comment.
6907
b215eee5
EZ
69082011-08-16 Eli Zaretskii <eliz@gnu.org>
6909
6910 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6911 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6912
a4579d33
KB
69132011-08-16 Ken Brown <kbrown@cornell.edu>
6914
6915 Fix memory allocation problems in Cygwin build (Bug#9273).
6916
6917 * unexcw.c ( __malloc_initialized): Declare external variable.
6918 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6919
8b76d6f8
SM
6920 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6921 New variables.
a4579d33
KB
6922 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6923 dumped emacs.
6924 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6925 in the static heap.
6926 [CYGWIN] (special_realloc): New function.
6927 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6928 requests to realloc storage in the static heap.
6929
3ebec551
PE
69302011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6931
6932 * bidi.c (bidi_initialize): Remove unused local.
6933
9fd8be00
EZ
69342011-08-15 Eli Zaretskii <eliz@gnu.org>
6935
6b02f655
SM
6936 * bidimirror.h:
6937 * biditype.h: Remove file.
6938 * makefile.w32-in ($(BLD)/bidi.$(O)):
6939 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6940
6941 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6942
6943 * chartab.c: Improve commentary for the uniprop_table API.
6944
32413314
EZ
6945 * bidi.c (bidi_paragraph_init): Support zero value of
6946 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6947 (bidi_initialize): Use uniprop_table instead of including
6948 biditype.h and bidimirror.h.
32413314 6949
9fd8be00
EZ
6950 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6951 coordinates of the iterator when restoring from ppos_it.
6952 (Bug#9296)
6953
5cf2b69b
KH
69542011-08-14 Kenichi Handa <handa@m17n.org>
6955
6956 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6957 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6958
daf17d00
EZ
69592011-08-14 Eli Zaretskii <eliz@gnu.org>
6960
6961 * xdisp.c (move_it_in_display_line_to): Don't invoke
6962 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6963 ppos_it. Fixes vertical cursor motion when line beginning is
6964 covered by an image. (Bug#9296)
6965
08e3161a
JD
69662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6967
6968 * nsterm.h (ns_run_ascript): Declare.
6969 (NSAPP_DATA2_RUNASSCRIPT): Define.
6970
6971 * nsfns.m (as_script, as_result, as_status): New static variables.
6972 (ns_run_ascript): New function.
5e617bc2 6973 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6974 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6975 the event loop. Get status from as_status (Bug#7276).
6976
6977 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6978 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6979 the event loop (Bug#7276).
6980
a3720aa2
AS
69812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6982
6983 * gnutls.c (QCgnutls_bootprop_priority)
6984 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6985 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6986 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6987 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6988 (QCgnutls_bootprop_verify_hostname_error)
6989 (QCgnutls_bootprop_callbacks_verify): Rename from
6990 Qgnutls_bootprop_..., all uses changed.
6991
6992 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6993 uses changed.
6994
0a0d27fb
PE
69952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6996
19d5c50c
PE
6997 * xfaces.c (Qframe_set_background_mode): Now static.
6998 * dispextern.h (Qframe_set_background_mode): Remove decl.
6999
0a0d27fb
PE
7000 * process.c (Fnetwork_interface_info): Declare local only if needed.
7001
377538cb
JD
70022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7003
7004 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7005 (Fnetwork_interface_list): Allocate in increments of bytes instead
7006 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7007 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7008 sockaddr.
7009 (struct ifflag_def): notrailers is smart on OSX.
7010 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7011 Get hardware address with getifaddrs if available.
7012
08fff70c
EZ
70132011-08-12 Eli Zaretskii <eliz@gnu.org>
7014
7015 * xdisp.c (iterate_out_of_display_property): xassert that
7016 IT->position is set to within IT->object's boundaries. Break from
7017 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7018 when IT->position is set up wrongly due to some bug.
7019 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7020 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7021 entry. Force push_it to save on the stack the current
7022 buffer/string position, to be restored by pop_it. Fix flags in
7023 the iterator structure wrt the object coming from a display
7024 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7025 properties. (Bug#9284)
7026
7be1c708 70272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7028
7be1c708
CY
7029 * fontset.c (fontset_get_font_group): Add proper type checks.
7030 (Bug#9172)
aac0c6e3 7031
7be1c708 70322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7033
7be1c708
CY
7034 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7035 and LC_VERSION_MIN_MACOSX.
7036 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7037 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7038
97bb72a6
EZ
70392011-08-08 Eli Zaretskii <eliz@gnu.org>
7040
7041 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7042 no-display-properties-and-no-overlays under bidi display.
7043 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7044 properties and overlays.
97bb72a6 7045
d5617611
CY
70462011-08-08 Chong Yidong <cyd@stupidchicken.com>
7047
37e11a63
CY
7048 * editfns.c (Fset_time_zone_rule): Document relationship with the
7049 setenv function.
7050
d5617611
CY
7051 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7052 the font entity extracted from the cache (Bug#8109).
7053
58872834
CY
70542011-08-07 Chong Yidong <cyd@stupidchicken.com>
7055
7056 * composite.c (autocmp_chars): Don't reset point. That is done by
7057 restore_point_unwind (Bug#5984).
7058
75bfc667
JL
70592011-08-07 Juri Linkov <juri@jurta.org>
7060
7061 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7062 to show the arg `TIME' instead of `TIMEVAL'.
7063
d1410150
EZ
70642011-08-06 Eli Zaretskii <eliz@gnu.org>
7065
7066 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7067 display property strides EOL and includes a newline, as in
7068 longlines-mode. (Bug#9254)
75b771e4
EZ
7069 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7070 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7071
7072 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7073 is non-zero, even if the data buffer is NULL. Fixes a crash in
7074 vertical-motion with longlines-mode. (Bug#9254)
7075
35928349
EZ
70762011-08-05 Eli Zaretskii <eliz@gnu.org>
7077
ec7cc85b
EZ
7078 * bidi.c <bidi_cache_total_alloc>: Now static.
7079 (bidi_initialize): Initialize bidi_cache_total_alloc.
7080
8b76d6f8 7081 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7082 cache. (Bug#9221)
7083
7084 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7085 amount allocated this far in `bidi_cache_total_alloc'.
7086 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7087 non-zero, only free the data buffer without restoring the cache
7088 contents. All callers changed.
7089
7090 * dispextern.h (bidi_unshelve_cache): Update prototype.
7091
7092 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7093 (move_it_in_display_line, move_it_to)
7094 (move_it_vertically_backward, move_it_by_lines): Replace the call
7095 to xfree to an equivalent call to bidi_unshelve_cache.
7096 (move_it_in_display_line_to): Fix logic of returning
412b6358 7097 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7098
e2e2423b
EZ
70992011-08-05 Eli Zaretskii <eliz@gnu.org>
7100
7101 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7102 came from a string character with a `cursor' property. (Bug#9229)
7103
ae9e757a
JD
71042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7105
7106 * Makefile.in (LIB_PTHREAD): New variable.
7107 (LIBES): Add LIB_PTHREAD (Bug#9216).
7108
7109 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7110 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7111
213bd7f2
AS
71122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7113
6b02f655 7114 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7115
99aaf75f
JD
71162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7117
7118 * xterm.c (x_find_topmost_parent): New function.
7119 (x_set_frame_alpha): Find topmost parent window with
7120 x_find_topmost_parent and set the property there also (bug#9181).
7121 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7122
c74e9d86
PE
71232011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7124
7125 * callproc.c (Fcall_process): Avoid vfork clobbering
7126 the local vars buffer, coding_systems, current_dir.
7127
640c8776
SM
71282011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7129
7130 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7131
f26d0e4c
PE
71322011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7133
8a10d76c
PE
7134 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7135 so that it is not optimized away.
7136
f26d0e4c
PE
7137 * xdisp.c (compute_display_string_pos): Remove unused local.
7138
55439c61
EZ
71392011-08-02 Eli Zaretskii <eliz@gnu.org>
7140
7141 Fix slow cursor motion and scrolling in large buffers with
7142 selective display, like Org Mode buffers. (Bug#9218)
7143
7144 * dispextern.h (struct bidi_it): New member disp_prop_p.
7145
7146 * xdisp.c: Remove one-slot cache of display string positions.
7147 (compute_display_string_pos): Accept an additional argument
5e617bc2 7148 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7149 for a display string or property. If found, set DISP_PROP_P
7150 non-zero.
7151
7152 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7153 DISP_PROP_P, and pass it to compute_display_string_pos.
7154 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7155 non-zero. All callers of bidi_fetch_char changed.
7156
fb33fa43
SM
71572011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7158
7159 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7160
b099e063
DM
71612010-12-03 Don March <don@ohspite.net>
7162
7163 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7164 last character M-[char] is translated to ESC [char] (bug#7541).
7165
5cc7f7af
KH
71662011-08-02 Kenichi Handa <handa@m17n.org>
7167
d0fffa3f 7168 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7169
7170 * chartab.c (uniprop_table): Make it non-static.
7171
525d5e6e
EZ
71722011-08-01 Eli Zaretskii <eliz@gnu.org>
7173
7174 * xdisp.c (forward_to_next_line_start): Accept additional argument
7175 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7176 on the newline.
7177 (reseat_at_next_visible_line_start): Use the bidi iterator state
7178 returned by forward_to_next_line_start to restore the state of
7179 it->bidi_it after backing up to previous newline. (Bug#9212)
7180
31011111
AS
71812011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7182
7183 * regex.c (re_comp): Protoize.
7184 (re_exec): Fix return type.
7185 (regexec): Fix type of `ret'. (Bug#9203)
7186
476371c4
PE
71872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7188
e5d76069
PE
7189 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7190 This is needed if max-image-size is a floating-point number.
7191
9a79b20c
AS
71922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7193
7194 * print.c (print_object): Print empty symbol as ##.
7195
7196 * lread.c (read1): Read ## as empty symbol.
7197
d8c2fa78
AA
71982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7199
7200 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7201 setting frame foreground color (Bug#9175).
7202 (x_set_background_color): Likewise.
7203
ffe57a7a
AA
7204 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7205 contents (Bug#9176).
7206 (EmacsTooltip -init): Remove bezels and add shadows to
7207 tooltip windows.
7208
bf3492a5
AA
7209 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7210 or scroll bar (Bug#8470).
7211
d55e9c53
AA
7212 * nsfont.m (nsfont_open): Remove assignment to voffset and
7213 unnecessary vars hshink, expand, hd, full_height, min_height.
7214 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7215
7216 * nsterm.h (nsfont_info): Remove voffset field.
7217
d8c2fa78 72182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7219
7220 Implement strike-through and overline on NextStep (Bug#8863).
7221
7222 * nsfont.m (nsfont_open): Use underline position provided by font,
7223 instead of hard-coded value of 2.
7224 (nsfont_draw): Call ns_draw_text_decoration instead.
7225
7226 * nsterm.h: Add declaration for ns_draw_text_decoration.
7227
7228 * nsterm.m (ns_draw_text_decoration): New function for drawing
7229 underline, overline, and strike-through.
7230 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7231 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7232 accommodate underlining, etc.
4843aac3 7233
4cc60b9b
EZ
72342011-07-28 Eli Zaretskii <eliz@gnu.org>
7235
bc7ece87
EZ
7236 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7237 default.
4cc60b9b 7238
476371c4
PE
72392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7240
66606eea
PE
7241 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7242 Without this fix, if a signal arrives just after memory fills up,
7243 'malloc' might be invoked reentrantly.
7244
476371c4
PE
7245 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7246 In other words, assume that every image size is allowed, on non-X
7247 hosts. This assumption is probably wrong, but it lets Emacs compile.
7248
f3fcc40d
AS
72492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7250
7251 * regex.c (re_iswctype): Convert return values to boolean.
7252
350c992f
EZ
72532011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7254
7255 * xdisp.c (compute_display_string_pos): Don't use cached display
7256 string position if the buffer had its restriction changed.
7257 (Bug#9184)
7258
5266b4bb
PE
72592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7260
7261 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7262
2573a837 72632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7264
41f55ccd 7265 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7266
39e378da
PE
7267 * bidi.c: Integer size and overflow fixes.
7268 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7269 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7270 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7271 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7272 (bidi_find_other_level_edge):
7273 Use ptrdiff_t instead of EMACS_INT where either will do.
7274 This works better on 32-bit hosts configured --with-wide-int.
7275 (bidi_cache_ensure_space): Check for size-calculation overflow.
7276 Use % rather than repeated addition, for better worst-case speed.
7277 Don't set bidi_cache_size until after xrealloc returns, because it
7278 might not return.
7279 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7280 (bidi_cache_ensure_space): Also check that the bidi cache size
7281 does not exceed that of the largest Lisp string or buffer. See Eli
7282 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7283
5e927815
PE
7284 * alloc.c (__malloc_size_t): Remove.
7285 All uses replaced by size_t. See Andreas Schwab's note
7286 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7287
ca4aa935
PE
7288 * image.c: Improve checking for integer overflow.
7289 (check_image_size): Assume that f is nonnull, since
7290 it is always nonnull in practice. This is one less thing to
7291 worry about when checking for integer overflow later.
7292 (x_check_image_size): New function, which checks for integer
7293 overflow issues inside X.
7294 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7295 This removes the need for a memory_full check.
7296 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7297 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7298 (xbm_read_bitmap_data): Change locals back to 'int', since
7299 their values must fit in 'int'.
7300 (xpm_load_image, png_load, tiff_load):
7301 Invoke x_create_x_image_and_pixmap earlier,
7302 to avoid much needless work if the image is too large.
7303 (tiff_load): Treat overly large images as if
7304 x_create_x_image_and_pixmap failed, not as malloc failures.
7305 (gs_load): Use x_check_image_size.
7306
5f8f9cc2
PE
7307 * gtkutil.c: Omit integer casts.
7308 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7309 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7310
5adf60bc
PE
7311 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7312
c8907a93
PE
7313 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7314 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7315 would wrongly return t on a 64-bit host.
7316
e3c25c68
PE
7317 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7318 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7319 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7320 and therefore cause GCC to emit a bogus diagnostic in some cases.
7321
3f791afe
PE
7322 * image.c: Integer signedness and overflow and related fixes.
7323 This is not an exhaustive set of fixes, but it's time to
7324 record what I've got.
7325 (lookup_pixel_color, check_image_size): Remove redundant decls.
7326 (check_image_size): Don't assume that arbitrary EMACS_INT values
7327 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7328 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7329 (tiff_load, imagemagick_load_image):
7330 Check for overflow in size calculations.
7331 (x_create_x_image_and_pixmap): Remove unnecessary test for
7332 xmalloc returning NULL; that can't happen.
7333 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7334 (xpm_color_bucket): Use better integer hashing function.
7335 (xpm_cache_color): Don't possibly over-allocate memory.
7336 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7337 (gif_memory_source):
7338 Use ptrdiff_t, not int or size_t, to record sizes.
7339 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7340 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7341 either works, as we prefer signed integers.
7342 (tiff_read_from_memory, tiff_write_from_memory):
7343 Return tsize_t, not size_t, since that's what the TIFF API wants.
7344 (tiff_read_from_memory): Don't fail simply because the read would
7345 go past EOF; instead, return a short read.
7346 (tiff_load): Omit no-longer-needed casts.
7347 (Fimagemagick_types): Don't assume size fits into 'int'.
7348
3cc5a532
PE
7349 Improve hashing quality when configured --with-wide-int.
7350 * fns.c (hash_string): New function, taken from sxhash_string.
7351 Do not discard information about ASCII character case; this
7352 discarding is no longer needed.
7353 (sxhash-string): Use it. Change sig to match it. Caller changed.
7354 * lisp.h: Declare it.
7355 * lread.c (hash_string): Remove, since we now use fns.c's version.
7356 The fns.c version returns a wider integer if --with-wide-int is
7357 specified, so this should help the quality of the hashing a bit.
7358
b312a492
PE
7359 * emacs.c: Integer overflow minor fix.
7360 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7361 Define only if GNU_LINUX.
7362 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7363
dfd153ae
PE
7364 * dispnew.c: Integer signedness and overflow fixes.
7365 Remove unnecessary forward decls, that were a maintenance hassle.
7366 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7367 All uses changed.
7368 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7369 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7370 (prepare_desired_row, line_draw_cost):
7371 Use int, not unsigned, where either works.
7372 (save_current_matrix, restore_current_matrix):
7373 Use ptrdiff_t, not size_t, where either works.
7374 (init_display): Check for overflow more accurately, and without
7375 relying on undefined behavior.
7376
a81d11a3
PE
7377 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7378 Remove, replacing with the new symbols in lisp.h. All uses changed.
7379 * fileio.c (make_temp_name):
7380 * filelock.c (lock_file_1, lock_file):
7381 * xdisp.c (message_dolog):
7382 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7383 Use pMd etc. instead.
7384 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7385 replacing the pWIDE etc. symbols removed from editfns.c.
7386
3300e6fd
PE
7387 * keyboard.h (num_input_events): Now uintmax_t.
7388 This is (very slightly) less likely to mess up due to wraparound.
7389 All uses changed.
7390
fd05c7e9
PE
7391 * buffer.c: Integer signedness fixes.
7392 (alloc_buffer_text, enlarge_buffer_text):
7393 Use ptrdiff_t rather than size_t when either will do, as we prefer
7394 signed integers.
7395
903fe15d
PE
7396 * alloc.c: Integer signedness and overflow fixes.
7397 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7398 (__malloc_size_t): Default to size_t, not to int.
7399 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7400 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7401 Prefer ptrdiff_t to size_t when either would do, as we prefer
7402 signed integers.
7403 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7404 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7405 Now const. Initialize with values that are in range even if char
7406 is signed.
7407 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7408 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7409 These functions do the right thing with sizes > 2**32.
7410 (check_depth): Now ptrdiff_t, not int.
7411 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7412 Adjust to new way of storing sizes. Check for size overflow bugs
7413 in rest of code.
7414 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7415 slightly wrong anyway, as it missed one instance of
7416 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7417 (refill_memory_reserve): Omit needless cast to size_t.
7418 (mark_object_loop_halt): Mark as externally visible.
7419
ac82cc6a
PE
7420 * xselect.c: Integer signedness and overflow fixes.
7421 (Fx_register_dnd_atom, x_handle_dnd_message):
7422 Use ptrdiff_t, not size_t, since we prefer signed.
7423 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7424 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7425 x_dnd_atoms_size and x_dnd_atoms_length.
7426
c2d1e36d
PE
7427 * doprnt.c: Prefer signed to unsigned when either works.
7428 * eval.c (verror):
7429 * doprnt.c (doprnt):
7430 * lisp.h (doprnt):
7431 * xdisp.c (vmessage):
7432 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7433 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7434 prefer signed arithmetic to avoid comparison confusion.
7435 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7436 but is a bit tricky.
7437
0e926e56
PE
7438 Assume freestanding C89 headers, string.h, stdlib.h.
7439 * data.c, doprnt.c, floatfns.c, print.c:
7440 Include float.h unconditionally.
7441 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7442 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7443 * regex.c: Likewise for stddef.h, string.h.
7444 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7445 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7446 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7447 (STDC_HEADERS): Remove obsolete defines.
7448 * sysdep.c: Include limits.h unconditionally.
7449
9cfdb3ec
PE
7450 Assume support for memcmp, memcpy, memmove, memset.
7451 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7452 * regex.c (memcmp, memcpy):
7453 Remove; we assume C89 now.
7454
7455 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7456 (__malloc_safe_bcopy): Remove; no longer needed.
7457
cf950e6b 7458 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7459 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7460 well either way, and we prefer signed to unsigned.
7461
dbf38e02
LMI
74622011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7463
7464 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7465 closes the connection while we're reading (bug#9182).
7466
d6f0886c 74672011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7468
d6f0886c
JD
7469 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7470 are specified (Bug#9168).
24e0f6b1 7471
2eb1f9e6
PE
74722011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7473
7474 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7475 Found by GCC static checking and --with-wide-int on a 32-bit host.
7476
22381272 74772011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7478
7479 * xdisp.c (compute_display_string_pos): Fix logic of caching
7480 previous display string position. Initialize cached_prev_pos to
7481 -1. Fixes slow-down at the beginning of a buffer.
7482
f25e39b4
EZ
74832011-07-24 Eli Zaretskii <eliz@gnu.org>
7484
7485 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7486 for attrs[LFACE_FONTSET_INDEX].
7487
04c4b52e
PE
74882011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7489
7490 * xml.c (parse_region): Remove unused local
7491 that was recently introduced.
7492
c1734fbd
EZ
74932011-07-23 Eli Zaretskii <eliz@gnu.org>
7494
be18c5a5
EZ
7495 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7496 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7497
c1734fbd
EZ
7498 * xdisp.c (move_it_in_display_line_to): Record the best matching
7499 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7500 exit if none of the characters scanned was an exact match.
7501 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7502 when exact match is impossible due to invisible text, and the
7503 lines are truncated.
7504
a258d627
JD
75052011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7506
7507 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7508 for OSX >= 10.7.
7509
b6d5a689
EZ
75102011-07-22 Eli Zaretskii <eliz@gnu.org>
7511
0f74f785
EZ
7512 Fix a significant slow-down of cursor motion with C-n, C-p,
7513 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7514 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7515 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7516 (next_element_from_buffer): Call compute_stop_pos_backwards to
7517 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7518 base_level_stop.
7519 (reseat): Don't look for prev_stop, as that could mean a very long
7520 run.
7521 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7522 <cached_disp_overlay_modiff>: Cache for last found display string
7523 position.
551918c1 7524 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7525 about the same buffer in the same area of character positions, and
7526 the buffer wasn't changed since the time the display string
7527 position was cached.
551918c1 7528
b2d0c91a
EZ
75292011-07-22 Eli Zaretskii <eliz@gnu.org>
7530
7531 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7532 is an integer, which is important for empty lines. (Bug#9149)
7533
043604ee
CY
75342011-07-22 Chong Yidong <cyd@stupidchicken.com>
7535
7536 * frame.c (Fmodify_frame_parameters): In tty case, update the
7537 default face if necessary (Bug#4238).
7538
da4adb04
CY
75392011-07-21 Chong Yidong <cyd@stupidchicken.com>
7540
7541 * editfns.c (Fstring_to_char): No need to explain what a character
7542 is in the docstring (Bug#6576).
7543
9abd0532
LMI
75442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7545
7546 * xml.c (parse_region): Make sure we always return a tree.
7547
36881d16
HK
75482011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7549
7550 * xml.c (parse_region): If a document contains only comments,
7551 return that, too.
7552
1e98674d
LMI
75532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7554
7555 * xml.c (make_dom): Return comments, too.
7556
590bd467
PE
75572011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7558
7559 Port to OpenBSD.
7560 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7561 and the surrounding thread.
7562 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7563 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7564 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7565 timer goes off.
7566 * s/openbsd.h (BROKEN_SIGIO): Define.
7567 * unexelf.c (unexec) [__OpenBSD__]:
7568 Don't update the .mdebug section of the Alpha COFF symbol table.
7569
f41628b2
LMI
75702011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7571
7572 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7573 (bug#8460).
7574
b59b67c5
PE
75752011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7576
15e3a074
PE
7577 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7578 This fixes some race conditions on the permissions of any newly
7579 created file.
7580
41bed37d
PE
7581 * alloc.c (valid_pointer_p): Use pipe, not open.
7582 This fixes some permissions issues when debugging.
7583
b59b67c5
PE
7584 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7585 If fchown fails to set both uid and gid, try to set just gid,
7586 as that is sometimes allowed. Adjust the file's mode to eliminate
7587 setuid or setgid bits that are inappropriate if fchown fails.
7588
925a6be7
SM
75892011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7590
7591 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7592 to compare Lisp_Objects.
7593 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7594 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7595 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7596
52968808
AS
75972011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7598
0a6a104b
AS
7599 * lread.c (read_integer): Unread even EOF character.
7600 (read1): Likewise. Properly record start position of symbol.
7601
52968808
AS
7602 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7603 symbol character follows.
7604
9e381cdd
PE
76052011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7606
7607 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7608 This works around a problem with the previous change to Fcopy_file.
7609 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7610 and without this change, GCC might complain about discarding
7611 fchown's return value.
7612
b5641435
JB
76132011-07-16 Juanma Barranquero <lekktu@gmail.com>
7614
7615 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7616
a8031457
PE
76172011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7618
7619 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7620
dd889327
LMI
76212011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7622
750c33f7
LMI
7623 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7624 it's used from the C level.
7625
dd889327
LMI
7626 * process.c: Use the same condition for POLL_FOR_INPUT in both
7627 keyboard.c and process.c (bug#1858).
7628
87e86684
LM
76292011-07-09 Lawrence Mitchell <wence@gmx.li>
7630
7631 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7632 (Fgnutls_boot): Use it.
7633
64348f40
AS
76342011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7635
7636 * doc.c (Fsubstitute_command_keys): Revert last change.
7637
1d698799
LMI
76382011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7639
f863868c
LMI
7640 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7641 quotes the next character, and doesn't affect other longer
7642 sequences (bug#8935).
7643
1d698799
LMI
7644 * lread.c (syms_of_lread): Clarify that is isn't only
7645 `eval-buffer' and `eval-defun' that's affected by
7646 `lexical-binding' (bug#8460).
7647
aa4b6df6
EZ
76482011-07-15 Eli Zaretskii <eliz@gnu.org>
7649
7650 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7651 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7652
5d856da6
PE
76532011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7654
ad6042bb
PE
7655 Fix minor problems found by static checking.
7656 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7657 (elsz): Now a signed constant, not a size_t var. We prefer signed
7658 types to unsigned, to avoid integer comparison confusion. Without
7659 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7660 "cannot optimize loop, the loop counter may overflow", a symptom
7661 of the confusion.
f00bbb22 7662 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7663 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7664
6468f31c
LMI
76652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7666
49080b10
LMI
7667 * search.c (Fre_search_backward): Mention `case-fold-search' in
7668 all the re_search_* functions (bug#8138).
7669
6468f31c
LMI
7670 * keyboard.c (Fopen_dribble_file): Document when the file is
7671 closed (bug#8056).
7672
c965adc5
EZ
76732011-07-14 Eli Zaretskii <eliz@gnu.org>
7674
df9733bf
EZ
7675 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7676 bidi_cache_idx.
7677
0bb23927
EZ
7678 Support bidi reordering of display and overlay strings.
7679 * xdisp.c (compute_display_string_pos)
7680 (compute_display_string_end): Accept additional argument STRING.
7681 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7682 (reseat_to_string): Initialize bidi_it->string.s and
7683 bidi_it->string.schars.
7684 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7685 NULL (avoids a crash in bidi_paragraph_init).
7686 Initialize itb.string.lstring.
0bb23927
EZ
7687 (init_iterator): Call bidi_init_it only of a valid
7688 buffer position was specified. Initialize paragraph_embedding to
7689 L2R.
7690 (reseat_to_string): Initialize the bidi iterator.
7691 (display_string): If we need to ignore text properties of
7692 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7693 original value of -1 will not work with bidi.)
7694 (compute_display_string_pos): First arg is now struct
7695 `text_pos *'; all callers changed. Support display properties on
7696 Lisp strings.
7697 (compute_display_string_end): Support display properties on Lisp
7698 strings.
7699 (init_iterator, reseat_1, reseat_to_string): Initialize the
7700 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7701 when iterating on a string not from display properties).
640c8776
SM
7702 (compute_display_string_pos, compute_display_string_end):
7703 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7704 arrow keys.
7705 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7706 base_level_stop; instead, set base_level_stop to BEGV.
7707 Fixes crashes in vertical-motion.
0bb23927
EZ
7708 (next_element_from_buffer): Improve commentary for when
7709 the iterator is before prev_stop.
7710 (init_iterator): Initialize bidi_p from the default value of
7711 bidi-display-reordering, not from buffer-local value. Use the
7712 buffer-local value only if initializing for buffer iteration.
7713 (handle_invisible_prop): Support invisible properties on strings
7714 that are being bidi-reordered.
7715 (set_iterator_to_next): Support bidi reordering of C strings and
7716 Lisp strings.
7717 (next_element_from_string): Support bidi reordering of Lisp
7718 strings.
7719 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7720 (display_string): Support display of R2L glyph rows.
7721 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7722 (init_iterator): Don't initialize it->bidi_p for strings
7723 here.
7724 (reseat_to_string): Initialize it->bidi_p for strings here.
7725 (next_element_from_string, next_element_from_c_string)
7726 (next_element_from_buffer): Add xassert's for correspondence
7727 between IT's object being iterated and it->bidi_it.string
7728 structure.
7729 (face_before_or_after_it_pos): Support bidi iteration.
7730 (next_element_from_c_string): Handle the case of the first string
7731 character that is not the first one in the visual order.
7732 (get_visually_first_element): New function, refactored from common
7733 parts of next_element_from_buffer, next_element_from_string, and
7734 next_element_from_c_string.
7735 (tool_bar_lines_needed, redisplay_tool_bar)
7736 (display_menu_bar): Force left-to-right direction. Add a FIXME
7737 comment for making that be controlled by a user option.
7738 (push_it, pop_it): Save and restore the state of the
7739 bidi iterator. Save and restore the bidi_p flag.
7740 (pop_it): Iterate out of display property for string iteration as
7741 well.
7742 (iterate_out_of_display_property): Support iteration over strings.
7743 (handle_single_display_spec): Set up it->bidi_it for iteration
7744 over a display string, and call bidi_init_it.
7745 (handle_single_display_spec, next_overlay_string)
7746 (get_overlay_strings_1, push_display_prop): Set up the bidi
7747 iterator for displaying display or overlay strings.
7748 (forward_to_next_line_start): Don't use the shortcut if
7749 bidi-iterating.
7750 (back_to_previous_visible_line_start): If handle_display_prop
7751 pushed the iterator stack, restore the internal state of the bidi
7752 iterator by calling bidi_pop_it same number of times.
7753 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7754 and we are bidi-iterating, don't decrement the iterator position;
7755 instead, set the first_elt flag in the bidi iterator, to produce
7756 the same effect.
7757 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7758 (push_display_prop): xassert that we are iterating a buffer.
7759 (push_it, pop_it): Save and restore paragraph_embedding member.
7760 (handle_single_display_spec, next_overlay_string)
7761 (get_overlay_strings_1, reseat_1, reseat_to_string)
7762 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7763 correctly. Don't assume unibyte strings are not bidi-reordered.
7764 (compute_display_string_pos)
7765 (compute_display_string_end): Fix handling the case of C string.
7766 (push_it, pop_it): Save and restore from_disp_prop_p.
7767 (handle_single_display_spec, push_display_prop): Set the
7768 from_disp_prop_p flag.
7769 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7770 (pop_it): Call iterate_out_of_display_property only if we are
7771 popping after iteration over a string that came from a display
7772 property. Fix a typo in popping stretch info. Add an assertion
7773 for verifying that the iterator position is in sync with the bidi
7774 iterator.
7775 (handle_single_display_spec, get_overlay_strings_1)
7776 (push_display_prop): Fix initialization of paragraph direction for
7777 string when that of the parent object is not yet determined.
7778 (reseat_1): Call bidi_init_it to resync the bidi
7779 iterator with IT's position. (Bug#7616)
7780 (find_row_edges): If ROW->start.pos gives position
7781 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7782 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7783 Reset the from_disp_prop_p flag.
7784 (SAVE_IT, RESTORE_IT): New macros.
7785 (pos_visible_p, face_before_or_after_it_pos)
7786 (back_to_previous_visible_line_start)
7787 (move_it_in_display_line_to, move_it_in_display_line)
7788 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7789 (try_scrolling, redisplay_window, display_line): Use them when
7790 saving a temporary copy of the iterator and restoring it back.
7791 (back_to_previous_visible_line_start, reseat_1)
7792 (init_iterator): Empty the bidi cache "stack".
7793 (move_it_in_display_line_to): If iterator ended up at
7794 EOL, but we never saw any buffer positions smaller than
7795 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7796 motion in bidi-reordered lines.
7797 (move_it_in_display_line_to): Record prev_method and prev_pos
7798 immediately before the call to set_iterator_to_next. Fixes cursor
7799 motion in bidi-reordered lines with stretch glyphs and strings
7800 displayed in margins. (Bug#8133) (Bug#8867)
7801 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7802 TO_CHARPOS.
640c8776
SM
7803 (pos_visible_p): Support positions in bidi-reordered lines.
7804 Save and restore bidi cache.
0bb23927
EZ
7805
7806 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7807 (bidi_paragraph_info): Delete unused struct.
7808 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7809 (bidi_cache_start): New variable.
7810 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7811 to zero.
7812 (bidi_cache_fetch_state, bidi_cache_search)
7813 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7814 (bidi_cache_find, bidi_peek_at_next_level)
7815 (bidi_level_of_next_char, bidi_find_other_level_edge)
7816 (bidi_move_to_visually_next): Compare cache index with
7817 bidi_cache_start rather than with zero.
7818 (bidi_fetch_char): Accept new argument STRING; all callers
7819 changed. Support iteration over a string. Support strings with
7820 display properties. Support unibyte strings. Fix the type of
7821 `len' according to what STRING_CHAR_AND_LENGTH expects.
7822 (bidi_paragraph_init, bidi_resolve_explicit_1)
7823 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7824 (bidi_level_of_next_char, bidi_move_to_visually_next):
7825 Support iteration over a string.
0bb23927
EZ
7826 (bidi_set_sor_type, bidi_resolve_explicit_1)
7827 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7828 can now be zero (for strings); special values 0 and -1 were
7829 changed to -1 and -2, respectively.
7830 (bidi_char_at_pos): New function.
7831 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7832 Call it instead of FETCH_MULTIBYTE_CHAR.
7833 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7834 initialized to valid values.
7835 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7836 values.
7837 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7838 the test for valid cached positions. Fix the logic for looking up
7839 the sentinel state in the cache. GCPRO the Lisp string we are
7840 iterating.
7841 (bidi_push_it, bidi_pop_it): New functions.
7842 (bidi_initialize): Initialize the bidi cache start stack pointer.
7843 (bidi_cache_ensure_space): New function, refactored from part of
7844 bidi_cache_iterator_state. Don't assume the required size is just
7845 one BIDI_CACHE_CHUNK away.
7846 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7847 (bidi_count_bytes, bidi_char_at_pos): New functions.
7848 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7849 always valid if bidi_cache_idx is valid.
7850 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7851 is valid if it's going to be used.
7852 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7853 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7854 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7855 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7856 (bidi_find_other_level_edge, bidi_cache_start_stack):
7857 All variables related to cache indices are now EMACS_INT.
c965adc5 7858
0bb23927
EZ
7859 * dispextern.h (struct bidi_string_data): New structure.
7860 (struct bidi_it): New member `string'. Make flag members be 1-bit
7861 fields, and put them last in the struct.
640c8776
SM
7862 (compute_display_string_pos, compute_display_string_end):
7863 Update prototypes.
0bb23927
EZ
7864 (bidi_push_it, bidi_pop_it): Add prototypes.
7865 (struct iterator_stack_entry): New members bidi_p,
7866 paragraph_embedding, and from_disp_prop_p.
7867 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7868 (bidi_shelve_cache, bidi_unshelve_cache):
7869 Declare prototypes.
0bb23927
EZ
7870
7871 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7872 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7873 and vector-like objects.
7874
7875 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7876 cache around display iteration.
7877
7878 * window.c (Fwindow_end, window_scroll_pixel_based)
7879 (displayed_window_lines, Frecenter): Save and restore the bidi
7880 cache around display iteration.
7881
3bbd2265
LMI
78822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7883
7884 * editfns.c (Fdelete_region): Clarify the use of the named
7885 parameters (bug#6788).
7886
adc47434
MR
78872011-07-14 Martin Rudalics <rudalics@gmx.at>
7888
7889 * indent.c (Fvertical_motion): Set and restore w->pointm when
7890 saving and restoring the window's buffer (Bug#9006).
7891
837c31f8
LMI
78922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7893
7894 * editfns.c (Fstring_to_char): Clarify just what is returned
7895 (bug#6576). Text by Eli Zaretskii.
7896
ac389d0c
JB
78972011-07-13 Juanma Barranquero <lekktu@gmail.com>
7898
7899 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7900
0be0ce47
EZ
79012011-07-13 Eli Zaretskii <eliz@gnu.org>
7902
7903 * buffer.c (mmap_find): Fix a typo.
7904
cd18e7e3
JB
79052011-07-13 Johan Bockgård <bojohan@gnu.org>
7906
7907 Fix execution of x selection hooks.
7908 * xselect.c (Qx_lost_selection_functions)
7909 (Qx_sent_selection_functions): New vars.
7910 (syms_of_xselect): DEFSYM them.
7911 (x_handle_selection_request): Pass Qx_sent_selection_functions
7912 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7913 (x_handle_selection_clear,x_clear_frame_selections):
7914 Pass Qx_lost_selection_functions rather than
7915 Vx_lost_selection_functions to Frun_hook_with_args.
7916
47ea7f44
PE
79172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7918
ac389d0c 7919 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7920 The old code sometimes used this field without initializing it.
7921
47ea7f44
PE
7922 * alloc.c (gc_sweep): Don't read past end of array.
7923 In theory, the old code could also have corrupted Emacs internals,
7924 though it'd be very unlikely.
7925
bc985c87
AS
79262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7927
7928 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7929 argument. (Bug#4026)
bc985c87 7930
0cf34688
LMI
79312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7932
b3dadd76
LMI
7933 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7934 key" (bug#4257).
7935
0cf34688
LMI
7936 * window.c (Fset_window_start): Doc fix (bug#4199).
7937 (Fset_window_hscroll): Ditto.
7938
270768cd
PE
79392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7940
077e3dda 7941 Fix minor new problems caught by GCC 4.6.1.
270768cd 7942 * term.c (init_tty): Remove unused local.
490011a6 7943 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7944 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7945 not used otherwise.
270768cd 7946
b1f58454
CY
79472011-07-12 Chong Yidong <cyd@stupidchicken.com>
7948
7949 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7950
22b9578d
LMI
79512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7952
6e70ab07
LMI
7953 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7954 are the mini-buffer and the echo area (bug#3320).
7955
22b9578d
LMI
7956 * term.c (init_tty): Remove support for supdup, c10 and perq
7957 terminals, which are no longer supported (bug#1482).
7958
8974cc9f
JB
79592011-07-10 Johan Bockgård <bojohan@gnu.org>
7960
7961 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7962
a560d974
JD
79632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7964
7965 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7966 for non-popups (Bug#3642).
7967
1dae0f0a
AS
79682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7969
268c2c36 7970 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7971 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7972 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7973 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7974 * data.c (fmod): Likewise.
7975 * dispnew.c (swap_glyphs_in_rows): Likewise.
7976 * emacs.c (memory_warning_signal): Likewise.
7977 * floatfns.c (float_error): Likewise.
7978 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7979 (otf_open, font_otf_capability, generate_otf_features)
7980 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7981 Likewise.
7982 * image.c (pbm_read_file): Likewise.
7983 * indent.c (string_display_width): Likewise.
7984 * intervals.c (check_for_interval, search_for_interval)
7985 (inc_interval_count, count_intervals, root_interval)
7986 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7987 * lread.c (defalias): Likewise.
268c2c36 7988 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7989 * regex.c (set_image_of_range_1, set_image_of_range)
7990 (regex_grow_registers): Likewise.
7991 * sysdep.c (strerror): Likewise.
7992 * termcap.c (valid_filename_p, tprint, main): Likewise.
7993 * tparam.c (main): Likewise.
7994 * unexhp9k800.c (run_time_remap, save_data_space)
7995 (update_file_ptrs, read_header, write_header, calculate_checksum)
7996 (copy_file, copy_rest, display_header): Likewise.
7997 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7998 Likewise.
7999 * xdisp.c (check_it): Likewise.
8000 * xfaces.c (register_color, unregister_color, unregister_colors):
8001 Likewise.
8002 * xfns.c (print_fontset_result): Likewise.
8003 * xrdb.c (member, fatal, main): Likewise.
8004
99033785
PE
80052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8006
8007 Fix minor problems found by static checking (Bug#9031).
8008 * chartab.c (char_table_set_range, map_sub_char_table):
8009 Remove unused locals.
8010 (uniprop_table): Now static.
8011 * composite.c (_work_char): Remove unused static var.
8012
9cb2ac56
JB
80132011-07-09 Juanma Barranquero <lekktu@gmail.com>
8014
8015 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8016
f25661f0
JD
80172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8018
8019 * gtkutil.c (qttip_cb): Remove code without function.
8020
8278c4fe
EZ
80212011-07-09 Eli Zaretskii <eliz@gnu.org>
8022
8023 * w32.c (pthread_sigmask): New stub.
8024
1692ae2d 80252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8026
8a6ebd58 8027 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8028 sigprocmask is portable only for single-threaded applications, and
8029 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8030 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8031 (LIBES): Use it.
8032 * callproc.c (Fcall_process):
8033 * process.c (create_process):
8034 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8035 Use pthread_sigmask, not sigprocmask.
123403e4 8036
1b854618
JD
80372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8038
8039 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8040 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8041 wrong (Bug#8591).
8042
3fe4b549
JD
80432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8044
0ce7e563
JD
8045 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8046 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8047 (xg_hide_tooltip): Fix comment.
8048
3fe4b549
JD
8049 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8050 in registerServicesMenuSendTypes.
8051 (validRequestorForSendType): Don't check ns_return_types.
8052
8053 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8054 ns_return_type.
8055
5df75e47
JR
80562011-07-08 Jason Rumney <jasonr@gnu.org>
8057
22610910
JR
8058 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8059 SH_SHOW for hidden windows (Bug#5482).
8060
5df75e47
JR
8061 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8062 frame struct members of non-existent frames (Bug#6284).
8063
699c10bd
JD
80642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8065
4393663b
JD
8066 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8067 variable firstTime not needed on OSX >= 10.6.
8068 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8069 >= 10.5. Use setKnobProportion, setDoubleValue.
8070
8071 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8072 (MAC_OS_X_VERSION_10_5): Define if not defined.
8073 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8074 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8075 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8076
8077 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8078 cString and lossyCString on OSX >= 10.4.
4393663b 8079
58179cce 8080 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8081 sizeToFit on OSX >= 10.2.
8082
8083 * nsimage.m (allocInitFromFile): Don't use deprecated method
8084 bestRepresentationForDevice on OSX >= 10.6.
8085
8086 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8087 to avoid warning.
8088
8089 * emacs.c: Declare unexec_init_emacs_zone.
8090
a63e0781
JD
8091 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8092
699c10bd
JD
8093 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8094
8095 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8096 on svcsMenu (Bug#8842).
8097
8098 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8099 ns_return_types.
8100 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8101
8102 * nsterm.m (QUTF8_STRING): Declare.
8103 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8104 (validRequestorForSendType): Return type is (id).
8105 Change indexOfObjectIdenticalTo to indexOfObject.
8106 Check if we have local selection before returning self (Bug#8842).
8107 (writeSelectionToPasteboard): Put local selection into paste board
8108 if we have a local selection (Bug#8842).
8109 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8110
8111 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8112 (ns_get_local_selection): Declare.
8113
54e10184
LMI
81142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8115
9888ff71
LMI
8116 * keymap.c (describe_map_tree): Don't insert a double newline at
8117 the end of the buffer (bug#1169) and return whether we inserted
8118 something.
8119
54e10184
LMI
8120 * callint.c (Fcall_interactively): Change "reading args" to
8121 "providing args" to try to clarify what it does (bug#1010).
8122
15fa4783
KH
81232011-07-07 Kenichi Handa <handa@m17n.org>
8124
8125 * composite.c (composition_compute_stop_pos): Ignore a static
8126 composition starting before CHARPOS (Bug#8915).
8127
8128 * xdisp.c (handle_composition_prop): Likewise.
8129
a8815b00
EZ
81302011-07-07 Eli Zaretskii <eliz@gnu.org>
8131
8132 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8133 (Bug#9015)
8134
ef7b981d 81352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8136
8137 * character.h (unicode_category_t): New enum type.
8138
8139 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8140 (Qchar_code_property_table): New variable.
8141 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8142 (UNIPROP_COMPRESSED_FORM_P): New macros.
8143 (char_table_ascii): Uncompress the compressed values.
8144 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8145 Uncompress the compressed values.
ac389d0c 8146 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8147 (char_table_ref_and_range): Uncompress the compressed values.
8148 (sub_char_table_set): New arg is_uniprop. Callers changed.
8149 Uncompress the compressed values.
8150 (sub_char_table_set_range): Args changed. Callers changed.
8151 (char_table_set_range): Adjuted for the above change.
8152 (map_sub_char_table): Delete args default_val and parent. Add arg
8153 top. Give decoded values to a Lisp function.
640c8776 8154 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8155 values to a Lisp function. Gcpro more variables.
8156 (uniprop_table_uncompress)
8157 (uniprop_decode_value_run_length): New functions.
8158 (uniprop_decoder, uniprop_decoder_count): New variables.
8159 (uniprop_get_decoder, uniprop_encode_value_character)
8160 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8161 New functions.
8162 (uniprop_encoder, uniprop_encoder_count): New variables.
8163 (uniprop_get_encoder, uniprop_table)
8164 (Funicode_property_table_internal, Fget_unicode_property_internal)
8165 (Fput_unicode_property_internal): New functions.
8166 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8167 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8168 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8169 char-code-property-alist.
8170
640c8776 8171 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8172 Vunicode_category_table.
8173
640c8776 8174 * font.c (font_range): Adjust for the change of
c805dec0
KH
8175 Vunicode_category_table.
8176
76b397fb
DN
81772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8178
8179 * m/iris4d.h: Remove file, move contents ...
8180 * s/irix6-5.h: ... here.
8181
22b4128e
PE
81822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8183
8184 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8185 * alloc.c (mark_buffer):
8186 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8187 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8188 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8189 This isn't true in general, and it's particularly not true
8190 if Emacs is configured with --with-wide-int.
8191 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8192 New macros, used in the buffer.c change.
8193
869795d6
JD
81942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8195
8196 * xsettings.c: Use both GConf and GSettings if both are available.
8197 (store_config_changed_event): Add comment.
8198 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8199 (store_tool_bar_style_changed): New functions.
5e617bc2 8200 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8201 (struct xsettings): Move font inside HAVE_XFT.
8202 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8203 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8204 Move inside HAVE_XFT.
640c8776 8205 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8206 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8207 also.
8208 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8209 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8210 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8211 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8212 (parse_settings): Move check for font inside HAVE_XFT.
8213 (read_settings, apply_xft_settings): Add comment.
8214 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8215 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8216 call store_font_name_changed.
8217 (xft_settings_event): Add comment.
8218 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8219 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8220 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8221 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8222 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8223 (xsettings_get_system_font, xsettings_get_system_normal_font):
8224 Add comment.
869795d6 8225
d8ed26bd
PE
82262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8227
8228 Random fixes. E.g., (random) never returned negative values.
8229 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8230 subseconds part to the entropy, as that's a bit more random.
8231 Prefer signed to unsigned, since the signedness doesn't matter and
8232 in general we prefer signed. When given a limit, use a
8233 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8234 latter isn't right if USE_2_TAGS_FOR_INTS.
8235 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8236 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8237
cabf1cac
SM
82382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8239
8240 * textprop.c (text_property_stickiness):
8241 Obey Vtext_property_default_nonsticky.
8242 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8243 * w32fns.c (syms_of_w32fns):
8244 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8245
6e9b2be9
PE
82462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8247
8248 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8249 This is more efficient than Ffile_directory_p and avoids a minor race.
8250
90186c68
LMI
82512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8252
7c301272
LMI
8253 * buffer.c (Foverlay_put): Say what the return value is
8254 (bug#7835).
8255
c4f2d8d4
LMI
8256 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8257 is a directory before asking whether to use the file name
8258 (bug#7564).
ad637907
LMI
8259 (barf_or_query_if_file_exists): Make the "File is a directory"
8260 error be more correct.
c4f2d8d4 8261
90186c68
LMI
8262 * fns.c (Frequire): Remove the mention of the .gz files, since
8263 that's installation-specific, but keep the mention of
8264 `get-load-suffixes'.
8265
da64016e
PE
82662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8267
8268 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8269 Report string overflow if the output is too long.
8270
7d47b580
JB
82712011-07-04 Juanma Barranquero <lekktu@gmail.com>
8272
a555cb87
JB
8273 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8274 (syms_of_gnutls): Remove duplicate DEFSYM for
8275 Qgnutls_bootprop_verify_hostname_error, an error for
8276 Qgnutls_bootprop_verify_error (which is no longer used).
8277
7d47b580
JB
8278 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8279 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8280 Also (re)move comments that are misplaced or no longer relevant.
8281
1e49bfab
LMI
82822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8283
8284 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8285
1485f4c0
CY
82862011-07-03 Chong Yidong <cyd@stupidchicken.com>
8287
8288 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8289 and background color parameters if they have been changed.
8290
a9ab721e
LMI
82912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8292
8293 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8294
cf7cff57
PE
82952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8296
2e13213d
PE
8297 * xsettings.c (SYSTEM_FONT): Define only when used.
8298 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8299
cf7cff57
PE
8300 * keymap.c (access_keymap_1): Now static.
8301
7a8e04f7
CY
83022011-07-02 Chong Yidong <cyd@stupidchicken.com>
8303
8304 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8305 leave any prefix arg for the up event (Bug#1586).
8306
61352f62
LMI
83072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8308
69bb1ef7
LMI
8309 * lread.c (syms_of_lread): Mention single symbols defined by
8310 `defvar' or `defconst' (bug#7154).
8311
61352f62 8312 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8313 (Frequire): Mention get-load-suffixes.
61352f62 8314
28545e04
MR
83152011-07-02 Martin Rudalics <rudalics@gmx.at>
8316
8317 * window.h (window): Remove clone_number slot.
8318 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8319 Remove.
8320 (make_parent_window, make_window, saved_window)
8321 (Fset_window_configuration, save_window_save): Don't deal with
8322 clone numbers.
8323 * buffer.c (Qclone_number): Remove declaration.
8324 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8325
3349e122
SM
83262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8327
8328 Add multiple inheritance to keymaps.
8329 * keymap.c (Fmake_composed_keymap): New function.
8330 (Fset_keymap_parent): Simplify.
8331 (fix_submap_inheritance): Remove.
8332 (access_keymap_1): New function extracted from access_keymap to handle
8333 embedded parents and handle lists of maps.
8334 (access_keymap): Use it.
8335 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8336 (Fcopy_keymap): Handle embedded parents.
8337 (Fcommand_remapping, define_as_prefix): Simplify.
8338 (Fkey_binding): Simplify.
8339 (syms_of_keymap): Move minibuffer-local-completion-map,
8340 minibuffer-local-filename-completion-map,
8341 minibuffer-local-must-match-map, and
8342 minibuffer-local-filename-must-match-map to Elisp.
8343 (syms_of_keymap): Defsubr make-composed-keymap.
8344 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8345 (parse_menu_item): Trivial simplification.
8346
3279eb87
GM
83472011-07-01 Glenn Morris <rgm@gnu.org>
8348
8349 * Makefile.in (SETTINGS_LIBS): Fix typo.
8350
4550efdf
KI
83512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8352
8353 * coding.c (Fencode_coding_string): Record the last coding system
8354 used, as the function doc string says (bug#8738).
8355
0949d2b6
JD
83562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8357
8358 * xsettings.c (store_monospaced_changed): Take new font as arg and
8359 check for change against current_mono_font.
8360 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8361 (emacs_settings_constructor, emacs_settings_get_property)
8362 (emacs_settings_set_property, emacs_settings_class_init)
8363 (emacs_settings_init, gsettings_obj): Remove.
8364 (something_changedCB): New function for HAVE_GSETTINGS.
8365 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8366 with value as argument.
8367 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8368 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8369 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8370 "changed".
8371
8372 * xgselect.c: Add defined (HAVE_GSETTINGS).
8373 (xgselect_initialize): Ditto.
8374
8375 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8376 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8377 xg_select.
8378
bbc6b304
PE
83792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8380
8381 * eval.c (struct backtrace): Simplify and port the data structure.
8382 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8383 signed bit field, as this assumption is not portable and it makes
8384 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8385 "char debug_on_exit : 1" as this is not portable either; instead,
8386 use the portable "unsigned int debug_on_exit : 1". Remove unused
8387 member evalargs. Remove obsolete comments about cc bombing out.
8388
9851bfc5
JD
83892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8390
51bb811f 8391 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8392 Let HAVE_GSETTINGS override HAVE_GCONF.
8393 (store_monospaced_changed): New function.
8394 (EMACS_SETTINGS): A new type derived from GObject to handle
8395 GSettings notifications.
8396 (emacs_settings_constructor, emacs_settings_get_property)
8397 (emacs_settings_set_property, emacs_settings_class_init):
8398 New functions.
8399 (gsettings_client, gsettings_obj): New variables.
8400 (GSETTINGS_SCHEMA): New define.
8401 (something_changedCB): Call store_monospaced_changed.
8402 (init_gsettings): New function.
8403 (xsettings_initialize): Call init_gsettings.
8404 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8405 to NULL.
8406
640c8776 8407 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8408 GCONF_CFLAGS/LIBS.
8409
5386012d
MR
84102011-06-29 Martin Rudalics <rudalics@gmx.at>
8411
8412 * window.c (resize_root_window, grow_mini_window)
8413 (shrink_mini_window): Rename Qresize_root_window to
8414 Qwindow_resize_root_window and Qresize_root_window_vertically to
8415 Qwindow_resize_root_window_vertically.
8416
f13e0b08
PE
84172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8418
8419 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8420
94515237
JB
84212011-06-27 Juanma Barranquero <lekktu@gmail.com>
8422
8423 * makefile.w32-in: Redesign dependencies so they reflect more
8424 clearly which files are directly included by each source file,
8425 and not through other includes.
8426
e43b6e43
MR
84272011-06-27 Martin Rudalics <rudalics@gmx.at>
8428
8429 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8430 (sort_overlays, overlay_strings): When an overlay's clone number
8431 matches the window's clone number process the overlay even if
8432 the overlay's window property doesn't match the current window.
8433
d68443dc
MR
8434 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8435 (Fwindow_hchild): Rename to Fwindow_left_child.
8436 (Fwindow_next): Rename to Fwindow_next_sibling.
8437 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8438 (resize_window_check): Rename to window_resize_check.
8439 (resize_window_apply): Rename to window_resize_apply.
8440 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8441 (Fdelete_other_windows_internal, resize_frame_windows)
8442 (Fsplit_window_internal, Fdelete_window_internal)
8443 (grow_mini_window, shrink_mini_window)
8444 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8445
c7e73be5
JD
84462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8447
8448 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8449 (emacs_fixed_set_min_size): Remove.
8450 (emacs_fixed_new): Take frame as argument.
8451
8452 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8453 (_EmacsFixedPrivate): Remove minwidth/height.
8454 Add struct frame *f.
8455 (emacs_fixed_init): Initialize priv->f.
8456 (get_parent_class, emacs_fixed_set_min_size): Remove.
8457 (emacs_fixed_new): Set priv->f to argument.
8458 (emacs_fixed_get_preferred_width)
8459 (emacs_fixed_get_preferred_height): Use min_width/height from
8460 frames size_hint to set minimum and natural (Bug#8919).
8461 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8462 and use min_width/height from frames size_hint to set
8463 min_width/height (Bug#8919).
8464
8465 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8466 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8467 Fix indentation.
c7e73be5 8468
cf99dcf8
EZ
84692011-06-26 Eli Zaretskii <eliz@gnu.org>
8470
8471 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8472 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8473 called at ZV.
8474
029529ac
CY
84752011-06-26 Chong Yidong <cyd@stupidchicken.com>
8476
8477 * process.c (wait_reading_process_output): Bypass select if
8478 waiting for a cell while ignoring keyboard input, and input is
8479 pending. Suggested by Jan Djärv (Bug#8869).
8480
7a7ef429
PE
84812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8482
8483 Use gnulib's dup2 module instead of rolling our own.
8484 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8485
11fdef7d 84862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8487
8488 * dispnew.c (scrolling_window): Before scrolling, turn off a
8489 mouse-highlight in the window being scrolled.
8490
cd3520a4
JB
84912011-06-24 Juanma Barranquero <lekktu@gmail.com>
8492
8493 Move DEFSYM to lisp.h and use everywhere.
8494
8495 * character.h (DEFSYM): Move declaration...
8496 * lisp.h (DEFSYM): ...here.
8497
8498 * gnutls.c:
8499 * minibuf.c:
8500 * w32menu.c:
8501 * w32proc.c:
8502 * w32select.c: Don't include character.h.
8503
8504 * alloc.c (syms_of_alloc):
8505 * buffer.c (syms_of_buffer):
8506 * bytecode.c (syms_of_bytecode):
8507 * callint.c (syms_of_callint):
8508 * casefiddle.c (syms_of_casefiddle):
8509 * casetab.c (init_casetab_once):
8510 * category.c (init_category_once, syms_of_category):
8511 * ccl.c (syms_of_ccl):
8512 * cmds.c (syms_of_cmds):
8513 * composite.c (syms_of_composite):
8514 * dbusbind.c (syms_of_dbusbind):
8515 * dired.c (syms_of_dired):
8516 * dispnew.c (syms_of_display):
8517 * doc.c (syms_of_doc):
8518 * editfns.c (syms_of_editfns):
8519 * emacs.c (syms_of_emacs):
8520 * eval.c (syms_of_eval):
8521 * fileio.c (syms_of_fileio):
8522 * fns.c (syms_of_fns):
8523 * frame.c (syms_of_frame):
8524 * fringe.c (syms_of_fringe):
8525 * insdel.c (syms_of_insdel):
8526 * keymap.c (syms_of_keymap):
8527 * lread.c (init_obarray, syms_of_lread):
8528 * macros.c (syms_of_macros):
8529 * msdos.c (syms_of_msdos):
8530 * print.c (syms_of_print):
8531 * process.c (syms_of_process):
8532 * search.c (syms_of_search):
8533 * sound.c (syms_of_sound):
8534 * syntax.c (init_syntax_once, syms_of_syntax):
8535 * terminal.c (syms_of_terminal):
8536 * textprop.c (syms_of_textprop):
8537 * undo.c (syms_of_undo):
8538 * w32.c (globals_of_w32):
8539 * window.c (syms_of_window):
8540 * xdisp.c (syms_of_xdisp):
8541 * xfaces.c (syms_of_xfaces):
8542 * xfns.c (syms_of_xfns):
8543 * xmenu.c (syms_of_xmenu):
8544 * xsettings.c (syms_of_xsettings):
8545 * xterm.c (syms_of_xterm): Use DEFSYM.
8546
4228cf16
TZ
85472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8548
cd3520a4 8549 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8550
7fcccf1e
PE
85512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8552
7efb4e0e
PE
8553 Integer and buffer overflow fixes (Bug#8873).
8554
ff5844ad
PE
8555 * print.c (printchar, strout): Check for string overflow.
8556 (PRINTPREPARE, printchar, strout):
8557 Don't set size unless allocation succeeds.
8558
90532f02
PE
8559 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8560 for sizes. Check for string overflow more accurately.
8561 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8562
6d84508d
PE
8563 * macros.c: Integer and buffer overflow fixes.
8564 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8565 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8566 Use ptrdiff_t, not int, for sizes.
8567 Don't increment bufsize until after realloc succeeds.
8568 Check for size-calculation overflow.
8569 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8570
437b2cb4
PE
8571 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8572
8b9ac8b4
PE
8573 * lread.c: Integer overflow fixes.
8574 (read_integer): Radix is now EMACS_INT, not int,
8575 to improve quality of diagnostics for out-of-range radices.
8576 Calculate buffer size correctly for out-of-range radices.
8577 (read1): Check for integer overflow in radices, and in
8578 read-circle numbers.
82cb60d3
PE
8579 (read_escape): Avoid int overflow.
8580 (Fload, openp, read_buffer_size, read1)
8581 (substitute_object_recurse, read_vector, read_list, map_obarray):
8582 Use ptrdiff_t, not int, for sizes.
8583 (read1): Use EMACS_INT, not int, for sizes.
20270765 8584 Check for size overflow.
8b9ac8b4 8585
7fcccf1e
PE
8586 * image.c (cache_image): Check for size arithmetic overflow.
8587
bfbbd7e7
PE
8588 * lread.c: Integer overflow issues.
8589 (saved_doc_string_size, saved_doc_string_length)
8590 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8591 Now ptrdiff_t, not int.
8592 (read1): Don't assume doc string length fits in int. Check for
8593 out-of-range doc string lengths.
8594 (read_list): Don't assume file position fits in int.
39019e54 8595 (read_escape): Check for hex character overflow.
bfbbd7e7 8596
4e323265
LL
85972011-06-22 Leo Liu <sdl.web@gmail.com>
8598
8599 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8600 Move to minibuffer.el.
8601
85fece3e
PE
86022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8603
20b84ce9 8604 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8605 The following patches are for when GLYPH_DEBUG && !XASSERT.
8606 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8607 * dispnew.c (flush_stdout):
8608 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8609 Mark as externally visible.
8610 * dispnew.c (check_window_matrix_pointers): Now static.
8611 * dispnew.c (window_to_frame_vpos):
8612 * xfns.c (unwind_create_frame):
8613 * xterm.c (x_check_font): Remove unused local.
8614 * scroll.c (CHECK_BOUNDS):
8615 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8616 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8617 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8618 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8619 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8620 Now static.
8621 (debug_method_add): Use va_list and vsprintf rather than relying
8622 on undefined behavior with wrong number of arguments.
8623 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8624 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8625 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8626 since we're not interested in debugging glyphs with old libraries.
8627 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8628 GCC 4.6.0's static checking.
8629
0766b489
PE
86302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8631
31fd4b32
PE
8632 Integer overflow and signedness fixes (Bug#8873).
8633 A few related buffer overrun fixes, too.
8634
b79e8648
PE
8635 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8636
0766b489
PE
8637 * dispextern.h (struct face.stipple):
8638 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8639 (x_bitmap_mask, x_allocate_bitmap_record)
8640 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8641 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8642 (x_create_bitmap_from_xpm_data):
8643 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8644 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8645 (.bitmaps_last):
8646 * xfaces.c (load_pixmap):
8647 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8648 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8649 (.bitmaps_last, struct x_output.icon_bitmap):
8650 Use ptrdiff_t, not int, for bitmap indexes.
8651 (x_allocate_bitmap_record): Check for size overflow.
8652 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8653
b081724f
PE
8654 Use ptrdiff_t, not int, for overlay counts.
8655 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8656 * editfns.c (overlays_around, get_pos_property):
8657 * textprop.c (get_char_property_and_overlay):
8658 * xdisp.c (next_overlay_change, note_mouse_highlight):
8659 * xfaces.c (face_at_buffer_position):
21514da7
PE
8660 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8661 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8662 (Fnext_overlay_change, Fprevious_overlay_change)
8663 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8664 Use ptrdiff_t, not int, for sizes.
21514da7 8665 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8666
3de73e5e
PE
8667 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8668
2606c57b
PE
8669 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8670 (x_session_initialize): Do not assume string length fits in int.
8671
aaafe47a
PE
8672 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8673 This is unlikely, but can occur if DPI is outlandish.
8674
2674ddc8 8675 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8676 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8677
28154962
PE
8678 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8679 * xrdb.c (magic_file_p, search_magic_path):
8680 Omit last arg SUFFIX; it was always 0. All callers changed.
8681 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8682
7de51af5
PE
8683 * xfont.c (xfont_match): Avoid need for strlen.
8684
25ed6cc3
PE
8685 * xfns.c: Don't assume strlen fits in int.
8686 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8687
4eab31dd
PE
8688 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8689 not unsigned long, as we prefer signed integers. All callers changed.
8690 Detect integer overflow in repeat count.
8691 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8692 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8693
171e2a58
PE
8694 * termcap.c: Don't assume sizes fit in int and never overflow.
8695 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8696 (gobble_line): Check for size-calculation overflow.
8697
ad39faca 8698 * minibuf.c (Fread_buffer):
6e5bb2dc 8699 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8700 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8701 Don't assume string length fits in int.
8702
52c61c22 8703 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8704 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8705
b5b8c9e5
PE
8706 * font.c: Don't assume string length fits in int.
8707 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8708 Use ptrdiff_t, not int.
ccd6111c
PE
8709 (font_intern_prop): Don't assume string length fits in int.
8710 Don't assume integer property fits in fixnum.
8711 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8712
882f0d81 8713 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8714 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8715 Reformulate so as not to need the command string.
8716 Invoke gzip -cd rather than gunzip, as it's more portable.
8717 (lock_info_type, lock_file_1, lock_file):
8718 Don't assume pid_t and time_t fit in unsigned long.
8719 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8720 (current_lock_owner): Prefer signed type for sizes.
8721 Use memcpy, not strncpy, where memcpy is what is really wanted.
8722 Don't assume (via atoi) that time_t and pid_t fit in int.
8723 Check for time_t and/or pid_t out of range, e.g., via a network share.
8724 Don't alloca where an auto var works fine.
8725
93f4cf88
PE
8726 * fileio.c: Fix some integer overflow issues.
8727 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8728 Don't assume string length fits in int.
8729 (directory_file_name): Don't assume string length fits in long.
8730 (make_temp_name): Don't assume pid fits in int, or that its print
8731 length is less than 20.
8732
f3e92b69
PE
8733 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8734
1bfdaf10
PE
8735 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8736
35016e9a
PE
8737 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8738
3d1e65a1
PE
8739 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8740 We prefer signed integers, even for size calculations.
8741
0b963a93
PE
8742 * emacs.c: Don't assume string length fits in 'int'.
8743 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8744 (main): Don't invoke strlen when not needed.
8745
573f4b54
PE
8746 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8747 (XD_DEBUG_MESSAGE): Don't waste a byte.
8748
989f33ba
PE
8749 * callproc.c (getenv_internal_1, getenv_internal)
8750 (Fgetenv_internal):
965d34eb
PE
8751 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8752
e4d29b33
PE
8753 * lread.c (invalid_syntax): Omit length argument.
8754 All uses changed. This doesn't fix a bug, but it simplifies the
8755 code away from its former Hollerith-constant appearance, and it's
8756 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8757 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8758
eb49b136
PE
8759 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8760 This didn't break anything, but it didn't help either.
8761 It's confusing to put a bogus integer in a place where the actual
8762 value does not matter.
9f62aeb1 8763 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8764 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8765
15375a22
PE
8766 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8767 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8768 implementation.
b61cc01c
PE
8769 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8770 We prefer signed types, and the value cannot exceed the EMACS_INT
8771 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8772 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8773 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8774 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8775
53b2623d
PE
8776 * indent.c (sane_tab_width): New function.
8777 (current_column, scan_for_column, Findent_to, position_indentation)
8778 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8779 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8780
51cab52b 8781 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8782
f2ed8a70
PE
8783 * lisp.h (lint_assume): New macro.
8784 * composite.c (composition_gstring_put_cache):
8785 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8786
abe80cc6
PE
8787 * editfns.c, insdel.c:
8788 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8789
b02c740e
PE
8790 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8791
ebc96716
PE
8792 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8793
b4e50fa0 8794 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8795 Use much-faster test for byte-length change.
311d5d7c 8796 Don't assume string byte-length fits in 'int'.
a4cf38e4 8797 Check that character arg fits in 'int'.
85461888 8798 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8799
c0c1ee9f
PE
8800 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8801
a498d7f4
PE
8802 * fns.c (concat): Catch string overflow earlier.
8803 Do not rely on integer wraparound.
8804
51cab52b
PE
8805 * dispextern.h (struct it.overlay_strings_charpos)
8806 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8807 * xdisp.c (forward_to_next_line_start)
8808 (back_to_previous_visible_line_start)
8809 (reseat_at_next_visible_line_start, next_element_from_buffer):
8810 Don't arbitrarily truncate the value of 'selective' to int.
8811
76031fad
PE
8812 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8813
5eb55db9
PE
8814 * composite.c: Don't truncate sizes to 'int'.
8815 (composition_gstring_p, composition_reseat_it)
8816 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8817 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8818 not EMACS_UINT, for indexes.
5eb55db9 8819
0703a717
PE
8820 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8821
d6202519
PE
8822 * buffer.c: Include <verify.h>.
8823 (struct sortvec.priority, struct sortstr.priority):
8961a454 8824 Now EMACS_INT, not int.
c20998a7 8825 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8826 (struct sortstr.size, record_overlay_string)
8827 (struct sortstrlist.size, struct sortlist.used):
8828 Don't truncate size to int.
8829 (record_overlay_string): Check for size-calculation overflow.
d6202519 8830 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8831
d5a19415
JM
88322011-06-22 Jim Meyering <meyering@redhat.com>
8833
029529ac 8834 Don't leak an XBM-image-sized buffer
d5a19415
JM
8835 * image.c (xbm_load): Free the image buffer after using it.
8836
a9041e6c
PE
88372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8838
8839 Port to Sun C.
8840 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8841 that Sun C diagnosed.
8842 * fns.c (secure_hash): Fix pointer signedness issue.
8843 * intervals.c (static_offset_intervals): New function.
8844 (offset_intervals): Use it.
8845
7f3f739f
LL
88462011-06-21 Leo Liu <sdl.web@gmail.com>
8847
8848 * deps.mk (fns.o):
8849 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8850 sha512.h.
8851
8852 * fns.c (secure_hash): Rename from crypto_hash_function and change
8853 the first arg to accept symbols.
5b66d427 8854 (Fsecure_hash): New primitive.
7f3f739f
LL
8855 (syms_of_fns): New symbols.
8856
76147d94
DD
88572011-06-20 Deniz Dogan <deniz@dogan.se>
8858
8859 * process.c (Fset_process_buffer): Clarify return value in
8860 docstring.
8861
7d7d0045
CY
88622011-06-18 Chong Yidong <cyd@stupidchicken.com>
8863
8864 * dispnew.c (add_window_display_history): Use BVAR.
8865
8866 * xdisp.c (debug_method_add): Use BVAR.
8867 (check_window_end, dump_glyph_matrix, dump_glyph)
8868 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8869
8870 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8871 Likewise.
8872
8873 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8874 check till after the cache is created in init_frame_faces.
8875
ff2bc410
SM
88762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8877
8878 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8879
28177add
PE
88802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8881
dd3482fe
PE
8882 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8883 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8884 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8885
393d71f3 8886 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8887 * fileio.c (Finsert_file_contents):
8888 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8889 Remove the old (too-loose) buffer overflow checks.
8890 They weren't needed, since make_gap checks for buffer overflow.
8891 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8892 The old code merely checked for Emacs fixnum overflow, and relied
8893 on undefined (wraparound) behavior. The new code avoids undefined
8894 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8895
2e6813b0 8896 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8897 Tune. Don't use wider integers than needed. Don't use alloca.
8898 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8899
599a9e4f
PE
8900 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8901
99561444
PE
8902 * insdel.c, lisp.h (buffer_overflow): New function.
8903 (insert_from_buffer_1, replace_range, replace_range_2):
8904 * insdel.c (make_gap_larger):
8905 * editfns.c (Finsert_char):
8906 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8907
28177add
PE
8908 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8909
e69dafad
PE
89102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8911
4baa020d 8912 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8913
b1c46f02
PE
8914 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8915 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8916
e69dafad
PE
8917 * fileio.c: Don't assume EMACS_INT fits in off_t.
8918 (emacs_lseek): New static function.
8919 (Finsert_file_contents, Fwrite_region): Use it.
8920 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8921
566684ea
PE
8922 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8923
e6966cd6
PE
8924 * fns.c: Don't overflow int when computing a list length.
8925 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8926 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8927 truncation on 64-bit hosts. Check for QUIT every
8928 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8929 faster and is responsive enough.
8930 (Flength): Report an error instead of overflowing an integer.
8931 (Fsafe_length): Return a float if the value is not representable
8932 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8933 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8934 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8935
dd0b0efb
PE
8936 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8937 (header_size, word_size): New constants.
8938 (allocate_vectorlike): Don't check size overflow here.
8939 (allocate_vector): Check it here instead, since this is the only
8940 caller of allocate_vectorlike that could cause overflow.
8941 Check that the new vector's length is representable as a fixnum.
8942
86fe5cfe
PE
8943 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8944 The previous code was bogus. For example, next_almost_prime (32)
8945 returned 39, which is undesirable as it is a multiple of 3; and
8946 next_almost_prime (24) returned 25, which is a multiple of 5 so
8947 why was the code bothering to check for multiples of 7?
8948
80e88859
PE
8949 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8950
4a2f0ad6
PE
8951 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8952
f66c7cf8
PE
8953 Variadic C functions now count arguments with ptrdiff_t.
8954 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8955 Back then I didn't know that the Emacs coding style prefers signed int.
8956 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8957 were being counted with int, which may truncate counts on 64-bit
8958 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8959 * lisp.h (struct Lisp_Subr.function.aMANY)
8960 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8961 Arg counts are now ptrdiff_t, not size_t.
8962 All variadic functions and their callers changed accordingly.
8963 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8964 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8965 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8966 * callint.c (Fcall_interactively): Check arg count for overflow,
8967 to avoid potential buffer overrun. Use signed char, not 'int',
8968 for 'varies' array, so that we needn't bother to check its size
8969 calculation for overflow.
8970 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8971 * eval.c (apply_lambda):
8972 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8973 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8974 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8975
a1759b76
PE
8976 * callint.c (Fcall_interactively): Don't use index var as event count.
8977
d96be9fc
PE
8978 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8979 * mem-limits.h (SIZE): Remove; no longer used.
8980
a690a978 8981 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8982
578c21e6
PE
8983 Remove unnecessary casts.
8984 * xterm.c (x_term_init):
8985 * xfns.c (x_set_border_pixel):
8986 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8987 These aren't needed now that we assume ANSI C.
8988
96f53c6c
PE
8989 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8990 It's more likely to cause problems (due to unsigned overflow)
8991 than to cure them.
8992
83c77d31
PE
8993 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8994
ee2079f1
PE
8995 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8996
6da65536
PE
8997 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8998
7147c4a4
PE
8999 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9000
193e32d9
PE
9001 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9002
e5533da6
PE
9003 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9004
9910e595
PE
9005 GLYPH_CODE_FACE returns EMACS_INT, not int.
9006 * dispextern.h (merge_faces):
9007 * xfaces.c (merge_faces):
01103c44
PE
9008 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9009 Don't assume EMACS_INT fits in int.
9910e595 9010
2638320e
PE
9011 * character.h (CHAR_VALID_P): Remove unused parameter.
9012 * fontset.c, lisp.h, xdisp.c: All uses changed.
9013
045eb8d9
PE
9014 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9015
c1f134b5
PE
9016 * fns.c (concat): Minor tuning based on overflow analysis.
9017 This doesn't fix any bugs. Use int to hold character, instead
9018 of constantly refetching from Emacs object. Use XFASTINT, not
9019 XINT, for value known to be a character. Don't bother comparing
9020 a single byte to 0400, as it's always less.
9021
395fcb93 9022 * floatfns.c (Fexpt):
327eeec8
PE
9023 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9024
abbd3d23
PE
9025 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9026 for characters.
9027
684a03ef
PE
9028 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9029
0fed43f3
PE
9030 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9031 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9032 incorrectly succeed when S was a string, because 4294967386 was
9033 truncated before it was used.
9034
8fd02eb7
PE
9035 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9036 Otherwise, an out-of-range integer could cause undefined behavior
9037 on a 64-bit host.
9038
f8c86b69
PE
9039 * composite.c: Use int, not EMACS_INT, for characters.
9040 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9041 EMACS_INT, for values that are known to be in character range.
9042 This doesn't fix any bugs but is the usual style inside Emacs and
9043 may generate better code on 32-bit machines.
9044
34206dd2
PE
9045 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9046 This is for reasons similar to the recent CHAR_STRING fix.
9047 * charset.c (Fencode_char): Check that character arg is actually
9048 a character. Pass an int to ENCODE_CHAR.
9049 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9050 wider than 'int', as a compile-time check to prevent future regressions
9051 in this area.
9052
c5958d4c 9053 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9054
9055 Make sure a 64-bit char is never passed to CHAR_STRING.
9056 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9057 by silently ignoring the top 32 bits, allowing some values
9058 that were far too large to be valid characters.
9059 * character.h: Include <verify.h>.
9060 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9061 arguments are no wider than unsigned, as a compile-time check
9062 to prevent future regressions in this area.
9063 * data.c (Faset):
01103c44 9064 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9065 (Fsubst_char_in_region):
9066 * fns.c (concat):
9067 * xdisp.c (decode_mode_spec_coding):
9068 Adjust to CHAR_STRING's new requirement.
9069 * editfns.c (Finsert_char, Fsubst_char_in_region):
9070 * fns.c (concat): Check that character args are actually
9071 characters. Without this test, these functions did the wrong
9072 thing with wildly out-of-range values on 64-bit hosts.
9073
d37ca623
PE
9074 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9075 These casts should not be needed on 32-bit hosts, either.
9076 * keyboard.c (read_char):
9077 * lread.c (Fload): Remove casts to unsigned.
9078
ea204efb
PE
9079 * lisp.h (UNSIGNED_CMP): New macro.
9080 This fixes comparison bugs on 64-bit hosts.
9081 (ASCII_CHAR_P): Use it.
9082 * casefiddle.c (casify_object):
01103c44 9083 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9084 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9085 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9086 * dispextern.h (FACE_FROM_ID):
9087 * keyboard.c (read_char): Use UNSIGNED_CMP.
9088
41cb286c
PE
9089 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9090 not to EMACS_INT, to avoid GCC warning.
9091
4a1b9832
PE
9092 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9093
55daad71
PE
9094 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9095 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9096 isn't needed on 32-bit machines.
8f95c75c 9097
01103c44
PE
9098 * buffer.c (Fgenerate_new_buffer_name):
9099 Use EMACS_INT for count, not int.
0ceccced 9100 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9101
9102 * data.c (Qcompiled_function): Now static.
9103
c6f072e7
PE
9104 * window.c (window_body_lines): Now static.
9105
20ce5912
PE
9106 * image.c (gif_load): Rename local to avoid shadowing.
9107
9c4c5f81
PE
9108 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9109 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9110 * alloc.c (make_save_value): Integer argument is now of type
9111 ptrdiff_t, not int.
9112 (mark_object): Use ptrdiff_t, not int.
9113 * lisp.h (pD): New macro.
9114 * print.c (print_object): Use it.
9115
c0c5c8ae
PE
9116 * alloc.c: Use EMACS_INT, not int, to count objects.
9117 (total_conses, total_markers, total_symbols, total_vector_size)
9118 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9119 (total_free_floats, total_floats, total_free_intervals)
9120 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9121 Now EMACS_INT, not int. All uses changed.
9122 (Fgarbage_collect): Compute overall total using a double, so that
9123 integer overflow is less likely to be a problem. Check for overflow
9124 when converting back to an integer.
5a25e253
PE
9125 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9126 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9127 These were 'int' variables that could overflow on 64-bit hosts;
9128 they were never used, so remove them instead of repairing them.
211a0b2a 9129 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9130 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9131 Previously, this ceilinged at INT_MAX, but that doesn't work on
9132 64-bit machines.
e46bb31a 9133 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9134
c78baabf 9135 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9136 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9137 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9138 when a (possibly-narrower) signed value would do just as well.
9139 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9140
c9d624c6
PE
9141 * alloc.c: Catch some string size overflows that we were missing.
9142 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9143 for convenience in STRING_BYTES_MAX.
9144 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9145 The definition here is exact; the one in lisp.h was approximate.
9146 (allocate_string_data): Check for string overflow. This catches
9147 some instances we weren't catching before. Also, it catches
9148 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9149 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9150 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9151
c9d624c6
PE
9152 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9153 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9154 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9155
353032ce
PE
9156 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9157
2bccce07
PE
9158 * alloc.c (Fmake_string): Check for out-of-range init.
9159
0ac30604
SM
91602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9161
9162 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9163
c195f2de
JD
91642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9165
9166 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9167 xg_get_default_scrollbar_width.
9168
9169 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9170 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9171 (style_changed_cb): Call update_theme_scrollbar_width and call
9172 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9173 all frames (Bug#8505).
9174 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9175 Call gtk_window_set_resizable if HAVE_GTK3.
9176 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9177 and height if HAVE_GTK3 (Bug#8505).
9178 (scroll_bar_width_for_theme): New variable.
9179 (update_theme_scrollbar_width): New function.
9180 (xg_get_default_scrollbar_width): Move code to
9181 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9182 (xg_initialize): Call update_theme_scrollbar_width.
9183
9184 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9185
9186 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9187
e10ac9f1
MR
91882011-06-12 Martin Rudalics <rudalics@gmx.at>
9189
9190 * frame.c (make_frame): Call other_buffer_safely instead of
9191 other_buffer.
9192
9193 * window.c (temp_output_buffer_show): Call display_buffer with
9194 second argument Vtemp_buffer_show_specifiers and reset latter
9195 immediately after the call.
9196 (Vtemp_buffer_show_specifiers): New variable.
9197 (auto_window_vscroll_p, next_screen_context_lines)
9198 (Vscroll_preserve_screen_position): Remove leading asterisks from
9199 doc-strings.
9200
2d3c217e 92012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9202
7b7f97e8 9203 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9204 * buffer.c (Qclone_number): Remove for now, as it's unused.
9205 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9206 (record_buffer): Remove unused local.
9207 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9208 (set_frame_buffer_list): Remove; unused.
9209 * frame.h (other_visible_frames): Remove decl.
9210 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9211 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9212 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9213 if HAVE_GPM.
9214 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9215 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9216 Define only if HAVE_GPM.
9217 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9218 (update_hints_inhibit): Remove; never set. All uses removed.
9219 * widgetprv.h (emacsFrameClassRec): Remove decl.
9220 * window.c (delete_deletable_window): Now returns void, since it
9221 wasn't returning anything.
9222 (compare_window_configurations): Remove unused locals.
9223 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9224 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9225 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9226 the same widths as pointers. This follows up on the 2011-05-06 patch.
9227 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9228 * xterm.h: Likewise.
9229 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9230
1384b89e
JB
92312011-06-12 Juanma Barranquero <lekktu@gmail.com>
9232
9233 * makefile.w32-in: Update dependencies.
9234 (LISP_H): Add lib/intprops.h.
9235
1100a63c
CY
92362011-06-11 Chong Yidong <cyd@stupidchicken.com>
9237
9238 * image.c (gif_load): Add animation frame delay to the metadata.
9239 (syms_of_image): Use DEFSYM. New symbol `delay'.
9240
6198ccd0
MR
92412011-06-11 Martin Rudalics <rudalics@gmx.at>
9242
9243 * window.c (delete_deletable_window): Re-add.
9244 (Fset_window_configuration): Rewrite to handle dead buffers and
9245 consequently deletable windows.
9246 (window_tree, Fwindow_tree): Remove. Supply functionality in
9247 window.el.
9248 (compare_window_configurations): Simplify code.
9249
b6e3633c
AS
92502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9251
1ab0dee5
AS
9252 * image.c (imagemagick_load_image): Fix type mismatch.
9253 (Fimagemagick_types): Likewise.
9254
b6e3633c
AS
9255 * window.h (replace_buffer_in_windows): Declare.
9256
9397e56f
MR
92572011-06-11 Martin Rudalics <rudalics@gmx.at>
9258
9259 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9260 Qclone_number. Remove external declaration of Qdelete_window.
9261 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9262 code.
640c8776
SM
9263 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9264 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9265 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9266 buffer list implementation.
9267 (other_buffer_safely): New function.
9268 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9269 calls to replace_buffer_in_windows and
9270 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9271 if allowed.
9272 (record_buffer): Inhibit quitting and rewrite using quittable
9273 functions. Run Qbuffer_list_update_hook if allowed.
9274 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9275 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9276 Move switch-to-buffer to window.el.
9397e56f
MR
9277 (bury-buffer): Move to window.el.
9278 (Vbuffer_list_update_hook): New variable.
9279
9280 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9281 section.
9282
9283 * window.h (resize_frame_windows): Move up in code.
9284 (Fwindow_frame): Remove EXFUN.
9285 (replace_buffer_in_all_windows): Remove prototype.
9286 (replace_buffer_in_windows_safely): Add prototype.
9287
9288 * window.c: Declare Qdelete_window static again. Move down
9289 declaration of select_count.
9290 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9291 (Fother_window): Move to window.el.
9292 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9293 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9294 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9295 window.el.
9296 (replace_buffer_in_windows): Implement by calling
9297 Qreplace_buffer_in_windows.
9298 (replace_buffer_in_all_windows): Remove with some functionality
9299 moved into replace_buffer_in_windows_safely.
9300 (replace_buffer_in_windows_safely): New function.
9301 (select_window_norecord, select_frame_norecord): Move in front
9302 of run_window_configuration_change_hook. Remove now obsolete
9303 declarations.
640c8776
SM
9304 (Fset_window_buffer): Rewrite doc-string.
9305 Call Qrecord_window_buffer.
9397e56f
MR
9306 (keys_of_window): Move binding for other-window to window.el.
9307
b50691aa
CY
93082011-06-11 Chong Yidong <cyd@stupidchicken.com>
9309
9310 * dispextern.h (struct image): Replace data member, whose int_val
9311 and ptr_val fields were not used by anything, with a single
9312 lisp_val object.
9313
9314 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9315 (gif_clear_image, gif_load, imagemagick_load_image)
9316 (gs_clear_image, gs_load): Callers changed.
9317
3f754b86
PE
93182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9319
cca69397
PE
9320 * buffer.h: Include <time.h>, for time_t.
9321 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9322
109e28d0
PE
9323 Fix minor problems found by static checking.
9324
60737f02
PE
9325 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9326
4b66faf3
PE
9327 Make identifiers static if they are not used in other modules.
9328 * data.c (Qcompiled_function, Qframe, Qvector):
9329 * image.c (QimageMagick, Qsvg):
9330 * minibuf.c (Qmetadata):
9331 * window.c (resize_window_check, resize_root_window): Now static.
9332 * window.h (resize_window_check, resize_root_window): Remove decls.
9333
109e28d0
PE
9334 * window.c (window_deletion_count, delete_deletable_window):
9335 Remove; unused.
46a4ce9e
PE
9336 (window_body_lines): Now static.
9337 (Fdelete_other_windows_internal): Mark vars as initialized.
9338 Make sure 'resize_failed' is initialized.
9339 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9340 (resize_window_apply): Remove unused local.
9341 * window.h (delete_deletable_window): Remove decl.
9342
109e28d0 9343 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9344 (imagemagick_load_image): Fix pointer signedness problem by changing
9345 last arg from unsigned char * to char *. All uses changed.
9346 Also, fix a local for similar reasons.
9347 Remove unused locals. Remove locals to avoid shadowing.
9348 (fn_rsvg_handle_free): Remove; unused.
9349 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9350 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9351
3f754b86
PE
9352 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9353
2547adb1
CY
93542011-06-10 Chong Yidong <cyd@stupidchicken.com>
9355
9356 * image.c (gif_load): Fix omitted cast error introduced by
9357 2011-06-06 change.
9358
2c8e37d4
MR
93592011-06-10 Martin Rudalics <rudalics@gmx.at>
9360
9361 * window.h (resize_proportionally, orig_total_lines)
9362 (orig_top_line): Remove from window structure.
9363 (set_window_height, set_window_width, change_window_heights)
9364 (Fdelete_window): Remove prototypes.
9365 (resize_frame_windows): Remove duplicate declaration.
9366
440a42e3
EZ
93672011-06-10 Eli Zaretskii <eliz@gnu.org>
9368
9369 * window.h (resize_frame_windows, resize_window_check)
9370 (delete_deletable_window, resize_root_window)
9371 (resize_frame_windows): Declare prototypes.
9372
9373 * window.c (resize_window_apply): Make definition be "static" to
9374 match the prototype.
9375
562dd5e9
MR
93762011-06-10 Martin Rudalics <rudalics@gmx.at>
9377
9378 * window.c: Remove declarations of Qwindow_size_fixed,
9379 window_min_size_1, window_min_size_2, window_min_size,
9380 size_window, window_fixed_size_p, enlarge_window, delete_window.
9381 Remove static from declaration of Qdelete_window, it's
9382 temporarily needed by Fbury_buffer.
9383 (replace_window): Don't assign orig_top_line and
9384 orig_total_lines.
9385 (Fdelete_window, delete_window): Remove. Window deletion is
9386 handled by window.el.
640c8776
SM
9387 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9388 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9389 (Fdelete_other_windows): Remove. Deleting other windows is
9390 handled by window.el.
9391 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9392 handled in window.el.
9393 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9394 Window minimum sizes are handled in window.el.
9395 (shrink_windows, size_window, set_window_height)
9396 (set_window_width, change_window_heights, window_height)
9397 (window_width, CURBEG, CURSIZE, enlarge_window)
9398 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9399 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9400 handled in window.el.
9401 (make_dummy_parent): Rename to make_parent_window and give it a
9402 second argument horflag.
9403 (make_window): Don't set resize_proportionally any more.
9404 (Fsplit_window): Remove. Windows are split in window.el.
9405 (save_restore_action, save_restore_orig_size)
9406 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9407 Resize mini windows in window.el.
9408 (grow_mini_window, shrink_mini_window): Implement by calling
9409 Qresize_root_window_vertically, resize_window_check and
9410 resize_window_apply.
640c8776
SM
9411 (saved_window, Fset_window_configuration, save_window_save):
9412 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9413 resize_proportionally.
9414 (window_min_height, window_min_width): Move to window.el.
9415 (keys_of_window): Move bindings for delete-other-windows,
9416 split-window, delete-window and enlarge-window to window.el.
9417
9418 * buffer.c: Temporarily extern Qdelete_window.
9419 (Fbury_buffer): Temporarily call Qdelete_window instead of
9420 Fdelete_window (Fbury_buffer will move to window.el soon).
9421
9422 * frame.c (set_menu_bar_lines_1): Remove code handling
9423 orig_top_line and orig_total_lines.
9424
9425 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9426 set_window_height but set heights directly.
9427 (change_frame_size_1): Use resize_frame_windows.
9428
9429 * xdisp.c (init_xdisp): Don't use set_window_height but set
9430 heights directly.
9431
640c8776
SM
9432 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9433 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9434 run_window_configuration_change_hook.
9435
9436 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9437 instead of change_window_heights and run
9438 run_window_configuration_change_hook.
9439
1a13852e
MR
94402011-06-09 Martin Rudalics <rudalics@gmx.at>
9441
9442 * window.c (replace_window): Rename second argument REPLACEMENT to
9443 NEW. New third argument SETFLAG. Rewrite.
9444 (delete_window, make_dummy_parent): Call replace_window with
9445 third argument 1.
9446 (window_list_1): Move down in code.
9447 (run_window_configuration_change_hook): Move set_buffer part
9448 before select_frame_norecord part in order to unwind correctly.
9449 Rename count1 to count.
9450 (recombine_windows, delete_deletable_window, resize_root_window)
9451 (Fdelete_other_windows_internal)
9452 (Frun_window_configuration_change_hook, make_parent_window)
9453 (resize_window_check, resize_window_apply, Fresize_window_apply)
9454 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9455 (Fdelete_window_internal, Fresize_mini_window_internal):
9456 New functions.
1a13852e
MR
9457 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9458
f3d1777e
MR
94592011-06-08 Martin Rudalics <rudalics@gmx.at>
9460
496e208e
MR
9461 * window.h (window): Add some new members to window structure -
9462 normal_lines, normal_cols, new_total, new_normal, clone_number,
9463 splits, nest, prev_buffers, next_buffers.
9464 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9465 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9466
f3d1777e
MR
9467 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9468 Remove.
496e208e
MR
9469 (make_dummy_parent): Set new members of windows structure.
9470 (make_window): Move down in code. Handle new members of window
9471 structure.
9472 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9473 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9474 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9475 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9476 (Fset_window_next_buffers, Fset_window_clone_number):
9477 New functions.
496e208e
MR
9478 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9479 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9480 Doc-string fixes.
9481 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9482 Argument WINDOW can be now internal window too.
9483 (Fwindow_use_time): Move up in code.
9484 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9485 Rewrite doc-string.
9486 (Fset_window_configuration, saved_window)
9487 (Fcurrent_window_configuration, save_window_save): Handle new
9488 members of window structure.
b9e809c2
MR
9489 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9490 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9491 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9492 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9493 Qget_mru_window, Qresize_root_window,
9494 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9495 Qauto_buffer_name; staticpro them.
f3d1777e 9496
abde8f8c
MR
94972011-06-07 Martin Rudalics <rudalics@gmx.at>
9498
9499 * window.c (Fwindow_total_size, Fwindow_left_column)
9500 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9501 (Fwindow_list_1): New functions.
9502 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9503 (Fwindow_width, Fscroll_left, Fscroll_right):
9504 Use window_body_cols instead of window_box_text_cols.
9505 (delete_window, Fset_window_configuration):
9506 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9507 (delete_all_subwindows): Take a window as argument and not a
9508 structure. Rewrite.
190b47e6
MR
9509 (window_loop): Remove handling of GET_LRU_WINDOW and
9510 GET_LARGEST_WINDOW.
9511 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9512
9513 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9514 window_box_text_cols. delete_all_subwindows now takes a
9515 Lisp_Object as argument.
abde8f8c 9516
640c8776
SM
9517 * indent.c (compute_motion, Fcompute_motion):
9518 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9519
fa8a67e6
MR
9520 * frame.c (delete_frame): Call delete_all_subwindows with root
9521 window as argument.
9522
a54e3482
DC
95232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9524
9525 * fns.c (Fputhash): Document return value.
9526
60002bf5
CY
95272011-06-06 Chong Yidong <cyd@stupidchicken.com>
9528
9529 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9530
0c671da6 95312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9532
b862a52a 9533 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9534
be44ca6c
PE
9535 Check for overflow when converting integer to cons and back.
9536 * charset.c (Fdefine_charset_internal, Fdecode_char):
9537 Use cons_to_unsigned to catch overflow.
9538 (Fencode_char): Use INTEGER_TO_CONS.
9539 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9540 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9541 * data.c (long_to_cons, cons_to_long): Remove.
9542 (cons_to_unsigned, cons_to_signed): New functions.
9543 These signal an error for invalid or out-of-range values.
9544 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9545 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9546 * font.c (Ffont_variation_glyphs):
9547 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9548 * lisp.h: Include <intprops.h>.
9549 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9550 (cons_to_signed, cons_to_unsigned): New decls.
9551 (long_to_cons, cons_to_long): Remove decls.
9552 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9553 (Fprimitive_undo): Use CONS_TO_INTEGER.
9554 * xfns.c (Fx_window_property): Likewise.
9555 * xselect.c: Include <limits.h>.
9556 (x_own_selection, selection_data_to_lisp_data):
9557 Use INTEGER_TO_CONS.
9558 (x_handle_selection_request, x_handle_selection_clear)
9559 (x_get_foreign_selection, Fx_disown_selection_internal)
9560 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9561 (lisp_data_to_selection_data): Use cons_to_unsigned.
9562 (x_fill_property_data): Use cons_to_signed.
9563 Report values out of range.
9564
d1f3d2af
PE
9565 Check for buffer and string overflow more precisely.
9566 * buffer.h (BUF_BYTES_MAX): New macro.
9567 * lisp.h (STRING_BYTES_MAX): New macro.
9568 * alloc.c (Fmake_string):
9569 * character.c (string_escape_byte8):
9570 * coding.c (coding_alloc_by_realloc):
9571 * doprnt.c (doprnt):
9572 * editfns.c (Fformat):
9573 * eval.c (verror):
9574 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9575 since they may not be the same number.
9576 * editfns.c (Finsert_char):
9577 * fileio.c (Finsert_file_contents):
9578 Likewise for BUF_BYTES_MAX.
9579
dd52fcea
PE
9580 * image.c: Use ptrdiff_t, not int, for sizes.
9581 (slurp_file): Switch from int to ptrdiff_t.
9582 All uses changed.
9583 (slurp_file): Check that file size fits in both size_t (for
9584 malloc) and ptrdiff_t (for sanity and safety).
9585
7f9bbdbb
PE
9586 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9587 if b->modtime has its maximal value.
9588
dfe18f82
PE
9589 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9590
84acfcf0
PE
9591 Don't assume time_t can fit into int.
9592 * buffer.h (struct buffer.modtime): Now time_t, not int.
9593 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9594 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9595
ccd9a01a
PE
9596 Minor fixes for signed vs unsigned integers.
9597 * character.h (MAYBE_UNIFY_CHAR):
9598 * charset.c (maybe_unify_char):
9599 * keyboard.c (read_char, reorder_modifiers):
9600 XINT -> XFASTINT, since the integer must be nonnegative.
9601 * ftfont.c (ftfont_spec_pattern):
9602 * keymap.c (access_keymap, silly_event_symbol_error):
9603 XUINT -> XFASTINT, since the integer must be nonnegative.
9604 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9605 since it makes no difference and we prefer signed.
9606 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9607 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9608 nonnegative.
9609
d6d100dd
SM
96102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9611
9612 * window.h (Fwindow_frame): Declare.
9613
2b6148e4
PE
96142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9615
9616 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9617 (SPARE_MEMORY): Always define.
9618 (LARGE_REQUEST): Remove.
9619 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9620
f230ecc9
MR
96212011-06-06 Martin Rudalics <rudalics@gmx.at>
9622
727e958e
MR
9623 * lisp.h: Move EXFUNS for Fframe_root_window,
9624 Fframe_first_window and Fset_frame_selected_window to window.h.
9625
9626 * window.h: Move EXFUNS for Fframe_root_window,
9627 Fframe_first_window and Fset_frame_selected_window here from
9628 lisp.h.
9629
9630 * frame.c (Fwindow_frame, Fframe_first_window)
9631 (Fframe_root_window, Fframe_selected_window)
9632 (Fset_frame_selected_window): Move to window.c.
9633 (Factive_minibuffer_window): Move to minibuf.c.
9634 (Fother_visible_frames_p): New function.
9635
9636 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9637
f230ecc9
MR
9638 * window.c (decode_window, decode_any_window): Move up in code.
9639 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9640 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9641 (Fwindow_buffer): Move up and rewrite doc-string.
9642 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9643 (Fwindow_prev): New functions.
727e958e
MR
9644 (Fwindow_frame): Move here from frame.c. Accept any window as
9645 argument.
9646 (Fframe_root_window, Fframe_first_window)
9647 (Fframe_selected_window): Move here from frame.c. Accept frame
9648 or arbitrary window as argument. Update doc-strings.
9649 (Fminibuffer_window): Move up in code.
9650 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9651 (Fset_frame_selected_window): Move here from frame.c.
9652 Marginal rewrite.
727e958e
MR
9653 (Fselected_window, select_window, Fselect_window): Move up in
9654 code. Minor doc-string fixes.
f230ecc9 9655
4d09bcf6
PE
96562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9657
9658 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9659 Do not assume that spare memory exists; that assumption is valid
9660 only if SYSTEM_MALLOC.
9661 (LARGE_REQUEST): New macro, so that the issue of large requests
9662 is separated from the issue of spare memory.
9663
810928a2
AS
96642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9665
172418ad
AS
9666 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9667 format. (Bug#8806)
9668
43f862f7
AS
9669 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9670
810928a2
AS
9671 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9672 before statements.
9673
a059fe24
JD
96742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9675
9676 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9677
9678 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9679
9680 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9681 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9682
989bf368
JB
96832011-06-05 Juanma Barranquero <lekktu@gmail.com>
9684
9685 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9686
4b80f674
CY
96872011-06-04 Chong Yidong <cyd@stupidchicken.com>
9688
9689 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9690 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9691 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9692 New error handlers.
4b80f674
CY
9693 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9694 Obey Vx_select_enable_clipboard_manager. Catch errors in
9695 x_clipboard_manager_save (Bug#8779).
9696 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9697 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9698
99a33b77 96992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9700
9701 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9702
99a33b77 97032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9704
9705 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9706 in the current matrix if keep_current_p is non-zero.
9707
8264569d
EZ
97082011-06-04 Eli Zaretskii <eliz@gnu.org>
9709
9710 * bidi.c (bidi_level_of_next_char): Fix last change.
9711
57f97249
EZ
97122011-06-03 Eli Zaretskii <eliz@gnu.org>
9713
fec2107c 9714 Support bidi reordering of text covered by display properties.
57f97249 9715
fec2107c
EZ
9716 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9717 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9718 (bidi_cache_search, bidi_cache_iterator_state)
9719 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9720 (bidi_level_of_next_char, bidi_move_to_visually_next):
9721 Support character positions inside a run of characters covered by a
fec2107c
EZ
9722 display string.
9723 (bidi_paragraph_init, bidi_resolve_explicit_1)
9724 (bidi_level_of_next_char): Call bidi_fetch_char and
9725 bidi_fetch_char_advance instead of FETCH_CHAR and
9726 FETCH_CHAR_ADVANCE.
9727 (bidi_init_it): Initialize new members.
9728 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9729 definitions.
9730 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9731 instead of using explicit *_CHAR codes.
d6d100dd
SM
9732 (bidi_resolve_explicit, bidi_resolve_weak):
9733 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9734 bidirectional text is supported only in multibyte buffers.
9735 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9736 it to initialize the frame_window_p member of struct bidi_it.
9737 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9738 (bidi_resolve_explicit, bidi_resolve_weak)
9739 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9740 bidi_it->nchars is non-positive.
9741 (bidi_level_of_next_char): Don't try to lookup the cache for the
9742 next/previous character if nothing is cached there yet, or if we
9743 were just reseat()'ed to a new position.
c40e2fb2 9744
0e14fe90
EZ
9745 * xdisp.c (set_cursor_from_row): Set start and stop points
9746 according to the row's direction when priming the loop that looks
9747 for the glyph on which to display cursor.
9748 (single_display_spec_intangible_p): Function deleted.
9749 (display_prop_intangible_p): Reimplement to call
9750 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9751 Accept 3 additional arguments needed by handle_display_spec.
9752 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9753 values: lists, `(when COND...)' forms, etc.
9754 (single_display_spec_string_p): Support property values that are
9755 lists with the argument STRING its top-level element.
9756 (display_prop_string_p): Fix the condition for processing a
9757 property that is a list to be consistent with handle_display_spec.
fec2107c 9758 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9759 last portion of handle_display_prop.
9760 (compute_display_string_pos): Accept additional argument
9761 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9762 value of a `display' property is a "replacing spec".
9763 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9764 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9765 the display property, but just return a value indicating whether
9766 the display property will replace the characters it covers.
9767 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9768 frame_window_p members of struct bidi_it.
d6d100dd
SM
9769 (compute_display_string_pos, compute_display_string_end):
9770 New functions.
fec2107c
EZ
9771 (push_it): Accept second argument POSITION, where pop_it should
9772 jump to continue iteration.
9773 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9774
fec2107c
EZ
9775 * keyboard.c (adjust_point_for_property): Adjust the call to
9776 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9777
9778 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9779 (bidi_init_it): Update prototypes.
9780 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9781 (compute_display_string_pos, compute_display_string_end):
9782 Declare prototypes.
fec2107c
EZ
9783 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9784 EMACS_INT.
fc6f18ce 9785
40087514 97862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9787
57f53182
PE
9788 Malloc failure behavior now depends on size of allocation.
9789 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9790 * lisp.h: Change signatures accordingly.
9791 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9792 All callers changed. (Bug#8762)
9793
9794 * gnutls.c: Use Emacs's memory allocators.
9795 Without this change, the gnutls library would invoke malloc etc.
9796 directly, which causes problems on non-SYNC_INPUT hosts, and which
9797 runs afoul of improving memory_full behavior. (Bug#8761)
9798 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9799 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9800 xfree instead of the default malloc, realloc, free.
9801 (Fgnutls_boot): No need to check for memory allocation failure,
9802 since xmalloc does that for us.
9803
ac32cd99 9804 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9805 * category.c (hash_get_category_set):
9806 * ccl.c (ccl_driver):
9807 * charset.c (Fdefine_charset_internal):
9808 * charset.h (struct charset.hash_index):
9809 * composite.c (get_composition_id, gstring_lookup_cache)
9810 (composition_gstring_put_cache):
9811 * composite.h (struct composition.hash_index):
9812 * dispextern.h (struct image.hash):
9813 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9814 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9815 (hashfn_equal, hashfn_user_defined, make_hash_table)
9816 (maybe_resize_hash_table, hash_lookup, hash_put)
9817 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9818 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9819 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9820 * image.c (make_image, search_image_cache, lookup_image)
9821 (xpm_put_color_table_h):
9822 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9823 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9824 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9825 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9826 * alloc.c (allocate_vectorlike):
9827 Check for overflow in vector size calculations.
9828 * ccl.c (ccl_driver):
9829 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9830 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9831 need to be updated by these changes.
40087514
PE
9832 * fns.c (make_hash_table, maybe_resize_hash_table):
9833 Check for integer overflow with large hash tables.
0de4bb68
PE
9834 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9835 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9836 (SXHASH_REDUCE): New macro.
9837 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9838 Use it instead of discarding useful hash info with large hash values.
9839 (sxhash_float): New function.
9840 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9841 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9842 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9843 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9844 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9845 Adjust signatures to match updated version of code.
9846 (consing_since_gc): Now EMACS_INT, since a single hash table can
9847 use more than INT_MAX bytes.
9848
698d32e2
DN
98492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9850
9851 Make it possible to build with GCC-4.6+ -O2 -flto.
9852
9853 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9854
fd6fa53f
SM
98552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9856
9857 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9858 Call minibuffer-inactive-mode.
9859
864db017
JB
98602011-05-31 Juanma Barranquero <lekktu@gmail.com>
9861
9862 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9863 Update dependencies.
9864
2ad0baf4
DN
98652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9866
9867 * data.c (init_data): Remove code for UTS, this system is not
9868 supported anymore.
9869
4fcc2638
DN
98702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9871
9872 Don't force ./temacs to start in terminal mode.
9873
9874 * frame.c (make_initial_frame): Initialize faces in all cases, not
9875 only when CANNOT_DUMP is defined.
9876 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9877
c56e0fd5
DN
98782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9879
9880 * dispnew.c (add_window_display_history): Use const for the string
9881 pointer. Remove declaration, not needed.
9882
333d54da 98832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9884
55d4c1b2 9885 Use 'inline', not 'INLINE'.
333d54da 9886 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9887 * alloc.c, fontset.c (INLINE): Remove.
9888 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9889 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9890 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9891 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9892 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9893
738db178
DN
98942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9895
9896 Make it possible to run ./temacs.
9897
9898 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9899 syms_of_callproc does the same thing. Remove test for
9900 "initialized", do it in the caller.
9901 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9902
620c53a6
SM
99032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9904
9905 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9906 (read_minibuf): Use get_minibuffer.
9907 (syms_of_minibuf): Use DEFSYM.
9908 (Qmetadata): New var.
9909 * data.c (Qbuffer): Don't make it static.
9910 (syms_of_data): Use DEFSYM.
9911
e003a292
PE
99122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9913
9914 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9915 (CCL_CODE_MIN): New macro.
9916
ed008a6d
PE
99172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9918
3687c2ef
PE
9919 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9920
ed008a6d
PE
9921 * eval.c (Qdebug): Now static.
9922 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9923 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9924 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9925
d66c4c7c
CY
99262011-05-29 Chong Yidong <cyd@stupidchicken.com>
9927
9928 * image.c: Various fixes to ImageMagick code comments.
9929 (Fimagemagick_types): Doc fix.
9930
5fbc2025
PE
99312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9932
0196f88a
PE
9933 Minor fixes prompted by GCC 4.6.0 warnings.
9934
9935 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9936
5fbc2025
PE
9937 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9938 (x_clipboard_manager_save_all): Move extern decl to ...
9939 * xterm.h: ... here, so that it can be checked for consistency.
9940
1dd3c2d9
CY
99412011-05-29 Chong Yidong <cyd@stupidchicken.com>
9942
9943 * xselect.c (x_clipboard_manager_save_frame)
9944 (x_clipboard_manager_save_all): New functions.
9945 (Fx_clipboard_manager_save): Lisp function deleted.
9946
9947 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9948 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9949
9950 * xterm.h: Update prototype.
9951
5ba6571d
WX
99522011-05-28 William Xu <william.xwl@gmail.com>
9953
9954 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9955 exiting (Bug#8239).
9956
3eaff834
JM
99572011-05-28 Jim Meyering <meyering@redhat.com>
9958
e1900994 9959 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9960 * fns.c (to_uchar): Define.
9961 (crypto_hash_function): Use it to convert some newly-signed
9962 variables to unsigned, to avoid sign-extension bugs. For example,
9963 without this change, (md5 "truc") would evaluate to
9964 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9965 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9966 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9967
0f6990a7
PE
99682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9969
9970 Integer overflow fixes.
c8a9ca5a 9971
08686060
PE
9972 * dbusbind.c: Serial number integer overflow fixes.
9973 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9974 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9975 to hold a serial number that is too large for a fixnum.
9976 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9977 Check for serial numbers out of range. Decode any serial number
59568bf0 9978 that was so large that it became a float. (Bug#8722)
08686060 9979
2d1fc3c7
PE
9980 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9981 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9982 Use XFASTINT rather than XUINT when numbers are nonnegative.
9983 (xd_append_arg, Fdbus_method_return_internal):
9984 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9985 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9986 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9987 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9988 (Bug#8722)
2d1fc3c7 9989
c8a9ca5a
PE
9990 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9991
519e1d69
PE
9992 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9993
6df6ae42 9994 ccl: Add integer overflow checks.
30569699
PE
9995 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9996 (IN_INT_RANGE): New macros.
9997 (ccl_driver): Use them to check for integer overflow when
9998 decoding a CCL program. Many of the new checks are whether XINT (x)
9999 fits in int; it doesn't always, on 64-bit hosts. The new version
10000 doesn't catch all possible integer overflows, but it's an
847044ea 10001 improvement. (Bug#8719)
30569699 10002
c11285dc
PE
10003 * alloc.c (make_event_array): Use XINT, not XUINT.
10004 There's no need for unsigned here.
10005
fdccd48e
PE
10006 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10007 This follows up to the 2011-05-06 change that substituted uintptr_t
10008 for EMACS_INT. This case wasn't caught back then.
10009
37910ab2
PE
10010 Rework Fformat to avoid integer overflow issues.
10011 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10012 now (part of C89). Include <verify.h>.
10013 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10014 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10015 (Fformat): Avoid the prepass trying to compute sizes; it was only
10016 approximate and thus did not catch overflow reliably. Instead, walk
10017 through the format just once, formatting and computing sizes as we go,
10018 checking for integer overflow at every step, and allocating a larger
10019 buffer as needed. Keep track separately whether the format is
10020 multibyte. Keep only the most-recently calculated precision, rather
10021 than them all. Record whether each argument has been converted to
10022 string. Use EMACS_INT, not int, for byte and char and arg counts.
10023 Support field widths and precisions larger than INT_MAX. Avoid
10024 sprintf's undefined behavior with conversion specifications such as %#d
10025 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10026 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10027 formatting out-of-range floating point numbers with int
9173deec 10028 formats. (Bug#8668)
37910ab2 10029
2e6578fb
PE
10030 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10031
0ae6bdee
PE
10032 * data.c: Avoid integer truncation in expressions involving floats.
10033 * data.c: Include <intprops.h>.
10034 (arith_driver): When there's an integer overflow in an expression
10035 involving floating point, convert the integers to floating point
10036 so that the resulting value does not suffer from catastrophic
10037 integer truncation. For example, on a 64-bit host (* 4
10038 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10039 Do not rely on undefined behavior after integer overflow.
10040
de883a70
PE
10041 merge count_size_as_multibyte, parse_str_to_multibyte
10042 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10043 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10044 Check for integer overflow.
10045 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10046 since it's now a duplicate of the other. This is more of
10047 a character than a buffer op, so better that it's in character.c.
10048 * fns.c, print.c: Adjust to above changes.
10049
2ff916cb
PE
100502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10051
10052 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10053
f1b54466
PE
100542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10055
fb1ac845
PE
10056 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10057 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10058 (x_clipboard_manager_save): Now static.
10059 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10060
f1b54466
PE
10061 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10062 (crypto_hash_function): Now static.
10063 Fix pointer signedness problems. Avoid unnecessary initializations.
10064
a9f737ee
CY
100652011-05-27 Chong Yidong <cyd@stupidchicken.com>
10066
10067 * termhooks.h (Vselection_alist): Make it terminal-local.
10068
10069 * terminal.c (create_terminal): Initialize it.
10070
10071 * xselect.c: Support for clipboard managers.
10072 (Vselection_alist): Move to termhooks.h as terminal-local var.
10073 (LOCAL_SELECTION): New macro.
10074 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10075 (symbol_to_x_atom): Remove gratuitous arg.
10076 (x_handle_selection_request, lisp_data_to_selection_data)
10077 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10078 (x_own_selection, x_get_local_selection, x_convert_selection):
10079 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10080 (some_frame_on_display): Delete unused function.
10081 (Fx_own_selection_internal, Fx_get_selection_internal)
10082 (Fx_disown_selection_internal, Fx_selection_owner_p)
10083 (Fx_selection_exists_p): New optional frame arg.
10084 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10085 (x_handle_selection_clear): Don't treat other terminals with the
10086 same keyboard specially. Use the terminal-local Vselection_alist.
10087 (x_clear_frame_selections): Use Frun_hook_with_args.
10088
10089 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10090
10091 * xterm.h: Add support for those atoms.
10092
e067f0c1
CY
100932011-05-26 Chong Yidong <cyd@stupidchicken.com>
10094
10095 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10096 (converted_selections, conversion_fail_tag): New global variables.
10097 (x_selection_request_lisp_error): Free the above.
10098 (x_get_local_selection): Remove unnecessary code.
10099 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10100 of converted selections stored in converted_selections.
10101 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10102 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10103 (x_convert_selection): New function.
10104 (x_handle_selection_event): Simplify.
10105 (x_get_foreign_selection): Don't ignore incoming requests while
10106 waiting for an answer; this will fail when we implement
10107 SAVE_TARGETS, and seems unnecessary anyway.
10108 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10109 (Vx_sent_selection_functions): Doc fix.
10110
0f4aebc0
LL
101112011-05-26 Leo Liu <sdl.web@gmail.com>
10112
10113 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10114
e61124cd
YM
101152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10116
10117 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10118
10119 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10120 for fringe update if it has periodic bitmap.
ac389d0c 10121 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10122 and fringe_bitmap_periodic_p.
10123
10124 * fringe.c (get_fringe_bitmap_data): New function.
10125 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10126 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10127 row. Mark glyph row for fringe update if periodicity changed.
10128
10129 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10130 for fringe update unless it has periodic bitmap.
10131
f16d9837
KH
101322011-05-25 Kenichi Handa <handa@m17n.org>
10133
10134 * xdisp.c (get_next_display_element): Set correct it->face_id for
10135 a static composition.
10136
e1b90ef6
LL
101372011-05-24 Leo Liu <sdl.web@gmail.com>
10138
10139 * deps.mk (fns.o):
10140 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10141
10142 * fns.c (crypto_hash_function, Fsha1): New function.
10143 (Fmd5): Use crypto_hash_function.
10144 (syms_of_fns): Add Ssha1.
10145
7400048f
PE
101462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10147
10148 * gnutls.c: Remove unused macros.
10149 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10150 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10151 Remove macros that are defined and never used.
10152 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10153
abb71cf4
CY
101542011-05-22 Chong Yidong <cyd@stupidchicken.com>
10155
10156 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10157 (Fx_get_selection_internal): Minor cleanup.
10158 (Fx_own_selection_internal): Rename arguments for consistency with
10159 select.el.
10160
6307db39
PE
101612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10162
10163 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10164
f3d4e0a4
CY
101652011-05-22 Chong Yidong <cyd@stupidchicken.com>
10166
10167 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10168
4d8ade89
YM
101692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10170
10171 * dispnew.c (scrolling_window): Don't exclude the case that the
10172 last enabled row in the desired matrix touches the bottom boundary.
10173
32078c8d
GM
101742011-05-21 Glenn Morris <rgm@gnu.org>
10175
10176 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10177 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10178 and add some more files.
32078c8d 10179
7285dc67
EZ
101802011-05-20 Eli Zaretskii <eliz@gnu.org>
10181
10182 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10183 report_file_error introduced by the change from 2011-05-07.
10184
89d1bd22
PE
101852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10186
10187 * systime.h (Time): Define only if emacs is defined.
10188 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10189 where the include path doesn't have X11/X.h by default. See
10190 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10191
cd394be1 101922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10193
10194 * composite.c (find_automatic_composition): Fix previous change.
10195
b9704ad9
GM
101962011-05-20 Glenn Morris <rgm@gnu.org>
10197
10198 * lisp.mk: New file, split from Makefile.in.
10199 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10200 (shortlisp): Remove.
10201 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10202
4a720484
GM
102032011-05-19 Glenn Morris <rgm@gnu.org>
10204
10205 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10206 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10207 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10208 (lisp): Set the order to that of loadup.el.
10209 (shortlisp): Make it a copy of $lisp.
10210 (SOME_MACHINE_LISP): Remove.
10211 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10212 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10213
a28d4396
KH
102142011-05-18 Kenichi Handa <handa@m17n.org>
10215
10216 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10217 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10218 (find_automatic_composition): Mostly rewrite for efficiency.
10219
a2b1fa8e
JB
102202011-05-18 Juanma Barranquero <lekktu@gmail.com>
10221
10222 * makefile.w32-in: Update dependencies.
10223
8e1f5610
CS
102242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10225
10226 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10227 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10228
7025ee00 102292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10230
cdfa6eab
PE
10231 Fix some integer overflow issues, such as string length overflow.
10232
06d6db33
PE
10233 * insdel.c (count_size_as_multibyte): Check for string overflow.
10234
2b4560a8
PE
10235 * character.c (lisp_string_width): Check for string overflow.
10236 Use EMACS_INT, not int, for string indexes and lengths; in
10237 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10238 the resulting string length overflows an EMACS_INT; instead,
10239 report a string overflow if no precision given. When checking for
10240 precision exhaustion, use a check that cannot possibly have
10241 integer overflow. (Bug#8675)
10242 * character.h (lisp_string_width): Adjust to new signature.
10243
cb93f9be
PE
10244 * alloc.c (string_overflow): New function.
10245 (Fmake_string): Use it. This doesn't change behavior, but saves
10246 a few bytes and will simplify future changes.
10247 * character.c (string_escape_byte8): Likewise.
10248 * lisp.h (string_overflow): New decl.
10249
1a1f3366
PE
10250 Fixups, following up to the user-interface timestamp change.
10251 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10252 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10253 * msdos.c (mouse_get_pos): Likewise.
10254 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10255 * w32gui.h (Time): Define by including "systime.h" rather than by
10256 declaring it ourselves. (Bug#8664)
10257
d4e3e4d3
PE
10258 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10259 * image.c (clear_image_cache): Likewise.
10260
f6a24d19
PE
10261 * term.c (term_mouse_position): Don't assume time_t wraparound.
10262
08dc5ae6
PE
10263 Be more systematic about user-interface timestamps.
10264 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10265 and sometimes 'EMACS_UINT', to represent these timestamps.
10266 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10267 This makes the code easier to follow, and makes it easier to catch
10268 integer overflow bugs such as Bug#8664.
10269 * frame.c (Fmouse_position, Fmouse_pixel_position):
10270 Use Time, not unsigned long, for user-interface timestamps.
10271 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10272 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10273 * keyboard.h (last_event_timestamp): Likewise.
10274 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10275 * menu.h (xmenu_show): Likewise.
10276 * term.c (term_mouse_position): Likewise.
10277 * termhooks.h (struct input_event.timestamp): Likewise.
10278 (struct terminal.mouse_position_hook): Likewise.
10279 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10280 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10281 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10282 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10283 what it was before.
10284 * menu.h, termhooks.h: Include "systime.h", for Time.
10285
8e55734a
PE
10286 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10287 Don't assume that the difference between two unsigned long values
10288 can fit into an integer. At this point, we know button_down_time
10289 <= event->timestamp, so the difference must be nonnegative, so
10290 there's no need to cast the result if double-click-time is
10291 nonnegative, as it should be; check that it's nonnegative, just in
10292 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10293 apart (about 25 days). (Bug#8664)
8e55734a 10294
841f1b75 10295 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10296 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10297
3e26f69c
PE
10298 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10299 that always fit in int. Use a sentinel instead of a counter, to
10300 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10301 * frame.h (struct frame): Use int for menu_bar_items_used
10302 instead of EMACS_INT, since it always fits in int.
3e26f69c 10303
5cc152c0
PE
10304 * menu.c (grow_menu_items): Check for int overflow.
10305
d89eb65e
PE
10306 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10307
5235bd3e
PE
10308 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10309 Before, the code was not consistent. These values cannot exceed
10310 2**31 - 1 so there's no need to make them unsigned.
10311 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10312 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10313 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10314 as modifiers.
10315 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10316
bc827e23
PE
10317 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10318 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10319 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10320 presumably because the widths might not match.
10321
78eb494e
PE
10322 * window.c (size_window): Avoid needless test at loop start.
10323
04f2d78b
CB
103242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10325
10326 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10327
d2fc7e3d 103282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10329
10330 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10331
d2fc7e3d 103322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10333
10334 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10335 `width' to `bar_area_x' and `bar_area_width', respectively.
10336 (x_scroll_run): Take account of fringe background extension.
10337
04f2d78b
CB
10338 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10339 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10340 `bar_area_width', respectively.
10341 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10342 background extension.
10343
79b70037
GM
103442011-05-10 Jim Meyering <meyering@redhat.com>
10345
10346 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10347
2f142cc5
JB
103482011-05-10 Juanma Barranquero <lekktu@gmail.com>
10349
10350 * image.c (Finit_image_library): Return t for built-in image types,
10351 like pbm and xbm. (Bug#8640)
10352
57679c86
AS
103532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10354
10355 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10356
888c9e86
EZ
103572011-05-07 Eli Zaretskii <eliz@gnu.org>
10358
b0512a1d
EZ
10359 * w32console.c (Fset_screen_color): Doc fix.
10360 (Fget_screen_color): New function.
10361 (syms_of_ntterm): Defsubr it.
10362
7285dc67
EZ
10363 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10364 unlink the temporary file if Fcall_process didn't create it in the
10365 first place.
10366 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10367 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10368 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10369 cue to call_process_cleanup not to close that handle.
10370
4d3fcc8e
BK
103712011-05-07 Ben Key <bkey76@gmail.com>
10372
10373 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10374 one of two shell specific rules, either bootstrap-temacs-CMD or
10375 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10376 to the previous implementation of the bootstrap-temacs rule.
10377 The bootstrap-temacs-CMD rule is similar to the previous
10378 implementation of the bootstrap-temacs rule except that it
10379 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10380 variable.
10381
10382 These changes, along with some changes to nt/configure.bat,
10383 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10384 earlier fix to add support for --cflags and --ldflags options
10385 that include quotes so that it works whether make uses cmd or
10386 sh as the shell.
10387
b4289b64
MA
103882011-05-06 Michael Albinus <michael.albinus@gmx.de>
10389
10390 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10391 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10392 is a constant.
10393 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10394 a string. Handle both cases.
10395 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10396 (Fdbus_register_method): Use Qinvalid_function.
10397
af4c0e28
JB
103982011-05-06 Juanma Barranquero <lekktu@gmail.com>
10399
10400 * makefile.w32-in: Update dependencies.
10401 (LISP_H): Add inttypes.h and stdin.h.
10402 (PROCESS_H): Add unistd.h.
10403
c51453d9
EZ
104042011-05-06 Eli Zaretskii <eliz@gnu.org>
10405
10406 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10407 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10408
8ff0ac3c 104092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10410
4c4b566b
PE
10411 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10412
aab2b9b5
PE
10413 * term.c (vfatal): Remove stray call to va_end.
10414 It's not needed and the C Standard doesn't allow it here anyway.
10415
c378da0b
PE
10416 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10417 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10418
288b08c7
PE
10419 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10420 bytes.
10421
e3601888
PE
10422 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10423
db6c0e74
PE
10424 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10425
dd5963ea
PE
10426 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10427
88c9450f
PE
10428 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10429
2f9442b8
PE
10430 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10431
c032b5f8
PE
10432 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10433 * charset.c (Fdefine_charset_internal): Don't initialize
10434 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10435 32-bit int (Bug#8600).
a108c10b
PE
10436
10437 * lread.c (read_integer): Be more consistent with string-to-number.
10438 Use string_to_number to do the actual conversion; this avoids
10439 rounding errors and fixes some other screwups. Without this fix,
10440 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10441 (digit_to_number): Move earlier, for benefit of read_integer.
10442 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10443 not a digit in any supported base. (Bug#8602)
a108c10b 10444
ad5f9eea
PE
10445 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10446
aec1708a
PE
10447 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10448 to match comment at start of function. This also removes a
10449 GCC warning about overflow in a 32+64-bit port.
10450
47be4ab5
PE
10451 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10452
371cac43
PE
10453 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10454 Reported by Stefan Monnier in
10455 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10456 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10457 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10458
d01a7826
PE
10459 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10460 (EMACS_UINTPTR): Likewise, with uintptr_t.
10461
7fd47d5c
PE
10462 * lisp.h: Prefer 64-bit EMACS_INT if available.
10463 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10464 on 32-bit hosts that have 64-bit int, so that they can access
10465 large files.
122b0c86
PE
10466 However, temporarily disable this change unless the temporary
10467 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10468
8727937b
PE
10469 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10470
8ac068ac
PE
10471 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10472 This removes an assumption that EMACS_INT and long are the same
10473 width as pointers. The assumption is true for Emacs porting targets
10474 now, but we want to make other targets possible.
10475 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10476 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10477 In the rest of the code, change types of integers that hold casted
10478 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10479 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10480 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10481 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10482 No need to cast type when ORing.
10483 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10484 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10485 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10486 assume EMACS_INT is the same width as char *.
10487 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10488 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10489 Remove no-longer-needed casts.
10490 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10491 (xg_tool_bar_help_callback, xg_make_tool_item):
10492 Use EMACS_INTPTR to hold an integer
10493 that will be cast to void *; this can avoid a GCC warning
10494 if EMACS_INT is not the same width as void *.
10495 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10496 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10497 (current_message_1, set_message_1):
10498 Use a local to convert to proper width without a cast.
10499 * xmenu.c (dialog_selection_callback): Likewise.
10500
ede49d71
PE
10501 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10502 Also, don't assume VALBITS / RAND_BITS is less than 5,
10503 and don't rely on undefined behavior when shifting a 1 left into
10504 the sign bit.
10505 * lisp.h (get_random): Change signature to match.
10506
2f30ecd0
PE
10507 * lread.c (hash_string): Use size_t, not int, for hash computation.
10508 Normally we prefer signed values; but hashing is special, because
10509 it's better to use unsigned division on hash table sizes so that
10510 the remainder is nonnegative. Also, size_t is the natural width
10511 for hashing into memory. The previous code used 'int', which doesn't
10512 retain enough info to hash well into very large tables.
10513 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10514
2a866e7b
PE
10515 * dbusbind.c: Don't possibly lose pointer info when converting.
10516 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10517 Use XPNTR rather than XHASH, so that the high-order bits of
10518 the pointer aren't lost when converting through void *.
10519
51639eac
PE
10520 * eval.c (Fautoload): Don't double-shift a pointer.
10521
92394119
PE
10522 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10523
dbdb9a7c
JB
105242011-05-06 Juanma Barranquero <lekktu@gmail.com>
10525
10526 * gnutls.c (DEF_GNUTLS_FN):
10527 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10528
db7a0b4f
AS
105292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10530
10531 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10532 marker. (Bug#8610)
10533
cd394be1 105342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10535
10536 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10537 New version that can reserve upto 2GB of heap space.
10538
f7ff1b0f 105392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10540
10541 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10542
639c109b
TZ
105432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10544
10545 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10546 `gnutls_certificate_set_x509_key_file'.
10547
d2127135
JB
105482011-05-05 Juanma Barranquero <lekktu@gmail.com>
10549
10550 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10551 Update dependencies.
10552
e968f4f3
JB
105532011-05-04 Juanma Barranquero <lekktu@gmail.com>
10554
10555 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10556 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10557 Remove unused parameter `fildes'.
10558 * process.c (read_process_output, send_process): Don't pass it.
10559
84d358f0
JB
105602011-05-04 Juanma Barranquero <lekktu@gmail.com>
10561
10562 Fix previous change: the library cache is defined in w32.c.
10563 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10564 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10565
0898ca10
JB
105662011-05-04 Juanma Barranquero <lekktu@gmail.com>
10567
10568 Implement dynamic loading of GnuTLS on Windows.
10569
10570 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10571 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10572 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10573 Declare.
10574
10575 * gnutls.c (Qgnutls_dll): Define.
10576 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10577 (gnutls_*): Declare function pointers.
10578 (init_gnutls_functions): New function to initialize function pointers.
10579 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10580 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10581 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10582 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10583 (emacs_gnutls_write, emacs_gnutls_read)
10584 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10585 (Fgnutls_available_p): New function.
10586 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10587 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10588 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10589
10590 * image.c: Include w32.h.
10591 (Vimage_type_cache): Delete.
10592 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10593 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10594 (w32_delayed_load): Move to w32.c.
10595
10596 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10597
10598 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10599 (w32_delayed_load): Move from image.c. When loading a library, record
10600 its filename in the :loaded-from property of the library id.
10601 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10602 Initialize and staticpro them.
10603 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10604
10605 * process.c: Include lisp.h before w32.h, not after.
10606 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10607 instead of gnutls_record_check_pending.
10608
10609 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10610
ff4de4aa
TZ
106112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10612
10613 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10614 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10615 as passed in.
10616
abe95abb
JD
106172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10618
10619 * xterm.c (x_set_frame_alpha): Do not set property on anything
10620 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10621
e16e55d4
JB
106222011-05-02 Juanma Barranquero <lekktu@gmail.com>
10623
10624 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10625
bafcf6a5
JB
106262011-05-02 Juanma Barranquero <lekktu@gmail.com>
10627
10628 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10629 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10630 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10631 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10632 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10633 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10634 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10635 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10636 (Qgnutls_bootprop_callbacks_verify): Make static.
10637
e7a6747f
AS
106382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10639
19ed11ba
AS
10640 * callproc.c: Indentation fixup.
10641
e7a6747f 10642 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10643 (wait_for_termination, interruptible_wait_for_termination):
10644 Move after wait_for_termination_1.
e7a6747f 10645
1ef14cb4
LMI
106462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10647
10648 * sysdep.c (interruptible_wait_for_termination): New function
10649 which is like wait_for_termination, but allows keyboard
10650 interruptions.
10651
10652 * callproc.c (Fcall_process): Add (:file "file") as an option for
10653 the STDOUT buffer.
10654 (Fcall_process_region): Ditto.
10655
330d880c
EZ
106562011-04-30 Eli Zaretskii <eliz@gnu.org>
10657
8db90b73
EZ
10658 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10659 rather than `XVECTOR (FOO)->size'.
10660
330d880c
EZ
10661 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10662 inttypes.h, as a gnulib replacement is used if it not available in
10663 system headers.
10664
15cbd324
EZ
106652011-04-21 Eli Zaretskii <eliz@gnu.org>
10666
10667 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10668 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10669 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10670
10671 * coding.c (coding_alloc_by_realloc): Error out if destination
10672 will grow beyond MOST_POSITIVE_FIXNUM.
10673 (decode_coding_emacs_mule): Abort if there isn't enough place in
10674 charbuf for the composition carryover bytes. Reserve an extra
10675 space for up to 2 characters produced in a loop.
10676 (decode_coding_iso_2022): Abort if there isn't enough place in
10677 charbuf for the composition carryover bytes.
10678
106792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10680
ae940cca
EZ
10681 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10682 aborting when %lld or %lll format is passed.
10683 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10684 %llo or %llx format is passed. (Bug#8545)
10685
03ab8921
EZ
10686 * window.c (window_scroll_line_based): Use a marker instead of
10687 simple variables to record original value of point. (Bug#7952)
10688
afda1437
EZ
10689 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10690 produced by %s or %c overflows available buffer space. (Bug#8545)
10691
f76dee0c
PE
106922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10693
10694 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10695 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10696
fdc5744d
JB
106972011-04-28 Juanma Barranquero <lekktu@gmail.com>
10698
10699 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10700
638f053a
JB
107012011-04-28 Juanma Barranquero <lekktu@gmail.com>
10702
10703 * keyboard.c (Qdelayed_warnings_hook): Define.
10704 (command_loop_1): Run `delayed-warnings-hook'
10705 if Vdelayed_warnings_list is non-nil.
10706 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10707 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10708
d178f871
EZ
107092011-04-28 Eli Zaretskii <eliz@gnu.org>
10710
10711 * doprnt.c (doprnt): Don't return value smaller than the buffer
10712 size if the message was truncated. (Bug#8545).
10713
b124fd93
JB
107142011-04-28 Juanma Barranquero <lekktu@gmail.com>
10715
10716 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10717 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10718
e810457d
PE
107192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10720
10721 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10722
ea51cceb
JB
107232011-04-27 Juanma Barranquero <lekktu@gmail.com>
10724
10725 * makefile.w32-in: Update dependencies.
10726
94dcfacf
EZ
107272011-04-27 Eli Zaretskii <eliz@gnu.org>
10728
10729 Improve `doprnt' and its usage. (Bug#8545)
10730 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10731 `format_end'. Remove support for %l as a conversion specifier.
10732 Don't use xrealloc. Improve diagnostics when the %l size modifier
10733 is used. Update the commentary.
10734
10735 * eval.c (verror): Simplify calculation of size_t.
10736
10737 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10738 messages.
10739
f61f41d7
PE
107402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10741
10742 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10743 change.
10744
96fb4434
PE
107452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10746
10747 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10748 This makes this file independent of the recent pseudovector change.
10749
671875da 107502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10751
69e9b5a3
PE
10752 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10753
b5f869a7 10754 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10755 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10756 Remove unused local.
c8926152 10757 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10758
841a1577 10759 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10760 GCC 4.6.0 optimizes based on type-based alias analysis.
10761 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10762 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10763 != &v->size, and therefore "v->size = 1; b->size = 2; return
10764 v->size;" must therefore return 1. This assumption is incorrect
10765 for Emacs, since it type-puns struct Lisp_Vector * with many other
10766 types. To fix this problem, this patch adds a new type struct
f904488f 10767 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10768 and pseudovectors, and helps optimizing compilers not get fooled
10769 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10770 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10771 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10772 the size member.
eab3844f
PE
10773 (XSETPVECTYPE): Rewrite in terms of new macro.
10774 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10775 This is a bit clearer, and further avoids the possibility of
10776 undesirable aliasing.
10777 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10778 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10779 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10780 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10781 (ASIZE): Now uses header.size rather than size.
10782 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10783 to avoid the hassle of writing XVECTOR (foo)->header.size.
10784 (struct vectorlike_header): New type.
eab3844f
PE
10785 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10786 object, to help avoid aliasing.
10787 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10788 (SUBRP): Likewise, since Lisp_Subr is a special case.
10789 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10790 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10791 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10792 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10793 changed to be "header.size" and "header.next".
10794 * buffer.h (struct buffer): Likewise.
10795 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10796 * frame.h (struct frame): Likewise.
10797 * process.h (struct Lisp_Process): Likewise.
10798 * termhooks.h (struct terminal): Likewise.
10799 * window.c (struct save_window_data, struct saved_window): Likewise.
10800 * window.h (struct window): Likewise.
10801 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10802 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10803 * buffer.c (init_buffer_once): Likewise.
10804 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10805 special case.
10806 * process.c (Fformat_network_address): Use local var for size,
10807 for brevity.
10808
0df1eac5
PE
10809 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10810
847ab9d1 10811 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10812 * data.c (atof): Remove decl; no longer used or needed.
10813 (digit_to_number): Move to lread.c.
10814 (Fstring_to_number): Use new string_to_number function, to be
10815 consistent with how the Lisp reader treats infinities and NaNs.
10816 Do not assume that floating-point numbers represent EMACS_INT
10817 without losing information; this is not true on most 64-bit hosts.
10818 Avoid double-rounding errors, by insisting on integers when
10819 parsing non-base-10 numbers, as the documentation specifies.
10820 * lisp.h (string_to_number): New decl, replacing ...
10821 (isfloat_string): Remove.
bc0a5c13 10822 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10823 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10824 appears to have been a coding error. Similarly, do not accept
10825 strings like +-1e0 as floating point numbers. Do not report
10826 overflow for integer overflows unless the base is not 10 which
10827 means we have no simple and reliable way to continue.
10828 Break out the floating-point parsing into a new
10829 function string_to_number, so that Fstring_to_number parses
10830 floating point numbers consistently with the Lisp reader.
04f2d78b 10831 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10832 (E_CHAR, EXP_INT): Remove, replacing with ...
10833 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10834 (string_to_number): New function, replacing isfloat_string.
10835 This function checks for valid syntax and produces the resulting
10836 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10837 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10838 so that overflow for non-base-10 numbers is reported only when
10839 there's no portable and simple way to convert to floating point.
452f4150 10840
67769ffc
PE
10841 * textprop.c (set_text_properties_1): Rewrite for clarity,
10842 and to avoid GCC warning about integer overflow.
10843
c20db43f
PE
10844 * intervals.h (struct interval): Use EMACS_INT for members
10845 where EMACS_UINT might cause problems. See
10846 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10847 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10848 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10849 All uses changed.
37aa2f85
PE
10850 (offset_intervals): Tell GCC not to worry about length overflow
10851 when negating a negative length.
c20db43f 10852
2538aa2f
PE
10853 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10854 (overrun_check_free): Likewise.
10855
f2d3008d
PE
10856 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10857 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10858 word size.
10859
ec8df744
PE
10860 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10861 (gnutls_make_error): Rename local to avoid shadowing.
10862 (gnutls_emacs_global_deinit): ifdef out; not used.
10863 (Fgnutls_boot): Use const for pointer to readonly storage.
10864 Comment out unused local. Fix pointer signedness problems.
10865
640ee02d
PE
10866 * lread.c (openp): Don't stuff size_t into an 'int'.
10867 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10868 about possible signed overflow.
10869
6048fb2a
PE
10870 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10871 (GDK_KEY_g): Don't define if already defined.
10872 (xg_prepare_tooltip): Avoid pointer signedness problem.
10873 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10874
fa3c87e1
PE
10875 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10876 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10877
2172544b
PE
10878 * xfns.c (Fx_window_property): Simplify a bit,
10879 to make a bit faster and to avoid GCC 4.6.0 warning.
10880 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10881
9b821a21
PE
10882 * fns.c (internal_equal): Don't assume size_t fits in int.
10883
3c616cfa
PE
10884 * alloc.c (compact_small_strings): Tighten assertion a little.
10885
c2982e87
PE
10886 Replace pEd with more-general pI, and fix some printf arg casts.
10887 * lisp.h (pI): New macro, generalizing old pEd macro to other
10888 conversion specifiers. For example, use "...%"pI"d..." rather
10889 than "...%"pEd"...".
10890 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10891 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10892 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10893 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10894 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10895 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10896 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10897 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10898 64-bit hosts.
10899 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10900 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10901 * print.c (safe_debug_print, print_object): Likewise.
10902 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10903 to int.
6f04d126
PE
10904 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10905 avoiding the 0 flag, which is not portable.
c2982e87
PE
10906 * process.c (Fmake_network_process): Use pI to avoid cast.
10907 * region-cache.c (pp_cache): Likewise.
10908 * xdisp.c (decode_mode_spec): Likewise.
10909 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10910 behavior on 64-bit hosts with printf arg.
6f04d126 10911 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10912 (x_stop_queuing_selection_requests): Likewise.
10913 (x_get_window_property): Don't truncate byte count to an 'int'
10914 when tracing.
0b432f21 10915
5e073ec7
PE
10916 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10917 here, since it parses constructs like leading '-' and spaces,
10918 which are not wanted; and it overflows with large numbers.
10919 Instead, simply match F[0-9]+, which is what is wanted anyway.
10920
36372bf9
PE
10921 * alloc.c: Remove unportable assumptions about struct layout.
10922 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10923 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10924 (allocate_vectorlike, make_pure_vector): Use the new macros,
10925 plus offsetof, to remove unportable assumptions about struct layout.
10926 These assumptions hold on all porting targets that I know of, but
10927 they are not guaranteed, they're easy to remove, and removing them
10928 makes further changes easier.
10929
0b432f21
PE
10930 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10931 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10932 (string_overrun_cookie): Now const. Use initializers that
10933 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10934 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10935 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10936 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10937 multiple of sizeof (EMACS_INT); it need not be, if
10938 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10939 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10940
895009e1
JB
109412011-04-26 Juanma Barranquero <lekktu@gmail.com>
10942
10943 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10944
6a7a1b0b
TZ
109452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10946
10947 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10948 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10949 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10950
841a1577 109512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10952
10953 * lisp.h (Qdebug): List symbol.
895009e1 10954 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10955 * keyboard.c (debug-on-event): New variable.
10956 (handle_user_signal): Break into debugger when debug-on-event
10957 matches the current signal symbol.
10958
f2d3ba6f
DN
109592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10960
10961 * alloc.c (check_sblock, check_string_bytes)
10962 (check_string_free_list): Convert to standard C.
10963
42ce4c63
TZ
109642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10965
10966 * w32.c (emacs_gnutls_push): Fix typo.
10967
825cd63c
EZ
109682011-04-25 Eli Zaretskii <eliz@gnu.org>
10969
fb11d64d
EZ
10970 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10971 "cast to pointer from integer of different size".
10972
825cd63c
EZ
10973 Improve doprnt and its use in verror. (Bug#8545)
10974 * doprnt.c (doprnt): Document the set of format control sequences
10975 supported by the function. Use SAFE_ALLOCA instead of always
10976 using `alloca'.
10977
10978 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10979 is one byte too soon. Don't use xrealloc; instead xfree and
10980 xmalloc anew.
10981
e061a11b
TZ
109822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10983
10984 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10985 callbacks stage.
10986
10987 * gnutls.c: Renamed global_initialized to
10988 gnutls_global_initialized. Added internals for the
10989 :verify-hostname-error, :verify-error, and :verify-flags
10990 parameters of `gnutls-boot' and documented those parameters in the
10991 docstring. Start callback support.
9173deec
JB
10992 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10993 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10994 on error. Return error code.
e061a11b
TZ
10995 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10996 (emacs_gnutls_read): Likewise.
10997 (Fgnutls_boot): Return handshake error code.
10998 (emacs_gnutls_handle_error): New function.
10999 (wsaerror_to_errno): Likewise.
11000
11001 * w32.h (emacs_gnutls_pull): Add prototype.
11002 (emacs_gnutls_push): Likewise.
11003
11004 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11005 (emacs_gnutls_push): Likewise.
11006
110072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11008
11009 * process.c (wait_reading_process_output): Check if GnuTLS
11010 buffered some data internally if no FDs are set for TLS
11011 connections.
11012
11013 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11014 (LIBS): Link to USER_LIBS.
11015 ($(BLD)/gnutls.$(0)): New target.
11016
fa6996bc
EZ
110172011-04-24 Eli Zaretskii <eliz@gnu.org>
11018
eb35682e
EZ
11019 * xdisp.c (handle_single_display_spec): Rename the
11020 display_replaced_before_p argument into display_replaced_p, to
11021 make it consistent with the commentary. Fix typos in the
11022 commentary.
11023
e2ad650c
EZ
11024 * textprop.c (syms_of_textprop): Remove dead code.
11025 (copy_text_properties): Delete obsolete commentary about an
11026 interface that was deleted long ago. Fix typos in the description
11027 of arguments.
11028
1b2de274
EZ
11029 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11030 to changes in oldXMenu/XMenu.h from 2011-04-16.
11031 <menu_help_message, prev_menu_help_message>: Constify.
11032 (IT_menu_make_room): menu->help_text is now `const char **';
11033 adjust.
11034
11035 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11036 to changes in oldXMenu/XMenu.h from 2011-04-16.
11037 (struct XMenu): Declare `help_text' `const char **'.
11038
11039 * xfaces.c <Qunspecified>: Make extern again.
11040
11041 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11042 required by POSIX.
1b2de274 11043
762b15be
EZ
11044 * doc.c (get_doc_string): Improve the format passed to `error'.
11045
11046 * doprnt.c (doprnt): Improve commentary.
11047
11048 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11049
11050 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11051 them with etags.
11052
f1052e5d
EZ
11053 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11054 changes in globals.h immediately force recompilation.
762b15be
EZ
11055 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11056 $(CURDIR)/s/ms-w32.h.
11057 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11058
fa6996bc
EZ
11059 * character.c (Fchar_direction): Function deleted.
11060 (syms_of_character): Don't defsubr it.
11061 <char-direction-table>: Deleted.
11062
e6c3da20
EZ
110632011-04-23 Eli Zaretskii <eliz@gnu.org>
11064
11065 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11066 * doprnt.c: Include limits.h.
11067 (SIZE_MAX): New macro.
04f2d78b
CB
11068 (doprnt): Return a size_t value. 2nd arg is now size_t.
11069 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11070 Improve overflow protection. Support `l' modifier for integer
11071 conversions. Support %l conversion. Don't assume an EMACS_INT
11072 argument for integer conversions and for %c.
11073
11074 * lisp.h (doprnt): Restore prototype.
11075
11076 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11077 $(SRC)/character.h.
11078
11079 * Makefile.in (base_obj): Add back doprnt.o.
11080
11081 * deps.mk (doprnt.o): Add back prerequisites.
11082 (callint.o): Depend on character.h.
11083
11084 * eval.c (internal_lisp_condition_case): Include the handler
11085 representation in the error message.
11086 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11087 when breaking from the loop.
11088
11089 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11090
11091 * callint.c (Fcall_interactively): When displaying error message
11092 about invalid control letter, pass the character's codepoint, not
11093 a pointer to its multibyte form. Improve display of the character
11094 in octal and display also its hex code.
11095
11096 * character.c (char_string): Use %x to display the (unsigned)
11097 codepoint of an invalid character, to avoid displaying a bogus
11098 negative value.
11099
11100 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11101 `error', not SYMBOL_NAME itself.
11102
11103 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11104 character arguments to `error'.
11105
11106 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11107 to `error' in error message about FINAL_CHAR argument. Make sure
11108 FINAL_CHAR is a character, and use %c when it is passed as
11109 argument to `error'.
11110
4ffd0d6b 111112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11112
11113 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11114
11115 * w32.c: Include <time.h>.
11116 (sys_localtime): New function.
11117
4ffd0d6b 111182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11119
11120 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11121
4ffd0d6b 11122 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11123
4ffd0d6b 111242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11125
4ffd0d6b
GM
11126 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11127 zombies (Bug#8467).
aac0c6e3 11128
04c56954
EZ
111292011-04-19 Eli Zaretskii <eliz@gnu.org>
11130
11131 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11132 gl_state.e_property when gl_state.object is Qt.
11133
11134 * insdel.c (make_gap_larger): Remove limitation of buffer size
11135 to <= INT_MAX.
11136
16a43933
CY
111372011-04-18 Chong Yidong <cyd@stupidchicken.com>
11138
11139 * xdisp.c (lookup_glyphless_char_display)
11140 (produce_glyphless_glyph): Handle cons cell entry in
11141 glyphless-char-display.
11142 (Vglyphless_char_display): Document it.
11143
11144 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11145 glyphless-char-display.
11146
4581706e
CY
111472011-04-17 Chong Yidong <cyd@stupidchicken.com>
11148
11149 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11150
11151 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11152
11153 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11154 definition for no-X builds.
11155
4887c6e2 111562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11157
fd35b6f9
PE
11158 Static checks with GCC 4.6.0 and non-default toolkits.
11159
5c1ccb01
PE
11160 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11161
006c5daa
PE
11162 * process.c (keyboard_bit_set): Define only if SIGIO.
11163 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11164 (send_process): Repair possible setjmp clobbering.
11165
efc736d3
PE
11166 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11167
4e2fe2e6
PE
11168 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11169
f97334a2
PE
11170 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11171
4e75f29d
PE
11172 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11173 Define only if needed.
11174
90efadd1
PE
11175 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11176 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11177 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11178
3c647824
PE
11179 * dispextern.h (struct redisplay_interface): Rename param
11180 to avoid shadowing.
e264f262 11181 * termhooks.h (struct terminal): Likewise.
761383f4 11182 * xterm.c (xembed_send_message): Likewise.
3c647824 11183
b58c5c4a
PE
11184 * insdel.c (make_gap_smaller): Define only if
11185 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11186
cad59032
PE
11187 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11188 it.
11189
c339dc2e
PE
11190 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11191 so that we aren't warned about unused symbols.
11192
91a3e27b
PE
11193 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11194
399c71d3 11195 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11196
8ffc96f5
PE
11197 * xfns.c (x_real_positions): Mark locals as initialized.
11198
eef9bc79
PE
11199 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11200
098db9dd
PE
11201 * xterm.c: Fix problems found by static analysis with other toolkits.
11202 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11203 (x_dispatch_event): Declare static if USE_GTK, and
11204 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11205 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11206 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11207 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11208 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11209
eb18f6cc
PE
11210 * xmenu.c (menu_help_callback): Pointer type fixes.
11211 Use const pointers when pointing at readonly data. Avoid pointer
11212 signedness clashes.
11213 (FALSE): Remove unused macro.
11214 (update_frame_menubar): Remove unused decl.
11215
1fe72bf8
PE
11216 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11217
60d9e1db
PE
11218 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11219 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11220 (single_menu_item): Rename local to avoid shadowing.
11221
39261c26
PE
11222 * keyboard.c (make_lispy_event): Remove unused local var.
11223
018c5e19
PE
11224 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11225 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11226
63d2b86e
PE
11227 * bitmaps: Change bitmaps from unsigned char back to the X11
11228 compatible char. Avoid the old compiler warnings about
11229 out-of-range initializers by using, for example, '\xab' rather
11230 than 0xab.
11231
aefd87e1
PE
11232 * xgselect.c (xgselect_initialize): Check vs interface
11233 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11234
bf501fb9
PE
11235 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11236
e9829fdf
PE
11237 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11238 to read-only memory.
11239
1086c095
PE
11240 * fns.c (vector): Remove; this old hack is no longer needed.
11241
2baccd04 11242 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11243 Remove unused var.
dde42981 11244 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11245
72391843 11246 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11247
436c16df 11248 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11249 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11250 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11251
92bb796d 11252 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11253 (x_term_init): Remove local to avoid shadowing.
92bb796d 11254
764430a3 11255 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11256
11257 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11258 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11259
d1dfb56c
EZ
112602011-04-16 Eli Zaretskii <eliz@gnu.org>
11261
c4354cb4
EZ
11262 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11263
d1dfb56c
EZ
11264 Fix regex.c, syntax.c and friends for buffers > 2GB.
11265 * syntax.h (struct gl_state_s): Declare character position members
11266 EMACS_INT.
11267
11268 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11269
04f2d78b
CB
11270 * textprop.c (verify_interval_modification, interval_of):
11271 Declare arguments EMACS_INT.
d1dfb56c
EZ
11272
11273 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11274 EMACS_INT.
11275
11276 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11277
11278 * indent.c (Fvertical_motion): Local variable it_start is now
11279 EMACS_INT.
11280
11281 * regex.c (re_match, re_match_2, re_match_2_internal)
11282 (bcmp_translate, regcomp, regexec, print_double_string)
11283 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11284 (re_compile_pattern, re_exec): Declare arguments and local
11285 variables `size_t' and `ssize_t' and return values `regoff_t', as
11286 appropriate.
11287 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11288 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11289 <compile_stack_type>: `size' and `avail' are now `size_t'.
11290
11291 * regex.h <regoff_t>: Use ssize_t, not int.
11292 (re_search, re_search_2, re_match, re_match_2): Arguments that
11293 specify buffer/string position and length are now ssize_t and
11294 size_t. Return type is regoff_t.
11295
613052cd
BK
112962011-04-16 Ben Key <bkey76@gmail.com>
11297
11298 * nsfont.m: Fixed bugs in ns_get_family and
11299 ns_descriptor_to_entity that were caused by using free to
11300 deallocate memory blocks that were allocated by xmalloc (via
11301 xstrdup). This caused Emacs to crash when compiled with
11302 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11303 --enable-checking=xmallocoverrun). xfree is now used to
11304 deallocate these memory blocks.
11305
4170f62f 113062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11307
71b41406
PE
11308 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11309
9587a89d
PE
11310 emacs_write: Accept and return EMACS_INT for sizes.
11311 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11312 et seq.
11313 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11314 Accept and return EMACS_INT.
11315 (emacs_gnutls_write): Return the number of bytes written on
11316 partial writes.
11317 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11318 (emacs_read, emacs_write): Remove check for negative size, as the
11319 Emacs source code has been audited now.
9587a89d
PE
11320 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11321 (emacs_read, emacs_write): Use it.
273a5f82
PE
11322 * process.c (send_process): Adjust to the new signatures of
11323 emacs_write and emacs_gnutls_write. Do not attempt to store
11324 a byte offset into an 'int'; it might overflow.
9587a89d 11325 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11326
3e047f51
PE
11327 * sound.c: Don't assume sizes fit in 'int'.
11328 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11329 Return EMACS_INT, not int.
3e047f51 11330 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11331 Accept EMACS_INT, not int.
11332 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11333 record read return values.
11334
cc39a9db
BK
113352011-04-15 Ben Key <bkey76@gmail.com>
11336
c9d0ec6d
JB
11337 * keyboard.c (Qundefined): Don't declare static since it is used
11338 in nsfns.m.
11339 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11340 static since they are used in nsfont.m.
cc39a9db 11341
6c60eb9f
SM
113422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11343
11344 * process.c (Qprocessp): Don't declare static.
11345 * lisp.h (Qprocessp): Declare again.
11346
7990b61a
JB
113472011-04-15 Juanma Barranquero <lekktu@gmail.com>
11348
11349 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11350
5d4cb038
PE
113512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11352
8bd7b830 11353 Improve C-level modularity by making more things 'static'.
cd64ea1d 11354
e3b27b31
PE
11355 Don't publish debugger-only interfaces to other modules.
11356 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11357 (verify_bytepos, count_markers): Move decls to the only modules
11358 that need them.
11359 * region-cache.h (pp_cache): Likewise.
11360 * window.h (check_all_windows): Likewise.
11361 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11362
5d4cb038
PE
11363 * sysdep.c (croak): Now static, if
11364 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11365 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11366
11367 * alloc.c (refill_memory_reserve): Now static if
11368 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11369 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11370
e87b6180
PE
11371 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11372 Define only if USE_LUCID.
11373
ac64929e
PE
11374 * xrdb.c (x_customization_string, x_rm_string): Now static.
11375
6f37259d
PE
11376 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11377 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11378
1683e3ab
PE
11379 * xdisp.c (draw_row_with_mouse_face): Now static.
11380 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11381
de9c2632
PE
11382 * window.h (check_all_windows): Mark externally visible.
11383
2b96acb7
PE
11384 * window.c (window_deletion_count): Now static.
11385
11386 * undo.c: Make symbols static if they're not exported.
11387 (last_undo_buffer, last_boundary_position, pending_boundary):
11388 Now static.
11389
50436f33
PE
11390 * textprop.c (interval_insert_behind_hooks): Now static.
11391 (interval_insert_in_front_hooks): Likewise.
11392
64520e5c
PE
11393 * term.c: Make symbols static if they're not exported.
11394 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11395 (max_frame_lines, tty_set_terminal_modes):
11396 (tty_reset_terminal_modes, tty_turn_off_highlight):
11397 (get_tty_terminal): Now static.
11398 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11399 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11400 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11401 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11402 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11403
1fa53021
PE
11404 * sysdep.c: Make symbols static if they're not exported.
11405 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11406 Now static.
11407 (sigprocmask_set, full_mask): Remove; unused.
11408 (wait_debugging): Mark as visible.
11409 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11410 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11411
d4b43b22
PE
11412 * syntax.c (syntax_temp): Define only if !__GNUC__.
11413
b7c513d0
PE
11414 * sound.c (current_sound_device, current_sound): Now static.
11415
989b29ad
PE
11416 * search.c (searchbufs, searchbuf_head): Now static.
11417
13a55a78
PE
11418 * scroll.c (scroll_cost): Remove; unused.
11419 * dispextern.h (scroll_cost): Remove decl.
11420
de68a1fc
PE
11421 * region-cache.h (pp_cache): Mark as externally visible.
11422
40ccffa6
PE
11423 * process.c: Make symbols static if they're not exported.
11424 (process_tick, update_tick, create_process, chan_process):
11425 (Vprocess_alist, proc_buffered_char, datagram_access):
11426 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11427 (deactivate_process): Mark defn as static, as well as decl.
11428 * lisp.h (create_process): Remove decl.
11429 * process.h (chan_process, Vprocess_alist): Remove decls.
11430
ad64fc97
PE
11431 * print.c: Make symbols static if they're not exported.
11432 (print_depth, new_backquote_output, being_printed, print_buffer):
11433 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11434 (print_interval, print_number_index, initial_stderr_stream):
11435 Now static.
11436 * lisp.h (Fprinc): Remove decl.
11437 (debug_output_compilation_hack): Mark as externally visible.
11438
adddb265
PE
11439 * sysdep.c (croak): Move decl from here to syssignal.h.
11440 * syssignal.h (croak): Put it here, so the API can be checked when
11441 'croak' is called from dissociate_if_controlling_tty.
11442
1717ede2
PE
11443 * minibuf.c: Make symbols static if they're not exported.
11444 (minibuf_save_list, choose_minibuf_frame): Now static.
11445 * lisp.h (choose_minibuf_frame): Remove decl.
11446
fa5fb2bc
PE
11447 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11448
1e3890d1
PE
11449 * lread.c: Make symbols static if they're not exported.
11450 (read_objects, initial_obarray, oblookup_last_bucket_number):
11451 Now static.
11452 (make_symbol): Remove; unused.
11453 * lisp.h (initial_obarray, make_symbol): Remove decls.
11454
8a1414fa
PE
11455 * keyboard.c: Make symbols static if they're not exported.
11456 (single_kboard, recent_keys_index, total_keys, recent_keys):
11457 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11458 (this_single_command_key_start, echoing, last_auto_save):
11459 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11460 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11461 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11462 (Vlispy_mouse_stem, double_click_count):
11463 Now static.
11464 (force_auto_save_soon): Define only if SIGDANGER.
11465 (ignore_mouse_drag_p): Now static if
11466 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11467 (print_help): Remove; unused.
11468 (stop_character, last_timer_event): Mark as externally visible.
11469 * keyboard.h (ignore_mouse_drag_p): Declare only if
11470 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11471 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11472 * lisp.h (echoing): Remove decl.
11473 (force_auto_save_soon): Declare only if SIGDANGER.
11474 * xdisp.c (redisplay_window): Simplify code, to make it more
11475 obvious that ignore_mouse_drag_p is not accessed if !defined
11476 USE_GTK && !defined HAVE_NS.
11477
93ea6e8f
PE
11478 * intervals.c: Make symbols static if they're not exported.
11479 (merge_properties_sticky, merge_interval_right, delete_interval):
11480 Now static.
11481 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11482
77382fcc
PE
11483 * insdel.c: Make symbols static if they're not exported.
11484 However, leave prepare_to_modify_buffer alone. It's never
11485 called from outside this function, but that appears to be a bug.
11486 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11487 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11488 (adjust_after_replace_noundo): Remove; unused.
11489 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11490 (signal_before_change): Remove decls.
77382fcc 11491
9306c32e
PE
11492 * indent.c (val_compute_motion, val_vmotion): Now static.
11493
cd44d2eb
PE
11494 * image.c: Make symbols static if they're not exported.
11495 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11496 if USE_GTK.
11497 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11498 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11499
ad9a7a06
PE
11500 * fringe.c (standard_bitmaps): Now static.
11501 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11502
81626931
PE
11503 * frame.c: Make symbols static if they're not exported.
11504 (x_report_frame_params, make_terminal_frame): Now static.
11505 (get_frame_param): Now static, unless HAVE_NS.
11506 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11507 (x_get_resource_string): Remove; not used.
11508 * frame.h (make_terminal_frame, x_report_frame_params):
11509 (x_get_resource_string); Remove decls.
11510 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11511 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11512
239f9db9
PE
11513 * font.c, fontset.c: Make symbols static if they're not exported.
11514 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11515 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11516 * font.c (font_close_object): Now static.
11517 * font.h (font_close_object): Remove.
11518 * fontset.c (FONTSET_OBJLIST): Remove.
11519 (free_realized_fontset) #if-0 the body, which does nothing.
11520 (face_suitable_for_char_p): #if-0, as it's never called.
11521 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11522 * xfaces.c (face_at_string_position):
11523 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11524 since 0 is always ASCII.
11525
dfcf3579
PE
11526 * fns.c (weak_hash_tables): Now static.
11527
5045092b
PE
11528 * fileio.c: Make symbols static if they're not exported.
11529 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11530 (Vwrite_region_annotation_buffers): Now static.
11531
57a96f5c
PE
11532 * eval.c: Make symbols static if they're not exported.
11533 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11534 * lisp.h (backtrace_list): Remove decl.
11535
35f08c38
PE
11536 * emacs.c: Make symbols static if they're not exported.
11537 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11538 (fatal_error_code, fatal_error_signal_hook, standard_args):
11539 Now static.
11540 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11541 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11542 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11543 * lisp.h (fatal_error_signal_hook): Remove decl.
11544 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11545
f44bd759
PE
11546 * editfns.c: Move a (normally-unused) function to its only use.
11547 * editfns.c, lisp.h (get_operating_system_release): Remove.
11548 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11549 worth the hassle of breaking this out.
11550
b532497d
PE
11551 * xterm.c: Make symbols static if they're not exported.
11552 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11553 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11554 (x_destroy_window, x_delete_display):
11555 Now static.
11556 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11557 (x_mouse_leave): Remove; unused.
11558 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11559 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11560 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11561 Remove decls.
11562 (x_mouse_leave): Declare only if WINDOWSNT.
11563 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11564 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11565 USE_X_TOOLKIT.
11566
1675728f
PE
11567 * ftxfont.c: Make symbols static if they're not exported.
11568 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11569 HAVE_FREETYPE.
11570 * font.h (ftxfont_driver): Likewise.
11571
e4cebfca
PE
11572 * xfns.c: Make symbols static if they're not exported.
11573 (x_last_font_name, x_display_info_for_name):
11574 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11575 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11576 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11577 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11578 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11579 (last_show_tip_args): Now static.
11580 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11581 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11582 (x_screen_planes): Remove; unused.
11583 * dispextern.h (x_screen_planes): Remove decl.
11584
5bf46f05
PE
11585 * dispnew.c: Make symbols static if they're not exported.
11586 * dispextern.h (redraw_garbaged_frames, scrolling):
11587 (increment_row_positions): Remove.
11588 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11589 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11590 Now static.
11591 (redraw_garbaged_frames): Remove; unused.
11592
435f4c28
PE
11593 * xfaces.c: Make symbols static if they're not exported.
11594 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11595 Remove decls.
11596 * xterm.h (defined_color): Remove decls.
11597 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11598 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11599 (menu_face_changed_default, defined_color, free_realized_face):
11600 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11601 (ascii_face_of_lisp_face): Remove; unused.
11602
8524aef3
PE
11603 * xdisp.c: Make symbols static if they're not exported.
11604 * dispextern.h (scratch_glyph_row, window_box_edges):
11605 (glyph_to_pixel_coords, set_cursor_from_row):
11606 (get_next_display_element, set_iterator_to_next):
11607 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11608 (show_mouse_face): Remove decls
11609 * frame.h (message_buf_print): Likewise.
11610 * lisp.h (pop_message, set_message, check_point_in_composition):
11611 Likewise.
11612 * xterm.h (set_vertical_scroll_bar): Likewise.
11613 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11614 (message_buf_print, scratch_glyph_row, displayed_buffer):
11615 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11616 (get_next_display_element, show_mouse_face, window_box_edges):
11617 (frame_to_window_pixel_xy, check_point_in_composition):
11618 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11619 (glyph_to_pixel_coords): Remove; unused.
11620
16390cd2
PE
11621 * dired.c (file_name_completion): Now static.
11622
11623 * dbusbind.c (xd_in_read_queued_messages): Now static.
11624
a25f4dfa
PE
11625 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11626 * data.c (circular_list_error): Remove.
11627
14a9c8df
PE
11628 * commands.h (last_point_position, last_point_position_buffer):
11629 (last_point_position_window): Remove decls.
11630 * keyboard.c: Make these variables static.
11631
04f2d78b
CB
11632 * coding.h (coding, code_convert_region, encode_coding_gap):
11633 Remove decls.
74ab6df5
PE
11634 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11635 (iso_code_class, detect_coding, code_convert_region): Now static.
11636 (encode_coding_gap): Remove; unused.
11637
38dfbee1
PE
11638 * chartab.c (chartab_chars, chartab_bits): Now static.
11639
a2cb4e63
PE
11640 * charset.h (charset_iso_8859_1): Remove decl.
11641 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11642 Now static.
11643
127198fd
PE
11644 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11645 * ccl.c (Vccl_program_table): Now static.
11646 (check_ccl_update): Remove; unused.
11647
d85b608f
PE
11648 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11649 * category.h: ... from here.
11650 * category.c (check_category_table, set_category_set): Now static.
11651
31cd66f3
PE
11652 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11653 * lisp.h: Remove these decls.
11654
c358e587
PE
11655 * buffer.c (buffer_count): Remove unused var.
11656
e78aecca
PE
11657 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11658 so that it's not optimized away.
11659 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11660 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11661 exported only to the debugger.
11662
e192d7d3 11663 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11664 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11665
92470028
PE
11666 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11667 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11668 was inaccessible from Lisp.
11669 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11670 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11671
244ed907
PE
11672 alloc.c: Import and export fewer symbols, and remove unused items.
11673 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11674 is defined.
11675 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11676 it's not optimized away by whole-program optimization.
11677 (message_enable_multibyte, free_misc): Remove.
11678 (catchlist, handlerlist, mark_backtrace):
11679 Declare only if BYTE_MARK_STACK.
11680 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11681 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11682 (message_enable_multibyte): Remove decl.
11683 (free_misc, interval_free_list, float_block, float_block_index):
11684 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11685 (cons_free_list, last_marked_index):
11686 Now static.
11687 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11688 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11689 (mark_backtrace): Define only if BYTE_MARK_STACK.
11690 * xdisp.c (message_enable_multibyte): Now static.
11691
61c2b50e 11692 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11693 This makes it easier for human readers (and static analyzers)
11694 to see whether these variables are used from other modules.
11695 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11696 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11697 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11698 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11699 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11700 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11701 * xmenu.c, xselect.c:
11702 Declare Q* vars static if they are not used in other modules.
11703 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11704 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11705 Remove decls of unexported vars.
11706 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11707
95c82688
PE
11708 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11709
16a97296
PE
11710 Make Emacs functions such as Fatom 'static' by default.
11711 This makes it easier for human readers (and static analyzers)
11712 to see whether these functions can be called from other modules.
11713 DEFUN now defines a static function. To make the function external
11714 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11715 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11716 (Finit_image_library):
16a97296
PE
11717 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11718 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11719 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11720 Remove decls, since these functions are now static.
11721 (Funintern, Fget_internal_run_time): New decls, since these functions
11722 were already external.
95c82688 11723
16a97296
PE
11724 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11725 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11726 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11727 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11728 * keyboard.c, keymap.c, lread.c:
11729 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11730 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11731 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11732 Mark functions with DEFUE instead of DEFUN,
11733 if they are used in other modules.
11734 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11735 decls for now-static functions.
11736 * buffer.h (Fdelete_overlay): Remove decl.
11737 * callproc.c (Fgetenv_internal): Mark as internal.
11738 * composite.c (Fremove_list_of_text_properties): Remove decl.
11739 (Fcomposition_get_gstring): New forward static decl.
11740 * composite.h (Fcomposite_get_gstring): Remove decl.
11741 * dired.c (Ffile_attributes): New forward static decl.
11742 * doc.c (Fdocumntation_property): New forward static decl.
11743 * eval.c (Ffetch_bytecode): New forward static decl.
11744 (Funintern): Remove extern decl; now in .h file where it belongs.
11745 * fileio.c (Fmake_symbolic_link): New forward static decl.
11746 * image.c (Finit_image_library): New forward static decl.
11747 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11748 * intervals.h (Fprevious_property_change):
11749 (Fremove_list_of_text_properties): Remove decls.
11750 * keyboard.c (Fthis_command_keys): Remove decl.
11751 (Fcommand_execute): New forward static decl.
11752 * keymap.c (Flookup_key): New forward static decl.
11753 (Fcopy_keymap): Now static.
11754 * keymap.h (Flookup_key): Remove decl.
11755 * process.c (Fget_process): New forward static decl.
11756 (Fprocess_datagram_address): Mark as internal.
11757 * syntax.c (Fsyntax_table_p): New forward static decl.
11758 (skip_chars): Remove duplicate decl.
11759 * textprop.c (Fprevious_property_change): New forward static decl.
11760 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11761 Now internal.
11762 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11763 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11764
785bbd42
PE
11765 * editfns.c (Fformat): Remove unreachable code.
11766
8b913b57
AS
117672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11768
11769 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11770 change. (Bug#8496)
11771
a6744a35
EZ
117722011-04-13 Eli Zaretskii <eliz@gnu.org>
11773
11774 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11775 when at ZV. (Bug#8487)
11776
e7974947
AS
117772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11778
baad03f0
AS
11779 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11780 (Bug#8437)
11781 * keyboard.c (parse_tool_bar_item): Likewise.
11782 * sound.c (sound_cleanup, alsa_close): Likewise.
11783 * termcap.c (tgetent): Likewise.
11784 * xfns.c (x_default_font_parameter): Likewise.
11785 * xsettings.c (read_and_apply_settings): Likewise.
11786
e7974947
AS
11787 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11788 (overrun_check_free): Protoize.
11789
28272684
PE
117902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11791
11792 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11793 since callers should never pass a negative size.
11794 Change the signature to match that of plain 'read' and 'write'; see
11795 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11796 * lisp.h: Update prototypes of emacs_write and emacs_read.
11797
11997c76
EZ
117982011-04-11 Eli Zaretskii <eliz@gnu.org>
11799
11800 * xdisp.c (redisplay_window): Don't try to determine the character
11801 position of the scroll margin if the window start point w->startp
e896f03c 11802 is outside the buffer's accessible region. (Bug#8468)
11997c76 11803
8a2cbd72
EZ
118042011-04-10 Eli Zaretskii <eliz@gnu.org>
11805
11806 Fix write-region and its subroutines for buffers > 2GB.
11807 * fileio.c (a_write, e_write): Modify declaration of arguments and
11808 local variables to support buffers larger than 2GB.
11809 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11810
11811 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11812 argument, local variables, and return value.
11813
11814 * lisp.h: Update prototypes of emacs_write and emacs_read.
11815
11816 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11817
4073e537 118182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11819
1ebfdcb6
PE
11820 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11821
b2ded58d
PE
11822 Fix more problems found by GCC 4.6.0's static checks.
11823
7d66342c
PE
11824 * xdisp.c (vmessage): Use a better test for character truncation.
11825
bbf47d44
PE
11826 * charset.c (load_charset_map): <, not <=, for optimization,
11827 and to avoid potential problems with integer overflow.
9248994d 11828 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11829 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11830 * editfns.c (Fformat): Likewise.
1e69125e 11831 * syntax.c (skip_chars): Likewise.
3befa583 11832
e3019616
PE
11833 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11834 This also lets GCC 4.6.0 generate slightly better loop code.
11835
becfa255
PE
11836 * callint.c (Fcall_interactively): <, not <=, for optimization.
11837 (Fcall_interactively): Count the number of arguments produced,
11838 not the number of arguments given. This is simpler and lets GCC
11839 4.6.0 generate slightly better code.
11840
dae0cd48
PE
11841 * ftfont.c: Distingish more carefully between FcChar8 and char.
11842 The previous code passed unsigned char * to a functions like
11843 strlen and xstrcasecmp that expect char *, which does not
11844 conform to the C standard.
11845 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11846 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11847 char * when the C standard requires it.
11848
76032d70
PE
11849 * keyboard.c (read_char): Remove unused var.
11850
eb3f1cc8
PE
11851 * eval.c: Port to Windows vsnprintf (Bug#8435).
11852 Include <limits.h>.
11853 (SIZE_MAX): Define if the headers do not.
11854 (verror): Do not give up if vsnprintf returns a negative count.
11855 Instead, grow the buffer. This ports to Windows vsnprintf, which
11856 does not conform to C99. Problem reported by Eli Zaretskii.
11857 Also, simplify the allocation scheme, by avoiding the need for
11858 calling realloc, and removing the ALLOCATED variable.
11859
70476b54
PE
11860 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11861
12020a9e
PE
11862 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11863 But keep the doprint source code for now, as we might revamp it
11864 and use it again (Bug#8435).
ea6c7ae6
PE
11865 * lisp.h (doprnt): Remove.
11866 * Makefile.in (base_obj): Remove doprnt.o.
11867 * deps.mk (doprnt.o): Remove.
11868
5fdb398c
PE
11869 error: Print 32- and 64-bit integers portably (Bug#8435).
11870 Without this change, on typical 64-bit hosts error ("...%d...", N)
11871 was used to print both 32- and 64-bit integers N, which relied on
11872 undefined behavior.
61bdb816 11873 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11874 * lisp.h (error, verror): Mark as printf-like functions.
11875 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11876 Report overflow in size calculations when allocating printf buffer.
11877 Do not truncate output string at its first null byte.
11878 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11879 Truncate the output at a character boundary, since vsnprintf does not
11880 do that.
11881 * charset.c (check_iso_charset_parameter): Convert internal
11882 character to string before calling 'error', since %c now has the
11883 printf meaning.
11884 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11885 overflow when computing char to be passed to 'error'. Do not
11886 pass Lisp_Object to 'error'; pass the integer instead.
11887 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11888 formatted with plain %d.
11889
b189fa66
PE
11890 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11891
bff87ef0
PE
11892 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11893
7e2cac20
PE
11894 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11895
ce4d90b5
PE
11896 * xterm.c (x_catch_errors): Remove duplicate declaration.
11897
266c9547
PE
11898 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11899
79c49ad2
PE
11900 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11901
368f4090
JM
119022011-04-10 Jim Meyering <meyering@redhat.com>
11903
11904 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11905 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11906 return ssize_t not "int", and use size_t as the buffer length.
11907 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11908 * gnutls.h: Update declarations.
11909 * process.c (read_process_output): Use ssize_t, to match.
11910 (send_process): Likewise.
11911
a32d4040
CY
119122011-04-09 Chong Yidong <cyd@stupidchicken.com>
11913
11914 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11915
8546720e 119162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11917
04f2d78b
CB
11918 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11919 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11920
8546720e
GM
11921 * xterm.c (handle_one_xevent):
11922 * xmenu.c (create_and_show_popup_menu):
11923 * xselect.c (x_decline_selection_request)
11924 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11925
0a2f5c1a 119262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11927
11928 Fix some uses of `int' instead of EMACS_INT.
11929 * search.c (string_match_1, fast_string_match)
11930 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11931 (scan_buffer, find_next_newline_no_quit)
11932 (find_before_next_newline, search_command, Freplace_match)
11933 (Fmatch_data): Make some `int' variables be EMACS_INT.
11934
11935 * xdisp.c (display_count_lines): 3rd argument and return value now
11936 EMACS_INT. All callers changed.
11937 (pint2hrstr): Last argument is now EMACS_INT.
11938
11939 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11940 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11941 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11942 (decode_coding_utf_16, decode_coding_emacs_mule)
11943 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11944 (decode_coding_ccl, decode_coding_charset)
11945 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11946 (decode_coding_iso_2022, decode_coding_emacs_mule)
11947 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11948 <char_offset, last_offset>: Declare EMACS_INT.
11949 (encode_coding_utf_8, encode_coding_utf_16)
11950 (encode_coding_emacs_mule, encode_invocation_designation)
11951 (encode_designation_at_bol, encode_coding_iso_2022)
11952 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11953 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11954 Declare EMACS_INT.
11955 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11956 (encode_invocation_designation): Last argument P_NCHARS is now
11957 EMACS_INT.
11958 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11959 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11960
11961 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11962 All users changed.
11963
11964 * ccl.c (Fccl_execute_on_string): Declare some variables
11965 EMACS_INT.
11966
8546720e 119672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11968
11969 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11970
4e19a977
CS
119712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11972
11973 * process.c (Fformat_network_address): Doc fix.
11974
87302331
R
119752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11976
ee7683eb 11977 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11978
cbb59342
CY
119792011-04-08 Chong Yidong <cyd@stupidchicken.com>
11980
11981 * keyboard.c (read_char): Call Lisp function help-form-show,
11982 instead of using internal_with_output_to_temp_buffer.
11983 (Qhelp_form_show): New var.
e0d38eeb 11984 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11985
11986 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11987
11988 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11989
e67a13ab
CY
119902011-04-06 Chong Yidong <cyd@stupidchicken.com>
11991
04f2d78b
CB
11992 * process.c (Flist_processes): Remove to Lisp.
11993 (list_processes_1): Delete.
e67a13ab 11994
973f782d
EZ
119952011-04-06 Eli Zaretskii <eliz@gnu.org>
11996
7c106b1e
EZ
11997 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11998
973f782d
EZ
11999 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12000
41cf7d1a 120012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12002
ca23cc88
PE
12003 Fix more problems found by GCC 4.6.0's static checks.
12004
f390e2d5
PE
12005 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12006
42eea0d0
PE
12007 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12008
b69769da 12009 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12010
f9541e84
PE
12011 * xdisp.c (vmessage): Mark as a printf-like function.
12012
13841b55
PE
12013 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12014
c136c10f
PE
12015 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12016
5e2d4a30
PE
12017 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12018 printf-like functions.
12019 (tiff_load): Add casts to remove these marks before passing them
12020 to system-supplied API.
12021
583f48b9
PE
12022 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12023
b25d760e
PE
12024 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12025 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12026 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12027 directly, rather than having caller test rule sign. This avoids
12028 some unnecessary tests.
12029 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12030 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12031 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12032
bc7b6697 12033 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12034 (xfont_open): Avoid unnecessary tests.
bc7b6697 12035
27ccc379
PE
12036 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12037
dcd5c89a
PE
12038 * composite.h, composite.c (composition_gstring_put_cache):
12039 Use EMACS_INT, not int, for length.
12040
b13a45c6
PE
12041 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12042 breaking out part of COMPOSITION_DECODE_RULE.
12043 (COMPOSITION_DECODE_RULE): Use it.
12044 * composite.c (get_composition_id): Remove unused local vars,
12045 by using the new macro.
12046
1e792e4d
PE
12047 * textprop.c (set_text_properties_1): Change while to do-while,
12048 since the condition is always true at first.
12049
dc6c6455 12050 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12051 (interval_deletion_adjustment): Return unsigned value.
12052 All uses changed.
dc6c6455 12053
aba7731a
PE
12054 * process.c (list_processes_1, create_pty, read_process_output):
12055 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12056 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12057 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12058 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12059 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12060
fdfc4bf3
PE
12061 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12062
fca8fe46 12063 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12064 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12065
06a0259a 12066 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12067 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12068 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12069
e7b9e80f
PE
12070 * print.c (print_error_message): Avoid int overflow.
12071
56201685
PE
12072 * font.c (font_list_entities): Redo for clarity,
12073 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12074
78834453 12075 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12076 (font_score): Avoid potential overflow in diff calculation.
78834453 12077
0bc0b309 12078 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12079 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12080
e610eaca
PE
12081 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12082
b895abce
PE
12083 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12084 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12085 can always succeed if overflow has undefined behavior.
12086
1f1d9321 12087 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12088 (wordify): Omit three unnecessary tests.
1f1d9321 12089
c59478bc
PE
12090 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12091 All callers changed. This avoids the need for an unused var.
12092
79b73827
PE
12093 * casefiddle.c (casify_region): Remove var that is set but not used.
12094
a4db5dfe
PE
12095 * dired.c (file_name_completion): Remove var that is set but not used.
12096
43aae36e
PE
12097 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12098
2a47c44d 12099 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12100 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12101
a37c69bf
PE
12102 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12103 Check for integer overflow on size calculations.
12104
328ab8e7
PE
12105 * buffer.c (Fprevious_overlay_change): Remove var that is set
12106 but not used.
12107
e5a2a5cb
PE
12108 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12109 Remove vars that are set but not used.
8d84a6eb 12110 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12111 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12112
a60e5f68
PE
12113 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12114
f661cb61 12115 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12116 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12117
f0397f5a
PE
12118 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12119 that are set but not used.
12120
8664db06 12121 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12122 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12123
6abdaa4a
PE
12124 * xselect.c (x_get_local_selection, x_handle_property_notify):
12125 Remove vars that are set but not used.
12126
0ce7538d 12127 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12128 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12129
9ae848fc
PE
12130 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12131 Remove var that is set but not used.
0b918413
PE
12132 (scroll_bar_windows_size): Now size_t, not int.
12133 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12134 Check for overflow.
9ae848fc 12135
a5a62657
PE
12136 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12137 (map_tty_color) [!defined MSDOS]: Likewise.
12138
5c5cdd39
PE
12139 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12140
66ebf983
PE
12141 * coding.c: Remove vars that are set but not used.
12142 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12143 All callers changed.
12144 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12145 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12146 (decode_coding_charset): Remove vars that are set but not used.
12147
1be4d761
PE
12148 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12149 that is set but not used.
12150
47553fa8
PE
12151 * print.c (print_object): Remove var that is set but not used.
12152
1f7196bf 12153 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12154 The gnulib version avoids calling malloc in the usual case,
12155 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12156 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12157 * filelock.c (current_lock_owner): Likewise.
12158 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12159 * sysdep.c: Include allocator.h, careadlinkat.h.
12160 (emacs_no_realloc_allocator): New static constant.
12161 (emacs_readlink): New function.
fdb61804
PE
12162 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12163 ../lib/careadlinkat.h.
d1fdcab7 12164
f84c17c7
SM
121652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12166
12167 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12168 first non-nil return value).
12169
ef3862ad
JD
121702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12171
12172 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12173 if not defined (Bug#8403).
12174
376a7006
JB
121752011-04-02 Juanma Barranquero <lekktu@gmail.com>
12176
12177 * xdisp.c (display_count_lines): Remove parameter `start',
12178 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12179 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12180 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12181 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12182 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12183 and thereabouts. All callers changed.
12184 (get_per_char_metric): Remove parameter `f', unused since
12185 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12186
6ca3801d
JM
121872011-04-02 Jim Meyering <meyering@redhat.com>
12188
12189 do not dereference NULL upon failed strdup
12190 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12191 (ns_get_family): Likewise.
12192
d8e2b5ba
JB
121932011-04-02 Juanma Barranquero <lekktu@gmail.com>
12194
12195 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12196
8c74fcbd
JD
121972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12198
12199 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12200 later (Bug#8403).
12201
7200d79c
SM
122022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12203
03408648 12204 Add lexical binding.
7200d79c 12205
03408648
SM
12206 * window.c (Ftemp_output_buffer_show): New fun.
12207 (Fsave_window_excursion):
12208 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12209
12210 * lread.c (lisp_file_lexically_bound_p): New function.
12211 (Fload): Bind Qlexical_binding.
12212 (readevalloop): Remove `evalfun' arg.
12213 Bind Qinternal_interpreter_environment.
12214 (Feval_buffer): Bind Qlexical_binding.
12215 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12216 Mark as dynamic.
12217 (syms_of_lread): Declare `lexical-binding'.
12218
12219 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12220
12221 * keyboard.c (eval_dyn): New fun.
12222 (menu_item_eval_property): Use it.
ca105506
SM
12223
12224 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12225
03408648
SM
12226 * fns.c (concat, mapcar1): Accept byte-code-functions.
12227
12228 * eval.c (Fsetq): Handle lexical vars.
12229 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12230 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12231 (FletX, Flet): Obey lexical binding.
12232 (Fcommandp): Handle closures.
12233 (Feval): New `lexical' arg.
12234 (eval_sub): New function extracted from Feval. Use it almost
12235 everywhere where Feval was used. Look up vars in lexical env.
12236 Handle closures.
12237 (Ffunctionp): Move from subr.el.
12238 (Ffuncall): Handle closures.
12239 (apply_lambda): Remove `eval_flags'.
12240 (funcall_lambda): Handle closures and new byte-code-functions.
12241 (Fspecial_variable_p): New function.
12242 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12243 but without exporting it to Lisp.
23aba0ea 12244
23aba0ea 12245 * doc.c (Fdocumentation, store_function_docstring):
03408648 12246 * data.c (Finteractive_form): Handle closures.
23aba0ea 12247
03408648
SM
12248 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12249 interactive spec.
ba83908c 12250
04f2d78b
CB
12251 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12252 New byte-codes.
03408648
SM
12253 (exec_byte_code): New function extracted from Fbyte_code to handle new
12254 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12255
03408648 12256 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12257
03408648 12258 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12259
e2abce01
JB
122602011-03-31 Juanma Barranquero <lekktu@gmail.com>
12261
12262 * xdisp.c (redisplay_internal): Fix prototype.
12263
63696a73 122642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12265
63696a73 12266 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12267 (try_scrolling): Use it when setting scroll_limit.
12268 Limit scrolling to 100 screen lines.
63696a73
EZ
12269 (redisplay_window): Even when falling back on "recentering",
12270 position point in the window according to scroll-conservatively,
12271 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12272
12273 (try_scrolling): When point is above the window, allow searching
12274 as far as scroll_max, or one screenful, to compute vertical
12275 distance from PT to the scroll margin position. This prevents
12276 try_scrolling from unnecessarily failing when
12277 scroll-conservatively is set to a value slightly larger than the
12278 window height. Clean up the case of PT below the margin at bottom
12279 of window: scroll_max can no longer be INT_MAX. When aggressive
12280 scrolling is in use, don't let point enter the opposite scroll
12281 margin as result of the scroll.
12282 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12283 threshold of 100 lines for never-recentering scrolling.
12284
e4cc2dfc
JB
122852011-03-31 Juanma Barranquero <lekktu@gmail.com>
12286
12287 * dispextern.h (move_it_by_lines):
12288 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12289 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12290 (message_log_check_duplicate): Remove parameters `prev_bol' and
12291 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12292 (redisplay_internal): Remove parameter `preserve_echo_area',
12293 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12294
12295 * indent.c (Fvertical_motion):
12296 * window.c (window_scroll_pixel_based, Frecenter):
12297 Don't pass `need_y_p' to `move_it_by_lines'.
12298
1c470562
SM
122992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12300
44f230aa
SM
12301 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12302 steal a few bits to be more compact.
12303 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12304 Remove unneeded casts.
12305
1c470562
SM
12306 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12307
888adce9
ZK
123082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12309
12310 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12311 binding" message (bug#7967).
12312
f838ed7b
PE
123132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12314
77861b95
PE
12315 Fix more problems found by GCC 4.6.0's static checks.
12316
de6dbc14
PE
12317 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12318 Remove unused local var.
12319
f838ed7b
PE
12320 * editfns.c (Fmessage_box): Remove unused local var.
12321
792c7b2b
PE
12322 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12323 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12324 Omit unused local vars.
c499e557 12325 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12326 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12327 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12328 Omit unused local var.
12329
ba0165e1
PE
12330 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12331 Don't assume string length fits in int.
32ad8845 12332 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12333 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12334
3c59b4c9
PE
12335 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12336 instead of alloca (Bug#8344).
12337
a3eed478 12338 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12339 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12340
eb4d412d
PE
12341 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12342
1658b401
PE
12343 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12344 concerns.
12345
12346 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12347
12348 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12349
9a2c6e05
PE
12350 * keyboard.c (syms_of_keyboard): Use the same style as later
12351 in this function when indexing through an array. This also
12352 works around GCC bug 48267.
12353
03d0a109
PE
12354 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12355
44f730c8
PE
12356 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12357
fe75f926
PE
12358 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12359 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12360
ffa8c828
PE
12361 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12362 This avoids undefined behavior on integer overflow, and is a bit
12363 more convenient anyway since it is compared to a size_t variable.
12364
c5101a77
PE
12365 Variadic C functions now count arguments with size_t, not int.
12366 This avoids an unnecessary limitation on 64-bit machines, which
12367 caused (substring ...) to crash on large vectors (Bug#8344).
12368 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12369 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12370 All variadic functions and their callers changed accordingly.
c5101a77
PE
12371 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12372 * data.c (arith_driver, float_arith_driver): Likewise.
12373 * editfns.c (general_insert_function): Likewise.
12374 * eval.c (struct backtrace.nargs, interactive_p)
12375 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12376 (funcall_lambda, mark_backtrace): Likewise.
12377 * fns.c (concat): Likewise.
12378 * frame.c (x_set_frame_parameters): Likewise.
12379 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12380 0 if not found, not -1. All callers changed.
12381
dd3f25f7
PE
12382 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12383 (stack_copy_size): Now size_t, not int.
12384 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12385
461c2ab9
JB
123862011-03-28 Juanma Barranquero <lekktu@gmail.com>
12387
12388 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12389 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12390 All callers changed.
12391
12392 * lisp.h (multibyte_char_to_unibyte):
12393 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12394 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12395 * character.h (CHAR_TO_BYTE8):
12396 * cmds.c (internal_self_insert):
12397 * editfns.c (general_insert_function):
12398 * keymap.c (push_key_description):
12399 * search.c (Freplace_match):
12400 * xdisp.c (message_dolog, set_message_1): All callers changed.
12401
f6d62986
SM
124022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12403
12404 * keyboard.c (safe_run_hook_funcall): New function.
12405 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12406 don't set the hook to nil, but remove the offending function instead.
12407 (Qcommand_hook_internal): Remove, unused.
12408 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12409 Vcommand_hook_internal.
12410
12411 * eval.c (enum run_hooks_condition): Remove.
12412 (funcall_nil, funcall_not): New functions.
12413 (run_hook_with_args): Call each function through a `funcall' argument.
12414 Remove `cond' argument, now redundant.
12415 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12416 (Frun_hook_with_args_until_failure): Adjust accordingly.
12417 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12418
1db5b1ad
JB
124192011-03-28 Juanma Barranquero <lekktu@gmail.com>
12420
12421 * dispextern.h (string_buffer_position): Remove declaration.
12422
12423 * print.c (strout): Remove parameter `multibyte', unused since
12424 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12425
12426 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12427 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12428 All callers changed.
12429
12430 * w32.c (_wsa_errlist): Use braces for struct initializers.
12431
12432 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12433 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12434 All callers changed.
12435 (string_buffer_position): Likewise. Also, make static (it's never
12436 used outside xdisp.c).
12437 (cursor_row_p): Remove parameter `w', unused since
12438 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12439 (decode_mode_spec): Remove parameter `precision', introduced during
12440 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12441 All callers changed.
12442
5ffb62aa
JD
124432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12444
12445 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12446
461c2ab9 124472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12448
12449 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12450 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12451 (ns_update_auto_hide_menu_bar): New functions.
12452 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12453 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12454 ns_constrain_all_frames.
12455 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12456 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12457
5c380ffb
JD
124582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12459
12460 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12461
9af30bdf
GM
124622011-03-27 Glenn Morris <rgm@gnu.org>
12463
12464 * syssignal.h: Replace RETSIGTYPE with void.
12465 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12466 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12467 Replace SIGTYPE with void everywhere.
12468 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12469 * s/template.h (SIGTYPE): Remove commented out definition.
12470
e2abce01
JB
124712011-03-26 Eli Zaretskii <eliz@gnu.org>
12472
12473 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12474 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12475
f868cd8a
JB
124762011-03-26 Juanma Barranquero <lekktu@gmail.com>
12477
59eb0929
JB
12478 * w32.c (read_unc_volume): Use parameter `henum', instead of
12479 global variable `wget_enum_handle'.
12480
12481 * keymap.c (describe_vector): Remove parameters `indices' and
12482 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12483 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12484
f868cd8a
JB
12485 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12486
12487 * keyboard.c (timer_check): Remove parameter `do_it_now',
12488 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12489 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12490 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12491
12492 * keyboard.c (read_char):
12493 * w32menu.c (w32_menu_display_help):
12494 * xmenu.c (show_help_event, menu_help_callback):
12495 Adjust calls to `show_help_echo'.
12496
12497 * gtkutil.c (xg_maybe_add_timer):
12498 * keyboard.c (readable_events):
12499 * process.c (wait_reading_process_output):
12500 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12501
12502 * insdel.c (adjust_markers_gap_motion):
12503 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12504 (gap_left, gap_right): Don't call it.
12505
2ecf6fdb
CY
125062011-03-25 Chong Yidong <cyd@stupidchicken.com>
12507
12508 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12509 incurred during fontification.
12510
6b1f9ba4
JB
125112011-03-25 Juanma Barranquero <lekktu@gmail.com>
12512
12513 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12514 (DEFVAR_PER_BUFFER): Don't pass it.
12515
12516 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12517 (scrolling_window): Don't pass it.
12518
0f4a96b5
JB
125192011-03-25 Juanma Barranquero <lekktu@gmail.com>
12520
12521 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12522
12523 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12524 and `suffix'.
12525 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12526 of variables specific to SELinux and computation of `encoded_absname'.
12527
12528 * image.c (XPutPixel): Remove unused variable `height'.
12529
12530 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12531
12532 * unexw32.c (get_section_info): Remove unused variable `section'.
12533
12534 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12535 (system_process_attributes): Remove unused variable `sess'.
12536 (sys_read): Remove unused variable `err'.
12537
12538 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12539 (w32_wnd_proc): Remove unused variable `isdead'.
12540 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12541 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12542 (x_create_tip_frame): Remove unused variable `tem'.
12543
12544 * w32inevt.c (w32_console_read_socket):
12545 Remove unused variable `no_events'.
12546
12547 * w32term.c (x_draw_composite_glyph_string_foreground):
12548 Remove unused variable `width'.
12549
1149507c
JB
125502011-03-24 Juanma Barranquero <lekktu@gmail.com>
12551
12552 * w32term.c (x_set_glyph_string_clipping):
12553 Don't pass uninitialized region to CombineRgn.
12554
9c88f339
JB
125552011-03-23 Juanma Barranquero <lekktu@gmail.com>
12556
12557 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12558 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12559 (Fx_close_connection): Remove unused variable `i'.
12560
12561 * w32font.c (w32font_draw): Return number of glyphs.
12562 (w32font_open_internal): Remove unused variable `i'.
12563 (w32font_driver): Add missing initializer.
12564
12565 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12566 (fill_in_menu): Remove unused variable `items_added'.
12567
12568 * w32term.c (last_mouse_press_frame): Remove static global variable.
12569 (w32_clip_to_row): Remove unused variable `f'.
12570 (x_delete_terminal): Remove unused variable `i'.
12571
12572 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12573 (NOTHING): Remove unused static global variable.
12574 (uniscribe_check_otf): Remove unused variable `table'.
12575 (uniscribe_font_driver): Add missing initializers.
12576
dee091a3
JD
125772011-03-23 Julien Danjou <julien@danjou.info>
12578
12579 * term.c (Fsuspend_tty, Fresume_tty):
12580 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12581 * window.c (temp_output_buffer_show):
12582 * insdel.c (signal_before_change):
12583 * frame.c (Fhandle_switch_frame):
12584 * fileio.c (Fdo_auto_save):
12585 * emacs.c (Fkill_emacs):
12586 * editfns.c (save_excursion_restore):
12587 * cmds.c (internal_self_insert):
12588 * callint.c (Fcall_interactively):
12589 * buffer.c (Fkill_all_local_variables):
12590 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12591 Use Frun_hooks.
0f4a96b5 12592 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12593 unconditionally since it does the check itself.
dee091a3 12594
2c520ab5 125952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12596
c9c49752
PE
12597 Fix more problems found by GCC 4.5.2's static checks.
12598
8abc3f12
PE
12599 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12600 the first time through the loop, since we know p0 < p1 then.
12601 This also avoids a gcc -Wstrict-overflow warning.
12602
a2d26660
PE
12603 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12604 leading to a memory leak, possible in functions like
12605 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12606 of objects (Bug#8318).
a2d26660 12607
916c72e9
PE
12608 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12609 that could (at least in theory) be that large.
12610
19ab8a18
PE
12611 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12612 This is less likely to overflow, and avoids undefined behavior if
12613 overflow does occur. All callers changed. Use strtoul to scan
12614 for the unsigned long integer.
b7cbbd6f
PE
12615 (pint2hrstr): Simplify and tune code slightly.
12616 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12617
f0641eff
PE
12618 * scroll.c (do_scrolling): Work around GCC bug 48228.
12619 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12620
7f650bb9
PE
12621 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12622 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12623 (validate_x_resource_name): Simplify count usage.
12624 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12625
37dd57d1
PE
12626 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12627 fail (Bug#8306).
81e56e61 12628
699979fc 12629 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12630
401bf9b4
PE
12631 * process.c (Fmake_network_process): Use socklen_t, not int,
12632 where POSIX says socklen_t is required in portable programs.
12633 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12634 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12635 (Fmake_network_process, server_accept_connection):
12636 (wait_reading_process_output, read_process_output):
12637 Likewise.
12638
b93aacde
PE
12639 * process.c: Rename or move locals to avoid shadowing.
12640 (list_processes_1, Fmake_network_process):
12641 (read_process_output_error_handler, exec_sentinel_error_handler):
12642 Rename or move locals.
4dc343ee 12643 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12644 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12645 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12646 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12647 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12648
af8a867c 12649 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12650 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12651 Include tparam.h instead, since it declares them.
af8a867c
PE
12652 * cm.h (PC): Remove extern decl; tparam.h now does this.
12653 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12654 * terminfo.c: Include tparam.h, to check interfaces.
12655 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12656 (tparam): Adjust signature to match interface in tparam.h;
12657 this removes some undefined behavior. Check that outstring and len
12658 are zero, which they always are with Emacs.
12659 * tparam.h (PC, BC, UP): New extern decls.
12660
0248044d 12661 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12662 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12663
8ff096c1 12664 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12665 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12666 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12667 (ftfont_list): Remove unused local.
49eaafba
PE
12668 (get_adstyle_property, ftfont_pattern_entity):
12669 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12670 Rename locals to avoid shadowing.
8ff096c1 12671
e2be39f6
PE
12672 * xfont.c (xfont_list_family): Mark var as initialized.
12673
c9735e30
PE
12674 * xml.c (make_dom): Now static.
12675
8f5201ae
PE
12676 * composite.c (composition_compute_stop_pos): Rename local to
12677 avoid shadowing.
b246f932
PE
12678 (composition_reseat_it): Remove unused locals.
12679 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12680 (composition_update_it): Mark var as initialized.
11b61122
PE
12681 (find_automatic_composition): Mark vars as initialized,
12682 with a FIXME (Bug#8290).
8f5201ae 12683
760fbc2c
PE
12684 character.h: Rename locals to avoid shadowing.
12685 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12686 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12687 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12688 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12689 to avoid shadowing.
12690
ff08eb85
PE
12691 * textprop.c (property_change_between_p): Remove; unused.
12692
fc7bf025
PE
12693 * intervals.c (interval_start_pos): Now static.
12694
235d7abc
PE
12695 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12696
44f230aa
SM
12697 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12698 Rename locals to avoid shadowing.
3e7d6594 12699
50060332
PE
12700 * sound.c (wav_play, au_play, Fplay_sound_internal):
12701 Fix pointer signedness.
d01f234b 12702 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12703 (wav_play): Initialize a variable to 0, to prevent undefined
12704 behavior (Bug#8278).
50060332 12705
c4fc4e30
PE
12706 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12707
918436ed
PE
12708 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12709
c939f91b
PE
12710 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12711 clobbering (Bug#8298).
b9c7f648
PE
12712 * sysdep.c (sys_subshell): Likewise.
12713 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12714
6bd8c144
PE
12715 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12716 This should get cleaned up, so that child_setup has the
12717 same signature on all platforms.
12718
7710357c 12719 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12720 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12721
c59da222
CY
127222011-03-22 Chong Yidong <cyd@stupidchicken.com>
12723
12724 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12725 not to be necessary, and produces flickering.
12726
66b87493
GM
127272011-03-20 Glenn Morris <rgm@gnu.org>
12728
12729 * config.in: Remove file.
12730
45b6f6d5
JB
127312011-03-20 Juanma Barranquero <lekktu@gmail.com>
12732
12733 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12734 are now in src/globals.h.
12735 (syms_of_minibuf): Remove spurious & from previous change.
12736
cd394be1 127372011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12738
12739 * minibuf.c (completing-read-function): New variable.
12740 (completing-read-default): Rename from completing-read.
12741 (completing-read): Call completing-read-function.
12742
b14e3e21
CY
127432011-03-19 Juanma Barranquero <lekktu@gmail.com>
12744
12745 * xfaces.c (Fx_load_color_file):
12746 Read color file from absolute filename (bug#8250).
12747
f2b726e6
JB
127482011-03-19 Juanma Barranquero <lekktu@gmail.com>
12749
12750 * makefile.w32-in: Update dependencies.
12751
09f6ff02
EZ
127522011-03-17 Eli Zaretskii <eliz@gnu.org>
12753
12754 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12755
29a6015a
PE
127562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12757
a3a6c54e
PE
12758 Fix more problems found by GCC 4.5.2's static checks.
12759
b766f867
PE
12760 * process.c (make_serial_process_unwind, send_process_trap):
12761 (sigchld_handler): Now static.
12762
be02381c
PE
12763 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12764 That way, the code declares only the vars that it needs.
12765 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12766 * s/cygwin.h (PTY_ITERATION): Likewise.
12767 * s/darwin.h (PTY_ITERATION): Likewise.
12768 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12769
57048744
PE
12770 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12771 * process.c (allocate_pty): Don't declare stb unless it's needed.
12772
7914961c 12773 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12774 (CONSTANTLIM): Remove; unused.
12775 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12776 Define only if needed.
7914961c 12777
b3967b18
PE
12778 * unexelf.c (unexec): Name an expression,
12779 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12780 Use a different way to cause a compilation error if anyone uses
12781 n rather than nn, a way that does not involve shadowing.
73366a00 12782 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12783
29a6015a
PE
12784 * deps.mk (unexalpha.o): Remove; unused.
12785
43cfc33e 12786 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12787 * unexec.h: New file.
ce701a33
PE
12788 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12789 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12790 Depend on unexec.h.
12791 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12792 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12793 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12794 Change as necessary to match prototype in unexec.h.
ce701a33 12795
01f44d5a
PE
12796 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12797 shadowing.
4f63c6bb 12798 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12799
a6670b0b
PE
12800 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12801 Rename locals to avoid shadowing.
12802
cef2010d 12803 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12804 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12805
d4d7173a
PE
12806 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12807
f08b802a
PE
12808 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12809 warning when compiling print.c.
12810
3ddb0639
PE
12811 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12812 instead of using an uninitialized var.
5ad03b97 12813 (font_sort_entities): Mark var as initialized.
3ddb0639 12814
170a2692
PE
12815 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12816
e663c700
PE
12817 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12818 pointers to constants.
89bc529a 12819 (font_parse_fcname): Remove unused vars.
7b81e2d0 12820 (font_delete_unmatched): Now static.
ea838e10 12821 (font_get_spec): Remove; unused.
13a547c6
PE
12822 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12823 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12824 Rename or move locals to avoid shadowing.
e663c700 12825
2a80c887 12826 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12827 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12828
1384fa33 12829 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12830 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12831
8b2c52e9
PE
12832 * alloc.c (mark_backtrace): Move decl from here ...
12833 * lisp.h: ... to here, so that it can be checked.
12834
475545b5 12835 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12836 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12837 (lisp_indirect_variable): Name an expression,
12838 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12839 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12840
b1349114 12841 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12842 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12843 Use const pointer when appropriate.
b1349114 12844
a2928364
PE
12845 * lisp.h (get_system_name, get_operating_system_release):
12846 Move decls here, to check interfaces.
12847 * process.c (get_operating_system_release): Move decl to lisp.h.
12848 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12849 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12850 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12851 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12852 (Fformat_time_string, Fencode_time, Finsert_char):
12853 (Ftranslate_region_internal, Fformat):
12854 Rename or remove local vars to avoid shadowing.
9710023e 12855 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12856
a415e694
PE
12857 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12858 avoid shadowing.
12859
8ef4622d
PE
12860 * lisp.h (eassert): Check that the argument compiles, even if
12861 ENABLE_CHECKING is not defined.
12862
946f9a5b
PE
12863 * data.c (Findirect_variable): Name an expression, to avoid
12864 gcc -Wbad-function-cast warning.
112396d6 12865 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12866 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12867 (Fmake_variable_buffer_local, Fmake_local_variable):
12868 Mark variables as initialized.
52746918 12869 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12870
e5aab7e7 12871 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12872 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12873 Rename locals to avoid shadowing.
dff45157
PE
12874 (mark_stack): Move local variables into the #ifdef region where
12875 they're used.
7bc26fdb
PE
12876 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12877 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12878 needed otherwise.
12879 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12880 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12881 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12882
e5aab7e7
PE
12883 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12884 avoids undefined behavior in theory.
12885
4da60324
PE
12886 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12887
88043301
PE
12888 Use functions, not macros, for up- and down-casing (Bug#8254).
12889 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12890 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12891 to use the following functions instead of these macros.
12892 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12893 EMACS_INT, since callers assume the returned value fits in int.
12894 (upcase1): Likewise, for UPCASE_TABLE.
12895 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12896 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12897 the race-condition problem in the old DOWNCASE.
88043301 12898
19ed5445
PE
12899 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12900 Rename locals to avoid shadowing.
12901 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12902 (regex_compile, re_search_2, re_match_2_internal):
12903 Remove unused local vars.
952db0d7
PE
12904 (FREE_VAR): Rewrite so as not to use empty "else",
12905 which gcc can warn about.
da053e48 12906 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12907 (RETALLOC_IF): Define only if needed.
12908 (WORDCHAR_P): Likewise. This one is never needed, but is used
12909 only in a comment talking about a compiler bug, so put inside
12910 the #if 0 of that comment.
12911 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12912 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12913 Remove; unused.
19ed5445 12914
1f3561e4 12915 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12916 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12917 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12918
ded6f8f7
PE
12919 * search.c (simple_search): Remove unused var.
12920
dbd37a95
PE
12921 * dired.c (compile_pattern): Move decl from here ...
12922 * lisp.h: ... to here, so that it can be checked.
12923 (struct re_registers): New forward decl.
12924
7e47afad
PE
12925 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12926
85f24f61
PE
12927 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12928 All uses changed.
12929 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12930 Rename locals to avoid shadowing.
5671df8f 12931 (Fvertical_motion): Mark locals as initialized.
85f24f61 12932
181aa2be 12933 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12934 (casify_region): Mark local as initialized.
181aa2be 12935
930d429c
PE
12936 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12937
7082eac6
PE
12938 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12939 New macros, so that the caller can use some names other than
12940 gcpro1, gcpro2, etc.
12941 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12942 of the new macros.
12943 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12944 argument, for consistency with GCPRO2_VAR, etc: it is now the
12945 prefix of the variable, not the variable itself. All uses
12946 changed.
38b2c076
PE
12947 * dired.c (directory_files_internal, file_name_completion):
12948 Rename locals to avoid shadowing.
12949
15206ed9
PE
12950 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12951 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12952 dired.c's scmp function, had undefined behavior.
12953 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12954 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12955 * buffer.h: ... to here, because these macros use current_buffer,
12956 and the new implementation with inline functions needs to have
12957 current_buffer in scope now, rather than later when the macros
12958 are used.
12959 (downcase, upcase1): New static inline functions.
12960 (DOWNCASE, UPCASE1): Reimplement using these functions.
12961 This avoids undefined behavior in expressions like
12962 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12963 from race conditions in accessing the global variables
12964 case_temp1 and case_temp2.
12965 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12966 * lisp.h (case_temp1, case_temp2): Remove their decls.
12967 * character.h (ASCII_CHAR_P): Move from here ...
12968 * lisp.h: ... to here, so that the inline functions mentioned
12969 above can use them.
12970
4a6bea26
PE
12971 * dired.c (directory_files_internal_unwind): Now static.
12972
f14b7e14
PE
12973 * fileio.c (file_name_as_directory, directory_file_name):
12974 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12975 Now static.
2893f146
PE
12976 (file_name_as_directory): Use const pointers when appropriate.
12977 (Fexpand_file_name): Likewise. In particular, newdir might
12978 point at constant storage, so make it a const pointer.
fd4ead52 12979 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12980 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12981 signedness issues.
f839df0c
PE
12982 (Fset_file_times, Finsert_file_contents, auto_save_error):
12983 Rename locals to avoid shadowing.
f14b7e14 12984
5716756e 12985 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12986 (Ftry_completion, Fall_completions): Rename or remove locals
12987 to avoid shadowing.
5716756e 12988
b4c3046a
PE
12989 * marker.c (bytepos_to_charpos): Remove; unused.
12990
b45db522
PE
12991 * lisp.h (verify_bytepos, count_markers): New decls,
12992 so that gcc does not warn that these functions aren't declared.
12993
85876d07
PE
12994 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12995 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12996 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12997 (copy_text): Remove unused local var.
85876d07 12998
03d78a21 12999 * filelock.c (within_one_second): Now static.
b3dd38ab 13000 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13001
5df8f01b
PE
13002 * buffer.c (fix_overlays_before): Mark locals as initialized.
13003 (fix_start_end_in_overlays): Likewise. This function should be
13004 simplified by using pointers-to-pointers, but that's a different
13005 matter.
b1d876f1 13006 (switch_to_buffer_1): Now static.
8f54f30a
PE
13007 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13008 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13009
a70072c9 13010 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13011 Fix pointer signedness issue.
edced198
PE
13012 (sys_subshell): Mark local as volatile if checking for lint,
13013 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13014 (MAXPATHLEN): Define only if needed.
a70072c9 13015
a0977c44
PE
13016 * process.c (serial_open, serial_configure): Move decls from here ...
13017 * systty.h: ... to here, so that they can be checked.
13018
a884fdcc
PE
13019 * fns.c (get_random, seed_random): Move extern decls from here ...
13020 * lisp.h: ... to here, so that they can be checked.
13021
604efe86 13022 * sysdep.c (reset_io): Now static.
b8950c94 13023 (wait_for_termination_signal): Remove; unused.
604efe86 13024
38fc62d9
PE
13025 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13026 (copy_keymap_item, append_key, push_text_char_description):
13027 Now static.
1004a21a 13028 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13029 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13030 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13031 (describe_map_tree):
13032 Rename locals to avoid shadowing.
38fc62d9 13033
2f2650da
PE
13034 * keyboard.c: Declare functions static if they are not used elsewhere.
13035 (echo_char, echo_dash, cmd_error, top_level_2):
13036 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13037 (read_char, kbd_buffer_get_event, make_lispy_position):
13038 (make_lispy_event, make_lispy_movement, apply_modifiers):
13039 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13040 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13041 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13042 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13043 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13044
a053e86c 13045 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13046 (mark_kboards): Move decl here ...
13047 * alloc.c (mark_kboards): ... from here.
a053e86c 13048
4752793e
PE
13049 * lisp.h (force_auto_save_soon): New decl.
13050
74f10ca7 13051 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13052 (DEFINE_DUMMY_FUNCTION): New macro.
13053 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13054 Use it.
c03cd23f
PE
13055 (main): Add casts to avoid warnings
13056 if GCC considers string literals to be constants.
74f10ca7 13057
022e70d4
PE
13058 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13059
59d6fe83
PE
13060 * dbusbind.c: Pointer signedness fixes.
13061 (xd_signature, xd_append_arg, xd_initialize):
13062 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13063 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13064 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13065 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13066
78320123
PE
13067 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13068 if GCC considers string literals to be constants.
49cebcca 13069 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13070
35ac2a97
SM
130712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13072
fb103ca9
SM
13073 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13074 (print_preprocess, print_object): New macro to fix last change.
13075
35ac2a97
SM
13076 * print.c (print_preprocess): Don't forget font objects.
13077
62973b41
JB
130782011-03-16 Juanma Barranquero <lekktu@gmail.com>
13079
13080 * emacs.c (USAGE3): Doc fixes.
13081
0e48bb22
AS
130822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13083
13084 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13085 structure.
13086
7684e57b
JB
130872011-03-14 Juanma Barranquero <lekktu@gmail.com>
13088
13089 * lisp.h (VWindow_system, Qfile_name_history):
13090 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13091 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13092 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13093
13094 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13095 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13096
13097 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13098 * w32console.c (detect_input_pending, read_input_pending)
13099 (encode_terminal_code):
13100 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13101 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13102 (w32_system_caret_y, Qfile_name_history):
13103 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13104 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13105 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13106 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13107 * w32proc.c (Qlocal, report_file_error):
13108 * w32term.c (Vwindow_system, updating_frame):
13109 * w32uniscribe.c (initialized, uniscribe_font_driver):
13110 Remove unneeded extern declarations.
13111
2aa46d6c
CY
131122011-03-14 Chong Yidong <cyd@stupidchicken.com>
13113
c96bbc66 13114 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13115
cffc6f3b
CY
131162011-03-13 Chong Yidong <cyd@stupidchicken.com>
13117
13118 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13119 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13120 These macros can no longer be used for assignment.
13121
44f230aa
SM
13122 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13123 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13124 (record_buffer_markers, fetch_buffer_markers): New functions for
13125 recording and fetching special buffer markers.
13126 (set_buffer_internal_1, set_buffer_temp): Use them.
13127
13128 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13129
13130 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13131
13132 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13133 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13134
13135 * xdisp.c (hscroll_window_tree):
13136 (reconsider_clip_changes): Use PT instead of BUF_PT.
13137
d251f04b
EZ
131382011-03-13 Eli Zaretskii <eliz@gnu.org>
13139
13140 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13141 $(EMACS_ROOT)/lib/intprops.h.
13142
f0c77cd1
PE
131432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13144
3eca4629
PE
13145 Fix more problems found by GCC 4.5.2's static checks.
13146
7c86ee98
PE
13147 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13148 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13149 (xg_free_frame_widgets): Make it clear that a local variable is
13150 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13151 (gdk_window_get_screen): Make it clear that this macro is needed
13152 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13153 (int_gtk_range_get_value): New function, which avoids a diagnostic
13154 from gcc -Wbad-function-cast.
13155 (xg_set_toolkit_scroll_bar_thumb): Use it.
13156 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13157 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13158 (get_utf8_string, xg_get_file_with_chooser):
13159 Rename locals to avoid shadowing.
13160 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13161
41729b81
PE
13162 * xgselect.c (xg_select): Remove unused var.
13163
f0c77cd1
PE
13164 * image.c (four_corners_best): Mark locals as initialized.
13165 (gif_load): Initialize transparent_p to zero (Bug#8238).
13166 Mark another local as initialized.
ec6cf4c6 13167 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13168
ce0ad53d 13169 * image.c (clear_image_cache): Now static.
d5d5a617 13170 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13171 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13172 (x_edge_detection): Remove unnecessary cast that
13173 gcc -Wbad-function-cast diagnoses.
2037898d 13174 (gif_load): Fix pointer signedness.
6ae141d6
PE
13175 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13176 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13177
33383987 131782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13179
d32df629
PE
13180 Improve quality of tests for time stamp overflow.
13181 For example, without this patch (encode-time 0 0 0 1 1
13182 1152921504606846976) returns the obviously-bogus value (-948597
13183 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13184 reports time overflow. See
13185 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13186 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13187 * editfns.c: Include limits.h and intprops.h.
13188 (TIME_T_MIN, TIME_T_MAX): New macros.
13189 (time_overflow): Move earlier, to before first use.
13190 (hi_time, lo_time): New functions, for an accurate test for
13191 out-of-range times.
13192 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13193 (Fget_internal_run_time): Don't assume time_t fits in int.
13194 (make_time): Use list2 instead of Fcons twice.
13195 (Fdecode_time): More accurate test for out-of-range times.
13196 (check_tm_member): New function.
13197 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13198 (lisp_time_argument): Don't rely on undefined left-shift and
13199 right-shift behavior when checking for time stamp overflow.
8be6f318 13200
fe31d94c
PE
13201 * editfns.c (time_overflow): New function, refactoring common code.
13202 (Fformat_time_string, Fdecode_time, Fencode_time):
13203 (Fcurrent_time_string): Use it.
13204
8be6f318
PE
13205 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13206 * dired.c (make_time): Move to ...
13207 * editfns.c (make_time): ... here.
13208 * systime.h: Note the move.
13209
09d9db2c 132102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13211
126bc0dc
YM
13212 * fringe.c (update_window_fringes): Remove unused variables.
13213
c47cbdfd
YM
13214 * unexmacosx.c (copy_data_segment): Also copy __got section.
13215 (Bug#8223)
13216
7ac80be9
EZ
132172011-03-12 Eli Zaretskii <eliz@gnu.org>
13218
c96bbc66 13219 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13220 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13221 Constify `char *' arguments and their references according to
13222 prototypes in tparam.h.
13223
ecb0f94d 13224 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13225
7ac80be9
EZ
13226 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13227 Adapt all references accordingly.
13228
13229 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13230
ef1fd07e
TT
132312011-03-11 Tom Tromey <tromey@redhat.com>
13232
13233 * buffer.c (syms_of_buffer): Remove obsolete comment.
13234
7ef4b50c
EZ
132352011-03-11 Eli Zaretskii <eliz@gnu.org>
13236
13237 * termhooks.h (encode_terminal_code): Declare prototype.
13238
13239 * msdos.c (encode_terminal_code): Don't declare prototype.
13240
13241 * term.c (encode_terminal_code): Now external again, used by
13242 w32console.c and msdos.c.
13243
44f230aa
SM
13244 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13245 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13246
4b1ec863 132472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13248
1714f52b 13249 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13250
4b1ec863
PE
13251 * fringe.c (update_window_fringes): Mark locals as initialized
13252 (Bug#8227).
13253 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13254
524c7aa6
PE
13255 * alloc.c (mark_fringe_data): Move decl from here ...
13256 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13257 to check its interface.
13258 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13259
a5c0af81 13260 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13261 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13262 (fontset_font): Mark local as initialized.
a9a06e0b 13263 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13264
b4716021
PE
13265 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13266
811e9bac 13267 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13268 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13269 (x_own_selection, Fx_disown_selection_internal): Rename locals
13270 to avoid shadowing.
13271 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13272
7e3ab302
PE
13273 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13274 so that the caller can use some name other than gcpro1.
13275 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13276 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13277 (Fx_backspace_delete_keys_p):
13278 Use them to avoid shadowing, and rename vars to avoid shadowing.
13279 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13280 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13281 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13282 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13283 Remove unused locals.
7e3ab302
PE
13284 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13285 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13286 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13287 macros.
f78faa98 13288
e2b13473
PE
13289 * xterm.h (x_mouse_leave): New decl.
13290
77f23912
PE
13291 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13292 Remove unused functions.
cdf4ba58
PE
13293 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13294 (x_calc_absolute_position): Now static.
7411c686 13295 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13296 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13297 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13298 unless they are used.
38d0b34a
PE
13299 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13300 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13301 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13302 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13303 (x_error_catcher, x_connection_closed, x_error_handler):
13304 (x_error_quitter, xembed_send_message, x_iconify_frame):
13305 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13306 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13307 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13308
44f230aa
SM
13309 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13310 Rename or move locals to avoid shadowing.
6b463e58 13311 (tty_defined_color, merge_face_heights): Now static.
5967d051 13312 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13313 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13314 does not deduce is never used uninitialized.
73719eba
PE
13315 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13316 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13317
426994c3 13318 * terminal.c (store_terminal_param): Now static.
5489860b 13319
032f1620 13320 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13321 (set_frame_menubar): Remove unused local.
d4323972 13322 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13323 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13324 since they might point to immutable storage.
281585b0
PE
13325 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13326 since it's unused otherwise.
032f1620 13327
367c19e5 13328 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13329 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13330 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13331 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13332 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13333 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13334 does not deduce are never used uninitialized.
70739cbe 13335
07b48fa9
PE
13336 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13337
8868a238 13338 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13339 * window.c (window_loop, size_window):
13340 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13341
7e5cf297 13342 * window.c (display_buffer): Now static.
d6550a9f
PE
13343 (size_window): Mark variables that gcc -Wuninitialized
13344 does not deduce are never used uninitialized.
a586633d
PE
13345 * window.h (check_all_windows): New decl, to forestall
13346 gcc -Wmissing-prototypes diagnostic.
5b555da1 13347 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13348
f6095868
PE
13349 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13350 shadowing.
13351 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13352 Include <limits.h>.
13353 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13354 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13355 (load_charset_map): Mark variables that gcc -Wuninitialized
13356 does not deduce are never used uninitialized.
53df7c11 13357 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13358
f38b440c
PE
13359 * coding.c (coding_set_source, coding_set_destination):
13360 Use "else { /* comment */ }" rather than "else /* comment */;"
13361 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13362 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13363 a block, when the outer 'i' will do.
13364 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13365 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13366 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13367 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13368 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13369 Rename locals to avoid shadowing.
13370 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13371 * coding.c (emacs_mule_char, encode_invocation_designation):
13372 Now static, since they're not used elsewhere.
413bb2db 13373 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13374 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13375 (decode_coding_emacs_mule): Mark variables that gcc
13376 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13377 (detect_coding_iso_2022): Initialize a local variable that might
13378 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13379 this initialization is needed. (Bug#8211)
5f58e762
PE
13380 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13381 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13382 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13383 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13384 Remove unused macros.
f38b440c 13385
232b38b9 13386 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13387 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13388 * character.c (string_count_byte8): Likewise.
232b38b9 13389
fb90da1b
PE
13390 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13391 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13392
fb93dbc2
PE
13393 * chartab.c (copy_sub_char_table): Now static, since it's not used
13394 elsewhere.
5c156ace
PE
13395 (sub_char_table_ref_and_range, char_table_ref_and_range):
13396 Rename locals to avoid shadowing.
bbcd0949 13397 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13398
7d3b3862 13399 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13400 (BIDI_BOB): Remove unused macro.
7d3b3862 13401
6be7d3da
PE
13402 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13403 deduce are never used uninitialized.
c2ed9c8b 13404 * term.c (encode_terminal_code): Likewise.
6be7d3da 13405
75f8807f 13406 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13407
50938595
PE
13408 * tparam.h: New file.
13409 * term.c, tparam.h: Include it.
13410 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13411 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13412 Move these decls to tparam.h, and make them agree with what
13413 is actually in tparam.c. The previous trick of using incompatible
13414 decls in different modules does not conform to the C standard.
13415 All callers of tparam changed to use tparam's actual API.
13416 * tparam.c (tparam1, tparam, tgoto):
13417 Use const pointers where appropriate.
13418
fbceeba2
PE
13419 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13420 * cm.h (struct cm): Likewise.
13421 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13422 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13423 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13424 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13425 (turn_on_face, init_tty): Likewise.
13426 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13427
7f3f1250
PE
13428 * term.c (term_mouse_position): Rename local to avoid shadowing.
13429
e6ca6543
PE
13430 * alloc.c (mark_ttys): Move decl from here ...
13431 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13432
c40f8d15
AS
134332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13434
13435 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13436
cfe0661d
JB
134372011-03-09 Juanma Barranquero <lekktu@gmail.com>
13438
13439 * search.c (compile_pattern_1): Remove argument regp, unused since
13440 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13441 (compile_pattern): Don't pass it.
13442
0afb4571
J
134432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13444
13445 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13446 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13447 for ! HAVE_GTK3.
13448 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13449
13450 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13451
13452 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13453 gdk_window_get_screen, gdk_window_get_geometry,
13454 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13455 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13456 (xg_get_pixbuf_from_pixmap): New function.
13457 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13458 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13459 Call xg_get_pixbuf_from_pixmap instead of
13460 gdk_pixbuf_get_from_drawable.
13461 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13462 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13463 (xg_check_special_colors): Use GtkStyleContext and its functions
13464 for HAVE_GTK3.
13465 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13466 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13467 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13468 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13469 Call gtk_widget_get_preferred_size.
0afb4571
J
13470 (xg_frame_resized): gdk_window_get_geometry only takes 5
13471 parameters.
44f230aa
SM
13472 (xg_win_to_widget, xg_event_is_for_menubar):
13473 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13474 (xg_set_widget_bg): New function.
13475 (delete_cb): New function.
895009e1 13476 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13477 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13478 (xg_set_background_color): Call xg_set_widget_bg.
13479 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13480 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13481 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13482 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13483 if ! HAVE_GTK3.
13484 (update_frame_tool_bar): Call gtk_widget_hide.
13485 (xg_initialize): Use GDK_KEY_g.
13486
13487 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13488 if ! HAVE_GTK3
13489 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13490
13491 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13492 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13493 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13494
1c2cc4ef
JB
134952011-03-08 Juanma Barranquero <lekktu@gmail.com>
13496
13497 * w32xfns.c (select_palette): Check success of RealizePalette against
13498 GDI_ERROR, not zero.
13499
33383987 13500See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13501
13502;; Local Variables:
13503;; coding: utf-8
aac0c6e3
MR
13504;; End:
13505
2f097256 13506 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13507
13508 This file is part of GNU Emacs.
13509
13510 GNU Emacs is free software: you can redistribute it and/or modify
13511 it under the terms of the GNU General Public License as published by
13512 the Free Software Foundation, either version 3 of the License, or
13513 (at your option) any later version.
13514
13515 GNU Emacs is distributed in the hope that it will be useful,
13516 but WITHOUT ANY WARRANTY; without even the implied warranty of
13517 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13518 GNU General Public License for more details.
13519
13520 You should have received a copy of the GNU General Public License
13521 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.