Commit | Line | Data |
---|---|---|
882f0d81 PE |
1 | 2011-06-20 Paul Eggert <eggert@cs.ucla.edu> |
2 | ||
171e2a58 PE |
3 | * termcap.c: Don't assume sizes fit in int and never overflow. |
4 | (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes. | |
5 | (gobble_line): Check for size-calculation overflow. | |
6 | ||
ad39faca | 7 | * minibuf.c (Fread_buffer): |
6e5bb2dc | 8 | * lread.c (intern, intern_c_string): |
74ca2eb3 PE |
9 | * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]: |
10 | Don't assume string length fits in int. | |
11 | ||
52c61c22 | 12 | * keyboard.c (parse_tool_bar_item): |
9bda3520 PE |
13 | * gtkutil.c (style_changed_cb): Avoid need for strlen. |
14 | ||
b5b8c9e5 PE |
15 | * font.c: Don't assume string length fits in int. |
16 | (font_parse_xlfd, font_parse_fcname, font_unparse_fcname): | |
17 | Use ptrdiff_t, not int. | |
ccd6111c PE |
18 | (font_intern_prop): Don't assume string length fits in int. |
19 | Don't assume integer property fits in fixnum. | |
20 | * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int. | |
b5b8c9e5 | 21 | |
882f0d81 PE |
22 | * filelock.c: Fix some buffer overrun and integer overflow issues. |
23 | (get_boot_time): Don't assume that gzip command string fits in 100 bytes. | |
24 | Reformulate so as not to need the command string. | |
25 | Invoke gzip -cd rather than gunzip, as it's more portable. | |
26 | (lock_info_type, lock_file_1, lock_file): | |
27 | Don't assume pid_t and time_t fit in unsigned long. | |
28 | (LOCK_PID_MAX): Remove; we now use more-reliable bounds. | |
29 | (current_lock_owner): Prefer signed type for sizes. | |
30 | Use memcpy, not strncpy, where memcpy is what is really wanted. | |
31 | Don't assume (via atoi) that time_t and pid_t fit in int. | |
32 | Check for time_t and/or pid_t out of range, e.g., via a network share. | |
33 | Don't alloca where an auto var works fine. | |
34 | ||
eb49b136 PE |
35 | 2011-06-19 Paul Eggert <eggert@cs.ucla.edu> |
36 | ||
93f4cf88 PE |
37 | * fileio.c: Fix some integer overflow issues. |
38 | (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name): | |
39 | Don't assume string length fits in int. | |
40 | (directory_file_name): Don't assume string length fits in long. | |
41 | (make_temp_name): Don't assume pid fits in int, or that its print | |
42 | length is less than 20. | |
43 | ||
f3e92b69 PE |
44 | * data.c (Fsubr_name): Rewrite to avoid a strlen call. |
45 | ||
1bfdaf10 PE |
46 | * coding.c (make_subsidiaries): Don't assume string length fits in int. |
47 | ||
35016e9a PE |
48 | * callproc.c (child_setup): Rewrite to avoid two strlen calls. |
49 | ||
3d1e65a1 PE |
50 | * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT. |
51 | We prefer signed integers, even for size calculations. | |
52 | ||
0b963a93 PE |
53 | * emacs.c: Don't assume string length fits in 'int'. |
54 | (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int. | |
55 | (main): Don't invoke strlen when not needed. | |
56 | ||
573f4b54 PE |
57 | * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string. |
58 | (XD_DEBUG_MESSAGE): Don't waste a byte. | |
59 | ||
989f33ba PE |
60 | * callproc.c (getenv_internal_1, getenv_internal) |
61 | (Fgetenv_internal): | |
965d34eb PE |
62 | * buffer.c (init_buffer): Don't assume string length fits in 'int'. |
63 | ||
e4d29b33 PE |
64 | * lread.c (invalid_syntax): Omit length argument. |
65 | All uses changed. This doesn't fix a bug, but it simplifies the | |
66 | code away from its former Hollerith-constant appearance, and it's | |
67 | one less 'int' to worry about when looking at integer-overflow issues. | |
f14ed477 | 68 | (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1. |
e4d29b33 | 69 | |
eb49b136 PE |
70 | * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr). |
71 | This didn't break anything, but it didn't help either. | |
72 | It's confusing to put a bogus integer in a place where the actual | |
73 | value does not matter. | |
9f62aeb1 | 74 | (LIST_END_P): Remove unused macro and its bogus comment. |
cbeff735 | 75 | (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT. |
eb49b136 | 76 | |
e39e811e PE |
77 | 2011-06-18 Paul Eggert <eggert@cs.ucla.edu> |
78 | ||
15375a22 PE |
79 | * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT. |
80 | This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE, | |
81 | implementation. | |
b61cc01c PE |
82 | (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT. |
83 | We prefer signed types, and the value cannot exceed the EMACS_INT | |
84 | range anyway (because otherwise the length would not be representable). | |
9a8e8d9b PE |
85 | (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t, |
86 | not EMACS_UINT and EMACS_INT, when converting pointer to integer. | |
87 | This avoids a GCC warning when WIDE_EMACS_INT. | |
15375a22 | 88 | |
53b2623d PE |
89 | * indent.c (sane_tab_width): New function. |
90 | (current_column, scan_for_column, Findent_to, position_indentation) | |
91 | (compute_motion): Use it. This is just for clarity. | |
8fcaf9cc | 92 | (Fcompute_motion): Don't assume hscroll and tab offset fit in int. |
53b2623d | 93 | |
45aebb64 PE |
94 | * image.c (xbm_image_p): Don't assume stated width and height fit in int. |
95 | ||
f2ed8a70 PE |
96 | * lisp.h (lint_assume): New macro. |
97 | * composite.c (composition_gstring_put_cache): | |
98 | * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0. | |
99 | ||
abe80cc6 PE |
100 | * editfns.c, insdel.c: |
101 | Omit unnecessary forward decls, to simplify future changes. | |
a9e860e1 | 102 | |
b02c740e PE |
103 | * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths. |
104 | ||
ebc96716 PE |
105 | * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'. |
106 | ||
b4e50fa0 | 107 | * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'. |
f03dc6ef | 108 | Use much-faster test for byte-length change. |
311d5d7c | 109 | Don't assume string byte-length fits in 'int'. |
a4cf38e4 | 110 | Check that character arg fits in 'int'. |
85461888 | 111 | (mapcar1): Declare byte as byte, for clarity. |
b4e50fa0 | 112 | |
c0c1ee9f PE |
113 | * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication. |
114 | ||
a498d7f4 PE |
115 | * fns.c (concat): Catch string overflow earlier. |
116 | Do not rely on integer wraparound. | |
117 | ||
e39e811e PE |
118 | * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int. |
119 | ||
fadf4e30 PE |
120 | 2011-06-17 Paul Eggert <eggert@cs.ucla.edu> |
121 | ||
87830974 PE |
122 | * dispextern.h (struct it.selective): Now EMACS_INT, not int. |
123 | * xdisp.c (forward_to_next_line_start) | |
124 | (back_to_previous_visible_line_start) | |
125 | (reseat_at_next_visible_line_start, next_element_from_buffer): | |
126 | Don't arbitrarily truncate the value of 'selective' to int. | |
127 | ||
76031fad PE |
128 | * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0. |
129 | ||
5eb55db9 PE |
130 | * composite.c: Don't truncate sizes to 'int'. |
131 | (composition_gstring_p, composition_reseat_it) | |
132 | (composition_adjust_point): Use EMACS_INT, not int. | |
7d100a81 PE |
133 | (get_composition_id, composition_gstring_put_cache): Use EMACS_INT, |
134 | not EMACS_UINT, for indexes. | |
5eb55db9 | 135 | |
0703a717 PE |
136 | * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT. |
137 | ||
d6202519 PE |
138 | * buffer.c: Include <verify.h>. |
139 | (struct sortvec.priority, struct sortstr.priority): | |
8961a454 | 140 | Now EMACS_INT, not int. |
c20998a7 | 141 | (compare_overlays, cmp_for_strings): Avoid subtraction overflow. |
67c36fce PE |
142 | (struct sortstr.size, record_overlay_string) |
143 | (struct sortstrlist.size, struct sortlist.used): | |
144 | Don't truncate size to int. | |
145 | (record_overlay_string): Check for size-calculation overflow. | |
d6202519 | 146 | (init_buffer_once): Check at compile-time, not run-time. |
fadf4e30 | 147 | |
28177add PE |
148 | 2011-06-16 Paul Eggert <eggert@cs.ucla.edu> |
149 | ||
dd3482fe PE |
150 | * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX. |
151 | Without this, prin1 mishandles Lisp_Misc_Save_Value printing on | |
152 | hosts with pre-C99 libraries, because pD is wrongly defined to "t". | |
153 | ||
393d71f3 | 154 | Improve buffer-overflow checking (Bug#8873). |
1c8e352f PE |
155 | * fileio.c (Finsert_file_contents): |
156 | * insdel.c (insert_from_buffer_1, replace_range, replace_range_2): | |
157 | Remove the old (too-loose) buffer overflow checks. | |
158 | They weren't needed, since make_gap checks for buffer overflow. | |
159 | * insdel.c (make_gap_larger): Catch buffer overflows that were missed. | |
160 | The old code merely checked for Emacs fixnum overflow, and relied | |
161 | on undefined (wraparound) behavior. The new code avoids undefined | |
162 | behavior, and also checks for ptrdiff_t and/or size_t overflow. | |
163 | ||
2e6813b0 | 164 | * editfns.c (Finsert_char): Don't dump core with very negative counts. |
21d890a4 PE |
165 | Tune. Don't use wider integers than needed. Don't use alloca. |
166 | Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test. | |
2e6813b0 | 167 | |
599a9e4f PE |
168 | * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing. |
169 | ||
99561444 PE |
170 | * insdel.c, lisp.h (buffer_overflow): New function. |
171 | (insert_from_buffer_1, replace_range, replace_range_2): | |
172 | * insdel.c (make_gap_larger): | |
173 | * editfns.c (Finsert_char): | |
174 | * fileio.c (Finsert_file_contents): Use it, to normalize wording. | |
175 | ||
28177add PE |
176 | * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed. |
177 | ||
e69dafad PE |
178 | 2011-06-15 Paul Eggert <eggert@cs.ucla.edu> |
179 | ||
a7af7fde | 180 | Integer overflow and signedness fixes (Bug#8873). |
ff672d2c | 181 | |
b1c46f02 PE |
182 | * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772. |
183 | (GET_CCL_RANGE, IN_INT_RANGE): Use it. | |
184 | ||
e69dafad PE |
185 | * fileio.c: Don't assume EMACS_INT fits in off_t. |
186 | (emacs_lseek): New static function. | |
187 | (Finsert_file_contents, Fwrite_region): Use it. | |
188 | Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate. | |
189 | ||
566684ea PE |
190 | * fns.c (Fload_average): Don't assume 100 * load average fits in int. |
191 | ||
e6966cd6 PE |
192 | * fns.c: Don't overflow int when computing a list length. |
193 | * fns.c (QUIT_COUNT_HEURISTIC): New constant. | |
194 | (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted | |
195 | truncation on 64-bit hosts. Check for QUIT every | |
196 | QUIT_COUNT_HEURISTIC entries rather than every other entry; that's | |
197 | faster and is responsive enough. | |
198 | (Flength): Report an error instead of overflowing an integer. | |
199 | (Fsafe_length): Return a float if the value is not representable | |
200 | as a fixnum. This shouldn't happen except in contrived situations. | |
6346d301 | 201 | (Fnthcdr, Fsort): Don't assume list length fits in int. |
de41a810 | 202 | (Fcopy_sequence): Don't assume vector length fits in int. |
00c604f2 | 203 | |
dd0b0efb PE |
204 | * alloc.c: Check that resized vectors' lengths fit in fixnums. |
205 | (header_size, word_size): New constants. | |
206 | (allocate_vectorlike): Don't check size overflow here. | |
207 | (allocate_vector): Check it here instead, since this is the only | |
208 | caller of allocate_vectorlike that could cause overflow. | |
209 | Check that the new vector's length is representable as a fixnum. | |
210 | ||
86fe5cfe PE |
211 | * fns.c (next_almost_prime): Don't return a multiple of 3 or 5. |
212 | The previous code was bogus. For example, next_almost_prime (32) | |
213 | returned 39, which is undesirable as it is a multiple of 3; and | |
214 | next_almost_prime (24) returned 25, which is a multiple of 5 so | |
215 | why was the code bothering to check for multiples of 7? | |
216 | ||
80e88859 PE |
217 | * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length. |
218 | ||
4a2f0ad6 PE |
219 | * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now. |
220 | ||
f66c7cf8 PE |
221 | Variadic C functions now count arguments with ptrdiff_t. |
222 | This partly undoes my 2011-03-30 change, which replaced int with size_t. | |
223 | Back then I didn't know that the Emacs coding style prefers signed int. | |
224 | Also, in the meantime I found a few more instances where arguments | |
4a2f0ad6 PE |
225 | were being counted with int, which may truncate counts on 64-bit |
226 | machines, or EMACS_INT, which may be unnecessarily wide. | |
f66c7cf8 PE |
227 | * lisp.h (struct Lisp_Subr.function.aMANY) |
228 | (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): | |
229 | Arg counts are now ptrdiff_t, not size_t. | |
230 | All variadic functions and their callers changed accordingly. | |
231 | (struct gcpro.nvars): Now size_t, not size_t. All uses changed. | |
232 | * bytecode.c (exec_byte_code): Check maxdepth for overflow, | |
233 | to avoid potential buffer overrun. Don't assume arg counts fit in 'int'. | |
234 | * callint.c (Fcall_interactively): Check arg count for overflow, | |
235 | to avoid potential buffer overrun. Use signed char, not 'int', | |
236 | for 'varies' array, so that we needn't bother to check its size | |
237 | calculation for overflow. | |
238 | * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args. | |
239 | * eval.c (apply_lambda): | |
240 | * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length. | |
241 | (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed. | |
242 | (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args. | |
243 | ||
a1759b76 PE |
244 | * callint.c (Fcall_interactively): Don't use index var as event count. |
245 | ||
d96be9fc PE |
246 | * vm-limit.c (check_memory_limits): Fix incorrect extern function decls. |
247 | * mem-limits.h (SIZE): Remove; no longer used. | |
248 | ||
a690a978 | 249 | * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works. |
5efd304b | 250 | |
578c21e6 PE |
251 | Remove unnecessary casts. |
252 | * xterm.c (x_term_init): | |
253 | * xfns.c (x_set_border_pixel): | |
254 | * widget.c (create_frame_gcs): Remove casts to unsigned long etc. | |
255 | These aren't needed now that we assume ANSI C. | |
256 | ||
96f53c6c PE |
257 | * sound.c (Fplay_sound_internal): Remove cast to unsigned long. |
258 | It's more likely to cause problems (due to unsigned overflow) | |
259 | than to cure them. | |
260 | ||
83c77d31 PE |
261 | * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts. |
262 | ||
ee2079f1 PE |
263 | * unexelf.c (unexec): Don't assume BSS addr fits in unsigned. |
264 | ||
6da65536 PE |
265 | * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned. |
266 | ||
7147c4a4 PE |
267 | * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX. |
268 | ||
193e32d9 PE |
269 | * lisp.h (CHAR_TABLE_SET): Omit now-redundant test. |
270 | ||
e5533da6 PE |
271 | * lread.c (Fload): Don't compare a possibly-garbage time_t value. |
272 | ||
9910e595 PE |
273 | GLYPH_CODE_FACE returns EMACS_INT, not int. |
274 | * dispextern.h (merge_faces): | |
275 | * xfaces.c (merge_faces): | |
01103c44 PE |
276 | * xdisp.c (get_next_display_element, next_element_from_display_vector): |
277 | Don't assume EMACS_INT fits in int. | |
9910e595 | 278 | |
2638320e PE |
279 | * character.h (CHAR_VALID_P): Remove unused parameter. |
280 | * fontset.c, lisp.h, xdisp.c: All uses changed. | |
281 | ||
045eb8d9 PE |
282 | * editfns.c (Ftranslate_region_internal): Omit redundant test. |
283 | ||
c1f134b5 PE |
284 | * fns.c (concat): Minor tuning based on overflow analysis. |
285 | This doesn't fix any bugs. Use int to hold character, instead | |
286 | of constantly refetching from Emacs object. Use XFASTINT, not | |
287 | XINT, for value known to be a character. Don't bother comparing | |
288 | a single byte to 0400, as it's always less. | |
289 | ||
395fcb93 | 290 | * floatfns.c (Fexpt): |
327eeec8 PE |
291 | * fileio.c (make_temp_name): Omit unnecessary cast to unsigned. |
292 | ||
abbd3d23 PE |
293 | * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT |
294 | for characters. | |
295 | ||
684a03ef PE |
296 | * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives. |
297 | ||
0fed43f3 PE |
298 | * data.c (Faset): If ARRAY is a string, check that NEWELT is a char. |
299 | Without this fix, on a 64-bit host (aset S 0 4294967386) would | |
300 | incorrectly succeed when S was a string, because 4294967386 was | |
301 | truncated before it was used. | |
302 | ||
8fd02eb7 PE |
303 | * chartab.c (Fchar_table_range): Use CHARACTERP to check range. |
304 | Otherwise, an out-of-range integer could cause undefined behavior | |
305 | on a 64-bit host. | |
306 | ||
f8c86b69 PE |
307 | * composite.c: Use int, not EMACS_INT, for characters. |
308 | (fill_gstring_body, composition_compute_stop_pos): Use int, not | |
309 | EMACS_INT, for values that are known to be in character range. | |
310 | This doesn't fix any bugs but is the usual style inside Emacs and | |
311 | may generate better code on 32-bit machines. | |
312 | ||
34206dd2 PE |
313 | Make sure a 64-bit char is never passed to ENCODE_CHAR. |
314 | This is for reasons similar to the recent CHAR_STRING fix. | |
315 | * charset.c (Fencode_char): Check that character arg is actually | |
316 | a character. Pass an int to ENCODE_CHAR. | |
317 | * charset.h (ENCODE_CHAR): Verify that the character argument is no | |
318 | wider than 'int', as a compile-time check to prevent future regressions | |
319 | in this area. | |
320 | ||
c5958d4c | 321 | * character.c (char_string): Remove unnecessary casts. |
13bdea59 PE |
322 | |
323 | Make sure a 64-bit char is never passed to CHAR_STRING. | |
324 | Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform, | |
325 | by silently ignoring the top 32 bits, allowing some values | |
326 | that were far too large to be valid characters. | |
327 | * character.h: Include <verify.h>. | |
328 | (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character | |
329 | arguments are no wider than unsigned, as a compile-time check | |
330 | to prevent future regressions in this area. | |
331 | * data.c (Faset): | |
01103c44 | 332 | * editfns.c (Fchar_to_string, general_insert_function, Finsert_char) |
13bdea59 PE |
333 | (Fsubst_char_in_region): |
334 | * fns.c (concat): | |
335 | * xdisp.c (decode_mode_spec_coding): | |
336 | Adjust to CHAR_STRING's new requirement. | |
337 | * editfns.c (Finsert_char, Fsubst_char_in_region): | |
338 | * fns.c (concat): Check that character args are actually | |
339 | characters. Without this test, these functions did the wrong | |
340 | thing with wildly out-of-range values on 64-bit hosts. | |
341 | ||
d37ca623 PE |
342 | Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts. |
343 | These casts should not be needed on 32-bit hosts, either. | |
344 | * keyboard.c (read_char): | |
345 | * lread.c (Fload): Remove casts to unsigned. | |
346 | ||
ea204efb PE |
347 | * lisp.h (UNSIGNED_CMP): New macro. |
348 | This fixes comparison bugs on 64-bit hosts. | |
349 | (ASCII_CHAR_P): Use it. | |
350 | * casefiddle.c (casify_object): | |
01103c44 | 351 | * character.h (ASCII_BYTE_P, CHAR_VALID_P) |
ea204efb PE |
352 | (SINGLE_BYTE_CHAR_P, CHAR_STRING): |
353 | * composite.h (COMPOSITION_ENCODE_RULE_VALID): | |
354 | * dispextern.h (FACE_FROM_ID): | |
355 | * keyboard.c (read_char): Use UNSIGNED_CMP. | |
356 | ||
41cb286c PE |
357 | * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t, |
358 | not to EMACS_INT, to avoid GCC warning. | |
359 | ||
4a1b9832 PE |
360 | * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals. |
361 | ||
55daad71 PE |
362 | * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast. |
363 | The cast incorrectly truncated 64-bit byte offsets to 32 bits, and | |
364 | isn't needed on 32-bit machines. | |
8f95c75c | 365 | |
01103c44 PE |
366 | * buffer.c (Fgenerate_new_buffer_name): |
367 | Use EMACS_INT for count, not int. | |
0ceccced | 368 | (advance_to_char_boundary): Return EMACS_INT, not int. |
e762cafe PE |
369 | |
370 | * data.c (Qcompiled_function): Now static. | |
371 | ||
c6f072e7 PE |
372 | * window.c (window_body_lines): Now static. |
373 | ||
20ce5912 PE |
374 | * image.c (gif_load): Rename local to avoid shadowing. |
375 | ||
9c4c5f81 PE |
376 | * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow. |
377 | (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member. | |
378 | * alloc.c (make_save_value): Integer argument is now of type | |
379 | ptrdiff_t, not int. | |
380 | (mark_object): Use ptrdiff_t, not int. | |
381 | * lisp.h (pD): New macro. | |
382 | * print.c (print_object): Use it. | |
383 | ||
c0c5c8ae PE |
384 | * alloc.c: Use EMACS_INT, not int, to count objects. |
385 | (total_conses, total_markers, total_symbols, total_vector_size) | |
386 | (total_free_conses, total_free_markers, total_free_symbols) | |
01103c44 PE |
387 | (total_free_floats, total_floats, total_free_intervals) |
388 | (total_intervals, total_strings, total_free_strings): | |
c0c5c8ae PE |
389 | Now EMACS_INT, not int. All uses changed. |
390 | (Fgarbage_collect): Compute overall total using a double, so that | |
391 | integer overflow is less likely to be a problem. Check for overflow | |
392 | when converting back to an integer. | |
5a25e253 PE |
393 | (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks) |
394 | (n_vectors, n_symbol_blocks, n_marker_blocks): Remove. | |
395 | These were 'int' variables that could overflow on 64-bit hosts; | |
396 | they were never used, so remove them instead of repairing them. | |
211a0b2a | 397 | (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'. |
6349ae4d PE |
398 | (inhibit_garbage_collection): Set gc_cons_threshold to max value. |
399 | Previously, this ceilinged at INT_MAX, but that doesn't work on | |
400 | 64-bit machines. | |
e46bb31a | 401 | (allocate_pseudovector): Don't use EMACS_INT when int would do. |
c0c5c8ae | 402 | |
c78baabf | 403 | * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int. |
86f61a15 | 404 | (allocate_vectorlike): Check for ptrdiff_t overflow. |
b6439961 PE |
405 | (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT |
406 | when a (possibly-narrower) signed value would do just as well. | |
407 | We prefer using signed arithmetic, to avoid comparison confusion. | |
c78baabf | 408 | |
c9d624c6 PE |
409 | * alloc.c: Catch some string size overflows that we were missing. |
410 | (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0, | |
411 | for convenience in STRING_BYTES_MAX. | |
412 | (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h. | |
413 | The definition here is exact; the one in lisp.h was approximate. | |
414 | (allocate_string_data): Check for string overflow. This catches | |
415 | some instances we weren't catching before. Also, it catches | |
416 | size_t overflow on (unusual) hosts where SIZE_MAX <= min | |
417 | (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits | |
418 | and ptrdiff_t and EMACS_INT are both 64 bits. | |
c78baabf | 419 | |
c9d624c6 PE |
420 | * character.c, coding.c, doprnt.c, editfns.c, eval.c: |
421 | All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND. | |
422 | * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX. | |
423 | ||
353032ce PE |
424 | * character.c (string_escape_byte8): Fix nbytes/nchars typo. |
425 | ||
2bccce07 PE |
426 | * alloc.c (Fmake_string): Check for out-of-range init. |
427 | ||
0ac30604 SM |
428 | 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca> |
429 | ||
430 | * eval.c (Fdefvaralias): Also mark the target as variable-special-p. | |
431 | ||
c195f2de JD |
432 | 2011-06-14 Jan Djärv <jan.h.d@swipnet.se> |
433 | ||
434 | * xfns.c (x_set_scroll_bar_default_width): Remove argument to | |
435 | xg_get_default_scrollbar_width. | |
436 | ||
437 | * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3. | |
438 | (int_gtk_range_get_value): Move to the scroll bar part of the file. | |
439 | (style_changed_cb): Call update_theme_scrollbar_width and call | |
440 | x_set_scroll_bar_default_width and xg_frame_set_char_size for | |
441 | all frames (Bug#8505). | |
442 | (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505). | |
443 | Call gtk_window_set_resizable if HAVE_GTK3. | |
444 | (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width | |
445 | and height if HAVE_GTK3 (Bug#8505). | |
446 | (scroll_bar_width_for_theme): New variable. | |
447 | (update_theme_scrollbar_width): New function. | |
448 | (xg_get_default_scrollbar_width): Move code to | |
449 | update_theme_scrollbar_width, just return scroll_bar_width_for_theme. | |
450 | (xg_initialize): Call update_theme_scrollbar_width. | |
451 | ||
452 | * gtkutil.h (xg_get_default_scrollbar_width): Remove argument. | |
453 | ||
454 | * emacsgtkfixed.c, emacsgtkfixed.h: New files. | |
455 | ||
e10ac9f1 MR |
456 | 2011-06-12 Martin Rudalics <rudalics@gmx.at> |
457 | ||
458 | * frame.c (make_frame): Call other_buffer_safely instead of | |
459 | other_buffer. | |
460 | ||
461 | * window.c (temp_output_buffer_show): Call display_buffer with | |
462 | second argument Vtemp_buffer_show_specifiers and reset latter | |
463 | immediately after the call. | |
464 | (Vtemp_buffer_show_specifiers): New variable. | |
465 | (auto_window_vscroll_p, next_screen_context_lines) | |
466 | (Vscroll_preserve_screen_position): Remove leading asterisks from | |
467 | doc-strings. | |
468 | ||
2d3c217e | 469 | 2011-06-12 Paul Eggert <eggert@cs.ucla.edu> |
4475bec4 | 470 | |
7b7f97e8 | 471 | Fix minor problems found by GCC 4.6.0 static checking. |
4475bec4 PE |
472 | * buffer.c (Qclone_number): Remove for now, as it's unused. |
473 | (record_buffer, Funrecord_buffer): Rename local to avoid shadowing. | |
474 | (record_buffer): Remove unused local. | |
475 | * frame.c (other_visible_frames, frame_buffer_list): Now static. | |
476 | (set_frame_buffer_list): Remove; unused. | |
477 | * frame.h (other_visible_frames): Remove decl. | |
478 | * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF. | |
479 | * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls. | |
480 | (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only | |
481 | if HAVE_GPM. | |
482 | * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF. | |
483 | * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): | |
484 | Define only if HAVE_GPM. | |
485 | * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static. | |
486 | (update_hints_inhibit): Remove; never set. All uses removed. | |
487 | * widgetprv.h (emacsFrameClassRec): Remove decl. | |
488 | * window.c (delete_deletable_window): Now returns void, since it | |
489 | wasn't returning anything. | |
490 | (compare_window_configurations): Remove unused locals. | |
491 | * xfns.c (x_set_scroll_bar_default_width): Remove unused locals. | |
492 | * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF. | |
4475bec4 PE |
493 | (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers |
494 | the same widths as pointers. This follows up on the 2011-05-06 patch. | |
495 | * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID. | |
496 | * xterm.h: Likewise. | |
497 | (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF. | |
498 | ||
1384b89e JB |
499 | 2011-06-12 Juanma Barranquero <lekktu@gmail.com> |
500 | ||
501 | * makefile.w32-in: Update dependencies. | |
502 | (LISP_H): Add lib/intprops.h. | |
503 | ||
1100a63c CY |
504 | 2011-06-11 Chong Yidong <cyd@stupidchicken.com> |
505 | ||
506 | * image.c (gif_load): Add animation frame delay to the metadata. | |
507 | (syms_of_image): Use DEFSYM. New symbol `delay'. | |
508 | ||
6198ccd0 MR |
509 | 2011-06-11 Martin Rudalics <rudalics@gmx.at> |
510 | ||
511 | * window.c (delete_deletable_window): Re-add. | |
512 | (Fset_window_configuration): Rewrite to handle dead buffers and | |
513 | consequently deletable windows. | |
514 | (window_tree, Fwindow_tree): Remove. Supply functionality in | |
515 | window.el. | |
516 | (compare_window_configurations): Simplify code. | |
517 | ||
b6e3633c AS |
518 | 2011-06-11 Andreas Schwab <schwab@linux-m68k.org> |
519 | ||
1ab0dee5 AS |
520 | * image.c (imagemagick_load_image): Fix type mismatch. |
521 | (Fimagemagick_types): Likewise. | |
522 | ||
b6e3633c AS |
523 | * window.h (replace_buffer_in_windows): Declare. |
524 | ||
9397e56f MR |
525 | 2011-06-11 Martin Rudalics <rudalics@gmx.at> |
526 | ||
527 | * buffer.c: New Lisp objects Qbuffer_list_update_hook and | |
528 | Qclone_number. Remove external declaration of Qdelete_window. | |
529 | (Fbuffer_list): Rewrite doc-string. Minor restructuring of | |
530 | code. | |
531 | (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run | |
532 | Qbuffer_list_update_hook if allowed. | |
533 | (Fother_buffer): Rewrite doc-string. Major rewrite for new | |
534 | buffer list implementation. | |
535 | (other_buffer_safely): New function. | |
536 | (Fkill_buffer): Replace call to replace_buffer_in_all_windows by | |
537 | calls to replace_buffer_in_windows and | |
538 | replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook | |
539 | if allowed. | |
540 | (record_buffer): Inhibit quitting and rewrite using quittable | |
541 | functions. Run Qbuffer_list_update_hook if allowed. | |
542 | (Frecord_buffer, Funrecord_buffer): New functions. | |
543 | (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move | |
544 | switch-to-buffer to window.el. | |
545 | (bury-buffer): Move to window.el. | |
546 | (Vbuffer_list_update_hook): New variable. | |
547 | ||
548 | * lisp.h (other_buffer_safely): Add prototype in buffer.c | |
549 | section. | |
550 | ||
551 | * window.h (resize_frame_windows): Move up in code. | |
552 | (Fwindow_frame): Remove EXFUN. | |
553 | (replace_buffer_in_all_windows): Remove prototype. | |
554 | (replace_buffer_in_windows_safely): Add prototype. | |
555 | ||
556 | * window.c: Declare Qdelete_window static again. Move down | |
557 | declaration of select_count. | |
558 | (Fnext_window, Fprevious_window): Rewrite doc-strings. | |
559 | (Fother_window): Move to window.el. | |
560 | (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER | |
561 | cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case. | |
562 | (Fdelete_windows_on, Freplace_buffer_in_windows): Move to | |
563 | window.el. | |
564 | (replace_buffer_in_windows): Implement by calling | |
565 | Qreplace_buffer_in_windows. | |
566 | (replace_buffer_in_all_windows): Remove with some functionality | |
567 | moved into replace_buffer_in_windows_safely. | |
568 | (replace_buffer_in_windows_safely): New function. | |
569 | (select_window_norecord, select_frame_norecord): Move in front | |
570 | of run_window_configuration_change_hook. Remove now obsolete | |
571 | declarations. | |
572 | (Fset_window_buffer): Rewrite doc-string. Call | |
573 | Qrecord_window_buffer. | |
574 | (keys_of_window): Move binding for other-window to window.el. | |
575 | ||
b50691aa CY |
576 | 2011-06-11 Chong Yidong <cyd@stupidchicken.com> |
577 | ||
578 | * dispextern.h (struct image): Replace data member, whose int_val | |
579 | and ptr_val fields were not used by anything, with a single | |
580 | lisp_val object. | |
581 | ||
582 | * image.c (Fimage_metadata, make_image, mark_image, tiff_load) | |
583 | (gif_clear_image, gif_load, imagemagick_load_image) | |
584 | (gs_clear_image, gs_load): Callers changed. | |
585 | ||
3f754b86 PE |
586 | 2011-06-10 Paul Eggert <eggert@cs.ucla.edu> |
587 | ||
cca69397 PE |
588 | * buffer.h: Include <time.h>, for time_t. |
589 | Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra. | |
590 | ||
109e28d0 PE |
591 | Fix minor problems found by static checking. |
592 | ||
60737f02 PE |
593 | * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't. |
594 | ||
4b66faf3 PE |
595 | Make identifiers static if they are not used in other modules. |
596 | * data.c (Qcompiled_function, Qframe, Qvector): | |
597 | * image.c (QimageMagick, Qsvg): | |
598 | * minibuf.c (Qmetadata): | |
599 | * window.c (resize_window_check, resize_root_window): Now static. | |
600 | * window.h (resize_window_check, resize_root_window): Remove decls. | |
601 | ||
109e28d0 PE |
602 | * window.c (window_deletion_count, delete_deletable_window): |
603 | Remove; unused. | |
46a4ce9e PE |
604 | (window_body_lines): Now static. |
605 | (Fdelete_other_windows_internal): Mark vars as initialized. | |
606 | Make sure 'resize_failed' is initialized. | |
607 | (run_window_configuration_change_hook): Rename local to avoid shadowing. | |
608 | (resize_window_apply): Remove unused local. | |
609 | * window.h (delete_deletable_window): Remove decl. | |
610 | ||
109e28d0 | 611 | * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing. |
33290528 PE |
612 | (imagemagick_load_image): Fix pointer signedness problem by changing |
613 | last arg from unsigned char * to char *. All uses changed. | |
614 | Also, fix a local for similar reasons. | |
615 | Remove unused locals. Remove locals to avoid shadowing. | |
616 | (fn_rsvg_handle_free): Remove; unused. | |
617 | (svg_load, svg_load_image): Fix pointer signedness problem. | |
f7e13da3 | 618 | (imagemagick_load_image): Don't use garbage pointer image_wand. |
33290528 | 619 | |
3f754b86 PE |
620 | * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals. |
621 | ||
2547adb1 CY |
622 | 2011-06-10 Chong Yidong <cyd@stupidchicken.com> |
623 | ||
624 | * image.c (gif_load): Fix omitted cast error introduced by | |
625 | 2011-06-06 change. | |
626 | ||
2c8e37d4 MR |
627 | 2011-06-10 Martin Rudalics <rudalics@gmx.at> |
628 | ||
629 | * window.h (resize_proportionally, orig_total_lines) | |
630 | (orig_top_line): Remove from window structure. | |
631 | (set_window_height, set_window_width, change_window_heights) | |
632 | (Fdelete_window): Remove prototypes. | |
633 | (resize_frame_windows): Remove duplicate declaration. | |
634 | ||
440a42e3 EZ |
635 | 2011-06-10 Eli Zaretskii <eliz@gnu.org> |
636 | ||
637 | * window.h (resize_frame_windows, resize_window_check) | |
638 | (delete_deletable_window, resize_root_window) | |
639 | (resize_frame_windows): Declare prototypes. | |
640 | ||
641 | * window.c (resize_window_apply): Make definition be "static" to | |
642 | match the prototype. | |
643 | ||
562dd5e9 MR |
644 | 2011-06-10 Martin Rudalics <rudalics@gmx.at> |
645 | ||
646 | * window.c: Remove declarations of Qwindow_size_fixed, | |
647 | window_min_size_1, window_min_size_2, window_min_size, | |
648 | size_window, window_fixed_size_p, enlarge_window, delete_window. | |
649 | Remove static from declaration of Qdelete_window, it's | |
650 | temporarily needed by Fbury_buffer. | |
651 | (replace_window): Don't assign orig_top_line and | |
652 | orig_total_lines. | |
653 | (Fdelete_window, delete_window): Remove. Window deletion is | |
654 | handled by window.el. | |
655 | (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace | |
656 | Fdelete_window calls with calls to Qdelete_window. | |
657 | (Fdelete_other_windows): Remove. Deleting other windows is | |
658 | handled by window.el. | |
659 | (window_fixed_size_p): Remove. Fixed-sizeness of windows is | |
660 | handled in window.el. | |
661 | (window_min_size_2, window_min_size_1, window_min_size): Remove. | |
662 | Window minimum sizes are handled in window.el. | |
663 | (shrink_windows, size_window, set_window_height) | |
664 | (set_window_width, change_window_heights, window_height) | |
665 | (window_width, CURBEG, CURSIZE, enlarge_window) | |
666 | (adjust_window_trailing_edge, Fadjust_window_trailing_edge) | |
667 | (Fenlarge_window, Fshrink_window): Remove. Window resizing is | |
668 | handled in window.el. | |
669 | (make_dummy_parent): Rename to make_parent_window and give it a | |
670 | second argument horflag. | |
671 | (make_window): Don't set resize_proportionally any more. | |
672 | (Fsplit_window): Remove. Windows are split in window.el. | |
673 | (save_restore_action, save_restore_orig_size) | |
674 | (shrink_window_lowest_first, save_restore_orig_size): Remove. | |
675 | Resize mini windows in window.el. | |
676 | (grow_mini_window, shrink_mini_window): Implement by calling | |
677 | Qresize_root_window_vertically, resize_window_check and | |
678 | resize_window_apply. | |
679 | (saved_window, Fset_window_configuration, save_window_save): Do | |
680 | not handle orig_top_line, orig_total_lines, and | |
681 | resize_proportionally. | |
682 | (window_min_height, window_min_width): Move to window.el. | |
683 | (keys_of_window): Move bindings for delete-other-windows, | |
684 | split-window, delete-window and enlarge-window to window.el. | |
685 | ||
686 | * buffer.c: Temporarily extern Qdelete_window. | |
687 | (Fbury_buffer): Temporarily call Qdelete_window instead of | |
688 | Fdelete_window (Fbury_buffer will move to window.el soon). | |
689 | ||
690 | * frame.c (set_menu_bar_lines_1): Remove code handling | |
691 | orig_top_line and orig_total_lines. | |
692 | ||
693 | * dispnew.c (adjust_frame_glyphs_initially): Don't use | |
694 | set_window_height but set heights directly. | |
695 | (change_frame_size_1): Use resize_frame_windows. | |
696 | ||
697 | * xdisp.c (init_xdisp): Don't use set_window_height but set | |
698 | heights directly. | |
699 | ||
700 | * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use | |
701 | resize_frame_windows instead of change_window_heights and run | |
702 | run_window_configuration_change_hook. | |
703 | ||
704 | * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows | |
705 | instead of change_window_heights and run | |
706 | run_window_configuration_change_hook. | |
707 | ||
1a13852e MR |
708 | 2011-06-09 Martin Rudalics <rudalics@gmx.at> |
709 | ||
710 | * window.c (replace_window): Rename second argument REPLACEMENT to | |
711 | NEW. New third argument SETFLAG. Rewrite. | |
712 | (delete_window, make_dummy_parent): Call replace_window with | |
713 | third argument 1. | |
714 | (window_list_1): Move down in code. | |
715 | (run_window_configuration_change_hook): Move set_buffer part | |
716 | before select_frame_norecord part in order to unwind correctly. | |
717 | Rename count1 to count. | |
718 | (recombine_windows, delete_deletable_window, resize_root_window) | |
719 | (Fdelete_other_windows_internal) | |
720 | (Frun_window_configuration_change_hook, make_parent_window) | |
721 | (resize_window_check, resize_window_apply, Fresize_window_apply) | |
722 | (resize_frame_windows, Fsplit_window_internal) | |
723 | (Fdelete_window_internal, Fresize_mini_window_internal): New | |
724 | functions. | |
725 | (syms_of_window): New variables Vwindow_splits and Vwindow_nest. | |
726 | ||
f3d1777e MR |
727 | 2011-06-08 Martin Rudalics <rudalics@gmx.at> |
728 | ||
496e208e MR |
729 | * window.h (window): Add some new members to window structure - |
730 | normal_lines, normal_cols, new_total, new_normal, clone_number, | |
731 | splits, nest, prev_buffers, next_buffers. | |
732 | (WINDOW_TOTAL_SIZE): Move here from window.c. | |
b9e809c2 | 733 | (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here. |
496e208e | 734 | |
f3d1777e MR |
735 | * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p): |
736 | Remove. | |
496e208e MR |
737 | (make_dummy_parent): Set new members of windows structure. |
738 | (make_window): Move down in code. Handle new members of window | |
739 | structure. | |
740 | (Fwindow_clone_number, Fwindow_splits, Fset_window_splits) | |
741 | (Fwindow_nest, Fset_window_nest, Fwindow_new_total) | |
742 | (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers) | |
743 | (Fset_window_prev_buffers, Fwindow_next_buffers) | |
744 | (Fset_window_next_buffers, Fset_window_clone_number): New | |
745 | functions. | |
746 | (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start) | |
747 | (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p): | |
748 | Doc-string fixes. | |
749 | (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter): | |
750 | Argument WINDOW can be now internal window too. | |
751 | (Fwindow_use_time): Move up in code. | |
752 | (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES. | |
753 | Rewrite doc-string. | |
754 | (Fset_window_configuration, saved_window) | |
755 | (Fcurrent_window_configuration, save_window_save): Handle new | |
756 | members of window structure. | |
b9e809c2 MR |
757 | (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH) |
758 | (MIN_SAFE_WINDOW_HEIGHT): Move to window.h. | |
759 | (syms_of_window): New Lisp objects Qrecord_window_buffer, | |
760 | Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows, | |
761 | Qget_mru_window, Qresize_root_window, | |
762 | Qresize_root_window_vertically, Qsafe, Qabove, Qbelow, | |
763 | Qauto_buffer_name; staticpro them. | |
f3d1777e | 764 | |
abde8f8c MR |
765 | 2011-06-07 Martin Rudalics <rudalics@gmx.at> |
766 | ||
767 | * window.c (Fwindow_total_size, Fwindow_left_column) | |
768 | (Fwindow_top_line, window_body_lines, Fwindow_body_size) | |
769 | (Fwindow_list_1): New functions. | |
770 | (window_box_text_cols): Replace with window_body_cols. | |
771 | (Fwindow_width, Fscroll_left, Fscroll_right): Use | |
772 | window_body_cols instead of window_box_text_cols. | |
fa8a67e6 MR |
773 | (delete_window, Fset_window_configuration): Call |
774 | delete_all_subwindows with window as argument. | |
775 | (delete_all_subwindows): Take a window as argument and not a | |
776 | structure. Rewrite. | |
190b47e6 MR |
777 | (window_loop): Remove handling of GET_LRU_WINDOW and |
778 | GET_LARGEST_WINDOW. | |
779 | (Fget_lru_window, Fget_largest_window): Move to window.el. | |
abde8f8c MR |
780 | |
781 | * window.h: Extern window_body_cols instead of | |
fa8a67e6 MR |
782 | window_box_text_cols. delete_all_subwindows now takes a |
783 | Lisp_Object as argument. | |
abde8f8c MR |
784 | |
785 | * indent.c (compute_motion, Fcompute_motion): Use | |
786 | window_body_cols instead of window_box_text_cols. | |
787 | ||
fa8a67e6 MR |
788 | * frame.c (delete_frame): Call delete_all_subwindows with root |
789 | window as argument. | |
790 | ||
a54e3482 DC |
791 | 2011-06-07 Daniel Colascione <dan.colascione@gmail.com> |
792 | ||
793 | * fns.c (Fputhash): Document return value. | |
794 | ||
60002bf5 CY |
795 | 2011-06-06 Chong Yidong <cyd@stupidchicken.com> |
796 | ||
797 | * image.c (gif_load): Implement gif89a spec "no disposal" method. | |
798 | ||
0c671da6 | 799 | 2011-06-06 Paul Eggert <eggert@cs.ucla.edu> |
ccd9a01a | 800 | |
b862a52a | 801 | Cons<->int and similar integer overflow fixes (Bug#8794). |
77984278 | 802 | |
be44ca6c PE |
803 | Check for overflow when converting integer to cons and back. |
804 | * charset.c (Fdefine_charset_internal, Fdecode_char): | |
805 | Use cons_to_unsigned to catch overflow. | |
806 | (Fencode_char): Use INTEGER_TO_CONS. | |
807 | * composite.h (LGLYPH_CODE): Use cons_to_unsigned. | |
808 | (LGLYPH_SET_CODE): Use INTEGER_TO_CONS. | |
809 | * data.c (long_to_cons, cons_to_long): Remove. | |
810 | (cons_to_unsigned, cons_to_signed): New functions. | |
811 | These signal an error for invalid or out-of-range values. | |
812 | * dired.c (Ffile_attributes): Use INTEGER_TO_CONS. | |
813 | * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER. | |
814 | * font.c (Ffont_variation_glyphs): | |
815 | * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS. | |
816 | * lisp.h: Include <intprops.h>. | |
817 | (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros. | |
818 | (cons_to_signed, cons_to_unsigned): New decls. | |
819 | (long_to_cons, cons_to_long): Remove decls. | |
820 | * undo.c (record_first_change): Use INTEGER_TO_CONS. | |
821 | (Fprimitive_undo): Use CONS_TO_INTEGER. | |
822 | * xfns.c (Fx_window_property): Likewise. | |
823 | * xselect.c: Include <limits.h>. | |
824 | (x_own_selection, selection_data_to_lisp_data): | |
825 | Use INTEGER_TO_CONS. | |
826 | (x_handle_selection_request, x_handle_selection_clear) | |
827 | (x_get_foreign_selection, Fx_disown_selection_internal) | |
828 | (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER. | |
829 | (lisp_data_to_selection_data): Use cons_to_unsigned. | |
830 | (x_fill_property_data): Use cons_to_signed. | |
831 | Report values out of range. | |
832 | ||
d1f3d2af PE |
833 | Check for buffer and string overflow more precisely. |
834 | * buffer.h (BUF_BYTES_MAX): New macro. | |
835 | * lisp.h (STRING_BYTES_MAX): New macro. | |
836 | * alloc.c (Fmake_string): | |
837 | * character.c (string_escape_byte8): | |
838 | * coding.c (coding_alloc_by_realloc): | |
839 | * doprnt.c (doprnt): | |
840 | * editfns.c (Fformat): | |
841 | * eval.c (verror): | |
842 | Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM, | |
843 | since they may not be the same number. | |
844 | * editfns.c (Finsert_char): | |
845 | * fileio.c (Finsert_file_contents): | |
846 | Likewise for BUF_BYTES_MAX. | |
847 | ||
dd52fcea PE |
848 | * image.c: Use ptrdiff_t, not int, for sizes. |
849 | (slurp_file): Switch from int to ptrdiff_t. | |
850 | All uses changed. | |
851 | (slurp_file): Check that file size fits in both size_t (for | |
852 | malloc) and ptrdiff_t (for sanity and safety). | |
853 | ||
7f9bbdbb PE |
854 | * fileio.c (Fverify_visited_file_modtime): Avoid time overflow |
855 | if b->modtime has its maximal value. | |
856 | ||
dfe18f82 PE |
857 | * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits. |
858 | ||
84acfcf0 PE |
859 | Don't assume time_t can fit into int. |
860 | * buffer.h (struct buffer.modtime): Now time_t, not int. | |
861 | * fileio.c (Fvisited_file_modtime): No need for time_t cast now. | |
862 | * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value. | |
863 | ||
ccd9a01a PE |
864 | Minor fixes for signed vs unsigned integers. |
865 | * character.h (MAYBE_UNIFY_CHAR): | |
866 | * charset.c (maybe_unify_char): | |
867 | * keyboard.c (read_char, reorder_modifiers): | |
868 | XINT -> XFASTINT, since the integer must be nonnegative. | |
869 | * ftfont.c (ftfont_spec_pattern): | |
870 | * keymap.c (access_keymap, silly_event_symbol_error): | |
871 | XUINT -> XFASTINT, since the integer must be nonnegative. | |
872 | (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT, | |
873 | since it makes no difference and we prefer signed. | |
874 | * keyboard.c (record_char): Use XUINT when all the neighbors do. | |
875 | (access_keymap): NATNUMP -> INTEGERP, since the integer must be | |
876 | nonnegative. | |
877 | ||
d6d100dd SM |
878 | 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca> |
879 | ||
880 | * window.h (Fwindow_frame): Declare. | |
881 | ||
2b6148e4 PE |
882 | 2011-06-06 Paul Eggert <eggert@cs.ucla.edu> |
883 | ||
884 | * alloc.c: Simplify handling of large-request failures (Bug#8800). | |
885 | (SPARE_MEMORY): Always define. | |
886 | (LARGE_REQUEST): Remove. | |
887 | (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST. | |
888 | ||
f230ecc9 MR |
889 | 2011-06-06 Martin Rudalics <rudalics@gmx.at> |
890 | ||
727e958e MR |
891 | * lisp.h: Move EXFUNS for Fframe_root_window, |
892 | Fframe_first_window and Fset_frame_selected_window to window.h. | |
893 | ||
894 | * window.h: Move EXFUNS for Fframe_root_window, | |
895 | Fframe_first_window and Fset_frame_selected_window here from | |
896 | lisp.h. | |
897 | ||
898 | * frame.c (Fwindow_frame, Fframe_first_window) | |
899 | (Fframe_root_window, Fframe_selected_window) | |
900 | (Fset_frame_selected_window): Move to window.c. | |
901 | (Factive_minibuffer_window): Move to minibuf.c. | |
902 | (Fother_visible_frames_p): New function. | |
903 | ||
904 | * minibuf.c (Factive_minibuffer_window): Move here from frame.c. | |
905 | ||
f230ecc9 MR |
906 | * window.c (decode_window, decode_any_window): Move up in code. |
907 | (Fwindowp, Fwindow_live_p): Rewrite doc-strings. | |
908 | (inhibit_frame_unsplittable): Remove unused variable. | |
bf60a96b MR |
909 | (Fwindow_buffer): Move up and rewrite doc-string. |
910 | (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next) | |
911 | (Fwindow_prev): New functions. | |
727e958e MR |
912 | (Fwindow_frame): Move here from frame.c. Accept any window as |
913 | argument. | |
914 | (Fframe_root_window, Fframe_first_window) | |
915 | (Fframe_selected_window): Move here from frame.c. Accept frame | |
916 | or arbitrary window as argument. Update doc-strings. | |
917 | (Fminibuffer_window): Move up in code. | |
918 | (Fwindow_minibuffer_p): Move up in code and simplify. | |
d6d100dd SM |
919 | (Fset_frame_selected_window): Move here from frame.c. |
920 | Marginal rewrite. | |
727e958e MR |
921 | (Fselected_window, select_window, Fselect_window): Move up in |
922 | code. Minor doc-string fixes. | |
f230ecc9 | 923 | |
4d09bcf6 PE |
924 | 2011-06-06 Paul Eggert <eggert@cs.ucla.edu> |
925 | ||
926 | * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800). | |
927 | Do not assume that spare memory exists; that assumption is valid | |
928 | only if SYSTEM_MALLOC. | |
929 | (LARGE_REQUEST): New macro, so that the issue of large requests | |
930 | is separated from the issue of spare memory. | |
931 | ||
810928a2 AS |
932 | 2011-06-05 Andreas Schwab <schwab@linux-m68k.org> |
933 | ||
172418ad AS |
934 | * editfns.c (Fformat): Correctly handle zero flag with hexadecimal |
935 | format. (Bug#8806) | |
936 | ||
43f862f7 AS |
937 | * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning. |
938 | ||
810928a2 AS |
939 | * xfns.c (x_set_scroll_bar_default_width): Move declarations |
940 | before statements. | |
941 | ||
a059fe24 JD |
942 | 2011-06-05 Jan Djärv <jan.h.d@swipnet.se> |
943 | ||
944 | * gtkutil.c (xg_get_default_scrollbar_width): New function. | |
945 | ||
946 | * gtkutil.h: Declare xg_get_default_scrollbar_width. | |
947 | ||
948 | * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get | |
949 | min width by calling x_set_scroll_bar_default_width (Bug#8505). | |
950 | ||
989bf368 JB |
951 | 2011-06-05 Juanma Barranquero <lekktu@gmail.com> |
952 | ||
953 | * xdisp.c (single_display_spec_intangible_p): Remove declaration. | |
954 | ||
4b80f674 CY |
955 | 2011-06-04 Chong Yidong <cyd@stupidchicken.com> |
956 | ||
957 | * xselect.c (x_clipboard_manager_save): Remove redundant arg. | |
958 | (x_clipboard_manager_save): Add return value. | |
d6d100dd SM |
959 | (x_clipboard_manager_error_1, x_clipboard_manager_error_2): |
960 | New error handlers. | |
4b80f674 CY |
961 | (x_clipboard_manager_save_frame, x_clipboard_manager_save_all): |
962 | Obey Vx_select_enable_clipboard_manager. Catch errors in | |
963 | x_clipboard_manager_save (Bug#8779). | |
964 | (Vx_select_enable_clipboard_manager): New variable. | |
de65b42c | 965 | (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790). |
4b80f674 | 966 | |
99a33b77 | 967 | 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu> |
8b3115e7 DN |
968 | |
969 | * emacs.c (main): Warn when starting a GTK emacs in daemon mode. | |
970 | ||
99a33b77 | 971 | 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
14eca62f YM |
972 | |
973 | * fringe.c (update_window_fringes): Don't update overlay arrow bitmap | |
974 | in the current matrix if keep_current_p is non-zero. | |
975 | ||
8264569d EZ |
976 | 2011-06-04 Eli Zaretskii <eliz@gnu.org> |
977 | ||
978 | * bidi.c (bidi_level_of_next_char): Fix last change. | |
979 | ||
57f97249 EZ |
980 | 2011-06-03 Eli Zaretskii <eliz@gnu.org> |
981 | ||
fec2107c | 982 | Support bidi reordering of text covered by display properties. |
57f97249 | 983 | |
fec2107c EZ |
984 | * bidi.c (bidi_copy_it): Use offsetof instead of emulating it. |
985 | (bidi_fetch_char, bidi_fetch_char_advance): New functions. | |
986 | (bidi_cache_search, bidi_cache_iterator_state) | |
987 | (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak) | |
d6d100dd SM |
988 | (bidi_level_of_next_char, bidi_move_to_visually_next): |
989 | Support character positions inside a run of characters covered by a | |
fec2107c EZ |
990 | display string. |
991 | (bidi_paragraph_init, bidi_resolve_explicit_1) | |
992 | (bidi_level_of_next_char): Call bidi_fetch_char and | |
993 | bidi_fetch_char_advance instead of FETCH_CHAR and | |
994 | FETCH_CHAR_ADVANCE. | |
995 | (bidi_init_it): Initialize new members. | |
996 | (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro | |
997 | definitions. | |
998 | (bidi_explicit_dir_char): Lookup character type in bidi_type_table, | |
999 | instead of using explicit *_CHAR codes. | |
d6d100dd SM |
1000 | (bidi_resolve_explicit, bidi_resolve_weak): |
1001 | Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of | |
fec2107c EZ |
1002 | bidirectional text is supported only in multibyte buffers. |
1003 | (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use | |
1004 | it to initialize the frame_window_p member of struct bidi_it. | |
1005 | (bidi_cache_iterator_state, bidi_resolve_explicit_1) | |
1006 | (bidi_resolve_explicit, bidi_resolve_weak) | |
1007 | (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if | |
1008 | bidi_it->nchars is non-positive. | |
1009 | (bidi_level_of_next_char): Don't try to lookup the cache for the | |
1010 | next/previous character if nothing is cached there yet, or if we | |
1011 | were just reseat()'ed to a new position. | |
c40e2fb2 | 1012 | |
0e14fe90 EZ |
1013 | * xdisp.c (set_cursor_from_row): Set start and stop points |
1014 | according to the row's direction when priming the loop that looks | |
1015 | for the glyph on which to display cursor. | |
1016 | (single_display_spec_intangible_p): Function deleted. | |
1017 | (display_prop_intangible_p): Reimplement to call | |
1018 | handle_display_spec instead of single_display_spec_intangible_p. | |
d6d100dd SM |
1019 | Accept 3 additional arguments needed by handle_display_spec. |
1020 | This fixes incorrect cursor motion across display property with complex | |
0e14fe90 EZ |
1021 | values: lists, `(when COND...)' forms, etc. |
1022 | (single_display_spec_string_p): Support property values that are | |
1023 | lists with the argument STRING its top-level element. | |
1024 | (display_prop_string_p): Fix the condition for processing a | |
1025 | property that is a list to be consistent with handle_display_spec. | |
fec2107c | 1026 | (handle_display_spec): New function, refactored from the |
fc6f18ce EZ |
1027 | last portion of handle_display_prop. |
1028 | (compute_display_string_pos): Accept additional argument | |
1029 | FRAME_WINDOW_P. Call handle_display_spec to determine whether the | |
1030 | value of a `display' property is a "replacing spec". | |
1031 | (handle_single_display_spec): Accept 2 additional arguments BUFPOS | |
1032 | and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from | |
1033 | the display property, but just return a value indicating whether | |
1034 | the display property will replace the characters it covers. | |
1035 | (Fcurrent_bidi_paragraph_direction): Initialize the nchars and | |
1036 | frame_window_p members of struct bidi_it. | |
d6d100dd SM |
1037 | (compute_display_string_pos, compute_display_string_end): |
1038 | New functions. | |
fec2107c EZ |
1039 | (push_it): Accept second argument POSITION, where pop_it should |
1040 | jump to continue iteration. | |
1041 | (reseat_1): Initialize bidi_it.disp_pos. | |
fc6f18ce | 1042 | |
fec2107c EZ |
1043 | * keyboard.c (adjust_point_for_property): Adjust the call to |
1044 | display_prop_intangible_p to its new signature. | |
fc6f18ce EZ |
1045 | |
1046 | * dispextern.h (struct bidi_it): New member frame_window_p. | |
fec2107c EZ |
1047 | (bidi_init_it): Update prototypes. |
1048 | (display_prop_intangible_p): Update prototype. | |
d6d100dd SM |
1049 | (compute_display_string_pos, compute_display_string_end): |
1050 | Declare prototypes. | |
fec2107c EZ |
1051 | (struct bidi_it): New members nchars and disp_pos. ch_len is now |
1052 | EMACS_INT. | |
fc6f18ce | 1053 | |
40087514 | 1054 | 2011-06-02 Paul Eggert <eggert@cs.ucla.edu> |
0de4bb68 | 1055 | |
57f53182 PE |
1056 | Malloc failure behavior now depends on size of allocation. |
1057 | * alloc.c (buffer_memory_full, memory_full): New arg NBYTES. | |
1058 | * lisp.h: Change signatures accordingly. | |
1059 | * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c: | |
1060 | All callers changed. (Bug#8762) | |
1061 | ||
1062 | * gnutls.c: Use Emacs's memory allocators. | |
1063 | Without this change, the gnutls library would invoke malloc etc. | |
1064 | directly, which causes problems on non-SYNC_INPUT hosts, and which | |
1065 | runs afoul of improving memory_full behavior. (Bug#8761) | |
1066 | (fn_gnutls_global_set_mem_functions): New macro or function pointer. | |
1067 | (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc, | |
1068 | xfree instead of the default malloc, realloc, free. | |
1069 | (Fgnutls_boot): No need to check for memory allocation failure, | |
1070 | since xmalloc does that for us. | |
1071 | ||
ac32cd99 | 1072 | Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771) |
3870d916 PE |
1073 | * category.c (hash_get_category_set): |
1074 | * ccl.c (ccl_driver): | |
1075 | * charset.c (Fdefine_charset_internal): | |
1076 | * charset.h (struct charset.hash_index): | |
1077 | * composite.c (get_composition_id, gstring_lookup_cache) | |
1078 | (composition_gstring_put_cache): | |
1079 | * composite.h (struct composition.hash_index): | |
1080 | * dispextern.h (struct image.hash): | |
1081 | * fns.c (next_almost_prime, larger_vector, cmpfn_eql) | |
1082 | (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql) | |
1083 | (hashfn_equal, hashfn_user_defined, make_hash_table) | |
1084 | (maybe_resize_hash_table, hash_lookup, hash_put) | |
1085 | (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE) | |
1086 | (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector) | |
1087 | (Fsxhash, Fgethash, Fputhash, Fmaphash): | |
1088 | * image.c (make_image, search_image_cache, lookup_image) | |
1089 | (xpm_put_color_table_h): | |
1090 | * lisp.h (struct Lisp_Hash_Table): | |
0de4bb68 | 1091 | * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion): |
3870d916 PE |
1092 | * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT' |
1093 | for hashes and hash indexes, instead of 'unsigned' and 'int'. | |
40087514 PE |
1094 | * alloc.c (allocate_vectorlike): |
1095 | Check for overflow in vector size calculations. | |
1096 | * ccl.c (ccl_driver): | |
1097 | Check for overflow when converting EMACS_INT to int. | |
0de4bb68 PE |
1098 | * fns.c, image.c: Remove unnecessary static decls that would otherwise |
1099 | need to be updated by these changes. | |
40087514 PE |
1100 | * fns.c (make_hash_table, maybe_resize_hash_table): |
1101 | Check for integer overflow with large hash tables. | |
0de4bb68 PE |
1102 | (make_hash_table, maybe_resize_hash_table, Fmake_hash_table): |
1103 | Prefer the faster XFLOAT_DATA to XFLOATINT where either will do. | |
1104 | (SXHASH_REDUCE): New macro. | |
1105 | (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector): | |
1106 | Use it instead of discarding useful hash info with large hash values. | |
1107 | (sxhash_float): New function. | |
1108 | (sxhash): Use it. No more need for "& INTMASK" due to above changes. | |
1109 | * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc. | |
40087514 PE |
1110 | (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK): |
1111 | Rewrite to use FIXNUM_BITS, as this simplifies things. | |
0de4bb68 PE |
1112 | (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put): |
1113 | Adjust signatures to match updated version of code. | |
1114 | (consing_since_gc): Now EMACS_INT, since a single hash table can | |
1115 | use more than INT_MAX bytes. | |
1116 | ||
698d32e2 DN |
1117 | 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu> |
1118 | ||
1119 | Make it possible to build with GCC-4.6+ -O2 -flto. | |
1120 | ||
1121 | * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE. | |
1122 | ||
fd6fa53f SM |
1123 | 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca> |
1124 | ||
1125 | * minibuf.c (get_minibuffer, read_minibuf_unwind): | |
1126 | Call minibuffer-inactive-mode. | |
1127 | ||
864db017 JB |
1128 | 2011-05-31 Juanma Barranquero <lekktu@gmail.com> |
1129 | ||
1130 | * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)): | |
1131 | Update dependencies. | |
1132 | ||
2ad0baf4 DN |
1133 | 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu> |
1134 | ||
1135 | * data.c (init_data): Remove code for UTS, this system is not | |
1136 | supported anymore. | |
1137 | ||
4fcc2638 DN |
1138 | 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu> |
1139 | ||
1140 | Don't force ./temacs to start in terminal mode. | |
1141 | ||
1142 | * frame.c (make_initial_frame): Initialize faces in all cases, not | |
1143 | only when CANNOT_DUMP is defined. | |
1144 | * dispnew.c (init_display): Remove CANNOT_DUMP condition. | |
1145 | ||
c56e0fd5 DN |
1146 | 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu> |
1147 | ||
1148 | * dispnew.c (add_window_display_history): Use const for the string | |
1149 | pointer. Remove declaration, not needed. | |
1150 | ||
333d54da | 1151 | 2011-05-31 Paul Eggert <eggert@cs.ucla.edu> |
9cf9f756 | 1152 | |
55d4c1b2 | 1153 | Use 'inline', not 'INLINE'. |
333d54da | 1154 | <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html> |
55d4c1b2 PE |
1155 | * alloc.c, fontset.c (INLINE): Remove. |
1156 | * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c: | |
1157 | * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c: | |
1158 | * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline. | |
1159 | * gmalloc.c (register_heapinfo): Use inline unconditionally. | |
1160 | * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__. | |
1161 | ||
738db178 DN |
1162 | 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu> |
1163 | ||
1164 | Make it possible to run ./temacs. | |
1165 | ||
1166 | * callproc.c (set_initial_environment): Remove CANNOT_DUMP code, | |
1167 | syms_of_callproc does the same thing. Remove test for | |
1168 | "initialized", do it in the caller. | |
1169 | * emacs.c (main): Avoid calling set_initial_environment when dumping. | |
1170 | ||
620c53a6 SM |
1171 | 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca> |
1172 | ||
1173 | * minibuf.c (Finternal_complete_buffer): Return `category' metadata. | |
1174 | (read_minibuf): Use get_minibuffer. | |
1175 | (syms_of_minibuf): Use DEFSYM. | |
1176 | (Qmetadata): New var. | |
1177 | * data.c (Qbuffer): Don't make it static. | |
1178 | (syms_of_data): Use DEFSYM. | |
1179 | ||
e003a292 PE |
1180 | 2011-05-31 Paul Eggert <eggert@cs.ucla.edu> |
1181 | ||
1182 | * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751) | |
1183 | (CCL_CODE_MIN): New macro. | |
1184 | ||
ed008a6d PE |
1185 | 2011-05-30 Paul Eggert <eggert@cs.ucla.edu> |
1186 | ||
3687c2ef PE |
1187 | * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests. |
1188 | ||
ed008a6d PE |
1189 | * eval.c (Qdebug): Now static. |
1190 | * lisp.h (Qdebug): Remove decl. This reverts a part of the | |
1191 | 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of | |
1192 | 2011-04-14T06:48:41Z!eggert@cs.ucla.edu. | |
1193 | ||
d66c4c7c CY |
1194 | 2011-05-29 Chong Yidong <cyd@stupidchicken.com> |
1195 | ||
1196 | * image.c: Various fixes to ImageMagick code comments. | |
1197 | (Fimagemagick_types): Doc fix. | |
1198 | ||
5fbc2025 PE |
1199 | 2011-05-29 Paul Eggert <eggert@cs.ucla.edu> |
1200 | ||
0196f88a PE |
1201 | Minor fixes prompted by GCC 4.6.0 warnings. |
1202 | ||
1203 | * xselect.c (converted_selections, conversion_fail_tag): Now static. | |
1204 | ||
5fbc2025 PE |
1205 | * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h". |
1206 | (x_clipboard_manager_save_all): Move extern decl to ... | |
1207 | * xterm.h: ... here, so that it can be checked for consistency. | |
1208 | ||
1dd3c2d9 CY |
1209 | 2011-05-29 Chong Yidong <cyd@stupidchicken.com> |
1210 | ||
1211 | * xselect.c (x_clipboard_manager_save_frame) | |
1212 | (x_clipboard_manager_save_all): New functions. | |
1213 | (Fx_clipboard_manager_save): Lisp function deleted. | |
1214 | ||
1215 | * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all. | |
1216 | * frame.c (delete_frame): Call x_clipboard_manager_save_frame. | |
1217 | ||
1218 | * xterm.h: Update prototype. | |
1219 | ||
5ba6571d WX |
1220 | 2011-05-28 William Xu <william.xwl@gmail.com> |
1221 | ||
1222 | * nsterm.m (ns_term_shutdown): Synchronize user defaults before | |
1223 | exiting (Bug#8239). | |
1224 | ||
3eaff834 JM |
1225 | 2011-05-28 Jim Meyering <meyering@redhat.com> |
1226 | ||
e1900994 | 1227 | Avoid a sign-extension bug in crypto_hash_function. |
3eaff834 JM |
1228 | * fns.c (to_uchar): Define. |
1229 | (crypto_hash_function): Use it to convert some newly-signed | |
1230 | variables to unsigned, to avoid sign-extension bugs. For example, | |
1231 | without this change, (md5 "truc") would evaluate to | |
1232 | 45723a2aff78ff4fff7fff1114760e62 rather than the expected | |
1233 | 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in | |
e1900994 | 1234 | https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html. |
3eaff834 | 1235 | |
0f6990a7 PE |
1236 | 2011-05-27 Paul Eggert <eggert@cs.ucla.edu> |
1237 | ||
1238 | Integer overflow fixes. | |
c8a9ca5a | 1239 | |
08686060 PE |
1240 | * dbusbind.c: Serial number integer overflow fixes. |
1241 | (CHECK_DBUS_SERIAL_GET_SERIAL): New macro. | |
08686060 PE |
1242 | (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float |
1243 | to hold a serial number that is too large for a fixnum. | |
1244 | (Fdbus_method_return_internal, Fdbus_method_error_internal): | |
1245 | Check for serial numbers out of range. Decode any serial number | |
59568bf0 | 1246 | that was so large that it became a float. (Bug#8722) |
08686060 | 1247 | |
2d1fc3c7 PE |
1248 | * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg. |
1249 | (Fdbus_call_method, Fdbus_call_method_asynchronously): | |
1250 | Use XFASTINT rather than XUINT when numbers are nonnegative. | |
1251 | (xd_append_arg, Fdbus_method_return_internal): | |
1252 | (Fdbus_method_error_internal): Likewise. Also, for unsigned | |
1253 | arguments, check that Lisp number is nonnegative, rather than | |
59568bf0 | 1254 | silently wrapping negative numbers around. (Bug#8722) |
30217ff0 | 1255 | (xd_read_message_1): Don't assume dbus_uint32_t can fit in int. |
59568bf0 | 1256 | (Bug#8722) |
2d1fc3c7 | 1257 | |
c8a9ca5a PE |
1258 | * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT. |
1259 | ||
519e1d69 PE |
1260 | * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'. |
1261 | ||
30569699 PE |
1262 | ccl: add integer overflow checks |
1263 | * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT): | |
1264 | (IN_INT_RANGE): New macros. | |
1265 | (ccl_driver): Use them to check for integer overflow when | |
1266 | decoding a CCL program. Many of the new checks are whether XINT (x) | |
1267 | fits in int; it doesn't always, on 64-bit hosts. The new version | |
1268 | doesn't catch all possible integer overflows, but it's an | |
847044ea | 1269 | improvement. (Bug#8719) |
30569699 | 1270 | |
c11285dc PE |
1271 | * alloc.c (make_event_array): Use XINT, not XUINT. |
1272 | There's no need for unsigned here. | |
1273 | ||
fdccd48e PE |
1274 | * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t |
1275 | This follows up to the 2011-05-06 change that substituted uintptr_t | |
1276 | for EMACS_INT. This case wasn't caught back then. | |
1277 | ||
37910ab2 PE |
1278 | Rework Fformat to avoid integer overflow issues. |
1279 | * editfns.c: Include <float.h> unconditionally, as it's everywhere | |
1280 | now (part of C89). Include <verify.h>. | |
1281 | (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed. | |
1282 | (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns. | |
1283 | (Fformat): Avoid the prepass trying to compute sizes; it was only | |
1284 | approximate and thus did not catch overflow reliably. Instead, walk | |
1285 | through the format just once, formatting and computing sizes as we go, | |
1286 | checking for integer overflow at every step, and allocating a larger | |
1287 | buffer as needed. Keep track separately whether the format is | |
1288 | multibyte. Keep only the most-recently calculated precision, rather | |
1289 | than them all. Record whether each argument has been converted to | |
1290 | string. Use EMACS_INT, not int, for byte and char and arg counts. | |
1291 | Support field widths and precisions larger than INT_MAX. Avoid | |
1292 | sprintf's undefined behavior with conversion specifications such as %#d | |
1293 | and %.0c. Fix bug with strchr succeeding on '\0' when looking for | |
1294 | flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when | |
1295 | formatting out-of-range floating point numbers with int | |
1296 | formats. (Bug#8668) | |
1297 | ||
2e6578fb PE |
1298 | * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN. |
1299 | ||
0ae6bdee PE |
1300 | * data.c: Avoid integer truncation in expressions involving floats. |
1301 | * data.c: Include <intprops.h>. | |
1302 | (arith_driver): When there's an integer overflow in an expression | |
1303 | involving floating point, convert the integers to floating point | |
1304 | so that the resulting value does not suffer from catastrophic | |
1305 | integer truncation. For example, on a 64-bit host (* 4 | |
1306 | most-negative-fixnum 0.5) should yield about -4.6e+18, not zero. | |
1307 | Do not rely on undefined behavior after integer overflow. | |
1308 | ||
de883a70 PE |
1309 | merge count_size_as_multibyte, parse_str_to_multibyte |
1310 | * character.c, character.h (count_size_as_multibyte): | |
fd6fa53f | 1311 | Rename from parse_str_to_multibyte; all uses changed. |
de883a70 PE |
1312 | Check for integer overflow. |
1313 | * insdel.c, lisp.h (count_size_as_multibyte): Remove, | |
1314 | since it's now a duplicate of the other. This is more of | |
1315 | a character than a buffer op, so better that it's in character.c. | |
1316 | * fns.c, print.c: Adjust to above changes. | |
1317 | ||
2ff916cb PE |
1318 | 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca> |
1319 | ||
1320 | * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup. | |
1321 | ||
f1b54466 PE |
1322 | 2011-05-27 Paul Eggert <eggert@cs.ucla.edu> |
1323 | ||
fb1ac845 PE |
1324 | * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings. |
1325 | (x_handle_selection_request, frame_for_x_selection): Remove unused vars. | |
1326 | (x_clipboard_manager_save): Now static. | |
1327 | (Fx_clipboard_manager_save): Rename local to avoid shadowing. | |
1328 | ||
f1b54466 PE |
1329 | * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings. |
1330 | (crypto_hash_function): Now static. | |
1331 | Fix pointer signedness problems. Avoid unnecessary initializations. | |
1332 | ||
a9f737ee CY |
1333 | 2011-05-27 Chong Yidong <cyd@stupidchicken.com> |
1334 | ||
1335 | * termhooks.h (Vselection_alist): Make it terminal-local. | |
1336 | ||
1337 | * terminal.c (create_terminal): Initialize it. | |
1338 | ||
1339 | * xselect.c: Support for clipboard managers. | |
1340 | (Vselection_alist): Move to termhooks.h as terminal-local var. | |
1341 | (LOCAL_SELECTION): New macro. | |
1342 | (x_atom_to_symbol): Handle x_display_info_for_display fail case. | |
1343 | (symbol_to_x_atom): Remove gratuitous arg. | |
1344 | (x_handle_selection_request, lisp_data_to_selection_data) | |
1345 | (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed. | |
620c53a6 SM |
1346 | (x_own_selection, x_get_local_selection, x_convert_selection): |
1347 | New arg, specifying work frame. Use terminal-local Vselection_alist. | |
a9f737ee CY |
1348 | (some_frame_on_display): Delete unused function. |
1349 | (Fx_own_selection_internal, Fx_get_selection_internal) | |
1350 | (Fx_disown_selection_internal, Fx_selection_owner_p) | |
1351 | (Fx_selection_exists_p): New optional frame arg. | |
1352 | (frame_for_x_selection, Fx_clipboard_manager_save): New functions. | |
1353 | (x_handle_selection_clear): Don't treat other terminals with the | |
1354 | same keyboard specially. Use the terminal-local Vselection_alist. | |
1355 | (x_clear_frame_selections): Use Frun_hook_with_args. | |
1356 | ||
1357 | * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms. | |
1358 | ||
1359 | * xterm.h: Add support for those atoms. | |
1360 | ||
e067f0c1 CY |
1361 | 2011-05-26 Chong Yidong <cyd@stupidchicken.com> |
1362 | ||
1363 | * xselect.c: ICCCM-compliant handling of MULTIPLE targets. | |
1364 | (converted_selections, conversion_fail_tag): New global variables. | |
1365 | (x_selection_request_lisp_error): Free the above. | |
1366 | (x_get_local_selection): Remove unnecessary code. | |
1367 | (x_reply_selection_request): Args changed; handle arbitrary array | |
620c53a6 SM |
1368 | of converted selections stored in converted_selections. |
1369 | Separate the XChangeProperty and SelectionNotify steps. | |
e067f0c1 CY |
1370 | (x_handle_selection_request): Rewrite to handle MULTIPLE target. |
1371 | (x_convert_selection): New function. | |
1372 | (x_handle_selection_event): Simplify. | |
1373 | (x_get_foreign_selection): Don't ignore incoming requests while | |
1374 | waiting for an answer; this will fail when we implement | |
1375 | SAVE_TARGETS, and seems unnecessary anyway. | |
1376 | (selection_data_to_lisp_data): Recognize ATOM_PAIR type. | |
1377 | (Vx_sent_selection_functions): Doc fix. | |
1378 | ||
0f4aebc0 LL |
1379 | 2011-05-26 Leo Liu <sdl.web@gmail.com> |
1380 | ||
1381 | * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699) | |
1382 | ||
e61124cd YM |
1383 | 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
1384 | ||
1385 | * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p. | |
1386 | ||
1387 | * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row | |
1388 | for fringe update if it has periodic bitmap. | |
1389 | (row_equal_p): Also compare left_fringe_offset, right_fringe_offset, | |
1390 | and fringe_bitmap_periodic_p. | |
1391 | ||
1392 | * fringe.c (get_fringe_bitmap_data): New function. | |
1393 | (draw_fringe_bitmap_1, update_window_fringes): Use it. | |
1394 | (update_window_fringes): Record periodicity of fringe bitmap in glyph | |
1395 | row. Mark glyph row for fringe update if periodicity changed. | |
1396 | ||
1397 | * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row | |
1398 | for fringe update unless it has periodic bitmap. | |
1399 | ||
f16d9837 KH |
1400 | 2011-05-25 Kenichi Handa <handa@m17n.org> |
1401 | ||
1402 | * xdisp.c (get_next_display_element): Set correct it->face_id for | |
1403 | a static composition. | |
1404 | ||
e1b90ef6 LL |
1405 | 2011-05-24 Leo Liu <sdl.web@gmail.com> |
1406 | ||
1407 | * deps.mk (fns.o): | |
1408 | * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h. | |
1409 | ||
1410 | * fns.c (crypto_hash_function, Fsha1): New function. | |
1411 | (Fmd5): Use crypto_hash_function. | |
1412 | (syms_of_fns): Add Ssha1. | |
1413 | ||
7400048f PE |
1414 | 2011-05-22 Paul Eggert <eggert@cs.ucla.edu> |
1415 | ||
1416 | * gnutls.c: Remove unused macros. | |
1417 | (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function): | |
1418 | (fn_gnutls_transport_set_push_function) [!WINDOWSNT]: | |
1419 | Remove macros that are defined and never used. | |
1420 | Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14). | |
1421 | ||
abb71cf4 CY |
1422 | 2011-05-22 Chong Yidong <cyd@stupidchicken.com> |
1423 | ||
1424 | * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS. | |
1425 | (Fx_get_selection_internal): Minor cleanup. | |
1426 | (Fx_own_selection_internal): Rename arguments for consistency with | |
1427 | select.el. | |
1428 | ||
6307db39 PE |
1429 | 2011-05-22 Paul Eggert <eggert@cs.ucla.edu> |
1430 | ||
1431 | * xselect.c (QSAVE_TARGETS): New static var, to fix build failure. | |
1432 | ||
f3d4e0a4 CY |
1433 | 2011-05-22 Chong Yidong <cyd@stupidchicken.com> |
1434 | ||
1435 | * xselect.c (syms_of_xselect): Include character.h; use DEFSYM. | |
1436 | ||
4d8ade89 YM |
1437 | 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
1438 | ||
1439 | * dispnew.c (scrolling_window): Don't exclude the case that the | |
1440 | last enabled row in the desired matrix touches the bottom boundary. | |
1441 | ||
32078c8d GM |
1442 | 2011-05-21 Glenn Morris <rgm@gnu.org> |
1443 | ||
1444 | * Makefile.in ($(etc)/DOC): Make second command line even shorter. | |
33cf345f GM |
1445 | (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion, |
1446 | and add some more files. | |
32078c8d | 1447 | |
7285dc67 EZ |
1448 | 2011-05-20 Eli Zaretskii <eliz@gnu.org> |
1449 | ||
1450 | * callproc.c (Fcall_process) [MSDOS]: Fix arguments to | |
1451 | report_file_error introduced by the change from 2011-05-07. | |
1452 | ||
89d1bd22 PE |
1453 | 2011-05-20 Paul Eggert <eggert@cs.ucla.edu> |
1454 | ||
1455 | * systime.h (Time): Define only if emacs is defined. | |
1456 | This is to allow ../lib-src/profile.c to be compiled on FreeBSD, | |
1457 | where the include path doesn't have X11/X.h by default. See | |
1458 | <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>. | |
1459 | ||
e23640bb | 1460 | 2011-05-20 Kenichi Handa <handa@m17n.org> |
31bfc35c KH |
1461 | |
1462 | * composite.c (find_automatic_composition): Fix previous change. | |
1463 | ||
b9704ad9 GM |
1464 | 2011-05-20 Glenn Morris <rgm@gnu.org> |
1465 | ||
1466 | * lisp.mk: New file, split from Makefile.in. | |
1467 | * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@. | |
1468 | (shortlisp): Remove. | |
1469 | ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp. | |
1470 | ||
4a720484 GM |
1471 | 2011-05-19 Glenn Morris <rgm@gnu.org> |
1472 | ||
1473 | * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT) | |
1474 | (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT) | |
1475 | (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove. | |
1476 | (lisp): Set the order to that of loadup.el. | |
1477 | (shortlisp): Make it a copy of $lisp. | |
1478 | (SOME_MACHINE_LISP): Remove. | |
1479 | ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too. | |
1480 | Use just $shortlisp, not $SOME_MACHINE_LISP too. | |
1481 | ||
a28d4396 KH |
1482 | 2011-05-18 Kenichi Handa <handa@m17n.org> |
1483 | ||
1484 | * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency. | |
1485 | (BACKWARD_CHAR): Wrap the arg STOP by parenthesis. | |
1486 | (find_automatic_composition): Mostly rewrite for efficiency. | |
1487 | ||
a2b1fa8e JB |
1488 | 2011-05-18 Juanma Barranquero <lekktu@gmail.com> |
1489 | ||
1490 | * makefile.w32-in: Update dependencies. | |
1491 | ||
8e1f5610 CS |
1492 | 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com> |
1493 | ||
1494 | * menu.c: Include limits.h (fixes the MS-Windows build broken by | |
fadf4e30 | 1495 | 2011-06-18T18:49:19Z!cyd@stupidchicken.com). |
8e1f5610 | 1496 | |
7025ee00 | 1497 | 2011-05-18 Paul Eggert <eggert@cs.ucla.edu> |
cb93f9be | 1498 | |
cdfa6eab PE |
1499 | Fix some integer overflow issues, such as string length overflow. |
1500 | ||
06d6db33 PE |
1501 | * insdel.c (count_size_as_multibyte): Check for string overflow. |
1502 | ||
2b4560a8 PE |
1503 | * character.c (lisp_string_width): Check for string overflow. |
1504 | Use EMACS_INT, not int, for string indexes and lengths; in | |
1505 | particular, 2nd arg is now EMACS_INT, not int. Do not crash if | |
1506 | the resulting string length overflows an EMACS_INT; instead, | |
1507 | report a string overflow if no precision given. When checking for | |
1508 | precision exhaustion, use a check that cannot possibly have | |
1509 | integer overflow. (Bug#8675) | |
1510 | * character.h (lisp_string_width): Adjust to new signature. | |
1511 | ||
cb93f9be PE |
1512 | * alloc.c (string_overflow): New function. |
1513 | (Fmake_string): Use it. This doesn't change behavior, but saves | |
1514 | a few bytes and will simplify future changes. | |
1515 | * character.c (string_escape_byte8): Likewise. | |
1516 | * lisp.h (string_overflow): New decl. | |
1517 | ||
1a1f3366 PE |
1518 | Fixups, following up to the user-interface timestamp change. |
1519 | * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time | |
1520 | for UI timestamps, instead of unsigned long. | |
9fbd6841 PE |
1521 | * msdos.c (mouse_get_pos): Likewise. |
1522 | * w32inevt.c (movement_time, w32_console_mouse_position): Likewise. | |
1a1f3366 PE |
1523 | * w32gui.h (Time): Define by including "systime.h" rather than by |
1524 | declaring it ourselves. (Bug#8664) | |
1525 | ||
d4e3e4d3 PE |
1526 | * dispextern.h (struct image): Don't assume time_t <= unsigned long. |
1527 | * image.c (clear_image_cache): Likewise. | |
1528 | ||
f6a24d19 PE |
1529 | * term.c (term_mouse_position): Don't assume time_t wraparound. |
1530 | ||
08dc5ae6 PE |
1531 | Be more systematic about user-interface timestamps. |
1532 | Before, the code sometimes used 'Time', sometimes 'unsigned long', | |
620c53a6 SM |
1533 | and sometimes 'EMACS_UINT', to represent these timestamps. |
1534 | This change causes it to use 'Time' uniformly, as that's what X uses. | |
08dc5ae6 PE |
1535 | This makes the code easier to follow, and makes it easier to catch |
1536 | integer overflow bugs such as Bug#8664. | |
1537 | * frame.c (Fmouse_position, Fmouse_pixel_position): | |
1538 | Use Time, not unsigned long, for user-interface timestamps. | |
1539 | * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise. | |
1540 | (button_down_time, make_lispy_position, make_lispy_movement): Likewise. | |
1541 | * keyboard.h (last_event_timestamp): Likewise. | |
1542 | * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise. | |
1543 | * menu.h (xmenu_show): Likewise. | |
1544 | * term.c (term_mouse_position): Likewise. | |
1545 | * termhooks.h (struct input_event.timestamp): Likewise. | |
1546 | (struct terminal.mouse_position_hook): Likewise. | |
1547 | * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise. | |
1548 | * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise. | |
1549 | * systime.h (Time): New decl. Pull it in from <X11/X.h> if | |
1550 | HAVE_X_WINDOWS, otherwise define it as unsigned long, which is | |
1551 | what it was before. | |
1552 | * menu.h, termhooks.h: Include "systime.h", for Time. | |
1553 | ||
8e55734a PE |
1554 | * keyboard.c (make_lispy_event): Fix problem in integer overflow. |
1555 | Don't assume that the difference between two unsigned long values | |
1556 | can fit into an integer. At this point, we know button_down_time | |
1557 | <= event->timestamp, so the difference must be nonnegative, so | |
1558 | there's no need to cast the result if double-click-time is | |
1559 | nonnegative, as it should be; check that it's nonnegative, just in | |
1560 | case. This bug is triggered when events are more than 2**31 ms | |
86db42d2 | 1561 | apart (about 25 days). (Bug#8664) |
8e55734a | 1562 | |
841f1b75 | 1563 | * xselect.c (last_event_timestamp): Remove duplicate decl. |
6434756c | 1564 | (x_own_selection): Remove needless cast to unsigned long. |
841f1b75 | 1565 | |
3e26f69c PE |
1566 | * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes |
1567 | that always fit in int. Use a sentinel instead of a counter, to | |
1568 | avoid a temp and to allay GCC's concerns about possible int overflow. | |
d230cb74 PE |
1569 | * frame.h (struct frame): Use int for menu_bar_items_used |
1570 | instead of EMACS_INT, since it always fits in int. | |
3e26f69c | 1571 | |
5cc152c0 PE |
1572 | * menu.c (grow_menu_items): Check for int overflow. |
1573 | ||
d89eb65e PE |
1574 | * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils. |
1575 | ||
5235bd3e PE |
1576 | * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers. |
1577 | Before, the code was not consistent. These values cannot exceed | |
1578 | 2**31 - 1 so there's no need to make them unsigned. | |
1579 | (x_x_to_emacs_modifiers): Accept int and return EMACS_INT. | |
1580 | (x_emacs_to_x_modifiers): Accept EMACS_INT and return int. | |
1581 | (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers | |
1582 | as modifiers. | |
1583 | * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change. | |
1584 | ||
bc827e23 PE |
1585 | * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT. |
1586 | (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT. | |
1587 | Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)), | |
1588 | presumably because the widths might not match. | |
1589 | ||
78eb494e PE |
1590 | * window.c (size_window): Avoid needless test at loop start. |
1591 | ||
04f2d78b CB |
1592 | 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change) |
1593 | ||
1594 | * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687). | |
1595 | ||
d2fc7e3d | 1596 | 2011-05-12 Drew Adams <drew.adams@oracle.com> |
e531bdff DA |
1597 | |
1598 | * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655). | |
1599 | ||
d2fc7e3d | 1600 | 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
7db47798 YM |
1601 | |
1602 | * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and | |
1603 | `width' to `bar_area_x' and `bar_area_width', respectively. | |
1604 | (x_scroll_run): Take account of fringe background extension. | |
1605 | ||
04f2d78b CB |
1606 | * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]: |
1607 | Rename local vars `left' and `width' to `bar_area_x' and | |
7db47798 YM |
1608 | `bar_area_width', respectively. |
1609 | (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe | |
1610 | background extension. | |
1611 | ||
79b70037 GM |
1612 | 2011-05-10 Jim Meyering <meyering@redhat.com> |
1613 | ||
1614 | * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the". | |
1615 | ||
2f142cc5 JB |
1616 | 2011-05-10 Juanma Barranquero <lekktu@gmail.com> |
1617 | ||
1618 | * image.c (Finit_image_library): Return t for built-in image types, | |
1619 | like pbm and xbm. (Bug#8640) | |
1620 | ||
57679c86 AS |
1621 | 2011-05-09 Andreas Schwab <schwab@linux-m68k.org> |
1622 | ||
1623 | * w32menu.c (set_frame_menubar): Fix submenu allocation. | |
1624 | ||
888c9e86 EZ |
1625 | 2011-05-07 Eli Zaretskii <eliz@gnu.org> |
1626 | ||
b0512a1d EZ |
1627 | * w32console.c (Fset_screen_color): Doc fix. |
1628 | (Fget_screen_color): New function. | |
1629 | (syms_of_ntterm): Defsubr it. | |
1630 | ||
7285dc67 EZ |
1631 | * callproc.c (call_process_cleanup) [MSDOS]: Don't close and |
1632 | unlink the temporary file if Fcall_process didn't create it in the | |
1633 | first place. | |
1634 | (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the | |
1635 | child process will be redirected to a file specified with `:file'. | |
888c9e86 EZ |
1636 | Don't try to re-open tempfile in that case, and set fd[0] to -1 as |
1637 | cue to call_process_cleanup not to close that handle. | |
1638 | ||
4d3fcc8e BK |
1639 | 2011-05-07 Ben Key <bkey76@gmail.com> |
1640 | ||
1641 | * makefile.w32-in: The bootstrap-temacs rule now makes use of | |
1642 | one of two shell specific rules, either bootstrap-temacs-CMD or | |
1643 | bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical | |
1644 | to the previous implementation of the bootstrap-temacs rule. | |
1645 | The bootstrap-temacs-CMD rule is similar to the previous | |
1646 | implementation of the bootstrap-temacs rule except that it | |
1647 | makes use of the ESC_CFLAGS variable instead of the CFLAGS | |
1648 | variable. | |
1649 | ||
1650 | These changes, along with some changes to nt/configure.bat, | |
1651 | nt/gmake.defs, and nt/nmake.defs, are required to extend my | |
1652 | earlier fix to add support for --cflags and --ldflags options | |
1653 | that include quotes so that it works whether make uses cmd or | |
1654 | sh as the shell. | |
1655 | ||
b4289b64 MA |
1656 | 2011-05-06 Michael Albinus <michael.albinus@gmx.de> |
1657 | ||
1658 | * dbusbind.c (QCdbus_type_unix_fd): Declare static. | |
1659 | (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it | |
1660 | is a constant. | |
1661 | (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or | |
1662 | a string. Handle both cases. | |
1663 | (Fdbus_call_method_asynchronously, Fdbus_register_signal) | |
1664 | (Fdbus_register_method): Use Qinvalid_function. | |
1665 | ||
af4c0e28 JB |
1666 | 2011-05-06 Juanma Barranquero <lekktu@gmail.com> |
1667 | ||
1668 | * makefile.w32-in: Update dependencies. | |
1669 | (LISP_H): Add inttypes.h and stdin.h. | |
1670 | (PROCESS_H): Add unistd.h. | |
1671 | ||
c51453d9 EZ |
1672 | 2011-05-06 Eli Zaretskii <eliz@gnu.org> |
1673 | ||
1674 | * lread.c: Include limits.h (fixes the MS-Windows build broken by | |
1675 | 2011-05-06T07:13:19Z!eggert@cs.ucla.edu). | |
1676 | ||
8ff0ac3c | 1677 | 2011-05-06 Paul Eggert <eggert@cs.ucla.edu> |
c032b5f8 | 1678 | |
4c4b566b PE |
1679 | * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local. |
1680 | ||
aab2b9b5 PE |
1681 | * term.c (vfatal): Remove stray call to va_end. |
1682 | It's not needed and the C Standard doesn't allow it here anyway. | |
1683 | ||
c378da0b PE |
1684 | Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux. |
1685 | * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545) | |
1686 | ||
288b08c7 PE |
1687 | * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM |
1688 | bytes. | |
1689 | ||
e3601888 PE |
1690 | * term.c: Don't include <stdarg.h>, as <lisp.h> does that. |
1691 | ||
db6c0e74 PE |
1692 | * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering. |
1693 | ||
dd5963ea PE |
1694 | * process.c (Fformat_network_address): Fix typo: args2 -> *args2. |
1695 | ||
88c9450f PE |
1696 | * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times). |
1697 | ||
2f9442b8 PE |
1698 | * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601). |
1699 | ||
c032b5f8 PE |
1700 | * charset.h (struct charset.code_space): Now has 15 elements, not 16. |
1701 | * charset.c (Fdefine_charset_internal): Don't initialize | |
1702 | charset.code_space[15]. The value was garbage, on hosts with | |
2d38271b | 1703 | 32-bit int (Bug#8600). |
a108c10b PE |
1704 | |
1705 | * lread.c (read_integer): Be more consistent with string-to-number. | |
1706 | Use string_to_number to do the actual conversion; this avoids | |
1707 | rounding errors and fixes some other screwups. Without this fix, | |
1708 | for example, #x1fffffffffffffff was misread as -2305843009213693952. | |
1709 | (digit_to_number): Move earlier, for benefit of read_integer. | |
1710 | Return -1 if the digit is out of range for the base, -2 if it is | |
48e400f0 | 1711 | not a digit in any supported base. (Bug#8602) |
a108c10b | 1712 | |
ad5f9eea PE |
1713 | * doprnt.c (doprnt): Support arbitrary pI values, such as "I64". |
1714 | ||
aec1708a PE |
1715 | * dispnew.c (scrolling_window): Return 1 if we scrolled, |
1716 | to match comment at start of function. This also removes a | |
1717 | GCC warning about overflow in a 32+64-bit port. | |
1718 | ||
47be4ab5 PE |
1719 | * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify. |
1720 | ||
371cac43 PE |
1721 | * dbusbind.c: Do not use XPNTR on a value that may be an integer. |
1722 | Reported by Stefan Monnier in | |
1723 | <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>. | |
04f2d78b CB |
1724 | (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): |
1725 | Use SYMBOLP-guarded XSYMBOL, not XPNTR. | |
371cac43 | 1726 | |
d01a7826 PE |
1727 | * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t. |
1728 | (EMACS_UINTPTR): Likewise, with uintptr_t. | |
1729 | ||
7fd47d5c PE |
1730 | * lisp.h: Prefer 64-bit EMACS_INT if available. |
1731 | (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit | |
1732 | on 32-bit hosts that have 64-bit int, so that they can access | |
1733 | large files. | |
122b0c86 PE |
1734 | However, temporarily disable this change unless the temporary |
1735 | symbol WIDE_EMACS_INT is defined. | |
7fd47d5c | 1736 | |
8727937b PE |
1737 | * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now. |
1738 | ||
8ac068ac PE |
1739 | Prefer intptr_t/uintptr_t for integers the same widths as pointers. |
1740 | This removes an assumption that EMACS_INT and long are the same | |
1741 | width as pointers. The assumption is true for Emacs porting targets | |
1742 | now, but we want to make other targets possible. | |
1743 | * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX. | |
1744 | (EMACS_INTPTR, EMACS_UINTPTR): New macros. | |
1745 | In the rest of the code, change types of integers that hold casted | |
1746 | pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically | |
1747 | replacing EMACS_INT, long, EMACS_UINT, and unsigned long. | |
1748 | (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed. | |
1749 | (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here. | |
1750 | No need to cast type when ORing. | |
1751 | (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR. | |
1752 | * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast. | |
1753 | * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to | |
1754 | assume EMACS_INT is the same width as char *. | |
1755 | * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb): | |
1756 | (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item): | |
1757 | Remove no-longer-needed casts. | |
1758 | (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback): | |
1759 | (xg_tool_bar_help_callback, xg_make_tool_item): | |
1760 | Use EMACS_INTPTR to hold an integer | |
1761 | that will be cast to void *; this can avoid a GCC warning | |
1762 | if EMACS_INT is not the same width as void *. | |
1763 | * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast. | |
1764 | * xdisp.c (display_echo_area_1, resize_mini_window_1): | |
1765 | (current_message_1, set_message_1): | |
1766 | Use a local to convert to proper width without a cast. | |
1767 | * xmenu.c (dialog_selection_callback): Likewise. | |
1768 | ||
ede49d71 PE |
1769 | * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long. |
1770 | Also, don't assume VALBITS / RAND_BITS is less than 5, | |
1771 | and don't rely on undefined behavior when shifting a 1 left into | |
1772 | the sign bit. | |
1773 | * lisp.h (get_random): Change signature to match. | |
1774 | ||
2f30ecd0 PE |
1775 | * lread.c (hash_string): Use size_t, not int, for hash computation. |
1776 | Normally we prefer signed values; but hashing is special, because | |
1777 | it's better to use unsigned division on hash table sizes so that | |
1778 | the remainder is nonnegative. Also, size_t is the natural width | |
1779 | for hashing into memory. The previous code used 'int', which doesn't | |
1780 | retain enough info to hash well into very large tables. | |
1781 | (oblookup, oblookup_last_bucket_number, Funintern): Likewise. | |
1782 | ||
2a866e7b PE |
1783 | * dbusbind.c: Don't possibly lose pointer info when converting. |
1784 | (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): | |
1785 | Use XPNTR rather than XHASH, so that the high-order bits of | |
1786 | the pointer aren't lost when converting through void *. | |
1787 | ||
51639eac PE |
1788 | * eval.c (Fautoload): Don't double-shift a pointer. |
1789 | ||
92394119 PE |
1790 | * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long. |
1791 | ||
dbdb9a7c JB |
1792 | 2011-05-06 Juanma Barranquero <lekktu@gmail.com> |
1793 | ||
1794 | * gnutls.c (DEF_GNUTLS_FN): | |
1795 | * image.c (DEF_IMGLIB_FN): Make function pointers static. | |
1796 | ||
db7a0b4f AS |
1797 | 2011-05-05 Andreas Schwab <schwab@linux-m68k.org> |
1798 | ||
1799 | * lread.c (lisp_file_lexically_bound_p): Stop scanning at end | |
1800 | marker. (Bug#8610) | |
1801 | ||
f7ff1b0f | 1802 | 2011-05-05 Eli Zaretskii <eliz@gnu.org> |
fab624aa EZ |
1803 | |
1804 | * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]: | |
1805 | New version that can reserve upto 2GB of heap space. | |
1806 | ||
f7ff1b0f | 1807 | 2011-05-05 Chong Yidong <cyd@stupidchicken.com> |
45cb8994 CY |
1808 | |
1809 | * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534). | |
1810 | ||
639c109b TZ |
1811 | 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com> |
1812 | ||
1813 | * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to | |
1814 | `gnutls_certificate_set_x509_key_file'. | |
1815 | ||
d2127135 JB |
1816 | 2011-05-05 Juanma Barranquero <lekktu@gmail.com> |
1817 | ||
1818 | * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)): | |
1819 | Update dependencies. | |
1820 | ||
e968f4f3 JB |
1821 | 2011-05-04 Juanma Barranquero <lekktu@gmail.com> |
1822 | ||
1823 | * gnutls.h (emacs_gnutls_write, emacs_gnutls_read): | |
1824 | * gnutls.c (emacs_gnutls_write, emacs_gnutls_read): | |
1825 | Remove unused parameter `fildes'. | |
1826 | * process.c (read_process_output, send_process): Don't pass it. | |
1827 | ||
84d358f0 JB |
1828 | 2011-05-04 Juanma Barranquero <lekktu@gmail.com> |
1829 | ||
1830 | Fix previous change: the library cache is defined in w32.c. | |
1831 | * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop. | |
1832 | (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI". | |
1833 | ||
0898ca10 JB |
1834 | 2011-05-04 Juanma Barranquero <lekktu@gmail.com> |
1835 | ||
1836 | Implement dynamic loading of GnuTLS on Windows. | |
1837 | ||
1838 | * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro. | |
1839 | (emacs_gnutls_write, emacs_gnutls_read): Mark as extern. | |
1840 | (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno): | |
1841 | Declare. | |
1842 | ||
1843 | * gnutls.c (Qgnutls_dll): Define. | |
1844 | (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros. | |
1845 | (gnutls_*): Declare function pointers. | |
1846 | (init_gnutls_functions): New function to initialize function pointers. | |
1847 | (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit) | |
1848 | (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers. | |
1849 | (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno): | |
1850 | Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno. | |
1851 | (emacs_gnutls_write, emacs_gnutls_read) | |
1852 | (emacs_gnutls_handle_error, Fgnutls_error_fatalp) | |
1853 | (Fgnutls_available_p): New function. | |
1854 | (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers. | |
1855 | (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it. | |
1856 | (syms_of_gnutls) <Sgnutls_available_p>: defsubr it. | |
1857 | ||
1858 | * image.c: Include w32.h. | |
1859 | (Vimage_type_cache): Delete. | |
1860 | (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it. | |
1861 | (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead. | |
1862 | (w32_delayed_load): Move to w32.c. | |
1863 | ||
1864 | * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare. | |
1865 | ||
1866 | * w32.c (QCloaded_from, Vlibrary_cache): Define. | |
1867 | (w32_delayed_load): Move from image.c. When loading a library, record | |
1868 | its filename in the :loaded-from property of the library id. | |
1869 | (globals_of_w32) <QCloaded_from, Vlibrary_cache>: | |
1870 | Initialize and staticpro them. | |
1871 | (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions. | |
1872 | ||
1873 | * process.c: Include lisp.h before w32.h, not after. | |
1874 | (wait_reading_process_output): Call emacs_gnutls_record_check_pending | |
1875 | instead of gnutls_record_check_pending. | |
1876 | ||
1877 | * callproc.c, emacs.c: Include lisp.h before w32.h, not after. | |
1878 | ||
ff4de4aa TZ |
1879 | 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com> |
1880 | ||
1881 | * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options | |
1882 | instead of :keyfiles. Give GnuTLS the keylist and the CRL lists | |
1883 | as passed in. | |
1884 | ||
abe95abb JD |
1885 | 2011-05-03 Jan Djärv <jan.h.d@swipnet.se> |
1886 | ||
1887 | * xterm.c (x_set_frame_alpha): Do not set property on anything | |
1888 | else than FRAME_X_OUTER_WINDOW (Bug#8608). | |
1889 | ||
e16e55d4 JB |
1890 | 2011-05-02 Juanma Barranquero <lekktu@gmail.com> |
1891 | ||
1892 | * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596) | |
1893 | ||
bafcf6a5 JB |
1894 | 2011-05-02 Juanma Barranquero <lekktu@gmail.com> |
1895 | ||
1896 | * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon) | |
1897 | (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again) | |
1898 | (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake) | |
1899 | (gnutls_global_initialized, Qgnutls_bootprop_priority) | |
1900 | (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles) | |
1901 | (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel) | |
1902 | (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags) | |
1903 | (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error) | |
1904 | (Qgnutls_bootprop_callbacks_verify): Make static. | |
1905 | ||
e7a6747f AS |
1906 | 2011-05-01 Andreas Schwab <schwab@linux-m68k.org> |
1907 | ||
19ed11ba AS |
1908 | * callproc.c: Indentation fixup. |
1909 | ||
e7a6747f | 1910 | * sysdep.c (wait_for_termination_1): Make static. |
04f2d78b CB |
1911 | (wait_for_termination, interruptible_wait_for_termination): |
1912 | Move after wait_for_termination_1. | |
e7a6747f | 1913 | |
1ef14cb4 LMI |
1914 | 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org> |
1915 | ||
1916 | * sysdep.c (interruptible_wait_for_termination): New function | |
1917 | which is like wait_for_termination, but allows keyboard | |
1918 | interruptions. | |
1919 | ||
1920 | * callproc.c (Fcall_process): Add (:file "file") as an option for | |
1921 | the STDOUT buffer. | |
1922 | (Fcall_process_region): Ditto. | |
1923 | ||
330d880c EZ |
1924 | 2011-04-30 Eli Zaretskii <eliz@gnu.org> |
1925 | ||
8db90b73 EZ |
1926 | * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)' |
1927 | rather than `XVECTOR (FOO)->size'. | |
1928 | ||
330d880c EZ |
1929 | * process.c: Remove HAVE_INTTYPES_H condition from inclusion of |
1930 | inttypes.h, as a gnulib replacement is used if it not available in | |
1931 | system headers. | |
1932 | ||
15cbd324 EZ |
1933 | 2011-04-21 Eli Zaretskii <eliz@gnu.org> |
1934 | ||
1935 | Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files. | |
1936 | * fileio.c (Finsert_file_contents): Don't limit file size to 1/4 | |
1937 | of MOST_POSITIVE_FIXNUM. (Bug#8528) | |
1938 | ||
1939 | * coding.c (coding_alloc_by_realloc): Error out if destination | |
1940 | will grow beyond MOST_POSITIVE_FIXNUM. | |
1941 | (decode_coding_emacs_mule): Abort if there isn't enough place in | |
1942 | charbuf for the composition carryover bytes. Reserve an extra | |
1943 | space for up to 2 characters produced in a loop. | |
1944 | (decode_coding_iso_2022): Abort if there isn't enough place in | |
1945 | charbuf for the composition carryover bytes. | |
1946 | ||
1947 | 2011-04-21 Eli Zaretskii <eliz@gnu.org> | |
afda1437 | 1948 | |
ae940cca EZ |
1949 | * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of |
1950 | aborting when %lld or %lll format is passed. | |
1951 | [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when | |
1952 | %llo or %llx format is passed. (Bug#8545) | |
1953 | ||
03ab8921 EZ |
1954 | * window.c (window_scroll_line_based): Use a marker instead of |
1955 | simple variables to record original value of point. (Bug#7952) | |
1956 | ||
afda1437 EZ |
1957 | * doprnt.c (doprnt): Fix the case where a multibyte sequence |
1958 | produced by %s or %c overflows available buffer space. (Bug#8545) | |
1959 | ||
f76dee0c PE |
1960 | 2011-04-28 Paul Eggert <eggert@cs.ucla.edu> |
1961 | ||
1962 | * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545). | |
283cdbef | 1963 | (SIZE_MAX): Move defn after all includes, as they might #define it. |
f76dee0c | 1964 | |
fdc5744d JB |
1965 | 2011-04-28 Juanma Barranquero <lekktu@gmail.com> |
1966 | ||
1967 | * w32.c (init_environment): Warn about defaulting HOME to C:\. | |
1968 | ||
638f053a JB |
1969 | 2011-04-28 Juanma Barranquero <lekktu@gmail.com> |
1970 | ||
1971 | * keyboard.c (Qdelayed_warnings_hook): Define. | |
1972 | (command_loop_1): Run `delayed-warnings-hook' | |
1973 | if Vdelayed_warnings_list is non-nil. | |
1974 | (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it. | |
1975 | (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it. | |
1976 | ||
d178f871 EZ |
1977 | 2011-04-28 Eli Zaretskii <eliz@gnu.org> |
1978 | ||
1979 | * doprnt.c (doprnt): Don't return value smaller than the buffer | |
1980 | size if the message was truncated. (Bug#8545). | |
1981 | ||
b124fd93 JB |
1982 | 2011-04-28 Juanma Barranquero <lekktu@gmail.com> |
1983 | ||
1984 | * w32fns.c (Fx_change_window_property, Fx_delete_window_property) | |
1985 | (Fx_window_property): #if-0 the whole functions, not just the bodies. | |
1986 | ||
e810457d PE |
1987 | 2011-04-27 Paul Eggert <eggert@cs.ucla.edu> |
1988 | ||
1989 | * doprnt.c (doprnt): Support "ll" length modifier, for long long. | |
1990 | ||
ea51cceb JB |
1991 | 2011-04-27 Juanma Barranquero <lekktu@gmail.com> |
1992 | ||
1993 | * makefile.w32-in: Update dependencies. | |
1994 | ||
94dcfacf EZ |
1995 | 2011-04-27 Eli Zaretskii <eliz@gnu.org> |
1996 | ||
1997 | Improve `doprnt' and its usage. (Bug#8545) | |
1998 | * doprnt.c (doprnt): Make sure `format' is never accessed beyond | |
1999 | `format_end'. Remove support for %l as a conversion specifier. | |
2000 | Don't use xrealloc. Improve diagnostics when the %l size modifier | |
2001 | is used. Update the commentary. | |
2002 | ||
2003 | * eval.c (verror): Simplify calculation of size_t. | |
2004 | ||
2005 | * coding.c (Ffind_operation_coding_system): Fix diagnostic error | |
2006 | messages. | |
2007 | ||
f61f41d7 PE |
2008 | 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change) |
2009 | ||
2010 | * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing | |
2011 | change. | |
2012 | ||
96fb4434 PE |
2013 | 2011-04-27 Paul Eggert <eggert@cs.ucla.edu> |
2014 | ||
2015 | * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF. | |
2016 | This makes this file independent of the recent pseudovector change. | |
2017 | ||
671875da | 2018 | 2011-04-26 Paul Eggert <eggert@cs.ucla.edu> |
eab3844f | 2019 | |
69e9b5a3 PE |
2020 | * keyboard.c (handle_user_signal): Fix pointer signedness problem. |
2021 | ||
b5f869a7 | 2022 | * gnutls.c (emacs_gnutls_handle_error): Remove unused local. |
7754e151 | 2023 | (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *. |
8d4c3955 | 2024 | Remove unused local. |
c8926152 | 2025 | (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0. |
080e5a8d | 2026 | |
841a1577 | 2027 | * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546) |
04f2d78b CB |
2028 | GCC 4.6.0 optimizes based on type-based alias analysis. |
2029 | For example, if b is of type struct buffer * and v of type struct | |
eab3844f PE |
2030 | Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size |
2031 | != &v->size, and therefore "v->size = 1; b->size = 2; return | |
2032 | v->size;" must therefore return 1. This assumption is incorrect | |
2033 | for Emacs, since it type-puns struct Lisp_Vector * with many other | |
2034 | types. To fix this problem, this patch adds a new type struct | |
f904488f | 2035 | vectorlike_header that documents the constraints on layout of vectors |
eab3844f PE |
2036 | and pseudovectors, and helps optimizing compilers not get fooled |
2037 | by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE | |
2038 | XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons. | |
f904488f PE |
2039 | * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of |
2040 | the size member. | |
eab3844f PE |
2041 | (XSETPVECTYPE): Rewrite in terms of new macro. |
2042 | (XSETPVECTYPESIZE): New macro, specifying both type and size. | |
2043 | This is a bit clearer, and further avoids the possibility of | |
2044 | undesirable aliasing. | |
2045 | (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size. | |
f904488f | 2046 | (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR. |
eab3844f PE |
2047 | (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE, |
2048 | since Lisp_Subr is a special case (no "next" field). | |
04f2d78b CB |
2049 | (ASIZE): Now uses header.size rather than size. |
2050 | All previous uses of XVECTOR (foo)->size replaced to use this macro, | |
f904488f PE |
2051 | to avoid the hassle of writing XVECTOR (foo)->header.size. |
2052 | (struct vectorlike_header): New type. | |
eab3844f PE |
2053 | (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the |
2054 | object, to help avoid aliasing. | |
2055 | (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP. | |
2056 | (SUBRP): Likewise, since Lisp_Subr is a special case. | |
2057 | * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table): | |
2058 | (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector): | |
2059 | (struct Lisp_Hash_Table): Combine first two members into a single | |
f904488f | 2060 | struct vectorlike_header member. All uses of "size" and "next" members |
eab3844f PE |
2061 | changed to be "header.size" and "header.next". |
2062 | * buffer.h (struct buffer): Likewise. | |
2063 | * font.h (struct font_spec, struct font_entity, struct font): Likewise. | |
2064 | * frame.h (struct frame): Likewise. | |
2065 | * process.h (struct Lisp_Process): Likewise. | |
2066 | * termhooks.h (struct terminal): Likewise. | |
2067 | * window.c (struct save_window_data, struct saved_window): Likewise. | |
2068 | * window.h (struct window): Likewise. | |
2069 | * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector): | |
2070 | Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems. | |
2071 | * buffer.c (init_buffer_once): Likewise. | |
2072 | * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a | |
2073 | special case. | |
2074 | * process.c (Fformat_network_address): Use local var for size, | |
2075 | for brevity. | |
2076 | ||
0df1eac5 PE |
2077 | * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR. |
2078 | ||
847ab9d1 | 2079 | Make the Lisp reader and string-to-float more consistent (Bug#8525) |
452f4150 PE |
2080 | * data.c (atof): Remove decl; no longer used or needed. |
2081 | (digit_to_number): Move to lread.c. | |
2082 | (Fstring_to_number): Use new string_to_number function, to be | |
2083 | consistent with how the Lisp reader treats infinities and NaNs. | |
2084 | Do not assume that floating-point numbers represent EMACS_INT | |
2085 | without losing information; this is not true on most 64-bit hosts. | |
2086 | Avoid double-rounding errors, by insisting on integers when | |
2087 | parsing non-base-10 numbers, as the documentation specifies. | |
2088 | * lisp.h (string_to_number): New decl, replacing ... | |
2089 | (isfloat_string): Remove. | |
bc0a5c13 | 2090 | * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax. |
d78050d6 | 2091 | (read1): Do not accept +. and -. as integers; this |
452f4150 PE |
2092 | appears to have been a coding error. Similarly, do not accept |
2093 | strings like +-1e0 as floating point numbers. Do not report | |
2094 | overflow for integer overflows unless the base is not 10 which | |
2095 | means we have no simple and reliable way to continue. | |
2096 | Break out the floating-point parsing into a new | |
2097 | function string_to_number, so that Fstring_to_number parses | |
2098 | floating point numbers consistently with the Lisp reader. | |
04f2d78b | 2099 | (digit_to_number): Move here from data.c. Make it static inline. |
452f4150 PE |
2100 | (E_CHAR, EXP_INT): Remove, replacing with ... |
2101 | (E_EXP): New macro, to solve the "1.0e+" problem mentioned below. | |
2102 | (string_to_number): New function, replacing isfloat_string. | |
2103 | This function checks for valid syntax and produces the resulting | |
2104 | Lisp float number too. Rework it so that string-to-number | |
bc0a5c13 | 2105 | no longer mishandles examples like "1.0e+". Use strtoumax, |
d78050d6 PE |
2106 | so that overflow for non-base-10 numbers is reported only when |
2107 | there's no portable and simple way to convert to floating point. | |
452f4150 | 2108 | |
67769ffc PE |
2109 | * textprop.c (set_text_properties_1): Rewrite for clarity, |
2110 | and to avoid GCC warning about integer overflow. | |
2111 | ||
c20db43f PE |
2112 | * intervals.h (struct interval): Use EMACS_INT for members |
2113 | where EMACS_UINT might cause problems. See | |
2114 | <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>. | |
2115 | (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed. | |
2116 | * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT. | |
2117 | All uses changed. | |
37aa2f85 PE |
2118 | (offset_intervals): Tell GCC not to worry about length overflow |
2119 | when negating a negative length. | |
c20db43f | 2120 | |
2538aa2f PE |
2121 | * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static. |
2122 | (overrun_check_free): Likewise. | |
2123 | ||
f2d3008d PE |
2124 | * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check |
2125 | in the common case where SDATA_DATA_OFFSET is a multiple of Emacs | |
2126 | word size. | |
2127 | ||
ec8df744 PE |
2128 | * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10. |
2129 | (gnutls_make_error): Rename local to avoid shadowing. | |
2130 | (gnutls_emacs_global_deinit): ifdef out; not used. | |
2131 | (Fgnutls_boot): Use const for pointer to readonly storage. | |
2132 | Comment out unused local. Fix pointer signedness problems. | |
2133 | ||
640ee02d PE |
2134 | * lread.c (openp): Don't stuff size_t into an 'int'. |
2135 | Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning | |
2136 | about possible signed overflow. | |
2137 | ||
6048fb2a PE |
2138 | * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10. |
2139 | (GDK_KEY_g): Don't define if already defined. | |
2140 | (xg_prepare_tooltip): Avoid pointer signedness problem. | |
2141 | (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts. | |
2142 | ||
fa3c87e1 PE |
2143 | * process.c (Fnetwork_interface_info): Avoid left-shift undefined |
2144 | behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts. | |
2145 | ||
2172544b PE |
2146 | * xfns.c (Fx_window_property): Simplify a bit, |
2147 | to make a bit faster and to avoid GCC 4.6.0 warning. | |
2148 | * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise. | |
2149 | ||
9b821a21 PE |
2150 | * fns.c (internal_equal): Don't assume size_t fits in int. |
2151 | ||
3c616cfa PE |
2152 | * alloc.c (compact_small_strings): Tighten assertion a little. |
2153 | ||
c2982e87 PE |
2154 | Replace pEd with more-general pI, and fix some printf arg casts. |
2155 | * lisp.h (pI): New macro, generalizing old pEd macro to other | |
2156 | conversion specifiers. For example, use "...%"pI"d..." rather | |
2157 | than "...%"pEd"...". | |
2158 | (pEd): Remove. All uses replaced with similar uses of pI. | |
2159 | * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise. | |
2160 | * alloc.c (check_pure_size): Don't overflow by converting size to int. | |
2161 | * bidi.c (bidi_dump_cached_states): Use pI to avoid cast. | |
2162 | * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort. | |
2163 | * dbusbind.c (xd_append_arg): Use pI to avoid cast. | |
2164 | (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise. | |
2165 | * font.c (font_unparse_xlfd): Avoid potential buffer overrun on | |
2166 | 64-bit hosts. | |
2167 | (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts. | |
2168 | * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts. | |
2169 | * print.c (safe_debug_print, print_object): Likewise. | |
2170 | (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT | |
2171 | to int. | |
6f04d126 PE |
2172 | Use pI instead of if-then-else-abort. Use %p to avoid casts, |
2173 | avoiding the 0 flag, which is not portable. | |
c2982e87 PE |
2174 | * process.c (Fmake_network_process): Use pI to avoid cast. |
2175 | * region-cache.c (pp_cache): Likewise. | |
2176 | * xdisp.c (decode_mode_spec): Likewise. | |
2177 | * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined | |
2178 | behavior on 64-bit hosts with printf arg. | |
6f04d126 | 2179 | * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag. |
c2982e87 PE |
2180 | (x_stop_queuing_selection_requests): Likewise. |
2181 | (x_get_window_property): Don't truncate byte count to an 'int' | |
2182 | when tracing. | |
0b432f21 | 2183 | |
5e073ec7 PE |
2184 | * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right |
2185 | here, since it parses constructs like leading '-' and spaces, | |
2186 | which are not wanted; and it overflows with large numbers. | |
2187 | Instead, simply match F[0-9]+, which is what is wanted anyway. | |
2188 | ||
36372bf9 PE |
2189 | * alloc.c: Remove unportable assumptions about struct layout. |
2190 | (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros. | |
2191 | (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data): | |
2192 | (allocate_vectorlike, make_pure_vector): Use the new macros, | |
2193 | plus offsetof, to remove unportable assumptions about struct layout. | |
2194 | These assumptions hold on all porting targets that I know of, but | |
2195 | they are not guaranteed, they're easy to remove, and removing them | |
2196 | makes further changes easier. | |
2197 | ||
0b432f21 PE |
2198 | * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks". |
2199 | This doesn't fix a bug but makes the code clearer. | |
bfd1c781 PE |
2200 | (string_overrun_cookie): Now const. Use initializers that |
2201 | don't formally overflow signed char, to avoid warnings. | |
000098c1 PE |
2202 | (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that |
2203 | can cause Emacs to crash when string overrun checking is enabled. | |
c7bda33c PE |
2204 | (allocate_buffer): Don't assume sizeof (struct buffer) is a |
2205 | multiple of sizeof (EMACS_INT); it need not be, if | |
2206 | alignof(EMACS_INT) < sizeof (EMACS_INT). | |
d0f4e1f5 | 2207 | (check_sblock, check_string_bytes, check_string_free_list): Protoize. |
0b432f21 | 2208 | |
895009e1 JB |
2209 | 2011-04-26 Juanma Barranquero <lekktu@gmail.com> |
2210 | ||
2211 | * keyboard.c (QCrtl): Rename from Qrtl. All uses changed. | |
2212 | ||
6a7a1b0b TZ |
2213 | 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com> |
2214 | ||
2215 | * gnutls.c (emacs_gnutls_handshake): Return an error if we're not | |
b5f869a7 | 2216 | supposed to be handshaking. (Bug#8556) |
6a7a1b0b TZ |
2217 | Reported by Paul Eggert <eggert@cs.ucla.edu>. |
2218 | ||
841a1577 | 2219 | 2011-04-26 Daniel Colascione <dan.colascione@gmail.com> |
0438ce91 DC |
2220 | |
2221 | * lisp.h (Qdebug): List symbol. | |
895009e1 | 2222 | * eval.c (Qdebug): Restore global linkage. |
0438ce91 DC |
2223 | * keyboard.c (debug-on-event): New variable. |
2224 | (handle_user_signal): Break into debugger when debug-on-event | |
2225 | matches the current signal symbol. | |
2226 | ||
f2d3ba6f DN |
2227 | 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu> |
2228 | ||
2229 | * alloc.c (check_sblock, check_string_bytes) | |
2230 | (check_string_free_list): Convert to standard C. | |
2231 | ||
42ce4c63 TZ |
2232 | 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com> |
2233 | ||
2234 | * w32.c (emacs_gnutls_push): Fix typo. | |
2235 | ||
825cd63c EZ |
2236 | 2011-04-25 Eli Zaretskii <eliz@gnu.org> |
2237 | ||
fb11d64d EZ |
2238 | * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about |
2239 | "cast to pointer from integer of different size". | |
2240 | ||
825cd63c EZ |
2241 | Improve doprnt and its use in verror. (Bug#8545) |
2242 | * doprnt.c (doprnt): Document the set of format control sequences | |
2243 | supported by the function. Use SAFE_ALLOCA instead of always | |
2244 | using `alloca'. | |
2245 | ||
2246 | * eval.c (verror): Don't limit the buffer size at size_max-1, that | |
2247 | is one byte too soon. Don't use xrealloc; instead xfree and | |
2248 | xmalloc anew. | |
2249 | ||
e061a11b TZ |
2250 | 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com> |
2251 | ||
2252 | * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the | |
2253 | callbacks stage. | |
2254 | ||
2255 | * gnutls.c: Renamed global_initialized to | |
2256 | gnutls_global_initialized. Added internals for the | |
2257 | :verify-hostname-error, :verify-error, and :verify-flags | |
2258 | parameters of `gnutls-boot' and documented those parameters in the | |
2259 | docstring. Start callback support. | |
2260 | (emacs_gnutls_handshake): Add Woe32 support. Retry handshake | |
2261 | unless a fatal error occured. Call gnutls_alert_send_appropriate | |
2262 | on error. Return error code. | |
2263 | (emacs_gnutls_write): Call emacs_gnutls_handle_error. | |
2264 | (emacs_gnutls_read): Likewise. | |
2265 | (Fgnutls_boot): Return handshake error code. | |
2266 | (emacs_gnutls_handle_error): New function. | |
2267 | (wsaerror_to_errno): Likewise. | |
2268 | ||
2269 | * w32.h (emacs_gnutls_pull): Add prototype. | |
2270 | (emacs_gnutls_push): Likewise. | |
2271 | ||
2272 | * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32. | |
2273 | (emacs_gnutls_push): Likewise. | |
2274 | ||
2275 | 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change) | |
2276 | ||
2277 | * process.c (wait_reading_process_output): Check if GnuTLS | |
2278 | buffered some data internally if no FDs are set for TLS | |
2279 | connections. | |
2280 | ||
2281 | * makefile.w32-in (OBJ2): Add gnutls.$(O). | |
2282 | (LIBS): Link to USER_LIBS. | |
2283 | ($(BLD)/gnutls.$(0)): New target. | |
2284 | ||
fa6996bc EZ |
2285 | 2011-04-24 Eli Zaretskii <eliz@gnu.org> |
2286 | ||
eb35682e EZ |
2287 | * xdisp.c (handle_single_display_spec): Rename the |
2288 | display_replaced_before_p argument into display_replaced_p, to | |
2289 | make it consistent with the commentary. Fix typos in the | |
2290 | commentary. | |
2291 | ||
e2ad650c EZ |
2292 | * textprop.c (syms_of_textprop): Remove dead code. |
2293 | (copy_text_properties): Delete obsolete commentary about an | |
2294 | interface that was deleted long ago. Fix typos in the description | |
2295 | of arguments. | |
2296 | ||
1b2de274 EZ |
2297 | * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list |
2298 | to changes in oldXMenu/XMenu.h from 2011-04-16. | |
2299 | <menu_help_message, prev_menu_help_message>: Constify. | |
2300 | (IT_menu_make_room): menu->help_text is now `const char **'; | |
2301 | adjust. | |
2302 | ||
2303 | * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes | |
2304 | to changes in oldXMenu/XMenu.h from 2011-04-16. | |
2305 | (struct XMenu): Declare `help_text' `const char **'. | |
2306 | ||
2307 | * xfaces.c <Qunspecified>: Make extern again. | |
2308 | ||
2309 | * syntax.c: Include sys/types.h before including regex.h, as | |
2310 | required by Posix. | |
2311 | ||
762b15be EZ |
2312 | * doc.c (get_doc_string): Improve the format passed to `error'. |
2313 | ||
2314 | * doprnt.c (doprnt): Improve commentary. | |
2315 | ||
2316 | * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal. | |
2317 | ||
2318 | * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan | |
2319 | them with etags. | |
2320 | ||
f1052e5d EZ |
2321 | * makefile.w32-in (globals.h): Add a dummy recipe, to make any |
2322 | changes in globals.h immediately force recompilation. | |
762b15be EZ |
2323 | (TAGS): Depend on $(CURDIR)/m/intel386.h and |
2324 | $(CURDIR)/s/ms-w32.h. | |
2325 | (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h. | |
f1052e5d | 2326 | |
fa6996bc EZ |
2327 | * character.c (Fchar_direction): Function deleted. |
2328 | (syms_of_character): Don't defsubr it. | |
2329 | <char-direction-table>: Deleted. | |
2330 | ||
e6c3da20 EZ |
2331 | 2011-04-23 Eli Zaretskii <eliz@gnu.org> |
2332 | ||
2333 | Fix doprnt so it could be used again safely in `verror'. (Bug#8435) | |
2334 | * doprnt.c: Include limits.h. | |
2335 | (SIZE_MAX): New macro. | |
04f2d78b CB |
2336 | (doprnt): Return a size_t value. 2nd arg is now size_t. |
2337 | Many local variables are now size_t instead of int or unsigned. | |
e6c3da20 EZ |
2338 | Improve overflow protection. Support `l' modifier for integer |
2339 | conversions. Support %l conversion. Don't assume an EMACS_INT | |
2340 | argument for integer conversions and for %c. | |
2341 | ||
2342 | * lisp.h (doprnt): Restore prototype. | |
2343 | ||
2344 | * makefile.w32-in ($(BLD)/callint.$(O)): Depend on | |
2345 | $(SRC)/character.h. | |
2346 | ||
2347 | * Makefile.in (base_obj): Add back doprnt.o. | |
2348 | ||
2349 | * deps.mk (doprnt.o): Add back prerequisites. | |
2350 | (callint.o): Depend on character.h. | |
2351 | ||
2352 | * eval.c (internal_lisp_condition_case): Include the handler | |
2353 | representation in the error message. | |
2354 | (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug | |
2355 | when breaking from the loop. | |
2356 | ||
2357 | * xdisp.c (vmessage): Call doprnt instead of vsnprintf. | |
2358 | ||
2359 | * callint.c (Fcall_interactively): When displaying error message | |
2360 | about invalid control letter, pass the character's codepoint, not | |
2361 | a pointer to its multibyte form. Improve display of the character | |
2362 | in octal and display also its hex code. | |
2363 | ||
2364 | * character.c (char_string): Use %x to display the (unsigned) | |
2365 | codepoint of an invalid character, to avoid displaying a bogus | |
2366 | negative value. | |
2367 | ||
2368 | * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to | |
2369 | `error', not SYMBOL_NAME itself. | |
2370 | ||
2371 | * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for | |
2372 | character arguments to `error'. | |
2373 | ||
2374 | * charset.c (check_iso_charset_parameter): Fix incorrect argument | |
2375 | to `error' in error message about FINAL_CHAR argument. Make sure | |
2376 | FINAL_CHAR is a character, and use %c when it is passed as | |
2377 | argument to `error'. | |
2378 | ||
4ffd0d6b | 2379 | 2011-04-23 Eli Zaretskii <eliz@gnu.org> |
97a93095 EZ |
2380 | |
2381 | * s/ms-w32.h (localtime): Redirect to sys_localtime. | |
2382 | ||
2383 | * w32.c: Include <time.h>. | |
2384 | (sys_localtime): New function. | |
2385 | ||
4ffd0d6b | 2386 | 2011-04-23 Chong Yidong <cyd@stupidchicken.com> |
c17819f4 CY |
2387 | |
2388 | * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451). | |
2389 | ||
4ffd0d6b | 2390 | * buffer.c (syms_of_buffer): Doc fix (Bug#6902). |
aac0c6e3 | 2391 | |
4ffd0d6b | 2392 | 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change) |
aac0c6e3 | 2393 | |
4ffd0d6b GM |
2394 | * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on |
2395 | zombies (Bug#8467). | |
aac0c6e3 | 2396 | |
04c56954 EZ |
2397 | 2011-04-19 Eli Zaretskii <eliz@gnu.org> |
2398 | ||
2399 | * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of | |
2400 | gl_state.e_property when gl_state.object is Qt. | |
2401 | ||
2402 | * insdel.c (make_gap_larger): Remove limitation of buffer size | |
2403 | to <= INT_MAX. | |
2404 | ||
16a43933 CY |
2405 | 2011-04-18 Chong Yidong <cyd@stupidchicken.com> |
2406 | ||
2407 | * xdisp.c (lookup_glyphless_char_display) | |
2408 | (produce_glyphless_glyph): Handle cons cell entry in | |
2409 | glyphless-char-display. | |
2410 | (Vglyphless_char_display): Document it. | |
2411 | ||
2412 | * term.c (produce_glyphless_glyph): Handle cons cell entry in | |
2413 | glyphless-char-display. | |
2414 | ||
4581706e CY |
2415 | 2011-04-17 Chong Yidong <cyd@stupidchicken.com> |
2416 | ||
2417 | * xdisp.c (get_next_display_element): Remove unnecessary ifdefs. | |
2418 | ||
2419 | * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions. | |
2420 | ||
2421 | * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing | |
2422 | definition for no-X builds. | |
2423 | ||
4887c6e2 | 2424 | 2011-04-16 Paul Eggert <eggert@cs.ucla.edu> |
764430a3 | 2425 | |
fd35b6f9 PE |
2426 | Static checks with GCC 4.6.0 and non-default toolkits. |
2427 | ||
5c1ccb01 PE |
2428 | * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl. |
2429 | ||
006c5daa PE |
2430 | * process.c (keyboard_bit_set): Define only if SIGIO. |
2431 | (send_process_trap): Mark it with NO_RETURN if it doesn't return. | |
2432 | (send_process): Repair possible setjmp clobbering. | |
2433 | ||
efc736d3 PE |
2434 | * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'. |
2435 | ||
4e2fe2e6 PE |
2436 | * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts. |
2437 | ||
f97334a2 PE |
2438 | * data.c (arith_error): Mark with NO_RETURN if it doesn't return. |
2439 | ||
4e75f29d PE |
2440 | * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED): |
2441 | Define only if needed. | |
2442 | ||
90efadd1 PE |
2443 | * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier |
2444 | by pacifying GCC about it. Maybe it's time to retire it? | |
875975e9 | 2445 | * xfaces.c (USG, __TIMEVAL__): Likewise. |
90efadd1 | 2446 | |
3c647824 PE |
2447 | * dispextern.h (struct redisplay_interface): Rename param |
2448 | to avoid shadowing. | |
e264f262 | 2449 | * termhooks.h (struct terminal): Likewise. |
761383f4 | 2450 | * xterm.c (xembed_send_message): Likewise. |
3c647824 | 2451 | |
b58c5c4a PE |
2452 | * insdel.c (make_gap_smaller): Define only if |
2453 | USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC. | |
2454 | ||
cad59032 PE |
2455 | * keyboard.c (read_char): Make a var volatile so longjmp won't clobber |
2456 | it. | |
2457 | ||
c339dc2e PE |
2458 | * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used, |
2459 | so that we aren't warned about unused symbols. | |
2460 | ||
91a3e27b PE |
2461 | * xfns.c (Fx_file_dialog): Rename local to avoid shadowing. |
2462 | ||
399c71d3 | 2463 | * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512). |
7a3fb125 | 2464 | |
8ffc96f5 PE |
2465 | * xfns.c (x_real_positions): Mark locals as initialized. |
2466 | ||
eef9bc79 PE |
2467 | * xmenu.c (xmenu_show): Don't use uninitialized vars. |
2468 | ||
098db9dd PE |
2469 | * xterm.c: Fix problems found by static analysis with other toolkits. |
2470 | (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT. | |
dda3aedd PE |
2471 | (x_dispatch_event): Declare static if USE_GTK, and |
2472 | define if USE_GTK || USE_X_TOOLKIT. | |
098db9dd | 2473 | (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK. |
dda3aedd | 2474 | * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT. |
841a1577 JB |
2475 | * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only |
2476 | if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK. | |
098db9dd | 2477 | |
eb18f6cc PE |
2478 | * xmenu.c (menu_help_callback): Pointer type fixes. |
2479 | Use const pointers when pointing at readonly data. Avoid pointer | |
2480 | signedness clashes. | |
2481 | (FALSE): Remove unused macro. | |
2482 | (update_frame_menubar): Remove unused decl. | |
2483 | ||
1fe72bf8 PE |
2484 | * xfns.c (Fx_hide_tip): Move locals to avoid shadowing. |
2485 | ||
60d9e1db PE |
2486 | * menu.c (push_submenu_start, push_submenu_end): Do not define unless |
2487 | USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI. | |
2488 | (single_menu_item): Rename local to avoid shadowing. | |
2489 | ||
39261c26 PE |
2490 | * keyboard.c (make_lispy_event): Remove unused local var. |
2491 | ||
018c5e19 PE |
2492 | * frame.c, frame.h (x_get_resource_string): Bring this back, but |
2493 | only if HAVE_X_WINDOWS && !USE_X_TOOLKIT. | |
2494 | ||
63d2b86e PE |
2495 | * bitmaps: Change bitmaps from unsigned char back to the X11 |
2496 | compatible char. Avoid the old compiler warnings about | |
2497 | out-of-range initializers by using, for example, '\xab' rather | |
2498 | than 0xab. | |
2499 | ||
aefd87e1 PE |
2500 | * xgselect.c (xgselect_initialize): Check vs interface |
2501 | even if ! (defined (USE_GTK) || defined (HAVE_GCONF)). | |
2502 | ||
bf501fb9 PE |
2503 | * xmenu.c (xmenu_show): Rename parm to avoid shadowing. |
2504 | ||
e9829fdf PE |
2505 | * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers |
2506 | to read-only memory. | |
2507 | ||
1086c095 PE |
2508 | * fns.c (vector): Remove; this old hack is no longer needed. |
2509 | ||
2baccd04 | 2510 | * xsmfns.c (create_client_leader_window): Rename shadowing arg. |
401f10cb | 2511 | Remove unused var. |
dde42981 | 2512 | (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define. |
2baccd04 | 2513 | |
72391843 | 2514 | * xrdb.c (x_load_resources): Omit unused local. |
3565b346 | 2515 | |
436c16df | 2516 | * xfns.c (free_frame_menubar, atof): Remove duplicate decls. |
8a94ea33 | 2517 | (x_window): Rename locals to avoid shadowing. |
dc5ddd85 | 2518 | (USG): Use the kludged USG macro, to pacify gcc. |
436c16df | 2519 | |
92bb796d | 2520 | * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused. |
bbbef9e1 | 2521 | (x_term_init): Remove local to avoid shadowing. |
92bb796d | 2522 | |
764430a3 | 2523 | * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl. |
4887c6e2 PE |
2524 | |
2525 | * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if | |
2526 | USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then. | |
2527 | ||
d1dfb56c EZ |
2528 | 2011-04-16 Eli Zaretskii <eliz@gnu.org> |
2529 | ||
c4354cb4 EZ |
2530 | * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'. |
2531 | ||
d1dfb56c EZ |
2532 | Fix regex.c, syntax.c and friends for buffers > 2GB. |
2533 | * syntax.h (struct gl_state_s): Declare character position members | |
2534 | EMACS_INT. | |
2535 | ||
2536 | * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT. | |
2537 | ||
04f2d78b CB |
2538 | * textprop.c (verify_interval_modification, interval_of): |
2539 | Declare arguments EMACS_INT. | |
d1dfb56c EZ |
2540 | |
2541 | * intervals.c (adjust_intervals_for_insertion): Declare arguments | |
2542 | EMACS_INT. | |
2543 | ||
2544 | * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'. | |
2545 | ||
2546 | * indent.c (Fvertical_motion): Local variable it_start is now | |
2547 | EMACS_INT. | |
2548 | ||
2549 | * regex.c (re_match, re_match_2, re_match_2_internal) | |
2550 | (bcmp_translate, regcomp, regexec, print_double_string) | |
2551 | (group_in_compile_stack, re_search, re_search_2, regex_compile) | |
2552 | (re_compile_pattern, re_exec): Declare arguments and local | |
2553 | variables `size_t' and `ssize_t' and return values `regoff_t', as | |
2554 | appropriate. | |
2555 | (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'. | |
2556 | (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'. | |
2557 | <compile_stack_type>: `size' and `avail' are now `size_t'. | |
2558 | ||
2559 | * regex.h <regoff_t>: Use ssize_t, not int. | |
2560 | (re_search, re_search_2, re_match, re_match_2): Arguments that | |
2561 | specify buffer/string position and length are now ssize_t and | |
2562 | size_t. Return type is regoff_t. | |
2563 | ||
613052cd BK |
2564 | 2011-04-16 Ben Key <bkey76@gmail.com> |
2565 | ||
2566 | * nsfont.m: Fixed bugs in ns_get_family and | |
2567 | ns_descriptor_to_entity that were caused by using free to | |
2568 | deallocate memory blocks that were allocated by xmalloc (via | |
2569 | xstrdup). This caused Emacs to crash when compiled with | |
2570 | XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with | |
2571 | --enable-checking=xmallocoverrun). xfree is now used to | |
2572 | deallocate these memory blocks. | |
2573 | ||
4170f62f | 2574 | 2011-04-15 Paul Eggert <eggert@cs.ucla.edu> |
3e047f51 | 2575 | |
71b41406 PE |
2576 | * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT. |
2577 | ||
9587a89d PE |
2578 | emacs_write: Accept and return EMACS_INT for sizes. |
2579 | See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html | |
2580 | et seq. | |
2581 | * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write): | |
2582 | Accept and return EMACS_INT. | |
2583 | (emacs_gnutls_write): Return the number of bytes written on | |
2584 | partial writes. | |
2585 | * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise. | |
273a5f82 PE |
2586 | (emacs_read, emacs_write): Remove check for negative size, as the |
2587 | Emacs source code has been audited now. | |
9587a89d PE |
2588 | * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs. |
2589 | (emacs_read, emacs_write): Use it. | |
273a5f82 PE |
2590 | * process.c (send_process): Adjust to the new signatures of |
2591 | emacs_write and emacs_gnutls_write. Do not attempt to store | |
2592 | a byte offset into an 'int'; it might overflow. | |
9587a89d | 2593 | See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html |
273a5f82 | 2594 | |
3e047f51 PE |
2595 | * sound.c: Don't assume sizes fit in 'int'. |
2596 | (struct sound_device.period_size, alsa_period_size): | |
9c3c56a7 | 2597 | Return EMACS_INT, not int. |
3e047f51 | 2598 | (struct sound_device.write, vox_write, alsa_write): |
9c3c56a7 PE |
2599 | Accept EMACS_INT, not int. |
2600 | (wav_play, au_play): Use EMACS_INT to store sizes and to | |
3e047f51 PE |
2601 | record read return values. |
2602 | ||
cc39a9db BK |
2603 | 2011-04-15 Ben Key <bkey76@gmail.com> |
2604 | ||
c9d0ec6d JB |
2605 | * keyboard.c (Qundefined): Don't declare static since it is used |
2606 | in nsfns.m. | |
2607 | * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare | |
2608 | static since they are used in nsfont.m. | |
cc39a9db | 2609 | |
6c60eb9f SM |
2610 | 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca> |
2611 | ||
2612 | * process.c (Qprocessp): Don't declare static. | |
2613 | * lisp.h (Qprocessp): Declare again. | |
2614 | ||
7990b61a JB |
2615 | 2011-04-15 Juanma Barranquero <lekktu@gmail.com> |
2616 | ||
2617 | * font.c (Qopentype): Don't make static (used from w32uniscribe.c). | |
2618 | ||
5d4cb038 PE |
2619 | 2011-04-14 Paul Eggert <eggert@cs.ucla.edu> |
2620 | ||
8bd7b830 | 2621 | Improve C-level modularity by making more things 'static'. |
cd64ea1d | 2622 | |
e3b27b31 PE |
2623 | Don't publish debugger-only interfaces to other modules. |
2624 | * lisp.h (safe_debug_print, debug_output_compilation_hack): | |
2625 | (verify_bytepos, count_markers): Move decls to the only modules | |
2626 | that need them. | |
2627 | * region-cache.h (pp_cache): Likewise. | |
2628 | * window.h (check_all_windows): Likewise. | |
2629 | * marker.c, print.c, region-cache.c, window.c: Decls moved here. | |
2630 | ||
5d4cb038 PE |
2631 | * sysdep.c (croak): Now static, if |
2632 | defined TIOCNOTTY || defined USG5 || defined CYGWIN. | |
2633 | * syssignal.h (croak): Declare only if not static. | |
69003fd8 PE |
2634 | |
2635 | * alloc.c (refill_memory_reserve): Now static if | |
2636 | !defined REL_ALLOC || defined SYSTEM_MALLOC. | |
2637 | * lisp.h (refill_memory_reserve): Declare only if not static. | |
93ea6e8f | 2638 | |
e87b6180 PE |
2639 | * xsettings.c, xsettings.h (xsettings_get_system_normal_font): |
2640 | Define only if USE_LUCID. | |
2641 | ||
ac64929e PE |
2642 | * xrdb.c (x_customization_string, x_rm_string): Now static. |
2643 | ||
6f37259d PE |
2644 | * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF. |
2645 | * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF. | |
2646 | ||
1683e3ab PE |
2647 | * xdisp.c (draw_row_with_mouse_face): Now static. |
2648 | * dispextern.h (draw_row_with_mouse_fave): Remove decl. | |
2649 | ||
de9c2632 PE |
2650 | * window.h (check_all_windows): Mark externally visible. |
2651 | ||
2b96acb7 PE |
2652 | * window.c (window_deletion_count): Now static. |
2653 | ||
2654 | * undo.c: Make symbols static if they're not exported. | |
2655 | (last_undo_buffer, last_boundary_position, pending_boundary): | |
2656 | Now static. | |
2657 | ||
50436f33 PE |
2658 | * textprop.c (interval_insert_behind_hooks): Now static. |
2659 | (interval_insert_in_front_hooks): Likewise. | |
2660 | ||
64520e5c PE |
2661 | * term.c: Make symbols static if they're not exported. |
2662 | (tty_turn_off_highlight, get_tty_terminal, max_frame_cols): | |
2663 | (max_frame_lines, tty_set_terminal_modes): | |
2664 | (tty_reset_terminal_modes, tty_turn_off_highlight): | |
2665 | (get_tty_terminal): Now static. | |
2666 | (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM. | |
2667 | * termhooks.h (term_mouse_moveto): Do not declare if | |
8bd7b830 | 2668 | HAVE_WINDOW_SYSTEM. |
64520e5c PE |
2669 | * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes): |
2670 | (tty_turn_off_highlight, get_tty_terminal): Remove decls. | |
2671 | ||
1fa53021 PE |
2672 | * sysdep.c: Make symbols static if they're not exported. |
2673 | (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner): | |
2674 | Now static. | |
2675 | (sigprocmask_set, full_mask): Remove; unused. | |
2676 | (wait_debugging): Mark as visible. | |
2677 | * syssignal.h (SIGFULLMASK, full_mask): Remove decls. | |
2678 | * systty.h (emacs_get_tty, emacs_set_tty): Remove decls. | |
2679 | ||
d4b43b22 PE |
2680 | * syntax.c (syntax_temp): Define only if !__GNUC__. |
2681 | ||
b7c513d0 PE |
2682 | * sound.c (current_sound_device, current_sound): Now static. |
2683 | ||
989b29ad PE |
2684 | * search.c (searchbufs, searchbuf_head): Now static. |
2685 | ||
13a55a78 PE |
2686 | * scroll.c (scroll_cost): Remove; unused. |
2687 | * dispextern.h (scroll_cost): Remove decl. | |
2688 | ||
de68a1fc PE |
2689 | * region-cache.h (pp_cache): Mark as externally visible. |
2690 | ||
40ccffa6 PE |
2691 | * process.c: Make symbols static if they're not exported. |
2692 | (process_tick, update_tick, create_process, chan_process): | |
2693 | (Vprocess_alist, proc_buffered_char, datagram_access): | |
2694 | (fd_callback_data, send_process_frame, process_sent_to): Now static. | |
2695 | (deactivate_process): Mark defn as static, as well as decl. | |
2696 | * lisp.h (create_process): Remove decl. | |
2697 | * process.h (chan_process, Vprocess_alist): Remove decls. | |
2698 | ||
ad64fc97 PE |
2699 | * print.c: Make symbols static if they're not exported. |
2700 | (print_depth, new_backquote_output, being_printed, print_buffer): | |
2701 | (print_buffer_size, print_buffer_pos, print_buffer_pos_byte): | |
2702 | (print_interval, print_number_index, initial_stderr_stream): | |
2703 | Now static. | |
2704 | * lisp.h (Fprinc): Remove decl. | |
2705 | (debug_output_compilation_hack): Mark as externally visible. | |
2706 | ||
adddb265 PE |
2707 | * sysdep.c (croak): Move decl from here to syssignal.h. |
2708 | * syssignal.h (croak): Put it here, so the API can be checked when | |
2709 | 'croak' is called from dissociate_if_controlling_tty. | |
2710 | ||
1717ede2 PE |
2711 | * minibuf.c: Make symbols static if they're not exported. |
2712 | (minibuf_save_list, choose_minibuf_frame): Now static. | |
2713 | * lisp.h (choose_minibuf_frame): Remove decl. | |
2714 | ||
fa5fb2bc PE |
2715 | * lisp.h (verify_bytepos, count_markers): Mark as externally visible. |
2716 | ||
1e3890d1 PE |
2717 | * lread.c: Make symbols static if they're not exported. |
2718 | (read_objects, initial_obarray, oblookup_last_bucket_number): | |
2719 | Now static. | |
2720 | (make_symbol): Remove; unused. | |
2721 | * lisp.h (initial_obarray, make_symbol): Remove decls. | |
2722 | ||
8a1414fa PE |
2723 | * keyboard.c: Make symbols static if they're not exported. |
2724 | (single_kboard, recent_keys_index, total_keys, recent_keys): | |
2725 | (this_command_key_count_reset, raw_keybuf, raw_keybuf_count): | |
2726 | (this_single_command_key_start, echoing, last_auto_save): | |
2727 | (read_key_sequence_cmd, dribble, recursive_edit_unwind): | |
2728 | (command_loop, echo_now, keyboard_init_hook, help_char_p): | |
2729 | (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer): | |
2730 | (Vlispy_mouse_stem, double_click_count): | |
2731 | Now static. | |
2732 | (force_auto_save_soon): Define only if SIGDANGER. | |
2733 | (ignore_mouse_drag_p): Now static if | |
2734 | !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS. | |
2735 | (print_help): Remove; unused. | |
2736 | (stop_character, last_timer_event): Mark as externally visible. | |
2737 | * keyboard.h (ignore_mouse_drag_p): Declare only if | |
2738 | defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS. | |
2739 | (echo_now, help_char_p, quit_throw_to_read_char): Remove decls. | |
2740 | * lisp.h (echoing): Remove decl. | |
2741 | (force_auto_save_soon): Declare only if SIGDANGER. | |
2742 | * xdisp.c (redisplay_window): Simplify code, to make it more | |
2743 | obvious that ignore_mouse_drag_p is not accessed if !defined | |
2744 | USE_GTK && !defined HAVE_NS. | |
2745 | ||
93ea6e8f PE |
2746 | * intervals.c: Make symbols static if they're not exported. |
2747 | (merge_properties_sticky, merge_interval_right, delete_interval): | |
2748 | Now static. | |
2749 | * intervals.h (merge_interval_right, delete_interval): Remove decls. | |
2750 | ||
77382fcc PE |
2751 | * insdel.c: Make symbols static if they're not exported. |
2752 | However, leave prepare_to_modify_buffer alone. It's never | |
2753 | called from outside this function, but that appears to be a bug. | |
2754 | (combine_after_change_list, combine_after_change_buffer): | |
4889fc82 | 2755 | (adjust_after_replace, signal_before_change): Now static. |
77382fcc PE |
2756 | (adjust_after_replace_noundo): Remove; unused. |
2757 | * lisp.h (adjust_after_replace, adjust_after_replace_noundo): | |
4889fc82 | 2758 | (signal_before_change): Remove decls. |
77382fcc | 2759 | |
9306c32e PE |
2760 | * indent.c (val_compute_motion, val_vmotion): Now static. |
2761 | ||
cd44d2eb PE |
2762 | * image.c: Make symbols static if they're not exported. |
2763 | * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare | |
2764 | if USE_GTK. | |
2765 | * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK. | |
2766 | (xpm_color_cache, ct_table, ct_colors_allocated): Now static. | |
2767 | ||
ad9a7a06 PE |
2768 | * fringe.c (standard_bitmaps): Now static. |
2769 | (max_used_fringe_bitmap): Now static, unless HAVE_NS. | |
2770 | ||
81626931 PE |
2771 | * frame.c: Make symbols static if they're not exported. |
2772 | (x_report_frame_params, make_terminal_frame): Now static. | |
2773 | (get_frame_param): Now static, unless HAVE_NS. | |
2774 | (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM. | |
2775 | (x_get_resource_string): Remove; not used. | |
2776 | * frame.h (make_terminal_frame, x_report_frame_params): | |
2777 | (x_get_resource_string); Remove decls. | |
2778 | (x_fullscreen_adjust): Declare only if WINDOWSNT. | |
2779 | * lisp.h (get_frame_param): Declare only if HAVE_NS. | |
2780 | ||
239f9db9 PE |
2781 | * font.c, fontset.c: Make symbols static if they're not exported. |
2782 | * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro. | |
2783 | (FACE_SUITABLE_FOR_CHAR_P): Use it. | |
2784 | * font.c (font_close_object): Now static. | |
2785 | * font.h (font_close_object): Remove. | |
2786 | * fontset.c (FONTSET_OBJLIST): Remove. | |
2787 | (free_realized_fontset) #if-0 the body, which does nothing. | |
2788 | (face_suitable_for_char_p): #if-0, as it's never called. | |
2789 | * fontset.h (face_suitable_for_char_p): Remove decl. | |
04f2d78b CB |
2790 | * xfaces.c (face_at_string_position): |
2791 | Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P, | |
239f9db9 PE |
2792 | since 0 is always ASCII. |
2793 | ||
dfcf3579 PE |
2794 | * fns.c (weak_hash_tables): Now static. |
2795 | ||
5045092b PE |
2796 | * fileio.c: Make symbols static if they're not exported. |
2797 | (auto_saving, auto_save_mode_bits, auto_save_error_occurred): | |
2798 | (Vwrite_region_annotation_buffers): Now static. | |
2799 | ||
57a96f5c PE |
2800 | * eval.c: Make symbols static if they're not exported. |
2801 | (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static. | |
2802 | * lisp.h (backtrace_list): Remove decl. | |
2803 | ||
35f08c38 PE |
2804 | * emacs.c: Make symbols static if they're not exported. |
2805 | (malloc_state_ptr, malloc_using_checking, syms_of_emacs): | |
2806 | (fatal_error_code, fatal_error_signal_hook, standard_args): | |
2807 | Now static. | |
2808 | (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL. | |
2809 | (DEFINE_DUMMY_FUNCTION): Mark function as externally visible. | |
2810 | (__CTOR_LIST__, __DTOR_LIST__): Now externally visible. | |
2811 | * lisp.h (fatal_error_signal_hook): Remove decl. | |
2812 | (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL. | |
2813 | ||
f44bd759 PE |
2814 | * editfns.c: Move a (normally-unused) function to its only use. |
2815 | * editfns.c, lisp.h (get_operating_system_release): Remove. | |
2816 | * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not | |
2817 | worth the hassle of breaking this out. | |
2818 | ||
b532497d PE |
2819 | * xterm.c: Make symbols static if they're not exported. |
2820 | (x_raise_frame, x_lower_frame, x_wm_set_window_state): | |
2821 | (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error): | |
2822 | (x_destroy_window, x_delete_display): | |
2823 | Now static. | |
2824 | (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT). | |
2825 | (x_mouse_leave): Remove; unused. | |
2826 | * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame): | |
2827 | (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap): | |
2828 | (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes): | |
2829 | Remove decls. | |
2830 | (x_mouse_leave): Declare only if WINDOWSNT. | |
2831 | (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT. | |
2832 | (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS && | |
2833 | USE_X_TOOLKIT. | |
2834 | ||
1675728f PE |
2835 | * ftxfont.c: Make symbols static if they're not exported. |
2836 | (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined | |
2837 | HAVE_FREETYPE. | |
2838 | * font.h (ftxfont_driver): Likewise. | |
2839 | ||
e4cebfca PE |
2840 | * xfns.c: Make symbols static if they're not exported. |
2841 | (x_last_font_name, x_display_info_for_name): | |
2842 | (x_set_foreground_color, x_set_background_color, x_set_mouse_color): | |
2843 | (x_set_cursor_color, x_set_border_pixel, x_set_border_color): | |
2844 | (x_set_cursor_type, x_set_icon_type, x_set_icon_name): | |
2845 | (x_set_scroll_bar_foreground, x_set_scroll_bar_background): | |
2846 | (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer): | |
2847 | (last_show_tip_args): Now static. | |
2848 | (xic_defaut_fontset, xic_create_fontsetname): Define only if | |
2849 | defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT | |
2850 | (x_screen_planes): Remove; unused. | |
2851 | * dispextern.h (x_screen_planes): Remove decl. | |
2852 | ||
5bf46f05 PE |
2853 | * dispnew.c: Make symbols static if they're not exported. |
2854 | * dispextern.h (redraw_garbaged_frames, scrolling): | |
2855 | (increment_row_positions): Remove. | |
2856 | * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling): | |
2857 | (delayed_size_change, glyph_matrix_count, glyph_pool_count): | |
2858 | Now static. | |
2859 | (redraw_garbaged_frames): Remove; unused. | |
2860 | ||
435f4c28 PE |
2861 | * xfaces.c: Make symbols static if they're not exported. |
2862 | * dispextern.h (ascii_face_of_lisp_face, free_realized_face): | |
2863 | Remove decls. | |
2864 | * xterm.h (defined_color): Remove decls. | |
2865 | (x_free_dpy_colors): Declare only if USE_X_TOOLKIT. | |
2866 | * xfaces.c (tty_suppress_bold_inverse_default_colors_p): | |
2867 | (menu_face_changed_default, defined_color, free_realized_face): | |
2868 | (x_free_dpy_colors): Define only if USE_X_TOOLKIT. | |
2869 | (ascii_face_of_lisp_face): Remove; unused. | |
2870 | ||
8524aef3 PE |
2871 | * xdisp.c: Make symbols static if they're not exported. |
2872 | * dispextern.h (scratch_glyph_row, window_box_edges): | |
2873 | (glyph_to_pixel_coords, set_cursor_from_row): | |
2874 | (get_next_display_element, set_iterator_to_next): | |
2875 | (highlight_trailing_whitespace, frame_to_window_pixel_xy): | |
2876 | (show_mouse_face): Remove decls | |
2877 | * frame.h (message_buf_print): Likewise. | |
2878 | * lisp.h (pop_message, set_message, check_point_in_composition): | |
2879 | Likewise. | |
2880 | * xterm.h (set_vertical_scroll_bar): Likewise. | |
2881 | * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed): | |
2882 | (message_buf_print, scratch_glyph_row, displayed_buffer): | |
2883 | (set_iterator_to_next, pop_message, set_message, set_cursor_from_row): | |
2884 | (get_next_display_element, show_mouse_face, window_box_edges): | |
2885 | (frame_to_window_pixel_xy, check_point_in_composition): | |
2886 | (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static. | |
2887 | (glyph_to_pixel_coords): Remove; unused. | |
2888 | ||
16390cd2 PE |
2889 | * dired.c (file_name_completion): Now static. |
2890 | ||
2891 | * dbusbind.c (xd_in_read_queued_messages): Now static. | |
2892 | ||
a25f4dfa PE |
2893 | * lisp.h (circular_list_error, FOREACH): Remove; unused. |
2894 | * data.c (circular_list_error): Remove. | |
2895 | ||
14a9c8df PE |
2896 | * commands.h (last_point_position, last_point_position_buffer): |
2897 | (last_point_position_window): Remove decls. | |
2898 | * keyboard.c: Make these variables static. | |
2899 | ||
04f2d78b CB |
2900 | * coding.h (coding, code_convert_region, encode_coding_gap): |
2901 | Remove decls. | |
74ab6df5 PE |
2902 | * coding.c (Vsjis_coding_system, Vbig5_coding_system): |
2903 | (iso_code_class, detect_coding, code_convert_region): Now static. | |
2904 | (encode_coding_gap): Remove; unused. | |
2905 | ||
38dfbee1 PE |
2906 | * chartab.c (chartab_chars, chartab_bits): Now static. |
2907 | ||
a2cb4e63 PE |
2908 | * charset.h (charset_iso_8859_1): Remove decl. |
2909 | * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump): | |
2910 | Now static. | |
2911 | ||
127198fd PE |
2912 | * ccl.h (check_ccl_update, Vccl_program_table): Remove decls. |
2913 | * ccl.c (Vccl_program_table): Now static. | |
2914 | (check_ccl_update): Remove; unused. | |
2915 | ||
d85b608f PE |
2916 | * category.c (SET_CATEGORY_SET, set_category_set): Move here. |
2917 | * category.h: ... from here. | |
2918 | * category.c (check_category_table, set_category_set): Now static. | |
2919 | ||
31cd66f3 PE |
2920 | * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static. |
2921 | * lisp.h: Remove these decls. | |
2922 | ||
c358e587 PE |
2923 | * buffer.c (buffer_count): Remove unused var. |
2924 | ||
e78aecca PE |
2925 | * bidi.c (bidi_dump_cached_states): Mark as externally visible, |
2926 | so that it's not optimized away. | |
2927 | (bidi_ignore_explicit_marks_for_paragraph_level): Likewise. | |
2928 | * dispextern.h (bidi_dump_cached_states): Remove, since it's | |
2929 | exported only to the debugger. | |
2930 | ||
e192d7d3 | 2931 | * atimer.c (alarm_signal_handler, run_all_atimers): Now static. |
04f2d78b | 2932 | * atimer.h (run_all_atimers): Remove; not exported. |
e192d7d3 | 2933 | |
92470028 PE |
2934 | font.c: Make copy_font_spec and merge_font_spec ordinary C functions. |
2935 | * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it | |
2936 | was inaccessible from Lisp. | |
2937 | (merge_font_spec): Likewise, renaming from Fmerge_font_spec. | |
2938 | * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses. | |
2939 | ||
244ed907 PE |
2940 | alloc.c: Import and export fewer symbols, and remove unused items. |
2941 | * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING | |
2942 | is defined. | |
2943 | (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that | |
2944 | it's not optimized away by whole-program optimization. | |
2945 | (message_enable_multibyte, free_misc): Remove. | |
2946 | (catchlist, handlerlist, mark_backtrace): | |
2947 | Declare only if BYTE_MARK_STACK. | |
2948 | (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo. | |
2949 | * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined. | |
2950 | (message_enable_multibyte): Remove decl. | |
2951 | (free_misc, interval_free_list, float_block, float_block_index): | |
2952 | (n_float_blocks, float_free_list, cons_block, cons_block_index): | |
2953 | (cons_free_list, last_marked_index): | |
2954 | Now static. | |
2955 | (suppress_checking, die): Define only if ENABLE_CHECKING is defined. | |
2956 | * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK. | |
2957 | (mark_backtrace): Define only if BYTE_MARK_STACK. | |
2958 | * xdisp.c (message_enable_multibyte): Now static. | |
2959 | ||
61c2b50e | 2960 | Declare Lisp_Object Q* variables to be 'static' if not exported. |
955cbe7b PE |
2961 | This makes it easier for human readers (and static analyzers) |
2962 | to see whether these variables are used from other modules. | |
2963 | * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c: | |
2964 | * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c: | |
2965 | * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c: | |
2966 | * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c: | |
2967 | * lread.c, macros.c, minibuf.c, print.c, process.c, search.c: | |
2968 | * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c: | |
2969 | * xmenu.c, xselect.c: | |
2970 | Declare Q* vars static if they are not used in other modules. | |
2971 | * ccl.h, character.h, charset.h, coding.h, composite.h, font.h: | |
2972 | * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h: | |
2973 | Remove decls of unexported vars. | |
2974 | * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro. | |
2975 | ||
95c82688 PE |
2976 | * lisp.h (DEFINE_FUNC): Make sname 'static'. |
2977 | ||
16a97296 PE |
2978 | Make Emacs functions such as Fatom 'static' by default. |
2979 | This makes it easier for human readers (and static analyzers) | |
2980 | to see whether these functions can be called from other modules. | |
2981 | DEFUN now defines a static function. To make the function external | |
2982 | so that it can be used in other C modules, use the new macro DEFUE. | |
8bd7b830 PE |
2983 | * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p): |
2984 | (Finit_image_library): | |
16a97296 PE |
2985 | (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer): |
2986 | (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute): | |
2987 | (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes): | |
2988 | Remove decls, since these functions are now static. | |
2989 | (Funintern, Fget_internal_run_time): New decls, since these functions | |
2990 | were already external. | |
95c82688 | 2991 | |
16a97296 PE |
2992 | * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c: |
2993 | * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c: | |
2994 | * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c: | |
2995 | * fns.c, font.c, fontset.c, frame.c, image.c, indent.c: | |
2996 | * keyboard.c, keymap.c, lread.c: | |
2997 | * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c: | |
2998 | * syntax.c, term.c, terminal.c, textprop.c, undo.c: | |
2999 | * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c: | |
3000 | Mark functions with DEFUE instead of DEFUN, | |
3001 | if they are used in other modules. | |
3002 | * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward | |
3003 | decls for now-static functions. | |
3004 | * buffer.h (Fdelete_overlay): Remove decl. | |
3005 | * callproc.c (Fgetenv_internal): Mark as internal. | |
3006 | * composite.c (Fremove_list_of_text_properties): Remove decl. | |
3007 | (Fcomposition_get_gstring): New forward static decl. | |
3008 | * composite.h (Fcomposite_get_gstring): Remove decl. | |
3009 | * dired.c (Ffile_attributes): New forward static decl. | |
3010 | * doc.c (Fdocumntation_property): New forward static decl. | |
3011 | * eval.c (Ffetch_bytecode): New forward static decl. | |
3012 | (Funintern): Remove extern decl; now in .h file where it belongs. | |
3013 | * fileio.c (Fmake_symbolic_link): New forward static decl. | |
3014 | * image.c (Finit_image_library): New forward static decl. | |
3015 | * insdel.c (Fcombine_after_change_execute): Make forward decl static. | |
3016 | * intervals.h (Fprevious_property_change): | |
3017 | (Fremove_list_of_text_properties): Remove decls. | |
3018 | * keyboard.c (Fthis_command_keys): Remove decl. | |
3019 | (Fcommand_execute): New forward static decl. | |
3020 | * keymap.c (Flookup_key): New forward static decl. | |
3021 | (Fcopy_keymap): Now static. | |
3022 | * keymap.h (Flookup_key): Remove decl. | |
3023 | * process.c (Fget_process): New forward static decl. | |
3024 | (Fprocess_datagram_address): Mark as internal. | |
3025 | * syntax.c (Fsyntax_table_p): New forward static decl. | |
3026 | (skip_chars): Remove duplicate decl. | |
3027 | * textprop.c (Fprevious_property_change): New forward static decl. | |
3028 | * window.c (Fset_window_fringes, Fset_window_scroll_bars): | |
3029 | Now internal. | |
3030 | (Fset_window_margins, Fset_window_vscroll): New forward static decls. | |
3031 | * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls. | |
3032 | ||
785bbd42 PE |
3033 | * editfns.c (Fformat): Remove unreachable code. |
3034 | ||
8b913b57 AS |
3035 | 2011-04-14 Andreas Schwab <schwab@linux-m68k.org> |
3036 | ||
3037 | * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13 | |
3038 | change. (Bug#8496) | |
3039 | ||
a6744a35 EZ |
3040 | 2011-04-13 Eli Zaretskii <eliz@gnu.org> |
3041 | ||
3042 | * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init | |
3043 | when at ZV. (Bug#8487) | |
3044 | ||
e7974947 AS |
3045 | 2011-04-12 Andreas Schwab <schwab@linux-m68k.org> |
3046 | ||
baad03f0 AS |
3047 | * charset.c (Fclear_charset_maps): Use xfree instead of free. |
3048 | (Bug#8437) | |
3049 | * keyboard.c (parse_tool_bar_item): Likewise. | |
3050 | * sound.c (sound_cleanup, alsa_close): Likewise. | |
3051 | * termcap.c (tgetent): Likewise. | |
3052 | * xfns.c (x_default_font_parameter): Likewise. | |
3053 | * xsettings.c (read_and_apply_settings): Likewise. | |
3054 | ||
e7974947 AS |
3055 | * alloc.c (overrun_check_malloc, overrun_check_realloc) |
3056 | (overrun_check_free): Protoize. | |
3057 | ||
28272684 PE |
3058 | 2011-04-12 Paul Eggert <eggert@cs.ucla.edu> |
3059 | ||
3060 | * sysdep.c (emacs_read, emacs_write): Check for negative sizes | |
3061 | since callers should never pass a negative size. | |
3062 | Change the signature to match that of plain 'read' and 'write'; see | |
3063 | <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>. | |
3064 | * lisp.h: Update prototypes of emacs_write and emacs_read. | |
3065 | ||
11997c76 EZ |
3066 | 2011-04-11 Eli Zaretskii <eliz@gnu.org> |
3067 | ||
3068 | * xdisp.c (redisplay_window): Don't try to determine the character | |
3069 | position of the scroll margin if the window start point w->startp | |
e896f03c | 3070 | is outside the buffer's accessible region. (Bug#8468) |
11997c76 | 3071 | |
8a2cbd72 EZ |
3072 | 2011-04-10 Eli Zaretskii <eliz@gnu.org> |
3073 | ||
3074 | Fix write-region and its subroutines for buffers > 2GB. | |
3075 | * fileio.c (a_write, e_write): Modify declaration of arguments and | |
3076 | local variables to support buffers larger than 2GB. | |
3077 | (Fcopy_file): Use EMACS_INT for return value of emacs_read. | |
3078 | ||
3079 | * sysdep.c (emacs_write, emacs_read): Use ssize_t for last | |
3080 | argument, local variables, and return value. | |
3081 | ||
3082 | * lisp.h: Update prototypes of emacs_write and emacs_read. | |
3083 | ||
3084 | * sound.c (vox_write): Use ssize_t for return value of emacs_write. | |
3085 | ||
4073e537 | 3086 | 2011-04-10 Paul Eggert <eggert@cs.ucla.edu> |
eb3f1cc8 | 3087 | |
1ebfdcb6 PE |
3088 | * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack. |
3089 | ||
b2ded58d PE |
3090 | Fix more problems found by GCC 4.6.0's static checks. |
3091 | ||
7d66342c PE |
3092 | * xdisp.c (vmessage): Use a better test for character truncation. |
3093 | ||
bbf47d44 PE |
3094 | * charset.c (load_charset_map): <, not <=, for optimization, |
3095 | and to avoid potential problems with integer overflow. | |
9248994d | 3096 | * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise. |
f9a68bc5 | 3097 | * casetab.c (set_identity, shuffle): Likewise. |
3ab1c7ce | 3098 | * editfns.c (Fformat): Likewise. |
1e69125e | 3099 | * syntax.c (skip_chars): Likewise. |
3befa583 | 3100 | |
e3019616 PE |
3101 | * xmenu.c (set_frame_menubar): Allocate smaller local vectors. |
3102 | This also lets GCC 4.6.0 generate slightly better loop code. | |
3103 | ||
becfa255 PE |
3104 | * callint.c (Fcall_interactively): <, not <=, for optimization. |
3105 | (Fcall_interactively): Count the number of arguments produced, | |
3106 | not the number of arguments given. This is simpler and lets GCC | |
3107 | 4.6.0 generate slightly better code. | |
3108 | ||
dae0cd48 PE |
3109 | * ftfont.c: Distingish more carefully between FcChar8 and char. |
3110 | The previous code passed unsigned char * to a functions like | |
3111 | strlen and xstrcasecmp that expect char *, which does not | |
3112 | conform to the C standard. | |
3113 | (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for | |
3114 | arguments to FcPatternGetString, and explicitly cast FcChar8 * to | |
3115 | char * when the C standard requires it. | |
3116 | ||
76032d70 PE |
3117 | * keyboard.c (read_char): Remove unused var. |
3118 | ||
eb3f1cc8 PE |
3119 | * eval.c: Port to Windows vsnprintf (Bug#8435). |
3120 | Include <limits.h>. | |
3121 | (SIZE_MAX): Define if the headers do not. | |
3122 | (verror): Do not give up if vsnprintf returns a negative count. | |
3123 | Instead, grow the buffer. This ports to Windows vsnprintf, which | |
3124 | does not conform to C99. Problem reported by Eli Zaretskii. | |
3125 | Also, simplify the allocation scheme, by avoiding the need for | |
3126 | calling realloc, and removing the ALLOCATED variable. | |
3127 | ||
70476b54 PE |
3128 | * eval.c (verror): Initial buffer size is 4000 (not 200) bytes. |
3129 | ||
12020a9e PE |
3130 | Remove invocations of doprnt, as Emacs now uses vsnprintf. |
3131 | But keep the doprint source code for now, as we might revamp it | |
3132 | and use it again (Bug#8435). | |
ea6c7ae6 PE |
3133 | * lisp.h (doprnt): Remove. |
3134 | * Makefile.in (base_obj): Remove doprnt.o. | |
3135 | * deps.mk (doprnt.o): Remove. | |
3136 | ||
5fdb398c PE |
3137 | error: Print 32- and 64-bit integers portably (Bug#8435). |
3138 | Without this change, on typical 64-bit hosts error ("...%d...", N) | |
3139 | was used to print both 32- and 64-bit integers N, which relied on | |
3140 | undefined behavior. | |
3141 | * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd): | |
3142 | New macro. | |
3143 | * lisp.h (error, verror): Mark as printf-like functions. | |
3144 | * eval.c (verror): Use vsnprintf, not doprnt, to do the real work. | |
3145 | Report overflow in size calculations when allocating printf buffer. | |
3146 | Do not truncate output string at its first null byte. | |
3147 | * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work. | |
3148 | Truncate the output at a character boundary, since vsnprintf does not | |
3149 | do that. | |
3150 | * charset.c (check_iso_charset_parameter): Convert internal | |
3151 | character to string before calling 'error', since %c now has the | |
3152 | printf meaning. | |
3153 | * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int | |
3154 | overflow when computing char to be passed to 'error'. Do not | |
3155 | pass Lisp_Object to 'error'; pass the integer instead. | |
3156 | * nsfns.m (Fns_do_applescript): Use int, not long, since it's | |
3157 | formatted with plain %d. | |
3158 | ||
b189fa66 PE |
3159 | * eval.c (internal_lisp_condition_case): Don't pass spurious arg. |
3160 | ||
bff87ef0 PE |
3161 | * keyboard.c (access_keymap_keyremap): Print func name, not garbage. |
3162 | ||
7e2cac20 PE |
3163 | * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int. |
3164 | ||
ce4d90b5 PE |
3165 | * xterm.c (x_catch_errors): Remove duplicate declaration. |
3166 | ||
266c9547 PE |
3167 | * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too. |
3168 | ||
79c49ad2 PE |
3169 | * xdisp.c, lisp.h (message_nolog): Remove; unused. |
3170 | ||
368f4090 JM |
3171 | 2011-04-10 Jim Meyering <meyering@redhat.com> |
3172 | ||
3173 | use ssize_t and size_t for read- and write-like emacs_gnutls_* functions | |
3174 | * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like: | |
3175 | return ssize_t not "int", and use size_t as the buffer length. | |
3176 | (emacs_gnutls_write): Likewise, and make the buffer pointer "const". | |
3177 | * gnutls.h: Update declarations. | |
3178 | * process.c (read_process_output): Use ssize_t, to match. | |
3179 | (send_process): Likewise. | |
3180 | ||
a32d4040 CY |
3181 | 2011-04-09 Chong Yidong <cyd@stupidchicken.com> |
3182 | ||
3183 | * image.c (Fimagemagick_types): Doc fix, and comment cleanup. | |
3184 | ||
8546720e | 3185 | 2011-04-09 Chong Yidong <cyd@stupidchicken.com> |
aac0c6e3 | 3186 | |
04f2d78b CB |
3187 | * ftfont.c (get_adstyle_property, ftfont_pattern_entity): |
3188 | Use unsigned char, to match FcChar8 type definition. | |
aac0c6e3 | 3189 | |
8546720e GM |
3190 | * xterm.c (handle_one_xevent): |
3191 | * xmenu.c (create_and_show_popup_menu): | |
3192 | * xselect.c (x_decline_selection_request) | |
3193 | (x_reply_selection_request): Avoid type-punned deref of X events. | |
aac0c6e3 | 3194 | |
0a2f5c1a | 3195 | 2011-04-09 Eli Zaretskii <eliz@gnu.org> |
a53e2e89 EZ |
3196 | |
3197 | Fix some uses of `int' instead of EMACS_INT. | |
3198 | * search.c (string_match_1, fast_string_match) | |
3199 | (fast_c_string_match_ignore_case, fast_string_match_ignore_case) | |
3200 | (scan_buffer, find_next_newline_no_quit) | |
3201 | (find_before_next_newline, search_command, Freplace_match) | |
3202 | (Fmatch_data): Make some `int' variables be EMACS_INT. | |
3203 | ||
3204 | * xdisp.c (display_count_lines): 3rd argument and return value now | |
3205 | EMACS_INT. All callers changed. | |
3206 | (pint2hrstr): Last argument is now EMACS_INT. | |
3207 | ||
3208 | * coding.c (detect_coding_utf_8, detect_coding_emacs_mule) | |
3209 | (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5) | |
3210 | (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8) | |
3211 | (decode_coding_utf_16, decode_coding_emacs_mule) | |
3212 | (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5) | |
3213 | (decode_coding_ccl, decode_coding_charset) | |
3214 | <consumed_chars, consumed_chars_base>: Declare EMACS_INT. | |
3215 | (decode_coding_iso_2022, decode_coding_emacs_mule) | |
3216 | (decode_coding_sjis, decode_coding_big5, decode_coding_charset) | |
3217 | <char_offset, last_offset>: Declare EMACS_INT. | |
3218 | (encode_coding_utf_8, encode_coding_utf_16) | |
3219 | (encode_coding_emacs_mule, encode_invocation_designation) | |
3220 | (encode_designation_at_bol, encode_coding_iso_2022) | |
3221 | (encode_coding_sjis, encode_coding_big5, encode_coding_ccl) | |
3222 | (encode_coding_raw_text, encode_coding_charset) <produced_chars>: | |
3223 | Declare EMACS_INT. | |
3224 | (ASSURE_DESTINATION): Declare more_bytes EMACS_INT. | |
3225 | (encode_invocation_designation): Last argument P_NCHARS is now | |
3226 | EMACS_INT. | |
3227 | (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT. | |
3228 | (produce_chars): from_nchars and to_nchars are now EMACS_INT. | |
3229 | ||
3230 | * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT. | |
3231 | All users changed. | |
3232 | ||
3233 | * ccl.c (Fccl_execute_on_string): Declare some variables | |
3234 | EMACS_INT. | |
3235 | ||
8546720e | 3236 | 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change) |
0080dc6b SS |
3237 | |
3238 | * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450). | |
3239 | ||
4e19a977 CS |
3240 | 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com> |
3241 | ||
3242 | * process.c (Fformat_network_address): Doc fix. | |
3243 | ||
87302331 R |
3244 | 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change) |
3245 | ||
3246 | * xml.c (parse_region): Avoid creating spurious whiespace nodes. | |
3247 | ||
cbb59342 CY |
3248 | 2011-04-08 Chong Yidong <cyd@stupidchicken.com> |
3249 | ||
3250 | * keyboard.c (read_char): Call Lisp function help-form-show, | |
3251 | instead of using internal_with_output_to_temp_buffer. | |
3252 | (Qhelp_form_show): New var. | |
e0d38eeb | 3253 | (syms_of_keyboard): Use DEFSYM macro. |
cbb59342 CY |
3254 | |
3255 | * print.c (internal_with_output_to_temp_buffer): Function deleted. | |
3256 | ||
3257 | * lisp.h (internal_with_output_to_temp_buffer): Remove prototype. | |
3258 | ||
e67a13ab CY |
3259 | 2011-04-06 Chong Yidong <cyd@stupidchicken.com> |
3260 | ||
04f2d78b CB |
3261 | * process.c (Flist_processes): Remove to Lisp. |
3262 | (list_processes_1): Delete. | |
e67a13ab | 3263 | |
973f782d EZ |
3264 | 2011-04-06 Eli Zaretskii <eliz@gnu.org> |
3265 | ||
7c106b1e EZ |
3266 | * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements. |
3267 | ||
973f782d EZ |
3268 | * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs. |
3269 | ||
41cf7d1a | 3270 | 2011-04-06 Paul Eggert <eggert@cs.ucla.edu> |
27ccc379 | 3271 | |
ca23cc88 PE |
3272 | Fix more problems found by GCC 4.6.0's static checks. |
3273 | ||
f390e2d5 PE |
3274 | * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats. |
3275 | ||
42eea0d0 PE |
3276 | * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats. |
3277 | ||
b69769da | 3278 | * lisp.h (message, message_nolog, fatal): Mark as printf-like. |
1e973bc7 | 3279 | |
f9541e84 PE |
3280 | * xdisp.c (vmessage): Mark as a printf-like function. |
3281 | ||
13841b55 PE |
3282 | * term.c (vfatal, maybe_fatal): Mark as printf-like functions. |
3283 | ||
c136c10f PE |
3284 | * sound.c (sound_warning): Don't crash if arg contains a printf format. |
3285 | ||
5e2d4a30 PE |
3286 | * image.c (tiff_error_handler, tiff_warning_handler): Mark as |
3287 | printf-like functions. | |
3288 | (tiff_load): Add casts to remove these marks before passing them | |
3289 | to system-supplied API. | |
3290 | ||
583f48b9 PE |
3291 | * eval.c (Fsignal): Remove excess argument to 'fatal'. |
3292 | ||
b25d760e PE |
3293 | * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int. |
3294 | This avoids several warnings with gcc -Wstrict-overflow. | |
d5efd1d1 PE |
3295 | (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code |
3296 | directly, rather than having caller test rule sign. This avoids | |
3297 | some unnecessary tests. | |
3298 | * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro. | |
3299 | (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This | |
3300 | affects only one use, in DECODE_COMPOSITION_RULE, which is changed. | |
b25d760e | 3301 | |
bc7b6697 | 3302 | * xfont.c (xfont_text_extents): Remove var that was set but not used. |
625a3eb1 | 3303 | (xfont_open): Avoid unnecessary tests. |
bc7b6697 | 3304 | |
27ccc379 PE |
3305 | * composite.c (composition_gstring_put_cache): Use unsigned integer. |
3306 | ||
dcd5c89a PE |
3307 | * composite.h, composite.c (composition_gstring_put_cache): |
3308 | Use EMACS_INT, not int, for length. | |
3309 | ||
b13a45c6 PE |
3310 | * composite.h (COMPOSITION_DECODE_REFS): New macro, |
3311 | breaking out part of COMPOSITION_DECODE_RULE. | |
3312 | (COMPOSITION_DECODE_RULE): Use it. | |
3313 | * composite.c (get_composition_id): Remove unused local vars, | |
3314 | by using the new macro. | |
3315 | ||
1e792e4d PE |
3316 | * textprop.c (set_text_properties_1): Change while to do-while, |
3317 | since the condition is always true at first. | |
3318 | ||
dc6c6455 | 3319 | * intervals.c (graft_intervals_into_buffer): Mark var as used. |
aa86731f PE |
3320 | (interval_deletion_adjustment): Return unsigned value. |
3321 | All uses changed. | |
dc6c6455 | 3322 | |
aba7731a PE |
3323 | * process.c (list_processes_1, create_pty, read_process_output): |
3324 | (exec_sentinel): Remove vars that were set but not used. | |
afd4052b | 3325 | (create_pty): Remove unnecessary "volatile"s. |
bc57d757 | 3326 | (Fnetwork_interface_info): Avoid possibility of int overflow. |
82eaa333 | 3327 | (read_process_output): Do adaptive read buffering even if carryover. |
fe07cdfa | 3328 | (read_process_output): Simplify nbytes computation if buffered. |
aba7731a | 3329 | |
fdfc4bf3 PE |
3330 | * bytecode.c (exec_byte_code): Rename local to avoid shadowing. |
3331 | ||
fca8fe46 | 3332 | * syntax.c (scan_words): Remove var that was set but not used. |
12cbf13f | 3333 | (update_syntax_table): Use unsigned instead of int. |
fca8fe46 | 3334 | |
06a0259a | 3335 | * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs. |
3c346cc3 | 3336 | (lisp_file_lexically_bound_p, read1): Use unsigned instead of int. |
e6eb4e9e | 3337 | (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop. |
06a0259a | 3338 | |
e7b9e80f PE |
3339 | * print.c (print_error_message): Avoid int overflow. |
3340 | ||
56201685 PE |
3341 | * font.c (font_list_entities): Redo for clarity, |
3342 | so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX. | |
3343 | ||
78834453 | 3344 | * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars. |
790771b1 | 3345 | (font_score): Avoid potential overflow in diff calculation. |
78834453 | 3346 | |
0bc0b309 | 3347 | * fns.c (substring_both): Remove var that is set but not used. |
8cd55cb4 | 3348 | (sxhash): Redo loop for clarity and to avoid wraparound warning. |
0bc0b309 | 3349 | |
e610eaca PE |
3350 | * eval.c (funcall_lambda): Rename local to avoid shadowing. |
3351 | ||
b895abce PE |
3352 | * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int. |
3353 | Otherwise, GCC 4.6.0 optimizes the loop check away since the check | |
3354 | can always succeed if overflow has undefined behavior. | |
3355 | ||
1f1d9321 | 3356 | * search.c (boyer_moore, wordify): Remove vars set but not used. |
6f076cc7 | 3357 | (wordify): Omit three unnecessary tests. |
1f1d9321 | 3358 | |
c59478bc PE |
3359 | * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column. |
3360 | All callers changed. This avoids the need for an unused var. | |
3361 | ||
79b73827 PE |
3362 | * casefiddle.c (casify_region): Remove var that is set but not used. |
3363 | ||
a4db5dfe PE |
3364 | * dired.c (file_name_completion): Remove var that is set but not used. |
3365 | ||
43aae36e PE |
3366 | * fileio.c (Finsert_file_contents): Make EOF condition clearer. |
3367 | ||
2a47c44d | 3368 | * fileio.c (Finsert_file_contents): Avoid signed integer overflow. |
163c5f32 | 3369 | (Finsert_file_contents): Remove unnecessary code checking fd. |
2a47c44d | 3370 | |
a37c69bf PE |
3371 | * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes. |
3372 | Check for integer overflow on size calculations. | |
3373 | ||
328ab8e7 PE |
3374 | * buffer.c (Fprevious_overlay_change): Remove var that is set |
3375 | but not used. | |
3376 | ||
e5a2a5cb PE |
3377 | * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt): |
3378 | Remove vars that are set but not used. | |
8d84a6eb | 3379 | (timer_check_2): Don't assume timer-list and idle-timer-list are lists. |
6b043475 | 3380 | (timer_check_2): Mark vars as initialized. |
e5a2a5cb | 3381 | |
a60e5f68 PE |
3382 | * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized. |
3383 | ||
f661cb61 | 3384 | * image.c (lookup_image): Remove var that is set but not used. |
35fa624f | 3385 | (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable. |
f661cb61 | 3386 | |
f0397f5a PE |
3387 | * fontset.c (Finternal_char_font, Ffontset_info): Remove vars |
3388 | that are set but not used. | |
3389 | ||
8664db06 | 3390 | * xfns.c (make_invisible_cursor): Don't return garbage |
03733ee7 | 3391 | if XCreateBitmapFromData fails (Bug#8410). |
8664db06 | 3392 | |
6abdaa4a PE |
3393 | * xselect.c (x_get_local_selection, x_handle_property_notify): |
3394 | Remove vars that are set but not used. | |
3395 | ||
0ce7538d | 3396 | * xfns.c (x_create_tip_frame): Remove var that is set but not used. |
6abdaa4a | 3397 | (make_invisible_cursor): Initialize a possibly-uninitialized variable. |
0ce7538d | 3398 | |
9ae848fc PE |
3399 | * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]: |
3400 | Remove var that is set but not used. | |
0b918413 PE |
3401 | (scroll_bar_windows_size): Now size_t, not int. |
3402 | (x_send_scroll_bar_event): Use size_t, not int, for sizes. | |
3403 | Check for overflow. | |
9ae848fc | 3404 | |
a5a62657 PE |
3405 | * xfaces.c (realize_named_face): Remove vars that are set but not used. |
3406 | (map_tty_color) [!defined MSDOS]: Likewise. | |
3407 | ||
5c5cdd39 PE |
3408 | * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning. |
3409 | ||
66ebf983 PE |
3410 | * coding.c: Remove vars that are set but not used. |
3411 | (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused. | |
3412 | All callers changed. | |
3413 | (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule): | |
3414 | (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5): | |
3415 | (decode_coding_charset): Remove vars that are set but not used. | |
3416 | ||
1be4d761 PE |
3417 | * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var |
3418 | that is set but not used. | |
3419 | ||
47553fa8 PE |
3420 | * print.c (print_object): Remove var that is set but not used. |
3421 | ||
1f7196bf | 3422 | Replace 2 copies of readlink code with 1 gnulib version (Bug#8401). |
d1fdcab7 PE |
3423 | The gnulib version avoids calling malloc in the usual case, |
3424 | and on 64-bit hosts doesn't have some arbitrary 32-bit limits. | |
3425 | * fileio.c (Ffile_symlink_p): Use emacs_readlink. | |
3426 | * filelock.c (current_lock_owner): Likewise. | |
3427 | * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function. | |
3428 | * sysdep.c: Include allocator.h, careadlinkat.h. | |
3429 | (emacs_no_realloc_allocator): New static constant. | |
3430 | (emacs_readlink): New function. | |
fdb61804 PE |
3431 | * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on |
3432 | ../lib/careadlinkat.h. | |
d1fdcab7 | 3433 | |
f84c17c7 SM |
3434 | 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca> |
3435 | ||
3436 | * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the | |
3437 | first non-nil return value). | |
3438 | ||
ef3862ad JD |
3439 | 2011-04-03 Jan Djärv <jan.h.d@swipnet.se> |
3440 | ||
3441 | * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6 | |
3442 | if not defined (Bug#8403). | |
3443 | ||
376a7006 JB |
3444 | 2011-04-02 Juanma Barranquero <lekktu@gmail.com> |
3445 | ||
3446 | * xdisp.c (display_count_lines): Remove parameter `start', | |
3447 | unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed. | |
3448 | (get_char_face_and_encoding): Remove parameter `multibyte_p', | |
3449 | unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed. | |
3450 | (fill_stretch_glyph_string): Remove parameters `row' and `area', | |
3451 | unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk | |
3452 | and thereabouts. All callers changed. | |
3453 | (get_per_char_metric): Remove parameter `f', unused since | |
3454 | 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed. | |
3455 | ||
6ca3801d JM |
3456 | 2011-04-02 Jim Meyering <meyering@redhat.com> |
3457 | ||
3458 | do not dereference NULL upon failed strdup | |
3459 | * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup. | |
3460 | (ns_get_family): Likewise. | |
3461 | ||
d8e2b5ba JB |
3462 | 2011-04-02 Juanma Barranquero <lekktu@gmail.com> |
3463 | ||
3464 | * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment. | |
3465 | ||
8c74fcbd JD |
3466 | 2011-04-02 Jan Djärv <jan.h.d@swipnet.se> |
3467 | ||
3468 | * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or | |
3469 | later (Bug#8403). | |
3470 | ||
7200d79c SM |
3471 | 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca> |
3472 | ||
03408648 | 3473 | Add lexical binding. |
7200d79c | 3474 | |
03408648 SM |
3475 | * window.c (Ftemp_output_buffer_show): New fun. |
3476 | (Fsave_window_excursion): | |
3477 | * print.c (Fwith_output_to_temp_buffer): Move to subr.el. | |
3478 | ||
3479 | * lread.c (lisp_file_lexically_bound_p): New function. | |
3480 | (Fload): Bind Qlexical_binding. | |
3481 | (readevalloop): Remove `evalfun' arg. | |
3482 | Bind Qinternal_interpreter_environment. | |
3483 | (Feval_buffer): Bind Qlexical_binding. | |
3484 | (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard): | |
3485 | Mark as dynamic. | |
3486 | (syms_of_lread): Declare `lexical-binding'. | |
3487 | ||
3488 | * lisp.h (struct Lisp_Symbol): New field `declared_special'. | |
3489 | ||
3490 | * keyboard.c (eval_dyn): New fun. | |
3491 | (menu_item_eval_property): Use it. | |
ca105506 SM |
3492 | |
3493 | * image.c (parse_image_spec): Use Ffunctionp. | |
ca105506 | 3494 | |
03408648 SM |
3495 | * fns.c (concat, mapcar1): Accept byte-code-functions. |
3496 | ||
3497 | * eval.c (Fsetq): Handle lexical vars. | |
3498 | (Fdefun, Fdefmacro, Ffunction): Make closures when needed. | |
3499 | (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic. | |
3500 | (FletX, Flet): Obey lexical binding. | |
3501 | (Fcommandp): Handle closures. | |
3502 | (Feval): New `lexical' arg. | |
3503 | (eval_sub): New function extracted from Feval. Use it almost | |
3504 | everywhere where Feval was used. Look up vars in lexical env. | |
3505 | Handle closures. | |
3506 | (Ffunctionp): Move from subr.el. | |
3507 | (Ffuncall): Handle closures. | |
3508 | (apply_lambda): Remove `eval_flags'. | |
3509 | (funcall_lambda): Handle closures and new byte-code-functions. | |
3510 | (Fspecial_variable_p): New function. | |
3511 | (syms_of_eval): Initialize the Vinternal_interpreter_environment var, | |
3512 | but without exporting it to Lisp. | |
23aba0ea | 3513 | |
23aba0ea | 3514 | * doc.c (Fdocumentation, store_function_docstring): |
03408648 | 3515 | * data.c (Finteractive_form): Handle closures. |
23aba0ea | 3516 | |
03408648 SM |
3517 | * callint.c (Fcall_interactively): Preserve lexical-binding mode for |
3518 | interactive spec. | |
ba83908c | 3519 | |
04f2d78b CB |
3520 | * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): |
3521 | New byte-codes. | |
03408648 SM |
3522 | (exec_byte_code): New function extracted from Fbyte_code to handle new |
3523 | calling convention for byte-code-functions. Add new byte-codes. | |
ba83908c | 3524 | |
03408648 | 3525 | * buffer.c (defvar_per_buffer): Set new `declared_special' field. |
e2abe5a1 | 3526 | |
03408648 | 3527 | * alloc.c (Fmake_symbol): Init new `declared_special' field. |
e2abe5a1 | 3528 | |
e2abce01 JB |
3529 | 2011-03-31 Juanma Barranquero <lekktu@gmail.com> |
3530 | ||
3531 | * xdisp.c (redisplay_internal): Fix prototype. | |
3532 | ||
63696a73 | 3533 | 2011-03-31 Eli Zaretskii <eliz@gnu.org> |
09725d26 | 3534 | |
63696a73 | 3535 | * xdisp.c (SCROLL_LIMIT): New macro. |
04f2d78b CB |
3536 | (try_scrolling): Use it when setting scroll_limit. |
3537 | Limit scrolling to 100 screen lines. | |
63696a73 EZ |
3538 | (redisplay_window): Even when falling back on "recentering", |
3539 | position point in the window according to scroll-conservatively, | |
3540 | scroll-margin, and scroll-*-aggressively variables. (Bug#6671) | |
3541 | ||
3542 | (try_scrolling): When point is above the window, allow searching | |
3543 | as far as scroll_max, or one screenful, to compute vertical | |
3544 | distance from PT to the scroll margin position. This prevents | |
3545 | try_scrolling from unnecessarily failing when | |
3546 | scroll-conservatively is set to a value slightly larger than the | |
3547 | window height. Clean up the case of PT below the margin at bottom | |
3548 | of window: scroll_max can no longer be INT_MAX. When aggressive | |
3549 | scrolling is in use, don't let point enter the opposite scroll | |
3550 | margin as result of the scroll. | |
3551 | (syms_of_xdisp) <scroll-conservatively>: Document the | |
09725d26 EZ |
3552 | threshold of 100 lines for never-recentering scrolling. |
3553 | ||
e4cc2dfc JB |
3554 | 2011-03-31 Juanma Barranquero <lekktu@gmail.com> |
3555 | ||
3556 | * dispextern.h (move_it_by_lines): | |
3557 | * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused | |
3558 | since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed. | |
3559 | (message_log_check_duplicate): Remove parameters `prev_bol' and | |
3560 | `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed. | |
3561 | (redisplay_internal): Remove parameter `preserve_echo_area', | |
3562 | unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed. | |
3563 | ||
3564 | * indent.c (Fvertical_motion): | |
3565 | * window.c (window_scroll_pixel_based, Frecenter): | |
3566 | Don't pass `need_y_p' to `move_it_by_lines'. | |
3567 | ||
1c470562 SM |
3568 | 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca> |
3569 | ||
44f230aa SM |
3570 | * eval.c (struct backtrace): Don't cheat with negative numbers, but do |
3571 | steal a few bits to be more compact. | |
3572 | (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace): | |
3573 | Remove unneeded casts. | |
3574 | ||
1c470562 SM |
3575 | * bytecode.c (Fbyte_code): CAR and CDR can GC. |
3576 | ||
888adce9 ZK |
3577 | 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change) |
3578 | ||
3579 | * keyboard.c (Fexecute_extended_command): Do log the "suggest key | |
3580 | binding" message (bug#7967). | |
3581 | ||
f838ed7b PE |
3582 | 2011-03-30 Paul Eggert <eggert@cs.ucla.edu> |
3583 | ||
77861b95 PE |
3584 | Fix more problems found by GCC 4.6.0's static checks. |
3585 | ||
de6dbc14 PE |
3586 | * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]: |
3587 | Remove unused local var. | |
3588 | ||
f838ed7b PE |
3589 | * editfns.c (Fmessage_box): Remove unused local var. |
3590 | ||
792c7b2b PE |
3591 | * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs): |
3592 | (note_mode_line_or_margin_highlight, note_mouse_highlight): | |
3593 | Omit unused local vars. | |
c499e557 | 3594 | * window.c (shrink_windows): Omit unused local var. |
b01a1c29 | 3595 | * menu.c (digest_single_submenu): Omit unused local var. |
0bc32927 PE |
3596 | * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]: |
3597 | Omit unused local var. | |
3598 | ||
ba0165e1 PE |
3599 | * keyboard.c (parse_modifiers_uncached, parse_modifiers): |
3600 | Don't assume string length fits in int. | |
32ad8845 | 3601 | (keyremap_step, read_key_sequence): Use size_t for sizes. |
48011560 | 3602 | (read_key_sequence): Don't check last_real_key_start redundantly. |
ba0165e1 | 3603 | |
3c59b4c9 PE |
3604 | * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA |
3605 | instead of alloca (Bug#8344). | |
3606 | ||
a3eed478 | 3607 | * eval.c (Fbacktrace): Don't assume nargs fits in int. |
5d5d959d | 3608 | (Fbacktrace_frame): Don't assume nframes fits in int. |
a3eed478 | 3609 | |
eb4d412d PE |
3610 | * syntax.c (scan_sexps_forward): Avoid pointer wraparound. |
3611 | ||
1658b401 PE |
3612 | * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow |
3613 | concerns. | |
3614 | ||
3615 | * term.c (produce_glyphless_glyph): Remove unnecessary test. | |
3616 | ||
3617 | * cm.c (calccost): Turn while-do into do-while, for clarity. | |
44f730c8 | 3618 | |
9a2c6e05 PE |
3619 | * keyboard.c (syms_of_keyboard): Use the same style as later |
3620 | in this function when indexing through an array. This also | |
3621 | works around GCC bug 48267. | |
3622 | ||
03d0a109 PE |
3623 | * image.c (tiff_load): Fix off-by-one image count (Bug#8336). |
3624 | ||
44f730c8 PE |
3625 | * xselect.c (x_check_property_data): Return correct size (Bug#8335). |
3626 | ||
fe75f926 PE |
3627 | * chartab.c (sub_char_table_ref_and_range): Redo for slight |
3628 | efficiency gain, and to bypass a gcc -Wstrict-overflow warning. | |
3629 | ||
ffa8c828 PE |
3630 | * keyboard.c, keyboard.h (num_input_events): Now size_t. |
3631 | This avoids undefined behavior on integer overflow, and is a bit | |
3632 | more convenient anyway since it is compared to a size_t variable. | |
3633 | ||
c5101a77 PE |
3634 | Variadic C functions now count arguments with size_t, not int. |
3635 | This avoids an unnecessary limitation on 64-bit machines, which | |
3636 | caused (substring ...) to crash on large vectors (Bug#8344). | |
3637 | * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int. | |
3638 | (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise. | |
77861b95 | 3639 | All variadic functions and their callers changed accordingly. |
c5101a77 PE |
3640 | (struct gcpro.nvars): Now size_t, not int. All uses changed. |
3641 | * data.c (arith_driver, float_arith_driver): Likewise. | |
3642 | * editfns.c (general_insert_function): Likewise. | |
3643 | * eval.c (struct backtrace.nargs, interactive_p) | |
3644 | (internal_condition_case_n, run_hook_with_args, apply_lambda) | |
3645 | (funcall_lambda, mark_backtrace): Likewise. | |
3646 | * fns.c (concat): Likewise. | |
3647 | * frame.c (x_set_frame_parameters): Likewise. | |
3648 | * fns.c (get_key_arg): Now accepts and returns size_t, and returns | |
3649 | 0 if not found, not -1. All callers changed. | |
3650 | ||
dd3f25f7 PE |
3651 | * alloc.c (garbage_collect): Don't assume stack size fits in int. |
3652 | (stack_copy_size): Now size_t, not int. | |
3653 | (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0. | |
3654 | ||
461c2ab9 JB |
3655 | 2011-03-28 Juanma Barranquero <lekktu@gmail.com> |
3656 | ||
3657 | * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end', | |
3658 | unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org. | |
3659 | All callers changed. | |
3660 | ||
3661 | * lisp.h (multibyte_char_to_unibyte): | |
3662 | * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl', | |
3663 | unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org. | |
3664 | * character.h (CHAR_TO_BYTE8): | |
3665 | * cmds.c (internal_self_insert): | |
3666 | * editfns.c (general_insert_function): | |
3667 | * keymap.c (push_key_description): | |
3668 | * search.c (Freplace_match): | |
3669 | * xdisp.c (message_dolog, set_message_1): All callers changed. | |
3670 | ||
f6d62986 SM |
3671 | 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca> |
3672 | ||
3673 | * keyboard.c (safe_run_hook_funcall): New function. | |
3674 | (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error, | |
3675 | don't set the hook to nil, but remove the offending function instead. | |
3676 | (Qcommand_hook_internal): Remove, unused. | |
3677 | (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define | |
3678 | Vcommand_hook_internal. | |
3679 | ||
3680 | * eval.c (enum run_hooks_condition): Remove. | |
3681 | (funcall_nil, funcall_not): New functions. | |
3682 | (run_hook_with_args): Call each function through a `funcall' argument. | |
3683 | Remove `cond' argument, now redundant. | |
3684 | (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success) | |
3685 | (Frun_hook_with_args_until_failure): Adjust accordingly. | |
3686 | (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions. | |
3687 | ||
1db5b1ad JB |
3688 | 2011-03-28 Juanma Barranquero <lekktu@gmail.com> |
3689 | ||
3690 | * dispextern.h (string_buffer_position): Remove declaration. | |
3691 | ||
3692 | * print.c (strout): Remove parameter `multibyte', unused since | |
3693 | 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed. | |
3694 | ||
3695 | * search.c (boyer_moore): Remove parameters `len', `pos' and `lim', | |
3696 | never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org. | |
3697 | All callers changed. | |
3698 | ||
3699 | * w32.c (_wsa_errlist): Use braces for struct initializers. | |
3700 | ||
3701 | * xdisp.c (string_buffer_position_lim): Remove parameter `w', | |
3702 | never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org. | |
3703 | All callers changed. | |
3704 | (string_buffer_position): Likewise. Also, make static (it's never | |
3705 | used outside xdisp.c). | |
3706 | (cursor_row_p): Remove parameter `w', unused since | |
3707 | 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed. | |
3708 | (decode_mode_spec): Remove parameter `precision', introduced during | |
3709 | Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used. | |
3710 | All callers changed. | |
3711 | ||
5ffb62aa JD |
3712 | 2011-03-27 Jan Djärv <jan.h.d@swipnet.se> |
3713 | ||
3714 | * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar. | |
3715 | ||
461c2ab9 | 3716 | 2011-03-27 Anders Lindgren <andlind@gmail.com> |
f0a1382a JD |
3717 | |
3718 | * nsterm.m (ns_menu_bar_is_hidden): New variable. | |
3719 | (ns_constrain_all_frames, ns_menu_bar_should_be_hidden) | |
3720 | (ns_update_auto_hide_menu_bar): New functions. | |
3721 | (ns_update_begin): Call ns_update_auto_hide_menu_bar. | |
3722 | (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and | |
3723 | ns_constrain_all_frames. | |
3724 | (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden. | |
3725 | (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil. | |
3726 | ||
5c380ffb JD |
3727 | 2011-03-27 Jan Djärv <jan.h.d@swipnet.se> |
3728 | ||
3729 | * nsmenu.m (runDialogAt): Remove argument to timer_check. | |
3730 | ||
9af30bdf GM |
3731 | 2011-03-27 Glenn Morris <rgm@gnu.org> |
3732 | ||
3733 | * syssignal.h: Replace RETSIGTYPE with void. | |
3734 | * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c: | |
3735 | * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c: | |
3736 | Replace SIGTYPE with void everywhere. | |
3737 | * s/usg5-4-common.h (SIGTYPE): Remove definition. | |
3738 | * s/template.h (SIGTYPE): Remove commented out definition. | |
3739 | ||
e2abce01 JB |
3740 | 2011-03-26 Eli Zaretskii <eliz@gnu.org> |
3741 | ||
3742 | * xdisp.c (redisplay_window): Don't check buffer's clip_changed | |
3743 | flag as a prerequisite for invoking try_scrolling. (Bug#6671) | |
3744 | ||
f868cd8a JB |
3745 | 2011-03-26 Juanma Barranquero <lekktu@gmail.com> |
3746 | ||
59eb0929 JB |
3747 | * w32.c (read_unc_volume): Use parameter `henum', instead of |
3748 | global variable `wget_enum_handle'. | |
3749 | ||
3750 | * keymap.c (describe_vector): Remove parameters `indices' and | |
3751 | `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org. | |
3752 | (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'. | |
3753 | ||
f868cd8a JB |
3754 | * keyboard.h (timer_check, show_help_echo): Remove unused parameters. |
3755 | ||
3756 | * keyboard.c (timer_check): Remove parameter `do_it_now', | |
3757 | unused since 1996-04-12T06:01:29Z!rms@gnu.org. | |
3758 | (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo', | |
3759 | unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca. | |
3760 | ||
3761 | * keyboard.c (read_char): | |
3762 | * w32menu.c (w32_menu_display_help): | |
3763 | * xmenu.c (show_help_event, menu_help_callback): | |
3764 | Adjust calls to `show_help_echo'. | |
3765 | ||
3766 | * gtkutil.c (xg_maybe_add_timer): | |
3767 | * keyboard.c (readable_events): | |
3768 | * process.c (wait_reading_process_output): | |
3769 | * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'. | |
3770 | ||
3771 | * insdel.c (adjust_markers_gap_motion): | |
3772 | Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org. | |
3773 | (gap_left, gap_right): Don't call it. | |
3774 | ||
2ecf6fdb CY |
3775 | 2011-03-25 Chong Yidong <cyd@stupidchicken.com> |
3776 | ||
3777 | * xdisp.c (handle_fontified_prop): Discard changes to clip_changed | |
3778 | incurred during fontification. | |
3779 | ||
6b1f9ba4 JB |
3780 | 2011-03-25 Juanma Barranquero <lekktu@gmail.com> |
3781 | ||
3782 | * buffer.c (defvar_per_buffer): Remove unused parameter `doc'. | |
3783 | (DEFVAR_PER_BUFFER): Don't pass it. | |
3784 | ||
3785 | * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'. | |
3786 | (scrolling_window): Don't pass it. | |
3787 | ||
0f4a96b5 JB |
3788 | 2011-03-25 Juanma Barranquero <lekktu@gmail.com> |
3789 | ||
3790 | * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef. | |
3791 | ||
3792 | * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len' | |
3793 | and `suffix'. | |
3794 | (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration | |
3795 | of variables specific to SELinux and computation of `encoded_absname'. | |
3796 | ||
3797 | * image.c (XPutPixel): Remove unused variable `height'. | |
3798 | ||
3799 | * keyboard.c (make_lispy_event): Remove unused variable `hpos'. | |
3800 | ||
3801 | * unexw32.c (get_section_info): Remove unused variable `section'. | |
3802 | ||
3803 | * w32.c (stat): Remove unused variables `drive_root' and `devtype'. | |
3804 | (system_process_attributes): Remove unused variable `sess'. | |
3805 | (sys_read): Remove unused variable `err'. | |
3806 | ||
3807 | * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef. | |
3808 | (w32_wnd_proc): Remove unused variable `isdead'. | |
3809 | (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef. | |
3810 | (Fx_server_max_request_size): Remove unused variable `dpyinfo'. | |
3811 | (x_create_tip_frame): Remove unused variable `tem'. | |
3812 | ||
3813 | * w32inevt.c (w32_console_read_socket): | |
3814 | Remove unused variable `no_events'. | |
3815 | ||
3816 | * w32term.c (x_draw_composite_glyph_string_foreground): | |
3817 | Remove unused variable `width'. | |
3818 | ||
1149507c JB |
3819 | 2011-03-24 Juanma Barranquero <lekktu@gmail.com> |
3820 | ||
3821 | * w32term.c (x_set_glyph_string_clipping): | |
3822 | Don't pass uninitialized region to CombineRgn. | |
3823 | ||
9c88f339 JB |
3824 | 2011-03-23 Juanma Barranquero <lekktu@gmail.com> |
3825 | ||
3826 | * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'. | |
3827 | (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer. | |
3828 | (Fx_close_connection): Remove unused variable `i'. | |
3829 | ||
3830 | * w32font.c (w32font_draw): Return number of glyphs. | |
3831 | (w32font_open_internal): Remove unused variable `i'. | |
3832 | (w32font_driver): Add missing initializer. | |
3833 | ||
3834 | * w32menu.c (utf8to16): Remove unused variable `utf16'. | |
3835 | (fill_in_menu): Remove unused variable `items_added'. | |
3836 | ||
3837 | * w32term.c (last_mouse_press_frame): Remove static global variable. | |
3838 | (w32_clip_to_row): Remove unused variable `f'. | |
3839 | (x_delete_terminal): Remove unused variable `i'. | |
3840 | ||
3841 | * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'. | |
3842 | (NOTHING): Remove unused static global variable. | |
3843 | (uniscribe_check_otf): Remove unused variable `table'. | |
3844 | (uniscribe_font_driver): Add missing initializers. | |
3845 | ||
dee091a3 JD |
3846 | 2011-03-23 Julien Danjou <julien@danjou.info> |
3847 | ||
3848 | * term.c (Fsuspend_tty, Fresume_tty): | |
3849 | * minibuf.c (read_minibuf, run_exit_minibuf_hook): | |
3850 | * window.c (temp_output_buffer_show): | |
3851 | * insdel.c (signal_before_change): | |
3852 | * frame.c (Fhandle_switch_frame): | |
3853 | * fileio.c (Fdo_auto_save): | |
3854 | * emacs.c (Fkill_emacs): | |
3855 | * editfns.c (save_excursion_restore): | |
3856 | * cmds.c (internal_self_insert): | |
3857 | * callint.c (Fcall_interactively): | |
3858 | * buffer.c (Fkill_all_local_variables): | |
3859 | * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1): | |
3860 | Use Frun_hooks. | |
0f4a96b5 | 3861 | (command_loop_1): Use Frun_hooks. Call safe_run_hooks |
dee091a3 JD |
3862 | unconditionnaly since it does the check itself. |
3863 | ||
2c520ab5 | 3864 | 2011-03-23 Paul Eggert <eggert@cs.ucla.edu> |
f0641eff | 3865 | |
c9c49752 PE |
3866 | Fix more problems found by GCC 4.5.2's static checks. |
3867 | ||
8abc3f12 PE |
3868 | * coding.c (encode_coding_raw_text): Avoid unnecessary test |
3869 | the first time through the loop, since we know p0 < p1 then. | |
3870 | This also avoids a gcc -Wstrict-overflow warning. | |
3871 | ||
a2d26660 PE |
3872 | * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow |
3873 | leading to a memory leak, possible in functions like | |
3874 | load_charset_map_from_file that can allocate an unbounded number | |
b12ef411 | 3875 | of objects (Bug#8318). |
a2d26660 | 3876 | |
916c72e9 PE |
3877 | * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes |
3878 | that could (at least in theory) be that large. | |
3879 | ||
19ab8a18 PE |
3880 | * xdisp.c (message_log_check_duplicate): Return unsigned long, not int. |
3881 | This is less likely to overflow, and avoids undefined behavior if | |
3882 | overflow does occur. All callers changed. Use strtoul to scan | |
3883 | for the unsigned long integer. | |
b7cbbd6f PE |
3884 | (pint2hrstr): Simplify and tune code slightly. |
3885 | This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow. | |
19ab8a18 | 3886 | |
f0641eff PE |
3887 | * scroll.c (do_scrolling): Work around GCC bug 48228. |
3888 | See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>. | |
3889 | ||
7f650bb9 PE |
3890 | * frame.c (Fmodify_frame_parameters): Simplify loop counter. |
3891 | This also avoids a warning with gcc -Wstrict-overflow. | |
39f5e519 PE |
3892 | (validate_x_resource_name): Simplify count usage. |
3893 | This also avoids a warning with gcc -Wstrict-overflow. | |
7f650bb9 | 3894 | |
37dd57d1 PE |
3895 | * fileio.c (Fcopy_file): Report error if fchown or fchmod |
3896 | fail (Bug#8306). | |
81e56e61 | 3897 | |
699979fc | 3898 | * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303). |
dc1ca6a8 | 3899 | |
401bf9b4 PE |
3900 | * process.c (Fmake_network_process): Use socklen_t, not int, |
3901 | where POSIX says socklen_t is required in portable programs. | |
3902 | This fixes a porting bug on hosts like 64-bit HP-UX, where | |
591b2973 | 3903 | socklen_t is wider than int (Bug#8277). |
401bf9b4 PE |
3904 | (Fmake_network_process, server_accept_connection): |
3905 | (wait_reading_process_output, read_process_output): | |
3906 | Likewise. | |
3907 | ||
b93aacde PE |
3908 | * process.c: Rename or move locals to avoid shadowing. |
3909 | (list_processes_1, Fmake_network_process): | |
3910 | (read_process_output_error_handler, exec_sentinel_error_handler): | |
3911 | Rename or move locals. | |
4dc343ee | 3912 | (Fmake_network_process): Define label "retry_connect" only if needed. |
0da49335 | 3913 | (Fnetwork_interface_info): Fix pointer signedness. |
f990b4e5 | 3914 | (process_send_signal): Add cast to avoid pointer signedness problem. |
7b808126 | 3915 | (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros. |
c939f91b | 3916 | (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298). |
b93aacde | 3917 | |
af8a867c | 3918 | Make tparam.h and terminfo.c consistent. |
44f230aa SM |
3919 | * cm.c (tputs, tgoto, BC, UP): Remove extern decls. |
3920 | Include tparam.h instead, since it declares them. | |
af8a867c PE |
3921 | * cm.h (PC): Remove extern decl; tparam.h now does this. |
3922 | * deps.mk (cm.o, terminfo.o): Depend on tparam.h. | |
3923 | * terminfo.c: Include tparam.h, to check interfaces. | |
3924 | (tparm): Make 1st arg a const pointer in decl. Put it at top level. | |
3925 | (tparam): Adjust signature to match interface in tparam.h; | |
3926 | this removes some undefined behavior. Check that outstring and len | |
3927 | are zero, which they always are with Emacs. | |
3928 | * tparam.h (PC, BC, UP): New extern decls. | |
3929 | ||
0248044d | 3930 | * xftfont.c (xftfont_shape): Now static, and defined only if needed. |
001a7ab4 | 3931 | (xftfont_open): Rename locals to avoid shadowing. |
0248044d | 3932 | |
8ff096c1 | 3933 | * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness. |
a00924bb PE |
3934 | (ftfont_otf_capability, ftfont_shape): Omit decls if not needed. |
3935 | (OTF_TAG_SYM): Omit macro if not needed. | |
e932860f | 3936 | (ftfont_list): Remove unused local. |
49eaafba PE |
3937 | (get_adstyle_property, ftfont_pattern_entity): |
3938 | (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point): | |
3939 | Rename locals to avoid shadowing. | |
8ff096c1 | 3940 | |
e2be39f6 PE |
3941 | * xfont.c (xfont_list_family): Mark var as initialized. |
3942 | ||
c9735e30 PE |
3943 | * xml.c (make_dom): Now static. |
3944 | ||
8f5201ae PE |
3945 | * composite.c (composition_compute_stop_pos): Rename local to |
3946 | avoid shadowing. | |
b246f932 PE |
3947 | (composition_reseat_it): Remove unused locals. |
3948 | (find_automatic_composition, composition_adjust_point): Likewise. | |
80e079b2 | 3949 | (composition_update_it): Mark var as initialized. |
11b61122 PE |
3950 | (find_automatic_composition): Mark vars as initialized, |
3951 | with a FIXME (Bug#8290). | |
8f5201ae | 3952 | |
760fbc2c PE |
3953 | character.h: Rename locals to avoid shadowing. |
3954 | * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE): | |
3955 | (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE): | |
3956 | (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS): | |
3957 | (BUF_DEC_POS): Be more systematic about renaming local temporaries | |
3958 | to avoid shadowing. | |
3959 | ||
ff08eb85 PE |
3960 | * textprop.c (property_change_between_p): Remove; unused. |
3961 | ||
fc7bf025 PE |
3962 | * intervals.c (interval_start_pos): Now static. |
3963 | ||
235d7abc PE |
3964 | * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else". |
3965 | ||
44f230aa SM |
3966 | * atimer.c (start_atimer, append_atimer_lists, set_alarm): |
3967 | Rename locals to avoid shadowing. | |
3e7d6594 | 3968 | |
50060332 PE |
3969 | * sound.c (wav_play, au_play, Fplay_sound_internal): |
3970 | Fix pointer signedness. | |
d01f234b | 3971 | (alsa_choose_format): Remove unused local var. |
c83b8872 PE |
3972 | (wav_play): Initialize a variable to 0, to prevent undefined |
3973 | behavior (Bug#8278). | |
50060332 | 3974 | |
c4fc4e30 PE |
3975 | * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing. |
3976 | ||
918436ed PE |
3977 | * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes. |
3978 | ||
c939f91b PE |
3979 | * callproc.c (Fcall_process): Use 'volatile' to avoid vfork |
3980 | clobbering (Bug#8298). | |
b9c7f648 PE |
3981 | * sysdep.c (sys_subshell): Likewise. |
3982 | Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out. | |
7e9123a2 | 3983 | |
6bd8c144 PE |
3984 | * lisp.h (child_setup): Now NO_RETURN unless DOS_NT. |
3985 | This should get cleaned up, so that child_setup has the | |
3986 | same signature on all platforms. | |
3987 | ||
7710357c | 3988 | * callproc.c (call_process_cleanup): Now static. |
cb1d0ef7 | 3989 | (relocate_fd): Rename locals to avoid shadowing. |
7710357c | 3990 | |
c59da222 CY |
3991 | 2011-03-22 Chong Yidong <cyd@stupidchicken.com> |
3992 | ||
3993 | * xterm.c (x_clear_frame): Remove XClearWindow call. This appears | |
3994 | not to be necessary, and produces flickering. | |
3995 | ||
66b87493 GM |
3996 | 2011-03-20 Glenn Morris <rgm@gnu.org> |
3997 | ||
3998 | * config.in: Remove file. | |
3999 | ||
45b6f6d5 JB |
4000 | 2011-03-20 Juanma Barranquero <lekktu@gmail.com> |
4001 | ||
4002 | * minibuf.c (Vcompleting_read_function): Don't declare, global variables | |
4003 | are now in src/globals.h. | |
4004 | (syms_of_minibuf): Remove spurious & from previous change. | |
4005 | ||
3ec03f7e LL |
4006 | 2011-03-20 Leo <sdl.web@gmail.com> |
4007 | ||
4008 | * minibuf.c (completing-read-function): New variable. | |
4009 | (completing-read-default): Rename from completing-read. | |
4010 | (completing-read): Call completing-read-function. | |
4011 | ||
b14e3e21 CY |
4012 | 2011-03-19 Juanma Barranquero <lekktu@gmail.com> |
4013 | ||
4014 | * xfaces.c (Fx_load_color_file): | |
4015 | Read color file from absolute filename (bug#8250). | |
4016 | ||
f2b726e6 JB |
4017 | 2011-03-19 Juanma Barranquero <lekktu@gmail.com> |
4018 | ||
4019 | * makefile.w32-in: Update dependencies. | |
4020 | ||
09f6ff02 EZ |
4021 | 2011-03-17 Eli Zaretskii <eliz@gnu.org> |
4022 | ||
4023 | * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h. | |
4024 | ||
29a6015a PE |
4025 | 2011-03-17 Paul Eggert <eggert@cs.ucla.edu> |
4026 | ||
a3a6c54e PE |
4027 | Fix more problems found by GCC 4.5.2's static checks. |
4028 | ||
b766f867 PE |
4029 | * process.c (make_serial_process_unwind, send_process_trap): |
4030 | (sigchld_handler): Now static. | |
4031 | ||
be02381c PE |
4032 | * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars. |
4033 | That way, the code declares only the vars that it needs. | |
4034 | * s/aix4-2.h (PTY_ITERATION): Declare iteration vars. | |
4035 | * s/cygwin.h (PTY_ITERATION): Likewise. | |
4036 | * s/darwin.h (PTY_ITERATION): Likewise. | |
4037 | * s/gnu-linux.h (PTY_ITERATION): Likewise. | |
4038 | ||
57048744 PE |
4039 | * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling. |
4040 | * process.c (allocate_pty): Don't declare stb unless it's needed. | |
4041 | ||
7914961c | 4042 | * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else". |
615f2d59 PE |
4043 | (CONSTANTLIM): Remove; unused. |
4044 | (METER_CODE, Bscan_buffer, Bread_char, Bset_mark): | |
4045 | Define only if needed. | |
7914961c | 4046 | |
b3967b18 PE |
4047 | * unexelf.c (unexec): Name an expression, |
4048 | to avoid gcc -Wbad-function-cast warning. | |
9ae71512 PE |
4049 | Use a different way to cause a compilation error if anyone uses |
4050 | n rather than nn, a way that does not involve shadowing. | |
73366a00 | 4051 | (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused. |
b3967b18 | 4052 | |
29a6015a PE |
4053 | * deps.mk (unexalpha.o): Remove; unused. |
4054 | ||
43cfc33e | 4055 | New file unexec.h, the (simple) interface for unexec (Bug#8267). |
7feda0d2 | 4056 | * unexec.h: New file. |
ce701a33 PE |
4057 | * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o): |
4058 | (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o): | |
4059 | Depend on unexec.h. | |
4060 | * emacs.c [!defined CANNOT_DUMP]: Include unexec.h. | |
4061 | * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c: | |
4062 | * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h. | |
381259ef | 4063 | Change as necessary to match prototype in unexec.h. |
ce701a33 | 4064 | |
01f44d5a PE |
4065 | * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid |
4066 | shadowing. | |
4f63c6bb | 4067 | (back_comment, skip_chars): Mark vars as initialized. |
01f44d5a | 4068 | |
a6670b0b PE |
4069 | * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS): |
4070 | Rename locals to avoid shadowing. | |
4071 | ||
cef2010d | 4072 | * lread.c (read1): Rewrite so as not to use empty "else". |
0902fe45 | 4073 | (Fload, readevalloop, read1): Rename locals to avoid shadowing. |
cef2010d | 4074 | |
d4d7173a PE |
4075 | * print.c (Fredirect_debugging_output): Fix pointer signedess. |
4076 | ||
f08b802a PE |
4077 | * lisp.h (debug_output_compilation_hack): Add decl here, to avoid |
4078 | warning when compiling print.c. | |
4079 | ||
3ddb0639 PE |
4080 | * font.c (font_unparse_fcname): Abort in an "impossible" situation |
4081 | instead of using an uninitialized var. | |
5ad03b97 | 4082 | (font_sort_entities): Mark var as initialized. |
3ddb0639 | 4083 | |
170a2692 PE |
4084 | * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing. |
4085 | ||
e663c700 PE |
4086 | * font.c (font_unparse_xlfd): Don't mix pointers to variables with |
4087 | pointers to constants. | |
89bc529a | 4088 | (font_parse_fcname): Remove unused vars. |
7b81e2d0 | 4089 | (font_delete_unmatched): Now static. |
ea838e10 | 4090 | (font_get_spec): Remove; unused. |
13a547c6 PE |
4091 | (font_style_to_value, font_prop_validate_style, font_unparse_fcname): |
4092 | (font_update_drivers, Ffont_get_glyphs, font_add_log): | |
4093 | Rename or move locals to avoid shadowing. | |
e663c700 | 4094 | |
2a80c887 | 4095 | * fns.c (require_nesting_list, require_unwind): Now static. |
612f56df | 4096 | (Ffillarray): Rename locals to avoid shadowing. |
2a80c887 | 4097 | |
1384fa33 | 4098 | * floatfns.c (domain_error2): Define only if needed. |
a885e2ed | 4099 | (Ffrexp, Fldexp): Rename locals to avoid shadowing. |
1384fa33 | 4100 | |
8b2c52e9 PE |
4101 | * alloc.c (mark_backtrace): Move decl from here ... |
4102 | * lisp.h: ... to here, so that it can be checked. | |
4103 | ||
475545b5 | 4104 | * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static. |
d28a2170 | 4105 | (Fdefvar): Rewrite so as not to use empty "else". |
cfcbfb1a PE |
4106 | (lisp_indirect_variable): Name an expression, |
4107 | to avoid gcc -Wbad-function-cast warning. | |
1faed8ae | 4108 | (Fdefvar): Rename locals to avoid shadowing. |
475545b5 | 4109 | |
b1349114 | 4110 | * callint.c (quotify_arg, quotify_args): Now static. |
a3e8cbda | 4111 | (Fcall_interactively): Rename locals to avoid shadowing. |
b0e80955 | 4112 | Use const pointer when appropriate. |
b1349114 | 4113 | |
a2928364 PE |
4114 | * lisp.h (get_system_name, get_operating_system_release): |
4115 | Move decls here, to check interfaces. | |
4116 | * process.c (get_operating_system_release): Move decl to lisp.h. | |
4117 | * xrdb.c (get_system_name): Likewise. | |
63c5d10b PE |
4118 | * editfns.c (init_editfns, Fuser_login_name, Fuser_uid): |
4119 | (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts, | |
4120 | some of which prompt warnings from gcc -Wbad-function-cast. | |
545b49b4 PE |
4121 | (Fformat_time_string, Fencode_time, Finsert_char): |
4122 | (Ftranslate_region_internal, Fformat): | |
4123 | Rename or remove local vars to avoid shadowing. | |
9710023e | 4124 | (Ftranslate_region_internal): Mark var as initialized. |
63c5d10b | 4125 | |
a415e694 PE |
4126 | * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to |
4127 | avoid shadowing. | |
4128 | ||
8ef4622d PE |
4129 | * lisp.h (eassert): Check that the argument compiles, even if |
4130 | ENABLE_CHECKING is not defined. | |
4131 | ||
946f9a5b PE |
4132 | * data.c (Findirect_variable): Name an expression, to avoid |
4133 | gcc -Wbad-function-cast warning. | |
112396d6 | 4134 | (default_value, arithcompare, arith_driver, arith_error): Now static. |
b9b84fa9 | 4135 | (store_symval_forwarding): Rename local to avoid shadowing. |
44f230aa SM |
4136 | (Fmake_variable_buffer_local, Fmake_local_variable): |
4137 | Mark variables as initialized. | |
52746918 | 4138 | (do_blv_forwarding, do_symval_forwarding): Remove; unused. |
946f9a5b | 4139 | |
e5aab7e7 | 4140 | * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST. |
ae35e756 PE |
4141 | (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect): |
4142 | Rename locals to avoid shadowing. | |
dff45157 PE |
4143 | (mark_stack): Move local variables into the #ifdef region where |
4144 | they're used. | |
7bc26fdb PE |
4145 | (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if |
4146 | ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not | |
4147 | needed otherwise. | |
4148 | (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS. | |
4149 | (GC_STRING_CHARS): Remove; not used. | |
d40d4be1 | 4150 | (Fmemory_limit): Cast sbrk's returned value to char *. |
ae35e756 | 4151 | |
e5aab7e7 PE |
4152 | * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this |
4153 | avoids undefined behavior in theory. | |
4154 | ||
4da60324 PE |
4155 | * regex.c (IF_LINT): Add defn, for benefit of ../lib-src. |
4156 | ||
88043301 PE |
4157 | Use functions, not macros, for up- and down-casing (Bug#8254). |
4158 | * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP): | |
4159 | (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed | |
4160 | to use the following functions instead of these macros. | |
4161 | (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not | |
4162 | EMACS_INT, since callers assume the returned value fits in int. | |
4163 | (upcase1): Likewise, for UPCASE_TABLE. | |
4164 | (uppercasep, lowercasep, upcase): New static inline functions. | |
0da09c43 | 4165 | * editfns.c (Fchar_equal): Remove no-longer-needed workaround for |
db69b0cd | 4166 | the race-condition problem in the old DOWNCASE. |
88043301 | 4167 | |
19ed5445 PE |
4168 | * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT): |
4169 | Rename locals to avoid shadowing. | |
4170 | (regex_compile, re_match_2_internal): Move locals to avoid shadowing. | |
abbd1bcf PE |
4171 | (regex_compile, re_search_2, re_match_2_internal): |
4172 | Remove unused local vars. | |
952db0d7 PE |
4173 | (FREE_VAR): Rewrite so as not to use empty "else", |
4174 | which gcc can warn about. | |
da053e48 | 4175 | (regex_compile, re_match_2_internal): Mark locals as initialized. |
b313f9d8 PE |
4176 | (RETALLOC_IF): Define only if needed. |
4177 | (WORDCHAR_P): Likewise. This one is never needed, but is used | |
4178 | only in a comment talking about a compiler bug, so put inside | |
4179 | the #if 0 of that comment. | |
4180 | (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK): | |
4181 | (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING): | |
4182 | Remove; unused. | |
19ed5445 | 4183 | |
1f3561e4 | 4184 | * search.c (boyer_moore): Rename locals to avoid shadowing. |
76ef09b7 PE |
4185 | * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE): |
4186 | (PREV_CHAR_BOUNDARY): Likewise. | |
1f3561e4 | 4187 | |
ded6f8f7 PE |
4188 | * search.c (simple_search): Remove unused var. |
4189 | ||
dbd37a95 PE |
4190 | * dired.c (compile_pattern): Move decl from here ... |
4191 | * lisp.h: ... to here, so that it can be checked. | |
4192 | (struct re_registers): New forward decl. | |
4193 | ||
7e47afad PE |
4194 | * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing. |
4195 | ||
85f24f61 PE |
4196 | * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width. |
4197 | All uses changed. | |
4198 | (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion): | |
4199 | Rename locals to avoid shadowing. | |
5671df8f | 4200 | (Fvertical_motion): Mark locals as initialized. |
85f24f61 | 4201 | |
181aa2be | 4202 | * casefiddle.c (casify_object, casify_region): Now static. |
e45a141a | 4203 | (casify_region): Mark local as initialized. |
181aa2be | 4204 | |
930d429c PE |
4205 | * cmds.c (internal_self_insert): Rename local to avoid shadowing. |
4206 | ||
7082eac6 PE |
4207 | * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR): |
4208 | New macros, so that the caller can use some names other than | |
4209 | gcpro1, gcpro2, etc. | |
4210 | (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms | |
4211 | of the new macros. | |
4212 | (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second | |
4213 | argument, for consistency with GCPRO2_VAR, etc: it is now the | |
4214 | prefix of the variable, not the variable itself. All uses | |
4215 | changed. | |
38b2c076 PE |
4216 | * dired.c (directory_files_internal, file_name_completion): |
4217 | Rename locals to avoid shadowing. | |
4218 | ||
15206ed9 PE |
4219 | Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254). |
4220 | An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in | |
4221 | dired.c's scmp function, had undefined behavior. | |
4222 | * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP): | |
4223 | (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ... | |
4224 | * buffer.h: ... to here, because these macros use current_buffer, | |
4225 | and the new implementation with inline functions needs to have | |
4226 | current_buffer in scope now, rather than later when the macros | |
4227 | are used. | |
4228 | (downcase, upcase1): New static inline functions. | |
4229 | (DOWNCASE, UPCASE1): Reimplement using these functions. | |
4230 | This avoids undefined behavior in expressions like | |
4231 | DOWNCASE (x) == DOWNCASE (y), which previously suffered | |
4232 | from race conditions in accessing the global variables | |
4233 | case_temp1 and case_temp2. | |
4234 | * casetab.c (case_temp1, case_temp2): Remove; no longer needed. | |
4235 | * lisp.h (case_temp1, case_temp2): Remove their decls. | |
4236 | * character.h (ASCII_CHAR_P): Move from here ... | |
4237 | * lisp.h: ... to here, so that the inline functions mentioned | |
4238 | above can use them. | |
4239 | ||
4a6bea26 PE |
4240 | * dired.c (directory_files_internal_unwind): Now static. |
4241 | ||
f14b7e14 PE |
4242 | * fileio.c (file_name_as_directory, directory_file_name): |
4243 | (barf_or_query_if_file_exists, auto_save_error, auto_save_1): | |
4244 | Now static. | |
2893f146 PE |
4245 | (file_name_as_directory): Use const pointers when appropriate. |
4246 | (Fexpand_file_name): Likewise. In particular, newdir might | |
4247 | point at constant storage, so make it a const pointer. | |
fd4ead52 | 4248 | (Fmake_directory_internal, Fread_file_name): Remove unused vars. |
b14aac08 PE |
4249 | (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer |
4250 | signedness issues. | |
f839df0c PE |
4251 | (Fset_file_times, Finsert_file_contents, auto_save_error): |
4252 | Rename locals to avoid shadowing. | |
f14b7e14 | 4253 | |
5716756e | 4254 | * minibuf.c (choose_minibuf_frame_1): Now static. |
62137a95 PE |
4255 | (Ftry_completion, Fall_completions): Rename or remove locals |
4256 | to avoid shadowing. | |
5716756e | 4257 | |
b4c3046a PE |
4258 | * marker.c (bytepos_to_charpos): Remove; unused. |
4259 | ||
b45db522 PE |
4260 | * lisp.h (verify_bytepos, count_markers): New decls, |
4261 | so that gcc does not warn that these functions aren't declared. | |
4262 | ||
85876d07 PE |
4263 | * insdel.c (check_markers, make_gap_larger, make_gap_smaller): |
4264 | (reset_var_on_error, Fcombine_after_change_execute_1): Now static. | |
f0cb4a60 | 4265 | (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic. |
40ef059e | 4266 | (copy_text): Remove unused local var. |
85876d07 | 4267 | |
03d78a21 | 4268 | * filelock.c (within_one_second): Now static. |
b3dd38ab | 4269 | (lock_file_1): Rename local to avoid shadowing. |
03d78a21 | 4270 | |
5df8f01b PE |
4271 | * buffer.c (fix_overlays_before): Mark locals as initialized. |
4272 | (fix_start_end_in_overlays): Likewise. This function should be | |
4273 | simplified by using pointers-to-pointers, but that's a different | |
4274 | matter. | |
b1d876f1 | 4275 | (switch_to_buffer_1): Now static. |
8f54f30a PE |
4276 | (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte): |
4277 | (report_overlay_modification): Rename locals to avoid shadowing. | |
c3bd59b5 | 4278 | |
a70072c9 | 4279 | * sysdep.c (system_process_attributes): Rename vars to avoid shadowing. |
fbd02d7b | 4280 | Fix pointer signedness issue. |
edced198 PE |
4281 | (sys_subshell): Mark local as volatile if checking for lint, |
4282 | to suppress a gcc -Wclobbered warning that does not seem to be right. | |
15dfd3d9 | 4283 | (MAXPATHLEN): Define only if needed. |
a70072c9 | 4284 | |
a0977c44 PE |
4285 | * process.c (serial_open, serial_configure): Move decls from here ... |
4286 | * systty.h: ... to here, so that they can be checked. | |
4287 | ||
a884fdcc PE |
4288 | * fns.c (get_random, seed_random): Move extern decls from here ... |
4289 | * lisp.h: ... to here, so that they can be checked. | |
4290 | ||
604efe86 | 4291 | * sysdep.c (reset_io): Now static. |
b8950c94 | 4292 | (wait_for_termination_signal): Remove; unused. |
604efe86 | 4293 | |
38fc62d9 PE |
4294 | * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal): |
4295 | (copy_keymap_item, append_key, push_text_char_description): | |
4296 | Now static. | |
1004a21a | 4297 | (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily. |
dbbb8427 | 4298 | (DENSE_TABLE_SIZE): Remove; unused. |
c1141155 PE |
4299 | (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal): |
4300 | (describe_map_tree): | |
4301 | Rename locals to avoid shadowing. | |
38fc62d9 | 4302 | |
2f2650da PE |
4303 | * keyboard.c: Declare functions static if they are not used elsewhere. |
4304 | (echo_char, echo_dash, cmd_error, top_level_2): | |
4305 | (poll_for_input, handle_async_input): Now static. | |
69a058fa PE |
4306 | (read_char, kbd_buffer_get_event, make_lispy_position): |
4307 | (make_lispy_event, make_lispy_movement, apply_modifiers): | |
4308 | (decode_keyboard_code, tty_read_avail_input, menu_bar_items): | |
4309 | (parse_tool_bar_item, read_key_sequence, Fread_key_sequence): | |
4310 | (Fread_key_sequence_vector): Rename locals to avoid shadowing. | |
c8a06054 | 4311 | (read_key_sequence, read_char): Mark locals as initialized. |
3ac94672 | 4312 | (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN. |
2f2650da | 4313 | |
a053e86c | 4314 | * keyboard.h (make_ctrl_char): New decl. |
da2f2dd9 PE |
4315 | (mark_kboards): Move decl here ... |
4316 | * alloc.c (mark_kboards): ... from here. | |
a053e86c | 4317 | |
4752793e PE |
4318 | * lisp.h (force_auto_save_soon): New decl. |
4319 | ||
74f10ca7 | 4320 | * emacs.c (init_cmdargs): Rename local to avoid shadowing. |
244fc23d PE |
4321 | (DEFINE_DUMMY_FUNCTION): New macro. |
4322 | (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main): | |
4323 | Use it. | |
c03cd23f PE |
4324 | (main): Add casts to avoid warnings |
4325 | if GCC considers string literals to be constants. | |
74f10ca7 | 4326 | |
022e70d4 PE |
4327 | * lisp.h (fatal_error_signal): Add decl, since it's exported. |
4328 | ||
59d6fe83 PE |
4329 | * dbusbind.c: Pointer signedness fixes. |
4330 | (xd_signature, xd_append_arg, xd_initialize): | |
4331 | (Fdbus_call_method, Fdbus_call_method_asynchronously): | |
4332 | (Fdbus_method_return_internal, Fdbus_method_error_internal): | |
4333 | (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service): | |
4334 | (Fdbus_register_signal): Use SSDATA when the context wants char *. | |
4335 | ||
78320123 PE |
4336 | * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning |
4337 | if GCC considers string literals to be constants. | |
49cebcca | 4338 | (Fdbus_register_service, Fdbus_register_method): Remove unused vars. |
78320123 | 4339 | |
35ac2a97 SM |
4340 | 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca> |
4341 | ||
fb103ca9 SM |
4342 | * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro. |
4343 | (print_preprocess, print_object): New macro to fix last change. | |
4344 | ||
35ac2a97 SM |
4345 | * print.c (print_preprocess): Don't forget font objects. |
4346 | ||
62973b41 JB |
4347 | 2011-03-16 Juanma Barranquero <lekktu@gmail.com> |
4348 | ||
4349 | * emacs.c (USAGE3): Doc fixes. | |
4350 | ||
0e48bb22 AS |
4351 | 2011-03-15 Andreas Schwab <schwab@linux-m68k.org> |
4352 | ||
4353 | * coding.c (detect_coding_iso_2022): Reorganize code to clarify | |
4354 | structure. | |
4355 | ||
7684e57b JB |
4356 | 2011-03-14 Juanma Barranquero <lekktu@gmail.com> |
4357 | ||
4358 | * lisp.h (VWindow_system, Qfile_name_history): | |
4359 | * keyboard.h (lispy_function_keys) [WINDOWSNT]: | |
4360 | * w32term.h (w32_system_caret_hwnd, w32_system_caret_height) | |
4361 | (w32_system_caret_x, w32_system_caret_y): Declare extern. | |
4362 | ||
4363 | * w32select.c: Don't #include "keyboard.h". | |
c96bbc66 | 4364 | (run_protected): Add extern declaration for waiting_for_input. |
7684e57b JB |
4365 | |
4366 | * w32.c (Qlocal, noninteractive1, inhibit_window_system): | |
4367 | * w32console.c (detect_input_pending, read_input_pending) | |
4368 | (encode_terminal_code): | |
4369 | * w32fns.c (quit_char, lispy_function_keys, Qtooltip) | |
4370 | (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x) | |
4371 | (w32_system_caret_y, Qfile_name_history): | |
4372 | * w32font.c (w32font_driver, QCantialias, QCotf, QClang): | |
4373 | * w32inevt.c (reinvoke_input_signal, lispy_function_keys): | |
4374 | * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map) | |
4375 | (Qoverriding_terminal_local_map, Qmenu_bar_update_hook): | |
4376 | * w32proc.c (Qlocal, report_file_error): | |
4377 | * w32term.c (Vwindow_system, updating_frame): | |
4378 | * w32uniscribe.c (initialized, uniscribe_font_driver): | |
4379 | Remove unneeded extern declarations. | |
4380 | ||
2aa46d6c CY |
4381 | 2011-03-14 Chong Yidong <cyd@stupidchicken.com> |
4382 | ||
c96bbc66 | 4383 | * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions. |
2aa46d6c | 4384 | |
cffc6f3b CY |
4385 | 2011-03-13 Chong Yidong <cyd@stupidchicken.com> |
4386 | ||
4387 | * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT) | |
4388 | (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219). | |
4389 | These macros can no longer be used for assignment. | |
4390 | ||
44f230aa SM |
4391 | * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): |
4392 | Assign struct members directly, instead of using BUF_BEGV etc. | |
cffc6f3b CY |
4393 | (record_buffer_markers, fetch_buffer_markers): New functions for |
4394 | recording and fetching special buffer markers. | |
4395 | (set_buffer_internal_1, set_buffer_temp): Use them. | |
4396 | ||
4397 | * lread.c (unreadchar): Use SET_BUF_PT_BOTH. | |
4398 | ||
4399 | * insdel.c (adjust_point): Use SET_BUF_PT_BOTH. | |
4400 | ||
4401 | * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH. | |
4402 | (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH. | |
4403 | ||
4404 | * xdisp.c (hscroll_window_tree): | |
4405 | (reconsider_clip_changes): Use PT instead of BUF_PT. | |
4406 | ||
d251f04b EZ |
4407 | 2011-03-13 Eli Zaretskii <eliz@gnu.org> |
4408 | ||
4409 | * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on | |
4410 | $(EMACS_ROOT)/lib/intprops.h. | |
4411 | ||
f0c77cd1 PE |
4412 | 2011-03-13 Paul Eggert <eggert@cs.ucla.edu> |
4413 | ||
3eca4629 PE |
4414 | Fix more problems found by GCC 4.5.2's static checks. |
4415 | ||
7c86ee98 PE |
4416 | * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char * |
4417 | to unsigned char * to avoid compiler diagnostic. | |
b0afc268 PE |
4418 | (xg_free_frame_widgets): Make it clear that a local variable is |
4419 | needed only if USE_GTK_TOOLTIP. | |
01e0b5ad PE |
4420 | (gdk_window_get_screen): Make it clear that this macro is needed |
4421 | only if USE_GTK_TOOLTIP. | |
1e5524e7 PE |
4422 | (int_gtk_range_get_value): New function, which avoids a diagnostic |
4423 | from gcc -Wbad-function-cast. | |
4424 | (xg_set_toolkit_scroll_bar_thumb): Use it. | |
4425 | (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid | |
4426 | diagnostic from gcc -Wbad-function-cast. | |
65dc836c PE |
4427 | (get_utf8_string, xg_get_file_with_chooser): |
4428 | Rename locals to avoid shadowing. | |
4429 | (create_dialog): Move locals to avoid shadowing. | |
7c86ee98 | 4430 | |
41729b81 PE |
4431 | * xgselect.c (xg_select): Remove unused var. |
4432 | ||
f0c77cd1 PE |
4433 | * image.c (four_corners_best): Mark locals as initialized. |
4434 | (gif_load): Initialize transparent_p to zero (Bug#8238). | |
4435 | Mark another local as initialized. | |
ec6cf4c6 | 4436 | (my_png_error, my_error_exit): Mark with NO_RETURN. |
f0c77cd1 | 4437 | |
ce0ad53d | 4438 | * image.c (clear_image_cache): Now static. |
d5d5a617 | 4439 | (DIM, HAVE_STDLIB_H_1): Remove unused macros. |
e22cffbc | 4440 | (xpm_load): Redo to avoid "discards qualifiers" gcc warning. |
77a765fd PE |
4441 | (x_edge_detection): Remove unnecessary cast that |
4442 | gcc -Wbad-function-cast diagnoses. | |
2037898d | 4443 | (gif_load): Fix pointer signedness. |
6ae141d6 PE |
4444 | (clear_image_cache, xbm_read_bitmap_data, x_detect_edges): |
4445 | (jpeg_load, gif_load): Rename locals to avoid shadowing. | |
ce0ad53d | 4446 | |
33383987 | 4447 | 2011-03-12 Paul Eggert <eggert@cs.ucla.edu> |
3eca4629 | 4448 | |
d32df629 PE |
4449 | Improve quality of tests for time stamp overflow. |
4450 | For example, without this patch (encode-time 0 0 0 1 1 | |
4451 | 1152921504606846976) returns the obviously-bogus value (-948597 | |
4452 | 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly | |
4453 | reports time overflow. See | |
4454 | <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>. | |
b8d9bd41 PE |
4455 | * deps.mk (editfns.o): Depend on ../lib/intprops.h. |
4456 | * editfns.c: Include limits.h and intprops.h. | |
4457 | (TIME_T_MIN, TIME_T_MAX): New macros. | |
4458 | (time_overflow): Move earlier, to before first use. | |
4459 | (hi_time, lo_time): New functions, for an accurate test for | |
4460 | out-of-range times. | |
4461 | (Fcurrent_time, Fget_internal_run_time, make_time): Use them. | |
4462 | (Fget_internal_run_time): Don't assume time_t fits in int. | |
4463 | (make_time): Use list2 instead of Fcons twice. | |
4464 | (Fdecode_time): More accurate test for out-of-range times. | |
4465 | (check_tm_member): New function. | |
4466 | (Fencode_time): Use it, to test for out-of-range times. | |
d32df629 PE |
4467 | (lisp_time_argument): Don't rely on undefined left-shift and |
4468 | right-shift behavior when checking for time stamp overflow. | |
8be6f318 | 4469 | |
fe31d94c PE |
4470 | * editfns.c (time_overflow): New function, refactoring common code. |
4471 | (Fformat_time_string, Fdecode_time, Fencode_time): | |
4472 | (Fcurrent_time_string): Use it. | |
4473 | ||
8be6f318 PE |
4474 | Move 'make_time' to be next to its inverse 'lisp_time_argument'. |
4475 | * dired.c (make_time): Move to ... | |
4476 | * editfns.c (make_time): ... here. | |
4477 | * systime.h: Note the move. | |
4478 | ||
09d9db2c | 4479 | 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
c47cbdfd | 4480 | |
126bc0dc YM |
4481 | * fringe.c (update_window_fringes): Remove unused variables. |
4482 | ||
c47cbdfd YM |
4483 | * unexmacosx.c (copy_data_segment): Also copy __got section. |
4484 | (Bug#8223) | |
4485 | ||
7ac80be9 EZ |
4486 | 2011-03-12 Eli Zaretskii <eliz@gnu.org> |
4487 | ||
c96bbc66 | 4488 | * termcap.c [MSDOS]: Include "msdos.h". |
058e5dad EZ |
4489 | (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent): |
4490 | Constify `char *' arguments and their references according to | |
4491 | prototypes in tparam.h. | |
4492 | ||
ecb0f94d | 4493 | * deps.mk (termcap.o): Depend on tparam.h and msdos.h. |
058e5dad | 4494 | |
7ac80be9 EZ |
4495 | * msdos.c (XMenuAddPane): 3rd argument is `const char *' now. |
4496 | Adapt all references accordingly. | |
4497 | ||
4498 | * msdos.h (XMenuAddPane): 3rd argument is `const char *' now. | |
4499 | ||
ef1fd07e TT |
4500 | 2011-03-11 Tom Tromey <tromey@redhat.com> |
4501 | ||
4502 | * buffer.c (syms_of_buffer): Remove obsolete comment. | |
4503 | ||
7ef4b50c EZ |
4504 | 2011-03-11 Eli Zaretskii <eliz@gnu.org> |
4505 | ||
4506 | * termhooks.h (encode_terminal_code): Declare prototype. | |
4507 | ||
4508 | * msdos.c (encode_terminal_code): Don't declare prototype. | |
4509 | ||
4510 | * term.c (encode_terminal_code): Now external again, used by | |
4511 | w32console.c and msdos.c. | |
4512 | ||
44f230aa SM |
4513 | * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): |
4514 | Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu. | |
7ef4b50c | 4515 | |
4b1ec863 | 4516 | 2011-03-11 Paul Eggert <eggert@cs.ucla.edu> |
f78faa98 | 4517 | |
1714f52b | 4518 | Fix some minor problems found by GCC 4.5.2's static checks. |
83316bf4 | 4519 | |
4b1ec863 PE |
4520 | * fringe.c (update_window_fringes): Mark locals as initialized |
4521 | (Bug#8227). | |
4522 | (destroy_fringe_bitmap, init_fringe_bitmap): Now static. | |
bf60f616 | 4523 | |
524c7aa6 PE |
4524 | * alloc.c (mark_fringe_data): Move decl from here ... |
4525 | * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here, | |
4526 | to check its interface. | |
4527 | (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM. | |
4528 | ||
a5c0af81 | 4529 | * fontset.c (free_realized_fontset): Now static. |
7519b8cd | 4530 | (Fset_fontset_font): Rename local to avoid shadowing. |
cc6e5db1 | 4531 | (fontset_font): Mark local as initialized. |
a9a06e0b | 4532 | (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused. |
a5c0af81 | 4533 | |
b4716021 PE |
4534 | * xrdb.c: Include "xterm.h", to check x_load_resources's interface. |
4535 | ||
811e9bac | 4536 | * xselect.c (x_disown_buffer_selections): Remove; not used. |
7b83e2f1 | 4537 | (TRACE3) [!defined TRACE_SELECTION]: Remove; not used. |
aa0daa9f PE |
4538 | (x_own_selection, Fx_disown_selection_internal): Rename locals |
4539 | to avoid shadowing. | |
4540 | (x_handle_dnd_message): Remove local to avoid shadowing. | |
811e9bac | 4541 | |
7e3ab302 PE |
4542 | * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros, |
4543 | so that the caller can use some name other than gcpro1. | |
4544 | (GCPRO1, UNGCPRO): Reimplement in terms of the new macros. | |
58d2d479 PE |
4545 | * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip): |
4546 | (Fx_backspace_delete_keys_p): | |
4547 | Use them to avoid shadowing, and rename vars to avoid shadowing. | |
4548 | (x_decode_color, x_set_name, x_window): Now static. | |
6b437900 | 4549 | (Fx_create_frame): Add braces to silence GCC warning. |
c0951e53 | 4550 | (Fx_file_dialog, Fx_select_font): Fix pointer signedness. |
06b0c8a0 PE |
4551 | (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame): |
4552 | Remove unused locals. | |
7e3ab302 PE |
4553 | (Fx_create_frame, x_create_tip_frame, Fx_show_tip): |
4554 | (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing. | |
4555 | Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR | |
4556 | macros. | |
f78faa98 | 4557 | |
e2b13473 PE |
4558 | * xterm.h (x_mouse_leave): New decl. |
4559 | ||
77f23912 PE |
4560 | * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame): |
4561 | Remove unused functions. | |
cdf4ba58 PE |
4562 | (x_shift_glyphs_for_insert, XTflash, XTring_bell): |
4563 | (x_calc_absolute_position): Now static. | |
7411c686 | 4564 | (XTread_socket): Don't define label "out" unless it's used. |
2b07bcff | 4565 | Don't declare local "event" unless it's used. |
ed7bf3a5 PE |
4566 | (x_iconify_frame, x_free_frame_resources): Don't declare locals |
4567 | unless they are used. | |
38d0b34a PE |
4568 | (XEMBED_VERSION, xembed_set_info): Don't define unless needed. |
4569 | (x_fatal_error_signal): Remove; not used. | |
a6067996 PE |
4570 | (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position): |
4571 | (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor): | |
4572 | (x_error_catcher, x_connection_closed, x_error_handler): | |
4573 | (x_error_quitter, xembed_send_message, x_iconify_frame): | |
4574 | (my_log_handler): Rename locals to avoid shadowing. | |
28f1c698 | 4575 | (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN. |
2a8fade0 | 4576 | (x_connection_closed): Tell GCC not to suggest NO_RETURN. |
77f23912 | 4577 | |
44f230aa SM |
4578 | * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): |
4579 | Rename or move locals to avoid shadowing. | |
6b463e58 | 4580 | (tty_defined_color, merge_face_heights): Now static. |
5967d051 | 4581 | (free_realized_faces_for_fontset): Remove; not used. |
1e9966ea PE |
4582 | (Fx_list_fonts): Mark variable that gcc -Wuninitialized |
4583 | does not deduce is never used uninitialized. | |
73719eba PE |
4584 | (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used. |
4585 | (LFACEP): Define only if XASSERTS, as it's not needed otherwise. | |
071048a3 | 4586 | |
426994c3 | 4587 | * terminal.c (store_terminal_param): Now static. |
5489860b | 4588 | |
032f1620 | 4589 | * xmenu.c (menu_highlight_callback): Now static. |
9d66f88e | 4590 | (set_frame_menubar): Remove unused local. |
d4323972 | 4591 | (xmenu_show): Rename parameter to avoid shadowing. |
6d1f7fee PE |
4592 | (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const" |
4593 | since they might point to immutable storage. | |
281585b0 PE |
4594 | (next_menubar_widget_id): Declare only if USE_X_TOOLKIT, |
4595 | since it's unused otherwise. | |
032f1620 | 4596 | |
367c19e5 | 4597 | * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff. |
53df7c11 | 4598 | Add a FIXME, since the code still doesn't look right. (Bug#8215) |
9f36b9fd PE |
4599 | (Fcurrent_bidi_paragraph_direction): Simplify slightly; this |
4600 | avoids a gcc -Wuninitialized diagnostic. | |
0e086e8f | 4601 | (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs): |
44a3a108 PE |
4602 | (note_mouse_highlight): Mark variables that gcc -Wuninitialized |
4603 | does not deduce are never used uninitialized. | |
70739cbe | 4604 | |
07b48fa9 PE |
4605 | * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c. |
4606 | ||
8868a238 | 4607 | * xdisp.c (redisplay_window): Rename local to avoid shadowing. |
4554d213 PE |
4608 | * window.c (window_loop, size_window): |
4609 | (run_window_configuration_change_hook, enlarge_window): Likewise. | |
8868a238 | 4610 | |
7e5cf297 | 4611 | * window.c (display_buffer): Now static. |
d6550a9f PE |
4612 | (size_window): Mark variables that gcc -Wuninitialized |
4613 | does not deduce are never used uninitialized. | |
a586633d PE |
4614 | * window.h (check_all_windows): New decl, to forestall |
4615 | gcc -Wmissing-prototypes diagnostic. | |
5b555da1 | 4616 | * dispextern.h (bidi_dump_cached_states): Likewise. |
7e5cf297 | 4617 | |
f6095868 PE |
4618 | * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid |
4619 | shadowing. | |
4620 | * charset.c (map_charset_for_dump, Fchar_charset): Likewise. | |
726929c4 PE |
4621 | Include <limits.h>. |
4622 | (Fsort_charsets): Redo min/max calculation to shorten the code a bit | |
4623 | and to avoid gcc -Wuninitialized warning. | |
89ef49df PE |
4624 | (load_charset_map): Mark variables that gcc -Wuninitialized |
4625 | does not deduce are never used uninitialized. | |
53df7c11 | 4626 | (load_charset): Abort instead of using uninitialized var (Bug#8229). |
f6095868 | 4627 | |
f38b440c PE |
4628 | * coding.c (coding_set_source, coding_set_destination): |
4629 | Use "else { /* comment */ }" rather than "else /* comment */;" | |
4630 | for clarity, and to avoid gcc -Wempty-body warning. | |
2735d060 PE |
4631 | (Fdefine_coding_system_internal): Don't redeclare 'i' inside |
4632 | a block, when the outer 'i' will do. | |
4633 | (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule): | |
4634 | (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022): | |
4635 | (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5): | |
4636 | (decode_coding_raw_text, decode_coding_charset, get_translation_table): | |
4637 | (Fdecode_sjis_char, Fdefine_coding_system_internal): | |
4638 | Rename locals to avoid shadowing. | |
4639 | * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise. | |
e2f1bab9 PE |
4640 | * coding.c (emacs_mule_char, encode_invocation_designation): |
4641 | Now static, since they're not used elsewhere. | |
413bb2db | 4642 | (decode_coding_iso_2022): Add "default: abort ();" as a safety check. |
c4a63b12 | 4643 | (decode_coding_object, encode_coding_object, detect_coding_system): |
ee05f961 PE |
4644 | (decode_coding_emacs_mule): Mark variables that gcc |
4645 | -Wuninitialized does not deduce are never used uninitialized. | |
160b01f6 PE |
4646 | (detect_coding_iso_2022): Initialize a local variable that might |
4647 | be used uninitialized. Leave a FIXME because it's not clear that | |
53df7c11 | 4648 | this initialization is needed. (Bug#8211) |
5f58e762 PE |
4649 | (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT): |
4650 | (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P): | |
4651 | (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER): | |
4652 | (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R): | |
4653 | Remove unused macros. | |
f38b440c | 4654 | |
232b38b9 | 4655 | * category.c (hash_get_category_set): Remove unused local var. |
9f3b5e69 | 4656 | (copy_category_table): Now static, since it's not used elsewhere. |
d0891610 | 4657 | * character.c (string_count_byte8): Likewise. |
232b38b9 | 4658 | |
fb90da1b PE |
4659 | * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string): |
4660 | (Fregister_code_conversion_map): Rename locals to avoid shadowing. | |
4661 | ||
fb93dbc2 PE |
4662 | * chartab.c (copy_sub_char_table): Now static, since it's not used |
4663 | elsewhere. | |
5c156ace PE |
4664 | (sub_char_table_ref_and_range, char_table_ref_and_range): |
4665 | Rename locals to avoid shadowing. | |
bbcd0949 | 4666 | (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros. |
fb93dbc2 | 4667 | |
7d3b3862 | 4668 | * bidi.c (bidi_check_type): Now static, since it's not used elsewhere. |
630d6892 | 4669 | (BIDI_BOB): Remove unused macro. |
7d3b3862 | 4670 | |
6be7d3da PE |
4671 | * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not |
4672 | deduce are never used uninitialized. | |
c2ed9c8b | 4673 | * term.c (encode_terminal_code): Likewise. |
6be7d3da | 4674 | |
75f8807f | 4675 | * term.c (encode_terminal_code): Now static. Remove unused local. |
72abad34 | 4676 | |
50938595 PE |
4677 | * tparam.h: New file. |
4678 | * term.c, tparam.h: Include it. | |
4679 | * deps.mk (term.o, tparam.o): Depend on tparam.h. | |
4680 | * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr): | |
4681 | Move these decls to tparam.h, and make them agree with what | |
4682 | is actually in tparam.c. The previous trick of using incompatible | |
4683 | decls in different modules does not conform to the C standard. | |
4684 | All callers of tparam changed to use tparam's actual API. | |
4685 | * tparam.c (tparam1, tparam, tgoto): | |
4686 | Use const pointers where appropriate. | |
4687 | ||
fbceeba2 PE |
4688 | * cm.c (calccost, cmgoto): Use const pointers where appropriate. |
4689 | * cm.h (struct cm): Likewise. | |
4690 | * dispextern.h (do_line_insertion_deletion_costs): Likewise. | |
4691 | * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise. | |
4692 | * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table): | |
4693 | (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph): | |
4694 | (turn_on_face, init_tty): Likewise. | |
4695 | * termchar.h (struct tty_display_info): Likewise. | |
fbceeba2 | 4696 | |
7f3f1250 PE |
4697 | * term.c (term_mouse_position): Rename local to avoid shadowing. |
4698 | ||
e6ca6543 PE |
4699 | * alloc.c (mark_ttys): Move decl from here ... |
4700 | * lisp.h (mark_ttys): ... to here, so that it's checked against defn. | |
4701 | ||
c40f8d15 AS |
4702 | 2011-03-11 Andreas Schwab <schwab@linux-m68k.org> |
4703 | ||
4704 | * .gdbinit (pwinx, xbuffer): Fix access to buffer name. | |
4705 | ||
cfe0661d JB |
4706 | 2011-03-09 Juanma Barranquero <lekktu@gmail.com> |
4707 | ||
4708 | * search.c (compile_pattern_1): Remove argument regp, unused since | |
4709 | revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig. | |
4710 | (compile_pattern): Don't pass it. | |
4711 | ||
0afb4571 J |
4712 | 2011-03-08 Jan Djärv <jan.h.d@swipnet.se> |
4713 | ||
4714 | * xterm.h (DEFAULT_GDK_DISPLAY): New define. | |
4715 | (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines | |
4716 | for ! HAVE_GTK3. | |
4717 | (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID. | |
4718 | ||
4719 | * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size. | |
4720 | ||
4721 | * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define | |
4722 | gdk_window_get_screen, gdk_window_get_geometry, | |
4723 | gdk_x11_window_lookup_for_display and GDK_KEY_g. | |
4724 | (xg_set_screen): Use DEFAULT_GDK_DISPLAY. | |
4725 | (xg_get_pixbuf_from_pixmap): New function. | |
4726 | (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap | |
4727 | to Pixmap, take frame as parameter, remove GdkColormap parameter. | |
4728 | Call xg_get_pixbuf_from_pixmap instead of | |
4729 | gdk_pixbuf_get_from_drawable. | |
4730 | (xg_get_image_for_pixmap): Do not make GdkPixmaps, call | |
4731 | xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead. | |
4732 | (xg_check_special_colors): Use GtkStyleContext and its functions | |
4733 | for HAVE_GTK3. | |
4734 | (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen. | |
4735 | (xg_prepare_tooltip, create_dialog, menubar_map_cb) | |
4736 | (xg_update_frame_menubar, xg_tool_bar_detach_callback) | |
44f230aa SM |
4737 | (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): |
4738 | Call gtk_widget_get_preferred_size. | |
0afb4571 J |
4739 | (xg_frame_resized): gdk_window_get_geometry only takes 5 |
4740 | parameters. | |
44f230aa SM |
4741 | (xg_win_to_widget, xg_event_is_for_menubar): |
4742 | Call gdk_x11_window_lookup_for_display. | |
0afb4571 J |
4743 | (xg_set_widget_bg): New function. |
4744 | (delete_cb): New function. | |
895009e1 | 4745 | (xg_create_frame_widgets): Connect delete-event to delete_cb. |
0afb4571 J |
4746 | Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3 |
4747 | (xg_set_background_color): Call xg_set_widget_bg. | |
4748 | (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask. | |
4749 | (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3. | |
4750 | Only call gtk_range_set_update_policy if ! HAVE_GTK3. | |
4751 | (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback | |
4752 | if ! HAVE_GTK3. | |
4753 | (update_frame_tool_bar): Call gtk_widget_hide. | |
4754 | (xg_initialize): Use GDK_KEY_g. | |
4755 | ||
4756 | * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id | |
4757 | if ! HAVE_GTK3 | |
4758 | (x_session_initialize): Call gdk_x11_set_sm_client_id. | |
4759 | ||
4760 | * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3. | |
4761 | (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS. | |
4762 | Load ~/emacs.d/gtkrc only for ! HAVE_GTK3. | |
4763 | ||
1c2cc4ef JB |
4764 | 2011-03-08 Juanma Barranquero <lekktu@gmail.com> |
4765 | ||
4766 | * w32xfns.c (select_palette): Check success of RealizePalette against | |
4767 | GDI_ERROR, not zero. | |
4768 | ||
33383987 | 4769 | See ChangeLog.11 for earlier changes. |
aac0c6e3 MR |
4770 | |
4771 | ;; Local Variables: | |
4772 | ;; coding: utf-8 | |
aac0c6e3 MR |
4773 | ;; End: |
4774 | ||
33383987 | 4775 | Copyright (C) 2011 Free Software Foundation, Inc. |
aac0c6e3 MR |
4776 | |
4777 | This file is part of GNU Emacs. | |
4778 | ||
4779 | GNU Emacs is free software: you can redistribute it and/or modify | |
4780 | it under the terms of the GNU General Public License as published by | |
4781 | the Free Software Foundation, either version 3 of the License, or | |
4782 | (at your option) any later version. | |
4783 | ||
4784 | GNU Emacs is distributed in the hope that it will be useful, | |
4785 | but WITHOUT ANY WARRANTY; without even the implied warranty of | |
4786 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
4787 | GNU General Public License for more details. | |
4788 | ||
4789 | You should have received a copy of the GNU General Public License | |
4790 | along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. |