Fix for GNUstep build failure during dumping.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b34d7317
YM
12011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2
3 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4 that where the value of an _OBJC_* symbol points to is in the .bss
5 section (Bug#10240).
6
76470ad1
KH
72011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8
9 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 10 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 11
745fff94
KH
122011-12-08 Kenichi Handa <handa@m17n.org>
13
14 * ftfont.c (get_adstyle_property): Fix previous change
15 (Bug#10233).
16
6e44397c
JB
172011-12-07 Juanma Barranquero <lekktu@gmail.com>
18
19 * w32.c (init_environment): If no_site_lisp, remove site-lisp
20 dirs from the default value of EMACSLOADPATH (bug#10208).
21
7efa6272
GM
222011-12-07 Glenn Morris <rgm@gnu.org>
23
24 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
25 installation and source directories as well. (Bug#10208)
26
f6fc4d87
CY
272011-12-06 Chong Yidong <cyd@gnu.org>
28
29 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
30
2bf26180
GM
312011-12-06 Glenn Morris <rgm@gnu.org>
32
33 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
34 as an error, not just -1. (Bug#10217)
35
3a6ad4f0
CY
362011-12-05 Chong Yidong <cyd@gnu.org>
37
38 * keyboard.c (process_special_events): New function.
39 (swallow_events, Finput_pending_p): Use it (Bug#10195).
40
75a3b399
PE
412011-12-05 Paul Eggert <eggert@cs.ucla.edu>
42
43 * coding.c (encode_designation_at_bol): Don't use uninitialized
44 local variable (Bug#9318).
45
c3c9e25e
KH
462011-12-05 Kenichi Handa <handa@m17n.org>
47
48 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
49 return Qnil (Bug#8046, Bug#10193).
50
5eb05ea3
KH
512011-12-05 Kenichi Handa <handa@m17n.org>
52
53 * coding.c (encode_designation_at_bol): New args charbuf_end and
54 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
55 (coding_set_source): Return how many bytes coding->source was
56 relocated.
57 (coding_set_destination): Return how many bytes
58 coding->destination was relocated.
59 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
60 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
61
622011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
63
64 * coding.c (CODING_CHAR_CHARSET_P): New macro.
65 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
66 macro (Bug#9318).
67
682011-12-05 Andreas Schwab <schwab@linux-m68k.org>
69
70 The following changes are to fix Bug#9318.
71
a79703f5 72 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
73 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
74 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 75 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 76
7dbda6df
JB
772011-12-05 Juanma Barranquero <lekktu@gmail.com>
78
79 * lisp.h (process_quit_flag): Fix external declaration.
80
6d5eb5b0
SM
812011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
82
83 Don't macro-inline non-performance-critical code.
84 * eval.c (process_quit_flag): New function.
85 * lisp.h (QUIT): Use it.
86
a0c3fad0
JD
872011-12-04 Jan Djärv <jan.h.d@swipnet.se>
88
89 * nsfns.m (get_geometry_from_preferences): New function.
90 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
91
6c07aac2
AS
922011-12-04 Andreas Schwab <schwab@linux-m68k.org>
93
94 * emacs.c (Qkill_emacs): Define.
95 (syms_of_emacs): Initialize it.
96 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
97 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
98 (quit_throw_to_read_char): Add parameter `from_signal'.
99 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
100 * lisp.h (QUIT): Call Fkill_emacs if requested.
101
c052ead4
JD
1022011-12-03 Jan Djärv <jan.h.d@swipnet.se>
103
104 * widget.c (update_wm_hints): Return if wmshell is null.
105 (widget_update_wm_size_hints): New function.
106
107 * widget.h (widget_update_wm_size_hints): Declare.
108
109 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
110 widget_update_wm_size_hints (Bug#10104).
111
9e49252b
EZ
1122011-12-03 Eli Zaretskii <eliz@gnu.org>
113
114 * xdisp.c (handle_invisible_prop): If the invisible text ends just
115 before a newline, prepare the bidi iterator for consuming the
116 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 117 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 118
02b16839
JL
1192011-12-02 Juri Linkov <juri@jurta.org>
120
121 * search.c (Fword_search_regexp): New Lisp function created from
122 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
123 (Fword_search_backward, Fword_search_forward)
124 (Fword_search_backward_lax, Fword_search_forward_lax):
125 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
126 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
127
0068070e
SM
1282011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
129
130 * fileio.c (Finsert_file_contents): Move after-change-function call
131 to before the "handled:" label, since all "goto handled" appear in
132 cases where the *-change-functions have already been properly called
133 (bug#10117).
134
3360a3fc
AS
1352011-12-01 Andreas Schwab <schwab@linux-m68k.org>
136
137 * keyboard.c (interrupt_signal): Don't call kill-emacs when
138 waiting for input. (Bug#10169)
139
73d6c093
EZ
1402011-11-30 Eli Zaretskii <eliz@gnu.org>
141
142 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
143 verifies glyph row's hash code--we have just reallocated the
144 glyphs, so their contents can be complete garbage. (Bug#10164)
145
febe6bea
JB
1462011-11-30 Juanma Barranquero <lekktu@gmail.com>
147
148 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
149
801a4313
EZ
1502011-11-30 Eli Zaretskii <eliz@gnu.org>
151
152 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
153 attributes are tested _before_ calling verify_row_hash, to protect
154 against GCC re-ordering of the tests. (Bug#10164)
155
2b56b87e
JD
1562011-11-29 Jan Djärv <jan.h.d@swipnet.se>
157
158 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
159
160 * xterm.c (handle_one_xevent): Only set async_visible and friends
161 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 162 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
163 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
164
dbf31225
PE
1652011-11-28 Paul Eggert <eggert@cs.ucla.edu>
166
167 Remove GCPRO-related macros that exist only to avoid shadowing locals.
168 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
169 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
170 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
171 All uses changed to use GCPRO1 etc.
172 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
173 Revert to old implementation (i.e., before 2011-03-11).
174
1305621b
YM
1752011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
176
177 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
178 of scroll runs so as to avoid assigning disabled bogus rows and
179 unnecessary graphics copy operations.
180
8c9afb46
EZ
1812011-11-27 Eli Zaretskii <eliz@gnu.org>
182
183 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
184 (snprintf) [_MSC_VER]: Redirect to _snprintf.
185 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
186 (malloc, free, realloc, calloc): Redirect to e_* only when
187 compiling Emacs.
188
189 * lisp.h (GCTYPEBITS): Move before first use.
190 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
191 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
192 this macro definition.
193
194 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
195 _MSC_VER.
196
54e9e3bf
JD
1972011-11-27 Jan Djärv <jan.h.d@swipnet.se>
198
6d5eb5b0
SM
199 * gtkutil.c (xg_create_frame_widgets):
200 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
201 present with Gtk+ 2.0.
202
83aca1cb
PE
2032011-11-26 Paul Eggert <eggert@cs.ucla.edu>
204
205 * fileio.c (Finsert_file_contents): Undo previous change; see
206 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
207
5b76caa4
PE
2082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
209
210 Rename locals to avoid shadowing.
211 * fileio.c (Finsert_file_contents):
212 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
213 * process.c (wait_reading_process_output):
214 Rename inner 'proc' to 'p' to avoid shadowing.
215 Indent for consistency with usual Emacs style.
216
8c535114
EZ
2172011-11-25 Eli Zaretskii <eliz@gnu.org>
218
219 * xdisp.c (redisplay_window): If cursor row is not fully visible
220 after recentering, and scroll-conservatively is set to a large
221 number, scroll window by a few more lines to make the cursor fully
222 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
223 (start_display): Don't move to the next line if the display should
224 start at a newline that is part of a display vector or an overlay
225 string. (Bug#10119)
8c535114 226
fa4fdb5c
JL
2272011-11-24 Juri Linkov <juri@jurta.org>
228
229 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
230 after the `MagickPingImage' call. (Bug#10112)
231
90ec88df
CY
2322011-11-23 Chong Yidong <cyd@gnu.org>
233
234 * window.c (Fcoordinates_in_window_p): Accept only live windows.
235
56e2e794
MR
2362011-11-23 Martin Rudalics <rudalics@gmx.at>
237
238 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
239 making another buffer current. (Bug#10114)
240
b6e64c41
GM
2412011-11-23 Glenn Morris <rgm@gnu.org>
242
243 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
244
6b21de18
CY
2452011-11-23 Chong Yidong <cyd@gnu.org>
246
247 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
248 using it (Bug#5984).
249
b12cd789
EZ
2502011-11-22 Eli Zaretskii <eliz@gnu.org>
251
252 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
253 and header-lines, as they don't have one computed for them.
254 (Bug#10098)
255
256 * .gdbinit (prow): Make displayed values more self-explaining.
257 Add row's hash code.
258
261b6fd4
LMI
2592011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
260
261 * process.c (wait_reading_process_output): Fix asynchrounous
262 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 263 (wait_reading_process_output): Add comment and URL.
261b6fd4 264
e7cfd277
JD
2652011-11-21 Jan Djärv <jan.h.d@swipnet.se>
266
267 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
268
a9b9b7f5
CY
2692011-11-21 Chong Yidong <cyd@gnu.org>
270
271 * window.c (Fnext_window, Fprevious_window): Doc fix.
272
b0d15b4f
SM
2732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
274
275 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
276
fe7a3057
JB
2772011-11-20 Juanma Barranquero <lekktu@gmail.com>
278
279 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
280
d2999b1a
MR
2812011-11-20 Martin Rudalics <rudalics@gmx.at>
282
283 * window.c (Fset_window_combination_limit): Rename argument
284 STATUS to LIMIT.
285 (Vwindow_combination_limit): Remove "status" from doc-string.
286
d5ff9cd0
AS
2872011-11-20 Andreas Schwab <schwab@linux-m68k.org>
288
289 * m/ibms390.h: Remove.
290 * m/ibms390x.h: Don't include "ibms390.h".
291
a5bb9bd3
SM
2922011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
293
294 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
295 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
296
cd1181db
JB
2972011-11-20 Juanma Barranquero <lekktu@gmail.com>
298
299 * casetab.c (Fset_case_table):
300 * charset.c (Fcharset_after): Fix typos.
301
615a3b8d 3022011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 303
17e845af
PE
304 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
305 Otherwise, valgrind does not work on some platforms.
306 Problem reported by Andreas Schwab in
6a0bf43d
PE
307 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
308 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
309 is set, removing the need for VIRT_ADDRESS_VARIES.
310 (PURE_P): Use a more-efficient implementation that needs just one
311 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
312 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
313 to 4 (xorl, subq, cmpq, setbe).
314 * alloc.c (pure): Always extern now, since that's the
315 VIRT_ADDR_VARIES behavior.
316 (PURE_POINTER_P): Use a single comparison, not two, for
317 consistency with the new puresize.h.
318 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
319 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
320 Remove VIRT_ADDR_VARIES no longer needed.
321
f8fe6f96
EZ
3222011-11-19 Eli Zaretskii <eliz@gnu.org>
323
324 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
325 (erase_phys_cursor, update_window_cursor, show_mouse_face)
326 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
327 behave as if the cursor position were at the window margin.
328
329 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
330 and the cursor position is out of bounds, behave as if the cursor
331 position were at the window margin. (Bug#10075)
332
df05a53c
CY
3332011-11-18 Chong Yidong <cyd@gnu.org>
334
335 * window.c (Fwindow_combination_limit): Make first argument
336 non-optional, since it is meaningless for live windows like the
337 selected window.
338
2071918e
DA
3392011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
340
341 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
342
b50a28de
SM
3432011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
344
345 * intervals.c: Fix grafting over the whole buffer (bug#10071).
346 (graft_intervals_into_buffer): Simplify.
347
015137db
EZ
3482011-11-18 Eli Zaretskii <eliz@gnu.org>
349
350 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
351 hash values of the two rows.
352 (copy_row_except_pointers): Preserve the used[] arrays and the
353 hash values of the two rows. (Bug#10035)
68c95424 354 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
355
356 * xdisp.c (row_hash): New function, body extracted from
357 compute_line_metrics.
358 (compute_line_metrics): Call row_hash, instead of computing the
359 hash code inline.
360
361 * dispnew.c (verify_row_hash): Call row_hash for computing the
362 hash code of a row, instead of duplicating code from xdisp.c.
363
364 * dispextern.h (row_hash): Add prototype.
365
a2addb04
TH
3662011-11-18 Tassilo Horn <tassilo@member.fsf.org>
367
368 * frame.c (delete_frame): Don't delete the terminal when the last
369 X frame is closed if emacs is built with GTK toolkit.
370
df85d315
JB
3712011-11-17 Juanma Barranquero <lekktu@gmail.com>
372
373 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
374
a0c2d0ae
MR
3752011-11-17 Martin Rudalics <rudalics@gmx.at>
376
377 * window.c (Vwindow_splits): Rename to
378 Vwindow_combination_resize. Suggested by Juri Linkov.
379 (Fsplit_window_internal): Use Vwindow_combination_resize instead
380 of Vwindow_splits.
381
58179cce
JB
3822011-11-16 Juanma Barranquero <lekktu@gmail.com>
383
7877f373
JB
384 * nsfns.m (Fns_font_name):
385 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 386
b6f67890
MR
3872011-11-16 Martin Rudalics <rudalics@gmx.at>
388
389 * window.h (window): Rename slot "nest" to "combination_limit".
390 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
391 (Fset_window_nest): Rename to Fset_window_combination_limit.
392 (Vwindow_nest): Rename to Vwindow_combination_limit.
393 (recombine_windows, make_parent_window, make_window)
394 (Fsplit_window_internal, saved_window)
395 (Fset_window_configuration, save_window_save): Rename all
396 occurrences of window_nest to window_combination_limit.
397
c7015153
JB
3982011-11-15 Juanma Barranquero <lekktu@gmail.com>
399
400 * image.c (imagemagick_load_image): Fix typo.
401
322ad6ec
EZ
4022011-11-14 Eli Zaretskii <eliz@gnu.org>
403
404 * xdisp.c (display_line): Move the call to
405 highlight_trailing_whitespace before the call to
406 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
407 faces of all the glyphs to compute ROW's hash value.
408 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 409
f067b8ec
JB
4102011-11-14 Juanma Barranquero <lekktu@gmail.com>
411
412 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
413 just return (bug#10044).
414
1e5b2111
EZ
4152011-11-12 Eli Zaretskii <eliz@gnu.org>
416
7ef3cbd5
EZ
417 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
418 with user-defined heap size. Bump the default size of the temacs
419 heap to 27MB, to avoid memory warning when running temacs.
420 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
421
1e5b2111
EZ
422 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
423 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
424 (verify_row_hash) [XASSERTS]: New function.
425 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
426 that the hash value of glyph rows is correct.
1e5b2111 427
89d61221
MR
4282011-11-12 Martin Rudalics <rudalics@gmx.at>
429
430 * window.h (window): Remove splits slot.
431 * window.c (Fwindow_splits, Fset_window_splits): Remove.
432 (Fdelete_other_windows_internal, make_parent_window)
433 (make_window, Fsplit_window_internal, Fdelete_window_internal)
434 (Fset_window_configuration, save_window_save): Don't deal with
435 split status of windows.
436 (saved_window): Remove splits slot.
437 (Vwindow_splits): Rewrite doc-string.
438
97f18cc8
JD
4392011-11-11 Jan Djärv <jan.h.d@swipnet.se>
440
441 * xfns.c (unwind_create_frame):
442 * nsfns.m (unwind_create_frame):
443 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
444 Vframe_list (Bug#9999).
445
22a648b4
DA
4462011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
447
0b381c7e 448 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 449
659afede
KH
4502011-11-11 Kenichi Handa <handa@m17n.org>
451
452 * callproc.c (Fcall_process): Set the member dst_multibyte of
453 process_coding.
454
9ac0394b
KH
4552011-11-11 Johan Bockgård <bojohan@gnu.org>
456
457 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
458 avoid a crash (bug#9496).
459
2fbdc249
CY
4602011-11-09 Chong Yidong <cyd@gnu.org>
461
462 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
463 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
464
ac6b1f81
PE
4652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
466
467 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
468
09db192c
PE
4692011-11-08 Paul Eggert <eggert@cs.ucla.edu>
470
471 Avoid some portability problems by eschewing 'extern inline' functions.
472 The trivial performance wins aren't worth the portability hassles; see
473 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
474 et seq.
475 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
476 (window_box_width, window_box_left, window_box_left_offset)
477 (window_box_right, window_box_right_offset): Undo previous change,
478 by removing the "extern"s.
479 * intervals.c (adjust_intervals_for_insertion)
480 (adjust_intervals_for_deletion): Undo previous change,
481 making these static again.
482 (offset_intervals, temp_set_point_both, temp_set_point)
483 (copy_intervals_to_string): No longer inline.
484 * xdisp.c (window_text_bottom_y, window_box_width)
485 (window_box_height, window_box_left_offset)
486 (window_box_right_offset, window_box_left, window_box_right)
487 (window_box): No longer inline.
488
105216ed
CY
4892011-11-08 Chong Yidong <cyd@gnu.org>
490
491 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
492 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
493 Signal an error if not a live window.
105216ed
CY
494 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
495 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
496
ae9e237f
JB
4972011-11-07 Juanma Barranquero <lekktu@gmail.com>
498
499 * lisp.h (syms_of_abbrev): Remove declaration.
500 Reported by CHENG Gao <chenggao@royau.me>.
501
c7aa8333
EZ
5022011-11-07 Eli Zaretskii <eliz@gnu.org>
503
504 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
505 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
506 of temacs in GUI mode.
507
be7f5545
MR
5082011-11-07 Martin Rudalics <rudalics@gmx.at>
509
510 * window.h: Declare delete_all_child_windows instead of
511 delete_all_subwindows.
512 * window.c (Fwindow_nest, Fset_window_nest)
513 (Fset_window_new_total, Fset_window_new_normal)
514 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
515 (delete_all_subwindows): Rename to delete_all_child_windows.
516 (Fdelete_other_windows_internal, Fset_window_configuration):
517 Call delete_all_child_windows instead of delete_all_subwindows.
518 * frame.c (delete_frame): Call delete_all_child_windows instead
519 of delete_all_subwindows.
520
ca78dc43
PE
5212011-11-07 Paul Eggert <eggert@cs.ucla.edu>
522
523 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
524 This is also needed for porting to any host where GC_MARK_STACK is
525 not GC_MAKE_GCPROS_NOOPS.
526 (which_symbols): Use it.
527
a0241d01
KH
5282011-11-07 Kenichi Handa <handa@m17n.org>
529
530 * coding.c (coding_set_destination): Check coding->src_pos only
531 when coding->src_object is a buffer (bug#9910).
532
533 * process.c (send_process): Set the member src_multibyte of coding
534 to 0 (bug#9911) when sending a unibyte text.
535
536 * callproc.c (Fcall_process): Set the member src_multibyte of
537 process_coding to 0 (bug#9912).
538
a64bfdfa 5392011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
540
541 * xmenu.c (cleanup_widget_value_tree): New function.
542 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
543 calling free_menubar_widget_value_tree directly (Bug#9830).
544
cb41b32a
PE
5452011-11-06 Paul Eggert <eggert@cs.ucla.edu>
546
547 Fix some portability problems with 'inline'.
548 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
549 (window_box_width, window_box_left, window_box_left_offset)
550 (window_box_right, window_box_right_offset): Declare extern.
551 Otherwise, these inline functions do not conform to C99 and
552 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
553 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
554 * intervals.c (adjust_intervals_for_insertion)
555 (adjust_intervals_for_deletion): Now extern, because otherwise the
556 extern inline functions 'offset_intervals' couldn't refer to it.
557 (static_offset_intervals): Remove.
558 (offset_intervals): Rewrite using the old contents of
559 static_offset_intervals. The old version didn't conform to C99
560 because an extern inline function contained a reference to an
561 identifier with static linkage.
562
b7041366
AS
5632011-11-06 Andreas Schwab <schwab@linux-m68k.org>
564
565 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
566 GC.
567
88a37c4d
EZ
5682011-11-06 Eli Zaretskii <eliz@gnu.org>
569
570 * xdisp.c (init_iterator, reseat_to_string): Don't set the
571 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
572 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
573 return Qleft_to_right.
574
49745b39
CY
5752011-11-06 Chong Yidong <cyd@gnu.org>
576
577 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
578 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
579 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
580 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
581 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
582 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
583 (Fwindow_vscroll): Doc fix.
584 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
585 argument, since it makes no sense to pass a live window and for
586 consistency with window-child.
587
1f05cd82
CS
5882011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
589
590 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
591 support MSVC.
592
22610910
JR
5932011-11-05 Jason Rumney <jasonr@gnu.org>
594
595 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
596 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
597 fonts (Bug#6029).
598 (add_font_entity_to_list): Fix logic errors in mixed boolean and
599 bitwise arithmetic preventing use of unicode-sip and non-truetype
600 opentype fonts.
601
a06776b2
EZ
6022011-11-05 Eli Zaretskii <eliz@gnu.org>
603
3ad924ba
EZ
604 * s/ms-w32.h (fstat, stat, utime): Move redirections to
605 "emacs"-only part.
606
a06776b2
EZ
607 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
608 initialization code to keep similarity to xfns.c after changes
609 from 2011-11-05.
610
c9e7db78
JD
6112011-11-05 Jan Djärv <jan.h.d@swipnet.se>
612
a97f8f3f
JD
613 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
614 (unwind_create_frame): New function (Bug#9943).
615 (Fx_create_frame): Restructure code to be more similar to the one in
616 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
617 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
618 Move terminal->reference_count++ just before making the frame official
619 (Bug#9943).
620
621 * nsterm.m (x_free_frame_resources): New function.
622 (x_destroy_window): Move code to x_free_frame_resources.
623
c9e7db78 624 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
625 (Fx_create_frame, x_create_tip_frame):
626 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
627 official. Move initialization of image_cache_refcount and
628 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
629
a6fc3b5c
EZ
6302011-11-05 Eli Zaretskii <eliz@gnu.org>
631
632 Support MSVC build with newer versions of Visual Studio.
633 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
634 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
635 nt/gmake.defs.
636
637 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
638 which are not supported by MSVC.
639 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
640 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
641 bitfields.
642 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
643 types in bitfields.
644 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
645
646 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
647
58179cce 6482011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
649
650 Support MSVC build with newer versions of Visual Studio.
651 * w32.c: Don't include w32api.h for MSVC.
652 (init_environment) [_MSC_VER]: Call sys_access, not _access.
653
654 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
655 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
656 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
657 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
658 e_* cousins.
659 (alloca) [_MSC_VER]: Define to _alloca.
660
661 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
662
663 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
664
a58c13ed
EZ
6652011-11-04 Eli Zaretskii <eliz@gnu.org>
666
667 * xdisp.c (note_mouse_highlight): If either of
668 previous/next-single-property-change returns nil, treat that as
669 the beginning or the end of the buffer. (Bug#9955)
670
fe0b6370
JD
6712011-11-04 Jan Djärv <jan.h.d@swipnet.se>
672
a58c13ed 673 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
674 label is not null (Bug#9951).
675 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
676 may be NULL.
677
89bd5ee1
EZ
6782011-11-04 Eli Zaretskii <eliz@gnu.org>
679
680 * window.c (Fwindow_body_size): Mention in the doc string that the
681 return value is in frame's canonical units. (Bug#9949)
682
84c3edb9
EZ
6832011-11-03 Eli Zaretskii <eliz@gnu.org>
684
4e2fb5c7
EZ
685 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
686
84c3edb9 687 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 688 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 689 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 690
bc17a887
EZ
6912011-11-01 Eli Zaretskii <eliz@gnu.org>
692
693 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
694 Don't stop backward scan on the continuation glyph, even though
695 its CHARPOS is positive.
6d5eb5b0
SM
696 (mouse_face_from_buffer_pos, note_mouse_highlight):
697 Rename cover_string to disp_string.
bc17a887 698
4ee88440
MR
6992011-11-01 Martin Rudalics <rudalics@gmx.at>
700
701 * window.c (temp_output_buffer_show): Don't use
702 Vtemp_buffer_show_specifiers.
703 (Vtemp_buffer_show_specifiers): Remove unused variable.
704
c2ff3c02
EZ
7052011-10-30 Eli Zaretskii <eliz@gnu.org>
706
707 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
708 past the beginning of the current glyph matrix.
709
58179cce 7102011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
711
712 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
713 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
714 HAVE_GTK3 (Bug#9869).
b77a6a7f 715
3b574623
JD
716 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
717 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
718
b77a6a7f
JD
719 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
720
721 * xterm.c: Declare x_handle_net_wm_state to return int.
722 (handle_one_xevent): Check if we are iconified but don't have
723 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
724 (get_current_wm_state): Return non-zero if not hidden,
725 check for _NET_WM_STATE_HIDDEN (Bug#9893).
726 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
727 (x_handle_net_wm_state): Return what get_current_wm_state returns.
728 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
729
196e41e4
PE
7302011-10-29 Paul Eggert <eggert@cs.ucla.edu>
731
732 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
733 so that this new function doesn't get optimized away by a
734 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
735
021f2e1a
AS
7362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
737
738 * frame.h (MOUSE_HL_INFO): Remove excess parens.
739
8b058d44
EZ
7402011-10-29 Eli Zaretskii <eliz@gnu.org>
741
742 Fix the `xbytecode' command.
743 * .gdbinit (xprintbytestr): New command.
b50a28de 744 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
745 (xbytecode): Print the byte-code string as well.
746
4452fb80
EZ
7472011-10-29 Kim Storm <storm@cua.dk>
748
8b058d44
EZ
749 * alloc.c (which_symbols): New function.
750
21b72067
AS
7512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
752
753 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
754 line. (Bug#9903)
755
83ed7b5c
GM
7562011-10-29 Glenn Morris <rgm@gnu.org>
757
758 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
759 Not clear what it was for, and it causes various bugs. (Bug#9839)
760
5a7a728b
EZ
7612011-10-28 Eli Zaretskii <eliz@gnu.org>
762
763 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
764 possible random value that matches one of those tested as
765 condition to clear the mouse face.
766
d3d0842f
CY
7672011-10-28 Chong Yidong <cyd@gnu.org>
768
769 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
770
31b39d13
DN
7712011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
772
773 * window.c (make_window): Initialize phys_cursor_on_p.
774
9aba6043
SM
7752011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
776
777 * lisp.h (struct Lisp_Symbol): Update comments.
778
c20992f4
JB
7792011-10-28 Juanma Barranquero <lekktu@gmail.com>
780
781 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
782
db4f02f2
EZ
7832011-10-28 Eli Zaretskii <eliz@gnu.org>
784
785 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
786 <oslsachem@gmail.com> for helping to debug this.
787
788 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
789 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
790 (g_b_init_get_glyph_outline_w): New static variables.
791 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
792 (GetGlyphOutlineW_Proc): New typedefs.
793 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
794 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
795 New functions.
796 (w32font_open_internal, compute_metrics):
797 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
798 instead of calling the "wide" APIs directly.
799
800 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
801
802 * w32.h (syms_of_w32font): Add prototype.
803
87e68db4
JB
8042011-10-27 Juanma Barranquero <lekktu@gmail.com>
805
806 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
807 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
808 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
809 (Fmove_to_window_line): Doc fix.
810
435c1d67
CY
8112011-10-27 Chong Yidong <cyd@gnu.org>
812
813 * process.c (make_process): Set gnutls_state to NULL.
814
815 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
816 non-NULL, regardless of GNUTLS_INITSTAGE.
817 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
818 an error. Set process slots as soon as we allocate them.
819
820 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
821
9c6c6f49
CY
8222011-10-27 Chong Yidong <cyd@gnu.org>
823
9aba6043
SM
824 * gnutls.c (emacs_gnutls_deinit): New function.
825 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
826 (Fgnutls_deinit, Fgnutls_boot): Use it.
827
828 * process.c (make_process): Initialize GnuTLS credentials to NULL.
829 (deactivate_process): Call emacs_gnutls_deinit.
830
657d08d3
JB
8312011-10-27 Juanma Barranquero <lekktu@gmail.com>
832
833 * image.c (x_create_x_image_and_pixmap):
834 * w32.c (sys_rename, w32_delayed_load):
835 * w32font.c (fill_in_logfont):
836 * w32reg.c (x_get_string_resource): Silence compiler warnings.
837
5430d399
JB
8382011-10-26 Juanma Barranquero <lekktu@gmail.com>
839
840 * w32fns.c (w32_default_color_map): New function,
841 extracted from Fw32_default_color_map.
a7ef684b 842 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 843
fe0055fa
PE
8442011-10-25 Paul Eggert <eggert@cs.ucla.edu>
845
846 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
847
e6346438
SM
8482011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
849
850 * keyboard.c (test_undefined): New function (bug#9751).
851 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
852
e112cc37
ET
8532011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
854
855 * sysdep.c (init_sys_modes): Fix the check for the controlling
856 terminal (Bug#6649).
857
7b5d6677
EZ
8582011-10-20 Eli Zaretskii <eliz@gnu.org>
859
860 * dispextern.h (struct bidi_it): New member next_en_type.
861
862 * bidi.c (bidi_line_init): Initialize the next_en_type member.
863 (bidi_resolve_explicit_1): When next_en_pos is valid for the
864 current character, check also for next_en_type being WEAK_EN.
865 (bidi_resolve_weak): Don't enter the expensive loop if the current
866 position is before next_en_pos. Record the bidi type of the first
867 non-ET, non-BN character we find, in addition to its position.
868 (bidi_level_of_next_char): Invalidate next_en_type when
869 next_en_pos is over-stepped.
870
7da0b018
PE
8712011-10-20 Paul Eggert <eggert@cs.ucla.edu>
872
873 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
874 * editfns.c: Rewrite current-time-zone so that it invokes
875 the equivalent of (format-time-string "%Z") to get the time zone name.
876 This fixes a bug when the time zone name contains characters that
877 need converting from the system time locale to Emacs internal format.
878 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
879 that patch fixed format-time-string to do the conversion, but
880 I forgot to fix current-time-zone.
881 (format_time_string): New function, containing most of
882 what Fformat_time_string used to contain.
883 (Fformat_time_string): Rewrite in terms of format_time_string.
884 This doesn't change this function's behavior.
885 (current-time-zone): Rewrite to use format_time_string.
886 This fixes the bug reported by Michael Schierl in
887 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
888 Jason Rumney's 2007-06-07 change worked around this bug, but
889 didn't fix it.
890 * systime.h (tzname, timezone): Remove no-longer-used declarations.
891
8547b010
EZ
8922011-10-19 Eli Zaretskii <eliz@gnu.org>
893
894 * xdisp.c (start_display): If the character at POS is displayed
895 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
896 (try_window_reusing_current_matrix): If a line ends in a display
897 vector or the next line starts in a display vector, continue
898 redrawing the window even though the character position of
899 start_row was reached.
8547b010
EZ
900 (Bug#9771, part 2)
901
4e948d15
CY
9022011-10-18 Chong Yidong <cyd@gnu.org>
903
904 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
905 with nobreak-char-display too.
906
4787455f
EZ
9072011-10-18 Eli Zaretskii <eliz@gnu.org>
908
909 Fix part 3 of bug#9771.
910 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
911 (bidi_resolve_neutral): Don't enter the expensive loop looking for
912 non-neutral characters if the current character is a paragraph
913 separator (a.k.a. Newline). This avoids running the same
914 expensive loop twice, once when we consume the preceding newline
915 and the other time when the line actually needs to be displayed.
916 Avoid the loop when we see neutrals on the base embedding level
917 following a character whose directionality is the same as the
918 paragraph's. This avoids running the expensive loop when a line
919 ends in a long sequence of neutrals, like control characters.
920 Add assertion against STRONG_AL type. Slightly rearrange code
921 that determines the type of a neutral given the first non-neutral
922 that follows it.
923 (bidi_level_of_next_char): Set next_en_pos to zero when
924 invalidating its info.
925
2c91f553
EZ
9262011-10-17 Eli Zaretskii <eliz@gnu.org>
927
928 * xdisp.c (push_display_prop): Determine whether to record string
929 or buffer position by IT->string, not by IT->method. Allow
930 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
931 (move_it_vertically_backward): Don't look for character position
932 immediately after the newline when in a continuation line.
933 (Bug#9771, part 1)
2c91f553 934
c7b08b0d
MR
9352011-10-15 Martin Rudalics <rudalics@gmx.at>
936
937 * window.c (coordinates_in_window): Rewrite and delabelize
938 vertical border check. (Bug#5357) (Bug#9618)
939
6b02f655
SM
9402011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
941
942 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
943 errors in XSetWindowBorder (bug#9310).
944
81d40c92
DA
9452011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
946
947 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
948 avoid crash when xmalloc overrun checking is enabled.
949
d4172c3b
EZ
9502011-10-13 Eli Zaretskii <eliz@gnu.org>
951
952 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
953 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
954 cursor motion with <left> and <right> arrow keys.
955
956 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
957 some callers set that themselves.
958
b00eea75
EZ
9592011-10-12 Eli Zaretskii <eliz@gnu.org>
960
961 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
962 display string and the previous row comes from the same string and
963 is empty. (Bug#9739) (Bug#9738)
964
8fe012c4
SM
9652011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
966
967 * doc.c (get_doc_string): Encode file name (bug#9735).
968
0074aef2
EZ
9692011-10-12 Eli Zaretskii <eliz@gnu.org>
970
79beb178
EZ
971 * bidi.c (bidi_level_of_next_char):
972 * xdisp.c (get_visually_first_element): Remove old incorrect
973 comments regarding the Unicode Line Separator character.
974
0074aef2
EZ
975 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
976
6e4b3fbe
DA
9772011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
978
979 * alloc.c (Fgc_status): Do not access beyond zombies array
980 boundary if nzombies > MAX_ZOMBIES.
981 * alloc.c (dump_zombies): Add missing format specifier.
982
0324f3af
PE
9832011-10-12 Paul Eggert <eggert@cs.ucla.edu>
984
b5525cac
PE
985 * xdisp.c (set_cursor_from_row): Simplify conditionals,
986 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
987
0324f3af
PE
988 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
989 Some packages use them to denote characters with modifiers.
990
e9b5f888
AS
9912011-10-11 Andreas Schwab <schwab@linux-m68k.org>
992
993 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
994 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
995 matching a pp-number. Rename parameter var to var1.
996
127827c0
SM
9972011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
998
999 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1000
c8fd3bd0
GM
10012011-10-08 Glenn Morris <rgm@gnu.org>
1002
1003 * callint.c (Fcall_interactively): Give a more explicit error for the
1004 'c' case with a non-character input. (Bug#8479)
1005
352ec8ff
EZ
10062011-10-08 Eli Zaretskii <eliz@gnu.org>
1007
03669ccb
EZ
1008 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1009 lines.
7061c986
EZ
1010 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1011 lines that are hscrolled on the left.
03669ccb 1012
352ec8ff
EZ
1013 * dispnew.c (buffer_posn_from_coords): Account for a possible
1014 presence of header-line. (Bug#4426)
1015
a66cfb1c
SM
10162011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1017
6b02f655
SM
1018 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1019 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1020
7c5ee88e
PE
10212011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1024 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1025 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1026 this makes Emacs dump core during garbage collection on rare
1027 occasions. sizeof is obviously inferior to offsetof here, so
1028 stick with offsetof.
1029 (GC_POINTER_ALIGNMENT): New macro.
1030 (mark_memory): Omit 3rd (offset) arg; caller changed.
1031 Don't assume EMACS_INT alignment is the same as pointer alignment.
1032
df1bbe5b
SM
10332011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1034
1035 * keyboard.c (read_key_sequence_remapped): New var.
1036 (read_key_sequence): Compute remapping in the right buffer.
1037 (command_loop_1): Use read_key_sequence's remapping directly.
1038
51553db6
SM
10392011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1040
32c1fffd
SM
1041 * dired.c (file_name_completion): Don't expand file name.
1042 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1043 before checking file name handler.
1044
51553db6
SM
1045 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1046 they've been requested explicitly (bug#9591).
1047
b6bd1599 10482011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1049
1050 * keymap.c (Fsingle_key_description): Use make_specified_string
1051 instead of build_string to build string from push_key_description.
1052 (Bug#5193)
1053
f701dc2a
PE
10542011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1055
4222c55d
PE
1056 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1057 This fixes a Y2038 bug on 64-bit hosts.
1058 * buffer.c (reset_buffer):
1059 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1060 (Fclear_buffer_auto_save_failure):
1061 Use 0, not -1, to represent an unset failure time, since time_t
1062 might not be signed.
1063
f701dc2a
PE
1064 Remove dependency on glibc malloc internals.
1065 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1066 Move back here from lisp.h, but with their new implementations.
1067 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1068 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1069 * charset.c (charset_table_init): New static var.
1070 (syms_of_charset): Use it instead of xmalloc. This removes a
1071 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1072 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1073 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1074 Move back to alloc.c.
1075 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1076 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1077
9ceebf39
JD
10782011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1079
1080 * nsterm.m (windowDidResize): Call x_set_window_size only when
1081 ns_in_resize is true. Otherwise set pixelwidth/height and
1082 call change_frame_size (Bug#9628).
1083
cb993c58
PE
10842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1085
3930c88b
PE
1086 Port --enable-checking=all to Fedora 14 x86-64.
1087 * charset.c (syms_of_charset): Also account for glibc malloc's
1088 internal overhead when calculating the initial malloc maximum.
1089
cb993c58
PE
1090 Port --enable-checking=all to Fedora 14 x86.
1091 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1092 Move to lisp.h.
1093 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1094 (overrun_check_realloc, overrun_check_free):
1095 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1096 That way, xmalloc returns a properly-aligned pointer even if
1097 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1098 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1099 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1100 into account when calculating the initial malloc maximum.
1101 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1102 Move here from alloc.c, so that charset.c can use it too.
1103 Properly align; the old code wasn't right for common 32-bit hosts
1104 when configured with --enable-checking=all.
1105 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1106 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1107
31bed486
EZ
11082011-09-29 Eli Zaretskii <eliz@gnu.org>
1109
04c70788 1110 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1111 use EDOM.
1112
fbcaa2f3
EZ
11132011-09-28 Eli Zaretskii <eliz@gnu.org>
1114
1115 * xdisp.c (compute_display_string_end): If there's no display
1116 string at CHARPOS, return -1.
1117
1118 * bidi.c (bidi_fetch_char): When compute_display_string_end
1119 returns a negative value, treat the character as a normal
1120 character not covered by a display string. (Bug#9624)
1121
a239d4e9
JB
11222011-09-28 Juanma Barranquero <lekktu@gmail.com>
1123
1124 * lread.c (Fread_from_string): Fix typo in docstring.
1125
88652fd5
EZ
11262011-09-27 Eli Zaretskii <eliz@gnu.org>
1127
1128 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1129 newline, reseat the iterator instead of bidi-iterating there one
1130 character at a time. (Bug#9610)
32c1fffd
SM
1131 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1132 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1133
ed497dd4
AS
11342011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1135
1136 * lread.c (readevalloop): Use correct code for NBSP.
1137 (read1): Likewise. (Bug#9608)
1138
b2bf61aa
MA
11392011-09-25 Michael Albinus <michael.albinus@gmx.de>
1140
1141 * dbusbind.c (Fdbus_register_signal): When service is not
1142 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1143
32bbb17c
GM
11442011-09-25 Glenn Morris <rgm@gnu.org>
1145
1146 * buffer.c (truncate-lines): Doc fix.
1147
94e0933e
CY
11482011-09-24 Chong Yidong <cyd@stupidchicken.com>
1149
1150 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1151 (Fset_window_next_buffers): Doc fix.
1152
cddde921
GM
11532011-09-24 Glenn Morris <rgm@gnu.org>
1154
1155 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1156
1260aef1
PE
11572011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1158
25b4bfa0
PE
1159 Fix minor problems found by static checking.
1160 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1161 * indent.c (Fvertical_motion): Fix == vs = typo.
1162
e3cbd34b
EZ
11632011-09-24 Eli Zaretskii <eliz@gnu.org>
1164
a66cfb1c
SM
1165 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1166 Default value is now t. Doc fix.
6bf7006f 1167
e3cbd34b 1168 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1169 logic when moving up, not only when moving down. Fix the
e3cbd34b 1170 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1171 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1172
1173 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1174 CHARPOS is covered by a display string which includes newlines.
1175 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1176 is covered by a display string with embedded newlines.
1177
a3de0cbd
MA
11782011-09-24 Michael Albinus <michael.albinus@gmx.de>
1179
1180 * dbusbind.c (Fdbus_register_signal): Add match rule to
1181 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1182 (Fdbus_register_method, Vdbus_registered_objects_table):
1183 Fix docstring.
a3de0cbd 1184
b260039d
JM
11852011-09-24 Jim Meyering <meyering@redhat.com>
1186
32c1fffd 1187 do not ignore write error for any output size
b260039d
JM
1188 The previous change was incomplete.
1189 While it makes emacs --batch detect the vast majority of stdout
1190 write failures, errors were still ignored whenever the output size is
1191 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1192 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1193 && echo FAIL: ignored write error
1194 FAIL: ignored write error
1195 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1196 && echo FAIL: ignored write error
1197 FAIL: ignored write error
1198 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1199
8eca8a7c
AS
12002011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1201
1202 * emacs.c (Fkill_emacs): In noninteractive mode exit
1203 non-successfully if a write error occurred on stdout. (Bug#9574)
1204
3341db62
EZ
12052011-09-21 Eli Zaretskii <eliz@gnu.org>
1206
1207 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1208 the xassert test.
1209
1210 * dispextern.h (struct it): Update the comment documenting what
1211 can it->OBJECT be.
1212
8c203dbf
EZ
12132011-09-20 Eli Zaretskii <eliz@gnu.org>
1214
1215 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1216 a display string, extend search for cursor position to end of row.
1217 (find_row_edges): If the row ends in a newline from a display
1218 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1219 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1220 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1221 non-empty line. Fixes confusing cursor motion with arrow keys at
1222 the beginning of a line that starts with whitespace.
8c203dbf 1223
a4824228
LMI
12242011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1225
1226 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1227 (bug#9493).
1228
33ed493b
CY
12292011-09-18 Chong Yidong <cyd@stupidchicken.com>
1230
1231 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1232 boolean (Bug#9154).
1233
56cd55c8
EZ
12342011-09-18 Eli Zaretskii <eliz@gnu.org>
1235
1236 * xdisp.c (display_line): Record maximum and minimum buffer
1237 positions even if no glyphs were produced (e.g., by a zero-width
1238 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1239 buffer positions that will be removed from the glyph row because
1240 they don't fit.
c02dcedf
EZ
1241 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1242 column is beyond frame width: don't subtract 1 "pixel" when
1243 computing width of the stretch.
3e62b7e0
EZ
1244 (reseat_at_next_visible_line_start): Undo the change made on
1245 2011-09-17 that saved paragraph information and restored it after
1246 the call to `reseat'. (Bug#9545)
56cd55c8 1247
5ed99d36 12482011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1249
1250 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1251 and turn window cursor on if cleared (Bug#9415).
1252
5ed99d36 12532011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1254
1255 * search.c (boyer_moore): Take unibyte characters from pattern
1256 literally. (Bug#9458)
1257
9bade7b2
EZ
12582011-09-18 Eli Zaretskii <eliz@gnu.org>
1259
1260 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1261
e5e9d610
PE
12622011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1263
87e4427a
PE
1264 Fix minor problem found by static checking.
1265 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1266 initialized, to pacify gcc -Wuninitialized.
1267
e5e9d610
PE
1268 * fileio.c: Report proper errno when syscall falls.
1269 (Finsert_file_contents): Save and restore errno,
1270 so that report_file_error outputs the correct diagnostic.
1271 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1272
a1674f0b
EZ
12732011-09-18 Eli Zaretskii <eliz@gnu.org>
1274
1275 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1276
fbfb6dd4
EZ
12772011-09-17 Eli Zaretskii <eliz@gnu.org>
1278
1279 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1280 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1281
bb187662
EZ
12822011-09-17 Eli Zaretskii <eliz@gnu.org>
1283
1137e8b8 1284 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1285 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1286
1287 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1288 (bidi_find_paragraph_start): Search back for paragraph beginning
1289 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1290 (bidi_move_to_visually_next): Only trigger paragraph-related
1291 computations when the last character is a newline or at EOB, not
1292 just any NEUTRAL_B. (Bug#9470)
1293
bb187662
EZ
1294 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1295 truncated lines if point is covered by a display string. (Bug#9524)
1296
2e621251
PE
12972011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1300 (cons_to_x_long): New function.
1301 (lisp_data_to_selection_data): Use it. Correct the test for
1302 short-versus-long data; it was negated. Break out of vector
1303 loop, for efficiency, when a long datum is discovered.
1304
91a15bc6
SM
13052011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1306
1307 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1308
b41c3a35
EZ
13092011-09-16 Eli Zaretskii <eliz@gnu.org>
1310
1311 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1312 GCC PR/17406) by declaring this function with external scope.
1313
7812ba2d
PE
13142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1317 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1318
cf7edc2a
AS
13192011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1320
1321 * editfns.c (Fformat): Correctly handle text properties on "%%".
1322
bd01620e
EZ
13232011-09-15 Eli Zaretskii <eliz@gnu.org>
1324
1325 * xterm.c (x_draw_composite_glyph_string_foreground):
1326 * w32term.c (x_draw_composite_glyph_string_foreground):
1327 * term.c (encode_terminal_code):
1328 * composite.c (composition_update_it, get_composition_id):
1329 * xdisp.c (get_next_display_element)
1330 (fill_composite_glyph_string): Add comments about special meaning
1331 of TAB characters in a composition.
1332
a02719a3
PE
13332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1334
1335 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1336 This occurs when processing a multibyte format.
1337 Problem reported by Wolfgang Jenker.
a02719a3 1338
72589a3c
JB
13392011-09-15 Johan Bockgård <bojohan@gnu.org>
1340
1341 * xdisp.c (try_cursor_movement): Only check for exact match if
1342 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1343
1c14176c
PE
13442011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 Remove unused external symbols.
1347 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1348 * xdisp.c (calc_pixel_width_or_height): Now static.
1349 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1350 * indent.c (check_display_width):
1351 * w32term.c: Fix comment to match code.
1352 * xterm.c, xterm.h (x_catching_errors): Remove.
1353
d2eea5b5
PE
13542011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 * xselect.c: Use signed conversions more consistently (Bug#9498).
1357 (selection_data_to_lisp_data): Assume incoming selection data are
1358 signed integers, not unsigned. This is to be consistent with
1359 outgoing selection data, which was modified to use signed integers
1360 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1361 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1362 expects long, not unsigned long.
1363
46888499
EZ
13642011-09-14 Eli Zaretskii <eliz@gnu.org>
1365
1366 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1367 computation of loop end. Reported by Johan Bockgård
1368 <bojohan@gnu.org>.
1369
ef8ef9fb
CY
13702011-09-13 Chong Yidong <cyd@stupidchicken.com>
1371
1372 * frame.c (Fother_visible_frames_p): Function deleted.
1373
fa819fed
EZ
13742011-09-12 Eli Zaretskii <eliz@gnu.org>
1375
1376 * indent.c (compute_motion): Process display vector front to back
1377 rather than the other way around. (Bug#2496)
1378
2ba8e008
SM
13792011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1380
1381 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1382
20f53c69
CY
13832011-09-11 Chong Yidong <cyd@stupidchicken.com>
1384
1385 * minibuf.c (Fread_from_minibuffer): Doc fix.
1386
d562d7a4
EZ
13872011-09-11 Eli Zaretskii <eliz@gnu.org>
1388
1389 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1390 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1391
1c4d7f3d
LMI
13922011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1393
1394 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1395 value for non-existent files.
1396
b885bf36
EZ
13972011-09-11 Eli Zaretskii <eliz@gnu.org>
1398
1399 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1400 set its "size" to -1. This will set the modtime_size field of
1401 the corresponding buffer to -1, which is what
1402 verify-visited-file-modtime expects for files that do not exist.
1403 (Bug#9139)
1404
6612f0bf
PE
14052011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1406
1407 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1408 here ...
1409 * lisp.h: ... from here. push_key_description is no longer
1410 defined in keyboard.c, so its declaration should not be in
1411 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1412 logically belongs with push_key_description.
1413
dfb3f755
PE
14142011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1415
1416 * buffer.h: Include <sys/types.h> instead of <time.h>.
1417 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1418 Problem reported by Herbert J. Skuhra.
1419
3134906c
LMI
14202011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1421
1422 * xml.c (parse_region): Make the parsing work for
1423 non-comment-starting XML files again (bug#9144).
1424
8d903f4e
AS
14252011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1426
1427 * image.c (gif_load): Fix calculation of bottom and right corner.
1428 (Bug#9468)
1429
80ad64f4
EZ
14302011-09-10 Eli Zaretskii <eliz@gnu.org>
1431
1432 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1433 redisplay in small windows.
1434
208a048d
EZ
14352011-09-09 Eli Zaretskii <eliz@gnu.org>
1436
1437 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1438
9b1c252e
MR
14392011-09-08 Martin Rudalics <rudalics@gmx.at>
1440
1441 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1442 Operate on live windows only.
1443
2949f33b
JB
14442011-09-08 Juanma Barranquero <lekktu@gmail.com>
1445
1446 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1447
e08dcafd
EZ
14482011-09-07 Eli Zaretskii <eliz@gnu.org>
1449
1450 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1451 only under bidi iteration.
1452
115b96bd
JD
14532011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1454
1455 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1456
c8199d0f
PE
14572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1460 Without this fix, the command to link temacs failed due to an
1461 undefined symbol __builtin_isnan. This is because
1462 /usr/include/iso/math_c99.h #defines isnan(x) to
1463 __builtin_isnan(x), but the bundled gcc, which identifies itself
1464 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1465 a __builtin_isnan.
1466 * floatfns.c (isnan): #undef, and then #define to a clone of
1467 what's in data.c.
1468 (Fisnan): Always define, since it's always available now.
1469 (syms_of_floatfns): Always define isnan at the Lisp level.
1470
e39b275c 14712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1472
1473 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1474
b2db44d9 14752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1476
f4af5137 1477 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1478 The previous code assumed that file offsets (off_t values) fit in
1479 EMACS_INT variables, which is not true on typical 32-bit hosts.
1480 The code messed up by falsely reporting buffer overflow in cases
1481 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1482 when "big" contains more than 2**29 bytes, even though this
1483 inserts just one byte and does not overflow the buffer.
1484 (Finsert_file_contents): Store file offsets as off_t
1485 values, not as EMACS_INT values. Check for overflow when
1486 converting between EMACS_INT and off_t. When checking for
1487 buffer overflow or for overlap, take the offsets into account.
1488 Don't use EMACS_INT for small values where int suffices.
1489 When checking for overlap, fix a typo: ZV was used where
1490 ZV_BYTE was intended.
1491 (Fwrite_region): Don't assume off_t fits into 'long'.
1492 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1493
ecfc0a49
MA
14942011-09-05 Michael Albinus <michael.albinus@gmx.de>
1495
1496 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1497
6511acf2 14982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1499
0999621a 1500 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1501
1502 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1503 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1504 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1505 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1506 (modify_event_symbol): Do not assume that the length of
1507 name_alist_or_stem is safe to alloca and fits in int.
1508 (Fexecute_extended_command): Likewise for function name and binding.
1509 (Frecursion_depth): Wrap around reliably on integer overflow.
1510 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1511 since some callers pass EMACS_INT values.
1512 (Fsingle_key_description): Don't crash if symbol name contains more
1513 than MAX_ALLOCA bytes.
1514 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1515 (get_minibuffer): Arg is now EMACS_INT, not int.
1516 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1517 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1518 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1519
2be7d702
PE
1520 * dbusbind.c (signature_cat): New function.
1521 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1522 Do not overrun buffer; instead, report string overflow.
1523
9d1df220
PE
1524 * dispnew.c (add_window_display_history): Don't overrun buffer.
1525 Truncate instead; this is OK since it's just a log.
1526
33ef5c64
PE
1527 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1528 even if the time zone offset is outlandishly large.
1529 Don't mishandle offset == INT_MIN.
1530
66c6fdd5
PE
1531 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1532 when creating daemon; the previous buffer-overflow check was incorrect.
1533
d749b01b
PE
1534 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1535 which has the guts of the old verror function.
1536
b5cd1905
PE
1537 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1538 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1539
6e1a67fb
PE
1540 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1541 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1542 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1543 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1544 length of string rather than counting it via multiple sprintfs;
1545 that's simpler and more reliable.
c21721cc
PE
1546 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1547 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1548 sprintf, in case result does not fit in int.
1549
c57b67fc
PE
1550 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1551 (fontset_from_font): Print it.
1552
8a401434
PE
1553 * frame.c (tty_frame_count): Now printmax_t, not int.
1554 (make_terminal_frame, set_term_frame_name): Print it.
1555 (x_report_frame_params): In X, window IDs are unsigned long,
1556 not signed long, so print them as unsigned.
1557 (validate_x_resource_name): Check for implausibly long names,
1558 and don't assume name length fits in 'int'.
1559 (x_get_resource_string): Don't blindly alloca invocation name;
1560 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1561 not fit in int.
1562
6e1a67fb
PE
1563 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1564 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1565 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1566
0df02bf3
PE
1567 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1568 Use esprintf, not sprintf, in case result does not fit in int.
1569
48e30793
PE
1570 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1571 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1572 it as a large positive number.
1573 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1574 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1575
a66ff6d8
PE
1576 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1577 in case result does not fit in int.
1578
aca216ff
PE
1579 * print.c (float_to_string): Detect width overflow more reliably.
1580 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1581 buffer overrun. Don't assume list length fits in 'int'. Treat
1582 print length of 0 as 0, not as infinity; to be consistent with other
1583 uses of print length in this function. Don't overflow print length
1584 index. Don't assume hash table size fits in 'long', or that
1585 vectorlike size fits in 'unsigned long'.
1586
31c286f7
PE
1587 * process.c (make_process): Use printmax_t, not int, to format
1588 process-name gensyms.
1589
55e5faa1
PE
1590 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1591
80f2e268
PE
1592 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1593 to avoid potential buffer overrun.
1594
670741ab
PE
1595 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1596 if X resource line is longer than 512 bytes.
1597
b7163a50
PE
1598 * xfns.c (x_window): Make sprintf buffer a bit bigger
1599 to avoid potential buffer overrun.
1600
ae58ff1f
PE
1601 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1602
c43c8a6a
PE
1603 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1604
3f8236f4
PE
16052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1606
53e9fe90 1607 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1608 Without these, Emacs silently mishandles large integers sometimes.
1609 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1610 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1611
6511acf2
PE
1612 * xdisp.c (try_window_id): Check Emacs fixnum range before
1613 converting to 'int'.
806add1d 1614
6511acf2 1615 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1616 Check that an Emacs fixnum is in range before assigning it to 'int'.
1617 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1618 values converted from Emacs fixnums.
1619 (Frecenter): Don't wrap around a line count if it is out of 'int'
1620 range; instead, treat it as an extreme value.
1621 (Fset_window_configuration, compare_window_configurations):
1622 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1623
6511acf2
PE
1624 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1625 that can exceed INT_MAX. Check that EMACS_INT value is in range
1626 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1627 (match_limit): Don't assume that a fixnum can fit in 'int'.
1628
6511acf2 1629 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1630 exceed INT_MAX.
1631
6511acf2 1632 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1633 (Fvertical_motion): Don't wrap around LINES values that don't fit
1634 in 'int'. Instead, treat them as extreme values. This is good
1635 enough for windows, which can't have more than INT_MAX lines anyway.
1636
fcb901a7
LMI
16372011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1638
0f2f6b6d
LMI
1639 * Require libxml/parser.h to avoid compilation warning.
1640
fcb901a7
LMI
1641 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1642
1643 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1644 since this reportedly can destroy thread storage.
1645
6e20a0d4
CY
16462011-08-30 Chong Yidong <cyd@stupidchicken.com>
1647
1648 * syntax.c (find_defun_start): Update all cache variables if
1649 exiting early (Bug#9401).
1650
148ae00e
EZ
16512011-08-30 Eli Zaretskii <eliz@gnu.org>
1652
f6cfbd8f
EZ
1653 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1654
148ae00e
EZ
1655 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1656 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1657 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1658
1659 * term.c (tty_append_glyph): New function.
1660 (produce_stretch_glyph): Static function and its prototype deleted.
1661
a66cfb1c
SM
1662 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1663 Add prototypes.
148ae00e 1664
c4a07a4c
PE
16652011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1668 when checking :margin (Bug#9390).
1669 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1670 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1671 so that the name doesn't mislead. All uses changed.
1672
6bc8cd65
JB
16732011-08-28 Johan Bockgård <bojohan@gnu.org>
1674
1675 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1676 set_tty_hooks.
1677
dca4927e
EZ
16782011-08-27 Eli Zaretskii <eliz@gnu.org>
1679
1680 * xdisp.c (move_it_to): Don't bail out early when reaching
1681 position beyond to_charpos, if we are scanning backwards.
1682 (move_it_vertically_backward): When DY == 0, make sure we get to
1683 the first character in the line after the newline.
1684
f2cad773
PE
16852011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1686
1687 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1688 (ccl_driver): Do not generate an out-of-range pointer.
1689 (Fccl_execute_on_string): Remove unnecessary check for
1690 integer overflow, noted by Stefan Monnier in
1691 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1692 Remove a FIXME that didn't need fixing.
1693 Simplify the newly-introduced buffer reallocation code.
1694
0cae2cdb
JB
16952011-08-27 Juanma Barranquero <lekktu@gmail.com>
1696
1697 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1698
5fc295a4 16992011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1700
70c60eb2 1701 Integer and memory overflow issues (Bug#9196).
726e0ab1 1702
d31850da
PE
1703 * doc.c (get_doc_string): Rework so that
1704 get_doc_string_buffer_size is the actual buffer size, rather than
1705 being 1 less than the actual buffer size; this makes xpalloc more
1706 convenient.
1707
a69fbedb
PE
1708 * image.c (x_allocate_bitmap_record, cache_image):
1709 * xselect.c (Fx_register_dnd_atom):
1710 Simplify previous changes by using xpalloc.
1711
fe5c5d37
PE
1712 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1713 since either will do and ptrdiff_t is convenient with xpalloc.
1714
0065d054
PE
1715 * charset.c (charset_table_size)
1716 (struct charset_sort_data.priority): Now ptrdiff_t.
1717 (charset_compare): Don't overflow if priorities differ greatly.
1718 (Fsort_charsets): Don't assume list length fits in int.
1719 Check for size-calculation overflow when allocating sort data.
1720 (syms_of_charset): Allocate an initial charset table that is
1721 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1722
1723 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1724
1725 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1726 The actual value is always <= INT_MAX, and leaving it unsigned made
1727 overflow checking harder.
1728
1729 * dispextern.h (struct glyph_matrix.rows_allocated)
1730 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1731 with xpalloc. The values are still always <= INT_MAX.
1732
1733 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1734
1735 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1736 (SAFE_NALLOCA): New macro.
1737
1738 * region-cache.c (struct boundary.pos, find_cache_boundary)
1739 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1740 (set_cache_region, invalidate_region_cache)
1741 (revalidate_region_cache, know_region_cache, region_cache_forward)
1742 (region_cache_backward, pp_cache):
1743 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1744 so that ptrdiff_t * can be passed to xpalloc.
1745 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1746 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1747 (pp_cache): Don't assume cache_len fits in int.
1748 * region-cache.h: Adjust extern decls to match.
1749
1750 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1751 EMACS_INT, since either will do, for xpalloc.
1752
1753 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1754 (xnmalloc, xnrealloc, xpalloc): New functions.
1755
726e0ab1
PE
1756 * bidi.c (bidi_shelve_header_size): New constant.
1757 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1758 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1759
51f30bc5 1760 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1761 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1762 (overlay_strings):
1763 Don't update size of array until after memory allocation succeeds,
1764 because xmalloc/xrealloc may not return.
0065d054
PE
1765 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1766 now that we have proper integer overflow checking.
1767 (record_overlay_string, overlay_strings): Catch overflows when
1768 calculating size of overlay_str_buf.
726e0ab1 1769
0065d054
PE
1770 * callproc.c (Fcall_process): Check for size overflow when
1771 calculating size of args2.
1772 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1773 Normally we prefer signed values, but sticking with ptrdiff_t would
1774 require adding more-complicated checks.
726e0ab1
PE
1775
1776 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1777 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1778 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1779 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1780
1781 * character.c (Fstring): Check for size-calculation overflow.
1782
1783 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1784 unnecessary integer overflow. Check for size overflow.
1785 (encode_coding_object): Don't update size until xmalloc succeeds.
1786
1787 * composite.c (get_composition_id): Check for overflow in glyph
1788 length calculations.
1789
1790 Integer and memory overflow fixes for display code.
1791 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1792 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1793 (scrolling_window): Check for overflow in size calculations.
1794 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1795 Don't assume glyph table len fits in int.
1796 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1797 (row_table_size): Now ptrdiff_t, not int.
1798 (scrolling_window): Avoid overflow in size calculations.
1799 Don't update size until allocation succeeds.
1800 * fns.c (concat): Check for overflow in size calculations.
1801 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1802 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1803 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1804
1805 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1806 (get_doc_string): Check for size calculation overflow.
1807 Don't update size until allocation succeeds.
1808 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1809 EMACS_INT, where ptrdiff_t will do.
1810 (Fsubstitute_command_keys): Check for string overflow.
1811
1812 * editfns.c (set_time_zone_rule): Don't assume environment length
1813 fits in int.
1814 (message_length): Now ptrdiff_t, not int.
1815 (Fmessage_box): Don't update size until allocation succeeds.
1816 Don't assume message length fits in int.
1817 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1818
0065d054
PE
1819 * emacs.c (main): Do not reallocate argv, since there is a null at
1820 the end that can be overwritten, and this way there's no need to
1821 worry about size-calculation overflow.
1822 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1823
1824 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1825 alloc succeeds.
1826 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1827
1828 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1829 (x_set_scroll_bar_width, x_figure_window_size):
1830 Check for integer overflow.
1831 (x_set_alpha): Do not assume XINT fits in int.
1832
1833 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1834 This is for the members text_lines, text_cols, total_lines, total_cols,
1835 where the system imposes an 'int' limit.
1836
1837 * fringe.c (Fdefine_fringe_bitmap):
1838 Don't update size until alloc works.
1839
1840 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1841 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1842
1843 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1844 Check for size-calculation overflow.
1845 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1846 do, as we prefer signed integers.
1847 (id_to_widget.max_size, id_to_widget.used)
1848 (xg_store_widget_in_map, xg_remove_widget_from_map)
1849 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1850 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1851 Use and return ptrdiff_t, not int.
1852 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1853 * gtkutil.h: Change prototypes to match the above.
1854
1855 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1856 are duplicate now that they've been promoted to lisp.h.
1857 (x_allocate_bitmap_record, x_alloc_image_color)
1858 (make_image_cache, cache_image, xpm_load):
1859 Don't update size until alloc is done.
1860 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1861 (x_detect_edges):
3256efce 1862 Check for size calculation overflow.
726e0ab1
PE
1863 (ct_colors_allocated_max): New constant.
1864 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1865 overflow.
3256efce 1866
726e0ab1
PE
1867 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1868 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1869 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1870 Use ptrdiff_t, not int, to count maps.
1871 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1872 calculations. Don't update size until allocation succeeds.
1873 Redo calculations to avoid overflow.
726e0ab1
PE
1874 * keyboard.h: Change prototypes to match the above.
1875
1876 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1877 to count maps.
1878 (current_minor_maps): Check for size calculation overflow.
1879 * keymap.h: Change prototypes to match the above.
1880
1881 * lread.c (read1, init_obarray): Don't update size until alloc done.
1882
1883 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1884 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1885
726e0ab1
PE
1886 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1887 Now ptrdiff_t, not int.
1888 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1889 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1890
1891 * process.c (Fnetwork_interface_list): Check for overflow
1892 in size calculation.
1893
1894 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1895
1896 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1897 overflow. Don't bother calling xmalloc when xrealloc will do.
1898
1899 * search.c (Freplace_match): Check for size calculation overflow.
1900 (Fset_match_data): Don't assume list lengths fit in 'int'.
1901
1902 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1903 for command line length. Do not attempt to address one before the
1904 beginning of an array, as that's not portable.
1905
1906 * term.c (max_frame_lines): Remove; unused.
1907 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1908 not int.
1909 (encode_terminal_code, calculate_costs): Check for size
1910 calculation overflow.
1911 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1912 table lengths and related sizes. Don't update size until alloc
1913 done. Redo calculations to avoid overflow.
1914 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1915
1916 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1917 subtracting pointers.
1918 (gobble_line): Check for overflow more carefully. Don't update size
1919 until alloc done.
1920
1921 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1922 Don't update size until alloc done.
1923 Redo size calculations to avoid overflow.
1924 Check for size calculation overflow.
0065d054 1925 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1926
1927 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1928 Use ptrdiff_t, not int, for sizes.
1929 (store_mode_line_noprop_char): Don't update size until alloc done.
1930
0065d054
PE
1931 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1932 Use ptrdiff_t, not int, for sizes.
1933 (Finternal_make_lisp_face, cache_face):
1934 Check for size calculation overflow.
1935 (cache_face): Treat size calculation overflows as if they were
1936 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1937
1938 * xfns.c (x_encode_text, x_set_name_internal)
1939 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1940 sizes, since they can exceed INT_MAX in size. Check for size
1941 calculation overflow.
1942
0065d054
PE
1943 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1944 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1945 Don't update size until alloc done.
1946
0065d054 1947 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1948 as sprintf is limited to int lengths.
1d526e2f 1949
252c5ee1
PE
1950 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1951 (X_LONG_MIN): New macros.
864d7ce7
PE
1952 Use them to make the following changes clearer.
1953 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1954 This change doesn't affect the value now, but it may help remind
1955 future maintainers not to raise the value too much later.
1956 (SELECTION_QUANTUM): Remove, replacing with ...
1957 (selection_quantum): ... new function, which avoids overflow.
1958 All uses changed.
1959 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1960 assumption that selection length fits in 'int'.
1961 (x_reply_selection_request, x_handle_selection_request)
1962 (x_get_window_property, receive_incremental_selection)
1963 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1964 (lisp_data_to_selection_data, clean_local_selection_data):
1965 Use ptrdiff_t, not int, to record length of selection.
1966 (x_reply_selection_request, x_get_window_property)
1967 (receive_incremental_selection, x_property_data_to_lisp):
1968 Redo calculations to avoid overflow.
1969 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1970 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1971 something.
1972 (x_get_window_property, receive_incremental_selection)
1973 (lisp_data_to_selection_data, x_property_data_to_lisp):
1974 Check for size-calculation overflow.
1975 (x_get_window_property, receive_incremental_selection)
1976 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1977 Don't store size until memory allocation succeeds.
1978 (x_get_window_property): Plug memory leak on memory exhaustion.
1979 Don't double-block input; malloc is safe here. Don't assume 2**34
1980 - 4 fits in unsigned long. Add an xassert to check
1981 XGetWindowProperty overflow. Be more careful about overflow
1982 calculations, and distinguish size from memory overflow better.
1983 (receive_incremental_selection): When tracing, don't assume
1984 unsigned int is less than INT_MAX.
1985 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1986 harmful) conversions of unsigned short to int.
1987 (lisp_data_to_selection_data): Don't assume that integers
1988 in the range -65535 through -1 fit in an X unsigned short.
1989 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1990 result parameters unless successful. Rely on cons_to_unsigned
1991 to report problems with elements; the old code wasn't right anyway.
1992 (x_check_property_data): Check for int overflow; we cannot use
1993 a wider type due to X limits.
1994 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1995
726e0ab1 1996 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1997
0065d054
PE
1998 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1999 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2000 (x_color_cells): Don't store size until memory allocation succeeds.
2001 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2002 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2003 (x_term_init): Don't assume length fits in int (sprintf is limited
2004 to int size).
bc18e09d 2005
ebfa62c0
PE
2006 Use ptrdiff_t for composition IDs.
2007 * character.c (lisp_string_width):
2008 * composite.c (composition_table_size, n_compositions)
2009 (get_composition_id, composition_gstring_from_id):
2010 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2011 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2012 * window.c (Frecenter):
2013 Use ptrdiff_t, not int, for composition IDs.
2014 * composite.c (get_composition_id): Check for integer overflow.
2015 * composite.h: Adjust prototypes to match the above changes.
2016
d3411f89
PE
2017 Use ptrdiff_t for hash table indexes.
2018 * category.c (hash_get_category_set):
2019 * ccl.c (ccl_driver):
2020 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2021 * coding.c (coding_system_charset_list, detect_coding_system):
2022 * coding.h (struct coding_system.id):
2023 * composite.c (get_composition_id, gstring_lookup_cache):
2024 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2025 * image.c (xpm_get_color_table_h):
2026 * lisp.h (hash_lookup, hash_put):
2027 * minibuf.c (Ftest_completion):
2028 Use ptrdiff_t for hash table indexes, not int (which is too
2029 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2030 32-bit --with-wide-int hosts).
2031
e097a6fa
PE
2032 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2033 Add a FIXME comment about memory leaks.
2034 (syms_of_charset): Don't assume xmalloc returns.
2035
5637687f
PE
2036 Don't assume that stated character widths fit in int.
2037 * character.c (Fchar_width, c_string_width, lisp_string_width):
2038 * character.h (CHAR_WIDTH):
2039 * indent.c (MULTIBYTE_BYTES_WIDTH):
2040 Use sanitize_char_width to avoid undefined and/or bad behavior
2041 with outlandish widths.
a66cfb1c 2042 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2043 now that we have two such functions. All uses changed.
2044 (sanitize_char_width): New inline function.
2045
a2271ba2
PE
2046 Don't assume that tab-width fits in int.
2047 * character.h (sanitize_width): New inline function.
2048 (SANE_TAB_WIDTH): New macro.
2049 (ASCII_CHAR_WIDTH): Use it.
2050 * indent.c (sane_tab_width): Remove. All uses replaced by
2051 SANE_TAB_WIDTH (current_buffer).
2052 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2053
18c52557
PE
2054 * fileio.c: Integer overflow issues with file modes.
2055 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2056
caeeedc1
PE
2057 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2058 Remove unreachable code.
2059 (read_hex, load_charset_map_from_file): Check for integer overflow.
2060
50849c52
PE
2061 * xterm.c: don't go over XClientMessageEvent limit
2062 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2063 (x_send_scroll_bar_event): Likewise. Check that the size does not
2064 exceed limits imposed by XClientMessageEvent, as well as the usual
2065 ptrdiff_t and size_t limits.
2066
b13995db
PE
2067 * keyboard.c: Overflow, signedness and related fixes.
2068 (make_lispy_movement): Use same integer type in forward decl
2069 that is used in the definition.
2070 (read_key_sequence, keyremap_step):
2071 Change bufsize argument back to int, undoing my 2011-03-30 change.
2072 We prefer signed types, and int is wide enough here.
2073 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2074 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2075 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2076 length, not size_t. Use ptrdiff_t for index, not int.
2077 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2078 possibility of integer overflow.
2079
13464394
PE
2080 Overflow, signedness and related fixes for images.
2081
2082 * dispextern.h (struct it.stack[0].u.image.image_id)
2083 (struct_it.image_id, struct image.id, struct image_cache.size)
2084 (struct image_cache.used, struct image_cache.ref_count):
2085 * gtkutil.c (update_frame_tool_bar):
2086 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2087 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2088 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2089 * nsmenu.m (update_frame_tool_bar):
2090 * xdisp.c (calc_pixel_width_or_height):
2091 * xfns.c (image_cache_refcount):
2092 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2093 on typical 64-bit hosts.
2094
2095 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2096 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2097 Omit unnecessary casts to int.
2098 (parse_image_spec): Check that integers fall into 'int' range
2099 when the callers expect that.
2100 (image_ascent): Redo ascent calculation to avoid int overflow.
2101 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2102 (lookup_image): Remove unnecessary tests.
2103 (xbm_image_p): Locals are now of int, not EMACS_INT,
2104 since parse_image_check makes sure they fit into int.
2105 (png_load, gif_load, svg_load_image):
2106 Prefer int to unsigned where either will do.
2107 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2108 old tiff_error_handler and tiff_warning_handler.
2109 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2110 stack buffer overflows. It uses only the features of vsnprintf
2111 that are common to both POSIX and native Microsoft.
2112 (tiff_error_handler, tiff_warning_handler): Use it.
2113 (tiff_load, gif_load, imagemagick_load_image):
2114 Don't assume :index value fits in 'int'.
2115 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2116 (imagemagick_load_image): Check that crop parameters fit into
2117 the integer types that MagickCropImage accepts. Don't assume
2118 Vimagemagick_render_type has a nonnegative value. Don't assume
2119 size_t fits in 'long'.
2120 (gs_load): Use printmax_t to print the widest integers possible.
2121 Check for integer overflow when computing image height and width.
2122
c11821d4
EZ
21232011-08-26 Eli Zaretskii <eliz@gnu.org>
2124
2125 * xdisp.c (redisplay_window): Don't force window start if point
2126 will be invisible in the resulting window. (Bug#9324)
2127
0c95fcf7
EZ
21282011-08-25 Eli Zaretskii <eliz@gnu.org>
2129
2130 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2131 the display spec is of the form `(space ...)'.
2132 (handle_display_spec): Return the value returned by
2133 handle_single_display_spec, not just 1 or zero.
2134 (handle_single_display_spec): If the display spec is of the form
2135 `(space ...)', and specifies display in the text area, return 2
2136 rather than 1.
fee65a97 2137 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2138 accurately, and prefer exact match for point under bidi.
2139 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2140
2141 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2142 into disp_prop; all users changed.
2143
2144 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2145 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2146 for the text covered by the display property.
2147
e4ed06f1
CY
21482011-08-25 Chong Yidong <cyd@stupidchicken.com>
2149
2150 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2151 Change return value to nil.
2152 (Frecord_buffer): Delete unused function.
2153
f67cdd7f
EZ
21542011-08-24 Eli Zaretskii <eliz@gnu.org>
2155
5980d4c6
EZ
2156 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2157 buffers, return left-to-right.
8610fe8b
EZ
2158 (set_cursor_from_row): Consider candidate row a win if its glyph
2159 represents a newline and point is on that newline. Fixes cursor
2160 positioning on the newline at EOL of R2L text within L2R
2161 paragraph, and vice versa.
2162 (try_cursor_movement): Check continued rows, in addition to
2163 continuation rows. Fixes unwarranted scroll when point enters a
2164 continued line of R2L text within an L2R paragraph, or vice versa.
2165 (cursor_row_p): Consider the case of point being equal to
2166 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2167 from the end of a short line to the beginning of a continued line
2168 of R2L text within L2R paragraph.
2169 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2170 composed characters.
5980d4c6 2171
f67cdd7f
EZ
2172 * bidi.c (bidi_check_type): Use xassert.
2173 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2174 members.
2175
bca633fb
EZ
21762011-08-23 Eli Zaretskii <eliz@gnu.org>
2177
2178 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2179 a character.
2180
4a5885a7
CY
21812011-08-23 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * nsfont.m (ns_otf_to_script): Fix typo.
2184
0902a04e
KH
21852011-08-22 Kenichi Handa <handa@m17n.org>
2186
2187 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2188 extra slot even if the purpose is char-code-property-table.
2189
1a2e6670
EZ
21902011-08-23 Eli Zaretskii <eliz@gnu.org>
2191
8ddde651
EZ
2192 * xdisp.c (redisplay_window): When computing centering_position,
2193 account for the height of the header line. (Bug#8874)
2194
425cc014
EZ
2195 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2196 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2197 candidate is selected by the mouse, and that candidate has a
2198 composed character under the mouse.
2199
1a2e6670
EZ
2200 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2201 coordinates reported by pos-visible-in-window-p for a composed
2202 character in column zero.
2203
8b76d6f8
SM
22042011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2205
2206 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2207
dac347dd
EZ
22082011-08-22 Eli Zaretskii <eliz@gnu.org>
2209
2210 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2211 consider it a hit if to_charpos is anywhere in the range of the
2212 composed buffer positions.
2213
e013fb34
CY
22142011-08-22 Chong Yidong <cyd@stupidchicken.com>
2215
2216 * image.c (gif_load): Don't assume that each subimage has the same
2217 dimensions as the base image. Handle disposal method that is
2218 "undefined" by the gif spec (Bug#9335).
2219
bd1ba3e8
CY
22202011-08-20 Chong Yidong <cyd@stupidchicken.com>
2221
2222 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2223 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2224
54a1215b
EZ
22252011-08-19 Eli Zaretskii <eliz@gnu.org>
2226
823564e5
EZ
2227 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2228 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2229 from an Org mode buffer to a Speedbar frame.
2230
54a1215b
EZ
2231 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2232 a composition, take its buffer position from IT->cmp_it.charpos.
2233 Fixes cursor positioning at the beginning of a line that begins
2234 with a composed character.
2235
9778ebcc
EZ
22362011-08-18 Eli Zaretskii <eliz@gnu.org>
2237
0be6ee06
EZ
2238 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2239 character bidirectional type, use STRONG_L instead. Fixes crashes
2240 in a buffer produced by `describe-categories'.
2241
9778ebcc
EZ
2242 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2243 members before the level stack, so they would be saved and
2244 restored when copying iterator state. Fixes incorrect reordering
2245 around TABs covered by display properties.
2246
156bffbe
AS
22472011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2248
6b02f655 2249 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2250
72ad093b
CY
22512011-08-17 Chong Yidong <cyd@stupidchicken.com>
2252
2253 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2254 (internal_condition_case_2, internal_condition_case_n):
2255 Remove unnecessary aborts (Bug#9081).
72ad093b 2256
35774242
EZ
22572011-08-17 Eli Zaretskii <eliz@gnu.org>
2258
2259 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2260 has no `load' handler, try opening the file locally. (Bug#9311)
2261
db76dd85
KB
22622011-08-16 Ken Brown <kbrown@cornell.edu>
2263
2264 * gmalloc.c: Expand comment.
2265
b215eee5
EZ
22662011-08-16 Eli Zaretskii <eliz@gnu.org>
2267
2268 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2269 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2270
a4579d33
KB
22712011-08-16 Ken Brown <kbrown@cornell.edu>
2272
2273 Fix memory allocation problems in Cygwin build (Bug#9273).
2274
2275 * unexcw.c ( __malloc_initialized): Declare external variable.
2276 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2277
8b76d6f8
SM
2278 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2279 New variables.
a4579d33
KB
2280 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2281 dumped emacs.
2282 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2283 in the static heap.
2284 [CYGWIN] (special_realloc): New function.
2285 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2286 requests to realloc storage in the static heap.
2287
3ebec551
PE
22882011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2289
2290 * bidi.c (bidi_initialize): Remove unused local.
2291
9fd8be00
EZ
22922011-08-15 Eli Zaretskii <eliz@gnu.org>
2293
6b02f655
SM
2294 * bidimirror.h:
2295 * biditype.h: Remove file.
2296 * makefile.w32-in ($(BLD)/bidi.$(O)):
2297 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2298
2299 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2300
2301 * chartab.c: Improve commentary for the uniprop_table API.
2302
32413314
EZ
2303 * bidi.c (bidi_paragraph_init): Support zero value of
2304 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2305 (bidi_initialize): Use uniprop_table instead of including
2306 biditype.h and bidimirror.h.
32413314 2307
9fd8be00
EZ
2308 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2309 coordinates of the iterator when restoring from ppos_it.
2310 (Bug#9296)
2311
5cf2b69b
KH
23122011-08-14 Kenichi Handa <handa@m17n.org>
2313
2314 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2315 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2316
daf17d00
EZ
23172011-08-14 Eli Zaretskii <eliz@gnu.org>
2318
2319 * xdisp.c (move_it_in_display_line_to): Don't invoke
2320 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2321 ppos_it. Fixes vertical cursor motion when line beginning is
2322 covered by an image. (Bug#9296)
2323
08e3161a
JD
23242011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2325
2326 * nsterm.h (ns_run_ascript): Declare.
2327 (NSAPP_DATA2_RUNASSCRIPT): Define.
2328
2329 * nsfns.m (as_script, as_result, as_status): New static variables.
2330 (ns_run_ascript): New function.
5e617bc2 2331 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2332 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2333 the event loop. Get status from as_status (Bug#7276).
2334
2335 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2336 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2337 the event loop (Bug#7276).
2338
a3720aa2
AS
23392011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2340
2341 * gnutls.c (QCgnutls_bootprop_priority)
2342 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2343 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2344 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2345 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2346 (QCgnutls_bootprop_verify_hostname_error)
2347 (QCgnutls_bootprop_callbacks_verify): Rename from
2348 Qgnutls_bootprop_..., all uses changed.
2349
2350 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2351 uses changed.
2352
0a0d27fb
PE
23532011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2354
19d5c50c
PE
2355 * xfaces.c (Qframe_set_background_mode): Now static.
2356 * dispextern.h (Qframe_set_background_mode): Remove decl.
2357
0a0d27fb
PE
2358 * process.c (Fnetwork_interface_info): Declare local only if needed.
2359
377538cb
JD
23602011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2361
2362 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2363 (Fnetwork_interface_list): Allocate in increments of bytes instead
2364 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2365 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2366 sockaddr.
2367 (struct ifflag_def): notrailers is smart on OSX.
2368 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2369 Get hardware address with getifaddrs if available.
2370
08fff70c
EZ
23712011-08-12 Eli Zaretskii <eliz@gnu.org>
2372
2373 * xdisp.c (iterate_out_of_display_property): xassert that
2374 IT->position is set to within IT->object's boundaries. Break from
2375 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2376 when IT->position is set up wrongly due to some bug.
2377 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2378 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2379 entry. Force push_it to save on the stack the current
2380 buffer/string position, to be restored by pop_it. Fix flags in
2381 the iterator structure wrt the object coming from a display
2382 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2383 properties. (Bug#9284)
2384
7be1c708 23852011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2386
7be1c708
CY
2387 * fontset.c (fontset_get_font_group): Add proper type checks.
2388 (Bug#9172)
aac0c6e3 2389
7be1c708 23902011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2391
7be1c708
CY
2392 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2393 and LC_VERSION_MIN_MACOSX.
2394 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2395 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2396
97bb72a6
EZ
23972011-08-08 Eli Zaretskii <eliz@gnu.org>
2398
2399 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2400 no-display-properties-and-no-overlays under bidi display.
2401 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2402 properties and overlays.
97bb72a6 2403
d5617611
CY
24042011-08-08 Chong Yidong <cyd@stupidchicken.com>
2405
37e11a63
CY
2406 * editfns.c (Fset_time_zone_rule): Document relationship with the
2407 setenv function.
2408
d5617611
CY
2409 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2410 the font entity extracted from the cache (Bug#8109).
2411
58872834
CY
24122011-08-07 Chong Yidong <cyd@stupidchicken.com>
2413
2414 * composite.c (autocmp_chars): Don't reset point. That is done by
2415 restore_point_unwind (Bug#5984).
2416
75bfc667
JL
24172011-08-07 Juri Linkov <juri@jurta.org>
2418
2419 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2420 to show the arg `TIME' instead of `TIMEVAL'.
2421
d1410150
EZ
24222011-08-06 Eli Zaretskii <eliz@gnu.org>
2423
2424 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2425 display property strides EOL and includes a newline, as in
2426 longlines-mode. (Bug#9254)
75b771e4
EZ
2427 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2428 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2429
2430 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2431 is non-zero, even if the data buffer is NULL. Fixes a crash in
2432 vertical-motion with longlines-mode. (Bug#9254)
2433
35928349
EZ
24342011-08-05 Eli Zaretskii <eliz@gnu.org>
2435
ec7cc85b
EZ
2436 * bidi.c <bidi_cache_total_alloc>: Now static.
2437 (bidi_initialize): Initialize bidi_cache_total_alloc.
2438
8b76d6f8 2439 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2440 cache. (Bug#9221)
2441
2442 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2443 amount allocated this far in `bidi_cache_total_alloc'.
2444 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2445 non-zero, only free the data buffer without restoring the cache
2446 contents. All callers changed.
2447
2448 * dispextern.h (bidi_unshelve_cache): Update prototype.
2449
2450 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2451 (move_it_in_display_line, move_it_to)
2452 (move_it_vertically_backward, move_it_by_lines): Replace the call
2453 to xfree to an equivalent call to bidi_unshelve_cache.
2454 (move_it_in_display_line_to): Fix logic of returning
412b6358 2455 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2456
e2e2423b
EZ
24572011-08-05 Eli Zaretskii <eliz@gnu.org>
2458
2459 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2460 came from a string character with a `cursor' property. (Bug#9229)
2461
ae9e757a
JD
24622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2463
2464 * Makefile.in (LIB_PTHREAD): New variable.
2465 (LIBES): Add LIB_PTHREAD (Bug#9216).
2466
2467 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2468 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2469
213bd7f2
AS
24702011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2471
6b02f655 2472 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2473
99aaf75f
JD
24742011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2475
2476 * xterm.c (x_find_topmost_parent): New function.
2477 (x_set_frame_alpha): Find topmost parent window with
2478 x_find_topmost_parent and set the property there also (bug#9181).
2479 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2480
c74e9d86
PE
24812011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2482
2483 * callproc.c (Fcall_process): Avoid vfork clobbering
2484 the local vars buffer, coding_systems, current_dir.
2485
640c8776
SM
24862011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2487
2488 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2489
f26d0e4c
PE
24902011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2491
8a10d76c
PE
2492 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2493 so that it is not optimized away.
2494
f26d0e4c
PE
2495 * xdisp.c (compute_display_string_pos): Remove unused local.
2496
55439c61
EZ
24972011-08-02 Eli Zaretskii <eliz@gnu.org>
2498
2499 Fix slow cursor motion and scrolling in large buffers with
2500 selective display, like Org Mode buffers. (Bug#9218)
2501
2502 * dispextern.h (struct bidi_it): New member disp_prop_p.
2503
2504 * xdisp.c: Remove one-slot cache of display string positions.
2505 (compute_display_string_pos): Accept an additional argument
5e617bc2 2506 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2507 for a display string or property. If found, set DISP_PROP_P
2508 non-zero.
2509
2510 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2511 DISP_PROP_P, and pass it to compute_display_string_pos.
2512 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2513 non-zero. All callers of bidi_fetch_char changed.
2514
fb33fa43
SM
25152011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2516
2517 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2518
b099e063
DM
25192010-12-03 Don March <don@ohspite.net>
2520
2521 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2522 last character M-[char] is translated to ESC [char] (bug#7541).
2523
5cc7f7af
KH
25242011-08-02 Kenichi Handa <handa@m17n.org>
2525
d0fffa3f 2526 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2527
2528 * chartab.c (uniprop_table): Make it non-static.
2529
525d5e6e
EZ
25302011-08-01 Eli Zaretskii <eliz@gnu.org>
2531
2532 * xdisp.c (forward_to_next_line_start): Accept additional argument
2533 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2534 on the newline.
2535 (reseat_at_next_visible_line_start): Use the bidi iterator state
2536 returned by forward_to_next_line_start to restore the state of
2537 it->bidi_it after backing up to previous newline. (Bug#9212)
2538
31011111
AS
25392011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2540
2541 * regex.c (re_comp): Protoize.
2542 (re_exec): Fix return type.
2543 (regexec): Fix type of `ret'. (Bug#9203)
2544
476371c4
PE
25452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2546
e5d76069
PE
2547 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2548 This is needed if max-image-size is a floating-point number.
2549
9a79b20c
AS
25502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2551
2552 * print.c (print_object): Print empty symbol as ##.
2553
2554 * lread.c (read1): Read ## as empty symbol.
2555
d8c2fa78
AA
25562011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2557
2558 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2559 setting frame foreground color (Bug#9175).
2560 (x_set_background_color): Likewise.
2561
ffe57a7a
AA
2562 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2563 contents (Bug#9176).
2564 (EmacsTooltip -init): Remove bezels and add shadows to
2565 tooltip windows.
2566
bf3492a5
AA
2567 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2568 or scroll bar (Bug#8470).
2569
d55e9c53
AA
2570 * nsfont.m (nsfont_open): Remove assignment to voffset and
2571 unnecessary vars hshink, expand, hd, full_height, min_height.
2572 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2573
2574 * nsterm.h (nsfont_info): Remove voffset field.
2575
d8c2fa78 25762011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2577
2578 Implement strike-through and overline on NextStep (Bug#8863).
2579
2580 * nsfont.m (nsfont_open): Use underline position provided by font,
2581 instead of hard-coded value of 2.
2582 (nsfont_draw): Call ns_draw_text_decoration instead.
2583
2584 * nsterm.h: Add declaration for ns_draw_text_decoration.
2585
2586 * nsterm.m (ns_draw_text_decoration): New function for drawing
2587 underline, overline, and strike-through.
2588 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2589 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2590 accommodate underlining, etc.
4843aac3 2591
4cc60b9b
EZ
25922011-07-28 Eli Zaretskii <eliz@gnu.org>
2593
bc7ece87
EZ
2594 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2595 default.
4cc60b9b 2596
476371c4
PE
25972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2598
66606eea
PE
2599 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2600 Without this fix, if a signal arrives just after memory fills up,
2601 'malloc' might be invoked reentrantly.
2602
476371c4
PE
2603 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2604 In other words, assume that every image size is allowed, on non-X
2605 hosts. This assumption is probably wrong, but it lets Emacs compile.
2606
f3fcc40d
AS
26072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2608
2609 * regex.c (re_iswctype): Convert return values to boolean.
2610
350c992f
EZ
26112011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2612
2613 * xdisp.c (compute_display_string_pos): Don't use cached display
2614 string position if the buffer had its restriction changed.
2615 (Bug#9184)
2616
5266b4bb
PE
26172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2618
2619 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2620
2573a837 26212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2622
41f55ccd 2623 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2624
39e378da
PE
2625 * bidi.c: Integer size and overflow fixes.
2626 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2627 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2628 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2629 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2630 (bidi_find_other_level_edge):
2631 Use ptrdiff_t instead of EMACS_INT where either will do.
2632 This works better on 32-bit hosts configured --with-wide-int.
2633 (bidi_cache_ensure_space): Check for size-calculation overflow.
2634 Use % rather than repeated addition, for better worst-case speed.
2635 Don't set bidi_cache_size until after xrealloc returns, because it
2636 might not return.
2637 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2638 (bidi_cache_ensure_space): Also check that the bidi cache size
2639 does not exceed that of the largest Lisp string or buffer. See Eli
2640 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2641
5e927815
PE
2642 * alloc.c (__malloc_size_t): Remove.
2643 All uses replaced by size_t. See Andreas Schwab's note
2644 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2645
ca4aa935
PE
2646 * image.c: Improve checking for integer overflow.
2647 (check_image_size): Assume that f is nonnull, since
2648 it is always nonnull in practice. This is one less thing to
2649 worry about when checking for integer overflow later.
2650 (x_check_image_size): New function, which checks for integer
2651 overflow issues inside X.
2652 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2653 This removes the need for a memory_full check.
2654 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2655 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2656 (xbm_read_bitmap_data): Change locals back to 'int', since
2657 their values must fit in 'int'.
2658 (xpm_load_image, png_load, tiff_load):
2659 Invoke x_create_x_image_and_pixmap earlier,
2660 to avoid much needless work if the image is too large.
2661 (tiff_load): Treat overly large images as if
2662 x_create_x_image_and_pixmap failed, not as malloc failures.
2663 (gs_load): Use x_check_image_size.
2664
5f8f9cc2
PE
2665 * gtkutil.c: Omit integer casts.
2666 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2667 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2668
5adf60bc
PE
2669 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2670
c8907a93
PE
2671 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2672 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2673 would wrongly return t on a 64-bit host.
2674
e3c25c68
PE
2675 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2676 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2677 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2678 and therefore cause GCC to emit a bogus diagnostic in some cases.
2679
3f791afe
PE
2680 * image.c: Integer signedness and overflow and related fixes.
2681 This is not an exhaustive set of fixes, but it's time to
2682 record what I've got.
2683 (lookup_pixel_color, check_image_size): Remove redundant decls.
2684 (check_image_size): Don't assume that arbitrary EMACS_INT values
2685 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2686 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2687 (tiff_load, imagemagick_load_image):
2688 Check for overflow in size calculations.
2689 (x_create_x_image_and_pixmap): Remove unnecessary test for
2690 xmalloc returning NULL; that can't happen.
2691 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2692 (xpm_color_bucket): Use better integer hashing function.
2693 (xpm_cache_color): Don't possibly over-allocate memory.
2694 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2695 (gif_memory_source):
2696 Use ptrdiff_t, not int or size_t, to record sizes.
2697 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2698 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2699 either works, as we prefer signed integers.
2700 (tiff_read_from_memory, tiff_write_from_memory):
2701 Return tsize_t, not size_t, since that's what the TIFF API wants.
2702 (tiff_read_from_memory): Don't fail simply because the read would
2703 go past EOF; instead, return a short read.
2704 (tiff_load): Omit no-longer-needed casts.
2705 (Fimagemagick_types): Don't assume size fits into 'int'.
2706
3cc5a532
PE
2707 Improve hashing quality when configured --with-wide-int.
2708 * fns.c (hash_string): New function, taken from sxhash_string.
2709 Do not discard information about ASCII character case; this
2710 discarding is no longer needed.
2711 (sxhash-string): Use it. Change sig to match it. Caller changed.
2712 * lisp.h: Declare it.
2713 * lread.c (hash_string): Remove, since we now use fns.c's version.
2714 The fns.c version returns a wider integer if --with-wide-int is
2715 specified, so this should help the quality of the hashing a bit.
2716
b312a492
PE
2717 * emacs.c: Integer overflow minor fix.
2718 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2719 Define only if GNU_LINUX.
2720 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2721
dfd153ae
PE
2722 * dispnew.c: Integer signedness and overflow fixes.
2723 Remove unnecessary forward decls, that were a maintenance hassle.
2724 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2725 All uses changed.
2726 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2727 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2728 (prepare_desired_row, line_draw_cost):
2729 Use int, not unsigned, where either works.
2730 (save_current_matrix, restore_current_matrix):
2731 Use ptrdiff_t, not size_t, where either works.
2732 (init_display): Check for overflow more accurately, and without
2733 relying on undefined behavior.
2734
a81d11a3
PE
2735 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2736 Remove, replacing with the new symbols in lisp.h. All uses changed.
2737 * fileio.c (make_temp_name):
2738 * filelock.c (lock_file_1, lock_file):
2739 * xdisp.c (message_dolog):
2740 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2741 Use pMd etc. instead.
2742 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2743 replacing the pWIDE etc. symbols removed from editfns.c.
2744
3300e6fd
PE
2745 * keyboard.h (num_input_events): Now uintmax_t.
2746 This is (very slightly) less likely to mess up due to wraparound.
2747 All uses changed.
2748
fd05c7e9
PE
2749 * buffer.c: Integer signedness fixes.
2750 (alloc_buffer_text, enlarge_buffer_text):
2751 Use ptrdiff_t rather than size_t when either will do, as we prefer
2752 signed integers.
2753
903fe15d
PE
2754 * alloc.c: Integer signedness and overflow fixes.
2755 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2756 (__malloc_size_t): Default to size_t, not to int.
2757 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2758 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2759 Prefer ptrdiff_t to size_t when either would do, as we prefer
2760 signed integers.
2761 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2762 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2763 Now const. Initialize with values that are in range even if char
2764 is signed.
2765 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2766 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2767 These functions do the right thing with sizes > 2**32.
2768 (check_depth): Now ptrdiff_t, not int.
2769 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2770 Adjust to new way of storing sizes. Check for size overflow bugs
2771 in rest of code.
2772 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2773 slightly wrong anyway, as it missed one instance of
2774 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2775 (refill_memory_reserve): Omit needless cast to size_t.
2776 (mark_object_loop_halt): Mark as externally visible.
2777
ac82cc6a
PE
2778 * xselect.c: Integer signedness and overflow fixes.
2779 (Fx_register_dnd_atom, x_handle_dnd_message):
2780 Use ptrdiff_t, not size_t, since we prefer signed.
2781 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2782 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2783 x_dnd_atoms_size and x_dnd_atoms_length.
2784
c2d1e36d
PE
2785 * doprnt.c: Prefer signed to unsigned when either works.
2786 * eval.c (verror):
2787 * doprnt.c (doprnt):
2788 * lisp.h (doprnt):
2789 * xdisp.c (vmessage):
2790 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2791 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2792 prefer signed arithmetic to avoid comparison confusion.
2793 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2794 but is a bit tricky.
2795
0e926e56
PE
2796 Assume freestanding C89 headers, string.h, stdlib.h.
2797 * data.c, doprnt.c, floatfns.c, print.c:
2798 Include float.h unconditionally.
2799 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2800 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2801 * regex.c: Likewise for stddef.h, string.h.
2802 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2803 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2804 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2805 (STDC_HEADERS): Remove obsolete defines.
2806 * sysdep.c: Include limits.h unconditionally.
2807
9cfdb3ec
PE
2808 Assume support for memcmp, memcpy, memmove, memset.
2809 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2810 * regex.c (memcmp, memcpy):
2811 Remove; we assume C89 now.
2812
2813 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2814 (__malloc_safe_bcopy): Remove; no longer needed.
2815
cf950e6b 2816 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2817 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2818 well either way, and we prefer signed to unsigned.
2819
dbf38e02
LMI
28202011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2821
2822 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2823 closes the connection while we're reading (bug#9182).
2824
d6f0886c 28252011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2826
d6f0886c
JD
2827 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2828 are specified (Bug#9168).
24e0f6b1 2829
2eb1f9e6
PE
28302011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2831
2832 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2833 Found by GCC static checking and --with-wide-int on a 32-bit host.
2834
22381272 28352011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2836
2837 * xdisp.c (compute_display_string_pos): Fix logic of caching
2838 previous display string position. Initialize cached_prev_pos to
2839 -1. Fixes slow-down at the beginning of a buffer.
2840
f25e39b4
EZ
28412011-07-24 Eli Zaretskii <eliz@gnu.org>
2842
2843 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2844 for attrs[LFACE_FONTSET_INDEX].
2845
04c4b52e
PE
28462011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * xml.c (parse_region): Remove unused local
2849 that was recently introduced.
2850
c1734fbd
EZ
28512011-07-23 Eli Zaretskii <eliz@gnu.org>
2852
be18c5a5
EZ
2853 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2854 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2855
c1734fbd
EZ
2856 * xdisp.c (move_it_in_display_line_to): Record the best matching
2857 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2858 exit if none of the characters scanned was an exact match.
2859 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2860 when exact match is impossible due to invisible text, and the
2861 lines are truncated.
2862
a258d627
JD
28632011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2864
2865 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2866 for OSX >= 10.7.
2867
b6d5a689
EZ
28682011-07-22 Eli Zaretskii <eliz@gnu.org>
2869
0f74f785
EZ
2870 Fix a significant slow-down of cursor motion with C-n, C-p,
2871 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2872 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2873 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2874 (next_element_from_buffer): Call compute_stop_pos_backwards to
2875 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2876 base_level_stop.
2877 (reseat): Don't look for prev_stop, as that could mean a very long
2878 run.
2879 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2880 <cached_disp_overlay_modiff>: Cache for last found display string
2881 position.
551918c1 2882 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2883 about the same buffer in the same area of character positions, and
2884 the buffer wasn't changed since the time the display string
2885 position was cached.
551918c1 2886
b2d0c91a
EZ
28872011-07-22 Eli Zaretskii <eliz@gnu.org>
2888
2889 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2890 is an integer, which is important for empty lines. (Bug#9149)
2891
043604ee
CY
28922011-07-22 Chong Yidong <cyd@stupidchicken.com>
2893
2894 * frame.c (Fmodify_frame_parameters): In tty case, update the
2895 default face if necessary (Bug#4238).
2896
da4adb04
CY
28972011-07-21 Chong Yidong <cyd@stupidchicken.com>
2898
2899 * editfns.c (Fstring_to_char): No need to explain what a character
2900 is in the docstring (Bug#6576).
2901
9abd0532
LMI
29022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2903
2904 * xml.c (parse_region): Make sure we always return a tree.
2905
36881d16
HK
29062011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2907
2908 * xml.c (parse_region): If a document contains only comments,
2909 return that, too.
2910
1e98674d
LMI
29112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2912
2913 * xml.c (make_dom): Return comments, too.
2914
590bd467
PE
29152011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 Port to OpenBSD.
2918 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2919 and the surrounding thread.
2920 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2921 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2922 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2923 timer goes off.
2924 * s/openbsd.h (BROKEN_SIGIO): Define.
2925 * unexelf.c (unexec) [__OpenBSD__]:
2926 Don't update the .mdebug section of the Alpha COFF symbol table.
2927
f41628b2
LMI
29282011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2929
2930 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2931 (bug#8460).
2932
b59b67c5
PE
29332011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2934
15e3a074
PE
2935 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2936 This fixes some race conditions on the permissions of any newly
2937 created file.
2938
41bed37d
PE
2939 * alloc.c (valid_pointer_p): Use pipe, not open.
2940 This fixes some permissions issues when debugging.
2941
b59b67c5
PE
2942 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2943 If fchown fails to set both uid and gid, try to set just gid,
2944 as that is sometimes allowed. Adjust the file's mode to eliminate
2945 setuid or setgid bits that are inappropriate if fchown fails.
2946
925a6be7
SM
29472011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2948
2949 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2950 to compare Lisp_Objects.
2951 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2952 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2953 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2954
52968808
AS
29552011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2956
0a6a104b
AS
2957 * lread.c (read_integer): Unread even EOF character.
2958 (read1): Likewise. Properly record start position of symbol.
2959
52968808
AS
2960 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2961 symbol character follows.
2962
9e381cdd
PE
29632011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2964
2965 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2966 This works around a problem with the previous change to Fcopy_file.
2967 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2968 and without this change, GCC might complain about discarding
2969 fchown's return value.
2970
b5641435
JB
29712011-07-16 Juanma Barranquero <lekktu@gmail.com>
2972
2973 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2974
a8031457
PE
29752011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2978
dd889327
LMI
29792011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2980
750c33f7
LMI
2981 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2982 it's used from the C level.
2983
dd889327
LMI
2984 * process.c: Use the same condition for POLL_FOR_INPUT in both
2985 keyboard.c and process.c (bug#1858).
2986
87e86684
LM
29872011-07-09 Lawrence Mitchell <wence@gmx.li>
2988
2989 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2990 (Fgnutls_boot): Use it.
2991
64348f40
AS
29922011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2993
2994 * doc.c (Fsubstitute_command_keys): Revert last change.
2995
1d698799
LMI
29962011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2997
f863868c
LMI
2998 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2999 quotes the next character, and doesn't affect other longer
3000 sequences (bug#8935).
3001
1d698799
LMI
3002 * lread.c (syms_of_lread): Clarify that is isn't only
3003 `eval-buffer' and `eval-defun' that's affected by
3004 `lexical-binding' (bug#8460).
3005
aa4b6df6
EZ
30062011-07-15 Eli Zaretskii <eliz@gnu.org>
3007
3008 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3009 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3010
5d856da6
PE
30112011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3012
ad6042bb
PE
3013 Fix minor problems found by static checking.
3014 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3015 (elsz): Now a signed constant, not a size_t var. We prefer signed
3016 types to unsigned, to avoid integer comparison confusion. Without
3017 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3018 "cannot optimize loop, the loop counter may overflow", a symptom
3019 of the confusion.
f00bbb22 3020 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3021 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3022
6468f31c
LMI
30232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3024
49080b10
LMI
3025 * search.c (Fre_search_backward): Mention `case-fold-search' in
3026 all the re_search_* functions (bug#8138).
3027
6468f31c
LMI
3028 * keyboard.c (Fopen_dribble_file): Document when the file is
3029 closed (bug#8056).
3030
c965adc5
EZ
30312011-07-14 Eli Zaretskii <eliz@gnu.org>
3032
df9733bf
EZ
3033 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3034 bidi_cache_idx.
3035
0bb23927
EZ
3036 Support bidi reordering of display and overlay strings.
3037 * xdisp.c (compute_display_string_pos)
3038 (compute_display_string_end): Accept additional argument STRING.
3039 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3040 (reseat_to_string): Initialize bidi_it->string.s and
3041 bidi_it->string.schars.
3042 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3043 NULL (avoids a crash in bidi_paragraph_init).
3044 Initialize itb.string.lstring.
0bb23927
EZ
3045 (init_iterator): Call bidi_init_it only of a valid
3046 buffer position was specified. Initialize paragraph_embedding to
3047 L2R.
3048 (reseat_to_string): Initialize the bidi iterator.
3049 (display_string): If we need to ignore text properties of
3050 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3051 original value of -1 will not work with bidi.)
3052 (compute_display_string_pos): First arg is now struct
3053 `text_pos *'; all callers changed. Support display properties on
3054 Lisp strings.
3055 (compute_display_string_end): Support display properties on Lisp
3056 strings.
3057 (init_iterator, reseat_1, reseat_to_string): Initialize the
3058 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3059 when iterating on a string not from display properties).
640c8776
SM
3060 (compute_display_string_pos, compute_display_string_end):
3061 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3062 arrow keys.
3063 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3064 base_level_stop; instead, set base_level_stop to BEGV.
3065 Fixes crashes in vertical-motion.
0bb23927
EZ
3066 (next_element_from_buffer): Improve commentary for when
3067 the iterator is before prev_stop.
3068 (init_iterator): Initialize bidi_p from the default value of
3069 bidi-display-reordering, not from buffer-local value. Use the
3070 buffer-local value only if initializing for buffer iteration.
3071 (handle_invisible_prop): Support invisible properties on strings
3072 that are being bidi-reordered.
3073 (set_iterator_to_next): Support bidi reordering of C strings and
3074 Lisp strings.
3075 (next_element_from_string): Support bidi reordering of Lisp
3076 strings.
3077 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3078 (display_string): Support display of R2L glyph rows.
3079 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3080 (init_iterator): Don't initialize it->bidi_p for strings
3081 here.
3082 (reseat_to_string): Initialize it->bidi_p for strings here.
3083 (next_element_from_string, next_element_from_c_string)
3084 (next_element_from_buffer): Add xassert's for correspondence
3085 between IT's object being iterated and it->bidi_it.string
3086 structure.
3087 (face_before_or_after_it_pos): Support bidi iteration.
3088 (next_element_from_c_string): Handle the case of the first string
3089 character that is not the first one in the visual order.
3090 (get_visually_first_element): New function, refactored from common
3091 parts of next_element_from_buffer, next_element_from_string, and
3092 next_element_from_c_string.
3093 (tool_bar_lines_needed, redisplay_tool_bar)
3094 (display_menu_bar): Force left-to-right direction. Add a FIXME
3095 comment for making that be controlled by a user option.
3096 (push_it, pop_it): Save and restore the state of the
3097 bidi iterator. Save and restore the bidi_p flag.
3098 (pop_it): Iterate out of display property for string iteration as
3099 well.
3100 (iterate_out_of_display_property): Support iteration over strings.
3101 (handle_single_display_spec): Set up it->bidi_it for iteration
3102 over a display string, and call bidi_init_it.
3103 (handle_single_display_spec, next_overlay_string)
3104 (get_overlay_strings_1, push_display_prop): Set up the bidi
3105 iterator for displaying display or overlay strings.
3106 (forward_to_next_line_start): Don't use the shortcut if
3107 bidi-iterating.
3108 (back_to_previous_visible_line_start): If handle_display_prop
3109 pushed the iterator stack, restore the internal state of the bidi
3110 iterator by calling bidi_pop_it same number of times.
3111 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3112 and we are bidi-iterating, don't decrement the iterator position;
3113 instead, set the first_elt flag in the bidi iterator, to produce
3114 the same effect.
3115 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3116 (push_display_prop): xassert that we are iterating a buffer.
3117 (push_it, pop_it): Save and restore paragraph_embedding member.
3118 (handle_single_display_spec, next_overlay_string)
3119 (get_overlay_strings_1, reseat_1, reseat_to_string)
3120 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3121 correctly. Don't assume unibyte strings are not bidi-reordered.
3122 (compute_display_string_pos)
3123 (compute_display_string_end): Fix handling the case of C string.
3124 (push_it, pop_it): Save and restore from_disp_prop_p.
3125 (handle_single_display_spec, push_display_prop): Set the
3126 from_disp_prop_p flag.
3127 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3128 (pop_it): Call iterate_out_of_display_property only if we are
3129 popping after iteration over a string that came from a display
3130 property. Fix a typo in popping stretch info. Add an assertion
3131 for verifying that the iterator position is in sync with the bidi
3132 iterator.
3133 (handle_single_display_spec, get_overlay_strings_1)
3134 (push_display_prop): Fix initialization of paragraph direction for
3135 string when that of the parent object is not yet determined.
3136 (reseat_1): Call bidi_init_it to resync the bidi
3137 iterator with IT's position. (Bug#7616)
3138 (find_row_edges): If ROW->start.pos gives position
3139 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3140 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3141 Reset the from_disp_prop_p flag.
3142 (SAVE_IT, RESTORE_IT): New macros.
3143 (pos_visible_p, face_before_or_after_it_pos)
3144 (back_to_previous_visible_line_start)
3145 (move_it_in_display_line_to, move_it_in_display_line)
3146 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3147 (try_scrolling, redisplay_window, display_line): Use them when
3148 saving a temporary copy of the iterator and restoring it back.
3149 (back_to_previous_visible_line_start, reseat_1)
3150 (init_iterator): Empty the bidi cache "stack".
3151 (move_it_in_display_line_to): If iterator ended up at
3152 EOL, but we never saw any buffer positions smaller than
3153 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3154 motion in bidi-reordered lines.
3155 (move_it_in_display_line_to): Record prev_method and prev_pos
3156 immediately before the call to set_iterator_to_next. Fixes cursor
3157 motion in bidi-reordered lines with stretch glyphs and strings
3158 displayed in margins. (Bug#8133) (Bug#8867)
3159 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3160 TO_CHARPOS.
640c8776
SM
3161 (pos_visible_p): Support positions in bidi-reordered lines.
3162 Save and restore bidi cache.
0bb23927
EZ
3163
3164 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3165 (bidi_paragraph_info): Delete unused struct.
3166 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3167 (bidi_cache_start): New variable.
3168 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3169 to zero.
3170 (bidi_cache_fetch_state, bidi_cache_search)
3171 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3172 (bidi_cache_find, bidi_peek_at_next_level)
3173 (bidi_level_of_next_char, bidi_find_other_level_edge)
3174 (bidi_move_to_visually_next): Compare cache index with
3175 bidi_cache_start rather than with zero.
3176 (bidi_fetch_char): Accept new argument STRING; all callers
3177 changed. Support iteration over a string. Support strings with
3178 display properties. Support unibyte strings. Fix the type of
3179 `len' according to what STRING_CHAR_AND_LENGTH expects.
3180 (bidi_paragraph_init, bidi_resolve_explicit_1)
3181 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3182 (bidi_level_of_next_char, bidi_move_to_visually_next):
3183 Support iteration over a string.
0bb23927
EZ
3184 (bidi_set_sor_type, bidi_resolve_explicit_1)
3185 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3186 can now be zero (for strings); special values 0 and -1 were
3187 changed to -1 and -2, respectively.
3188 (bidi_char_at_pos): New function.
3189 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3190 Call it instead of FETCH_MULTIBYTE_CHAR.
3191 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3192 initialized to valid values.
3193 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3194 values.
3195 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3196 the test for valid cached positions. Fix the logic for looking up
3197 the sentinel state in the cache. GCPRO the Lisp string we are
3198 iterating.
3199 (bidi_push_it, bidi_pop_it): New functions.
3200 (bidi_initialize): Initialize the bidi cache start stack pointer.
3201 (bidi_cache_ensure_space): New function, refactored from part of
3202 bidi_cache_iterator_state. Don't assume the required size is just
3203 one BIDI_CACHE_CHUNK away.
3204 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3205 (bidi_count_bytes, bidi_char_at_pos): New functions.
3206 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3207 always valid if bidi_cache_idx is valid.
3208 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3209 is valid if it's going to be used.
3210 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3211 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3212 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3213 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3214 (bidi_find_other_level_edge, bidi_cache_start_stack):
3215 All variables related to cache indices are now EMACS_INT.
c965adc5 3216
0bb23927
EZ
3217 * dispextern.h (struct bidi_string_data): New structure.
3218 (struct bidi_it): New member `string'. Make flag members be 1-bit
3219 fields, and put them last in the struct.
640c8776
SM
3220 (compute_display_string_pos, compute_display_string_end):
3221 Update prototypes.
0bb23927
EZ
3222 (bidi_push_it, bidi_pop_it): Add prototypes.
3223 (struct iterator_stack_entry): New members bidi_p,
3224 paragraph_embedding, and from_disp_prop_p.
3225 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3226 (bidi_shelve_cache, bidi_unshelve_cache):
3227 Declare prototypes.
0bb23927
EZ
3228
3229 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3230 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3231 and vector-like objects.
3232
3233 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3234 cache around display iteration.
3235
3236 * window.c (Fwindow_end, window_scroll_pixel_based)
3237 (displayed_window_lines, Frecenter): Save and restore the bidi
3238 cache around display iteration.
3239
3bbd2265
LMI
32402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3241
3242 * editfns.c (Fdelete_region): Clarify the use of the named
3243 parameters (bug#6788).
3244
adc47434
MR
32452011-07-14 Martin Rudalics <rudalics@gmx.at>
3246
3247 * indent.c (Fvertical_motion): Set and restore w->pointm when
3248 saving and restoring the window's buffer (Bug#9006).
3249
837c31f8
LMI
32502011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3251
3252 * editfns.c (Fstring_to_char): Clarify just what is returned
3253 (bug#6576). Text by Eli Zaretskii.
3254
ac389d0c
JB
32552011-07-13 Juanma Barranquero <lekktu@gmail.com>
3256
3257 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3258
0be0ce47
EZ
32592011-07-13 Eli Zaretskii <eliz@gnu.org>
3260
3261 * buffer.c (mmap_find): Fix a typo.
3262
cd18e7e3
JB
32632011-07-13 Johan Bockgård <bojohan@gnu.org>
3264
3265 Fix execution of x selection hooks.
3266 * xselect.c (Qx_lost_selection_functions)
3267 (Qx_sent_selection_functions): New vars.
3268 (syms_of_xselect): DEFSYM them.
3269 (x_handle_selection_request): Pass Qx_sent_selection_functions
3270 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3271 (x_handle_selection_clear,x_clear_frame_selections):
3272 Pass Qx_lost_selection_functions rather than
3273 Vx_lost_selection_functions to Frun_hook_with_args.
3274
47ea7f44
PE
32752011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3276
ac389d0c 3277 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3278 The old code sometimes used this field without initializing it.
3279
47ea7f44
PE
3280 * alloc.c (gc_sweep): Don't read past end of array.
3281 In theory, the old code could also have corrupted Emacs internals,
3282 though it'd be very unlikely.
3283
bc985c87
AS
32842011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3285
3286 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3287 argument. (Bug#4026)
bc985c87 3288
0cf34688
LMI
32892011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3290
b3dadd76
LMI
3291 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3292 key" (bug#4257).
3293
0cf34688
LMI
3294 * window.c (Fset_window_start): Doc fix (bug#4199).
3295 (Fset_window_hscroll): Ditto.
3296
270768cd
PE
32972011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3298
077e3dda 3299 Fix minor new problems caught by GCC 4.6.1.
270768cd 3300 * term.c (init_tty): Remove unused local.
490011a6 3301 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3302 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3303 not used otherwise.
270768cd 3304
b1f58454
CY
33052011-07-12 Chong Yidong <cyd@stupidchicken.com>
3306
3307 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3308
22b9578d
LMI
33092011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3310
6e70ab07
LMI
3311 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3312 are the mini-buffer and the echo area (bug#3320).
3313
22b9578d
LMI
3314 * term.c (init_tty): Remove support for supdup, c10 and perq
3315 terminals, which are no longer supported (bug#1482).
3316
8974cc9f
JB
33172011-07-10 Johan Bockgård <bojohan@gnu.org>
3318
3319 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3320
a560d974
JD
33212011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3322
3323 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3324 for non-popups (Bug#3642).
3325
1dae0f0a
AS
33262011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3327
268c2c36 3328 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3329 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3330 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3331 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3332 * data.c (fmod): Likewise.
3333 * dispnew.c (swap_glyphs_in_rows): Likewise.
3334 * emacs.c (memory_warning_signal): Likewise.
3335 * floatfns.c (float_error): Likewise.
3336 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3337 (otf_open, font_otf_capability, generate_otf_features)
3338 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3339 Likewise.
3340 * image.c (pbm_read_file): Likewise.
3341 * indent.c (string_display_width): Likewise.
3342 * intervals.c (check_for_interval, search_for_interval)
3343 (inc_interval_count, count_intervals, root_interval)
3344 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3345 * lread.c (defalias): Likewise.
268c2c36 3346 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3347 * regex.c (set_image_of_range_1, set_image_of_range)
3348 (regex_grow_registers): Likewise.
3349 * sysdep.c (strerror): Likewise.
3350 * termcap.c (valid_filename_p, tprint, main): Likewise.
3351 * tparam.c (main): Likewise.
3352 * unexhp9k800.c (run_time_remap, save_data_space)
3353 (update_file_ptrs, read_header, write_header, calculate_checksum)
3354 (copy_file, copy_rest, display_header): Likewise.
3355 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3356 Likewise.
3357 * xdisp.c (check_it): Likewise.
3358 * xfaces.c (register_color, unregister_color, unregister_colors):
3359 Likewise.
3360 * xfns.c (print_fontset_result): Likewise.
3361 * xrdb.c (member, fatal, main): Likewise.
3362
99033785
PE
33632011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3364
3365 Fix minor problems found by static checking (Bug#9031).
3366 * chartab.c (char_table_set_range, map_sub_char_table):
3367 Remove unused locals.
3368 (uniprop_table): Now static.
3369 * composite.c (_work_char): Remove unused static var.
3370
9cb2ac56
JB
33712011-07-09 Juanma Barranquero <lekktu@gmail.com>
3372
3373 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3374
f25661f0
JD
33752011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3376
3377 * gtkutil.c (qttip_cb): Remove code without function.
3378
8278c4fe
EZ
33792011-07-09 Eli Zaretskii <eliz@gnu.org>
3380
3381 * w32.c (pthread_sigmask): New stub.
3382
1692ae2d 33832011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3384
8a6ebd58 3385 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3386 sigprocmask is portable only for single-threaded applications, and
3387 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3388 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3389 (LIBES): Use it.
3390 * callproc.c (Fcall_process):
3391 * process.c (create_process):
3392 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3393 Use pthread_sigmask, not sigprocmask.
123403e4 3394
1b854618
JD
33952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3396
3397 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3398 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3399 wrong (Bug#8591).
3400
3fe4b549
JD
34012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3402
0ce7e563
JD
3403 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3404 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3405 (xg_hide_tooltip): Fix comment.
3406
3fe4b549
JD
3407 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3408 in registerServicesMenuSendTypes.
3409 (validRequestorForSendType): Don't check ns_return_types.
3410
3411 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3412 ns_return_type.
3413
5df75e47
JR
34142011-07-08 Jason Rumney <jasonr@gnu.org>
3415
22610910
JR
3416 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3417 SH_SHOW for hidden windows (Bug#5482).
3418
5df75e47
JR
3419 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3420 frame struct members of non-existent frames (Bug#6284).
3421
699c10bd
JD
34222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3423
4393663b
JD
3424 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3425 variable firstTime not needed on OSX >= 10.6.
3426 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3427 >= 10.5. Use setKnobProportion, setDoubleValue.
3428
3429 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3430 (MAC_OS_X_VERSION_10_5): Define if not defined.
3431 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3432 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3433 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3434
3435 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3436 cString and lossyCString on OSX >= 10.4
3437
58179cce 3438 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3439 sizeToFit on OSX >= 10.2.
3440
3441 * nsimage.m (allocInitFromFile): Don't use deprecated method
3442 bestRepresentationForDevice on OSX >= 10.6.
3443
3444 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3445 to avoid warning.
3446
3447 * emacs.c: Declare unexec_init_emacs_zone.
3448
a63e0781
JD
3449 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3450
699c10bd
JD
3451 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3452
3453 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3454 on svcsMenu (Bug#8842).
3455
3456 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3457 ns_return_types.
3458 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3459
3460 * nsterm.m (QUTF8_STRING): Declare.
3461 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3462 (validRequestorForSendType): Return type is (id).
3463 Change indexOfObjectIdenticalTo to indexOfObject.
3464 Check if we have local selection before returning self (Bug#8842).
3465 (writeSelectionToPasteboard): Put local selection into paste board
3466 if we have a local selection (Bug#8842).
3467 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3468
3469 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3470 (ns_get_local_selection): Declare.
3471
54e10184
LMI
34722011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3473
9888ff71
LMI
3474 * keymap.c (describe_map_tree): Don't insert a double newline at
3475 the end of the buffer (bug#1169) and return whether we inserted
3476 something.
3477
54e10184
LMI
3478 * callint.c (Fcall_interactively): Change "reading args" to
3479 "providing args" to try to clarify what it does (bug#1010).
3480
15fa4783
KH
34812011-07-07 Kenichi Handa <handa@m17n.org>
3482
3483 * composite.c (composition_compute_stop_pos): Ignore a static
3484 composition starting before CHARPOS (Bug#8915).
3485
3486 * xdisp.c (handle_composition_prop): Likewise.
3487
a8815b00
EZ
34882011-07-07 Eli Zaretskii <eliz@gnu.org>
3489
3490 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3491 (Bug#9015)
3492
ef7b981d 34932011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3494
3495 * character.h (unicode_category_t): New enum type.
3496
3497 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3498 (Qchar_code_property_table): New variable.
3499 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3500 (UNIPROP_COMPRESSED_FORM_P): New macros.
3501 (char_table_ascii): Uncompress the compressed values.
3502 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3503 Uncompress the compressed values.
ac389d0c 3504 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3505 (char_table_ref_and_range): Uncompress the compressed values.
3506 (sub_char_table_set): New arg is_uniprop. Callers changed.
3507 Uncompress the compressed values.
3508 (sub_char_table_set_range): Args changed. Callers changed.
3509 (char_table_set_range): Adjuted for the above change.
3510 (map_sub_char_table): Delete args default_val and parent. Add arg
3511 top. Give decoded values to a Lisp function.
640c8776 3512 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3513 values to a Lisp function. Gcpro more variables.
3514 (uniprop_table_uncompress)
3515 (uniprop_decode_value_run_length): New functions.
3516 (uniprop_decoder, uniprop_decoder_count): New variables.
3517 (uniprop_get_decoder, uniprop_encode_value_character)
3518 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3519 New functions.
3520 (uniprop_encoder, uniprop_encoder_count): New variables.
3521 (uniprop_get_encoder, uniprop_table)
3522 (Funicode_property_table_internal, Fget_unicode_property_internal)
3523 (Fput_unicode_property_internal): New functions.
3524 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3525 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3526 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3527 char-code-property-alist.
3528
640c8776 3529 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3530 Vunicode_category_table.
3531
640c8776 3532 * font.c (font_range): Adjust for the change of
c805dec0
KH
3533 Vunicode_category_table.
3534
76b397fb
DN
35352011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3536
3537 * m/iris4d.h: Remove file, move contents ...
3538 * s/irix6-5.h: ... here.
3539
22b4128e
PE
35402011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3541
3542 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3543 * alloc.c (mark_buffer):
3544 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3545 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3546 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3547 This isn't true in general, and it's particularly not true
3548 if Emacs is configured with --with-wide-int.
3549 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3550 New macros, used in the buffer.c change.
3551
869795d6
JD
35522011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3553
3554 * xsettings.c: Use both GConf and GSettings if both are available.
3555 (store_config_changed_event): Add comment.
3556 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3557 (store_tool_bar_style_changed): New functions.
5e617bc2 3558 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3559 (struct xsettings): Move font inside HAVE_XFT.
3560 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3561 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3562 Move inside HAVE_XFT.
640c8776 3563 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3564 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3565 also.
3566 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3567 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3568 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3569 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3570 (parse_settings): Move check for font inside HAVE_XFT.
3571 (read_settings, apply_xft_settings): Add comment.
3572 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3573 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3574 call store_font_name_changed.
3575 (xft_settings_event): Add comment.
3576 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3577 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3578 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3579 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3580 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3581 (xsettings_get_system_font, xsettings_get_system_normal_font):
3582 Add comment.
869795d6 3583
d8ed26bd
PE
35842011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3585
3586 Random fixes. E.g., (random) never returned negative values.
3587 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3588 subseconds part to the entropy, as that's a bit more random.
3589 Prefer signed to unsigned, since the signedness doesn't matter and
3590 in general we prefer signed. When given a limit, use a
3591 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3592 latter isn't right if USE_2_TAGS_FOR_INTS.
3593 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3594 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3595
cabf1cac
SM
35962011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3597
3598 * textprop.c (text_property_stickiness):
3599 Obey Vtext_property_default_nonsticky.
3600 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3601 * w32fns.c (syms_of_w32fns):
3602 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3603
6e9b2be9
PE
36042011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3605
3606 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3607 This is more efficient than Ffile_directory_p and avoids a minor race.
3608
90186c68
LMI
36092011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3610
7c301272
LMI
3611 * buffer.c (Foverlay_put): Say what the return value is
3612 (bug#7835).
3613
c4f2d8d4
LMI
3614 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3615 is a directory before asking whether to use the file name
3616 (bug#7564).
ad637907
LMI
3617 (barf_or_query_if_file_exists): Make the "File is a directory"
3618 error be more correct.
c4f2d8d4 3619
90186c68
LMI
3620 * fns.c (Frequire): Remove the mention of the .gz files, since
3621 that's installation-specific, but keep the mention of
3622 `get-load-suffixes'.
3623
da64016e
PE
36242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3625
3626 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3627 Report string overflow if the output is too long.
3628
7d47b580
JB
36292011-07-04 Juanma Barranquero <lekktu@gmail.com>
3630
a555cb87
JB
3631 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3632 (syms_of_gnutls): Remove duplicate DEFSYM for
3633 Qgnutls_bootprop_verify_hostname_error, an error for
3634 Qgnutls_bootprop_verify_error (which is no longer used).
3635
7d47b580
JB
3636 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3637 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3638 Also (re)move comments that are misplaced or no longer relevant.
3639
1e49bfab
LMI
36402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3641
3642 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3643
1485f4c0
CY
36442011-07-03 Chong Yidong <cyd@stupidchicken.com>
3645
3646 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3647 and background color parameters if they have been changed.
3648
a9ab721e
LMI
36492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3650
3651 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3652
cf7cff57
PE
36532011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3654
2e13213d
PE
3655 * xsettings.c (SYSTEM_FONT): Define only when used.
3656 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3657
cf7cff57
PE
3658 * keymap.c (access_keymap_1): Now static.
3659
7a8e04f7
CY
36602011-07-02 Chong Yidong <cyd@stupidchicken.com>
3661
3662 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3663 leave any prefix arg for the up event (Bug#1586).
3664
61352f62
LMI
36652011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3666
69bb1ef7
LMI
3667 * lread.c (syms_of_lread): Mention single symbols defined by
3668 `defvar' or `defconst' (bug#7154).
3669
61352f62 3670 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3671 (Frequire): Mention get-load-suffixes.
61352f62 3672
28545e04
MR
36732011-07-02 Martin Rudalics <rudalics@gmx.at>
3674
3675 * window.h (window): Remove clone_number slot.
3676 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3677 Remove.
3678 (make_parent_window, make_window, saved_window)
3679 (Fset_window_configuration, save_window_save): Don't deal with
3680 clone numbers.
3681 * buffer.c (Qclone_number): Remove declaration.
3682 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3683
3349e122
SM
36842011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3685
3686 Add multiple inheritance to keymaps.
3687 * keymap.c (Fmake_composed_keymap): New function.
3688 (Fset_keymap_parent): Simplify.
3689 (fix_submap_inheritance): Remove.
3690 (access_keymap_1): New function extracted from access_keymap to handle
3691 embedded parents and handle lists of maps.
3692 (access_keymap): Use it.
3693 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3694 (Fcopy_keymap): Handle embedded parents.
3695 (Fcommand_remapping, define_as_prefix): Simplify.
3696 (Fkey_binding): Simplify.
3697 (syms_of_keymap): Move minibuffer-local-completion-map,
3698 minibuffer-local-filename-completion-map,
3699 minibuffer-local-must-match-map, and
3700 minibuffer-local-filename-must-match-map to Elisp.
3701 (syms_of_keymap): Defsubr make-composed-keymap.
3702 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3703 (parse_menu_item): Trivial simplification.
3704
3279eb87
GM
37052011-07-01 Glenn Morris <rgm@gnu.org>
3706
3707 * Makefile.in (SETTINGS_LIBS): Fix typo.
3708
4550efdf
KI
37092011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3710
3711 * coding.c (Fencode_coding_string): Record the last coding system
3712 used, as the function doc string says (bug#8738).
3713
0949d2b6
JD
37142011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3715
3716 * xsettings.c (store_monospaced_changed): Take new font as arg and
3717 check for change against current_mono_font.
3718 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3719 (emacs_settings_constructor, emacs_settings_get_property)
3720 (emacs_settings_set_property, emacs_settings_class_init)
3721 (emacs_settings_init, gsettings_obj): Remove.
3722 (something_changedCB): New function for HAVE_GSETTINGS.
3723 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3724 with value as argument.
3725 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3726 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3727 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3728 "changed".
3729
3730 * xgselect.c: Add defined (HAVE_GSETTINGS).
3731 (xgselect_initialize): Ditto.
3732
3733 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3734 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3735 xg_select.
3736
bbc6b304
PE
37372011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3738
3739 * eval.c (struct backtrace): Simplify and port the data structure.
3740 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3741 signed bit field, as this assumption is not portable and it makes
3742 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3743 "char debug_on_exit : 1" as this is not portable either; instead,
3744 use the portable "unsigned int debug_on_exit : 1". Remove unused
3745 member evalargs. Remove obsolete comments about cc bombing out.
3746
9851bfc5
JD
37472011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3748
51bb811f 3749 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3750 Let HAVE_GSETTINGS override HAVE_GCONF.
3751 (store_monospaced_changed): New function.
3752 (EMACS_SETTINGS): A new type derived from GObject to handle
3753 GSettings notifications.
3754 (emacs_settings_constructor, emacs_settings_get_property)
3755 (emacs_settings_set_property, emacs_settings_class_init):
3756 New functions.
3757 (gsettings_client, gsettings_obj): New variables.
3758 (GSETTINGS_SCHEMA): New define.
3759 (something_changedCB): Call store_monospaced_changed.
3760 (init_gsettings): New function.
3761 (xsettings_initialize): Call init_gsettings.
3762 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3763 to NULL.
3764
640c8776 3765 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3766 GCONF_CFLAGS/LIBS.
3767
5386012d
MR
37682011-06-29 Martin Rudalics <rudalics@gmx.at>
3769
3770 * window.c (resize_root_window, grow_mini_window)
3771 (shrink_mini_window): Rename Qresize_root_window to
3772 Qwindow_resize_root_window and Qresize_root_window_vertically to
3773 Qwindow_resize_root_window_vertically.
3774
f13e0b08
PE
37752011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3776
3777 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3778
94515237
JB
37792011-06-27 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * makefile.w32-in: Redesign dependencies so they reflect more
3782 clearly which files are directly included by each source file,
3783 and not through other includes.
3784
e43b6e43
MR
37852011-06-27 Martin Rudalics <rudalics@gmx.at>
3786
3787 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3788 (sort_overlays, overlay_strings): When an overlay's clone number
3789 matches the window's clone number process the overlay even if
3790 the overlay's window property doesn't match the current window.
3791
d68443dc
MR
3792 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3793 (Fwindow_hchild): Rename to Fwindow_left_child.
3794 (Fwindow_next): Rename to Fwindow_next_sibling.
3795 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3796 (resize_window_check): Rename to window_resize_check.
3797 (resize_window_apply): Rename to window_resize_apply.
3798 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3799 (Fdelete_other_windows_internal, resize_frame_windows)
3800 (Fsplit_window_internal, Fdelete_window_internal)
3801 (grow_mini_window, shrink_mini_window)
3802 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3803
c7e73be5
JD
38042011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3805
3806 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3807 (emacs_fixed_set_min_size): Remove.
3808 (emacs_fixed_new): Take frame as argument.
3809
3810 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3811 (_EmacsFixedPrivate): Remove minwidth/height.
3812 Add struct frame *f.
3813 (emacs_fixed_init): Initialize priv->f.
3814 (get_parent_class, emacs_fixed_set_min_size): Remove.
3815 (emacs_fixed_new): Set priv->f to argument.
3816 (emacs_fixed_get_preferred_width)
3817 (emacs_fixed_get_preferred_height): Use min_width/height from
3818 frames size_hint to set minimum and natural (Bug#8919).
3819 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3820 and use min_width/height from frames size_hint to set
3821 min_width/height (Bug#8919).
3822
3823 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3824 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3825 Fix indentation.
c7e73be5 3826
cf99dcf8
EZ
38272011-06-26 Eli Zaretskii <eliz@gnu.org>
3828
3829 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3830 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3831 called at ZV.
3832
029529ac
CY
38332011-06-26 Chong Yidong <cyd@stupidchicken.com>
3834
3835 * process.c (wait_reading_process_output): Bypass select if
3836 waiting for a cell while ignoring keyboard input, and input is
3837 pending. Suggested by Jan Djärv (Bug#8869).
3838
7a7ef429
PE
38392011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3840
3841 Use gnulib's dup2 module instead of rolling our own.
3842 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3843
11fdef7d 38442011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3845
3846 * dispnew.c (scrolling_window): Before scrolling, turn off a
3847 mouse-highlight in the window being scrolled.
3848
cd3520a4
JB
38492011-06-24 Juanma Barranquero <lekktu@gmail.com>
3850
3851 Move DEFSYM to lisp.h and use everywhere.
3852
3853 * character.h (DEFSYM): Move declaration...
3854 * lisp.h (DEFSYM): ...here.
3855
3856 * gnutls.c:
3857 * minibuf.c:
3858 * w32menu.c:
3859 * w32proc.c:
3860 * w32select.c: Don't include character.h.
3861
3862 * alloc.c (syms_of_alloc):
3863 * buffer.c (syms_of_buffer):
3864 * bytecode.c (syms_of_bytecode):
3865 * callint.c (syms_of_callint):
3866 * casefiddle.c (syms_of_casefiddle):
3867 * casetab.c (init_casetab_once):
3868 * category.c (init_category_once, syms_of_category):
3869 * ccl.c (syms_of_ccl):
3870 * cmds.c (syms_of_cmds):
3871 * composite.c (syms_of_composite):
3872 * dbusbind.c (syms_of_dbusbind):
3873 * dired.c (syms_of_dired):
3874 * dispnew.c (syms_of_display):
3875 * doc.c (syms_of_doc):
3876 * editfns.c (syms_of_editfns):
3877 * emacs.c (syms_of_emacs):
3878 * eval.c (syms_of_eval):
3879 * fileio.c (syms_of_fileio):
3880 * fns.c (syms_of_fns):
3881 * frame.c (syms_of_frame):
3882 * fringe.c (syms_of_fringe):
3883 * insdel.c (syms_of_insdel):
3884 * keymap.c (syms_of_keymap):
3885 * lread.c (init_obarray, syms_of_lread):
3886 * macros.c (syms_of_macros):
3887 * msdos.c (syms_of_msdos):
3888 * print.c (syms_of_print):
3889 * process.c (syms_of_process):
3890 * search.c (syms_of_search):
3891 * sound.c (syms_of_sound):
3892 * syntax.c (init_syntax_once, syms_of_syntax):
3893 * terminal.c (syms_of_terminal):
3894 * textprop.c (syms_of_textprop):
3895 * undo.c (syms_of_undo):
3896 * w32.c (globals_of_w32):
3897 * window.c (syms_of_window):
3898 * xdisp.c (syms_of_xdisp):
3899 * xfaces.c (syms_of_xfaces):
3900 * xfns.c (syms_of_xfns):
3901 * xmenu.c (syms_of_xmenu):
3902 * xsettings.c (syms_of_xsettings):
3903 * xterm.c (syms_of_xterm): Use DEFSYM.
3904
4228cf16
TZ
39052011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3906
cd3520a4 3907 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3908
7fcccf1e
PE
39092011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3910
7efb4e0e
PE
3911 Integer and buffer overflow fixes (Bug#8873).
3912
ff5844ad
PE
3913 * print.c (printchar, strout): Check for string overflow.
3914 (PRINTPREPARE, printchar, strout):
3915 Don't set size unless allocation succeeds.
3916
90532f02
PE
3917 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3918 for sizes. Check for string overflow more accurately.
3919 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3920
6d84508d
PE
3921 * macros.c: Integer and buffer overflow fixes.
3922 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3923 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3924 Use ptrdiff_t, not int, for sizes.
3925 Don't increment bufsize until after realloc succeeds.
3926 Check for size-calculation overflow.
3927 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3928
437b2cb4
PE
3929 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3930
8b9ac8b4
PE
3931 * lread.c: Integer overflow fixes.
3932 (read_integer): Radix is now EMACS_INT, not int,
3933 to improve quality of diagnostics for out-of-range radices.
3934 Calculate buffer size correctly for out-of-range radices.
3935 (read1): Check for integer overflow in radices, and in
3936 read-circle numbers.
82cb60d3
PE
3937 (read_escape): Avoid int overflow.
3938 (Fload, openp, read_buffer_size, read1)
3939 (substitute_object_recurse, read_vector, read_list, map_obarray):
3940 Use ptrdiff_t, not int, for sizes.
3941 (read1): Use EMACS_INT, not int, for sizes.
20270765 3942 Check for size overflow.
8b9ac8b4 3943
7fcccf1e
PE
3944 * image.c (cache_image): Check for size arithmetic overflow.
3945
bfbbd7e7
PE
3946 * lread.c: Integer overflow issues.
3947 (saved_doc_string_size, saved_doc_string_length)
3948 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3949 Now ptrdiff_t, not int.
3950 (read1): Don't assume doc string length fits in int. Check for
3951 out-of-range doc string lengths.
3952 (read_list): Don't assume file position fits in int.
39019e54 3953 (read_escape): Check for hex character overflow.
bfbbd7e7 3954
4e323265
LL
39552011-06-22 Leo Liu <sdl.web@gmail.com>
3956
3957 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3958 Move to minibuffer.el.
3959
85fece3e
PE
39602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3961
20b84ce9 3962 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3963 The following patches are for when GLYPH_DEBUG && !XASSERT.
3964 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3965 * dispnew.c (flush_stdout):
3966 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3967 Mark as externally visible.
3968 * dispnew.c (check_window_matrix_pointers): Now static.
3969 * dispnew.c (window_to_frame_vpos):
3970 * xfns.c (unwind_create_frame):
3971 * xterm.c (x_check_font): Remove unused local.
3972 * scroll.c (CHECK_BOUNDS):
3973 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3974 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3975 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3976 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3977 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3978 Now static.
3979 (debug_method_add): Use va_list and vsprintf rather than relying
3980 on undefined behavior with wrong number of arguments.
3981 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3982 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3983 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3984 since we're not interested in debugging glyphs with old libraries.
3985 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3986 GCC 4.6.0's static checking.
3987
0766b489
PE
39882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3989
31fd4b32
PE
3990 Integer overflow and signedness fixes (Bug#8873).
3991 A few related buffer overrun fixes, too.
3992
b79e8648
PE
3993 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3994
0766b489
PE
3995 * dispextern.h (struct face.stipple):
3996 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3997 (x_bitmap_mask, x_allocate_bitmap_record)
3998 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3999 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4000 (x_create_bitmap_from_xpm_data):
4001 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4002 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4003 (.bitmaps_last):
4004 * xfaces.c (load_pixmap):
4005 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4006 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4007 (.bitmaps_last, struct x_output.icon_bitmap):
4008 Use ptrdiff_t, not int, for bitmap indexes.
4009 (x_allocate_bitmap_record): Check for size overflow.
4010 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4011
b081724f
PE
4012 Use ptrdiff_t, not int, for overlay counts.
4013 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4014 * editfns.c (overlays_around, get_pos_property):
4015 * textprop.c (get_char_property_and_overlay):
4016 * xdisp.c (next_overlay_change, note_mouse_highlight):
4017 * xfaces.c (face_at_buffer_position):
21514da7
PE
4018 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4019 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4020 (Fnext_overlay_change, Fprevious_overlay_change)
4021 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4022 Use ptrdiff_t, not int, for sizes.
21514da7 4023 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4024
3de73e5e
PE
4025 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4026
2606c57b
PE
4027 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4028 (x_session_initialize): Do not assume string length fits in int.
4029
aaafe47a
PE
4030 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4031 This is unlikely, but can occur if DPI is outlandish.
4032
2674ddc8 4033 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4034 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4035
28154962
PE
4036 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4037 * xrdb.c (magic_file_p, search_magic_path):
4038 Omit last arg SUFFIX; it was always 0. All callers changed.
4039 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4040
7de51af5
PE
4041 * xfont.c (xfont_match): Avoid need for strlen.
4042
25ed6cc3
PE
4043 * xfns.c: Don't assume strlen fits in int.
4044 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4045
4eab31dd
PE
4046 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4047 not unsigned long, as we prefer signed integers. All callers changed.
4048 Detect integer overflow in repeat count.
4049 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4050 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4051
171e2a58
PE
4052 * termcap.c: Don't assume sizes fit in int and never overflow.
4053 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4054 (gobble_line): Check for size-calculation overflow.
4055
ad39faca 4056 * minibuf.c (Fread_buffer):
6e5bb2dc 4057 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4058 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4059 Don't assume string length fits in int.
4060
52c61c22 4061 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4062 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4063
b5b8c9e5
PE
4064 * font.c: Don't assume string length fits in int.
4065 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4066 Use ptrdiff_t, not int.
ccd6111c
PE
4067 (font_intern_prop): Don't assume string length fits in int.
4068 Don't assume integer property fits in fixnum.
4069 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4070
882f0d81 4071 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4072 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4073 Reformulate so as not to need the command string.
4074 Invoke gzip -cd rather than gunzip, as it's more portable.
4075 (lock_info_type, lock_file_1, lock_file):
4076 Don't assume pid_t and time_t fit in unsigned long.
4077 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4078 (current_lock_owner): Prefer signed type for sizes.
4079 Use memcpy, not strncpy, where memcpy is what is really wanted.
4080 Don't assume (via atoi) that time_t and pid_t fit in int.
4081 Check for time_t and/or pid_t out of range, e.g., via a network share.
4082 Don't alloca where an auto var works fine.
4083
93f4cf88
PE
4084 * fileio.c: Fix some integer overflow issues.
4085 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4086 Don't assume string length fits in int.
4087 (directory_file_name): Don't assume string length fits in long.
4088 (make_temp_name): Don't assume pid fits in int, or that its print
4089 length is less than 20.
4090
f3e92b69
PE
4091 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4092
1bfdaf10
PE
4093 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4094
35016e9a
PE
4095 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4096
3d1e65a1
PE
4097 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4098 We prefer signed integers, even for size calculations.
4099
0b963a93
PE
4100 * emacs.c: Don't assume string length fits in 'int'.
4101 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4102 (main): Don't invoke strlen when not needed.
4103
573f4b54
PE
4104 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4105 (XD_DEBUG_MESSAGE): Don't waste a byte.
4106
989f33ba
PE
4107 * callproc.c (getenv_internal_1, getenv_internal)
4108 (Fgetenv_internal):
965d34eb
PE
4109 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4110
e4d29b33
PE
4111 * lread.c (invalid_syntax): Omit length argument.
4112 All uses changed. This doesn't fix a bug, but it simplifies the
4113 code away from its former Hollerith-constant appearance, and it's
4114 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4115 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4116
eb49b136
PE
4117 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4118 This didn't break anything, but it didn't help either.
4119 It's confusing to put a bogus integer in a place where the actual
4120 value does not matter.
9f62aeb1 4121 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4122 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4123
15375a22
PE
4124 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4125 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4126 implementation.
b61cc01c
PE
4127 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4128 We prefer signed types, and the value cannot exceed the EMACS_INT
4129 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4130 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4131 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4132 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4133
53b2623d
PE
4134 * indent.c (sane_tab_width): New function.
4135 (current_column, scan_for_column, Findent_to, position_indentation)
4136 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4137 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4138
51cab52b 4139 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4140
f2ed8a70
PE
4141 * lisp.h (lint_assume): New macro.
4142 * composite.c (composition_gstring_put_cache):
4143 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4144
abe80cc6
PE
4145 * editfns.c, insdel.c:
4146 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4147
b02c740e
PE
4148 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4149
ebc96716
PE
4150 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4151
b4e50fa0 4152 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4153 Use much-faster test for byte-length change.
311d5d7c 4154 Don't assume string byte-length fits in 'int'.
a4cf38e4 4155 Check that character arg fits in 'int'.
85461888 4156 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4157
c0c1ee9f
PE
4158 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4159
a498d7f4
PE
4160 * fns.c (concat): Catch string overflow earlier.
4161 Do not rely on integer wraparound.
4162
51cab52b
PE
4163 * dispextern.h (struct it.overlay_strings_charpos)
4164 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4165 * xdisp.c (forward_to_next_line_start)
4166 (back_to_previous_visible_line_start)
4167 (reseat_at_next_visible_line_start, next_element_from_buffer):
4168 Don't arbitrarily truncate the value of 'selective' to int.
4169
76031fad
PE
4170 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4171
5eb55db9
PE
4172 * composite.c: Don't truncate sizes to 'int'.
4173 (composition_gstring_p, composition_reseat_it)
4174 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4175 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4176 not EMACS_UINT, for indexes.
5eb55db9 4177
0703a717
PE
4178 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4179
d6202519
PE
4180 * buffer.c: Include <verify.h>.
4181 (struct sortvec.priority, struct sortstr.priority):
8961a454 4182 Now EMACS_INT, not int.
c20998a7 4183 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4184 (struct sortstr.size, record_overlay_string)
4185 (struct sortstrlist.size, struct sortlist.used):
4186 Don't truncate size to int.
4187 (record_overlay_string): Check for size-calculation overflow.
d6202519 4188 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4189
d5a19415
JM
41902011-06-22 Jim Meyering <meyering@redhat.com>
4191
029529ac 4192 Don't leak an XBM-image-sized buffer
d5a19415
JM
4193 * image.c (xbm_load): Free the image buffer after using it.
4194
a9041e6c
PE
41952011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4196
4197 Port to Sun C.
4198 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4199 that Sun C diagnosed.
4200 * fns.c (secure_hash): Fix pointer signedness issue.
4201 * intervals.c (static_offset_intervals): New function.
4202 (offset_intervals): Use it.
4203
7f3f739f
LL
42042011-06-21 Leo Liu <sdl.web@gmail.com>
4205
4206 * deps.mk (fns.o):
4207 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4208 sha512.h.
4209
4210 * fns.c (secure_hash): Rename from crypto_hash_function and change
4211 the first arg to accept symbols.
5b66d427 4212 (Fsecure_hash): New primitive.
7f3f739f
LL
4213 (syms_of_fns): New symbols.
4214
76147d94
DD
42152011-06-20 Deniz Dogan <deniz@dogan.se>
4216
4217 * process.c (Fset_process_buffer): Clarify return value in
4218 docstring.
4219
7d7d0045
CY
42202011-06-18 Chong Yidong <cyd@stupidchicken.com>
4221
4222 * dispnew.c (add_window_display_history): Use BVAR.
4223
4224 * xdisp.c (debug_method_add): Use BVAR.
4225 (check_window_end, dump_glyph_matrix, dump_glyph)
4226 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4227
4228 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4229 Likewise.
4230
4231 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4232 check till after the cache is created in init_frame_faces.
4233
ff2bc410
SM
42342011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4235
4236 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4237
28177add
PE
42382011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4239
dd3482fe
PE
4240 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4241 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4242 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4243
393d71f3 4244 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4245 * fileio.c (Finsert_file_contents):
4246 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4247 Remove the old (too-loose) buffer overflow checks.
4248 They weren't needed, since make_gap checks for buffer overflow.
4249 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4250 The old code merely checked for Emacs fixnum overflow, and relied
4251 on undefined (wraparound) behavior. The new code avoids undefined
4252 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4253
2e6813b0 4254 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4255 Tune. Don't use wider integers than needed. Don't use alloca.
4256 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4257
599a9e4f
PE
4258 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4259
99561444
PE
4260 * insdel.c, lisp.h (buffer_overflow): New function.
4261 (insert_from_buffer_1, replace_range, replace_range_2):
4262 * insdel.c (make_gap_larger):
4263 * editfns.c (Finsert_char):
4264 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4265
28177add
PE
4266 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4267
e69dafad
PE
42682011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4269
a7af7fde 4270 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4271
b1c46f02
PE
4272 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4273 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4274
e69dafad
PE
4275 * fileio.c: Don't assume EMACS_INT fits in off_t.
4276 (emacs_lseek): New static function.
4277 (Finsert_file_contents, Fwrite_region): Use it.
4278 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4279
566684ea
PE
4280 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4281
e6966cd6
PE
4282 * fns.c: Don't overflow int when computing a list length.
4283 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4284 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4285 truncation on 64-bit hosts. Check for QUIT every
4286 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4287 faster and is responsive enough.
4288 (Flength): Report an error instead of overflowing an integer.
4289 (Fsafe_length): Return a float if the value is not representable
4290 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4291 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4292 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4293
dd0b0efb
PE
4294 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4295 (header_size, word_size): New constants.
4296 (allocate_vectorlike): Don't check size overflow here.
4297 (allocate_vector): Check it here instead, since this is the only
4298 caller of allocate_vectorlike that could cause overflow.
4299 Check that the new vector's length is representable as a fixnum.
4300
86fe5cfe
PE
4301 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4302 The previous code was bogus. For example, next_almost_prime (32)
4303 returned 39, which is undesirable as it is a multiple of 3; and
4304 next_almost_prime (24) returned 25, which is a multiple of 5 so
4305 why was the code bothering to check for multiples of 7?
4306
80e88859
PE
4307 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4308
4a2f0ad6
PE
4309 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4310
f66c7cf8
PE
4311 Variadic C functions now count arguments with ptrdiff_t.
4312 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4313 Back then I didn't know that the Emacs coding style prefers signed int.
4314 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4315 were being counted with int, which may truncate counts on 64-bit
4316 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4317 * lisp.h (struct Lisp_Subr.function.aMANY)
4318 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4319 Arg counts are now ptrdiff_t, not size_t.
4320 All variadic functions and their callers changed accordingly.
4321 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4322 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4323 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4324 * callint.c (Fcall_interactively): Check arg count for overflow,
4325 to avoid potential buffer overrun. Use signed char, not 'int',
4326 for 'varies' array, so that we needn't bother to check its size
4327 calculation for overflow.
4328 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4329 * eval.c (apply_lambda):
4330 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4331 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4332 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4333
a1759b76
PE
4334 * callint.c (Fcall_interactively): Don't use index var as event count.
4335
d96be9fc
PE
4336 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4337 * mem-limits.h (SIZE): Remove; no longer used.
4338
a690a978 4339 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4340
578c21e6
PE
4341 Remove unnecessary casts.
4342 * xterm.c (x_term_init):
4343 * xfns.c (x_set_border_pixel):
4344 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4345 These aren't needed now that we assume ANSI C.
4346
96f53c6c
PE
4347 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4348 It's more likely to cause problems (due to unsigned overflow)
4349 than to cure them.
4350
83c77d31
PE
4351 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4352
ee2079f1
PE
4353 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4354
6da65536
PE
4355 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4356
7147c4a4
PE
4357 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4358
193e32d9
PE
4359 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4360
e5533da6
PE
4361 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4362
9910e595
PE
4363 GLYPH_CODE_FACE returns EMACS_INT, not int.
4364 * dispextern.h (merge_faces):
4365 * xfaces.c (merge_faces):
01103c44
PE
4366 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4367 Don't assume EMACS_INT fits in int.
9910e595 4368
2638320e
PE
4369 * character.h (CHAR_VALID_P): Remove unused parameter.
4370 * fontset.c, lisp.h, xdisp.c: All uses changed.
4371
045eb8d9
PE
4372 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4373
c1f134b5
PE
4374 * fns.c (concat): Minor tuning based on overflow analysis.
4375 This doesn't fix any bugs. Use int to hold character, instead
4376 of constantly refetching from Emacs object. Use XFASTINT, not
4377 XINT, for value known to be a character. Don't bother comparing
4378 a single byte to 0400, as it's always less.
4379
395fcb93 4380 * floatfns.c (Fexpt):
327eeec8
PE
4381 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4382
abbd3d23
PE
4383 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4384 for characters.
4385
684a03ef
PE
4386 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4387
0fed43f3
PE
4388 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4389 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4390 incorrectly succeed when S was a string, because 4294967386 was
4391 truncated before it was used.
4392
8fd02eb7
PE
4393 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4394 Otherwise, an out-of-range integer could cause undefined behavior
4395 on a 64-bit host.
4396
f8c86b69
PE
4397 * composite.c: Use int, not EMACS_INT, for characters.
4398 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4399 EMACS_INT, for values that are known to be in character range.
4400 This doesn't fix any bugs but is the usual style inside Emacs and
4401 may generate better code on 32-bit machines.
4402
34206dd2
PE
4403 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4404 This is for reasons similar to the recent CHAR_STRING fix.
4405 * charset.c (Fencode_char): Check that character arg is actually
4406 a character. Pass an int to ENCODE_CHAR.
4407 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4408 wider than 'int', as a compile-time check to prevent future regressions
4409 in this area.
4410
c5958d4c 4411 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4412
4413 Make sure a 64-bit char is never passed to CHAR_STRING.
4414 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4415 by silently ignoring the top 32 bits, allowing some values
4416 that were far too large to be valid characters.
4417 * character.h: Include <verify.h>.
4418 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4419 arguments are no wider than unsigned, as a compile-time check
4420 to prevent future regressions in this area.
4421 * data.c (Faset):
01103c44 4422 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4423 (Fsubst_char_in_region):
4424 * fns.c (concat):
4425 * xdisp.c (decode_mode_spec_coding):
4426 Adjust to CHAR_STRING's new requirement.
4427 * editfns.c (Finsert_char, Fsubst_char_in_region):
4428 * fns.c (concat): Check that character args are actually
4429 characters. Without this test, these functions did the wrong
4430 thing with wildly out-of-range values on 64-bit hosts.
4431
d37ca623
PE
4432 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4433 These casts should not be needed on 32-bit hosts, either.
4434 * keyboard.c (read_char):
4435 * lread.c (Fload): Remove casts to unsigned.
4436
ea204efb
PE
4437 * lisp.h (UNSIGNED_CMP): New macro.
4438 This fixes comparison bugs on 64-bit hosts.
4439 (ASCII_CHAR_P): Use it.
4440 * casefiddle.c (casify_object):
01103c44 4441 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4442 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4443 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4444 * dispextern.h (FACE_FROM_ID):
4445 * keyboard.c (read_char): Use UNSIGNED_CMP.
4446
41cb286c
PE
4447 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4448 not to EMACS_INT, to avoid GCC warning.
4449
4a1b9832
PE
4450 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4451
55daad71
PE
4452 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4453 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4454 isn't needed on 32-bit machines.
8f95c75c 4455
01103c44
PE
4456 * buffer.c (Fgenerate_new_buffer_name):
4457 Use EMACS_INT for count, not int.
0ceccced 4458 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4459
4460 * data.c (Qcompiled_function): Now static.
4461
c6f072e7
PE
4462 * window.c (window_body_lines): Now static.
4463
20ce5912
PE
4464 * image.c (gif_load): Rename local to avoid shadowing.
4465
9c4c5f81
PE
4466 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4467 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4468 * alloc.c (make_save_value): Integer argument is now of type
4469 ptrdiff_t, not int.
4470 (mark_object): Use ptrdiff_t, not int.
4471 * lisp.h (pD): New macro.
4472 * print.c (print_object): Use it.
4473
c0c5c8ae
PE
4474 * alloc.c: Use EMACS_INT, not int, to count objects.
4475 (total_conses, total_markers, total_symbols, total_vector_size)
4476 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4477 (total_free_floats, total_floats, total_free_intervals)
4478 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4479 Now EMACS_INT, not int. All uses changed.
4480 (Fgarbage_collect): Compute overall total using a double, so that
4481 integer overflow is less likely to be a problem. Check for overflow
4482 when converting back to an integer.
5a25e253
PE
4483 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4484 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4485 These were 'int' variables that could overflow on 64-bit hosts;
4486 they were never used, so remove them instead of repairing them.
211a0b2a 4487 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4488 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4489 Previously, this ceilinged at INT_MAX, but that doesn't work on
4490 64-bit machines.
e46bb31a 4491 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4492
c78baabf 4493 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4494 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4495 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4496 when a (possibly-narrower) signed value would do just as well.
4497 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4498
c9d624c6
PE
4499 * alloc.c: Catch some string size overflows that we were missing.
4500 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4501 for convenience in STRING_BYTES_MAX.
4502 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4503 The definition here is exact; the one in lisp.h was approximate.
4504 (allocate_string_data): Check for string overflow. This catches
4505 some instances we weren't catching before. Also, it catches
4506 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4507 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4508 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4509
c9d624c6
PE
4510 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4511 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4512 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4513
353032ce
PE
4514 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4515
2bccce07
PE
4516 * alloc.c (Fmake_string): Check for out-of-range init.
4517
0ac30604
SM
45182011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4519
4520 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4521
c195f2de
JD
45222011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4523
4524 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4525 xg_get_default_scrollbar_width.
4526
4527 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4528 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4529 (style_changed_cb): Call update_theme_scrollbar_width and call
4530 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4531 all frames (Bug#8505).
4532 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4533 Call gtk_window_set_resizable if HAVE_GTK3.
4534 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4535 and height if HAVE_GTK3 (Bug#8505).
4536 (scroll_bar_width_for_theme): New variable.
4537 (update_theme_scrollbar_width): New function.
4538 (xg_get_default_scrollbar_width): Move code to
4539 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4540 (xg_initialize): Call update_theme_scrollbar_width.
4541
4542 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4543
4544 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4545
e10ac9f1
MR
45462011-06-12 Martin Rudalics <rudalics@gmx.at>
4547
4548 * frame.c (make_frame): Call other_buffer_safely instead of
4549 other_buffer.
4550
4551 * window.c (temp_output_buffer_show): Call display_buffer with
4552 second argument Vtemp_buffer_show_specifiers and reset latter
4553 immediately after the call.
4554 (Vtemp_buffer_show_specifiers): New variable.
4555 (auto_window_vscroll_p, next_screen_context_lines)
4556 (Vscroll_preserve_screen_position): Remove leading asterisks from
4557 doc-strings.
4558
2d3c217e 45592011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4560
7b7f97e8 4561 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4562 * buffer.c (Qclone_number): Remove for now, as it's unused.
4563 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4564 (record_buffer): Remove unused local.
4565 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4566 (set_frame_buffer_list): Remove; unused.
4567 * frame.h (other_visible_frames): Remove decl.
4568 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4569 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4570 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4571 if HAVE_GPM.
4572 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4573 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4574 Define only if HAVE_GPM.
4575 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4576 (update_hints_inhibit): Remove; never set. All uses removed.
4577 * widgetprv.h (emacsFrameClassRec): Remove decl.
4578 * window.c (delete_deletable_window): Now returns void, since it
4579 wasn't returning anything.
4580 (compare_window_configurations): Remove unused locals.
4581 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4582 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4583 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4584 the same widths as pointers. This follows up on the 2011-05-06 patch.
4585 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4586 * xterm.h: Likewise.
4587 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4588
1384b89e
JB
45892011-06-12 Juanma Barranquero <lekktu@gmail.com>
4590
4591 * makefile.w32-in: Update dependencies.
4592 (LISP_H): Add lib/intprops.h.
4593
1100a63c
CY
45942011-06-11 Chong Yidong <cyd@stupidchicken.com>
4595
4596 * image.c (gif_load): Add animation frame delay to the metadata.
4597 (syms_of_image): Use DEFSYM. New symbol `delay'.
4598
6198ccd0
MR
45992011-06-11 Martin Rudalics <rudalics@gmx.at>
4600
4601 * window.c (delete_deletable_window): Re-add.
4602 (Fset_window_configuration): Rewrite to handle dead buffers and
4603 consequently deletable windows.
4604 (window_tree, Fwindow_tree): Remove. Supply functionality in
4605 window.el.
4606 (compare_window_configurations): Simplify code.
4607
b6e3633c
AS
46082011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4609
1ab0dee5
AS
4610 * image.c (imagemagick_load_image): Fix type mismatch.
4611 (Fimagemagick_types): Likewise.
4612
b6e3633c
AS
4613 * window.h (replace_buffer_in_windows): Declare.
4614
9397e56f
MR
46152011-06-11 Martin Rudalics <rudalics@gmx.at>
4616
4617 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4618 Qclone_number. Remove external declaration of Qdelete_window.
4619 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4620 code.
640c8776
SM
4621 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4622 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4623 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4624 buffer list implementation.
4625 (other_buffer_safely): New function.
4626 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4627 calls to replace_buffer_in_windows and
4628 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4629 if allowed.
4630 (record_buffer): Inhibit quitting and rewrite using quittable
4631 functions. Run Qbuffer_list_update_hook if allowed.
4632 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4633 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4634 Move switch-to-buffer to window.el.
9397e56f
MR
4635 (bury-buffer): Move to window.el.
4636 (Vbuffer_list_update_hook): New variable.
4637
4638 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4639 section.
4640
4641 * window.h (resize_frame_windows): Move up in code.
4642 (Fwindow_frame): Remove EXFUN.
4643 (replace_buffer_in_all_windows): Remove prototype.
4644 (replace_buffer_in_windows_safely): Add prototype.
4645
4646 * window.c: Declare Qdelete_window static again. Move down
4647 declaration of select_count.
4648 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4649 (Fother_window): Move to window.el.
4650 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4651 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4652 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4653 window.el.
4654 (replace_buffer_in_windows): Implement by calling
4655 Qreplace_buffer_in_windows.
4656 (replace_buffer_in_all_windows): Remove with some functionality
4657 moved into replace_buffer_in_windows_safely.
4658 (replace_buffer_in_windows_safely): New function.
4659 (select_window_norecord, select_frame_norecord): Move in front
4660 of run_window_configuration_change_hook. Remove now obsolete
4661 declarations.
640c8776
SM
4662 (Fset_window_buffer): Rewrite doc-string.
4663 Call Qrecord_window_buffer.
9397e56f
MR
4664 (keys_of_window): Move binding for other-window to window.el.
4665
b50691aa
CY
46662011-06-11 Chong Yidong <cyd@stupidchicken.com>
4667
4668 * dispextern.h (struct image): Replace data member, whose int_val
4669 and ptr_val fields were not used by anything, with a single
4670 lisp_val object.
4671
4672 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4673 (gif_clear_image, gif_load, imagemagick_load_image)
4674 (gs_clear_image, gs_load): Callers changed.
4675
3f754b86
PE
46762011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4677
cca69397
PE
4678 * buffer.h: Include <time.h>, for time_t.
4679 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4680
109e28d0
PE
4681 Fix minor problems found by static checking.
4682
60737f02
PE
4683 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4684
4b66faf3
PE
4685 Make identifiers static if they are not used in other modules.
4686 * data.c (Qcompiled_function, Qframe, Qvector):
4687 * image.c (QimageMagick, Qsvg):
4688 * minibuf.c (Qmetadata):
4689 * window.c (resize_window_check, resize_root_window): Now static.
4690 * window.h (resize_window_check, resize_root_window): Remove decls.
4691
109e28d0
PE
4692 * window.c (window_deletion_count, delete_deletable_window):
4693 Remove; unused.
46a4ce9e
PE
4694 (window_body_lines): Now static.
4695 (Fdelete_other_windows_internal): Mark vars as initialized.
4696 Make sure 'resize_failed' is initialized.
4697 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4698 (resize_window_apply): Remove unused local.
4699 * window.h (delete_deletable_window): Remove decl.
4700
109e28d0 4701 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4702 (imagemagick_load_image): Fix pointer signedness problem by changing
4703 last arg from unsigned char * to char *. All uses changed.
4704 Also, fix a local for similar reasons.
4705 Remove unused locals. Remove locals to avoid shadowing.
4706 (fn_rsvg_handle_free): Remove; unused.
4707 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4708 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4709
3f754b86
PE
4710 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4711
2547adb1
CY
47122011-06-10 Chong Yidong <cyd@stupidchicken.com>
4713
4714 * image.c (gif_load): Fix omitted cast error introduced by
4715 2011-06-06 change.
4716
2c8e37d4
MR
47172011-06-10 Martin Rudalics <rudalics@gmx.at>
4718
4719 * window.h (resize_proportionally, orig_total_lines)
4720 (orig_top_line): Remove from window structure.
4721 (set_window_height, set_window_width, change_window_heights)
4722 (Fdelete_window): Remove prototypes.
4723 (resize_frame_windows): Remove duplicate declaration.
4724
440a42e3
EZ
47252011-06-10 Eli Zaretskii <eliz@gnu.org>
4726
4727 * window.h (resize_frame_windows, resize_window_check)
4728 (delete_deletable_window, resize_root_window)
4729 (resize_frame_windows): Declare prototypes.
4730
4731 * window.c (resize_window_apply): Make definition be "static" to
4732 match the prototype.
4733
562dd5e9
MR
47342011-06-10 Martin Rudalics <rudalics@gmx.at>
4735
4736 * window.c: Remove declarations of Qwindow_size_fixed,
4737 window_min_size_1, window_min_size_2, window_min_size,
4738 size_window, window_fixed_size_p, enlarge_window, delete_window.
4739 Remove static from declaration of Qdelete_window, it's
4740 temporarily needed by Fbury_buffer.
4741 (replace_window): Don't assign orig_top_line and
4742 orig_total_lines.
4743 (Fdelete_window, delete_window): Remove. Window deletion is
4744 handled by window.el.
640c8776
SM
4745 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4746 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4747 (Fdelete_other_windows): Remove. Deleting other windows is
4748 handled by window.el.
4749 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4750 handled in window.el.
4751 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4752 Window minimum sizes are handled in window.el.
4753 (shrink_windows, size_window, set_window_height)
4754 (set_window_width, change_window_heights, window_height)
4755 (window_width, CURBEG, CURSIZE, enlarge_window)
4756 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4757 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4758 handled in window.el.
4759 (make_dummy_parent): Rename to make_parent_window and give it a
4760 second argument horflag.
4761 (make_window): Don't set resize_proportionally any more.
4762 (Fsplit_window): Remove. Windows are split in window.el.
4763 (save_restore_action, save_restore_orig_size)
4764 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4765 Resize mini windows in window.el.
4766 (grow_mini_window, shrink_mini_window): Implement by calling
4767 Qresize_root_window_vertically, resize_window_check and
4768 resize_window_apply.
640c8776
SM
4769 (saved_window, Fset_window_configuration, save_window_save):
4770 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4771 resize_proportionally.
4772 (window_min_height, window_min_width): Move to window.el.
4773 (keys_of_window): Move bindings for delete-other-windows,
4774 split-window, delete-window and enlarge-window to window.el.
4775
4776 * buffer.c: Temporarily extern Qdelete_window.
4777 (Fbury_buffer): Temporarily call Qdelete_window instead of
4778 Fdelete_window (Fbury_buffer will move to window.el soon).
4779
4780 * frame.c (set_menu_bar_lines_1): Remove code handling
4781 orig_top_line and orig_total_lines.
4782
4783 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4784 set_window_height but set heights directly.
4785 (change_frame_size_1): Use resize_frame_windows.
4786
4787 * xdisp.c (init_xdisp): Don't use set_window_height but set
4788 heights directly.
4789
640c8776
SM
4790 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4791 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4792 run_window_configuration_change_hook.
4793
4794 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4795 instead of change_window_heights and run
4796 run_window_configuration_change_hook.
4797
1a13852e
MR
47982011-06-09 Martin Rudalics <rudalics@gmx.at>
4799
4800 * window.c (replace_window): Rename second argument REPLACEMENT to
4801 NEW. New third argument SETFLAG. Rewrite.
4802 (delete_window, make_dummy_parent): Call replace_window with
4803 third argument 1.
4804 (window_list_1): Move down in code.
4805 (run_window_configuration_change_hook): Move set_buffer part
4806 before select_frame_norecord part in order to unwind correctly.
4807 Rename count1 to count.
4808 (recombine_windows, delete_deletable_window, resize_root_window)
4809 (Fdelete_other_windows_internal)
4810 (Frun_window_configuration_change_hook, make_parent_window)
4811 (resize_window_check, resize_window_apply, Fresize_window_apply)
4812 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4813 (Fdelete_window_internal, Fresize_mini_window_internal):
4814 New functions.
1a13852e
MR
4815 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4816
f3d1777e
MR
48172011-06-08 Martin Rudalics <rudalics@gmx.at>
4818
496e208e
MR
4819 * window.h (window): Add some new members to window structure -
4820 normal_lines, normal_cols, new_total, new_normal, clone_number,
4821 splits, nest, prev_buffers, next_buffers.
4822 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4823 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4824
f3d1777e
MR
4825 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4826 Remove.
496e208e
MR
4827 (make_dummy_parent): Set new members of windows structure.
4828 (make_window): Move down in code. Handle new members of window
4829 structure.
4830 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4831 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4832 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4833 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4834 (Fset_window_next_buffers, Fset_window_clone_number):
4835 New functions.
496e208e
MR
4836 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4837 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4838 Doc-string fixes.
4839 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4840 Argument WINDOW can be now internal window too.
4841 (Fwindow_use_time): Move up in code.
4842 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4843 Rewrite doc-string.
4844 (Fset_window_configuration, saved_window)
4845 (Fcurrent_window_configuration, save_window_save): Handle new
4846 members of window structure.
b9e809c2
MR
4847 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4848 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4849 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4850 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4851 Qget_mru_window, Qresize_root_window,
4852 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4853 Qauto_buffer_name; staticpro them.
f3d1777e 4854
abde8f8c
MR
48552011-06-07 Martin Rudalics <rudalics@gmx.at>
4856
4857 * window.c (Fwindow_total_size, Fwindow_left_column)
4858 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4859 (Fwindow_list_1): New functions.
4860 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4861 (Fwindow_width, Fscroll_left, Fscroll_right):
4862 Use window_body_cols instead of window_box_text_cols.
4863 (delete_window, Fset_window_configuration):
4864 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4865 (delete_all_subwindows): Take a window as argument and not a
4866 structure. Rewrite.
190b47e6
MR
4867 (window_loop): Remove handling of GET_LRU_WINDOW and
4868 GET_LARGEST_WINDOW.
4869 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4870
4871 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4872 window_box_text_cols. delete_all_subwindows now takes a
4873 Lisp_Object as argument.
abde8f8c 4874
640c8776
SM
4875 * indent.c (compute_motion, Fcompute_motion):
4876 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4877
fa8a67e6
MR
4878 * frame.c (delete_frame): Call delete_all_subwindows with root
4879 window as argument.
4880
a54e3482
DC
48812011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4882
4883 * fns.c (Fputhash): Document return value.
4884
60002bf5
CY
48852011-06-06 Chong Yidong <cyd@stupidchicken.com>
4886
4887 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4888
0c671da6 48892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4890
b862a52a 4891 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4892
be44ca6c
PE
4893 Check for overflow when converting integer to cons and back.
4894 * charset.c (Fdefine_charset_internal, Fdecode_char):
4895 Use cons_to_unsigned to catch overflow.
4896 (Fencode_char): Use INTEGER_TO_CONS.
4897 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4898 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4899 * data.c (long_to_cons, cons_to_long): Remove.
4900 (cons_to_unsigned, cons_to_signed): New functions.
4901 These signal an error for invalid or out-of-range values.
4902 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4903 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4904 * font.c (Ffont_variation_glyphs):
4905 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4906 * lisp.h: Include <intprops.h>.
4907 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4908 (cons_to_signed, cons_to_unsigned): New decls.
4909 (long_to_cons, cons_to_long): Remove decls.
4910 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4911 (Fprimitive_undo): Use CONS_TO_INTEGER.
4912 * xfns.c (Fx_window_property): Likewise.
4913 * xselect.c: Include <limits.h>.
4914 (x_own_selection, selection_data_to_lisp_data):
4915 Use INTEGER_TO_CONS.
4916 (x_handle_selection_request, x_handle_selection_clear)
4917 (x_get_foreign_selection, Fx_disown_selection_internal)
4918 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4919 (lisp_data_to_selection_data): Use cons_to_unsigned.
4920 (x_fill_property_data): Use cons_to_signed.
4921 Report values out of range.
4922
d1f3d2af
PE
4923 Check for buffer and string overflow more precisely.
4924 * buffer.h (BUF_BYTES_MAX): New macro.
4925 * lisp.h (STRING_BYTES_MAX): New macro.
4926 * alloc.c (Fmake_string):
4927 * character.c (string_escape_byte8):
4928 * coding.c (coding_alloc_by_realloc):
4929 * doprnt.c (doprnt):
4930 * editfns.c (Fformat):
4931 * eval.c (verror):
4932 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4933 since they may not be the same number.
4934 * editfns.c (Finsert_char):
4935 * fileio.c (Finsert_file_contents):
4936 Likewise for BUF_BYTES_MAX.
4937
dd52fcea
PE
4938 * image.c: Use ptrdiff_t, not int, for sizes.
4939 (slurp_file): Switch from int to ptrdiff_t.
4940 All uses changed.
4941 (slurp_file): Check that file size fits in both size_t (for
4942 malloc) and ptrdiff_t (for sanity and safety).
4943
7f9bbdbb
PE
4944 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4945 if b->modtime has its maximal value.
4946
dfe18f82
PE
4947 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4948
84acfcf0
PE
4949 Don't assume time_t can fit into int.
4950 * buffer.h (struct buffer.modtime): Now time_t, not int.
4951 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4952 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4953
ccd9a01a
PE
4954 Minor fixes for signed vs unsigned integers.
4955 * character.h (MAYBE_UNIFY_CHAR):
4956 * charset.c (maybe_unify_char):
4957 * keyboard.c (read_char, reorder_modifiers):
4958 XINT -> XFASTINT, since the integer must be nonnegative.
4959 * ftfont.c (ftfont_spec_pattern):
4960 * keymap.c (access_keymap, silly_event_symbol_error):
4961 XUINT -> XFASTINT, since the integer must be nonnegative.
4962 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4963 since it makes no difference and we prefer signed.
4964 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4965 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4966 nonnegative.
4967
d6d100dd
SM
49682011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4969
4970 * window.h (Fwindow_frame): Declare.
4971
2b6148e4
PE
49722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4973
4974 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4975 (SPARE_MEMORY): Always define.
4976 (LARGE_REQUEST): Remove.
4977 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4978
f230ecc9
MR
49792011-06-06 Martin Rudalics <rudalics@gmx.at>
4980
727e958e
MR
4981 * lisp.h: Move EXFUNS for Fframe_root_window,
4982 Fframe_first_window and Fset_frame_selected_window to window.h.
4983
4984 * window.h: Move EXFUNS for Fframe_root_window,
4985 Fframe_first_window and Fset_frame_selected_window here from
4986 lisp.h.
4987
4988 * frame.c (Fwindow_frame, Fframe_first_window)
4989 (Fframe_root_window, Fframe_selected_window)
4990 (Fset_frame_selected_window): Move to window.c.
4991 (Factive_minibuffer_window): Move to minibuf.c.
4992 (Fother_visible_frames_p): New function.
4993
4994 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4995
f230ecc9
MR
4996 * window.c (decode_window, decode_any_window): Move up in code.
4997 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4998 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4999 (Fwindow_buffer): Move up and rewrite doc-string.
5000 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5001 (Fwindow_prev): New functions.
727e958e
MR
5002 (Fwindow_frame): Move here from frame.c. Accept any window as
5003 argument.
5004 (Fframe_root_window, Fframe_first_window)
5005 (Fframe_selected_window): Move here from frame.c. Accept frame
5006 or arbitrary window as argument. Update doc-strings.
5007 (Fminibuffer_window): Move up in code.
5008 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5009 (Fset_frame_selected_window): Move here from frame.c.
5010 Marginal rewrite.
727e958e
MR
5011 (Fselected_window, select_window, Fselect_window): Move up in
5012 code. Minor doc-string fixes.
f230ecc9 5013
4d09bcf6
PE
50142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5015
5016 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5017 Do not assume that spare memory exists; that assumption is valid
5018 only if SYSTEM_MALLOC.
5019 (LARGE_REQUEST): New macro, so that the issue of large requests
5020 is separated from the issue of spare memory.
5021
810928a2
AS
50222011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5023
172418ad
AS
5024 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5025 format. (Bug#8806)
5026
43f862f7
AS
5027 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5028
810928a2
AS
5029 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5030 before statements.
5031
a059fe24
JD
50322011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5033
5034 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5035
5036 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5037
5038 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5039 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5040
989bf368
JB
50412011-06-05 Juanma Barranquero <lekktu@gmail.com>
5042
5043 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5044
4b80f674
CY
50452011-06-04 Chong Yidong <cyd@stupidchicken.com>
5046
5047 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5048 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5049 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5050 New error handlers.
4b80f674
CY
5051 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5052 Obey Vx_select_enable_clipboard_manager. Catch errors in
5053 x_clipboard_manager_save (Bug#8779).
5054 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5055 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5056
99a33b77 50572011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5058
5059 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5060
99a33b77 50612011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5062
5063 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5064 in the current matrix if keep_current_p is non-zero.
5065
8264569d
EZ
50662011-06-04 Eli Zaretskii <eliz@gnu.org>
5067
5068 * bidi.c (bidi_level_of_next_char): Fix last change.
5069
57f97249
EZ
50702011-06-03 Eli Zaretskii <eliz@gnu.org>
5071
fec2107c 5072 Support bidi reordering of text covered by display properties.
57f97249 5073
fec2107c
EZ
5074 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5075 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5076 (bidi_cache_search, bidi_cache_iterator_state)
5077 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5078 (bidi_level_of_next_char, bidi_move_to_visually_next):
5079 Support character positions inside a run of characters covered by a
fec2107c
EZ
5080 display string.
5081 (bidi_paragraph_init, bidi_resolve_explicit_1)
5082 (bidi_level_of_next_char): Call bidi_fetch_char and
5083 bidi_fetch_char_advance instead of FETCH_CHAR and
5084 FETCH_CHAR_ADVANCE.
5085 (bidi_init_it): Initialize new members.
5086 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5087 definitions.
5088 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5089 instead of using explicit *_CHAR codes.
d6d100dd
SM
5090 (bidi_resolve_explicit, bidi_resolve_weak):
5091 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5092 bidirectional text is supported only in multibyte buffers.
5093 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5094 it to initialize the frame_window_p member of struct bidi_it.
5095 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5096 (bidi_resolve_explicit, bidi_resolve_weak)
5097 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5098 bidi_it->nchars is non-positive.
5099 (bidi_level_of_next_char): Don't try to lookup the cache for the
5100 next/previous character if nothing is cached there yet, or if we
5101 were just reseat()'ed to a new position.
c40e2fb2 5102
0e14fe90
EZ
5103 * xdisp.c (set_cursor_from_row): Set start and stop points
5104 according to the row's direction when priming the loop that looks
5105 for the glyph on which to display cursor.
5106 (single_display_spec_intangible_p): Function deleted.
5107 (display_prop_intangible_p): Reimplement to call
5108 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5109 Accept 3 additional arguments needed by handle_display_spec.
5110 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5111 values: lists, `(when COND...)' forms, etc.
5112 (single_display_spec_string_p): Support property values that are
5113 lists with the argument STRING its top-level element.
5114 (display_prop_string_p): Fix the condition for processing a
5115 property that is a list to be consistent with handle_display_spec.
fec2107c 5116 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5117 last portion of handle_display_prop.
5118 (compute_display_string_pos): Accept additional argument
5119 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5120 value of a `display' property is a "replacing spec".
5121 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5122 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5123 the display property, but just return a value indicating whether
5124 the display property will replace the characters it covers.
5125 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5126 frame_window_p members of struct bidi_it.
d6d100dd
SM
5127 (compute_display_string_pos, compute_display_string_end):
5128 New functions.
fec2107c
EZ
5129 (push_it): Accept second argument POSITION, where pop_it should
5130 jump to continue iteration.
5131 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5132
fec2107c
EZ
5133 * keyboard.c (adjust_point_for_property): Adjust the call to
5134 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5135
5136 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5137 (bidi_init_it): Update prototypes.
5138 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5139 (compute_display_string_pos, compute_display_string_end):
5140 Declare prototypes.
fec2107c
EZ
5141 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5142 EMACS_INT.
fc6f18ce 5143
40087514 51442011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5145
57f53182
PE
5146 Malloc failure behavior now depends on size of allocation.
5147 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5148 * lisp.h: Change signatures accordingly.
5149 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5150 All callers changed. (Bug#8762)
5151
5152 * gnutls.c: Use Emacs's memory allocators.
5153 Without this change, the gnutls library would invoke malloc etc.
5154 directly, which causes problems on non-SYNC_INPUT hosts, and which
5155 runs afoul of improving memory_full behavior. (Bug#8761)
5156 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5157 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5158 xfree instead of the default malloc, realloc, free.
5159 (Fgnutls_boot): No need to check for memory allocation failure,
5160 since xmalloc does that for us.
5161
ac32cd99 5162 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5163 * category.c (hash_get_category_set):
5164 * ccl.c (ccl_driver):
5165 * charset.c (Fdefine_charset_internal):
5166 * charset.h (struct charset.hash_index):
5167 * composite.c (get_composition_id, gstring_lookup_cache)
5168 (composition_gstring_put_cache):
5169 * composite.h (struct composition.hash_index):
5170 * dispextern.h (struct image.hash):
5171 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5172 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5173 (hashfn_equal, hashfn_user_defined, make_hash_table)
5174 (maybe_resize_hash_table, hash_lookup, hash_put)
5175 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5176 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5177 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5178 * image.c (make_image, search_image_cache, lookup_image)
5179 (xpm_put_color_table_h):
5180 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5181 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5182 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5183 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5184 * alloc.c (allocate_vectorlike):
5185 Check for overflow in vector size calculations.
5186 * ccl.c (ccl_driver):
5187 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5188 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5189 need to be updated by these changes.
40087514
PE
5190 * fns.c (make_hash_table, maybe_resize_hash_table):
5191 Check for integer overflow with large hash tables.
0de4bb68
PE
5192 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5193 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5194 (SXHASH_REDUCE): New macro.
5195 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5196 Use it instead of discarding useful hash info with large hash values.
5197 (sxhash_float): New function.
5198 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5199 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5200 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5201 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5202 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5203 Adjust signatures to match updated version of code.
5204 (consing_since_gc): Now EMACS_INT, since a single hash table can
5205 use more than INT_MAX bytes.
5206
698d32e2
DN
52072011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5208
5209 Make it possible to build with GCC-4.6+ -O2 -flto.
5210
5211 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5212
fd6fa53f
SM
52132011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5214
5215 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5216 Call minibuffer-inactive-mode.
5217
864db017
JB
52182011-05-31 Juanma Barranquero <lekktu@gmail.com>
5219
5220 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5221 Update dependencies.
5222
2ad0baf4
DN
52232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5224
5225 * data.c (init_data): Remove code for UTS, this system is not
5226 supported anymore.
5227
4fcc2638
DN
52282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5229
5230 Don't force ./temacs to start in terminal mode.
5231
5232 * frame.c (make_initial_frame): Initialize faces in all cases, not
5233 only when CANNOT_DUMP is defined.
5234 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5235
c56e0fd5
DN
52362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5237
5238 * dispnew.c (add_window_display_history): Use const for the string
5239 pointer. Remove declaration, not needed.
5240
333d54da 52412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5242
55d4c1b2 5243 Use 'inline', not 'INLINE'.
333d54da 5244 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5245 * alloc.c, fontset.c (INLINE): Remove.
5246 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5247 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5248 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5249 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5250 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5251
738db178
DN
52522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5253
5254 Make it possible to run ./temacs.
5255
5256 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5257 syms_of_callproc does the same thing. Remove test for
5258 "initialized", do it in the caller.
5259 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5260
620c53a6
SM
52612011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5262
5263 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5264 (read_minibuf): Use get_minibuffer.
5265 (syms_of_minibuf): Use DEFSYM.
5266 (Qmetadata): New var.
5267 * data.c (Qbuffer): Don't make it static.
5268 (syms_of_data): Use DEFSYM.
5269
e003a292
PE
52702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5271
5272 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5273 (CCL_CODE_MIN): New macro.
5274
ed008a6d
PE
52752011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5276
3687c2ef
PE
5277 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5278
ed008a6d
PE
5279 * eval.c (Qdebug): Now static.
5280 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5281 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5282 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5283
d66c4c7c
CY
52842011-05-29 Chong Yidong <cyd@stupidchicken.com>
5285
5286 * image.c: Various fixes to ImageMagick code comments.
5287 (Fimagemagick_types): Doc fix.
5288
5fbc2025
PE
52892011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5290
0196f88a
PE
5291 Minor fixes prompted by GCC 4.6.0 warnings.
5292
5293 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5294
5fbc2025
PE
5295 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5296 (x_clipboard_manager_save_all): Move extern decl to ...
5297 * xterm.h: ... here, so that it can be checked for consistency.
5298
1dd3c2d9
CY
52992011-05-29 Chong Yidong <cyd@stupidchicken.com>
5300
5301 * xselect.c (x_clipboard_manager_save_frame)
5302 (x_clipboard_manager_save_all): New functions.
5303 (Fx_clipboard_manager_save): Lisp function deleted.
5304
5305 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5306 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5307
5308 * xterm.h: Update prototype.
5309
5ba6571d
WX
53102011-05-28 William Xu <william.xwl@gmail.com>
5311
5312 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5313 exiting (Bug#8239).
5314
3eaff834
JM
53152011-05-28 Jim Meyering <meyering@redhat.com>
5316
e1900994 5317 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5318 * fns.c (to_uchar): Define.
5319 (crypto_hash_function): Use it to convert some newly-signed
5320 variables to unsigned, to avoid sign-extension bugs. For example,
5321 without this change, (md5 "truc") would evaluate to
5322 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5323 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5324 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5325
0f6990a7
PE
53262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5327
5328 Integer overflow fixes.
c8a9ca5a 5329
08686060
PE
5330 * dbusbind.c: Serial number integer overflow fixes.
5331 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5332 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5333 to hold a serial number that is too large for a fixnum.
5334 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5335 Check for serial numbers out of range. Decode any serial number
59568bf0 5336 that was so large that it became a float. (Bug#8722)
08686060 5337
2d1fc3c7
PE
5338 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5339 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5340 Use XFASTINT rather than XUINT when numbers are nonnegative.
5341 (xd_append_arg, Fdbus_method_return_internal):
5342 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5343 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5344 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5345 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5346 (Bug#8722)
2d1fc3c7 5347
c8a9ca5a
PE
5348 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5349
519e1d69
PE
5350 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5351
30569699
PE
5352 ccl: add integer overflow checks
5353 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5354 (IN_INT_RANGE): New macros.
5355 (ccl_driver): Use them to check for integer overflow when
5356 decoding a CCL program. Many of the new checks are whether XINT (x)
5357 fits in int; it doesn't always, on 64-bit hosts. The new version
5358 doesn't catch all possible integer overflows, but it's an
847044ea 5359 improvement. (Bug#8719)
30569699 5360
c11285dc
PE
5361 * alloc.c (make_event_array): Use XINT, not XUINT.
5362 There's no need for unsigned here.
5363
fdccd48e
PE
5364 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5365 This follows up to the 2011-05-06 change that substituted uintptr_t
5366 for EMACS_INT. This case wasn't caught back then.
5367
37910ab2
PE
5368 Rework Fformat to avoid integer overflow issues.
5369 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5370 now (part of C89). Include <verify.h>.
5371 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5372 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5373 (Fformat): Avoid the prepass trying to compute sizes; it was only
5374 approximate and thus did not catch overflow reliably. Instead, walk
5375 through the format just once, formatting and computing sizes as we go,
5376 checking for integer overflow at every step, and allocating a larger
5377 buffer as needed. Keep track separately whether the format is
5378 multibyte. Keep only the most-recently calculated precision, rather
5379 than them all. Record whether each argument has been converted to
5380 string. Use EMACS_INT, not int, for byte and char and arg counts.
5381 Support field widths and precisions larger than INT_MAX. Avoid
5382 sprintf's undefined behavior with conversion specifications such as %#d
5383 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5384 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5385 formatting out-of-range floating point numbers with int
9173deec 5386 formats. (Bug#8668)
37910ab2 5387
2e6578fb
PE
5388 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5389
0ae6bdee
PE
5390 * data.c: Avoid integer truncation in expressions involving floats.
5391 * data.c: Include <intprops.h>.
5392 (arith_driver): When there's an integer overflow in an expression
5393 involving floating point, convert the integers to floating point
5394 so that the resulting value does not suffer from catastrophic
5395 integer truncation. For example, on a 64-bit host (* 4
5396 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5397 Do not rely on undefined behavior after integer overflow.
5398
de883a70
PE
5399 merge count_size_as_multibyte, parse_str_to_multibyte
5400 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5401 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5402 Check for integer overflow.
5403 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5404 since it's now a duplicate of the other. This is more of
5405 a character than a buffer op, so better that it's in character.c.
5406 * fns.c, print.c: Adjust to above changes.
5407
2ff916cb
PE
54082011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5409
5410 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5411
f1b54466
PE
54122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5413
fb1ac845
PE
5414 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5415 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5416 (x_clipboard_manager_save): Now static.
5417 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5418
f1b54466
PE
5419 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5420 (crypto_hash_function): Now static.
5421 Fix pointer signedness problems. Avoid unnecessary initializations.
5422
a9f737ee
CY
54232011-05-27 Chong Yidong <cyd@stupidchicken.com>
5424
5425 * termhooks.h (Vselection_alist): Make it terminal-local.
5426
5427 * terminal.c (create_terminal): Initialize it.
5428
5429 * xselect.c: Support for clipboard managers.
5430 (Vselection_alist): Move to termhooks.h as terminal-local var.
5431 (LOCAL_SELECTION): New macro.
5432 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5433 (symbol_to_x_atom): Remove gratuitous arg.
5434 (x_handle_selection_request, lisp_data_to_selection_data)
5435 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5436 (x_own_selection, x_get_local_selection, x_convert_selection):
5437 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5438 (some_frame_on_display): Delete unused function.
5439 (Fx_own_selection_internal, Fx_get_selection_internal)
5440 (Fx_disown_selection_internal, Fx_selection_owner_p)
5441 (Fx_selection_exists_p): New optional frame arg.
5442 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5443 (x_handle_selection_clear): Don't treat other terminals with the
5444 same keyboard specially. Use the terminal-local Vselection_alist.
5445 (x_clear_frame_selections): Use Frun_hook_with_args.
5446
5447 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5448
5449 * xterm.h: Add support for those atoms.
5450
e067f0c1
CY
54512011-05-26 Chong Yidong <cyd@stupidchicken.com>
5452
5453 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5454 (converted_selections, conversion_fail_tag): New global variables.
5455 (x_selection_request_lisp_error): Free the above.
5456 (x_get_local_selection): Remove unnecessary code.
5457 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5458 of converted selections stored in converted_selections.
5459 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5460 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5461 (x_convert_selection): New function.
5462 (x_handle_selection_event): Simplify.
5463 (x_get_foreign_selection): Don't ignore incoming requests while
5464 waiting for an answer; this will fail when we implement
5465 SAVE_TARGETS, and seems unnecessary anyway.
5466 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5467 (Vx_sent_selection_functions): Doc fix.
5468
0f4aebc0
LL
54692011-05-26 Leo Liu <sdl.web@gmail.com>
5470
5471 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5472
e61124cd
YM
54732011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5474
5475 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5476
5477 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5478 for fringe update if it has periodic bitmap.
ac389d0c 5479 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5480 and fringe_bitmap_periodic_p.
5481
5482 * fringe.c (get_fringe_bitmap_data): New function.
5483 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5484 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5485 row. Mark glyph row for fringe update if periodicity changed.
5486
5487 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5488 for fringe update unless it has periodic bitmap.
5489
f16d9837
KH
54902011-05-25 Kenichi Handa <handa@m17n.org>
5491
5492 * xdisp.c (get_next_display_element): Set correct it->face_id for
5493 a static composition.
5494
e1b90ef6
LL
54952011-05-24 Leo Liu <sdl.web@gmail.com>
5496
5497 * deps.mk (fns.o):
5498 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5499
5500 * fns.c (crypto_hash_function, Fsha1): New function.
5501 (Fmd5): Use crypto_hash_function.
5502 (syms_of_fns): Add Ssha1.
5503
7400048f
PE
55042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5505
5506 * gnutls.c: Remove unused macros.
5507 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5508 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5509 Remove macros that are defined and never used.
5510 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5511
abb71cf4
CY
55122011-05-22 Chong Yidong <cyd@stupidchicken.com>
5513
5514 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5515 (Fx_get_selection_internal): Minor cleanup.
5516 (Fx_own_selection_internal): Rename arguments for consistency with
5517 select.el.
5518
6307db39
PE
55192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5520
5521 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5522
f3d4e0a4
CY
55232011-05-22 Chong Yidong <cyd@stupidchicken.com>
5524
5525 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5526
4d8ade89
YM
55272011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5528
5529 * dispnew.c (scrolling_window): Don't exclude the case that the
5530 last enabled row in the desired matrix touches the bottom boundary.
5531
32078c8d
GM
55322011-05-21 Glenn Morris <rgm@gnu.org>
5533
5534 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5535 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5536 and add some more files.
32078c8d 5537
7285dc67
EZ
55382011-05-20 Eli Zaretskii <eliz@gnu.org>
5539
5540 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5541 report_file_error introduced by the change from 2011-05-07.
5542
89d1bd22
PE
55432011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5544
5545 * systime.h (Time): Define only if emacs is defined.
5546 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5547 where the include path doesn't have X11/X.h by default. See
5548 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5549
e23640bb 55502011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5551
5552 * composite.c (find_automatic_composition): Fix previous change.
5553
b9704ad9
GM
55542011-05-20 Glenn Morris <rgm@gnu.org>
5555
5556 * lisp.mk: New file, split from Makefile.in.
5557 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5558 (shortlisp): Remove.
5559 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5560
4a720484
GM
55612011-05-19 Glenn Morris <rgm@gnu.org>
5562
5563 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5564 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5565 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5566 (lisp): Set the order to that of loadup.el.
5567 (shortlisp): Make it a copy of $lisp.
5568 (SOME_MACHINE_LISP): Remove.
5569 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5570 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5571
a28d4396
KH
55722011-05-18 Kenichi Handa <handa@m17n.org>
5573
5574 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5575 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5576 (find_automatic_composition): Mostly rewrite for efficiency.
5577
a2b1fa8e
JB
55782011-05-18 Juanma Barranquero <lekktu@gmail.com>
5579
5580 * makefile.w32-in: Update dependencies.
5581
8e1f5610
CS
55822011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5583
5584 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5585 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5586
7025ee00 55872011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5588
cdfa6eab
PE
5589 Fix some integer overflow issues, such as string length overflow.
5590
06d6db33
PE
5591 * insdel.c (count_size_as_multibyte): Check for string overflow.
5592
2b4560a8
PE
5593 * character.c (lisp_string_width): Check for string overflow.
5594 Use EMACS_INT, not int, for string indexes and lengths; in
5595 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5596 the resulting string length overflows an EMACS_INT; instead,
5597 report a string overflow if no precision given. When checking for
5598 precision exhaustion, use a check that cannot possibly have
5599 integer overflow. (Bug#8675)
5600 * character.h (lisp_string_width): Adjust to new signature.
5601
cb93f9be
PE
5602 * alloc.c (string_overflow): New function.
5603 (Fmake_string): Use it. This doesn't change behavior, but saves
5604 a few bytes and will simplify future changes.
5605 * character.c (string_escape_byte8): Likewise.
5606 * lisp.h (string_overflow): New decl.
5607
1a1f3366
PE
5608 Fixups, following up to the user-interface timestamp change.
5609 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5610 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5611 * msdos.c (mouse_get_pos): Likewise.
5612 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5613 * w32gui.h (Time): Define by including "systime.h" rather than by
5614 declaring it ourselves. (Bug#8664)
5615
d4e3e4d3
PE
5616 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5617 * image.c (clear_image_cache): Likewise.
5618
f6a24d19
PE
5619 * term.c (term_mouse_position): Don't assume time_t wraparound.
5620
08dc5ae6
PE
5621 Be more systematic about user-interface timestamps.
5622 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5623 and sometimes 'EMACS_UINT', to represent these timestamps.
5624 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5625 This makes the code easier to follow, and makes it easier to catch
5626 integer overflow bugs such as Bug#8664.
5627 * frame.c (Fmouse_position, Fmouse_pixel_position):
5628 Use Time, not unsigned long, for user-interface timestamps.
5629 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5630 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5631 * keyboard.h (last_event_timestamp): Likewise.
5632 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5633 * menu.h (xmenu_show): Likewise.
5634 * term.c (term_mouse_position): Likewise.
5635 * termhooks.h (struct input_event.timestamp): Likewise.
5636 (struct terminal.mouse_position_hook): Likewise.
5637 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5638 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5639 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5640 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5641 what it was before.
5642 * menu.h, termhooks.h: Include "systime.h", for Time.
5643
8e55734a
PE
5644 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5645 Don't assume that the difference between two unsigned long values
5646 can fit into an integer. At this point, we know button_down_time
5647 <= event->timestamp, so the difference must be nonnegative, so
5648 there's no need to cast the result if double-click-time is
5649 nonnegative, as it should be; check that it's nonnegative, just in
5650 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5651 apart (about 25 days). (Bug#8664)
8e55734a 5652
841f1b75 5653 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5654 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5655
3e26f69c
PE
5656 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5657 that always fit in int. Use a sentinel instead of a counter, to
5658 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5659 * frame.h (struct frame): Use int for menu_bar_items_used
5660 instead of EMACS_INT, since it always fits in int.
3e26f69c 5661
5cc152c0
PE
5662 * menu.c (grow_menu_items): Check for int overflow.
5663
d89eb65e
PE
5664 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5665
5235bd3e
PE
5666 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5667 Before, the code was not consistent. These values cannot exceed
5668 2**31 - 1 so there's no need to make them unsigned.
5669 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5670 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5671 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5672 as modifiers.
5673 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5674
bc827e23
PE
5675 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5676 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5677 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5678 presumably because the widths might not match.
5679
78eb494e
PE
5680 * window.c (size_window): Avoid needless test at loop start.
5681
04f2d78b
CB
56822011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5683
5684 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5685
d2fc7e3d 56862011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5687
5688 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5689
d2fc7e3d 56902011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5691
5692 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5693 `width' to `bar_area_x' and `bar_area_width', respectively.
5694 (x_scroll_run): Take account of fringe background extension.
5695
04f2d78b
CB
5696 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5697 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5698 `bar_area_width', respectively.
5699 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5700 background extension.
5701
79b70037
GM
57022011-05-10 Jim Meyering <meyering@redhat.com>
5703
5704 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5705
2f142cc5
JB
57062011-05-10 Juanma Barranquero <lekktu@gmail.com>
5707
5708 * image.c (Finit_image_library): Return t for built-in image types,
5709 like pbm and xbm. (Bug#8640)
5710
57679c86
AS
57112011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5712
5713 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5714
888c9e86
EZ
57152011-05-07 Eli Zaretskii <eliz@gnu.org>
5716
b0512a1d
EZ
5717 * w32console.c (Fset_screen_color): Doc fix.
5718 (Fget_screen_color): New function.
5719 (syms_of_ntterm): Defsubr it.
5720
7285dc67
EZ
5721 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5722 unlink the temporary file if Fcall_process didn't create it in the
5723 first place.
5724 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5725 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5726 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5727 cue to call_process_cleanup not to close that handle.
5728
4d3fcc8e
BK
57292011-05-07 Ben Key <bkey76@gmail.com>
5730
5731 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5732 one of two shell specific rules, either bootstrap-temacs-CMD or
5733 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5734 to the previous implementation of the bootstrap-temacs rule.
5735 The bootstrap-temacs-CMD rule is similar to the previous
5736 implementation of the bootstrap-temacs rule except that it
5737 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5738 variable.
5739
5740 These changes, along with some changes to nt/configure.bat,
5741 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5742 earlier fix to add support for --cflags and --ldflags options
5743 that include quotes so that it works whether make uses cmd or
5744 sh as the shell.
5745
b4289b64
MA
57462011-05-06 Michael Albinus <michael.albinus@gmx.de>
5747
5748 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5749 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5750 is a constant.
5751 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5752 a string. Handle both cases.
5753 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5754 (Fdbus_register_method): Use Qinvalid_function.
5755
af4c0e28
JB
57562011-05-06 Juanma Barranquero <lekktu@gmail.com>
5757
5758 * makefile.w32-in: Update dependencies.
5759 (LISP_H): Add inttypes.h and stdin.h.
5760 (PROCESS_H): Add unistd.h.
5761
c51453d9
EZ
57622011-05-06 Eli Zaretskii <eliz@gnu.org>
5763
5764 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5765 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5766
8ff0ac3c 57672011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5768
4c4b566b
PE
5769 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5770
aab2b9b5
PE
5771 * term.c (vfatal): Remove stray call to va_end.
5772 It's not needed and the C Standard doesn't allow it here anyway.
5773
c378da0b
PE
5774 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5775 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5776
288b08c7
PE
5777 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5778 bytes.
5779
e3601888
PE
5780 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5781
db6c0e74
PE
5782 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5783
dd5963ea
PE
5784 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5785
88c9450f
PE
5786 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5787
2f9442b8
PE
5788 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5789
c032b5f8
PE
5790 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5791 * charset.c (Fdefine_charset_internal): Don't initialize
5792 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5793 32-bit int (Bug#8600).
a108c10b
PE
5794
5795 * lread.c (read_integer): Be more consistent with string-to-number.
5796 Use string_to_number to do the actual conversion; this avoids
5797 rounding errors and fixes some other screwups. Without this fix,
5798 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5799 (digit_to_number): Move earlier, for benefit of read_integer.
5800 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5801 not a digit in any supported base. (Bug#8602)
a108c10b 5802
ad5f9eea
PE
5803 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5804
aec1708a
PE
5805 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5806 to match comment at start of function. This also removes a
5807 GCC warning about overflow in a 32+64-bit port.
5808
47be4ab5
PE
5809 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5810
371cac43
PE
5811 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5812 Reported by Stefan Monnier in
5813 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5814 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5815 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5816
d01a7826
PE
5817 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5818 (EMACS_UINTPTR): Likewise, with uintptr_t.
5819
7fd47d5c
PE
5820 * lisp.h: Prefer 64-bit EMACS_INT if available.
5821 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5822 on 32-bit hosts that have 64-bit int, so that they can access
5823 large files.
122b0c86
PE
5824 However, temporarily disable this change unless the temporary
5825 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5826
8727937b
PE
5827 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5828
8ac068ac
PE
5829 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5830 This removes an assumption that EMACS_INT and long are the same
5831 width as pointers. The assumption is true for Emacs porting targets
5832 now, but we want to make other targets possible.
5833 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5834 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5835 In the rest of the code, change types of integers that hold casted
5836 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5837 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5838 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5839 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5840 No need to cast type when ORing.
5841 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5842 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5843 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5844 assume EMACS_INT is the same width as char *.
5845 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5846 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5847 Remove no-longer-needed casts.
5848 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5849 (xg_tool_bar_help_callback, xg_make_tool_item):
5850 Use EMACS_INTPTR to hold an integer
5851 that will be cast to void *; this can avoid a GCC warning
5852 if EMACS_INT is not the same width as void *.
5853 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5854 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5855 (current_message_1, set_message_1):
5856 Use a local to convert to proper width without a cast.
5857 * xmenu.c (dialog_selection_callback): Likewise.
5858
ede49d71
PE
5859 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5860 Also, don't assume VALBITS / RAND_BITS is less than 5,
5861 and don't rely on undefined behavior when shifting a 1 left into
5862 the sign bit.
5863 * lisp.h (get_random): Change signature to match.
5864
2f30ecd0
PE
5865 * lread.c (hash_string): Use size_t, not int, for hash computation.
5866 Normally we prefer signed values; but hashing is special, because
5867 it's better to use unsigned division on hash table sizes so that
5868 the remainder is nonnegative. Also, size_t is the natural width
5869 for hashing into memory. The previous code used 'int', which doesn't
5870 retain enough info to hash well into very large tables.
5871 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5872
2a866e7b
PE
5873 * dbusbind.c: Don't possibly lose pointer info when converting.
5874 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5875 Use XPNTR rather than XHASH, so that the high-order bits of
5876 the pointer aren't lost when converting through void *.
5877
51639eac
PE
5878 * eval.c (Fautoload): Don't double-shift a pointer.
5879
92394119
PE
5880 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5881
dbdb9a7c
JB
58822011-05-06 Juanma Barranquero <lekktu@gmail.com>
5883
5884 * gnutls.c (DEF_GNUTLS_FN):
5885 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5886
db7a0b4f
AS
58872011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5888
5889 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5890 marker. (Bug#8610)
5891
f7ff1b0f 58922011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5893
5894 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5895 New version that can reserve upto 2GB of heap space.
5896
f7ff1b0f 58972011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5898
5899 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5900
639c109b
TZ
59012011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5902
5903 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5904 `gnutls_certificate_set_x509_key_file'.
5905
d2127135
JB
59062011-05-05 Juanma Barranquero <lekktu@gmail.com>
5907
5908 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5909 Update dependencies.
5910
e968f4f3
JB
59112011-05-04 Juanma Barranquero <lekktu@gmail.com>
5912
5913 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5914 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5915 Remove unused parameter `fildes'.
5916 * process.c (read_process_output, send_process): Don't pass it.
5917
84d358f0
JB
59182011-05-04 Juanma Barranquero <lekktu@gmail.com>
5919
5920 Fix previous change: the library cache is defined in w32.c.
5921 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5922 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5923
0898ca10
JB
59242011-05-04 Juanma Barranquero <lekktu@gmail.com>
5925
5926 Implement dynamic loading of GnuTLS on Windows.
5927
5928 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5929 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5930 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5931 Declare.
5932
5933 * gnutls.c (Qgnutls_dll): Define.
5934 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5935 (gnutls_*): Declare function pointers.
5936 (init_gnutls_functions): New function to initialize function pointers.
5937 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5938 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5939 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5940 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5941 (emacs_gnutls_write, emacs_gnutls_read)
5942 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5943 (Fgnutls_available_p): New function.
5944 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5945 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5946 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5947
5948 * image.c: Include w32.h.
5949 (Vimage_type_cache): Delete.
5950 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5951 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5952 (w32_delayed_load): Move to w32.c.
5953
5954 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5955
5956 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5957 (w32_delayed_load): Move from image.c. When loading a library, record
5958 its filename in the :loaded-from property of the library id.
5959 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5960 Initialize and staticpro them.
5961 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5962
5963 * process.c: Include lisp.h before w32.h, not after.
5964 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5965 instead of gnutls_record_check_pending.
5966
5967 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5968
ff4de4aa
TZ
59692011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5970
5971 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5972 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5973 as passed in.
5974
abe95abb
JD
59752011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5976
5977 * xterm.c (x_set_frame_alpha): Do not set property on anything
5978 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5979
e16e55d4
JB
59802011-05-02 Juanma Barranquero <lekktu@gmail.com>
5981
5982 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5983
bafcf6a5
JB
59842011-05-02 Juanma Barranquero <lekktu@gmail.com>
5985
5986 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5987 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5988 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5989 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5990 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5991 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5992 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5993 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5994 (Qgnutls_bootprop_callbacks_verify): Make static.
5995
e7a6747f
AS
59962011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5997
19ed11ba
AS
5998 * callproc.c: Indentation fixup.
5999
e7a6747f 6000 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6001 (wait_for_termination, interruptible_wait_for_termination):
6002 Move after wait_for_termination_1.
e7a6747f 6003
1ef14cb4
LMI
60042011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6005
6006 * sysdep.c (interruptible_wait_for_termination): New function
6007 which is like wait_for_termination, but allows keyboard
6008 interruptions.
6009
6010 * callproc.c (Fcall_process): Add (:file "file") as an option for
6011 the STDOUT buffer.
6012 (Fcall_process_region): Ditto.
6013
330d880c
EZ
60142011-04-30 Eli Zaretskii <eliz@gnu.org>
6015
8db90b73
EZ
6016 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6017 rather than `XVECTOR (FOO)->size'.
6018
330d880c
EZ
6019 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6020 inttypes.h, as a gnulib replacement is used if it not available in
6021 system headers.
6022
15cbd324
EZ
60232011-04-21 Eli Zaretskii <eliz@gnu.org>
6024
6025 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6026 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6027 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6028
6029 * coding.c (coding_alloc_by_realloc): Error out if destination
6030 will grow beyond MOST_POSITIVE_FIXNUM.
6031 (decode_coding_emacs_mule): Abort if there isn't enough place in
6032 charbuf for the composition carryover bytes. Reserve an extra
6033 space for up to 2 characters produced in a loop.
6034 (decode_coding_iso_2022): Abort if there isn't enough place in
6035 charbuf for the composition carryover bytes.
6036
60372011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6038
ae940cca
EZ
6039 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6040 aborting when %lld or %lll format is passed.
6041 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6042 %llo or %llx format is passed. (Bug#8545)
6043
03ab8921
EZ
6044 * window.c (window_scroll_line_based): Use a marker instead of
6045 simple variables to record original value of point. (Bug#7952)
6046
afda1437
EZ
6047 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6048 produced by %s or %c overflows available buffer space. (Bug#8545)
6049
f76dee0c
PE
60502011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6051
6052 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6053 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6054
fdc5744d
JB
60552011-04-28 Juanma Barranquero <lekktu@gmail.com>
6056
6057 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6058
638f053a
JB
60592011-04-28 Juanma Barranquero <lekktu@gmail.com>
6060
6061 * keyboard.c (Qdelayed_warnings_hook): Define.
6062 (command_loop_1): Run `delayed-warnings-hook'
6063 if Vdelayed_warnings_list is non-nil.
6064 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6065 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6066
d178f871
EZ
60672011-04-28 Eli Zaretskii <eliz@gnu.org>
6068
6069 * doprnt.c (doprnt): Don't return value smaller than the buffer
6070 size if the message was truncated. (Bug#8545).
6071
b124fd93
JB
60722011-04-28 Juanma Barranquero <lekktu@gmail.com>
6073
6074 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6075 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6076
e810457d
PE
60772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6078
6079 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6080
ea51cceb
JB
60812011-04-27 Juanma Barranquero <lekktu@gmail.com>
6082
6083 * makefile.w32-in: Update dependencies.
6084
94dcfacf
EZ
60852011-04-27 Eli Zaretskii <eliz@gnu.org>
6086
6087 Improve `doprnt' and its usage. (Bug#8545)
6088 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6089 `format_end'. Remove support for %l as a conversion specifier.
6090 Don't use xrealloc. Improve diagnostics when the %l size modifier
6091 is used. Update the commentary.
6092
6093 * eval.c (verror): Simplify calculation of size_t.
6094
6095 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6096 messages.
6097
f61f41d7
PE
60982011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6099
6100 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6101 change.
6102
96fb4434
PE
61032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6104
6105 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6106 This makes this file independent of the recent pseudovector change.
6107
671875da 61082011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6109
69e9b5a3
PE
6110 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6111
b5f869a7 6112 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6113 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6114 Remove unused local.
c8926152 6115 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6116
841a1577 6117 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6118 GCC 4.6.0 optimizes based on type-based alias analysis.
6119 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6120 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6121 != &v->size, and therefore "v->size = 1; b->size = 2; return
6122 v->size;" must therefore return 1. This assumption is incorrect
6123 for Emacs, since it type-puns struct Lisp_Vector * with many other
6124 types. To fix this problem, this patch adds a new type struct
f904488f 6125 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6126 and pseudovectors, and helps optimizing compilers not get fooled
6127 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6128 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6129 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6130 the size member.
eab3844f
PE
6131 (XSETPVECTYPE): Rewrite in terms of new macro.
6132 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6133 This is a bit clearer, and further avoids the possibility of
6134 undesirable aliasing.
6135 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6136 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6137 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6138 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6139 (ASIZE): Now uses header.size rather than size.
6140 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6141 to avoid the hassle of writing XVECTOR (foo)->header.size.
6142 (struct vectorlike_header): New type.
eab3844f
PE
6143 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6144 object, to help avoid aliasing.
6145 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6146 (SUBRP): Likewise, since Lisp_Subr is a special case.
6147 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6148 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6149 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6150 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6151 changed to be "header.size" and "header.next".
6152 * buffer.h (struct buffer): Likewise.
6153 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6154 * frame.h (struct frame): Likewise.
6155 * process.h (struct Lisp_Process): Likewise.
6156 * termhooks.h (struct terminal): Likewise.
6157 * window.c (struct save_window_data, struct saved_window): Likewise.
6158 * window.h (struct window): Likewise.
6159 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6160 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6161 * buffer.c (init_buffer_once): Likewise.
6162 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6163 special case.
6164 * process.c (Fformat_network_address): Use local var for size,
6165 for brevity.
6166
0df1eac5
PE
6167 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6168
847ab9d1 6169 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6170 * data.c (atof): Remove decl; no longer used or needed.
6171 (digit_to_number): Move to lread.c.
6172 (Fstring_to_number): Use new string_to_number function, to be
6173 consistent with how the Lisp reader treats infinities and NaNs.
6174 Do not assume that floating-point numbers represent EMACS_INT
6175 without losing information; this is not true on most 64-bit hosts.
6176 Avoid double-rounding errors, by insisting on integers when
6177 parsing non-base-10 numbers, as the documentation specifies.
6178 * lisp.h (string_to_number): New decl, replacing ...
6179 (isfloat_string): Remove.
bc0a5c13 6180 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6181 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6182 appears to have been a coding error. Similarly, do not accept
6183 strings like +-1e0 as floating point numbers. Do not report
6184 overflow for integer overflows unless the base is not 10 which
6185 means we have no simple and reliable way to continue.
6186 Break out the floating-point parsing into a new
6187 function string_to_number, so that Fstring_to_number parses
6188 floating point numbers consistently with the Lisp reader.
04f2d78b 6189 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6190 (E_CHAR, EXP_INT): Remove, replacing with ...
6191 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6192 (string_to_number): New function, replacing isfloat_string.
6193 This function checks for valid syntax and produces the resulting
6194 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6195 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6196 so that overflow for non-base-10 numbers is reported only when
6197 there's no portable and simple way to convert to floating point.
452f4150 6198
67769ffc
PE
6199 * textprop.c (set_text_properties_1): Rewrite for clarity,
6200 and to avoid GCC warning about integer overflow.
6201
c20db43f
PE
6202 * intervals.h (struct interval): Use EMACS_INT for members
6203 where EMACS_UINT might cause problems. See
6204 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6205 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6206 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6207 All uses changed.
37aa2f85
PE
6208 (offset_intervals): Tell GCC not to worry about length overflow
6209 when negating a negative length.
c20db43f 6210
2538aa2f
PE
6211 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6212 (overrun_check_free): Likewise.
6213
f2d3008d
PE
6214 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6215 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6216 word size.
6217
ec8df744
PE
6218 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6219 (gnutls_make_error): Rename local to avoid shadowing.
6220 (gnutls_emacs_global_deinit): ifdef out; not used.
6221 (Fgnutls_boot): Use const for pointer to readonly storage.
6222 Comment out unused local. Fix pointer signedness problems.
6223
640ee02d
PE
6224 * lread.c (openp): Don't stuff size_t into an 'int'.
6225 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6226 about possible signed overflow.
6227
6048fb2a
PE
6228 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6229 (GDK_KEY_g): Don't define if already defined.
6230 (xg_prepare_tooltip): Avoid pointer signedness problem.
6231 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6232
fa3c87e1
PE
6233 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6234 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6235
2172544b
PE
6236 * xfns.c (Fx_window_property): Simplify a bit,
6237 to make a bit faster and to avoid GCC 4.6.0 warning.
6238 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6239
9b821a21
PE
6240 * fns.c (internal_equal): Don't assume size_t fits in int.
6241
3c616cfa
PE
6242 * alloc.c (compact_small_strings): Tighten assertion a little.
6243
c2982e87
PE
6244 Replace pEd with more-general pI, and fix some printf arg casts.
6245 * lisp.h (pI): New macro, generalizing old pEd macro to other
6246 conversion specifiers. For example, use "...%"pI"d..." rather
6247 than "...%"pEd"...".
6248 (pEd): Remove. All uses replaced with similar uses of pI.
6249 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6250 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6251 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6252 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6253 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6254 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6255 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6256 64-bit hosts.
6257 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6258 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6259 * print.c (safe_debug_print, print_object): Likewise.
6260 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6261 to int.
6f04d126
PE
6262 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6263 avoiding the 0 flag, which is not portable.
c2982e87
PE
6264 * process.c (Fmake_network_process): Use pI to avoid cast.
6265 * region-cache.c (pp_cache): Likewise.
6266 * xdisp.c (decode_mode_spec): Likewise.
6267 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6268 behavior on 64-bit hosts with printf arg.
6f04d126 6269 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6270 (x_stop_queuing_selection_requests): Likewise.
6271 (x_get_window_property): Don't truncate byte count to an 'int'
6272 when tracing.
0b432f21 6273
5e073ec7
PE
6274 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6275 here, since it parses constructs like leading '-' and spaces,
6276 which are not wanted; and it overflows with large numbers.
6277 Instead, simply match F[0-9]+, which is what is wanted anyway.
6278
36372bf9
PE
6279 * alloc.c: Remove unportable assumptions about struct layout.
6280 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6281 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6282 (allocate_vectorlike, make_pure_vector): Use the new macros,
6283 plus offsetof, to remove unportable assumptions about struct layout.
6284 These assumptions hold on all porting targets that I know of, but
6285 they are not guaranteed, they're easy to remove, and removing them
6286 makes further changes easier.
6287
0b432f21
PE
6288 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6289 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6290 (string_overrun_cookie): Now const. Use initializers that
6291 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6292 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6293 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6294 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6295 multiple of sizeof (EMACS_INT); it need not be, if
6296 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6297 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6298
895009e1
JB
62992011-04-26 Juanma Barranquero <lekktu@gmail.com>
6300
6301 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6302
6a7a1b0b
TZ
63032011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6304
6305 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6306 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6307 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6308
841a1577 63092011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6310
6311 * lisp.h (Qdebug): List symbol.
895009e1 6312 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6313 * keyboard.c (debug-on-event): New variable.
6314 (handle_user_signal): Break into debugger when debug-on-event
6315 matches the current signal symbol.
6316
f2d3ba6f
DN
63172011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6318
6319 * alloc.c (check_sblock, check_string_bytes)
6320 (check_string_free_list): Convert to standard C.
6321
42ce4c63
TZ
63222011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6323
6324 * w32.c (emacs_gnutls_push): Fix typo.
6325
825cd63c
EZ
63262011-04-25 Eli Zaretskii <eliz@gnu.org>
6327
fb11d64d
EZ
6328 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6329 "cast to pointer from integer of different size".
6330
825cd63c
EZ
6331 Improve doprnt and its use in verror. (Bug#8545)
6332 * doprnt.c (doprnt): Document the set of format control sequences
6333 supported by the function. Use SAFE_ALLOCA instead of always
6334 using `alloca'.
6335
6336 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6337 is one byte too soon. Don't use xrealloc; instead xfree and
6338 xmalloc anew.
6339
e061a11b
TZ
63402011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6341
6342 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6343 callbacks stage.
6344
6345 * gnutls.c: Renamed global_initialized to
6346 gnutls_global_initialized. Added internals for the
6347 :verify-hostname-error, :verify-error, and :verify-flags
6348 parameters of `gnutls-boot' and documented those parameters in the
6349 docstring. Start callback support.
9173deec
JB
6350 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6351 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6352 on error. Return error code.
e061a11b
TZ
6353 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6354 (emacs_gnutls_read): Likewise.
6355 (Fgnutls_boot): Return handshake error code.
6356 (emacs_gnutls_handle_error): New function.
6357 (wsaerror_to_errno): Likewise.
6358
6359 * w32.h (emacs_gnutls_pull): Add prototype.
6360 (emacs_gnutls_push): Likewise.
6361
6362 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6363 (emacs_gnutls_push): Likewise.
6364
63652011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6366
6367 * process.c (wait_reading_process_output): Check if GnuTLS
6368 buffered some data internally if no FDs are set for TLS
6369 connections.
6370
6371 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6372 (LIBS): Link to USER_LIBS.
6373 ($(BLD)/gnutls.$(0)): New target.
6374
fa6996bc
EZ
63752011-04-24 Eli Zaretskii <eliz@gnu.org>
6376
eb35682e
EZ
6377 * xdisp.c (handle_single_display_spec): Rename the
6378 display_replaced_before_p argument into display_replaced_p, to
6379 make it consistent with the commentary. Fix typos in the
6380 commentary.
6381
e2ad650c
EZ
6382 * textprop.c (syms_of_textprop): Remove dead code.
6383 (copy_text_properties): Delete obsolete commentary about an
6384 interface that was deleted long ago. Fix typos in the description
6385 of arguments.
6386
1b2de274
EZ
6387 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6388 to changes in oldXMenu/XMenu.h from 2011-04-16.
6389 <menu_help_message, prev_menu_help_message>: Constify.
6390 (IT_menu_make_room): menu->help_text is now `const char **';
6391 adjust.
6392
6393 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6394 to changes in oldXMenu/XMenu.h from 2011-04-16.
6395 (struct XMenu): Declare `help_text' `const char **'.
6396
6397 * xfaces.c <Qunspecified>: Make extern again.
6398
6399 * syntax.c: Include sys/types.h before including regex.h, as
6400 required by Posix.
6401
762b15be
EZ
6402 * doc.c (get_doc_string): Improve the format passed to `error'.
6403
6404 * doprnt.c (doprnt): Improve commentary.
6405
6406 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6407
6408 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6409 them with etags.
6410
f1052e5d
EZ
6411 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6412 changes in globals.h immediately force recompilation.
762b15be
EZ
6413 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6414 $(CURDIR)/s/ms-w32.h.
6415 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6416
fa6996bc
EZ
6417 * character.c (Fchar_direction): Function deleted.
6418 (syms_of_character): Don't defsubr it.
6419 <char-direction-table>: Deleted.
6420
e6c3da20
EZ
64212011-04-23 Eli Zaretskii <eliz@gnu.org>
6422
6423 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6424 * doprnt.c: Include limits.h.
6425 (SIZE_MAX): New macro.
04f2d78b
CB
6426 (doprnt): Return a size_t value. 2nd arg is now size_t.
6427 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6428 Improve overflow protection. Support `l' modifier for integer
6429 conversions. Support %l conversion. Don't assume an EMACS_INT
6430 argument for integer conversions and for %c.
6431
6432 * lisp.h (doprnt): Restore prototype.
6433
6434 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6435 $(SRC)/character.h.
6436
6437 * Makefile.in (base_obj): Add back doprnt.o.
6438
6439 * deps.mk (doprnt.o): Add back prerequisites.
6440 (callint.o): Depend on character.h.
6441
6442 * eval.c (internal_lisp_condition_case): Include the handler
6443 representation in the error message.
6444 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6445 when breaking from the loop.
6446
6447 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6448
6449 * callint.c (Fcall_interactively): When displaying error message
6450 about invalid control letter, pass the character's codepoint, not
6451 a pointer to its multibyte form. Improve display of the character
6452 in octal and display also its hex code.
6453
6454 * character.c (char_string): Use %x to display the (unsigned)
6455 codepoint of an invalid character, to avoid displaying a bogus
6456 negative value.
6457
6458 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6459 `error', not SYMBOL_NAME itself.
6460
6461 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6462 character arguments to `error'.
6463
6464 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6465 to `error' in error message about FINAL_CHAR argument. Make sure
6466 FINAL_CHAR is a character, and use %c when it is passed as
6467 argument to `error'.
6468
4ffd0d6b 64692011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6470
6471 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6472
6473 * w32.c: Include <time.h>.
6474 (sys_localtime): New function.
6475
4ffd0d6b 64762011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6477
6478 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6479
4ffd0d6b 6480 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6481
4ffd0d6b 64822011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6483
4ffd0d6b
GM
6484 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6485 zombies (Bug#8467).
aac0c6e3 6486
04c56954
EZ
64872011-04-19 Eli Zaretskii <eliz@gnu.org>
6488
6489 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6490 gl_state.e_property when gl_state.object is Qt.
6491
6492 * insdel.c (make_gap_larger): Remove limitation of buffer size
6493 to <= INT_MAX.
6494
16a43933
CY
64952011-04-18 Chong Yidong <cyd@stupidchicken.com>
6496
6497 * xdisp.c (lookup_glyphless_char_display)
6498 (produce_glyphless_glyph): Handle cons cell entry in
6499 glyphless-char-display.
6500 (Vglyphless_char_display): Document it.
6501
6502 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6503 glyphless-char-display.
6504
4581706e
CY
65052011-04-17 Chong Yidong <cyd@stupidchicken.com>
6506
6507 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6508
6509 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6510
6511 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6512 definition for no-X builds.
6513
4887c6e2 65142011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6515
fd35b6f9
PE
6516 Static checks with GCC 4.6.0 and non-default toolkits.
6517
5c1ccb01
PE
6518 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6519
006c5daa
PE
6520 * process.c (keyboard_bit_set): Define only if SIGIO.
6521 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6522 (send_process): Repair possible setjmp clobbering.
6523
efc736d3
PE
6524 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6525
4e2fe2e6
PE
6526 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6527
f97334a2
PE
6528 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6529
4e75f29d
PE
6530 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6531 Define only if needed.
6532
90efadd1
PE
6533 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6534 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6535 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6536
3c647824
PE
6537 * dispextern.h (struct redisplay_interface): Rename param
6538 to avoid shadowing.
e264f262 6539 * termhooks.h (struct terminal): Likewise.
761383f4 6540 * xterm.c (xembed_send_message): Likewise.
3c647824 6541
b58c5c4a
PE
6542 * insdel.c (make_gap_smaller): Define only if
6543 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6544
cad59032
PE
6545 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6546 it.
6547
c339dc2e
PE
6548 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6549 so that we aren't warned about unused symbols.
6550
91a3e27b
PE
6551 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6552
399c71d3 6553 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6554
8ffc96f5
PE
6555 * xfns.c (x_real_positions): Mark locals as initialized.
6556
eef9bc79
PE
6557 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6558
098db9dd
PE
6559 * xterm.c: Fix problems found by static analysis with other toolkits.
6560 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6561 (x_dispatch_event): Declare static if USE_GTK, and
6562 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6563 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6564 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6565 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6566 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6567
eb18f6cc
PE
6568 * xmenu.c (menu_help_callback): Pointer type fixes.
6569 Use const pointers when pointing at readonly data. Avoid pointer
6570 signedness clashes.
6571 (FALSE): Remove unused macro.
6572 (update_frame_menubar): Remove unused decl.
6573
1fe72bf8
PE
6574 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6575
60d9e1db
PE
6576 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6577 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6578 (single_menu_item): Rename local to avoid shadowing.
6579
39261c26
PE
6580 * keyboard.c (make_lispy_event): Remove unused local var.
6581
018c5e19
PE
6582 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6583 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6584
63d2b86e
PE
6585 * bitmaps: Change bitmaps from unsigned char back to the X11
6586 compatible char. Avoid the old compiler warnings about
6587 out-of-range initializers by using, for example, '\xab' rather
6588 than 0xab.
6589
aefd87e1
PE
6590 * xgselect.c (xgselect_initialize): Check vs interface
6591 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6592
bf501fb9
PE
6593 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6594
e9829fdf
PE
6595 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6596 to read-only memory.
6597
1086c095
PE
6598 * fns.c (vector): Remove; this old hack is no longer needed.
6599
2baccd04 6600 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6601 Remove unused var.
dde42981 6602 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6603
72391843 6604 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6605
436c16df 6606 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6607 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6608 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6609
92bb796d 6610 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6611 (x_term_init): Remove local to avoid shadowing.
92bb796d 6612
764430a3 6613 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6614
6615 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6616 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6617
d1dfb56c
EZ
66182011-04-16 Eli Zaretskii <eliz@gnu.org>
6619
c4354cb4
EZ
6620 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6621
d1dfb56c
EZ
6622 Fix regex.c, syntax.c and friends for buffers > 2GB.
6623 * syntax.h (struct gl_state_s): Declare character position members
6624 EMACS_INT.
6625
6626 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6627
04f2d78b
CB
6628 * textprop.c (verify_interval_modification, interval_of):
6629 Declare arguments EMACS_INT.
d1dfb56c
EZ
6630
6631 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6632 EMACS_INT.
6633
6634 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6635
6636 * indent.c (Fvertical_motion): Local variable it_start is now
6637 EMACS_INT.
6638
6639 * regex.c (re_match, re_match_2, re_match_2_internal)
6640 (bcmp_translate, regcomp, regexec, print_double_string)
6641 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6642 (re_compile_pattern, re_exec): Declare arguments and local
6643 variables `size_t' and `ssize_t' and return values `regoff_t', as
6644 appropriate.
6645 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6646 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6647 <compile_stack_type>: `size' and `avail' are now `size_t'.
6648
6649 * regex.h <regoff_t>: Use ssize_t, not int.
6650 (re_search, re_search_2, re_match, re_match_2): Arguments that
6651 specify buffer/string position and length are now ssize_t and
6652 size_t. Return type is regoff_t.
6653
613052cd
BK
66542011-04-16 Ben Key <bkey76@gmail.com>
6655
6656 * nsfont.m: Fixed bugs in ns_get_family and
6657 ns_descriptor_to_entity that were caused by using free to
6658 deallocate memory blocks that were allocated by xmalloc (via
6659 xstrdup). This caused Emacs to crash when compiled with
6660 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6661 --enable-checking=xmallocoverrun). xfree is now used to
6662 deallocate these memory blocks.
6663
4170f62f 66642011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6665
71b41406
PE
6666 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6667
9587a89d
PE
6668 emacs_write: Accept and return EMACS_INT for sizes.
6669 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6670 et seq.
6671 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6672 Accept and return EMACS_INT.
6673 (emacs_gnutls_write): Return the number of bytes written on
6674 partial writes.
6675 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6676 (emacs_read, emacs_write): Remove check for negative size, as the
6677 Emacs source code has been audited now.
9587a89d
PE
6678 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6679 (emacs_read, emacs_write): Use it.
273a5f82
PE
6680 * process.c (send_process): Adjust to the new signatures of
6681 emacs_write and emacs_gnutls_write. Do not attempt to store
6682 a byte offset into an 'int'; it might overflow.
9587a89d 6683 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6684
3e047f51
PE
6685 * sound.c: Don't assume sizes fit in 'int'.
6686 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6687 Return EMACS_INT, not int.
3e047f51 6688 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6689 Accept EMACS_INT, not int.
6690 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6691 record read return values.
6692
cc39a9db
BK
66932011-04-15 Ben Key <bkey76@gmail.com>
6694
c9d0ec6d
JB
6695 * keyboard.c (Qundefined): Don't declare static since it is used
6696 in nsfns.m.
6697 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6698 static since they are used in nsfont.m.
cc39a9db 6699
6c60eb9f
SM
67002011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6701
6702 * process.c (Qprocessp): Don't declare static.
6703 * lisp.h (Qprocessp): Declare again.
6704
7990b61a
JB
67052011-04-15 Juanma Barranquero <lekktu@gmail.com>
6706
6707 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6708
5d4cb038
PE
67092011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6710
8bd7b830 6711 Improve C-level modularity by making more things 'static'.
cd64ea1d 6712
e3b27b31
PE
6713 Don't publish debugger-only interfaces to other modules.
6714 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6715 (verify_bytepos, count_markers): Move decls to the only modules
6716 that need them.
6717 * region-cache.h (pp_cache): Likewise.
6718 * window.h (check_all_windows): Likewise.
6719 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6720
5d4cb038
PE
6721 * sysdep.c (croak): Now static, if
6722 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6723 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6724
6725 * alloc.c (refill_memory_reserve): Now static if
6726 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6727 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6728
e87b6180
PE
6729 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6730 Define only if USE_LUCID.
6731
ac64929e
PE
6732 * xrdb.c (x_customization_string, x_rm_string): Now static.
6733
6f37259d
PE
6734 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6735 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6736
1683e3ab
PE
6737 * xdisp.c (draw_row_with_mouse_face): Now static.
6738 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6739
de9c2632
PE
6740 * window.h (check_all_windows): Mark externally visible.
6741
2b96acb7
PE
6742 * window.c (window_deletion_count): Now static.
6743
6744 * undo.c: Make symbols static if they're not exported.
6745 (last_undo_buffer, last_boundary_position, pending_boundary):
6746 Now static.
6747
50436f33
PE
6748 * textprop.c (interval_insert_behind_hooks): Now static.
6749 (interval_insert_in_front_hooks): Likewise.
6750
64520e5c
PE
6751 * term.c: Make symbols static if they're not exported.
6752 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6753 (max_frame_lines, tty_set_terminal_modes):
6754 (tty_reset_terminal_modes, tty_turn_off_highlight):
6755 (get_tty_terminal): Now static.
6756 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6757 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6758 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6759 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6760 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6761
1fa53021
PE
6762 * sysdep.c: Make symbols static if they're not exported.
6763 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6764 Now static.
6765 (sigprocmask_set, full_mask): Remove; unused.
6766 (wait_debugging): Mark as visible.
6767 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6768 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6769
d4b43b22
PE
6770 * syntax.c (syntax_temp): Define only if !__GNUC__.
6771
b7c513d0
PE
6772 * sound.c (current_sound_device, current_sound): Now static.
6773
989b29ad
PE
6774 * search.c (searchbufs, searchbuf_head): Now static.
6775
13a55a78
PE
6776 * scroll.c (scroll_cost): Remove; unused.
6777 * dispextern.h (scroll_cost): Remove decl.
6778
de68a1fc
PE
6779 * region-cache.h (pp_cache): Mark as externally visible.
6780
40ccffa6
PE
6781 * process.c: Make symbols static if they're not exported.
6782 (process_tick, update_tick, create_process, chan_process):
6783 (Vprocess_alist, proc_buffered_char, datagram_access):
6784 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6785 (deactivate_process): Mark defn as static, as well as decl.
6786 * lisp.h (create_process): Remove decl.
6787 * process.h (chan_process, Vprocess_alist): Remove decls.
6788
ad64fc97
PE
6789 * print.c: Make symbols static if they're not exported.
6790 (print_depth, new_backquote_output, being_printed, print_buffer):
6791 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6792 (print_interval, print_number_index, initial_stderr_stream):
6793 Now static.
6794 * lisp.h (Fprinc): Remove decl.
6795 (debug_output_compilation_hack): Mark as externally visible.
6796
adddb265
PE
6797 * sysdep.c (croak): Move decl from here to syssignal.h.
6798 * syssignal.h (croak): Put it here, so the API can be checked when
6799 'croak' is called from dissociate_if_controlling_tty.
6800
1717ede2
PE
6801 * minibuf.c: Make symbols static if they're not exported.
6802 (minibuf_save_list, choose_minibuf_frame): Now static.
6803 * lisp.h (choose_minibuf_frame): Remove decl.
6804
fa5fb2bc
PE
6805 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6806
1e3890d1
PE
6807 * lread.c: Make symbols static if they're not exported.
6808 (read_objects, initial_obarray, oblookup_last_bucket_number):
6809 Now static.
6810 (make_symbol): Remove; unused.
6811 * lisp.h (initial_obarray, make_symbol): Remove decls.
6812
8a1414fa
PE
6813 * keyboard.c: Make symbols static if they're not exported.
6814 (single_kboard, recent_keys_index, total_keys, recent_keys):
6815 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6816 (this_single_command_key_start, echoing, last_auto_save):
6817 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6818 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6819 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6820 (Vlispy_mouse_stem, double_click_count):
6821 Now static.
6822 (force_auto_save_soon): Define only if SIGDANGER.
6823 (ignore_mouse_drag_p): Now static if
6824 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6825 (print_help): Remove; unused.
6826 (stop_character, last_timer_event): Mark as externally visible.
6827 * keyboard.h (ignore_mouse_drag_p): Declare only if
6828 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6829 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6830 * lisp.h (echoing): Remove decl.
6831 (force_auto_save_soon): Declare only if SIGDANGER.
6832 * xdisp.c (redisplay_window): Simplify code, to make it more
6833 obvious that ignore_mouse_drag_p is not accessed if !defined
6834 USE_GTK && !defined HAVE_NS.
6835
93ea6e8f
PE
6836 * intervals.c: Make symbols static if they're not exported.
6837 (merge_properties_sticky, merge_interval_right, delete_interval):
6838 Now static.
6839 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6840
77382fcc
PE
6841 * insdel.c: Make symbols static if they're not exported.
6842 However, leave prepare_to_modify_buffer alone. It's never
6843 called from outside this function, but that appears to be a bug.
6844 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6845 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6846 (adjust_after_replace_noundo): Remove; unused.
6847 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6848 (signal_before_change): Remove decls.
77382fcc 6849
9306c32e
PE
6850 * indent.c (val_compute_motion, val_vmotion): Now static.
6851
cd44d2eb
PE
6852 * image.c: Make symbols static if they're not exported.
6853 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6854 if USE_GTK.
6855 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6856 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6857
ad9a7a06
PE
6858 * fringe.c (standard_bitmaps): Now static.
6859 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6860
81626931
PE
6861 * frame.c: Make symbols static if they're not exported.
6862 (x_report_frame_params, make_terminal_frame): Now static.
6863 (get_frame_param): Now static, unless HAVE_NS.
6864 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6865 (x_get_resource_string): Remove; not used.
6866 * frame.h (make_terminal_frame, x_report_frame_params):
6867 (x_get_resource_string); Remove decls.
6868 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6869 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6870
239f9db9
PE
6871 * font.c, fontset.c: Make symbols static if they're not exported.
6872 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6873 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6874 * font.c (font_close_object): Now static.
6875 * font.h (font_close_object): Remove.
6876 * fontset.c (FONTSET_OBJLIST): Remove.
6877 (free_realized_fontset) #if-0 the body, which does nothing.
6878 (face_suitable_for_char_p): #if-0, as it's never called.
6879 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6880 * xfaces.c (face_at_string_position):
6881 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6882 since 0 is always ASCII.
6883
dfcf3579
PE
6884 * fns.c (weak_hash_tables): Now static.
6885
5045092b
PE
6886 * fileio.c: Make symbols static if they're not exported.
6887 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6888 (Vwrite_region_annotation_buffers): Now static.
6889
57a96f5c
PE
6890 * eval.c: Make symbols static if they're not exported.
6891 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6892 * lisp.h (backtrace_list): Remove decl.
6893
35f08c38
PE
6894 * emacs.c: Make symbols static if they're not exported.
6895 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6896 (fatal_error_code, fatal_error_signal_hook, standard_args):
6897 Now static.
6898 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6899 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6900 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6901 * lisp.h (fatal_error_signal_hook): Remove decl.
6902 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6903
f44bd759
PE
6904 * editfns.c: Move a (normally-unused) function to its only use.
6905 * editfns.c, lisp.h (get_operating_system_release): Remove.
6906 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6907 worth the hassle of breaking this out.
6908
b532497d
PE
6909 * xterm.c: Make symbols static if they're not exported.
6910 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6911 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6912 (x_destroy_window, x_delete_display):
6913 Now static.
6914 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6915 (x_mouse_leave): Remove; unused.
6916 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6917 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6918 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6919 Remove decls.
6920 (x_mouse_leave): Declare only if WINDOWSNT.
6921 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6922 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6923 USE_X_TOOLKIT.
6924
1675728f
PE
6925 * ftxfont.c: Make symbols static if they're not exported.
6926 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6927 HAVE_FREETYPE.
6928 * font.h (ftxfont_driver): Likewise.
6929
e4cebfca
PE
6930 * xfns.c: Make symbols static if they're not exported.
6931 (x_last_font_name, x_display_info_for_name):
6932 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6933 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6934 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6935 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6936 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6937 (last_show_tip_args): Now static.
6938 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6939 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6940 (x_screen_planes): Remove; unused.
6941 * dispextern.h (x_screen_planes): Remove decl.
6942
5bf46f05
PE
6943 * dispnew.c: Make symbols static if they're not exported.
6944 * dispextern.h (redraw_garbaged_frames, scrolling):
6945 (increment_row_positions): Remove.
6946 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6947 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6948 Now static.
6949 (redraw_garbaged_frames): Remove; unused.
6950
435f4c28
PE
6951 * xfaces.c: Make symbols static if they're not exported.
6952 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6953 Remove decls.
6954 * xterm.h (defined_color): Remove decls.
6955 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6956 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6957 (menu_face_changed_default, defined_color, free_realized_face):
6958 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6959 (ascii_face_of_lisp_face): Remove; unused.
6960
8524aef3
PE
6961 * xdisp.c: Make symbols static if they're not exported.
6962 * dispextern.h (scratch_glyph_row, window_box_edges):
6963 (glyph_to_pixel_coords, set_cursor_from_row):
6964 (get_next_display_element, set_iterator_to_next):
6965 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6966 (show_mouse_face): Remove decls
6967 * frame.h (message_buf_print): Likewise.
6968 * lisp.h (pop_message, set_message, check_point_in_composition):
6969 Likewise.
6970 * xterm.h (set_vertical_scroll_bar): Likewise.
6971 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6972 (message_buf_print, scratch_glyph_row, displayed_buffer):
6973 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6974 (get_next_display_element, show_mouse_face, window_box_edges):
6975 (frame_to_window_pixel_xy, check_point_in_composition):
6976 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6977 (glyph_to_pixel_coords): Remove; unused.
6978
16390cd2
PE
6979 * dired.c (file_name_completion): Now static.
6980
6981 * dbusbind.c (xd_in_read_queued_messages): Now static.
6982
a25f4dfa
PE
6983 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6984 * data.c (circular_list_error): Remove.
6985
14a9c8df
PE
6986 * commands.h (last_point_position, last_point_position_buffer):
6987 (last_point_position_window): Remove decls.
6988 * keyboard.c: Make these variables static.
6989
04f2d78b
CB
6990 * coding.h (coding, code_convert_region, encode_coding_gap):
6991 Remove decls.
74ab6df5
PE
6992 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6993 (iso_code_class, detect_coding, code_convert_region): Now static.
6994 (encode_coding_gap): Remove; unused.
6995
38dfbee1
PE
6996 * chartab.c (chartab_chars, chartab_bits): Now static.
6997
a2cb4e63
PE
6998 * charset.h (charset_iso_8859_1): Remove decl.
6999 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7000 Now static.
7001
127198fd
PE
7002 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7003 * ccl.c (Vccl_program_table): Now static.
7004 (check_ccl_update): Remove; unused.
7005
d85b608f
PE
7006 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7007 * category.h: ... from here.
7008 * category.c (check_category_table, set_category_set): Now static.
7009
31cd66f3
PE
7010 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7011 * lisp.h: Remove these decls.
7012
c358e587
PE
7013 * buffer.c (buffer_count): Remove unused var.
7014
e78aecca
PE
7015 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7016 so that it's not optimized away.
7017 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7018 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7019 exported only to the debugger.
7020
e192d7d3 7021 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7022 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7023
92470028
PE
7024 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7025 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7026 was inaccessible from Lisp.
7027 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7028 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7029
244ed907
PE
7030 alloc.c: Import and export fewer symbols, and remove unused items.
7031 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7032 is defined.
7033 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7034 it's not optimized away by whole-program optimization.
7035 (message_enable_multibyte, free_misc): Remove.
7036 (catchlist, handlerlist, mark_backtrace):
7037 Declare only if BYTE_MARK_STACK.
7038 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7039 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7040 (message_enable_multibyte): Remove decl.
7041 (free_misc, interval_free_list, float_block, float_block_index):
7042 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7043 (cons_free_list, last_marked_index):
7044 Now static.
7045 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7046 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7047 (mark_backtrace): Define only if BYTE_MARK_STACK.
7048 * xdisp.c (message_enable_multibyte): Now static.
7049
61c2b50e 7050 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7051 This makes it easier for human readers (and static analyzers)
7052 to see whether these variables are used from other modules.
7053 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7054 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7055 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7056 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7057 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7058 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7059 * xmenu.c, xselect.c:
7060 Declare Q* vars static if they are not used in other modules.
7061 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7062 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7063 Remove decls of unexported vars.
7064 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7065
95c82688
PE
7066 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7067
16a97296
PE
7068 Make Emacs functions such as Fatom 'static' by default.
7069 This makes it easier for human readers (and static analyzers)
7070 to see whether these functions can be called from other modules.
7071 DEFUN now defines a static function. To make the function external
7072 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7073 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7074 (Finit_image_library):
16a97296
PE
7075 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7076 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7077 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7078 Remove decls, since these functions are now static.
7079 (Funintern, Fget_internal_run_time): New decls, since these functions
7080 were already external.
95c82688 7081
16a97296
PE
7082 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7083 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7084 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7085 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7086 * keyboard.c, keymap.c, lread.c:
7087 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7088 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7089 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7090 Mark functions with DEFUE instead of DEFUN,
7091 if they are used in other modules.
7092 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7093 decls for now-static functions.
7094 * buffer.h (Fdelete_overlay): Remove decl.
7095 * callproc.c (Fgetenv_internal): Mark as internal.
7096 * composite.c (Fremove_list_of_text_properties): Remove decl.
7097 (Fcomposition_get_gstring): New forward static decl.
7098 * composite.h (Fcomposite_get_gstring): Remove decl.
7099 * dired.c (Ffile_attributes): New forward static decl.
7100 * doc.c (Fdocumntation_property): New forward static decl.
7101 * eval.c (Ffetch_bytecode): New forward static decl.
7102 (Funintern): Remove extern decl; now in .h file where it belongs.
7103 * fileio.c (Fmake_symbolic_link): New forward static decl.
7104 * image.c (Finit_image_library): New forward static decl.
7105 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7106 * intervals.h (Fprevious_property_change):
7107 (Fremove_list_of_text_properties): Remove decls.
7108 * keyboard.c (Fthis_command_keys): Remove decl.
7109 (Fcommand_execute): New forward static decl.
7110 * keymap.c (Flookup_key): New forward static decl.
7111 (Fcopy_keymap): Now static.
7112 * keymap.h (Flookup_key): Remove decl.
7113 * process.c (Fget_process): New forward static decl.
7114 (Fprocess_datagram_address): Mark as internal.
7115 * syntax.c (Fsyntax_table_p): New forward static decl.
7116 (skip_chars): Remove duplicate decl.
7117 * textprop.c (Fprevious_property_change): New forward static decl.
7118 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7119 Now internal.
7120 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7121 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7122
785bbd42
PE
7123 * editfns.c (Fformat): Remove unreachable code.
7124
8b913b57
AS
71252011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7126
7127 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7128 change. (Bug#8496)
7129
a6744a35
EZ
71302011-04-13 Eli Zaretskii <eliz@gnu.org>
7131
7132 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7133 when at ZV. (Bug#8487)
7134
e7974947
AS
71352011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7136
baad03f0
AS
7137 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7138 (Bug#8437)
7139 * keyboard.c (parse_tool_bar_item): Likewise.
7140 * sound.c (sound_cleanup, alsa_close): Likewise.
7141 * termcap.c (tgetent): Likewise.
7142 * xfns.c (x_default_font_parameter): Likewise.
7143 * xsettings.c (read_and_apply_settings): Likewise.
7144
e7974947
AS
7145 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7146 (overrun_check_free): Protoize.
7147
28272684
PE
71482011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7149
7150 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7151 since callers should never pass a negative size.
7152 Change the signature to match that of plain 'read' and 'write'; see
7153 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7154 * lisp.h: Update prototypes of emacs_write and emacs_read.
7155
11997c76
EZ
71562011-04-11 Eli Zaretskii <eliz@gnu.org>
7157
7158 * xdisp.c (redisplay_window): Don't try to determine the character
7159 position of the scroll margin if the window start point w->startp
e896f03c 7160 is outside the buffer's accessible region. (Bug#8468)
11997c76 7161
8a2cbd72
EZ
71622011-04-10 Eli Zaretskii <eliz@gnu.org>
7163
7164 Fix write-region and its subroutines for buffers > 2GB.
7165 * fileio.c (a_write, e_write): Modify declaration of arguments and
7166 local variables to support buffers larger than 2GB.
7167 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7168
7169 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7170 argument, local variables, and return value.
7171
7172 * lisp.h: Update prototypes of emacs_write and emacs_read.
7173
7174 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7175
4073e537 71762011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7177
1ebfdcb6
PE
7178 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7179
b2ded58d
PE
7180 Fix more problems found by GCC 4.6.0's static checks.
7181
7d66342c
PE
7182 * xdisp.c (vmessage): Use a better test for character truncation.
7183
bbf47d44
PE
7184 * charset.c (load_charset_map): <, not <=, for optimization,
7185 and to avoid potential problems with integer overflow.
9248994d 7186 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7187 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7188 * editfns.c (Fformat): Likewise.
1e69125e 7189 * syntax.c (skip_chars): Likewise.
3befa583 7190
e3019616
PE
7191 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7192 This also lets GCC 4.6.0 generate slightly better loop code.
7193
becfa255
PE
7194 * callint.c (Fcall_interactively): <, not <=, for optimization.
7195 (Fcall_interactively): Count the number of arguments produced,
7196 not the number of arguments given. This is simpler and lets GCC
7197 4.6.0 generate slightly better code.
7198
dae0cd48
PE
7199 * ftfont.c: Distingish more carefully between FcChar8 and char.
7200 The previous code passed unsigned char * to a functions like
7201 strlen and xstrcasecmp that expect char *, which does not
7202 conform to the C standard.
7203 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7204 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7205 char * when the C standard requires it.
7206
76032d70
PE
7207 * keyboard.c (read_char): Remove unused var.
7208
eb3f1cc8
PE
7209 * eval.c: Port to Windows vsnprintf (Bug#8435).
7210 Include <limits.h>.
7211 (SIZE_MAX): Define if the headers do not.
7212 (verror): Do not give up if vsnprintf returns a negative count.
7213 Instead, grow the buffer. This ports to Windows vsnprintf, which
7214 does not conform to C99. Problem reported by Eli Zaretskii.
7215 Also, simplify the allocation scheme, by avoiding the need for
7216 calling realloc, and removing the ALLOCATED variable.
7217
70476b54
PE
7218 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7219
12020a9e
PE
7220 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7221 But keep the doprint source code for now, as we might revamp it
7222 and use it again (Bug#8435).
ea6c7ae6
PE
7223 * lisp.h (doprnt): Remove.
7224 * Makefile.in (base_obj): Remove doprnt.o.
7225 * deps.mk (doprnt.o): Remove.
7226
5fdb398c
PE
7227 error: Print 32- and 64-bit integers portably (Bug#8435).
7228 Without this change, on typical 64-bit hosts error ("...%d...", N)
7229 was used to print both 32- and 64-bit integers N, which relied on
7230 undefined behavior.
7231 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7232 New macro.
7233 * lisp.h (error, verror): Mark as printf-like functions.
7234 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7235 Report overflow in size calculations when allocating printf buffer.
7236 Do not truncate output string at its first null byte.
7237 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7238 Truncate the output at a character boundary, since vsnprintf does not
7239 do that.
7240 * charset.c (check_iso_charset_parameter): Convert internal
7241 character to string before calling 'error', since %c now has the
7242 printf meaning.
7243 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7244 overflow when computing char to be passed to 'error'. Do not
7245 pass Lisp_Object to 'error'; pass the integer instead.
7246 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7247 formatted with plain %d.
7248
b189fa66
PE
7249 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7250
bff87ef0
PE
7251 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7252
7e2cac20
PE
7253 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7254
ce4d90b5
PE
7255 * xterm.c (x_catch_errors): Remove duplicate declaration.
7256
266c9547
PE
7257 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7258
79c49ad2
PE
7259 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7260
368f4090
JM
72612011-04-10 Jim Meyering <meyering@redhat.com>
7262
7263 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7264 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7265 return ssize_t not "int", and use size_t as the buffer length.
7266 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7267 * gnutls.h: Update declarations.
7268 * process.c (read_process_output): Use ssize_t, to match.
7269 (send_process): Likewise.
7270
a32d4040
CY
72712011-04-09 Chong Yidong <cyd@stupidchicken.com>
7272
7273 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7274
8546720e 72752011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7276
04f2d78b
CB
7277 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7278 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7279
8546720e
GM
7280 * xterm.c (handle_one_xevent):
7281 * xmenu.c (create_and_show_popup_menu):
7282 * xselect.c (x_decline_selection_request)
7283 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7284
0a2f5c1a 72852011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7286
7287 Fix some uses of `int' instead of EMACS_INT.
7288 * search.c (string_match_1, fast_string_match)
7289 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7290 (scan_buffer, find_next_newline_no_quit)
7291 (find_before_next_newline, search_command, Freplace_match)
7292 (Fmatch_data): Make some `int' variables be EMACS_INT.
7293
7294 * xdisp.c (display_count_lines): 3rd argument and return value now
7295 EMACS_INT. All callers changed.
7296 (pint2hrstr): Last argument is now EMACS_INT.
7297
7298 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7299 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7300 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7301 (decode_coding_utf_16, decode_coding_emacs_mule)
7302 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7303 (decode_coding_ccl, decode_coding_charset)
7304 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7305 (decode_coding_iso_2022, decode_coding_emacs_mule)
7306 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7307 <char_offset, last_offset>: Declare EMACS_INT.
7308 (encode_coding_utf_8, encode_coding_utf_16)
7309 (encode_coding_emacs_mule, encode_invocation_designation)
7310 (encode_designation_at_bol, encode_coding_iso_2022)
7311 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7312 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7313 Declare EMACS_INT.
7314 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7315 (encode_invocation_designation): Last argument P_NCHARS is now
7316 EMACS_INT.
7317 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7318 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7319
7320 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7321 All users changed.
7322
7323 * ccl.c (Fccl_execute_on_string): Declare some variables
7324 EMACS_INT.
7325
8546720e 73262011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7327
7328 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7329
4e19a977
CS
73302011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7331
7332 * process.c (Fformat_network_address): Doc fix.
7333
87302331
R
73342011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7335
ee7683eb 7336 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7337
cbb59342
CY
73382011-04-08 Chong Yidong <cyd@stupidchicken.com>
7339
7340 * keyboard.c (read_char): Call Lisp function help-form-show,
7341 instead of using internal_with_output_to_temp_buffer.
7342 (Qhelp_form_show): New var.
e0d38eeb 7343 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7344
7345 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7346
7347 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7348
e67a13ab
CY
73492011-04-06 Chong Yidong <cyd@stupidchicken.com>
7350
04f2d78b
CB
7351 * process.c (Flist_processes): Remove to Lisp.
7352 (list_processes_1): Delete.
e67a13ab 7353
973f782d
EZ
73542011-04-06 Eli Zaretskii <eliz@gnu.org>
7355
7c106b1e
EZ
7356 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7357
973f782d
EZ
7358 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7359
41cf7d1a 73602011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7361
ca23cc88
PE
7362 Fix more problems found by GCC 4.6.0's static checks.
7363
f390e2d5
PE
7364 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7365
42eea0d0
PE
7366 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7367
b69769da 7368 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7369
f9541e84
PE
7370 * xdisp.c (vmessage): Mark as a printf-like function.
7371
13841b55
PE
7372 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7373
c136c10f
PE
7374 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7375
5e2d4a30
PE
7376 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7377 printf-like functions.
7378 (tiff_load): Add casts to remove these marks before passing them
7379 to system-supplied API.
7380
583f48b9
PE
7381 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7382
b25d760e
PE
7383 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7384 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7385 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7386 directly, rather than having caller test rule sign. This avoids
7387 some unnecessary tests.
7388 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7389 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7390 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7391
bc7b6697 7392 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7393 (xfont_open): Avoid unnecessary tests.
bc7b6697 7394
27ccc379
PE
7395 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7396
dcd5c89a
PE
7397 * composite.h, composite.c (composition_gstring_put_cache):
7398 Use EMACS_INT, not int, for length.
7399
b13a45c6
PE
7400 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7401 breaking out part of COMPOSITION_DECODE_RULE.
7402 (COMPOSITION_DECODE_RULE): Use it.
7403 * composite.c (get_composition_id): Remove unused local vars,
7404 by using the new macro.
7405
1e792e4d
PE
7406 * textprop.c (set_text_properties_1): Change while to do-while,
7407 since the condition is always true at first.
7408
dc6c6455 7409 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7410 (interval_deletion_adjustment): Return unsigned value.
7411 All uses changed.
dc6c6455 7412
aba7731a
PE
7413 * process.c (list_processes_1, create_pty, read_process_output):
7414 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7415 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7416 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7417 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7418 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7419
fdfc4bf3
PE
7420 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7421
fca8fe46 7422 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7423 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7424
06a0259a 7425 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7426 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7427 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7428
e7b9e80f
PE
7429 * print.c (print_error_message): Avoid int overflow.
7430
56201685
PE
7431 * font.c (font_list_entities): Redo for clarity,
7432 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7433
78834453 7434 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7435 (font_score): Avoid potential overflow in diff calculation.
78834453 7436
0bc0b309 7437 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7438 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7439
e610eaca
PE
7440 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7441
b895abce
PE
7442 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7443 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7444 can always succeed if overflow has undefined behavior.
7445
1f1d9321 7446 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7447 (wordify): Omit three unnecessary tests.
1f1d9321 7448
c59478bc
PE
7449 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7450 All callers changed. This avoids the need for an unused var.
7451
79b73827
PE
7452 * casefiddle.c (casify_region): Remove var that is set but not used.
7453
a4db5dfe
PE
7454 * dired.c (file_name_completion): Remove var that is set but not used.
7455
43aae36e
PE
7456 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7457
2a47c44d 7458 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7459 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7460
a37c69bf
PE
7461 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7462 Check for integer overflow on size calculations.
7463
328ab8e7
PE
7464 * buffer.c (Fprevious_overlay_change): Remove var that is set
7465 but not used.
7466
e5a2a5cb
PE
7467 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7468 Remove vars that are set but not used.
8d84a6eb 7469 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7470 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7471
a60e5f68
PE
7472 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7473
f661cb61 7474 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7475 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7476
f0397f5a
PE
7477 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7478 that are set but not used.
7479
8664db06 7480 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7481 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7482
6abdaa4a
PE
7483 * xselect.c (x_get_local_selection, x_handle_property_notify):
7484 Remove vars that are set but not used.
7485
0ce7538d 7486 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7487 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7488
9ae848fc
PE
7489 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7490 Remove var that is set but not used.
0b918413
PE
7491 (scroll_bar_windows_size): Now size_t, not int.
7492 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7493 Check for overflow.
9ae848fc 7494
a5a62657
PE
7495 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7496 (map_tty_color) [!defined MSDOS]: Likewise.
7497
5c5cdd39
PE
7498 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7499
66ebf983
PE
7500 * coding.c: Remove vars that are set but not used.
7501 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7502 All callers changed.
7503 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7504 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7505 (decode_coding_charset): Remove vars that are set but not used.
7506
1be4d761
PE
7507 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7508 that is set but not used.
7509
47553fa8
PE
7510 * print.c (print_object): Remove var that is set but not used.
7511
1f7196bf 7512 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7513 The gnulib version avoids calling malloc in the usual case,
7514 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7515 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7516 * filelock.c (current_lock_owner): Likewise.
7517 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7518 * sysdep.c: Include allocator.h, careadlinkat.h.
7519 (emacs_no_realloc_allocator): New static constant.
7520 (emacs_readlink): New function.
fdb61804
PE
7521 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7522 ../lib/careadlinkat.h.
d1fdcab7 7523
f84c17c7
SM
75242011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7525
7526 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7527 first non-nil return value).
7528
ef3862ad
JD
75292011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7530
7531 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7532 if not defined (Bug#8403).
7533
376a7006
JB
75342011-04-02 Juanma Barranquero <lekktu@gmail.com>
7535
7536 * xdisp.c (display_count_lines): Remove parameter `start',
7537 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7538 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7539 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7540 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7541 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7542 and thereabouts. All callers changed.
7543 (get_per_char_metric): Remove parameter `f', unused since
7544 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7545
6ca3801d
JM
75462011-04-02 Jim Meyering <meyering@redhat.com>
7547
7548 do not dereference NULL upon failed strdup
7549 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7550 (ns_get_family): Likewise.
7551
d8e2b5ba
JB
75522011-04-02 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7555
8c74fcbd
JD
75562011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7557
7558 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7559 later (Bug#8403).
7560
7200d79c
SM
75612011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7562
03408648 7563 Add lexical binding.
7200d79c 7564
03408648
SM
7565 * window.c (Ftemp_output_buffer_show): New fun.
7566 (Fsave_window_excursion):
7567 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7568
7569 * lread.c (lisp_file_lexically_bound_p): New function.
7570 (Fload): Bind Qlexical_binding.
7571 (readevalloop): Remove `evalfun' arg.
7572 Bind Qinternal_interpreter_environment.
7573 (Feval_buffer): Bind Qlexical_binding.
7574 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7575 Mark as dynamic.
7576 (syms_of_lread): Declare `lexical-binding'.
7577
7578 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7579
7580 * keyboard.c (eval_dyn): New fun.
7581 (menu_item_eval_property): Use it.
ca105506
SM
7582
7583 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7584
03408648
SM
7585 * fns.c (concat, mapcar1): Accept byte-code-functions.
7586
7587 * eval.c (Fsetq): Handle lexical vars.
7588 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7589 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7590 (FletX, Flet): Obey lexical binding.
7591 (Fcommandp): Handle closures.
7592 (Feval): New `lexical' arg.
7593 (eval_sub): New function extracted from Feval. Use it almost
7594 everywhere where Feval was used. Look up vars in lexical env.
7595 Handle closures.
7596 (Ffunctionp): Move from subr.el.
7597 (Ffuncall): Handle closures.
7598 (apply_lambda): Remove `eval_flags'.
7599 (funcall_lambda): Handle closures and new byte-code-functions.
7600 (Fspecial_variable_p): New function.
7601 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7602 but without exporting it to Lisp.
23aba0ea 7603
23aba0ea 7604 * doc.c (Fdocumentation, store_function_docstring):
03408648 7605 * data.c (Finteractive_form): Handle closures.
23aba0ea 7606
03408648
SM
7607 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7608 interactive spec.
ba83908c 7609
04f2d78b
CB
7610 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7611 New byte-codes.
03408648
SM
7612 (exec_byte_code): New function extracted from Fbyte_code to handle new
7613 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7614
03408648 7615 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7616
03408648 7617 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7618
e2abce01
JB
76192011-03-31 Juanma Barranquero <lekktu@gmail.com>
7620
7621 * xdisp.c (redisplay_internal): Fix prototype.
7622
63696a73 76232011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7624
63696a73 7625 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7626 (try_scrolling): Use it when setting scroll_limit.
7627 Limit scrolling to 100 screen lines.
63696a73
EZ
7628 (redisplay_window): Even when falling back on "recentering",
7629 position point in the window according to scroll-conservatively,
7630 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7631
7632 (try_scrolling): When point is above the window, allow searching
7633 as far as scroll_max, or one screenful, to compute vertical
7634 distance from PT to the scroll margin position. This prevents
7635 try_scrolling from unnecessarily failing when
7636 scroll-conservatively is set to a value slightly larger than the
7637 window height. Clean up the case of PT below the margin at bottom
7638 of window: scroll_max can no longer be INT_MAX. When aggressive
7639 scrolling is in use, don't let point enter the opposite scroll
7640 margin as result of the scroll.
7641 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7642 threshold of 100 lines for never-recentering scrolling.
7643
e4cc2dfc
JB
76442011-03-31 Juanma Barranquero <lekktu@gmail.com>
7645
7646 * dispextern.h (move_it_by_lines):
7647 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7648 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7649 (message_log_check_duplicate): Remove parameters `prev_bol' and
7650 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7651 (redisplay_internal): Remove parameter `preserve_echo_area',
7652 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7653
7654 * indent.c (Fvertical_motion):
7655 * window.c (window_scroll_pixel_based, Frecenter):
7656 Don't pass `need_y_p' to `move_it_by_lines'.
7657
1c470562
SM
76582011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7659
44f230aa
SM
7660 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7661 steal a few bits to be more compact.
7662 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7663 Remove unneeded casts.
7664
1c470562
SM
7665 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7666
888adce9
ZK
76672011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7668
7669 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7670 binding" message (bug#7967).
7671
f838ed7b
PE
76722011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7673
77861b95
PE
7674 Fix more problems found by GCC 4.6.0's static checks.
7675
de6dbc14
PE
7676 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7677 Remove unused local var.
7678
f838ed7b
PE
7679 * editfns.c (Fmessage_box): Remove unused local var.
7680
792c7b2b
PE
7681 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7682 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7683 Omit unused local vars.
c499e557 7684 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7685 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7686 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7687 Omit unused local var.
7688
ba0165e1
PE
7689 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7690 Don't assume string length fits in int.
32ad8845 7691 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7692 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7693
3c59b4c9
PE
7694 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7695 instead of alloca (Bug#8344).
7696
a3eed478 7697 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7698 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7699
eb4d412d
PE
7700 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7701
1658b401
PE
7702 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7703 concerns.
7704
7705 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7706
7707 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7708
9a2c6e05
PE
7709 * keyboard.c (syms_of_keyboard): Use the same style as later
7710 in this function when indexing through an array. This also
7711 works around GCC bug 48267.
7712
03d0a109
PE
7713 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7714
44f730c8
PE
7715 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7716
fe75f926
PE
7717 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7718 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7719
ffa8c828
PE
7720 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7721 This avoids undefined behavior on integer overflow, and is a bit
7722 more convenient anyway since it is compared to a size_t variable.
7723
c5101a77
PE
7724 Variadic C functions now count arguments with size_t, not int.
7725 This avoids an unnecessary limitation on 64-bit machines, which
7726 caused (substring ...) to crash on large vectors (Bug#8344).
7727 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7728 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7729 All variadic functions and their callers changed accordingly.
c5101a77
PE
7730 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7731 * data.c (arith_driver, float_arith_driver): Likewise.
7732 * editfns.c (general_insert_function): Likewise.
7733 * eval.c (struct backtrace.nargs, interactive_p)
7734 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7735 (funcall_lambda, mark_backtrace): Likewise.
7736 * fns.c (concat): Likewise.
7737 * frame.c (x_set_frame_parameters): Likewise.
7738 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7739 0 if not found, not -1. All callers changed.
7740
dd3f25f7
PE
7741 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7742 (stack_copy_size): Now size_t, not int.
7743 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7744
461c2ab9
JB
77452011-03-28 Juanma Barranquero <lekktu@gmail.com>
7746
7747 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7748 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7749 All callers changed.
7750
7751 * lisp.h (multibyte_char_to_unibyte):
7752 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7753 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7754 * character.h (CHAR_TO_BYTE8):
7755 * cmds.c (internal_self_insert):
7756 * editfns.c (general_insert_function):
7757 * keymap.c (push_key_description):
7758 * search.c (Freplace_match):
7759 * xdisp.c (message_dolog, set_message_1): All callers changed.
7760
f6d62986
SM
77612011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7762
7763 * keyboard.c (safe_run_hook_funcall): New function.
7764 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7765 don't set the hook to nil, but remove the offending function instead.
7766 (Qcommand_hook_internal): Remove, unused.
7767 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7768 Vcommand_hook_internal.
7769
7770 * eval.c (enum run_hooks_condition): Remove.
7771 (funcall_nil, funcall_not): New functions.
7772 (run_hook_with_args): Call each function through a `funcall' argument.
7773 Remove `cond' argument, now redundant.
7774 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7775 (Frun_hook_with_args_until_failure): Adjust accordingly.
7776 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7777
1db5b1ad
JB
77782011-03-28 Juanma Barranquero <lekktu@gmail.com>
7779
7780 * dispextern.h (string_buffer_position): Remove declaration.
7781
7782 * print.c (strout): Remove parameter `multibyte', unused since
7783 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7784
7785 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7786 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7787 All callers changed.
7788
7789 * w32.c (_wsa_errlist): Use braces for struct initializers.
7790
7791 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7792 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7793 All callers changed.
7794 (string_buffer_position): Likewise. Also, make static (it's never
7795 used outside xdisp.c).
7796 (cursor_row_p): Remove parameter `w', unused since
7797 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7798 (decode_mode_spec): Remove parameter `precision', introduced during
7799 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7800 All callers changed.
7801
5ffb62aa
JD
78022011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7803
7804 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7805
461c2ab9 78062011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7807
7808 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7809 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7810 (ns_update_auto_hide_menu_bar): New functions.
7811 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7812 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7813 ns_constrain_all_frames.
7814 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7815 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7816
5c380ffb
JD
78172011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7818
7819 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7820
9af30bdf
GM
78212011-03-27 Glenn Morris <rgm@gnu.org>
7822
7823 * syssignal.h: Replace RETSIGTYPE with void.
7824 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7825 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7826 Replace SIGTYPE with void everywhere.
7827 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7828 * s/template.h (SIGTYPE): Remove commented out definition.
7829
e2abce01
JB
78302011-03-26 Eli Zaretskii <eliz@gnu.org>
7831
7832 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7833 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7834
f868cd8a
JB
78352011-03-26 Juanma Barranquero <lekktu@gmail.com>
7836
59eb0929
JB
7837 * w32.c (read_unc_volume): Use parameter `henum', instead of
7838 global variable `wget_enum_handle'.
7839
7840 * keymap.c (describe_vector): Remove parameters `indices' and
7841 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7842 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7843
f868cd8a
JB
7844 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7845
7846 * keyboard.c (timer_check): Remove parameter `do_it_now',
7847 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7848 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7849 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7850
7851 * keyboard.c (read_char):
7852 * w32menu.c (w32_menu_display_help):
7853 * xmenu.c (show_help_event, menu_help_callback):
7854 Adjust calls to `show_help_echo'.
7855
7856 * gtkutil.c (xg_maybe_add_timer):
7857 * keyboard.c (readable_events):
7858 * process.c (wait_reading_process_output):
7859 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7860
7861 * insdel.c (adjust_markers_gap_motion):
7862 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7863 (gap_left, gap_right): Don't call it.
7864
2ecf6fdb
CY
78652011-03-25 Chong Yidong <cyd@stupidchicken.com>
7866
7867 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7868 incurred during fontification.
7869
6b1f9ba4
JB
78702011-03-25 Juanma Barranquero <lekktu@gmail.com>
7871
7872 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7873 (DEFVAR_PER_BUFFER): Don't pass it.
7874
7875 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7876 (scrolling_window): Don't pass it.
7877
0f4a96b5
JB
78782011-03-25 Juanma Barranquero <lekktu@gmail.com>
7879
7880 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7881
7882 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7883 and `suffix'.
7884 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7885 of variables specific to SELinux and computation of `encoded_absname'.
7886
7887 * image.c (XPutPixel): Remove unused variable `height'.
7888
7889 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7890
7891 * unexw32.c (get_section_info): Remove unused variable `section'.
7892
7893 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7894 (system_process_attributes): Remove unused variable `sess'.
7895 (sys_read): Remove unused variable `err'.
7896
7897 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7898 (w32_wnd_proc): Remove unused variable `isdead'.
7899 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7900 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7901 (x_create_tip_frame): Remove unused variable `tem'.
7902
7903 * w32inevt.c (w32_console_read_socket):
7904 Remove unused variable `no_events'.
7905
7906 * w32term.c (x_draw_composite_glyph_string_foreground):
7907 Remove unused variable `width'.
7908
1149507c
JB
79092011-03-24 Juanma Barranquero <lekktu@gmail.com>
7910
7911 * w32term.c (x_set_glyph_string_clipping):
7912 Don't pass uninitialized region to CombineRgn.
7913
9c88f339
JB
79142011-03-23 Juanma Barranquero <lekktu@gmail.com>
7915
7916 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7917 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7918 (Fx_close_connection): Remove unused variable `i'.
7919
7920 * w32font.c (w32font_draw): Return number of glyphs.
7921 (w32font_open_internal): Remove unused variable `i'.
7922 (w32font_driver): Add missing initializer.
7923
7924 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7925 (fill_in_menu): Remove unused variable `items_added'.
7926
7927 * w32term.c (last_mouse_press_frame): Remove static global variable.
7928 (w32_clip_to_row): Remove unused variable `f'.
7929 (x_delete_terminal): Remove unused variable `i'.
7930
7931 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7932 (NOTHING): Remove unused static global variable.
7933 (uniscribe_check_otf): Remove unused variable `table'.
7934 (uniscribe_font_driver): Add missing initializers.
7935
dee091a3
JD
79362011-03-23 Julien Danjou <julien@danjou.info>
7937
7938 * term.c (Fsuspend_tty, Fresume_tty):
7939 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7940 * window.c (temp_output_buffer_show):
7941 * insdel.c (signal_before_change):
7942 * frame.c (Fhandle_switch_frame):
7943 * fileio.c (Fdo_auto_save):
7944 * emacs.c (Fkill_emacs):
7945 * editfns.c (save_excursion_restore):
7946 * cmds.c (internal_self_insert):
7947 * callint.c (Fcall_interactively):
7948 * buffer.c (Fkill_all_local_variables):
7949 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7950 Use Frun_hooks.
0f4a96b5 7951 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7952 unconditionally since it does the check itself.
dee091a3 7953
2c520ab5 79542011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7955
c9c49752
PE
7956 Fix more problems found by GCC 4.5.2's static checks.
7957
8abc3f12
PE
7958 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7959 the first time through the loop, since we know p0 < p1 then.
7960 This also avoids a gcc -Wstrict-overflow warning.
7961
a2d26660
PE
7962 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7963 leading to a memory leak, possible in functions like
7964 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7965 of objects (Bug#8318).
a2d26660 7966
916c72e9
PE
7967 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7968 that could (at least in theory) be that large.
7969
19ab8a18
PE
7970 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7971 This is less likely to overflow, and avoids undefined behavior if
7972 overflow does occur. All callers changed. Use strtoul to scan
7973 for the unsigned long integer.
b7cbbd6f
PE
7974 (pint2hrstr): Simplify and tune code slightly.
7975 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7976
f0641eff
PE
7977 * scroll.c (do_scrolling): Work around GCC bug 48228.
7978 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7979
7f650bb9
PE
7980 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7981 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7982 (validate_x_resource_name): Simplify count usage.
7983 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7984
37dd57d1
PE
7985 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7986 fail (Bug#8306).
81e56e61 7987
699979fc 7988 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7989
401bf9b4
PE
7990 * process.c (Fmake_network_process): Use socklen_t, not int,
7991 where POSIX says socklen_t is required in portable programs.
7992 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7993 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7994 (Fmake_network_process, server_accept_connection):
7995 (wait_reading_process_output, read_process_output):
7996 Likewise.
7997
b93aacde
PE
7998 * process.c: Rename or move locals to avoid shadowing.
7999 (list_processes_1, Fmake_network_process):
8000 (read_process_output_error_handler, exec_sentinel_error_handler):
8001 Rename or move locals.
4dc343ee 8002 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8003 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8004 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8005 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8006 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8007
af8a867c 8008 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8009 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8010 Include tparam.h instead, since it declares them.
af8a867c
PE
8011 * cm.h (PC): Remove extern decl; tparam.h now does this.
8012 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8013 * terminfo.c: Include tparam.h, to check interfaces.
8014 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8015 (tparam): Adjust signature to match interface in tparam.h;
8016 this removes some undefined behavior. Check that outstring and len
8017 are zero, which they always are with Emacs.
8018 * tparam.h (PC, BC, UP): New extern decls.
8019
0248044d 8020 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8021 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8022
8ff096c1 8023 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8024 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8025 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8026 (ftfont_list): Remove unused local.
49eaafba
PE
8027 (get_adstyle_property, ftfont_pattern_entity):
8028 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8029 Rename locals to avoid shadowing.
8ff096c1 8030
e2be39f6
PE
8031 * xfont.c (xfont_list_family): Mark var as initialized.
8032
c9735e30
PE
8033 * xml.c (make_dom): Now static.
8034
8f5201ae
PE
8035 * composite.c (composition_compute_stop_pos): Rename local to
8036 avoid shadowing.
b246f932
PE
8037 (composition_reseat_it): Remove unused locals.
8038 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8039 (composition_update_it): Mark var as initialized.
11b61122
PE
8040 (find_automatic_composition): Mark vars as initialized,
8041 with a FIXME (Bug#8290).
8f5201ae 8042
760fbc2c
PE
8043 character.h: Rename locals to avoid shadowing.
8044 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8045 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8046 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8047 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8048 to avoid shadowing.
8049
ff08eb85
PE
8050 * textprop.c (property_change_between_p): Remove; unused.
8051
fc7bf025
PE
8052 * intervals.c (interval_start_pos): Now static.
8053
235d7abc
PE
8054 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8055
44f230aa
SM
8056 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8057 Rename locals to avoid shadowing.
3e7d6594 8058
50060332
PE
8059 * sound.c (wav_play, au_play, Fplay_sound_internal):
8060 Fix pointer signedness.
d01f234b 8061 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8062 (wav_play): Initialize a variable to 0, to prevent undefined
8063 behavior (Bug#8278).
50060332 8064
c4fc4e30
PE
8065 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8066
918436ed
PE
8067 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8068
c939f91b
PE
8069 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8070 clobbering (Bug#8298).
b9c7f648
PE
8071 * sysdep.c (sys_subshell): Likewise.
8072 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8073
6bd8c144
PE
8074 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8075 This should get cleaned up, so that child_setup has the
8076 same signature on all platforms.
8077
7710357c 8078 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8079 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8080
c59da222
CY
80812011-03-22 Chong Yidong <cyd@stupidchicken.com>
8082
8083 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8084 not to be necessary, and produces flickering.
8085
66b87493
GM
80862011-03-20 Glenn Morris <rgm@gnu.org>
8087
8088 * config.in: Remove file.
8089
45b6f6d5
JB
80902011-03-20 Juanma Barranquero <lekktu@gmail.com>
8091
8092 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8093 are now in src/globals.h.
8094 (syms_of_minibuf): Remove spurious & from previous change.
8095
3ec03f7e
LL
80962011-03-20 Leo <sdl.web@gmail.com>
8097
8098 * minibuf.c (completing-read-function): New variable.
8099 (completing-read-default): Rename from completing-read.
8100 (completing-read): Call completing-read-function.
8101
b14e3e21
CY
81022011-03-19 Juanma Barranquero <lekktu@gmail.com>
8103
8104 * xfaces.c (Fx_load_color_file):
8105 Read color file from absolute filename (bug#8250).
8106
f2b726e6
JB
81072011-03-19 Juanma Barranquero <lekktu@gmail.com>
8108
8109 * makefile.w32-in: Update dependencies.
8110
09f6ff02
EZ
81112011-03-17 Eli Zaretskii <eliz@gnu.org>
8112
8113 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8114
29a6015a
PE
81152011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8116
a3a6c54e
PE
8117 Fix more problems found by GCC 4.5.2's static checks.
8118
b766f867
PE
8119 * process.c (make_serial_process_unwind, send_process_trap):
8120 (sigchld_handler): Now static.
8121
be02381c
PE
8122 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8123 That way, the code declares only the vars that it needs.
8124 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8125 * s/cygwin.h (PTY_ITERATION): Likewise.
8126 * s/darwin.h (PTY_ITERATION): Likewise.
8127 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8128
57048744
PE
8129 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8130 * process.c (allocate_pty): Don't declare stb unless it's needed.
8131
7914961c 8132 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8133 (CONSTANTLIM): Remove; unused.
8134 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8135 Define only if needed.
7914961c 8136
b3967b18
PE
8137 * unexelf.c (unexec): Name an expression,
8138 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8139 Use a different way to cause a compilation error if anyone uses
8140 n rather than nn, a way that does not involve shadowing.
73366a00 8141 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8142
29a6015a
PE
8143 * deps.mk (unexalpha.o): Remove; unused.
8144
43cfc33e 8145 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8146 * unexec.h: New file.
ce701a33
PE
8147 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8148 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8149 Depend on unexec.h.
8150 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8151 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8152 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8153 Change as necessary to match prototype in unexec.h.
ce701a33 8154
01f44d5a
PE
8155 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8156 shadowing.
4f63c6bb 8157 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8158
a6670b0b
PE
8159 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8160 Rename locals to avoid shadowing.
8161
cef2010d 8162 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8163 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8164
d4d7173a
PE
8165 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8166
f08b802a
PE
8167 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8168 warning when compiling print.c.
8169
3ddb0639
PE
8170 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8171 instead of using an uninitialized var.
5ad03b97 8172 (font_sort_entities): Mark var as initialized.
3ddb0639 8173
170a2692
PE
8174 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8175
e663c700
PE
8176 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8177 pointers to constants.
89bc529a 8178 (font_parse_fcname): Remove unused vars.
7b81e2d0 8179 (font_delete_unmatched): Now static.
ea838e10 8180 (font_get_spec): Remove; unused.
13a547c6
PE
8181 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8182 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8183 Rename or move locals to avoid shadowing.
e663c700 8184
2a80c887 8185 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8186 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8187
1384fa33 8188 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8189 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8190
8b2c52e9
PE
8191 * alloc.c (mark_backtrace): Move decl from here ...
8192 * lisp.h: ... to here, so that it can be checked.
8193
475545b5 8194 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8195 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8196 (lisp_indirect_variable): Name an expression,
8197 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8198 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8199
b1349114 8200 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8201 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8202 Use const pointer when appropriate.
b1349114 8203
a2928364
PE
8204 * lisp.h (get_system_name, get_operating_system_release):
8205 Move decls here, to check interfaces.
8206 * process.c (get_operating_system_release): Move decl to lisp.h.
8207 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8208 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8209 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8210 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8211 (Fformat_time_string, Fencode_time, Finsert_char):
8212 (Ftranslate_region_internal, Fformat):
8213 Rename or remove local vars to avoid shadowing.
9710023e 8214 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8215
a415e694
PE
8216 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8217 avoid shadowing.
8218
8ef4622d
PE
8219 * lisp.h (eassert): Check that the argument compiles, even if
8220 ENABLE_CHECKING is not defined.
8221
946f9a5b
PE
8222 * data.c (Findirect_variable): Name an expression, to avoid
8223 gcc -Wbad-function-cast warning.
112396d6 8224 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8225 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8226 (Fmake_variable_buffer_local, Fmake_local_variable):
8227 Mark variables as initialized.
52746918 8228 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8229
e5aab7e7 8230 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8231 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8232 Rename locals to avoid shadowing.
dff45157
PE
8233 (mark_stack): Move local variables into the #ifdef region where
8234 they're used.
7bc26fdb
PE
8235 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8236 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8237 needed otherwise.
8238 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8239 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8240 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8241
e5aab7e7
PE
8242 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8243 avoids undefined behavior in theory.
8244
4da60324
PE
8245 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8246
88043301
PE
8247 Use functions, not macros, for up- and down-casing (Bug#8254).
8248 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8249 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8250 to use the following functions instead of these macros.
8251 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8252 EMACS_INT, since callers assume the returned value fits in int.
8253 (upcase1): Likewise, for UPCASE_TABLE.
8254 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8255 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8256 the race-condition problem in the old DOWNCASE.
88043301 8257
19ed5445
PE
8258 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8259 Rename locals to avoid shadowing.
8260 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8261 (regex_compile, re_search_2, re_match_2_internal):
8262 Remove unused local vars.
952db0d7
PE
8263 (FREE_VAR): Rewrite so as not to use empty "else",
8264 which gcc can warn about.
da053e48 8265 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8266 (RETALLOC_IF): Define only if needed.
8267 (WORDCHAR_P): Likewise. This one is never needed, but is used
8268 only in a comment talking about a compiler bug, so put inside
8269 the #if 0 of that comment.
8270 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8271 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8272 Remove; unused.
19ed5445 8273
1f3561e4 8274 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8275 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8276 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8277
ded6f8f7
PE
8278 * search.c (simple_search): Remove unused var.
8279
dbd37a95
PE
8280 * dired.c (compile_pattern): Move decl from here ...
8281 * lisp.h: ... to here, so that it can be checked.
8282 (struct re_registers): New forward decl.
8283
7e47afad
PE
8284 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8285
85f24f61
PE
8286 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8287 All uses changed.
8288 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8289 Rename locals to avoid shadowing.
5671df8f 8290 (Fvertical_motion): Mark locals as initialized.
85f24f61 8291
181aa2be 8292 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8293 (casify_region): Mark local as initialized.
181aa2be 8294
930d429c
PE
8295 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8296
7082eac6
PE
8297 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8298 New macros, so that the caller can use some names other than
8299 gcpro1, gcpro2, etc.
8300 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8301 of the new macros.
8302 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8303 argument, for consistency with GCPRO2_VAR, etc: it is now the
8304 prefix of the variable, not the variable itself. All uses
8305 changed.
38b2c076
PE
8306 * dired.c (directory_files_internal, file_name_completion):
8307 Rename locals to avoid shadowing.
8308
15206ed9
PE
8309 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8310 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8311 dired.c's scmp function, had undefined behavior.
8312 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8313 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8314 * buffer.h: ... to here, because these macros use current_buffer,
8315 and the new implementation with inline functions needs to have
8316 current_buffer in scope now, rather than later when the macros
8317 are used.
8318 (downcase, upcase1): New static inline functions.
8319 (DOWNCASE, UPCASE1): Reimplement using these functions.
8320 This avoids undefined behavior in expressions like
8321 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8322 from race conditions in accessing the global variables
8323 case_temp1 and case_temp2.
8324 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8325 * lisp.h (case_temp1, case_temp2): Remove their decls.
8326 * character.h (ASCII_CHAR_P): Move from here ...
8327 * lisp.h: ... to here, so that the inline functions mentioned
8328 above can use them.
8329
4a6bea26
PE
8330 * dired.c (directory_files_internal_unwind): Now static.
8331
f14b7e14
PE
8332 * fileio.c (file_name_as_directory, directory_file_name):
8333 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8334 Now static.
2893f146
PE
8335 (file_name_as_directory): Use const pointers when appropriate.
8336 (Fexpand_file_name): Likewise. In particular, newdir might
8337 point at constant storage, so make it a const pointer.
fd4ead52 8338 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8339 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8340 signedness issues.
f839df0c
PE
8341 (Fset_file_times, Finsert_file_contents, auto_save_error):
8342 Rename locals to avoid shadowing.
f14b7e14 8343
5716756e 8344 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8345 (Ftry_completion, Fall_completions): Rename or remove locals
8346 to avoid shadowing.
5716756e 8347
b4c3046a
PE
8348 * marker.c (bytepos_to_charpos): Remove; unused.
8349
b45db522
PE
8350 * lisp.h (verify_bytepos, count_markers): New decls,
8351 so that gcc does not warn that these functions aren't declared.
8352
85876d07
PE
8353 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8354 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8355 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8356 (copy_text): Remove unused local var.
85876d07 8357
03d78a21 8358 * filelock.c (within_one_second): Now static.
b3dd38ab 8359 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8360
5df8f01b
PE
8361 * buffer.c (fix_overlays_before): Mark locals as initialized.
8362 (fix_start_end_in_overlays): Likewise. This function should be
8363 simplified by using pointers-to-pointers, but that's a different
8364 matter.
b1d876f1 8365 (switch_to_buffer_1): Now static.
8f54f30a
PE
8366 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8367 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8368
a70072c9 8369 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8370 Fix pointer signedness issue.
edced198
PE
8371 (sys_subshell): Mark local as volatile if checking for lint,
8372 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8373 (MAXPATHLEN): Define only if needed.
a70072c9 8374
a0977c44
PE
8375 * process.c (serial_open, serial_configure): Move decls from here ...
8376 * systty.h: ... to here, so that they can be checked.
8377
a884fdcc
PE
8378 * fns.c (get_random, seed_random): Move extern decls from here ...
8379 * lisp.h: ... to here, so that they can be checked.
8380
604efe86 8381 * sysdep.c (reset_io): Now static.
b8950c94 8382 (wait_for_termination_signal): Remove; unused.
604efe86 8383
38fc62d9
PE
8384 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8385 (copy_keymap_item, append_key, push_text_char_description):
8386 Now static.
1004a21a 8387 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8388 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8389 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8390 (describe_map_tree):
8391 Rename locals to avoid shadowing.
38fc62d9 8392
2f2650da
PE
8393 * keyboard.c: Declare functions static if they are not used elsewhere.
8394 (echo_char, echo_dash, cmd_error, top_level_2):
8395 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8396 (read_char, kbd_buffer_get_event, make_lispy_position):
8397 (make_lispy_event, make_lispy_movement, apply_modifiers):
8398 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8399 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8400 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8401 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8402 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8403
a053e86c 8404 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8405 (mark_kboards): Move decl here ...
8406 * alloc.c (mark_kboards): ... from here.
a053e86c 8407
4752793e
PE
8408 * lisp.h (force_auto_save_soon): New decl.
8409
74f10ca7 8410 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8411 (DEFINE_DUMMY_FUNCTION): New macro.
8412 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8413 Use it.
c03cd23f
PE
8414 (main): Add casts to avoid warnings
8415 if GCC considers string literals to be constants.
74f10ca7 8416
022e70d4
PE
8417 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8418
59d6fe83
PE
8419 * dbusbind.c: Pointer signedness fixes.
8420 (xd_signature, xd_append_arg, xd_initialize):
8421 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8422 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8423 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8424 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8425
78320123
PE
8426 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8427 if GCC considers string literals to be constants.
49cebcca 8428 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8429
35ac2a97
SM
84302011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8431
fb103ca9
SM
8432 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8433 (print_preprocess, print_object): New macro to fix last change.
8434
35ac2a97
SM
8435 * print.c (print_preprocess): Don't forget font objects.
8436
62973b41
JB
84372011-03-16 Juanma Barranquero <lekktu@gmail.com>
8438
8439 * emacs.c (USAGE3): Doc fixes.
8440
0e48bb22
AS
84412011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8442
8443 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8444 structure.
8445
7684e57b
JB
84462011-03-14 Juanma Barranquero <lekktu@gmail.com>
8447
8448 * lisp.h (VWindow_system, Qfile_name_history):
8449 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8450 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8451 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8452
8453 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8454 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8455
8456 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8457 * w32console.c (detect_input_pending, read_input_pending)
8458 (encode_terminal_code):
8459 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8460 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8461 (w32_system_caret_y, Qfile_name_history):
8462 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8463 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8464 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8465 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8466 * w32proc.c (Qlocal, report_file_error):
8467 * w32term.c (Vwindow_system, updating_frame):
8468 * w32uniscribe.c (initialized, uniscribe_font_driver):
8469 Remove unneeded extern declarations.
8470
2aa46d6c
CY
84712011-03-14 Chong Yidong <cyd@stupidchicken.com>
8472
c96bbc66 8473 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8474
cffc6f3b
CY
84752011-03-13 Chong Yidong <cyd@stupidchicken.com>
8476
8477 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8478 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8479 These macros can no longer be used for assignment.
8480
44f230aa
SM
8481 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8482 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8483 (record_buffer_markers, fetch_buffer_markers): New functions for
8484 recording and fetching special buffer markers.
8485 (set_buffer_internal_1, set_buffer_temp): Use them.
8486
8487 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8488
8489 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8490
8491 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8492 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8493
8494 * xdisp.c (hscroll_window_tree):
8495 (reconsider_clip_changes): Use PT instead of BUF_PT.
8496
d251f04b
EZ
84972011-03-13 Eli Zaretskii <eliz@gnu.org>
8498
8499 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8500 $(EMACS_ROOT)/lib/intprops.h.
8501
f0c77cd1
PE
85022011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8503
3eca4629
PE
8504 Fix more problems found by GCC 4.5.2's static checks.
8505
7c86ee98
PE
8506 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8507 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8508 (xg_free_frame_widgets): Make it clear that a local variable is
8509 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8510 (gdk_window_get_screen): Make it clear that this macro is needed
8511 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8512 (int_gtk_range_get_value): New function, which avoids a diagnostic
8513 from gcc -Wbad-function-cast.
8514 (xg_set_toolkit_scroll_bar_thumb): Use it.
8515 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8516 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8517 (get_utf8_string, xg_get_file_with_chooser):
8518 Rename locals to avoid shadowing.
8519 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8520
41729b81
PE
8521 * xgselect.c (xg_select): Remove unused var.
8522
f0c77cd1
PE
8523 * image.c (four_corners_best): Mark locals as initialized.
8524 (gif_load): Initialize transparent_p to zero (Bug#8238).
8525 Mark another local as initialized.
ec6cf4c6 8526 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8527
ce0ad53d 8528 * image.c (clear_image_cache): Now static.
d5d5a617 8529 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8530 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8531 (x_edge_detection): Remove unnecessary cast that
8532 gcc -Wbad-function-cast diagnoses.
2037898d 8533 (gif_load): Fix pointer signedness.
6ae141d6
PE
8534 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8535 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8536
33383987 85372011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8538
d32df629
PE
8539 Improve quality of tests for time stamp overflow.
8540 For example, without this patch (encode-time 0 0 0 1 1
8541 1152921504606846976) returns the obviously-bogus value (-948597
8542 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8543 reports time overflow. See
8544 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8545 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8546 * editfns.c: Include limits.h and intprops.h.
8547 (TIME_T_MIN, TIME_T_MAX): New macros.
8548 (time_overflow): Move earlier, to before first use.
8549 (hi_time, lo_time): New functions, for an accurate test for
8550 out-of-range times.
8551 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8552 (Fget_internal_run_time): Don't assume time_t fits in int.
8553 (make_time): Use list2 instead of Fcons twice.
8554 (Fdecode_time): More accurate test for out-of-range times.
8555 (check_tm_member): New function.
8556 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8557 (lisp_time_argument): Don't rely on undefined left-shift and
8558 right-shift behavior when checking for time stamp overflow.
8be6f318 8559
fe31d94c
PE
8560 * editfns.c (time_overflow): New function, refactoring common code.
8561 (Fformat_time_string, Fdecode_time, Fencode_time):
8562 (Fcurrent_time_string): Use it.
8563
8be6f318
PE
8564 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8565 * dired.c (make_time): Move to ...
8566 * editfns.c (make_time): ... here.
8567 * systime.h: Note the move.
8568
09d9db2c 85692011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8570
126bc0dc
YM
8571 * fringe.c (update_window_fringes): Remove unused variables.
8572
c47cbdfd
YM
8573 * unexmacosx.c (copy_data_segment): Also copy __got section.
8574 (Bug#8223)
8575
7ac80be9
EZ
85762011-03-12 Eli Zaretskii <eliz@gnu.org>
8577
c96bbc66 8578 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8579 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8580 Constify `char *' arguments and their references according to
8581 prototypes in tparam.h.
8582
ecb0f94d 8583 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8584
7ac80be9
EZ
8585 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8586 Adapt all references accordingly.
8587
8588 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8589
ef1fd07e
TT
85902011-03-11 Tom Tromey <tromey@redhat.com>
8591
8592 * buffer.c (syms_of_buffer): Remove obsolete comment.
8593
7ef4b50c
EZ
85942011-03-11 Eli Zaretskii <eliz@gnu.org>
8595
8596 * termhooks.h (encode_terminal_code): Declare prototype.
8597
8598 * msdos.c (encode_terminal_code): Don't declare prototype.
8599
8600 * term.c (encode_terminal_code): Now external again, used by
8601 w32console.c and msdos.c.
8602
44f230aa
SM
8603 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8604 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8605
4b1ec863 86062011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8607
1714f52b 8608 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8609
4b1ec863
PE
8610 * fringe.c (update_window_fringes): Mark locals as initialized
8611 (Bug#8227).
8612 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8613
524c7aa6
PE
8614 * alloc.c (mark_fringe_data): Move decl from here ...
8615 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8616 to check its interface.
8617 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8618
a5c0af81 8619 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8620 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8621 (fontset_font): Mark local as initialized.
a9a06e0b 8622 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8623
b4716021
PE
8624 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8625
811e9bac 8626 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8627 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8628 (x_own_selection, Fx_disown_selection_internal): Rename locals
8629 to avoid shadowing.
8630 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8631
7e3ab302
PE
8632 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8633 so that the caller can use some name other than gcpro1.
8634 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8635 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8636 (Fx_backspace_delete_keys_p):
8637 Use them to avoid shadowing, and rename vars to avoid shadowing.
8638 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8639 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8640 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8641 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8642 Remove unused locals.
7e3ab302
PE
8643 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8644 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8645 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8646 macros.
f78faa98 8647
e2b13473
PE
8648 * xterm.h (x_mouse_leave): New decl.
8649
77f23912
PE
8650 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8651 Remove unused functions.
cdf4ba58
PE
8652 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8653 (x_calc_absolute_position): Now static.
7411c686 8654 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8655 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8656 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8657 unless they are used.
38d0b34a
PE
8658 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8659 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8660 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8661 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8662 (x_error_catcher, x_connection_closed, x_error_handler):
8663 (x_error_quitter, xembed_send_message, x_iconify_frame):
8664 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8665 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8666 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8667
44f230aa
SM
8668 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8669 Rename or move locals to avoid shadowing.
6b463e58 8670 (tty_defined_color, merge_face_heights): Now static.
5967d051 8671 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8672 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8673 does not deduce is never used uninitialized.
73719eba
PE
8674 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8675 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8676
426994c3 8677 * terminal.c (store_terminal_param): Now static.
5489860b 8678
032f1620 8679 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8680 (set_frame_menubar): Remove unused local.
d4323972 8681 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8682 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8683 since they might point to immutable storage.
281585b0
PE
8684 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8685 since it's unused otherwise.
032f1620 8686
367c19e5 8687 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8688 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8689 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8690 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8691 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8692 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8693 does not deduce are never used uninitialized.
70739cbe 8694
07b48fa9
PE
8695 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8696
8868a238 8697 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8698 * window.c (window_loop, size_window):
8699 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8700
7e5cf297 8701 * window.c (display_buffer): Now static.
d6550a9f
PE
8702 (size_window): Mark variables that gcc -Wuninitialized
8703 does not deduce are never used uninitialized.
a586633d
PE
8704 * window.h (check_all_windows): New decl, to forestall
8705 gcc -Wmissing-prototypes diagnostic.
5b555da1 8706 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8707
f6095868
PE
8708 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8709 shadowing.
8710 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8711 Include <limits.h>.
8712 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8713 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8714 (load_charset_map): Mark variables that gcc -Wuninitialized
8715 does not deduce are never used uninitialized.
53df7c11 8716 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8717
f38b440c
PE
8718 * coding.c (coding_set_source, coding_set_destination):
8719 Use "else { /* comment */ }" rather than "else /* comment */;"
8720 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8721 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8722 a block, when the outer 'i' will do.
8723 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8724 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8725 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8726 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8727 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8728 Rename locals to avoid shadowing.
8729 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8730 * coding.c (emacs_mule_char, encode_invocation_designation):
8731 Now static, since they're not used elsewhere.
413bb2db 8732 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8733 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8734 (decode_coding_emacs_mule): Mark variables that gcc
8735 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8736 (detect_coding_iso_2022): Initialize a local variable that might
8737 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8738 this initialization is needed. (Bug#8211)
5f58e762
PE
8739 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8740 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8741 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8742 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8743 Remove unused macros.
f38b440c 8744
232b38b9 8745 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8746 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8747 * character.c (string_count_byte8): Likewise.
232b38b9 8748
fb90da1b
PE
8749 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8750 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8751
fb93dbc2
PE
8752 * chartab.c (copy_sub_char_table): Now static, since it's not used
8753 elsewhere.
5c156ace
PE
8754 (sub_char_table_ref_and_range, char_table_ref_and_range):
8755 Rename locals to avoid shadowing.
bbcd0949 8756 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8757
7d3b3862 8758 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8759 (BIDI_BOB): Remove unused macro.
7d3b3862 8760
6be7d3da
PE
8761 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8762 deduce are never used uninitialized.
c2ed9c8b 8763 * term.c (encode_terminal_code): Likewise.
6be7d3da 8764
75f8807f 8765 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8766
50938595
PE
8767 * tparam.h: New file.
8768 * term.c, tparam.h: Include it.
8769 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8770 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8771 Move these decls to tparam.h, and make them agree with what
8772 is actually in tparam.c. The previous trick of using incompatible
8773 decls in different modules does not conform to the C standard.
8774 All callers of tparam changed to use tparam's actual API.
8775 * tparam.c (tparam1, tparam, tgoto):
8776 Use const pointers where appropriate.
8777
fbceeba2
PE
8778 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8779 * cm.h (struct cm): Likewise.
8780 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8781 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8782 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8783 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8784 (turn_on_face, init_tty): Likewise.
8785 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8786
7f3f1250
PE
8787 * term.c (term_mouse_position): Rename local to avoid shadowing.
8788
e6ca6543
PE
8789 * alloc.c (mark_ttys): Move decl from here ...
8790 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8791
c40f8d15
AS
87922011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8793
8794 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8795
cfe0661d
JB
87962011-03-09 Juanma Barranquero <lekktu@gmail.com>
8797
8798 * search.c (compile_pattern_1): Remove argument regp, unused since
8799 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8800 (compile_pattern): Don't pass it.
8801
0afb4571
J
88022011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8803
8804 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8805 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8806 for ! HAVE_GTK3.
8807 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8808
8809 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8810
8811 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8812 gdk_window_get_screen, gdk_window_get_geometry,
8813 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8814 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8815 (xg_get_pixbuf_from_pixmap): New function.
8816 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8817 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8818 Call xg_get_pixbuf_from_pixmap instead of
8819 gdk_pixbuf_get_from_drawable.
8820 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8821 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8822 (xg_check_special_colors): Use GtkStyleContext and its functions
8823 for HAVE_GTK3.
8824 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8825 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8826 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8827 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8828 Call gtk_widget_get_preferred_size.
0afb4571
J
8829 (xg_frame_resized): gdk_window_get_geometry only takes 5
8830 parameters.
44f230aa
SM
8831 (xg_win_to_widget, xg_event_is_for_menubar):
8832 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8833 (xg_set_widget_bg): New function.
8834 (delete_cb): New function.
895009e1 8835 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8836 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8837 (xg_set_background_color): Call xg_set_widget_bg.
8838 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8839 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8840 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8841 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8842 if ! HAVE_GTK3.
8843 (update_frame_tool_bar): Call gtk_widget_hide.
8844 (xg_initialize): Use GDK_KEY_g.
8845
8846 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8847 if ! HAVE_GTK3
8848 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8849
8850 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8851 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8852 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8853
1c2cc4ef
JB
88542011-03-08 Juanma Barranquero <lekktu@gmail.com>
8855
8856 * w32xfns.c (select_palette): Check success of RealizePalette against
8857 GDI_ERROR, not zero.
8858
33383987 8859See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8860
8861;; Local Variables:
8862;; coding: utf-8
aac0c6e3
MR
8863;; End:
8864
33383987 8865 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8866
8867 This file is part of GNU Emacs.
8868
8869 GNU Emacs is free software: you can redistribute it and/or modify
8870 it under the terms of the GNU General Public License as published by
8871 the Free Software Foundation, either version 3 of the License, or
8872 (at your option) any later version.
8873
8874 GNU Emacs is distributed in the hope that it will be useful,
8875 but WITHOUT ANY WARRANTY; without even the implied warranty of
8876 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8877 GNU General Public License for more details.
8878
8879 You should have received a copy of the GNU General Public License
8880 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.