Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e8a02204
EZ
12012-06-23 Eli Zaretskii <eliz@gnu.org>
2
388cdec0
EZ
3 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4 * w32.c (fdutimens): New function.
5
6 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
7
8 * s/ms-w32.h (pselect): Redirect to sys_select.
9
10 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
11
e8a02204
EZ
12 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
13 in the logic of incrementing and decrementing the value of
14 use_relocatable_buffers.
15
d054f3fb
PE
162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
17
18 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
19 Privately reported by Herbert J. Skuhra.
20 [__FreeBSD__]: Remove "*/" typo after "#include".
21 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
22 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
23 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
24 Don't assume EMACS_TIME and struct timeval are the same type.
25
d35af63c
PE
262012-06-22 Paul Eggert <eggert@cs.ucla.edu>
27
28 Support higher-resolution time stamps (Bug#9000).
29 The time stamps are only nanosecond-resolution at the C level,
30 since that's the best that any real-world system supports now.
31 But they are picosecond-resolution at the Lisp level, as that's
32 easy, and leaves room for future OS improvements.
33
34 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
35 (LIBES): Use it.
36
37 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
38 Don't get current time unless it's needed.
39
40 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
41 now provides it if it's absent.
42 (start_atimer): Port to higher-res time stamps.
43 Check for time stamp overflow. Don't get current time more
44 often than is needed.
45
46 * buffer.h (struct buffer): Buffer modtime now has high resolution.
47 Include systime.h, not time.h.
48 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
49
50 * dired.c: Include stat-time.h.
51 (Ffile-attributes): File times now have higher resolution.
52
53 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
54 (struct image): Timestamp now has higher resolution.
55
56 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
57 has at least microseconds now. All uses removed.
58 (update_frame, update_single_window, update_window, update_frame_1)
59 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
60
61 * editfns.c (time_overflow): Now extern.
62 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
63 (float-time, Fformat_time_string, Fcurrent_time_string)
64 (Fcurrent_time_zone): Accept and generate higher-resolution
65 time stamps.
66 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
67 (decode_time_components, lisp_seconds_argument): New functions.
68 (make_time): Now static.
69 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
70 Report an error if the time is invalid, rather than having the caller
71 do that.
72
73 * fileio.c: Include <stat-time.h>
74 (Fcopy_file): Copy higher-resolution time stamps.
75 Prefer to set the time stamp via a file descriptor if that works.
76 (Fset_file_times, Finsert_file_contents, Fwrite_region)
77 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
78 (Fvisited_file_modtime, Fset_visited_file_modtime):
79 Support higher-resolution time stamps.
80
81 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
82
83 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
84
85 * image.c (prepare_image_for_display, clear_image_cache)
86 (lookup_image): Port to higer-resolution time stamps.
87
88 * keyboard.c (start_polling, bind_polling_period):
89 Check for time stamp overflow.
90 (read_char, kbd_buffer_get_event, timer_start_idle)
91 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
92 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
93 Port to higher-resolution time stamps. Do not assume time_t is signed.
94 (decode_timer): New function. Timers are now vectors of length 9,
95 not 8, to accommodate the picosecond component.
96 (timer_check_2): Use it.
97
98 * nsterm.m (select_timeout, timeval_subtract): Remove.
99 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
100 as they're a bit more accurate and handle overflow better.
101 (ns_select): Change prototype to be compatible with pselect.
102 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
103 * nsterm.h (ns_select): Adjust prototype.
104
105 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
106 us-resolution time stamps.
107 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
108
109 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
110
111 * lisp.h (time_overflow): New decl.
112 (wait_reading_process_output): First arg is now intmax_t, not int,
113 to accommodate larger waits.
114
115 * process.h (struct Lisp_Process.read_output_delay):
116 Now counts nanoseconds, not microseconds.
117 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
118 EMACS_HAS_USECS.
119 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
120 (wait_reading_process_output):
121 Port to ns-resolution time stamps.
122 (Faccept_process_output, wait_reading_process_output):
123 Check for time stamp overflow. Do not assume time_t is signed.
124 (select_wrapper): Remove; we now use pselect.
125 (Fprocess_attributes): Now generates ns-resolution time stamps.
126
127 * sysdep.c: Include utimens.h. Don't include utime.h
128 or worry about struct utimbuf; gnulib does that for us now.
129 (gettimeofday): Remove; gnulib provides a substitute.
130 (make_timeval): New function.
131 (set_file_times): Now sets ns-resolution time stamps.
132 New arg FD; all uses changed.
133 (time_from_jiffies, ltime_from_jiffies, get_up_time)
134 (system_process_attributes):
135 Now returns ns-resolution time stamp. All uses changed.
136 Check for time stamp overflow.
137
138 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
139 provides a substitute now.
140
141 * systime.h: Include timespec.h rather than sys/time.h and time.h,
142 since it guarantees struct timespec.
143 (EMACS_TIME): Now struct timespec, so that we can support
144 ns-resolution time stamps.
145 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
146 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
147 (EMACS_USECS): Remove.
148 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
149 so multiply the arg by 1000 before storing it.
150 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
151 New macros.
152 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
153 Port to ns-resolution time stamps.
154 (EMACS_TIME_NEG_P): Remove; replaced by....
155 (EMACS_TIME_SIGN): New macro.
156 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
157 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
158 (set_file_times, make_time, lisp_time_argument): Adjust signature.
159 (make_timeval, make_lisp_time, decode_time_components): New decls.
160 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
161 that it mishandled time_t overflow. You can't compare by subtracting!
162 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
163 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
164
165 * term.c: Include <sys/time.h>.
166 (timeval_to_Time): New function, for proper overflow wraparound.
167 (term_mouse_position, term_mouse_click): Use it.
168
169 * undo.c (record_first_change): Support higher-resolution time stamps
170 in the undo buffer.
171 (Fprimitive_undo): Use them when restoring time stamps.
172
173 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
174 (w32_get_internal_run_time):
175 Port to higher-resolution Emacs time stamps.
176 (ltime): Now accepts single 64-bit integer, as that's more convenient
177 for callers.
178
179 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
180
181 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
182 for compatibility with pselect. Support ns-resolution time stamps.
183
184 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
185
186 * xselect.c (wait_for_property_change, x_get_foreign_selection):
187 Check for time stamp overflow, and support ns-resolution time stamps.
188
189 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
190 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
191 (timeval_subtract): Remove; no longer needed.
192 (XTflash, XTring_bell, x_wait_for_event):
193 Port to ns-resolution time stamps. Don't assume time_t is signed.
194
b6a92dfe
CY
1952012-06-22 Chong Yidong <cyd@gnu.org>
196
197 * xdisp.c (x_consider_frame_title): Revert last change.
198
d251c37c
EZ
1992012-06-22 Eli Zaretskii <eliz@gnu.org>
200
201 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
202 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
203 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
204 staticidx goes up to 1597 out of 1600 = 0x640.)
205
f10deafb
PE
2062012-06-20 Paul Eggert <eggert@cs.ucla.edu>
207
208 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
209 Otherwise, the umask might be mistakenly 0 while handling input signals.
210
ec6de1e2
SM
2112012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
212
213 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
214
28be1ada
DA
2152012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
216
217 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
218 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
219 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
220 access to `contents' member of Lisp_Vector objects with AREF and ASET
221 where appropriate.
222
c6bf3022
CY
2232012-06-19 Chong Yidong <cyd@gnu.org>
224
225 * frame.c (delete_frame): When selecting a frame on a different
226 text terminal, do not alter the terminal's top-frame.
227
228 * xdisp.c (format_mode_line_unwind_data): Record the target
229 frame's selected window and its terminal's top-frame.
230 (unwind_format_mode_line): Restore them.
231 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
232 Callers changed.
233 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
234 since tty frames can be explicitly named.
235 (prepare_menu_bars): Likewise.
236
237 * term.c (Ftty_top_frame): New function.
238
defd4196
PE
2392012-06-18 Paul Eggert <eggert@cs.ucla.edu>
240
241 Port byte-code-meter to modern targets.
242 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
243 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 244 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
245 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
246 (METER_1, METER_2): Simplify.
247
1053a871
SM
2482012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
249
250 * data.c (Fdefalias): Return `symbol' (bug#11686).
251
b7e8d081
MR
2522012-06-18 Martin Rudalics <rudalics@gmx.at>
253
254 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
255 gets killed during executing of this function (Bug#11665).
256 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
257 (Vkill_buffer_query_functions): In doc-string say that functions
258 run by this hook should not change the current buffer.
259
7ea2b339
PE
2602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
261
262 Fix recently-introduced process.c problems found by static checking.
263 * process.c (write_queue_push, write_queue_pop, send_process):
264 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
265 (write_queue_pop): Fix pointer signedness problem.
266 (send_process): Remove unused local.
267
96a313a1
CY
2682012-06-17 Chong Yidong <cyd@gnu.org>
269
270 * xdisp.c (redisplay_internal): No need to redisplay terminal
271 frames that are not on top.
272
20ca2e94
TN
2732012-06-17 Troels Nielsen <bn.troels@gmail.com>
274
275 * process.c (make_process): Initialize write_queue.
276 (write_queue_push, write_queue_pop): New functions.
277 (send_process): Use them to maintain correct ordering of process
278 writes (Bug#10815).
279
9a900ca9
PE
2802012-06-17 Paul Eggert <eggert@cs.ucla.edu>
281
310fbfa8
PE
282 * lisp.h (eassert): Assume C89 or later.
283 This removes the need for CHECK.
284 (CHECK): Remove. Its comments about always evaluating its
285 argument were confusing, as 'eassert' typically does not evaluate
286 its argument.
287
27bb1ca4
PE
288 * coding.c (produce_chars): Use ptrdiff_t, not int.
289
9a900ca9
PE
290 * xterm.c (x_draw_underwave): Check for integer overflow.
291 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
292
41b7f8bc 2932012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
294
295 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
296 referenced (Bug#11583).
297
9b0e3eba
AA
2982012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
299
300 Implement wave-style variant of underlining.
301 * dispextern.h (face_underline_type): New enum.
302 (face): Add field for underline type.
303 * nsterm.m (ns_draw_underwave): New function.
304 (ns_draw_text_decoration): Use it.
305 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
306 New functions.
307 (x_draw_glyph_string): Use them.
308 * xfaces.c (Qline, Qwave): New Lisp objects.
309 (check_lface_attrs, merge_face_ref)
1053a871
SM
310 (Finternal_set_lisp_face_attribute, realize_x_face):
311 Handle wave-style underline face attributes.
9b0e3eba
AA
312 * xterm.c (x_draw_underwave): New function.
313 (x_draw_glyph_string): Use it.
314
0fb52f11
JB
3152012-06-16 Juanma Barranquero <lekktu@gmail.com>
316
317 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
318 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
319 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
320 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
321 ($(BLD)/w32select.$(O)): Update dependencies.
322
e5560ff7
AS
3232012-06-16 Andreas Schwab <schwab@linux-m68k.org>
324
325 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
326 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
327 * character.c (_fetch_multibyte_char_p): Remove.
328 * alloc.c: Include "character.h" before "buffer.h".
329 * bidi.c: Likewise.
330 * buffer.c: Likewise.
331 * bytecode.c: Likewise.
332 * callint.c: Likewise.
333 * callproc.c: Likewise.
334 * casefiddle.c: Likewise.
335 * casetab.c: Likewise.
336 * category.c: Likewise.
337 * cmds.c: Likewise.
338 * coding.c: Likewise.
339 * composite.c: Likewise.
340 * dired.c: Likewise.
341 * dispnew.c: Likewise.
342 * doc.c: Likewise.
343 * dosfns.c: Likewise.
344 * editfns.c: Likewise.
345 * emacs.c: Likewise.
346 * fileio.c: Likewise.
347 * filelock.c: Likewise.
348 * font.c: Likewise.
349 * fontset.c: Likewise.
350 * fringe.c: Likewise.
351 * indent.c: Likewise.
352 * insdel.c: Likewise.
353 * intervals.c: Likewise.
354 * keyboard.c: Likewise.
355 * keymap.c: Likewise.
356 * lread.c: Likewise.
357 * macros.c: Likewise.
358 * marker.c: Likewise.
359 * minibuf.c: Likewise.
360 * nsfns.m: Likewise.
361 * nsmenu.m: Likewise.
362 * print.c: Likewise.
363 * process.c: Likewise.
364 * regex.c: Likewise.
365 * region-cache.c: Likewise.
366 * search.c: Likewise.
367 * syntax.c: Likewise.
368 * term.c: Likewise.
369 * textprop.c: Likewise.
370 * undo.c: Likewise.
371 * unexsol.c: Likewise.
372 * w16select.c: Likewise.
373 * w32fns.c: Likewise.
374 * w32menu.c: Likewise.
375 * window.c: Likewise.
376 * xdisp.c: Likewise.
377 * xfns.c: Likewise.
378 * xmenu.c: Likewise.
379 * xml.c: Likewise.
380 * xselect.c: Likewise.
381
2f07e6af
EZ
3822012-06-16 Eli Zaretskii <eliz@gnu.org>
383
1053a871
SM
384 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
385 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 386 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
387 row.
388 (handle_face_prop): Use chunk-relative overlay string index when
389 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
390 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
391 the rightmost. (Bug#11720)
2f07e6af 392
29b83cec
AS
3932012-06-16 Andreas Schwab <schwab@linux-m68k.org>
394
395 * category.h (CHAR_HAS_CATEGORY): Define as inline.
396 (CATEGORY_MEMBER): Enforce 1/0 value.
397 * category.c (_temp_category_set): Remove.
398
4c5501e9
EZ
3992012-06-16 Eli Zaretskii <eliz@gnu.org>
400
401 * window.c (Fdelete_other_windows_internal)
402 (Fdelete_window_internal): Don't access frame's mouse highlight
403 info of the initial frame. (Bug#11677)
404
2b570124
PE
4052012-06-14 Paul Eggert <eggert@cs.ucla.edu>
406
e93864f9
PE
407 * .gdbinit (xgetint): Fix recently-introduced paren typo.
408 Assume USE_2_TAGS_FOR_INTS.
409 (xreload): Adjust $tagmask width to match recent lisp.h change.
410
2b570124
PE
411 Simplify lisp.h in minor ways that should not affect code.
412 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
413 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
414 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
415 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
416 (INTTYPEBITS): New macro, for clarity.
417 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
418 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
419 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
420 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
421 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
422
81755f69
JB
4232012-06-13 Juanma Barranquero <lekktu@gmail.com>
424
425 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
426
16192a57
GM
4272012-06-13 Glenn Morris <rgm@gnu.org>
428
429 * s/bsd-common.h (BSD4_3):
430 * s/usg5-4-common.h (USG5_4): No longer define; unused.
431
646b5f55
AS
4322012-06-13 Andreas Schwab <schwab@linux-m68k.org>
433
434 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
435 instead of union.
436 (XLI, XIL): Define.
1053a871
SM
437 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
438 Use them.
439 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 440 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 441 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
442 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
443 * frame.c (delete_frame): Remove outdated comment.
444 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
445 USE_LISP_UNION_TYPE.
446 (Fw32_unregister_hot_key): Likewise.
447 (Fw32_toggle_lock_key): Likewise.
448 * w32menu.c (add_menu_item): Likewise.
449 (w32_menu_display_help): Use XIL instead of checking
450 USE_LISP_UNION_TYPE.
451 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
452 (init_heap): Likewise.
453 * w32term.c (w32_read_socket): Update comment.
454
1d3823c9
GM
4552012-06-13 Glenn Morris <rgm@gnu.org>
456
c62ff706
GM
457 * s/usg5-4-common.h, src/s/unixware.h:
458 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
459
1d3823c9
GM
460 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
461
bfe3e0a2
PE
4622012-06-13 Paul Eggert <eggert@cs.ucla.edu>
463
464 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
465 * alloc.c (make_number) [!defined make_number]:
466 Remove, as lisp.h always defines this now.
467 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
468 (roundup_size): Verify that it is a power of 2.
469 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
470 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
471 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
472 -DUSE_LSB_TAG=0, to override the automatically-selected default.
473 USE_LSB_TAG now is always defined to be either 0 or 1.
474 All uses changed.
475 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
476 code works fine either way, and efficiency is not a concern here,
477 as the union type is for debugging, not for production.
478 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
479 Use an inline function on all platforms when using the union type,
480 since this is simpler and 'static inline' can be used portably
481 within Emacs now.
482 (LISP_INITIALLY_ZERO): New macro.
483 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
484 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
485
45fa9c0f
GM
4862012-06-12 Glenn Morris <rgm@gnu.org>
487
b4492cba
GM
488 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
489
490 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 491
45fa9c0f
GM
492 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
493 Move BROKEN_SIGIO to configure.
494
495 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
496 Move NO_TERMIO to configure.
497
0e25d334
CY
4982012-06-12 Chong Yidong <cyd@gnu.org>
499
500 * image.c (imagemagick_load_image): Use MagickFlattenImage if
501 MagickMergeImageLayers is undefined. Use pixel pusher loop if
502 MagickExportImagePixels is undefined.
503
43682bb6
PE
5042012-06-12 Paul Eggert <eggert@cs.ucla.edu>
505
506 * image.c (imagemagick_load_image): Remove unused label.
507
a9be7d2b
GM
5082012-06-11 Glenn Morris <rgm@gnu.org>
509
510 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
511 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
512 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
513 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
514
3017f87f
SM
5152012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
516
517 * alloc.c (make_byte_code): New function.
518 (Fmake_byte_code): Use it. Don't purify here.
519 * lread.c (read1): Use it as well to avoid extra allocation.
520
1b9b4cf4
CY
5212012-06-11 Chong Yidong <cyd@gnu.org>
522
523 * image.c (imagemagick_load_image): Implement transparency.
524
95988fcf
AS
5252012-06-10 Andreas Schwab <schwab@linux-m68k.org>
526
527 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
528 account for preceding backslashes. (Bug#11663)
529
cd4eb164
CY
5302012-06-09 Chong Yidong <cyd@gnu.org>
531
532 * term.c: Support italics in capable terminals (Bug#9652).
533 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
534 (turn_on_face): Output using TS_enter_italic_mode if available.
535 Don't handle unused blinking and alt-charset cases.
536 (turn_off_face): Handle italic case; discard unused tty_blinking_p
537 and tty_alt_charset_p cases.
538 (tty_capable_p, init_tty): Support italics.
539
540 * termchar.h (struct tty_display_info): Add field for italics.
541 Remove unused blink field.
542
543 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
544 Handle slant.
545
546 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
547 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
548 tty_alt_charset_p. Add tty_italic_p.
549
ff88beb8
MA
5502012-06-09 Michael Albinus <michael.albinus@gmx.de>
551
552 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
553 dbus_type_is_basic if available.
554 (xd_extract_signed, xd_extract_unsigned): Rename from
555 extract_signed and extract_unsigned, respectively. Adapt callers.
556
44286096
CY
5572012-06-09 Chong Yidong <cyd@gnu.org>
558
1682701f
CY
559 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
560
44286096
CY
561 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
562 case (Bug#9752).
563
d86feb17
PE
5642012-06-08 Paul Eggert <eggert@cs.ucla.edu>
565
566 * xdisp.c (vmessage): Treat frame message as multibyte.
567 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
568 would generate the diagnostic "Making \302\247 buffer-local while
569 let-bound!".
570
d5c20fe8
EZ
5712012-06-08 Eli Zaretskii <eliz@gnu.org>
572
573 * dispnew.c (showing_window_margins_p): Undo last change, which
574 was done due to an inadvertent commit.
575 (adjust_frame_glyphs_for_frame_redisplay): Do call
576 showing_window_margins_p.
577
513749ee
SM
5782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
579
580 * eval.c (Fmake_var_non_special): New primitive.
581 (syms_of_eval): Defsubr it.
582 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
583
d4a8f5c1
JB
5842012-06-08 Juanma Barranquero <lekktu@gmail.com>
585
586 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
587 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
588
8bbbc977
EZ
5892012-06-08 Eli Zaretskii <eliz@gnu.org>
590
591 * alloc.c (allocate_vectorlike): Fix last change.
592
f3372c87
DA
5932012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
594
595 Block-based vector allocation of small vectors.
596 * lisp.h (struct vectorlike_header): New field `nbytes',
597 adjust comment accordingly.
598 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
599 to denote vector blocks. Adjust users (live_vector_p,
600 mark_maybe_pointer, valid_lisp_object_p) accordingly.
601 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
602 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
603 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
604 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
605 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
606 (roundup_size): New constant.
607 (struct vector_block): New data type.
608 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 609 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
610 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
611 (sweep_vectors): New functions.
612 (allocate_vectorlike): Return `zero_vector' as the only vector of
613 0 items. Allocate new vector from block if vector size is less than
614 or equal to VBLOCK_BYTES_MAX.
615 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
616 (init_alloc_once): Add call to init_vectors.
617
4f18a4ed
SM
6182012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
619
620 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
621
86f158bc
PE
6222012-06-07 Paul Eggert <eggert@cs.ucla.edu>
623
624 * doprnt.c (doprnt): Truncate multibyte char correctly.
625 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
626 would mishandle a string argument "Xc" if X was a multibyte
627 character of length 2: it would truncate after X's first byte
628 rather than including all of X.
629
c5cfcbe0
CY
6302012-06-06 Chong Yidong <cyd@gnu.org>
631
632 * buffer.c (word_wrap): Doc fix.
633
c05cf390
PE
6342012-06-04 Paul Eggert <eggert@cs.ucla.edu>
635
636 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
637
0c3461de
GM
6382012-06-03 Glenn Morris <rgm@gnu.org>
639
640 * xdisp.c (tool-bar-style): Doc fix.
641
c71232db
UM
6422012-06-03 Ulrich Müller <ulm@gentoo.org>
643
644 * Makefile.in (PAXCTL): Define.
645 (temacs$(EXEEXT)): Disable memory randomization for the temacs
646 binary via PaX flags if the paxctl utility is available.
647 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
648 Restore PaX flags to their default. (Bug#11398)
649
383f7350
CY
6502012-06-03 Chong Yidong <cyd@gnu.org>
651
652 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
653 buffer (Bug#11226).
654
5f2c76c6
CY
6552012-06-03 Chong Yidong <cyd@gnu.org>
656
657 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
658 (note_mode_line_or_margin_highlight): If there is no help echo,
659 use mode-line-default-help-echo. Handle the case where the mouse
660 position is past the end of the mode line string.
661
662 * buffer.c (buffer_local_value_1): New function, split from
663 Fbuffer_local_value; can return Qunbound.
664 (Fbuffer_local_value): Use it.
665 (Vmode_line_format): Docstring tweaks.
666
773d47f6
PE
6672012-06-02 Paul Eggert <eggert@cs.ucla.edu>
668
669 * sysdep.c (system_process_attributes): Improve comment.
670
f2d6a3df
SM
6712012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
672
673 * keyboard.c: Export real-this-command to Elisp.
674 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
675 and DEFVAR it. Update all users.
676
63810350
PE
6772012-06-02 Paul Eggert <eggert@cs.ucla.edu>
678
7bd5c1f4
PE
679 * minibuf.c (Fassoc_string): Remove duplicate declaration.
680
63810350
PE
681 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
682 Convert pctcpu and pctmem to Lisp float properly.
683 Let the compiler fold better, as 100.0/0x8000 is exact.
684
a2821611
AS
6852012-06-02 Andreas Schwab <schwab@linux-m68k.org>
686
687 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
688 cons_block.
689
5fceba1d
PE
6902012-06-01 Paul Eggert <eggert@cs.ucla.edu>
691
692 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
693
c98ff5dd
DA
6942012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
695
696 For a 'struct window', replace some Lisp_Object fields to
697 bitfields where appropriate, remove unused fields.
698 * window.h (struct window): Remove unused 'last_mark_x' and
699 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
700 change it's type from Lisp_Object to bitfield.
701 Change type of 'force_start', 'optional_new_start',
702 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
703 fields from Lisp_Object to bitfield. Adjust users accordingly.
704
ca34e0be
PE
7052012-05-31 Paul Eggert <eggert@cs.ucla.edu>
706
707 Pacify gcc -Wdouble-precision when using Xaw.
708 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
709 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
710 Use 'float' consistently, rather than 'float' in most places
711 and 'double' in a couple of places.
712
efc00ab1 7132012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
714
715 * xdisp.c (handle_stop): Detect whether we have overlay strings
716 loaded by testing it->current.overlay_string_index to be
717 non-negative, instead of checking whether n_overlay_strings is
718 positive. (Bug#11587)
719
efc00ab1 7202012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
721
722 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
723
724 * doc.c (Fsubstitute_command_keys): Doc fix.
725
efc00ab1 7262012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
727
728 * search.c (search_buffer): Remove calls to
729 r_alloc_inhibit_buffer_relocation, as it is now called by
730 maybe_unify_char, which was the cause of relocation of buffer text
731 in bug#11519.
732
efc00ab1 7332012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
734
735 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
736 for the duration of call to load_charset, to avoid problems with
737 callers of maybe_unify_char that access buffer text through C
738 pointers.
739
740 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
741 decrement the inhibition flag, instead of just setting or
742 resetting it.
743
ba93a187
PE
7442012-05-31 Paul Eggert <eggert@cs.ucla.edu>
745
746 Remove obsolete '#define static' cruft.
747 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
748 This #undef was "temporary" in 2000; it is no longer needed
749 now that '#define static' has gone away.
750 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
751 (gray_bitmap_bits): Remove; no longer needed.
752 All uses replaced with definiens.
753 * xterm.c: Include "bitmaps/gray.xbm".
754
9e4bf381
PE
7552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
756
757 Clean up __executable_start, monstartup when --enable-profiling.
758 The following changes affect the code only when profiling.
759 * dispnew.c (__executable_start): Rename from safe_bcopy.
760 Define only on platforms that need it.
761 * emacs.c: Include <sys/gmon.h> when profiling.
762 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
763 (__executable_start): Remove decl, since lisp.h does it now.
764 (safe_bcopy): Remove decl; no longer has that name.
765 (main): Coalesce #if into single bit of code, for simplicity.
766 Cast pointers to uintptr_t, since standard libraries want integers
767 and not pointers.
768 * lisp.h (__executable_start): New decl.
769
32d72c2f
GM
7702012-05-31 Glenn Morris <rgm@gnu.org>
771
772 * image.c (Fimagemagick_types): Doc fix.
773
baac5bc7
JM
7742012-05-30 Jim Meyering <meyering@redhat.com>
775
776 * callproc.c (Fcall_process_region): Include directory component
777 in mkstemp error message (Bug#11586).
778
72cb32cf
PE
7792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
780
781 * alloc.c, lisp.h (make_pure_vector): Now static.
782
61b108cc
SM
7832012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
784
785 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
786 Move to byte-run.el.
787 (Fautoload): Do the hash-doc more carefully.
788 * data.c (Fdefalias): Purify definition, except for keymaps.
789 (Qdefun): Move from eval.c.
790 * lisp.h (Qdefun): Remove.
791 * lread.c (read1): Tiny simplification.
792
471fe23d
TN
7932012-05-29 Troels Nielsen <bn.troels@gmail.com>
794
934f3f58 795 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
796 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
797 Bug#9642, but explicitly check that the buffer the overlay would
798 be moved to is live and rearrange lines to make sure that errors
799 will not put the overlay in an inconsistent state.
800 (Fdelete_overlay): Cosmetics.
801
85d0efd1
EZ
8022012-05-28 Eli Zaretskii <eliz@gnu.org>
803
804 * w32term.c (my_bring_window_to_top): New function.
805 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
806 could be different from the original one.
807 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
808 (Bug#11513)
809
810 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
811 by calling BringWindowToTop.
812
813 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
814 (WM_EMACS_END): Increase by one.
815
da92a98c
PE
8162012-05-28 Paul Eggert <eggert@cs.ucla.edu>
817
818 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
819 This avoids undefined behavior that might cause the eassert
820 to not catch an out-of-range value.
821
74d1f848
JB
8222012-05-28 Juanma Barranquero <lekktu@gmail.com>
823
824 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
825 Update dependencies.
826
9e1a06fc
EZ
8272012-05-27 Eli Zaretskii <eliz@gnu.org>
828
829 * bidi.c (bidi_mirror_char): Fix last change.
830
f3dd7312
AS
8312012-05-27 Andreas Schwab <schwab@linux-m68k.org>
832
833 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
834 when referring to sectname field in printf format.
835
81899c91
PE
8362012-05-27 Paul Eggert <eggert@cs.ucla.edu>
837
57b81a9f
PE
838 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
839 Only r_alloc_inhibit_buffer_relocation needed to be added;
840 the others were already declared.
841
81899c91
PE
842 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
843 before checking whether it's out of range. Put the check inside
844 eassert. See
845 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
846
33017faf 8472012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
848
849 * callproc.c (Fcall_process): Restore a line that was accidentally
850 commented out in the 2011-02-13 change (bug#11547).
851
33017faf 8522012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
853
854 * lisp.h [REL_ALLOC]: Add prototypes for external functions
855 defined on ralloc.c.
856
857 * buffer.c [REL_ALLOC]: Remove prototypes of
858 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
859 they are now on lisp.h.
860
861 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
862
863 * search.c (search_buffer): Use it to inhibit relocation of buffer
864 text while re_search_2 is doing its job, because re_search_2 is
865 passed C pointers to buffer text. (Bug#11519)
866
23415acf
EZ
867 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
868 Update value to 24.
869
44e27368
EZ
870 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
871 state after an additional call to move_it_in_display_line_to, keep
872 the values of it->max_ascent and it->max_descent found for the
873 entire line.
874 (pos_visible_p): Revert the comparison against bottom_y to what it
875 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
876 (Bug#11464)
877
c1892f11
PE
8782012-05-26 Paul Eggert <eggert@cs.ucla.edu>
879
880 Fix coding-related core dumps with gcc -ftrapv.
881 The code was computing A - B, where A and B are pointers, and B is
882 random garbage. This can lead to core dumps on platforms that
883 have special pointer registers, and it also leads to core dumps on
884 x86-64 when compiled with gcc -ftrapv. The fix is to compute
885 A - B only when B is initialized properly.
886 * coding.c (coding_set_source, coding_set_destination): Return void.
887 (coding_change_source, coding_change_destinations): New functions,
888 with the old behaviors of coding_set_source and coding_set_destination.
889 All callers that need an offset changed to use these new functions.
890
eb7afdad
GM
8912012-05-26 Glenn Morris <rgm@gnu.org>
892
893 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
894
f12fdf02
EZ
8952012-05-26 Eli Zaretskii <eliz@gnu.org>
896
53a63be6 897 Extend mouse support on W32 text-mode console.
61b108cc
SM
898 * xdisp.c (draw_row_with_mouse_face):
899 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 900
eb3f6f01 901 * w32console.c: Include window.h.
61b108cc
SM
902 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
903 New functions.
eb3f6f01
EZ
904 (initialize_w32_display): Initialize mouse-highlight data.
905
53a63be6
EZ
906 * w32inevt.c: Include termchar.h and window.h.
907 (do_mouse_event): Support mouse-autoselect-window. When the mouse
908 moves, call note_mouse_highlight. If help_echo changed, call
909 gen_help_event to produce help-echo message in the echo area.
910 Call clear_mouse_face if mouse_face_hidden is set in the mouse
911 highlight info.
912
4cfd81f6
PE
9132012-05-26 Paul Eggert <eggert@cs.ucla.edu>
914
915 * lread.c (read1): Simplify slightly to avoid an overflow warning
916 with GCC 4.7.0 on x86-64.
917
4446092a
EZ
9182012-05-26 Eli Zaretskii <eliz@gnu.org>
919
920 * bidi.c (bidi_mirror_char): Revert last change: an int is
921 definitely wide enough here.
922
42b2a986 9232012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 924
42b2a986 925 Fix integer width and related bugs (Bug#9874).
eb106a49 926 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
927 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
928 (string_bytes, check_sblock, allocate_string_data):
929 (compact_small_strings, Fmake_bool_vector, make_string)
930 (make_unibyte_string, make_multibyte_string)
931 (make_string_from_bytes, make_specified_string)
932 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
933 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
934 (mark_vectorlike):
935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
936 (allocate_pseudovector):
937 Use int, not EMACS_INT, where int is wide enough.
938 (inhibit_garbage_collection, Fgarbage_collect):
939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
940 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
941 int might not be wide enough.
942 (bidi_cache_search, bidi_cache_find, bidi_init_it)
943 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
944 (bidi_at_paragraph_end, bidi_find_paragraph_start)
945 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
946 (bidi_level_of_next_char, bidi_move_to_visually_next):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
949 (Fkill_buffer, Fset_buffer_major_mode)
950 (advance_to_char_boundary, Fbuffer_swap_text)
951 (Fset_buffer_multibyte, overlays_at, overlays_in)
952 (overlay_touches_p, struct sortvec, record_overlay_string)
953 (overlay_strings, recenter_overlay_lists)
954 (adjust_overlays_for_insert, adjust_overlays_for_delete)
955 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
956 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
957 (Foverlay_recenter, last_overlay_modification_hooks_used)
958 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
960 (validate_region): Omit unnecessary test for b <= e,
961 since that's guaranteed by the previous test.
d311d28c
PE
962 (adjust_overlays_for_delete): Avoid pos + length overflow.
963 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
964 (report_overlay_modification):
965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
966 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
967 Omit pointer cast, which isn't needed anyway, and doesn't work
968 after the EMACS_INT -> ptrdiff_t change.
02481186 969 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
970 * buffer.h: Adjust decls to match defn changes elsewhere.
971 (struct buffer_text, struct buffer):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
973 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
974 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
975 not int, to avoid needless 32-bit limit on 64-bit hosts.
976 (exec_byte_code): Use tighter memory-full test, one that checks
977 for alloca overflow. Don't compute the address of the object just
978 before an array, as that's not portable. Use EMACS_INT, not
979 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
980 * callint.c (Fcall_interactively):
981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
982 * callproc.c (call_process_kill, Fcall_process):
983 Don't assume pid_t fits into an Emacs fixnum.
984 (call_process_cleanup, Fcall_process, child_setup):
985 Don't assume pid_t fits into int.
986 (call_process_cleanup, Fcall_process, delete_temp_file)
987 (Fcall_process_region):
988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
989 (Fcall_process): Simplify handling of volatile integers.
990 Use int, not EMACS_INT, where int will do.
991 * casefiddle.c (casify_object, casify_region, operate_on_word)
992 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
994 (casify_object): Avoid integer overflow when overallocating buffer.
995 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 996 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
997 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
998 * category.h (CATEGORYP): Don't assume arg is nonnegative.
999 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1000 integers are now checked earlier. All uses replaced with XINT.
1001 (ccl_driver):
1002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1003 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1004 (ccl_driver, Fregister_code_conversion_map):
1005 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1006 (resolve_symbol_ccl_program): Check that vector header is in range.
1007 Always copy the vector, so that we can check its contents reliably
1008 now rather than having to recheck each instruction as it's being
1009 executed. Check that vector words fit in 'int'.
1010 (ccl_get_compiled_code, Fregister_ccl_program)
1011 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1012 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1013 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1014 contents are in range.
1015 (Fccl_execute_on_string): Check that status is in range.
1016 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1017 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1018 Accept and return EMACS_INT, not int, because callers can pass values
1019 out of 'int' range.
1020 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1021 (multibyte_chars_in_text, parse_str_as_multibyte)
1022 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1023 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1024 (string_escape_byte8, Fget_byte):
1025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1026 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1027 avoid mishandling large integers.
1028 * character.h: Adjust decls to match defn changes elsewhere.
1029 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1030 (Ffind_charset_region):
1031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1032 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1033 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1034 Don't assume fixnum fits in int.
d311d28c
PE
1035 (load_charset_map_from_vector, Fmap_charset_chars):
1036 Remove now-unnecessary CHECK_NATNUMs.
1037 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1038 Don't rely on undefined behavior with signed left shift overflow.
1039 Don't assume unsigned int fits into fixnum, or that fixnum fits
1040 into unsigned int. Don't require max_code to be a valid fixnum;
1041 that's not true for gb10830 4-byte on a 32-bit host. Allow
1042 invalid_code to be a cons, for the same reason. Require code_offset
1043 to be a character. Avoid int overflow if max_char is close
1044 to INT_MAX.
1045 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1046 this is intended anyway and avoids some undefined behavior.
1047 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1048 INDEX_TO_CODE_POINT, as that's what it expects.
1049 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1050 * charset.h (DECODE_CHAR): Return int, not unsigned;
1051 this is what was intended anyway, and it avoids undefined behavior.
1052 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1053 integer-overflow issues.
1054 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1055 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1056 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1057 * chartab.c (Fmake_char_table, Fset_char_table_range)
1058 (uniprop_get_decoder, uniprop_get_encoder):
1059 Don't assume fixnum fits in int.
1060 * cmds.c (move_point): New function, that does the gist of
1061 Fforward_char and Fbackward_char, but does so while checking
1062 for integer overflow more accurately.
c96e5d6a 1063 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1064 (Fforward_line, Fend_of_line, internal_self_insert)
1065 (internal_self_insert):
1066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1067 Fix a FIXME, by checking for integer overflow when calculating
1068 target_clm and actual_clm.
1069 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1070 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1071 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1072 (coding_alloc_by_making_gap, alloc_destination)
1073 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1074 (encode_coding_utf_16, detect_coding_emacs_mule)
1075 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1076 (detect_coding_iso_2022, decode_coding_iso_2022)
1077 (encode_invocation_designation, encode_designation_at_bol)
1078 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1079 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1080 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1081 (encode_coding_ccl, encode_coding_raw_text)
1082 (detect_coding_charset, decode_coding_charset)
1083 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1084 (produce_composition, produce_charset, produce_annotation)
1085 (decode_coding, handle_composition_annotation)
1086 (handle_charset_annotation, consume_chars, decode_coding_gap)
1087 (decode_coding_object, encode_coding_object, detect_coding_system)
1088 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1089 (code_convert_region, code_convert_string)
8f50130c
PE
1090 (Fdefine_coding_system_internal)
1091 (coding_set_source, coding_set_destination):
d311d28c
PE
1092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1093 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1094 (Fdefine_coding_system_internal):
1095 Don't assume fixnums fit in int.
1096 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1097 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1098 (Funencodable_char_position, Fcheck_coding_systems_region)
1099 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1101 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1102 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1103 Don't access memory outside of the args array.
d311d28c 1104 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1105 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1106 result of ENCODE_CHAR.
d311d28c
PE
1107 * coding.h: Adjust decls to match defn changes elsewhere.
1108 (struct coding_system):
1109 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1110 * composite.c (get_composition_id, find_composition)
1111 (run_composition_function, update_compositions)
1112 (compose_text, composition_gstring_put_cache)
1113 (composition_gstring_p, composition_gstring_width)
1114 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1115 (composition_compute_stop_pos, composition_reseat_it)
1116 (composition_update_it, struct position_record)
1117 (find_automatic_composition, composition_adjust_point)
1118 (Fcomposition_get_gstring, Ffind_composition_internal):
1119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1120 (update_compositions):
1121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1122 * composite.h: Adjust decls to match defn changes elsewhere.
1123 (struct composition):
1124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1125 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1126 Do not attempt to compute the address of the object just before a
1127 buffer; this is not portable.
1128 (Faref, Faset):
1129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1130 (Faset): Use int, not EMACS_INT, where int is wide enough.
1131 (Fstring_to_number): Don't assume fixnums fit in int.
1132 (Frem): Don't assume arg is nonnegative.
1133 * dbusbind.c (xd_append_arg): Check for integers out of range.
1134 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1135 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1136 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1137 (xd_get_connection_references): Return ptrdiff_t, not int.
1138 All uses changed.
1139 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1140 (xd_read_message_1):
1141 Use int, not unsigned, where the dbus API uses int.
1142 (Fdbus_message_internal): Don't overflow mtype.
1143 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1144 * dired.c (directory_files_internal, file_name_completion, scmp)
1145 (file_name_completion_stat):
1146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1147 (file_name_completion): Don't overflow matchcount.
1148 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1149 * dispextern.h: Adjust decls to match defn changes elsewhere.
1150 (struct text_pos, struct glyph, struct bidi_saved_info)
1151 (struct bidi_string_data, struct bidi_it, struct composition_it)
1152 (struct it):
1153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1154 (struct display_pos, struct composition_it, struct it):
1155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1156 * dispnew.c (increment_matrix_positions)
1157 (increment_row_positions, mode_line_string)
1158 (marginal_area_string):
1159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1160 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 (duration_to_sec_usec): New function, to check for overflow better.
1163 (Fsleep_for, sit_for): Use it.
1164 * doc.c (get_doc_string, store_function_docstring):
1165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1166 (get_doc_string, Fsnarf_documentation):
1167 Use int, not EMACS_INT, where int is wide enough.
1168 (get_doc_string):
1169 Use SAFE_ALLOCA, not alloca.
1170 Check for overflow when converting EMACS_INT to off_t.
1171 * doprnt.c (doprnt):
1172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1173 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1174 Don't assume uid_t fits into fixnum.
1175 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1176 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1177 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1178 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1179 (general_insert_function)
1180 (Finsert_char, make_buffer_string, make_buffer_string_both)
1181 (update_buffer_properties, Fbuffer_substring)
1182 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1183 (Fsubst_char_in_region, check_translation)
1184 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1185 (transpose_markers, Ftranspose_regions):
1186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1187 (clip_to_bounds): Move to lisp.h as an inline function).
1188 (Fconstrain_to_field): Don't assume integers are nonnegative.
1189 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1190 (Fsubst_char_in_region, Fsave_restriction):
1191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1192 (Femacs_pid): Don't assume pid_t fits into fixnum.
1193 (lo_time): Use int, not EMACS_INT, when int suffices.
1194 (lisp_time_argument): Check for usec out of range.
1195 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1196 (Fuser_login_name, Fuser_full_name): Signal an error
1197 if a uid argument is out of range, rather than relying on
1198 undefined behavior.
c8d5c857
PE
1199 (Fformat_time_string): Remove now-unnecessary check.
1200 lisp_time_argument checks for out-of-range usec now.
243e0530 1201 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1202 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1203 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1204 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1205 (init_cmdargs, Fdump_emacs):
1206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1207 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1208 the bottom (typically) 32 bits of the fixnum.
1209 * eval.c (specpdl_size, call_debugger):
1210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1211 (when_entered_debugger, Fbacktrace_debug):
1212 Don't assume fixnum can fit in int.
1213 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1214 the object just before a buffer; this is not portable.
1215 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1216 (grow_specpdl, unbind_to):
1217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1218 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1219 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1220 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1221 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1222 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1224 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1225 (a_write, e_write):
1226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1227 (Fcopy_file, non_regular_nbytes, read_non_regular)
1228 (Finsert_file_contents):
1229 Use int, not EMACS_INT, where int is wide enough.
1230 (READ_BUF_SIZE): Verify that it fits in int.
1231 (Finsert_file_contents): Check that counts are in proper range,
1232 rather than assuming fixnums fit into ptrdiff_t etc.
1233 Don't assume fixnums fit into int.
125b3835 1234 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1235 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1236 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1237 (string_char_to_byte, string_byte_to_char)
1238 (string_make_multibyte, string_to_multibyte)
1239 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1240 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1241 (substring_both, Fdelete, internal_equal, Ffillarray)
1242 (Fclear_string, mapcar1)
1243 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1244 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1245 (larger_vector, make_hash_table, maybe_resize_hash_table)
1246 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1247 (Fmaphash, secure_hash):
1248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1249 (concat): Check for string index and length overflow.
1250 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1251 (Frequire):
1252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1253 (larger_vector): New API (vec, incr_min, size_max) replaces old
1254 one (vec, new_size, init). This catches size overflow.
1255 INIT was removed because it was always Qnil.
1256 All callers changed.
1257 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1258 the upper bound on a hash table index size.
1259 (make_hash_table, maybe_resize_hash_table): Use it.
1260 (secure_hash): Computer start_byte and end_byte only after
1261 they're known to be in ptrdiff_t range.
1262 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1263 (Ffont_get_glyphs, Ffont_at):
1264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1265 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1266 (Flist_fonts, Fopen_font):
1267 Don't assume fixnum can fit in int.
1268 (check_gstring): Don't assume index can fit in int.
1269 (font_match_p): Check that fixnum is a character, not a nonnegative
1270 fixnum, since the later code needs to stuff it into an int.
1271 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1272 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1273 conversion overflow issues.
1274 (Fopen_font): Check for integer out of range.
1275 (Ffont_get_glyphs): Don't assume index can fit in int.
1276 * font.h: Adjust decls to match defn changes elsewhere.
1277 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1278 integer overflow.
1279 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1280 printmax_t, where ptrdiff_t is wide enough.
1281 (Finternal_char_font):
1282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1283 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1284 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1285 (Fset_frame_position, x_set_frame_parameters)
1286 (x_set_line_spacing, x_set_border_width)
1287 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1288 Check that fixnums are in proper range for system types.
1289 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1291 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1292 Use SAFE_ALLOCA_LISP, not alloca.
1293 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1294 intptr_t is wide enough.
1295 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1296 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1297 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1298 Check for fixnum out of range.
1299 * ftfont.c (ftfont_list): Don't assume index fits in int.
1300 Check that fixnums are in proper range for system types.
1301 (ftfont_shape_by_flt):
1302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1303 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1305 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1306 Check that fixnums are in proper range for system types.
1307 * gnutls.h: Adjust decls to match defn changes elsewhere.
1308 * gtkutil.c (xg_dialog_run):
1309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1310 (update_frame_tool_bar):
1311 Check that fixnums are in proper range for system types.
1312 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1313 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1314 * indent.c (last_known_column, last_known_column_point):
1315 (current_column_bol_cache):
1316 (skip_invisible, current_column, check_display_width):
1317 (check_display_width, scan_for_column, current_column_1)
1318 (Findent_to, Fcurrent_indentation, position_indentation)
1319 (indented_beyond_p, Fmove_to_column, compute_motion):
1320 (Fcompute_motion, Fvertical_motion):
1321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1322 (last_known_column_modified): Use EMACS_INT, not int.
1323 (check_display_width):
1324 (Fcompute_motion):
1325 Check that fixnums and floats are in proper range for system types.
1326 (compute_motion): Don't assume index or fixnum fits in int.
1327 (compute_motion, Fcompute_motion):
1328 Use int, not EMACS_INT, when it is wide enough.
1329 (vmotion): Omit local var start_hpos that is always 0; that way
1330 we don't need to worry about overflow in expressions involving it.
1331 * indent.h: Adjust decls to match defn changes elsewhere.
1332 (struct position):
1333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1334 Use int, not EMACS_INT, where int is wide enough.
1335 Remove unused members ovstring_chars_done and tab_offset;
1336 all uses removed.
1337 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1338 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1339 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1340 (make_gap, copy_text, insert, insert_and_inherit)
1341 (insert_before_markers, insert_before_markers_and_inherit)
1342 (insert_1, count_combining_before, count_combining_after)
1343 (insert_1_both, insert_from_string)
1344 (insert_from_string_before_markers, insert_from_string_1)
1345 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1346 (adjust_after_replace, adjust_after_insert, replace_range)
1347 (replace_range_2, del_range, del_range_1, del_range_byte)
1348 (del_range_both, del_range_2, modify_region)
1349 (prepare_to_modify_buffer, signal_before_change)
1350 (signal_after_change, Fcombine_after_change_execute):
1351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1352 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1353 (balance_an_interval, split_interval_right, split_interval_left)
1354 (find_interval, next_interval, update_interval)
1355 (adjust_intervals_for_insertion, delete_node, delete_interval)
1356 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1357 (static_offset_intervals, offset_intervals)
1358 (merge_interval_right, merge_interval_left, make_new_interval)
1359 (graft_intervals_into_buffer, temp_set_point_both)
1360 (temp_set_point, set_point, adjust_for_invis_intang)
1361 (set_point_both, move_if_not_intangible, get_property_and_range)
1362 (get_local_map, copy_intervals, copy_intervals_to_string)
1363 (compare_string_intervals, set_intervals_multibyte_1):
1364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1365 * intervals.h: Adjust decls to match defn changes elsewhere.
1366 (struct interval):
1367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1368 * keyboard.c (this_command_key_count, this_single_command_key_start)
1369 (before_command_key_count, before_command_echo_length, echo_now)
1370 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1371 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1372 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1373 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1375 (last_non_minibuf_size, last_point_position, echo_truncate)
1376 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1377 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1378 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1379 (stuff_buffered_input):
1380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1381 (last_auto_save, command_loop_1, read_char):
1382 Use EMACS_INT, not int, to avoid integer overflow.
1383 (record_char): Avoid overflow in total_keys computation.
1384 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1385 * keyboard.h: Adjust decls to match defn changes elsewhere.
1386 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1387 (Fkey_description, Fdescribe_vector, Flookup_key):
1388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1389 (click_position): New function, to check that positions are in range.
1390 (Fcurrent_active_maps):
1391 (describe_command):
1392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1393 (Faccessible_keymaps, Fkey_description):
1394 (preferred_sequence_p):
1395 Don't assume fixnum can fit into int.
1396 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1397 Check for integer overflow in size calculations.
1398 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1399 avoid mishandling large integers.
1400 * lisp.h: Adjust decls to match defn changes elsewhere.
1401 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1402 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1403 (struct Lisp_Marker):
1404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1405 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1406 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1407 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1408 All callers changed.
1409 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1410 Assume the arg has valid form, since it always does.
1411 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1412 unsigned integer system type.
1413 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1414 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1416 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1417 (duration_to_sec_usec): New decl.
1418 * lread.c (read_from_string_index, read_from_string_index_byte)
1419 (read_from_string_limit, readchar, unreadchar, openp)
1420 (read_internal_start, read1, oblookup):
1421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1422 (Fload, readevalloop, Feval_buffer, Feval_region):
1423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1424 (openp): Check for out-of-range argument to 'access'.
1425 (read1): Use int, not EMACS_INT, where int is wide enough.
1426 Don't assume fixnum fits into int.
6efdadfd 1427 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1428 (read_filtered_event): Use duration_to_sec_usec
1429 to do proper overflow checking on durations.
d311d28c
PE
1430 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1431 in size calculation.
1432 (Fexecute_kbd_macro):
1433 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1434 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1435 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1436 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1437 (set_marker_both, set_marker_restricted_both, marker_position)
1438 (marker_byte_position, Fbuffer_has_markers_at):
1439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1440 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1441 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1442 It now merely ensures that the menu is large enough, without
1443 necessarily growing it, as this avoids some integer overflow issues.
1444 All callers changed.
1445 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1447 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1448 Use SAFE_ALLOCA_LISP, not alloca.
1449 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1450 to EMACS_INT. Check that fixnums are in proper range for system types.
1451 * minibuf.c (minibuf_prompt_width, string_to_object)
1452 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1453 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1455 (get_minibuffer, read_minibuf_unwind):
1456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1457 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1458 this simplifies overflow checking. All callers changed.
1459 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1460 (Ftest_completion):
1461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1462 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1463 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1464 Check that fixnums are in proper range for system types.
1465 (Fx_create_frame, Fx_show_tip):
1466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1467 * nsfont.m (ns_findfonts, nsfont_list_family):
1468 Don't assume fixnum fits in long.
1469 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1471 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1472 wide enough.
17fdb222 1473 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1475 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1476 (PRINTDECLARE, PRINTPREPARE):
1477 (strout, print_string):
1478 (print, print_preprocess, print_check_string_charset_prop)
1479 (print_object):
1480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1481 (PRINTDECLARE):
1482 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1484 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1485 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1486 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1487 (print_error_message): Use SAFE_ALLOCA, not alloca.
1488 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1489 (print_depth, new_backquote_output, print_number_index):
1490 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1491 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1492 (Fset_process_window_size, Fformat_network_address)
1493 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1494 (sigchld_handler):
d311d28c 1495 Check that fixnums are in proper range for system types.
d44287d4 1496 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1497 Check for process-ids out of pid_t range rather than relying on
1498 undefined behavior.
e4d81efc 1499 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1500 (Fformat_network_address, read_process_output, send_process)
1501 (Fprocess_send_region, status_notify):
1502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1503 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1504 (wait_reading_process_output, read_process_output, exec_sentinel):
1505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1506 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1507 (Faccept_process_output): Use duration_to_sec_usec to do proper
1508 overflow checking on durations.
dde14581
PE
1509 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1510 Don't assume pid_t fits in int.
02481186
PE
1511 * process.h (struct Lisp_Process): Members tick and update_tick
1512 are now of type EMACS_INT, not int.
b62b53e8
PE
1513 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1514 configured --with-wide-int.
d311d28c
PE
1515 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1516 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1517 * search.c (looking_at_1, string_match_1):
1518 (fast_string_match, fast_c_string_match_ignore_case)
1519 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1520 (scan_newline, find_before_next_newline, search_command)
1521 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1522 (set_search_regs, wordify):
1523 (Freplace_match):
1524 (Fmatch_data):
1525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1526 (string_match_1, search_buffer, set_search_regs):
1527 (Fmatch_data):
1528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1529 (wordify): Check for overflow in size calculation.
1530 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1531 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1532 Check that fixnums are in proper range for system types.
1533 * sound.c (struct sound_device)
1534 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1536 (Fplay_sound_internal):
1537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1538 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1539 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1540 (Fparse_partial_sexp):
1541 Don't assume fixnums can fit in int.
1542 (struct lisp_parse_state, find_start_pos, find_start_value)
1543 (find_start_value_byte, find_start_begv)
1544 (update_syntax_table, char_quoted, dec_bytepos)
1545 (find_defun_start, prev_char_comend_first, back_comment):
1546 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1547 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1549 (Finternal_describe_syntax_value): Check that match_lisp is a
1550 character, not an integer, since the code stuffs it into int.
1551 (scan_words, scan_sexps_forward):
1552 Check that fixnums are in proper range for system types.
1553 (Fforward_word):
1554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1555 (scan_sexps_forward):
1556 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1557 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1558 * syntax.h: Adjust decls to match defn changes elsewhere.
1559 (struct gl_state_s):
1560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1561 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1562 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1563 * sysdep.c (wait_for_termination_1, wait_for_termination)
1564 (interruptible_wait_for_termination, mkdir):
1565 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1566 (emacs_read, emacs_write):
1567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1568 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1569 and double all fit in int.
d311d28c
PE
1570 * term.c (set_tty_color_mode):
1571 Check that fixnums are in proper range for system types.
1572 * termhooks.h (struct input_event):
1573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1574 * textprop.c (validate_interval_range, interval_of)
1575 (Fadd_text_properties, set_text_properties_1)
1576 (Fremove_text_properties, Fremove_list_of_text_properties)
1577 (Ftext_property_any, Ftext_property_not_all)
1578 (copy_text_properties, text_property_list, extend_property_ranges)
1579 (verify_interval_modification):
1580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1581 (Fnext_single_char_property_change)
1582 (Fprevious_single_char_property_change):
1583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1584 (copy_text_properties):
1585 Check for integer overflow in index calculation.
d311d28c
PE
1586 * undo.c (last_boundary_position, record_point, record_insert)
1587 (record_delete, record_marker_adjustment, record_change)
1588 (record_property_change):
1589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1590 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1592 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1593 (Fx_hide_tip, Fx_file_dialog):
1594 * w32menu.c (set_frame_menubar):
1595 Use ptrdiff_t, not int, for consistency with rest of code.
1596 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1597 (select_window, Fdelete_other_windows_internal)
1598 (window_scroll_pixel_based, window_scroll_line_based)
1599 (Frecenter, Fset_window_configuration):
1600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1601 (Fset_window_hscroll, run_window_configuration_change_hook)
1602 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1603 (Fscroll_other_window, Frecenter):
d311d28c
PE
1604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1605 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1606 Don't assume fixnum fits in int.
1607 (Fset_window_scroll_bars):
1608 Check that fixnums are in proper range for system types.
1609 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1610 (string_pos, c_string_pos, number_of_chars, init_iterator)
1611 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1612 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1613 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1614 (face_before_or_after_it_pos, handle_invisible_prop)
1615 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1616 (display_prop_intangible_p, string_buffer_position_lim)
1617 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1618 (get_overlay_strings_1, get_overlay_strings)
1619 (iterate_out_of_display_property, forward_to_next_line_start)
1620 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1621 (get_next_display_element, set_iterator_to_next)
1622 (get_visually_first_element, compute_stop_pos_backwards)
1623 (handle_stop_backwards, next_element_from_buffer)
1624 (move_it_in_display_line_to, move_it_in_display_line)
1625 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1626 (add_to_log, message_dolog, message_log_check_duplicate)
1627 (message2, message2_nolog, message3, message3_nolog
1628 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1629 (current_message_1, truncate_echo_area, truncate_message_1)
1630 (set_message, set_message_1, store_mode_line_noprop)
1631 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1632 (text_outside_line_unchanged_p, check_point_in_composition)
1633 (reconsider_clip_changes)
1634 (redisplay_internal, set_cursor_from_row, try_scrolling)
1635 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1636 (redisplay_window, find_last_unchanged_at_beg_row)
1637 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1638 (trailing_whitespace_p, find_row_edges, display_line)
1639 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1640 (display_mode_element, store_mode_line_string)
1641 (pint2str, pint2hrstr, decode_mode_spec)
1642 (display_count_lines, display_string, draw_glyphs)
1643 (x_produce_glyphs, x_insert_glyphs)
1644 (rows_from_pos_range, mouse_face_from_buffer_pos)
1645 (fast_find_string_pos, mouse_face_from_string_pos)
1646 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1648 (safe_call, init_from_display_pos, handle_fontified_prop)
1649 (handle_single_display_spec, load_overlay_strings)
1650 (with_echo_area_buffer, setup_echo_area_for_printing)
1651 (display_echo_area, echo_area_display)
1652 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1653 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1654 (redisplay_window, dump_glyph_row, display_mode_line)
1655 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1656 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1658 (handle_single_display_spec, build_desired_tool_bar_string)
1659 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1660 (get_specified_cursor_type):
1661 Check that fixnums are in proper range for system types.
1662 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1663 (Flookup_image_map):
1664 Don't assume fixnums fit in int.
1665 (compare_overlay_entries):
1666 Avoid mishandling comparisons due to subtraction overflow.
1667 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1668 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1669 (handle_tool_bar_click):
1670 Use int, not unsigned, since we prefer signed and the signedness
1671 doesn't matter here.
1672 (get_next_display_element, next_element_from_display_vector):
1673 Use int, not EMACS_INT, when int is wide enough.
1674 (start_hourglass): Use duration_to_sec_usec to do proper
1675 overflow checking on durations.
1676 * xfaces.c (Fbitmap_spec_p):
1677 Check that fixnums are in proper range for system types.
1678 (compare_fonts_by_sort_order):
1679 Avoid mishandling comparisons due to subtraction overflow.
1680 (Fx_family_fonts, realize_basic_faces):
1681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1682 (Fx_family_fonts):
1683 Don't assume fixnum fits in int.
1684 Use SAFE_ALLOCA_LISP, not alloca.
1685 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1686 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1687 (face_at_buffer_position, face_for_overlay_string)
1688 (face_at_string_position):
1689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1690 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1691 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1692 (Fx_show_tip):
1693 Check that fixnums are in proper range for system types.
1694 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1695 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1697 (Fx_change_window_property): Don't assume fixnums fit in int.
1698 * xfont.c (xfont_chars_supported):
1699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1700 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1701 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1703 * xml.c (parse_region):
1704 * xrdb.c (magic_file_p):
1705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1706 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1707 (x_get_local_selection, x_reply_selection_request)
1708 (x_handle_selection_request, wait_for_property_change):
1709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1710 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1711 short is wide enough.
1712 (x_send_client_event): Don't assume fixnum fits in int.
1713 * xterm.c (x_x_to_emacs_modifiers):
1714 Don't assume EMACS_INT overflows nicely into int.
1715 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1716 may come from Lisp.
1717 (handle_one_xevent): NATNUMP can eval its arg twice.
1718 (x_connection_closed):
1719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1720 * xterm.h: Adjust decls to match defn changes elsewhere.
1721 (struct scroll_bar): Use struct vectorlike_header
1722 rather than rolling our own approximation.
1723 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1724
c6574eb5
GM
17252012-05-25 Glenn Morris <rgm@gnu.org>
1726
1727 * lisp.mk (lisp): Update for more files being compiled now.
1728
e8d32c7e
SM
17292012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1730
48def666
SM
1731 * lread.c: Remove `read_pure' which makes no difference.
1732 (read_pure): Remove var.
1733 (unreadpure): Remove function.
1734 (readevalloop): Don't call read_list with -1 flag.
1735 (read1, read_vector): Don't test read_pure any more.
1736 (read_list): Simplify.
1737
e8d32c7e
SM
1738 * fileio.c, character.h: Minor style tweaks.
1739
4b2addb7
DA
17402012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1741
1742 * window.h (clip_changed): Remove useless declaration.
1743
584461b2
JB
17442012-05-22 Juanma Barranquero <lekktu@gmail.com>
1745
1746 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1747 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1748
34374650
PE
17492012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 Remove src/m/*.
1752 This directory predates autoconf and is no longer needed nowadays.
1753 Move its few remaining bits of functionality to where they're needed.
1754 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1755 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1756 * m/template.h: Remove.
1757 * Makefile.in (M_FILE): Remove. All uses removed.
1758 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1759 * lisp.h (USE_LSB_TAG):
1760 * mem-limits.h (EXCEEDS_LISP_PTR):
1761 Use VAL_MAX, not VALBITS, in #if.
1762 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1763 (EMACS_UINT): Define unconditionally now.
1764 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1765 (BITS_PER_EMACS_INT): New constants, replacing
1766 what used to be in config.h, but not useful in #if.
1767 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1768 define them any more.
1769 (VAL_MAX): New macro.
1770 (VALMASK): Use it.
1771 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1772 BITS_PER_EMACS_INT, in #if.
1773 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1774 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1775 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1776 * s/ms-w32.h (DATA_START):
1777 Move here from removed file m/intel386.h.
1778 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1779 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1780
261cb4bb
PE
17812012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 Assume C89 or later.
1784 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1785 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1786 (xrealloc):
1787 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1788 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1789 * textprop.c, tparam.c (NULL): Remove.
1790 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1791 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1792 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1793 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1794 * xterm.c (input_signal_count): Assume volatile works.
1795
ff23cd9f
KB
17962012-05-21 Ken Brown <kbrown@cornell.edu>
1797
1798 * xgselect.c (xg_select): Fix first argument in call to 'select'
1799 (bug#11508).
1800
1b170bc6
KB
18012012-05-20 Ken Brown <kbrown@cornell.edu>
1802
1803 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1804 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1805
b2f4d39f
KB
18062012-05-19 Ken Brown <kbrown@cornell.edu>
1807
1808 * xfns.c (x_in_use): Remove `static' qualifier.
1809 * xterm.h (x_in_use): Declare.
1810 * xgselect.c: Include xterm.h.
1811 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1812 and `display_arg' (bug#9754).
1813
003fdae2
PE
18142012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1815
9232a6d9
PE
1816 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1817
003fdae2
PE
1818 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1819 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1820
784b56e2
EZ
18212012-05-18 Eli Zaretskii <eliz@gnu.org>
1822
1823 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1824
1825 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1826 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1827
1828 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1829 reference to image_cache->refcount.
1830 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1831
a0a79cde
JL
18322012-05-17 Juri Linkov <juri@jurta.org>
1833
1834 * search.c (Fword_search_regexp, Fword_search_backward)
1835 (Fword_search_forward, Fword_search_backward_lax)
1836 (Fword_search_forward_lax): Move functions to isearch.el
1837 (bug#10145, bug#11381).
1838
b0572523
PE
18392012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1842
9660f5fc
SM
18432012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1844
1845 * lread.c (init_obarray): Declare Qt and Qnil as special.
1846
4374de83
GM
18472012-05-14 Glenn Morris <rgm@gnu.org>
1848
1849 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1850 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1851
dc44c39a
PE
18522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1853
078c97cb
PE
1854 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1855
dc44c39a
PE
1856 * unexaix.c: Port to more-recent AIX compilers.
1857 (report_error, report_error_1, make_hdr, copy_sym)
1858 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1859 Make arguments const char *, not char *, to avoid violations of C
1860 standard and to fix some AIX warnings reported by Gilles Pion.
1861
e18afed7 18622012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1863
1864 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1865 already have overlays loaded.
1866 (handle_single_display_spec): Before returning without displaying
1867 fringe bitmap, synchronize the bidi iterator with the main display
1868 iterator, by calling iterate_out_of_display_property.
1869 (iterate_out_of_display_property): Detect buffer iteration by
1870 testing that it->string is a Lisp string.
1871 (get_next_display_element): When the current object is exhausted,
1872 and there's something on it->stack, call set_iterator_to_next to
1873 proceed with what's on the stack, instead of returning zero.
1874 (set_iterator_to_next): If called at the end of a Lisp string,
1875 proceed to consider_string_end without incrementing string
1876 position. Don't increment display vector index past the end of
1877 the display vector. (Bug#11417)
c8fb9dc6
EZ
1878 (pos_visible_p): Don't report a position visible when move_it_to
1879 stopped at the last line of window, which happens to be scanned
1880 backwards by the bidi iteration. (Bug#11464)
ac268e67 1881
e18afed7 18822012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1883
1884 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1885 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1886 are on a TTY, and thus unable to display on the fringes.
1887 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1888 so we need to signal to the caller that this is a "replacing"
1889 display spec. This fixes display when the spec is invalid or we
1890 are on a TTY.
1891
e18afed7 18922012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1893
1894 * unexaix.c (make_hdr): Fix typo in prototype.
1895 This bug broke the build on AIX. Problem reported by Gilles Pion.
1896
9d0a235a
MA
18972012-05-14 Michael Albinus <michael.albinus@gmx.de>
1898
1899 * keyboard.c (kbd_buffer_get_event): Read special events also in
1900 batch mode. (Bug#11415)
1901
9e6b06ed
GM
19022012-05-12 Glenn Morris <rgm@gnu.org>
1903
1904 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1905
c1a1d7a3
EZ
19062012-05-12 Eli Zaretskii <eliz@gnu.org>
1907
1908 * lisp.mk (lisp): Add newcomment.elc.
1909
3fe7cdc8
GM
19102012-05-12 Glenn Morris <rgm@gnu.org>
1911
1912 * Makefile.in (MKDIR_P): New, set by configure.
1913 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1914
53f7d2c0
PE
19152012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1916
1917 Remove unused function hourglass_started.
1918 * dispextern.h (hourglass_started):
1919 * w32fns.c (hourglass_started):
1920 * xdisp.c (hourglass_started): Remove.
1921
75aafb17
JB
19222012-05-10 Juanma Barranquero <lekktu@gmail.com>
1923
1924 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1925 Update dependencies.
1926
12959e8e
PE
19272012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1928
97107e2e
PE
1929 * xgselect.c (xg_select): Put maxfds+1 into a var.
1930 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1931
12959e8e
PE
1932 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1933
836d29b3
DA
19342012-05-10 Dave Abrahams <dave@boostpro.com>
1935
1936 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1937 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1938
5cb67954
MA
19392012-05-09 Michael Albinus <michael.albinus@gmx.de>
1940
1941 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1942 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1943 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1944 Initialize xd_registered_buses.
1945
3478ec45
PE
19462012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1947
b263a6b0
PE
1948 Untag more efficiently if USE_LSB_TAG.
1949 This is based on a proposal by YAMAMOTO Mitsuharu in
1950 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1951 For an admittedly artificial (nth 8000 longlist) benchmark on
1952 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1953 Emacs's overall text size by 1%.
1954 * lisp.h (XUNTAG): New macro.
1955 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1956 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1957 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1958 * eval.c (Fautoload):
1959 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1960 * frame.h (XFRAME): Use XUNTAG.
1961
3478ec45
PE
1962 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1963 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1964 Remove unportable assumptions about print widths of types like
1965 dbus_uint32_t.
1966 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1967 intptr_t when converting between pointer and integer, to avoid GCC
1968 warnings about wrong width.
1969
666b903b 19702012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1971
1972 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1973 stack for each reader_thread, instead of defaulting to 8MB
1974 determined by the linker. This avoids failures in creating
1975 subprocesses on Windows 7, see the discussion in this thread:
1976 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1977
b120cc17
JC
19782012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1979
1980 Fix up display of the *Minibuf-0* buffer in the mini window.
1981 * keyboard.c (read_char): Don't clear the echo area if there's no
1982 message to clear.
1983 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1984 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1985
9a4b36f8
MA
19862012-05-07 Michael Albinus <michael.albinus@gmx.de>
1987
1988 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1989 batch mode.
1990
e5f9458f
CY
19912012-05-06 Chong Yidong <cyd@gnu.org>
1992
1993 * lisp.mk (lisp): Update.
1994
eceeb5fc 19952012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1996
1997 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1998
71873e2b
SM
19992012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2000
2001 * data.c (PUT_ERROR): New macro.
2002 (syms_of_data): Use it. Add new error type `user-error'.
2003 * undo.c (user_error): New function.
2004 (Fprimitive_undo): Use it.
2005 * print.c (print_error_message): Adjust print style for `user-error'.
2006 * keyboard.c (user_error): New function.
2007 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2008
ab0fa4e4
PE
20092012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 Do not limit current-time-string to years 1000..9999.
2012 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2013 (Fcurrent_time_string): Support any year that is supported by the
2014 underlying localtime representation. Don't use asctime, as it
2015 has undefined behavior for years outside the range -999..9999.
2016
7ed806a7
PE
20172012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 Fix race conditions involving setenv, gmtime, localtime, asctime.
2020 Without this fix, interrupts could mess up code that uses these
2021 nonreentrant functions, since setting TZ invalidates existing
2022 tm_zone or tzname values, and since most of these functions return
2023 pointers to static storage.
2024 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2025 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2026 Grow the critical sections to include not just invoking
2027 localtime/gmtime, but also accessing these functions' results
2028 including their tm_zone values if any, and any related TZ setting.
2029 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2030 so that the struct tm is saved in the critical section.
2031 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2032 motivated by the fact that memory allocation needs to be outside
2033 the critical section.
2034
0c16dfed
DA
20352012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2036
2037 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2038 with RESET_INTERVAL.
2039
2040 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2041 Remove duplicated buffer name initialization.
2042
3f83ace8
JM
20432012-05-02 Jim Meyering <jim@meyering.net>
2044
2045 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2046
c7b8541e
JM
2047 * xfns.c (x_window): Use xstrdup (Bug#11375).
2048
90207a15 20492012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2050
2051 * xdisp.c (pos_visible_p): If already at a newline from the
2052 display string before the 'while' loop, don't walk back the glyphs
2053 from it3.glyph_row. Solves assertion violation when the display
2054 string begins with a newline (egg.el). (Bug#11367)
2055
b593d6a9
AH
20562012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2057
2058 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2059 Move to simple.el.
2060
4737362e
GM
20612012-05-01 Glenn Morris <rgm@gnu.org>
2062
99cf43f9
GM
2063 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2064 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2065 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2066 All were removed before 23.1.
2067
9311dcff
GM
2068 * dispnew.c: Remove HAVE_LIBNCURSES test;
2069 it is always true on relevant platforms.
2070
4d5c6349
GM
2071 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2072 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2073
4737362e
GM
2074 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2075
74dd3a6b
AS
20762012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2077
2078 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2079 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2080 Remove.
2081
13c379ee
PE
20822012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2083
2084 Do not avoid creating empty evaporating overlays (Bug#9642).
2085 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2086 That is, do not delete an evaporating overlay if it becomes
2087 empty after its bounds are adjusted to fit within its buffer.
2088 This fix caused other problems, and I'm reverting it until we get
2089 to the bottom of them.
2090
a8e7d6d7 20912012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2092
2093 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2094
a8e7d6d7 20952012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2096
2097 * xdisp.c (pos_visible_p): If the window start position is beyond
2098 ZV, start the display from buffer beginning. Prevents assertion
2099 violation in init_iterator when the minibuffer window is scrolled
2100 via the scroll bar.
2101
2102 * window.c (window_scroll_pixel_based): Likewise.
2103
a8e7d6d7 21042012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2105
2106 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2107
a8e7d6d7 21082012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2109
2110 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2111 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2112
a8e7d6d7 21132012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2114
b593d6a9
AH
2115 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2116 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2117
1c6900d9
EZ
21182012-04-26 Eli Zaretskii <eliz@gnu.org>
2119
4c3fa1d9
EZ
2120 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2121 display element, check also the underlying string or buffer
2122 character. (Bug#11341)
2123
1c6900d9
EZ
2124 * w32menu.c: Include w32heap.h.
2125 (add_menu_item): If the call to AppendMenuW (via
2126 unicode_append_menu) fails, disable Unicode menus only if we are
2127 running on Windows 9X/Me.
2128
42bf8205
AS
21292012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2130
2131 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2132 (xgetint): Add missing shift for LSB tags.
2133
b1bac16e
MR
21342012-04-24 Martin Rudalics <rudalics@gmx.at>
2135
2136 * keyboard.c (read_char): Don't wipe echo area for select window
2137 events: These might get delayed via `mouse-autoselect-window'
2138 (Bug#11304).
2139
d69621cc
JB
21402012-04-24 Juanma Barranquero <lekktu@gmail.com>
2141
2142 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2143 manipulation of :loaded-from data.
2144
02fd101b
JB
21452012-04-23 Juanma Barranquero <lekktu@gmail.com>
2146
2147 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2148 now a cons (bug#11311).
2149
888bec30
PE
21502012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2151
89a438bd
PE
2152 Do not create empty overlays with the evaporate property (Bug#9642).
2153 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2154 if it becomes empty after its bounds are adjusted to fit within
2155 its buffer. Without this fix, in a nonempty buffer (let ((o
2156 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2157 yields an empty overlay that has the evaporate property, which is
2158 not supposed to happen.
2159
1068fe4d
PE
2160 Fix minor GTK3 problems found by static checking.
2161 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2162 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2163 (struct _EmacsFixedClass, emacs_fixed_get_type):
2164 Move decls here from emacsgtkfixed.h, since they needn't be public.
2165 (emacs_fixed_get_type): Now static.
2166 (emacs_fixed_class_init): Omit unused local.
2167 (emacs_fixed_child_type): Remove; unused.
2168 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2169 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2170 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2171 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2172 (EMACS_FIXED_GET_CLASS): Remove; unused.
2173 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2174
888bec30
PE
2175 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2176 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2177
de85e130
PE
21782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2179
d0baac98 2180 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2181 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2182 (__malloc_size_t, __malloc_ptrdiff_t):
2183 Remove. All uses removed, replaced by the definiens if needed,
2184 since we can assume C89 or better now.
2185 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2186 (protect_malloc_state, align, get_contiguous_space)
2187 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2188 (malloc_atfork_handler_child, malloc_enable_thread)
2189 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2190 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2191 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2192 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2193 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2194 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2195 Define using prototypes, not old style.
2196 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2197 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2198 (align): Don't assume that signed integer overflow wraps around.
2199 Omit unused local var.
2200 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2201 (_free_internal_nolock, memalign, mallochook, reallochook):
2202 Omit no-longer-needed casts.
2203 (valloc): Use getpagesize, not __getpagesize.
2204 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2205 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2206
de85e130
PE
2207 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2208
dcbf5805
MA
22092012-04-22 Michael Albinus <michael.albinus@gmx.de>
2210
2211 Move functions from C to Lisp. Make non-blocking method calls
2212 the default. Implement further D-Bus standard interfaces.
2213
2214 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2215 (QCdbus_request_name_allow_replacement)
2216 (QCdbus_request_name_replace_existing)
2217 (QCdbus_request_name_do_not_queue)
2218 (QCdbus_request_name_reply_primary_owner)
2219 (QCdbus_request_name_reply_in_queue)
2220 (QCdbus_request_name_reply_exists)
2221 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2222 (QCdbus_registered_serial, QCdbus_registered_method)
2223 (QCdbus_registered_signal): New Lisp objects.
2224 (XD_DEBUG_MESSAGE): Use sizeof.
2225 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2226 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2227 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2228 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2229 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2230 (xd_signature, xd_append_arg): Allow float for integer types.
2231 (xd_get_connection_references): New function.
b593d6a9
AH
2232 (xd_get_connection_address): Rename from xd_initialize.
2233 Return cached address.
dcbf5805
MA
2234 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2235 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2236 level.
2237 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2238 Return number of refcounts.
dcbf5805
MA
2239 (Fdbus_get_unique_name): Make stronger parameter check.
2240 (Fdbus_message_internal): New defun.
2241 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2242 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2243 (Fdbus_send_signal, Fdbus_register_service)
2244 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2245 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2246 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2247 (Vdbus_compiled_version, Vdbus_runtime_version)
2248 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2249 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2250 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2251 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2252 Adapt docstring.
dcbf5805 2253
52828e02
PE
22542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2255
da05bc4c
PE
2256 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2257 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2258 Do not assume ptrdiff_t is the same width as 'int'.
2259
52828e02
PE
2260 * alloc.c: Handle unusual debugging option combinations.
2261 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2262 since the two debugging options are incompatible.
2263 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2264 is defined.
2265 (mem_init, mem_insert, mem_insert_fixup):
2266 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2267 (NEED_MEM_INSERT): Remove; no longer needed.
2268
f01769f9
LL
22692012-04-22 Leo Liu <sdl.web@gmail.com>
2270
2271 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2272
5790543d
PE
22732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2274
2275 * sysdep.c [__FreeBSD__]: Minor cleanups.
2276 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2277 Use Emacs indenting style more consistently. Avoid some casts.
2278 Use 'double' consistently rather than mixing 'float' and 'double'.
2279
b91b7e4d
EW
22802012-04-21 Eduard Wiebe <usenet@pusto.de>
2281
b593d6a9
AH
2282 * sysdep.c (list_system_processes, system_process_attributes):
2283 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2284
6114eb15
AS
22852012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2286
2287 * lisp.mk (lisp): Update.
2288
2f38dff7
PE
22892012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2292 It is never used otherwise.
2293
4ae29f89
SM
22942012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2295
2296 * print.c (print_preprocess): Only check print_depth if print-circle
2297 is nil.
2298 (print_object): Check for cycles even when print-circle is nil and
2299 print-gensym is t, but only check print_depth if print-circle is nil.
2300
f30d612a
CY
23012012-04-20 Chong Yidong <cyd@gnu.org>
2302
2303 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2304 set the status to "failed" and ensure that sentinel is run.
2305
c07a4c0b 23062012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2307
2308 * process.c (Fset_process_inherit_coding_system_flag)
2309 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2310 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2311
c07a4c0b 23122012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2313
2314 * xdisp.c (string_buffer_position_lim): Limit starting position to
2315 BEGV.
2316 (set_cursor_from_row): If called for a mode-line or header-line
2317 row, return zero immediately.
2318 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2319 farther than the first row after the header line, if any.
2320 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2321 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2322
c07a4c0b 23232012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2324
4ae29f89
SM
2325 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2326 (bug#11238).
ad3a2b41 2327
c07a4c0b 23282012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 23292012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2330
2331 configure: new option --enable-gcc-warnings (Bug#11207)
2332 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2333 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2334 (ALL_CFLAGS): Use new macros rather than old.
2335 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2336 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2337 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2338 -Wunused-result, -Wunused-variable. This should go away once
2339 the Emacs and Gnulib regex code is merged.
2340 (xmalloc, xrealloc): Now static.
2341
aba027e8
PE
23422012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2343
2344 * dired.c (Fsystem_groups): Remove unused local.
2345
e5a36063
GM
23462012-04-17 Glenn Morris <rgm@gnu.org>
2347
2348 * dired.c (Fsystem_users): Doc fix.
2349
316411f0
DA
23502012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2351
2352 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2353 (syms_of_dired): Add them.
2354
9426aba4
PE
23552012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2356
b62a57be
PE
2357 Fix minor alloc.c problems found by static checking.
2358 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2359 New extern decls, to avoid calling undeclared functions.
2360 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2361 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2362 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2363 (NEED_MEM_INSERT): New macro.
2364 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2365 Remove one incorrect comment and fix another.
b62a57be 2366
3539f31f
PE
2367 Fix minor ralloc.c problems found by static checking.
2368 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2369 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2370 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2371 (r_alloc_sbrk): Now static.
2372
a041960a
PE
2373 Improve ralloc.c interface checking.
2374 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2375 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2376 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2377 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2378 [REL_ALLOC]: ... to here, to check interface.
2379 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2380 Remove decls. This fixes an "It stinks!".
2381
9426aba4
PE
2382 * alloc.c (which_symbols): Fix alignment issue / type clash.
2383
d55c12ed
AS
23842012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2385
2386 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2387 (struct Lisp_Misc_Any): Likewise.
2388 (struct Lisp_Free): Likewise.
2389 * alloc.c (union aligned_Lisp_Symbol): Define.
2390 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2391 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2392 (union aligned_Lisp_Misc): Define.
2393 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2394 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2395 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2396
b948ce8b
PE
23972012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2398
2399 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2400 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2401 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2402 * s/netbsd.h, s/sol2-6.h:
2403 Remove definition of GC_MARK_STACK, since the default now works.
2404 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2405 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2406 no longer the default.
2407 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2408
35dc09a1 24092012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2410
35dc09a1
GM
2411 * lread.c (lisp_file_lexically_bound_p):
2412 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2413
35dc09a1
GM
24142012-04-14 Eli Zaretskii <eliz@gnu.org>
2415
2416 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2417 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2418
24192012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2420
2421 * nsterm.m (constrainFrameRect): Always constrain when there is only
2422 one screen (Bug#10962).
2423
bcd86815
KB
24242012-04-13 Ken Brown <kbrown@cornell.edu>
2425
2426 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2427
c25df26e
RT
24282012-04-13 Reuben Thomas <rrt@sc3d.org>
2429
2430 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2431
0fc59f1e
DC
24322012-04-11 Daniel Colascione <dancol@dancol.org>
2433
2434 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2435 against is gone. It's better to use vfork now so that when Cygwin
2436 gains a new, working vfork, we use it automatically (bug#10398).
2437
de8c03dc
SM
24382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2439
2440 * window.c (save_window_save): Obey window-point-insertion-type.
2441
2f097256
GM
24422012-04-11 Glenn Morris <rgm@gnu.org>
2443
2444 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2445
453b951e
SM
24462012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2447
2448 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2449
75f1671a 24502012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2451
2452 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2453 (force_quit_count): New var.
2454 (handle_interrupt): Use it.
2455
2a8ce227
JB
24562012-04-10 Juanma Barranquero <lekktu@gmail.com>
2457
2458 * w32.c (w32_delayed_load): Record the full path of the library
2459 being loaded (bug#10424).
2460
935396c0
GM
24612012-04-09 Glenn Morris <rgm@gnu.org>
2462
05920a43
GM
2463 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2464 not just in the obarray, before snarfing them. (Bug#11036)
2465
935396c0
GM
2466 * Makefile.in ($(leimdir)/leim-list.el):
2467 Pass EMACS rather than BUILT_EMACS.
2468
a18ecafa
TZ
24692012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2470
2471 * process.c (make_process):
2472 * process.h: Add integer `gnutls_handshakes_tried' member to
2473 process struct.
2474
6bbef4e5
JC
2475 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2476 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2477
2478 * gnutls.c (gnutls_log_function2i): Convenience log function.
2479 (emacs_gnutls_read): Use new log functions,
2480 `gnutls_handshakes_tried' process member, and
2481 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2482 attempts per process (connection).
2483
b4d3bc10
CY
24842012-04-09 Chong Yidong <cyd@gnu.org>
2485
2486 * eval.c (Fuser_variable_p, user_variable_p_eh)
2487 (lisp_indirect_variable): Functions deleted.
2488 (Fdefvar): Caller changed.
2489
2490 * callint.c (Finteractive, Fcall_interactively):
2491 * minibuf.c (Fread_variable): Callers changed.
2492
70f4d973
EZ
24932012-04-09 Eli Zaretskii <eliz@gnu.org>
2494
2495 * xdisp.c (set_cursor_from_row): If the display string appears in
2496 the buffer at position that is closer to point than the position
2497 after the display string, display the cursor on the first glyph of
2498 the display string. Fixes cursor display when a 'display' text
2499 property immediately follows invisible text. (Bug#11094)
2500
cb3c2e3e
PE
25012012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 composite.c: use 'double' consistently
2504 * composite.c (get_composition_id): Use 'double' consistently
2505 instead of converting 'float' to 'double' and vice versa; this is
2506 easier to understand and avoids a GCC warning.
2507
fd06db5d
GM
25082012-04-09 Glenn Morris <rgm@gnu.org>
2509
50fe702a
GM
2510 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2511 preparation for dumping it with emacs. (Bug#4789)
2512 (leimdir): New variable.
2513 ($(leimdir)/leim-list.el): New rule.
2514 (emacs$(EXEEXT)): Depend on leim-list.el.
2515
fd06db5d
GM
2516 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2517 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2518 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2519
55c131ee
AS
25202012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2521
2522 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2523 proper alignment.
2524
9209588f
JB
25252012-04-07 Juanma Barranquero <lekktu@gmail.com>
2526
2527 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2528 Remove unused local variable.
2529
e3fb2efb
PE
25302012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2531
2532 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2533 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2534 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2535 objects, as mark_maybe_pointer will catch them otherwise.
2536 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2537 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2538
b5385551
PE
25392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2540
2541 Fix typo that broke non-Windows builds.
2542 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2543
9078ead6
EZ
25442012-04-07 Eli Zaretskii <eliz@gnu.org>
2545
2546 Support building on MS-Windows with libxml2.
2547
2548 * makefile.w32-in (OBJ2): Add xml.$(O).
2549 (GLOBAL_SOURCES): Add xml.c.
2550 ($(BLD)/xml.$(O)): New dependency list.
2551
2552 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2553 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2554 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2555 [!WINDOWSNT]: New macros.
2556 (init_libxml2_functions, libxml2_loaded_p): New functions.
2557 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2558 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2559 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2560 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2561 linked in).
6bbef4e5
JC
2562 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2563 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2564 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2565
2566 * emacs.c: Don't include libxml/parser.h.
2567 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2568 xmlCleanupParser directly.
2569
2570 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2571
3811fdf3
EZ
25722012-04-07 Eli Zaretskii <eliz@gnu.org>
2573
2574 * indent.c (Fvertical_motion): If there is a display string at
2575 point, use it.vpos to compute how many lines to backtrack after
2576 move_it_to point. (Bug#11133)
2577
2f8e16b2
EZ
25782012-04-06 Eli Zaretskii <eliz@gnu.org>
2579
2580 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2581 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2582 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2583 macros related to unification of CJK characters. For the details,
2584 see the discussion following the message here:
2585 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2586
3d439cd1
CY
25872012-04-04 Chong Yidong <cyd@gnu.org>
2588
2589 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2590
8bc53d00
EZ
25912012-04-01 Eli Zaretskii <eliz@gnu.org>
2592
2593 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2594 instead of alloca. (Bug#11138)
2595
3b0512a3
AS
25962012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2597
2598 * w32menu.c (is_simple_dialog): Properly check lisp types.
2599 (Bug#11141)
2600
8427ddd2
EZ
26012012-03-31 Eli Zaretskii <eliz@gnu.org>
2602
979022ef
EZ
2603 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2604 position we get to after a call to move_it_to fails the
2605 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2606 only if we wind up in a string from display property. (Bug#11063)
2607
a6b1c7cc
EZ
2608 * window.c (Fdelete_other_windows_internal): Invalidate the row
2609 and column information about mouse highlight, so that redisplay
2610 restores it after reallocating the glyph matrices. (Bug#7464)
2611
8427ddd2
EZ
2612 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2613 string comes from a `display' text property, use the buffer
2614 position of that property as if we actually saw that position in
2615 the row's glyphs.
697ba24b
EZ
2616 (move_it_by_lines): Remove the assertion that
2617 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2618 violated when there's a before-string at the beginning of a line.
2619 (Bug#11063)
8427ddd2 2620
65a0a738
EZ
26212012-03-30 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (append_space_for_newline): If the default face was
2624 remapped, use the remapped face for the appended newline.
2625 (extend_face_to_end_of_line): Use the remapped default face for
2626 extending the face to the end of the line.
2627 (display_line): Call extend_face_to_end_of_line when the default
2628 face was remapped. (Bug#11068)
2629
581355cc
EZ
26302012-03-29 Eli Zaretskii <eliz@gnu.org>
2631
2632 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2633
e8fc049f
SM
26342012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2635
2636 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2637
4fb9a543
GM
26382012-03-27 Glenn Morris <rgm@gnu.org>
2639
2640 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2641 Doc fixes.
2642
679910f1
KH
26432012-03-26 Kenichi Handa <handa@m17n.org>
2644
2645 * dispextern.h (struct glyph): Fix previous change. Change the
2646 bit length of glyphless.ch to 25 (Bug#11082).
2647
90d49b7f
CY
26482012-03-26 Chong Yidong <cyd@gnu.org>
2649
2650 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2651 (command_loop_1): Use it; inhibit selection update for
2652 handle-select-window too (Bug#8996).
2653
f514f6f0
FP
26542012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2655
e8fc049f 2656 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2657
bf43fa51
KH
26582012-03-25 Kenichi Handa <handa@m17n.org>
2659
2660 * dispextern.h (struct glyph): Change the bit length of
2661 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2662
8a0c01dd
EZ
26632012-03-24 Eli Zaretskii <eliz@gnu.org>
2664
2665 * s/ms-w32.h (tzname): Include time.h before redirecting to
2666 _tzname. Fixes the MSVC build. (Bug#9960)
2667
7d1c3a76
AS
26682012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2669
8ed79523
AS
2670 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2671 characters.
2672
7d1c3a76
AS
2673 * xterm.c (XTread_socket): Only modify handling_signal if
2674 !SYNC_INPUT. (Bug#11080)
2675
e99a9b8b
EZ
26762012-03-23 Eli Zaretskii <eliz@gnu.org>
2677
2678 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2679 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2680 when fetching a multibyte character consumes more bytes than
2681 CHAR_BYTES returns, due to unification of CJK characters in
2682 string_char. (Bug#11073)
2683
5063c0e1
TN
26842012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2685
2686 * process.c (wait_reading_process_output): Handle pty disconnect
2687 by refraining from sending oneself a SIGCHLD (bug#10933).
2688
9f851fbd
CY
26892012-03-22 Chong Yidong <cyd@gnu.org>
2690
2691 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2692
5063c0e1 2693 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2694 Mark string as coming from a prefix property.
2695 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2696 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2697
fb5b8aca
CY
26982012-03-21 Chong Yidong <cyd@gnu.org>
2699
2700 * xfaces.c (Vface_remapping_alist): Doc fix.
2701
62356a1b
EZ
27022012-03-20 Eli Zaretskii <eliz@gnu.org>
2703
2704 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2705 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2706 Doc fixes.
62356a1b 2707
025de85b
CY
27082012-03-20 Chong Yidong <cyd@gnu.org>
2709
2710 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2711 to reflect default non-nil value of redisplay-dont-pause.
2712
4827f94e
KH
27132012-03-19 Kenichi Handa <handa@m17n.org>
2714
2715 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2716 it fit in a valid range (Bug#11003).
2717
e50a24a2
EZ
27182012-03-18 Eli Zaretskii <eliz@gnu.org>
2719
2720 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2721 that is not from display property, accept the row as a "cursor
2722 row" if one of the string's character has a non-nil `cursor'
2723 property. Fixes cursor positioning when there are newlines in
2724 overlay strings, e.g. in icomplete.el. (Bug#11035)
2725
9af5ed87
PE
27262012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2727
2728 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2729
d1f55f16
CY
27302012-03-12 Chong Yidong <cyd@gnu.org>
2731
2732 * eval.c (inhibit_lisp_code): Rename from
2733 inhibit_window_configuration_change_hook; move from window.c.
2734
2735 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2736 * window.c (run_window_configuration_change_hook)
2737 (syms_of_window): Callers changed.
2738
66c5eebd
CY
27392012-03-11 Chong Yidong <cyd@gnu.org>
2740
413df973
CY
2741 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2742
66c5eebd
CY
2743 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2744
1de11f56
CY
27452012-03-10 Chong Yidong <cyd@gnu.org>
2746
2747 * frame.c (other_visible_frames): Don't assume the selected frame
2748 is visible (Bug#10955).
2749
cae07000
SM
27502012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2751
2752 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2753
89c94350
JD
27542012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2755
2756 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2757 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2758 zero (Bug#10954).
2759
999dd333
GM
27602012-03-03 Glenn Morris <rgm@gnu.org>
2761
01a6dcc8 2762 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2763
de0100f2
EZ
27642012-03-02 Eli Zaretskii <eliz@gnu.org>
2765
2766 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2767 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2768 (redisplay_window, next_element_from_string): Fix typos in
2769 comments.
3e441275
EZ
2770 (redisplay_window): Pass to move_it_vertically the margin in
2771 pixels, not in screen lines.
de0100f2 2772
96a72ee9
GM
27732012-03-02 Glenn Morris <rgm@gnu.org>
2774
2775 * buffer.c (buffer-list-update-hook): Doc fix.
2776
312508d7
EZ
27772012-02-29 Eli Zaretskii <eliz@gnu.org>
2778
2779 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2780 push_it before setting up the iterator for the first overlay
2781 string, even if we have an empty string loaded.
2782 (next_overlay_string): If there's an empty string on the iterator
2783 stack, pop the stack. (Bug#10903)
2784
27f3c637
PE
27852012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2788 Suggested by Stefan Monnier in
2789 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2790 * alloc.c (widen_to_Lisp_Object): New static function.
2791 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2792 and widening them to Lisp_Objects. This would work even if
2793 USE_LSB_TAG is defined and wide integers are used, which might
2794 happen in a future version of Emacs.
2795
3c9dfce6
CY
27962012-02-25 Chong Yidong <cyd@gnu.org>
2797
fa74b241
CY
2798 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2799 Doc fix.
2800
3c9dfce6
CY
2801 * xselect.c (Fx_selection_exists_p): Doc fix.
2802 (x_clipboard_manager_save_all): Print an informative message
2803 before saving to clipboard manager.
2804
9486df08
CY
28052012-02-24 Chong Yidong <cyd@gnu.org>
2806
2807 * keyboard.c (process_special_events): Handle all X selection
2808 requests in kbd_buffer, not just the next one (Bug#8869).
2809
f01d3321
CY
28102012-02-23 Chong Yidong <cyd@gnu.org>
2811
2812 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2813 call when setting menu-bar-lines and tool-bar-lines parameters.
2814 (unwind_create_frame_1): New helper function.
2815
2816 * window.c (inhibit_window_configuration_change_hook): New var.
2817 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2818 (syms_of_window): Initialize it.
f01d3321 2819
86b847b6
CY
28202012-02-22 Chong Yidong <cyd@gnu.org>
2821
2822 * xterm.c (x_draw_image_relief): Add missing type check for
2823 Vtool_bar_button_margin (Bug#10743).
2824
a59225b1
CY
28252012-02-21 Chong Yidong <cyd@gnu.org>
2826
2827 * fileio.c (Vfile_name_handler_alist): Doc fix.
2828
2829 * buffer.c (Fget_file_buffer): Protect against invalid file
2830 handler return value.
2831
310f5bd4
PE
28322012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2833
cb3a28cc
PE
2834 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2835 when computing $valmask.
2836
310f5bd4
PE
2837 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2838 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2839 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2840 It's useless in that case, and it can cause problems on hosts
2841 that allocate halves of EMACS_INT values separately.
2842 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2843 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2844 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2845 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2846 it avoids undefined behavior on hosts where shifting right by more
2847 than the word width has undefined behavior.
2848
2375c96a
CY
28492012-02-19 Chong Yidong <cyd@gnu.org>
2850
2851 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2852 (Funhandled_file_name_directory, Ffile_name_as_directory)
2853 (Fdirectory_file_name, Fexpand_file_name)
2854 (Fsubstitute_in_file_name): Protect against invalid file handler
2855 return values (Bug#10845).
2856
3eb49e71
EZ
28572012-02-18 Eli Zaretskii <eliz@gnu.org>
2858
2859 * .gdbinit (pitx): Fix incorrect references to fields of the
2860 iterator stack.
2861
7b926f3f
CY
28622012-02-17 Chong Yidong <cyd@gnu.org>
2863
2864 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2865
11273115
PE
28662012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2869 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2870
c3a70e2b
CY
28712012-02-15 Chong Yidong <cyd@gnu.org>
2872
2873 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2874 marked as special. Also, starting docstrings with * is obsolete.
2875
0ca43699
AS
28762012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2877
2878 * gnutls.c (emacs_gnutls_write): Fix last change.
2879
2e8f3c56
LI
28802012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2881
2882 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2883 send_process.
2884
af70074f
SM
28852012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2886
2887 * keymap.c (Fsingle_key_description): Handle char ranges.
2888
95986d52
CY
28892012-02-12 Chong Yidong <cyd@gnu.org>
2890
afd83bd1
CY
2891 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2892 as that creates a dangerous corner case.
2893
95986d52
CY
2894 * window.c (Fdelete_window_internal): Invalidate the mouse
2895 highlight (Bug#9904).
2896
bd7da63e
GM
28972012-02-12 Glenn Morris <rgm@gnu.org>
2898
2899 * xselect.c (Fx_own_selection_internal)
2900 (Fx_get_selection_internal, Fx_disown_selection_internal)
2901 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2902 * nsselect.m (Fx_own_selection_internal)
2903 (Fx_disown_selection_internal, Fx_selection_exists_p)
2904 (Fx_selection_owner_p, Fx_get_selection_internal):
2905 Sync docs and argument specs with the xselect.c versions.
2906
77abcbc2
LI
29072012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2908
2909 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2910
90b671e2
EZ
29112012-02-11 Eli Zaretskii <eliz@gnu.org>
2912
1c0ca0b7
EZ
2913 * w32select.c (Fx_selection_exists_p): Sync doc string and
2914 argument list with xselect.c. (Bug#10783)
2915
2916 * w16select.c (Fx_selection_exists_p): Sync doc string and
2917 argument list with xselect.c. (Bug#10783)
90b671e2 2918
49241268
GM
29192012-02-10 Glenn Morris <rgm@gnu.org>
2920
2921 * fns.c (Fsecure_hash): Doc fix.
2922
f998bbe7 29232012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2924
2925 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2926
0992bd9c
CY
29272012-02-07 Chong Yidong <cyd@gnu.org>
2928
2929 * buffer.c (Fbuffer_local_variables)
2930 (buffer_lisp_local_variables): Handle unbound vars correctly;
2931 don't let Qunbound leak into Lisp.
2932
af008560
GM
29332012-02-07 Glenn Morris <rgm@gnu.org>
2934
dd605cc4
GM
2935 * image.c (Fimagemagick_types): Doc fix.
2936
af008560
GM
2937 * image.c (imagemagick-render-type): Change it from a lisp object
2938 to an integer. Move the doc here from the lisp manual.
2939 Treat all values not equal to 0 the same.
2940
1449fa1d
CY
29412012-02-06 Chong Yidong <cyd@gnu.org>
2942
2943 * doc.c (store_function_docstring): Avoid applying docstring of
2944 alias to base function (Bug#2603).
2945
3723ec07
AS
29462012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2947
2948 * .gdbinit (pp1, pv1): Remove redundant defines.
2949 (pr): Use pp.
2950
79c1cc1e
CY
29512012-02-04 Chong Yidong <cyd@gnu.org>
2952
2953 * nsterm.m: Declare a global (Bug#10694).
2954
d7f29f8e
EZ
29552012-02-04 Eli Zaretskii <eliz@gnu.org>
2956
cae07000
SM
2957 * w32.c (get_emacs_configuration_options):
2958 Include --enable-checking, if specified, in the return value.
d7f29f8e 2959
3b95a6f9
MR
29602012-02-04 Martin Rudalics <rudalics@gmx.at>
2961
2962 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2963 after rounding frame sizes. (Bug#9723)
2964
d6fa96a6
EZ
29652012-02-04 Eli Zaretskii <eliz@gnu.org>
2966
2967 * keyboard.c (adjust_point_for_property): Don't position point
2968 before BEGV. (Bug#10696)
2969
df0b2940
PE
29702012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 Handle overflow when computing char display width (Bug#9496).
2973 * character.c (char_width): Return EMACS_INT, not int.
2974 (char_width, c_string_width): Check for overflow when
2975 computing the width; this is possible now that individual
2976 characters can have unbounded width. Problem introduced
2977 by merge from Emacs 23 on 2012-01-19.
2978
6bee44d6
MA
29792012-02-02 Michael Albinus <michael.albinus@gmx.de>
2980
2981 * dbusbind.c (Fdbus_register_method): Mention the return value
2982 :ignore in the docstring.
2983
44f92739
GM
29842012-02-02 Glenn Morris <rgm@gnu.org>
2985
1b9f60cc
GM
2986 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2987
44f92739
GM
2988 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2989 Unconditionally set to t. (Bug#10673)
2990 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2991 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2992 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2993
c5d3843c
KH
29942012-02-02 Kenichi Handa <handa@m17n.org>
2995
2996 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2997 0, do not call append_composite_glyph.
2998
159462d4 29992012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3000
3001 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3002 NULL (Bug#6988).
3003 (x_produce_glyphs): If the component of a composition is a null
3004 string, set it->pixel_width to 1 to avoid zero-width glyph.
3005
78cef877
EZ
30062012-02-01 Eli Zaretskii <eliz@gnu.org>
3007
3008 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3009 first 2 arguments are identical. This makes inserting large
3010 output from a subprocess an order of magnitude faster on
3011 MS-Windows, where all sbrk'ed memory is always contiguous.
3012
97897668
GM
30132012-01-31 Glenn Morris <rgm@gnu.org>
3014
3015 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3016 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3017 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3018
31fd3586
GM
30192012-01-29 Glenn Morris <rgm@gnu.org>
3020
3021 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3022
0e24a8b2
CY
30232012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3024
3025 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3026
cc0adcb0
CY
30272012-01-28 Chong Yidong <cyd@gnu.org>
3028
3029 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3030
acc28cb9
CY
30312012-01-26 Chong Yidong <cyd@gnu.org>
3032
9c69cfb7
CY
3033 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3034
acc28cb9
CY
3035 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3036 repeat counts (Bug#10507).
3037
48da7392
GM
30382012-01-26 Glenn Morris <rgm@gnu.org>
3039
3040 * lread.c (syms_of_lread): Doc fix.
3041
14af5f7f
CY
30422012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3043
3044 * coding.c (encode_designation_at_bol): Change return value to
3045 EMACS_INT.
3046
0b21c100
CY
30472012-01-25 Chong Yidong <cyd@gnu.org>
3048
3049 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3050
3c2907f7
CY
30512012-01-21 Chong Yidong <cyd@gnu.org>
3052
3053 * floatfns.c (Fcopysign): Make the second argument non-optional,
3054 since nil is not allowed anyway.
3055
959ad23f
AS
30562012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3057
3058 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3059 (send_process): Likewise.
3060
34a02f46
MR
30612012-01-19 Martin Rudalics <rudalics@gmx.at>
3062
3063 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3064 (Vwindow_persistent_parameters): Do not use Qstate.
3065 Rewrite doc-strings.
34a02f46 3066
1259009a 30672012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3068
3069 * character.c (char_width): New function.
70d4fdf6
GM
3070 (Fchar_width, c_string_width, lisp_string_width):
3071 Use char_width (Bug#9496).
25ed9e61 3072
6a6ee00d
MR
30732012-01-16 Martin Rudalics <rudalics@gmx.at>
3074
3075 * window.c (Vwindow_persistent_parameters): New variable.
3076 (Fset_window_configuration, save_window_save): Handle persistent
3077 window parameters.
3078
c85efaf7
EZ
30792012-01-14 Eli Zaretskii <eliz@gnu.org>
3080
3081 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3082 thrashing the stack of the thread. (Bug#9087)
3083
5944709e
PE
30842012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3085
3086 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3087
e71f5d99
EZ
30882012-01-11 Eli Zaretskii <eliz@gnu.org>
3089
3090 * xdisp.c (rows_from_pos_range): Handle the case where the
3091 highlight ends on a newline. (Bug#10464)
3092 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3093 he end column for display of highlight that ends on a newline
3094 before a R2L line.
3095
ce316182
GM
30962012-01-11 Glenn Morris <rgm@gnu.org>
3097
3098 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3099 from load-path also when installation-directory is nil. (Bug#10208)
3100
5b43da69
GM
31012012-01-10 Glenn Morris <rgm@gnu.org>
3102
74cc8ff9
GM
3103 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3104
7d8d6e4e
GM
3105 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3106 Update template values to be closer to their typical values these days.
5b43da69 3107
a0db8d43
EZ
31082012-01-09 Eli Zaretskii <eliz@gnu.org>
3109
3110 * xdisp.c (rows_from_pos_range): Accept additional argument
3111 DISP_STRING, and accept any glyph in a row whose object is that
3112 string as eligible for mouse highlight. Fixes mouse highlight of
3113 display strings from overlays. (Bug#10464)
3114
9a0115ab 31152012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3116
b9110d6a 3117 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3118 * fileio.c (auto_saving_dir_umask): New static var.
3119 (Fmake_directory_internal): Use it.
3120 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3121 creating the directory. The old code temporarily assigns
3122 too-generous permissions to the directory.
3123 (do_auto_save_eh): Clear it.
b9110d6a 3124 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3125 that the var is always cleared.
3126
6c1bd3f3
EZ
31272012-01-07 Eli Zaretskii <eliz@gnu.org>
3128
3129 * search.c (scan_buffer): Pass character positions to
3130 know_region_cache, not byte positions. (Bug#6540)
3131
069d2b50
L
31322012-01-07 LynX <_LynX@bk.ru> (tiny change)
3133
3134 * w32.c (sys_rename): Report EXDEV when rename of a directory
3135 fails because the target is on another logical disk. (Bug#10284)
3136
75bf0d33
DB
31372012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3138
3139 * xterm.c (x_embed_request_focus): New function.
3140
3141 * xterm.h: Add prototype.
3142
3143 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3144
1c6e5a32
GM
31452012-01-05 Glenn Morris <rgm@gnu.org>
3146
3147 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3148
651e947e
EZ
31492012-01-01 Eli Zaretskii <eliz@gnu.org>
3150
3151 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3152 Load gnutls_transport_set_lowat only if GnuTLS version is below
3153 2.11.1.
3154 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3155 GnuTLS versions below 2.11.1.
3156
3778cdd8
AL
31572011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3158
3159 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3160 to the doc string advising against its use for altering the way
3161 windows are scrolled.
3162
0e5317f7
KH
31632011-12-28 Kenichi Handa <handa@m17n.org>
3164
3165 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3166 coding-system ASCII compatible only when it does not produce BOM
3167 on encoding (Bug#10383).
3168
93d5ca1f
JD
31692011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3170
3171 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3172 can scroll.
3173 (create_and_show_popup_menu): Always use menu_position_func for
3174 Gtk3 (Bug#10361).
3175
ca22b785
AS
31762011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3177
3178 * callint.c (Fcall_interactively): Don't truncate prompt string.
3179
d048e1e6
EZ
31802011-12-23 Eli Zaretskii <eliz@gnu.org>
3181
3182 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3183 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3184 resumed from there (after widening). (Bug#10360)
d048e1e6 3185
5ccaba1f
JD
31862011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3187
3188 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3189
204ee57f
JD
31902011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3191
b81d40f0
JB
3192 * nsterm.m (x_free_frame_resources):
3193 Release f->output_data.ns->miniimage.
204ee57f
JD
3194 (ns_index_color): Fix indentation. Do not retain
3195 color_table->colors[i].
3196
3197 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3198 before returning.
3199
3200 * nsfns.m (x_set_background_color): Assign return value from
3201 ns_index_color to face-background instead of NSColor*.
3202 (ns_implicitly_set_icon_type): Fix indentation.
3203 Change assignment in for loop to comparison.
3204
3205 * emacs.c (ns_pool): New variable.
3206 (main): Assign ns_pool.
3207 (Fkill_emacs): Call ns_release_autorelease_pool.
3208
3209 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3210 autorelease fdesc, release fdAttrs and tdict.
3211 (ns_get_covering_families): Release charset.
3212 (ns_findfonts): Release NSFontDescriptor created with new.
3213 (ns_uni_to_glyphs): Fix indentation.
3214 (setString): Release attrStr before assigning new value.
3215
c803b2b7
JD
32162011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3217
678f4426
JD
3218 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3219 and NS_IMPL_COCOA.
3220 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3221 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3222
cd394be1 32232011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3224
5fecd5fc
JD
3225 * nsterm.m (ns_term_init): Subscribe for notifications
3226 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3227 to method trackingNotification in EmacsMenu.
3228
3229 * nsmenu.m (trackingMenu): New variable.
3771cb17 3230 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3231 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3232 from Aquamacs (Bug#7030).
678f4426
JD
3233
32342011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3235
c803b2b7
JD
3236 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3237 (symbol_to_nsstring): Fix indentation.
3238 (ns_symbol_to_pb): New function.
cae07000
SM
3239 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3240 (Fns_rotate_cut_buffers_internal): Remove.
3241 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3242 Fns_store_cut_buffer_internal.
3243 (ns_get_foreign_selection, Fx_own_selection_internal)
3244 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3245 (Fns_get_selection_internal, Fns_store_selection_internal):
3246 Use ns_symbol_to_pb and check if return value is nil.
3247 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3248 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3249 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3250 renamed to Sns_store_selection_internal.
3251 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3252 and remove this function.
3253 (ns_handle_selection_clear): Remove, never used.
3254 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3255 here.
3256
e1b01a3a
KB
32572011-12-17 Ken Brown <kbrown@cornell.edu>
3258
3259 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3260 GID is unknown (Bug#10257).
3261
2adb6e85
PE
32622011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3265 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3266 which caused a build failure on GNU/Linux IA-64. This problem was
3267 introduced by my 2011-10-07 patch.
3268
d1d7b339
JL
32692011-12-15 Juri Linkov <juri@jurta.org>
3270
3271 * image.c (imagemagick_error): New function. (Bug#10112)
3272 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3273 Use `imagemagick_error' where ImageMagick functions return
3274 `MagickFalse'.
3275 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3276 proper order.
3277
100d5755
KH
32782011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3279
3280 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3281 fill background (Bug#8992).
3282
454592a6
MR
32832011-12-13 Martin Rudalics <rudalics@gmx.at>
3284
3285 * window.c (Vwindow_combination_resize)
3286 (Vwindow_combination_limit): Use t instead of non-nil in
3287 doc-strings.
61d4b438
MR
3288 (Vrecenter_redisplay): Add first sentence of doc-string on
3289 separate line.
53524d93 3290 (Frecenter): Fix doc-string typo.
454592a6 3291
3633e3aa
KH
32922011-12-11 Kenichi Handa <handa@m17n.org>
3293
3294 * coding.c (Funencodable_char_position): Pay attention to the
3295 buffer text relocation (Bug#9389).
3296
7b9d523a 32972011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3298
7b9d523a
JD
3299 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3300 gtk_init (Bug#10100).
3301
b73189c6
EZ
33022011-12-10 Eli Zaretskii <eliz@gnu.org>
3303
3304 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3305 IT->string is nil. (Bug#10263)
3306
f7dfe5d6
JD
33072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3308
83faebb4
JD
3309 * nsterm.h (x_free_frame_resources): Declare.
3310
f7dfe5d6
JD
3311 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3312 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3313
3314 * nsterm.h (ns_get_defaults_value): Declare.
3315
3316 * nsterm.m (ns_default): Call ns_get_defaults_value.
3317
7cd4e72c
EZ
33182011-12-09 Eli Zaretskii <eliz@gnu.org>
3319
3320 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3321 (Bug#10170)
3322
b34d7317
YM
33232011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3324
3325 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3326 that where the value of an _OBJC_* symbol points to is in the .bss
3327 section (Bug#10240).
3328
76470ad1
KH
33292011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3330
3331 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3332 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3333
745fff94
KH
33342011-12-08 Kenichi Handa <handa@m17n.org>
3335
3336 * ftfont.c (get_adstyle_property): Fix previous change
3337 (Bug#10233).
3338
6e44397c
JB
33392011-12-07 Juanma Barranquero <lekktu@gmail.com>
3340
3341 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3342 dirs from the default value of EMACSLOADPATH (bug#10208).
3343
7efa6272
GM
33442011-12-07 Glenn Morris <rgm@gnu.org>
3345
3346 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3347 installation and source directories as well. (Bug#10208)
3348
f6fc4d87
CY
33492011-12-06 Chong Yidong <cyd@gnu.org>
3350
3351 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3352
2bf26180
GM
33532011-12-06 Glenn Morris <rgm@gnu.org>
3354
3355 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3356 as an error, not just -1. (Bug#10217)
3357
3a6ad4f0
CY
33582011-12-05 Chong Yidong <cyd@gnu.org>
3359
3360 * keyboard.c (process_special_events): New function.
3361 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3362
75a3b399
PE
33632011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3364
3365 * coding.c (encode_designation_at_bol): Don't use uninitialized
3366 local variable (Bug#9318).
3367
c3c9e25e
KH
33682011-12-05 Kenichi Handa <handa@m17n.org>
3369
3370 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3371 return Qnil (Bug#8046, Bug#10193).
3372
5eb05ea3
KH
33732011-12-05 Kenichi Handa <handa@m17n.org>
3374
3375 * coding.c (encode_designation_at_bol): New args charbuf_end and
3376 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3377 (coding_set_source): Return how many bytes coding->source was
3378 relocated.
3379 (coding_set_destination): Return how many bytes
3380 coding->destination was relocated.
3381 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3382 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3383
33842011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3385
3386 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3387 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3388 macro (Bug#9318).
3389
33902011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3391
3392 The following changes are to fix Bug#9318.
3393
a79703f5 3394 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3395 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3396 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3397 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3398
7dbda6df
JB
33992011-12-05 Juanma Barranquero <lekktu@gmail.com>
3400
3401 * lisp.h (process_quit_flag): Fix external declaration.
3402
6d5eb5b0
SM
34032011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3404
3405 Don't macro-inline non-performance-critical code.
3406 * eval.c (process_quit_flag): New function.
3407 * lisp.h (QUIT): Use it.
3408
a0c3fad0
JD
34092011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3410
3411 * nsfns.m (get_geometry_from_preferences): New function.
3412 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3413
6c07aac2
AS
34142011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3415
3416 * emacs.c (Qkill_emacs): Define.
3417 (syms_of_emacs): Initialize it.
3418 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3419 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3420 (quit_throw_to_read_char): Add parameter `from_signal'.
3421 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3422 * lisp.h (QUIT): Call Fkill_emacs if requested.
3423
c052ead4
JD
34242011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3425
3426 * widget.c (update_wm_hints): Return if wmshell is null.
3427 (widget_update_wm_size_hints): New function.
3428
3429 * widget.h (widget_update_wm_size_hints): Declare.
3430
3431 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3432 widget_update_wm_size_hints (Bug#10104).
3433
9e49252b
EZ
34342011-12-03 Eli Zaretskii <eliz@gnu.org>
3435
3436 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3437 before a newline, prepare the bidi iterator for consuming the
3438 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3439 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3440
02b16839
JL
34412011-12-02 Juri Linkov <juri@jurta.org>
3442
3443 * search.c (Fword_search_regexp): New Lisp function created from
3444 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3445 (Fword_search_backward, Fword_search_forward)
3446 (Fword_search_backward_lax, Fword_search_forward_lax):
3447 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3448 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3449
0068070e
SM
34502011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3451
3452 * fileio.c (Finsert_file_contents): Move after-change-function call
3453 to before the "handled:" label, since all "goto handled" appear in
3454 cases where the *-change-functions have already been properly called
3455 (bug#10117).
3456
3360a3fc
AS
34572011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3458
3459 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3460 waiting for input. (Bug#10169)
3461
73d6c093
EZ
34622011-11-30 Eli Zaretskii <eliz@gnu.org>
3463
3464 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3465 verifies glyph row's hash code--we have just reallocated the
3466 glyphs, so their contents can be complete garbage. (Bug#10164)
3467
febe6bea
JB
34682011-11-30 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3471
801a4313
EZ
34722011-11-30 Eli Zaretskii <eliz@gnu.org>
3473
3474 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3475 attributes are tested _before_ calling verify_row_hash, to protect
3476 against GCC re-ordering of the tests. (Bug#10164)
3477
2b56b87e
JD
34782011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3479
3480 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3481
3482 * xterm.c (handle_one_xevent): Only set async_visible and friends
3483 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3484 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3485 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3486
dbf31225
PE
34872011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3488
3489 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3490 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3491 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3492 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3493 All uses changed to use GCPRO1 etc.
3494 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3495 Revert to old implementation (i.e., before 2011-03-11).
3496
1305621b
YM
34972011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3498
3499 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3500 of scroll runs so as to avoid assigning disabled bogus rows and
3501 unnecessary graphics copy operations.
3502
8c9afb46
EZ
35032011-11-27 Eli Zaretskii <eliz@gnu.org>
3504
3505 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3506 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3507 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3508 (malloc, free, realloc, calloc): Redirect to e_* only when
3509 compiling Emacs.
3510
3511 * lisp.h (GCTYPEBITS): Move before first use.
3512 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3513 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3514 this macro definition.
3515
3516 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3517 _MSC_VER.
3518
54e9e3bf
JD
35192011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3520
6d5eb5b0
SM
3521 * gtkutil.c (xg_create_frame_widgets):
3522 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3523 present with Gtk+ 2.0.
3524
83aca1cb
PE
35252011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 * fileio.c (Finsert_file_contents): Undo previous change; see
3528 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3529
5b76caa4
PE
35302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3531
3532 Rename locals to avoid shadowing.
3533 * fileio.c (Finsert_file_contents):
3534 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3535 * process.c (wait_reading_process_output):
3536 Rename inner 'proc' to 'p' to avoid shadowing.
3537 Indent for consistency with usual Emacs style.
3538
8c535114
EZ
35392011-11-25 Eli Zaretskii <eliz@gnu.org>
3540
3541 * xdisp.c (redisplay_window): If cursor row is not fully visible
3542 after recentering, and scroll-conservatively is set to a large
3543 number, scroll window by a few more lines to make the cursor fully
3544 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3545 (start_display): Don't move to the next line if the display should
3546 start at a newline that is part of a display vector or an overlay
3547 string. (Bug#10119)
8c535114 3548
fa4fdb5c
JL
35492011-11-24 Juri Linkov <juri@jurta.org>
3550
3551 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3552 after the `MagickPingImage' call. (Bug#10112)
3553
90ec88df
CY
35542011-11-23 Chong Yidong <cyd@gnu.org>
3555
3556 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3557
56e2e794
MR
35582011-11-23 Martin Rudalics <rudalics@gmx.at>
3559
3560 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3561 making another buffer current. (Bug#10114)
3562
b6e64c41
GM
35632011-11-23 Glenn Morris <rgm@gnu.org>
3564
3565 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3566
6b21de18
CY
35672011-11-23 Chong Yidong <cyd@gnu.org>
3568
3569 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3570 using it (Bug#5984).
3571
b12cd789
EZ
35722011-11-22 Eli Zaretskii <eliz@gnu.org>
3573
3574 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3575 and header-lines, as they don't have one computed for them.
3576 (Bug#10098)
3577
3578 * .gdbinit (prow): Make displayed values more self-explaining.
3579 Add row's hash code.
3580
261b6fd4
LMI
35812011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3582
3583 * process.c (wait_reading_process_output): Fix asynchrounous
3584 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3585 (wait_reading_process_output): Add comment and URL.
261b6fd4 3586
e7cfd277
JD
35872011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3588
3589 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3590
a9b9b7f5
CY
35912011-11-21 Chong Yidong <cyd@gnu.org>
3592
3593 * window.c (Fnext_window, Fprevious_window): Doc fix.
3594
b0d15b4f
SM
35952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3596
3597 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3598
fe7a3057
JB
35992011-11-20 Juanma Barranquero <lekktu@gmail.com>
3600
3601 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3602
d2999b1a
MR
36032011-11-20 Martin Rudalics <rudalics@gmx.at>
3604
3605 * window.c (Fset_window_combination_limit): Rename argument
3606 STATUS to LIMIT.
3607 (Vwindow_combination_limit): Remove "status" from doc-string.
3608
d5ff9cd0
AS
36092011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3610
3611 * m/ibms390.h: Remove.
3612 * m/ibms390x.h: Don't include "ibms390.h".
3613
a5bb9bd3
SM
36142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3615
3616 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3617 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3618
cd1181db
JB
36192011-11-20 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * casetab.c (Fset_case_table):
3622 * charset.c (Fcharset_after): Fix typos.
3623
615a3b8d 36242011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3625
17e845af
PE
3626 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3627 Otherwise, valgrind does not work on some platforms.
3628 Problem reported by Andreas Schwab in
6a0bf43d
PE
3629 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3630 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3631 is set, removing the need for VIRT_ADDRESS_VARIES.
3632 (PURE_P): Use a more-efficient implementation that needs just one
3633 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3634 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3635 to 4 (xorl, subq, cmpq, setbe).
3636 * alloc.c (pure): Always extern now, since that's the
3637 VIRT_ADDR_VARIES behavior.
3638 (PURE_POINTER_P): Use a single comparison, not two, for
3639 consistency with the new puresize.h.
3640 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3641 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3642 Remove VIRT_ADDR_VARIES no longer needed.
3643
f8fe6f96
EZ
36442011-11-19 Eli Zaretskii <eliz@gnu.org>
3645
3646 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3647 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3648 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3649 behave as if the cursor position were at the window margin.
3650
3651 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3652 and the cursor position is out of bounds, behave as if the cursor
3653 position were at the window margin. (Bug#10075)
3654
df05a53c
CY
36552011-11-18 Chong Yidong <cyd@gnu.org>
3656
3657 * window.c (Fwindow_combination_limit): Make first argument
3658 non-optional, since it is meaningless for live windows like the
3659 selected window.
61ccba97 3660
2071918e
DA
36612011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3662
3663 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3664
b50a28de
SM
36652011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3666
3667 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3668 (graft_intervals_into_buffer): Simplify.
3669
015137db
EZ
36702011-11-18 Eli Zaretskii <eliz@gnu.org>
3671
3672 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3673 hash values of the two rows.
3674 (copy_row_except_pointers): Preserve the used[] arrays and the
3675 hash values of the two rows. (Bug#10035)
68c95424 3676 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3677
3678 * xdisp.c (row_hash): New function, body extracted from
3679 compute_line_metrics.
3680 (compute_line_metrics): Call row_hash, instead of computing the
3681 hash code inline.
3682
3683 * dispnew.c (verify_row_hash): Call row_hash for computing the
3684 hash code of a row, instead of duplicating code from xdisp.c.
3685
3686 * dispextern.h (row_hash): Add prototype.
3687
a2addb04
TH
36882011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3689
3690 * frame.c (delete_frame): Don't delete the terminal when the last
3691 X frame is closed if emacs is built with GTK toolkit.
3692
df85d315
JB
36932011-11-17 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3696
a0c2d0ae
MR
36972011-11-17 Martin Rudalics <rudalics@gmx.at>
3698
3699 * window.c (Vwindow_splits): Rename to
3700 Vwindow_combination_resize. Suggested by Juri Linkov.
3701 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3702 of Vwindow_splits.
3703
58179cce
JB
37042011-11-16 Juanma Barranquero <lekktu@gmail.com>
3705
7877f373
JB
3706 * nsfns.m (Fns_font_name):
3707 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3708
b6f67890
MR
37092011-11-16 Martin Rudalics <rudalics@gmx.at>
3710
3711 * window.h (window): Rename slot "nest" to "combination_limit".
3712 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3713 (Fset_window_nest): Rename to Fset_window_combination_limit.
3714 (Vwindow_nest): Rename to Vwindow_combination_limit.
3715 (recombine_windows, make_parent_window, make_window)
3716 (Fsplit_window_internal, saved_window)
3717 (Fset_window_configuration, save_window_save): Rename all
3718 occurrences of window_nest to window_combination_limit.
3719
c7015153
JB
37202011-11-15 Juanma Barranquero <lekktu@gmail.com>
3721
3722 * image.c (imagemagick_load_image): Fix typo.
3723
322ad6ec
EZ
37242011-11-14 Eli Zaretskii <eliz@gnu.org>
3725
3726 * xdisp.c (display_line): Move the call to
3727 highlight_trailing_whitespace before the call to
3728 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3729 faces of all the glyphs to compute ROW's hash value.
3730 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3731
f067b8ec
JB
37322011-11-14 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3735 just return (bug#10044).
3736
1e5b2111
EZ
37372011-11-12 Eli Zaretskii <eliz@gnu.org>
3738
7ef3cbd5
EZ
3739 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3740 with user-defined heap size. Bump the default size of the temacs
3741 heap to 27MB, to avoid memory warning when running temacs.
3742 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3743
1e5b2111
EZ
3744 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3745 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3746 (verify_row_hash) [XASSERTS]: New function.
3747 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3748 that the hash value of glyph rows is correct.
1e5b2111 3749
89d61221
MR
37502011-11-12 Martin Rudalics <rudalics@gmx.at>
3751
3752 * window.h (window): Remove splits slot.
3753 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3754 (Fdelete_other_windows_internal, make_parent_window)
3755 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3756 (Fset_window_configuration, save_window_save): Don't deal with
3757 split status of windows.
3758 (saved_window): Remove splits slot.
3759 (Vwindow_splits): Rewrite doc-string.
3760
97f18cc8
JD
37612011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3762
3763 * xfns.c (unwind_create_frame):
3764 * nsfns.m (unwind_create_frame):
3765 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3766 Vframe_list (Bug#9999).
3767
22a648b4
DA
37682011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3769
0b381c7e 3770 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3771
659afede
KH
37722011-11-11 Kenichi Handa <handa@m17n.org>
3773
3774 * callproc.c (Fcall_process): Set the member dst_multibyte of
3775 process_coding.
3776
9ac0394b
KH
37772011-11-11 Johan Bockgård <bojohan@gnu.org>
3778
3779 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3780 avoid a crash (bug#9496).
3781
2fbdc249
CY
37822011-11-09 Chong Yidong <cyd@gnu.org>
3783
3784 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3785 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3786
ac6b1f81
PE
37872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3788
3789 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3790
09db192c
PE
37912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3792
3793 Avoid some portability problems by eschewing 'extern inline' functions.
3794 The trivial performance wins aren't worth the portability hassles; see
3795 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3796 et seq.
3797 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3798 (window_box_width, window_box_left, window_box_left_offset)
3799 (window_box_right, window_box_right_offset): Undo previous change,
3800 by removing the "extern"s.
3801 * intervals.c (adjust_intervals_for_insertion)
3802 (adjust_intervals_for_deletion): Undo previous change,
3803 making these static again.
3804 (offset_intervals, temp_set_point_both, temp_set_point)
3805 (copy_intervals_to_string): No longer inline.
3806 * xdisp.c (window_text_bottom_y, window_box_width)
3807 (window_box_height, window_box_left_offset)
3808 (window_box_right_offset, window_box_left, window_box_right)
3809 (window_box): No longer inline.
3810
105216ed
CY
38112011-11-08 Chong Yidong <cyd@gnu.org>
3812
3813 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3814 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3815 Signal an error if not a live window.
105216ed
CY
3816 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3817 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3818
ae9e237f
JB
38192011-11-07 Juanma Barranquero <lekktu@gmail.com>
3820
3821 * lisp.h (syms_of_abbrev): Remove declaration.
3822 Reported by CHENG Gao <chenggao@royau.me>.
3823
c7aa8333
EZ
38242011-11-07 Eli Zaretskii <eliz@gnu.org>
3825
3826 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3827 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3828 of temacs in GUI mode.
3829
be7f5545
MR
38302011-11-07 Martin Rudalics <rudalics@gmx.at>
3831
3832 * window.h: Declare delete_all_child_windows instead of
3833 delete_all_subwindows.
3834 * window.c (Fwindow_nest, Fset_window_nest)
3835 (Fset_window_new_total, Fset_window_new_normal)
3836 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3837 (delete_all_subwindows): Rename to delete_all_child_windows.
3838 (Fdelete_other_windows_internal, Fset_window_configuration):
3839 Call delete_all_child_windows instead of delete_all_subwindows.
3840 * frame.c (delete_frame): Call delete_all_child_windows instead
3841 of delete_all_subwindows.
3842
ca78dc43
PE
38432011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3844
3845 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3846 This is also needed for porting to any host where GC_MARK_STACK is
3847 not GC_MAKE_GCPROS_NOOPS.
3848 (which_symbols): Use it.
3849
a0241d01
KH
38502011-11-07 Kenichi Handa <handa@m17n.org>
3851
3852 * coding.c (coding_set_destination): Check coding->src_pos only
3853 when coding->src_object is a buffer (bug#9910).
3854
3855 * process.c (send_process): Set the member src_multibyte of coding
3856 to 0 (bug#9911) when sending a unibyte text.
3857
3858 * callproc.c (Fcall_process): Set the member src_multibyte of
3859 process_coding to 0 (bug#9912).
3860
a64bfdfa 38612011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3862
3863 * xmenu.c (cleanup_widget_value_tree): New function.
3864 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3865 calling free_menubar_widget_value_tree directly (Bug#9830).
3866
cb41b32a
PE
38672011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3868
3869 Fix some portability problems with 'inline'.
3870 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3871 (window_box_width, window_box_left, window_box_left_offset)
3872 (window_box_right, window_box_right_offset): Declare extern.
3873 Otherwise, these inline functions do not conform to C99 and
3874 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3875 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3876 * intervals.c (adjust_intervals_for_insertion)
3877 (adjust_intervals_for_deletion): Now extern, because otherwise the
3878 extern inline functions 'offset_intervals' couldn't refer to it.
3879 (static_offset_intervals): Remove.
3880 (offset_intervals): Rewrite using the old contents of
3881 static_offset_intervals. The old version didn't conform to C99
3882 because an extern inline function contained a reference to an
3883 identifier with static linkage.
3884
b7041366
AS
38852011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3886
3887 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3888 GC.
3889
88a37c4d
EZ
38902011-11-06 Eli Zaretskii <eliz@gnu.org>
3891
3892 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3893 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3894 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3895 return Qleft_to_right.
3896
49745b39
CY
38972011-11-06 Chong Yidong <cyd@gnu.org>
3898
3899 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3900 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3901 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3902 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3903 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3904 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3905 (Fwindow_vscroll): Doc fix.
3906 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3907 argument, since it makes no sense to pass a live window and for
3908 consistency with window-child.
3909
1f05cd82
CS
39102011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3911
3912 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3913 support MSVC.
3914
22610910
JR
39152011-11-05 Jason Rumney <jasonr@gnu.org>
3916
3917 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3918 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3919 fonts (Bug#6029).
3920 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3921 bitwise arithmetic preventing use of unicode-sip and non-truetype
3922 opentype fonts.
3923
a06776b2
EZ
39242011-11-05 Eli Zaretskii <eliz@gnu.org>
3925
3ad924ba
EZ
3926 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3927 "emacs"-only part.
3928
a06776b2
EZ
3929 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3930 initialization code to keep similarity to xfns.c after changes
3931 from 2011-11-05.
3932
c9e7db78
JD
39332011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3934
a97f8f3f
JD
3935 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3936 (unwind_create_frame): New function (Bug#9943).
3937 (Fx_create_frame): Restructure code to be more similar to the one in
3938 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3939 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3940 Move terminal->reference_count++ just before making the frame official
3941 (Bug#9943).
3942
3943 * nsterm.m (x_free_frame_resources): New function.
3944 (x_destroy_window): Move code to x_free_frame_resources.
3945
c9e7db78 3946 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3947 (Fx_create_frame, x_create_tip_frame):
3948 Move terminal->reference_count++ just before making the frame
75f1671a 3949 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3950 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3951
a6fc3b5c
EZ
39522011-11-05 Eli Zaretskii <eliz@gnu.org>
3953
3954 Support MSVC build with newer versions of Visual Studio.
3955 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3956 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3957 nt/gmake.defs.
3958
3959 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3960 which are not supported by MSVC.
3961 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3962 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3963 bitfields.
3964 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3965 types in bitfields.
3966 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3967
3968 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3969
58179cce 39702011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3971
3972 Support MSVC build with newer versions of Visual Studio.
3973 * w32.c: Don't include w32api.h for MSVC.
3974 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3975
3976 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3977 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3978 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3979 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3980 e_* cousins.
3981 (alloca) [_MSC_VER]: Define to _alloca.
3982
3983 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3984
3985 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3986
a58c13ed
EZ
39872011-11-04 Eli Zaretskii <eliz@gnu.org>
3988
3989 * xdisp.c (note_mouse_highlight): If either of
3990 previous/next-single-property-change returns nil, treat that as
3991 the beginning or the end of the buffer. (Bug#9955)
3992
fe0b6370
JD
39932011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3994
a58c13ed 3995 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3996 label is not null (Bug#9951).
3997 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3998 may be NULL.
3999
89bd5ee1
EZ
40002011-11-04 Eli Zaretskii <eliz@gnu.org>
4001
4002 * window.c (Fwindow_body_size): Mention in the doc string that the
4003 return value is in frame's canonical units. (Bug#9949)
4004
84c3edb9
EZ
40052011-11-03 Eli Zaretskii <eliz@gnu.org>
4006
4e2fb5c7
EZ
4007 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4008
84c3edb9 4009 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4010 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4011 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4012
bc17a887
EZ
40132011-11-01 Eli Zaretskii <eliz@gnu.org>
4014
4015 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4016 Don't stop backward scan on the continuation glyph, even though
4017 its CHARPOS is positive.
6d5eb5b0
SM
4018 (mouse_face_from_buffer_pos, note_mouse_highlight):
4019 Rename cover_string to disp_string.
bc17a887 4020
4ee88440
MR
40212011-11-01 Martin Rudalics <rudalics@gmx.at>
4022
4023 * window.c (temp_output_buffer_show): Don't use
4024 Vtemp_buffer_show_specifiers.
4025 (Vtemp_buffer_show_specifiers): Remove unused variable.
4026
c2ff3c02
EZ
40272011-10-30 Eli Zaretskii <eliz@gnu.org>
4028
4029 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4030 past the beginning of the current glyph matrix.
4031
58179cce 40322011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4033
4034 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4035 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4036 HAVE_GTK3 (Bug#9869).
b77a6a7f 4037
3b574623
JD
4038 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4039 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4040
b77a6a7f
JD
4041 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4042
4043 * xterm.c: Declare x_handle_net_wm_state to return int.
4044 (handle_one_xevent): Check if we are iconified but don't have
4045 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4046 (get_current_wm_state): Return non-zero if not hidden,
4047 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4048 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4049 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4050 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4051
196e41e4
PE
40522011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4053
4054 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4055 so that this new function doesn't get optimized away by a
4056 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4057
021f2e1a
AS
40582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4059
4060 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4061
8b058d44
EZ
40622011-10-29 Eli Zaretskii <eliz@gnu.org>
4063
4064 Fix the `xbytecode' command.
4065 * .gdbinit (xprintbytestr): New command.
b50a28de 4066 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4067 (xbytecode): Print the byte-code string as well.
4068
4452fb80
EZ
40692011-10-29 Kim Storm <storm@cua.dk>
4070
8b058d44
EZ
4071 * alloc.c (which_symbols): New function.
4072
21b72067
AS
40732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4074
4075 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4076 line. (Bug#9903)
4077
83ed7b5c
GM
40782011-10-29 Glenn Morris <rgm@gnu.org>
4079
4080 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4081 Not clear what it was for, and it causes various bugs. (Bug#9839)
4082
5a7a728b
EZ
40832011-10-28 Eli Zaretskii <eliz@gnu.org>
4084
4085 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4086 possible random value that matches one of those tested as
4087 condition to clear the mouse face.
4088
d3d0842f
CY
40892011-10-28 Chong Yidong <cyd@gnu.org>
4090
4091 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4092
31b39d13
DN
40932011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4094
4095 * window.c (make_window): Initialize phys_cursor_on_p.
4096
9aba6043
SM
40972011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4098
4099 * lisp.h (struct Lisp_Symbol): Update comments.
4100
c20992f4
JB
41012011-10-28 Juanma Barranquero <lekktu@gmail.com>
4102
4103 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4104
db4f02f2
EZ
41052011-10-28 Eli Zaretskii <eliz@gnu.org>
4106
4107 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4108 <oslsachem@gmail.com> for helping to debug this.
4109
4110 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4111 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4112 (g_b_init_get_glyph_outline_w): New static variables.
4113 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4114 (GetGlyphOutlineW_Proc): New typedefs.
4115 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4116 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4117 New functions.
4118 (w32font_open_internal, compute_metrics):
4119 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4120 instead of calling the "wide" APIs directly.
4121
4122 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4123
4124 * w32.h (syms_of_w32font): Add prototype.
4125
87e68db4
JB
41262011-10-27 Juanma Barranquero <lekktu@gmail.com>
4127
4128 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4129 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4130 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4131 (Fmove_to_window_line): Doc fix.
4132
435c1d67
CY
41332011-10-27 Chong Yidong <cyd@gnu.org>
4134
4135 * process.c (make_process): Set gnutls_state to NULL.
4136
4137 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4138 non-NULL, regardless of GNUTLS_INITSTAGE.
4139 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4140 an error. Set process slots as soon as we allocate them.
4141
4142 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4143
9c6c6f49
CY
41442011-10-27 Chong Yidong <cyd@gnu.org>
4145
9aba6043
SM
4146 * gnutls.c (emacs_gnutls_deinit): New function.
4147 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4148 (Fgnutls_deinit, Fgnutls_boot): Use it.
4149
4150 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4151 (deactivate_process): Call emacs_gnutls_deinit.
4152
657d08d3
JB
41532011-10-27 Juanma Barranquero <lekktu@gmail.com>
4154
4155 * image.c (x_create_x_image_and_pixmap):
4156 * w32.c (sys_rename, w32_delayed_load):
4157 * w32font.c (fill_in_logfont):
4158 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4159
5430d399
JB
41602011-10-26 Juanma Barranquero <lekktu@gmail.com>
4161
4162 * w32fns.c (w32_default_color_map): New function,
4163 extracted from Fw32_default_color_map.
a7ef684b 4164 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4165
fe0055fa
PE
41662011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4169
e6346438
SM
41702011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4171
4172 * keyboard.c (test_undefined): New function (bug#9751).
4173 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4174
e112cc37
ET
41752011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4176
4177 * sysdep.c (init_sys_modes): Fix the check for the controlling
4178 terminal (Bug#6649).
4179
7b5d6677
EZ
41802011-10-20 Eli Zaretskii <eliz@gnu.org>
4181
4182 * dispextern.h (struct bidi_it): New member next_en_type.
4183
4184 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4185 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4186 current character, check also for next_en_type being WEAK_EN.
4187 (bidi_resolve_weak): Don't enter the expensive loop if the current
4188 position is before next_en_pos. Record the bidi type of the first
4189 non-ET, non-BN character we find, in addition to its position.
4190 (bidi_level_of_next_char): Invalidate next_en_type when
4191 next_en_pos is over-stepped.
4192
7da0b018
PE
41932011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4194
4195 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4196 * editfns.c: Rewrite current-time-zone so that it invokes
4197 the equivalent of (format-time-string "%Z") to get the time zone name.
4198 This fixes a bug when the time zone name contains characters that
4199 need converting from the system time locale to Emacs internal format.
4200 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4201 that patch fixed format-time-string to do the conversion, but
4202 I forgot to fix current-time-zone.
4203 (format_time_string): New function, containing most of
4204 what Fformat_time_string used to contain.
4205 (Fformat_time_string): Rewrite in terms of format_time_string.
4206 This doesn't change this function's behavior.
4207 (current-time-zone): Rewrite to use format_time_string.
4208 This fixes the bug reported by Michael Schierl in
4209 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4210 Jason Rumney's 2007-06-07 change worked around this bug, but
4211 didn't fix it.
4212 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4213
8547b010
EZ
42142011-10-19 Eli Zaretskii <eliz@gnu.org>
4215
4216 * xdisp.c (start_display): If the character at POS is displayed
4217 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4218 (try_window_reusing_current_matrix): If a line ends in a display
4219 vector or the next line starts in a display vector, continue
4220 redrawing the window even though the character position of
4221 start_row was reached.
8547b010
EZ
4222 (Bug#9771, part 2)
4223
4e948d15
CY
42242011-10-18 Chong Yidong <cyd@gnu.org>
4225
4226 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4227 with nobreak-char-display too.
4228
4787455f
EZ
42292011-10-18 Eli Zaretskii <eliz@gnu.org>
4230
4231 Fix part 3 of bug#9771.
4232 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4233 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4234 non-neutral characters if the current character is a paragraph
4235 separator (a.k.a. Newline). This avoids running the same
4236 expensive loop twice, once when we consume the preceding newline
4237 and the other time when the line actually needs to be displayed.
4238 Avoid the loop when we see neutrals on the base embedding level
4239 following a character whose directionality is the same as the
4240 paragraph's. This avoids running the expensive loop when a line
4241 ends in a long sequence of neutrals, like control characters.
4242 Add assertion against STRONG_AL type. Slightly rearrange code
4243 that determines the type of a neutral given the first non-neutral
4244 that follows it.
4245 (bidi_level_of_next_char): Set next_en_pos to zero when
4246 invalidating its info.
4247
2c91f553
EZ
42482011-10-17 Eli Zaretskii <eliz@gnu.org>
4249
4250 * xdisp.c (push_display_prop): Determine whether to record string
4251 or buffer position by IT->string, not by IT->method. Allow
4252 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4253 (move_it_vertically_backward): Don't look for character position
4254 immediately after the newline when in a continuation line.
4255 (Bug#9771, part 1)
2c91f553 4256
c7b08b0d
MR
42572011-10-15 Martin Rudalics <rudalics@gmx.at>
4258
4259 * window.c (coordinates_in_window): Rewrite and delabelize
4260 vertical border check. (Bug#5357) (Bug#9618)
4261
6b02f655
SM
42622011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4263
4264 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4265 errors in XSetWindowBorder (bug#9310).
4266
81d40c92
DA
42672011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4268
4269 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4270 avoid crash when xmalloc overrun checking is enabled.
4271
d4172c3b
EZ
42722011-10-13 Eli Zaretskii <eliz@gnu.org>
4273
4274 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4275 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4276 cursor motion with <left> and <right> arrow keys.
4277
4278 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4279 some callers set that themselves.
4280
b00eea75
EZ
42812011-10-12 Eli Zaretskii <eliz@gnu.org>
4282
4283 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4284 display string and the previous row comes from the same string and
4285 is empty. (Bug#9739) (Bug#9738)
4286
8fe012c4
SM
42872011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4288
4289 * doc.c (get_doc_string): Encode file name (bug#9735).
4290
0074aef2
EZ
42912011-10-12 Eli Zaretskii <eliz@gnu.org>
4292
79beb178
EZ
4293 * bidi.c (bidi_level_of_next_char):
4294 * xdisp.c (get_visually_first_element): Remove old incorrect
4295 comments regarding the Unicode Line Separator character.
4296
0074aef2
EZ
4297 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4298
6e4b3fbe
DA
42992011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4300
4301 * alloc.c (Fgc_status): Do not access beyond zombies array
4302 boundary if nzombies > MAX_ZOMBIES.
4303 * alloc.c (dump_zombies): Add missing format specifier.
4304
0324f3af
PE
43052011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4306
b5525cac
PE
4307 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4308 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4309
0324f3af
PE
4310 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4311 Some packages use them to denote characters with modifiers.
4312
e9b5f888
AS
43132011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4314
4315 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4316 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4317 matching a pp-number. Rename parameter var to var1.
4318
127827c0
SM
43192011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4320
4321 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4322
c8fd3bd0
GM
43232011-10-08 Glenn Morris <rgm@gnu.org>
4324
4325 * callint.c (Fcall_interactively): Give a more explicit error for the
4326 'c' case with a non-character input. (Bug#8479)
4327
352ec8ff
EZ
43282011-10-08 Eli Zaretskii <eliz@gnu.org>
4329
03669ccb
EZ
4330 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4331 lines.
7061c986
EZ
4332 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4333 lines that are hscrolled on the left.
03669ccb 4334
352ec8ff
EZ
4335 * dispnew.c (buffer_posn_from_coords): Account for a possible
4336 presence of header-line. (Bug#4426)
4337
a66cfb1c
SM
43382011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4339
6b02f655
SM
4340 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4341 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4342
7c5ee88e
PE
43432011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4344
4345 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4346 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4347 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4348 this makes Emacs dump core during garbage collection on rare
4349 occasions. sizeof is obviously inferior to offsetof here, so
4350 stick with offsetof.
4351 (GC_POINTER_ALIGNMENT): New macro.
4352 (mark_memory): Omit 3rd (offset) arg; caller changed.
4353 Don't assume EMACS_INT alignment is the same as pointer alignment.
4354
df1bbe5b
SM
43552011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4356
4357 * keyboard.c (read_key_sequence_remapped): New var.
4358 (read_key_sequence): Compute remapping in the right buffer.
4359 (command_loop_1): Use read_key_sequence's remapping directly.
4360
51553db6
SM
43612011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4362
32c1fffd
SM
4363 * dired.c (file_name_completion): Don't expand file name.
4364 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4365 before checking file name handler.
4366
51553db6
SM
4367 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4368 they've been requested explicitly (bug#9591).
4369
b6bd1599 43702011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4371
4372 * keymap.c (Fsingle_key_description): Use make_specified_string
4373 instead of build_string to build string from push_key_description.
4374 (Bug#5193)
4375
f701dc2a
PE
43762011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4377
4222c55d
PE
4378 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4379 This fixes a Y2038 bug on 64-bit hosts.
4380 * buffer.c (reset_buffer):
4381 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4382 (Fclear_buffer_auto_save_failure):
4383 Use 0, not -1, to represent an unset failure time, since time_t
4384 might not be signed.
4385
f701dc2a
PE
4386 Remove dependency on glibc malloc internals.
4387 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4388 Move back here from lisp.h, but with their new implementations.
4389 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4390 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4391 * charset.c (charset_table_init): New static var.
4392 (syms_of_charset): Use it instead of xmalloc. This removes a
4393 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4394 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4395 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4396 Move back to alloc.c.
4397 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4398 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4399
9ceebf39
JD
44002011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4401
4402 * nsterm.m (windowDidResize): Call x_set_window_size only when
4403 ns_in_resize is true. Otherwise set pixelwidth/height and
4404 call change_frame_size (Bug#9628).
4405
cb993c58
PE
44062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4407
3930c88b
PE
4408 Port --enable-checking=all to Fedora 14 x86-64.
4409 * charset.c (syms_of_charset): Also account for glibc malloc's
4410 internal overhead when calculating the initial malloc maximum.
4411
cb993c58
PE
4412 Port --enable-checking=all to Fedora 14 x86.
4413 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4414 Move to lisp.h.
4415 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4416 (overrun_check_realloc, overrun_check_free):
4417 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4418 That way, xmalloc returns a properly-aligned pointer even if
4419 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4420 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4421 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4422 into account when calculating the initial malloc maximum.
4423 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4424 Move here from alloc.c, so that charset.c can use it too.
4425 Properly align; the old code wasn't right for common 32-bit hosts
4426 when configured with --enable-checking=all.
4427 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4428 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4429
31bed486
EZ
44302011-09-29 Eli Zaretskii <eliz@gnu.org>
4431
04c70788 4432 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4433 use EDOM.
4434
fbcaa2f3
EZ
44352011-09-28 Eli Zaretskii <eliz@gnu.org>
4436
4437 * xdisp.c (compute_display_string_end): If there's no display
4438 string at CHARPOS, return -1.
4439
4440 * bidi.c (bidi_fetch_char): When compute_display_string_end
4441 returns a negative value, treat the character as a normal
4442 character not covered by a display string. (Bug#9624)
4443
a239d4e9
JB
44442011-09-28 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * lread.c (Fread_from_string): Fix typo in docstring.
4447
88652fd5
EZ
44482011-09-27 Eli Zaretskii <eliz@gnu.org>
4449
4450 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4451 newline, reseat the iterator instead of bidi-iterating there one
4452 character at a time. (Bug#9610)
32c1fffd
SM
4453 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4454 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4455
ed497dd4
AS
44562011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4457
4458 * lread.c (readevalloop): Use correct code for NBSP.
4459 (read1): Likewise. (Bug#9608)
4460
b2bf61aa
MA
44612011-09-25 Michael Albinus <michael.albinus@gmx.de>
4462
4463 * dbusbind.c (Fdbus_register_signal): When service is not
4464 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4465
32bbb17c
GM
44662011-09-25 Glenn Morris <rgm@gnu.org>
4467
4468 * buffer.c (truncate-lines): Doc fix.
4469
94e0933e
CY
44702011-09-24 Chong Yidong <cyd@stupidchicken.com>
4471
4472 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4473 (Fset_window_next_buffers): Doc fix.
4474
cddde921
GM
44752011-09-24 Glenn Morris <rgm@gnu.org>
4476
4477 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4478
1260aef1
PE
44792011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4480
25b4bfa0
PE
4481 Fix minor problems found by static checking.
4482 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4483 * indent.c (Fvertical_motion): Fix == vs = typo.
4484
e3cbd34b
EZ
44852011-09-24 Eli Zaretskii <eliz@gnu.org>
4486
a66cfb1c
SM
4487 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4488 Default value is now t. Doc fix.
6bf7006f 4489
e3cbd34b 4490 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4491 logic when moving up, not only when moving down. Fix the
e3cbd34b 4492 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4493 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4494
4495 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4496 CHARPOS is covered by a display string which includes newlines.
4497 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4498 is covered by a display string with embedded newlines.
4499
a3de0cbd
MA
45002011-09-24 Michael Albinus <michael.albinus@gmx.de>
4501
4502 * dbusbind.c (Fdbus_register_signal): Add match rule to
4503 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4504 (Fdbus_register_method, Vdbus_registered_objects_table):
4505 Fix docstring.
a3de0cbd 4506
b260039d
JM
45072011-09-24 Jim Meyering <meyering@redhat.com>
4508
32c1fffd 4509 do not ignore write error for any output size
b260039d
JM
4510 The previous change was incomplete.
4511 While it makes emacs --batch detect the vast majority of stdout
4512 write failures, errors were still ignored whenever the output size is
4513 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4514 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4515 && echo FAIL: ignored write error
4516 FAIL: ignored write error
4517 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4518 && echo FAIL: ignored write error
4519 FAIL: ignored write error
4520 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4521
8eca8a7c
AS
45222011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4523
4524 * emacs.c (Fkill_emacs): In noninteractive mode exit
4525 non-successfully if a write error occurred on stdout. (Bug#9574)
4526
3341db62
EZ
45272011-09-21 Eli Zaretskii <eliz@gnu.org>
4528
4529 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4530 the xassert test.
4531
4532 * dispextern.h (struct it): Update the comment documenting what
4533 can it->OBJECT be.
4534
8c203dbf
EZ
45352011-09-20 Eli Zaretskii <eliz@gnu.org>
4536
4537 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4538 a display string, extend search for cursor position to end of row.
4539 (find_row_edges): If the row ends in a newline from a display
4540 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4541 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4542 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4543 non-empty line. Fixes confusing cursor motion with arrow keys at
4544 the beginning of a line that starts with whitespace.
8c203dbf 4545
a4824228
LMI
45462011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4547
4548 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4549 (bug#9493).
4550
33ed493b
CY
45512011-09-18 Chong Yidong <cyd@stupidchicken.com>
4552
4553 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4554 boolean (Bug#9154).
4555
56cd55c8
EZ
45562011-09-18 Eli Zaretskii <eliz@gnu.org>
4557
4558 * xdisp.c (display_line): Record maximum and minimum buffer
4559 positions even if no glyphs were produced (e.g., by a zero-width
4560 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4561 buffer positions that will be removed from the glyph row because
4562 they don't fit.
c02dcedf
EZ
4563 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4564 column is beyond frame width: don't subtract 1 "pixel" when
4565 computing width of the stretch.
3e62b7e0
EZ
4566 (reseat_at_next_visible_line_start): Undo the change made on
4567 2011-09-17 that saved paragraph information and restored it after
4568 the call to `reseat'. (Bug#9545)
56cd55c8 4569
5ed99d36 45702011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4571
4572 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4573 and turn window cursor on if cleared (Bug#9415).
4574
5ed99d36 45752011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4576
4577 * search.c (boyer_moore): Take unibyte characters from pattern
4578 literally. (Bug#9458)
4579
9bade7b2
EZ
45802011-09-18 Eli Zaretskii <eliz@gnu.org>
4581
4582 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4583
e5e9d610
PE
45842011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4585
87e4427a
PE
4586 Fix minor problem found by static checking.
4587 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4588 initialized, to pacify gcc -Wuninitialized.
4589
e5e9d610
PE
4590 * fileio.c: Report proper errno when syscall falls.
4591 (Finsert_file_contents): Save and restore errno,
4592 so that report_file_error outputs the correct diagnostic.
4593 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4594
a1674f0b
EZ
45952011-09-18 Eli Zaretskii <eliz@gnu.org>
4596
4597 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4598
fbfb6dd4
EZ
45992011-09-17 Eli Zaretskii <eliz@gnu.org>
4600
4601 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4602 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4603
bb187662
EZ
46042011-09-17 Eli Zaretskii <eliz@gnu.org>
4605
1137e8b8 4606 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4607 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4608
4609 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4610 (bidi_find_paragraph_start): Search back for paragraph beginning
4611 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4612 (bidi_move_to_visually_next): Only trigger paragraph-related
4613 computations when the last character is a newline or at EOB, not
4614 just any NEUTRAL_B. (Bug#9470)
4615
bb187662
EZ
4616 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4617 truncated lines if point is covered by a display string. (Bug#9524)
4618
2e621251
PE
46192011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4620
4621 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4622 (cons_to_x_long): New function.
4623 (lisp_data_to_selection_data): Use it. Correct the test for
4624 short-versus-long data; it was negated. Break out of vector
4625 loop, for efficiency, when a long datum is discovered.
4626
91a15bc6
SM
46272011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4628
4629 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4630
b41c3a35
EZ
46312011-09-16 Eli Zaretskii <eliz@gnu.org>
4632
4633 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4634 GCC PR/17406) by declaring this function with external scope.
4635
7812ba2d
PE
46362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4637
4638 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4639 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4640
cf7edc2a
AS
46412011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4642
4643 * editfns.c (Fformat): Correctly handle text properties on "%%".
4644
bd01620e
EZ
46452011-09-15 Eli Zaretskii <eliz@gnu.org>
4646
4647 * xterm.c (x_draw_composite_glyph_string_foreground):
4648 * w32term.c (x_draw_composite_glyph_string_foreground):
4649 * term.c (encode_terminal_code):
4650 * composite.c (composition_update_it, get_composition_id):
4651 * xdisp.c (get_next_display_element)
4652 (fill_composite_glyph_string): Add comments about special meaning
4653 of TAB characters in a composition.
4654
a02719a3
PE
46552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4656
4657 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4658 This occurs when processing a multibyte format.
4659 Problem reported by Wolfgang Jenker.
a02719a3 4660
72589a3c
JB
46612011-09-15 Johan Bockgård <bojohan@gnu.org>
4662
4663 * xdisp.c (try_cursor_movement): Only check for exact match if
4664 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4665
1c14176c
PE
46662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4667
4668 Remove unused external symbols.
4669 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4670 * xdisp.c (calc_pixel_width_or_height): Now static.
4671 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4672 * indent.c (check_display_width):
4673 * w32term.c: Fix comment to match code.
4674 * xterm.c, xterm.h (x_catching_errors): Remove.
4675
d2eea5b5
PE
46762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 * xselect.c: Use signed conversions more consistently (Bug#9498).
4679 (selection_data_to_lisp_data): Assume incoming selection data are
4680 signed integers, not unsigned. This is to be consistent with
4681 outgoing selection data, which was modified to use signed integers
4682 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4683 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4684 expects long, not unsigned long.
4685
46888499
EZ
46862011-09-14 Eli Zaretskii <eliz@gnu.org>
4687
4688 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4689 computation of loop end. Reported by Johan Bockgård
4690 <bojohan@gnu.org>.
4691
ef8ef9fb
CY
46922011-09-13 Chong Yidong <cyd@stupidchicken.com>
4693
4694 * frame.c (Fother_visible_frames_p): Function deleted.
4695
fa819fed
EZ
46962011-09-12 Eli Zaretskii <eliz@gnu.org>
4697
4698 * indent.c (compute_motion): Process display vector front to back
4699 rather than the other way around. (Bug#2496)
4700
2ba8e008
SM
47012011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4702
4703 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4704
20f53c69
CY
47052011-09-11 Chong Yidong <cyd@stupidchicken.com>
4706
4707 * minibuf.c (Fread_from_minibuffer): Doc fix.
4708
d562d7a4
EZ
47092011-09-11 Eli Zaretskii <eliz@gnu.org>
4710
4711 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4712 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4713
1c4d7f3d
LMI
47142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4715
4716 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4717 value for non-existent files.
4718
b885bf36
EZ
47192011-09-11 Eli Zaretskii <eliz@gnu.org>
4720
4721 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4722 set its "size" to -1. This will set the modtime_size field of
4723 the corresponding buffer to -1, which is what
4724 verify-visited-file-modtime expects for files that do not exist.
4725 (Bug#9139)
4726
6612f0bf
PE
47272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4728
4729 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4730 here ...
4731 * lisp.h: ... from here. push_key_description is no longer
4732 defined in keyboard.c, so its declaration should not be in
4733 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4734 logically belongs with push_key_description.
4735
dfb3f755
PE
47362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4737
4738 * buffer.h: Include <sys/types.h> instead of <time.h>.
4739 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4740 Problem reported by Herbert J. Skuhra.
4741
3134906c
LMI
47422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4743
4744 * xml.c (parse_region): Make the parsing work for
4745 non-comment-starting XML files again (bug#9144).
4746
8d903f4e
AS
47472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4748
4749 * image.c (gif_load): Fix calculation of bottom and right corner.
4750 (Bug#9468)
4751
80ad64f4
EZ
47522011-09-10 Eli Zaretskii <eliz@gnu.org>
4753
4754 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4755 redisplay in small windows.
4756
208a048d
EZ
47572011-09-09 Eli Zaretskii <eliz@gnu.org>
4758
4759 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4760
9b1c252e
MR
47612011-09-08 Martin Rudalics <rudalics@gmx.at>
4762
4763 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4764 Operate on live windows only.
4765
2949f33b
JB
47662011-09-08 Juanma Barranquero <lekktu@gmail.com>
4767
4768 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4769
e08dcafd
EZ
47702011-09-07 Eli Zaretskii <eliz@gnu.org>
4771
4772 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4773 only under bidi iteration.
4774
115b96bd
JD
47752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4776
4777 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4778
c8199d0f
PE
47792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4780
4781 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4782 Without this fix, the command to link temacs failed due to an
4783 undefined symbol __builtin_isnan. This is because
4784 /usr/include/iso/math_c99.h #defines isnan(x) to
4785 __builtin_isnan(x), but the bundled gcc, which identifies itself
4786 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4787 a __builtin_isnan.
4788 * floatfns.c (isnan): #undef, and then #define to a clone of
4789 what's in data.c.
4790 (Fisnan): Always define, since it's always available now.
4791 (syms_of_floatfns): Always define isnan at the Lisp level.
4792
e39b275c 47932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4794
4795 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4796
b2db44d9 47972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4798
f4af5137 4799 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4800 The previous code assumed that file offsets (off_t values) fit in
4801 EMACS_INT variables, which is not true on typical 32-bit hosts.
4802 The code messed up by falsely reporting buffer overflow in cases
4803 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4804 when "big" contains more than 2**29 bytes, even though this
4805 inserts just one byte and does not overflow the buffer.
4806 (Finsert_file_contents): Store file offsets as off_t
4807 values, not as EMACS_INT values. Check for overflow when
4808 converting between EMACS_INT and off_t. When checking for
4809 buffer overflow or for overlap, take the offsets into account.
4810 Don't use EMACS_INT for small values where int suffices.
4811 When checking for overlap, fix a typo: ZV was used where
4812 ZV_BYTE was intended.
4813 (Fwrite_region): Don't assume off_t fits into 'long'.
4814 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4815
ecfc0a49
MA
48162011-09-05 Michael Albinus <michael.albinus@gmx.de>
4817
4818 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4819
6511acf2 48202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4821
0999621a 4822 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4823
4824 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4825 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4826 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4827 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4828 (modify_event_symbol): Do not assume that the length of
4829 name_alist_or_stem is safe to alloca and fits in int.
4830 (Fexecute_extended_command): Likewise for function name and binding.
4831 (Frecursion_depth): Wrap around reliably on integer overflow.
4832 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4833 since some callers pass EMACS_INT values.
4834 (Fsingle_key_description): Don't crash if symbol name contains more
4835 than MAX_ALLOCA bytes.
4836 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4837 (get_minibuffer): Arg is now EMACS_INT, not int.
4838 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4839 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4840 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4841
2be7d702
PE
4842 * dbusbind.c (signature_cat): New function.
4843 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4844 Do not overrun buffer; instead, report string overflow.
4845
9d1df220
PE
4846 * dispnew.c (add_window_display_history): Don't overrun buffer.
4847 Truncate instead; this is OK since it's just a log.
4848
33ef5c64
PE
4849 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4850 even if the time zone offset is outlandishly large.
4851 Don't mishandle offset == INT_MIN.
4852
66c6fdd5
PE
4853 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4854 when creating daemon; the previous buffer-overflow check was incorrect.
4855
d749b01b
PE
4856 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4857 which has the guts of the old verror function.
4858
b5cd1905
PE
4859 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4860 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4861
6e1a67fb
PE
4862 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4863 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4864 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4865 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4866 length of string rather than counting it via multiple sprintfs;
4867 that's simpler and more reliable.
c21721cc
PE
4868 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4869 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4870 sprintf, in case result does not fit in int.
4871
c57b67fc
PE
4872 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4873 (fontset_from_font): Print it.
4874
8a401434
PE
4875 * frame.c (tty_frame_count): Now printmax_t, not int.
4876 (make_terminal_frame, set_term_frame_name): Print it.
4877 (x_report_frame_params): In X, window IDs are unsigned long,
4878 not signed long, so print them as unsigned.
4879 (validate_x_resource_name): Check for implausibly long names,
4880 and don't assume name length fits in 'int'.
4881 (x_get_resource_string): Don't blindly alloca invocation name;
4882 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4883 not fit in int.
4884
6e1a67fb
PE
4885 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4886 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4887 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4888
0df02bf3
PE
4889 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4890 Use esprintf, not sprintf, in case result does not fit in int.
4891
48e30793
PE
4892 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4893 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4894 it as a large positive number.
4895 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4896 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4897
a66ff6d8
PE
4898 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4899 in case result does not fit in int.
4900
aca216ff
PE
4901 * print.c (float_to_string): Detect width overflow more reliably.
4902 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4903 buffer overrun. Don't assume list length fits in 'int'. Treat
4904 print length of 0 as 0, not as infinity; to be consistent with other
4905 uses of print length in this function. Don't overflow print length
4906 index. Don't assume hash table size fits in 'long', or that
4907 vectorlike size fits in 'unsigned long'.
4908
31c286f7
PE
4909 * process.c (make_process): Use printmax_t, not int, to format
4910 process-name gensyms.
4911
55e5faa1
PE
4912 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4913
80f2e268
PE
4914 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4915 to avoid potential buffer overrun.
4916
670741ab
PE
4917 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4918 if X resource line is longer than 512 bytes.
4919
b7163a50
PE
4920 * xfns.c (x_window): Make sprintf buffer a bit bigger
4921 to avoid potential buffer overrun.
4922
ae58ff1f
PE
4923 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4924
c43c8a6a
PE
4925 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4926
3f8236f4
PE
49272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4928
53e9fe90 4929 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4930 Without these, Emacs silently mishandles large integers sometimes.
4931 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4932 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4933
6511acf2
PE
4934 * xdisp.c (try_window_id): Check Emacs fixnum range before
4935 converting to 'int'.
806add1d 4936
6511acf2 4937 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4938 Check that an Emacs fixnum is in range before assigning it to 'int'.
4939 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4940 values converted from Emacs fixnums.
4941 (Frecenter): Don't wrap around a line count if it is out of 'int'
4942 range; instead, treat it as an extreme value.
4943 (Fset_window_configuration, compare_window_configurations):
4944 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4945
6511acf2
PE
4946 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4947 that can exceed INT_MAX. Check that EMACS_INT value is in range
4948 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4949 (match_limit): Don't assume that a fixnum can fit in 'int'.
4950
6511acf2 4951 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4952 exceed INT_MAX.
4953
6511acf2 4954 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4955 (Fvertical_motion): Don't wrap around LINES values that don't fit
4956 in 'int'. Instead, treat them as extreme values. This is good
4957 enough for windows, which can't have more than INT_MAX lines anyway.
4958
fcb901a7
LMI
49592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4960
0f2f6b6d
LMI
4961 * Require libxml/parser.h to avoid compilation warning.
4962
fcb901a7
LMI
4963 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4964
4965 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4966 since this reportedly can destroy thread storage.
4967
6e20a0d4
CY
49682011-08-30 Chong Yidong <cyd@stupidchicken.com>
4969
4970 * syntax.c (find_defun_start): Update all cache variables if
4971 exiting early (Bug#9401).
4972
148ae00e
EZ
49732011-08-30 Eli Zaretskii <eliz@gnu.org>
4974
f6cfbd8f
EZ
4975 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4976
148ae00e
EZ
4977 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4978 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4979 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4980
4981 * term.c (tty_append_glyph): New function.
4982 (produce_stretch_glyph): Static function and its prototype deleted.
4983
a66cfb1c
SM
4984 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4985 Add prototypes.
148ae00e 4986
c4a07a4c
PE
49872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4988
4989 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4990 when checking :margin (Bug#9390).
4991 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4992 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4993 so that the name doesn't mislead. All uses changed.
4994
6bc8cd65
JB
49952011-08-28 Johan Bockgård <bojohan@gnu.org>
4996
4997 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4998 set_tty_hooks.
4999
dca4927e
EZ
50002011-08-27 Eli Zaretskii <eliz@gnu.org>
5001
5002 * xdisp.c (move_it_to): Don't bail out early when reaching
5003 position beyond to_charpos, if we are scanning backwards.
5004 (move_it_vertically_backward): When DY == 0, make sure we get to
5005 the first character in the line after the newline.
5006
f2cad773
PE
50072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5008
5009 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5010 (ccl_driver): Do not generate an out-of-range pointer.
5011 (Fccl_execute_on_string): Remove unnecessary check for
5012 integer overflow, noted by Stefan Monnier in
5013 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5014 Remove a FIXME that didn't need fixing.
5015 Simplify the newly-introduced buffer reallocation code.
5016
0cae2cdb
JB
50172011-08-27 Juanma Barranquero <lekktu@gmail.com>
5018
5019 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5020
5fc295a4 50212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5022
70c60eb2 5023 Integer and memory overflow issues (Bug#9196).
726e0ab1 5024
d31850da
PE
5025 * doc.c (get_doc_string): Rework so that
5026 get_doc_string_buffer_size is the actual buffer size, rather than
5027 being 1 less than the actual buffer size; this makes xpalloc more
5028 convenient.
5029
a69fbedb
PE
5030 * image.c (x_allocate_bitmap_record, cache_image):
5031 * xselect.c (Fx_register_dnd_atom):
5032 Simplify previous changes by using xpalloc.
5033
fe5c5d37
PE
5034 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5035 since either will do and ptrdiff_t is convenient with xpalloc.
5036
0065d054
PE
5037 * charset.c (charset_table_size)
5038 (struct charset_sort_data.priority): Now ptrdiff_t.
5039 (charset_compare): Don't overflow if priorities differ greatly.
5040 (Fsort_charsets): Don't assume list length fits in int.
5041 Check for size-calculation overflow when allocating sort data.
5042 (syms_of_charset): Allocate an initial charset table that is
5043 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5044
5045 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5046
5047 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5048 The actual value is always <= INT_MAX, and leaving it unsigned made
5049 overflow checking harder.
5050
5051 * dispextern.h (struct glyph_matrix.rows_allocated)
5052 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5053 with xpalloc. The values are still always <= INT_MAX.
5054
5055 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5056
5057 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5058 (SAFE_NALLOCA): New macro.
5059
5060 * region-cache.c (struct boundary.pos, find_cache_boundary)
5061 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5062 (set_cache_region, invalidate_region_cache)
5063 (revalidate_region_cache, know_region_cache, region_cache_forward)
5064 (region_cache_backward, pp_cache):
5065 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5066 so that ptrdiff_t * can be passed to xpalloc.
5067 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5068 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5069 (pp_cache): Don't assume cache_len fits in int.
5070 * region-cache.h: Adjust extern decls to match.
5071
5072 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5073 EMACS_INT, since either will do, for xpalloc.
5074
5075 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5076 (xnmalloc, xnrealloc, xpalloc): New functions.
5077
726e0ab1
PE
5078 * bidi.c (bidi_shelve_header_size): New constant.
5079 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5080 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5081
51f30bc5 5082 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5083 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5084 (overlay_strings):
5085 Don't update size of array until after memory allocation succeeds,
5086 because xmalloc/xrealloc may not return.
0065d054
PE
5087 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5088 now that we have proper integer overflow checking.
5089 (record_overlay_string, overlay_strings): Catch overflows when
5090 calculating size of overlay_str_buf.
726e0ab1 5091
0065d054
PE
5092 * callproc.c (Fcall_process): Check for size overflow when
5093 calculating size of args2.
5094 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5095 Normally we prefer signed values, but sticking with ptrdiff_t would
5096 require adding more-complicated checks.
726e0ab1
PE
5097
5098 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5099 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5100 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5101 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5102
5103 * character.c (Fstring): Check for size-calculation overflow.
5104
5105 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5106 unnecessary integer overflow. Check for size overflow.
5107 (encode_coding_object): Don't update size until xmalloc succeeds.
5108
5109 * composite.c (get_composition_id): Check for overflow in glyph
5110 length calculations.
5111
5112 Integer and memory overflow fixes for display code.
5113 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5114 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5115 (scrolling_window): Check for overflow in size calculations.
5116 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5117 Don't assume glyph table len fits in int.
5118 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5119 (row_table_size): Now ptrdiff_t, not int.
5120 (scrolling_window): Avoid overflow in size calculations.
5121 Don't update size until allocation succeeds.
5122 * fns.c (concat): Check for overflow in size calculations.
5123 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5124 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5125 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5126
5127 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5128 (get_doc_string): Check for size calculation overflow.
5129 Don't update size until allocation succeeds.
5130 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5131 EMACS_INT, where ptrdiff_t will do.
5132 (Fsubstitute_command_keys): Check for string overflow.
5133
5134 * editfns.c (set_time_zone_rule): Don't assume environment length
5135 fits in int.
5136 (message_length): Now ptrdiff_t, not int.
5137 (Fmessage_box): Don't update size until allocation succeeds.
5138 Don't assume message length fits in int.
5139 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5140
0065d054
PE
5141 * emacs.c (main): Do not reallocate argv, since there is a null at
5142 the end that can be overwritten, and this way there's no need to
5143 worry about size-calculation overflow.
5144 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5145
5146 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5147 alloc succeeds.
5148 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5149
5150 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5151 (x_set_scroll_bar_width, x_figure_window_size):
5152 Check for integer overflow.
5153 (x_set_alpha): Do not assume XINT fits in int.
5154
5155 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5156 This is for the members text_lines, text_cols, total_lines, total_cols,
5157 where the system imposes an 'int' limit.
5158
5159 * fringe.c (Fdefine_fringe_bitmap):
5160 Don't update size until alloc works.
5161
5162 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5163 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5164
5165 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5166 Check for size-calculation overflow.
5167 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5168 do, as we prefer signed integers.
5169 (id_to_widget.max_size, id_to_widget.used)
5170 (xg_store_widget_in_map, xg_remove_widget_from_map)
5171 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5172 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5173 Use and return ptrdiff_t, not int.
5174 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5175 * gtkutil.h: Change prototypes to match the above.
5176
5177 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5178 are duplicate now that they've been promoted to lisp.h.
5179 (x_allocate_bitmap_record, x_alloc_image_color)
5180 (make_image_cache, cache_image, xpm_load):
5181 Don't update size until alloc is done.
5182 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5183 (x_detect_edges):
3256efce 5184 Check for size calculation overflow.
726e0ab1
PE
5185 (ct_colors_allocated_max): New constant.
5186 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5187 overflow.
3256efce 5188
726e0ab1
PE
5189 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5190 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5191 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5192 Use ptrdiff_t, not int, to count maps.
5193 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5194 calculations. Don't update size until allocation succeeds.
5195 Redo calculations to avoid overflow.
726e0ab1
PE
5196 * keyboard.h: Change prototypes to match the above.
5197
5198 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5199 to count maps.
5200 (current_minor_maps): Check for size calculation overflow.
5201 * keymap.h: Change prototypes to match the above.
5202
5203 * lread.c (read1, init_obarray): Don't update size until alloc done.
5204
5205 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5206 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5207
726e0ab1
PE
5208 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5209 Now ptrdiff_t, not int.
5210 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5211 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5212
5213 * process.c (Fnetwork_interface_list): Check for overflow
5214 in size calculation.
5215
5216 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5217
5218 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5219 overflow. Don't bother calling xmalloc when xrealloc will do.
5220
5221 * search.c (Freplace_match): Check for size calculation overflow.
5222 (Fset_match_data): Don't assume list lengths fit in 'int'.
5223
5224 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5225 for command line length. Do not attempt to address one before the
5226 beginning of an array, as that's not portable.
5227
5228 * term.c (max_frame_lines): Remove; unused.
5229 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5230 not int.
5231 (encode_terminal_code, calculate_costs): Check for size
5232 calculation overflow.
5233 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5234 table lengths and related sizes. Don't update size until alloc
5235 done. Redo calculations to avoid overflow.
5236 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5237
5238 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5239 subtracting pointers.
5240 (gobble_line): Check for overflow more carefully. Don't update size
5241 until alloc done.
5242
5243 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5244 Don't update size until alloc done.
5245 Redo size calculations to avoid overflow.
5246 Check for size calculation overflow.
0065d054 5247 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5248
5249 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5250 Use ptrdiff_t, not int, for sizes.
5251 (store_mode_line_noprop_char): Don't update size until alloc done.
5252
0065d054
PE
5253 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5254 Use ptrdiff_t, not int, for sizes.
5255 (Finternal_make_lisp_face, cache_face):
5256 Check for size calculation overflow.
5257 (cache_face): Treat size calculation overflows as if they were
5258 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5259
5260 * xfns.c (x_encode_text, x_set_name_internal)
5261 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5262 sizes, since they can exceed INT_MAX in size. Check for size
5263 calculation overflow.
5264
0065d054
PE
5265 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5266 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5267 Don't update size until alloc done.
5268
0065d054 5269 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5270 as sprintf is limited to int lengths.
1d526e2f 5271
252c5ee1
PE
5272 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5273 (X_LONG_MIN): New macros.
864d7ce7
PE
5274 Use them to make the following changes clearer.
5275 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5276 This change doesn't affect the value now, but it may help remind
5277 future maintainers not to raise the value too much later.
5278 (SELECTION_QUANTUM): Remove, replacing with ...
5279 (selection_quantum): ... new function, which avoids overflow.
5280 All uses changed.
5281 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5282 assumption that selection length fits in 'int'.
5283 (x_reply_selection_request, x_handle_selection_request)
5284 (x_get_window_property, receive_incremental_selection)
5285 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5286 (lisp_data_to_selection_data, clean_local_selection_data):
5287 Use ptrdiff_t, not int, to record length of selection.
5288 (x_reply_selection_request, x_get_window_property)
5289 (receive_incremental_selection, x_property_data_to_lisp):
5290 Redo calculations to avoid overflow.
5291 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5292 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5293 something.
5294 (x_get_window_property, receive_incremental_selection)
5295 (lisp_data_to_selection_data, x_property_data_to_lisp):
5296 Check for size-calculation overflow.
5297 (x_get_window_property, receive_incremental_selection)
5298 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5299 Don't store size until memory allocation succeeds.
5300 (x_get_window_property): Plug memory leak on memory exhaustion.
5301 Don't double-block input; malloc is safe here. Don't assume 2**34
5302 - 4 fits in unsigned long. Add an xassert to check
5303 XGetWindowProperty overflow. Be more careful about overflow
5304 calculations, and distinguish size from memory overflow better.
5305 (receive_incremental_selection): When tracing, don't assume
5306 unsigned int is less than INT_MAX.
5307 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5308 harmful) conversions of unsigned short to int.
5309 (lisp_data_to_selection_data): Don't assume that integers
5310 in the range -65535 through -1 fit in an X unsigned short.
5311 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5312 result parameters unless successful. Rely on cons_to_unsigned
5313 to report problems with elements; the old code wasn't right anyway.
5314 (x_check_property_data): Check for int overflow; we cannot use
5315 a wider type due to X limits.
5316 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5317
726e0ab1 5318 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5319
0065d054
PE
5320 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5321 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5322 (x_color_cells): Don't store size until memory allocation succeeds.
5323 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5324 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5325 (x_term_init): Don't assume length fits in int (sprintf is limited
5326 to int size).
bc18e09d 5327
ebfa62c0
PE
5328 Use ptrdiff_t for composition IDs.
5329 * character.c (lisp_string_width):
5330 * composite.c (composition_table_size, n_compositions)
5331 (get_composition_id, composition_gstring_from_id):
5332 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5333 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5334 * window.c (Frecenter):
5335 Use ptrdiff_t, not int, for composition IDs.
5336 * composite.c (get_composition_id): Check for integer overflow.
5337 * composite.h: Adjust prototypes to match the above changes.
5338
d3411f89
PE
5339 Use ptrdiff_t for hash table indexes.
5340 * category.c (hash_get_category_set):
5341 * ccl.c (ccl_driver):
5342 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5343 * coding.c (coding_system_charset_list, detect_coding_system):
5344 * coding.h (struct coding_system.id):
5345 * composite.c (get_composition_id, gstring_lookup_cache):
5346 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5347 * image.c (xpm_get_color_table_h):
5348 * lisp.h (hash_lookup, hash_put):
5349 * minibuf.c (Ftest_completion):
5350 Use ptrdiff_t for hash table indexes, not int (which is too
5351 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5352 32-bit --with-wide-int hosts).
5353
e097a6fa
PE
5354 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5355 Add a FIXME comment about memory leaks.
5356 (syms_of_charset): Don't assume xmalloc returns.
5357
5637687f
PE
5358 Don't assume that stated character widths fit in int.
5359 * character.c (Fchar_width, c_string_width, lisp_string_width):
5360 * character.h (CHAR_WIDTH):
5361 * indent.c (MULTIBYTE_BYTES_WIDTH):
5362 Use sanitize_char_width to avoid undefined and/or bad behavior
5363 with outlandish widths.
a66cfb1c 5364 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5365 now that we have two such functions. All uses changed.
5366 (sanitize_char_width): New inline function.
5367
a2271ba2
PE
5368 Don't assume that tab-width fits in int.
5369 * character.h (sanitize_width): New inline function.
5370 (SANE_TAB_WIDTH): New macro.
5371 (ASCII_CHAR_WIDTH): Use it.
5372 * indent.c (sane_tab_width): Remove. All uses replaced by
5373 SANE_TAB_WIDTH (current_buffer).
5374 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5375
18c52557
PE
5376 * fileio.c: Integer overflow issues with file modes.
5377 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5378
caeeedc1
PE
5379 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5380 Remove unreachable code.
5381 (read_hex, load_charset_map_from_file): Check for integer overflow.
5382
6df6ae42 5383 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5384 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5385 (x_send_scroll_bar_event): Likewise. Check that the size does not
5386 exceed limits imposed by XClientMessageEvent, as well as the usual
5387 ptrdiff_t and size_t limits.
5388
b13995db
PE
5389 * keyboard.c: Overflow, signedness and related fixes.
5390 (make_lispy_movement): Use same integer type in forward decl
5391 that is used in the definition.
5392 (read_key_sequence, keyremap_step):
5393 Change bufsize argument back to int, undoing my 2011-03-30 change.
5394 We prefer signed types, and int is wide enough here.
5395 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5396 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5397 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5398 length, not size_t. Use ptrdiff_t for index, not int.
5399 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5400 possibility of integer overflow.
5401
13464394
PE
5402 Overflow, signedness and related fixes for images.
5403
5404 * dispextern.h (struct it.stack[0].u.image.image_id)
5405 (struct_it.image_id, struct image.id, struct image_cache.size)
5406 (struct image_cache.used, struct image_cache.ref_count):
5407 * gtkutil.c (update_frame_tool_bar):
5408 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5409 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5410 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5411 * nsmenu.m (update_frame_tool_bar):
5412 * xdisp.c (calc_pixel_width_or_height):
5413 * xfns.c (image_cache_refcount):
5414 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5415 on typical 64-bit hosts.
5416
5417 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5418 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5419 Omit unnecessary casts to int.
5420 (parse_image_spec): Check that integers fall into 'int' range
5421 when the callers expect that.
5422 (image_ascent): Redo ascent calculation to avoid int overflow.
5423 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5424 (lookup_image): Remove unnecessary tests.
5425 (xbm_image_p): Locals are now of int, not EMACS_INT,
5426 since parse_image_check makes sure they fit into int.
5427 (png_load, gif_load, svg_load_image):
5428 Prefer int to unsigned where either will do.
5429 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5430 old tiff_error_handler and tiff_warning_handler.
5431 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5432 stack buffer overflows. It uses only the features of vsnprintf
5433 that are common to both POSIX and native Microsoft.
5434 (tiff_error_handler, tiff_warning_handler): Use it.
5435 (tiff_load, gif_load, imagemagick_load_image):
5436 Don't assume :index value fits in 'int'.
5437 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5438 (imagemagick_load_image): Check that crop parameters fit into
5439 the integer types that MagickCropImage accepts. Don't assume
5440 Vimagemagick_render_type has a nonnegative value. Don't assume
5441 size_t fits in 'long'.
5442 (gs_load): Use printmax_t to print the widest integers possible.
5443 Check for integer overflow when computing image height and width.
5444
c11821d4
EZ
54452011-08-26 Eli Zaretskii <eliz@gnu.org>
5446
5447 * xdisp.c (redisplay_window): Don't force window start if point
5448 will be invisible in the resulting window. (Bug#9324)
5449
0c95fcf7
EZ
54502011-08-25 Eli Zaretskii <eliz@gnu.org>
5451
5452 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5453 the display spec is of the form `(space ...)'.
5454 (handle_display_spec): Return the value returned by
5455 handle_single_display_spec, not just 1 or zero.
5456 (handle_single_display_spec): If the display spec is of the form
5457 `(space ...)', and specifies display in the text area, return 2
5458 rather than 1.
fee65a97 5459 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5460 accurately, and prefer exact match for point under bidi.
5461 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5462
5463 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5464 into disp_prop; all users changed.
5465
5466 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5467 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5468 for the text covered by the display property.
5469
e4ed06f1
CY
54702011-08-25 Chong Yidong <cyd@stupidchicken.com>
5471
5472 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5473 Change return value to nil.
5474 (Frecord_buffer): Delete unused function.
5475
f67cdd7f
EZ
54762011-08-24 Eli Zaretskii <eliz@gnu.org>
5477
5980d4c6
EZ
5478 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5479 buffers, return left-to-right.
8610fe8b
EZ
5480 (set_cursor_from_row): Consider candidate row a win if its glyph
5481 represents a newline and point is on that newline. Fixes cursor
5482 positioning on the newline at EOL of R2L text within L2R
5483 paragraph, and vice versa.
5484 (try_cursor_movement): Check continued rows, in addition to
5485 continuation rows. Fixes unwarranted scroll when point enters a
5486 continued line of R2L text within an L2R paragraph, or vice versa.
5487 (cursor_row_p): Consider the case of point being equal to
5488 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5489 from the end of a short line to the beginning of a continued line
5490 of R2L text within L2R paragraph.
5491 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5492 composed characters.
5980d4c6 5493
f67cdd7f
EZ
5494 * bidi.c (bidi_check_type): Use xassert.
5495 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5496 members.
5497
bca633fb
EZ
54982011-08-23 Eli Zaretskii <eliz@gnu.org>
5499
5500 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5501 a character.
5502
4a5885a7
CY
55032011-08-23 Chong Yidong <cyd@stupidchicken.com>
5504
5505 * nsfont.m (ns_otf_to_script): Fix typo.
5506
0902a04e
KH
55072011-08-22 Kenichi Handa <handa@m17n.org>
5508
5509 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5510 extra slot even if the purpose is char-code-property-table.
5511
1a2e6670
EZ
55122011-08-23 Eli Zaretskii <eliz@gnu.org>
5513
8ddde651
EZ
5514 * xdisp.c (redisplay_window): When computing centering_position,
5515 account for the height of the header line. (Bug#8874)
5516
425cc014
EZ
5517 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5518 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5519 candidate is selected by the mouse, and that candidate has a
5520 composed character under the mouse.
5521
1a2e6670
EZ
5522 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5523 coordinates reported by pos-visible-in-window-p for a composed
5524 character in column zero.
5525
8b76d6f8
SM
55262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5527
5528 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5529
dac347dd
EZ
55302011-08-22 Eli Zaretskii <eliz@gnu.org>
5531
5532 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5533 consider it a hit if to_charpos is anywhere in the range of the
5534 composed buffer positions.
5535
e013fb34
CY
55362011-08-22 Chong Yidong <cyd@stupidchicken.com>
5537
5538 * image.c (gif_load): Don't assume that each subimage has the same
5539 dimensions as the base image. Handle disposal method that is
5540 "undefined" by the gif spec (Bug#9335).
5541
bd1ba3e8
CY
55422011-08-20 Chong Yidong <cyd@stupidchicken.com>
5543
5544 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5545 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5546
54a1215b
EZ
55472011-08-19 Eli Zaretskii <eliz@gnu.org>
5548
823564e5
EZ
5549 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5550 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5551 from an Org mode buffer to a Speedbar frame.
5552
54a1215b
EZ
5553 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5554 a composition, take its buffer position from IT->cmp_it.charpos.
5555 Fixes cursor positioning at the beginning of a line that begins
5556 with a composed character.
5557
9778ebcc
EZ
55582011-08-18 Eli Zaretskii <eliz@gnu.org>
5559
0be6ee06
EZ
5560 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5561 character bidirectional type, use STRONG_L instead. Fixes crashes
5562 in a buffer produced by `describe-categories'.
5563
9778ebcc
EZ
5564 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5565 members before the level stack, so they would be saved and
5566 restored when copying iterator state. Fixes incorrect reordering
5567 around TABs covered by display properties.
5568
156bffbe
AS
55692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5570
6b02f655 5571 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5572
72ad093b
CY
55732011-08-17 Chong Yidong <cyd@stupidchicken.com>
5574
5575 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5576 (internal_condition_case_2, internal_condition_case_n):
5577 Remove unnecessary aborts (Bug#9081).
72ad093b 5578
35774242
EZ
55792011-08-17 Eli Zaretskii <eliz@gnu.org>
5580
5581 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5582 has no `load' handler, try opening the file locally. (Bug#9311)
5583
db76dd85
KB
55842011-08-16 Ken Brown <kbrown@cornell.edu>
5585
5586 * gmalloc.c: Expand comment.
5587
b215eee5
EZ
55882011-08-16 Eli Zaretskii <eliz@gnu.org>
5589
5590 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5591 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5592
a4579d33
KB
55932011-08-16 Ken Brown <kbrown@cornell.edu>
5594
5595 Fix memory allocation problems in Cygwin build (Bug#9273).
5596
5597 * unexcw.c ( __malloc_initialized): Declare external variable.
5598 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5599
8b76d6f8
SM
5600 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5601 New variables.
a4579d33
KB
5602 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5603 dumped emacs.
5604 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5605 in the static heap.
5606 [CYGWIN] (special_realloc): New function.
5607 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5608 requests to realloc storage in the static heap.
5609
3ebec551
PE
56102011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5611
5612 * bidi.c (bidi_initialize): Remove unused local.
5613
9fd8be00
EZ
56142011-08-15 Eli Zaretskii <eliz@gnu.org>
5615
6b02f655
SM
5616 * bidimirror.h:
5617 * biditype.h: Remove file.
5618 * makefile.w32-in ($(BLD)/bidi.$(O)):
5619 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5620
5621 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5622
5623 * chartab.c: Improve commentary for the uniprop_table API.
5624
32413314
EZ
5625 * bidi.c (bidi_paragraph_init): Support zero value of
5626 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5627 (bidi_initialize): Use uniprop_table instead of including
5628 biditype.h and bidimirror.h.
32413314 5629
9fd8be00
EZ
5630 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5631 coordinates of the iterator when restoring from ppos_it.
5632 (Bug#9296)
5633
5cf2b69b
KH
56342011-08-14 Kenichi Handa <handa@m17n.org>
5635
5636 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5637 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5638
daf17d00
EZ
56392011-08-14 Eli Zaretskii <eliz@gnu.org>
5640
5641 * xdisp.c (move_it_in_display_line_to): Don't invoke
5642 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5643 ppos_it. Fixes vertical cursor motion when line beginning is
5644 covered by an image. (Bug#9296)
5645
08e3161a
JD
56462011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5647
5648 * nsterm.h (ns_run_ascript): Declare.
5649 (NSAPP_DATA2_RUNASSCRIPT): Define.
5650
5651 * nsfns.m (as_script, as_result, as_status): New static variables.
5652 (ns_run_ascript): New function.
5e617bc2 5653 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5654 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5655 the event loop. Get status from as_status (Bug#7276).
5656
5657 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5658 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5659 the event loop (Bug#7276).
5660
a3720aa2
AS
56612011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5662
5663 * gnutls.c (QCgnutls_bootprop_priority)
5664 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5665 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5666 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5667 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5668 (QCgnutls_bootprop_verify_hostname_error)
5669 (QCgnutls_bootprop_callbacks_verify): Rename from
5670 Qgnutls_bootprop_..., all uses changed.
5671
5672 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5673 uses changed.
5674
0a0d27fb
PE
56752011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5676
19d5c50c
PE
5677 * xfaces.c (Qframe_set_background_mode): Now static.
5678 * dispextern.h (Qframe_set_background_mode): Remove decl.
5679
0a0d27fb
PE
5680 * process.c (Fnetwork_interface_info): Declare local only if needed.
5681
377538cb
JD
56822011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5683
5684 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5685 (Fnetwork_interface_list): Allocate in increments of bytes instead
5686 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5687 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5688 sockaddr.
5689 (struct ifflag_def): notrailers is smart on OSX.
5690 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5691 Get hardware address with getifaddrs if available.
5692
08fff70c
EZ
56932011-08-12 Eli Zaretskii <eliz@gnu.org>
5694
5695 * xdisp.c (iterate_out_of_display_property): xassert that
5696 IT->position is set to within IT->object's boundaries. Break from
5697 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5698 when IT->position is set up wrongly due to some bug.
5699 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5700 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5701 entry. Force push_it to save on the stack the current
5702 buffer/string position, to be restored by pop_it. Fix flags in
5703 the iterator structure wrt the object coming from a display
5704 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5705 properties. (Bug#9284)
5706
7be1c708 57072011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5708
7be1c708
CY
5709 * fontset.c (fontset_get_font_group): Add proper type checks.
5710 (Bug#9172)
aac0c6e3 5711
7be1c708 57122011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5713
7be1c708
CY
5714 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5715 and LC_VERSION_MIN_MACOSX.
5716 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5717 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5718
97bb72a6
EZ
57192011-08-08 Eli Zaretskii <eliz@gnu.org>
5720
5721 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5722 no-display-properties-and-no-overlays under bidi display.
5723 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5724 properties and overlays.
97bb72a6 5725
d5617611
CY
57262011-08-08 Chong Yidong <cyd@stupidchicken.com>
5727
37e11a63
CY
5728 * editfns.c (Fset_time_zone_rule): Document relationship with the
5729 setenv function.
5730
d5617611
CY
5731 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5732 the font entity extracted from the cache (Bug#8109).
5733
58872834
CY
57342011-08-07 Chong Yidong <cyd@stupidchicken.com>
5735
5736 * composite.c (autocmp_chars): Don't reset point. That is done by
5737 restore_point_unwind (Bug#5984).
5738
75bfc667
JL
57392011-08-07 Juri Linkov <juri@jurta.org>
5740
5741 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5742 to show the arg `TIME' instead of `TIMEVAL'.
5743
d1410150
EZ
57442011-08-06 Eli Zaretskii <eliz@gnu.org>
5745
5746 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5747 display property strides EOL and includes a newline, as in
5748 longlines-mode. (Bug#9254)
75b771e4
EZ
5749 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5750 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5751
5752 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5753 is non-zero, even if the data buffer is NULL. Fixes a crash in
5754 vertical-motion with longlines-mode. (Bug#9254)
5755
35928349
EZ
57562011-08-05 Eli Zaretskii <eliz@gnu.org>
5757
ec7cc85b
EZ
5758 * bidi.c <bidi_cache_total_alloc>: Now static.
5759 (bidi_initialize): Initialize bidi_cache_total_alloc.
5760
8b76d6f8 5761 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5762 cache. (Bug#9221)
5763
5764 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5765 amount allocated this far in `bidi_cache_total_alloc'.
5766 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5767 non-zero, only free the data buffer without restoring the cache
5768 contents. All callers changed.
5769
5770 * dispextern.h (bidi_unshelve_cache): Update prototype.
5771
5772 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5773 (move_it_in_display_line, move_it_to)
5774 (move_it_vertically_backward, move_it_by_lines): Replace the call
5775 to xfree to an equivalent call to bidi_unshelve_cache.
5776 (move_it_in_display_line_to): Fix logic of returning
412b6358 5777 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5778
e2e2423b
EZ
57792011-08-05 Eli Zaretskii <eliz@gnu.org>
5780
5781 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5782 came from a string character with a `cursor' property. (Bug#9229)
5783
ae9e757a
JD
57842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5785
5786 * Makefile.in (LIB_PTHREAD): New variable.
5787 (LIBES): Add LIB_PTHREAD (Bug#9216).
5788
5789 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5790 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5791
213bd7f2
AS
57922011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5793
6b02f655 5794 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5795
99aaf75f
JD
57962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5797
5798 * xterm.c (x_find_topmost_parent): New function.
5799 (x_set_frame_alpha): Find topmost parent window with
5800 x_find_topmost_parent and set the property there also (bug#9181).
5801 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5802
c74e9d86
PE
58032011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5804
5805 * callproc.c (Fcall_process): Avoid vfork clobbering
5806 the local vars buffer, coding_systems, current_dir.
5807
640c8776
SM
58082011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5809
5810 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5811
f26d0e4c
PE
58122011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5813
8a10d76c
PE
5814 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5815 so that it is not optimized away.
5816
f26d0e4c
PE
5817 * xdisp.c (compute_display_string_pos): Remove unused local.
5818
55439c61
EZ
58192011-08-02 Eli Zaretskii <eliz@gnu.org>
5820
5821 Fix slow cursor motion and scrolling in large buffers with
5822 selective display, like Org Mode buffers. (Bug#9218)
5823
5824 * dispextern.h (struct bidi_it): New member disp_prop_p.
5825
5826 * xdisp.c: Remove one-slot cache of display string positions.
5827 (compute_display_string_pos): Accept an additional argument
5e617bc2 5828 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5829 for a display string or property. If found, set DISP_PROP_P
5830 non-zero.
5831
5832 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5833 DISP_PROP_P, and pass it to compute_display_string_pos.
5834 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5835 non-zero. All callers of bidi_fetch_char changed.
5836
fb33fa43
SM
58372011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5838
5839 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5840
b099e063
DM
58412010-12-03 Don March <don@ohspite.net>
5842
5843 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5844 last character M-[char] is translated to ESC [char] (bug#7541).
5845
5cc7f7af
KH
58462011-08-02 Kenichi Handa <handa@m17n.org>
5847
d0fffa3f 5848 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5849
5850 * chartab.c (uniprop_table): Make it non-static.
5851
525d5e6e
EZ
58522011-08-01 Eli Zaretskii <eliz@gnu.org>
5853
5854 * xdisp.c (forward_to_next_line_start): Accept additional argument
5855 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5856 on the newline.
5857 (reseat_at_next_visible_line_start): Use the bidi iterator state
5858 returned by forward_to_next_line_start to restore the state of
5859 it->bidi_it after backing up to previous newline. (Bug#9212)
5860
31011111
AS
58612011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5862
5863 * regex.c (re_comp): Protoize.
5864 (re_exec): Fix return type.
5865 (regexec): Fix type of `ret'. (Bug#9203)
5866
476371c4
PE
58672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5868
e5d76069
PE
5869 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5870 This is needed if max-image-size is a floating-point number.
5871
9a79b20c
AS
58722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5873
5874 * print.c (print_object): Print empty symbol as ##.
5875
5876 * lread.c (read1): Read ## as empty symbol.
5877
d8c2fa78
AA
58782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5879
5880 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5881 setting frame foreground color (Bug#9175).
5882 (x_set_background_color): Likewise.
5883
ffe57a7a
AA
5884 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5885 contents (Bug#9176).
5886 (EmacsTooltip -init): Remove bezels and add shadows to
5887 tooltip windows.
5888
bf3492a5
AA
5889 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5890 or scroll bar (Bug#8470).
5891
d55e9c53
AA
5892 * nsfont.m (nsfont_open): Remove assignment to voffset and
5893 unnecessary vars hshink, expand, hd, full_height, min_height.
5894 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5895
5896 * nsterm.h (nsfont_info): Remove voffset field.
5897
d8c2fa78 58982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5899
5900 Implement strike-through and overline on NextStep (Bug#8863).
5901
5902 * nsfont.m (nsfont_open): Use underline position provided by font,
5903 instead of hard-coded value of 2.
5904 (nsfont_draw): Call ns_draw_text_decoration instead.
5905
5906 * nsterm.h: Add declaration for ns_draw_text_decoration.
5907
5908 * nsterm.m (ns_draw_text_decoration): New function for drawing
5909 underline, overline, and strike-through.
5910 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5911 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5912 accommodate underlining, etc.
4843aac3 5913
4cc60b9b
EZ
59142011-07-28 Eli Zaretskii <eliz@gnu.org>
5915
bc7ece87
EZ
5916 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5917 default.
4cc60b9b 5918
476371c4
PE
59192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5920
66606eea
PE
5921 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5922 Without this fix, if a signal arrives just after memory fills up,
5923 'malloc' might be invoked reentrantly.
5924
476371c4
PE
5925 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5926 In other words, assume that every image size is allowed, on non-X
5927 hosts. This assumption is probably wrong, but it lets Emacs compile.
5928
f3fcc40d
AS
59292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5930
5931 * regex.c (re_iswctype): Convert return values to boolean.
5932
350c992f
EZ
59332011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5934
5935 * xdisp.c (compute_display_string_pos): Don't use cached display
5936 string position if the buffer had its restriction changed.
5937 (Bug#9184)
5938
5266b4bb
PE
59392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5940
5941 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5942
2573a837 59432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5944
41f55ccd 5945 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5946
39e378da
PE
5947 * bidi.c: Integer size and overflow fixes.
5948 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5949 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5950 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5951 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5952 (bidi_find_other_level_edge):
5953 Use ptrdiff_t instead of EMACS_INT where either will do.
5954 This works better on 32-bit hosts configured --with-wide-int.
5955 (bidi_cache_ensure_space): Check for size-calculation overflow.
5956 Use % rather than repeated addition, for better worst-case speed.
5957 Don't set bidi_cache_size until after xrealloc returns, because it
5958 might not return.
5959 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5960 (bidi_cache_ensure_space): Also check that the bidi cache size
5961 does not exceed that of the largest Lisp string or buffer. See Eli
5962 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5963
5e927815
PE
5964 * alloc.c (__malloc_size_t): Remove.
5965 All uses replaced by size_t. See Andreas Schwab's note
5966 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5967
ca4aa935
PE
5968 * image.c: Improve checking for integer overflow.
5969 (check_image_size): Assume that f is nonnull, since
5970 it is always nonnull in practice. This is one less thing to
5971 worry about when checking for integer overflow later.
5972 (x_check_image_size): New function, which checks for integer
5973 overflow issues inside X.
5974 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5975 This removes the need for a memory_full check.
5976 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5977 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5978 (xbm_read_bitmap_data): Change locals back to 'int', since
5979 their values must fit in 'int'.
5980 (xpm_load_image, png_load, tiff_load):
5981 Invoke x_create_x_image_and_pixmap earlier,
5982 to avoid much needless work if the image is too large.
5983 (tiff_load): Treat overly large images as if
5984 x_create_x_image_and_pixmap failed, not as malloc failures.
5985 (gs_load): Use x_check_image_size.
5986
5f8f9cc2
PE
5987 * gtkutil.c: Omit integer casts.
5988 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5989 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5990
5adf60bc
PE
5991 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5992
c8907a93
PE
5993 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5994 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5995 would wrongly return t on a 64-bit host.
5996
e3c25c68
PE
5997 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5998 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5999 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6000 and therefore cause GCC to emit a bogus diagnostic in some cases.
6001
3f791afe
PE
6002 * image.c: Integer signedness and overflow and related fixes.
6003 This is not an exhaustive set of fixes, but it's time to
6004 record what I've got.
6005 (lookup_pixel_color, check_image_size): Remove redundant decls.
6006 (check_image_size): Don't assume that arbitrary EMACS_INT values
6007 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6008 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6009 (tiff_load, imagemagick_load_image):
6010 Check for overflow in size calculations.
6011 (x_create_x_image_and_pixmap): Remove unnecessary test for
6012 xmalloc returning NULL; that can't happen.
6013 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6014 (xpm_color_bucket): Use better integer hashing function.
6015 (xpm_cache_color): Don't possibly over-allocate memory.
6016 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6017 (gif_memory_source):
6018 Use ptrdiff_t, not int or size_t, to record sizes.
6019 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6020 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6021 either works, as we prefer signed integers.
6022 (tiff_read_from_memory, tiff_write_from_memory):
6023 Return tsize_t, not size_t, since that's what the TIFF API wants.
6024 (tiff_read_from_memory): Don't fail simply because the read would
6025 go past EOF; instead, return a short read.
6026 (tiff_load): Omit no-longer-needed casts.
6027 (Fimagemagick_types): Don't assume size fits into 'int'.
6028
3cc5a532
PE
6029 Improve hashing quality when configured --with-wide-int.
6030 * fns.c (hash_string): New function, taken from sxhash_string.
6031 Do not discard information about ASCII character case; this
6032 discarding is no longer needed.
6033 (sxhash-string): Use it. Change sig to match it. Caller changed.
6034 * lisp.h: Declare it.
6035 * lread.c (hash_string): Remove, since we now use fns.c's version.
6036 The fns.c version returns a wider integer if --with-wide-int is
6037 specified, so this should help the quality of the hashing a bit.
6038
b312a492
PE
6039 * emacs.c: Integer overflow minor fix.
6040 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6041 Define only if GNU_LINUX.
6042 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6043
dfd153ae
PE
6044 * dispnew.c: Integer signedness and overflow fixes.
6045 Remove unnecessary forward decls, that were a maintenance hassle.
6046 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6047 All uses changed.
6048 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6049 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6050 (prepare_desired_row, line_draw_cost):
6051 Use int, not unsigned, where either works.
6052 (save_current_matrix, restore_current_matrix):
6053 Use ptrdiff_t, not size_t, where either works.
6054 (init_display): Check for overflow more accurately, and without
6055 relying on undefined behavior.
6056
a81d11a3
PE
6057 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6058 Remove, replacing with the new symbols in lisp.h. All uses changed.
6059 * fileio.c (make_temp_name):
6060 * filelock.c (lock_file_1, lock_file):
6061 * xdisp.c (message_dolog):
6062 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6063 Use pMd etc. instead.
6064 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6065 replacing the pWIDE etc. symbols removed from editfns.c.
6066
3300e6fd
PE
6067 * keyboard.h (num_input_events): Now uintmax_t.
6068 This is (very slightly) less likely to mess up due to wraparound.
6069 All uses changed.
6070
fd05c7e9
PE
6071 * buffer.c: Integer signedness fixes.
6072 (alloc_buffer_text, enlarge_buffer_text):
6073 Use ptrdiff_t rather than size_t when either will do, as we prefer
6074 signed integers.
6075
903fe15d
PE
6076 * alloc.c: Integer signedness and overflow fixes.
6077 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6078 (__malloc_size_t): Default to size_t, not to int.
6079 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6080 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6081 Prefer ptrdiff_t to size_t when either would do, as we prefer
6082 signed integers.
6083 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6084 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6085 Now const. Initialize with values that are in range even if char
6086 is signed.
6087 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6088 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6089 These functions do the right thing with sizes > 2**32.
6090 (check_depth): Now ptrdiff_t, not int.
6091 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6092 Adjust to new way of storing sizes. Check for size overflow bugs
6093 in rest of code.
6094 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6095 slightly wrong anyway, as it missed one instance of
6096 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6097 (refill_memory_reserve): Omit needless cast to size_t.
6098 (mark_object_loop_halt): Mark as externally visible.
6099
ac82cc6a
PE
6100 * xselect.c: Integer signedness and overflow fixes.
6101 (Fx_register_dnd_atom, x_handle_dnd_message):
6102 Use ptrdiff_t, not size_t, since we prefer signed.
6103 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6104 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6105 x_dnd_atoms_size and x_dnd_atoms_length.
6106
c2d1e36d
PE
6107 * doprnt.c: Prefer signed to unsigned when either works.
6108 * eval.c (verror):
6109 * doprnt.c (doprnt):
6110 * lisp.h (doprnt):
6111 * xdisp.c (vmessage):
6112 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6113 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6114 prefer signed arithmetic to avoid comparison confusion.
6115 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6116 but is a bit tricky.
6117
0e926e56
PE
6118 Assume freestanding C89 headers, string.h, stdlib.h.
6119 * data.c, doprnt.c, floatfns.c, print.c:
6120 Include float.h unconditionally.
6121 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6122 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6123 * regex.c: Likewise for stddef.h, string.h.
6124 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6125 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6126 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6127 (STDC_HEADERS): Remove obsolete defines.
6128 * sysdep.c: Include limits.h unconditionally.
6129
9cfdb3ec
PE
6130 Assume support for memcmp, memcpy, memmove, memset.
6131 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6132 * regex.c (memcmp, memcpy):
6133 Remove; we assume C89 now.
6134
6135 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6136 (__malloc_safe_bcopy): Remove; no longer needed.
6137
cf950e6b 6138 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6139 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6140 well either way, and we prefer signed to unsigned.
6141
dbf38e02
LMI
61422011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6143
6144 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6145 closes the connection while we're reading (bug#9182).
6146
d6f0886c 61472011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6148
d6f0886c
JD
6149 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6150 are specified (Bug#9168).
24e0f6b1 6151
2eb1f9e6
PE
61522011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6153
6154 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6155 Found by GCC static checking and --with-wide-int on a 32-bit host.
6156
22381272 61572011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6158
6159 * xdisp.c (compute_display_string_pos): Fix logic of caching
6160 previous display string position. Initialize cached_prev_pos to
6161 -1. Fixes slow-down at the beginning of a buffer.
6162
f25e39b4
EZ
61632011-07-24 Eli Zaretskii <eliz@gnu.org>
6164
6165 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6166 for attrs[LFACE_FONTSET_INDEX].
6167
04c4b52e
PE
61682011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6169
6170 * xml.c (parse_region): Remove unused local
6171 that was recently introduced.
6172
c1734fbd
EZ
61732011-07-23 Eli Zaretskii <eliz@gnu.org>
6174
be18c5a5
EZ
6175 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6176 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6177
c1734fbd
EZ
6178 * xdisp.c (move_it_in_display_line_to): Record the best matching
6179 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6180 exit if none of the characters scanned was an exact match.
6181 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6182 when exact match is impossible due to invisible text, and the
6183 lines are truncated.
6184
a258d627
JD
61852011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6186
6187 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6188 for OSX >= 10.7.
6189
b6d5a689
EZ
61902011-07-22 Eli Zaretskii <eliz@gnu.org>
6191
0f74f785
EZ
6192 Fix a significant slow-down of cursor motion with C-n, C-p,
6193 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6194 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6195 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6196 (next_element_from_buffer): Call compute_stop_pos_backwards to
6197 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6198 base_level_stop.
6199 (reseat): Don't look for prev_stop, as that could mean a very long
6200 run.
6201 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6202 <cached_disp_overlay_modiff>: Cache for last found display string
6203 position.
551918c1 6204 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6205 about the same buffer in the same area of character positions, and
6206 the buffer wasn't changed since the time the display string
6207 position was cached.
551918c1 6208
b2d0c91a
EZ
62092011-07-22 Eli Zaretskii <eliz@gnu.org>
6210
6211 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6212 is an integer, which is important for empty lines. (Bug#9149)
6213
043604ee
CY
62142011-07-22 Chong Yidong <cyd@stupidchicken.com>
6215
6216 * frame.c (Fmodify_frame_parameters): In tty case, update the
6217 default face if necessary (Bug#4238).
6218
da4adb04
CY
62192011-07-21 Chong Yidong <cyd@stupidchicken.com>
6220
6221 * editfns.c (Fstring_to_char): No need to explain what a character
6222 is in the docstring (Bug#6576).
6223
9abd0532
LMI
62242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6225
6226 * xml.c (parse_region): Make sure we always return a tree.
6227
36881d16
HK
62282011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6229
6230 * xml.c (parse_region): If a document contains only comments,
6231 return that, too.
6232
1e98674d
LMI
62332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6234
6235 * xml.c (make_dom): Return comments, too.
6236
590bd467
PE
62372011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6238
6239 Port to OpenBSD.
6240 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6241 and the surrounding thread.
6242 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6243 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6244 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6245 timer goes off.
6246 * s/openbsd.h (BROKEN_SIGIO): Define.
6247 * unexelf.c (unexec) [__OpenBSD__]:
6248 Don't update the .mdebug section of the Alpha COFF symbol table.
6249
f41628b2
LMI
62502011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6251
6252 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6253 (bug#8460).
6254
b59b67c5
PE
62552011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6256
15e3a074
PE
6257 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6258 This fixes some race conditions on the permissions of any newly
6259 created file.
6260
41bed37d
PE
6261 * alloc.c (valid_pointer_p): Use pipe, not open.
6262 This fixes some permissions issues when debugging.
6263
b59b67c5
PE
6264 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6265 If fchown fails to set both uid and gid, try to set just gid,
6266 as that is sometimes allowed. Adjust the file's mode to eliminate
6267 setuid or setgid bits that are inappropriate if fchown fails.
6268
925a6be7
SM
62692011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6270
6271 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6272 to compare Lisp_Objects.
6273 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6274 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6275 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6276
52968808
AS
62772011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6278
0a6a104b
AS
6279 * lread.c (read_integer): Unread even EOF character.
6280 (read1): Likewise. Properly record start position of symbol.
6281
52968808
AS
6282 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6283 symbol character follows.
6284
9e381cdd
PE
62852011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6286
6287 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6288 This works around a problem with the previous change to Fcopy_file.
6289 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6290 and without this change, GCC might complain about discarding
6291 fchown's return value.
6292
b5641435
JB
62932011-07-16 Juanma Barranquero <lekktu@gmail.com>
6294
6295 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6296
a8031457
PE
62972011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6298
6299 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6300
dd889327
LMI
63012011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6302
750c33f7
LMI
6303 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6304 it's used from the C level.
6305
dd889327
LMI
6306 * process.c: Use the same condition for POLL_FOR_INPUT in both
6307 keyboard.c and process.c (bug#1858).
6308
87e86684
LM
63092011-07-09 Lawrence Mitchell <wence@gmx.li>
6310
6311 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6312 (Fgnutls_boot): Use it.
6313
64348f40
AS
63142011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6315
6316 * doc.c (Fsubstitute_command_keys): Revert last change.
6317
1d698799
LMI
63182011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6319
f863868c
LMI
6320 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6321 quotes the next character, and doesn't affect other longer
6322 sequences (bug#8935).
6323
1d698799
LMI
6324 * lread.c (syms_of_lread): Clarify that is isn't only
6325 `eval-buffer' and `eval-defun' that's affected by
6326 `lexical-binding' (bug#8460).
6327
aa4b6df6
EZ
63282011-07-15 Eli Zaretskii <eliz@gnu.org>
6329
6330 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6331 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6332
5d856da6
PE
63332011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6334
ad6042bb
PE
6335 Fix minor problems found by static checking.
6336 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6337 (elsz): Now a signed constant, not a size_t var. We prefer signed
6338 types to unsigned, to avoid integer comparison confusion. Without
6339 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6340 "cannot optimize loop, the loop counter may overflow", a symptom
6341 of the confusion.
f00bbb22 6342 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6343 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6344
6468f31c
LMI
63452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6346
49080b10
LMI
6347 * search.c (Fre_search_backward): Mention `case-fold-search' in
6348 all the re_search_* functions (bug#8138).
6349
6468f31c
LMI
6350 * keyboard.c (Fopen_dribble_file): Document when the file is
6351 closed (bug#8056).
6352
c965adc5
EZ
63532011-07-14 Eli Zaretskii <eliz@gnu.org>
6354
df9733bf
EZ
6355 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6356 bidi_cache_idx.
6357
0bb23927
EZ
6358 Support bidi reordering of display and overlay strings.
6359 * xdisp.c (compute_display_string_pos)
6360 (compute_display_string_end): Accept additional argument STRING.
6361 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6362 (reseat_to_string): Initialize bidi_it->string.s and
6363 bidi_it->string.schars.
6364 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6365 NULL (avoids a crash in bidi_paragraph_init).
6366 Initialize itb.string.lstring.
0bb23927
EZ
6367 (init_iterator): Call bidi_init_it only of a valid
6368 buffer position was specified. Initialize paragraph_embedding to
6369 L2R.
6370 (reseat_to_string): Initialize the bidi iterator.
6371 (display_string): If we need to ignore text properties of
6372 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6373 original value of -1 will not work with bidi.)
6374 (compute_display_string_pos): First arg is now struct
6375 `text_pos *'; all callers changed. Support display properties on
6376 Lisp strings.
6377 (compute_display_string_end): Support display properties on Lisp
6378 strings.
6379 (init_iterator, reseat_1, reseat_to_string): Initialize the
6380 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6381 when iterating on a string not from display properties).
640c8776
SM
6382 (compute_display_string_pos, compute_display_string_end):
6383 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6384 arrow keys.
6385 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6386 base_level_stop; instead, set base_level_stop to BEGV.
6387 Fixes crashes in vertical-motion.
0bb23927
EZ
6388 (next_element_from_buffer): Improve commentary for when
6389 the iterator is before prev_stop.
6390 (init_iterator): Initialize bidi_p from the default value of
6391 bidi-display-reordering, not from buffer-local value. Use the
6392 buffer-local value only if initializing for buffer iteration.
6393 (handle_invisible_prop): Support invisible properties on strings
6394 that are being bidi-reordered.
6395 (set_iterator_to_next): Support bidi reordering of C strings and
6396 Lisp strings.
6397 (next_element_from_string): Support bidi reordering of Lisp
6398 strings.
6399 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6400 (display_string): Support display of R2L glyph rows.
6401 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6402 (init_iterator): Don't initialize it->bidi_p for strings
6403 here.
6404 (reseat_to_string): Initialize it->bidi_p for strings here.
6405 (next_element_from_string, next_element_from_c_string)
6406 (next_element_from_buffer): Add xassert's for correspondence
6407 between IT's object being iterated and it->bidi_it.string
6408 structure.
6409 (face_before_or_after_it_pos): Support bidi iteration.
6410 (next_element_from_c_string): Handle the case of the first string
6411 character that is not the first one in the visual order.
6412 (get_visually_first_element): New function, refactored from common
6413 parts of next_element_from_buffer, next_element_from_string, and
6414 next_element_from_c_string.
6415 (tool_bar_lines_needed, redisplay_tool_bar)
6416 (display_menu_bar): Force left-to-right direction. Add a FIXME
6417 comment for making that be controlled by a user option.
6418 (push_it, pop_it): Save and restore the state of the
6419 bidi iterator. Save and restore the bidi_p flag.
6420 (pop_it): Iterate out of display property for string iteration as
6421 well.
6422 (iterate_out_of_display_property): Support iteration over strings.
6423 (handle_single_display_spec): Set up it->bidi_it for iteration
6424 over a display string, and call bidi_init_it.
6425 (handle_single_display_spec, next_overlay_string)
6426 (get_overlay_strings_1, push_display_prop): Set up the bidi
6427 iterator for displaying display or overlay strings.
6428 (forward_to_next_line_start): Don't use the shortcut if
6429 bidi-iterating.
6430 (back_to_previous_visible_line_start): If handle_display_prop
6431 pushed the iterator stack, restore the internal state of the bidi
6432 iterator by calling bidi_pop_it same number of times.
6433 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6434 and we are bidi-iterating, don't decrement the iterator position;
6435 instead, set the first_elt flag in the bidi iterator, to produce
6436 the same effect.
6437 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6438 (push_display_prop): xassert that we are iterating a buffer.
6439 (push_it, pop_it): Save and restore paragraph_embedding member.
6440 (handle_single_display_spec, next_overlay_string)
6441 (get_overlay_strings_1, reseat_1, reseat_to_string)
6442 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6443 correctly. Don't assume unibyte strings are not bidi-reordered.
6444 (compute_display_string_pos)
6445 (compute_display_string_end): Fix handling the case of C string.
6446 (push_it, pop_it): Save and restore from_disp_prop_p.
6447 (handle_single_display_spec, push_display_prop): Set the
6448 from_disp_prop_p flag.
6449 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6450 (pop_it): Call iterate_out_of_display_property only if we are
6451 popping after iteration over a string that came from a display
6452 property. Fix a typo in popping stretch info. Add an assertion
6453 for verifying that the iterator position is in sync with the bidi
6454 iterator.
6455 (handle_single_display_spec, get_overlay_strings_1)
6456 (push_display_prop): Fix initialization of paragraph direction for
6457 string when that of the parent object is not yet determined.
6458 (reseat_1): Call bidi_init_it to resync the bidi
6459 iterator with IT's position. (Bug#7616)
6460 (find_row_edges): If ROW->start.pos gives position
6461 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6462 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6463 Reset the from_disp_prop_p flag.
6464 (SAVE_IT, RESTORE_IT): New macros.
6465 (pos_visible_p, face_before_or_after_it_pos)
6466 (back_to_previous_visible_line_start)
6467 (move_it_in_display_line_to, move_it_in_display_line)
6468 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6469 (try_scrolling, redisplay_window, display_line): Use them when
6470 saving a temporary copy of the iterator and restoring it back.
6471 (back_to_previous_visible_line_start, reseat_1)
6472 (init_iterator): Empty the bidi cache "stack".
6473 (move_it_in_display_line_to): If iterator ended up at
6474 EOL, but we never saw any buffer positions smaller than
6475 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6476 motion in bidi-reordered lines.
6477 (move_it_in_display_line_to): Record prev_method and prev_pos
6478 immediately before the call to set_iterator_to_next. Fixes cursor
6479 motion in bidi-reordered lines with stretch glyphs and strings
6480 displayed in margins. (Bug#8133) (Bug#8867)
6481 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6482 TO_CHARPOS.
640c8776
SM
6483 (pos_visible_p): Support positions in bidi-reordered lines.
6484 Save and restore bidi cache.
0bb23927
EZ
6485
6486 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6487 (bidi_paragraph_info): Delete unused struct.
6488 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6489 (bidi_cache_start): New variable.
6490 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6491 to zero.
6492 (bidi_cache_fetch_state, bidi_cache_search)
6493 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6494 (bidi_cache_find, bidi_peek_at_next_level)
6495 (bidi_level_of_next_char, bidi_find_other_level_edge)
6496 (bidi_move_to_visually_next): Compare cache index with
6497 bidi_cache_start rather than with zero.
6498 (bidi_fetch_char): Accept new argument STRING; all callers
6499 changed. Support iteration over a string. Support strings with
6500 display properties. Support unibyte strings. Fix the type of
6501 `len' according to what STRING_CHAR_AND_LENGTH expects.
6502 (bidi_paragraph_init, bidi_resolve_explicit_1)
6503 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6504 (bidi_level_of_next_char, bidi_move_to_visually_next):
6505 Support iteration over a string.
0bb23927
EZ
6506 (bidi_set_sor_type, bidi_resolve_explicit_1)
6507 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6508 can now be zero (for strings); special values 0 and -1 were
6509 changed to -1 and -2, respectively.
6510 (bidi_char_at_pos): New function.
6511 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6512 Call it instead of FETCH_MULTIBYTE_CHAR.
6513 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6514 initialized to valid values.
6515 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6516 values.
6517 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6518 the test for valid cached positions. Fix the logic for looking up
6519 the sentinel state in the cache. GCPRO the Lisp string we are
6520 iterating.
6521 (bidi_push_it, bidi_pop_it): New functions.
6522 (bidi_initialize): Initialize the bidi cache start stack pointer.
6523 (bidi_cache_ensure_space): New function, refactored from part of
6524 bidi_cache_iterator_state. Don't assume the required size is just
6525 one BIDI_CACHE_CHUNK away.
6526 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6527 (bidi_count_bytes, bidi_char_at_pos): New functions.
6528 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6529 always valid if bidi_cache_idx is valid.
6530 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6531 is valid if it's going to be used.
6532 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6533 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6534 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6535 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6536 (bidi_find_other_level_edge, bidi_cache_start_stack):
6537 All variables related to cache indices are now EMACS_INT.
c965adc5 6538
0bb23927
EZ
6539 * dispextern.h (struct bidi_string_data): New structure.
6540 (struct bidi_it): New member `string'. Make flag members be 1-bit
6541 fields, and put them last in the struct.
640c8776
SM
6542 (compute_display_string_pos, compute_display_string_end):
6543 Update prototypes.
0bb23927
EZ
6544 (bidi_push_it, bidi_pop_it): Add prototypes.
6545 (struct iterator_stack_entry): New members bidi_p,
6546 paragraph_embedding, and from_disp_prop_p.
6547 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6548 (bidi_shelve_cache, bidi_unshelve_cache):
6549 Declare prototypes.
0bb23927
EZ
6550
6551 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6552 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6553 and vector-like objects.
6554
6555 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6556 cache around display iteration.
6557
6558 * window.c (Fwindow_end, window_scroll_pixel_based)
6559 (displayed_window_lines, Frecenter): Save and restore the bidi
6560 cache around display iteration.
6561
3bbd2265
LMI
65622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6563
6564 * editfns.c (Fdelete_region): Clarify the use of the named
6565 parameters (bug#6788).
6566
adc47434
MR
65672011-07-14 Martin Rudalics <rudalics@gmx.at>
6568
6569 * indent.c (Fvertical_motion): Set and restore w->pointm when
6570 saving and restoring the window's buffer (Bug#9006).
6571
837c31f8
LMI
65722011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6573
6574 * editfns.c (Fstring_to_char): Clarify just what is returned
6575 (bug#6576). Text by Eli Zaretskii.
6576
ac389d0c
JB
65772011-07-13 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6580
0be0ce47
EZ
65812011-07-13 Eli Zaretskii <eliz@gnu.org>
6582
6583 * buffer.c (mmap_find): Fix a typo.
6584
cd18e7e3
JB
65852011-07-13 Johan Bockgård <bojohan@gnu.org>
6586
6587 Fix execution of x selection hooks.
6588 * xselect.c (Qx_lost_selection_functions)
6589 (Qx_sent_selection_functions): New vars.
6590 (syms_of_xselect): DEFSYM them.
6591 (x_handle_selection_request): Pass Qx_sent_selection_functions
6592 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6593 (x_handle_selection_clear,x_clear_frame_selections):
6594 Pass Qx_lost_selection_functions rather than
6595 Vx_lost_selection_functions to Frun_hook_with_args.
6596
47ea7f44
PE
65972011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6598
ac389d0c 6599 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6600 The old code sometimes used this field without initializing it.
6601
47ea7f44
PE
6602 * alloc.c (gc_sweep): Don't read past end of array.
6603 In theory, the old code could also have corrupted Emacs internals,
6604 though it'd be very unlikely.
6605
bc985c87
AS
66062011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6607
6608 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6609 argument. (Bug#4026)
bc985c87 6610
0cf34688
LMI
66112011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6612
b3dadd76
LMI
6613 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6614 key" (bug#4257).
6615
0cf34688
LMI
6616 * window.c (Fset_window_start): Doc fix (bug#4199).
6617 (Fset_window_hscroll): Ditto.
6618
270768cd
PE
66192011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6620
077e3dda 6621 Fix minor new problems caught by GCC 4.6.1.
270768cd 6622 * term.c (init_tty): Remove unused local.
490011a6 6623 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6624 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6625 not used otherwise.
270768cd 6626
b1f58454
CY
66272011-07-12 Chong Yidong <cyd@stupidchicken.com>
6628
6629 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6630
22b9578d
LMI
66312011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6632
6e70ab07
LMI
6633 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6634 are the mini-buffer and the echo area (bug#3320).
6635
22b9578d
LMI
6636 * term.c (init_tty): Remove support for supdup, c10 and perq
6637 terminals, which are no longer supported (bug#1482).
6638
8974cc9f
JB
66392011-07-10 Johan Bockgård <bojohan@gnu.org>
6640
6641 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6642
a560d974
JD
66432011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6644
6645 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6646 for non-popups (Bug#3642).
6647
1dae0f0a
AS
66482011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6649
268c2c36 6650 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6651 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6652 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6653 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6654 * data.c (fmod): Likewise.
6655 * dispnew.c (swap_glyphs_in_rows): Likewise.
6656 * emacs.c (memory_warning_signal): Likewise.
6657 * floatfns.c (float_error): Likewise.
6658 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6659 (otf_open, font_otf_capability, generate_otf_features)
6660 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6661 Likewise.
6662 * image.c (pbm_read_file): Likewise.
6663 * indent.c (string_display_width): Likewise.
6664 * intervals.c (check_for_interval, search_for_interval)
6665 (inc_interval_count, count_intervals, root_interval)
6666 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6667 * lread.c (defalias): Likewise.
268c2c36 6668 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6669 * regex.c (set_image_of_range_1, set_image_of_range)
6670 (regex_grow_registers): Likewise.
6671 * sysdep.c (strerror): Likewise.
6672 * termcap.c (valid_filename_p, tprint, main): Likewise.
6673 * tparam.c (main): Likewise.
6674 * unexhp9k800.c (run_time_remap, save_data_space)
6675 (update_file_ptrs, read_header, write_header, calculate_checksum)
6676 (copy_file, copy_rest, display_header): Likewise.
6677 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6678 Likewise.
6679 * xdisp.c (check_it): Likewise.
6680 * xfaces.c (register_color, unregister_color, unregister_colors):
6681 Likewise.
6682 * xfns.c (print_fontset_result): Likewise.
6683 * xrdb.c (member, fatal, main): Likewise.
6684
99033785
PE
66852011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6686
6687 Fix minor problems found by static checking (Bug#9031).
6688 * chartab.c (char_table_set_range, map_sub_char_table):
6689 Remove unused locals.
6690 (uniprop_table): Now static.
6691 * composite.c (_work_char): Remove unused static var.
6692
9cb2ac56
JB
66932011-07-09 Juanma Barranquero <lekktu@gmail.com>
6694
6695 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6696
f25661f0
JD
66972011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6698
6699 * gtkutil.c (qttip_cb): Remove code without function.
6700
8278c4fe
EZ
67012011-07-09 Eli Zaretskii <eliz@gnu.org>
6702
6703 * w32.c (pthread_sigmask): New stub.
6704
1692ae2d 67052011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6706
8a6ebd58 6707 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6708 sigprocmask is portable only for single-threaded applications, and
6709 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6710 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6711 (LIBES): Use it.
6712 * callproc.c (Fcall_process):
6713 * process.c (create_process):
6714 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6715 Use pthread_sigmask, not sigprocmask.
123403e4 6716
1b854618
JD
67172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6718
6719 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6720 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6721 wrong (Bug#8591).
6722
3fe4b549
JD
67232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6724
0ce7e563
JD
6725 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6726 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6727 (xg_hide_tooltip): Fix comment.
6728
3fe4b549
JD
6729 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6730 in registerServicesMenuSendTypes.
6731 (validRequestorForSendType): Don't check ns_return_types.
6732
6733 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6734 ns_return_type.
6735
5df75e47
JR
67362011-07-08 Jason Rumney <jasonr@gnu.org>
6737
22610910
JR
6738 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6739 SH_SHOW for hidden windows (Bug#5482).
6740
5df75e47
JR
6741 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6742 frame struct members of non-existent frames (Bug#6284).
6743
699c10bd
JD
67442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6745
4393663b
JD
6746 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6747 variable firstTime not needed on OSX >= 10.6.
6748 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6749 >= 10.5. Use setKnobProportion, setDoubleValue.
6750
6751 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6752 (MAC_OS_X_VERSION_10_5): Define if not defined.
6753 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6754 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6755 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6756
6757 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6758 cString and lossyCString on OSX >= 10.4
6759
58179cce 6760 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6761 sizeToFit on OSX >= 10.2.
6762
6763 * nsimage.m (allocInitFromFile): Don't use deprecated method
6764 bestRepresentationForDevice on OSX >= 10.6.
6765
6766 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6767 to avoid warning.
6768
6769 * emacs.c: Declare unexec_init_emacs_zone.
6770
a63e0781
JD
6771 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6772
699c10bd
JD
6773 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6774
6775 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6776 on svcsMenu (Bug#8842).
6777
6778 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6779 ns_return_types.
6780 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6781
6782 * nsterm.m (QUTF8_STRING): Declare.
6783 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6784 (validRequestorForSendType): Return type is (id).
6785 Change indexOfObjectIdenticalTo to indexOfObject.
6786 Check if we have local selection before returning self (Bug#8842).
6787 (writeSelectionToPasteboard): Put local selection into paste board
6788 if we have a local selection (Bug#8842).
6789 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6790
6791 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6792 (ns_get_local_selection): Declare.
6793
54e10184
LMI
67942011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6795
9888ff71
LMI
6796 * keymap.c (describe_map_tree): Don't insert a double newline at
6797 the end of the buffer (bug#1169) and return whether we inserted
6798 something.
6799
54e10184
LMI
6800 * callint.c (Fcall_interactively): Change "reading args" to
6801 "providing args" to try to clarify what it does (bug#1010).
6802
15fa4783
KH
68032011-07-07 Kenichi Handa <handa@m17n.org>
6804
6805 * composite.c (composition_compute_stop_pos): Ignore a static
6806 composition starting before CHARPOS (Bug#8915).
6807
6808 * xdisp.c (handle_composition_prop): Likewise.
6809
a8815b00
EZ
68102011-07-07 Eli Zaretskii <eliz@gnu.org>
6811
6812 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6813 (Bug#9015)
6814
ef7b981d 68152011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6816
6817 * character.h (unicode_category_t): New enum type.
6818
6819 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6820 (Qchar_code_property_table): New variable.
6821 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6822 (UNIPROP_COMPRESSED_FORM_P): New macros.
6823 (char_table_ascii): Uncompress the compressed values.
6824 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6825 Uncompress the compressed values.
ac389d0c 6826 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6827 (char_table_ref_and_range): Uncompress the compressed values.
6828 (sub_char_table_set): New arg is_uniprop. Callers changed.
6829 Uncompress the compressed values.
6830 (sub_char_table_set_range): Args changed. Callers changed.
6831 (char_table_set_range): Adjuted for the above change.
6832 (map_sub_char_table): Delete args default_val and parent. Add arg
6833 top. Give decoded values to a Lisp function.
640c8776 6834 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6835 values to a Lisp function. Gcpro more variables.
6836 (uniprop_table_uncompress)
6837 (uniprop_decode_value_run_length): New functions.
6838 (uniprop_decoder, uniprop_decoder_count): New variables.
6839 (uniprop_get_decoder, uniprop_encode_value_character)
6840 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6841 New functions.
6842 (uniprop_encoder, uniprop_encoder_count): New variables.
6843 (uniprop_get_encoder, uniprop_table)
6844 (Funicode_property_table_internal, Fget_unicode_property_internal)
6845 (Fput_unicode_property_internal): New functions.
6846 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6847 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6848 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6849 char-code-property-alist.
6850
640c8776 6851 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6852 Vunicode_category_table.
6853
640c8776 6854 * font.c (font_range): Adjust for the change of
c805dec0
KH
6855 Vunicode_category_table.
6856
76b397fb
DN
68572011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6858
6859 * m/iris4d.h: Remove file, move contents ...
6860 * s/irix6-5.h: ... here.
6861
22b4128e
PE
68622011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6863
6864 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6865 * alloc.c (mark_buffer):
6866 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6867 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6868 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6869 This isn't true in general, and it's particularly not true
6870 if Emacs is configured with --with-wide-int.
6871 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6872 New macros, used in the buffer.c change.
6873
869795d6
JD
68742011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6875
6876 * xsettings.c: Use both GConf and GSettings if both are available.
6877 (store_config_changed_event): Add comment.
6878 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6879 (store_tool_bar_style_changed): New functions.
5e617bc2 6880 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6881 (struct xsettings): Move font inside HAVE_XFT.
6882 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6883 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6884 Move inside HAVE_XFT.
640c8776 6885 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6886 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6887 also.
6888 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6889 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6890 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6891 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6892 (parse_settings): Move check for font inside HAVE_XFT.
6893 (read_settings, apply_xft_settings): Add comment.
6894 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6895 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6896 call store_font_name_changed.
6897 (xft_settings_event): Add comment.
6898 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6899 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6900 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6901 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6902 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6903 (xsettings_get_system_font, xsettings_get_system_normal_font):
6904 Add comment.
869795d6 6905
d8ed26bd
PE
69062011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6907
6908 Random fixes. E.g., (random) never returned negative values.
6909 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6910 subseconds part to the entropy, as that's a bit more random.
6911 Prefer signed to unsigned, since the signedness doesn't matter and
6912 in general we prefer signed. When given a limit, use a
6913 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6914 latter isn't right if USE_2_TAGS_FOR_INTS.
6915 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6916 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6917
cabf1cac
SM
69182011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6919
6920 * textprop.c (text_property_stickiness):
6921 Obey Vtext_property_default_nonsticky.
6922 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6923 * w32fns.c (syms_of_w32fns):
6924 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6925
6e9b2be9
PE
69262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6927
6928 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6929 This is more efficient than Ffile_directory_p and avoids a minor race.
6930
90186c68
LMI
69312011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6932
7c301272
LMI
6933 * buffer.c (Foverlay_put): Say what the return value is
6934 (bug#7835).
6935
c4f2d8d4
LMI
6936 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6937 is a directory before asking whether to use the file name
6938 (bug#7564).
ad637907
LMI
6939 (barf_or_query_if_file_exists): Make the "File is a directory"
6940 error be more correct.
c4f2d8d4 6941
90186c68
LMI
6942 * fns.c (Frequire): Remove the mention of the .gz files, since
6943 that's installation-specific, but keep the mention of
6944 `get-load-suffixes'.
6945
da64016e
PE
69462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6947
6948 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6949 Report string overflow if the output is too long.
6950
7d47b580
JB
69512011-07-04 Juanma Barranquero <lekktu@gmail.com>
6952
a555cb87
JB
6953 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6954 (syms_of_gnutls): Remove duplicate DEFSYM for
6955 Qgnutls_bootprop_verify_hostname_error, an error for
6956 Qgnutls_bootprop_verify_error (which is no longer used).
6957
7d47b580
JB
6958 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6959 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6960 Also (re)move comments that are misplaced or no longer relevant.
6961
1e49bfab
LMI
69622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6963
6964 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6965
1485f4c0
CY
69662011-07-03 Chong Yidong <cyd@stupidchicken.com>
6967
6968 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6969 and background color parameters if they have been changed.
6970
a9ab721e
LMI
69712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6972
6973 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6974
cf7cff57
PE
69752011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6976
2e13213d
PE
6977 * xsettings.c (SYSTEM_FONT): Define only when used.
6978 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6979
cf7cff57
PE
6980 * keymap.c (access_keymap_1): Now static.
6981
7a8e04f7
CY
69822011-07-02 Chong Yidong <cyd@stupidchicken.com>
6983
6984 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6985 leave any prefix arg for the up event (Bug#1586).
6986
61352f62
LMI
69872011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6988
69bb1ef7
LMI
6989 * lread.c (syms_of_lread): Mention single symbols defined by
6990 `defvar' or `defconst' (bug#7154).
6991
61352f62 6992 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6993 (Frequire): Mention get-load-suffixes.
61352f62 6994
28545e04
MR
69952011-07-02 Martin Rudalics <rudalics@gmx.at>
6996
6997 * window.h (window): Remove clone_number slot.
6998 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6999 Remove.
7000 (make_parent_window, make_window, saved_window)
7001 (Fset_window_configuration, save_window_save): Don't deal with
7002 clone numbers.
7003 * buffer.c (Qclone_number): Remove declaration.
7004 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7005
3349e122
SM
70062011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7007
7008 Add multiple inheritance to keymaps.
7009 * keymap.c (Fmake_composed_keymap): New function.
7010 (Fset_keymap_parent): Simplify.
7011 (fix_submap_inheritance): Remove.
7012 (access_keymap_1): New function extracted from access_keymap to handle
7013 embedded parents and handle lists of maps.
7014 (access_keymap): Use it.
7015 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7016 (Fcopy_keymap): Handle embedded parents.
7017 (Fcommand_remapping, define_as_prefix): Simplify.
7018 (Fkey_binding): Simplify.
7019 (syms_of_keymap): Move minibuffer-local-completion-map,
7020 minibuffer-local-filename-completion-map,
7021 minibuffer-local-must-match-map, and
7022 minibuffer-local-filename-must-match-map to Elisp.
7023 (syms_of_keymap): Defsubr make-composed-keymap.
7024 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7025 (parse_menu_item): Trivial simplification.
7026
3279eb87
GM
70272011-07-01 Glenn Morris <rgm@gnu.org>
7028
7029 * Makefile.in (SETTINGS_LIBS): Fix typo.
7030
4550efdf
KI
70312011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7032
7033 * coding.c (Fencode_coding_string): Record the last coding system
7034 used, as the function doc string says (bug#8738).
7035
0949d2b6
JD
70362011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7037
7038 * xsettings.c (store_monospaced_changed): Take new font as arg and
7039 check for change against current_mono_font.
7040 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7041 (emacs_settings_constructor, emacs_settings_get_property)
7042 (emacs_settings_set_property, emacs_settings_class_init)
7043 (emacs_settings_init, gsettings_obj): Remove.
7044 (something_changedCB): New function for HAVE_GSETTINGS.
7045 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7046 with value as argument.
7047 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7048 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7049 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7050 "changed".
7051
7052 * xgselect.c: Add defined (HAVE_GSETTINGS).
7053 (xgselect_initialize): Ditto.
7054
7055 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7056 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7057 xg_select.
7058
bbc6b304
PE
70592011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7060
7061 * eval.c (struct backtrace): Simplify and port the data structure.
7062 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7063 signed bit field, as this assumption is not portable and it makes
7064 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7065 "char debug_on_exit : 1" as this is not portable either; instead,
7066 use the portable "unsigned int debug_on_exit : 1". Remove unused
7067 member evalargs. Remove obsolete comments about cc bombing out.
7068
9851bfc5
JD
70692011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7070
51bb811f 7071 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7072 Let HAVE_GSETTINGS override HAVE_GCONF.
7073 (store_monospaced_changed): New function.
7074 (EMACS_SETTINGS): A new type derived from GObject to handle
7075 GSettings notifications.
7076 (emacs_settings_constructor, emacs_settings_get_property)
7077 (emacs_settings_set_property, emacs_settings_class_init):
7078 New functions.
7079 (gsettings_client, gsettings_obj): New variables.
7080 (GSETTINGS_SCHEMA): New define.
7081 (something_changedCB): Call store_monospaced_changed.
7082 (init_gsettings): New function.
7083 (xsettings_initialize): Call init_gsettings.
7084 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7085 to NULL.
7086
640c8776 7087 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7088 GCONF_CFLAGS/LIBS.
7089
5386012d
MR
70902011-06-29 Martin Rudalics <rudalics@gmx.at>
7091
7092 * window.c (resize_root_window, grow_mini_window)
7093 (shrink_mini_window): Rename Qresize_root_window to
7094 Qwindow_resize_root_window and Qresize_root_window_vertically to
7095 Qwindow_resize_root_window_vertically.
7096
f13e0b08
PE
70972011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7098
7099 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7100
94515237
JB
71012011-06-27 Juanma Barranquero <lekktu@gmail.com>
7102
7103 * makefile.w32-in: Redesign dependencies so they reflect more
7104 clearly which files are directly included by each source file,
7105 and not through other includes.
7106
e43b6e43
MR
71072011-06-27 Martin Rudalics <rudalics@gmx.at>
7108
7109 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7110 (sort_overlays, overlay_strings): When an overlay's clone number
7111 matches the window's clone number process the overlay even if
7112 the overlay's window property doesn't match the current window.
7113
d68443dc
MR
7114 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7115 (Fwindow_hchild): Rename to Fwindow_left_child.
7116 (Fwindow_next): Rename to Fwindow_next_sibling.
7117 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7118 (resize_window_check): Rename to window_resize_check.
7119 (resize_window_apply): Rename to window_resize_apply.
7120 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7121 (Fdelete_other_windows_internal, resize_frame_windows)
7122 (Fsplit_window_internal, Fdelete_window_internal)
7123 (grow_mini_window, shrink_mini_window)
7124 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7125
c7e73be5
JD
71262011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7127
7128 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7129 (emacs_fixed_set_min_size): Remove.
7130 (emacs_fixed_new): Take frame as argument.
7131
7132 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7133 (_EmacsFixedPrivate): Remove minwidth/height.
7134 Add struct frame *f.
7135 (emacs_fixed_init): Initialize priv->f.
7136 (get_parent_class, emacs_fixed_set_min_size): Remove.
7137 (emacs_fixed_new): Set priv->f to argument.
7138 (emacs_fixed_get_preferred_width)
7139 (emacs_fixed_get_preferred_height): Use min_width/height from
7140 frames size_hint to set minimum and natural (Bug#8919).
7141 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7142 and use min_width/height from frames size_hint to set
7143 min_width/height (Bug#8919).
7144
7145 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7146 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7147 Fix indentation.
c7e73be5 7148
cf99dcf8
EZ
71492011-06-26 Eli Zaretskii <eliz@gnu.org>
7150
7151 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7152 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7153 called at ZV.
7154
029529ac
CY
71552011-06-26 Chong Yidong <cyd@stupidchicken.com>
7156
7157 * process.c (wait_reading_process_output): Bypass select if
7158 waiting for a cell while ignoring keyboard input, and input is
7159 pending. Suggested by Jan Djärv (Bug#8869).
7160
7a7ef429
PE
71612011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7162
7163 Use gnulib's dup2 module instead of rolling our own.
7164 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7165
11fdef7d 71662011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7167
7168 * dispnew.c (scrolling_window): Before scrolling, turn off a
7169 mouse-highlight in the window being scrolled.
7170
cd3520a4
JB
71712011-06-24 Juanma Barranquero <lekktu@gmail.com>
7172
7173 Move DEFSYM to lisp.h and use everywhere.
7174
7175 * character.h (DEFSYM): Move declaration...
7176 * lisp.h (DEFSYM): ...here.
7177
7178 * gnutls.c:
7179 * minibuf.c:
7180 * w32menu.c:
7181 * w32proc.c:
7182 * w32select.c: Don't include character.h.
7183
7184 * alloc.c (syms_of_alloc):
7185 * buffer.c (syms_of_buffer):
7186 * bytecode.c (syms_of_bytecode):
7187 * callint.c (syms_of_callint):
7188 * casefiddle.c (syms_of_casefiddle):
7189 * casetab.c (init_casetab_once):
7190 * category.c (init_category_once, syms_of_category):
7191 * ccl.c (syms_of_ccl):
7192 * cmds.c (syms_of_cmds):
7193 * composite.c (syms_of_composite):
7194 * dbusbind.c (syms_of_dbusbind):
7195 * dired.c (syms_of_dired):
7196 * dispnew.c (syms_of_display):
7197 * doc.c (syms_of_doc):
7198 * editfns.c (syms_of_editfns):
7199 * emacs.c (syms_of_emacs):
7200 * eval.c (syms_of_eval):
7201 * fileio.c (syms_of_fileio):
7202 * fns.c (syms_of_fns):
7203 * frame.c (syms_of_frame):
7204 * fringe.c (syms_of_fringe):
7205 * insdel.c (syms_of_insdel):
7206 * keymap.c (syms_of_keymap):
7207 * lread.c (init_obarray, syms_of_lread):
7208 * macros.c (syms_of_macros):
7209 * msdos.c (syms_of_msdos):
7210 * print.c (syms_of_print):
7211 * process.c (syms_of_process):
7212 * search.c (syms_of_search):
7213 * sound.c (syms_of_sound):
7214 * syntax.c (init_syntax_once, syms_of_syntax):
7215 * terminal.c (syms_of_terminal):
7216 * textprop.c (syms_of_textprop):
7217 * undo.c (syms_of_undo):
7218 * w32.c (globals_of_w32):
7219 * window.c (syms_of_window):
7220 * xdisp.c (syms_of_xdisp):
7221 * xfaces.c (syms_of_xfaces):
7222 * xfns.c (syms_of_xfns):
7223 * xmenu.c (syms_of_xmenu):
7224 * xsettings.c (syms_of_xsettings):
7225 * xterm.c (syms_of_xterm): Use DEFSYM.
7226
4228cf16
TZ
72272011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7228
cd3520a4 7229 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7230
7fcccf1e
PE
72312011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7232
7efb4e0e
PE
7233 Integer and buffer overflow fixes (Bug#8873).
7234
ff5844ad
PE
7235 * print.c (printchar, strout): Check for string overflow.
7236 (PRINTPREPARE, printchar, strout):
7237 Don't set size unless allocation succeeds.
7238
90532f02
PE
7239 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7240 for sizes. Check for string overflow more accurately.
7241 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7242
6d84508d
PE
7243 * macros.c: Integer and buffer overflow fixes.
7244 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7245 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7246 Use ptrdiff_t, not int, for sizes.
7247 Don't increment bufsize until after realloc succeeds.
7248 Check for size-calculation overflow.
7249 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7250
437b2cb4
PE
7251 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7252
8b9ac8b4
PE
7253 * lread.c: Integer overflow fixes.
7254 (read_integer): Radix is now EMACS_INT, not int,
7255 to improve quality of diagnostics for out-of-range radices.
7256 Calculate buffer size correctly for out-of-range radices.
7257 (read1): Check for integer overflow in radices, and in
7258 read-circle numbers.
82cb60d3
PE
7259 (read_escape): Avoid int overflow.
7260 (Fload, openp, read_buffer_size, read1)
7261 (substitute_object_recurse, read_vector, read_list, map_obarray):
7262 Use ptrdiff_t, not int, for sizes.
7263 (read1): Use EMACS_INT, not int, for sizes.
20270765 7264 Check for size overflow.
8b9ac8b4 7265
7fcccf1e
PE
7266 * image.c (cache_image): Check for size arithmetic overflow.
7267
bfbbd7e7
PE
7268 * lread.c: Integer overflow issues.
7269 (saved_doc_string_size, saved_doc_string_length)
7270 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7271 Now ptrdiff_t, not int.
7272 (read1): Don't assume doc string length fits in int. Check for
7273 out-of-range doc string lengths.
7274 (read_list): Don't assume file position fits in int.
39019e54 7275 (read_escape): Check for hex character overflow.
bfbbd7e7 7276
4e323265
LL
72772011-06-22 Leo Liu <sdl.web@gmail.com>
7278
7279 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7280 Move to minibuffer.el.
7281
85fece3e
PE
72822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7283
20b84ce9 7284 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7285 The following patches are for when GLYPH_DEBUG && !XASSERT.
7286 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7287 * dispnew.c (flush_stdout):
7288 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7289 Mark as externally visible.
7290 * dispnew.c (check_window_matrix_pointers): Now static.
7291 * dispnew.c (window_to_frame_vpos):
7292 * xfns.c (unwind_create_frame):
7293 * xterm.c (x_check_font): Remove unused local.
7294 * scroll.c (CHECK_BOUNDS):
7295 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7296 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7297 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7298 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7299 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7300 Now static.
7301 (debug_method_add): Use va_list and vsprintf rather than relying
7302 on undefined behavior with wrong number of arguments.
7303 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7304 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7305 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7306 since we're not interested in debugging glyphs with old libraries.
7307 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7308 GCC 4.6.0's static checking.
7309
0766b489
PE
73102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7311
31fd4b32
PE
7312 Integer overflow and signedness fixes (Bug#8873).
7313 A few related buffer overrun fixes, too.
7314
b79e8648
PE
7315 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7316
0766b489
PE
7317 * dispextern.h (struct face.stipple):
7318 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7319 (x_bitmap_mask, x_allocate_bitmap_record)
7320 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7321 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7322 (x_create_bitmap_from_xpm_data):
7323 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7324 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7325 (.bitmaps_last):
7326 * xfaces.c (load_pixmap):
7327 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7328 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7329 (.bitmaps_last, struct x_output.icon_bitmap):
7330 Use ptrdiff_t, not int, for bitmap indexes.
7331 (x_allocate_bitmap_record): Check for size overflow.
7332 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7333
b081724f
PE
7334 Use ptrdiff_t, not int, for overlay counts.
7335 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7336 * editfns.c (overlays_around, get_pos_property):
7337 * textprop.c (get_char_property_and_overlay):
7338 * xdisp.c (next_overlay_change, note_mouse_highlight):
7339 * xfaces.c (face_at_buffer_position):
21514da7
PE
7340 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7341 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7342 (Fnext_overlay_change, Fprevious_overlay_change)
7343 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7344 Use ptrdiff_t, not int, for sizes.
21514da7 7345 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7346
3de73e5e
PE
7347 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7348
2606c57b
PE
7349 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7350 (x_session_initialize): Do not assume string length fits in int.
7351
aaafe47a
PE
7352 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7353 This is unlikely, but can occur if DPI is outlandish.
7354
2674ddc8 7355 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7356 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7357
28154962
PE
7358 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7359 * xrdb.c (magic_file_p, search_magic_path):
7360 Omit last arg SUFFIX; it was always 0. All callers changed.
7361 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7362
7de51af5
PE
7363 * xfont.c (xfont_match): Avoid need for strlen.
7364
25ed6cc3
PE
7365 * xfns.c: Don't assume strlen fits in int.
7366 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7367
4eab31dd
PE
7368 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7369 not unsigned long, as we prefer signed integers. All callers changed.
7370 Detect integer overflow in repeat count.
7371 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7372 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7373
171e2a58
PE
7374 * termcap.c: Don't assume sizes fit in int and never overflow.
7375 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7376 (gobble_line): Check for size-calculation overflow.
7377
ad39faca 7378 * minibuf.c (Fread_buffer):
6e5bb2dc 7379 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7380 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7381 Don't assume string length fits in int.
7382
52c61c22 7383 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7384 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7385
b5b8c9e5
PE
7386 * font.c: Don't assume string length fits in int.
7387 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7388 Use ptrdiff_t, not int.
ccd6111c
PE
7389 (font_intern_prop): Don't assume string length fits in int.
7390 Don't assume integer property fits in fixnum.
7391 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7392
882f0d81 7393 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7394 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7395 Reformulate so as not to need the command string.
7396 Invoke gzip -cd rather than gunzip, as it's more portable.
7397 (lock_info_type, lock_file_1, lock_file):
7398 Don't assume pid_t and time_t fit in unsigned long.
7399 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7400 (current_lock_owner): Prefer signed type for sizes.
7401 Use memcpy, not strncpy, where memcpy is what is really wanted.
7402 Don't assume (via atoi) that time_t and pid_t fit in int.
7403 Check for time_t and/or pid_t out of range, e.g., via a network share.
7404 Don't alloca where an auto var works fine.
7405
93f4cf88
PE
7406 * fileio.c: Fix some integer overflow issues.
7407 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7408 Don't assume string length fits in int.
7409 (directory_file_name): Don't assume string length fits in long.
7410 (make_temp_name): Don't assume pid fits in int, or that its print
7411 length is less than 20.
7412
f3e92b69
PE
7413 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7414
1bfdaf10
PE
7415 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7416
35016e9a
PE
7417 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7418
3d1e65a1
PE
7419 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7420 We prefer signed integers, even for size calculations.
7421
0b963a93
PE
7422 * emacs.c: Don't assume string length fits in 'int'.
7423 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7424 (main): Don't invoke strlen when not needed.
7425
573f4b54
PE
7426 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7427 (XD_DEBUG_MESSAGE): Don't waste a byte.
7428
989f33ba
PE
7429 * callproc.c (getenv_internal_1, getenv_internal)
7430 (Fgetenv_internal):
965d34eb
PE
7431 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7432
e4d29b33
PE
7433 * lread.c (invalid_syntax): Omit length argument.
7434 All uses changed. This doesn't fix a bug, but it simplifies the
7435 code away from its former Hollerith-constant appearance, and it's
7436 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7437 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7438
eb49b136
PE
7439 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7440 This didn't break anything, but it didn't help either.
7441 It's confusing to put a bogus integer in a place where the actual
7442 value does not matter.
9f62aeb1 7443 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7444 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7445
15375a22
PE
7446 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7447 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7448 implementation.
b61cc01c
PE
7449 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7450 We prefer signed types, and the value cannot exceed the EMACS_INT
7451 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7452 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7453 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7454 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7455
53b2623d
PE
7456 * indent.c (sane_tab_width): New function.
7457 (current_column, scan_for_column, Findent_to, position_indentation)
7458 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7459 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7460
51cab52b 7461 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7462
f2ed8a70
PE
7463 * lisp.h (lint_assume): New macro.
7464 * composite.c (composition_gstring_put_cache):
7465 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7466
abe80cc6
PE
7467 * editfns.c, insdel.c:
7468 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7469
b02c740e
PE
7470 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7471
ebc96716
PE
7472 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7473
b4e50fa0 7474 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7475 Use much-faster test for byte-length change.
311d5d7c 7476 Don't assume string byte-length fits in 'int'.
a4cf38e4 7477 Check that character arg fits in 'int'.
85461888 7478 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7479
c0c1ee9f
PE
7480 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7481
a498d7f4
PE
7482 * fns.c (concat): Catch string overflow earlier.
7483 Do not rely on integer wraparound.
7484
51cab52b
PE
7485 * dispextern.h (struct it.overlay_strings_charpos)
7486 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7487 * xdisp.c (forward_to_next_line_start)
7488 (back_to_previous_visible_line_start)
7489 (reseat_at_next_visible_line_start, next_element_from_buffer):
7490 Don't arbitrarily truncate the value of 'selective' to int.
7491
76031fad
PE
7492 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7493
5eb55db9
PE
7494 * composite.c: Don't truncate sizes to 'int'.
7495 (composition_gstring_p, composition_reseat_it)
7496 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7497 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7498 not EMACS_UINT, for indexes.
5eb55db9 7499
0703a717
PE
7500 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7501
d6202519
PE
7502 * buffer.c: Include <verify.h>.
7503 (struct sortvec.priority, struct sortstr.priority):
8961a454 7504 Now EMACS_INT, not int.
c20998a7 7505 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7506 (struct sortstr.size, record_overlay_string)
7507 (struct sortstrlist.size, struct sortlist.used):
7508 Don't truncate size to int.
7509 (record_overlay_string): Check for size-calculation overflow.
d6202519 7510 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7511
d5a19415
JM
75122011-06-22 Jim Meyering <meyering@redhat.com>
7513
029529ac 7514 Don't leak an XBM-image-sized buffer
d5a19415
JM
7515 * image.c (xbm_load): Free the image buffer after using it.
7516
a9041e6c
PE
75172011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7518
7519 Port to Sun C.
7520 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7521 that Sun C diagnosed.
7522 * fns.c (secure_hash): Fix pointer signedness issue.
7523 * intervals.c (static_offset_intervals): New function.
7524 (offset_intervals): Use it.
7525
7f3f739f
LL
75262011-06-21 Leo Liu <sdl.web@gmail.com>
7527
7528 * deps.mk (fns.o):
7529 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7530 sha512.h.
7531
7532 * fns.c (secure_hash): Rename from crypto_hash_function and change
7533 the first arg to accept symbols.
5b66d427 7534 (Fsecure_hash): New primitive.
7f3f739f
LL
7535 (syms_of_fns): New symbols.
7536
76147d94
DD
75372011-06-20 Deniz Dogan <deniz@dogan.se>
7538
7539 * process.c (Fset_process_buffer): Clarify return value in
7540 docstring.
7541
7d7d0045
CY
75422011-06-18 Chong Yidong <cyd@stupidchicken.com>
7543
7544 * dispnew.c (add_window_display_history): Use BVAR.
7545
7546 * xdisp.c (debug_method_add): Use BVAR.
7547 (check_window_end, dump_glyph_matrix, dump_glyph)
7548 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7549
7550 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7551 Likewise.
7552
7553 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7554 check till after the cache is created in init_frame_faces.
7555
ff2bc410
SM
75562011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7557
7558 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7559
28177add
PE
75602011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7561
dd3482fe
PE
7562 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7563 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7564 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7565
393d71f3 7566 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7567 * fileio.c (Finsert_file_contents):
7568 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7569 Remove the old (too-loose) buffer overflow checks.
7570 They weren't needed, since make_gap checks for buffer overflow.
7571 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7572 The old code merely checked for Emacs fixnum overflow, and relied
7573 on undefined (wraparound) behavior. The new code avoids undefined
7574 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7575
2e6813b0 7576 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7577 Tune. Don't use wider integers than needed. Don't use alloca.
7578 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7579
599a9e4f
PE
7580 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7581
99561444
PE
7582 * insdel.c, lisp.h (buffer_overflow): New function.
7583 (insert_from_buffer_1, replace_range, replace_range_2):
7584 * insdel.c (make_gap_larger):
7585 * editfns.c (Finsert_char):
7586 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7587
28177add
PE
7588 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7589
e69dafad
PE
75902011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7591
4baa020d 7592 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7593
b1c46f02
PE
7594 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7595 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7596
e69dafad
PE
7597 * fileio.c: Don't assume EMACS_INT fits in off_t.
7598 (emacs_lseek): New static function.
7599 (Finsert_file_contents, Fwrite_region): Use it.
7600 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7601
566684ea
PE
7602 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7603
e6966cd6
PE
7604 * fns.c: Don't overflow int when computing a list length.
7605 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7606 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7607 truncation on 64-bit hosts. Check for QUIT every
7608 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7609 faster and is responsive enough.
7610 (Flength): Report an error instead of overflowing an integer.
7611 (Fsafe_length): Return a float if the value is not representable
7612 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7613 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7614 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7615
dd0b0efb
PE
7616 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7617 (header_size, word_size): New constants.
7618 (allocate_vectorlike): Don't check size overflow here.
7619 (allocate_vector): Check it here instead, since this is the only
7620 caller of allocate_vectorlike that could cause overflow.
7621 Check that the new vector's length is representable as a fixnum.
7622
86fe5cfe
PE
7623 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7624 The previous code was bogus. For example, next_almost_prime (32)
7625 returned 39, which is undesirable as it is a multiple of 3; and
7626 next_almost_prime (24) returned 25, which is a multiple of 5 so
7627 why was the code bothering to check for multiples of 7?
7628
80e88859
PE
7629 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7630
4a2f0ad6
PE
7631 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7632
f66c7cf8
PE
7633 Variadic C functions now count arguments with ptrdiff_t.
7634 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7635 Back then I didn't know that the Emacs coding style prefers signed int.
7636 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7637 were being counted with int, which may truncate counts on 64-bit
7638 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7639 * lisp.h (struct Lisp_Subr.function.aMANY)
7640 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7641 Arg counts are now ptrdiff_t, not size_t.
7642 All variadic functions and their callers changed accordingly.
7643 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7644 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7645 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7646 * callint.c (Fcall_interactively): Check arg count for overflow,
7647 to avoid potential buffer overrun. Use signed char, not 'int',
7648 for 'varies' array, so that we needn't bother to check its size
7649 calculation for overflow.
7650 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7651 * eval.c (apply_lambda):
7652 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7653 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7654 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7655
a1759b76
PE
7656 * callint.c (Fcall_interactively): Don't use index var as event count.
7657
d96be9fc
PE
7658 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7659 * mem-limits.h (SIZE): Remove; no longer used.
7660
a690a978 7661 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7662
578c21e6
PE
7663 Remove unnecessary casts.
7664 * xterm.c (x_term_init):
7665 * xfns.c (x_set_border_pixel):
7666 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7667 These aren't needed now that we assume ANSI C.
7668
96f53c6c
PE
7669 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7670 It's more likely to cause problems (due to unsigned overflow)
7671 than to cure them.
7672
83c77d31
PE
7673 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7674
ee2079f1
PE
7675 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7676
6da65536
PE
7677 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7678
7147c4a4
PE
7679 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7680
193e32d9
PE
7681 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7682
e5533da6
PE
7683 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7684
9910e595
PE
7685 GLYPH_CODE_FACE returns EMACS_INT, not int.
7686 * dispextern.h (merge_faces):
7687 * xfaces.c (merge_faces):
01103c44
PE
7688 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7689 Don't assume EMACS_INT fits in int.
9910e595 7690
2638320e
PE
7691 * character.h (CHAR_VALID_P): Remove unused parameter.
7692 * fontset.c, lisp.h, xdisp.c: All uses changed.
7693
045eb8d9
PE
7694 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7695
c1f134b5
PE
7696 * fns.c (concat): Minor tuning based on overflow analysis.
7697 This doesn't fix any bugs. Use int to hold character, instead
7698 of constantly refetching from Emacs object. Use XFASTINT, not
7699 XINT, for value known to be a character. Don't bother comparing
7700 a single byte to 0400, as it's always less.
7701
395fcb93 7702 * floatfns.c (Fexpt):
327eeec8
PE
7703 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7704
abbd3d23
PE
7705 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7706 for characters.
7707
684a03ef
PE
7708 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7709
0fed43f3
PE
7710 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7711 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7712 incorrectly succeed when S was a string, because 4294967386 was
7713 truncated before it was used.
7714
8fd02eb7
PE
7715 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7716 Otherwise, an out-of-range integer could cause undefined behavior
7717 on a 64-bit host.
7718
f8c86b69
PE
7719 * composite.c: Use int, not EMACS_INT, for characters.
7720 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7721 EMACS_INT, for values that are known to be in character range.
7722 This doesn't fix any bugs but is the usual style inside Emacs and
7723 may generate better code on 32-bit machines.
7724
34206dd2
PE
7725 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7726 This is for reasons similar to the recent CHAR_STRING fix.
7727 * charset.c (Fencode_char): Check that character arg is actually
7728 a character. Pass an int to ENCODE_CHAR.
7729 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7730 wider than 'int', as a compile-time check to prevent future regressions
7731 in this area.
7732
c5958d4c 7733 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7734
7735 Make sure a 64-bit char is never passed to CHAR_STRING.
7736 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7737 by silently ignoring the top 32 bits, allowing some values
7738 that were far too large to be valid characters.
7739 * character.h: Include <verify.h>.
7740 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7741 arguments are no wider than unsigned, as a compile-time check
7742 to prevent future regressions in this area.
7743 * data.c (Faset):
01103c44 7744 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7745 (Fsubst_char_in_region):
7746 * fns.c (concat):
7747 * xdisp.c (decode_mode_spec_coding):
7748 Adjust to CHAR_STRING's new requirement.
7749 * editfns.c (Finsert_char, Fsubst_char_in_region):
7750 * fns.c (concat): Check that character args are actually
7751 characters. Without this test, these functions did the wrong
7752 thing with wildly out-of-range values on 64-bit hosts.
7753
d37ca623
PE
7754 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7755 These casts should not be needed on 32-bit hosts, either.
7756 * keyboard.c (read_char):
7757 * lread.c (Fload): Remove casts to unsigned.
7758
ea204efb
PE
7759 * lisp.h (UNSIGNED_CMP): New macro.
7760 This fixes comparison bugs on 64-bit hosts.
7761 (ASCII_CHAR_P): Use it.
7762 * casefiddle.c (casify_object):
01103c44 7763 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7764 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7765 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7766 * dispextern.h (FACE_FROM_ID):
7767 * keyboard.c (read_char): Use UNSIGNED_CMP.
7768
41cb286c
PE
7769 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7770 not to EMACS_INT, to avoid GCC warning.
7771
4a1b9832
PE
7772 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7773
55daad71
PE
7774 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7775 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7776 isn't needed on 32-bit machines.
8f95c75c 7777
01103c44
PE
7778 * buffer.c (Fgenerate_new_buffer_name):
7779 Use EMACS_INT for count, not int.
0ceccced 7780 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7781
7782 * data.c (Qcompiled_function): Now static.
7783
c6f072e7
PE
7784 * window.c (window_body_lines): Now static.
7785
20ce5912
PE
7786 * image.c (gif_load): Rename local to avoid shadowing.
7787
9c4c5f81
PE
7788 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7789 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7790 * alloc.c (make_save_value): Integer argument is now of type
7791 ptrdiff_t, not int.
7792 (mark_object): Use ptrdiff_t, not int.
7793 * lisp.h (pD): New macro.
7794 * print.c (print_object): Use it.
7795
c0c5c8ae
PE
7796 * alloc.c: Use EMACS_INT, not int, to count objects.
7797 (total_conses, total_markers, total_symbols, total_vector_size)
7798 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7799 (total_free_floats, total_floats, total_free_intervals)
7800 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7801 Now EMACS_INT, not int. All uses changed.
7802 (Fgarbage_collect): Compute overall total using a double, so that
7803 integer overflow is less likely to be a problem. Check for overflow
7804 when converting back to an integer.
5a25e253
PE
7805 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7806 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7807 These were 'int' variables that could overflow on 64-bit hosts;
7808 they were never used, so remove them instead of repairing them.
211a0b2a 7809 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7810 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7811 Previously, this ceilinged at INT_MAX, but that doesn't work on
7812 64-bit machines.
e46bb31a 7813 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7814
c78baabf 7815 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7816 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7817 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7818 when a (possibly-narrower) signed value would do just as well.
7819 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7820
c9d624c6
PE
7821 * alloc.c: Catch some string size overflows that we were missing.
7822 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7823 for convenience in STRING_BYTES_MAX.
7824 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7825 The definition here is exact; the one in lisp.h was approximate.
7826 (allocate_string_data): Check for string overflow. This catches
7827 some instances we weren't catching before. Also, it catches
7828 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7829 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7830 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7831
c9d624c6
PE
7832 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7833 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7834 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7835
353032ce
PE
7836 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7837
2bccce07
PE
7838 * alloc.c (Fmake_string): Check for out-of-range init.
7839
0ac30604
SM
78402011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7841
7842 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7843
c195f2de
JD
78442011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7845
7846 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7847 xg_get_default_scrollbar_width.
7848
7849 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7850 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7851 (style_changed_cb): Call update_theme_scrollbar_width and call
7852 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7853 all frames (Bug#8505).
7854 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7855 Call gtk_window_set_resizable if HAVE_GTK3.
7856 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7857 and height if HAVE_GTK3 (Bug#8505).
7858 (scroll_bar_width_for_theme): New variable.
7859 (update_theme_scrollbar_width): New function.
7860 (xg_get_default_scrollbar_width): Move code to
7861 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7862 (xg_initialize): Call update_theme_scrollbar_width.
7863
7864 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7865
7866 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7867
e10ac9f1
MR
78682011-06-12 Martin Rudalics <rudalics@gmx.at>
7869
7870 * frame.c (make_frame): Call other_buffer_safely instead of
7871 other_buffer.
7872
7873 * window.c (temp_output_buffer_show): Call display_buffer with
7874 second argument Vtemp_buffer_show_specifiers and reset latter
7875 immediately after the call.
7876 (Vtemp_buffer_show_specifiers): New variable.
7877 (auto_window_vscroll_p, next_screen_context_lines)
7878 (Vscroll_preserve_screen_position): Remove leading asterisks from
7879 doc-strings.
7880
2d3c217e 78812011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7882
7b7f97e8 7883 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7884 * buffer.c (Qclone_number): Remove for now, as it's unused.
7885 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7886 (record_buffer): Remove unused local.
7887 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7888 (set_frame_buffer_list): Remove; unused.
7889 * frame.h (other_visible_frames): Remove decl.
7890 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7891 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7892 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7893 if HAVE_GPM.
7894 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7895 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7896 Define only if HAVE_GPM.
7897 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7898 (update_hints_inhibit): Remove; never set. All uses removed.
7899 * widgetprv.h (emacsFrameClassRec): Remove decl.
7900 * window.c (delete_deletable_window): Now returns void, since it
7901 wasn't returning anything.
7902 (compare_window_configurations): Remove unused locals.
7903 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7904 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7905 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7906 the same widths as pointers. This follows up on the 2011-05-06 patch.
7907 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7908 * xterm.h: Likewise.
7909 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7910
1384b89e
JB
79112011-06-12 Juanma Barranquero <lekktu@gmail.com>
7912
7913 * makefile.w32-in: Update dependencies.
7914 (LISP_H): Add lib/intprops.h.
7915
1100a63c
CY
79162011-06-11 Chong Yidong <cyd@stupidchicken.com>
7917
7918 * image.c (gif_load): Add animation frame delay to the metadata.
7919 (syms_of_image): Use DEFSYM. New symbol `delay'.
7920
6198ccd0
MR
79212011-06-11 Martin Rudalics <rudalics@gmx.at>
7922
7923 * window.c (delete_deletable_window): Re-add.
7924 (Fset_window_configuration): Rewrite to handle dead buffers and
7925 consequently deletable windows.
7926 (window_tree, Fwindow_tree): Remove. Supply functionality in
7927 window.el.
7928 (compare_window_configurations): Simplify code.
7929
b6e3633c
AS
79302011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7931
1ab0dee5
AS
7932 * image.c (imagemagick_load_image): Fix type mismatch.
7933 (Fimagemagick_types): Likewise.
7934
b6e3633c
AS
7935 * window.h (replace_buffer_in_windows): Declare.
7936
9397e56f
MR
79372011-06-11 Martin Rudalics <rudalics@gmx.at>
7938
7939 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7940 Qclone_number. Remove external declaration of Qdelete_window.
7941 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7942 code.
640c8776
SM
7943 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7944 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7945 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7946 buffer list implementation.
7947 (other_buffer_safely): New function.
7948 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7949 calls to replace_buffer_in_windows and
7950 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7951 if allowed.
7952 (record_buffer): Inhibit quitting and rewrite using quittable
7953 functions. Run Qbuffer_list_update_hook if allowed.
7954 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7955 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7956 Move switch-to-buffer to window.el.
9397e56f
MR
7957 (bury-buffer): Move to window.el.
7958 (Vbuffer_list_update_hook): New variable.
7959
7960 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7961 section.
7962
7963 * window.h (resize_frame_windows): Move up in code.
7964 (Fwindow_frame): Remove EXFUN.
7965 (replace_buffer_in_all_windows): Remove prototype.
7966 (replace_buffer_in_windows_safely): Add prototype.
7967
7968 * window.c: Declare Qdelete_window static again. Move down
7969 declaration of select_count.
7970 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7971 (Fother_window): Move to window.el.
7972 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7973 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7974 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7975 window.el.
7976 (replace_buffer_in_windows): Implement by calling
7977 Qreplace_buffer_in_windows.
7978 (replace_buffer_in_all_windows): Remove with some functionality
7979 moved into replace_buffer_in_windows_safely.
7980 (replace_buffer_in_windows_safely): New function.
7981 (select_window_norecord, select_frame_norecord): Move in front
7982 of run_window_configuration_change_hook. Remove now obsolete
7983 declarations.
640c8776
SM
7984 (Fset_window_buffer): Rewrite doc-string.
7985 Call Qrecord_window_buffer.
9397e56f
MR
7986 (keys_of_window): Move binding for other-window to window.el.
7987
b50691aa
CY
79882011-06-11 Chong Yidong <cyd@stupidchicken.com>
7989
7990 * dispextern.h (struct image): Replace data member, whose int_val
7991 and ptr_val fields were not used by anything, with a single
7992 lisp_val object.
7993
7994 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7995 (gif_clear_image, gif_load, imagemagick_load_image)
7996 (gs_clear_image, gs_load): Callers changed.
7997
3f754b86
PE
79982011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7999
cca69397
PE
8000 * buffer.h: Include <time.h>, for time_t.
8001 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8002
109e28d0
PE
8003 Fix minor problems found by static checking.
8004
60737f02
PE
8005 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8006
4b66faf3
PE
8007 Make identifiers static if they are not used in other modules.
8008 * data.c (Qcompiled_function, Qframe, Qvector):
8009 * image.c (QimageMagick, Qsvg):
8010 * minibuf.c (Qmetadata):
8011 * window.c (resize_window_check, resize_root_window): Now static.
8012 * window.h (resize_window_check, resize_root_window): Remove decls.
8013
109e28d0
PE
8014 * window.c (window_deletion_count, delete_deletable_window):
8015 Remove; unused.
46a4ce9e
PE
8016 (window_body_lines): Now static.
8017 (Fdelete_other_windows_internal): Mark vars as initialized.
8018 Make sure 'resize_failed' is initialized.
8019 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8020 (resize_window_apply): Remove unused local.
8021 * window.h (delete_deletable_window): Remove decl.
8022
109e28d0 8023 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8024 (imagemagick_load_image): Fix pointer signedness problem by changing
8025 last arg from unsigned char * to char *. All uses changed.
8026 Also, fix a local for similar reasons.
8027 Remove unused locals. Remove locals to avoid shadowing.
8028 (fn_rsvg_handle_free): Remove; unused.
8029 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8030 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8031
3f754b86
PE
8032 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8033
2547adb1
CY
80342011-06-10 Chong Yidong <cyd@stupidchicken.com>
8035
8036 * image.c (gif_load): Fix omitted cast error introduced by
8037 2011-06-06 change.
8038
2c8e37d4
MR
80392011-06-10 Martin Rudalics <rudalics@gmx.at>
8040
8041 * window.h (resize_proportionally, orig_total_lines)
8042 (orig_top_line): Remove from window structure.
8043 (set_window_height, set_window_width, change_window_heights)
8044 (Fdelete_window): Remove prototypes.
8045 (resize_frame_windows): Remove duplicate declaration.
8046
440a42e3
EZ
80472011-06-10 Eli Zaretskii <eliz@gnu.org>
8048
8049 * window.h (resize_frame_windows, resize_window_check)
8050 (delete_deletable_window, resize_root_window)
8051 (resize_frame_windows): Declare prototypes.
8052
8053 * window.c (resize_window_apply): Make definition be "static" to
8054 match the prototype.
8055
562dd5e9
MR
80562011-06-10 Martin Rudalics <rudalics@gmx.at>
8057
8058 * window.c: Remove declarations of Qwindow_size_fixed,
8059 window_min_size_1, window_min_size_2, window_min_size,
8060 size_window, window_fixed_size_p, enlarge_window, delete_window.
8061 Remove static from declaration of Qdelete_window, it's
8062 temporarily needed by Fbury_buffer.
8063 (replace_window): Don't assign orig_top_line and
8064 orig_total_lines.
8065 (Fdelete_window, delete_window): Remove. Window deletion is
8066 handled by window.el.
640c8776
SM
8067 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8068 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8069 (Fdelete_other_windows): Remove. Deleting other windows is
8070 handled by window.el.
8071 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8072 handled in window.el.
8073 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8074 Window minimum sizes are handled in window.el.
8075 (shrink_windows, size_window, set_window_height)
8076 (set_window_width, change_window_heights, window_height)
8077 (window_width, CURBEG, CURSIZE, enlarge_window)
8078 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8079 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8080 handled in window.el.
8081 (make_dummy_parent): Rename to make_parent_window and give it a
8082 second argument horflag.
8083 (make_window): Don't set resize_proportionally any more.
8084 (Fsplit_window): Remove. Windows are split in window.el.
8085 (save_restore_action, save_restore_orig_size)
8086 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8087 Resize mini windows in window.el.
8088 (grow_mini_window, shrink_mini_window): Implement by calling
8089 Qresize_root_window_vertically, resize_window_check and
8090 resize_window_apply.
640c8776
SM
8091 (saved_window, Fset_window_configuration, save_window_save):
8092 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8093 resize_proportionally.
8094 (window_min_height, window_min_width): Move to window.el.
8095 (keys_of_window): Move bindings for delete-other-windows,
8096 split-window, delete-window and enlarge-window to window.el.
8097
8098 * buffer.c: Temporarily extern Qdelete_window.
8099 (Fbury_buffer): Temporarily call Qdelete_window instead of
8100 Fdelete_window (Fbury_buffer will move to window.el soon).
8101
8102 * frame.c (set_menu_bar_lines_1): Remove code handling
8103 orig_top_line and orig_total_lines.
8104
8105 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8106 set_window_height but set heights directly.
8107 (change_frame_size_1): Use resize_frame_windows.
8108
8109 * xdisp.c (init_xdisp): Don't use set_window_height but set
8110 heights directly.
8111
640c8776
SM
8112 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8113 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8114 run_window_configuration_change_hook.
8115
8116 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8117 instead of change_window_heights and run
8118 run_window_configuration_change_hook.
8119
1a13852e
MR
81202011-06-09 Martin Rudalics <rudalics@gmx.at>
8121
8122 * window.c (replace_window): Rename second argument REPLACEMENT to
8123 NEW. New third argument SETFLAG. Rewrite.
8124 (delete_window, make_dummy_parent): Call replace_window with
8125 third argument 1.
8126 (window_list_1): Move down in code.
8127 (run_window_configuration_change_hook): Move set_buffer part
8128 before select_frame_norecord part in order to unwind correctly.
8129 Rename count1 to count.
8130 (recombine_windows, delete_deletable_window, resize_root_window)
8131 (Fdelete_other_windows_internal)
8132 (Frun_window_configuration_change_hook, make_parent_window)
8133 (resize_window_check, resize_window_apply, Fresize_window_apply)
8134 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8135 (Fdelete_window_internal, Fresize_mini_window_internal):
8136 New functions.
1a13852e
MR
8137 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8138
f3d1777e
MR
81392011-06-08 Martin Rudalics <rudalics@gmx.at>
8140
496e208e
MR
8141 * window.h (window): Add some new members to window structure -
8142 normal_lines, normal_cols, new_total, new_normal, clone_number,
8143 splits, nest, prev_buffers, next_buffers.
8144 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8145 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8146
f3d1777e
MR
8147 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8148 Remove.
496e208e
MR
8149 (make_dummy_parent): Set new members of windows structure.
8150 (make_window): Move down in code. Handle new members of window
8151 structure.
8152 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8153 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8154 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8155 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8156 (Fset_window_next_buffers, Fset_window_clone_number):
8157 New functions.
496e208e
MR
8158 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8159 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8160 Doc-string fixes.
8161 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8162 Argument WINDOW can be now internal window too.
8163 (Fwindow_use_time): Move up in code.
8164 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8165 Rewrite doc-string.
8166 (Fset_window_configuration, saved_window)
8167 (Fcurrent_window_configuration, save_window_save): Handle new
8168 members of window structure.
b9e809c2
MR
8169 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8170 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8171 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8172 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8173 Qget_mru_window, Qresize_root_window,
8174 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8175 Qauto_buffer_name; staticpro them.
f3d1777e 8176
abde8f8c
MR
81772011-06-07 Martin Rudalics <rudalics@gmx.at>
8178
8179 * window.c (Fwindow_total_size, Fwindow_left_column)
8180 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8181 (Fwindow_list_1): New functions.
8182 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8183 (Fwindow_width, Fscroll_left, Fscroll_right):
8184 Use window_body_cols instead of window_box_text_cols.
8185 (delete_window, Fset_window_configuration):
8186 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8187 (delete_all_subwindows): Take a window as argument and not a
8188 structure. Rewrite.
190b47e6
MR
8189 (window_loop): Remove handling of GET_LRU_WINDOW and
8190 GET_LARGEST_WINDOW.
8191 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8192
8193 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8194 window_box_text_cols. delete_all_subwindows now takes a
8195 Lisp_Object as argument.
abde8f8c 8196
640c8776
SM
8197 * indent.c (compute_motion, Fcompute_motion):
8198 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8199
fa8a67e6
MR
8200 * frame.c (delete_frame): Call delete_all_subwindows with root
8201 window as argument.
8202
a54e3482
DC
82032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8204
8205 * fns.c (Fputhash): Document return value.
8206
60002bf5
CY
82072011-06-06 Chong Yidong <cyd@stupidchicken.com>
8208
8209 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8210
0c671da6 82112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8212
b862a52a 8213 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8214
be44ca6c
PE
8215 Check for overflow when converting integer to cons and back.
8216 * charset.c (Fdefine_charset_internal, Fdecode_char):
8217 Use cons_to_unsigned to catch overflow.
8218 (Fencode_char): Use INTEGER_TO_CONS.
8219 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8220 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8221 * data.c (long_to_cons, cons_to_long): Remove.
8222 (cons_to_unsigned, cons_to_signed): New functions.
8223 These signal an error for invalid or out-of-range values.
8224 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8225 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8226 * font.c (Ffont_variation_glyphs):
8227 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8228 * lisp.h: Include <intprops.h>.
8229 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8230 (cons_to_signed, cons_to_unsigned): New decls.
8231 (long_to_cons, cons_to_long): Remove decls.
8232 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8233 (Fprimitive_undo): Use CONS_TO_INTEGER.
8234 * xfns.c (Fx_window_property): Likewise.
8235 * xselect.c: Include <limits.h>.
8236 (x_own_selection, selection_data_to_lisp_data):
8237 Use INTEGER_TO_CONS.
8238 (x_handle_selection_request, x_handle_selection_clear)
8239 (x_get_foreign_selection, Fx_disown_selection_internal)
8240 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8241 (lisp_data_to_selection_data): Use cons_to_unsigned.
8242 (x_fill_property_data): Use cons_to_signed.
8243 Report values out of range.
8244
d1f3d2af
PE
8245 Check for buffer and string overflow more precisely.
8246 * buffer.h (BUF_BYTES_MAX): New macro.
8247 * lisp.h (STRING_BYTES_MAX): New macro.
8248 * alloc.c (Fmake_string):
8249 * character.c (string_escape_byte8):
8250 * coding.c (coding_alloc_by_realloc):
8251 * doprnt.c (doprnt):
8252 * editfns.c (Fformat):
8253 * eval.c (verror):
8254 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8255 since they may not be the same number.
8256 * editfns.c (Finsert_char):
8257 * fileio.c (Finsert_file_contents):
8258 Likewise for BUF_BYTES_MAX.
8259
dd52fcea
PE
8260 * image.c: Use ptrdiff_t, not int, for sizes.
8261 (slurp_file): Switch from int to ptrdiff_t.
8262 All uses changed.
8263 (slurp_file): Check that file size fits in both size_t (for
8264 malloc) and ptrdiff_t (for sanity and safety).
8265
7f9bbdbb
PE
8266 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8267 if b->modtime has its maximal value.
8268
dfe18f82
PE
8269 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8270
84acfcf0
PE
8271 Don't assume time_t can fit into int.
8272 * buffer.h (struct buffer.modtime): Now time_t, not int.
8273 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8274 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8275
ccd9a01a
PE
8276 Minor fixes for signed vs unsigned integers.
8277 * character.h (MAYBE_UNIFY_CHAR):
8278 * charset.c (maybe_unify_char):
8279 * keyboard.c (read_char, reorder_modifiers):
8280 XINT -> XFASTINT, since the integer must be nonnegative.
8281 * ftfont.c (ftfont_spec_pattern):
8282 * keymap.c (access_keymap, silly_event_symbol_error):
8283 XUINT -> XFASTINT, since the integer must be nonnegative.
8284 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8285 since it makes no difference and we prefer signed.
8286 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8287 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8288 nonnegative.
8289
d6d100dd
SM
82902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8291
8292 * window.h (Fwindow_frame): Declare.
8293
2b6148e4
PE
82942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8295
8296 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8297 (SPARE_MEMORY): Always define.
8298 (LARGE_REQUEST): Remove.
8299 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8300
f230ecc9
MR
83012011-06-06 Martin Rudalics <rudalics@gmx.at>
8302
727e958e
MR
8303 * lisp.h: Move EXFUNS for Fframe_root_window,
8304 Fframe_first_window and Fset_frame_selected_window to window.h.
8305
8306 * window.h: Move EXFUNS for Fframe_root_window,
8307 Fframe_first_window and Fset_frame_selected_window here from
8308 lisp.h.
8309
8310 * frame.c (Fwindow_frame, Fframe_first_window)
8311 (Fframe_root_window, Fframe_selected_window)
8312 (Fset_frame_selected_window): Move to window.c.
8313 (Factive_minibuffer_window): Move to minibuf.c.
8314 (Fother_visible_frames_p): New function.
8315
8316 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8317
f230ecc9
MR
8318 * window.c (decode_window, decode_any_window): Move up in code.
8319 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8320 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8321 (Fwindow_buffer): Move up and rewrite doc-string.
8322 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8323 (Fwindow_prev): New functions.
727e958e
MR
8324 (Fwindow_frame): Move here from frame.c. Accept any window as
8325 argument.
8326 (Fframe_root_window, Fframe_first_window)
8327 (Fframe_selected_window): Move here from frame.c. Accept frame
8328 or arbitrary window as argument. Update doc-strings.
8329 (Fminibuffer_window): Move up in code.
8330 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8331 (Fset_frame_selected_window): Move here from frame.c.
8332 Marginal rewrite.
727e958e
MR
8333 (Fselected_window, select_window, Fselect_window): Move up in
8334 code. Minor doc-string fixes.
f230ecc9 8335
4d09bcf6
PE
83362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8337
8338 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8339 Do not assume that spare memory exists; that assumption is valid
8340 only if SYSTEM_MALLOC.
8341 (LARGE_REQUEST): New macro, so that the issue of large requests
8342 is separated from the issue of spare memory.
8343
810928a2
AS
83442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8345
172418ad
AS
8346 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8347 format. (Bug#8806)
8348
43f862f7
AS
8349 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8350
810928a2
AS
8351 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8352 before statements.
8353
a059fe24
JD
83542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8355
8356 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8357
8358 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8359
8360 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8361 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8362
989bf368
JB
83632011-06-05 Juanma Barranquero <lekktu@gmail.com>
8364
8365 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8366
4b80f674
CY
83672011-06-04 Chong Yidong <cyd@stupidchicken.com>
8368
8369 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8370 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8371 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8372 New error handlers.
4b80f674
CY
8373 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8374 Obey Vx_select_enable_clipboard_manager. Catch errors in
8375 x_clipboard_manager_save (Bug#8779).
8376 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8377 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8378
99a33b77 83792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8380
8381 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8382
99a33b77 83832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8384
8385 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8386 in the current matrix if keep_current_p is non-zero.
8387
8264569d
EZ
83882011-06-04 Eli Zaretskii <eliz@gnu.org>
8389
8390 * bidi.c (bidi_level_of_next_char): Fix last change.
8391
57f97249
EZ
83922011-06-03 Eli Zaretskii <eliz@gnu.org>
8393
fec2107c 8394 Support bidi reordering of text covered by display properties.
57f97249 8395
fec2107c
EZ
8396 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8397 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8398 (bidi_cache_search, bidi_cache_iterator_state)
8399 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8400 (bidi_level_of_next_char, bidi_move_to_visually_next):
8401 Support character positions inside a run of characters covered by a
fec2107c
EZ
8402 display string.
8403 (bidi_paragraph_init, bidi_resolve_explicit_1)
8404 (bidi_level_of_next_char): Call bidi_fetch_char and
8405 bidi_fetch_char_advance instead of FETCH_CHAR and
8406 FETCH_CHAR_ADVANCE.
8407 (bidi_init_it): Initialize new members.
8408 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8409 definitions.
8410 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8411 instead of using explicit *_CHAR codes.
d6d100dd
SM
8412 (bidi_resolve_explicit, bidi_resolve_weak):
8413 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8414 bidirectional text is supported only in multibyte buffers.
8415 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8416 it to initialize the frame_window_p member of struct bidi_it.
8417 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8418 (bidi_resolve_explicit, bidi_resolve_weak)
8419 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8420 bidi_it->nchars is non-positive.
8421 (bidi_level_of_next_char): Don't try to lookup the cache for the
8422 next/previous character if nothing is cached there yet, or if we
8423 were just reseat()'ed to a new position.
c40e2fb2 8424
0e14fe90
EZ
8425 * xdisp.c (set_cursor_from_row): Set start and stop points
8426 according to the row's direction when priming the loop that looks
8427 for the glyph on which to display cursor.
8428 (single_display_spec_intangible_p): Function deleted.
8429 (display_prop_intangible_p): Reimplement to call
8430 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8431 Accept 3 additional arguments needed by handle_display_spec.
8432 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8433 values: lists, `(when COND...)' forms, etc.
8434 (single_display_spec_string_p): Support property values that are
8435 lists with the argument STRING its top-level element.
8436 (display_prop_string_p): Fix the condition for processing a
8437 property that is a list to be consistent with handle_display_spec.
fec2107c 8438 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8439 last portion of handle_display_prop.
8440 (compute_display_string_pos): Accept additional argument
8441 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8442 value of a `display' property is a "replacing spec".
8443 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8444 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8445 the display property, but just return a value indicating whether
8446 the display property will replace the characters it covers.
8447 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8448 frame_window_p members of struct bidi_it.
d6d100dd
SM
8449 (compute_display_string_pos, compute_display_string_end):
8450 New functions.
fec2107c
EZ
8451 (push_it): Accept second argument POSITION, where pop_it should
8452 jump to continue iteration.
8453 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8454
fec2107c
EZ
8455 * keyboard.c (adjust_point_for_property): Adjust the call to
8456 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8457
8458 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8459 (bidi_init_it): Update prototypes.
8460 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8461 (compute_display_string_pos, compute_display_string_end):
8462 Declare prototypes.
fec2107c
EZ
8463 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8464 EMACS_INT.
fc6f18ce 8465
40087514 84662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8467
57f53182
PE
8468 Malloc failure behavior now depends on size of allocation.
8469 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8470 * lisp.h: Change signatures accordingly.
8471 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8472 All callers changed. (Bug#8762)
8473
8474 * gnutls.c: Use Emacs's memory allocators.
8475 Without this change, the gnutls library would invoke malloc etc.
8476 directly, which causes problems on non-SYNC_INPUT hosts, and which
8477 runs afoul of improving memory_full behavior. (Bug#8761)
8478 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8479 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8480 xfree instead of the default malloc, realloc, free.
8481 (Fgnutls_boot): No need to check for memory allocation failure,
8482 since xmalloc does that for us.
8483
ac32cd99 8484 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8485 * category.c (hash_get_category_set):
8486 * ccl.c (ccl_driver):
8487 * charset.c (Fdefine_charset_internal):
8488 * charset.h (struct charset.hash_index):
8489 * composite.c (get_composition_id, gstring_lookup_cache)
8490 (composition_gstring_put_cache):
8491 * composite.h (struct composition.hash_index):
8492 * dispextern.h (struct image.hash):
8493 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8494 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8495 (hashfn_equal, hashfn_user_defined, make_hash_table)
8496 (maybe_resize_hash_table, hash_lookup, hash_put)
8497 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8498 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8499 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8500 * image.c (make_image, search_image_cache, lookup_image)
8501 (xpm_put_color_table_h):
8502 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8503 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8504 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8505 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8506 * alloc.c (allocate_vectorlike):
8507 Check for overflow in vector size calculations.
8508 * ccl.c (ccl_driver):
8509 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8510 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8511 need to be updated by these changes.
40087514
PE
8512 * fns.c (make_hash_table, maybe_resize_hash_table):
8513 Check for integer overflow with large hash tables.
0de4bb68
PE
8514 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8515 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8516 (SXHASH_REDUCE): New macro.
8517 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8518 Use it instead of discarding useful hash info with large hash values.
8519 (sxhash_float): New function.
8520 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8521 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8522 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8523 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8524 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8525 Adjust signatures to match updated version of code.
8526 (consing_since_gc): Now EMACS_INT, since a single hash table can
8527 use more than INT_MAX bytes.
8528
698d32e2
DN
85292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8530
8531 Make it possible to build with GCC-4.6+ -O2 -flto.
8532
8533 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8534
fd6fa53f
SM
85352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8536
8537 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8538 Call minibuffer-inactive-mode.
8539
864db017
JB
85402011-05-31 Juanma Barranquero <lekktu@gmail.com>
8541
8542 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8543 Update dependencies.
8544
2ad0baf4
DN
85452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8546
8547 * data.c (init_data): Remove code for UTS, this system is not
8548 supported anymore.
8549
4fcc2638
DN
85502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8551
8552 Don't force ./temacs to start in terminal mode.
8553
8554 * frame.c (make_initial_frame): Initialize faces in all cases, not
8555 only when CANNOT_DUMP is defined.
8556 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8557
c56e0fd5
DN
85582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8559
8560 * dispnew.c (add_window_display_history): Use const for the string
8561 pointer. Remove declaration, not needed.
8562
333d54da 85632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8564
55d4c1b2 8565 Use 'inline', not 'INLINE'.
333d54da 8566 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8567 * alloc.c, fontset.c (INLINE): Remove.
8568 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8569 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8570 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8571 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8572 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8573
738db178
DN
85742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8575
8576 Make it possible to run ./temacs.
8577
8578 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8579 syms_of_callproc does the same thing. Remove test for
8580 "initialized", do it in the caller.
8581 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8582
620c53a6
SM
85832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8584
8585 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8586 (read_minibuf): Use get_minibuffer.
8587 (syms_of_minibuf): Use DEFSYM.
8588 (Qmetadata): New var.
8589 * data.c (Qbuffer): Don't make it static.
8590 (syms_of_data): Use DEFSYM.
8591
e003a292
PE
85922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8593
8594 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8595 (CCL_CODE_MIN): New macro.
8596
ed008a6d
PE
85972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8598
3687c2ef
PE
8599 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8600
ed008a6d
PE
8601 * eval.c (Qdebug): Now static.
8602 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8603 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8604 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8605
d66c4c7c
CY
86062011-05-29 Chong Yidong <cyd@stupidchicken.com>
8607
8608 * image.c: Various fixes to ImageMagick code comments.
8609 (Fimagemagick_types): Doc fix.
8610
5fbc2025
PE
86112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8612
0196f88a
PE
8613 Minor fixes prompted by GCC 4.6.0 warnings.
8614
8615 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8616
5fbc2025
PE
8617 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8618 (x_clipboard_manager_save_all): Move extern decl to ...
8619 * xterm.h: ... here, so that it can be checked for consistency.
8620
1dd3c2d9
CY
86212011-05-29 Chong Yidong <cyd@stupidchicken.com>
8622
8623 * xselect.c (x_clipboard_manager_save_frame)
8624 (x_clipboard_manager_save_all): New functions.
8625 (Fx_clipboard_manager_save): Lisp function deleted.
8626
8627 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8628 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8629
8630 * xterm.h: Update prototype.
8631
5ba6571d
WX
86322011-05-28 William Xu <william.xwl@gmail.com>
8633
8634 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8635 exiting (Bug#8239).
8636
3eaff834
JM
86372011-05-28 Jim Meyering <meyering@redhat.com>
8638
e1900994 8639 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8640 * fns.c (to_uchar): Define.
8641 (crypto_hash_function): Use it to convert some newly-signed
8642 variables to unsigned, to avoid sign-extension bugs. For example,
8643 without this change, (md5 "truc") would evaluate to
8644 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8645 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8646 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8647
0f6990a7
PE
86482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8649
8650 Integer overflow fixes.
c8a9ca5a 8651
08686060
PE
8652 * dbusbind.c: Serial number integer overflow fixes.
8653 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8654 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8655 to hold a serial number that is too large for a fixnum.
8656 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8657 Check for serial numbers out of range. Decode any serial number
59568bf0 8658 that was so large that it became a float. (Bug#8722)
08686060 8659
2d1fc3c7
PE
8660 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8661 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8662 Use XFASTINT rather than XUINT when numbers are nonnegative.
8663 (xd_append_arg, Fdbus_method_return_internal):
8664 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8665 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8666 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8667 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8668 (Bug#8722)
2d1fc3c7 8669
c8a9ca5a
PE
8670 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8671
519e1d69
PE
8672 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8673
6df6ae42 8674 ccl: Add integer overflow checks.
30569699
PE
8675 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8676 (IN_INT_RANGE): New macros.
8677 (ccl_driver): Use them to check for integer overflow when
8678 decoding a CCL program. Many of the new checks are whether XINT (x)
8679 fits in int; it doesn't always, on 64-bit hosts. The new version
8680 doesn't catch all possible integer overflows, but it's an
847044ea 8681 improvement. (Bug#8719)
30569699 8682
c11285dc
PE
8683 * alloc.c (make_event_array): Use XINT, not XUINT.
8684 There's no need for unsigned here.
8685
fdccd48e
PE
8686 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8687 This follows up to the 2011-05-06 change that substituted uintptr_t
8688 for EMACS_INT. This case wasn't caught back then.
8689
37910ab2
PE
8690 Rework Fformat to avoid integer overflow issues.
8691 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8692 now (part of C89). Include <verify.h>.
8693 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8694 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8695 (Fformat): Avoid the prepass trying to compute sizes; it was only
8696 approximate and thus did not catch overflow reliably. Instead, walk
8697 through the format just once, formatting and computing sizes as we go,
8698 checking for integer overflow at every step, and allocating a larger
8699 buffer as needed. Keep track separately whether the format is
8700 multibyte. Keep only the most-recently calculated precision, rather
8701 than them all. Record whether each argument has been converted to
8702 string. Use EMACS_INT, not int, for byte and char and arg counts.
8703 Support field widths and precisions larger than INT_MAX. Avoid
8704 sprintf's undefined behavior with conversion specifications such as %#d
8705 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8706 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8707 formatting out-of-range floating point numbers with int
9173deec 8708 formats. (Bug#8668)
37910ab2 8709
2e6578fb
PE
8710 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8711
0ae6bdee
PE
8712 * data.c: Avoid integer truncation in expressions involving floats.
8713 * data.c: Include <intprops.h>.
8714 (arith_driver): When there's an integer overflow in an expression
8715 involving floating point, convert the integers to floating point
8716 so that the resulting value does not suffer from catastrophic
8717 integer truncation. For example, on a 64-bit host (* 4
8718 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8719 Do not rely on undefined behavior after integer overflow.
8720
de883a70
PE
8721 merge count_size_as_multibyte, parse_str_to_multibyte
8722 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8723 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8724 Check for integer overflow.
8725 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8726 since it's now a duplicate of the other. This is more of
8727 a character than a buffer op, so better that it's in character.c.
8728 * fns.c, print.c: Adjust to above changes.
8729
2ff916cb
PE
87302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8731
8732 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8733
f1b54466
PE
87342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8735
fb1ac845
PE
8736 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8737 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8738 (x_clipboard_manager_save): Now static.
8739 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8740
f1b54466
PE
8741 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8742 (crypto_hash_function): Now static.
8743 Fix pointer signedness problems. Avoid unnecessary initializations.
8744
a9f737ee
CY
87452011-05-27 Chong Yidong <cyd@stupidchicken.com>
8746
8747 * termhooks.h (Vselection_alist): Make it terminal-local.
8748
8749 * terminal.c (create_terminal): Initialize it.
8750
8751 * xselect.c: Support for clipboard managers.
8752 (Vselection_alist): Move to termhooks.h as terminal-local var.
8753 (LOCAL_SELECTION): New macro.
8754 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8755 (symbol_to_x_atom): Remove gratuitous arg.
8756 (x_handle_selection_request, lisp_data_to_selection_data)
8757 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8758 (x_own_selection, x_get_local_selection, x_convert_selection):
8759 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8760 (some_frame_on_display): Delete unused function.
8761 (Fx_own_selection_internal, Fx_get_selection_internal)
8762 (Fx_disown_selection_internal, Fx_selection_owner_p)
8763 (Fx_selection_exists_p): New optional frame arg.
8764 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8765 (x_handle_selection_clear): Don't treat other terminals with the
8766 same keyboard specially. Use the terminal-local Vselection_alist.
8767 (x_clear_frame_selections): Use Frun_hook_with_args.
8768
8769 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8770
8771 * xterm.h: Add support for those atoms.
8772
e067f0c1
CY
87732011-05-26 Chong Yidong <cyd@stupidchicken.com>
8774
8775 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8776 (converted_selections, conversion_fail_tag): New global variables.
8777 (x_selection_request_lisp_error): Free the above.
8778 (x_get_local_selection): Remove unnecessary code.
8779 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8780 of converted selections stored in converted_selections.
8781 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8782 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8783 (x_convert_selection): New function.
8784 (x_handle_selection_event): Simplify.
8785 (x_get_foreign_selection): Don't ignore incoming requests while
8786 waiting for an answer; this will fail when we implement
8787 SAVE_TARGETS, and seems unnecessary anyway.
8788 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8789 (Vx_sent_selection_functions): Doc fix.
8790
0f4aebc0
LL
87912011-05-26 Leo Liu <sdl.web@gmail.com>
8792
8793 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8794
e61124cd
YM
87952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8796
8797 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8798
8799 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8800 for fringe update if it has periodic bitmap.
ac389d0c 8801 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8802 and fringe_bitmap_periodic_p.
8803
8804 * fringe.c (get_fringe_bitmap_data): New function.
8805 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8806 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8807 row. Mark glyph row for fringe update if periodicity changed.
8808
8809 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8810 for fringe update unless it has periodic bitmap.
8811
f16d9837
KH
88122011-05-25 Kenichi Handa <handa@m17n.org>
8813
8814 * xdisp.c (get_next_display_element): Set correct it->face_id for
8815 a static composition.
8816
e1b90ef6
LL
88172011-05-24 Leo Liu <sdl.web@gmail.com>
8818
8819 * deps.mk (fns.o):
8820 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8821
8822 * fns.c (crypto_hash_function, Fsha1): New function.
8823 (Fmd5): Use crypto_hash_function.
8824 (syms_of_fns): Add Ssha1.
8825
7400048f
PE
88262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8827
8828 * gnutls.c: Remove unused macros.
8829 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8830 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8831 Remove macros that are defined and never used.
8832 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8833
abb71cf4
CY
88342011-05-22 Chong Yidong <cyd@stupidchicken.com>
8835
8836 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8837 (Fx_get_selection_internal): Minor cleanup.
8838 (Fx_own_selection_internal): Rename arguments for consistency with
8839 select.el.
8840
6307db39
PE
88412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8842
8843 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8844
f3d4e0a4
CY
88452011-05-22 Chong Yidong <cyd@stupidchicken.com>
8846
8847 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8848
4d8ade89
YM
88492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8850
8851 * dispnew.c (scrolling_window): Don't exclude the case that the
8852 last enabled row in the desired matrix touches the bottom boundary.
8853
32078c8d
GM
88542011-05-21 Glenn Morris <rgm@gnu.org>
8855
8856 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8857 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8858 and add some more files.
32078c8d 8859
7285dc67
EZ
88602011-05-20 Eli Zaretskii <eliz@gnu.org>
8861
8862 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8863 report_file_error introduced by the change from 2011-05-07.
8864
89d1bd22
PE
88652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8866
8867 * systime.h (Time): Define only if emacs is defined.
8868 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8869 where the include path doesn't have X11/X.h by default. See
8870 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8871
cd394be1 88722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8873
8874 * composite.c (find_automatic_composition): Fix previous change.
8875
b9704ad9
GM
88762011-05-20 Glenn Morris <rgm@gnu.org>
8877
8878 * lisp.mk: New file, split from Makefile.in.
8879 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8880 (shortlisp): Remove.
8881 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8882
4a720484
GM
88832011-05-19 Glenn Morris <rgm@gnu.org>
8884
8885 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8886 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8887 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8888 (lisp): Set the order to that of loadup.el.
8889 (shortlisp): Make it a copy of $lisp.
8890 (SOME_MACHINE_LISP): Remove.
8891 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8892 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8893
a28d4396
KH
88942011-05-18 Kenichi Handa <handa@m17n.org>
8895
8896 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8897 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8898 (find_automatic_composition): Mostly rewrite for efficiency.
8899
a2b1fa8e
JB
89002011-05-18 Juanma Barranquero <lekktu@gmail.com>
8901
8902 * makefile.w32-in: Update dependencies.
8903
8e1f5610
CS
89042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8905
8906 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8907 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8908
7025ee00 89092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8910
cdfa6eab
PE
8911 Fix some integer overflow issues, such as string length overflow.
8912
06d6db33
PE
8913 * insdel.c (count_size_as_multibyte): Check for string overflow.
8914
2b4560a8
PE
8915 * character.c (lisp_string_width): Check for string overflow.
8916 Use EMACS_INT, not int, for string indexes and lengths; in
8917 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8918 the resulting string length overflows an EMACS_INT; instead,
8919 report a string overflow if no precision given. When checking for
8920 precision exhaustion, use a check that cannot possibly have
8921 integer overflow. (Bug#8675)
8922 * character.h (lisp_string_width): Adjust to new signature.
8923
cb93f9be
PE
8924 * alloc.c (string_overflow): New function.
8925 (Fmake_string): Use it. This doesn't change behavior, but saves
8926 a few bytes and will simplify future changes.
8927 * character.c (string_escape_byte8): Likewise.
8928 * lisp.h (string_overflow): New decl.
8929
1a1f3366
PE
8930 Fixups, following up to the user-interface timestamp change.
8931 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8932 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8933 * msdos.c (mouse_get_pos): Likewise.
8934 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8935 * w32gui.h (Time): Define by including "systime.h" rather than by
8936 declaring it ourselves. (Bug#8664)
8937
d4e3e4d3
PE
8938 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8939 * image.c (clear_image_cache): Likewise.
8940
f6a24d19
PE
8941 * term.c (term_mouse_position): Don't assume time_t wraparound.
8942
08dc5ae6
PE
8943 Be more systematic about user-interface timestamps.
8944 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8945 and sometimes 'EMACS_UINT', to represent these timestamps.
8946 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8947 This makes the code easier to follow, and makes it easier to catch
8948 integer overflow bugs such as Bug#8664.
8949 * frame.c (Fmouse_position, Fmouse_pixel_position):
8950 Use Time, not unsigned long, for user-interface timestamps.
8951 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8952 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8953 * keyboard.h (last_event_timestamp): Likewise.
8954 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8955 * menu.h (xmenu_show): Likewise.
8956 * term.c (term_mouse_position): Likewise.
8957 * termhooks.h (struct input_event.timestamp): Likewise.
8958 (struct terminal.mouse_position_hook): Likewise.
8959 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8960 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8961 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8962 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8963 what it was before.
8964 * menu.h, termhooks.h: Include "systime.h", for Time.
8965
8e55734a
PE
8966 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8967 Don't assume that the difference between two unsigned long values
8968 can fit into an integer. At this point, we know button_down_time
8969 <= event->timestamp, so the difference must be nonnegative, so
8970 there's no need to cast the result if double-click-time is
8971 nonnegative, as it should be; check that it's nonnegative, just in
8972 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8973 apart (about 25 days). (Bug#8664)
8e55734a 8974
841f1b75 8975 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8976 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8977
3e26f69c
PE
8978 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8979 that always fit in int. Use a sentinel instead of a counter, to
8980 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8981 * frame.h (struct frame): Use int for menu_bar_items_used
8982 instead of EMACS_INT, since it always fits in int.
3e26f69c 8983
5cc152c0
PE
8984 * menu.c (grow_menu_items): Check for int overflow.
8985
d89eb65e
PE
8986 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8987
5235bd3e
PE
8988 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8989 Before, the code was not consistent. These values cannot exceed
8990 2**31 - 1 so there's no need to make them unsigned.
8991 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8992 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8993 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8994 as modifiers.
8995 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8996
bc827e23
PE
8997 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8998 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8999 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9000 presumably because the widths might not match.
9001
78eb494e
PE
9002 * window.c (size_window): Avoid needless test at loop start.
9003
04f2d78b
CB
90042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9005
9006 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9007
d2fc7e3d 90082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9009
9010 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9011
d2fc7e3d 90122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9013
9014 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9015 `width' to `bar_area_x' and `bar_area_width', respectively.
9016 (x_scroll_run): Take account of fringe background extension.
9017
04f2d78b
CB
9018 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9019 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9020 `bar_area_width', respectively.
9021 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9022 background extension.
9023
79b70037
GM
90242011-05-10 Jim Meyering <meyering@redhat.com>
9025
9026 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9027
2f142cc5
JB
90282011-05-10 Juanma Barranquero <lekktu@gmail.com>
9029
9030 * image.c (Finit_image_library): Return t for built-in image types,
9031 like pbm and xbm. (Bug#8640)
9032
57679c86
AS
90332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9034
9035 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9036
888c9e86
EZ
90372011-05-07 Eli Zaretskii <eliz@gnu.org>
9038
b0512a1d
EZ
9039 * w32console.c (Fset_screen_color): Doc fix.
9040 (Fget_screen_color): New function.
9041 (syms_of_ntterm): Defsubr it.
9042
7285dc67
EZ
9043 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9044 unlink the temporary file if Fcall_process didn't create it in the
9045 first place.
9046 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9047 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9048 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9049 cue to call_process_cleanup not to close that handle.
9050
4d3fcc8e
BK
90512011-05-07 Ben Key <bkey76@gmail.com>
9052
9053 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9054 one of two shell specific rules, either bootstrap-temacs-CMD or
9055 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9056 to the previous implementation of the bootstrap-temacs rule.
9057 The bootstrap-temacs-CMD rule is similar to the previous
9058 implementation of the bootstrap-temacs rule except that it
9059 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9060 variable.
9061
9062 These changes, along with some changes to nt/configure.bat,
9063 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9064 earlier fix to add support for --cflags and --ldflags options
9065 that include quotes so that it works whether make uses cmd or
9066 sh as the shell.
9067
b4289b64
MA
90682011-05-06 Michael Albinus <michael.albinus@gmx.de>
9069
9070 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9071 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9072 is a constant.
9073 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9074 a string. Handle both cases.
9075 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9076 (Fdbus_register_method): Use Qinvalid_function.
9077
af4c0e28
JB
90782011-05-06 Juanma Barranquero <lekktu@gmail.com>
9079
9080 * makefile.w32-in: Update dependencies.
9081 (LISP_H): Add inttypes.h and stdin.h.
9082 (PROCESS_H): Add unistd.h.
9083
c51453d9
EZ
90842011-05-06 Eli Zaretskii <eliz@gnu.org>
9085
9086 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9087 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9088
8ff0ac3c 90892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9090
4c4b566b
PE
9091 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9092
aab2b9b5
PE
9093 * term.c (vfatal): Remove stray call to va_end.
9094 It's not needed and the C Standard doesn't allow it here anyway.
9095
c378da0b
PE
9096 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9097 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9098
288b08c7
PE
9099 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9100 bytes.
9101
e3601888
PE
9102 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9103
db6c0e74
PE
9104 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9105
dd5963ea
PE
9106 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9107
88c9450f
PE
9108 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9109
2f9442b8
PE
9110 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9111
c032b5f8
PE
9112 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9113 * charset.c (Fdefine_charset_internal): Don't initialize
9114 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9115 32-bit int (Bug#8600).
a108c10b
PE
9116
9117 * lread.c (read_integer): Be more consistent with string-to-number.
9118 Use string_to_number to do the actual conversion; this avoids
9119 rounding errors and fixes some other screwups. Without this fix,
9120 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9121 (digit_to_number): Move earlier, for benefit of read_integer.
9122 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9123 not a digit in any supported base. (Bug#8602)
a108c10b 9124
ad5f9eea
PE
9125 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9126
aec1708a
PE
9127 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9128 to match comment at start of function. This also removes a
9129 GCC warning about overflow in a 32+64-bit port.
9130
47be4ab5
PE
9131 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9132
371cac43
PE
9133 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9134 Reported by Stefan Monnier in
9135 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9136 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9137 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9138
d01a7826
PE
9139 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9140 (EMACS_UINTPTR): Likewise, with uintptr_t.
9141
7fd47d5c
PE
9142 * lisp.h: Prefer 64-bit EMACS_INT if available.
9143 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9144 on 32-bit hosts that have 64-bit int, so that they can access
9145 large files.
122b0c86
PE
9146 However, temporarily disable this change unless the temporary
9147 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9148
8727937b
PE
9149 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9150
8ac068ac
PE
9151 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9152 This removes an assumption that EMACS_INT and long are the same
9153 width as pointers. The assumption is true for Emacs porting targets
9154 now, but we want to make other targets possible.
9155 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9156 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9157 In the rest of the code, change types of integers that hold casted
9158 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9159 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9160 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9161 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9162 No need to cast type when ORing.
9163 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9164 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9165 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9166 assume EMACS_INT is the same width as char *.
9167 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9168 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9169 Remove no-longer-needed casts.
9170 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9171 (xg_tool_bar_help_callback, xg_make_tool_item):
9172 Use EMACS_INTPTR to hold an integer
9173 that will be cast to void *; this can avoid a GCC warning
9174 if EMACS_INT is not the same width as void *.
9175 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9176 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9177 (current_message_1, set_message_1):
9178 Use a local to convert to proper width without a cast.
9179 * xmenu.c (dialog_selection_callback): Likewise.
9180
ede49d71
PE
9181 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9182 Also, don't assume VALBITS / RAND_BITS is less than 5,
9183 and don't rely on undefined behavior when shifting a 1 left into
9184 the sign bit.
9185 * lisp.h (get_random): Change signature to match.
9186
2f30ecd0
PE
9187 * lread.c (hash_string): Use size_t, not int, for hash computation.
9188 Normally we prefer signed values; but hashing is special, because
9189 it's better to use unsigned division on hash table sizes so that
9190 the remainder is nonnegative. Also, size_t is the natural width
9191 for hashing into memory. The previous code used 'int', which doesn't
9192 retain enough info to hash well into very large tables.
9193 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9194
2a866e7b
PE
9195 * dbusbind.c: Don't possibly lose pointer info when converting.
9196 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9197 Use XPNTR rather than XHASH, so that the high-order bits of
9198 the pointer aren't lost when converting through void *.
9199
51639eac
PE
9200 * eval.c (Fautoload): Don't double-shift a pointer.
9201
92394119
PE
9202 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9203
dbdb9a7c
JB
92042011-05-06 Juanma Barranquero <lekktu@gmail.com>
9205
9206 * gnutls.c (DEF_GNUTLS_FN):
9207 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9208
db7a0b4f
AS
92092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9210
9211 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9212 marker. (Bug#8610)
9213
cd394be1 92142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9215
9216 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9217 New version that can reserve upto 2GB of heap space.
9218
f7ff1b0f 92192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9220
9221 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9222
639c109b
TZ
92232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9224
9225 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9226 `gnutls_certificate_set_x509_key_file'.
9227
d2127135
JB
92282011-05-05 Juanma Barranquero <lekktu@gmail.com>
9229
9230 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9231 Update dependencies.
9232
e968f4f3
JB
92332011-05-04 Juanma Barranquero <lekktu@gmail.com>
9234
9235 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9236 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9237 Remove unused parameter `fildes'.
9238 * process.c (read_process_output, send_process): Don't pass it.
9239
84d358f0
JB
92402011-05-04 Juanma Barranquero <lekktu@gmail.com>
9241
9242 Fix previous change: the library cache is defined in w32.c.
9243 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9244 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9245
0898ca10
JB
92462011-05-04 Juanma Barranquero <lekktu@gmail.com>
9247
9248 Implement dynamic loading of GnuTLS on Windows.
9249
9250 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9251 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9252 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9253 Declare.
9254
9255 * gnutls.c (Qgnutls_dll): Define.
9256 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9257 (gnutls_*): Declare function pointers.
9258 (init_gnutls_functions): New function to initialize function pointers.
9259 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9260 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9261 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9262 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9263 (emacs_gnutls_write, emacs_gnutls_read)
9264 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9265 (Fgnutls_available_p): New function.
9266 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9267 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9268 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9269
9270 * image.c: Include w32.h.
9271 (Vimage_type_cache): Delete.
9272 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9273 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9274 (w32_delayed_load): Move to w32.c.
9275
9276 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9277
9278 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9279 (w32_delayed_load): Move from image.c. When loading a library, record
9280 its filename in the :loaded-from property of the library id.
9281 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9282 Initialize and staticpro them.
9283 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9284
9285 * process.c: Include lisp.h before w32.h, not after.
9286 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9287 instead of gnutls_record_check_pending.
9288
9289 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9290
ff4de4aa
TZ
92912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9292
9293 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9294 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9295 as passed in.
9296
abe95abb
JD
92972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9298
9299 * xterm.c (x_set_frame_alpha): Do not set property on anything
9300 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9301
e16e55d4
JB
93022011-05-02 Juanma Barranquero <lekktu@gmail.com>
9303
9304 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9305
bafcf6a5
JB
93062011-05-02 Juanma Barranquero <lekktu@gmail.com>
9307
9308 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9309 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9310 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9311 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9312 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9313 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9314 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9315 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9316 (Qgnutls_bootprop_callbacks_verify): Make static.
9317
e7a6747f
AS
93182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9319
19ed11ba
AS
9320 * callproc.c: Indentation fixup.
9321
e7a6747f 9322 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9323 (wait_for_termination, interruptible_wait_for_termination):
9324 Move after wait_for_termination_1.
e7a6747f 9325
1ef14cb4
LMI
93262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9327
9328 * sysdep.c (interruptible_wait_for_termination): New function
9329 which is like wait_for_termination, but allows keyboard
9330 interruptions.
9331
9332 * callproc.c (Fcall_process): Add (:file "file") as an option for
9333 the STDOUT buffer.
9334 (Fcall_process_region): Ditto.
9335
330d880c
EZ
93362011-04-30 Eli Zaretskii <eliz@gnu.org>
9337
8db90b73
EZ
9338 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9339 rather than `XVECTOR (FOO)->size'.
9340
330d880c
EZ
9341 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9342 inttypes.h, as a gnulib replacement is used if it not available in
9343 system headers.
9344
15cbd324
EZ
93452011-04-21 Eli Zaretskii <eliz@gnu.org>
9346
9347 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9348 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9349 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9350
9351 * coding.c (coding_alloc_by_realloc): Error out if destination
9352 will grow beyond MOST_POSITIVE_FIXNUM.
9353 (decode_coding_emacs_mule): Abort if there isn't enough place in
9354 charbuf for the composition carryover bytes. Reserve an extra
9355 space for up to 2 characters produced in a loop.
9356 (decode_coding_iso_2022): Abort if there isn't enough place in
9357 charbuf for the composition carryover bytes.
9358
93592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9360
ae940cca
EZ
9361 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9362 aborting when %lld or %lll format is passed.
9363 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9364 %llo or %llx format is passed. (Bug#8545)
9365
03ab8921
EZ
9366 * window.c (window_scroll_line_based): Use a marker instead of
9367 simple variables to record original value of point. (Bug#7952)
9368
afda1437
EZ
9369 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9370 produced by %s or %c overflows available buffer space. (Bug#8545)
9371
f76dee0c
PE
93722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9373
9374 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9375 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9376
fdc5744d
JB
93772011-04-28 Juanma Barranquero <lekktu@gmail.com>
9378
9379 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9380
638f053a
JB
93812011-04-28 Juanma Barranquero <lekktu@gmail.com>
9382
9383 * keyboard.c (Qdelayed_warnings_hook): Define.
9384 (command_loop_1): Run `delayed-warnings-hook'
9385 if Vdelayed_warnings_list is non-nil.
9386 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9387 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9388
d178f871
EZ
93892011-04-28 Eli Zaretskii <eliz@gnu.org>
9390
9391 * doprnt.c (doprnt): Don't return value smaller than the buffer
9392 size if the message was truncated. (Bug#8545).
9393
b124fd93
JB
93942011-04-28 Juanma Barranquero <lekktu@gmail.com>
9395
9396 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9397 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9398
e810457d
PE
93992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9400
9401 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9402
ea51cceb
JB
94032011-04-27 Juanma Barranquero <lekktu@gmail.com>
9404
9405 * makefile.w32-in: Update dependencies.
9406
94dcfacf
EZ
94072011-04-27 Eli Zaretskii <eliz@gnu.org>
9408
9409 Improve `doprnt' and its usage. (Bug#8545)
9410 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9411 `format_end'. Remove support for %l as a conversion specifier.
9412 Don't use xrealloc. Improve diagnostics when the %l size modifier
9413 is used. Update the commentary.
9414
9415 * eval.c (verror): Simplify calculation of size_t.
9416
9417 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9418 messages.
9419
f61f41d7
PE
94202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9421
9422 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9423 change.
9424
96fb4434
PE
94252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9426
9427 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9428 This makes this file independent of the recent pseudovector change.
9429
671875da 94302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9431
69e9b5a3
PE
9432 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9433
b5f869a7 9434 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9435 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9436 Remove unused local.
c8926152 9437 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9438
841a1577 9439 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9440 GCC 4.6.0 optimizes based on type-based alias analysis.
9441 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9442 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9443 != &v->size, and therefore "v->size = 1; b->size = 2; return
9444 v->size;" must therefore return 1. This assumption is incorrect
9445 for Emacs, since it type-puns struct Lisp_Vector * with many other
9446 types. To fix this problem, this patch adds a new type struct
f904488f 9447 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9448 and pseudovectors, and helps optimizing compilers not get fooled
9449 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9450 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9451 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9452 the size member.
eab3844f
PE
9453 (XSETPVECTYPE): Rewrite in terms of new macro.
9454 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9455 This is a bit clearer, and further avoids the possibility of
9456 undesirable aliasing.
9457 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9458 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9459 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9460 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9461 (ASIZE): Now uses header.size rather than size.
9462 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9463 to avoid the hassle of writing XVECTOR (foo)->header.size.
9464 (struct vectorlike_header): New type.
eab3844f
PE
9465 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9466 object, to help avoid aliasing.
9467 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9468 (SUBRP): Likewise, since Lisp_Subr is a special case.
9469 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9470 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9471 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9472 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9473 changed to be "header.size" and "header.next".
9474 * buffer.h (struct buffer): Likewise.
9475 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9476 * frame.h (struct frame): Likewise.
9477 * process.h (struct Lisp_Process): Likewise.
9478 * termhooks.h (struct terminal): Likewise.
9479 * window.c (struct save_window_data, struct saved_window): Likewise.
9480 * window.h (struct window): Likewise.
9481 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9482 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9483 * buffer.c (init_buffer_once): Likewise.
9484 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9485 special case.
9486 * process.c (Fformat_network_address): Use local var for size,
9487 for brevity.
9488
0df1eac5
PE
9489 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9490
847ab9d1 9491 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9492 * data.c (atof): Remove decl; no longer used or needed.
9493 (digit_to_number): Move to lread.c.
9494 (Fstring_to_number): Use new string_to_number function, to be
9495 consistent with how the Lisp reader treats infinities and NaNs.
9496 Do not assume that floating-point numbers represent EMACS_INT
9497 without losing information; this is not true on most 64-bit hosts.
9498 Avoid double-rounding errors, by insisting on integers when
9499 parsing non-base-10 numbers, as the documentation specifies.
9500 * lisp.h (string_to_number): New decl, replacing ...
9501 (isfloat_string): Remove.
bc0a5c13 9502 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9503 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9504 appears to have been a coding error. Similarly, do not accept
9505 strings like +-1e0 as floating point numbers. Do not report
9506 overflow for integer overflows unless the base is not 10 which
9507 means we have no simple and reliable way to continue.
9508 Break out the floating-point parsing into a new
9509 function string_to_number, so that Fstring_to_number parses
9510 floating point numbers consistently with the Lisp reader.
04f2d78b 9511 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9512 (E_CHAR, EXP_INT): Remove, replacing with ...
9513 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9514 (string_to_number): New function, replacing isfloat_string.
9515 This function checks for valid syntax and produces the resulting
9516 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9517 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9518 so that overflow for non-base-10 numbers is reported only when
9519 there's no portable and simple way to convert to floating point.
452f4150 9520
67769ffc
PE
9521 * textprop.c (set_text_properties_1): Rewrite for clarity,
9522 and to avoid GCC warning about integer overflow.
9523
c20db43f
PE
9524 * intervals.h (struct interval): Use EMACS_INT for members
9525 where EMACS_UINT might cause problems. See
9526 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9527 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9528 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9529 All uses changed.
37aa2f85
PE
9530 (offset_intervals): Tell GCC not to worry about length overflow
9531 when negating a negative length.
c20db43f 9532
2538aa2f
PE
9533 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9534 (overrun_check_free): Likewise.
9535
f2d3008d
PE
9536 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9537 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9538 word size.
9539
ec8df744
PE
9540 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9541 (gnutls_make_error): Rename local to avoid shadowing.
9542 (gnutls_emacs_global_deinit): ifdef out; not used.
9543 (Fgnutls_boot): Use const for pointer to readonly storage.
9544 Comment out unused local. Fix pointer signedness problems.
9545
640ee02d
PE
9546 * lread.c (openp): Don't stuff size_t into an 'int'.
9547 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9548 about possible signed overflow.
9549
6048fb2a
PE
9550 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9551 (GDK_KEY_g): Don't define if already defined.
9552 (xg_prepare_tooltip): Avoid pointer signedness problem.
9553 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9554
fa3c87e1
PE
9555 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9556 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9557
2172544b
PE
9558 * xfns.c (Fx_window_property): Simplify a bit,
9559 to make a bit faster and to avoid GCC 4.6.0 warning.
9560 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9561
9b821a21
PE
9562 * fns.c (internal_equal): Don't assume size_t fits in int.
9563
3c616cfa
PE
9564 * alloc.c (compact_small_strings): Tighten assertion a little.
9565
c2982e87
PE
9566 Replace pEd with more-general pI, and fix some printf arg casts.
9567 * lisp.h (pI): New macro, generalizing old pEd macro to other
9568 conversion specifiers. For example, use "...%"pI"d..." rather
9569 than "...%"pEd"...".
9570 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9571 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9572 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9573 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9574 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9575 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9576 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9577 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9578 64-bit hosts.
9579 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9580 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9581 * print.c (safe_debug_print, print_object): Likewise.
9582 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9583 to int.
6f04d126
PE
9584 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9585 avoiding the 0 flag, which is not portable.
c2982e87
PE
9586 * process.c (Fmake_network_process): Use pI to avoid cast.
9587 * region-cache.c (pp_cache): Likewise.
9588 * xdisp.c (decode_mode_spec): Likewise.
9589 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9590 behavior on 64-bit hosts with printf arg.
6f04d126 9591 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9592 (x_stop_queuing_selection_requests): Likewise.
9593 (x_get_window_property): Don't truncate byte count to an 'int'
9594 when tracing.
0b432f21 9595
5e073ec7
PE
9596 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9597 here, since it parses constructs like leading '-' and spaces,
9598 which are not wanted; and it overflows with large numbers.
9599 Instead, simply match F[0-9]+, which is what is wanted anyway.
9600
36372bf9
PE
9601 * alloc.c: Remove unportable assumptions about struct layout.
9602 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9603 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9604 (allocate_vectorlike, make_pure_vector): Use the new macros,
9605 plus offsetof, to remove unportable assumptions about struct layout.
9606 These assumptions hold on all porting targets that I know of, but
9607 they are not guaranteed, they're easy to remove, and removing them
9608 makes further changes easier.
9609
0b432f21
PE
9610 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9611 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9612 (string_overrun_cookie): Now const. Use initializers that
9613 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9614 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9615 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9616 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9617 multiple of sizeof (EMACS_INT); it need not be, if
9618 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9619 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9620
895009e1
JB
96212011-04-26 Juanma Barranquero <lekktu@gmail.com>
9622
9623 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9624
6a7a1b0b
TZ
96252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9626
9627 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9628 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9629 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9630
841a1577 96312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9632
9633 * lisp.h (Qdebug): List symbol.
895009e1 9634 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9635 * keyboard.c (debug-on-event): New variable.
9636 (handle_user_signal): Break into debugger when debug-on-event
9637 matches the current signal symbol.
9638
f2d3ba6f
DN
96392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9640
9641 * alloc.c (check_sblock, check_string_bytes)
9642 (check_string_free_list): Convert to standard C.
9643
42ce4c63
TZ
96442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9645
9646 * w32.c (emacs_gnutls_push): Fix typo.
9647
825cd63c
EZ
96482011-04-25 Eli Zaretskii <eliz@gnu.org>
9649
fb11d64d
EZ
9650 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9651 "cast to pointer from integer of different size".
9652
825cd63c
EZ
9653 Improve doprnt and its use in verror. (Bug#8545)
9654 * doprnt.c (doprnt): Document the set of format control sequences
9655 supported by the function. Use SAFE_ALLOCA instead of always
9656 using `alloca'.
9657
9658 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9659 is one byte too soon. Don't use xrealloc; instead xfree and
9660 xmalloc anew.
9661
e061a11b
TZ
96622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9663
9664 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9665 callbacks stage.
9666
9667 * gnutls.c: Renamed global_initialized to
9668 gnutls_global_initialized. Added internals for the
9669 :verify-hostname-error, :verify-error, and :verify-flags
9670 parameters of `gnutls-boot' and documented those parameters in the
9671 docstring. Start callback support.
9173deec
JB
9672 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9673 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9674 on error. Return error code.
e061a11b
TZ
9675 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9676 (emacs_gnutls_read): Likewise.
9677 (Fgnutls_boot): Return handshake error code.
9678 (emacs_gnutls_handle_error): New function.
9679 (wsaerror_to_errno): Likewise.
9680
9681 * w32.h (emacs_gnutls_pull): Add prototype.
9682 (emacs_gnutls_push): Likewise.
9683
9684 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9685 (emacs_gnutls_push): Likewise.
9686
96872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9688
9689 * process.c (wait_reading_process_output): Check if GnuTLS
9690 buffered some data internally if no FDs are set for TLS
9691 connections.
9692
9693 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9694 (LIBS): Link to USER_LIBS.
9695 ($(BLD)/gnutls.$(0)): New target.
9696
fa6996bc
EZ
96972011-04-24 Eli Zaretskii <eliz@gnu.org>
9698
eb35682e
EZ
9699 * xdisp.c (handle_single_display_spec): Rename the
9700 display_replaced_before_p argument into display_replaced_p, to
9701 make it consistent with the commentary. Fix typos in the
9702 commentary.
9703
e2ad650c
EZ
9704 * textprop.c (syms_of_textprop): Remove dead code.
9705 (copy_text_properties): Delete obsolete commentary about an
9706 interface that was deleted long ago. Fix typos in the description
9707 of arguments.
9708
1b2de274
EZ
9709 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9710 to changes in oldXMenu/XMenu.h from 2011-04-16.
9711 <menu_help_message, prev_menu_help_message>: Constify.
9712 (IT_menu_make_room): menu->help_text is now `const char **';
9713 adjust.
9714
9715 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9716 to changes in oldXMenu/XMenu.h from 2011-04-16.
9717 (struct XMenu): Declare `help_text' `const char **'.
9718
9719 * xfaces.c <Qunspecified>: Make extern again.
9720
9721 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9722 required by POSIX.
1b2de274 9723
762b15be
EZ
9724 * doc.c (get_doc_string): Improve the format passed to `error'.
9725
9726 * doprnt.c (doprnt): Improve commentary.
9727
9728 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9729
9730 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9731 them with etags.
9732
f1052e5d
EZ
9733 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9734 changes in globals.h immediately force recompilation.
762b15be
EZ
9735 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9736 $(CURDIR)/s/ms-w32.h.
9737 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9738
fa6996bc
EZ
9739 * character.c (Fchar_direction): Function deleted.
9740 (syms_of_character): Don't defsubr it.
9741 <char-direction-table>: Deleted.
9742
e6c3da20
EZ
97432011-04-23 Eli Zaretskii <eliz@gnu.org>
9744
9745 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9746 * doprnt.c: Include limits.h.
9747 (SIZE_MAX): New macro.
04f2d78b
CB
9748 (doprnt): Return a size_t value. 2nd arg is now size_t.
9749 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9750 Improve overflow protection. Support `l' modifier for integer
9751 conversions. Support %l conversion. Don't assume an EMACS_INT
9752 argument for integer conversions and for %c.
9753
9754 * lisp.h (doprnt): Restore prototype.
9755
9756 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9757 $(SRC)/character.h.
9758
9759 * Makefile.in (base_obj): Add back doprnt.o.
9760
9761 * deps.mk (doprnt.o): Add back prerequisites.
9762 (callint.o): Depend on character.h.
9763
9764 * eval.c (internal_lisp_condition_case): Include the handler
9765 representation in the error message.
9766 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9767 when breaking from the loop.
9768
9769 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9770
9771 * callint.c (Fcall_interactively): When displaying error message
9772 about invalid control letter, pass the character's codepoint, not
9773 a pointer to its multibyte form. Improve display of the character
9774 in octal and display also its hex code.
9775
9776 * character.c (char_string): Use %x to display the (unsigned)
9777 codepoint of an invalid character, to avoid displaying a bogus
9778 negative value.
9779
9780 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9781 `error', not SYMBOL_NAME itself.
9782
9783 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9784 character arguments to `error'.
9785
9786 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9787 to `error' in error message about FINAL_CHAR argument. Make sure
9788 FINAL_CHAR is a character, and use %c when it is passed as
9789 argument to `error'.
9790
4ffd0d6b 97912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9792
9793 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9794
9795 * w32.c: Include <time.h>.
9796 (sys_localtime): New function.
9797
4ffd0d6b 97982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9799
9800 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9801
4ffd0d6b 9802 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9803
4ffd0d6b 98042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9805
4ffd0d6b
GM
9806 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9807 zombies (Bug#8467).
aac0c6e3 9808
04c56954
EZ
98092011-04-19 Eli Zaretskii <eliz@gnu.org>
9810
9811 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9812 gl_state.e_property when gl_state.object is Qt.
9813
9814 * insdel.c (make_gap_larger): Remove limitation of buffer size
9815 to <= INT_MAX.
9816
16a43933
CY
98172011-04-18 Chong Yidong <cyd@stupidchicken.com>
9818
9819 * xdisp.c (lookup_glyphless_char_display)
9820 (produce_glyphless_glyph): Handle cons cell entry in
9821 glyphless-char-display.
9822 (Vglyphless_char_display): Document it.
9823
9824 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9825 glyphless-char-display.
9826
4581706e
CY
98272011-04-17 Chong Yidong <cyd@stupidchicken.com>
9828
9829 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9830
9831 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9832
9833 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9834 definition for no-X builds.
9835
4887c6e2 98362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9837
fd35b6f9
PE
9838 Static checks with GCC 4.6.0 and non-default toolkits.
9839
5c1ccb01
PE
9840 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9841
006c5daa
PE
9842 * process.c (keyboard_bit_set): Define only if SIGIO.
9843 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9844 (send_process): Repair possible setjmp clobbering.
9845
efc736d3
PE
9846 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9847
4e2fe2e6
PE
9848 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9849
f97334a2
PE
9850 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9851
4e75f29d
PE
9852 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9853 Define only if needed.
9854
90efadd1
PE
9855 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9856 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9857 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9858
3c647824
PE
9859 * dispextern.h (struct redisplay_interface): Rename param
9860 to avoid shadowing.
e264f262 9861 * termhooks.h (struct terminal): Likewise.
761383f4 9862 * xterm.c (xembed_send_message): Likewise.
3c647824 9863
b58c5c4a
PE
9864 * insdel.c (make_gap_smaller): Define only if
9865 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9866
cad59032
PE
9867 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9868 it.
9869
c339dc2e
PE
9870 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9871 so that we aren't warned about unused symbols.
9872
91a3e27b
PE
9873 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9874
399c71d3 9875 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9876
8ffc96f5
PE
9877 * xfns.c (x_real_positions): Mark locals as initialized.
9878
eef9bc79
PE
9879 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9880
098db9dd
PE
9881 * xterm.c: Fix problems found by static analysis with other toolkits.
9882 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9883 (x_dispatch_event): Declare static if USE_GTK, and
9884 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9885 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9886 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9887 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9888 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9889
eb18f6cc
PE
9890 * xmenu.c (menu_help_callback): Pointer type fixes.
9891 Use const pointers when pointing at readonly data. Avoid pointer
9892 signedness clashes.
9893 (FALSE): Remove unused macro.
9894 (update_frame_menubar): Remove unused decl.
9895
1fe72bf8
PE
9896 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9897
60d9e1db
PE
9898 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9899 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9900 (single_menu_item): Rename local to avoid shadowing.
9901
39261c26
PE
9902 * keyboard.c (make_lispy_event): Remove unused local var.
9903
018c5e19
PE
9904 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9905 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9906
63d2b86e
PE
9907 * bitmaps: Change bitmaps from unsigned char back to the X11
9908 compatible char. Avoid the old compiler warnings about
9909 out-of-range initializers by using, for example, '\xab' rather
9910 than 0xab.
9911
aefd87e1
PE
9912 * xgselect.c (xgselect_initialize): Check vs interface
9913 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9914
bf501fb9
PE
9915 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9916
e9829fdf
PE
9917 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9918 to read-only memory.
9919
1086c095
PE
9920 * fns.c (vector): Remove; this old hack is no longer needed.
9921
2baccd04 9922 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9923 Remove unused var.
dde42981 9924 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9925
72391843 9926 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9927
436c16df 9928 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9929 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9930 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9931
92bb796d 9932 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9933 (x_term_init): Remove local to avoid shadowing.
92bb796d 9934
764430a3 9935 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9936
9937 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9938 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9939
d1dfb56c
EZ
99402011-04-16 Eli Zaretskii <eliz@gnu.org>
9941
c4354cb4
EZ
9942 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9943
d1dfb56c
EZ
9944 Fix regex.c, syntax.c and friends for buffers > 2GB.
9945 * syntax.h (struct gl_state_s): Declare character position members
9946 EMACS_INT.
9947
9948 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9949
04f2d78b
CB
9950 * textprop.c (verify_interval_modification, interval_of):
9951 Declare arguments EMACS_INT.
d1dfb56c
EZ
9952
9953 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9954 EMACS_INT.
9955
9956 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9957
9958 * indent.c (Fvertical_motion): Local variable it_start is now
9959 EMACS_INT.
9960
9961 * regex.c (re_match, re_match_2, re_match_2_internal)
9962 (bcmp_translate, regcomp, regexec, print_double_string)
9963 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9964 (re_compile_pattern, re_exec): Declare arguments and local
9965 variables `size_t' and `ssize_t' and return values `regoff_t', as
9966 appropriate.
9967 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9968 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9969 <compile_stack_type>: `size' and `avail' are now `size_t'.
9970
9971 * regex.h <regoff_t>: Use ssize_t, not int.
9972 (re_search, re_search_2, re_match, re_match_2): Arguments that
9973 specify buffer/string position and length are now ssize_t and
9974 size_t. Return type is regoff_t.
9975
613052cd
BK
99762011-04-16 Ben Key <bkey76@gmail.com>
9977
9978 * nsfont.m: Fixed bugs in ns_get_family and
9979 ns_descriptor_to_entity that were caused by using free to
9980 deallocate memory blocks that were allocated by xmalloc (via
9981 xstrdup). This caused Emacs to crash when compiled with
9982 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9983 --enable-checking=xmallocoverrun). xfree is now used to
9984 deallocate these memory blocks.
9985
4170f62f 99862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9987
71b41406
PE
9988 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9989
9587a89d
PE
9990 emacs_write: Accept and return EMACS_INT for sizes.
9991 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9992 et seq.
9993 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9994 Accept and return EMACS_INT.
9995 (emacs_gnutls_write): Return the number of bytes written on
9996 partial writes.
9997 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9998 (emacs_read, emacs_write): Remove check for negative size, as the
9999 Emacs source code has been audited now.
9587a89d
PE
10000 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10001 (emacs_read, emacs_write): Use it.
273a5f82
PE
10002 * process.c (send_process): Adjust to the new signatures of
10003 emacs_write and emacs_gnutls_write. Do not attempt to store
10004 a byte offset into an 'int'; it might overflow.
9587a89d 10005 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10006
3e047f51
PE
10007 * sound.c: Don't assume sizes fit in 'int'.
10008 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10009 Return EMACS_INT, not int.
3e047f51 10010 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10011 Accept EMACS_INT, not int.
10012 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10013 record read return values.
10014
cc39a9db
BK
100152011-04-15 Ben Key <bkey76@gmail.com>
10016
c9d0ec6d
JB
10017 * keyboard.c (Qundefined): Don't declare static since it is used
10018 in nsfns.m.
10019 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10020 static since they are used in nsfont.m.
cc39a9db 10021
6c60eb9f
SM
100222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10023
10024 * process.c (Qprocessp): Don't declare static.
10025 * lisp.h (Qprocessp): Declare again.
10026
7990b61a
JB
100272011-04-15 Juanma Barranquero <lekktu@gmail.com>
10028
10029 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10030
5d4cb038
PE
100312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10032
8bd7b830 10033 Improve C-level modularity by making more things 'static'.
cd64ea1d 10034
e3b27b31
PE
10035 Don't publish debugger-only interfaces to other modules.
10036 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10037 (verify_bytepos, count_markers): Move decls to the only modules
10038 that need them.
10039 * region-cache.h (pp_cache): Likewise.
10040 * window.h (check_all_windows): Likewise.
10041 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10042
5d4cb038
PE
10043 * sysdep.c (croak): Now static, if
10044 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10045 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10046
10047 * alloc.c (refill_memory_reserve): Now static if
10048 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10049 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10050
e87b6180
PE
10051 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10052 Define only if USE_LUCID.
10053
ac64929e
PE
10054 * xrdb.c (x_customization_string, x_rm_string): Now static.
10055
6f37259d
PE
10056 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10057 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10058
1683e3ab
PE
10059 * xdisp.c (draw_row_with_mouse_face): Now static.
10060 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10061
de9c2632
PE
10062 * window.h (check_all_windows): Mark externally visible.
10063
2b96acb7
PE
10064 * window.c (window_deletion_count): Now static.
10065
10066 * undo.c: Make symbols static if they're not exported.
10067 (last_undo_buffer, last_boundary_position, pending_boundary):
10068 Now static.
10069
50436f33
PE
10070 * textprop.c (interval_insert_behind_hooks): Now static.
10071 (interval_insert_in_front_hooks): Likewise.
10072
64520e5c
PE
10073 * term.c: Make symbols static if they're not exported.
10074 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10075 (max_frame_lines, tty_set_terminal_modes):
10076 (tty_reset_terminal_modes, tty_turn_off_highlight):
10077 (get_tty_terminal): Now static.
10078 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10079 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10080 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10081 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10082 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10083
1fa53021
PE
10084 * sysdep.c: Make symbols static if they're not exported.
10085 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10086 Now static.
10087 (sigprocmask_set, full_mask): Remove; unused.
10088 (wait_debugging): Mark as visible.
10089 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10090 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10091
d4b43b22
PE
10092 * syntax.c (syntax_temp): Define only if !__GNUC__.
10093
b7c513d0
PE
10094 * sound.c (current_sound_device, current_sound): Now static.
10095
989b29ad
PE
10096 * search.c (searchbufs, searchbuf_head): Now static.
10097
13a55a78
PE
10098 * scroll.c (scroll_cost): Remove; unused.
10099 * dispextern.h (scroll_cost): Remove decl.
10100
de68a1fc
PE
10101 * region-cache.h (pp_cache): Mark as externally visible.
10102
40ccffa6
PE
10103 * process.c: Make symbols static if they're not exported.
10104 (process_tick, update_tick, create_process, chan_process):
10105 (Vprocess_alist, proc_buffered_char, datagram_access):
10106 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10107 (deactivate_process): Mark defn as static, as well as decl.
10108 * lisp.h (create_process): Remove decl.
10109 * process.h (chan_process, Vprocess_alist): Remove decls.
10110
ad64fc97
PE
10111 * print.c: Make symbols static if they're not exported.
10112 (print_depth, new_backquote_output, being_printed, print_buffer):
10113 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10114 (print_interval, print_number_index, initial_stderr_stream):
10115 Now static.
10116 * lisp.h (Fprinc): Remove decl.
10117 (debug_output_compilation_hack): Mark as externally visible.
10118
adddb265
PE
10119 * sysdep.c (croak): Move decl from here to syssignal.h.
10120 * syssignal.h (croak): Put it here, so the API can be checked when
10121 'croak' is called from dissociate_if_controlling_tty.
10122
1717ede2
PE
10123 * minibuf.c: Make symbols static if they're not exported.
10124 (minibuf_save_list, choose_minibuf_frame): Now static.
10125 * lisp.h (choose_minibuf_frame): Remove decl.
10126
fa5fb2bc
PE
10127 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10128
1e3890d1
PE
10129 * lread.c: Make symbols static if they're not exported.
10130 (read_objects, initial_obarray, oblookup_last_bucket_number):
10131 Now static.
10132 (make_symbol): Remove; unused.
10133 * lisp.h (initial_obarray, make_symbol): Remove decls.
10134
8a1414fa
PE
10135 * keyboard.c: Make symbols static if they're not exported.
10136 (single_kboard, recent_keys_index, total_keys, recent_keys):
10137 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10138 (this_single_command_key_start, echoing, last_auto_save):
10139 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10140 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10141 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10142 (Vlispy_mouse_stem, double_click_count):
10143 Now static.
10144 (force_auto_save_soon): Define only if SIGDANGER.
10145 (ignore_mouse_drag_p): Now static if
10146 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10147 (print_help): Remove; unused.
10148 (stop_character, last_timer_event): Mark as externally visible.
10149 * keyboard.h (ignore_mouse_drag_p): Declare only if
10150 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10151 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10152 * lisp.h (echoing): Remove decl.
10153 (force_auto_save_soon): Declare only if SIGDANGER.
10154 * xdisp.c (redisplay_window): Simplify code, to make it more
10155 obvious that ignore_mouse_drag_p is not accessed if !defined
10156 USE_GTK && !defined HAVE_NS.
10157
93ea6e8f
PE
10158 * intervals.c: Make symbols static if they're not exported.
10159 (merge_properties_sticky, merge_interval_right, delete_interval):
10160 Now static.
10161 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10162
77382fcc
PE
10163 * insdel.c: Make symbols static if they're not exported.
10164 However, leave prepare_to_modify_buffer alone. It's never
10165 called from outside this function, but that appears to be a bug.
10166 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10167 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10168 (adjust_after_replace_noundo): Remove; unused.
10169 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10170 (signal_before_change): Remove decls.
77382fcc 10171
9306c32e
PE
10172 * indent.c (val_compute_motion, val_vmotion): Now static.
10173
cd44d2eb
PE
10174 * image.c: Make symbols static if they're not exported.
10175 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10176 if USE_GTK.
10177 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10178 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10179
ad9a7a06
PE
10180 * fringe.c (standard_bitmaps): Now static.
10181 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10182
81626931
PE
10183 * frame.c: Make symbols static if they're not exported.
10184 (x_report_frame_params, make_terminal_frame): Now static.
10185 (get_frame_param): Now static, unless HAVE_NS.
10186 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10187 (x_get_resource_string): Remove; not used.
10188 * frame.h (make_terminal_frame, x_report_frame_params):
10189 (x_get_resource_string); Remove decls.
10190 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10191 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10192
239f9db9
PE
10193 * font.c, fontset.c: Make symbols static if they're not exported.
10194 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10195 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10196 * font.c (font_close_object): Now static.
10197 * font.h (font_close_object): Remove.
10198 * fontset.c (FONTSET_OBJLIST): Remove.
10199 (free_realized_fontset) #if-0 the body, which does nothing.
10200 (face_suitable_for_char_p): #if-0, as it's never called.
10201 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10202 * xfaces.c (face_at_string_position):
10203 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10204 since 0 is always ASCII.
10205
dfcf3579
PE
10206 * fns.c (weak_hash_tables): Now static.
10207
5045092b
PE
10208 * fileio.c: Make symbols static if they're not exported.
10209 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10210 (Vwrite_region_annotation_buffers): Now static.
10211
57a96f5c
PE
10212 * eval.c: Make symbols static if they're not exported.
10213 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10214 * lisp.h (backtrace_list): Remove decl.
10215
35f08c38
PE
10216 * emacs.c: Make symbols static if they're not exported.
10217 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10218 (fatal_error_code, fatal_error_signal_hook, standard_args):
10219 Now static.
10220 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10221 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10222 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10223 * lisp.h (fatal_error_signal_hook): Remove decl.
10224 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10225
f44bd759
PE
10226 * editfns.c: Move a (normally-unused) function to its only use.
10227 * editfns.c, lisp.h (get_operating_system_release): Remove.
10228 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10229 worth the hassle of breaking this out.
10230
b532497d
PE
10231 * xterm.c: Make symbols static if they're not exported.
10232 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10233 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10234 (x_destroy_window, x_delete_display):
10235 Now static.
10236 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10237 (x_mouse_leave): Remove; unused.
10238 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10239 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10240 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10241 Remove decls.
10242 (x_mouse_leave): Declare only if WINDOWSNT.
10243 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10244 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10245 USE_X_TOOLKIT.
10246
1675728f
PE
10247 * ftxfont.c: Make symbols static if they're not exported.
10248 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10249 HAVE_FREETYPE.
10250 * font.h (ftxfont_driver): Likewise.
10251
e4cebfca
PE
10252 * xfns.c: Make symbols static if they're not exported.
10253 (x_last_font_name, x_display_info_for_name):
10254 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10255 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10256 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10257 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10258 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10259 (last_show_tip_args): Now static.
10260 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10261 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10262 (x_screen_planes): Remove; unused.
10263 * dispextern.h (x_screen_planes): Remove decl.
10264
5bf46f05
PE
10265 * dispnew.c: Make symbols static if they're not exported.
10266 * dispextern.h (redraw_garbaged_frames, scrolling):
10267 (increment_row_positions): Remove.
10268 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10269 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10270 Now static.
10271 (redraw_garbaged_frames): Remove; unused.
10272
435f4c28
PE
10273 * xfaces.c: Make symbols static if they're not exported.
10274 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10275 Remove decls.
10276 * xterm.h (defined_color): Remove decls.
10277 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10278 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10279 (menu_face_changed_default, defined_color, free_realized_face):
10280 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10281 (ascii_face_of_lisp_face): Remove; unused.
10282
8524aef3
PE
10283 * xdisp.c: Make symbols static if they're not exported.
10284 * dispextern.h (scratch_glyph_row, window_box_edges):
10285 (glyph_to_pixel_coords, set_cursor_from_row):
10286 (get_next_display_element, set_iterator_to_next):
10287 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10288 (show_mouse_face): Remove decls
10289 * frame.h (message_buf_print): Likewise.
10290 * lisp.h (pop_message, set_message, check_point_in_composition):
10291 Likewise.
10292 * xterm.h (set_vertical_scroll_bar): Likewise.
10293 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10294 (message_buf_print, scratch_glyph_row, displayed_buffer):
10295 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10296 (get_next_display_element, show_mouse_face, window_box_edges):
10297 (frame_to_window_pixel_xy, check_point_in_composition):
10298 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10299 (glyph_to_pixel_coords): Remove; unused.
10300
16390cd2
PE
10301 * dired.c (file_name_completion): Now static.
10302
10303 * dbusbind.c (xd_in_read_queued_messages): Now static.
10304
a25f4dfa
PE
10305 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10306 * data.c (circular_list_error): Remove.
10307
14a9c8df
PE
10308 * commands.h (last_point_position, last_point_position_buffer):
10309 (last_point_position_window): Remove decls.
10310 * keyboard.c: Make these variables static.
10311
04f2d78b
CB
10312 * coding.h (coding, code_convert_region, encode_coding_gap):
10313 Remove decls.
74ab6df5
PE
10314 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10315 (iso_code_class, detect_coding, code_convert_region): Now static.
10316 (encode_coding_gap): Remove; unused.
10317
38dfbee1
PE
10318 * chartab.c (chartab_chars, chartab_bits): Now static.
10319
a2cb4e63
PE
10320 * charset.h (charset_iso_8859_1): Remove decl.
10321 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10322 Now static.
10323
127198fd
PE
10324 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10325 * ccl.c (Vccl_program_table): Now static.
10326 (check_ccl_update): Remove; unused.
10327
d85b608f
PE
10328 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10329 * category.h: ... from here.
10330 * category.c (check_category_table, set_category_set): Now static.
10331
31cd66f3
PE
10332 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10333 * lisp.h: Remove these decls.
10334
c358e587
PE
10335 * buffer.c (buffer_count): Remove unused var.
10336
e78aecca
PE
10337 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10338 so that it's not optimized away.
10339 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10340 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10341 exported only to the debugger.
10342
e192d7d3 10343 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10344 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10345
92470028
PE
10346 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10347 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10348 was inaccessible from Lisp.
10349 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10350 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10351
244ed907
PE
10352 alloc.c: Import and export fewer symbols, and remove unused items.
10353 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10354 is defined.
10355 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10356 it's not optimized away by whole-program optimization.
10357 (message_enable_multibyte, free_misc): Remove.
10358 (catchlist, handlerlist, mark_backtrace):
10359 Declare only if BYTE_MARK_STACK.
10360 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10361 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10362 (message_enable_multibyte): Remove decl.
10363 (free_misc, interval_free_list, float_block, float_block_index):
10364 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10365 (cons_free_list, last_marked_index):
10366 Now static.
10367 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10368 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10369 (mark_backtrace): Define only if BYTE_MARK_STACK.
10370 * xdisp.c (message_enable_multibyte): Now static.
10371
61c2b50e 10372 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10373 This makes it easier for human readers (and static analyzers)
10374 to see whether these variables are used from other modules.
10375 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10376 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10377 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10378 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10379 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10380 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10381 * xmenu.c, xselect.c:
10382 Declare Q* vars static if they are not used in other modules.
10383 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10384 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10385 Remove decls of unexported vars.
10386 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10387
95c82688
PE
10388 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10389
16a97296
PE
10390 Make Emacs functions such as Fatom 'static' by default.
10391 This makes it easier for human readers (and static analyzers)
10392 to see whether these functions can be called from other modules.
10393 DEFUN now defines a static function. To make the function external
10394 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10395 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10396 (Finit_image_library):
16a97296
PE
10397 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10398 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10399 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10400 Remove decls, since these functions are now static.
10401 (Funintern, Fget_internal_run_time): New decls, since these functions
10402 were already external.
95c82688 10403
16a97296
PE
10404 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10405 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10406 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10407 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10408 * keyboard.c, keymap.c, lread.c:
10409 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10410 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10411 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10412 Mark functions with DEFUE instead of DEFUN,
10413 if they are used in other modules.
10414 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10415 decls for now-static functions.
10416 * buffer.h (Fdelete_overlay): Remove decl.
10417 * callproc.c (Fgetenv_internal): Mark as internal.
10418 * composite.c (Fremove_list_of_text_properties): Remove decl.
10419 (Fcomposition_get_gstring): New forward static decl.
10420 * composite.h (Fcomposite_get_gstring): Remove decl.
10421 * dired.c (Ffile_attributes): New forward static decl.
10422 * doc.c (Fdocumntation_property): New forward static decl.
10423 * eval.c (Ffetch_bytecode): New forward static decl.
10424 (Funintern): Remove extern decl; now in .h file where it belongs.
10425 * fileio.c (Fmake_symbolic_link): New forward static decl.
10426 * image.c (Finit_image_library): New forward static decl.
10427 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10428 * intervals.h (Fprevious_property_change):
10429 (Fremove_list_of_text_properties): Remove decls.
10430 * keyboard.c (Fthis_command_keys): Remove decl.
10431 (Fcommand_execute): New forward static decl.
10432 * keymap.c (Flookup_key): New forward static decl.
10433 (Fcopy_keymap): Now static.
10434 * keymap.h (Flookup_key): Remove decl.
10435 * process.c (Fget_process): New forward static decl.
10436 (Fprocess_datagram_address): Mark as internal.
10437 * syntax.c (Fsyntax_table_p): New forward static decl.
10438 (skip_chars): Remove duplicate decl.
10439 * textprop.c (Fprevious_property_change): New forward static decl.
10440 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10441 Now internal.
10442 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10443 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10444
785bbd42
PE
10445 * editfns.c (Fformat): Remove unreachable code.
10446
8b913b57
AS
104472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10448
10449 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10450 change. (Bug#8496)
10451
a6744a35
EZ
104522011-04-13 Eli Zaretskii <eliz@gnu.org>
10453
10454 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10455 when at ZV. (Bug#8487)
10456
e7974947
AS
104572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10458
baad03f0
AS
10459 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10460 (Bug#8437)
10461 * keyboard.c (parse_tool_bar_item): Likewise.
10462 * sound.c (sound_cleanup, alsa_close): Likewise.
10463 * termcap.c (tgetent): Likewise.
10464 * xfns.c (x_default_font_parameter): Likewise.
10465 * xsettings.c (read_and_apply_settings): Likewise.
10466
e7974947
AS
10467 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10468 (overrun_check_free): Protoize.
10469
28272684
PE
104702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10471
10472 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10473 since callers should never pass a negative size.
10474 Change the signature to match that of plain 'read' and 'write'; see
10475 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10476 * lisp.h: Update prototypes of emacs_write and emacs_read.
10477
11997c76
EZ
104782011-04-11 Eli Zaretskii <eliz@gnu.org>
10479
10480 * xdisp.c (redisplay_window): Don't try to determine the character
10481 position of the scroll margin if the window start point w->startp
e896f03c 10482 is outside the buffer's accessible region. (Bug#8468)
11997c76 10483
8a2cbd72
EZ
104842011-04-10 Eli Zaretskii <eliz@gnu.org>
10485
10486 Fix write-region and its subroutines for buffers > 2GB.
10487 * fileio.c (a_write, e_write): Modify declaration of arguments and
10488 local variables to support buffers larger than 2GB.
10489 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10490
10491 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10492 argument, local variables, and return value.
10493
10494 * lisp.h: Update prototypes of emacs_write and emacs_read.
10495
10496 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10497
4073e537 104982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10499
1ebfdcb6
PE
10500 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10501
b2ded58d
PE
10502 Fix more problems found by GCC 4.6.0's static checks.
10503
7d66342c
PE
10504 * xdisp.c (vmessage): Use a better test for character truncation.
10505
bbf47d44
PE
10506 * charset.c (load_charset_map): <, not <=, for optimization,
10507 and to avoid potential problems with integer overflow.
9248994d 10508 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10509 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10510 * editfns.c (Fformat): Likewise.
1e69125e 10511 * syntax.c (skip_chars): Likewise.
3befa583 10512
e3019616
PE
10513 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10514 This also lets GCC 4.6.0 generate slightly better loop code.
10515
becfa255
PE
10516 * callint.c (Fcall_interactively): <, not <=, for optimization.
10517 (Fcall_interactively): Count the number of arguments produced,
10518 not the number of arguments given. This is simpler and lets GCC
10519 4.6.0 generate slightly better code.
10520
dae0cd48
PE
10521 * ftfont.c: Distingish more carefully between FcChar8 and char.
10522 The previous code passed unsigned char * to a functions like
10523 strlen and xstrcasecmp that expect char *, which does not
10524 conform to the C standard.
10525 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10526 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10527 char * when the C standard requires it.
10528
76032d70
PE
10529 * keyboard.c (read_char): Remove unused var.
10530
eb3f1cc8
PE
10531 * eval.c: Port to Windows vsnprintf (Bug#8435).
10532 Include <limits.h>.
10533 (SIZE_MAX): Define if the headers do not.
10534 (verror): Do not give up if vsnprintf returns a negative count.
10535 Instead, grow the buffer. This ports to Windows vsnprintf, which
10536 does not conform to C99. Problem reported by Eli Zaretskii.
10537 Also, simplify the allocation scheme, by avoiding the need for
10538 calling realloc, and removing the ALLOCATED variable.
10539
70476b54
PE
10540 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10541
12020a9e
PE
10542 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10543 But keep the doprint source code for now, as we might revamp it
10544 and use it again (Bug#8435).
ea6c7ae6
PE
10545 * lisp.h (doprnt): Remove.
10546 * Makefile.in (base_obj): Remove doprnt.o.
10547 * deps.mk (doprnt.o): Remove.
10548
5fdb398c
PE
10549 error: Print 32- and 64-bit integers portably (Bug#8435).
10550 Without this change, on typical 64-bit hosts error ("...%d...", N)
10551 was used to print both 32- and 64-bit integers N, which relied on
10552 undefined behavior.
61bdb816 10553 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10554 * lisp.h (error, verror): Mark as printf-like functions.
10555 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10556 Report overflow in size calculations when allocating printf buffer.
10557 Do not truncate output string at its first null byte.
10558 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10559 Truncate the output at a character boundary, since vsnprintf does not
10560 do that.
10561 * charset.c (check_iso_charset_parameter): Convert internal
10562 character to string before calling 'error', since %c now has the
10563 printf meaning.
10564 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10565 overflow when computing char to be passed to 'error'. Do not
10566 pass Lisp_Object to 'error'; pass the integer instead.
10567 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10568 formatted with plain %d.
10569
b189fa66
PE
10570 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10571
bff87ef0
PE
10572 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10573
7e2cac20
PE
10574 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10575
ce4d90b5
PE
10576 * xterm.c (x_catch_errors): Remove duplicate declaration.
10577
266c9547
PE
10578 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10579
79c49ad2
PE
10580 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10581
368f4090
JM
105822011-04-10 Jim Meyering <meyering@redhat.com>
10583
10584 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10585 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10586 return ssize_t not "int", and use size_t as the buffer length.
10587 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10588 * gnutls.h: Update declarations.
10589 * process.c (read_process_output): Use ssize_t, to match.
10590 (send_process): Likewise.
10591
a32d4040
CY
105922011-04-09 Chong Yidong <cyd@stupidchicken.com>
10593
10594 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10595
8546720e 105962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10597
04f2d78b
CB
10598 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10599 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10600
8546720e
GM
10601 * xterm.c (handle_one_xevent):
10602 * xmenu.c (create_and_show_popup_menu):
10603 * xselect.c (x_decline_selection_request)
10604 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10605
0a2f5c1a 106062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10607
10608 Fix some uses of `int' instead of EMACS_INT.
10609 * search.c (string_match_1, fast_string_match)
10610 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10611 (scan_buffer, find_next_newline_no_quit)
10612 (find_before_next_newline, search_command, Freplace_match)
10613 (Fmatch_data): Make some `int' variables be EMACS_INT.
10614
10615 * xdisp.c (display_count_lines): 3rd argument and return value now
10616 EMACS_INT. All callers changed.
10617 (pint2hrstr): Last argument is now EMACS_INT.
10618
10619 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10620 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10621 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10622 (decode_coding_utf_16, decode_coding_emacs_mule)
10623 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10624 (decode_coding_ccl, decode_coding_charset)
10625 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10626 (decode_coding_iso_2022, decode_coding_emacs_mule)
10627 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10628 <char_offset, last_offset>: Declare EMACS_INT.
10629 (encode_coding_utf_8, encode_coding_utf_16)
10630 (encode_coding_emacs_mule, encode_invocation_designation)
10631 (encode_designation_at_bol, encode_coding_iso_2022)
10632 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10633 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10634 Declare EMACS_INT.
10635 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10636 (encode_invocation_designation): Last argument P_NCHARS is now
10637 EMACS_INT.
10638 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10639 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10640
10641 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10642 All users changed.
10643
10644 * ccl.c (Fccl_execute_on_string): Declare some variables
10645 EMACS_INT.
10646
8546720e 106472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10648
10649 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10650
4e19a977
CS
106512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10652
10653 * process.c (Fformat_network_address): Doc fix.
10654
87302331
R
106552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10656
ee7683eb 10657 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10658
cbb59342
CY
106592011-04-08 Chong Yidong <cyd@stupidchicken.com>
10660
10661 * keyboard.c (read_char): Call Lisp function help-form-show,
10662 instead of using internal_with_output_to_temp_buffer.
10663 (Qhelp_form_show): New var.
e0d38eeb 10664 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10665
10666 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10667
10668 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10669
e67a13ab
CY
106702011-04-06 Chong Yidong <cyd@stupidchicken.com>
10671
04f2d78b
CB
10672 * process.c (Flist_processes): Remove to Lisp.
10673 (list_processes_1): Delete.
e67a13ab 10674
973f782d
EZ
106752011-04-06 Eli Zaretskii <eliz@gnu.org>
10676
7c106b1e
EZ
10677 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10678
973f782d
EZ
10679 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10680
41cf7d1a 106812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10682
ca23cc88
PE
10683 Fix more problems found by GCC 4.6.0's static checks.
10684
f390e2d5
PE
10685 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10686
42eea0d0
PE
10687 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10688
b69769da 10689 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10690
f9541e84
PE
10691 * xdisp.c (vmessage): Mark as a printf-like function.
10692
13841b55
PE
10693 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10694
c136c10f
PE
10695 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10696
5e2d4a30
PE
10697 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10698 printf-like functions.
10699 (tiff_load): Add casts to remove these marks before passing them
10700 to system-supplied API.
10701
583f48b9
PE
10702 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10703
b25d760e
PE
10704 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10705 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10706 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10707 directly, rather than having caller test rule sign. This avoids
10708 some unnecessary tests.
10709 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10710 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10711 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10712
bc7b6697 10713 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10714 (xfont_open): Avoid unnecessary tests.
bc7b6697 10715
27ccc379
PE
10716 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10717
dcd5c89a
PE
10718 * composite.h, composite.c (composition_gstring_put_cache):
10719 Use EMACS_INT, not int, for length.
10720
b13a45c6
PE
10721 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10722 breaking out part of COMPOSITION_DECODE_RULE.
10723 (COMPOSITION_DECODE_RULE): Use it.
10724 * composite.c (get_composition_id): Remove unused local vars,
10725 by using the new macro.
10726
1e792e4d
PE
10727 * textprop.c (set_text_properties_1): Change while to do-while,
10728 since the condition is always true at first.
10729
dc6c6455 10730 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10731 (interval_deletion_adjustment): Return unsigned value.
10732 All uses changed.
dc6c6455 10733
aba7731a
PE
10734 * process.c (list_processes_1, create_pty, read_process_output):
10735 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10736 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10737 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10738 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10739 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10740
fdfc4bf3
PE
10741 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10742
fca8fe46 10743 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10744 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10745
06a0259a 10746 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10747 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10748 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10749
e7b9e80f
PE
10750 * print.c (print_error_message): Avoid int overflow.
10751
56201685
PE
10752 * font.c (font_list_entities): Redo for clarity,
10753 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10754
78834453 10755 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10756 (font_score): Avoid potential overflow in diff calculation.
78834453 10757
0bc0b309 10758 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10759 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10760
e610eaca
PE
10761 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10762
b895abce
PE
10763 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10764 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10765 can always succeed if overflow has undefined behavior.
10766
1f1d9321 10767 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10768 (wordify): Omit three unnecessary tests.
1f1d9321 10769
c59478bc
PE
10770 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10771 All callers changed. This avoids the need for an unused var.
10772
79b73827
PE
10773 * casefiddle.c (casify_region): Remove var that is set but not used.
10774
a4db5dfe
PE
10775 * dired.c (file_name_completion): Remove var that is set but not used.
10776
43aae36e
PE
10777 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10778
2a47c44d 10779 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10780 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10781
a37c69bf
PE
10782 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10783 Check for integer overflow on size calculations.
10784
328ab8e7
PE
10785 * buffer.c (Fprevious_overlay_change): Remove var that is set
10786 but not used.
10787
e5a2a5cb
PE
10788 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10789 Remove vars that are set but not used.
8d84a6eb 10790 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10791 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10792
a60e5f68
PE
10793 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10794
f661cb61 10795 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10796 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10797
f0397f5a
PE
10798 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10799 that are set but not used.
10800
8664db06 10801 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10802 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10803
6abdaa4a
PE
10804 * xselect.c (x_get_local_selection, x_handle_property_notify):
10805 Remove vars that are set but not used.
10806
0ce7538d 10807 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10808 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10809
9ae848fc
PE
10810 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10811 Remove var that is set but not used.
0b918413
PE
10812 (scroll_bar_windows_size): Now size_t, not int.
10813 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10814 Check for overflow.
9ae848fc 10815
a5a62657
PE
10816 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10817 (map_tty_color) [!defined MSDOS]: Likewise.
10818
5c5cdd39
PE
10819 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10820
66ebf983
PE
10821 * coding.c: Remove vars that are set but not used.
10822 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10823 All callers changed.
10824 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10825 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10826 (decode_coding_charset): Remove vars that are set but not used.
10827
1be4d761
PE
10828 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10829 that is set but not used.
10830
47553fa8
PE
10831 * print.c (print_object): Remove var that is set but not used.
10832
1f7196bf 10833 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10834 The gnulib version avoids calling malloc in the usual case,
10835 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10836 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10837 * filelock.c (current_lock_owner): Likewise.
10838 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10839 * sysdep.c: Include allocator.h, careadlinkat.h.
10840 (emacs_no_realloc_allocator): New static constant.
10841 (emacs_readlink): New function.
fdb61804
PE
10842 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10843 ../lib/careadlinkat.h.
d1fdcab7 10844
f84c17c7
SM
108452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10846
10847 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10848 first non-nil return value).
10849
ef3862ad
JD
108502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10851
10852 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10853 if not defined (Bug#8403).
10854
376a7006
JB
108552011-04-02 Juanma Barranquero <lekktu@gmail.com>
10856
10857 * xdisp.c (display_count_lines): Remove parameter `start',
10858 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10859 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10860 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10861 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10862 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10863 and thereabouts. All callers changed.
10864 (get_per_char_metric): Remove parameter `f', unused since
10865 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10866
6ca3801d
JM
108672011-04-02 Jim Meyering <meyering@redhat.com>
10868
10869 do not dereference NULL upon failed strdup
10870 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10871 (ns_get_family): Likewise.
10872
d8e2b5ba
JB
108732011-04-02 Juanma Barranquero <lekktu@gmail.com>
10874
10875 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10876
8c74fcbd
JD
108772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10878
10879 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10880 later (Bug#8403).
10881
7200d79c
SM
108822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10883
03408648 10884 Add lexical binding.
7200d79c 10885
03408648
SM
10886 * window.c (Ftemp_output_buffer_show): New fun.
10887 (Fsave_window_excursion):
10888 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10889
10890 * lread.c (lisp_file_lexically_bound_p): New function.
10891 (Fload): Bind Qlexical_binding.
10892 (readevalloop): Remove `evalfun' arg.
10893 Bind Qinternal_interpreter_environment.
10894 (Feval_buffer): Bind Qlexical_binding.
10895 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10896 Mark as dynamic.
10897 (syms_of_lread): Declare `lexical-binding'.
10898
10899 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10900
10901 * keyboard.c (eval_dyn): New fun.
10902 (menu_item_eval_property): Use it.
ca105506
SM
10903
10904 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10905
03408648
SM
10906 * fns.c (concat, mapcar1): Accept byte-code-functions.
10907
10908 * eval.c (Fsetq): Handle lexical vars.
10909 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10910 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10911 (FletX, Flet): Obey lexical binding.
10912 (Fcommandp): Handle closures.
10913 (Feval): New `lexical' arg.
10914 (eval_sub): New function extracted from Feval. Use it almost
10915 everywhere where Feval was used. Look up vars in lexical env.
10916 Handle closures.
10917 (Ffunctionp): Move from subr.el.
10918 (Ffuncall): Handle closures.
10919 (apply_lambda): Remove `eval_flags'.
10920 (funcall_lambda): Handle closures and new byte-code-functions.
10921 (Fspecial_variable_p): New function.
10922 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10923 but without exporting it to Lisp.
23aba0ea 10924
23aba0ea 10925 * doc.c (Fdocumentation, store_function_docstring):
03408648 10926 * data.c (Finteractive_form): Handle closures.
23aba0ea 10927
03408648
SM
10928 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10929 interactive spec.
ba83908c 10930
04f2d78b
CB
10931 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10932 New byte-codes.
03408648
SM
10933 (exec_byte_code): New function extracted from Fbyte_code to handle new
10934 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10935
03408648 10936 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10937
03408648 10938 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10939
e2abce01
JB
109402011-03-31 Juanma Barranquero <lekktu@gmail.com>
10941
10942 * xdisp.c (redisplay_internal): Fix prototype.
10943
63696a73 109442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10945
63696a73 10946 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10947 (try_scrolling): Use it when setting scroll_limit.
10948 Limit scrolling to 100 screen lines.
63696a73
EZ
10949 (redisplay_window): Even when falling back on "recentering",
10950 position point in the window according to scroll-conservatively,
10951 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10952
10953 (try_scrolling): When point is above the window, allow searching
10954 as far as scroll_max, or one screenful, to compute vertical
10955 distance from PT to the scroll margin position. This prevents
10956 try_scrolling from unnecessarily failing when
10957 scroll-conservatively is set to a value slightly larger than the
10958 window height. Clean up the case of PT below the margin at bottom
10959 of window: scroll_max can no longer be INT_MAX. When aggressive
10960 scrolling is in use, don't let point enter the opposite scroll
10961 margin as result of the scroll.
10962 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10963 threshold of 100 lines for never-recentering scrolling.
10964
e4cc2dfc
JB
109652011-03-31 Juanma Barranquero <lekktu@gmail.com>
10966
10967 * dispextern.h (move_it_by_lines):
10968 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10969 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10970 (message_log_check_duplicate): Remove parameters `prev_bol' and
10971 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10972 (redisplay_internal): Remove parameter `preserve_echo_area',
10973 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10974
10975 * indent.c (Fvertical_motion):
10976 * window.c (window_scroll_pixel_based, Frecenter):
10977 Don't pass `need_y_p' to `move_it_by_lines'.
10978
1c470562
SM
109792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10980
44f230aa
SM
10981 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10982 steal a few bits to be more compact.
10983 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10984 Remove unneeded casts.
10985
1c470562
SM
10986 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10987
888adce9
ZK
109882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10989
10990 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10991 binding" message (bug#7967).
10992
f838ed7b
PE
109932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10994
77861b95
PE
10995 Fix more problems found by GCC 4.6.0's static checks.
10996
de6dbc14
PE
10997 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10998 Remove unused local var.
10999
f838ed7b
PE
11000 * editfns.c (Fmessage_box): Remove unused local var.
11001
792c7b2b
PE
11002 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11003 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11004 Omit unused local vars.
c499e557 11005 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11006 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11007 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11008 Omit unused local var.
11009
ba0165e1
PE
11010 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11011 Don't assume string length fits in int.
32ad8845 11012 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11013 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11014
3c59b4c9
PE
11015 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11016 instead of alloca (Bug#8344).
11017
a3eed478 11018 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11019 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11020
eb4d412d
PE
11021 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11022
1658b401
PE
11023 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11024 concerns.
11025
11026 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11027
11028 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11029
9a2c6e05
PE
11030 * keyboard.c (syms_of_keyboard): Use the same style as later
11031 in this function when indexing through an array. This also
11032 works around GCC bug 48267.
11033
03d0a109
PE
11034 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11035
44f730c8
PE
11036 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11037
fe75f926
PE
11038 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11039 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11040
ffa8c828
PE
11041 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11042 This avoids undefined behavior on integer overflow, and is a bit
11043 more convenient anyway since it is compared to a size_t variable.
11044
c5101a77
PE
11045 Variadic C functions now count arguments with size_t, not int.
11046 This avoids an unnecessary limitation on 64-bit machines, which
11047 caused (substring ...) to crash on large vectors (Bug#8344).
11048 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11049 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11050 All variadic functions and their callers changed accordingly.
c5101a77
PE
11051 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11052 * data.c (arith_driver, float_arith_driver): Likewise.
11053 * editfns.c (general_insert_function): Likewise.
11054 * eval.c (struct backtrace.nargs, interactive_p)
11055 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11056 (funcall_lambda, mark_backtrace): Likewise.
11057 * fns.c (concat): Likewise.
11058 * frame.c (x_set_frame_parameters): Likewise.
11059 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11060 0 if not found, not -1. All callers changed.
11061
dd3f25f7
PE
11062 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11063 (stack_copy_size): Now size_t, not int.
11064 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11065
461c2ab9
JB
110662011-03-28 Juanma Barranquero <lekktu@gmail.com>
11067
11068 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11069 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11070 All callers changed.
11071
11072 * lisp.h (multibyte_char_to_unibyte):
11073 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11074 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11075 * character.h (CHAR_TO_BYTE8):
11076 * cmds.c (internal_self_insert):
11077 * editfns.c (general_insert_function):
11078 * keymap.c (push_key_description):
11079 * search.c (Freplace_match):
11080 * xdisp.c (message_dolog, set_message_1): All callers changed.
11081
f6d62986
SM
110822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11083
11084 * keyboard.c (safe_run_hook_funcall): New function.
11085 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11086 don't set the hook to nil, but remove the offending function instead.
11087 (Qcommand_hook_internal): Remove, unused.
11088 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11089 Vcommand_hook_internal.
11090
11091 * eval.c (enum run_hooks_condition): Remove.
11092 (funcall_nil, funcall_not): New functions.
11093 (run_hook_with_args): Call each function through a `funcall' argument.
11094 Remove `cond' argument, now redundant.
11095 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11096 (Frun_hook_with_args_until_failure): Adjust accordingly.
11097 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11098
1db5b1ad
JB
110992011-03-28 Juanma Barranquero <lekktu@gmail.com>
11100
11101 * dispextern.h (string_buffer_position): Remove declaration.
11102
11103 * print.c (strout): Remove parameter `multibyte', unused since
11104 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11105
11106 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11107 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11108 All callers changed.
11109
11110 * w32.c (_wsa_errlist): Use braces for struct initializers.
11111
11112 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11113 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11114 All callers changed.
11115 (string_buffer_position): Likewise. Also, make static (it's never
11116 used outside xdisp.c).
11117 (cursor_row_p): Remove parameter `w', unused since
11118 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11119 (decode_mode_spec): Remove parameter `precision', introduced during
11120 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11121 All callers changed.
11122
5ffb62aa
JD
111232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11124
11125 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11126
461c2ab9 111272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11128
11129 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11130 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11131 (ns_update_auto_hide_menu_bar): New functions.
11132 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11133 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11134 ns_constrain_all_frames.
11135 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11136 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11137
5c380ffb
JD
111382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11139
11140 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11141
9af30bdf
GM
111422011-03-27 Glenn Morris <rgm@gnu.org>
11143
11144 * syssignal.h: Replace RETSIGTYPE with void.
11145 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11146 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11147 Replace SIGTYPE with void everywhere.
11148 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11149 * s/template.h (SIGTYPE): Remove commented out definition.
11150
e2abce01
JB
111512011-03-26 Eli Zaretskii <eliz@gnu.org>
11152
11153 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11154 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11155
f868cd8a
JB
111562011-03-26 Juanma Barranquero <lekktu@gmail.com>
11157
59eb0929
JB
11158 * w32.c (read_unc_volume): Use parameter `henum', instead of
11159 global variable `wget_enum_handle'.
11160
11161 * keymap.c (describe_vector): Remove parameters `indices' and
11162 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11163 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11164
f868cd8a
JB
11165 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11166
11167 * keyboard.c (timer_check): Remove parameter `do_it_now',
11168 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11169 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11170 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11171
11172 * keyboard.c (read_char):
11173 * w32menu.c (w32_menu_display_help):
11174 * xmenu.c (show_help_event, menu_help_callback):
11175 Adjust calls to `show_help_echo'.
11176
11177 * gtkutil.c (xg_maybe_add_timer):
11178 * keyboard.c (readable_events):
11179 * process.c (wait_reading_process_output):
11180 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11181
11182 * insdel.c (adjust_markers_gap_motion):
11183 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11184 (gap_left, gap_right): Don't call it.
11185
2ecf6fdb
CY
111862011-03-25 Chong Yidong <cyd@stupidchicken.com>
11187
11188 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11189 incurred during fontification.
11190
6b1f9ba4
JB
111912011-03-25 Juanma Barranquero <lekktu@gmail.com>
11192
11193 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11194 (DEFVAR_PER_BUFFER): Don't pass it.
11195
11196 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11197 (scrolling_window): Don't pass it.
11198
0f4a96b5
JB
111992011-03-25 Juanma Barranquero <lekktu@gmail.com>
11200
11201 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11202
11203 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11204 and `suffix'.
11205 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11206 of variables specific to SELinux and computation of `encoded_absname'.
11207
11208 * image.c (XPutPixel): Remove unused variable `height'.
11209
11210 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11211
11212 * unexw32.c (get_section_info): Remove unused variable `section'.
11213
11214 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11215 (system_process_attributes): Remove unused variable `sess'.
11216 (sys_read): Remove unused variable `err'.
11217
11218 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11219 (w32_wnd_proc): Remove unused variable `isdead'.
11220 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11221 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11222 (x_create_tip_frame): Remove unused variable `tem'.
11223
11224 * w32inevt.c (w32_console_read_socket):
11225 Remove unused variable `no_events'.
11226
11227 * w32term.c (x_draw_composite_glyph_string_foreground):
11228 Remove unused variable `width'.
11229
1149507c
JB
112302011-03-24 Juanma Barranquero <lekktu@gmail.com>
11231
11232 * w32term.c (x_set_glyph_string_clipping):
11233 Don't pass uninitialized region to CombineRgn.
11234
9c88f339
JB
112352011-03-23 Juanma Barranquero <lekktu@gmail.com>
11236
11237 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11238 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11239 (Fx_close_connection): Remove unused variable `i'.
11240
11241 * w32font.c (w32font_draw): Return number of glyphs.
11242 (w32font_open_internal): Remove unused variable `i'.
11243 (w32font_driver): Add missing initializer.
11244
11245 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11246 (fill_in_menu): Remove unused variable `items_added'.
11247
11248 * w32term.c (last_mouse_press_frame): Remove static global variable.
11249 (w32_clip_to_row): Remove unused variable `f'.
11250 (x_delete_terminal): Remove unused variable `i'.
11251
11252 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11253 (NOTHING): Remove unused static global variable.
11254 (uniscribe_check_otf): Remove unused variable `table'.
11255 (uniscribe_font_driver): Add missing initializers.
11256
dee091a3
JD
112572011-03-23 Julien Danjou <julien@danjou.info>
11258
11259 * term.c (Fsuspend_tty, Fresume_tty):
11260 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11261 * window.c (temp_output_buffer_show):
11262 * insdel.c (signal_before_change):
11263 * frame.c (Fhandle_switch_frame):
11264 * fileio.c (Fdo_auto_save):
11265 * emacs.c (Fkill_emacs):
11266 * editfns.c (save_excursion_restore):
11267 * cmds.c (internal_self_insert):
11268 * callint.c (Fcall_interactively):
11269 * buffer.c (Fkill_all_local_variables):
11270 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11271 Use Frun_hooks.
0f4a96b5 11272 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11273 unconditionally since it does the check itself.
dee091a3 11274
2c520ab5 112752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11276
c9c49752
PE
11277 Fix more problems found by GCC 4.5.2's static checks.
11278
8abc3f12
PE
11279 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11280 the first time through the loop, since we know p0 < p1 then.
11281 This also avoids a gcc -Wstrict-overflow warning.
11282
a2d26660
PE
11283 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11284 leading to a memory leak, possible in functions like
11285 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11286 of objects (Bug#8318).
a2d26660 11287
916c72e9
PE
11288 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11289 that could (at least in theory) be that large.
11290
19ab8a18
PE
11291 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11292 This is less likely to overflow, and avoids undefined behavior if
11293 overflow does occur. All callers changed. Use strtoul to scan
11294 for the unsigned long integer.
b7cbbd6f
PE
11295 (pint2hrstr): Simplify and tune code slightly.
11296 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11297
f0641eff
PE
11298 * scroll.c (do_scrolling): Work around GCC bug 48228.
11299 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11300
7f650bb9
PE
11301 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11302 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11303 (validate_x_resource_name): Simplify count usage.
11304 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11305
37dd57d1
PE
11306 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11307 fail (Bug#8306).
81e56e61 11308
699979fc 11309 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11310
401bf9b4
PE
11311 * process.c (Fmake_network_process): Use socklen_t, not int,
11312 where POSIX says socklen_t is required in portable programs.
11313 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11314 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11315 (Fmake_network_process, server_accept_connection):
11316 (wait_reading_process_output, read_process_output):
11317 Likewise.
11318
b93aacde
PE
11319 * process.c: Rename or move locals to avoid shadowing.
11320 (list_processes_1, Fmake_network_process):
11321 (read_process_output_error_handler, exec_sentinel_error_handler):
11322 Rename or move locals.
4dc343ee 11323 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11324 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11325 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11326 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11327 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11328
af8a867c 11329 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11330 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11331 Include tparam.h instead, since it declares them.
af8a867c
PE
11332 * cm.h (PC): Remove extern decl; tparam.h now does this.
11333 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11334 * terminfo.c: Include tparam.h, to check interfaces.
11335 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11336 (tparam): Adjust signature to match interface in tparam.h;
11337 this removes some undefined behavior. Check that outstring and len
11338 are zero, which they always are with Emacs.
11339 * tparam.h (PC, BC, UP): New extern decls.
11340
0248044d 11341 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11342 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11343
8ff096c1 11344 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11345 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11346 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11347 (ftfont_list): Remove unused local.
49eaafba
PE
11348 (get_adstyle_property, ftfont_pattern_entity):
11349 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11350 Rename locals to avoid shadowing.
8ff096c1 11351
e2be39f6
PE
11352 * xfont.c (xfont_list_family): Mark var as initialized.
11353
c9735e30
PE
11354 * xml.c (make_dom): Now static.
11355
8f5201ae
PE
11356 * composite.c (composition_compute_stop_pos): Rename local to
11357 avoid shadowing.
b246f932
PE
11358 (composition_reseat_it): Remove unused locals.
11359 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11360 (composition_update_it): Mark var as initialized.
11b61122
PE
11361 (find_automatic_composition): Mark vars as initialized,
11362 with a FIXME (Bug#8290).
8f5201ae 11363
760fbc2c
PE
11364 character.h: Rename locals to avoid shadowing.
11365 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11366 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11367 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11368 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11369 to avoid shadowing.
11370
ff08eb85
PE
11371 * textprop.c (property_change_between_p): Remove; unused.
11372
fc7bf025
PE
11373 * intervals.c (interval_start_pos): Now static.
11374
235d7abc
PE
11375 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11376
44f230aa
SM
11377 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11378 Rename locals to avoid shadowing.
3e7d6594 11379
50060332
PE
11380 * sound.c (wav_play, au_play, Fplay_sound_internal):
11381 Fix pointer signedness.
d01f234b 11382 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11383 (wav_play): Initialize a variable to 0, to prevent undefined
11384 behavior (Bug#8278).
50060332 11385
c4fc4e30
PE
11386 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11387
918436ed
PE
11388 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11389
c939f91b
PE
11390 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11391 clobbering (Bug#8298).
b9c7f648
PE
11392 * sysdep.c (sys_subshell): Likewise.
11393 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11394
6bd8c144
PE
11395 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11396 This should get cleaned up, so that child_setup has the
11397 same signature on all platforms.
11398
7710357c 11399 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11400 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11401
c59da222
CY
114022011-03-22 Chong Yidong <cyd@stupidchicken.com>
11403
11404 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11405 not to be necessary, and produces flickering.
11406
66b87493
GM
114072011-03-20 Glenn Morris <rgm@gnu.org>
11408
11409 * config.in: Remove file.
11410
45b6f6d5
JB
114112011-03-20 Juanma Barranquero <lekktu@gmail.com>
11412
11413 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11414 are now in src/globals.h.
11415 (syms_of_minibuf): Remove spurious & from previous change.
11416
cd394be1 114172011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11418
11419 * minibuf.c (completing-read-function): New variable.
11420 (completing-read-default): Rename from completing-read.
11421 (completing-read): Call completing-read-function.
11422
b14e3e21
CY
114232011-03-19 Juanma Barranquero <lekktu@gmail.com>
11424
11425 * xfaces.c (Fx_load_color_file):
11426 Read color file from absolute filename (bug#8250).
11427
f2b726e6
JB
114282011-03-19 Juanma Barranquero <lekktu@gmail.com>
11429
11430 * makefile.w32-in: Update dependencies.
11431
09f6ff02
EZ
114322011-03-17 Eli Zaretskii <eliz@gnu.org>
11433
11434 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11435
29a6015a
PE
114362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11437
a3a6c54e
PE
11438 Fix more problems found by GCC 4.5.2's static checks.
11439
b766f867
PE
11440 * process.c (make_serial_process_unwind, send_process_trap):
11441 (sigchld_handler): Now static.
11442
be02381c
PE
11443 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11444 That way, the code declares only the vars that it needs.
11445 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11446 * s/cygwin.h (PTY_ITERATION): Likewise.
11447 * s/darwin.h (PTY_ITERATION): Likewise.
11448 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11449
57048744
PE
11450 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11451 * process.c (allocate_pty): Don't declare stb unless it's needed.
11452
7914961c 11453 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11454 (CONSTANTLIM): Remove; unused.
11455 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11456 Define only if needed.
7914961c 11457
b3967b18
PE
11458 * unexelf.c (unexec): Name an expression,
11459 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11460 Use a different way to cause a compilation error if anyone uses
11461 n rather than nn, a way that does not involve shadowing.
73366a00 11462 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11463
29a6015a
PE
11464 * deps.mk (unexalpha.o): Remove; unused.
11465
43cfc33e 11466 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11467 * unexec.h: New file.
ce701a33
PE
11468 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11469 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11470 Depend on unexec.h.
11471 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11472 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11473 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11474 Change as necessary to match prototype in unexec.h.
ce701a33 11475
01f44d5a
PE
11476 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11477 shadowing.
4f63c6bb 11478 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11479
a6670b0b
PE
11480 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11481 Rename locals to avoid shadowing.
11482
cef2010d 11483 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11484 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11485
d4d7173a
PE
11486 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11487
f08b802a
PE
11488 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11489 warning when compiling print.c.
11490
3ddb0639
PE
11491 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11492 instead of using an uninitialized var.
5ad03b97 11493 (font_sort_entities): Mark var as initialized.
3ddb0639 11494
170a2692
PE
11495 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11496
e663c700
PE
11497 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11498 pointers to constants.
89bc529a 11499 (font_parse_fcname): Remove unused vars.
7b81e2d0 11500 (font_delete_unmatched): Now static.
ea838e10 11501 (font_get_spec): Remove; unused.
13a547c6
PE
11502 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11503 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11504 Rename or move locals to avoid shadowing.
e663c700 11505
2a80c887 11506 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11507 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11508
1384fa33 11509 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11510 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11511
8b2c52e9
PE
11512 * alloc.c (mark_backtrace): Move decl from here ...
11513 * lisp.h: ... to here, so that it can be checked.
11514
475545b5 11515 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11516 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11517 (lisp_indirect_variable): Name an expression,
11518 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11519 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11520
b1349114 11521 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11522 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11523 Use const pointer when appropriate.
b1349114 11524
a2928364
PE
11525 * lisp.h (get_system_name, get_operating_system_release):
11526 Move decls here, to check interfaces.
11527 * process.c (get_operating_system_release): Move decl to lisp.h.
11528 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11529 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11530 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11531 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11532 (Fformat_time_string, Fencode_time, Finsert_char):
11533 (Ftranslate_region_internal, Fformat):
11534 Rename or remove local vars to avoid shadowing.
9710023e 11535 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11536
a415e694
PE
11537 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11538 avoid shadowing.
11539
8ef4622d
PE
11540 * lisp.h (eassert): Check that the argument compiles, even if
11541 ENABLE_CHECKING is not defined.
11542
946f9a5b
PE
11543 * data.c (Findirect_variable): Name an expression, to avoid
11544 gcc -Wbad-function-cast warning.
112396d6 11545 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11546 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11547 (Fmake_variable_buffer_local, Fmake_local_variable):
11548 Mark variables as initialized.
52746918 11549 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11550
e5aab7e7 11551 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11552 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11553 Rename locals to avoid shadowing.
dff45157
PE
11554 (mark_stack): Move local variables into the #ifdef region where
11555 they're used.
7bc26fdb
PE
11556 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11557 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11558 needed otherwise.
11559 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11560 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11561 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11562
e5aab7e7
PE
11563 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11564 avoids undefined behavior in theory.
11565
4da60324
PE
11566 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11567
88043301
PE
11568 Use functions, not macros, for up- and down-casing (Bug#8254).
11569 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11570 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11571 to use the following functions instead of these macros.
11572 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11573 EMACS_INT, since callers assume the returned value fits in int.
11574 (upcase1): Likewise, for UPCASE_TABLE.
11575 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11576 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11577 the race-condition problem in the old DOWNCASE.
88043301 11578
19ed5445
PE
11579 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11580 Rename locals to avoid shadowing.
11581 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11582 (regex_compile, re_search_2, re_match_2_internal):
11583 Remove unused local vars.
952db0d7
PE
11584 (FREE_VAR): Rewrite so as not to use empty "else",
11585 which gcc can warn about.
da053e48 11586 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11587 (RETALLOC_IF): Define only if needed.
11588 (WORDCHAR_P): Likewise. This one is never needed, but is used
11589 only in a comment talking about a compiler bug, so put inside
11590 the #if 0 of that comment.
11591 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11592 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11593 Remove; unused.
19ed5445 11594
1f3561e4 11595 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11596 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11597 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11598
ded6f8f7
PE
11599 * search.c (simple_search): Remove unused var.
11600
dbd37a95
PE
11601 * dired.c (compile_pattern): Move decl from here ...
11602 * lisp.h: ... to here, so that it can be checked.
11603 (struct re_registers): New forward decl.
11604
7e47afad
PE
11605 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11606
85f24f61
PE
11607 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11608 All uses changed.
11609 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11610 Rename locals to avoid shadowing.
5671df8f 11611 (Fvertical_motion): Mark locals as initialized.
85f24f61 11612
181aa2be 11613 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11614 (casify_region): Mark local as initialized.
181aa2be 11615
930d429c
PE
11616 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11617
7082eac6
PE
11618 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11619 New macros, so that the caller can use some names other than
11620 gcpro1, gcpro2, etc.
11621 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11622 of the new macros.
11623 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11624 argument, for consistency with GCPRO2_VAR, etc: it is now the
11625 prefix of the variable, not the variable itself. All uses
11626 changed.
38b2c076
PE
11627 * dired.c (directory_files_internal, file_name_completion):
11628 Rename locals to avoid shadowing.
11629
15206ed9
PE
11630 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11631 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11632 dired.c's scmp function, had undefined behavior.
11633 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11634 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11635 * buffer.h: ... to here, because these macros use current_buffer,
11636 and the new implementation with inline functions needs to have
11637 current_buffer in scope now, rather than later when the macros
11638 are used.
11639 (downcase, upcase1): New static inline functions.
11640 (DOWNCASE, UPCASE1): Reimplement using these functions.
11641 This avoids undefined behavior in expressions like
11642 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11643 from race conditions in accessing the global variables
11644 case_temp1 and case_temp2.
11645 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11646 * lisp.h (case_temp1, case_temp2): Remove their decls.
11647 * character.h (ASCII_CHAR_P): Move from here ...
11648 * lisp.h: ... to here, so that the inline functions mentioned
11649 above can use them.
11650
4a6bea26
PE
11651 * dired.c (directory_files_internal_unwind): Now static.
11652
f14b7e14
PE
11653 * fileio.c (file_name_as_directory, directory_file_name):
11654 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11655 Now static.
2893f146
PE
11656 (file_name_as_directory): Use const pointers when appropriate.
11657 (Fexpand_file_name): Likewise. In particular, newdir might
11658 point at constant storage, so make it a const pointer.
fd4ead52 11659 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11660 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11661 signedness issues.
f839df0c
PE
11662 (Fset_file_times, Finsert_file_contents, auto_save_error):
11663 Rename locals to avoid shadowing.
f14b7e14 11664
5716756e 11665 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11666 (Ftry_completion, Fall_completions): Rename or remove locals
11667 to avoid shadowing.
5716756e 11668
b4c3046a
PE
11669 * marker.c (bytepos_to_charpos): Remove; unused.
11670
b45db522
PE
11671 * lisp.h (verify_bytepos, count_markers): New decls,
11672 so that gcc does not warn that these functions aren't declared.
11673
85876d07
PE
11674 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11675 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11676 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11677 (copy_text): Remove unused local var.
85876d07 11678
03d78a21 11679 * filelock.c (within_one_second): Now static.
b3dd38ab 11680 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11681
5df8f01b
PE
11682 * buffer.c (fix_overlays_before): Mark locals as initialized.
11683 (fix_start_end_in_overlays): Likewise. This function should be
11684 simplified by using pointers-to-pointers, but that's a different
11685 matter.
b1d876f1 11686 (switch_to_buffer_1): Now static.
8f54f30a
PE
11687 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11688 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11689
a70072c9 11690 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11691 Fix pointer signedness issue.
edced198
PE
11692 (sys_subshell): Mark local as volatile if checking for lint,
11693 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11694 (MAXPATHLEN): Define only if needed.
a70072c9 11695
a0977c44
PE
11696 * process.c (serial_open, serial_configure): Move decls from here ...
11697 * systty.h: ... to here, so that they can be checked.
11698
a884fdcc
PE
11699 * fns.c (get_random, seed_random): Move extern decls from here ...
11700 * lisp.h: ... to here, so that they can be checked.
11701
604efe86 11702 * sysdep.c (reset_io): Now static.
b8950c94 11703 (wait_for_termination_signal): Remove; unused.
604efe86 11704
38fc62d9
PE
11705 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11706 (copy_keymap_item, append_key, push_text_char_description):
11707 Now static.
1004a21a 11708 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11709 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11710 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11711 (describe_map_tree):
11712 Rename locals to avoid shadowing.
38fc62d9 11713
2f2650da
PE
11714 * keyboard.c: Declare functions static if they are not used elsewhere.
11715 (echo_char, echo_dash, cmd_error, top_level_2):
11716 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11717 (read_char, kbd_buffer_get_event, make_lispy_position):
11718 (make_lispy_event, make_lispy_movement, apply_modifiers):
11719 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11720 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11721 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11722 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11723 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11724
a053e86c 11725 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11726 (mark_kboards): Move decl here ...
11727 * alloc.c (mark_kboards): ... from here.
a053e86c 11728
4752793e
PE
11729 * lisp.h (force_auto_save_soon): New decl.
11730
74f10ca7 11731 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11732 (DEFINE_DUMMY_FUNCTION): New macro.
11733 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11734 Use it.
c03cd23f
PE
11735 (main): Add casts to avoid warnings
11736 if GCC considers string literals to be constants.
74f10ca7 11737
022e70d4
PE
11738 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11739
59d6fe83
PE
11740 * dbusbind.c: Pointer signedness fixes.
11741 (xd_signature, xd_append_arg, xd_initialize):
11742 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11743 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11744 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11745 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11746
78320123
PE
11747 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11748 if GCC considers string literals to be constants.
49cebcca 11749 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11750
35ac2a97
SM
117512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11752
fb103ca9
SM
11753 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11754 (print_preprocess, print_object): New macro to fix last change.
11755
35ac2a97
SM
11756 * print.c (print_preprocess): Don't forget font objects.
11757
62973b41
JB
117582011-03-16 Juanma Barranquero <lekktu@gmail.com>
11759
11760 * emacs.c (USAGE3): Doc fixes.
11761
0e48bb22
AS
117622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11763
11764 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11765 structure.
11766
7684e57b
JB
117672011-03-14 Juanma Barranquero <lekktu@gmail.com>
11768
11769 * lisp.h (VWindow_system, Qfile_name_history):
11770 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11771 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11772 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11773
11774 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11775 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11776
11777 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11778 * w32console.c (detect_input_pending, read_input_pending)
11779 (encode_terminal_code):
11780 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11781 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11782 (w32_system_caret_y, Qfile_name_history):
11783 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11784 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11785 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11786 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11787 * w32proc.c (Qlocal, report_file_error):
11788 * w32term.c (Vwindow_system, updating_frame):
11789 * w32uniscribe.c (initialized, uniscribe_font_driver):
11790 Remove unneeded extern declarations.
11791
2aa46d6c
CY
117922011-03-14 Chong Yidong <cyd@stupidchicken.com>
11793
c96bbc66 11794 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11795
cffc6f3b
CY
117962011-03-13 Chong Yidong <cyd@stupidchicken.com>
11797
11798 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11799 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11800 These macros can no longer be used for assignment.
11801
44f230aa
SM
11802 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11803 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11804 (record_buffer_markers, fetch_buffer_markers): New functions for
11805 recording and fetching special buffer markers.
11806 (set_buffer_internal_1, set_buffer_temp): Use them.
11807
11808 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11809
11810 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11811
11812 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11813 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11814
11815 * xdisp.c (hscroll_window_tree):
11816 (reconsider_clip_changes): Use PT instead of BUF_PT.
11817
d251f04b
EZ
118182011-03-13 Eli Zaretskii <eliz@gnu.org>
11819
11820 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11821 $(EMACS_ROOT)/lib/intprops.h.
11822
f0c77cd1
PE
118232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11824
3eca4629
PE
11825 Fix more problems found by GCC 4.5.2's static checks.
11826
7c86ee98
PE
11827 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11828 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11829 (xg_free_frame_widgets): Make it clear that a local variable is
11830 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11831 (gdk_window_get_screen): Make it clear that this macro is needed
11832 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11833 (int_gtk_range_get_value): New function, which avoids a diagnostic
11834 from gcc -Wbad-function-cast.
11835 (xg_set_toolkit_scroll_bar_thumb): Use it.
11836 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11837 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11838 (get_utf8_string, xg_get_file_with_chooser):
11839 Rename locals to avoid shadowing.
11840 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11841
41729b81
PE
11842 * xgselect.c (xg_select): Remove unused var.
11843
f0c77cd1
PE
11844 * image.c (four_corners_best): Mark locals as initialized.
11845 (gif_load): Initialize transparent_p to zero (Bug#8238).
11846 Mark another local as initialized.
ec6cf4c6 11847 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11848
ce0ad53d 11849 * image.c (clear_image_cache): Now static.
d5d5a617 11850 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11851 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11852 (x_edge_detection): Remove unnecessary cast that
11853 gcc -Wbad-function-cast diagnoses.
2037898d 11854 (gif_load): Fix pointer signedness.
6ae141d6
PE
11855 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11856 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11857
33383987 118582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11859
d32df629
PE
11860 Improve quality of tests for time stamp overflow.
11861 For example, without this patch (encode-time 0 0 0 1 1
11862 1152921504606846976) returns the obviously-bogus value (-948597
11863 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11864 reports time overflow. See
11865 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11866 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11867 * editfns.c: Include limits.h and intprops.h.
11868 (TIME_T_MIN, TIME_T_MAX): New macros.
11869 (time_overflow): Move earlier, to before first use.
11870 (hi_time, lo_time): New functions, for an accurate test for
11871 out-of-range times.
11872 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11873 (Fget_internal_run_time): Don't assume time_t fits in int.
11874 (make_time): Use list2 instead of Fcons twice.
11875 (Fdecode_time): More accurate test for out-of-range times.
11876 (check_tm_member): New function.
11877 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11878 (lisp_time_argument): Don't rely on undefined left-shift and
11879 right-shift behavior when checking for time stamp overflow.
8be6f318 11880
fe31d94c
PE
11881 * editfns.c (time_overflow): New function, refactoring common code.
11882 (Fformat_time_string, Fdecode_time, Fencode_time):
11883 (Fcurrent_time_string): Use it.
11884
8be6f318
PE
11885 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11886 * dired.c (make_time): Move to ...
11887 * editfns.c (make_time): ... here.
11888 * systime.h: Note the move.
11889
09d9db2c 118902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11891
126bc0dc
YM
11892 * fringe.c (update_window_fringes): Remove unused variables.
11893
c47cbdfd
YM
11894 * unexmacosx.c (copy_data_segment): Also copy __got section.
11895 (Bug#8223)
11896
7ac80be9
EZ
118972011-03-12 Eli Zaretskii <eliz@gnu.org>
11898
c96bbc66 11899 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11900 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11901 Constify `char *' arguments and their references according to
11902 prototypes in tparam.h.
11903
ecb0f94d 11904 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11905
7ac80be9
EZ
11906 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11907 Adapt all references accordingly.
11908
11909 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11910
ef1fd07e
TT
119112011-03-11 Tom Tromey <tromey@redhat.com>
11912
11913 * buffer.c (syms_of_buffer): Remove obsolete comment.
11914
7ef4b50c
EZ
119152011-03-11 Eli Zaretskii <eliz@gnu.org>
11916
11917 * termhooks.h (encode_terminal_code): Declare prototype.
11918
11919 * msdos.c (encode_terminal_code): Don't declare prototype.
11920
11921 * term.c (encode_terminal_code): Now external again, used by
11922 w32console.c and msdos.c.
11923
44f230aa
SM
11924 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11925 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11926
4b1ec863 119272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11928
1714f52b 11929 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11930
4b1ec863
PE
11931 * fringe.c (update_window_fringes): Mark locals as initialized
11932 (Bug#8227).
11933 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11934
524c7aa6
PE
11935 * alloc.c (mark_fringe_data): Move decl from here ...
11936 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11937 to check its interface.
11938 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11939
a5c0af81 11940 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11941 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11942 (fontset_font): Mark local as initialized.
a9a06e0b 11943 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11944
b4716021
PE
11945 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11946
811e9bac 11947 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11948 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11949 (x_own_selection, Fx_disown_selection_internal): Rename locals
11950 to avoid shadowing.
11951 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11952
7e3ab302
PE
11953 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11954 so that the caller can use some name other than gcpro1.
11955 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11956 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11957 (Fx_backspace_delete_keys_p):
11958 Use them to avoid shadowing, and rename vars to avoid shadowing.
11959 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11960 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11961 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11962 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11963 Remove unused locals.
7e3ab302
PE
11964 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11965 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11966 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11967 macros.
f78faa98 11968
e2b13473
PE
11969 * xterm.h (x_mouse_leave): New decl.
11970
77f23912
PE
11971 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11972 Remove unused functions.
cdf4ba58
PE
11973 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11974 (x_calc_absolute_position): Now static.
7411c686 11975 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11976 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11977 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11978 unless they are used.
38d0b34a
PE
11979 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11980 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11981 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11982 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11983 (x_error_catcher, x_connection_closed, x_error_handler):
11984 (x_error_quitter, xembed_send_message, x_iconify_frame):
11985 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11986 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11987 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11988
44f230aa
SM
11989 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11990 Rename or move locals to avoid shadowing.
6b463e58 11991 (tty_defined_color, merge_face_heights): Now static.
5967d051 11992 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11993 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11994 does not deduce is never used uninitialized.
73719eba
PE
11995 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11996 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11997
426994c3 11998 * terminal.c (store_terminal_param): Now static.
5489860b 11999
032f1620 12000 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12001 (set_frame_menubar): Remove unused local.
d4323972 12002 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12003 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12004 since they might point to immutable storage.
281585b0
PE
12005 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12006 since it's unused otherwise.
032f1620 12007
367c19e5 12008 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12009 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12010 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12011 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12012 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12013 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12014 does not deduce are never used uninitialized.
70739cbe 12015
07b48fa9
PE
12016 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12017
8868a238 12018 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12019 * window.c (window_loop, size_window):
12020 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12021
7e5cf297 12022 * window.c (display_buffer): Now static.
d6550a9f
PE
12023 (size_window): Mark variables that gcc -Wuninitialized
12024 does not deduce are never used uninitialized.
a586633d
PE
12025 * window.h (check_all_windows): New decl, to forestall
12026 gcc -Wmissing-prototypes diagnostic.
5b555da1 12027 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12028
f6095868
PE
12029 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12030 shadowing.
12031 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12032 Include <limits.h>.
12033 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12034 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12035 (load_charset_map): Mark variables that gcc -Wuninitialized
12036 does not deduce are never used uninitialized.
53df7c11 12037 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12038
f38b440c
PE
12039 * coding.c (coding_set_source, coding_set_destination):
12040 Use "else { /* comment */ }" rather than "else /* comment */;"
12041 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12042 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12043 a block, when the outer 'i' will do.
12044 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12045 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12046 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12047 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12048 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12049 Rename locals to avoid shadowing.
12050 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12051 * coding.c (emacs_mule_char, encode_invocation_designation):
12052 Now static, since they're not used elsewhere.
413bb2db 12053 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12054 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12055 (decode_coding_emacs_mule): Mark variables that gcc
12056 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12057 (detect_coding_iso_2022): Initialize a local variable that might
12058 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12059 this initialization is needed. (Bug#8211)
5f58e762
PE
12060 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12061 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12062 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12063 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12064 Remove unused macros.
f38b440c 12065
232b38b9 12066 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12067 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12068 * character.c (string_count_byte8): Likewise.
232b38b9 12069
fb90da1b
PE
12070 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12071 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12072
fb93dbc2
PE
12073 * chartab.c (copy_sub_char_table): Now static, since it's not used
12074 elsewhere.
5c156ace
PE
12075 (sub_char_table_ref_and_range, char_table_ref_and_range):
12076 Rename locals to avoid shadowing.
bbcd0949 12077 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12078
7d3b3862 12079 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12080 (BIDI_BOB): Remove unused macro.
7d3b3862 12081
6be7d3da
PE
12082 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12083 deduce are never used uninitialized.
c2ed9c8b 12084 * term.c (encode_terminal_code): Likewise.
6be7d3da 12085
75f8807f 12086 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12087
50938595
PE
12088 * tparam.h: New file.
12089 * term.c, tparam.h: Include it.
12090 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12091 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12092 Move these decls to tparam.h, and make them agree with what
12093 is actually in tparam.c. The previous trick of using incompatible
12094 decls in different modules does not conform to the C standard.
12095 All callers of tparam changed to use tparam's actual API.
12096 * tparam.c (tparam1, tparam, tgoto):
12097 Use const pointers where appropriate.
12098
fbceeba2
PE
12099 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12100 * cm.h (struct cm): Likewise.
12101 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12102 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12103 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12104 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12105 (turn_on_face, init_tty): Likewise.
12106 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12107
7f3f1250
PE
12108 * term.c (term_mouse_position): Rename local to avoid shadowing.
12109
e6ca6543
PE
12110 * alloc.c (mark_ttys): Move decl from here ...
12111 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12112
c40f8d15
AS
121132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12114
12115 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12116
cfe0661d
JB
121172011-03-09 Juanma Barranquero <lekktu@gmail.com>
12118
12119 * search.c (compile_pattern_1): Remove argument regp, unused since
12120 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12121 (compile_pattern): Don't pass it.
12122
0afb4571
J
121232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12124
12125 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12126 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12127 for ! HAVE_GTK3.
12128 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12129
12130 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12131
12132 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12133 gdk_window_get_screen, gdk_window_get_geometry,
12134 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12135 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12136 (xg_get_pixbuf_from_pixmap): New function.
12137 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12138 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12139 Call xg_get_pixbuf_from_pixmap instead of
12140 gdk_pixbuf_get_from_drawable.
12141 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12142 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12143 (xg_check_special_colors): Use GtkStyleContext and its functions
12144 for HAVE_GTK3.
12145 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12146 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12147 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12148 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12149 Call gtk_widget_get_preferred_size.
0afb4571
J
12150 (xg_frame_resized): gdk_window_get_geometry only takes 5
12151 parameters.
44f230aa
SM
12152 (xg_win_to_widget, xg_event_is_for_menubar):
12153 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12154 (xg_set_widget_bg): New function.
12155 (delete_cb): New function.
895009e1 12156 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12157 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12158 (xg_set_background_color): Call xg_set_widget_bg.
12159 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12160 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12161 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12162 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12163 if ! HAVE_GTK3.
12164 (update_frame_tool_bar): Call gtk_widget_hide.
12165 (xg_initialize): Use GDK_KEY_g.
12166
12167 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12168 if ! HAVE_GTK3
12169 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12170
12171 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12172 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12173 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12174
1c2cc4ef
JB
121752011-03-08 Juanma Barranquero <lekktu@gmail.com>
12176
12177 * w32xfns.c (select_palette): Check success of RealizePalette against
12178 GDI_ERROR, not zero.
12179
33383987 12180See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12181
12182;; Local Variables:
12183;; coding: utf-8
aac0c6e3
MR
12184;; End:
12185
2f097256 12186 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12187
12188 This file is part of GNU Emacs.
12189
12190 GNU Emacs is free software: you can redistribute it and/or modify
12191 it under the terms of the GNU General Public License as published by
12192 the Free Software Foundation, either version 3 of the License, or
12193 (at your option) any later version.
12194
12195 GNU Emacs is distributed in the hope that it will be useful,
12196 but WITHOUT ANY WARRANTY; without even the implied warranty of
12197 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12198 GNU General Public License for more details.
12199
12200 You should have received a copy of the GNU General Public License
12201 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.