Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2ba8e008
SM
12011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4
20f53c69
CY
52011-09-11 Chong Yidong <cyd@stupidchicken.com>
6
7 * minibuf.c (Fread_from_minibuffer): Doc fix.
8
d562d7a4
EZ
92011-09-11 Eli Zaretskii <eliz@gnu.org>
10
11 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
12 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
13
1c4d7f3d
LMI
142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
15
16 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
17 value for non-existent files.
18
b885bf36
EZ
192011-09-11 Eli Zaretskii <eliz@gnu.org>
20
21 * fileio.c (Finsert_file_contents): If the file cannot be opened,
22 set its "size" to -1. This will set the modtime_size field of
23 the corresponding buffer to -1, which is what
24 verify-visited-file-modtime expects for files that do not exist.
25 (Bug#9139)
26
6612f0bf
PE
272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
28
29 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
30 here ...
31 * lisp.h: ... from here. push_key_description is no longer
32 defined in keyboard.c, so its declaration should not be in
33 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
34 logically belongs with push_key_description.
35
dfb3f755
PE
362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
37
38 * buffer.h: Include <sys/types.h> instead of <time.h>.
39 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
40 Problem reported by Herbert J. Skuhra.
41
3134906c
LMI
422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
43
44 * xml.c (parse_region): Make the parsing work for
45 non-comment-starting XML files again (bug#9144).
46
8d903f4e
AS
472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
48
49 * image.c (gif_load): Fix calculation of bottom and right corner.
50 (Bug#9468)
51
80ad64f4
EZ
522011-09-10 Eli Zaretskii <eliz@gnu.org>
53
54 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
55 redisplay in small windows.
56
208a048d
EZ
572011-09-09 Eli Zaretskii <eliz@gnu.org>
58
59 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
60
9b1c252e
MR
612011-09-08 Martin Rudalics <rudalics@gmx.at>
62
63 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
64 Operate on live windows only.
65
2949f33b
JB
662011-09-08 Juanma Barranquero <lekktu@gmail.com>
67
68 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
69
e08dcafd
EZ
702011-09-07 Eli Zaretskii <eliz@gnu.org>
71
72 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
73 only under bidi iteration.
74
115b96bd
JD
752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
76
77 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
78
c8199d0f
PE
792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
80
81 isnan: Fix porting problem to Solaris 10 with bundled gcc.
82 Without this fix, the command to link temacs failed due to an
83 undefined symbol __builtin_isnan. This is because
84 /usr/include/iso/math_c99.h #defines isnan(x) to
85 __builtin_isnan(x), but the bundled gcc, which identifies itself
86 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
87 a __builtin_isnan.
88 * floatfns.c (isnan): #undef, and then #define to a clone of
89 what's in data.c.
90 (Fisnan): Always define, since it's always available now.
91 (syms_of_floatfns): Always define isnan at the Lisp level.
92
e39b275c 932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
94
95 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
96
b2db44d9 972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 98
f4af5137 99 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
100 The previous code assumed that file offsets (off_t values) fit in
101 EMACS_INT variables, which is not true on typical 32-bit hosts.
102 The code messed up by falsely reporting buffer overflow in cases
103 such as (insert-file-contents "big" nil 1 2) into an empty buffer
104 when "big" contains more than 2**29 bytes, even though this
105 inserts just one byte and does not overflow the buffer.
106 (Finsert_file_contents): Store file offsets as off_t
107 values, not as EMACS_INT values. Check for overflow when
108 converting between EMACS_INT and off_t. When checking for
109 buffer overflow or for overlap, take the offsets into account.
110 Don't use EMACS_INT for small values where int suffices.
111 When checking for overlap, fix a typo: ZV was used where
112 ZV_BYTE was intended.
113 (Fwrite_region): Don't assume off_t fits into 'long'.
114 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
115
ecfc0a49
MA
1162011-09-05 Michael Albinus <michael.albinus@gmx.de>
117
118 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
119
6511acf2 1202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 121
0999621a 122 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
123
124 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 125 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
126 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
127 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
128 (modify_event_symbol): Do not assume that the length of
129 name_alist_or_stem is safe to alloca and fits in int.
130 (Fexecute_extended_command): Likewise for function name and binding.
131 (Frecursion_depth): Wrap around reliably on integer overflow.
132 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
133 since some callers pass EMACS_INT values.
134 (Fsingle_key_description): Don't crash if symbol name contains more
135 than MAX_ALLOCA bytes.
136 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
137 (get_minibuffer): Arg is now EMACS_INT, not int.
138 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 139 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
140 * window.h (command_loop_level, minibuf_level): Reflect API changes.
141
2be7d702
PE
142 * dbusbind.c (signature_cat): New function.
143 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
144 Do not overrun buffer; instead, report string overflow.
145
9d1df220
PE
146 * dispnew.c (add_window_display_history): Don't overrun buffer.
147 Truncate instead; this is OK since it's just a log.
148
33ef5c64
PE
149 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
150 even if the time zone offset is outlandishly large.
151 Don't mishandle offset == INT_MIN.
152
66c6fdd5
PE
153 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
154 when creating daemon; the previous buffer-overflow check was incorrect.
155
d749b01b
PE
156 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
157 which has the guts of the old verror function.
158
b5cd1905
PE
159 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
160 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
161
6e1a67fb
PE
162 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
163 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 164 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 165 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
166 length of string rather than counting it via multiple sprintfs;
167 that's simpler and more reliable.
c21721cc
PE
168 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
169 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
170 sprintf, in case result does not fit in int.
171
c57b67fc
PE
172 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
173 (fontset_from_font): Print it.
174
8a401434
PE
175 * frame.c (tty_frame_count): Now printmax_t, not int.
176 (make_terminal_frame, set_term_frame_name): Print it.
177 (x_report_frame_params): In X, window IDs are unsigned long,
178 not signed long, so print them as unsigned.
179 (validate_x_resource_name): Check for implausibly long names,
180 and don't assume name length fits in 'int'.
181 (x_get_resource_string): Don't blindly alloca invocation name;
182 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
183 not fit in int.
184
6e1a67fb
PE
185 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
186 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
187 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
188
0df02bf3
PE
189 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
190 Use esprintf, not sprintf, in case result does not fit in int.
191
48e30793
PE
192 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
193 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
194 it as a large positive number.
195 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
196 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
197
a66ff6d8
PE
198 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
199 in case result does not fit in int.
200
aca216ff
PE
201 * print.c (float_to_string): Detect width overflow more reliably.
202 (print_object): Make sprintf buffer a bit bigger, to avoid potential
203 buffer overrun. Don't assume list length fits in 'int'. Treat
204 print length of 0 as 0, not as infinity; to be consistent with other
205 uses of print length in this function. Don't overflow print length
206 index. Don't assume hash table size fits in 'long', or that
207 vectorlike size fits in 'unsigned long'.
208
31c286f7
PE
209 * process.c (make_process): Use printmax_t, not int, to format
210 process-name gensyms.
211
55e5faa1
PE
212 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
213
80f2e268
PE
214 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
215 to avoid potential buffer overrun.
216
670741ab
PE
217 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
218 if X resource line is longer than 512 bytes.
219
b7163a50
PE
220 * xfns.c (x_window): Make sprintf buffer a bit bigger
221 to avoid potential buffer overrun.
222
ae58ff1f
PE
223 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
224
c43c8a6a
PE
225 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
226
3f8236f4
PE
2272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
228
53e9fe90 229 Integer overflow fixes for scrolling, etc.
6511acf2
PE
230 Without these, Emacs silently mishandles large integers sometimes.
231 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
232 it were "C-u 1 M-x recenter" on a typical 64-bit host.
233
6511acf2
PE
234 * xdisp.c (try_window_id): Check Emacs fixnum range before
235 converting to 'int'.
806add1d 236
6511acf2 237 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
238 Check that an Emacs fixnum is in range before assigning it to 'int'.
239 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
240 values converted from Emacs fixnums.
241 (Frecenter): Don't wrap around a line count if it is out of 'int'
242 range; instead, treat it as an extreme value.
243 (Fset_window_configuration, compare_window_configurations):
244 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
245
6511acf2
PE
246 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
247 that can exceed INT_MAX. Check that EMACS_INT value is in range
248 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
249 (match_limit): Don't assume that a fixnum can fit in 'int'.
250
6511acf2 251 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
252 exceed INT_MAX.
253
6511acf2 254 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
255 (Fvertical_motion): Don't wrap around LINES values that don't fit
256 in 'int'. Instead, treat them as extreme values. This is good
257 enough for windows, which can't have more than INT_MAX lines anyway.
258
fcb901a7
LMI
2592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
260
0f2f6b6d
LMI
261 * Require libxml/parser.h to avoid compilation warning.
262
fcb901a7
LMI
263 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
264
265 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
266 since this reportedly can destroy thread storage.
267
6e20a0d4
CY
2682011-08-30 Chong Yidong <cyd@stupidchicken.com>
269
270 * syntax.c (find_defun_start): Update all cache variables if
271 exiting early (Bug#9401).
272
148ae00e
EZ
2732011-08-30 Eli Zaretskii <eliz@gnu.org>
274
f6cfbd8f
EZ
275 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
276
148ae00e
EZ
277 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
278 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
279 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
280
281 * term.c (tty_append_glyph): New function.
282 (produce_stretch_glyph): Static function and its prototype deleted.
283
284 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
285 prototypes.
286
c4a07a4c
PE
2872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
288
289 * image.c (parse_image_spec): Check for nonnegative, not for positive,
290 when checking :margin (Bug#9390).
291 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
292 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
293 so that the name doesn't mislead. All uses changed.
294
6bc8cd65
JB
2952011-08-28 Johan Bockgård <bojohan@gnu.org>
296
297 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
298 set_tty_hooks.
299
dca4927e
EZ
3002011-08-27 Eli Zaretskii <eliz@gnu.org>
301
302 * xdisp.c (move_it_to): Don't bail out early when reaching
303 position beyond to_charpos, if we are scanning backwards.
304 (move_it_vertically_backward): When DY == 0, make sure we get to
305 the first character in the line after the newline.
306
f2cad773
PE
3072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
308
309 * ccl.c: Improve and simplify overflow checking (Bug#9196).
310 (ccl_driver): Do not generate an out-of-range pointer.
311 (Fccl_execute_on_string): Remove unnecessary check for
312 integer overflow, noted by Stefan Monnier in
313 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
314 Remove a FIXME that didn't need fixing.
315 Simplify the newly-introduced buffer reallocation code.
316
0cae2cdb
JB
3172011-08-27 Juanma Barranquero <lekktu@gmail.com>
318
319 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
320
5fc295a4 3212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 322
70c60eb2 323 Integer and memory overflow issues (Bug#9196).
726e0ab1 324
d31850da
PE
325 * doc.c (get_doc_string): Rework so that
326 get_doc_string_buffer_size is the actual buffer size, rather than
327 being 1 less than the actual buffer size; this makes xpalloc more
328 convenient.
329
a69fbedb
PE
330 * image.c (x_allocate_bitmap_record, cache_image):
331 * xselect.c (Fx_register_dnd_atom):
332 Simplify previous changes by using xpalloc.
333
fe5c5d37
PE
334 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
335 since either will do and ptrdiff_t is convenient with xpalloc.
336
0065d054
PE
337 * charset.c (charset_table_size)
338 (struct charset_sort_data.priority): Now ptrdiff_t.
339 (charset_compare): Don't overflow if priorities differ greatly.
340 (Fsort_charsets): Don't assume list length fits in int.
341 Check for size-calculation overflow when allocating sort data.
342 (syms_of_charset): Allocate an initial charset table that is
343 just under 64 KiB, to avoid problems with glibc malloc and mmap.
344
345 * cmds.c (internal_self_insert): Check for size-calculation overflow.
346
347 * composite.h (struct composition.glyph_len): Now int, not unsigned.
348 The actual value is always <= INT_MAX, and leaving it unsigned made
349 overflow checking harder.
350
351 * dispextern.h (struct glyph_matrix.rows_allocated)
352 (struct face_cache.size): Now ptrdiff_t, for convenience in use
353 with xpalloc. The values are still always <= INT_MAX.
354
355 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
356
357 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
358 (SAFE_NALLOCA): New macro.
359
360 * region-cache.c (struct boundary.pos, find_cache_boundary)
361 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
362 (set_cache_region, invalidate_region_cache)
363 (revalidate_region_cache, know_region_cache, region_cache_forward)
364 (region_cache_backward, pp_cache):
365 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
366 so that ptrdiff_t * can be passed to xpalloc.
367 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
368 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
369 (pp_cache): Don't assume cache_len fits in int.
370 * region-cache.h: Adjust extern decls to match.
371
372 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
373 EMACS_INT, since either will do, for xpalloc.
374
375 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
376 (xnmalloc, xnrealloc, xpalloc): New functions.
377
726e0ab1
PE
378 * bidi.c (bidi_shelve_header_size): New constant.
379 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
380 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
381
51f30bc5 382 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
383 * buffer.c (overlays_at, overlays_in, record_overlay_string)
384 (overlay_strings):
385 Don't update size of array until after memory allocation succeeds,
386 because xmalloc/xrealloc may not return.
0065d054
PE
387 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
388 now that we have proper integer overflow checking.
389 (record_overlay_string, overlay_strings): Catch overflows when
390 calculating size of overlay_str_buf.
726e0ab1 391
0065d054
PE
392 * callproc.c (Fcall_process): Check for size overflow when
393 calculating size of args2.
394 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
395 Normally we prefer signed values, but sticking with ptrdiff_t would
396 require adding more-complicated checks.
726e0ab1
PE
397
398 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
399 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
400 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 401 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
402
403 * character.c (Fstring): Check for size-calculation overflow.
404
405 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
406 unnecessary integer overflow. Check for size overflow.
407 (encode_coding_object): Don't update size until xmalloc succeeds.
408
409 * composite.c (get_composition_id): Check for overflow in glyph
410 length calculations.
411
412 Integer and memory overflow fixes for display code.
413 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
414 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
415 (scrolling_window): Check for overflow in size calculations.
416 (line_draw_cost, realloc_glyph_pool, add_row_entry):
417 Don't assume glyph table len fits in int.
418 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
419 (row_table_size): Now ptrdiff_t, not int.
420 (scrolling_window): Avoid overflow in size calculations.
421 Don't update size until allocation succeeds.
422 * fns.c (concat): Check for overflow in size calculations.
423 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
424 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
425 (NEXT_ALMOST_PRIME_LIMIT): New constant.
426
427 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
428 (get_doc_string): Check for size calculation overflow.
429 Don't update size until allocation succeeds.
430 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
431 EMACS_INT, where ptrdiff_t will do.
432 (Fsubstitute_command_keys): Check for string overflow.
433
434 * editfns.c (set_time_zone_rule): Don't assume environment length
435 fits in int.
436 (message_length): Now ptrdiff_t, not int.
437 (Fmessage_box): Don't update size until allocation succeeds.
438 Don't assume message length fits in int.
439 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
440
0065d054
PE
441 * emacs.c (main): Do not reallocate argv, since there is a null at
442 the end that can be overwritten, and this way there's no need to
443 worry about size-calculation overflow.
444 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
445
446 * eval.c (init_eval_once, grow_specpdl): Don't update size until
447 alloc succeeds.
448 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
449
450 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
451 (x_set_scroll_bar_width, x_figure_window_size):
452 Check for integer overflow.
453 (x_set_alpha): Do not assume XINT fits in int.
454
455 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
456 This is for the members text_lines, text_cols, total_lines, total_cols,
457 where the system imposes an 'int' limit.
458
459 * fringe.c (Fdefine_fringe_bitmap):
460 Don't update size until alloc works.
461
462 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
463 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
464
465 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
466 Check for size-calculation overflow.
467 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
468 do, as we prefer signed integers.
469 (id_to_widget.max_size, id_to_widget.used)
470 (xg_store_widget_in_map, xg_remove_widget_from_map)
471 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
472 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
473 Use and return ptrdiff_t, not int.
474 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
475 * gtkutil.h: Change prototypes to match the above.
476
477 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
478 are duplicate now that they've been promoted to lisp.h.
479 (x_allocate_bitmap_record, x_alloc_image_color)
480 (make_image_cache, cache_image, xpm_load):
481 Don't update size until alloc is done.
482 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
483 (x_detect_edges):
3256efce 484 Check for size calculation overflow.
726e0ab1
PE
485 (ct_colors_allocated_max): New constant.
486 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
487 overflow.
3256efce 488
726e0ab1
PE
489 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
490 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
491 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
492 Use ptrdiff_t, not int, to count maps.
493 (read_char_minibuf_menu_prompt): Check for overflow in size
494 calculations. Don't update size until allocation succeeds. Redo
495 calculations to avoid overflow.
496 * keyboard.h: Change prototypes to match the above.
497
498 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
499 to count maps.
500 (current_minor_maps): Check for size calculation overflow.
501 * keymap.h: Change prototypes to match the above.
502
503 * lread.c (read1, init_obarray): Don't update size until alloc done.
504
505 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
506 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
507
726e0ab1
PE
508 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
509 Now ptrdiff_t, not int.
510 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
511 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
512
513 * process.c (Fnetwork_interface_list): Check for overflow
514 in size calculation.
515
516 * region-cache.c (move_cache_gap): Check for size calculation overflow.
517
518 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
519 overflow. Don't bother calling xmalloc when xrealloc will do.
520
521 * search.c (Freplace_match): Check for size calculation overflow.
522 (Fset_match_data): Don't assume list lengths fit in 'int'.
523
524 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
525 for command line length. Do not attempt to address one before the
526 beginning of an array, as that's not portable.
527
528 * term.c (max_frame_lines): Remove; unused.
529 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
530 not int.
531 (encode_terminal_code, calculate_costs): Check for size
532 calculation overflow.
533 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
534 table lengths and related sizes. Don't update size until alloc
535 done. Redo calculations to avoid overflow.
536 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
537
538 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
539 subtracting pointers.
540 (gobble_line): Check for overflow more carefully. Don't update size
541 until alloc done.
542
543 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
544 Don't update size until alloc done.
545 Redo size calculations to avoid overflow.
546 Check for size calculation overflow.
0065d054 547 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
548
549 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
550 Use ptrdiff_t, not int, for sizes.
551 (store_mode_line_noprop_char): Don't update size until alloc done.
552
0065d054
PE
553 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
554 Use ptrdiff_t, not int, for sizes.
555 (Finternal_make_lisp_face, cache_face):
556 Check for size calculation overflow.
557 (cache_face): Treat size calculation overflows as if they were
558 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
559
560 * xfns.c (x_encode_text, x_set_name_internal)
561 (Fx_change_window_property): Use ptrdiff_t, not int, to count
562 sizes, since they can exceed INT_MAX in size. Check for size
563 calculation overflow.
564
0065d054
PE
565 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
566 (xg_select): Check for size calculation overflow.
726e0ab1
PE
567 Don't update size until alloc done.
568
0065d054 569 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 570 as sprintf is limited to int lengths.
1d526e2f 571
252c5ee1
PE
572 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
573 (X_LONG_MIN): New macros.
864d7ce7
PE
574 Use them to make the following changes clearer.
575 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
576 This change doesn't affect the value now, but it may help remind
577 future maintainers not to raise the value too much later.
578 (SELECTION_QUANTUM): Remove, replacing with ...
579 (selection_quantum): ... new function, which avoids overflow.
580 All uses changed.
581 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
582 assumption that selection length fits in 'int'.
583 (x_reply_selection_request, x_handle_selection_request)
584 (x_get_window_property, receive_incremental_selection)
585 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
586 (lisp_data_to_selection_data, clean_local_selection_data):
587 Use ptrdiff_t, not int, to record length of selection.
588 (x_reply_selection_request, x_get_window_property)
589 (receive_incremental_selection, x_property_data_to_lisp):
590 Redo calculations to avoid overflow.
591 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 592 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
593 something.
594 (x_get_window_property, receive_incremental_selection)
595 (lisp_data_to_selection_data, x_property_data_to_lisp):
596 Check for size-calculation overflow.
597 (x_get_window_property, receive_incremental_selection)
598 (lisp_data_to_selection_data, Fx_register_dnd_atom):
599 Don't store size until memory allocation succeeds.
600 (x_get_window_property): Plug memory leak on memory exhaustion.
601 Don't double-block input; malloc is safe here. Don't assume 2**34
602 - 4 fits in unsigned long. Add an xassert to check
603 XGetWindowProperty overflow. Be more careful about overflow
604 calculations, and distinguish size from memory overflow better.
605 (receive_incremental_selection): When tracing, don't assume
606 unsigned int is less than INT_MAX.
607 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
608 harmful) conversions of unsigned short to int.
609 (lisp_data_to_selection_data): Don't assume that integers
610 in the range -65535 through -1 fit in an X unsigned short.
611 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
612 result parameters unless successful. Rely on cons_to_unsigned
613 to report problems with elements; the old code wasn't right anyway.
614 (x_check_property_data): Check for int overflow; we cannot use
615 a wider type due to X limits.
616 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
617
726e0ab1 618 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 619
0065d054
PE
620 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
621 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
622 (x_color_cells): Don't store size until memory allocation succeeds.
623 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 624 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
625 (x_term_init): Don't assume length fits in int (sprintf is limited
626 to int size).
bc18e09d 627
ebfa62c0
PE
628 Use ptrdiff_t for composition IDs.
629 * character.c (lisp_string_width):
630 * composite.c (composition_table_size, n_compositions)
631 (get_composition_id, composition_gstring_from_id):
632 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
633 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
634 * window.c (Frecenter):
635 Use ptrdiff_t, not int, for composition IDs.
636 * composite.c (get_composition_id): Check for integer overflow.
637 * composite.h: Adjust prototypes to match the above changes.
638
d3411f89
PE
639 Use ptrdiff_t for hash table indexes.
640 * category.c (hash_get_category_set):
641 * ccl.c (ccl_driver):
642 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
643 * coding.c (coding_system_charset_list, detect_coding_system):
644 * coding.h (struct coding_system.id):
645 * composite.c (get_composition_id, gstring_lookup_cache):
646 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
647 * image.c (xpm_get_color_table_h):
648 * lisp.h (hash_lookup, hash_put):
649 * minibuf.c (Ftest_completion):
650 Use ptrdiff_t for hash table indexes, not int (which is too
651 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
652 32-bit --with-wide-int hosts).
653
e097a6fa
PE
654 * charset.c (Fdefine_charset_internal): Check for integer overflow.
655 Add a FIXME comment about memory leaks.
656 (syms_of_charset): Don't assume xmalloc returns.
657
5637687f
PE
658 Don't assume that stated character widths fit in int.
659 * character.c (Fchar_width, c_string_width, lisp_string_width):
660 * character.h (CHAR_WIDTH):
661 * indent.c (MULTIBYTE_BYTES_WIDTH):
662 Use sanitize_char_width to avoid undefined and/or bad behavior
663 with outlandish widths.
664 * character.h (sanitize_tab_width): Renamed from sanitize_width,
665 now that we have two such functions. All uses changed.
666 (sanitize_char_width): New inline function.
667
a2271ba2
PE
668 Don't assume that tab-width fits in int.
669 * character.h (sanitize_width): New inline function.
670 (SANE_TAB_WIDTH): New macro.
671 (ASCII_CHAR_WIDTH): Use it.
672 * indent.c (sane_tab_width): Remove. All uses replaced by
673 SANE_TAB_WIDTH (current_buffer).
674 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
675
18c52557
PE
676 * fileio.c: Integer overflow issues with file modes.
677 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
678
caeeedc1
PE
679 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
680 Remove unreachable code.
681 (read_hex, load_charset_map_from_file): Check for integer overflow.
682
50849c52
PE
683 * xterm.c: don't go over XClientMessageEvent limit
684 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
685 (x_send_scroll_bar_event): Likewise. Check that the size does not
686 exceed limits imposed by XClientMessageEvent, as well as the usual
687 ptrdiff_t and size_t limits.
688
b13995db
PE
689 * keyboard.c: Overflow, signedness and related fixes.
690 (make_lispy_movement): Use same integer type in forward decl
691 that is used in the definition.
692 (read_key_sequence, keyremap_step):
693 Change bufsize argument back to int, undoing my 2011-03-30 change.
694 We prefer signed types, and int is wide enough here.
695 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
696 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
697 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
698 length, not size_t. Use ptrdiff_t for index, not int.
699 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
700 possibility of integer overflow.
701
13464394
PE
702 Overflow, signedness and related fixes for images.
703
704 * dispextern.h (struct it.stack[0].u.image.image_id)
705 (struct_it.image_id, struct image.id, struct image_cache.size)
706 (struct image_cache.used, struct image_cache.ref_count):
707 * gtkutil.c (update_frame_tool_bar):
708 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
709 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
710 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
711 * nsmenu.m (update_frame_tool_bar):
712 * xdisp.c (calc_pixel_width_or_height):
713 * xfns.c (image_cache_refcount):
714 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
715 on typical 64-bit hosts.
716
717 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
718 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
719 Omit unnecessary casts to int.
720 (parse_image_spec): Check that integers fall into 'int' range
721 when the callers expect that.
722 (image_ascent): Redo ascent calculation to avoid int overflow.
723 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
724 (lookup_image): Remove unnecessary tests.
725 (xbm_image_p): Locals are now of int, not EMACS_INT,
726 since parse_image_check makes sure they fit into int.
727 (png_load, gif_load, svg_load_image):
728 Prefer int to unsigned where either will do.
729 (tiff_handler): New function, combining the cores of the
730 old tiff_error_handler and tiff_warning_handler. This
731 function is rewritten to use vsnprintf and thereby avoid
732 stack buffer overflows. It uses only the features of vsnprintf
733 that are common to both POSIX and native Microsoft.
734 (tiff_error_handler, tiff_warning_handler): Use it.
735 (tiff_load, gif_load, imagemagick_load_image):
736 Don't assume :index value fits in 'int'.
737 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
738 (imagemagick_load_image): Check that crop parameters fit into
739 the integer types that MagickCropImage accepts. Don't assume
740 Vimagemagick_render_type has a nonnegative value. Don't assume
741 size_t fits in 'long'.
742 (gs_load): Use printmax_t to print the widest integers possible.
743 Check for integer overflow when computing image height and width.
744
c11821d4
EZ
7452011-08-26 Eli Zaretskii <eliz@gnu.org>
746
747 * xdisp.c (redisplay_window): Don't force window start if point
748 will be invisible in the resulting window. (Bug#9324)
749
0c95fcf7
EZ
7502011-08-25 Eli Zaretskii <eliz@gnu.org>
751
752 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
753 the display spec is of the form `(space ...)'.
754 (handle_display_spec): Return the value returned by
755 handle_single_display_spec, not just 1 or zero.
756 (handle_single_display_spec): If the display spec is of the form
757 `(space ...)', and specifies display in the text area, return 2
758 rather than 1.
fee65a97 759 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
760 accurately, and prefer exact match for point under bidi. Don't
761 advance `row' beyond the last row of the window.
0c95fcf7
EZ
762
763 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
764 into disp_prop; all users changed.
765
766 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
767 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
768 for the text covered by the display property.
769
e4ed06f1
CY
7702011-08-25 Chong Yidong <cyd@stupidchicken.com>
771
772 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
773 Change return value to nil.
774 (Frecord_buffer): Delete unused function.
775
f67cdd7f
EZ
7762011-08-24 Eli Zaretskii <eliz@gnu.org>
777
5980d4c6
EZ
778 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
779 buffers, return left-to-right.
8610fe8b
EZ
780 (set_cursor_from_row): Consider candidate row a win if its glyph
781 represents a newline and point is on that newline. Fixes cursor
782 positioning on the newline at EOL of R2L text within L2R
783 paragraph, and vice versa.
784 (try_cursor_movement): Check continued rows, in addition to
785 continuation rows. Fixes unwarranted scroll when point enters a
786 continued line of R2L text within an L2R paragraph, or vice versa.
787 (cursor_row_p): Consider the case of point being equal to
788 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
789 from the end of a short line to the beginning of a continued line
790 of R2L text within L2R paragraph.
791 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
792 composed characters.
5980d4c6 793
f67cdd7f
EZ
794 * bidi.c (bidi_check_type): Use xassert.
795 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
796 members.
797
bca633fb
EZ
7982011-08-23 Eli Zaretskii <eliz@gnu.org>
799
800 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
801 a character.
802
4a5885a7
CY
8032011-08-23 Chong Yidong <cyd@stupidchicken.com>
804
805 * nsfont.m (ns_otf_to_script): Fix typo.
806
0902a04e
KH
8072011-08-22 Kenichi Handa <handa@m17n.org>
808
809 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
810 extra slot even if the purpose is char-code-property-table.
811
1a2e6670
EZ
8122011-08-23 Eli Zaretskii <eliz@gnu.org>
813
8ddde651
EZ
814 * xdisp.c (redisplay_window): When computing centering_position,
815 account for the height of the header line. (Bug#8874)
816
425cc014
EZ
817 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
818 instead of CHAR_TO_BYTE. Fixes a crash when a completion
819 candidate is selected by the mouse, and that candidate has a
820 composed character under the mouse.
821
1a2e6670
EZ
822 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
823 coordinates reported by pos-visible-in-window-p for a composed
824 character in column zero.
825
8b76d6f8
SM
8262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
827
828 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
829
dac347dd
EZ
8302011-08-22 Eli Zaretskii <eliz@gnu.org>
831
832 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
833 consider it a hit if to_charpos is anywhere in the range of the
834 composed buffer positions.
835
e013fb34
CY
8362011-08-22 Chong Yidong <cyd@stupidchicken.com>
837
838 * image.c (gif_load): Don't assume that each subimage has the same
839 dimensions as the base image. Handle disposal method that is
840 "undefined" by the gif spec (Bug#9335).
841
bd1ba3e8
CY
8422011-08-20 Chong Yidong <cyd@stupidchicken.com>
843
844 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 845 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 846
54a1215b
EZ
8472011-08-19 Eli Zaretskii <eliz@gnu.org>
848
823564e5
EZ
849 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
850 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
851 from an Org mode buffer to a Speedbar frame.
852
54a1215b
EZ
853 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
854 a composition, take its buffer position from IT->cmp_it.charpos.
855 Fixes cursor positioning at the beginning of a line that begins
856 with a composed character.
857
9778ebcc
EZ
8582011-08-18 Eli Zaretskii <eliz@gnu.org>
859
0be6ee06
EZ
860 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
861 character bidirectional type, use STRONG_L instead. Fixes crashes
862 in a buffer produced by `describe-categories'.
863
9778ebcc
EZ
864 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
865 members before the level stack, so they would be saved and
866 restored when copying iterator state. Fixes incorrect reordering
867 around TABs covered by display properties.
868
156bffbe
AS
8692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
870
871 * process.c (Fnetwork_interface_list): Correctly determine buffer
872 size.
873
72ad093b
CY
8742011-08-17 Chong Yidong <cyd@stupidchicken.com>
875
876 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
877 (internal_condition_case_2, internal_condition_case_n):
878 Remove unnecessary aborts (Bug#9081).
72ad093b 879
35774242
EZ
8802011-08-17 Eli Zaretskii <eliz@gnu.org>
881
882 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
883 has no `load' handler, try opening the file locally. (Bug#9311)
884
db76dd85
KB
8852011-08-16 Ken Brown <kbrown@cornell.edu>
886
887 * gmalloc.c: Expand comment.
888
b215eee5
EZ
8892011-08-16 Eli Zaretskii <eliz@gnu.org>
890
891 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
892 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
893
a4579d33
KB
8942011-08-16 Ken Brown <kbrown@cornell.edu>
895
896 Fix memory allocation problems in Cygwin build (Bug#9273).
897
898 * unexcw.c ( __malloc_initialized): Declare external variable.
899 (fixup_executable): Force the dumped emacs to reinitialize malloc.
900
8b76d6f8
SM
901 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
902 New variables.
a4579d33
KB
903 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
904 dumped emacs.
905 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
906 in the static heap.
907 [CYGWIN] (special_realloc): New function.
908 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
909 requests to realloc storage in the static heap.
910
3ebec551
PE
9112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
912
913 * bidi.c (bidi_initialize): Remove unused local.
914
9fd8be00
EZ
9152011-08-15 Eli Zaretskii <eliz@gnu.org>
916
474a8465
EZ
917 * biditype.h: File removed.
918
919 * bidimirror.h: File removed.
920
921 * deps.mk (bidi.o): Remove biditype.h and
922 bidimirror.h.
923
924 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
925 bidimirror.h.
926
927 * dispextern.h: Fix a typo in the comment to bidi_type_t.
928
929 * chartab.c: Improve commentary for the uniprop_table API.
930
32413314
EZ
931 * bidi.c (bidi_paragraph_init): Support zero value of
932 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
933 (bidi_initialize): Use uniprop_table instead of including
934 biditype.h and bidimirror.h.
32413314 935
9fd8be00
EZ
936 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
937 coordinates of the iterator when restoring from ppos_it.
938 (Bug#9296)
939
5cf2b69b
KH
9402011-08-14 Kenichi Handa <handa@m17n.org>
941
942 * process.c (create_process): Call setup_process_coding_systems
72ad093b 943 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 944
daf17d00
EZ
9452011-08-14 Eli Zaretskii <eliz@gnu.org>
946
947 * xdisp.c (move_it_in_display_line_to): Don't invoke
948 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
949 ppos_it. Fixes vertical cursor motion when line beginning is
950 covered by an image. (Bug#9296)
951
08e3161a
JD
9522011-08-14 Jan Djärv <jan.h.d@swipnet.se>
953
954 * nsterm.h (ns_run_ascript): Declare.
955 (NSAPP_DATA2_RUNASSCRIPT): Define.
956
957 * nsfns.m (as_script, as_result, as_status): New static variables.
958 (ns_run_ascript): New function.
5e617bc2 959 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
960 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
961 the event loop. Get status from as_status (Bug#7276).
962
963 * nsterm.m (sendEvent): If event is NSApplicationDefined and
964 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
965 the event loop (Bug#7276).
966
a3720aa2
AS
9672011-08-14 Andreas Schwab <schwab@linux-m68k.org>
968
969 * gnutls.c (QCgnutls_bootprop_priority)
970 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
971 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
972 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
973 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
974 (QCgnutls_bootprop_verify_hostname_error)
975 (QCgnutls_bootprop_callbacks_verify): Rename from
976 Qgnutls_bootprop_..., all uses changed.
977
978 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
979 uses changed.
980
0a0d27fb
PE
9812011-08-14 Paul Eggert <eggert@cs.ucla.edu>
982
19d5c50c
PE
983 * xfaces.c (Qframe_set_background_mode): Now static.
984 * dispextern.h (Qframe_set_background_mode): Remove decl.
985
0a0d27fb
PE
986 * process.c (Fnetwork_interface_info): Declare local only if needed.
987
377538cb
JD
9882011-08-13 Jan Djärv <jan.h.d@swipnet.se>
989
990 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
991 (Fnetwork_interface_list): Allocate in increments of bytes instead
992 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
993 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
994 sockaddr.
995 (struct ifflag_def): notrailers is smart on OSX.
996 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
997 Get hardware address with getifaddrs if available.
998
08fff70c
EZ
9992011-08-12 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (iterate_out_of_display_property): xassert that
1002 IT->position is set to within IT->object's boundaries. Break from
1003 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1004 when IT->position is set up wrongly due to some bug.
1005 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1006 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1007 entry. Force push_it to save on the stack the current
1008 buffer/string position, to be restored by pop_it. Fix flags in
1009 the iterator structure wrt the object coming from a display
1010 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1011 properties. (Bug#9284)
1012
7be1c708 10132011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1014
7be1c708
CY
1015 * fontset.c (fontset_get_font_group): Add proper type checks.
1016 (Bug#9172)
aac0c6e3 1017
7be1c708 10182011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1019
7be1c708
CY
1020 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1021 and LC_VERSION_MIN_MACOSX.
1022 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1023 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1024
97bb72a6
EZ
10252011-08-08 Eli Zaretskii <eliz@gnu.org>
1026
1027 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1028 no-display-properties-and-no-overlays under bidi display.
1029 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1030 properties and overlays.
97bb72a6 1031
d5617611
CY
10322011-08-08 Chong Yidong <cyd@stupidchicken.com>
1033
37e11a63
CY
1034 * editfns.c (Fset_time_zone_rule): Document relationship with the
1035 setenv function.
1036
d5617611
CY
1037 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1038 the font entity extracted from the cache (Bug#8109).
1039
58872834
CY
10402011-08-07 Chong Yidong <cyd@stupidchicken.com>
1041
1042 * composite.c (autocmp_chars): Don't reset point. That is done by
1043 restore_point_unwind (Bug#5984).
1044
75bfc667
JL
10452011-08-07 Juri Linkov <juri@jurta.org>
1046
1047 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1048 to show the arg `TIME' instead of `TIMEVAL'.
1049
d1410150
EZ
10502011-08-06 Eli Zaretskii <eliz@gnu.org>
1051
1052 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1053 display property strides EOL and includes a newline, as in
1054 longlines-mode. (Bug#9254)
75b771e4
EZ
1055 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1056 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1057
1058 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1059 is non-zero, even if the data buffer is NULL. Fixes a crash in
1060 vertical-motion with longlines-mode. (Bug#9254)
1061
35928349
EZ
10622011-08-05 Eli Zaretskii <eliz@gnu.org>
1063
ec7cc85b
EZ
1064 * bidi.c <bidi_cache_total_alloc>: Now static.
1065 (bidi_initialize): Initialize bidi_cache_total_alloc.
1066
8b76d6f8 1067 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1068 cache. (Bug#9221)
1069
1070 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1071 amount allocated this far in `bidi_cache_total_alloc'.
1072 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1073 non-zero, only free the data buffer without restoring the cache
1074 contents. All callers changed.
1075
1076 * dispextern.h (bidi_unshelve_cache): Update prototype.
1077
1078 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1079 (move_it_in_display_line, move_it_to)
1080 (move_it_vertically_backward, move_it_by_lines): Replace the call
1081 to xfree to an equivalent call to bidi_unshelve_cache.
1082 (move_it_in_display_line_to): Fix logic of returning
412b6358 1083 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1084
e2e2423b
EZ
10852011-08-05 Eli Zaretskii <eliz@gnu.org>
1086
1087 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1088 came from a string character with a `cursor' property. (Bug#9229)
1089
ae9e757a
JD
10902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1091
1092 * Makefile.in (LIB_PTHREAD): New variable.
1093 (LIBES): Add LIB_PTHREAD (Bug#9216).
1094
1095 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1096 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1097
213bd7f2
AS
10982011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1099
1100 * regex.c (re_iswctype): Remove some redundant boolean
1101 conversions.
1102
99aaf75f
JD
11032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1104
1105 * xterm.c (x_find_topmost_parent): New function.
1106 (x_set_frame_alpha): Find topmost parent window with
1107 x_find_topmost_parent and set the property there also (bug#9181).
1108 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1109
c74e9d86
PE
11102011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1111
1112 * callproc.c (Fcall_process): Avoid vfork clobbering
1113 the local vars buffer, coding_systems, current_dir.
1114
640c8776
SM
11152011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1118
f26d0e4c
PE
11192011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1120
8a10d76c
PE
1121 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1122 so that it is not optimized away.
1123
f26d0e4c
PE
1124 * xdisp.c (compute_display_string_pos): Remove unused local.
1125
55439c61
EZ
11262011-08-02 Eli Zaretskii <eliz@gnu.org>
1127
1128 Fix slow cursor motion and scrolling in large buffers with
1129 selective display, like Org Mode buffers. (Bug#9218)
1130
1131 * dispextern.h (struct bidi_it): New member disp_prop_p.
1132
1133 * xdisp.c: Remove one-slot cache of display string positions.
1134 (compute_display_string_pos): Accept an additional argument
5e617bc2 1135 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1136 for a display string or property. If found, set DISP_PROP_P
1137 non-zero.
1138
1139 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1140 DISP_PROP_P, and pass it to compute_display_string_pos.
1141 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1142 non-zero. All callers of bidi_fetch_char changed.
1143
fb33fa43
SM
11442011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1145
1146 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1147
b099e063
DM
11482010-12-03 Don March <don@ohspite.net>
1149
1150 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1151 last character M-[char] is translated to ESC [char] (bug#7541).
1152
5cc7f7af
KH
11532011-08-02 Kenichi Handa <handa@m17n.org>
1154
d0fffa3f 1155 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1156
1157 * chartab.c (uniprop_table): Make it non-static.
1158
525d5e6e
EZ
11592011-08-01 Eli Zaretskii <eliz@gnu.org>
1160
1161 * xdisp.c (forward_to_next_line_start): Accept additional argument
1162 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1163 on the newline.
1164 (reseat_at_next_visible_line_start): Use the bidi iterator state
1165 returned by forward_to_next_line_start to restore the state of
1166 it->bidi_it after backing up to previous newline. (Bug#9212)
1167
31011111
AS
11682011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1169
1170 * regex.c (re_comp): Protoize.
1171 (re_exec): Fix return type.
1172 (regexec): Fix type of `ret'. (Bug#9203)
1173
476371c4
PE
11742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1175
e5d76069
PE
1176 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1177 This is needed if max-image-size is a floating-point number.
1178
9a79b20c
AS
11792011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1180
1181 * print.c (print_object): Print empty symbol as ##.
1182
1183 * lread.c (read1): Read ## as empty symbol.
1184
d8c2fa78
AA
11852011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1186
1187 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1188 setting frame foreground color (Bug#9175).
1189 (x_set_background_color): Likewise.
1190
ffe57a7a
AA
1191 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1192 contents (Bug#9176).
1193 (EmacsTooltip -init): Remove bezels and add shadows to
1194 tooltip windows.
1195
bf3492a5
AA
1196 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1197 or scroll bar (Bug#8470).
1198
d55e9c53
AA
1199 * nsfont.m (nsfont_open): Remove assignment to voffset and
1200 unnecessary vars hshink, expand, hd, full_height, min_height.
1201 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1202
1203 * nsterm.h (nsfont_info): Remove voffset field.
1204
d8c2fa78 12052011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1206
1207 Implement strike-through and overline on NextStep (Bug#8863).
1208
1209 * nsfont.m (nsfont_open): Use underline position provided by font,
1210 instead of hard-coded value of 2.
1211 (nsfont_draw): Call ns_draw_text_decoration instead.
1212
1213 * nsterm.h: Add declaration for ns_draw_text_decoration.
1214
1215 * nsterm.m (ns_draw_text_decoration): New function for drawing
1216 underline, overline, and strike-through.
1217 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1218 ns_draw_text_decoration. Change treatment of cursor drawing to
1219 accomodate underlining, etc.
1220
4cc60b9b
EZ
12212011-07-28 Eli Zaretskii <eliz@gnu.org>
1222
bc7ece87
EZ
1223 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1224 default.
4cc60b9b 1225
476371c4
PE
12262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1227
66606eea
PE
1228 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1229 Without this fix, if a signal arrives just after memory fills up,
1230 'malloc' might be invoked reentrantly.
1231
476371c4
PE
1232 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1233 In other words, assume that every image size is allowed, on non-X
1234 hosts. This assumption is probably wrong, but it lets Emacs compile.
1235
f3fcc40d
AS
12362011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1237
1238 * regex.c (re_iswctype): Convert return values to boolean.
1239
350c992f
EZ
12402011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1241
1242 * xdisp.c (compute_display_string_pos): Don't use cached display
1243 string position if the buffer had its restriction changed.
1244 (Bug#9184)
1245
5266b4bb
PE
12462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1249
2573a837 12502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1251
41f55ccd 1252 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1253
39e378da
PE
1254 * bidi.c: Integer size and overflow fixes.
1255 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1256 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1257 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1258 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1259 (bidi_find_other_level_edge):
1260 Use ptrdiff_t instead of EMACS_INT where either will do.
1261 This works better on 32-bit hosts configured --with-wide-int.
1262 (bidi_cache_ensure_space): Check for size-calculation overflow.
1263 Use % rather than repeated addition, for better worst-case speed.
1264 Don't set bidi_cache_size until after xrealloc returns, because it
1265 might not return.
1266 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1267 (bidi_cache_ensure_space): Also check that the bidi cache size
1268 does not exceed that of the largest Lisp string or buffer. See Eli
1269 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1270
5e927815
PE
1271 * alloc.c (__malloc_size_t): Remove.
1272 All uses replaced by size_t. See Andreas Schwab's note
1273 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1274
ca4aa935
PE
1275 * image.c: Improve checking for integer overflow.
1276 (check_image_size): Assume that f is nonnull, since
1277 it is always nonnull in practice. This is one less thing to
1278 worry about when checking for integer overflow later.
1279 (x_check_image_size): New function, which checks for integer
1280 overflow issues inside X.
1281 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1282 This removes the need for a memory_full check.
1283 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1284 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1285 (xbm_read_bitmap_data): Change locals back to 'int', since
1286 their values must fit in 'int'.
1287 (xpm_load_image, png_load, tiff_load):
1288 Invoke x_create_x_image_and_pixmap earlier,
1289 to avoid much needless work if the image is too large.
1290 (tiff_load): Treat overly large images as if
1291 x_create_x_image_and_pixmap failed, not as malloc failures.
1292 (gs_load): Use x_check_image_size.
1293
5f8f9cc2
PE
1294 * gtkutil.c: Omit integer casts.
1295 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1296 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1297
5adf60bc
PE
1298 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1299
c8907a93
PE
1300 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1301 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1302 would wrongly return t on a 64-bit host.
1303
e3c25c68
PE
1304 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1305 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1306 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1307 and therefore cause GCC to emit a bogus diagnostic in some cases.
1308
3f791afe
PE
1309 * image.c: Integer signedness and overflow and related fixes.
1310 This is not an exhaustive set of fixes, but it's time to
1311 record what I've got.
1312 (lookup_pixel_color, check_image_size): Remove redundant decls.
1313 (check_image_size): Don't assume that arbitrary EMACS_INT values
1314 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1315 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1316 (tiff_load, imagemagick_load_image):
1317 Check for overflow in size calculations.
1318 (x_create_x_image_and_pixmap): Remove unnecessary test for
1319 xmalloc returning NULL; that can't happen.
1320 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1321 (xpm_color_bucket): Use better integer hashing function.
1322 (xpm_cache_color): Don't possibly over-allocate memory.
1323 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1324 (gif_memory_source):
1325 Use ptrdiff_t, not int or size_t, to record sizes.
1326 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1327 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1328 either works, as we prefer signed integers.
1329 (tiff_read_from_memory, tiff_write_from_memory):
1330 Return tsize_t, not size_t, since that's what the TIFF API wants.
1331 (tiff_read_from_memory): Don't fail simply because the read would
1332 go past EOF; instead, return a short read.
1333 (tiff_load): Omit no-longer-needed casts.
1334 (Fimagemagick_types): Don't assume size fits into 'int'.
1335
3cc5a532
PE
1336 Improve hashing quality when configured --with-wide-int.
1337 * fns.c (hash_string): New function, taken from sxhash_string.
1338 Do not discard information about ASCII character case; this
1339 discarding is no longer needed.
1340 (sxhash-string): Use it. Change sig to match it. Caller changed.
1341 * lisp.h: Declare it.
1342 * lread.c (hash_string): Remove, since we now use fns.c's version.
1343 The fns.c version returns a wider integer if --with-wide-int is
1344 specified, so this should help the quality of the hashing a bit.
1345
b312a492
PE
1346 * emacs.c: Integer overflow minor fix.
1347 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1348 Define only if GNU_LINUX.
1349 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1350
dfd153ae
PE
1351 * dispnew.c: Integer signedness and overflow fixes.
1352 Remove unnecessary forward decls, that were a maintenance hassle.
1353 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1354 All uses changed.
1355 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1356 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1357 (prepare_desired_row, line_draw_cost):
1358 Use int, not unsigned, where either works.
1359 (save_current_matrix, restore_current_matrix):
1360 Use ptrdiff_t, not size_t, where either works.
1361 (init_display): Check for overflow more accurately, and without
1362 relying on undefined behavior.
1363
a81d11a3
PE
1364 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1365 Remove, replacing with the new symbols in lisp.h. All uses changed.
1366 * fileio.c (make_temp_name):
1367 * filelock.c (lock_file_1, lock_file):
1368 * xdisp.c (message_dolog):
1369 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1370 Use pMd etc. instead.
1371 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1372 replacing the pWIDE etc. symbols removed from editfns.c.
1373
3300e6fd
PE
1374 * keyboard.h (num_input_events): Now uintmax_t.
1375 This is (very slightly) less likely to mess up due to wraparound.
1376 All uses changed.
1377
fd05c7e9
PE
1378 * buffer.c: Integer signedness fixes.
1379 (alloc_buffer_text, enlarge_buffer_text):
1380 Use ptrdiff_t rather than size_t when either will do, as we prefer
1381 signed integers.
1382
903fe15d
PE
1383 * alloc.c: Integer signedness and overflow fixes.
1384 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1385 (__malloc_size_t): Default to size_t, not to int.
1386 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1387 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1388 Prefer ptrdiff_t to size_t when either would do, as we prefer
1389 signed integers.
1390 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1391 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1392 Now const. Initialize with values that are in range even if char
1393 is signed.
1394 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1395 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1396 These functions do the right thing with sizes > 2**32.
1397 (check_depth): Now ptrdiff_t, not int.
1398 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1399 Adjust to new way of storing sizes. Check for size overflow bugs
1400 in rest of code.
1401 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1402 slightly wrong anyway, as it missed one instance of
1403 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1404 (refill_memory_reserve): Omit needless cast to size_t.
1405 (mark_object_loop_halt): Mark as externally visible.
1406
ac82cc6a
PE
1407 * xselect.c: Integer signedness and overflow fixes.
1408 (Fx_register_dnd_atom, x_handle_dnd_message):
1409 Use ptrdiff_t, not size_t, since we prefer signed.
1410 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1411 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1412 x_dnd_atoms_size and x_dnd_atoms_length.
1413
c2d1e36d
PE
1414 * doprnt.c: Prefer signed to unsigned when either works.
1415 * eval.c (verror):
1416 * doprnt.c (doprnt):
1417 * lisp.h (doprnt):
1418 * xdisp.c (vmessage):
1419 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1420 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1421 prefer signed arithmetic to avoid comparison confusion.
1422 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1423 but is a bit tricky.
1424
0e926e56
PE
1425 Assume freestanding C89 headers, string.h, stdlib.h.
1426 * data.c, doprnt.c, floatfns.c, print.c:
1427 Include float.h unconditionally.
1428 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1429 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1430 * regex.c: Likewise for stddef.h, string.h.
1431 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1432 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1433 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1434 (STDC_HEADERS): Remove obsolete defines.
1435 * sysdep.c: Include limits.h unconditionally.
1436
9cfdb3ec
PE
1437 Assume support for memcmp, memcpy, memmove, memset.
1438 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1439 * regex.c (memcmp, memcpy):
1440 Remove; we assume C89 now.
1441
1442 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1443 (__malloc_safe_bcopy): Remove; no longer needed.
1444
cf950e6b 1445 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1446 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1447 well either way, and we prefer signed to unsigned.
1448
dbf38e02
LMI
14492011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1450
1451 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1452 closes the connection while we're reading (bug#9182).
1453
d6f0886c 14542011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1455
d6f0886c
JD
1456 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1457 are specified (Bug#9168).
24e0f6b1 1458
2eb1f9e6
PE
14592011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1462 Found by GCC static checking and --with-wide-int on a 32-bit host.
1463
22381272 14642011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1465
1466 * xdisp.c (compute_display_string_pos): Fix logic of caching
1467 previous display string position. Initialize cached_prev_pos to
1468 -1. Fixes slow-down at the beginning of a buffer.
1469
f25e39b4
EZ
14702011-07-24 Eli Zaretskii <eliz@gnu.org>
1471
1472 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1473 for attrs[LFACE_FONTSET_INDEX].
1474
04c4b52e
PE
14752011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 * xml.c (parse_region): Remove unused local
1478 that was recently introduced.
1479
c1734fbd
EZ
14802011-07-23 Eli Zaretskii <eliz@gnu.org>
1481
be18c5a5
EZ
1482 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1483 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1484
c1734fbd
EZ
1485 * xdisp.c (move_it_in_display_line_to): Record the best matching
1486 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1487 exit if none of the characters scanned was an exact match.
1488 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1489 when exact match is impossible due to invisible text, and the
1490 lines are truncated.
1491
a258d627
JD
14922011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1493
1494 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1495 for OSX >= 10.7.
1496
b6d5a689
EZ
14972011-07-22 Eli Zaretskii <eliz@gnu.org>
1498
0f74f785
EZ
1499 Fix a significant slow-down of cursor motion with C-n, C-p,
1500 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1501 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1502 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1503 (next_element_from_buffer): Call compute_stop_pos_backwards to
1504 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1505 base_level_stop.
1506 (reseat): Don't look for prev_stop, as that could mean a very long
1507 run.
1508 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1509 <cached_disp_overlay_modiff>: Cache for last found display string
1510 position.
551918c1 1511 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1512 about the same buffer in the same area of character positions, and
1513 the buffer wasn't changed since the time the display string
1514 position was cached.
551918c1 1515
b2d0c91a
EZ
15162011-07-22 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1519 is an integer, which is important for empty lines. (Bug#9149)
1520
043604ee
CY
15212011-07-22 Chong Yidong <cyd@stupidchicken.com>
1522
1523 * frame.c (Fmodify_frame_parameters): In tty case, update the
1524 default face if necessary (Bug#4238).
1525
da4adb04
CY
15262011-07-21 Chong Yidong <cyd@stupidchicken.com>
1527
1528 * editfns.c (Fstring_to_char): No need to explain what a character
1529 is in the docstring (Bug#6576).
1530
9abd0532
LMI
15312011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1532
1533 * xml.c (parse_region): Make sure we always return a tree.
1534
36881d16
HK
15352011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1536
1537 * xml.c (parse_region): If a document contains only comments,
1538 return that, too.
1539
1e98674d
LMI
15402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1541
1542 * xml.c (make_dom): Return comments, too.
1543
590bd467
PE
15442011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1545
1546 Port to OpenBSD.
1547 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1548 and the surrounding thread.
1549 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1550 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1551 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1552 timer goes off.
1553 * s/openbsd.h (BROKEN_SIGIO): Define.
1554 * unexelf.c (unexec) [__OpenBSD__]:
1555 Don't update the .mdebug section of the Alpha COFF symbol table.
1556
f41628b2
LMI
15572011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1558
1559 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1560 (bug#8460).
1561
b59b67c5
PE
15622011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1563
15e3a074
PE
1564 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1565 This fixes some race conditions on the permissions of any newly
1566 created file.
1567
41bed37d
PE
1568 * alloc.c (valid_pointer_p): Use pipe, not open.
1569 This fixes some permissions issues when debugging.
1570
b59b67c5
PE
1571 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1572 If fchown fails to set both uid and gid, try to set just gid,
1573 as that is sometimes allowed. Adjust the file's mode to eliminate
1574 setuid or setgid bits that are inappropriate if fchown fails.
1575
925a6be7
SM
15762011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1577
1578 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1579 to compare Lisp_Objects.
1580 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1581 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1582 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1583
52968808
AS
15842011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1585
0a6a104b
AS
1586 * lread.c (read_integer): Unread even EOF character.
1587 (read1): Likewise. Properly record start position of symbol.
1588
52968808
AS
1589 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1590 symbol character follows.
1591
9e381cdd
PE
15922011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1595 This works around a problem with the previous change to Fcopy_file.
1596 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1597 and without this change, GCC might complain about discarding
1598 fchown's return value.
1599
b5641435
JB
16002011-07-16 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1603
a8031457
PE
16042011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1607
dd889327
LMI
16082011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1609
750c33f7
LMI
1610 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1611 it's used from the C level.
1612
dd889327
LMI
1613 * process.c: Use the same condition for POLL_FOR_INPUT in both
1614 keyboard.c and process.c (bug#1858).
1615
87e86684
LM
16162011-07-09 Lawrence Mitchell <wence@gmx.li>
1617
1618 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1619 (Fgnutls_boot): Use it.
1620
64348f40
AS
16212011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1622
1623 * doc.c (Fsubstitute_command_keys): Revert last change.
1624
1d698799
LMI
16252011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1626
f863868c
LMI
1627 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1628 quotes the next character, and doesn't affect other longer
1629 sequences (bug#8935).
1630
1d698799
LMI
1631 * lread.c (syms_of_lread): Clarify that is isn't only
1632 `eval-buffer' and `eval-defun' that's affected by
1633 `lexical-binding' (bug#8460).
1634
aa4b6df6
EZ
16352011-07-15 Eli Zaretskii <eliz@gnu.org>
1636
1637 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1638 bidi redisplay when a line includes both an image and is
1639 truncated.
1640
5d856da6
PE
16412011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1642
ad6042bb
PE
1643 Fix minor problems found by static checking.
1644 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1645 (elsz): Now a signed constant, not a size_t var. We prefer signed
1646 types to unsigned, to avoid integer comparison confusion. Without
1647 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1648 "cannot optimize loop, the loop counter may overflow", a symptom
1649 of the confusion.
f00bbb22 1650 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1651 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1652
6468f31c
LMI
16532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1654
49080b10
LMI
1655 * search.c (Fre_search_backward): Mention `case-fold-search' in
1656 all the re_search_* functions (bug#8138).
1657
6468f31c
LMI
1658 * keyboard.c (Fopen_dribble_file): Document when the file is
1659 closed (bug#8056).
1660
c965adc5
EZ
16612011-07-14 Eli Zaretskii <eliz@gnu.org>
1662
df9733bf
EZ
1663 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1664 bidi_cache_idx.
1665
0bb23927
EZ
1666 Support bidi reordering of display and overlay strings.
1667 * xdisp.c (compute_display_string_pos)
1668 (compute_display_string_end): Accept additional argument STRING.
1669 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1670 (reseat_to_string): Initialize bidi_it->string.s and
1671 bidi_it->string.schars.
1672 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1673 NULL (avoids a crash in bidi_paragraph_init).
1674 Initialize itb.string.lstring.
0bb23927
EZ
1675 (init_iterator): Call bidi_init_it only of a valid
1676 buffer position was specified. Initialize paragraph_embedding to
1677 L2R.
1678 (reseat_to_string): Initialize the bidi iterator.
1679 (display_string): If we need to ignore text properties of
1680 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1681 original value of -1 will not work with bidi.)
1682 (compute_display_string_pos): First arg is now struct
1683 `text_pos *'; all callers changed. Support display properties on
1684 Lisp strings.
1685 (compute_display_string_end): Support display properties on Lisp
1686 strings.
1687 (init_iterator, reseat_1, reseat_to_string): Initialize the
1688 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1689 when iterating on a string not from display properties).
640c8776
SM
1690 (compute_display_string_pos, compute_display_string_end):
1691 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1692 arrow keys.
1693 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1694 base_level_stop; instead, set base_level_stop to BEGV.
1695 Fixes crashes in vertical-motion.
0bb23927
EZ
1696 (next_element_from_buffer): Improve commentary for when
1697 the iterator is before prev_stop.
1698 (init_iterator): Initialize bidi_p from the default value of
1699 bidi-display-reordering, not from buffer-local value. Use the
1700 buffer-local value only if initializing for buffer iteration.
1701 (handle_invisible_prop): Support invisible properties on strings
1702 that are being bidi-reordered.
1703 (set_iterator_to_next): Support bidi reordering of C strings and
1704 Lisp strings.
1705 (next_element_from_string): Support bidi reordering of Lisp
1706 strings.
1707 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1708 (display_string): Support display of R2L glyph rows.
1709 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1710 (init_iterator): Don't initialize it->bidi_p for strings
1711 here.
1712 (reseat_to_string): Initialize it->bidi_p for strings here.
1713 (next_element_from_string, next_element_from_c_string)
1714 (next_element_from_buffer): Add xassert's for correspondence
1715 between IT's object being iterated and it->bidi_it.string
1716 structure.
1717 (face_before_or_after_it_pos): Support bidi iteration.
1718 (next_element_from_c_string): Handle the case of the first string
1719 character that is not the first one in the visual order.
1720 (get_visually_first_element): New function, refactored from common
1721 parts of next_element_from_buffer, next_element_from_string, and
1722 next_element_from_c_string.
1723 (tool_bar_lines_needed, redisplay_tool_bar)
1724 (display_menu_bar): Force left-to-right direction. Add a FIXME
1725 comment for making that be controlled by a user option.
1726 (push_it, pop_it): Save and restore the state of the
1727 bidi iterator. Save and restore the bidi_p flag.
1728 (pop_it): Iterate out of display property for string iteration as
1729 well.
1730 (iterate_out_of_display_property): Support iteration over strings.
1731 (handle_single_display_spec): Set up it->bidi_it for iteration
1732 over a display string, and call bidi_init_it.
1733 (handle_single_display_spec, next_overlay_string)
1734 (get_overlay_strings_1, push_display_prop): Set up the bidi
1735 iterator for displaying display or overlay strings.
1736 (forward_to_next_line_start): Don't use the shortcut if
1737 bidi-iterating.
1738 (back_to_previous_visible_line_start): If handle_display_prop
1739 pushed the iterator stack, restore the internal state of the bidi
1740 iterator by calling bidi_pop_it same number of times.
1741 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1742 and we are bidi-iterating, don't decrement the iterator position;
1743 instead, set the first_elt flag in the bidi iterator, to produce
1744 the same effect.
1745 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1746 (push_display_prop): xassert that we are iterating a buffer.
1747 (push_it, pop_it): Save and restore paragraph_embedding member.
1748 (handle_single_display_spec, next_overlay_string)
1749 (get_overlay_strings_1, reseat_1, reseat_to_string)
1750 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1751 correctly. Don't assume unibyte strings are not bidi-reordered.
1752 (compute_display_string_pos)
1753 (compute_display_string_end): Fix handling the case of C string.
1754 (push_it, pop_it): Save and restore from_disp_prop_p.
1755 (handle_single_display_spec, push_display_prop): Set the
1756 from_disp_prop_p flag.
1757 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1758 (pop_it): Call iterate_out_of_display_property only if we are
1759 popping after iteration over a string that came from a display
1760 property. Fix a typo in popping stretch info. Add an assertion
1761 for verifying that the iterator position is in sync with the bidi
1762 iterator.
1763 (handle_single_display_spec, get_overlay_strings_1)
1764 (push_display_prop): Fix initialization of paragraph direction for
1765 string when that of the parent object is not yet determined.
1766 (reseat_1): Call bidi_init_it to resync the bidi
1767 iterator with IT's position. (Bug#7616)
1768 (find_row_edges): If ROW->start.pos gives position
1769 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1770 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1771 Reset the from_disp_prop_p flag.
1772 (SAVE_IT, RESTORE_IT): New macros.
1773 (pos_visible_p, face_before_or_after_it_pos)
1774 (back_to_previous_visible_line_start)
1775 (move_it_in_display_line_to, move_it_in_display_line)
1776 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1777 (try_scrolling, redisplay_window, display_line): Use them when
1778 saving a temporary copy of the iterator and restoring it back.
1779 (back_to_previous_visible_line_start, reseat_1)
1780 (init_iterator): Empty the bidi cache "stack".
1781 (move_it_in_display_line_to): If iterator ended up at
1782 EOL, but we never saw any buffer positions smaller than
1783 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1784 motion in bidi-reordered lines.
1785 (move_it_in_display_line_to): Record prev_method and prev_pos
1786 immediately before the call to set_iterator_to_next. Fixes cursor
1787 motion in bidi-reordered lines with stretch glyphs and strings
1788 displayed in margins. (Bug#8133) (Bug#8867)
1789 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1790 TO_CHARPOS.
640c8776
SM
1791 (pos_visible_p): Support positions in bidi-reordered lines.
1792 Save and restore bidi cache.
0bb23927
EZ
1793
1794 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1795 (bidi_paragraph_info): Delete unused struct.
1796 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1797 (bidi_cache_start): New variable.
1798 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1799 to zero.
1800 (bidi_cache_fetch_state, bidi_cache_search)
1801 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1802 (bidi_cache_find, bidi_peek_at_next_level)
1803 (bidi_level_of_next_char, bidi_find_other_level_edge)
1804 (bidi_move_to_visually_next): Compare cache index with
1805 bidi_cache_start rather than with zero.
1806 (bidi_fetch_char): Accept new argument STRING; all callers
1807 changed. Support iteration over a string. Support strings with
1808 display properties. Support unibyte strings. Fix the type of
1809 `len' according to what STRING_CHAR_AND_LENGTH expects.
1810 (bidi_paragraph_init, bidi_resolve_explicit_1)
1811 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1812 (bidi_level_of_next_char, bidi_move_to_visually_next):
1813 Support iteration over a string.
0bb23927
EZ
1814 (bidi_set_sor_type, bidi_resolve_explicit_1)
1815 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1816 can now be zero (for strings); special values 0 and -1 were
1817 changed to -1 and -2, respectively.
1818 (bidi_char_at_pos): New function.
1819 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1820 Call it instead of FETCH_MULTIBYTE_CHAR.
1821 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1822 initialized to valid values.
1823 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1824 values.
1825 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1826 the test for valid cached positions. Fix the logic for looking up
1827 the sentinel state in the cache. GCPRO the Lisp string we are
1828 iterating.
1829 (bidi_push_it, bidi_pop_it): New functions.
1830 (bidi_initialize): Initialize the bidi cache start stack pointer.
1831 (bidi_cache_ensure_space): New function, refactored from part of
1832 bidi_cache_iterator_state. Don't assume the required size is just
1833 one BIDI_CACHE_CHUNK away.
1834 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1835 (bidi_count_bytes, bidi_char_at_pos): New functions.
1836 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1837 always valid if bidi_cache_idx is valid.
1838 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1839 is valid if it's going to be used.
1840 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1841 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1842 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1843 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1844 (bidi_find_other_level_edge, bidi_cache_start_stack):
1845 All variables related to cache indices are now EMACS_INT.
c965adc5 1846
0bb23927
EZ
1847 * dispextern.h (struct bidi_string_data): New structure.
1848 (struct bidi_it): New member `string'. Make flag members be 1-bit
1849 fields, and put them last in the struct.
640c8776
SM
1850 (compute_display_string_pos, compute_display_string_end):
1851 Update prototypes.
0bb23927
EZ
1852 (bidi_push_it, bidi_pop_it): Add prototypes.
1853 (struct iterator_stack_entry): New members bidi_p,
1854 paragraph_embedding, and from_disp_prop_p.
1855 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1856 (bidi_shelve_cache, bidi_unshelve_cache):
1857 Declare prototypes.
0bb23927
EZ
1858
1859 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1860 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1861 and vector-like objects.
1862
1863 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1864 cache around display iteration.
1865
1866 * window.c (Fwindow_end, window_scroll_pixel_based)
1867 (displayed_window_lines, Frecenter): Save and restore the bidi
1868 cache around display iteration.
1869
3bbd2265
LMI
18702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1871
1872 * editfns.c (Fdelete_region): Clarify the use of the named
1873 parameters (bug#6788).
1874
adc47434
MR
18752011-07-14 Martin Rudalics <rudalics@gmx.at>
1876
1877 * indent.c (Fvertical_motion): Set and restore w->pointm when
1878 saving and restoring the window's buffer (Bug#9006).
1879
837c31f8
LMI
18802011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1881
1882 * editfns.c (Fstring_to_char): Clarify just what is returned
1883 (bug#6576). Text by Eli Zaretskii.
1884
ac389d0c
JB
18852011-07-13 Juanma Barranquero <lekktu@gmail.com>
1886
1887 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1888
0be0ce47
EZ
18892011-07-13 Eli Zaretskii <eliz@gnu.org>
1890
1891 * buffer.c (mmap_find): Fix a typo.
1892
cd18e7e3
JB
18932011-07-13 Johan Bockgård <bojohan@gnu.org>
1894
1895 Fix execution of x selection hooks.
1896 * xselect.c (Qx_lost_selection_functions)
1897 (Qx_sent_selection_functions): New vars.
1898 (syms_of_xselect): DEFSYM them.
1899 (x_handle_selection_request): Pass Qx_sent_selection_functions
1900 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1901 (x_handle_selection_clear,x_clear_frame_selections):
1902 Pass Qx_lost_selection_functions rather than
1903 Vx_lost_selection_functions to Frun_hook_with_args.
1904
47ea7f44
PE
19052011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1906
ac389d0c 1907 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1908 The old code sometimes used this field without initializing it.
1909
47ea7f44
PE
1910 * alloc.c (gc_sweep): Don't read past end of array.
1911 In theory, the old code could also have corrupted Emacs internals,
1912 though it'd be very unlikely.
1913
bc985c87
AS
19142011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1915
1916 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1917 argument. (Bug#4026)
bc985c87 1918
0cf34688
LMI
19192011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1920
b3dadd76
LMI
1921 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1922 key" (bug#4257).
1923
0cf34688
LMI
1924 * window.c (Fset_window_start): Doc fix (bug#4199).
1925 (Fset_window_hscroll): Ditto.
1926
270768cd
PE
19272011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1928
077e3dda 1929 Fix minor new problems caught by GCC 4.6.1.
270768cd 1930 * term.c (init_tty): Remove unused local.
490011a6 1931 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1932 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1933 not used otherwise.
270768cd 1934
b1f58454
CY
19352011-07-12 Chong Yidong <cyd@stupidchicken.com>
1936
1937 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1938
22b9578d
LMI
19392011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1940
6e70ab07
LMI
1941 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1942 are the mini-buffer and the echo area (bug#3320).
1943
22b9578d
LMI
1944 * term.c (init_tty): Remove support for supdup, c10 and perq
1945 terminals, which are no longer supported (bug#1482).
1946
8974cc9f
JB
19472011-07-10 Johan Bockgård <bojohan@gnu.org>
1948
1949 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1950
a560d974
JD
19512011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1952
1953 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1954 for non-popups (Bug#3642).
1955
1dae0f0a
AS
19562011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1957
268c2c36 1958 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1959 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1960 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1961 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1962 * data.c (fmod): Likewise.
1963 * dispnew.c (swap_glyphs_in_rows): Likewise.
1964 * emacs.c (memory_warning_signal): Likewise.
1965 * floatfns.c (float_error): Likewise.
1966 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1967 (otf_open, font_otf_capability, generate_otf_features)
1968 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1969 Likewise.
1970 * image.c (pbm_read_file): Likewise.
1971 * indent.c (string_display_width): Likewise.
1972 * intervals.c (check_for_interval, search_for_interval)
1973 (inc_interval_count, count_intervals, root_interval)
1974 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1975 * lread.c (defalias): Likewise.
268c2c36 1976 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1977 * regex.c (set_image_of_range_1, set_image_of_range)
1978 (regex_grow_registers): Likewise.
1979 * sysdep.c (strerror): Likewise.
1980 * termcap.c (valid_filename_p, tprint, main): Likewise.
1981 * tparam.c (main): Likewise.
1982 * unexhp9k800.c (run_time_remap, save_data_space)
1983 (update_file_ptrs, read_header, write_header, calculate_checksum)
1984 (copy_file, copy_rest, display_header): Likewise.
1985 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1986 Likewise.
1987 * xdisp.c (check_it): Likewise.
1988 * xfaces.c (register_color, unregister_color, unregister_colors):
1989 Likewise.
1990 * xfns.c (print_fontset_result): Likewise.
1991 * xrdb.c (member, fatal, main): Likewise.
1992
99033785
PE
19932011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 Fix minor problems found by static checking (Bug#9031).
1996 * chartab.c (char_table_set_range, map_sub_char_table):
1997 Remove unused locals.
1998 (uniprop_table): Now static.
1999 * composite.c (_work_char): Remove unused static var.
2000
9cb2ac56
JB
20012011-07-09 Juanma Barranquero <lekktu@gmail.com>
2002
2003 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2004
f25661f0
JD
20052011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2006
2007 * gtkutil.c (qttip_cb): Remove code without function.
2008
8278c4fe
EZ
20092011-07-09 Eli Zaretskii <eliz@gnu.org>
2010
2011 * w32.c (pthread_sigmask): New stub.
2012
1692ae2d 20132011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2014
8a6ebd58 2015 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2016 sigprocmask is portable only for single-threaded applications, and
2017 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2018 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2019 (LIBES): Use it.
2020 * callproc.c (Fcall_process):
2021 * process.c (create_process):
2022 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2023 Use pthread_sigmask, not sigprocmask.
123403e4 2024
1b854618
JD
20252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2026
2027 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2028 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2029 wrong (Bug#8591).
2030
3fe4b549
JD
20312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2032
0ce7e563
JD
2033 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2034 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2035 (xg_hide_tooltip): Fix comment.
2036
3fe4b549
JD
2037 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2038 in registerServicesMenuSendTypes.
2039 (validRequestorForSendType): Don't check ns_return_types.
2040
2041 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2042 ns_return_type.
2043
5df75e47
JR
20442011-07-08 Jason Rumney <jasonr@gnu.org>
2045
2046 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2047 frame struct members of non-existent frames (Bug#6284).
2048
699c10bd
JD
20492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2050
4393663b
JD
2051 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2052 variable firstTime not needed on OSX >= 10.6.
2053 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2054 >= 10.5. Use setKnobProportion, setDoubleValue.
2055
2056 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2057 (MAC_OS_X_VERSION_10_5): Define if not defined.
2058 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2059 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2060 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2061
2062 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2063 cString and lossyCString on OSX >= 10.4
2064
2065 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2066 sizeToFit on OSX >= 10.2.
2067
2068 * nsimage.m (allocInitFromFile): Don't use deprecated method
2069 bestRepresentationForDevice on OSX >= 10.6.
2070
2071 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2072 to avoid warning.
2073
2074 * emacs.c: Declare unexec_init_emacs_zone.
2075
a63e0781
JD
2076 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2077
699c10bd
JD
2078 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2079
2080 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2081 on svcsMenu (Bug#8842).
2082
2083 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2084 ns_return_types.
2085 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2086
2087 * nsterm.m (QUTF8_STRING): Declare.
2088 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2089 (validRequestorForSendType): Return type is (id).
2090 Change indexOfObjectIdenticalTo to indexOfObject.
2091 Check if we have local selection before returning self (Bug#8842).
2092 (writeSelectionToPasteboard): Put local selection into paste board
2093 if we have a local selection (Bug#8842).
2094 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2095
2096 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2097 (ns_get_local_selection): Declare.
2098
54e10184
LMI
20992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2100
9888ff71
LMI
2101 * keymap.c (describe_map_tree): Don't insert a double newline at
2102 the end of the buffer (bug#1169) and return whether we inserted
2103 something.
2104
54e10184
LMI
2105 * callint.c (Fcall_interactively): Change "reading args" to
2106 "providing args" to try to clarify what it does (bug#1010).
2107
15fa4783
KH
21082011-07-07 Kenichi Handa <handa@m17n.org>
2109
2110 * composite.c (composition_compute_stop_pos): Ignore a static
2111 composition starting before CHARPOS (Bug#8915).
2112
2113 * xdisp.c (handle_composition_prop): Likewise.
2114
a8815b00
EZ
21152011-07-07 Eli Zaretskii <eliz@gnu.org>
2116
2117 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2118 (Bug#9015)
2119
ef7b981d 21202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2121
2122 * character.h (unicode_category_t): New enum type.
2123
2124 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2125 (Qchar_code_property_table): New variable.
2126 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2127 (UNIPROP_COMPRESSED_FORM_P): New macros.
2128 (char_table_ascii): Uncompress the compressed values.
2129 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2130 Uncompress the compressed values.
ac389d0c 2131 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2132 (char_table_ref_and_range): Uncompress the compressed values.
2133 (sub_char_table_set): New arg is_uniprop. Callers changed.
2134 Uncompress the compressed values.
2135 (sub_char_table_set_range): Args changed. Callers changed.
2136 (char_table_set_range): Adjuted for the above change.
2137 (map_sub_char_table): Delete args default_val and parent. Add arg
2138 top. Give decoded values to a Lisp function.
640c8776 2139 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2140 values to a Lisp function. Gcpro more variables.
2141 (uniprop_table_uncompress)
2142 (uniprop_decode_value_run_length): New functions.
2143 (uniprop_decoder, uniprop_decoder_count): New variables.
2144 (uniprop_get_decoder, uniprop_encode_value_character)
2145 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2146 New functions.
2147 (uniprop_encoder, uniprop_encoder_count): New variables.
2148 (uniprop_get_encoder, uniprop_table)
2149 (Funicode_property_table_internal, Fget_unicode_property_internal)
2150 (Fput_unicode_property_internal): New functions.
2151 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2152 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2153 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2154 char-code-property-alist.
2155
640c8776 2156 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2157 Vunicode_category_table.
2158
640c8776 2159 * font.c (font_range): Adjust for the change of
c805dec0
KH
2160 Vunicode_category_table.
2161
76b397fb
DN
21622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2163
2164 * m/iris4d.h: Remove file, move contents ...
2165 * s/irix6-5.h: ... here.
2166
22b4128e
PE
21672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2168
2169 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2170 * alloc.c (mark_buffer):
2171 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2172 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2173 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2174 This isn't true in general, and it's particularly not true
2175 if Emacs is configured with --with-wide-int.
2176 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2177 New macros, used in the buffer.c change.
2178
869795d6
JD
21792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2180
2181 * xsettings.c: Use both GConf and GSettings if both are available.
2182 (store_config_changed_event): Add comment.
2183 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2184 (store_tool_bar_style_changed): New functions.
5e617bc2 2185 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2186 (struct xsettings): Move font inside HAVE_XFT.
2187 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2188 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2189 Move inside HAVE_XFT.
640c8776 2190 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2191 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2192 also.
2193 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2194 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2195 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2196 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2197 (parse_settings): Move check for font inside HAVE_XFT.
2198 (read_settings, apply_xft_settings): Add comment.
2199 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2200 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2201 call store_font_name_changed.
2202 (xft_settings_event): Add comment.
2203 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2204 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2205 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2206 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2207 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2208 (xsettings_get_system_font, xsettings_get_system_normal_font):
2209 Add comment.
869795d6 2210
d8ed26bd
PE
22112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 Random fixes. E.g., (random) never returned negative values.
2214 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2215 subseconds part to the entropy, as that's a bit more random.
2216 Prefer signed to unsigned, since the signedness doesn't matter and
2217 in general we prefer signed. When given a limit, use a
2218 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2219 latter isn't right if USE_2_TAGS_FOR_INTS.
2220 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2221 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2222
cabf1cac
SM
22232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2224
2225 * textprop.c (text_property_stickiness):
2226 Obey Vtext_property_default_nonsticky.
2227 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2228 * w32fns.c (syms_of_w32fns):
2229 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2230
6e9b2be9
PE
22312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2234 This is more efficient than Ffile_directory_p and avoids a minor race.
2235
90186c68
LMI
22362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2237
7c301272
LMI
2238 * buffer.c (Foverlay_put): Say what the return value is
2239 (bug#7835).
2240
c4f2d8d4
LMI
2241 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2242 is a directory before asking whether to use the file name
2243 (bug#7564).
ad637907
LMI
2244 (barf_or_query_if_file_exists): Make the "File is a directory"
2245 error be more correct.
c4f2d8d4 2246
90186c68
LMI
2247 * fns.c (Frequire): Remove the mention of the .gz files, since
2248 that's installation-specific, but keep the mention of
2249 `get-load-suffixes'.
2250
da64016e
PE
22512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2254 Report string overflow if the output is too long.
2255
7d47b580
JB
22562011-07-04 Juanma Barranquero <lekktu@gmail.com>
2257
a555cb87
JB
2258 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2259 (syms_of_gnutls): Remove duplicate DEFSYM for
2260 Qgnutls_bootprop_verify_hostname_error, an error for
2261 Qgnutls_bootprop_verify_error (which is no longer used).
2262
7d47b580
JB
2263 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2264 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2265 Also (re)move comments that are misplaced or no longer relevant.
2266
1e49bfab
LMI
22672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2268
2269 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2270
1485f4c0
CY
22712011-07-03 Chong Yidong <cyd@stupidchicken.com>
2272
2273 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2274 and background color parameters if they have been changed.
2275
a9ab721e
LMI
22762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2277
2278 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2279
cf7cff57
PE
22802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2281
2e13213d
PE
2282 * xsettings.c (SYSTEM_FONT): Define only when used.
2283 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2284
cf7cff57
PE
2285 * keymap.c (access_keymap_1): Now static.
2286
7a8e04f7
CY
22872011-07-02 Chong Yidong <cyd@stupidchicken.com>
2288
2289 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2290 leave any prefix arg for the up event (Bug#1586).
2291
61352f62
LMI
22922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2293
69bb1ef7
LMI
2294 * lread.c (syms_of_lread): Mention single symbols defined by
2295 `defvar' or `defconst' (bug#7154).
2296
61352f62 2297 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2298 (Frequire): Mention get-load-suffixes.
61352f62 2299
28545e04
MR
23002011-07-02 Martin Rudalics <rudalics@gmx.at>
2301
2302 * window.h (window): Remove clone_number slot.
2303 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2304 Remove.
2305 (make_parent_window, make_window, saved_window)
2306 (Fset_window_configuration, save_window_save): Don't deal with
2307 clone numbers.
2308 * buffer.c (Qclone_number): Remove declaration.
2309 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2310
3349e122
SM
23112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2312
2313 Add multiple inheritance to keymaps.
2314 * keymap.c (Fmake_composed_keymap): New function.
2315 (Fset_keymap_parent): Simplify.
2316 (fix_submap_inheritance): Remove.
2317 (access_keymap_1): New function extracted from access_keymap to handle
2318 embedded parents and handle lists of maps.
2319 (access_keymap): Use it.
2320 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2321 (Fcopy_keymap): Handle embedded parents.
2322 (Fcommand_remapping, define_as_prefix): Simplify.
2323 (Fkey_binding): Simplify.
2324 (syms_of_keymap): Move minibuffer-local-completion-map,
2325 minibuffer-local-filename-completion-map,
2326 minibuffer-local-must-match-map, and
2327 minibuffer-local-filename-must-match-map to Elisp.
2328 (syms_of_keymap): Defsubr make-composed-keymap.
2329 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2330 (parse_menu_item): Trivial simplification.
2331
3279eb87
GM
23322011-07-01 Glenn Morris <rgm@gnu.org>
2333
2334 * Makefile.in (SETTINGS_LIBS): Fix typo.
2335
4550efdf
KI
23362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2337
2338 * coding.c (Fencode_coding_string): Record the last coding system
2339 used, as the function doc string says (bug#8738).
2340
0949d2b6
JD
23412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2342
2343 * xsettings.c (store_monospaced_changed): Take new font as arg and
2344 check for change against current_mono_font.
2345 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2346 (emacs_settings_constructor, emacs_settings_get_property)
2347 (emacs_settings_set_property, emacs_settings_class_init)
2348 (emacs_settings_init, gsettings_obj): Remove.
2349 (something_changedCB): New function for HAVE_GSETTINGS.
2350 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2351 with value as argument.
2352 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2353 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2354 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2355 "changed".
2356
2357 * xgselect.c: Add defined (HAVE_GSETTINGS).
2358 (xgselect_initialize): Ditto.
2359
2360 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2361 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2362 xg_select.
2363
bbc6b304
PE
23642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2365
2366 * eval.c (struct backtrace): Simplify and port the data structure.
2367 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2368 signed bit field, as this assumption is not portable and it makes
2369 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2370 "char debug_on_exit : 1" as this is not portable either; instead,
2371 use the portable "unsigned int debug_on_exit : 1". Remove unused
2372 member evalargs. Remove obsolete comments about cc bombing out.
2373
9851bfc5
JD
23742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2375
51bb811f 2376 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2377 Let HAVE_GSETTINGS override HAVE_GCONF.
2378 (store_monospaced_changed): New function.
2379 (EMACS_SETTINGS): A new type derived from GObject to handle
2380 GSettings notifications.
2381 (emacs_settings_constructor, emacs_settings_get_property)
2382 (emacs_settings_set_property, emacs_settings_class_init):
2383 New functions.
2384 (gsettings_client, gsettings_obj): New variables.
2385 (GSETTINGS_SCHEMA): New define.
2386 (something_changedCB): Call store_monospaced_changed.
2387 (init_gsettings): New function.
2388 (xsettings_initialize): Call init_gsettings.
2389 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2390 to NULL.
2391
640c8776 2392 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2393 GCONF_CFLAGS/LIBS.
2394
5386012d
MR
23952011-06-29 Martin Rudalics <rudalics@gmx.at>
2396
2397 * window.c (resize_root_window, grow_mini_window)
2398 (shrink_mini_window): Rename Qresize_root_window to
2399 Qwindow_resize_root_window and Qresize_root_window_vertically to
2400 Qwindow_resize_root_window_vertically.
2401
f13e0b08
PE
24022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2405
94515237
JB
24062011-06-27 Juanma Barranquero <lekktu@gmail.com>
2407
2408 * makefile.w32-in: Redesign dependencies so they reflect more
2409 clearly which files are directly included by each source file,
2410 and not through other includes.
2411
e43b6e43
MR
24122011-06-27 Martin Rudalics <rudalics@gmx.at>
2413
2414 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2415 (sort_overlays, overlay_strings): When an overlay's clone number
2416 matches the window's clone number process the overlay even if
2417 the overlay's window property doesn't match the current window.
2418
d68443dc
MR
2419 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2420 (Fwindow_hchild): Rename to Fwindow_left_child.
2421 (Fwindow_next): Rename to Fwindow_next_sibling.
2422 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2423 (resize_window_check): Rename to window_resize_check.
2424 (resize_window_apply): Rename to window_resize_apply.
2425 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2426 (Fdelete_other_windows_internal, resize_frame_windows)
2427 (Fsplit_window_internal, Fdelete_window_internal)
2428 (grow_mini_window, shrink_mini_window)
2429 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2430
c7e73be5
JD
24312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2432
2433 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2434 (emacs_fixed_set_min_size): Remove.
2435 (emacs_fixed_new): Take frame as argument.
2436
2437 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2438 (_EmacsFixedPrivate): Remove minwidth/height.
2439 Add struct frame *f.
2440 (emacs_fixed_init): Initialize priv->f.
2441 (get_parent_class, emacs_fixed_set_min_size): Remove.
2442 (emacs_fixed_new): Set priv->f to argument.
2443 (emacs_fixed_get_preferred_width)
2444 (emacs_fixed_get_preferred_height): Use min_width/height from
2445 frames size_hint to set minimum and natural (Bug#8919).
2446 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2447 and use min_width/height from frames size_hint to set
2448 min_width/height (Bug#8919).
2449
2450 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2451 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2452 Fix indentation.
c7e73be5 2453
cf99dcf8
EZ
24542011-06-26 Eli Zaretskii <eliz@gnu.org>
2455
2456 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2457 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2458 called at ZV.
2459
029529ac
CY
24602011-06-26 Chong Yidong <cyd@stupidchicken.com>
2461
2462 * process.c (wait_reading_process_output): Bypass select if
2463 waiting for a cell while ignoring keyboard input, and input is
2464 pending. Suggested by Jan Djärv (Bug#8869).
2465
7a7ef429
PE
24662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2467
2468 Use gnulib's dup2 module instead of rolling our own.
2469 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2470
11fdef7d 24712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2472
2473 * dispnew.c (scrolling_window): Before scrolling, turn off a
2474 mouse-highlight in the window being scrolled.
2475
cd3520a4
JB
24762011-06-24 Juanma Barranquero <lekktu@gmail.com>
2477
2478 Move DEFSYM to lisp.h and use everywhere.
2479
2480 * character.h (DEFSYM): Move declaration...
2481 * lisp.h (DEFSYM): ...here.
2482
2483 * gnutls.c:
2484 * minibuf.c:
2485 * w32menu.c:
2486 * w32proc.c:
2487 * w32select.c: Don't include character.h.
2488
2489 * alloc.c (syms_of_alloc):
2490 * buffer.c (syms_of_buffer):
2491 * bytecode.c (syms_of_bytecode):
2492 * callint.c (syms_of_callint):
2493 * casefiddle.c (syms_of_casefiddle):
2494 * casetab.c (init_casetab_once):
2495 * category.c (init_category_once, syms_of_category):
2496 * ccl.c (syms_of_ccl):
2497 * cmds.c (syms_of_cmds):
2498 * composite.c (syms_of_composite):
2499 * dbusbind.c (syms_of_dbusbind):
2500 * dired.c (syms_of_dired):
2501 * dispnew.c (syms_of_display):
2502 * doc.c (syms_of_doc):
2503 * editfns.c (syms_of_editfns):
2504 * emacs.c (syms_of_emacs):
2505 * eval.c (syms_of_eval):
2506 * fileio.c (syms_of_fileio):
2507 * fns.c (syms_of_fns):
2508 * frame.c (syms_of_frame):
2509 * fringe.c (syms_of_fringe):
2510 * insdel.c (syms_of_insdel):
2511 * keymap.c (syms_of_keymap):
2512 * lread.c (init_obarray, syms_of_lread):
2513 * macros.c (syms_of_macros):
2514 * msdos.c (syms_of_msdos):
2515 * print.c (syms_of_print):
2516 * process.c (syms_of_process):
2517 * search.c (syms_of_search):
2518 * sound.c (syms_of_sound):
2519 * syntax.c (init_syntax_once, syms_of_syntax):
2520 * terminal.c (syms_of_terminal):
2521 * textprop.c (syms_of_textprop):
2522 * undo.c (syms_of_undo):
2523 * w32.c (globals_of_w32):
2524 * window.c (syms_of_window):
2525 * xdisp.c (syms_of_xdisp):
2526 * xfaces.c (syms_of_xfaces):
2527 * xfns.c (syms_of_xfns):
2528 * xmenu.c (syms_of_xmenu):
2529 * xsettings.c (syms_of_xsettings):
2530 * xterm.c (syms_of_xterm): Use DEFSYM.
2531
4228cf16
TZ
25322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2533
cd3520a4 2534 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2535
7fcccf1e
PE
25362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2537
7efb4e0e
PE
2538 Integer and buffer overflow fixes (Bug#8873).
2539
ff5844ad
PE
2540 * print.c (printchar, strout): Check for string overflow.
2541 (PRINTPREPARE, printchar, strout):
2542 Don't set size unless allocation succeeds.
2543
90532f02
PE
2544 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2545 for sizes. Check for string overflow more accurately.
2546 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2547
6d84508d
PE
2548 * macros.c: Integer and buffer overflow fixes.
2549 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2550 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2551 Use ptrdiff_t, not int, for sizes.
2552 Don't increment bufsize until after realloc succeeds.
2553 Check for size-calculation overflow.
2554 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2555
437b2cb4
PE
2556 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2557
8b9ac8b4
PE
2558 * lread.c: Integer overflow fixes.
2559 (read_integer): Radix is now EMACS_INT, not int,
2560 to improve quality of diagnostics for out-of-range radices.
2561 Calculate buffer size correctly for out-of-range radices.
2562 (read1): Check for integer overflow in radices, and in
2563 read-circle numbers.
82cb60d3
PE
2564 (read_escape): Avoid int overflow.
2565 (Fload, openp, read_buffer_size, read1)
2566 (substitute_object_recurse, read_vector, read_list, map_obarray):
2567 Use ptrdiff_t, not int, for sizes.
2568 (read1): Use EMACS_INT, not int, for sizes.
20270765 2569 Check for size overflow.
8b9ac8b4 2570
7fcccf1e
PE
2571 * image.c (cache_image): Check for size arithmetic overflow.
2572
bfbbd7e7
PE
2573 * lread.c: Integer overflow issues.
2574 (saved_doc_string_size, saved_doc_string_length)
2575 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2576 Now ptrdiff_t, not int.
2577 (read1): Don't assume doc string length fits in int. Check for
2578 out-of-range doc string lengths.
2579 (read_list): Don't assume file position fits in int.
39019e54 2580 (read_escape): Check for hex character overflow.
bfbbd7e7 2581
4e323265
LL
25822011-06-22 Leo Liu <sdl.web@gmail.com>
2583
2584 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2585 Move to minibuffer.el.
2586
85fece3e
PE
25872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2588
20b84ce9 2589 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2590 The following patches are for when GLYPH_DEBUG && !XASSERT.
2591 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2592 * dispnew.c (flush_stdout):
2593 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2594 Mark as externally visible.
2595 * dispnew.c (check_window_matrix_pointers): Now static.
2596 * dispnew.c (window_to_frame_vpos):
2597 * xfns.c (unwind_create_frame):
2598 * xterm.c (x_check_font): Remove unused local.
2599 * scroll.c (CHECK_BOUNDS):
2600 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2601 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2602 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2603 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2604 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2605 Now static.
2606 (debug_method_add): Use va_list and vsprintf rather than relying
2607 on undefined behavior with wrong number of arguments.
2608 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2609 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2610 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2611 since we're not interested in debugging glyphs with old libraries.
2612 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2613 GCC 4.6.0's static checking.
2614
0766b489
PE
26152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2616
31fd4b32
PE
2617 Integer overflow and signedness fixes (Bug#8873).
2618 A few related buffer overrun fixes, too.
2619
b79e8648
PE
2620 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2621
0766b489
PE
2622 * dispextern.h (struct face.stipple):
2623 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2624 (x_bitmap_mask, x_allocate_bitmap_record)
2625 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2626 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2627 (x_create_bitmap_from_xpm_data):
2628 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2629 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2630 (.bitmaps_last):
2631 * xfaces.c (load_pixmap):
2632 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2633 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2634 (.bitmaps_last, struct x_output.icon_bitmap):
2635 Use ptrdiff_t, not int, for bitmap indexes.
2636 (x_allocate_bitmap_record): Check for size overflow.
2637 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2638
b081724f
PE
2639 Use ptrdiff_t, not int, for overlay counts.
2640 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2641 * editfns.c (overlays_around, get_pos_property):
2642 * textprop.c (get_char_property_and_overlay):
2643 * xdisp.c (next_overlay_change, note_mouse_highlight):
2644 * xfaces.c (face_at_buffer_position):
21514da7
PE
2645 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2646 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2647 (Fnext_overlay_change, Fprevious_overlay_change)
2648 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2649 Use ptrdiff_t, not int, for sizes.
21514da7 2650 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2651
3de73e5e
PE
2652 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2653
2606c57b
PE
2654 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2655 (x_session_initialize): Do not assume string length fits in int.
2656
aaafe47a
PE
2657 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2658 This is unlikely, but can occur if DPI is outlandish.
2659
2674ddc8 2660 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2661 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2662
28154962
PE
2663 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2664 * xrdb.c (magic_file_p, search_magic_path):
2665 Omit last arg SUFFIX; it was always 0. All callers changed.
2666 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2667
7de51af5
PE
2668 * xfont.c (xfont_match): Avoid need for strlen.
2669
25ed6cc3
PE
2670 * xfns.c: Don't assume strlen fits in int.
2671 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2672
4eab31dd
PE
2673 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2674 not unsigned long, as we prefer signed integers. All callers changed.
2675 Detect integer overflow in repeat count.
2676 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2677 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2678
171e2a58
PE
2679 * termcap.c: Don't assume sizes fit in int and never overflow.
2680 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2681 (gobble_line): Check for size-calculation overflow.
2682
ad39faca 2683 * minibuf.c (Fread_buffer):
6e5bb2dc 2684 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2685 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2686 Don't assume string length fits in int.
2687
52c61c22 2688 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2689 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2690
b5b8c9e5
PE
2691 * font.c: Don't assume string length fits in int.
2692 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2693 Use ptrdiff_t, not int.
ccd6111c
PE
2694 (font_intern_prop): Don't assume string length fits in int.
2695 Don't assume integer property fits in fixnum.
2696 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2697
882f0d81 2698 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2699 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2700 Reformulate so as not to need the command string.
2701 Invoke gzip -cd rather than gunzip, as it's more portable.
2702 (lock_info_type, lock_file_1, lock_file):
2703 Don't assume pid_t and time_t fit in unsigned long.
2704 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2705 (current_lock_owner): Prefer signed type for sizes.
2706 Use memcpy, not strncpy, where memcpy is what is really wanted.
2707 Don't assume (via atoi) that time_t and pid_t fit in int.
2708 Check for time_t and/or pid_t out of range, e.g., via a network share.
2709 Don't alloca where an auto var works fine.
2710
93f4cf88
PE
2711 * fileio.c: Fix some integer overflow issues.
2712 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2713 Don't assume string length fits in int.
2714 (directory_file_name): Don't assume string length fits in long.
2715 (make_temp_name): Don't assume pid fits in int, or that its print
2716 length is less than 20.
2717
f3e92b69
PE
2718 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2719
1bfdaf10
PE
2720 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2721
35016e9a
PE
2722 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2723
3d1e65a1
PE
2724 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2725 We prefer signed integers, even for size calculations.
2726
0b963a93
PE
2727 * emacs.c: Don't assume string length fits in 'int'.
2728 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2729 (main): Don't invoke strlen when not needed.
2730
573f4b54
PE
2731 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2732 (XD_DEBUG_MESSAGE): Don't waste a byte.
2733
989f33ba
PE
2734 * callproc.c (getenv_internal_1, getenv_internal)
2735 (Fgetenv_internal):
965d34eb
PE
2736 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2737
e4d29b33
PE
2738 * lread.c (invalid_syntax): Omit length argument.
2739 All uses changed. This doesn't fix a bug, but it simplifies the
2740 code away from its former Hollerith-constant appearance, and it's
2741 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2742 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2743
eb49b136
PE
2744 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2745 This didn't break anything, but it didn't help either.
2746 It's confusing to put a bogus integer in a place where the actual
2747 value does not matter.
9f62aeb1 2748 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2749 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2750
15375a22
PE
2751 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2752 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2753 implementation.
b61cc01c
PE
2754 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2755 We prefer signed types, and the value cannot exceed the EMACS_INT
2756 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2757 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2758 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2759 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2760
53b2623d
PE
2761 * indent.c (sane_tab_width): New function.
2762 (current_column, scan_for_column, Findent_to, position_indentation)
2763 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2764 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2765
51cab52b 2766 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2767
f2ed8a70
PE
2768 * lisp.h (lint_assume): New macro.
2769 * composite.c (composition_gstring_put_cache):
2770 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2771
abe80cc6
PE
2772 * editfns.c, insdel.c:
2773 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2774
b02c740e
PE
2775 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2776
ebc96716
PE
2777 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2778
b4e50fa0 2779 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2780 Use much-faster test for byte-length change.
311d5d7c 2781 Don't assume string byte-length fits in 'int'.
a4cf38e4 2782 Check that character arg fits in 'int'.
85461888 2783 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2784
c0c1ee9f
PE
2785 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2786
a498d7f4
PE
2787 * fns.c (concat): Catch string overflow earlier.
2788 Do not rely on integer wraparound.
2789
51cab52b
PE
2790 * dispextern.h (struct it.overlay_strings_charpos)
2791 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2792 * xdisp.c (forward_to_next_line_start)
2793 (back_to_previous_visible_line_start)
2794 (reseat_at_next_visible_line_start, next_element_from_buffer):
2795 Don't arbitrarily truncate the value of 'selective' to int.
2796
76031fad
PE
2797 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2798
5eb55db9
PE
2799 * composite.c: Don't truncate sizes to 'int'.
2800 (composition_gstring_p, composition_reseat_it)
2801 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2802 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2803 not EMACS_UINT, for indexes.
5eb55db9 2804
0703a717
PE
2805 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2806
d6202519
PE
2807 * buffer.c: Include <verify.h>.
2808 (struct sortvec.priority, struct sortstr.priority):
8961a454 2809 Now EMACS_INT, not int.
c20998a7 2810 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2811 (struct sortstr.size, record_overlay_string)
2812 (struct sortstrlist.size, struct sortlist.used):
2813 Don't truncate size to int.
2814 (record_overlay_string): Check for size-calculation overflow.
d6202519 2815 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2816
d5a19415
JM
28172011-06-22 Jim Meyering <meyering@redhat.com>
2818
029529ac 2819 Don't leak an XBM-image-sized buffer
d5a19415
JM
2820 * image.c (xbm_load): Free the image buffer after using it.
2821
a9041e6c
PE
28222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2823
2824 Port to Sun C.
2825 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2826 that Sun C diagnosed.
2827 * fns.c (secure_hash): Fix pointer signedness issue.
2828 * intervals.c (static_offset_intervals): New function.
2829 (offset_intervals): Use it.
2830
7f3f739f
LL
28312011-06-21 Leo Liu <sdl.web@gmail.com>
2832
2833 * deps.mk (fns.o):
2834 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2835 sha512.h.
2836
2837 * fns.c (secure_hash): Rename from crypto_hash_function and change
2838 the first arg to accept symbols.
5b66d427 2839 (Fsecure_hash): New primitive.
7f3f739f
LL
2840 (syms_of_fns): New symbols.
2841
76147d94
DD
28422011-06-20 Deniz Dogan <deniz@dogan.se>
2843
2844 * process.c (Fset_process_buffer): Clarify return value in
2845 docstring.
2846
7d7d0045
CY
28472011-06-18 Chong Yidong <cyd@stupidchicken.com>
2848
2849 * dispnew.c (add_window_display_history): Use BVAR.
2850
2851 * xdisp.c (debug_method_add): Use BVAR.
2852 (check_window_end, dump_glyph_matrix, dump_glyph)
2853 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2854
2855 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2856 Likewise.
2857
2858 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2859 check till after the cache is created in init_frame_faces.
2860
ff2bc410
SM
28612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2862
2863 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2864
28177add
PE
28652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2866
dd3482fe
PE
2867 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2868 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2869 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2870
393d71f3 2871 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2872 * fileio.c (Finsert_file_contents):
2873 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2874 Remove the old (too-loose) buffer overflow checks.
2875 They weren't needed, since make_gap checks for buffer overflow.
2876 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2877 The old code merely checked for Emacs fixnum overflow, and relied
2878 on undefined (wraparound) behavior. The new code avoids undefined
2879 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2880
2e6813b0 2881 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2882 Tune. Don't use wider integers than needed. Don't use alloca.
2883 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2884
599a9e4f
PE
2885 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2886
99561444
PE
2887 * insdel.c, lisp.h (buffer_overflow): New function.
2888 (insert_from_buffer_1, replace_range, replace_range_2):
2889 * insdel.c (make_gap_larger):
2890 * editfns.c (Finsert_char):
2891 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2892
28177add
PE
2893 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2894
e69dafad
PE
28952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2896
a7af7fde 2897 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2898
b1c46f02
PE
2899 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2900 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2901
e69dafad
PE
2902 * fileio.c: Don't assume EMACS_INT fits in off_t.
2903 (emacs_lseek): New static function.
2904 (Finsert_file_contents, Fwrite_region): Use it.
2905 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2906
566684ea
PE
2907 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2908
e6966cd6
PE
2909 * fns.c: Don't overflow int when computing a list length.
2910 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2911 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2912 truncation on 64-bit hosts. Check for QUIT every
2913 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2914 faster and is responsive enough.
2915 (Flength): Report an error instead of overflowing an integer.
2916 (Fsafe_length): Return a float if the value is not representable
2917 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2918 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2919 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2920
dd0b0efb
PE
2921 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2922 (header_size, word_size): New constants.
2923 (allocate_vectorlike): Don't check size overflow here.
2924 (allocate_vector): Check it here instead, since this is the only
2925 caller of allocate_vectorlike that could cause overflow.
2926 Check that the new vector's length is representable as a fixnum.
2927
86fe5cfe
PE
2928 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2929 The previous code was bogus. For example, next_almost_prime (32)
2930 returned 39, which is undesirable as it is a multiple of 3; and
2931 next_almost_prime (24) returned 25, which is a multiple of 5 so
2932 why was the code bothering to check for multiples of 7?
2933
80e88859
PE
2934 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2935
4a2f0ad6
PE
2936 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2937
f66c7cf8
PE
2938 Variadic C functions now count arguments with ptrdiff_t.
2939 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2940 Back then I didn't know that the Emacs coding style prefers signed int.
2941 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2942 were being counted with int, which may truncate counts on 64-bit
2943 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2944 * lisp.h (struct Lisp_Subr.function.aMANY)
2945 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2946 Arg counts are now ptrdiff_t, not size_t.
2947 All variadic functions and their callers changed accordingly.
2948 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2949 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2950 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2951 * callint.c (Fcall_interactively): Check arg count for overflow,
2952 to avoid potential buffer overrun. Use signed char, not 'int',
2953 for 'varies' array, so that we needn't bother to check its size
2954 calculation for overflow.
2955 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2956 * eval.c (apply_lambda):
2957 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2958 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2959 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2960
a1759b76
PE
2961 * callint.c (Fcall_interactively): Don't use index var as event count.
2962
d96be9fc
PE
2963 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2964 * mem-limits.h (SIZE): Remove; no longer used.
2965
a690a978 2966 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2967
578c21e6
PE
2968 Remove unnecessary casts.
2969 * xterm.c (x_term_init):
2970 * xfns.c (x_set_border_pixel):
2971 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2972 These aren't needed now that we assume ANSI C.
2973
96f53c6c
PE
2974 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2975 It's more likely to cause problems (due to unsigned overflow)
2976 than to cure them.
2977
83c77d31
PE
2978 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2979
ee2079f1
PE
2980 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2981
6da65536
PE
2982 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2983
7147c4a4
PE
2984 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2985
193e32d9
PE
2986 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2987
e5533da6
PE
2988 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2989
9910e595
PE
2990 GLYPH_CODE_FACE returns EMACS_INT, not int.
2991 * dispextern.h (merge_faces):
2992 * xfaces.c (merge_faces):
01103c44
PE
2993 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2994 Don't assume EMACS_INT fits in int.
9910e595 2995
2638320e
PE
2996 * character.h (CHAR_VALID_P): Remove unused parameter.
2997 * fontset.c, lisp.h, xdisp.c: All uses changed.
2998
045eb8d9
PE
2999 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3000
c1f134b5
PE
3001 * fns.c (concat): Minor tuning based on overflow analysis.
3002 This doesn't fix any bugs. Use int to hold character, instead
3003 of constantly refetching from Emacs object. Use XFASTINT, not
3004 XINT, for value known to be a character. Don't bother comparing
3005 a single byte to 0400, as it's always less.
3006
395fcb93 3007 * floatfns.c (Fexpt):
327eeec8
PE
3008 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3009
abbd3d23
PE
3010 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3011 for characters.
3012
684a03ef
PE
3013 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3014
0fed43f3
PE
3015 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3016 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3017 incorrectly succeed when S was a string, because 4294967386 was
3018 truncated before it was used.
3019
8fd02eb7
PE
3020 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3021 Otherwise, an out-of-range integer could cause undefined behavior
3022 on a 64-bit host.
3023
f8c86b69
PE
3024 * composite.c: Use int, not EMACS_INT, for characters.
3025 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3026 EMACS_INT, for values that are known to be in character range.
3027 This doesn't fix any bugs but is the usual style inside Emacs and
3028 may generate better code on 32-bit machines.
3029
34206dd2
PE
3030 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3031 This is for reasons similar to the recent CHAR_STRING fix.
3032 * charset.c (Fencode_char): Check that character arg is actually
3033 a character. Pass an int to ENCODE_CHAR.
3034 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3035 wider than 'int', as a compile-time check to prevent future regressions
3036 in this area.
3037
c5958d4c 3038 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3039
3040 Make sure a 64-bit char is never passed to CHAR_STRING.
3041 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3042 by silently ignoring the top 32 bits, allowing some values
3043 that were far too large to be valid characters.
3044 * character.h: Include <verify.h>.
3045 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3046 arguments are no wider than unsigned, as a compile-time check
3047 to prevent future regressions in this area.
3048 * data.c (Faset):
01103c44 3049 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3050 (Fsubst_char_in_region):
3051 * fns.c (concat):
3052 * xdisp.c (decode_mode_spec_coding):
3053 Adjust to CHAR_STRING's new requirement.
3054 * editfns.c (Finsert_char, Fsubst_char_in_region):
3055 * fns.c (concat): Check that character args are actually
3056 characters. Without this test, these functions did the wrong
3057 thing with wildly out-of-range values on 64-bit hosts.
3058
d37ca623
PE
3059 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3060 These casts should not be needed on 32-bit hosts, either.
3061 * keyboard.c (read_char):
3062 * lread.c (Fload): Remove casts to unsigned.
3063
ea204efb
PE
3064 * lisp.h (UNSIGNED_CMP): New macro.
3065 This fixes comparison bugs on 64-bit hosts.
3066 (ASCII_CHAR_P): Use it.
3067 * casefiddle.c (casify_object):
01103c44 3068 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3069 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3070 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3071 * dispextern.h (FACE_FROM_ID):
3072 * keyboard.c (read_char): Use UNSIGNED_CMP.
3073
41cb286c
PE
3074 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3075 not to EMACS_INT, to avoid GCC warning.
3076
4a1b9832
PE
3077 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3078
55daad71
PE
3079 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3080 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3081 isn't needed on 32-bit machines.
8f95c75c 3082
01103c44
PE
3083 * buffer.c (Fgenerate_new_buffer_name):
3084 Use EMACS_INT for count, not int.
0ceccced 3085 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3086
3087 * data.c (Qcompiled_function): Now static.
3088
c6f072e7
PE
3089 * window.c (window_body_lines): Now static.
3090
20ce5912
PE
3091 * image.c (gif_load): Rename local to avoid shadowing.
3092
9c4c5f81
PE
3093 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3094 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3095 * alloc.c (make_save_value): Integer argument is now of type
3096 ptrdiff_t, not int.
3097 (mark_object): Use ptrdiff_t, not int.
3098 * lisp.h (pD): New macro.
3099 * print.c (print_object): Use it.
3100
c0c5c8ae
PE
3101 * alloc.c: Use EMACS_INT, not int, to count objects.
3102 (total_conses, total_markers, total_symbols, total_vector_size)
3103 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3104 (total_free_floats, total_floats, total_free_intervals)
3105 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3106 Now EMACS_INT, not int. All uses changed.
3107 (Fgarbage_collect): Compute overall total using a double, so that
3108 integer overflow is less likely to be a problem. Check for overflow
3109 when converting back to an integer.
5a25e253
PE
3110 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3111 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3112 These were 'int' variables that could overflow on 64-bit hosts;
3113 they were never used, so remove them instead of repairing them.
211a0b2a 3114 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3115 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3116 Previously, this ceilinged at INT_MAX, but that doesn't work on
3117 64-bit machines.
e46bb31a 3118 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3119
c78baabf 3120 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3121 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3122 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3123 when a (possibly-narrower) signed value would do just as well.
3124 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3125
c9d624c6
PE
3126 * alloc.c: Catch some string size overflows that we were missing.
3127 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3128 for convenience in STRING_BYTES_MAX.
3129 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3130 The definition here is exact; the one in lisp.h was approximate.
3131 (allocate_string_data): Check for string overflow. This catches
3132 some instances we weren't catching before. Also, it catches
3133 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3134 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3135 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3136
c9d624c6
PE
3137 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3138 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3139 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3140
353032ce
PE
3141 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3142
2bccce07
PE
3143 * alloc.c (Fmake_string): Check for out-of-range init.
3144
0ac30604
SM
31452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3146
3147 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3148
c195f2de
JD
31492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3150
3151 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3152 xg_get_default_scrollbar_width.
3153
3154 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3155 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3156 (style_changed_cb): Call update_theme_scrollbar_width and call
3157 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3158 all frames (Bug#8505).
3159 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3160 Call gtk_window_set_resizable if HAVE_GTK3.
3161 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3162 and height if HAVE_GTK3 (Bug#8505).
3163 (scroll_bar_width_for_theme): New variable.
3164 (update_theme_scrollbar_width): New function.
3165 (xg_get_default_scrollbar_width): Move code to
3166 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3167 (xg_initialize): Call update_theme_scrollbar_width.
3168
3169 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3170
3171 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3172
e10ac9f1
MR
31732011-06-12 Martin Rudalics <rudalics@gmx.at>
3174
3175 * frame.c (make_frame): Call other_buffer_safely instead of
3176 other_buffer.
3177
3178 * window.c (temp_output_buffer_show): Call display_buffer with
3179 second argument Vtemp_buffer_show_specifiers and reset latter
3180 immediately after the call.
3181 (Vtemp_buffer_show_specifiers): New variable.
3182 (auto_window_vscroll_p, next_screen_context_lines)
3183 (Vscroll_preserve_screen_position): Remove leading asterisks from
3184 doc-strings.
3185
2d3c217e 31862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3187
7b7f97e8 3188 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3189 * buffer.c (Qclone_number): Remove for now, as it's unused.
3190 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3191 (record_buffer): Remove unused local.
3192 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3193 (set_frame_buffer_list): Remove; unused.
3194 * frame.h (other_visible_frames): Remove decl.
3195 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3196 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3197 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3198 if HAVE_GPM.
3199 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3200 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3201 Define only if HAVE_GPM.
3202 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3203 (update_hints_inhibit): Remove; never set. All uses removed.
3204 * widgetprv.h (emacsFrameClassRec): Remove decl.
3205 * window.c (delete_deletable_window): Now returns void, since it
3206 wasn't returning anything.
3207 (compare_window_configurations): Remove unused locals.
3208 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3209 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3210 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3211 the same widths as pointers. This follows up on the 2011-05-06 patch.
3212 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3213 * xterm.h: Likewise.
3214 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3215
1384b89e
JB
32162011-06-12 Juanma Barranquero <lekktu@gmail.com>
3217
3218 * makefile.w32-in: Update dependencies.
3219 (LISP_H): Add lib/intprops.h.
3220
1100a63c
CY
32212011-06-11 Chong Yidong <cyd@stupidchicken.com>
3222
3223 * image.c (gif_load): Add animation frame delay to the metadata.
3224 (syms_of_image): Use DEFSYM. New symbol `delay'.
3225
6198ccd0
MR
32262011-06-11 Martin Rudalics <rudalics@gmx.at>
3227
3228 * window.c (delete_deletable_window): Re-add.
3229 (Fset_window_configuration): Rewrite to handle dead buffers and
3230 consequently deletable windows.
3231 (window_tree, Fwindow_tree): Remove. Supply functionality in
3232 window.el.
3233 (compare_window_configurations): Simplify code.
3234
b6e3633c
AS
32352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3236
1ab0dee5
AS
3237 * image.c (imagemagick_load_image): Fix type mismatch.
3238 (Fimagemagick_types): Likewise.
3239
b6e3633c
AS
3240 * window.h (replace_buffer_in_windows): Declare.
3241
9397e56f
MR
32422011-06-11 Martin Rudalics <rudalics@gmx.at>
3243
3244 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3245 Qclone_number. Remove external declaration of Qdelete_window.
3246 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3247 code.
640c8776
SM
3248 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3249 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3250 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3251 buffer list implementation.
3252 (other_buffer_safely): New function.
3253 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3254 calls to replace_buffer_in_windows and
3255 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3256 if allowed.
3257 (record_buffer): Inhibit quitting and rewrite using quittable
3258 functions. Run Qbuffer_list_update_hook if allowed.
3259 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3260 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3261 Move switch-to-buffer to window.el.
9397e56f
MR
3262 (bury-buffer): Move to window.el.
3263 (Vbuffer_list_update_hook): New variable.
3264
3265 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3266 section.
3267
3268 * window.h (resize_frame_windows): Move up in code.
3269 (Fwindow_frame): Remove EXFUN.
3270 (replace_buffer_in_all_windows): Remove prototype.
3271 (replace_buffer_in_windows_safely): Add prototype.
3272
3273 * window.c: Declare Qdelete_window static again. Move down
3274 declaration of select_count.
3275 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3276 (Fother_window): Move to window.el.
3277 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3278 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3279 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3280 window.el.
3281 (replace_buffer_in_windows): Implement by calling
3282 Qreplace_buffer_in_windows.
3283 (replace_buffer_in_all_windows): Remove with some functionality
3284 moved into replace_buffer_in_windows_safely.
3285 (replace_buffer_in_windows_safely): New function.
3286 (select_window_norecord, select_frame_norecord): Move in front
3287 of run_window_configuration_change_hook. Remove now obsolete
3288 declarations.
640c8776
SM
3289 (Fset_window_buffer): Rewrite doc-string.
3290 Call Qrecord_window_buffer.
9397e56f
MR
3291 (keys_of_window): Move binding for other-window to window.el.
3292
b50691aa
CY
32932011-06-11 Chong Yidong <cyd@stupidchicken.com>
3294
3295 * dispextern.h (struct image): Replace data member, whose int_val
3296 and ptr_val fields were not used by anything, with a single
3297 lisp_val object.
3298
3299 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3300 (gif_clear_image, gif_load, imagemagick_load_image)
3301 (gs_clear_image, gs_load): Callers changed.
3302
3f754b86
PE
33032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3304
cca69397
PE
3305 * buffer.h: Include <time.h>, for time_t.
3306 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3307
109e28d0
PE
3308 Fix minor problems found by static checking.
3309
60737f02
PE
3310 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3311
4b66faf3
PE
3312 Make identifiers static if they are not used in other modules.
3313 * data.c (Qcompiled_function, Qframe, Qvector):
3314 * image.c (QimageMagick, Qsvg):
3315 * minibuf.c (Qmetadata):
3316 * window.c (resize_window_check, resize_root_window): Now static.
3317 * window.h (resize_window_check, resize_root_window): Remove decls.
3318
109e28d0
PE
3319 * window.c (window_deletion_count, delete_deletable_window):
3320 Remove; unused.
46a4ce9e
PE
3321 (window_body_lines): Now static.
3322 (Fdelete_other_windows_internal): Mark vars as initialized.
3323 Make sure 'resize_failed' is initialized.
3324 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3325 (resize_window_apply): Remove unused local.
3326 * window.h (delete_deletable_window): Remove decl.
3327
109e28d0 3328 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3329 (imagemagick_load_image): Fix pointer signedness problem by changing
3330 last arg from unsigned char * to char *. All uses changed.
3331 Also, fix a local for similar reasons.
3332 Remove unused locals. Remove locals to avoid shadowing.
3333 (fn_rsvg_handle_free): Remove; unused.
3334 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3335 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3336
3f754b86
PE
3337 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3338
2547adb1
CY
33392011-06-10 Chong Yidong <cyd@stupidchicken.com>
3340
3341 * image.c (gif_load): Fix omitted cast error introduced by
3342 2011-06-06 change.
3343
2c8e37d4
MR
33442011-06-10 Martin Rudalics <rudalics@gmx.at>
3345
3346 * window.h (resize_proportionally, orig_total_lines)
3347 (orig_top_line): Remove from window structure.
3348 (set_window_height, set_window_width, change_window_heights)
3349 (Fdelete_window): Remove prototypes.
3350 (resize_frame_windows): Remove duplicate declaration.
3351
440a42e3
EZ
33522011-06-10 Eli Zaretskii <eliz@gnu.org>
3353
3354 * window.h (resize_frame_windows, resize_window_check)
3355 (delete_deletable_window, resize_root_window)
3356 (resize_frame_windows): Declare prototypes.
3357
3358 * window.c (resize_window_apply): Make definition be "static" to
3359 match the prototype.
3360
562dd5e9
MR
33612011-06-10 Martin Rudalics <rudalics@gmx.at>
3362
3363 * window.c: Remove declarations of Qwindow_size_fixed,
3364 window_min_size_1, window_min_size_2, window_min_size,
3365 size_window, window_fixed_size_p, enlarge_window, delete_window.
3366 Remove static from declaration of Qdelete_window, it's
3367 temporarily needed by Fbury_buffer.
3368 (replace_window): Don't assign orig_top_line and
3369 orig_total_lines.
3370 (Fdelete_window, delete_window): Remove. Window deletion is
3371 handled by window.el.
640c8776
SM
3372 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3373 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3374 (Fdelete_other_windows): Remove. Deleting other windows is
3375 handled by window.el.
3376 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3377 handled in window.el.
3378 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3379 Window minimum sizes are handled in window.el.
3380 (shrink_windows, size_window, set_window_height)
3381 (set_window_width, change_window_heights, window_height)
3382 (window_width, CURBEG, CURSIZE, enlarge_window)
3383 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3384 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3385 handled in window.el.
3386 (make_dummy_parent): Rename to make_parent_window and give it a
3387 second argument horflag.
3388 (make_window): Don't set resize_proportionally any more.
3389 (Fsplit_window): Remove. Windows are split in window.el.
3390 (save_restore_action, save_restore_orig_size)
3391 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3392 Resize mini windows in window.el.
3393 (grow_mini_window, shrink_mini_window): Implement by calling
3394 Qresize_root_window_vertically, resize_window_check and
3395 resize_window_apply.
640c8776
SM
3396 (saved_window, Fset_window_configuration, save_window_save):
3397 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3398 resize_proportionally.
3399 (window_min_height, window_min_width): Move to window.el.
3400 (keys_of_window): Move bindings for delete-other-windows,
3401 split-window, delete-window and enlarge-window to window.el.
3402
3403 * buffer.c: Temporarily extern Qdelete_window.
3404 (Fbury_buffer): Temporarily call Qdelete_window instead of
3405 Fdelete_window (Fbury_buffer will move to window.el soon).
3406
3407 * frame.c (set_menu_bar_lines_1): Remove code handling
3408 orig_top_line and orig_total_lines.
3409
3410 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3411 set_window_height but set heights directly.
3412 (change_frame_size_1): Use resize_frame_windows.
3413
3414 * xdisp.c (init_xdisp): Don't use set_window_height but set
3415 heights directly.
3416
640c8776
SM
3417 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3418 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3419 run_window_configuration_change_hook.
3420
3421 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3422 instead of change_window_heights and run
3423 run_window_configuration_change_hook.
3424
1a13852e
MR
34252011-06-09 Martin Rudalics <rudalics@gmx.at>
3426
3427 * window.c (replace_window): Rename second argument REPLACEMENT to
3428 NEW. New third argument SETFLAG. Rewrite.
3429 (delete_window, make_dummy_parent): Call replace_window with
3430 third argument 1.
3431 (window_list_1): Move down in code.
3432 (run_window_configuration_change_hook): Move set_buffer part
3433 before select_frame_norecord part in order to unwind correctly.
3434 Rename count1 to count.
3435 (recombine_windows, delete_deletable_window, resize_root_window)
3436 (Fdelete_other_windows_internal)
3437 (Frun_window_configuration_change_hook, make_parent_window)
3438 (resize_window_check, resize_window_apply, Fresize_window_apply)
3439 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3440 (Fdelete_window_internal, Fresize_mini_window_internal):
3441 New functions.
1a13852e
MR
3442 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3443
f3d1777e
MR
34442011-06-08 Martin Rudalics <rudalics@gmx.at>
3445
496e208e
MR
3446 * window.h (window): Add some new members to window structure -
3447 normal_lines, normal_cols, new_total, new_normal, clone_number,
3448 splits, nest, prev_buffers, next_buffers.
3449 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3450 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3451
f3d1777e
MR
3452 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3453 Remove.
496e208e
MR
3454 (make_dummy_parent): Set new members of windows structure.
3455 (make_window): Move down in code. Handle new members of window
3456 structure.
3457 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3458 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3459 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3460 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3461 (Fset_window_next_buffers, Fset_window_clone_number):
3462 New functions.
496e208e
MR
3463 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3464 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3465 Doc-string fixes.
3466 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3467 Argument WINDOW can be now internal window too.
3468 (Fwindow_use_time): Move up in code.
3469 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3470 Rewrite doc-string.
3471 (Fset_window_configuration, saved_window)
3472 (Fcurrent_window_configuration, save_window_save): Handle new
3473 members of window structure.
b9e809c2
MR
3474 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3475 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3476 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3477 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3478 Qget_mru_window, Qresize_root_window,
3479 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3480 Qauto_buffer_name; staticpro them.
f3d1777e 3481
abde8f8c
MR
34822011-06-07 Martin Rudalics <rudalics@gmx.at>
3483
3484 * window.c (Fwindow_total_size, Fwindow_left_column)
3485 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3486 (Fwindow_list_1): New functions.
3487 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3488 (Fwindow_width, Fscroll_left, Fscroll_right):
3489 Use window_body_cols instead of window_box_text_cols.
3490 (delete_window, Fset_window_configuration):
3491 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3492 (delete_all_subwindows): Take a window as argument and not a
3493 structure. Rewrite.
190b47e6
MR
3494 (window_loop): Remove handling of GET_LRU_WINDOW and
3495 GET_LARGEST_WINDOW.
3496 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3497
3498 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3499 window_box_text_cols. delete_all_subwindows now takes a
3500 Lisp_Object as argument.
abde8f8c 3501
640c8776
SM
3502 * indent.c (compute_motion, Fcompute_motion):
3503 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3504
fa8a67e6
MR
3505 * frame.c (delete_frame): Call delete_all_subwindows with root
3506 window as argument.
3507
a54e3482
DC
35082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3509
3510 * fns.c (Fputhash): Document return value.
3511
60002bf5
CY
35122011-06-06 Chong Yidong <cyd@stupidchicken.com>
3513
3514 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3515
0c671da6 35162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3517
b862a52a 3518 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3519
be44ca6c
PE
3520 Check for overflow when converting integer to cons and back.
3521 * charset.c (Fdefine_charset_internal, Fdecode_char):
3522 Use cons_to_unsigned to catch overflow.
3523 (Fencode_char): Use INTEGER_TO_CONS.
3524 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3525 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3526 * data.c (long_to_cons, cons_to_long): Remove.
3527 (cons_to_unsigned, cons_to_signed): New functions.
3528 These signal an error for invalid or out-of-range values.
3529 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3530 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3531 * font.c (Ffont_variation_glyphs):
3532 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3533 * lisp.h: Include <intprops.h>.
3534 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3535 (cons_to_signed, cons_to_unsigned): New decls.
3536 (long_to_cons, cons_to_long): Remove decls.
3537 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3538 (Fprimitive_undo): Use CONS_TO_INTEGER.
3539 * xfns.c (Fx_window_property): Likewise.
3540 * xselect.c: Include <limits.h>.
3541 (x_own_selection, selection_data_to_lisp_data):
3542 Use INTEGER_TO_CONS.
3543 (x_handle_selection_request, x_handle_selection_clear)
3544 (x_get_foreign_selection, Fx_disown_selection_internal)
3545 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3546 (lisp_data_to_selection_data): Use cons_to_unsigned.
3547 (x_fill_property_data): Use cons_to_signed.
3548 Report values out of range.
3549
d1f3d2af
PE
3550 Check for buffer and string overflow more precisely.
3551 * buffer.h (BUF_BYTES_MAX): New macro.
3552 * lisp.h (STRING_BYTES_MAX): New macro.
3553 * alloc.c (Fmake_string):
3554 * character.c (string_escape_byte8):
3555 * coding.c (coding_alloc_by_realloc):
3556 * doprnt.c (doprnt):
3557 * editfns.c (Fformat):
3558 * eval.c (verror):
3559 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3560 since they may not be the same number.
3561 * editfns.c (Finsert_char):
3562 * fileio.c (Finsert_file_contents):
3563 Likewise for BUF_BYTES_MAX.
3564
dd52fcea
PE
3565 * image.c: Use ptrdiff_t, not int, for sizes.
3566 (slurp_file): Switch from int to ptrdiff_t.
3567 All uses changed.
3568 (slurp_file): Check that file size fits in both size_t (for
3569 malloc) and ptrdiff_t (for sanity and safety).
3570
7f9bbdbb
PE
3571 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3572 if b->modtime has its maximal value.
3573
dfe18f82
PE
3574 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3575
84acfcf0
PE
3576 Don't assume time_t can fit into int.
3577 * buffer.h (struct buffer.modtime): Now time_t, not int.
3578 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3579 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3580
ccd9a01a
PE
3581 Minor fixes for signed vs unsigned integers.
3582 * character.h (MAYBE_UNIFY_CHAR):
3583 * charset.c (maybe_unify_char):
3584 * keyboard.c (read_char, reorder_modifiers):
3585 XINT -> XFASTINT, since the integer must be nonnegative.
3586 * ftfont.c (ftfont_spec_pattern):
3587 * keymap.c (access_keymap, silly_event_symbol_error):
3588 XUINT -> XFASTINT, since the integer must be nonnegative.
3589 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3590 since it makes no difference and we prefer signed.
3591 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3592 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3593 nonnegative.
3594
d6d100dd
SM
35952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3596
3597 * window.h (Fwindow_frame): Declare.
3598
2b6148e4
PE
35992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3600
3601 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3602 (SPARE_MEMORY): Always define.
3603 (LARGE_REQUEST): Remove.
3604 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3605
f230ecc9
MR
36062011-06-06 Martin Rudalics <rudalics@gmx.at>
3607
727e958e
MR
3608 * lisp.h: Move EXFUNS for Fframe_root_window,
3609 Fframe_first_window and Fset_frame_selected_window to window.h.
3610
3611 * window.h: Move EXFUNS for Fframe_root_window,
3612 Fframe_first_window and Fset_frame_selected_window here from
3613 lisp.h.
3614
3615 * frame.c (Fwindow_frame, Fframe_first_window)
3616 (Fframe_root_window, Fframe_selected_window)
3617 (Fset_frame_selected_window): Move to window.c.
3618 (Factive_minibuffer_window): Move to minibuf.c.
3619 (Fother_visible_frames_p): New function.
3620
3621 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3622
f230ecc9
MR
3623 * window.c (decode_window, decode_any_window): Move up in code.
3624 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3625 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3626 (Fwindow_buffer): Move up and rewrite doc-string.
3627 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3628 (Fwindow_prev): New functions.
727e958e
MR
3629 (Fwindow_frame): Move here from frame.c. Accept any window as
3630 argument.
3631 (Fframe_root_window, Fframe_first_window)
3632 (Fframe_selected_window): Move here from frame.c. Accept frame
3633 or arbitrary window as argument. Update doc-strings.
3634 (Fminibuffer_window): Move up in code.
3635 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3636 (Fset_frame_selected_window): Move here from frame.c.
3637 Marginal rewrite.
727e958e
MR
3638 (Fselected_window, select_window, Fselect_window): Move up in
3639 code. Minor doc-string fixes.
f230ecc9 3640
4d09bcf6
PE
36412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3644 Do not assume that spare memory exists; that assumption is valid
3645 only if SYSTEM_MALLOC.
3646 (LARGE_REQUEST): New macro, so that the issue of large requests
3647 is separated from the issue of spare memory.
3648
810928a2
AS
36492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3650
172418ad
AS
3651 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3652 format. (Bug#8806)
3653
43f862f7
AS
3654 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3655
810928a2
AS
3656 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3657 before statements.
3658
a059fe24
JD
36592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3660
3661 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3662
3663 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3664
3665 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3666 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3667
989bf368
JB
36682011-06-05 Juanma Barranquero <lekktu@gmail.com>
3669
3670 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3671
4b80f674
CY
36722011-06-04 Chong Yidong <cyd@stupidchicken.com>
3673
3674 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3675 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3676 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3677 New error handlers.
4b80f674
CY
3678 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3679 Obey Vx_select_enable_clipboard_manager. Catch errors in
3680 x_clipboard_manager_save (Bug#8779).
3681 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3682 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3683
99a33b77 36842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3685
3686 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3687
99a33b77 36882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3689
3690 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3691 in the current matrix if keep_current_p is non-zero.
3692
8264569d
EZ
36932011-06-04 Eli Zaretskii <eliz@gnu.org>
3694
3695 * bidi.c (bidi_level_of_next_char): Fix last change.
3696
57f97249
EZ
36972011-06-03 Eli Zaretskii <eliz@gnu.org>
3698
fec2107c 3699 Support bidi reordering of text covered by display properties.
57f97249 3700
fec2107c
EZ
3701 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3702 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3703 (bidi_cache_search, bidi_cache_iterator_state)
3704 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3705 (bidi_level_of_next_char, bidi_move_to_visually_next):
3706 Support character positions inside a run of characters covered by a
fec2107c
EZ
3707 display string.
3708 (bidi_paragraph_init, bidi_resolve_explicit_1)
3709 (bidi_level_of_next_char): Call bidi_fetch_char and
3710 bidi_fetch_char_advance instead of FETCH_CHAR and
3711 FETCH_CHAR_ADVANCE.
3712 (bidi_init_it): Initialize new members.
3713 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3714 definitions.
3715 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3716 instead of using explicit *_CHAR codes.
d6d100dd
SM
3717 (bidi_resolve_explicit, bidi_resolve_weak):
3718 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3719 bidirectional text is supported only in multibyte buffers.
3720 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3721 it to initialize the frame_window_p member of struct bidi_it.
3722 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3723 (bidi_resolve_explicit, bidi_resolve_weak)
3724 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3725 bidi_it->nchars is non-positive.
3726 (bidi_level_of_next_char): Don't try to lookup the cache for the
3727 next/previous character if nothing is cached there yet, or if we
3728 were just reseat()'ed to a new position.
c40e2fb2 3729
0e14fe90
EZ
3730 * xdisp.c (set_cursor_from_row): Set start and stop points
3731 according to the row's direction when priming the loop that looks
3732 for the glyph on which to display cursor.
3733 (single_display_spec_intangible_p): Function deleted.
3734 (display_prop_intangible_p): Reimplement to call
3735 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3736 Accept 3 additional arguments needed by handle_display_spec.
3737 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3738 values: lists, `(when COND...)' forms, etc.
3739 (single_display_spec_string_p): Support property values that are
3740 lists with the argument STRING its top-level element.
3741 (display_prop_string_p): Fix the condition for processing a
3742 property that is a list to be consistent with handle_display_spec.
fec2107c 3743 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3744 last portion of handle_display_prop.
3745 (compute_display_string_pos): Accept additional argument
3746 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3747 value of a `display' property is a "replacing spec".
3748 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3749 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3750 the display property, but just return a value indicating whether
3751 the display property will replace the characters it covers.
3752 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3753 frame_window_p members of struct bidi_it.
d6d100dd
SM
3754 (compute_display_string_pos, compute_display_string_end):
3755 New functions.
fec2107c
EZ
3756 (push_it): Accept second argument POSITION, where pop_it should
3757 jump to continue iteration.
3758 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3759
fec2107c
EZ
3760 * keyboard.c (adjust_point_for_property): Adjust the call to
3761 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3762
3763 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3764 (bidi_init_it): Update prototypes.
3765 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3766 (compute_display_string_pos, compute_display_string_end):
3767 Declare prototypes.
fec2107c
EZ
3768 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3769 EMACS_INT.
fc6f18ce 3770
40087514 37712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3772
57f53182
PE
3773 Malloc failure behavior now depends on size of allocation.
3774 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3775 * lisp.h: Change signatures accordingly.
3776 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3777 All callers changed. (Bug#8762)
3778
3779 * gnutls.c: Use Emacs's memory allocators.
3780 Without this change, the gnutls library would invoke malloc etc.
3781 directly, which causes problems on non-SYNC_INPUT hosts, and which
3782 runs afoul of improving memory_full behavior. (Bug#8761)
3783 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3784 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3785 xfree instead of the default malloc, realloc, free.
3786 (Fgnutls_boot): No need to check for memory allocation failure,
3787 since xmalloc does that for us.
3788
ac32cd99 3789 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3790 * category.c (hash_get_category_set):
3791 * ccl.c (ccl_driver):
3792 * charset.c (Fdefine_charset_internal):
3793 * charset.h (struct charset.hash_index):
3794 * composite.c (get_composition_id, gstring_lookup_cache)
3795 (composition_gstring_put_cache):
3796 * composite.h (struct composition.hash_index):
3797 * dispextern.h (struct image.hash):
3798 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3799 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3800 (hashfn_equal, hashfn_user_defined, make_hash_table)
3801 (maybe_resize_hash_table, hash_lookup, hash_put)
3802 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3803 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3804 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3805 * image.c (make_image, search_image_cache, lookup_image)
3806 (xpm_put_color_table_h):
3807 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3808 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3809 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3810 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3811 * alloc.c (allocate_vectorlike):
3812 Check for overflow in vector size calculations.
3813 * ccl.c (ccl_driver):
3814 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3815 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3816 need to be updated by these changes.
40087514
PE
3817 * fns.c (make_hash_table, maybe_resize_hash_table):
3818 Check for integer overflow with large hash tables.
0de4bb68
PE
3819 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3820 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3821 (SXHASH_REDUCE): New macro.
3822 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3823 Use it instead of discarding useful hash info with large hash values.
3824 (sxhash_float): New function.
3825 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3826 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3827 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3828 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3829 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3830 Adjust signatures to match updated version of code.
3831 (consing_since_gc): Now EMACS_INT, since a single hash table can
3832 use more than INT_MAX bytes.
3833
698d32e2
DN
38342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3835
3836 Make it possible to build with GCC-4.6+ -O2 -flto.
3837
3838 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3839
fd6fa53f
SM
38402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3841
3842 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3843 Call minibuffer-inactive-mode.
3844
864db017
JB
38452011-05-31 Juanma Barranquero <lekktu@gmail.com>
3846
3847 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3848 Update dependencies.
3849
2ad0baf4
DN
38502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3851
3852 * data.c (init_data): Remove code for UTS, this system is not
3853 supported anymore.
3854
4fcc2638
DN
38552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3856
3857 Don't force ./temacs to start in terminal mode.
3858
3859 * frame.c (make_initial_frame): Initialize faces in all cases, not
3860 only when CANNOT_DUMP is defined.
3861 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3862
c56e0fd5
DN
38632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3864
3865 * dispnew.c (add_window_display_history): Use const for the string
3866 pointer. Remove declaration, not needed.
3867
333d54da 38682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3869
55d4c1b2 3870 Use 'inline', not 'INLINE'.
333d54da 3871 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3872 * alloc.c, fontset.c (INLINE): Remove.
3873 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3874 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3875 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3876 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3877 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3878
738db178
DN
38792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3880
3881 Make it possible to run ./temacs.
3882
3883 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3884 syms_of_callproc does the same thing. Remove test for
3885 "initialized", do it in the caller.
3886 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3887
620c53a6
SM
38882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3889
3890 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3891 (read_minibuf): Use get_minibuffer.
3892 (syms_of_minibuf): Use DEFSYM.
3893 (Qmetadata): New var.
3894 * data.c (Qbuffer): Don't make it static.
3895 (syms_of_data): Use DEFSYM.
3896
e003a292
PE
38972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3898
3899 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3900 (CCL_CODE_MIN): New macro.
3901
ed008a6d
PE
39022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3903
3687c2ef
PE
3904 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3905
ed008a6d
PE
3906 * eval.c (Qdebug): Now static.
3907 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3908 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3909 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3910
d66c4c7c
CY
39112011-05-29 Chong Yidong <cyd@stupidchicken.com>
3912
3913 * image.c: Various fixes to ImageMagick code comments.
3914 (Fimagemagick_types): Doc fix.
3915
5fbc2025
PE
39162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3917
0196f88a
PE
3918 Minor fixes prompted by GCC 4.6.0 warnings.
3919
3920 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3921
5fbc2025
PE
3922 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3923 (x_clipboard_manager_save_all): Move extern decl to ...
3924 * xterm.h: ... here, so that it can be checked for consistency.
3925
1dd3c2d9
CY
39262011-05-29 Chong Yidong <cyd@stupidchicken.com>
3927
3928 * xselect.c (x_clipboard_manager_save_frame)
3929 (x_clipboard_manager_save_all): New functions.
3930 (Fx_clipboard_manager_save): Lisp function deleted.
3931
3932 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3933 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3934
3935 * xterm.h: Update prototype.
3936
5ba6571d
WX
39372011-05-28 William Xu <william.xwl@gmail.com>
3938
3939 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3940 exiting (Bug#8239).
3941
3eaff834
JM
39422011-05-28 Jim Meyering <meyering@redhat.com>
3943
e1900994 3944 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3945 * fns.c (to_uchar): Define.
3946 (crypto_hash_function): Use it to convert some newly-signed
3947 variables to unsigned, to avoid sign-extension bugs. For example,
3948 without this change, (md5 "truc") would evaluate to
3949 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3950 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3951 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3952
0f6990a7
PE
39532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 Integer overflow fixes.
c8a9ca5a 3956
08686060
PE
3957 * dbusbind.c: Serial number integer overflow fixes.
3958 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3959 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3960 to hold a serial number that is too large for a fixnum.
3961 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3962 Check for serial numbers out of range. Decode any serial number
59568bf0 3963 that was so large that it became a float. (Bug#8722)
08686060 3964
2d1fc3c7
PE
3965 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3966 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3967 Use XFASTINT rather than XUINT when numbers are nonnegative.
3968 (xd_append_arg, Fdbus_method_return_internal):
3969 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3970 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3971 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3972 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3973 (Bug#8722)
2d1fc3c7 3974
c8a9ca5a
PE
3975 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3976
519e1d69
PE
3977 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3978
30569699
PE
3979 ccl: add integer overflow checks
3980 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3981 (IN_INT_RANGE): New macros.
3982 (ccl_driver): Use them to check for integer overflow when
3983 decoding a CCL program. Many of the new checks are whether XINT (x)
3984 fits in int; it doesn't always, on 64-bit hosts. The new version
3985 doesn't catch all possible integer overflows, but it's an
847044ea 3986 improvement. (Bug#8719)
30569699 3987
c11285dc
PE
3988 * alloc.c (make_event_array): Use XINT, not XUINT.
3989 There's no need for unsigned here.
3990
fdccd48e
PE
3991 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3992 This follows up to the 2011-05-06 change that substituted uintptr_t
3993 for EMACS_INT. This case wasn't caught back then.
3994
37910ab2
PE
3995 Rework Fformat to avoid integer overflow issues.
3996 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3997 now (part of C89). Include <verify.h>.
3998 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3999 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4000 (Fformat): Avoid the prepass trying to compute sizes; it was only
4001 approximate and thus did not catch overflow reliably. Instead, walk
4002 through the format just once, formatting and computing sizes as we go,
4003 checking for integer overflow at every step, and allocating a larger
4004 buffer as needed. Keep track separately whether the format is
4005 multibyte. Keep only the most-recently calculated precision, rather
4006 than them all. Record whether each argument has been converted to
4007 string. Use EMACS_INT, not int, for byte and char and arg counts.
4008 Support field widths and precisions larger than INT_MAX. Avoid
4009 sprintf's undefined behavior with conversion specifications such as %#d
4010 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4011 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4012 formatting out-of-range floating point numbers with int
9173deec 4013 formats. (Bug#8668)
37910ab2 4014
2e6578fb
PE
4015 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4016
0ae6bdee
PE
4017 * data.c: Avoid integer truncation in expressions involving floats.
4018 * data.c: Include <intprops.h>.
4019 (arith_driver): When there's an integer overflow in an expression
4020 involving floating point, convert the integers to floating point
4021 so that the resulting value does not suffer from catastrophic
4022 integer truncation. For example, on a 64-bit host (* 4
4023 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4024 Do not rely on undefined behavior after integer overflow.
4025
de883a70
PE
4026 merge count_size_as_multibyte, parse_str_to_multibyte
4027 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4028 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4029 Check for integer overflow.
4030 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4031 since it's now a duplicate of the other. This is more of
4032 a character than a buffer op, so better that it's in character.c.
4033 * fns.c, print.c: Adjust to above changes.
4034
2ff916cb
PE
40352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4036
4037 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4038
f1b54466
PE
40392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4040
fb1ac845
PE
4041 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4042 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4043 (x_clipboard_manager_save): Now static.
4044 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4045
f1b54466
PE
4046 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4047 (crypto_hash_function): Now static.
4048 Fix pointer signedness problems. Avoid unnecessary initializations.
4049
a9f737ee
CY
40502011-05-27 Chong Yidong <cyd@stupidchicken.com>
4051
4052 * termhooks.h (Vselection_alist): Make it terminal-local.
4053
4054 * terminal.c (create_terminal): Initialize it.
4055
4056 * xselect.c: Support for clipboard managers.
4057 (Vselection_alist): Move to termhooks.h as terminal-local var.
4058 (LOCAL_SELECTION): New macro.
4059 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4060 (symbol_to_x_atom): Remove gratuitous arg.
4061 (x_handle_selection_request, lisp_data_to_selection_data)
4062 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4063 (x_own_selection, x_get_local_selection, x_convert_selection):
4064 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4065 (some_frame_on_display): Delete unused function.
4066 (Fx_own_selection_internal, Fx_get_selection_internal)
4067 (Fx_disown_selection_internal, Fx_selection_owner_p)
4068 (Fx_selection_exists_p): New optional frame arg.
4069 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4070 (x_handle_selection_clear): Don't treat other terminals with the
4071 same keyboard specially. Use the terminal-local Vselection_alist.
4072 (x_clear_frame_selections): Use Frun_hook_with_args.
4073
4074 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4075
4076 * xterm.h: Add support for those atoms.
4077
e067f0c1
CY
40782011-05-26 Chong Yidong <cyd@stupidchicken.com>
4079
4080 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4081 (converted_selections, conversion_fail_tag): New global variables.
4082 (x_selection_request_lisp_error): Free the above.
4083 (x_get_local_selection): Remove unnecessary code.
4084 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4085 of converted selections stored in converted_selections.
4086 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4087 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4088 (x_convert_selection): New function.
4089 (x_handle_selection_event): Simplify.
4090 (x_get_foreign_selection): Don't ignore incoming requests while
4091 waiting for an answer; this will fail when we implement
4092 SAVE_TARGETS, and seems unnecessary anyway.
4093 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4094 (Vx_sent_selection_functions): Doc fix.
4095
0f4aebc0
LL
40962011-05-26 Leo Liu <sdl.web@gmail.com>
4097
4098 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4099
e61124cd
YM
41002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4101
4102 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4103
4104 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4105 for fringe update if it has periodic bitmap.
ac389d0c 4106 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4107 and fringe_bitmap_periodic_p.
4108
4109 * fringe.c (get_fringe_bitmap_data): New function.
4110 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4111 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4112 row. Mark glyph row for fringe update if periodicity changed.
4113
4114 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4115 for fringe update unless it has periodic bitmap.
4116
f16d9837
KH
41172011-05-25 Kenichi Handa <handa@m17n.org>
4118
4119 * xdisp.c (get_next_display_element): Set correct it->face_id for
4120 a static composition.
4121
e1b90ef6
LL
41222011-05-24 Leo Liu <sdl.web@gmail.com>
4123
4124 * deps.mk (fns.o):
4125 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4126
4127 * fns.c (crypto_hash_function, Fsha1): New function.
4128 (Fmd5): Use crypto_hash_function.
4129 (syms_of_fns): Add Ssha1.
4130
7400048f
PE
41312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4132
4133 * gnutls.c: Remove unused macros.
4134 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4135 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4136 Remove macros that are defined and never used.
4137 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4138
abb71cf4
CY
41392011-05-22 Chong Yidong <cyd@stupidchicken.com>
4140
4141 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4142 (Fx_get_selection_internal): Minor cleanup.
4143 (Fx_own_selection_internal): Rename arguments for consistency with
4144 select.el.
4145
6307db39
PE
41462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4149
f3d4e0a4
CY
41502011-05-22 Chong Yidong <cyd@stupidchicken.com>
4151
4152 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4153
4d8ade89
YM
41542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4155
4156 * dispnew.c (scrolling_window): Don't exclude the case that the
4157 last enabled row in the desired matrix touches the bottom boundary.
4158
32078c8d
GM
41592011-05-21 Glenn Morris <rgm@gnu.org>
4160
4161 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4162 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4163 and add some more files.
32078c8d 4164
7285dc67
EZ
41652011-05-20 Eli Zaretskii <eliz@gnu.org>
4166
4167 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4168 report_file_error introduced by the change from 2011-05-07.
4169
89d1bd22
PE
41702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 * systime.h (Time): Define only if emacs is defined.
4173 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4174 where the include path doesn't have X11/X.h by default. See
4175 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4176
e23640bb 41772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4178
4179 * composite.c (find_automatic_composition): Fix previous change.
4180
b9704ad9
GM
41812011-05-20 Glenn Morris <rgm@gnu.org>
4182
4183 * lisp.mk: New file, split from Makefile.in.
4184 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4185 (shortlisp): Remove.
4186 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4187
4a720484
GM
41882011-05-19 Glenn Morris <rgm@gnu.org>
4189
4190 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4191 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4192 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4193 (lisp): Set the order to that of loadup.el.
4194 (shortlisp): Make it a copy of $lisp.
4195 (SOME_MACHINE_LISP): Remove.
4196 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4197 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4198
a28d4396
KH
41992011-05-18 Kenichi Handa <handa@m17n.org>
4200
4201 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4202 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4203 (find_automatic_composition): Mostly rewrite for efficiency.
4204
a2b1fa8e
JB
42052011-05-18 Juanma Barranquero <lekktu@gmail.com>
4206
4207 * makefile.w32-in: Update dependencies.
4208
8e1f5610
CS
42092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4210
4211 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4212 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4213
7025ee00 42142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4215
cdfa6eab
PE
4216 Fix some integer overflow issues, such as string length overflow.
4217
06d6db33
PE
4218 * insdel.c (count_size_as_multibyte): Check for string overflow.
4219
2b4560a8
PE
4220 * character.c (lisp_string_width): Check for string overflow.
4221 Use EMACS_INT, not int, for string indexes and lengths; in
4222 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4223 the resulting string length overflows an EMACS_INT; instead,
4224 report a string overflow if no precision given. When checking for
4225 precision exhaustion, use a check that cannot possibly have
4226 integer overflow. (Bug#8675)
4227 * character.h (lisp_string_width): Adjust to new signature.
4228
cb93f9be
PE
4229 * alloc.c (string_overflow): New function.
4230 (Fmake_string): Use it. This doesn't change behavior, but saves
4231 a few bytes and will simplify future changes.
4232 * character.c (string_escape_byte8): Likewise.
4233 * lisp.h (string_overflow): New decl.
4234
1a1f3366
PE
4235 Fixups, following up to the user-interface timestamp change.
4236 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4237 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4238 * msdos.c (mouse_get_pos): Likewise.
4239 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4240 * w32gui.h (Time): Define by including "systime.h" rather than by
4241 declaring it ourselves. (Bug#8664)
4242
d4e3e4d3
PE
4243 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4244 * image.c (clear_image_cache): Likewise.
4245
f6a24d19
PE
4246 * term.c (term_mouse_position): Don't assume time_t wraparound.
4247
08dc5ae6
PE
4248 Be more systematic about user-interface timestamps.
4249 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4250 and sometimes 'EMACS_UINT', to represent these timestamps.
4251 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4252 This makes the code easier to follow, and makes it easier to catch
4253 integer overflow bugs such as Bug#8664.
4254 * frame.c (Fmouse_position, Fmouse_pixel_position):
4255 Use Time, not unsigned long, for user-interface timestamps.
4256 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4257 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4258 * keyboard.h (last_event_timestamp): Likewise.
4259 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4260 * menu.h (xmenu_show): Likewise.
4261 * term.c (term_mouse_position): Likewise.
4262 * termhooks.h (struct input_event.timestamp): Likewise.
4263 (struct terminal.mouse_position_hook): Likewise.
4264 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4265 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4266 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4267 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4268 what it was before.
4269 * menu.h, termhooks.h: Include "systime.h", for Time.
4270
8e55734a
PE
4271 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4272 Don't assume that the difference between two unsigned long values
4273 can fit into an integer. At this point, we know button_down_time
4274 <= event->timestamp, so the difference must be nonnegative, so
4275 there's no need to cast the result if double-click-time is
4276 nonnegative, as it should be; check that it's nonnegative, just in
4277 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4278 apart (about 25 days). (Bug#8664)
8e55734a 4279
841f1b75 4280 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4281 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4282
3e26f69c
PE
4283 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4284 that always fit in int. Use a sentinel instead of a counter, to
4285 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4286 * frame.h (struct frame): Use int for menu_bar_items_used
4287 instead of EMACS_INT, since it always fits in int.
3e26f69c 4288
5cc152c0
PE
4289 * menu.c (grow_menu_items): Check for int overflow.
4290
d89eb65e
PE
4291 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4292
5235bd3e
PE
4293 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4294 Before, the code was not consistent. These values cannot exceed
4295 2**31 - 1 so there's no need to make them unsigned.
4296 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4297 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4298 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4299 as modifiers.
4300 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4301
bc827e23
PE
4302 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4303 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4304 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4305 presumably because the widths might not match.
4306
78eb494e
PE
4307 * window.c (size_window): Avoid needless test at loop start.
4308
04f2d78b
CB
43092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4310
4311 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4312
d2fc7e3d 43132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4314
4315 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4316
d2fc7e3d 43172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4318
4319 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4320 `width' to `bar_area_x' and `bar_area_width', respectively.
4321 (x_scroll_run): Take account of fringe background extension.
4322
04f2d78b
CB
4323 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4324 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4325 `bar_area_width', respectively.
4326 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4327 background extension.
4328
79b70037
GM
43292011-05-10 Jim Meyering <meyering@redhat.com>
4330
4331 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4332
2f142cc5
JB
43332011-05-10 Juanma Barranquero <lekktu@gmail.com>
4334
4335 * image.c (Finit_image_library): Return t for built-in image types,
4336 like pbm and xbm. (Bug#8640)
4337
57679c86
AS
43382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4339
4340 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4341
888c9e86
EZ
43422011-05-07 Eli Zaretskii <eliz@gnu.org>
4343
b0512a1d
EZ
4344 * w32console.c (Fset_screen_color): Doc fix.
4345 (Fget_screen_color): New function.
4346 (syms_of_ntterm): Defsubr it.
4347
7285dc67
EZ
4348 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4349 unlink the temporary file if Fcall_process didn't create it in the
4350 first place.
4351 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4352 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4353 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4354 cue to call_process_cleanup not to close that handle.
4355
4d3fcc8e
BK
43562011-05-07 Ben Key <bkey76@gmail.com>
4357
4358 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4359 one of two shell specific rules, either bootstrap-temacs-CMD or
4360 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4361 to the previous implementation of the bootstrap-temacs rule.
4362 The bootstrap-temacs-CMD rule is similar to the previous
4363 implementation of the bootstrap-temacs rule except that it
4364 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4365 variable.
4366
4367 These changes, along with some changes to nt/configure.bat,
4368 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4369 earlier fix to add support for --cflags and --ldflags options
4370 that include quotes so that it works whether make uses cmd or
4371 sh as the shell.
4372
b4289b64
MA
43732011-05-06 Michael Albinus <michael.albinus@gmx.de>
4374
4375 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4376 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4377 is a constant.
4378 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4379 a string. Handle both cases.
4380 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4381 (Fdbus_register_method): Use Qinvalid_function.
4382
af4c0e28
JB
43832011-05-06 Juanma Barranquero <lekktu@gmail.com>
4384
4385 * makefile.w32-in: Update dependencies.
4386 (LISP_H): Add inttypes.h and stdin.h.
4387 (PROCESS_H): Add unistd.h.
4388
c51453d9
EZ
43892011-05-06 Eli Zaretskii <eliz@gnu.org>
4390
4391 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4392 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4393
8ff0ac3c 43942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4395
4c4b566b
PE
4396 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4397
aab2b9b5
PE
4398 * term.c (vfatal): Remove stray call to va_end.
4399 It's not needed and the C Standard doesn't allow it here anyway.
4400
c378da0b
PE
4401 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4402 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4403
288b08c7
PE
4404 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4405 bytes.
4406
e3601888
PE
4407 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4408
db6c0e74
PE
4409 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4410
dd5963ea
PE
4411 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4412
88c9450f
PE
4413 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4414
2f9442b8
PE
4415 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4416
c032b5f8
PE
4417 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4418 * charset.c (Fdefine_charset_internal): Don't initialize
4419 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4420 32-bit int (Bug#8600).
a108c10b
PE
4421
4422 * lread.c (read_integer): Be more consistent with string-to-number.
4423 Use string_to_number to do the actual conversion; this avoids
4424 rounding errors and fixes some other screwups. Without this fix,
4425 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4426 (digit_to_number): Move earlier, for benefit of read_integer.
4427 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4428 not a digit in any supported base. (Bug#8602)
a108c10b 4429
ad5f9eea
PE
4430 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4431
aec1708a
PE
4432 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4433 to match comment at start of function. This also removes a
4434 GCC warning about overflow in a 32+64-bit port.
4435
47be4ab5
PE
4436 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4437
371cac43
PE
4438 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4439 Reported by Stefan Monnier in
4440 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4441 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4442 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4443
d01a7826
PE
4444 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4445 (EMACS_UINTPTR): Likewise, with uintptr_t.
4446
7fd47d5c
PE
4447 * lisp.h: Prefer 64-bit EMACS_INT if available.
4448 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4449 on 32-bit hosts that have 64-bit int, so that they can access
4450 large files.
122b0c86
PE
4451 However, temporarily disable this change unless the temporary
4452 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4453
8727937b
PE
4454 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4455
8ac068ac
PE
4456 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4457 This removes an assumption that EMACS_INT and long are the same
4458 width as pointers. The assumption is true for Emacs porting targets
4459 now, but we want to make other targets possible.
4460 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4461 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4462 In the rest of the code, change types of integers that hold casted
4463 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4464 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4465 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4466 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4467 No need to cast type when ORing.
4468 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4469 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4470 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4471 assume EMACS_INT is the same width as char *.
4472 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4473 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4474 Remove no-longer-needed casts.
4475 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4476 (xg_tool_bar_help_callback, xg_make_tool_item):
4477 Use EMACS_INTPTR to hold an integer
4478 that will be cast to void *; this can avoid a GCC warning
4479 if EMACS_INT is not the same width as void *.
4480 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4481 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4482 (current_message_1, set_message_1):
4483 Use a local to convert to proper width without a cast.
4484 * xmenu.c (dialog_selection_callback): Likewise.
4485
ede49d71
PE
4486 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4487 Also, don't assume VALBITS / RAND_BITS is less than 5,
4488 and don't rely on undefined behavior when shifting a 1 left into
4489 the sign bit.
4490 * lisp.h (get_random): Change signature to match.
4491
2f30ecd0
PE
4492 * lread.c (hash_string): Use size_t, not int, for hash computation.
4493 Normally we prefer signed values; but hashing is special, because
4494 it's better to use unsigned division on hash table sizes so that
4495 the remainder is nonnegative. Also, size_t is the natural width
4496 for hashing into memory. The previous code used 'int', which doesn't
4497 retain enough info to hash well into very large tables.
4498 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4499
2a866e7b
PE
4500 * dbusbind.c: Don't possibly lose pointer info when converting.
4501 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4502 Use XPNTR rather than XHASH, so that the high-order bits of
4503 the pointer aren't lost when converting through void *.
4504
51639eac
PE
4505 * eval.c (Fautoload): Don't double-shift a pointer.
4506
92394119
PE
4507 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4508
dbdb9a7c
JB
45092011-05-06 Juanma Barranquero <lekktu@gmail.com>
4510
4511 * gnutls.c (DEF_GNUTLS_FN):
4512 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4513
db7a0b4f
AS
45142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4515
4516 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4517 marker. (Bug#8610)
4518
f7ff1b0f 45192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4520
4521 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4522 New version that can reserve upto 2GB of heap space.
4523
f7ff1b0f 45242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4525
4526 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4527
639c109b
TZ
45282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4529
4530 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4531 `gnutls_certificate_set_x509_key_file'.
4532
d2127135
JB
45332011-05-05 Juanma Barranquero <lekktu@gmail.com>
4534
4535 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4536 Update dependencies.
4537
e968f4f3
JB
45382011-05-04 Juanma Barranquero <lekktu@gmail.com>
4539
4540 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4541 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4542 Remove unused parameter `fildes'.
4543 * process.c (read_process_output, send_process): Don't pass it.
4544
84d358f0
JB
45452011-05-04 Juanma Barranquero <lekktu@gmail.com>
4546
4547 Fix previous change: the library cache is defined in w32.c.
4548 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4549 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4550
0898ca10
JB
45512011-05-04 Juanma Barranquero <lekktu@gmail.com>
4552
4553 Implement dynamic loading of GnuTLS on Windows.
4554
4555 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4556 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4557 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4558 Declare.
4559
4560 * gnutls.c (Qgnutls_dll): Define.
4561 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4562 (gnutls_*): Declare function pointers.
4563 (init_gnutls_functions): New function to initialize function pointers.
4564 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4565 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4566 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4567 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4568 (emacs_gnutls_write, emacs_gnutls_read)
4569 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4570 (Fgnutls_available_p): New function.
4571 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4572 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4573 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4574
4575 * image.c: Include w32.h.
4576 (Vimage_type_cache): Delete.
4577 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4578 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4579 (w32_delayed_load): Move to w32.c.
4580
4581 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4582
4583 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4584 (w32_delayed_load): Move from image.c. When loading a library, record
4585 its filename in the :loaded-from property of the library id.
4586 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4587 Initialize and staticpro them.
4588 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4589
4590 * process.c: Include lisp.h before w32.h, not after.
4591 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4592 instead of gnutls_record_check_pending.
4593
4594 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4595
ff4de4aa
TZ
45962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4597
4598 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4599 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4600 as passed in.
4601
abe95abb
JD
46022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4603
4604 * xterm.c (x_set_frame_alpha): Do not set property on anything
4605 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4606
e16e55d4
JB
46072011-05-02 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4610
bafcf6a5
JB
46112011-05-02 Juanma Barranquero <lekktu@gmail.com>
4612
4613 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4614 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4615 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4616 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4617 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4618 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4619 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4620 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4621 (Qgnutls_bootprop_callbacks_verify): Make static.
4622
e7a6747f
AS
46232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4624
19ed11ba
AS
4625 * callproc.c: Indentation fixup.
4626
e7a6747f 4627 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4628 (wait_for_termination, interruptible_wait_for_termination):
4629 Move after wait_for_termination_1.
e7a6747f 4630
1ef14cb4
LMI
46312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4632
4633 * sysdep.c (interruptible_wait_for_termination): New function
4634 which is like wait_for_termination, but allows keyboard
4635 interruptions.
4636
4637 * callproc.c (Fcall_process): Add (:file "file") as an option for
4638 the STDOUT buffer.
4639 (Fcall_process_region): Ditto.
4640
330d880c
EZ
46412011-04-30 Eli Zaretskii <eliz@gnu.org>
4642
8db90b73
EZ
4643 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4644 rather than `XVECTOR (FOO)->size'.
4645
330d880c
EZ
4646 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4647 inttypes.h, as a gnulib replacement is used if it not available in
4648 system headers.
4649
15cbd324
EZ
46502011-04-21 Eli Zaretskii <eliz@gnu.org>
4651
4652 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4653 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4654 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4655
4656 * coding.c (coding_alloc_by_realloc): Error out if destination
4657 will grow beyond MOST_POSITIVE_FIXNUM.
4658 (decode_coding_emacs_mule): Abort if there isn't enough place in
4659 charbuf for the composition carryover bytes. Reserve an extra
4660 space for up to 2 characters produced in a loop.
4661 (decode_coding_iso_2022): Abort if there isn't enough place in
4662 charbuf for the composition carryover bytes.
4663
46642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4665
ae940cca
EZ
4666 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4667 aborting when %lld or %lll format is passed.
4668 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4669 %llo or %llx format is passed. (Bug#8545)
4670
03ab8921
EZ
4671 * window.c (window_scroll_line_based): Use a marker instead of
4672 simple variables to record original value of point. (Bug#7952)
4673
afda1437
EZ
4674 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4675 produced by %s or %c overflows available buffer space. (Bug#8545)
4676
f76dee0c
PE
46772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4678
4679 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4680 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4681
fdc5744d
JB
46822011-04-28 Juanma Barranquero <lekktu@gmail.com>
4683
4684 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4685
638f053a
JB
46862011-04-28 Juanma Barranquero <lekktu@gmail.com>
4687
4688 * keyboard.c (Qdelayed_warnings_hook): Define.
4689 (command_loop_1): Run `delayed-warnings-hook'
4690 if Vdelayed_warnings_list is non-nil.
4691 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4692 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4693
d178f871
EZ
46942011-04-28 Eli Zaretskii <eliz@gnu.org>
4695
4696 * doprnt.c (doprnt): Don't return value smaller than the buffer
4697 size if the message was truncated. (Bug#8545).
4698
b124fd93
JB
46992011-04-28 Juanma Barranquero <lekktu@gmail.com>
4700
4701 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4702 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4703
e810457d
PE
47042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4705
4706 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4707
ea51cceb
JB
47082011-04-27 Juanma Barranquero <lekktu@gmail.com>
4709
4710 * makefile.w32-in: Update dependencies.
4711
94dcfacf
EZ
47122011-04-27 Eli Zaretskii <eliz@gnu.org>
4713
4714 Improve `doprnt' and its usage. (Bug#8545)
4715 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4716 `format_end'. Remove support for %l as a conversion specifier.
4717 Don't use xrealloc. Improve diagnostics when the %l size modifier
4718 is used. Update the commentary.
4719
4720 * eval.c (verror): Simplify calculation of size_t.
4721
4722 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4723 messages.
4724
f61f41d7
PE
47252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4726
4727 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4728 change.
4729
96fb4434
PE
47302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4731
4732 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4733 This makes this file independent of the recent pseudovector change.
4734
671875da 47352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4736
69e9b5a3
PE
4737 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4738
b5f869a7 4739 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4740 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4741 Remove unused local.
c8926152 4742 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4743
841a1577 4744 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4745 GCC 4.6.0 optimizes based on type-based alias analysis.
4746 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4747 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4748 != &v->size, and therefore "v->size = 1; b->size = 2; return
4749 v->size;" must therefore return 1. This assumption is incorrect
4750 for Emacs, since it type-puns struct Lisp_Vector * with many other
4751 types. To fix this problem, this patch adds a new type struct
f904488f 4752 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4753 and pseudovectors, and helps optimizing compilers not get fooled
4754 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4755 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4756 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4757 the size member.
eab3844f
PE
4758 (XSETPVECTYPE): Rewrite in terms of new macro.
4759 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4760 This is a bit clearer, and further avoids the possibility of
4761 undesirable aliasing.
4762 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4763 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4764 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4765 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4766 (ASIZE): Now uses header.size rather than size.
4767 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4768 to avoid the hassle of writing XVECTOR (foo)->header.size.
4769 (struct vectorlike_header): New type.
eab3844f
PE
4770 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4771 object, to help avoid aliasing.
4772 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4773 (SUBRP): Likewise, since Lisp_Subr is a special case.
4774 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4775 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4776 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4777 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4778 changed to be "header.size" and "header.next".
4779 * buffer.h (struct buffer): Likewise.
4780 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4781 * frame.h (struct frame): Likewise.
4782 * process.h (struct Lisp_Process): Likewise.
4783 * termhooks.h (struct terminal): Likewise.
4784 * window.c (struct save_window_data, struct saved_window): Likewise.
4785 * window.h (struct window): Likewise.
4786 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4787 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4788 * buffer.c (init_buffer_once): Likewise.
4789 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4790 special case.
4791 * process.c (Fformat_network_address): Use local var for size,
4792 for brevity.
4793
0df1eac5
PE
4794 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4795
847ab9d1 4796 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4797 * data.c (atof): Remove decl; no longer used or needed.
4798 (digit_to_number): Move to lread.c.
4799 (Fstring_to_number): Use new string_to_number function, to be
4800 consistent with how the Lisp reader treats infinities and NaNs.
4801 Do not assume that floating-point numbers represent EMACS_INT
4802 without losing information; this is not true on most 64-bit hosts.
4803 Avoid double-rounding errors, by insisting on integers when
4804 parsing non-base-10 numbers, as the documentation specifies.
4805 * lisp.h (string_to_number): New decl, replacing ...
4806 (isfloat_string): Remove.
bc0a5c13 4807 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4808 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4809 appears to have been a coding error. Similarly, do not accept
4810 strings like +-1e0 as floating point numbers. Do not report
4811 overflow for integer overflows unless the base is not 10 which
4812 means we have no simple and reliable way to continue.
4813 Break out the floating-point parsing into a new
4814 function string_to_number, so that Fstring_to_number parses
4815 floating point numbers consistently with the Lisp reader.
04f2d78b 4816 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4817 (E_CHAR, EXP_INT): Remove, replacing with ...
4818 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4819 (string_to_number): New function, replacing isfloat_string.
4820 This function checks for valid syntax and produces the resulting
4821 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4822 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4823 so that overflow for non-base-10 numbers is reported only when
4824 there's no portable and simple way to convert to floating point.
452f4150 4825
67769ffc
PE
4826 * textprop.c (set_text_properties_1): Rewrite for clarity,
4827 and to avoid GCC warning about integer overflow.
4828
c20db43f
PE
4829 * intervals.h (struct interval): Use EMACS_INT for members
4830 where EMACS_UINT might cause problems. See
4831 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4832 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4833 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4834 All uses changed.
37aa2f85
PE
4835 (offset_intervals): Tell GCC not to worry about length overflow
4836 when negating a negative length.
c20db43f 4837
2538aa2f
PE
4838 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4839 (overrun_check_free): Likewise.
4840
f2d3008d
PE
4841 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4842 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4843 word size.
4844
ec8df744
PE
4845 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4846 (gnutls_make_error): Rename local to avoid shadowing.
4847 (gnutls_emacs_global_deinit): ifdef out; not used.
4848 (Fgnutls_boot): Use const for pointer to readonly storage.
4849 Comment out unused local. Fix pointer signedness problems.
4850
640ee02d
PE
4851 * lread.c (openp): Don't stuff size_t into an 'int'.
4852 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4853 about possible signed overflow.
4854
6048fb2a
PE
4855 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4856 (GDK_KEY_g): Don't define if already defined.
4857 (xg_prepare_tooltip): Avoid pointer signedness problem.
4858 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4859
fa3c87e1
PE
4860 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4861 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4862
2172544b
PE
4863 * xfns.c (Fx_window_property): Simplify a bit,
4864 to make a bit faster and to avoid GCC 4.6.0 warning.
4865 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4866
9b821a21
PE
4867 * fns.c (internal_equal): Don't assume size_t fits in int.
4868
3c616cfa
PE
4869 * alloc.c (compact_small_strings): Tighten assertion a little.
4870
c2982e87
PE
4871 Replace pEd with more-general pI, and fix some printf arg casts.
4872 * lisp.h (pI): New macro, generalizing old pEd macro to other
4873 conversion specifiers. For example, use "...%"pI"d..." rather
4874 than "...%"pEd"...".
4875 (pEd): Remove. All uses replaced with similar uses of pI.
4876 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4877 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4878 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4879 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4880 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4881 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4882 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4883 64-bit hosts.
4884 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4885 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4886 * print.c (safe_debug_print, print_object): Likewise.
4887 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4888 to int.
6f04d126
PE
4889 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4890 avoiding the 0 flag, which is not portable.
c2982e87
PE
4891 * process.c (Fmake_network_process): Use pI to avoid cast.
4892 * region-cache.c (pp_cache): Likewise.
4893 * xdisp.c (decode_mode_spec): Likewise.
4894 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4895 behavior on 64-bit hosts with printf arg.
6f04d126 4896 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4897 (x_stop_queuing_selection_requests): Likewise.
4898 (x_get_window_property): Don't truncate byte count to an 'int'
4899 when tracing.
0b432f21 4900
5e073ec7
PE
4901 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4902 here, since it parses constructs like leading '-' and spaces,
4903 which are not wanted; and it overflows with large numbers.
4904 Instead, simply match F[0-9]+, which is what is wanted anyway.
4905
36372bf9
PE
4906 * alloc.c: Remove unportable assumptions about struct layout.
4907 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4908 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4909 (allocate_vectorlike, make_pure_vector): Use the new macros,
4910 plus offsetof, to remove unportable assumptions about struct layout.
4911 These assumptions hold on all porting targets that I know of, but
4912 they are not guaranteed, they're easy to remove, and removing them
4913 makes further changes easier.
4914
0b432f21
PE
4915 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4916 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4917 (string_overrun_cookie): Now const. Use initializers that
4918 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4919 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4920 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4921 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4922 multiple of sizeof (EMACS_INT); it need not be, if
4923 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4924 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4925
895009e1
JB
49262011-04-26 Juanma Barranquero <lekktu@gmail.com>
4927
4928 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4929
6a7a1b0b
TZ
49302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4931
4932 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4933 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4934 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4935
841a1577 49362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4937
4938 * lisp.h (Qdebug): List symbol.
895009e1 4939 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4940 * keyboard.c (debug-on-event): New variable.
4941 (handle_user_signal): Break into debugger when debug-on-event
4942 matches the current signal symbol.
4943
f2d3ba6f
DN
49442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4945
4946 * alloc.c (check_sblock, check_string_bytes)
4947 (check_string_free_list): Convert to standard C.
4948
42ce4c63
TZ
49492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4950
4951 * w32.c (emacs_gnutls_push): Fix typo.
4952
825cd63c
EZ
49532011-04-25 Eli Zaretskii <eliz@gnu.org>
4954
fb11d64d
EZ
4955 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4956 "cast to pointer from integer of different size".
4957
825cd63c
EZ
4958 Improve doprnt and its use in verror. (Bug#8545)
4959 * doprnt.c (doprnt): Document the set of format control sequences
4960 supported by the function. Use SAFE_ALLOCA instead of always
4961 using `alloca'.
4962
4963 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4964 is one byte too soon. Don't use xrealloc; instead xfree and
4965 xmalloc anew.
4966
e061a11b
TZ
49672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4968
4969 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4970 callbacks stage.
4971
4972 * gnutls.c: Renamed global_initialized to
4973 gnutls_global_initialized. Added internals for the
4974 :verify-hostname-error, :verify-error, and :verify-flags
4975 parameters of `gnutls-boot' and documented those parameters in the
4976 docstring. Start callback support.
9173deec
JB
4977 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4978 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4979 on error. Return error code.
e061a11b
TZ
4980 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4981 (emacs_gnutls_read): Likewise.
4982 (Fgnutls_boot): Return handshake error code.
4983 (emacs_gnutls_handle_error): New function.
4984 (wsaerror_to_errno): Likewise.
4985
4986 * w32.h (emacs_gnutls_pull): Add prototype.
4987 (emacs_gnutls_push): Likewise.
4988
4989 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4990 (emacs_gnutls_push): Likewise.
4991
49922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4993
4994 * process.c (wait_reading_process_output): Check if GnuTLS
4995 buffered some data internally if no FDs are set for TLS
4996 connections.
4997
4998 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4999 (LIBS): Link to USER_LIBS.
5000 ($(BLD)/gnutls.$(0)): New target.
5001
fa6996bc
EZ
50022011-04-24 Eli Zaretskii <eliz@gnu.org>
5003
eb35682e
EZ
5004 * xdisp.c (handle_single_display_spec): Rename the
5005 display_replaced_before_p argument into display_replaced_p, to
5006 make it consistent with the commentary. Fix typos in the
5007 commentary.
5008
e2ad650c
EZ
5009 * textprop.c (syms_of_textprop): Remove dead code.
5010 (copy_text_properties): Delete obsolete commentary about an
5011 interface that was deleted long ago. Fix typos in the description
5012 of arguments.
5013
1b2de274
EZ
5014 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5015 to changes in oldXMenu/XMenu.h from 2011-04-16.
5016 <menu_help_message, prev_menu_help_message>: Constify.
5017 (IT_menu_make_room): menu->help_text is now `const char **';
5018 adjust.
5019
5020 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5021 to changes in oldXMenu/XMenu.h from 2011-04-16.
5022 (struct XMenu): Declare `help_text' `const char **'.
5023
5024 * xfaces.c <Qunspecified>: Make extern again.
5025
5026 * syntax.c: Include sys/types.h before including regex.h, as
5027 required by Posix.
5028
762b15be
EZ
5029 * doc.c (get_doc_string): Improve the format passed to `error'.
5030
5031 * doprnt.c (doprnt): Improve commentary.
5032
5033 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5034
5035 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5036 them with etags.
5037
f1052e5d
EZ
5038 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5039 changes in globals.h immediately force recompilation.
762b15be
EZ
5040 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5041 $(CURDIR)/s/ms-w32.h.
5042 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5043
fa6996bc
EZ
5044 * character.c (Fchar_direction): Function deleted.
5045 (syms_of_character): Don't defsubr it.
5046 <char-direction-table>: Deleted.
5047
e6c3da20
EZ
50482011-04-23 Eli Zaretskii <eliz@gnu.org>
5049
5050 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5051 * doprnt.c: Include limits.h.
5052 (SIZE_MAX): New macro.
04f2d78b
CB
5053 (doprnt): Return a size_t value. 2nd arg is now size_t.
5054 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5055 Improve overflow protection. Support `l' modifier for integer
5056 conversions. Support %l conversion. Don't assume an EMACS_INT
5057 argument for integer conversions and for %c.
5058
5059 * lisp.h (doprnt): Restore prototype.
5060
5061 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5062 $(SRC)/character.h.
5063
5064 * Makefile.in (base_obj): Add back doprnt.o.
5065
5066 * deps.mk (doprnt.o): Add back prerequisites.
5067 (callint.o): Depend on character.h.
5068
5069 * eval.c (internal_lisp_condition_case): Include the handler
5070 representation in the error message.
5071 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5072 when breaking from the loop.
5073
5074 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5075
5076 * callint.c (Fcall_interactively): When displaying error message
5077 about invalid control letter, pass the character's codepoint, not
5078 a pointer to its multibyte form. Improve display of the character
5079 in octal and display also its hex code.
5080
5081 * character.c (char_string): Use %x to display the (unsigned)
5082 codepoint of an invalid character, to avoid displaying a bogus
5083 negative value.
5084
5085 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5086 `error', not SYMBOL_NAME itself.
5087
5088 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5089 character arguments to `error'.
5090
5091 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5092 to `error' in error message about FINAL_CHAR argument. Make sure
5093 FINAL_CHAR is a character, and use %c when it is passed as
5094 argument to `error'.
5095
4ffd0d6b 50962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5097
5098 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5099
5100 * w32.c: Include <time.h>.
5101 (sys_localtime): New function.
5102
4ffd0d6b 51032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5104
5105 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5106
4ffd0d6b 5107 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5108
4ffd0d6b 51092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5110
4ffd0d6b
GM
5111 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5112 zombies (Bug#8467).
aac0c6e3 5113
04c56954
EZ
51142011-04-19 Eli Zaretskii <eliz@gnu.org>
5115
5116 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5117 gl_state.e_property when gl_state.object is Qt.
5118
5119 * insdel.c (make_gap_larger): Remove limitation of buffer size
5120 to <= INT_MAX.
5121
16a43933
CY
51222011-04-18 Chong Yidong <cyd@stupidchicken.com>
5123
5124 * xdisp.c (lookup_glyphless_char_display)
5125 (produce_glyphless_glyph): Handle cons cell entry in
5126 glyphless-char-display.
5127 (Vglyphless_char_display): Document it.
5128
5129 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5130 glyphless-char-display.
5131
4581706e
CY
51322011-04-17 Chong Yidong <cyd@stupidchicken.com>
5133
5134 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5135
5136 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5137
5138 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5139 definition for no-X builds.
5140
4887c6e2 51412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5142
fd35b6f9
PE
5143 Static checks with GCC 4.6.0 and non-default toolkits.
5144
5c1ccb01
PE
5145 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5146
006c5daa
PE
5147 * process.c (keyboard_bit_set): Define only if SIGIO.
5148 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5149 (send_process): Repair possible setjmp clobbering.
5150
efc736d3
PE
5151 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5152
4e2fe2e6
PE
5153 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5154
f97334a2
PE
5155 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5156
4e75f29d
PE
5157 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5158 Define only if needed.
5159
90efadd1
PE
5160 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5161 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5162 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5163
3c647824
PE
5164 * dispextern.h (struct redisplay_interface): Rename param
5165 to avoid shadowing.
e264f262 5166 * termhooks.h (struct terminal): Likewise.
761383f4 5167 * xterm.c (xembed_send_message): Likewise.
3c647824 5168
b58c5c4a
PE
5169 * insdel.c (make_gap_smaller): Define only if
5170 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5171
cad59032
PE
5172 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5173 it.
5174
c339dc2e
PE
5175 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5176 so that we aren't warned about unused symbols.
5177
91a3e27b
PE
5178 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5179
399c71d3 5180 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5181
8ffc96f5
PE
5182 * xfns.c (x_real_positions): Mark locals as initialized.
5183
eef9bc79
PE
5184 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5185
098db9dd
PE
5186 * xterm.c: Fix problems found by static analysis with other toolkits.
5187 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5188 (x_dispatch_event): Declare static if USE_GTK, and
5189 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5190 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5191 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5192 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5193 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5194
eb18f6cc
PE
5195 * xmenu.c (menu_help_callback): Pointer type fixes.
5196 Use const pointers when pointing at readonly data. Avoid pointer
5197 signedness clashes.
5198 (FALSE): Remove unused macro.
5199 (update_frame_menubar): Remove unused decl.
5200
1fe72bf8
PE
5201 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5202
60d9e1db
PE
5203 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5204 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5205 (single_menu_item): Rename local to avoid shadowing.
5206
39261c26
PE
5207 * keyboard.c (make_lispy_event): Remove unused local var.
5208
018c5e19
PE
5209 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5210 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5211
63d2b86e
PE
5212 * bitmaps: Change bitmaps from unsigned char back to the X11
5213 compatible char. Avoid the old compiler warnings about
5214 out-of-range initializers by using, for example, '\xab' rather
5215 than 0xab.
5216
aefd87e1
PE
5217 * xgselect.c (xgselect_initialize): Check vs interface
5218 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5219
bf501fb9
PE
5220 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5221
e9829fdf
PE
5222 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5223 to read-only memory.
5224
1086c095
PE
5225 * fns.c (vector): Remove; this old hack is no longer needed.
5226
2baccd04 5227 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5228 Remove unused var.
dde42981 5229 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5230
72391843 5231 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5232
436c16df 5233 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5234 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5235 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5236
92bb796d 5237 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5238 (x_term_init): Remove local to avoid shadowing.
92bb796d 5239
764430a3 5240 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5241
5242 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5243 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5244
d1dfb56c
EZ
52452011-04-16 Eli Zaretskii <eliz@gnu.org>
5246
c4354cb4
EZ
5247 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5248
d1dfb56c
EZ
5249 Fix regex.c, syntax.c and friends for buffers > 2GB.
5250 * syntax.h (struct gl_state_s): Declare character position members
5251 EMACS_INT.
5252
5253 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5254
04f2d78b
CB
5255 * textprop.c (verify_interval_modification, interval_of):
5256 Declare arguments EMACS_INT.
d1dfb56c
EZ
5257
5258 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5259 EMACS_INT.
5260
5261 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5262
5263 * indent.c (Fvertical_motion): Local variable it_start is now
5264 EMACS_INT.
5265
5266 * regex.c (re_match, re_match_2, re_match_2_internal)
5267 (bcmp_translate, regcomp, regexec, print_double_string)
5268 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5269 (re_compile_pattern, re_exec): Declare arguments and local
5270 variables `size_t' and `ssize_t' and return values `regoff_t', as
5271 appropriate.
5272 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5273 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5274 <compile_stack_type>: `size' and `avail' are now `size_t'.
5275
5276 * regex.h <regoff_t>: Use ssize_t, not int.
5277 (re_search, re_search_2, re_match, re_match_2): Arguments that
5278 specify buffer/string position and length are now ssize_t and
5279 size_t. Return type is regoff_t.
5280
613052cd
BK
52812011-04-16 Ben Key <bkey76@gmail.com>
5282
5283 * nsfont.m: Fixed bugs in ns_get_family and
5284 ns_descriptor_to_entity that were caused by using free to
5285 deallocate memory blocks that were allocated by xmalloc (via
5286 xstrdup). This caused Emacs to crash when compiled with
5287 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5288 --enable-checking=xmallocoverrun). xfree is now used to
5289 deallocate these memory blocks.
5290
4170f62f 52912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5292
71b41406
PE
5293 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5294
9587a89d
PE
5295 emacs_write: Accept and return EMACS_INT for sizes.
5296 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5297 et seq.
5298 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5299 Accept and return EMACS_INT.
5300 (emacs_gnutls_write): Return the number of bytes written on
5301 partial writes.
5302 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5303 (emacs_read, emacs_write): Remove check for negative size, as the
5304 Emacs source code has been audited now.
9587a89d
PE
5305 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5306 (emacs_read, emacs_write): Use it.
273a5f82
PE
5307 * process.c (send_process): Adjust to the new signatures of
5308 emacs_write and emacs_gnutls_write. Do not attempt to store
5309 a byte offset into an 'int'; it might overflow.
9587a89d 5310 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5311
3e047f51
PE
5312 * sound.c: Don't assume sizes fit in 'int'.
5313 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5314 Return EMACS_INT, not int.
3e047f51 5315 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5316 Accept EMACS_INT, not int.
5317 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5318 record read return values.
5319
cc39a9db
BK
53202011-04-15 Ben Key <bkey76@gmail.com>
5321
c9d0ec6d
JB
5322 * keyboard.c (Qundefined): Don't declare static since it is used
5323 in nsfns.m.
5324 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5325 static since they are used in nsfont.m.
cc39a9db 5326
6c60eb9f
SM
53272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5328
5329 * process.c (Qprocessp): Don't declare static.
5330 * lisp.h (Qprocessp): Declare again.
5331
7990b61a
JB
53322011-04-15 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5335
5d4cb038
PE
53362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5337
8bd7b830 5338 Improve C-level modularity by making more things 'static'.
cd64ea1d 5339
e3b27b31
PE
5340 Don't publish debugger-only interfaces to other modules.
5341 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5342 (verify_bytepos, count_markers): Move decls to the only modules
5343 that need them.
5344 * region-cache.h (pp_cache): Likewise.
5345 * window.h (check_all_windows): Likewise.
5346 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5347
5d4cb038
PE
5348 * sysdep.c (croak): Now static, if
5349 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5350 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5351
5352 * alloc.c (refill_memory_reserve): Now static if
5353 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5354 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5355
e87b6180
PE
5356 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5357 Define only if USE_LUCID.
5358
ac64929e
PE
5359 * xrdb.c (x_customization_string, x_rm_string): Now static.
5360
6f37259d
PE
5361 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5362 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5363
1683e3ab
PE
5364 * xdisp.c (draw_row_with_mouse_face): Now static.
5365 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5366
de9c2632
PE
5367 * window.h (check_all_windows): Mark externally visible.
5368
2b96acb7
PE
5369 * window.c (window_deletion_count): Now static.
5370
5371 * undo.c: Make symbols static if they're not exported.
5372 (last_undo_buffer, last_boundary_position, pending_boundary):
5373 Now static.
5374
50436f33
PE
5375 * textprop.c (interval_insert_behind_hooks): Now static.
5376 (interval_insert_in_front_hooks): Likewise.
5377
64520e5c
PE
5378 * term.c: Make symbols static if they're not exported.
5379 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5380 (max_frame_lines, tty_set_terminal_modes):
5381 (tty_reset_terminal_modes, tty_turn_off_highlight):
5382 (get_tty_terminal): Now static.
5383 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5384 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5385 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5386 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5387 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5388
1fa53021
PE
5389 * sysdep.c: Make symbols static if they're not exported.
5390 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5391 Now static.
5392 (sigprocmask_set, full_mask): Remove; unused.
5393 (wait_debugging): Mark as visible.
5394 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5395 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5396
d4b43b22
PE
5397 * syntax.c (syntax_temp): Define only if !__GNUC__.
5398
b7c513d0
PE
5399 * sound.c (current_sound_device, current_sound): Now static.
5400
989b29ad
PE
5401 * search.c (searchbufs, searchbuf_head): Now static.
5402
13a55a78
PE
5403 * scroll.c (scroll_cost): Remove; unused.
5404 * dispextern.h (scroll_cost): Remove decl.
5405
de68a1fc
PE
5406 * region-cache.h (pp_cache): Mark as externally visible.
5407
40ccffa6
PE
5408 * process.c: Make symbols static if they're not exported.
5409 (process_tick, update_tick, create_process, chan_process):
5410 (Vprocess_alist, proc_buffered_char, datagram_access):
5411 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5412 (deactivate_process): Mark defn as static, as well as decl.
5413 * lisp.h (create_process): Remove decl.
5414 * process.h (chan_process, Vprocess_alist): Remove decls.
5415
ad64fc97
PE
5416 * print.c: Make symbols static if they're not exported.
5417 (print_depth, new_backquote_output, being_printed, print_buffer):
5418 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5419 (print_interval, print_number_index, initial_stderr_stream):
5420 Now static.
5421 * lisp.h (Fprinc): Remove decl.
5422 (debug_output_compilation_hack): Mark as externally visible.
5423
adddb265
PE
5424 * sysdep.c (croak): Move decl from here to syssignal.h.
5425 * syssignal.h (croak): Put it here, so the API can be checked when
5426 'croak' is called from dissociate_if_controlling_tty.
5427
1717ede2
PE
5428 * minibuf.c: Make symbols static if they're not exported.
5429 (minibuf_save_list, choose_minibuf_frame): Now static.
5430 * lisp.h (choose_minibuf_frame): Remove decl.
5431
fa5fb2bc
PE
5432 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5433
1e3890d1
PE
5434 * lread.c: Make symbols static if they're not exported.
5435 (read_objects, initial_obarray, oblookup_last_bucket_number):
5436 Now static.
5437 (make_symbol): Remove; unused.
5438 * lisp.h (initial_obarray, make_symbol): Remove decls.
5439
8a1414fa
PE
5440 * keyboard.c: Make symbols static if they're not exported.
5441 (single_kboard, recent_keys_index, total_keys, recent_keys):
5442 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5443 (this_single_command_key_start, echoing, last_auto_save):
5444 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5445 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5446 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5447 (Vlispy_mouse_stem, double_click_count):
5448 Now static.
5449 (force_auto_save_soon): Define only if SIGDANGER.
5450 (ignore_mouse_drag_p): Now static if
5451 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5452 (print_help): Remove; unused.
5453 (stop_character, last_timer_event): Mark as externally visible.
5454 * keyboard.h (ignore_mouse_drag_p): Declare only if
5455 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5456 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5457 * lisp.h (echoing): Remove decl.
5458 (force_auto_save_soon): Declare only if SIGDANGER.
5459 * xdisp.c (redisplay_window): Simplify code, to make it more
5460 obvious that ignore_mouse_drag_p is not accessed if !defined
5461 USE_GTK && !defined HAVE_NS.
5462
93ea6e8f
PE
5463 * intervals.c: Make symbols static if they're not exported.
5464 (merge_properties_sticky, merge_interval_right, delete_interval):
5465 Now static.
5466 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5467
77382fcc
PE
5468 * insdel.c: Make symbols static if they're not exported.
5469 However, leave prepare_to_modify_buffer alone. It's never
5470 called from outside this function, but that appears to be a bug.
5471 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5472 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5473 (adjust_after_replace_noundo): Remove; unused.
5474 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5475 (signal_before_change): Remove decls.
77382fcc 5476
9306c32e
PE
5477 * indent.c (val_compute_motion, val_vmotion): Now static.
5478
cd44d2eb
PE
5479 * image.c: Make symbols static if they're not exported.
5480 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5481 if USE_GTK.
5482 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5483 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5484
ad9a7a06
PE
5485 * fringe.c (standard_bitmaps): Now static.
5486 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5487
81626931
PE
5488 * frame.c: Make symbols static if they're not exported.
5489 (x_report_frame_params, make_terminal_frame): Now static.
5490 (get_frame_param): Now static, unless HAVE_NS.
5491 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5492 (x_get_resource_string): Remove; not used.
5493 * frame.h (make_terminal_frame, x_report_frame_params):
5494 (x_get_resource_string); Remove decls.
5495 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5496 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5497
239f9db9
PE
5498 * font.c, fontset.c: Make symbols static if they're not exported.
5499 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5500 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5501 * font.c (font_close_object): Now static.
5502 * font.h (font_close_object): Remove.
5503 * fontset.c (FONTSET_OBJLIST): Remove.
5504 (free_realized_fontset) #if-0 the body, which does nothing.
5505 (face_suitable_for_char_p): #if-0, as it's never called.
5506 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5507 * xfaces.c (face_at_string_position):
5508 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5509 since 0 is always ASCII.
5510
dfcf3579
PE
5511 * fns.c (weak_hash_tables): Now static.
5512
5045092b
PE
5513 * fileio.c: Make symbols static if they're not exported.
5514 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5515 (Vwrite_region_annotation_buffers): Now static.
5516
57a96f5c
PE
5517 * eval.c: Make symbols static if they're not exported.
5518 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5519 * lisp.h (backtrace_list): Remove decl.
5520
35f08c38
PE
5521 * emacs.c: Make symbols static if they're not exported.
5522 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5523 (fatal_error_code, fatal_error_signal_hook, standard_args):
5524 Now static.
5525 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5526 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5527 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5528 * lisp.h (fatal_error_signal_hook): Remove decl.
5529 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5530
f44bd759
PE
5531 * editfns.c: Move a (normally-unused) function to its only use.
5532 * editfns.c, lisp.h (get_operating_system_release): Remove.
5533 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5534 worth the hassle of breaking this out.
5535
b532497d
PE
5536 * xterm.c: Make symbols static if they're not exported.
5537 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5538 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5539 (x_destroy_window, x_delete_display):
5540 Now static.
5541 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5542 (x_mouse_leave): Remove; unused.
5543 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5544 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5545 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5546 Remove decls.
5547 (x_mouse_leave): Declare only if WINDOWSNT.
5548 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5549 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5550 USE_X_TOOLKIT.
5551
1675728f
PE
5552 * ftxfont.c: Make symbols static if they're not exported.
5553 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5554 HAVE_FREETYPE.
5555 * font.h (ftxfont_driver): Likewise.
5556
e4cebfca
PE
5557 * xfns.c: Make symbols static if they're not exported.
5558 (x_last_font_name, x_display_info_for_name):
5559 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5560 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5561 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5562 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5563 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5564 (last_show_tip_args): Now static.
5565 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5566 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5567 (x_screen_planes): Remove; unused.
5568 * dispextern.h (x_screen_planes): Remove decl.
5569
5bf46f05
PE
5570 * dispnew.c: Make symbols static if they're not exported.
5571 * dispextern.h (redraw_garbaged_frames, scrolling):
5572 (increment_row_positions): Remove.
5573 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5574 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5575 Now static.
5576 (redraw_garbaged_frames): Remove; unused.
5577
435f4c28
PE
5578 * xfaces.c: Make symbols static if they're not exported.
5579 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5580 Remove decls.
5581 * xterm.h (defined_color): Remove decls.
5582 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5583 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5584 (menu_face_changed_default, defined_color, free_realized_face):
5585 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5586 (ascii_face_of_lisp_face): Remove; unused.
5587
8524aef3
PE
5588 * xdisp.c: Make symbols static if they're not exported.
5589 * dispextern.h (scratch_glyph_row, window_box_edges):
5590 (glyph_to_pixel_coords, set_cursor_from_row):
5591 (get_next_display_element, set_iterator_to_next):
5592 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5593 (show_mouse_face): Remove decls
5594 * frame.h (message_buf_print): Likewise.
5595 * lisp.h (pop_message, set_message, check_point_in_composition):
5596 Likewise.
5597 * xterm.h (set_vertical_scroll_bar): Likewise.
5598 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5599 (message_buf_print, scratch_glyph_row, displayed_buffer):
5600 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5601 (get_next_display_element, show_mouse_face, window_box_edges):
5602 (frame_to_window_pixel_xy, check_point_in_composition):
5603 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5604 (glyph_to_pixel_coords): Remove; unused.
5605
16390cd2
PE
5606 * dired.c (file_name_completion): Now static.
5607
5608 * dbusbind.c (xd_in_read_queued_messages): Now static.
5609
a25f4dfa
PE
5610 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5611 * data.c (circular_list_error): Remove.
5612
14a9c8df
PE
5613 * commands.h (last_point_position, last_point_position_buffer):
5614 (last_point_position_window): Remove decls.
5615 * keyboard.c: Make these variables static.
5616
04f2d78b
CB
5617 * coding.h (coding, code_convert_region, encode_coding_gap):
5618 Remove decls.
74ab6df5
PE
5619 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5620 (iso_code_class, detect_coding, code_convert_region): Now static.
5621 (encode_coding_gap): Remove; unused.
5622
38dfbee1
PE
5623 * chartab.c (chartab_chars, chartab_bits): Now static.
5624
a2cb4e63
PE
5625 * charset.h (charset_iso_8859_1): Remove decl.
5626 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5627 Now static.
5628
127198fd
PE
5629 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5630 * ccl.c (Vccl_program_table): Now static.
5631 (check_ccl_update): Remove; unused.
5632
d85b608f
PE
5633 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5634 * category.h: ... from here.
5635 * category.c (check_category_table, set_category_set): Now static.
5636
31cd66f3
PE
5637 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5638 * lisp.h: Remove these decls.
5639
c358e587
PE
5640 * buffer.c (buffer_count): Remove unused var.
5641
e78aecca
PE
5642 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5643 so that it's not optimized away.
5644 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5645 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5646 exported only to the debugger.
5647
e192d7d3 5648 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5649 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5650
92470028
PE
5651 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5652 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5653 was inaccessible from Lisp.
5654 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5655 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5656
244ed907
PE
5657 alloc.c: Import and export fewer symbols, and remove unused items.
5658 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5659 is defined.
5660 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5661 it's not optimized away by whole-program optimization.
5662 (message_enable_multibyte, free_misc): Remove.
5663 (catchlist, handlerlist, mark_backtrace):
5664 Declare only if BYTE_MARK_STACK.
5665 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5666 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5667 (message_enable_multibyte): Remove decl.
5668 (free_misc, interval_free_list, float_block, float_block_index):
5669 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5670 (cons_free_list, last_marked_index):
5671 Now static.
5672 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5673 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5674 (mark_backtrace): Define only if BYTE_MARK_STACK.
5675 * xdisp.c (message_enable_multibyte): Now static.
5676
61c2b50e 5677 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5678 This makes it easier for human readers (and static analyzers)
5679 to see whether these variables are used from other modules.
5680 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5681 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5682 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5683 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5684 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5685 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5686 * xmenu.c, xselect.c:
5687 Declare Q* vars static if they are not used in other modules.
5688 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5689 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5690 Remove decls of unexported vars.
5691 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5692
95c82688
PE
5693 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5694
16a97296
PE
5695 Make Emacs functions such as Fatom 'static' by default.
5696 This makes it easier for human readers (and static analyzers)
5697 to see whether these functions can be called from other modules.
5698 DEFUN now defines a static function. To make the function external
5699 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5700 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5701 (Finit_image_library):
16a97296
PE
5702 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5703 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5704 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5705 Remove decls, since these functions are now static.
5706 (Funintern, Fget_internal_run_time): New decls, since these functions
5707 were already external.
95c82688 5708
16a97296
PE
5709 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5710 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5711 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5712 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5713 * keyboard.c, keymap.c, lread.c:
5714 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5715 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5716 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5717 Mark functions with DEFUE instead of DEFUN,
5718 if they are used in other modules.
5719 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5720 decls for now-static functions.
5721 * buffer.h (Fdelete_overlay): Remove decl.
5722 * callproc.c (Fgetenv_internal): Mark as internal.
5723 * composite.c (Fremove_list_of_text_properties): Remove decl.
5724 (Fcomposition_get_gstring): New forward static decl.
5725 * composite.h (Fcomposite_get_gstring): Remove decl.
5726 * dired.c (Ffile_attributes): New forward static decl.
5727 * doc.c (Fdocumntation_property): New forward static decl.
5728 * eval.c (Ffetch_bytecode): New forward static decl.
5729 (Funintern): Remove extern decl; now in .h file where it belongs.
5730 * fileio.c (Fmake_symbolic_link): New forward static decl.
5731 * image.c (Finit_image_library): New forward static decl.
5732 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5733 * intervals.h (Fprevious_property_change):
5734 (Fremove_list_of_text_properties): Remove decls.
5735 * keyboard.c (Fthis_command_keys): Remove decl.
5736 (Fcommand_execute): New forward static decl.
5737 * keymap.c (Flookup_key): New forward static decl.
5738 (Fcopy_keymap): Now static.
5739 * keymap.h (Flookup_key): Remove decl.
5740 * process.c (Fget_process): New forward static decl.
5741 (Fprocess_datagram_address): Mark as internal.
5742 * syntax.c (Fsyntax_table_p): New forward static decl.
5743 (skip_chars): Remove duplicate decl.
5744 * textprop.c (Fprevious_property_change): New forward static decl.
5745 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5746 Now internal.
5747 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5748 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5749
785bbd42
PE
5750 * editfns.c (Fformat): Remove unreachable code.
5751
8b913b57
AS
57522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5753
5754 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5755 change. (Bug#8496)
5756
a6744a35
EZ
57572011-04-13 Eli Zaretskii <eliz@gnu.org>
5758
5759 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5760 when at ZV. (Bug#8487)
5761
e7974947
AS
57622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5763
baad03f0
AS
5764 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5765 (Bug#8437)
5766 * keyboard.c (parse_tool_bar_item): Likewise.
5767 * sound.c (sound_cleanup, alsa_close): Likewise.
5768 * termcap.c (tgetent): Likewise.
5769 * xfns.c (x_default_font_parameter): Likewise.
5770 * xsettings.c (read_and_apply_settings): Likewise.
5771
e7974947
AS
5772 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5773 (overrun_check_free): Protoize.
5774
28272684
PE
57752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5776
5777 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5778 since callers should never pass a negative size.
5779 Change the signature to match that of plain 'read' and 'write'; see
5780 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5781 * lisp.h: Update prototypes of emacs_write and emacs_read.
5782
11997c76
EZ
57832011-04-11 Eli Zaretskii <eliz@gnu.org>
5784
5785 * xdisp.c (redisplay_window): Don't try to determine the character
5786 position of the scroll margin if the window start point w->startp
e896f03c 5787 is outside the buffer's accessible region. (Bug#8468)
11997c76 5788
8a2cbd72
EZ
57892011-04-10 Eli Zaretskii <eliz@gnu.org>
5790
5791 Fix write-region and its subroutines for buffers > 2GB.
5792 * fileio.c (a_write, e_write): Modify declaration of arguments and
5793 local variables to support buffers larger than 2GB.
5794 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5795
5796 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5797 argument, local variables, and return value.
5798
5799 * lisp.h: Update prototypes of emacs_write and emacs_read.
5800
5801 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5802
4073e537 58032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5804
1ebfdcb6
PE
5805 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5806
b2ded58d
PE
5807 Fix more problems found by GCC 4.6.0's static checks.
5808
7d66342c
PE
5809 * xdisp.c (vmessage): Use a better test for character truncation.
5810
bbf47d44
PE
5811 * charset.c (load_charset_map): <, not <=, for optimization,
5812 and to avoid potential problems with integer overflow.
9248994d 5813 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5814 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5815 * editfns.c (Fformat): Likewise.
1e69125e 5816 * syntax.c (skip_chars): Likewise.
3befa583 5817
e3019616
PE
5818 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5819 This also lets GCC 4.6.0 generate slightly better loop code.
5820
becfa255
PE
5821 * callint.c (Fcall_interactively): <, not <=, for optimization.
5822 (Fcall_interactively): Count the number of arguments produced,
5823 not the number of arguments given. This is simpler and lets GCC
5824 4.6.0 generate slightly better code.
5825
dae0cd48
PE
5826 * ftfont.c: Distingish more carefully between FcChar8 and char.
5827 The previous code passed unsigned char * to a functions like
5828 strlen and xstrcasecmp that expect char *, which does not
5829 conform to the C standard.
5830 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5831 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5832 char * when the C standard requires it.
5833
76032d70
PE
5834 * keyboard.c (read_char): Remove unused var.
5835
eb3f1cc8
PE
5836 * eval.c: Port to Windows vsnprintf (Bug#8435).
5837 Include <limits.h>.
5838 (SIZE_MAX): Define if the headers do not.
5839 (verror): Do not give up if vsnprintf returns a negative count.
5840 Instead, grow the buffer. This ports to Windows vsnprintf, which
5841 does not conform to C99. Problem reported by Eli Zaretskii.
5842 Also, simplify the allocation scheme, by avoiding the need for
5843 calling realloc, and removing the ALLOCATED variable.
5844
70476b54
PE
5845 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5846
12020a9e
PE
5847 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5848 But keep the doprint source code for now, as we might revamp it
5849 and use it again (Bug#8435).
ea6c7ae6
PE
5850 * lisp.h (doprnt): Remove.
5851 * Makefile.in (base_obj): Remove doprnt.o.
5852 * deps.mk (doprnt.o): Remove.
5853
5fdb398c
PE
5854 error: Print 32- and 64-bit integers portably (Bug#8435).
5855 Without this change, on typical 64-bit hosts error ("...%d...", N)
5856 was used to print both 32- and 64-bit integers N, which relied on
5857 undefined behavior.
5858 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5859 New macro.
5860 * lisp.h (error, verror): Mark as printf-like functions.
5861 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5862 Report overflow in size calculations when allocating printf buffer.
5863 Do not truncate output string at its first null byte.
5864 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5865 Truncate the output at a character boundary, since vsnprintf does not
5866 do that.
5867 * charset.c (check_iso_charset_parameter): Convert internal
5868 character to string before calling 'error', since %c now has the
5869 printf meaning.
5870 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5871 overflow when computing char to be passed to 'error'. Do not
5872 pass Lisp_Object to 'error'; pass the integer instead.
5873 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5874 formatted with plain %d.
5875
b189fa66
PE
5876 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5877
bff87ef0
PE
5878 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5879
7e2cac20
PE
5880 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5881
ce4d90b5
PE
5882 * xterm.c (x_catch_errors): Remove duplicate declaration.
5883
266c9547
PE
5884 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5885
79c49ad2
PE
5886 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5887
368f4090
JM
58882011-04-10 Jim Meyering <meyering@redhat.com>
5889
5890 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5891 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5892 return ssize_t not "int", and use size_t as the buffer length.
5893 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5894 * gnutls.h: Update declarations.
5895 * process.c (read_process_output): Use ssize_t, to match.
5896 (send_process): Likewise.
5897
a32d4040
CY
58982011-04-09 Chong Yidong <cyd@stupidchicken.com>
5899
5900 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5901
8546720e 59022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5903
04f2d78b
CB
5904 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5905 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5906
8546720e
GM
5907 * xterm.c (handle_one_xevent):
5908 * xmenu.c (create_and_show_popup_menu):
5909 * xselect.c (x_decline_selection_request)
5910 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5911
0a2f5c1a 59122011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5913
5914 Fix some uses of `int' instead of EMACS_INT.
5915 * search.c (string_match_1, fast_string_match)
5916 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5917 (scan_buffer, find_next_newline_no_quit)
5918 (find_before_next_newline, search_command, Freplace_match)
5919 (Fmatch_data): Make some `int' variables be EMACS_INT.
5920
5921 * xdisp.c (display_count_lines): 3rd argument and return value now
5922 EMACS_INT. All callers changed.
5923 (pint2hrstr): Last argument is now EMACS_INT.
5924
5925 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5926 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5927 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5928 (decode_coding_utf_16, decode_coding_emacs_mule)
5929 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5930 (decode_coding_ccl, decode_coding_charset)
5931 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5932 (decode_coding_iso_2022, decode_coding_emacs_mule)
5933 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5934 <char_offset, last_offset>: Declare EMACS_INT.
5935 (encode_coding_utf_8, encode_coding_utf_16)
5936 (encode_coding_emacs_mule, encode_invocation_designation)
5937 (encode_designation_at_bol, encode_coding_iso_2022)
5938 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5939 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5940 Declare EMACS_INT.
5941 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5942 (encode_invocation_designation): Last argument P_NCHARS is now
5943 EMACS_INT.
5944 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5945 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5946
5947 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5948 All users changed.
5949
5950 * ccl.c (Fccl_execute_on_string): Declare some variables
5951 EMACS_INT.
5952
8546720e 59532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5954
5955 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5956
4e19a977
CS
59572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5958
5959 * process.c (Fformat_network_address): Doc fix.
5960
87302331
R
59612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5962
5963 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5964
cbb59342
CY
59652011-04-08 Chong Yidong <cyd@stupidchicken.com>
5966
5967 * keyboard.c (read_char): Call Lisp function help-form-show,
5968 instead of using internal_with_output_to_temp_buffer.
5969 (Qhelp_form_show): New var.
e0d38eeb 5970 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5971
5972 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5973
5974 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5975
e67a13ab
CY
59762011-04-06 Chong Yidong <cyd@stupidchicken.com>
5977
04f2d78b
CB
5978 * process.c (Flist_processes): Remove to Lisp.
5979 (list_processes_1): Delete.
e67a13ab 5980
973f782d
EZ
59812011-04-06 Eli Zaretskii <eliz@gnu.org>
5982
7c106b1e
EZ
5983 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5984
973f782d
EZ
5985 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5986
41cf7d1a 59872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5988
ca23cc88
PE
5989 Fix more problems found by GCC 4.6.0's static checks.
5990
f390e2d5
PE
5991 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5992
42eea0d0
PE
5993 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5994
b69769da 5995 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5996
f9541e84
PE
5997 * xdisp.c (vmessage): Mark as a printf-like function.
5998
13841b55
PE
5999 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6000
c136c10f
PE
6001 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6002
5e2d4a30
PE
6003 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6004 printf-like functions.
6005 (tiff_load): Add casts to remove these marks before passing them
6006 to system-supplied API.
6007
583f48b9
PE
6008 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6009
b25d760e
PE
6010 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6011 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6012 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6013 directly, rather than having caller test rule sign. This avoids
6014 some unnecessary tests.
6015 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6016 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6017 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6018
bc7b6697 6019 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6020 (xfont_open): Avoid unnecessary tests.
bc7b6697 6021
27ccc379
PE
6022 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6023
dcd5c89a
PE
6024 * composite.h, composite.c (composition_gstring_put_cache):
6025 Use EMACS_INT, not int, for length.
6026
b13a45c6
PE
6027 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6028 breaking out part of COMPOSITION_DECODE_RULE.
6029 (COMPOSITION_DECODE_RULE): Use it.
6030 * composite.c (get_composition_id): Remove unused local vars,
6031 by using the new macro.
6032
1e792e4d
PE
6033 * textprop.c (set_text_properties_1): Change while to do-while,
6034 since the condition is always true at first.
6035
dc6c6455 6036 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6037 (interval_deletion_adjustment): Return unsigned value.
6038 All uses changed.
dc6c6455 6039
aba7731a
PE
6040 * process.c (list_processes_1, create_pty, read_process_output):
6041 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6042 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6043 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6044 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6045 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6046
fdfc4bf3
PE
6047 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6048
fca8fe46 6049 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6050 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6051
06a0259a 6052 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6053 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6054 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6055
e7b9e80f
PE
6056 * print.c (print_error_message): Avoid int overflow.
6057
56201685
PE
6058 * font.c (font_list_entities): Redo for clarity,
6059 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6060
78834453 6061 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6062 (font_score): Avoid potential overflow in diff calculation.
78834453 6063
0bc0b309 6064 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6065 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6066
e610eaca
PE
6067 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6068
b895abce
PE
6069 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6070 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6071 can always succeed if overflow has undefined behavior.
6072
1f1d9321 6073 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6074 (wordify): Omit three unnecessary tests.
1f1d9321 6075
c59478bc
PE
6076 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6077 All callers changed. This avoids the need for an unused var.
6078
79b73827
PE
6079 * casefiddle.c (casify_region): Remove var that is set but not used.
6080
a4db5dfe
PE
6081 * dired.c (file_name_completion): Remove var that is set but not used.
6082
43aae36e
PE
6083 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6084
2a47c44d 6085 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6086 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6087
a37c69bf
PE
6088 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6089 Check for integer overflow on size calculations.
6090
328ab8e7
PE
6091 * buffer.c (Fprevious_overlay_change): Remove var that is set
6092 but not used.
6093
e5a2a5cb
PE
6094 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6095 Remove vars that are set but not used.
8d84a6eb 6096 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6097 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6098
a60e5f68
PE
6099 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6100
f661cb61 6101 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6102 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6103
f0397f5a
PE
6104 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6105 that are set but not used.
6106
8664db06 6107 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6108 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6109
6abdaa4a
PE
6110 * xselect.c (x_get_local_selection, x_handle_property_notify):
6111 Remove vars that are set but not used.
6112
0ce7538d 6113 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6114 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6115
9ae848fc
PE
6116 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6117 Remove var that is set but not used.
0b918413
PE
6118 (scroll_bar_windows_size): Now size_t, not int.
6119 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6120 Check for overflow.
9ae848fc 6121
a5a62657
PE
6122 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6123 (map_tty_color) [!defined MSDOS]: Likewise.
6124
5c5cdd39
PE
6125 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6126
66ebf983
PE
6127 * coding.c: Remove vars that are set but not used.
6128 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6129 All callers changed.
6130 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6131 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6132 (decode_coding_charset): Remove vars that are set but not used.
6133
1be4d761
PE
6134 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6135 that is set but not used.
6136
47553fa8
PE
6137 * print.c (print_object): Remove var that is set but not used.
6138
1f7196bf 6139 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6140 The gnulib version avoids calling malloc in the usual case,
6141 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6142 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6143 * filelock.c (current_lock_owner): Likewise.
6144 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6145 * sysdep.c: Include allocator.h, careadlinkat.h.
6146 (emacs_no_realloc_allocator): New static constant.
6147 (emacs_readlink): New function.
fdb61804
PE
6148 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6149 ../lib/careadlinkat.h.
d1fdcab7 6150
f84c17c7
SM
61512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6152
6153 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6154 first non-nil return value).
6155
ef3862ad
JD
61562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6157
6158 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6159 if not defined (Bug#8403).
6160
376a7006
JB
61612011-04-02 Juanma Barranquero <lekktu@gmail.com>
6162
6163 * xdisp.c (display_count_lines): Remove parameter `start',
6164 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6165 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6166 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6167 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6168 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6169 and thereabouts. All callers changed.
6170 (get_per_char_metric): Remove parameter `f', unused since
6171 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6172
6ca3801d
JM
61732011-04-02 Jim Meyering <meyering@redhat.com>
6174
6175 do not dereference NULL upon failed strdup
6176 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6177 (ns_get_family): Likewise.
6178
d8e2b5ba
JB
61792011-04-02 Juanma Barranquero <lekktu@gmail.com>
6180
6181 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6182
8c74fcbd
JD
61832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6184
6185 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6186 later (Bug#8403).
6187
7200d79c
SM
61882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6189
03408648 6190 Add lexical binding.
7200d79c 6191
03408648
SM
6192 * window.c (Ftemp_output_buffer_show): New fun.
6193 (Fsave_window_excursion):
6194 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6195
6196 * lread.c (lisp_file_lexically_bound_p): New function.
6197 (Fload): Bind Qlexical_binding.
6198 (readevalloop): Remove `evalfun' arg.
6199 Bind Qinternal_interpreter_environment.
6200 (Feval_buffer): Bind Qlexical_binding.
6201 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6202 Mark as dynamic.
6203 (syms_of_lread): Declare `lexical-binding'.
6204
6205 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6206
6207 * keyboard.c (eval_dyn): New fun.
6208 (menu_item_eval_property): Use it.
ca105506
SM
6209
6210 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6211
03408648
SM
6212 * fns.c (concat, mapcar1): Accept byte-code-functions.
6213
6214 * eval.c (Fsetq): Handle lexical vars.
6215 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6216 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6217 (FletX, Flet): Obey lexical binding.
6218 (Fcommandp): Handle closures.
6219 (Feval): New `lexical' arg.
6220 (eval_sub): New function extracted from Feval. Use it almost
6221 everywhere where Feval was used. Look up vars in lexical env.
6222 Handle closures.
6223 (Ffunctionp): Move from subr.el.
6224 (Ffuncall): Handle closures.
6225 (apply_lambda): Remove `eval_flags'.
6226 (funcall_lambda): Handle closures and new byte-code-functions.
6227 (Fspecial_variable_p): New function.
6228 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6229 but without exporting it to Lisp.
23aba0ea 6230
23aba0ea 6231 * doc.c (Fdocumentation, store_function_docstring):
03408648 6232 * data.c (Finteractive_form): Handle closures.
23aba0ea 6233
03408648
SM
6234 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6235 interactive spec.
ba83908c 6236
04f2d78b
CB
6237 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6238 New byte-codes.
03408648
SM
6239 (exec_byte_code): New function extracted from Fbyte_code to handle new
6240 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6241
03408648 6242 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6243
03408648 6244 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6245
e2abce01
JB
62462011-03-31 Juanma Barranquero <lekktu@gmail.com>
6247
6248 * xdisp.c (redisplay_internal): Fix prototype.
6249
63696a73 62502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6251
63696a73 6252 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6253 (try_scrolling): Use it when setting scroll_limit.
6254 Limit scrolling to 100 screen lines.
63696a73
EZ
6255 (redisplay_window): Even when falling back on "recentering",
6256 position point in the window according to scroll-conservatively,
6257 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6258
6259 (try_scrolling): When point is above the window, allow searching
6260 as far as scroll_max, or one screenful, to compute vertical
6261 distance from PT to the scroll margin position. This prevents
6262 try_scrolling from unnecessarily failing when
6263 scroll-conservatively is set to a value slightly larger than the
6264 window height. Clean up the case of PT below the margin at bottom
6265 of window: scroll_max can no longer be INT_MAX. When aggressive
6266 scrolling is in use, don't let point enter the opposite scroll
6267 margin as result of the scroll.
6268 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6269 threshold of 100 lines for never-recentering scrolling.
6270
e4cc2dfc
JB
62712011-03-31 Juanma Barranquero <lekktu@gmail.com>
6272
6273 * dispextern.h (move_it_by_lines):
6274 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6275 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6276 (message_log_check_duplicate): Remove parameters `prev_bol' and
6277 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6278 (redisplay_internal): Remove parameter `preserve_echo_area',
6279 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6280
6281 * indent.c (Fvertical_motion):
6282 * window.c (window_scroll_pixel_based, Frecenter):
6283 Don't pass `need_y_p' to `move_it_by_lines'.
6284
1c470562
SM
62852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6286
44f230aa
SM
6287 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6288 steal a few bits to be more compact.
6289 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6290 Remove unneeded casts.
6291
1c470562
SM
6292 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6293
888adce9
ZK
62942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6295
6296 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6297 binding" message (bug#7967).
6298
f838ed7b
PE
62992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6300
77861b95
PE
6301 Fix more problems found by GCC 4.6.0's static checks.
6302
de6dbc14
PE
6303 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6304 Remove unused local var.
6305
f838ed7b
PE
6306 * editfns.c (Fmessage_box): Remove unused local var.
6307
792c7b2b
PE
6308 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6309 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6310 Omit unused local vars.
c499e557 6311 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6312 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6313 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6314 Omit unused local var.
6315
ba0165e1
PE
6316 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6317 Don't assume string length fits in int.
32ad8845 6318 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6319 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6320
3c59b4c9
PE
6321 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6322 instead of alloca (Bug#8344).
6323
a3eed478 6324 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6325 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6326
eb4d412d
PE
6327 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6328
1658b401
PE
6329 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6330 concerns.
6331
6332 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6333
6334 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6335
9a2c6e05
PE
6336 * keyboard.c (syms_of_keyboard): Use the same style as later
6337 in this function when indexing through an array. This also
6338 works around GCC bug 48267.
6339
03d0a109
PE
6340 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6341
44f730c8
PE
6342 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6343
fe75f926
PE
6344 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6345 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6346
ffa8c828
PE
6347 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6348 This avoids undefined behavior on integer overflow, and is a bit
6349 more convenient anyway since it is compared to a size_t variable.
6350
c5101a77
PE
6351 Variadic C functions now count arguments with size_t, not int.
6352 This avoids an unnecessary limitation on 64-bit machines, which
6353 caused (substring ...) to crash on large vectors (Bug#8344).
6354 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6355 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6356 All variadic functions and their callers changed accordingly.
c5101a77
PE
6357 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6358 * data.c (arith_driver, float_arith_driver): Likewise.
6359 * editfns.c (general_insert_function): Likewise.
6360 * eval.c (struct backtrace.nargs, interactive_p)
6361 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6362 (funcall_lambda, mark_backtrace): Likewise.
6363 * fns.c (concat): Likewise.
6364 * frame.c (x_set_frame_parameters): Likewise.
6365 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6366 0 if not found, not -1. All callers changed.
6367
dd3f25f7
PE
6368 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6369 (stack_copy_size): Now size_t, not int.
6370 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6371
461c2ab9
JB
63722011-03-28 Juanma Barranquero <lekktu@gmail.com>
6373
6374 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6375 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6376 All callers changed.
6377
6378 * lisp.h (multibyte_char_to_unibyte):
6379 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6380 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6381 * character.h (CHAR_TO_BYTE8):
6382 * cmds.c (internal_self_insert):
6383 * editfns.c (general_insert_function):
6384 * keymap.c (push_key_description):
6385 * search.c (Freplace_match):
6386 * xdisp.c (message_dolog, set_message_1): All callers changed.
6387
f6d62986
SM
63882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6389
6390 * keyboard.c (safe_run_hook_funcall): New function.
6391 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6392 don't set the hook to nil, but remove the offending function instead.
6393 (Qcommand_hook_internal): Remove, unused.
6394 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6395 Vcommand_hook_internal.
6396
6397 * eval.c (enum run_hooks_condition): Remove.
6398 (funcall_nil, funcall_not): New functions.
6399 (run_hook_with_args): Call each function through a `funcall' argument.
6400 Remove `cond' argument, now redundant.
6401 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6402 (Frun_hook_with_args_until_failure): Adjust accordingly.
6403 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6404
1db5b1ad
JB
64052011-03-28 Juanma Barranquero <lekktu@gmail.com>
6406
6407 * dispextern.h (string_buffer_position): Remove declaration.
6408
6409 * print.c (strout): Remove parameter `multibyte', unused since
6410 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6411
6412 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6413 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6414 All callers changed.
6415
6416 * w32.c (_wsa_errlist): Use braces for struct initializers.
6417
6418 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6419 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6420 All callers changed.
6421 (string_buffer_position): Likewise. Also, make static (it's never
6422 used outside xdisp.c).
6423 (cursor_row_p): Remove parameter `w', unused since
6424 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6425 (decode_mode_spec): Remove parameter `precision', introduced during
6426 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6427 All callers changed.
6428
5ffb62aa
JD
64292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6430
6431 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6432
461c2ab9 64332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6434
6435 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6436 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6437 (ns_update_auto_hide_menu_bar): New functions.
6438 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6439 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6440 ns_constrain_all_frames.
6441 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6442 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6443
5c380ffb
JD
64442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6445
6446 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6447
9af30bdf
GM
64482011-03-27 Glenn Morris <rgm@gnu.org>
6449
6450 * syssignal.h: Replace RETSIGTYPE with void.
6451 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6452 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6453 Replace SIGTYPE with void everywhere.
6454 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6455 * s/template.h (SIGTYPE): Remove commented out definition.
6456
e2abce01
JB
64572011-03-26 Eli Zaretskii <eliz@gnu.org>
6458
6459 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6460 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6461
f868cd8a
JB
64622011-03-26 Juanma Barranquero <lekktu@gmail.com>
6463
59eb0929
JB
6464 * w32.c (read_unc_volume): Use parameter `henum', instead of
6465 global variable `wget_enum_handle'.
6466
6467 * keymap.c (describe_vector): Remove parameters `indices' and
6468 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6469 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6470
f868cd8a
JB
6471 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6472
6473 * keyboard.c (timer_check): Remove parameter `do_it_now',
6474 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6475 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6476 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6477
6478 * keyboard.c (read_char):
6479 * w32menu.c (w32_menu_display_help):
6480 * xmenu.c (show_help_event, menu_help_callback):
6481 Adjust calls to `show_help_echo'.
6482
6483 * gtkutil.c (xg_maybe_add_timer):
6484 * keyboard.c (readable_events):
6485 * process.c (wait_reading_process_output):
6486 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6487
6488 * insdel.c (adjust_markers_gap_motion):
6489 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6490 (gap_left, gap_right): Don't call it.
6491
2ecf6fdb
CY
64922011-03-25 Chong Yidong <cyd@stupidchicken.com>
6493
6494 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6495 incurred during fontification.
6496
6b1f9ba4
JB
64972011-03-25 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6500 (DEFVAR_PER_BUFFER): Don't pass it.
6501
6502 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6503 (scrolling_window): Don't pass it.
6504
0f4a96b5
JB
65052011-03-25 Juanma Barranquero <lekktu@gmail.com>
6506
6507 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6508
6509 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6510 and `suffix'.
6511 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6512 of variables specific to SELinux and computation of `encoded_absname'.
6513
6514 * image.c (XPutPixel): Remove unused variable `height'.
6515
6516 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6517
6518 * unexw32.c (get_section_info): Remove unused variable `section'.
6519
6520 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6521 (system_process_attributes): Remove unused variable `sess'.
6522 (sys_read): Remove unused variable `err'.
6523
6524 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6525 (w32_wnd_proc): Remove unused variable `isdead'.
6526 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6527 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6528 (x_create_tip_frame): Remove unused variable `tem'.
6529
6530 * w32inevt.c (w32_console_read_socket):
6531 Remove unused variable `no_events'.
6532
6533 * w32term.c (x_draw_composite_glyph_string_foreground):
6534 Remove unused variable `width'.
6535
1149507c
JB
65362011-03-24 Juanma Barranquero <lekktu@gmail.com>
6537
6538 * w32term.c (x_set_glyph_string_clipping):
6539 Don't pass uninitialized region to CombineRgn.
6540
9c88f339
JB
65412011-03-23 Juanma Barranquero <lekktu@gmail.com>
6542
6543 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6544 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6545 (Fx_close_connection): Remove unused variable `i'.
6546
6547 * w32font.c (w32font_draw): Return number of glyphs.
6548 (w32font_open_internal): Remove unused variable `i'.
6549 (w32font_driver): Add missing initializer.
6550
6551 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6552 (fill_in_menu): Remove unused variable `items_added'.
6553
6554 * w32term.c (last_mouse_press_frame): Remove static global variable.
6555 (w32_clip_to_row): Remove unused variable `f'.
6556 (x_delete_terminal): Remove unused variable `i'.
6557
6558 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6559 (NOTHING): Remove unused static global variable.
6560 (uniscribe_check_otf): Remove unused variable `table'.
6561 (uniscribe_font_driver): Add missing initializers.
6562
dee091a3
JD
65632011-03-23 Julien Danjou <julien@danjou.info>
6564
6565 * term.c (Fsuspend_tty, Fresume_tty):
6566 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6567 * window.c (temp_output_buffer_show):
6568 * insdel.c (signal_before_change):
6569 * frame.c (Fhandle_switch_frame):
6570 * fileio.c (Fdo_auto_save):
6571 * emacs.c (Fkill_emacs):
6572 * editfns.c (save_excursion_restore):
6573 * cmds.c (internal_self_insert):
6574 * callint.c (Fcall_interactively):
6575 * buffer.c (Fkill_all_local_variables):
6576 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6577 Use Frun_hooks.
0f4a96b5 6578 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6579 unconditionnaly since it does the check itself.
6580
2c520ab5 65812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6582
c9c49752
PE
6583 Fix more problems found by GCC 4.5.2's static checks.
6584
8abc3f12
PE
6585 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6586 the first time through the loop, since we know p0 < p1 then.
6587 This also avoids a gcc -Wstrict-overflow warning.
6588
a2d26660
PE
6589 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6590 leading to a memory leak, possible in functions like
6591 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6592 of objects (Bug#8318).
a2d26660 6593
916c72e9
PE
6594 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6595 that could (at least in theory) be that large.
6596
19ab8a18
PE
6597 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6598 This is less likely to overflow, and avoids undefined behavior if
6599 overflow does occur. All callers changed. Use strtoul to scan
6600 for the unsigned long integer.
b7cbbd6f
PE
6601 (pint2hrstr): Simplify and tune code slightly.
6602 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6603
f0641eff
PE
6604 * scroll.c (do_scrolling): Work around GCC bug 48228.
6605 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6606
7f650bb9
PE
6607 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6608 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6609 (validate_x_resource_name): Simplify count usage.
6610 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6611
37dd57d1
PE
6612 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6613 fail (Bug#8306).
81e56e61 6614
699979fc 6615 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6616
401bf9b4
PE
6617 * process.c (Fmake_network_process): Use socklen_t, not int,
6618 where POSIX says socklen_t is required in portable programs.
6619 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6620 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6621 (Fmake_network_process, server_accept_connection):
6622 (wait_reading_process_output, read_process_output):
6623 Likewise.
6624
b93aacde
PE
6625 * process.c: Rename or move locals to avoid shadowing.
6626 (list_processes_1, Fmake_network_process):
6627 (read_process_output_error_handler, exec_sentinel_error_handler):
6628 Rename or move locals.
4dc343ee 6629 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6630 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6631 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6632 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6633 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6634
af8a867c 6635 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6636 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6637 Include tparam.h instead, since it declares them.
af8a867c
PE
6638 * cm.h (PC): Remove extern decl; tparam.h now does this.
6639 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6640 * terminfo.c: Include tparam.h, to check interfaces.
6641 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6642 (tparam): Adjust signature to match interface in tparam.h;
6643 this removes some undefined behavior. Check that outstring and len
6644 are zero, which they always are with Emacs.
6645 * tparam.h (PC, BC, UP): New extern decls.
6646
0248044d 6647 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6648 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6649
8ff096c1 6650 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6651 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6652 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6653 (ftfont_list): Remove unused local.
49eaafba
PE
6654 (get_adstyle_property, ftfont_pattern_entity):
6655 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6656 Rename locals to avoid shadowing.
8ff096c1 6657
e2be39f6
PE
6658 * xfont.c (xfont_list_family): Mark var as initialized.
6659
c9735e30
PE
6660 * xml.c (make_dom): Now static.
6661
8f5201ae
PE
6662 * composite.c (composition_compute_stop_pos): Rename local to
6663 avoid shadowing.
b246f932
PE
6664 (composition_reseat_it): Remove unused locals.
6665 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6666 (composition_update_it): Mark var as initialized.
11b61122
PE
6667 (find_automatic_composition): Mark vars as initialized,
6668 with a FIXME (Bug#8290).
8f5201ae 6669
760fbc2c
PE
6670 character.h: Rename locals to avoid shadowing.
6671 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6672 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6673 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6674 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6675 to avoid shadowing.
6676
ff08eb85
PE
6677 * textprop.c (property_change_between_p): Remove; unused.
6678
fc7bf025
PE
6679 * intervals.c (interval_start_pos): Now static.
6680
235d7abc
PE
6681 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6682
44f230aa
SM
6683 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6684 Rename locals to avoid shadowing.
3e7d6594 6685
50060332
PE
6686 * sound.c (wav_play, au_play, Fplay_sound_internal):
6687 Fix pointer signedness.
d01f234b 6688 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6689 (wav_play): Initialize a variable to 0, to prevent undefined
6690 behavior (Bug#8278).
50060332 6691
c4fc4e30
PE
6692 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6693
918436ed
PE
6694 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6695
c939f91b
PE
6696 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6697 clobbering (Bug#8298).
b9c7f648
PE
6698 * sysdep.c (sys_subshell): Likewise.
6699 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6700
6bd8c144
PE
6701 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6702 This should get cleaned up, so that child_setup has the
6703 same signature on all platforms.
6704
7710357c 6705 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6706 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6707
c59da222
CY
67082011-03-22 Chong Yidong <cyd@stupidchicken.com>
6709
6710 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6711 not to be necessary, and produces flickering.
6712
66b87493
GM
67132011-03-20 Glenn Morris <rgm@gnu.org>
6714
6715 * config.in: Remove file.
6716
45b6f6d5
JB
67172011-03-20 Juanma Barranquero <lekktu@gmail.com>
6718
6719 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6720 are now in src/globals.h.
6721 (syms_of_minibuf): Remove spurious & from previous change.
6722
3ec03f7e
LL
67232011-03-20 Leo <sdl.web@gmail.com>
6724
6725 * minibuf.c (completing-read-function): New variable.
6726 (completing-read-default): Rename from completing-read.
6727 (completing-read): Call completing-read-function.
6728
b14e3e21
CY
67292011-03-19 Juanma Barranquero <lekktu@gmail.com>
6730
6731 * xfaces.c (Fx_load_color_file):
6732 Read color file from absolute filename (bug#8250).
6733
f2b726e6
JB
67342011-03-19 Juanma Barranquero <lekktu@gmail.com>
6735
6736 * makefile.w32-in: Update dependencies.
6737
09f6ff02
EZ
67382011-03-17 Eli Zaretskii <eliz@gnu.org>
6739
6740 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6741
29a6015a
PE
67422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6743
a3a6c54e
PE
6744 Fix more problems found by GCC 4.5.2's static checks.
6745
b766f867
PE
6746 * process.c (make_serial_process_unwind, send_process_trap):
6747 (sigchld_handler): Now static.
6748
be02381c
PE
6749 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6750 That way, the code declares only the vars that it needs.
6751 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6752 * s/cygwin.h (PTY_ITERATION): Likewise.
6753 * s/darwin.h (PTY_ITERATION): Likewise.
6754 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6755
57048744
PE
6756 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6757 * process.c (allocate_pty): Don't declare stb unless it's needed.
6758
7914961c 6759 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6760 (CONSTANTLIM): Remove; unused.
6761 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6762 Define only if needed.
7914961c 6763
b3967b18
PE
6764 * unexelf.c (unexec): Name an expression,
6765 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6766 Use a different way to cause a compilation error if anyone uses
6767 n rather than nn, a way that does not involve shadowing.
73366a00 6768 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6769
29a6015a
PE
6770 * deps.mk (unexalpha.o): Remove; unused.
6771
43cfc33e 6772 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6773 * unexec.h: New file.
ce701a33
PE
6774 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6775 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6776 Depend on unexec.h.
6777 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6778 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6779 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6780 Change as necessary to match prototype in unexec.h.
ce701a33 6781
01f44d5a
PE
6782 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6783 shadowing.
4f63c6bb 6784 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6785
a6670b0b
PE
6786 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6787 Rename locals to avoid shadowing.
6788
cef2010d 6789 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6790 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6791
d4d7173a
PE
6792 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6793
f08b802a
PE
6794 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6795 warning when compiling print.c.
6796
3ddb0639
PE
6797 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6798 instead of using an uninitialized var.
5ad03b97 6799 (font_sort_entities): Mark var as initialized.
3ddb0639 6800
170a2692
PE
6801 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6802
e663c700
PE
6803 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6804 pointers to constants.
89bc529a 6805 (font_parse_fcname): Remove unused vars.
7b81e2d0 6806 (font_delete_unmatched): Now static.
ea838e10 6807 (font_get_spec): Remove; unused.
13a547c6
PE
6808 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6809 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6810 Rename or move locals to avoid shadowing.
e663c700 6811
2a80c887 6812 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6813 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6814
1384fa33 6815 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6816 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6817
8b2c52e9
PE
6818 * alloc.c (mark_backtrace): Move decl from here ...
6819 * lisp.h: ... to here, so that it can be checked.
6820
475545b5 6821 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6822 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6823 (lisp_indirect_variable): Name an expression,
6824 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6825 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6826
b1349114 6827 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6828 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6829 Use const pointer when appropriate.
b1349114 6830
a2928364
PE
6831 * lisp.h (get_system_name, get_operating_system_release):
6832 Move decls here, to check interfaces.
6833 * process.c (get_operating_system_release): Move decl to lisp.h.
6834 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6835 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6836 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6837 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6838 (Fformat_time_string, Fencode_time, Finsert_char):
6839 (Ftranslate_region_internal, Fformat):
6840 Rename or remove local vars to avoid shadowing.
9710023e 6841 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6842
a415e694
PE
6843 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6844 avoid shadowing.
6845
8ef4622d
PE
6846 * lisp.h (eassert): Check that the argument compiles, even if
6847 ENABLE_CHECKING is not defined.
6848
946f9a5b
PE
6849 * data.c (Findirect_variable): Name an expression, to avoid
6850 gcc -Wbad-function-cast warning.
112396d6 6851 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6852 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6853 (Fmake_variable_buffer_local, Fmake_local_variable):
6854 Mark variables as initialized.
52746918 6855 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6856
e5aab7e7 6857 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6858 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6859 Rename locals to avoid shadowing.
dff45157
PE
6860 (mark_stack): Move local variables into the #ifdef region where
6861 they're used.
7bc26fdb
PE
6862 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6863 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6864 needed otherwise.
6865 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6866 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6867 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6868
e5aab7e7
PE
6869 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6870 avoids undefined behavior in theory.
6871
4da60324
PE
6872 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6873
88043301
PE
6874 Use functions, not macros, for up- and down-casing (Bug#8254).
6875 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6876 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6877 to use the following functions instead of these macros.
6878 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6879 EMACS_INT, since callers assume the returned value fits in int.
6880 (upcase1): Likewise, for UPCASE_TABLE.
6881 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6882 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6883 the race-condition problem in the old DOWNCASE.
88043301 6884
19ed5445
PE
6885 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6886 Rename locals to avoid shadowing.
6887 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6888 (regex_compile, re_search_2, re_match_2_internal):
6889 Remove unused local vars.
952db0d7
PE
6890 (FREE_VAR): Rewrite so as not to use empty "else",
6891 which gcc can warn about.
da053e48 6892 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6893 (RETALLOC_IF): Define only if needed.
6894 (WORDCHAR_P): Likewise. This one is never needed, but is used
6895 only in a comment talking about a compiler bug, so put inside
6896 the #if 0 of that comment.
6897 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6898 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6899 Remove; unused.
19ed5445 6900
1f3561e4 6901 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6902 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6903 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6904
ded6f8f7
PE
6905 * search.c (simple_search): Remove unused var.
6906
dbd37a95
PE
6907 * dired.c (compile_pattern): Move decl from here ...
6908 * lisp.h: ... to here, so that it can be checked.
6909 (struct re_registers): New forward decl.
6910
7e47afad
PE
6911 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6912
85f24f61
PE
6913 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6914 All uses changed.
6915 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6916 Rename locals to avoid shadowing.
5671df8f 6917 (Fvertical_motion): Mark locals as initialized.
85f24f61 6918
181aa2be 6919 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6920 (casify_region): Mark local as initialized.
181aa2be 6921
930d429c
PE
6922 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6923
7082eac6
PE
6924 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6925 New macros, so that the caller can use some names other than
6926 gcpro1, gcpro2, etc.
6927 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6928 of the new macros.
6929 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6930 argument, for consistency with GCPRO2_VAR, etc: it is now the
6931 prefix of the variable, not the variable itself. All uses
6932 changed.
38b2c076
PE
6933 * dired.c (directory_files_internal, file_name_completion):
6934 Rename locals to avoid shadowing.
6935
15206ed9
PE
6936 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6937 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6938 dired.c's scmp function, had undefined behavior.
6939 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6940 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6941 * buffer.h: ... to here, because these macros use current_buffer,
6942 and the new implementation with inline functions needs to have
6943 current_buffer in scope now, rather than later when the macros
6944 are used.
6945 (downcase, upcase1): New static inline functions.
6946 (DOWNCASE, UPCASE1): Reimplement using these functions.
6947 This avoids undefined behavior in expressions like
6948 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6949 from race conditions in accessing the global variables
6950 case_temp1 and case_temp2.
6951 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6952 * lisp.h (case_temp1, case_temp2): Remove their decls.
6953 * character.h (ASCII_CHAR_P): Move from here ...
6954 * lisp.h: ... to here, so that the inline functions mentioned
6955 above can use them.
6956
4a6bea26
PE
6957 * dired.c (directory_files_internal_unwind): Now static.
6958
f14b7e14
PE
6959 * fileio.c (file_name_as_directory, directory_file_name):
6960 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6961 Now static.
2893f146
PE
6962 (file_name_as_directory): Use const pointers when appropriate.
6963 (Fexpand_file_name): Likewise. In particular, newdir might
6964 point at constant storage, so make it a const pointer.
fd4ead52 6965 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6966 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6967 signedness issues.
f839df0c
PE
6968 (Fset_file_times, Finsert_file_contents, auto_save_error):
6969 Rename locals to avoid shadowing.
f14b7e14 6970
5716756e 6971 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6972 (Ftry_completion, Fall_completions): Rename or remove locals
6973 to avoid shadowing.
5716756e 6974
b4c3046a
PE
6975 * marker.c (bytepos_to_charpos): Remove; unused.
6976
b45db522
PE
6977 * lisp.h (verify_bytepos, count_markers): New decls,
6978 so that gcc does not warn that these functions aren't declared.
6979
85876d07
PE
6980 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6981 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6982 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6983 (copy_text): Remove unused local var.
85876d07 6984
03d78a21 6985 * filelock.c (within_one_second): Now static.
b3dd38ab 6986 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6987
5df8f01b
PE
6988 * buffer.c (fix_overlays_before): Mark locals as initialized.
6989 (fix_start_end_in_overlays): Likewise. This function should be
6990 simplified by using pointers-to-pointers, but that's a different
6991 matter.
b1d876f1 6992 (switch_to_buffer_1): Now static.
8f54f30a
PE
6993 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6994 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6995
a70072c9 6996 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6997 Fix pointer signedness issue.
edced198
PE
6998 (sys_subshell): Mark local as volatile if checking for lint,
6999 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7000 (MAXPATHLEN): Define only if needed.
a70072c9 7001
a0977c44
PE
7002 * process.c (serial_open, serial_configure): Move decls from here ...
7003 * systty.h: ... to here, so that they can be checked.
7004
a884fdcc
PE
7005 * fns.c (get_random, seed_random): Move extern decls from here ...
7006 * lisp.h: ... to here, so that they can be checked.
7007
604efe86 7008 * sysdep.c (reset_io): Now static.
b8950c94 7009 (wait_for_termination_signal): Remove; unused.
604efe86 7010
38fc62d9
PE
7011 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7012 (copy_keymap_item, append_key, push_text_char_description):
7013 Now static.
1004a21a 7014 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7015 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7016 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7017 (describe_map_tree):
7018 Rename locals to avoid shadowing.
38fc62d9 7019
2f2650da
PE
7020 * keyboard.c: Declare functions static if they are not used elsewhere.
7021 (echo_char, echo_dash, cmd_error, top_level_2):
7022 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7023 (read_char, kbd_buffer_get_event, make_lispy_position):
7024 (make_lispy_event, make_lispy_movement, apply_modifiers):
7025 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7026 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7027 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7028 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7029 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7030
a053e86c 7031 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7032 (mark_kboards): Move decl here ...
7033 * alloc.c (mark_kboards): ... from here.
a053e86c 7034
4752793e
PE
7035 * lisp.h (force_auto_save_soon): New decl.
7036
74f10ca7 7037 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7038 (DEFINE_DUMMY_FUNCTION): New macro.
7039 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7040 Use it.
c03cd23f
PE
7041 (main): Add casts to avoid warnings
7042 if GCC considers string literals to be constants.
74f10ca7 7043
022e70d4
PE
7044 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7045
59d6fe83
PE
7046 * dbusbind.c: Pointer signedness fixes.
7047 (xd_signature, xd_append_arg, xd_initialize):
7048 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7049 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7050 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7051 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7052
78320123
PE
7053 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7054 if GCC considers string literals to be constants.
49cebcca 7055 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7056
35ac2a97
SM
70572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7058
fb103ca9
SM
7059 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7060 (print_preprocess, print_object): New macro to fix last change.
7061
35ac2a97
SM
7062 * print.c (print_preprocess): Don't forget font objects.
7063
62973b41
JB
70642011-03-16 Juanma Barranquero <lekktu@gmail.com>
7065
7066 * emacs.c (USAGE3): Doc fixes.
7067
0e48bb22
AS
70682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7069
7070 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7071 structure.
7072
7684e57b
JB
70732011-03-14 Juanma Barranquero <lekktu@gmail.com>
7074
7075 * lisp.h (VWindow_system, Qfile_name_history):
7076 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7077 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7078 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7079
7080 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7081 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7082
7083 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7084 * w32console.c (detect_input_pending, read_input_pending)
7085 (encode_terminal_code):
7086 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7087 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7088 (w32_system_caret_y, Qfile_name_history):
7089 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7090 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7091 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7092 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7093 * w32proc.c (Qlocal, report_file_error):
7094 * w32term.c (Vwindow_system, updating_frame):
7095 * w32uniscribe.c (initialized, uniscribe_font_driver):
7096 Remove unneeded extern declarations.
7097
2aa46d6c
CY
70982011-03-14 Chong Yidong <cyd@stupidchicken.com>
7099
c96bbc66 7100 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7101
cffc6f3b
CY
71022011-03-13 Chong Yidong <cyd@stupidchicken.com>
7103
7104 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7105 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7106 These macros can no longer be used for assignment.
7107
44f230aa
SM
7108 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7109 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7110 (record_buffer_markers, fetch_buffer_markers): New functions for
7111 recording and fetching special buffer markers.
7112 (set_buffer_internal_1, set_buffer_temp): Use them.
7113
7114 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7115
7116 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7117
7118 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7119 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7120
7121 * xdisp.c (hscroll_window_tree):
7122 (reconsider_clip_changes): Use PT instead of BUF_PT.
7123
d251f04b
EZ
71242011-03-13 Eli Zaretskii <eliz@gnu.org>
7125
7126 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7127 $(EMACS_ROOT)/lib/intprops.h.
7128
f0c77cd1
PE
71292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7130
3eca4629
PE
7131 Fix more problems found by GCC 4.5.2's static checks.
7132
7c86ee98
PE
7133 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7134 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7135 (xg_free_frame_widgets): Make it clear that a local variable is
7136 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7137 (gdk_window_get_screen): Make it clear that this macro is needed
7138 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7139 (int_gtk_range_get_value): New function, which avoids a diagnostic
7140 from gcc -Wbad-function-cast.
7141 (xg_set_toolkit_scroll_bar_thumb): Use it.
7142 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7143 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7144 (get_utf8_string, xg_get_file_with_chooser):
7145 Rename locals to avoid shadowing.
7146 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7147
41729b81
PE
7148 * xgselect.c (xg_select): Remove unused var.
7149
f0c77cd1
PE
7150 * image.c (four_corners_best): Mark locals as initialized.
7151 (gif_load): Initialize transparent_p to zero (Bug#8238).
7152 Mark another local as initialized.
ec6cf4c6 7153 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7154
ce0ad53d 7155 * image.c (clear_image_cache): Now static.
d5d5a617 7156 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7157 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7158 (x_edge_detection): Remove unnecessary cast that
7159 gcc -Wbad-function-cast diagnoses.
2037898d 7160 (gif_load): Fix pointer signedness.
6ae141d6
PE
7161 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7162 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7163
33383987 71642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7165
d32df629
PE
7166 Improve quality of tests for time stamp overflow.
7167 For example, without this patch (encode-time 0 0 0 1 1
7168 1152921504606846976) returns the obviously-bogus value (-948597
7169 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7170 reports time overflow. See
7171 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7172 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7173 * editfns.c: Include limits.h and intprops.h.
7174 (TIME_T_MIN, TIME_T_MAX): New macros.
7175 (time_overflow): Move earlier, to before first use.
7176 (hi_time, lo_time): New functions, for an accurate test for
7177 out-of-range times.
7178 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7179 (Fget_internal_run_time): Don't assume time_t fits in int.
7180 (make_time): Use list2 instead of Fcons twice.
7181 (Fdecode_time): More accurate test for out-of-range times.
7182 (check_tm_member): New function.
7183 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7184 (lisp_time_argument): Don't rely on undefined left-shift and
7185 right-shift behavior when checking for time stamp overflow.
8be6f318 7186
fe31d94c
PE
7187 * editfns.c (time_overflow): New function, refactoring common code.
7188 (Fformat_time_string, Fdecode_time, Fencode_time):
7189 (Fcurrent_time_string): Use it.
7190
8be6f318
PE
7191 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7192 * dired.c (make_time): Move to ...
7193 * editfns.c (make_time): ... here.
7194 * systime.h: Note the move.
7195
09d9db2c 71962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7197
126bc0dc
YM
7198 * fringe.c (update_window_fringes): Remove unused variables.
7199
c47cbdfd
YM
7200 * unexmacosx.c (copy_data_segment): Also copy __got section.
7201 (Bug#8223)
7202
7ac80be9
EZ
72032011-03-12 Eli Zaretskii <eliz@gnu.org>
7204
c96bbc66 7205 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7206 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7207 Constify `char *' arguments and their references according to
7208 prototypes in tparam.h.
7209
ecb0f94d 7210 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7211
7ac80be9
EZ
7212 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7213 Adapt all references accordingly.
7214
7215 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7216
ef1fd07e
TT
72172011-03-11 Tom Tromey <tromey@redhat.com>
7218
7219 * buffer.c (syms_of_buffer): Remove obsolete comment.
7220
7ef4b50c
EZ
72212011-03-11 Eli Zaretskii <eliz@gnu.org>
7222
7223 * termhooks.h (encode_terminal_code): Declare prototype.
7224
7225 * msdos.c (encode_terminal_code): Don't declare prototype.
7226
7227 * term.c (encode_terminal_code): Now external again, used by
7228 w32console.c and msdos.c.
7229
44f230aa
SM
7230 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7231 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7232
4b1ec863 72332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7234
1714f52b 7235 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7236
4b1ec863
PE
7237 * fringe.c (update_window_fringes): Mark locals as initialized
7238 (Bug#8227).
7239 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7240
524c7aa6
PE
7241 * alloc.c (mark_fringe_data): Move decl from here ...
7242 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7243 to check its interface.
7244 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7245
a5c0af81 7246 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7247 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7248 (fontset_font): Mark local as initialized.
a9a06e0b 7249 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7250
b4716021
PE
7251 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7252
811e9bac 7253 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7254 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7255 (x_own_selection, Fx_disown_selection_internal): Rename locals
7256 to avoid shadowing.
7257 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7258
7e3ab302
PE
7259 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7260 so that the caller can use some name other than gcpro1.
7261 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7262 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7263 (Fx_backspace_delete_keys_p):
7264 Use them to avoid shadowing, and rename vars to avoid shadowing.
7265 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7266 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7267 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7268 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7269 Remove unused locals.
7e3ab302
PE
7270 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7271 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7272 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7273 macros.
f78faa98 7274
e2b13473
PE
7275 * xterm.h (x_mouse_leave): New decl.
7276
77f23912
PE
7277 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7278 Remove unused functions.
cdf4ba58
PE
7279 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7280 (x_calc_absolute_position): Now static.
7411c686 7281 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7282 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7283 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7284 unless they are used.
38d0b34a
PE
7285 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7286 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7287 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7288 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7289 (x_error_catcher, x_connection_closed, x_error_handler):
7290 (x_error_quitter, xembed_send_message, x_iconify_frame):
7291 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7292 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7293 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7294
44f230aa
SM
7295 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7296 Rename or move locals to avoid shadowing.
6b463e58 7297 (tty_defined_color, merge_face_heights): Now static.
5967d051 7298 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7299 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7300 does not deduce is never used uninitialized.
73719eba
PE
7301 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7302 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7303
426994c3 7304 * terminal.c (store_terminal_param): Now static.
5489860b 7305
032f1620 7306 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7307 (set_frame_menubar): Remove unused local.
d4323972 7308 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7309 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7310 since they might point to immutable storage.
281585b0
PE
7311 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7312 since it's unused otherwise.
032f1620 7313
367c19e5 7314 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7315 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7316 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7317 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7318 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7319 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7320 does not deduce are never used uninitialized.
70739cbe 7321
07b48fa9
PE
7322 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7323
8868a238 7324 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7325 * window.c (window_loop, size_window):
7326 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7327
7e5cf297 7328 * window.c (display_buffer): Now static.
d6550a9f
PE
7329 (size_window): Mark variables that gcc -Wuninitialized
7330 does not deduce are never used uninitialized.
a586633d
PE
7331 * window.h (check_all_windows): New decl, to forestall
7332 gcc -Wmissing-prototypes diagnostic.
5b555da1 7333 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7334
f6095868
PE
7335 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7336 shadowing.
7337 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7338 Include <limits.h>.
7339 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7340 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7341 (load_charset_map): Mark variables that gcc -Wuninitialized
7342 does not deduce are never used uninitialized.
53df7c11 7343 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7344
f38b440c
PE
7345 * coding.c (coding_set_source, coding_set_destination):
7346 Use "else { /* comment */ }" rather than "else /* comment */;"
7347 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7348 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7349 a block, when the outer 'i' will do.
7350 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7351 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7352 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7353 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7354 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7355 Rename locals to avoid shadowing.
7356 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7357 * coding.c (emacs_mule_char, encode_invocation_designation):
7358 Now static, since they're not used elsewhere.
413bb2db 7359 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7360 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7361 (decode_coding_emacs_mule): Mark variables that gcc
7362 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7363 (detect_coding_iso_2022): Initialize a local variable that might
7364 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7365 this initialization is needed. (Bug#8211)
5f58e762
PE
7366 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7367 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7368 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7369 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7370 Remove unused macros.
f38b440c 7371
232b38b9 7372 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7373 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7374 * character.c (string_count_byte8): Likewise.
232b38b9 7375
fb90da1b
PE
7376 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7377 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7378
fb93dbc2
PE
7379 * chartab.c (copy_sub_char_table): Now static, since it's not used
7380 elsewhere.
5c156ace
PE
7381 (sub_char_table_ref_and_range, char_table_ref_and_range):
7382 Rename locals to avoid shadowing.
bbcd0949 7383 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7384
7d3b3862 7385 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7386 (BIDI_BOB): Remove unused macro.
7d3b3862 7387
6be7d3da
PE
7388 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7389 deduce are never used uninitialized.
c2ed9c8b 7390 * term.c (encode_terminal_code): Likewise.
6be7d3da 7391
75f8807f 7392 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7393
50938595
PE
7394 * tparam.h: New file.
7395 * term.c, tparam.h: Include it.
7396 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7397 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7398 Move these decls to tparam.h, and make them agree with what
7399 is actually in tparam.c. The previous trick of using incompatible
7400 decls in different modules does not conform to the C standard.
7401 All callers of tparam changed to use tparam's actual API.
7402 * tparam.c (tparam1, tparam, tgoto):
7403 Use const pointers where appropriate.
7404
fbceeba2
PE
7405 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7406 * cm.h (struct cm): Likewise.
7407 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7408 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7409 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7410 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7411 (turn_on_face, init_tty): Likewise.
7412 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7413
7f3f1250
PE
7414 * term.c (term_mouse_position): Rename local to avoid shadowing.
7415
e6ca6543
PE
7416 * alloc.c (mark_ttys): Move decl from here ...
7417 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7418
c40f8d15
AS
74192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7420
7421 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7422
cfe0661d
JB
74232011-03-09 Juanma Barranquero <lekktu@gmail.com>
7424
7425 * search.c (compile_pattern_1): Remove argument regp, unused since
7426 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7427 (compile_pattern): Don't pass it.
7428
0afb4571
J
74292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7430
7431 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7432 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7433 for ! HAVE_GTK3.
7434 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7435
7436 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7437
7438 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7439 gdk_window_get_screen, gdk_window_get_geometry,
7440 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7441 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7442 (xg_get_pixbuf_from_pixmap): New function.
7443 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7444 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7445 Call xg_get_pixbuf_from_pixmap instead of
7446 gdk_pixbuf_get_from_drawable.
7447 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7448 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7449 (xg_check_special_colors): Use GtkStyleContext and its functions
7450 for HAVE_GTK3.
7451 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7452 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7453 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7454 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7455 Call gtk_widget_get_preferred_size.
0afb4571
J
7456 (xg_frame_resized): gdk_window_get_geometry only takes 5
7457 parameters.
44f230aa
SM
7458 (xg_win_to_widget, xg_event_is_for_menubar):
7459 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7460 (xg_set_widget_bg): New function.
7461 (delete_cb): New function.
895009e1 7462 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7463 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7464 (xg_set_background_color): Call xg_set_widget_bg.
7465 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7466 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7467 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7468 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7469 if ! HAVE_GTK3.
7470 (update_frame_tool_bar): Call gtk_widget_hide.
7471 (xg_initialize): Use GDK_KEY_g.
7472
7473 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7474 if ! HAVE_GTK3
7475 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7476
7477 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7478 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7479 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7480
1c2cc4ef
JB
74812011-03-08 Juanma Barranquero <lekktu@gmail.com>
7482
7483 * w32xfns.c (select_palette): Check success of RealizePalette against
7484 GDI_ERROR, not zero.
7485
33383987 7486See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7487
7488;; Local Variables:
7489;; coding: utf-8
aac0c6e3
MR
7490;; End:
7491
33383987 7492 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7493
7494 This file is part of GNU Emacs.
7495
7496 GNU Emacs is free software: you can redistribute it and/or modify
7497 it under the terms of the GNU General Public License as published by
7498 the Free Software Foundation, either version 3 of the License, or
7499 (at your option) any later version.
7500
7501 GNU Emacs is distributed in the hope that it will be useful,
7502 but WITHOUT ANY WARRANTY; without even the implied warranty of
7503 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7504 GNU General Public License for more details.
7505
7506 You should have received a copy of the GNU General Public License
7507 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.