* lisp/gnus/gnus-win.el (gnus-configure-frame): Don't signal an error when
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4b2addb7
DA
12012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * window.h (clip_changed): Remove useless declaration.
4
584461b2
JB
52012-05-22 Juanma Barranquero <lekktu@gmail.com>
6
7 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
8 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
9
34374650
PE
102012-05-22 Paul Eggert <eggert@cs.ucla.edu>
11
12 Remove src/m/*.
13 This directory predates autoconf and is no longer needed nowadays.
14 Move its few remaining bits of functionality to where they're needed.
15 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
16 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
17 * m/template.h: Remove.
18 * Makefile.in (M_FILE): Remove. All uses removed.
19 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
20 * lisp.h (USE_LSB_TAG):
21 * mem-limits.h (EXCEEDS_LISP_PTR):
22 Use VAL_MAX, not VALBITS, in #if.
23 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
24 (EMACS_UINT): Define unconditionally now.
25 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
26 (BITS_PER_EMACS_INT): New constants, replacing
27 what used to be in config.h, but not useful in #if.
28 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
29 define them any more.
30 (VAL_MAX): New macro.
31 (VALMASK): Use it.
32 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
33 BITS_PER_EMACS_INT, in #if.
34 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
35 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
36 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
37 * s/ms-w32.h (DATA_START):
38 Move here from removed file m/intel386.h.
39 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
40 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
41
261cb4bb
PE
422012-05-21 Paul Eggert <eggert@cs.ucla.edu>
43
44 Assume C89 or later.
45 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
46 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
47 (xrealloc):
48 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
49 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
50 * textprop.c, tparam.c (NULL): Remove.
51 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
52 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
53 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
54 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
55 * xterm.c (input_signal_count): Assume volatile works.
56
ff23cd9f
KB
572012-05-21 Ken Brown <kbrown@cornell.edu>
58
59 * xgselect.c (xg_select): Fix first argument in call to 'select'
60 (bug#11508).
61
1b170bc6
KB
622012-05-20 Ken Brown <kbrown@cornell.edu>
63
64 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 65 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 66
b2f4d39f
KB
672012-05-19 Ken Brown <kbrown@cornell.edu>
68
69 * xfns.c (x_in_use): Remove `static' qualifier.
70 * xterm.h (x_in_use): Declare.
71 * xgselect.c: Include xterm.h.
72 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
73 and `display_arg' (bug#9754).
74
003fdae2
PE
752012-05-19 Paul Eggert <eggert@cs.ucla.edu>
76
9232a6d9
PE
77 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
78
003fdae2
PE
79 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
80 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
81
784b56e2
EZ
822012-05-18 Eli Zaretskii <eliz@gnu.org>
83
84 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
85
86 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
87 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
88
89 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
90 reference to image_cache->refcount.
91 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
92
a0a79cde
JL
932012-05-17 Juri Linkov <juri@jurta.org>
94
95 * search.c (Fword_search_regexp, Fword_search_backward)
96 (Fword_search_forward, Fword_search_backward_lax)
97 (Fword_search_forward_lax): Move functions to isearch.el
98 (bug#10145, bug#11381).
99
b0572523
PE
1002012-05-16 Paul Eggert <eggert@cs.ucla.edu>
101
102 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
103
9660f5fc
SM
1042012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
105
106 * lread.c (init_obarray): Declare Qt and Qnil as special.
107
4374de83
GM
1082012-05-14 Glenn Morris <rgm@gnu.org>
109
110 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 111 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 112
dc44c39a
PE
1132012-05-14 Paul Eggert <eggert@cs.ucla.edu>
114
078c97cb
PE
115 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
116
dc44c39a
PE
117 * unexaix.c: Port to more-recent AIX compilers.
118 (report_error, report_error_1, make_hdr, copy_sym)
119 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
120 Make arguments const char *, not char *, to avoid violations of C
121 standard and to fix some AIX warnings reported by Gilles Pion.
122
e18afed7 1232012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
124
125 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
126 already have overlays loaded.
127 (handle_single_display_spec): Before returning without displaying
128 fringe bitmap, synchronize the bidi iterator with the main display
129 iterator, by calling iterate_out_of_display_property.
130 (iterate_out_of_display_property): Detect buffer iteration by
131 testing that it->string is a Lisp string.
132 (get_next_display_element): When the current object is exhausted,
133 and there's something on it->stack, call set_iterator_to_next to
134 proceed with what's on the stack, instead of returning zero.
135 (set_iterator_to_next): If called at the end of a Lisp string,
136 proceed to consider_string_end without incrementing string
137 position. Don't increment display vector index past the end of
138 the display vector. (Bug#11417)
c8fb9dc6
EZ
139 (pos_visible_p): Don't report a position visible when move_it_to
140 stopped at the last line of window, which happens to be scanned
141 backwards by the bidi iteration. (Bug#11464)
ac268e67 142
e18afed7 1432012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
144
145 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
146 and right-margin display specs even if the spec is invalid or we
147 are on a TTY, and thus unable to display on the fringes. That's
148 because the text with the property will not be displayed anyway,
149 so we need to signal to the caller that this is a "replacing"
150 display spec. This fixes display when the spec is invalid or we
151 are on a TTY.
152
e18afed7 1532012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
154
155 * unexaix.c (make_hdr): Fix typo in prototype.
156 This bug broke the build on AIX. Problem reported by Gilles Pion.
157
9d0a235a
MA
1582012-05-14 Michael Albinus <michael.albinus@gmx.de>
159
160 * keyboard.c (kbd_buffer_get_event): Read special events also in
161 batch mode. (Bug#11415)
162
9e6b06ed
GM
1632012-05-12 Glenn Morris <rgm@gnu.org>
164
165 * ns.mk: Update for ns_appbindir no longer having trailing "/".
166
c1a1d7a3
EZ
1672012-05-12 Eli Zaretskii <eliz@gnu.org>
168
169 * lisp.mk (lisp): Add newcomment.elc.
170
3fe7cdc8
GM
1712012-05-12 Glenn Morris <rgm@gnu.org>
172
173 * Makefile.in (MKDIR_P): New, set by configure.
174 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
175
53f7d2c0
PE
1762012-05-11 Paul Eggert <eggert@cs.ucla.edu>
177
178 Remove unused function hourglass_started.
179 * dispextern.h (hourglass_started):
180 * w32fns.c (hourglass_started):
181 * xdisp.c (hourglass_started): Remove.
182
75aafb17
JB
1832012-05-10 Juanma Barranquero <lekktu@gmail.com>
184
185 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
186 Update dependencies.
187
12959e8e
PE
1882012-05-10 Paul Eggert <eggert@cs.ucla.edu>
189
97107e2e
PE
190 * xgselect.c (xg_select): Put maxfds+1 into a var.
191 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
192
12959e8e
PE
193 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
194
836d29b3
DA
1952012-05-10 Dave Abrahams <dave@boostpro.com>
196
197 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
198 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
199
5cb67954
MA
2002012-05-09 Michael Albinus <michael.albinus@gmx.de>
201
202 * dbusbind.c (xd_registered_buses): New internal Lisp object.
203 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
204 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
205 Initialize xd_registered_buses.
206
3478ec45
PE
2072012-05-09 Paul Eggert <eggert@cs.ucla.edu>
208
b263a6b0
PE
209 Untag more efficiently if USE_LSB_TAG.
210 This is based on a proposal by YAMAMOTO Mitsuharu in
211 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
212 For an admittedly artificial (nth 8000 longlist) benchmark on
213 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
214 Emacs's overall text size by 1%.
215 * lisp.h (XUNTAG): New macro.
216 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
217 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
218 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
219 * eval.c (Fautoload):
220 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
221 * frame.h (XFRAME): Use XUNTAG.
222
3478ec45
PE
223 Port recent dbusbind.c changes to 32-bit --with-wide-int.
224 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
225 Remove unportable assumptions about print widths of types like
226 dbus_uint32_t.
227 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
228 intptr_t when converting between pointer and integer, to avoid GCC
229 warnings about wrong width.
230
666b903b 2312012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
232
233 * w32proc.c (new_child): Force Windows to reserve only 64KB of
234 stack for each reader_thread, instead of defaulting to 8MB
235 determined by the linker. This avoids failures in creating
236 subprocesses on Windows 7, see the discussion in this thread:
237 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
238
b120cc17
JC
2392012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
240
241 Fix up display of the *Minibuf-0* buffer in the mini window.
242 * keyboard.c (read_char): Don't clear the echo area if there's no
243 message to clear.
244 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 245 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 246
9a4b36f8
MA
2472012-05-07 Michael Albinus <michael.albinus@gmx.de>
248
249 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
250 batch mode.
251
e5f9458f
CY
2522012-05-06 Chong Yidong <cyd@gnu.org>
253
254 * lisp.mk (lisp): Update.
255
eceeb5fc 2562012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
257
258 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
259
71873e2b
SM
2602012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
261
262 * data.c (PUT_ERROR): New macro.
263 (syms_of_data): Use it. Add new error type `user-error'.
264 * undo.c (user_error): New function.
265 (Fprimitive_undo): Use it.
266 * print.c (print_error_message): Adjust print style for `user-error'.
267 * keyboard.c (user_error): New function.
268 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
269
ab0fa4e4
PE
2702012-05-03 Paul Eggert <eggert@cs.ucla.edu>
271
272 Do not limit current-time-string to years 1000..9999.
273 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
274 (Fcurrent_time_string): Support any year that is supported by the
275 underlying localtime representation. Don't use asctime, as it
276 has undefined behavior for years outside the range -999..9999.
277
7ed806a7
PE
2782012-05-02 Paul Eggert <eggert@cs.ucla.edu>
279
280 Fix race conditions involving setenv, gmtime, localtime, asctime.
281 Without this fix, interrupts could mess up code that uses these
282 nonreentrant functions, since setting TZ invalidates existing
283 tm_zone or tzname values, and since most of these functions return
284 pointers to static storage.
285 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
286 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
287 Grow the critical sections to include not just invoking
288 localtime/gmtime, but also accessing these functions' results
289 including their tm_zone values if any, and any related TZ setting.
290 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
291 so that the struct tm is saved in the critical section.
292 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
293 motivated by the fact that memory allocation needs to be outside
294 the critical section.
295
0c16dfed
DA
2962012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
297
298 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
299 with RESET_INTERVAL.
300
301 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
302 Remove duplicated buffer name initialization.
303
3f83ace8
JM
3042012-05-02 Jim Meyering <jim@meyering.net>
305
306 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
307
c7b8541e
JM
308 * xfns.c (x_window): Use xstrdup (Bug#11375).
309
90207a15 3102012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
311
312 * xdisp.c (pos_visible_p): If already at a newline from the
313 display string before the 'while' loop, don't walk back the glyphs
314 from it3.glyph_row. Solves assertion violation when the display
315 string begins with a newline (egg.el). (Bug#11367)
316
b593d6a9
AH
3172012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
318
319 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
320 Move to simple.el.
321
4737362e
GM
3222012-05-01 Glenn Morris <rgm@gnu.org>
323
99cf43f9
GM
324 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
325 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
326 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
327 All were removed before 23.1.
328
9311dcff
GM
329 * dispnew.c: Remove HAVE_LIBNCURSES test;
330 it is always true on relevant platforms.
331
4d5c6349
GM
332 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
333 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
334
4737362e
GM
335 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
336
74dd3a6b
AS
3372012-04-30 Andreas Schwab <schwab@linux-m68k.org>
338
339 * .gdbinit (xpr): Remove checks for no longer existing misc types.
340 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
341 Remove.
342
13c379ee
PE
3432012-04-28 Paul Eggert <eggert@cs.ucla.edu>
344
345 Do not avoid creating empty evaporating overlays (Bug#9642).
346 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
347 That is, do not delete an evaporating overlay if it becomes
348 empty after its bounds are adjusted to fit within its buffer.
349 This fix caused other problems, and I'm reverting it until we get
350 to the bottom of them.
351
a8e7d6d7 3522012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
353
354 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
355
a8e7d6d7 3562012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
357
358 * xdisp.c (pos_visible_p): If the window start position is beyond
359 ZV, start the display from buffer beginning. Prevents assertion
360 violation in init_iterator when the minibuffer window is scrolled
361 via the scroll bar.
362
363 * window.c (window_scroll_pixel_based): Likewise.
364
a8e7d6d7 3652012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
366
367 * keymap.c (where_is_internal): Doc fix (Bug#10872).
368
a8e7d6d7 3692012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
370
371 * fileio.c (Fcopy_file, Fset_file_selinux_context):
372 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
373
a8e7d6d7 3742012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 375
b593d6a9
AH
376 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
377 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 378
1c6900d9
EZ
3792012-04-26 Eli Zaretskii <eliz@gnu.org>
380
4c3fa1d9
EZ
381 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
382 display element, check also the underlying string or buffer
383 character. (Bug#11341)
384
1c6900d9
EZ
385 * w32menu.c: Include w32heap.h.
386 (add_menu_item): If the call to AppendMenuW (via
387 unicode_append_menu) fails, disable Unicode menus only if we are
388 running on Windows 9X/Me.
389
42bf8205
AS
3902012-04-24 Andreas Schwab <schwab@linux-m68k.org>
391
392 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
393 (xgetint): Add missing shift for LSB tags.
394
b1bac16e
MR
3952012-04-24 Martin Rudalics <rudalics@gmx.at>
396
397 * keyboard.c (read_char): Don't wipe echo area for select window
398 events: These might get delayed via `mouse-autoselect-window'
399 (Bug#11304).
400
d69621cc
JB
4012012-04-24 Juanma Barranquero <lekktu@gmail.com>
402
403 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
404 manipulation of :loaded-from data.
405
02fd101b
JB
4062012-04-23 Juanma Barranquero <lekktu@gmail.com>
407
408 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
409 now a cons (bug#11311).
410
888bec30
PE
4112012-04-23 Paul Eggert <eggert@cs.ucla.edu>
412
89a438bd
PE
413 Do not create empty overlays with the evaporate property (Bug#9642).
414 * buffer.c (Fmove_overlay): Delete an evaporating overlay
415 if it becomes empty after its bounds are adjusted to fit within
416 its buffer. Without this fix, in a nonempty buffer (let ((o
417 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
418 yields an empty overlay that has the evaporate property, which is
419 not supposed to happen.
420
1068fe4d
PE
421 Fix minor GTK3 problems found by static checking.
422 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
423 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
424 (struct _EmacsFixedClass, emacs_fixed_get_type):
425 Move decls here from emacsgtkfixed.h, since they needn't be public.
426 (emacs_fixed_get_type): Now static.
427 (emacs_fixed_class_init): Omit unused local.
428 (emacs_fixed_child_type): Remove; unused.
429 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
430 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
431 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
432 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
433 (EMACS_FIXED_GET_CLASS): Remove; unused.
434 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
435
888bec30
PE
436 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
437 Problem reported by Juanma Barranquero for Windows -Wunused-function.
438
de85e130
PE
4392012-04-22 Paul Eggert <eggert@cs.ucla.edu>
440
d0baac98 441 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 442 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
443 (__malloc_size_t, __malloc_ptrdiff_t):
444 Remove. All uses removed, replaced by the definiens if needed,
445 since we can assume C89 or better now.
446 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
447 (protect_malloc_state, align, get_contiguous_space)
448 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
449 (malloc_atfork_handler_child, malloc_enable_thread)
450 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
451 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
452 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
453 (special_realloc, _realloc_internal_nolock, _realloc_internal)
454 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
455 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
456 Define using prototypes, not old style.
457 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
458 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
459 (align): Don't assume that signed integer overflow wraps around.
460 Omit unused local var.
461 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
462 (_free_internal_nolock, memalign, mallochook, reallochook):
463 Omit no-longer-needed casts.
464 (valloc): Use getpagesize, not __getpagesize.
465 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
466 (struct hdr): The 'magic' member is now size_t, not unsigned long.
467
de85e130
PE
468 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
469
dcbf5805
MA
4702012-04-22 Michael Albinus <michael.albinus@gmx.de>
471
472 Move functions from C to Lisp. Make non-blocking method calls
473 the default. Implement further D-Bus standard interfaces.
474
475 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
476 (QCdbus_request_name_allow_replacement)
477 (QCdbus_request_name_replace_existing)
478 (QCdbus_request_name_do_not_queue)
479 (QCdbus_request_name_reply_primary_owner)
480 (QCdbus_request_name_reply_in_queue)
481 (QCdbus_request_name_reply_exists)
482 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
483 (QCdbus_registered_serial, QCdbus_registered_method)
484 (QCdbus_registered_signal): New Lisp objects.
485 (XD_DEBUG_MESSAGE): Use sizeof.
486 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
487 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
488 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
489 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
490 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
491 (xd_signature, xd_append_arg): Allow float for integer types.
492 (xd_get_connection_references): New function.
b593d6a9
AH
493 (xd_get_connection_address): Rename from xd_initialize.
494 Return cached address.
dcbf5805
MA
495 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
496 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
497 level.
498 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 499 Return number of refcounts.
dcbf5805
MA
500 (Fdbus_get_unique_name): Make stronger parameter check.
501 (Fdbus_message_internal): New defun.
502 (Fdbus_call_method, Fdbus_call_method_asynchronously)
503 (Fdbus_method_return_internal, Fdbus_method_error_internal)
504 (Fdbus_send_signal, Fdbus_register_service)
505 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
506 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
507 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
508 (Vdbus_compiled_version, Vdbus_runtime_version)
509 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
510 (Vdbus_message_type_method_return, Vdbus_message_type_error)
511 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
512 (Vdbus_registered_buses, Vdbus_registered_objects_table):
513 Adapt docstring.
dcbf5805 514
52828e02
PE
5152012-04-22 Paul Eggert <eggert@cs.ucla.edu>
516
da05bc4c
PE
517 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
518 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
519 Do not assume ptrdiff_t is the same width as 'int'.
520
52828e02
PE
521 * alloc.c: Handle unusual debugging option combinations.
522 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
523 since the two debugging options are incompatible.
524 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
525 is defined.
526 (mem_init, mem_insert, mem_insert_fixup):
527 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
528 (NEED_MEM_INSERT): Remove; no longer needed.
529
f01769f9
LL
5302012-04-22 Leo Liu <sdl.web@gmail.com>
531
532 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
533
5790543d
PE
5342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
535
536 * sysdep.c [__FreeBSD__]: Minor cleanups.
537 (list_system_processes, system_process_attributes) [__FreeBSD__]:
538 Use Emacs indenting style more consistently. Avoid some casts.
539 Use 'double' consistently rather than mixing 'float' and 'double'.
540
b91b7e4d
EW
5412012-04-21 Eduard Wiebe <usenet@pusto.de>
542
b593d6a9
AH
543 * sysdep.c (list_system_processes, system_process_attributes):
544 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 545
6114eb15
AS
5462012-04-21 Andreas Schwab <schwab@linux-m68k.org>
547
548 * lisp.mk (lisp): Update.
549
2f38dff7
PE
5502012-04-20 Paul Eggert <eggert@cs.ucla.edu>
551
552 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
553 It is never used otherwise.
554
4ae29f89
SM
5552012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
556
557 * print.c (print_preprocess): Only check print_depth if print-circle
558 is nil.
559 (print_object): Check for cycles even when print-circle is nil and
560 print-gensym is t, but only check print_depth if print-circle is nil.
561
f30d612a
CY
5622012-04-20 Chong Yidong <cyd@gnu.org>
563
564 * process.c (wait_reading_process_output): If EIO occurs on a pty,
565 set the status to "failed" and ensure that sentinel is run.
566
c07a4c0b 5672012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
568
569 * process.c (Fset_process_inherit_coding_system_flag)
570 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 571 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 572
c07a4c0b 5732012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
574
575 * xdisp.c (string_buffer_position_lim): Limit starting position to
576 BEGV.
577 (set_cursor_from_row): If called for a mode-line or header-line
578 row, return zero immediately.
579 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
580 farther than the first row after the header line, if any.
581 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
582 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
583
c07a4c0b 5842012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 585
4ae29f89
SM
586 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
587 (bug#11238).
ad3a2b41 588
c07a4c0b 5892012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 5902012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
591
592 configure: new option --enable-gcc-warnings (Bug#11207)
593 * Makefile.in (C_WARNINGS_SWITCH): Remove.
594 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
595 (ALL_CFLAGS): Use new macros rather than old.
596 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
597 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
598 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
599 -Wunused-result, -Wunused-variable. This should go away once
600 the Emacs and Gnulib regex code is merged.
601 (xmalloc, xrealloc): Now static.
602
aba027e8
PE
6032012-04-17 Paul Eggert <eggert@cs.ucla.edu>
604
605 * dired.c (Fsystem_groups): Remove unused local.
606
e5a36063
GM
6072012-04-17 Glenn Morris <rgm@gnu.org>
608
609 * dired.c (Fsystem_users): Doc fix.
610
316411f0
DA
6112012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
612
613 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
614 (syms_of_dired): Add them.
615
9426aba4
PE
6162012-04-16 Paul Eggert <eggert@cs.ucla.edu>
617
b62a57be
PE
618 Fix minor alloc.c problems found by static checking.
619 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
620 New extern decls, to avoid calling undeclared functions.
621 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
622 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
623 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
624 (NEED_MEM_INSERT): New macro.
625 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 626 Remove one incorrect comment and fix another.
b62a57be 627
3539f31f
PE
628 Fix minor ralloc.c problems found by static checking.
629 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
630 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
631 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
632 (r_alloc_sbrk): Now static.
633
a041960a
PE
634 Improve ralloc.c interface checking.
635 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
636 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
637 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
638 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
639 [REL_ALLOC]: ... to here, to check interface.
640 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
641 Remove decls. This fixes an "It stinks!".
642
9426aba4
PE
643 * alloc.c (which_symbols): Fix alignment issue / type clash.
644
d55c12ed
AS
6452012-04-15 Andreas Schwab <schwab@linux-m68k.org>
646
647 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
648 (struct Lisp_Misc_Any): Likewise.
649 (struct Lisp_Free): Likewise.
650 * alloc.c (union aligned_Lisp_Symbol): Define.
651 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
652 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
653 (union aligned_Lisp_Misc): Define.
654 (MARKER_BLOCK_SIZE, struct marker_block): Use union
655 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 656 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 657
b948ce8b
PE
6582012-04-14 Paul Eggert <eggert@cs.ucla.edu>
659
660 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
661 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
662 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
663 * s/netbsd.h, s/sol2-6.h:
664 Remove definition of GC_MARK_STACK, since the default now works.
665 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
666 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
667 no longer the default.
668 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
669
35dc09a1 6702012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 671
35dc09a1
GM
672 * lread.c (lisp_file_lexically_bound_p):
673 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 674
35dc09a1
GM
6752012-04-14 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
678 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
679
6802012-04-14 Jan Djärv <jan.h.d@swipnet.se>
681
682 * nsterm.m (constrainFrameRect): Always constrain when there is only
683 one screen (Bug#10962).
684
bcd86815
KB
6852012-04-13 Ken Brown <kbrown@cornell.edu>
686
687 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
688
c25df26e
RT
6892012-04-13 Reuben Thomas <rrt@sc3d.org>
690
691 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
692
0fc59f1e
DC
6932012-04-11 Daniel Colascione <dancol@dancol.org>
694
695 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
696 against is gone. It's better to use vfork now so that when Cygwin
697 gains a new, working vfork, we use it automatically (bug#10398).
698
de8c03dc
SM
6992012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
700
701 * window.c (save_window_save): Obey window-point-insertion-type.
702
2f097256
GM
7032012-04-11 Glenn Morris <rgm@gnu.org>
704
705 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
706
453b951e
SM
7072012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
708
709 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
710
75f1671a 7112012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
712
713 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
714 (force_quit_count): New var.
715 (handle_interrupt): Use it.
716
2a8ce227
JB
7172012-04-10 Juanma Barranquero <lekktu@gmail.com>
718
719 * w32.c (w32_delayed_load): Record the full path of the library
720 being loaded (bug#10424).
721
935396c0
GM
7222012-04-09 Glenn Morris <rgm@gnu.org>
723
05920a43
GM
724 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
725 not just in the obarray, before snarfing them. (Bug#11036)
726
935396c0
GM
727 * Makefile.in ($(leimdir)/leim-list.el):
728 Pass EMACS rather than BUILT_EMACS.
729
a18ecafa
TZ
7302012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
731
732 * process.c (make_process):
733 * process.h: Add integer `gnutls_handshakes_tried' member to
734 process struct.
735
6bbef4e5
JC
736 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
737 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
738
739 * gnutls.c (gnutls_log_function2i): Convenience log function.
740 (emacs_gnutls_read): Use new log functions,
741 `gnutls_handshakes_tried' process member, and
742 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
743 attempts per process (connection).
744
b4d3bc10
CY
7452012-04-09 Chong Yidong <cyd@gnu.org>
746
747 * eval.c (Fuser_variable_p, user_variable_p_eh)
748 (lisp_indirect_variable): Functions deleted.
749 (Fdefvar): Caller changed.
750
751 * callint.c (Finteractive, Fcall_interactively):
752 * minibuf.c (Fread_variable): Callers changed.
753
70f4d973
EZ
7542012-04-09 Eli Zaretskii <eliz@gnu.org>
755
756 * xdisp.c (set_cursor_from_row): If the display string appears in
757 the buffer at position that is closer to point than the position
758 after the display string, display the cursor on the first glyph of
759 the display string. Fixes cursor display when a 'display' text
760 property immediately follows invisible text. (Bug#11094)
761
cb3c2e3e
PE
7622012-04-09 Paul Eggert <eggert@cs.ucla.edu>
763
764 composite.c: use 'double' consistently
765 * composite.c (get_composition_id): Use 'double' consistently
766 instead of converting 'float' to 'double' and vice versa; this is
767 easier to understand and avoids a GCC warning.
768
fd06db5d
GM
7692012-04-09 Glenn Morris <rgm@gnu.org>
770
50fe702a
GM
771 * Makefile.in: Generate leim-list with bootstrap-emacs, in
772 preparation for dumping it with emacs. (Bug#4789)
773 (leimdir): New variable.
774 ($(leimdir)/leim-list.el): New rule.
775 (emacs$(EXEEXT)): Depend on leim-list.el.
776
fd06db5d
GM
777 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
778 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
779 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
780
55c131ee
AS
7812012-04-08 Andreas Schwab <schwab@linux-m68k.org>
782
783 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
784 proper alignment.
785
9209588f
JB
7862012-04-07 Juanma Barranquero <lekktu@gmail.com>
787
788 * xml.c (init_libxml2_functions) [WINDOWSNT]:
789 Remove unused local variable.
790
e3fb2efb
PE
7912012-04-07 Paul Eggert <eggert@cs.ucla.edu>
792
793 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
794 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
795 (mark_memory): Mark Lisp_Objects only if pointers might hide in
796 objects, as mark_maybe_pointer will catch them otherwise.
797 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
798 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
799
b5385551
PE
8002012-04-07 Paul Eggert <eggert@cs.ucla.edu>
801
802 Fix typo that broke non-Windows builds.
803 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
804
9078ead6
EZ
8052012-04-07 Eli Zaretskii <eliz@gnu.org>
806
807 Support building on MS-Windows with libxml2.
808
809 * makefile.w32-in (OBJ2): Add xml.$(O).
810 (GLOBAL_SOURCES): Add xml.c.
811 ($(BLD)/xml.$(O)): New dependency list.
812
813 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
814 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
815 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
816 [!WINDOWSNT]: New macros.
817 (init_libxml2_functions, libxml2_loaded_p): New functions.
818 (parse_region): Call fn_xmlCheckVersion instead of using the macro
819 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
820 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
821 Calls xmlCleanupParser only if libxml2 was loaded (or statically
822 linked in).
6bbef4e5
JC
823 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
824 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
825 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
826
827 * emacs.c: Don't include libxml/parser.h.
828 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
829 xmlCleanupParser directly.
830
831 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
832
3811fdf3
EZ
8332012-04-07 Eli Zaretskii <eliz@gnu.org>
834
835 * indent.c (Fvertical_motion): If there is a display string at
836 point, use it.vpos to compute how many lines to backtrack after
837 move_it_to point. (Bug#11133)
838
2f8e16b2
EZ
8392012-04-06 Eli Zaretskii <eliz@gnu.org>
840
841 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
842 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
843 about subtle differences between FETCH_CHAR* and STRING_CHAR*
844 macros related to unification of CJK characters. For the details,
845 see the discussion following the message here:
846 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
847
3d439cd1
CY
8482012-04-04 Chong Yidong <cyd@gnu.org>
849
850 * keyboard.c (Vdelayed_warnings_list): Doc fix.
851
8bc53d00
EZ
8522012-04-01 Eli Zaretskii <eliz@gnu.org>
853
854 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
855 instead of alloca. (Bug#11138)
856
3b0512a3
AS
8572012-04-01 Andreas Schwab <schwab@linux-m68k.org>
858
859 * w32menu.c (is_simple_dialog): Properly check lisp types.
860 (Bug#11141)
861
8427ddd2
EZ
8622012-03-31 Eli Zaretskii <eliz@gnu.org>
863
979022ef
EZ
864 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
865 position we get to after a call to move_it_to fails the
866 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
867 only if we wind up in a string from display property. (Bug#11063)
868
a6b1c7cc
EZ
869 * window.c (Fdelete_other_windows_internal): Invalidate the row
870 and column information about mouse highlight, so that redisplay
871 restores it after reallocating the glyph matrices. (Bug#7464)
872
8427ddd2
EZ
873 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
874 string comes from a `display' text property, use the buffer
875 position of that property as if we actually saw that position in
876 the row's glyphs.
697ba24b
EZ
877 (move_it_by_lines): Remove the assertion that
878 "it->current_x == 0 && it->hpos == 0" which can be legitimately
879 violated when there's a before-string at the beginning of a line.
880 (Bug#11063)
8427ddd2 881
65a0a738
EZ
8822012-03-30 Eli Zaretskii <eliz@gnu.org>
883
884 * xdisp.c (append_space_for_newline): If the default face was
885 remapped, use the remapped face for the appended newline.
886 (extend_face_to_end_of_line): Use the remapped default face for
887 extending the face to the end of the line.
888 (display_line): Call extend_face_to_end_of_line when the default
889 face was remapped. (Bug#11068)
890
581355cc
EZ
8912012-03-29 Eli Zaretskii <eliz@gnu.org>
892
893 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
894
e8fc049f
SM
8952012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
896
897 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
898
4fb9a543
GM
8992012-03-27 Glenn Morris <rgm@gnu.org>
900
901 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
902 Doc fixes.
903
679910f1
KH
9042012-03-26 Kenichi Handa <handa@m17n.org>
905
906 * dispextern.h (struct glyph): Fix previous change. Change the
907 bit length of glyphless.ch to 25 (Bug#11082).
908
90d49b7f
CY
9092012-03-26 Chong Yidong <cyd@gnu.org>
910
911 * keyboard.c (Vselection_inhibit_update_commands): New variable.
912 (command_loop_1): Use it; inhibit selection update for
913 handle-select-window too (Bug#8996).
914
f514f6f0
FP
9152012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
916
e8fc049f 917 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 918
bf43fa51
KH
9192012-03-25 Kenichi Handa <handa@m17n.org>
920
921 * dispextern.h (struct glyph): Change the bit length of
922 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
923
8a0c01dd
EZ
9242012-03-24 Eli Zaretskii <eliz@gnu.org>
925
926 * s/ms-w32.h (tzname): Include time.h before redirecting to
927 _tzname. Fixes the MSVC build. (Bug#9960)
928
7d1c3a76
AS
9292012-03-24 Andreas Schwab <schwab@linux-m68k.org>
930
8ed79523
AS
931 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
932 characters.
933
7d1c3a76
AS
934 * xterm.c (XTread_socket): Only modify handling_signal if
935 !SYNC_INPUT. (Bug#11080)
936
e99a9b8b
EZ
9372012-03-23 Eli Zaretskii <eliz@gnu.org>
938
939 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
940 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
941 when fetching a multibyte character consumes more bytes than
942 CHAR_BYTES returns, due to unification of CJK characters in
943 string_char. (Bug#11073)
944
5063c0e1
TN
9452012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
946
947 * process.c (wait_reading_process_output): Handle pty disconnect
948 by refraining from sending oneself a SIGCHLD (bug#10933).
949
9f851fbd
CY
9502012-03-22 Chong Yidong <cyd@gnu.org>
951
952 * dispextern.h (struct it): New member string_from_prefix_prop_p.
953
5063c0e1 954 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
955 Mark string as coming from a prefix property.
956 (handle_face_prop): Use default face for prefix strings (Bug#4281).
957 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
958
fb5b8aca
CY
9592012-03-21 Chong Yidong <cyd@gnu.org>
960
961 * xfaces.c (Vface_remapping_alist): Doc fix.
962
62356a1b
EZ
9632012-03-20 Eli Zaretskii <eliz@gnu.org>
964
965 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
966 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
967 Doc fixes.
62356a1b 968
025de85b
CY
9692012-03-20 Chong Yidong <cyd@gnu.org>
970
971 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
972 to reflect default non-nil value of redisplay-dont-pause.
973
4827f94e
KH
9742012-03-19 Kenichi Handa <handa@m17n.org>
975
976 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
977 it fit in a valid range (Bug#11003).
978
e50a24a2
EZ
9792012-03-18 Eli Zaretskii <eliz@gnu.org>
980
981 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
982 that is not from display property, accept the row as a "cursor
983 row" if one of the string's character has a non-nil `cursor'
984 property. Fixes cursor positioning when there are newlines in
985 overlay strings, e.g. in icomplete.el. (Bug#11035)
986
9af5ed87
PE
9872012-03-12 Paul Eggert <eggert@cs.ucla.edu>
988
989 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
990
d1f55f16
CY
9912012-03-12 Chong Yidong <cyd@gnu.org>
992
993 * eval.c (inhibit_lisp_code): Rename from
994 inhibit_window_configuration_change_hook; move from window.c.
995
996 * xfns.c (unwind_create_frame_1, Fx_create_frame):
997 * window.c (run_window_configuration_change_hook)
998 (syms_of_window): Callers changed.
999
66c5eebd
CY
10002012-03-11 Chong Yidong <cyd@gnu.org>
1001
413df973
CY
1002 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1003
66c5eebd
CY
1004 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1005
1de11f56
CY
10062012-03-10 Chong Yidong <cyd@gnu.org>
1007
1008 * frame.c (other_visible_frames): Don't assume the selected frame
1009 is visible (Bug#10955).
1010
cae07000
SM
10112012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1012
1013 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1014
89c94350
JD
10152012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1016
1017 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1018 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1019 zero (Bug#10954).
1020
999dd333
GM
10212012-03-03 Glenn Morris <rgm@gnu.org>
1022
01a6dcc8 1023 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1024
de0100f2
EZ
10252012-03-02 Eli Zaretskii <eliz@gnu.org>
1026
1027 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1028 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1029 (redisplay_window, next_element_from_string): Fix typos in
1030 comments.
3e441275
EZ
1031 (redisplay_window): Pass to move_it_vertically the margin in
1032 pixels, not in screen lines.
de0100f2 1033
96a72ee9
GM
10342012-03-02 Glenn Morris <rgm@gnu.org>
1035
1036 * buffer.c (buffer-list-update-hook): Doc fix.
1037
312508d7
EZ
10382012-02-29 Eli Zaretskii <eliz@gnu.org>
1039
1040 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1041 push_it before setting up the iterator for the first overlay
1042 string, even if we have an empty string loaded.
1043 (next_overlay_string): If there's an empty string on the iterator
1044 stack, pop the stack. (Bug#10903)
1045
27f3c637
PE
10462012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1049 Suggested by Stefan Monnier in
1050 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1051 * alloc.c (widen_to_Lisp_Object): New static function.
1052 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1053 and widening them to Lisp_Objects. This would work even if
1054 USE_LSB_TAG is defined and wide integers are used, which might
1055 happen in a future version of Emacs.
1056
3c9dfce6
CY
10572012-02-25 Chong Yidong <cyd@gnu.org>
1058
fa74b241
CY
1059 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1060 Doc fix.
1061
3c9dfce6
CY
1062 * xselect.c (Fx_selection_exists_p): Doc fix.
1063 (x_clipboard_manager_save_all): Print an informative message
1064 before saving to clipboard manager.
1065
9486df08
CY
10662012-02-24 Chong Yidong <cyd@gnu.org>
1067
1068 * keyboard.c (process_special_events): Handle all X selection
1069 requests in kbd_buffer, not just the next one (Bug#8869).
1070
f01d3321
CY
10712012-02-23 Chong Yidong <cyd@gnu.org>
1072
1073 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1074 call when setting menu-bar-lines and tool-bar-lines parameters.
1075 (unwind_create_frame_1): New helper function.
1076
1077 * window.c (inhibit_window_configuration_change_hook): New var.
1078 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1079 (syms_of_window): Initialize it.
f01d3321 1080
86b847b6
CY
10812012-02-22 Chong Yidong <cyd@gnu.org>
1082
1083 * xterm.c (x_draw_image_relief): Add missing type check for
1084 Vtool_bar_button_margin (Bug#10743).
1085
a59225b1
CY
10862012-02-21 Chong Yidong <cyd@gnu.org>
1087
1088 * fileio.c (Vfile_name_handler_alist): Doc fix.
1089
1090 * buffer.c (Fget_file_buffer): Protect against invalid file
1091 handler return value.
1092
310f5bd4
PE
10932012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1094
cb3a28cc
PE
1095 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1096 when computing $valmask.
1097
310f5bd4
PE
1098 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1099 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1100 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1101 It's useless in that case, and it can cause problems on hosts
1102 that allocate halves of EMACS_INT values separately.
1103 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1104 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1105 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1106 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1107 it avoids undefined behavior on hosts where shifting right by more
1108 than the word width has undefined behavior.
1109
2375c96a
CY
11102012-02-19 Chong Yidong <cyd@gnu.org>
1111
1112 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1113 (Funhandled_file_name_directory, Ffile_name_as_directory)
1114 (Fdirectory_file_name, Fexpand_file_name)
1115 (Fsubstitute_in_file_name): Protect against invalid file handler
1116 return values (Bug#10845).
1117
3eb49e71
EZ
11182012-02-18 Eli Zaretskii <eliz@gnu.org>
1119
1120 * .gdbinit (pitx): Fix incorrect references to fields of the
1121 iterator stack.
1122
7b926f3f
CY
11232012-02-17 Chong Yidong <cyd@gnu.org>
1124
1125 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1126
11273115
PE
11272012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1128
1129 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1130 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1131
c3a70e2b
CY
11322012-02-15 Chong Yidong <cyd@gnu.org>
1133
1134 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1135 marked as special. Also, starting docstrings with * is obsolete.
1136
0ca43699
AS
11372012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1138
1139 * gnutls.c (emacs_gnutls_write): Fix last change.
1140
2e8f3c56
LI
11412012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1142
1143 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1144 send_process.
1145
af70074f
SM
11462012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1147
1148 * keymap.c (Fsingle_key_description): Handle char ranges.
1149
95986d52
CY
11502012-02-12 Chong Yidong <cyd@gnu.org>
1151
afd83bd1
CY
1152 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1153 as that creates a dangerous corner case.
1154
95986d52
CY
1155 * window.c (Fdelete_window_internal): Invalidate the mouse
1156 highlight (Bug#9904).
1157
bd7da63e
GM
11582012-02-12 Glenn Morris <rgm@gnu.org>
1159
1160 * xselect.c (Fx_own_selection_internal)
1161 (Fx_get_selection_internal, Fx_disown_selection_internal)
1162 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1163 * nsselect.m (Fx_own_selection_internal)
1164 (Fx_disown_selection_internal, Fx_selection_exists_p)
1165 (Fx_selection_owner_p, Fx_get_selection_internal):
1166 Sync docs and argument specs with the xselect.c versions.
1167
77abcbc2
LI
11682012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1169
1170 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1171
90b671e2
EZ
11722012-02-11 Eli Zaretskii <eliz@gnu.org>
1173
1c0ca0b7
EZ
1174 * w32select.c (Fx_selection_exists_p): Sync doc string and
1175 argument list with xselect.c. (Bug#10783)
1176
1177 * w16select.c (Fx_selection_exists_p): Sync doc string and
1178 argument list with xselect.c. (Bug#10783)
90b671e2 1179
49241268
GM
11802012-02-10 Glenn Morris <rgm@gnu.org>
1181
1182 * fns.c (Fsecure_hash): Doc fix.
1183
f998bbe7 11842012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
1185
1186 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1187
0992bd9c
CY
11882012-02-07 Chong Yidong <cyd@gnu.org>
1189
1190 * buffer.c (Fbuffer_local_variables)
1191 (buffer_lisp_local_variables): Handle unbound vars correctly;
1192 don't let Qunbound leak into Lisp.
1193
af008560
GM
11942012-02-07 Glenn Morris <rgm@gnu.org>
1195
dd605cc4
GM
1196 * image.c (Fimagemagick_types): Doc fix.
1197
af008560
GM
1198 * image.c (imagemagick-render-type): Change it from a lisp object
1199 to an integer. Move the doc here from the lisp manual.
1200 Treat all values not equal to 0 the same.
1201
1449fa1d
CY
12022012-02-06 Chong Yidong <cyd@gnu.org>
1203
1204 * doc.c (store_function_docstring): Avoid applying docstring of
1205 alias to base function (Bug#2603).
1206
3723ec07
AS
12072012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1208
1209 * .gdbinit (pp1, pv1): Remove redundant defines.
1210 (pr): Use pp.
1211
79c1cc1e
CY
12122012-02-04 Chong Yidong <cyd@gnu.org>
1213
1214 * nsterm.m: Declare a global (Bug#10694).
1215
d7f29f8e
EZ
12162012-02-04 Eli Zaretskii <eliz@gnu.org>
1217
cae07000
SM
1218 * w32.c (get_emacs_configuration_options):
1219 Include --enable-checking, if specified, in the return value.
d7f29f8e 1220
3b95a6f9
MR
12212012-02-04 Martin Rudalics <rudalics@gmx.at>
1222
1223 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1224 after rounding frame sizes. (Bug#9723)
1225
d6fa96a6
EZ
12262012-02-04 Eli Zaretskii <eliz@gnu.org>
1227
1228 * keyboard.c (adjust_point_for_property): Don't position point
1229 before BEGV. (Bug#10696)
1230
df0b2940
PE
12312012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 Handle overflow when computing char display width (Bug#9496).
1234 * character.c (char_width): Return EMACS_INT, not int.
1235 (char_width, c_string_width): Check for overflow when
1236 computing the width; this is possible now that individual
1237 characters can have unbounded width. Problem introduced
1238 by merge from Emacs 23 on 2012-01-19.
1239
6bee44d6
MA
12402012-02-02 Michael Albinus <michael.albinus@gmx.de>
1241
1242 * dbusbind.c (Fdbus_register_method): Mention the return value
1243 :ignore in the docstring.
1244
44f92739
GM
12452012-02-02 Glenn Morris <rgm@gnu.org>
1246
1b9f60cc
GM
1247 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1248
44f92739
GM
1249 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1250 Unconditionally set to t. (Bug#10673)
1251 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1252 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1253 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1254
c5d3843c
KH
12552012-02-02 Kenichi Handa <handa@m17n.org>
1256
1257 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1258 0, do not call append_composite_glyph.
1259
159462d4 12602012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1261
1262 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1263 NULL (Bug#6988).
1264 (x_produce_glyphs): If the component of a composition is a null
1265 string, set it->pixel_width to 1 to avoid zero-width glyph.
1266
78cef877
EZ
12672012-02-01 Eli Zaretskii <eliz@gnu.org>
1268
1269 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1270 first 2 arguments are identical. This makes inserting large
1271 output from a subprocess an order of magnitude faster on
1272 MS-Windows, where all sbrk'ed memory is always contiguous.
1273
97897668
GM
12742012-01-31 Glenn Morris <rgm@gnu.org>
1275
1276 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1277 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1278 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1279
31fd3586
GM
12802012-01-29 Glenn Morris <rgm@gnu.org>
1281
1282 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1283
0e24a8b2
CY
12842012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1285
1286 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1287
cc0adcb0
CY
12882012-01-28 Chong Yidong <cyd@gnu.org>
1289
1290 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1291
acc28cb9
CY
12922012-01-26 Chong Yidong <cyd@gnu.org>
1293
9c69cfb7
CY
1294 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1295
acc28cb9
CY
1296 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1297 repeat counts (Bug#10507).
1298
48da7392
GM
12992012-01-26 Glenn Morris <rgm@gnu.org>
1300
1301 * lread.c (syms_of_lread): Doc fix.
1302
14af5f7f
CY
13032012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1304
1305 * coding.c (encode_designation_at_bol): Change return value to
1306 EMACS_INT.
1307
0b21c100
CY
13082012-01-25 Chong Yidong <cyd@gnu.org>
1309
1310 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1311
3c2907f7
CY
13122012-01-21 Chong Yidong <cyd@gnu.org>
1313
1314 * floatfns.c (Fcopysign): Make the second argument non-optional,
1315 since nil is not allowed anyway.
1316
959ad23f
AS
13172012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1318
1319 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1320 (send_process): Likewise.
1321
34a02f46
MR
13222012-01-19 Martin Rudalics <rudalics@gmx.at>
1323
1324 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1325 (Vwindow_persistent_parameters): Do not use Qstate.
1326 Rewrite doc-strings.
34a02f46 1327
1259009a 13282012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1329
1330 * character.c (char_width): New function.
70d4fdf6
GM
1331 (Fchar_width, c_string_width, lisp_string_width):
1332 Use char_width (Bug#9496).
25ed9e61 1333
6a6ee00d
MR
13342012-01-16 Martin Rudalics <rudalics@gmx.at>
1335
1336 * window.c (Vwindow_persistent_parameters): New variable.
1337 (Fset_window_configuration, save_window_save): Handle persistent
1338 window parameters.
1339
c85efaf7
EZ
13402012-01-14 Eli Zaretskii <eliz@gnu.org>
1341
1342 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1343 thrashing the stack of the thread. (Bug#9087)
1344
5944709e
PE
13452012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1348
e71f5d99
EZ
13492012-01-11 Eli Zaretskii <eliz@gnu.org>
1350
1351 * xdisp.c (rows_from_pos_range): Handle the case where the
1352 highlight ends on a newline. (Bug#10464)
1353 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1354 he end column for display of highlight that ends on a newline
1355 before a R2L line.
1356
ce316182
GM
13572012-01-11 Glenn Morris <rgm@gnu.org>
1358
1359 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1360 from load-path also when installation-directory is nil. (Bug#10208)
1361
5b43da69
GM
13622012-01-10 Glenn Morris <rgm@gnu.org>
1363
74cc8ff9
GM
1364 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1365
7d8d6e4e
GM
1366 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1367 Update template values to be closer to their typical values these days.
5b43da69 1368
a0db8d43
EZ
13692012-01-09 Eli Zaretskii <eliz@gnu.org>
1370
1371 * xdisp.c (rows_from_pos_range): Accept additional argument
1372 DISP_STRING, and accept any glyph in a row whose object is that
1373 string as eligible for mouse highlight. Fixes mouse highlight of
1374 display strings from overlays. (Bug#10464)
1375
9a0115ab 13762012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1377
b9110d6a 1378 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1379 * fileio.c (auto_saving_dir_umask): New static var.
1380 (Fmake_directory_internal): Use it.
1381 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1382 creating the directory. The old code temporarily assigns
1383 too-generous permissions to the directory.
1384 (do_auto_save_eh): Clear it.
b9110d6a 1385 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1386 that the var is always cleared.
1387
6c1bd3f3
EZ
13882012-01-07 Eli Zaretskii <eliz@gnu.org>
1389
1390 * search.c (scan_buffer): Pass character positions to
1391 know_region_cache, not byte positions. (Bug#6540)
1392
069d2b50
L
13932012-01-07 LynX <_LynX@bk.ru> (tiny change)
1394
1395 * w32.c (sys_rename): Report EXDEV when rename of a directory
1396 fails because the target is on another logical disk. (Bug#10284)
1397
75bf0d33
DB
13982012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1399
1400 * xterm.c (x_embed_request_focus): New function.
1401
1402 * xterm.h: Add prototype.
1403
1404 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1405
1c6e5a32
GM
14062012-01-05 Glenn Morris <rgm@gnu.org>
1407
1408 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1409
651e947e
EZ
14102012-01-01 Eli Zaretskii <eliz@gnu.org>
1411
1412 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1413 Load gnutls_transport_set_lowat only if GnuTLS version is below
1414 2.11.1.
1415 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1416 GnuTLS versions below 2.11.1.
1417
3778cdd8
AL
14182011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1419
1420 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1421 to the doc string advising against its use for altering the way
1422 windows are scrolled.
1423
0e5317f7
KH
14242011-12-28 Kenichi Handa <handa@m17n.org>
1425
1426 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1427 coding-system ASCII compatible only when it does not produce BOM
1428 on encoding (Bug#10383).
1429
93d5ca1f
JD
14302011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1431
1432 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1433 can scroll.
1434 (create_and_show_popup_menu): Always use menu_position_func for
1435 Gtk3 (Bug#10361).
1436
ca22b785
AS
14372011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1438
1439 * callint.c (Fcall_interactively): Don't truncate prompt string.
1440
d048e1e6
EZ
14412011-12-23 Eli Zaretskii <eliz@gnu.org>
1442
1443 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1444 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1445 resumed from there (after widening). (Bug#10360)
d048e1e6 1446
5ccaba1f
JD
14472011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1448
1449 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1450
204ee57f
JD
14512011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1452
b81d40f0
JB
1453 * nsterm.m (x_free_frame_resources):
1454 Release f->output_data.ns->miniimage.
204ee57f
JD
1455 (ns_index_color): Fix indentation. Do not retain
1456 color_table->colors[i].
1457
1458 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1459 before returning.
1460
1461 * nsfns.m (x_set_background_color): Assign return value from
1462 ns_index_color to face-background instead of NSColor*.
1463 (ns_implicitly_set_icon_type): Fix indentation.
1464 Change assignment in for loop to comparison.
1465
1466 * emacs.c (ns_pool): New variable.
1467 (main): Assign ns_pool.
1468 (Fkill_emacs): Call ns_release_autorelease_pool.
1469
1470 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1471 autorelease fdesc, release fdAttrs and tdict.
1472 (ns_get_covering_families): Release charset.
1473 (ns_findfonts): Release NSFontDescriptor created with new.
1474 (ns_uni_to_glyphs): Fix indentation.
1475 (setString): Release attrStr before assigning new value.
1476
c803b2b7
JD
14772011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1478
678f4426
JD
1479 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1480 and NS_IMPL_COCOA.
1481 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1482 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1483
cd394be1 14842011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1485
5fecd5fc
JD
1486 * nsterm.m (ns_term_init): Subscribe for notifications
1487 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1488 to method trackingNotification in EmacsMenu.
1489
1490 * nsmenu.m (trackingMenu): New variable.
3771cb17 1491 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1492 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1493 from Aquamacs (Bug#7030).
678f4426
JD
1494
14952011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1496
c803b2b7
JD
1497 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1498 (symbol_to_nsstring): Fix indentation.
1499 (ns_symbol_to_pb): New function.
cae07000
SM
1500 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1501 (Fns_rotate_cut_buffers_internal): Remove.
1502 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1503 Fns_store_cut_buffer_internal.
1504 (ns_get_foreign_selection, Fx_own_selection_internal)
1505 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1506 (Fns_get_selection_internal, Fns_store_selection_internal):
1507 Use ns_symbol_to_pb and check if return value is nil.
1508 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1509 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1510 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1511 renamed to Sns_store_selection_internal.
1512 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1513 and remove this function.
1514 (ns_handle_selection_clear): Remove, never used.
1515 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1516 here.
1517
e1b01a3a
KB
15182011-12-17 Ken Brown <kbrown@cornell.edu>
1519
1520 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1521 GID is unknown (Bug#10257).
1522
2adb6e85
PE
15232011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1526 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1527 which caused a build failure on GNU/Linux IA-64. This problem was
1528 introduced by my 2011-10-07 patch.
1529
d1d7b339
JL
15302011-12-15 Juri Linkov <juri@jurta.org>
1531
1532 * image.c (imagemagick_error): New function. (Bug#10112)
1533 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1534 Use `imagemagick_error' where ImageMagick functions return
1535 `MagickFalse'.
1536 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1537 proper order.
1538
100d5755
KH
15392011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1540
1541 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1542 fill background (Bug#8992).
1543
454592a6
MR
15442011-12-13 Martin Rudalics <rudalics@gmx.at>
1545
1546 * window.c (Vwindow_combination_resize)
1547 (Vwindow_combination_limit): Use t instead of non-nil in
1548 doc-strings.
61d4b438
MR
1549 (Vrecenter_redisplay): Add first sentence of doc-string on
1550 separate line.
53524d93 1551 (Frecenter): Fix doc-string typo.
454592a6 1552
3633e3aa
KH
15532011-12-11 Kenichi Handa <handa@m17n.org>
1554
1555 * coding.c (Funencodable_char_position): Pay attention to the
1556 buffer text relocation (Bug#9389).
1557
7b9d523a
JD
15582011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1559
1560 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1561 gtk_init (Bug#10100).
1562
b73189c6
EZ
15632011-12-10 Eli Zaretskii <eliz@gnu.org>
1564
1565 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1566 IT->string is nil. (Bug#10263)
1567
f7dfe5d6
JD
15682011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1569
83faebb4
JD
1570 * nsterm.h (x_free_frame_resources): Declare.
1571
f7dfe5d6
JD
1572 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1573 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1574
1575 * nsterm.h (ns_get_defaults_value): Declare.
1576
1577 * nsterm.m (ns_default): Call ns_get_defaults_value.
1578
7cd4e72c
EZ
15792011-12-09 Eli Zaretskii <eliz@gnu.org>
1580
1581 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1582 (Bug#10170)
1583
b34d7317
YM
15842011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1585
1586 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1587 that where the value of an _OBJC_* symbol points to is in the .bss
1588 section (Bug#10240).
1589
76470ad1
KH
15902011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1591
1592 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1593 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1594
745fff94
KH
15952011-12-08 Kenichi Handa <handa@m17n.org>
1596
1597 * ftfont.c (get_adstyle_property): Fix previous change
1598 (Bug#10233).
1599
6e44397c
JB
16002011-12-07 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1603 dirs from the default value of EMACSLOADPATH (bug#10208).
1604
7efa6272
GM
16052011-12-07 Glenn Morris <rgm@gnu.org>
1606
1607 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1608 installation and source directories as well. (Bug#10208)
1609
f6fc4d87
CY
16102011-12-06 Chong Yidong <cyd@gnu.org>
1611
1612 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1613
2bf26180
GM
16142011-12-06 Glenn Morris <rgm@gnu.org>
1615
1616 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1617 as an error, not just -1. (Bug#10217)
1618
3a6ad4f0
CY
16192011-12-05 Chong Yidong <cyd@gnu.org>
1620
1621 * keyboard.c (process_special_events): New function.
1622 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1623
75a3b399
PE
16242011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 * coding.c (encode_designation_at_bol): Don't use uninitialized
1627 local variable (Bug#9318).
1628
c3c9e25e
KH
16292011-12-05 Kenichi Handa <handa@m17n.org>
1630
1631 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1632 return Qnil (Bug#8046, Bug#10193).
1633
5eb05ea3
KH
16342011-12-05 Kenichi Handa <handa@m17n.org>
1635
1636 * coding.c (encode_designation_at_bol): New args charbuf_end and
1637 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1638 (coding_set_source): Return how many bytes coding->source was
1639 relocated.
1640 (coding_set_destination): Return how many bytes
1641 coding->destination was relocated.
1642 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1643 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1644
16452011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1646
1647 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1648 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1649 macro (Bug#9318).
1650
16512011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1652
1653 The following changes are to fix Bug#9318.
1654
a79703f5 1655 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1656 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1657 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1658 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1659
7dbda6df
JB
16602011-12-05 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * lisp.h (process_quit_flag): Fix external declaration.
1663
6d5eb5b0
SM
16642011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1665
1666 Don't macro-inline non-performance-critical code.
1667 * eval.c (process_quit_flag): New function.
1668 * lisp.h (QUIT): Use it.
1669
a0c3fad0
JD
16702011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1671
1672 * nsfns.m (get_geometry_from_preferences): New function.
1673 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1674
6c07aac2
AS
16752011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1676
1677 * emacs.c (Qkill_emacs): Define.
1678 (syms_of_emacs): Initialize it.
1679 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1680 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1681 (quit_throw_to_read_char): Add parameter `from_signal'.
1682 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1683 * lisp.h (QUIT): Call Fkill_emacs if requested.
1684
c052ead4
JD
16852011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1686
1687 * widget.c (update_wm_hints): Return if wmshell is null.
1688 (widget_update_wm_size_hints): New function.
1689
1690 * widget.h (widget_update_wm_size_hints): Declare.
1691
1692 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1693 widget_update_wm_size_hints (Bug#10104).
1694
9e49252b
EZ
16952011-12-03 Eli Zaretskii <eliz@gnu.org>
1696
1697 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1698 before a newline, prepare the bidi iterator for consuming the
1699 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1700 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1701
02b16839
JL
17022011-12-02 Juri Linkov <juri@jurta.org>
1703
1704 * search.c (Fword_search_regexp): New Lisp function created from
1705 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1706 (Fword_search_backward, Fword_search_forward)
1707 (Fword_search_backward_lax, Fword_search_forward_lax):
1708 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1709 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1710
0068070e
SM
17112011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1712
1713 * fileio.c (Finsert_file_contents): Move after-change-function call
1714 to before the "handled:" label, since all "goto handled" appear in
1715 cases where the *-change-functions have already been properly called
1716 (bug#10117).
1717
3360a3fc
AS
17182011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1719
1720 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1721 waiting for input. (Bug#10169)
1722
73d6c093
EZ
17232011-11-30 Eli Zaretskii <eliz@gnu.org>
1724
1725 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1726 verifies glyph row's hash code--we have just reallocated the
1727 glyphs, so their contents can be complete garbage. (Bug#10164)
1728
febe6bea
JB
17292011-11-30 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1732
801a4313
EZ
17332011-11-30 Eli Zaretskii <eliz@gnu.org>
1734
1735 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1736 attributes are tested _before_ calling verify_row_hash, to protect
1737 against GCC re-ordering of the tests. (Bug#10164)
1738
2b56b87e
JD
17392011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1740
1741 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1742
1743 * xterm.c (handle_one_xevent): Only set async_visible and friends
1744 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1745 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1746 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1747
dbf31225
PE
17482011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1749
1750 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1751 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1752 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1753 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1754 All uses changed to use GCPRO1 etc.
1755 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1756 Revert to old implementation (i.e., before 2011-03-11).
1757
1305621b
YM
17582011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1759
1760 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1761 of scroll runs so as to avoid assigning disabled bogus rows and
1762 unnecessary graphics copy operations.
1763
8c9afb46
EZ
17642011-11-27 Eli Zaretskii <eliz@gnu.org>
1765
1766 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1767 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1768 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1769 (malloc, free, realloc, calloc): Redirect to e_* only when
1770 compiling Emacs.
1771
1772 * lisp.h (GCTYPEBITS): Move before first use.
1773 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1774 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1775 this macro definition.
1776
1777 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1778 _MSC_VER.
1779
54e9e3bf
JD
17802011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1781
6d5eb5b0
SM
1782 * gtkutil.c (xg_create_frame_widgets):
1783 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1784 present with Gtk+ 2.0.
1785
83aca1cb
PE
17862011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * fileio.c (Finsert_file_contents): Undo previous change; see
1789 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1790
5b76caa4
PE
17912011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 Rename locals to avoid shadowing.
1794 * fileio.c (Finsert_file_contents):
1795 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1796 * process.c (wait_reading_process_output):
1797 Rename inner 'proc' to 'p' to avoid shadowing.
1798 Indent for consistency with usual Emacs style.
1799
8c535114
EZ
18002011-11-25 Eli Zaretskii <eliz@gnu.org>
1801
1802 * xdisp.c (redisplay_window): If cursor row is not fully visible
1803 after recentering, and scroll-conservatively is set to a large
1804 number, scroll window by a few more lines to make the cursor fully
1805 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1806 (start_display): Don't move to the next line if the display should
1807 start at a newline that is part of a display vector or an overlay
1808 string. (Bug#10119)
8c535114 1809
fa4fdb5c
JL
18102011-11-24 Juri Linkov <juri@jurta.org>
1811
1812 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1813 after the `MagickPingImage' call. (Bug#10112)
1814
90ec88df
CY
18152011-11-23 Chong Yidong <cyd@gnu.org>
1816
1817 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1818
56e2e794
MR
18192011-11-23 Martin Rudalics <rudalics@gmx.at>
1820
1821 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1822 making another buffer current. (Bug#10114)
1823
b6e64c41
GM
18242011-11-23 Glenn Morris <rgm@gnu.org>
1825
1826 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1827
6b21de18
CY
18282011-11-23 Chong Yidong <cyd@gnu.org>
1829
1830 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1831 using it (Bug#5984).
1832
b12cd789
EZ
18332011-11-22 Eli Zaretskii <eliz@gnu.org>
1834
1835 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1836 and header-lines, as they don't have one computed for them.
1837 (Bug#10098)
1838
1839 * .gdbinit (prow): Make displayed values more self-explaining.
1840 Add row's hash code.
1841
261b6fd4
LMI
18422011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1843
1844 * process.c (wait_reading_process_output): Fix asynchrounous
1845 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1846 (wait_reading_process_output): Add comment and URL.
261b6fd4 1847
e7cfd277
JD
18482011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1849
1850 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1851
a9b9b7f5
CY
18522011-11-21 Chong Yidong <cyd@gnu.org>
1853
1854 * window.c (Fnext_window, Fprevious_window): Doc fix.
1855
b0d15b4f
SM
18562011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1857
1858 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1859
fe7a3057
JB
18602011-11-20 Juanma Barranquero <lekktu@gmail.com>
1861
1862 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1863
d2999b1a
MR
18642011-11-20 Martin Rudalics <rudalics@gmx.at>
1865
1866 * window.c (Fset_window_combination_limit): Rename argument
1867 STATUS to LIMIT.
1868 (Vwindow_combination_limit): Remove "status" from doc-string.
1869
d5ff9cd0
AS
18702011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1871
1872 * m/ibms390.h: Remove.
1873 * m/ibms390x.h: Don't include "ibms390.h".
1874
a5bb9bd3
SM
18752011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1876
1877 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1878 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1879
cd1181db
JB
18802011-11-20 Juanma Barranquero <lekktu@gmail.com>
1881
1882 * casetab.c (Fset_case_table):
1883 * charset.c (Fcharset_after): Fix typos.
1884
615a3b8d 18852011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1886
17e845af
PE
1887 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1888 Otherwise, valgrind does not work on some platforms.
1889 Problem reported by Andreas Schwab in
6a0bf43d
PE
1890 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1891 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1892 is set, removing the need for VIRT_ADDRESS_VARIES.
1893 (PURE_P): Use a more-efficient implementation that needs just one
1894 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1895 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1896 to 4 (xorl, subq, cmpq, setbe).
1897 * alloc.c (pure): Always extern now, since that's the
1898 VIRT_ADDR_VARIES behavior.
1899 (PURE_POINTER_P): Use a single comparison, not two, for
1900 consistency with the new puresize.h.
1901 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1902 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1903 Remove VIRT_ADDR_VARIES no longer needed.
1904
f8fe6f96
EZ
19052011-11-19 Eli Zaretskii <eliz@gnu.org>
1906
1907 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1908 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1909 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1910 behave as if the cursor position were at the window margin.
1911
1912 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1913 and the cursor position is out of bounds, behave as if the cursor
1914 position were at the window margin. (Bug#10075)
1915
df05a53c
CY
19162011-11-18 Chong Yidong <cyd@gnu.org>
1917
1918 * window.c (Fwindow_combination_limit): Make first argument
1919 non-optional, since it is meaningless for live windows like the
1920 selected window.
1921
2071918e
DA
19222011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1923
1924 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1925
b50a28de
SM
19262011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1927
1928 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1929 (graft_intervals_into_buffer): Simplify.
1930
015137db
EZ
19312011-11-18 Eli Zaretskii <eliz@gnu.org>
1932
1933 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1934 hash values of the two rows.
1935 (copy_row_except_pointers): Preserve the used[] arrays and the
1936 hash values of the two rows. (Bug#10035)
68c95424 1937 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1938
1939 * xdisp.c (row_hash): New function, body extracted from
1940 compute_line_metrics.
1941 (compute_line_metrics): Call row_hash, instead of computing the
1942 hash code inline.
1943
1944 * dispnew.c (verify_row_hash): Call row_hash for computing the
1945 hash code of a row, instead of duplicating code from xdisp.c.
1946
1947 * dispextern.h (row_hash): Add prototype.
1948
a2addb04
TH
19492011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1950
1951 * frame.c (delete_frame): Don't delete the terminal when the last
1952 X frame is closed if emacs is built with GTK toolkit.
1953
df85d315
JB
19542011-11-17 Juanma Barranquero <lekktu@gmail.com>
1955
1956 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1957
a0c2d0ae
MR
19582011-11-17 Martin Rudalics <rudalics@gmx.at>
1959
1960 * window.c (Vwindow_splits): Rename to
1961 Vwindow_combination_resize. Suggested by Juri Linkov.
1962 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1963 of Vwindow_splits.
1964
58179cce
JB
19652011-11-16 Juanma Barranquero <lekktu@gmail.com>
1966
7877f373
JB
1967 * nsfns.m (Fns_font_name):
1968 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1969
b6f67890
MR
19702011-11-16 Martin Rudalics <rudalics@gmx.at>
1971
1972 * window.h (window): Rename slot "nest" to "combination_limit".
1973 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1974 (Fset_window_nest): Rename to Fset_window_combination_limit.
1975 (Vwindow_nest): Rename to Vwindow_combination_limit.
1976 (recombine_windows, make_parent_window, make_window)
1977 (Fsplit_window_internal, saved_window)
1978 (Fset_window_configuration, save_window_save): Rename all
1979 occurrences of window_nest to window_combination_limit.
1980
c7015153
JB
19812011-11-15 Juanma Barranquero <lekktu@gmail.com>
1982
1983 * image.c (imagemagick_load_image): Fix typo.
1984
322ad6ec
EZ
19852011-11-14 Eli Zaretskii <eliz@gnu.org>
1986
1987 * xdisp.c (display_line): Move the call to
1988 highlight_trailing_whitespace before the call to
1989 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1990 faces of all the glyphs to compute ROW's hash value.
1991 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1992
f067b8ec
JB
19932011-11-14 Juanma Barranquero <lekktu@gmail.com>
1994
1995 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1996 just return (bug#10044).
1997
1e5b2111
EZ
19982011-11-12 Eli Zaretskii <eliz@gnu.org>
1999
7ef3cbd5
EZ
2000 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2001 with user-defined heap size. Bump the default size of the temacs
2002 heap to 27MB, to avoid memory warning when running temacs.
2003 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2004
1e5b2111
EZ
2005 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2006 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2007 (verify_row_hash) [XASSERTS]: New function.
2008 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2009 that the hash value of glyph rows is correct.
1e5b2111 2010
89d61221
MR
20112011-11-12 Martin Rudalics <rudalics@gmx.at>
2012
2013 * window.h (window): Remove splits slot.
2014 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2015 (Fdelete_other_windows_internal, make_parent_window)
2016 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2017 (Fset_window_configuration, save_window_save): Don't deal with
2018 split status of windows.
2019 (saved_window): Remove splits slot.
2020 (Vwindow_splits): Rewrite doc-string.
2021
97f18cc8
JD
20222011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2023
2024 * xfns.c (unwind_create_frame):
2025 * nsfns.m (unwind_create_frame):
2026 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2027 Vframe_list (Bug#9999).
2028
22a648b4
DA
20292011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2030
0b381c7e 2031 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2032
659afede
KH
20332011-11-11 Kenichi Handa <handa@m17n.org>
2034
2035 * callproc.c (Fcall_process): Set the member dst_multibyte of
2036 process_coding.
2037
9ac0394b
KH
20382011-11-11 Johan Bockgård <bojohan@gnu.org>
2039
2040 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2041 avoid a crash (bug#9496).
2042
2fbdc249
CY
20432011-11-09 Chong Yidong <cyd@gnu.org>
2044
2045 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2046 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2047
ac6b1f81
PE
20482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2051
09db192c
PE
20522011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 Avoid some portability problems by eschewing 'extern inline' functions.
2055 The trivial performance wins aren't worth the portability hassles; see
2056 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2057 et seq.
2058 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2059 (window_box_width, window_box_left, window_box_left_offset)
2060 (window_box_right, window_box_right_offset): Undo previous change,
2061 by removing the "extern"s.
2062 * intervals.c (adjust_intervals_for_insertion)
2063 (adjust_intervals_for_deletion): Undo previous change,
2064 making these static again.
2065 (offset_intervals, temp_set_point_both, temp_set_point)
2066 (copy_intervals_to_string): No longer inline.
2067 * xdisp.c (window_text_bottom_y, window_box_width)
2068 (window_box_height, window_box_left_offset)
2069 (window_box_right_offset, window_box_left, window_box_right)
2070 (window_box): No longer inline.
2071
105216ed
CY
20722011-11-08 Chong Yidong <cyd@gnu.org>
2073
2074 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2075 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2076 Signal an error if not a live window.
105216ed
CY
2077 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2078 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2079
ae9e237f
JB
20802011-11-07 Juanma Barranquero <lekktu@gmail.com>
2081
2082 * lisp.h (syms_of_abbrev): Remove declaration.
2083 Reported by CHENG Gao <chenggao@royau.me>.
2084
c7aa8333
EZ
20852011-11-07 Eli Zaretskii <eliz@gnu.org>
2086
2087 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2088 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2089 of temacs in GUI mode.
2090
be7f5545
MR
20912011-11-07 Martin Rudalics <rudalics@gmx.at>
2092
2093 * window.h: Declare delete_all_child_windows instead of
2094 delete_all_subwindows.
2095 * window.c (Fwindow_nest, Fset_window_nest)
2096 (Fset_window_new_total, Fset_window_new_normal)
2097 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2098 (delete_all_subwindows): Rename to delete_all_child_windows.
2099 (Fdelete_other_windows_internal, Fset_window_configuration):
2100 Call delete_all_child_windows instead of delete_all_subwindows.
2101 * frame.c (delete_frame): Call delete_all_child_windows instead
2102 of delete_all_subwindows.
2103
ca78dc43
PE
21042011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2107 This is also needed for porting to any host where GC_MARK_STACK is
2108 not GC_MAKE_GCPROS_NOOPS.
2109 (which_symbols): Use it.
2110
a0241d01
KH
21112011-11-07 Kenichi Handa <handa@m17n.org>
2112
2113 * coding.c (coding_set_destination): Check coding->src_pos only
2114 when coding->src_object is a buffer (bug#9910).
2115
2116 * process.c (send_process): Set the member src_multibyte of coding
2117 to 0 (bug#9911) when sending a unibyte text.
2118
2119 * callproc.c (Fcall_process): Set the member src_multibyte of
2120 process_coding to 0 (bug#9912).
2121
a64bfdfa 21222011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2123
2124 * xmenu.c (cleanup_widget_value_tree): New function.
2125 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2126 calling free_menubar_widget_value_tree directly (Bug#9830).
2127
cb41b32a
PE
21282011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2129
2130 Fix some portability problems with 'inline'.
2131 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2132 (window_box_width, window_box_left, window_box_left_offset)
2133 (window_box_right, window_box_right_offset): Declare extern.
2134 Otherwise, these inline functions do not conform to C99 and
2135 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2136 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2137 * intervals.c (adjust_intervals_for_insertion)
2138 (adjust_intervals_for_deletion): Now extern, because otherwise the
2139 extern inline functions 'offset_intervals' couldn't refer to it.
2140 (static_offset_intervals): Remove.
2141 (offset_intervals): Rewrite using the old contents of
2142 static_offset_intervals. The old version didn't conform to C99
2143 because an extern inline function contained a reference to an
2144 identifier with static linkage.
2145
b7041366
AS
21462011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2147
2148 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2149 GC.
2150
88a37c4d
EZ
21512011-11-06 Eli Zaretskii <eliz@gnu.org>
2152
2153 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2154 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2155 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2156 return Qleft_to_right.
2157
49745b39
CY
21582011-11-06 Chong Yidong <cyd@gnu.org>
2159
2160 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2161 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2162 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2163 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2164 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2165 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2166 (Fwindow_vscroll): Doc fix.
2167 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2168 argument, since it makes no sense to pass a live window and for
2169 consistency with window-child.
2170
1f05cd82
CS
21712011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2172
2173 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2174 support MSVC.
2175
22610910
JR
21762011-11-05 Jason Rumney <jasonr@gnu.org>
2177
2178 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2179 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2180 fonts (Bug#6029).
2181 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2182 bitwise arithmetic preventing use of unicode-sip and non-truetype
2183 opentype fonts.
2184
a06776b2
EZ
21852011-11-05 Eli Zaretskii <eliz@gnu.org>
2186
3ad924ba
EZ
2187 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2188 "emacs"-only part.
2189
a06776b2
EZ
2190 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2191 initialization code to keep similarity to xfns.c after changes
2192 from 2011-11-05.
2193
c9e7db78
JD
21942011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2195
a97f8f3f
JD
2196 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2197 (unwind_create_frame): New function (Bug#9943).
2198 (Fx_create_frame): Restructure code to be more similar to the one in
2199 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2200 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2201 Move terminal->reference_count++ just before making the frame official
2202 (Bug#9943).
2203
2204 * nsterm.m (x_free_frame_resources): New function.
2205 (x_destroy_window): Move code to x_free_frame_resources.
2206
c9e7db78 2207 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2208 (Fx_create_frame, x_create_tip_frame):
2209 Move terminal->reference_count++ just before making the frame
75f1671a 2210 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2211 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2212
a6fc3b5c
EZ
22132011-11-05 Eli Zaretskii <eliz@gnu.org>
2214
2215 Support MSVC build with newer versions of Visual Studio.
2216 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2217 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2218 nt/gmake.defs.
2219
2220 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2221 which are not supported by MSVC.
2222 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2223 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2224 bitfields.
2225 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2226 types in bitfields.
2227 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2228
2229 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2230
58179cce 22312011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2232
2233 Support MSVC build with newer versions of Visual Studio.
2234 * w32.c: Don't include w32api.h for MSVC.
2235 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2236
2237 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2238 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2239 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2240 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2241 e_* cousins.
2242 (alloca) [_MSC_VER]: Define to _alloca.
2243
2244 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2245
2246 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2247
a58c13ed
EZ
22482011-11-04 Eli Zaretskii <eliz@gnu.org>
2249
2250 * xdisp.c (note_mouse_highlight): If either of
2251 previous/next-single-property-change returns nil, treat that as
2252 the beginning or the end of the buffer. (Bug#9955)
2253
fe0b6370
JD
22542011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2255
a58c13ed 2256 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2257 label is not null (Bug#9951).
2258 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2259 may be NULL.
2260
89bd5ee1
EZ
22612011-11-04 Eli Zaretskii <eliz@gnu.org>
2262
2263 * window.c (Fwindow_body_size): Mention in the doc string that the
2264 return value is in frame's canonical units. (Bug#9949)
2265
84c3edb9
EZ
22662011-11-03 Eli Zaretskii <eliz@gnu.org>
2267
4e2fb5c7
EZ
2268 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2269
84c3edb9 2270 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2271 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2272 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2273
bc17a887
EZ
22742011-11-01 Eli Zaretskii <eliz@gnu.org>
2275
2276 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2277 Don't stop backward scan on the continuation glyph, even though
2278 its CHARPOS is positive.
6d5eb5b0
SM
2279 (mouse_face_from_buffer_pos, note_mouse_highlight):
2280 Rename cover_string to disp_string.
bc17a887 2281
4ee88440
MR
22822011-11-01 Martin Rudalics <rudalics@gmx.at>
2283
2284 * window.c (temp_output_buffer_show): Don't use
2285 Vtemp_buffer_show_specifiers.
2286 (Vtemp_buffer_show_specifiers): Remove unused variable.
2287
c2ff3c02
EZ
22882011-10-30 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2291 past the beginning of the current glyph matrix.
2292
58179cce 22932011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2294
2295 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2296 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2297 HAVE_GTK3 (Bug#9869).
b77a6a7f 2298
3b574623
JD
2299 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2300 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2301
b77a6a7f
JD
2302 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2303
2304 * xterm.c: Declare x_handle_net_wm_state to return int.
2305 (handle_one_xevent): Check if we are iconified but don't have
2306 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2307 (get_current_wm_state): Return non-zero if not hidden,
2308 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2309 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2310 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2311 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2312
196e41e4
PE
23132011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2316 so that this new function doesn't get optimized away by a
2317 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2318
021f2e1a
AS
23192011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2320
2321 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2322
8b058d44
EZ
23232011-10-29 Eli Zaretskii <eliz@gnu.org>
2324
2325 Fix the `xbytecode' command.
2326 * .gdbinit (xprintbytestr): New command.
b50a28de 2327 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2328 (xbytecode): Print the byte-code string as well.
2329
4452fb80
EZ
23302011-10-29 Kim Storm <storm@cua.dk>
2331
8b058d44
EZ
2332 * alloc.c (which_symbols): New function.
2333
21b72067
AS
23342011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2335
2336 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2337 line. (Bug#9903)
2338
83ed7b5c
GM
23392011-10-29 Glenn Morris <rgm@gnu.org>
2340
2341 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2342 Not clear what it was for, and it causes various bugs. (Bug#9839)
2343
5a7a728b
EZ
23442011-10-28 Eli Zaretskii <eliz@gnu.org>
2345
2346 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2347 possible random value that matches one of those tested as
2348 condition to clear the mouse face.
2349
d3d0842f
CY
23502011-10-28 Chong Yidong <cyd@gnu.org>
2351
2352 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2353
31b39d13
DN
23542011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2355
2356 * window.c (make_window): Initialize phys_cursor_on_p.
2357
9aba6043
SM
23582011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2359
2360 * lisp.h (struct Lisp_Symbol): Update comments.
2361
c20992f4
JB
23622011-10-28 Juanma Barranquero <lekktu@gmail.com>
2363
2364 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2365
db4f02f2
EZ
23662011-10-28 Eli Zaretskii <eliz@gnu.org>
2367
2368 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2369 <oslsachem@gmail.com> for helping to debug this.
2370
2371 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2372 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2373 (g_b_init_get_glyph_outline_w): New static variables.
2374 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2375 (GetGlyphOutlineW_Proc): New typedefs.
2376 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2377 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2378 New functions.
2379 (w32font_open_internal, compute_metrics):
2380 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2381 instead of calling the "wide" APIs directly.
2382
2383 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2384
2385 * w32.h (syms_of_w32font): Add prototype.
2386
87e68db4
JB
23872011-10-27 Juanma Barranquero <lekktu@gmail.com>
2388
2389 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2390 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2391 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2392 (Fmove_to_window_line): Doc fix.
2393
435c1d67
CY
23942011-10-27 Chong Yidong <cyd@gnu.org>
2395
2396 * process.c (make_process): Set gnutls_state to NULL.
2397
2398 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2399 non-NULL, regardless of GNUTLS_INITSTAGE.
2400 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2401 an error. Set process slots as soon as we allocate them.
2402
2403 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2404
9c6c6f49
CY
24052011-10-27 Chong Yidong <cyd@gnu.org>
2406
9aba6043
SM
2407 * gnutls.c (emacs_gnutls_deinit): New function.
2408 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2409 (Fgnutls_deinit, Fgnutls_boot): Use it.
2410
2411 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2412 (deactivate_process): Call emacs_gnutls_deinit.
2413
657d08d3
JB
24142011-10-27 Juanma Barranquero <lekktu@gmail.com>
2415
2416 * image.c (x_create_x_image_and_pixmap):
2417 * w32.c (sys_rename, w32_delayed_load):
2418 * w32font.c (fill_in_logfont):
2419 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2420
5430d399
JB
24212011-10-26 Juanma Barranquero <lekktu@gmail.com>
2422
2423 * w32fns.c (w32_default_color_map): New function,
2424 extracted from Fw32_default_color_map.
a7ef684b 2425 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2426
fe0055fa
PE
24272011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2428
2429 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2430
e6346438
SM
24312011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2432
2433 * keyboard.c (test_undefined): New function (bug#9751).
2434 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2435
e112cc37
ET
24362011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2437
2438 * sysdep.c (init_sys_modes): Fix the check for the controlling
2439 terminal (Bug#6649).
2440
7b5d6677
EZ
24412011-10-20 Eli Zaretskii <eliz@gnu.org>
2442
2443 * dispextern.h (struct bidi_it): New member next_en_type.
2444
2445 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2446 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2447 current character, check also for next_en_type being WEAK_EN.
2448 (bidi_resolve_weak): Don't enter the expensive loop if the current
2449 position is before next_en_pos. Record the bidi type of the first
2450 non-ET, non-BN character we find, in addition to its position.
2451 (bidi_level_of_next_char): Invalidate next_en_type when
2452 next_en_pos is over-stepped.
2453
7da0b018
PE
24542011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2455
2456 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2457 * editfns.c: Rewrite current-time-zone so that it invokes
2458 the equivalent of (format-time-string "%Z") to get the time zone name.
2459 This fixes a bug when the time zone name contains characters that
2460 need converting from the system time locale to Emacs internal format.
2461 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2462 that patch fixed format-time-string to do the conversion, but
2463 I forgot to fix current-time-zone.
2464 (format_time_string): New function, containing most of
2465 what Fformat_time_string used to contain.
2466 (Fformat_time_string): Rewrite in terms of format_time_string.
2467 This doesn't change this function's behavior.
2468 (current-time-zone): Rewrite to use format_time_string.
2469 This fixes the bug reported by Michael Schierl in
2470 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2471 Jason Rumney's 2007-06-07 change worked around this bug, but
2472 didn't fix it.
2473 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2474
8547b010
EZ
24752011-10-19 Eli Zaretskii <eliz@gnu.org>
2476
2477 * xdisp.c (start_display): If the character at POS is displayed
2478 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2479 (try_window_reusing_current_matrix): If a line ends in a display
2480 vector or the next line starts in a display vector, continue
2481 redrawing the window even though the character position of
2482 start_row was reached.
8547b010
EZ
2483 (Bug#9771, part 2)
2484
4e948d15
CY
24852011-10-18 Chong Yidong <cyd@gnu.org>
2486
2487 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2488 with nobreak-char-display too.
2489
4787455f
EZ
24902011-10-18 Eli Zaretskii <eliz@gnu.org>
2491
2492 Fix part 3 of bug#9771.
2493 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2494 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2495 non-neutral characters if the current character is a paragraph
2496 separator (a.k.a. Newline). This avoids running the same
2497 expensive loop twice, once when we consume the preceding newline
2498 and the other time when the line actually needs to be displayed.
2499 Avoid the loop when we see neutrals on the base embedding level
2500 following a character whose directionality is the same as the
2501 paragraph's. This avoids running the expensive loop when a line
2502 ends in a long sequence of neutrals, like control characters.
2503 Add assertion against STRONG_AL type. Slightly rearrange code
2504 that determines the type of a neutral given the first non-neutral
2505 that follows it.
2506 (bidi_level_of_next_char): Set next_en_pos to zero when
2507 invalidating its info.
2508
2c91f553
EZ
25092011-10-17 Eli Zaretskii <eliz@gnu.org>
2510
2511 * xdisp.c (push_display_prop): Determine whether to record string
2512 or buffer position by IT->string, not by IT->method. Allow
2513 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2514 (move_it_vertically_backward): Don't look for character position
2515 immediately after the newline when in a continuation line.
2516 (Bug#9771, part 1)
2c91f553 2517
c7b08b0d
MR
25182011-10-15 Martin Rudalics <rudalics@gmx.at>
2519
2520 * window.c (coordinates_in_window): Rewrite and delabelize
2521 vertical border check. (Bug#5357) (Bug#9618)
2522
6b02f655
SM
25232011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2524
2525 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2526 errors in XSetWindowBorder (bug#9310).
2527
81d40c92
DA
25282011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2529
2530 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2531 avoid crash when xmalloc overrun checking is enabled.
2532
d4172c3b
EZ
25332011-10-13 Eli Zaretskii <eliz@gnu.org>
2534
2535 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2536 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2537 cursor motion with <left> and <right> arrow keys.
2538
2539 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2540 some callers set that themselves.
2541
b00eea75
EZ
25422011-10-12 Eli Zaretskii <eliz@gnu.org>
2543
2544 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2545 display string and the previous row comes from the same string and
2546 is empty. (Bug#9739) (Bug#9738)
2547
8fe012c4
SM
25482011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2549
2550 * doc.c (get_doc_string): Encode file name (bug#9735).
2551
0074aef2
EZ
25522011-10-12 Eli Zaretskii <eliz@gnu.org>
2553
79beb178
EZ
2554 * bidi.c (bidi_level_of_next_char):
2555 * xdisp.c (get_visually_first_element): Remove old incorrect
2556 comments regarding the Unicode Line Separator character.
2557
0074aef2
EZ
2558 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2559
6e4b3fbe
DA
25602011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2561
2562 * alloc.c (Fgc_status): Do not access beyond zombies array
2563 boundary if nzombies > MAX_ZOMBIES.
2564 * alloc.c (dump_zombies): Add missing format specifier.
2565
0324f3af
PE
25662011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2567
b5525cac
PE
2568 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2569 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2570
0324f3af
PE
2571 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2572 Some packages use them to denote characters with modifiers.
2573
e9b5f888
AS
25742011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2575
2576 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2577 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2578 matching a pp-number. Rename parameter var to var1.
2579
127827c0
SM
25802011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2581
2582 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2583
c8fd3bd0
GM
25842011-10-08 Glenn Morris <rgm@gnu.org>
2585
2586 * callint.c (Fcall_interactively): Give a more explicit error for the
2587 'c' case with a non-character input. (Bug#8479)
2588
352ec8ff
EZ
25892011-10-08 Eli Zaretskii <eliz@gnu.org>
2590
03669ccb
EZ
2591 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2592 lines.
7061c986
EZ
2593 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2594 lines that are hscrolled on the left.
03669ccb 2595
352ec8ff
EZ
2596 * dispnew.c (buffer_posn_from_coords): Account for a possible
2597 presence of header-line. (Bug#4426)
2598
a66cfb1c
SM
25992011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2600
6b02f655
SM
2601 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2602 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2603
7c5ee88e
PE
26042011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2605
2606 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2607 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2608 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2609 this makes Emacs dump core during garbage collection on rare
2610 occasions. sizeof is obviously inferior to offsetof here, so
2611 stick with offsetof.
2612 (GC_POINTER_ALIGNMENT): New macro.
2613 (mark_memory): Omit 3rd (offset) arg; caller changed.
2614 Don't assume EMACS_INT alignment is the same as pointer alignment.
2615
df1bbe5b
SM
26162011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2617
2618 * keyboard.c (read_key_sequence_remapped): New var.
2619 (read_key_sequence): Compute remapping in the right buffer.
2620 (command_loop_1): Use read_key_sequence's remapping directly.
2621
51553db6
SM
26222011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2623
32c1fffd
SM
2624 * dired.c (file_name_completion): Don't expand file name.
2625 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2626 before checking file name handler.
2627
51553db6
SM
2628 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2629 they've been requested explicitly (bug#9591).
2630
b6bd1599 26312011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2632
2633 * keymap.c (Fsingle_key_description): Use make_specified_string
2634 instead of build_string to build string from push_key_description.
2635 (Bug#5193)
2636
f701dc2a
PE
26372011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2638
4222c55d
PE
2639 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2640 This fixes a Y2038 bug on 64-bit hosts.
2641 * buffer.c (reset_buffer):
2642 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2643 (Fclear_buffer_auto_save_failure):
2644 Use 0, not -1, to represent an unset failure time, since time_t
2645 might not be signed.
2646
f701dc2a
PE
2647 Remove dependency on glibc malloc internals.
2648 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2649 Move back here from lisp.h, but with their new implementations.
2650 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2651 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2652 * charset.c (charset_table_init): New static var.
2653 (syms_of_charset): Use it instead of xmalloc. This removes a
2654 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2655 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2656 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2657 Move back to alloc.c.
2658 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2659 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2660
9ceebf39
JD
26612011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2662
2663 * nsterm.m (windowDidResize): Call x_set_window_size only when
2664 ns_in_resize is true. Otherwise set pixelwidth/height and
2665 call change_frame_size (Bug#9628).
2666
cb993c58
PE
26672011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2668
3930c88b
PE
2669 Port --enable-checking=all to Fedora 14 x86-64.
2670 * charset.c (syms_of_charset): Also account for glibc malloc's
2671 internal overhead when calculating the initial malloc maximum.
2672
cb993c58
PE
2673 Port --enable-checking=all to Fedora 14 x86.
2674 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2675 Move to lisp.h.
2676 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2677 (overrun_check_realloc, overrun_check_free):
2678 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2679 That way, xmalloc returns a properly-aligned pointer even if
2680 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2681 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2682 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2683 into account when calculating the initial malloc maximum.
2684 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2685 Move here from alloc.c, so that charset.c can use it too.
2686 Properly align; the old code wasn't right for common 32-bit hosts
2687 when configured with --enable-checking=all.
2688 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2689 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2690
31bed486
EZ
26912011-09-29 Eli Zaretskii <eliz@gnu.org>
2692
04c70788 2693 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2694 use EDOM.
2695
fbcaa2f3
EZ
26962011-09-28 Eli Zaretskii <eliz@gnu.org>
2697
2698 * xdisp.c (compute_display_string_end): If there's no display
2699 string at CHARPOS, return -1.
2700
2701 * bidi.c (bidi_fetch_char): When compute_display_string_end
2702 returns a negative value, treat the character as a normal
2703 character not covered by a display string. (Bug#9624)
2704
a239d4e9
JB
27052011-09-28 Juanma Barranquero <lekktu@gmail.com>
2706
2707 * lread.c (Fread_from_string): Fix typo in docstring.
2708
88652fd5
EZ
27092011-09-27 Eli Zaretskii <eliz@gnu.org>
2710
2711 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2712 newline, reseat the iterator instead of bidi-iterating there one
2713 character at a time. (Bug#9610)
32c1fffd
SM
2714 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2715 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2716
ed497dd4
AS
27172011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2718
2719 * lread.c (readevalloop): Use correct code for NBSP.
2720 (read1): Likewise. (Bug#9608)
2721
b2bf61aa
MA
27222011-09-25 Michael Albinus <michael.albinus@gmx.de>
2723
2724 * dbusbind.c (Fdbus_register_signal): When service is not
2725 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2726
32bbb17c
GM
27272011-09-25 Glenn Morris <rgm@gnu.org>
2728
2729 * buffer.c (truncate-lines): Doc fix.
2730
94e0933e
CY
27312011-09-24 Chong Yidong <cyd@stupidchicken.com>
2732
2733 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2734 (Fset_window_next_buffers): Doc fix.
2735
cddde921
GM
27362011-09-24 Glenn Morris <rgm@gnu.org>
2737
2738 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2739
1260aef1
PE
27402011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2741
25b4bfa0
PE
2742 Fix minor problems found by static checking.
2743 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2744 * indent.c (Fvertical_motion): Fix == vs = typo.
2745
e3cbd34b
EZ
27462011-09-24 Eli Zaretskii <eliz@gnu.org>
2747
a66cfb1c
SM
2748 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2749 Default value is now t. Doc fix.
6bf7006f 2750
e3cbd34b 2751 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2752 logic when moving up, not only when moving down. Fix the
e3cbd34b 2753 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2754 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2755
2756 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2757 CHARPOS is covered by a display string which includes newlines.
2758 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2759 is covered by a display string with embedded newlines.
2760
a3de0cbd
MA
27612011-09-24 Michael Albinus <michael.albinus@gmx.de>
2762
2763 * dbusbind.c (Fdbus_register_signal): Add match rule to
2764 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2765 (Fdbus_register_method, Vdbus_registered_objects_table):
2766 Fix docstring.
a3de0cbd 2767
b260039d
JM
27682011-09-24 Jim Meyering <meyering@redhat.com>
2769
32c1fffd 2770 do not ignore write error for any output size
b260039d
JM
2771 The previous change was incomplete.
2772 While it makes emacs --batch detect the vast majority of stdout
2773 write failures, errors were still ignored whenever the output size is
2774 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2775 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2776 && echo FAIL: ignored write error
2777 FAIL: ignored write error
2778 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2779 && echo FAIL: ignored write error
2780 FAIL: ignored write error
2781 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2782
8eca8a7c
AS
27832011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2784
2785 * emacs.c (Fkill_emacs): In noninteractive mode exit
2786 non-successfully if a write error occurred on stdout. (Bug#9574)
2787
3341db62
EZ
27882011-09-21 Eli Zaretskii <eliz@gnu.org>
2789
2790 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2791 the xassert test.
2792
2793 * dispextern.h (struct it): Update the comment documenting what
2794 can it->OBJECT be.
2795
8c203dbf
EZ
27962011-09-20 Eli Zaretskii <eliz@gnu.org>
2797
2798 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2799 a display string, extend search for cursor position to end of row.
2800 (find_row_edges): If the row ends in a newline from a display
2801 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2802 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2803 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2804 non-empty line. Fixes confusing cursor motion with arrow keys at
2805 the beginning of a line that starts with whitespace.
8c203dbf 2806
a4824228
LMI
28072011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2808
2809 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2810 (bug#9493).
2811
33ed493b
CY
28122011-09-18 Chong Yidong <cyd@stupidchicken.com>
2813
2814 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2815 boolean (Bug#9154).
2816
56cd55c8
EZ
28172011-09-18 Eli Zaretskii <eliz@gnu.org>
2818
2819 * xdisp.c (display_line): Record maximum and minimum buffer
2820 positions even if no glyphs were produced (e.g., by a zero-width
2821 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2822 buffer positions that will be removed from the glyph row because
2823 they don't fit.
c02dcedf
EZ
2824 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2825 column is beyond frame width: don't subtract 1 "pixel" when
2826 computing width of the stretch.
3e62b7e0
EZ
2827 (reseat_at_next_visible_line_start): Undo the change made on
2828 2011-09-17 that saved paragraph information and restored it after
2829 the call to `reseat'. (Bug#9545)
56cd55c8 2830
5ed99d36 28312011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2832
2833 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2834 and turn window cursor on if cleared (Bug#9415).
2835
5ed99d36 28362011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2837
2838 * search.c (boyer_moore): Take unibyte characters from pattern
2839 literally. (Bug#9458)
2840
9bade7b2
EZ
28412011-09-18 Eli Zaretskii <eliz@gnu.org>
2842
2843 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2844
e5e9d610
PE
28452011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2846
87e4427a
PE
2847 Fix minor problem found by static checking.
2848 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2849 initialized, to pacify gcc -Wuninitialized.
2850
e5e9d610
PE
2851 * fileio.c: Report proper errno when syscall falls.
2852 (Finsert_file_contents): Save and restore errno,
2853 so that report_file_error outputs the correct diagnostic.
2854 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2855
a1674f0b
EZ
28562011-09-18 Eli Zaretskii <eliz@gnu.org>
2857
2858 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2859
fbfb6dd4
EZ
28602011-09-17 Eli Zaretskii <eliz@gnu.org>
2861
2862 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2863 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2864
bb187662
EZ
28652011-09-17 Eli Zaretskii <eliz@gnu.org>
2866
1137e8b8 2867 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2868 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2869
2870 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2871 (bidi_find_paragraph_start): Search back for paragraph beginning
2872 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2873 (bidi_move_to_visually_next): Only trigger paragraph-related
2874 computations when the last character is a newline or at EOB, not
2875 just any NEUTRAL_B. (Bug#9470)
2876
bb187662
EZ
2877 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2878 truncated lines if point is covered by a display string. (Bug#9524)
2879
2e621251
PE
28802011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2881
2882 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2883 (cons_to_x_long): New function.
2884 (lisp_data_to_selection_data): Use it. Correct the test for
2885 short-versus-long data; it was negated. Break out of vector
2886 loop, for efficiency, when a long datum is discovered.
2887
91a15bc6
SM
28882011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2889
2890 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2891
b41c3a35
EZ
28922011-09-16 Eli Zaretskii <eliz@gnu.org>
2893
2894 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2895 GCC PR/17406) by declaring this function with external scope.
2896
7812ba2d
PE
28972011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2900 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2901
cf7edc2a
AS
29022011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2903
2904 * editfns.c (Fformat): Correctly handle text properties on "%%".
2905
bd01620e
EZ
29062011-09-15 Eli Zaretskii <eliz@gnu.org>
2907
2908 * xterm.c (x_draw_composite_glyph_string_foreground):
2909 * w32term.c (x_draw_composite_glyph_string_foreground):
2910 * term.c (encode_terminal_code):
2911 * composite.c (composition_update_it, get_composition_id):
2912 * xdisp.c (get_next_display_element)
2913 (fill_composite_glyph_string): Add comments about special meaning
2914 of TAB characters in a composition.
2915
a02719a3
PE
29162011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2919 This occurs when processing a multibyte format.
2920 Problem reported by Wolfgang Jenker.
a02719a3 2921
72589a3c
JB
29222011-09-15 Johan Bockgård <bojohan@gnu.org>
2923
2924 * xdisp.c (try_cursor_movement): Only check for exact match if
2925 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2926
1c14176c
PE
29272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2928
2929 Remove unused external symbols.
2930 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2931 * xdisp.c (calc_pixel_width_or_height): Now static.
2932 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2933 * indent.c (check_display_width):
2934 * w32term.c: Fix comment to match code.
2935 * xterm.c, xterm.h (x_catching_errors): Remove.
2936
d2eea5b5
PE
29372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2938
2939 * xselect.c: Use signed conversions more consistently (Bug#9498).
2940 (selection_data_to_lisp_data): Assume incoming selection data are
2941 signed integers, not unsigned. This is to be consistent with
2942 outgoing selection data, which was modified to use signed integers
2943 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2944 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2945 expects long, not unsigned long.
2946
46888499
EZ
29472011-09-14 Eli Zaretskii <eliz@gnu.org>
2948
2949 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2950 computation of loop end. Reported by Johan Bockgård
2951 <bojohan@gnu.org>.
2952
ef8ef9fb
CY
29532011-09-13 Chong Yidong <cyd@stupidchicken.com>
2954
2955 * frame.c (Fother_visible_frames_p): Function deleted.
2956
fa819fed
EZ
29572011-09-12 Eli Zaretskii <eliz@gnu.org>
2958
2959 * indent.c (compute_motion): Process display vector front to back
2960 rather than the other way around. (Bug#2496)
2961
2ba8e008
SM
29622011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2963
2964 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2965
20f53c69
CY
29662011-09-11 Chong Yidong <cyd@stupidchicken.com>
2967
2968 * minibuf.c (Fread_from_minibuffer): Doc fix.
2969
d562d7a4
EZ
29702011-09-11 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2973 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2974
1c4d7f3d
LMI
29752011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2976
2977 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2978 value for non-existent files.
2979
b885bf36
EZ
29802011-09-11 Eli Zaretskii <eliz@gnu.org>
2981
2982 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2983 set its "size" to -1. This will set the modtime_size field of
2984 the corresponding buffer to -1, which is what
2985 verify-visited-file-modtime expects for files that do not exist.
2986 (Bug#9139)
2987
6612f0bf
PE
29882011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2989
2990 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2991 here ...
2992 * lisp.h: ... from here. push_key_description is no longer
2993 defined in keyboard.c, so its declaration should not be in
2994 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2995 logically belongs with push_key_description.
2996
dfb3f755
PE
29972011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 * buffer.h: Include <sys/types.h> instead of <time.h>.
3000 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3001 Problem reported by Herbert J. Skuhra.
3002
3134906c
LMI
30032011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3004
3005 * xml.c (parse_region): Make the parsing work for
3006 non-comment-starting XML files again (bug#9144).
3007
8d903f4e
AS
30082011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3009
3010 * image.c (gif_load): Fix calculation of bottom and right corner.
3011 (Bug#9468)
3012
80ad64f4
EZ
30132011-09-10 Eli Zaretskii <eliz@gnu.org>
3014
3015 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3016 redisplay in small windows.
3017
208a048d
EZ
30182011-09-09 Eli Zaretskii <eliz@gnu.org>
3019
3020 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3021
9b1c252e
MR
30222011-09-08 Martin Rudalics <rudalics@gmx.at>
3023
3024 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3025 Operate on live windows only.
3026
2949f33b
JB
30272011-09-08 Juanma Barranquero <lekktu@gmail.com>
3028
3029 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3030
e08dcafd
EZ
30312011-09-07 Eli Zaretskii <eliz@gnu.org>
3032
3033 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3034 only under bidi iteration.
3035
115b96bd
JD
30362011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3037
3038 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3039
c8199d0f
PE
30402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3041
3042 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3043 Without this fix, the command to link temacs failed due to an
3044 undefined symbol __builtin_isnan. This is because
3045 /usr/include/iso/math_c99.h #defines isnan(x) to
3046 __builtin_isnan(x), but the bundled gcc, which identifies itself
3047 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3048 a __builtin_isnan.
3049 * floatfns.c (isnan): #undef, and then #define to a clone of
3050 what's in data.c.
3051 (Fisnan): Always define, since it's always available now.
3052 (syms_of_floatfns): Always define isnan at the Lisp level.
3053
e39b275c 30542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3055
3056 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3057
b2db44d9 30582011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3059
f4af5137 3060 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3061 The previous code assumed that file offsets (off_t values) fit in
3062 EMACS_INT variables, which is not true on typical 32-bit hosts.
3063 The code messed up by falsely reporting buffer overflow in cases
3064 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3065 when "big" contains more than 2**29 bytes, even though this
3066 inserts just one byte and does not overflow the buffer.
3067 (Finsert_file_contents): Store file offsets as off_t
3068 values, not as EMACS_INT values. Check for overflow when
3069 converting between EMACS_INT and off_t. When checking for
3070 buffer overflow or for overlap, take the offsets into account.
3071 Don't use EMACS_INT for small values where int suffices.
3072 When checking for overlap, fix a typo: ZV was used where
3073 ZV_BYTE was intended.
3074 (Fwrite_region): Don't assume off_t fits into 'long'.
3075 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3076
ecfc0a49
MA
30772011-09-05 Michael Albinus <michael.albinus@gmx.de>
3078
3079 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3080
6511acf2 30812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3082
0999621a 3083 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3084
3085 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3086 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3087 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3088 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3089 (modify_event_symbol): Do not assume that the length of
3090 name_alist_or_stem is safe to alloca and fits in int.
3091 (Fexecute_extended_command): Likewise for function name and binding.
3092 (Frecursion_depth): Wrap around reliably on integer overflow.
3093 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3094 since some callers pass EMACS_INT values.
3095 (Fsingle_key_description): Don't crash if symbol name contains more
3096 than MAX_ALLOCA bytes.
3097 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3098 (get_minibuffer): Arg is now EMACS_INT, not int.
3099 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3100 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3101 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3102
2be7d702
PE
3103 * dbusbind.c (signature_cat): New function.
3104 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3105 Do not overrun buffer; instead, report string overflow.
3106
9d1df220
PE
3107 * dispnew.c (add_window_display_history): Don't overrun buffer.
3108 Truncate instead; this is OK since it's just a log.
3109
33ef5c64
PE
3110 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3111 even if the time zone offset is outlandishly large.
3112 Don't mishandle offset == INT_MIN.
3113
66c6fdd5
PE
3114 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3115 when creating daemon; the previous buffer-overflow check was incorrect.
3116
d749b01b
PE
3117 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3118 which has the guts of the old verror function.
3119
b5cd1905
PE
3120 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3121 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3122
6e1a67fb
PE
3123 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3124 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3125 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3126 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3127 length of string rather than counting it via multiple sprintfs;
3128 that's simpler and more reliable.
c21721cc
PE
3129 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3130 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3131 sprintf, in case result does not fit in int.
3132
c57b67fc
PE
3133 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3134 (fontset_from_font): Print it.
3135
8a401434
PE
3136 * frame.c (tty_frame_count): Now printmax_t, not int.
3137 (make_terminal_frame, set_term_frame_name): Print it.
3138 (x_report_frame_params): In X, window IDs are unsigned long,
3139 not signed long, so print them as unsigned.
3140 (validate_x_resource_name): Check for implausibly long names,
3141 and don't assume name length fits in 'int'.
3142 (x_get_resource_string): Don't blindly alloca invocation name;
3143 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3144 not fit in int.
3145
6e1a67fb
PE
3146 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3147 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3148 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3149
0df02bf3
PE
3150 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3151 Use esprintf, not sprintf, in case result does not fit in int.
3152
48e30793
PE
3153 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3154 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3155 it as a large positive number.
3156 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3157 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3158
a66ff6d8
PE
3159 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3160 in case result does not fit in int.
3161
aca216ff
PE
3162 * print.c (float_to_string): Detect width overflow more reliably.
3163 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3164 buffer overrun. Don't assume list length fits in 'int'. Treat
3165 print length of 0 as 0, not as infinity; to be consistent with other
3166 uses of print length in this function. Don't overflow print length
3167 index. Don't assume hash table size fits in 'long', or that
3168 vectorlike size fits in 'unsigned long'.
3169
31c286f7
PE
3170 * process.c (make_process): Use printmax_t, not int, to format
3171 process-name gensyms.
3172
55e5faa1
PE
3173 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3174
80f2e268
PE
3175 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3176 to avoid potential buffer overrun.
3177
670741ab
PE
3178 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3179 if X resource line is longer than 512 bytes.
3180
b7163a50
PE
3181 * xfns.c (x_window): Make sprintf buffer a bit bigger
3182 to avoid potential buffer overrun.
3183
ae58ff1f
PE
3184 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3185
c43c8a6a
PE
3186 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3187
3f8236f4
PE
31882011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3189
53e9fe90 3190 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3191 Without these, Emacs silently mishandles large integers sometimes.
3192 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3193 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3194
6511acf2
PE
3195 * xdisp.c (try_window_id): Check Emacs fixnum range before
3196 converting to 'int'.
806add1d 3197
6511acf2 3198 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3199 Check that an Emacs fixnum is in range before assigning it to 'int'.
3200 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3201 values converted from Emacs fixnums.
3202 (Frecenter): Don't wrap around a line count if it is out of 'int'
3203 range; instead, treat it as an extreme value.
3204 (Fset_window_configuration, compare_window_configurations):
3205 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3206
6511acf2
PE
3207 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3208 that can exceed INT_MAX. Check that EMACS_INT value is in range
3209 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3210 (match_limit): Don't assume that a fixnum can fit in 'int'.
3211
6511acf2 3212 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3213 exceed INT_MAX.
3214
6511acf2 3215 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3216 (Fvertical_motion): Don't wrap around LINES values that don't fit
3217 in 'int'. Instead, treat them as extreme values. This is good
3218 enough for windows, which can't have more than INT_MAX lines anyway.
3219
fcb901a7
LMI
32202011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3221
0f2f6b6d
LMI
3222 * Require libxml/parser.h to avoid compilation warning.
3223
fcb901a7
LMI
3224 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3225
3226 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3227 since this reportedly can destroy thread storage.
3228
6e20a0d4
CY
32292011-08-30 Chong Yidong <cyd@stupidchicken.com>
3230
3231 * syntax.c (find_defun_start): Update all cache variables if
3232 exiting early (Bug#9401).
3233
148ae00e
EZ
32342011-08-30 Eli Zaretskii <eliz@gnu.org>
3235
f6cfbd8f
EZ
3236 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3237
148ae00e
EZ
3238 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3239 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3240 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3241
3242 * term.c (tty_append_glyph): New function.
3243 (produce_stretch_glyph): Static function and its prototype deleted.
3244
a66cfb1c
SM
3245 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3246 Add prototypes.
148ae00e 3247
c4a07a4c
PE
32482011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3249
3250 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3251 when checking :margin (Bug#9390).
3252 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3253 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3254 so that the name doesn't mislead. All uses changed.
3255
6bc8cd65
JB
32562011-08-28 Johan Bockgård <bojohan@gnu.org>
3257
3258 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3259 set_tty_hooks.
3260
dca4927e
EZ
32612011-08-27 Eli Zaretskii <eliz@gnu.org>
3262
3263 * xdisp.c (move_it_to): Don't bail out early when reaching
3264 position beyond to_charpos, if we are scanning backwards.
3265 (move_it_vertically_backward): When DY == 0, make sure we get to
3266 the first character in the line after the newline.
3267
f2cad773
PE
32682011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3271 (ccl_driver): Do not generate an out-of-range pointer.
3272 (Fccl_execute_on_string): Remove unnecessary check for
3273 integer overflow, noted by Stefan Monnier in
3274 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3275 Remove a FIXME that didn't need fixing.
3276 Simplify the newly-introduced buffer reallocation code.
3277
0cae2cdb
JB
32782011-08-27 Juanma Barranquero <lekktu@gmail.com>
3279
3280 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3281
5fc295a4 32822011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3283
70c60eb2 3284 Integer and memory overflow issues (Bug#9196).
726e0ab1 3285
d31850da
PE
3286 * doc.c (get_doc_string): Rework so that
3287 get_doc_string_buffer_size is the actual buffer size, rather than
3288 being 1 less than the actual buffer size; this makes xpalloc more
3289 convenient.
3290
a69fbedb
PE
3291 * image.c (x_allocate_bitmap_record, cache_image):
3292 * xselect.c (Fx_register_dnd_atom):
3293 Simplify previous changes by using xpalloc.
3294
fe5c5d37
PE
3295 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3296 since either will do and ptrdiff_t is convenient with xpalloc.
3297
0065d054
PE
3298 * charset.c (charset_table_size)
3299 (struct charset_sort_data.priority): Now ptrdiff_t.
3300 (charset_compare): Don't overflow if priorities differ greatly.
3301 (Fsort_charsets): Don't assume list length fits in int.
3302 Check for size-calculation overflow when allocating sort data.
3303 (syms_of_charset): Allocate an initial charset table that is
3304 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3305
3306 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3307
3308 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3309 The actual value is always <= INT_MAX, and leaving it unsigned made
3310 overflow checking harder.
3311
3312 * dispextern.h (struct glyph_matrix.rows_allocated)
3313 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3314 with xpalloc. The values are still always <= INT_MAX.
3315
3316 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3317
3318 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3319 (SAFE_NALLOCA): New macro.
3320
3321 * region-cache.c (struct boundary.pos, find_cache_boundary)
3322 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3323 (set_cache_region, invalidate_region_cache)
3324 (revalidate_region_cache, know_region_cache, region_cache_forward)
3325 (region_cache_backward, pp_cache):
3326 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3327 so that ptrdiff_t * can be passed to xpalloc.
3328 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3329 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3330 (pp_cache): Don't assume cache_len fits in int.
3331 * region-cache.h: Adjust extern decls to match.
3332
3333 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3334 EMACS_INT, since either will do, for xpalloc.
3335
3336 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3337 (xnmalloc, xnrealloc, xpalloc): New functions.
3338
726e0ab1
PE
3339 * bidi.c (bidi_shelve_header_size): New constant.
3340 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3341 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3342
51f30bc5 3343 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3344 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3345 (overlay_strings):
3346 Don't update size of array until after memory allocation succeeds,
3347 because xmalloc/xrealloc may not return.
0065d054
PE
3348 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3349 now that we have proper integer overflow checking.
3350 (record_overlay_string, overlay_strings): Catch overflows when
3351 calculating size of overlay_str_buf.
726e0ab1 3352
0065d054
PE
3353 * callproc.c (Fcall_process): Check for size overflow when
3354 calculating size of args2.
3355 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3356 Normally we prefer signed values, but sticking with ptrdiff_t would
3357 require adding more-complicated checks.
726e0ab1
PE
3358
3359 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3360 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3361 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3362 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3363
3364 * character.c (Fstring): Check for size-calculation overflow.
3365
3366 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3367 unnecessary integer overflow. Check for size overflow.
3368 (encode_coding_object): Don't update size until xmalloc succeeds.
3369
3370 * composite.c (get_composition_id): Check for overflow in glyph
3371 length calculations.
3372
3373 Integer and memory overflow fixes for display code.
3374 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3375 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3376 (scrolling_window): Check for overflow in size calculations.
3377 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3378 Don't assume glyph table len fits in int.
3379 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3380 (row_table_size): Now ptrdiff_t, not int.
3381 (scrolling_window): Avoid overflow in size calculations.
3382 Don't update size until allocation succeeds.
3383 * fns.c (concat): Check for overflow in size calculations.
3384 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3385 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3386 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3387
3388 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3389 (get_doc_string): Check for size calculation overflow.
3390 Don't update size until allocation succeeds.
3391 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3392 EMACS_INT, where ptrdiff_t will do.
3393 (Fsubstitute_command_keys): Check for string overflow.
3394
3395 * editfns.c (set_time_zone_rule): Don't assume environment length
3396 fits in int.
3397 (message_length): Now ptrdiff_t, not int.
3398 (Fmessage_box): Don't update size until allocation succeeds.
3399 Don't assume message length fits in int.
3400 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3401
0065d054
PE
3402 * emacs.c (main): Do not reallocate argv, since there is a null at
3403 the end that can be overwritten, and this way there's no need to
3404 worry about size-calculation overflow.
3405 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3406
3407 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3408 alloc succeeds.
3409 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3410
3411 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3412 (x_set_scroll_bar_width, x_figure_window_size):
3413 Check for integer overflow.
3414 (x_set_alpha): Do not assume XINT fits in int.
3415
3416 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3417 This is for the members text_lines, text_cols, total_lines, total_cols,
3418 where the system imposes an 'int' limit.
3419
3420 * fringe.c (Fdefine_fringe_bitmap):
3421 Don't update size until alloc works.
3422
3423 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3424 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3425
3426 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3427 Check for size-calculation overflow.
3428 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3429 do, as we prefer signed integers.
3430 (id_to_widget.max_size, id_to_widget.used)
3431 (xg_store_widget_in_map, xg_remove_widget_from_map)
3432 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3433 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3434 Use and return ptrdiff_t, not int.
3435 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3436 * gtkutil.h: Change prototypes to match the above.
3437
3438 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3439 are duplicate now that they've been promoted to lisp.h.
3440 (x_allocate_bitmap_record, x_alloc_image_color)
3441 (make_image_cache, cache_image, xpm_load):
3442 Don't update size until alloc is done.
3443 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3444 (x_detect_edges):
3256efce 3445 Check for size calculation overflow.
726e0ab1
PE
3446 (ct_colors_allocated_max): New constant.
3447 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3448 overflow.
3256efce 3449
726e0ab1
PE
3450 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3451 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3452 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3453 Use ptrdiff_t, not int, to count maps.
3454 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3455 calculations. Don't update size until allocation succeeds.
3456 Redo calculations to avoid overflow.
726e0ab1
PE
3457 * keyboard.h: Change prototypes to match the above.
3458
3459 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3460 to count maps.
3461 (current_minor_maps): Check for size calculation overflow.
3462 * keymap.h: Change prototypes to match the above.
3463
3464 * lread.c (read1, init_obarray): Don't update size until alloc done.
3465
3466 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3467 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3468
726e0ab1
PE
3469 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3470 Now ptrdiff_t, not int.
3471 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3472 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3473
3474 * process.c (Fnetwork_interface_list): Check for overflow
3475 in size calculation.
3476
3477 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3478
3479 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3480 overflow. Don't bother calling xmalloc when xrealloc will do.
3481
3482 * search.c (Freplace_match): Check for size calculation overflow.
3483 (Fset_match_data): Don't assume list lengths fit in 'int'.
3484
3485 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3486 for command line length. Do not attempt to address one before the
3487 beginning of an array, as that's not portable.
3488
3489 * term.c (max_frame_lines): Remove; unused.
3490 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3491 not int.
3492 (encode_terminal_code, calculate_costs): Check for size
3493 calculation overflow.
3494 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3495 table lengths and related sizes. Don't update size until alloc
3496 done. Redo calculations to avoid overflow.
3497 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3498
3499 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3500 subtracting pointers.
3501 (gobble_line): Check for overflow more carefully. Don't update size
3502 until alloc done.
3503
3504 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3505 Don't update size until alloc done.
3506 Redo size calculations to avoid overflow.
3507 Check for size calculation overflow.
0065d054 3508 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3509
3510 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3511 Use ptrdiff_t, not int, for sizes.
3512 (store_mode_line_noprop_char): Don't update size until alloc done.
3513
0065d054
PE
3514 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3515 Use ptrdiff_t, not int, for sizes.
3516 (Finternal_make_lisp_face, cache_face):
3517 Check for size calculation overflow.
3518 (cache_face): Treat size calculation overflows as if they were
3519 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3520
3521 * xfns.c (x_encode_text, x_set_name_internal)
3522 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3523 sizes, since they can exceed INT_MAX in size. Check for size
3524 calculation overflow.
3525
0065d054
PE
3526 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3527 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3528 Don't update size until alloc done.
3529
0065d054 3530 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3531 as sprintf is limited to int lengths.
1d526e2f 3532
252c5ee1
PE
3533 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3534 (X_LONG_MIN): New macros.
864d7ce7
PE
3535 Use them to make the following changes clearer.
3536 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3537 This change doesn't affect the value now, but it may help remind
3538 future maintainers not to raise the value too much later.
3539 (SELECTION_QUANTUM): Remove, replacing with ...
3540 (selection_quantum): ... new function, which avoids overflow.
3541 All uses changed.
3542 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3543 assumption that selection length fits in 'int'.
3544 (x_reply_selection_request, x_handle_selection_request)
3545 (x_get_window_property, receive_incremental_selection)
3546 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3547 (lisp_data_to_selection_data, clean_local_selection_data):
3548 Use ptrdiff_t, not int, to record length of selection.
3549 (x_reply_selection_request, x_get_window_property)
3550 (receive_incremental_selection, x_property_data_to_lisp):
3551 Redo calculations to avoid overflow.
3552 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3553 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3554 something.
3555 (x_get_window_property, receive_incremental_selection)
3556 (lisp_data_to_selection_data, x_property_data_to_lisp):
3557 Check for size-calculation overflow.
3558 (x_get_window_property, receive_incremental_selection)
3559 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3560 Don't store size until memory allocation succeeds.
3561 (x_get_window_property): Plug memory leak on memory exhaustion.
3562 Don't double-block input; malloc is safe here. Don't assume 2**34
3563 - 4 fits in unsigned long. Add an xassert to check
3564 XGetWindowProperty overflow. Be more careful about overflow
3565 calculations, and distinguish size from memory overflow better.
3566 (receive_incremental_selection): When tracing, don't assume
3567 unsigned int is less than INT_MAX.
3568 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3569 harmful) conversions of unsigned short to int.
3570 (lisp_data_to_selection_data): Don't assume that integers
3571 in the range -65535 through -1 fit in an X unsigned short.
3572 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3573 result parameters unless successful. Rely on cons_to_unsigned
3574 to report problems with elements; the old code wasn't right anyway.
3575 (x_check_property_data): Check for int overflow; we cannot use
3576 a wider type due to X limits.
3577 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3578
726e0ab1 3579 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3580
0065d054
PE
3581 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3582 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3583 (x_color_cells): Don't store size until memory allocation succeeds.
3584 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3585 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3586 (x_term_init): Don't assume length fits in int (sprintf is limited
3587 to int size).
bc18e09d 3588
ebfa62c0
PE
3589 Use ptrdiff_t for composition IDs.
3590 * character.c (lisp_string_width):
3591 * composite.c (composition_table_size, n_compositions)
3592 (get_composition_id, composition_gstring_from_id):
3593 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3594 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3595 * window.c (Frecenter):
3596 Use ptrdiff_t, not int, for composition IDs.
3597 * composite.c (get_composition_id): Check for integer overflow.
3598 * composite.h: Adjust prototypes to match the above changes.
3599
d3411f89
PE
3600 Use ptrdiff_t for hash table indexes.
3601 * category.c (hash_get_category_set):
3602 * ccl.c (ccl_driver):
3603 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3604 * coding.c (coding_system_charset_list, detect_coding_system):
3605 * coding.h (struct coding_system.id):
3606 * composite.c (get_composition_id, gstring_lookup_cache):
3607 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3608 * image.c (xpm_get_color_table_h):
3609 * lisp.h (hash_lookup, hash_put):
3610 * minibuf.c (Ftest_completion):
3611 Use ptrdiff_t for hash table indexes, not int (which is too
3612 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3613 32-bit --with-wide-int hosts).
3614
e097a6fa
PE
3615 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3616 Add a FIXME comment about memory leaks.
3617 (syms_of_charset): Don't assume xmalloc returns.
3618
5637687f
PE
3619 Don't assume that stated character widths fit in int.
3620 * character.c (Fchar_width, c_string_width, lisp_string_width):
3621 * character.h (CHAR_WIDTH):
3622 * indent.c (MULTIBYTE_BYTES_WIDTH):
3623 Use sanitize_char_width to avoid undefined and/or bad behavior
3624 with outlandish widths.
a66cfb1c 3625 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3626 now that we have two such functions. All uses changed.
3627 (sanitize_char_width): New inline function.
3628
a2271ba2
PE
3629 Don't assume that tab-width fits in int.
3630 * character.h (sanitize_width): New inline function.
3631 (SANE_TAB_WIDTH): New macro.
3632 (ASCII_CHAR_WIDTH): Use it.
3633 * indent.c (sane_tab_width): Remove. All uses replaced by
3634 SANE_TAB_WIDTH (current_buffer).
3635 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3636
18c52557
PE
3637 * fileio.c: Integer overflow issues with file modes.
3638 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3639
caeeedc1
PE
3640 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3641 Remove unreachable code.
3642 (read_hex, load_charset_map_from_file): Check for integer overflow.
3643
6df6ae42 3644 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3645 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3646 (x_send_scroll_bar_event): Likewise. Check that the size does not
3647 exceed limits imposed by XClientMessageEvent, as well as the usual
3648 ptrdiff_t and size_t limits.
3649
b13995db
PE
3650 * keyboard.c: Overflow, signedness and related fixes.
3651 (make_lispy_movement): Use same integer type in forward decl
3652 that is used in the definition.
3653 (read_key_sequence, keyremap_step):
3654 Change bufsize argument back to int, undoing my 2011-03-30 change.
3655 We prefer signed types, and int is wide enough here.
3656 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3657 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3658 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3659 length, not size_t. Use ptrdiff_t for index, not int.
3660 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3661 possibility of integer overflow.
3662
13464394
PE
3663 Overflow, signedness and related fixes for images.
3664
3665 * dispextern.h (struct it.stack[0].u.image.image_id)
3666 (struct_it.image_id, struct image.id, struct image_cache.size)
3667 (struct image_cache.used, struct image_cache.ref_count):
3668 * gtkutil.c (update_frame_tool_bar):
3669 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3670 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3671 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3672 * nsmenu.m (update_frame_tool_bar):
3673 * xdisp.c (calc_pixel_width_or_height):
3674 * xfns.c (image_cache_refcount):
3675 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3676 on typical 64-bit hosts.
3677
3678 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3679 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3680 Omit unnecessary casts to int.
3681 (parse_image_spec): Check that integers fall into 'int' range
3682 when the callers expect that.
3683 (image_ascent): Redo ascent calculation to avoid int overflow.
3684 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3685 (lookup_image): Remove unnecessary tests.
3686 (xbm_image_p): Locals are now of int, not EMACS_INT,
3687 since parse_image_check makes sure they fit into int.
3688 (png_load, gif_load, svg_load_image):
3689 Prefer int to unsigned where either will do.
3690 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3691 old tiff_error_handler and tiff_warning_handler.
3692 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3693 stack buffer overflows. It uses only the features of vsnprintf
3694 that are common to both POSIX and native Microsoft.
3695 (tiff_error_handler, tiff_warning_handler): Use it.
3696 (tiff_load, gif_load, imagemagick_load_image):
3697 Don't assume :index value fits in 'int'.
3698 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3699 (imagemagick_load_image): Check that crop parameters fit into
3700 the integer types that MagickCropImage accepts. Don't assume
3701 Vimagemagick_render_type has a nonnegative value. Don't assume
3702 size_t fits in 'long'.
3703 (gs_load): Use printmax_t to print the widest integers possible.
3704 Check for integer overflow when computing image height and width.
3705
c11821d4
EZ
37062011-08-26 Eli Zaretskii <eliz@gnu.org>
3707
3708 * xdisp.c (redisplay_window): Don't force window start if point
3709 will be invisible in the resulting window. (Bug#9324)
3710
0c95fcf7
EZ
37112011-08-25 Eli Zaretskii <eliz@gnu.org>
3712
3713 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3714 the display spec is of the form `(space ...)'.
3715 (handle_display_spec): Return the value returned by
3716 handle_single_display_spec, not just 1 or zero.
3717 (handle_single_display_spec): If the display spec is of the form
3718 `(space ...)', and specifies display in the text area, return 2
3719 rather than 1.
fee65a97 3720 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3721 accurately, and prefer exact match for point under bidi.
3722 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3723
3724 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3725 into disp_prop; all users changed.
3726
3727 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3728 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3729 for the text covered by the display property.
3730
e4ed06f1
CY
37312011-08-25 Chong Yidong <cyd@stupidchicken.com>
3732
3733 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3734 Change return value to nil.
3735 (Frecord_buffer): Delete unused function.
3736
f67cdd7f
EZ
37372011-08-24 Eli Zaretskii <eliz@gnu.org>
3738
5980d4c6
EZ
3739 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3740 buffers, return left-to-right.
8610fe8b
EZ
3741 (set_cursor_from_row): Consider candidate row a win if its glyph
3742 represents a newline and point is on that newline. Fixes cursor
3743 positioning on the newline at EOL of R2L text within L2R
3744 paragraph, and vice versa.
3745 (try_cursor_movement): Check continued rows, in addition to
3746 continuation rows. Fixes unwarranted scroll when point enters a
3747 continued line of R2L text within an L2R paragraph, or vice versa.
3748 (cursor_row_p): Consider the case of point being equal to
3749 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3750 from the end of a short line to the beginning of a continued line
3751 of R2L text within L2R paragraph.
3752 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3753 composed characters.
5980d4c6 3754
f67cdd7f
EZ
3755 * bidi.c (bidi_check_type): Use xassert.
3756 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3757 members.
3758
bca633fb
EZ
37592011-08-23 Eli Zaretskii <eliz@gnu.org>
3760
3761 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3762 a character.
3763
4a5885a7
CY
37642011-08-23 Chong Yidong <cyd@stupidchicken.com>
3765
3766 * nsfont.m (ns_otf_to_script): Fix typo.
3767
0902a04e
KH
37682011-08-22 Kenichi Handa <handa@m17n.org>
3769
3770 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3771 extra slot even if the purpose is char-code-property-table.
3772
1a2e6670
EZ
37732011-08-23 Eli Zaretskii <eliz@gnu.org>
3774
8ddde651
EZ
3775 * xdisp.c (redisplay_window): When computing centering_position,
3776 account for the height of the header line. (Bug#8874)
3777
425cc014
EZ
3778 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3779 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3780 candidate is selected by the mouse, and that candidate has a
3781 composed character under the mouse.
3782
1a2e6670
EZ
3783 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3784 coordinates reported by pos-visible-in-window-p for a composed
3785 character in column zero.
3786
8b76d6f8
SM
37872011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3788
3789 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3790
dac347dd
EZ
37912011-08-22 Eli Zaretskii <eliz@gnu.org>
3792
3793 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3794 consider it a hit if to_charpos is anywhere in the range of the
3795 composed buffer positions.
3796
e013fb34
CY
37972011-08-22 Chong Yidong <cyd@stupidchicken.com>
3798
3799 * image.c (gif_load): Don't assume that each subimage has the same
3800 dimensions as the base image. Handle disposal method that is
3801 "undefined" by the gif spec (Bug#9335).
3802
bd1ba3e8
CY
38032011-08-20 Chong Yidong <cyd@stupidchicken.com>
3804
3805 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3806 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3807
54a1215b
EZ
38082011-08-19 Eli Zaretskii <eliz@gnu.org>
3809
823564e5
EZ
3810 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3811 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3812 from an Org mode buffer to a Speedbar frame.
3813
54a1215b
EZ
3814 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3815 a composition, take its buffer position from IT->cmp_it.charpos.
3816 Fixes cursor positioning at the beginning of a line that begins
3817 with a composed character.
3818
9778ebcc
EZ
38192011-08-18 Eli Zaretskii <eliz@gnu.org>
3820
0be6ee06
EZ
3821 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3822 character bidirectional type, use STRONG_L instead. Fixes crashes
3823 in a buffer produced by `describe-categories'.
3824
9778ebcc
EZ
3825 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3826 members before the level stack, so they would be saved and
3827 restored when copying iterator state. Fixes incorrect reordering
3828 around TABs covered by display properties.
3829
156bffbe
AS
38302011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3831
6b02f655 3832 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3833
72ad093b
CY
38342011-08-17 Chong Yidong <cyd@stupidchicken.com>
3835
3836 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3837 (internal_condition_case_2, internal_condition_case_n):
3838 Remove unnecessary aborts (Bug#9081).
72ad093b 3839
35774242
EZ
38402011-08-17 Eli Zaretskii <eliz@gnu.org>
3841
3842 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3843 has no `load' handler, try opening the file locally. (Bug#9311)
3844
db76dd85
KB
38452011-08-16 Ken Brown <kbrown@cornell.edu>
3846
3847 * gmalloc.c: Expand comment.
3848
b215eee5
EZ
38492011-08-16 Eli Zaretskii <eliz@gnu.org>
3850
3851 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3852 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3853
a4579d33
KB
38542011-08-16 Ken Brown <kbrown@cornell.edu>
3855
3856 Fix memory allocation problems in Cygwin build (Bug#9273).
3857
3858 * unexcw.c ( __malloc_initialized): Declare external variable.
3859 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3860
8b76d6f8
SM
3861 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3862 New variables.
a4579d33
KB
3863 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3864 dumped emacs.
3865 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3866 in the static heap.
3867 [CYGWIN] (special_realloc): New function.
3868 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3869 requests to realloc storage in the static heap.
3870
3ebec551
PE
38712011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * bidi.c (bidi_initialize): Remove unused local.
3874
9fd8be00
EZ
38752011-08-15 Eli Zaretskii <eliz@gnu.org>
3876
6b02f655
SM
3877 * bidimirror.h:
3878 * biditype.h: Remove file.
3879 * makefile.w32-in ($(BLD)/bidi.$(O)):
3880 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3881
3882 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3883
3884 * chartab.c: Improve commentary for the uniprop_table API.
3885
32413314
EZ
3886 * bidi.c (bidi_paragraph_init): Support zero value of
3887 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3888 (bidi_initialize): Use uniprop_table instead of including
3889 biditype.h and bidimirror.h.
32413314 3890
9fd8be00
EZ
3891 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3892 coordinates of the iterator when restoring from ppos_it.
3893 (Bug#9296)
3894
5cf2b69b
KH
38952011-08-14 Kenichi Handa <handa@m17n.org>
3896
3897 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3898 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3899
daf17d00
EZ
39002011-08-14 Eli Zaretskii <eliz@gnu.org>
3901
3902 * xdisp.c (move_it_in_display_line_to): Don't invoke
3903 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3904 ppos_it. Fixes vertical cursor motion when line beginning is
3905 covered by an image. (Bug#9296)
3906
08e3161a
JD
39072011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3908
3909 * nsterm.h (ns_run_ascript): Declare.
3910 (NSAPP_DATA2_RUNASSCRIPT): Define.
3911
3912 * nsfns.m (as_script, as_result, as_status): New static variables.
3913 (ns_run_ascript): New function.
5e617bc2 3914 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3915 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3916 the event loop. Get status from as_status (Bug#7276).
3917
3918 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3919 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3920 the event loop (Bug#7276).
3921
a3720aa2
AS
39222011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3923
3924 * gnutls.c (QCgnutls_bootprop_priority)
3925 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3926 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3927 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3928 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3929 (QCgnutls_bootprop_verify_hostname_error)
3930 (QCgnutls_bootprop_callbacks_verify): Rename from
3931 Qgnutls_bootprop_..., all uses changed.
3932
3933 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3934 uses changed.
3935
0a0d27fb
PE
39362011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3937
19d5c50c
PE
3938 * xfaces.c (Qframe_set_background_mode): Now static.
3939 * dispextern.h (Qframe_set_background_mode): Remove decl.
3940
0a0d27fb
PE
3941 * process.c (Fnetwork_interface_info): Declare local only if needed.
3942
377538cb
JD
39432011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3944
3945 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3946 (Fnetwork_interface_list): Allocate in increments of bytes instead
3947 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3948 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3949 sockaddr.
3950 (struct ifflag_def): notrailers is smart on OSX.
3951 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3952 Get hardware address with getifaddrs if available.
3953
08fff70c
EZ
39542011-08-12 Eli Zaretskii <eliz@gnu.org>
3955
3956 * xdisp.c (iterate_out_of_display_property): xassert that
3957 IT->position is set to within IT->object's boundaries. Break from
3958 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3959 when IT->position is set up wrongly due to some bug.
3960 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3961 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3962 entry. Force push_it to save on the stack the current
3963 buffer/string position, to be restored by pop_it. Fix flags in
3964 the iterator structure wrt the object coming from a display
3965 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3966 properties. (Bug#9284)
3967
7be1c708 39682011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3969
7be1c708
CY
3970 * fontset.c (fontset_get_font_group): Add proper type checks.
3971 (Bug#9172)
aac0c6e3 3972
7be1c708 39732011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3974
7be1c708
CY
3975 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3976 and LC_VERSION_MIN_MACOSX.
3977 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3978 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3979
97bb72a6
EZ
39802011-08-08 Eli Zaretskii <eliz@gnu.org>
3981
3982 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3983 no-display-properties-and-no-overlays under bidi display.
3984 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3985 properties and overlays.
97bb72a6 3986
d5617611
CY
39872011-08-08 Chong Yidong <cyd@stupidchicken.com>
3988
37e11a63
CY
3989 * editfns.c (Fset_time_zone_rule): Document relationship with the
3990 setenv function.
3991
d5617611
CY
3992 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3993 the font entity extracted from the cache (Bug#8109).
3994
58872834
CY
39952011-08-07 Chong Yidong <cyd@stupidchicken.com>
3996
3997 * composite.c (autocmp_chars): Don't reset point. That is done by
3998 restore_point_unwind (Bug#5984).
3999
75bfc667
JL
40002011-08-07 Juri Linkov <juri@jurta.org>
4001
4002 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4003 to show the arg `TIME' instead of `TIMEVAL'.
4004
d1410150
EZ
40052011-08-06 Eli Zaretskii <eliz@gnu.org>
4006
4007 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4008 display property strides EOL and includes a newline, as in
4009 longlines-mode. (Bug#9254)
75b771e4
EZ
4010 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4011 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4012
4013 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4014 is non-zero, even if the data buffer is NULL. Fixes a crash in
4015 vertical-motion with longlines-mode. (Bug#9254)
4016
35928349
EZ
40172011-08-05 Eli Zaretskii <eliz@gnu.org>
4018
ec7cc85b
EZ
4019 * bidi.c <bidi_cache_total_alloc>: Now static.
4020 (bidi_initialize): Initialize bidi_cache_total_alloc.
4021
8b76d6f8 4022 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4023 cache. (Bug#9221)
4024
4025 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4026 amount allocated this far in `bidi_cache_total_alloc'.
4027 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4028 non-zero, only free the data buffer without restoring the cache
4029 contents. All callers changed.
4030
4031 * dispextern.h (bidi_unshelve_cache): Update prototype.
4032
4033 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4034 (move_it_in_display_line, move_it_to)
4035 (move_it_vertically_backward, move_it_by_lines): Replace the call
4036 to xfree to an equivalent call to bidi_unshelve_cache.
4037 (move_it_in_display_line_to): Fix logic of returning
412b6358 4038 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 4039
e2e2423b
EZ
40402011-08-05 Eli Zaretskii <eliz@gnu.org>
4041
4042 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4043 came from a string character with a `cursor' property. (Bug#9229)
4044
ae9e757a
JD
40452011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4046
4047 * Makefile.in (LIB_PTHREAD): New variable.
4048 (LIBES): Add LIB_PTHREAD (Bug#9216).
4049
4050 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4051 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4052
213bd7f2
AS
40532011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4054
6b02f655 4055 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4056
99aaf75f
JD
40572011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4058
4059 * xterm.c (x_find_topmost_parent): New function.
4060 (x_set_frame_alpha): Find topmost parent window with
4061 x_find_topmost_parent and set the property there also (bug#9181).
4062 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4063
c74e9d86
PE
40642011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4065
4066 * callproc.c (Fcall_process): Avoid vfork clobbering
4067 the local vars buffer, coding_systems, current_dir.
4068
640c8776
SM
40692011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4070
4071 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4072
f26d0e4c
PE
40732011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4074
8a10d76c
PE
4075 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4076 so that it is not optimized away.
4077
f26d0e4c
PE
4078 * xdisp.c (compute_display_string_pos): Remove unused local.
4079
55439c61
EZ
40802011-08-02 Eli Zaretskii <eliz@gnu.org>
4081
4082 Fix slow cursor motion and scrolling in large buffers with
4083 selective display, like Org Mode buffers. (Bug#9218)
4084
4085 * dispextern.h (struct bidi_it): New member disp_prop_p.
4086
4087 * xdisp.c: Remove one-slot cache of display string positions.
4088 (compute_display_string_pos): Accept an additional argument
5e617bc2 4089 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4090 for a display string or property. If found, set DISP_PROP_P
4091 non-zero.
4092
4093 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4094 DISP_PROP_P, and pass it to compute_display_string_pos.
4095 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4096 non-zero. All callers of bidi_fetch_char changed.
4097
fb33fa43
SM
40982011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4099
4100 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4101
b099e063
DM
41022010-12-03 Don March <don@ohspite.net>
4103
4104 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4105 last character M-[char] is translated to ESC [char] (bug#7541).
4106
5cc7f7af
KH
41072011-08-02 Kenichi Handa <handa@m17n.org>
4108
d0fffa3f 4109 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4110
4111 * chartab.c (uniprop_table): Make it non-static.
4112
525d5e6e
EZ
41132011-08-01 Eli Zaretskii <eliz@gnu.org>
4114
4115 * xdisp.c (forward_to_next_line_start): Accept additional argument
4116 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4117 on the newline.
4118 (reseat_at_next_visible_line_start): Use the bidi iterator state
4119 returned by forward_to_next_line_start to restore the state of
4120 it->bidi_it after backing up to previous newline. (Bug#9212)
4121
31011111
AS
41222011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4123
4124 * regex.c (re_comp): Protoize.
4125 (re_exec): Fix return type.
4126 (regexec): Fix type of `ret'. (Bug#9203)
4127
476371c4
PE
41282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4129
e5d76069
PE
4130 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4131 This is needed if max-image-size is a floating-point number.
4132
9a79b20c
AS
41332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4134
4135 * print.c (print_object): Print empty symbol as ##.
4136
4137 * lread.c (read1): Read ## as empty symbol.
4138
d8c2fa78
AA
41392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4140
4141 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4142 setting frame foreground color (Bug#9175).
4143 (x_set_background_color): Likewise.
4144
ffe57a7a
AA
4145 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4146 contents (Bug#9176).
4147 (EmacsTooltip -init): Remove bezels and add shadows to
4148 tooltip windows.
4149
bf3492a5
AA
4150 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4151 or scroll bar (Bug#8470).
4152
d55e9c53
AA
4153 * nsfont.m (nsfont_open): Remove assignment to voffset and
4154 unnecessary vars hshink, expand, hd, full_height, min_height.
4155 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4156
4157 * nsterm.h (nsfont_info): Remove voffset field.
4158
d8c2fa78 41592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4160
4161 Implement strike-through and overline on NextStep (Bug#8863).
4162
4163 * nsfont.m (nsfont_open): Use underline position provided by font,
4164 instead of hard-coded value of 2.
4165 (nsfont_draw): Call ns_draw_text_decoration instead.
4166
4167 * nsterm.h: Add declaration for ns_draw_text_decoration.
4168
4169 * nsterm.m (ns_draw_text_decoration): New function for drawing
4170 underline, overline, and strike-through.
4171 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4172 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4173 accommodate underlining, etc.
4843aac3 4174
4cc60b9b
EZ
41752011-07-28 Eli Zaretskii <eliz@gnu.org>
4176
bc7ece87
EZ
4177 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4178 default.
4cc60b9b 4179
476371c4
PE
41802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4181
66606eea
PE
4182 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4183 Without this fix, if a signal arrives just after memory fills up,
4184 'malloc' might be invoked reentrantly.
4185
476371c4
PE
4186 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4187 In other words, assume that every image size is allowed, on non-X
4188 hosts. This assumption is probably wrong, but it lets Emacs compile.
4189
f3fcc40d
AS
41902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4191
4192 * regex.c (re_iswctype): Convert return values to boolean.
4193
350c992f
EZ
41942011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4195
4196 * xdisp.c (compute_display_string_pos): Don't use cached display
4197 string position if the buffer had its restriction changed.
4198 (Bug#9184)
4199
5266b4bb
PE
42002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4201
4202 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4203
2573a837 42042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4205
41f55ccd 4206 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4207
39e378da
PE
4208 * bidi.c: Integer size and overflow fixes.
4209 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4210 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4211 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4212 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4213 (bidi_find_other_level_edge):
4214 Use ptrdiff_t instead of EMACS_INT where either will do.
4215 This works better on 32-bit hosts configured --with-wide-int.
4216 (bidi_cache_ensure_space): Check for size-calculation overflow.
4217 Use % rather than repeated addition, for better worst-case speed.
4218 Don't set bidi_cache_size until after xrealloc returns, because it
4219 might not return.
4220 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4221 (bidi_cache_ensure_space): Also check that the bidi cache size
4222 does not exceed that of the largest Lisp string or buffer. See Eli
4223 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4224
5e927815
PE
4225 * alloc.c (__malloc_size_t): Remove.
4226 All uses replaced by size_t. See Andreas Schwab's note
4227 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4228
ca4aa935
PE
4229 * image.c: Improve checking for integer overflow.
4230 (check_image_size): Assume that f is nonnull, since
4231 it is always nonnull in practice. This is one less thing to
4232 worry about when checking for integer overflow later.
4233 (x_check_image_size): New function, which checks for integer
4234 overflow issues inside X.
4235 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4236 This removes the need for a memory_full check.
4237 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4238 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4239 (xbm_read_bitmap_data): Change locals back to 'int', since
4240 their values must fit in 'int'.
4241 (xpm_load_image, png_load, tiff_load):
4242 Invoke x_create_x_image_and_pixmap earlier,
4243 to avoid much needless work if the image is too large.
4244 (tiff_load): Treat overly large images as if
4245 x_create_x_image_and_pixmap failed, not as malloc failures.
4246 (gs_load): Use x_check_image_size.
4247
5f8f9cc2
PE
4248 * gtkutil.c: Omit integer casts.
4249 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4250 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4251
5adf60bc
PE
4252 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4253
c8907a93
PE
4254 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4255 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4256 would wrongly return t on a 64-bit host.
4257
e3c25c68
PE
4258 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4259 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4260 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4261 and therefore cause GCC to emit a bogus diagnostic in some cases.
4262
3f791afe
PE
4263 * image.c: Integer signedness and overflow and related fixes.
4264 This is not an exhaustive set of fixes, but it's time to
4265 record what I've got.
4266 (lookup_pixel_color, check_image_size): Remove redundant decls.
4267 (check_image_size): Don't assume that arbitrary EMACS_INT values
4268 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4269 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4270 (tiff_load, imagemagick_load_image):
4271 Check for overflow in size calculations.
4272 (x_create_x_image_and_pixmap): Remove unnecessary test for
4273 xmalloc returning NULL; that can't happen.
4274 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4275 (xpm_color_bucket): Use better integer hashing function.
4276 (xpm_cache_color): Don't possibly over-allocate memory.
4277 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4278 (gif_memory_source):
4279 Use ptrdiff_t, not int or size_t, to record sizes.
4280 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4281 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4282 either works, as we prefer signed integers.
4283 (tiff_read_from_memory, tiff_write_from_memory):
4284 Return tsize_t, not size_t, since that's what the TIFF API wants.
4285 (tiff_read_from_memory): Don't fail simply because the read would
4286 go past EOF; instead, return a short read.
4287 (tiff_load): Omit no-longer-needed casts.
4288 (Fimagemagick_types): Don't assume size fits into 'int'.
4289
3cc5a532
PE
4290 Improve hashing quality when configured --with-wide-int.
4291 * fns.c (hash_string): New function, taken from sxhash_string.
4292 Do not discard information about ASCII character case; this
4293 discarding is no longer needed.
4294 (sxhash-string): Use it. Change sig to match it. Caller changed.
4295 * lisp.h: Declare it.
4296 * lread.c (hash_string): Remove, since we now use fns.c's version.
4297 The fns.c version returns a wider integer if --with-wide-int is
4298 specified, so this should help the quality of the hashing a bit.
4299
b312a492
PE
4300 * emacs.c: Integer overflow minor fix.
4301 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4302 Define only if GNU_LINUX.
4303 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4304
dfd153ae
PE
4305 * dispnew.c: Integer signedness and overflow fixes.
4306 Remove unnecessary forward decls, that were a maintenance hassle.
4307 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4308 All uses changed.
4309 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4310 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4311 (prepare_desired_row, line_draw_cost):
4312 Use int, not unsigned, where either works.
4313 (save_current_matrix, restore_current_matrix):
4314 Use ptrdiff_t, not size_t, where either works.
4315 (init_display): Check for overflow more accurately, and without
4316 relying on undefined behavior.
4317
a81d11a3
PE
4318 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4319 Remove, replacing with the new symbols in lisp.h. All uses changed.
4320 * fileio.c (make_temp_name):
4321 * filelock.c (lock_file_1, lock_file):
4322 * xdisp.c (message_dolog):
4323 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4324 Use pMd etc. instead.
4325 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4326 replacing the pWIDE etc. symbols removed from editfns.c.
4327
3300e6fd
PE
4328 * keyboard.h (num_input_events): Now uintmax_t.
4329 This is (very slightly) less likely to mess up due to wraparound.
4330 All uses changed.
4331
fd05c7e9
PE
4332 * buffer.c: Integer signedness fixes.
4333 (alloc_buffer_text, enlarge_buffer_text):
4334 Use ptrdiff_t rather than size_t when either will do, as we prefer
4335 signed integers.
4336
903fe15d
PE
4337 * alloc.c: Integer signedness and overflow fixes.
4338 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4339 (__malloc_size_t): Default to size_t, not to int.
4340 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4341 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4342 Prefer ptrdiff_t to size_t when either would do, as we prefer
4343 signed integers.
4344 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4345 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4346 Now const. Initialize with values that are in range even if char
4347 is signed.
4348 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4349 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4350 These functions do the right thing with sizes > 2**32.
4351 (check_depth): Now ptrdiff_t, not int.
4352 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4353 Adjust to new way of storing sizes. Check for size overflow bugs
4354 in rest of code.
4355 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4356 slightly wrong anyway, as it missed one instance of
4357 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4358 (refill_memory_reserve): Omit needless cast to size_t.
4359 (mark_object_loop_halt): Mark as externally visible.
4360
ac82cc6a
PE
4361 * xselect.c: Integer signedness and overflow fixes.
4362 (Fx_register_dnd_atom, x_handle_dnd_message):
4363 Use ptrdiff_t, not size_t, since we prefer signed.
4364 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4365 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4366 x_dnd_atoms_size and x_dnd_atoms_length.
4367
c2d1e36d
PE
4368 * doprnt.c: Prefer signed to unsigned when either works.
4369 * eval.c (verror):
4370 * doprnt.c (doprnt):
4371 * lisp.h (doprnt):
4372 * xdisp.c (vmessage):
4373 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4374 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4375 prefer signed arithmetic to avoid comparison confusion.
4376 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4377 but is a bit tricky.
4378
0e926e56
PE
4379 Assume freestanding C89 headers, string.h, stdlib.h.
4380 * data.c, doprnt.c, floatfns.c, print.c:
4381 Include float.h unconditionally.
4382 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4383 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4384 * regex.c: Likewise for stddef.h, string.h.
4385 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4386 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4387 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4388 (STDC_HEADERS): Remove obsolete defines.
4389 * sysdep.c: Include limits.h unconditionally.
4390
9cfdb3ec
PE
4391 Assume support for memcmp, memcpy, memmove, memset.
4392 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4393 * regex.c (memcmp, memcpy):
4394 Remove; we assume C89 now.
4395
4396 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4397 (__malloc_safe_bcopy): Remove; no longer needed.
4398
cf950e6b 4399 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4400 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4401 well either way, and we prefer signed to unsigned.
4402
dbf38e02
LMI
44032011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4404
4405 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4406 closes the connection while we're reading (bug#9182).
4407
d6f0886c 44082011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4409
d6f0886c
JD
4410 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4411 are specified (Bug#9168).
24e0f6b1 4412
2eb1f9e6
PE
44132011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4414
4415 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4416 Found by GCC static checking and --with-wide-int on a 32-bit host.
4417
22381272 44182011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4419
4420 * xdisp.c (compute_display_string_pos): Fix logic of caching
4421 previous display string position. Initialize cached_prev_pos to
4422 -1. Fixes slow-down at the beginning of a buffer.
4423
f25e39b4
EZ
44242011-07-24 Eli Zaretskii <eliz@gnu.org>
4425
4426 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4427 for attrs[LFACE_FONTSET_INDEX].
4428
04c4b52e
PE
44292011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4430
4431 * xml.c (parse_region): Remove unused local
4432 that was recently introduced.
4433
c1734fbd
EZ
44342011-07-23 Eli Zaretskii <eliz@gnu.org>
4435
be18c5a5
EZ
4436 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4437 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4438
c1734fbd
EZ
4439 * xdisp.c (move_it_in_display_line_to): Record the best matching
4440 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4441 exit if none of the characters scanned was an exact match.
4442 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4443 when exact match is impossible due to invisible text, and the
4444 lines are truncated.
4445
a258d627
JD
44462011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4447
4448 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4449 for OSX >= 10.7.
4450
b6d5a689
EZ
44512011-07-22 Eli Zaretskii <eliz@gnu.org>
4452
0f74f785
EZ
4453 Fix a significant slow-down of cursor motion with C-n, C-p,
4454 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4455 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4456 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4457 (next_element_from_buffer): Call compute_stop_pos_backwards to
4458 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4459 base_level_stop.
4460 (reseat): Don't look for prev_stop, as that could mean a very long
4461 run.
4462 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4463 <cached_disp_overlay_modiff>: Cache for last found display string
4464 position.
551918c1 4465 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4466 about the same buffer in the same area of character positions, and
4467 the buffer wasn't changed since the time the display string
4468 position was cached.
551918c1 4469
b2d0c91a
EZ
44702011-07-22 Eli Zaretskii <eliz@gnu.org>
4471
4472 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4473 is an integer, which is important for empty lines. (Bug#9149)
4474
043604ee
CY
44752011-07-22 Chong Yidong <cyd@stupidchicken.com>
4476
4477 * frame.c (Fmodify_frame_parameters): In tty case, update the
4478 default face if necessary (Bug#4238).
4479
da4adb04
CY
44802011-07-21 Chong Yidong <cyd@stupidchicken.com>
4481
4482 * editfns.c (Fstring_to_char): No need to explain what a character
4483 is in the docstring (Bug#6576).
4484
9abd0532
LMI
44852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4486
4487 * xml.c (parse_region): Make sure we always return a tree.
4488
36881d16
HK
44892011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4490
4491 * xml.c (parse_region): If a document contains only comments,
4492 return that, too.
4493
1e98674d
LMI
44942011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4495
4496 * xml.c (make_dom): Return comments, too.
4497
590bd467
PE
44982011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4499
4500 Port to OpenBSD.
4501 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4502 and the surrounding thread.
4503 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4504 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4505 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4506 timer goes off.
4507 * s/openbsd.h (BROKEN_SIGIO): Define.
4508 * unexelf.c (unexec) [__OpenBSD__]:
4509 Don't update the .mdebug section of the Alpha COFF symbol table.
4510
f41628b2
LMI
45112011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4512
4513 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4514 (bug#8460).
4515
b59b67c5
PE
45162011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4517
15e3a074
PE
4518 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4519 This fixes some race conditions on the permissions of any newly
4520 created file.
4521
41bed37d
PE
4522 * alloc.c (valid_pointer_p): Use pipe, not open.
4523 This fixes some permissions issues when debugging.
4524
b59b67c5
PE
4525 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4526 If fchown fails to set both uid and gid, try to set just gid,
4527 as that is sometimes allowed. Adjust the file's mode to eliminate
4528 setuid or setgid bits that are inappropriate if fchown fails.
4529
925a6be7
SM
45302011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4531
4532 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4533 to compare Lisp_Objects.
4534 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4535 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4536 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4537
52968808
AS
45382011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4539
0a6a104b
AS
4540 * lread.c (read_integer): Unread even EOF character.
4541 (read1): Likewise. Properly record start position of symbol.
4542
52968808
AS
4543 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4544 symbol character follows.
4545
9e381cdd
PE
45462011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4547
4548 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4549 This works around a problem with the previous change to Fcopy_file.
4550 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4551 and without this change, GCC might complain about discarding
4552 fchown's return value.
4553
b5641435
JB
45542011-07-16 Juanma Barranquero <lekktu@gmail.com>
4555
4556 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4557
a8031457
PE
45582011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4559
4560 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4561
dd889327
LMI
45622011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4563
750c33f7
LMI
4564 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4565 it's used from the C level.
4566
dd889327
LMI
4567 * process.c: Use the same condition for POLL_FOR_INPUT in both
4568 keyboard.c and process.c (bug#1858).
4569
87e86684
LM
45702011-07-09 Lawrence Mitchell <wence@gmx.li>
4571
4572 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4573 (Fgnutls_boot): Use it.
4574
64348f40
AS
45752011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4576
4577 * doc.c (Fsubstitute_command_keys): Revert last change.
4578
1d698799
LMI
45792011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4580
f863868c
LMI
4581 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4582 quotes the next character, and doesn't affect other longer
4583 sequences (bug#8935).
4584
1d698799
LMI
4585 * lread.c (syms_of_lread): Clarify that is isn't only
4586 `eval-buffer' and `eval-defun' that's affected by
4587 `lexical-binding' (bug#8460).
4588
aa4b6df6
EZ
45892011-07-15 Eli Zaretskii <eliz@gnu.org>
4590
4591 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4592 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4593
5d856da6
PE
45942011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4595
ad6042bb
PE
4596 Fix minor problems found by static checking.
4597 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4598 (elsz): Now a signed constant, not a size_t var. We prefer signed
4599 types to unsigned, to avoid integer comparison confusion. Without
4600 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4601 "cannot optimize loop, the loop counter may overflow", a symptom
4602 of the confusion.
f00bbb22 4603 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4604 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4605
6468f31c
LMI
46062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4607
49080b10
LMI
4608 * search.c (Fre_search_backward): Mention `case-fold-search' in
4609 all the re_search_* functions (bug#8138).
4610
6468f31c
LMI
4611 * keyboard.c (Fopen_dribble_file): Document when the file is
4612 closed (bug#8056).
4613
c965adc5
EZ
46142011-07-14 Eli Zaretskii <eliz@gnu.org>
4615
df9733bf
EZ
4616 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4617 bidi_cache_idx.
4618
0bb23927
EZ
4619 Support bidi reordering of display and overlay strings.
4620 * xdisp.c (compute_display_string_pos)
4621 (compute_display_string_end): Accept additional argument STRING.
4622 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4623 (reseat_to_string): Initialize bidi_it->string.s and
4624 bidi_it->string.schars.
4625 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4626 NULL (avoids a crash in bidi_paragraph_init).
4627 Initialize itb.string.lstring.
0bb23927
EZ
4628 (init_iterator): Call bidi_init_it only of a valid
4629 buffer position was specified. Initialize paragraph_embedding to
4630 L2R.
4631 (reseat_to_string): Initialize the bidi iterator.
4632 (display_string): If we need to ignore text properties of
4633 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4634 original value of -1 will not work with bidi.)
4635 (compute_display_string_pos): First arg is now struct
4636 `text_pos *'; all callers changed. Support display properties on
4637 Lisp strings.
4638 (compute_display_string_end): Support display properties on Lisp
4639 strings.
4640 (init_iterator, reseat_1, reseat_to_string): Initialize the
4641 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4642 when iterating on a string not from display properties).
640c8776
SM
4643 (compute_display_string_pos, compute_display_string_end):
4644 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4645 arrow keys.
4646 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4647 base_level_stop; instead, set base_level_stop to BEGV.
4648 Fixes crashes in vertical-motion.
0bb23927
EZ
4649 (next_element_from_buffer): Improve commentary for when
4650 the iterator is before prev_stop.
4651 (init_iterator): Initialize bidi_p from the default value of
4652 bidi-display-reordering, not from buffer-local value. Use the
4653 buffer-local value only if initializing for buffer iteration.
4654 (handle_invisible_prop): Support invisible properties on strings
4655 that are being bidi-reordered.
4656 (set_iterator_to_next): Support bidi reordering of C strings and
4657 Lisp strings.
4658 (next_element_from_string): Support bidi reordering of Lisp
4659 strings.
4660 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4661 (display_string): Support display of R2L glyph rows.
4662 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4663 (init_iterator): Don't initialize it->bidi_p for strings
4664 here.
4665 (reseat_to_string): Initialize it->bidi_p for strings here.
4666 (next_element_from_string, next_element_from_c_string)
4667 (next_element_from_buffer): Add xassert's for correspondence
4668 between IT's object being iterated and it->bidi_it.string
4669 structure.
4670 (face_before_or_after_it_pos): Support bidi iteration.
4671 (next_element_from_c_string): Handle the case of the first string
4672 character that is not the first one in the visual order.
4673 (get_visually_first_element): New function, refactored from common
4674 parts of next_element_from_buffer, next_element_from_string, and
4675 next_element_from_c_string.
4676 (tool_bar_lines_needed, redisplay_tool_bar)
4677 (display_menu_bar): Force left-to-right direction. Add a FIXME
4678 comment for making that be controlled by a user option.
4679 (push_it, pop_it): Save and restore the state of the
4680 bidi iterator. Save and restore the bidi_p flag.
4681 (pop_it): Iterate out of display property for string iteration as
4682 well.
4683 (iterate_out_of_display_property): Support iteration over strings.
4684 (handle_single_display_spec): Set up it->bidi_it for iteration
4685 over a display string, and call bidi_init_it.
4686 (handle_single_display_spec, next_overlay_string)
4687 (get_overlay_strings_1, push_display_prop): Set up the bidi
4688 iterator for displaying display or overlay strings.
4689 (forward_to_next_line_start): Don't use the shortcut if
4690 bidi-iterating.
4691 (back_to_previous_visible_line_start): If handle_display_prop
4692 pushed the iterator stack, restore the internal state of the bidi
4693 iterator by calling bidi_pop_it same number of times.
4694 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4695 and we are bidi-iterating, don't decrement the iterator position;
4696 instead, set the first_elt flag in the bidi iterator, to produce
4697 the same effect.
4698 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4699 (push_display_prop): xassert that we are iterating a buffer.
4700 (push_it, pop_it): Save and restore paragraph_embedding member.
4701 (handle_single_display_spec, next_overlay_string)
4702 (get_overlay_strings_1, reseat_1, reseat_to_string)
4703 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4704 correctly. Don't assume unibyte strings are not bidi-reordered.
4705 (compute_display_string_pos)
4706 (compute_display_string_end): Fix handling the case of C string.
4707 (push_it, pop_it): Save and restore from_disp_prop_p.
4708 (handle_single_display_spec, push_display_prop): Set the
4709 from_disp_prop_p flag.
4710 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4711 (pop_it): Call iterate_out_of_display_property only if we are
4712 popping after iteration over a string that came from a display
4713 property. Fix a typo in popping stretch info. Add an assertion
4714 for verifying that the iterator position is in sync with the bidi
4715 iterator.
4716 (handle_single_display_spec, get_overlay_strings_1)
4717 (push_display_prop): Fix initialization of paragraph direction for
4718 string when that of the parent object is not yet determined.
4719 (reseat_1): Call bidi_init_it to resync the bidi
4720 iterator with IT's position. (Bug#7616)
4721 (find_row_edges): If ROW->start.pos gives position
4722 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4723 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4724 Reset the from_disp_prop_p flag.
4725 (SAVE_IT, RESTORE_IT): New macros.
4726 (pos_visible_p, face_before_or_after_it_pos)
4727 (back_to_previous_visible_line_start)
4728 (move_it_in_display_line_to, move_it_in_display_line)
4729 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4730 (try_scrolling, redisplay_window, display_line): Use them when
4731 saving a temporary copy of the iterator and restoring it back.
4732 (back_to_previous_visible_line_start, reseat_1)
4733 (init_iterator): Empty the bidi cache "stack".
4734 (move_it_in_display_line_to): If iterator ended up at
4735 EOL, but we never saw any buffer positions smaller than
4736 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4737 motion in bidi-reordered lines.
4738 (move_it_in_display_line_to): Record prev_method and prev_pos
4739 immediately before the call to set_iterator_to_next. Fixes cursor
4740 motion in bidi-reordered lines with stretch glyphs and strings
4741 displayed in margins. (Bug#8133) (Bug#8867)
4742 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4743 TO_CHARPOS.
640c8776
SM
4744 (pos_visible_p): Support positions in bidi-reordered lines.
4745 Save and restore bidi cache.
0bb23927
EZ
4746
4747 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4748 (bidi_paragraph_info): Delete unused struct.
4749 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4750 (bidi_cache_start): New variable.
4751 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4752 to zero.
4753 (bidi_cache_fetch_state, bidi_cache_search)
4754 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4755 (bidi_cache_find, bidi_peek_at_next_level)
4756 (bidi_level_of_next_char, bidi_find_other_level_edge)
4757 (bidi_move_to_visually_next): Compare cache index with
4758 bidi_cache_start rather than with zero.
4759 (bidi_fetch_char): Accept new argument STRING; all callers
4760 changed. Support iteration over a string. Support strings with
4761 display properties. Support unibyte strings. Fix the type of
4762 `len' according to what STRING_CHAR_AND_LENGTH expects.
4763 (bidi_paragraph_init, bidi_resolve_explicit_1)
4764 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4765 (bidi_level_of_next_char, bidi_move_to_visually_next):
4766 Support iteration over a string.
0bb23927
EZ
4767 (bidi_set_sor_type, bidi_resolve_explicit_1)
4768 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4769 can now be zero (for strings); special values 0 and -1 were
4770 changed to -1 and -2, respectively.
4771 (bidi_char_at_pos): New function.
4772 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4773 Call it instead of FETCH_MULTIBYTE_CHAR.
4774 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4775 initialized to valid values.
4776 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4777 values.
4778 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4779 the test for valid cached positions. Fix the logic for looking up
4780 the sentinel state in the cache. GCPRO the Lisp string we are
4781 iterating.
4782 (bidi_push_it, bidi_pop_it): New functions.
4783 (bidi_initialize): Initialize the bidi cache start stack pointer.
4784 (bidi_cache_ensure_space): New function, refactored from part of
4785 bidi_cache_iterator_state. Don't assume the required size is just
4786 one BIDI_CACHE_CHUNK away.
4787 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4788 (bidi_count_bytes, bidi_char_at_pos): New functions.
4789 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4790 always valid if bidi_cache_idx is valid.
4791 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4792 is valid if it's going to be used.
4793 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4794 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4795 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4796 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4797 (bidi_find_other_level_edge, bidi_cache_start_stack):
4798 All variables related to cache indices are now EMACS_INT.
c965adc5 4799
0bb23927
EZ
4800 * dispextern.h (struct bidi_string_data): New structure.
4801 (struct bidi_it): New member `string'. Make flag members be 1-bit
4802 fields, and put them last in the struct.
640c8776
SM
4803 (compute_display_string_pos, compute_display_string_end):
4804 Update prototypes.
0bb23927
EZ
4805 (bidi_push_it, bidi_pop_it): Add prototypes.
4806 (struct iterator_stack_entry): New members bidi_p,
4807 paragraph_embedding, and from_disp_prop_p.
4808 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4809 (bidi_shelve_cache, bidi_unshelve_cache):
4810 Declare prototypes.
0bb23927
EZ
4811
4812 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4813 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4814 and vector-like objects.
4815
4816 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4817 cache around display iteration.
4818
4819 * window.c (Fwindow_end, window_scroll_pixel_based)
4820 (displayed_window_lines, Frecenter): Save and restore the bidi
4821 cache around display iteration.
4822
3bbd2265
LMI
48232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4824
4825 * editfns.c (Fdelete_region): Clarify the use of the named
4826 parameters (bug#6788).
4827
adc47434
MR
48282011-07-14 Martin Rudalics <rudalics@gmx.at>
4829
4830 * indent.c (Fvertical_motion): Set and restore w->pointm when
4831 saving and restoring the window's buffer (Bug#9006).
4832
837c31f8
LMI
48332011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4834
4835 * editfns.c (Fstring_to_char): Clarify just what is returned
4836 (bug#6576). Text by Eli Zaretskii.
4837
ac389d0c
JB
48382011-07-13 Juanma Barranquero <lekktu@gmail.com>
4839
4840 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4841
0be0ce47
EZ
48422011-07-13 Eli Zaretskii <eliz@gnu.org>
4843
4844 * buffer.c (mmap_find): Fix a typo.
4845
cd18e7e3
JB
48462011-07-13 Johan Bockgård <bojohan@gnu.org>
4847
4848 Fix execution of x selection hooks.
4849 * xselect.c (Qx_lost_selection_functions)
4850 (Qx_sent_selection_functions): New vars.
4851 (syms_of_xselect): DEFSYM them.
4852 (x_handle_selection_request): Pass Qx_sent_selection_functions
4853 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4854 (x_handle_selection_clear,x_clear_frame_selections):
4855 Pass Qx_lost_selection_functions rather than
4856 Vx_lost_selection_functions to Frun_hook_with_args.
4857
47ea7f44
PE
48582011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4859
ac389d0c 4860 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4861 The old code sometimes used this field without initializing it.
4862
47ea7f44
PE
4863 * alloc.c (gc_sweep): Don't read past end of array.
4864 In theory, the old code could also have corrupted Emacs internals,
4865 though it'd be very unlikely.
4866
bc985c87
AS
48672011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4868
4869 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4870 argument. (Bug#4026)
bc985c87 4871
0cf34688
LMI
48722011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4873
b3dadd76
LMI
4874 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4875 key" (bug#4257).
4876
0cf34688
LMI
4877 * window.c (Fset_window_start): Doc fix (bug#4199).
4878 (Fset_window_hscroll): Ditto.
4879
270768cd
PE
48802011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4881
077e3dda 4882 Fix minor new problems caught by GCC 4.6.1.
270768cd 4883 * term.c (init_tty): Remove unused local.
490011a6 4884 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4885 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4886 not used otherwise.
270768cd 4887
b1f58454
CY
48882011-07-12 Chong Yidong <cyd@stupidchicken.com>
4889
4890 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4891
22b9578d
LMI
48922011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4893
6e70ab07
LMI
4894 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4895 are the mini-buffer and the echo area (bug#3320).
4896
22b9578d
LMI
4897 * term.c (init_tty): Remove support for supdup, c10 and perq
4898 terminals, which are no longer supported (bug#1482).
4899
8974cc9f
JB
49002011-07-10 Johan Bockgård <bojohan@gnu.org>
4901
4902 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4903
a560d974
JD
49042011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4905
4906 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4907 for non-popups (Bug#3642).
4908
1dae0f0a
AS
49092011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4910
268c2c36 4911 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4912 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4913 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4914 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4915 * data.c (fmod): Likewise.
4916 * dispnew.c (swap_glyphs_in_rows): Likewise.
4917 * emacs.c (memory_warning_signal): Likewise.
4918 * floatfns.c (float_error): Likewise.
4919 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4920 (otf_open, font_otf_capability, generate_otf_features)
4921 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4922 Likewise.
4923 * image.c (pbm_read_file): Likewise.
4924 * indent.c (string_display_width): Likewise.
4925 * intervals.c (check_for_interval, search_for_interval)
4926 (inc_interval_count, count_intervals, root_interval)
4927 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4928 * lread.c (defalias): Likewise.
268c2c36 4929 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4930 * regex.c (set_image_of_range_1, set_image_of_range)
4931 (regex_grow_registers): Likewise.
4932 * sysdep.c (strerror): Likewise.
4933 * termcap.c (valid_filename_p, tprint, main): Likewise.
4934 * tparam.c (main): Likewise.
4935 * unexhp9k800.c (run_time_remap, save_data_space)
4936 (update_file_ptrs, read_header, write_header, calculate_checksum)
4937 (copy_file, copy_rest, display_header): Likewise.
4938 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4939 Likewise.
4940 * xdisp.c (check_it): Likewise.
4941 * xfaces.c (register_color, unregister_color, unregister_colors):
4942 Likewise.
4943 * xfns.c (print_fontset_result): Likewise.
4944 * xrdb.c (member, fatal, main): Likewise.
4945
99033785
PE
49462011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4947
4948 Fix minor problems found by static checking (Bug#9031).
4949 * chartab.c (char_table_set_range, map_sub_char_table):
4950 Remove unused locals.
4951 (uniprop_table): Now static.
4952 * composite.c (_work_char): Remove unused static var.
4953
9cb2ac56
JB
49542011-07-09 Juanma Barranquero <lekktu@gmail.com>
4955
4956 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4957
f25661f0
JD
49582011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4959
4960 * gtkutil.c (qttip_cb): Remove code without function.
4961
8278c4fe
EZ
49622011-07-09 Eli Zaretskii <eliz@gnu.org>
4963
4964 * w32.c (pthread_sigmask): New stub.
4965
1692ae2d 49662011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4967
8a6ebd58 4968 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4969 sigprocmask is portable only for single-threaded applications, and
4970 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4971 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4972 (LIBES): Use it.
4973 * callproc.c (Fcall_process):
4974 * process.c (create_process):
4975 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4976 Use pthread_sigmask, not sigprocmask.
123403e4 4977
1b854618
JD
49782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4979
4980 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4981 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4982 wrong (Bug#8591).
4983
3fe4b549
JD
49842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4985
0ce7e563
JD
4986 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4987 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4988 (xg_hide_tooltip): Fix comment.
4989
3fe4b549
JD
4990 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4991 in registerServicesMenuSendTypes.
4992 (validRequestorForSendType): Don't check ns_return_types.
4993
4994 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4995 ns_return_type.
4996
5df75e47
JR
49972011-07-08 Jason Rumney <jasonr@gnu.org>
4998
22610910
JR
4999 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5000 SH_SHOW for hidden windows (Bug#5482).
5001
5df75e47
JR
5002 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5003 frame struct members of non-existent frames (Bug#6284).
5004
699c10bd
JD
50052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5006
4393663b
JD
5007 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5008 variable firstTime not needed on OSX >= 10.6.
5009 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5010 >= 10.5. Use setKnobProportion, setDoubleValue.
5011
5012 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5013 (MAC_OS_X_VERSION_10_5): Define if not defined.
5014 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5015 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5016 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5017
5018 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5019 cString and lossyCString on OSX >= 10.4
5020
58179cce 5021 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5022 sizeToFit on OSX >= 10.2.
5023
5024 * nsimage.m (allocInitFromFile): Don't use deprecated method
5025 bestRepresentationForDevice on OSX >= 10.6.
5026
5027 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5028 to avoid warning.
5029
5030 * emacs.c: Declare unexec_init_emacs_zone.
5031
a63e0781
JD
5032 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5033
699c10bd
JD
5034 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5035
5036 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5037 on svcsMenu (Bug#8842).
5038
5039 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5040 ns_return_types.
5041 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5042
5043 * nsterm.m (QUTF8_STRING): Declare.
5044 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5045 (validRequestorForSendType): Return type is (id).
5046 Change indexOfObjectIdenticalTo to indexOfObject.
5047 Check if we have local selection before returning self (Bug#8842).
5048 (writeSelectionToPasteboard): Put local selection into paste board
5049 if we have a local selection (Bug#8842).
5050 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5051
5052 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5053 (ns_get_local_selection): Declare.
5054
54e10184
LMI
50552011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5056
9888ff71
LMI
5057 * keymap.c (describe_map_tree): Don't insert a double newline at
5058 the end of the buffer (bug#1169) and return whether we inserted
5059 something.
5060
54e10184
LMI
5061 * callint.c (Fcall_interactively): Change "reading args" to
5062 "providing args" to try to clarify what it does (bug#1010).
5063
15fa4783
KH
50642011-07-07 Kenichi Handa <handa@m17n.org>
5065
5066 * composite.c (composition_compute_stop_pos): Ignore a static
5067 composition starting before CHARPOS (Bug#8915).
5068
5069 * xdisp.c (handle_composition_prop): Likewise.
5070
a8815b00
EZ
50712011-07-07 Eli Zaretskii <eliz@gnu.org>
5072
5073 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5074 (Bug#9015)
5075
ef7b981d 50762011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5077
5078 * character.h (unicode_category_t): New enum type.
5079
5080 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5081 (Qchar_code_property_table): New variable.
5082 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5083 (UNIPROP_COMPRESSED_FORM_P): New macros.
5084 (char_table_ascii): Uncompress the compressed values.
5085 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5086 Uncompress the compressed values.
ac389d0c 5087 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5088 (char_table_ref_and_range): Uncompress the compressed values.
5089 (sub_char_table_set): New arg is_uniprop. Callers changed.
5090 Uncompress the compressed values.
5091 (sub_char_table_set_range): Args changed. Callers changed.
5092 (char_table_set_range): Adjuted for the above change.
5093 (map_sub_char_table): Delete args default_val and parent. Add arg
5094 top. Give decoded values to a Lisp function.
640c8776 5095 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5096 values to a Lisp function. Gcpro more variables.
5097 (uniprop_table_uncompress)
5098 (uniprop_decode_value_run_length): New functions.
5099 (uniprop_decoder, uniprop_decoder_count): New variables.
5100 (uniprop_get_decoder, uniprop_encode_value_character)
5101 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5102 New functions.
5103 (uniprop_encoder, uniprop_encoder_count): New variables.
5104 (uniprop_get_encoder, uniprop_table)
5105 (Funicode_property_table_internal, Fget_unicode_property_internal)
5106 (Fput_unicode_property_internal): New functions.
5107 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5108 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 5109 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
5110 char-code-property-alist.
5111
640c8776 5112 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5113 Vunicode_category_table.
5114
640c8776 5115 * font.c (font_range): Adjust for the change of
c805dec0
KH
5116 Vunicode_category_table.
5117
76b397fb
DN
51182011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5119
5120 * m/iris4d.h: Remove file, move contents ...
5121 * s/irix6-5.h: ... here.
5122
22b4128e
PE
51232011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5124
5125 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5126 * alloc.c (mark_buffer):
5127 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5128 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5129 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5130 This isn't true in general, and it's particularly not true
5131 if Emacs is configured with --with-wide-int.
5132 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5133 New macros, used in the buffer.c change.
5134
869795d6
JD
51352011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5136
5137 * xsettings.c: Use both GConf and GSettings if both are available.
5138 (store_config_changed_event): Add comment.
5139 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5140 (store_tool_bar_style_changed): New functions.
5e617bc2 5141 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5142 (struct xsettings): Move font inside HAVE_XFT.
5143 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5144 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5145 Move inside HAVE_XFT.
640c8776 5146 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5147 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5148 also.
5149 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5150 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5151 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5152 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5153 (parse_settings): Move check for font inside HAVE_XFT.
5154 (read_settings, apply_xft_settings): Add comment.
5155 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5156 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5157 call store_font_name_changed.
5158 (xft_settings_event): Add comment.
5159 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5160 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5161 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5162 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5163 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5164 (xsettings_get_system_font, xsettings_get_system_normal_font):
5165 Add comment.
869795d6 5166
d8ed26bd
PE
51672011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5168
5169 Random fixes. E.g., (random) never returned negative values.
5170 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5171 subseconds part to the entropy, as that's a bit more random.
5172 Prefer signed to unsigned, since the signedness doesn't matter and
5173 in general we prefer signed. When given a limit, use a
5174 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5175 latter isn't right if USE_2_TAGS_FOR_INTS.
5176 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5177 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5178
cabf1cac
SM
51792011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5180
5181 * textprop.c (text_property_stickiness):
5182 Obey Vtext_property_default_nonsticky.
5183 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5184 * w32fns.c (syms_of_w32fns):
5185 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5186
6e9b2be9
PE
51872011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5190 This is more efficient than Ffile_directory_p and avoids a minor race.
5191
90186c68
LMI
51922011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5193
7c301272
LMI
5194 * buffer.c (Foverlay_put): Say what the return value is
5195 (bug#7835).
5196
c4f2d8d4
LMI
5197 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5198 is a directory before asking whether to use the file name
5199 (bug#7564).
ad637907
LMI
5200 (barf_or_query_if_file_exists): Make the "File is a directory"
5201 error be more correct.
c4f2d8d4 5202
90186c68
LMI
5203 * fns.c (Frequire): Remove the mention of the .gz files, since
5204 that's installation-specific, but keep the mention of
5205 `get-load-suffixes'.
5206
da64016e
PE
52072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5208
5209 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5210 Report string overflow if the output is too long.
5211
7d47b580
JB
52122011-07-04 Juanma Barranquero <lekktu@gmail.com>
5213
a555cb87
JB
5214 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5215 (syms_of_gnutls): Remove duplicate DEFSYM for
5216 Qgnutls_bootprop_verify_hostname_error, an error for
5217 Qgnutls_bootprop_verify_error (which is no longer used).
5218
7d47b580
JB
5219 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5220 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5221 Also (re)move comments that are misplaced or no longer relevant.
5222
1e49bfab
LMI
52232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5224
5225 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5226
1485f4c0
CY
52272011-07-03 Chong Yidong <cyd@stupidchicken.com>
5228
5229 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5230 and background color parameters if they have been changed.
5231
a9ab721e
LMI
52322011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5233
5234 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5235
cf7cff57
PE
52362011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5237
2e13213d
PE
5238 * xsettings.c (SYSTEM_FONT): Define only when used.
5239 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5240
cf7cff57
PE
5241 * keymap.c (access_keymap_1): Now static.
5242
7a8e04f7
CY
52432011-07-02 Chong Yidong <cyd@stupidchicken.com>
5244
5245 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5246 leave any prefix arg for the up event (Bug#1586).
5247
61352f62
LMI
52482011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5249
69bb1ef7
LMI
5250 * lread.c (syms_of_lread): Mention single symbols defined by
5251 `defvar' or `defconst' (bug#7154).
5252
61352f62 5253 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5254 (Frequire): Mention get-load-suffixes.
61352f62 5255
28545e04
MR
52562011-07-02 Martin Rudalics <rudalics@gmx.at>
5257
5258 * window.h (window): Remove clone_number slot.
5259 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5260 Remove.
5261 (make_parent_window, make_window, saved_window)
5262 (Fset_window_configuration, save_window_save): Don't deal with
5263 clone numbers.
5264 * buffer.c (Qclone_number): Remove declaration.
5265 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5266
3349e122
SM
52672011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5268
5269 Add multiple inheritance to keymaps.
5270 * keymap.c (Fmake_composed_keymap): New function.
5271 (Fset_keymap_parent): Simplify.
5272 (fix_submap_inheritance): Remove.
5273 (access_keymap_1): New function extracted from access_keymap to handle
5274 embedded parents and handle lists of maps.
5275 (access_keymap): Use it.
5276 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5277 (Fcopy_keymap): Handle embedded parents.
5278 (Fcommand_remapping, define_as_prefix): Simplify.
5279 (Fkey_binding): Simplify.
5280 (syms_of_keymap): Move minibuffer-local-completion-map,
5281 minibuffer-local-filename-completion-map,
5282 minibuffer-local-must-match-map, and
5283 minibuffer-local-filename-must-match-map to Elisp.
5284 (syms_of_keymap): Defsubr make-composed-keymap.
5285 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5286 (parse_menu_item): Trivial simplification.
5287
3279eb87
GM
52882011-07-01 Glenn Morris <rgm@gnu.org>
5289
5290 * Makefile.in (SETTINGS_LIBS): Fix typo.
5291
4550efdf
KI
52922011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5293
5294 * coding.c (Fencode_coding_string): Record the last coding system
5295 used, as the function doc string says (bug#8738).
5296
0949d2b6
JD
52972011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5298
5299 * xsettings.c (store_monospaced_changed): Take new font as arg and
5300 check for change against current_mono_font.
5301 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5302 (emacs_settings_constructor, emacs_settings_get_property)
5303 (emacs_settings_set_property, emacs_settings_class_init)
5304 (emacs_settings_init, gsettings_obj): Remove.
5305 (something_changedCB): New function for HAVE_GSETTINGS.
5306 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5307 with value as argument.
5308 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5309 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5310 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5311 "changed".
5312
5313 * xgselect.c: Add defined (HAVE_GSETTINGS).
5314 (xgselect_initialize): Ditto.
5315
5316 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5317 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5318 xg_select.
5319
bbc6b304
PE
53202011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5321
5322 * eval.c (struct backtrace): Simplify and port the data structure.
5323 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5324 signed bit field, as this assumption is not portable and it makes
5325 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5326 "char debug_on_exit : 1" as this is not portable either; instead,
5327 use the portable "unsigned int debug_on_exit : 1". Remove unused
5328 member evalargs. Remove obsolete comments about cc bombing out.
5329
9851bfc5
JD
53302011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5331
51bb811f 5332 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5333 Let HAVE_GSETTINGS override HAVE_GCONF.
5334 (store_monospaced_changed): New function.
5335 (EMACS_SETTINGS): A new type derived from GObject to handle
5336 GSettings notifications.
5337 (emacs_settings_constructor, emacs_settings_get_property)
5338 (emacs_settings_set_property, emacs_settings_class_init):
5339 New functions.
5340 (gsettings_client, gsettings_obj): New variables.
5341 (GSETTINGS_SCHEMA): New define.
5342 (something_changedCB): Call store_monospaced_changed.
5343 (init_gsettings): New function.
5344 (xsettings_initialize): Call init_gsettings.
5345 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5346 to NULL.
5347
640c8776 5348 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5349 GCONF_CFLAGS/LIBS.
5350
5386012d
MR
53512011-06-29 Martin Rudalics <rudalics@gmx.at>
5352
5353 * window.c (resize_root_window, grow_mini_window)
5354 (shrink_mini_window): Rename Qresize_root_window to
5355 Qwindow_resize_root_window and Qresize_root_window_vertically to
5356 Qwindow_resize_root_window_vertically.
5357
f13e0b08
PE
53582011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5359
5360 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5361
94515237
JB
53622011-06-27 Juanma Barranquero <lekktu@gmail.com>
5363
5364 * makefile.w32-in: Redesign dependencies so they reflect more
5365 clearly which files are directly included by each source file,
5366 and not through other includes.
5367
e43b6e43
MR
53682011-06-27 Martin Rudalics <rudalics@gmx.at>
5369
5370 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5371 (sort_overlays, overlay_strings): When an overlay's clone number
5372 matches the window's clone number process the overlay even if
5373 the overlay's window property doesn't match the current window.
5374
d68443dc
MR
5375 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5376 (Fwindow_hchild): Rename to Fwindow_left_child.
5377 (Fwindow_next): Rename to Fwindow_next_sibling.
5378 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5379 (resize_window_check): Rename to window_resize_check.
5380 (resize_window_apply): Rename to window_resize_apply.
5381 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5382 (Fdelete_other_windows_internal, resize_frame_windows)
5383 (Fsplit_window_internal, Fdelete_window_internal)
5384 (grow_mini_window, shrink_mini_window)
5385 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5386
c7e73be5
JD
53872011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5388
5389 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5390 (emacs_fixed_set_min_size): Remove.
5391 (emacs_fixed_new): Take frame as argument.
5392
5393 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5394 (_EmacsFixedPrivate): Remove minwidth/height.
5395 Add struct frame *f.
5396 (emacs_fixed_init): Initialize priv->f.
5397 (get_parent_class, emacs_fixed_set_min_size): Remove.
5398 (emacs_fixed_new): Set priv->f to argument.
5399 (emacs_fixed_get_preferred_width)
5400 (emacs_fixed_get_preferred_height): Use min_width/height from
5401 frames size_hint to set minimum and natural (Bug#8919).
5402 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5403 and use min_width/height from frames size_hint to set
5404 min_width/height (Bug#8919).
5405
5406 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5407 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5408 Fix indentation.
c7e73be5 5409
cf99dcf8
EZ
54102011-06-26 Eli Zaretskii <eliz@gnu.org>
5411
5412 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5413 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5414 called at ZV.
5415
029529ac
CY
54162011-06-26 Chong Yidong <cyd@stupidchicken.com>
5417
5418 * process.c (wait_reading_process_output): Bypass select if
5419 waiting for a cell while ignoring keyboard input, and input is
5420 pending. Suggested by Jan Djärv (Bug#8869).
5421
7a7ef429
PE
54222011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5423
5424 Use gnulib's dup2 module instead of rolling our own.
5425 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5426
11fdef7d 54272011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5428
5429 * dispnew.c (scrolling_window): Before scrolling, turn off a
5430 mouse-highlight in the window being scrolled.
5431
cd3520a4
JB
54322011-06-24 Juanma Barranquero <lekktu@gmail.com>
5433
5434 Move DEFSYM to lisp.h and use everywhere.
5435
5436 * character.h (DEFSYM): Move declaration...
5437 * lisp.h (DEFSYM): ...here.
5438
5439 * gnutls.c:
5440 * minibuf.c:
5441 * w32menu.c:
5442 * w32proc.c:
5443 * w32select.c: Don't include character.h.
5444
5445 * alloc.c (syms_of_alloc):
5446 * buffer.c (syms_of_buffer):
5447 * bytecode.c (syms_of_bytecode):
5448 * callint.c (syms_of_callint):
5449 * casefiddle.c (syms_of_casefiddle):
5450 * casetab.c (init_casetab_once):
5451 * category.c (init_category_once, syms_of_category):
5452 * ccl.c (syms_of_ccl):
5453 * cmds.c (syms_of_cmds):
5454 * composite.c (syms_of_composite):
5455 * dbusbind.c (syms_of_dbusbind):
5456 * dired.c (syms_of_dired):
5457 * dispnew.c (syms_of_display):
5458 * doc.c (syms_of_doc):
5459 * editfns.c (syms_of_editfns):
5460 * emacs.c (syms_of_emacs):
5461 * eval.c (syms_of_eval):
5462 * fileio.c (syms_of_fileio):
5463 * fns.c (syms_of_fns):
5464 * frame.c (syms_of_frame):
5465 * fringe.c (syms_of_fringe):
5466 * insdel.c (syms_of_insdel):
5467 * keymap.c (syms_of_keymap):
5468 * lread.c (init_obarray, syms_of_lread):
5469 * macros.c (syms_of_macros):
5470 * msdos.c (syms_of_msdos):
5471 * print.c (syms_of_print):
5472 * process.c (syms_of_process):
5473 * search.c (syms_of_search):
5474 * sound.c (syms_of_sound):
5475 * syntax.c (init_syntax_once, syms_of_syntax):
5476 * terminal.c (syms_of_terminal):
5477 * textprop.c (syms_of_textprop):
5478 * undo.c (syms_of_undo):
5479 * w32.c (globals_of_w32):
5480 * window.c (syms_of_window):
5481 * xdisp.c (syms_of_xdisp):
5482 * xfaces.c (syms_of_xfaces):
5483 * xfns.c (syms_of_xfns):
5484 * xmenu.c (syms_of_xmenu):
5485 * xsettings.c (syms_of_xsettings):
5486 * xterm.c (syms_of_xterm): Use DEFSYM.
5487
4228cf16
TZ
54882011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5489
cd3520a4 5490 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5491
7fcccf1e
PE
54922011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5493
7efb4e0e
PE
5494 Integer and buffer overflow fixes (Bug#8873).
5495
ff5844ad
PE
5496 * print.c (printchar, strout): Check for string overflow.
5497 (PRINTPREPARE, printchar, strout):
5498 Don't set size unless allocation succeeds.
5499
90532f02
PE
5500 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5501 for sizes. Check for string overflow more accurately.
5502 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5503
6d84508d
PE
5504 * macros.c: Integer and buffer overflow fixes.
5505 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5506 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5507 Use ptrdiff_t, not int, for sizes.
5508 Don't increment bufsize until after realloc succeeds.
5509 Check for size-calculation overflow.
5510 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5511
437b2cb4
PE
5512 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5513
8b9ac8b4
PE
5514 * lread.c: Integer overflow fixes.
5515 (read_integer): Radix is now EMACS_INT, not int,
5516 to improve quality of diagnostics for out-of-range radices.
5517 Calculate buffer size correctly for out-of-range radices.
5518 (read1): Check for integer overflow in radices, and in
5519 read-circle numbers.
82cb60d3
PE
5520 (read_escape): Avoid int overflow.
5521 (Fload, openp, read_buffer_size, read1)
5522 (substitute_object_recurse, read_vector, read_list, map_obarray):
5523 Use ptrdiff_t, not int, for sizes.
5524 (read1): Use EMACS_INT, not int, for sizes.
20270765 5525 Check for size overflow.
8b9ac8b4 5526
7fcccf1e
PE
5527 * image.c (cache_image): Check for size arithmetic overflow.
5528
bfbbd7e7
PE
5529 * lread.c: Integer overflow issues.
5530 (saved_doc_string_size, saved_doc_string_length)
5531 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5532 Now ptrdiff_t, not int.
5533 (read1): Don't assume doc string length fits in int. Check for
5534 out-of-range doc string lengths.
5535 (read_list): Don't assume file position fits in int.
39019e54 5536 (read_escape): Check for hex character overflow.
bfbbd7e7 5537
4e323265
LL
55382011-06-22 Leo Liu <sdl.web@gmail.com>
5539
5540 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5541 Move to minibuffer.el.
5542
85fece3e
PE
55432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5544
20b84ce9 5545 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5546 The following patches are for when GLYPH_DEBUG && !XASSERT.
5547 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5548 * dispnew.c (flush_stdout):
5549 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5550 Mark as externally visible.
5551 * dispnew.c (check_window_matrix_pointers): Now static.
5552 * dispnew.c (window_to_frame_vpos):
5553 * xfns.c (unwind_create_frame):
5554 * xterm.c (x_check_font): Remove unused local.
5555 * scroll.c (CHECK_BOUNDS):
5556 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5557 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5558 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5559 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5560 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5561 Now static.
5562 (debug_method_add): Use va_list and vsprintf rather than relying
5563 on undefined behavior with wrong number of arguments.
5564 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5565 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5566 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5567 since we're not interested in debugging glyphs with old libraries.
5568 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5569 GCC 4.6.0's static checking.
5570
0766b489
PE
55712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5572
31fd4b32
PE
5573 Integer overflow and signedness fixes (Bug#8873).
5574 A few related buffer overrun fixes, too.
5575
b79e8648
PE
5576 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5577
0766b489
PE
5578 * dispextern.h (struct face.stipple):
5579 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5580 (x_bitmap_mask, x_allocate_bitmap_record)
5581 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5582 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5583 (x_create_bitmap_from_xpm_data):
5584 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5585 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5586 (.bitmaps_last):
5587 * xfaces.c (load_pixmap):
5588 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5589 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5590 (.bitmaps_last, struct x_output.icon_bitmap):
5591 Use ptrdiff_t, not int, for bitmap indexes.
5592 (x_allocate_bitmap_record): Check for size overflow.
5593 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5594
b081724f
PE
5595 Use ptrdiff_t, not int, for overlay counts.
5596 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5597 * editfns.c (overlays_around, get_pos_property):
5598 * textprop.c (get_char_property_and_overlay):
5599 * xdisp.c (next_overlay_change, note_mouse_highlight):
5600 * xfaces.c (face_at_buffer_position):
21514da7
PE
5601 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5602 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5603 (Fnext_overlay_change, Fprevious_overlay_change)
5604 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5605 Use ptrdiff_t, not int, for sizes.
21514da7 5606 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5607
3de73e5e
PE
5608 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5609
2606c57b
PE
5610 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5611 (x_session_initialize): Do not assume string length fits in int.
5612
aaafe47a
PE
5613 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5614 This is unlikely, but can occur if DPI is outlandish.
5615
2674ddc8 5616 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5617 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5618
28154962
PE
5619 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5620 * xrdb.c (magic_file_p, search_magic_path):
5621 Omit last arg SUFFIX; it was always 0. All callers changed.
5622 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5623
7de51af5
PE
5624 * xfont.c (xfont_match): Avoid need for strlen.
5625
25ed6cc3
PE
5626 * xfns.c: Don't assume strlen fits in int.
5627 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5628
4eab31dd
PE
5629 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5630 not unsigned long, as we prefer signed integers. All callers changed.
5631 Detect integer overflow in repeat count.
5632 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5633 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5634
171e2a58
PE
5635 * termcap.c: Don't assume sizes fit in int and never overflow.
5636 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5637 (gobble_line): Check for size-calculation overflow.
5638
ad39faca 5639 * minibuf.c (Fread_buffer):
6e5bb2dc 5640 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5641 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5642 Don't assume string length fits in int.
5643
52c61c22 5644 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5645 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5646
b5b8c9e5
PE
5647 * font.c: Don't assume string length fits in int.
5648 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5649 Use ptrdiff_t, not int.
ccd6111c
PE
5650 (font_intern_prop): Don't assume string length fits in int.
5651 Don't assume integer property fits in fixnum.
5652 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5653
882f0d81 5654 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5655 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5656 Reformulate so as not to need the command string.
5657 Invoke gzip -cd rather than gunzip, as it's more portable.
5658 (lock_info_type, lock_file_1, lock_file):
5659 Don't assume pid_t and time_t fit in unsigned long.
5660 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5661 (current_lock_owner): Prefer signed type for sizes.
5662 Use memcpy, not strncpy, where memcpy is what is really wanted.
5663 Don't assume (via atoi) that time_t and pid_t fit in int.
5664 Check for time_t and/or pid_t out of range, e.g., via a network share.
5665 Don't alloca where an auto var works fine.
5666
93f4cf88
PE
5667 * fileio.c: Fix some integer overflow issues.
5668 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5669 Don't assume string length fits in int.
5670 (directory_file_name): Don't assume string length fits in long.
5671 (make_temp_name): Don't assume pid fits in int, or that its print
5672 length is less than 20.
5673
f3e92b69
PE
5674 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5675
1bfdaf10
PE
5676 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5677
35016e9a
PE
5678 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5679
3d1e65a1
PE
5680 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5681 We prefer signed integers, even for size calculations.
5682
0b963a93
PE
5683 * emacs.c: Don't assume string length fits in 'int'.
5684 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5685 (main): Don't invoke strlen when not needed.
5686
573f4b54
PE
5687 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5688 (XD_DEBUG_MESSAGE): Don't waste a byte.
5689
989f33ba
PE
5690 * callproc.c (getenv_internal_1, getenv_internal)
5691 (Fgetenv_internal):
965d34eb
PE
5692 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5693
e4d29b33
PE
5694 * lread.c (invalid_syntax): Omit length argument.
5695 All uses changed. This doesn't fix a bug, but it simplifies the
5696 code away from its former Hollerith-constant appearance, and it's
5697 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5698 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5699
eb49b136
PE
5700 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5701 This didn't break anything, but it didn't help either.
5702 It's confusing to put a bogus integer in a place where the actual
5703 value does not matter.
9f62aeb1 5704 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5705 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5706
15375a22
PE
5707 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5708 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5709 implementation.
b61cc01c
PE
5710 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5711 We prefer signed types, and the value cannot exceed the EMACS_INT
5712 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5713 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5714 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5715 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5716
53b2623d
PE
5717 * indent.c (sane_tab_width): New function.
5718 (current_column, scan_for_column, Findent_to, position_indentation)
5719 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5720 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5721
51cab52b 5722 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5723
f2ed8a70
PE
5724 * lisp.h (lint_assume): New macro.
5725 * composite.c (composition_gstring_put_cache):
5726 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5727
abe80cc6
PE
5728 * editfns.c, insdel.c:
5729 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5730
b02c740e
PE
5731 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5732
ebc96716
PE
5733 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5734
b4e50fa0 5735 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5736 Use much-faster test for byte-length change.
311d5d7c 5737 Don't assume string byte-length fits in 'int'.
a4cf38e4 5738 Check that character arg fits in 'int'.
85461888 5739 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5740
c0c1ee9f
PE
5741 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5742
a498d7f4
PE
5743 * fns.c (concat): Catch string overflow earlier.
5744 Do not rely on integer wraparound.
5745
51cab52b
PE
5746 * dispextern.h (struct it.overlay_strings_charpos)
5747 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5748 * xdisp.c (forward_to_next_line_start)
5749 (back_to_previous_visible_line_start)
5750 (reseat_at_next_visible_line_start, next_element_from_buffer):
5751 Don't arbitrarily truncate the value of 'selective' to int.
5752
76031fad
PE
5753 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5754
5eb55db9
PE
5755 * composite.c: Don't truncate sizes to 'int'.
5756 (composition_gstring_p, composition_reseat_it)
5757 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5758 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5759 not EMACS_UINT, for indexes.
5eb55db9 5760
0703a717
PE
5761 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5762
d6202519
PE
5763 * buffer.c: Include <verify.h>.
5764 (struct sortvec.priority, struct sortstr.priority):
8961a454 5765 Now EMACS_INT, not int.
c20998a7 5766 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5767 (struct sortstr.size, record_overlay_string)
5768 (struct sortstrlist.size, struct sortlist.used):
5769 Don't truncate size to int.
5770 (record_overlay_string): Check for size-calculation overflow.
d6202519 5771 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5772
d5a19415
JM
57732011-06-22 Jim Meyering <meyering@redhat.com>
5774
029529ac 5775 Don't leak an XBM-image-sized buffer
d5a19415
JM
5776 * image.c (xbm_load): Free the image buffer after using it.
5777
a9041e6c
PE
57782011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5779
5780 Port to Sun C.
5781 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5782 that Sun C diagnosed.
5783 * fns.c (secure_hash): Fix pointer signedness issue.
5784 * intervals.c (static_offset_intervals): New function.
5785 (offset_intervals): Use it.
5786
7f3f739f
LL
57872011-06-21 Leo Liu <sdl.web@gmail.com>
5788
5789 * deps.mk (fns.o):
5790 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5791 sha512.h.
5792
5793 * fns.c (secure_hash): Rename from crypto_hash_function and change
5794 the first arg to accept symbols.
5b66d427 5795 (Fsecure_hash): New primitive.
7f3f739f
LL
5796 (syms_of_fns): New symbols.
5797
76147d94
DD
57982011-06-20 Deniz Dogan <deniz@dogan.se>
5799
5800 * process.c (Fset_process_buffer): Clarify return value in
5801 docstring.
5802
7d7d0045
CY
58032011-06-18 Chong Yidong <cyd@stupidchicken.com>
5804
5805 * dispnew.c (add_window_display_history): Use BVAR.
5806
5807 * xdisp.c (debug_method_add): Use BVAR.
5808 (check_window_end, dump_glyph_matrix, dump_glyph)
5809 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5810
5811 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5812 Likewise.
5813
5814 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5815 check till after the cache is created in init_frame_faces.
5816
ff2bc410
SM
58172011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5818
5819 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5820
28177add
PE
58212011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5822
dd3482fe
PE
5823 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5824 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5825 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5826
393d71f3 5827 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5828 * fileio.c (Finsert_file_contents):
5829 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5830 Remove the old (too-loose) buffer overflow checks.
5831 They weren't needed, since make_gap checks for buffer overflow.
5832 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5833 The old code merely checked for Emacs fixnum overflow, and relied
5834 on undefined (wraparound) behavior. The new code avoids undefined
5835 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5836
2e6813b0 5837 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5838 Tune. Don't use wider integers than needed. Don't use alloca.
5839 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5840
599a9e4f
PE
5841 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5842
99561444
PE
5843 * insdel.c, lisp.h (buffer_overflow): New function.
5844 (insert_from_buffer_1, replace_range, replace_range_2):
5845 * insdel.c (make_gap_larger):
5846 * editfns.c (Finsert_char):
5847 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5848
28177add
PE
5849 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5850
e69dafad
PE
58512011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5852
4baa020d 5853 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5854
b1c46f02
PE
5855 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5856 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5857
e69dafad
PE
5858 * fileio.c: Don't assume EMACS_INT fits in off_t.
5859 (emacs_lseek): New static function.
5860 (Finsert_file_contents, Fwrite_region): Use it.
5861 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5862
566684ea
PE
5863 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5864
e6966cd6
PE
5865 * fns.c: Don't overflow int when computing a list length.
5866 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5867 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5868 truncation on 64-bit hosts. Check for QUIT every
5869 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5870 faster and is responsive enough.
5871 (Flength): Report an error instead of overflowing an integer.
5872 (Fsafe_length): Return a float if the value is not representable
5873 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5874 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5875 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5876
dd0b0efb
PE
5877 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5878 (header_size, word_size): New constants.
5879 (allocate_vectorlike): Don't check size overflow here.
5880 (allocate_vector): Check it here instead, since this is the only
5881 caller of allocate_vectorlike that could cause overflow.
5882 Check that the new vector's length is representable as a fixnum.
5883
86fe5cfe
PE
5884 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5885 The previous code was bogus. For example, next_almost_prime (32)
5886 returned 39, which is undesirable as it is a multiple of 3; and
5887 next_almost_prime (24) returned 25, which is a multiple of 5 so
5888 why was the code bothering to check for multiples of 7?
5889
80e88859
PE
5890 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5891
4a2f0ad6
PE
5892 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5893
f66c7cf8
PE
5894 Variadic C functions now count arguments with ptrdiff_t.
5895 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5896 Back then I didn't know that the Emacs coding style prefers signed int.
5897 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5898 were being counted with int, which may truncate counts on 64-bit
5899 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5900 * lisp.h (struct Lisp_Subr.function.aMANY)
5901 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5902 Arg counts are now ptrdiff_t, not size_t.
5903 All variadic functions and their callers changed accordingly.
5904 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5905 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5906 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5907 * callint.c (Fcall_interactively): Check arg count for overflow,
5908 to avoid potential buffer overrun. Use signed char, not 'int',
5909 for 'varies' array, so that we needn't bother to check its size
5910 calculation for overflow.
5911 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5912 * eval.c (apply_lambda):
5913 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5914 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5915 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5916
a1759b76
PE
5917 * callint.c (Fcall_interactively): Don't use index var as event count.
5918
d96be9fc
PE
5919 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5920 * mem-limits.h (SIZE): Remove; no longer used.
5921
a690a978 5922 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5923
578c21e6
PE
5924 Remove unnecessary casts.
5925 * xterm.c (x_term_init):
5926 * xfns.c (x_set_border_pixel):
5927 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5928 These aren't needed now that we assume ANSI C.
5929
96f53c6c
PE
5930 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5931 It's more likely to cause problems (due to unsigned overflow)
5932 than to cure them.
5933
83c77d31
PE
5934 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5935
ee2079f1
PE
5936 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5937
6da65536
PE
5938 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5939
7147c4a4
PE
5940 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5941
193e32d9
PE
5942 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5943
e5533da6
PE
5944 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5945
9910e595
PE
5946 GLYPH_CODE_FACE returns EMACS_INT, not int.
5947 * dispextern.h (merge_faces):
5948 * xfaces.c (merge_faces):
01103c44
PE
5949 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5950 Don't assume EMACS_INT fits in int.
9910e595 5951
2638320e
PE
5952 * character.h (CHAR_VALID_P): Remove unused parameter.
5953 * fontset.c, lisp.h, xdisp.c: All uses changed.
5954
045eb8d9
PE
5955 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5956
c1f134b5
PE
5957 * fns.c (concat): Minor tuning based on overflow analysis.
5958 This doesn't fix any bugs. Use int to hold character, instead
5959 of constantly refetching from Emacs object. Use XFASTINT, not
5960 XINT, for value known to be a character. Don't bother comparing
5961 a single byte to 0400, as it's always less.
5962
395fcb93 5963 * floatfns.c (Fexpt):
327eeec8
PE
5964 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5965
abbd3d23
PE
5966 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5967 for characters.
5968
684a03ef
PE
5969 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5970
0fed43f3
PE
5971 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5972 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5973 incorrectly succeed when S was a string, because 4294967386 was
5974 truncated before it was used.
5975
8fd02eb7
PE
5976 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5977 Otherwise, an out-of-range integer could cause undefined behavior
5978 on a 64-bit host.
5979
f8c86b69
PE
5980 * composite.c: Use int, not EMACS_INT, for characters.
5981 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5982 EMACS_INT, for values that are known to be in character range.
5983 This doesn't fix any bugs but is the usual style inside Emacs and
5984 may generate better code on 32-bit machines.
5985
34206dd2
PE
5986 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5987 This is for reasons similar to the recent CHAR_STRING fix.
5988 * charset.c (Fencode_char): Check that character arg is actually
5989 a character. Pass an int to ENCODE_CHAR.
5990 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5991 wider than 'int', as a compile-time check to prevent future regressions
5992 in this area.
5993
c5958d4c 5994 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5995
5996 Make sure a 64-bit char is never passed to CHAR_STRING.
5997 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5998 by silently ignoring the top 32 bits, allowing some values
5999 that were far too large to be valid characters.
6000 * character.h: Include <verify.h>.
6001 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6002 arguments are no wider than unsigned, as a compile-time check
6003 to prevent future regressions in this area.
6004 * data.c (Faset):
01103c44 6005 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6006 (Fsubst_char_in_region):
6007 * fns.c (concat):
6008 * xdisp.c (decode_mode_spec_coding):
6009 Adjust to CHAR_STRING's new requirement.
6010 * editfns.c (Finsert_char, Fsubst_char_in_region):
6011 * fns.c (concat): Check that character args are actually
6012 characters. Without this test, these functions did the wrong
6013 thing with wildly out-of-range values on 64-bit hosts.
6014
d37ca623
PE
6015 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6016 These casts should not be needed on 32-bit hosts, either.
6017 * keyboard.c (read_char):
6018 * lread.c (Fload): Remove casts to unsigned.
6019
ea204efb
PE
6020 * lisp.h (UNSIGNED_CMP): New macro.
6021 This fixes comparison bugs on 64-bit hosts.
6022 (ASCII_CHAR_P): Use it.
6023 * casefiddle.c (casify_object):
01103c44 6024 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6025 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6026 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6027 * dispextern.h (FACE_FROM_ID):
6028 * keyboard.c (read_char): Use UNSIGNED_CMP.
6029
41cb286c
PE
6030 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6031 not to EMACS_INT, to avoid GCC warning.
6032
4a1b9832
PE
6033 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6034
55daad71
PE
6035 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6036 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6037 isn't needed on 32-bit machines.
8f95c75c 6038
01103c44
PE
6039 * buffer.c (Fgenerate_new_buffer_name):
6040 Use EMACS_INT for count, not int.
0ceccced 6041 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6042
6043 * data.c (Qcompiled_function): Now static.
6044
c6f072e7
PE
6045 * window.c (window_body_lines): Now static.
6046
20ce5912
PE
6047 * image.c (gif_load): Rename local to avoid shadowing.
6048
9c4c5f81
PE
6049 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6050 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6051 * alloc.c (make_save_value): Integer argument is now of type
6052 ptrdiff_t, not int.
6053 (mark_object): Use ptrdiff_t, not int.
6054 * lisp.h (pD): New macro.
6055 * print.c (print_object): Use it.
6056
c0c5c8ae
PE
6057 * alloc.c: Use EMACS_INT, not int, to count objects.
6058 (total_conses, total_markers, total_symbols, total_vector_size)
6059 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6060 (total_free_floats, total_floats, total_free_intervals)
6061 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6062 Now EMACS_INT, not int. All uses changed.
6063 (Fgarbage_collect): Compute overall total using a double, so that
6064 integer overflow is less likely to be a problem. Check for overflow
6065 when converting back to an integer.
5a25e253
PE
6066 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6067 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6068 These were 'int' variables that could overflow on 64-bit hosts;
6069 they were never used, so remove them instead of repairing them.
211a0b2a 6070 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6071 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6072 Previously, this ceilinged at INT_MAX, but that doesn't work on
6073 64-bit machines.
e46bb31a 6074 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6075
c78baabf 6076 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6077 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6078 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6079 when a (possibly-narrower) signed value would do just as well.
6080 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6081
c9d624c6
PE
6082 * alloc.c: Catch some string size overflows that we were missing.
6083 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6084 for convenience in STRING_BYTES_MAX.
6085 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6086 The definition here is exact; the one in lisp.h was approximate.
6087 (allocate_string_data): Check for string overflow. This catches
6088 some instances we weren't catching before. Also, it catches
6089 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6090 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6091 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6092
c9d624c6
PE
6093 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6094 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6095 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6096
353032ce
PE
6097 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6098
2bccce07
PE
6099 * alloc.c (Fmake_string): Check for out-of-range init.
6100
0ac30604
SM
61012011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6102
6103 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6104
c195f2de
JD
61052011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6106
6107 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6108 xg_get_default_scrollbar_width.
6109
6110 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6111 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6112 (style_changed_cb): Call update_theme_scrollbar_width and call
6113 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6114 all frames (Bug#8505).
6115 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6116 Call gtk_window_set_resizable if HAVE_GTK3.
6117 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6118 and height if HAVE_GTK3 (Bug#8505).
6119 (scroll_bar_width_for_theme): New variable.
6120 (update_theme_scrollbar_width): New function.
6121 (xg_get_default_scrollbar_width): Move code to
6122 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6123 (xg_initialize): Call update_theme_scrollbar_width.
6124
6125 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6126
6127 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6128
e10ac9f1
MR
61292011-06-12 Martin Rudalics <rudalics@gmx.at>
6130
6131 * frame.c (make_frame): Call other_buffer_safely instead of
6132 other_buffer.
6133
6134 * window.c (temp_output_buffer_show): Call display_buffer with
6135 second argument Vtemp_buffer_show_specifiers and reset latter
6136 immediately after the call.
6137 (Vtemp_buffer_show_specifiers): New variable.
6138 (auto_window_vscroll_p, next_screen_context_lines)
6139 (Vscroll_preserve_screen_position): Remove leading asterisks from
6140 doc-strings.
6141
2d3c217e 61422011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6143
7b7f97e8 6144 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6145 * buffer.c (Qclone_number): Remove for now, as it's unused.
6146 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6147 (record_buffer): Remove unused local.
6148 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6149 (set_frame_buffer_list): Remove; unused.
6150 * frame.h (other_visible_frames): Remove decl.
6151 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6152 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6153 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6154 if HAVE_GPM.
6155 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6156 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6157 Define only if HAVE_GPM.
6158 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6159 (update_hints_inhibit): Remove; never set. All uses removed.
6160 * widgetprv.h (emacsFrameClassRec): Remove decl.
6161 * window.c (delete_deletable_window): Now returns void, since it
6162 wasn't returning anything.
6163 (compare_window_configurations): Remove unused locals.
6164 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6165 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6166 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6167 the same widths as pointers. This follows up on the 2011-05-06 patch.
6168 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6169 * xterm.h: Likewise.
6170 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6171
1384b89e
JB
61722011-06-12 Juanma Barranquero <lekktu@gmail.com>
6173
6174 * makefile.w32-in: Update dependencies.
6175 (LISP_H): Add lib/intprops.h.
6176
1100a63c
CY
61772011-06-11 Chong Yidong <cyd@stupidchicken.com>
6178
6179 * image.c (gif_load): Add animation frame delay to the metadata.
6180 (syms_of_image): Use DEFSYM. New symbol `delay'.
6181
6198ccd0
MR
61822011-06-11 Martin Rudalics <rudalics@gmx.at>
6183
6184 * window.c (delete_deletable_window): Re-add.
6185 (Fset_window_configuration): Rewrite to handle dead buffers and
6186 consequently deletable windows.
6187 (window_tree, Fwindow_tree): Remove. Supply functionality in
6188 window.el.
6189 (compare_window_configurations): Simplify code.
6190
b6e3633c
AS
61912011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6192
1ab0dee5
AS
6193 * image.c (imagemagick_load_image): Fix type mismatch.
6194 (Fimagemagick_types): Likewise.
6195
b6e3633c
AS
6196 * window.h (replace_buffer_in_windows): Declare.
6197
9397e56f
MR
61982011-06-11 Martin Rudalics <rudalics@gmx.at>
6199
6200 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6201 Qclone_number. Remove external declaration of Qdelete_window.
6202 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6203 code.
640c8776
SM
6204 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6205 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6206 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6207 buffer list implementation.
6208 (other_buffer_safely): New function.
6209 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6210 calls to replace_buffer_in_windows and
6211 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6212 if allowed.
6213 (record_buffer): Inhibit quitting and rewrite using quittable
6214 functions. Run Qbuffer_list_update_hook if allowed.
6215 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6216 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6217 Move switch-to-buffer to window.el.
9397e56f
MR
6218 (bury-buffer): Move to window.el.
6219 (Vbuffer_list_update_hook): New variable.
6220
6221 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6222 section.
6223
6224 * window.h (resize_frame_windows): Move up in code.
6225 (Fwindow_frame): Remove EXFUN.
6226 (replace_buffer_in_all_windows): Remove prototype.
6227 (replace_buffer_in_windows_safely): Add prototype.
6228
6229 * window.c: Declare Qdelete_window static again. Move down
6230 declaration of select_count.
6231 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6232 (Fother_window): Move to window.el.
6233 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6234 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6235 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6236 window.el.
6237 (replace_buffer_in_windows): Implement by calling
6238 Qreplace_buffer_in_windows.
6239 (replace_buffer_in_all_windows): Remove with some functionality
6240 moved into replace_buffer_in_windows_safely.
6241 (replace_buffer_in_windows_safely): New function.
6242 (select_window_norecord, select_frame_norecord): Move in front
6243 of run_window_configuration_change_hook. Remove now obsolete
6244 declarations.
640c8776
SM
6245 (Fset_window_buffer): Rewrite doc-string.
6246 Call Qrecord_window_buffer.
9397e56f
MR
6247 (keys_of_window): Move binding for other-window to window.el.
6248
b50691aa
CY
62492011-06-11 Chong Yidong <cyd@stupidchicken.com>
6250
6251 * dispextern.h (struct image): Replace data member, whose int_val
6252 and ptr_val fields were not used by anything, with a single
6253 lisp_val object.
6254
6255 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6256 (gif_clear_image, gif_load, imagemagick_load_image)
6257 (gs_clear_image, gs_load): Callers changed.
6258
3f754b86
PE
62592011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6260
cca69397
PE
6261 * buffer.h: Include <time.h>, for time_t.
6262 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6263
109e28d0
PE
6264 Fix minor problems found by static checking.
6265
60737f02
PE
6266 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6267
4b66faf3
PE
6268 Make identifiers static if they are not used in other modules.
6269 * data.c (Qcompiled_function, Qframe, Qvector):
6270 * image.c (QimageMagick, Qsvg):
6271 * minibuf.c (Qmetadata):
6272 * window.c (resize_window_check, resize_root_window): Now static.
6273 * window.h (resize_window_check, resize_root_window): Remove decls.
6274
109e28d0
PE
6275 * window.c (window_deletion_count, delete_deletable_window):
6276 Remove; unused.
46a4ce9e
PE
6277 (window_body_lines): Now static.
6278 (Fdelete_other_windows_internal): Mark vars as initialized.
6279 Make sure 'resize_failed' is initialized.
6280 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6281 (resize_window_apply): Remove unused local.
6282 * window.h (delete_deletable_window): Remove decl.
6283
109e28d0 6284 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6285 (imagemagick_load_image): Fix pointer signedness problem by changing
6286 last arg from unsigned char * to char *. All uses changed.
6287 Also, fix a local for similar reasons.
6288 Remove unused locals. Remove locals to avoid shadowing.
6289 (fn_rsvg_handle_free): Remove; unused.
6290 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6291 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6292
3f754b86
PE
6293 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6294
2547adb1
CY
62952011-06-10 Chong Yidong <cyd@stupidchicken.com>
6296
6297 * image.c (gif_load): Fix omitted cast error introduced by
6298 2011-06-06 change.
6299
2c8e37d4
MR
63002011-06-10 Martin Rudalics <rudalics@gmx.at>
6301
6302 * window.h (resize_proportionally, orig_total_lines)
6303 (orig_top_line): Remove from window structure.
6304 (set_window_height, set_window_width, change_window_heights)
6305 (Fdelete_window): Remove prototypes.
6306 (resize_frame_windows): Remove duplicate declaration.
6307
440a42e3
EZ
63082011-06-10 Eli Zaretskii <eliz@gnu.org>
6309
6310 * window.h (resize_frame_windows, resize_window_check)
6311 (delete_deletable_window, resize_root_window)
6312 (resize_frame_windows): Declare prototypes.
6313
6314 * window.c (resize_window_apply): Make definition be "static" to
6315 match the prototype.
6316
562dd5e9
MR
63172011-06-10 Martin Rudalics <rudalics@gmx.at>
6318
6319 * window.c: Remove declarations of Qwindow_size_fixed,
6320 window_min_size_1, window_min_size_2, window_min_size,
6321 size_window, window_fixed_size_p, enlarge_window, delete_window.
6322 Remove static from declaration of Qdelete_window, it's
6323 temporarily needed by Fbury_buffer.
6324 (replace_window): Don't assign orig_top_line and
6325 orig_total_lines.
6326 (Fdelete_window, delete_window): Remove. Window deletion is
6327 handled by window.el.
640c8776
SM
6328 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6329 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6330 (Fdelete_other_windows): Remove. Deleting other windows is
6331 handled by window.el.
6332 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6333 handled in window.el.
6334 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6335 Window minimum sizes are handled in window.el.
6336 (shrink_windows, size_window, set_window_height)
6337 (set_window_width, change_window_heights, window_height)
6338 (window_width, CURBEG, CURSIZE, enlarge_window)
6339 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6340 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6341 handled in window.el.
6342 (make_dummy_parent): Rename to make_parent_window and give it a
6343 second argument horflag.
6344 (make_window): Don't set resize_proportionally any more.
6345 (Fsplit_window): Remove. Windows are split in window.el.
6346 (save_restore_action, save_restore_orig_size)
6347 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6348 Resize mini windows in window.el.
6349 (grow_mini_window, shrink_mini_window): Implement by calling
6350 Qresize_root_window_vertically, resize_window_check and
6351 resize_window_apply.
640c8776
SM
6352 (saved_window, Fset_window_configuration, save_window_save):
6353 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6354 resize_proportionally.
6355 (window_min_height, window_min_width): Move to window.el.
6356 (keys_of_window): Move bindings for delete-other-windows,
6357 split-window, delete-window and enlarge-window to window.el.
6358
6359 * buffer.c: Temporarily extern Qdelete_window.
6360 (Fbury_buffer): Temporarily call Qdelete_window instead of
6361 Fdelete_window (Fbury_buffer will move to window.el soon).
6362
6363 * frame.c (set_menu_bar_lines_1): Remove code handling
6364 orig_top_line and orig_total_lines.
6365
6366 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6367 set_window_height but set heights directly.
6368 (change_frame_size_1): Use resize_frame_windows.
6369
6370 * xdisp.c (init_xdisp): Don't use set_window_height but set
6371 heights directly.
6372
640c8776
SM
6373 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6374 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6375 run_window_configuration_change_hook.
6376
6377 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6378 instead of change_window_heights and run
6379 run_window_configuration_change_hook.
6380
1a13852e
MR
63812011-06-09 Martin Rudalics <rudalics@gmx.at>
6382
6383 * window.c (replace_window): Rename second argument REPLACEMENT to
6384 NEW. New third argument SETFLAG. Rewrite.
6385 (delete_window, make_dummy_parent): Call replace_window with
6386 third argument 1.
6387 (window_list_1): Move down in code.
6388 (run_window_configuration_change_hook): Move set_buffer part
6389 before select_frame_norecord part in order to unwind correctly.
6390 Rename count1 to count.
6391 (recombine_windows, delete_deletable_window, resize_root_window)
6392 (Fdelete_other_windows_internal)
6393 (Frun_window_configuration_change_hook, make_parent_window)
6394 (resize_window_check, resize_window_apply, Fresize_window_apply)
6395 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6396 (Fdelete_window_internal, Fresize_mini_window_internal):
6397 New functions.
1a13852e
MR
6398 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6399
f3d1777e
MR
64002011-06-08 Martin Rudalics <rudalics@gmx.at>
6401
496e208e
MR
6402 * window.h (window): Add some new members to window structure -
6403 normal_lines, normal_cols, new_total, new_normal, clone_number,
6404 splits, nest, prev_buffers, next_buffers.
6405 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6406 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6407
f3d1777e
MR
6408 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6409 Remove.
496e208e
MR
6410 (make_dummy_parent): Set new members of windows structure.
6411 (make_window): Move down in code. Handle new members of window
6412 structure.
6413 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6414 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6415 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6416 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6417 (Fset_window_next_buffers, Fset_window_clone_number):
6418 New functions.
496e208e
MR
6419 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6420 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6421 Doc-string fixes.
6422 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6423 Argument WINDOW can be now internal window too.
6424 (Fwindow_use_time): Move up in code.
6425 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6426 Rewrite doc-string.
6427 (Fset_window_configuration, saved_window)
6428 (Fcurrent_window_configuration, save_window_save): Handle new
6429 members of window structure.
b9e809c2
MR
6430 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6431 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6432 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6433 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6434 Qget_mru_window, Qresize_root_window,
6435 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6436 Qauto_buffer_name; staticpro them.
f3d1777e 6437
abde8f8c
MR
64382011-06-07 Martin Rudalics <rudalics@gmx.at>
6439
6440 * window.c (Fwindow_total_size, Fwindow_left_column)
6441 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6442 (Fwindow_list_1): New functions.
6443 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6444 (Fwindow_width, Fscroll_left, Fscroll_right):
6445 Use window_body_cols instead of window_box_text_cols.
6446 (delete_window, Fset_window_configuration):
6447 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6448 (delete_all_subwindows): Take a window as argument and not a
6449 structure. Rewrite.
190b47e6
MR
6450 (window_loop): Remove handling of GET_LRU_WINDOW and
6451 GET_LARGEST_WINDOW.
6452 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6453
6454 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6455 window_box_text_cols. delete_all_subwindows now takes a
6456 Lisp_Object as argument.
abde8f8c 6457
640c8776
SM
6458 * indent.c (compute_motion, Fcompute_motion):
6459 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6460
fa8a67e6
MR
6461 * frame.c (delete_frame): Call delete_all_subwindows with root
6462 window as argument.
6463
a54e3482
DC
64642011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6465
6466 * fns.c (Fputhash): Document return value.
6467
60002bf5
CY
64682011-06-06 Chong Yidong <cyd@stupidchicken.com>
6469
6470 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6471
0c671da6 64722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6473
b862a52a 6474 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6475
be44ca6c
PE
6476 Check for overflow when converting integer to cons and back.
6477 * charset.c (Fdefine_charset_internal, Fdecode_char):
6478 Use cons_to_unsigned to catch overflow.
6479 (Fencode_char): Use INTEGER_TO_CONS.
6480 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6481 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6482 * data.c (long_to_cons, cons_to_long): Remove.
6483 (cons_to_unsigned, cons_to_signed): New functions.
6484 These signal an error for invalid or out-of-range values.
6485 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6486 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6487 * font.c (Ffont_variation_glyphs):
6488 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6489 * lisp.h: Include <intprops.h>.
6490 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6491 (cons_to_signed, cons_to_unsigned): New decls.
6492 (long_to_cons, cons_to_long): Remove decls.
6493 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6494 (Fprimitive_undo): Use CONS_TO_INTEGER.
6495 * xfns.c (Fx_window_property): Likewise.
6496 * xselect.c: Include <limits.h>.
6497 (x_own_selection, selection_data_to_lisp_data):
6498 Use INTEGER_TO_CONS.
6499 (x_handle_selection_request, x_handle_selection_clear)
6500 (x_get_foreign_selection, Fx_disown_selection_internal)
6501 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6502 (lisp_data_to_selection_data): Use cons_to_unsigned.
6503 (x_fill_property_data): Use cons_to_signed.
6504 Report values out of range.
6505
d1f3d2af
PE
6506 Check for buffer and string overflow more precisely.
6507 * buffer.h (BUF_BYTES_MAX): New macro.
6508 * lisp.h (STRING_BYTES_MAX): New macro.
6509 * alloc.c (Fmake_string):
6510 * character.c (string_escape_byte8):
6511 * coding.c (coding_alloc_by_realloc):
6512 * doprnt.c (doprnt):
6513 * editfns.c (Fformat):
6514 * eval.c (verror):
6515 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6516 since they may not be the same number.
6517 * editfns.c (Finsert_char):
6518 * fileio.c (Finsert_file_contents):
6519 Likewise for BUF_BYTES_MAX.
6520
dd52fcea
PE
6521 * image.c: Use ptrdiff_t, not int, for sizes.
6522 (slurp_file): Switch from int to ptrdiff_t.
6523 All uses changed.
6524 (slurp_file): Check that file size fits in both size_t (for
6525 malloc) and ptrdiff_t (for sanity and safety).
6526
7f9bbdbb
PE
6527 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6528 if b->modtime has its maximal value.
6529
dfe18f82
PE
6530 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6531
84acfcf0
PE
6532 Don't assume time_t can fit into int.
6533 * buffer.h (struct buffer.modtime): Now time_t, not int.
6534 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6535 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6536
ccd9a01a
PE
6537 Minor fixes for signed vs unsigned integers.
6538 * character.h (MAYBE_UNIFY_CHAR):
6539 * charset.c (maybe_unify_char):
6540 * keyboard.c (read_char, reorder_modifiers):
6541 XINT -> XFASTINT, since the integer must be nonnegative.
6542 * ftfont.c (ftfont_spec_pattern):
6543 * keymap.c (access_keymap, silly_event_symbol_error):
6544 XUINT -> XFASTINT, since the integer must be nonnegative.
6545 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6546 since it makes no difference and we prefer signed.
6547 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6548 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6549 nonnegative.
6550
d6d100dd
SM
65512011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6552
6553 * window.h (Fwindow_frame): Declare.
6554
2b6148e4
PE
65552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6556
6557 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6558 (SPARE_MEMORY): Always define.
6559 (LARGE_REQUEST): Remove.
6560 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6561
f230ecc9
MR
65622011-06-06 Martin Rudalics <rudalics@gmx.at>
6563
727e958e
MR
6564 * lisp.h: Move EXFUNS for Fframe_root_window,
6565 Fframe_first_window and Fset_frame_selected_window to window.h.
6566
6567 * window.h: Move EXFUNS for Fframe_root_window,
6568 Fframe_first_window and Fset_frame_selected_window here from
6569 lisp.h.
6570
6571 * frame.c (Fwindow_frame, Fframe_first_window)
6572 (Fframe_root_window, Fframe_selected_window)
6573 (Fset_frame_selected_window): Move to window.c.
6574 (Factive_minibuffer_window): Move to minibuf.c.
6575 (Fother_visible_frames_p): New function.
6576
6577 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6578
f230ecc9
MR
6579 * window.c (decode_window, decode_any_window): Move up in code.
6580 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6581 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6582 (Fwindow_buffer): Move up and rewrite doc-string.
6583 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6584 (Fwindow_prev): New functions.
727e958e
MR
6585 (Fwindow_frame): Move here from frame.c. Accept any window as
6586 argument.
6587 (Fframe_root_window, Fframe_first_window)
6588 (Fframe_selected_window): Move here from frame.c. Accept frame
6589 or arbitrary window as argument. Update doc-strings.
6590 (Fminibuffer_window): Move up in code.
6591 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6592 (Fset_frame_selected_window): Move here from frame.c.
6593 Marginal rewrite.
727e958e
MR
6594 (Fselected_window, select_window, Fselect_window): Move up in
6595 code. Minor doc-string fixes.
f230ecc9 6596
4d09bcf6
PE
65972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6598
6599 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6600 Do not assume that spare memory exists; that assumption is valid
6601 only if SYSTEM_MALLOC.
6602 (LARGE_REQUEST): New macro, so that the issue of large requests
6603 is separated from the issue of spare memory.
6604
810928a2
AS
66052011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6606
172418ad
AS
6607 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6608 format. (Bug#8806)
6609
43f862f7
AS
6610 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6611
810928a2
AS
6612 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6613 before statements.
6614
a059fe24
JD
66152011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6616
6617 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6618
6619 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6620
6621 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6622 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6623
989bf368
JB
66242011-06-05 Juanma Barranquero <lekktu@gmail.com>
6625
6626 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6627
4b80f674
CY
66282011-06-04 Chong Yidong <cyd@stupidchicken.com>
6629
6630 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6631 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6632 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6633 New error handlers.
4b80f674
CY
6634 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6635 Obey Vx_select_enable_clipboard_manager. Catch errors in
6636 x_clipboard_manager_save (Bug#8779).
6637 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6638 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6639
99a33b77 66402011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6641
6642 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6643
99a33b77 66442011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6645
6646 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6647 in the current matrix if keep_current_p is non-zero.
6648
8264569d
EZ
66492011-06-04 Eli Zaretskii <eliz@gnu.org>
6650
6651 * bidi.c (bidi_level_of_next_char): Fix last change.
6652
57f97249
EZ
66532011-06-03 Eli Zaretskii <eliz@gnu.org>
6654
fec2107c 6655 Support bidi reordering of text covered by display properties.
57f97249 6656
fec2107c
EZ
6657 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6658 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6659 (bidi_cache_search, bidi_cache_iterator_state)
6660 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6661 (bidi_level_of_next_char, bidi_move_to_visually_next):
6662 Support character positions inside a run of characters covered by a
fec2107c
EZ
6663 display string.
6664 (bidi_paragraph_init, bidi_resolve_explicit_1)
6665 (bidi_level_of_next_char): Call bidi_fetch_char and
6666 bidi_fetch_char_advance instead of FETCH_CHAR and
6667 FETCH_CHAR_ADVANCE.
6668 (bidi_init_it): Initialize new members.
6669 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6670 definitions.
6671 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6672 instead of using explicit *_CHAR codes.
d6d100dd
SM
6673 (bidi_resolve_explicit, bidi_resolve_weak):
6674 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6675 bidirectional text is supported only in multibyte buffers.
6676 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6677 it to initialize the frame_window_p member of struct bidi_it.
6678 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6679 (bidi_resolve_explicit, bidi_resolve_weak)
6680 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6681 bidi_it->nchars is non-positive.
6682 (bidi_level_of_next_char): Don't try to lookup the cache for the
6683 next/previous character if nothing is cached there yet, or if we
6684 were just reseat()'ed to a new position.
c40e2fb2 6685
0e14fe90
EZ
6686 * xdisp.c (set_cursor_from_row): Set start and stop points
6687 according to the row's direction when priming the loop that looks
6688 for the glyph on which to display cursor.
6689 (single_display_spec_intangible_p): Function deleted.
6690 (display_prop_intangible_p): Reimplement to call
6691 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6692 Accept 3 additional arguments needed by handle_display_spec.
6693 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6694 values: lists, `(when COND...)' forms, etc.
6695 (single_display_spec_string_p): Support property values that are
6696 lists with the argument STRING its top-level element.
6697 (display_prop_string_p): Fix the condition for processing a
6698 property that is a list to be consistent with handle_display_spec.
fec2107c 6699 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6700 last portion of handle_display_prop.
6701 (compute_display_string_pos): Accept additional argument
6702 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6703 value of a `display' property is a "replacing spec".
6704 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6705 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6706 the display property, but just return a value indicating whether
6707 the display property will replace the characters it covers.
6708 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6709 frame_window_p members of struct bidi_it.
d6d100dd
SM
6710 (compute_display_string_pos, compute_display_string_end):
6711 New functions.
fec2107c
EZ
6712 (push_it): Accept second argument POSITION, where pop_it should
6713 jump to continue iteration.
6714 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6715
fec2107c
EZ
6716 * keyboard.c (adjust_point_for_property): Adjust the call to
6717 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6718
6719 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6720 (bidi_init_it): Update prototypes.
6721 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6722 (compute_display_string_pos, compute_display_string_end):
6723 Declare prototypes.
fec2107c
EZ
6724 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6725 EMACS_INT.
fc6f18ce 6726
40087514 67272011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6728
57f53182
PE
6729 Malloc failure behavior now depends on size of allocation.
6730 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6731 * lisp.h: Change signatures accordingly.
6732 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6733 All callers changed. (Bug#8762)
6734
6735 * gnutls.c: Use Emacs's memory allocators.
6736 Without this change, the gnutls library would invoke malloc etc.
6737 directly, which causes problems on non-SYNC_INPUT hosts, and which
6738 runs afoul of improving memory_full behavior. (Bug#8761)
6739 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6740 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6741 xfree instead of the default malloc, realloc, free.
6742 (Fgnutls_boot): No need to check for memory allocation failure,
6743 since xmalloc does that for us.
6744
ac32cd99 6745 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6746 * category.c (hash_get_category_set):
6747 * ccl.c (ccl_driver):
6748 * charset.c (Fdefine_charset_internal):
6749 * charset.h (struct charset.hash_index):
6750 * composite.c (get_composition_id, gstring_lookup_cache)
6751 (composition_gstring_put_cache):
6752 * composite.h (struct composition.hash_index):
6753 * dispextern.h (struct image.hash):
6754 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6755 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6756 (hashfn_equal, hashfn_user_defined, make_hash_table)
6757 (maybe_resize_hash_table, hash_lookup, hash_put)
6758 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6759 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6760 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6761 * image.c (make_image, search_image_cache, lookup_image)
6762 (xpm_put_color_table_h):
6763 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6764 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6765 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6766 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6767 * alloc.c (allocate_vectorlike):
6768 Check for overflow in vector size calculations.
6769 * ccl.c (ccl_driver):
6770 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6771 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6772 need to be updated by these changes.
40087514
PE
6773 * fns.c (make_hash_table, maybe_resize_hash_table):
6774 Check for integer overflow with large hash tables.
0de4bb68
PE
6775 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6776 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6777 (SXHASH_REDUCE): New macro.
6778 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6779 Use it instead of discarding useful hash info with large hash values.
6780 (sxhash_float): New function.
6781 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6782 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6783 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6784 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6785 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6786 Adjust signatures to match updated version of code.
6787 (consing_since_gc): Now EMACS_INT, since a single hash table can
6788 use more than INT_MAX bytes.
6789
698d32e2
DN
67902011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6791
6792 Make it possible to build with GCC-4.6+ -O2 -flto.
6793
6794 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6795
fd6fa53f
SM
67962011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6797
6798 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6799 Call minibuffer-inactive-mode.
6800
864db017
JB
68012011-05-31 Juanma Barranquero <lekktu@gmail.com>
6802
6803 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6804 Update dependencies.
6805
2ad0baf4
DN
68062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6807
6808 * data.c (init_data): Remove code for UTS, this system is not
6809 supported anymore.
6810
4fcc2638
DN
68112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6812
6813 Don't force ./temacs to start in terminal mode.
6814
6815 * frame.c (make_initial_frame): Initialize faces in all cases, not
6816 only when CANNOT_DUMP is defined.
6817 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6818
c56e0fd5
DN
68192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6820
6821 * dispnew.c (add_window_display_history): Use const for the string
6822 pointer. Remove declaration, not needed.
6823
333d54da 68242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6825
55d4c1b2 6826 Use 'inline', not 'INLINE'.
333d54da 6827 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6828 * alloc.c, fontset.c (INLINE): Remove.
6829 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6830 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6831 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6832 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6833 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6834
738db178
DN
68352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6836
6837 Make it possible to run ./temacs.
6838
6839 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6840 syms_of_callproc does the same thing. Remove test for
6841 "initialized", do it in the caller.
6842 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6843
620c53a6
SM
68442011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6845
6846 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6847 (read_minibuf): Use get_minibuffer.
6848 (syms_of_minibuf): Use DEFSYM.
6849 (Qmetadata): New var.
6850 * data.c (Qbuffer): Don't make it static.
6851 (syms_of_data): Use DEFSYM.
6852
e003a292
PE
68532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6854
6855 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6856 (CCL_CODE_MIN): New macro.
6857
ed008a6d
PE
68582011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6859
3687c2ef
PE
6860 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6861
ed008a6d
PE
6862 * eval.c (Qdebug): Now static.
6863 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6864 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6865 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6866
d66c4c7c
CY
68672011-05-29 Chong Yidong <cyd@stupidchicken.com>
6868
6869 * image.c: Various fixes to ImageMagick code comments.
6870 (Fimagemagick_types): Doc fix.
6871
5fbc2025
PE
68722011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6873
0196f88a
PE
6874 Minor fixes prompted by GCC 4.6.0 warnings.
6875
6876 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6877
5fbc2025
PE
6878 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6879 (x_clipboard_manager_save_all): Move extern decl to ...
6880 * xterm.h: ... here, so that it can be checked for consistency.
6881
1dd3c2d9
CY
68822011-05-29 Chong Yidong <cyd@stupidchicken.com>
6883
6884 * xselect.c (x_clipboard_manager_save_frame)
6885 (x_clipboard_manager_save_all): New functions.
6886 (Fx_clipboard_manager_save): Lisp function deleted.
6887
6888 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6889 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6890
6891 * xterm.h: Update prototype.
6892
5ba6571d
WX
68932011-05-28 William Xu <william.xwl@gmail.com>
6894
6895 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6896 exiting (Bug#8239).
6897
3eaff834
JM
68982011-05-28 Jim Meyering <meyering@redhat.com>
6899
e1900994 6900 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6901 * fns.c (to_uchar): Define.
6902 (crypto_hash_function): Use it to convert some newly-signed
6903 variables to unsigned, to avoid sign-extension bugs. For example,
6904 without this change, (md5 "truc") would evaluate to
6905 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6906 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6907 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6908
0f6990a7
PE
69092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6910
6911 Integer overflow fixes.
c8a9ca5a 6912
08686060
PE
6913 * dbusbind.c: Serial number integer overflow fixes.
6914 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6915 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6916 to hold a serial number that is too large for a fixnum.
6917 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6918 Check for serial numbers out of range. Decode any serial number
59568bf0 6919 that was so large that it became a float. (Bug#8722)
08686060 6920
2d1fc3c7
PE
6921 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6922 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6923 Use XFASTINT rather than XUINT when numbers are nonnegative.
6924 (xd_append_arg, Fdbus_method_return_internal):
6925 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6926 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6927 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6928 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6929 (Bug#8722)
2d1fc3c7 6930
c8a9ca5a
PE
6931 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6932
519e1d69
PE
6933 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6934
6df6ae42 6935 ccl: Add integer overflow checks.
30569699
PE
6936 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6937 (IN_INT_RANGE): New macros.
6938 (ccl_driver): Use them to check for integer overflow when
6939 decoding a CCL program. Many of the new checks are whether XINT (x)
6940 fits in int; it doesn't always, on 64-bit hosts. The new version
6941 doesn't catch all possible integer overflows, but it's an
847044ea 6942 improvement. (Bug#8719)
30569699 6943
c11285dc
PE
6944 * alloc.c (make_event_array): Use XINT, not XUINT.
6945 There's no need for unsigned here.
6946
fdccd48e
PE
6947 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6948 This follows up to the 2011-05-06 change that substituted uintptr_t
6949 for EMACS_INT. This case wasn't caught back then.
6950
37910ab2
PE
6951 Rework Fformat to avoid integer overflow issues.
6952 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6953 now (part of C89). Include <verify.h>.
6954 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6955 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6956 (Fformat): Avoid the prepass trying to compute sizes; it was only
6957 approximate and thus did not catch overflow reliably. Instead, walk
6958 through the format just once, formatting and computing sizes as we go,
6959 checking for integer overflow at every step, and allocating a larger
6960 buffer as needed. Keep track separately whether the format is
6961 multibyte. Keep only the most-recently calculated precision, rather
6962 than them all. Record whether each argument has been converted to
6963 string. Use EMACS_INT, not int, for byte and char and arg counts.
6964 Support field widths and precisions larger than INT_MAX. Avoid
6965 sprintf's undefined behavior with conversion specifications such as %#d
6966 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6967 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6968 formatting out-of-range floating point numbers with int
9173deec 6969 formats. (Bug#8668)
37910ab2 6970
2e6578fb
PE
6971 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6972
0ae6bdee
PE
6973 * data.c: Avoid integer truncation in expressions involving floats.
6974 * data.c: Include <intprops.h>.
6975 (arith_driver): When there's an integer overflow in an expression
6976 involving floating point, convert the integers to floating point
6977 so that the resulting value does not suffer from catastrophic
6978 integer truncation. For example, on a 64-bit host (* 4
6979 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6980 Do not rely on undefined behavior after integer overflow.
6981
de883a70
PE
6982 merge count_size_as_multibyte, parse_str_to_multibyte
6983 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6984 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6985 Check for integer overflow.
6986 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6987 since it's now a duplicate of the other. This is more of
6988 a character than a buffer op, so better that it's in character.c.
6989 * fns.c, print.c: Adjust to above changes.
6990
2ff916cb
PE
69912011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6992
6993 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6994
f1b54466
PE
69952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6996
fb1ac845
PE
6997 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6998 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6999 (x_clipboard_manager_save): Now static.
7000 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7001
f1b54466
PE
7002 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7003 (crypto_hash_function): Now static.
7004 Fix pointer signedness problems. Avoid unnecessary initializations.
7005
a9f737ee
CY
70062011-05-27 Chong Yidong <cyd@stupidchicken.com>
7007
7008 * termhooks.h (Vselection_alist): Make it terminal-local.
7009
7010 * terminal.c (create_terminal): Initialize it.
7011
7012 * xselect.c: Support for clipboard managers.
7013 (Vselection_alist): Move to termhooks.h as terminal-local var.
7014 (LOCAL_SELECTION): New macro.
7015 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7016 (symbol_to_x_atom): Remove gratuitous arg.
7017 (x_handle_selection_request, lisp_data_to_selection_data)
7018 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7019 (x_own_selection, x_get_local_selection, x_convert_selection):
7020 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7021 (some_frame_on_display): Delete unused function.
7022 (Fx_own_selection_internal, Fx_get_selection_internal)
7023 (Fx_disown_selection_internal, Fx_selection_owner_p)
7024 (Fx_selection_exists_p): New optional frame arg.
7025 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7026 (x_handle_selection_clear): Don't treat other terminals with the
7027 same keyboard specially. Use the terminal-local Vselection_alist.
7028 (x_clear_frame_selections): Use Frun_hook_with_args.
7029
7030 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7031
7032 * xterm.h: Add support for those atoms.
7033
e067f0c1
CY
70342011-05-26 Chong Yidong <cyd@stupidchicken.com>
7035
7036 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7037 (converted_selections, conversion_fail_tag): New global variables.
7038 (x_selection_request_lisp_error): Free the above.
7039 (x_get_local_selection): Remove unnecessary code.
7040 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7041 of converted selections stored in converted_selections.
7042 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7043 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7044 (x_convert_selection): New function.
7045 (x_handle_selection_event): Simplify.
7046 (x_get_foreign_selection): Don't ignore incoming requests while
7047 waiting for an answer; this will fail when we implement
7048 SAVE_TARGETS, and seems unnecessary anyway.
7049 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7050 (Vx_sent_selection_functions): Doc fix.
7051
0f4aebc0
LL
70522011-05-26 Leo Liu <sdl.web@gmail.com>
7053
7054 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7055
e61124cd
YM
70562011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7057
7058 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7059
7060 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7061 for fringe update if it has periodic bitmap.
ac389d0c 7062 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7063 and fringe_bitmap_periodic_p.
7064
7065 * fringe.c (get_fringe_bitmap_data): New function.
7066 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7067 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7068 row. Mark glyph row for fringe update if periodicity changed.
7069
7070 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7071 for fringe update unless it has periodic bitmap.
7072
f16d9837
KH
70732011-05-25 Kenichi Handa <handa@m17n.org>
7074
7075 * xdisp.c (get_next_display_element): Set correct it->face_id for
7076 a static composition.
7077
e1b90ef6
LL
70782011-05-24 Leo Liu <sdl.web@gmail.com>
7079
7080 * deps.mk (fns.o):
7081 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7082
7083 * fns.c (crypto_hash_function, Fsha1): New function.
7084 (Fmd5): Use crypto_hash_function.
7085 (syms_of_fns): Add Ssha1.
7086
7400048f
PE
70872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7088
7089 * gnutls.c: Remove unused macros.
7090 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7091 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7092 Remove macros that are defined and never used.
7093 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7094
abb71cf4
CY
70952011-05-22 Chong Yidong <cyd@stupidchicken.com>
7096
7097 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7098 (Fx_get_selection_internal): Minor cleanup.
7099 (Fx_own_selection_internal): Rename arguments for consistency with
7100 select.el.
7101
6307db39
PE
71022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7103
7104 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7105
f3d4e0a4
CY
71062011-05-22 Chong Yidong <cyd@stupidchicken.com>
7107
7108 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7109
4d8ade89
YM
71102011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7111
7112 * dispnew.c (scrolling_window): Don't exclude the case that the
7113 last enabled row in the desired matrix touches the bottom boundary.
7114
32078c8d
GM
71152011-05-21 Glenn Morris <rgm@gnu.org>
7116
7117 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7118 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7119 and add some more files.
32078c8d 7120
7285dc67
EZ
71212011-05-20 Eli Zaretskii <eliz@gnu.org>
7122
7123 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7124 report_file_error introduced by the change from 2011-05-07.
7125
89d1bd22
PE
71262011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7127
7128 * systime.h (Time): Define only if emacs is defined.
7129 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7130 where the include path doesn't have X11/X.h by default. See
7131 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7132
cd394be1 71332011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7134
7135 * composite.c (find_automatic_composition): Fix previous change.
7136
b9704ad9
GM
71372011-05-20 Glenn Morris <rgm@gnu.org>
7138
7139 * lisp.mk: New file, split from Makefile.in.
7140 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7141 (shortlisp): Remove.
7142 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7143
4a720484
GM
71442011-05-19 Glenn Morris <rgm@gnu.org>
7145
7146 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7147 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7148 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7149 (lisp): Set the order to that of loadup.el.
7150 (shortlisp): Make it a copy of $lisp.
7151 (SOME_MACHINE_LISP): Remove.
7152 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7153 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7154
a28d4396
KH
71552011-05-18 Kenichi Handa <handa@m17n.org>
7156
7157 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7158 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7159 (find_automatic_composition): Mostly rewrite for efficiency.
7160
a2b1fa8e
JB
71612011-05-18 Juanma Barranquero <lekktu@gmail.com>
7162
7163 * makefile.w32-in: Update dependencies.
7164
8e1f5610
CS
71652011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7166
7167 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7168 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7169
7025ee00 71702011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7171
cdfa6eab
PE
7172 Fix some integer overflow issues, such as string length overflow.
7173
06d6db33
PE
7174 * insdel.c (count_size_as_multibyte): Check for string overflow.
7175
2b4560a8
PE
7176 * character.c (lisp_string_width): Check for string overflow.
7177 Use EMACS_INT, not int, for string indexes and lengths; in
7178 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7179 the resulting string length overflows an EMACS_INT; instead,
7180 report a string overflow if no precision given. When checking for
7181 precision exhaustion, use a check that cannot possibly have
7182 integer overflow. (Bug#8675)
7183 * character.h (lisp_string_width): Adjust to new signature.
7184
cb93f9be
PE
7185 * alloc.c (string_overflow): New function.
7186 (Fmake_string): Use it. This doesn't change behavior, but saves
7187 a few bytes and will simplify future changes.
7188 * character.c (string_escape_byte8): Likewise.
7189 * lisp.h (string_overflow): New decl.
7190
1a1f3366
PE
7191 Fixups, following up to the user-interface timestamp change.
7192 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7193 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7194 * msdos.c (mouse_get_pos): Likewise.
7195 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7196 * w32gui.h (Time): Define by including "systime.h" rather than by
7197 declaring it ourselves. (Bug#8664)
7198
d4e3e4d3
PE
7199 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7200 * image.c (clear_image_cache): Likewise.
7201
f6a24d19
PE
7202 * term.c (term_mouse_position): Don't assume time_t wraparound.
7203
08dc5ae6
PE
7204 Be more systematic about user-interface timestamps.
7205 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7206 and sometimes 'EMACS_UINT', to represent these timestamps.
7207 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7208 This makes the code easier to follow, and makes it easier to catch
7209 integer overflow bugs such as Bug#8664.
7210 * frame.c (Fmouse_position, Fmouse_pixel_position):
7211 Use Time, not unsigned long, for user-interface timestamps.
7212 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7213 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7214 * keyboard.h (last_event_timestamp): Likewise.
7215 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7216 * menu.h (xmenu_show): Likewise.
7217 * term.c (term_mouse_position): Likewise.
7218 * termhooks.h (struct input_event.timestamp): Likewise.
7219 (struct terminal.mouse_position_hook): Likewise.
7220 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7221 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7222 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7223 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7224 what it was before.
7225 * menu.h, termhooks.h: Include "systime.h", for Time.
7226
8e55734a
PE
7227 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7228 Don't assume that the difference between two unsigned long values
7229 can fit into an integer. At this point, we know button_down_time
7230 <= event->timestamp, so the difference must be nonnegative, so
7231 there's no need to cast the result if double-click-time is
7232 nonnegative, as it should be; check that it's nonnegative, just in
7233 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7234 apart (about 25 days). (Bug#8664)
8e55734a 7235
841f1b75 7236 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7237 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7238
3e26f69c
PE
7239 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7240 that always fit in int. Use a sentinel instead of a counter, to
7241 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7242 * frame.h (struct frame): Use int for menu_bar_items_used
7243 instead of EMACS_INT, since it always fits in int.
3e26f69c 7244
5cc152c0
PE
7245 * menu.c (grow_menu_items): Check for int overflow.
7246
d89eb65e
PE
7247 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7248
5235bd3e
PE
7249 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7250 Before, the code was not consistent. These values cannot exceed
7251 2**31 - 1 so there's no need to make them unsigned.
7252 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7253 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7254 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7255 as modifiers.
7256 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7257
bc827e23
PE
7258 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7259 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7260 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7261 presumably because the widths might not match.
7262
78eb494e
PE
7263 * window.c (size_window): Avoid needless test at loop start.
7264
04f2d78b
CB
72652011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7266
7267 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7268
d2fc7e3d 72692011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7270
7271 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7272
d2fc7e3d 72732011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7274
7275 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7276 `width' to `bar_area_x' and `bar_area_width', respectively.
7277 (x_scroll_run): Take account of fringe background extension.
7278
04f2d78b
CB
7279 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7280 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7281 `bar_area_width', respectively.
7282 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7283 background extension.
7284
79b70037
GM
72852011-05-10 Jim Meyering <meyering@redhat.com>
7286
7287 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7288
2f142cc5
JB
72892011-05-10 Juanma Barranquero <lekktu@gmail.com>
7290
7291 * image.c (Finit_image_library): Return t for built-in image types,
7292 like pbm and xbm. (Bug#8640)
7293
57679c86
AS
72942011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7295
7296 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7297
888c9e86
EZ
72982011-05-07 Eli Zaretskii <eliz@gnu.org>
7299
b0512a1d
EZ
7300 * w32console.c (Fset_screen_color): Doc fix.
7301 (Fget_screen_color): New function.
7302 (syms_of_ntterm): Defsubr it.
7303
7285dc67
EZ
7304 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7305 unlink the temporary file if Fcall_process didn't create it in the
7306 first place.
7307 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7308 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7309 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7310 cue to call_process_cleanup not to close that handle.
7311
4d3fcc8e
BK
73122011-05-07 Ben Key <bkey76@gmail.com>
7313
7314 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7315 one of two shell specific rules, either bootstrap-temacs-CMD or
7316 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7317 to the previous implementation of the bootstrap-temacs rule.
7318 The bootstrap-temacs-CMD rule is similar to the previous
7319 implementation of the bootstrap-temacs rule except that it
7320 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7321 variable.
7322
7323 These changes, along with some changes to nt/configure.bat,
7324 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7325 earlier fix to add support for --cflags and --ldflags options
7326 that include quotes so that it works whether make uses cmd or
7327 sh as the shell.
7328
b4289b64
MA
73292011-05-06 Michael Albinus <michael.albinus@gmx.de>
7330
7331 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7332 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7333 is a constant.
7334 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7335 a string. Handle both cases.
7336 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7337 (Fdbus_register_method): Use Qinvalid_function.
7338
af4c0e28
JB
73392011-05-06 Juanma Barranquero <lekktu@gmail.com>
7340
7341 * makefile.w32-in: Update dependencies.
7342 (LISP_H): Add inttypes.h and stdin.h.
7343 (PROCESS_H): Add unistd.h.
7344
c51453d9
EZ
73452011-05-06 Eli Zaretskii <eliz@gnu.org>
7346
7347 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7348 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7349
8ff0ac3c 73502011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7351
4c4b566b
PE
7352 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7353
aab2b9b5
PE
7354 * term.c (vfatal): Remove stray call to va_end.
7355 It's not needed and the C Standard doesn't allow it here anyway.
7356
c378da0b
PE
7357 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7358 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7359
288b08c7
PE
7360 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7361 bytes.
7362
e3601888
PE
7363 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7364
db6c0e74
PE
7365 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7366
dd5963ea
PE
7367 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7368
88c9450f
PE
7369 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7370
2f9442b8
PE
7371 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7372
c032b5f8
PE
7373 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7374 * charset.c (Fdefine_charset_internal): Don't initialize
7375 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7376 32-bit int (Bug#8600).
a108c10b
PE
7377
7378 * lread.c (read_integer): Be more consistent with string-to-number.
7379 Use string_to_number to do the actual conversion; this avoids
7380 rounding errors and fixes some other screwups. Without this fix,
7381 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7382 (digit_to_number): Move earlier, for benefit of read_integer.
7383 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7384 not a digit in any supported base. (Bug#8602)
a108c10b 7385
ad5f9eea
PE
7386 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7387
aec1708a
PE
7388 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7389 to match comment at start of function. This also removes a
7390 GCC warning about overflow in a 32+64-bit port.
7391
47be4ab5
PE
7392 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7393
371cac43
PE
7394 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7395 Reported by Stefan Monnier in
7396 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7397 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7398 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7399
d01a7826
PE
7400 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7401 (EMACS_UINTPTR): Likewise, with uintptr_t.
7402
7fd47d5c
PE
7403 * lisp.h: Prefer 64-bit EMACS_INT if available.
7404 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7405 on 32-bit hosts that have 64-bit int, so that they can access
7406 large files.
122b0c86
PE
7407 However, temporarily disable this change unless the temporary
7408 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7409
8727937b
PE
7410 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7411
8ac068ac
PE
7412 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7413 This removes an assumption that EMACS_INT and long are the same
7414 width as pointers. The assumption is true for Emacs porting targets
7415 now, but we want to make other targets possible.
7416 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7417 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7418 In the rest of the code, change types of integers that hold casted
7419 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7420 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7421 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7422 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7423 No need to cast type when ORing.
7424 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7425 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7426 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7427 assume EMACS_INT is the same width as char *.
7428 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7429 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7430 Remove no-longer-needed casts.
7431 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7432 (xg_tool_bar_help_callback, xg_make_tool_item):
7433 Use EMACS_INTPTR to hold an integer
7434 that will be cast to void *; this can avoid a GCC warning
7435 if EMACS_INT is not the same width as void *.
7436 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7437 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7438 (current_message_1, set_message_1):
7439 Use a local to convert to proper width without a cast.
7440 * xmenu.c (dialog_selection_callback): Likewise.
7441
ede49d71
PE
7442 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7443 Also, don't assume VALBITS / RAND_BITS is less than 5,
7444 and don't rely on undefined behavior when shifting a 1 left into
7445 the sign bit.
7446 * lisp.h (get_random): Change signature to match.
7447
2f30ecd0
PE
7448 * lread.c (hash_string): Use size_t, not int, for hash computation.
7449 Normally we prefer signed values; but hashing is special, because
7450 it's better to use unsigned division on hash table sizes so that
7451 the remainder is nonnegative. Also, size_t is the natural width
7452 for hashing into memory. The previous code used 'int', which doesn't
7453 retain enough info to hash well into very large tables.
7454 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7455
2a866e7b
PE
7456 * dbusbind.c: Don't possibly lose pointer info when converting.
7457 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7458 Use XPNTR rather than XHASH, so that the high-order bits of
7459 the pointer aren't lost when converting through void *.
7460
51639eac
PE
7461 * eval.c (Fautoload): Don't double-shift a pointer.
7462
92394119
PE
7463 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7464
dbdb9a7c
JB
74652011-05-06 Juanma Barranquero <lekktu@gmail.com>
7466
7467 * gnutls.c (DEF_GNUTLS_FN):
7468 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7469
db7a0b4f
AS
74702011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7471
7472 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7473 marker. (Bug#8610)
7474
cd394be1 74752011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7476
7477 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7478 New version that can reserve upto 2GB of heap space.
7479
f7ff1b0f 74802011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7481
7482 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7483
639c109b
TZ
74842011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7485
7486 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7487 `gnutls_certificate_set_x509_key_file'.
7488
d2127135
JB
74892011-05-05 Juanma Barranquero <lekktu@gmail.com>
7490
7491 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7492 Update dependencies.
7493
e968f4f3
JB
74942011-05-04 Juanma Barranquero <lekktu@gmail.com>
7495
7496 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7497 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7498 Remove unused parameter `fildes'.
7499 * process.c (read_process_output, send_process): Don't pass it.
7500
84d358f0
JB
75012011-05-04 Juanma Barranquero <lekktu@gmail.com>
7502
7503 Fix previous change: the library cache is defined in w32.c.
7504 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7505 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7506
0898ca10
JB
75072011-05-04 Juanma Barranquero <lekktu@gmail.com>
7508
7509 Implement dynamic loading of GnuTLS on Windows.
7510
7511 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7512 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7513 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7514 Declare.
7515
7516 * gnutls.c (Qgnutls_dll): Define.
7517 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7518 (gnutls_*): Declare function pointers.
7519 (init_gnutls_functions): New function to initialize function pointers.
7520 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7521 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7522 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7523 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7524 (emacs_gnutls_write, emacs_gnutls_read)
7525 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7526 (Fgnutls_available_p): New function.
7527 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7528 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7529 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7530
7531 * image.c: Include w32.h.
7532 (Vimage_type_cache): Delete.
7533 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7534 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7535 (w32_delayed_load): Move to w32.c.
7536
7537 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7538
7539 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7540 (w32_delayed_load): Move from image.c. When loading a library, record
7541 its filename in the :loaded-from property of the library id.
7542 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7543 Initialize and staticpro them.
7544 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7545
7546 * process.c: Include lisp.h before w32.h, not after.
7547 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7548 instead of gnutls_record_check_pending.
7549
7550 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7551
ff4de4aa
TZ
75522011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7553
7554 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7555 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7556 as passed in.
7557
abe95abb
JD
75582011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7559
7560 * xterm.c (x_set_frame_alpha): Do not set property on anything
7561 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7562
e16e55d4
JB
75632011-05-02 Juanma Barranquero <lekktu@gmail.com>
7564
7565 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7566
bafcf6a5
JB
75672011-05-02 Juanma Barranquero <lekktu@gmail.com>
7568
7569 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7570 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7571 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7572 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7573 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7574 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7575 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7576 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7577 (Qgnutls_bootprop_callbacks_verify): Make static.
7578
e7a6747f
AS
75792011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7580
19ed11ba
AS
7581 * callproc.c: Indentation fixup.
7582
e7a6747f 7583 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7584 (wait_for_termination, interruptible_wait_for_termination):
7585 Move after wait_for_termination_1.
e7a6747f 7586
1ef14cb4
LMI
75872011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7588
7589 * sysdep.c (interruptible_wait_for_termination): New function
7590 which is like wait_for_termination, but allows keyboard
7591 interruptions.
7592
7593 * callproc.c (Fcall_process): Add (:file "file") as an option for
7594 the STDOUT buffer.
7595 (Fcall_process_region): Ditto.
7596
330d880c
EZ
75972011-04-30 Eli Zaretskii <eliz@gnu.org>
7598
8db90b73
EZ
7599 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7600 rather than `XVECTOR (FOO)->size'.
7601
330d880c
EZ
7602 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7603 inttypes.h, as a gnulib replacement is used if it not available in
7604 system headers.
7605
15cbd324
EZ
76062011-04-21 Eli Zaretskii <eliz@gnu.org>
7607
7608 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7609 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7610 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7611
7612 * coding.c (coding_alloc_by_realloc): Error out if destination
7613 will grow beyond MOST_POSITIVE_FIXNUM.
7614 (decode_coding_emacs_mule): Abort if there isn't enough place in
7615 charbuf for the composition carryover bytes. Reserve an extra
7616 space for up to 2 characters produced in a loop.
7617 (decode_coding_iso_2022): Abort if there isn't enough place in
7618 charbuf for the composition carryover bytes.
7619
76202011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7621
ae940cca
EZ
7622 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7623 aborting when %lld or %lll format is passed.
7624 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7625 %llo or %llx format is passed. (Bug#8545)
7626
03ab8921
EZ
7627 * window.c (window_scroll_line_based): Use a marker instead of
7628 simple variables to record original value of point. (Bug#7952)
7629
afda1437
EZ
7630 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7631 produced by %s or %c overflows available buffer space. (Bug#8545)
7632
f76dee0c
PE
76332011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7634
7635 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7636 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7637
fdc5744d
JB
76382011-04-28 Juanma Barranquero <lekktu@gmail.com>
7639
7640 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7641
638f053a
JB
76422011-04-28 Juanma Barranquero <lekktu@gmail.com>
7643
7644 * keyboard.c (Qdelayed_warnings_hook): Define.
7645 (command_loop_1): Run `delayed-warnings-hook'
7646 if Vdelayed_warnings_list is non-nil.
7647 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7648 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7649
d178f871
EZ
76502011-04-28 Eli Zaretskii <eliz@gnu.org>
7651
7652 * doprnt.c (doprnt): Don't return value smaller than the buffer
7653 size if the message was truncated. (Bug#8545).
7654
b124fd93
JB
76552011-04-28 Juanma Barranquero <lekktu@gmail.com>
7656
7657 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7658 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7659
e810457d
PE
76602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7661
7662 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7663
ea51cceb
JB
76642011-04-27 Juanma Barranquero <lekktu@gmail.com>
7665
7666 * makefile.w32-in: Update dependencies.
7667
94dcfacf
EZ
76682011-04-27 Eli Zaretskii <eliz@gnu.org>
7669
7670 Improve `doprnt' and its usage. (Bug#8545)
7671 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7672 `format_end'. Remove support for %l as a conversion specifier.
7673 Don't use xrealloc. Improve diagnostics when the %l size modifier
7674 is used. Update the commentary.
7675
7676 * eval.c (verror): Simplify calculation of size_t.
7677
7678 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7679 messages.
7680
f61f41d7
PE
76812011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7682
7683 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7684 change.
7685
96fb4434
PE
76862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7687
7688 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7689 This makes this file independent of the recent pseudovector change.
7690
671875da 76912011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7692
69e9b5a3
PE
7693 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7694
b5f869a7 7695 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7696 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7697 Remove unused local.
c8926152 7698 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7699
841a1577 7700 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7701 GCC 4.6.0 optimizes based on type-based alias analysis.
7702 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7703 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7704 != &v->size, and therefore "v->size = 1; b->size = 2; return
7705 v->size;" must therefore return 1. This assumption is incorrect
7706 for Emacs, since it type-puns struct Lisp_Vector * with many other
7707 types. To fix this problem, this patch adds a new type struct
f904488f 7708 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7709 and pseudovectors, and helps optimizing compilers not get fooled
7710 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7711 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7712 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7713 the size member.
eab3844f
PE
7714 (XSETPVECTYPE): Rewrite in terms of new macro.
7715 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7716 This is a bit clearer, and further avoids the possibility of
7717 undesirable aliasing.
7718 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7719 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7720 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7721 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7722 (ASIZE): Now uses header.size rather than size.
7723 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7724 to avoid the hassle of writing XVECTOR (foo)->header.size.
7725 (struct vectorlike_header): New type.
eab3844f
PE
7726 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7727 object, to help avoid aliasing.
7728 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7729 (SUBRP): Likewise, since Lisp_Subr is a special case.
7730 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7731 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7732 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7733 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7734 changed to be "header.size" and "header.next".
7735 * buffer.h (struct buffer): Likewise.
7736 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7737 * frame.h (struct frame): Likewise.
7738 * process.h (struct Lisp_Process): Likewise.
7739 * termhooks.h (struct terminal): Likewise.
7740 * window.c (struct save_window_data, struct saved_window): Likewise.
7741 * window.h (struct window): Likewise.
7742 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7743 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7744 * buffer.c (init_buffer_once): Likewise.
7745 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7746 special case.
7747 * process.c (Fformat_network_address): Use local var for size,
7748 for brevity.
7749
0df1eac5
PE
7750 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7751
847ab9d1 7752 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7753 * data.c (atof): Remove decl; no longer used or needed.
7754 (digit_to_number): Move to lread.c.
7755 (Fstring_to_number): Use new string_to_number function, to be
7756 consistent with how the Lisp reader treats infinities and NaNs.
7757 Do not assume that floating-point numbers represent EMACS_INT
7758 without losing information; this is not true on most 64-bit hosts.
7759 Avoid double-rounding errors, by insisting on integers when
7760 parsing non-base-10 numbers, as the documentation specifies.
7761 * lisp.h (string_to_number): New decl, replacing ...
7762 (isfloat_string): Remove.
bc0a5c13 7763 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7764 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7765 appears to have been a coding error. Similarly, do not accept
7766 strings like +-1e0 as floating point numbers. Do not report
7767 overflow for integer overflows unless the base is not 10 which
7768 means we have no simple and reliable way to continue.
7769 Break out the floating-point parsing into a new
7770 function string_to_number, so that Fstring_to_number parses
7771 floating point numbers consistently with the Lisp reader.
04f2d78b 7772 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7773 (E_CHAR, EXP_INT): Remove, replacing with ...
7774 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7775 (string_to_number): New function, replacing isfloat_string.
7776 This function checks for valid syntax and produces the resulting
7777 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7778 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7779 so that overflow for non-base-10 numbers is reported only when
7780 there's no portable and simple way to convert to floating point.
452f4150 7781
67769ffc
PE
7782 * textprop.c (set_text_properties_1): Rewrite for clarity,
7783 and to avoid GCC warning about integer overflow.
7784
c20db43f
PE
7785 * intervals.h (struct interval): Use EMACS_INT for members
7786 where EMACS_UINT might cause problems. See
7787 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7788 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7789 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7790 All uses changed.
37aa2f85
PE
7791 (offset_intervals): Tell GCC not to worry about length overflow
7792 when negating a negative length.
c20db43f 7793
2538aa2f
PE
7794 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7795 (overrun_check_free): Likewise.
7796
f2d3008d
PE
7797 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7798 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7799 word size.
7800
ec8df744
PE
7801 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7802 (gnutls_make_error): Rename local to avoid shadowing.
7803 (gnutls_emacs_global_deinit): ifdef out; not used.
7804 (Fgnutls_boot): Use const for pointer to readonly storage.
7805 Comment out unused local. Fix pointer signedness problems.
7806
640ee02d
PE
7807 * lread.c (openp): Don't stuff size_t into an 'int'.
7808 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7809 about possible signed overflow.
7810
6048fb2a
PE
7811 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7812 (GDK_KEY_g): Don't define if already defined.
7813 (xg_prepare_tooltip): Avoid pointer signedness problem.
7814 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7815
fa3c87e1
PE
7816 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7817 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7818
2172544b
PE
7819 * xfns.c (Fx_window_property): Simplify a bit,
7820 to make a bit faster and to avoid GCC 4.6.0 warning.
7821 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7822
9b821a21
PE
7823 * fns.c (internal_equal): Don't assume size_t fits in int.
7824
3c616cfa
PE
7825 * alloc.c (compact_small_strings): Tighten assertion a little.
7826
c2982e87
PE
7827 Replace pEd with more-general pI, and fix some printf arg casts.
7828 * lisp.h (pI): New macro, generalizing old pEd macro to other
7829 conversion specifiers. For example, use "...%"pI"d..." rather
7830 than "...%"pEd"...".
7831 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7832 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7833 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7834 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7835 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7836 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7837 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7838 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7839 64-bit hosts.
7840 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7841 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7842 * print.c (safe_debug_print, print_object): Likewise.
7843 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7844 to int.
6f04d126
PE
7845 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7846 avoiding the 0 flag, which is not portable.
c2982e87
PE
7847 * process.c (Fmake_network_process): Use pI to avoid cast.
7848 * region-cache.c (pp_cache): Likewise.
7849 * xdisp.c (decode_mode_spec): Likewise.
7850 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7851 behavior on 64-bit hosts with printf arg.
6f04d126 7852 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7853 (x_stop_queuing_selection_requests): Likewise.
7854 (x_get_window_property): Don't truncate byte count to an 'int'
7855 when tracing.
0b432f21 7856
5e073ec7
PE
7857 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7858 here, since it parses constructs like leading '-' and spaces,
7859 which are not wanted; and it overflows with large numbers.
7860 Instead, simply match F[0-9]+, which is what is wanted anyway.
7861
36372bf9
PE
7862 * alloc.c: Remove unportable assumptions about struct layout.
7863 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7864 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7865 (allocate_vectorlike, make_pure_vector): Use the new macros,
7866 plus offsetof, to remove unportable assumptions about struct layout.
7867 These assumptions hold on all porting targets that I know of, but
7868 they are not guaranteed, they're easy to remove, and removing them
7869 makes further changes easier.
7870
0b432f21
PE
7871 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7872 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7873 (string_overrun_cookie): Now const. Use initializers that
7874 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7875 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7876 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7877 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7878 multiple of sizeof (EMACS_INT); it need not be, if
7879 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7880 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7881
895009e1
JB
78822011-04-26 Juanma Barranquero <lekktu@gmail.com>
7883
7884 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7885
6a7a1b0b
TZ
78862011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7887
7888 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7889 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7890 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7891
841a1577 78922011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7893
7894 * lisp.h (Qdebug): List symbol.
895009e1 7895 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7896 * keyboard.c (debug-on-event): New variable.
7897 (handle_user_signal): Break into debugger when debug-on-event
7898 matches the current signal symbol.
7899
f2d3ba6f
DN
79002011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7901
7902 * alloc.c (check_sblock, check_string_bytes)
7903 (check_string_free_list): Convert to standard C.
7904
42ce4c63
TZ
79052011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7906
7907 * w32.c (emacs_gnutls_push): Fix typo.
7908
825cd63c
EZ
79092011-04-25 Eli Zaretskii <eliz@gnu.org>
7910
fb11d64d
EZ
7911 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7912 "cast to pointer from integer of different size".
7913
825cd63c
EZ
7914 Improve doprnt and its use in verror. (Bug#8545)
7915 * doprnt.c (doprnt): Document the set of format control sequences
7916 supported by the function. Use SAFE_ALLOCA instead of always
7917 using `alloca'.
7918
7919 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7920 is one byte too soon. Don't use xrealloc; instead xfree and
7921 xmalloc anew.
7922
e061a11b
TZ
79232011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7924
7925 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7926 callbacks stage.
7927
7928 * gnutls.c: Renamed global_initialized to
7929 gnutls_global_initialized. Added internals for the
7930 :verify-hostname-error, :verify-error, and :verify-flags
7931 parameters of `gnutls-boot' and documented those parameters in the
7932 docstring. Start callback support.
9173deec
JB
7933 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7934 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7935 on error. Return error code.
e061a11b
TZ
7936 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7937 (emacs_gnutls_read): Likewise.
7938 (Fgnutls_boot): Return handshake error code.
7939 (emacs_gnutls_handle_error): New function.
7940 (wsaerror_to_errno): Likewise.
7941
7942 * w32.h (emacs_gnutls_pull): Add prototype.
7943 (emacs_gnutls_push): Likewise.
7944
7945 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7946 (emacs_gnutls_push): Likewise.
7947
79482011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7949
7950 * process.c (wait_reading_process_output): Check if GnuTLS
7951 buffered some data internally if no FDs are set for TLS
7952 connections.
7953
7954 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7955 (LIBS): Link to USER_LIBS.
7956 ($(BLD)/gnutls.$(0)): New target.
7957
fa6996bc
EZ
79582011-04-24 Eli Zaretskii <eliz@gnu.org>
7959
eb35682e
EZ
7960 * xdisp.c (handle_single_display_spec): Rename the
7961 display_replaced_before_p argument into display_replaced_p, to
7962 make it consistent with the commentary. Fix typos in the
7963 commentary.
7964
e2ad650c
EZ
7965 * textprop.c (syms_of_textprop): Remove dead code.
7966 (copy_text_properties): Delete obsolete commentary about an
7967 interface that was deleted long ago. Fix typos in the description
7968 of arguments.
7969
1b2de274
EZ
7970 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7971 to changes in oldXMenu/XMenu.h from 2011-04-16.
7972 <menu_help_message, prev_menu_help_message>: Constify.
7973 (IT_menu_make_room): menu->help_text is now `const char **';
7974 adjust.
7975
7976 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7977 to changes in oldXMenu/XMenu.h from 2011-04-16.
7978 (struct XMenu): Declare `help_text' `const char **'.
7979
7980 * xfaces.c <Qunspecified>: Make extern again.
7981
7982 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7983 required by POSIX.
1b2de274 7984
762b15be
EZ
7985 * doc.c (get_doc_string): Improve the format passed to `error'.
7986
7987 * doprnt.c (doprnt): Improve commentary.
7988
7989 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7990
7991 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7992 them with etags.
7993
f1052e5d
EZ
7994 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7995 changes in globals.h immediately force recompilation.
762b15be
EZ
7996 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7997 $(CURDIR)/s/ms-w32.h.
7998 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7999
fa6996bc
EZ
8000 * character.c (Fchar_direction): Function deleted.
8001 (syms_of_character): Don't defsubr it.
8002 <char-direction-table>: Deleted.
8003
e6c3da20
EZ
80042011-04-23 Eli Zaretskii <eliz@gnu.org>
8005
8006 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8007 * doprnt.c: Include limits.h.
8008 (SIZE_MAX): New macro.
04f2d78b
CB
8009 (doprnt): Return a size_t value. 2nd arg is now size_t.
8010 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8011 Improve overflow protection. Support `l' modifier for integer
8012 conversions. Support %l conversion. Don't assume an EMACS_INT
8013 argument for integer conversions and for %c.
8014
8015 * lisp.h (doprnt): Restore prototype.
8016
8017 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8018 $(SRC)/character.h.
8019
8020 * Makefile.in (base_obj): Add back doprnt.o.
8021
8022 * deps.mk (doprnt.o): Add back prerequisites.
8023 (callint.o): Depend on character.h.
8024
8025 * eval.c (internal_lisp_condition_case): Include the handler
8026 representation in the error message.
8027 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8028 when breaking from the loop.
8029
8030 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8031
8032 * callint.c (Fcall_interactively): When displaying error message
8033 about invalid control letter, pass the character's codepoint, not
8034 a pointer to its multibyte form. Improve display of the character
8035 in octal and display also its hex code.
8036
8037 * character.c (char_string): Use %x to display the (unsigned)
8038 codepoint of an invalid character, to avoid displaying a bogus
8039 negative value.
8040
8041 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8042 `error', not SYMBOL_NAME itself.
8043
8044 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8045 character arguments to `error'.
8046
8047 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8048 to `error' in error message about FINAL_CHAR argument. Make sure
8049 FINAL_CHAR is a character, and use %c when it is passed as
8050 argument to `error'.
8051
4ffd0d6b 80522011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8053
8054 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8055
8056 * w32.c: Include <time.h>.
8057 (sys_localtime): New function.
8058
4ffd0d6b 80592011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8060
8061 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8062
4ffd0d6b 8063 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8064
4ffd0d6b 80652011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8066
4ffd0d6b
GM
8067 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8068 zombies (Bug#8467).
aac0c6e3 8069
04c56954
EZ
80702011-04-19 Eli Zaretskii <eliz@gnu.org>
8071
8072 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8073 gl_state.e_property when gl_state.object is Qt.
8074
8075 * insdel.c (make_gap_larger): Remove limitation of buffer size
8076 to <= INT_MAX.
8077
16a43933
CY
80782011-04-18 Chong Yidong <cyd@stupidchicken.com>
8079
8080 * xdisp.c (lookup_glyphless_char_display)
8081 (produce_glyphless_glyph): Handle cons cell entry in
8082 glyphless-char-display.
8083 (Vglyphless_char_display): Document it.
8084
8085 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8086 glyphless-char-display.
8087
4581706e
CY
80882011-04-17 Chong Yidong <cyd@stupidchicken.com>
8089
8090 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8091
8092 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8093
8094 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8095 definition for no-X builds.
8096
4887c6e2 80972011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8098
fd35b6f9
PE
8099 Static checks with GCC 4.6.0 and non-default toolkits.
8100
5c1ccb01
PE
8101 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8102
006c5daa
PE
8103 * process.c (keyboard_bit_set): Define only if SIGIO.
8104 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8105 (send_process): Repair possible setjmp clobbering.
8106
efc736d3
PE
8107 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8108
4e2fe2e6
PE
8109 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8110
f97334a2
PE
8111 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8112
4e75f29d
PE
8113 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8114 Define only if needed.
8115
90efadd1
PE
8116 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8117 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8118 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8119
3c647824
PE
8120 * dispextern.h (struct redisplay_interface): Rename param
8121 to avoid shadowing.
e264f262 8122 * termhooks.h (struct terminal): Likewise.
761383f4 8123 * xterm.c (xembed_send_message): Likewise.
3c647824 8124
b58c5c4a
PE
8125 * insdel.c (make_gap_smaller): Define only if
8126 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8127
cad59032
PE
8128 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8129 it.
8130
c339dc2e
PE
8131 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8132 so that we aren't warned about unused symbols.
8133
91a3e27b
PE
8134 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8135
399c71d3 8136 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8137
8ffc96f5
PE
8138 * xfns.c (x_real_positions): Mark locals as initialized.
8139
eef9bc79
PE
8140 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8141
098db9dd
PE
8142 * xterm.c: Fix problems found by static analysis with other toolkits.
8143 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8144 (x_dispatch_event): Declare static if USE_GTK, and
8145 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8146 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8147 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8148 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8149 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8150
eb18f6cc
PE
8151 * xmenu.c (menu_help_callback): Pointer type fixes.
8152 Use const pointers when pointing at readonly data. Avoid pointer
8153 signedness clashes.
8154 (FALSE): Remove unused macro.
8155 (update_frame_menubar): Remove unused decl.
8156
1fe72bf8
PE
8157 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8158
60d9e1db
PE
8159 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8160 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8161 (single_menu_item): Rename local to avoid shadowing.
8162
39261c26
PE
8163 * keyboard.c (make_lispy_event): Remove unused local var.
8164
018c5e19
PE
8165 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8166 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8167
63d2b86e
PE
8168 * bitmaps: Change bitmaps from unsigned char back to the X11
8169 compatible char. Avoid the old compiler warnings about
8170 out-of-range initializers by using, for example, '\xab' rather
8171 than 0xab.
8172
aefd87e1
PE
8173 * xgselect.c (xgselect_initialize): Check vs interface
8174 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8175
bf501fb9
PE
8176 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8177
e9829fdf
PE
8178 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8179 to read-only memory.
8180
1086c095
PE
8181 * fns.c (vector): Remove; this old hack is no longer needed.
8182
2baccd04 8183 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 8184 Remove unused var.
dde42981 8185 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8186
72391843 8187 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8188
436c16df 8189 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8190 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8191 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8192
92bb796d 8193 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8194 (x_term_init): Remove local to avoid shadowing.
92bb796d 8195
764430a3 8196 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8197
8198 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8199 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8200
d1dfb56c
EZ
82012011-04-16 Eli Zaretskii <eliz@gnu.org>
8202
c4354cb4
EZ
8203 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8204
d1dfb56c
EZ
8205 Fix regex.c, syntax.c and friends for buffers > 2GB.
8206 * syntax.h (struct gl_state_s): Declare character position members
8207 EMACS_INT.
8208
8209 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8210
04f2d78b
CB
8211 * textprop.c (verify_interval_modification, interval_of):
8212 Declare arguments EMACS_INT.
d1dfb56c
EZ
8213
8214 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8215 EMACS_INT.
8216
8217 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8218
8219 * indent.c (Fvertical_motion): Local variable it_start is now
8220 EMACS_INT.
8221
8222 * regex.c (re_match, re_match_2, re_match_2_internal)
8223 (bcmp_translate, regcomp, regexec, print_double_string)
8224 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8225 (re_compile_pattern, re_exec): Declare arguments and local
8226 variables `size_t' and `ssize_t' and return values `regoff_t', as
8227 appropriate.
8228 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8229 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8230 <compile_stack_type>: `size' and `avail' are now `size_t'.
8231
8232 * regex.h <regoff_t>: Use ssize_t, not int.
8233 (re_search, re_search_2, re_match, re_match_2): Arguments that
8234 specify buffer/string position and length are now ssize_t and
8235 size_t. Return type is regoff_t.
8236
613052cd
BK
82372011-04-16 Ben Key <bkey76@gmail.com>
8238
8239 * nsfont.m: Fixed bugs in ns_get_family and
8240 ns_descriptor_to_entity that were caused by using free to
8241 deallocate memory blocks that were allocated by xmalloc (via
8242 xstrdup). This caused Emacs to crash when compiled with
8243 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8244 --enable-checking=xmallocoverrun). xfree is now used to
8245 deallocate these memory blocks.
8246
4170f62f 82472011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8248
71b41406
PE
8249 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8250
9587a89d
PE
8251 emacs_write: Accept and return EMACS_INT for sizes.
8252 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8253 et seq.
8254 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8255 Accept and return EMACS_INT.
8256 (emacs_gnutls_write): Return the number of bytes written on
8257 partial writes.
8258 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8259 (emacs_read, emacs_write): Remove check for negative size, as the
8260 Emacs source code has been audited now.
9587a89d
PE
8261 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8262 (emacs_read, emacs_write): Use it.
273a5f82
PE
8263 * process.c (send_process): Adjust to the new signatures of
8264 emacs_write and emacs_gnutls_write. Do not attempt to store
8265 a byte offset into an 'int'; it might overflow.
9587a89d 8266 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8267
3e047f51
PE
8268 * sound.c: Don't assume sizes fit in 'int'.
8269 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8270 Return EMACS_INT, not int.
3e047f51 8271 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8272 Accept EMACS_INT, not int.
8273 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8274 record read return values.
8275
cc39a9db
BK
82762011-04-15 Ben Key <bkey76@gmail.com>
8277
c9d0ec6d
JB
8278 * keyboard.c (Qundefined): Don't declare static since it is used
8279 in nsfns.m.
8280 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8281 static since they are used in nsfont.m.
cc39a9db 8282
6c60eb9f
SM
82832011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8284
8285 * process.c (Qprocessp): Don't declare static.
8286 * lisp.h (Qprocessp): Declare again.
8287
7990b61a
JB
82882011-04-15 Juanma Barranquero <lekktu@gmail.com>
8289
8290 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8291
5d4cb038
PE
82922011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8293
8bd7b830 8294 Improve C-level modularity by making more things 'static'.
cd64ea1d 8295
e3b27b31
PE
8296 Don't publish debugger-only interfaces to other modules.
8297 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8298 (verify_bytepos, count_markers): Move decls to the only modules
8299 that need them.
8300 * region-cache.h (pp_cache): Likewise.
8301 * window.h (check_all_windows): Likewise.
8302 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8303
5d4cb038
PE
8304 * sysdep.c (croak): Now static, if
8305 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8306 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8307
8308 * alloc.c (refill_memory_reserve): Now static if
8309 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8310 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8311
e87b6180
PE
8312 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8313 Define only if USE_LUCID.
8314
ac64929e
PE
8315 * xrdb.c (x_customization_string, x_rm_string): Now static.
8316
6f37259d
PE
8317 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8318 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8319
1683e3ab
PE
8320 * xdisp.c (draw_row_with_mouse_face): Now static.
8321 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8322
de9c2632
PE
8323 * window.h (check_all_windows): Mark externally visible.
8324
2b96acb7
PE
8325 * window.c (window_deletion_count): Now static.
8326
8327 * undo.c: Make symbols static if they're not exported.
8328 (last_undo_buffer, last_boundary_position, pending_boundary):
8329 Now static.
8330
50436f33
PE
8331 * textprop.c (interval_insert_behind_hooks): Now static.
8332 (interval_insert_in_front_hooks): Likewise.
8333
64520e5c
PE
8334 * term.c: Make symbols static if they're not exported.
8335 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8336 (max_frame_lines, tty_set_terminal_modes):
8337 (tty_reset_terminal_modes, tty_turn_off_highlight):
8338 (get_tty_terminal): Now static.
8339 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8340 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8341 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8342 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8343 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8344
1fa53021
PE
8345 * sysdep.c: Make symbols static if they're not exported.
8346 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8347 Now static.
8348 (sigprocmask_set, full_mask): Remove; unused.
8349 (wait_debugging): Mark as visible.
8350 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8351 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8352
d4b43b22
PE
8353 * syntax.c (syntax_temp): Define only if !__GNUC__.
8354
b7c513d0
PE
8355 * sound.c (current_sound_device, current_sound): Now static.
8356
989b29ad
PE
8357 * search.c (searchbufs, searchbuf_head): Now static.
8358
13a55a78
PE
8359 * scroll.c (scroll_cost): Remove; unused.
8360 * dispextern.h (scroll_cost): Remove decl.
8361
de68a1fc
PE
8362 * region-cache.h (pp_cache): Mark as externally visible.
8363
40ccffa6
PE
8364 * process.c: Make symbols static if they're not exported.
8365 (process_tick, update_tick, create_process, chan_process):
8366 (Vprocess_alist, proc_buffered_char, datagram_access):
8367 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8368 (deactivate_process): Mark defn as static, as well as decl.
8369 * lisp.h (create_process): Remove decl.
8370 * process.h (chan_process, Vprocess_alist): Remove decls.
8371
ad64fc97
PE
8372 * print.c: Make symbols static if they're not exported.
8373 (print_depth, new_backquote_output, being_printed, print_buffer):
8374 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8375 (print_interval, print_number_index, initial_stderr_stream):
8376 Now static.
8377 * lisp.h (Fprinc): Remove decl.
8378 (debug_output_compilation_hack): Mark as externally visible.
8379
adddb265
PE
8380 * sysdep.c (croak): Move decl from here to syssignal.h.
8381 * syssignal.h (croak): Put it here, so the API can be checked when
8382 'croak' is called from dissociate_if_controlling_tty.
8383
1717ede2
PE
8384 * minibuf.c: Make symbols static if they're not exported.
8385 (minibuf_save_list, choose_minibuf_frame): Now static.
8386 * lisp.h (choose_minibuf_frame): Remove decl.
8387
fa5fb2bc
PE
8388 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8389
1e3890d1
PE
8390 * lread.c: Make symbols static if they're not exported.
8391 (read_objects, initial_obarray, oblookup_last_bucket_number):
8392 Now static.
8393 (make_symbol): Remove; unused.
8394 * lisp.h (initial_obarray, make_symbol): Remove decls.
8395
8a1414fa
PE
8396 * keyboard.c: Make symbols static if they're not exported.
8397 (single_kboard, recent_keys_index, total_keys, recent_keys):
8398 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8399 (this_single_command_key_start, echoing, last_auto_save):
8400 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8401 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8402 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8403 (Vlispy_mouse_stem, double_click_count):
8404 Now static.
8405 (force_auto_save_soon): Define only if SIGDANGER.
8406 (ignore_mouse_drag_p): Now static if
8407 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8408 (print_help): Remove; unused.
8409 (stop_character, last_timer_event): Mark as externally visible.
8410 * keyboard.h (ignore_mouse_drag_p): Declare only if
8411 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8412 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8413 * lisp.h (echoing): Remove decl.
8414 (force_auto_save_soon): Declare only if SIGDANGER.
8415 * xdisp.c (redisplay_window): Simplify code, to make it more
8416 obvious that ignore_mouse_drag_p is not accessed if !defined
8417 USE_GTK && !defined HAVE_NS.
8418
93ea6e8f
PE
8419 * intervals.c: Make symbols static if they're not exported.
8420 (merge_properties_sticky, merge_interval_right, delete_interval):
8421 Now static.
8422 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8423
77382fcc
PE
8424 * insdel.c: Make symbols static if they're not exported.
8425 However, leave prepare_to_modify_buffer alone. It's never
8426 called from outside this function, but that appears to be a bug.
8427 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8428 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8429 (adjust_after_replace_noundo): Remove; unused.
8430 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8431 (signal_before_change): Remove decls.
77382fcc 8432
9306c32e
PE
8433 * indent.c (val_compute_motion, val_vmotion): Now static.
8434
cd44d2eb
PE
8435 * image.c: Make symbols static if they're not exported.
8436 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8437 if USE_GTK.
8438 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8439 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8440
ad9a7a06
PE
8441 * fringe.c (standard_bitmaps): Now static.
8442 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8443
81626931
PE
8444 * frame.c: Make symbols static if they're not exported.
8445 (x_report_frame_params, make_terminal_frame): Now static.
8446 (get_frame_param): Now static, unless HAVE_NS.
8447 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8448 (x_get_resource_string): Remove; not used.
8449 * frame.h (make_terminal_frame, x_report_frame_params):
8450 (x_get_resource_string); Remove decls.
8451 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8452 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8453
239f9db9
PE
8454 * font.c, fontset.c: Make symbols static if they're not exported.
8455 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8456 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8457 * font.c (font_close_object): Now static.
8458 * font.h (font_close_object): Remove.
8459 * fontset.c (FONTSET_OBJLIST): Remove.
8460 (free_realized_fontset) #if-0 the body, which does nothing.
8461 (face_suitable_for_char_p): #if-0, as it's never called.
8462 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8463 * xfaces.c (face_at_string_position):
8464 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8465 since 0 is always ASCII.
8466
dfcf3579
PE
8467 * fns.c (weak_hash_tables): Now static.
8468
5045092b
PE
8469 * fileio.c: Make symbols static if they're not exported.
8470 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8471 (Vwrite_region_annotation_buffers): Now static.
8472
57a96f5c
PE
8473 * eval.c: Make symbols static if they're not exported.
8474 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8475 * lisp.h (backtrace_list): Remove decl.
8476
35f08c38
PE
8477 * emacs.c: Make symbols static if they're not exported.
8478 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8479 (fatal_error_code, fatal_error_signal_hook, standard_args):
8480 Now static.
8481 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8482 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8483 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8484 * lisp.h (fatal_error_signal_hook): Remove decl.
8485 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8486
f44bd759
PE
8487 * editfns.c: Move a (normally-unused) function to its only use.
8488 * editfns.c, lisp.h (get_operating_system_release): Remove.
8489 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8490 worth the hassle of breaking this out.
8491
b532497d
PE
8492 * xterm.c: Make symbols static if they're not exported.
8493 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8494 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8495 (x_destroy_window, x_delete_display):
8496 Now static.
8497 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8498 (x_mouse_leave): Remove; unused.
8499 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8500 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8501 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8502 Remove decls.
8503 (x_mouse_leave): Declare only if WINDOWSNT.
8504 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8505 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8506 USE_X_TOOLKIT.
8507
1675728f
PE
8508 * ftxfont.c: Make symbols static if they're not exported.
8509 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8510 HAVE_FREETYPE.
8511 * font.h (ftxfont_driver): Likewise.
8512
e4cebfca
PE
8513 * xfns.c: Make symbols static if they're not exported.
8514 (x_last_font_name, x_display_info_for_name):
8515 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8516 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8517 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8518 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8519 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8520 (last_show_tip_args): Now static.
8521 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8522 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8523 (x_screen_planes): Remove; unused.
8524 * dispextern.h (x_screen_planes): Remove decl.
8525
5bf46f05
PE
8526 * dispnew.c: Make symbols static if they're not exported.
8527 * dispextern.h (redraw_garbaged_frames, scrolling):
8528 (increment_row_positions): Remove.
8529 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8530 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8531 Now static.
8532 (redraw_garbaged_frames): Remove; unused.
8533
435f4c28
PE
8534 * xfaces.c: Make symbols static if they're not exported.
8535 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8536 Remove decls.
8537 * xterm.h (defined_color): Remove decls.
8538 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8539 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8540 (menu_face_changed_default, defined_color, free_realized_face):
8541 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8542 (ascii_face_of_lisp_face): Remove; unused.
8543
8524aef3
PE
8544 * xdisp.c: Make symbols static if they're not exported.
8545 * dispextern.h (scratch_glyph_row, window_box_edges):
8546 (glyph_to_pixel_coords, set_cursor_from_row):
8547 (get_next_display_element, set_iterator_to_next):
8548 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8549 (show_mouse_face): Remove decls
8550 * frame.h (message_buf_print): Likewise.
8551 * lisp.h (pop_message, set_message, check_point_in_composition):
8552 Likewise.
8553 * xterm.h (set_vertical_scroll_bar): Likewise.
8554 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8555 (message_buf_print, scratch_glyph_row, displayed_buffer):
8556 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8557 (get_next_display_element, show_mouse_face, window_box_edges):
8558 (frame_to_window_pixel_xy, check_point_in_composition):
8559 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8560 (glyph_to_pixel_coords): Remove; unused.
8561
16390cd2
PE
8562 * dired.c (file_name_completion): Now static.
8563
8564 * dbusbind.c (xd_in_read_queued_messages): Now static.
8565
a25f4dfa
PE
8566 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8567 * data.c (circular_list_error): Remove.
8568
14a9c8df
PE
8569 * commands.h (last_point_position, last_point_position_buffer):
8570 (last_point_position_window): Remove decls.
8571 * keyboard.c: Make these variables static.
8572
04f2d78b
CB
8573 * coding.h (coding, code_convert_region, encode_coding_gap):
8574 Remove decls.
74ab6df5
PE
8575 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8576 (iso_code_class, detect_coding, code_convert_region): Now static.
8577 (encode_coding_gap): Remove; unused.
8578
38dfbee1
PE
8579 * chartab.c (chartab_chars, chartab_bits): Now static.
8580
a2cb4e63
PE
8581 * charset.h (charset_iso_8859_1): Remove decl.
8582 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8583 Now static.
8584
127198fd
PE
8585 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8586 * ccl.c (Vccl_program_table): Now static.
8587 (check_ccl_update): Remove; unused.
8588
d85b608f
PE
8589 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8590 * category.h: ... from here.
8591 * category.c (check_category_table, set_category_set): Now static.
8592
31cd66f3
PE
8593 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8594 * lisp.h: Remove these decls.
8595
c358e587
PE
8596 * buffer.c (buffer_count): Remove unused var.
8597
e78aecca
PE
8598 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8599 so that it's not optimized away.
8600 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8601 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8602 exported only to the debugger.
8603
e192d7d3 8604 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8605 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8606
92470028
PE
8607 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8608 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8609 was inaccessible from Lisp.
8610 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8611 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8612
244ed907
PE
8613 alloc.c: Import and export fewer symbols, and remove unused items.
8614 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8615 is defined.
8616 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8617 it's not optimized away by whole-program optimization.
8618 (message_enable_multibyte, free_misc): Remove.
8619 (catchlist, handlerlist, mark_backtrace):
8620 Declare only if BYTE_MARK_STACK.
8621 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8622 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8623 (message_enable_multibyte): Remove decl.
8624 (free_misc, interval_free_list, float_block, float_block_index):
8625 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8626 (cons_free_list, last_marked_index):
8627 Now static.
8628 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8629 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8630 (mark_backtrace): Define only if BYTE_MARK_STACK.
8631 * xdisp.c (message_enable_multibyte): Now static.
8632
61c2b50e 8633 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8634 This makes it easier for human readers (and static analyzers)
8635 to see whether these variables are used from other modules.
8636 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8637 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8638 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8639 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8640 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8641 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8642 * xmenu.c, xselect.c:
8643 Declare Q* vars static if they are not used in other modules.
8644 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8645 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8646 Remove decls of unexported vars.
8647 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8648
95c82688
PE
8649 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8650
16a97296
PE
8651 Make Emacs functions such as Fatom 'static' by default.
8652 This makes it easier for human readers (and static analyzers)
8653 to see whether these functions can be called from other modules.
8654 DEFUN now defines a static function. To make the function external
8655 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8656 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8657 (Finit_image_library):
16a97296
PE
8658 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8659 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8660 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8661 Remove decls, since these functions are now static.
8662 (Funintern, Fget_internal_run_time): New decls, since these functions
8663 were already external.
95c82688 8664
16a97296
PE
8665 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8666 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8667 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8668 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8669 * keyboard.c, keymap.c, lread.c:
8670 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8671 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8672 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8673 Mark functions with DEFUE instead of DEFUN,
8674 if they are used in other modules.
8675 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8676 decls for now-static functions.
8677 * buffer.h (Fdelete_overlay): Remove decl.
8678 * callproc.c (Fgetenv_internal): Mark as internal.
8679 * composite.c (Fremove_list_of_text_properties): Remove decl.
8680 (Fcomposition_get_gstring): New forward static decl.
8681 * composite.h (Fcomposite_get_gstring): Remove decl.
8682 * dired.c (Ffile_attributes): New forward static decl.
8683 * doc.c (Fdocumntation_property): New forward static decl.
8684 * eval.c (Ffetch_bytecode): New forward static decl.
8685 (Funintern): Remove extern decl; now in .h file where it belongs.
8686 * fileio.c (Fmake_symbolic_link): New forward static decl.
8687 * image.c (Finit_image_library): New forward static decl.
8688 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8689 * intervals.h (Fprevious_property_change):
8690 (Fremove_list_of_text_properties): Remove decls.
8691 * keyboard.c (Fthis_command_keys): Remove decl.
8692 (Fcommand_execute): New forward static decl.
8693 * keymap.c (Flookup_key): New forward static decl.
8694 (Fcopy_keymap): Now static.
8695 * keymap.h (Flookup_key): Remove decl.
8696 * process.c (Fget_process): New forward static decl.
8697 (Fprocess_datagram_address): Mark as internal.
8698 * syntax.c (Fsyntax_table_p): New forward static decl.
8699 (skip_chars): Remove duplicate decl.
8700 * textprop.c (Fprevious_property_change): New forward static decl.
8701 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8702 Now internal.
8703 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8704 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8705
785bbd42
PE
8706 * editfns.c (Fformat): Remove unreachable code.
8707
8b913b57
AS
87082011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8709
8710 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8711 change. (Bug#8496)
8712
a6744a35
EZ
87132011-04-13 Eli Zaretskii <eliz@gnu.org>
8714
8715 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8716 when at ZV. (Bug#8487)
8717
e7974947
AS
87182011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8719
baad03f0
AS
8720 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8721 (Bug#8437)
8722 * keyboard.c (parse_tool_bar_item): Likewise.
8723 * sound.c (sound_cleanup, alsa_close): Likewise.
8724 * termcap.c (tgetent): Likewise.
8725 * xfns.c (x_default_font_parameter): Likewise.
8726 * xsettings.c (read_and_apply_settings): Likewise.
8727
e7974947
AS
8728 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8729 (overrun_check_free): Protoize.
8730
28272684
PE
87312011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8732
8733 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8734 since callers should never pass a negative size.
8735 Change the signature to match that of plain 'read' and 'write'; see
8736 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8737 * lisp.h: Update prototypes of emacs_write and emacs_read.
8738
11997c76
EZ
87392011-04-11 Eli Zaretskii <eliz@gnu.org>
8740
8741 * xdisp.c (redisplay_window): Don't try to determine the character
8742 position of the scroll margin if the window start point w->startp
e896f03c 8743 is outside the buffer's accessible region. (Bug#8468)
11997c76 8744
8a2cbd72
EZ
87452011-04-10 Eli Zaretskii <eliz@gnu.org>
8746
8747 Fix write-region and its subroutines for buffers > 2GB.
8748 * fileio.c (a_write, e_write): Modify declaration of arguments and
8749 local variables to support buffers larger than 2GB.
8750 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8751
8752 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8753 argument, local variables, and return value.
8754
8755 * lisp.h: Update prototypes of emacs_write and emacs_read.
8756
8757 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8758
4073e537 87592011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8760
1ebfdcb6
PE
8761 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8762
b2ded58d
PE
8763 Fix more problems found by GCC 4.6.0's static checks.
8764
7d66342c
PE
8765 * xdisp.c (vmessage): Use a better test for character truncation.
8766
bbf47d44
PE
8767 * charset.c (load_charset_map): <, not <=, for optimization,
8768 and to avoid potential problems with integer overflow.
9248994d 8769 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8770 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8771 * editfns.c (Fformat): Likewise.
1e69125e 8772 * syntax.c (skip_chars): Likewise.
3befa583 8773
e3019616
PE
8774 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8775 This also lets GCC 4.6.0 generate slightly better loop code.
8776
becfa255
PE
8777 * callint.c (Fcall_interactively): <, not <=, for optimization.
8778 (Fcall_interactively): Count the number of arguments produced,
8779 not the number of arguments given. This is simpler and lets GCC
8780 4.6.0 generate slightly better code.
8781
dae0cd48
PE
8782 * ftfont.c: Distingish more carefully between FcChar8 and char.
8783 The previous code passed unsigned char * to a functions like
8784 strlen and xstrcasecmp that expect char *, which does not
8785 conform to the C standard.
8786 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8787 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8788 char * when the C standard requires it.
8789
76032d70
PE
8790 * keyboard.c (read_char): Remove unused var.
8791
eb3f1cc8
PE
8792 * eval.c: Port to Windows vsnprintf (Bug#8435).
8793 Include <limits.h>.
8794 (SIZE_MAX): Define if the headers do not.
8795 (verror): Do not give up if vsnprintf returns a negative count.
8796 Instead, grow the buffer. This ports to Windows vsnprintf, which
8797 does not conform to C99. Problem reported by Eli Zaretskii.
8798 Also, simplify the allocation scheme, by avoiding the need for
8799 calling realloc, and removing the ALLOCATED variable.
8800
70476b54
PE
8801 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8802
12020a9e
PE
8803 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8804 But keep the doprint source code for now, as we might revamp it
8805 and use it again (Bug#8435).
ea6c7ae6
PE
8806 * lisp.h (doprnt): Remove.
8807 * Makefile.in (base_obj): Remove doprnt.o.
8808 * deps.mk (doprnt.o): Remove.
8809
5fdb398c
PE
8810 error: Print 32- and 64-bit integers portably (Bug#8435).
8811 Without this change, on typical 64-bit hosts error ("...%d...", N)
8812 was used to print both 32- and 64-bit integers N, which relied on
8813 undefined behavior.
61bdb816 8814 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8815 * lisp.h (error, verror): Mark as printf-like functions.
8816 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8817 Report overflow in size calculations when allocating printf buffer.
8818 Do not truncate output string at its first null byte.
8819 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8820 Truncate the output at a character boundary, since vsnprintf does not
8821 do that.
8822 * charset.c (check_iso_charset_parameter): Convert internal
8823 character to string before calling 'error', since %c now has the
8824 printf meaning.
8825 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8826 overflow when computing char to be passed to 'error'. Do not
8827 pass Lisp_Object to 'error'; pass the integer instead.
8828 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8829 formatted with plain %d.
8830
b189fa66
PE
8831 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8832
bff87ef0
PE
8833 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8834
7e2cac20
PE
8835 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8836
ce4d90b5
PE
8837 * xterm.c (x_catch_errors): Remove duplicate declaration.
8838
266c9547
PE
8839 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8840
79c49ad2
PE
8841 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8842
368f4090
JM
88432011-04-10 Jim Meyering <meyering@redhat.com>
8844
8845 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8846 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8847 return ssize_t not "int", and use size_t as the buffer length.
8848 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8849 * gnutls.h: Update declarations.
8850 * process.c (read_process_output): Use ssize_t, to match.
8851 (send_process): Likewise.
8852
a32d4040
CY
88532011-04-09 Chong Yidong <cyd@stupidchicken.com>
8854
8855 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8856
8546720e 88572011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8858
04f2d78b
CB
8859 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8860 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8861
8546720e
GM
8862 * xterm.c (handle_one_xevent):
8863 * xmenu.c (create_and_show_popup_menu):
8864 * xselect.c (x_decline_selection_request)
8865 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8866
0a2f5c1a 88672011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8868
8869 Fix some uses of `int' instead of EMACS_INT.
8870 * search.c (string_match_1, fast_string_match)
8871 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8872 (scan_buffer, find_next_newline_no_quit)
8873 (find_before_next_newline, search_command, Freplace_match)
8874 (Fmatch_data): Make some `int' variables be EMACS_INT.
8875
8876 * xdisp.c (display_count_lines): 3rd argument and return value now
8877 EMACS_INT. All callers changed.
8878 (pint2hrstr): Last argument is now EMACS_INT.
8879
8880 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8881 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8882 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8883 (decode_coding_utf_16, decode_coding_emacs_mule)
8884 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8885 (decode_coding_ccl, decode_coding_charset)
8886 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8887 (decode_coding_iso_2022, decode_coding_emacs_mule)
8888 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8889 <char_offset, last_offset>: Declare EMACS_INT.
8890 (encode_coding_utf_8, encode_coding_utf_16)
8891 (encode_coding_emacs_mule, encode_invocation_designation)
8892 (encode_designation_at_bol, encode_coding_iso_2022)
8893 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8894 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8895 Declare EMACS_INT.
8896 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8897 (encode_invocation_designation): Last argument P_NCHARS is now
8898 EMACS_INT.
8899 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8900 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8901
8902 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8903 All users changed.
8904
8905 * ccl.c (Fccl_execute_on_string): Declare some variables
8906 EMACS_INT.
8907
8546720e 89082011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8909
8910 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8911
4e19a977
CS
89122011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8913
8914 * process.c (Fformat_network_address): Doc fix.
8915
87302331
R
89162011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8917
ee7683eb 8918 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8919
cbb59342
CY
89202011-04-08 Chong Yidong <cyd@stupidchicken.com>
8921
8922 * keyboard.c (read_char): Call Lisp function help-form-show,
8923 instead of using internal_with_output_to_temp_buffer.
8924 (Qhelp_form_show): New var.
e0d38eeb 8925 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8926
8927 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8928
8929 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8930
e67a13ab
CY
89312011-04-06 Chong Yidong <cyd@stupidchicken.com>
8932
04f2d78b
CB
8933 * process.c (Flist_processes): Remove to Lisp.
8934 (list_processes_1): Delete.
e67a13ab 8935
973f782d
EZ
89362011-04-06 Eli Zaretskii <eliz@gnu.org>
8937
7c106b1e
EZ
8938 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8939
973f782d
EZ
8940 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8941
41cf7d1a 89422011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8943
ca23cc88
PE
8944 Fix more problems found by GCC 4.6.0's static checks.
8945
f390e2d5
PE
8946 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8947
42eea0d0
PE
8948 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8949
b69769da 8950 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8951
f9541e84
PE
8952 * xdisp.c (vmessage): Mark as a printf-like function.
8953
13841b55
PE
8954 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8955
c136c10f
PE
8956 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8957
5e2d4a30
PE
8958 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8959 printf-like functions.
8960 (tiff_load): Add casts to remove these marks before passing them
8961 to system-supplied API.
8962
583f48b9
PE
8963 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8964
b25d760e
PE
8965 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8966 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8967 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8968 directly, rather than having caller test rule sign. This avoids
8969 some unnecessary tests.
8970 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8971 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8972 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8973
bc7b6697 8974 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8975 (xfont_open): Avoid unnecessary tests.
bc7b6697 8976
27ccc379
PE
8977 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8978
dcd5c89a
PE
8979 * composite.h, composite.c (composition_gstring_put_cache):
8980 Use EMACS_INT, not int, for length.
8981
b13a45c6
PE
8982 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8983 breaking out part of COMPOSITION_DECODE_RULE.
8984 (COMPOSITION_DECODE_RULE): Use it.
8985 * composite.c (get_composition_id): Remove unused local vars,
8986 by using the new macro.
8987
1e792e4d
PE
8988 * textprop.c (set_text_properties_1): Change while to do-while,
8989 since the condition is always true at first.
8990
dc6c6455 8991 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8992 (interval_deletion_adjustment): Return unsigned value.
8993 All uses changed.
dc6c6455 8994
aba7731a
PE
8995 * process.c (list_processes_1, create_pty, read_process_output):
8996 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8997 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8998 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8999 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9000 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9001
fdfc4bf3
PE
9002 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9003
fca8fe46 9004 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9005 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9006
06a0259a 9007 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9008 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9009 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9010
e7b9e80f
PE
9011 * print.c (print_error_message): Avoid int overflow.
9012
56201685
PE
9013 * font.c (font_list_entities): Redo for clarity,
9014 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9015
78834453 9016 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9017 (font_score): Avoid potential overflow in diff calculation.
78834453 9018
0bc0b309 9019 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9020 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9021
e610eaca
PE
9022 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9023
b895abce
PE
9024 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9025 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9026 can always succeed if overflow has undefined behavior.
9027
1f1d9321 9028 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9029 (wordify): Omit three unnecessary tests.
1f1d9321 9030
c59478bc
PE
9031 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9032 All callers changed. This avoids the need for an unused var.
9033
79b73827
PE
9034 * casefiddle.c (casify_region): Remove var that is set but not used.
9035
a4db5dfe
PE
9036 * dired.c (file_name_completion): Remove var that is set but not used.
9037
43aae36e
PE
9038 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9039
2a47c44d 9040 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9041 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9042
a37c69bf
PE
9043 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9044 Check for integer overflow on size calculations.
9045
328ab8e7
PE
9046 * buffer.c (Fprevious_overlay_change): Remove var that is set
9047 but not used.
9048
e5a2a5cb
PE
9049 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9050 Remove vars that are set but not used.
8d84a6eb 9051 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9052 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9053
a60e5f68
PE
9054 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9055
f661cb61 9056 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9057 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9058
f0397f5a
PE
9059 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9060 that are set but not used.
9061
8664db06 9062 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9063 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9064
6abdaa4a
PE
9065 * xselect.c (x_get_local_selection, x_handle_property_notify):
9066 Remove vars that are set but not used.
9067
0ce7538d 9068 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9069 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9070
9ae848fc
PE
9071 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9072 Remove var that is set but not used.
0b918413
PE
9073 (scroll_bar_windows_size): Now size_t, not int.
9074 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9075 Check for overflow.
9ae848fc 9076
a5a62657
PE
9077 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9078 (map_tty_color) [!defined MSDOS]: Likewise.
9079
5c5cdd39
PE
9080 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9081
66ebf983
PE
9082 * coding.c: Remove vars that are set but not used.
9083 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9084 All callers changed.
9085 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9086 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9087 (decode_coding_charset): Remove vars that are set but not used.
9088
1be4d761
PE
9089 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9090 that is set but not used.
9091
47553fa8
PE
9092 * print.c (print_object): Remove var that is set but not used.
9093
1f7196bf 9094 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9095 The gnulib version avoids calling malloc in the usual case,
9096 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9097 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9098 * filelock.c (current_lock_owner): Likewise.
9099 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9100 * sysdep.c: Include allocator.h, careadlinkat.h.
9101 (emacs_no_realloc_allocator): New static constant.
9102 (emacs_readlink): New function.
fdb61804
PE
9103 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9104 ../lib/careadlinkat.h.
d1fdcab7 9105
f84c17c7
SM
91062011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9107
9108 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9109 first non-nil return value).
9110
ef3862ad
JD
91112011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9112
9113 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9114 if not defined (Bug#8403).
9115
376a7006
JB
91162011-04-02 Juanma Barranquero <lekktu@gmail.com>
9117
9118 * xdisp.c (display_count_lines): Remove parameter `start',
9119 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9120 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9121 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9122 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9123 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9124 and thereabouts. All callers changed.
9125 (get_per_char_metric): Remove parameter `f', unused since
9126 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9127
6ca3801d
JM
91282011-04-02 Jim Meyering <meyering@redhat.com>
9129
9130 do not dereference NULL upon failed strdup
9131 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9132 (ns_get_family): Likewise.
9133
d8e2b5ba
JB
91342011-04-02 Juanma Barranquero <lekktu@gmail.com>
9135
9136 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9137
8c74fcbd
JD
91382011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9139
9140 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9141 later (Bug#8403).
9142
7200d79c
SM
91432011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9144
03408648 9145 Add lexical binding.
7200d79c 9146
03408648
SM
9147 * window.c (Ftemp_output_buffer_show): New fun.
9148 (Fsave_window_excursion):
9149 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9150
9151 * lread.c (lisp_file_lexically_bound_p): New function.
9152 (Fload): Bind Qlexical_binding.
9153 (readevalloop): Remove `evalfun' arg.
9154 Bind Qinternal_interpreter_environment.
9155 (Feval_buffer): Bind Qlexical_binding.
9156 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9157 Mark as dynamic.
9158 (syms_of_lread): Declare `lexical-binding'.
9159
9160 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9161
9162 * keyboard.c (eval_dyn): New fun.
9163 (menu_item_eval_property): Use it.
ca105506
SM
9164
9165 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9166
03408648
SM
9167 * fns.c (concat, mapcar1): Accept byte-code-functions.
9168
9169 * eval.c (Fsetq): Handle lexical vars.
9170 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9171 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9172 (FletX, Flet): Obey lexical binding.
9173 (Fcommandp): Handle closures.
9174 (Feval): New `lexical' arg.
9175 (eval_sub): New function extracted from Feval. Use it almost
9176 everywhere where Feval was used. Look up vars in lexical env.
9177 Handle closures.
9178 (Ffunctionp): Move from subr.el.
9179 (Ffuncall): Handle closures.
9180 (apply_lambda): Remove `eval_flags'.
9181 (funcall_lambda): Handle closures and new byte-code-functions.
9182 (Fspecial_variable_p): New function.
9183 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9184 but without exporting it to Lisp.
23aba0ea 9185
23aba0ea 9186 * doc.c (Fdocumentation, store_function_docstring):
03408648 9187 * data.c (Finteractive_form): Handle closures.
23aba0ea 9188
03408648
SM
9189 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9190 interactive spec.
ba83908c 9191
04f2d78b
CB
9192 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9193 New byte-codes.
03408648
SM
9194 (exec_byte_code): New function extracted from Fbyte_code to handle new
9195 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9196
03408648 9197 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9198
03408648 9199 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9200
e2abce01
JB
92012011-03-31 Juanma Barranquero <lekktu@gmail.com>
9202
9203 * xdisp.c (redisplay_internal): Fix prototype.
9204
63696a73 92052011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9206
63696a73 9207 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9208 (try_scrolling): Use it when setting scroll_limit.
9209 Limit scrolling to 100 screen lines.
63696a73
EZ
9210 (redisplay_window): Even when falling back on "recentering",
9211 position point in the window according to scroll-conservatively,
9212 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9213
9214 (try_scrolling): When point is above the window, allow searching
9215 as far as scroll_max, or one screenful, to compute vertical
9216 distance from PT to the scroll margin position. This prevents
9217 try_scrolling from unnecessarily failing when
9218 scroll-conservatively is set to a value slightly larger than the
9219 window height. Clean up the case of PT below the margin at bottom
9220 of window: scroll_max can no longer be INT_MAX. When aggressive
9221 scrolling is in use, don't let point enter the opposite scroll
9222 margin as result of the scroll.
9223 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9224 threshold of 100 lines for never-recentering scrolling.
9225
e4cc2dfc
JB
92262011-03-31 Juanma Barranquero <lekktu@gmail.com>
9227
9228 * dispextern.h (move_it_by_lines):
9229 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9230 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9231 (message_log_check_duplicate): Remove parameters `prev_bol' and
9232 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9233 (redisplay_internal): Remove parameter `preserve_echo_area',
9234 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9235
9236 * indent.c (Fvertical_motion):
9237 * window.c (window_scroll_pixel_based, Frecenter):
9238 Don't pass `need_y_p' to `move_it_by_lines'.
9239
1c470562
SM
92402011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9241
44f230aa
SM
9242 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9243 steal a few bits to be more compact.
9244 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9245 Remove unneeded casts.
9246
1c470562
SM
9247 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9248
888adce9
ZK
92492011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9250
9251 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9252 binding" message (bug#7967).
9253
f838ed7b
PE
92542011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9255
77861b95
PE
9256 Fix more problems found by GCC 4.6.0's static checks.
9257
de6dbc14
PE
9258 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9259 Remove unused local var.
9260
f838ed7b
PE
9261 * editfns.c (Fmessage_box): Remove unused local var.
9262
792c7b2b
PE
9263 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9264 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9265 Omit unused local vars.
c499e557 9266 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9267 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9268 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9269 Omit unused local var.
9270
ba0165e1
PE
9271 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9272 Don't assume string length fits in int.
32ad8845 9273 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9274 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9275
3c59b4c9
PE
9276 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9277 instead of alloca (Bug#8344).
9278
a3eed478 9279 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9280 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9281
eb4d412d
PE
9282 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9283
1658b401
PE
9284 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9285 concerns.
9286
9287 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9288
9289 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9290
9a2c6e05
PE
9291 * keyboard.c (syms_of_keyboard): Use the same style as later
9292 in this function when indexing through an array. This also
9293 works around GCC bug 48267.
9294
03d0a109
PE
9295 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9296
44f730c8
PE
9297 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9298
fe75f926
PE
9299 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9300 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9301
ffa8c828
PE
9302 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9303 This avoids undefined behavior on integer overflow, and is a bit
9304 more convenient anyway since it is compared to a size_t variable.
9305
c5101a77
PE
9306 Variadic C functions now count arguments with size_t, not int.
9307 This avoids an unnecessary limitation on 64-bit machines, which
9308 caused (substring ...) to crash on large vectors (Bug#8344).
9309 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9310 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9311 All variadic functions and their callers changed accordingly.
c5101a77
PE
9312 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9313 * data.c (arith_driver, float_arith_driver): Likewise.
9314 * editfns.c (general_insert_function): Likewise.
9315 * eval.c (struct backtrace.nargs, interactive_p)
9316 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9317 (funcall_lambda, mark_backtrace): Likewise.
9318 * fns.c (concat): Likewise.
9319 * frame.c (x_set_frame_parameters): Likewise.
9320 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9321 0 if not found, not -1. All callers changed.
9322
dd3f25f7
PE
9323 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9324 (stack_copy_size): Now size_t, not int.
9325 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9326
461c2ab9
JB
93272011-03-28 Juanma Barranquero <lekktu@gmail.com>
9328
9329 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9330 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9331 All callers changed.
9332
9333 * lisp.h (multibyte_char_to_unibyte):
9334 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9335 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9336 * character.h (CHAR_TO_BYTE8):
9337 * cmds.c (internal_self_insert):
9338 * editfns.c (general_insert_function):
9339 * keymap.c (push_key_description):
9340 * search.c (Freplace_match):
9341 * xdisp.c (message_dolog, set_message_1): All callers changed.
9342
f6d62986
SM
93432011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9344
9345 * keyboard.c (safe_run_hook_funcall): New function.
9346 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9347 don't set the hook to nil, but remove the offending function instead.
9348 (Qcommand_hook_internal): Remove, unused.
9349 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9350 Vcommand_hook_internal.
9351
9352 * eval.c (enum run_hooks_condition): Remove.
9353 (funcall_nil, funcall_not): New functions.
9354 (run_hook_with_args): Call each function through a `funcall' argument.
9355 Remove `cond' argument, now redundant.
9356 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9357 (Frun_hook_with_args_until_failure): Adjust accordingly.
9358 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9359
1db5b1ad
JB
93602011-03-28 Juanma Barranquero <lekktu@gmail.com>
9361
9362 * dispextern.h (string_buffer_position): Remove declaration.
9363
9364 * print.c (strout): Remove parameter `multibyte', unused since
9365 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9366
9367 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9368 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9369 All callers changed.
9370
9371 * w32.c (_wsa_errlist): Use braces for struct initializers.
9372
9373 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9374 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9375 All callers changed.
9376 (string_buffer_position): Likewise. Also, make static (it's never
9377 used outside xdisp.c).
9378 (cursor_row_p): Remove parameter `w', unused since
9379 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9380 (decode_mode_spec): Remove parameter `precision', introduced during
9381 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9382 All callers changed.
9383
5ffb62aa
JD
93842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9385
9386 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9387
461c2ab9 93882011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9389
9390 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9391 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9392 (ns_update_auto_hide_menu_bar): New functions.
9393 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9394 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9395 ns_constrain_all_frames.
9396 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9397 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9398
5c380ffb
JD
93992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9400
9401 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9402
9af30bdf
GM
94032011-03-27 Glenn Morris <rgm@gnu.org>
9404
9405 * syssignal.h: Replace RETSIGTYPE with void.
9406 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9407 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9408 Replace SIGTYPE with void everywhere.
9409 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9410 * s/template.h (SIGTYPE): Remove commented out definition.
9411
e2abce01
JB
94122011-03-26 Eli Zaretskii <eliz@gnu.org>
9413
9414 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9415 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9416
f868cd8a
JB
94172011-03-26 Juanma Barranquero <lekktu@gmail.com>
9418
59eb0929
JB
9419 * w32.c (read_unc_volume): Use parameter `henum', instead of
9420 global variable `wget_enum_handle'.
9421
9422 * keymap.c (describe_vector): Remove parameters `indices' and
9423 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9424 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9425
f868cd8a
JB
9426 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9427
9428 * keyboard.c (timer_check): Remove parameter `do_it_now',
9429 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9430 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9431 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9432
9433 * keyboard.c (read_char):
9434 * w32menu.c (w32_menu_display_help):
9435 * xmenu.c (show_help_event, menu_help_callback):
9436 Adjust calls to `show_help_echo'.
9437
9438 * gtkutil.c (xg_maybe_add_timer):
9439 * keyboard.c (readable_events):
9440 * process.c (wait_reading_process_output):
9441 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9442
9443 * insdel.c (adjust_markers_gap_motion):
9444 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9445 (gap_left, gap_right): Don't call it.
9446
2ecf6fdb
CY
94472011-03-25 Chong Yidong <cyd@stupidchicken.com>
9448
9449 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9450 incurred during fontification.
9451
6b1f9ba4
JB
94522011-03-25 Juanma Barranquero <lekktu@gmail.com>
9453
9454 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9455 (DEFVAR_PER_BUFFER): Don't pass it.
9456
9457 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9458 (scrolling_window): Don't pass it.
9459
0f4a96b5
JB
94602011-03-25 Juanma Barranquero <lekktu@gmail.com>
9461
9462 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9463
9464 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9465 and `suffix'.
9466 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9467 of variables specific to SELinux and computation of `encoded_absname'.
9468
9469 * image.c (XPutPixel): Remove unused variable `height'.
9470
9471 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9472
9473 * unexw32.c (get_section_info): Remove unused variable `section'.
9474
9475 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9476 (system_process_attributes): Remove unused variable `sess'.
9477 (sys_read): Remove unused variable `err'.
9478
9479 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9480 (w32_wnd_proc): Remove unused variable `isdead'.
9481 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9482 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9483 (x_create_tip_frame): Remove unused variable `tem'.
9484
9485 * w32inevt.c (w32_console_read_socket):
9486 Remove unused variable `no_events'.
9487
9488 * w32term.c (x_draw_composite_glyph_string_foreground):
9489 Remove unused variable `width'.
9490
1149507c
JB
94912011-03-24 Juanma Barranquero <lekktu@gmail.com>
9492
9493 * w32term.c (x_set_glyph_string_clipping):
9494 Don't pass uninitialized region to CombineRgn.
9495
9c88f339
JB
94962011-03-23 Juanma Barranquero <lekktu@gmail.com>
9497
9498 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9499 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9500 (Fx_close_connection): Remove unused variable `i'.
9501
9502 * w32font.c (w32font_draw): Return number of glyphs.
9503 (w32font_open_internal): Remove unused variable `i'.
9504 (w32font_driver): Add missing initializer.
9505
9506 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9507 (fill_in_menu): Remove unused variable `items_added'.
9508
9509 * w32term.c (last_mouse_press_frame): Remove static global variable.
9510 (w32_clip_to_row): Remove unused variable `f'.
9511 (x_delete_terminal): Remove unused variable `i'.
9512
9513 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9514 (NOTHING): Remove unused static global variable.
9515 (uniscribe_check_otf): Remove unused variable `table'.
9516 (uniscribe_font_driver): Add missing initializers.
9517
dee091a3
JD
95182011-03-23 Julien Danjou <julien@danjou.info>
9519
9520 * term.c (Fsuspend_tty, Fresume_tty):
9521 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9522 * window.c (temp_output_buffer_show):
9523 * insdel.c (signal_before_change):
9524 * frame.c (Fhandle_switch_frame):
9525 * fileio.c (Fdo_auto_save):
9526 * emacs.c (Fkill_emacs):
9527 * editfns.c (save_excursion_restore):
9528 * cmds.c (internal_self_insert):
9529 * callint.c (Fcall_interactively):
9530 * buffer.c (Fkill_all_local_variables):
9531 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9532 Use Frun_hooks.
0f4a96b5 9533 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9534 unconditionally since it does the check itself.
dee091a3 9535
2c520ab5 95362011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9537
c9c49752
PE
9538 Fix more problems found by GCC 4.5.2's static checks.
9539
8abc3f12
PE
9540 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9541 the first time through the loop, since we know p0 < p1 then.
9542 This also avoids a gcc -Wstrict-overflow warning.
9543
a2d26660
PE
9544 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9545 leading to a memory leak, possible in functions like
9546 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9547 of objects (Bug#8318).
a2d26660 9548
916c72e9
PE
9549 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9550 that could (at least in theory) be that large.
9551
19ab8a18
PE
9552 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9553 This is less likely to overflow, and avoids undefined behavior if
9554 overflow does occur. All callers changed. Use strtoul to scan
9555 for the unsigned long integer.
b7cbbd6f
PE
9556 (pint2hrstr): Simplify and tune code slightly.
9557 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9558
f0641eff
PE
9559 * scroll.c (do_scrolling): Work around GCC bug 48228.
9560 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9561
7f650bb9
PE
9562 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9563 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9564 (validate_x_resource_name): Simplify count usage.
9565 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9566
37dd57d1
PE
9567 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9568 fail (Bug#8306).
81e56e61 9569
699979fc 9570 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9571
401bf9b4
PE
9572 * process.c (Fmake_network_process): Use socklen_t, not int,
9573 where POSIX says socklen_t is required in portable programs.
9574 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9575 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9576 (Fmake_network_process, server_accept_connection):
9577 (wait_reading_process_output, read_process_output):
9578 Likewise.
9579
b93aacde
PE
9580 * process.c: Rename or move locals to avoid shadowing.
9581 (list_processes_1, Fmake_network_process):
9582 (read_process_output_error_handler, exec_sentinel_error_handler):
9583 Rename or move locals.
4dc343ee 9584 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9585 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9586 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9587 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9588 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9589
af8a867c 9590 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9591 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9592 Include tparam.h instead, since it declares them.
af8a867c
PE
9593 * cm.h (PC): Remove extern decl; tparam.h now does this.
9594 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9595 * terminfo.c: Include tparam.h, to check interfaces.
9596 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9597 (tparam): Adjust signature to match interface in tparam.h;
9598 this removes some undefined behavior. Check that outstring and len
9599 are zero, which they always are with Emacs.
9600 * tparam.h (PC, BC, UP): New extern decls.
9601
0248044d 9602 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9603 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9604
8ff096c1 9605 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9606 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9607 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9608 (ftfont_list): Remove unused local.
49eaafba
PE
9609 (get_adstyle_property, ftfont_pattern_entity):
9610 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9611 Rename locals to avoid shadowing.
8ff096c1 9612
e2be39f6
PE
9613 * xfont.c (xfont_list_family): Mark var as initialized.
9614
c9735e30
PE
9615 * xml.c (make_dom): Now static.
9616
8f5201ae
PE
9617 * composite.c (composition_compute_stop_pos): Rename local to
9618 avoid shadowing.
b246f932
PE
9619 (composition_reseat_it): Remove unused locals.
9620 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9621 (composition_update_it): Mark var as initialized.
11b61122
PE
9622 (find_automatic_composition): Mark vars as initialized,
9623 with a FIXME (Bug#8290).
8f5201ae 9624
760fbc2c
PE
9625 character.h: Rename locals to avoid shadowing.
9626 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9627 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9628 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9629 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9630 to avoid shadowing.
9631
ff08eb85
PE
9632 * textprop.c (property_change_between_p): Remove; unused.
9633
fc7bf025
PE
9634 * intervals.c (interval_start_pos): Now static.
9635
235d7abc
PE
9636 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9637
44f230aa
SM
9638 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9639 Rename locals to avoid shadowing.
3e7d6594 9640
50060332
PE
9641 * sound.c (wav_play, au_play, Fplay_sound_internal):
9642 Fix pointer signedness.
d01f234b 9643 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9644 (wav_play): Initialize a variable to 0, to prevent undefined
9645 behavior (Bug#8278).
50060332 9646
c4fc4e30
PE
9647 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9648
918436ed
PE
9649 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9650
c939f91b
PE
9651 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9652 clobbering (Bug#8298).
b9c7f648
PE
9653 * sysdep.c (sys_subshell): Likewise.
9654 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9655
6bd8c144
PE
9656 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9657 This should get cleaned up, so that child_setup has the
9658 same signature on all platforms.
9659
7710357c 9660 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9661 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9662
c59da222
CY
96632011-03-22 Chong Yidong <cyd@stupidchicken.com>
9664
9665 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9666 not to be necessary, and produces flickering.
9667
66b87493
GM
96682011-03-20 Glenn Morris <rgm@gnu.org>
9669
9670 * config.in: Remove file.
9671
45b6f6d5
JB
96722011-03-20 Juanma Barranquero <lekktu@gmail.com>
9673
9674 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9675 are now in src/globals.h.
9676 (syms_of_minibuf): Remove spurious & from previous change.
9677
cd394be1 96782011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9679
9680 * minibuf.c (completing-read-function): New variable.
9681 (completing-read-default): Rename from completing-read.
9682 (completing-read): Call completing-read-function.
9683
b14e3e21
CY
96842011-03-19 Juanma Barranquero <lekktu@gmail.com>
9685
9686 * xfaces.c (Fx_load_color_file):
9687 Read color file from absolute filename (bug#8250).
9688
f2b726e6
JB
96892011-03-19 Juanma Barranquero <lekktu@gmail.com>
9690
9691 * makefile.w32-in: Update dependencies.
9692
09f6ff02
EZ
96932011-03-17 Eli Zaretskii <eliz@gnu.org>
9694
9695 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9696
29a6015a
PE
96972011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9698
a3a6c54e
PE
9699 Fix more problems found by GCC 4.5.2's static checks.
9700
b766f867
PE
9701 * process.c (make_serial_process_unwind, send_process_trap):
9702 (sigchld_handler): Now static.
9703
be02381c
PE
9704 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9705 That way, the code declares only the vars that it needs.
9706 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9707 * s/cygwin.h (PTY_ITERATION): Likewise.
9708 * s/darwin.h (PTY_ITERATION): Likewise.
9709 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9710
57048744
PE
9711 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9712 * process.c (allocate_pty): Don't declare stb unless it's needed.
9713
7914961c 9714 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9715 (CONSTANTLIM): Remove; unused.
9716 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9717 Define only if needed.
7914961c 9718
b3967b18
PE
9719 * unexelf.c (unexec): Name an expression,
9720 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9721 Use a different way to cause a compilation error if anyone uses
9722 n rather than nn, a way that does not involve shadowing.
73366a00 9723 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9724
29a6015a
PE
9725 * deps.mk (unexalpha.o): Remove; unused.
9726
43cfc33e 9727 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9728 * unexec.h: New file.
ce701a33
PE
9729 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9730 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9731 Depend on unexec.h.
9732 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9733 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9734 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9735 Change as necessary to match prototype in unexec.h.
ce701a33 9736
01f44d5a
PE
9737 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9738 shadowing.
4f63c6bb 9739 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9740
a6670b0b
PE
9741 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9742 Rename locals to avoid shadowing.
9743
cef2010d 9744 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9745 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9746
d4d7173a
PE
9747 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9748
f08b802a
PE
9749 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9750 warning when compiling print.c.
9751
3ddb0639
PE
9752 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9753 instead of using an uninitialized var.
5ad03b97 9754 (font_sort_entities): Mark var as initialized.
3ddb0639 9755
170a2692
PE
9756 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9757
e663c700
PE
9758 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9759 pointers to constants.
89bc529a 9760 (font_parse_fcname): Remove unused vars.
7b81e2d0 9761 (font_delete_unmatched): Now static.
ea838e10 9762 (font_get_spec): Remove; unused.
13a547c6
PE
9763 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9764 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9765 Rename or move locals to avoid shadowing.
e663c700 9766
2a80c887 9767 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9768 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9769
1384fa33 9770 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9771 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9772
8b2c52e9
PE
9773 * alloc.c (mark_backtrace): Move decl from here ...
9774 * lisp.h: ... to here, so that it can be checked.
9775
475545b5 9776 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9777 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9778 (lisp_indirect_variable): Name an expression,
9779 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9780 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9781
b1349114 9782 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9783 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9784 Use const pointer when appropriate.
b1349114 9785
a2928364
PE
9786 * lisp.h (get_system_name, get_operating_system_release):
9787 Move decls here, to check interfaces.
9788 * process.c (get_operating_system_release): Move decl to lisp.h.
9789 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9790 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9791 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9792 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9793 (Fformat_time_string, Fencode_time, Finsert_char):
9794 (Ftranslate_region_internal, Fformat):
9795 Rename or remove local vars to avoid shadowing.
9710023e 9796 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9797
a415e694
PE
9798 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9799 avoid shadowing.
9800
8ef4622d
PE
9801 * lisp.h (eassert): Check that the argument compiles, even if
9802 ENABLE_CHECKING is not defined.
9803
946f9a5b
PE
9804 * data.c (Findirect_variable): Name an expression, to avoid
9805 gcc -Wbad-function-cast warning.
112396d6 9806 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9807 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9808 (Fmake_variable_buffer_local, Fmake_local_variable):
9809 Mark variables as initialized.
52746918 9810 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9811
e5aab7e7 9812 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9813 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9814 Rename locals to avoid shadowing.
dff45157
PE
9815 (mark_stack): Move local variables into the #ifdef region where
9816 they're used.
7bc26fdb
PE
9817 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9818 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9819 needed otherwise.
9820 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9821 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9822 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9823
e5aab7e7
PE
9824 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9825 avoids undefined behavior in theory.
9826
4da60324
PE
9827 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9828
88043301
PE
9829 Use functions, not macros, for up- and down-casing (Bug#8254).
9830 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9831 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9832 to use the following functions instead of these macros.
9833 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9834 EMACS_INT, since callers assume the returned value fits in int.
9835 (upcase1): Likewise, for UPCASE_TABLE.
9836 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9837 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9838 the race-condition problem in the old DOWNCASE.
88043301 9839
19ed5445
PE
9840 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9841 Rename locals to avoid shadowing.
9842 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9843 (regex_compile, re_search_2, re_match_2_internal):
9844 Remove unused local vars.
952db0d7
PE
9845 (FREE_VAR): Rewrite so as not to use empty "else",
9846 which gcc can warn about.
da053e48 9847 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9848 (RETALLOC_IF): Define only if needed.
9849 (WORDCHAR_P): Likewise. This one is never needed, but is used
9850 only in a comment talking about a compiler bug, so put inside
9851 the #if 0 of that comment.
9852 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9853 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9854 Remove; unused.
19ed5445 9855
1f3561e4 9856 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9857 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9858 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9859
ded6f8f7
PE
9860 * search.c (simple_search): Remove unused var.
9861
dbd37a95
PE
9862 * dired.c (compile_pattern): Move decl from here ...
9863 * lisp.h: ... to here, so that it can be checked.
9864 (struct re_registers): New forward decl.
9865
7e47afad
PE
9866 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9867
85f24f61
PE
9868 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9869 All uses changed.
9870 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9871 Rename locals to avoid shadowing.
5671df8f 9872 (Fvertical_motion): Mark locals as initialized.
85f24f61 9873
181aa2be 9874 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9875 (casify_region): Mark local as initialized.
181aa2be 9876
930d429c
PE
9877 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9878
7082eac6
PE
9879 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9880 New macros, so that the caller can use some names other than
9881 gcpro1, gcpro2, etc.
9882 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9883 of the new macros.
9884 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9885 argument, for consistency with GCPRO2_VAR, etc: it is now the
9886 prefix of the variable, not the variable itself. All uses
9887 changed.
38b2c076
PE
9888 * dired.c (directory_files_internal, file_name_completion):
9889 Rename locals to avoid shadowing.
9890
15206ed9
PE
9891 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9892 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9893 dired.c's scmp function, had undefined behavior.
9894 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9895 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9896 * buffer.h: ... to here, because these macros use current_buffer,
9897 and the new implementation with inline functions needs to have
9898 current_buffer in scope now, rather than later when the macros
9899 are used.
9900 (downcase, upcase1): New static inline functions.
9901 (DOWNCASE, UPCASE1): Reimplement using these functions.
9902 This avoids undefined behavior in expressions like
9903 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9904 from race conditions in accessing the global variables
9905 case_temp1 and case_temp2.
9906 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9907 * lisp.h (case_temp1, case_temp2): Remove their decls.
9908 * character.h (ASCII_CHAR_P): Move from here ...
9909 * lisp.h: ... to here, so that the inline functions mentioned
9910 above can use them.
9911
4a6bea26
PE
9912 * dired.c (directory_files_internal_unwind): Now static.
9913
f14b7e14
PE
9914 * fileio.c (file_name_as_directory, directory_file_name):
9915 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9916 Now static.
2893f146
PE
9917 (file_name_as_directory): Use const pointers when appropriate.
9918 (Fexpand_file_name): Likewise. In particular, newdir might
9919 point at constant storage, so make it a const pointer.
fd4ead52 9920 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9921 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9922 signedness issues.
f839df0c
PE
9923 (Fset_file_times, Finsert_file_contents, auto_save_error):
9924 Rename locals to avoid shadowing.
f14b7e14 9925
5716756e 9926 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9927 (Ftry_completion, Fall_completions): Rename or remove locals
9928 to avoid shadowing.
5716756e 9929
b4c3046a
PE
9930 * marker.c (bytepos_to_charpos): Remove; unused.
9931
b45db522
PE
9932 * lisp.h (verify_bytepos, count_markers): New decls,
9933 so that gcc does not warn that these functions aren't declared.
9934
85876d07
PE
9935 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9936 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9937 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9938 (copy_text): Remove unused local var.
85876d07 9939
03d78a21 9940 * filelock.c (within_one_second): Now static.
b3dd38ab 9941 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9942
5df8f01b
PE
9943 * buffer.c (fix_overlays_before): Mark locals as initialized.
9944 (fix_start_end_in_overlays): Likewise. This function should be
9945 simplified by using pointers-to-pointers, but that's a different
9946 matter.
b1d876f1 9947 (switch_to_buffer_1): Now static.
8f54f30a
PE
9948 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9949 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9950
a70072c9 9951 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9952 Fix pointer signedness issue.
edced198
PE
9953 (sys_subshell): Mark local as volatile if checking for lint,
9954 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9955 (MAXPATHLEN): Define only if needed.
a70072c9 9956
a0977c44
PE
9957 * process.c (serial_open, serial_configure): Move decls from here ...
9958 * systty.h: ... to here, so that they can be checked.
9959
a884fdcc
PE
9960 * fns.c (get_random, seed_random): Move extern decls from here ...
9961 * lisp.h: ... to here, so that they can be checked.
9962
604efe86 9963 * sysdep.c (reset_io): Now static.
b8950c94 9964 (wait_for_termination_signal): Remove; unused.
604efe86 9965
38fc62d9
PE
9966 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9967 (copy_keymap_item, append_key, push_text_char_description):
9968 Now static.
1004a21a 9969 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9970 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9971 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9972 (describe_map_tree):
9973 Rename locals to avoid shadowing.
38fc62d9 9974
2f2650da
PE
9975 * keyboard.c: Declare functions static if they are not used elsewhere.
9976 (echo_char, echo_dash, cmd_error, top_level_2):
9977 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9978 (read_char, kbd_buffer_get_event, make_lispy_position):
9979 (make_lispy_event, make_lispy_movement, apply_modifiers):
9980 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9981 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9982 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9983 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9984 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9985
a053e86c 9986 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9987 (mark_kboards): Move decl here ...
9988 * alloc.c (mark_kboards): ... from here.
a053e86c 9989
4752793e
PE
9990 * lisp.h (force_auto_save_soon): New decl.
9991
74f10ca7 9992 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9993 (DEFINE_DUMMY_FUNCTION): New macro.
9994 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9995 Use it.
c03cd23f
PE
9996 (main): Add casts to avoid warnings
9997 if GCC considers string literals to be constants.
74f10ca7 9998
022e70d4
PE
9999 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10000
59d6fe83
PE
10001 * dbusbind.c: Pointer signedness fixes.
10002 (xd_signature, xd_append_arg, xd_initialize):
10003 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10004 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10005 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10006 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10007
78320123
PE
10008 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10009 if GCC considers string literals to be constants.
49cebcca 10010 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10011
35ac2a97
SM
100122011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10013
fb103ca9
SM
10014 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10015 (print_preprocess, print_object): New macro to fix last change.
10016
35ac2a97
SM
10017 * print.c (print_preprocess): Don't forget font objects.
10018
62973b41
JB
100192011-03-16 Juanma Barranquero <lekktu@gmail.com>
10020
10021 * emacs.c (USAGE3): Doc fixes.
10022
0e48bb22
AS
100232011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10024
10025 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10026 structure.
10027
7684e57b
JB
100282011-03-14 Juanma Barranquero <lekktu@gmail.com>
10029
10030 * lisp.h (VWindow_system, Qfile_name_history):
10031 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10032 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10033 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10034
10035 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10036 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10037
10038 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10039 * w32console.c (detect_input_pending, read_input_pending)
10040 (encode_terminal_code):
10041 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10042 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10043 (w32_system_caret_y, Qfile_name_history):
10044 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10045 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10046 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10047 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10048 * w32proc.c (Qlocal, report_file_error):
10049 * w32term.c (Vwindow_system, updating_frame):
10050 * w32uniscribe.c (initialized, uniscribe_font_driver):
10051 Remove unneeded extern declarations.
10052
2aa46d6c
CY
100532011-03-14 Chong Yidong <cyd@stupidchicken.com>
10054
c96bbc66 10055 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10056
cffc6f3b
CY
100572011-03-13 Chong Yidong <cyd@stupidchicken.com>
10058
10059 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10060 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10061 These macros can no longer be used for assignment.
10062
44f230aa
SM
10063 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10064 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10065 (record_buffer_markers, fetch_buffer_markers): New functions for
10066 recording and fetching special buffer markers.
10067 (set_buffer_internal_1, set_buffer_temp): Use them.
10068
10069 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10070
10071 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10072
10073 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10074 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10075
10076 * xdisp.c (hscroll_window_tree):
10077 (reconsider_clip_changes): Use PT instead of BUF_PT.
10078
d251f04b
EZ
100792011-03-13 Eli Zaretskii <eliz@gnu.org>
10080
10081 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10082 $(EMACS_ROOT)/lib/intprops.h.
10083
f0c77cd1
PE
100842011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10085
3eca4629
PE
10086 Fix more problems found by GCC 4.5.2's static checks.
10087
7c86ee98
PE
10088 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10089 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10090 (xg_free_frame_widgets): Make it clear that a local variable is
10091 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10092 (gdk_window_get_screen): Make it clear that this macro is needed
10093 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10094 (int_gtk_range_get_value): New function, which avoids a diagnostic
10095 from gcc -Wbad-function-cast.
10096 (xg_set_toolkit_scroll_bar_thumb): Use it.
10097 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10098 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10099 (get_utf8_string, xg_get_file_with_chooser):
10100 Rename locals to avoid shadowing.
10101 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10102
41729b81
PE
10103 * xgselect.c (xg_select): Remove unused var.
10104
f0c77cd1
PE
10105 * image.c (four_corners_best): Mark locals as initialized.
10106 (gif_load): Initialize transparent_p to zero (Bug#8238).
10107 Mark another local as initialized.
ec6cf4c6 10108 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 10109
ce0ad53d 10110 * image.c (clear_image_cache): Now static.
d5d5a617 10111 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10112 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10113 (x_edge_detection): Remove unnecessary cast that
10114 gcc -Wbad-function-cast diagnoses.
2037898d 10115 (gif_load): Fix pointer signedness.
6ae141d6
PE
10116 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10117 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10118
33383987 101192011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10120
d32df629
PE
10121 Improve quality of tests for time stamp overflow.
10122 For example, without this patch (encode-time 0 0 0 1 1
10123 1152921504606846976) returns the obviously-bogus value (-948597
10124 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10125 reports time overflow. See
10126 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10127 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10128 * editfns.c: Include limits.h and intprops.h.
10129 (TIME_T_MIN, TIME_T_MAX): New macros.
10130 (time_overflow): Move earlier, to before first use.
10131 (hi_time, lo_time): New functions, for an accurate test for
10132 out-of-range times.
10133 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10134 (Fget_internal_run_time): Don't assume time_t fits in int.
10135 (make_time): Use list2 instead of Fcons twice.
10136 (Fdecode_time): More accurate test for out-of-range times.
10137 (check_tm_member): New function.
10138 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10139 (lisp_time_argument): Don't rely on undefined left-shift and
10140 right-shift behavior when checking for time stamp overflow.
8be6f318 10141
fe31d94c
PE
10142 * editfns.c (time_overflow): New function, refactoring common code.
10143 (Fformat_time_string, Fdecode_time, Fencode_time):
10144 (Fcurrent_time_string): Use it.
10145
8be6f318
PE
10146 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10147 * dired.c (make_time): Move to ...
10148 * editfns.c (make_time): ... here.
10149 * systime.h: Note the move.
10150
09d9db2c 101512011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10152
126bc0dc
YM
10153 * fringe.c (update_window_fringes): Remove unused variables.
10154
c47cbdfd
YM
10155 * unexmacosx.c (copy_data_segment): Also copy __got section.
10156 (Bug#8223)
10157
7ac80be9
EZ
101582011-03-12 Eli Zaretskii <eliz@gnu.org>
10159
c96bbc66 10160 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10161 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10162 Constify `char *' arguments and their references according to
10163 prototypes in tparam.h.
10164
ecb0f94d 10165 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10166
7ac80be9
EZ
10167 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10168 Adapt all references accordingly.
10169
10170 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10171
ef1fd07e
TT
101722011-03-11 Tom Tromey <tromey@redhat.com>
10173
10174 * buffer.c (syms_of_buffer): Remove obsolete comment.
10175
7ef4b50c
EZ
101762011-03-11 Eli Zaretskii <eliz@gnu.org>
10177
10178 * termhooks.h (encode_terminal_code): Declare prototype.
10179
10180 * msdos.c (encode_terminal_code): Don't declare prototype.
10181
10182 * term.c (encode_terminal_code): Now external again, used by
10183 w32console.c and msdos.c.
10184
44f230aa
SM
10185 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10186 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10187
4b1ec863 101882011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10189
1714f52b 10190 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10191
4b1ec863
PE
10192 * fringe.c (update_window_fringes): Mark locals as initialized
10193 (Bug#8227).
10194 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10195
524c7aa6
PE
10196 * alloc.c (mark_fringe_data): Move decl from here ...
10197 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10198 to check its interface.
10199 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10200
a5c0af81 10201 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10202 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10203 (fontset_font): Mark local as initialized.
a9a06e0b 10204 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10205
b4716021
PE
10206 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10207
811e9bac 10208 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10209 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10210 (x_own_selection, Fx_disown_selection_internal): Rename locals
10211 to avoid shadowing.
10212 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10213
7e3ab302
PE
10214 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10215 so that the caller can use some name other than gcpro1.
10216 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10217 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10218 (Fx_backspace_delete_keys_p):
10219 Use them to avoid shadowing, and rename vars to avoid shadowing.
10220 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10221 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10222 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10223 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10224 Remove unused locals.
7e3ab302
PE
10225 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10226 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10227 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10228 macros.
f78faa98 10229
e2b13473
PE
10230 * xterm.h (x_mouse_leave): New decl.
10231
77f23912
PE
10232 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10233 Remove unused functions.
cdf4ba58
PE
10234 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10235 (x_calc_absolute_position): Now static.
7411c686 10236 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10237 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10238 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10239 unless they are used.
38d0b34a
PE
10240 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10241 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10242 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10243 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10244 (x_error_catcher, x_connection_closed, x_error_handler):
10245 (x_error_quitter, xembed_send_message, x_iconify_frame):
10246 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10247 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10248 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10249
44f230aa
SM
10250 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10251 Rename or move locals to avoid shadowing.
6b463e58 10252 (tty_defined_color, merge_face_heights): Now static.
5967d051 10253 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10254 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10255 does not deduce is never used uninitialized.
73719eba
PE
10256 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10257 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10258
426994c3 10259 * terminal.c (store_terminal_param): Now static.
5489860b 10260
032f1620 10261 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10262 (set_frame_menubar): Remove unused local.
d4323972 10263 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10264 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10265 since they might point to immutable storage.
281585b0
PE
10266 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10267 since it's unused otherwise.
032f1620 10268
367c19e5 10269 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10270 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10271 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10272 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10273 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10274 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10275 does not deduce are never used uninitialized.
70739cbe 10276
07b48fa9
PE
10277 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10278
8868a238 10279 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10280 * window.c (window_loop, size_window):
10281 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10282
7e5cf297 10283 * window.c (display_buffer): Now static.
d6550a9f
PE
10284 (size_window): Mark variables that gcc -Wuninitialized
10285 does not deduce are never used uninitialized.
a586633d
PE
10286 * window.h (check_all_windows): New decl, to forestall
10287 gcc -Wmissing-prototypes diagnostic.
5b555da1 10288 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10289
f6095868
PE
10290 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10291 shadowing.
10292 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10293 Include <limits.h>.
10294 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10295 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10296 (load_charset_map): Mark variables that gcc -Wuninitialized
10297 does not deduce are never used uninitialized.
53df7c11 10298 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10299
f38b440c
PE
10300 * coding.c (coding_set_source, coding_set_destination):
10301 Use "else { /* comment */ }" rather than "else /* comment */;"
10302 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10303 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10304 a block, when the outer 'i' will do.
10305 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10306 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10307 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10308 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10309 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10310 Rename locals to avoid shadowing.
10311 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10312 * coding.c (emacs_mule_char, encode_invocation_designation):
10313 Now static, since they're not used elsewhere.
413bb2db 10314 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10315 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10316 (decode_coding_emacs_mule): Mark variables that gcc
10317 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10318 (detect_coding_iso_2022): Initialize a local variable that might
10319 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10320 this initialization is needed. (Bug#8211)
5f58e762
PE
10321 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10322 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10323 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10324 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10325 Remove unused macros.
f38b440c 10326
232b38b9 10327 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10328 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10329 * character.c (string_count_byte8): Likewise.
232b38b9 10330
fb90da1b
PE
10331 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10332 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10333
fb93dbc2
PE
10334 * chartab.c (copy_sub_char_table): Now static, since it's not used
10335 elsewhere.
5c156ace
PE
10336 (sub_char_table_ref_and_range, char_table_ref_and_range):
10337 Rename locals to avoid shadowing.
bbcd0949 10338 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10339
7d3b3862 10340 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10341 (BIDI_BOB): Remove unused macro.
7d3b3862 10342
6be7d3da
PE
10343 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10344 deduce are never used uninitialized.
c2ed9c8b 10345 * term.c (encode_terminal_code): Likewise.
6be7d3da 10346
75f8807f 10347 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10348
50938595
PE
10349 * tparam.h: New file.
10350 * term.c, tparam.h: Include it.
10351 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10352 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10353 Move these decls to tparam.h, and make them agree with what
10354 is actually in tparam.c. The previous trick of using incompatible
10355 decls in different modules does not conform to the C standard.
10356 All callers of tparam changed to use tparam's actual API.
10357 * tparam.c (tparam1, tparam, tgoto):
10358 Use const pointers where appropriate.
10359
fbceeba2
PE
10360 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10361 * cm.h (struct cm): Likewise.
10362 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10363 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10364 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10365 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10366 (turn_on_face, init_tty): Likewise.
10367 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10368
7f3f1250
PE
10369 * term.c (term_mouse_position): Rename local to avoid shadowing.
10370
e6ca6543
PE
10371 * alloc.c (mark_ttys): Move decl from here ...
10372 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10373
c40f8d15
AS
103742011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10375
10376 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10377
cfe0661d
JB
103782011-03-09 Juanma Barranquero <lekktu@gmail.com>
10379
10380 * search.c (compile_pattern_1): Remove argument regp, unused since
10381 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10382 (compile_pattern): Don't pass it.
10383
0afb4571
J
103842011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10385
10386 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10387 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10388 for ! HAVE_GTK3.
10389 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10390
10391 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10392
10393 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10394 gdk_window_get_screen, gdk_window_get_geometry,
10395 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10396 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10397 (xg_get_pixbuf_from_pixmap): New function.
10398 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10399 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10400 Call xg_get_pixbuf_from_pixmap instead of
10401 gdk_pixbuf_get_from_drawable.
10402 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10403 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10404 (xg_check_special_colors): Use GtkStyleContext and its functions
10405 for HAVE_GTK3.
10406 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10407 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10408 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10409 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10410 Call gtk_widget_get_preferred_size.
0afb4571
J
10411 (xg_frame_resized): gdk_window_get_geometry only takes 5
10412 parameters.
44f230aa
SM
10413 (xg_win_to_widget, xg_event_is_for_menubar):
10414 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10415 (xg_set_widget_bg): New function.
10416 (delete_cb): New function.
895009e1 10417 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10418 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10419 (xg_set_background_color): Call xg_set_widget_bg.
10420 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10421 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10422 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10423 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10424 if ! HAVE_GTK3.
10425 (update_frame_tool_bar): Call gtk_widget_hide.
10426 (xg_initialize): Use GDK_KEY_g.
10427
10428 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10429 if ! HAVE_GTK3
10430 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10431
10432 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10433 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10434 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10435
1c2cc4ef
JB
104362011-03-08 Juanma Barranquero <lekktu@gmail.com>
10437
10438 * w32xfns.c (select_palette): Check success of RealizePalette against
10439 GDI_ERROR, not zero.
10440
33383987 10441See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10442
10443;; Local Variables:
10444;; coding: utf-8
aac0c6e3
MR
10445;; End:
10446
2f097256 10447 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10448
10449 This file is part of GNU Emacs.
10450
10451 GNU Emacs is free software: you can redistribute it and/or modify
10452 it under the terms of the GNU General Public License as published by
10453 the Free Software Foundation, either version 3 of the License, or
10454 (at your option) any later version.
10455
10456 GNU Emacs is distributed in the hope that it will be useful,
10457 but WITHOUT ANY WARRANTY; without even the implied warranty of
10458 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10459 GNU General Public License for more details.
10460
10461 You should have received a copy of the GNU General Public License
10462 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.