* xterm.c: don't go over XClientMessageEvent limit
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b1f367f7 12011-07-17 Paul Eggert <eggert@cs.ucla.edu>
13464394 2
50849c52
PE
3 * xterm.c: don't go over XClientMessageEvent limit
4 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5 (x_send_scroll_bar_event): Likewise. Check that the size does not
6 exceed limits imposed by XClientMessageEvent, as well as the usual
7 ptrdiff_t and size_t limits.
8
b13995db
PE
9 * keyboard.c: Overflow, signedness and related fixes.
10 (make_lispy_movement): Use same integer type in forward decl
11 that is used in the definition.
12 (read_key_sequence, keyremap_step):
13 Change bufsize argument back to int, undoing my 2011-03-30 change.
14 We prefer signed types, and int is wide enough here.
15 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
16 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
17 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
18 length, not size_t. Use ptrdiff_t for index, not int.
19 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
20 possibility of integer overflow.
21
13464394
PE
22 Overflow, signedness and related fixes for images.
23
24 * dispextern.h (struct it.stack[0].u.image.image_id)
25 (struct_it.image_id, struct image.id, struct image_cache.size)
26 (struct image_cache.used, struct image_cache.ref_count):
27 * gtkutil.c (update_frame_tool_bar):
28 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
29 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
30 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
31 * nsmenu.m (update_frame_tool_bar):
32 * xdisp.c (calc_pixel_width_or_height):
33 * xfns.c (image_cache_refcount):
34 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
35 on typical 64-bit hosts.
36
37 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
38 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
39 Omit unnecessary casts to int.
40 (parse_image_spec): Check that integers fall into 'int' range
41 when the callers expect that.
42 (image_ascent): Redo ascent calculation to avoid int overflow.
43 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
44 (lookup_image): Remove unnecessary tests.
45 (xbm_image_p): Locals are now of int, not EMACS_INT,
46 since parse_image_check makes sure they fit into int.
47 (png_load, gif_load, svg_load_image):
48 Prefer int to unsigned where either will do.
49 (tiff_handler): New function, combining the cores of the
50 old tiff_error_handler and tiff_warning_handler. This
51 function is rewritten to use vsnprintf and thereby avoid
52 stack buffer overflows. It uses only the features of vsnprintf
53 that are common to both POSIX and native Microsoft.
54 (tiff_error_handler, tiff_warning_handler): Use it.
55 (tiff_load, gif_load, imagemagick_load_image):
56 Don't assume :index value fits in 'int'.
57 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
58 (imagemagick_load_image): Check that crop parameters fit into
59 the integer types that MagickCropImage accepts. Don't assume
60 Vimagemagick_render_type has a nonnegative value. Don't assume
61 size_t fits in 'long'.
62 (gs_load): Use printmax_t to print the widest integers possible.
63 Check for integer overflow when computing image height and width.
64
4f8a4547 652011-07-17 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 66
41f55ccd 67 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 68
39e378da
PE
69 * bidi.c: Integer size and overflow fixes.
70 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
71 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
72 (bidi_cache_find_level_change, bidi_cache_ensure_space)
73 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
74 (bidi_find_other_level_edge):
75 Use ptrdiff_t instead of EMACS_INT where either will do.
76 This works better on 32-bit hosts configured --with-wide-int.
77 (bidi_cache_ensure_space): Check for size-calculation overflow.
78 Use % rather than repeated addition, for better worst-case speed.
79 Don't set bidi_cache_size until after xrealloc returns, because it
80 might not return.
81 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
82 (bidi_cache_ensure_space): Also check that the bidi cache size
83 does not exceed that of the largest Lisp string or buffer. See Eli
84 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 85
5e927815
PE
86 * alloc.c (__malloc_size_t): Remove.
87 All uses replaced by size_t. See Andreas Schwab's note
88 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
89
ca4aa935
PE
90 * image.c: Improve checking for integer overflow.
91 (check_image_size): Assume that f is nonnull, since
92 it is always nonnull in practice. This is one less thing to
93 worry about when checking for integer overflow later.
94 (x_check_image_size): New function, which checks for integer
95 overflow issues inside X.
96 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
97 This removes the need for a memory_full check.
98 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
99 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
100 (xbm_read_bitmap_data): Change locals back to 'int', since
101 their values must fit in 'int'.
102 (xpm_load_image, png_load, tiff_load):
103 Invoke x_create_x_image_and_pixmap earlier,
104 to avoid much needless work if the image is too large.
105 (tiff_load): Treat overly large images as if
106 x_create_x_image_and_pixmap failed, not as malloc failures.
107 (gs_load): Use x_check_image_size.
108
5f8f9cc2
PE
109 * gtkutil.c: Omit integer casts.
110 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
111 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
112
5adf60bc
PE
113 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
114
c8907a93
PE
115 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
116 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
117 would wrongly return t on a 64-bit host.
118
e3c25c68
PE
119 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
120 The plain *_OVERFLOW macros run afoul of GCC bug 49705
121 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
122 and therefore cause GCC to emit a bogus diagnostic in some cases.
123
3f791afe
PE
124 * image.c: Integer signedness and overflow and related fixes.
125 This is not an exhaustive set of fixes, but it's time to
126 record what I've got.
127 (lookup_pixel_color, check_image_size): Remove redundant decls.
128 (check_image_size): Don't assume that arbitrary EMACS_INT values
129 fit in 'int', or that arbitrary 'double' values fit in 'int'.
130 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
131 (tiff_load, imagemagick_load_image):
132 Check for overflow in size calculations.
133 (x_create_x_image_and_pixmap): Remove unnecessary test for
134 xmalloc returning NULL; that can't happen.
135 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
136 (xpm_color_bucket): Use better integer hashing function.
137 (xpm_cache_color): Don't possibly over-allocate memory.
138 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
139 (gif_memory_source):
140 Use ptrdiff_t, not int or size_t, to record sizes.
141 (png_load): Don't assume values greater than 2**31 fit in 'int'.
142 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
143 either works, as we prefer signed integers.
144 (tiff_read_from_memory, tiff_write_from_memory):
145 Return tsize_t, not size_t, since that's what the TIFF API wants.
146 (tiff_read_from_memory): Don't fail simply because the read would
147 go past EOF; instead, return a short read.
148 (tiff_load): Omit no-longer-needed casts.
149 (Fimagemagick_types): Don't assume size fits into 'int'.
150
3cc5a532
PE
151 Improve hashing quality when configured --with-wide-int.
152 * fns.c (hash_string): New function, taken from sxhash_string.
153 Do not discard information about ASCII character case; this
154 discarding is no longer needed.
155 (sxhash-string): Use it. Change sig to match it. Caller changed.
156 * lisp.h: Declare it.
157 * lread.c (hash_string): Remove, since we now use fns.c's version.
158 The fns.c version returns a wider integer if --with-wide-int is
159 specified, so this should help the quality of the hashing a bit.
160
b312a492
PE
161 * emacs.c: Integer overflow minor fix.
162 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
163 Define only if GNU_LINUX.
164 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
165
dfd153ae
PE
166 * dispnew.c: Integer signedness and overflow fixes.
167 Remove unnecessary forward decls, that were a maintenance hassle.
168 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
169 All uses changed.
170 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
171 (scrolling_window): Use ptrdiff_t, not int, for byte count.
172 (prepare_desired_row, line_draw_cost):
173 Use int, not unsigned, where either works.
174 (save_current_matrix, restore_current_matrix):
175 Use ptrdiff_t, not size_t, where either works.
176 (init_display): Check for overflow more accurately, and without
177 relying on undefined behavior.
178
a81d11a3
PE
179 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
180 Remove, replacing with the new symbols in lisp.h. All uses changed.
181 * fileio.c (make_temp_name):
182 * filelock.c (lock_file_1, lock_file):
183 * xdisp.c (message_dolog):
184 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
185 Use pMd etc. instead.
186 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
187 replacing the pWIDE etc. symbols removed from editfns.c.
188
3300e6fd
PE
189 * keyboard.h (num_input_events): Now uintmax_t.
190 This is (very slightly) less likely to mess up due to wraparound.
191 All uses changed.
192
fd05c7e9
PE
193 * buffer.c: Integer signedness fixes.
194 (alloc_buffer_text, enlarge_buffer_text):
195 Use ptrdiff_t rather than size_t when either will do, as we prefer
196 signed integers.
197
903fe15d
PE
198 * alloc.c: Integer signedness and overflow fixes.
199 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
200 (__malloc_size_t): Default to size_t, not to int.
201 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
202 (Fgarbage_collect, mark_object_loop_halt, mark_object):
203 Prefer ptrdiff_t to size_t when either would do, as we prefer
204 signed integers.
205 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
206 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
207 Now const. Initialize with values that are in range even if char
208 is signed.
209 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
210 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
211 These functions do the right thing with sizes > 2**32.
212 (check_depth): Now ptrdiff_t, not int.
213 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
214 Adjust to new way of storing sizes. Check for size overflow bugs
215 in rest of code.
216 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
217 slightly wrong anyway, as it missed one instance of
218 XMALLOC_OVERRUN_CHECK_OVERHEAD.
219 (refill_memory_reserve): Omit needless cast to size_t.
220 (mark_object_loop_halt): Mark as externally visible.
221
ac82cc6a
PE
222 * xselect.c: Integer signedness and overflow fixes.
223 (Fx_register_dnd_atom, x_handle_dnd_message):
224 Use ptrdiff_t, not size_t, since we prefer signed.
225 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
226 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
227 x_dnd_atoms_size and x_dnd_atoms_length.
228
c2d1e36d
PE
229 * doprnt.c: Prefer signed to unsigned when either works.
230 * eval.c (verror):
231 * doprnt.c (doprnt):
232 * lisp.h (doprnt):
233 * xdisp.c (vmessage):
234 Use ptrdiff_t, not size_t, when using or implementing doprnt,
235 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
236 prefer signed arithmetic to avoid comparison confusion.
237 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
238 but is a bit tricky.
239
0e926e56
PE
240 Assume freestanding C89 headers, string.h, stdlib.h.
241 * data.c, doprnt.c, floatfns.c, print.c:
242 Include float.h unconditionally.
243 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
244 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
245 * regex.c: Likewise for stddef.h, string.h.
246 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
247 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
248 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
249 (STDC_HEADERS): Remove obsolete defines.
250 * sysdep.c: Include limits.h unconditionally.
251
9cfdb3ec
PE
252 Assume support for memcmp, memcpy, memmove, memset.
253 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
254 * regex.c (memcmp, memcpy):
255 Remove; we assume C89 now.
256
257 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
258 (__malloc_safe_bcopy): Remove; no longer needed.
259
cf950e6b 260 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
261 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
262 well either way, and we prefer signed to unsigned.
263
9e381cdd
PE
2642011-07-17 Paul Eggert <eggert@cs.ucla.edu>
265
266 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
267 This works around a problem with the previous change to Fcopy_file.
268 Recent glibc declares fchown with __attribute__((warn_unused_result)),
269 and without this change, GCC might complain about discarding
270 fchown's return value.
271
b5641435
JB
2722011-07-16 Juanma Barranquero <lekktu@gmail.com>
273
274 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
275
a8031457
PE
2762011-07-16 Paul Eggert <eggert@cs.ucla.edu>
277
278 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
279
dd889327
LMI
2802011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
281
750c33f7
LMI
282 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
283 it's used from the C level.
284
dd889327
LMI
285 * process.c: Use the same condition for POLL_FOR_INPUT in both
286 keyboard.c and process.c (bug#1858).
287
87e86684
LM
2882011-07-09 Lawrence Mitchell <wence@gmx.li>
289
290 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
291 (Fgnutls_boot): Use it.
292
64348f40
AS
2932011-07-15 Andreas Schwab <schwab@linux-m68k.org>
294
295 * doc.c (Fsubstitute_command_keys): Revert last change.
296
1d698799
LMI
2972011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
298
f863868c
LMI
299 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
300 quotes the next character, and doesn't affect other longer
301 sequences (bug#8935).
302
1d698799
LMI
303 * lread.c (syms_of_lread): Clarify that is isn't only
304 `eval-buffer' and `eval-defun' that's affected by
305 `lexical-binding' (bug#8460).
306
aa4b6df6
EZ
3072011-07-15 Eli Zaretskii <eliz@gnu.org>
308
309 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
310 bidi redisplay when a line includes both an image and is
311 truncated.
312
5d856da6
PE
3132011-07-14 Paul Eggert <eggert@cs.ucla.edu>
314
ad6042bb
PE
315 Fix minor problems found by static checking.
316 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
317 (elsz): Now a signed constant, not a size_t var. We prefer signed
318 types to unsigned, to avoid integer comparison confusion. Without
319 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
320 "cannot optimize loop, the loop counter may overflow", a symptom
321 of the confusion.
f00bbb22 322 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
323 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
324
6468f31c
LMI
3252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
326
49080b10
LMI
327 * search.c (Fre_search_backward): Mention `case-fold-search' in
328 all the re_search_* functions (bug#8138).
329
6468f31c
LMI
330 * keyboard.c (Fopen_dribble_file): Document when the file is
331 closed (bug#8056).
332
c965adc5
EZ
3332011-07-14 Eli Zaretskii <eliz@gnu.org>
334
df9733bf
EZ
335 * bidi.c (bidi_dump_cached_states): Fix format of displaying
336 bidi_cache_idx.
337
0bb23927
EZ
338 Support bidi reordering of display and overlay strings.
339 * xdisp.c (compute_display_string_pos)
340 (compute_display_string_end): Accept additional argument STRING.
341 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
342 (reseat_to_string): Initialize bidi_it->string.s and
343 bidi_it->string.schars.
344 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
345 NULL (avoids a crash in bidi_paragraph_init). Initialize
346 itb.string.lstring.
347 (init_iterator): Call bidi_init_it only of a valid
348 buffer position was specified. Initialize paragraph_embedding to
349 L2R.
350 (reseat_to_string): Initialize the bidi iterator.
351 (display_string): If we need to ignore text properties of
352 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
353 original value of -1 will not work with bidi.)
354 (compute_display_string_pos): First arg is now struct
355 `text_pos *'; all callers changed. Support display properties on
356 Lisp strings.
357 (compute_display_string_end): Support display properties on Lisp
358 strings.
359 (init_iterator, reseat_1, reseat_to_string): Initialize the
360 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
361 when iterating on a string not from display properties).
362 (compute_display_string_pos, compute_display_string_end): Fix
363 calculation of the object to scan. Fixes an error when using
364 arrow keys.
365 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
366 base_level_stop; instead, set base_level_stop to BEGV. Fixes
367 crashes in vertical-motion.
368 (next_element_from_buffer): Improve commentary for when
369 the iterator is before prev_stop.
370 (init_iterator): Initialize bidi_p from the default value of
371 bidi-display-reordering, not from buffer-local value. Use the
372 buffer-local value only if initializing for buffer iteration.
373 (handle_invisible_prop): Support invisible properties on strings
374 that are being bidi-reordered.
375 (set_iterator_to_next): Support bidi reordering of C strings and
376 Lisp strings.
377 (next_element_from_string): Support bidi reordering of Lisp
378 strings.
379 (handle_stop_backwards): Support Lisp strings as well.
380 (display_string): Support display of R2L glyph rows. Use
381 IT_STRING_CHARPOS when displaying from a Lisp string.
382 (init_iterator): Don't initialize it->bidi_p for strings
383 here.
384 (reseat_to_string): Initialize it->bidi_p for strings here.
385 (next_element_from_string, next_element_from_c_string)
386 (next_element_from_buffer): Add xassert's for correspondence
387 between IT's object being iterated and it->bidi_it.string
388 structure.
389 (face_before_or_after_it_pos): Support bidi iteration.
390 (next_element_from_c_string): Handle the case of the first string
391 character that is not the first one in the visual order.
392 (get_visually_first_element): New function, refactored from common
393 parts of next_element_from_buffer, next_element_from_string, and
394 next_element_from_c_string.
395 (tool_bar_lines_needed, redisplay_tool_bar)
396 (display_menu_bar): Force left-to-right direction. Add a FIXME
397 comment for making that be controlled by a user option.
398 (push_it, pop_it): Save and restore the state of the
399 bidi iterator. Save and restore the bidi_p flag.
400 (pop_it): Iterate out of display property for string iteration as
401 well.
402 (iterate_out_of_display_property): Support iteration over strings.
403 (handle_single_display_spec): Set up it->bidi_it for iteration
404 over a display string, and call bidi_init_it.
405 (handle_single_display_spec, next_overlay_string)
406 (get_overlay_strings_1, push_display_prop): Set up the bidi
407 iterator for displaying display or overlay strings.
408 (forward_to_next_line_start): Don't use the shortcut if
409 bidi-iterating.
410 (back_to_previous_visible_line_start): If handle_display_prop
411 pushed the iterator stack, restore the internal state of the bidi
412 iterator by calling bidi_pop_it same number of times.
413 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
414 and we are bidi-iterating, don't decrement the iterator position;
415 instead, set the first_elt flag in the bidi iterator, to produce
416 the same effect.
417 (reseat_1): Remove redundant setting of string_from_display_prop_p.
418 (push_display_prop): xassert that we are iterating a buffer.
419 (push_it, pop_it): Save and restore paragraph_embedding member.
420 (handle_single_display_spec, next_overlay_string)
421 (get_overlay_strings_1, reseat_1, reseat_to_string)
422 (push_display_prop): Set up the `unibyte' member of bidi_it.string
423 correctly. Don't assume unibyte strings are not bidi-reordered.
424 (compute_display_string_pos)
425 (compute_display_string_end): Fix handling the case of C string.
426 (push_it, pop_it): Save and restore from_disp_prop_p.
427 (handle_single_display_spec, push_display_prop): Set the
428 from_disp_prop_p flag.
429 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
430 (pop_it): Call iterate_out_of_display_property only if we are
431 popping after iteration over a string that came from a display
432 property. Fix a typo in popping stretch info. Add an assertion
433 for verifying that the iterator position is in sync with the bidi
434 iterator.
435 (handle_single_display_spec, get_overlay_strings_1)
436 (push_display_prop): Fix initialization of paragraph direction for
437 string when that of the parent object is not yet determined.
438 (reseat_1): Call bidi_init_it to resync the bidi
439 iterator with IT's position. (Bug#7616)
440 (find_row_edges): If ROW->start.pos gives position
441 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
442 (handle_stop, back_to_previous_visible_line_start, reseat_1):
443 Reset the from_disp_prop_p flag.
444 (SAVE_IT, RESTORE_IT): New macros.
445 (pos_visible_p, face_before_or_after_it_pos)
446 (back_to_previous_visible_line_start)
447 (move_it_in_display_line_to, move_it_in_display_line)
448 (move_it_to, move_it_vertically_backward, move_it_by_lines)
449 (try_scrolling, redisplay_window, display_line): Use them when
450 saving a temporary copy of the iterator and restoring it back.
451 (back_to_previous_visible_line_start, reseat_1)
452 (init_iterator): Empty the bidi cache "stack".
453 (move_it_in_display_line_to): If iterator ended up at
454 EOL, but we never saw any buffer positions smaller than
455 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
456 motion in bidi-reordered lines.
457 (move_it_in_display_line_to): Record prev_method and prev_pos
458 immediately before the call to set_iterator_to_next. Fixes cursor
459 motion in bidi-reordered lines with stretch glyphs and strings
460 displayed in margins. (Bug#8133) (Bug#8867)
461 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
462 TO_CHARPOS.
463 (pos_visible_p): Support positions in bidi-reordered lines. Save
464 and restore bidi cache.
465
466 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
467 (bidi_paragraph_info): Delete unused struct.
468 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
469 (bidi_cache_start): New variable.
470 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
471 to zero.
472 (bidi_cache_fetch_state, bidi_cache_search)
473 (bidi_cache_find_level_change, bidi_cache_iterator_state)
474 (bidi_cache_find, bidi_peek_at_next_level)
475 (bidi_level_of_next_char, bidi_find_other_level_edge)
476 (bidi_move_to_visually_next): Compare cache index with
477 bidi_cache_start rather than with zero.
478 (bidi_fetch_char): Accept new argument STRING; all callers
479 changed. Support iteration over a string. Support strings with
480 display properties. Support unibyte strings. Fix the type of
481 `len' according to what STRING_CHAR_AND_LENGTH expects.
482 (bidi_paragraph_init, bidi_resolve_explicit_1)
483 (bidi_resolve_explicit, bidi_resolve_weak)
484 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
485 iteration over a string.
486 (bidi_set_sor_type, bidi_resolve_explicit_1)
487 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
488 can now be zero (for strings); special values 0 and -1 were
489 changed to -1 and -2, respectively.
490 (bidi_char_at_pos): New function.
491 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
492 Call it instead of FETCH_MULTIBYTE_CHAR.
493 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
494 initialized to valid values.
495 (bidi_init_it): Don't initialize charpos and bytepos with invalid
496 values.
497 (bidi_level_of_next_char): Allow the sentinel "position" to pass
498 the test for valid cached positions. Fix the logic for looking up
499 the sentinel state in the cache. GCPRO the Lisp string we are
500 iterating.
501 (bidi_push_it, bidi_pop_it): New functions.
502 (bidi_initialize): Initialize the bidi cache start stack pointer.
503 (bidi_cache_ensure_space): New function, refactored from part of
504 bidi_cache_iterator_state. Don't assume the required size is just
505 one BIDI_CACHE_CHUNK away.
506 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
507 (bidi_count_bytes, bidi_char_at_pos): New functions.
508 (bidi_cache_search): Don't assume bidi_cache_last_idx is
509 always valid if bidi_cache_idx is valid.
510 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
511 is valid if it's going to be used.
512 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
513 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
514 (bidi_cache_find_level_change, bidi_cache_ensure_space)
515 (bidi_cache_iterator_state, bidi_cache_find)
516 (bidi_find_other_level_edge, bidi_cache_start_stack): All
517 variables related to cache indices are now EMACS_INT.
518
0bb23927
EZ
519 * dispextern.h (struct bidi_string_data): New structure.
520 (struct bidi_it): New member `string'. Make flag members be 1-bit
521 fields, and put them last in the struct.
522 (compute_display_string_pos, compute_display_string_end): Update
523 prototypes.
524 (bidi_push_it, bidi_pop_it): Add prototypes.
525 (struct iterator_stack_entry): New members bidi_p,
526 paragraph_embedding, and from_disp_prop_p.
527 (struct it): Member bidi_p is now a bit field 1 bit wide.
528 (bidi_shelve_cache, bidi_unshelve_cache): Declare
529 prototypes.
530
531 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
532 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
533 and vector-like objects.
534
535 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
536 cache around display iteration.
537
538 * window.c (Fwindow_end, window_scroll_pixel_based)
539 (displayed_window_lines, Frecenter): Save and restore the bidi
540 cache around display iteration.
541
3bbd2265
LMI
5422011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
543
544 * editfns.c (Fdelete_region): Clarify the use of the named
545 parameters (bug#6788).
546
adc47434
MR
5472011-07-14 Martin Rudalics <rudalics@gmx.at>
548
549 * indent.c (Fvertical_motion): Set and restore w->pointm when
550 saving and restoring the window's buffer (Bug#9006).
551
837c31f8
LMI
5522011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
553
554 * editfns.c (Fstring_to_char): Clarify just what is returned
555 (bug#6576). Text by Eli Zaretskii.
556
ac389d0c
JB
5572011-07-13 Juanma Barranquero <lekktu@gmail.com>
558
559 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
560
0be0ce47
EZ
5612011-07-13 Eli Zaretskii <eliz@gnu.org>
562
563 * buffer.c (mmap_find): Fix a typo.
564
cd18e7e3
JB
5652011-07-13 Johan Bockgård <bojohan@gnu.org>
566
567 Fix execution of x selection hooks.
568 * xselect.c (Qx_lost_selection_functions)
569 (Qx_sent_selection_functions): New vars.
570 (syms_of_xselect): DEFSYM them.
571 (x_handle_selection_request): Pass Qx_sent_selection_functions
572 rather than Vx_sent_selection_functions to Frun_hook_with_args.
573 (x_handle_selection_clear,x_clear_frame_selections):
574 Pass Qx_lost_selection_functions rather than
575 Vx_lost_selection_functions to Frun_hook_with_args.
576
47ea7f44
PE
5772011-07-13 Paul Eggert <eggert@cs.ucla.edu>
578
ac389d0c 579 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
580 The old code sometimes used this field without initializing it.
581
47ea7f44
PE
582 * alloc.c (gc_sweep): Don't read past end of array.
583 In theory, the old code could also have corrupted Emacs internals,
584 though it'd be very unlikely.
585
bc985c87
AS
5862011-07-12 Andreas Schwab <schwab@linux-m68k.org>
587
588 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 589 argument. (Bug#4026)
bc985c87 590
0cf34688
LMI
5912011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
592
b3dadd76
LMI
593 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
594 key" (bug#4257).
595
0cf34688
LMI
596 * window.c (Fset_window_start): Doc fix (bug#4199).
597 (Fset_window_hscroll): Ditto.
598
270768cd
PE
5992011-07-12 Paul Eggert <eggert@cs.ucla.edu>
600
077e3dda 601 Fix minor new problems caught by GCC 4.6.1.
270768cd 602 * term.c (init_tty): Remove unused local.
490011a6 603 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 604 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 605 not used otherwise.
270768cd 606
b1f58454
CY
6072011-07-12 Chong Yidong <cyd@stupidchicken.com>
608
609 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
610
22b9578d
LMI
6112011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
612
6e70ab07
LMI
613 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
614 are the mini-buffer and the echo area (bug#3320).
615
22b9578d
LMI
616 * term.c (init_tty): Remove support for supdup, c10 and perq
617 terminals, which are no longer supported (bug#1482).
618
8974cc9f
JB
6192011-07-10 Johan Bockgård <bojohan@gnu.org>
620
621 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
622
a560d974
JD
6232011-07-10 Jan Djärv <jan.h.d@swipnet.se>
624
625 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
626 for non-popups (Bug#3642).
627
1dae0f0a
AS
6282011-07-10 Andreas Schwab <schwab@linux-m68k.org>
629
268c2c36 630 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 631 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
632 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
633 * cm.c (losecursor): Likewise.
1dae0f0a
AS
634 * data.c (fmod): Likewise.
635 * dispnew.c (swap_glyphs_in_rows): Likewise.
636 * emacs.c (memory_warning_signal): Likewise.
637 * floatfns.c (float_error): Likewise.
638 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
639 (otf_open, font_otf_capability, generate_otf_features)
640 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
641 Likewise.
642 * image.c (pbm_read_file): Likewise.
643 * indent.c (string_display_width): Likewise.
644 * intervals.c (check_for_interval, search_for_interval)
645 (inc_interval_count, count_intervals, root_interval)
646 (adjust_intervals_for_insertion, make_new_interval): Likewise.
647 * lread.c (defalias): Likewise.
268c2c36 648 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
649 * regex.c (set_image_of_range_1, set_image_of_range)
650 (regex_grow_registers): Likewise.
651 * sysdep.c (strerror): Likewise.
652 * termcap.c (valid_filename_p, tprint, main): Likewise.
653 * tparam.c (main): Likewise.
654 * unexhp9k800.c (run_time_remap, save_data_space)
655 (update_file_ptrs, read_header, write_header, calculate_checksum)
656 (copy_file, copy_rest, display_header): Likewise.
657 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
658 Likewise.
659 * xdisp.c (check_it): Likewise.
660 * xfaces.c (register_color, unregister_color, unregister_colors):
661 Likewise.
662 * xfns.c (print_fontset_result): Likewise.
663 * xrdb.c (member, fatal, main): Likewise.
664
99033785
PE
6652011-07-10 Paul Eggert <eggert@cs.ucla.edu>
666
667 Fix minor problems found by static checking (Bug#9031).
668 * chartab.c (char_table_set_range, map_sub_char_table):
669 Remove unused locals.
670 (uniprop_table): Now static.
671 * composite.c (_work_char): Remove unused static var.
672
9cb2ac56
JB
6732011-07-09 Juanma Barranquero <lekktu@gmail.com>
674
675 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
676
f25661f0
JD
6772011-07-09 Jan Djärv <jan.h.d@swipnet.se>
678
679 * gtkutil.c (qttip_cb): Remove code without function.
680
8278c4fe
EZ
6812011-07-09 Eli Zaretskii <eliz@gnu.org>
682
683 * w32.c (pthread_sigmask): New stub.
684
1692ae2d 6852011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 686
8a6ebd58 687 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
688 sigprocmask is portable only for single-threaded applications, and
689 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
690 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
691 (LIBES): Use it.
692 * callproc.c (Fcall_process):
693 * process.c (create_process):
694 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
695 Use pthread_sigmask, not sigprocmask.
123403e4 696
1b854618
JD
6972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
698
699 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
700 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
701 wrong (Bug#8591).
702
3fe4b549
JD
7032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
704
0ce7e563
JD
705 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
706 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
707 (xg_hide_tooltip): Fix comment.
708
3fe4b549
JD
709 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
710 in registerServicesMenuSendTypes.
711 (validRequestorForSendType): Don't check ns_return_types.
712
713 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
714 ns_return_type.
715
5df75e47
JR
7162011-07-08 Jason Rumney <jasonr@gnu.org>
717
718 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
719 frame struct members of non-existent frames (Bug#6284).
720
699c10bd
JD
7212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
722
4393663b
JD
723 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
724 variable firstTime not needed on OSX >= 10.6.
725 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
726 >= 10.5. Use setKnobProportion, setDoubleValue.
727
728 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
729 (MAC_OS_X_VERSION_10_5): Define if not defined.
730 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
731 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
732 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
733
734 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
735 cString and lossyCString on OSX >= 10.4
736
737 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
738 sizeToFit on OSX >= 10.2.
739
740 * nsimage.m (allocInitFromFile): Don't use deprecated method
741 bestRepresentationForDevice on OSX >= 10.6.
742
743 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
744 to avoid warning.
745
746 * emacs.c: Declare unexec_init_emacs_zone.
747
a63e0781
JD
748 * nsgui.h: Fix compiler warning about gnulib redefining verify.
749
699c10bd
JD
750 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
751
752 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
753 on svcsMenu (Bug#8842).
754
755 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
756 ns_return_types.
757 (Fns_list_services): Just return Qnil on 10.6, code not working there.
758
759 * nsterm.m (QUTF8_STRING): Declare.
760 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
761 (validRequestorForSendType): Return type is (id).
762 Change indexOfObjectIdenticalTo to indexOfObject.
763 Check if we have local selection before returning self (Bug#8842).
764 (writeSelectionToPasteboard): Put local selection into paste board
765 if we have a local selection (Bug#8842).
766 (syms_of_nsterm): DEFSYM QUTF8_STRING.
767
768 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
769 (ns_get_local_selection): Declare.
770
54e10184
LMI
7712011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
772
9888ff71
LMI
773 * keymap.c (describe_map_tree): Don't insert a double newline at
774 the end of the buffer (bug#1169) and return whether we inserted
775 something.
776
54e10184
LMI
777 * callint.c (Fcall_interactively): Change "reading args" to
778 "providing args" to try to clarify what it does (bug#1010).
779
15fa4783
KH
7802011-07-07 Kenichi Handa <handa@m17n.org>
781
782 * composite.c (composition_compute_stop_pos): Ignore a static
783 composition starting before CHARPOS (Bug#8915).
784
785 * xdisp.c (handle_composition_prop): Likewise.
786
a8815b00
EZ
7872011-07-07 Eli Zaretskii <eliz@gnu.org>
788
789 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
790 (Bug#9015)
791
ef7b981d 7922011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
793
794 * character.h (unicode_category_t): New enum type.
795
796 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
797 (Qchar_code_property_table): New variable.
798 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
799 (UNIPROP_COMPRESSED_FORM_P): New macros.
800 (char_table_ascii): Uncompress the compressed values.
801 (sub_char_table_ref): New arg is_uniprop. Callers changed.
802 Uncompress the compressed values.
ac389d0c 803 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
804 (char_table_ref_and_range): Uncompress the compressed values.
805 (sub_char_table_set): New arg is_uniprop. Callers changed.
806 Uncompress the compressed values.
807 (sub_char_table_set_range): Args changed. Callers changed.
808 (char_table_set_range): Adjuted for the above change.
809 (map_sub_char_table): Delete args default_val and parent. Add arg
810 top. Give decoded values to a Lisp function.
811 (map_char_table): Adjusted for the above change. Give decoded
812 values to a Lisp function. Gcpro more variables.
813 (uniprop_table_uncompress)
814 (uniprop_decode_value_run_length): New functions.
815 (uniprop_decoder, uniprop_decoder_count): New variables.
816 (uniprop_get_decoder, uniprop_encode_value_character)
817 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
818 New functions.
819 (uniprop_encoder, uniprop_encoder_count): New variables.
820 (uniprop_get_encoder, uniprop_table)
821 (Funicode_property_table_internal, Fget_unicode_property_internal)
822 (Fput_unicode_property_internal): New functions.
823 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
824 Sunicode_property_table_internal, Sget_unicode_property_internal,
825 and Sput_unicode_property_internal. Defvar_lisp
826 char-code-property-alist.
827
828 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
829 Vunicode_category_table.
830
831 * font.c (font_range): Adjusted for the change of
832 Vunicode_category_table.
833
76b397fb
DN
8342011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
835
836 * m/iris4d.h: Remove file, move contents ...
837 * s/irix6-5.h: ... here.
838
22b4128e
PE
8392011-07-06 Paul Eggert <eggert@cs.ucla.edu>
840
841 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
842 * alloc.c (mark_buffer):
843 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
844 (clone_per_buffer_values): Don't assume that
22b4128e
PE
845 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
846 This isn't true in general, and it's particularly not true
847 if Emacs is configured with --with-wide-int.
848 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
849 New macros, used in the buffer.c change.
850
869795d6
JD
8512011-07-05 Jan Djärv <jan.h.d@swipnet.se>
852
853 * xsettings.c: Use both GConf and GSettings if both are available.
854 (store_config_changed_event): Add comment.
855 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
856 (store_tool_bar_style_changed): New functions.
857 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
858 (struct xsettings): Move font inside HAVE_XFT.
859 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
860 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
861 Move inside HAVE_XFT.
862 (something_changed_gsettingsCB): Renamed from something_changedCB.
863 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
864 also.
865 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
866 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
867 (something_changed_gconfCB): Renamed from something_changedCB.
868 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
869 (parse_settings): Move check for font inside HAVE_XFT.
870 (read_settings, apply_xft_settings): Add comment.
871 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
872 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
873 call store_font_name_changed.
874 (xft_settings_event): Add comment.
875 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
876 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
877 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
878 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
879 (xsettings_initialize): Call init_gsettings last.
880 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
881 comment.
882
d8ed26bd
PE
8832011-07-05 Paul Eggert <eggert@cs.ucla.edu>
884
885 Random fixes. E.g., (random) never returned negative values.
886 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
887 subseconds part to the entropy, as that's a bit more random.
888 Prefer signed to unsigned, since the signedness doesn't matter and
889 in general we prefer signed. When given a limit, use a
890 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
891 latter isn't right if USE_2_TAGS_FOR_INTS.
892 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
893 not 0..VALMASK. Don't discard "excess" bits that random () returns.
894
cabf1cac
SM
8952011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
896
897 * textprop.c (text_property_stickiness):
898 Obey Vtext_property_default_nonsticky.
899 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
900 * w32fns.c (syms_of_w32fns):
901 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
902
6e9b2be9
PE
9032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
904
905 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
906 This is more efficient than Ffile_directory_p and avoids a minor race.
907
90186c68
LMI
9082011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
909
7c301272
LMI
910 * buffer.c (Foverlay_put): Say what the return value is
911 (bug#7835).
912
c4f2d8d4
LMI
913 * fileio.c (barf_or_query_if_file_exists): Check first if the file
914 is a directory before asking whether to use the file name
915 (bug#7564).
ad637907
LMI
916 (barf_or_query_if_file_exists): Make the "File is a directory"
917 error be more correct.
c4f2d8d4 918
90186c68
LMI
919 * fns.c (Frequire): Remove the mention of the .gz files, since
920 that's installation-specific, but keep the mention of
921 `get-load-suffixes'.
922
da64016e
PE
9232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
924
925 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
926 Report string overflow if the output is too long.
927
7d47b580
JB
9282011-07-04 Juanma Barranquero <lekktu@gmail.com>
929
a555cb87
JB
930 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
931 (syms_of_gnutls): Remove duplicate DEFSYM for
932 Qgnutls_bootprop_verify_hostname_error, an error for
933 Qgnutls_bootprop_verify_error (which is no longer used).
934
7d47b580
JB
935 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
936 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
937 Also (re)move comments that are misplaced or no longer relevant.
938
1e49bfab
LMI
9392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
940
941 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
942
1485f4c0
CY
9432011-07-03 Chong Yidong <cyd@stupidchicken.com>
944
945 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
946 and background color parameters if they have been changed.
947
a9ab721e
LMI
9482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
949
950 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
951
cf7cff57
PE
9522011-07-03 Paul Eggert <eggert@cs.ucla.edu>
953
2e13213d
PE
954 * xsettings.c (SYSTEM_FONT): Define only when used.
955 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
956
cf7cff57
PE
957 * keymap.c (access_keymap_1): Now static.
958
7a8e04f7
CY
9592011-07-02 Chong Yidong <cyd@stupidchicken.com>
960
961 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
962 leave any prefix arg for the up event (Bug#1586).
963
61352f62
LMI
9642011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
965
69bb1ef7
LMI
966 * lread.c (syms_of_lread): Mention single symbols defined by
967 `defvar' or `defconst' (bug#7154).
968
61352f62 969 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 970 (Frequire): Mention get-load-suffixes.
61352f62 971
28545e04
MR
9722011-07-02 Martin Rudalics <rudalics@gmx.at>
973
974 * window.h (window): Remove clone_number slot.
975 * window.c (Fwindow_clone_number, Fset_window_clone_number):
976 Remove.
977 (make_parent_window, make_window, saved_window)
978 (Fset_window_configuration, save_window_save): Don't deal with
979 clone numbers.
980 * buffer.c (Qclone_number): Remove declaration.
981 (sort_overlays, overlay_strings): Don't deal with clone numbers.
982
3349e122
SM
9832011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
984
985 Add multiple inheritance to keymaps.
986 * keymap.c (Fmake_composed_keymap): New function.
987 (Fset_keymap_parent): Simplify.
988 (fix_submap_inheritance): Remove.
989 (access_keymap_1): New function extracted from access_keymap to handle
990 embedded parents and handle lists of maps.
991 (access_keymap): Use it.
992 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
993 (Fcopy_keymap): Handle embedded parents.
994 (Fcommand_remapping, define_as_prefix): Simplify.
995 (Fkey_binding): Simplify.
996 (syms_of_keymap): Move minibuffer-local-completion-map,
997 minibuffer-local-filename-completion-map,
998 minibuffer-local-must-match-map, and
999 minibuffer-local-filename-must-match-map to Elisp.
1000 (syms_of_keymap): Defsubr make-composed-keymap.
1001 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1002 (parse_menu_item): Trivial simplification.
1003
3279eb87
GM
10042011-07-01 Glenn Morris <rgm@gnu.org>
1005
1006 * Makefile.in (SETTINGS_LIBS): Fix typo.
1007
4550efdf
KI
10082011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1009
1010 * coding.c (Fencode_coding_string): Record the last coding system
1011 used, as the function doc string says (bug#8738).
1012
0949d2b6
JD
10132011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1014
1015 * xsettings.c (store_monospaced_changed): Take new font as arg and
1016 check for change against current_mono_font.
1017 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1018 (emacs_settings_constructor, emacs_settings_get_property)
1019 (emacs_settings_set_property, emacs_settings_class_init)
1020 (emacs_settings_init, gsettings_obj): Remove.
1021 (something_changedCB): New function for HAVE_GSETTINGS.
1022 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1023 with value as argument.
1024 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1025 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1026 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1027 "changed".
1028
1029 * xgselect.c: Add defined (HAVE_GSETTINGS).
1030 (xgselect_initialize): Ditto.
1031
1032 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1033 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1034 xg_select.
1035
bbc6b304
PE
10362011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 * eval.c (struct backtrace): Simplify and port the data structure.
1039 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1040 signed bit field, as this assumption is not portable and it makes
1041 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1042 "char debug_on_exit : 1" as this is not portable either; instead,
1043 use the portable "unsigned int debug_on_exit : 1". Remove unused
1044 member evalargs. Remove obsolete comments about cc bombing out.
1045
9851bfc5
JD
10462011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1047
51bb811f 1048 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1049 Let HAVE_GSETTINGS override HAVE_GCONF.
1050 (store_monospaced_changed): New function.
1051 (EMACS_SETTINGS): A new type derived from GObject to handle
1052 GSettings notifications.
1053 (emacs_settings_constructor, emacs_settings_get_property)
1054 (emacs_settings_set_property, emacs_settings_class_init):
1055 New functions.
1056 (gsettings_client, gsettings_obj): New variables.
1057 (GSETTINGS_SCHEMA): New define.
1058 (something_changedCB): Call store_monospaced_changed.
1059 (init_gsettings): New function.
1060 (xsettings_initialize): Call init_gsettings.
1061 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1062 to NULL.
1063
1064 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1065 GCONF_CFLAGS/LIBS.
1066
5386012d
MR
10672011-06-29 Martin Rudalics <rudalics@gmx.at>
1068
1069 * window.c (resize_root_window, grow_mini_window)
1070 (shrink_mini_window): Rename Qresize_root_window to
1071 Qwindow_resize_root_window and Qresize_root_window_vertically to
1072 Qwindow_resize_root_window_vertically.
1073
f13e0b08
PE
10742011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1075
1076 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1077
94515237
JB
10782011-06-27 Juanma Barranquero <lekktu@gmail.com>
1079
1080 * makefile.w32-in: Redesign dependencies so they reflect more
1081 clearly which files are directly included by each source file,
1082 and not through other includes.
1083
e43b6e43
MR
10842011-06-27 Martin Rudalics <rudalics@gmx.at>
1085
1086 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1087 (sort_overlays, overlay_strings): When an overlay's clone number
1088 matches the window's clone number process the overlay even if
1089 the overlay's window property doesn't match the current window.
1090
d68443dc
MR
1091 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1092 (Fwindow_hchild): Rename to Fwindow_left_child.
1093 (Fwindow_next): Rename to Fwindow_next_sibling.
1094 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1095 (resize_window_check): Rename to window_resize_check.
1096 (resize_window_apply): Rename to window_resize_apply.
1097 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1098 (Fdelete_other_windows_internal, resize_frame_windows)
1099 (Fsplit_window_internal, Fdelete_window_internal)
1100 (grow_mini_window, shrink_mini_window)
1101 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1102
c7e73be5
JD
11032011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1104
1105 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1106 (emacs_fixed_set_min_size): Remove.
1107 (emacs_fixed_new): Take frame as argument.
1108
1109 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1110 (_EmacsFixedPrivate): Remove minwidth/height.
1111 Add struct frame *f.
1112 (emacs_fixed_init): Initialize priv->f.
1113 (get_parent_class, emacs_fixed_set_min_size): Remove.
1114 (emacs_fixed_new): Set priv->f to argument.
1115 (emacs_fixed_get_preferred_width)
1116 (emacs_fixed_get_preferred_height): Use min_width/height from
1117 frames size_hint to set minimum and natural (Bug#8919).
1118 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1119 and use min_width/height from frames size_hint to set
1120 min_width/height (Bug#8919).
1121
1122 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1123 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1124 Fix indentation.
c7e73be5 1125
cf99dcf8
EZ
11262011-06-26 Eli Zaretskii <eliz@gnu.org>
1127
1128 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1129 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1130 called at ZV.
1131
029529ac
CY
11322011-06-26 Chong Yidong <cyd@stupidchicken.com>
1133
1134 * process.c (wait_reading_process_output): Bypass select if
1135 waiting for a cell while ignoring keyboard input, and input is
1136 pending. Suggested by Jan Djärv (Bug#8869).
1137
7a7ef429
PE
11382011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 Use gnulib's dup2 module instead of rolling our own.
1141 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1142
11fdef7d 11432011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1144
1145 * dispnew.c (scrolling_window): Before scrolling, turn off a
1146 mouse-highlight in the window being scrolled.
1147
cd3520a4
JB
11482011-06-24 Juanma Barranquero <lekktu@gmail.com>
1149
1150 Move DEFSYM to lisp.h and use everywhere.
1151
1152 * character.h (DEFSYM): Move declaration...
1153 * lisp.h (DEFSYM): ...here.
1154
1155 * gnutls.c:
1156 * minibuf.c:
1157 * w32menu.c:
1158 * w32proc.c:
1159 * w32select.c: Don't include character.h.
1160
1161 * alloc.c (syms_of_alloc):
1162 * buffer.c (syms_of_buffer):
1163 * bytecode.c (syms_of_bytecode):
1164 * callint.c (syms_of_callint):
1165 * casefiddle.c (syms_of_casefiddle):
1166 * casetab.c (init_casetab_once):
1167 * category.c (init_category_once, syms_of_category):
1168 * ccl.c (syms_of_ccl):
1169 * cmds.c (syms_of_cmds):
1170 * composite.c (syms_of_composite):
1171 * dbusbind.c (syms_of_dbusbind):
1172 * dired.c (syms_of_dired):
1173 * dispnew.c (syms_of_display):
1174 * doc.c (syms_of_doc):
1175 * editfns.c (syms_of_editfns):
1176 * emacs.c (syms_of_emacs):
1177 * eval.c (syms_of_eval):
1178 * fileio.c (syms_of_fileio):
1179 * fns.c (syms_of_fns):
1180 * frame.c (syms_of_frame):
1181 * fringe.c (syms_of_fringe):
1182 * insdel.c (syms_of_insdel):
1183 * keymap.c (syms_of_keymap):
1184 * lread.c (init_obarray, syms_of_lread):
1185 * macros.c (syms_of_macros):
1186 * msdos.c (syms_of_msdos):
1187 * print.c (syms_of_print):
1188 * process.c (syms_of_process):
1189 * search.c (syms_of_search):
1190 * sound.c (syms_of_sound):
1191 * syntax.c (init_syntax_once, syms_of_syntax):
1192 * terminal.c (syms_of_terminal):
1193 * textprop.c (syms_of_textprop):
1194 * undo.c (syms_of_undo):
1195 * w32.c (globals_of_w32):
1196 * window.c (syms_of_window):
1197 * xdisp.c (syms_of_xdisp):
1198 * xfaces.c (syms_of_xfaces):
1199 * xfns.c (syms_of_xfns):
1200 * xmenu.c (syms_of_xmenu):
1201 * xsettings.c (syms_of_xsettings):
1202 * xterm.c (syms_of_xterm): Use DEFSYM.
1203
4228cf16
TZ
12042011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1205
cd3520a4 1206 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1207
7fcccf1e
PE
12082011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1209
7efb4e0e
PE
1210 Integer and buffer overflow fixes (Bug#8873).
1211
ff5844ad
PE
1212 * print.c (printchar, strout): Check for string overflow.
1213 (PRINTPREPARE, printchar, strout):
1214 Don't set size unless allocation succeeds.
1215
90532f02
PE
1216 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1217 for sizes. Check for string overflow more accurately.
1218 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1219
6d84508d
PE
1220 * macros.c: Integer and buffer overflow fixes.
1221 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1222 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1223 Use ptrdiff_t, not int, for sizes.
1224 Don't increment bufsize until after realloc succeeds.
1225 Check for size-calculation overflow.
1226 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1227
437b2cb4
PE
1228 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1229
8b9ac8b4
PE
1230 * lread.c: Integer overflow fixes.
1231 (read_integer): Radix is now EMACS_INT, not int,
1232 to improve quality of diagnostics for out-of-range radices.
1233 Calculate buffer size correctly for out-of-range radices.
1234 (read1): Check for integer overflow in radices, and in
1235 read-circle numbers.
82cb60d3
PE
1236 (read_escape): Avoid int overflow.
1237 (Fload, openp, read_buffer_size, read1)
1238 (substitute_object_recurse, read_vector, read_list, map_obarray):
1239 Use ptrdiff_t, not int, for sizes.
1240 (read1): Use EMACS_INT, not int, for sizes.
20270765 1241 Check for size overflow.
8b9ac8b4 1242
7fcccf1e
PE
1243 * image.c (cache_image): Check for size arithmetic overflow.
1244
bfbbd7e7
PE
1245 * lread.c: Integer overflow issues.
1246 (saved_doc_string_size, saved_doc_string_length)
1247 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1248 Now ptrdiff_t, not int.
1249 (read1): Don't assume doc string length fits in int. Check for
1250 out-of-range doc string lengths.
1251 (read_list): Don't assume file position fits in int.
39019e54 1252 (read_escape): Check for hex character overflow.
bfbbd7e7 1253
4e323265
LL
12542011-06-22 Leo Liu <sdl.web@gmail.com>
1255
1256 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1257 Move to minibuffer.el.
1258
85fece3e
PE
12592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1260
20b84ce9 1261 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1262 The following patches are for when GLYPH_DEBUG && !XASSERT.
1263 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1264 * dispnew.c (flush_stdout):
1265 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1266 Mark as externally visible.
1267 * dispnew.c (check_window_matrix_pointers): Now static.
1268 * dispnew.c (window_to_frame_vpos):
1269 * xfns.c (unwind_create_frame):
1270 * xterm.c (x_check_font): Remove unused local.
1271 * scroll.c (CHECK_BOUNDS):
1272 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1273 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1274 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1275 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1276 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1277 Now static.
1278 (debug_method_add): Use va_list and vsprintf rather than relying
1279 on undefined behavior with wrong number of arguments.
1280 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1281 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1282 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1283 since we're not interested in debugging glyphs with old libraries.
1284 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1285 GCC 4.6.0's static checking.
1286
0766b489
PE
12872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1288
31fd4b32
PE
1289 Integer overflow and signedness fixes (Bug#8873).
1290 A few related buffer overrun fixes, too.
1291
b79e8648
PE
1292 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1293
0766b489
PE
1294 * dispextern.h (struct face.stipple):
1295 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1296 (x_bitmap_mask, x_allocate_bitmap_record)
1297 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1298 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1299 (x_create_bitmap_from_xpm_data):
1300 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1301 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1302 (.bitmaps_last):
1303 * xfaces.c (load_pixmap):
1304 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1305 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1306 (.bitmaps_last, struct x_output.icon_bitmap):
1307 Use ptrdiff_t, not int, for bitmap indexes.
1308 (x_allocate_bitmap_record): Check for size overflow.
1309 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1310
b081724f
PE
1311 Use ptrdiff_t, not int, for overlay counts.
1312 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1313 * editfns.c (overlays_around, get_pos_property):
1314 * textprop.c (get_char_property_and_overlay):
1315 * xdisp.c (next_overlay_change, note_mouse_highlight):
1316 * xfaces.c (face_at_buffer_position):
21514da7
PE
1317 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1318 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1319 (Fnext_overlay_change, Fprevious_overlay_change)
1320 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1321 Use ptrdiff_t, not int, for sizes.
21514da7 1322 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1323
3de73e5e
PE
1324 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1325
2606c57b
PE
1326 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1327 (x_session_initialize): Do not assume string length fits in int.
1328
aaafe47a
PE
1329 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1330 This is unlikely, but can occur if DPI is outlandish.
1331
2674ddc8 1332 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1333 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1334
28154962
PE
1335 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1336 * xrdb.c (magic_file_p, search_magic_path):
1337 Omit last arg SUFFIX; it was always 0. All callers changed.
1338 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1339
7de51af5
PE
1340 * xfont.c (xfont_match): Avoid need for strlen.
1341
25ed6cc3
PE
1342 * xfns.c: Don't assume strlen fits in int.
1343 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1344
4eab31dd
PE
1345 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1346 not unsigned long, as we prefer signed integers. All callers changed.
1347 Detect integer overflow in repeat count.
1348 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1349 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1350
171e2a58
PE
1351 * termcap.c: Don't assume sizes fit in int and never overflow.
1352 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1353 (gobble_line): Check for size-calculation overflow.
1354
ad39faca 1355 * minibuf.c (Fread_buffer):
6e5bb2dc 1356 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1357 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1358 Don't assume string length fits in int.
1359
52c61c22 1360 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1361 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1362
b5b8c9e5
PE
1363 * font.c: Don't assume string length fits in int.
1364 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1365 Use ptrdiff_t, not int.
ccd6111c
PE
1366 (font_intern_prop): Don't assume string length fits in int.
1367 Don't assume integer property fits in fixnum.
1368 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1369
882f0d81 1370 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1371 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1372 Reformulate so as not to need the command string.
1373 Invoke gzip -cd rather than gunzip, as it's more portable.
1374 (lock_info_type, lock_file_1, lock_file):
1375 Don't assume pid_t and time_t fit in unsigned long.
1376 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1377 (current_lock_owner): Prefer signed type for sizes.
1378 Use memcpy, not strncpy, where memcpy is what is really wanted.
1379 Don't assume (via atoi) that time_t and pid_t fit in int.
1380 Check for time_t and/or pid_t out of range, e.g., via a network share.
1381 Don't alloca where an auto var works fine.
1382
93f4cf88
PE
1383 * fileio.c: Fix some integer overflow issues.
1384 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1385 Don't assume string length fits in int.
1386 (directory_file_name): Don't assume string length fits in long.
1387 (make_temp_name): Don't assume pid fits in int, or that its print
1388 length is less than 20.
1389
f3e92b69
PE
1390 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1391
1bfdaf10
PE
1392 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1393
35016e9a
PE
1394 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1395
3d1e65a1
PE
1396 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1397 We prefer signed integers, even for size calculations.
1398
0b963a93
PE
1399 * emacs.c: Don't assume string length fits in 'int'.
1400 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1401 (main): Don't invoke strlen when not needed.
1402
573f4b54
PE
1403 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1404 (XD_DEBUG_MESSAGE): Don't waste a byte.
1405
989f33ba
PE
1406 * callproc.c (getenv_internal_1, getenv_internal)
1407 (Fgetenv_internal):
965d34eb
PE
1408 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1409
e4d29b33
PE
1410 * lread.c (invalid_syntax): Omit length argument.
1411 All uses changed. This doesn't fix a bug, but it simplifies the
1412 code away from its former Hollerith-constant appearance, and it's
1413 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1414 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1415
eb49b136
PE
1416 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1417 This didn't break anything, but it didn't help either.
1418 It's confusing to put a bogus integer in a place where the actual
1419 value does not matter.
9f62aeb1 1420 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1421 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1422
15375a22
PE
1423 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1424 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1425 implementation.
b61cc01c
PE
1426 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1427 We prefer signed types, and the value cannot exceed the EMACS_INT
1428 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1429 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1430 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1431 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1432
53b2623d
PE
1433 * indent.c (sane_tab_width): New function.
1434 (current_column, scan_for_column, Findent_to, position_indentation)
1435 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1436 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1437
51cab52b 1438 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1439
f2ed8a70
PE
1440 * lisp.h (lint_assume): New macro.
1441 * composite.c (composition_gstring_put_cache):
1442 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1443
abe80cc6
PE
1444 * editfns.c, insdel.c:
1445 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1446
b02c740e
PE
1447 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1448
ebc96716
PE
1449 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1450
b4e50fa0 1451 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1452 Use much-faster test for byte-length change.
311d5d7c 1453 Don't assume string byte-length fits in 'int'.
a4cf38e4 1454 Check that character arg fits in 'int'.
85461888 1455 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1456
c0c1ee9f
PE
1457 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1458
a498d7f4
PE
1459 * fns.c (concat): Catch string overflow earlier.
1460 Do not rely on integer wraparound.
1461
51cab52b
PE
1462 * dispextern.h (struct it.overlay_strings_charpos)
1463 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1464 * xdisp.c (forward_to_next_line_start)
1465 (back_to_previous_visible_line_start)
1466 (reseat_at_next_visible_line_start, next_element_from_buffer):
1467 Don't arbitrarily truncate the value of 'selective' to int.
1468
76031fad
PE
1469 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1470
5eb55db9
PE
1471 * composite.c: Don't truncate sizes to 'int'.
1472 (composition_gstring_p, composition_reseat_it)
1473 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1474 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1475 not EMACS_UINT, for indexes.
5eb55db9 1476
0703a717
PE
1477 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1478
d6202519
PE
1479 * buffer.c: Include <verify.h>.
1480 (struct sortvec.priority, struct sortstr.priority):
8961a454 1481 Now EMACS_INT, not int.
c20998a7 1482 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1483 (struct sortstr.size, record_overlay_string)
1484 (struct sortstrlist.size, struct sortlist.used):
1485 Don't truncate size to int.
1486 (record_overlay_string): Check for size-calculation overflow.
d6202519 1487 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1488
d5a19415
JM
14892011-06-22 Jim Meyering <meyering@redhat.com>
1490
029529ac 1491 Don't leak an XBM-image-sized buffer
d5a19415
JM
1492 * image.c (xbm_load): Free the image buffer after using it.
1493
a9041e6c
PE
14942011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 Port to Sun C.
1497 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1498 that Sun C diagnosed.
1499 * fns.c (secure_hash): Fix pointer signedness issue.
1500 * intervals.c (static_offset_intervals): New function.
1501 (offset_intervals): Use it.
1502
7f3f739f
LL
15032011-06-21 Leo Liu <sdl.web@gmail.com>
1504
1505 * deps.mk (fns.o):
1506 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1507 sha512.h.
1508
1509 * fns.c (secure_hash): Rename from crypto_hash_function and change
1510 the first arg to accept symbols.
5b66d427 1511 (Fsecure_hash): New primitive.
7f3f739f
LL
1512 (syms_of_fns): New symbols.
1513
76147d94
DD
15142011-06-20 Deniz Dogan <deniz@dogan.se>
1515
1516 * process.c (Fset_process_buffer): Clarify return value in
1517 docstring.
1518
7d7d0045
CY
15192011-06-18 Chong Yidong <cyd@stupidchicken.com>
1520
1521 * dispnew.c (add_window_display_history): Use BVAR.
1522
1523 * xdisp.c (debug_method_add): Use BVAR.
1524 (check_window_end, dump_glyph_matrix, dump_glyph)
1525 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1526
1527 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1528 Likewise.
1529
1530 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1531 check till after the cache is created in init_frame_faces.
1532
ff2bc410
SM
15332011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1534
1535 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1536
28177add
PE
15372011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1538
dd3482fe
PE
1539 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1540 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1541 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1542
393d71f3 1543 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1544 * fileio.c (Finsert_file_contents):
1545 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1546 Remove the old (too-loose) buffer overflow checks.
1547 They weren't needed, since make_gap checks for buffer overflow.
1548 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1549 The old code merely checked for Emacs fixnum overflow, and relied
1550 on undefined (wraparound) behavior. The new code avoids undefined
1551 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1552
2e6813b0 1553 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1554 Tune. Don't use wider integers than needed. Don't use alloca.
1555 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1556
599a9e4f
PE
1557 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1558
99561444
PE
1559 * insdel.c, lisp.h (buffer_overflow): New function.
1560 (insert_from_buffer_1, replace_range, replace_range_2):
1561 * insdel.c (make_gap_larger):
1562 * editfns.c (Finsert_char):
1563 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1564
28177add
PE
1565 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1566
e69dafad
PE
15672011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1568
a7af7fde 1569 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1570
b1c46f02
PE
1571 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1572 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1573
e69dafad
PE
1574 * fileio.c: Don't assume EMACS_INT fits in off_t.
1575 (emacs_lseek): New static function.
1576 (Finsert_file_contents, Fwrite_region): Use it.
1577 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1578
566684ea
PE
1579 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1580
e6966cd6
PE
1581 * fns.c: Don't overflow int when computing a list length.
1582 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1583 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1584 truncation on 64-bit hosts. Check for QUIT every
1585 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1586 faster and is responsive enough.
1587 (Flength): Report an error instead of overflowing an integer.
1588 (Fsafe_length): Return a float if the value is not representable
1589 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1590 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1591 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1592
dd0b0efb
PE
1593 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1594 (header_size, word_size): New constants.
1595 (allocate_vectorlike): Don't check size overflow here.
1596 (allocate_vector): Check it here instead, since this is the only
1597 caller of allocate_vectorlike that could cause overflow.
1598 Check that the new vector's length is representable as a fixnum.
1599
86fe5cfe
PE
1600 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1601 The previous code was bogus. For example, next_almost_prime (32)
1602 returned 39, which is undesirable as it is a multiple of 3; and
1603 next_almost_prime (24) returned 25, which is a multiple of 5 so
1604 why was the code bothering to check for multiples of 7?
1605
80e88859
PE
1606 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1607
4a2f0ad6
PE
1608 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1609
f66c7cf8
PE
1610 Variadic C functions now count arguments with ptrdiff_t.
1611 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1612 Back then I didn't know that the Emacs coding style prefers signed int.
1613 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1614 were being counted with int, which may truncate counts on 64-bit
1615 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1616 * lisp.h (struct Lisp_Subr.function.aMANY)
1617 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1618 Arg counts are now ptrdiff_t, not size_t.
1619 All variadic functions and their callers changed accordingly.
1620 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1621 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1622 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1623 * callint.c (Fcall_interactively): Check arg count for overflow,
1624 to avoid potential buffer overrun. Use signed char, not 'int',
1625 for 'varies' array, so that we needn't bother to check its size
1626 calculation for overflow.
1627 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1628 * eval.c (apply_lambda):
1629 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1630 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1631 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1632
a1759b76
PE
1633 * callint.c (Fcall_interactively): Don't use index var as event count.
1634
d96be9fc
PE
1635 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1636 * mem-limits.h (SIZE): Remove; no longer used.
1637
a690a978 1638 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1639
578c21e6
PE
1640 Remove unnecessary casts.
1641 * xterm.c (x_term_init):
1642 * xfns.c (x_set_border_pixel):
1643 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1644 These aren't needed now that we assume ANSI C.
1645
96f53c6c
PE
1646 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1647 It's more likely to cause problems (due to unsigned overflow)
1648 than to cure them.
1649
83c77d31
PE
1650 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1651
ee2079f1
PE
1652 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1653
6da65536
PE
1654 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1655
7147c4a4
PE
1656 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1657
193e32d9
PE
1658 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1659
e5533da6
PE
1660 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1661
9910e595
PE
1662 GLYPH_CODE_FACE returns EMACS_INT, not int.
1663 * dispextern.h (merge_faces):
1664 * xfaces.c (merge_faces):
01103c44
PE
1665 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1666 Don't assume EMACS_INT fits in int.
9910e595 1667
2638320e
PE
1668 * character.h (CHAR_VALID_P): Remove unused parameter.
1669 * fontset.c, lisp.h, xdisp.c: All uses changed.
1670
045eb8d9
PE
1671 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1672
c1f134b5
PE
1673 * fns.c (concat): Minor tuning based on overflow analysis.
1674 This doesn't fix any bugs. Use int to hold character, instead
1675 of constantly refetching from Emacs object. Use XFASTINT, not
1676 XINT, for value known to be a character. Don't bother comparing
1677 a single byte to 0400, as it's always less.
1678
395fcb93 1679 * floatfns.c (Fexpt):
327eeec8
PE
1680 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1681
abbd3d23
PE
1682 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1683 for characters.
1684
684a03ef
PE
1685 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1686
0fed43f3
PE
1687 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1688 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1689 incorrectly succeed when S was a string, because 4294967386 was
1690 truncated before it was used.
1691
8fd02eb7
PE
1692 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1693 Otherwise, an out-of-range integer could cause undefined behavior
1694 on a 64-bit host.
1695
f8c86b69
PE
1696 * composite.c: Use int, not EMACS_INT, for characters.
1697 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1698 EMACS_INT, for values that are known to be in character range.
1699 This doesn't fix any bugs but is the usual style inside Emacs and
1700 may generate better code on 32-bit machines.
1701
34206dd2
PE
1702 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1703 This is for reasons similar to the recent CHAR_STRING fix.
1704 * charset.c (Fencode_char): Check that character arg is actually
1705 a character. Pass an int to ENCODE_CHAR.
1706 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1707 wider than 'int', as a compile-time check to prevent future regressions
1708 in this area.
1709
c5958d4c 1710 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1711
1712 Make sure a 64-bit char is never passed to CHAR_STRING.
1713 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1714 by silently ignoring the top 32 bits, allowing some values
1715 that were far too large to be valid characters.
1716 * character.h: Include <verify.h>.
1717 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1718 arguments are no wider than unsigned, as a compile-time check
1719 to prevent future regressions in this area.
1720 * data.c (Faset):
01103c44 1721 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1722 (Fsubst_char_in_region):
1723 * fns.c (concat):
1724 * xdisp.c (decode_mode_spec_coding):
1725 Adjust to CHAR_STRING's new requirement.
1726 * editfns.c (Finsert_char, Fsubst_char_in_region):
1727 * fns.c (concat): Check that character args are actually
1728 characters. Without this test, these functions did the wrong
1729 thing with wildly out-of-range values on 64-bit hosts.
1730
d37ca623
PE
1731 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1732 These casts should not be needed on 32-bit hosts, either.
1733 * keyboard.c (read_char):
1734 * lread.c (Fload): Remove casts to unsigned.
1735
ea204efb
PE
1736 * lisp.h (UNSIGNED_CMP): New macro.
1737 This fixes comparison bugs on 64-bit hosts.
1738 (ASCII_CHAR_P): Use it.
1739 * casefiddle.c (casify_object):
01103c44 1740 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1741 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1742 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1743 * dispextern.h (FACE_FROM_ID):
1744 * keyboard.c (read_char): Use UNSIGNED_CMP.
1745
41cb286c
PE
1746 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1747 not to EMACS_INT, to avoid GCC warning.
1748
4a1b9832
PE
1749 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1750
55daad71
PE
1751 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1752 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1753 isn't needed on 32-bit machines.
8f95c75c 1754
01103c44
PE
1755 * buffer.c (Fgenerate_new_buffer_name):
1756 Use EMACS_INT for count, not int.
0ceccced 1757 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1758
1759 * data.c (Qcompiled_function): Now static.
1760
c6f072e7
PE
1761 * window.c (window_body_lines): Now static.
1762
20ce5912
PE
1763 * image.c (gif_load): Rename local to avoid shadowing.
1764
9c4c5f81
PE
1765 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1766 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1767 * alloc.c (make_save_value): Integer argument is now of type
1768 ptrdiff_t, not int.
1769 (mark_object): Use ptrdiff_t, not int.
1770 * lisp.h (pD): New macro.
1771 * print.c (print_object): Use it.
1772
c0c5c8ae
PE
1773 * alloc.c: Use EMACS_INT, not int, to count objects.
1774 (total_conses, total_markers, total_symbols, total_vector_size)
1775 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1776 (total_free_floats, total_floats, total_free_intervals)
1777 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1778 Now EMACS_INT, not int. All uses changed.
1779 (Fgarbage_collect): Compute overall total using a double, so that
1780 integer overflow is less likely to be a problem. Check for overflow
1781 when converting back to an integer.
5a25e253
PE
1782 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1783 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1784 These were 'int' variables that could overflow on 64-bit hosts;
1785 they were never used, so remove them instead of repairing them.
211a0b2a 1786 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1787 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1788 Previously, this ceilinged at INT_MAX, but that doesn't work on
1789 64-bit machines.
e46bb31a 1790 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1791
c78baabf 1792 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1793 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1794 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1795 when a (possibly-narrower) signed value would do just as well.
1796 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1797
c9d624c6
PE
1798 * alloc.c: Catch some string size overflows that we were missing.
1799 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1800 for convenience in STRING_BYTES_MAX.
1801 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1802 The definition here is exact; the one in lisp.h was approximate.
1803 (allocate_string_data): Check for string overflow. This catches
1804 some instances we weren't catching before. Also, it catches
1805 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1806 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1807 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1808
c9d624c6
PE
1809 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1810 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1811 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1812
353032ce
PE
1813 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1814
2bccce07
PE
1815 * alloc.c (Fmake_string): Check for out-of-range init.
1816
0ac30604
SM
18172011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1818
1819 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1820
c195f2de
JD
18212011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1822
1823 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1824 xg_get_default_scrollbar_width.
1825
1826 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1827 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1828 (style_changed_cb): Call update_theme_scrollbar_width and call
1829 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1830 all frames (Bug#8505).
1831 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1832 Call gtk_window_set_resizable if HAVE_GTK3.
1833 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1834 and height if HAVE_GTK3 (Bug#8505).
1835 (scroll_bar_width_for_theme): New variable.
1836 (update_theme_scrollbar_width): New function.
1837 (xg_get_default_scrollbar_width): Move code to
1838 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1839 (xg_initialize): Call update_theme_scrollbar_width.
1840
1841 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1842
1843 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1844
e10ac9f1
MR
18452011-06-12 Martin Rudalics <rudalics@gmx.at>
1846
1847 * frame.c (make_frame): Call other_buffer_safely instead of
1848 other_buffer.
1849
1850 * window.c (temp_output_buffer_show): Call display_buffer with
1851 second argument Vtemp_buffer_show_specifiers and reset latter
1852 immediately after the call.
1853 (Vtemp_buffer_show_specifiers): New variable.
1854 (auto_window_vscroll_p, next_screen_context_lines)
1855 (Vscroll_preserve_screen_position): Remove leading asterisks from
1856 doc-strings.
1857
2d3c217e 18582011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1859
7b7f97e8 1860 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1861 * buffer.c (Qclone_number): Remove for now, as it's unused.
1862 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1863 (record_buffer): Remove unused local.
1864 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1865 (set_frame_buffer_list): Remove; unused.
1866 * frame.h (other_visible_frames): Remove decl.
1867 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1868 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1869 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1870 if HAVE_GPM.
1871 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1872 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1873 Define only if HAVE_GPM.
1874 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1875 (update_hints_inhibit): Remove; never set. All uses removed.
1876 * widgetprv.h (emacsFrameClassRec): Remove decl.
1877 * window.c (delete_deletable_window): Now returns void, since it
1878 wasn't returning anything.
1879 (compare_window_configurations): Remove unused locals.
1880 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1881 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1882 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1883 the same widths as pointers. This follows up on the 2011-05-06 patch.
1884 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1885 * xterm.h: Likewise.
1886 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1887
1384b89e
JB
18882011-06-12 Juanma Barranquero <lekktu@gmail.com>
1889
1890 * makefile.w32-in: Update dependencies.
1891 (LISP_H): Add lib/intprops.h.
1892
1100a63c
CY
18932011-06-11 Chong Yidong <cyd@stupidchicken.com>
1894
1895 * image.c (gif_load): Add animation frame delay to the metadata.
1896 (syms_of_image): Use DEFSYM. New symbol `delay'.
1897
6198ccd0
MR
18982011-06-11 Martin Rudalics <rudalics@gmx.at>
1899
1900 * window.c (delete_deletable_window): Re-add.
1901 (Fset_window_configuration): Rewrite to handle dead buffers and
1902 consequently deletable windows.
1903 (window_tree, Fwindow_tree): Remove. Supply functionality in
1904 window.el.
1905 (compare_window_configurations): Simplify code.
1906
b6e3633c
AS
19072011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1908
1ab0dee5
AS
1909 * image.c (imagemagick_load_image): Fix type mismatch.
1910 (Fimagemagick_types): Likewise.
1911
b6e3633c
AS
1912 * window.h (replace_buffer_in_windows): Declare.
1913
9397e56f
MR
19142011-06-11 Martin Rudalics <rudalics@gmx.at>
1915
1916 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1917 Qclone_number. Remove external declaration of Qdelete_window.
1918 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1919 code.
1920 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1921 Qbuffer_list_update_hook if allowed.
1922 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1923 buffer list implementation.
1924 (other_buffer_safely): New function.
1925 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1926 calls to replace_buffer_in_windows and
1927 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1928 if allowed.
1929 (record_buffer): Inhibit quitting and rewrite using quittable
1930 functions. Run Qbuffer_list_update_hook if allowed.
1931 (Frecord_buffer, Funrecord_buffer): New functions.
1932 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1933 switch-to-buffer to window.el.
1934 (bury-buffer): Move to window.el.
1935 (Vbuffer_list_update_hook): New variable.
1936
1937 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1938 section.
1939
1940 * window.h (resize_frame_windows): Move up in code.
1941 (Fwindow_frame): Remove EXFUN.
1942 (replace_buffer_in_all_windows): Remove prototype.
1943 (replace_buffer_in_windows_safely): Add prototype.
1944
1945 * window.c: Declare Qdelete_window static again. Move down
1946 declaration of select_count.
1947 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1948 (Fother_window): Move to window.el.
1949 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1950 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1951 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1952 window.el.
1953 (replace_buffer_in_windows): Implement by calling
1954 Qreplace_buffer_in_windows.
1955 (replace_buffer_in_all_windows): Remove with some functionality
1956 moved into replace_buffer_in_windows_safely.
1957 (replace_buffer_in_windows_safely): New function.
1958 (select_window_norecord, select_frame_norecord): Move in front
1959 of run_window_configuration_change_hook. Remove now obsolete
1960 declarations.
1961 (Fset_window_buffer): Rewrite doc-string. Call
1962 Qrecord_window_buffer.
1963 (keys_of_window): Move binding for other-window to window.el.
1964
b50691aa
CY
19652011-06-11 Chong Yidong <cyd@stupidchicken.com>
1966
1967 * dispextern.h (struct image): Replace data member, whose int_val
1968 and ptr_val fields were not used by anything, with a single
1969 lisp_val object.
1970
1971 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1972 (gif_clear_image, gif_load, imagemagick_load_image)
1973 (gs_clear_image, gs_load): Callers changed.
1974
3f754b86
PE
19752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1976
cca69397
PE
1977 * buffer.h: Include <time.h>, for time_t.
1978 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1979
109e28d0
PE
1980 Fix minor problems found by static checking.
1981
60737f02
PE
1982 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1983
4b66faf3
PE
1984 Make identifiers static if they are not used in other modules.
1985 * data.c (Qcompiled_function, Qframe, Qvector):
1986 * image.c (QimageMagick, Qsvg):
1987 * minibuf.c (Qmetadata):
1988 * window.c (resize_window_check, resize_root_window): Now static.
1989 * window.h (resize_window_check, resize_root_window): Remove decls.
1990
109e28d0
PE
1991 * window.c (window_deletion_count, delete_deletable_window):
1992 Remove; unused.
46a4ce9e
PE
1993 (window_body_lines): Now static.
1994 (Fdelete_other_windows_internal): Mark vars as initialized.
1995 Make sure 'resize_failed' is initialized.
1996 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1997 (resize_window_apply): Remove unused local.
1998 * window.h (delete_deletable_window): Remove decl.
1999
109e28d0 2000 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2001 (imagemagick_load_image): Fix pointer signedness problem by changing
2002 last arg from unsigned char * to char *. All uses changed.
2003 Also, fix a local for similar reasons.
2004 Remove unused locals. Remove locals to avoid shadowing.
2005 (fn_rsvg_handle_free): Remove; unused.
2006 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2007 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2008
3f754b86
PE
2009 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2010
2547adb1
CY
20112011-06-10 Chong Yidong <cyd@stupidchicken.com>
2012
2013 * image.c (gif_load): Fix omitted cast error introduced by
2014 2011-06-06 change.
2015
2c8e37d4
MR
20162011-06-10 Martin Rudalics <rudalics@gmx.at>
2017
2018 * window.h (resize_proportionally, orig_total_lines)
2019 (orig_top_line): Remove from window structure.
2020 (set_window_height, set_window_width, change_window_heights)
2021 (Fdelete_window): Remove prototypes.
2022 (resize_frame_windows): Remove duplicate declaration.
2023
440a42e3
EZ
20242011-06-10 Eli Zaretskii <eliz@gnu.org>
2025
2026 * window.h (resize_frame_windows, resize_window_check)
2027 (delete_deletable_window, resize_root_window)
2028 (resize_frame_windows): Declare prototypes.
2029
2030 * window.c (resize_window_apply): Make definition be "static" to
2031 match the prototype.
2032
562dd5e9
MR
20332011-06-10 Martin Rudalics <rudalics@gmx.at>
2034
2035 * window.c: Remove declarations of Qwindow_size_fixed,
2036 window_min_size_1, window_min_size_2, window_min_size,
2037 size_window, window_fixed_size_p, enlarge_window, delete_window.
2038 Remove static from declaration of Qdelete_window, it's
2039 temporarily needed by Fbury_buffer.
2040 (replace_window): Don't assign orig_top_line and
2041 orig_total_lines.
2042 (Fdelete_window, delete_window): Remove. Window deletion is
2043 handled by window.el.
2044 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2045 Fdelete_window calls with calls to Qdelete_window.
2046 (Fdelete_other_windows): Remove. Deleting other windows is
2047 handled by window.el.
2048 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2049 handled in window.el.
2050 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2051 Window minimum sizes are handled in window.el.
2052 (shrink_windows, size_window, set_window_height)
2053 (set_window_width, change_window_heights, window_height)
2054 (window_width, CURBEG, CURSIZE, enlarge_window)
2055 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2056 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2057 handled in window.el.
2058 (make_dummy_parent): Rename to make_parent_window and give it a
2059 second argument horflag.
2060 (make_window): Don't set resize_proportionally any more.
2061 (Fsplit_window): Remove. Windows are split in window.el.
2062 (save_restore_action, save_restore_orig_size)
2063 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2064 Resize mini windows in window.el.
2065 (grow_mini_window, shrink_mini_window): Implement by calling
2066 Qresize_root_window_vertically, resize_window_check and
2067 resize_window_apply.
2068 (saved_window, Fset_window_configuration, save_window_save): Do
2069 not handle orig_top_line, orig_total_lines, and
2070 resize_proportionally.
2071 (window_min_height, window_min_width): Move to window.el.
2072 (keys_of_window): Move bindings for delete-other-windows,
2073 split-window, delete-window and enlarge-window to window.el.
2074
2075 * buffer.c: Temporarily extern Qdelete_window.
2076 (Fbury_buffer): Temporarily call Qdelete_window instead of
2077 Fdelete_window (Fbury_buffer will move to window.el soon).
2078
2079 * frame.c (set_menu_bar_lines_1): Remove code handling
2080 orig_top_line and orig_total_lines.
2081
2082 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2083 set_window_height but set heights directly.
2084 (change_frame_size_1): Use resize_frame_windows.
2085
2086 * xdisp.c (init_xdisp): Don't use set_window_height but set
2087 heights directly.
2088
2089 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2090 resize_frame_windows instead of change_window_heights and run
2091 run_window_configuration_change_hook.
2092
2093 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2094 instead of change_window_heights and run
2095 run_window_configuration_change_hook.
2096
1a13852e
MR
20972011-06-09 Martin Rudalics <rudalics@gmx.at>
2098
2099 * window.c (replace_window): Rename second argument REPLACEMENT to
2100 NEW. New third argument SETFLAG. Rewrite.
2101 (delete_window, make_dummy_parent): Call replace_window with
2102 third argument 1.
2103 (window_list_1): Move down in code.
2104 (run_window_configuration_change_hook): Move set_buffer part
2105 before select_frame_norecord part in order to unwind correctly.
2106 Rename count1 to count.
2107 (recombine_windows, delete_deletable_window, resize_root_window)
2108 (Fdelete_other_windows_internal)
2109 (Frun_window_configuration_change_hook, make_parent_window)
2110 (resize_window_check, resize_window_apply, Fresize_window_apply)
2111 (resize_frame_windows, Fsplit_window_internal)
2112 (Fdelete_window_internal, Fresize_mini_window_internal): New
2113 functions.
2114 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2115
f3d1777e
MR
21162011-06-08 Martin Rudalics <rudalics@gmx.at>
2117
496e208e
MR
2118 * window.h (window): Add some new members to window structure -
2119 normal_lines, normal_cols, new_total, new_normal, clone_number,
2120 splits, nest, prev_buffers, next_buffers.
2121 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2122 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2123
f3d1777e
MR
2124 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2125 Remove.
496e208e
MR
2126 (make_dummy_parent): Set new members of windows structure.
2127 (make_window): Move down in code. Handle new members of window
2128 structure.
2129 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2130 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2131 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2132 (Fset_window_prev_buffers, Fwindow_next_buffers)
2133 (Fset_window_next_buffers, Fset_window_clone_number): New
2134 functions.
2135 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2136 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2137 Doc-string fixes.
2138 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2139 Argument WINDOW can be now internal window too.
2140 (Fwindow_use_time): Move up in code.
2141 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2142 Rewrite doc-string.
2143 (Fset_window_configuration, saved_window)
2144 (Fcurrent_window_configuration, save_window_save): Handle new
2145 members of window structure.
b9e809c2
MR
2146 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2147 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2148 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2149 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2150 Qget_mru_window, Qresize_root_window,
2151 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2152 Qauto_buffer_name; staticpro them.
f3d1777e 2153
abde8f8c
MR
21542011-06-07 Martin Rudalics <rudalics@gmx.at>
2155
2156 * window.c (Fwindow_total_size, Fwindow_left_column)
2157 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2158 (Fwindow_list_1): New functions.
2159 (window_box_text_cols): Replace with window_body_cols.
2160 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2161 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2162 (delete_window, Fset_window_configuration): Call
2163 delete_all_subwindows with window as argument.
2164 (delete_all_subwindows): Take a window as argument and not a
2165 structure. Rewrite.
190b47e6
MR
2166 (window_loop): Remove handling of GET_LRU_WINDOW and
2167 GET_LARGEST_WINDOW.
2168 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2169
2170 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2171 window_box_text_cols. delete_all_subwindows now takes a
2172 Lisp_Object as argument.
abde8f8c
MR
2173
2174 * indent.c (compute_motion, Fcompute_motion): Use
2175 window_body_cols instead of window_box_text_cols.
2176
fa8a67e6
MR
2177 * frame.c (delete_frame): Call delete_all_subwindows with root
2178 window as argument.
2179
a54e3482
DC
21802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2181
2182 * fns.c (Fputhash): Document return value.
2183
60002bf5
CY
21842011-06-06 Chong Yidong <cyd@stupidchicken.com>
2185
2186 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2187
0c671da6 21882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2189
b862a52a 2190 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2191
be44ca6c
PE
2192 Check for overflow when converting integer to cons and back.
2193 * charset.c (Fdefine_charset_internal, Fdecode_char):
2194 Use cons_to_unsigned to catch overflow.
2195 (Fencode_char): Use INTEGER_TO_CONS.
2196 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2197 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2198 * data.c (long_to_cons, cons_to_long): Remove.
2199 (cons_to_unsigned, cons_to_signed): New functions.
2200 These signal an error for invalid or out-of-range values.
2201 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2202 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2203 * font.c (Ffont_variation_glyphs):
2204 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2205 * lisp.h: Include <intprops.h>.
2206 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2207 (cons_to_signed, cons_to_unsigned): New decls.
2208 (long_to_cons, cons_to_long): Remove decls.
2209 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2210 (Fprimitive_undo): Use CONS_TO_INTEGER.
2211 * xfns.c (Fx_window_property): Likewise.
2212 * xselect.c: Include <limits.h>.
2213 (x_own_selection, selection_data_to_lisp_data):
2214 Use INTEGER_TO_CONS.
2215 (x_handle_selection_request, x_handle_selection_clear)
2216 (x_get_foreign_selection, Fx_disown_selection_internal)
2217 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2218 (lisp_data_to_selection_data): Use cons_to_unsigned.
2219 (x_fill_property_data): Use cons_to_signed.
2220 Report values out of range.
2221
d1f3d2af
PE
2222 Check for buffer and string overflow more precisely.
2223 * buffer.h (BUF_BYTES_MAX): New macro.
2224 * lisp.h (STRING_BYTES_MAX): New macro.
2225 * alloc.c (Fmake_string):
2226 * character.c (string_escape_byte8):
2227 * coding.c (coding_alloc_by_realloc):
2228 * doprnt.c (doprnt):
2229 * editfns.c (Fformat):
2230 * eval.c (verror):
2231 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2232 since they may not be the same number.
2233 * editfns.c (Finsert_char):
2234 * fileio.c (Finsert_file_contents):
2235 Likewise for BUF_BYTES_MAX.
2236
dd52fcea
PE
2237 * image.c: Use ptrdiff_t, not int, for sizes.
2238 (slurp_file): Switch from int to ptrdiff_t.
2239 All uses changed.
2240 (slurp_file): Check that file size fits in both size_t (for
2241 malloc) and ptrdiff_t (for sanity and safety).
2242
7f9bbdbb
PE
2243 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2244 if b->modtime has its maximal value.
2245
dfe18f82
PE
2246 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2247
84acfcf0
PE
2248 Don't assume time_t can fit into int.
2249 * buffer.h (struct buffer.modtime): Now time_t, not int.
2250 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2251 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2252
ccd9a01a
PE
2253 Minor fixes for signed vs unsigned integers.
2254 * character.h (MAYBE_UNIFY_CHAR):
2255 * charset.c (maybe_unify_char):
2256 * keyboard.c (read_char, reorder_modifiers):
2257 XINT -> XFASTINT, since the integer must be nonnegative.
2258 * ftfont.c (ftfont_spec_pattern):
2259 * keymap.c (access_keymap, silly_event_symbol_error):
2260 XUINT -> XFASTINT, since the integer must be nonnegative.
2261 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2262 since it makes no difference and we prefer signed.
2263 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2264 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2265 nonnegative.
2266
d6d100dd
SM
22672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2268
2269 * window.h (Fwindow_frame): Declare.
2270
2b6148e4
PE
22712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2274 (SPARE_MEMORY): Always define.
2275 (LARGE_REQUEST): Remove.
2276 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2277
f230ecc9
MR
22782011-06-06 Martin Rudalics <rudalics@gmx.at>
2279
727e958e
MR
2280 * lisp.h: Move EXFUNS for Fframe_root_window,
2281 Fframe_first_window and Fset_frame_selected_window to window.h.
2282
2283 * window.h: Move EXFUNS for Fframe_root_window,
2284 Fframe_first_window and Fset_frame_selected_window here from
2285 lisp.h.
2286
2287 * frame.c (Fwindow_frame, Fframe_first_window)
2288 (Fframe_root_window, Fframe_selected_window)
2289 (Fset_frame_selected_window): Move to window.c.
2290 (Factive_minibuffer_window): Move to minibuf.c.
2291 (Fother_visible_frames_p): New function.
2292
2293 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2294
f230ecc9
MR
2295 * window.c (decode_window, decode_any_window): Move up in code.
2296 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2297 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2298 (Fwindow_buffer): Move up and rewrite doc-string.
2299 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2300 (Fwindow_prev): New functions.
727e958e
MR
2301 (Fwindow_frame): Move here from frame.c. Accept any window as
2302 argument.
2303 (Fframe_root_window, Fframe_first_window)
2304 (Fframe_selected_window): Move here from frame.c. Accept frame
2305 or arbitrary window as argument. Update doc-strings.
2306 (Fminibuffer_window): Move up in code.
2307 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2308 (Fset_frame_selected_window): Move here from frame.c.
2309 Marginal rewrite.
727e958e
MR
2310 (Fselected_window, select_window, Fselect_window): Move up in
2311 code. Minor doc-string fixes.
f230ecc9 2312
4d09bcf6
PE
23132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2316 Do not assume that spare memory exists; that assumption is valid
2317 only if SYSTEM_MALLOC.
2318 (LARGE_REQUEST): New macro, so that the issue of large requests
2319 is separated from the issue of spare memory.
2320
810928a2
AS
23212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2322
172418ad
AS
2323 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2324 format. (Bug#8806)
2325
43f862f7
AS
2326 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2327
810928a2
AS
2328 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2329 before statements.
2330
a059fe24
JD
23312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2332
2333 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2334
2335 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2336
2337 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2338 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2339
989bf368
JB
23402011-06-05 Juanma Barranquero <lekktu@gmail.com>
2341
2342 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2343
4b80f674
CY
23442011-06-04 Chong Yidong <cyd@stupidchicken.com>
2345
2346 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2347 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2348 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2349 New error handlers.
4b80f674
CY
2350 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2351 Obey Vx_select_enable_clipboard_manager. Catch errors in
2352 x_clipboard_manager_save (Bug#8779).
2353 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2354 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2355
99a33b77 23562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2357
2358 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2359
99a33b77 23602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2361
2362 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2363 in the current matrix if keep_current_p is non-zero.
2364
8264569d
EZ
23652011-06-04 Eli Zaretskii <eliz@gnu.org>
2366
2367 * bidi.c (bidi_level_of_next_char): Fix last change.
2368
57f97249
EZ
23692011-06-03 Eli Zaretskii <eliz@gnu.org>
2370
fec2107c 2371 Support bidi reordering of text covered by display properties.
57f97249 2372
fec2107c
EZ
2373 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2374 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2375 (bidi_cache_search, bidi_cache_iterator_state)
2376 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2377 (bidi_level_of_next_char, bidi_move_to_visually_next):
2378 Support character positions inside a run of characters covered by a
fec2107c
EZ
2379 display string.
2380 (bidi_paragraph_init, bidi_resolve_explicit_1)
2381 (bidi_level_of_next_char): Call bidi_fetch_char and
2382 bidi_fetch_char_advance instead of FETCH_CHAR and
2383 FETCH_CHAR_ADVANCE.
2384 (bidi_init_it): Initialize new members.
2385 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2386 definitions.
2387 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2388 instead of using explicit *_CHAR codes.
d6d100dd
SM
2389 (bidi_resolve_explicit, bidi_resolve_weak):
2390 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2391 bidirectional text is supported only in multibyte buffers.
2392 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2393 it to initialize the frame_window_p member of struct bidi_it.
2394 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2395 (bidi_resolve_explicit, bidi_resolve_weak)
2396 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2397 bidi_it->nchars is non-positive.
2398 (bidi_level_of_next_char): Don't try to lookup the cache for the
2399 next/previous character if nothing is cached there yet, or if we
2400 were just reseat()'ed to a new position.
c40e2fb2 2401
0e14fe90
EZ
2402 * xdisp.c (set_cursor_from_row): Set start and stop points
2403 according to the row's direction when priming the loop that looks
2404 for the glyph on which to display cursor.
2405 (single_display_spec_intangible_p): Function deleted.
2406 (display_prop_intangible_p): Reimplement to call
2407 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2408 Accept 3 additional arguments needed by handle_display_spec.
2409 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2410 values: lists, `(when COND...)' forms, etc.
2411 (single_display_spec_string_p): Support property values that are
2412 lists with the argument STRING its top-level element.
2413 (display_prop_string_p): Fix the condition for processing a
2414 property that is a list to be consistent with handle_display_spec.
fec2107c 2415 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2416 last portion of handle_display_prop.
2417 (compute_display_string_pos): Accept additional argument
2418 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2419 value of a `display' property is a "replacing spec".
2420 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2421 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2422 the display property, but just return a value indicating whether
2423 the display property will replace the characters it covers.
2424 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2425 frame_window_p members of struct bidi_it.
d6d100dd
SM
2426 (compute_display_string_pos, compute_display_string_end):
2427 New functions.
fec2107c
EZ
2428 (push_it): Accept second argument POSITION, where pop_it should
2429 jump to continue iteration.
2430 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2431
fec2107c
EZ
2432 * keyboard.c (adjust_point_for_property): Adjust the call to
2433 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2434
2435 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2436 (bidi_init_it): Update prototypes.
2437 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2438 (compute_display_string_pos, compute_display_string_end):
2439 Declare prototypes.
fec2107c
EZ
2440 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2441 EMACS_INT.
fc6f18ce 2442
40087514 24432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2444
57f53182
PE
2445 Malloc failure behavior now depends on size of allocation.
2446 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2447 * lisp.h: Change signatures accordingly.
2448 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2449 All callers changed. (Bug#8762)
2450
2451 * gnutls.c: Use Emacs's memory allocators.
2452 Without this change, the gnutls library would invoke malloc etc.
2453 directly, which causes problems on non-SYNC_INPUT hosts, and which
2454 runs afoul of improving memory_full behavior. (Bug#8761)
2455 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2456 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2457 xfree instead of the default malloc, realloc, free.
2458 (Fgnutls_boot): No need to check for memory allocation failure,
2459 since xmalloc does that for us.
2460
ac32cd99 2461 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2462 * category.c (hash_get_category_set):
2463 * ccl.c (ccl_driver):
2464 * charset.c (Fdefine_charset_internal):
2465 * charset.h (struct charset.hash_index):
2466 * composite.c (get_composition_id, gstring_lookup_cache)
2467 (composition_gstring_put_cache):
2468 * composite.h (struct composition.hash_index):
2469 * dispextern.h (struct image.hash):
2470 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2471 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2472 (hashfn_equal, hashfn_user_defined, make_hash_table)
2473 (maybe_resize_hash_table, hash_lookup, hash_put)
2474 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2475 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2476 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2477 * image.c (make_image, search_image_cache, lookup_image)
2478 (xpm_put_color_table_h):
2479 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2480 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2481 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2482 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2483 * alloc.c (allocate_vectorlike):
2484 Check for overflow in vector size calculations.
2485 * ccl.c (ccl_driver):
2486 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2487 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2488 need to be updated by these changes.
40087514
PE
2489 * fns.c (make_hash_table, maybe_resize_hash_table):
2490 Check for integer overflow with large hash tables.
0de4bb68
PE
2491 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2492 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2493 (SXHASH_REDUCE): New macro.
2494 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2495 Use it instead of discarding useful hash info with large hash values.
2496 (sxhash_float): New function.
2497 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2498 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2499 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2500 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2501 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2502 Adjust signatures to match updated version of code.
2503 (consing_since_gc): Now EMACS_INT, since a single hash table can
2504 use more than INT_MAX bytes.
2505
698d32e2
DN
25062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2507
2508 Make it possible to build with GCC-4.6+ -O2 -flto.
2509
2510 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2511
fd6fa53f
SM
25122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2513
2514 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2515 Call minibuffer-inactive-mode.
2516
864db017
JB
25172011-05-31 Juanma Barranquero <lekktu@gmail.com>
2518
2519 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2520 Update dependencies.
2521
2ad0baf4
DN
25222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2523
2524 * data.c (init_data): Remove code for UTS, this system is not
2525 supported anymore.
2526
4fcc2638
DN
25272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2528
2529 Don't force ./temacs to start in terminal mode.
2530
2531 * frame.c (make_initial_frame): Initialize faces in all cases, not
2532 only when CANNOT_DUMP is defined.
2533 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2534
c56e0fd5
DN
25352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2536
2537 * dispnew.c (add_window_display_history): Use const for the string
2538 pointer. Remove declaration, not needed.
2539
333d54da 25402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2541
55d4c1b2 2542 Use 'inline', not 'INLINE'.
333d54da 2543 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2544 * alloc.c, fontset.c (INLINE): Remove.
2545 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2546 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2547 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2548 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2549 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2550
738db178
DN
25512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2552
2553 Make it possible to run ./temacs.
2554
2555 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2556 syms_of_callproc does the same thing. Remove test for
2557 "initialized", do it in the caller.
2558 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2559
620c53a6
SM
25602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2561
2562 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2563 (read_minibuf): Use get_minibuffer.
2564 (syms_of_minibuf): Use DEFSYM.
2565 (Qmetadata): New var.
2566 * data.c (Qbuffer): Don't make it static.
2567 (syms_of_data): Use DEFSYM.
2568
e003a292
PE
25692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2570
2571 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2572 (CCL_CODE_MIN): New macro.
2573
ed008a6d
PE
25742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2575
3687c2ef
PE
2576 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2577
ed008a6d
PE
2578 * eval.c (Qdebug): Now static.
2579 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2580 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2581 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2582
d66c4c7c
CY
25832011-05-29 Chong Yidong <cyd@stupidchicken.com>
2584
2585 * image.c: Various fixes to ImageMagick code comments.
2586 (Fimagemagick_types): Doc fix.
2587
5fbc2025
PE
25882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2589
0196f88a
PE
2590 Minor fixes prompted by GCC 4.6.0 warnings.
2591
2592 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2593
5fbc2025
PE
2594 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2595 (x_clipboard_manager_save_all): Move extern decl to ...
2596 * xterm.h: ... here, so that it can be checked for consistency.
2597
1dd3c2d9
CY
25982011-05-29 Chong Yidong <cyd@stupidchicken.com>
2599
2600 * xselect.c (x_clipboard_manager_save_frame)
2601 (x_clipboard_manager_save_all): New functions.
2602 (Fx_clipboard_manager_save): Lisp function deleted.
2603
2604 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2605 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2606
2607 * xterm.h: Update prototype.
2608
5ba6571d
WX
26092011-05-28 William Xu <william.xwl@gmail.com>
2610
2611 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2612 exiting (Bug#8239).
2613
3eaff834
JM
26142011-05-28 Jim Meyering <meyering@redhat.com>
2615
e1900994 2616 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2617 * fns.c (to_uchar): Define.
2618 (crypto_hash_function): Use it to convert some newly-signed
2619 variables to unsigned, to avoid sign-extension bugs. For example,
2620 without this change, (md5 "truc") would evaluate to
2621 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2622 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2623 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2624
0f6990a7
PE
26252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2626
2627 Integer overflow fixes.
c8a9ca5a 2628
08686060
PE
2629 * dbusbind.c: Serial number integer overflow fixes.
2630 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2631 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2632 to hold a serial number that is too large for a fixnum.
2633 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2634 Check for serial numbers out of range. Decode any serial number
59568bf0 2635 that was so large that it became a float. (Bug#8722)
08686060 2636
2d1fc3c7
PE
2637 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2638 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2639 Use XFASTINT rather than XUINT when numbers are nonnegative.
2640 (xd_append_arg, Fdbus_method_return_internal):
2641 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2642 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2643 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2644 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2645 (Bug#8722)
2d1fc3c7 2646
c8a9ca5a
PE
2647 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2648
519e1d69
PE
2649 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2650
30569699
PE
2651 ccl: add integer overflow checks
2652 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2653 (IN_INT_RANGE): New macros.
2654 (ccl_driver): Use them to check for integer overflow when
2655 decoding a CCL program. Many of the new checks are whether XINT (x)
2656 fits in int; it doesn't always, on 64-bit hosts. The new version
2657 doesn't catch all possible integer overflows, but it's an
847044ea 2658 improvement. (Bug#8719)
30569699 2659
c11285dc
PE
2660 * alloc.c (make_event_array): Use XINT, not XUINT.
2661 There's no need for unsigned here.
2662
fdccd48e
PE
2663 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2664 This follows up to the 2011-05-06 change that substituted uintptr_t
2665 for EMACS_INT. This case wasn't caught back then.
2666
37910ab2
PE
2667 Rework Fformat to avoid integer overflow issues.
2668 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2669 now (part of C89). Include <verify.h>.
2670 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2671 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2672 (Fformat): Avoid the prepass trying to compute sizes; it was only
2673 approximate and thus did not catch overflow reliably. Instead, walk
2674 through the format just once, formatting and computing sizes as we go,
2675 checking for integer overflow at every step, and allocating a larger
2676 buffer as needed. Keep track separately whether the format is
2677 multibyte. Keep only the most-recently calculated precision, rather
2678 than them all. Record whether each argument has been converted to
2679 string. Use EMACS_INT, not int, for byte and char and arg counts.
2680 Support field widths and precisions larger than INT_MAX. Avoid
2681 sprintf's undefined behavior with conversion specifications such as %#d
2682 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2683 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2684 formatting out-of-range floating point numbers with int
9173deec 2685 formats. (Bug#8668)
37910ab2 2686
2e6578fb
PE
2687 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2688
0ae6bdee
PE
2689 * data.c: Avoid integer truncation in expressions involving floats.
2690 * data.c: Include <intprops.h>.
2691 (arith_driver): When there's an integer overflow in an expression
2692 involving floating point, convert the integers to floating point
2693 so that the resulting value does not suffer from catastrophic
2694 integer truncation. For example, on a 64-bit host (* 4
2695 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2696 Do not rely on undefined behavior after integer overflow.
2697
de883a70
PE
2698 merge count_size_as_multibyte, parse_str_to_multibyte
2699 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2700 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2701 Check for integer overflow.
2702 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2703 since it's now a duplicate of the other. This is more of
2704 a character than a buffer op, so better that it's in character.c.
2705 * fns.c, print.c: Adjust to above changes.
2706
2ff916cb
PE
27072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2708
2709 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2710
f1b54466
PE
27112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2712
fb1ac845
PE
2713 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2714 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2715 (x_clipboard_manager_save): Now static.
2716 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2717
f1b54466
PE
2718 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2719 (crypto_hash_function): Now static.
2720 Fix pointer signedness problems. Avoid unnecessary initializations.
2721
a9f737ee
CY
27222011-05-27 Chong Yidong <cyd@stupidchicken.com>
2723
2724 * termhooks.h (Vselection_alist): Make it terminal-local.
2725
2726 * terminal.c (create_terminal): Initialize it.
2727
2728 * xselect.c: Support for clipboard managers.
2729 (Vselection_alist): Move to termhooks.h as terminal-local var.
2730 (LOCAL_SELECTION): New macro.
2731 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2732 (symbol_to_x_atom): Remove gratuitous arg.
2733 (x_handle_selection_request, lisp_data_to_selection_data)
2734 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2735 (x_own_selection, x_get_local_selection, x_convert_selection):
2736 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2737 (some_frame_on_display): Delete unused function.
2738 (Fx_own_selection_internal, Fx_get_selection_internal)
2739 (Fx_disown_selection_internal, Fx_selection_owner_p)
2740 (Fx_selection_exists_p): New optional frame arg.
2741 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2742 (x_handle_selection_clear): Don't treat other terminals with the
2743 same keyboard specially. Use the terminal-local Vselection_alist.
2744 (x_clear_frame_selections): Use Frun_hook_with_args.
2745
2746 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2747
2748 * xterm.h: Add support for those atoms.
2749
e067f0c1
CY
27502011-05-26 Chong Yidong <cyd@stupidchicken.com>
2751
2752 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2753 (converted_selections, conversion_fail_tag): New global variables.
2754 (x_selection_request_lisp_error): Free the above.
2755 (x_get_local_selection): Remove unnecessary code.
2756 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2757 of converted selections stored in converted_selections.
2758 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2759 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2760 (x_convert_selection): New function.
2761 (x_handle_selection_event): Simplify.
2762 (x_get_foreign_selection): Don't ignore incoming requests while
2763 waiting for an answer; this will fail when we implement
2764 SAVE_TARGETS, and seems unnecessary anyway.
2765 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2766 (Vx_sent_selection_functions): Doc fix.
2767
0f4aebc0
LL
27682011-05-26 Leo Liu <sdl.web@gmail.com>
2769
2770 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2771
e61124cd
YM
27722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2773
2774 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2775
2776 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2777 for fringe update if it has periodic bitmap.
ac389d0c 2778 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2779 and fringe_bitmap_periodic_p.
2780
2781 * fringe.c (get_fringe_bitmap_data): New function.
2782 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2783 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2784 row. Mark glyph row for fringe update if periodicity changed.
2785
2786 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2787 for fringe update unless it has periodic bitmap.
2788
f16d9837
KH
27892011-05-25 Kenichi Handa <handa@m17n.org>
2790
2791 * xdisp.c (get_next_display_element): Set correct it->face_id for
2792 a static composition.
2793
e1b90ef6
LL
27942011-05-24 Leo Liu <sdl.web@gmail.com>
2795
2796 * deps.mk (fns.o):
2797 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2798
2799 * fns.c (crypto_hash_function, Fsha1): New function.
2800 (Fmd5): Use crypto_hash_function.
2801 (syms_of_fns): Add Ssha1.
2802
7400048f
PE
28032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 * gnutls.c: Remove unused macros.
2806 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2807 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2808 Remove macros that are defined and never used.
2809 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2810
abb71cf4
CY
28112011-05-22 Chong Yidong <cyd@stupidchicken.com>
2812
2813 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2814 (Fx_get_selection_internal): Minor cleanup.
2815 (Fx_own_selection_internal): Rename arguments for consistency with
2816 select.el.
2817
6307db39
PE
28182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2819
2820 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2821
f3d4e0a4
CY
28222011-05-22 Chong Yidong <cyd@stupidchicken.com>
2823
2824 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2825
4d8ade89
YM
28262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2827
2828 * dispnew.c (scrolling_window): Don't exclude the case that the
2829 last enabled row in the desired matrix touches the bottom boundary.
2830
32078c8d
GM
28312011-05-21 Glenn Morris <rgm@gnu.org>
2832
2833 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2834 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2835 and add some more files.
32078c8d 2836
7285dc67
EZ
28372011-05-20 Eli Zaretskii <eliz@gnu.org>
2838
2839 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2840 report_file_error introduced by the change from 2011-05-07.
2841
89d1bd22
PE
28422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2843
2844 * systime.h (Time): Define only if emacs is defined.
2845 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2846 where the include path doesn't have X11/X.h by default. See
2847 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2848
e23640bb 28492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2850
2851 * composite.c (find_automatic_composition): Fix previous change.
2852
b9704ad9
GM
28532011-05-20 Glenn Morris <rgm@gnu.org>
2854
2855 * lisp.mk: New file, split from Makefile.in.
2856 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2857 (shortlisp): Remove.
2858 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2859
4a720484
GM
28602011-05-19 Glenn Morris <rgm@gnu.org>
2861
2862 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2863 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2864 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2865 (lisp): Set the order to that of loadup.el.
2866 (shortlisp): Make it a copy of $lisp.
2867 (SOME_MACHINE_LISP): Remove.
2868 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2869 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2870
a28d4396
KH
28712011-05-18 Kenichi Handa <handa@m17n.org>
2872
2873 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2874 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2875 (find_automatic_composition): Mostly rewrite for efficiency.
2876
a2b1fa8e
JB
28772011-05-18 Juanma Barranquero <lekktu@gmail.com>
2878
2879 * makefile.w32-in: Update dependencies.
2880
8e1f5610
CS
28812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2882
2883 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2884 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2885
7025ee00 28862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2887
cdfa6eab
PE
2888 Fix some integer overflow issues, such as string length overflow.
2889
06d6db33
PE
2890 * insdel.c (count_size_as_multibyte): Check for string overflow.
2891
2b4560a8
PE
2892 * character.c (lisp_string_width): Check for string overflow.
2893 Use EMACS_INT, not int, for string indexes and lengths; in
2894 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2895 the resulting string length overflows an EMACS_INT; instead,
2896 report a string overflow if no precision given. When checking for
2897 precision exhaustion, use a check that cannot possibly have
2898 integer overflow. (Bug#8675)
2899 * character.h (lisp_string_width): Adjust to new signature.
2900
cb93f9be
PE
2901 * alloc.c (string_overflow): New function.
2902 (Fmake_string): Use it. This doesn't change behavior, but saves
2903 a few bytes and will simplify future changes.
2904 * character.c (string_escape_byte8): Likewise.
2905 * lisp.h (string_overflow): New decl.
2906
1a1f3366
PE
2907 Fixups, following up to the user-interface timestamp change.
2908 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2909 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2910 * msdos.c (mouse_get_pos): Likewise.
2911 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2912 * w32gui.h (Time): Define by including "systime.h" rather than by
2913 declaring it ourselves. (Bug#8664)
2914
d4e3e4d3
PE
2915 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2916 * image.c (clear_image_cache): Likewise.
2917
f6a24d19
PE
2918 * term.c (term_mouse_position): Don't assume time_t wraparound.
2919
08dc5ae6
PE
2920 Be more systematic about user-interface timestamps.
2921 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2922 and sometimes 'EMACS_UINT', to represent these timestamps.
2923 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2924 This makes the code easier to follow, and makes it easier to catch
2925 integer overflow bugs such as Bug#8664.
2926 * frame.c (Fmouse_position, Fmouse_pixel_position):
2927 Use Time, not unsigned long, for user-interface timestamps.
2928 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2929 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2930 * keyboard.h (last_event_timestamp): Likewise.
2931 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2932 * menu.h (xmenu_show): Likewise.
2933 * term.c (term_mouse_position): Likewise.
2934 * termhooks.h (struct input_event.timestamp): Likewise.
2935 (struct terminal.mouse_position_hook): Likewise.
2936 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2937 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2938 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2939 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2940 what it was before.
2941 * menu.h, termhooks.h: Include "systime.h", for Time.
2942
8e55734a
PE
2943 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2944 Don't assume that the difference between two unsigned long values
2945 can fit into an integer. At this point, we know button_down_time
2946 <= event->timestamp, so the difference must be nonnegative, so
2947 there's no need to cast the result if double-click-time is
2948 nonnegative, as it should be; check that it's nonnegative, just in
2949 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2950 apart (about 25 days). (Bug#8664)
8e55734a 2951
841f1b75 2952 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2953 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2954
3e26f69c
PE
2955 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2956 that always fit in int. Use a sentinel instead of a counter, to
2957 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2958 * frame.h (struct frame): Use int for menu_bar_items_used
2959 instead of EMACS_INT, since it always fits in int.
3e26f69c 2960
5cc152c0
PE
2961 * menu.c (grow_menu_items): Check for int overflow.
2962
d89eb65e
PE
2963 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2964
5235bd3e
PE
2965 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2966 Before, the code was not consistent. These values cannot exceed
2967 2**31 - 1 so there's no need to make them unsigned.
2968 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2969 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2970 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2971 as modifiers.
2972 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2973
bc827e23
PE
2974 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2975 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2976 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2977 presumably because the widths might not match.
2978
78eb494e
PE
2979 * window.c (size_window): Avoid needless test at loop start.
2980
04f2d78b
CB
29812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2982
2983 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2984
d2fc7e3d 29852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2986
2987 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2988
d2fc7e3d 29892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2990
2991 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2992 `width' to `bar_area_x' and `bar_area_width', respectively.
2993 (x_scroll_run): Take account of fringe background extension.
2994
04f2d78b
CB
2995 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2996 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2997 `bar_area_width', respectively.
2998 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2999 background extension.
3000
79b70037
GM
30012011-05-10 Jim Meyering <meyering@redhat.com>
3002
3003 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3004
2f142cc5
JB
30052011-05-10 Juanma Barranquero <lekktu@gmail.com>
3006
3007 * image.c (Finit_image_library): Return t for built-in image types,
3008 like pbm and xbm. (Bug#8640)
3009
57679c86
AS
30102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3011
3012 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3013
888c9e86
EZ
30142011-05-07 Eli Zaretskii <eliz@gnu.org>
3015
b0512a1d
EZ
3016 * w32console.c (Fset_screen_color): Doc fix.
3017 (Fget_screen_color): New function.
3018 (syms_of_ntterm): Defsubr it.
3019
7285dc67
EZ
3020 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3021 unlink the temporary file if Fcall_process didn't create it in the
3022 first place.
3023 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3024 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3025 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3026 cue to call_process_cleanup not to close that handle.
3027
4d3fcc8e
BK
30282011-05-07 Ben Key <bkey76@gmail.com>
3029
3030 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3031 one of two shell specific rules, either bootstrap-temacs-CMD or
3032 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3033 to the previous implementation of the bootstrap-temacs rule.
3034 The bootstrap-temacs-CMD rule is similar to the previous
3035 implementation of the bootstrap-temacs rule except that it
3036 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3037 variable.
3038
3039 These changes, along with some changes to nt/configure.bat,
3040 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3041 earlier fix to add support for --cflags and --ldflags options
3042 that include quotes so that it works whether make uses cmd or
3043 sh as the shell.
3044
b4289b64
MA
30452011-05-06 Michael Albinus <michael.albinus@gmx.de>
3046
3047 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3048 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3049 is a constant.
3050 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3051 a string. Handle both cases.
3052 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3053 (Fdbus_register_method): Use Qinvalid_function.
3054
af4c0e28
JB
30552011-05-06 Juanma Barranquero <lekktu@gmail.com>
3056
3057 * makefile.w32-in: Update dependencies.
3058 (LISP_H): Add inttypes.h and stdin.h.
3059 (PROCESS_H): Add unistd.h.
3060
c51453d9
EZ
30612011-05-06 Eli Zaretskii <eliz@gnu.org>
3062
3063 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3064 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3065
8ff0ac3c 30662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3067
4c4b566b
PE
3068 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3069
aab2b9b5
PE
3070 * term.c (vfatal): Remove stray call to va_end.
3071 It's not needed and the C Standard doesn't allow it here anyway.
3072
c378da0b
PE
3073 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3074 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3075
288b08c7
PE
3076 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3077 bytes.
3078
e3601888
PE
3079 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3080
db6c0e74
PE
3081 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3082
dd5963ea
PE
3083 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3084
88c9450f
PE
3085 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3086
2f9442b8
PE
3087 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3088
c032b5f8
PE
3089 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3090 * charset.c (Fdefine_charset_internal): Don't initialize
3091 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3092 32-bit int (Bug#8600).
a108c10b
PE
3093
3094 * lread.c (read_integer): Be more consistent with string-to-number.
3095 Use string_to_number to do the actual conversion; this avoids
3096 rounding errors and fixes some other screwups. Without this fix,
3097 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3098 (digit_to_number): Move earlier, for benefit of read_integer.
3099 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3100 not a digit in any supported base. (Bug#8602)
a108c10b 3101
ad5f9eea
PE
3102 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3103
aec1708a
PE
3104 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3105 to match comment at start of function. This also removes a
3106 GCC warning about overflow in a 32+64-bit port.
3107
47be4ab5
PE
3108 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3109
371cac43
PE
3110 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3111 Reported by Stefan Monnier in
3112 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3113 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3114 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3115
d01a7826
PE
3116 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3117 (EMACS_UINTPTR): Likewise, with uintptr_t.
3118
7fd47d5c
PE
3119 * lisp.h: Prefer 64-bit EMACS_INT if available.
3120 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3121 on 32-bit hosts that have 64-bit int, so that they can access
3122 large files.
122b0c86
PE
3123 However, temporarily disable this change unless the temporary
3124 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3125
8727937b
PE
3126 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3127
8ac068ac
PE
3128 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3129 This removes an assumption that EMACS_INT and long are the same
3130 width as pointers. The assumption is true for Emacs porting targets
3131 now, but we want to make other targets possible.
3132 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3133 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3134 In the rest of the code, change types of integers that hold casted
3135 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3136 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3137 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3138 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3139 No need to cast type when ORing.
3140 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3141 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3142 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3143 assume EMACS_INT is the same width as char *.
3144 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3145 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3146 Remove no-longer-needed casts.
3147 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3148 (xg_tool_bar_help_callback, xg_make_tool_item):
3149 Use EMACS_INTPTR to hold an integer
3150 that will be cast to void *; this can avoid a GCC warning
3151 if EMACS_INT is not the same width as void *.
3152 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3153 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3154 (current_message_1, set_message_1):
3155 Use a local to convert to proper width without a cast.
3156 * xmenu.c (dialog_selection_callback): Likewise.
3157
ede49d71
PE
3158 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3159 Also, don't assume VALBITS / RAND_BITS is less than 5,
3160 and don't rely on undefined behavior when shifting a 1 left into
3161 the sign bit.
3162 * lisp.h (get_random): Change signature to match.
3163
2f30ecd0
PE
3164 * lread.c (hash_string): Use size_t, not int, for hash computation.
3165 Normally we prefer signed values; but hashing is special, because
3166 it's better to use unsigned division on hash table sizes so that
3167 the remainder is nonnegative. Also, size_t is the natural width
3168 for hashing into memory. The previous code used 'int', which doesn't
3169 retain enough info to hash well into very large tables.
3170 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3171
2a866e7b
PE
3172 * dbusbind.c: Don't possibly lose pointer info when converting.
3173 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3174 Use XPNTR rather than XHASH, so that the high-order bits of
3175 the pointer aren't lost when converting through void *.
3176
51639eac
PE
3177 * eval.c (Fautoload): Don't double-shift a pointer.
3178
92394119
PE
3179 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3180
dbdb9a7c
JB
31812011-05-06 Juanma Barranquero <lekktu@gmail.com>
3182
3183 * gnutls.c (DEF_GNUTLS_FN):
3184 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3185
db7a0b4f
AS
31862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3187
3188 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3189 marker. (Bug#8610)
3190
f7ff1b0f 31912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3192
3193 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3194 New version that can reserve upto 2GB of heap space.
3195
f7ff1b0f 31962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3197
3198 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3199
639c109b
TZ
32002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3201
3202 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3203 `gnutls_certificate_set_x509_key_file'.
3204
d2127135
JB
32052011-05-05 Juanma Barranquero <lekktu@gmail.com>
3206
3207 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3208 Update dependencies.
3209
e968f4f3
JB
32102011-05-04 Juanma Barranquero <lekktu@gmail.com>
3211
3212 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3213 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3214 Remove unused parameter `fildes'.
3215 * process.c (read_process_output, send_process): Don't pass it.
3216
84d358f0
JB
32172011-05-04 Juanma Barranquero <lekktu@gmail.com>
3218
3219 Fix previous change: the library cache is defined in w32.c.
3220 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3221 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3222
0898ca10
JB
32232011-05-04 Juanma Barranquero <lekktu@gmail.com>
3224
3225 Implement dynamic loading of GnuTLS on Windows.
3226
3227 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3228 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3229 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3230 Declare.
3231
3232 * gnutls.c (Qgnutls_dll): Define.
3233 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3234 (gnutls_*): Declare function pointers.
3235 (init_gnutls_functions): New function to initialize function pointers.
3236 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3237 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3238 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3239 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3240 (emacs_gnutls_write, emacs_gnutls_read)
3241 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3242 (Fgnutls_available_p): New function.
3243 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3244 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3245 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3246
3247 * image.c: Include w32.h.
3248 (Vimage_type_cache): Delete.
3249 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3250 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3251 (w32_delayed_load): Move to w32.c.
3252
3253 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3254
3255 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3256 (w32_delayed_load): Move from image.c. When loading a library, record
3257 its filename in the :loaded-from property of the library id.
3258 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3259 Initialize and staticpro them.
3260 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3261
3262 * process.c: Include lisp.h before w32.h, not after.
3263 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3264 instead of gnutls_record_check_pending.
3265
3266 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3267
ff4de4aa
TZ
32682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3269
3270 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3271 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3272 as passed in.
3273
abe95abb
JD
32742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3275
3276 * xterm.c (x_set_frame_alpha): Do not set property on anything
3277 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3278
e16e55d4
JB
32792011-05-02 Juanma Barranquero <lekktu@gmail.com>
3280
3281 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3282
bafcf6a5
JB
32832011-05-02 Juanma Barranquero <lekktu@gmail.com>
3284
3285 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3286 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3287 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3288 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3289 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3290 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3291 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3292 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3293 (Qgnutls_bootprop_callbacks_verify): Make static.
3294
e7a6747f
AS
32952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3296
19ed11ba
AS
3297 * callproc.c: Indentation fixup.
3298
e7a6747f 3299 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3300 (wait_for_termination, interruptible_wait_for_termination):
3301 Move after wait_for_termination_1.
e7a6747f 3302
1ef14cb4
LMI
33032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3304
3305 * sysdep.c (interruptible_wait_for_termination): New function
3306 which is like wait_for_termination, but allows keyboard
3307 interruptions.
3308
3309 * callproc.c (Fcall_process): Add (:file "file") as an option for
3310 the STDOUT buffer.
3311 (Fcall_process_region): Ditto.
3312
330d880c
EZ
33132011-04-30 Eli Zaretskii <eliz@gnu.org>
3314
8db90b73
EZ
3315 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3316 rather than `XVECTOR (FOO)->size'.
3317
330d880c
EZ
3318 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3319 inttypes.h, as a gnulib replacement is used if it not available in
3320 system headers.
3321
15cbd324
EZ
33222011-04-21 Eli Zaretskii <eliz@gnu.org>
3323
3324 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3325 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3326 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3327
3328 * coding.c (coding_alloc_by_realloc): Error out if destination
3329 will grow beyond MOST_POSITIVE_FIXNUM.
3330 (decode_coding_emacs_mule): Abort if there isn't enough place in
3331 charbuf for the composition carryover bytes. Reserve an extra
3332 space for up to 2 characters produced in a loop.
3333 (decode_coding_iso_2022): Abort if there isn't enough place in
3334 charbuf for the composition carryover bytes.
3335
33362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3337
ae940cca
EZ
3338 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3339 aborting when %lld or %lll format is passed.
3340 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3341 %llo or %llx format is passed. (Bug#8545)
3342
03ab8921
EZ
3343 * window.c (window_scroll_line_based): Use a marker instead of
3344 simple variables to record original value of point. (Bug#7952)
3345
afda1437
EZ
3346 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3347 produced by %s or %c overflows available buffer space. (Bug#8545)
3348
f76dee0c
PE
33492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3352 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3353
fdc5744d
JB
33542011-04-28 Juanma Barranquero <lekktu@gmail.com>
3355
3356 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3357
638f053a
JB
33582011-04-28 Juanma Barranquero <lekktu@gmail.com>
3359
3360 * keyboard.c (Qdelayed_warnings_hook): Define.
3361 (command_loop_1): Run `delayed-warnings-hook'
3362 if Vdelayed_warnings_list is non-nil.
3363 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3364 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3365
d178f871
EZ
33662011-04-28 Eli Zaretskii <eliz@gnu.org>
3367
3368 * doprnt.c (doprnt): Don't return value smaller than the buffer
3369 size if the message was truncated. (Bug#8545).
3370
b124fd93
JB
33712011-04-28 Juanma Barranquero <lekktu@gmail.com>
3372
3373 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3374 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3375
e810457d
PE
33762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3379
ea51cceb
JB
33802011-04-27 Juanma Barranquero <lekktu@gmail.com>
3381
3382 * makefile.w32-in: Update dependencies.
3383
94dcfacf
EZ
33842011-04-27 Eli Zaretskii <eliz@gnu.org>
3385
3386 Improve `doprnt' and its usage. (Bug#8545)
3387 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3388 `format_end'. Remove support for %l as a conversion specifier.
3389 Don't use xrealloc. Improve diagnostics when the %l size modifier
3390 is used. Update the commentary.
3391
3392 * eval.c (verror): Simplify calculation of size_t.
3393
3394 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3395 messages.
3396
f61f41d7
PE
33972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3398
3399 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3400 change.
3401
96fb4434
PE
34022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3405 This makes this file independent of the recent pseudovector change.
3406
671875da 34072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3408
69e9b5a3
PE
3409 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3410
b5f869a7 3411 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3412 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3413 Remove unused local.
c8926152 3414 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3415
841a1577 3416 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3417 GCC 4.6.0 optimizes based on type-based alias analysis.
3418 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3419 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3420 != &v->size, and therefore "v->size = 1; b->size = 2; return
3421 v->size;" must therefore return 1. This assumption is incorrect
3422 for Emacs, since it type-puns struct Lisp_Vector * with many other
3423 types. To fix this problem, this patch adds a new type struct
f904488f 3424 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3425 and pseudovectors, and helps optimizing compilers not get fooled
3426 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3427 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3428 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3429 the size member.
eab3844f
PE
3430 (XSETPVECTYPE): Rewrite in terms of new macro.
3431 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3432 This is a bit clearer, and further avoids the possibility of
3433 undesirable aliasing.
3434 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3435 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3436 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3437 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3438 (ASIZE): Now uses header.size rather than size.
3439 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3440 to avoid the hassle of writing XVECTOR (foo)->header.size.
3441 (struct vectorlike_header): New type.
eab3844f
PE
3442 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3443 object, to help avoid aliasing.
3444 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3445 (SUBRP): Likewise, since Lisp_Subr is a special case.
3446 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3447 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3448 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3449 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3450 changed to be "header.size" and "header.next".
3451 * buffer.h (struct buffer): Likewise.
3452 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3453 * frame.h (struct frame): Likewise.
3454 * process.h (struct Lisp_Process): Likewise.
3455 * termhooks.h (struct terminal): Likewise.
3456 * window.c (struct save_window_data, struct saved_window): Likewise.
3457 * window.h (struct window): Likewise.
3458 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3459 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3460 * buffer.c (init_buffer_once): Likewise.
3461 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3462 special case.
3463 * process.c (Fformat_network_address): Use local var for size,
3464 for brevity.
3465
0df1eac5
PE
3466 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3467
847ab9d1 3468 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3469 * data.c (atof): Remove decl; no longer used or needed.
3470 (digit_to_number): Move to lread.c.
3471 (Fstring_to_number): Use new string_to_number function, to be
3472 consistent with how the Lisp reader treats infinities and NaNs.
3473 Do not assume that floating-point numbers represent EMACS_INT
3474 without losing information; this is not true on most 64-bit hosts.
3475 Avoid double-rounding errors, by insisting on integers when
3476 parsing non-base-10 numbers, as the documentation specifies.
3477 * lisp.h (string_to_number): New decl, replacing ...
3478 (isfloat_string): Remove.
bc0a5c13 3479 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3480 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3481 appears to have been a coding error. Similarly, do not accept
3482 strings like +-1e0 as floating point numbers. Do not report
3483 overflow for integer overflows unless the base is not 10 which
3484 means we have no simple and reliable way to continue.
3485 Break out the floating-point parsing into a new
3486 function string_to_number, so that Fstring_to_number parses
3487 floating point numbers consistently with the Lisp reader.
04f2d78b 3488 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3489 (E_CHAR, EXP_INT): Remove, replacing with ...
3490 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3491 (string_to_number): New function, replacing isfloat_string.
3492 This function checks for valid syntax and produces the resulting
3493 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3494 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3495 so that overflow for non-base-10 numbers is reported only when
3496 there's no portable and simple way to convert to floating point.
452f4150 3497
67769ffc
PE
3498 * textprop.c (set_text_properties_1): Rewrite for clarity,
3499 and to avoid GCC warning about integer overflow.
3500
c20db43f
PE
3501 * intervals.h (struct interval): Use EMACS_INT for members
3502 where EMACS_UINT might cause problems. See
3503 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3504 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3505 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3506 All uses changed.
37aa2f85
PE
3507 (offset_intervals): Tell GCC not to worry about length overflow
3508 when negating a negative length.
c20db43f 3509
2538aa2f
PE
3510 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3511 (overrun_check_free): Likewise.
3512
f2d3008d
PE
3513 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3514 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3515 word size.
3516
ec8df744
PE
3517 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3518 (gnutls_make_error): Rename local to avoid shadowing.
3519 (gnutls_emacs_global_deinit): ifdef out; not used.
3520 (Fgnutls_boot): Use const for pointer to readonly storage.
3521 Comment out unused local. Fix pointer signedness problems.
3522
640ee02d
PE
3523 * lread.c (openp): Don't stuff size_t into an 'int'.
3524 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3525 about possible signed overflow.
3526
6048fb2a
PE
3527 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3528 (GDK_KEY_g): Don't define if already defined.
3529 (xg_prepare_tooltip): Avoid pointer signedness problem.
3530 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3531
fa3c87e1
PE
3532 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3533 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3534
2172544b
PE
3535 * xfns.c (Fx_window_property): Simplify a bit,
3536 to make a bit faster and to avoid GCC 4.6.0 warning.
3537 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3538
9b821a21
PE
3539 * fns.c (internal_equal): Don't assume size_t fits in int.
3540
3c616cfa
PE
3541 * alloc.c (compact_small_strings): Tighten assertion a little.
3542
c2982e87
PE
3543 Replace pEd with more-general pI, and fix some printf arg casts.
3544 * lisp.h (pI): New macro, generalizing old pEd macro to other
3545 conversion specifiers. For example, use "...%"pI"d..." rather
3546 than "...%"pEd"...".
3547 (pEd): Remove. All uses replaced with similar uses of pI.
3548 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3549 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3550 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3551 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3552 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3553 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3554 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3555 64-bit hosts.
3556 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3557 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3558 * print.c (safe_debug_print, print_object): Likewise.
3559 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3560 to int.
6f04d126
PE
3561 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3562 avoiding the 0 flag, which is not portable.
c2982e87
PE
3563 * process.c (Fmake_network_process): Use pI to avoid cast.
3564 * region-cache.c (pp_cache): Likewise.
3565 * xdisp.c (decode_mode_spec): Likewise.
3566 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3567 behavior on 64-bit hosts with printf arg.
6f04d126 3568 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3569 (x_stop_queuing_selection_requests): Likewise.
3570 (x_get_window_property): Don't truncate byte count to an 'int'
3571 when tracing.
0b432f21 3572
5e073ec7
PE
3573 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3574 here, since it parses constructs like leading '-' and spaces,
3575 which are not wanted; and it overflows with large numbers.
3576 Instead, simply match F[0-9]+, which is what is wanted anyway.
3577
36372bf9
PE
3578 * alloc.c: Remove unportable assumptions about struct layout.
3579 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3580 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3581 (allocate_vectorlike, make_pure_vector): Use the new macros,
3582 plus offsetof, to remove unportable assumptions about struct layout.
3583 These assumptions hold on all porting targets that I know of, but
3584 they are not guaranteed, they're easy to remove, and removing them
3585 makes further changes easier.
3586
0b432f21
PE
3587 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3588 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3589 (string_overrun_cookie): Now const. Use initializers that
3590 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3591 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3592 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3593 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3594 multiple of sizeof (EMACS_INT); it need not be, if
3595 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3596 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3597
895009e1
JB
35982011-04-26 Juanma Barranquero <lekktu@gmail.com>
3599
3600 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3601
6a7a1b0b
TZ
36022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3603
3604 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3605 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3606 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3607
841a1577 36082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3609
3610 * lisp.h (Qdebug): List symbol.
895009e1 3611 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3612 * keyboard.c (debug-on-event): New variable.
3613 (handle_user_signal): Break into debugger when debug-on-event
3614 matches the current signal symbol.
3615
f2d3ba6f
DN
36162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3617
3618 * alloc.c (check_sblock, check_string_bytes)
3619 (check_string_free_list): Convert to standard C.
3620
42ce4c63
TZ
36212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3622
3623 * w32.c (emacs_gnutls_push): Fix typo.
3624
825cd63c
EZ
36252011-04-25 Eli Zaretskii <eliz@gnu.org>
3626
fb11d64d
EZ
3627 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3628 "cast to pointer from integer of different size".
3629
825cd63c
EZ
3630 Improve doprnt and its use in verror. (Bug#8545)
3631 * doprnt.c (doprnt): Document the set of format control sequences
3632 supported by the function. Use SAFE_ALLOCA instead of always
3633 using `alloca'.
3634
3635 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3636 is one byte too soon. Don't use xrealloc; instead xfree and
3637 xmalloc anew.
3638
e061a11b
TZ
36392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3640
3641 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3642 callbacks stage.
3643
3644 * gnutls.c: Renamed global_initialized to
3645 gnutls_global_initialized. Added internals for the
3646 :verify-hostname-error, :verify-error, and :verify-flags
3647 parameters of `gnutls-boot' and documented those parameters in the
3648 docstring. Start callback support.
9173deec
JB
3649 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3650 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3651 on error. Return error code.
e061a11b
TZ
3652 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3653 (emacs_gnutls_read): Likewise.
3654 (Fgnutls_boot): Return handshake error code.
3655 (emacs_gnutls_handle_error): New function.
3656 (wsaerror_to_errno): Likewise.
3657
3658 * w32.h (emacs_gnutls_pull): Add prototype.
3659 (emacs_gnutls_push): Likewise.
3660
3661 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3662 (emacs_gnutls_push): Likewise.
3663
36642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3665
3666 * process.c (wait_reading_process_output): Check if GnuTLS
3667 buffered some data internally if no FDs are set for TLS
3668 connections.
3669
3670 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3671 (LIBS): Link to USER_LIBS.
3672 ($(BLD)/gnutls.$(0)): New target.
3673
fa6996bc
EZ
36742011-04-24 Eli Zaretskii <eliz@gnu.org>
3675
eb35682e
EZ
3676 * xdisp.c (handle_single_display_spec): Rename the
3677 display_replaced_before_p argument into display_replaced_p, to
3678 make it consistent with the commentary. Fix typos in the
3679 commentary.
3680
e2ad650c
EZ
3681 * textprop.c (syms_of_textprop): Remove dead code.
3682 (copy_text_properties): Delete obsolete commentary about an
3683 interface that was deleted long ago. Fix typos in the description
3684 of arguments.
3685
1b2de274
EZ
3686 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3687 to changes in oldXMenu/XMenu.h from 2011-04-16.
3688 <menu_help_message, prev_menu_help_message>: Constify.
3689 (IT_menu_make_room): menu->help_text is now `const char **';
3690 adjust.
3691
3692 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3693 to changes in oldXMenu/XMenu.h from 2011-04-16.
3694 (struct XMenu): Declare `help_text' `const char **'.
3695
3696 * xfaces.c <Qunspecified>: Make extern again.
3697
3698 * syntax.c: Include sys/types.h before including regex.h, as
3699 required by Posix.
3700
762b15be
EZ
3701 * doc.c (get_doc_string): Improve the format passed to `error'.
3702
3703 * doprnt.c (doprnt): Improve commentary.
3704
3705 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3706
3707 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3708 them with etags.
3709
f1052e5d
EZ
3710 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3711 changes in globals.h immediately force recompilation.
762b15be
EZ
3712 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3713 $(CURDIR)/s/ms-w32.h.
3714 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3715
fa6996bc
EZ
3716 * character.c (Fchar_direction): Function deleted.
3717 (syms_of_character): Don't defsubr it.
3718 <char-direction-table>: Deleted.
3719
e6c3da20
EZ
37202011-04-23 Eli Zaretskii <eliz@gnu.org>
3721
3722 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3723 * doprnt.c: Include limits.h.
3724 (SIZE_MAX): New macro.
04f2d78b
CB
3725 (doprnt): Return a size_t value. 2nd arg is now size_t.
3726 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3727 Improve overflow protection. Support `l' modifier for integer
3728 conversions. Support %l conversion. Don't assume an EMACS_INT
3729 argument for integer conversions and for %c.
3730
3731 * lisp.h (doprnt): Restore prototype.
3732
3733 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3734 $(SRC)/character.h.
3735
3736 * Makefile.in (base_obj): Add back doprnt.o.
3737
3738 * deps.mk (doprnt.o): Add back prerequisites.
3739 (callint.o): Depend on character.h.
3740
3741 * eval.c (internal_lisp_condition_case): Include the handler
3742 representation in the error message.
3743 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3744 when breaking from the loop.
3745
3746 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3747
3748 * callint.c (Fcall_interactively): When displaying error message
3749 about invalid control letter, pass the character's codepoint, not
3750 a pointer to its multibyte form. Improve display of the character
3751 in octal and display also its hex code.
3752
3753 * character.c (char_string): Use %x to display the (unsigned)
3754 codepoint of an invalid character, to avoid displaying a bogus
3755 negative value.
3756
3757 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3758 `error', not SYMBOL_NAME itself.
3759
3760 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3761 character arguments to `error'.
3762
3763 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3764 to `error' in error message about FINAL_CHAR argument. Make sure
3765 FINAL_CHAR is a character, and use %c when it is passed as
3766 argument to `error'.
3767
4ffd0d6b 37682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3769
3770 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3771
3772 * w32.c: Include <time.h>.
3773 (sys_localtime): New function.
3774
4ffd0d6b 37752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3776
3777 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3778
4ffd0d6b 3779 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3780
4ffd0d6b 37812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3782
4ffd0d6b
GM
3783 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3784 zombies (Bug#8467).
aac0c6e3 3785
04c56954
EZ
37862011-04-19 Eli Zaretskii <eliz@gnu.org>
3787
3788 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3789 gl_state.e_property when gl_state.object is Qt.
3790
3791 * insdel.c (make_gap_larger): Remove limitation of buffer size
3792 to <= INT_MAX.
3793
16a43933
CY
37942011-04-18 Chong Yidong <cyd@stupidchicken.com>
3795
3796 * xdisp.c (lookup_glyphless_char_display)
3797 (produce_glyphless_glyph): Handle cons cell entry in
3798 glyphless-char-display.
3799 (Vglyphless_char_display): Document it.
3800
3801 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3802 glyphless-char-display.
3803
4581706e
CY
38042011-04-17 Chong Yidong <cyd@stupidchicken.com>
3805
3806 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3807
3808 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3809
3810 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3811 definition for no-X builds.
3812
4887c6e2 38132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3814
fd35b6f9
PE
3815 Static checks with GCC 4.6.0 and non-default toolkits.
3816
5c1ccb01
PE
3817 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3818
006c5daa
PE
3819 * process.c (keyboard_bit_set): Define only if SIGIO.
3820 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3821 (send_process): Repair possible setjmp clobbering.
3822
efc736d3
PE
3823 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3824
4e2fe2e6
PE
3825 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3826
f97334a2
PE
3827 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3828
4e75f29d
PE
3829 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3830 Define only if needed.
3831
90efadd1
PE
3832 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3833 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3834 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3835
3c647824
PE
3836 * dispextern.h (struct redisplay_interface): Rename param
3837 to avoid shadowing.
e264f262 3838 * termhooks.h (struct terminal): Likewise.
761383f4 3839 * xterm.c (xembed_send_message): Likewise.
3c647824 3840
b58c5c4a
PE
3841 * insdel.c (make_gap_smaller): Define only if
3842 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3843
cad59032
PE
3844 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3845 it.
3846
c339dc2e
PE
3847 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3848 so that we aren't warned about unused symbols.
3849
91a3e27b
PE
3850 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3851
399c71d3 3852 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3853
8ffc96f5
PE
3854 * xfns.c (x_real_positions): Mark locals as initialized.
3855
eef9bc79
PE
3856 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3857
098db9dd
PE
3858 * xterm.c: Fix problems found by static analysis with other toolkits.
3859 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3860 (x_dispatch_event): Declare static if USE_GTK, and
3861 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3862 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3863 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3864 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3865 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3866
eb18f6cc
PE
3867 * xmenu.c (menu_help_callback): Pointer type fixes.
3868 Use const pointers when pointing at readonly data. Avoid pointer
3869 signedness clashes.
3870 (FALSE): Remove unused macro.
3871 (update_frame_menubar): Remove unused decl.
3872
1fe72bf8
PE
3873 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3874
60d9e1db
PE
3875 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3876 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3877 (single_menu_item): Rename local to avoid shadowing.
3878
39261c26
PE
3879 * keyboard.c (make_lispy_event): Remove unused local var.
3880
018c5e19
PE
3881 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3882 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3883
63d2b86e
PE
3884 * bitmaps: Change bitmaps from unsigned char back to the X11
3885 compatible char. Avoid the old compiler warnings about
3886 out-of-range initializers by using, for example, '\xab' rather
3887 than 0xab.
3888
aefd87e1
PE
3889 * xgselect.c (xgselect_initialize): Check vs interface
3890 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3891
bf501fb9
PE
3892 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3893
e9829fdf
PE
3894 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3895 to read-only memory.
3896
1086c095
PE
3897 * fns.c (vector): Remove; this old hack is no longer needed.
3898
2baccd04 3899 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3900 Remove unused var.
dde42981 3901 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3902
72391843 3903 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3904
436c16df 3905 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3906 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3907 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3908
92bb796d 3909 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3910 (x_term_init): Remove local to avoid shadowing.
92bb796d 3911
764430a3 3912 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3913
3914 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3915 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3916
d1dfb56c
EZ
39172011-04-16 Eli Zaretskii <eliz@gnu.org>
3918
c4354cb4
EZ
3919 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3920
d1dfb56c
EZ
3921 Fix regex.c, syntax.c and friends for buffers > 2GB.
3922 * syntax.h (struct gl_state_s): Declare character position members
3923 EMACS_INT.
3924
3925 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3926
04f2d78b
CB
3927 * textprop.c (verify_interval_modification, interval_of):
3928 Declare arguments EMACS_INT.
d1dfb56c
EZ
3929
3930 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3931 EMACS_INT.
3932
3933 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3934
3935 * indent.c (Fvertical_motion): Local variable it_start is now
3936 EMACS_INT.
3937
3938 * regex.c (re_match, re_match_2, re_match_2_internal)
3939 (bcmp_translate, regcomp, regexec, print_double_string)
3940 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3941 (re_compile_pattern, re_exec): Declare arguments and local
3942 variables `size_t' and `ssize_t' and return values `regoff_t', as
3943 appropriate.
3944 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3945 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3946 <compile_stack_type>: `size' and `avail' are now `size_t'.
3947
3948 * regex.h <regoff_t>: Use ssize_t, not int.
3949 (re_search, re_search_2, re_match, re_match_2): Arguments that
3950 specify buffer/string position and length are now ssize_t and
3951 size_t. Return type is regoff_t.
3952
613052cd
BK
39532011-04-16 Ben Key <bkey76@gmail.com>
3954
3955 * nsfont.m: Fixed bugs in ns_get_family and
3956 ns_descriptor_to_entity that were caused by using free to
3957 deallocate memory blocks that were allocated by xmalloc (via
3958 xstrdup). This caused Emacs to crash when compiled with
3959 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3960 --enable-checking=xmallocoverrun). xfree is now used to
3961 deallocate these memory blocks.
3962
4170f62f 39632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3964
71b41406
PE
3965 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3966
9587a89d
PE
3967 emacs_write: Accept and return EMACS_INT for sizes.
3968 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3969 et seq.
3970 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3971 Accept and return EMACS_INT.
3972 (emacs_gnutls_write): Return the number of bytes written on
3973 partial writes.
3974 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3975 (emacs_read, emacs_write): Remove check for negative size, as the
3976 Emacs source code has been audited now.
9587a89d
PE
3977 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3978 (emacs_read, emacs_write): Use it.
273a5f82
PE
3979 * process.c (send_process): Adjust to the new signatures of
3980 emacs_write and emacs_gnutls_write. Do not attempt to store
3981 a byte offset into an 'int'; it might overflow.
9587a89d 3982 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3983
3e047f51
PE
3984 * sound.c: Don't assume sizes fit in 'int'.
3985 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3986 Return EMACS_INT, not int.
3e047f51 3987 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3988 Accept EMACS_INT, not int.
3989 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3990 record read return values.
3991
cc39a9db
BK
39922011-04-15 Ben Key <bkey76@gmail.com>
3993
c9d0ec6d
JB
3994 * keyboard.c (Qundefined): Don't declare static since it is used
3995 in nsfns.m.
3996 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3997 static since they are used in nsfont.m.
cc39a9db 3998
6c60eb9f
SM
39992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4000
4001 * process.c (Qprocessp): Don't declare static.
4002 * lisp.h (Qprocessp): Declare again.
4003
7990b61a
JB
40042011-04-15 Juanma Barranquero <lekktu@gmail.com>
4005
4006 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4007
5d4cb038
PE
40082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4009
8bd7b830 4010 Improve C-level modularity by making more things 'static'.
cd64ea1d 4011
e3b27b31
PE
4012 Don't publish debugger-only interfaces to other modules.
4013 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4014 (verify_bytepos, count_markers): Move decls to the only modules
4015 that need them.
4016 * region-cache.h (pp_cache): Likewise.
4017 * window.h (check_all_windows): Likewise.
4018 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4019
5d4cb038
PE
4020 * sysdep.c (croak): Now static, if
4021 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4022 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4023
4024 * alloc.c (refill_memory_reserve): Now static if
4025 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4026 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4027
e87b6180
PE
4028 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4029 Define only if USE_LUCID.
4030
ac64929e
PE
4031 * xrdb.c (x_customization_string, x_rm_string): Now static.
4032
6f37259d
PE
4033 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4034 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4035
1683e3ab
PE
4036 * xdisp.c (draw_row_with_mouse_face): Now static.
4037 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4038
de9c2632
PE
4039 * window.h (check_all_windows): Mark externally visible.
4040
2b96acb7
PE
4041 * window.c (window_deletion_count): Now static.
4042
4043 * undo.c: Make symbols static if they're not exported.
4044 (last_undo_buffer, last_boundary_position, pending_boundary):
4045 Now static.
4046
50436f33
PE
4047 * textprop.c (interval_insert_behind_hooks): Now static.
4048 (interval_insert_in_front_hooks): Likewise.
4049
64520e5c
PE
4050 * term.c: Make symbols static if they're not exported.
4051 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4052 (max_frame_lines, tty_set_terminal_modes):
4053 (tty_reset_terminal_modes, tty_turn_off_highlight):
4054 (get_tty_terminal): Now static.
4055 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4056 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4057 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4058 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4059 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4060
1fa53021
PE
4061 * sysdep.c: Make symbols static if they're not exported.
4062 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4063 Now static.
4064 (sigprocmask_set, full_mask): Remove; unused.
4065 (wait_debugging): Mark as visible.
4066 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4067 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4068
d4b43b22
PE
4069 * syntax.c (syntax_temp): Define only if !__GNUC__.
4070
b7c513d0
PE
4071 * sound.c (current_sound_device, current_sound): Now static.
4072
989b29ad
PE
4073 * search.c (searchbufs, searchbuf_head): Now static.
4074
13a55a78
PE
4075 * scroll.c (scroll_cost): Remove; unused.
4076 * dispextern.h (scroll_cost): Remove decl.
4077
de68a1fc
PE
4078 * region-cache.h (pp_cache): Mark as externally visible.
4079
40ccffa6
PE
4080 * process.c: Make symbols static if they're not exported.
4081 (process_tick, update_tick, create_process, chan_process):
4082 (Vprocess_alist, proc_buffered_char, datagram_access):
4083 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4084 (deactivate_process): Mark defn as static, as well as decl.
4085 * lisp.h (create_process): Remove decl.
4086 * process.h (chan_process, Vprocess_alist): Remove decls.
4087
ad64fc97
PE
4088 * print.c: Make symbols static if they're not exported.
4089 (print_depth, new_backquote_output, being_printed, print_buffer):
4090 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4091 (print_interval, print_number_index, initial_stderr_stream):
4092 Now static.
4093 * lisp.h (Fprinc): Remove decl.
4094 (debug_output_compilation_hack): Mark as externally visible.
4095
adddb265
PE
4096 * sysdep.c (croak): Move decl from here to syssignal.h.
4097 * syssignal.h (croak): Put it here, so the API can be checked when
4098 'croak' is called from dissociate_if_controlling_tty.
4099
1717ede2
PE
4100 * minibuf.c: Make symbols static if they're not exported.
4101 (minibuf_save_list, choose_minibuf_frame): Now static.
4102 * lisp.h (choose_minibuf_frame): Remove decl.
4103
fa5fb2bc
PE
4104 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4105
1e3890d1
PE
4106 * lread.c: Make symbols static if they're not exported.
4107 (read_objects, initial_obarray, oblookup_last_bucket_number):
4108 Now static.
4109 (make_symbol): Remove; unused.
4110 * lisp.h (initial_obarray, make_symbol): Remove decls.
4111
8a1414fa
PE
4112 * keyboard.c: Make symbols static if they're not exported.
4113 (single_kboard, recent_keys_index, total_keys, recent_keys):
4114 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4115 (this_single_command_key_start, echoing, last_auto_save):
4116 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4117 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4118 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4119 (Vlispy_mouse_stem, double_click_count):
4120 Now static.
4121 (force_auto_save_soon): Define only if SIGDANGER.
4122 (ignore_mouse_drag_p): Now static if
4123 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4124 (print_help): Remove; unused.
4125 (stop_character, last_timer_event): Mark as externally visible.
4126 * keyboard.h (ignore_mouse_drag_p): Declare only if
4127 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4128 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4129 * lisp.h (echoing): Remove decl.
4130 (force_auto_save_soon): Declare only if SIGDANGER.
4131 * xdisp.c (redisplay_window): Simplify code, to make it more
4132 obvious that ignore_mouse_drag_p is not accessed if !defined
4133 USE_GTK && !defined HAVE_NS.
4134
93ea6e8f
PE
4135 * intervals.c: Make symbols static if they're not exported.
4136 (merge_properties_sticky, merge_interval_right, delete_interval):
4137 Now static.
4138 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4139
77382fcc
PE
4140 * insdel.c: Make symbols static if they're not exported.
4141 However, leave prepare_to_modify_buffer alone. It's never
4142 called from outside this function, but that appears to be a bug.
4143 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4144 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4145 (adjust_after_replace_noundo): Remove; unused.
4146 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4147 (signal_before_change): Remove decls.
77382fcc 4148
9306c32e
PE
4149 * indent.c (val_compute_motion, val_vmotion): Now static.
4150
cd44d2eb
PE
4151 * image.c: Make symbols static if they're not exported.
4152 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4153 if USE_GTK.
4154 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4155 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4156
ad9a7a06
PE
4157 * fringe.c (standard_bitmaps): Now static.
4158 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4159
81626931
PE
4160 * frame.c: Make symbols static if they're not exported.
4161 (x_report_frame_params, make_terminal_frame): Now static.
4162 (get_frame_param): Now static, unless HAVE_NS.
4163 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4164 (x_get_resource_string): Remove; not used.
4165 * frame.h (make_terminal_frame, x_report_frame_params):
4166 (x_get_resource_string); Remove decls.
4167 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4168 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4169
239f9db9
PE
4170 * font.c, fontset.c: Make symbols static if they're not exported.
4171 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4172 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4173 * font.c (font_close_object): Now static.
4174 * font.h (font_close_object): Remove.
4175 * fontset.c (FONTSET_OBJLIST): Remove.
4176 (free_realized_fontset) #if-0 the body, which does nothing.
4177 (face_suitable_for_char_p): #if-0, as it's never called.
4178 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4179 * xfaces.c (face_at_string_position):
4180 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4181 since 0 is always ASCII.
4182
dfcf3579
PE
4183 * fns.c (weak_hash_tables): Now static.
4184
5045092b
PE
4185 * fileio.c: Make symbols static if they're not exported.
4186 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4187 (Vwrite_region_annotation_buffers): Now static.
4188
57a96f5c
PE
4189 * eval.c: Make symbols static if they're not exported.
4190 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4191 * lisp.h (backtrace_list): Remove decl.
4192
35f08c38
PE
4193 * emacs.c: Make symbols static if they're not exported.
4194 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4195 (fatal_error_code, fatal_error_signal_hook, standard_args):
4196 Now static.
4197 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4198 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4199 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4200 * lisp.h (fatal_error_signal_hook): Remove decl.
4201 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4202
f44bd759
PE
4203 * editfns.c: Move a (normally-unused) function to its only use.
4204 * editfns.c, lisp.h (get_operating_system_release): Remove.
4205 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4206 worth the hassle of breaking this out.
4207
b532497d
PE
4208 * xterm.c: Make symbols static if they're not exported.
4209 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4210 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4211 (x_destroy_window, x_delete_display):
4212 Now static.
4213 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4214 (x_mouse_leave): Remove; unused.
4215 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4216 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4217 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4218 Remove decls.
4219 (x_mouse_leave): Declare only if WINDOWSNT.
4220 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4221 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4222 USE_X_TOOLKIT.
4223
1675728f
PE
4224 * ftxfont.c: Make symbols static if they're not exported.
4225 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4226 HAVE_FREETYPE.
4227 * font.h (ftxfont_driver): Likewise.
4228
e4cebfca
PE
4229 * xfns.c: Make symbols static if they're not exported.
4230 (x_last_font_name, x_display_info_for_name):
4231 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4232 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4233 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4234 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4235 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4236 (last_show_tip_args): Now static.
4237 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4238 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4239 (x_screen_planes): Remove; unused.
4240 * dispextern.h (x_screen_planes): Remove decl.
4241
5bf46f05
PE
4242 * dispnew.c: Make symbols static if they're not exported.
4243 * dispextern.h (redraw_garbaged_frames, scrolling):
4244 (increment_row_positions): Remove.
4245 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4246 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4247 Now static.
4248 (redraw_garbaged_frames): Remove; unused.
4249
435f4c28
PE
4250 * xfaces.c: Make symbols static if they're not exported.
4251 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4252 Remove decls.
4253 * xterm.h (defined_color): Remove decls.
4254 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4255 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4256 (menu_face_changed_default, defined_color, free_realized_face):
4257 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4258 (ascii_face_of_lisp_face): Remove; unused.
4259
8524aef3
PE
4260 * xdisp.c: Make symbols static if they're not exported.
4261 * dispextern.h (scratch_glyph_row, window_box_edges):
4262 (glyph_to_pixel_coords, set_cursor_from_row):
4263 (get_next_display_element, set_iterator_to_next):
4264 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4265 (show_mouse_face): Remove decls
4266 * frame.h (message_buf_print): Likewise.
4267 * lisp.h (pop_message, set_message, check_point_in_composition):
4268 Likewise.
4269 * xterm.h (set_vertical_scroll_bar): Likewise.
4270 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4271 (message_buf_print, scratch_glyph_row, displayed_buffer):
4272 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4273 (get_next_display_element, show_mouse_face, window_box_edges):
4274 (frame_to_window_pixel_xy, check_point_in_composition):
4275 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4276 (glyph_to_pixel_coords): Remove; unused.
4277
16390cd2
PE
4278 * dired.c (file_name_completion): Now static.
4279
4280 * dbusbind.c (xd_in_read_queued_messages): Now static.
4281
a25f4dfa
PE
4282 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4283 * data.c (circular_list_error): Remove.
4284
14a9c8df
PE
4285 * commands.h (last_point_position, last_point_position_buffer):
4286 (last_point_position_window): Remove decls.
4287 * keyboard.c: Make these variables static.
4288
04f2d78b
CB
4289 * coding.h (coding, code_convert_region, encode_coding_gap):
4290 Remove decls.
74ab6df5
PE
4291 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4292 (iso_code_class, detect_coding, code_convert_region): Now static.
4293 (encode_coding_gap): Remove; unused.
4294
38dfbee1
PE
4295 * chartab.c (chartab_chars, chartab_bits): Now static.
4296
a2cb4e63
PE
4297 * charset.h (charset_iso_8859_1): Remove decl.
4298 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4299 Now static.
4300
127198fd
PE
4301 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4302 * ccl.c (Vccl_program_table): Now static.
4303 (check_ccl_update): Remove; unused.
4304
d85b608f
PE
4305 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4306 * category.h: ... from here.
4307 * category.c (check_category_table, set_category_set): Now static.
4308
31cd66f3
PE
4309 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4310 * lisp.h: Remove these decls.
4311
c358e587
PE
4312 * buffer.c (buffer_count): Remove unused var.
4313
e78aecca
PE
4314 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4315 so that it's not optimized away.
4316 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4317 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4318 exported only to the debugger.
4319
e192d7d3 4320 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4321 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4322
92470028
PE
4323 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4324 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4325 was inaccessible from Lisp.
4326 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4327 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4328
244ed907
PE
4329 alloc.c: Import and export fewer symbols, and remove unused items.
4330 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4331 is defined.
4332 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4333 it's not optimized away by whole-program optimization.
4334 (message_enable_multibyte, free_misc): Remove.
4335 (catchlist, handlerlist, mark_backtrace):
4336 Declare only if BYTE_MARK_STACK.
4337 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4338 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4339 (message_enable_multibyte): Remove decl.
4340 (free_misc, interval_free_list, float_block, float_block_index):
4341 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4342 (cons_free_list, last_marked_index):
4343 Now static.
4344 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4345 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4346 (mark_backtrace): Define only if BYTE_MARK_STACK.
4347 * xdisp.c (message_enable_multibyte): Now static.
4348
61c2b50e 4349 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4350 This makes it easier for human readers (and static analyzers)
4351 to see whether these variables are used from other modules.
4352 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4353 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4354 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4355 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4356 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4357 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4358 * xmenu.c, xselect.c:
4359 Declare Q* vars static if they are not used in other modules.
4360 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4361 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4362 Remove decls of unexported vars.
4363 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4364
95c82688
PE
4365 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4366
16a97296
PE
4367 Make Emacs functions such as Fatom 'static' by default.
4368 This makes it easier for human readers (and static analyzers)
4369 to see whether these functions can be called from other modules.
4370 DEFUN now defines a static function. To make the function external
4371 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4372 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4373 (Finit_image_library):
16a97296
PE
4374 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4375 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4376 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4377 Remove decls, since these functions are now static.
4378 (Funintern, Fget_internal_run_time): New decls, since these functions
4379 were already external.
95c82688 4380
16a97296
PE
4381 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4382 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4383 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4384 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4385 * keyboard.c, keymap.c, lread.c:
4386 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4387 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4388 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4389 Mark functions with DEFUE instead of DEFUN,
4390 if they are used in other modules.
4391 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4392 decls for now-static functions.
4393 * buffer.h (Fdelete_overlay): Remove decl.
4394 * callproc.c (Fgetenv_internal): Mark as internal.
4395 * composite.c (Fremove_list_of_text_properties): Remove decl.
4396 (Fcomposition_get_gstring): New forward static decl.
4397 * composite.h (Fcomposite_get_gstring): Remove decl.
4398 * dired.c (Ffile_attributes): New forward static decl.
4399 * doc.c (Fdocumntation_property): New forward static decl.
4400 * eval.c (Ffetch_bytecode): New forward static decl.
4401 (Funintern): Remove extern decl; now in .h file where it belongs.
4402 * fileio.c (Fmake_symbolic_link): New forward static decl.
4403 * image.c (Finit_image_library): New forward static decl.
4404 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4405 * intervals.h (Fprevious_property_change):
4406 (Fremove_list_of_text_properties): Remove decls.
4407 * keyboard.c (Fthis_command_keys): Remove decl.
4408 (Fcommand_execute): New forward static decl.
4409 * keymap.c (Flookup_key): New forward static decl.
4410 (Fcopy_keymap): Now static.
4411 * keymap.h (Flookup_key): Remove decl.
4412 * process.c (Fget_process): New forward static decl.
4413 (Fprocess_datagram_address): Mark as internal.
4414 * syntax.c (Fsyntax_table_p): New forward static decl.
4415 (skip_chars): Remove duplicate decl.
4416 * textprop.c (Fprevious_property_change): New forward static decl.
4417 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4418 Now internal.
4419 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4420 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4421
785bbd42
PE
4422 * editfns.c (Fformat): Remove unreachable code.
4423
8b913b57
AS
44242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4425
4426 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4427 change. (Bug#8496)
4428
a6744a35
EZ
44292011-04-13 Eli Zaretskii <eliz@gnu.org>
4430
4431 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4432 when at ZV. (Bug#8487)
4433
e7974947
AS
44342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4435
baad03f0
AS
4436 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4437 (Bug#8437)
4438 * keyboard.c (parse_tool_bar_item): Likewise.
4439 * sound.c (sound_cleanup, alsa_close): Likewise.
4440 * termcap.c (tgetent): Likewise.
4441 * xfns.c (x_default_font_parameter): Likewise.
4442 * xsettings.c (read_and_apply_settings): Likewise.
4443
e7974947
AS
4444 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4445 (overrun_check_free): Protoize.
4446
28272684
PE
44472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4448
4449 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4450 since callers should never pass a negative size.
4451 Change the signature to match that of plain 'read' and 'write'; see
4452 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4453 * lisp.h: Update prototypes of emacs_write and emacs_read.
4454
11997c76
EZ
44552011-04-11 Eli Zaretskii <eliz@gnu.org>
4456
4457 * xdisp.c (redisplay_window): Don't try to determine the character
4458 position of the scroll margin if the window start point w->startp
e896f03c 4459 is outside the buffer's accessible region. (Bug#8468)
11997c76 4460
8a2cbd72
EZ
44612011-04-10 Eli Zaretskii <eliz@gnu.org>
4462
4463 Fix write-region and its subroutines for buffers > 2GB.
4464 * fileio.c (a_write, e_write): Modify declaration of arguments and
4465 local variables to support buffers larger than 2GB.
4466 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4467
4468 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4469 argument, local variables, and return value.
4470
4471 * lisp.h: Update prototypes of emacs_write and emacs_read.
4472
4473 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4474
4073e537 44752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4476
1ebfdcb6
PE
4477 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4478
b2ded58d
PE
4479 Fix more problems found by GCC 4.6.0's static checks.
4480
7d66342c
PE
4481 * xdisp.c (vmessage): Use a better test for character truncation.
4482
bbf47d44
PE
4483 * charset.c (load_charset_map): <, not <=, for optimization,
4484 and to avoid potential problems with integer overflow.
9248994d 4485 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4486 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4487 * editfns.c (Fformat): Likewise.
1e69125e 4488 * syntax.c (skip_chars): Likewise.
3befa583 4489
e3019616
PE
4490 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4491 This also lets GCC 4.6.0 generate slightly better loop code.
4492
becfa255
PE
4493 * callint.c (Fcall_interactively): <, not <=, for optimization.
4494 (Fcall_interactively): Count the number of arguments produced,
4495 not the number of arguments given. This is simpler and lets GCC
4496 4.6.0 generate slightly better code.
4497
dae0cd48
PE
4498 * ftfont.c: Distingish more carefully between FcChar8 and char.
4499 The previous code passed unsigned char * to a functions like
4500 strlen and xstrcasecmp that expect char *, which does not
4501 conform to the C standard.
4502 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4503 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4504 char * when the C standard requires it.
4505
76032d70
PE
4506 * keyboard.c (read_char): Remove unused var.
4507
eb3f1cc8
PE
4508 * eval.c: Port to Windows vsnprintf (Bug#8435).
4509 Include <limits.h>.
4510 (SIZE_MAX): Define if the headers do not.
4511 (verror): Do not give up if vsnprintf returns a negative count.
4512 Instead, grow the buffer. This ports to Windows vsnprintf, which
4513 does not conform to C99. Problem reported by Eli Zaretskii.
4514 Also, simplify the allocation scheme, by avoiding the need for
4515 calling realloc, and removing the ALLOCATED variable.
4516
70476b54
PE
4517 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4518
12020a9e
PE
4519 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4520 But keep the doprint source code for now, as we might revamp it
4521 and use it again (Bug#8435).
ea6c7ae6
PE
4522 * lisp.h (doprnt): Remove.
4523 * Makefile.in (base_obj): Remove doprnt.o.
4524 * deps.mk (doprnt.o): Remove.
4525
5fdb398c
PE
4526 error: Print 32- and 64-bit integers portably (Bug#8435).
4527 Without this change, on typical 64-bit hosts error ("...%d...", N)
4528 was used to print both 32- and 64-bit integers N, which relied on
4529 undefined behavior.
4530 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4531 New macro.
4532 * lisp.h (error, verror): Mark as printf-like functions.
4533 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4534 Report overflow in size calculations when allocating printf buffer.
4535 Do not truncate output string at its first null byte.
4536 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4537 Truncate the output at a character boundary, since vsnprintf does not
4538 do that.
4539 * charset.c (check_iso_charset_parameter): Convert internal
4540 character to string before calling 'error', since %c now has the
4541 printf meaning.
4542 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4543 overflow when computing char to be passed to 'error'. Do not
4544 pass Lisp_Object to 'error'; pass the integer instead.
4545 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4546 formatted with plain %d.
4547
b189fa66
PE
4548 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4549
bff87ef0
PE
4550 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4551
7e2cac20
PE
4552 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4553
ce4d90b5
PE
4554 * xterm.c (x_catch_errors): Remove duplicate declaration.
4555
266c9547
PE
4556 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4557
79c49ad2
PE
4558 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4559
368f4090
JM
45602011-04-10 Jim Meyering <meyering@redhat.com>
4561
4562 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4563 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4564 return ssize_t not "int", and use size_t as the buffer length.
4565 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4566 * gnutls.h: Update declarations.
4567 * process.c (read_process_output): Use ssize_t, to match.
4568 (send_process): Likewise.
4569
a32d4040
CY
45702011-04-09 Chong Yidong <cyd@stupidchicken.com>
4571
4572 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4573
8546720e 45742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4575
04f2d78b
CB
4576 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4577 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4578
8546720e
GM
4579 * xterm.c (handle_one_xevent):
4580 * xmenu.c (create_and_show_popup_menu):
4581 * xselect.c (x_decline_selection_request)
4582 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4583
0a2f5c1a 45842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4585
4586 Fix some uses of `int' instead of EMACS_INT.
4587 * search.c (string_match_1, fast_string_match)
4588 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4589 (scan_buffer, find_next_newline_no_quit)
4590 (find_before_next_newline, search_command, Freplace_match)
4591 (Fmatch_data): Make some `int' variables be EMACS_INT.
4592
4593 * xdisp.c (display_count_lines): 3rd argument and return value now
4594 EMACS_INT. All callers changed.
4595 (pint2hrstr): Last argument is now EMACS_INT.
4596
4597 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4598 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4599 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4600 (decode_coding_utf_16, decode_coding_emacs_mule)
4601 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4602 (decode_coding_ccl, decode_coding_charset)
4603 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4604 (decode_coding_iso_2022, decode_coding_emacs_mule)
4605 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4606 <char_offset, last_offset>: Declare EMACS_INT.
4607 (encode_coding_utf_8, encode_coding_utf_16)
4608 (encode_coding_emacs_mule, encode_invocation_designation)
4609 (encode_designation_at_bol, encode_coding_iso_2022)
4610 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4611 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4612 Declare EMACS_INT.
4613 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4614 (encode_invocation_designation): Last argument P_NCHARS is now
4615 EMACS_INT.
4616 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4617 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4618
4619 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4620 All users changed.
4621
4622 * ccl.c (Fccl_execute_on_string): Declare some variables
4623 EMACS_INT.
4624
8546720e 46252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4626
4627 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4628
4e19a977
CS
46292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4630
4631 * process.c (Fformat_network_address): Doc fix.
4632
87302331
R
46332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4634
4635 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4636
cbb59342
CY
46372011-04-08 Chong Yidong <cyd@stupidchicken.com>
4638
4639 * keyboard.c (read_char): Call Lisp function help-form-show,
4640 instead of using internal_with_output_to_temp_buffer.
4641 (Qhelp_form_show): New var.
e0d38eeb 4642 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4643
4644 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4645
4646 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4647
e67a13ab
CY
46482011-04-06 Chong Yidong <cyd@stupidchicken.com>
4649
04f2d78b
CB
4650 * process.c (Flist_processes): Remove to Lisp.
4651 (list_processes_1): Delete.
e67a13ab 4652
973f782d
EZ
46532011-04-06 Eli Zaretskii <eliz@gnu.org>
4654
7c106b1e
EZ
4655 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4656
973f782d
EZ
4657 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4658
41cf7d1a 46592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4660
ca23cc88
PE
4661 Fix more problems found by GCC 4.6.0's static checks.
4662
f390e2d5
PE
4663 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4664
42eea0d0
PE
4665 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4666
b69769da 4667 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4668
f9541e84
PE
4669 * xdisp.c (vmessage): Mark as a printf-like function.
4670
13841b55
PE
4671 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4672
c136c10f
PE
4673 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4674
5e2d4a30
PE
4675 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4676 printf-like functions.
4677 (tiff_load): Add casts to remove these marks before passing them
4678 to system-supplied API.
4679
583f48b9
PE
4680 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4681
b25d760e
PE
4682 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4683 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4684 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4685 directly, rather than having caller test rule sign. This avoids
4686 some unnecessary tests.
4687 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4688 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4689 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4690
bc7b6697 4691 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4692 (xfont_open): Avoid unnecessary tests.
bc7b6697 4693
27ccc379
PE
4694 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4695
dcd5c89a
PE
4696 * composite.h, composite.c (composition_gstring_put_cache):
4697 Use EMACS_INT, not int, for length.
4698
b13a45c6
PE
4699 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4700 breaking out part of COMPOSITION_DECODE_RULE.
4701 (COMPOSITION_DECODE_RULE): Use it.
4702 * composite.c (get_composition_id): Remove unused local vars,
4703 by using the new macro.
4704
1e792e4d
PE
4705 * textprop.c (set_text_properties_1): Change while to do-while,
4706 since the condition is always true at first.
4707
dc6c6455 4708 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4709 (interval_deletion_adjustment): Return unsigned value.
4710 All uses changed.
dc6c6455 4711
aba7731a
PE
4712 * process.c (list_processes_1, create_pty, read_process_output):
4713 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4714 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4715 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4716 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4717 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4718
fdfc4bf3
PE
4719 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4720
fca8fe46 4721 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4722 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4723
06a0259a 4724 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4725 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4726 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4727
e7b9e80f
PE
4728 * print.c (print_error_message): Avoid int overflow.
4729
56201685
PE
4730 * font.c (font_list_entities): Redo for clarity,
4731 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4732
78834453 4733 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4734 (font_score): Avoid potential overflow in diff calculation.
78834453 4735
0bc0b309 4736 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4737 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4738
e610eaca
PE
4739 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4740
b895abce
PE
4741 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4742 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4743 can always succeed if overflow has undefined behavior.
4744
1f1d9321 4745 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4746 (wordify): Omit three unnecessary tests.
1f1d9321 4747
c59478bc
PE
4748 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4749 All callers changed. This avoids the need for an unused var.
4750
79b73827
PE
4751 * casefiddle.c (casify_region): Remove var that is set but not used.
4752
a4db5dfe
PE
4753 * dired.c (file_name_completion): Remove var that is set but not used.
4754
43aae36e
PE
4755 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4756
2a47c44d 4757 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4758 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4759
a37c69bf
PE
4760 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4761 Check for integer overflow on size calculations.
4762
328ab8e7
PE
4763 * buffer.c (Fprevious_overlay_change): Remove var that is set
4764 but not used.
4765
e5a2a5cb
PE
4766 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4767 Remove vars that are set but not used.
8d84a6eb 4768 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4769 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4770
a60e5f68
PE
4771 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4772
f661cb61 4773 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4774 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4775
f0397f5a
PE
4776 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4777 that are set but not used.
4778
8664db06 4779 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4780 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4781
6abdaa4a
PE
4782 * xselect.c (x_get_local_selection, x_handle_property_notify):
4783 Remove vars that are set but not used.
4784
0ce7538d 4785 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4786 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4787
9ae848fc
PE
4788 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4789 Remove var that is set but not used.
0b918413
PE
4790 (scroll_bar_windows_size): Now size_t, not int.
4791 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4792 Check for overflow.
9ae848fc 4793
a5a62657
PE
4794 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4795 (map_tty_color) [!defined MSDOS]: Likewise.
4796
5c5cdd39
PE
4797 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4798
66ebf983
PE
4799 * coding.c: Remove vars that are set but not used.
4800 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4801 All callers changed.
4802 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4803 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4804 (decode_coding_charset): Remove vars that are set but not used.
4805
1be4d761
PE
4806 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4807 that is set but not used.
4808
47553fa8
PE
4809 * print.c (print_object): Remove var that is set but not used.
4810
1f7196bf 4811 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4812 The gnulib version avoids calling malloc in the usual case,
4813 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4814 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4815 * filelock.c (current_lock_owner): Likewise.
4816 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4817 * sysdep.c: Include allocator.h, careadlinkat.h.
4818 (emacs_no_realloc_allocator): New static constant.
4819 (emacs_readlink): New function.
fdb61804
PE
4820 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4821 ../lib/careadlinkat.h.
d1fdcab7 4822
f84c17c7
SM
48232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4824
4825 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4826 first non-nil return value).
4827
ef3862ad
JD
48282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4829
4830 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4831 if not defined (Bug#8403).
4832
376a7006
JB
48332011-04-02 Juanma Barranquero <lekktu@gmail.com>
4834
4835 * xdisp.c (display_count_lines): Remove parameter `start',
4836 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4837 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4838 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4839 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4840 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4841 and thereabouts. All callers changed.
4842 (get_per_char_metric): Remove parameter `f', unused since
4843 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4844
6ca3801d
JM
48452011-04-02 Jim Meyering <meyering@redhat.com>
4846
4847 do not dereference NULL upon failed strdup
4848 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4849 (ns_get_family): Likewise.
4850
d8e2b5ba
JB
48512011-04-02 Juanma Barranquero <lekktu@gmail.com>
4852
4853 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4854
8c74fcbd
JD
48552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4856
4857 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4858 later (Bug#8403).
4859
7200d79c
SM
48602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4861
03408648 4862 Add lexical binding.
7200d79c 4863
03408648
SM
4864 * window.c (Ftemp_output_buffer_show): New fun.
4865 (Fsave_window_excursion):
4866 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4867
4868 * lread.c (lisp_file_lexically_bound_p): New function.
4869 (Fload): Bind Qlexical_binding.
4870 (readevalloop): Remove `evalfun' arg.
4871 Bind Qinternal_interpreter_environment.
4872 (Feval_buffer): Bind Qlexical_binding.
4873 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4874 Mark as dynamic.
4875 (syms_of_lread): Declare `lexical-binding'.
4876
4877 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4878
4879 * keyboard.c (eval_dyn): New fun.
4880 (menu_item_eval_property): Use it.
ca105506
SM
4881
4882 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4883
03408648
SM
4884 * fns.c (concat, mapcar1): Accept byte-code-functions.
4885
4886 * eval.c (Fsetq): Handle lexical vars.
4887 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4888 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4889 (FletX, Flet): Obey lexical binding.
4890 (Fcommandp): Handle closures.
4891 (Feval): New `lexical' arg.
4892 (eval_sub): New function extracted from Feval. Use it almost
4893 everywhere where Feval was used. Look up vars in lexical env.
4894 Handle closures.
4895 (Ffunctionp): Move from subr.el.
4896 (Ffuncall): Handle closures.
4897 (apply_lambda): Remove `eval_flags'.
4898 (funcall_lambda): Handle closures and new byte-code-functions.
4899 (Fspecial_variable_p): New function.
4900 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4901 but without exporting it to Lisp.
23aba0ea 4902
23aba0ea 4903 * doc.c (Fdocumentation, store_function_docstring):
03408648 4904 * data.c (Finteractive_form): Handle closures.
23aba0ea 4905
03408648
SM
4906 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4907 interactive spec.
ba83908c 4908
04f2d78b
CB
4909 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4910 New byte-codes.
03408648
SM
4911 (exec_byte_code): New function extracted from Fbyte_code to handle new
4912 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4913
03408648 4914 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4915
03408648 4916 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4917
e2abce01
JB
49182011-03-31 Juanma Barranquero <lekktu@gmail.com>
4919
4920 * xdisp.c (redisplay_internal): Fix prototype.
4921
63696a73 49222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4923
63696a73 4924 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4925 (try_scrolling): Use it when setting scroll_limit.
4926 Limit scrolling to 100 screen lines.
63696a73
EZ
4927 (redisplay_window): Even when falling back on "recentering",
4928 position point in the window according to scroll-conservatively,
4929 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4930
4931 (try_scrolling): When point is above the window, allow searching
4932 as far as scroll_max, or one screenful, to compute vertical
4933 distance from PT to the scroll margin position. This prevents
4934 try_scrolling from unnecessarily failing when
4935 scroll-conservatively is set to a value slightly larger than the
4936 window height. Clean up the case of PT below the margin at bottom
4937 of window: scroll_max can no longer be INT_MAX. When aggressive
4938 scrolling is in use, don't let point enter the opposite scroll
4939 margin as result of the scroll.
4940 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4941 threshold of 100 lines for never-recentering scrolling.
4942
e4cc2dfc
JB
49432011-03-31 Juanma Barranquero <lekktu@gmail.com>
4944
4945 * dispextern.h (move_it_by_lines):
4946 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4947 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4948 (message_log_check_duplicate): Remove parameters `prev_bol' and
4949 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4950 (redisplay_internal): Remove parameter `preserve_echo_area',
4951 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4952
4953 * indent.c (Fvertical_motion):
4954 * window.c (window_scroll_pixel_based, Frecenter):
4955 Don't pass `need_y_p' to `move_it_by_lines'.
4956
1c470562
SM
49572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4958
44f230aa
SM
4959 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4960 steal a few bits to be more compact.
4961 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4962 Remove unneeded casts.
4963
1c470562
SM
4964 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4965
888adce9
ZK
49662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4967
4968 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4969 binding" message (bug#7967).
4970
f838ed7b
PE
49712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4972
77861b95
PE
4973 Fix more problems found by GCC 4.6.0's static checks.
4974
de6dbc14
PE
4975 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4976 Remove unused local var.
4977
f838ed7b
PE
4978 * editfns.c (Fmessage_box): Remove unused local var.
4979
792c7b2b
PE
4980 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4981 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4982 Omit unused local vars.
c499e557 4983 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4984 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4985 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4986 Omit unused local var.
4987
ba0165e1
PE
4988 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4989 Don't assume string length fits in int.
32ad8845 4990 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4991 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4992
3c59b4c9
PE
4993 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4994 instead of alloca (Bug#8344).
4995
a3eed478 4996 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4997 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4998
eb4d412d
PE
4999 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5000
1658b401
PE
5001 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5002 concerns.
5003
5004 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5005
5006 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5007
9a2c6e05
PE
5008 * keyboard.c (syms_of_keyboard): Use the same style as later
5009 in this function when indexing through an array. This also
5010 works around GCC bug 48267.
5011
03d0a109
PE
5012 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5013
44f730c8
PE
5014 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5015
fe75f926
PE
5016 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5017 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5018
ffa8c828
PE
5019 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5020 This avoids undefined behavior on integer overflow, and is a bit
5021 more convenient anyway since it is compared to a size_t variable.
5022
c5101a77
PE
5023 Variadic C functions now count arguments with size_t, not int.
5024 This avoids an unnecessary limitation on 64-bit machines, which
5025 caused (substring ...) to crash on large vectors (Bug#8344).
5026 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5027 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5028 All variadic functions and their callers changed accordingly.
c5101a77
PE
5029 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5030 * data.c (arith_driver, float_arith_driver): Likewise.
5031 * editfns.c (general_insert_function): Likewise.
5032 * eval.c (struct backtrace.nargs, interactive_p)
5033 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5034 (funcall_lambda, mark_backtrace): Likewise.
5035 * fns.c (concat): Likewise.
5036 * frame.c (x_set_frame_parameters): Likewise.
5037 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5038 0 if not found, not -1. All callers changed.
5039
dd3f25f7
PE
5040 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5041 (stack_copy_size): Now size_t, not int.
5042 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5043
461c2ab9
JB
50442011-03-28 Juanma Barranquero <lekktu@gmail.com>
5045
5046 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5047 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5048 All callers changed.
5049
5050 * lisp.h (multibyte_char_to_unibyte):
5051 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5052 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5053 * character.h (CHAR_TO_BYTE8):
5054 * cmds.c (internal_self_insert):
5055 * editfns.c (general_insert_function):
5056 * keymap.c (push_key_description):
5057 * search.c (Freplace_match):
5058 * xdisp.c (message_dolog, set_message_1): All callers changed.
5059
f6d62986
SM
50602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5061
5062 * keyboard.c (safe_run_hook_funcall): New function.
5063 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5064 don't set the hook to nil, but remove the offending function instead.
5065 (Qcommand_hook_internal): Remove, unused.
5066 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5067 Vcommand_hook_internal.
5068
5069 * eval.c (enum run_hooks_condition): Remove.
5070 (funcall_nil, funcall_not): New functions.
5071 (run_hook_with_args): Call each function through a `funcall' argument.
5072 Remove `cond' argument, now redundant.
5073 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5074 (Frun_hook_with_args_until_failure): Adjust accordingly.
5075 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5076
1db5b1ad
JB
50772011-03-28 Juanma Barranquero <lekktu@gmail.com>
5078
5079 * dispextern.h (string_buffer_position): Remove declaration.
5080
5081 * print.c (strout): Remove parameter `multibyte', unused since
5082 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5083
5084 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5085 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5086 All callers changed.
5087
5088 * w32.c (_wsa_errlist): Use braces for struct initializers.
5089
5090 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5091 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5092 All callers changed.
5093 (string_buffer_position): Likewise. Also, make static (it's never
5094 used outside xdisp.c).
5095 (cursor_row_p): Remove parameter `w', unused since
5096 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5097 (decode_mode_spec): Remove parameter `precision', introduced during
5098 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5099 All callers changed.
5100
5ffb62aa
JD
51012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5102
5103 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5104
461c2ab9 51052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5106
5107 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5108 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5109 (ns_update_auto_hide_menu_bar): New functions.
5110 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5111 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5112 ns_constrain_all_frames.
5113 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5114 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5115
5c380ffb
JD
51162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5117
5118 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5119
9af30bdf
GM
51202011-03-27 Glenn Morris <rgm@gnu.org>
5121
5122 * syssignal.h: Replace RETSIGTYPE with void.
5123 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5124 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5125 Replace SIGTYPE with void everywhere.
5126 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5127 * s/template.h (SIGTYPE): Remove commented out definition.
5128
e2abce01
JB
51292011-03-26 Eli Zaretskii <eliz@gnu.org>
5130
5131 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5132 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5133
f868cd8a
JB
51342011-03-26 Juanma Barranquero <lekktu@gmail.com>
5135
59eb0929
JB
5136 * w32.c (read_unc_volume): Use parameter `henum', instead of
5137 global variable `wget_enum_handle'.
5138
5139 * keymap.c (describe_vector): Remove parameters `indices' and
5140 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5141 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5142
f868cd8a
JB
5143 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5144
5145 * keyboard.c (timer_check): Remove parameter `do_it_now',
5146 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5147 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5148 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5149
5150 * keyboard.c (read_char):
5151 * w32menu.c (w32_menu_display_help):
5152 * xmenu.c (show_help_event, menu_help_callback):
5153 Adjust calls to `show_help_echo'.
5154
5155 * gtkutil.c (xg_maybe_add_timer):
5156 * keyboard.c (readable_events):
5157 * process.c (wait_reading_process_output):
5158 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5159
5160 * insdel.c (adjust_markers_gap_motion):
5161 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5162 (gap_left, gap_right): Don't call it.
5163
2ecf6fdb
CY
51642011-03-25 Chong Yidong <cyd@stupidchicken.com>
5165
5166 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5167 incurred during fontification.
5168
6b1f9ba4
JB
51692011-03-25 Juanma Barranquero <lekktu@gmail.com>
5170
5171 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5172 (DEFVAR_PER_BUFFER): Don't pass it.
5173
5174 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5175 (scrolling_window): Don't pass it.
5176
0f4a96b5
JB
51772011-03-25 Juanma Barranquero <lekktu@gmail.com>
5178
5179 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5180
5181 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5182 and `suffix'.
5183 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5184 of variables specific to SELinux and computation of `encoded_absname'.
5185
5186 * image.c (XPutPixel): Remove unused variable `height'.
5187
5188 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5189
5190 * unexw32.c (get_section_info): Remove unused variable `section'.
5191
5192 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5193 (system_process_attributes): Remove unused variable `sess'.
5194 (sys_read): Remove unused variable `err'.
5195
5196 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5197 (w32_wnd_proc): Remove unused variable `isdead'.
5198 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5199 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5200 (x_create_tip_frame): Remove unused variable `tem'.
5201
5202 * w32inevt.c (w32_console_read_socket):
5203 Remove unused variable `no_events'.
5204
5205 * w32term.c (x_draw_composite_glyph_string_foreground):
5206 Remove unused variable `width'.
5207
1149507c
JB
52082011-03-24 Juanma Barranquero <lekktu@gmail.com>
5209
5210 * w32term.c (x_set_glyph_string_clipping):
5211 Don't pass uninitialized region to CombineRgn.
5212
9c88f339
JB
52132011-03-23 Juanma Barranquero <lekktu@gmail.com>
5214
5215 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5216 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5217 (Fx_close_connection): Remove unused variable `i'.
5218
5219 * w32font.c (w32font_draw): Return number of glyphs.
5220 (w32font_open_internal): Remove unused variable `i'.
5221 (w32font_driver): Add missing initializer.
5222
5223 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5224 (fill_in_menu): Remove unused variable `items_added'.
5225
5226 * w32term.c (last_mouse_press_frame): Remove static global variable.
5227 (w32_clip_to_row): Remove unused variable `f'.
5228 (x_delete_terminal): Remove unused variable `i'.
5229
5230 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5231 (NOTHING): Remove unused static global variable.
5232 (uniscribe_check_otf): Remove unused variable `table'.
5233 (uniscribe_font_driver): Add missing initializers.
5234
dee091a3
JD
52352011-03-23 Julien Danjou <julien@danjou.info>
5236
5237 * term.c (Fsuspend_tty, Fresume_tty):
5238 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5239 * window.c (temp_output_buffer_show):
5240 * insdel.c (signal_before_change):
5241 * frame.c (Fhandle_switch_frame):
5242 * fileio.c (Fdo_auto_save):
5243 * emacs.c (Fkill_emacs):
5244 * editfns.c (save_excursion_restore):
5245 * cmds.c (internal_self_insert):
5246 * callint.c (Fcall_interactively):
5247 * buffer.c (Fkill_all_local_variables):
5248 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5249 Use Frun_hooks.
0f4a96b5 5250 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5251 unconditionnaly since it does the check itself.
5252
2c520ab5 52532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5254
c9c49752
PE
5255 Fix more problems found by GCC 4.5.2's static checks.
5256
8abc3f12
PE
5257 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5258 the first time through the loop, since we know p0 < p1 then.
5259 This also avoids a gcc -Wstrict-overflow warning.
5260
a2d26660
PE
5261 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5262 leading to a memory leak, possible in functions like
5263 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5264 of objects (Bug#8318).
a2d26660 5265
916c72e9
PE
5266 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5267 that could (at least in theory) be that large.
5268
19ab8a18
PE
5269 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5270 This is less likely to overflow, and avoids undefined behavior if
5271 overflow does occur. All callers changed. Use strtoul to scan
5272 for the unsigned long integer.
b7cbbd6f
PE
5273 (pint2hrstr): Simplify and tune code slightly.
5274 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5275
f0641eff
PE
5276 * scroll.c (do_scrolling): Work around GCC bug 48228.
5277 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5278
7f650bb9
PE
5279 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5280 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5281 (validate_x_resource_name): Simplify count usage.
5282 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5283
37dd57d1
PE
5284 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5285 fail (Bug#8306).
81e56e61 5286
699979fc 5287 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5288
401bf9b4
PE
5289 * process.c (Fmake_network_process): Use socklen_t, not int,
5290 where POSIX says socklen_t is required in portable programs.
5291 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5292 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5293 (Fmake_network_process, server_accept_connection):
5294 (wait_reading_process_output, read_process_output):
5295 Likewise.
5296
b93aacde
PE
5297 * process.c: Rename or move locals to avoid shadowing.
5298 (list_processes_1, Fmake_network_process):
5299 (read_process_output_error_handler, exec_sentinel_error_handler):
5300 Rename or move locals.
4dc343ee 5301 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5302 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5303 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5304 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5305 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5306
af8a867c 5307 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5308 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5309 Include tparam.h instead, since it declares them.
af8a867c
PE
5310 * cm.h (PC): Remove extern decl; tparam.h now does this.
5311 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5312 * terminfo.c: Include tparam.h, to check interfaces.
5313 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5314 (tparam): Adjust signature to match interface in tparam.h;
5315 this removes some undefined behavior. Check that outstring and len
5316 are zero, which they always are with Emacs.
5317 * tparam.h (PC, BC, UP): New extern decls.
5318
0248044d 5319 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5320 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5321
8ff096c1 5322 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5323 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5324 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5325 (ftfont_list): Remove unused local.
49eaafba
PE
5326 (get_adstyle_property, ftfont_pattern_entity):
5327 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5328 Rename locals to avoid shadowing.
8ff096c1 5329
e2be39f6
PE
5330 * xfont.c (xfont_list_family): Mark var as initialized.
5331
c9735e30
PE
5332 * xml.c (make_dom): Now static.
5333
8f5201ae
PE
5334 * composite.c (composition_compute_stop_pos): Rename local to
5335 avoid shadowing.
b246f932
PE
5336 (composition_reseat_it): Remove unused locals.
5337 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5338 (composition_update_it): Mark var as initialized.
11b61122
PE
5339 (find_automatic_composition): Mark vars as initialized,
5340 with a FIXME (Bug#8290).
8f5201ae 5341
760fbc2c
PE
5342 character.h: Rename locals to avoid shadowing.
5343 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5344 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5345 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5346 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5347 to avoid shadowing.
5348
ff08eb85
PE
5349 * textprop.c (property_change_between_p): Remove; unused.
5350
fc7bf025
PE
5351 * intervals.c (interval_start_pos): Now static.
5352
235d7abc
PE
5353 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5354
44f230aa
SM
5355 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5356 Rename locals to avoid shadowing.
3e7d6594 5357
50060332
PE
5358 * sound.c (wav_play, au_play, Fplay_sound_internal):
5359 Fix pointer signedness.
d01f234b 5360 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5361 (wav_play): Initialize a variable to 0, to prevent undefined
5362 behavior (Bug#8278).
50060332 5363
c4fc4e30
PE
5364 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5365
918436ed
PE
5366 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5367
c939f91b
PE
5368 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5369 clobbering (Bug#8298).
b9c7f648
PE
5370 * sysdep.c (sys_subshell): Likewise.
5371 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5372
6bd8c144
PE
5373 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5374 This should get cleaned up, so that child_setup has the
5375 same signature on all platforms.
5376
7710357c 5377 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5378 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5379
c59da222
CY
53802011-03-22 Chong Yidong <cyd@stupidchicken.com>
5381
5382 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5383 not to be necessary, and produces flickering.
5384
66b87493
GM
53852011-03-20 Glenn Morris <rgm@gnu.org>
5386
5387 * config.in: Remove file.
5388
45b6f6d5
JB
53892011-03-20 Juanma Barranquero <lekktu@gmail.com>
5390
5391 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5392 are now in src/globals.h.
5393 (syms_of_minibuf): Remove spurious & from previous change.
5394
3ec03f7e
LL
53952011-03-20 Leo <sdl.web@gmail.com>
5396
5397 * minibuf.c (completing-read-function): New variable.
5398 (completing-read-default): Rename from completing-read.
5399 (completing-read): Call completing-read-function.
5400
b14e3e21
CY
54012011-03-19 Juanma Barranquero <lekktu@gmail.com>
5402
5403 * xfaces.c (Fx_load_color_file):
5404 Read color file from absolute filename (bug#8250).
5405
f2b726e6
JB
54062011-03-19 Juanma Barranquero <lekktu@gmail.com>
5407
5408 * makefile.w32-in: Update dependencies.
5409
09f6ff02
EZ
54102011-03-17 Eli Zaretskii <eliz@gnu.org>
5411
5412 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5413
29a6015a
PE
54142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5415
a3a6c54e
PE
5416 Fix more problems found by GCC 4.5.2's static checks.
5417
b766f867
PE
5418 * process.c (make_serial_process_unwind, send_process_trap):
5419 (sigchld_handler): Now static.
5420
be02381c
PE
5421 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5422 That way, the code declares only the vars that it needs.
5423 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5424 * s/cygwin.h (PTY_ITERATION): Likewise.
5425 * s/darwin.h (PTY_ITERATION): Likewise.
5426 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5427
57048744
PE
5428 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5429 * process.c (allocate_pty): Don't declare stb unless it's needed.
5430
7914961c 5431 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5432 (CONSTANTLIM): Remove; unused.
5433 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5434 Define only if needed.
7914961c 5435
b3967b18
PE
5436 * unexelf.c (unexec): Name an expression,
5437 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5438 Use a different way to cause a compilation error if anyone uses
5439 n rather than nn, a way that does not involve shadowing.
73366a00 5440 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5441
29a6015a
PE
5442 * deps.mk (unexalpha.o): Remove; unused.
5443
43cfc33e 5444 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5445 * unexec.h: New file.
ce701a33
PE
5446 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5447 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5448 Depend on unexec.h.
5449 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5450 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5451 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5452 Change as necessary to match prototype in unexec.h.
ce701a33 5453
01f44d5a
PE
5454 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5455 shadowing.
4f63c6bb 5456 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5457
a6670b0b
PE
5458 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5459 Rename locals to avoid shadowing.
5460
cef2010d 5461 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5462 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5463
d4d7173a
PE
5464 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5465
f08b802a
PE
5466 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5467 warning when compiling print.c.
5468
3ddb0639
PE
5469 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5470 instead of using an uninitialized var.
5ad03b97 5471 (font_sort_entities): Mark var as initialized.
3ddb0639 5472
170a2692
PE
5473 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5474
e663c700
PE
5475 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5476 pointers to constants.
89bc529a 5477 (font_parse_fcname): Remove unused vars.
7b81e2d0 5478 (font_delete_unmatched): Now static.
ea838e10 5479 (font_get_spec): Remove; unused.
13a547c6
PE
5480 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5481 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5482 Rename or move locals to avoid shadowing.
e663c700 5483
2a80c887 5484 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5485 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5486
1384fa33 5487 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5488 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5489
8b2c52e9
PE
5490 * alloc.c (mark_backtrace): Move decl from here ...
5491 * lisp.h: ... to here, so that it can be checked.
5492
475545b5 5493 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5494 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5495 (lisp_indirect_variable): Name an expression,
5496 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5497 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5498
b1349114 5499 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5500 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5501 Use const pointer when appropriate.
b1349114 5502
a2928364
PE
5503 * lisp.h (get_system_name, get_operating_system_release):
5504 Move decls here, to check interfaces.
5505 * process.c (get_operating_system_release): Move decl to lisp.h.
5506 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5507 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5508 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5509 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5510 (Fformat_time_string, Fencode_time, Finsert_char):
5511 (Ftranslate_region_internal, Fformat):
5512 Rename or remove local vars to avoid shadowing.
9710023e 5513 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5514
a415e694
PE
5515 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5516 avoid shadowing.
5517
8ef4622d
PE
5518 * lisp.h (eassert): Check that the argument compiles, even if
5519 ENABLE_CHECKING is not defined.
5520
946f9a5b
PE
5521 * data.c (Findirect_variable): Name an expression, to avoid
5522 gcc -Wbad-function-cast warning.
112396d6 5523 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5524 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5525 (Fmake_variable_buffer_local, Fmake_local_variable):
5526 Mark variables as initialized.
52746918 5527 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5528
e5aab7e7 5529 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5530 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5531 Rename locals to avoid shadowing.
dff45157
PE
5532 (mark_stack): Move local variables into the #ifdef region where
5533 they're used.
7bc26fdb
PE
5534 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5535 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5536 needed otherwise.
5537 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5538 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5539 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5540
e5aab7e7
PE
5541 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5542 avoids undefined behavior in theory.
5543
4da60324
PE
5544 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5545
88043301
PE
5546 Use functions, not macros, for up- and down-casing (Bug#8254).
5547 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5548 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5549 to use the following functions instead of these macros.
5550 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5551 EMACS_INT, since callers assume the returned value fits in int.
5552 (upcase1): Likewise, for UPCASE_TABLE.
5553 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5554 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5555 the race-condition problem in the old DOWNCASE.
88043301 5556
19ed5445
PE
5557 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5558 Rename locals to avoid shadowing.
5559 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5560 (regex_compile, re_search_2, re_match_2_internal):
5561 Remove unused local vars.
952db0d7
PE
5562 (FREE_VAR): Rewrite so as not to use empty "else",
5563 which gcc can warn about.
da053e48 5564 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5565 (RETALLOC_IF): Define only if needed.
5566 (WORDCHAR_P): Likewise. This one is never needed, but is used
5567 only in a comment talking about a compiler bug, so put inside
5568 the #if 0 of that comment.
5569 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5570 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5571 Remove; unused.
19ed5445 5572
1f3561e4 5573 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5574 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5575 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5576
ded6f8f7
PE
5577 * search.c (simple_search): Remove unused var.
5578
dbd37a95
PE
5579 * dired.c (compile_pattern): Move decl from here ...
5580 * lisp.h: ... to here, so that it can be checked.
5581 (struct re_registers): New forward decl.
5582
7e47afad
PE
5583 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5584
85f24f61
PE
5585 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5586 All uses changed.
5587 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5588 Rename locals to avoid shadowing.
5671df8f 5589 (Fvertical_motion): Mark locals as initialized.
85f24f61 5590
181aa2be 5591 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5592 (casify_region): Mark local as initialized.
181aa2be 5593
930d429c
PE
5594 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5595
7082eac6
PE
5596 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5597 New macros, so that the caller can use some names other than
5598 gcpro1, gcpro2, etc.
5599 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5600 of the new macros.
5601 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5602 argument, for consistency with GCPRO2_VAR, etc: it is now the
5603 prefix of the variable, not the variable itself. All uses
5604 changed.
38b2c076
PE
5605 * dired.c (directory_files_internal, file_name_completion):
5606 Rename locals to avoid shadowing.
5607
15206ed9
PE
5608 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5609 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5610 dired.c's scmp function, had undefined behavior.
5611 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5612 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5613 * buffer.h: ... to here, because these macros use current_buffer,
5614 and the new implementation with inline functions needs to have
5615 current_buffer in scope now, rather than later when the macros
5616 are used.
5617 (downcase, upcase1): New static inline functions.
5618 (DOWNCASE, UPCASE1): Reimplement using these functions.
5619 This avoids undefined behavior in expressions like
5620 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5621 from race conditions in accessing the global variables
5622 case_temp1 and case_temp2.
5623 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5624 * lisp.h (case_temp1, case_temp2): Remove their decls.
5625 * character.h (ASCII_CHAR_P): Move from here ...
5626 * lisp.h: ... to here, so that the inline functions mentioned
5627 above can use them.
5628
4a6bea26
PE
5629 * dired.c (directory_files_internal_unwind): Now static.
5630
f14b7e14
PE
5631 * fileio.c (file_name_as_directory, directory_file_name):
5632 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5633 Now static.
2893f146
PE
5634 (file_name_as_directory): Use const pointers when appropriate.
5635 (Fexpand_file_name): Likewise. In particular, newdir might
5636 point at constant storage, so make it a const pointer.
fd4ead52 5637 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5638 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5639 signedness issues.
f839df0c
PE
5640 (Fset_file_times, Finsert_file_contents, auto_save_error):
5641 Rename locals to avoid shadowing.
f14b7e14 5642
5716756e 5643 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5644 (Ftry_completion, Fall_completions): Rename or remove locals
5645 to avoid shadowing.
5716756e 5646
b4c3046a
PE
5647 * marker.c (bytepos_to_charpos): Remove; unused.
5648
b45db522
PE
5649 * lisp.h (verify_bytepos, count_markers): New decls,
5650 so that gcc does not warn that these functions aren't declared.
5651
85876d07
PE
5652 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5653 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5654 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5655 (copy_text): Remove unused local var.
85876d07 5656
03d78a21 5657 * filelock.c (within_one_second): Now static.
b3dd38ab 5658 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5659
5df8f01b
PE
5660 * buffer.c (fix_overlays_before): Mark locals as initialized.
5661 (fix_start_end_in_overlays): Likewise. This function should be
5662 simplified by using pointers-to-pointers, but that's a different
5663 matter.
b1d876f1 5664 (switch_to_buffer_1): Now static.
8f54f30a
PE
5665 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5666 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5667
a70072c9 5668 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5669 Fix pointer signedness issue.
edced198
PE
5670 (sys_subshell): Mark local as volatile if checking for lint,
5671 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5672 (MAXPATHLEN): Define only if needed.
a70072c9 5673
a0977c44
PE
5674 * process.c (serial_open, serial_configure): Move decls from here ...
5675 * systty.h: ... to here, so that they can be checked.
5676
a884fdcc
PE
5677 * fns.c (get_random, seed_random): Move extern decls from here ...
5678 * lisp.h: ... to here, so that they can be checked.
5679
604efe86 5680 * sysdep.c (reset_io): Now static.
b8950c94 5681 (wait_for_termination_signal): Remove; unused.
604efe86 5682
38fc62d9
PE
5683 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5684 (copy_keymap_item, append_key, push_text_char_description):
5685 Now static.
1004a21a 5686 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5687 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5688 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5689 (describe_map_tree):
5690 Rename locals to avoid shadowing.
38fc62d9 5691
2f2650da
PE
5692 * keyboard.c: Declare functions static if they are not used elsewhere.
5693 (echo_char, echo_dash, cmd_error, top_level_2):
5694 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5695 (read_char, kbd_buffer_get_event, make_lispy_position):
5696 (make_lispy_event, make_lispy_movement, apply_modifiers):
5697 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5698 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5699 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5700 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5701 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5702
a053e86c 5703 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5704 (mark_kboards): Move decl here ...
5705 * alloc.c (mark_kboards): ... from here.
a053e86c 5706
4752793e
PE
5707 * lisp.h (force_auto_save_soon): New decl.
5708
74f10ca7 5709 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5710 (DEFINE_DUMMY_FUNCTION): New macro.
5711 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5712 Use it.
c03cd23f
PE
5713 (main): Add casts to avoid warnings
5714 if GCC considers string literals to be constants.
74f10ca7 5715
022e70d4
PE
5716 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5717
59d6fe83
PE
5718 * dbusbind.c: Pointer signedness fixes.
5719 (xd_signature, xd_append_arg, xd_initialize):
5720 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5721 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5722 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5723 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5724
78320123
PE
5725 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5726 if GCC considers string literals to be constants.
49cebcca 5727 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5728
35ac2a97
SM
57292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5730
fb103ca9
SM
5731 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5732 (print_preprocess, print_object): New macro to fix last change.
5733
35ac2a97
SM
5734 * print.c (print_preprocess): Don't forget font objects.
5735
62973b41
JB
57362011-03-16 Juanma Barranquero <lekktu@gmail.com>
5737
5738 * emacs.c (USAGE3): Doc fixes.
5739
0e48bb22
AS
57402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5741
5742 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5743 structure.
5744
7684e57b
JB
57452011-03-14 Juanma Barranquero <lekktu@gmail.com>
5746
5747 * lisp.h (VWindow_system, Qfile_name_history):
5748 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5749 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5750 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5751
5752 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5753 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5754
5755 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5756 * w32console.c (detect_input_pending, read_input_pending)
5757 (encode_terminal_code):
5758 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5759 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5760 (w32_system_caret_y, Qfile_name_history):
5761 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5762 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5763 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5764 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5765 * w32proc.c (Qlocal, report_file_error):
5766 * w32term.c (Vwindow_system, updating_frame):
5767 * w32uniscribe.c (initialized, uniscribe_font_driver):
5768 Remove unneeded extern declarations.
5769
2aa46d6c
CY
57702011-03-14 Chong Yidong <cyd@stupidchicken.com>
5771
c96bbc66 5772 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5773
cffc6f3b
CY
57742011-03-13 Chong Yidong <cyd@stupidchicken.com>
5775
5776 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5777 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5778 These macros can no longer be used for assignment.
5779
44f230aa
SM
5780 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5781 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5782 (record_buffer_markers, fetch_buffer_markers): New functions for
5783 recording and fetching special buffer markers.
5784 (set_buffer_internal_1, set_buffer_temp): Use them.
5785
5786 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5787
5788 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5789
5790 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5791 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5792
5793 * xdisp.c (hscroll_window_tree):
5794 (reconsider_clip_changes): Use PT instead of BUF_PT.
5795
d251f04b
EZ
57962011-03-13 Eli Zaretskii <eliz@gnu.org>
5797
5798 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5799 $(EMACS_ROOT)/lib/intprops.h.
5800
f0c77cd1
PE
58012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5802
3eca4629
PE
5803 Fix more problems found by GCC 4.5.2's static checks.
5804
7c86ee98
PE
5805 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5806 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5807 (xg_free_frame_widgets): Make it clear that a local variable is
5808 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5809 (gdk_window_get_screen): Make it clear that this macro is needed
5810 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5811 (int_gtk_range_get_value): New function, which avoids a diagnostic
5812 from gcc -Wbad-function-cast.
5813 (xg_set_toolkit_scroll_bar_thumb): Use it.
5814 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5815 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5816 (get_utf8_string, xg_get_file_with_chooser):
5817 Rename locals to avoid shadowing.
5818 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5819
41729b81
PE
5820 * xgselect.c (xg_select): Remove unused var.
5821
f0c77cd1
PE
5822 * image.c (four_corners_best): Mark locals as initialized.
5823 (gif_load): Initialize transparent_p to zero (Bug#8238).
5824 Mark another local as initialized.
ec6cf4c6 5825 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5826
ce0ad53d 5827 * image.c (clear_image_cache): Now static.
d5d5a617 5828 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5829 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5830 (x_edge_detection): Remove unnecessary cast that
5831 gcc -Wbad-function-cast diagnoses.
2037898d 5832 (gif_load): Fix pointer signedness.
6ae141d6
PE
5833 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5834 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5835
33383987 58362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5837
d32df629
PE
5838 Improve quality of tests for time stamp overflow.
5839 For example, without this patch (encode-time 0 0 0 1 1
5840 1152921504606846976) returns the obviously-bogus value (-948597
5841 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5842 reports time overflow. See
5843 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5844 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5845 * editfns.c: Include limits.h and intprops.h.
5846 (TIME_T_MIN, TIME_T_MAX): New macros.
5847 (time_overflow): Move earlier, to before first use.
5848 (hi_time, lo_time): New functions, for an accurate test for
5849 out-of-range times.
5850 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5851 (Fget_internal_run_time): Don't assume time_t fits in int.
5852 (make_time): Use list2 instead of Fcons twice.
5853 (Fdecode_time): More accurate test for out-of-range times.
5854 (check_tm_member): New function.
5855 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5856 (lisp_time_argument): Don't rely on undefined left-shift and
5857 right-shift behavior when checking for time stamp overflow.
8be6f318 5858
fe31d94c
PE
5859 * editfns.c (time_overflow): New function, refactoring common code.
5860 (Fformat_time_string, Fdecode_time, Fencode_time):
5861 (Fcurrent_time_string): Use it.
5862
8be6f318
PE
5863 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5864 * dired.c (make_time): Move to ...
5865 * editfns.c (make_time): ... here.
5866 * systime.h: Note the move.
5867
09d9db2c 58682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5869
126bc0dc
YM
5870 * fringe.c (update_window_fringes): Remove unused variables.
5871
c47cbdfd
YM
5872 * unexmacosx.c (copy_data_segment): Also copy __got section.
5873 (Bug#8223)
5874
7ac80be9
EZ
58752011-03-12 Eli Zaretskii <eliz@gnu.org>
5876
c96bbc66 5877 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5878 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5879 Constify `char *' arguments and their references according to
5880 prototypes in tparam.h.
5881
ecb0f94d 5882 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5883
7ac80be9
EZ
5884 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5885 Adapt all references accordingly.
5886
5887 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5888
ef1fd07e
TT
58892011-03-11 Tom Tromey <tromey@redhat.com>
5890
5891 * buffer.c (syms_of_buffer): Remove obsolete comment.
5892
7ef4b50c
EZ
58932011-03-11 Eli Zaretskii <eliz@gnu.org>
5894
5895 * termhooks.h (encode_terminal_code): Declare prototype.
5896
5897 * msdos.c (encode_terminal_code): Don't declare prototype.
5898
5899 * term.c (encode_terminal_code): Now external again, used by
5900 w32console.c and msdos.c.
5901
44f230aa
SM
5902 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5903 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5904
4b1ec863 59052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5906
1714f52b 5907 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5908
4b1ec863
PE
5909 * fringe.c (update_window_fringes): Mark locals as initialized
5910 (Bug#8227).
5911 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5912
524c7aa6
PE
5913 * alloc.c (mark_fringe_data): Move decl from here ...
5914 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5915 to check its interface.
5916 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5917
a5c0af81 5918 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5919 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5920 (fontset_font): Mark local as initialized.
a9a06e0b 5921 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5922
b4716021
PE
5923 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5924
811e9bac 5925 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5926 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5927 (x_own_selection, Fx_disown_selection_internal): Rename locals
5928 to avoid shadowing.
5929 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5930
7e3ab302
PE
5931 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5932 so that the caller can use some name other than gcpro1.
5933 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5934 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5935 (Fx_backspace_delete_keys_p):
5936 Use them to avoid shadowing, and rename vars to avoid shadowing.
5937 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5938 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5939 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5940 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5941 Remove unused locals.
7e3ab302
PE
5942 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5943 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5944 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5945 macros.
f78faa98 5946
e2b13473
PE
5947 * xterm.h (x_mouse_leave): New decl.
5948
77f23912
PE
5949 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5950 Remove unused functions.
cdf4ba58
PE
5951 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5952 (x_calc_absolute_position): Now static.
7411c686 5953 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5954 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5955 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5956 unless they are used.
38d0b34a
PE
5957 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5958 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5959 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5960 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5961 (x_error_catcher, x_connection_closed, x_error_handler):
5962 (x_error_quitter, xembed_send_message, x_iconify_frame):
5963 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5964 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5965 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5966
44f230aa
SM
5967 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5968 Rename or move locals to avoid shadowing.
6b463e58 5969 (tty_defined_color, merge_face_heights): Now static.
5967d051 5970 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5971 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5972 does not deduce is never used uninitialized.
73719eba
PE
5973 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5974 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5975
426994c3 5976 * terminal.c (store_terminal_param): Now static.
5489860b 5977
032f1620 5978 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5979 (set_frame_menubar): Remove unused local.
d4323972 5980 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5981 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5982 since they might point to immutable storage.
281585b0
PE
5983 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5984 since it's unused otherwise.
032f1620 5985
367c19e5 5986 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5987 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5988 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5989 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5990 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5991 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5992 does not deduce are never used uninitialized.
70739cbe 5993
07b48fa9
PE
5994 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5995
8868a238 5996 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5997 * window.c (window_loop, size_window):
5998 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5999
7e5cf297 6000 * window.c (display_buffer): Now static.
d6550a9f
PE
6001 (size_window): Mark variables that gcc -Wuninitialized
6002 does not deduce are never used uninitialized.
a586633d
PE
6003 * window.h (check_all_windows): New decl, to forestall
6004 gcc -Wmissing-prototypes diagnostic.
5b555da1 6005 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6006
f6095868
PE
6007 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6008 shadowing.
6009 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6010 Include <limits.h>.
6011 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6012 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6013 (load_charset_map): Mark variables that gcc -Wuninitialized
6014 does not deduce are never used uninitialized.
53df7c11 6015 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6016
f38b440c
PE
6017 * coding.c (coding_set_source, coding_set_destination):
6018 Use "else { /* comment */ }" rather than "else /* comment */;"
6019 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6020 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6021 a block, when the outer 'i' will do.
6022 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6023 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6024 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6025 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6026 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6027 Rename locals to avoid shadowing.
6028 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6029 * coding.c (emacs_mule_char, encode_invocation_designation):
6030 Now static, since they're not used elsewhere.
413bb2db 6031 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6032 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6033 (decode_coding_emacs_mule): Mark variables that gcc
6034 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6035 (detect_coding_iso_2022): Initialize a local variable that might
6036 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6037 this initialization is needed. (Bug#8211)
5f58e762
PE
6038 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6039 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6040 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6041 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6042 Remove unused macros.
f38b440c 6043
232b38b9 6044 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6045 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6046 * character.c (string_count_byte8): Likewise.
232b38b9 6047
fb90da1b
PE
6048 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6049 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6050
fb93dbc2
PE
6051 * chartab.c (copy_sub_char_table): Now static, since it's not used
6052 elsewhere.
5c156ace
PE
6053 (sub_char_table_ref_and_range, char_table_ref_and_range):
6054 Rename locals to avoid shadowing.
bbcd0949 6055 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6056
7d3b3862 6057 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6058 (BIDI_BOB): Remove unused macro.
7d3b3862 6059
6be7d3da
PE
6060 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6061 deduce are never used uninitialized.
c2ed9c8b 6062 * term.c (encode_terminal_code): Likewise.
6be7d3da 6063
75f8807f 6064 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6065
50938595
PE
6066 * tparam.h: New file.
6067 * term.c, tparam.h: Include it.
6068 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6069 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6070 Move these decls to tparam.h, and make them agree with what
6071 is actually in tparam.c. The previous trick of using incompatible
6072 decls in different modules does not conform to the C standard.
6073 All callers of tparam changed to use tparam's actual API.
6074 * tparam.c (tparam1, tparam, tgoto):
6075 Use const pointers where appropriate.
6076
fbceeba2
PE
6077 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6078 * cm.h (struct cm): Likewise.
6079 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6080 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6081 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6082 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6083 (turn_on_face, init_tty): Likewise.
6084 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6085
7f3f1250
PE
6086 * term.c (term_mouse_position): Rename local to avoid shadowing.
6087
e6ca6543
PE
6088 * alloc.c (mark_ttys): Move decl from here ...
6089 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6090
c40f8d15
AS
60912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6092
6093 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6094
cfe0661d
JB
60952011-03-09 Juanma Barranquero <lekktu@gmail.com>
6096
6097 * search.c (compile_pattern_1): Remove argument regp, unused since
6098 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6099 (compile_pattern): Don't pass it.
6100
0afb4571
J
61012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6102
6103 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6104 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6105 for ! HAVE_GTK3.
6106 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6107
6108 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6109
6110 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6111 gdk_window_get_screen, gdk_window_get_geometry,
6112 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6113 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6114 (xg_get_pixbuf_from_pixmap): New function.
6115 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6116 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6117 Call xg_get_pixbuf_from_pixmap instead of
6118 gdk_pixbuf_get_from_drawable.
6119 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6120 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6121 (xg_check_special_colors): Use GtkStyleContext and its functions
6122 for HAVE_GTK3.
6123 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6124 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6125 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6126 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6127 Call gtk_widget_get_preferred_size.
0afb4571
J
6128 (xg_frame_resized): gdk_window_get_geometry only takes 5
6129 parameters.
44f230aa
SM
6130 (xg_win_to_widget, xg_event_is_for_menubar):
6131 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6132 (xg_set_widget_bg): New function.
6133 (delete_cb): New function.
895009e1 6134 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6135 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6136 (xg_set_background_color): Call xg_set_widget_bg.
6137 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6138 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6139 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6140 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6141 if ! HAVE_GTK3.
6142 (update_frame_tool_bar): Call gtk_widget_hide.
6143 (xg_initialize): Use GDK_KEY_g.
6144
6145 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6146 if ! HAVE_GTK3
6147 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6148
6149 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6150 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6151 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6152
1c2cc4ef
JB
61532011-03-08 Juanma Barranquero <lekktu@gmail.com>
6154
6155 * w32xfns.c (select_palette): Check success of RealizePalette against
6156 GDI_ERROR, not zero.
6157
33383987 6158See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6159
6160;; Local Variables:
6161;; coding: utf-8
aac0c6e3
MR
6162;; End:
6163
33383987 6164 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6165
6166 This file is part of GNU Emacs.
6167
6168 GNU Emacs is free software: you can redistribute it and/or modify
6169 it under the terms of the GNU General Public License as published by
6170 the Free Software Foundation, either version 3 of the License, or
6171 (at your option) any later version.
6172
6173 GNU Emacs is distributed in the hope that it will be useful,
6174 but WITHOUT ANY WARRANTY; without even the implied warranty of
6175 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6176 GNU General Public License for more details.
6177
6178 You should have received a copy of the GNU General Public License
6179 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.