* nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
[bpt/emacs.git] / src / ChangeLog
CommitLineData
62f19c19
PE
12011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2ea16b89
PE
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
9d1df220
PE
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
33ef5c64
PE
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
66c6fdd5
PE
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
d749b01b
PE
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
b5cd1905
PE
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
41
c21721cc
PE
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
51
c57b67fc
PE
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
54
8a401434
PE
55 * frame.c (tty_frame_count): Now printmax_t, not int.
56 (make_terminal_frame, set_term_frame_name): Print it.
57 (x_report_frame_params): In X, window IDs are unsigned long,
58 not signed long, so print them as unsigned.
59 (validate_x_resource_name): Check for implausibly long names,
60 and don't assume name length fits in 'int'.
61 (x_get_resource_string): Don't blindly alloca invocation name;
62 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
63 not fit in int.
64
84722b3d
PE
65 * gtkutil.c (xg_check_special_colors, xg_set_geometry):
66 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
67
0df02bf3
PE
68 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
69 Use esprintf, not sprintf, in case result does not fit in int.
70
48e30793
PE
71 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
72 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
73 it as a large positive number.
74 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
75 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
76
a66ff6d8
PE
77 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
78 in case result does not fit in int.
79
5fc295a4 802011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 81
70c60eb2 82 Integer and memory overflow issues (Bug#9196).
726e0ab1 83
d31850da
PE
84 * doc.c (get_doc_string): Rework so that
85 get_doc_string_buffer_size is the actual buffer size, rather than
86 being 1 less than the actual buffer size; this makes xpalloc more
87 convenient.
88
a69fbedb
PE
89 * image.c (x_allocate_bitmap_record, cache_image):
90 * xselect.c (Fx_register_dnd_atom):
91 Simplify previous changes by using xpalloc.
92
fe5c5d37
PE
93 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
94 since either will do and ptrdiff_t is convenient with xpalloc.
95
0065d054
PE
96 * charset.c (charset_table_size)
97 (struct charset_sort_data.priority): Now ptrdiff_t.
98 (charset_compare): Don't overflow if priorities differ greatly.
99 (Fsort_charsets): Don't assume list length fits in int.
100 Check for size-calculation overflow when allocating sort data.
101 (syms_of_charset): Allocate an initial charset table that is
102 just under 64 KiB, to avoid problems with glibc malloc and mmap.
103
104 * cmds.c (internal_self_insert): Check for size-calculation overflow.
105
106 * composite.h (struct composition.glyph_len): Now int, not unsigned.
107 The actual value is always <= INT_MAX, and leaving it unsigned made
108 overflow checking harder.
109
110 * dispextern.h (struct glyph_matrix.rows_allocated)
111 (struct face_cache.size): Now ptrdiff_t, for convenience in use
112 with xpalloc. The values are still always <= INT_MAX.
113
114 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
115
116 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
117 (SAFE_NALLOCA): New macro.
118
119 * region-cache.c (struct boundary.pos, find_cache_boundary)
120 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
121 (set_cache_region, invalidate_region_cache)
122 (revalidate_region_cache, know_region_cache, region_cache_forward)
123 (region_cache_backward, pp_cache):
124 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
125 so that ptrdiff_t * can be passed to xpalloc.
126 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
127 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
128 (pp_cache): Don't assume cache_len fits in int.
129 * region-cache.h: Adjust extern decls to match.
130
131 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
132 EMACS_INT, since either will do, for xpalloc.
133
134 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
135 (xnmalloc, xnrealloc, xpalloc): New functions.
136
726e0ab1
PE
137 * bidi.c (bidi_shelve_header_size): New constant.
138 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
139 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
140
51f30bc5 141 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
142 * buffer.c (overlays_at, overlays_in, record_overlay_string)
143 (overlay_strings):
144 Don't update size of array until after memory allocation succeeds,
145 because xmalloc/xrealloc may not return.
0065d054
PE
146 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
147 now that we have proper integer overflow checking.
148 (record_overlay_string, overlay_strings): Catch overflows when
149 calculating size of overlay_str_buf.
726e0ab1 150
0065d054
PE
151 * callproc.c (Fcall_process): Check for size overflow when
152 calculating size of args2.
153 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
154 Normally we prefer signed values, but sticking with ptrdiff_t would
155 require adding more-complicated checks.
726e0ab1
PE
156
157 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
158 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
159 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 160 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
161
162 * character.c (Fstring): Check for size-calculation overflow.
163
164 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
165 unnecessary integer overflow. Check for size overflow.
166 (encode_coding_object): Don't update size until xmalloc succeeds.
167
168 * composite.c (get_composition_id): Check for overflow in glyph
169 length calculations.
170
171 Integer and memory overflow fixes for display code.
172 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
173 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
174 (scrolling_window): Check for overflow in size calculations.
175 (line_draw_cost, realloc_glyph_pool, add_row_entry):
176 Don't assume glyph table len fits in int.
177 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
178 (row_table_size): Now ptrdiff_t, not int.
179 (scrolling_window): Avoid overflow in size calculations.
180 Don't update size until allocation succeeds.
181 * fns.c (concat): Check for overflow in size calculations.
182 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
183 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
184 (NEXT_ALMOST_PRIME_LIMIT): New constant.
185
186 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
187 (get_doc_string): Check for size calculation overflow.
188 Don't update size until allocation succeeds.
189 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
190 EMACS_INT, where ptrdiff_t will do.
191 (Fsubstitute_command_keys): Check for string overflow.
192
193 * editfns.c (set_time_zone_rule): Don't assume environment length
194 fits in int.
195 (message_length): Now ptrdiff_t, not int.
196 (Fmessage_box): Don't update size until allocation succeeds.
197 Don't assume message length fits in int.
198 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
199
0065d054
PE
200 * emacs.c (main): Do not reallocate argv, since there is a null at
201 the end that can be overwritten, and this way there's no need to
202 worry about size-calculation overflow.
203 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
204
205 * eval.c (init_eval_once, grow_specpdl): Don't update size until
206 alloc succeeds.
207 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
208
209 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
210 (x_set_scroll_bar_width, x_figure_window_size):
211 Check for integer overflow.
212 (x_set_alpha): Do not assume XINT fits in int.
213
214 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
215 This is for the members text_lines, text_cols, total_lines, total_cols,
216 where the system imposes an 'int' limit.
217
218 * fringe.c (Fdefine_fringe_bitmap):
219 Don't update size until alloc works.
220
221 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
222 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
223
224 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
225 Check for size-calculation overflow.
226 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
227 do, as we prefer signed integers.
228 (id_to_widget.max_size, id_to_widget.used)
229 (xg_store_widget_in_map, xg_remove_widget_from_map)
230 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
231 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
232 Use and return ptrdiff_t, not int.
233 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
234 * gtkutil.h: Change prototypes to match the above.
235
236 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
237 are duplicate now that they've been promoted to lisp.h.
238 (x_allocate_bitmap_record, x_alloc_image_color)
239 (make_image_cache, cache_image, xpm_load):
240 Don't update size until alloc is done.
241 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
242 (x_detect_edges):
3256efce 243 Check for size calculation overflow.
726e0ab1
PE
244 (ct_colors_allocated_max): New constant.
245 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
246 overflow.
3256efce 247
726e0ab1
PE
248 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
249 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
250 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
251 Use ptrdiff_t, not int, to count maps.
252 (read_char_minibuf_menu_prompt): Check for overflow in size
253 calculations. Don't update size until allocation succeeds. Redo
254 calculations to avoid overflow.
255 * keyboard.h: Change prototypes to match the above.
256
257 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
258 to count maps.
259 (current_minor_maps): Check for size calculation overflow.
260 * keymap.h: Change prototypes to match the above.
261
262 * lread.c (read1, init_obarray): Don't update size until alloc done.
263
264 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
265 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
266
726e0ab1
PE
267 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
268 Now ptrdiff_t, not int.
269 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
270 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
271
272 * process.c (Fnetwork_interface_list): Check for overflow
273 in size calculation.
274
275 * region-cache.c (move_cache_gap): Check for size calculation overflow.
276
277 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
278 overflow. Don't bother calling xmalloc when xrealloc will do.
279
280 * search.c (Freplace_match): Check for size calculation overflow.
281 (Fset_match_data): Don't assume list lengths fit in 'int'.
282
283 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
284 for command line length. Do not attempt to address one before the
285 beginning of an array, as that's not portable.
286
287 * term.c (max_frame_lines): Remove; unused.
288 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
289 not int.
290 (encode_terminal_code, calculate_costs): Check for size
291 calculation overflow.
292 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
293 table lengths and related sizes. Don't update size until alloc
294 done. Redo calculations to avoid overflow.
295 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
296
297 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
298 subtracting pointers.
299 (gobble_line): Check for overflow more carefully. Don't update size
300 until alloc done.
301
302 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
303 Don't update size until alloc done.
304 Redo size calculations to avoid overflow.
305 Check for size calculation overflow.
0065d054 306 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
307
308 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
309 Use ptrdiff_t, not int, for sizes.
310 (store_mode_line_noprop_char): Don't update size until alloc done.
311
0065d054
PE
312 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
313 Use ptrdiff_t, not int, for sizes.
314 (Finternal_make_lisp_face, cache_face):
315 Check for size calculation overflow.
316 (cache_face): Treat size calculation overflows as if they were
317 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
318
319 * xfns.c (x_encode_text, x_set_name_internal)
320 (Fx_change_window_property): Use ptrdiff_t, not int, to count
321 sizes, since they can exceed INT_MAX in size. Check for size
322 calculation overflow.
323
0065d054
PE
324 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
325 (xg_select): Check for size calculation overflow.
726e0ab1
PE
326 Don't update size until alloc done.
327
0065d054 328 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 329 as sprintf is limited to int lengths.
1d526e2f 330
252c5ee1
PE
331 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
332 (X_LONG_MIN): New macros.
864d7ce7
PE
333 Use them to make the following changes clearer.
334 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
335 This change doesn't affect the value now, but it may help remind
336 future maintainers not to raise the value too much later.
337 (SELECTION_QUANTUM): Remove, replacing with ...
338 (selection_quantum): ... new function, which avoids overflow.
339 All uses changed.
340 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
341 assumption that selection length fits in 'int'.
342 (x_reply_selection_request, x_handle_selection_request)
343 (x_get_window_property, receive_incremental_selection)
344 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
345 (lisp_data_to_selection_data, clean_local_selection_data):
346 Use ptrdiff_t, not int, to record length of selection.
347 (x_reply_selection_request, x_get_window_property)
348 (receive_incremental_selection, x_property_data_to_lisp):
349 Redo calculations to avoid overflow.
350 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 351 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
352 something.
353 (x_get_window_property, receive_incremental_selection)
354 (lisp_data_to_selection_data, x_property_data_to_lisp):
355 Check for size-calculation overflow.
356 (x_get_window_property, receive_incremental_selection)
357 (lisp_data_to_selection_data, Fx_register_dnd_atom):
358 Don't store size until memory allocation succeeds.
359 (x_get_window_property): Plug memory leak on memory exhaustion.
360 Don't double-block input; malloc is safe here. Don't assume 2**34
361 - 4 fits in unsigned long. Add an xassert to check
362 XGetWindowProperty overflow. Be more careful about overflow
363 calculations, and distinguish size from memory overflow better.
364 (receive_incremental_selection): When tracing, don't assume
365 unsigned int is less than INT_MAX.
366 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
367 harmful) conversions of unsigned short to int.
368 (lisp_data_to_selection_data): Don't assume that integers
369 in the range -65535 through -1 fit in an X unsigned short.
370 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
371 result parameters unless successful. Rely on cons_to_unsigned
372 to report problems with elements; the old code wasn't right anyway.
373 (x_check_property_data): Check for int overflow; we cannot use
374 a wider type due to X limits.
375 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
376
726e0ab1 377 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 378
0065d054
PE
379 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
380 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
381 (x_color_cells): Don't store size until memory allocation succeeds.
382 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 383 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
384 (x_term_init): Don't assume length fits in int (sprintf is limited
385 to int size).
bc18e09d 386
ebfa62c0
PE
387 Use ptrdiff_t for composition IDs.
388 * character.c (lisp_string_width):
389 * composite.c (composition_table_size, n_compositions)
390 (get_composition_id, composition_gstring_from_id):
391 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
392 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
393 * window.c (Frecenter):
394 Use ptrdiff_t, not int, for composition IDs.
395 * composite.c (get_composition_id): Check for integer overflow.
396 * composite.h: Adjust prototypes to match the above changes.
397
d3411f89
PE
398 Use ptrdiff_t for hash table indexes.
399 * category.c (hash_get_category_set):
400 * ccl.c (ccl_driver):
401 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
402 * coding.c (coding_system_charset_list, detect_coding_system):
403 * coding.h (struct coding_system.id):
404 * composite.c (get_composition_id, gstring_lookup_cache):
405 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
406 * image.c (xpm_get_color_table_h):
407 * lisp.h (hash_lookup, hash_put):
408 * minibuf.c (Ftest_completion):
409 Use ptrdiff_t for hash table indexes, not int (which is too
410 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
411 32-bit --with-wide-int hosts).
412
e097a6fa
PE
413 * charset.c (Fdefine_charset_internal): Check for integer overflow.
414 Add a FIXME comment about memory leaks.
415 (syms_of_charset): Don't assume xmalloc returns.
416
5637687f
PE
417 Don't assume that stated character widths fit in int.
418 * character.c (Fchar_width, c_string_width, lisp_string_width):
419 * character.h (CHAR_WIDTH):
420 * indent.c (MULTIBYTE_BYTES_WIDTH):
421 Use sanitize_char_width to avoid undefined and/or bad behavior
422 with outlandish widths.
423 * character.h (sanitize_tab_width): Renamed from sanitize_width,
424 now that we have two such functions. All uses changed.
425 (sanitize_char_width): New inline function.
426
a2271ba2
PE
427 Don't assume that tab-width fits in int.
428 * character.h (sanitize_width): New inline function.
429 (SANE_TAB_WIDTH): New macro.
430 (ASCII_CHAR_WIDTH): Use it.
431 * indent.c (sane_tab_width): Remove. All uses replaced by
432 SANE_TAB_WIDTH (current_buffer).
433 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
434
18c52557
PE
435 * fileio.c: Integer overflow issues with file modes.
436 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
437
caeeedc1
PE
438 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
439 Remove unreachable code.
440 (read_hex, load_charset_map_from_file): Check for integer overflow.
441
50849c52
PE
442 * xterm.c: don't go over XClientMessageEvent limit
443 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
444 (x_send_scroll_bar_event): Likewise. Check that the size does not
445 exceed limits imposed by XClientMessageEvent, as well as the usual
446 ptrdiff_t and size_t limits.
447
b13995db
PE
448 * keyboard.c: Overflow, signedness and related fixes.
449 (make_lispy_movement): Use same integer type in forward decl
450 that is used in the definition.
451 (read_key_sequence, keyremap_step):
452 Change bufsize argument back to int, undoing my 2011-03-30 change.
453 We prefer signed types, and int is wide enough here.
454 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
455 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
456 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
457 length, not size_t. Use ptrdiff_t for index, not int.
458 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
459 possibility of integer overflow.
460
13464394
PE
461 Overflow, signedness and related fixes for images.
462
463 * dispextern.h (struct it.stack[0].u.image.image_id)
464 (struct_it.image_id, struct image.id, struct image_cache.size)
465 (struct image_cache.used, struct image_cache.ref_count):
466 * gtkutil.c (update_frame_tool_bar):
467 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
468 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
469 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
470 * nsmenu.m (update_frame_tool_bar):
471 * xdisp.c (calc_pixel_width_or_height):
472 * xfns.c (image_cache_refcount):
473 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
474 on typical 64-bit hosts.
475
476 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
477 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
478 Omit unnecessary casts to int.
479 (parse_image_spec): Check that integers fall into 'int' range
480 when the callers expect that.
481 (image_ascent): Redo ascent calculation to avoid int overflow.
482 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
483 (lookup_image): Remove unnecessary tests.
484 (xbm_image_p): Locals are now of int, not EMACS_INT,
485 since parse_image_check makes sure they fit into int.
486 (png_load, gif_load, svg_load_image):
487 Prefer int to unsigned where either will do.
488 (tiff_handler): New function, combining the cores of the
489 old tiff_error_handler and tiff_warning_handler. This
490 function is rewritten to use vsnprintf and thereby avoid
491 stack buffer overflows. It uses only the features of vsnprintf
492 that are common to both POSIX and native Microsoft.
493 (tiff_error_handler, tiff_warning_handler): Use it.
494 (tiff_load, gif_load, imagemagick_load_image):
495 Don't assume :index value fits in 'int'.
496 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
497 (imagemagick_load_image): Check that crop parameters fit into
498 the integer types that MagickCropImage accepts. Don't assume
499 Vimagemagick_render_type has a nonnegative value. Don't assume
500 size_t fits in 'long'.
501 (gs_load): Use printmax_t to print the widest integers possible.
502 Check for integer overflow when computing image height and width.
503
c11821d4
EZ
5042011-08-26 Eli Zaretskii <eliz@gnu.org>
505
506 * xdisp.c (redisplay_window): Don't force window start if point
507 will be invisible in the resulting window. (Bug#9324)
508
0c95fcf7
EZ
5092011-08-25 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
512 the display spec is of the form `(space ...)'.
513 (handle_display_spec): Return the value returned by
514 handle_single_display_spec, not just 1 or zero.
515 (handle_single_display_spec): If the display spec is of the form
516 `(space ...)', and specifies display in the text area, return 2
517 rather than 1.
fee65a97 518 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
519 accurately, and prefer exact match for point under bidi. Don't
520 advance `row' beyond the last row of the window.
0c95fcf7
EZ
521
522 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
523 into disp_prop; all users changed.
524
525 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
526 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
527 for the text covered by the display property.
528
e4ed06f1
CY
5292011-08-25 Chong Yidong <cyd@stupidchicken.com>
530
531 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
532 Change return value to nil.
533 (Frecord_buffer): Delete unused function.
534
f67cdd7f
EZ
5352011-08-24 Eli Zaretskii <eliz@gnu.org>
536
5980d4c6
EZ
537 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
538 buffers, return left-to-right.
8610fe8b
EZ
539 (set_cursor_from_row): Consider candidate row a win if its glyph
540 represents a newline and point is on that newline. Fixes cursor
541 positioning on the newline at EOL of R2L text within L2R
542 paragraph, and vice versa.
543 (try_cursor_movement): Check continued rows, in addition to
544 continuation rows. Fixes unwarranted scroll when point enters a
545 continued line of R2L text within an L2R paragraph, or vice versa.
546 (cursor_row_p): Consider the case of point being equal to
547 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
548 from the end of a short line to the beginning of a continued line
549 of R2L text within L2R paragraph.
550 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
551 composed characters.
5980d4c6 552
f67cdd7f
EZ
553 * bidi.c (bidi_check_type): Use xassert.
554 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
555 members.
556
bca633fb
EZ
5572011-08-23 Eli Zaretskii <eliz@gnu.org>
558
559 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
560 a character.
561
4a5885a7
CY
5622011-08-23 Chong Yidong <cyd@stupidchicken.com>
563
564 * nsfont.m (ns_otf_to_script): Fix typo.
565
0902a04e
KH
5662011-08-22 Kenichi Handa <handa@m17n.org>
567
568 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
569 extra slot even if the purpose is char-code-property-table.
570
1a2e6670
EZ
5712011-08-23 Eli Zaretskii <eliz@gnu.org>
572
8ddde651
EZ
573 * xdisp.c (redisplay_window): When computing centering_position,
574 account for the height of the header line. (Bug#8874)
575
425cc014
EZ
576 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
577 instead of CHAR_TO_BYTE. Fixes a crash when a completion
578 candidate is selected by the mouse, and that candidate has a
579 composed character under the mouse.
580
1a2e6670
EZ
581 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
582 coordinates reported by pos-visible-in-window-p for a composed
583 character in column zero.
584
8b76d6f8
SM
5852011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
586
587 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
588
dac347dd
EZ
5892011-08-22 Eli Zaretskii <eliz@gnu.org>
590
591 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
592 consider it a hit if to_charpos is anywhere in the range of the
593 composed buffer positions.
594
e013fb34
CY
5952011-08-22 Chong Yidong <cyd@stupidchicken.com>
596
597 * image.c (gif_load): Don't assume that each subimage has the same
598 dimensions as the base image. Handle disposal method that is
599 "undefined" by the gif spec (Bug#9335).
600
bd1ba3e8
CY
6012011-08-20 Chong Yidong <cyd@stupidchicken.com>
602
603 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 604 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 605
54a1215b
EZ
6062011-08-19 Eli Zaretskii <eliz@gnu.org>
607
823564e5
EZ
608 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
609 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
610 from an Org mode buffer to a Speedbar frame.
611
54a1215b
EZ
612 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
613 a composition, take its buffer position from IT->cmp_it.charpos.
614 Fixes cursor positioning at the beginning of a line that begins
615 with a composed character.
616
9778ebcc
EZ
6172011-08-18 Eli Zaretskii <eliz@gnu.org>
618
0be6ee06
EZ
619 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
620 character bidirectional type, use STRONG_L instead. Fixes crashes
621 in a buffer produced by `describe-categories'.
622
9778ebcc
EZ
623 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
624 members before the level stack, so they would be saved and
625 restored when copying iterator state. Fixes incorrect reordering
626 around TABs covered by display properties.
627
156bffbe
AS
6282011-08-18 Andreas Schwab <schwab@linux-m68k.org>
629
630 * process.c (Fnetwork_interface_list): Correctly determine buffer
631 size.
632
72ad093b
CY
6332011-08-17 Chong Yidong <cyd@stupidchicken.com>
634
635 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
636 (internal_condition_case_2, internal_condition_case_n):
637 Remove unnecessary aborts (Bug#9081).
72ad093b 638
35774242
EZ
6392011-08-17 Eli Zaretskii <eliz@gnu.org>
640
641 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
642 has no `load' handler, try opening the file locally. (Bug#9311)
643
db76dd85
KB
6442011-08-16 Ken Brown <kbrown@cornell.edu>
645
646 * gmalloc.c: Expand comment.
647
b215eee5
EZ
6482011-08-16 Eli Zaretskii <eliz@gnu.org>
649
650 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
651 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
652
a4579d33
KB
6532011-08-16 Ken Brown <kbrown@cornell.edu>
654
655 Fix memory allocation problems in Cygwin build (Bug#9273).
656
657 * unexcw.c ( __malloc_initialized): Declare external variable.
658 (fixup_executable): Force the dumped emacs to reinitialize malloc.
659
8b76d6f8
SM
660 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
661 New variables.
a4579d33
KB
662 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
663 dumped emacs.
664 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
665 in the static heap.
666 [CYGWIN] (special_realloc): New function.
667 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
668 requests to realloc storage in the static heap.
669
3ebec551
PE
6702011-08-15 Paul Eggert <eggert@cs.ucla.edu>
671
672 * bidi.c (bidi_initialize): Remove unused local.
673
9fd8be00
EZ
6742011-08-15 Eli Zaretskii <eliz@gnu.org>
675
474a8465
EZ
676 * biditype.h: File removed.
677
678 * bidimirror.h: File removed.
679
680 * deps.mk (bidi.o): Remove biditype.h and
681 bidimirror.h.
682
683 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
684 bidimirror.h.
685
686 * dispextern.h: Fix a typo in the comment to bidi_type_t.
687
688 * chartab.c: Improve commentary for the uniprop_table API.
689
32413314
EZ
690 * bidi.c (bidi_paragraph_init): Support zero value of
691 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
692 (bidi_initialize): Use uniprop_table instead of including
693 biditype.h and bidimirror.h.
32413314 694
9fd8be00
EZ
695 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
696 coordinates of the iterator when restoring from ppos_it.
697 (Bug#9296)
698
5cf2b69b
KH
6992011-08-14 Kenichi Handa <handa@m17n.org>
700
701 * process.c (create_process): Call setup_process_coding_systems
72ad093b 702 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 703
daf17d00
EZ
7042011-08-14 Eli Zaretskii <eliz@gnu.org>
705
706 * xdisp.c (move_it_in_display_line_to): Don't invoke
707 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
708 ppos_it. Fixes vertical cursor motion when line beginning is
709 covered by an image. (Bug#9296)
710
08e3161a
JD
7112011-08-14 Jan Djärv <jan.h.d@swipnet.se>
712
713 * nsterm.h (ns_run_ascript): Declare.
714 (NSAPP_DATA2_RUNASSCRIPT): Define.
715
716 * nsfns.m (as_script, as_result, as_status): New static variables.
717 (ns_run_ascript): New function.
718 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
719 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
720 the event loop. Get status from as_status (Bug#7276).
721
722 * nsterm.m (sendEvent): If event is NSApplicationDefined and
723 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
724 the event loop (Bug#7276).
725
a3720aa2
AS
7262011-08-14 Andreas Schwab <schwab@linux-m68k.org>
727
728 * gnutls.c (QCgnutls_bootprop_priority)
729 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
730 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
731 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
732 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
733 (QCgnutls_bootprop_verify_hostname_error)
734 (QCgnutls_bootprop_callbacks_verify): Rename from
735 Qgnutls_bootprop_..., all uses changed.
736
737 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
738 uses changed.
739
0a0d27fb
PE
7402011-08-14 Paul Eggert <eggert@cs.ucla.edu>
741
19d5c50c
PE
742 * xfaces.c (Qframe_set_background_mode): Now static.
743 * dispextern.h (Qframe_set_background_mode): Remove decl.
744
0a0d27fb
PE
745 * process.c (Fnetwork_interface_info): Declare local only if needed.
746
377538cb
JD
7472011-08-13 Jan Djärv <jan.h.d@swipnet.se>
748
749 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
750 (Fnetwork_interface_list): Allocate in increments of bytes instead
751 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
752 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
753 sockaddr.
754 (struct ifflag_def): notrailers is smart on OSX.
755 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
756 Get hardware address with getifaddrs if available.
757
08fff70c
EZ
7582011-08-12 Eli Zaretskii <eliz@gnu.org>
759
760 * xdisp.c (iterate_out_of_display_property): xassert that
761 IT->position is set to within IT->object's boundaries. Break from
762 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
763 when IT->position is set up wrongly due to some bug.
764 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
765 (push_display_prop): Allow GET_FROM_STRING as IT->method on
766 entry. Force push_it to save on the stack the current
767 buffer/string position, to be restored by pop_it. Fix flags in
768 the iterator structure wrt the object coming from a display
769 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
770 properties. (Bug#9284)
771
7be1c708 7722011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 773
7be1c708
CY
774 * fontset.c (fontset_get_font_group): Add proper type checks.
775 (Bug#9172)
aac0c6e3 776
7be1c708 7772011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 778
7be1c708
CY
779 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
780 and LC_VERSION_MIN_MACOSX.
781 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
782 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 783
97bb72a6
EZ
7842011-08-08 Eli Zaretskii <eliz@gnu.org>
785
786 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
787 no-display-properties-and-no-overlays under bidi display.
788 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 789 properties and overlays.
97bb72a6 790
d5617611
CY
7912011-08-08 Chong Yidong <cyd@stupidchicken.com>
792
37e11a63
CY
793 * editfns.c (Fset_time_zone_rule): Document relationship with the
794 setenv function.
795
d5617611
CY
796 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
797 the font entity extracted from the cache (Bug#8109).
798
58872834
CY
7992011-08-07 Chong Yidong <cyd@stupidchicken.com>
800
801 * composite.c (autocmp_chars): Don't reset point. That is done by
802 restore_point_unwind (Bug#5984).
803
75bfc667
JL
8042011-08-07 Juri Linkov <juri@jurta.org>
805
806 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
807 to show the arg `TIME' instead of `TIMEVAL'.
808
d1410150
EZ
8092011-08-06 Eli Zaretskii <eliz@gnu.org>
810
811 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
812 display property strides EOL and includes a newline, as in
813 longlines-mode. (Bug#9254)
75b771e4
EZ
814 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
815 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
816
817 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
818 is non-zero, even if the data buffer is NULL. Fixes a crash in
819 vertical-motion with longlines-mode. (Bug#9254)
820
35928349
EZ
8212011-08-05 Eli Zaretskii <eliz@gnu.org>
822
ec7cc85b
EZ
823 * bidi.c <bidi_cache_total_alloc>: Now static.
824 (bidi_initialize): Initialize bidi_cache_total_alloc.
825
8b76d6f8 826 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
827 cache. (Bug#9221)
828
829 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
830 amount allocated this far in `bidi_cache_total_alloc'.
831 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
832 non-zero, only free the data buffer without restoring the cache
833 contents. All callers changed.
834
835 * dispextern.h (bidi_unshelve_cache): Update prototype.
836
837 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
838 (move_it_in_display_line, move_it_to)
839 (move_it_vertically_backward, move_it_by_lines): Replace the call
840 to xfree to an equivalent call to bidi_unshelve_cache.
841 (move_it_in_display_line_to): Fix logic of returning
412b6358 842 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 843
e2e2423b
EZ
8442011-08-05 Eli Zaretskii <eliz@gnu.org>
845
846 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
847 came from a string character with a `cursor' property. (Bug#9229)
848
ae9e757a
JD
8492011-08-04 Jan Djärv <jan.h.d@swipnet.se>
850
851 * Makefile.in (LIB_PTHREAD): New variable.
852 (LIBES): Add LIB_PTHREAD (Bug#9216).
853
854 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
855 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
856
213bd7f2
AS
8572011-08-04 Andreas Schwab <schwab@linux-m68k.org>
858
859 * regex.c (re_iswctype): Remove some redundant boolean
860 conversions.
861
99aaf75f
JD
8622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
863
864 * xterm.c (x_find_topmost_parent): New function.
865 (x_set_frame_alpha): Find topmost parent window with
866 x_find_topmost_parent and set the property there also (bug#9181).
867 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
868
c74e9d86
PE
8692011-08-04 Paul Eggert <eggert@cs.ucla.edu>
870
871 * callproc.c (Fcall_process): Avoid vfork clobbering
872 the local vars buffer, coding_systems, current_dir.
873
640c8776
SM
8742011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
875
876 * keymap.c (Fmake_composed_keymap): Move to subr.el.
877
f26d0e4c
PE
8782011-08-03 Paul Eggert <eggert@cs.ucla.edu>
879
8a10d76c
PE
880 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
881 so that it is not optimized away.
882
f26d0e4c
PE
883 * xdisp.c (compute_display_string_pos): Remove unused local.
884
55439c61
EZ
8852011-08-02 Eli Zaretskii <eliz@gnu.org>
886
887 Fix slow cursor motion and scrolling in large buffers with
888 selective display, like Org Mode buffers. (Bug#9218)
889
890 * dispextern.h (struct bidi_it): New member disp_prop_p.
891
892 * xdisp.c: Remove one-slot cache of display string positions.
893 (compute_display_string_pos): Accept an additional argument
894 DISP_PROP_P; callers changed. Scan at most 5K characters forward
895 for a display string or property. If found, set DISP_PROP_P
896 non-zero.
897
898 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
899 DISP_PROP_P, and pass it to compute_display_string_pos.
900 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
901 non-zero. All callers of bidi_fetch_char changed.
902
fb33fa43
SM
9032011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
904
905 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
906
b099e063
DM
9072010-12-03 Don March <don@ohspite.net>
908
909 * keymap.c (Fdefine_key): Fix non-prefix key error message when
910 last character M-[char] is translated to ESC [char] (bug#7541).
911
5cc7f7af
KH
9122011-08-02 Kenichi Handa <handa@m17n.org>
913
d0fffa3f 914 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
915
916 * chartab.c (uniprop_table): Make it non-static.
917
525d5e6e
EZ
9182011-08-01 Eli Zaretskii <eliz@gnu.org>
919
920 * xdisp.c (forward_to_next_line_start): Accept additional argument
921 BIDI_IT_PREV, and store into it the state of the bidi iterator had
922 on the newline.
923 (reseat_at_next_visible_line_start): Use the bidi iterator state
924 returned by forward_to_next_line_start to restore the state of
925 it->bidi_it after backing up to previous newline. (Bug#9212)
926
31011111
AS
9272011-07-30 Andreas Schwab <schwab@linux-m68k.org>
928
929 * regex.c (re_comp): Protoize.
930 (re_exec): Fix return type.
931 (regexec): Fix type of `ret'. (Bug#9203)
932
e5d76069
PE
9332011-07-29 Paul Eggert <eggert@cs.ucla.edu>
934
935 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
936 This is needed if max-image-size is a floating-point number.
937
9a79b20c
AS
9382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
939
940 * print.c (print_object): Print empty symbol as ##.
941
942 * lread.c (read1): Read ## as empty symbol.
943
d8c2fa78
AA
9442011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
945
946 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
947 setting frame foreground color (Bug#9175).
948 (x_set_background_color): Likewise.
949
ffe57a7a
AA
950 * nsmenu.m (-setText): Size tooltip dimensions precisely to
951 contents (Bug#9176).
952 (EmacsTooltip -init): Remove bezels and add shadows to
953 tooltip windows.
954
bf3492a5
AA
955 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
956 or scroll bar (Bug#8470).
957
d55e9c53
AA
958 * nsfont.m (nsfont_open): Remove assignment to voffset and
959 unnecessary vars hshink, expand, hd, full_height, min_height.
960 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
961
962 * nsterm.h (nsfont_info): Remove voffset field.
963
d8c2fa78 9642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
965
966 Implement strike-through and overline on NextStep (Bug#8863).
967
968 * nsfont.m (nsfont_open): Use underline position provided by font,
969 instead of hard-coded value of 2.
970 (nsfont_draw): Call ns_draw_text_decoration instead.
971
972 * nsterm.h: Add declaration for ns_draw_text_decoration.
973
974 * nsterm.m (ns_draw_text_decoration): New function for drawing
975 underline, overline, and strike-through.
976 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
977 ns_draw_text_decoration. Change treatment of cursor drawing to
978 accomodate underlining, etc.
979
4cc60b9b
EZ
9802011-07-28 Eli Zaretskii <eliz@gnu.org>
981
bc7ece87
EZ
982 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
983 default.
4cc60b9b 984
476371c4
PE
9852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
986
66606eea
PE
987 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
988 Without this fix, if a signal arrives just after memory fills up,
989 'malloc' might be invoked reentrantly.
990
476371c4
PE
991 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
992 In other words, assume that every image size is allowed, on non-X
993 hosts. This assumption is probably wrong, but it lets Emacs compile.
994
f3fcc40d
AS
9952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
996
997 * regex.c (re_iswctype): Convert return values to boolean.
998
350c992f
EZ
9992011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1000
1001 * xdisp.c (compute_display_string_pos): Don't use cached display
1002 string position if the buffer had its restriction changed.
1003 (Bug#9184)
1004
5266b4bb
PE
10052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1008
2573a837 10092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1010
41f55ccd 1011 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1012
39e378da
PE
1013 * bidi.c: Integer size and overflow fixes.
1014 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1015 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1016 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1017 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1018 (bidi_find_other_level_edge):
1019 Use ptrdiff_t instead of EMACS_INT where either will do.
1020 This works better on 32-bit hosts configured --with-wide-int.
1021 (bidi_cache_ensure_space): Check for size-calculation overflow.
1022 Use % rather than repeated addition, for better worst-case speed.
1023 Don't set bidi_cache_size until after xrealloc returns, because it
1024 might not return.
1025 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1026 (bidi_cache_ensure_space): Also check that the bidi cache size
1027 does not exceed that of the largest Lisp string or buffer. See Eli
1028 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1029
5e927815
PE
1030 * alloc.c (__malloc_size_t): Remove.
1031 All uses replaced by size_t. See Andreas Schwab's note
1032 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1033
ca4aa935
PE
1034 * image.c: Improve checking for integer overflow.
1035 (check_image_size): Assume that f is nonnull, since
1036 it is always nonnull in practice. This is one less thing to
1037 worry about when checking for integer overflow later.
1038 (x_check_image_size): New function, which checks for integer
1039 overflow issues inside X.
1040 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1041 This removes the need for a memory_full check.
1042 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1043 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1044 (xbm_read_bitmap_data): Change locals back to 'int', since
1045 their values must fit in 'int'.
1046 (xpm_load_image, png_load, tiff_load):
1047 Invoke x_create_x_image_and_pixmap earlier,
1048 to avoid much needless work if the image is too large.
1049 (tiff_load): Treat overly large images as if
1050 x_create_x_image_and_pixmap failed, not as malloc failures.
1051 (gs_load): Use x_check_image_size.
1052
5f8f9cc2
PE
1053 * gtkutil.c: Omit integer casts.
1054 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1055 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1056
5adf60bc
PE
1057 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1058
c8907a93
PE
1059 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1060 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1061 would wrongly return t on a 64-bit host.
1062
e3c25c68
PE
1063 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1064 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1065 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1066 and therefore cause GCC to emit a bogus diagnostic in some cases.
1067
3f791afe
PE
1068 * image.c: Integer signedness and overflow and related fixes.
1069 This is not an exhaustive set of fixes, but it's time to
1070 record what I've got.
1071 (lookup_pixel_color, check_image_size): Remove redundant decls.
1072 (check_image_size): Don't assume that arbitrary EMACS_INT values
1073 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1074 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1075 (tiff_load, imagemagick_load_image):
1076 Check for overflow in size calculations.
1077 (x_create_x_image_and_pixmap): Remove unnecessary test for
1078 xmalloc returning NULL; that can't happen.
1079 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1080 (xpm_color_bucket): Use better integer hashing function.
1081 (xpm_cache_color): Don't possibly over-allocate memory.
1082 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1083 (gif_memory_source):
1084 Use ptrdiff_t, not int or size_t, to record sizes.
1085 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1086 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1087 either works, as we prefer signed integers.
1088 (tiff_read_from_memory, tiff_write_from_memory):
1089 Return tsize_t, not size_t, since that's what the TIFF API wants.
1090 (tiff_read_from_memory): Don't fail simply because the read would
1091 go past EOF; instead, return a short read.
1092 (tiff_load): Omit no-longer-needed casts.
1093 (Fimagemagick_types): Don't assume size fits into 'int'.
1094
3cc5a532
PE
1095 Improve hashing quality when configured --with-wide-int.
1096 * fns.c (hash_string): New function, taken from sxhash_string.
1097 Do not discard information about ASCII character case; this
1098 discarding is no longer needed.
1099 (sxhash-string): Use it. Change sig to match it. Caller changed.
1100 * lisp.h: Declare it.
1101 * lread.c (hash_string): Remove, since we now use fns.c's version.
1102 The fns.c version returns a wider integer if --with-wide-int is
1103 specified, so this should help the quality of the hashing a bit.
1104
b312a492
PE
1105 * emacs.c: Integer overflow minor fix.
1106 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1107 Define only if GNU_LINUX.
1108 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1109
dfd153ae
PE
1110 * dispnew.c: Integer signedness and overflow fixes.
1111 Remove unnecessary forward decls, that were a maintenance hassle.
1112 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1113 All uses changed.
1114 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1115 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1116 (prepare_desired_row, line_draw_cost):
1117 Use int, not unsigned, where either works.
1118 (save_current_matrix, restore_current_matrix):
1119 Use ptrdiff_t, not size_t, where either works.
1120 (init_display): Check for overflow more accurately, and without
1121 relying on undefined behavior.
1122
a81d11a3
PE
1123 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1124 Remove, replacing with the new symbols in lisp.h. All uses changed.
1125 * fileio.c (make_temp_name):
1126 * filelock.c (lock_file_1, lock_file):
1127 * xdisp.c (message_dolog):
1128 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1129 Use pMd etc. instead.
1130 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1131 replacing the pWIDE etc. symbols removed from editfns.c.
1132
3300e6fd
PE
1133 * keyboard.h (num_input_events): Now uintmax_t.
1134 This is (very slightly) less likely to mess up due to wraparound.
1135 All uses changed.
1136
fd05c7e9
PE
1137 * buffer.c: Integer signedness fixes.
1138 (alloc_buffer_text, enlarge_buffer_text):
1139 Use ptrdiff_t rather than size_t when either will do, as we prefer
1140 signed integers.
1141
903fe15d
PE
1142 * alloc.c: Integer signedness and overflow fixes.
1143 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1144 (__malloc_size_t): Default to size_t, not to int.
1145 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1146 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1147 Prefer ptrdiff_t to size_t when either would do, as we prefer
1148 signed integers.
1149 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1150 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1151 Now const. Initialize with values that are in range even if char
1152 is signed.
1153 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1154 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1155 These functions do the right thing with sizes > 2**32.
1156 (check_depth): Now ptrdiff_t, not int.
1157 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1158 Adjust to new way of storing sizes. Check for size overflow bugs
1159 in rest of code.
1160 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1161 slightly wrong anyway, as it missed one instance of
1162 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1163 (refill_memory_reserve): Omit needless cast to size_t.
1164 (mark_object_loop_halt): Mark as externally visible.
1165
ac82cc6a
PE
1166 * xselect.c: Integer signedness and overflow fixes.
1167 (Fx_register_dnd_atom, x_handle_dnd_message):
1168 Use ptrdiff_t, not size_t, since we prefer signed.
1169 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1170 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1171 x_dnd_atoms_size and x_dnd_atoms_length.
1172
c2d1e36d
PE
1173 * doprnt.c: Prefer signed to unsigned when either works.
1174 * eval.c (verror):
1175 * doprnt.c (doprnt):
1176 * lisp.h (doprnt):
1177 * xdisp.c (vmessage):
1178 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1179 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1180 prefer signed arithmetic to avoid comparison confusion.
1181 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1182 but is a bit tricky.
1183
0e926e56
PE
1184 Assume freestanding C89 headers, string.h, stdlib.h.
1185 * data.c, doprnt.c, floatfns.c, print.c:
1186 Include float.h unconditionally.
1187 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1188 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1189 * regex.c: Likewise for stddef.h, string.h.
1190 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1191 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1192 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1193 (STDC_HEADERS): Remove obsolete defines.
1194 * sysdep.c: Include limits.h unconditionally.
1195
9cfdb3ec
PE
1196 Assume support for memcmp, memcpy, memmove, memset.
1197 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1198 * regex.c (memcmp, memcpy):
1199 Remove; we assume C89 now.
1200
1201 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1202 (__malloc_safe_bcopy): Remove; no longer needed.
1203
cf950e6b 1204 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1205 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1206 well either way, and we prefer signed to unsigned.
1207
dbf38e02
LMI
12082011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1209
1210 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1211 closes the connection while we're reading (bug#9182).
1212
d6f0886c
JD
12132011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1214
1215 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1216 are specified (Bug#9168).
1217
2eb1f9e6
PE
12182011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1221 Found by GCC static checking and --with-wide-int on a 32-bit host.
1222
22381272 12232011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1224
1225 * xdisp.c (compute_display_string_pos): Fix logic of caching
1226 previous display string position. Initialize cached_prev_pos to
1227 -1. Fixes slow-down at the beginning of a buffer.
1228
f25e39b4
EZ
12292011-07-24 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1232 for attrs[LFACE_FONTSET_INDEX].
1233
04c4b52e
PE
12342011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 * xml.c (parse_region): Remove unused local
1237 that was recently introduced.
1238
c1734fbd
EZ
12392011-07-23 Eli Zaretskii <eliz@gnu.org>
1240
be18c5a5
EZ
1241 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1242 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1243
c1734fbd
EZ
1244 * xdisp.c (move_it_in_display_line_to): Record the best matching
1245 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1246 exit if none of the characters scanned was an exact match.
1247 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1248 when exact match is impossible due to invisible text, and the
1249 lines are truncated.
1250
a258d627
JD
12512011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1252
1253 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1254 for OSX >= 10.7.
1255
b6d5a689
EZ
12562011-07-22 Eli Zaretskii <eliz@gnu.org>
1257
0f74f785
EZ
1258 Fix a significant slow-down of cursor motion with C-n, C-p,
1259 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1260 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1261 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1262 (next_element_from_buffer): Call compute_stop_pos_backwards to
1263 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1264 base_level_stop.
1265 (reseat): Don't look for prev_stop, as that could mean a very long
1266 run.
1267 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1268 <cached_disp_overlay_modiff>: Cache for last found display string
1269 position.
551918c1 1270 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1271 about the same buffer in the same area of character positions, and
1272 the buffer wasn't changed since the time the display string
1273 position was cached.
551918c1 1274
b2d0c91a
EZ
12752011-07-22 Eli Zaretskii <eliz@gnu.org>
1276
1277 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1278 is an integer, which is important for empty lines. (Bug#9149)
1279
043604ee
CY
12802011-07-22 Chong Yidong <cyd@stupidchicken.com>
1281
1282 * frame.c (Fmodify_frame_parameters): In tty case, update the
1283 default face if necessary (Bug#4238).
1284
da4adb04
CY
12852011-07-21 Chong Yidong <cyd@stupidchicken.com>
1286
1287 * editfns.c (Fstring_to_char): No need to explain what a character
1288 is in the docstring (Bug#6576).
1289
9abd0532
LMI
12902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1291
1292 * xml.c (parse_region): Make sure we always return a tree.
1293
36881d16
HK
12942011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1295
1296 * xml.c (parse_region): If a document contains only comments,
1297 return that, too.
1298
1e98674d
LMI
12992011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1300
1301 * xml.c (make_dom): Return comments, too.
1302
590bd467
PE
13032011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 Port to OpenBSD.
1306 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1307 and the surrounding thread.
1308 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1309 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1310 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1311 timer goes off.
1312 * s/openbsd.h (BROKEN_SIGIO): Define.
1313 * unexelf.c (unexec) [__OpenBSD__]:
1314 Don't update the .mdebug section of the Alpha COFF symbol table.
1315
f41628b2
LMI
13162011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1317
1318 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1319 (bug#8460).
1320
b59b67c5
PE
13212011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1322
15e3a074
PE
1323 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1324 This fixes some race conditions on the permissions of any newly
1325 created file.
1326
41bed37d
PE
1327 * alloc.c (valid_pointer_p): Use pipe, not open.
1328 This fixes some permissions issues when debugging.
1329
b59b67c5
PE
1330 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1331 If fchown fails to set both uid and gid, try to set just gid,
1332 as that is sometimes allowed. Adjust the file's mode to eliminate
1333 setuid or setgid bits that are inappropriate if fchown fails.
1334
925a6be7
SM
13352011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1336
1337 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1338 to compare Lisp_Objects.
1339 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1340 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1341 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1342
52968808
AS
13432011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1344
0a6a104b
AS
1345 * lread.c (read_integer): Unread even EOF character.
1346 (read1): Likewise. Properly record start position of symbol.
1347
52968808
AS
1348 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1349 symbol character follows.
1350
9e381cdd
PE
13512011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1352
1353 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1354 This works around a problem with the previous change to Fcopy_file.
1355 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1356 and without this change, GCC might complain about discarding
1357 fchown's return value.
1358
b5641435
JB
13592011-07-16 Juanma Barranquero <lekktu@gmail.com>
1360
1361 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1362
a8031457
PE
13632011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1366
dd889327
LMI
13672011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1368
750c33f7
LMI
1369 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1370 it's used from the C level.
1371
dd889327
LMI
1372 * process.c: Use the same condition for POLL_FOR_INPUT in both
1373 keyboard.c and process.c (bug#1858).
1374
87e86684
LM
13752011-07-09 Lawrence Mitchell <wence@gmx.li>
1376
1377 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1378 (Fgnutls_boot): Use it.
1379
64348f40
AS
13802011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1381
1382 * doc.c (Fsubstitute_command_keys): Revert last change.
1383
1d698799
LMI
13842011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1385
f863868c
LMI
1386 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1387 quotes the next character, and doesn't affect other longer
1388 sequences (bug#8935).
1389
1d698799
LMI
1390 * lread.c (syms_of_lread): Clarify that is isn't only
1391 `eval-buffer' and `eval-defun' that's affected by
1392 `lexical-binding' (bug#8460).
1393
aa4b6df6
EZ
13942011-07-15 Eli Zaretskii <eliz@gnu.org>
1395
1396 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1397 bidi redisplay when a line includes both an image and is
1398 truncated.
1399
5d856da6
PE
14002011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1401
ad6042bb
PE
1402 Fix minor problems found by static checking.
1403 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1404 (elsz): Now a signed constant, not a size_t var. We prefer signed
1405 types to unsigned, to avoid integer comparison confusion. Without
1406 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1407 "cannot optimize loop, the loop counter may overflow", a symptom
1408 of the confusion.
f00bbb22 1409 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1410 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1411
6468f31c
LMI
14122011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1413
49080b10
LMI
1414 * search.c (Fre_search_backward): Mention `case-fold-search' in
1415 all the re_search_* functions (bug#8138).
1416
6468f31c
LMI
1417 * keyboard.c (Fopen_dribble_file): Document when the file is
1418 closed (bug#8056).
1419
c965adc5
EZ
14202011-07-14 Eli Zaretskii <eliz@gnu.org>
1421
df9733bf
EZ
1422 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1423 bidi_cache_idx.
1424
0bb23927
EZ
1425 Support bidi reordering of display and overlay strings.
1426 * xdisp.c (compute_display_string_pos)
1427 (compute_display_string_end): Accept additional argument STRING.
1428 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1429 (reseat_to_string): Initialize bidi_it->string.s and
1430 bidi_it->string.schars.
1431 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1432 NULL (avoids a crash in bidi_paragraph_init).
1433 Initialize itb.string.lstring.
0bb23927
EZ
1434 (init_iterator): Call bidi_init_it only of a valid
1435 buffer position was specified. Initialize paragraph_embedding to
1436 L2R.
1437 (reseat_to_string): Initialize the bidi iterator.
1438 (display_string): If we need to ignore text properties of
1439 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1440 original value of -1 will not work with bidi.)
1441 (compute_display_string_pos): First arg is now struct
1442 `text_pos *'; all callers changed. Support display properties on
1443 Lisp strings.
1444 (compute_display_string_end): Support display properties on Lisp
1445 strings.
1446 (init_iterator, reseat_1, reseat_to_string): Initialize the
1447 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1448 when iterating on a string not from display properties).
640c8776
SM
1449 (compute_display_string_pos, compute_display_string_end):
1450 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1451 arrow keys.
1452 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1453 base_level_stop; instead, set base_level_stop to BEGV.
1454 Fixes crashes in vertical-motion.
0bb23927
EZ
1455 (next_element_from_buffer): Improve commentary for when
1456 the iterator is before prev_stop.
1457 (init_iterator): Initialize bidi_p from the default value of
1458 bidi-display-reordering, not from buffer-local value. Use the
1459 buffer-local value only if initializing for buffer iteration.
1460 (handle_invisible_prop): Support invisible properties on strings
1461 that are being bidi-reordered.
1462 (set_iterator_to_next): Support bidi reordering of C strings and
1463 Lisp strings.
1464 (next_element_from_string): Support bidi reordering of Lisp
1465 strings.
1466 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1467 (display_string): Support display of R2L glyph rows.
1468 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1469 (init_iterator): Don't initialize it->bidi_p for strings
1470 here.
1471 (reseat_to_string): Initialize it->bidi_p for strings here.
1472 (next_element_from_string, next_element_from_c_string)
1473 (next_element_from_buffer): Add xassert's for correspondence
1474 between IT's object being iterated and it->bidi_it.string
1475 structure.
1476 (face_before_or_after_it_pos): Support bidi iteration.
1477 (next_element_from_c_string): Handle the case of the first string
1478 character that is not the first one in the visual order.
1479 (get_visually_first_element): New function, refactored from common
1480 parts of next_element_from_buffer, next_element_from_string, and
1481 next_element_from_c_string.
1482 (tool_bar_lines_needed, redisplay_tool_bar)
1483 (display_menu_bar): Force left-to-right direction. Add a FIXME
1484 comment for making that be controlled by a user option.
1485 (push_it, pop_it): Save and restore the state of the
1486 bidi iterator. Save and restore the bidi_p flag.
1487 (pop_it): Iterate out of display property for string iteration as
1488 well.
1489 (iterate_out_of_display_property): Support iteration over strings.
1490 (handle_single_display_spec): Set up it->bidi_it for iteration
1491 over a display string, and call bidi_init_it.
1492 (handle_single_display_spec, next_overlay_string)
1493 (get_overlay_strings_1, push_display_prop): Set up the bidi
1494 iterator for displaying display or overlay strings.
1495 (forward_to_next_line_start): Don't use the shortcut if
1496 bidi-iterating.
1497 (back_to_previous_visible_line_start): If handle_display_prop
1498 pushed the iterator stack, restore the internal state of the bidi
1499 iterator by calling bidi_pop_it same number of times.
1500 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1501 and we are bidi-iterating, don't decrement the iterator position;
1502 instead, set the first_elt flag in the bidi iterator, to produce
1503 the same effect.
1504 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1505 (push_display_prop): xassert that we are iterating a buffer.
1506 (push_it, pop_it): Save and restore paragraph_embedding member.
1507 (handle_single_display_spec, next_overlay_string)
1508 (get_overlay_strings_1, reseat_1, reseat_to_string)
1509 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1510 correctly. Don't assume unibyte strings are not bidi-reordered.
1511 (compute_display_string_pos)
1512 (compute_display_string_end): Fix handling the case of C string.
1513 (push_it, pop_it): Save and restore from_disp_prop_p.
1514 (handle_single_display_spec, push_display_prop): Set the
1515 from_disp_prop_p flag.
1516 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1517 (pop_it): Call iterate_out_of_display_property only if we are
1518 popping after iteration over a string that came from a display
1519 property. Fix a typo in popping stretch info. Add an assertion
1520 for verifying that the iterator position is in sync with the bidi
1521 iterator.
1522 (handle_single_display_spec, get_overlay_strings_1)
1523 (push_display_prop): Fix initialization of paragraph direction for
1524 string when that of the parent object is not yet determined.
1525 (reseat_1): Call bidi_init_it to resync the bidi
1526 iterator with IT's position. (Bug#7616)
1527 (find_row_edges): If ROW->start.pos gives position
1528 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1529 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1530 Reset the from_disp_prop_p flag.
1531 (SAVE_IT, RESTORE_IT): New macros.
1532 (pos_visible_p, face_before_or_after_it_pos)
1533 (back_to_previous_visible_line_start)
1534 (move_it_in_display_line_to, move_it_in_display_line)
1535 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1536 (try_scrolling, redisplay_window, display_line): Use them when
1537 saving a temporary copy of the iterator and restoring it back.
1538 (back_to_previous_visible_line_start, reseat_1)
1539 (init_iterator): Empty the bidi cache "stack".
1540 (move_it_in_display_line_to): If iterator ended up at
1541 EOL, but we never saw any buffer positions smaller than
1542 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1543 motion in bidi-reordered lines.
1544 (move_it_in_display_line_to): Record prev_method and prev_pos
1545 immediately before the call to set_iterator_to_next. Fixes cursor
1546 motion in bidi-reordered lines with stretch glyphs and strings
1547 displayed in margins. (Bug#8133) (Bug#8867)
1548 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1549 TO_CHARPOS.
640c8776
SM
1550 (pos_visible_p): Support positions in bidi-reordered lines.
1551 Save and restore bidi cache.
0bb23927
EZ
1552
1553 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1554 (bidi_paragraph_info): Delete unused struct.
1555 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1556 (bidi_cache_start): New variable.
1557 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1558 to zero.
1559 (bidi_cache_fetch_state, bidi_cache_search)
1560 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1561 (bidi_cache_find, bidi_peek_at_next_level)
1562 (bidi_level_of_next_char, bidi_find_other_level_edge)
1563 (bidi_move_to_visually_next): Compare cache index with
1564 bidi_cache_start rather than with zero.
1565 (bidi_fetch_char): Accept new argument STRING; all callers
1566 changed. Support iteration over a string. Support strings with
1567 display properties. Support unibyte strings. Fix the type of
1568 `len' according to what STRING_CHAR_AND_LENGTH expects.
1569 (bidi_paragraph_init, bidi_resolve_explicit_1)
1570 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1571 (bidi_level_of_next_char, bidi_move_to_visually_next):
1572 Support iteration over a string.
0bb23927
EZ
1573 (bidi_set_sor_type, bidi_resolve_explicit_1)
1574 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1575 can now be zero (for strings); special values 0 and -1 were
1576 changed to -1 and -2, respectively.
1577 (bidi_char_at_pos): New function.
1578 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1579 Call it instead of FETCH_MULTIBYTE_CHAR.
1580 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1581 initialized to valid values.
1582 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1583 values.
1584 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1585 the test for valid cached positions. Fix the logic for looking up
1586 the sentinel state in the cache. GCPRO the Lisp string we are
1587 iterating.
1588 (bidi_push_it, bidi_pop_it): New functions.
1589 (bidi_initialize): Initialize the bidi cache start stack pointer.
1590 (bidi_cache_ensure_space): New function, refactored from part of
1591 bidi_cache_iterator_state. Don't assume the required size is just
1592 one BIDI_CACHE_CHUNK away.
1593 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1594 (bidi_count_bytes, bidi_char_at_pos): New functions.
1595 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1596 always valid if bidi_cache_idx is valid.
1597 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1598 is valid if it's going to be used.
1599 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1600 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1601 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1602 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1603 (bidi_find_other_level_edge, bidi_cache_start_stack):
1604 All variables related to cache indices are now EMACS_INT.
c965adc5 1605
0bb23927
EZ
1606 * dispextern.h (struct bidi_string_data): New structure.
1607 (struct bidi_it): New member `string'. Make flag members be 1-bit
1608 fields, and put them last in the struct.
640c8776
SM
1609 (compute_display_string_pos, compute_display_string_end):
1610 Update prototypes.
0bb23927
EZ
1611 (bidi_push_it, bidi_pop_it): Add prototypes.
1612 (struct iterator_stack_entry): New members bidi_p,
1613 paragraph_embedding, and from_disp_prop_p.
1614 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1615 (bidi_shelve_cache, bidi_unshelve_cache):
1616 Declare prototypes.
0bb23927
EZ
1617
1618 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1619 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1620 and vector-like objects.
1621
1622 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1623 cache around display iteration.
1624
1625 * window.c (Fwindow_end, window_scroll_pixel_based)
1626 (displayed_window_lines, Frecenter): Save and restore the bidi
1627 cache around display iteration.
1628
3bbd2265
LMI
16292011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1630
1631 * editfns.c (Fdelete_region): Clarify the use of the named
1632 parameters (bug#6788).
1633
adc47434
MR
16342011-07-14 Martin Rudalics <rudalics@gmx.at>
1635
1636 * indent.c (Fvertical_motion): Set and restore w->pointm when
1637 saving and restoring the window's buffer (Bug#9006).
1638
837c31f8
LMI
16392011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1640
1641 * editfns.c (Fstring_to_char): Clarify just what is returned
1642 (bug#6576). Text by Eli Zaretskii.
1643
ac389d0c
JB
16442011-07-13 Juanma Barranquero <lekktu@gmail.com>
1645
1646 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1647
0be0ce47
EZ
16482011-07-13 Eli Zaretskii <eliz@gnu.org>
1649
1650 * buffer.c (mmap_find): Fix a typo.
1651
cd18e7e3
JB
16522011-07-13 Johan Bockgård <bojohan@gnu.org>
1653
1654 Fix execution of x selection hooks.
1655 * xselect.c (Qx_lost_selection_functions)
1656 (Qx_sent_selection_functions): New vars.
1657 (syms_of_xselect): DEFSYM them.
1658 (x_handle_selection_request): Pass Qx_sent_selection_functions
1659 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1660 (x_handle_selection_clear,x_clear_frame_selections):
1661 Pass Qx_lost_selection_functions rather than
1662 Vx_lost_selection_functions to Frun_hook_with_args.
1663
47ea7f44
PE
16642011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1665
ac389d0c 1666 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1667 The old code sometimes used this field without initializing it.
1668
47ea7f44
PE
1669 * alloc.c (gc_sweep): Don't read past end of array.
1670 In theory, the old code could also have corrupted Emacs internals,
1671 though it'd be very unlikely.
1672
bc985c87
AS
16732011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1674
1675 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1676 argument. (Bug#4026)
bc985c87 1677
0cf34688
LMI
16782011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1679
b3dadd76
LMI
1680 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1681 key" (bug#4257).
1682
0cf34688
LMI
1683 * window.c (Fset_window_start): Doc fix (bug#4199).
1684 (Fset_window_hscroll): Ditto.
1685
270768cd
PE
16862011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1687
077e3dda 1688 Fix minor new problems caught by GCC 4.6.1.
270768cd 1689 * term.c (init_tty): Remove unused local.
490011a6 1690 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1691 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1692 not used otherwise.
270768cd 1693
b1f58454
CY
16942011-07-12 Chong Yidong <cyd@stupidchicken.com>
1695
1696 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1697
22b9578d
LMI
16982011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1699
6e70ab07
LMI
1700 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1701 are the mini-buffer and the echo area (bug#3320).
1702
22b9578d
LMI
1703 * term.c (init_tty): Remove support for supdup, c10 and perq
1704 terminals, which are no longer supported (bug#1482).
1705
8974cc9f
JB
17062011-07-10 Johan Bockgård <bojohan@gnu.org>
1707
1708 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1709
a560d974
JD
17102011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1711
1712 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1713 for non-popups (Bug#3642).
1714
1dae0f0a
AS
17152011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1716
268c2c36 1717 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1718 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1719 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1720 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1721 * data.c (fmod): Likewise.
1722 * dispnew.c (swap_glyphs_in_rows): Likewise.
1723 * emacs.c (memory_warning_signal): Likewise.
1724 * floatfns.c (float_error): Likewise.
1725 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1726 (otf_open, font_otf_capability, generate_otf_features)
1727 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1728 Likewise.
1729 * image.c (pbm_read_file): Likewise.
1730 * indent.c (string_display_width): Likewise.
1731 * intervals.c (check_for_interval, search_for_interval)
1732 (inc_interval_count, count_intervals, root_interval)
1733 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1734 * lread.c (defalias): Likewise.
268c2c36 1735 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1736 * regex.c (set_image_of_range_1, set_image_of_range)
1737 (regex_grow_registers): Likewise.
1738 * sysdep.c (strerror): Likewise.
1739 * termcap.c (valid_filename_p, tprint, main): Likewise.
1740 * tparam.c (main): Likewise.
1741 * unexhp9k800.c (run_time_remap, save_data_space)
1742 (update_file_ptrs, read_header, write_header, calculate_checksum)
1743 (copy_file, copy_rest, display_header): Likewise.
1744 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1745 Likewise.
1746 * xdisp.c (check_it): Likewise.
1747 * xfaces.c (register_color, unregister_color, unregister_colors):
1748 Likewise.
1749 * xfns.c (print_fontset_result): Likewise.
1750 * xrdb.c (member, fatal, main): Likewise.
1751
99033785
PE
17522011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 Fix minor problems found by static checking (Bug#9031).
1755 * chartab.c (char_table_set_range, map_sub_char_table):
1756 Remove unused locals.
1757 (uniprop_table): Now static.
1758 * composite.c (_work_char): Remove unused static var.
1759
9cb2ac56
JB
17602011-07-09 Juanma Barranquero <lekktu@gmail.com>
1761
1762 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1763
f25661f0
JD
17642011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1765
1766 * gtkutil.c (qttip_cb): Remove code without function.
1767
8278c4fe
EZ
17682011-07-09 Eli Zaretskii <eliz@gnu.org>
1769
1770 * w32.c (pthread_sigmask): New stub.
1771
1692ae2d 17722011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1773
8a6ebd58 1774 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1775 sigprocmask is portable only for single-threaded applications, and
1776 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1777 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1778 (LIBES): Use it.
1779 * callproc.c (Fcall_process):
1780 * process.c (create_process):
1781 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1782 Use pthread_sigmask, not sigprocmask.
123403e4 1783
1b854618
JD
17842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1785
1786 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1787 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1788 wrong (Bug#8591).
1789
3fe4b549
JD
17902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1791
0ce7e563
JD
1792 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1793 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1794 (xg_hide_tooltip): Fix comment.
1795
3fe4b549
JD
1796 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1797 in registerServicesMenuSendTypes.
1798 (validRequestorForSendType): Don't check ns_return_types.
1799
1800 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1801 ns_return_type.
1802
5df75e47
JR
18032011-07-08 Jason Rumney <jasonr@gnu.org>
1804
1805 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1806 frame struct members of non-existent frames (Bug#6284).
1807
699c10bd
JD
18082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1809
4393663b
JD
1810 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1811 variable firstTime not needed on OSX >= 10.6.
1812 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1813 >= 10.5. Use setKnobProportion, setDoubleValue.
1814
1815 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1816 (MAC_OS_X_VERSION_10_5): Define if not defined.
1817 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1818 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1819 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1820
1821 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1822 cString and lossyCString on OSX >= 10.4
1823
1824 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1825 sizeToFit on OSX >= 10.2.
1826
1827 * nsimage.m (allocInitFromFile): Don't use deprecated method
1828 bestRepresentationForDevice on OSX >= 10.6.
1829
1830 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1831 to avoid warning.
1832
1833 * emacs.c: Declare unexec_init_emacs_zone.
1834
a63e0781
JD
1835 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1836
699c10bd
JD
1837 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1838
1839 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1840 on svcsMenu (Bug#8842).
1841
1842 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1843 ns_return_types.
1844 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1845
1846 * nsterm.m (QUTF8_STRING): Declare.
1847 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1848 (validRequestorForSendType): Return type is (id).
1849 Change indexOfObjectIdenticalTo to indexOfObject.
1850 Check if we have local selection before returning self (Bug#8842).
1851 (writeSelectionToPasteboard): Put local selection into paste board
1852 if we have a local selection (Bug#8842).
1853 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1854
1855 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1856 (ns_get_local_selection): Declare.
1857
54e10184
LMI
18582011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1859
9888ff71
LMI
1860 * keymap.c (describe_map_tree): Don't insert a double newline at
1861 the end of the buffer (bug#1169) and return whether we inserted
1862 something.
1863
54e10184
LMI
1864 * callint.c (Fcall_interactively): Change "reading args" to
1865 "providing args" to try to clarify what it does (bug#1010).
1866
15fa4783
KH
18672011-07-07 Kenichi Handa <handa@m17n.org>
1868
1869 * composite.c (composition_compute_stop_pos): Ignore a static
1870 composition starting before CHARPOS (Bug#8915).
1871
1872 * xdisp.c (handle_composition_prop): Likewise.
1873
a8815b00
EZ
18742011-07-07 Eli Zaretskii <eliz@gnu.org>
1875
1876 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1877 (Bug#9015)
1878
ef7b981d 18792011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1880
1881 * character.h (unicode_category_t): New enum type.
1882
1883 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1884 (Qchar_code_property_table): New variable.
1885 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1886 (UNIPROP_COMPRESSED_FORM_P): New macros.
1887 (char_table_ascii): Uncompress the compressed values.
1888 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1889 Uncompress the compressed values.
ac389d0c 1890 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1891 (char_table_ref_and_range): Uncompress the compressed values.
1892 (sub_char_table_set): New arg is_uniprop. Callers changed.
1893 Uncompress the compressed values.
1894 (sub_char_table_set_range): Args changed. Callers changed.
1895 (char_table_set_range): Adjuted for the above change.
1896 (map_sub_char_table): Delete args default_val and parent. Add arg
1897 top. Give decoded values to a Lisp function.
640c8776 1898 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1899 values to a Lisp function. Gcpro more variables.
1900 (uniprop_table_uncompress)
1901 (uniprop_decode_value_run_length): New functions.
1902 (uniprop_decoder, uniprop_decoder_count): New variables.
1903 (uniprop_get_decoder, uniprop_encode_value_character)
1904 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1905 New functions.
1906 (uniprop_encoder, uniprop_encoder_count): New variables.
1907 (uniprop_get_encoder, uniprop_table)
1908 (Funicode_property_table_internal, Fget_unicode_property_internal)
1909 (Fput_unicode_property_internal): New functions.
1910 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1911 Sunicode_property_table_internal, Sget_unicode_property_internal,
1912 and Sput_unicode_property_internal. Defvar_lisp
1913 char-code-property-alist.
1914
640c8776 1915 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1916 Vunicode_category_table.
1917
640c8776 1918 * font.c (font_range): Adjust for the change of
c805dec0
KH
1919 Vunicode_category_table.
1920
76b397fb
DN
19212011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1922
1923 * m/iris4d.h: Remove file, move contents ...
1924 * s/irix6-5.h: ... here.
1925
22b4128e
PE
19262011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1929 * alloc.c (mark_buffer):
1930 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1931 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1932 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1933 This isn't true in general, and it's particularly not true
1934 if Emacs is configured with --with-wide-int.
1935 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1936 New macros, used in the buffer.c change.
1937
869795d6
JD
19382011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1939
1940 * xsettings.c: Use both GConf and GSettings if both are available.
1941 (store_config_changed_event): Add comment.
1942 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1943 (store_tool_bar_style_changed): New functions.
1944 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1945 (struct xsettings): Move font inside HAVE_XFT.
1946 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1947 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1948 Move inside HAVE_XFT.
640c8776 1949 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1950 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1951 also.
1952 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1953 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1954 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1955 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1956 (parse_settings): Move check for font inside HAVE_XFT.
1957 (read_settings, apply_xft_settings): Add comment.
1958 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1959 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1960 call store_font_name_changed.
1961 (xft_settings_event): Add comment.
1962 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1963 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1964 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1965 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1966 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1967 (xsettings_get_system_font, xsettings_get_system_normal_font):
1968 Add comment.
869795d6 1969
d8ed26bd
PE
19702011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 Random fixes. E.g., (random) never returned negative values.
1973 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1974 subseconds part to the entropy, as that's a bit more random.
1975 Prefer signed to unsigned, since the signedness doesn't matter and
1976 in general we prefer signed. When given a limit, use a
1977 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1978 latter isn't right if USE_2_TAGS_FOR_INTS.
1979 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1980 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1981
cabf1cac
SM
19822011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1983
1984 * textprop.c (text_property_stickiness):
1985 Obey Vtext_property_default_nonsticky.
1986 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1987 * w32fns.c (syms_of_w32fns):
1988 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1989
6e9b2be9
PE
19902011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1993 This is more efficient than Ffile_directory_p and avoids a minor race.
1994
90186c68
LMI
19952011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1996
7c301272
LMI
1997 * buffer.c (Foverlay_put): Say what the return value is
1998 (bug#7835).
1999
c4f2d8d4
LMI
2000 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2001 is a directory before asking whether to use the file name
2002 (bug#7564).
ad637907
LMI
2003 (barf_or_query_if_file_exists): Make the "File is a directory"
2004 error be more correct.
c4f2d8d4 2005
90186c68
LMI
2006 * fns.c (Frequire): Remove the mention of the .gz files, since
2007 that's installation-specific, but keep the mention of
2008 `get-load-suffixes'.
2009
da64016e
PE
20102011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2013 Report string overflow if the output is too long.
2014
7d47b580
JB
20152011-07-04 Juanma Barranquero <lekktu@gmail.com>
2016
a555cb87
JB
2017 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2018 (syms_of_gnutls): Remove duplicate DEFSYM for
2019 Qgnutls_bootprop_verify_hostname_error, an error for
2020 Qgnutls_bootprop_verify_error (which is no longer used).
2021
7d47b580
JB
2022 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2023 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2024 Also (re)move comments that are misplaced or no longer relevant.
2025
1e49bfab
LMI
20262011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2027
2028 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2029
1485f4c0
CY
20302011-07-03 Chong Yidong <cyd@stupidchicken.com>
2031
2032 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2033 and background color parameters if they have been changed.
2034
a9ab721e
LMI
20352011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2036
2037 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2038
cf7cff57
PE
20392011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2040
2e13213d
PE
2041 * xsettings.c (SYSTEM_FONT): Define only when used.
2042 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2043
cf7cff57
PE
2044 * keymap.c (access_keymap_1): Now static.
2045
7a8e04f7
CY
20462011-07-02 Chong Yidong <cyd@stupidchicken.com>
2047
2048 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2049 leave any prefix arg for the up event (Bug#1586).
2050
61352f62
LMI
20512011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2052
69bb1ef7
LMI
2053 * lread.c (syms_of_lread): Mention single symbols defined by
2054 `defvar' or `defconst' (bug#7154).
2055
61352f62 2056 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2057 (Frequire): Mention get-load-suffixes.
61352f62 2058
28545e04
MR
20592011-07-02 Martin Rudalics <rudalics@gmx.at>
2060
2061 * window.h (window): Remove clone_number slot.
2062 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2063 Remove.
2064 (make_parent_window, make_window, saved_window)
2065 (Fset_window_configuration, save_window_save): Don't deal with
2066 clone numbers.
2067 * buffer.c (Qclone_number): Remove declaration.
2068 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2069
3349e122
SM
20702011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2071
2072 Add multiple inheritance to keymaps.
2073 * keymap.c (Fmake_composed_keymap): New function.
2074 (Fset_keymap_parent): Simplify.
2075 (fix_submap_inheritance): Remove.
2076 (access_keymap_1): New function extracted from access_keymap to handle
2077 embedded parents and handle lists of maps.
2078 (access_keymap): Use it.
2079 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2080 (Fcopy_keymap): Handle embedded parents.
2081 (Fcommand_remapping, define_as_prefix): Simplify.
2082 (Fkey_binding): Simplify.
2083 (syms_of_keymap): Move minibuffer-local-completion-map,
2084 minibuffer-local-filename-completion-map,
2085 minibuffer-local-must-match-map, and
2086 minibuffer-local-filename-must-match-map to Elisp.
2087 (syms_of_keymap): Defsubr make-composed-keymap.
2088 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2089 (parse_menu_item): Trivial simplification.
2090
3279eb87
GM
20912011-07-01 Glenn Morris <rgm@gnu.org>
2092
2093 * Makefile.in (SETTINGS_LIBS): Fix typo.
2094
4550efdf
KI
20952011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2096
2097 * coding.c (Fencode_coding_string): Record the last coding system
2098 used, as the function doc string says (bug#8738).
2099
0949d2b6
JD
21002011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2101
2102 * xsettings.c (store_monospaced_changed): Take new font as arg and
2103 check for change against current_mono_font.
2104 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2105 (emacs_settings_constructor, emacs_settings_get_property)
2106 (emacs_settings_set_property, emacs_settings_class_init)
2107 (emacs_settings_init, gsettings_obj): Remove.
2108 (something_changedCB): New function for HAVE_GSETTINGS.
2109 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2110 with value as argument.
2111 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2112 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2113 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2114 "changed".
2115
2116 * xgselect.c: Add defined (HAVE_GSETTINGS).
2117 (xgselect_initialize): Ditto.
2118
2119 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2120 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2121 xg_select.
2122
bbc6b304
PE
21232011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 * eval.c (struct backtrace): Simplify and port the data structure.
2126 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2127 signed bit field, as this assumption is not portable and it makes
2128 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2129 "char debug_on_exit : 1" as this is not portable either; instead,
2130 use the portable "unsigned int debug_on_exit : 1". Remove unused
2131 member evalargs. Remove obsolete comments about cc bombing out.
2132
9851bfc5
JD
21332011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2134
51bb811f 2135 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2136 Let HAVE_GSETTINGS override HAVE_GCONF.
2137 (store_monospaced_changed): New function.
2138 (EMACS_SETTINGS): A new type derived from GObject to handle
2139 GSettings notifications.
2140 (emacs_settings_constructor, emacs_settings_get_property)
2141 (emacs_settings_set_property, emacs_settings_class_init):
2142 New functions.
2143 (gsettings_client, gsettings_obj): New variables.
2144 (GSETTINGS_SCHEMA): New define.
2145 (something_changedCB): Call store_monospaced_changed.
2146 (init_gsettings): New function.
2147 (xsettings_initialize): Call init_gsettings.
2148 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2149 to NULL.
2150
640c8776 2151 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2152 GCONF_CFLAGS/LIBS.
2153
5386012d
MR
21542011-06-29 Martin Rudalics <rudalics@gmx.at>
2155
2156 * window.c (resize_root_window, grow_mini_window)
2157 (shrink_mini_window): Rename Qresize_root_window to
2158 Qwindow_resize_root_window and Qresize_root_window_vertically to
2159 Qwindow_resize_root_window_vertically.
2160
f13e0b08
PE
21612011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2164
94515237
JB
21652011-06-27 Juanma Barranquero <lekktu@gmail.com>
2166
2167 * makefile.w32-in: Redesign dependencies so they reflect more
2168 clearly which files are directly included by each source file,
2169 and not through other includes.
2170
e43b6e43
MR
21712011-06-27 Martin Rudalics <rudalics@gmx.at>
2172
2173 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2174 (sort_overlays, overlay_strings): When an overlay's clone number
2175 matches the window's clone number process the overlay even if
2176 the overlay's window property doesn't match the current window.
2177
d68443dc
MR
2178 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2179 (Fwindow_hchild): Rename to Fwindow_left_child.
2180 (Fwindow_next): Rename to Fwindow_next_sibling.
2181 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2182 (resize_window_check): Rename to window_resize_check.
2183 (resize_window_apply): Rename to window_resize_apply.
2184 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2185 (Fdelete_other_windows_internal, resize_frame_windows)
2186 (Fsplit_window_internal, Fdelete_window_internal)
2187 (grow_mini_window, shrink_mini_window)
2188 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2189
c7e73be5
JD
21902011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2191
2192 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2193 (emacs_fixed_set_min_size): Remove.
2194 (emacs_fixed_new): Take frame as argument.
2195
2196 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2197 (_EmacsFixedPrivate): Remove minwidth/height.
2198 Add struct frame *f.
2199 (emacs_fixed_init): Initialize priv->f.
2200 (get_parent_class, emacs_fixed_set_min_size): Remove.
2201 (emacs_fixed_new): Set priv->f to argument.
2202 (emacs_fixed_get_preferred_width)
2203 (emacs_fixed_get_preferred_height): Use min_width/height from
2204 frames size_hint to set minimum and natural (Bug#8919).
2205 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2206 and use min_width/height from frames size_hint to set
2207 min_width/height (Bug#8919).
2208
2209 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2210 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2211 Fix indentation.
c7e73be5 2212
cf99dcf8
EZ
22132011-06-26 Eli Zaretskii <eliz@gnu.org>
2214
2215 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2216 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2217 called at ZV.
2218
029529ac
CY
22192011-06-26 Chong Yidong <cyd@stupidchicken.com>
2220
2221 * process.c (wait_reading_process_output): Bypass select if
2222 waiting for a cell while ignoring keyboard input, and input is
2223 pending. Suggested by Jan Djärv (Bug#8869).
2224
7a7ef429
PE
22252011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 Use gnulib's dup2 module instead of rolling our own.
2228 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2229
11fdef7d 22302011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2231
2232 * dispnew.c (scrolling_window): Before scrolling, turn off a
2233 mouse-highlight in the window being scrolled.
2234
cd3520a4
JB
22352011-06-24 Juanma Barranquero <lekktu@gmail.com>
2236
2237 Move DEFSYM to lisp.h and use everywhere.
2238
2239 * character.h (DEFSYM): Move declaration...
2240 * lisp.h (DEFSYM): ...here.
2241
2242 * gnutls.c:
2243 * minibuf.c:
2244 * w32menu.c:
2245 * w32proc.c:
2246 * w32select.c: Don't include character.h.
2247
2248 * alloc.c (syms_of_alloc):
2249 * buffer.c (syms_of_buffer):
2250 * bytecode.c (syms_of_bytecode):
2251 * callint.c (syms_of_callint):
2252 * casefiddle.c (syms_of_casefiddle):
2253 * casetab.c (init_casetab_once):
2254 * category.c (init_category_once, syms_of_category):
2255 * ccl.c (syms_of_ccl):
2256 * cmds.c (syms_of_cmds):
2257 * composite.c (syms_of_composite):
2258 * dbusbind.c (syms_of_dbusbind):
2259 * dired.c (syms_of_dired):
2260 * dispnew.c (syms_of_display):
2261 * doc.c (syms_of_doc):
2262 * editfns.c (syms_of_editfns):
2263 * emacs.c (syms_of_emacs):
2264 * eval.c (syms_of_eval):
2265 * fileio.c (syms_of_fileio):
2266 * fns.c (syms_of_fns):
2267 * frame.c (syms_of_frame):
2268 * fringe.c (syms_of_fringe):
2269 * insdel.c (syms_of_insdel):
2270 * keymap.c (syms_of_keymap):
2271 * lread.c (init_obarray, syms_of_lread):
2272 * macros.c (syms_of_macros):
2273 * msdos.c (syms_of_msdos):
2274 * print.c (syms_of_print):
2275 * process.c (syms_of_process):
2276 * search.c (syms_of_search):
2277 * sound.c (syms_of_sound):
2278 * syntax.c (init_syntax_once, syms_of_syntax):
2279 * terminal.c (syms_of_terminal):
2280 * textprop.c (syms_of_textprop):
2281 * undo.c (syms_of_undo):
2282 * w32.c (globals_of_w32):
2283 * window.c (syms_of_window):
2284 * xdisp.c (syms_of_xdisp):
2285 * xfaces.c (syms_of_xfaces):
2286 * xfns.c (syms_of_xfns):
2287 * xmenu.c (syms_of_xmenu):
2288 * xsettings.c (syms_of_xsettings):
2289 * xterm.c (syms_of_xterm): Use DEFSYM.
2290
4228cf16
TZ
22912011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2292
cd3520a4 2293 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2294
7fcccf1e
PE
22952011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2296
7efb4e0e
PE
2297 Integer and buffer overflow fixes (Bug#8873).
2298
ff5844ad
PE
2299 * print.c (printchar, strout): Check for string overflow.
2300 (PRINTPREPARE, printchar, strout):
2301 Don't set size unless allocation succeeds.
2302
90532f02
PE
2303 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2304 for sizes. Check for string overflow more accurately.
2305 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2306
6d84508d
PE
2307 * macros.c: Integer and buffer overflow fixes.
2308 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2309 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2310 Use ptrdiff_t, not int, for sizes.
2311 Don't increment bufsize until after realloc succeeds.
2312 Check for size-calculation overflow.
2313 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2314
437b2cb4
PE
2315 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2316
8b9ac8b4
PE
2317 * lread.c: Integer overflow fixes.
2318 (read_integer): Radix is now EMACS_INT, not int,
2319 to improve quality of diagnostics for out-of-range radices.
2320 Calculate buffer size correctly for out-of-range radices.
2321 (read1): Check for integer overflow in radices, and in
2322 read-circle numbers.
82cb60d3
PE
2323 (read_escape): Avoid int overflow.
2324 (Fload, openp, read_buffer_size, read1)
2325 (substitute_object_recurse, read_vector, read_list, map_obarray):
2326 Use ptrdiff_t, not int, for sizes.
2327 (read1): Use EMACS_INT, not int, for sizes.
20270765 2328 Check for size overflow.
8b9ac8b4 2329
7fcccf1e
PE
2330 * image.c (cache_image): Check for size arithmetic overflow.
2331
bfbbd7e7
PE
2332 * lread.c: Integer overflow issues.
2333 (saved_doc_string_size, saved_doc_string_length)
2334 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2335 Now ptrdiff_t, not int.
2336 (read1): Don't assume doc string length fits in int. Check for
2337 out-of-range doc string lengths.
2338 (read_list): Don't assume file position fits in int.
39019e54 2339 (read_escape): Check for hex character overflow.
bfbbd7e7 2340
4e323265
LL
23412011-06-22 Leo Liu <sdl.web@gmail.com>
2342
2343 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2344 Move to minibuffer.el.
2345
85fece3e
PE
23462011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2347
20b84ce9 2348 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2349 The following patches are for when GLYPH_DEBUG && !XASSERT.
2350 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2351 * dispnew.c (flush_stdout):
2352 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2353 Mark as externally visible.
2354 * dispnew.c (check_window_matrix_pointers): Now static.
2355 * dispnew.c (window_to_frame_vpos):
2356 * xfns.c (unwind_create_frame):
2357 * xterm.c (x_check_font): Remove unused local.
2358 * scroll.c (CHECK_BOUNDS):
2359 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2360 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2361 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2362 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2363 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2364 Now static.
2365 (debug_method_add): Use va_list and vsprintf rather than relying
2366 on undefined behavior with wrong number of arguments.
2367 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2368 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2369 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2370 since we're not interested in debugging glyphs with old libraries.
2371 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2372 GCC 4.6.0's static checking.
2373
0766b489
PE
23742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2375
31fd4b32
PE
2376 Integer overflow and signedness fixes (Bug#8873).
2377 A few related buffer overrun fixes, too.
2378
b79e8648
PE
2379 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2380
0766b489
PE
2381 * dispextern.h (struct face.stipple):
2382 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2383 (x_bitmap_mask, x_allocate_bitmap_record)
2384 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2385 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2386 (x_create_bitmap_from_xpm_data):
2387 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2388 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2389 (.bitmaps_last):
2390 * xfaces.c (load_pixmap):
2391 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2392 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2393 (.bitmaps_last, struct x_output.icon_bitmap):
2394 Use ptrdiff_t, not int, for bitmap indexes.
2395 (x_allocate_bitmap_record): Check for size overflow.
2396 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2397
b081724f
PE
2398 Use ptrdiff_t, not int, for overlay counts.
2399 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2400 * editfns.c (overlays_around, get_pos_property):
2401 * textprop.c (get_char_property_and_overlay):
2402 * xdisp.c (next_overlay_change, note_mouse_highlight):
2403 * xfaces.c (face_at_buffer_position):
21514da7
PE
2404 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2405 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2406 (Fnext_overlay_change, Fprevious_overlay_change)
2407 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2408 Use ptrdiff_t, not int, for sizes.
21514da7 2409 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2410
3de73e5e
PE
2411 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2412
2606c57b
PE
2413 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2414 (x_session_initialize): Do not assume string length fits in int.
2415
aaafe47a
PE
2416 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2417 This is unlikely, but can occur if DPI is outlandish.
2418
2674ddc8 2419 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2420 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2421
28154962
PE
2422 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2423 * xrdb.c (magic_file_p, search_magic_path):
2424 Omit last arg SUFFIX; it was always 0. All callers changed.
2425 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2426
7de51af5
PE
2427 * xfont.c (xfont_match): Avoid need for strlen.
2428
25ed6cc3
PE
2429 * xfns.c: Don't assume strlen fits in int.
2430 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2431
4eab31dd
PE
2432 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2433 not unsigned long, as we prefer signed integers. All callers changed.
2434 Detect integer overflow in repeat count.
2435 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2436 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2437
171e2a58
PE
2438 * termcap.c: Don't assume sizes fit in int and never overflow.
2439 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2440 (gobble_line): Check for size-calculation overflow.
2441
ad39faca 2442 * minibuf.c (Fread_buffer):
6e5bb2dc 2443 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2444 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2445 Don't assume string length fits in int.
2446
52c61c22 2447 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2448 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2449
b5b8c9e5
PE
2450 * font.c: Don't assume string length fits in int.
2451 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2452 Use ptrdiff_t, not int.
ccd6111c
PE
2453 (font_intern_prop): Don't assume string length fits in int.
2454 Don't assume integer property fits in fixnum.
2455 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2456
882f0d81 2457 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2458 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2459 Reformulate so as not to need the command string.
2460 Invoke gzip -cd rather than gunzip, as it's more portable.
2461 (lock_info_type, lock_file_1, lock_file):
2462 Don't assume pid_t and time_t fit in unsigned long.
2463 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2464 (current_lock_owner): Prefer signed type for sizes.
2465 Use memcpy, not strncpy, where memcpy is what is really wanted.
2466 Don't assume (via atoi) that time_t and pid_t fit in int.
2467 Check for time_t and/or pid_t out of range, e.g., via a network share.
2468 Don't alloca where an auto var works fine.
2469
93f4cf88
PE
2470 * fileio.c: Fix some integer overflow issues.
2471 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2472 Don't assume string length fits in int.
2473 (directory_file_name): Don't assume string length fits in long.
2474 (make_temp_name): Don't assume pid fits in int, or that its print
2475 length is less than 20.
2476
f3e92b69
PE
2477 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2478
1bfdaf10
PE
2479 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2480
35016e9a
PE
2481 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2482
3d1e65a1
PE
2483 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2484 We prefer signed integers, even for size calculations.
2485
0b963a93
PE
2486 * emacs.c: Don't assume string length fits in 'int'.
2487 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2488 (main): Don't invoke strlen when not needed.
2489
573f4b54
PE
2490 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2491 (XD_DEBUG_MESSAGE): Don't waste a byte.
2492
989f33ba
PE
2493 * callproc.c (getenv_internal_1, getenv_internal)
2494 (Fgetenv_internal):
965d34eb
PE
2495 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2496
e4d29b33
PE
2497 * lread.c (invalid_syntax): Omit length argument.
2498 All uses changed. This doesn't fix a bug, but it simplifies the
2499 code away from its former Hollerith-constant appearance, and it's
2500 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2501 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2502
eb49b136
PE
2503 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2504 This didn't break anything, but it didn't help either.
2505 It's confusing to put a bogus integer in a place where the actual
2506 value does not matter.
9f62aeb1 2507 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2508 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2509
15375a22
PE
2510 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2511 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2512 implementation.
b61cc01c
PE
2513 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2514 We prefer signed types, and the value cannot exceed the EMACS_INT
2515 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2516 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2517 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2518 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2519
53b2623d
PE
2520 * indent.c (sane_tab_width): New function.
2521 (current_column, scan_for_column, Findent_to, position_indentation)
2522 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2523 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2524
51cab52b 2525 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2526
f2ed8a70
PE
2527 * lisp.h (lint_assume): New macro.
2528 * composite.c (composition_gstring_put_cache):
2529 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2530
abe80cc6
PE
2531 * editfns.c, insdel.c:
2532 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2533
b02c740e
PE
2534 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2535
ebc96716
PE
2536 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2537
b4e50fa0 2538 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2539 Use much-faster test for byte-length change.
311d5d7c 2540 Don't assume string byte-length fits in 'int'.
a4cf38e4 2541 Check that character arg fits in 'int'.
85461888 2542 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2543
c0c1ee9f
PE
2544 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2545
a498d7f4
PE
2546 * fns.c (concat): Catch string overflow earlier.
2547 Do not rely on integer wraparound.
2548
51cab52b
PE
2549 * dispextern.h (struct it.overlay_strings_charpos)
2550 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2551 * xdisp.c (forward_to_next_line_start)
2552 (back_to_previous_visible_line_start)
2553 (reseat_at_next_visible_line_start, next_element_from_buffer):
2554 Don't arbitrarily truncate the value of 'selective' to int.
2555
76031fad
PE
2556 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2557
5eb55db9
PE
2558 * composite.c: Don't truncate sizes to 'int'.
2559 (composition_gstring_p, composition_reseat_it)
2560 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2561 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2562 not EMACS_UINT, for indexes.
5eb55db9 2563
0703a717
PE
2564 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2565
d6202519
PE
2566 * buffer.c: Include <verify.h>.
2567 (struct sortvec.priority, struct sortstr.priority):
8961a454 2568 Now EMACS_INT, not int.
c20998a7 2569 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2570 (struct sortstr.size, record_overlay_string)
2571 (struct sortstrlist.size, struct sortlist.used):
2572 Don't truncate size to int.
2573 (record_overlay_string): Check for size-calculation overflow.
d6202519 2574 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2575
d5a19415
JM
25762011-06-22 Jim Meyering <meyering@redhat.com>
2577
029529ac 2578 Don't leak an XBM-image-sized buffer
d5a19415
JM
2579 * image.c (xbm_load): Free the image buffer after using it.
2580
a9041e6c
PE
25812011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2582
2583 Port to Sun C.
2584 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2585 that Sun C diagnosed.
2586 * fns.c (secure_hash): Fix pointer signedness issue.
2587 * intervals.c (static_offset_intervals): New function.
2588 (offset_intervals): Use it.
2589
7f3f739f
LL
25902011-06-21 Leo Liu <sdl.web@gmail.com>
2591
2592 * deps.mk (fns.o):
2593 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2594 sha512.h.
2595
2596 * fns.c (secure_hash): Rename from crypto_hash_function and change
2597 the first arg to accept symbols.
5b66d427 2598 (Fsecure_hash): New primitive.
7f3f739f
LL
2599 (syms_of_fns): New symbols.
2600
76147d94
DD
26012011-06-20 Deniz Dogan <deniz@dogan.se>
2602
2603 * process.c (Fset_process_buffer): Clarify return value in
2604 docstring.
2605
7d7d0045
CY
26062011-06-18 Chong Yidong <cyd@stupidchicken.com>
2607
2608 * dispnew.c (add_window_display_history): Use BVAR.
2609
2610 * xdisp.c (debug_method_add): Use BVAR.
2611 (check_window_end, dump_glyph_matrix, dump_glyph)
2612 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2613
2614 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2615 Likewise.
2616
2617 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2618 check till after the cache is created in init_frame_faces.
2619
ff2bc410
SM
26202011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2621
2622 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2623
28177add
PE
26242011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2625
dd3482fe
PE
2626 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2627 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2628 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2629
393d71f3 2630 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2631 * fileio.c (Finsert_file_contents):
2632 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2633 Remove the old (too-loose) buffer overflow checks.
2634 They weren't needed, since make_gap checks for buffer overflow.
2635 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2636 The old code merely checked for Emacs fixnum overflow, and relied
2637 on undefined (wraparound) behavior. The new code avoids undefined
2638 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2639
2e6813b0 2640 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2641 Tune. Don't use wider integers than needed. Don't use alloca.
2642 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2643
599a9e4f
PE
2644 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2645
99561444
PE
2646 * insdel.c, lisp.h (buffer_overflow): New function.
2647 (insert_from_buffer_1, replace_range, replace_range_2):
2648 * insdel.c (make_gap_larger):
2649 * editfns.c (Finsert_char):
2650 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2651
28177add
PE
2652 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2653
e69dafad
PE
26542011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2655
a7af7fde 2656 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2657
b1c46f02
PE
2658 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2659 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2660
e69dafad
PE
2661 * fileio.c: Don't assume EMACS_INT fits in off_t.
2662 (emacs_lseek): New static function.
2663 (Finsert_file_contents, Fwrite_region): Use it.
2664 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2665
566684ea
PE
2666 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2667
e6966cd6
PE
2668 * fns.c: Don't overflow int when computing a list length.
2669 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2670 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2671 truncation on 64-bit hosts. Check for QUIT every
2672 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2673 faster and is responsive enough.
2674 (Flength): Report an error instead of overflowing an integer.
2675 (Fsafe_length): Return a float if the value is not representable
2676 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2677 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2678 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2679
dd0b0efb
PE
2680 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2681 (header_size, word_size): New constants.
2682 (allocate_vectorlike): Don't check size overflow here.
2683 (allocate_vector): Check it here instead, since this is the only
2684 caller of allocate_vectorlike that could cause overflow.
2685 Check that the new vector's length is representable as a fixnum.
2686
86fe5cfe
PE
2687 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2688 The previous code was bogus. For example, next_almost_prime (32)
2689 returned 39, which is undesirable as it is a multiple of 3; and
2690 next_almost_prime (24) returned 25, which is a multiple of 5 so
2691 why was the code bothering to check for multiples of 7?
2692
80e88859
PE
2693 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2694
4a2f0ad6
PE
2695 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2696
f66c7cf8
PE
2697 Variadic C functions now count arguments with ptrdiff_t.
2698 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2699 Back then I didn't know that the Emacs coding style prefers signed int.
2700 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2701 were being counted with int, which may truncate counts on 64-bit
2702 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2703 * lisp.h (struct Lisp_Subr.function.aMANY)
2704 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2705 Arg counts are now ptrdiff_t, not size_t.
2706 All variadic functions and their callers changed accordingly.
2707 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2708 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2709 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2710 * callint.c (Fcall_interactively): Check arg count for overflow,
2711 to avoid potential buffer overrun. Use signed char, not 'int',
2712 for 'varies' array, so that we needn't bother to check its size
2713 calculation for overflow.
2714 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2715 * eval.c (apply_lambda):
2716 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2717 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2718 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2719
a1759b76
PE
2720 * callint.c (Fcall_interactively): Don't use index var as event count.
2721
d96be9fc
PE
2722 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2723 * mem-limits.h (SIZE): Remove; no longer used.
2724
a690a978 2725 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2726
578c21e6
PE
2727 Remove unnecessary casts.
2728 * xterm.c (x_term_init):
2729 * xfns.c (x_set_border_pixel):
2730 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2731 These aren't needed now that we assume ANSI C.
2732
96f53c6c
PE
2733 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2734 It's more likely to cause problems (due to unsigned overflow)
2735 than to cure them.
2736
83c77d31
PE
2737 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2738
ee2079f1
PE
2739 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2740
6da65536
PE
2741 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2742
7147c4a4
PE
2743 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2744
193e32d9
PE
2745 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2746
e5533da6
PE
2747 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2748
9910e595
PE
2749 GLYPH_CODE_FACE returns EMACS_INT, not int.
2750 * dispextern.h (merge_faces):
2751 * xfaces.c (merge_faces):
01103c44
PE
2752 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2753 Don't assume EMACS_INT fits in int.
9910e595 2754
2638320e
PE
2755 * character.h (CHAR_VALID_P): Remove unused parameter.
2756 * fontset.c, lisp.h, xdisp.c: All uses changed.
2757
045eb8d9
PE
2758 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2759
c1f134b5
PE
2760 * fns.c (concat): Minor tuning based on overflow analysis.
2761 This doesn't fix any bugs. Use int to hold character, instead
2762 of constantly refetching from Emacs object. Use XFASTINT, not
2763 XINT, for value known to be a character. Don't bother comparing
2764 a single byte to 0400, as it's always less.
2765
395fcb93 2766 * floatfns.c (Fexpt):
327eeec8
PE
2767 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2768
abbd3d23
PE
2769 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2770 for characters.
2771
684a03ef
PE
2772 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2773
0fed43f3
PE
2774 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2775 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2776 incorrectly succeed when S was a string, because 4294967386 was
2777 truncated before it was used.
2778
8fd02eb7
PE
2779 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2780 Otherwise, an out-of-range integer could cause undefined behavior
2781 on a 64-bit host.
2782
f8c86b69
PE
2783 * composite.c: Use int, not EMACS_INT, for characters.
2784 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2785 EMACS_INT, for values that are known to be in character range.
2786 This doesn't fix any bugs but is the usual style inside Emacs and
2787 may generate better code on 32-bit machines.
2788
34206dd2
PE
2789 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2790 This is for reasons similar to the recent CHAR_STRING fix.
2791 * charset.c (Fencode_char): Check that character arg is actually
2792 a character. Pass an int to ENCODE_CHAR.
2793 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2794 wider than 'int', as a compile-time check to prevent future regressions
2795 in this area.
2796
c5958d4c 2797 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2798
2799 Make sure a 64-bit char is never passed to CHAR_STRING.
2800 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2801 by silently ignoring the top 32 bits, allowing some values
2802 that were far too large to be valid characters.
2803 * character.h: Include <verify.h>.
2804 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2805 arguments are no wider than unsigned, as a compile-time check
2806 to prevent future regressions in this area.
2807 * data.c (Faset):
01103c44 2808 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2809 (Fsubst_char_in_region):
2810 * fns.c (concat):
2811 * xdisp.c (decode_mode_spec_coding):
2812 Adjust to CHAR_STRING's new requirement.
2813 * editfns.c (Finsert_char, Fsubst_char_in_region):
2814 * fns.c (concat): Check that character args are actually
2815 characters. Without this test, these functions did the wrong
2816 thing with wildly out-of-range values on 64-bit hosts.
2817
d37ca623
PE
2818 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2819 These casts should not be needed on 32-bit hosts, either.
2820 * keyboard.c (read_char):
2821 * lread.c (Fload): Remove casts to unsigned.
2822
ea204efb
PE
2823 * lisp.h (UNSIGNED_CMP): New macro.
2824 This fixes comparison bugs on 64-bit hosts.
2825 (ASCII_CHAR_P): Use it.
2826 * casefiddle.c (casify_object):
01103c44 2827 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2828 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2829 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2830 * dispextern.h (FACE_FROM_ID):
2831 * keyboard.c (read_char): Use UNSIGNED_CMP.
2832
41cb286c
PE
2833 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2834 not to EMACS_INT, to avoid GCC warning.
2835
4a1b9832
PE
2836 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2837
55daad71
PE
2838 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2839 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2840 isn't needed on 32-bit machines.
8f95c75c 2841
01103c44
PE
2842 * buffer.c (Fgenerate_new_buffer_name):
2843 Use EMACS_INT for count, not int.
0ceccced 2844 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2845
2846 * data.c (Qcompiled_function): Now static.
2847
c6f072e7
PE
2848 * window.c (window_body_lines): Now static.
2849
20ce5912
PE
2850 * image.c (gif_load): Rename local to avoid shadowing.
2851
9c4c5f81
PE
2852 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2853 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2854 * alloc.c (make_save_value): Integer argument is now of type
2855 ptrdiff_t, not int.
2856 (mark_object): Use ptrdiff_t, not int.
2857 * lisp.h (pD): New macro.
2858 * print.c (print_object): Use it.
2859
c0c5c8ae
PE
2860 * alloc.c: Use EMACS_INT, not int, to count objects.
2861 (total_conses, total_markers, total_symbols, total_vector_size)
2862 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2863 (total_free_floats, total_floats, total_free_intervals)
2864 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2865 Now EMACS_INT, not int. All uses changed.
2866 (Fgarbage_collect): Compute overall total using a double, so that
2867 integer overflow is less likely to be a problem. Check for overflow
2868 when converting back to an integer.
5a25e253
PE
2869 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2870 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2871 These were 'int' variables that could overflow on 64-bit hosts;
2872 they were never used, so remove them instead of repairing them.
211a0b2a 2873 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2874 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2875 Previously, this ceilinged at INT_MAX, but that doesn't work on
2876 64-bit machines.
e46bb31a 2877 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2878
c78baabf 2879 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2880 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2881 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2882 when a (possibly-narrower) signed value would do just as well.
2883 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2884
c9d624c6
PE
2885 * alloc.c: Catch some string size overflows that we were missing.
2886 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2887 for convenience in STRING_BYTES_MAX.
2888 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2889 The definition here is exact; the one in lisp.h was approximate.
2890 (allocate_string_data): Check for string overflow. This catches
2891 some instances we weren't catching before. Also, it catches
2892 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2893 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2894 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2895
c9d624c6
PE
2896 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2897 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2898 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2899
353032ce
PE
2900 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2901
2bccce07
PE
2902 * alloc.c (Fmake_string): Check for out-of-range init.
2903
0ac30604
SM
29042011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2905
2906 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2907
c195f2de
JD
29082011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2909
2910 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2911 xg_get_default_scrollbar_width.
2912
2913 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2914 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2915 (style_changed_cb): Call update_theme_scrollbar_width and call
2916 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2917 all frames (Bug#8505).
2918 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2919 Call gtk_window_set_resizable if HAVE_GTK3.
2920 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2921 and height if HAVE_GTK3 (Bug#8505).
2922 (scroll_bar_width_for_theme): New variable.
2923 (update_theme_scrollbar_width): New function.
2924 (xg_get_default_scrollbar_width): Move code to
2925 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2926 (xg_initialize): Call update_theme_scrollbar_width.
2927
2928 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2929
2930 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2931
e10ac9f1
MR
29322011-06-12 Martin Rudalics <rudalics@gmx.at>
2933
2934 * frame.c (make_frame): Call other_buffer_safely instead of
2935 other_buffer.
2936
2937 * window.c (temp_output_buffer_show): Call display_buffer with
2938 second argument Vtemp_buffer_show_specifiers and reset latter
2939 immediately after the call.
2940 (Vtemp_buffer_show_specifiers): New variable.
2941 (auto_window_vscroll_p, next_screen_context_lines)
2942 (Vscroll_preserve_screen_position): Remove leading asterisks from
2943 doc-strings.
2944
2d3c217e 29452011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2946
7b7f97e8 2947 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2948 * buffer.c (Qclone_number): Remove for now, as it's unused.
2949 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2950 (record_buffer): Remove unused local.
2951 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2952 (set_frame_buffer_list): Remove; unused.
2953 * frame.h (other_visible_frames): Remove decl.
2954 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2955 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2956 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2957 if HAVE_GPM.
2958 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2959 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2960 Define only if HAVE_GPM.
2961 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2962 (update_hints_inhibit): Remove; never set. All uses removed.
2963 * widgetprv.h (emacsFrameClassRec): Remove decl.
2964 * window.c (delete_deletable_window): Now returns void, since it
2965 wasn't returning anything.
2966 (compare_window_configurations): Remove unused locals.
2967 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2968 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2969 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2970 the same widths as pointers. This follows up on the 2011-05-06 patch.
2971 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2972 * xterm.h: Likewise.
2973 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2974
1384b89e
JB
29752011-06-12 Juanma Barranquero <lekktu@gmail.com>
2976
2977 * makefile.w32-in: Update dependencies.
2978 (LISP_H): Add lib/intprops.h.
2979
1100a63c
CY
29802011-06-11 Chong Yidong <cyd@stupidchicken.com>
2981
2982 * image.c (gif_load): Add animation frame delay to the metadata.
2983 (syms_of_image): Use DEFSYM. New symbol `delay'.
2984
6198ccd0
MR
29852011-06-11 Martin Rudalics <rudalics@gmx.at>
2986
2987 * window.c (delete_deletable_window): Re-add.
2988 (Fset_window_configuration): Rewrite to handle dead buffers and
2989 consequently deletable windows.
2990 (window_tree, Fwindow_tree): Remove. Supply functionality in
2991 window.el.
2992 (compare_window_configurations): Simplify code.
2993
b6e3633c
AS
29942011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2995
1ab0dee5
AS
2996 * image.c (imagemagick_load_image): Fix type mismatch.
2997 (Fimagemagick_types): Likewise.
2998
b6e3633c
AS
2999 * window.h (replace_buffer_in_windows): Declare.
3000
9397e56f
MR
30012011-06-11 Martin Rudalics <rudalics@gmx.at>
3002
3003 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3004 Qclone_number. Remove external declaration of Qdelete_window.
3005 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3006 code.
640c8776
SM
3007 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3008 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3009 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3010 buffer list implementation.
3011 (other_buffer_safely): New function.
3012 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3013 calls to replace_buffer_in_windows and
3014 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3015 if allowed.
3016 (record_buffer): Inhibit quitting and rewrite using quittable
3017 functions. Run Qbuffer_list_update_hook if allowed.
3018 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3019 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3020 Move switch-to-buffer to window.el.
9397e56f
MR
3021 (bury-buffer): Move to window.el.
3022 (Vbuffer_list_update_hook): New variable.
3023
3024 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3025 section.
3026
3027 * window.h (resize_frame_windows): Move up in code.
3028 (Fwindow_frame): Remove EXFUN.
3029 (replace_buffer_in_all_windows): Remove prototype.
3030 (replace_buffer_in_windows_safely): Add prototype.
3031
3032 * window.c: Declare Qdelete_window static again. Move down
3033 declaration of select_count.
3034 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3035 (Fother_window): Move to window.el.
3036 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3037 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3038 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3039 window.el.
3040 (replace_buffer_in_windows): Implement by calling
3041 Qreplace_buffer_in_windows.
3042 (replace_buffer_in_all_windows): Remove with some functionality
3043 moved into replace_buffer_in_windows_safely.
3044 (replace_buffer_in_windows_safely): New function.
3045 (select_window_norecord, select_frame_norecord): Move in front
3046 of run_window_configuration_change_hook. Remove now obsolete
3047 declarations.
640c8776
SM
3048 (Fset_window_buffer): Rewrite doc-string.
3049 Call Qrecord_window_buffer.
9397e56f
MR
3050 (keys_of_window): Move binding for other-window to window.el.
3051
b50691aa
CY
30522011-06-11 Chong Yidong <cyd@stupidchicken.com>
3053
3054 * dispextern.h (struct image): Replace data member, whose int_val
3055 and ptr_val fields were not used by anything, with a single
3056 lisp_val object.
3057
3058 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3059 (gif_clear_image, gif_load, imagemagick_load_image)
3060 (gs_clear_image, gs_load): Callers changed.
3061
3f754b86
PE
30622011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3063
cca69397
PE
3064 * buffer.h: Include <time.h>, for time_t.
3065 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3066
109e28d0
PE
3067 Fix minor problems found by static checking.
3068
60737f02
PE
3069 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3070
4b66faf3
PE
3071 Make identifiers static if they are not used in other modules.
3072 * data.c (Qcompiled_function, Qframe, Qvector):
3073 * image.c (QimageMagick, Qsvg):
3074 * minibuf.c (Qmetadata):
3075 * window.c (resize_window_check, resize_root_window): Now static.
3076 * window.h (resize_window_check, resize_root_window): Remove decls.
3077
109e28d0
PE
3078 * window.c (window_deletion_count, delete_deletable_window):
3079 Remove; unused.
46a4ce9e
PE
3080 (window_body_lines): Now static.
3081 (Fdelete_other_windows_internal): Mark vars as initialized.
3082 Make sure 'resize_failed' is initialized.
3083 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3084 (resize_window_apply): Remove unused local.
3085 * window.h (delete_deletable_window): Remove decl.
3086
109e28d0 3087 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3088 (imagemagick_load_image): Fix pointer signedness problem by changing
3089 last arg from unsigned char * to char *. All uses changed.
3090 Also, fix a local for similar reasons.
3091 Remove unused locals. Remove locals to avoid shadowing.
3092 (fn_rsvg_handle_free): Remove; unused.
3093 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3094 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3095
3f754b86
PE
3096 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3097
2547adb1
CY
30982011-06-10 Chong Yidong <cyd@stupidchicken.com>
3099
3100 * image.c (gif_load): Fix omitted cast error introduced by
3101 2011-06-06 change.
3102
2c8e37d4
MR
31032011-06-10 Martin Rudalics <rudalics@gmx.at>
3104
3105 * window.h (resize_proportionally, orig_total_lines)
3106 (orig_top_line): Remove from window structure.
3107 (set_window_height, set_window_width, change_window_heights)
3108 (Fdelete_window): Remove prototypes.
3109 (resize_frame_windows): Remove duplicate declaration.
3110
440a42e3
EZ
31112011-06-10 Eli Zaretskii <eliz@gnu.org>
3112
3113 * window.h (resize_frame_windows, resize_window_check)
3114 (delete_deletable_window, resize_root_window)
3115 (resize_frame_windows): Declare prototypes.
3116
3117 * window.c (resize_window_apply): Make definition be "static" to
3118 match the prototype.
3119
562dd5e9
MR
31202011-06-10 Martin Rudalics <rudalics@gmx.at>
3121
3122 * window.c: Remove declarations of Qwindow_size_fixed,
3123 window_min_size_1, window_min_size_2, window_min_size,
3124 size_window, window_fixed_size_p, enlarge_window, delete_window.
3125 Remove static from declaration of Qdelete_window, it's
3126 temporarily needed by Fbury_buffer.
3127 (replace_window): Don't assign orig_top_line and
3128 orig_total_lines.
3129 (Fdelete_window, delete_window): Remove. Window deletion is
3130 handled by window.el.
640c8776
SM
3131 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3132 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3133 (Fdelete_other_windows): Remove. Deleting other windows is
3134 handled by window.el.
3135 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3136 handled in window.el.
3137 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3138 Window minimum sizes are handled in window.el.
3139 (shrink_windows, size_window, set_window_height)
3140 (set_window_width, change_window_heights, window_height)
3141 (window_width, CURBEG, CURSIZE, enlarge_window)
3142 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3143 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3144 handled in window.el.
3145 (make_dummy_parent): Rename to make_parent_window and give it a
3146 second argument horflag.
3147 (make_window): Don't set resize_proportionally any more.
3148 (Fsplit_window): Remove. Windows are split in window.el.
3149 (save_restore_action, save_restore_orig_size)
3150 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3151 Resize mini windows in window.el.
3152 (grow_mini_window, shrink_mini_window): Implement by calling
3153 Qresize_root_window_vertically, resize_window_check and
3154 resize_window_apply.
640c8776
SM
3155 (saved_window, Fset_window_configuration, save_window_save):
3156 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3157 resize_proportionally.
3158 (window_min_height, window_min_width): Move to window.el.
3159 (keys_of_window): Move bindings for delete-other-windows,
3160 split-window, delete-window and enlarge-window to window.el.
3161
3162 * buffer.c: Temporarily extern Qdelete_window.
3163 (Fbury_buffer): Temporarily call Qdelete_window instead of
3164 Fdelete_window (Fbury_buffer will move to window.el soon).
3165
3166 * frame.c (set_menu_bar_lines_1): Remove code handling
3167 orig_top_line and orig_total_lines.
3168
3169 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3170 set_window_height but set heights directly.
3171 (change_frame_size_1): Use resize_frame_windows.
3172
3173 * xdisp.c (init_xdisp): Don't use set_window_height but set
3174 heights directly.
3175
640c8776
SM
3176 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3177 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3178 run_window_configuration_change_hook.
3179
3180 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3181 instead of change_window_heights and run
3182 run_window_configuration_change_hook.
3183
1a13852e
MR
31842011-06-09 Martin Rudalics <rudalics@gmx.at>
3185
3186 * window.c (replace_window): Rename second argument REPLACEMENT to
3187 NEW. New third argument SETFLAG. Rewrite.
3188 (delete_window, make_dummy_parent): Call replace_window with
3189 third argument 1.
3190 (window_list_1): Move down in code.
3191 (run_window_configuration_change_hook): Move set_buffer part
3192 before select_frame_norecord part in order to unwind correctly.
3193 Rename count1 to count.
3194 (recombine_windows, delete_deletable_window, resize_root_window)
3195 (Fdelete_other_windows_internal)
3196 (Frun_window_configuration_change_hook, make_parent_window)
3197 (resize_window_check, resize_window_apply, Fresize_window_apply)
3198 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3199 (Fdelete_window_internal, Fresize_mini_window_internal):
3200 New functions.
1a13852e
MR
3201 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3202
f3d1777e
MR
32032011-06-08 Martin Rudalics <rudalics@gmx.at>
3204
496e208e
MR
3205 * window.h (window): Add some new members to window structure -
3206 normal_lines, normal_cols, new_total, new_normal, clone_number,
3207 splits, nest, prev_buffers, next_buffers.
3208 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3209 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3210
f3d1777e
MR
3211 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3212 Remove.
496e208e
MR
3213 (make_dummy_parent): Set new members of windows structure.
3214 (make_window): Move down in code. Handle new members of window
3215 structure.
3216 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3217 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3218 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3219 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3220 (Fset_window_next_buffers, Fset_window_clone_number):
3221 New functions.
496e208e
MR
3222 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3223 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3224 Doc-string fixes.
3225 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3226 Argument WINDOW can be now internal window too.
3227 (Fwindow_use_time): Move up in code.
3228 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3229 Rewrite doc-string.
3230 (Fset_window_configuration, saved_window)
3231 (Fcurrent_window_configuration, save_window_save): Handle new
3232 members of window structure.
b9e809c2
MR
3233 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3234 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3235 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3236 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3237 Qget_mru_window, Qresize_root_window,
3238 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3239 Qauto_buffer_name; staticpro them.
f3d1777e 3240
abde8f8c
MR
32412011-06-07 Martin Rudalics <rudalics@gmx.at>
3242
3243 * window.c (Fwindow_total_size, Fwindow_left_column)
3244 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3245 (Fwindow_list_1): New functions.
3246 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3247 (Fwindow_width, Fscroll_left, Fscroll_right):
3248 Use window_body_cols instead of window_box_text_cols.
3249 (delete_window, Fset_window_configuration):
3250 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3251 (delete_all_subwindows): Take a window as argument and not a
3252 structure. Rewrite.
190b47e6
MR
3253 (window_loop): Remove handling of GET_LRU_WINDOW and
3254 GET_LARGEST_WINDOW.
3255 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3256
3257 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3258 window_box_text_cols. delete_all_subwindows now takes a
3259 Lisp_Object as argument.
abde8f8c 3260
640c8776
SM
3261 * indent.c (compute_motion, Fcompute_motion):
3262 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3263
fa8a67e6
MR
3264 * frame.c (delete_frame): Call delete_all_subwindows with root
3265 window as argument.
3266
a54e3482
DC
32672011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3268
3269 * fns.c (Fputhash): Document return value.
3270
60002bf5
CY
32712011-06-06 Chong Yidong <cyd@stupidchicken.com>
3272
3273 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3274
0c671da6 32752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3276
b862a52a 3277 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3278
be44ca6c
PE
3279 Check for overflow when converting integer to cons and back.
3280 * charset.c (Fdefine_charset_internal, Fdecode_char):
3281 Use cons_to_unsigned to catch overflow.
3282 (Fencode_char): Use INTEGER_TO_CONS.
3283 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3284 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3285 * data.c (long_to_cons, cons_to_long): Remove.
3286 (cons_to_unsigned, cons_to_signed): New functions.
3287 These signal an error for invalid or out-of-range values.
3288 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3289 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3290 * font.c (Ffont_variation_glyphs):
3291 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3292 * lisp.h: Include <intprops.h>.
3293 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3294 (cons_to_signed, cons_to_unsigned): New decls.
3295 (long_to_cons, cons_to_long): Remove decls.
3296 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3297 (Fprimitive_undo): Use CONS_TO_INTEGER.
3298 * xfns.c (Fx_window_property): Likewise.
3299 * xselect.c: Include <limits.h>.
3300 (x_own_selection, selection_data_to_lisp_data):
3301 Use INTEGER_TO_CONS.
3302 (x_handle_selection_request, x_handle_selection_clear)
3303 (x_get_foreign_selection, Fx_disown_selection_internal)
3304 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3305 (lisp_data_to_selection_data): Use cons_to_unsigned.
3306 (x_fill_property_data): Use cons_to_signed.
3307 Report values out of range.
3308
d1f3d2af
PE
3309 Check for buffer and string overflow more precisely.
3310 * buffer.h (BUF_BYTES_MAX): New macro.
3311 * lisp.h (STRING_BYTES_MAX): New macro.
3312 * alloc.c (Fmake_string):
3313 * character.c (string_escape_byte8):
3314 * coding.c (coding_alloc_by_realloc):
3315 * doprnt.c (doprnt):
3316 * editfns.c (Fformat):
3317 * eval.c (verror):
3318 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3319 since they may not be the same number.
3320 * editfns.c (Finsert_char):
3321 * fileio.c (Finsert_file_contents):
3322 Likewise for BUF_BYTES_MAX.
3323
dd52fcea
PE
3324 * image.c: Use ptrdiff_t, not int, for sizes.
3325 (slurp_file): Switch from int to ptrdiff_t.
3326 All uses changed.
3327 (slurp_file): Check that file size fits in both size_t (for
3328 malloc) and ptrdiff_t (for sanity and safety).
3329
7f9bbdbb
PE
3330 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3331 if b->modtime has its maximal value.
3332
dfe18f82
PE
3333 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3334
84acfcf0
PE
3335 Don't assume time_t can fit into int.
3336 * buffer.h (struct buffer.modtime): Now time_t, not int.
3337 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3338 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3339
ccd9a01a
PE
3340 Minor fixes for signed vs unsigned integers.
3341 * character.h (MAYBE_UNIFY_CHAR):
3342 * charset.c (maybe_unify_char):
3343 * keyboard.c (read_char, reorder_modifiers):
3344 XINT -> XFASTINT, since the integer must be nonnegative.
3345 * ftfont.c (ftfont_spec_pattern):
3346 * keymap.c (access_keymap, silly_event_symbol_error):
3347 XUINT -> XFASTINT, since the integer must be nonnegative.
3348 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3349 since it makes no difference and we prefer signed.
3350 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3351 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3352 nonnegative.
3353
d6d100dd
SM
33542011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3355
3356 * window.h (Fwindow_frame): Declare.
3357
2b6148e4
PE
33582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3359
3360 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3361 (SPARE_MEMORY): Always define.
3362 (LARGE_REQUEST): Remove.
3363 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3364
f230ecc9
MR
33652011-06-06 Martin Rudalics <rudalics@gmx.at>
3366
727e958e
MR
3367 * lisp.h: Move EXFUNS for Fframe_root_window,
3368 Fframe_first_window and Fset_frame_selected_window to window.h.
3369
3370 * window.h: Move EXFUNS for Fframe_root_window,
3371 Fframe_first_window and Fset_frame_selected_window here from
3372 lisp.h.
3373
3374 * frame.c (Fwindow_frame, Fframe_first_window)
3375 (Fframe_root_window, Fframe_selected_window)
3376 (Fset_frame_selected_window): Move to window.c.
3377 (Factive_minibuffer_window): Move to minibuf.c.
3378 (Fother_visible_frames_p): New function.
3379
3380 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3381
f230ecc9
MR
3382 * window.c (decode_window, decode_any_window): Move up in code.
3383 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3384 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3385 (Fwindow_buffer): Move up and rewrite doc-string.
3386 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3387 (Fwindow_prev): New functions.
727e958e
MR
3388 (Fwindow_frame): Move here from frame.c. Accept any window as
3389 argument.
3390 (Fframe_root_window, Fframe_first_window)
3391 (Fframe_selected_window): Move here from frame.c. Accept frame
3392 or arbitrary window as argument. Update doc-strings.
3393 (Fminibuffer_window): Move up in code.
3394 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3395 (Fset_frame_selected_window): Move here from frame.c.
3396 Marginal rewrite.
727e958e
MR
3397 (Fselected_window, select_window, Fselect_window): Move up in
3398 code. Minor doc-string fixes.
f230ecc9 3399
4d09bcf6
PE
34002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3401
3402 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3403 Do not assume that spare memory exists; that assumption is valid
3404 only if SYSTEM_MALLOC.
3405 (LARGE_REQUEST): New macro, so that the issue of large requests
3406 is separated from the issue of spare memory.
3407
810928a2
AS
34082011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3409
172418ad
AS
3410 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3411 format. (Bug#8806)
3412
43f862f7
AS
3413 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3414
810928a2
AS
3415 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3416 before statements.
3417
a059fe24
JD
34182011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3419
3420 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3421
3422 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3423
3424 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3425 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3426
989bf368
JB
34272011-06-05 Juanma Barranquero <lekktu@gmail.com>
3428
3429 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3430
4b80f674
CY
34312011-06-04 Chong Yidong <cyd@stupidchicken.com>
3432
3433 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3434 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3435 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3436 New error handlers.
4b80f674
CY
3437 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3438 Obey Vx_select_enable_clipboard_manager. Catch errors in
3439 x_clipboard_manager_save (Bug#8779).
3440 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3441 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3442
99a33b77 34432011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3444
3445 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3446
99a33b77 34472011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3448
3449 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3450 in the current matrix if keep_current_p is non-zero.
3451
8264569d
EZ
34522011-06-04 Eli Zaretskii <eliz@gnu.org>
3453
3454 * bidi.c (bidi_level_of_next_char): Fix last change.
3455
57f97249
EZ
34562011-06-03 Eli Zaretskii <eliz@gnu.org>
3457
fec2107c 3458 Support bidi reordering of text covered by display properties.
57f97249 3459
fec2107c
EZ
3460 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3461 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3462 (bidi_cache_search, bidi_cache_iterator_state)
3463 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3464 (bidi_level_of_next_char, bidi_move_to_visually_next):
3465 Support character positions inside a run of characters covered by a
fec2107c
EZ
3466 display string.
3467 (bidi_paragraph_init, bidi_resolve_explicit_1)
3468 (bidi_level_of_next_char): Call bidi_fetch_char and
3469 bidi_fetch_char_advance instead of FETCH_CHAR and
3470 FETCH_CHAR_ADVANCE.
3471 (bidi_init_it): Initialize new members.
3472 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3473 definitions.
3474 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3475 instead of using explicit *_CHAR codes.
d6d100dd
SM
3476 (bidi_resolve_explicit, bidi_resolve_weak):
3477 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3478 bidirectional text is supported only in multibyte buffers.
3479 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3480 it to initialize the frame_window_p member of struct bidi_it.
3481 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3482 (bidi_resolve_explicit, bidi_resolve_weak)
3483 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3484 bidi_it->nchars is non-positive.
3485 (bidi_level_of_next_char): Don't try to lookup the cache for the
3486 next/previous character if nothing is cached there yet, or if we
3487 were just reseat()'ed to a new position.
c40e2fb2 3488
0e14fe90
EZ
3489 * xdisp.c (set_cursor_from_row): Set start and stop points
3490 according to the row's direction when priming the loop that looks
3491 for the glyph on which to display cursor.
3492 (single_display_spec_intangible_p): Function deleted.
3493 (display_prop_intangible_p): Reimplement to call
3494 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3495 Accept 3 additional arguments needed by handle_display_spec.
3496 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3497 values: lists, `(when COND...)' forms, etc.
3498 (single_display_spec_string_p): Support property values that are
3499 lists with the argument STRING its top-level element.
3500 (display_prop_string_p): Fix the condition for processing a
3501 property that is a list to be consistent with handle_display_spec.
fec2107c 3502 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3503 last portion of handle_display_prop.
3504 (compute_display_string_pos): Accept additional argument
3505 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3506 value of a `display' property is a "replacing spec".
3507 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3508 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3509 the display property, but just return a value indicating whether
3510 the display property will replace the characters it covers.
3511 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3512 frame_window_p members of struct bidi_it.
d6d100dd
SM
3513 (compute_display_string_pos, compute_display_string_end):
3514 New functions.
fec2107c
EZ
3515 (push_it): Accept second argument POSITION, where pop_it should
3516 jump to continue iteration.
3517 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3518
fec2107c
EZ
3519 * keyboard.c (adjust_point_for_property): Adjust the call to
3520 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3521
3522 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3523 (bidi_init_it): Update prototypes.
3524 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3525 (compute_display_string_pos, compute_display_string_end):
3526 Declare prototypes.
fec2107c
EZ
3527 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3528 EMACS_INT.
fc6f18ce 3529
40087514 35302011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3531
57f53182
PE
3532 Malloc failure behavior now depends on size of allocation.
3533 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3534 * lisp.h: Change signatures accordingly.
3535 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3536 All callers changed. (Bug#8762)
3537
3538 * gnutls.c: Use Emacs's memory allocators.
3539 Without this change, the gnutls library would invoke malloc etc.
3540 directly, which causes problems on non-SYNC_INPUT hosts, and which
3541 runs afoul of improving memory_full behavior. (Bug#8761)
3542 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3543 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3544 xfree instead of the default malloc, realloc, free.
3545 (Fgnutls_boot): No need to check for memory allocation failure,
3546 since xmalloc does that for us.
3547
ac32cd99 3548 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3549 * category.c (hash_get_category_set):
3550 * ccl.c (ccl_driver):
3551 * charset.c (Fdefine_charset_internal):
3552 * charset.h (struct charset.hash_index):
3553 * composite.c (get_composition_id, gstring_lookup_cache)
3554 (composition_gstring_put_cache):
3555 * composite.h (struct composition.hash_index):
3556 * dispextern.h (struct image.hash):
3557 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3558 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3559 (hashfn_equal, hashfn_user_defined, make_hash_table)
3560 (maybe_resize_hash_table, hash_lookup, hash_put)
3561 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3562 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3563 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3564 * image.c (make_image, search_image_cache, lookup_image)
3565 (xpm_put_color_table_h):
3566 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3567 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3568 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3569 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3570 * alloc.c (allocate_vectorlike):
3571 Check for overflow in vector size calculations.
3572 * ccl.c (ccl_driver):
3573 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3574 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3575 need to be updated by these changes.
40087514
PE
3576 * fns.c (make_hash_table, maybe_resize_hash_table):
3577 Check for integer overflow with large hash tables.
0de4bb68
PE
3578 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3579 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3580 (SXHASH_REDUCE): New macro.
3581 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3582 Use it instead of discarding useful hash info with large hash values.
3583 (sxhash_float): New function.
3584 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3585 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3586 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3587 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3588 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3589 Adjust signatures to match updated version of code.
3590 (consing_since_gc): Now EMACS_INT, since a single hash table can
3591 use more than INT_MAX bytes.
3592
698d32e2
DN
35932011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3594
3595 Make it possible to build with GCC-4.6+ -O2 -flto.
3596
3597 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3598
fd6fa53f
SM
35992011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3600
3601 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3602 Call minibuffer-inactive-mode.
3603
864db017
JB
36042011-05-31 Juanma Barranquero <lekktu@gmail.com>
3605
3606 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3607 Update dependencies.
3608
2ad0baf4
DN
36092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3610
3611 * data.c (init_data): Remove code for UTS, this system is not
3612 supported anymore.
3613
4fcc2638
DN
36142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3615
3616 Don't force ./temacs to start in terminal mode.
3617
3618 * frame.c (make_initial_frame): Initialize faces in all cases, not
3619 only when CANNOT_DUMP is defined.
3620 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3621
c56e0fd5
DN
36222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3623
3624 * dispnew.c (add_window_display_history): Use const for the string
3625 pointer. Remove declaration, not needed.
3626
333d54da 36272011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3628
55d4c1b2 3629 Use 'inline', not 'INLINE'.
333d54da 3630 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3631 * alloc.c, fontset.c (INLINE): Remove.
3632 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3633 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3634 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3635 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3636 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3637
738db178
DN
36382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3639
3640 Make it possible to run ./temacs.
3641
3642 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3643 syms_of_callproc does the same thing. Remove test for
3644 "initialized", do it in the caller.
3645 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3646
620c53a6
SM
36472011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3648
3649 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3650 (read_minibuf): Use get_minibuffer.
3651 (syms_of_minibuf): Use DEFSYM.
3652 (Qmetadata): New var.
3653 * data.c (Qbuffer): Don't make it static.
3654 (syms_of_data): Use DEFSYM.
3655
e003a292
PE
36562011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3659 (CCL_CODE_MIN): New macro.
3660
ed008a6d
PE
36612011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3662
3687c2ef
PE
3663 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3664
ed008a6d
PE
3665 * eval.c (Qdebug): Now static.
3666 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3667 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3668 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3669
d66c4c7c
CY
36702011-05-29 Chong Yidong <cyd@stupidchicken.com>
3671
3672 * image.c: Various fixes to ImageMagick code comments.
3673 (Fimagemagick_types): Doc fix.
3674
5fbc2025
PE
36752011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3676
0196f88a
PE
3677 Minor fixes prompted by GCC 4.6.0 warnings.
3678
3679 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3680
5fbc2025
PE
3681 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3682 (x_clipboard_manager_save_all): Move extern decl to ...
3683 * xterm.h: ... here, so that it can be checked for consistency.
3684
1dd3c2d9
CY
36852011-05-29 Chong Yidong <cyd@stupidchicken.com>
3686
3687 * xselect.c (x_clipboard_manager_save_frame)
3688 (x_clipboard_manager_save_all): New functions.
3689 (Fx_clipboard_manager_save): Lisp function deleted.
3690
3691 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3692 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3693
3694 * xterm.h: Update prototype.
3695
5ba6571d
WX
36962011-05-28 William Xu <william.xwl@gmail.com>
3697
3698 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3699 exiting (Bug#8239).
3700
3eaff834
JM
37012011-05-28 Jim Meyering <meyering@redhat.com>
3702
e1900994 3703 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3704 * fns.c (to_uchar): Define.
3705 (crypto_hash_function): Use it to convert some newly-signed
3706 variables to unsigned, to avoid sign-extension bugs. For example,
3707 without this change, (md5 "truc") would evaluate to
3708 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3709 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3710 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3711
0f6990a7
PE
37122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3713
3714 Integer overflow fixes.
c8a9ca5a 3715
08686060
PE
3716 * dbusbind.c: Serial number integer overflow fixes.
3717 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3718 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3719 to hold a serial number that is too large for a fixnum.
3720 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3721 Check for serial numbers out of range. Decode any serial number
59568bf0 3722 that was so large that it became a float. (Bug#8722)
08686060 3723
2d1fc3c7
PE
3724 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3725 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3726 Use XFASTINT rather than XUINT when numbers are nonnegative.
3727 (xd_append_arg, Fdbus_method_return_internal):
3728 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3729 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3730 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3731 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3732 (Bug#8722)
2d1fc3c7 3733
c8a9ca5a
PE
3734 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3735
519e1d69
PE
3736 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3737
30569699
PE
3738 ccl: add integer overflow checks
3739 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3740 (IN_INT_RANGE): New macros.
3741 (ccl_driver): Use them to check for integer overflow when
3742 decoding a CCL program. Many of the new checks are whether XINT (x)
3743 fits in int; it doesn't always, on 64-bit hosts. The new version
3744 doesn't catch all possible integer overflows, but it's an
847044ea 3745 improvement. (Bug#8719)
30569699 3746
c11285dc
PE
3747 * alloc.c (make_event_array): Use XINT, not XUINT.
3748 There's no need for unsigned here.
3749
fdccd48e
PE
3750 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3751 This follows up to the 2011-05-06 change that substituted uintptr_t
3752 for EMACS_INT. This case wasn't caught back then.
3753
37910ab2
PE
3754 Rework Fformat to avoid integer overflow issues.
3755 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3756 now (part of C89). Include <verify.h>.
3757 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3758 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3759 (Fformat): Avoid the prepass trying to compute sizes; it was only
3760 approximate and thus did not catch overflow reliably. Instead, walk
3761 through the format just once, formatting and computing sizes as we go,
3762 checking for integer overflow at every step, and allocating a larger
3763 buffer as needed. Keep track separately whether the format is
3764 multibyte. Keep only the most-recently calculated precision, rather
3765 than them all. Record whether each argument has been converted to
3766 string. Use EMACS_INT, not int, for byte and char and arg counts.
3767 Support field widths and precisions larger than INT_MAX. Avoid
3768 sprintf's undefined behavior with conversion specifications such as %#d
3769 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3770 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3771 formatting out-of-range floating point numbers with int
9173deec 3772 formats. (Bug#8668)
37910ab2 3773
2e6578fb
PE
3774 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3775
0ae6bdee
PE
3776 * data.c: Avoid integer truncation in expressions involving floats.
3777 * data.c: Include <intprops.h>.
3778 (arith_driver): When there's an integer overflow in an expression
3779 involving floating point, convert the integers to floating point
3780 so that the resulting value does not suffer from catastrophic
3781 integer truncation. For example, on a 64-bit host (* 4
3782 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3783 Do not rely on undefined behavior after integer overflow.
3784
de883a70
PE
3785 merge count_size_as_multibyte, parse_str_to_multibyte
3786 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3787 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3788 Check for integer overflow.
3789 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3790 since it's now a duplicate of the other. This is more of
3791 a character than a buffer op, so better that it's in character.c.
3792 * fns.c, print.c: Adjust to above changes.
3793
2ff916cb
PE
37942011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3795
3796 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3797
f1b54466
PE
37982011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3799
fb1ac845
PE
3800 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3801 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3802 (x_clipboard_manager_save): Now static.
3803 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3804
f1b54466
PE
3805 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3806 (crypto_hash_function): Now static.
3807 Fix pointer signedness problems. Avoid unnecessary initializations.
3808
a9f737ee
CY
38092011-05-27 Chong Yidong <cyd@stupidchicken.com>
3810
3811 * termhooks.h (Vselection_alist): Make it terminal-local.
3812
3813 * terminal.c (create_terminal): Initialize it.
3814
3815 * xselect.c: Support for clipboard managers.
3816 (Vselection_alist): Move to termhooks.h as terminal-local var.
3817 (LOCAL_SELECTION): New macro.
3818 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3819 (symbol_to_x_atom): Remove gratuitous arg.
3820 (x_handle_selection_request, lisp_data_to_selection_data)
3821 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3822 (x_own_selection, x_get_local_selection, x_convert_selection):
3823 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3824 (some_frame_on_display): Delete unused function.
3825 (Fx_own_selection_internal, Fx_get_selection_internal)
3826 (Fx_disown_selection_internal, Fx_selection_owner_p)
3827 (Fx_selection_exists_p): New optional frame arg.
3828 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3829 (x_handle_selection_clear): Don't treat other terminals with the
3830 same keyboard specially. Use the terminal-local Vselection_alist.
3831 (x_clear_frame_selections): Use Frun_hook_with_args.
3832
3833 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3834
3835 * xterm.h: Add support for those atoms.
3836
e067f0c1
CY
38372011-05-26 Chong Yidong <cyd@stupidchicken.com>
3838
3839 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3840 (converted_selections, conversion_fail_tag): New global variables.
3841 (x_selection_request_lisp_error): Free the above.
3842 (x_get_local_selection): Remove unnecessary code.
3843 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3844 of converted selections stored in converted_selections.
3845 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3846 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3847 (x_convert_selection): New function.
3848 (x_handle_selection_event): Simplify.
3849 (x_get_foreign_selection): Don't ignore incoming requests while
3850 waiting for an answer; this will fail when we implement
3851 SAVE_TARGETS, and seems unnecessary anyway.
3852 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3853 (Vx_sent_selection_functions): Doc fix.
3854
0f4aebc0
LL
38552011-05-26 Leo Liu <sdl.web@gmail.com>
3856
3857 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3858
e61124cd
YM
38592011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3860
3861 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3862
3863 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3864 for fringe update if it has periodic bitmap.
ac389d0c 3865 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3866 and fringe_bitmap_periodic_p.
3867
3868 * fringe.c (get_fringe_bitmap_data): New function.
3869 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3870 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3871 row. Mark glyph row for fringe update if periodicity changed.
3872
3873 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3874 for fringe update unless it has periodic bitmap.
3875
f16d9837
KH
38762011-05-25 Kenichi Handa <handa@m17n.org>
3877
3878 * xdisp.c (get_next_display_element): Set correct it->face_id for
3879 a static composition.
3880
e1b90ef6
LL
38812011-05-24 Leo Liu <sdl.web@gmail.com>
3882
3883 * deps.mk (fns.o):
3884 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3885
3886 * fns.c (crypto_hash_function, Fsha1): New function.
3887 (Fmd5): Use crypto_hash_function.
3888 (syms_of_fns): Add Ssha1.
3889
7400048f
PE
38902011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 * gnutls.c: Remove unused macros.
3893 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3894 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3895 Remove macros that are defined and never used.
3896 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3897
abb71cf4
CY
38982011-05-22 Chong Yidong <cyd@stupidchicken.com>
3899
3900 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3901 (Fx_get_selection_internal): Minor cleanup.
3902 (Fx_own_selection_internal): Rename arguments for consistency with
3903 select.el.
3904
6307db39
PE
39052011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3906
3907 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3908
f3d4e0a4
CY
39092011-05-22 Chong Yidong <cyd@stupidchicken.com>
3910
3911 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3912
4d8ade89
YM
39132011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3914
3915 * dispnew.c (scrolling_window): Don't exclude the case that the
3916 last enabled row in the desired matrix touches the bottom boundary.
3917
32078c8d
GM
39182011-05-21 Glenn Morris <rgm@gnu.org>
3919
3920 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3921 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3922 and add some more files.
32078c8d 3923
7285dc67
EZ
39242011-05-20 Eli Zaretskii <eliz@gnu.org>
3925
3926 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3927 report_file_error introduced by the change from 2011-05-07.
3928
89d1bd22
PE
39292011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * systime.h (Time): Define only if emacs is defined.
3932 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3933 where the include path doesn't have X11/X.h by default. See
3934 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3935
e23640bb 39362011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3937
3938 * composite.c (find_automatic_composition): Fix previous change.
3939
b9704ad9
GM
39402011-05-20 Glenn Morris <rgm@gnu.org>
3941
3942 * lisp.mk: New file, split from Makefile.in.
3943 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3944 (shortlisp): Remove.
3945 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3946
4a720484
GM
39472011-05-19 Glenn Morris <rgm@gnu.org>
3948
3949 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3950 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3951 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3952 (lisp): Set the order to that of loadup.el.
3953 (shortlisp): Make it a copy of $lisp.
3954 (SOME_MACHINE_LISP): Remove.
3955 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3956 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3957
a28d4396
KH
39582011-05-18 Kenichi Handa <handa@m17n.org>
3959
3960 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3961 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3962 (find_automatic_composition): Mostly rewrite for efficiency.
3963
a2b1fa8e
JB
39642011-05-18 Juanma Barranquero <lekktu@gmail.com>
3965
3966 * makefile.w32-in: Update dependencies.
3967
8e1f5610
CS
39682011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3969
3970 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3971 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3972
7025ee00 39732011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3974
cdfa6eab
PE
3975 Fix some integer overflow issues, such as string length overflow.
3976
06d6db33
PE
3977 * insdel.c (count_size_as_multibyte): Check for string overflow.
3978
2b4560a8
PE
3979 * character.c (lisp_string_width): Check for string overflow.
3980 Use EMACS_INT, not int, for string indexes and lengths; in
3981 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3982 the resulting string length overflows an EMACS_INT; instead,
3983 report a string overflow if no precision given. When checking for
3984 precision exhaustion, use a check that cannot possibly have
3985 integer overflow. (Bug#8675)
3986 * character.h (lisp_string_width): Adjust to new signature.
3987
cb93f9be
PE
3988 * alloc.c (string_overflow): New function.
3989 (Fmake_string): Use it. This doesn't change behavior, but saves
3990 a few bytes and will simplify future changes.
3991 * character.c (string_escape_byte8): Likewise.
3992 * lisp.h (string_overflow): New decl.
3993
1a1f3366
PE
3994 Fixups, following up to the user-interface timestamp change.
3995 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3996 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3997 * msdos.c (mouse_get_pos): Likewise.
3998 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3999 * w32gui.h (Time): Define by including "systime.h" rather than by
4000 declaring it ourselves. (Bug#8664)
4001
d4e3e4d3
PE
4002 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4003 * image.c (clear_image_cache): Likewise.
4004
f6a24d19
PE
4005 * term.c (term_mouse_position): Don't assume time_t wraparound.
4006
08dc5ae6
PE
4007 Be more systematic about user-interface timestamps.
4008 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4009 and sometimes 'EMACS_UINT', to represent these timestamps.
4010 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4011 This makes the code easier to follow, and makes it easier to catch
4012 integer overflow bugs such as Bug#8664.
4013 * frame.c (Fmouse_position, Fmouse_pixel_position):
4014 Use Time, not unsigned long, for user-interface timestamps.
4015 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4016 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4017 * keyboard.h (last_event_timestamp): Likewise.
4018 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4019 * menu.h (xmenu_show): Likewise.
4020 * term.c (term_mouse_position): Likewise.
4021 * termhooks.h (struct input_event.timestamp): Likewise.
4022 (struct terminal.mouse_position_hook): Likewise.
4023 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4024 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4025 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4026 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4027 what it was before.
4028 * menu.h, termhooks.h: Include "systime.h", for Time.
4029
8e55734a
PE
4030 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4031 Don't assume that the difference between two unsigned long values
4032 can fit into an integer. At this point, we know button_down_time
4033 <= event->timestamp, so the difference must be nonnegative, so
4034 there's no need to cast the result if double-click-time is
4035 nonnegative, as it should be; check that it's nonnegative, just in
4036 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4037 apart (about 25 days). (Bug#8664)
8e55734a 4038
841f1b75 4039 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4040 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4041
3e26f69c
PE
4042 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4043 that always fit in int. Use a sentinel instead of a counter, to
4044 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4045 * frame.h (struct frame): Use int for menu_bar_items_used
4046 instead of EMACS_INT, since it always fits in int.
3e26f69c 4047
5cc152c0
PE
4048 * menu.c (grow_menu_items): Check for int overflow.
4049
d89eb65e
PE
4050 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4051
5235bd3e
PE
4052 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4053 Before, the code was not consistent. These values cannot exceed
4054 2**31 - 1 so there's no need to make them unsigned.
4055 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4056 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4057 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4058 as modifiers.
4059 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4060
bc827e23
PE
4061 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4062 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4063 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4064 presumably because the widths might not match.
4065
78eb494e
PE
4066 * window.c (size_window): Avoid needless test at loop start.
4067
04f2d78b
CB
40682011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4069
4070 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4071
d2fc7e3d 40722011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4073
4074 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4075
d2fc7e3d 40762011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4077
4078 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4079 `width' to `bar_area_x' and `bar_area_width', respectively.
4080 (x_scroll_run): Take account of fringe background extension.
4081
04f2d78b
CB
4082 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4083 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4084 `bar_area_width', respectively.
4085 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4086 background extension.
4087
79b70037
GM
40882011-05-10 Jim Meyering <meyering@redhat.com>
4089
4090 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4091
2f142cc5
JB
40922011-05-10 Juanma Barranquero <lekktu@gmail.com>
4093
4094 * image.c (Finit_image_library): Return t for built-in image types,
4095 like pbm and xbm. (Bug#8640)
4096
57679c86
AS
40972011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4098
4099 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4100
888c9e86
EZ
41012011-05-07 Eli Zaretskii <eliz@gnu.org>
4102
b0512a1d
EZ
4103 * w32console.c (Fset_screen_color): Doc fix.
4104 (Fget_screen_color): New function.
4105 (syms_of_ntterm): Defsubr it.
4106
7285dc67
EZ
4107 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4108 unlink the temporary file if Fcall_process didn't create it in the
4109 first place.
4110 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4111 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4112 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4113 cue to call_process_cleanup not to close that handle.
4114
4d3fcc8e
BK
41152011-05-07 Ben Key <bkey76@gmail.com>
4116
4117 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4118 one of two shell specific rules, either bootstrap-temacs-CMD or
4119 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4120 to the previous implementation of the bootstrap-temacs rule.
4121 The bootstrap-temacs-CMD rule is similar to the previous
4122 implementation of the bootstrap-temacs rule except that it
4123 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4124 variable.
4125
4126 These changes, along with some changes to nt/configure.bat,
4127 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4128 earlier fix to add support for --cflags and --ldflags options
4129 that include quotes so that it works whether make uses cmd or
4130 sh as the shell.
4131
b4289b64
MA
41322011-05-06 Michael Albinus <michael.albinus@gmx.de>
4133
4134 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4135 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4136 is a constant.
4137 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4138 a string. Handle both cases.
4139 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4140 (Fdbus_register_method): Use Qinvalid_function.
4141
af4c0e28
JB
41422011-05-06 Juanma Barranquero <lekktu@gmail.com>
4143
4144 * makefile.w32-in: Update dependencies.
4145 (LISP_H): Add inttypes.h and stdin.h.
4146 (PROCESS_H): Add unistd.h.
4147
c51453d9
EZ
41482011-05-06 Eli Zaretskii <eliz@gnu.org>
4149
4150 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4151 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4152
8ff0ac3c 41532011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4154
4c4b566b
PE
4155 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4156
aab2b9b5
PE
4157 * term.c (vfatal): Remove stray call to va_end.
4158 It's not needed and the C Standard doesn't allow it here anyway.
4159
c378da0b
PE
4160 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4161 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4162
288b08c7
PE
4163 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4164 bytes.
4165
e3601888
PE
4166 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4167
db6c0e74
PE
4168 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4169
dd5963ea
PE
4170 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4171
88c9450f
PE
4172 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4173
2f9442b8
PE
4174 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4175
c032b5f8
PE
4176 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4177 * charset.c (Fdefine_charset_internal): Don't initialize
4178 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4179 32-bit int (Bug#8600).
a108c10b
PE
4180
4181 * lread.c (read_integer): Be more consistent with string-to-number.
4182 Use string_to_number to do the actual conversion; this avoids
4183 rounding errors and fixes some other screwups. Without this fix,
4184 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4185 (digit_to_number): Move earlier, for benefit of read_integer.
4186 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4187 not a digit in any supported base. (Bug#8602)
a108c10b 4188
ad5f9eea
PE
4189 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4190
aec1708a
PE
4191 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4192 to match comment at start of function. This also removes a
4193 GCC warning about overflow in a 32+64-bit port.
4194
47be4ab5
PE
4195 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4196
371cac43
PE
4197 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4198 Reported by Stefan Monnier in
4199 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4200 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4201 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4202
d01a7826
PE
4203 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4204 (EMACS_UINTPTR): Likewise, with uintptr_t.
4205
7fd47d5c
PE
4206 * lisp.h: Prefer 64-bit EMACS_INT if available.
4207 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4208 on 32-bit hosts that have 64-bit int, so that they can access
4209 large files.
122b0c86
PE
4210 However, temporarily disable this change unless the temporary
4211 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4212
8727937b
PE
4213 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4214
8ac068ac
PE
4215 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4216 This removes an assumption that EMACS_INT and long are the same
4217 width as pointers. The assumption is true for Emacs porting targets
4218 now, but we want to make other targets possible.
4219 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4220 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4221 In the rest of the code, change types of integers that hold casted
4222 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4223 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4224 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4225 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4226 No need to cast type when ORing.
4227 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4228 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4229 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4230 assume EMACS_INT is the same width as char *.
4231 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4232 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4233 Remove no-longer-needed casts.
4234 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4235 (xg_tool_bar_help_callback, xg_make_tool_item):
4236 Use EMACS_INTPTR to hold an integer
4237 that will be cast to void *; this can avoid a GCC warning
4238 if EMACS_INT is not the same width as void *.
4239 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4240 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4241 (current_message_1, set_message_1):
4242 Use a local to convert to proper width without a cast.
4243 * xmenu.c (dialog_selection_callback): Likewise.
4244
ede49d71
PE
4245 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4246 Also, don't assume VALBITS / RAND_BITS is less than 5,
4247 and don't rely on undefined behavior when shifting a 1 left into
4248 the sign bit.
4249 * lisp.h (get_random): Change signature to match.
4250
2f30ecd0
PE
4251 * lread.c (hash_string): Use size_t, not int, for hash computation.
4252 Normally we prefer signed values; but hashing is special, because
4253 it's better to use unsigned division on hash table sizes so that
4254 the remainder is nonnegative. Also, size_t is the natural width
4255 for hashing into memory. The previous code used 'int', which doesn't
4256 retain enough info to hash well into very large tables.
4257 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4258
2a866e7b
PE
4259 * dbusbind.c: Don't possibly lose pointer info when converting.
4260 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4261 Use XPNTR rather than XHASH, so that the high-order bits of
4262 the pointer aren't lost when converting through void *.
4263
51639eac
PE
4264 * eval.c (Fautoload): Don't double-shift a pointer.
4265
92394119
PE
4266 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4267
dbdb9a7c
JB
42682011-05-06 Juanma Barranquero <lekktu@gmail.com>
4269
4270 * gnutls.c (DEF_GNUTLS_FN):
4271 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4272
db7a0b4f
AS
42732011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4274
4275 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4276 marker. (Bug#8610)
4277
f7ff1b0f 42782011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4279
4280 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4281 New version that can reserve upto 2GB of heap space.
4282
f7ff1b0f 42832011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4284
4285 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4286
639c109b
TZ
42872011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4288
4289 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4290 `gnutls_certificate_set_x509_key_file'.
4291
d2127135
JB
42922011-05-05 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4295 Update dependencies.
4296
e968f4f3
JB
42972011-05-04 Juanma Barranquero <lekktu@gmail.com>
4298
4299 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4300 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4301 Remove unused parameter `fildes'.
4302 * process.c (read_process_output, send_process): Don't pass it.
4303
84d358f0
JB
43042011-05-04 Juanma Barranquero <lekktu@gmail.com>
4305
4306 Fix previous change: the library cache is defined in w32.c.
4307 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4308 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4309
0898ca10
JB
43102011-05-04 Juanma Barranquero <lekktu@gmail.com>
4311
4312 Implement dynamic loading of GnuTLS on Windows.
4313
4314 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4315 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4316 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4317 Declare.
4318
4319 * gnutls.c (Qgnutls_dll): Define.
4320 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4321 (gnutls_*): Declare function pointers.
4322 (init_gnutls_functions): New function to initialize function pointers.
4323 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4324 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4325 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4326 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4327 (emacs_gnutls_write, emacs_gnutls_read)
4328 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4329 (Fgnutls_available_p): New function.
4330 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4331 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4332 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4333
4334 * image.c: Include w32.h.
4335 (Vimage_type_cache): Delete.
4336 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4337 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4338 (w32_delayed_load): Move to w32.c.
4339
4340 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4341
4342 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4343 (w32_delayed_load): Move from image.c. When loading a library, record
4344 its filename in the :loaded-from property of the library id.
4345 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4346 Initialize and staticpro them.
4347 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4348
4349 * process.c: Include lisp.h before w32.h, not after.
4350 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4351 instead of gnutls_record_check_pending.
4352
4353 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4354
ff4de4aa
TZ
43552011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4356
4357 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4358 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4359 as passed in.
4360
abe95abb
JD
43612011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4362
4363 * xterm.c (x_set_frame_alpha): Do not set property on anything
4364 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4365
e16e55d4
JB
43662011-05-02 Juanma Barranquero <lekktu@gmail.com>
4367
4368 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4369
bafcf6a5
JB
43702011-05-02 Juanma Barranquero <lekktu@gmail.com>
4371
4372 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4373 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4374 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4375 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4376 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4377 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4378 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4379 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4380 (Qgnutls_bootprop_callbacks_verify): Make static.
4381
e7a6747f
AS
43822011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4383
19ed11ba
AS
4384 * callproc.c: Indentation fixup.
4385
e7a6747f 4386 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4387 (wait_for_termination, interruptible_wait_for_termination):
4388 Move after wait_for_termination_1.
e7a6747f 4389
1ef14cb4
LMI
43902011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4391
4392 * sysdep.c (interruptible_wait_for_termination): New function
4393 which is like wait_for_termination, but allows keyboard
4394 interruptions.
4395
4396 * callproc.c (Fcall_process): Add (:file "file") as an option for
4397 the STDOUT buffer.
4398 (Fcall_process_region): Ditto.
4399
330d880c
EZ
44002011-04-30 Eli Zaretskii <eliz@gnu.org>
4401
8db90b73
EZ
4402 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4403 rather than `XVECTOR (FOO)->size'.
4404
330d880c
EZ
4405 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4406 inttypes.h, as a gnulib replacement is used if it not available in
4407 system headers.
4408
15cbd324
EZ
44092011-04-21 Eli Zaretskii <eliz@gnu.org>
4410
4411 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4412 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4413 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4414
4415 * coding.c (coding_alloc_by_realloc): Error out if destination
4416 will grow beyond MOST_POSITIVE_FIXNUM.
4417 (decode_coding_emacs_mule): Abort if there isn't enough place in
4418 charbuf for the composition carryover bytes. Reserve an extra
4419 space for up to 2 characters produced in a loop.
4420 (decode_coding_iso_2022): Abort if there isn't enough place in
4421 charbuf for the composition carryover bytes.
4422
44232011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4424
ae940cca
EZ
4425 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4426 aborting when %lld or %lll format is passed.
4427 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4428 %llo or %llx format is passed. (Bug#8545)
4429
03ab8921
EZ
4430 * window.c (window_scroll_line_based): Use a marker instead of
4431 simple variables to record original value of point. (Bug#7952)
4432
afda1437
EZ
4433 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4434 produced by %s or %c overflows available buffer space. (Bug#8545)
4435
f76dee0c
PE
44362011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4437
4438 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4439 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4440
fdc5744d
JB
44412011-04-28 Juanma Barranquero <lekktu@gmail.com>
4442
4443 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4444
638f053a
JB
44452011-04-28 Juanma Barranquero <lekktu@gmail.com>
4446
4447 * keyboard.c (Qdelayed_warnings_hook): Define.
4448 (command_loop_1): Run `delayed-warnings-hook'
4449 if Vdelayed_warnings_list is non-nil.
4450 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4451 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4452
d178f871
EZ
44532011-04-28 Eli Zaretskii <eliz@gnu.org>
4454
4455 * doprnt.c (doprnt): Don't return value smaller than the buffer
4456 size if the message was truncated. (Bug#8545).
4457
b124fd93
JB
44582011-04-28 Juanma Barranquero <lekktu@gmail.com>
4459
4460 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4461 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4462
e810457d
PE
44632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4466
ea51cceb
JB
44672011-04-27 Juanma Barranquero <lekktu@gmail.com>
4468
4469 * makefile.w32-in: Update dependencies.
4470
94dcfacf
EZ
44712011-04-27 Eli Zaretskii <eliz@gnu.org>
4472
4473 Improve `doprnt' and its usage. (Bug#8545)
4474 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4475 `format_end'. Remove support for %l as a conversion specifier.
4476 Don't use xrealloc. Improve diagnostics when the %l size modifier
4477 is used. Update the commentary.
4478
4479 * eval.c (verror): Simplify calculation of size_t.
4480
4481 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4482 messages.
4483
f61f41d7
PE
44842011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4485
4486 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4487 change.
4488
96fb4434
PE
44892011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4490
4491 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4492 This makes this file independent of the recent pseudovector change.
4493
671875da 44942011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4495
69e9b5a3
PE
4496 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4497
b5f869a7 4498 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4499 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4500 Remove unused local.
c8926152 4501 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4502
841a1577 4503 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4504 GCC 4.6.0 optimizes based on type-based alias analysis.
4505 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4506 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4507 != &v->size, and therefore "v->size = 1; b->size = 2; return
4508 v->size;" must therefore return 1. This assumption is incorrect
4509 for Emacs, since it type-puns struct Lisp_Vector * with many other
4510 types. To fix this problem, this patch adds a new type struct
f904488f 4511 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4512 and pseudovectors, and helps optimizing compilers not get fooled
4513 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4514 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4515 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4516 the size member.
eab3844f
PE
4517 (XSETPVECTYPE): Rewrite in terms of new macro.
4518 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4519 This is a bit clearer, and further avoids the possibility of
4520 undesirable aliasing.
4521 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4522 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4523 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4524 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4525 (ASIZE): Now uses header.size rather than size.
4526 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4527 to avoid the hassle of writing XVECTOR (foo)->header.size.
4528 (struct vectorlike_header): New type.
eab3844f
PE
4529 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4530 object, to help avoid aliasing.
4531 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4532 (SUBRP): Likewise, since Lisp_Subr is a special case.
4533 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4534 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4535 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4536 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4537 changed to be "header.size" and "header.next".
4538 * buffer.h (struct buffer): Likewise.
4539 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4540 * frame.h (struct frame): Likewise.
4541 * process.h (struct Lisp_Process): Likewise.
4542 * termhooks.h (struct terminal): Likewise.
4543 * window.c (struct save_window_data, struct saved_window): Likewise.
4544 * window.h (struct window): Likewise.
4545 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4546 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4547 * buffer.c (init_buffer_once): Likewise.
4548 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4549 special case.
4550 * process.c (Fformat_network_address): Use local var for size,
4551 for brevity.
4552
0df1eac5
PE
4553 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4554
847ab9d1 4555 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4556 * data.c (atof): Remove decl; no longer used or needed.
4557 (digit_to_number): Move to lread.c.
4558 (Fstring_to_number): Use new string_to_number function, to be
4559 consistent with how the Lisp reader treats infinities and NaNs.
4560 Do not assume that floating-point numbers represent EMACS_INT
4561 without losing information; this is not true on most 64-bit hosts.
4562 Avoid double-rounding errors, by insisting on integers when
4563 parsing non-base-10 numbers, as the documentation specifies.
4564 * lisp.h (string_to_number): New decl, replacing ...
4565 (isfloat_string): Remove.
bc0a5c13 4566 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4567 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4568 appears to have been a coding error. Similarly, do not accept
4569 strings like +-1e0 as floating point numbers. Do not report
4570 overflow for integer overflows unless the base is not 10 which
4571 means we have no simple and reliable way to continue.
4572 Break out the floating-point parsing into a new
4573 function string_to_number, so that Fstring_to_number parses
4574 floating point numbers consistently with the Lisp reader.
04f2d78b 4575 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4576 (E_CHAR, EXP_INT): Remove, replacing with ...
4577 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4578 (string_to_number): New function, replacing isfloat_string.
4579 This function checks for valid syntax and produces the resulting
4580 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4581 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4582 so that overflow for non-base-10 numbers is reported only when
4583 there's no portable and simple way to convert to floating point.
452f4150 4584
67769ffc
PE
4585 * textprop.c (set_text_properties_1): Rewrite for clarity,
4586 and to avoid GCC warning about integer overflow.
4587
c20db43f
PE
4588 * intervals.h (struct interval): Use EMACS_INT for members
4589 where EMACS_UINT might cause problems. See
4590 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4591 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4592 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4593 All uses changed.
37aa2f85
PE
4594 (offset_intervals): Tell GCC not to worry about length overflow
4595 when negating a negative length.
c20db43f 4596
2538aa2f
PE
4597 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4598 (overrun_check_free): Likewise.
4599
f2d3008d
PE
4600 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4601 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4602 word size.
4603
ec8df744
PE
4604 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4605 (gnutls_make_error): Rename local to avoid shadowing.
4606 (gnutls_emacs_global_deinit): ifdef out; not used.
4607 (Fgnutls_boot): Use const for pointer to readonly storage.
4608 Comment out unused local. Fix pointer signedness problems.
4609
640ee02d
PE
4610 * lread.c (openp): Don't stuff size_t into an 'int'.
4611 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4612 about possible signed overflow.
4613
6048fb2a
PE
4614 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4615 (GDK_KEY_g): Don't define if already defined.
4616 (xg_prepare_tooltip): Avoid pointer signedness problem.
4617 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4618
fa3c87e1
PE
4619 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4620 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4621
2172544b
PE
4622 * xfns.c (Fx_window_property): Simplify a bit,
4623 to make a bit faster and to avoid GCC 4.6.0 warning.
4624 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4625
9b821a21
PE
4626 * fns.c (internal_equal): Don't assume size_t fits in int.
4627
3c616cfa
PE
4628 * alloc.c (compact_small_strings): Tighten assertion a little.
4629
c2982e87
PE
4630 Replace pEd with more-general pI, and fix some printf arg casts.
4631 * lisp.h (pI): New macro, generalizing old pEd macro to other
4632 conversion specifiers. For example, use "...%"pI"d..." rather
4633 than "...%"pEd"...".
4634 (pEd): Remove. All uses replaced with similar uses of pI.
4635 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4636 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4637 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4638 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4639 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4640 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4641 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4642 64-bit hosts.
4643 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4644 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4645 * print.c (safe_debug_print, print_object): Likewise.
4646 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4647 to int.
6f04d126
PE
4648 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4649 avoiding the 0 flag, which is not portable.
c2982e87
PE
4650 * process.c (Fmake_network_process): Use pI to avoid cast.
4651 * region-cache.c (pp_cache): Likewise.
4652 * xdisp.c (decode_mode_spec): Likewise.
4653 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4654 behavior on 64-bit hosts with printf arg.
6f04d126 4655 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4656 (x_stop_queuing_selection_requests): Likewise.
4657 (x_get_window_property): Don't truncate byte count to an 'int'
4658 when tracing.
0b432f21 4659
5e073ec7
PE
4660 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4661 here, since it parses constructs like leading '-' and spaces,
4662 which are not wanted; and it overflows with large numbers.
4663 Instead, simply match F[0-9]+, which is what is wanted anyway.
4664
36372bf9
PE
4665 * alloc.c: Remove unportable assumptions about struct layout.
4666 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4667 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4668 (allocate_vectorlike, make_pure_vector): Use the new macros,
4669 plus offsetof, to remove unportable assumptions about struct layout.
4670 These assumptions hold on all porting targets that I know of, but
4671 they are not guaranteed, they're easy to remove, and removing them
4672 makes further changes easier.
4673
0b432f21
PE
4674 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4675 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4676 (string_overrun_cookie): Now const. Use initializers that
4677 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4678 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4679 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4680 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4681 multiple of sizeof (EMACS_INT); it need not be, if
4682 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4683 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4684
895009e1
JB
46852011-04-26 Juanma Barranquero <lekktu@gmail.com>
4686
4687 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4688
6a7a1b0b
TZ
46892011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4690
4691 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4692 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4693 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4694
841a1577 46952011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4696
4697 * lisp.h (Qdebug): List symbol.
895009e1 4698 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4699 * keyboard.c (debug-on-event): New variable.
4700 (handle_user_signal): Break into debugger when debug-on-event
4701 matches the current signal symbol.
4702
f2d3ba6f
DN
47032011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4704
4705 * alloc.c (check_sblock, check_string_bytes)
4706 (check_string_free_list): Convert to standard C.
4707
42ce4c63
TZ
47082011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4709
4710 * w32.c (emacs_gnutls_push): Fix typo.
4711
825cd63c
EZ
47122011-04-25 Eli Zaretskii <eliz@gnu.org>
4713
fb11d64d
EZ
4714 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4715 "cast to pointer from integer of different size".
4716
825cd63c
EZ
4717 Improve doprnt and its use in verror. (Bug#8545)
4718 * doprnt.c (doprnt): Document the set of format control sequences
4719 supported by the function. Use SAFE_ALLOCA instead of always
4720 using `alloca'.
4721
4722 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4723 is one byte too soon. Don't use xrealloc; instead xfree and
4724 xmalloc anew.
4725
e061a11b
TZ
47262011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4727
4728 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4729 callbacks stage.
4730
4731 * gnutls.c: Renamed global_initialized to
4732 gnutls_global_initialized. Added internals for the
4733 :verify-hostname-error, :verify-error, and :verify-flags
4734 parameters of `gnutls-boot' and documented those parameters in the
4735 docstring. Start callback support.
9173deec
JB
4736 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4737 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4738 on error. Return error code.
e061a11b
TZ
4739 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4740 (emacs_gnutls_read): Likewise.
4741 (Fgnutls_boot): Return handshake error code.
4742 (emacs_gnutls_handle_error): New function.
4743 (wsaerror_to_errno): Likewise.
4744
4745 * w32.h (emacs_gnutls_pull): Add prototype.
4746 (emacs_gnutls_push): Likewise.
4747
4748 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4749 (emacs_gnutls_push): Likewise.
4750
47512011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4752
4753 * process.c (wait_reading_process_output): Check if GnuTLS
4754 buffered some data internally if no FDs are set for TLS
4755 connections.
4756
4757 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4758 (LIBS): Link to USER_LIBS.
4759 ($(BLD)/gnutls.$(0)): New target.
4760
fa6996bc
EZ
47612011-04-24 Eli Zaretskii <eliz@gnu.org>
4762
eb35682e
EZ
4763 * xdisp.c (handle_single_display_spec): Rename the
4764 display_replaced_before_p argument into display_replaced_p, to
4765 make it consistent with the commentary. Fix typos in the
4766 commentary.
4767
e2ad650c
EZ
4768 * textprop.c (syms_of_textprop): Remove dead code.
4769 (copy_text_properties): Delete obsolete commentary about an
4770 interface that was deleted long ago. Fix typos in the description
4771 of arguments.
4772
1b2de274
EZ
4773 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4774 to changes in oldXMenu/XMenu.h from 2011-04-16.
4775 <menu_help_message, prev_menu_help_message>: Constify.
4776 (IT_menu_make_room): menu->help_text is now `const char **';
4777 adjust.
4778
4779 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4780 to changes in oldXMenu/XMenu.h from 2011-04-16.
4781 (struct XMenu): Declare `help_text' `const char **'.
4782
4783 * xfaces.c <Qunspecified>: Make extern again.
4784
4785 * syntax.c: Include sys/types.h before including regex.h, as
4786 required by Posix.
4787
762b15be
EZ
4788 * doc.c (get_doc_string): Improve the format passed to `error'.
4789
4790 * doprnt.c (doprnt): Improve commentary.
4791
4792 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4793
4794 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4795 them with etags.
4796
f1052e5d
EZ
4797 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4798 changes in globals.h immediately force recompilation.
762b15be
EZ
4799 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4800 $(CURDIR)/s/ms-w32.h.
4801 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4802
fa6996bc
EZ
4803 * character.c (Fchar_direction): Function deleted.
4804 (syms_of_character): Don't defsubr it.
4805 <char-direction-table>: Deleted.
4806
e6c3da20
EZ
48072011-04-23 Eli Zaretskii <eliz@gnu.org>
4808
4809 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4810 * doprnt.c: Include limits.h.
4811 (SIZE_MAX): New macro.
04f2d78b
CB
4812 (doprnt): Return a size_t value. 2nd arg is now size_t.
4813 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4814 Improve overflow protection. Support `l' modifier for integer
4815 conversions. Support %l conversion. Don't assume an EMACS_INT
4816 argument for integer conversions and for %c.
4817
4818 * lisp.h (doprnt): Restore prototype.
4819
4820 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4821 $(SRC)/character.h.
4822
4823 * Makefile.in (base_obj): Add back doprnt.o.
4824
4825 * deps.mk (doprnt.o): Add back prerequisites.
4826 (callint.o): Depend on character.h.
4827
4828 * eval.c (internal_lisp_condition_case): Include the handler
4829 representation in the error message.
4830 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4831 when breaking from the loop.
4832
4833 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4834
4835 * callint.c (Fcall_interactively): When displaying error message
4836 about invalid control letter, pass the character's codepoint, not
4837 a pointer to its multibyte form. Improve display of the character
4838 in octal and display also its hex code.
4839
4840 * character.c (char_string): Use %x to display the (unsigned)
4841 codepoint of an invalid character, to avoid displaying a bogus
4842 negative value.
4843
4844 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4845 `error', not SYMBOL_NAME itself.
4846
4847 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4848 character arguments to `error'.
4849
4850 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4851 to `error' in error message about FINAL_CHAR argument. Make sure
4852 FINAL_CHAR is a character, and use %c when it is passed as
4853 argument to `error'.
4854
4ffd0d6b 48552011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4856
4857 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4858
4859 * w32.c: Include <time.h>.
4860 (sys_localtime): New function.
4861
4ffd0d6b 48622011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4863
4864 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4865
4ffd0d6b 4866 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4867
4ffd0d6b 48682011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4869
4ffd0d6b
GM
4870 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4871 zombies (Bug#8467).
aac0c6e3 4872
04c56954
EZ
48732011-04-19 Eli Zaretskii <eliz@gnu.org>
4874
4875 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4876 gl_state.e_property when gl_state.object is Qt.
4877
4878 * insdel.c (make_gap_larger): Remove limitation of buffer size
4879 to <= INT_MAX.
4880
16a43933
CY
48812011-04-18 Chong Yidong <cyd@stupidchicken.com>
4882
4883 * xdisp.c (lookup_glyphless_char_display)
4884 (produce_glyphless_glyph): Handle cons cell entry in
4885 glyphless-char-display.
4886 (Vglyphless_char_display): Document it.
4887
4888 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4889 glyphless-char-display.
4890
4581706e
CY
48912011-04-17 Chong Yidong <cyd@stupidchicken.com>
4892
4893 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4894
4895 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4896
4897 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4898 definition for no-X builds.
4899
4887c6e2 49002011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4901
fd35b6f9
PE
4902 Static checks with GCC 4.6.0 and non-default toolkits.
4903
5c1ccb01
PE
4904 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4905
006c5daa
PE
4906 * process.c (keyboard_bit_set): Define only if SIGIO.
4907 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4908 (send_process): Repair possible setjmp clobbering.
4909
efc736d3
PE
4910 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4911
4e2fe2e6
PE
4912 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4913
f97334a2
PE
4914 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4915
4e75f29d
PE
4916 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4917 Define only if needed.
4918
90efadd1
PE
4919 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4920 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4921 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4922
3c647824
PE
4923 * dispextern.h (struct redisplay_interface): Rename param
4924 to avoid shadowing.
e264f262 4925 * termhooks.h (struct terminal): Likewise.
761383f4 4926 * xterm.c (xembed_send_message): Likewise.
3c647824 4927
b58c5c4a
PE
4928 * insdel.c (make_gap_smaller): Define only if
4929 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4930
cad59032
PE
4931 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4932 it.
4933
c339dc2e
PE
4934 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4935 so that we aren't warned about unused symbols.
4936
91a3e27b
PE
4937 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4938
399c71d3 4939 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4940
8ffc96f5
PE
4941 * xfns.c (x_real_positions): Mark locals as initialized.
4942
eef9bc79
PE
4943 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4944
098db9dd
PE
4945 * xterm.c: Fix problems found by static analysis with other toolkits.
4946 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4947 (x_dispatch_event): Declare static if USE_GTK, and
4948 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4949 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4950 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4951 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4952 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4953
eb18f6cc
PE
4954 * xmenu.c (menu_help_callback): Pointer type fixes.
4955 Use const pointers when pointing at readonly data. Avoid pointer
4956 signedness clashes.
4957 (FALSE): Remove unused macro.
4958 (update_frame_menubar): Remove unused decl.
4959
1fe72bf8
PE
4960 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4961
60d9e1db
PE
4962 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4963 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4964 (single_menu_item): Rename local to avoid shadowing.
4965
39261c26
PE
4966 * keyboard.c (make_lispy_event): Remove unused local var.
4967
018c5e19
PE
4968 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4969 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4970
63d2b86e
PE
4971 * bitmaps: Change bitmaps from unsigned char back to the X11
4972 compatible char. Avoid the old compiler warnings about
4973 out-of-range initializers by using, for example, '\xab' rather
4974 than 0xab.
4975
aefd87e1
PE
4976 * xgselect.c (xgselect_initialize): Check vs interface
4977 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4978
bf501fb9
PE
4979 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4980
e9829fdf
PE
4981 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4982 to read-only memory.
4983
1086c095
PE
4984 * fns.c (vector): Remove; this old hack is no longer needed.
4985
2baccd04 4986 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4987 Remove unused var.
dde42981 4988 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4989
72391843 4990 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4991
436c16df 4992 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4993 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4994 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4995
92bb796d 4996 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4997 (x_term_init): Remove local to avoid shadowing.
92bb796d 4998
764430a3 4999 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5000
5001 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5002 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5003
d1dfb56c
EZ
50042011-04-16 Eli Zaretskii <eliz@gnu.org>
5005
c4354cb4
EZ
5006 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5007
d1dfb56c
EZ
5008 Fix regex.c, syntax.c and friends for buffers > 2GB.
5009 * syntax.h (struct gl_state_s): Declare character position members
5010 EMACS_INT.
5011
5012 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5013
04f2d78b
CB
5014 * textprop.c (verify_interval_modification, interval_of):
5015 Declare arguments EMACS_INT.
d1dfb56c
EZ
5016
5017 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5018 EMACS_INT.
5019
5020 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5021
5022 * indent.c (Fvertical_motion): Local variable it_start is now
5023 EMACS_INT.
5024
5025 * regex.c (re_match, re_match_2, re_match_2_internal)
5026 (bcmp_translate, regcomp, regexec, print_double_string)
5027 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5028 (re_compile_pattern, re_exec): Declare arguments and local
5029 variables `size_t' and `ssize_t' and return values `regoff_t', as
5030 appropriate.
5031 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5032 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5033 <compile_stack_type>: `size' and `avail' are now `size_t'.
5034
5035 * regex.h <regoff_t>: Use ssize_t, not int.
5036 (re_search, re_search_2, re_match, re_match_2): Arguments that
5037 specify buffer/string position and length are now ssize_t and
5038 size_t. Return type is regoff_t.
5039
613052cd
BK
50402011-04-16 Ben Key <bkey76@gmail.com>
5041
5042 * nsfont.m: Fixed bugs in ns_get_family and
5043 ns_descriptor_to_entity that were caused by using free to
5044 deallocate memory blocks that were allocated by xmalloc (via
5045 xstrdup). This caused Emacs to crash when compiled with
5046 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5047 --enable-checking=xmallocoverrun). xfree is now used to
5048 deallocate these memory blocks.
5049
4170f62f 50502011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5051
71b41406
PE
5052 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5053
9587a89d
PE
5054 emacs_write: Accept and return EMACS_INT for sizes.
5055 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5056 et seq.
5057 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5058 Accept and return EMACS_INT.
5059 (emacs_gnutls_write): Return the number of bytes written on
5060 partial writes.
5061 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5062 (emacs_read, emacs_write): Remove check for negative size, as the
5063 Emacs source code has been audited now.
9587a89d
PE
5064 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5065 (emacs_read, emacs_write): Use it.
273a5f82
PE
5066 * process.c (send_process): Adjust to the new signatures of
5067 emacs_write and emacs_gnutls_write. Do not attempt to store
5068 a byte offset into an 'int'; it might overflow.
9587a89d 5069 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5070
3e047f51
PE
5071 * sound.c: Don't assume sizes fit in 'int'.
5072 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5073 Return EMACS_INT, not int.
3e047f51 5074 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5075 Accept EMACS_INT, not int.
5076 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5077 record read return values.
5078
cc39a9db
BK
50792011-04-15 Ben Key <bkey76@gmail.com>
5080
c9d0ec6d
JB
5081 * keyboard.c (Qundefined): Don't declare static since it is used
5082 in nsfns.m.
5083 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5084 static since they are used in nsfont.m.
cc39a9db 5085
6c60eb9f
SM
50862011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5087
5088 * process.c (Qprocessp): Don't declare static.
5089 * lisp.h (Qprocessp): Declare again.
5090
7990b61a
JB
50912011-04-15 Juanma Barranquero <lekktu@gmail.com>
5092
5093 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5094
5d4cb038
PE
50952011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5096
8bd7b830 5097 Improve C-level modularity by making more things 'static'.
cd64ea1d 5098
e3b27b31
PE
5099 Don't publish debugger-only interfaces to other modules.
5100 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5101 (verify_bytepos, count_markers): Move decls to the only modules
5102 that need them.
5103 * region-cache.h (pp_cache): Likewise.
5104 * window.h (check_all_windows): Likewise.
5105 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5106
5d4cb038
PE
5107 * sysdep.c (croak): Now static, if
5108 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5109 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5110
5111 * alloc.c (refill_memory_reserve): Now static if
5112 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5113 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5114
e87b6180
PE
5115 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5116 Define only if USE_LUCID.
5117
ac64929e
PE
5118 * xrdb.c (x_customization_string, x_rm_string): Now static.
5119
6f37259d
PE
5120 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5121 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5122
1683e3ab
PE
5123 * xdisp.c (draw_row_with_mouse_face): Now static.
5124 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5125
de9c2632
PE
5126 * window.h (check_all_windows): Mark externally visible.
5127
2b96acb7
PE
5128 * window.c (window_deletion_count): Now static.
5129
5130 * undo.c: Make symbols static if they're not exported.
5131 (last_undo_buffer, last_boundary_position, pending_boundary):
5132 Now static.
5133
50436f33
PE
5134 * textprop.c (interval_insert_behind_hooks): Now static.
5135 (interval_insert_in_front_hooks): Likewise.
5136
64520e5c
PE
5137 * term.c: Make symbols static if they're not exported.
5138 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5139 (max_frame_lines, tty_set_terminal_modes):
5140 (tty_reset_terminal_modes, tty_turn_off_highlight):
5141 (get_tty_terminal): Now static.
5142 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5143 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5144 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5145 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5146 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5147
1fa53021
PE
5148 * sysdep.c: Make symbols static if they're not exported.
5149 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5150 Now static.
5151 (sigprocmask_set, full_mask): Remove; unused.
5152 (wait_debugging): Mark as visible.
5153 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5154 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5155
d4b43b22
PE
5156 * syntax.c (syntax_temp): Define only if !__GNUC__.
5157
b7c513d0
PE
5158 * sound.c (current_sound_device, current_sound): Now static.
5159
989b29ad
PE
5160 * search.c (searchbufs, searchbuf_head): Now static.
5161
13a55a78
PE
5162 * scroll.c (scroll_cost): Remove; unused.
5163 * dispextern.h (scroll_cost): Remove decl.
5164
de68a1fc
PE
5165 * region-cache.h (pp_cache): Mark as externally visible.
5166
40ccffa6
PE
5167 * process.c: Make symbols static if they're not exported.
5168 (process_tick, update_tick, create_process, chan_process):
5169 (Vprocess_alist, proc_buffered_char, datagram_access):
5170 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5171 (deactivate_process): Mark defn as static, as well as decl.
5172 * lisp.h (create_process): Remove decl.
5173 * process.h (chan_process, Vprocess_alist): Remove decls.
5174
ad64fc97
PE
5175 * print.c: Make symbols static if they're not exported.
5176 (print_depth, new_backquote_output, being_printed, print_buffer):
5177 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5178 (print_interval, print_number_index, initial_stderr_stream):
5179 Now static.
5180 * lisp.h (Fprinc): Remove decl.
5181 (debug_output_compilation_hack): Mark as externally visible.
5182
adddb265
PE
5183 * sysdep.c (croak): Move decl from here to syssignal.h.
5184 * syssignal.h (croak): Put it here, so the API can be checked when
5185 'croak' is called from dissociate_if_controlling_tty.
5186
1717ede2
PE
5187 * minibuf.c: Make symbols static if they're not exported.
5188 (minibuf_save_list, choose_minibuf_frame): Now static.
5189 * lisp.h (choose_minibuf_frame): Remove decl.
5190
fa5fb2bc
PE
5191 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5192
1e3890d1
PE
5193 * lread.c: Make symbols static if they're not exported.
5194 (read_objects, initial_obarray, oblookup_last_bucket_number):
5195 Now static.
5196 (make_symbol): Remove; unused.
5197 * lisp.h (initial_obarray, make_symbol): Remove decls.
5198
8a1414fa
PE
5199 * keyboard.c: Make symbols static if they're not exported.
5200 (single_kboard, recent_keys_index, total_keys, recent_keys):
5201 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5202 (this_single_command_key_start, echoing, last_auto_save):
5203 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5204 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5205 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5206 (Vlispy_mouse_stem, double_click_count):
5207 Now static.
5208 (force_auto_save_soon): Define only if SIGDANGER.
5209 (ignore_mouse_drag_p): Now static if
5210 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5211 (print_help): Remove; unused.
5212 (stop_character, last_timer_event): Mark as externally visible.
5213 * keyboard.h (ignore_mouse_drag_p): Declare only if
5214 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5215 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5216 * lisp.h (echoing): Remove decl.
5217 (force_auto_save_soon): Declare only if SIGDANGER.
5218 * xdisp.c (redisplay_window): Simplify code, to make it more
5219 obvious that ignore_mouse_drag_p is not accessed if !defined
5220 USE_GTK && !defined HAVE_NS.
5221
93ea6e8f
PE
5222 * intervals.c: Make symbols static if they're not exported.
5223 (merge_properties_sticky, merge_interval_right, delete_interval):
5224 Now static.
5225 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5226
77382fcc
PE
5227 * insdel.c: Make symbols static if they're not exported.
5228 However, leave prepare_to_modify_buffer alone. It's never
5229 called from outside this function, but that appears to be a bug.
5230 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5231 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5232 (adjust_after_replace_noundo): Remove; unused.
5233 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5234 (signal_before_change): Remove decls.
77382fcc 5235
9306c32e
PE
5236 * indent.c (val_compute_motion, val_vmotion): Now static.
5237
cd44d2eb
PE
5238 * image.c: Make symbols static if they're not exported.
5239 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5240 if USE_GTK.
5241 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5242 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5243
ad9a7a06
PE
5244 * fringe.c (standard_bitmaps): Now static.
5245 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5246
81626931
PE
5247 * frame.c: Make symbols static if they're not exported.
5248 (x_report_frame_params, make_terminal_frame): Now static.
5249 (get_frame_param): Now static, unless HAVE_NS.
5250 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5251 (x_get_resource_string): Remove; not used.
5252 * frame.h (make_terminal_frame, x_report_frame_params):
5253 (x_get_resource_string); Remove decls.
5254 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5255 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5256
239f9db9
PE
5257 * font.c, fontset.c: Make symbols static if they're not exported.
5258 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5259 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5260 * font.c (font_close_object): Now static.
5261 * font.h (font_close_object): Remove.
5262 * fontset.c (FONTSET_OBJLIST): Remove.
5263 (free_realized_fontset) #if-0 the body, which does nothing.
5264 (face_suitable_for_char_p): #if-0, as it's never called.
5265 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5266 * xfaces.c (face_at_string_position):
5267 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5268 since 0 is always ASCII.
5269
dfcf3579
PE
5270 * fns.c (weak_hash_tables): Now static.
5271
5045092b
PE
5272 * fileio.c: Make symbols static if they're not exported.
5273 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5274 (Vwrite_region_annotation_buffers): Now static.
5275
57a96f5c
PE
5276 * eval.c: Make symbols static if they're not exported.
5277 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5278 * lisp.h (backtrace_list): Remove decl.
5279
35f08c38
PE
5280 * emacs.c: Make symbols static if they're not exported.
5281 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5282 (fatal_error_code, fatal_error_signal_hook, standard_args):
5283 Now static.
5284 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5285 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5286 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5287 * lisp.h (fatal_error_signal_hook): Remove decl.
5288 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5289
f44bd759
PE
5290 * editfns.c: Move a (normally-unused) function to its only use.
5291 * editfns.c, lisp.h (get_operating_system_release): Remove.
5292 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5293 worth the hassle of breaking this out.
5294
b532497d
PE
5295 * xterm.c: Make symbols static if they're not exported.
5296 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5297 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5298 (x_destroy_window, x_delete_display):
5299 Now static.
5300 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5301 (x_mouse_leave): Remove; unused.
5302 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5303 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5304 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5305 Remove decls.
5306 (x_mouse_leave): Declare only if WINDOWSNT.
5307 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5308 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5309 USE_X_TOOLKIT.
5310
1675728f
PE
5311 * ftxfont.c: Make symbols static if they're not exported.
5312 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5313 HAVE_FREETYPE.
5314 * font.h (ftxfont_driver): Likewise.
5315
e4cebfca
PE
5316 * xfns.c: Make symbols static if they're not exported.
5317 (x_last_font_name, x_display_info_for_name):
5318 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5319 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5320 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5321 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5322 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5323 (last_show_tip_args): Now static.
5324 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5325 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5326 (x_screen_planes): Remove; unused.
5327 * dispextern.h (x_screen_planes): Remove decl.
5328
5bf46f05
PE
5329 * dispnew.c: Make symbols static if they're not exported.
5330 * dispextern.h (redraw_garbaged_frames, scrolling):
5331 (increment_row_positions): Remove.
5332 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5333 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5334 Now static.
5335 (redraw_garbaged_frames): Remove; unused.
5336
435f4c28
PE
5337 * xfaces.c: Make symbols static if they're not exported.
5338 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5339 Remove decls.
5340 * xterm.h (defined_color): Remove decls.
5341 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5342 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5343 (menu_face_changed_default, defined_color, free_realized_face):
5344 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5345 (ascii_face_of_lisp_face): Remove; unused.
5346
8524aef3
PE
5347 * xdisp.c: Make symbols static if they're not exported.
5348 * dispextern.h (scratch_glyph_row, window_box_edges):
5349 (glyph_to_pixel_coords, set_cursor_from_row):
5350 (get_next_display_element, set_iterator_to_next):
5351 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5352 (show_mouse_face): Remove decls
5353 * frame.h (message_buf_print): Likewise.
5354 * lisp.h (pop_message, set_message, check_point_in_composition):
5355 Likewise.
5356 * xterm.h (set_vertical_scroll_bar): Likewise.
5357 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5358 (message_buf_print, scratch_glyph_row, displayed_buffer):
5359 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5360 (get_next_display_element, show_mouse_face, window_box_edges):
5361 (frame_to_window_pixel_xy, check_point_in_composition):
5362 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5363 (glyph_to_pixel_coords): Remove; unused.
5364
16390cd2
PE
5365 * dired.c (file_name_completion): Now static.
5366
5367 * dbusbind.c (xd_in_read_queued_messages): Now static.
5368
a25f4dfa
PE
5369 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5370 * data.c (circular_list_error): Remove.
5371
14a9c8df
PE
5372 * commands.h (last_point_position, last_point_position_buffer):
5373 (last_point_position_window): Remove decls.
5374 * keyboard.c: Make these variables static.
5375
04f2d78b
CB
5376 * coding.h (coding, code_convert_region, encode_coding_gap):
5377 Remove decls.
74ab6df5
PE
5378 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5379 (iso_code_class, detect_coding, code_convert_region): Now static.
5380 (encode_coding_gap): Remove; unused.
5381
38dfbee1
PE
5382 * chartab.c (chartab_chars, chartab_bits): Now static.
5383
a2cb4e63
PE
5384 * charset.h (charset_iso_8859_1): Remove decl.
5385 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5386 Now static.
5387
127198fd
PE
5388 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5389 * ccl.c (Vccl_program_table): Now static.
5390 (check_ccl_update): Remove; unused.
5391
d85b608f
PE
5392 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5393 * category.h: ... from here.
5394 * category.c (check_category_table, set_category_set): Now static.
5395
31cd66f3
PE
5396 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5397 * lisp.h: Remove these decls.
5398
c358e587
PE
5399 * buffer.c (buffer_count): Remove unused var.
5400
e78aecca
PE
5401 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5402 so that it's not optimized away.
5403 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5404 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5405 exported only to the debugger.
5406
e192d7d3 5407 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5408 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5409
92470028
PE
5410 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5411 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5412 was inaccessible from Lisp.
5413 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5414 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5415
244ed907
PE
5416 alloc.c: Import and export fewer symbols, and remove unused items.
5417 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5418 is defined.
5419 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5420 it's not optimized away by whole-program optimization.
5421 (message_enable_multibyte, free_misc): Remove.
5422 (catchlist, handlerlist, mark_backtrace):
5423 Declare only if BYTE_MARK_STACK.
5424 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5425 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5426 (message_enable_multibyte): Remove decl.
5427 (free_misc, interval_free_list, float_block, float_block_index):
5428 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5429 (cons_free_list, last_marked_index):
5430 Now static.
5431 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5432 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5433 (mark_backtrace): Define only if BYTE_MARK_STACK.
5434 * xdisp.c (message_enable_multibyte): Now static.
5435
61c2b50e 5436 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5437 This makes it easier for human readers (and static analyzers)
5438 to see whether these variables are used from other modules.
5439 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5440 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5441 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5442 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5443 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5444 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5445 * xmenu.c, xselect.c:
5446 Declare Q* vars static if they are not used in other modules.
5447 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5448 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5449 Remove decls of unexported vars.
5450 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5451
95c82688
PE
5452 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5453
16a97296
PE
5454 Make Emacs functions such as Fatom 'static' by default.
5455 This makes it easier for human readers (and static analyzers)
5456 to see whether these functions can be called from other modules.
5457 DEFUN now defines a static function. To make the function external
5458 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5459 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5460 (Finit_image_library):
16a97296
PE
5461 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5462 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5463 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5464 Remove decls, since these functions are now static.
5465 (Funintern, Fget_internal_run_time): New decls, since these functions
5466 were already external.
95c82688 5467
16a97296
PE
5468 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5469 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5470 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5471 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5472 * keyboard.c, keymap.c, lread.c:
5473 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5474 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5475 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5476 Mark functions with DEFUE instead of DEFUN,
5477 if they are used in other modules.
5478 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5479 decls for now-static functions.
5480 * buffer.h (Fdelete_overlay): Remove decl.
5481 * callproc.c (Fgetenv_internal): Mark as internal.
5482 * composite.c (Fremove_list_of_text_properties): Remove decl.
5483 (Fcomposition_get_gstring): New forward static decl.
5484 * composite.h (Fcomposite_get_gstring): Remove decl.
5485 * dired.c (Ffile_attributes): New forward static decl.
5486 * doc.c (Fdocumntation_property): New forward static decl.
5487 * eval.c (Ffetch_bytecode): New forward static decl.
5488 (Funintern): Remove extern decl; now in .h file where it belongs.
5489 * fileio.c (Fmake_symbolic_link): New forward static decl.
5490 * image.c (Finit_image_library): New forward static decl.
5491 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5492 * intervals.h (Fprevious_property_change):
5493 (Fremove_list_of_text_properties): Remove decls.
5494 * keyboard.c (Fthis_command_keys): Remove decl.
5495 (Fcommand_execute): New forward static decl.
5496 * keymap.c (Flookup_key): New forward static decl.
5497 (Fcopy_keymap): Now static.
5498 * keymap.h (Flookup_key): Remove decl.
5499 * process.c (Fget_process): New forward static decl.
5500 (Fprocess_datagram_address): Mark as internal.
5501 * syntax.c (Fsyntax_table_p): New forward static decl.
5502 (skip_chars): Remove duplicate decl.
5503 * textprop.c (Fprevious_property_change): New forward static decl.
5504 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5505 Now internal.
5506 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5507 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5508
785bbd42
PE
5509 * editfns.c (Fformat): Remove unreachable code.
5510
8b913b57
AS
55112011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5512
5513 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5514 change. (Bug#8496)
5515
a6744a35
EZ
55162011-04-13 Eli Zaretskii <eliz@gnu.org>
5517
5518 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5519 when at ZV. (Bug#8487)
5520
e7974947
AS
55212011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5522
baad03f0
AS
5523 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5524 (Bug#8437)
5525 * keyboard.c (parse_tool_bar_item): Likewise.
5526 * sound.c (sound_cleanup, alsa_close): Likewise.
5527 * termcap.c (tgetent): Likewise.
5528 * xfns.c (x_default_font_parameter): Likewise.
5529 * xsettings.c (read_and_apply_settings): Likewise.
5530
e7974947
AS
5531 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5532 (overrun_check_free): Protoize.
5533
28272684
PE
55342011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5535
5536 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5537 since callers should never pass a negative size.
5538 Change the signature to match that of plain 'read' and 'write'; see
5539 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5540 * lisp.h: Update prototypes of emacs_write and emacs_read.
5541
11997c76
EZ
55422011-04-11 Eli Zaretskii <eliz@gnu.org>
5543
5544 * xdisp.c (redisplay_window): Don't try to determine the character
5545 position of the scroll margin if the window start point w->startp
e896f03c 5546 is outside the buffer's accessible region. (Bug#8468)
11997c76 5547
8a2cbd72
EZ
55482011-04-10 Eli Zaretskii <eliz@gnu.org>
5549
5550 Fix write-region and its subroutines for buffers > 2GB.
5551 * fileio.c (a_write, e_write): Modify declaration of arguments and
5552 local variables to support buffers larger than 2GB.
5553 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5554
5555 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5556 argument, local variables, and return value.
5557
5558 * lisp.h: Update prototypes of emacs_write and emacs_read.
5559
5560 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5561
4073e537 55622011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5563
1ebfdcb6
PE
5564 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5565
b2ded58d
PE
5566 Fix more problems found by GCC 4.6.0's static checks.
5567
7d66342c
PE
5568 * xdisp.c (vmessage): Use a better test for character truncation.
5569
bbf47d44
PE
5570 * charset.c (load_charset_map): <, not <=, for optimization,
5571 and to avoid potential problems with integer overflow.
9248994d 5572 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5573 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5574 * editfns.c (Fformat): Likewise.
1e69125e 5575 * syntax.c (skip_chars): Likewise.
3befa583 5576
e3019616
PE
5577 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5578 This also lets GCC 4.6.0 generate slightly better loop code.
5579
becfa255
PE
5580 * callint.c (Fcall_interactively): <, not <=, for optimization.
5581 (Fcall_interactively): Count the number of arguments produced,
5582 not the number of arguments given. This is simpler and lets GCC
5583 4.6.0 generate slightly better code.
5584
dae0cd48
PE
5585 * ftfont.c: Distingish more carefully between FcChar8 and char.
5586 The previous code passed unsigned char * to a functions like
5587 strlen and xstrcasecmp that expect char *, which does not
5588 conform to the C standard.
5589 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5590 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5591 char * when the C standard requires it.
5592
76032d70
PE
5593 * keyboard.c (read_char): Remove unused var.
5594
eb3f1cc8
PE
5595 * eval.c: Port to Windows vsnprintf (Bug#8435).
5596 Include <limits.h>.
5597 (SIZE_MAX): Define if the headers do not.
5598 (verror): Do not give up if vsnprintf returns a negative count.
5599 Instead, grow the buffer. This ports to Windows vsnprintf, which
5600 does not conform to C99. Problem reported by Eli Zaretskii.
5601 Also, simplify the allocation scheme, by avoiding the need for
5602 calling realloc, and removing the ALLOCATED variable.
5603
70476b54
PE
5604 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5605
12020a9e
PE
5606 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5607 But keep the doprint source code for now, as we might revamp it
5608 and use it again (Bug#8435).
ea6c7ae6
PE
5609 * lisp.h (doprnt): Remove.
5610 * Makefile.in (base_obj): Remove doprnt.o.
5611 * deps.mk (doprnt.o): Remove.
5612
5fdb398c
PE
5613 error: Print 32- and 64-bit integers portably (Bug#8435).
5614 Without this change, on typical 64-bit hosts error ("...%d...", N)
5615 was used to print both 32- and 64-bit integers N, which relied on
5616 undefined behavior.
5617 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5618 New macro.
5619 * lisp.h (error, verror): Mark as printf-like functions.
5620 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5621 Report overflow in size calculations when allocating printf buffer.
5622 Do not truncate output string at its first null byte.
5623 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5624 Truncate the output at a character boundary, since vsnprintf does not
5625 do that.
5626 * charset.c (check_iso_charset_parameter): Convert internal
5627 character to string before calling 'error', since %c now has the
5628 printf meaning.
5629 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5630 overflow when computing char to be passed to 'error'. Do not
5631 pass Lisp_Object to 'error'; pass the integer instead.
5632 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5633 formatted with plain %d.
5634
b189fa66
PE
5635 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5636
bff87ef0
PE
5637 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5638
7e2cac20
PE
5639 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5640
ce4d90b5
PE
5641 * xterm.c (x_catch_errors): Remove duplicate declaration.
5642
266c9547
PE
5643 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5644
79c49ad2
PE
5645 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5646
368f4090
JM
56472011-04-10 Jim Meyering <meyering@redhat.com>
5648
5649 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5650 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5651 return ssize_t not "int", and use size_t as the buffer length.
5652 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5653 * gnutls.h: Update declarations.
5654 * process.c (read_process_output): Use ssize_t, to match.
5655 (send_process): Likewise.
5656
a32d4040
CY
56572011-04-09 Chong Yidong <cyd@stupidchicken.com>
5658
5659 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5660
8546720e 56612011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5662
04f2d78b
CB
5663 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5664 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5665
8546720e
GM
5666 * xterm.c (handle_one_xevent):
5667 * xmenu.c (create_and_show_popup_menu):
5668 * xselect.c (x_decline_selection_request)
5669 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5670
0a2f5c1a 56712011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5672
5673 Fix some uses of `int' instead of EMACS_INT.
5674 * search.c (string_match_1, fast_string_match)
5675 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5676 (scan_buffer, find_next_newline_no_quit)
5677 (find_before_next_newline, search_command, Freplace_match)
5678 (Fmatch_data): Make some `int' variables be EMACS_INT.
5679
5680 * xdisp.c (display_count_lines): 3rd argument and return value now
5681 EMACS_INT. All callers changed.
5682 (pint2hrstr): Last argument is now EMACS_INT.
5683
5684 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5685 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5686 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5687 (decode_coding_utf_16, decode_coding_emacs_mule)
5688 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5689 (decode_coding_ccl, decode_coding_charset)
5690 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5691 (decode_coding_iso_2022, decode_coding_emacs_mule)
5692 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5693 <char_offset, last_offset>: Declare EMACS_INT.
5694 (encode_coding_utf_8, encode_coding_utf_16)
5695 (encode_coding_emacs_mule, encode_invocation_designation)
5696 (encode_designation_at_bol, encode_coding_iso_2022)
5697 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5698 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5699 Declare EMACS_INT.
5700 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5701 (encode_invocation_designation): Last argument P_NCHARS is now
5702 EMACS_INT.
5703 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5704 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5705
5706 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5707 All users changed.
5708
5709 * ccl.c (Fccl_execute_on_string): Declare some variables
5710 EMACS_INT.
5711
8546720e 57122011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5713
5714 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5715
4e19a977
CS
57162011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5717
5718 * process.c (Fformat_network_address): Doc fix.
5719
87302331
R
57202011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5721
5722 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5723
cbb59342
CY
57242011-04-08 Chong Yidong <cyd@stupidchicken.com>
5725
5726 * keyboard.c (read_char): Call Lisp function help-form-show,
5727 instead of using internal_with_output_to_temp_buffer.
5728 (Qhelp_form_show): New var.
e0d38eeb 5729 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5730
5731 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5732
5733 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5734
e67a13ab
CY
57352011-04-06 Chong Yidong <cyd@stupidchicken.com>
5736
04f2d78b
CB
5737 * process.c (Flist_processes): Remove to Lisp.
5738 (list_processes_1): Delete.
e67a13ab 5739
973f782d
EZ
57402011-04-06 Eli Zaretskii <eliz@gnu.org>
5741
7c106b1e
EZ
5742 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5743
973f782d
EZ
5744 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5745
41cf7d1a 57462011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5747
ca23cc88
PE
5748 Fix more problems found by GCC 4.6.0's static checks.
5749
f390e2d5
PE
5750 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5751
42eea0d0
PE
5752 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5753
b69769da 5754 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5755
f9541e84
PE
5756 * xdisp.c (vmessage): Mark as a printf-like function.
5757
13841b55
PE
5758 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5759
c136c10f
PE
5760 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5761
5e2d4a30
PE
5762 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5763 printf-like functions.
5764 (tiff_load): Add casts to remove these marks before passing them
5765 to system-supplied API.
5766
583f48b9
PE
5767 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5768
b25d760e
PE
5769 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5770 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5771 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5772 directly, rather than having caller test rule sign. This avoids
5773 some unnecessary tests.
5774 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5775 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5776 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5777
bc7b6697 5778 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5779 (xfont_open): Avoid unnecessary tests.
bc7b6697 5780
27ccc379
PE
5781 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5782
dcd5c89a
PE
5783 * composite.h, composite.c (composition_gstring_put_cache):
5784 Use EMACS_INT, not int, for length.
5785
b13a45c6
PE
5786 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5787 breaking out part of COMPOSITION_DECODE_RULE.
5788 (COMPOSITION_DECODE_RULE): Use it.
5789 * composite.c (get_composition_id): Remove unused local vars,
5790 by using the new macro.
5791
1e792e4d
PE
5792 * textprop.c (set_text_properties_1): Change while to do-while,
5793 since the condition is always true at first.
5794
dc6c6455 5795 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5796 (interval_deletion_adjustment): Return unsigned value.
5797 All uses changed.
dc6c6455 5798
aba7731a
PE
5799 * process.c (list_processes_1, create_pty, read_process_output):
5800 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5801 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5802 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5803 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5804 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5805
fdfc4bf3
PE
5806 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5807
fca8fe46 5808 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5809 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5810
06a0259a 5811 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5812 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5813 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5814
e7b9e80f
PE
5815 * print.c (print_error_message): Avoid int overflow.
5816
56201685
PE
5817 * font.c (font_list_entities): Redo for clarity,
5818 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5819
78834453 5820 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5821 (font_score): Avoid potential overflow in diff calculation.
78834453 5822
0bc0b309 5823 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5824 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5825
e610eaca
PE
5826 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5827
b895abce
PE
5828 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5829 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5830 can always succeed if overflow has undefined behavior.
5831
1f1d9321 5832 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5833 (wordify): Omit three unnecessary tests.
1f1d9321 5834
c59478bc
PE
5835 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5836 All callers changed. This avoids the need for an unused var.
5837
79b73827
PE
5838 * casefiddle.c (casify_region): Remove var that is set but not used.
5839
a4db5dfe
PE
5840 * dired.c (file_name_completion): Remove var that is set but not used.
5841
43aae36e
PE
5842 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5843
2a47c44d 5844 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5845 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5846
a37c69bf
PE
5847 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5848 Check for integer overflow on size calculations.
5849
328ab8e7
PE
5850 * buffer.c (Fprevious_overlay_change): Remove var that is set
5851 but not used.
5852
e5a2a5cb
PE
5853 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5854 Remove vars that are set but not used.
8d84a6eb 5855 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5856 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5857
a60e5f68
PE
5858 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5859
f661cb61 5860 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5861 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5862
f0397f5a
PE
5863 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5864 that are set but not used.
5865
8664db06 5866 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5867 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5868
6abdaa4a
PE
5869 * xselect.c (x_get_local_selection, x_handle_property_notify):
5870 Remove vars that are set but not used.
5871
0ce7538d 5872 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5873 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5874
9ae848fc
PE
5875 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5876 Remove var that is set but not used.
0b918413
PE
5877 (scroll_bar_windows_size): Now size_t, not int.
5878 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5879 Check for overflow.
9ae848fc 5880
a5a62657
PE
5881 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5882 (map_tty_color) [!defined MSDOS]: Likewise.
5883
5c5cdd39
PE
5884 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5885
66ebf983
PE
5886 * coding.c: Remove vars that are set but not used.
5887 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5888 All callers changed.
5889 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5890 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5891 (decode_coding_charset): Remove vars that are set but not used.
5892
1be4d761
PE
5893 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5894 that is set but not used.
5895
47553fa8
PE
5896 * print.c (print_object): Remove var that is set but not used.
5897
1f7196bf 5898 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5899 The gnulib version avoids calling malloc in the usual case,
5900 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5901 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5902 * filelock.c (current_lock_owner): Likewise.
5903 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5904 * sysdep.c: Include allocator.h, careadlinkat.h.
5905 (emacs_no_realloc_allocator): New static constant.
5906 (emacs_readlink): New function.
fdb61804
PE
5907 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5908 ../lib/careadlinkat.h.
d1fdcab7 5909
f84c17c7
SM
59102011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5911
5912 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5913 first non-nil return value).
5914
ef3862ad
JD
59152011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5916
5917 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5918 if not defined (Bug#8403).
5919
376a7006
JB
59202011-04-02 Juanma Barranquero <lekktu@gmail.com>
5921
5922 * xdisp.c (display_count_lines): Remove parameter `start',
5923 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5924 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5925 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5926 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5927 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5928 and thereabouts. All callers changed.
5929 (get_per_char_metric): Remove parameter `f', unused since
5930 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5931
6ca3801d
JM
59322011-04-02 Jim Meyering <meyering@redhat.com>
5933
5934 do not dereference NULL upon failed strdup
5935 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5936 (ns_get_family): Likewise.
5937
d8e2b5ba
JB
59382011-04-02 Juanma Barranquero <lekktu@gmail.com>
5939
5940 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5941
8c74fcbd
JD
59422011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5943
5944 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5945 later (Bug#8403).
5946
7200d79c
SM
59472011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5948
03408648 5949 Add lexical binding.
7200d79c 5950
03408648
SM
5951 * window.c (Ftemp_output_buffer_show): New fun.
5952 (Fsave_window_excursion):
5953 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5954
5955 * lread.c (lisp_file_lexically_bound_p): New function.
5956 (Fload): Bind Qlexical_binding.
5957 (readevalloop): Remove `evalfun' arg.
5958 Bind Qinternal_interpreter_environment.
5959 (Feval_buffer): Bind Qlexical_binding.
5960 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5961 Mark as dynamic.
5962 (syms_of_lread): Declare `lexical-binding'.
5963
5964 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5965
5966 * keyboard.c (eval_dyn): New fun.
5967 (menu_item_eval_property): Use it.
ca105506
SM
5968
5969 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5970
03408648
SM
5971 * fns.c (concat, mapcar1): Accept byte-code-functions.
5972
5973 * eval.c (Fsetq): Handle lexical vars.
5974 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5975 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5976 (FletX, Flet): Obey lexical binding.
5977 (Fcommandp): Handle closures.
5978 (Feval): New `lexical' arg.
5979 (eval_sub): New function extracted from Feval. Use it almost
5980 everywhere where Feval was used. Look up vars in lexical env.
5981 Handle closures.
5982 (Ffunctionp): Move from subr.el.
5983 (Ffuncall): Handle closures.
5984 (apply_lambda): Remove `eval_flags'.
5985 (funcall_lambda): Handle closures and new byte-code-functions.
5986 (Fspecial_variable_p): New function.
5987 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5988 but without exporting it to Lisp.
23aba0ea 5989
23aba0ea 5990 * doc.c (Fdocumentation, store_function_docstring):
03408648 5991 * data.c (Finteractive_form): Handle closures.
23aba0ea 5992
03408648
SM
5993 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5994 interactive spec.
ba83908c 5995
04f2d78b
CB
5996 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5997 New byte-codes.
03408648
SM
5998 (exec_byte_code): New function extracted from Fbyte_code to handle new
5999 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6000
03408648 6001 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6002
03408648 6003 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6004
e2abce01
JB
60052011-03-31 Juanma Barranquero <lekktu@gmail.com>
6006
6007 * xdisp.c (redisplay_internal): Fix prototype.
6008
63696a73 60092011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6010
63696a73 6011 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6012 (try_scrolling): Use it when setting scroll_limit.
6013 Limit scrolling to 100 screen lines.
63696a73
EZ
6014 (redisplay_window): Even when falling back on "recentering",
6015 position point in the window according to scroll-conservatively,
6016 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6017
6018 (try_scrolling): When point is above the window, allow searching
6019 as far as scroll_max, or one screenful, to compute vertical
6020 distance from PT to the scroll margin position. This prevents
6021 try_scrolling from unnecessarily failing when
6022 scroll-conservatively is set to a value slightly larger than the
6023 window height. Clean up the case of PT below the margin at bottom
6024 of window: scroll_max can no longer be INT_MAX. When aggressive
6025 scrolling is in use, don't let point enter the opposite scroll
6026 margin as result of the scroll.
6027 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6028 threshold of 100 lines for never-recentering scrolling.
6029
e4cc2dfc
JB
60302011-03-31 Juanma Barranquero <lekktu@gmail.com>
6031
6032 * dispextern.h (move_it_by_lines):
6033 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6034 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6035 (message_log_check_duplicate): Remove parameters `prev_bol' and
6036 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6037 (redisplay_internal): Remove parameter `preserve_echo_area',
6038 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6039
6040 * indent.c (Fvertical_motion):
6041 * window.c (window_scroll_pixel_based, Frecenter):
6042 Don't pass `need_y_p' to `move_it_by_lines'.
6043
1c470562
SM
60442011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6045
44f230aa
SM
6046 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6047 steal a few bits to be more compact.
6048 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6049 Remove unneeded casts.
6050
1c470562
SM
6051 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6052
888adce9
ZK
60532011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6054
6055 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6056 binding" message (bug#7967).
6057
f838ed7b
PE
60582011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6059
77861b95
PE
6060 Fix more problems found by GCC 4.6.0's static checks.
6061
de6dbc14
PE
6062 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6063 Remove unused local var.
6064
f838ed7b
PE
6065 * editfns.c (Fmessage_box): Remove unused local var.
6066
792c7b2b
PE
6067 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6068 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6069 Omit unused local vars.
c499e557 6070 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6071 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6072 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6073 Omit unused local var.
6074
ba0165e1
PE
6075 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6076 Don't assume string length fits in int.
32ad8845 6077 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6078 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6079
3c59b4c9
PE
6080 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6081 instead of alloca (Bug#8344).
6082
a3eed478 6083 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6084 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6085
eb4d412d
PE
6086 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6087
1658b401
PE
6088 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6089 concerns.
6090
6091 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6092
6093 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6094
9a2c6e05
PE
6095 * keyboard.c (syms_of_keyboard): Use the same style as later
6096 in this function when indexing through an array. This also
6097 works around GCC bug 48267.
6098
03d0a109
PE
6099 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6100
44f730c8
PE
6101 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6102
fe75f926
PE
6103 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6104 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6105
ffa8c828
PE
6106 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6107 This avoids undefined behavior on integer overflow, and is a bit
6108 more convenient anyway since it is compared to a size_t variable.
6109
c5101a77
PE
6110 Variadic C functions now count arguments with size_t, not int.
6111 This avoids an unnecessary limitation on 64-bit machines, which
6112 caused (substring ...) to crash on large vectors (Bug#8344).
6113 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6114 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6115 All variadic functions and their callers changed accordingly.
c5101a77
PE
6116 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6117 * data.c (arith_driver, float_arith_driver): Likewise.
6118 * editfns.c (general_insert_function): Likewise.
6119 * eval.c (struct backtrace.nargs, interactive_p)
6120 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6121 (funcall_lambda, mark_backtrace): Likewise.
6122 * fns.c (concat): Likewise.
6123 * frame.c (x_set_frame_parameters): Likewise.
6124 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6125 0 if not found, not -1. All callers changed.
6126
dd3f25f7
PE
6127 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6128 (stack_copy_size): Now size_t, not int.
6129 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6130
461c2ab9
JB
61312011-03-28 Juanma Barranquero <lekktu@gmail.com>
6132
6133 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6134 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6135 All callers changed.
6136
6137 * lisp.h (multibyte_char_to_unibyte):
6138 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6139 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6140 * character.h (CHAR_TO_BYTE8):
6141 * cmds.c (internal_self_insert):
6142 * editfns.c (general_insert_function):
6143 * keymap.c (push_key_description):
6144 * search.c (Freplace_match):
6145 * xdisp.c (message_dolog, set_message_1): All callers changed.
6146
f6d62986
SM
61472011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6148
6149 * keyboard.c (safe_run_hook_funcall): New function.
6150 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6151 don't set the hook to nil, but remove the offending function instead.
6152 (Qcommand_hook_internal): Remove, unused.
6153 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6154 Vcommand_hook_internal.
6155
6156 * eval.c (enum run_hooks_condition): Remove.
6157 (funcall_nil, funcall_not): New functions.
6158 (run_hook_with_args): Call each function through a `funcall' argument.
6159 Remove `cond' argument, now redundant.
6160 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6161 (Frun_hook_with_args_until_failure): Adjust accordingly.
6162 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6163
1db5b1ad
JB
61642011-03-28 Juanma Barranquero <lekktu@gmail.com>
6165
6166 * dispextern.h (string_buffer_position): Remove declaration.
6167
6168 * print.c (strout): Remove parameter `multibyte', unused since
6169 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6170
6171 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6172 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6173 All callers changed.
6174
6175 * w32.c (_wsa_errlist): Use braces for struct initializers.
6176
6177 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6178 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6179 All callers changed.
6180 (string_buffer_position): Likewise. Also, make static (it's never
6181 used outside xdisp.c).
6182 (cursor_row_p): Remove parameter `w', unused since
6183 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6184 (decode_mode_spec): Remove parameter `precision', introduced during
6185 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6186 All callers changed.
6187
5ffb62aa
JD
61882011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6189
6190 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6191
461c2ab9 61922011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6193
6194 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6195 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6196 (ns_update_auto_hide_menu_bar): New functions.
6197 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6198 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6199 ns_constrain_all_frames.
6200 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6201 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6202
5c380ffb
JD
62032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6204
6205 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6206
9af30bdf
GM
62072011-03-27 Glenn Morris <rgm@gnu.org>
6208
6209 * syssignal.h: Replace RETSIGTYPE with void.
6210 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6211 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6212 Replace SIGTYPE with void everywhere.
6213 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6214 * s/template.h (SIGTYPE): Remove commented out definition.
6215
e2abce01
JB
62162011-03-26 Eli Zaretskii <eliz@gnu.org>
6217
6218 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6219 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6220
f868cd8a
JB
62212011-03-26 Juanma Barranquero <lekktu@gmail.com>
6222
59eb0929
JB
6223 * w32.c (read_unc_volume): Use parameter `henum', instead of
6224 global variable `wget_enum_handle'.
6225
6226 * keymap.c (describe_vector): Remove parameters `indices' and
6227 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6228 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6229
f868cd8a
JB
6230 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6231
6232 * keyboard.c (timer_check): Remove parameter `do_it_now',
6233 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6234 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6235 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6236
6237 * keyboard.c (read_char):
6238 * w32menu.c (w32_menu_display_help):
6239 * xmenu.c (show_help_event, menu_help_callback):
6240 Adjust calls to `show_help_echo'.
6241
6242 * gtkutil.c (xg_maybe_add_timer):
6243 * keyboard.c (readable_events):
6244 * process.c (wait_reading_process_output):
6245 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6246
6247 * insdel.c (adjust_markers_gap_motion):
6248 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6249 (gap_left, gap_right): Don't call it.
6250
2ecf6fdb
CY
62512011-03-25 Chong Yidong <cyd@stupidchicken.com>
6252
6253 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6254 incurred during fontification.
6255
6b1f9ba4
JB
62562011-03-25 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6259 (DEFVAR_PER_BUFFER): Don't pass it.
6260
6261 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6262 (scrolling_window): Don't pass it.
6263
0f4a96b5
JB
62642011-03-25 Juanma Barranquero <lekktu@gmail.com>
6265
6266 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6267
6268 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6269 and `suffix'.
6270 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6271 of variables specific to SELinux and computation of `encoded_absname'.
6272
6273 * image.c (XPutPixel): Remove unused variable `height'.
6274
6275 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6276
6277 * unexw32.c (get_section_info): Remove unused variable `section'.
6278
6279 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6280 (system_process_attributes): Remove unused variable `sess'.
6281 (sys_read): Remove unused variable `err'.
6282
6283 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6284 (w32_wnd_proc): Remove unused variable `isdead'.
6285 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6286 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6287 (x_create_tip_frame): Remove unused variable `tem'.
6288
6289 * w32inevt.c (w32_console_read_socket):
6290 Remove unused variable `no_events'.
6291
6292 * w32term.c (x_draw_composite_glyph_string_foreground):
6293 Remove unused variable `width'.
6294
1149507c
JB
62952011-03-24 Juanma Barranquero <lekktu@gmail.com>
6296
6297 * w32term.c (x_set_glyph_string_clipping):
6298 Don't pass uninitialized region to CombineRgn.
6299
9c88f339
JB
63002011-03-23 Juanma Barranquero <lekktu@gmail.com>
6301
6302 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6303 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6304 (Fx_close_connection): Remove unused variable `i'.
6305
6306 * w32font.c (w32font_draw): Return number of glyphs.
6307 (w32font_open_internal): Remove unused variable `i'.
6308 (w32font_driver): Add missing initializer.
6309
6310 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6311 (fill_in_menu): Remove unused variable `items_added'.
6312
6313 * w32term.c (last_mouse_press_frame): Remove static global variable.
6314 (w32_clip_to_row): Remove unused variable `f'.
6315 (x_delete_terminal): Remove unused variable `i'.
6316
6317 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6318 (NOTHING): Remove unused static global variable.
6319 (uniscribe_check_otf): Remove unused variable `table'.
6320 (uniscribe_font_driver): Add missing initializers.
6321
dee091a3
JD
63222011-03-23 Julien Danjou <julien@danjou.info>
6323
6324 * term.c (Fsuspend_tty, Fresume_tty):
6325 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6326 * window.c (temp_output_buffer_show):
6327 * insdel.c (signal_before_change):
6328 * frame.c (Fhandle_switch_frame):
6329 * fileio.c (Fdo_auto_save):
6330 * emacs.c (Fkill_emacs):
6331 * editfns.c (save_excursion_restore):
6332 * cmds.c (internal_self_insert):
6333 * callint.c (Fcall_interactively):
6334 * buffer.c (Fkill_all_local_variables):
6335 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6336 Use Frun_hooks.
0f4a96b5 6337 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6338 unconditionnaly since it does the check itself.
6339
2c520ab5 63402011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6341
c9c49752
PE
6342 Fix more problems found by GCC 4.5.2's static checks.
6343
8abc3f12
PE
6344 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6345 the first time through the loop, since we know p0 < p1 then.
6346 This also avoids a gcc -Wstrict-overflow warning.
6347
a2d26660
PE
6348 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6349 leading to a memory leak, possible in functions like
6350 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6351 of objects (Bug#8318).
a2d26660 6352
916c72e9
PE
6353 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6354 that could (at least in theory) be that large.
6355
19ab8a18
PE
6356 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6357 This is less likely to overflow, and avoids undefined behavior if
6358 overflow does occur. All callers changed. Use strtoul to scan
6359 for the unsigned long integer.
b7cbbd6f
PE
6360 (pint2hrstr): Simplify and tune code slightly.
6361 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6362
f0641eff
PE
6363 * scroll.c (do_scrolling): Work around GCC bug 48228.
6364 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6365
7f650bb9
PE
6366 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6367 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6368 (validate_x_resource_name): Simplify count usage.
6369 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6370
37dd57d1
PE
6371 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6372 fail (Bug#8306).
81e56e61 6373
699979fc 6374 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6375
401bf9b4
PE
6376 * process.c (Fmake_network_process): Use socklen_t, not int,
6377 where POSIX says socklen_t is required in portable programs.
6378 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6379 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6380 (Fmake_network_process, server_accept_connection):
6381 (wait_reading_process_output, read_process_output):
6382 Likewise.
6383
b93aacde
PE
6384 * process.c: Rename or move locals to avoid shadowing.
6385 (list_processes_1, Fmake_network_process):
6386 (read_process_output_error_handler, exec_sentinel_error_handler):
6387 Rename or move locals.
4dc343ee 6388 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6389 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6390 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6391 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6392 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6393
af8a867c 6394 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6395 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6396 Include tparam.h instead, since it declares them.
af8a867c
PE
6397 * cm.h (PC): Remove extern decl; tparam.h now does this.
6398 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6399 * terminfo.c: Include tparam.h, to check interfaces.
6400 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6401 (tparam): Adjust signature to match interface in tparam.h;
6402 this removes some undefined behavior. Check that outstring and len
6403 are zero, which they always are with Emacs.
6404 * tparam.h (PC, BC, UP): New extern decls.
6405
0248044d 6406 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6407 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6408
8ff096c1 6409 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6410 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6411 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6412 (ftfont_list): Remove unused local.
49eaafba
PE
6413 (get_adstyle_property, ftfont_pattern_entity):
6414 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6415 Rename locals to avoid shadowing.
8ff096c1 6416
e2be39f6
PE
6417 * xfont.c (xfont_list_family): Mark var as initialized.
6418
c9735e30
PE
6419 * xml.c (make_dom): Now static.
6420
8f5201ae
PE
6421 * composite.c (composition_compute_stop_pos): Rename local to
6422 avoid shadowing.
b246f932
PE
6423 (composition_reseat_it): Remove unused locals.
6424 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6425 (composition_update_it): Mark var as initialized.
11b61122
PE
6426 (find_automatic_composition): Mark vars as initialized,
6427 with a FIXME (Bug#8290).
8f5201ae 6428
760fbc2c
PE
6429 character.h: Rename locals to avoid shadowing.
6430 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6431 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6432 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6433 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6434 to avoid shadowing.
6435
ff08eb85
PE
6436 * textprop.c (property_change_between_p): Remove; unused.
6437
fc7bf025
PE
6438 * intervals.c (interval_start_pos): Now static.
6439
235d7abc
PE
6440 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6441
44f230aa
SM
6442 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6443 Rename locals to avoid shadowing.
3e7d6594 6444
50060332
PE
6445 * sound.c (wav_play, au_play, Fplay_sound_internal):
6446 Fix pointer signedness.
d01f234b 6447 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6448 (wav_play): Initialize a variable to 0, to prevent undefined
6449 behavior (Bug#8278).
50060332 6450
c4fc4e30
PE
6451 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6452
918436ed
PE
6453 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6454
c939f91b
PE
6455 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6456 clobbering (Bug#8298).
b9c7f648
PE
6457 * sysdep.c (sys_subshell): Likewise.
6458 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6459
6bd8c144
PE
6460 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6461 This should get cleaned up, so that child_setup has the
6462 same signature on all platforms.
6463
7710357c 6464 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6465 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6466
c59da222
CY
64672011-03-22 Chong Yidong <cyd@stupidchicken.com>
6468
6469 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6470 not to be necessary, and produces flickering.
6471
66b87493
GM
64722011-03-20 Glenn Morris <rgm@gnu.org>
6473
6474 * config.in: Remove file.
6475
45b6f6d5
JB
64762011-03-20 Juanma Barranquero <lekktu@gmail.com>
6477
6478 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6479 are now in src/globals.h.
6480 (syms_of_minibuf): Remove spurious & from previous change.
6481
3ec03f7e
LL
64822011-03-20 Leo <sdl.web@gmail.com>
6483
6484 * minibuf.c (completing-read-function): New variable.
6485 (completing-read-default): Rename from completing-read.
6486 (completing-read): Call completing-read-function.
6487
b14e3e21
CY
64882011-03-19 Juanma Barranquero <lekktu@gmail.com>
6489
6490 * xfaces.c (Fx_load_color_file):
6491 Read color file from absolute filename (bug#8250).
6492
f2b726e6
JB
64932011-03-19 Juanma Barranquero <lekktu@gmail.com>
6494
6495 * makefile.w32-in: Update dependencies.
6496
09f6ff02
EZ
64972011-03-17 Eli Zaretskii <eliz@gnu.org>
6498
6499 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6500
29a6015a
PE
65012011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6502
a3a6c54e
PE
6503 Fix more problems found by GCC 4.5.2's static checks.
6504
b766f867
PE
6505 * process.c (make_serial_process_unwind, send_process_trap):
6506 (sigchld_handler): Now static.
6507
be02381c
PE
6508 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6509 That way, the code declares only the vars that it needs.
6510 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6511 * s/cygwin.h (PTY_ITERATION): Likewise.
6512 * s/darwin.h (PTY_ITERATION): Likewise.
6513 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6514
57048744
PE
6515 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6516 * process.c (allocate_pty): Don't declare stb unless it's needed.
6517
7914961c 6518 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6519 (CONSTANTLIM): Remove; unused.
6520 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6521 Define only if needed.
7914961c 6522
b3967b18
PE
6523 * unexelf.c (unexec): Name an expression,
6524 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6525 Use a different way to cause a compilation error if anyone uses
6526 n rather than nn, a way that does not involve shadowing.
73366a00 6527 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6528
29a6015a
PE
6529 * deps.mk (unexalpha.o): Remove; unused.
6530
43cfc33e 6531 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6532 * unexec.h: New file.
ce701a33
PE
6533 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6534 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6535 Depend on unexec.h.
6536 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6537 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6538 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6539 Change as necessary to match prototype in unexec.h.
ce701a33 6540
01f44d5a
PE
6541 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6542 shadowing.
4f63c6bb 6543 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6544
a6670b0b
PE
6545 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6546 Rename locals to avoid shadowing.
6547
cef2010d 6548 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6549 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6550
d4d7173a
PE
6551 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6552
f08b802a
PE
6553 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6554 warning when compiling print.c.
6555
3ddb0639
PE
6556 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6557 instead of using an uninitialized var.
5ad03b97 6558 (font_sort_entities): Mark var as initialized.
3ddb0639 6559
170a2692
PE
6560 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6561
e663c700
PE
6562 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6563 pointers to constants.
89bc529a 6564 (font_parse_fcname): Remove unused vars.
7b81e2d0 6565 (font_delete_unmatched): Now static.
ea838e10 6566 (font_get_spec): Remove; unused.
13a547c6
PE
6567 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6568 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6569 Rename or move locals to avoid shadowing.
e663c700 6570
2a80c887 6571 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6572 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6573
1384fa33 6574 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6575 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6576
8b2c52e9
PE
6577 * alloc.c (mark_backtrace): Move decl from here ...
6578 * lisp.h: ... to here, so that it can be checked.
6579
475545b5 6580 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6581 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6582 (lisp_indirect_variable): Name an expression,
6583 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6584 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6585
b1349114 6586 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6587 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6588 Use const pointer when appropriate.
b1349114 6589
a2928364
PE
6590 * lisp.h (get_system_name, get_operating_system_release):
6591 Move decls here, to check interfaces.
6592 * process.c (get_operating_system_release): Move decl to lisp.h.
6593 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6594 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6595 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6596 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6597 (Fformat_time_string, Fencode_time, Finsert_char):
6598 (Ftranslate_region_internal, Fformat):
6599 Rename or remove local vars to avoid shadowing.
9710023e 6600 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6601
a415e694
PE
6602 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6603 avoid shadowing.
6604
8ef4622d
PE
6605 * lisp.h (eassert): Check that the argument compiles, even if
6606 ENABLE_CHECKING is not defined.
6607
946f9a5b
PE
6608 * data.c (Findirect_variable): Name an expression, to avoid
6609 gcc -Wbad-function-cast warning.
112396d6 6610 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6611 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6612 (Fmake_variable_buffer_local, Fmake_local_variable):
6613 Mark variables as initialized.
52746918 6614 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6615
e5aab7e7 6616 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6617 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6618 Rename locals to avoid shadowing.
dff45157
PE
6619 (mark_stack): Move local variables into the #ifdef region where
6620 they're used.
7bc26fdb
PE
6621 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6622 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6623 needed otherwise.
6624 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6625 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6626 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6627
e5aab7e7
PE
6628 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6629 avoids undefined behavior in theory.
6630
4da60324
PE
6631 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6632
88043301
PE
6633 Use functions, not macros, for up- and down-casing (Bug#8254).
6634 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6635 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6636 to use the following functions instead of these macros.
6637 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6638 EMACS_INT, since callers assume the returned value fits in int.
6639 (upcase1): Likewise, for UPCASE_TABLE.
6640 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6641 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6642 the race-condition problem in the old DOWNCASE.
88043301 6643
19ed5445
PE
6644 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6645 Rename locals to avoid shadowing.
6646 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6647 (regex_compile, re_search_2, re_match_2_internal):
6648 Remove unused local vars.
952db0d7
PE
6649 (FREE_VAR): Rewrite so as not to use empty "else",
6650 which gcc can warn about.
da053e48 6651 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6652 (RETALLOC_IF): Define only if needed.
6653 (WORDCHAR_P): Likewise. This one is never needed, but is used
6654 only in a comment talking about a compiler bug, so put inside
6655 the #if 0 of that comment.
6656 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6657 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6658 Remove; unused.
19ed5445 6659
1f3561e4 6660 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6661 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6662 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6663
ded6f8f7
PE
6664 * search.c (simple_search): Remove unused var.
6665
dbd37a95
PE
6666 * dired.c (compile_pattern): Move decl from here ...
6667 * lisp.h: ... to here, so that it can be checked.
6668 (struct re_registers): New forward decl.
6669
7e47afad
PE
6670 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6671
85f24f61
PE
6672 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6673 All uses changed.
6674 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6675 Rename locals to avoid shadowing.
5671df8f 6676 (Fvertical_motion): Mark locals as initialized.
85f24f61 6677
181aa2be 6678 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6679 (casify_region): Mark local as initialized.
181aa2be 6680
930d429c
PE
6681 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6682
7082eac6
PE
6683 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6684 New macros, so that the caller can use some names other than
6685 gcpro1, gcpro2, etc.
6686 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6687 of the new macros.
6688 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6689 argument, for consistency with GCPRO2_VAR, etc: it is now the
6690 prefix of the variable, not the variable itself. All uses
6691 changed.
38b2c076
PE
6692 * dired.c (directory_files_internal, file_name_completion):
6693 Rename locals to avoid shadowing.
6694
15206ed9
PE
6695 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6696 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6697 dired.c's scmp function, had undefined behavior.
6698 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6699 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6700 * buffer.h: ... to here, because these macros use current_buffer,
6701 and the new implementation with inline functions needs to have
6702 current_buffer in scope now, rather than later when the macros
6703 are used.
6704 (downcase, upcase1): New static inline functions.
6705 (DOWNCASE, UPCASE1): Reimplement using these functions.
6706 This avoids undefined behavior in expressions like
6707 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6708 from race conditions in accessing the global variables
6709 case_temp1 and case_temp2.
6710 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6711 * lisp.h (case_temp1, case_temp2): Remove their decls.
6712 * character.h (ASCII_CHAR_P): Move from here ...
6713 * lisp.h: ... to here, so that the inline functions mentioned
6714 above can use them.
6715
4a6bea26
PE
6716 * dired.c (directory_files_internal_unwind): Now static.
6717
f14b7e14
PE
6718 * fileio.c (file_name_as_directory, directory_file_name):
6719 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6720 Now static.
2893f146
PE
6721 (file_name_as_directory): Use const pointers when appropriate.
6722 (Fexpand_file_name): Likewise. In particular, newdir might
6723 point at constant storage, so make it a const pointer.
fd4ead52 6724 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6725 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6726 signedness issues.
f839df0c
PE
6727 (Fset_file_times, Finsert_file_contents, auto_save_error):
6728 Rename locals to avoid shadowing.
f14b7e14 6729
5716756e 6730 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6731 (Ftry_completion, Fall_completions): Rename or remove locals
6732 to avoid shadowing.
5716756e 6733
b4c3046a
PE
6734 * marker.c (bytepos_to_charpos): Remove; unused.
6735
b45db522
PE
6736 * lisp.h (verify_bytepos, count_markers): New decls,
6737 so that gcc does not warn that these functions aren't declared.
6738
85876d07
PE
6739 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6740 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6741 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6742 (copy_text): Remove unused local var.
85876d07 6743
03d78a21 6744 * filelock.c (within_one_second): Now static.
b3dd38ab 6745 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6746
5df8f01b
PE
6747 * buffer.c (fix_overlays_before): Mark locals as initialized.
6748 (fix_start_end_in_overlays): Likewise. This function should be
6749 simplified by using pointers-to-pointers, but that's a different
6750 matter.
b1d876f1 6751 (switch_to_buffer_1): Now static.
8f54f30a
PE
6752 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6753 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6754
a70072c9 6755 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6756 Fix pointer signedness issue.
edced198
PE
6757 (sys_subshell): Mark local as volatile if checking for lint,
6758 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6759 (MAXPATHLEN): Define only if needed.
a70072c9 6760
a0977c44
PE
6761 * process.c (serial_open, serial_configure): Move decls from here ...
6762 * systty.h: ... to here, so that they can be checked.
6763
a884fdcc
PE
6764 * fns.c (get_random, seed_random): Move extern decls from here ...
6765 * lisp.h: ... to here, so that they can be checked.
6766
604efe86 6767 * sysdep.c (reset_io): Now static.
b8950c94 6768 (wait_for_termination_signal): Remove; unused.
604efe86 6769
38fc62d9
PE
6770 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6771 (copy_keymap_item, append_key, push_text_char_description):
6772 Now static.
1004a21a 6773 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6774 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6775 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6776 (describe_map_tree):
6777 Rename locals to avoid shadowing.
38fc62d9 6778
2f2650da
PE
6779 * keyboard.c: Declare functions static if they are not used elsewhere.
6780 (echo_char, echo_dash, cmd_error, top_level_2):
6781 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6782 (read_char, kbd_buffer_get_event, make_lispy_position):
6783 (make_lispy_event, make_lispy_movement, apply_modifiers):
6784 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6785 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6786 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6787 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6788 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6789
a053e86c 6790 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6791 (mark_kboards): Move decl here ...
6792 * alloc.c (mark_kboards): ... from here.
a053e86c 6793
4752793e
PE
6794 * lisp.h (force_auto_save_soon): New decl.
6795
74f10ca7 6796 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6797 (DEFINE_DUMMY_FUNCTION): New macro.
6798 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6799 Use it.
c03cd23f
PE
6800 (main): Add casts to avoid warnings
6801 if GCC considers string literals to be constants.
74f10ca7 6802
022e70d4
PE
6803 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6804
59d6fe83
PE
6805 * dbusbind.c: Pointer signedness fixes.
6806 (xd_signature, xd_append_arg, xd_initialize):
6807 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6808 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6809 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6810 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6811
78320123
PE
6812 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6813 if GCC considers string literals to be constants.
49cebcca 6814 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6815
35ac2a97
SM
68162011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6817
fb103ca9
SM
6818 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6819 (print_preprocess, print_object): New macro to fix last change.
6820
35ac2a97
SM
6821 * print.c (print_preprocess): Don't forget font objects.
6822
62973b41
JB
68232011-03-16 Juanma Barranquero <lekktu@gmail.com>
6824
6825 * emacs.c (USAGE3): Doc fixes.
6826
0e48bb22
AS
68272011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6828
6829 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6830 structure.
6831
7684e57b
JB
68322011-03-14 Juanma Barranquero <lekktu@gmail.com>
6833
6834 * lisp.h (VWindow_system, Qfile_name_history):
6835 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6836 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6837 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6838
6839 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6840 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6841
6842 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6843 * w32console.c (detect_input_pending, read_input_pending)
6844 (encode_terminal_code):
6845 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6846 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6847 (w32_system_caret_y, Qfile_name_history):
6848 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6849 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6850 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6851 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6852 * w32proc.c (Qlocal, report_file_error):
6853 * w32term.c (Vwindow_system, updating_frame):
6854 * w32uniscribe.c (initialized, uniscribe_font_driver):
6855 Remove unneeded extern declarations.
6856
2aa46d6c
CY
68572011-03-14 Chong Yidong <cyd@stupidchicken.com>
6858
c96bbc66 6859 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6860
cffc6f3b
CY
68612011-03-13 Chong Yidong <cyd@stupidchicken.com>
6862
6863 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6864 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6865 These macros can no longer be used for assignment.
6866
44f230aa
SM
6867 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6868 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6869 (record_buffer_markers, fetch_buffer_markers): New functions for
6870 recording and fetching special buffer markers.
6871 (set_buffer_internal_1, set_buffer_temp): Use them.
6872
6873 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6874
6875 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6876
6877 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6878 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6879
6880 * xdisp.c (hscroll_window_tree):
6881 (reconsider_clip_changes): Use PT instead of BUF_PT.
6882
d251f04b
EZ
68832011-03-13 Eli Zaretskii <eliz@gnu.org>
6884
6885 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6886 $(EMACS_ROOT)/lib/intprops.h.
6887
f0c77cd1
PE
68882011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6889
3eca4629
PE
6890 Fix more problems found by GCC 4.5.2's static checks.
6891
7c86ee98
PE
6892 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6893 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6894 (xg_free_frame_widgets): Make it clear that a local variable is
6895 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6896 (gdk_window_get_screen): Make it clear that this macro is needed
6897 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6898 (int_gtk_range_get_value): New function, which avoids a diagnostic
6899 from gcc -Wbad-function-cast.
6900 (xg_set_toolkit_scroll_bar_thumb): Use it.
6901 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6902 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6903 (get_utf8_string, xg_get_file_with_chooser):
6904 Rename locals to avoid shadowing.
6905 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6906
41729b81
PE
6907 * xgselect.c (xg_select): Remove unused var.
6908
f0c77cd1
PE
6909 * image.c (four_corners_best): Mark locals as initialized.
6910 (gif_load): Initialize transparent_p to zero (Bug#8238).
6911 Mark another local as initialized.
ec6cf4c6 6912 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6913
ce0ad53d 6914 * image.c (clear_image_cache): Now static.
d5d5a617 6915 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6916 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6917 (x_edge_detection): Remove unnecessary cast that
6918 gcc -Wbad-function-cast diagnoses.
2037898d 6919 (gif_load): Fix pointer signedness.
6ae141d6
PE
6920 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6921 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6922
33383987 69232011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6924
d32df629
PE
6925 Improve quality of tests for time stamp overflow.
6926 For example, without this patch (encode-time 0 0 0 1 1
6927 1152921504606846976) returns the obviously-bogus value (-948597
6928 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6929 reports time overflow. See
6930 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6931 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6932 * editfns.c: Include limits.h and intprops.h.
6933 (TIME_T_MIN, TIME_T_MAX): New macros.
6934 (time_overflow): Move earlier, to before first use.
6935 (hi_time, lo_time): New functions, for an accurate test for
6936 out-of-range times.
6937 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6938 (Fget_internal_run_time): Don't assume time_t fits in int.
6939 (make_time): Use list2 instead of Fcons twice.
6940 (Fdecode_time): More accurate test for out-of-range times.
6941 (check_tm_member): New function.
6942 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6943 (lisp_time_argument): Don't rely on undefined left-shift and
6944 right-shift behavior when checking for time stamp overflow.
8be6f318 6945
fe31d94c
PE
6946 * editfns.c (time_overflow): New function, refactoring common code.
6947 (Fformat_time_string, Fdecode_time, Fencode_time):
6948 (Fcurrent_time_string): Use it.
6949
8be6f318
PE
6950 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6951 * dired.c (make_time): Move to ...
6952 * editfns.c (make_time): ... here.
6953 * systime.h: Note the move.
6954
09d9db2c 69552011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6956
126bc0dc
YM
6957 * fringe.c (update_window_fringes): Remove unused variables.
6958
c47cbdfd
YM
6959 * unexmacosx.c (copy_data_segment): Also copy __got section.
6960 (Bug#8223)
6961
7ac80be9
EZ
69622011-03-12 Eli Zaretskii <eliz@gnu.org>
6963
c96bbc66 6964 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6965 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6966 Constify `char *' arguments and their references according to
6967 prototypes in tparam.h.
6968
ecb0f94d 6969 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6970
7ac80be9
EZ
6971 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6972 Adapt all references accordingly.
6973
6974 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6975
ef1fd07e
TT
69762011-03-11 Tom Tromey <tromey@redhat.com>
6977
6978 * buffer.c (syms_of_buffer): Remove obsolete comment.
6979
7ef4b50c
EZ
69802011-03-11 Eli Zaretskii <eliz@gnu.org>
6981
6982 * termhooks.h (encode_terminal_code): Declare prototype.
6983
6984 * msdos.c (encode_terminal_code): Don't declare prototype.
6985
6986 * term.c (encode_terminal_code): Now external again, used by
6987 w32console.c and msdos.c.
6988
44f230aa
SM
6989 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6990 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6991
4b1ec863 69922011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6993
1714f52b 6994 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6995
4b1ec863
PE
6996 * fringe.c (update_window_fringes): Mark locals as initialized
6997 (Bug#8227).
6998 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6999
524c7aa6
PE
7000 * alloc.c (mark_fringe_data): Move decl from here ...
7001 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7002 to check its interface.
7003 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7004
a5c0af81 7005 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7006 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7007 (fontset_font): Mark local as initialized.
a9a06e0b 7008 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7009
b4716021
PE
7010 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7011
811e9bac 7012 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7013 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7014 (x_own_selection, Fx_disown_selection_internal): Rename locals
7015 to avoid shadowing.
7016 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7017
7e3ab302
PE
7018 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7019 so that the caller can use some name other than gcpro1.
7020 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7021 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7022 (Fx_backspace_delete_keys_p):
7023 Use them to avoid shadowing, and rename vars to avoid shadowing.
7024 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7025 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7026 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7027 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7028 Remove unused locals.
7e3ab302
PE
7029 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7030 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7031 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7032 macros.
f78faa98 7033
e2b13473
PE
7034 * xterm.h (x_mouse_leave): New decl.
7035
77f23912
PE
7036 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7037 Remove unused functions.
cdf4ba58
PE
7038 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7039 (x_calc_absolute_position): Now static.
7411c686 7040 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7041 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7042 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7043 unless they are used.
38d0b34a
PE
7044 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7045 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7046 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7047 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7048 (x_error_catcher, x_connection_closed, x_error_handler):
7049 (x_error_quitter, xembed_send_message, x_iconify_frame):
7050 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7051 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7052 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7053
44f230aa
SM
7054 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7055 Rename or move locals to avoid shadowing.
6b463e58 7056 (tty_defined_color, merge_face_heights): Now static.
5967d051 7057 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7058 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7059 does not deduce is never used uninitialized.
73719eba
PE
7060 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7061 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7062
426994c3 7063 * terminal.c (store_terminal_param): Now static.
5489860b 7064
032f1620 7065 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7066 (set_frame_menubar): Remove unused local.
d4323972 7067 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7068 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7069 since they might point to immutable storage.
281585b0
PE
7070 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7071 since it's unused otherwise.
032f1620 7072
367c19e5 7073 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7074 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7075 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7076 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7077 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7078 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7079 does not deduce are never used uninitialized.
70739cbe 7080
07b48fa9
PE
7081 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7082
8868a238 7083 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7084 * window.c (window_loop, size_window):
7085 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7086
7e5cf297 7087 * window.c (display_buffer): Now static.
d6550a9f
PE
7088 (size_window): Mark variables that gcc -Wuninitialized
7089 does not deduce are never used uninitialized.
a586633d
PE
7090 * window.h (check_all_windows): New decl, to forestall
7091 gcc -Wmissing-prototypes diagnostic.
5b555da1 7092 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7093
f6095868
PE
7094 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7095 shadowing.
7096 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7097 Include <limits.h>.
7098 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7099 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7100 (load_charset_map): Mark variables that gcc -Wuninitialized
7101 does not deduce are never used uninitialized.
53df7c11 7102 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7103
f38b440c
PE
7104 * coding.c (coding_set_source, coding_set_destination):
7105 Use "else { /* comment */ }" rather than "else /* comment */;"
7106 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7107 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7108 a block, when the outer 'i' will do.
7109 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7110 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7111 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7112 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7113 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7114 Rename locals to avoid shadowing.
7115 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7116 * coding.c (emacs_mule_char, encode_invocation_designation):
7117 Now static, since they're not used elsewhere.
413bb2db 7118 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7119 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7120 (decode_coding_emacs_mule): Mark variables that gcc
7121 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7122 (detect_coding_iso_2022): Initialize a local variable that might
7123 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7124 this initialization is needed. (Bug#8211)
5f58e762
PE
7125 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7126 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7127 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7128 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7129 Remove unused macros.
f38b440c 7130
232b38b9 7131 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7132 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7133 * character.c (string_count_byte8): Likewise.
232b38b9 7134
fb90da1b
PE
7135 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7136 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7137
fb93dbc2
PE
7138 * chartab.c (copy_sub_char_table): Now static, since it's not used
7139 elsewhere.
5c156ace
PE
7140 (sub_char_table_ref_and_range, char_table_ref_and_range):
7141 Rename locals to avoid shadowing.
bbcd0949 7142 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7143
7d3b3862 7144 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7145 (BIDI_BOB): Remove unused macro.
7d3b3862 7146
6be7d3da
PE
7147 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7148 deduce are never used uninitialized.
c2ed9c8b 7149 * term.c (encode_terminal_code): Likewise.
6be7d3da 7150
75f8807f 7151 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7152
50938595
PE
7153 * tparam.h: New file.
7154 * term.c, tparam.h: Include it.
7155 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7156 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7157 Move these decls to tparam.h, and make them agree with what
7158 is actually in tparam.c. The previous trick of using incompatible
7159 decls in different modules does not conform to the C standard.
7160 All callers of tparam changed to use tparam's actual API.
7161 * tparam.c (tparam1, tparam, tgoto):
7162 Use const pointers where appropriate.
7163
fbceeba2
PE
7164 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7165 * cm.h (struct cm): Likewise.
7166 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7167 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7168 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7169 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7170 (turn_on_face, init_tty): Likewise.
7171 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7172
7f3f1250
PE
7173 * term.c (term_mouse_position): Rename local to avoid shadowing.
7174
e6ca6543
PE
7175 * alloc.c (mark_ttys): Move decl from here ...
7176 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7177
c40f8d15
AS
71782011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7179
7180 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7181
cfe0661d
JB
71822011-03-09 Juanma Barranquero <lekktu@gmail.com>
7183
7184 * search.c (compile_pattern_1): Remove argument regp, unused since
7185 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7186 (compile_pattern): Don't pass it.
7187
0afb4571
J
71882011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7189
7190 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7191 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7192 for ! HAVE_GTK3.
7193 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7194
7195 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7196
7197 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7198 gdk_window_get_screen, gdk_window_get_geometry,
7199 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7200 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7201 (xg_get_pixbuf_from_pixmap): New function.
7202 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7203 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7204 Call xg_get_pixbuf_from_pixmap instead of
7205 gdk_pixbuf_get_from_drawable.
7206 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7207 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7208 (xg_check_special_colors): Use GtkStyleContext and its functions
7209 for HAVE_GTK3.
7210 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7211 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7212 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7213 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7214 Call gtk_widget_get_preferred_size.
0afb4571
J
7215 (xg_frame_resized): gdk_window_get_geometry only takes 5
7216 parameters.
44f230aa
SM
7217 (xg_win_to_widget, xg_event_is_for_menubar):
7218 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7219 (xg_set_widget_bg): New function.
7220 (delete_cb): New function.
895009e1 7221 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7222 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7223 (xg_set_background_color): Call xg_set_widget_bg.
7224 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7225 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7226 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7227 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7228 if ! HAVE_GTK3.
7229 (update_frame_tool_bar): Call gtk_widget_hide.
7230 (xg_initialize): Use GDK_KEY_g.
7231
7232 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7233 if ! HAVE_GTK3
7234 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7235
7236 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7237 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7238 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7239
1c2cc4ef
JB
72402011-03-08 Juanma Barranquero <lekktu@gmail.com>
7241
7242 * w32xfns.c (select_palette): Check success of RealizePalette against
7243 GDI_ERROR, not zero.
7244
33383987 7245See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7246
7247;; Local Variables:
7248;; coding: utf-8
aac0c6e3
MR
7249;; End:
7250
33383987 7251 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7252
7253 This file is part of GNU Emacs.
7254
7255 GNU Emacs is free software: you can redistribute it and/or modify
7256 it under the terms of the GNU General Public License as published by
7257 the Free Software Foundation, either version 3 of the License, or
7258 (at your option) any later version.
7259
7260 GNU Emacs is distributed in the hope that it will be useful,
7261 but WITHOUT ANY WARRANTY; without even the implied warranty of
7262 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7263 GNU General Public License for more details.
7264
7265 You should have received a copy of the GNU General Public License
7266 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.