registry.el (registry-reindex): Fix percentage message.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ff4de4aa
TZ
12011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2
3 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5 as passed in.
6
abe95abb
JD
72011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8
9 * xterm.c (x_set_frame_alpha): Do not set property on anything
10 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11
e16e55d4
JB
122011-05-02 Juanma Barranquero <lekktu@gmail.com>
13
14 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15
bafcf6a5
JB
162011-05-02 Juanma Barranquero <lekktu@gmail.com>
17
18 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
19 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
20 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
21 (gnutls_global_initialized, Qgnutls_bootprop_priority)
22 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
23 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
24 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
25 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
26 (Qgnutls_bootprop_callbacks_verify): Make static.
27
e7a6747f
AS
282011-05-01 Andreas Schwab <schwab@linux-m68k.org>
29
19ed11ba
AS
30 * callproc.c: Indentation fixup.
31
e7a6747f
AS
32 * sysdep.c (wait_for_termination_1): Make static.
33 (wait_for_termination, interruptible_wait_for_termination): Move
34 after wait_for_termination_1.
35
1ef14cb4
LMI
362011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
37
38 * sysdep.c (interruptible_wait_for_termination): New function
39 which is like wait_for_termination, but allows keyboard
40 interruptions.
41
42 * callproc.c (Fcall_process): Add (:file "file") as an option for
43 the STDOUT buffer.
44 (Fcall_process_region): Ditto.
45
330d880c
EZ
462011-04-30 Eli Zaretskii <eliz@gnu.org>
47
8db90b73
EZ
48 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
49 rather than `XVECTOR (FOO)->size'.
50
330d880c
EZ
51 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
52 inttypes.h, as a gnulib replacement is used if it not available in
53 system headers.
54
15cbd324
EZ
552011-04-21 Eli Zaretskii <eliz@gnu.org>
56
57 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
58 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
59 of MOST_POSITIVE_FIXNUM. (Bug#8528)
60
61 * coding.c (coding_alloc_by_realloc): Error out if destination
62 will grow beyond MOST_POSITIVE_FIXNUM.
63 (decode_coding_emacs_mule): Abort if there isn't enough place in
64 charbuf for the composition carryover bytes. Reserve an extra
65 space for up to 2 characters produced in a loop.
66 (decode_coding_iso_2022): Abort if there isn't enough place in
67 charbuf for the composition carryover bytes.
68
692011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 70
ae940cca
EZ
71 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
72 aborting when %lld or %lll format is passed.
73 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
74 %llo or %llx format is passed. (Bug#8545)
75
03ab8921
EZ
76 * window.c (window_scroll_line_based): Use a marker instead of
77 simple variables to record original value of point. (Bug#7952)
78
afda1437
EZ
79 * doprnt.c (doprnt): Fix the case where a multibyte sequence
80 produced by %s or %c overflows available buffer space. (Bug#8545)
81
f76dee0c
PE
822011-04-28 Paul Eggert <eggert@cs.ucla.edu>
83
84 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 85 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 86
fdc5744d
JB
872011-04-28 Juanma Barranquero <lekktu@gmail.com>
88
89 * w32.c (init_environment): Warn about defaulting HOME to C:\.
90
638f053a
JB
912011-04-28 Juanma Barranquero <lekktu@gmail.com>
92
93 * keyboard.c (Qdelayed_warnings_hook): Define.
94 (command_loop_1): Run `delayed-warnings-hook'
95 if Vdelayed_warnings_list is non-nil.
96 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
97 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
98
d178f871
EZ
992011-04-28 Eli Zaretskii <eliz@gnu.org>
100
101 * doprnt.c (doprnt): Don't return value smaller than the buffer
102 size if the message was truncated. (Bug#8545).
103
b124fd93
JB
1042011-04-28 Juanma Barranquero <lekktu@gmail.com>
105
106 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
107 (Fx_window_property): #if-0 the whole functions, not just the bodies.
108
e810457d
PE
1092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
110
111 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
112
ea51cceb
JB
1132011-04-27 Juanma Barranquero <lekktu@gmail.com>
114
115 * makefile.w32-in: Update dependencies.
116
94dcfacf
EZ
1172011-04-27 Eli Zaretskii <eliz@gnu.org>
118
119 Improve `doprnt' and its usage. (Bug#8545)
120 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
121 `format_end'. Remove support for %l as a conversion specifier.
122 Don't use xrealloc. Improve diagnostics when the %l size modifier
123 is used. Update the commentary.
124
125 * eval.c (verror): Simplify calculation of size_t.
126
127 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
128 messages.
129
f61f41d7
PE
1302011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
131
132 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
133 change.
134
96fb4434
PE
1352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
136
137 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
138 This makes this file independent of the recent pseudovector change.
139
671875da 1402011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 141
69e9b5a3
PE
142 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
143
b5f869a7 144 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 145 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 146 Remove unused local.
c8926152 147 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 148
841a1577 149 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
150 GCC 4.6.0 optimizes based on type-based alias analysis. For
151 example, if b is of type struct buffer * and v of type struct
152 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
153 != &v->size, and therefore "v->size = 1; b->size = 2; return
154 v->size;" must therefore return 1. This assumption is incorrect
155 for Emacs, since it type-puns struct Lisp_Vector * with many other
156 types. To fix this problem, this patch adds a new type struct
f904488f 157 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
158 and pseudovectors, and helps optimizing compilers not get fooled
159 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
160 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
161 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
162 the size member.
eab3844f
PE
163 (XSETPVECTYPE): Rewrite in terms of new macro.
164 (XSETPVECTYPESIZE): New macro, specifying both type and size.
165 This is a bit clearer, and further avoids the possibility of
166 undesirable aliasing.
167 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 168 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
169 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
170 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
171 (ASIZE): Now uses header.size rather than size. All
172 previous uses of XVECTOR (foo)->size replaced to use this macro,
173 to avoid the hassle of writing XVECTOR (foo)->header.size.
174 (struct vectorlike_header): New type.
eab3844f
PE
175 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
176 object, to help avoid aliasing.
177 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
178 (SUBRP): Likewise, since Lisp_Subr is a special case.
179 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
180 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
181 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 182 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
183 changed to be "header.size" and "header.next".
184 * buffer.h (struct buffer): Likewise.
185 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
186 * frame.h (struct frame): Likewise.
187 * process.h (struct Lisp_Process): Likewise.
188 * termhooks.h (struct terminal): Likewise.
189 * window.c (struct save_window_data, struct saved_window): Likewise.
190 * window.h (struct window): Likewise.
191 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
192 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
193 * buffer.c (init_buffer_once): Likewise.
194 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
195 special case.
196 * process.c (Fformat_network_address): Use local var for size,
197 for brevity.
198
0df1eac5
PE
199 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
200
847ab9d1 201 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
202 * data.c (atof): Remove decl; no longer used or needed.
203 (digit_to_number): Move to lread.c.
204 (Fstring_to_number): Use new string_to_number function, to be
205 consistent with how the Lisp reader treats infinities and NaNs.
206 Do not assume that floating-point numbers represent EMACS_INT
207 without losing information; this is not true on most 64-bit hosts.
208 Avoid double-rounding errors, by insisting on integers when
209 parsing non-base-10 numbers, as the documentation specifies.
210 * lisp.h (string_to_number): New decl, replacing ...
211 (isfloat_string): Remove.
bc0a5c13 212 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 213 (read1): Do not accept +. and -. as integers; this
452f4150
PE
214 appears to have been a coding error. Similarly, do not accept
215 strings like +-1e0 as floating point numbers. Do not report
216 overflow for integer overflows unless the base is not 10 which
217 means we have no simple and reliable way to continue.
218 Break out the floating-point parsing into a new
219 function string_to_number, so that Fstring_to_number parses
220 floating point numbers consistently with the Lisp reader.
221 (digit_to_number): Moved here from data.c. Make it static inline.
222 (E_CHAR, EXP_INT): Remove, replacing with ...
223 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
224 (string_to_number): New function, replacing isfloat_string.
225 This function checks for valid syntax and produces the resulting
226 Lisp float number too. Rework it so that string-to-number
bc0a5c13 227 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
228 so that overflow for non-base-10 numbers is reported only when
229 there's no portable and simple way to convert to floating point.
452f4150 230
67769ffc
PE
231 * textprop.c (set_text_properties_1): Rewrite for clarity,
232 and to avoid GCC warning about integer overflow.
233
c20db43f
PE
234 * intervals.h (struct interval): Use EMACS_INT for members
235 where EMACS_UINT might cause problems. See
236 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
237 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
238 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
239 All uses changed.
37aa2f85
PE
240 (offset_intervals): Tell GCC not to worry about length overflow
241 when negating a negative length.
c20db43f 242
2538aa2f
PE
243 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
244 (overrun_check_free): Likewise.
245
f2d3008d
PE
246 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
247 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
248 word size.
249
ec8df744
PE
250 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
251 (gnutls_make_error): Rename local to avoid shadowing.
252 (gnutls_emacs_global_deinit): ifdef out; not used.
253 (Fgnutls_boot): Use const for pointer to readonly storage.
254 Comment out unused local. Fix pointer signedness problems.
255
640ee02d
PE
256 * lread.c (openp): Don't stuff size_t into an 'int'.
257 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
258 about possible signed overflow.
259
6048fb2a
PE
260 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
261 (GDK_KEY_g): Don't define if already defined.
262 (xg_prepare_tooltip): Avoid pointer signedness problem.
263 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
264
fa3c87e1
PE
265 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
266 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
267
2172544b
PE
268 * xfns.c (Fx_window_property): Simplify a bit,
269 to make a bit faster and to avoid GCC 4.6.0 warning.
270 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
271
9b821a21
PE
272 * fns.c (internal_equal): Don't assume size_t fits in int.
273
3c616cfa
PE
274 * alloc.c (compact_small_strings): Tighten assertion a little.
275
c2982e87
PE
276 Replace pEd with more-general pI, and fix some printf arg casts.
277 * lisp.h (pI): New macro, generalizing old pEd macro to other
278 conversion specifiers. For example, use "...%"pI"d..." rather
279 than "...%"pEd"...".
280 (pEd): Remove. All uses replaced with similar uses of pI.
281 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
282 * alloc.c (check_pure_size): Don't overflow by converting size to int.
283 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
284 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
285 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
286 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
287 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
288 64-bit hosts.
289 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
290 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
291 * print.c (safe_debug_print, print_object): Likewise.
292 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
293 to int.
6f04d126
PE
294 Use pI instead of if-then-else-abort. Use %p to avoid casts,
295 avoiding the 0 flag, which is not portable.
c2982e87
PE
296 * process.c (Fmake_network_process): Use pI to avoid cast.
297 * region-cache.c (pp_cache): Likewise.
298 * xdisp.c (decode_mode_spec): Likewise.
299 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
300 behavior on 64-bit hosts with printf arg.
6f04d126 301 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
302 (x_stop_queuing_selection_requests): Likewise.
303 (x_get_window_property): Don't truncate byte count to an 'int'
304 when tracing.
0b432f21 305
5e073ec7
PE
306 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
307 here, since it parses constructs like leading '-' and spaces,
308 which are not wanted; and it overflows with large numbers.
309 Instead, simply match F[0-9]+, which is what is wanted anyway.
310
36372bf9
PE
311 * alloc.c: Remove unportable assumptions about struct layout.
312 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
313 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
314 (allocate_vectorlike, make_pure_vector): Use the new macros,
315 plus offsetof, to remove unportable assumptions about struct layout.
316 These assumptions hold on all porting targets that I know of, but
317 they are not guaranteed, they're easy to remove, and removing them
318 makes further changes easier.
319
0b432f21
PE
320 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
321 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
322 (string_overrun_cookie): Now const. Use initializers that
323 don't formally overflow signed char, to avoid warnings.
000098c1
PE
324 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
325 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
326 (allocate_buffer): Don't assume sizeof (struct buffer) is a
327 multiple of sizeof (EMACS_INT); it need not be, if
328 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 329 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 330
895009e1
JB
3312011-04-26 Juanma Barranquero <lekktu@gmail.com>
332
333 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
334
6a7a1b0b
TZ
3352011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
336
337 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 338 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
339 Reported by Paul Eggert <eggert@cs.ucla.edu>.
340
841a1577 3412011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
342
343 * lisp.h (Qdebug): List symbol.
895009e1 344 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
345 * keyboard.c (debug-on-event): New variable.
346 (handle_user_signal): Break into debugger when debug-on-event
347 matches the current signal symbol.
348
f2d3ba6f
DN
3492011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
350
351 * alloc.c (check_sblock, check_string_bytes)
352 (check_string_free_list): Convert to standard C.
353
42ce4c63
TZ
3542011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
355
356 * w32.c (emacs_gnutls_push): Fix typo.
357
825cd63c
EZ
3582011-04-25 Eli Zaretskii <eliz@gnu.org>
359
fb11d64d
EZ
360 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
361 "cast to pointer from integer of different size".
362
825cd63c
EZ
363 Improve doprnt and its use in verror. (Bug#8545)
364 * doprnt.c (doprnt): Document the set of format control sequences
365 supported by the function. Use SAFE_ALLOCA instead of always
366 using `alloca'.
367
368 * eval.c (verror): Don't limit the buffer size at size_max-1, that
369 is one byte too soon. Don't use xrealloc; instead xfree and
370 xmalloc anew.
371
e061a11b
TZ
3722011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
373
374 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
375 callbacks stage.
376
377 * gnutls.c: Renamed global_initialized to
378 gnutls_global_initialized. Added internals for the
379 :verify-hostname-error, :verify-error, and :verify-flags
380 parameters of `gnutls-boot' and documented those parameters in the
381 docstring. Start callback support.
382 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
383 unless a fatal error occured. Call gnutls_alert_send_appropriate
384 on error. Return error code.
385 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
386 (emacs_gnutls_read): Likewise.
387 (Fgnutls_boot): Return handshake error code.
388 (emacs_gnutls_handle_error): New function.
389 (wsaerror_to_errno): Likewise.
390
391 * w32.h (emacs_gnutls_pull): Add prototype.
392 (emacs_gnutls_push): Likewise.
393
394 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
395 (emacs_gnutls_push): Likewise.
396
3972011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
398
399 * process.c (wait_reading_process_output): Check if GnuTLS
400 buffered some data internally if no FDs are set for TLS
401 connections.
402
403 * makefile.w32-in (OBJ2): Add gnutls.$(O).
404 (LIBS): Link to USER_LIBS.
405 ($(BLD)/gnutls.$(0)): New target.
406
fa6996bc
EZ
4072011-04-24 Eli Zaretskii <eliz@gnu.org>
408
eb35682e
EZ
409 * xdisp.c (handle_single_display_spec): Rename the
410 display_replaced_before_p argument into display_replaced_p, to
411 make it consistent with the commentary. Fix typos in the
412 commentary.
413
e2ad650c
EZ
414 * textprop.c (syms_of_textprop): Remove dead code.
415 (copy_text_properties): Delete obsolete commentary about an
416 interface that was deleted long ago. Fix typos in the description
417 of arguments.
418
1b2de274
EZ
419 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
420 to changes in oldXMenu/XMenu.h from 2011-04-16.
421 <menu_help_message, prev_menu_help_message>: Constify.
422 (IT_menu_make_room): menu->help_text is now `const char **';
423 adjust.
424
425 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
426 to changes in oldXMenu/XMenu.h from 2011-04-16.
427 (struct XMenu): Declare `help_text' `const char **'.
428
429 * xfaces.c <Qunspecified>: Make extern again.
430
431 * syntax.c: Include sys/types.h before including regex.h, as
432 required by Posix.
433
762b15be
EZ
434 * doc.c (get_doc_string): Improve the format passed to `error'.
435
436 * doprnt.c (doprnt): Improve commentary.
437
438 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
439
440 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
441 them with etags.
442
f1052e5d
EZ
443 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
444 changes in globals.h immediately force recompilation.
762b15be
EZ
445 (TAGS): Depend on $(CURDIR)/m/intel386.h and
446 $(CURDIR)/s/ms-w32.h.
447 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 448
fa6996bc
EZ
449 * character.c (Fchar_direction): Function deleted.
450 (syms_of_character): Don't defsubr it.
451 <char-direction-table>: Deleted.
452
e6c3da20
EZ
4532011-04-23 Eli Zaretskii <eliz@gnu.org>
454
455 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
456 * doprnt.c: Include limits.h.
457 (SIZE_MAX): New macro.
458 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
459 local variables are now size_t instead of int or unsigned.
460 Improve overflow protection. Support `l' modifier for integer
461 conversions. Support %l conversion. Don't assume an EMACS_INT
462 argument for integer conversions and for %c.
463
464 * lisp.h (doprnt): Restore prototype.
465
466 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
467 $(SRC)/character.h.
468
469 * Makefile.in (base_obj): Add back doprnt.o.
470
471 * deps.mk (doprnt.o): Add back prerequisites.
472 (callint.o): Depend on character.h.
473
474 * eval.c (internal_lisp_condition_case): Include the handler
475 representation in the error message.
476 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
477 when breaking from the loop.
478
479 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
480
481 * callint.c (Fcall_interactively): When displaying error message
482 about invalid control letter, pass the character's codepoint, not
483 a pointer to its multibyte form. Improve display of the character
484 in octal and display also its hex code.
485
486 * character.c (char_string): Use %x to display the (unsigned)
487 codepoint of an invalid character, to avoid displaying a bogus
488 negative value.
489
490 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
491 `error', not SYMBOL_NAME itself.
492
493 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
494 character arguments to `error'.
495
496 * charset.c (check_iso_charset_parameter): Fix incorrect argument
497 to `error' in error message about FINAL_CHAR argument. Make sure
498 FINAL_CHAR is a character, and use %c when it is passed as
499 argument to `error'.
500
4ffd0d6b 5012011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
502
503 * s/ms-w32.h (localtime): Redirect to sys_localtime.
504
505 * w32.c: Include <time.h>.
506 (sys_localtime): New function.
507
4ffd0d6b 5082011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
509
510 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
511
4ffd0d6b 512 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 513
4ffd0d6b 5142011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 515
4ffd0d6b
GM
516 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
517 zombies (Bug#8467).
aac0c6e3 518
04c56954
EZ
5192011-04-19 Eli Zaretskii <eliz@gnu.org>
520
521 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
522 gl_state.e_property when gl_state.object is Qt.
523
524 * insdel.c (make_gap_larger): Remove limitation of buffer size
525 to <= INT_MAX.
526
16a43933
CY
5272011-04-18 Chong Yidong <cyd@stupidchicken.com>
528
529 * xdisp.c (lookup_glyphless_char_display)
530 (produce_glyphless_glyph): Handle cons cell entry in
531 glyphless-char-display.
532 (Vglyphless_char_display): Document it.
533
534 * term.c (produce_glyphless_glyph): Handle cons cell entry in
535 glyphless-char-display.
536
4581706e
CY
5372011-04-17 Chong Yidong <cyd@stupidchicken.com>
538
539 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
540
541 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
542
543 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
544 definition for no-X builds.
545
4887c6e2 5462011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 547
fd35b6f9
PE
548 Static checks with GCC 4.6.0 and non-default toolkits.
549
5c1ccb01
PE
550 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
551
006c5daa
PE
552 * process.c (keyboard_bit_set): Define only if SIGIO.
553 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
554 (send_process): Repair possible setjmp clobbering.
555
efc736d3
PE
556 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
557
4e2fe2e6
PE
558 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
559
f97334a2
PE
560 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
561
4e75f29d
PE
562 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
563 Define only if needed.
564
90efadd1
PE
565 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
566 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 567 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 568
3c647824
PE
569 * dispextern.h (struct redisplay_interface): Rename param
570 to avoid shadowing.
e264f262 571 * termhooks.h (struct terminal): Likewise.
761383f4 572 * xterm.c (xembed_send_message): Likewise.
3c647824 573
b58c5c4a
PE
574 * insdel.c (make_gap_smaller): Define only if
575 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
576
cad59032
PE
577 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
578 it.
579
c339dc2e
PE
580 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
581 so that we aren't warned about unused symbols.
582
91a3e27b
PE
583 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
584
399c71d3 585 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 586
8ffc96f5
PE
587 * xfns.c (x_real_positions): Mark locals as initialized.
588
eef9bc79
PE
589 * xmenu.c (xmenu_show): Don't use uninitialized vars.
590
098db9dd
PE
591 * xterm.c: Fix problems found by static analysis with other toolkits.
592 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
593 (x_dispatch_event): Declare static if USE_GTK, and
594 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 595 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 596 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
597 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
598 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 599
eb18f6cc
PE
600 * xmenu.c (menu_help_callback): Pointer type fixes.
601 Use const pointers when pointing at readonly data. Avoid pointer
602 signedness clashes.
603 (FALSE): Remove unused macro.
604 (update_frame_menubar): Remove unused decl.
605
1fe72bf8
PE
606 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
607
60d9e1db
PE
608 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
609 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
610 (single_menu_item): Rename local to avoid shadowing.
611
39261c26
PE
612 * keyboard.c (make_lispy_event): Remove unused local var.
613
018c5e19
PE
614 * frame.c, frame.h (x_get_resource_string): Bring this back, but
615 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
616
63d2b86e
PE
617 * bitmaps: Change bitmaps from unsigned char back to the X11
618 compatible char. Avoid the old compiler warnings about
619 out-of-range initializers by using, for example, '\xab' rather
620 than 0xab.
621
aefd87e1
PE
622 * xgselect.c (xgselect_initialize): Check vs interface
623 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
624
bf501fb9
PE
625 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
626
e9829fdf
PE
627 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
628 to read-only memory.
629
1086c095
PE
630 * fns.c (vector): Remove; this old hack is no longer needed.
631
2baccd04 632 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 633 Remove unused var.
dde42981 634 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 635
72391843 636 * xrdb.c (x_load_resources): Omit unused local.
3565b346 637
436c16df 638 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 639 (x_window): Rename locals to avoid shadowing.
dc5ddd85 640 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 641
92bb796d 642 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 643 (x_term_init): Remove local to avoid shadowing.
92bb796d 644
764430a3 645 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
646
647 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
648 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
649
d1dfb56c
EZ
6502011-04-16 Eli Zaretskii <eliz@gnu.org>
651
c4354cb4
EZ
652 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
653
d1dfb56c
EZ
654 Fix regex.c, syntax.c and friends for buffers > 2GB.
655 * syntax.h (struct gl_state_s): Declare character position members
656 EMACS_INT.
657
658 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
659
660 * textprop.c (verify_interval_modification, interval_of): Declare
661 arguments EMACS_INT.
662
663 * intervals.c (adjust_intervals_for_insertion): Declare arguments
664 EMACS_INT.
665
666 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
667
668 * indent.c (Fvertical_motion): Local variable it_start is now
669 EMACS_INT.
670
671 * regex.c (re_match, re_match_2, re_match_2_internal)
672 (bcmp_translate, regcomp, regexec, print_double_string)
673 (group_in_compile_stack, re_search, re_search_2, regex_compile)
674 (re_compile_pattern, re_exec): Declare arguments and local
675 variables `size_t' and `ssize_t' and return values `regoff_t', as
676 appropriate.
677 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
678 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
679 <compile_stack_type>: `size' and `avail' are now `size_t'.
680
681 * regex.h <regoff_t>: Use ssize_t, not int.
682 (re_search, re_search_2, re_match, re_match_2): Arguments that
683 specify buffer/string position and length are now ssize_t and
684 size_t. Return type is regoff_t.
685
613052cd
BK
6862011-04-16 Ben Key <bkey76@gmail.com>
687
688 * nsfont.m: Fixed bugs in ns_get_family and
689 ns_descriptor_to_entity that were caused by using free to
690 deallocate memory blocks that were allocated by xmalloc (via
691 xstrdup). This caused Emacs to crash when compiled with
692 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
693 --enable-checking=xmallocoverrun). xfree is now used to
694 deallocate these memory blocks.
695
4170f62f 6962011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 697
71b41406
PE
698 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
699
9587a89d
PE
700 emacs_write: Accept and return EMACS_INT for sizes.
701 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
702 et seq.
703 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
704 Accept and return EMACS_INT.
705 (emacs_gnutls_write): Return the number of bytes written on
706 partial writes.
707 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
708 (emacs_read, emacs_write): Remove check for negative size, as the
709 Emacs source code has been audited now.
9587a89d
PE
710 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
711 (emacs_read, emacs_write): Use it.
273a5f82
PE
712 * process.c (send_process): Adjust to the new signatures of
713 emacs_write and emacs_gnutls_write. Do not attempt to store
714 a byte offset into an 'int'; it might overflow.
9587a89d 715 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 716
3e047f51
PE
717 * sound.c: Don't assume sizes fit in 'int'.
718 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 719 Return EMACS_INT, not int.
3e047f51 720 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
721 Accept EMACS_INT, not int.
722 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
723 record read return values.
724
cc39a9db
BK
7252011-04-15 Ben Key <bkey76@gmail.com>
726
c9d0ec6d
JB
727 * keyboard.c (Qundefined): Don't declare static since it is used
728 in nsfns.m.
729 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
730 static since they are used in nsfont.m.
cc39a9db 731
6c60eb9f
SM
7322011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
733
734 * process.c (Qprocessp): Don't declare static.
735 * lisp.h (Qprocessp): Declare again.
736
7990b61a
JB
7372011-04-15 Juanma Barranquero <lekktu@gmail.com>
738
739 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
740
5d4cb038
PE
7412011-04-14 Paul Eggert <eggert@cs.ucla.edu>
742
8bd7b830 743 Improve C-level modularity by making more things 'static'.
cd64ea1d 744
e3b27b31
PE
745 Don't publish debugger-only interfaces to other modules.
746 * lisp.h (safe_debug_print, debug_output_compilation_hack):
747 (verify_bytepos, count_markers): Move decls to the only modules
748 that need them.
749 * region-cache.h (pp_cache): Likewise.
750 * window.h (check_all_windows): Likewise.
751 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
752
5d4cb038
PE
753 * sysdep.c (croak): Now static, if
754 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
755 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
756
757 * alloc.c (refill_memory_reserve): Now static if
758 !defined REL_ALLOC || defined SYSTEM_MALLOC.
759 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 760
e87b6180
PE
761 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
762 Define only if USE_LUCID.
763
ac64929e
PE
764 * xrdb.c (x_customization_string, x_rm_string): Now static.
765
6f37259d
PE
766 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
767 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
768
1683e3ab
PE
769 * xdisp.c (draw_row_with_mouse_face): Now static.
770 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
771
de9c2632
PE
772 * window.h (check_all_windows): Mark externally visible.
773
2b96acb7
PE
774 * window.c (window_deletion_count): Now static.
775
776 * undo.c: Make symbols static if they're not exported.
777 (last_undo_buffer, last_boundary_position, pending_boundary):
778 Now static.
779
50436f33
PE
780 * textprop.c (interval_insert_behind_hooks): Now static.
781 (interval_insert_in_front_hooks): Likewise.
782
64520e5c
PE
783 * term.c: Make symbols static if they're not exported.
784 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
785 (max_frame_lines, tty_set_terminal_modes):
786 (tty_reset_terminal_modes, tty_turn_off_highlight):
787 (get_tty_terminal): Now static.
788 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
789 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 790 HAVE_WINDOW_SYSTEM.
64520e5c
PE
791 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
792 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
793
1fa53021
PE
794 * sysdep.c: Make symbols static if they're not exported.
795 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
796 Now static.
797 (sigprocmask_set, full_mask): Remove; unused.
798 (wait_debugging): Mark as visible.
799 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
800 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
801
d4b43b22
PE
802 * syntax.c (syntax_temp): Define only if !__GNUC__.
803
b7c513d0
PE
804 * sound.c (current_sound_device, current_sound): Now static.
805
989b29ad
PE
806 * search.c (searchbufs, searchbuf_head): Now static.
807
13a55a78
PE
808 * scroll.c (scroll_cost): Remove; unused.
809 * dispextern.h (scroll_cost): Remove decl.
810
de68a1fc
PE
811 * region-cache.h (pp_cache): Mark as externally visible.
812
40ccffa6
PE
813 * process.c: Make symbols static if they're not exported.
814 (process_tick, update_tick, create_process, chan_process):
815 (Vprocess_alist, proc_buffered_char, datagram_access):
816 (fd_callback_data, send_process_frame, process_sent_to): Now static.
817 (deactivate_process): Mark defn as static, as well as decl.
818 * lisp.h (create_process): Remove decl.
819 * process.h (chan_process, Vprocess_alist): Remove decls.
820
ad64fc97
PE
821 * print.c: Make symbols static if they're not exported.
822 (print_depth, new_backquote_output, being_printed, print_buffer):
823 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
824 (print_interval, print_number_index, initial_stderr_stream):
825 Now static.
826 * lisp.h (Fprinc): Remove decl.
827 (debug_output_compilation_hack): Mark as externally visible.
828
adddb265
PE
829 * sysdep.c (croak): Move decl from here to syssignal.h.
830 * syssignal.h (croak): Put it here, so the API can be checked when
831 'croak' is called from dissociate_if_controlling_tty.
832
1717ede2
PE
833 * minibuf.c: Make symbols static if they're not exported.
834 (minibuf_save_list, choose_minibuf_frame): Now static.
835 * lisp.h (choose_minibuf_frame): Remove decl.
836
fa5fb2bc
PE
837 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
838
1e3890d1
PE
839 * lread.c: Make symbols static if they're not exported.
840 (read_objects, initial_obarray, oblookup_last_bucket_number):
841 Now static.
842 (make_symbol): Remove; unused.
843 * lisp.h (initial_obarray, make_symbol): Remove decls.
844
8a1414fa
PE
845 * keyboard.c: Make symbols static if they're not exported.
846 (single_kboard, recent_keys_index, total_keys, recent_keys):
847 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
848 (this_single_command_key_start, echoing, last_auto_save):
849 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
850 (command_loop, echo_now, keyboard_init_hook, help_char_p):
851 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
852 (Vlispy_mouse_stem, double_click_count):
853 Now static.
854 (force_auto_save_soon): Define only if SIGDANGER.
855 (ignore_mouse_drag_p): Now static if
856 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
857 (print_help): Remove; unused.
858 (stop_character, last_timer_event): Mark as externally visible.
859 * keyboard.h (ignore_mouse_drag_p): Declare only if
860 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
861 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
862 * lisp.h (echoing): Remove decl.
863 (force_auto_save_soon): Declare only if SIGDANGER.
864 * xdisp.c (redisplay_window): Simplify code, to make it more
865 obvious that ignore_mouse_drag_p is not accessed if !defined
866 USE_GTK && !defined HAVE_NS.
867
93ea6e8f
PE
868 * intervals.c: Make symbols static if they're not exported.
869 (merge_properties_sticky, merge_interval_right, delete_interval):
870 Now static.
871 * intervals.h (merge_interval_right, delete_interval): Remove decls.
872
77382fcc
PE
873 * insdel.c: Make symbols static if they're not exported.
874 However, leave prepare_to_modify_buffer alone. It's never
875 called from outside this function, but that appears to be a bug.
876 (combine_after_change_list, combine_after_change_buffer):
4889fc82 877 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
878 (adjust_after_replace_noundo): Remove; unused.
879 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 880 (signal_before_change): Remove decls.
77382fcc 881
9306c32e
PE
882 * indent.c (val_compute_motion, val_vmotion): Now static.
883
cd44d2eb
PE
884 * image.c: Make symbols static if they're not exported.
885 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
886 if USE_GTK.
887 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
888 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
889
ad9a7a06
PE
890 * fringe.c (standard_bitmaps): Now static.
891 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
892
81626931
PE
893 * frame.c: Make symbols static if they're not exported.
894 (x_report_frame_params, make_terminal_frame): Now static.
895 (get_frame_param): Now static, unless HAVE_NS.
896 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
897 (x_get_resource_string): Remove; not used.
898 * frame.h (make_terminal_frame, x_report_frame_params):
899 (x_get_resource_string); Remove decls.
900 (x_fullscreen_adjust): Declare only if WINDOWSNT.
901 * lisp.h (get_frame_param): Declare only if HAVE_NS.
902
239f9db9
PE
903 * font.c, fontset.c: Make symbols static if they're not exported.
904 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
905 (FACE_SUITABLE_FOR_CHAR_P): Use it.
906 * font.c (font_close_object): Now static.
907 * font.h (font_close_object): Remove.
908 * fontset.c (FONTSET_OBJLIST): Remove.
909 (free_realized_fontset) #if-0 the body, which does nothing.
910 (face_suitable_for_char_p): #if-0, as it's never called.
911 * fontset.h (face_suitable_for_char_p): Remove decl.
912 * xfaces.c (face_at_string_position): Use
913 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
914 since 0 is always ASCII.
915
dfcf3579
PE
916 * fns.c (weak_hash_tables): Now static.
917
5045092b
PE
918 * fileio.c: Make symbols static if they're not exported.
919 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
920 (Vwrite_region_annotation_buffers): Now static.
921
57a96f5c
PE
922 * eval.c: Make symbols static if they're not exported.
923 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
924 * lisp.h (backtrace_list): Remove decl.
925
35f08c38
PE
926 * emacs.c: Make symbols static if they're not exported.
927 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
928 (fatal_error_code, fatal_error_signal_hook, standard_args):
929 Now static.
930 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
931 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
932 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
933 * lisp.h (fatal_error_signal_hook): Remove decl.
934 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
935
f44bd759
PE
936 * editfns.c: Move a (normally-unused) function to its only use.
937 * editfns.c, lisp.h (get_operating_system_release): Remove.
938 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
939 worth the hassle of breaking this out.
940
b532497d
PE
941 * xterm.c: Make symbols static if they're not exported.
942 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
943 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
944 (x_destroy_window, x_delete_display):
945 Now static.
946 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
947 (x_mouse_leave): Remove; unused.
948 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
949 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
950 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
951 Remove decls.
952 (x_mouse_leave): Declare only if WINDOWSNT.
953 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
954 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
955 USE_X_TOOLKIT.
956
1675728f
PE
957 * ftxfont.c: Make symbols static if they're not exported.
958 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
959 HAVE_FREETYPE.
960 * font.h (ftxfont_driver): Likewise.
961
e4cebfca
PE
962 * xfns.c: Make symbols static if they're not exported.
963 (x_last_font_name, x_display_info_for_name):
964 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
965 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
966 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
967 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
968 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
969 (last_show_tip_args): Now static.
970 (xic_defaut_fontset, xic_create_fontsetname): Define only if
971 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
972 (x_screen_planes): Remove; unused.
973 * dispextern.h (x_screen_planes): Remove decl.
974
5bf46f05
PE
975 * dispnew.c: Make symbols static if they're not exported.
976 * dispextern.h (redraw_garbaged_frames, scrolling):
977 (increment_row_positions): Remove.
978 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
979 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
980 Now static.
981 (redraw_garbaged_frames): Remove; unused.
982
435f4c28
PE
983 * xfaces.c: Make symbols static if they're not exported.
984 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
985 Remove decls.
986 * xterm.h (defined_color): Remove decls.
987 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
988 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
989 (menu_face_changed_default, defined_color, free_realized_face):
990 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
991 (ascii_face_of_lisp_face): Remove; unused.
992
8524aef3
PE
993 * xdisp.c: Make symbols static if they're not exported.
994 * dispextern.h (scratch_glyph_row, window_box_edges):
995 (glyph_to_pixel_coords, set_cursor_from_row):
996 (get_next_display_element, set_iterator_to_next):
997 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
998 (show_mouse_face): Remove decls
999 * frame.h (message_buf_print): Likewise.
1000 * lisp.h (pop_message, set_message, check_point_in_composition):
1001 Likewise.
1002 * xterm.h (set_vertical_scroll_bar): Likewise.
1003 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1004 (message_buf_print, scratch_glyph_row, displayed_buffer):
1005 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1006 (get_next_display_element, show_mouse_face, window_box_edges):
1007 (frame_to_window_pixel_xy, check_point_in_composition):
1008 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1009 (glyph_to_pixel_coords): Remove; unused.
1010
16390cd2
PE
1011 * dired.c (file_name_completion): Now static.
1012
1013 * dbusbind.c (xd_in_read_queued_messages): Now static.
1014
a25f4dfa
PE
1015 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1016 * data.c (circular_list_error): Remove.
1017
14a9c8df
PE
1018 * commands.h (last_point_position, last_point_position_buffer):
1019 (last_point_position_window): Remove decls.
1020 * keyboard.c: Make these variables static.
1021
74ab6df5
PE
1022 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1023 decls.
1024 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1025 (iso_code_class, detect_coding, code_convert_region): Now static.
1026 (encode_coding_gap): Remove; unused.
1027
38dfbee1
PE
1028 * chartab.c (chartab_chars, chartab_bits): Now static.
1029
a2cb4e63
PE
1030 * charset.h (charset_iso_8859_1): Remove decl.
1031 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1032 Now static.
1033
127198fd
PE
1034 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1035 * ccl.c (Vccl_program_table): Now static.
1036 (check_ccl_update): Remove; unused.
1037
d85b608f
PE
1038 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1039 * category.h: ... from here.
1040 * category.c (check_category_table, set_category_set): Now static.
1041
31cd66f3
PE
1042 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1043 * lisp.h: Remove these decls.
1044
c358e587
PE
1045 * buffer.c (buffer_count): Remove unused var.
1046
e78aecca
PE
1047 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1048 so that it's not optimized away.
1049 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1050 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1051 exported only to the debugger.
1052
e192d7d3
PE
1053 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1054 * atimer.h (run_all_atimers): Removed; not exported.
1055
92470028
PE
1056 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1057 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1058 was inaccessible from Lisp.
1059 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1060 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1061
244ed907
PE
1062 alloc.c: Import and export fewer symbols, and remove unused items.
1063 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1064 is defined.
1065 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1066 it's not optimized away by whole-program optimization.
1067 (message_enable_multibyte, free_misc): Remove.
1068 (catchlist, handlerlist, mark_backtrace):
1069 Declare only if BYTE_MARK_STACK.
1070 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1071 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1072 (message_enable_multibyte): Remove decl.
1073 (free_misc, interval_free_list, float_block, float_block_index):
1074 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1075 (cons_free_list, last_marked_index):
1076 Now static.
1077 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1078 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1079 (mark_backtrace): Define only if BYTE_MARK_STACK.
1080 * xdisp.c (message_enable_multibyte): Now static.
1081
61c2b50e 1082 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1083 This makes it easier for human readers (and static analyzers)
1084 to see whether these variables are used from other modules.
1085 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1086 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1087 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1088 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1089 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1090 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1091 * xmenu.c, xselect.c:
1092 Declare Q* vars static if they are not used in other modules.
1093 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1094 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1095 Remove decls of unexported vars.
1096 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1097
95c82688
PE
1098 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1099
16a97296
PE
1100 Make Emacs functions such as Fatom 'static' by default.
1101 This makes it easier for human readers (and static analyzers)
1102 to see whether these functions can be called from other modules.
1103 DEFUN now defines a static function. To make the function external
1104 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1105 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1106 (Finit_image_library):
16a97296
PE
1107 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1108 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1109 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1110 Remove decls, since these functions are now static.
1111 (Funintern, Fget_internal_run_time): New decls, since these functions
1112 were already external.
95c82688 1113
16a97296
PE
1114 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1115 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1116 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1117 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1118 * keyboard.c, keymap.c, lread.c:
1119 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1120 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1121 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1122 Mark functions with DEFUE instead of DEFUN,
1123 if they are used in other modules.
1124 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1125 decls for now-static functions.
1126 * buffer.h (Fdelete_overlay): Remove decl.
1127 * callproc.c (Fgetenv_internal): Mark as internal.
1128 * composite.c (Fremove_list_of_text_properties): Remove decl.
1129 (Fcomposition_get_gstring): New forward static decl.
1130 * composite.h (Fcomposite_get_gstring): Remove decl.
1131 * dired.c (Ffile_attributes): New forward static decl.
1132 * doc.c (Fdocumntation_property): New forward static decl.
1133 * eval.c (Ffetch_bytecode): New forward static decl.
1134 (Funintern): Remove extern decl; now in .h file where it belongs.
1135 * fileio.c (Fmake_symbolic_link): New forward static decl.
1136 * image.c (Finit_image_library): New forward static decl.
1137 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1138 * intervals.h (Fprevious_property_change):
1139 (Fremove_list_of_text_properties): Remove decls.
1140 * keyboard.c (Fthis_command_keys): Remove decl.
1141 (Fcommand_execute): New forward static decl.
1142 * keymap.c (Flookup_key): New forward static decl.
1143 (Fcopy_keymap): Now static.
1144 * keymap.h (Flookup_key): Remove decl.
1145 * process.c (Fget_process): New forward static decl.
1146 (Fprocess_datagram_address): Mark as internal.
1147 * syntax.c (Fsyntax_table_p): New forward static decl.
1148 (skip_chars): Remove duplicate decl.
1149 * textprop.c (Fprevious_property_change): New forward static decl.
1150 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1151 Now internal.
1152 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1153 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1154
785bbd42
PE
1155 * editfns.c (Fformat): Remove unreachable code.
1156
8b913b57
AS
11572011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1158
1159 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1160 change. (Bug#8496)
1161
a6744a35
EZ
11622011-04-13 Eli Zaretskii <eliz@gnu.org>
1163
1164 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1165 when at ZV. (Bug#8487)
1166
e7974947
AS
11672011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1168
baad03f0
AS
1169 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1170 (Bug#8437)
1171 * keyboard.c (parse_tool_bar_item): Likewise.
1172 * sound.c (sound_cleanup, alsa_close): Likewise.
1173 * termcap.c (tgetent): Likewise.
1174 * xfns.c (x_default_font_parameter): Likewise.
1175 * xsettings.c (read_and_apply_settings): Likewise.
1176
e7974947
AS
1177 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1178 (overrun_check_free): Protoize.
1179
28272684
PE
11802011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1183 since callers should never pass a negative size.
1184 Change the signature to match that of plain 'read' and 'write'; see
1185 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1186 * lisp.h: Update prototypes of emacs_write and emacs_read.
1187
11997c76
EZ
11882011-04-11 Eli Zaretskii <eliz@gnu.org>
1189
1190 * xdisp.c (redisplay_window): Don't try to determine the character
1191 position of the scroll margin if the window start point w->startp
e896f03c 1192 is outside the buffer's accessible region. (Bug#8468)
11997c76 1193
8a2cbd72
EZ
11942011-04-10 Eli Zaretskii <eliz@gnu.org>
1195
1196 Fix write-region and its subroutines for buffers > 2GB.
1197 * fileio.c (a_write, e_write): Modify declaration of arguments and
1198 local variables to support buffers larger than 2GB.
1199 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1200
1201 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1202 argument, local variables, and return value.
1203
1204 * lisp.h: Update prototypes of emacs_write and emacs_read.
1205
1206 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1207
4073e537 12082011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1209
1ebfdcb6
PE
1210 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1211
b2ded58d
PE
1212 Fix more problems found by GCC 4.6.0's static checks.
1213
7d66342c
PE
1214 * xdisp.c (vmessage): Use a better test for character truncation.
1215
bbf47d44
PE
1216 * charset.c (load_charset_map): <, not <=, for optimization,
1217 and to avoid potential problems with integer overflow.
9248994d 1218 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1219 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1220 * editfns.c (Fformat): Likewise.
1e69125e 1221 * syntax.c (skip_chars): Likewise.
3befa583 1222
e3019616
PE
1223 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1224 This also lets GCC 4.6.0 generate slightly better loop code.
1225
becfa255
PE
1226 * callint.c (Fcall_interactively): <, not <=, for optimization.
1227 (Fcall_interactively): Count the number of arguments produced,
1228 not the number of arguments given. This is simpler and lets GCC
1229 4.6.0 generate slightly better code.
1230
dae0cd48
PE
1231 * ftfont.c: Distingish more carefully between FcChar8 and char.
1232 The previous code passed unsigned char * to a functions like
1233 strlen and xstrcasecmp that expect char *, which does not
1234 conform to the C standard.
1235 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1236 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1237 char * when the C standard requires it.
1238
76032d70
PE
1239 * keyboard.c (read_char): Remove unused var.
1240
eb3f1cc8
PE
1241 * eval.c: Port to Windows vsnprintf (Bug#8435).
1242 Include <limits.h>.
1243 (SIZE_MAX): Define if the headers do not.
1244 (verror): Do not give up if vsnprintf returns a negative count.
1245 Instead, grow the buffer. This ports to Windows vsnprintf, which
1246 does not conform to C99. Problem reported by Eli Zaretskii.
1247 Also, simplify the allocation scheme, by avoiding the need for
1248 calling realloc, and removing the ALLOCATED variable.
1249
70476b54
PE
1250 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1251
12020a9e
PE
1252 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1253 But keep the doprint source code for now, as we might revamp it
1254 and use it again (Bug#8435).
ea6c7ae6
PE
1255 * lisp.h (doprnt): Remove.
1256 * Makefile.in (base_obj): Remove doprnt.o.
1257 * deps.mk (doprnt.o): Remove.
1258
5fdb398c
PE
1259 error: Print 32- and 64-bit integers portably (Bug#8435).
1260 Without this change, on typical 64-bit hosts error ("...%d...", N)
1261 was used to print both 32- and 64-bit integers N, which relied on
1262 undefined behavior.
1263 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1264 New macro.
1265 * lisp.h (error, verror): Mark as printf-like functions.
1266 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1267 Report overflow in size calculations when allocating printf buffer.
1268 Do not truncate output string at its first null byte.
1269 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1270 Truncate the output at a character boundary, since vsnprintf does not
1271 do that.
1272 * charset.c (check_iso_charset_parameter): Convert internal
1273 character to string before calling 'error', since %c now has the
1274 printf meaning.
1275 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1276 overflow when computing char to be passed to 'error'. Do not
1277 pass Lisp_Object to 'error'; pass the integer instead.
1278 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1279 formatted with plain %d.
1280
b189fa66
PE
1281 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1282
bff87ef0
PE
1283 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1284
7e2cac20
PE
1285 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1286
ce4d90b5
PE
1287 * xterm.c (x_catch_errors): Remove duplicate declaration.
1288
266c9547
PE
1289 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1290
79c49ad2
PE
1291 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1292
368f4090
JM
12932011-04-10 Jim Meyering <meyering@redhat.com>
1294
1295 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1296 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1297 return ssize_t not "int", and use size_t as the buffer length.
1298 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1299 * gnutls.h: Update declarations.
1300 * process.c (read_process_output): Use ssize_t, to match.
1301 (send_process): Likewise.
1302
a32d4040
CY
13032011-04-09 Chong Yidong <cyd@stupidchicken.com>
1304
1305 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1306
8546720e 13072011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1308
8546720e
GM
1309 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1310 unsigned char, to match FcChar8 type definition.
aac0c6e3 1311
8546720e
GM
1312 * xterm.c (handle_one_xevent):
1313 * xmenu.c (create_and_show_popup_menu):
1314 * xselect.c (x_decline_selection_request)
1315 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1316
0a2f5c1a 13172011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1318
1319 Fix some uses of `int' instead of EMACS_INT.
1320 * search.c (string_match_1, fast_string_match)
1321 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1322 (scan_buffer, find_next_newline_no_quit)
1323 (find_before_next_newline, search_command, Freplace_match)
1324 (Fmatch_data): Make some `int' variables be EMACS_INT.
1325
1326 * xdisp.c (display_count_lines): 3rd argument and return value now
1327 EMACS_INT. All callers changed.
1328 (pint2hrstr): Last argument is now EMACS_INT.
1329
1330 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1331 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1332 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1333 (decode_coding_utf_16, decode_coding_emacs_mule)
1334 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1335 (decode_coding_ccl, decode_coding_charset)
1336 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1337 (decode_coding_iso_2022, decode_coding_emacs_mule)
1338 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1339 <char_offset, last_offset>: Declare EMACS_INT.
1340 (encode_coding_utf_8, encode_coding_utf_16)
1341 (encode_coding_emacs_mule, encode_invocation_designation)
1342 (encode_designation_at_bol, encode_coding_iso_2022)
1343 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1344 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1345 Declare EMACS_INT.
1346 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1347 (encode_invocation_designation): Last argument P_NCHARS is now
1348 EMACS_INT.
1349 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1350 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1351
1352 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1353 All users changed.
1354
1355 * ccl.c (Fccl_execute_on_string): Declare some variables
1356 EMACS_INT.
1357
8546720e 13582011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1359
1360 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1361
4e19a977
CS
13622011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1363
1364 * process.c (Fformat_network_address): Doc fix.
1365
87302331
R
13662011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1367
1368 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1369
cbb59342
CY
13702011-04-08 Chong Yidong <cyd@stupidchicken.com>
1371
1372 * keyboard.c (read_char): Call Lisp function help-form-show,
1373 instead of using internal_with_output_to_temp_buffer.
1374 (Qhelp_form_show): New var.
e0d38eeb 1375 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1376
1377 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1378
1379 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1380
e67a13ab
CY
13812011-04-06 Chong Yidong <cyd@stupidchicken.com>
1382
1383 * process.c (Flist_processes): Removed to Lisp.
1384 (list_processes_1): Deleted.
1385
973f782d
EZ
13862011-04-06 Eli Zaretskii <eliz@gnu.org>
1387
7c106b1e
EZ
1388 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1389
973f782d
EZ
1390 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1391
41cf7d1a 13922011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1393
ca23cc88
PE
1394 Fix more problems found by GCC 4.6.0's static checks.
1395
f390e2d5
PE
1396 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1397
42eea0d0
PE
1398 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1399
b69769da 1400 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1401
f9541e84
PE
1402 * xdisp.c (vmessage): Mark as a printf-like function.
1403
13841b55
PE
1404 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1405
c136c10f
PE
1406 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1407
5e2d4a30
PE
1408 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1409 printf-like functions.
1410 (tiff_load): Add casts to remove these marks before passing them
1411 to system-supplied API.
1412
583f48b9
PE
1413 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1414
b25d760e
PE
1415 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1416 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1417 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1418 directly, rather than having caller test rule sign. This avoids
1419 some unnecessary tests.
1420 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1421 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1422 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1423
bc7b6697 1424 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1425 (xfont_open): Avoid unnecessary tests.
bc7b6697 1426
27ccc379
PE
1427 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1428
dcd5c89a
PE
1429 * composite.h, composite.c (composition_gstring_put_cache):
1430 Use EMACS_INT, not int, for length.
1431
b13a45c6
PE
1432 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1433 breaking out part of COMPOSITION_DECODE_RULE.
1434 (COMPOSITION_DECODE_RULE): Use it.
1435 * composite.c (get_composition_id): Remove unused local vars,
1436 by using the new macro.
1437
1e792e4d
PE
1438 * textprop.c (set_text_properties_1): Change while to do-while,
1439 since the condition is always true at first.
1440
dc6c6455 1441 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1442 (interval_deletion_adjustment): Return unsigned value.
1443 All uses changed.
dc6c6455 1444
aba7731a
PE
1445 * process.c (list_processes_1, create_pty, read_process_output):
1446 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1447 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1448 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1449 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1450 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1451
fdfc4bf3
PE
1452 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1453
fca8fe46 1454 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1455 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1456
06a0259a 1457 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1458 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1459 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1460
e7b9e80f
PE
1461 * print.c (print_error_message): Avoid int overflow.
1462
56201685
PE
1463 * font.c (font_list_entities): Redo for clarity,
1464 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1465
78834453 1466 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1467 (font_score): Avoid potential overflow in diff calculation.
78834453 1468
0bc0b309 1469 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1470 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1471
e610eaca
PE
1472 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1473
b895abce
PE
1474 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1475 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1476 can always succeed if overflow has undefined behavior.
1477
1f1d9321 1478 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1479 (wordify): Omit three unnecessary tests.
1f1d9321 1480
c59478bc
PE
1481 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1482 All callers changed. This avoids the need for an unused var.
1483
79b73827
PE
1484 * casefiddle.c (casify_region): Remove var that is set but not used.
1485
a4db5dfe
PE
1486 * dired.c (file_name_completion): Remove var that is set but not used.
1487
43aae36e
PE
1488 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1489
2a47c44d 1490 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1491 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1492
a37c69bf
PE
1493 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1494 Check for integer overflow on size calculations.
1495
328ab8e7
PE
1496 * buffer.c (Fprevious_overlay_change): Remove var that is set
1497 but not used.
1498
e5a2a5cb
PE
1499 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1500 Remove vars that are set but not used.
8d84a6eb 1501 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1502 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1503
a60e5f68
PE
1504 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1505
f661cb61 1506 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1507 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1508
f0397f5a
PE
1509 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1510 that are set but not used.
1511
8664db06 1512 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1513 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1514
6abdaa4a
PE
1515 * xselect.c (x_get_local_selection, x_handle_property_notify):
1516 Remove vars that are set but not used.
1517
0ce7538d 1518 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1519 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1520
9ae848fc
PE
1521 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1522 Remove var that is set but not used.
0b918413
PE
1523 (scroll_bar_windows_size): Now size_t, not int.
1524 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1525 Check for overflow.
9ae848fc 1526
a5a62657
PE
1527 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1528 (map_tty_color) [!defined MSDOS]: Likewise.
1529
5c5cdd39
PE
1530 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1531
66ebf983
PE
1532 * coding.c: Remove vars that are set but not used.
1533 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1534 All callers changed.
1535 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1536 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1537 (decode_coding_charset): Remove vars that are set but not used.
1538
1be4d761
PE
1539 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1540 that is set but not used.
1541
47553fa8
PE
1542 * print.c (print_object): Remove var that is set but not used.
1543
1f7196bf 1544 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1545 The gnulib version avoids calling malloc in the usual case,
1546 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1547 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1548 * filelock.c (current_lock_owner): Likewise.
1549 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1550 * sysdep.c: Include allocator.h, careadlinkat.h.
1551 (emacs_no_realloc_allocator): New static constant.
1552 (emacs_readlink): New function.
fdb61804
PE
1553 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1554 ../lib/careadlinkat.h.
d1fdcab7 1555
f84c17c7
SM
15562011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1557
1558 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1559 first non-nil return value).
1560
ef3862ad
JD
15612011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1562
1563 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1564 if not defined (Bug#8403).
1565
376a7006
JB
15662011-04-02 Juanma Barranquero <lekktu@gmail.com>
1567
1568 * xdisp.c (display_count_lines): Remove parameter `start',
1569 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1570 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1571 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1572 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1573 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1574 and thereabouts. All callers changed.
1575 (get_per_char_metric): Remove parameter `f', unused since
1576 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1577
6ca3801d
JM
15782011-04-02 Jim Meyering <meyering@redhat.com>
1579
1580 do not dereference NULL upon failed strdup
1581 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1582 (ns_get_family): Likewise.
1583
d8e2b5ba
JB
15842011-04-02 Juanma Barranquero <lekktu@gmail.com>
1585
1586 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1587
8c74fcbd
JD
15882011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1589
1590 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1591 later (Bug#8403).
1592
7200d79c
SM
15932011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1594
03408648 1595 Add lexical binding.
7200d79c 1596
03408648
SM
1597 * window.c (Ftemp_output_buffer_show): New fun.
1598 (Fsave_window_excursion):
1599 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1600
1601 * lread.c (lisp_file_lexically_bound_p): New function.
1602 (Fload): Bind Qlexical_binding.
1603 (readevalloop): Remove `evalfun' arg.
1604 Bind Qinternal_interpreter_environment.
1605 (Feval_buffer): Bind Qlexical_binding.
1606 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1607 Mark as dynamic.
1608 (syms_of_lread): Declare `lexical-binding'.
1609
1610 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1611
1612 * keyboard.c (eval_dyn): New fun.
1613 (menu_item_eval_property): Use it.
ca105506
SM
1614
1615 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1616
03408648
SM
1617 * fns.c (concat, mapcar1): Accept byte-code-functions.
1618
1619 * eval.c (Fsetq): Handle lexical vars.
1620 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1621 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1622 (FletX, Flet): Obey lexical binding.
1623 (Fcommandp): Handle closures.
1624 (Feval): New `lexical' arg.
1625 (eval_sub): New function extracted from Feval. Use it almost
1626 everywhere where Feval was used. Look up vars in lexical env.
1627 Handle closures.
1628 (Ffunctionp): Move from subr.el.
1629 (Ffuncall): Handle closures.
1630 (apply_lambda): Remove `eval_flags'.
1631 (funcall_lambda): Handle closures and new byte-code-functions.
1632 (Fspecial_variable_p): New function.
1633 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1634 but without exporting it to Lisp.
23aba0ea 1635
23aba0ea 1636 * doc.c (Fdocumentation, store_function_docstring):
03408648 1637 * data.c (Finteractive_form): Handle closures.
23aba0ea 1638
03408648
SM
1639 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1640 interactive spec.
ba83908c 1641
03408648
SM
1642 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1643 byte-codes.
1644 (exec_byte_code): New function extracted from Fbyte_code to handle new
1645 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1646
03408648 1647 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1648
03408648 1649 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1650
e2abce01
JB
16512011-03-31 Juanma Barranquero <lekktu@gmail.com>
1652
1653 * xdisp.c (redisplay_internal): Fix prototype.
1654
63696a73 16552011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1656
63696a73
EZ
1657 * xdisp.c (SCROLL_LIMIT): New macro.
1658 (try_scrolling): Use it when setting scroll_limit. Limit
1659 scrolling to 100 screen lines.
1660 (redisplay_window): Even when falling back on "recentering",
1661 position point in the window according to scroll-conservatively,
1662 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1663
1664 (try_scrolling): When point is above the window, allow searching
1665 as far as scroll_max, or one screenful, to compute vertical
1666 distance from PT to the scroll margin position. This prevents
1667 try_scrolling from unnecessarily failing when
1668 scroll-conservatively is set to a value slightly larger than the
1669 window height. Clean up the case of PT below the margin at bottom
1670 of window: scroll_max can no longer be INT_MAX. When aggressive
1671 scrolling is in use, don't let point enter the opposite scroll
1672 margin as result of the scroll.
1673 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1674 threshold of 100 lines for never-recentering scrolling.
1675
e4cc2dfc
JB
16762011-03-31 Juanma Barranquero <lekktu@gmail.com>
1677
1678 * dispextern.h (move_it_by_lines):
1679 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1680 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1681 (message_log_check_duplicate): Remove parameters `prev_bol' and
1682 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1683 (redisplay_internal): Remove parameter `preserve_echo_area',
1684 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1685
1686 * indent.c (Fvertical_motion):
1687 * window.c (window_scroll_pixel_based, Frecenter):
1688 Don't pass `need_y_p' to `move_it_by_lines'.
1689
1c470562
SM
16902011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1691
44f230aa
SM
1692 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1693 steal a few bits to be more compact.
1694 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1695 Remove unneeded casts.
1696
1c470562
SM
1697 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1698
888adce9
ZK
16992011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1700
1701 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1702 binding" message (bug#7967).
1703
f838ed7b
PE
17042011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1705
77861b95
PE
1706 Fix more problems found by GCC 4.6.0's static checks.
1707
de6dbc14
PE
1708 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1709 Remove unused local var.
1710
f838ed7b
PE
1711 * editfns.c (Fmessage_box): Remove unused local var.
1712
792c7b2b
PE
1713 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1714 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1715 Omit unused local vars.
c499e557 1716 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1717 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1718 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1719 Omit unused local var.
1720
ba0165e1
PE
1721 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1722 Don't assume string length fits in int.
32ad8845 1723 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1724 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1725
3c59b4c9
PE
1726 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1727 instead of alloca (Bug#8344).
1728
a3eed478 1729 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1730 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1731
eb4d412d
PE
1732 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1733
1658b401
PE
1734 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1735 concerns.
1736
1737 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1738
1739 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1740
9a2c6e05
PE
1741 * keyboard.c (syms_of_keyboard): Use the same style as later
1742 in this function when indexing through an array. This also
1743 works around GCC bug 48267.
1744
03d0a109
PE
1745 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1746
44f730c8
PE
1747 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1748
fe75f926
PE
1749 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1750 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1751
ffa8c828
PE
1752 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1753 This avoids undefined behavior on integer overflow, and is a bit
1754 more convenient anyway since it is compared to a size_t variable.
1755
c5101a77
PE
1756 Variadic C functions now count arguments with size_t, not int.
1757 This avoids an unnecessary limitation on 64-bit machines, which
1758 caused (substring ...) to crash on large vectors (Bug#8344).
1759 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1760 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1761 All variadic functions and their callers changed accordingly.
c5101a77
PE
1762 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1763 * data.c (arith_driver, float_arith_driver): Likewise.
1764 * editfns.c (general_insert_function): Likewise.
1765 * eval.c (struct backtrace.nargs, interactive_p)
1766 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1767 (funcall_lambda, mark_backtrace): Likewise.
1768 * fns.c (concat): Likewise.
1769 * frame.c (x_set_frame_parameters): Likewise.
1770 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1771 0 if not found, not -1. All callers changed.
1772
dd3f25f7
PE
1773 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1774 (stack_copy_size): Now size_t, not int.
1775 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1776
461c2ab9
JB
17772011-03-28 Juanma Barranquero <lekktu@gmail.com>
1778
1779 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1780 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1781 All callers changed.
1782
1783 * lisp.h (multibyte_char_to_unibyte):
1784 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1785 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1786 * character.h (CHAR_TO_BYTE8):
1787 * cmds.c (internal_self_insert):
1788 * editfns.c (general_insert_function):
1789 * keymap.c (push_key_description):
1790 * search.c (Freplace_match):
1791 * xdisp.c (message_dolog, set_message_1): All callers changed.
1792
f6d62986
SM
17932011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1794
1795 * keyboard.c (safe_run_hook_funcall): New function.
1796 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1797 don't set the hook to nil, but remove the offending function instead.
1798 (Qcommand_hook_internal): Remove, unused.
1799 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1800 Vcommand_hook_internal.
1801
1802 * eval.c (enum run_hooks_condition): Remove.
1803 (funcall_nil, funcall_not): New functions.
1804 (run_hook_with_args): Call each function through a `funcall' argument.
1805 Remove `cond' argument, now redundant.
1806 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1807 (Frun_hook_with_args_until_failure): Adjust accordingly.
1808 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1809
1db5b1ad
JB
18102011-03-28 Juanma Barranquero <lekktu@gmail.com>
1811
1812 * dispextern.h (string_buffer_position): Remove declaration.
1813
1814 * print.c (strout): Remove parameter `multibyte', unused since
1815 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1816
1817 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1818 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1819 All callers changed.
1820
1821 * w32.c (_wsa_errlist): Use braces for struct initializers.
1822
1823 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1824 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1825 All callers changed.
1826 (string_buffer_position): Likewise. Also, make static (it's never
1827 used outside xdisp.c).
1828 (cursor_row_p): Remove parameter `w', unused since
1829 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1830 (decode_mode_spec): Remove parameter `precision', introduced during
1831 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1832 All callers changed.
1833
5ffb62aa
JD
18342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1835
1836 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1837
461c2ab9 18382011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1839
1840 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1841 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1842 (ns_update_auto_hide_menu_bar): New functions.
1843 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1844 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1845 ns_constrain_all_frames.
1846 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1847 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1848
5c380ffb
JD
18492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1850
1851 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1852
9af30bdf
GM
18532011-03-27 Glenn Morris <rgm@gnu.org>
1854
1855 * syssignal.h: Replace RETSIGTYPE with void.
1856 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1857 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1858 Replace SIGTYPE with void everywhere.
1859 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1860 * s/template.h (SIGTYPE): Remove commented out definition.
1861
e2abce01
JB
18622011-03-26 Eli Zaretskii <eliz@gnu.org>
1863
1864 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1865 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1866
f868cd8a
JB
18672011-03-26 Juanma Barranquero <lekktu@gmail.com>
1868
59eb0929
JB
1869 * w32.c (read_unc_volume): Use parameter `henum', instead of
1870 global variable `wget_enum_handle'.
1871
1872 * keymap.c (describe_vector): Remove parameters `indices' and
1873 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1874 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1875
f868cd8a
JB
1876 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1877
1878 * keyboard.c (timer_check): Remove parameter `do_it_now',
1879 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1880 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1881 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1882
1883 * keyboard.c (read_char):
1884 * w32menu.c (w32_menu_display_help):
1885 * xmenu.c (show_help_event, menu_help_callback):
1886 Adjust calls to `show_help_echo'.
1887
1888 * gtkutil.c (xg_maybe_add_timer):
1889 * keyboard.c (readable_events):
1890 * process.c (wait_reading_process_output):
1891 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1892
1893 * insdel.c (adjust_markers_gap_motion):
1894 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1895 (gap_left, gap_right): Don't call it.
1896
2ecf6fdb
CY
18972011-03-25 Chong Yidong <cyd@stupidchicken.com>
1898
1899 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1900 incurred during fontification.
1901
6b1f9ba4
JB
19022011-03-25 Juanma Barranquero <lekktu@gmail.com>
1903
1904 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1905 (DEFVAR_PER_BUFFER): Don't pass it.
1906
1907 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1908 (scrolling_window): Don't pass it.
1909
0f4a96b5
JB
19102011-03-25 Juanma Barranquero <lekktu@gmail.com>
1911
1912 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1913
1914 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1915 and `suffix'.
1916 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1917 of variables specific to SELinux and computation of `encoded_absname'.
1918
1919 * image.c (XPutPixel): Remove unused variable `height'.
1920
1921 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1922
1923 * unexw32.c (get_section_info): Remove unused variable `section'.
1924
1925 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1926 (system_process_attributes): Remove unused variable `sess'.
1927 (sys_read): Remove unused variable `err'.
1928
1929 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1930 (w32_wnd_proc): Remove unused variable `isdead'.
1931 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1932 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1933 (x_create_tip_frame): Remove unused variable `tem'.
1934
1935 * w32inevt.c (w32_console_read_socket):
1936 Remove unused variable `no_events'.
1937
1938 * w32term.c (x_draw_composite_glyph_string_foreground):
1939 Remove unused variable `width'.
1940
1149507c
JB
19412011-03-24 Juanma Barranquero <lekktu@gmail.com>
1942
1943 * w32term.c (x_set_glyph_string_clipping):
1944 Don't pass uninitialized region to CombineRgn.
1945
9c88f339
JB
19462011-03-23 Juanma Barranquero <lekktu@gmail.com>
1947
1948 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1949 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1950 (Fx_close_connection): Remove unused variable `i'.
1951
1952 * w32font.c (w32font_draw): Return number of glyphs.
1953 (w32font_open_internal): Remove unused variable `i'.
1954 (w32font_driver): Add missing initializer.
1955
1956 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1957 (fill_in_menu): Remove unused variable `items_added'.
1958
1959 * w32term.c (last_mouse_press_frame): Remove static global variable.
1960 (w32_clip_to_row): Remove unused variable `f'.
1961 (x_delete_terminal): Remove unused variable `i'.
1962
1963 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1964 (NOTHING): Remove unused static global variable.
1965 (uniscribe_check_otf): Remove unused variable `table'.
1966 (uniscribe_font_driver): Add missing initializers.
1967
dee091a3
JD
19682011-03-23 Julien Danjou <julien@danjou.info>
1969
1970 * term.c (Fsuspend_tty, Fresume_tty):
1971 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1972 * window.c (temp_output_buffer_show):
1973 * insdel.c (signal_before_change):
1974 * frame.c (Fhandle_switch_frame):
1975 * fileio.c (Fdo_auto_save):
1976 * emacs.c (Fkill_emacs):
1977 * editfns.c (save_excursion_restore):
1978 * cmds.c (internal_self_insert):
1979 * callint.c (Fcall_interactively):
1980 * buffer.c (Fkill_all_local_variables):
1981 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1982 Use Frun_hooks.
0f4a96b5 1983 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1984 unconditionnaly since it does the check itself.
1985
2c520ab5 19862011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1987
c9c49752
PE
1988 Fix more problems found by GCC 4.5.2's static checks.
1989
8abc3f12
PE
1990 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1991 the first time through the loop, since we know p0 < p1 then.
1992 This also avoids a gcc -Wstrict-overflow warning.
1993
a2d26660
PE
1994 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1995 leading to a memory leak, possible in functions like
1996 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1997 of objects (Bug#8318).
a2d26660 1998
916c72e9
PE
1999 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2000 that could (at least in theory) be that large.
2001
19ab8a18
PE
2002 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2003 This is less likely to overflow, and avoids undefined behavior if
2004 overflow does occur. All callers changed. Use strtoul to scan
2005 for the unsigned long integer.
b7cbbd6f
PE
2006 (pint2hrstr): Simplify and tune code slightly.
2007 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2008
f0641eff
PE
2009 * scroll.c (do_scrolling): Work around GCC bug 48228.
2010 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2011
7f650bb9
PE
2012 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2013 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2014 (validate_x_resource_name): Simplify count usage.
2015 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2016
37dd57d1
PE
2017 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2018 fail (Bug#8306).
81e56e61 2019
699979fc 2020 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2021
401bf9b4
PE
2022 * process.c (Fmake_network_process): Use socklen_t, not int,
2023 where POSIX says socklen_t is required in portable programs.
2024 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2025 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2026 (Fmake_network_process, server_accept_connection):
2027 (wait_reading_process_output, read_process_output):
2028 Likewise.
2029
b93aacde
PE
2030 * process.c: Rename or move locals to avoid shadowing.
2031 (list_processes_1, Fmake_network_process):
2032 (read_process_output_error_handler, exec_sentinel_error_handler):
2033 Rename or move locals.
4dc343ee 2034 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2035 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2036 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2037 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2038 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2039
af8a867c 2040 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2041 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2042 Include tparam.h instead, since it declares them.
af8a867c
PE
2043 * cm.h (PC): Remove extern decl; tparam.h now does this.
2044 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2045 * terminfo.c: Include tparam.h, to check interfaces.
2046 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2047 (tparam): Adjust signature to match interface in tparam.h;
2048 this removes some undefined behavior. Check that outstring and len
2049 are zero, which they always are with Emacs.
2050 * tparam.h (PC, BC, UP): New extern decls.
2051
0248044d 2052 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2053 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2054
8ff096c1 2055 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2056 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2057 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2058 (ftfont_list): Remove unused local.
49eaafba
PE
2059 (get_adstyle_property, ftfont_pattern_entity):
2060 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2061 Rename locals to avoid shadowing.
8ff096c1 2062
e2be39f6
PE
2063 * xfont.c (xfont_list_family): Mark var as initialized.
2064
c9735e30
PE
2065 * xml.c (make_dom): Now static.
2066
8f5201ae
PE
2067 * composite.c (composition_compute_stop_pos): Rename local to
2068 avoid shadowing.
b246f932
PE
2069 (composition_reseat_it): Remove unused locals.
2070 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2071 (composition_update_it): Mark var as initialized.
11b61122
PE
2072 (find_automatic_composition): Mark vars as initialized,
2073 with a FIXME (Bug#8290).
8f5201ae 2074
760fbc2c
PE
2075 character.h: Rename locals to avoid shadowing.
2076 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2077 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2078 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2079 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2080 to avoid shadowing.
2081
ff08eb85
PE
2082 * textprop.c (property_change_between_p): Remove; unused.
2083
fc7bf025
PE
2084 * intervals.c (interval_start_pos): Now static.
2085
235d7abc
PE
2086 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2087
44f230aa
SM
2088 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2089 Rename locals to avoid shadowing.
3e7d6594 2090
50060332
PE
2091 * sound.c (wav_play, au_play, Fplay_sound_internal):
2092 Fix pointer signedness.
d01f234b 2093 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2094 (wav_play): Initialize a variable to 0, to prevent undefined
2095 behavior (Bug#8278).
50060332 2096
c4fc4e30
PE
2097 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2098
918436ed
PE
2099 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2100
c939f91b
PE
2101 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2102 clobbering (Bug#8298).
b9c7f648
PE
2103 * sysdep.c (sys_subshell): Likewise.
2104 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2105
6bd8c144
PE
2106 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2107 This should get cleaned up, so that child_setup has the
2108 same signature on all platforms.
2109
7710357c 2110 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2111 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2112
c59da222
CY
21132011-03-22 Chong Yidong <cyd@stupidchicken.com>
2114
2115 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2116 not to be necessary, and produces flickering.
2117
66b87493
GM
21182011-03-20 Glenn Morris <rgm@gnu.org>
2119
2120 * config.in: Remove file.
2121
45b6f6d5
JB
21222011-03-20 Juanma Barranquero <lekktu@gmail.com>
2123
2124 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2125 are now in src/globals.h.
2126 (syms_of_minibuf): Remove spurious & from previous change.
2127
3ec03f7e
LL
21282011-03-20 Leo <sdl.web@gmail.com>
2129
2130 * minibuf.c (completing-read-function): New variable.
2131 (completing-read-default): Rename from completing-read.
2132 (completing-read): Call completing-read-function.
2133
b14e3e21
CY
21342011-03-19 Juanma Barranquero <lekktu@gmail.com>
2135
2136 * xfaces.c (Fx_load_color_file):
2137 Read color file from absolute filename (bug#8250).
2138
f2b726e6
JB
21392011-03-19 Juanma Barranquero <lekktu@gmail.com>
2140
2141 * makefile.w32-in: Update dependencies.
2142
09f6ff02
EZ
21432011-03-17 Eli Zaretskii <eliz@gnu.org>
2144
2145 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2146
29a6015a
PE
21472011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2148
a3a6c54e
PE
2149 Fix more problems found by GCC 4.5.2's static checks.
2150
b766f867
PE
2151 * process.c (make_serial_process_unwind, send_process_trap):
2152 (sigchld_handler): Now static.
2153
be02381c
PE
2154 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2155 That way, the code declares only the vars that it needs.
2156 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2157 * s/cygwin.h (PTY_ITERATION): Likewise.
2158 * s/darwin.h (PTY_ITERATION): Likewise.
2159 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2160
57048744
PE
2161 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2162 * process.c (allocate_pty): Don't declare stb unless it's needed.
2163
7914961c 2164 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2165 (CONSTANTLIM): Remove; unused.
2166 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2167 Define only if needed.
7914961c 2168
b3967b18
PE
2169 * unexelf.c (unexec): Name an expression,
2170 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2171 Use a different way to cause a compilation error if anyone uses
2172 n rather than nn, a way that does not involve shadowing.
73366a00 2173 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2174
29a6015a
PE
2175 * deps.mk (unexalpha.o): Remove; unused.
2176
43cfc33e 2177 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2178 * unexec.h: New file.
ce701a33
PE
2179 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2180 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2181 Depend on unexec.h.
2182 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2183 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2184 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2185 Change as necessary to match prototype in unexec.h.
ce701a33 2186
01f44d5a
PE
2187 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2188 shadowing.
4f63c6bb 2189 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2190
a6670b0b
PE
2191 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2192 Rename locals to avoid shadowing.
2193
cef2010d 2194 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2195 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2196
d4d7173a
PE
2197 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2198
f08b802a
PE
2199 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2200 warning when compiling print.c.
2201
3ddb0639
PE
2202 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2203 instead of using an uninitialized var.
5ad03b97 2204 (font_sort_entities): Mark var as initialized.
3ddb0639 2205
170a2692
PE
2206 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2207
e663c700
PE
2208 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2209 pointers to constants.
89bc529a 2210 (font_parse_fcname): Remove unused vars.
7b81e2d0 2211 (font_delete_unmatched): Now static.
ea838e10 2212 (font_get_spec): Remove; unused.
13a547c6
PE
2213 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2214 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2215 Rename or move locals to avoid shadowing.
e663c700 2216
2a80c887 2217 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2218 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2219
1384fa33 2220 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2221 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2222
8b2c52e9
PE
2223 * alloc.c (mark_backtrace): Move decl from here ...
2224 * lisp.h: ... to here, so that it can be checked.
2225
475545b5 2226 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2227 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2228 (lisp_indirect_variable): Name an expression,
2229 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2230 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2231
b1349114 2232 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2233 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2234 Use const pointer when appropriate.
b1349114 2235
a2928364
PE
2236 * lisp.h (get_system_name, get_operating_system_release):
2237 Move decls here, to check interfaces.
2238 * process.c (get_operating_system_release): Move decl to lisp.h.
2239 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2240 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2241 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2242 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2243 (Fformat_time_string, Fencode_time, Finsert_char):
2244 (Ftranslate_region_internal, Fformat):
2245 Rename or remove local vars to avoid shadowing.
9710023e 2246 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2247
a415e694
PE
2248 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2249 avoid shadowing.
2250
8ef4622d
PE
2251 * lisp.h (eassert): Check that the argument compiles, even if
2252 ENABLE_CHECKING is not defined.
2253
946f9a5b
PE
2254 * data.c (Findirect_variable): Name an expression, to avoid
2255 gcc -Wbad-function-cast warning.
112396d6 2256 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2257 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2258 (Fmake_variable_buffer_local, Fmake_local_variable):
2259 Mark variables as initialized.
52746918 2260 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2261
e5aab7e7 2262 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2263 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2264 Rename locals to avoid shadowing.
dff45157
PE
2265 (mark_stack): Move local variables into the #ifdef region where
2266 they're used.
7bc26fdb
PE
2267 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2268 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2269 needed otherwise.
2270 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2271 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2272 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2273
e5aab7e7
PE
2274 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2275 avoids undefined behavior in theory.
2276
4da60324
PE
2277 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2278
88043301
PE
2279 Use functions, not macros, for up- and down-casing (Bug#8254).
2280 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2281 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2282 to use the following functions instead of these macros.
2283 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2284 EMACS_INT, since callers assume the returned value fits in int.
2285 (upcase1): Likewise, for UPCASE_TABLE.
2286 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2287 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2288 the race-condition problem in the old DOWNCASE.
88043301 2289
19ed5445
PE
2290 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2291 Rename locals to avoid shadowing.
2292 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2293 (regex_compile, re_search_2, re_match_2_internal):
2294 Remove unused local vars.
952db0d7
PE
2295 (FREE_VAR): Rewrite so as not to use empty "else",
2296 which gcc can warn about.
da053e48 2297 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2298 (RETALLOC_IF): Define only if needed.
2299 (WORDCHAR_P): Likewise. This one is never needed, but is used
2300 only in a comment talking about a compiler bug, so put inside
2301 the #if 0 of that comment.
2302 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2303 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2304 Remove; unused.
19ed5445 2305
1f3561e4 2306 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2307 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2308 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2309
ded6f8f7
PE
2310 * search.c (simple_search): Remove unused var.
2311
dbd37a95
PE
2312 * dired.c (compile_pattern): Move decl from here ...
2313 * lisp.h: ... to here, so that it can be checked.
2314 (struct re_registers): New forward decl.
2315
7e47afad
PE
2316 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2317
85f24f61
PE
2318 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2319 All uses changed.
2320 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2321 Rename locals to avoid shadowing.
5671df8f 2322 (Fvertical_motion): Mark locals as initialized.
85f24f61 2323
181aa2be 2324 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2325 (casify_region): Mark local as initialized.
181aa2be 2326
930d429c
PE
2327 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2328
7082eac6
PE
2329 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2330 New macros, so that the caller can use some names other than
2331 gcpro1, gcpro2, etc.
2332 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2333 of the new macros.
2334 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2335 argument, for consistency with GCPRO2_VAR, etc: it is now the
2336 prefix of the variable, not the variable itself. All uses
2337 changed.
38b2c076
PE
2338 * dired.c (directory_files_internal, file_name_completion):
2339 Rename locals to avoid shadowing.
2340
15206ed9
PE
2341 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2342 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2343 dired.c's scmp function, had undefined behavior.
2344 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2345 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2346 * buffer.h: ... to here, because these macros use current_buffer,
2347 and the new implementation with inline functions needs to have
2348 current_buffer in scope now, rather than later when the macros
2349 are used.
2350 (downcase, upcase1): New static inline functions.
2351 (DOWNCASE, UPCASE1): Reimplement using these functions.
2352 This avoids undefined behavior in expressions like
2353 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2354 from race conditions in accessing the global variables
2355 case_temp1 and case_temp2.
2356 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2357 * lisp.h (case_temp1, case_temp2): Remove their decls.
2358 * character.h (ASCII_CHAR_P): Move from here ...
2359 * lisp.h: ... to here, so that the inline functions mentioned
2360 above can use them.
2361
4a6bea26
PE
2362 * dired.c (directory_files_internal_unwind): Now static.
2363
f14b7e14
PE
2364 * fileio.c (file_name_as_directory, directory_file_name):
2365 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2366 Now static.
2893f146
PE
2367 (file_name_as_directory): Use const pointers when appropriate.
2368 (Fexpand_file_name): Likewise. In particular, newdir might
2369 point at constant storage, so make it a const pointer.
fd4ead52 2370 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2371 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2372 signedness issues.
f839df0c
PE
2373 (Fset_file_times, Finsert_file_contents, auto_save_error):
2374 Rename locals to avoid shadowing.
f14b7e14 2375
5716756e 2376 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2377 (Ftry_completion, Fall_completions): Rename or remove locals
2378 to avoid shadowing.
5716756e 2379
b4c3046a
PE
2380 * marker.c (bytepos_to_charpos): Remove; unused.
2381
b45db522
PE
2382 * lisp.h (verify_bytepos, count_markers): New decls,
2383 so that gcc does not warn that these functions aren't declared.
2384
85876d07
PE
2385 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2386 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2387 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2388 (copy_text): Remove unused local var.
85876d07 2389
03d78a21 2390 * filelock.c (within_one_second): Now static.
b3dd38ab 2391 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2392
5df8f01b
PE
2393 * buffer.c (fix_overlays_before): Mark locals as initialized.
2394 (fix_start_end_in_overlays): Likewise. This function should be
2395 simplified by using pointers-to-pointers, but that's a different
2396 matter.
b1d876f1 2397 (switch_to_buffer_1): Now static.
8f54f30a
PE
2398 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2399 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2400
a70072c9 2401 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2402 Fix pointer signedness issue.
edced198
PE
2403 (sys_subshell): Mark local as volatile if checking for lint,
2404 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2405 (MAXPATHLEN): Define only if needed.
a70072c9 2406
a0977c44
PE
2407 * process.c (serial_open, serial_configure): Move decls from here ...
2408 * systty.h: ... to here, so that they can be checked.
2409
a884fdcc
PE
2410 * fns.c (get_random, seed_random): Move extern decls from here ...
2411 * lisp.h: ... to here, so that they can be checked.
2412
604efe86 2413 * sysdep.c (reset_io): Now static.
b8950c94 2414 (wait_for_termination_signal): Remove; unused.
604efe86 2415
38fc62d9
PE
2416 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2417 (copy_keymap_item, append_key, push_text_char_description):
2418 Now static.
1004a21a 2419 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2420 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2421 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2422 (describe_map_tree):
2423 Rename locals to avoid shadowing.
38fc62d9 2424
2f2650da
PE
2425 * keyboard.c: Declare functions static if they are not used elsewhere.
2426 (echo_char, echo_dash, cmd_error, top_level_2):
2427 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2428 (read_char, kbd_buffer_get_event, make_lispy_position):
2429 (make_lispy_event, make_lispy_movement, apply_modifiers):
2430 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2431 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2432 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2433 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2434 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2435
a053e86c 2436 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2437 (mark_kboards): Move decl here ...
2438 * alloc.c (mark_kboards): ... from here.
a053e86c 2439
4752793e
PE
2440 * lisp.h (force_auto_save_soon): New decl.
2441
74f10ca7 2442 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2443 (DEFINE_DUMMY_FUNCTION): New macro.
2444 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2445 Use it.
c03cd23f
PE
2446 (main): Add casts to avoid warnings
2447 if GCC considers string literals to be constants.
74f10ca7 2448
022e70d4
PE
2449 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2450
59d6fe83
PE
2451 * dbusbind.c: Pointer signedness fixes.
2452 (xd_signature, xd_append_arg, xd_initialize):
2453 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2454 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2455 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2456 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2457
78320123
PE
2458 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2459 if GCC considers string literals to be constants.
49cebcca 2460 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2461
35ac2a97
SM
24622011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2463
fb103ca9
SM
2464 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2465 (print_preprocess, print_object): New macro to fix last change.
2466
35ac2a97
SM
2467 * print.c (print_preprocess): Don't forget font objects.
2468
62973b41
JB
24692011-03-16 Juanma Barranquero <lekktu@gmail.com>
2470
2471 * emacs.c (USAGE3): Doc fixes.
2472
0e48bb22
AS
24732011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2474
2475 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2476 structure.
2477
7684e57b
JB
24782011-03-14 Juanma Barranquero <lekktu@gmail.com>
2479
2480 * lisp.h (VWindow_system, Qfile_name_history):
2481 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2482 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2483 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2484
2485 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2486 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2487
2488 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2489 * w32console.c (detect_input_pending, read_input_pending)
2490 (encode_terminal_code):
2491 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2492 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2493 (w32_system_caret_y, Qfile_name_history):
2494 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2495 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2496 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2497 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2498 * w32proc.c (Qlocal, report_file_error):
2499 * w32term.c (Vwindow_system, updating_frame):
2500 * w32uniscribe.c (initialized, uniscribe_font_driver):
2501 Remove unneeded extern declarations.
2502
2aa46d6c
CY
25032011-03-14 Chong Yidong <cyd@stupidchicken.com>
2504
c96bbc66 2505 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2506
cffc6f3b
CY
25072011-03-13 Chong Yidong <cyd@stupidchicken.com>
2508
2509 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2510 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2511 These macros can no longer be used for assignment.
2512
44f230aa
SM
2513 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2514 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2515 (record_buffer_markers, fetch_buffer_markers): New functions for
2516 recording and fetching special buffer markers.
2517 (set_buffer_internal_1, set_buffer_temp): Use them.
2518
2519 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2520
2521 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2522
2523 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2524 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2525
2526 * xdisp.c (hscroll_window_tree):
2527 (reconsider_clip_changes): Use PT instead of BUF_PT.
2528
d251f04b
EZ
25292011-03-13 Eli Zaretskii <eliz@gnu.org>
2530
2531 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2532 $(EMACS_ROOT)/lib/intprops.h.
2533
f0c77cd1
PE
25342011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2535
3eca4629
PE
2536 Fix more problems found by GCC 4.5.2's static checks.
2537
7c86ee98
PE
2538 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2539 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2540 (xg_free_frame_widgets): Make it clear that a local variable is
2541 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2542 (gdk_window_get_screen): Make it clear that this macro is needed
2543 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2544 (int_gtk_range_get_value): New function, which avoids a diagnostic
2545 from gcc -Wbad-function-cast.
2546 (xg_set_toolkit_scroll_bar_thumb): Use it.
2547 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2548 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2549 (get_utf8_string, xg_get_file_with_chooser):
2550 Rename locals to avoid shadowing.
2551 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2552
41729b81
PE
2553 * xgselect.c (xg_select): Remove unused var.
2554
f0c77cd1
PE
2555 * image.c (four_corners_best): Mark locals as initialized.
2556 (gif_load): Initialize transparent_p to zero (Bug#8238).
2557 Mark another local as initialized.
ec6cf4c6 2558 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2559
ce0ad53d 2560 * image.c (clear_image_cache): Now static.
d5d5a617 2561 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2562 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2563 (x_edge_detection): Remove unnecessary cast that
2564 gcc -Wbad-function-cast diagnoses.
2037898d 2565 (gif_load): Fix pointer signedness.
6ae141d6
PE
2566 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2567 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2568
33383987 25692011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2570
d32df629
PE
2571 Improve quality of tests for time stamp overflow.
2572 For example, without this patch (encode-time 0 0 0 1 1
2573 1152921504606846976) returns the obviously-bogus value (-948597
2574 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2575 reports time overflow. See
2576 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2577 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2578 * editfns.c: Include limits.h and intprops.h.
2579 (TIME_T_MIN, TIME_T_MAX): New macros.
2580 (time_overflow): Move earlier, to before first use.
2581 (hi_time, lo_time): New functions, for an accurate test for
2582 out-of-range times.
2583 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2584 (Fget_internal_run_time): Don't assume time_t fits in int.
2585 (make_time): Use list2 instead of Fcons twice.
2586 (Fdecode_time): More accurate test for out-of-range times.
2587 (check_tm_member): New function.
2588 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2589 (lisp_time_argument): Don't rely on undefined left-shift and
2590 right-shift behavior when checking for time stamp overflow.
8be6f318 2591
fe31d94c
PE
2592 * editfns.c (time_overflow): New function, refactoring common code.
2593 (Fformat_time_string, Fdecode_time, Fencode_time):
2594 (Fcurrent_time_string): Use it.
2595
8be6f318
PE
2596 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2597 * dired.c (make_time): Move to ...
2598 * editfns.c (make_time): ... here.
2599 * systime.h: Note the move.
2600
09d9db2c 26012011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2602
126bc0dc
YM
2603 * fringe.c (update_window_fringes): Remove unused variables.
2604
c47cbdfd
YM
2605 * unexmacosx.c (copy_data_segment): Also copy __got section.
2606 (Bug#8223)
2607
7ac80be9
EZ
26082011-03-12 Eli Zaretskii <eliz@gnu.org>
2609
c96bbc66 2610 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2611 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2612 Constify `char *' arguments and their references according to
2613 prototypes in tparam.h.
2614
ecb0f94d 2615 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2616
7ac80be9
EZ
2617 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2618 Adapt all references accordingly.
2619
2620 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2621
ef1fd07e
TT
26222011-03-11 Tom Tromey <tromey@redhat.com>
2623
2624 * buffer.c (syms_of_buffer): Remove obsolete comment.
2625
7ef4b50c
EZ
26262011-03-11 Eli Zaretskii <eliz@gnu.org>
2627
2628 * termhooks.h (encode_terminal_code): Declare prototype.
2629
2630 * msdos.c (encode_terminal_code): Don't declare prototype.
2631
2632 * term.c (encode_terminal_code): Now external again, used by
2633 w32console.c and msdos.c.
2634
44f230aa
SM
2635 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2636 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2637
4b1ec863 26382011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2639
1714f52b 2640 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2641
4b1ec863
PE
2642 * fringe.c (update_window_fringes): Mark locals as initialized
2643 (Bug#8227).
2644 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2645
524c7aa6
PE
2646 * alloc.c (mark_fringe_data): Move decl from here ...
2647 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2648 to check its interface.
2649 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2650
a5c0af81 2651 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2652 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2653 (fontset_font): Mark local as initialized.
a9a06e0b 2654 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2655
b4716021
PE
2656 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2657
811e9bac 2658 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2659 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2660 (x_own_selection, Fx_disown_selection_internal): Rename locals
2661 to avoid shadowing.
2662 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2663
7e3ab302
PE
2664 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2665 so that the caller can use some name other than gcpro1.
2666 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2667 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2668 (Fx_backspace_delete_keys_p):
2669 Use them to avoid shadowing, and rename vars to avoid shadowing.
2670 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2671 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2672 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2673 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2674 Remove unused locals.
7e3ab302
PE
2675 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2676 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2677 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2678 macros.
f78faa98 2679
e2b13473
PE
2680 * xterm.h (x_mouse_leave): New decl.
2681
77f23912
PE
2682 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2683 Remove unused functions.
cdf4ba58
PE
2684 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2685 (x_calc_absolute_position): Now static.
7411c686 2686 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2687 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2688 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2689 unless they are used.
38d0b34a
PE
2690 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2691 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2692 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2693 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2694 (x_error_catcher, x_connection_closed, x_error_handler):
2695 (x_error_quitter, xembed_send_message, x_iconify_frame):
2696 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2697 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2698 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2699
44f230aa
SM
2700 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2701 Rename or move locals to avoid shadowing.
6b463e58 2702 (tty_defined_color, merge_face_heights): Now static.
5967d051 2703 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2704 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2705 does not deduce is never used uninitialized.
73719eba
PE
2706 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2707 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2708
426994c3 2709 * terminal.c (store_terminal_param): Now static.
5489860b 2710
032f1620 2711 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2712 (set_frame_menubar): Remove unused local.
d4323972 2713 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2714 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2715 since they might point to immutable storage.
281585b0
PE
2716 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2717 since it's unused otherwise.
032f1620 2718
367c19e5 2719 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2720 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2721 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2722 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2723 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2724 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2725 does not deduce are never used uninitialized.
70739cbe 2726
07b48fa9
PE
2727 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2728
8868a238 2729 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2730 * window.c (window_loop, size_window):
2731 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2732
7e5cf297 2733 * window.c (display_buffer): Now static.
d6550a9f
PE
2734 (size_window): Mark variables that gcc -Wuninitialized
2735 does not deduce are never used uninitialized.
a586633d
PE
2736 * window.h (check_all_windows): New decl, to forestall
2737 gcc -Wmissing-prototypes diagnostic.
5b555da1 2738 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2739
f6095868
PE
2740 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2741 shadowing.
2742 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2743 Include <limits.h>.
2744 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2745 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2746 (load_charset_map): Mark variables that gcc -Wuninitialized
2747 does not deduce are never used uninitialized.
53df7c11 2748 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2749
f38b440c
PE
2750 * coding.c (coding_set_source, coding_set_destination):
2751 Use "else { /* comment */ }" rather than "else /* comment */;"
2752 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2753 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2754 a block, when the outer 'i' will do.
2755 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2756 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2757 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2758 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2759 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2760 Rename locals to avoid shadowing.
2761 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2762 * coding.c (emacs_mule_char, encode_invocation_designation):
2763 Now static, since they're not used elsewhere.
413bb2db 2764 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2765 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2766 (decode_coding_emacs_mule): Mark variables that gcc
2767 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2768 (detect_coding_iso_2022): Initialize a local variable that might
2769 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2770 this initialization is needed. (Bug#8211)
5f58e762
PE
2771 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2772 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2773 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2774 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2775 Remove unused macros.
f38b440c 2776
232b38b9 2777 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2778 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2779 * character.c (string_count_byte8): Likewise.
232b38b9 2780
fb90da1b
PE
2781 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2782 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2783
fb93dbc2
PE
2784 * chartab.c (copy_sub_char_table): Now static, since it's not used
2785 elsewhere.
5c156ace
PE
2786 (sub_char_table_ref_and_range, char_table_ref_and_range):
2787 Rename locals to avoid shadowing.
bbcd0949 2788 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2789
7d3b3862 2790 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2791 (BIDI_BOB): Remove unused macro.
7d3b3862 2792
6be7d3da
PE
2793 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2794 deduce are never used uninitialized.
c2ed9c8b 2795 * term.c (encode_terminal_code): Likewise.
6be7d3da 2796
75f8807f 2797 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2798
50938595
PE
2799 * tparam.h: New file.
2800 * term.c, tparam.h: Include it.
2801 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2802 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2803 Move these decls to tparam.h, and make them agree with what
2804 is actually in tparam.c. The previous trick of using incompatible
2805 decls in different modules does not conform to the C standard.
2806 All callers of tparam changed to use tparam's actual API.
2807 * tparam.c (tparam1, tparam, tgoto):
2808 Use const pointers where appropriate.
2809
fbceeba2
PE
2810 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2811 * cm.h (struct cm): Likewise.
2812 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2813 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2814 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2815 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2816 (turn_on_face, init_tty): Likewise.
2817 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2818
7f3f1250
PE
2819 * term.c (term_mouse_position): Rename local to avoid shadowing.
2820
e6ca6543
PE
2821 * alloc.c (mark_ttys): Move decl from here ...
2822 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2823
c40f8d15
AS
28242011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2825
2826 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2827
cfe0661d
JB
28282011-03-09 Juanma Barranquero <lekktu@gmail.com>
2829
2830 * search.c (compile_pattern_1): Remove argument regp, unused since
2831 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2832 (compile_pattern): Don't pass it.
2833
0afb4571
J
28342011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2835
2836 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2837 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2838 for ! HAVE_GTK3.
2839 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2840
2841 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2842
2843 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2844 gdk_window_get_screen, gdk_window_get_geometry,
2845 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2846 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2847 (xg_get_pixbuf_from_pixmap): New function.
2848 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2849 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2850 Call xg_get_pixbuf_from_pixmap instead of
2851 gdk_pixbuf_get_from_drawable.
2852 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2853 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2854 (xg_check_special_colors): Use GtkStyleContext and its functions
2855 for HAVE_GTK3.
2856 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2857 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2858 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2859 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2860 Call gtk_widget_get_preferred_size.
0afb4571
J
2861 (xg_frame_resized): gdk_window_get_geometry only takes 5
2862 parameters.
44f230aa
SM
2863 (xg_win_to_widget, xg_event_is_for_menubar):
2864 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2865 (xg_set_widget_bg): New function.
2866 (delete_cb): New function.
895009e1 2867 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2868 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2869 (xg_set_background_color): Call xg_set_widget_bg.
2870 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2871 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2872 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2873 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2874 if ! HAVE_GTK3.
2875 (update_frame_tool_bar): Call gtk_widget_hide.
2876 (xg_initialize): Use GDK_KEY_g.
2877
2878 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2879 if ! HAVE_GTK3
2880 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2881
2882 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2883 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2884 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2885
1c2cc4ef
JB
28862011-03-08 Juanma Barranquero <lekktu@gmail.com>
2887
2888 * w32xfns.c (select_palette): Check success of RealizePalette against
2889 GDI_ERROR, not zero.
2890
33383987 2891See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2892
2893;; Local Variables:
2894;; coding: utf-8
aac0c6e3
MR
2895;; End:
2896
33383987 2897 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2898
2899 This file is part of GNU Emacs.
2900
2901 GNU Emacs is free software: you can redistribute it and/or modify
2902 it under the terms of the GNU General Public License as published by
2903 the Free Software Foundation, either version 3 of the License, or
2904 (at your option) any later version.
2905
2906 GNU Emacs is distributed in the hope that it will be useful,
2907 but WITHOUT ANY WARRANTY; without even the implied warranty of
2908 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2909 GNU General Public License for more details.
2910
2911 You should have received a copy of the GNU General Public License
2912 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.