* info.el: Remove the `Info-beginning-of-buffer' function
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5cc7f7af
KH
12011-08-02 Kenichi Handa <handa@m17n.org>
2
d0fffa3f 3 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4
5 * chartab.c (uniprop_table): Make it non-static.
6
525d5e6e
EZ
72011-08-01 Eli Zaretskii <eliz@gnu.org>
8
9 * xdisp.c (forward_to_next_line_start): Accept additional argument
10 BIDI_IT_PREV, and store into it the state of the bidi iterator had
11 on the newline.
12 (reseat_at_next_visible_line_start): Use the bidi iterator state
13 returned by forward_to_next_line_start to restore the state of
14 it->bidi_it after backing up to previous newline. (Bug#9212)
15
31011111
AS
162011-07-30 Andreas Schwab <schwab@linux-m68k.org>
17
18 * regex.c (re_comp): Protoize.
19 (re_exec): Fix return type.
20 (regexec): Fix type of `ret'. (Bug#9203)
21
e5d76069
PE
222011-07-29 Paul Eggert <eggert@cs.ucla.edu>
23
24 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
25 This is needed if max-image-size is a floating-point number.
26
9a79b20c
AS
272011-07-28 Andreas Schwab <schwab@linux-m68k.org>
28
29 * print.c (print_object): Print empty symbol as ##.
30
31 * lread.c (read1): Read ## as empty symbol.
32
d8c2fa78
AA
332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
34
35 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
36 setting frame foreground color (Bug#9175).
37 (x_set_background_color): Likewise.
38
ffe57a7a
AA
39 * nsmenu.m (-setText): Size tooltip dimensions precisely to
40 contents (Bug#9176).
41 (EmacsTooltip -init): Remove bezels and add shadows to
42 tooltip windows.
43
bf3492a5
AA
44 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
45 or scroll bar (Bug#8470).
46
d55e9c53
AA
47 * nsfont.m (nsfont_open): Remove assignment to voffset and
48 unnecessary vars hshink, expand, hd, full_height, min_height.
49 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
50
51 * nsterm.h (nsfont_info): Remove voffset field.
52
d8c2fa78 532011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
54
55 Implement strike-through and overline on NextStep (Bug#8863).
56
57 * nsfont.m (nsfont_open): Use underline position provided by font,
58 instead of hard-coded value of 2.
59 (nsfont_draw): Call ns_draw_text_decoration instead.
60
61 * nsterm.h: Add declaration for ns_draw_text_decoration.
62
63 * nsterm.m (ns_draw_text_decoration): New function for drawing
64 underline, overline, and strike-through.
65 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
66 ns_draw_text_decoration. Change treatment of cursor drawing to
67 accomodate underlining, etc.
68
4cc60b9b
EZ
692011-07-28 Eli Zaretskii <eliz@gnu.org>
70
bc7ece87
EZ
71 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
72 default.
4cc60b9b 73
476371c4
PE
742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
75
66606eea
PE
76 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
77 Without this fix, if a signal arrives just after memory fills up,
78 'malloc' might be invoked reentrantly.
79
476371c4
PE
80 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
81 In other words, assume that every image size is allowed, on non-X
82 hosts. This assumption is probably wrong, but it lets Emacs compile.
83
f3fcc40d
AS
842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
85
86 * regex.c (re_iswctype): Convert return values to boolean.
87
350c992f
EZ
882011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
89
90 * xdisp.c (compute_display_string_pos): Don't use cached display
91 string position if the buffer had its restriction changed.
92 (Bug#9184)
93
5266b4bb
PE
942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
95
96 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
97
2573a837 982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 99
41f55ccd 100 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 101
39e378da
PE
102 * bidi.c: Integer size and overflow fixes.
103 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
104 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
105 (bidi_cache_find_level_change, bidi_cache_ensure_space)
106 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
107 (bidi_find_other_level_edge):
108 Use ptrdiff_t instead of EMACS_INT where either will do.
109 This works better on 32-bit hosts configured --with-wide-int.
110 (bidi_cache_ensure_space): Check for size-calculation overflow.
111 Use % rather than repeated addition, for better worst-case speed.
112 Don't set bidi_cache_size until after xrealloc returns, because it
113 might not return.
114 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
115 (bidi_cache_ensure_space): Also check that the bidi cache size
116 does not exceed that of the largest Lisp string or buffer. See Eli
117 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 118
5e927815
PE
119 * alloc.c (__malloc_size_t): Remove.
120 All uses replaced by size_t. See Andreas Schwab's note
121 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
122
ca4aa935
PE
123 * image.c: Improve checking for integer overflow.
124 (check_image_size): Assume that f is nonnull, since
125 it is always nonnull in practice. This is one less thing to
126 worry about when checking for integer overflow later.
127 (x_check_image_size): New function, which checks for integer
128 overflow issues inside X.
129 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
130 This removes the need for a memory_full check.
131 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
132 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
133 (xbm_read_bitmap_data): Change locals back to 'int', since
134 their values must fit in 'int'.
135 (xpm_load_image, png_load, tiff_load):
136 Invoke x_create_x_image_and_pixmap earlier,
137 to avoid much needless work if the image is too large.
138 (tiff_load): Treat overly large images as if
139 x_create_x_image_and_pixmap failed, not as malloc failures.
140 (gs_load): Use x_check_image_size.
141
5f8f9cc2
PE
142 * gtkutil.c: Omit integer casts.
143 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
144 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
145
5adf60bc
PE
146 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
147
c8907a93
PE
148 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
149 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
150 would wrongly return t on a 64-bit host.
151
e3c25c68
PE
152 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
153 The plain *_OVERFLOW macros run afoul of GCC bug 49705
154 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
155 and therefore cause GCC to emit a bogus diagnostic in some cases.
156
3f791afe
PE
157 * image.c: Integer signedness and overflow and related fixes.
158 This is not an exhaustive set of fixes, but it's time to
159 record what I've got.
160 (lookup_pixel_color, check_image_size): Remove redundant decls.
161 (check_image_size): Don't assume that arbitrary EMACS_INT values
162 fit in 'int', or that arbitrary 'double' values fit in 'int'.
163 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
164 (tiff_load, imagemagick_load_image):
165 Check for overflow in size calculations.
166 (x_create_x_image_and_pixmap): Remove unnecessary test for
167 xmalloc returning NULL; that can't happen.
168 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
169 (xpm_color_bucket): Use better integer hashing function.
170 (xpm_cache_color): Don't possibly over-allocate memory.
171 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
172 (gif_memory_source):
173 Use ptrdiff_t, not int or size_t, to record sizes.
174 (png_load): Don't assume values greater than 2**31 fit in 'int'.
175 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
176 either works, as we prefer signed integers.
177 (tiff_read_from_memory, tiff_write_from_memory):
178 Return tsize_t, not size_t, since that's what the TIFF API wants.
179 (tiff_read_from_memory): Don't fail simply because the read would
180 go past EOF; instead, return a short read.
181 (tiff_load): Omit no-longer-needed casts.
182 (Fimagemagick_types): Don't assume size fits into 'int'.
183
3cc5a532
PE
184 Improve hashing quality when configured --with-wide-int.
185 * fns.c (hash_string): New function, taken from sxhash_string.
186 Do not discard information about ASCII character case; this
187 discarding is no longer needed.
188 (sxhash-string): Use it. Change sig to match it. Caller changed.
189 * lisp.h: Declare it.
190 * lread.c (hash_string): Remove, since we now use fns.c's version.
191 The fns.c version returns a wider integer if --with-wide-int is
192 specified, so this should help the quality of the hashing a bit.
193
b312a492
PE
194 * emacs.c: Integer overflow minor fix.
195 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
196 Define only if GNU_LINUX.
197 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
198
dfd153ae
PE
199 * dispnew.c: Integer signedness and overflow fixes.
200 Remove unnecessary forward decls, that were a maintenance hassle.
201 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
202 All uses changed.
203 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
204 (scrolling_window): Use ptrdiff_t, not int, for byte count.
205 (prepare_desired_row, line_draw_cost):
206 Use int, not unsigned, where either works.
207 (save_current_matrix, restore_current_matrix):
208 Use ptrdiff_t, not size_t, where either works.
209 (init_display): Check for overflow more accurately, and without
210 relying on undefined behavior.
211
a81d11a3
PE
212 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
213 Remove, replacing with the new symbols in lisp.h. All uses changed.
214 * fileio.c (make_temp_name):
215 * filelock.c (lock_file_1, lock_file):
216 * xdisp.c (message_dolog):
217 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
218 Use pMd etc. instead.
219 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
220 replacing the pWIDE etc. symbols removed from editfns.c.
221
3300e6fd
PE
222 * keyboard.h (num_input_events): Now uintmax_t.
223 This is (very slightly) less likely to mess up due to wraparound.
224 All uses changed.
225
fd05c7e9
PE
226 * buffer.c: Integer signedness fixes.
227 (alloc_buffer_text, enlarge_buffer_text):
228 Use ptrdiff_t rather than size_t when either will do, as we prefer
229 signed integers.
230
903fe15d
PE
231 * alloc.c: Integer signedness and overflow fixes.
232 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
233 (__malloc_size_t): Default to size_t, not to int.
234 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
235 (Fgarbage_collect, mark_object_loop_halt, mark_object):
236 Prefer ptrdiff_t to size_t when either would do, as we prefer
237 signed integers.
238 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
239 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
240 Now const. Initialize with values that are in range even if char
241 is signed.
242 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
243 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
244 These functions do the right thing with sizes > 2**32.
245 (check_depth): Now ptrdiff_t, not int.
246 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
247 Adjust to new way of storing sizes. Check for size overflow bugs
248 in rest of code.
249 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
250 slightly wrong anyway, as it missed one instance of
251 XMALLOC_OVERRUN_CHECK_OVERHEAD.
252 (refill_memory_reserve): Omit needless cast to size_t.
253 (mark_object_loop_halt): Mark as externally visible.
254
ac82cc6a
PE
255 * xselect.c: Integer signedness and overflow fixes.
256 (Fx_register_dnd_atom, x_handle_dnd_message):
257 Use ptrdiff_t, not size_t, since we prefer signed.
258 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
259 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
260 x_dnd_atoms_size and x_dnd_atoms_length.
261
c2d1e36d
PE
262 * doprnt.c: Prefer signed to unsigned when either works.
263 * eval.c (verror):
264 * doprnt.c (doprnt):
265 * lisp.h (doprnt):
266 * xdisp.c (vmessage):
267 Use ptrdiff_t, not size_t, when using or implementing doprnt,
268 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
269 prefer signed arithmetic to avoid comparison confusion.
270 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
271 but is a bit tricky.
272
0e926e56
PE
273 Assume freestanding C89 headers, string.h, stdlib.h.
274 * data.c, doprnt.c, floatfns.c, print.c:
275 Include float.h unconditionally.
276 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
277 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
278 * regex.c: Likewise for stddef.h, string.h.
279 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
280 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
281 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
282 (STDC_HEADERS): Remove obsolete defines.
283 * sysdep.c: Include limits.h unconditionally.
284
9cfdb3ec
PE
285 Assume support for memcmp, memcpy, memmove, memset.
286 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
287 * regex.c (memcmp, memcpy):
288 Remove; we assume C89 now.
289
290 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
291 (__malloc_safe_bcopy): Remove; no longer needed.
292
cf950e6b 293 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
294 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
295 well either way, and we prefer signed to unsigned.
296
dbf38e02
LMI
2972011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
298
299 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
300 closes the connection while we're reading (bug#9182).
301
d6f0886c
JD
3022011-07-25 Jan Djärv <jan.h.d@swipnet.se>
303
304 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
305 are specified (Bug#9168).
306
2eb1f9e6
PE
3072011-07-25 Paul Eggert <eggert@cs.ucla.edu>
308
309 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
310 Found by GCC static checking and --with-wide-int on a 32-bit host.
311
22381272 3122011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
313
314 * xdisp.c (compute_display_string_pos): Fix logic of caching
315 previous display string position. Initialize cached_prev_pos to
316 -1. Fixes slow-down at the beginning of a buffer.
317
f25e39b4
EZ
3182011-07-24 Eli Zaretskii <eliz@gnu.org>
319
320 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
321 for attrs[LFACE_FONTSET_INDEX].
322
04c4b52e
PE
3232011-07-23 Paul Eggert <eggert@cs.ucla.edu>
324
325 * xml.c (parse_region): Remove unused local
326 that was recently introduced.
327
c1734fbd
EZ
3282011-07-23 Eli Zaretskii <eliz@gnu.org>
329
be18c5a5
EZ
330 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
331 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
332
c1734fbd
EZ
333 * xdisp.c (move_it_in_display_line_to): Record the best matching
334 position for TO_CHARPOS while scanning the line, and restore it on
335 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
336 vertical-motion and pos-visible-in-window-p under bidi redisplay
337 when exact match is impossible due to invisible text, and the
338 lines are truncated.
339
a258d627
JD
3402011-07-23 Jan Djärv <jan.h.d@swipnet.se>
341
342 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
343 for OSX >= 10.7.
344
b6d5a689
EZ
3452011-07-22 Eli Zaretskii <eliz@gnu.org>
346
0f74f785
EZ
347 Fix a significant slow-down of cursor motion with C-n, C-p,
348 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
349 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 350 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
351 (next_element_from_buffer): Call compute_stop_pos_backwards to
352 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
353 base_level_stop.
354 (reseat): Don't look for prev_stop, as that could mean a very long
355 run.
356 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
357 <cached_disp_overlay_modiff>: Cache for last found display string
358 position.
551918c1 359 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
360 about the same buffer in the same area of character positions, and
361 the buffer wasn't changed since the time the display string
362 position was cached.
551918c1 363
b2d0c91a
EZ
3642011-07-22 Eli Zaretskii <eliz@gnu.org>
365
366 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
367 is an integer, which is important for empty lines. (Bug#9149)
368
043604ee
CY
3692011-07-22 Chong Yidong <cyd@stupidchicken.com>
370
371 * frame.c (Fmodify_frame_parameters): In tty case, update the
372 default face if necessary (Bug#4238).
373
da4adb04
CY
3742011-07-21 Chong Yidong <cyd@stupidchicken.com>
375
376 * editfns.c (Fstring_to_char): No need to explain what a character
377 is in the docstring (Bug#6576).
378
9abd0532
LMI
3792011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
380
381 * xml.c (parse_region): Make sure we always return a tree.
382
36881d16
HK
3832011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
384
385 * xml.c (parse_region): If a document contains only comments,
386 return that, too.
387
1e98674d
LMI
3882011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
389
390 * xml.c (make_dom): Return comments, too.
391
590bd467
PE
3922011-07-19 Paul Eggert <eggert@cs.ucla.edu>
393
394 Port to OpenBSD.
395 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
396 and the surrounding thread.
397 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
398 rather than fgets, and retry after EINTR. Otherwise, 'emacs
399 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
400 timer goes off.
401 * s/openbsd.h (BROKEN_SIGIO): Define.
402 * unexelf.c (unexec) [__OpenBSD__]:
403 Don't update the .mdebug section of the Alpha COFF symbol table.
404
f41628b2
LMI
4052011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
406
407 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
408 (bug#8460).
409
b59b67c5
PE
4102011-07-18 Paul Eggert <eggert@cs.ucla.edu>
411
15e3a074
PE
412 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
413 This fixes some race conditions on the permissions of any newly
414 created file.
415
41bed37d
PE
416 * alloc.c (valid_pointer_p): Use pipe, not open.
417 This fixes some permissions issues when debugging.
418
b59b67c5
PE
419 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
420 If fchown fails to set both uid and gid, try to set just gid,
421 as that is sometimes allowed. Adjust the file's mode to eliminate
422 setuid or setgid bits that are inappropriate if fchown fails.
423
925a6be7
SM
4242011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
425
426 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
427 to compare Lisp_Objects.
428 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
429 global_gnutls_log_level, don't mistake it for a Lisp_Object.
430 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
431
52968808
AS
4322011-07-17 Andreas Schwab <schwab@linux-m68k.org>
433
0a6a104b
AS
434 * lread.c (read_integer): Unread even EOF character.
435 (read1): Likewise. Properly record start position of symbol.
436
52968808
AS
437 * lread.c (read1): Read `#:' as empty uninterned symbol if no
438 symbol character follows.
439
9e381cdd
PE
4402011-07-17 Paul Eggert <eggert@cs.ucla.edu>
441
442 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
443 This works around a problem with the previous change to Fcopy_file.
444 Recent glibc declares fchown with __attribute__((warn_unused_result)),
445 and without this change, GCC might complain about discarding
446 fchown's return value.
447
b5641435
JB
4482011-07-16 Juanma Barranquero <lekktu@gmail.com>
449
450 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
451
a8031457
PE
4522011-07-16 Paul Eggert <eggert@cs.ucla.edu>
453
454 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
455
dd889327
LMI
4562011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
457
750c33f7
LMI
458 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
459 it's used from the C level.
460
dd889327
LMI
461 * process.c: Use the same condition for POLL_FOR_INPUT in both
462 keyboard.c and process.c (bug#1858).
463
87e86684
LM
4642011-07-09 Lawrence Mitchell <wence@gmx.li>
465
466 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
467 (Fgnutls_boot): Use it.
468
64348f40
AS
4692011-07-15 Andreas Schwab <schwab@linux-m68k.org>
470
471 * doc.c (Fsubstitute_command_keys): Revert last change.
472
1d698799
LMI
4732011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
474
f863868c
LMI
475 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
476 quotes the next character, and doesn't affect other longer
477 sequences (bug#8935).
478
1d698799
LMI
479 * lread.c (syms_of_lread): Clarify that is isn't only
480 `eval-buffer' and `eval-defun' that's affected by
481 `lexical-binding' (bug#8460).
482
aa4b6df6
EZ
4832011-07-15 Eli Zaretskii <eliz@gnu.org>
484
485 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
486 bidi redisplay when a line includes both an image and is
487 truncated.
488
5d856da6
PE
4892011-07-14 Paul Eggert <eggert@cs.ucla.edu>
490
ad6042bb
PE
491 Fix minor problems found by static checking.
492 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
493 (elsz): Now a signed constant, not a size_t var. We prefer signed
494 types to unsigned, to avoid integer comparison confusion. Without
495 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
496 "cannot optimize loop, the loop counter may overflow", a symptom
497 of the confusion.
f00bbb22 498 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
499 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
500
6468f31c
LMI
5012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
502
49080b10
LMI
503 * search.c (Fre_search_backward): Mention `case-fold-search' in
504 all the re_search_* functions (bug#8138).
505
6468f31c
LMI
506 * keyboard.c (Fopen_dribble_file): Document when the file is
507 closed (bug#8056).
508
c965adc5
EZ
5092011-07-14 Eli Zaretskii <eliz@gnu.org>
510
df9733bf
EZ
511 * bidi.c (bidi_dump_cached_states): Fix format of displaying
512 bidi_cache_idx.
513
0bb23927
EZ
514 Support bidi reordering of display and overlay strings.
515 * xdisp.c (compute_display_string_pos)
516 (compute_display_string_end): Accept additional argument STRING.
517 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
518 (reseat_to_string): Initialize bidi_it->string.s and
519 bidi_it->string.schars.
520 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
521 NULL (avoids a crash in bidi_paragraph_init). Initialize
522 itb.string.lstring.
523 (init_iterator): Call bidi_init_it only of a valid
524 buffer position was specified. Initialize paragraph_embedding to
525 L2R.
526 (reseat_to_string): Initialize the bidi iterator.
527 (display_string): If we need to ignore text properties of
528 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
529 original value of -1 will not work with bidi.)
530 (compute_display_string_pos): First arg is now struct
531 `text_pos *'; all callers changed. Support display properties on
532 Lisp strings.
533 (compute_display_string_end): Support display properties on Lisp
534 strings.
535 (init_iterator, reseat_1, reseat_to_string): Initialize the
536 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
537 when iterating on a string not from display properties).
538 (compute_display_string_pos, compute_display_string_end): Fix
539 calculation of the object to scan. Fixes an error when using
540 arrow keys.
541 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
542 base_level_stop; instead, set base_level_stop to BEGV. Fixes
543 crashes in vertical-motion.
544 (next_element_from_buffer): Improve commentary for when
545 the iterator is before prev_stop.
546 (init_iterator): Initialize bidi_p from the default value of
547 bidi-display-reordering, not from buffer-local value. Use the
548 buffer-local value only if initializing for buffer iteration.
549 (handle_invisible_prop): Support invisible properties on strings
550 that are being bidi-reordered.
551 (set_iterator_to_next): Support bidi reordering of C strings and
552 Lisp strings.
553 (next_element_from_string): Support bidi reordering of Lisp
554 strings.
555 (handle_stop_backwards): Support Lisp strings as well.
556 (display_string): Support display of R2L glyph rows. Use
557 IT_STRING_CHARPOS when displaying from a Lisp string.
558 (init_iterator): Don't initialize it->bidi_p for strings
559 here.
560 (reseat_to_string): Initialize it->bidi_p for strings here.
561 (next_element_from_string, next_element_from_c_string)
562 (next_element_from_buffer): Add xassert's for correspondence
563 between IT's object being iterated and it->bidi_it.string
564 structure.
565 (face_before_or_after_it_pos): Support bidi iteration.
566 (next_element_from_c_string): Handle the case of the first string
567 character that is not the first one in the visual order.
568 (get_visually_first_element): New function, refactored from common
569 parts of next_element_from_buffer, next_element_from_string, and
570 next_element_from_c_string.
571 (tool_bar_lines_needed, redisplay_tool_bar)
572 (display_menu_bar): Force left-to-right direction. Add a FIXME
573 comment for making that be controlled by a user option.
574 (push_it, pop_it): Save and restore the state of the
575 bidi iterator. Save and restore the bidi_p flag.
576 (pop_it): Iterate out of display property for string iteration as
577 well.
578 (iterate_out_of_display_property): Support iteration over strings.
579 (handle_single_display_spec): Set up it->bidi_it for iteration
580 over a display string, and call bidi_init_it.
581 (handle_single_display_spec, next_overlay_string)
582 (get_overlay_strings_1, push_display_prop): Set up the bidi
583 iterator for displaying display or overlay strings.
584 (forward_to_next_line_start): Don't use the shortcut if
585 bidi-iterating.
586 (back_to_previous_visible_line_start): If handle_display_prop
587 pushed the iterator stack, restore the internal state of the bidi
588 iterator by calling bidi_pop_it same number of times.
589 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
590 and we are bidi-iterating, don't decrement the iterator position;
591 instead, set the first_elt flag in the bidi iterator, to produce
592 the same effect.
593 (reseat_1): Remove redundant setting of string_from_display_prop_p.
594 (push_display_prop): xassert that we are iterating a buffer.
595 (push_it, pop_it): Save and restore paragraph_embedding member.
596 (handle_single_display_spec, next_overlay_string)
597 (get_overlay_strings_1, reseat_1, reseat_to_string)
598 (push_display_prop): Set up the `unibyte' member of bidi_it.string
599 correctly. Don't assume unibyte strings are not bidi-reordered.
600 (compute_display_string_pos)
601 (compute_display_string_end): Fix handling the case of C string.
602 (push_it, pop_it): Save and restore from_disp_prop_p.
603 (handle_single_display_spec, push_display_prop): Set the
604 from_disp_prop_p flag.
605 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
606 (pop_it): Call iterate_out_of_display_property only if we are
607 popping after iteration over a string that came from a display
608 property. Fix a typo in popping stretch info. Add an assertion
609 for verifying that the iterator position is in sync with the bidi
610 iterator.
611 (handle_single_display_spec, get_overlay_strings_1)
612 (push_display_prop): Fix initialization of paragraph direction for
613 string when that of the parent object is not yet determined.
614 (reseat_1): Call bidi_init_it to resync the bidi
615 iterator with IT's position. (Bug#7616)
616 (find_row_edges): If ROW->start.pos gives position
617 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
618 (handle_stop, back_to_previous_visible_line_start, reseat_1):
619 Reset the from_disp_prop_p flag.
620 (SAVE_IT, RESTORE_IT): New macros.
621 (pos_visible_p, face_before_or_after_it_pos)
622 (back_to_previous_visible_line_start)
623 (move_it_in_display_line_to, move_it_in_display_line)
624 (move_it_to, move_it_vertically_backward, move_it_by_lines)
625 (try_scrolling, redisplay_window, display_line): Use them when
626 saving a temporary copy of the iterator and restoring it back.
627 (back_to_previous_visible_line_start, reseat_1)
628 (init_iterator): Empty the bidi cache "stack".
629 (move_it_in_display_line_to): If iterator ended up at
630 EOL, but we never saw any buffer positions smaller than
631 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
632 motion in bidi-reordered lines.
633 (move_it_in_display_line_to): Record prev_method and prev_pos
634 immediately before the call to set_iterator_to_next. Fixes cursor
635 motion in bidi-reordered lines with stretch glyphs and strings
636 displayed in margins. (Bug#8133) (Bug#8867)
637 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
638 TO_CHARPOS.
639 (pos_visible_p): Support positions in bidi-reordered lines. Save
640 and restore bidi cache.
641
642 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
643 (bidi_paragraph_info): Delete unused struct.
644 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
645 (bidi_cache_start): New variable.
646 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
647 to zero.
648 (bidi_cache_fetch_state, bidi_cache_search)
649 (bidi_cache_find_level_change, bidi_cache_iterator_state)
650 (bidi_cache_find, bidi_peek_at_next_level)
651 (bidi_level_of_next_char, bidi_find_other_level_edge)
652 (bidi_move_to_visually_next): Compare cache index with
653 bidi_cache_start rather than with zero.
654 (bidi_fetch_char): Accept new argument STRING; all callers
655 changed. Support iteration over a string. Support strings with
656 display properties. Support unibyte strings. Fix the type of
657 `len' according to what STRING_CHAR_AND_LENGTH expects.
658 (bidi_paragraph_init, bidi_resolve_explicit_1)
659 (bidi_resolve_explicit, bidi_resolve_weak)
660 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
661 iteration over a string.
662 (bidi_set_sor_type, bidi_resolve_explicit_1)
663 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
664 can now be zero (for strings); special values 0 and -1 were
665 changed to -1 and -2, respectively.
666 (bidi_char_at_pos): New function.
667 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
668 Call it instead of FETCH_MULTIBYTE_CHAR.
669 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
670 initialized to valid values.
671 (bidi_init_it): Don't initialize charpos and bytepos with invalid
672 values.
673 (bidi_level_of_next_char): Allow the sentinel "position" to pass
674 the test for valid cached positions. Fix the logic for looking up
675 the sentinel state in the cache. GCPRO the Lisp string we are
676 iterating.
677 (bidi_push_it, bidi_pop_it): New functions.
678 (bidi_initialize): Initialize the bidi cache start stack pointer.
679 (bidi_cache_ensure_space): New function, refactored from part of
680 bidi_cache_iterator_state. Don't assume the required size is just
681 one BIDI_CACHE_CHUNK away.
682 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
683 (bidi_count_bytes, bidi_char_at_pos): New functions.
684 (bidi_cache_search): Don't assume bidi_cache_last_idx is
685 always valid if bidi_cache_idx is valid.
686 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
687 is valid if it's going to be used.
688 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
689 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
690 (bidi_cache_find_level_change, bidi_cache_ensure_space)
691 (bidi_cache_iterator_state, bidi_cache_find)
692 (bidi_find_other_level_edge, bidi_cache_start_stack): All
693 variables related to cache indices are now EMACS_INT.
694
0bb23927
EZ
695 * dispextern.h (struct bidi_string_data): New structure.
696 (struct bidi_it): New member `string'. Make flag members be 1-bit
697 fields, and put them last in the struct.
698 (compute_display_string_pos, compute_display_string_end): Update
699 prototypes.
700 (bidi_push_it, bidi_pop_it): Add prototypes.
701 (struct iterator_stack_entry): New members bidi_p,
702 paragraph_embedding, and from_disp_prop_p.
703 (struct it): Member bidi_p is now a bit field 1 bit wide.
704 (bidi_shelve_cache, bidi_unshelve_cache): Declare
705 prototypes.
706
707 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
708 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
709 and vector-like objects.
710
711 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
712 cache around display iteration.
713
714 * window.c (Fwindow_end, window_scroll_pixel_based)
715 (displayed_window_lines, Frecenter): Save and restore the bidi
716 cache around display iteration.
717
3bbd2265
LMI
7182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
719
720 * editfns.c (Fdelete_region): Clarify the use of the named
721 parameters (bug#6788).
722
adc47434
MR
7232011-07-14 Martin Rudalics <rudalics@gmx.at>
724
725 * indent.c (Fvertical_motion): Set and restore w->pointm when
726 saving and restoring the window's buffer (Bug#9006).
727
837c31f8
LMI
7282011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
729
730 * editfns.c (Fstring_to_char): Clarify just what is returned
731 (bug#6576). Text by Eli Zaretskii.
732
ac389d0c
JB
7332011-07-13 Juanma Barranquero <lekktu@gmail.com>
734
735 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
736
0be0ce47
EZ
7372011-07-13 Eli Zaretskii <eliz@gnu.org>
738
739 * buffer.c (mmap_find): Fix a typo.
740
cd18e7e3
JB
7412011-07-13 Johan Bockgård <bojohan@gnu.org>
742
743 Fix execution of x selection hooks.
744 * xselect.c (Qx_lost_selection_functions)
745 (Qx_sent_selection_functions): New vars.
746 (syms_of_xselect): DEFSYM them.
747 (x_handle_selection_request): Pass Qx_sent_selection_functions
748 rather than Vx_sent_selection_functions to Frun_hook_with_args.
749 (x_handle_selection_clear,x_clear_frame_selections):
750 Pass Qx_lost_selection_functions rather than
751 Vx_lost_selection_functions to Frun_hook_with_args.
752
47ea7f44
PE
7532011-07-13 Paul Eggert <eggert@cs.ucla.edu>
754
ac389d0c 755 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
756 The old code sometimes used this field without initializing it.
757
47ea7f44
PE
758 * alloc.c (gc_sweep): Don't read past end of array.
759 In theory, the old code could also have corrupted Emacs internals,
760 though it'd be very unlikely.
761
bc985c87
AS
7622011-07-12 Andreas Schwab <schwab@linux-m68k.org>
763
764 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 765 argument. (Bug#4026)
bc985c87 766
0cf34688
LMI
7672011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
768
b3dadd76
LMI
769 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
770 key" (bug#4257).
771
0cf34688
LMI
772 * window.c (Fset_window_start): Doc fix (bug#4199).
773 (Fset_window_hscroll): Ditto.
774
270768cd
PE
7752011-07-12 Paul Eggert <eggert@cs.ucla.edu>
776
077e3dda 777 Fix minor new problems caught by GCC 4.6.1.
270768cd 778 * term.c (init_tty): Remove unused local.
490011a6 779 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 780 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 781 not used otherwise.
270768cd 782
b1f58454
CY
7832011-07-12 Chong Yidong <cyd@stupidchicken.com>
784
785 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
786
22b9578d
LMI
7872011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
788
6e70ab07
LMI
789 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
790 are the mini-buffer and the echo area (bug#3320).
791
22b9578d
LMI
792 * term.c (init_tty): Remove support for supdup, c10 and perq
793 terminals, which are no longer supported (bug#1482).
794
8974cc9f
JB
7952011-07-10 Johan Bockgård <bojohan@gnu.org>
796
797 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
798
a560d974
JD
7992011-07-10 Jan Djärv <jan.h.d@swipnet.se>
800
801 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
802 for non-popups (Bug#3642).
803
1dae0f0a
AS
8042011-07-10 Andreas Schwab <schwab@linux-m68k.org>
805
268c2c36 806 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 807 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
808 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
809 * cm.c (losecursor): Likewise.
1dae0f0a
AS
810 * data.c (fmod): Likewise.
811 * dispnew.c (swap_glyphs_in_rows): Likewise.
812 * emacs.c (memory_warning_signal): Likewise.
813 * floatfns.c (float_error): Likewise.
814 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
815 (otf_open, font_otf_capability, generate_otf_features)
816 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
817 Likewise.
818 * image.c (pbm_read_file): Likewise.
819 * indent.c (string_display_width): Likewise.
820 * intervals.c (check_for_interval, search_for_interval)
821 (inc_interval_count, count_intervals, root_interval)
822 (adjust_intervals_for_insertion, make_new_interval): Likewise.
823 * lread.c (defalias): Likewise.
268c2c36 824 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
825 * regex.c (set_image_of_range_1, set_image_of_range)
826 (regex_grow_registers): Likewise.
827 * sysdep.c (strerror): Likewise.
828 * termcap.c (valid_filename_p, tprint, main): Likewise.
829 * tparam.c (main): Likewise.
830 * unexhp9k800.c (run_time_remap, save_data_space)
831 (update_file_ptrs, read_header, write_header, calculate_checksum)
832 (copy_file, copy_rest, display_header): Likewise.
833 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
834 Likewise.
835 * xdisp.c (check_it): Likewise.
836 * xfaces.c (register_color, unregister_color, unregister_colors):
837 Likewise.
838 * xfns.c (print_fontset_result): Likewise.
839 * xrdb.c (member, fatal, main): Likewise.
840
99033785
PE
8412011-07-10 Paul Eggert <eggert@cs.ucla.edu>
842
843 Fix minor problems found by static checking (Bug#9031).
844 * chartab.c (char_table_set_range, map_sub_char_table):
845 Remove unused locals.
846 (uniprop_table): Now static.
847 * composite.c (_work_char): Remove unused static var.
848
9cb2ac56
JB
8492011-07-09 Juanma Barranquero <lekktu@gmail.com>
850
851 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
852
f25661f0
JD
8532011-07-09 Jan Djärv <jan.h.d@swipnet.se>
854
855 * gtkutil.c (qttip_cb): Remove code without function.
856
8278c4fe
EZ
8572011-07-09 Eli Zaretskii <eliz@gnu.org>
858
859 * w32.c (pthread_sigmask): New stub.
860
1692ae2d 8612011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 862
8a6ebd58 863 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
864 sigprocmask is portable only for single-threaded applications, and
865 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
866 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
867 (LIBES): Use it.
868 * callproc.c (Fcall_process):
869 * process.c (create_process):
870 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
871 Use pthread_sigmask, not sigprocmask.
123403e4 872
1b854618
JD
8732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
874
875 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
876 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
877 wrong (Bug#8591).
878
3fe4b549
JD
8792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
880
0ce7e563
JD
881 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
882 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
883 (xg_hide_tooltip): Fix comment.
884
3fe4b549
JD
885 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
886 in registerServicesMenuSendTypes.
887 (validRequestorForSendType): Don't check ns_return_types.
888
889 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
890 ns_return_type.
891
5df75e47
JR
8922011-07-08 Jason Rumney <jasonr@gnu.org>
893
894 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
895 frame struct members of non-existent frames (Bug#6284).
896
699c10bd
JD
8972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
898
4393663b
JD
899 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
900 variable firstTime not needed on OSX >= 10.6.
901 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
902 >= 10.5. Use setKnobProportion, setDoubleValue.
903
904 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
905 (MAC_OS_X_VERSION_10_5): Define if not defined.
906 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
907 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
908 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
909
910 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
911 cString and lossyCString on OSX >= 10.4
912
913 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
914 sizeToFit on OSX >= 10.2.
915
916 * nsimage.m (allocInitFromFile): Don't use deprecated method
917 bestRepresentationForDevice on OSX >= 10.6.
918
919 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
920 to avoid warning.
921
922 * emacs.c: Declare unexec_init_emacs_zone.
923
a63e0781
JD
924 * nsgui.h: Fix compiler warning about gnulib redefining verify.
925
699c10bd
JD
926 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
927
928 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
929 on svcsMenu (Bug#8842).
930
931 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
932 ns_return_types.
933 (Fns_list_services): Just return Qnil on 10.6, code not working there.
934
935 * nsterm.m (QUTF8_STRING): Declare.
936 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
937 (validRequestorForSendType): Return type is (id).
938 Change indexOfObjectIdenticalTo to indexOfObject.
939 Check if we have local selection before returning self (Bug#8842).
940 (writeSelectionToPasteboard): Put local selection into paste board
941 if we have a local selection (Bug#8842).
942 (syms_of_nsterm): DEFSYM QUTF8_STRING.
943
944 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
945 (ns_get_local_selection): Declare.
946
54e10184
LMI
9472011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
948
9888ff71
LMI
949 * keymap.c (describe_map_tree): Don't insert a double newline at
950 the end of the buffer (bug#1169) and return whether we inserted
951 something.
952
54e10184
LMI
953 * callint.c (Fcall_interactively): Change "reading args" to
954 "providing args" to try to clarify what it does (bug#1010).
955
15fa4783
KH
9562011-07-07 Kenichi Handa <handa@m17n.org>
957
958 * composite.c (composition_compute_stop_pos): Ignore a static
959 composition starting before CHARPOS (Bug#8915).
960
961 * xdisp.c (handle_composition_prop): Likewise.
962
a8815b00
EZ
9632011-07-07 Eli Zaretskii <eliz@gnu.org>
964
965 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
966 (Bug#9015)
967
ef7b981d 9682011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
969
970 * character.h (unicode_category_t): New enum type.
971
972 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
973 (Qchar_code_property_table): New variable.
974 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
975 (UNIPROP_COMPRESSED_FORM_P): New macros.
976 (char_table_ascii): Uncompress the compressed values.
977 (sub_char_table_ref): New arg is_uniprop. Callers changed.
978 Uncompress the compressed values.
ac389d0c 979 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
980 (char_table_ref_and_range): Uncompress the compressed values.
981 (sub_char_table_set): New arg is_uniprop. Callers changed.
982 Uncompress the compressed values.
983 (sub_char_table_set_range): Args changed. Callers changed.
984 (char_table_set_range): Adjuted for the above change.
985 (map_sub_char_table): Delete args default_val and parent. Add arg
986 top. Give decoded values to a Lisp function.
987 (map_char_table): Adjusted for the above change. Give decoded
988 values to a Lisp function. Gcpro more variables.
989 (uniprop_table_uncompress)
990 (uniprop_decode_value_run_length): New functions.
991 (uniprop_decoder, uniprop_decoder_count): New variables.
992 (uniprop_get_decoder, uniprop_encode_value_character)
993 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
994 New functions.
995 (uniprop_encoder, uniprop_encoder_count): New variables.
996 (uniprop_get_encoder, uniprop_table)
997 (Funicode_property_table_internal, Fget_unicode_property_internal)
998 (Fput_unicode_property_internal): New functions.
999 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1000 Sunicode_property_table_internal, Sget_unicode_property_internal,
1001 and Sput_unicode_property_internal. Defvar_lisp
1002 char-code-property-alist.
1003
1004 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1005 Vunicode_category_table.
1006
1007 * font.c (font_range): Adjusted for the change of
1008 Vunicode_category_table.
1009
76b397fb
DN
10102011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1011
1012 * m/iris4d.h: Remove file, move contents ...
1013 * s/irix6-5.h: ... here.
1014
22b4128e
PE
10152011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1018 * alloc.c (mark_buffer):
1019 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1020 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1021 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1022 This isn't true in general, and it's particularly not true
1023 if Emacs is configured with --with-wide-int.
1024 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1025 New macros, used in the buffer.c change.
1026
869795d6
JD
10272011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1028
1029 * xsettings.c: Use both GConf and GSettings if both are available.
1030 (store_config_changed_event): Add comment.
1031 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1032 (store_tool_bar_style_changed): New functions.
1033 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1034 (struct xsettings): Move font inside HAVE_XFT.
1035 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1036 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1037 Move inside HAVE_XFT.
1038 (something_changed_gsettingsCB): Renamed from something_changedCB.
1039 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1040 also.
1041 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1042 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1043 (something_changed_gconfCB): Renamed from something_changedCB.
1044 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1045 (parse_settings): Move check for font inside HAVE_XFT.
1046 (read_settings, apply_xft_settings): Add comment.
1047 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1048 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1049 call store_font_name_changed.
1050 (xft_settings_event): Add comment.
1051 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1052 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1053 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1054 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1055 (xsettings_initialize): Call init_gsettings last.
1056 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1057 comment.
1058
d8ed26bd
PE
10592011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 Random fixes. E.g., (random) never returned negative values.
1062 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1063 subseconds part to the entropy, as that's a bit more random.
1064 Prefer signed to unsigned, since the signedness doesn't matter and
1065 in general we prefer signed. When given a limit, use a
1066 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1067 latter isn't right if USE_2_TAGS_FOR_INTS.
1068 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1069 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1070
cabf1cac
SM
10712011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1072
1073 * textprop.c (text_property_stickiness):
1074 Obey Vtext_property_default_nonsticky.
1075 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1076 * w32fns.c (syms_of_w32fns):
1077 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1078
6e9b2be9
PE
10792011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1082 This is more efficient than Ffile_directory_p and avoids a minor race.
1083
90186c68
LMI
10842011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1085
7c301272
LMI
1086 * buffer.c (Foverlay_put): Say what the return value is
1087 (bug#7835).
1088
c4f2d8d4
LMI
1089 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1090 is a directory before asking whether to use the file name
1091 (bug#7564).
ad637907
LMI
1092 (barf_or_query_if_file_exists): Make the "File is a directory"
1093 error be more correct.
c4f2d8d4 1094
90186c68
LMI
1095 * fns.c (Frequire): Remove the mention of the .gz files, since
1096 that's installation-specific, but keep the mention of
1097 `get-load-suffixes'.
1098
da64016e
PE
10992011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1102 Report string overflow if the output is too long.
1103
7d47b580
JB
11042011-07-04 Juanma Barranquero <lekktu@gmail.com>
1105
a555cb87
JB
1106 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1107 (syms_of_gnutls): Remove duplicate DEFSYM for
1108 Qgnutls_bootprop_verify_hostname_error, an error for
1109 Qgnutls_bootprop_verify_error (which is no longer used).
1110
7d47b580
JB
1111 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1112 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1113 Also (re)move comments that are misplaced or no longer relevant.
1114
1e49bfab
LMI
11152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1116
1117 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1118
1485f4c0
CY
11192011-07-03 Chong Yidong <cyd@stupidchicken.com>
1120
1121 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1122 and background color parameters if they have been changed.
1123
a9ab721e
LMI
11242011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1125
1126 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1127
cf7cff57
PE
11282011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1129
2e13213d
PE
1130 * xsettings.c (SYSTEM_FONT): Define only when used.
1131 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1132
cf7cff57
PE
1133 * keymap.c (access_keymap_1): Now static.
1134
7a8e04f7
CY
11352011-07-02 Chong Yidong <cyd@stupidchicken.com>
1136
1137 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1138 leave any prefix arg for the up event (Bug#1586).
1139
61352f62
LMI
11402011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1141
69bb1ef7
LMI
1142 * lread.c (syms_of_lread): Mention single symbols defined by
1143 `defvar' or `defconst' (bug#7154).
1144
61352f62 1145 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1146 (Frequire): Mention get-load-suffixes.
61352f62 1147
28545e04
MR
11482011-07-02 Martin Rudalics <rudalics@gmx.at>
1149
1150 * window.h (window): Remove clone_number slot.
1151 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1152 Remove.
1153 (make_parent_window, make_window, saved_window)
1154 (Fset_window_configuration, save_window_save): Don't deal with
1155 clone numbers.
1156 * buffer.c (Qclone_number): Remove declaration.
1157 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1158
3349e122
SM
11592011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1160
1161 Add multiple inheritance to keymaps.
1162 * keymap.c (Fmake_composed_keymap): New function.
1163 (Fset_keymap_parent): Simplify.
1164 (fix_submap_inheritance): Remove.
1165 (access_keymap_1): New function extracted from access_keymap to handle
1166 embedded parents and handle lists of maps.
1167 (access_keymap): Use it.
1168 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1169 (Fcopy_keymap): Handle embedded parents.
1170 (Fcommand_remapping, define_as_prefix): Simplify.
1171 (Fkey_binding): Simplify.
1172 (syms_of_keymap): Move minibuffer-local-completion-map,
1173 minibuffer-local-filename-completion-map,
1174 minibuffer-local-must-match-map, and
1175 minibuffer-local-filename-must-match-map to Elisp.
1176 (syms_of_keymap): Defsubr make-composed-keymap.
1177 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1178 (parse_menu_item): Trivial simplification.
1179
3279eb87
GM
11802011-07-01 Glenn Morris <rgm@gnu.org>
1181
1182 * Makefile.in (SETTINGS_LIBS): Fix typo.
1183
4550efdf
KI
11842011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1185
1186 * coding.c (Fencode_coding_string): Record the last coding system
1187 used, as the function doc string says (bug#8738).
1188
0949d2b6
JD
11892011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1190
1191 * xsettings.c (store_monospaced_changed): Take new font as arg and
1192 check for change against current_mono_font.
1193 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1194 (emacs_settings_constructor, emacs_settings_get_property)
1195 (emacs_settings_set_property, emacs_settings_class_init)
1196 (emacs_settings_init, gsettings_obj): Remove.
1197 (something_changedCB): New function for HAVE_GSETTINGS.
1198 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1199 with value as argument.
1200 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1201 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1202 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1203 "changed".
1204
1205 * xgselect.c: Add defined (HAVE_GSETTINGS).
1206 (xgselect_initialize): Ditto.
1207
1208 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1209 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1210 xg_select.
1211
bbc6b304
PE
12122011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1213
1214 * eval.c (struct backtrace): Simplify and port the data structure.
1215 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1216 signed bit field, as this assumption is not portable and it makes
1217 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1218 "char debug_on_exit : 1" as this is not portable either; instead,
1219 use the portable "unsigned int debug_on_exit : 1". Remove unused
1220 member evalargs. Remove obsolete comments about cc bombing out.
1221
9851bfc5
JD
12222011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1223
51bb811f 1224 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1225 Let HAVE_GSETTINGS override HAVE_GCONF.
1226 (store_monospaced_changed): New function.
1227 (EMACS_SETTINGS): A new type derived from GObject to handle
1228 GSettings notifications.
1229 (emacs_settings_constructor, emacs_settings_get_property)
1230 (emacs_settings_set_property, emacs_settings_class_init):
1231 New functions.
1232 (gsettings_client, gsettings_obj): New variables.
1233 (GSETTINGS_SCHEMA): New define.
1234 (something_changedCB): Call store_monospaced_changed.
1235 (init_gsettings): New function.
1236 (xsettings_initialize): Call init_gsettings.
1237 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1238 to NULL.
1239
1240 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1241 GCONF_CFLAGS/LIBS.
1242
5386012d
MR
12432011-06-29 Martin Rudalics <rudalics@gmx.at>
1244
1245 * window.c (resize_root_window, grow_mini_window)
1246 (shrink_mini_window): Rename Qresize_root_window to
1247 Qwindow_resize_root_window and Qresize_root_window_vertically to
1248 Qwindow_resize_root_window_vertically.
1249
f13e0b08
PE
12502011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1253
94515237
JB
12542011-06-27 Juanma Barranquero <lekktu@gmail.com>
1255
1256 * makefile.w32-in: Redesign dependencies so they reflect more
1257 clearly which files are directly included by each source file,
1258 and not through other includes.
1259
e43b6e43
MR
12602011-06-27 Martin Rudalics <rudalics@gmx.at>
1261
1262 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1263 (sort_overlays, overlay_strings): When an overlay's clone number
1264 matches the window's clone number process the overlay even if
1265 the overlay's window property doesn't match the current window.
1266
d68443dc
MR
1267 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1268 (Fwindow_hchild): Rename to Fwindow_left_child.
1269 (Fwindow_next): Rename to Fwindow_next_sibling.
1270 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1271 (resize_window_check): Rename to window_resize_check.
1272 (resize_window_apply): Rename to window_resize_apply.
1273 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1274 (Fdelete_other_windows_internal, resize_frame_windows)
1275 (Fsplit_window_internal, Fdelete_window_internal)
1276 (grow_mini_window, shrink_mini_window)
1277 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1278
c7e73be5
JD
12792011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1280
1281 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1282 (emacs_fixed_set_min_size): Remove.
1283 (emacs_fixed_new): Take frame as argument.
1284
1285 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1286 (_EmacsFixedPrivate): Remove minwidth/height.
1287 Add struct frame *f.
1288 (emacs_fixed_init): Initialize priv->f.
1289 (get_parent_class, emacs_fixed_set_min_size): Remove.
1290 (emacs_fixed_new): Set priv->f to argument.
1291 (emacs_fixed_get_preferred_width)
1292 (emacs_fixed_get_preferred_height): Use min_width/height from
1293 frames size_hint to set minimum and natural (Bug#8919).
1294 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1295 and use min_width/height from frames size_hint to set
1296 min_width/height (Bug#8919).
1297
1298 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1299 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1300 Fix indentation.
c7e73be5 1301
cf99dcf8
EZ
13022011-06-26 Eli Zaretskii <eliz@gnu.org>
1303
1304 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1305 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1306 called at ZV.
1307
029529ac
CY
13082011-06-26 Chong Yidong <cyd@stupidchicken.com>
1309
1310 * process.c (wait_reading_process_output): Bypass select if
1311 waiting for a cell while ignoring keyboard input, and input is
1312 pending. Suggested by Jan Djärv (Bug#8869).
1313
7a7ef429
PE
13142011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 Use gnulib's dup2 module instead of rolling our own.
1317 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1318
11fdef7d 13192011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1320
1321 * dispnew.c (scrolling_window): Before scrolling, turn off a
1322 mouse-highlight in the window being scrolled.
1323
cd3520a4
JB
13242011-06-24 Juanma Barranquero <lekktu@gmail.com>
1325
1326 Move DEFSYM to lisp.h and use everywhere.
1327
1328 * character.h (DEFSYM): Move declaration...
1329 * lisp.h (DEFSYM): ...here.
1330
1331 * gnutls.c:
1332 * minibuf.c:
1333 * w32menu.c:
1334 * w32proc.c:
1335 * w32select.c: Don't include character.h.
1336
1337 * alloc.c (syms_of_alloc):
1338 * buffer.c (syms_of_buffer):
1339 * bytecode.c (syms_of_bytecode):
1340 * callint.c (syms_of_callint):
1341 * casefiddle.c (syms_of_casefiddle):
1342 * casetab.c (init_casetab_once):
1343 * category.c (init_category_once, syms_of_category):
1344 * ccl.c (syms_of_ccl):
1345 * cmds.c (syms_of_cmds):
1346 * composite.c (syms_of_composite):
1347 * dbusbind.c (syms_of_dbusbind):
1348 * dired.c (syms_of_dired):
1349 * dispnew.c (syms_of_display):
1350 * doc.c (syms_of_doc):
1351 * editfns.c (syms_of_editfns):
1352 * emacs.c (syms_of_emacs):
1353 * eval.c (syms_of_eval):
1354 * fileio.c (syms_of_fileio):
1355 * fns.c (syms_of_fns):
1356 * frame.c (syms_of_frame):
1357 * fringe.c (syms_of_fringe):
1358 * insdel.c (syms_of_insdel):
1359 * keymap.c (syms_of_keymap):
1360 * lread.c (init_obarray, syms_of_lread):
1361 * macros.c (syms_of_macros):
1362 * msdos.c (syms_of_msdos):
1363 * print.c (syms_of_print):
1364 * process.c (syms_of_process):
1365 * search.c (syms_of_search):
1366 * sound.c (syms_of_sound):
1367 * syntax.c (init_syntax_once, syms_of_syntax):
1368 * terminal.c (syms_of_terminal):
1369 * textprop.c (syms_of_textprop):
1370 * undo.c (syms_of_undo):
1371 * w32.c (globals_of_w32):
1372 * window.c (syms_of_window):
1373 * xdisp.c (syms_of_xdisp):
1374 * xfaces.c (syms_of_xfaces):
1375 * xfns.c (syms_of_xfns):
1376 * xmenu.c (syms_of_xmenu):
1377 * xsettings.c (syms_of_xsettings):
1378 * xterm.c (syms_of_xterm): Use DEFSYM.
1379
4228cf16
TZ
13802011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1381
cd3520a4 1382 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1383
7fcccf1e
PE
13842011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1385
7efb4e0e
PE
1386 Integer and buffer overflow fixes (Bug#8873).
1387
ff5844ad
PE
1388 * print.c (printchar, strout): Check for string overflow.
1389 (PRINTPREPARE, printchar, strout):
1390 Don't set size unless allocation succeeds.
1391
90532f02
PE
1392 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1393 for sizes. Check for string overflow more accurately.
1394 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1395
6d84508d
PE
1396 * macros.c: Integer and buffer overflow fixes.
1397 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1398 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1399 Use ptrdiff_t, not int, for sizes.
1400 Don't increment bufsize until after realloc succeeds.
1401 Check for size-calculation overflow.
1402 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1403
437b2cb4
PE
1404 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1405
8b9ac8b4
PE
1406 * lread.c: Integer overflow fixes.
1407 (read_integer): Radix is now EMACS_INT, not int,
1408 to improve quality of diagnostics for out-of-range radices.
1409 Calculate buffer size correctly for out-of-range radices.
1410 (read1): Check for integer overflow in radices, and in
1411 read-circle numbers.
82cb60d3
PE
1412 (read_escape): Avoid int overflow.
1413 (Fload, openp, read_buffer_size, read1)
1414 (substitute_object_recurse, read_vector, read_list, map_obarray):
1415 Use ptrdiff_t, not int, for sizes.
1416 (read1): Use EMACS_INT, not int, for sizes.
20270765 1417 Check for size overflow.
8b9ac8b4 1418
7fcccf1e
PE
1419 * image.c (cache_image): Check for size arithmetic overflow.
1420
bfbbd7e7
PE
1421 * lread.c: Integer overflow issues.
1422 (saved_doc_string_size, saved_doc_string_length)
1423 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1424 Now ptrdiff_t, not int.
1425 (read1): Don't assume doc string length fits in int. Check for
1426 out-of-range doc string lengths.
1427 (read_list): Don't assume file position fits in int.
39019e54 1428 (read_escape): Check for hex character overflow.
bfbbd7e7 1429
4e323265
LL
14302011-06-22 Leo Liu <sdl.web@gmail.com>
1431
1432 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1433 Move to minibuffer.el.
1434
85fece3e
PE
14352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1436
20b84ce9 1437 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1438 The following patches are for when GLYPH_DEBUG && !XASSERT.
1439 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1440 * dispnew.c (flush_stdout):
1441 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1442 Mark as externally visible.
1443 * dispnew.c (check_window_matrix_pointers): Now static.
1444 * dispnew.c (window_to_frame_vpos):
1445 * xfns.c (unwind_create_frame):
1446 * xterm.c (x_check_font): Remove unused local.
1447 * scroll.c (CHECK_BOUNDS):
1448 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1449 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1450 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1451 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1452 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1453 Now static.
1454 (debug_method_add): Use va_list and vsprintf rather than relying
1455 on undefined behavior with wrong number of arguments.
1456 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1457 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1458 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1459 since we're not interested in debugging glyphs with old libraries.
1460 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1461 GCC 4.6.0's static checking.
1462
0766b489
PE
14632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1464
31fd4b32
PE
1465 Integer overflow and signedness fixes (Bug#8873).
1466 A few related buffer overrun fixes, too.
1467
b79e8648
PE
1468 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1469
0766b489
PE
1470 * dispextern.h (struct face.stipple):
1471 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1472 (x_bitmap_mask, x_allocate_bitmap_record)
1473 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1474 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1475 (x_create_bitmap_from_xpm_data):
1476 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1477 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1478 (.bitmaps_last):
1479 * xfaces.c (load_pixmap):
1480 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1481 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1482 (.bitmaps_last, struct x_output.icon_bitmap):
1483 Use ptrdiff_t, not int, for bitmap indexes.
1484 (x_allocate_bitmap_record): Check for size overflow.
1485 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1486
b081724f
PE
1487 Use ptrdiff_t, not int, for overlay counts.
1488 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1489 * editfns.c (overlays_around, get_pos_property):
1490 * textprop.c (get_char_property_and_overlay):
1491 * xdisp.c (next_overlay_change, note_mouse_highlight):
1492 * xfaces.c (face_at_buffer_position):
21514da7
PE
1493 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1494 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1495 (Fnext_overlay_change, Fprevious_overlay_change)
1496 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1497 Use ptrdiff_t, not int, for sizes.
21514da7 1498 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1499
3de73e5e
PE
1500 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1501
2606c57b
PE
1502 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1503 (x_session_initialize): Do not assume string length fits in int.
1504
aaafe47a
PE
1505 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1506 This is unlikely, but can occur if DPI is outlandish.
1507
2674ddc8 1508 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1509 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1510
28154962
PE
1511 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1512 * xrdb.c (magic_file_p, search_magic_path):
1513 Omit last arg SUFFIX; it was always 0. All callers changed.
1514 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1515
7de51af5
PE
1516 * xfont.c (xfont_match): Avoid need for strlen.
1517
25ed6cc3
PE
1518 * xfns.c: Don't assume strlen fits in int.
1519 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1520
4eab31dd
PE
1521 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1522 not unsigned long, as we prefer signed integers. All callers changed.
1523 Detect integer overflow in repeat count.
1524 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1525 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1526
171e2a58
PE
1527 * termcap.c: Don't assume sizes fit in int and never overflow.
1528 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1529 (gobble_line): Check for size-calculation overflow.
1530
ad39faca 1531 * minibuf.c (Fread_buffer):
6e5bb2dc 1532 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1533 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1534 Don't assume string length fits in int.
1535
52c61c22 1536 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1537 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1538
b5b8c9e5
PE
1539 * font.c: Don't assume string length fits in int.
1540 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1541 Use ptrdiff_t, not int.
ccd6111c
PE
1542 (font_intern_prop): Don't assume string length fits in int.
1543 Don't assume integer property fits in fixnum.
1544 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1545
882f0d81 1546 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1547 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1548 Reformulate so as not to need the command string.
1549 Invoke gzip -cd rather than gunzip, as it's more portable.
1550 (lock_info_type, lock_file_1, lock_file):
1551 Don't assume pid_t and time_t fit in unsigned long.
1552 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1553 (current_lock_owner): Prefer signed type for sizes.
1554 Use memcpy, not strncpy, where memcpy is what is really wanted.
1555 Don't assume (via atoi) that time_t and pid_t fit in int.
1556 Check for time_t and/or pid_t out of range, e.g., via a network share.
1557 Don't alloca where an auto var works fine.
1558
93f4cf88
PE
1559 * fileio.c: Fix some integer overflow issues.
1560 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1561 Don't assume string length fits in int.
1562 (directory_file_name): Don't assume string length fits in long.
1563 (make_temp_name): Don't assume pid fits in int, or that its print
1564 length is less than 20.
1565
f3e92b69
PE
1566 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1567
1bfdaf10
PE
1568 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1569
35016e9a
PE
1570 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1571
3d1e65a1
PE
1572 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1573 We prefer signed integers, even for size calculations.
1574
0b963a93
PE
1575 * emacs.c: Don't assume string length fits in 'int'.
1576 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1577 (main): Don't invoke strlen when not needed.
1578
573f4b54
PE
1579 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1580 (XD_DEBUG_MESSAGE): Don't waste a byte.
1581
989f33ba
PE
1582 * callproc.c (getenv_internal_1, getenv_internal)
1583 (Fgetenv_internal):
965d34eb
PE
1584 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1585
e4d29b33
PE
1586 * lread.c (invalid_syntax): Omit length argument.
1587 All uses changed. This doesn't fix a bug, but it simplifies the
1588 code away from its former Hollerith-constant appearance, and it's
1589 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1590 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1591
eb49b136
PE
1592 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1593 This didn't break anything, but it didn't help either.
1594 It's confusing to put a bogus integer in a place where the actual
1595 value does not matter.
9f62aeb1 1596 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1597 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1598
15375a22
PE
1599 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1600 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1601 implementation.
b61cc01c
PE
1602 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1603 We prefer signed types, and the value cannot exceed the EMACS_INT
1604 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1605 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1606 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1607 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1608
53b2623d
PE
1609 * indent.c (sane_tab_width): New function.
1610 (current_column, scan_for_column, Findent_to, position_indentation)
1611 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1612 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1613
51cab52b 1614 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1615
f2ed8a70
PE
1616 * lisp.h (lint_assume): New macro.
1617 * composite.c (composition_gstring_put_cache):
1618 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1619
abe80cc6
PE
1620 * editfns.c, insdel.c:
1621 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1622
b02c740e
PE
1623 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1624
ebc96716
PE
1625 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1626
b4e50fa0 1627 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1628 Use much-faster test for byte-length change.
311d5d7c 1629 Don't assume string byte-length fits in 'int'.
a4cf38e4 1630 Check that character arg fits in 'int'.
85461888 1631 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1632
c0c1ee9f
PE
1633 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1634
a498d7f4
PE
1635 * fns.c (concat): Catch string overflow earlier.
1636 Do not rely on integer wraparound.
1637
51cab52b
PE
1638 * dispextern.h (struct it.overlay_strings_charpos)
1639 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1640 * xdisp.c (forward_to_next_line_start)
1641 (back_to_previous_visible_line_start)
1642 (reseat_at_next_visible_line_start, next_element_from_buffer):
1643 Don't arbitrarily truncate the value of 'selective' to int.
1644
76031fad
PE
1645 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1646
5eb55db9
PE
1647 * composite.c: Don't truncate sizes to 'int'.
1648 (composition_gstring_p, composition_reseat_it)
1649 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1650 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1651 not EMACS_UINT, for indexes.
5eb55db9 1652
0703a717
PE
1653 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1654
d6202519
PE
1655 * buffer.c: Include <verify.h>.
1656 (struct sortvec.priority, struct sortstr.priority):
8961a454 1657 Now EMACS_INT, not int.
c20998a7 1658 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1659 (struct sortstr.size, record_overlay_string)
1660 (struct sortstrlist.size, struct sortlist.used):
1661 Don't truncate size to int.
1662 (record_overlay_string): Check for size-calculation overflow.
d6202519 1663 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1664
d5a19415
JM
16652011-06-22 Jim Meyering <meyering@redhat.com>
1666
029529ac 1667 Don't leak an XBM-image-sized buffer
d5a19415
JM
1668 * image.c (xbm_load): Free the image buffer after using it.
1669
a9041e6c
PE
16702011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 Port to Sun C.
1673 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1674 that Sun C diagnosed.
1675 * fns.c (secure_hash): Fix pointer signedness issue.
1676 * intervals.c (static_offset_intervals): New function.
1677 (offset_intervals): Use it.
1678
7f3f739f
LL
16792011-06-21 Leo Liu <sdl.web@gmail.com>
1680
1681 * deps.mk (fns.o):
1682 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1683 sha512.h.
1684
1685 * fns.c (secure_hash): Rename from crypto_hash_function and change
1686 the first arg to accept symbols.
5b66d427 1687 (Fsecure_hash): New primitive.
7f3f739f
LL
1688 (syms_of_fns): New symbols.
1689
76147d94
DD
16902011-06-20 Deniz Dogan <deniz@dogan.se>
1691
1692 * process.c (Fset_process_buffer): Clarify return value in
1693 docstring.
1694
7d7d0045
CY
16952011-06-18 Chong Yidong <cyd@stupidchicken.com>
1696
1697 * dispnew.c (add_window_display_history): Use BVAR.
1698
1699 * xdisp.c (debug_method_add): Use BVAR.
1700 (check_window_end, dump_glyph_matrix, dump_glyph)
1701 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1702
1703 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1704 Likewise.
1705
1706 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1707 check till after the cache is created in init_frame_faces.
1708
ff2bc410
SM
17092011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1710
1711 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1712
28177add
PE
17132011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1714
dd3482fe
PE
1715 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1716 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1717 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1718
393d71f3 1719 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1720 * fileio.c (Finsert_file_contents):
1721 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1722 Remove the old (too-loose) buffer overflow checks.
1723 They weren't needed, since make_gap checks for buffer overflow.
1724 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1725 The old code merely checked for Emacs fixnum overflow, and relied
1726 on undefined (wraparound) behavior. The new code avoids undefined
1727 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1728
2e6813b0 1729 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1730 Tune. Don't use wider integers than needed. Don't use alloca.
1731 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1732
599a9e4f
PE
1733 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1734
99561444
PE
1735 * insdel.c, lisp.h (buffer_overflow): New function.
1736 (insert_from_buffer_1, replace_range, replace_range_2):
1737 * insdel.c (make_gap_larger):
1738 * editfns.c (Finsert_char):
1739 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1740
28177add
PE
1741 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1742
e69dafad
PE
17432011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1744
a7af7fde 1745 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1746
b1c46f02
PE
1747 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1748 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1749
e69dafad
PE
1750 * fileio.c: Don't assume EMACS_INT fits in off_t.
1751 (emacs_lseek): New static function.
1752 (Finsert_file_contents, Fwrite_region): Use it.
1753 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1754
566684ea
PE
1755 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1756
e6966cd6
PE
1757 * fns.c: Don't overflow int when computing a list length.
1758 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1759 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1760 truncation on 64-bit hosts. Check for QUIT every
1761 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1762 faster and is responsive enough.
1763 (Flength): Report an error instead of overflowing an integer.
1764 (Fsafe_length): Return a float if the value is not representable
1765 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1766 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1767 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1768
dd0b0efb
PE
1769 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1770 (header_size, word_size): New constants.
1771 (allocate_vectorlike): Don't check size overflow here.
1772 (allocate_vector): Check it here instead, since this is the only
1773 caller of allocate_vectorlike that could cause overflow.
1774 Check that the new vector's length is representable as a fixnum.
1775
86fe5cfe
PE
1776 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1777 The previous code was bogus. For example, next_almost_prime (32)
1778 returned 39, which is undesirable as it is a multiple of 3; and
1779 next_almost_prime (24) returned 25, which is a multiple of 5 so
1780 why was the code bothering to check for multiples of 7?
1781
80e88859
PE
1782 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1783
4a2f0ad6
PE
1784 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1785
f66c7cf8
PE
1786 Variadic C functions now count arguments with ptrdiff_t.
1787 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1788 Back then I didn't know that the Emacs coding style prefers signed int.
1789 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1790 were being counted with int, which may truncate counts on 64-bit
1791 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1792 * lisp.h (struct Lisp_Subr.function.aMANY)
1793 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1794 Arg counts are now ptrdiff_t, not size_t.
1795 All variadic functions and their callers changed accordingly.
1796 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1797 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1798 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1799 * callint.c (Fcall_interactively): Check arg count for overflow,
1800 to avoid potential buffer overrun. Use signed char, not 'int',
1801 for 'varies' array, so that we needn't bother to check its size
1802 calculation for overflow.
1803 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1804 * eval.c (apply_lambda):
1805 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1806 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1807 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1808
a1759b76
PE
1809 * callint.c (Fcall_interactively): Don't use index var as event count.
1810
d96be9fc
PE
1811 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1812 * mem-limits.h (SIZE): Remove; no longer used.
1813
a690a978 1814 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1815
578c21e6
PE
1816 Remove unnecessary casts.
1817 * xterm.c (x_term_init):
1818 * xfns.c (x_set_border_pixel):
1819 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1820 These aren't needed now that we assume ANSI C.
1821
96f53c6c
PE
1822 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1823 It's more likely to cause problems (due to unsigned overflow)
1824 than to cure them.
1825
83c77d31
PE
1826 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1827
ee2079f1
PE
1828 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1829
6da65536
PE
1830 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1831
7147c4a4
PE
1832 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1833
193e32d9
PE
1834 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1835
e5533da6
PE
1836 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1837
9910e595
PE
1838 GLYPH_CODE_FACE returns EMACS_INT, not int.
1839 * dispextern.h (merge_faces):
1840 * xfaces.c (merge_faces):
01103c44
PE
1841 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1842 Don't assume EMACS_INT fits in int.
9910e595 1843
2638320e
PE
1844 * character.h (CHAR_VALID_P): Remove unused parameter.
1845 * fontset.c, lisp.h, xdisp.c: All uses changed.
1846
045eb8d9
PE
1847 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1848
c1f134b5
PE
1849 * fns.c (concat): Minor tuning based on overflow analysis.
1850 This doesn't fix any bugs. Use int to hold character, instead
1851 of constantly refetching from Emacs object. Use XFASTINT, not
1852 XINT, for value known to be a character. Don't bother comparing
1853 a single byte to 0400, as it's always less.
1854
395fcb93 1855 * floatfns.c (Fexpt):
327eeec8
PE
1856 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1857
abbd3d23
PE
1858 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1859 for characters.
1860
684a03ef
PE
1861 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1862
0fed43f3
PE
1863 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1864 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1865 incorrectly succeed when S was a string, because 4294967386 was
1866 truncated before it was used.
1867
8fd02eb7
PE
1868 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1869 Otherwise, an out-of-range integer could cause undefined behavior
1870 on a 64-bit host.
1871
f8c86b69
PE
1872 * composite.c: Use int, not EMACS_INT, for characters.
1873 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1874 EMACS_INT, for values that are known to be in character range.
1875 This doesn't fix any bugs but is the usual style inside Emacs and
1876 may generate better code on 32-bit machines.
1877
34206dd2
PE
1878 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1879 This is for reasons similar to the recent CHAR_STRING fix.
1880 * charset.c (Fencode_char): Check that character arg is actually
1881 a character. Pass an int to ENCODE_CHAR.
1882 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1883 wider than 'int', as a compile-time check to prevent future regressions
1884 in this area.
1885
c5958d4c 1886 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1887
1888 Make sure a 64-bit char is never passed to CHAR_STRING.
1889 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1890 by silently ignoring the top 32 bits, allowing some values
1891 that were far too large to be valid characters.
1892 * character.h: Include <verify.h>.
1893 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1894 arguments are no wider than unsigned, as a compile-time check
1895 to prevent future regressions in this area.
1896 * data.c (Faset):
01103c44 1897 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1898 (Fsubst_char_in_region):
1899 * fns.c (concat):
1900 * xdisp.c (decode_mode_spec_coding):
1901 Adjust to CHAR_STRING's new requirement.
1902 * editfns.c (Finsert_char, Fsubst_char_in_region):
1903 * fns.c (concat): Check that character args are actually
1904 characters. Without this test, these functions did the wrong
1905 thing with wildly out-of-range values on 64-bit hosts.
1906
d37ca623
PE
1907 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1908 These casts should not be needed on 32-bit hosts, either.
1909 * keyboard.c (read_char):
1910 * lread.c (Fload): Remove casts to unsigned.
1911
ea204efb
PE
1912 * lisp.h (UNSIGNED_CMP): New macro.
1913 This fixes comparison bugs on 64-bit hosts.
1914 (ASCII_CHAR_P): Use it.
1915 * casefiddle.c (casify_object):
01103c44 1916 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1917 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1918 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1919 * dispextern.h (FACE_FROM_ID):
1920 * keyboard.c (read_char): Use UNSIGNED_CMP.
1921
41cb286c
PE
1922 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1923 not to EMACS_INT, to avoid GCC warning.
1924
4a1b9832
PE
1925 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1926
55daad71
PE
1927 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1928 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1929 isn't needed on 32-bit machines.
8f95c75c 1930
01103c44
PE
1931 * buffer.c (Fgenerate_new_buffer_name):
1932 Use EMACS_INT for count, not int.
0ceccced 1933 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1934
1935 * data.c (Qcompiled_function): Now static.
1936
c6f072e7
PE
1937 * window.c (window_body_lines): Now static.
1938
20ce5912
PE
1939 * image.c (gif_load): Rename local to avoid shadowing.
1940
9c4c5f81
PE
1941 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1942 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1943 * alloc.c (make_save_value): Integer argument is now of type
1944 ptrdiff_t, not int.
1945 (mark_object): Use ptrdiff_t, not int.
1946 * lisp.h (pD): New macro.
1947 * print.c (print_object): Use it.
1948
c0c5c8ae
PE
1949 * alloc.c: Use EMACS_INT, not int, to count objects.
1950 (total_conses, total_markers, total_symbols, total_vector_size)
1951 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1952 (total_free_floats, total_floats, total_free_intervals)
1953 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1954 Now EMACS_INT, not int. All uses changed.
1955 (Fgarbage_collect): Compute overall total using a double, so that
1956 integer overflow is less likely to be a problem. Check for overflow
1957 when converting back to an integer.
5a25e253
PE
1958 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1959 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1960 These were 'int' variables that could overflow on 64-bit hosts;
1961 they were never used, so remove them instead of repairing them.
211a0b2a 1962 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1963 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1964 Previously, this ceilinged at INT_MAX, but that doesn't work on
1965 64-bit machines.
e46bb31a 1966 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1967
c78baabf 1968 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1969 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1970 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1971 when a (possibly-narrower) signed value would do just as well.
1972 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1973
c9d624c6
PE
1974 * alloc.c: Catch some string size overflows that we were missing.
1975 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1976 for convenience in STRING_BYTES_MAX.
1977 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1978 The definition here is exact; the one in lisp.h was approximate.
1979 (allocate_string_data): Check for string overflow. This catches
1980 some instances we weren't catching before. Also, it catches
1981 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1982 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1983 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1984
c9d624c6
PE
1985 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1986 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1987 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1988
353032ce
PE
1989 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1990
2bccce07
PE
1991 * alloc.c (Fmake_string): Check for out-of-range init.
1992
0ac30604
SM
19932011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1994
1995 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1996
c195f2de
JD
19972011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1998
1999 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2000 xg_get_default_scrollbar_width.
2001
2002 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2003 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2004 (style_changed_cb): Call update_theme_scrollbar_width and call
2005 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2006 all frames (Bug#8505).
2007 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2008 Call gtk_window_set_resizable if HAVE_GTK3.
2009 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2010 and height if HAVE_GTK3 (Bug#8505).
2011 (scroll_bar_width_for_theme): New variable.
2012 (update_theme_scrollbar_width): New function.
2013 (xg_get_default_scrollbar_width): Move code to
2014 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2015 (xg_initialize): Call update_theme_scrollbar_width.
2016
2017 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2018
2019 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2020
e10ac9f1
MR
20212011-06-12 Martin Rudalics <rudalics@gmx.at>
2022
2023 * frame.c (make_frame): Call other_buffer_safely instead of
2024 other_buffer.
2025
2026 * window.c (temp_output_buffer_show): Call display_buffer with
2027 second argument Vtemp_buffer_show_specifiers and reset latter
2028 immediately after the call.
2029 (Vtemp_buffer_show_specifiers): New variable.
2030 (auto_window_vscroll_p, next_screen_context_lines)
2031 (Vscroll_preserve_screen_position): Remove leading asterisks from
2032 doc-strings.
2033
2d3c217e 20342011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2035
7b7f97e8 2036 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2037 * buffer.c (Qclone_number): Remove for now, as it's unused.
2038 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2039 (record_buffer): Remove unused local.
2040 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2041 (set_frame_buffer_list): Remove; unused.
2042 * frame.h (other_visible_frames): Remove decl.
2043 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2044 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2045 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2046 if HAVE_GPM.
2047 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2048 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2049 Define only if HAVE_GPM.
2050 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2051 (update_hints_inhibit): Remove; never set. All uses removed.
2052 * widgetprv.h (emacsFrameClassRec): Remove decl.
2053 * window.c (delete_deletable_window): Now returns void, since it
2054 wasn't returning anything.
2055 (compare_window_configurations): Remove unused locals.
2056 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2057 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2058 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2059 the same widths as pointers. This follows up on the 2011-05-06 patch.
2060 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2061 * xterm.h: Likewise.
2062 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2063
1384b89e
JB
20642011-06-12 Juanma Barranquero <lekktu@gmail.com>
2065
2066 * makefile.w32-in: Update dependencies.
2067 (LISP_H): Add lib/intprops.h.
2068
1100a63c
CY
20692011-06-11 Chong Yidong <cyd@stupidchicken.com>
2070
2071 * image.c (gif_load): Add animation frame delay to the metadata.
2072 (syms_of_image): Use DEFSYM. New symbol `delay'.
2073
6198ccd0
MR
20742011-06-11 Martin Rudalics <rudalics@gmx.at>
2075
2076 * window.c (delete_deletable_window): Re-add.
2077 (Fset_window_configuration): Rewrite to handle dead buffers and
2078 consequently deletable windows.
2079 (window_tree, Fwindow_tree): Remove. Supply functionality in
2080 window.el.
2081 (compare_window_configurations): Simplify code.
2082
b6e3633c
AS
20832011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2084
1ab0dee5
AS
2085 * image.c (imagemagick_load_image): Fix type mismatch.
2086 (Fimagemagick_types): Likewise.
2087
b6e3633c
AS
2088 * window.h (replace_buffer_in_windows): Declare.
2089
9397e56f
MR
20902011-06-11 Martin Rudalics <rudalics@gmx.at>
2091
2092 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2093 Qclone_number. Remove external declaration of Qdelete_window.
2094 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2095 code.
2096 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2097 Qbuffer_list_update_hook if allowed.
2098 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2099 buffer list implementation.
2100 (other_buffer_safely): New function.
2101 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2102 calls to replace_buffer_in_windows and
2103 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2104 if allowed.
2105 (record_buffer): Inhibit quitting and rewrite using quittable
2106 functions. Run Qbuffer_list_update_hook if allowed.
2107 (Frecord_buffer, Funrecord_buffer): New functions.
2108 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2109 switch-to-buffer to window.el.
2110 (bury-buffer): Move to window.el.
2111 (Vbuffer_list_update_hook): New variable.
2112
2113 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2114 section.
2115
2116 * window.h (resize_frame_windows): Move up in code.
2117 (Fwindow_frame): Remove EXFUN.
2118 (replace_buffer_in_all_windows): Remove prototype.
2119 (replace_buffer_in_windows_safely): Add prototype.
2120
2121 * window.c: Declare Qdelete_window static again. Move down
2122 declaration of select_count.
2123 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2124 (Fother_window): Move to window.el.
2125 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2126 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2127 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2128 window.el.
2129 (replace_buffer_in_windows): Implement by calling
2130 Qreplace_buffer_in_windows.
2131 (replace_buffer_in_all_windows): Remove with some functionality
2132 moved into replace_buffer_in_windows_safely.
2133 (replace_buffer_in_windows_safely): New function.
2134 (select_window_norecord, select_frame_norecord): Move in front
2135 of run_window_configuration_change_hook. Remove now obsolete
2136 declarations.
2137 (Fset_window_buffer): Rewrite doc-string. Call
2138 Qrecord_window_buffer.
2139 (keys_of_window): Move binding for other-window to window.el.
2140
b50691aa
CY
21412011-06-11 Chong Yidong <cyd@stupidchicken.com>
2142
2143 * dispextern.h (struct image): Replace data member, whose int_val
2144 and ptr_val fields were not used by anything, with a single
2145 lisp_val object.
2146
2147 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2148 (gif_clear_image, gif_load, imagemagick_load_image)
2149 (gs_clear_image, gs_load): Callers changed.
2150
3f754b86
PE
21512011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2152
cca69397
PE
2153 * buffer.h: Include <time.h>, for time_t.
2154 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2155
109e28d0
PE
2156 Fix minor problems found by static checking.
2157
60737f02
PE
2158 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2159
4b66faf3
PE
2160 Make identifiers static if they are not used in other modules.
2161 * data.c (Qcompiled_function, Qframe, Qvector):
2162 * image.c (QimageMagick, Qsvg):
2163 * minibuf.c (Qmetadata):
2164 * window.c (resize_window_check, resize_root_window): Now static.
2165 * window.h (resize_window_check, resize_root_window): Remove decls.
2166
109e28d0
PE
2167 * window.c (window_deletion_count, delete_deletable_window):
2168 Remove; unused.
46a4ce9e
PE
2169 (window_body_lines): Now static.
2170 (Fdelete_other_windows_internal): Mark vars as initialized.
2171 Make sure 'resize_failed' is initialized.
2172 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2173 (resize_window_apply): Remove unused local.
2174 * window.h (delete_deletable_window): Remove decl.
2175
109e28d0 2176 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2177 (imagemagick_load_image): Fix pointer signedness problem by changing
2178 last arg from unsigned char * to char *. All uses changed.
2179 Also, fix a local for similar reasons.
2180 Remove unused locals. Remove locals to avoid shadowing.
2181 (fn_rsvg_handle_free): Remove; unused.
2182 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2183 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2184
3f754b86
PE
2185 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2186
2547adb1
CY
21872011-06-10 Chong Yidong <cyd@stupidchicken.com>
2188
2189 * image.c (gif_load): Fix omitted cast error introduced by
2190 2011-06-06 change.
2191
2c8e37d4
MR
21922011-06-10 Martin Rudalics <rudalics@gmx.at>
2193
2194 * window.h (resize_proportionally, orig_total_lines)
2195 (orig_top_line): Remove from window structure.
2196 (set_window_height, set_window_width, change_window_heights)
2197 (Fdelete_window): Remove prototypes.
2198 (resize_frame_windows): Remove duplicate declaration.
2199
440a42e3
EZ
22002011-06-10 Eli Zaretskii <eliz@gnu.org>
2201
2202 * window.h (resize_frame_windows, resize_window_check)
2203 (delete_deletable_window, resize_root_window)
2204 (resize_frame_windows): Declare prototypes.
2205
2206 * window.c (resize_window_apply): Make definition be "static" to
2207 match the prototype.
2208
562dd5e9
MR
22092011-06-10 Martin Rudalics <rudalics@gmx.at>
2210
2211 * window.c: Remove declarations of Qwindow_size_fixed,
2212 window_min_size_1, window_min_size_2, window_min_size,
2213 size_window, window_fixed_size_p, enlarge_window, delete_window.
2214 Remove static from declaration of Qdelete_window, it's
2215 temporarily needed by Fbury_buffer.
2216 (replace_window): Don't assign orig_top_line and
2217 orig_total_lines.
2218 (Fdelete_window, delete_window): Remove. Window deletion is
2219 handled by window.el.
2220 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2221 Fdelete_window calls with calls to Qdelete_window.
2222 (Fdelete_other_windows): Remove. Deleting other windows is
2223 handled by window.el.
2224 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2225 handled in window.el.
2226 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2227 Window minimum sizes are handled in window.el.
2228 (shrink_windows, size_window, set_window_height)
2229 (set_window_width, change_window_heights, window_height)
2230 (window_width, CURBEG, CURSIZE, enlarge_window)
2231 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2232 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2233 handled in window.el.
2234 (make_dummy_parent): Rename to make_parent_window and give it a
2235 second argument horflag.
2236 (make_window): Don't set resize_proportionally any more.
2237 (Fsplit_window): Remove. Windows are split in window.el.
2238 (save_restore_action, save_restore_orig_size)
2239 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2240 Resize mini windows in window.el.
2241 (grow_mini_window, shrink_mini_window): Implement by calling
2242 Qresize_root_window_vertically, resize_window_check and
2243 resize_window_apply.
2244 (saved_window, Fset_window_configuration, save_window_save): Do
2245 not handle orig_top_line, orig_total_lines, and
2246 resize_proportionally.
2247 (window_min_height, window_min_width): Move to window.el.
2248 (keys_of_window): Move bindings for delete-other-windows,
2249 split-window, delete-window and enlarge-window to window.el.
2250
2251 * buffer.c: Temporarily extern Qdelete_window.
2252 (Fbury_buffer): Temporarily call Qdelete_window instead of
2253 Fdelete_window (Fbury_buffer will move to window.el soon).
2254
2255 * frame.c (set_menu_bar_lines_1): Remove code handling
2256 orig_top_line and orig_total_lines.
2257
2258 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2259 set_window_height but set heights directly.
2260 (change_frame_size_1): Use resize_frame_windows.
2261
2262 * xdisp.c (init_xdisp): Don't use set_window_height but set
2263 heights directly.
2264
2265 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2266 resize_frame_windows instead of change_window_heights and run
2267 run_window_configuration_change_hook.
2268
2269 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2270 instead of change_window_heights and run
2271 run_window_configuration_change_hook.
2272
1a13852e
MR
22732011-06-09 Martin Rudalics <rudalics@gmx.at>
2274
2275 * window.c (replace_window): Rename second argument REPLACEMENT to
2276 NEW. New third argument SETFLAG. Rewrite.
2277 (delete_window, make_dummy_parent): Call replace_window with
2278 third argument 1.
2279 (window_list_1): Move down in code.
2280 (run_window_configuration_change_hook): Move set_buffer part
2281 before select_frame_norecord part in order to unwind correctly.
2282 Rename count1 to count.
2283 (recombine_windows, delete_deletable_window, resize_root_window)
2284 (Fdelete_other_windows_internal)
2285 (Frun_window_configuration_change_hook, make_parent_window)
2286 (resize_window_check, resize_window_apply, Fresize_window_apply)
2287 (resize_frame_windows, Fsplit_window_internal)
2288 (Fdelete_window_internal, Fresize_mini_window_internal): New
2289 functions.
2290 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2291
f3d1777e
MR
22922011-06-08 Martin Rudalics <rudalics@gmx.at>
2293
496e208e
MR
2294 * window.h (window): Add some new members to window structure -
2295 normal_lines, normal_cols, new_total, new_normal, clone_number,
2296 splits, nest, prev_buffers, next_buffers.
2297 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2298 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2299
f3d1777e
MR
2300 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2301 Remove.
496e208e
MR
2302 (make_dummy_parent): Set new members of windows structure.
2303 (make_window): Move down in code. Handle new members of window
2304 structure.
2305 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2306 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2307 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2308 (Fset_window_prev_buffers, Fwindow_next_buffers)
2309 (Fset_window_next_buffers, Fset_window_clone_number): New
2310 functions.
2311 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2312 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2313 Doc-string fixes.
2314 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2315 Argument WINDOW can be now internal window too.
2316 (Fwindow_use_time): Move up in code.
2317 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2318 Rewrite doc-string.
2319 (Fset_window_configuration, saved_window)
2320 (Fcurrent_window_configuration, save_window_save): Handle new
2321 members of window structure.
b9e809c2
MR
2322 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2323 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2324 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2325 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2326 Qget_mru_window, Qresize_root_window,
2327 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2328 Qauto_buffer_name; staticpro them.
f3d1777e 2329
abde8f8c
MR
23302011-06-07 Martin Rudalics <rudalics@gmx.at>
2331
2332 * window.c (Fwindow_total_size, Fwindow_left_column)
2333 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2334 (Fwindow_list_1): New functions.
2335 (window_box_text_cols): Replace with window_body_cols.
2336 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2337 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2338 (delete_window, Fset_window_configuration): Call
2339 delete_all_subwindows with window as argument.
2340 (delete_all_subwindows): Take a window as argument and not a
2341 structure. Rewrite.
190b47e6
MR
2342 (window_loop): Remove handling of GET_LRU_WINDOW and
2343 GET_LARGEST_WINDOW.
2344 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2345
2346 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2347 window_box_text_cols. delete_all_subwindows now takes a
2348 Lisp_Object as argument.
abde8f8c
MR
2349
2350 * indent.c (compute_motion, Fcompute_motion): Use
2351 window_body_cols instead of window_box_text_cols.
2352
fa8a67e6
MR
2353 * frame.c (delete_frame): Call delete_all_subwindows with root
2354 window as argument.
2355
a54e3482
DC
23562011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2357
2358 * fns.c (Fputhash): Document return value.
2359
60002bf5
CY
23602011-06-06 Chong Yidong <cyd@stupidchicken.com>
2361
2362 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2363
0c671da6 23642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2365
b862a52a 2366 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2367
be44ca6c
PE
2368 Check for overflow when converting integer to cons and back.
2369 * charset.c (Fdefine_charset_internal, Fdecode_char):
2370 Use cons_to_unsigned to catch overflow.
2371 (Fencode_char): Use INTEGER_TO_CONS.
2372 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2373 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2374 * data.c (long_to_cons, cons_to_long): Remove.
2375 (cons_to_unsigned, cons_to_signed): New functions.
2376 These signal an error for invalid or out-of-range values.
2377 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2378 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2379 * font.c (Ffont_variation_glyphs):
2380 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2381 * lisp.h: Include <intprops.h>.
2382 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2383 (cons_to_signed, cons_to_unsigned): New decls.
2384 (long_to_cons, cons_to_long): Remove decls.
2385 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2386 (Fprimitive_undo): Use CONS_TO_INTEGER.
2387 * xfns.c (Fx_window_property): Likewise.
2388 * xselect.c: Include <limits.h>.
2389 (x_own_selection, selection_data_to_lisp_data):
2390 Use INTEGER_TO_CONS.
2391 (x_handle_selection_request, x_handle_selection_clear)
2392 (x_get_foreign_selection, Fx_disown_selection_internal)
2393 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2394 (lisp_data_to_selection_data): Use cons_to_unsigned.
2395 (x_fill_property_data): Use cons_to_signed.
2396 Report values out of range.
2397
d1f3d2af
PE
2398 Check for buffer and string overflow more precisely.
2399 * buffer.h (BUF_BYTES_MAX): New macro.
2400 * lisp.h (STRING_BYTES_MAX): New macro.
2401 * alloc.c (Fmake_string):
2402 * character.c (string_escape_byte8):
2403 * coding.c (coding_alloc_by_realloc):
2404 * doprnt.c (doprnt):
2405 * editfns.c (Fformat):
2406 * eval.c (verror):
2407 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2408 since they may not be the same number.
2409 * editfns.c (Finsert_char):
2410 * fileio.c (Finsert_file_contents):
2411 Likewise for BUF_BYTES_MAX.
2412
dd52fcea
PE
2413 * image.c: Use ptrdiff_t, not int, for sizes.
2414 (slurp_file): Switch from int to ptrdiff_t.
2415 All uses changed.
2416 (slurp_file): Check that file size fits in both size_t (for
2417 malloc) and ptrdiff_t (for sanity and safety).
2418
7f9bbdbb
PE
2419 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2420 if b->modtime has its maximal value.
2421
dfe18f82
PE
2422 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2423
84acfcf0
PE
2424 Don't assume time_t can fit into int.
2425 * buffer.h (struct buffer.modtime): Now time_t, not int.
2426 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2427 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2428
ccd9a01a
PE
2429 Minor fixes for signed vs unsigned integers.
2430 * character.h (MAYBE_UNIFY_CHAR):
2431 * charset.c (maybe_unify_char):
2432 * keyboard.c (read_char, reorder_modifiers):
2433 XINT -> XFASTINT, since the integer must be nonnegative.
2434 * ftfont.c (ftfont_spec_pattern):
2435 * keymap.c (access_keymap, silly_event_symbol_error):
2436 XUINT -> XFASTINT, since the integer must be nonnegative.
2437 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2438 since it makes no difference and we prefer signed.
2439 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2440 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2441 nonnegative.
2442
d6d100dd
SM
24432011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2444
2445 * window.h (Fwindow_frame): Declare.
2446
2b6148e4
PE
24472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2450 (SPARE_MEMORY): Always define.
2451 (LARGE_REQUEST): Remove.
2452 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2453
f230ecc9
MR
24542011-06-06 Martin Rudalics <rudalics@gmx.at>
2455
727e958e
MR
2456 * lisp.h: Move EXFUNS for Fframe_root_window,
2457 Fframe_first_window and Fset_frame_selected_window to window.h.
2458
2459 * window.h: Move EXFUNS for Fframe_root_window,
2460 Fframe_first_window and Fset_frame_selected_window here from
2461 lisp.h.
2462
2463 * frame.c (Fwindow_frame, Fframe_first_window)
2464 (Fframe_root_window, Fframe_selected_window)
2465 (Fset_frame_selected_window): Move to window.c.
2466 (Factive_minibuffer_window): Move to minibuf.c.
2467 (Fother_visible_frames_p): New function.
2468
2469 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2470
f230ecc9
MR
2471 * window.c (decode_window, decode_any_window): Move up in code.
2472 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2473 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2474 (Fwindow_buffer): Move up and rewrite doc-string.
2475 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2476 (Fwindow_prev): New functions.
727e958e
MR
2477 (Fwindow_frame): Move here from frame.c. Accept any window as
2478 argument.
2479 (Fframe_root_window, Fframe_first_window)
2480 (Fframe_selected_window): Move here from frame.c. Accept frame
2481 or arbitrary window as argument. Update doc-strings.
2482 (Fminibuffer_window): Move up in code.
2483 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2484 (Fset_frame_selected_window): Move here from frame.c.
2485 Marginal rewrite.
727e958e
MR
2486 (Fselected_window, select_window, Fselect_window): Move up in
2487 code. Minor doc-string fixes.
f230ecc9 2488
4d09bcf6
PE
24892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2490
2491 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2492 Do not assume that spare memory exists; that assumption is valid
2493 only if SYSTEM_MALLOC.
2494 (LARGE_REQUEST): New macro, so that the issue of large requests
2495 is separated from the issue of spare memory.
2496
810928a2
AS
24972011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2498
172418ad
AS
2499 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2500 format. (Bug#8806)
2501
43f862f7
AS
2502 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2503
810928a2
AS
2504 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2505 before statements.
2506
a059fe24
JD
25072011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2508
2509 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2510
2511 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2512
2513 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2514 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2515
989bf368
JB
25162011-06-05 Juanma Barranquero <lekktu@gmail.com>
2517
2518 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2519
4b80f674
CY
25202011-06-04 Chong Yidong <cyd@stupidchicken.com>
2521
2522 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2523 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2524 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2525 New error handlers.
4b80f674
CY
2526 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2527 Obey Vx_select_enable_clipboard_manager. Catch errors in
2528 x_clipboard_manager_save (Bug#8779).
2529 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2530 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2531
99a33b77 25322011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2533
2534 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2535
99a33b77 25362011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2537
2538 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2539 in the current matrix if keep_current_p is non-zero.
2540
8264569d
EZ
25412011-06-04 Eli Zaretskii <eliz@gnu.org>
2542
2543 * bidi.c (bidi_level_of_next_char): Fix last change.
2544
57f97249
EZ
25452011-06-03 Eli Zaretskii <eliz@gnu.org>
2546
fec2107c 2547 Support bidi reordering of text covered by display properties.
57f97249 2548
fec2107c
EZ
2549 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2550 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2551 (bidi_cache_search, bidi_cache_iterator_state)
2552 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2553 (bidi_level_of_next_char, bidi_move_to_visually_next):
2554 Support character positions inside a run of characters covered by a
fec2107c
EZ
2555 display string.
2556 (bidi_paragraph_init, bidi_resolve_explicit_1)
2557 (bidi_level_of_next_char): Call bidi_fetch_char and
2558 bidi_fetch_char_advance instead of FETCH_CHAR and
2559 FETCH_CHAR_ADVANCE.
2560 (bidi_init_it): Initialize new members.
2561 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2562 definitions.
2563 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2564 instead of using explicit *_CHAR codes.
d6d100dd
SM
2565 (bidi_resolve_explicit, bidi_resolve_weak):
2566 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2567 bidirectional text is supported only in multibyte buffers.
2568 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2569 it to initialize the frame_window_p member of struct bidi_it.
2570 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2571 (bidi_resolve_explicit, bidi_resolve_weak)
2572 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2573 bidi_it->nchars is non-positive.
2574 (bidi_level_of_next_char): Don't try to lookup the cache for the
2575 next/previous character if nothing is cached there yet, or if we
2576 were just reseat()'ed to a new position.
c40e2fb2 2577
0e14fe90
EZ
2578 * xdisp.c (set_cursor_from_row): Set start and stop points
2579 according to the row's direction when priming the loop that looks
2580 for the glyph on which to display cursor.
2581 (single_display_spec_intangible_p): Function deleted.
2582 (display_prop_intangible_p): Reimplement to call
2583 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2584 Accept 3 additional arguments needed by handle_display_spec.
2585 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2586 values: lists, `(when COND...)' forms, etc.
2587 (single_display_spec_string_p): Support property values that are
2588 lists with the argument STRING its top-level element.
2589 (display_prop_string_p): Fix the condition for processing a
2590 property that is a list to be consistent with handle_display_spec.
fec2107c 2591 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2592 last portion of handle_display_prop.
2593 (compute_display_string_pos): Accept additional argument
2594 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2595 value of a `display' property is a "replacing spec".
2596 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2597 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2598 the display property, but just return a value indicating whether
2599 the display property will replace the characters it covers.
2600 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2601 frame_window_p members of struct bidi_it.
d6d100dd
SM
2602 (compute_display_string_pos, compute_display_string_end):
2603 New functions.
fec2107c
EZ
2604 (push_it): Accept second argument POSITION, where pop_it should
2605 jump to continue iteration.
2606 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2607
fec2107c
EZ
2608 * keyboard.c (adjust_point_for_property): Adjust the call to
2609 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2610
2611 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2612 (bidi_init_it): Update prototypes.
2613 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2614 (compute_display_string_pos, compute_display_string_end):
2615 Declare prototypes.
fec2107c
EZ
2616 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2617 EMACS_INT.
fc6f18ce 2618
40087514 26192011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2620
57f53182
PE
2621 Malloc failure behavior now depends on size of allocation.
2622 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2623 * lisp.h: Change signatures accordingly.
2624 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2625 All callers changed. (Bug#8762)
2626
2627 * gnutls.c: Use Emacs's memory allocators.
2628 Without this change, the gnutls library would invoke malloc etc.
2629 directly, which causes problems on non-SYNC_INPUT hosts, and which
2630 runs afoul of improving memory_full behavior. (Bug#8761)
2631 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2632 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2633 xfree instead of the default malloc, realloc, free.
2634 (Fgnutls_boot): No need to check for memory allocation failure,
2635 since xmalloc does that for us.
2636
ac32cd99 2637 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2638 * category.c (hash_get_category_set):
2639 * ccl.c (ccl_driver):
2640 * charset.c (Fdefine_charset_internal):
2641 * charset.h (struct charset.hash_index):
2642 * composite.c (get_composition_id, gstring_lookup_cache)
2643 (composition_gstring_put_cache):
2644 * composite.h (struct composition.hash_index):
2645 * dispextern.h (struct image.hash):
2646 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2647 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2648 (hashfn_equal, hashfn_user_defined, make_hash_table)
2649 (maybe_resize_hash_table, hash_lookup, hash_put)
2650 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2651 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2652 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2653 * image.c (make_image, search_image_cache, lookup_image)
2654 (xpm_put_color_table_h):
2655 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2656 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2657 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2658 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2659 * alloc.c (allocate_vectorlike):
2660 Check for overflow in vector size calculations.
2661 * ccl.c (ccl_driver):
2662 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2663 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2664 need to be updated by these changes.
40087514
PE
2665 * fns.c (make_hash_table, maybe_resize_hash_table):
2666 Check for integer overflow with large hash tables.
0de4bb68
PE
2667 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2668 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2669 (SXHASH_REDUCE): New macro.
2670 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2671 Use it instead of discarding useful hash info with large hash values.
2672 (sxhash_float): New function.
2673 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2674 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2675 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2676 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2677 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2678 Adjust signatures to match updated version of code.
2679 (consing_since_gc): Now EMACS_INT, since a single hash table can
2680 use more than INT_MAX bytes.
2681
698d32e2
DN
26822011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2683
2684 Make it possible to build with GCC-4.6+ -O2 -flto.
2685
2686 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2687
fd6fa53f
SM
26882011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2689
2690 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2691 Call minibuffer-inactive-mode.
2692
864db017
JB
26932011-05-31 Juanma Barranquero <lekktu@gmail.com>
2694
2695 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2696 Update dependencies.
2697
2ad0baf4
DN
26982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2699
2700 * data.c (init_data): Remove code for UTS, this system is not
2701 supported anymore.
2702
4fcc2638
DN
27032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2704
2705 Don't force ./temacs to start in terminal mode.
2706
2707 * frame.c (make_initial_frame): Initialize faces in all cases, not
2708 only when CANNOT_DUMP is defined.
2709 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2710
c56e0fd5
DN
27112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2712
2713 * dispnew.c (add_window_display_history): Use const for the string
2714 pointer. Remove declaration, not needed.
2715
333d54da 27162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2717
55d4c1b2 2718 Use 'inline', not 'INLINE'.
333d54da 2719 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2720 * alloc.c, fontset.c (INLINE): Remove.
2721 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2722 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2723 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2724 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2725 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2726
738db178
DN
27272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2728
2729 Make it possible to run ./temacs.
2730
2731 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2732 syms_of_callproc does the same thing. Remove test for
2733 "initialized", do it in the caller.
2734 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2735
620c53a6
SM
27362011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2737
2738 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2739 (read_minibuf): Use get_minibuffer.
2740 (syms_of_minibuf): Use DEFSYM.
2741 (Qmetadata): New var.
2742 * data.c (Qbuffer): Don't make it static.
2743 (syms_of_data): Use DEFSYM.
2744
e003a292
PE
27452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2748 (CCL_CODE_MIN): New macro.
2749
ed008a6d
PE
27502011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2751
3687c2ef
PE
2752 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2753
ed008a6d
PE
2754 * eval.c (Qdebug): Now static.
2755 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2756 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2757 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2758
d66c4c7c
CY
27592011-05-29 Chong Yidong <cyd@stupidchicken.com>
2760
2761 * image.c: Various fixes to ImageMagick code comments.
2762 (Fimagemagick_types): Doc fix.
2763
5fbc2025
PE
27642011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2765
0196f88a
PE
2766 Minor fixes prompted by GCC 4.6.0 warnings.
2767
2768 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2769
5fbc2025
PE
2770 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2771 (x_clipboard_manager_save_all): Move extern decl to ...
2772 * xterm.h: ... here, so that it can be checked for consistency.
2773
1dd3c2d9
CY
27742011-05-29 Chong Yidong <cyd@stupidchicken.com>
2775
2776 * xselect.c (x_clipboard_manager_save_frame)
2777 (x_clipboard_manager_save_all): New functions.
2778 (Fx_clipboard_manager_save): Lisp function deleted.
2779
2780 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2781 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2782
2783 * xterm.h: Update prototype.
2784
5ba6571d
WX
27852011-05-28 William Xu <william.xwl@gmail.com>
2786
2787 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2788 exiting (Bug#8239).
2789
3eaff834
JM
27902011-05-28 Jim Meyering <meyering@redhat.com>
2791
e1900994 2792 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2793 * fns.c (to_uchar): Define.
2794 (crypto_hash_function): Use it to convert some newly-signed
2795 variables to unsigned, to avoid sign-extension bugs. For example,
2796 without this change, (md5 "truc") would evaluate to
2797 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2798 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2799 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2800
0f6990a7
PE
28012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 Integer overflow fixes.
c8a9ca5a 2804
08686060
PE
2805 * dbusbind.c: Serial number integer overflow fixes.
2806 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2807 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2808 to hold a serial number that is too large for a fixnum.
2809 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2810 Check for serial numbers out of range. Decode any serial number
59568bf0 2811 that was so large that it became a float. (Bug#8722)
08686060 2812
2d1fc3c7
PE
2813 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2814 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2815 Use XFASTINT rather than XUINT when numbers are nonnegative.
2816 (xd_append_arg, Fdbus_method_return_internal):
2817 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2818 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2819 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2820 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2821 (Bug#8722)
2d1fc3c7 2822
c8a9ca5a
PE
2823 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2824
519e1d69
PE
2825 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2826
30569699
PE
2827 ccl: add integer overflow checks
2828 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2829 (IN_INT_RANGE): New macros.
2830 (ccl_driver): Use them to check for integer overflow when
2831 decoding a CCL program. Many of the new checks are whether XINT (x)
2832 fits in int; it doesn't always, on 64-bit hosts. The new version
2833 doesn't catch all possible integer overflows, but it's an
847044ea 2834 improvement. (Bug#8719)
30569699 2835
c11285dc
PE
2836 * alloc.c (make_event_array): Use XINT, not XUINT.
2837 There's no need for unsigned here.
2838
fdccd48e
PE
2839 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2840 This follows up to the 2011-05-06 change that substituted uintptr_t
2841 for EMACS_INT. This case wasn't caught back then.
2842
37910ab2
PE
2843 Rework Fformat to avoid integer overflow issues.
2844 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2845 now (part of C89). Include <verify.h>.
2846 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2847 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2848 (Fformat): Avoid the prepass trying to compute sizes; it was only
2849 approximate and thus did not catch overflow reliably. Instead, walk
2850 through the format just once, formatting and computing sizes as we go,
2851 checking for integer overflow at every step, and allocating a larger
2852 buffer as needed. Keep track separately whether the format is
2853 multibyte. Keep only the most-recently calculated precision, rather
2854 than them all. Record whether each argument has been converted to
2855 string. Use EMACS_INT, not int, for byte and char and arg counts.
2856 Support field widths and precisions larger than INT_MAX. Avoid
2857 sprintf's undefined behavior with conversion specifications such as %#d
2858 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2859 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2860 formatting out-of-range floating point numbers with int
9173deec 2861 formats. (Bug#8668)
37910ab2 2862
2e6578fb
PE
2863 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2864
0ae6bdee
PE
2865 * data.c: Avoid integer truncation in expressions involving floats.
2866 * data.c: Include <intprops.h>.
2867 (arith_driver): When there's an integer overflow in an expression
2868 involving floating point, convert the integers to floating point
2869 so that the resulting value does not suffer from catastrophic
2870 integer truncation. For example, on a 64-bit host (* 4
2871 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2872 Do not rely on undefined behavior after integer overflow.
2873
de883a70
PE
2874 merge count_size_as_multibyte, parse_str_to_multibyte
2875 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2876 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2877 Check for integer overflow.
2878 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2879 since it's now a duplicate of the other. This is more of
2880 a character than a buffer op, so better that it's in character.c.
2881 * fns.c, print.c: Adjust to above changes.
2882
2ff916cb
PE
28832011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2884
2885 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2886
f1b54466
PE
28872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2888
fb1ac845
PE
2889 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2890 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2891 (x_clipboard_manager_save): Now static.
2892 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2893
f1b54466
PE
2894 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2895 (crypto_hash_function): Now static.
2896 Fix pointer signedness problems. Avoid unnecessary initializations.
2897
a9f737ee
CY
28982011-05-27 Chong Yidong <cyd@stupidchicken.com>
2899
2900 * termhooks.h (Vselection_alist): Make it terminal-local.
2901
2902 * terminal.c (create_terminal): Initialize it.
2903
2904 * xselect.c: Support for clipboard managers.
2905 (Vselection_alist): Move to termhooks.h as terminal-local var.
2906 (LOCAL_SELECTION): New macro.
2907 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2908 (symbol_to_x_atom): Remove gratuitous arg.
2909 (x_handle_selection_request, lisp_data_to_selection_data)
2910 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2911 (x_own_selection, x_get_local_selection, x_convert_selection):
2912 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2913 (some_frame_on_display): Delete unused function.
2914 (Fx_own_selection_internal, Fx_get_selection_internal)
2915 (Fx_disown_selection_internal, Fx_selection_owner_p)
2916 (Fx_selection_exists_p): New optional frame arg.
2917 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2918 (x_handle_selection_clear): Don't treat other terminals with the
2919 same keyboard specially. Use the terminal-local Vselection_alist.
2920 (x_clear_frame_selections): Use Frun_hook_with_args.
2921
2922 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2923
2924 * xterm.h: Add support for those atoms.
2925
e067f0c1
CY
29262011-05-26 Chong Yidong <cyd@stupidchicken.com>
2927
2928 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2929 (converted_selections, conversion_fail_tag): New global variables.
2930 (x_selection_request_lisp_error): Free the above.
2931 (x_get_local_selection): Remove unnecessary code.
2932 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2933 of converted selections stored in converted_selections.
2934 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2935 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2936 (x_convert_selection): New function.
2937 (x_handle_selection_event): Simplify.
2938 (x_get_foreign_selection): Don't ignore incoming requests while
2939 waiting for an answer; this will fail when we implement
2940 SAVE_TARGETS, and seems unnecessary anyway.
2941 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2942 (Vx_sent_selection_functions): Doc fix.
2943
0f4aebc0
LL
29442011-05-26 Leo Liu <sdl.web@gmail.com>
2945
2946 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2947
e61124cd
YM
29482011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2949
2950 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2951
2952 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2953 for fringe update if it has periodic bitmap.
ac389d0c 2954 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2955 and fringe_bitmap_periodic_p.
2956
2957 * fringe.c (get_fringe_bitmap_data): New function.
2958 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2959 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2960 row. Mark glyph row for fringe update if periodicity changed.
2961
2962 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2963 for fringe update unless it has periodic bitmap.
2964
f16d9837
KH
29652011-05-25 Kenichi Handa <handa@m17n.org>
2966
2967 * xdisp.c (get_next_display_element): Set correct it->face_id for
2968 a static composition.
2969
e1b90ef6
LL
29702011-05-24 Leo Liu <sdl.web@gmail.com>
2971
2972 * deps.mk (fns.o):
2973 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2974
2975 * fns.c (crypto_hash_function, Fsha1): New function.
2976 (Fmd5): Use crypto_hash_function.
2977 (syms_of_fns): Add Ssha1.
2978
7400048f
PE
29792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 * gnutls.c: Remove unused macros.
2982 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2983 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2984 Remove macros that are defined and never used.
2985 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2986
abb71cf4
CY
29872011-05-22 Chong Yidong <cyd@stupidchicken.com>
2988
2989 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2990 (Fx_get_selection_internal): Minor cleanup.
2991 (Fx_own_selection_internal): Rename arguments for consistency with
2992 select.el.
2993
6307db39
PE
29942011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2995
2996 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2997
f3d4e0a4
CY
29982011-05-22 Chong Yidong <cyd@stupidchicken.com>
2999
3000 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3001
4d8ade89
YM
30022011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3003
3004 * dispnew.c (scrolling_window): Don't exclude the case that the
3005 last enabled row in the desired matrix touches the bottom boundary.
3006
32078c8d
GM
30072011-05-21 Glenn Morris <rgm@gnu.org>
3008
3009 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3010 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3011 and add some more files.
32078c8d 3012
7285dc67
EZ
30132011-05-20 Eli Zaretskii <eliz@gnu.org>
3014
3015 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3016 report_file_error introduced by the change from 2011-05-07.
3017
89d1bd22
PE
30182011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 * systime.h (Time): Define only if emacs is defined.
3021 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3022 where the include path doesn't have X11/X.h by default. See
3023 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3024
e23640bb 30252011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3026
3027 * composite.c (find_automatic_composition): Fix previous change.
3028
b9704ad9
GM
30292011-05-20 Glenn Morris <rgm@gnu.org>
3030
3031 * lisp.mk: New file, split from Makefile.in.
3032 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3033 (shortlisp): Remove.
3034 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3035
4a720484
GM
30362011-05-19 Glenn Morris <rgm@gnu.org>
3037
3038 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3039 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3040 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3041 (lisp): Set the order to that of loadup.el.
3042 (shortlisp): Make it a copy of $lisp.
3043 (SOME_MACHINE_LISP): Remove.
3044 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3045 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3046
a28d4396
KH
30472011-05-18 Kenichi Handa <handa@m17n.org>
3048
3049 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3050 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3051 (find_automatic_composition): Mostly rewrite for efficiency.
3052
a2b1fa8e
JB
30532011-05-18 Juanma Barranquero <lekktu@gmail.com>
3054
3055 * makefile.w32-in: Update dependencies.
3056
8e1f5610
CS
30572011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3058
3059 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3060 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3061
7025ee00 30622011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3063
cdfa6eab
PE
3064 Fix some integer overflow issues, such as string length overflow.
3065
06d6db33
PE
3066 * insdel.c (count_size_as_multibyte): Check for string overflow.
3067
2b4560a8
PE
3068 * character.c (lisp_string_width): Check for string overflow.
3069 Use EMACS_INT, not int, for string indexes and lengths; in
3070 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3071 the resulting string length overflows an EMACS_INT; instead,
3072 report a string overflow if no precision given. When checking for
3073 precision exhaustion, use a check that cannot possibly have
3074 integer overflow. (Bug#8675)
3075 * character.h (lisp_string_width): Adjust to new signature.
3076
cb93f9be
PE
3077 * alloc.c (string_overflow): New function.
3078 (Fmake_string): Use it. This doesn't change behavior, but saves
3079 a few bytes and will simplify future changes.
3080 * character.c (string_escape_byte8): Likewise.
3081 * lisp.h (string_overflow): New decl.
3082
1a1f3366
PE
3083 Fixups, following up to the user-interface timestamp change.
3084 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3085 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3086 * msdos.c (mouse_get_pos): Likewise.
3087 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3088 * w32gui.h (Time): Define by including "systime.h" rather than by
3089 declaring it ourselves. (Bug#8664)
3090
d4e3e4d3
PE
3091 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3092 * image.c (clear_image_cache): Likewise.
3093
f6a24d19
PE
3094 * term.c (term_mouse_position): Don't assume time_t wraparound.
3095
08dc5ae6
PE
3096 Be more systematic about user-interface timestamps.
3097 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3098 and sometimes 'EMACS_UINT', to represent these timestamps.
3099 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3100 This makes the code easier to follow, and makes it easier to catch
3101 integer overflow bugs such as Bug#8664.
3102 * frame.c (Fmouse_position, Fmouse_pixel_position):
3103 Use Time, not unsigned long, for user-interface timestamps.
3104 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3105 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3106 * keyboard.h (last_event_timestamp): Likewise.
3107 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3108 * menu.h (xmenu_show): Likewise.
3109 * term.c (term_mouse_position): Likewise.
3110 * termhooks.h (struct input_event.timestamp): Likewise.
3111 (struct terminal.mouse_position_hook): Likewise.
3112 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3113 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3114 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3115 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3116 what it was before.
3117 * menu.h, termhooks.h: Include "systime.h", for Time.
3118
8e55734a
PE
3119 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3120 Don't assume that the difference between two unsigned long values
3121 can fit into an integer. At this point, we know button_down_time
3122 <= event->timestamp, so the difference must be nonnegative, so
3123 there's no need to cast the result if double-click-time is
3124 nonnegative, as it should be; check that it's nonnegative, just in
3125 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3126 apart (about 25 days). (Bug#8664)
8e55734a 3127
841f1b75 3128 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3129 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3130
3e26f69c
PE
3131 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3132 that always fit in int. Use a sentinel instead of a counter, to
3133 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3134 * frame.h (struct frame): Use int for menu_bar_items_used
3135 instead of EMACS_INT, since it always fits in int.
3e26f69c 3136
5cc152c0
PE
3137 * menu.c (grow_menu_items): Check for int overflow.
3138
d89eb65e
PE
3139 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3140
5235bd3e
PE
3141 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3142 Before, the code was not consistent. These values cannot exceed
3143 2**31 - 1 so there's no need to make them unsigned.
3144 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3145 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3146 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3147 as modifiers.
3148 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3149
bc827e23
PE
3150 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3151 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3152 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3153 presumably because the widths might not match.
3154
78eb494e
PE
3155 * window.c (size_window): Avoid needless test at loop start.
3156
04f2d78b
CB
31572011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3158
3159 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3160
d2fc7e3d 31612011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3162
3163 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3164
d2fc7e3d 31652011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3166
3167 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3168 `width' to `bar_area_x' and `bar_area_width', respectively.
3169 (x_scroll_run): Take account of fringe background extension.
3170
04f2d78b
CB
3171 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3172 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3173 `bar_area_width', respectively.
3174 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3175 background extension.
3176
79b70037
GM
31772011-05-10 Jim Meyering <meyering@redhat.com>
3178
3179 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3180
2f142cc5
JB
31812011-05-10 Juanma Barranquero <lekktu@gmail.com>
3182
3183 * image.c (Finit_image_library): Return t for built-in image types,
3184 like pbm and xbm. (Bug#8640)
3185
57679c86
AS
31862011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3187
3188 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3189
888c9e86
EZ
31902011-05-07 Eli Zaretskii <eliz@gnu.org>
3191
b0512a1d
EZ
3192 * w32console.c (Fset_screen_color): Doc fix.
3193 (Fget_screen_color): New function.
3194 (syms_of_ntterm): Defsubr it.
3195
7285dc67
EZ
3196 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3197 unlink the temporary file if Fcall_process didn't create it in the
3198 first place.
3199 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3200 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3201 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3202 cue to call_process_cleanup not to close that handle.
3203
4d3fcc8e
BK
32042011-05-07 Ben Key <bkey76@gmail.com>
3205
3206 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3207 one of two shell specific rules, either bootstrap-temacs-CMD or
3208 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3209 to the previous implementation of the bootstrap-temacs rule.
3210 The bootstrap-temacs-CMD rule is similar to the previous
3211 implementation of the bootstrap-temacs rule except that it
3212 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3213 variable.
3214
3215 These changes, along with some changes to nt/configure.bat,
3216 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3217 earlier fix to add support for --cflags and --ldflags options
3218 that include quotes so that it works whether make uses cmd or
3219 sh as the shell.
3220
b4289b64
MA
32212011-05-06 Michael Albinus <michael.albinus@gmx.de>
3222
3223 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3224 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3225 is a constant.
3226 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3227 a string. Handle both cases.
3228 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3229 (Fdbus_register_method): Use Qinvalid_function.
3230
af4c0e28
JB
32312011-05-06 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * makefile.w32-in: Update dependencies.
3234 (LISP_H): Add inttypes.h and stdin.h.
3235 (PROCESS_H): Add unistd.h.
3236
c51453d9
EZ
32372011-05-06 Eli Zaretskii <eliz@gnu.org>
3238
3239 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3240 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3241
8ff0ac3c 32422011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3243
4c4b566b
PE
3244 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3245
aab2b9b5
PE
3246 * term.c (vfatal): Remove stray call to va_end.
3247 It's not needed and the C Standard doesn't allow it here anyway.
3248
c378da0b
PE
3249 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3250 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3251
288b08c7
PE
3252 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3253 bytes.
3254
e3601888
PE
3255 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3256
db6c0e74
PE
3257 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3258
dd5963ea
PE
3259 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3260
88c9450f
PE
3261 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3262
2f9442b8
PE
3263 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3264
c032b5f8
PE
3265 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3266 * charset.c (Fdefine_charset_internal): Don't initialize
3267 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3268 32-bit int (Bug#8600).
a108c10b
PE
3269
3270 * lread.c (read_integer): Be more consistent with string-to-number.
3271 Use string_to_number to do the actual conversion; this avoids
3272 rounding errors and fixes some other screwups. Without this fix,
3273 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3274 (digit_to_number): Move earlier, for benefit of read_integer.
3275 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3276 not a digit in any supported base. (Bug#8602)
a108c10b 3277
ad5f9eea
PE
3278 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3279
aec1708a
PE
3280 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3281 to match comment at start of function. This also removes a
3282 GCC warning about overflow in a 32+64-bit port.
3283
47be4ab5
PE
3284 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3285
371cac43
PE
3286 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3287 Reported by Stefan Monnier in
3288 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3289 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3290 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3291
d01a7826
PE
3292 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3293 (EMACS_UINTPTR): Likewise, with uintptr_t.
3294
7fd47d5c
PE
3295 * lisp.h: Prefer 64-bit EMACS_INT if available.
3296 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3297 on 32-bit hosts that have 64-bit int, so that they can access
3298 large files.
122b0c86
PE
3299 However, temporarily disable this change unless the temporary
3300 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3301
8727937b
PE
3302 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3303
8ac068ac
PE
3304 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3305 This removes an assumption that EMACS_INT and long are the same
3306 width as pointers. The assumption is true for Emacs porting targets
3307 now, but we want to make other targets possible.
3308 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3309 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3310 In the rest of the code, change types of integers that hold casted
3311 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3312 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3313 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3314 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3315 No need to cast type when ORing.
3316 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3317 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3318 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3319 assume EMACS_INT is the same width as char *.
3320 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3321 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3322 Remove no-longer-needed casts.
3323 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3324 (xg_tool_bar_help_callback, xg_make_tool_item):
3325 Use EMACS_INTPTR to hold an integer
3326 that will be cast to void *; this can avoid a GCC warning
3327 if EMACS_INT is not the same width as void *.
3328 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3329 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3330 (current_message_1, set_message_1):
3331 Use a local to convert to proper width without a cast.
3332 * xmenu.c (dialog_selection_callback): Likewise.
3333
ede49d71
PE
3334 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3335 Also, don't assume VALBITS / RAND_BITS is less than 5,
3336 and don't rely on undefined behavior when shifting a 1 left into
3337 the sign bit.
3338 * lisp.h (get_random): Change signature to match.
3339
2f30ecd0
PE
3340 * lread.c (hash_string): Use size_t, not int, for hash computation.
3341 Normally we prefer signed values; but hashing is special, because
3342 it's better to use unsigned division on hash table sizes so that
3343 the remainder is nonnegative. Also, size_t is the natural width
3344 for hashing into memory. The previous code used 'int', which doesn't
3345 retain enough info to hash well into very large tables.
3346 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3347
2a866e7b
PE
3348 * dbusbind.c: Don't possibly lose pointer info when converting.
3349 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3350 Use XPNTR rather than XHASH, so that the high-order bits of
3351 the pointer aren't lost when converting through void *.
3352
51639eac
PE
3353 * eval.c (Fautoload): Don't double-shift a pointer.
3354
92394119
PE
3355 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3356
dbdb9a7c
JB
33572011-05-06 Juanma Barranquero <lekktu@gmail.com>
3358
3359 * gnutls.c (DEF_GNUTLS_FN):
3360 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3361
db7a0b4f
AS
33622011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3363
3364 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3365 marker. (Bug#8610)
3366
f7ff1b0f 33672011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3368
3369 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3370 New version that can reserve upto 2GB of heap space.
3371
f7ff1b0f 33722011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3373
3374 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3375
639c109b
TZ
33762011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3377
3378 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3379 `gnutls_certificate_set_x509_key_file'.
3380
d2127135
JB
33812011-05-05 Juanma Barranquero <lekktu@gmail.com>
3382
3383 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3384 Update dependencies.
3385
e968f4f3
JB
33862011-05-04 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3389 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3390 Remove unused parameter `fildes'.
3391 * process.c (read_process_output, send_process): Don't pass it.
3392
84d358f0
JB
33932011-05-04 Juanma Barranquero <lekktu@gmail.com>
3394
3395 Fix previous change: the library cache is defined in w32.c.
3396 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3397 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3398
0898ca10
JB
33992011-05-04 Juanma Barranquero <lekktu@gmail.com>
3400
3401 Implement dynamic loading of GnuTLS on Windows.
3402
3403 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3404 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3405 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3406 Declare.
3407
3408 * gnutls.c (Qgnutls_dll): Define.
3409 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3410 (gnutls_*): Declare function pointers.
3411 (init_gnutls_functions): New function to initialize function pointers.
3412 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3413 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3414 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3415 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3416 (emacs_gnutls_write, emacs_gnutls_read)
3417 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3418 (Fgnutls_available_p): New function.
3419 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3420 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3421 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3422
3423 * image.c: Include w32.h.
3424 (Vimage_type_cache): Delete.
3425 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3426 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3427 (w32_delayed_load): Move to w32.c.
3428
3429 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3430
3431 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3432 (w32_delayed_load): Move from image.c. When loading a library, record
3433 its filename in the :loaded-from property of the library id.
3434 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3435 Initialize and staticpro them.
3436 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3437
3438 * process.c: Include lisp.h before w32.h, not after.
3439 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3440 instead of gnutls_record_check_pending.
3441
3442 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3443
ff4de4aa
TZ
34442011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3445
3446 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3447 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3448 as passed in.
3449
abe95abb
JD
34502011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3451
3452 * xterm.c (x_set_frame_alpha): Do not set property on anything
3453 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3454
e16e55d4
JB
34552011-05-02 Juanma Barranquero <lekktu@gmail.com>
3456
3457 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3458
bafcf6a5
JB
34592011-05-02 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3462 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3463 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3464 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3465 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3466 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3467 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3468 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3469 (Qgnutls_bootprop_callbacks_verify): Make static.
3470
e7a6747f
AS
34712011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3472
19ed11ba
AS
3473 * callproc.c: Indentation fixup.
3474
e7a6747f 3475 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3476 (wait_for_termination, interruptible_wait_for_termination):
3477 Move after wait_for_termination_1.
e7a6747f 3478
1ef14cb4
LMI
34792011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3480
3481 * sysdep.c (interruptible_wait_for_termination): New function
3482 which is like wait_for_termination, but allows keyboard
3483 interruptions.
3484
3485 * callproc.c (Fcall_process): Add (:file "file") as an option for
3486 the STDOUT buffer.
3487 (Fcall_process_region): Ditto.
3488
330d880c
EZ
34892011-04-30 Eli Zaretskii <eliz@gnu.org>
3490
8db90b73
EZ
3491 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3492 rather than `XVECTOR (FOO)->size'.
3493
330d880c
EZ
3494 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3495 inttypes.h, as a gnulib replacement is used if it not available in
3496 system headers.
3497
15cbd324
EZ
34982011-04-21 Eli Zaretskii <eliz@gnu.org>
3499
3500 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3501 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3502 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3503
3504 * coding.c (coding_alloc_by_realloc): Error out if destination
3505 will grow beyond MOST_POSITIVE_FIXNUM.
3506 (decode_coding_emacs_mule): Abort if there isn't enough place in
3507 charbuf for the composition carryover bytes. Reserve an extra
3508 space for up to 2 characters produced in a loop.
3509 (decode_coding_iso_2022): Abort if there isn't enough place in
3510 charbuf for the composition carryover bytes.
3511
35122011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3513
ae940cca
EZ
3514 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3515 aborting when %lld or %lll format is passed.
3516 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3517 %llo or %llx format is passed. (Bug#8545)
3518
03ab8921
EZ
3519 * window.c (window_scroll_line_based): Use a marker instead of
3520 simple variables to record original value of point. (Bug#7952)
3521
afda1437
EZ
3522 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3523 produced by %s or %c overflows available buffer space. (Bug#8545)
3524
f76dee0c
PE
35252011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3528 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3529
fdc5744d
JB
35302011-04-28 Juanma Barranquero <lekktu@gmail.com>
3531
3532 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3533
638f053a
JB
35342011-04-28 Juanma Barranquero <lekktu@gmail.com>
3535
3536 * keyboard.c (Qdelayed_warnings_hook): Define.
3537 (command_loop_1): Run `delayed-warnings-hook'
3538 if Vdelayed_warnings_list is non-nil.
3539 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3540 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3541
d178f871
EZ
35422011-04-28 Eli Zaretskii <eliz@gnu.org>
3543
3544 * doprnt.c (doprnt): Don't return value smaller than the buffer
3545 size if the message was truncated. (Bug#8545).
3546
b124fd93
JB
35472011-04-28 Juanma Barranquero <lekktu@gmail.com>
3548
3549 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3550 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3551
e810457d
PE
35522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3553
3554 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3555
ea51cceb
JB
35562011-04-27 Juanma Barranquero <lekktu@gmail.com>
3557
3558 * makefile.w32-in: Update dependencies.
3559
94dcfacf
EZ
35602011-04-27 Eli Zaretskii <eliz@gnu.org>
3561
3562 Improve `doprnt' and its usage. (Bug#8545)
3563 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3564 `format_end'. Remove support for %l as a conversion specifier.
3565 Don't use xrealloc. Improve diagnostics when the %l size modifier
3566 is used. Update the commentary.
3567
3568 * eval.c (verror): Simplify calculation of size_t.
3569
3570 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3571 messages.
3572
f61f41d7
PE
35732011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3574
3575 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3576 change.
3577
96fb4434
PE
35782011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3579
3580 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3581 This makes this file independent of the recent pseudovector change.
3582
671875da 35832011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3584
69e9b5a3
PE
3585 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3586
b5f869a7 3587 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3588 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3589 Remove unused local.
c8926152 3590 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3591
841a1577 3592 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3593 GCC 4.6.0 optimizes based on type-based alias analysis.
3594 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3595 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3596 != &v->size, and therefore "v->size = 1; b->size = 2; return
3597 v->size;" must therefore return 1. This assumption is incorrect
3598 for Emacs, since it type-puns struct Lisp_Vector * with many other
3599 types. To fix this problem, this patch adds a new type struct
f904488f 3600 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3601 and pseudovectors, and helps optimizing compilers not get fooled
3602 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3603 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3604 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3605 the size member.
eab3844f
PE
3606 (XSETPVECTYPE): Rewrite in terms of new macro.
3607 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3608 This is a bit clearer, and further avoids the possibility of
3609 undesirable aliasing.
3610 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3611 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3612 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3613 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3614 (ASIZE): Now uses header.size rather than size.
3615 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3616 to avoid the hassle of writing XVECTOR (foo)->header.size.
3617 (struct vectorlike_header): New type.
eab3844f
PE
3618 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3619 object, to help avoid aliasing.
3620 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3621 (SUBRP): Likewise, since Lisp_Subr is a special case.
3622 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3623 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3624 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3625 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3626 changed to be "header.size" and "header.next".
3627 * buffer.h (struct buffer): Likewise.
3628 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3629 * frame.h (struct frame): Likewise.
3630 * process.h (struct Lisp_Process): Likewise.
3631 * termhooks.h (struct terminal): Likewise.
3632 * window.c (struct save_window_data, struct saved_window): Likewise.
3633 * window.h (struct window): Likewise.
3634 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3635 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3636 * buffer.c (init_buffer_once): Likewise.
3637 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3638 special case.
3639 * process.c (Fformat_network_address): Use local var for size,
3640 for brevity.
3641
0df1eac5
PE
3642 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3643
847ab9d1 3644 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3645 * data.c (atof): Remove decl; no longer used or needed.
3646 (digit_to_number): Move to lread.c.
3647 (Fstring_to_number): Use new string_to_number function, to be
3648 consistent with how the Lisp reader treats infinities and NaNs.
3649 Do not assume that floating-point numbers represent EMACS_INT
3650 without losing information; this is not true on most 64-bit hosts.
3651 Avoid double-rounding errors, by insisting on integers when
3652 parsing non-base-10 numbers, as the documentation specifies.
3653 * lisp.h (string_to_number): New decl, replacing ...
3654 (isfloat_string): Remove.
bc0a5c13 3655 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3656 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3657 appears to have been a coding error. Similarly, do not accept
3658 strings like +-1e0 as floating point numbers. Do not report
3659 overflow for integer overflows unless the base is not 10 which
3660 means we have no simple and reliable way to continue.
3661 Break out the floating-point parsing into a new
3662 function string_to_number, so that Fstring_to_number parses
3663 floating point numbers consistently with the Lisp reader.
04f2d78b 3664 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3665 (E_CHAR, EXP_INT): Remove, replacing with ...
3666 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3667 (string_to_number): New function, replacing isfloat_string.
3668 This function checks for valid syntax and produces the resulting
3669 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3670 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3671 so that overflow for non-base-10 numbers is reported only when
3672 there's no portable and simple way to convert to floating point.
452f4150 3673
67769ffc
PE
3674 * textprop.c (set_text_properties_1): Rewrite for clarity,
3675 and to avoid GCC warning about integer overflow.
3676
c20db43f
PE
3677 * intervals.h (struct interval): Use EMACS_INT for members
3678 where EMACS_UINT might cause problems. See
3679 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3680 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3681 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3682 All uses changed.
37aa2f85
PE
3683 (offset_intervals): Tell GCC not to worry about length overflow
3684 when negating a negative length.
c20db43f 3685
2538aa2f
PE
3686 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3687 (overrun_check_free): Likewise.
3688
f2d3008d
PE
3689 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3690 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3691 word size.
3692
ec8df744
PE
3693 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3694 (gnutls_make_error): Rename local to avoid shadowing.
3695 (gnutls_emacs_global_deinit): ifdef out; not used.
3696 (Fgnutls_boot): Use const for pointer to readonly storage.
3697 Comment out unused local. Fix pointer signedness problems.
3698
640ee02d
PE
3699 * lread.c (openp): Don't stuff size_t into an 'int'.
3700 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3701 about possible signed overflow.
3702
6048fb2a
PE
3703 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3704 (GDK_KEY_g): Don't define if already defined.
3705 (xg_prepare_tooltip): Avoid pointer signedness problem.
3706 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3707
fa3c87e1
PE
3708 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3709 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3710
2172544b
PE
3711 * xfns.c (Fx_window_property): Simplify a bit,
3712 to make a bit faster and to avoid GCC 4.6.0 warning.
3713 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3714
9b821a21
PE
3715 * fns.c (internal_equal): Don't assume size_t fits in int.
3716
3c616cfa
PE
3717 * alloc.c (compact_small_strings): Tighten assertion a little.
3718
c2982e87
PE
3719 Replace pEd with more-general pI, and fix some printf arg casts.
3720 * lisp.h (pI): New macro, generalizing old pEd macro to other
3721 conversion specifiers. For example, use "...%"pI"d..." rather
3722 than "...%"pEd"...".
3723 (pEd): Remove. All uses replaced with similar uses of pI.
3724 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3725 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3726 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3727 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3728 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3729 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3730 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3731 64-bit hosts.
3732 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3733 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3734 * print.c (safe_debug_print, print_object): Likewise.
3735 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3736 to int.
6f04d126
PE
3737 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3738 avoiding the 0 flag, which is not portable.
c2982e87
PE
3739 * process.c (Fmake_network_process): Use pI to avoid cast.
3740 * region-cache.c (pp_cache): Likewise.
3741 * xdisp.c (decode_mode_spec): Likewise.
3742 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3743 behavior on 64-bit hosts with printf arg.
6f04d126 3744 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3745 (x_stop_queuing_selection_requests): Likewise.
3746 (x_get_window_property): Don't truncate byte count to an 'int'
3747 when tracing.
0b432f21 3748
5e073ec7
PE
3749 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3750 here, since it parses constructs like leading '-' and spaces,
3751 which are not wanted; and it overflows with large numbers.
3752 Instead, simply match F[0-9]+, which is what is wanted anyway.
3753
36372bf9
PE
3754 * alloc.c: Remove unportable assumptions about struct layout.
3755 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3756 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3757 (allocate_vectorlike, make_pure_vector): Use the new macros,
3758 plus offsetof, to remove unportable assumptions about struct layout.
3759 These assumptions hold on all porting targets that I know of, but
3760 they are not guaranteed, they're easy to remove, and removing them
3761 makes further changes easier.
3762
0b432f21
PE
3763 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3764 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3765 (string_overrun_cookie): Now const. Use initializers that
3766 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3767 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3768 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3769 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3770 multiple of sizeof (EMACS_INT); it need not be, if
3771 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3772 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3773
895009e1
JB
37742011-04-26 Juanma Barranquero <lekktu@gmail.com>
3775
3776 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3777
6a7a1b0b
TZ
37782011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3779
3780 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3781 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3782 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3783
841a1577 37842011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3785
3786 * lisp.h (Qdebug): List symbol.
895009e1 3787 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3788 * keyboard.c (debug-on-event): New variable.
3789 (handle_user_signal): Break into debugger when debug-on-event
3790 matches the current signal symbol.
3791
f2d3ba6f
DN
37922011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3793
3794 * alloc.c (check_sblock, check_string_bytes)
3795 (check_string_free_list): Convert to standard C.
3796
42ce4c63
TZ
37972011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3798
3799 * w32.c (emacs_gnutls_push): Fix typo.
3800
825cd63c
EZ
38012011-04-25 Eli Zaretskii <eliz@gnu.org>
3802
fb11d64d
EZ
3803 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3804 "cast to pointer from integer of different size".
3805
825cd63c
EZ
3806 Improve doprnt and its use in verror. (Bug#8545)
3807 * doprnt.c (doprnt): Document the set of format control sequences
3808 supported by the function. Use SAFE_ALLOCA instead of always
3809 using `alloca'.
3810
3811 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3812 is one byte too soon. Don't use xrealloc; instead xfree and
3813 xmalloc anew.
3814
e061a11b
TZ
38152011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3816
3817 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3818 callbacks stage.
3819
3820 * gnutls.c: Renamed global_initialized to
3821 gnutls_global_initialized. Added internals for the
3822 :verify-hostname-error, :verify-error, and :verify-flags
3823 parameters of `gnutls-boot' and documented those parameters in the
3824 docstring. Start callback support.
9173deec
JB
3825 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3826 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3827 on error. Return error code.
e061a11b
TZ
3828 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3829 (emacs_gnutls_read): Likewise.
3830 (Fgnutls_boot): Return handshake error code.
3831 (emacs_gnutls_handle_error): New function.
3832 (wsaerror_to_errno): Likewise.
3833
3834 * w32.h (emacs_gnutls_pull): Add prototype.
3835 (emacs_gnutls_push): Likewise.
3836
3837 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3838 (emacs_gnutls_push): Likewise.
3839
38402011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3841
3842 * process.c (wait_reading_process_output): Check if GnuTLS
3843 buffered some data internally if no FDs are set for TLS
3844 connections.
3845
3846 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3847 (LIBS): Link to USER_LIBS.
3848 ($(BLD)/gnutls.$(0)): New target.
3849
fa6996bc
EZ
38502011-04-24 Eli Zaretskii <eliz@gnu.org>
3851
eb35682e
EZ
3852 * xdisp.c (handle_single_display_spec): Rename the
3853 display_replaced_before_p argument into display_replaced_p, to
3854 make it consistent with the commentary. Fix typos in the
3855 commentary.
3856
e2ad650c
EZ
3857 * textprop.c (syms_of_textprop): Remove dead code.
3858 (copy_text_properties): Delete obsolete commentary about an
3859 interface that was deleted long ago. Fix typos in the description
3860 of arguments.
3861
1b2de274
EZ
3862 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3863 to changes in oldXMenu/XMenu.h from 2011-04-16.
3864 <menu_help_message, prev_menu_help_message>: Constify.
3865 (IT_menu_make_room): menu->help_text is now `const char **';
3866 adjust.
3867
3868 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3869 to changes in oldXMenu/XMenu.h from 2011-04-16.
3870 (struct XMenu): Declare `help_text' `const char **'.
3871
3872 * xfaces.c <Qunspecified>: Make extern again.
3873
3874 * syntax.c: Include sys/types.h before including regex.h, as
3875 required by Posix.
3876
762b15be
EZ
3877 * doc.c (get_doc_string): Improve the format passed to `error'.
3878
3879 * doprnt.c (doprnt): Improve commentary.
3880
3881 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3882
3883 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3884 them with etags.
3885
f1052e5d
EZ
3886 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3887 changes in globals.h immediately force recompilation.
762b15be
EZ
3888 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3889 $(CURDIR)/s/ms-w32.h.
3890 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3891
fa6996bc
EZ
3892 * character.c (Fchar_direction): Function deleted.
3893 (syms_of_character): Don't defsubr it.
3894 <char-direction-table>: Deleted.
3895
e6c3da20
EZ
38962011-04-23 Eli Zaretskii <eliz@gnu.org>
3897
3898 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3899 * doprnt.c: Include limits.h.
3900 (SIZE_MAX): New macro.
04f2d78b
CB
3901 (doprnt): Return a size_t value. 2nd arg is now size_t.
3902 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3903 Improve overflow protection. Support `l' modifier for integer
3904 conversions. Support %l conversion. Don't assume an EMACS_INT
3905 argument for integer conversions and for %c.
3906
3907 * lisp.h (doprnt): Restore prototype.
3908
3909 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3910 $(SRC)/character.h.
3911
3912 * Makefile.in (base_obj): Add back doprnt.o.
3913
3914 * deps.mk (doprnt.o): Add back prerequisites.
3915 (callint.o): Depend on character.h.
3916
3917 * eval.c (internal_lisp_condition_case): Include the handler
3918 representation in the error message.
3919 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3920 when breaking from the loop.
3921
3922 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3923
3924 * callint.c (Fcall_interactively): When displaying error message
3925 about invalid control letter, pass the character's codepoint, not
3926 a pointer to its multibyte form. Improve display of the character
3927 in octal and display also its hex code.
3928
3929 * character.c (char_string): Use %x to display the (unsigned)
3930 codepoint of an invalid character, to avoid displaying a bogus
3931 negative value.
3932
3933 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3934 `error', not SYMBOL_NAME itself.
3935
3936 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3937 character arguments to `error'.
3938
3939 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3940 to `error' in error message about FINAL_CHAR argument. Make sure
3941 FINAL_CHAR is a character, and use %c when it is passed as
3942 argument to `error'.
3943
4ffd0d6b 39442011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3945
3946 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3947
3948 * w32.c: Include <time.h>.
3949 (sys_localtime): New function.
3950
4ffd0d6b 39512011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3952
3953 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3954
4ffd0d6b 3955 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3956
4ffd0d6b 39572011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3958
4ffd0d6b
GM
3959 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3960 zombies (Bug#8467).
aac0c6e3 3961
04c56954
EZ
39622011-04-19 Eli Zaretskii <eliz@gnu.org>
3963
3964 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3965 gl_state.e_property when gl_state.object is Qt.
3966
3967 * insdel.c (make_gap_larger): Remove limitation of buffer size
3968 to <= INT_MAX.
3969
16a43933
CY
39702011-04-18 Chong Yidong <cyd@stupidchicken.com>
3971
3972 * xdisp.c (lookup_glyphless_char_display)
3973 (produce_glyphless_glyph): Handle cons cell entry in
3974 glyphless-char-display.
3975 (Vglyphless_char_display): Document it.
3976
3977 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3978 glyphless-char-display.
3979
4581706e
CY
39802011-04-17 Chong Yidong <cyd@stupidchicken.com>
3981
3982 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3983
3984 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3985
3986 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3987 definition for no-X builds.
3988
4887c6e2 39892011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3990
fd35b6f9
PE
3991 Static checks with GCC 4.6.0 and non-default toolkits.
3992
5c1ccb01
PE
3993 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3994
006c5daa
PE
3995 * process.c (keyboard_bit_set): Define only if SIGIO.
3996 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3997 (send_process): Repair possible setjmp clobbering.
3998
efc736d3
PE
3999 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4000
4e2fe2e6
PE
4001 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4002
f97334a2
PE
4003 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4004
4e75f29d
PE
4005 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4006 Define only if needed.
4007
90efadd1
PE
4008 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4009 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4010 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4011
3c647824
PE
4012 * dispextern.h (struct redisplay_interface): Rename param
4013 to avoid shadowing.
e264f262 4014 * termhooks.h (struct terminal): Likewise.
761383f4 4015 * xterm.c (xembed_send_message): Likewise.
3c647824 4016
b58c5c4a
PE
4017 * insdel.c (make_gap_smaller): Define only if
4018 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4019
cad59032
PE
4020 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4021 it.
4022
c339dc2e
PE
4023 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4024 so that we aren't warned about unused symbols.
4025
91a3e27b
PE
4026 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4027
399c71d3 4028 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4029
8ffc96f5
PE
4030 * xfns.c (x_real_positions): Mark locals as initialized.
4031
eef9bc79
PE
4032 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4033
098db9dd
PE
4034 * xterm.c: Fix problems found by static analysis with other toolkits.
4035 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4036 (x_dispatch_event): Declare static if USE_GTK, and
4037 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4038 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4039 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4040 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4041 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4042
eb18f6cc
PE
4043 * xmenu.c (menu_help_callback): Pointer type fixes.
4044 Use const pointers when pointing at readonly data. Avoid pointer
4045 signedness clashes.
4046 (FALSE): Remove unused macro.
4047 (update_frame_menubar): Remove unused decl.
4048
1fe72bf8
PE
4049 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4050
60d9e1db
PE
4051 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4052 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4053 (single_menu_item): Rename local to avoid shadowing.
4054
39261c26
PE
4055 * keyboard.c (make_lispy_event): Remove unused local var.
4056
018c5e19
PE
4057 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4058 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4059
63d2b86e
PE
4060 * bitmaps: Change bitmaps from unsigned char back to the X11
4061 compatible char. Avoid the old compiler warnings about
4062 out-of-range initializers by using, for example, '\xab' rather
4063 than 0xab.
4064
aefd87e1
PE
4065 * xgselect.c (xgselect_initialize): Check vs interface
4066 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4067
bf501fb9
PE
4068 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4069
e9829fdf
PE
4070 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4071 to read-only memory.
4072
1086c095
PE
4073 * fns.c (vector): Remove; this old hack is no longer needed.
4074
2baccd04 4075 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4076 Remove unused var.
dde42981 4077 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4078
72391843 4079 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4080
436c16df 4081 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4082 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4083 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4084
92bb796d 4085 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4086 (x_term_init): Remove local to avoid shadowing.
92bb796d 4087
764430a3 4088 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4089
4090 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4091 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4092
d1dfb56c
EZ
40932011-04-16 Eli Zaretskii <eliz@gnu.org>
4094
c4354cb4
EZ
4095 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4096
d1dfb56c
EZ
4097 Fix regex.c, syntax.c and friends for buffers > 2GB.
4098 * syntax.h (struct gl_state_s): Declare character position members
4099 EMACS_INT.
4100
4101 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4102
04f2d78b
CB
4103 * textprop.c (verify_interval_modification, interval_of):
4104 Declare arguments EMACS_INT.
d1dfb56c
EZ
4105
4106 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4107 EMACS_INT.
4108
4109 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4110
4111 * indent.c (Fvertical_motion): Local variable it_start is now
4112 EMACS_INT.
4113
4114 * regex.c (re_match, re_match_2, re_match_2_internal)
4115 (bcmp_translate, regcomp, regexec, print_double_string)
4116 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4117 (re_compile_pattern, re_exec): Declare arguments and local
4118 variables `size_t' and `ssize_t' and return values `regoff_t', as
4119 appropriate.
4120 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4121 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4122 <compile_stack_type>: `size' and `avail' are now `size_t'.
4123
4124 * regex.h <regoff_t>: Use ssize_t, not int.
4125 (re_search, re_search_2, re_match, re_match_2): Arguments that
4126 specify buffer/string position and length are now ssize_t and
4127 size_t. Return type is regoff_t.
4128
613052cd
BK
41292011-04-16 Ben Key <bkey76@gmail.com>
4130
4131 * nsfont.m: Fixed bugs in ns_get_family and
4132 ns_descriptor_to_entity that were caused by using free to
4133 deallocate memory blocks that were allocated by xmalloc (via
4134 xstrdup). This caused Emacs to crash when compiled with
4135 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4136 --enable-checking=xmallocoverrun). xfree is now used to
4137 deallocate these memory blocks.
4138
4170f62f 41392011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4140
71b41406
PE
4141 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4142
9587a89d
PE
4143 emacs_write: Accept and return EMACS_INT for sizes.
4144 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4145 et seq.
4146 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4147 Accept and return EMACS_INT.
4148 (emacs_gnutls_write): Return the number of bytes written on
4149 partial writes.
4150 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4151 (emacs_read, emacs_write): Remove check for negative size, as the
4152 Emacs source code has been audited now.
9587a89d
PE
4153 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4154 (emacs_read, emacs_write): Use it.
273a5f82
PE
4155 * process.c (send_process): Adjust to the new signatures of
4156 emacs_write and emacs_gnutls_write. Do not attempt to store
4157 a byte offset into an 'int'; it might overflow.
9587a89d 4158 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4159
3e047f51
PE
4160 * sound.c: Don't assume sizes fit in 'int'.
4161 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4162 Return EMACS_INT, not int.
3e047f51 4163 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4164 Accept EMACS_INT, not int.
4165 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4166 record read return values.
4167
cc39a9db
BK
41682011-04-15 Ben Key <bkey76@gmail.com>
4169
c9d0ec6d
JB
4170 * keyboard.c (Qundefined): Don't declare static since it is used
4171 in nsfns.m.
4172 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4173 static since they are used in nsfont.m.
cc39a9db 4174
6c60eb9f
SM
41752011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4176
4177 * process.c (Qprocessp): Don't declare static.
4178 * lisp.h (Qprocessp): Declare again.
4179
7990b61a
JB
41802011-04-15 Juanma Barranquero <lekktu@gmail.com>
4181
4182 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4183
5d4cb038
PE
41842011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4185
8bd7b830 4186 Improve C-level modularity by making more things 'static'.
cd64ea1d 4187
e3b27b31
PE
4188 Don't publish debugger-only interfaces to other modules.
4189 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4190 (verify_bytepos, count_markers): Move decls to the only modules
4191 that need them.
4192 * region-cache.h (pp_cache): Likewise.
4193 * window.h (check_all_windows): Likewise.
4194 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4195
5d4cb038
PE
4196 * sysdep.c (croak): Now static, if
4197 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4198 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4199
4200 * alloc.c (refill_memory_reserve): Now static if
4201 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4202 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4203
e87b6180
PE
4204 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4205 Define only if USE_LUCID.
4206
ac64929e
PE
4207 * xrdb.c (x_customization_string, x_rm_string): Now static.
4208
6f37259d
PE
4209 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4210 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4211
1683e3ab
PE
4212 * xdisp.c (draw_row_with_mouse_face): Now static.
4213 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4214
de9c2632
PE
4215 * window.h (check_all_windows): Mark externally visible.
4216
2b96acb7
PE
4217 * window.c (window_deletion_count): Now static.
4218
4219 * undo.c: Make symbols static if they're not exported.
4220 (last_undo_buffer, last_boundary_position, pending_boundary):
4221 Now static.
4222
50436f33
PE
4223 * textprop.c (interval_insert_behind_hooks): Now static.
4224 (interval_insert_in_front_hooks): Likewise.
4225
64520e5c
PE
4226 * term.c: Make symbols static if they're not exported.
4227 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4228 (max_frame_lines, tty_set_terminal_modes):
4229 (tty_reset_terminal_modes, tty_turn_off_highlight):
4230 (get_tty_terminal): Now static.
4231 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4232 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4233 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4234 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4235 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4236
1fa53021
PE
4237 * sysdep.c: Make symbols static if they're not exported.
4238 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4239 Now static.
4240 (sigprocmask_set, full_mask): Remove; unused.
4241 (wait_debugging): Mark as visible.
4242 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4243 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4244
d4b43b22
PE
4245 * syntax.c (syntax_temp): Define only if !__GNUC__.
4246
b7c513d0
PE
4247 * sound.c (current_sound_device, current_sound): Now static.
4248
989b29ad
PE
4249 * search.c (searchbufs, searchbuf_head): Now static.
4250
13a55a78
PE
4251 * scroll.c (scroll_cost): Remove; unused.
4252 * dispextern.h (scroll_cost): Remove decl.
4253
de68a1fc
PE
4254 * region-cache.h (pp_cache): Mark as externally visible.
4255
40ccffa6
PE
4256 * process.c: Make symbols static if they're not exported.
4257 (process_tick, update_tick, create_process, chan_process):
4258 (Vprocess_alist, proc_buffered_char, datagram_access):
4259 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4260 (deactivate_process): Mark defn as static, as well as decl.
4261 * lisp.h (create_process): Remove decl.
4262 * process.h (chan_process, Vprocess_alist): Remove decls.
4263
ad64fc97
PE
4264 * print.c: Make symbols static if they're not exported.
4265 (print_depth, new_backquote_output, being_printed, print_buffer):
4266 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4267 (print_interval, print_number_index, initial_stderr_stream):
4268 Now static.
4269 * lisp.h (Fprinc): Remove decl.
4270 (debug_output_compilation_hack): Mark as externally visible.
4271
adddb265
PE
4272 * sysdep.c (croak): Move decl from here to syssignal.h.
4273 * syssignal.h (croak): Put it here, so the API can be checked when
4274 'croak' is called from dissociate_if_controlling_tty.
4275
1717ede2
PE
4276 * minibuf.c: Make symbols static if they're not exported.
4277 (minibuf_save_list, choose_minibuf_frame): Now static.
4278 * lisp.h (choose_minibuf_frame): Remove decl.
4279
fa5fb2bc
PE
4280 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4281
1e3890d1
PE
4282 * lread.c: Make symbols static if they're not exported.
4283 (read_objects, initial_obarray, oblookup_last_bucket_number):
4284 Now static.
4285 (make_symbol): Remove; unused.
4286 * lisp.h (initial_obarray, make_symbol): Remove decls.
4287
8a1414fa
PE
4288 * keyboard.c: Make symbols static if they're not exported.
4289 (single_kboard, recent_keys_index, total_keys, recent_keys):
4290 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4291 (this_single_command_key_start, echoing, last_auto_save):
4292 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4293 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4294 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4295 (Vlispy_mouse_stem, double_click_count):
4296 Now static.
4297 (force_auto_save_soon): Define only if SIGDANGER.
4298 (ignore_mouse_drag_p): Now static if
4299 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4300 (print_help): Remove; unused.
4301 (stop_character, last_timer_event): Mark as externally visible.
4302 * keyboard.h (ignore_mouse_drag_p): Declare only if
4303 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4304 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4305 * lisp.h (echoing): Remove decl.
4306 (force_auto_save_soon): Declare only if SIGDANGER.
4307 * xdisp.c (redisplay_window): Simplify code, to make it more
4308 obvious that ignore_mouse_drag_p is not accessed if !defined
4309 USE_GTK && !defined HAVE_NS.
4310
93ea6e8f
PE
4311 * intervals.c: Make symbols static if they're not exported.
4312 (merge_properties_sticky, merge_interval_right, delete_interval):
4313 Now static.
4314 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4315
77382fcc
PE
4316 * insdel.c: Make symbols static if they're not exported.
4317 However, leave prepare_to_modify_buffer alone. It's never
4318 called from outside this function, but that appears to be a bug.
4319 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4320 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4321 (adjust_after_replace_noundo): Remove; unused.
4322 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4323 (signal_before_change): Remove decls.
77382fcc 4324
9306c32e
PE
4325 * indent.c (val_compute_motion, val_vmotion): Now static.
4326
cd44d2eb
PE
4327 * image.c: Make symbols static if they're not exported.
4328 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4329 if USE_GTK.
4330 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4331 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4332
ad9a7a06
PE
4333 * fringe.c (standard_bitmaps): Now static.
4334 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4335
81626931
PE
4336 * frame.c: Make symbols static if they're not exported.
4337 (x_report_frame_params, make_terminal_frame): Now static.
4338 (get_frame_param): Now static, unless HAVE_NS.
4339 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4340 (x_get_resource_string): Remove; not used.
4341 * frame.h (make_terminal_frame, x_report_frame_params):
4342 (x_get_resource_string); Remove decls.
4343 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4344 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4345
239f9db9
PE
4346 * font.c, fontset.c: Make symbols static if they're not exported.
4347 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4348 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4349 * font.c (font_close_object): Now static.
4350 * font.h (font_close_object): Remove.
4351 * fontset.c (FONTSET_OBJLIST): Remove.
4352 (free_realized_fontset) #if-0 the body, which does nothing.
4353 (face_suitable_for_char_p): #if-0, as it's never called.
4354 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4355 * xfaces.c (face_at_string_position):
4356 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4357 since 0 is always ASCII.
4358
dfcf3579
PE
4359 * fns.c (weak_hash_tables): Now static.
4360
5045092b
PE
4361 * fileio.c: Make symbols static if they're not exported.
4362 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4363 (Vwrite_region_annotation_buffers): Now static.
4364
57a96f5c
PE
4365 * eval.c: Make symbols static if they're not exported.
4366 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4367 * lisp.h (backtrace_list): Remove decl.
4368
35f08c38
PE
4369 * emacs.c: Make symbols static if they're not exported.
4370 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4371 (fatal_error_code, fatal_error_signal_hook, standard_args):
4372 Now static.
4373 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4374 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4375 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4376 * lisp.h (fatal_error_signal_hook): Remove decl.
4377 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4378
f44bd759
PE
4379 * editfns.c: Move a (normally-unused) function to its only use.
4380 * editfns.c, lisp.h (get_operating_system_release): Remove.
4381 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4382 worth the hassle of breaking this out.
4383
b532497d
PE
4384 * xterm.c: Make symbols static if they're not exported.
4385 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4386 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4387 (x_destroy_window, x_delete_display):
4388 Now static.
4389 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4390 (x_mouse_leave): Remove; unused.
4391 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4392 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4393 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4394 Remove decls.
4395 (x_mouse_leave): Declare only if WINDOWSNT.
4396 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4397 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4398 USE_X_TOOLKIT.
4399
1675728f
PE
4400 * ftxfont.c: Make symbols static if they're not exported.
4401 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4402 HAVE_FREETYPE.
4403 * font.h (ftxfont_driver): Likewise.
4404
e4cebfca
PE
4405 * xfns.c: Make symbols static if they're not exported.
4406 (x_last_font_name, x_display_info_for_name):
4407 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4408 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4409 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4410 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4411 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4412 (last_show_tip_args): Now static.
4413 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4414 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4415 (x_screen_planes): Remove; unused.
4416 * dispextern.h (x_screen_planes): Remove decl.
4417
5bf46f05
PE
4418 * dispnew.c: Make symbols static if they're not exported.
4419 * dispextern.h (redraw_garbaged_frames, scrolling):
4420 (increment_row_positions): Remove.
4421 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4422 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4423 Now static.
4424 (redraw_garbaged_frames): Remove; unused.
4425
435f4c28
PE
4426 * xfaces.c: Make symbols static if they're not exported.
4427 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4428 Remove decls.
4429 * xterm.h (defined_color): Remove decls.
4430 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4431 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4432 (menu_face_changed_default, defined_color, free_realized_face):
4433 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4434 (ascii_face_of_lisp_face): Remove; unused.
4435
8524aef3
PE
4436 * xdisp.c: Make symbols static if they're not exported.
4437 * dispextern.h (scratch_glyph_row, window_box_edges):
4438 (glyph_to_pixel_coords, set_cursor_from_row):
4439 (get_next_display_element, set_iterator_to_next):
4440 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4441 (show_mouse_face): Remove decls
4442 * frame.h (message_buf_print): Likewise.
4443 * lisp.h (pop_message, set_message, check_point_in_composition):
4444 Likewise.
4445 * xterm.h (set_vertical_scroll_bar): Likewise.
4446 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4447 (message_buf_print, scratch_glyph_row, displayed_buffer):
4448 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4449 (get_next_display_element, show_mouse_face, window_box_edges):
4450 (frame_to_window_pixel_xy, check_point_in_composition):
4451 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4452 (glyph_to_pixel_coords): Remove; unused.
4453
16390cd2
PE
4454 * dired.c (file_name_completion): Now static.
4455
4456 * dbusbind.c (xd_in_read_queued_messages): Now static.
4457
a25f4dfa
PE
4458 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4459 * data.c (circular_list_error): Remove.
4460
14a9c8df
PE
4461 * commands.h (last_point_position, last_point_position_buffer):
4462 (last_point_position_window): Remove decls.
4463 * keyboard.c: Make these variables static.
4464
04f2d78b
CB
4465 * coding.h (coding, code_convert_region, encode_coding_gap):
4466 Remove decls.
74ab6df5
PE
4467 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4468 (iso_code_class, detect_coding, code_convert_region): Now static.
4469 (encode_coding_gap): Remove; unused.
4470
38dfbee1
PE
4471 * chartab.c (chartab_chars, chartab_bits): Now static.
4472
a2cb4e63
PE
4473 * charset.h (charset_iso_8859_1): Remove decl.
4474 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4475 Now static.
4476
127198fd
PE
4477 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4478 * ccl.c (Vccl_program_table): Now static.
4479 (check_ccl_update): Remove; unused.
4480
d85b608f
PE
4481 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4482 * category.h: ... from here.
4483 * category.c (check_category_table, set_category_set): Now static.
4484
31cd66f3
PE
4485 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4486 * lisp.h: Remove these decls.
4487
c358e587
PE
4488 * buffer.c (buffer_count): Remove unused var.
4489
e78aecca
PE
4490 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4491 so that it's not optimized away.
4492 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4493 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4494 exported only to the debugger.
4495
e192d7d3 4496 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4497 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4498
92470028
PE
4499 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4500 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4501 was inaccessible from Lisp.
4502 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4503 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4504
244ed907
PE
4505 alloc.c: Import and export fewer symbols, and remove unused items.
4506 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4507 is defined.
4508 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4509 it's not optimized away by whole-program optimization.
4510 (message_enable_multibyte, free_misc): Remove.
4511 (catchlist, handlerlist, mark_backtrace):
4512 Declare only if BYTE_MARK_STACK.
4513 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4514 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4515 (message_enable_multibyte): Remove decl.
4516 (free_misc, interval_free_list, float_block, float_block_index):
4517 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4518 (cons_free_list, last_marked_index):
4519 Now static.
4520 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4521 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4522 (mark_backtrace): Define only if BYTE_MARK_STACK.
4523 * xdisp.c (message_enable_multibyte): Now static.
4524
61c2b50e 4525 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4526 This makes it easier for human readers (and static analyzers)
4527 to see whether these variables are used from other modules.
4528 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4529 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4530 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4531 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4532 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4533 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4534 * xmenu.c, xselect.c:
4535 Declare Q* vars static if they are not used in other modules.
4536 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4537 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4538 Remove decls of unexported vars.
4539 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4540
95c82688
PE
4541 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4542
16a97296
PE
4543 Make Emacs functions such as Fatom 'static' by default.
4544 This makes it easier for human readers (and static analyzers)
4545 to see whether these functions can be called from other modules.
4546 DEFUN now defines a static function. To make the function external
4547 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4548 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4549 (Finit_image_library):
16a97296
PE
4550 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4551 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4552 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4553 Remove decls, since these functions are now static.
4554 (Funintern, Fget_internal_run_time): New decls, since these functions
4555 were already external.
95c82688 4556
16a97296
PE
4557 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4558 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4559 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4560 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4561 * keyboard.c, keymap.c, lread.c:
4562 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4563 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4564 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4565 Mark functions with DEFUE instead of DEFUN,
4566 if they are used in other modules.
4567 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4568 decls for now-static functions.
4569 * buffer.h (Fdelete_overlay): Remove decl.
4570 * callproc.c (Fgetenv_internal): Mark as internal.
4571 * composite.c (Fremove_list_of_text_properties): Remove decl.
4572 (Fcomposition_get_gstring): New forward static decl.
4573 * composite.h (Fcomposite_get_gstring): Remove decl.
4574 * dired.c (Ffile_attributes): New forward static decl.
4575 * doc.c (Fdocumntation_property): New forward static decl.
4576 * eval.c (Ffetch_bytecode): New forward static decl.
4577 (Funintern): Remove extern decl; now in .h file where it belongs.
4578 * fileio.c (Fmake_symbolic_link): New forward static decl.
4579 * image.c (Finit_image_library): New forward static decl.
4580 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4581 * intervals.h (Fprevious_property_change):
4582 (Fremove_list_of_text_properties): Remove decls.
4583 * keyboard.c (Fthis_command_keys): Remove decl.
4584 (Fcommand_execute): New forward static decl.
4585 * keymap.c (Flookup_key): New forward static decl.
4586 (Fcopy_keymap): Now static.
4587 * keymap.h (Flookup_key): Remove decl.
4588 * process.c (Fget_process): New forward static decl.
4589 (Fprocess_datagram_address): Mark as internal.
4590 * syntax.c (Fsyntax_table_p): New forward static decl.
4591 (skip_chars): Remove duplicate decl.
4592 * textprop.c (Fprevious_property_change): New forward static decl.
4593 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4594 Now internal.
4595 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4596 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4597
785bbd42
PE
4598 * editfns.c (Fformat): Remove unreachable code.
4599
8b913b57
AS
46002011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4601
4602 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4603 change. (Bug#8496)
4604
a6744a35
EZ
46052011-04-13 Eli Zaretskii <eliz@gnu.org>
4606
4607 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4608 when at ZV. (Bug#8487)
4609
e7974947
AS
46102011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4611
baad03f0
AS
4612 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4613 (Bug#8437)
4614 * keyboard.c (parse_tool_bar_item): Likewise.
4615 * sound.c (sound_cleanup, alsa_close): Likewise.
4616 * termcap.c (tgetent): Likewise.
4617 * xfns.c (x_default_font_parameter): Likewise.
4618 * xsettings.c (read_and_apply_settings): Likewise.
4619
e7974947
AS
4620 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4621 (overrun_check_free): Protoize.
4622
28272684
PE
46232011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4624
4625 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4626 since callers should never pass a negative size.
4627 Change the signature to match that of plain 'read' and 'write'; see
4628 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4629 * lisp.h: Update prototypes of emacs_write and emacs_read.
4630
11997c76
EZ
46312011-04-11 Eli Zaretskii <eliz@gnu.org>
4632
4633 * xdisp.c (redisplay_window): Don't try to determine the character
4634 position of the scroll margin if the window start point w->startp
e896f03c 4635 is outside the buffer's accessible region. (Bug#8468)
11997c76 4636
8a2cbd72
EZ
46372011-04-10 Eli Zaretskii <eliz@gnu.org>
4638
4639 Fix write-region and its subroutines for buffers > 2GB.
4640 * fileio.c (a_write, e_write): Modify declaration of arguments and
4641 local variables to support buffers larger than 2GB.
4642 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4643
4644 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4645 argument, local variables, and return value.
4646
4647 * lisp.h: Update prototypes of emacs_write and emacs_read.
4648
4649 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4650
4073e537 46512011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4652
1ebfdcb6
PE
4653 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4654
b2ded58d
PE
4655 Fix more problems found by GCC 4.6.0's static checks.
4656
7d66342c
PE
4657 * xdisp.c (vmessage): Use a better test for character truncation.
4658
bbf47d44
PE
4659 * charset.c (load_charset_map): <, not <=, for optimization,
4660 and to avoid potential problems with integer overflow.
9248994d 4661 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4662 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4663 * editfns.c (Fformat): Likewise.
1e69125e 4664 * syntax.c (skip_chars): Likewise.
3befa583 4665
e3019616
PE
4666 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4667 This also lets GCC 4.6.0 generate slightly better loop code.
4668
becfa255
PE
4669 * callint.c (Fcall_interactively): <, not <=, for optimization.
4670 (Fcall_interactively): Count the number of arguments produced,
4671 not the number of arguments given. This is simpler and lets GCC
4672 4.6.0 generate slightly better code.
4673
dae0cd48
PE
4674 * ftfont.c: Distingish more carefully between FcChar8 and char.
4675 The previous code passed unsigned char * to a functions like
4676 strlen and xstrcasecmp that expect char *, which does not
4677 conform to the C standard.
4678 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4679 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4680 char * when the C standard requires it.
4681
76032d70
PE
4682 * keyboard.c (read_char): Remove unused var.
4683
eb3f1cc8
PE
4684 * eval.c: Port to Windows vsnprintf (Bug#8435).
4685 Include <limits.h>.
4686 (SIZE_MAX): Define if the headers do not.
4687 (verror): Do not give up if vsnprintf returns a negative count.
4688 Instead, grow the buffer. This ports to Windows vsnprintf, which
4689 does not conform to C99. Problem reported by Eli Zaretskii.
4690 Also, simplify the allocation scheme, by avoiding the need for
4691 calling realloc, and removing the ALLOCATED variable.
4692
70476b54
PE
4693 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4694
12020a9e
PE
4695 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4696 But keep the doprint source code for now, as we might revamp it
4697 and use it again (Bug#8435).
ea6c7ae6
PE
4698 * lisp.h (doprnt): Remove.
4699 * Makefile.in (base_obj): Remove doprnt.o.
4700 * deps.mk (doprnt.o): Remove.
4701
5fdb398c
PE
4702 error: Print 32- and 64-bit integers portably (Bug#8435).
4703 Without this change, on typical 64-bit hosts error ("...%d...", N)
4704 was used to print both 32- and 64-bit integers N, which relied on
4705 undefined behavior.
4706 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4707 New macro.
4708 * lisp.h (error, verror): Mark as printf-like functions.
4709 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4710 Report overflow in size calculations when allocating printf buffer.
4711 Do not truncate output string at its first null byte.
4712 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4713 Truncate the output at a character boundary, since vsnprintf does not
4714 do that.
4715 * charset.c (check_iso_charset_parameter): Convert internal
4716 character to string before calling 'error', since %c now has the
4717 printf meaning.
4718 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4719 overflow when computing char to be passed to 'error'. Do not
4720 pass Lisp_Object to 'error'; pass the integer instead.
4721 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4722 formatted with plain %d.
4723
b189fa66
PE
4724 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4725
bff87ef0
PE
4726 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4727
7e2cac20
PE
4728 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4729
ce4d90b5
PE
4730 * xterm.c (x_catch_errors): Remove duplicate declaration.
4731
266c9547
PE
4732 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4733
79c49ad2
PE
4734 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4735
368f4090
JM
47362011-04-10 Jim Meyering <meyering@redhat.com>
4737
4738 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4739 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4740 return ssize_t not "int", and use size_t as the buffer length.
4741 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4742 * gnutls.h: Update declarations.
4743 * process.c (read_process_output): Use ssize_t, to match.
4744 (send_process): Likewise.
4745
a32d4040
CY
47462011-04-09 Chong Yidong <cyd@stupidchicken.com>
4747
4748 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4749
8546720e 47502011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4751
04f2d78b
CB
4752 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4753 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4754
8546720e
GM
4755 * xterm.c (handle_one_xevent):
4756 * xmenu.c (create_and_show_popup_menu):
4757 * xselect.c (x_decline_selection_request)
4758 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4759
0a2f5c1a 47602011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4761
4762 Fix some uses of `int' instead of EMACS_INT.
4763 * search.c (string_match_1, fast_string_match)
4764 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4765 (scan_buffer, find_next_newline_no_quit)
4766 (find_before_next_newline, search_command, Freplace_match)
4767 (Fmatch_data): Make some `int' variables be EMACS_INT.
4768
4769 * xdisp.c (display_count_lines): 3rd argument and return value now
4770 EMACS_INT. All callers changed.
4771 (pint2hrstr): Last argument is now EMACS_INT.
4772
4773 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4774 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4775 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4776 (decode_coding_utf_16, decode_coding_emacs_mule)
4777 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4778 (decode_coding_ccl, decode_coding_charset)
4779 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4780 (decode_coding_iso_2022, decode_coding_emacs_mule)
4781 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4782 <char_offset, last_offset>: Declare EMACS_INT.
4783 (encode_coding_utf_8, encode_coding_utf_16)
4784 (encode_coding_emacs_mule, encode_invocation_designation)
4785 (encode_designation_at_bol, encode_coding_iso_2022)
4786 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4787 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4788 Declare EMACS_INT.
4789 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4790 (encode_invocation_designation): Last argument P_NCHARS is now
4791 EMACS_INT.
4792 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4793 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4794
4795 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4796 All users changed.
4797
4798 * ccl.c (Fccl_execute_on_string): Declare some variables
4799 EMACS_INT.
4800
8546720e 48012011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4802
4803 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4804
4e19a977
CS
48052011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4806
4807 * process.c (Fformat_network_address): Doc fix.
4808
87302331
R
48092011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4810
4811 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4812
cbb59342
CY
48132011-04-08 Chong Yidong <cyd@stupidchicken.com>
4814
4815 * keyboard.c (read_char): Call Lisp function help-form-show,
4816 instead of using internal_with_output_to_temp_buffer.
4817 (Qhelp_form_show): New var.
e0d38eeb 4818 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4819
4820 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4821
4822 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4823
e67a13ab
CY
48242011-04-06 Chong Yidong <cyd@stupidchicken.com>
4825
04f2d78b
CB
4826 * process.c (Flist_processes): Remove to Lisp.
4827 (list_processes_1): Delete.
e67a13ab 4828
973f782d
EZ
48292011-04-06 Eli Zaretskii <eliz@gnu.org>
4830
7c106b1e
EZ
4831 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4832
973f782d
EZ
4833 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4834
41cf7d1a 48352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4836
ca23cc88
PE
4837 Fix more problems found by GCC 4.6.0's static checks.
4838
f390e2d5
PE
4839 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4840
42eea0d0
PE
4841 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4842
b69769da 4843 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4844
f9541e84
PE
4845 * xdisp.c (vmessage): Mark as a printf-like function.
4846
13841b55
PE
4847 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4848
c136c10f
PE
4849 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4850
5e2d4a30
PE
4851 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4852 printf-like functions.
4853 (tiff_load): Add casts to remove these marks before passing them
4854 to system-supplied API.
4855
583f48b9
PE
4856 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4857
b25d760e
PE
4858 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4859 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4860 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4861 directly, rather than having caller test rule sign. This avoids
4862 some unnecessary tests.
4863 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4864 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4865 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4866
bc7b6697 4867 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4868 (xfont_open): Avoid unnecessary tests.
bc7b6697 4869
27ccc379
PE
4870 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4871
dcd5c89a
PE
4872 * composite.h, composite.c (composition_gstring_put_cache):
4873 Use EMACS_INT, not int, for length.
4874
b13a45c6
PE
4875 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4876 breaking out part of COMPOSITION_DECODE_RULE.
4877 (COMPOSITION_DECODE_RULE): Use it.
4878 * composite.c (get_composition_id): Remove unused local vars,
4879 by using the new macro.
4880
1e792e4d
PE
4881 * textprop.c (set_text_properties_1): Change while to do-while,
4882 since the condition is always true at first.
4883
dc6c6455 4884 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4885 (interval_deletion_adjustment): Return unsigned value.
4886 All uses changed.
dc6c6455 4887
aba7731a
PE
4888 * process.c (list_processes_1, create_pty, read_process_output):
4889 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4890 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4891 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4892 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4893 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4894
fdfc4bf3
PE
4895 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4896
fca8fe46 4897 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4898 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4899
06a0259a 4900 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4901 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4902 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4903
e7b9e80f
PE
4904 * print.c (print_error_message): Avoid int overflow.
4905
56201685
PE
4906 * font.c (font_list_entities): Redo for clarity,
4907 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4908
78834453 4909 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4910 (font_score): Avoid potential overflow in diff calculation.
78834453 4911
0bc0b309 4912 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4913 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4914
e610eaca
PE
4915 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4916
b895abce
PE
4917 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4918 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4919 can always succeed if overflow has undefined behavior.
4920
1f1d9321 4921 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4922 (wordify): Omit three unnecessary tests.
1f1d9321 4923
c59478bc
PE
4924 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4925 All callers changed. This avoids the need for an unused var.
4926
79b73827
PE
4927 * casefiddle.c (casify_region): Remove var that is set but not used.
4928
a4db5dfe
PE
4929 * dired.c (file_name_completion): Remove var that is set but not used.
4930
43aae36e
PE
4931 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4932
2a47c44d 4933 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4934 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4935
a37c69bf
PE
4936 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4937 Check for integer overflow on size calculations.
4938
328ab8e7
PE
4939 * buffer.c (Fprevious_overlay_change): Remove var that is set
4940 but not used.
4941
e5a2a5cb
PE
4942 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4943 Remove vars that are set but not used.
8d84a6eb 4944 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4945 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4946
a60e5f68
PE
4947 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4948
f661cb61 4949 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4950 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4951
f0397f5a
PE
4952 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4953 that are set but not used.
4954
8664db06 4955 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4956 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4957
6abdaa4a
PE
4958 * xselect.c (x_get_local_selection, x_handle_property_notify):
4959 Remove vars that are set but not used.
4960
0ce7538d 4961 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4962 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4963
9ae848fc
PE
4964 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4965 Remove var that is set but not used.
0b918413
PE
4966 (scroll_bar_windows_size): Now size_t, not int.
4967 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4968 Check for overflow.
9ae848fc 4969
a5a62657
PE
4970 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4971 (map_tty_color) [!defined MSDOS]: Likewise.
4972
5c5cdd39
PE
4973 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4974
66ebf983
PE
4975 * coding.c: Remove vars that are set but not used.
4976 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4977 All callers changed.
4978 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4979 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4980 (decode_coding_charset): Remove vars that are set but not used.
4981
1be4d761
PE
4982 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4983 that is set but not used.
4984
47553fa8
PE
4985 * print.c (print_object): Remove var that is set but not used.
4986
1f7196bf 4987 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4988 The gnulib version avoids calling malloc in the usual case,
4989 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4990 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4991 * filelock.c (current_lock_owner): Likewise.
4992 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4993 * sysdep.c: Include allocator.h, careadlinkat.h.
4994 (emacs_no_realloc_allocator): New static constant.
4995 (emacs_readlink): New function.
fdb61804
PE
4996 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4997 ../lib/careadlinkat.h.
d1fdcab7 4998
f84c17c7
SM
49992011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5000
5001 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5002 first non-nil return value).
5003
ef3862ad
JD
50042011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5005
5006 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5007 if not defined (Bug#8403).
5008
376a7006
JB
50092011-04-02 Juanma Barranquero <lekktu@gmail.com>
5010
5011 * xdisp.c (display_count_lines): Remove parameter `start',
5012 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5013 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5014 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5015 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5016 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5017 and thereabouts. All callers changed.
5018 (get_per_char_metric): Remove parameter `f', unused since
5019 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5020
6ca3801d
JM
50212011-04-02 Jim Meyering <meyering@redhat.com>
5022
5023 do not dereference NULL upon failed strdup
5024 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5025 (ns_get_family): Likewise.
5026
d8e2b5ba
JB
50272011-04-02 Juanma Barranquero <lekktu@gmail.com>
5028
5029 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5030
8c74fcbd
JD
50312011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5032
5033 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5034 later (Bug#8403).
5035
7200d79c
SM
50362011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5037
03408648 5038 Add lexical binding.
7200d79c 5039
03408648
SM
5040 * window.c (Ftemp_output_buffer_show): New fun.
5041 (Fsave_window_excursion):
5042 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5043
5044 * lread.c (lisp_file_lexically_bound_p): New function.
5045 (Fload): Bind Qlexical_binding.
5046 (readevalloop): Remove `evalfun' arg.
5047 Bind Qinternal_interpreter_environment.
5048 (Feval_buffer): Bind Qlexical_binding.
5049 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5050 Mark as dynamic.
5051 (syms_of_lread): Declare `lexical-binding'.
5052
5053 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5054
5055 * keyboard.c (eval_dyn): New fun.
5056 (menu_item_eval_property): Use it.
ca105506
SM
5057
5058 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5059
03408648
SM
5060 * fns.c (concat, mapcar1): Accept byte-code-functions.
5061
5062 * eval.c (Fsetq): Handle lexical vars.
5063 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5064 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5065 (FletX, Flet): Obey lexical binding.
5066 (Fcommandp): Handle closures.
5067 (Feval): New `lexical' arg.
5068 (eval_sub): New function extracted from Feval. Use it almost
5069 everywhere where Feval was used. Look up vars in lexical env.
5070 Handle closures.
5071 (Ffunctionp): Move from subr.el.
5072 (Ffuncall): Handle closures.
5073 (apply_lambda): Remove `eval_flags'.
5074 (funcall_lambda): Handle closures and new byte-code-functions.
5075 (Fspecial_variable_p): New function.
5076 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5077 but without exporting it to Lisp.
23aba0ea 5078
23aba0ea 5079 * doc.c (Fdocumentation, store_function_docstring):
03408648 5080 * data.c (Finteractive_form): Handle closures.
23aba0ea 5081
03408648
SM
5082 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5083 interactive spec.
ba83908c 5084
04f2d78b
CB
5085 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5086 New byte-codes.
03408648
SM
5087 (exec_byte_code): New function extracted from Fbyte_code to handle new
5088 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5089
03408648 5090 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5091
03408648 5092 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5093
e2abce01
JB
50942011-03-31 Juanma Barranquero <lekktu@gmail.com>
5095
5096 * xdisp.c (redisplay_internal): Fix prototype.
5097
63696a73 50982011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5099
63696a73 5100 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5101 (try_scrolling): Use it when setting scroll_limit.
5102 Limit scrolling to 100 screen lines.
63696a73
EZ
5103 (redisplay_window): Even when falling back on "recentering",
5104 position point in the window according to scroll-conservatively,
5105 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5106
5107 (try_scrolling): When point is above the window, allow searching
5108 as far as scroll_max, or one screenful, to compute vertical
5109 distance from PT to the scroll margin position. This prevents
5110 try_scrolling from unnecessarily failing when
5111 scroll-conservatively is set to a value slightly larger than the
5112 window height. Clean up the case of PT below the margin at bottom
5113 of window: scroll_max can no longer be INT_MAX. When aggressive
5114 scrolling is in use, don't let point enter the opposite scroll
5115 margin as result of the scroll.
5116 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5117 threshold of 100 lines for never-recentering scrolling.
5118
e4cc2dfc
JB
51192011-03-31 Juanma Barranquero <lekktu@gmail.com>
5120
5121 * dispextern.h (move_it_by_lines):
5122 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5123 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5124 (message_log_check_duplicate): Remove parameters `prev_bol' and
5125 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5126 (redisplay_internal): Remove parameter `preserve_echo_area',
5127 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5128
5129 * indent.c (Fvertical_motion):
5130 * window.c (window_scroll_pixel_based, Frecenter):
5131 Don't pass `need_y_p' to `move_it_by_lines'.
5132
1c470562
SM
51332011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5134
44f230aa
SM
5135 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5136 steal a few bits to be more compact.
5137 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5138 Remove unneeded casts.
5139
1c470562
SM
5140 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5141
888adce9
ZK
51422011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5143
5144 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5145 binding" message (bug#7967).
5146
f838ed7b
PE
51472011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5148
77861b95
PE
5149 Fix more problems found by GCC 4.6.0's static checks.
5150
de6dbc14
PE
5151 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5152 Remove unused local var.
5153
f838ed7b
PE
5154 * editfns.c (Fmessage_box): Remove unused local var.
5155
792c7b2b
PE
5156 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5157 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5158 Omit unused local vars.
c499e557 5159 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5160 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5161 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5162 Omit unused local var.
5163
ba0165e1
PE
5164 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5165 Don't assume string length fits in int.
32ad8845 5166 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5167 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5168
3c59b4c9
PE
5169 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5170 instead of alloca (Bug#8344).
5171
a3eed478 5172 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5173 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5174
eb4d412d
PE
5175 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5176
1658b401
PE
5177 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5178 concerns.
5179
5180 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5181
5182 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5183
9a2c6e05
PE
5184 * keyboard.c (syms_of_keyboard): Use the same style as later
5185 in this function when indexing through an array. This also
5186 works around GCC bug 48267.
5187
03d0a109
PE
5188 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5189
44f730c8
PE
5190 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5191
fe75f926
PE
5192 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5193 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5194
ffa8c828
PE
5195 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5196 This avoids undefined behavior on integer overflow, and is a bit
5197 more convenient anyway since it is compared to a size_t variable.
5198
c5101a77
PE
5199 Variadic C functions now count arguments with size_t, not int.
5200 This avoids an unnecessary limitation on 64-bit machines, which
5201 caused (substring ...) to crash on large vectors (Bug#8344).
5202 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5203 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5204 All variadic functions and their callers changed accordingly.
c5101a77
PE
5205 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5206 * data.c (arith_driver, float_arith_driver): Likewise.
5207 * editfns.c (general_insert_function): Likewise.
5208 * eval.c (struct backtrace.nargs, interactive_p)
5209 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5210 (funcall_lambda, mark_backtrace): Likewise.
5211 * fns.c (concat): Likewise.
5212 * frame.c (x_set_frame_parameters): Likewise.
5213 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5214 0 if not found, not -1. All callers changed.
5215
dd3f25f7
PE
5216 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5217 (stack_copy_size): Now size_t, not int.
5218 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5219
461c2ab9
JB
52202011-03-28 Juanma Barranquero <lekktu@gmail.com>
5221
5222 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5223 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5224 All callers changed.
5225
5226 * lisp.h (multibyte_char_to_unibyte):
5227 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5228 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5229 * character.h (CHAR_TO_BYTE8):
5230 * cmds.c (internal_self_insert):
5231 * editfns.c (general_insert_function):
5232 * keymap.c (push_key_description):
5233 * search.c (Freplace_match):
5234 * xdisp.c (message_dolog, set_message_1): All callers changed.
5235
f6d62986
SM
52362011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5237
5238 * keyboard.c (safe_run_hook_funcall): New function.
5239 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5240 don't set the hook to nil, but remove the offending function instead.
5241 (Qcommand_hook_internal): Remove, unused.
5242 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5243 Vcommand_hook_internal.
5244
5245 * eval.c (enum run_hooks_condition): Remove.
5246 (funcall_nil, funcall_not): New functions.
5247 (run_hook_with_args): Call each function through a `funcall' argument.
5248 Remove `cond' argument, now redundant.
5249 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5250 (Frun_hook_with_args_until_failure): Adjust accordingly.
5251 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5252
1db5b1ad
JB
52532011-03-28 Juanma Barranquero <lekktu@gmail.com>
5254
5255 * dispextern.h (string_buffer_position): Remove declaration.
5256
5257 * print.c (strout): Remove parameter `multibyte', unused since
5258 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5259
5260 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5261 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5262 All callers changed.
5263
5264 * w32.c (_wsa_errlist): Use braces for struct initializers.
5265
5266 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5267 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5268 All callers changed.
5269 (string_buffer_position): Likewise. Also, make static (it's never
5270 used outside xdisp.c).
5271 (cursor_row_p): Remove parameter `w', unused since
5272 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5273 (decode_mode_spec): Remove parameter `precision', introduced during
5274 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5275 All callers changed.
5276
5ffb62aa
JD
52772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5278
5279 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5280
461c2ab9 52812011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5282
5283 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5284 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5285 (ns_update_auto_hide_menu_bar): New functions.
5286 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5287 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5288 ns_constrain_all_frames.
5289 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5290 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5291
5c380ffb
JD
52922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5293
5294 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5295
9af30bdf
GM
52962011-03-27 Glenn Morris <rgm@gnu.org>
5297
5298 * syssignal.h: Replace RETSIGTYPE with void.
5299 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5300 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5301 Replace SIGTYPE with void everywhere.
5302 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5303 * s/template.h (SIGTYPE): Remove commented out definition.
5304
e2abce01
JB
53052011-03-26 Eli Zaretskii <eliz@gnu.org>
5306
5307 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5308 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5309
f868cd8a
JB
53102011-03-26 Juanma Barranquero <lekktu@gmail.com>
5311
59eb0929
JB
5312 * w32.c (read_unc_volume): Use parameter `henum', instead of
5313 global variable `wget_enum_handle'.
5314
5315 * keymap.c (describe_vector): Remove parameters `indices' and
5316 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5317 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5318
f868cd8a
JB
5319 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5320
5321 * keyboard.c (timer_check): Remove parameter `do_it_now',
5322 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5323 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5324 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5325
5326 * keyboard.c (read_char):
5327 * w32menu.c (w32_menu_display_help):
5328 * xmenu.c (show_help_event, menu_help_callback):
5329 Adjust calls to `show_help_echo'.
5330
5331 * gtkutil.c (xg_maybe_add_timer):
5332 * keyboard.c (readable_events):
5333 * process.c (wait_reading_process_output):
5334 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5335
5336 * insdel.c (adjust_markers_gap_motion):
5337 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5338 (gap_left, gap_right): Don't call it.
5339
2ecf6fdb
CY
53402011-03-25 Chong Yidong <cyd@stupidchicken.com>
5341
5342 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5343 incurred during fontification.
5344
6b1f9ba4
JB
53452011-03-25 Juanma Barranquero <lekktu@gmail.com>
5346
5347 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5348 (DEFVAR_PER_BUFFER): Don't pass it.
5349
5350 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5351 (scrolling_window): Don't pass it.
5352
0f4a96b5
JB
53532011-03-25 Juanma Barranquero <lekktu@gmail.com>
5354
5355 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5356
5357 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5358 and `suffix'.
5359 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5360 of variables specific to SELinux and computation of `encoded_absname'.
5361
5362 * image.c (XPutPixel): Remove unused variable `height'.
5363
5364 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5365
5366 * unexw32.c (get_section_info): Remove unused variable `section'.
5367
5368 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5369 (system_process_attributes): Remove unused variable `sess'.
5370 (sys_read): Remove unused variable `err'.
5371
5372 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5373 (w32_wnd_proc): Remove unused variable `isdead'.
5374 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5375 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5376 (x_create_tip_frame): Remove unused variable `tem'.
5377
5378 * w32inevt.c (w32_console_read_socket):
5379 Remove unused variable `no_events'.
5380
5381 * w32term.c (x_draw_composite_glyph_string_foreground):
5382 Remove unused variable `width'.
5383
1149507c
JB
53842011-03-24 Juanma Barranquero <lekktu@gmail.com>
5385
5386 * w32term.c (x_set_glyph_string_clipping):
5387 Don't pass uninitialized region to CombineRgn.
5388
9c88f339
JB
53892011-03-23 Juanma Barranquero <lekktu@gmail.com>
5390
5391 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5392 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5393 (Fx_close_connection): Remove unused variable `i'.
5394
5395 * w32font.c (w32font_draw): Return number of glyphs.
5396 (w32font_open_internal): Remove unused variable `i'.
5397 (w32font_driver): Add missing initializer.
5398
5399 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5400 (fill_in_menu): Remove unused variable `items_added'.
5401
5402 * w32term.c (last_mouse_press_frame): Remove static global variable.
5403 (w32_clip_to_row): Remove unused variable `f'.
5404 (x_delete_terminal): Remove unused variable `i'.
5405
5406 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5407 (NOTHING): Remove unused static global variable.
5408 (uniscribe_check_otf): Remove unused variable `table'.
5409 (uniscribe_font_driver): Add missing initializers.
5410
dee091a3
JD
54112011-03-23 Julien Danjou <julien@danjou.info>
5412
5413 * term.c (Fsuspend_tty, Fresume_tty):
5414 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5415 * window.c (temp_output_buffer_show):
5416 * insdel.c (signal_before_change):
5417 * frame.c (Fhandle_switch_frame):
5418 * fileio.c (Fdo_auto_save):
5419 * emacs.c (Fkill_emacs):
5420 * editfns.c (save_excursion_restore):
5421 * cmds.c (internal_self_insert):
5422 * callint.c (Fcall_interactively):
5423 * buffer.c (Fkill_all_local_variables):
5424 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5425 Use Frun_hooks.
0f4a96b5 5426 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5427 unconditionnaly since it does the check itself.
5428
2c520ab5 54292011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5430
c9c49752
PE
5431 Fix more problems found by GCC 4.5.2's static checks.
5432
8abc3f12
PE
5433 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5434 the first time through the loop, since we know p0 < p1 then.
5435 This also avoids a gcc -Wstrict-overflow warning.
5436
a2d26660
PE
5437 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5438 leading to a memory leak, possible in functions like
5439 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5440 of objects (Bug#8318).
a2d26660 5441
916c72e9
PE
5442 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5443 that could (at least in theory) be that large.
5444
19ab8a18
PE
5445 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5446 This is less likely to overflow, and avoids undefined behavior if
5447 overflow does occur. All callers changed. Use strtoul to scan
5448 for the unsigned long integer.
b7cbbd6f
PE
5449 (pint2hrstr): Simplify and tune code slightly.
5450 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5451
f0641eff
PE
5452 * scroll.c (do_scrolling): Work around GCC bug 48228.
5453 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5454
7f650bb9
PE
5455 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5456 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5457 (validate_x_resource_name): Simplify count usage.
5458 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5459
37dd57d1
PE
5460 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5461 fail (Bug#8306).
81e56e61 5462
699979fc 5463 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5464
401bf9b4
PE
5465 * process.c (Fmake_network_process): Use socklen_t, not int,
5466 where POSIX says socklen_t is required in portable programs.
5467 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5468 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5469 (Fmake_network_process, server_accept_connection):
5470 (wait_reading_process_output, read_process_output):
5471 Likewise.
5472
b93aacde
PE
5473 * process.c: Rename or move locals to avoid shadowing.
5474 (list_processes_1, Fmake_network_process):
5475 (read_process_output_error_handler, exec_sentinel_error_handler):
5476 Rename or move locals.
4dc343ee 5477 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5478 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5479 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5480 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5481 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5482
af8a867c 5483 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5484 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5485 Include tparam.h instead, since it declares them.
af8a867c
PE
5486 * cm.h (PC): Remove extern decl; tparam.h now does this.
5487 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5488 * terminfo.c: Include tparam.h, to check interfaces.
5489 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5490 (tparam): Adjust signature to match interface in tparam.h;
5491 this removes some undefined behavior. Check that outstring and len
5492 are zero, which they always are with Emacs.
5493 * tparam.h (PC, BC, UP): New extern decls.
5494
0248044d 5495 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5496 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5497
8ff096c1 5498 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5499 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5500 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5501 (ftfont_list): Remove unused local.
49eaafba
PE
5502 (get_adstyle_property, ftfont_pattern_entity):
5503 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5504 Rename locals to avoid shadowing.
8ff096c1 5505
e2be39f6
PE
5506 * xfont.c (xfont_list_family): Mark var as initialized.
5507
c9735e30
PE
5508 * xml.c (make_dom): Now static.
5509
8f5201ae
PE
5510 * composite.c (composition_compute_stop_pos): Rename local to
5511 avoid shadowing.
b246f932
PE
5512 (composition_reseat_it): Remove unused locals.
5513 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5514 (composition_update_it): Mark var as initialized.
11b61122
PE
5515 (find_automatic_composition): Mark vars as initialized,
5516 with a FIXME (Bug#8290).
8f5201ae 5517
760fbc2c
PE
5518 character.h: Rename locals to avoid shadowing.
5519 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5520 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5521 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5522 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5523 to avoid shadowing.
5524
ff08eb85
PE
5525 * textprop.c (property_change_between_p): Remove; unused.
5526
fc7bf025
PE
5527 * intervals.c (interval_start_pos): Now static.
5528
235d7abc
PE
5529 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5530
44f230aa
SM
5531 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5532 Rename locals to avoid shadowing.
3e7d6594 5533
50060332
PE
5534 * sound.c (wav_play, au_play, Fplay_sound_internal):
5535 Fix pointer signedness.
d01f234b 5536 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5537 (wav_play): Initialize a variable to 0, to prevent undefined
5538 behavior (Bug#8278).
50060332 5539
c4fc4e30
PE
5540 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5541
918436ed
PE
5542 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5543
c939f91b
PE
5544 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5545 clobbering (Bug#8298).
b9c7f648
PE
5546 * sysdep.c (sys_subshell): Likewise.
5547 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5548
6bd8c144
PE
5549 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5550 This should get cleaned up, so that child_setup has the
5551 same signature on all platforms.
5552
7710357c 5553 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5554 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5555
c59da222
CY
55562011-03-22 Chong Yidong <cyd@stupidchicken.com>
5557
5558 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5559 not to be necessary, and produces flickering.
5560
66b87493
GM
55612011-03-20 Glenn Morris <rgm@gnu.org>
5562
5563 * config.in: Remove file.
5564
45b6f6d5
JB
55652011-03-20 Juanma Barranquero <lekktu@gmail.com>
5566
5567 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5568 are now in src/globals.h.
5569 (syms_of_minibuf): Remove spurious & from previous change.
5570
3ec03f7e
LL
55712011-03-20 Leo <sdl.web@gmail.com>
5572
5573 * minibuf.c (completing-read-function): New variable.
5574 (completing-read-default): Rename from completing-read.
5575 (completing-read): Call completing-read-function.
5576
b14e3e21
CY
55772011-03-19 Juanma Barranquero <lekktu@gmail.com>
5578
5579 * xfaces.c (Fx_load_color_file):
5580 Read color file from absolute filename (bug#8250).
5581
f2b726e6
JB
55822011-03-19 Juanma Barranquero <lekktu@gmail.com>
5583
5584 * makefile.w32-in: Update dependencies.
5585
09f6ff02
EZ
55862011-03-17 Eli Zaretskii <eliz@gnu.org>
5587
5588 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5589
29a6015a
PE
55902011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5591
a3a6c54e
PE
5592 Fix more problems found by GCC 4.5.2's static checks.
5593
b766f867
PE
5594 * process.c (make_serial_process_unwind, send_process_trap):
5595 (sigchld_handler): Now static.
5596
be02381c
PE
5597 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5598 That way, the code declares only the vars that it needs.
5599 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5600 * s/cygwin.h (PTY_ITERATION): Likewise.
5601 * s/darwin.h (PTY_ITERATION): Likewise.
5602 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5603
57048744
PE
5604 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5605 * process.c (allocate_pty): Don't declare stb unless it's needed.
5606
7914961c 5607 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5608 (CONSTANTLIM): Remove; unused.
5609 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5610 Define only if needed.
7914961c 5611
b3967b18
PE
5612 * unexelf.c (unexec): Name an expression,
5613 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5614 Use a different way to cause a compilation error if anyone uses
5615 n rather than nn, a way that does not involve shadowing.
73366a00 5616 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5617
29a6015a
PE
5618 * deps.mk (unexalpha.o): Remove; unused.
5619
43cfc33e 5620 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5621 * unexec.h: New file.
ce701a33
PE
5622 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5623 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5624 Depend on unexec.h.
5625 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5626 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5627 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5628 Change as necessary to match prototype in unexec.h.
ce701a33 5629
01f44d5a
PE
5630 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5631 shadowing.
4f63c6bb 5632 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5633
a6670b0b
PE
5634 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5635 Rename locals to avoid shadowing.
5636
cef2010d 5637 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5638 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5639
d4d7173a
PE
5640 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5641
f08b802a
PE
5642 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5643 warning when compiling print.c.
5644
3ddb0639
PE
5645 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5646 instead of using an uninitialized var.
5ad03b97 5647 (font_sort_entities): Mark var as initialized.
3ddb0639 5648
170a2692
PE
5649 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5650
e663c700
PE
5651 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5652 pointers to constants.
89bc529a 5653 (font_parse_fcname): Remove unused vars.
7b81e2d0 5654 (font_delete_unmatched): Now static.
ea838e10 5655 (font_get_spec): Remove; unused.
13a547c6
PE
5656 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5657 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5658 Rename or move locals to avoid shadowing.
e663c700 5659
2a80c887 5660 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5661 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5662
1384fa33 5663 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5664 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5665
8b2c52e9
PE
5666 * alloc.c (mark_backtrace): Move decl from here ...
5667 * lisp.h: ... to here, so that it can be checked.
5668
475545b5 5669 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5670 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5671 (lisp_indirect_variable): Name an expression,
5672 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5673 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5674
b1349114 5675 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5676 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5677 Use const pointer when appropriate.
b1349114 5678
a2928364
PE
5679 * lisp.h (get_system_name, get_operating_system_release):
5680 Move decls here, to check interfaces.
5681 * process.c (get_operating_system_release): Move decl to lisp.h.
5682 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5683 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5684 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5685 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5686 (Fformat_time_string, Fencode_time, Finsert_char):
5687 (Ftranslate_region_internal, Fformat):
5688 Rename or remove local vars to avoid shadowing.
9710023e 5689 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5690
a415e694
PE
5691 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5692 avoid shadowing.
5693
8ef4622d
PE
5694 * lisp.h (eassert): Check that the argument compiles, even if
5695 ENABLE_CHECKING is not defined.
5696
946f9a5b
PE
5697 * data.c (Findirect_variable): Name an expression, to avoid
5698 gcc -Wbad-function-cast warning.
112396d6 5699 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5700 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5701 (Fmake_variable_buffer_local, Fmake_local_variable):
5702 Mark variables as initialized.
52746918 5703 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5704
e5aab7e7 5705 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5706 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5707 Rename locals to avoid shadowing.
dff45157
PE
5708 (mark_stack): Move local variables into the #ifdef region where
5709 they're used.
7bc26fdb
PE
5710 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5711 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5712 needed otherwise.
5713 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5714 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5715 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5716
e5aab7e7
PE
5717 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5718 avoids undefined behavior in theory.
5719
4da60324
PE
5720 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5721
88043301
PE
5722 Use functions, not macros, for up- and down-casing (Bug#8254).
5723 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5724 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5725 to use the following functions instead of these macros.
5726 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5727 EMACS_INT, since callers assume the returned value fits in int.
5728 (upcase1): Likewise, for UPCASE_TABLE.
5729 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5730 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5731 the race-condition problem in the old DOWNCASE.
88043301 5732
19ed5445
PE
5733 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5734 Rename locals to avoid shadowing.
5735 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5736 (regex_compile, re_search_2, re_match_2_internal):
5737 Remove unused local vars.
952db0d7
PE
5738 (FREE_VAR): Rewrite so as not to use empty "else",
5739 which gcc can warn about.
da053e48 5740 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5741 (RETALLOC_IF): Define only if needed.
5742 (WORDCHAR_P): Likewise. This one is never needed, but is used
5743 only in a comment talking about a compiler bug, so put inside
5744 the #if 0 of that comment.
5745 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5746 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5747 Remove; unused.
19ed5445 5748
1f3561e4 5749 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5750 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5751 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5752
ded6f8f7
PE
5753 * search.c (simple_search): Remove unused var.
5754
dbd37a95
PE
5755 * dired.c (compile_pattern): Move decl from here ...
5756 * lisp.h: ... to here, so that it can be checked.
5757 (struct re_registers): New forward decl.
5758
7e47afad
PE
5759 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5760
85f24f61
PE
5761 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5762 All uses changed.
5763 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5764 Rename locals to avoid shadowing.
5671df8f 5765 (Fvertical_motion): Mark locals as initialized.
85f24f61 5766
181aa2be 5767 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5768 (casify_region): Mark local as initialized.
181aa2be 5769
930d429c
PE
5770 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5771
7082eac6
PE
5772 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5773 New macros, so that the caller can use some names other than
5774 gcpro1, gcpro2, etc.
5775 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5776 of the new macros.
5777 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5778 argument, for consistency with GCPRO2_VAR, etc: it is now the
5779 prefix of the variable, not the variable itself. All uses
5780 changed.
38b2c076
PE
5781 * dired.c (directory_files_internal, file_name_completion):
5782 Rename locals to avoid shadowing.
5783
15206ed9
PE
5784 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5785 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5786 dired.c's scmp function, had undefined behavior.
5787 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5788 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5789 * buffer.h: ... to here, because these macros use current_buffer,
5790 and the new implementation with inline functions needs to have
5791 current_buffer in scope now, rather than later when the macros
5792 are used.
5793 (downcase, upcase1): New static inline functions.
5794 (DOWNCASE, UPCASE1): Reimplement using these functions.
5795 This avoids undefined behavior in expressions like
5796 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5797 from race conditions in accessing the global variables
5798 case_temp1 and case_temp2.
5799 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5800 * lisp.h (case_temp1, case_temp2): Remove their decls.
5801 * character.h (ASCII_CHAR_P): Move from here ...
5802 * lisp.h: ... to here, so that the inline functions mentioned
5803 above can use them.
5804
4a6bea26
PE
5805 * dired.c (directory_files_internal_unwind): Now static.
5806
f14b7e14
PE
5807 * fileio.c (file_name_as_directory, directory_file_name):
5808 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5809 Now static.
2893f146
PE
5810 (file_name_as_directory): Use const pointers when appropriate.
5811 (Fexpand_file_name): Likewise. In particular, newdir might
5812 point at constant storage, so make it a const pointer.
fd4ead52 5813 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5814 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5815 signedness issues.
f839df0c
PE
5816 (Fset_file_times, Finsert_file_contents, auto_save_error):
5817 Rename locals to avoid shadowing.
f14b7e14 5818
5716756e 5819 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5820 (Ftry_completion, Fall_completions): Rename or remove locals
5821 to avoid shadowing.
5716756e 5822
b4c3046a
PE
5823 * marker.c (bytepos_to_charpos): Remove; unused.
5824
b45db522
PE
5825 * lisp.h (verify_bytepos, count_markers): New decls,
5826 so that gcc does not warn that these functions aren't declared.
5827
85876d07
PE
5828 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5829 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5830 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5831 (copy_text): Remove unused local var.
85876d07 5832
03d78a21 5833 * filelock.c (within_one_second): Now static.
b3dd38ab 5834 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5835
5df8f01b
PE
5836 * buffer.c (fix_overlays_before): Mark locals as initialized.
5837 (fix_start_end_in_overlays): Likewise. This function should be
5838 simplified by using pointers-to-pointers, but that's a different
5839 matter.
b1d876f1 5840 (switch_to_buffer_1): Now static.
8f54f30a
PE
5841 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5842 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5843
a70072c9 5844 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5845 Fix pointer signedness issue.
edced198
PE
5846 (sys_subshell): Mark local as volatile if checking for lint,
5847 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5848 (MAXPATHLEN): Define only if needed.
a70072c9 5849
a0977c44
PE
5850 * process.c (serial_open, serial_configure): Move decls from here ...
5851 * systty.h: ... to here, so that they can be checked.
5852
a884fdcc
PE
5853 * fns.c (get_random, seed_random): Move extern decls from here ...
5854 * lisp.h: ... to here, so that they can be checked.
5855
604efe86 5856 * sysdep.c (reset_io): Now static.
b8950c94 5857 (wait_for_termination_signal): Remove; unused.
604efe86 5858
38fc62d9
PE
5859 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5860 (copy_keymap_item, append_key, push_text_char_description):
5861 Now static.
1004a21a 5862 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5863 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5864 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5865 (describe_map_tree):
5866 Rename locals to avoid shadowing.
38fc62d9 5867
2f2650da
PE
5868 * keyboard.c: Declare functions static if they are not used elsewhere.
5869 (echo_char, echo_dash, cmd_error, top_level_2):
5870 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5871 (read_char, kbd_buffer_get_event, make_lispy_position):
5872 (make_lispy_event, make_lispy_movement, apply_modifiers):
5873 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5874 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5875 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5876 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5877 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5878
a053e86c 5879 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5880 (mark_kboards): Move decl here ...
5881 * alloc.c (mark_kboards): ... from here.
a053e86c 5882
4752793e
PE
5883 * lisp.h (force_auto_save_soon): New decl.
5884
74f10ca7 5885 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5886 (DEFINE_DUMMY_FUNCTION): New macro.
5887 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5888 Use it.
c03cd23f
PE
5889 (main): Add casts to avoid warnings
5890 if GCC considers string literals to be constants.
74f10ca7 5891
022e70d4
PE
5892 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5893
59d6fe83
PE
5894 * dbusbind.c: Pointer signedness fixes.
5895 (xd_signature, xd_append_arg, xd_initialize):
5896 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5897 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5898 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5899 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5900
78320123
PE
5901 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5902 if GCC considers string literals to be constants.
49cebcca 5903 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5904
35ac2a97
SM
59052011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5906
fb103ca9
SM
5907 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5908 (print_preprocess, print_object): New macro to fix last change.
5909
35ac2a97
SM
5910 * print.c (print_preprocess): Don't forget font objects.
5911
62973b41
JB
59122011-03-16 Juanma Barranquero <lekktu@gmail.com>
5913
5914 * emacs.c (USAGE3): Doc fixes.
5915
0e48bb22
AS
59162011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5917
5918 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5919 structure.
5920
7684e57b
JB
59212011-03-14 Juanma Barranquero <lekktu@gmail.com>
5922
5923 * lisp.h (VWindow_system, Qfile_name_history):
5924 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5925 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5926 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5927
5928 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5929 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5930
5931 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5932 * w32console.c (detect_input_pending, read_input_pending)
5933 (encode_terminal_code):
5934 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5935 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5936 (w32_system_caret_y, Qfile_name_history):
5937 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5938 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5939 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5940 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5941 * w32proc.c (Qlocal, report_file_error):
5942 * w32term.c (Vwindow_system, updating_frame):
5943 * w32uniscribe.c (initialized, uniscribe_font_driver):
5944 Remove unneeded extern declarations.
5945
2aa46d6c
CY
59462011-03-14 Chong Yidong <cyd@stupidchicken.com>
5947
c96bbc66 5948 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5949
cffc6f3b
CY
59502011-03-13 Chong Yidong <cyd@stupidchicken.com>
5951
5952 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5953 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5954 These macros can no longer be used for assignment.
5955
44f230aa
SM
5956 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5957 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5958 (record_buffer_markers, fetch_buffer_markers): New functions for
5959 recording and fetching special buffer markers.
5960 (set_buffer_internal_1, set_buffer_temp): Use them.
5961
5962 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5963
5964 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5965
5966 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5967 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5968
5969 * xdisp.c (hscroll_window_tree):
5970 (reconsider_clip_changes): Use PT instead of BUF_PT.
5971
d251f04b
EZ
59722011-03-13 Eli Zaretskii <eliz@gnu.org>
5973
5974 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5975 $(EMACS_ROOT)/lib/intprops.h.
5976
f0c77cd1
PE
59772011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5978
3eca4629
PE
5979 Fix more problems found by GCC 4.5.2's static checks.
5980
7c86ee98
PE
5981 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5982 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5983 (xg_free_frame_widgets): Make it clear that a local variable is
5984 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5985 (gdk_window_get_screen): Make it clear that this macro is needed
5986 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5987 (int_gtk_range_get_value): New function, which avoids a diagnostic
5988 from gcc -Wbad-function-cast.
5989 (xg_set_toolkit_scroll_bar_thumb): Use it.
5990 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5991 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5992 (get_utf8_string, xg_get_file_with_chooser):
5993 Rename locals to avoid shadowing.
5994 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5995
41729b81
PE
5996 * xgselect.c (xg_select): Remove unused var.
5997
f0c77cd1
PE
5998 * image.c (four_corners_best): Mark locals as initialized.
5999 (gif_load): Initialize transparent_p to zero (Bug#8238).
6000 Mark another local as initialized.
ec6cf4c6 6001 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6002
ce0ad53d 6003 * image.c (clear_image_cache): Now static.
d5d5a617 6004 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6005 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6006 (x_edge_detection): Remove unnecessary cast that
6007 gcc -Wbad-function-cast diagnoses.
2037898d 6008 (gif_load): Fix pointer signedness.
6ae141d6
PE
6009 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6010 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6011
33383987 60122011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6013
d32df629
PE
6014 Improve quality of tests for time stamp overflow.
6015 For example, without this patch (encode-time 0 0 0 1 1
6016 1152921504606846976) returns the obviously-bogus value (-948597
6017 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6018 reports time overflow. See
6019 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6020 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6021 * editfns.c: Include limits.h and intprops.h.
6022 (TIME_T_MIN, TIME_T_MAX): New macros.
6023 (time_overflow): Move earlier, to before first use.
6024 (hi_time, lo_time): New functions, for an accurate test for
6025 out-of-range times.
6026 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6027 (Fget_internal_run_time): Don't assume time_t fits in int.
6028 (make_time): Use list2 instead of Fcons twice.
6029 (Fdecode_time): More accurate test for out-of-range times.
6030 (check_tm_member): New function.
6031 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6032 (lisp_time_argument): Don't rely on undefined left-shift and
6033 right-shift behavior when checking for time stamp overflow.
8be6f318 6034
fe31d94c
PE
6035 * editfns.c (time_overflow): New function, refactoring common code.
6036 (Fformat_time_string, Fdecode_time, Fencode_time):
6037 (Fcurrent_time_string): Use it.
6038
8be6f318
PE
6039 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6040 * dired.c (make_time): Move to ...
6041 * editfns.c (make_time): ... here.
6042 * systime.h: Note the move.
6043
09d9db2c 60442011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6045
126bc0dc
YM
6046 * fringe.c (update_window_fringes): Remove unused variables.
6047
c47cbdfd
YM
6048 * unexmacosx.c (copy_data_segment): Also copy __got section.
6049 (Bug#8223)
6050
7ac80be9
EZ
60512011-03-12 Eli Zaretskii <eliz@gnu.org>
6052
c96bbc66 6053 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6054 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6055 Constify `char *' arguments and their references according to
6056 prototypes in tparam.h.
6057
ecb0f94d 6058 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6059
7ac80be9
EZ
6060 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6061 Adapt all references accordingly.
6062
6063 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6064
ef1fd07e
TT
60652011-03-11 Tom Tromey <tromey@redhat.com>
6066
6067 * buffer.c (syms_of_buffer): Remove obsolete comment.
6068
7ef4b50c
EZ
60692011-03-11 Eli Zaretskii <eliz@gnu.org>
6070
6071 * termhooks.h (encode_terminal_code): Declare prototype.
6072
6073 * msdos.c (encode_terminal_code): Don't declare prototype.
6074
6075 * term.c (encode_terminal_code): Now external again, used by
6076 w32console.c and msdos.c.
6077
44f230aa
SM
6078 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6079 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6080
4b1ec863 60812011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6082
1714f52b 6083 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6084
4b1ec863
PE
6085 * fringe.c (update_window_fringes): Mark locals as initialized
6086 (Bug#8227).
6087 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6088
524c7aa6
PE
6089 * alloc.c (mark_fringe_data): Move decl from here ...
6090 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6091 to check its interface.
6092 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6093
a5c0af81 6094 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6095 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6096 (fontset_font): Mark local as initialized.
a9a06e0b 6097 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6098
b4716021
PE
6099 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6100
811e9bac 6101 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6102 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6103 (x_own_selection, Fx_disown_selection_internal): Rename locals
6104 to avoid shadowing.
6105 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6106
7e3ab302
PE
6107 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6108 so that the caller can use some name other than gcpro1.
6109 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6110 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6111 (Fx_backspace_delete_keys_p):
6112 Use them to avoid shadowing, and rename vars to avoid shadowing.
6113 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6114 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6115 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6116 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6117 Remove unused locals.
7e3ab302
PE
6118 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6119 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6120 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6121 macros.
f78faa98 6122
e2b13473
PE
6123 * xterm.h (x_mouse_leave): New decl.
6124
77f23912
PE
6125 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6126 Remove unused functions.
cdf4ba58
PE
6127 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6128 (x_calc_absolute_position): Now static.
7411c686 6129 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6130 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6131 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6132 unless they are used.
38d0b34a
PE
6133 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6134 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6135 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6136 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6137 (x_error_catcher, x_connection_closed, x_error_handler):
6138 (x_error_quitter, xembed_send_message, x_iconify_frame):
6139 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6140 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6141 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6142
44f230aa
SM
6143 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6144 Rename or move locals to avoid shadowing.
6b463e58 6145 (tty_defined_color, merge_face_heights): Now static.
5967d051 6146 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6147 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6148 does not deduce is never used uninitialized.
73719eba
PE
6149 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6150 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6151
426994c3 6152 * terminal.c (store_terminal_param): Now static.
5489860b 6153
032f1620 6154 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6155 (set_frame_menubar): Remove unused local.
d4323972 6156 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6157 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6158 since they might point to immutable storage.
281585b0
PE
6159 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6160 since it's unused otherwise.
032f1620 6161
367c19e5 6162 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6163 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6164 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6165 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6166 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6167 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6168 does not deduce are never used uninitialized.
70739cbe 6169
07b48fa9
PE
6170 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6171
8868a238 6172 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6173 * window.c (window_loop, size_window):
6174 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6175
7e5cf297 6176 * window.c (display_buffer): Now static.
d6550a9f
PE
6177 (size_window): Mark variables that gcc -Wuninitialized
6178 does not deduce are never used uninitialized.
a586633d
PE
6179 * window.h (check_all_windows): New decl, to forestall
6180 gcc -Wmissing-prototypes diagnostic.
5b555da1 6181 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6182
f6095868
PE
6183 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6184 shadowing.
6185 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6186 Include <limits.h>.
6187 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6188 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6189 (load_charset_map): Mark variables that gcc -Wuninitialized
6190 does not deduce are never used uninitialized.
53df7c11 6191 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6192
f38b440c
PE
6193 * coding.c (coding_set_source, coding_set_destination):
6194 Use "else { /* comment */ }" rather than "else /* comment */;"
6195 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6196 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6197 a block, when the outer 'i' will do.
6198 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6199 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6201 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6202 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6203 Rename locals to avoid shadowing.
6204 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6205 * coding.c (emacs_mule_char, encode_invocation_designation):
6206 Now static, since they're not used elsewhere.
413bb2db 6207 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6208 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6209 (decode_coding_emacs_mule): Mark variables that gcc
6210 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6211 (detect_coding_iso_2022): Initialize a local variable that might
6212 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6213 this initialization is needed. (Bug#8211)
5f58e762
PE
6214 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6215 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6216 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6217 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6218 Remove unused macros.
f38b440c 6219
232b38b9 6220 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6221 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6222 * character.c (string_count_byte8): Likewise.
232b38b9 6223
fb90da1b
PE
6224 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6225 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6226
fb93dbc2
PE
6227 * chartab.c (copy_sub_char_table): Now static, since it's not used
6228 elsewhere.
5c156ace
PE
6229 (sub_char_table_ref_and_range, char_table_ref_and_range):
6230 Rename locals to avoid shadowing.
bbcd0949 6231 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6232
7d3b3862 6233 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6234 (BIDI_BOB): Remove unused macro.
7d3b3862 6235
6be7d3da
PE
6236 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6237 deduce are never used uninitialized.
c2ed9c8b 6238 * term.c (encode_terminal_code): Likewise.
6be7d3da 6239
75f8807f 6240 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6241
50938595
PE
6242 * tparam.h: New file.
6243 * term.c, tparam.h: Include it.
6244 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6245 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6246 Move these decls to tparam.h, and make them agree with what
6247 is actually in tparam.c. The previous trick of using incompatible
6248 decls in different modules does not conform to the C standard.
6249 All callers of tparam changed to use tparam's actual API.
6250 * tparam.c (tparam1, tparam, tgoto):
6251 Use const pointers where appropriate.
6252
fbceeba2
PE
6253 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6254 * cm.h (struct cm): Likewise.
6255 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6256 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6257 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6258 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6259 (turn_on_face, init_tty): Likewise.
6260 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6261
7f3f1250
PE
6262 * term.c (term_mouse_position): Rename local to avoid shadowing.
6263
e6ca6543
PE
6264 * alloc.c (mark_ttys): Move decl from here ...
6265 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6266
c40f8d15
AS
62672011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6268
6269 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6270
cfe0661d
JB
62712011-03-09 Juanma Barranquero <lekktu@gmail.com>
6272
6273 * search.c (compile_pattern_1): Remove argument regp, unused since
6274 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6275 (compile_pattern): Don't pass it.
6276
0afb4571
J
62772011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6278
6279 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6280 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6281 for ! HAVE_GTK3.
6282 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6283
6284 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6285
6286 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6287 gdk_window_get_screen, gdk_window_get_geometry,
6288 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6289 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6290 (xg_get_pixbuf_from_pixmap): New function.
6291 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6292 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6293 Call xg_get_pixbuf_from_pixmap instead of
6294 gdk_pixbuf_get_from_drawable.
6295 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6296 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6297 (xg_check_special_colors): Use GtkStyleContext and its functions
6298 for HAVE_GTK3.
6299 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6300 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6301 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6302 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6303 Call gtk_widget_get_preferred_size.
0afb4571
J
6304 (xg_frame_resized): gdk_window_get_geometry only takes 5
6305 parameters.
44f230aa
SM
6306 (xg_win_to_widget, xg_event_is_for_menubar):
6307 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6308 (xg_set_widget_bg): New function.
6309 (delete_cb): New function.
895009e1 6310 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6311 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6312 (xg_set_background_color): Call xg_set_widget_bg.
6313 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6314 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6315 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6316 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6317 if ! HAVE_GTK3.
6318 (update_frame_tool_bar): Call gtk_widget_hide.
6319 (xg_initialize): Use GDK_KEY_g.
6320
6321 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6322 if ! HAVE_GTK3
6323 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6324
6325 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6326 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6327 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6328
1c2cc4ef
JB
63292011-03-08 Juanma Barranquero <lekktu@gmail.com>
6330
6331 * w32xfns.c (select_palette): Check success of RealizePalette against
6332 GDI_ERROR, not zero.
6333
33383987 6334See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6335
6336;; Local Variables:
6337;; coding: utf-8
aac0c6e3
MR
6338;; End:
6339
33383987 6340 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6341
6342 This file is part of GNU Emacs.
6343
6344 GNU Emacs is free software: you can redistribute it and/or modify
6345 it under the terms of the GNU General Public License as published by
6346 the Free Software Foundation, either version 3 of the License, or
6347 (at your option) any later version.
6348
6349 GNU Emacs is distributed in the hope that it will be useful,
6350 but WITHOUT ANY WARRANTY; without even the implied warranty of
6351 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6352 GNU General Public License for more details.
6353
6354 You should have received a copy of the GNU General Public License
6355 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.