* s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
efc736d3
PE
3 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4
4e2fe2e6
PE
5 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6
f97334a2
PE
7 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8
4e75f29d
PE
9 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10 Define only if needed.
11
90efadd1
PE
12 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 15
3c647824
PE
16 * dispextern.h (struct redisplay_interface): Rename param
17 to avoid shadowing.
e264f262 18 * termhooks.h (struct terminal): Likewise.
761383f4 19 * xterm.c (xembed_send_message): Likewise.
3c647824 20
b58c5c4a
PE
21 * insdel.c (make_gap_smaller): Define only if
22 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
23
cad59032
PE
24 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
25 it.
26
c339dc2e
PE
27 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
28 so that we aren't warned about unused symbols.
29
91a3e27b
PE
30 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
31
94578f9c
PE
32 * xdisp.c (x_produce_glyphs): Avoid possibly-uninitialized
33 var (Bug#8512).
7a3fb125 34
8ffc96f5
PE
35 * xfns.c (x_real_positions): Mark locals as initialized.
36
eef9bc79
PE
37 * xmenu.c (xmenu_show): Don't use uninitialized vars.
38
098db9dd
PE
39 * xterm.c: Fix problems found by static analysis with other toolkits.
40 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
41 (x_dispatch_event): Declare static if USE_GTK, and
42 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 43 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 44 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
45 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
46 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
47
eb18f6cc
PE
48 * xmenu.c (menu_help_callback): Pointer type fixes.
49 Use const pointers when pointing at readonly data. Avoid pointer
50 signedness clashes.
51 (FALSE): Remove unused macro.
52 (update_frame_menubar): Remove unused decl.
53
1fe72bf8
PE
54 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
55
60d9e1db
PE
56 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
57 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
58 (single_menu_item): Rename local to avoid shadowing.
59
39261c26
PE
60 * keyboard.c (make_lispy_event): Remove unused local var.
61
018c5e19
PE
62 * frame.c, frame.h (x_get_resource_string): Bring this back, but
63 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
64
63d2b86e
PE
65 * bitmaps: Change bitmaps from unsigned char back to the X11
66 compatible char. Avoid the old compiler warnings about
67 out-of-range initializers by using, for example, '\xab' rather
68 than 0xab.
69
aefd87e1
PE
70 * xgselect.c (xgselect_initialize): Check vs interface
71 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
72
bf501fb9
PE
73 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
74
e9829fdf
PE
75 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
76 to read-only memory.
77
1086c095
PE
78 * fns.c (vector): Remove; this old hack is no longer needed.
79
2baccd04 80 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 81 Remove unused var.
dde42981 82 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 83
72391843 84 * xrdb.c (x_load_resources): Omit unused local.
3565b346 85
436c16df 86 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 87 (x_window): Rename locals to avoid shadowing.
dc5ddd85 88 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 89
92bb796d 90 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 91 (x_term_init): Remove local to avoid shadowing.
92bb796d 92
764430a3 93 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
94
95 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
96 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
97
4170f62f 982011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 99
71b41406
PE
100 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
101
9587a89d
PE
102 emacs_write: Accept and return EMACS_INT for sizes.
103 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
104 et seq.
105 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
106 Accept and return EMACS_INT.
107 (emacs_gnutls_write): Return the number of bytes written on
108 partial writes.
109 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
110 (emacs_read, emacs_write): Remove check for negative size, as the
111 Emacs source code has been audited now.
9587a89d
PE
112 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
113 (emacs_read, emacs_write): Use it.
273a5f82
PE
114 * process.c (send_process): Adjust to the new signatures of
115 emacs_write and emacs_gnutls_write. Do not attempt to store
116 a byte offset into an 'int'; it might overflow.
9587a89d 117 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 118
3e047f51
PE
119 * sound.c: Don't assume sizes fit in 'int'.
120 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 121 Return EMACS_INT, not int.
3e047f51 122 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
123 Accept EMACS_INT, not int.
124 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
125 record read return values.
126
cc39a9db
BK
1272011-04-15 Ben Key <bkey76@gmail.com>
128
129 * keyboard.c (Qundefined): Don't declare static since it is
130 used in nsfns.m.
131 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
132 declare static since they are used in nsfont.m.
133
6c60eb9f
SM
1342011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
135
136 * process.c (Qprocessp): Don't declare static.
137 * lisp.h (Qprocessp): Declare again.
138
7990b61a
JB
1392011-04-15 Juanma Barranquero <lekktu@gmail.com>
140
141 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
142
5d4cb038
PE
1432011-04-14 Paul Eggert <eggert@cs.ucla.edu>
144
8bd7b830 145 Improve C-level modularity by making more things 'static'.
cd64ea1d 146
e3b27b31
PE
147 Don't publish debugger-only interfaces to other modules.
148 * lisp.h (safe_debug_print, debug_output_compilation_hack):
149 (verify_bytepos, count_markers): Move decls to the only modules
150 that need them.
151 * region-cache.h (pp_cache): Likewise.
152 * window.h (check_all_windows): Likewise.
153 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
154
5d4cb038
PE
155 * sysdep.c (croak): Now static, if
156 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
157 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
158
159 * alloc.c (refill_memory_reserve): Now static if
160 !defined REL_ALLOC || defined SYSTEM_MALLOC.
161 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 162
e87b6180
PE
163 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
164 Define only if USE_LUCID.
165
ac64929e
PE
166 * xrdb.c (x_customization_string, x_rm_string): Now static.
167
6f37259d
PE
168 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
169 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
170
1683e3ab
PE
171 * xdisp.c (draw_row_with_mouse_face): Now static.
172 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
173
de9c2632
PE
174 * window.h (check_all_windows): Mark externally visible.
175
2b96acb7
PE
176 * window.c (window_deletion_count): Now static.
177
178 * undo.c: Make symbols static if they're not exported.
179 (last_undo_buffer, last_boundary_position, pending_boundary):
180 Now static.
181
50436f33
PE
182 * textprop.c (interval_insert_behind_hooks): Now static.
183 (interval_insert_in_front_hooks): Likewise.
184
64520e5c
PE
185 * term.c: Make symbols static if they're not exported.
186 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
187 (max_frame_lines, tty_set_terminal_modes):
188 (tty_reset_terminal_modes, tty_turn_off_highlight):
189 (get_tty_terminal): Now static.
190 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
191 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 192 HAVE_WINDOW_SYSTEM.
64520e5c
PE
193 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
194 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
195
1fa53021
PE
196 * sysdep.c: Make symbols static if they're not exported.
197 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
198 Now static.
199 (sigprocmask_set, full_mask): Remove; unused.
200 (wait_debugging): Mark as visible.
201 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
202 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
203
d4b43b22
PE
204 * syntax.c (syntax_temp): Define only if !__GNUC__.
205
b7c513d0
PE
206 * sound.c (current_sound_device, current_sound): Now static.
207
989b29ad
PE
208 * search.c (searchbufs, searchbuf_head): Now static.
209
13a55a78
PE
210 * scroll.c (scroll_cost): Remove; unused.
211 * dispextern.h (scroll_cost): Remove decl.
212
de68a1fc
PE
213 * region-cache.h (pp_cache): Mark as externally visible.
214
40ccffa6
PE
215 * process.c: Make symbols static if they're not exported.
216 (process_tick, update_tick, create_process, chan_process):
217 (Vprocess_alist, proc_buffered_char, datagram_access):
218 (fd_callback_data, send_process_frame, process_sent_to): Now static.
219 (deactivate_process): Mark defn as static, as well as decl.
220 * lisp.h (create_process): Remove decl.
221 * process.h (chan_process, Vprocess_alist): Remove decls.
222
ad64fc97
PE
223 * print.c: Make symbols static if they're not exported.
224 (print_depth, new_backquote_output, being_printed, print_buffer):
225 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
226 (print_interval, print_number_index, initial_stderr_stream):
227 Now static.
228 * lisp.h (Fprinc): Remove decl.
229 (debug_output_compilation_hack): Mark as externally visible.
230
adddb265
PE
231 * sysdep.c (croak): Move decl from here to syssignal.h.
232 * syssignal.h (croak): Put it here, so the API can be checked when
233 'croak' is called from dissociate_if_controlling_tty.
234
1717ede2
PE
235 * minibuf.c: Make symbols static if they're not exported.
236 (minibuf_save_list, choose_minibuf_frame): Now static.
237 * lisp.h (choose_minibuf_frame): Remove decl.
238
fa5fb2bc
PE
239 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
240
1e3890d1
PE
241 * lread.c: Make symbols static if they're not exported.
242 (read_objects, initial_obarray, oblookup_last_bucket_number):
243 Now static.
244 (make_symbol): Remove; unused.
245 * lisp.h (initial_obarray, make_symbol): Remove decls.
246
8a1414fa
PE
247 * keyboard.c: Make symbols static if they're not exported.
248 (single_kboard, recent_keys_index, total_keys, recent_keys):
249 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
250 (this_single_command_key_start, echoing, last_auto_save):
251 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
252 (command_loop, echo_now, keyboard_init_hook, help_char_p):
253 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
254 (Vlispy_mouse_stem, double_click_count):
255 Now static.
256 (force_auto_save_soon): Define only if SIGDANGER.
257 (ignore_mouse_drag_p): Now static if
258 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
259 (print_help): Remove; unused.
260 (stop_character, last_timer_event): Mark as externally visible.
261 * keyboard.h (ignore_mouse_drag_p): Declare only if
262 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
263 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
264 * lisp.h (echoing): Remove decl.
265 (force_auto_save_soon): Declare only if SIGDANGER.
266 * xdisp.c (redisplay_window): Simplify code, to make it more
267 obvious that ignore_mouse_drag_p is not accessed if !defined
268 USE_GTK && !defined HAVE_NS.
269
93ea6e8f
PE
270 * intervals.c: Make symbols static if they're not exported.
271 (merge_properties_sticky, merge_interval_right, delete_interval):
272 Now static.
273 * intervals.h (merge_interval_right, delete_interval): Remove decls.
274
77382fcc
PE
275 * insdel.c: Make symbols static if they're not exported.
276 However, leave prepare_to_modify_buffer alone. It's never
277 called from outside this function, but that appears to be a bug.
278 (combine_after_change_list, combine_after_change_buffer):
4889fc82 279 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
280 (adjust_after_replace_noundo): Remove; unused.
281 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 282 (signal_before_change): Remove decls.
77382fcc 283
9306c32e
PE
284 * indent.c (val_compute_motion, val_vmotion): Now static.
285
cd44d2eb
PE
286 * image.c: Make symbols static if they're not exported.
287 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
288 if USE_GTK.
289 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
290 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
291
ad9a7a06
PE
292 * fringe.c (standard_bitmaps): Now static.
293 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
294
81626931
PE
295 * frame.c: Make symbols static if they're not exported.
296 (x_report_frame_params, make_terminal_frame): Now static.
297 (get_frame_param): Now static, unless HAVE_NS.
298 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
299 (x_get_resource_string): Remove; not used.
300 * frame.h (make_terminal_frame, x_report_frame_params):
301 (x_get_resource_string); Remove decls.
302 (x_fullscreen_adjust): Declare only if WINDOWSNT.
303 * lisp.h (get_frame_param): Declare only if HAVE_NS.
304
239f9db9
PE
305 * font.c, fontset.c: Make symbols static if they're not exported.
306 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
307 (FACE_SUITABLE_FOR_CHAR_P): Use it.
308 * font.c (font_close_object): Now static.
309 * font.h (font_close_object): Remove.
310 * fontset.c (FONTSET_OBJLIST): Remove.
311 (free_realized_fontset) #if-0 the body, which does nothing.
312 (face_suitable_for_char_p): #if-0, as it's never called.
313 * fontset.h (face_suitable_for_char_p): Remove decl.
314 * xfaces.c (face_at_string_position): Use
315 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
316 since 0 is always ASCII.
317
dfcf3579
PE
318 * fns.c (weak_hash_tables): Now static.
319
5045092b
PE
320 * fileio.c: Make symbols static if they're not exported.
321 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
322 (Vwrite_region_annotation_buffers): Now static.
323
57a96f5c
PE
324 * eval.c: Make symbols static if they're not exported.
325 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
326 * lisp.h (backtrace_list): Remove decl.
327
35f08c38
PE
328 * emacs.c: Make symbols static if they're not exported.
329 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
330 (fatal_error_code, fatal_error_signal_hook, standard_args):
331 Now static.
332 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
333 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
334 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
335 * lisp.h (fatal_error_signal_hook): Remove decl.
336 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
337
f44bd759
PE
338 * editfns.c: Move a (normally-unused) function to its only use.
339 * editfns.c, lisp.h (get_operating_system_release): Remove.
340 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
341 worth the hassle of breaking this out.
342
b532497d
PE
343 * xterm.c: Make symbols static if they're not exported.
344 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
345 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
346 (x_destroy_window, x_delete_display):
347 Now static.
348 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
349 (x_mouse_leave): Remove; unused.
350 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
351 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
352 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
353 Remove decls.
354 (x_mouse_leave): Declare only if WINDOWSNT.
355 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
356 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
357 USE_X_TOOLKIT.
358
1675728f
PE
359 * ftxfont.c: Make symbols static if they're not exported.
360 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
361 HAVE_FREETYPE.
362 * font.h (ftxfont_driver): Likewise.
363
e4cebfca
PE
364 * xfns.c: Make symbols static if they're not exported.
365 (x_last_font_name, x_display_info_for_name):
366 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
367 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
368 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
369 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
370 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
371 (last_show_tip_args): Now static.
372 (xic_defaut_fontset, xic_create_fontsetname): Define only if
373 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
374 (x_screen_planes): Remove; unused.
375 * dispextern.h (x_screen_planes): Remove decl.
376
5bf46f05
PE
377 * dispnew.c: Make symbols static if they're not exported.
378 * dispextern.h (redraw_garbaged_frames, scrolling):
379 (increment_row_positions): Remove.
380 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
381 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
382 Now static.
383 (redraw_garbaged_frames): Remove; unused.
384
435f4c28
PE
385 * xfaces.c: Make symbols static if they're not exported.
386 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
387 Remove decls.
388 * xterm.h (defined_color): Remove decls.
389 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
390 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
391 (menu_face_changed_default, defined_color, free_realized_face):
392 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
393 (ascii_face_of_lisp_face): Remove; unused.
394
8524aef3
PE
395 * xdisp.c: Make symbols static if they're not exported.
396 * dispextern.h (scratch_glyph_row, window_box_edges):
397 (glyph_to_pixel_coords, set_cursor_from_row):
398 (get_next_display_element, set_iterator_to_next):
399 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
400 (show_mouse_face): Remove decls
401 * frame.h (message_buf_print): Likewise.
402 * lisp.h (pop_message, set_message, check_point_in_composition):
403 Likewise.
404 * xterm.h (set_vertical_scroll_bar): Likewise.
405 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
406 (message_buf_print, scratch_glyph_row, displayed_buffer):
407 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
408 (get_next_display_element, show_mouse_face, window_box_edges):
409 (frame_to_window_pixel_xy, check_point_in_composition):
410 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
411 (glyph_to_pixel_coords): Remove; unused.
412
16390cd2
PE
413 * dired.c (file_name_completion): Now static.
414
415 * dbusbind.c (xd_in_read_queued_messages): Now static.
416
a25f4dfa
PE
417 * lisp.h (circular_list_error, FOREACH): Remove; unused.
418 * data.c (circular_list_error): Remove.
419
14a9c8df
PE
420 * commands.h (last_point_position, last_point_position_buffer):
421 (last_point_position_window): Remove decls.
422 * keyboard.c: Make these variables static.
423
74ab6df5
PE
424 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
425 decls.
426 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
427 (iso_code_class, detect_coding, code_convert_region): Now static.
428 (encode_coding_gap): Remove; unused.
429
38dfbee1
PE
430 * chartab.c (chartab_chars, chartab_bits): Now static.
431
a2cb4e63
PE
432 * charset.h (charset_iso_8859_1): Remove decl.
433 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
434 Now static.
435
127198fd
PE
436 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
437 * ccl.c (Vccl_program_table): Now static.
438 (check_ccl_update): Remove; unused.
439
d85b608f
PE
440 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
441 * category.h: ... from here.
442 * category.c (check_category_table, set_category_set): Now static.
443
31cd66f3
PE
444 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
445 * lisp.h: Remove these decls.
446
c358e587
PE
447 * buffer.c (buffer_count): Remove unused var.
448
e78aecca
PE
449 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
450 so that it's not optimized away.
451 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
452 * dispextern.h (bidi_dump_cached_states): Remove, since it's
453 exported only to the debugger.
454
e192d7d3
PE
455 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
456 * atimer.h (run_all_atimers): Removed; not exported.
457
92470028
PE
458 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
459 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
460 was inaccessible from Lisp.
461 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
462 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
463
244ed907
PE
464 alloc.c: Import and export fewer symbols, and remove unused items.
465 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
466 is defined.
467 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
468 it's not optimized away by whole-program optimization.
469 (message_enable_multibyte, free_misc): Remove.
470 (catchlist, handlerlist, mark_backtrace):
471 Declare only if BYTE_MARK_STACK.
472 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
473 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
474 (message_enable_multibyte): Remove decl.
475 (free_misc, interval_free_list, float_block, float_block_index):
476 (n_float_blocks, float_free_list, cons_block, cons_block_index):
477 (cons_free_list, last_marked_index):
478 Now static.
479 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
480 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
481 (mark_backtrace): Define only if BYTE_MARK_STACK.
482 * xdisp.c (message_enable_multibyte): Now static.
483
955cbe7b
PE
484 Declare Lisp_Object Q* variables to be 'static' if not exproted.
485 This makes it easier for human readers (and static analyzers)
486 to see whether these variables are used from other modules.
487 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
488 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
489 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
490 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
491 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
492 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
493 * xmenu.c, xselect.c:
494 Declare Q* vars static if they are not used in other modules.
495 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
496 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
497 Remove decls of unexported vars.
498 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
499
95c82688
PE
500 * lisp.h (DEFINE_FUNC): Make sname 'static'.
501
16a97296
PE
502 Make Emacs functions such as Fatom 'static' by default.
503 This makes it easier for human readers (and static analyzers)
504 to see whether these functions can be called from other modules.
505 DEFUN now defines a static function. To make the function external
506 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
507 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
508 (Finit_image_library):
16a97296
PE
509 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
510 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
511 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
512 Remove decls, since these functions are now static.
513 (Funintern, Fget_internal_run_time): New decls, since these functions
514 were already external.
95c82688 515
16a97296
PE
516 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
517 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
518 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
519 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
520 * keyboard.c, keymap.c, lread.c:
521 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
522 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
523 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
524 Mark functions with DEFUE instead of DEFUN,
525 if they are used in other modules.
526 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
527 decls for now-static functions.
528 * buffer.h (Fdelete_overlay): Remove decl.
529 * callproc.c (Fgetenv_internal): Mark as internal.
530 * composite.c (Fremove_list_of_text_properties): Remove decl.
531 (Fcomposition_get_gstring): New forward static decl.
532 * composite.h (Fcomposite_get_gstring): Remove decl.
533 * dired.c (Ffile_attributes): New forward static decl.
534 * doc.c (Fdocumntation_property): New forward static decl.
535 * eval.c (Ffetch_bytecode): New forward static decl.
536 (Funintern): Remove extern decl; now in .h file where it belongs.
537 * fileio.c (Fmake_symbolic_link): New forward static decl.
538 * image.c (Finit_image_library): New forward static decl.
539 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
540 * intervals.h (Fprevious_property_change):
541 (Fremove_list_of_text_properties): Remove decls.
542 * keyboard.c (Fthis_command_keys): Remove decl.
543 (Fcommand_execute): New forward static decl.
544 * keymap.c (Flookup_key): New forward static decl.
545 (Fcopy_keymap): Now static.
546 * keymap.h (Flookup_key): Remove decl.
547 * process.c (Fget_process): New forward static decl.
548 (Fprocess_datagram_address): Mark as internal.
549 * syntax.c (Fsyntax_table_p): New forward static decl.
550 (skip_chars): Remove duplicate decl.
551 * textprop.c (Fprevious_property_change): New forward static decl.
552 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
553 Now internal.
554 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
555 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
556
785bbd42
PE
557 * editfns.c (Fformat): Remove unreachable code.
558
8b913b57
AS
5592011-04-14 Andreas Schwab <schwab@linux-m68k.org>
560
561 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
562 change. (Bug#8496)
563
a6744a35
EZ
5642011-04-13 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
567 when at ZV. (Bug#8487)
568
e7974947
AS
5692011-04-12 Andreas Schwab <schwab@linux-m68k.org>
570
baad03f0
AS
571 * charset.c (Fclear_charset_maps): Use xfree instead of free.
572 (Bug#8437)
573 * keyboard.c (parse_tool_bar_item): Likewise.
574 * sound.c (sound_cleanup, alsa_close): Likewise.
575 * termcap.c (tgetent): Likewise.
576 * xfns.c (x_default_font_parameter): Likewise.
577 * xsettings.c (read_and_apply_settings): Likewise.
578
e7974947
AS
579 * alloc.c (overrun_check_malloc, overrun_check_realloc)
580 (overrun_check_free): Protoize.
581
28272684
PE
5822011-04-12 Paul Eggert <eggert@cs.ucla.edu>
583
584 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
585 since callers should never pass a negative size.
586 Change the signature to match that of plain 'read' and 'write'; see
587 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
588 * lisp.h: Update prototypes of emacs_write and emacs_read.
589
11997c76
EZ
5902011-04-11 Eli Zaretskii <eliz@gnu.org>
591
592 * xdisp.c (redisplay_window): Don't try to determine the character
593 position of the scroll margin if the window start point w->startp
e896f03c 594 is outside the buffer's accessible region. (Bug#8468)
11997c76 595
8a2cbd72
EZ
5962011-04-10 Eli Zaretskii <eliz@gnu.org>
597
598 Fix write-region and its subroutines for buffers > 2GB.
599 * fileio.c (a_write, e_write): Modify declaration of arguments and
600 local variables to support buffers larger than 2GB.
601 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
602
603 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
604 argument, local variables, and return value.
605
606 * lisp.h: Update prototypes of emacs_write and emacs_read.
607
608 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
609
4073e537 6102011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 611
1ebfdcb6
PE
612 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
613
b2ded58d
PE
614 Fix more problems found by GCC 4.6.0's static checks.
615
7d66342c
PE
616 * xdisp.c (vmessage): Use a better test for character truncation.
617
bbf47d44
PE
618 * charset.c (load_charset_map): <, not <=, for optimization,
619 and to avoid potential problems with integer overflow.
9248994d 620 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 621 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 622 * editfns.c (Fformat): Likewise.
1e69125e 623 * syntax.c (skip_chars): Likewise.
3befa583 624
e3019616
PE
625 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
626 This also lets GCC 4.6.0 generate slightly better loop code.
627
becfa255
PE
628 * callint.c (Fcall_interactively): <, not <=, for optimization.
629 (Fcall_interactively): Count the number of arguments produced,
630 not the number of arguments given. This is simpler and lets GCC
631 4.6.0 generate slightly better code.
632
dae0cd48
PE
633 * ftfont.c: Distingish more carefully between FcChar8 and char.
634 The previous code passed unsigned char * to a functions like
635 strlen and xstrcasecmp that expect char *, which does not
636 conform to the C standard.
637 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
638 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
639 char * when the C standard requires it.
640
76032d70
PE
641 * keyboard.c (read_char): Remove unused var.
642
eb3f1cc8
PE
643 * eval.c: Port to Windows vsnprintf (Bug#8435).
644 Include <limits.h>.
645 (SIZE_MAX): Define if the headers do not.
646 (verror): Do not give up if vsnprintf returns a negative count.
647 Instead, grow the buffer. This ports to Windows vsnprintf, which
648 does not conform to C99. Problem reported by Eli Zaretskii.
649 Also, simplify the allocation scheme, by avoiding the need for
650 calling realloc, and removing the ALLOCATED variable.
651
70476b54
PE
652 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
653
12020a9e
PE
654 Remove invocations of doprnt, as Emacs now uses vsnprintf.
655 But keep the doprint source code for now, as we might revamp it
656 and use it again (Bug#8435).
ea6c7ae6
PE
657 * lisp.h (doprnt): Remove.
658 * Makefile.in (base_obj): Remove doprnt.o.
659 * deps.mk (doprnt.o): Remove.
660
5fdb398c
PE
661 error: Print 32- and 64-bit integers portably (Bug#8435).
662 Without this change, on typical 64-bit hosts error ("...%d...", N)
663 was used to print both 32- and 64-bit integers N, which relied on
664 undefined behavior.
665 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
666 New macro.
667 * lisp.h (error, verror): Mark as printf-like functions.
668 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
669 Report overflow in size calculations when allocating printf buffer.
670 Do not truncate output string at its first null byte.
671 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
672 Truncate the output at a character boundary, since vsnprintf does not
673 do that.
674 * charset.c (check_iso_charset_parameter): Convert internal
675 character to string before calling 'error', since %c now has the
676 printf meaning.
677 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
678 overflow when computing char to be passed to 'error'. Do not
679 pass Lisp_Object to 'error'; pass the integer instead.
680 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
681 formatted with plain %d.
682
b189fa66
PE
683 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
684
bff87ef0
PE
685 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
686
7e2cac20
PE
687 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
688
ce4d90b5
PE
689 * xterm.c (x_catch_errors): Remove duplicate declaration.
690
266c9547
PE
691 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
692
79c49ad2
PE
693 * xdisp.c, lisp.h (message_nolog): Remove; unused.
694
368f4090
JM
6952011-04-10 Jim Meyering <meyering@redhat.com>
696
697 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
698 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
699 return ssize_t not "int", and use size_t as the buffer length.
700 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
701 * gnutls.h: Update declarations.
702 * process.c (read_process_output): Use ssize_t, to match.
703 (send_process): Likewise.
704
a32d4040
CY
7052011-04-09 Chong Yidong <cyd@stupidchicken.com>
706
707 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
708
8546720e 7092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 710
8546720e
GM
711 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
712 unsigned char, to match FcChar8 type definition.
aac0c6e3 713
8546720e
GM
714 * xterm.c (handle_one_xevent):
715 * xmenu.c (create_and_show_popup_menu):
716 * xselect.c (x_decline_selection_request)
717 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 718
0a2f5c1a 7192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
720
721 Fix some uses of `int' instead of EMACS_INT.
722 * search.c (string_match_1, fast_string_match)
723 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
724 (scan_buffer, find_next_newline_no_quit)
725 (find_before_next_newline, search_command, Freplace_match)
726 (Fmatch_data): Make some `int' variables be EMACS_INT.
727
728 * xdisp.c (display_count_lines): 3rd argument and return value now
729 EMACS_INT. All callers changed.
730 (pint2hrstr): Last argument is now EMACS_INT.
731
732 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
733 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
734 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
735 (decode_coding_utf_16, decode_coding_emacs_mule)
736 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
737 (decode_coding_ccl, decode_coding_charset)
738 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
739 (decode_coding_iso_2022, decode_coding_emacs_mule)
740 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
741 <char_offset, last_offset>: Declare EMACS_INT.
742 (encode_coding_utf_8, encode_coding_utf_16)
743 (encode_coding_emacs_mule, encode_invocation_designation)
744 (encode_designation_at_bol, encode_coding_iso_2022)
745 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
746 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
747 Declare EMACS_INT.
748 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
749 (encode_invocation_designation): Last argument P_NCHARS is now
750 EMACS_INT.
751 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
752 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
753
754 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
755 All users changed.
756
757 * ccl.c (Fccl_execute_on_string): Declare some variables
758 EMACS_INT.
759
8546720e 7602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
761
762 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
763
4e19a977
CS
7642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
765
766 * process.c (Fformat_network_address): Doc fix.
767
87302331
R
7682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
769
770 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
771
cbb59342
CY
7722011-04-08 Chong Yidong <cyd@stupidchicken.com>
773
774 * keyboard.c (read_char): Call Lisp function help-form-show,
775 instead of using internal_with_output_to_temp_buffer.
776 (Qhelp_form_show): New var.
e0d38eeb 777 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
778
779 * print.c (internal_with_output_to_temp_buffer): Function deleted.
780
781 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
782
e67a13ab
CY
7832011-04-06 Chong Yidong <cyd@stupidchicken.com>
784
785 * process.c (Flist_processes): Removed to Lisp.
786 (list_processes_1): Deleted.
787
973f782d
EZ
7882011-04-06 Eli Zaretskii <eliz@gnu.org>
789
7c106b1e
EZ
790 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
791
973f782d
EZ
792 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
793
41cf7d1a 7942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 795
ca23cc88
PE
796 Fix more problems found by GCC 4.6.0's static checks.
797
f390e2d5
PE
798 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
799
42eea0d0
PE
800 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
801
b69769da 802 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 803
f9541e84
PE
804 * xdisp.c (vmessage): Mark as a printf-like function.
805
13841b55
PE
806 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
807
c136c10f
PE
808 * sound.c (sound_warning): Don't crash if arg contains a printf format.
809
5e2d4a30
PE
810 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
811 printf-like functions.
812 (tiff_load): Add casts to remove these marks before passing them
813 to system-supplied API.
814
583f48b9
PE
815 * eval.c (Fsignal): Remove excess argument to 'fatal'.
816
b25d760e
PE
817 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
818 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
819 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
820 directly, rather than having caller test rule sign. This avoids
821 some unnecessary tests.
822 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
823 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
824 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 825
bc7b6697 826 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 827 (xfont_open): Avoid unnecessary tests.
bc7b6697 828
27ccc379
PE
829 * composite.c (composition_gstring_put_cache): Use unsigned integer.
830
dcd5c89a
PE
831 * composite.h, composite.c (composition_gstring_put_cache):
832 Use EMACS_INT, not int, for length.
833
b13a45c6
PE
834 * composite.h (COMPOSITION_DECODE_REFS): New macro,
835 breaking out part of COMPOSITION_DECODE_RULE.
836 (COMPOSITION_DECODE_RULE): Use it.
837 * composite.c (get_composition_id): Remove unused local vars,
838 by using the new macro.
839
1e792e4d
PE
840 * textprop.c (set_text_properties_1): Change while to do-while,
841 since the condition is always true at first.
842
dc6c6455 843 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
844 (interval_deletion_adjustment): Return unsigned value.
845 All uses changed.
dc6c6455 846
aba7731a
PE
847 * process.c (list_processes_1, create_pty, read_process_output):
848 (exec_sentinel): Remove vars that were set but not used.
afd4052b 849 (create_pty): Remove unnecessary "volatile"s.
bc57d757 850 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 851 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 852 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 853
fdfc4bf3
PE
854 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
855
fca8fe46 856 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 857 (update_syntax_table): Use unsigned instead of int.
fca8fe46 858
06a0259a 859 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 860 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 861 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 862
e7b9e80f
PE
863 * print.c (print_error_message): Avoid int overflow.
864
56201685
PE
865 * font.c (font_list_entities): Redo for clarity,
866 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
867
78834453 868 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 869 (font_score): Avoid potential overflow in diff calculation.
78834453 870
0bc0b309 871 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 872 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 873
e610eaca
PE
874 * eval.c (funcall_lambda): Rename local to avoid shadowing.
875
b895abce
PE
876 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
877 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
878 can always succeed if overflow has undefined behavior.
879
1f1d9321 880 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 881 (wordify): Omit three unnecessary tests.
1f1d9321 882
c59478bc
PE
883 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
884 All callers changed. This avoids the need for an unused var.
885
79b73827
PE
886 * casefiddle.c (casify_region): Remove var that is set but not used.
887
a4db5dfe
PE
888 * dired.c (file_name_completion): Remove var that is set but not used.
889
43aae36e
PE
890 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
891
2a47c44d 892 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 893 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 894
a37c69bf
PE
895 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
896 Check for integer overflow on size calculations.
897
328ab8e7
PE
898 * buffer.c (Fprevious_overlay_change): Remove var that is set
899 but not used.
900
e5a2a5cb
PE
901 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
902 Remove vars that are set but not used.
8d84a6eb 903 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 904 (timer_check_2): Mark vars as initialized.
e5a2a5cb 905
a60e5f68
PE
906 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
907
f661cb61 908 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 909 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 910
f0397f5a
PE
911 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
912 that are set but not used.
913
8664db06 914 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 915 if XCreateBitmapFromData fails (Bug#8410).
8664db06 916
6abdaa4a
PE
917 * xselect.c (x_get_local_selection, x_handle_property_notify):
918 Remove vars that are set but not used.
919
0ce7538d 920 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 921 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 922
9ae848fc
PE
923 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
924 Remove var that is set but not used.
0b918413
PE
925 (scroll_bar_windows_size): Now size_t, not int.
926 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
927 Check for overflow.
9ae848fc 928
a5a62657
PE
929 * xfaces.c (realize_named_face): Remove vars that are set but not used.
930 (map_tty_color) [!defined MSDOS]: Likewise.
931
5c5cdd39
PE
932 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
933
66ebf983
PE
934 * coding.c: Remove vars that are set but not used.
935 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
936 All callers changed.
937 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
938 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
939 (decode_coding_charset): Remove vars that are set but not used.
940
1be4d761
PE
941 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
942 that is set but not used.
943
47553fa8
PE
944 * print.c (print_object): Remove var that is set but not used.
945
1f7196bf 946 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
947 The gnulib version avoids calling malloc in the usual case,
948 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
949 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
950 * filelock.c (current_lock_owner): Likewise.
951 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
952 * sysdep.c: Include allocator.h, careadlinkat.h.
953 (emacs_no_realloc_allocator): New static constant.
954 (emacs_readlink): New function.
fdb61804
PE
955 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
956 ../lib/careadlinkat.h.
d1fdcab7 957
f84c17c7
SM
9582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
959
960 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
961 first non-nil return value).
962
ef3862ad
JD
9632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
964
965 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
966 if not defined (Bug#8403).
967
376a7006
JB
9682011-04-02 Juanma Barranquero <lekktu@gmail.com>
969
970 * xdisp.c (display_count_lines): Remove parameter `start',
971 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
972 (get_char_face_and_encoding): Remove parameter `multibyte_p',
973 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
974 (fill_stretch_glyph_string): Remove parameters `row' and `area',
975 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
976 and thereabouts. All callers changed.
977 (get_per_char_metric): Remove parameter `f', unused since
978 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
979
6ca3801d
JM
9802011-04-02 Jim Meyering <meyering@redhat.com>
981
982 do not dereference NULL upon failed strdup
983 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
984 (ns_get_family): Likewise.
985
d8e2b5ba
JB
9862011-04-02 Juanma Barranquero <lekktu@gmail.com>
987
988 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
989
8c74fcbd
JD
9902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
991
992 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
993 later (Bug#8403).
994
7200d79c
SM
9952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
996
03408648 997 Add lexical binding.
7200d79c 998
03408648
SM
999 * window.c (Ftemp_output_buffer_show): New fun.
1000 (Fsave_window_excursion):
1001 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1002
1003 * lread.c (lisp_file_lexically_bound_p): New function.
1004 (Fload): Bind Qlexical_binding.
1005 (readevalloop): Remove `evalfun' arg.
1006 Bind Qinternal_interpreter_environment.
1007 (Feval_buffer): Bind Qlexical_binding.
1008 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1009 Mark as dynamic.
1010 (syms_of_lread): Declare `lexical-binding'.
1011
1012 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1013
1014 * keyboard.c (eval_dyn): New fun.
1015 (menu_item_eval_property): Use it.
ca105506
SM
1016
1017 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1018
03408648
SM
1019 * fns.c (concat, mapcar1): Accept byte-code-functions.
1020
1021 * eval.c (Fsetq): Handle lexical vars.
1022 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1023 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1024 (FletX, Flet): Obey lexical binding.
1025 (Fcommandp): Handle closures.
1026 (Feval): New `lexical' arg.
1027 (eval_sub): New function extracted from Feval. Use it almost
1028 everywhere where Feval was used. Look up vars in lexical env.
1029 Handle closures.
1030 (Ffunctionp): Move from subr.el.
1031 (Ffuncall): Handle closures.
1032 (apply_lambda): Remove `eval_flags'.
1033 (funcall_lambda): Handle closures and new byte-code-functions.
1034 (Fspecial_variable_p): New function.
1035 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1036 but without exporting it to Lisp.
23aba0ea 1037
23aba0ea 1038 * doc.c (Fdocumentation, store_function_docstring):
03408648 1039 * data.c (Finteractive_form): Handle closures.
23aba0ea 1040
03408648
SM
1041 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1042 interactive spec.
ba83908c 1043
03408648
SM
1044 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1045 byte-codes.
1046 (exec_byte_code): New function extracted from Fbyte_code to handle new
1047 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1048
03408648 1049 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1050
03408648 1051 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1052
e2abce01
JB
10532011-03-31 Juanma Barranquero <lekktu@gmail.com>
1054
1055 * xdisp.c (redisplay_internal): Fix prototype.
1056
63696a73 10572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1058
63696a73
EZ
1059 * xdisp.c (SCROLL_LIMIT): New macro.
1060 (try_scrolling): Use it when setting scroll_limit. Limit
1061 scrolling to 100 screen lines.
1062 (redisplay_window): Even when falling back on "recentering",
1063 position point in the window according to scroll-conservatively,
1064 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1065
1066 (try_scrolling): When point is above the window, allow searching
1067 as far as scroll_max, or one screenful, to compute vertical
1068 distance from PT to the scroll margin position. This prevents
1069 try_scrolling from unnecessarily failing when
1070 scroll-conservatively is set to a value slightly larger than the
1071 window height. Clean up the case of PT below the margin at bottom
1072 of window: scroll_max can no longer be INT_MAX. When aggressive
1073 scrolling is in use, don't let point enter the opposite scroll
1074 margin as result of the scroll.
1075 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1076 threshold of 100 lines for never-recentering scrolling.
1077
e4cc2dfc
JB
10782011-03-31 Juanma Barranquero <lekktu@gmail.com>
1079
1080 * dispextern.h (move_it_by_lines):
1081 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1082 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1083 (message_log_check_duplicate): Remove parameters `prev_bol' and
1084 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1085 (redisplay_internal): Remove parameter `preserve_echo_area',
1086 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1087
1088 * indent.c (Fvertical_motion):
1089 * window.c (window_scroll_pixel_based, Frecenter):
1090 Don't pass `need_y_p' to `move_it_by_lines'.
1091
1c470562
SM
10922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1093
44f230aa
SM
1094 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1095 steal a few bits to be more compact.
1096 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1097 Remove unneeded casts.
1098
1c470562
SM
1099 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1100
888adce9
ZK
11012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1102
1103 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1104 binding" message (bug#7967).
1105
f838ed7b
PE
11062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1107
77861b95
PE
1108 Fix more problems found by GCC 4.6.0's static checks.
1109
de6dbc14
PE
1110 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1111 Remove unused local var.
1112
f838ed7b
PE
1113 * editfns.c (Fmessage_box): Remove unused local var.
1114
792c7b2b
PE
1115 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1116 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1117 Omit unused local vars.
c499e557 1118 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1119 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1120 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1121 Omit unused local var.
1122
ba0165e1
PE
1123 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1124 Don't assume string length fits in int.
32ad8845 1125 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1126 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1127
3c59b4c9
PE
1128 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1129 instead of alloca (Bug#8344).
1130
a3eed478 1131 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1132 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1133
eb4d412d
PE
1134 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1135
1658b401
PE
1136 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1137 concerns.
1138
1139 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1140
1141 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1142
9a2c6e05
PE
1143 * keyboard.c (syms_of_keyboard): Use the same style as later
1144 in this function when indexing through an array. This also
1145 works around GCC bug 48267.
1146
03d0a109
PE
1147 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1148
44f730c8
PE
1149 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1150
fe75f926
PE
1151 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1152 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1153
ffa8c828
PE
1154 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1155 This avoids undefined behavior on integer overflow, and is a bit
1156 more convenient anyway since it is compared to a size_t variable.
1157
c5101a77
PE
1158 Variadic C functions now count arguments with size_t, not int.
1159 This avoids an unnecessary limitation on 64-bit machines, which
1160 caused (substring ...) to crash on large vectors (Bug#8344).
1161 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1162 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1163 All variadic functions and their callers changed accordingly.
c5101a77
PE
1164 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1165 * data.c (arith_driver, float_arith_driver): Likewise.
1166 * editfns.c (general_insert_function): Likewise.
1167 * eval.c (struct backtrace.nargs, interactive_p)
1168 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1169 (funcall_lambda, mark_backtrace): Likewise.
1170 * fns.c (concat): Likewise.
1171 * frame.c (x_set_frame_parameters): Likewise.
1172 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1173 0 if not found, not -1. All callers changed.
1174
dd3f25f7
PE
1175 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1176 (stack_copy_size): Now size_t, not int.
1177 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1178
461c2ab9
JB
11792011-03-28 Juanma Barranquero <lekktu@gmail.com>
1180
1181 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1182 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1183 All callers changed.
1184
1185 * lisp.h (multibyte_char_to_unibyte):
1186 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1187 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1188 * character.h (CHAR_TO_BYTE8):
1189 * cmds.c (internal_self_insert):
1190 * editfns.c (general_insert_function):
1191 * keymap.c (push_key_description):
1192 * search.c (Freplace_match):
1193 * xdisp.c (message_dolog, set_message_1): All callers changed.
1194
f6d62986
SM
11952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1196
1197 * keyboard.c (safe_run_hook_funcall): New function.
1198 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1199 don't set the hook to nil, but remove the offending function instead.
1200 (Qcommand_hook_internal): Remove, unused.
1201 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1202 Vcommand_hook_internal.
1203
1204 * eval.c (enum run_hooks_condition): Remove.
1205 (funcall_nil, funcall_not): New functions.
1206 (run_hook_with_args): Call each function through a `funcall' argument.
1207 Remove `cond' argument, now redundant.
1208 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1209 (Frun_hook_with_args_until_failure): Adjust accordingly.
1210 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1211
1db5b1ad
JB
12122011-03-28 Juanma Barranquero <lekktu@gmail.com>
1213
1214 * dispextern.h (string_buffer_position): Remove declaration.
1215
1216 * print.c (strout): Remove parameter `multibyte', unused since
1217 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1218
1219 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1220 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1221 All callers changed.
1222
1223 * w32.c (_wsa_errlist): Use braces for struct initializers.
1224
1225 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1226 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1227 All callers changed.
1228 (string_buffer_position): Likewise. Also, make static (it's never
1229 used outside xdisp.c).
1230 (cursor_row_p): Remove parameter `w', unused since
1231 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1232 (decode_mode_spec): Remove parameter `precision', introduced during
1233 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1234 All callers changed.
1235
5ffb62aa
JD
12362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1239
461c2ab9 12402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1241
1242 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1243 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1244 (ns_update_auto_hide_menu_bar): New functions.
1245 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1246 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1247 ns_constrain_all_frames.
1248 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1249 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1250
5c380ffb
JD
12512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1252
1253 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1254
9af30bdf
GM
12552011-03-27 Glenn Morris <rgm@gnu.org>
1256
1257 * syssignal.h: Replace RETSIGTYPE with void.
1258 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1259 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1260 Replace SIGTYPE with void everywhere.
1261 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1262 * s/template.h (SIGTYPE): Remove commented out definition.
1263
e2abce01
JB
12642011-03-26 Eli Zaretskii <eliz@gnu.org>
1265
1266 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1267 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1268
f868cd8a
JB
12692011-03-26 Juanma Barranquero <lekktu@gmail.com>
1270
59eb0929
JB
1271 * w32.c (read_unc_volume): Use parameter `henum', instead of
1272 global variable `wget_enum_handle'.
1273
1274 * keymap.c (describe_vector): Remove parameters `indices' and
1275 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1276 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1277
f868cd8a
JB
1278 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1279
1280 * keyboard.c (timer_check): Remove parameter `do_it_now',
1281 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1282 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1283 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1284
1285 * keyboard.c (read_char):
1286 * w32menu.c (w32_menu_display_help):
1287 * xmenu.c (show_help_event, menu_help_callback):
1288 Adjust calls to `show_help_echo'.
1289
1290 * gtkutil.c (xg_maybe_add_timer):
1291 * keyboard.c (readable_events):
1292 * process.c (wait_reading_process_output):
1293 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1294
1295 * insdel.c (adjust_markers_gap_motion):
1296 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1297 (gap_left, gap_right): Don't call it.
1298
2ecf6fdb
CY
12992011-03-25 Chong Yidong <cyd@stupidchicken.com>
1300
1301 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1302 incurred during fontification.
1303
6b1f9ba4
JB
13042011-03-25 Juanma Barranquero <lekktu@gmail.com>
1305
1306 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1307 (DEFVAR_PER_BUFFER): Don't pass it.
1308
1309 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1310 (scrolling_window): Don't pass it.
1311
0f4a96b5
JB
13122011-03-25 Juanma Barranquero <lekktu@gmail.com>
1313
1314 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1315
1316 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1317 and `suffix'.
1318 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1319 of variables specific to SELinux and computation of `encoded_absname'.
1320
1321 * image.c (XPutPixel): Remove unused variable `height'.
1322
1323 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1324
1325 * unexw32.c (get_section_info): Remove unused variable `section'.
1326
1327 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1328 (system_process_attributes): Remove unused variable `sess'.
1329 (sys_read): Remove unused variable `err'.
1330
1331 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1332 (w32_wnd_proc): Remove unused variable `isdead'.
1333 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1334 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1335 (x_create_tip_frame): Remove unused variable `tem'.
1336
1337 * w32inevt.c (w32_console_read_socket):
1338 Remove unused variable `no_events'.
1339
1340 * w32term.c (x_draw_composite_glyph_string_foreground):
1341 Remove unused variable `width'.
1342
1149507c
JB
13432011-03-24 Juanma Barranquero <lekktu@gmail.com>
1344
1345 * w32term.c (x_set_glyph_string_clipping):
1346 Don't pass uninitialized region to CombineRgn.
1347
9c88f339
JB
13482011-03-23 Juanma Barranquero <lekktu@gmail.com>
1349
1350 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1351 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1352 (Fx_close_connection): Remove unused variable `i'.
1353
1354 * w32font.c (w32font_draw): Return number of glyphs.
1355 (w32font_open_internal): Remove unused variable `i'.
1356 (w32font_driver): Add missing initializer.
1357
1358 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1359 (fill_in_menu): Remove unused variable `items_added'.
1360
1361 * w32term.c (last_mouse_press_frame): Remove static global variable.
1362 (w32_clip_to_row): Remove unused variable `f'.
1363 (x_delete_terminal): Remove unused variable `i'.
1364
1365 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1366 (NOTHING): Remove unused static global variable.
1367 (uniscribe_check_otf): Remove unused variable `table'.
1368 (uniscribe_font_driver): Add missing initializers.
1369
dee091a3
JD
13702011-03-23 Julien Danjou <julien@danjou.info>
1371
1372 * term.c (Fsuspend_tty, Fresume_tty):
1373 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1374 * window.c (temp_output_buffer_show):
1375 * insdel.c (signal_before_change):
1376 * frame.c (Fhandle_switch_frame):
1377 * fileio.c (Fdo_auto_save):
1378 * emacs.c (Fkill_emacs):
1379 * editfns.c (save_excursion_restore):
1380 * cmds.c (internal_self_insert):
1381 * callint.c (Fcall_interactively):
1382 * buffer.c (Fkill_all_local_variables):
1383 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1384 Use Frun_hooks.
0f4a96b5 1385 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1386 unconditionnaly since it does the check itself.
1387
2c520ab5 13882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1389
c9c49752
PE
1390 Fix more problems found by GCC 4.5.2's static checks.
1391
8abc3f12
PE
1392 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1393 the first time through the loop, since we know p0 < p1 then.
1394 This also avoids a gcc -Wstrict-overflow warning.
1395
a2d26660
PE
1396 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1397 leading to a memory leak, possible in functions like
1398 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1399 of objects (Bug#8318).
a2d26660 1400
916c72e9
PE
1401 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1402 that could (at least in theory) be that large.
1403
19ab8a18
PE
1404 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1405 This is less likely to overflow, and avoids undefined behavior if
1406 overflow does occur. All callers changed. Use strtoul to scan
1407 for the unsigned long integer.
b7cbbd6f
PE
1408 (pint2hrstr): Simplify and tune code slightly.
1409 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1410
f0641eff
PE
1411 * scroll.c (do_scrolling): Work around GCC bug 48228.
1412 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1413
7f650bb9
PE
1414 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1415 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1416 (validate_x_resource_name): Simplify count usage.
1417 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1418
37dd57d1
PE
1419 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1420 fail (Bug#8306).
81e56e61 1421
699979fc 1422 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1423
401bf9b4
PE
1424 * process.c (Fmake_network_process): Use socklen_t, not int,
1425 where POSIX says socklen_t is required in portable programs.
1426 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1427 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1428 (Fmake_network_process, server_accept_connection):
1429 (wait_reading_process_output, read_process_output):
1430 Likewise.
1431
b93aacde
PE
1432 * process.c: Rename or move locals to avoid shadowing.
1433 (list_processes_1, Fmake_network_process):
1434 (read_process_output_error_handler, exec_sentinel_error_handler):
1435 Rename or move locals.
4dc343ee 1436 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1437 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1438 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1439 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1440 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1441
af8a867c 1442 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1443 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1444 Include tparam.h instead, since it declares them.
af8a867c
PE
1445 * cm.h (PC): Remove extern decl; tparam.h now does this.
1446 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1447 * terminfo.c: Include tparam.h, to check interfaces.
1448 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1449 (tparam): Adjust signature to match interface in tparam.h;
1450 this removes some undefined behavior. Check that outstring and len
1451 are zero, which they always are with Emacs.
1452 * tparam.h (PC, BC, UP): New extern decls.
1453
0248044d 1454 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1455 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1456
8ff096c1 1457 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1458 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1459 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1460 (ftfont_list): Remove unused local.
49eaafba
PE
1461 (get_adstyle_property, ftfont_pattern_entity):
1462 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1463 Rename locals to avoid shadowing.
8ff096c1 1464
e2be39f6
PE
1465 * xfont.c (xfont_list_family): Mark var as initialized.
1466
c9735e30
PE
1467 * xml.c (make_dom): Now static.
1468
8f5201ae
PE
1469 * composite.c (composition_compute_stop_pos): Rename local to
1470 avoid shadowing.
b246f932
PE
1471 (composition_reseat_it): Remove unused locals.
1472 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1473 (composition_update_it): Mark var as initialized.
11b61122
PE
1474 (find_automatic_composition): Mark vars as initialized,
1475 with a FIXME (Bug#8290).
8f5201ae 1476
760fbc2c
PE
1477 character.h: Rename locals to avoid shadowing.
1478 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1479 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1480 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1481 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1482 to avoid shadowing.
1483
ff08eb85
PE
1484 * textprop.c (property_change_between_p): Remove; unused.
1485
fc7bf025
PE
1486 * intervals.c (interval_start_pos): Now static.
1487
235d7abc
PE
1488 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1489
44f230aa
SM
1490 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1491 Rename locals to avoid shadowing.
3e7d6594 1492
50060332
PE
1493 * sound.c (wav_play, au_play, Fplay_sound_internal):
1494 Fix pointer signedness.
d01f234b 1495 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1496 (wav_play): Initialize a variable to 0, to prevent undefined
1497 behavior (Bug#8278).
50060332 1498
c4fc4e30
PE
1499 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1500
918436ed
PE
1501 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1502
c939f91b
PE
1503 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1504 clobbering (Bug#8298).
b9c7f648
PE
1505 * sysdep.c (sys_subshell): Likewise.
1506 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1507
6bd8c144
PE
1508 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1509 This should get cleaned up, so that child_setup has the
1510 same signature on all platforms.
1511
7710357c 1512 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1513 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1514
c59da222
CY
15152011-03-22 Chong Yidong <cyd@stupidchicken.com>
1516
1517 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1518 not to be necessary, and produces flickering.
1519
66b87493
GM
15202011-03-20 Glenn Morris <rgm@gnu.org>
1521
1522 * config.in: Remove file.
1523
45b6f6d5
JB
15242011-03-20 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1527 are now in src/globals.h.
1528 (syms_of_minibuf): Remove spurious & from previous change.
1529
3ec03f7e
LL
15302011-03-20 Leo <sdl.web@gmail.com>
1531
1532 * minibuf.c (completing-read-function): New variable.
1533 (completing-read-default): Rename from completing-read.
1534 (completing-read): Call completing-read-function.
1535
b14e3e21
CY
15362011-03-19 Juanma Barranquero <lekktu@gmail.com>
1537
1538 * xfaces.c (Fx_load_color_file):
1539 Read color file from absolute filename (bug#8250).
1540
f2b726e6
JB
15412011-03-19 Juanma Barranquero <lekktu@gmail.com>
1542
1543 * makefile.w32-in: Update dependencies.
1544
09f6ff02
EZ
15452011-03-17 Eli Zaretskii <eliz@gnu.org>
1546
1547 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1548
29a6015a
PE
15492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1550
a3a6c54e
PE
1551 Fix more problems found by GCC 4.5.2's static checks.
1552
b766f867
PE
1553 * process.c (make_serial_process_unwind, send_process_trap):
1554 (sigchld_handler): Now static.
1555
be02381c
PE
1556 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1557 That way, the code declares only the vars that it needs.
1558 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1559 * s/cygwin.h (PTY_ITERATION): Likewise.
1560 * s/darwin.h (PTY_ITERATION): Likewise.
1561 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1562
57048744
PE
1563 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1564 * process.c (allocate_pty): Don't declare stb unless it's needed.
1565
7914961c 1566 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1567 (CONSTANTLIM): Remove; unused.
1568 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1569 Define only if needed.
7914961c 1570
b3967b18
PE
1571 * unexelf.c (unexec): Name an expression,
1572 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1573 Use a different way to cause a compilation error if anyone uses
1574 n rather than nn, a way that does not involve shadowing.
73366a00 1575 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1576
29a6015a
PE
1577 * deps.mk (unexalpha.o): Remove; unused.
1578
43cfc33e 1579 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1580 * unexec.h: New file.
ce701a33
PE
1581 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1582 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1583 Depend on unexec.h.
1584 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1585 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1586 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1587 Change as necessary to match prototype in unexec.h.
ce701a33 1588
01f44d5a
PE
1589 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1590 shadowing.
4f63c6bb 1591 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1592
a6670b0b
PE
1593 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1594 Rename locals to avoid shadowing.
1595
cef2010d 1596 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1597 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1598
d4d7173a
PE
1599 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1600
f08b802a
PE
1601 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1602 warning when compiling print.c.
1603
3ddb0639
PE
1604 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1605 instead of using an uninitialized var.
5ad03b97 1606 (font_sort_entities): Mark var as initialized.
3ddb0639 1607
170a2692
PE
1608 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1609
e663c700
PE
1610 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1611 pointers to constants.
89bc529a 1612 (font_parse_fcname): Remove unused vars.
7b81e2d0 1613 (font_delete_unmatched): Now static.
ea838e10 1614 (font_get_spec): Remove; unused.
13a547c6
PE
1615 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1616 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1617 Rename or move locals to avoid shadowing.
e663c700 1618
2a80c887 1619 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1620 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1621
1384fa33 1622 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1623 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1624
8b2c52e9
PE
1625 * alloc.c (mark_backtrace): Move decl from here ...
1626 * lisp.h: ... to here, so that it can be checked.
1627
475545b5 1628 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1629 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1630 (lisp_indirect_variable): Name an expression,
1631 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1632 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1633
b1349114 1634 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1635 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1636 Use const pointer when appropriate.
b1349114 1637
a2928364
PE
1638 * lisp.h (get_system_name, get_operating_system_release):
1639 Move decls here, to check interfaces.
1640 * process.c (get_operating_system_release): Move decl to lisp.h.
1641 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1642 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1643 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1644 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1645 (Fformat_time_string, Fencode_time, Finsert_char):
1646 (Ftranslate_region_internal, Fformat):
1647 Rename or remove local vars to avoid shadowing.
9710023e 1648 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1649
a415e694
PE
1650 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1651 avoid shadowing.
1652
8ef4622d
PE
1653 * lisp.h (eassert): Check that the argument compiles, even if
1654 ENABLE_CHECKING is not defined.
1655
946f9a5b
PE
1656 * data.c (Findirect_variable): Name an expression, to avoid
1657 gcc -Wbad-function-cast warning.
112396d6 1658 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1659 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1660 (Fmake_variable_buffer_local, Fmake_local_variable):
1661 Mark variables as initialized.
52746918 1662 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1663
e5aab7e7 1664 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1665 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1666 Rename locals to avoid shadowing.
dff45157
PE
1667 (mark_stack): Move local variables into the #ifdef region where
1668 they're used.
7bc26fdb
PE
1669 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1670 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1671 needed otherwise.
1672 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1673 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1674 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1675
e5aab7e7
PE
1676 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1677 avoids undefined behavior in theory.
1678
4da60324
PE
1679 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1680
88043301
PE
1681 Use functions, not macros, for up- and down-casing (Bug#8254).
1682 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1683 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1684 to use the following functions instead of these macros.
1685 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1686 EMACS_INT, since callers assume the returned value fits in int.
1687 (upcase1): Likewise, for UPCASE_TABLE.
1688 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1689 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1690 the race-condition problem in the old DOWNCASE.
88043301 1691
19ed5445
PE
1692 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1693 Rename locals to avoid shadowing.
1694 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1695 (regex_compile, re_search_2, re_match_2_internal):
1696 Remove unused local vars.
952db0d7
PE
1697 (FREE_VAR): Rewrite so as not to use empty "else",
1698 which gcc can warn about.
da053e48 1699 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1700 (RETALLOC_IF): Define only if needed.
1701 (WORDCHAR_P): Likewise. This one is never needed, but is used
1702 only in a comment talking about a compiler bug, so put inside
1703 the #if 0 of that comment.
1704 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1705 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1706 Remove; unused.
19ed5445 1707
1f3561e4 1708 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1709 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1710 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1711
ded6f8f7
PE
1712 * search.c (simple_search): Remove unused var.
1713
dbd37a95
PE
1714 * dired.c (compile_pattern): Move decl from here ...
1715 * lisp.h: ... to here, so that it can be checked.
1716 (struct re_registers): New forward decl.
1717
7e47afad
PE
1718 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1719
85f24f61
PE
1720 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1721 All uses changed.
1722 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1723 Rename locals to avoid shadowing.
5671df8f 1724 (Fvertical_motion): Mark locals as initialized.
85f24f61 1725
181aa2be 1726 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1727 (casify_region): Mark local as initialized.
181aa2be 1728
930d429c
PE
1729 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1730
7082eac6
PE
1731 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1732 New macros, so that the caller can use some names other than
1733 gcpro1, gcpro2, etc.
1734 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1735 of the new macros.
1736 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1737 argument, for consistency with GCPRO2_VAR, etc: it is now the
1738 prefix of the variable, not the variable itself. All uses
1739 changed.
38b2c076
PE
1740 * dired.c (directory_files_internal, file_name_completion):
1741 Rename locals to avoid shadowing.
1742
15206ed9
PE
1743 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1744 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1745 dired.c's scmp function, had undefined behavior.
1746 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1747 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1748 * buffer.h: ... to here, because these macros use current_buffer,
1749 and the new implementation with inline functions needs to have
1750 current_buffer in scope now, rather than later when the macros
1751 are used.
1752 (downcase, upcase1): New static inline functions.
1753 (DOWNCASE, UPCASE1): Reimplement using these functions.
1754 This avoids undefined behavior in expressions like
1755 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1756 from race conditions in accessing the global variables
1757 case_temp1 and case_temp2.
1758 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1759 * lisp.h (case_temp1, case_temp2): Remove their decls.
1760 * character.h (ASCII_CHAR_P): Move from here ...
1761 * lisp.h: ... to here, so that the inline functions mentioned
1762 above can use them.
1763
4a6bea26
PE
1764 * dired.c (directory_files_internal_unwind): Now static.
1765
f14b7e14
PE
1766 * fileio.c (file_name_as_directory, directory_file_name):
1767 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1768 Now static.
2893f146
PE
1769 (file_name_as_directory): Use const pointers when appropriate.
1770 (Fexpand_file_name): Likewise. In particular, newdir might
1771 point at constant storage, so make it a const pointer.
fd4ead52 1772 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1773 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1774 signedness issues.
f839df0c
PE
1775 (Fset_file_times, Finsert_file_contents, auto_save_error):
1776 Rename locals to avoid shadowing.
f14b7e14 1777
5716756e 1778 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1779 (Ftry_completion, Fall_completions): Rename or remove locals
1780 to avoid shadowing.
5716756e 1781
b4c3046a
PE
1782 * marker.c (bytepos_to_charpos): Remove; unused.
1783
b45db522
PE
1784 * lisp.h (verify_bytepos, count_markers): New decls,
1785 so that gcc does not warn that these functions aren't declared.
1786
85876d07
PE
1787 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1788 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1789 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1790 (copy_text): Remove unused local var.
85876d07 1791
03d78a21 1792 * filelock.c (within_one_second): Now static.
b3dd38ab 1793 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1794
5df8f01b
PE
1795 * buffer.c (fix_overlays_before): Mark locals as initialized.
1796 (fix_start_end_in_overlays): Likewise. This function should be
1797 simplified by using pointers-to-pointers, but that's a different
1798 matter.
b1d876f1 1799 (switch_to_buffer_1): Now static.
8f54f30a
PE
1800 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1801 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1802
a70072c9 1803 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1804 Fix pointer signedness issue.
edced198
PE
1805 (sys_subshell): Mark local as volatile if checking for lint,
1806 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1807 (MAXPATHLEN): Define only if needed.
a70072c9 1808
a0977c44
PE
1809 * process.c (serial_open, serial_configure): Move decls from here ...
1810 * systty.h: ... to here, so that they can be checked.
1811
a884fdcc
PE
1812 * fns.c (get_random, seed_random): Move extern decls from here ...
1813 * lisp.h: ... to here, so that they can be checked.
1814
604efe86 1815 * sysdep.c (reset_io): Now static.
b8950c94 1816 (wait_for_termination_signal): Remove; unused.
604efe86 1817
38fc62d9
PE
1818 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1819 (copy_keymap_item, append_key, push_text_char_description):
1820 Now static.
1004a21a 1821 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1822 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1823 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1824 (describe_map_tree):
1825 Rename locals to avoid shadowing.
38fc62d9 1826
2f2650da
PE
1827 * keyboard.c: Declare functions static if they are not used elsewhere.
1828 (echo_char, echo_dash, cmd_error, top_level_2):
1829 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1830 (read_char, kbd_buffer_get_event, make_lispy_position):
1831 (make_lispy_event, make_lispy_movement, apply_modifiers):
1832 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1833 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1834 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1835 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1836 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1837
a053e86c 1838 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1839 (mark_kboards): Move decl here ...
1840 * alloc.c (mark_kboards): ... from here.
a053e86c 1841
4752793e
PE
1842 * lisp.h (force_auto_save_soon): New decl.
1843
74f10ca7 1844 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1845 (DEFINE_DUMMY_FUNCTION): New macro.
1846 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1847 Use it.
c03cd23f
PE
1848 (main): Add casts to avoid warnings
1849 if GCC considers string literals to be constants.
74f10ca7 1850
022e70d4
PE
1851 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1852
59d6fe83
PE
1853 * dbusbind.c: Pointer signedness fixes.
1854 (xd_signature, xd_append_arg, xd_initialize):
1855 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1856 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1857 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1858 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1859
78320123
PE
1860 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1861 if GCC considers string literals to be constants.
49cebcca 1862 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1863
35ac2a97
SM
18642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1865
fb103ca9
SM
1866 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1867 (print_preprocess, print_object): New macro to fix last change.
1868
35ac2a97
SM
1869 * print.c (print_preprocess): Don't forget font objects.
1870
62973b41
JB
18712011-03-16 Juanma Barranquero <lekktu@gmail.com>
1872
1873 * emacs.c (USAGE3): Doc fixes.
1874
0e48bb22
AS
18752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1876
1877 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1878 structure.
1879
7684e57b
JB
18802011-03-14 Juanma Barranquero <lekktu@gmail.com>
1881
1882 * lisp.h (VWindow_system, Qfile_name_history):
1883 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1884 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1885 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1886
1887 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1888 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1889
1890 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1891 * w32console.c (detect_input_pending, read_input_pending)
1892 (encode_terminal_code):
1893 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1894 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1895 (w32_system_caret_y, Qfile_name_history):
1896 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1897 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1898 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1899 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1900 * w32proc.c (Qlocal, report_file_error):
1901 * w32term.c (Vwindow_system, updating_frame):
1902 * w32uniscribe.c (initialized, uniscribe_font_driver):
1903 Remove unneeded extern declarations.
1904
2aa46d6c
CY
19052011-03-14 Chong Yidong <cyd@stupidchicken.com>
1906
c96bbc66 1907 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1908
cffc6f3b
CY
19092011-03-13 Chong Yidong <cyd@stupidchicken.com>
1910
1911 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1912 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1913 These macros can no longer be used for assignment.
1914
44f230aa
SM
1915 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1916 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1917 (record_buffer_markers, fetch_buffer_markers): New functions for
1918 recording and fetching special buffer markers.
1919 (set_buffer_internal_1, set_buffer_temp): Use them.
1920
1921 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1922
1923 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1924
1925 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1926 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1927
1928 * xdisp.c (hscroll_window_tree):
1929 (reconsider_clip_changes): Use PT instead of BUF_PT.
1930
d251f04b
EZ
19312011-03-13 Eli Zaretskii <eliz@gnu.org>
1932
1933 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1934 $(EMACS_ROOT)/lib/intprops.h.
1935
f0c77cd1
PE
19362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1937
3eca4629
PE
1938 Fix more problems found by GCC 4.5.2's static checks.
1939
7c86ee98
PE
1940 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1941 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1942 (xg_free_frame_widgets): Make it clear that a local variable is
1943 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1944 (gdk_window_get_screen): Make it clear that this macro is needed
1945 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1946 (int_gtk_range_get_value): New function, which avoids a diagnostic
1947 from gcc -Wbad-function-cast.
1948 (xg_set_toolkit_scroll_bar_thumb): Use it.
1949 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1950 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1951 (get_utf8_string, xg_get_file_with_chooser):
1952 Rename locals to avoid shadowing.
1953 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1954
41729b81
PE
1955 * xgselect.c (xg_select): Remove unused var.
1956
f0c77cd1
PE
1957 * image.c (four_corners_best): Mark locals as initialized.
1958 (gif_load): Initialize transparent_p to zero (Bug#8238).
1959 Mark another local as initialized.
ec6cf4c6 1960 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1961
ce0ad53d 1962 * image.c (clear_image_cache): Now static.
d5d5a617 1963 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1964 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1965 (x_edge_detection): Remove unnecessary cast that
1966 gcc -Wbad-function-cast diagnoses.
2037898d 1967 (gif_load): Fix pointer signedness.
6ae141d6
PE
1968 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1969 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1970
33383987 19712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1972
d32df629
PE
1973 Improve quality of tests for time stamp overflow.
1974 For example, without this patch (encode-time 0 0 0 1 1
1975 1152921504606846976) returns the obviously-bogus value (-948597
1976 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1977 reports time overflow. See
1978 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1979 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1980 * editfns.c: Include limits.h and intprops.h.
1981 (TIME_T_MIN, TIME_T_MAX): New macros.
1982 (time_overflow): Move earlier, to before first use.
1983 (hi_time, lo_time): New functions, for an accurate test for
1984 out-of-range times.
1985 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1986 (Fget_internal_run_time): Don't assume time_t fits in int.
1987 (make_time): Use list2 instead of Fcons twice.
1988 (Fdecode_time): More accurate test for out-of-range times.
1989 (check_tm_member): New function.
1990 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1991 (lisp_time_argument): Don't rely on undefined left-shift and
1992 right-shift behavior when checking for time stamp overflow.
8be6f318 1993
fe31d94c
PE
1994 * editfns.c (time_overflow): New function, refactoring common code.
1995 (Fformat_time_string, Fdecode_time, Fencode_time):
1996 (Fcurrent_time_string): Use it.
1997
8be6f318
PE
1998 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1999 * dired.c (make_time): Move to ...
2000 * editfns.c (make_time): ... here.
2001 * systime.h: Note the move.
2002
09d9db2c 20032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2004
126bc0dc
YM
2005 * fringe.c (update_window_fringes): Remove unused variables.
2006
c47cbdfd
YM
2007 * unexmacosx.c (copy_data_segment): Also copy __got section.
2008 (Bug#8223)
2009
7ac80be9
EZ
20102011-03-12 Eli Zaretskii <eliz@gnu.org>
2011
c96bbc66 2012 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2013 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2014 Constify `char *' arguments and their references according to
2015 prototypes in tparam.h.
2016
ecb0f94d 2017 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2018
7ac80be9
EZ
2019 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2020 Adapt all references accordingly.
2021
2022 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2023
ef1fd07e
TT
20242011-03-11 Tom Tromey <tromey@redhat.com>
2025
2026 * buffer.c (syms_of_buffer): Remove obsolete comment.
2027
7ef4b50c
EZ
20282011-03-11 Eli Zaretskii <eliz@gnu.org>
2029
2030 * termhooks.h (encode_terminal_code): Declare prototype.
2031
2032 * msdos.c (encode_terminal_code): Don't declare prototype.
2033
2034 * term.c (encode_terminal_code): Now external again, used by
2035 w32console.c and msdos.c.
2036
44f230aa
SM
2037 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2038 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2039
4b1ec863 20402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2041
1714f52b 2042 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2043
4b1ec863
PE
2044 * fringe.c (update_window_fringes): Mark locals as initialized
2045 (Bug#8227).
2046 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2047
524c7aa6
PE
2048 * alloc.c (mark_fringe_data): Move decl from here ...
2049 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2050 to check its interface.
2051 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2052
a5c0af81 2053 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2054 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2055 (fontset_font): Mark local as initialized.
a9a06e0b 2056 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2057
b4716021
PE
2058 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2059
811e9bac 2060 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2061 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2062 (x_own_selection, Fx_disown_selection_internal): Rename locals
2063 to avoid shadowing.
2064 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2065
7e3ab302
PE
2066 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2067 so that the caller can use some name other than gcpro1.
2068 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2069 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2070 (Fx_backspace_delete_keys_p):
2071 Use them to avoid shadowing, and rename vars to avoid shadowing.
2072 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2073 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2074 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2075 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2076 Remove unused locals.
7e3ab302
PE
2077 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2078 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2079 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2080 macros.
f78faa98 2081
e2b13473
PE
2082 * xterm.h (x_mouse_leave): New decl.
2083
77f23912
PE
2084 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2085 Remove unused functions.
cdf4ba58
PE
2086 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2087 (x_calc_absolute_position): Now static.
7411c686 2088 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2089 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2090 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2091 unless they are used.
38d0b34a
PE
2092 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2093 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2094 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2095 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2096 (x_error_catcher, x_connection_closed, x_error_handler):
2097 (x_error_quitter, xembed_send_message, x_iconify_frame):
2098 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2099 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2100 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2101
44f230aa
SM
2102 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2103 Rename or move locals to avoid shadowing.
6b463e58 2104 (tty_defined_color, merge_face_heights): Now static.
5967d051 2105 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2106 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2107 does not deduce is never used uninitialized.
73719eba
PE
2108 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2109 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2110
426994c3 2111 * terminal.c (store_terminal_param): Now static.
5489860b 2112
032f1620 2113 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2114 (set_frame_menubar): Remove unused local.
d4323972 2115 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2116 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2117 since they might point to immutable storage.
281585b0
PE
2118 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2119 since it's unused otherwise.
032f1620 2120
367c19e5 2121 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2122 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2123 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2124 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2125 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2126 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2127 does not deduce are never used uninitialized.
70739cbe 2128
07b48fa9
PE
2129 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2130
8868a238 2131 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2132 * window.c (window_loop, size_window):
2133 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2134
7e5cf297 2135 * window.c (display_buffer): Now static.
d6550a9f
PE
2136 (size_window): Mark variables that gcc -Wuninitialized
2137 does not deduce are never used uninitialized.
a586633d
PE
2138 * window.h (check_all_windows): New decl, to forestall
2139 gcc -Wmissing-prototypes diagnostic.
5b555da1 2140 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2141
f6095868
PE
2142 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2143 shadowing.
2144 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2145 Include <limits.h>.
2146 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2147 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2148 (load_charset_map): Mark variables that gcc -Wuninitialized
2149 does not deduce are never used uninitialized.
53df7c11 2150 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2151
f38b440c
PE
2152 * coding.c (coding_set_source, coding_set_destination):
2153 Use "else { /* comment */ }" rather than "else /* comment */;"
2154 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2155 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2156 a block, when the outer 'i' will do.
2157 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2158 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2159 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2160 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2161 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2162 Rename locals to avoid shadowing.
2163 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2164 * coding.c (emacs_mule_char, encode_invocation_designation):
2165 Now static, since they're not used elsewhere.
413bb2db 2166 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2167 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2168 (decode_coding_emacs_mule): Mark variables that gcc
2169 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2170 (detect_coding_iso_2022): Initialize a local variable that might
2171 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2172 this initialization is needed. (Bug#8211)
5f58e762
PE
2173 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2174 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2175 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2176 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2177 Remove unused macros.
f38b440c 2178
232b38b9 2179 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2180 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2181 * character.c (string_count_byte8): Likewise.
232b38b9 2182
fb90da1b
PE
2183 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2184 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2185
fb93dbc2
PE
2186 * chartab.c (copy_sub_char_table): Now static, since it's not used
2187 elsewhere.
5c156ace
PE
2188 (sub_char_table_ref_and_range, char_table_ref_and_range):
2189 Rename locals to avoid shadowing.
bbcd0949 2190 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2191
7d3b3862 2192 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2193 (BIDI_BOB): Remove unused macro.
7d3b3862 2194
6be7d3da
PE
2195 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2196 deduce are never used uninitialized.
c2ed9c8b 2197 * term.c (encode_terminal_code): Likewise.
6be7d3da 2198
75f8807f 2199 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2200
50938595
PE
2201 * tparam.h: New file.
2202 * term.c, tparam.h: Include it.
2203 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2204 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2205 Move these decls to tparam.h, and make them agree with what
2206 is actually in tparam.c. The previous trick of using incompatible
2207 decls in different modules does not conform to the C standard.
2208 All callers of tparam changed to use tparam's actual API.
2209 * tparam.c (tparam1, tparam, tgoto):
2210 Use const pointers where appropriate.
2211
fbceeba2
PE
2212 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2213 * cm.h (struct cm): Likewise.
2214 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2215 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2216 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2217 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2218 (turn_on_face, init_tty): Likewise.
2219 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2220
7f3f1250
PE
2221 * term.c (term_mouse_position): Rename local to avoid shadowing.
2222
e6ca6543
PE
2223 * alloc.c (mark_ttys): Move decl from here ...
2224 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2225
c40f8d15
AS
22262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2227
2228 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2229
cfe0661d
JB
22302011-03-09 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * search.c (compile_pattern_1): Remove argument regp, unused since
2233 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2234 (compile_pattern): Don't pass it.
2235
0afb4571
J
22362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2237
2238 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2239 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2240 for ! HAVE_GTK3.
2241 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2242
2243 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2244
2245 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2246 gdk_window_get_screen, gdk_window_get_geometry,
2247 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2248 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2249 (xg_get_pixbuf_from_pixmap): New function.
2250 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2251 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2252 Call xg_get_pixbuf_from_pixmap instead of
2253 gdk_pixbuf_get_from_drawable.
2254 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2255 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2256 (xg_check_special_colors): Use GtkStyleContext and its functions
2257 for HAVE_GTK3.
2258 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2259 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2260 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2261 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2262 Call gtk_widget_get_preferred_size.
0afb4571
J
2263 (xg_frame_resized): gdk_window_get_geometry only takes 5
2264 parameters.
44f230aa
SM
2265 (xg_win_to_widget, xg_event_is_for_menubar):
2266 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2267 (xg_set_widget_bg): New function.
2268 (delete_cb): New function.
2269 (xg_create_frame_widgets): connect delete-event to delete_cb.
2270 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2271 (xg_set_background_color): Call xg_set_widget_bg.
2272 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2273 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2274 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2275 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2276 if ! HAVE_GTK3.
2277 (update_frame_tool_bar): Call gtk_widget_hide.
2278 (xg_initialize): Use GDK_KEY_g.
2279
2280 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2281 if ! HAVE_GTK3
2282 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2283
2284 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2285 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2286 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2287
1c2cc4ef
JB
22882011-03-08 Juanma Barranquero <lekktu@gmail.com>
2289
2290 * w32xfns.c (select_palette): Check success of RealizePalette against
2291 GDI_ERROR, not zero.
2292
33383987 2293See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2294
2295;; Local Variables:
2296;; coding: utf-8
aac0c6e3
MR
2297;; End:
2298
33383987 2299 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2300
2301 This file is part of GNU Emacs.
2302
2303 GNU Emacs is free software: you can redistribute it and/or modify
2304 it under the terms of the GNU General Public License as published by
2305 the Free Software Foundation, either version 3 of the License, or
2306 (at your option) any later version.
2307
2308 GNU Emacs is distributed in the hope that it will be useful,
2309 but WITHOUT ANY WARRANTY; without even the implied warranty of
2310 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2311 GNU General Public License for more details.
2312
2313 You should have received a copy of the GNU General Public License
2314 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.