* variables.texi (File Local Variables): More hack-local-variables details.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0f4aebc0
LL
12011-05-26 Leo Liu <sdl.web@gmail.com>
2
3 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4
e61124cd
YM
52011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6
7 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8
9 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10 for fringe update if it has periodic bitmap.
11 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
12 and fringe_bitmap_periodic_p.
13
14 * fringe.c (get_fringe_bitmap_data): New function.
15 (draw_fringe_bitmap_1, update_window_fringes): Use it.
16 (update_window_fringes): Record periodicity of fringe bitmap in glyph
17 row. Mark glyph row for fringe update if periodicity changed.
18
19 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
20 for fringe update unless it has periodic bitmap.
21
f16d9837
KH
222011-05-25 Kenichi Handa <handa@m17n.org>
23
24 * xdisp.c (get_next_display_element): Set correct it->face_id for
25 a static composition.
26
e1b90ef6
LL
272011-05-24 Leo Liu <sdl.web@gmail.com>
28
29 * deps.mk (fns.o):
30 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
31
32 * fns.c (crypto_hash_function, Fsha1): New function.
33 (Fmd5): Use crypto_hash_function.
34 (syms_of_fns): Add Ssha1.
35
7400048f
PE
362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
37
38 * gnutls.c: Remove unused macros.
39 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
40 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
41 Remove macros that are defined and never used.
42 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
43
abb71cf4
CY
442011-05-22 Chong Yidong <cyd@stupidchicken.com>
45
46 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
47 (Fx_get_selection_internal): Minor cleanup.
48 (Fx_own_selection_internal): Rename arguments for consistency with
49 select.el.
50
6307db39
PE
512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
52
53 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
54
f3d4e0a4
CY
552011-05-22 Chong Yidong <cyd@stupidchicken.com>
56
57 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
58
4d8ade89
YM
592011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
60
61 * dispnew.c (scrolling_window): Don't exclude the case that the
62 last enabled row in the desired matrix touches the bottom boundary.
63
32078c8d
GM
642011-05-21 Glenn Morris <rgm@gnu.org>
65
66 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
67 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
68 and add some more files.
32078c8d 69
7285dc67
EZ
702011-05-20 Eli Zaretskii <eliz@gnu.org>
71
72 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
73 report_file_error introduced by the change from 2011-05-07.
74
89d1bd22
PE
752011-05-20 Paul Eggert <eggert@cs.ucla.edu>
76
77 * systime.h (Time): Define only if emacs is defined.
78 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
79 where the include path doesn't have X11/X.h by default. See
80 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
81
e23640bb 822011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
83
84 * composite.c (find_automatic_composition): Fix previous change.
85
b9704ad9
GM
862011-05-20 Glenn Morris <rgm@gnu.org>
87
88 * lisp.mk: New file, split from Makefile.in.
89 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
90 (shortlisp): Remove.
91 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
92
4a720484
GM
932011-05-19 Glenn Morris <rgm@gnu.org>
94
95 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
96 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
97 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
98 (lisp): Set the order to that of loadup.el.
99 (shortlisp): Make it a copy of $lisp.
100 (SOME_MACHINE_LISP): Remove.
101 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
102 Use just $shortlisp, not $SOME_MACHINE_LISP too.
103
a28d4396
KH
1042011-05-18 Kenichi Handa <handa@m17n.org>
105
106 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
107 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
108 (find_automatic_composition): Mostly rewrite for efficiency.
109
a2b1fa8e
JB
1102011-05-18 Juanma Barranquero <lekktu@gmail.com>
111
112 * makefile.w32-in: Update dependencies.
113
8e1f5610
CS
1142011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
115
116 * menu.c: Include limits.h (fixes the MS-Windows build broken by
117 revision 104625).
118
7025ee00 1192011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 120
cdfa6eab
PE
121 Fix some integer overflow issues, such as string length overflow.
122
06d6db33
PE
123 * insdel.c (count_size_as_multibyte): Check for string overflow.
124
2b4560a8
PE
125 * character.c (lisp_string_width): Check for string overflow.
126 Use EMACS_INT, not int, for string indexes and lengths; in
127 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
128 the resulting string length overflows an EMACS_INT; instead,
129 report a string overflow if no precision given. When checking for
130 precision exhaustion, use a check that cannot possibly have
131 integer overflow. (Bug#8675)
132 * character.h (lisp_string_width): Adjust to new signature.
133
cb93f9be
PE
134 * alloc.c (string_overflow): New function.
135 (Fmake_string): Use it. This doesn't change behavior, but saves
136 a few bytes and will simplify future changes.
137 * character.c (string_escape_byte8): Likewise.
138 * lisp.h (string_overflow): New decl.
139
1a1f3366
PE
140 Fixups, following up to the user-interface timestamp change.
141 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
142 for UI timestamps, instead of unsigned long.
9fbd6841
PE
143 * msdos.c (mouse_get_pos): Likewise.
144 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
145 * w32gui.h (Time): Define by including "systime.h" rather than by
146 declaring it ourselves. (Bug#8664)
147
d4e3e4d3
PE
148 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
149 * image.c (clear_image_cache): Likewise.
150
f6a24d19
PE
151 * term.c (term_mouse_position): Don't assume time_t wraparound.
152
08dc5ae6
PE
153 Be more systematic about user-interface timestamps.
154 Before, the code sometimes used 'Time', sometimes 'unsigned long',
155 and sometimes 'EMACS_UINT', to represent these timestamps. This
156 change causes it to use 'Time' uniformly, as that's what X uses.
157 This makes the code easier to follow, and makes it easier to catch
158 integer overflow bugs such as Bug#8664.
159 * frame.c (Fmouse_position, Fmouse_pixel_position):
160 Use Time, not unsigned long, for user-interface timestamps.
161 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
162 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
163 * keyboard.h (last_event_timestamp): Likewise.
164 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
165 * menu.h (xmenu_show): Likewise.
166 * term.c (term_mouse_position): Likewise.
167 * termhooks.h (struct input_event.timestamp): Likewise.
168 (struct terminal.mouse_position_hook): Likewise.
169 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
170 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
171 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
172 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
173 what it was before.
174 * menu.h, termhooks.h: Include "systime.h", for Time.
175
8e55734a
PE
176 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
177 Don't assume that the difference between two unsigned long values
178 can fit into an integer. At this point, we know button_down_time
179 <= event->timestamp, so the difference must be nonnegative, so
180 there's no need to cast the result if double-click-time is
181 nonnegative, as it should be; check that it's nonnegative, just in
182 case. This bug is triggered when events are more than 2**31 ms
86db42d2 183 apart (about 25 days). (Bug#8664)
8e55734a 184
841f1b75 185 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 186 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 187
3e26f69c
PE
188 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
189 that always fit in int. Use a sentinel instead of a counter, to
190 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
191 * frame.h (struct frame): Use int for menu_bar_items_used
192 instead of EMACS_INT, since it always fits in int.
3e26f69c 193
5cc152c0
PE
194 * menu.c (grow_menu_items): Check for int overflow.
195
d89eb65e
PE
196 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
197
5235bd3e
PE
198 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
199 Before, the code was not consistent. These values cannot exceed
200 2**31 - 1 so there's no need to make them unsigned.
201 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
202 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
203 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
204 as modifiers.
205 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
206
bc827e23
PE
207 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
208 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
209 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
210 presumably because the widths might not match.
211
78eb494e
PE
212 * window.c (size_window): Avoid needless test at loop start.
213
04f2d78b
CB
2142011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
215
216 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
217
d2fc7e3d 2182011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
219
220 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
221
d2fc7e3d 2222011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
223
224 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
225 `width' to `bar_area_x' and `bar_area_width', respectively.
226 (x_scroll_run): Take account of fringe background extension.
227
04f2d78b
CB
228 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
229 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
230 `bar_area_width', respectively.
231 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
232 background extension.
233
79b70037
GM
2342011-05-10 Jim Meyering <meyering@redhat.com>
235
236 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
237
2f142cc5
JB
2382011-05-10 Juanma Barranquero <lekktu@gmail.com>
239
240 * image.c (Finit_image_library): Return t for built-in image types,
241 like pbm and xbm. (Bug#8640)
242
57679c86
AS
2432011-05-09 Andreas Schwab <schwab@linux-m68k.org>
244
245 * w32menu.c (set_frame_menubar): Fix submenu allocation.
246
888c9e86
EZ
2472011-05-07 Eli Zaretskii <eliz@gnu.org>
248
b0512a1d
EZ
249 * w32console.c (Fset_screen_color): Doc fix.
250 (Fget_screen_color): New function.
251 (syms_of_ntterm): Defsubr it.
252
7285dc67
EZ
253 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
254 unlink the temporary file if Fcall_process didn't create it in the
255 first place.
256 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
257 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
258 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
259 cue to call_process_cleanup not to close that handle.
260
4d3fcc8e
BK
2612011-05-07 Ben Key <bkey76@gmail.com>
262
263 * makefile.w32-in: The bootstrap-temacs rule now makes use of
264 one of two shell specific rules, either bootstrap-temacs-CMD or
265 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
266 to the previous implementation of the bootstrap-temacs rule.
267 The bootstrap-temacs-CMD rule is similar to the previous
268 implementation of the bootstrap-temacs rule except that it
269 makes use of the ESC_CFLAGS variable instead of the CFLAGS
270 variable.
271
272 These changes, along with some changes to nt/configure.bat,
273 nt/gmake.defs, and nt/nmake.defs, are required to extend my
274 earlier fix to add support for --cflags and --ldflags options
275 that include quotes so that it works whether make uses cmd or
276 sh as the shell.
277
b4289b64
MA
2782011-05-06 Michael Albinus <michael.albinus@gmx.de>
279
280 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
281 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
282 is a constant.
283 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
284 a string. Handle both cases.
285 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
286 (Fdbus_register_method): Use Qinvalid_function.
287
af4c0e28
JB
2882011-05-06 Juanma Barranquero <lekktu@gmail.com>
289
290 * makefile.w32-in: Update dependencies.
291 (LISP_H): Add inttypes.h and stdin.h.
292 (PROCESS_H): Add unistd.h.
293
c51453d9
EZ
2942011-05-06 Eli Zaretskii <eliz@gnu.org>
295
296 * lread.c: Include limits.h (fixes the MS-Windows build broken by
297 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
298
8ff0ac3c 2992011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 300
4c4b566b
PE
301 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
302
aab2b9b5
PE
303 * term.c (vfatal): Remove stray call to va_end.
304 It's not needed and the C Standard doesn't allow it here anyway.
305
c378da0b
PE
306 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
307 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
308
288b08c7
PE
309 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
310 bytes.
311
e3601888
PE
312 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
313
db6c0e74
PE
314 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
315
dd5963ea
PE
316 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
317
88c9450f
PE
318 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
319
2f9442b8
PE
320 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
321
c032b5f8
PE
322 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
323 * charset.c (Fdefine_charset_internal): Don't initialize
324 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 325 32-bit int (Bug#8600).
a108c10b
PE
326
327 * lread.c (read_integer): Be more consistent with string-to-number.
328 Use string_to_number to do the actual conversion; this avoids
329 rounding errors and fixes some other screwups. Without this fix,
330 for example, #x1fffffffffffffff was misread as -2305843009213693952.
331 (digit_to_number): Move earlier, for benefit of read_integer.
332 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 333 not a digit in any supported base. (Bug#8602)
a108c10b 334
ad5f9eea
PE
335 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
336
aec1708a
PE
337 * dispnew.c (scrolling_window): Return 1 if we scrolled,
338 to match comment at start of function. This also removes a
339 GCC warning about overflow in a 32+64-bit port.
340
47be4ab5
PE
341 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
342
371cac43
PE
343 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
344 Reported by Stefan Monnier in
345 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
346 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
347 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 348
d01a7826
PE
349 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
350 (EMACS_UINTPTR): Likewise, with uintptr_t.
351
7fd47d5c
PE
352 * lisp.h: Prefer 64-bit EMACS_INT if available.
353 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
354 on 32-bit hosts that have 64-bit int, so that they can access
355 large files.
122b0c86
PE
356 However, temporarily disable this change unless the temporary
357 symbol WIDE_EMACS_INT is defined.
7fd47d5c 358
8727937b
PE
359 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
360
8ac068ac
PE
361 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
362 This removes an assumption that EMACS_INT and long are the same
363 width as pointers. The assumption is true for Emacs porting targets
364 now, but we want to make other targets possible.
365 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
366 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
367 In the rest of the code, change types of integers that hold casted
368 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
369 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
370 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
371 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
372 No need to cast type when ORing.
373 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
374 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
375 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
376 assume EMACS_INT is the same width as char *.
377 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
378 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
379 Remove no-longer-needed casts.
380 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
381 (xg_tool_bar_help_callback, xg_make_tool_item):
382 Use EMACS_INTPTR to hold an integer
383 that will be cast to void *; this can avoid a GCC warning
384 if EMACS_INT is not the same width as void *.
385 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
386 * xdisp.c (display_echo_area_1, resize_mini_window_1):
387 (current_message_1, set_message_1):
388 Use a local to convert to proper width without a cast.
389 * xmenu.c (dialog_selection_callback): Likewise.
390
ede49d71
PE
391 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
392 Also, don't assume VALBITS / RAND_BITS is less than 5,
393 and don't rely on undefined behavior when shifting a 1 left into
394 the sign bit.
395 * lisp.h (get_random): Change signature to match.
396
2f30ecd0
PE
397 * lread.c (hash_string): Use size_t, not int, for hash computation.
398 Normally we prefer signed values; but hashing is special, because
399 it's better to use unsigned division on hash table sizes so that
400 the remainder is nonnegative. Also, size_t is the natural width
401 for hashing into memory. The previous code used 'int', which doesn't
402 retain enough info to hash well into very large tables.
403 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
404
2a866e7b
PE
405 * dbusbind.c: Don't possibly lose pointer info when converting.
406 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
407 Use XPNTR rather than XHASH, so that the high-order bits of
408 the pointer aren't lost when converting through void *.
409
51639eac
PE
410 * eval.c (Fautoload): Don't double-shift a pointer.
411
92394119
PE
412 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
413
dbdb9a7c
JB
4142011-05-06 Juanma Barranquero <lekktu@gmail.com>
415
416 * gnutls.c (DEF_GNUTLS_FN):
417 * image.c (DEF_IMGLIB_FN): Make function pointers static.
418
db7a0b4f
AS
4192011-05-05 Andreas Schwab <schwab@linux-m68k.org>
420
421 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
422 marker. (Bug#8610)
423
f7ff1b0f 4242011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
425
426 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
427 New version that can reserve upto 2GB of heap space.
428
f7ff1b0f 4292011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
430
431 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
432
639c109b
TZ
4332011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
434
435 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
436 `gnutls_certificate_set_x509_key_file'.
437
d2127135
JB
4382011-05-05 Juanma Barranquero <lekktu@gmail.com>
439
440 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
441 Update dependencies.
442
e968f4f3
JB
4432011-05-04 Juanma Barranquero <lekktu@gmail.com>
444
445 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
446 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
447 Remove unused parameter `fildes'.
448 * process.c (read_process_output, send_process): Don't pass it.
449
84d358f0
JB
4502011-05-04 Juanma Barranquero <lekktu@gmail.com>
451
452 Fix previous change: the library cache is defined in w32.c.
453 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
454 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
455
0898ca10
JB
4562011-05-04 Juanma Barranquero <lekktu@gmail.com>
457
458 Implement dynamic loading of GnuTLS on Windows.
459
460 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
461 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
462 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
463 Declare.
464
465 * gnutls.c (Qgnutls_dll): Define.
466 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
467 (gnutls_*): Declare function pointers.
468 (init_gnutls_functions): New function to initialize function pointers.
469 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
470 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
471 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
472 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
473 (emacs_gnutls_write, emacs_gnutls_read)
474 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
475 (Fgnutls_available_p): New function.
476 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
477 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
478 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
479
480 * image.c: Include w32.h.
481 (Vimage_type_cache): Delete.
482 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
483 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
484 (w32_delayed_load): Move to w32.c.
485
486 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
487
488 * w32.c (QCloaded_from, Vlibrary_cache): Define.
489 (w32_delayed_load): Move from image.c. When loading a library, record
490 its filename in the :loaded-from property of the library id.
491 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
492 Initialize and staticpro them.
493 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
494
495 * process.c: Include lisp.h before w32.h, not after.
496 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
497 instead of gnutls_record_check_pending.
498
499 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
500
ff4de4aa
TZ
5012011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
502
503 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
504 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
505 as passed in.
506
abe95abb
JD
5072011-05-03 Jan Djärv <jan.h.d@swipnet.se>
508
509 * xterm.c (x_set_frame_alpha): Do not set property on anything
510 else than FRAME_X_OUTER_WINDOW (Bug#8608).
511
e16e55d4
JB
5122011-05-02 Juanma Barranquero <lekktu@gmail.com>
513
514 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
515
bafcf6a5
JB
5162011-05-02 Juanma Barranquero <lekktu@gmail.com>
517
518 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
519 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
520 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
521 (gnutls_global_initialized, Qgnutls_bootprop_priority)
522 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
523 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
524 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
525 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
526 (Qgnutls_bootprop_callbacks_verify): Make static.
527
e7a6747f
AS
5282011-05-01 Andreas Schwab <schwab@linux-m68k.org>
529
19ed11ba
AS
530 * callproc.c: Indentation fixup.
531
e7a6747f 532 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
533 (wait_for_termination, interruptible_wait_for_termination):
534 Move after wait_for_termination_1.
e7a6747f 535
1ef14cb4
LMI
5362011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
537
538 * sysdep.c (interruptible_wait_for_termination): New function
539 which is like wait_for_termination, but allows keyboard
540 interruptions.
541
542 * callproc.c (Fcall_process): Add (:file "file") as an option for
543 the STDOUT buffer.
544 (Fcall_process_region): Ditto.
545
330d880c
EZ
5462011-04-30 Eli Zaretskii <eliz@gnu.org>
547
8db90b73
EZ
548 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
549 rather than `XVECTOR (FOO)->size'.
550
330d880c
EZ
551 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
552 inttypes.h, as a gnulib replacement is used if it not available in
553 system headers.
554
15cbd324
EZ
5552011-04-21 Eli Zaretskii <eliz@gnu.org>
556
557 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
558 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
559 of MOST_POSITIVE_FIXNUM. (Bug#8528)
560
561 * coding.c (coding_alloc_by_realloc): Error out if destination
562 will grow beyond MOST_POSITIVE_FIXNUM.
563 (decode_coding_emacs_mule): Abort if there isn't enough place in
564 charbuf for the composition carryover bytes. Reserve an extra
565 space for up to 2 characters produced in a loop.
566 (decode_coding_iso_2022): Abort if there isn't enough place in
567 charbuf for the composition carryover bytes.
568
5692011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 570
ae940cca
EZ
571 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
572 aborting when %lld or %lll format is passed.
573 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
574 %llo or %llx format is passed. (Bug#8545)
575
03ab8921
EZ
576 * window.c (window_scroll_line_based): Use a marker instead of
577 simple variables to record original value of point. (Bug#7952)
578
afda1437
EZ
579 * doprnt.c (doprnt): Fix the case where a multibyte sequence
580 produced by %s or %c overflows available buffer space. (Bug#8545)
581
f76dee0c
PE
5822011-04-28 Paul Eggert <eggert@cs.ucla.edu>
583
584 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 585 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 586
fdc5744d
JB
5872011-04-28 Juanma Barranquero <lekktu@gmail.com>
588
589 * w32.c (init_environment): Warn about defaulting HOME to C:\.
590
638f053a
JB
5912011-04-28 Juanma Barranquero <lekktu@gmail.com>
592
593 * keyboard.c (Qdelayed_warnings_hook): Define.
594 (command_loop_1): Run `delayed-warnings-hook'
595 if Vdelayed_warnings_list is non-nil.
596 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
597 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
598
d178f871
EZ
5992011-04-28 Eli Zaretskii <eliz@gnu.org>
600
601 * doprnt.c (doprnt): Don't return value smaller than the buffer
602 size if the message was truncated. (Bug#8545).
603
b124fd93
JB
6042011-04-28 Juanma Barranquero <lekktu@gmail.com>
605
606 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
607 (Fx_window_property): #if-0 the whole functions, not just the bodies.
608
e810457d
PE
6092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
610
611 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
612
ea51cceb
JB
6132011-04-27 Juanma Barranquero <lekktu@gmail.com>
614
615 * makefile.w32-in: Update dependencies.
616
94dcfacf
EZ
6172011-04-27 Eli Zaretskii <eliz@gnu.org>
618
619 Improve `doprnt' and its usage. (Bug#8545)
620 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
621 `format_end'. Remove support for %l as a conversion specifier.
622 Don't use xrealloc. Improve diagnostics when the %l size modifier
623 is used. Update the commentary.
624
625 * eval.c (verror): Simplify calculation of size_t.
626
627 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
628 messages.
629
f61f41d7
PE
6302011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
631
632 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
633 change.
634
96fb4434
PE
6352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
636
637 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
638 This makes this file independent of the recent pseudovector change.
639
671875da 6402011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 641
69e9b5a3
PE
642 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
643
b5f869a7 644 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 645 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 646 Remove unused local.
c8926152 647 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 648
841a1577 649 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
650 GCC 4.6.0 optimizes based on type-based alias analysis.
651 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
652 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
653 != &v->size, and therefore "v->size = 1; b->size = 2; return
654 v->size;" must therefore return 1. This assumption is incorrect
655 for Emacs, since it type-puns struct Lisp_Vector * with many other
656 types. To fix this problem, this patch adds a new type struct
f904488f 657 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
658 and pseudovectors, and helps optimizing compilers not get fooled
659 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
660 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
661 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
662 the size member.
eab3844f
PE
663 (XSETPVECTYPE): Rewrite in terms of new macro.
664 (XSETPVECTYPESIZE): New macro, specifying both type and size.
665 This is a bit clearer, and further avoids the possibility of
666 undesirable aliasing.
667 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 668 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
669 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
670 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
671 (ASIZE): Now uses header.size rather than size.
672 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
673 to avoid the hassle of writing XVECTOR (foo)->header.size.
674 (struct vectorlike_header): New type.
eab3844f
PE
675 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
676 object, to help avoid aliasing.
677 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
678 (SUBRP): Likewise, since Lisp_Subr is a special case.
679 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
680 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
681 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 682 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
683 changed to be "header.size" and "header.next".
684 * buffer.h (struct buffer): Likewise.
685 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
686 * frame.h (struct frame): Likewise.
687 * process.h (struct Lisp_Process): Likewise.
688 * termhooks.h (struct terminal): Likewise.
689 * window.c (struct save_window_data, struct saved_window): Likewise.
690 * window.h (struct window): Likewise.
691 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
692 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
693 * buffer.c (init_buffer_once): Likewise.
694 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
695 special case.
696 * process.c (Fformat_network_address): Use local var for size,
697 for brevity.
698
0df1eac5
PE
699 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
700
847ab9d1 701 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
702 * data.c (atof): Remove decl; no longer used or needed.
703 (digit_to_number): Move to lread.c.
704 (Fstring_to_number): Use new string_to_number function, to be
705 consistent with how the Lisp reader treats infinities and NaNs.
706 Do not assume that floating-point numbers represent EMACS_INT
707 without losing information; this is not true on most 64-bit hosts.
708 Avoid double-rounding errors, by insisting on integers when
709 parsing non-base-10 numbers, as the documentation specifies.
710 * lisp.h (string_to_number): New decl, replacing ...
711 (isfloat_string): Remove.
bc0a5c13 712 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 713 (read1): Do not accept +. and -. as integers; this
452f4150
PE
714 appears to have been a coding error. Similarly, do not accept
715 strings like +-1e0 as floating point numbers. Do not report
716 overflow for integer overflows unless the base is not 10 which
717 means we have no simple and reliable way to continue.
718 Break out the floating-point parsing into a new
719 function string_to_number, so that Fstring_to_number parses
720 floating point numbers consistently with the Lisp reader.
04f2d78b 721 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
722 (E_CHAR, EXP_INT): Remove, replacing with ...
723 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
724 (string_to_number): New function, replacing isfloat_string.
725 This function checks for valid syntax and produces the resulting
726 Lisp float number too. Rework it so that string-to-number
bc0a5c13 727 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
728 so that overflow for non-base-10 numbers is reported only when
729 there's no portable and simple way to convert to floating point.
452f4150 730
67769ffc
PE
731 * textprop.c (set_text_properties_1): Rewrite for clarity,
732 and to avoid GCC warning about integer overflow.
733
c20db43f
PE
734 * intervals.h (struct interval): Use EMACS_INT for members
735 where EMACS_UINT might cause problems. See
736 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
737 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
738 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
739 All uses changed.
37aa2f85
PE
740 (offset_intervals): Tell GCC not to worry about length overflow
741 when negating a negative length.
c20db43f 742
2538aa2f
PE
743 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
744 (overrun_check_free): Likewise.
745
f2d3008d
PE
746 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
747 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
748 word size.
749
ec8df744
PE
750 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
751 (gnutls_make_error): Rename local to avoid shadowing.
752 (gnutls_emacs_global_deinit): ifdef out; not used.
753 (Fgnutls_boot): Use const for pointer to readonly storage.
754 Comment out unused local. Fix pointer signedness problems.
755
640ee02d
PE
756 * lread.c (openp): Don't stuff size_t into an 'int'.
757 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
758 about possible signed overflow.
759
6048fb2a
PE
760 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
761 (GDK_KEY_g): Don't define if already defined.
762 (xg_prepare_tooltip): Avoid pointer signedness problem.
763 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
764
fa3c87e1
PE
765 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
766 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
767
2172544b
PE
768 * xfns.c (Fx_window_property): Simplify a bit,
769 to make a bit faster and to avoid GCC 4.6.0 warning.
770 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
771
9b821a21
PE
772 * fns.c (internal_equal): Don't assume size_t fits in int.
773
3c616cfa
PE
774 * alloc.c (compact_small_strings): Tighten assertion a little.
775
c2982e87
PE
776 Replace pEd with more-general pI, and fix some printf arg casts.
777 * lisp.h (pI): New macro, generalizing old pEd macro to other
778 conversion specifiers. For example, use "...%"pI"d..." rather
779 than "...%"pEd"...".
780 (pEd): Remove. All uses replaced with similar uses of pI.
781 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
782 * alloc.c (check_pure_size): Don't overflow by converting size to int.
783 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
784 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
785 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
786 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
787 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
788 64-bit hosts.
789 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
790 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
791 * print.c (safe_debug_print, print_object): Likewise.
792 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
793 to int.
6f04d126
PE
794 Use pI instead of if-then-else-abort. Use %p to avoid casts,
795 avoiding the 0 flag, which is not portable.
c2982e87
PE
796 * process.c (Fmake_network_process): Use pI to avoid cast.
797 * region-cache.c (pp_cache): Likewise.
798 * xdisp.c (decode_mode_spec): Likewise.
799 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
800 behavior on 64-bit hosts with printf arg.
6f04d126 801 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
802 (x_stop_queuing_selection_requests): Likewise.
803 (x_get_window_property): Don't truncate byte count to an 'int'
804 when tracing.
0b432f21 805
5e073ec7
PE
806 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
807 here, since it parses constructs like leading '-' and spaces,
808 which are not wanted; and it overflows with large numbers.
809 Instead, simply match F[0-9]+, which is what is wanted anyway.
810
36372bf9
PE
811 * alloc.c: Remove unportable assumptions about struct layout.
812 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
813 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
814 (allocate_vectorlike, make_pure_vector): Use the new macros,
815 plus offsetof, to remove unportable assumptions about struct layout.
816 These assumptions hold on all porting targets that I know of, but
817 they are not guaranteed, they're easy to remove, and removing them
818 makes further changes easier.
819
0b432f21
PE
820 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
821 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
822 (string_overrun_cookie): Now const. Use initializers that
823 don't formally overflow signed char, to avoid warnings.
000098c1
PE
824 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
825 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
826 (allocate_buffer): Don't assume sizeof (struct buffer) is a
827 multiple of sizeof (EMACS_INT); it need not be, if
828 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 829 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 830
895009e1
JB
8312011-04-26 Juanma Barranquero <lekktu@gmail.com>
832
833 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
834
6a7a1b0b
TZ
8352011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
836
837 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 838 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
839 Reported by Paul Eggert <eggert@cs.ucla.edu>.
840
841a1577 8412011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
842
843 * lisp.h (Qdebug): List symbol.
895009e1 844 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
845 * keyboard.c (debug-on-event): New variable.
846 (handle_user_signal): Break into debugger when debug-on-event
847 matches the current signal symbol.
848
f2d3ba6f
DN
8492011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
850
851 * alloc.c (check_sblock, check_string_bytes)
852 (check_string_free_list): Convert to standard C.
853
42ce4c63
TZ
8542011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
855
856 * w32.c (emacs_gnutls_push): Fix typo.
857
825cd63c
EZ
8582011-04-25 Eli Zaretskii <eliz@gnu.org>
859
fb11d64d
EZ
860 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
861 "cast to pointer from integer of different size".
862
825cd63c
EZ
863 Improve doprnt and its use in verror. (Bug#8545)
864 * doprnt.c (doprnt): Document the set of format control sequences
865 supported by the function. Use SAFE_ALLOCA instead of always
866 using `alloca'.
867
868 * eval.c (verror): Don't limit the buffer size at size_max-1, that
869 is one byte too soon. Don't use xrealloc; instead xfree and
870 xmalloc anew.
871
e061a11b
TZ
8722011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
873
874 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
875 callbacks stage.
876
877 * gnutls.c: Renamed global_initialized to
878 gnutls_global_initialized. Added internals for the
879 :verify-hostname-error, :verify-error, and :verify-flags
880 parameters of `gnutls-boot' and documented those parameters in the
881 docstring. Start callback support.
882 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
883 unless a fatal error occured. Call gnutls_alert_send_appropriate
884 on error. Return error code.
885 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
886 (emacs_gnutls_read): Likewise.
887 (Fgnutls_boot): Return handshake error code.
888 (emacs_gnutls_handle_error): New function.
889 (wsaerror_to_errno): Likewise.
890
891 * w32.h (emacs_gnutls_pull): Add prototype.
892 (emacs_gnutls_push): Likewise.
893
894 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
895 (emacs_gnutls_push): Likewise.
896
8972011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
898
899 * process.c (wait_reading_process_output): Check if GnuTLS
900 buffered some data internally if no FDs are set for TLS
901 connections.
902
903 * makefile.w32-in (OBJ2): Add gnutls.$(O).
904 (LIBS): Link to USER_LIBS.
905 ($(BLD)/gnutls.$(0)): New target.
906
fa6996bc
EZ
9072011-04-24 Eli Zaretskii <eliz@gnu.org>
908
eb35682e
EZ
909 * xdisp.c (handle_single_display_spec): Rename the
910 display_replaced_before_p argument into display_replaced_p, to
911 make it consistent with the commentary. Fix typos in the
912 commentary.
913
e2ad650c
EZ
914 * textprop.c (syms_of_textprop): Remove dead code.
915 (copy_text_properties): Delete obsolete commentary about an
916 interface that was deleted long ago. Fix typos in the description
917 of arguments.
918
1b2de274
EZ
919 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
920 to changes in oldXMenu/XMenu.h from 2011-04-16.
921 <menu_help_message, prev_menu_help_message>: Constify.
922 (IT_menu_make_room): menu->help_text is now `const char **';
923 adjust.
924
925 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
926 to changes in oldXMenu/XMenu.h from 2011-04-16.
927 (struct XMenu): Declare `help_text' `const char **'.
928
929 * xfaces.c <Qunspecified>: Make extern again.
930
931 * syntax.c: Include sys/types.h before including regex.h, as
932 required by Posix.
933
762b15be
EZ
934 * doc.c (get_doc_string): Improve the format passed to `error'.
935
936 * doprnt.c (doprnt): Improve commentary.
937
938 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
939
940 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
941 them with etags.
942
f1052e5d
EZ
943 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
944 changes in globals.h immediately force recompilation.
762b15be
EZ
945 (TAGS): Depend on $(CURDIR)/m/intel386.h and
946 $(CURDIR)/s/ms-w32.h.
947 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 948
fa6996bc
EZ
949 * character.c (Fchar_direction): Function deleted.
950 (syms_of_character): Don't defsubr it.
951 <char-direction-table>: Deleted.
952
e6c3da20
EZ
9532011-04-23 Eli Zaretskii <eliz@gnu.org>
954
955 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
956 * doprnt.c: Include limits.h.
957 (SIZE_MAX): New macro.
04f2d78b
CB
958 (doprnt): Return a size_t value. 2nd arg is now size_t.
959 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
960 Improve overflow protection. Support `l' modifier for integer
961 conversions. Support %l conversion. Don't assume an EMACS_INT
962 argument for integer conversions and for %c.
963
964 * lisp.h (doprnt): Restore prototype.
965
966 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
967 $(SRC)/character.h.
968
969 * Makefile.in (base_obj): Add back doprnt.o.
970
971 * deps.mk (doprnt.o): Add back prerequisites.
972 (callint.o): Depend on character.h.
973
974 * eval.c (internal_lisp_condition_case): Include the handler
975 representation in the error message.
976 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
977 when breaking from the loop.
978
979 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
980
981 * callint.c (Fcall_interactively): When displaying error message
982 about invalid control letter, pass the character's codepoint, not
983 a pointer to its multibyte form. Improve display of the character
984 in octal and display also its hex code.
985
986 * character.c (char_string): Use %x to display the (unsigned)
987 codepoint of an invalid character, to avoid displaying a bogus
988 negative value.
989
990 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
991 `error', not SYMBOL_NAME itself.
992
993 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
994 character arguments to `error'.
995
996 * charset.c (check_iso_charset_parameter): Fix incorrect argument
997 to `error' in error message about FINAL_CHAR argument. Make sure
998 FINAL_CHAR is a character, and use %c when it is passed as
999 argument to `error'.
1000
4ffd0d6b 10012011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1002
1003 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1004
1005 * w32.c: Include <time.h>.
1006 (sys_localtime): New function.
1007
4ffd0d6b 10082011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1009
1010 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1011
4ffd0d6b 1012 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1013
4ffd0d6b 10142011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1015
4ffd0d6b
GM
1016 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1017 zombies (Bug#8467).
aac0c6e3 1018
04c56954
EZ
10192011-04-19 Eli Zaretskii <eliz@gnu.org>
1020
1021 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1022 gl_state.e_property when gl_state.object is Qt.
1023
1024 * insdel.c (make_gap_larger): Remove limitation of buffer size
1025 to <= INT_MAX.
1026
16a43933
CY
10272011-04-18 Chong Yidong <cyd@stupidchicken.com>
1028
1029 * xdisp.c (lookup_glyphless_char_display)
1030 (produce_glyphless_glyph): Handle cons cell entry in
1031 glyphless-char-display.
1032 (Vglyphless_char_display): Document it.
1033
1034 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1035 glyphless-char-display.
1036
4581706e
CY
10372011-04-17 Chong Yidong <cyd@stupidchicken.com>
1038
1039 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1040
1041 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1042
1043 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1044 definition for no-X builds.
1045
4887c6e2 10462011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1047
fd35b6f9
PE
1048 Static checks with GCC 4.6.0 and non-default toolkits.
1049
5c1ccb01
PE
1050 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1051
006c5daa
PE
1052 * process.c (keyboard_bit_set): Define only if SIGIO.
1053 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1054 (send_process): Repair possible setjmp clobbering.
1055
efc736d3
PE
1056 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1057
4e2fe2e6
PE
1058 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1059
f97334a2
PE
1060 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1061
4e75f29d
PE
1062 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1063 Define only if needed.
1064
90efadd1
PE
1065 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1066 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1067 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1068
3c647824
PE
1069 * dispextern.h (struct redisplay_interface): Rename param
1070 to avoid shadowing.
e264f262 1071 * termhooks.h (struct terminal): Likewise.
761383f4 1072 * xterm.c (xembed_send_message): Likewise.
3c647824 1073
b58c5c4a
PE
1074 * insdel.c (make_gap_smaller): Define only if
1075 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1076
cad59032
PE
1077 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1078 it.
1079
c339dc2e
PE
1080 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1081 so that we aren't warned about unused symbols.
1082
91a3e27b
PE
1083 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1084
399c71d3 1085 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1086
8ffc96f5
PE
1087 * xfns.c (x_real_positions): Mark locals as initialized.
1088
eef9bc79
PE
1089 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1090
098db9dd
PE
1091 * xterm.c: Fix problems found by static analysis with other toolkits.
1092 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1093 (x_dispatch_event): Declare static if USE_GTK, and
1094 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1095 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1096 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1097 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1098 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1099
eb18f6cc
PE
1100 * xmenu.c (menu_help_callback): Pointer type fixes.
1101 Use const pointers when pointing at readonly data. Avoid pointer
1102 signedness clashes.
1103 (FALSE): Remove unused macro.
1104 (update_frame_menubar): Remove unused decl.
1105
1fe72bf8
PE
1106 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1107
60d9e1db
PE
1108 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1109 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1110 (single_menu_item): Rename local to avoid shadowing.
1111
39261c26
PE
1112 * keyboard.c (make_lispy_event): Remove unused local var.
1113
018c5e19
PE
1114 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1115 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1116
63d2b86e
PE
1117 * bitmaps: Change bitmaps from unsigned char back to the X11
1118 compatible char. Avoid the old compiler warnings about
1119 out-of-range initializers by using, for example, '\xab' rather
1120 than 0xab.
1121
aefd87e1
PE
1122 * xgselect.c (xgselect_initialize): Check vs interface
1123 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1124
bf501fb9
PE
1125 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1126
e9829fdf
PE
1127 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1128 to read-only memory.
1129
1086c095
PE
1130 * fns.c (vector): Remove; this old hack is no longer needed.
1131
2baccd04 1132 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1133 Remove unused var.
dde42981 1134 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1135
72391843 1136 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1137
436c16df 1138 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1139 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1140 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1141
92bb796d 1142 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1143 (x_term_init): Remove local to avoid shadowing.
92bb796d 1144
764430a3 1145 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1146
1147 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1148 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1149
d1dfb56c
EZ
11502011-04-16 Eli Zaretskii <eliz@gnu.org>
1151
c4354cb4
EZ
1152 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1153
d1dfb56c
EZ
1154 Fix regex.c, syntax.c and friends for buffers > 2GB.
1155 * syntax.h (struct gl_state_s): Declare character position members
1156 EMACS_INT.
1157
1158 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1159
04f2d78b
CB
1160 * textprop.c (verify_interval_modification, interval_of):
1161 Declare arguments EMACS_INT.
d1dfb56c
EZ
1162
1163 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1164 EMACS_INT.
1165
1166 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1167
1168 * indent.c (Fvertical_motion): Local variable it_start is now
1169 EMACS_INT.
1170
1171 * regex.c (re_match, re_match_2, re_match_2_internal)
1172 (bcmp_translate, regcomp, regexec, print_double_string)
1173 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1174 (re_compile_pattern, re_exec): Declare arguments and local
1175 variables `size_t' and `ssize_t' and return values `regoff_t', as
1176 appropriate.
1177 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1178 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1179 <compile_stack_type>: `size' and `avail' are now `size_t'.
1180
1181 * regex.h <regoff_t>: Use ssize_t, not int.
1182 (re_search, re_search_2, re_match, re_match_2): Arguments that
1183 specify buffer/string position and length are now ssize_t and
1184 size_t. Return type is regoff_t.
1185
613052cd
BK
11862011-04-16 Ben Key <bkey76@gmail.com>
1187
1188 * nsfont.m: Fixed bugs in ns_get_family and
1189 ns_descriptor_to_entity that were caused by using free to
1190 deallocate memory blocks that were allocated by xmalloc (via
1191 xstrdup). This caused Emacs to crash when compiled with
1192 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1193 --enable-checking=xmallocoverrun). xfree is now used to
1194 deallocate these memory blocks.
1195
4170f62f 11962011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1197
71b41406
PE
1198 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1199
9587a89d
PE
1200 emacs_write: Accept and return EMACS_INT for sizes.
1201 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1202 et seq.
1203 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1204 Accept and return EMACS_INT.
1205 (emacs_gnutls_write): Return the number of bytes written on
1206 partial writes.
1207 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1208 (emacs_read, emacs_write): Remove check for negative size, as the
1209 Emacs source code has been audited now.
9587a89d
PE
1210 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1211 (emacs_read, emacs_write): Use it.
273a5f82
PE
1212 * process.c (send_process): Adjust to the new signatures of
1213 emacs_write and emacs_gnutls_write. Do not attempt to store
1214 a byte offset into an 'int'; it might overflow.
9587a89d 1215 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1216
3e047f51
PE
1217 * sound.c: Don't assume sizes fit in 'int'.
1218 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1219 Return EMACS_INT, not int.
3e047f51 1220 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1221 Accept EMACS_INT, not int.
1222 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1223 record read return values.
1224
cc39a9db
BK
12252011-04-15 Ben Key <bkey76@gmail.com>
1226
c9d0ec6d
JB
1227 * keyboard.c (Qundefined): Don't declare static since it is used
1228 in nsfns.m.
1229 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1230 static since they are used in nsfont.m.
cc39a9db 1231
6c60eb9f
SM
12322011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1233
1234 * process.c (Qprocessp): Don't declare static.
1235 * lisp.h (Qprocessp): Declare again.
1236
7990b61a
JB
12372011-04-15 Juanma Barranquero <lekktu@gmail.com>
1238
1239 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1240
5d4cb038
PE
12412011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1242
8bd7b830 1243 Improve C-level modularity by making more things 'static'.
cd64ea1d 1244
e3b27b31
PE
1245 Don't publish debugger-only interfaces to other modules.
1246 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1247 (verify_bytepos, count_markers): Move decls to the only modules
1248 that need them.
1249 * region-cache.h (pp_cache): Likewise.
1250 * window.h (check_all_windows): Likewise.
1251 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1252
5d4cb038
PE
1253 * sysdep.c (croak): Now static, if
1254 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1255 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1256
1257 * alloc.c (refill_memory_reserve): Now static if
1258 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1259 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1260
e87b6180
PE
1261 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1262 Define only if USE_LUCID.
1263
ac64929e
PE
1264 * xrdb.c (x_customization_string, x_rm_string): Now static.
1265
6f37259d
PE
1266 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1267 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1268
1683e3ab
PE
1269 * xdisp.c (draw_row_with_mouse_face): Now static.
1270 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1271
de9c2632
PE
1272 * window.h (check_all_windows): Mark externally visible.
1273
2b96acb7
PE
1274 * window.c (window_deletion_count): Now static.
1275
1276 * undo.c: Make symbols static if they're not exported.
1277 (last_undo_buffer, last_boundary_position, pending_boundary):
1278 Now static.
1279
50436f33
PE
1280 * textprop.c (interval_insert_behind_hooks): Now static.
1281 (interval_insert_in_front_hooks): Likewise.
1282
64520e5c
PE
1283 * term.c: Make symbols static if they're not exported.
1284 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1285 (max_frame_lines, tty_set_terminal_modes):
1286 (tty_reset_terminal_modes, tty_turn_off_highlight):
1287 (get_tty_terminal): Now static.
1288 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1289 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1290 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1291 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1292 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1293
1fa53021
PE
1294 * sysdep.c: Make symbols static if they're not exported.
1295 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1296 Now static.
1297 (sigprocmask_set, full_mask): Remove; unused.
1298 (wait_debugging): Mark as visible.
1299 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1300 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1301
d4b43b22
PE
1302 * syntax.c (syntax_temp): Define only if !__GNUC__.
1303
b7c513d0
PE
1304 * sound.c (current_sound_device, current_sound): Now static.
1305
989b29ad
PE
1306 * search.c (searchbufs, searchbuf_head): Now static.
1307
13a55a78
PE
1308 * scroll.c (scroll_cost): Remove; unused.
1309 * dispextern.h (scroll_cost): Remove decl.
1310
de68a1fc
PE
1311 * region-cache.h (pp_cache): Mark as externally visible.
1312
40ccffa6
PE
1313 * process.c: Make symbols static if they're not exported.
1314 (process_tick, update_tick, create_process, chan_process):
1315 (Vprocess_alist, proc_buffered_char, datagram_access):
1316 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1317 (deactivate_process): Mark defn as static, as well as decl.
1318 * lisp.h (create_process): Remove decl.
1319 * process.h (chan_process, Vprocess_alist): Remove decls.
1320
ad64fc97
PE
1321 * print.c: Make symbols static if they're not exported.
1322 (print_depth, new_backquote_output, being_printed, print_buffer):
1323 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1324 (print_interval, print_number_index, initial_stderr_stream):
1325 Now static.
1326 * lisp.h (Fprinc): Remove decl.
1327 (debug_output_compilation_hack): Mark as externally visible.
1328
adddb265
PE
1329 * sysdep.c (croak): Move decl from here to syssignal.h.
1330 * syssignal.h (croak): Put it here, so the API can be checked when
1331 'croak' is called from dissociate_if_controlling_tty.
1332
1717ede2
PE
1333 * minibuf.c: Make symbols static if they're not exported.
1334 (minibuf_save_list, choose_minibuf_frame): Now static.
1335 * lisp.h (choose_minibuf_frame): Remove decl.
1336
fa5fb2bc
PE
1337 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1338
1e3890d1
PE
1339 * lread.c: Make symbols static if they're not exported.
1340 (read_objects, initial_obarray, oblookup_last_bucket_number):
1341 Now static.
1342 (make_symbol): Remove; unused.
1343 * lisp.h (initial_obarray, make_symbol): Remove decls.
1344
8a1414fa
PE
1345 * keyboard.c: Make symbols static if they're not exported.
1346 (single_kboard, recent_keys_index, total_keys, recent_keys):
1347 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1348 (this_single_command_key_start, echoing, last_auto_save):
1349 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1350 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1351 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1352 (Vlispy_mouse_stem, double_click_count):
1353 Now static.
1354 (force_auto_save_soon): Define only if SIGDANGER.
1355 (ignore_mouse_drag_p): Now static if
1356 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1357 (print_help): Remove; unused.
1358 (stop_character, last_timer_event): Mark as externally visible.
1359 * keyboard.h (ignore_mouse_drag_p): Declare only if
1360 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1361 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1362 * lisp.h (echoing): Remove decl.
1363 (force_auto_save_soon): Declare only if SIGDANGER.
1364 * xdisp.c (redisplay_window): Simplify code, to make it more
1365 obvious that ignore_mouse_drag_p is not accessed if !defined
1366 USE_GTK && !defined HAVE_NS.
1367
93ea6e8f
PE
1368 * intervals.c: Make symbols static if they're not exported.
1369 (merge_properties_sticky, merge_interval_right, delete_interval):
1370 Now static.
1371 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1372
77382fcc
PE
1373 * insdel.c: Make symbols static if they're not exported.
1374 However, leave prepare_to_modify_buffer alone. It's never
1375 called from outside this function, but that appears to be a bug.
1376 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1377 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1378 (adjust_after_replace_noundo): Remove; unused.
1379 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1380 (signal_before_change): Remove decls.
77382fcc 1381
9306c32e
PE
1382 * indent.c (val_compute_motion, val_vmotion): Now static.
1383
cd44d2eb
PE
1384 * image.c: Make symbols static if they're not exported.
1385 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1386 if USE_GTK.
1387 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1388 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1389
ad9a7a06
PE
1390 * fringe.c (standard_bitmaps): Now static.
1391 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1392
81626931
PE
1393 * frame.c: Make symbols static if they're not exported.
1394 (x_report_frame_params, make_terminal_frame): Now static.
1395 (get_frame_param): Now static, unless HAVE_NS.
1396 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1397 (x_get_resource_string): Remove; not used.
1398 * frame.h (make_terminal_frame, x_report_frame_params):
1399 (x_get_resource_string); Remove decls.
1400 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1401 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1402
239f9db9
PE
1403 * font.c, fontset.c: Make symbols static if they're not exported.
1404 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1405 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1406 * font.c (font_close_object): Now static.
1407 * font.h (font_close_object): Remove.
1408 * fontset.c (FONTSET_OBJLIST): Remove.
1409 (free_realized_fontset) #if-0 the body, which does nothing.
1410 (face_suitable_for_char_p): #if-0, as it's never called.
1411 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1412 * xfaces.c (face_at_string_position):
1413 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1414 since 0 is always ASCII.
1415
dfcf3579
PE
1416 * fns.c (weak_hash_tables): Now static.
1417
5045092b
PE
1418 * fileio.c: Make symbols static if they're not exported.
1419 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1420 (Vwrite_region_annotation_buffers): Now static.
1421
57a96f5c
PE
1422 * eval.c: Make symbols static if they're not exported.
1423 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1424 * lisp.h (backtrace_list): Remove decl.
1425
35f08c38
PE
1426 * emacs.c: Make symbols static if they're not exported.
1427 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1428 (fatal_error_code, fatal_error_signal_hook, standard_args):
1429 Now static.
1430 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1431 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1432 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1433 * lisp.h (fatal_error_signal_hook): Remove decl.
1434 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1435
f44bd759
PE
1436 * editfns.c: Move a (normally-unused) function to its only use.
1437 * editfns.c, lisp.h (get_operating_system_release): Remove.
1438 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1439 worth the hassle of breaking this out.
1440
b532497d
PE
1441 * xterm.c: Make symbols static if they're not exported.
1442 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1443 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1444 (x_destroy_window, x_delete_display):
1445 Now static.
1446 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1447 (x_mouse_leave): Remove; unused.
1448 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1449 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1450 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1451 Remove decls.
1452 (x_mouse_leave): Declare only if WINDOWSNT.
1453 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1454 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1455 USE_X_TOOLKIT.
1456
1675728f
PE
1457 * ftxfont.c: Make symbols static if they're not exported.
1458 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1459 HAVE_FREETYPE.
1460 * font.h (ftxfont_driver): Likewise.
1461
e4cebfca
PE
1462 * xfns.c: Make symbols static if they're not exported.
1463 (x_last_font_name, x_display_info_for_name):
1464 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1465 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1466 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1467 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1468 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1469 (last_show_tip_args): Now static.
1470 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1471 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1472 (x_screen_planes): Remove; unused.
1473 * dispextern.h (x_screen_planes): Remove decl.
1474
5bf46f05
PE
1475 * dispnew.c: Make symbols static if they're not exported.
1476 * dispextern.h (redraw_garbaged_frames, scrolling):
1477 (increment_row_positions): Remove.
1478 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1479 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1480 Now static.
1481 (redraw_garbaged_frames): Remove; unused.
1482
435f4c28
PE
1483 * xfaces.c: Make symbols static if they're not exported.
1484 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1485 Remove decls.
1486 * xterm.h (defined_color): Remove decls.
1487 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1488 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1489 (menu_face_changed_default, defined_color, free_realized_face):
1490 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1491 (ascii_face_of_lisp_face): Remove; unused.
1492
8524aef3
PE
1493 * xdisp.c: Make symbols static if they're not exported.
1494 * dispextern.h (scratch_glyph_row, window_box_edges):
1495 (glyph_to_pixel_coords, set_cursor_from_row):
1496 (get_next_display_element, set_iterator_to_next):
1497 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1498 (show_mouse_face): Remove decls
1499 * frame.h (message_buf_print): Likewise.
1500 * lisp.h (pop_message, set_message, check_point_in_composition):
1501 Likewise.
1502 * xterm.h (set_vertical_scroll_bar): Likewise.
1503 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1504 (message_buf_print, scratch_glyph_row, displayed_buffer):
1505 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1506 (get_next_display_element, show_mouse_face, window_box_edges):
1507 (frame_to_window_pixel_xy, check_point_in_composition):
1508 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1509 (glyph_to_pixel_coords): Remove; unused.
1510
16390cd2
PE
1511 * dired.c (file_name_completion): Now static.
1512
1513 * dbusbind.c (xd_in_read_queued_messages): Now static.
1514
a25f4dfa
PE
1515 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1516 * data.c (circular_list_error): Remove.
1517
14a9c8df
PE
1518 * commands.h (last_point_position, last_point_position_buffer):
1519 (last_point_position_window): Remove decls.
1520 * keyboard.c: Make these variables static.
1521
04f2d78b
CB
1522 * coding.h (coding, code_convert_region, encode_coding_gap):
1523 Remove decls.
74ab6df5
PE
1524 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1525 (iso_code_class, detect_coding, code_convert_region): Now static.
1526 (encode_coding_gap): Remove; unused.
1527
38dfbee1
PE
1528 * chartab.c (chartab_chars, chartab_bits): Now static.
1529
a2cb4e63
PE
1530 * charset.h (charset_iso_8859_1): Remove decl.
1531 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1532 Now static.
1533
127198fd
PE
1534 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1535 * ccl.c (Vccl_program_table): Now static.
1536 (check_ccl_update): Remove; unused.
1537
d85b608f
PE
1538 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1539 * category.h: ... from here.
1540 * category.c (check_category_table, set_category_set): Now static.
1541
31cd66f3
PE
1542 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1543 * lisp.h: Remove these decls.
1544
c358e587
PE
1545 * buffer.c (buffer_count): Remove unused var.
1546
e78aecca
PE
1547 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1548 so that it's not optimized away.
1549 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1550 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1551 exported only to the debugger.
1552
e192d7d3 1553 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1554 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1555
92470028
PE
1556 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1557 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1558 was inaccessible from Lisp.
1559 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1560 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1561
244ed907
PE
1562 alloc.c: Import and export fewer symbols, and remove unused items.
1563 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1564 is defined.
1565 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1566 it's not optimized away by whole-program optimization.
1567 (message_enable_multibyte, free_misc): Remove.
1568 (catchlist, handlerlist, mark_backtrace):
1569 Declare only if BYTE_MARK_STACK.
1570 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1571 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1572 (message_enable_multibyte): Remove decl.
1573 (free_misc, interval_free_list, float_block, float_block_index):
1574 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1575 (cons_free_list, last_marked_index):
1576 Now static.
1577 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1578 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1579 (mark_backtrace): Define only if BYTE_MARK_STACK.
1580 * xdisp.c (message_enable_multibyte): Now static.
1581
61c2b50e 1582 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1583 This makes it easier for human readers (and static analyzers)
1584 to see whether these variables are used from other modules.
1585 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1586 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1587 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1588 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1589 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1590 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1591 * xmenu.c, xselect.c:
1592 Declare Q* vars static if they are not used in other modules.
1593 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1594 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1595 Remove decls of unexported vars.
1596 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1597
95c82688
PE
1598 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1599
16a97296
PE
1600 Make Emacs functions such as Fatom 'static' by default.
1601 This makes it easier for human readers (and static analyzers)
1602 to see whether these functions can be called from other modules.
1603 DEFUN now defines a static function. To make the function external
1604 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1605 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1606 (Finit_image_library):
16a97296
PE
1607 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1608 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1609 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1610 Remove decls, since these functions are now static.
1611 (Funintern, Fget_internal_run_time): New decls, since these functions
1612 were already external.
95c82688 1613
16a97296
PE
1614 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1615 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1616 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1617 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1618 * keyboard.c, keymap.c, lread.c:
1619 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1620 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1621 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1622 Mark functions with DEFUE instead of DEFUN,
1623 if they are used in other modules.
1624 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1625 decls for now-static functions.
1626 * buffer.h (Fdelete_overlay): Remove decl.
1627 * callproc.c (Fgetenv_internal): Mark as internal.
1628 * composite.c (Fremove_list_of_text_properties): Remove decl.
1629 (Fcomposition_get_gstring): New forward static decl.
1630 * composite.h (Fcomposite_get_gstring): Remove decl.
1631 * dired.c (Ffile_attributes): New forward static decl.
1632 * doc.c (Fdocumntation_property): New forward static decl.
1633 * eval.c (Ffetch_bytecode): New forward static decl.
1634 (Funintern): Remove extern decl; now in .h file where it belongs.
1635 * fileio.c (Fmake_symbolic_link): New forward static decl.
1636 * image.c (Finit_image_library): New forward static decl.
1637 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1638 * intervals.h (Fprevious_property_change):
1639 (Fremove_list_of_text_properties): Remove decls.
1640 * keyboard.c (Fthis_command_keys): Remove decl.
1641 (Fcommand_execute): New forward static decl.
1642 * keymap.c (Flookup_key): New forward static decl.
1643 (Fcopy_keymap): Now static.
1644 * keymap.h (Flookup_key): Remove decl.
1645 * process.c (Fget_process): New forward static decl.
1646 (Fprocess_datagram_address): Mark as internal.
1647 * syntax.c (Fsyntax_table_p): New forward static decl.
1648 (skip_chars): Remove duplicate decl.
1649 * textprop.c (Fprevious_property_change): New forward static decl.
1650 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1651 Now internal.
1652 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1653 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1654
785bbd42
PE
1655 * editfns.c (Fformat): Remove unreachable code.
1656
8b913b57
AS
16572011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1658
1659 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1660 change. (Bug#8496)
1661
a6744a35
EZ
16622011-04-13 Eli Zaretskii <eliz@gnu.org>
1663
1664 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1665 when at ZV. (Bug#8487)
1666
e7974947
AS
16672011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1668
baad03f0
AS
1669 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1670 (Bug#8437)
1671 * keyboard.c (parse_tool_bar_item): Likewise.
1672 * sound.c (sound_cleanup, alsa_close): Likewise.
1673 * termcap.c (tgetent): Likewise.
1674 * xfns.c (x_default_font_parameter): Likewise.
1675 * xsettings.c (read_and_apply_settings): Likewise.
1676
e7974947
AS
1677 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1678 (overrun_check_free): Protoize.
1679
28272684
PE
16802011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1681
1682 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1683 since callers should never pass a negative size.
1684 Change the signature to match that of plain 'read' and 'write'; see
1685 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1686 * lisp.h: Update prototypes of emacs_write and emacs_read.
1687
11997c76
EZ
16882011-04-11 Eli Zaretskii <eliz@gnu.org>
1689
1690 * xdisp.c (redisplay_window): Don't try to determine the character
1691 position of the scroll margin if the window start point w->startp
e896f03c 1692 is outside the buffer's accessible region. (Bug#8468)
11997c76 1693
8a2cbd72
EZ
16942011-04-10 Eli Zaretskii <eliz@gnu.org>
1695
1696 Fix write-region and its subroutines for buffers > 2GB.
1697 * fileio.c (a_write, e_write): Modify declaration of arguments and
1698 local variables to support buffers larger than 2GB.
1699 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1700
1701 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1702 argument, local variables, and return value.
1703
1704 * lisp.h: Update prototypes of emacs_write and emacs_read.
1705
1706 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1707
4073e537 17082011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1709
1ebfdcb6
PE
1710 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1711
b2ded58d
PE
1712 Fix more problems found by GCC 4.6.0's static checks.
1713
7d66342c
PE
1714 * xdisp.c (vmessage): Use a better test for character truncation.
1715
bbf47d44
PE
1716 * charset.c (load_charset_map): <, not <=, for optimization,
1717 and to avoid potential problems with integer overflow.
9248994d 1718 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1719 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1720 * editfns.c (Fformat): Likewise.
1e69125e 1721 * syntax.c (skip_chars): Likewise.
3befa583 1722
e3019616
PE
1723 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1724 This also lets GCC 4.6.0 generate slightly better loop code.
1725
becfa255
PE
1726 * callint.c (Fcall_interactively): <, not <=, for optimization.
1727 (Fcall_interactively): Count the number of arguments produced,
1728 not the number of arguments given. This is simpler and lets GCC
1729 4.6.0 generate slightly better code.
1730
dae0cd48
PE
1731 * ftfont.c: Distingish more carefully between FcChar8 and char.
1732 The previous code passed unsigned char * to a functions like
1733 strlen and xstrcasecmp that expect char *, which does not
1734 conform to the C standard.
1735 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1736 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1737 char * when the C standard requires it.
1738
76032d70
PE
1739 * keyboard.c (read_char): Remove unused var.
1740
eb3f1cc8
PE
1741 * eval.c: Port to Windows vsnprintf (Bug#8435).
1742 Include <limits.h>.
1743 (SIZE_MAX): Define if the headers do not.
1744 (verror): Do not give up if vsnprintf returns a negative count.
1745 Instead, grow the buffer. This ports to Windows vsnprintf, which
1746 does not conform to C99. Problem reported by Eli Zaretskii.
1747 Also, simplify the allocation scheme, by avoiding the need for
1748 calling realloc, and removing the ALLOCATED variable.
1749
70476b54
PE
1750 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1751
12020a9e
PE
1752 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1753 But keep the doprint source code for now, as we might revamp it
1754 and use it again (Bug#8435).
ea6c7ae6
PE
1755 * lisp.h (doprnt): Remove.
1756 * Makefile.in (base_obj): Remove doprnt.o.
1757 * deps.mk (doprnt.o): Remove.
1758
5fdb398c
PE
1759 error: Print 32- and 64-bit integers portably (Bug#8435).
1760 Without this change, on typical 64-bit hosts error ("...%d...", N)
1761 was used to print both 32- and 64-bit integers N, which relied on
1762 undefined behavior.
1763 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1764 New macro.
1765 * lisp.h (error, verror): Mark as printf-like functions.
1766 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1767 Report overflow in size calculations when allocating printf buffer.
1768 Do not truncate output string at its first null byte.
1769 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1770 Truncate the output at a character boundary, since vsnprintf does not
1771 do that.
1772 * charset.c (check_iso_charset_parameter): Convert internal
1773 character to string before calling 'error', since %c now has the
1774 printf meaning.
1775 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1776 overflow when computing char to be passed to 'error'. Do not
1777 pass Lisp_Object to 'error'; pass the integer instead.
1778 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1779 formatted with plain %d.
1780
b189fa66
PE
1781 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1782
bff87ef0
PE
1783 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1784
7e2cac20
PE
1785 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1786
ce4d90b5
PE
1787 * xterm.c (x_catch_errors): Remove duplicate declaration.
1788
266c9547
PE
1789 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1790
79c49ad2
PE
1791 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1792
368f4090
JM
17932011-04-10 Jim Meyering <meyering@redhat.com>
1794
1795 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1796 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1797 return ssize_t not "int", and use size_t as the buffer length.
1798 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1799 * gnutls.h: Update declarations.
1800 * process.c (read_process_output): Use ssize_t, to match.
1801 (send_process): Likewise.
1802
a32d4040
CY
18032011-04-09 Chong Yidong <cyd@stupidchicken.com>
1804
1805 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1806
8546720e 18072011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1808
04f2d78b
CB
1809 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1810 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1811
8546720e
GM
1812 * xterm.c (handle_one_xevent):
1813 * xmenu.c (create_and_show_popup_menu):
1814 * xselect.c (x_decline_selection_request)
1815 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1816
0a2f5c1a 18172011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1818
1819 Fix some uses of `int' instead of EMACS_INT.
1820 * search.c (string_match_1, fast_string_match)
1821 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1822 (scan_buffer, find_next_newline_no_quit)
1823 (find_before_next_newline, search_command, Freplace_match)
1824 (Fmatch_data): Make some `int' variables be EMACS_INT.
1825
1826 * xdisp.c (display_count_lines): 3rd argument and return value now
1827 EMACS_INT. All callers changed.
1828 (pint2hrstr): Last argument is now EMACS_INT.
1829
1830 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1831 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1832 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1833 (decode_coding_utf_16, decode_coding_emacs_mule)
1834 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1835 (decode_coding_ccl, decode_coding_charset)
1836 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1837 (decode_coding_iso_2022, decode_coding_emacs_mule)
1838 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1839 <char_offset, last_offset>: Declare EMACS_INT.
1840 (encode_coding_utf_8, encode_coding_utf_16)
1841 (encode_coding_emacs_mule, encode_invocation_designation)
1842 (encode_designation_at_bol, encode_coding_iso_2022)
1843 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1844 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1845 Declare EMACS_INT.
1846 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1847 (encode_invocation_designation): Last argument P_NCHARS is now
1848 EMACS_INT.
1849 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1850 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1851
1852 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1853 All users changed.
1854
1855 * ccl.c (Fccl_execute_on_string): Declare some variables
1856 EMACS_INT.
1857
8546720e 18582011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1859
1860 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1861
4e19a977
CS
18622011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1863
1864 * process.c (Fformat_network_address): Doc fix.
1865
87302331
R
18662011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1867
1868 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1869
cbb59342
CY
18702011-04-08 Chong Yidong <cyd@stupidchicken.com>
1871
1872 * keyboard.c (read_char): Call Lisp function help-form-show,
1873 instead of using internal_with_output_to_temp_buffer.
1874 (Qhelp_form_show): New var.
e0d38eeb 1875 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1876
1877 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1878
1879 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1880
e67a13ab
CY
18812011-04-06 Chong Yidong <cyd@stupidchicken.com>
1882
04f2d78b
CB
1883 * process.c (Flist_processes): Remove to Lisp.
1884 (list_processes_1): Delete.
e67a13ab 1885
973f782d
EZ
18862011-04-06 Eli Zaretskii <eliz@gnu.org>
1887
7c106b1e
EZ
1888 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1889
973f782d
EZ
1890 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1891
41cf7d1a 18922011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1893
ca23cc88
PE
1894 Fix more problems found by GCC 4.6.0's static checks.
1895
f390e2d5
PE
1896 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1897
42eea0d0
PE
1898 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1899
b69769da 1900 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1901
f9541e84
PE
1902 * xdisp.c (vmessage): Mark as a printf-like function.
1903
13841b55
PE
1904 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1905
c136c10f
PE
1906 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1907
5e2d4a30
PE
1908 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1909 printf-like functions.
1910 (tiff_load): Add casts to remove these marks before passing them
1911 to system-supplied API.
1912
583f48b9
PE
1913 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1914
b25d760e
PE
1915 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1916 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1917 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1918 directly, rather than having caller test rule sign. This avoids
1919 some unnecessary tests.
1920 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1921 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1922 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1923
bc7b6697 1924 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1925 (xfont_open): Avoid unnecessary tests.
bc7b6697 1926
27ccc379
PE
1927 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1928
dcd5c89a
PE
1929 * composite.h, composite.c (composition_gstring_put_cache):
1930 Use EMACS_INT, not int, for length.
1931
b13a45c6
PE
1932 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1933 breaking out part of COMPOSITION_DECODE_RULE.
1934 (COMPOSITION_DECODE_RULE): Use it.
1935 * composite.c (get_composition_id): Remove unused local vars,
1936 by using the new macro.
1937
1e792e4d
PE
1938 * textprop.c (set_text_properties_1): Change while to do-while,
1939 since the condition is always true at first.
1940
dc6c6455 1941 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1942 (interval_deletion_adjustment): Return unsigned value.
1943 All uses changed.
dc6c6455 1944
aba7731a
PE
1945 * process.c (list_processes_1, create_pty, read_process_output):
1946 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1947 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1948 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1949 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1950 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1951
fdfc4bf3
PE
1952 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1953
fca8fe46 1954 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1955 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1956
06a0259a 1957 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1958 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1959 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1960
e7b9e80f
PE
1961 * print.c (print_error_message): Avoid int overflow.
1962
56201685
PE
1963 * font.c (font_list_entities): Redo for clarity,
1964 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1965
78834453 1966 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1967 (font_score): Avoid potential overflow in diff calculation.
78834453 1968
0bc0b309 1969 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1970 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1971
e610eaca
PE
1972 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1973
b895abce
PE
1974 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1975 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1976 can always succeed if overflow has undefined behavior.
1977
1f1d9321 1978 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1979 (wordify): Omit three unnecessary tests.
1f1d9321 1980
c59478bc
PE
1981 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1982 All callers changed. This avoids the need for an unused var.
1983
79b73827
PE
1984 * casefiddle.c (casify_region): Remove var that is set but not used.
1985
a4db5dfe
PE
1986 * dired.c (file_name_completion): Remove var that is set but not used.
1987
43aae36e
PE
1988 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1989
2a47c44d 1990 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1991 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1992
a37c69bf
PE
1993 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1994 Check for integer overflow on size calculations.
1995
328ab8e7
PE
1996 * buffer.c (Fprevious_overlay_change): Remove var that is set
1997 but not used.
1998
e5a2a5cb
PE
1999 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2000 Remove vars that are set but not used.
8d84a6eb 2001 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2002 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2003
a60e5f68
PE
2004 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2005
f661cb61 2006 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2007 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2008
f0397f5a
PE
2009 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2010 that are set but not used.
2011
8664db06 2012 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2013 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2014
6abdaa4a
PE
2015 * xselect.c (x_get_local_selection, x_handle_property_notify):
2016 Remove vars that are set but not used.
2017
0ce7538d 2018 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2019 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2020
9ae848fc
PE
2021 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2022 Remove var that is set but not used.
0b918413
PE
2023 (scroll_bar_windows_size): Now size_t, not int.
2024 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2025 Check for overflow.
9ae848fc 2026
a5a62657
PE
2027 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2028 (map_tty_color) [!defined MSDOS]: Likewise.
2029
5c5cdd39
PE
2030 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2031
66ebf983
PE
2032 * coding.c: Remove vars that are set but not used.
2033 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2034 All callers changed.
2035 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2036 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2037 (decode_coding_charset): Remove vars that are set but not used.
2038
1be4d761
PE
2039 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2040 that is set but not used.
2041
47553fa8
PE
2042 * print.c (print_object): Remove var that is set but not used.
2043
1f7196bf 2044 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2045 The gnulib version avoids calling malloc in the usual case,
2046 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2047 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2048 * filelock.c (current_lock_owner): Likewise.
2049 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2050 * sysdep.c: Include allocator.h, careadlinkat.h.
2051 (emacs_no_realloc_allocator): New static constant.
2052 (emacs_readlink): New function.
fdb61804
PE
2053 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2054 ../lib/careadlinkat.h.
d1fdcab7 2055
f84c17c7
SM
20562011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2057
2058 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2059 first non-nil return value).
2060
ef3862ad
JD
20612011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2062
2063 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2064 if not defined (Bug#8403).
2065
376a7006
JB
20662011-04-02 Juanma Barranquero <lekktu@gmail.com>
2067
2068 * xdisp.c (display_count_lines): Remove parameter `start',
2069 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2070 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2071 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2072 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2073 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2074 and thereabouts. All callers changed.
2075 (get_per_char_metric): Remove parameter `f', unused since
2076 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2077
6ca3801d
JM
20782011-04-02 Jim Meyering <meyering@redhat.com>
2079
2080 do not dereference NULL upon failed strdup
2081 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2082 (ns_get_family): Likewise.
2083
d8e2b5ba
JB
20842011-04-02 Juanma Barranquero <lekktu@gmail.com>
2085
2086 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2087
8c74fcbd
JD
20882011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2089
2090 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2091 later (Bug#8403).
2092
7200d79c
SM
20932011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2094
03408648 2095 Add lexical binding.
7200d79c 2096
03408648
SM
2097 * window.c (Ftemp_output_buffer_show): New fun.
2098 (Fsave_window_excursion):
2099 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2100
2101 * lread.c (lisp_file_lexically_bound_p): New function.
2102 (Fload): Bind Qlexical_binding.
2103 (readevalloop): Remove `evalfun' arg.
2104 Bind Qinternal_interpreter_environment.
2105 (Feval_buffer): Bind Qlexical_binding.
2106 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2107 Mark as dynamic.
2108 (syms_of_lread): Declare `lexical-binding'.
2109
2110 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2111
2112 * keyboard.c (eval_dyn): New fun.
2113 (menu_item_eval_property): Use it.
ca105506
SM
2114
2115 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2116
03408648
SM
2117 * fns.c (concat, mapcar1): Accept byte-code-functions.
2118
2119 * eval.c (Fsetq): Handle lexical vars.
2120 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2121 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2122 (FletX, Flet): Obey lexical binding.
2123 (Fcommandp): Handle closures.
2124 (Feval): New `lexical' arg.
2125 (eval_sub): New function extracted from Feval. Use it almost
2126 everywhere where Feval was used. Look up vars in lexical env.
2127 Handle closures.
2128 (Ffunctionp): Move from subr.el.
2129 (Ffuncall): Handle closures.
2130 (apply_lambda): Remove `eval_flags'.
2131 (funcall_lambda): Handle closures and new byte-code-functions.
2132 (Fspecial_variable_p): New function.
2133 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2134 but without exporting it to Lisp.
23aba0ea 2135
23aba0ea 2136 * doc.c (Fdocumentation, store_function_docstring):
03408648 2137 * data.c (Finteractive_form): Handle closures.
23aba0ea 2138
03408648
SM
2139 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2140 interactive spec.
ba83908c 2141
04f2d78b
CB
2142 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2143 New byte-codes.
03408648
SM
2144 (exec_byte_code): New function extracted from Fbyte_code to handle new
2145 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2146
03408648 2147 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2148
03408648 2149 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2150
e2abce01
JB
21512011-03-31 Juanma Barranquero <lekktu@gmail.com>
2152
2153 * xdisp.c (redisplay_internal): Fix prototype.
2154
63696a73 21552011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2156
63696a73 2157 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2158 (try_scrolling): Use it when setting scroll_limit.
2159 Limit scrolling to 100 screen lines.
63696a73
EZ
2160 (redisplay_window): Even when falling back on "recentering",
2161 position point in the window according to scroll-conservatively,
2162 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2163
2164 (try_scrolling): When point is above the window, allow searching
2165 as far as scroll_max, or one screenful, to compute vertical
2166 distance from PT to the scroll margin position. This prevents
2167 try_scrolling from unnecessarily failing when
2168 scroll-conservatively is set to a value slightly larger than the
2169 window height. Clean up the case of PT below the margin at bottom
2170 of window: scroll_max can no longer be INT_MAX. When aggressive
2171 scrolling is in use, don't let point enter the opposite scroll
2172 margin as result of the scroll.
2173 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2174 threshold of 100 lines for never-recentering scrolling.
2175
e4cc2dfc
JB
21762011-03-31 Juanma Barranquero <lekktu@gmail.com>
2177
2178 * dispextern.h (move_it_by_lines):
2179 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2180 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2181 (message_log_check_duplicate): Remove parameters `prev_bol' and
2182 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2183 (redisplay_internal): Remove parameter `preserve_echo_area',
2184 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2185
2186 * indent.c (Fvertical_motion):
2187 * window.c (window_scroll_pixel_based, Frecenter):
2188 Don't pass `need_y_p' to `move_it_by_lines'.
2189
1c470562
SM
21902011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2191
44f230aa
SM
2192 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2193 steal a few bits to be more compact.
2194 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2195 Remove unneeded casts.
2196
1c470562
SM
2197 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2198
888adce9
ZK
21992011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2200
2201 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2202 binding" message (bug#7967).
2203
f838ed7b
PE
22042011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2205
77861b95
PE
2206 Fix more problems found by GCC 4.6.0's static checks.
2207
de6dbc14
PE
2208 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2209 Remove unused local var.
2210
f838ed7b
PE
2211 * editfns.c (Fmessage_box): Remove unused local var.
2212
792c7b2b
PE
2213 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2214 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2215 Omit unused local vars.
c499e557 2216 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2217 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2218 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2219 Omit unused local var.
2220
ba0165e1
PE
2221 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2222 Don't assume string length fits in int.
32ad8845 2223 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2224 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2225
3c59b4c9
PE
2226 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2227 instead of alloca (Bug#8344).
2228
a3eed478 2229 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2230 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2231
eb4d412d
PE
2232 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2233
1658b401
PE
2234 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2235 concerns.
2236
2237 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2238
2239 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2240
9a2c6e05
PE
2241 * keyboard.c (syms_of_keyboard): Use the same style as later
2242 in this function when indexing through an array. This also
2243 works around GCC bug 48267.
2244
03d0a109
PE
2245 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2246
44f730c8
PE
2247 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2248
fe75f926
PE
2249 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2250 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2251
ffa8c828
PE
2252 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2253 This avoids undefined behavior on integer overflow, and is a bit
2254 more convenient anyway since it is compared to a size_t variable.
2255
c5101a77
PE
2256 Variadic C functions now count arguments with size_t, not int.
2257 This avoids an unnecessary limitation on 64-bit machines, which
2258 caused (substring ...) to crash on large vectors (Bug#8344).
2259 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2260 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2261 All variadic functions and their callers changed accordingly.
c5101a77
PE
2262 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2263 * data.c (arith_driver, float_arith_driver): Likewise.
2264 * editfns.c (general_insert_function): Likewise.
2265 * eval.c (struct backtrace.nargs, interactive_p)
2266 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2267 (funcall_lambda, mark_backtrace): Likewise.
2268 * fns.c (concat): Likewise.
2269 * frame.c (x_set_frame_parameters): Likewise.
2270 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2271 0 if not found, not -1. All callers changed.
2272
dd3f25f7
PE
2273 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2274 (stack_copy_size): Now size_t, not int.
2275 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2276
461c2ab9
JB
22772011-03-28 Juanma Barranquero <lekktu@gmail.com>
2278
2279 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2280 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2281 All callers changed.
2282
2283 * lisp.h (multibyte_char_to_unibyte):
2284 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2285 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2286 * character.h (CHAR_TO_BYTE8):
2287 * cmds.c (internal_self_insert):
2288 * editfns.c (general_insert_function):
2289 * keymap.c (push_key_description):
2290 * search.c (Freplace_match):
2291 * xdisp.c (message_dolog, set_message_1): All callers changed.
2292
f6d62986
SM
22932011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2294
2295 * keyboard.c (safe_run_hook_funcall): New function.
2296 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2297 don't set the hook to nil, but remove the offending function instead.
2298 (Qcommand_hook_internal): Remove, unused.
2299 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2300 Vcommand_hook_internal.
2301
2302 * eval.c (enum run_hooks_condition): Remove.
2303 (funcall_nil, funcall_not): New functions.
2304 (run_hook_with_args): Call each function through a `funcall' argument.
2305 Remove `cond' argument, now redundant.
2306 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2307 (Frun_hook_with_args_until_failure): Adjust accordingly.
2308 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2309
1db5b1ad
JB
23102011-03-28 Juanma Barranquero <lekktu@gmail.com>
2311
2312 * dispextern.h (string_buffer_position): Remove declaration.
2313
2314 * print.c (strout): Remove parameter `multibyte', unused since
2315 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2316
2317 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2318 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2319 All callers changed.
2320
2321 * w32.c (_wsa_errlist): Use braces for struct initializers.
2322
2323 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2324 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2325 All callers changed.
2326 (string_buffer_position): Likewise. Also, make static (it's never
2327 used outside xdisp.c).
2328 (cursor_row_p): Remove parameter `w', unused since
2329 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2330 (decode_mode_spec): Remove parameter `precision', introduced during
2331 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2332 All callers changed.
2333
5ffb62aa
JD
23342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2335
2336 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2337
461c2ab9 23382011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2339
2340 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2341 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2342 (ns_update_auto_hide_menu_bar): New functions.
2343 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2344 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2345 ns_constrain_all_frames.
2346 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2347 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2348
5c380ffb
JD
23492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2350
2351 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2352
9af30bdf
GM
23532011-03-27 Glenn Morris <rgm@gnu.org>
2354
2355 * syssignal.h: Replace RETSIGTYPE with void.
2356 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2357 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2358 Replace SIGTYPE with void everywhere.
2359 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2360 * s/template.h (SIGTYPE): Remove commented out definition.
2361
e2abce01
JB
23622011-03-26 Eli Zaretskii <eliz@gnu.org>
2363
2364 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2365 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2366
f868cd8a
JB
23672011-03-26 Juanma Barranquero <lekktu@gmail.com>
2368
59eb0929
JB
2369 * w32.c (read_unc_volume): Use parameter `henum', instead of
2370 global variable `wget_enum_handle'.
2371
2372 * keymap.c (describe_vector): Remove parameters `indices' and
2373 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2374 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2375
f868cd8a
JB
2376 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2377
2378 * keyboard.c (timer_check): Remove parameter `do_it_now',
2379 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2380 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2381 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2382
2383 * keyboard.c (read_char):
2384 * w32menu.c (w32_menu_display_help):
2385 * xmenu.c (show_help_event, menu_help_callback):
2386 Adjust calls to `show_help_echo'.
2387
2388 * gtkutil.c (xg_maybe_add_timer):
2389 * keyboard.c (readable_events):
2390 * process.c (wait_reading_process_output):
2391 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2392
2393 * insdel.c (adjust_markers_gap_motion):
2394 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2395 (gap_left, gap_right): Don't call it.
2396
2ecf6fdb
CY
23972011-03-25 Chong Yidong <cyd@stupidchicken.com>
2398
2399 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2400 incurred during fontification.
2401
6b1f9ba4
JB
24022011-03-25 Juanma Barranquero <lekktu@gmail.com>
2403
2404 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2405 (DEFVAR_PER_BUFFER): Don't pass it.
2406
2407 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2408 (scrolling_window): Don't pass it.
2409
0f4a96b5
JB
24102011-03-25 Juanma Barranquero <lekktu@gmail.com>
2411
2412 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2413
2414 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2415 and `suffix'.
2416 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2417 of variables specific to SELinux and computation of `encoded_absname'.
2418
2419 * image.c (XPutPixel): Remove unused variable `height'.
2420
2421 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2422
2423 * unexw32.c (get_section_info): Remove unused variable `section'.
2424
2425 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2426 (system_process_attributes): Remove unused variable `sess'.
2427 (sys_read): Remove unused variable `err'.
2428
2429 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2430 (w32_wnd_proc): Remove unused variable `isdead'.
2431 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2432 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2433 (x_create_tip_frame): Remove unused variable `tem'.
2434
2435 * w32inevt.c (w32_console_read_socket):
2436 Remove unused variable `no_events'.
2437
2438 * w32term.c (x_draw_composite_glyph_string_foreground):
2439 Remove unused variable `width'.
2440
1149507c
JB
24412011-03-24 Juanma Barranquero <lekktu@gmail.com>
2442
2443 * w32term.c (x_set_glyph_string_clipping):
2444 Don't pass uninitialized region to CombineRgn.
2445
9c88f339
JB
24462011-03-23 Juanma Barranquero <lekktu@gmail.com>
2447
2448 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2449 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2450 (Fx_close_connection): Remove unused variable `i'.
2451
2452 * w32font.c (w32font_draw): Return number of glyphs.
2453 (w32font_open_internal): Remove unused variable `i'.
2454 (w32font_driver): Add missing initializer.
2455
2456 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2457 (fill_in_menu): Remove unused variable `items_added'.
2458
2459 * w32term.c (last_mouse_press_frame): Remove static global variable.
2460 (w32_clip_to_row): Remove unused variable `f'.
2461 (x_delete_terminal): Remove unused variable `i'.
2462
2463 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2464 (NOTHING): Remove unused static global variable.
2465 (uniscribe_check_otf): Remove unused variable `table'.
2466 (uniscribe_font_driver): Add missing initializers.
2467
dee091a3
JD
24682011-03-23 Julien Danjou <julien@danjou.info>
2469
2470 * term.c (Fsuspend_tty, Fresume_tty):
2471 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2472 * window.c (temp_output_buffer_show):
2473 * insdel.c (signal_before_change):
2474 * frame.c (Fhandle_switch_frame):
2475 * fileio.c (Fdo_auto_save):
2476 * emacs.c (Fkill_emacs):
2477 * editfns.c (save_excursion_restore):
2478 * cmds.c (internal_self_insert):
2479 * callint.c (Fcall_interactively):
2480 * buffer.c (Fkill_all_local_variables):
2481 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2482 Use Frun_hooks.
0f4a96b5 2483 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2484 unconditionnaly since it does the check itself.
2485
2c520ab5 24862011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2487
c9c49752
PE
2488 Fix more problems found by GCC 4.5.2's static checks.
2489
8abc3f12
PE
2490 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2491 the first time through the loop, since we know p0 < p1 then.
2492 This also avoids a gcc -Wstrict-overflow warning.
2493
a2d26660
PE
2494 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2495 leading to a memory leak, possible in functions like
2496 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2497 of objects (Bug#8318).
a2d26660 2498
916c72e9
PE
2499 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2500 that could (at least in theory) be that large.
2501
19ab8a18
PE
2502 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2503 This is less likely to overflow, and avoids undefined behavior if
2504 overflow does occur. All callers changed. Use strtoul to scan
2505 for the unsigned long integer.
b7cbbd6f
PE
2506 (pint2hrstr): Simplify and tune code slightly.
2507 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2508
f0641eff
PE
2509 * scroll.c (do_scrolling): Work around GCC bug 48228.
2510 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2511
7f650bb9
PE
2512 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2513 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2514 (validate_x_resource_name): Simplify count usage.
2515 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2516
37dd57d1
PE
2517 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2518 fail (Bug#8306).
81e56e61 2519
699979fc 2520 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2521
401bf9b4
PE
2522 * process.c (Fmake_network_process): Use socklen_t, not int,
2523 where POSIX says socklen_t is required in portable programs.
2524 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2525 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2526 (Fmake_network_process, server_accept_connection):
2527 (wait_reading_process_output, read_process_output):
2528 Likewise.
2529
b93aacde
PE
2530 * process.c: Rename or move locals to avoid shadowing.
2531 (list_processes_1, Fmake_network_process):
2532 (read_process_output_error_handler, exec_sentinel_error_handler):
2533 Rename or move locals.
4dc343ee 2534 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2535 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2536 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2537 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2538 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2539
af8a867c 2540 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2541 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2542 Include tparam.h instead, since it declares them.
af8a867c
PE
2543 * cm.h (PC): Remove extern decl; tparam.h now does this.
2544 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2545 * terminfo.c: Include tparam.h, to check interfaces.
2546 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2547 (tparam): Adjust signature to match interface in tparam.h;
2548 this removes some undefined behavior. Check that outstring and len
2549 are zero, which they always are with Emacs.
2550 * tparam.h (PC, BC, UP): New extern decls.
2551
0248044d 2552 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2553 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2554
8ff096c1 2555 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2556 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2557 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2558 (ftfont_list): Remove unused local.
49eaafba
PE
2559 (get_adstyle_property, ftfont_pattern_entity):
2560 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2561 Rename locals to avoid shadowing.
8ff096c1 2562
e2be39f6
PE
2563 * xfont.c (xfont_list_family): Mark var as initialized.
2564
c9735e30
PE
2565 * xml.c (make_dom): Now static.
2566
8f5201ae
PE
2567 * composite.c (composition_compute_stop_pos): Rename local to
2568 avoid shadowing.
b246f932
PE
2569 (composition_reseat_it): Remove unused locals.
2570 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2571 (composition_update_it): Mark var as initialized.
11b61122
PE
2572 (find_automatic_composition): Mark vars as initialized,
2573 with a FIXME (Bug#8290).
8f5201ae 2574
760fbc2c
PE
2575 character.h: Rename locals to avoid shadowing.
2576 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2577 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2578 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2579 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2580 to avoid shadowing.
2581
ff08eb85
PE
2582 * textprop.c (property_change_between_p): Remove; unused.
2583
fc7bf025
PE
2584 * intervals.c (interval_start_pos): Now static.
2585
235d7abc
PE
2586 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2587
44f230aa
SM
2588 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2589 Rename locals to avoid shadowing.
3e7d6594 2590
50060332
PE
2591 * sound.c (wav_play, au_play, Fplay_sound_internal):
2592 Fix pointer signedness.
d01f234b 2593 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2594 (wav_play): Initialize a variable to 0, to prevent undefined
2595 behavior (Bug#8278).
50060332 2596
c4fc4e30
PE
2597 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2598
918436ed
PE
2599 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2600
c939f91b
PE
2601 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2602 clobbering (Bug#8298).
b9c7f648
PE
2603 * sysdep.c (sys_subshell): Likewise.
2604 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2605
6bd8c144
PE
2606 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2607 This should get cleaned up, so that child_setup has the
2608 same signature on all platforms.
2609
7710357c 2610 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2611 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2612
c59da222
CY
26132011-03-22 Chong Yidong <cyd@stupidchicken.com>
2614
2615 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2616 not to be necessary, and produces flickering.
2617
66b87493
GM
26182011-03-20 Glenn Morris <rgm@gnu.org>
2619
2620 * config.in: Remove file.
2621
45b6f6d5
JB
26222011-03-20 Juanma Barranquero <lekktu@gmail.com>
2623
2624 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2625 are now in src/globals.h.
2626 (syms_of_minibuf): Remove spurious & from previous change.
2627
3ec03f7e
LL
26282011-03-20 Leo <sdl.web@gmail.com>
2629
2630 * minibuf.c (completing-read-function): New variable.
2631 (completing-read-default): Rename from completing-read.
2632 (completing-read): Call completing-read-function.
2633
b14e3e21
CY
26342011-03-19 Juanma Barranquero <lekktu@gmail.com>
2635
2636 * xfaces.c (Fx_load_color_file):
2637 Read color file from absolute filename (bug#8250).
2638
f2b726e6
JB
26392011-03-19 Juanma Barranquero <lekktu@gmail.com>
2640
2641 * makefile.w32-in: Update dependencies.
2642
09f6ff02
EZ
26432011-03-17 Eli Zaretskii <eliz@gnu.org>
2644
2645 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2646
29a6015a
PE
26472011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2648
a3a6c54e
PE
2649 Fix more problems found by GCC 4.5.2's static checks.
2650
b766f867
PE
2651 * process.c (make_serial_process_unwind, send_process_trap):
2652 (sigchld_handler): Now static.
2653
be02381c
PE
2654 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2655 That way, the code declares only the vars that it needs.
2656 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2657 * s/cygwin.h (PTY_ITERATION): Likewise.
2658 * s/darwin.h (PTY_ITERATION): Likewise.
2659 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2660
57048744
PE
2661 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2662 * process.c (allocate_pty): Don't declare stb unless it's needed.
2663
7914961c 2664 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2665 (CONSTANTLIM): Remove; unused.
2666 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2667 Define only if needed.
7914961c 2668
b3967b18
PE
2669 * unexelf.c (unexec): Name an expression,
2670 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2671 Use a different way to cause a compilation error if anyone uses
2672 n rather than nn, a way that does not involve shadowing.
73366a00 2673 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2674
29a6015a
PE
2675 * deps.mk (unexalpha.o): Remove; unused.
2676
43cfc33e 2677 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2678 * unexec.h: New file.
ce701a33
PE
2679 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2680 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2681 Depend on unexec.h.
2682 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2683 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2684 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2685 Change as necessary to match prototype in unexec.h.
ce701a33 2686
01f44d5a
PE
2687 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2688 shadowing.
4f63c6bb 2689 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2690
a6670b0b
PE
2691 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2692 Rename locals to avoid shadowing.
2693
cef2010d 2694 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2695 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2696
d4d7173a
PE
2697 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2698
f08b802a
PE
2699 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2700 warning when compiling print.c.
2701
3ddb0639
PE
2702 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2703 instead of using an uninitialized var.
5ad03b97 2704 (font_sort_entities): Mark var as initialized.
3ddb0639 2705
170a2692
PE
2706 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2707
e663c700
PE
2708 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2709 pointers to constants.
89bc529a 2710 (font_parse_fcname): Remove unused vars.
7b81e2d0 2711 (font_delete_unmatched): Now static.
ea838e10 2712 (font_get_spec): Remove; unused.
13a547c6
PE
2713 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2714 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2715 Rename or move locals to avoid shadowing.
e663c700 2716
2a80c887 2717 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2718 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2719
1384fa33 2720 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2721 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2722
8b2c52e9
PE
2723 * alloc.c (mark_backtrace): Move decl from here ...
2724 * lisp.h: ... to here, so that it can be checked.
2725
475545b5 2726 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2727 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2728 (lisp_indirect_variable): Name an expression,
2729 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2730 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2731
b1349114 2732 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2733 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2734 Use const pointer when appropriate.
b1349114 2735
a2928364
PE
2736 * lisp.h (get_system_name, get_operating_system_release):
2737 Move decls here, to check interfaces.
2738 * process.c (get_operating_system_release): Move decl to lisp.h.
2739 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2740 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2741 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2742 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2743 (Fformat_time_string, Fencode_time, Finsert_char):
2744 (Ftranslate_region_internal, Fformat):
2745 Rename or remove local vars to avoid shadowing.
9710023e 2746 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2747
a415e694
PE
2748 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2749 avoid shadowing.
2750
8ef4622d
PE
2751 * lisp.h (eassert): Check that the argument compiles, even if
2752 ENABLE_CHECKING is not defined.
2753
946f9a5b
PE
2754 * data.c (Findirect_variable): Name an expression, to avoid
2755 gcc -Wbad-function-cast warning.
112396d6 2756 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2757 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2758 (Fmake_variable_buffer_local, Fmake_local_variable):
2759 Mark variables as initialized.
52746918 2760 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2761
e5aab7e7 2762 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2763 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2764 Rename locals to avoid shadowing.
dff45157
PE
2765 (mark_stack): Move local variables into the #ifdef region where
2766 they're used.
7bc26fdb
PE
2767 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2768 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2769 needed otherwise.
2770 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2771 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2772 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2773
e5aab7e7
PE
2774 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2775 avoids undefined behavior in theory.
2776
4da60324
PE
2777 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2778
88043301
PE
2779 Use functions, not macros, for up- and down-casing (Bug#8254).
2780 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2781 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2782 to use the following functions instead of these macros.
2783 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2784 EMACS_INT, since callers assume the returned value fits in int.
2785 (upcase1): Likewise, for UPCASE_TABLE.
2786 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2787 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2788 the race-condition problem in the old DOWNCASE.
88043301 2789
19ed5445
PE
2790 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2791 Rename locals to avoid shadowing.
2792 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2793 (regex_compile, re_search_2, re_match_2_internal):
2794 Remove unused local vars.
952db0d7
PE
2795 (FREE_VAR): Rewrite so as not to use empty "else",
2796 which gcc can warn about.
da053e48 2797 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2798 (RETALLOC_IF): Define only if needed.
2799 (WORDCHAR_P): Likewise. This one is never needed, but is used
2800 only in a comment talking about a compiler bug, so put inside
2801 the #if 0 of that comment.
2802 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2803 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2804 Remove; unused.
19ed5445 2805
1f3561e4 2806 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2807 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2808 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2809
ded6f8f7
PE
2810 * search.c (simple_search): Remove unused var.
2811
dbd37a95
PE
2812 * dired.c (compile_pattern): Move decl from here ...
2813 * lisp.h: ... to here, so that it can be checked.
2814 (struct re_registers): New forward decl.
2815
7e47afad
PE
2816 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2817
85f24f61
PE
2818 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2819 All uses changed.
2820 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2821 Rename locals to avoid shadowing.
5671df8f 2822 (Fvertical_motion): Mark locals as initialized.
85f24f61 2823
181aa2be 2824 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2825 (casify_region): Mark local as initialized.
181aa2be 2826
930d429c
PE
2827 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2828
7082eac6
PE
2829 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2830 New macros, so that the caller can use some names other than
2831 gcpro1, gcpro2, etc.
2832 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2833 of the new macros.
2834 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2835 argument, for consistency with GCPRO2_VAR, etc: it is now the
2836 prefix of the variable, not the variable itself. All uses
2837 changed.
38b2c076
PE
2838 * dired.c (directory_files_internal, file_name_completion):
2839 Rename locals to avoid shadowing.
2840
15206ed9
PE
2841 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2842 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2843 dired.c's scmp function, had undefined behavior.
2844 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2845 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2846 * buffer.h: ... to here, because these macros use current_buffer,
2847 and the new implementation with inline functions needs to have
2848 current_buffer in scope now, rather than later when the macros
2849 are used.
2850 (downcase, upcase1): New static inline functions.
2851 (DOWNCASE, UPCASE1): Reimplement using these functions.
2852 This avoids undefined behavior in expressions like
2853 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2854 from race conditions in accessing the global variables
2855 case_temp1 and case_temp2.
2856 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2857 * lisp.h (case_temp1, case_temp2): Remove their decls.
2858 * character.h (ASCII_CHAR_P): Move from here ...
2859 * lisp.h: ... to here, so that the inline functions mentioned
2860 above can use them.
2861
4a6bea26
PE
2862 * dired.c (directory_files_internal_unwind): Now static.
2863
f14b7e14
PE
2864 * fileio.c (file_name_as_directory, directory_file_name):
2865 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2866 Now static.
2893f146
PE
2867 (file_name_as_directory): Use const pointers when appropriate.
2868 (Fexpand_file_name): Likewise. In particular, newdir might
2869 point at constant storage, so make it a const pointer.
fd4ead52 2870 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2871 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2872 signedness issues.
f839df0c
PE
2873 (Fset_file_times, Finsert_file_contents, auto_save_error):
2874 Rename locals to avoid shadowing.
f14b7e14 2875
5716756e 2876 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2877 (Ftry_completion, Fall_completions): Rename or remove locals
2878 to avoid shadowing.
5716756e 2879
b4c3046a
PE
2880 * marker.c (bytepos_to_charpos): Remove; unused.
2881
b45db522
PE
2882 * lisp.h (verify_bytepos, count_markers): New decls,
2883 so that gcc does not warn that these functions aren't declared.
2884
85876d07
PE
2885 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2886 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2887 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2888 (copy_text): Remove unused local var.
85876d07 2889
03d78a21 2890 * filelock.c (within_one_second): Now static.
b3dd38ab 2891 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2892
5df8f01b
PE
2893 * buffer.c (fix_overlays_before): Mark locals as initialized.
2894 (fix_start_end_in_overlays): Likewise. This function should be
2895 simplified by using pointers-to-pointers, but that's a different
2896 matter.
b1d876f1 2897 (switch_to_buffer_1): Now static.
8f54f30a
PE
2898 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2899 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2900
a70072c9 2901 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2902 Fix pointer signedness issue.
edced198
PE
2903 (sys_subshell): Mark local as volatile if checking for lint,
2904 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2905 (MAXPATHLEN): Define only if needed.
a70072c9 2906
a0977c44
PE
2907 * process.c (serial_open, serial_configure): Move decls from here ...
2908 * systty.h: ... to here, so that they can be checked.
2909
a884fdcc
PE
2910 * fns.c (get_random, seed_random): Move extern decls from here ...
2911 * lisp.h: ... to here, so that they can be checked.
2912
604efe86 2913 * sysdep.c (reset_io): Now static.
b8950c94 2914 (wait_for_termination_signal): Remove; unused.
604efe86 2915
38fc62d9
PE
2916 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2917 (copy_keymap_item, append_key, push_text_char_description):
2918 Now static.
1004a21a 2919 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2920 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2921 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2922 (describe_map_tree):
2923 Rename locals to avoid shadowing.
38fc62d9 2924
2f2650da
PE
2925 * keyboard.c: Declare functions static if they are not used elsewhere.
2926 (echo_char, echo_dash, cmd_error, top_level_2):
2927 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2928 (read_char, kbd_buffer_get_event, make_lispy_position):
2929 (make_lispy_event, make_lispy_movement, apply_modifiers):
2930 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2931 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2932 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2933 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2934 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2935
a053e86c 2936 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2937 (mark_kboards): Move decl here ...
2938 * alloc.c (mark_kboards): ... from here.
a053e86c 2939
4752793e
PE
2940 * lisp.h (force_auto_save_soon): New decl.
2941
74f10ca7 2942 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2943 (DEFINE_DUMMY_FUNCTION): New macro.
2944 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2945 Use it.
c03cd23f
PE
2946 (main): Add casts to avoid warnings
2947 if GCC considers string literals to be constants.
74f10ca7 2948
022e70d4
PE
2949 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2950
59d6fe83
PE
2951 * dbusbind.c: Pointer signedness fixes.
2952 (xd_signature, xd_append_arg, xd_initialize):
2953 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2954 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2955 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2956 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2957
78320123
PE
2958 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2959 if GCC considers string literals to be constants.
49cebcca 2960 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2961
35ac2a97
SM
29622011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2963
fb103ca9
SM
2964 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2965 (print_preprocess, print_object): New macro to fix last change.
2966
35ac2a97
SM
2967 * print.c (print_preprocess): Don't forget font objects.
2968
62973b41
JB
29692011-03-16 Juanma Barranquero <lekktu@gmail.com>
2970
2971 * emacs.c (USAGE3): Doc fixes.
2972
0e48bb22
AS
29732011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2974
2975 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2976 structure.
2977
7684e57b
JB
29782011-03-14 Juanma Barranquero <lekktu@gmail.com>
2979
2980 * lisp.h (VWindow_system, Qfile_name_history):
2981 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2982 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2983 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2984
2985 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2986 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2987
2988 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2989 * w32console.c (detect_input_pending, read_input_pending)
2990 (encode_terminal_code):
2991 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2992 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2993 (w32_system_caret_y, Qfile_name_history):
2994 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2995 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2996 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2997 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2998 * w32proc.c (Qlocal, report_file_error):
2999 * w32term.c (Vwindow_system, updating_frame):
3000 * w32uniscribe.c (initialized, uniscribe_font_driver):
3001 Remove unneeded extern declarations.
3002
2aa46d6c
CY
30032011-03-14 Chong Yidong <cyd@stupidchicken.com>
3004
c96bbc66 3005 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3006
cffc6f3b
CY
30072011-03-13 Chong Yidong <cyd@stupidchicken.com>
3008
3009 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3010 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3011 These macros can no longer be used for assignment.
3012
44f230aa
SM
3013 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3014 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3015 (record_buffer_markers, fetch_buffer_markers): New functions for
3016 recording and fetching special buffer markers.
3017 (set_buffer_internal_1, set_buffer_temp): Use them.
3018
3019 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3020
3021 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3022
3023 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3024 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3025
3026 * xdisp.c (hscroll_window_tree):
3027 (reconsider_clip_changes): Use PT instead of BUF_PT.
3028
d251f04b
EZ
30292011-03-13 Eli Zaretskii <eliz@gnu.org>
3030
3031 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3032 $(EMACS_ROOT)/lib/intprops.h.
3033
f0c77cd1
PE
30342011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3035
3eca4629
PE
3036 Fix more problems found by GCC 4.5.2's static checks.
3037
7c86ee98
PE
3038 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3039 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3040 (xg_free_frame_widgets): Make it clear that a local variable is
3041 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3042 (gdk_window_get_screen): Make it clear that this macro is needed
3043 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3044 (int_gtk_range_get_value): New function, which avoids a diagnostic
3045 from gcc -Wbad-function-cast.
3046 (xg_set_toolkit_scroll_bar_thumb): Use it.
3047 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3048 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3049 (get_utf8_string, xg_get_file_with_chooser):
3050 Rename locals to avoid shadowing.
3051 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3052
41729b81
PE
3053 * xgselect.c (xg_select): Remove unused var.
3054
f0c77cd1
PE
3055 * image.c (four_corners_best): Mark locals as initialized.
3056 (gif_load): Initialize transparent_p to zero (Bug#8238).
3057 Mark another local as initialized.
ec6cf4c6 3058 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3059
ce0ad53d 3060 * image.c (clear_image_cache): Now static.
d5d5a617 3061 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3062 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3063 (x_edge_detection): Remove unnecessary cast that
3064 gcc -Wbad-function-cast diagnoses.
2037898d 3065 (gif_load): Fix pointer signedness.
6ae141d6
PE
3066 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3067 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3068
33383987 30692011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3070
d32df629
PE
3071 Improve quality of tests for time stamp overflow.
3072 For example, without this patch (encode-time 0 0 0 1 1
3073 1152921504606846976) returns the obviously-bogus value (-948597
3074 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3075 reports time overflow. See
3076 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3077 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3078 * editfns.c: Include limits.h and intprops.h.
3079 (TIME_T_MIN, TIME_T_MAX): New macros.
3080 (time_overflow): Move earlier, to before first use.
3081 (hi_time, lo_time): New functions, for an accurate test for
3082 out-of-range times.
3083 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3084 (Fget_internal_run_time): Don't assume time_t fits in int.
3085 (make_time): Use list2 instead of Fcons twice.
3086 (Fdecode_time): More accurate test for out-of-range times.
3087 (check_tm_member): New function.
3088 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3089 (lisp_time_argument): Don't rely on undefined left-shift and
3090 right-shift behavior when checking for time stamp overflow.
8be6f318 3091
fe31d94c
PE
3092 * editfns.c (time_overflow): New function, refactoring common code.
3093 (Fformat_time_string, Fdecode_time, Fencode_time):
3094 (Fcurrent_time_string): Use it.
3095
8be6f318
PE
3096 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3097 * dired.c (make_time): Move to ...
3098 * editfns.c (make_time): ... here.
3099 * systime.h: Note the move.
3100
09d9db2c 31012011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3102
126bc0dc
YM
3103 * fringe.c (update_window_fringes): Remove unused variables.
3104
c47cbdfd
YM
3105 * unexmacosx.c (copy_data_segment): Also copy __got section.
3106 (Bug#8223)
3107
7ac80be9
EZ
31082011-03-12 Eli Zaretskii <eliz@gnu.org>
3109
c96bbc66 3110 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3111 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3112 Constify `char *' arguments and their references according to
3113 prototypes in tparam.h.
3114
ecb0f94d 3115 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3116
7ac80be9
EZ
3117 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3118 Adapt all references accordingly.
3119
3120 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3121
ef1fd07e
TT
31222011-03-11 Tom Tromey <tromey@redhat.com>
3123
3124 * buffer.c (syms_of_buffer): Remove obsolete comment.
3125
7ef4b50c
EZ
31262011-03-11 Eli Zaretskii <eliz@gnu.org>
3127
3128 * termhooks.h (encode_terminal_code): Declare prototype.
3129
3130 * msdos.c (encode_terminal_code): Don't declare prototype.
3131
3132 * term.c (encode_terminal_code): Now external again, used by
3133 w32console.c and msdos.c.
3134
44f230aa
SM
3135 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3136 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3137
4b1ec863 31382011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3139
1714f52b 3140 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3141
4b1ec863
PE
3142 * fringe.c (update_window_fringes): Mark locals as initialized
3143 (Bug#8227).
3144 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3145
524c7aa6
PE
3146 * alloc.c (mark_fringe_data): Move decl from here ...
3147 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3148 to check its interface.
3149 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3150
a5c0af81 3151 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3152 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3153 (fontset_font): Mark local as initialized.
a9a06e0b 3154 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3155
b4716021
PE
3156 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3157
811e9bac 3158 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3159 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3160 (x_own_selection, Fx_disown_selection_internal): Rename locals
3161 to avoid shadowing.
3162 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3163
7e3ab302
PE
3164 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3165 so that the caller can use some name other than gcpro1.
3166 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3167 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3168 (Fx_backspace_delete_keys_p):
3169 Use them to avoid shadowing, and rename vars to avoid shadowing.
3170 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3171 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3172 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3173 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3174 Remove unused locals.
7e3ab302
PE
3175 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3176 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3177 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3178 macros.
f78faa98 3179
e2b13473
PE
3180 * xterm.h (x_mouse_leave): New decl.
3181
77f23912
PE
3182 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3183 Remove unused functions.
cdf4ba58
PE
3184 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3185 (x_calc_absolute_position): Now static.
7411c686 3186 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3187 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3188 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3189 unless they are used.
38d0b34a
PE
3190 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3191 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3192 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3193 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3194 (x_error_catcher, x_connection_closed, x_error_handler):
3195 (x_error_quitter, xembed_send_message, x_iconify_frame):
3196 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3197 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3198 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3199
44f230aa
SM
3200 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3201 Rename or move locals to avoid shadowing.
6b463e58 3202 (tty_defined_color, merge_face_heights): Now static.
5967d051 3203 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3204 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3205 does not deduce is never used uninitialized.
73719eba
PE
3206 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3207 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3208
426994c3 3209 * terminal.c (store_terminal_param): Now static.
5489860b 3210
032f1620 3211 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3212 (set_frame_menubar): Remove unused local.
d4323972 3213 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3214 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3215 since they might point to immutable storage.
281585b0
PE
3216 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3217 since it's unused otherwise.
032f1620 3218
367c19e5 3219 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3220 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3221 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3222 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3223 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3224 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3225 does not deduce are never used uninitialized.
70739cbe 3226
07b48fa9
PE
3227 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3228
8868a238 3229 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3230 * window.c (window_loop, size_window):
3231 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3232
7e5cf297 3233 * window.c (display_buffer): Now static.
d6550a9f
PE
3234 (size_window): Mark variables that gcc -Wuninitialized
3235 does not deduce are never used uninitialized.
a586633d
PE
3236 * window.h (check_all_windows): New decl, to forestall
3237 gcc -Wmissing-prototypes diagnostic.
5b555da1 3238 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3239
f6095868
PE
3240 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3241 shadowing.
3242 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3243 Include <limits.h>.
3244 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3245 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3246 (load_charset_map): Mark variables that gcc -Wuninitialized
3247 does not deduce are never used uninitialized.
53df7c11 3248 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3249
f38b440c
PE
3250 * coding.c (coding_set_source, coding_set_destination):
3251 Use "else { /* comment */ }" rather than "else /* comment */;"
3252 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3253 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3254 a block, when the outer 'i' will do.
3255 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3256 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3257 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3258 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3259 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3260 Rename locals to avoid shadowing.
3261 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3262 * coding.c (emacs_mule_char, encode_invocation_designation):
3263 Now static, since they're not used elsewhere.
413bb2db 3264 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3265 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3266 (decode_coding_emacs_mule): Mark variables that gcc
3267 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3268 (detect_coding_iso_2022): Initialize a local variable that might
3269 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3270 this initialization is needed. (Bug#8211)
5f58e762
PE
3271 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3272 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3273 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3274 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3275 Remove unused macros.
f38b440c 3276
232b38b9 3277 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3278 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3279 * character.c (string_count_byte8): Likewise.
232b38b9 3280
fb90da1b
PE
3281 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3282 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3283
fb93dbc2
PE
3284 * chartab.c (copy_sub_char_table): Now static, since it's not used
3285 elsewhere.
5c156ace
PE
3286 (sub_char_table_ref_and_range, char_table_ref_and_range):
3287 Rename locals to avoid shadowing.
bbcd0949 3288 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3289
7d3b3862 3290 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3291 (BIDI_BOB): Remove unused macro.
7d3b3862 3292
6be7d3da
PE
3293 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3294 deduce are never used uninitialized.
c2ed9c8b 3295 * term.c (encode_terminal_code): Likewise.
6be7d3da 3296
75f8807f 3297 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3298
50938595
PE
3299 * tparam.h: New file.
3300 * term.c, tparam.h: Include it.
3301 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3302 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3303 Move these decls to tparam.h, and make them agree with what
3304 is actually in tparam.c. The previous trick of using incompatible
3305 decls in different modules does not conform to the C standard.
3306 All callers of tparam changed to use tparam's actual API.
3307 * tparam.c (tparam1, tparam, tgoto):
3308 Use const pointers where appropriate.
3309
fbceeba2
PE
3310 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3311 * cm.h (struct cm): Likewise.
3312 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3313 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3314 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3315 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3316 (turn_on_face, init_tty): Likewise.
3317 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3318
7f3f1250
PE
3319 * term.c (term_mouse_position): Rename local to avoid shadowing.
3320
e6ca6543
PE
3321 * alloc.c (mark_ttys): Move decl from here ...
3322 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3323
c40f8d15
AS
33242011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3325
3326 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3327
cfe0661d
JB
33282011-03-09 Juanma Barranquero <lekktu@gmail.com>
3329
3330 * search.c (compile_pattern_1): Remove argument regp, unused since
3331 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3332 (compile_pattern): Don't pass it.
3333
0afb4571
J
33342011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3335
3336 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3337 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3338 for ! HAVE_GTK3.
3339 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3340
3341 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3342
3343 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3344 gdk_window_get_screen, gdk_window_get_geometry,
3345 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3346 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3347 (xg_get_pixbuf_from_pixmap): New function.
3348 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3349 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3350 Call xg_get_pixbuf_from_pixmap instead of
3351 gdk_pixbuf_get_from_drawable.
3352 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3353 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3354 (xg_check_special_colors): Use GtkStyleContext and its functions
3355 for HAVE_GTK3.
3356 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3357 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3358 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3359 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3360 Call gtk_widget_get_preferred_size.
0afb4571
J
3361 (xg_frame_resized): gdk_window_get_geometry only takes 5
3362 parameters.
44f230aa
SM
3363 (xg_win_to_widget, xg_event_is_for_menubar):
3364 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3365 (xg_set_widget_bg): New function.
3366 (delete_cb): New function.
895009e1 3367 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3368 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3369 (xg_set_background_color): Call xg_set_widget_bg.
3370 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3371 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3372 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3373 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3374 if ! HAVE_GTK3.
3375 (update_frame_tool_bar): Call gtk_widget_hide.
3376 (xg_initialize): Use GDK_KEY_g.
3377
3378 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3379 if ! HAVE_GTK3
3380 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3381
3382 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3383 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3384 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3385
1c2cc4ef
JB
33862011-03-08 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * w32xfns.c (select_palette): Check success of RealizePalette against
3389 GDI_ERROR, not zero.
3390
33383987 3391See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3392
3393;; Local Variables:
3394;; coding: utf-8
aac0c6e3
MR
3395;; End:
3396
33383987 3397 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3398
3399 This file is part of GNU Emacs.
3400
3401 GNU Emacs is free software: you can redistribute it and/or modify
3402 it under the terms of the GNU General Public License as published by
3403 the Free Software Foundation, either version 3 of the License, or
3404 (at your option) any later version.
3405
3406 GNU Emacs is distributed in the hope that it will be useful,
3407 but WITHOUT ANY WARRANTY; without even the implied warranty of
3408 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3409 GNU General Public License for more details.
3410
3411 You should have received a copy of the GNU General Public License
3412 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.