comint.el: Don't let `insert' break an `input' field into two.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c7b08b0d
MR
12011-10-15 Martin Rudalics <rudalics@gmx.at>
2
3 * window.c (coordinates_in_window): Rewrite and delabelize
4 vertical border check. (Bug#5357) (Bug#9618)
5
6b02f655
SM
62011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7
8 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
9 errors in XSetWindowBorder (bug#9310).
10
81d40c92
DA
112011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
12
13 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
14 avoid crash when xmalloc overrun checking is enabled.
15
d4172c3b
EZ
162011-10-13 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
19 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
20 cursor motion with <left> and <right> arrow keys.
21
22 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
23 some callers set that themselves.
24
b00eea75
EZ
252011-10-12 Eli Zaretskii <eliz@gnu.org>
26
27 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
28 display string and the previous row comes from the same string and
29 is empty. (Bug#9739) (Bug#9738)
30
8fe012c4
SM
312011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
32
33 * doc.c (get_doc_string): Encode file name (bug#9735).
34
0074aef2
EZ
352011-10-12 Eli Zaretskii <eliz@gnu.org>
36
79beb178
EZ
37 * bidi.c (bidi_level_of_next_char):
38 * xdisp.c (get_visually_first_element): Remove old incorrect
39 comments regarding the Unicode Line Separator character.
40
0074aef2
EZ
41 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
42
6e4b3fbe
DA
432011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
44
45 * alloc.c (Fgc_status): Do not access beyond zombies array
46 boundary if nzombies > MAX_ZOMBIES.
47 * alloc.c (dump_zombies): Add missing format specifier.
48
0324f3af
PE
492011-10-12 Paul Eggert <eggert@cs.ucla.edu>
50
b5525cac
PE
51 * xdisp.c (set_cursor_from_row): Simplify conditionals,
52 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
53
0324f3af
PE
54 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
55 Some packages use them to denote characters with modifiers.
56
e9b5f888
AS
572011-10-11 Andreas Schwab <schwab@linux-m68k.org>
58
59 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
60 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
61 matching a pp-number. Rename parameter var to var1.
62
127827c0
SM
632011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
64
65 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
66
c8fd3bd0
GM
672011-10-08 Glenn Morris <rgm@gnu.org>
68
69 * callint.c (Fcall_interactively): Give a more explicit error for the
70 'c' case with a non-character input. (Bug#8479)
71
352ec8ff
EZ
722011-10-08 Eli Zaretskii <eliz@gnu.org>
73
03669ccb
EZ
74 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
75 lines.
7061c986
EZ
76 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
77 lines that are hscrolled on the left.
03669ccb 78
352ec8ff
EZ
79 * dispnew.c (buffer_posn_from_coords): Account for a possible
80 presence of header-line. (Bug#4426)
81
a66cfb1c
SM
822011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
83
6b02f655
SM
84 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
85 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 86
7c5ee88e
PE
872011-10-07 Paul Eggert <eggert@cs.ucla.edu>
88
89 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
90 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
91 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
92 this makes Emacs dump core during garbage collection on rare
93 occasions. sizeof is obviously inferior to offsetof here, so
94 stick with offsetof.
95 (GC_POINTER_ALIGNMENT): New macro.
96 (mark_memory): Omit 3rd (offset) arg; caller changed.
97 Don't assume EMACS_INT alignment is the same as pointer alignment.
98
df1bbe5b
SM
992011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * keyboard.c (read_key_sequence_remapped): New var.
102 (read_key_sequence): Compute remapping in the right buffer.
103 (command_loop_1): Use read_key_sequence's remapping directly.
104
51553db6
SM
1052011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
106
32c1fffd
SM
107 * dired.c (file_name_completion): Don't expand file name.
108 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
109 before checking file name handler.
110
51553db6
SM
111 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
112 they've been requested explicitly (bug#9591).
113
b6bd1599 1142011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
115
116 * keymap.c (Fsingle_key_description): Use make_specified_string
117 instead of build_string to build string from push_key_description.
118 (Bug#5193)
119
f701dc2a
PE
1202011-09-30 Paul Eggert <eggert@cs.ucla.edu>
121
4222c55d
PE
122 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
123 This fixes a Y2038 bug on 64-bit hosts.
124 * buffer.c (reset_buffer):
125 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
126 (Fclear_buffer_auto_save_failure):
127 Use 0, not -1, to represent an unset failure time, since time_t
128 might not be signed.
129
f701dc2a
PE
130 Remove dependency on glibc malloc internals.
131 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
132 Move back here from lisp.h, but with their new implementations.
133 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
134 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
135 * charset.c (charset_table_init): New static var.
136 (syms_of_charset): Use it instead of xmalloc. This removes a
137 dependency on glibc malloc internals. See Eli Zaretskii's comment in
138 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
139 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
140 Move back to alloc.c.
141 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
142 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
143
9ceebf39
JD
1442011-09-30 Jan Djärv <jan.h.d@swipnet.se>
145
146 * nsterm.m (windowDidResize): Call x_set_window_size only when
147 ns_in_resize is true. Otherwise set pixelwidth/height and
148 call change_frame_size (Bug#9628).
149
cb993c58
PE
1502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
151
3930c88b
PE
152 Port --enable-checking=all to Fedora 14 x86-64.
153 * charset.c (syms_of_charset): Also account for glibc malloc's
154 internal overhead when calculating the initial malloc maximum.
155
cb993c58
PE
156 Port --enable-checking=all to Fedora 14 x86.
157 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
158 Move to lisp.h.
159 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
160 (overrun_check_realloc, overrun_check_free):
161 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
162 That way, xmalloc returns a properly-aligned pointer even if
163 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
164 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
165 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
166 into account when calculating the initial malloc maximum.
167 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
168 Move here from alloc.c, so that charset.c can use it too.
169 Properly align; the old code wasn't right for common 32-bit hosts
170 when configured with --enable-checking=all.
171 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
172 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
173
31bed486
EZ
1742011-09-29 Eli Zaretskii <eliz@gnu.org>
175
04c70788 176 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
177 use EDOM.
178
fbcaa2f3
EZ
1792011-09-28 Eli Zaretskii <eliz@gnu.org>
180
181 * xdisp.c (compute_display_string_end): If there's no display
182 string at CHARPOS, return -1.
183
184 * bidi.c (bidi_fetch_char): When compute_display_string_end
185 returns a negative value, treat the character as a normal
186 character not covered by a display string. (Bug#9624)
187
a239d4e9
JB
1882011-09-28 Juanma Barranquero <lekktu@gmail.com>
189
190 * lread.c (Fread_from_string): Fix typo in docstring.
191
88652fd5
EZ
1922011-09-27 Eli Zaretskii <eliz@gnu.org>
193
194 * xdisp.c (handle_invisible_prop): If invisible text ends on a
195 newline, reseat the iterator instead of bidi-iterating there one
196 character at a time. (Bug#9610)
32c1fffd
SM
197 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
198 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 199
ed497dd4
AS
2002011-09-27 Andreas Schwab <schwab@linux-m68k.org>
201
202 * lread.c (readevalloop): Use correct code for NBSP.
203 (read1): Likewise. (Bug#9608)
204
b2bf61aa
MA
2052011-09-25 Michael Albinus <michael.albinus@gmx.de>
206
207 * dbusbind.c (Fdbus_register_signal): When service is not
208 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
209
32bbb17c
GM
2102011-09-25 Glenn Morris <rgm@gnu.org>
211
212 * buffer.c (truncate-lines): Doc fix.
213
94e0933e
CY
2142011-09-24 Chong Yidong <cyd@stupidchicken.com>
215
216 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
217 (Fset_window_next_buffers): Doc fix.
218
cddde921
GM
2192011-09-24 Glenn Morris <rgm@gnu.org>
220
221 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
222
1260aef1
PE
2232011-09-24 Paul Eggert <eggert@cs.ucla.edu>
224
25b4bfa0
PE
225 Fix minor problems found by static checking.
226 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
227 * indent.c (Fvertical_motion): Fix == vs = typo.
228
e3cbd34b
EZ
2292011-09-24 Eli Zaretskii <eliz@gnu.org>
230
a66cfb1c
SM
231 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
232 Default value is now t. Doc fix.
6bf7006f 233
e3cbd34b 234 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 235 logic when moving up, not only when moving down. Fix the
e3cbd34b 236 confusing name and values of the it_overshoot_expected variable;
32c1fffd 237 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
238
239 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
240 CHARPOS is covered by a display string which includes newlines.
241 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
242 is covered by a display string with embedded newlines.
243
a3de0cbd
MA
2442011-09-24 Michael Albinus <michael.albinus@gmx.de>
245
246 * dbusbind.c (Fdbus_register_signal): Add match rule to
247 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
248 (Fdbus_register_method, Vdbus_registered_objects_table):
249 Fix docstring.
a3de0cbd 250
b260039d
JM
2512011-09-24 Jim Meyering <meyering@redhat.com>
252
32c1fffd 253 do not ignore write error for any output size
b260039d
JM
254 The previous change was incomplete.
255 While it makes emacs --batch detect the vast majority of stdout
256 write failures, errors were still ignored whenever the output size is
257 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
258 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
259 && echo FAIL: ignored write error
260 FAIL: ignored write error
261 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
262 && echo FAIL: ignored write error
263 FAIL: ignored write error
264 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
265
8eca8a7c
AS
2662011-09-23 Andreas Schwab <schwab@linux-m68k.org>
267
268 * emacs.c (Fkill_emacs): In noninteractive mode exit
269 non-successfully if a write error occurred on stdout. (Bug#9574)
270
3341db62
EZ
2712011-09-21 Eli Zaretskii <eliz@gnu.org>
272
273 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
274 the xassert test.
275
276 * dispextern.h (struct it): Update the comment documenting what
277 can it->OBJECT be.
278
8c203dbf
EZ
2792011-09-20 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
282 a display string, extend search for cursor position to end of row.
283 (find_row_edges): If the row ends in a newline from a display
284 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
285 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
286 (Fcurrent_bidi_paragraph_direction): Fix search for previous
287 non-empty line. Fixes confusing cursor motion with arrow keys at
288 the beginning of a line that starts with whitespace.
8c203dbf 289
a4824228
LMI
2902011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
291
292 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
293 (bug#9493).
294
33ed493b
CY
2952011-09-18 Chong Yidong <cyd@stupidchicken.com>
296
297 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
298 boolean (Bug#9154).
299
56cd55c8
EZ
3002011-09-18 Eli Zaretskii <eliz@gnu.org>
301
302 * xdisp.c (display_line): Record maximum and minimum buffer
303 positions even if no glyphs were produced (e.g., by a zero-width
304 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
305 buffer positions that will be removed from the glyph row because
306 they don't fit.
c02dcedf
EZ
307 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
308 column is beyond frame width: don't subtract 1 "pixel" when
309 computing width of the stretch.
3e62b7e0
EZ
310 (reseat_at_next_visible_line_start): Undo the change made on
311 2011-09-17 that saved paragraph information and restored it after
312 the call to `reseat'. (Bug#9545)
56cd55c8 313
5ed99d36 3142011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
315
316 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
317 and turn window cursor on if cleared (Bug#9415).
318
5ed99d36 3192011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
320
321 * search.c (boyer_moore): Take unibyte characters from pattern
322 literally. (Bug#9458)
323
9bade7b2
EZ
3242011-09-18 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
327
e5e9d610
PE
3282011-09-18 Paul Eggert <eggert@cs.ucla.edu>
329
87e4427a
PE
330 Fix minor problem found by static checking.
331 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
332 initialized, to pacify gcc -Wuninitialized.
333
e5e9d610
PE
334 * fileio.c: Report proper errno when syscall falls.
335 (Finsert_file_contents): Save and restore errno,
336 so that report_file_error outputs the correct diagnostic.
337 (Fwrite_region) [CLASH_DETECTION]: Likewise.
338
a1674f0b
EZ
3392011-09-18 Eli Zaretskii <eliz@gnu.org>
340
341 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
342
fbfb6dd4
EZ
3432011-09-17 Eli Zaretskii <eliz@gnu.org>
344
345 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
346 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
347
bb187662
EZ
3482011-09-17 Eli Zaretskii <eliz@gnu.org>
349
1137e8b8 350 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 351 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
352
353 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
354 (bidi_find_paragraph_start): Search back for paragraph beginning
355 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
356 (bidi_move_to_visually_next): Only trigger paragraph-related
357 computations when the last character is a newline or at EOB, not
358 just any NEUTRAL_B. (Bug#9470)
359
bb187662
EZ
360 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
361 truncated lines if point is covered by a display string. (Bug#9524)
362
2e621251
PE
3632011-09-16 Paul Eggert <eggert@cs.ucla.edu>
364
365 * xselect.c: Relax test for outgoing X longs (Bug#9498).
366 (cons_to_x_long): New function.
367 (lisp_data_to_selection_data): Use it. Correct the test for
368 short-versus-long data; it was negated. Break out of vector
369 loop, for efficiency, when a long datum is discovered.
370
91a15bc6
SM
3712011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
372
373 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
374
b41c3a35
EZ
3752011-09-16 Eli Zaretskii <eliz@gnu.org>
376
377 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
378 GCC PR/17406) by declaring this function with external scope.
379
7812ba2d
PE
3802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
381
382 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
383 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
384
cf7edc2a
AS
3852011-09-15 Andreas Schwab <schwab@linux-m68k.org>
386
387 * editfns.c (Fformat): Correctly handle text properties on "%%".
388
bd01620e
EZ
3892011-09-15 Eli Zaretskii <eliz@gnu.org>
390
391 * xterm.c (x_draw_composite_glyph_string_foreground):
392 * w32term.c (x_draw_composite_glyph_string_foreground):
393 * term.c (encode_terminal_code):
394 * composite.c (composition_update_it, get_composition_id):
395 * xdisp.c (get_next_display_element)
396 (fill_composite_glyph_string): Add comments about special meaning
397 of TAB characters in a composition.
398
a02719a3
PE
3992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
400
401 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
402 This occurs when processing a multibyte format.
403 Problem reported by Wolfgang Jenker.
a02719a3 404
72589a3c
JB
4052011-09-15 Johan Bockgård <bojohan@gnu.org>
406
407 * xdisp.c (try_cursor_movement): Only check for exact match if
408 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
409
1c14176c
PE
4102011-09-14 Paul Eggert <eggert@cs.ucla.edu>
411
412 Remove unused external symbols.
413 * dispextern.h (calc_pixel_width_or_height): Remove decl.
414 * xdisp.c (calc_pixel_width_or_height): Now static.
415 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
416 * indent.c (check_display_width):
417 * w32term.c: Fix comment to match code.
418 * xterm.c, xterm.h (x_catching_errors): Remove.
419
d2eea5b5
PE
4202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
421
422 * xselect.c: Use signed conversions more consistently (Bug#9498).
423 (selection_data_to_lisp_data): Assume incoming selection data are
424 signed integers, not unsigned. This is to be consistent with
425 outgoing selection data, which was modified to use signed integers
426 in as part of the fix to Bug#9196 in response to Jan D.'s comment
427 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
428 expects long, not unsigned long.
429
46888499
EZ
4302011-09-14 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
433 computation of loop end. Reported by Johan Bockgård
434 <bojohan@gnu.org>.
435
ef8ef9fb
CY
4362011-09-13 Chong Yidong <cyd@stupidchicken.com>
437
438 * frame.c (Fother_visible_frames_p): Function deleted.
439
fa819fed
EZ
4402011-09-12 Eli Zaretskii <eliz@gnu.org>
441
442 * indent.c (compute_motion): Process display vector front to back
443 rather than the other way around. (Bug#2496)
444
2ba8e008
SM
4452011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
446
447 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
448
20f53c69
CY
4492011-09-11 Chong Yidong <cyd@stupidchicken.com>
450
451 * minibuf.c (Fread_from_minibuffer): Doc fix.
452
d562d7a4
EZ
4532011-09-11 Eli Zaretskii <eliz@gnu.org>
454
455 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
456 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
457
1c4d7f3d
LMI
4582011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
459
460 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
461 value for non-existent files.
462
b885bf36
EZ
4632011-09-11 Eli Zaretskii <eliz@gnu.org>
464
465 * fileio.c (Finsert_file_contents): If the file cannot be opened,
466 set its "size" to -1. This will set the modtime_size field of
467 the corresponding buffer to -1, which is what
468 verify-visited-file-modtime expects for files that do not exist.
469 (Bug#9139)
470
6612f0bf
PE
4712011-09-11 Paul Eggert <eggert@cs.ucla.edu>
472
473 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
474 here ...
475 * lisp.h: ... from here. push_key_description is no longer
476 defined in keyboard.c, so its declaration should not be in
477 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
478 logically belongs with push_key_description.
479
dfb3f755
PE
4802011-09-10 Paul Eggert <eggert@cs.ucla.edu>
481
482 * buffer.h: Include <sys/types.h> instead of <time.h>.
483 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
484 Problem reported by Herbert J. Skuhra.
485
3134906c
LMI
4862011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
487
488 * xml.c (parse_region): Make the parsing work for
489 non-comment-starting XML files again (bug#9144).
490
8d903f4e
AS
4912011-09-10 Andreas Schwab <schwab@linux-m68k.org>
492
493 * image.c (gif_load): Fix calculation of bottom and right corner.
494 (Bug#9468)
495
80ad64f4
EZ
4962011-09-10 Eli Zaretskii <eliz@gnu.org>
497
498 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
499 redisplay in small windows.
500
208a048d
EZ
5012011-09-09 Eli Zaretskii <eliz@gnu.org>
502
503 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
504
9b1c252e
MR
5052011-09-08 Martin Rudalics <rudalics@gmx.at>
506
507 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
508 Operate on live windows only.
509
2949f33b
JB
5102011-09-08 Juanma Barranquero <lekktu@gmail.com>
511
512 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
513
e08dcafd
EZ
5142011-09-07 Eli Zaretskii <eliz@gnu.org>
515
516 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
517 only under bidi iteration.
518
115b96bd
JD
5192011-09-07 Jan Djärv <jan.h.d@swipnet.se>
520
521 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
522
c8199d0f
PE
5232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
524
525 isnan: Fix porting problem to Solaris 10 with bundled gcc.
526 Without this fix, the command to link temacs failed due to an
527 undefined symbol __builtin_isnan. This is because
528 /usr/include/iso/math_c99.h #defines isnan(x) to
529 __builtin_isnan(x), but the bundled gcc, which identifies itself
530 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
531 a __builtin_isnan.
532 * floatfns.c (isnan): #undef, and then #define to a clone of
533 what's in data.c.
534 (Fisnan): Always define, since it's always available now.
535 (syms_of_floatfns): Always define isnan at the Lisp level.
536
e39b275c 5372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
538
539 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
540
b2db44d9 5412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 542
f4af5137 543 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
544 The previous code assumed that file offsets (off_t values) fit in
545 EMACS_INT variables, which is not true on typical 32-bit hosts.
546 The code messed up by falsely reporting buffer overflow in cases
547 such as (insert-file-contents "big" nil 1 2) into an empty buffer
548 when "big" contains more than 2**29 bytes, even though this
549 inserts just one byte and does not overflow the buffer.
550 (Finsert_file_contents): Store file offsets as off_t
551 values, not as EMACS_INT values. Check for overflow when
552 converting between EMACS_INT and off_t. When checking for
553 buffer overflow or for overlap, take the offsets into account.
554 Don't use EMACS_INT for small values where int suffices.
555 When checking for overlap, fix a typo: ZV was used where
556 ZV_BYTE was intended.
557 (Fwrite_region): Don't assume off_t fits into 'long'.
558 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
559
ecfc0a49
MA
5602011-09-05 Michael Albinus <michael.albinus@gmx.de>
561
562 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
563
6511acf2 5642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 565
0999621a 566 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
567
568 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 569 (esprintf, exprintf, evxprintf): New functions.
62f19c19 570 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 571 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
572 (modify_event_symbol): Do not assume that the length of
573 name_alist_or_stem is safe to alloca and fits in int.
574 (Fexecute_extended_command): Likewise for function name and binding.
575 (Frecursion_depth): Wrap around reliably on integer overflow.
576 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
577 since some callers pass EMACS_INT values.
578 (Fsingle_key_description): Don't crash if symbol name contains more
579 than MAX_ALLOCA bytes.
580 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
581 (get_minibuffer): Arg is now EMACS_INT, not int.
582 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 583 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
584 * window.h (command_loop_level, minibuf_level): Reflect API changes.
585
2be7d702
PE
586 * dbusbind.c (signature_cat): New function.
587 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
588 Do not overrun buffer; instead, report string overflow.
589
9d1df220
PE
590 * dispnew.c (add_window_display_history): Don't overrun buffer.
591 Truncate instead; this is OK since it's just a log.
592
33ef5c64
PE
593 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
594 even if the time zone offset is outlandishly large.
595 Don't mishandle offset == INT_MIN.
596
66c6fdd5
PE
597 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
598 when creating daemon; the previous buffer-overflow check was incorrect.
599
d749b01b
PE
600 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
601 which has the guts of the old verror function.
602
b5cd1905
PE
603 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
604 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
605
6e1a67fb
PE
606 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
607 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 608 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 609 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
610 length of string rather than counting it via multiple sprintfs;
611 that's simpler and more reliable.
c21721cc
PE
612 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
613 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
614 sprintf, in case result does not fit in int.
615
c57b67fc
PE
616 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
617 (fontset_from_font): Print it.
618
8a401434
PE
619 * frame.c (tty_frame_count): Now printmax_t, not int.
620 (make_terminal_frame, set_term_frame_name): Print it.
621 (x_report_frame_params): In X, window IDs are unsigned long,
622 not signed long, so print them as unsigned.
623 (validate_x_resource_name): Check for implausibly long names,
624 and don't assume name length fits in 'int'.
625 (x_get_resource_string): Don't blindly alloca invocation name;
626 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
627 not fit in int.
628
6e1a67fb
PE
629 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
630 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
631 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
632
0df02bf3
PE
633 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
634 Use esprintf, not sprintf, in case result does not fit in int.
635
48e30793
PE
636 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
637 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
638 it as a large positive number.
639 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
640 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
641
a66ff6d8
PE
642 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
643 in case result does not fit in int.
644
aca216ff
PE
645 * print.c (float_to_string): Detect width overflow more reliably.
646 (print_object): Make sprintf buffer a bit bigger, to avoid potential
647 buffer overrun. Don't assume list length fits in 'int'. Treat
648 print length of 0 as 0, not as infinity; to be consistent with other
649 uses of print length in this function. Don't overflow print length
650 index. Don't assume hash table size fits in 'long', or that
651 vectorlike size fits in 'unsigned long'.
652
31c286f7
PE
653 * process.c (make_process): Use printmax_t, not int, to format
654 process-name gensyms.
655
55e5faa1
PE
656 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
657
80f2e268
PE
658 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
659 to avoid potential buffer overrun.
660
670741ab
PE
661 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
662 if X resource line is longer than 512 bytes.
663
b7163a50
PE
664 * xfns.c (x_window): Make sprintf buffer a bit bigger
665 to avoid potential buffer overrun.
666
ae58ff1f
PE
667 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
668
c43c8a6a
PE
669 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
670
3f8236f4
PE
6712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
672
53e9fe90 673 Integer overflow fixes for scrolling, etc.
6511acf2
PE
674 Without these, Emacs silently mishandles large integers sometimes.
675 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
676 it were "C-u 1 M-x recenter" on a typical 64-bit host.
677
6511acf2
PE
678 * xdisp.c (try_window_id): Check Emacs fixnum range before
679 converting to 'int'.
806add1d 680
6511acf2 681 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
682 Check that an Emacs fixnum is in range before assigning it to 'int'.
683 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
684 values converted from Emacs fixnums.
685 (Frecenter): Don't wrap around a line count if it is out of 'int'
686 range; instead, treat it as an extreme value.
687 (Fset_window_configuration, compare_window_configurations):
688 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
689
6511acf2
PE
690 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
691 that can exceed INT_MAX. Check that EMACS_INT value is in range
692 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
693 (match_limit): Don't assume that a fixnum can fit in 'int'.
694
6511acf2 695 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
696 exceed INT_MAX.
697
6511acf2 698 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
699 (Fvertical_motion): Don't wrap around LINES values that don't fit
700 in 'int'. Instead, treat them as extreme values. This is good
701 enough for windows, which can't have more than INT_MAX lines anyway.
702
fcb901a7
LMI
7032011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
704
0f2f6b6d
LMI
705 * Require libxml/parser.h to avoid compilation warning.
706
fcb901a7
LMI
707 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
708
709 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
710 since this reportedly can destroy thread storage.
711
6e20a0d4
CY
7122011-08-30 Chong Yidong <cyd@stupidchicken.com>
713
714 * syntax.c (find_defun_start): Update all cache variables if
715 exiting early (Bug#9401).
716
148ae00e
EZ
7172011-08-30 Eli Zaretskii <eliz@gnu.org>
718
f6cfbd8f
EZ
719 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
720
148ae00e
EZ
721 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
722 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
723 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
724
725 * term.c (tty_append_glyph): New function.
726 (produce_stretch_glyph): Static function and its prototype deleted.
727
a66cfb1c
SM
728 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
729 Add prototypes.
148ae00e 730
c4a07a4c
PE
7312011-08-29 Paul Eggert <eggert@cs.ucla.edu>
732
733 * image.c (parse_image_spec): Check for nonnegative, not for positive,
734 when checking :margin (Bug#9390).
735 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 736 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
737 so that the name doesn't mislead. All uses changed.
738
6bc8cd65
JB
7392011-08-28 Johan Bockgård <bojohan@gnu.org>
740
741 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
742 set_tty_hooks.
743
dca4927e
EZ
7442011-08-27 Eli Zaretskii <eliz@gnu.org>
745
746 * xdisp.c (move_it_to): Don't bail out early when reaching
747 position beyond to_charpos, if we are scanning backwards.
748 (move_it_vertically_backward): When DY == 0, make sure we get to
749 the first character in the line after the newline.
750
f2cad773
PE
7512011-08-27 Paul Eggert <eggert@cs.ucla.edu>
752
753 * ccl.c: Improve and simplify overflow checking (Bug#9196).
754 (ccl_driver): Do not generate an out-of-range pointer.
755 (Fccl_execute_on_string): Remove unnecessary check for
756 integer overflow, noted by Stefan Monnier in
757 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
758 Remove a FIXME that didn't need fixing.
759 Simplify the newly-introduced buffer reallocation code.
760
0cae2cdb
JB
7612011-08-27 Juanma Barranquero <lekktu@gmail.com>
762
763 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
764
5fc295a4 7652011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 766
70c60eb2 767 Integer and memory overflow issues (Bug#9196).
726e0ab1 768
d31850da
PE
769 * doc.c (get_doc_string): Rework so that
770 get_doc_string_buffer_size is the actual buffer size, rather than
771 being 1 less than the actual buffer size; this makes xpalloc more
772 convenient.
773
a69fbedb
PE
774 * image.c (x_allocate_bitmap_record, cache_image):
775 * xselect.c (Fx_register_dnd_atom):
776 Simplify previous changes by using xpalloc.
777
fe5c5d37
PE
778 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
779 since either will do and ptrdiff_t is convenient with xpalloc.
780
0065d054
PE
781 * charset.c (charset_table_size)
782 (struct charset_sort_data.priority): Now ptrdiff_t.
783 (charset_compare): Don't overflow if priorities differ greatly.
784 (Fsort_charsets): Don't assume list length fits in int.
785 Check for size-calculation overflow when allocating sort data.
786 (syms_of_charset): Allocate an initial charset table that is
787 just under 64 KiB, to avoid problems with glibc malloc and mmap.
788
789 * cmds.c (internal_self_insert): Check for size-calculation overflow.
790
791 * composite.h (struct composition.glyph_len): Now int, not unsigned.
792 The actual value is always <= INT_MAX, and leaving it unsigned made
793 overflow checking harder.
794
795 * dispextern.h (struct glyph_matrix.rows_allocated)
796 (struct face_cache.size): Now ptrdiff_t, for convenience in use
797 with xpalloc. The values are still always <= INT_MAX.
798
799 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
800
801 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
802 (SAFE_NALLOCA): New macro.
803
804 * region-cache.c (struct boundary.pos, find_cache_boundary)
805 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
806 (set_cache_region, invalidate_region_cache)
807 (revalidate_region_cache, know_region_cache, region_cache_forward)
808 (region_cache_backward, pp_cache):
809 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
810 so that ptrdiff_t * can be passed to xpalloc.
811 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
812 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
813 (pp_cache): Don't assume cache_len fits in int.
814 * region-cache.h: Adjust extern decls to match.
815
816 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
817 EMACS_INT, since either will do, for xpalloc.
818
819 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
820 (xnmalloc, xnrealloc, xpalloc): New functions.
821
726e0ab1
PE
822 * bidi.c (bidi_shelve_header_size): New constant.
823 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
824 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
825
51f30bc5 826 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
827 * buffer.c (overlays_at, overlays_in, record_overlay_string)
828 (overlay_strings):
829 Don't update size of array until after memory allocation succeeds,
830 because xmalloc/xrealloc may not return.
0065d054
PE
831 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
832 now that we have proper integer overflow checking.
833 (record_overlay_string, overlay_strings): Catch overflows when
834 calculating size of overlay_str_buf.
726e0ab1 835
0065d054
PE
836 * callproc.c (Fcall_process): Check for size overflow when
837 calculating size of args2.
838 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
839 Normally we prefer signed values, but sticking with ptrdiff_t would
840 require adding more-complicated checks.
726e0ab1
PE
841
842 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
843 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
844 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 845 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
846
847 * character.c (Fstring): Check for size-calculation overflow.
848
849 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
850 unnecessary integer overflow. Check for size overflow.
851 (encode_coding_object): Don't update size until xmalloc succeeds.
852
853 * composite.c (get_composition_id): Check for overflow in glyph
854 length calculations.
855
856 Integer and memory overflow fixes for display code.
857 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
858 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
859 (scrolling_window): Check for overflow in size calculations.
860 (line_draw_cost, realloc_glyph_pool, add_row_entry):
861 Don't assume glyph table len fits in int.
862 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
863 (row_table_size): Now ptrdiff_t, not int.
864 (scrolling_window): Avoid overflow in size calculations.
865 Don't update size until allocation succeeds.
866 * fns.c (concat): Check for overflow in size calculations.
867 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
868 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
869 (NEXT_ALMOST_PRIME_LIMIT): New constant.
870
871 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
872 (get_doc_string): Check for size calculation overflow.
873 Don't update size until allocation succeeds.
874 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
875 EMACS_INT, where ptrdiff_t will do.
876 (Fsubstitute_command_keys): Check for string overflow.
877
878 * editfns.c (set_time_zone_rule): Don't assume environment length
879 fits in int.
880 (message_length): Now ptrdiff_t, not int.
881 (Fmessage_box): Don't update size until allocation succeeds.
882 Don't assume message length fits in int.
883 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
884
0065d054
PE
885 * emacs.c (main): Do not reallocate argv, since there is a null at
886 the end that can be overwritten, and this way there's no need to
887 worry about size-calculation overflow.
888 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
889
890 * eval.c (init_eval_once, grow_specpdl): Don't update size until
891 alloc succeeds.
892 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
893
894 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
895 (x_set_scroll_bar_width, x_figure_window_size):
896 Check for integer overflow.
897 (x_set_alpha): Do not assume XINT fits in int.
898
899 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
900 This is for the members text_lines, text_cols, total_lines, total_cols,
901 where the system imposes an 'int' limit.
902
903 * fringe.c (Fdefine_fringe_bitmap):
904 Don't update size until alloc works.
905
906 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
907 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
908
909 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
910 Check for size-calculation overflow.
911 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
912 do, as we prefer signed integers.
913 (id_to_widget.max_size, id_to_widget.used)
914 (xg_store_widget_in_map, xg_remove_widget_from_map)
915 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
916 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
917 Use and return ptrdiff_t, not int.
918 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
919 * gtkutil.h: Change prototypes to match the above.
920
921 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
922 are duplicate now that they've been promoted to lisp.h.
923 (x_allocate_bitmap_record, x_alloc_image_color)
924 (make_image_cache, cache_image, xpm_load):
925 Don't update size until alloc is done.
926 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
927 (x_detect_edges):
3256efce 928 Check for size calculation overflow.
726e0ab1
PE
929 (ct_colors_allocated_max): New constant.
930 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
931 overflow.
3256efce 932
726e0ab1
PE
933 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
934 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
935 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
936 Use ptrdiff_t, not int, to count maps.
937 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
938 calculations. Don't update size until allocation succeeds.
939 Redo calculations to avoid overflow.
726e0ab1
PE
940 * keyboard.h: Change prototypes to match the above.
941
942 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
943 to count maps.
944 (current_minor_maps): Check for size calculation overflow.
945 * keymap.h: Change prototypes to match the above.
946
947 * lread.c (read1, init_obarray): Don't update size until alloc done.
948
949 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
950 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
951
726e0ab1
PE
952 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
953 Now ptrdiff_t, not int.
954 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
955 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
956
957 * process.c (Fnetwork_interface_list): Check for overflow
958 in size calculation.
959
960 * region-cache.c (move_cache_gap): Check for size calculation overflow.
961
962 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
963 overflow. Don't bother calling xmalloc when xrealloc will do.
964
965 * search.c (Freplace_match): Check for size calculation overflow.
966 (Fset_match_data): Don't assume list lengths fit in 'int'.
967
968 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
969 for command line length. Do not attempt to address one before the
970 beginning of an array, as that's not portable.
971
972 * term.c (max_frame_lines): Remove; unused.
973 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
974 not int.
975 (encode_terminal_code, calculate_costs): Check for size
976 calculation overflow.
977 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
978 table lengths and related sizes. Don't update size until alloc
979 done. Redo calculations to avoid overflow.
980 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
981
982 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
983 subtracting pointers.
984 (gobble_line): Check for overflow more carefully. Don't update size
985 until alloc done.
986
987 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
988 Don't update size until alloc done.
989 Redo size calculations to avoid overflow.
990 Check for size calculation overflow.
0065d054 991 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
992
993 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
994 Use ptrdiff_t, not int, for sizes.
995 (store_mode_line_noprop_char): Don't update size until alloc done.
996
0065d054
PE
997 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
998 Use ptrdiff_t, not int, for sizes.
999 (Finternal_make_lisp_face, cache_face):
1000 Check for size calculation overflow.
1001 (cache_face): Treat size calculation overflows as if they were
1002 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1003
1004 * xfns.c (x_encode_text, x_set_name_internal)
1005 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1006 sizes, since they can exceed INT_MAX in size. Check for size
1007 calculation overflow.
1008
0065d054
PE
1009 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1010 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1011 Don't update size until alloc done.
1012
0065d054 1013 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1014 as sprintf is limited to int lengths.
1d526e2f 1015
252c5ee1
PE
1016 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1017 (X_LONG_MIN): New macros.
864d7ce7
PE
1018 Use them to make the following changes clearer.
1019 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1020 This change doesn't affect the value now, but it may help remind
1021 future maintainers not to raise the value too much later.
1022 (SELECTION_QUANTUM): Remove, replacing with ...
1023 (selection_quantum): ... new function, which avoids overflow.
1024 All uses changed.
1025 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1026 assumption that selection length fits in 'int'.
1027 (x_reply_selection_request, x_handle_selection_request)
1028 (x_get_window_property, receive_incremental_selection)
1029 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1030 (lisp_data_to_selection_data, clean_local_selection_data):
1031 Use ptrdiff_t, not int, to record length of selection.
1032 (x_reply_selection_request, x_get_window_property)
1033 (receive_incremental_selection, x_property_data_to_lisp):
1034 Redo calculations to avoid overflow.
1035 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1036 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1037 something.
1038 (x_get_window_property, receive_incremental_selection)
1039 (lisp_data_to_selection_data, x_property_data_to_lisp):
1040 Check for size-calculation overflow.
1041 (x_get_window_property, receive_incremental_selection)
1042 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1043 Don't store size until memory allocation succeeds.
1044 (x_get_window_property): Plug memory leak on memory exhaustion.
1045 Don't double-block input; malloc is safe here. Don't assume 2**34
1046 - 4 fits in unsigned long. Add an xassert to check
1047 XGetWindowProperty overflow. Be more careful about overflow
1048 calculations, and distinguish size from memory overflow better.
1049 (receive_incremental_selection): When tracing, don't assume
1050 unsigned int is less than INT_MAX.
1051 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1052 harmful) conversions of unsigned short to int.
1053 (lisp_data_to_selection_data): Don't assume that integers
1054 in the range -65535 through -1 fit in an X unsigned short.
1055 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1056 result parameters unless successful. Rely on cons_to_unsigned
1057 to report problems with elements; the old code wasn't right anyway.
1058 (x_check_property_data): Check for int overflow; we cannot use
1059 a wider type due to X limits.
1060 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1061
726e0ab1 1062 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1063
0065d054
PE
1064 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1065 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1066 (x_color_cells): Don't store size until memory allocation succeeds.
1067 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1068 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1069 (x_term_init): Don't assume length fits in int (sprintf is limited
1070 to int size).
bc18e09d 1071
ebfa62c0
PE
1072 Use ptrdiff_t for composition IDs.
1073 * character.c (lisp_string_width):
1074 * composite.c (composition_table_size, n_compositions)
1075 (get_composition_id, composition_gstring_from_id):
1076 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1077 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1078 * window.c (Frecenter):
1079 Use ptrdiff_t, not int, for composition IDs.
1080 * composite.c (get_composition_id): Check for integer overflow.
1081 * composite.h: Adjust prototypes to match the above changes.
1082
d3411f89
PE
1083 Use ptrdiff_t for hash table indexes.
1084 * category.c (hash_get_category_set):
1085 * ccl.c (ccl_driver):
1086 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1087 * coding.c (coding_system_charset_list, detect_coding_system):
1088 * coding.h (struct coding_system.id):
1089 * composite.c (get_composition_id, gstring_lookup_cache):
1090 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1091 * image.c (xpm_get_color_table_h):
1092 * lisp.h (hash_lookup, hash_put):
1093 * minibuf.c (Ftest_completion):
1094 Use ptrdiff_t for hash table indexes, not int (which is too
1095 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1096 32-bit --with-wide-int hosts).
1097
e097a6fa
PE
1098 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1099 Add a FIXME comment about memory leaks.
1100 (syms_of_charset): Don't assume xmalloc returns.
1101
5637687f
PE
1102 Don't assume that stated character widths fit in int.
1103 * character.c (Fchar_width, c_string_width, lisp_string_width):
1104 * character.h (CHAR_WIDTH):
1105 * indent.c (MULTIBYTE_BYTES_WIDTH):
1106 Use sanitize_char_width to avoid undefined and/or bad behavior
1107 with outlandish widths.
a66cfb1c 1108 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1109 now that we have two such functions. All uses changed.
1110 (sanitize_char_width): New inline function.
1111
a2271ba2
PE
1112 Don't assume that tab-width fits in int.
1113 * character.h (sanitize_width): New inline function.
1114 (SANE_TAB_WIDTH): New macro.
1115 (ASCII_CHAR_WIDTH): Use it.
1116 * indent.c (sane_tab_width): Remove. All uses replaced by
1117 SANE_TAB_WIDTH (current_buffer).
1118 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1119
18c52557
PE
1120 * fileio.c: Integer overflow issues with file modes.
1121 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1122
caeeedc1
PE
1123 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1124 Remove unreachable code.
1125 (read_hex, load_charset_map_from_file): Check for integer overflow.
1126
50849c52
PE
1127 * xterm.c: don't go over XClientMessageEvent limit
1128 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1129 (x_send_scroll_bar_event): Likewise. Check that the size does not
1130 exceed limits imposed by XClientMessageEvent, as well as the usual
1131 ptrdiff_t and size_t limits.
1132
b13995db
PE
1133 * keyboard.c: Overflow, signedness and related fixes.
1134 (make_lispy_movement): Use same integer type in forward decl
1135 that is used in the definition.
1136 (read_key_sequence, keyremap_step):
1137 Change bufsize argument back to int, undoing my 2011-03-30 change.
1138 We prefer signed types, and int is wide enough here.
1139 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1140 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1141 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1142 length, not size_t. Use ptrdiff_t for index, not int.
1143 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1144 possibility of integer overflow.
1145
13464394
PE
1146 Overflow, signedness and related fixes for images.
1147
1148 * dispextern.h (struct it.stack[0].u.image.image_id)
1149 (struct_it.image_id, struct image.id, struct image_cache.size)
1150 (struct image_cache.used, struct image_cache.ref_count):
1151 * gtkutil.c (update_frame_tool_bar):
1152 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1153 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1154 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1155 * nsmenu.m (update_frame_tool_bar):
1156 * xdisp.c (calc_pixel_width_or_height):
1157 * xfns.c (image_cache_refcount):
1158 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1159 on typical 64-bit hosts.
1160
1161 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1162 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1163 Omit unnecessary casts to int.
1164 (parse_image_spec): Check that integers fall into 'int' range
1165 when the callers expect that.
1166 (image_ascent): Redo ascent calculation to avoid int overflow.
1167 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1168 (lookup_image): Remove unnecessary tests.
1169 (xbm_image_p): Locals are now of int, not EMACS_INT,
1170 since parse_image_check makes sure they fit into int.
1171 (png_load, gif_load, svg_load_image):
1172 Prefer int to unsigned where either will do.
1173 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1174 old tiff_error_handler and tiff_warning_handler.
1175 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1176 stack buffer overflows. It uses only the features of vsnprintf
1177 that are common to both POSIX and native Microsoft.
1178 (tiff_error_handler, tiff_warning_handler): Use it.
1179 (tiff_load, gif_load, imagemagick_load_image):
1180 Don't assume :index value fits in 'int'.
1181 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1182 (imagemagick_load_image): Check that crop parameters fit into
1183 the integer types that MagickCropImage accepts. Don't assume
1184 Vimagemagick_render_type has a nonnegative value. Don't assume
1185 size_t fits in 'long'.
1186 (gs_load): Use printmax_t to print the widest integers possible.
1187 Check for integer overflow when computing image height and width.
1188
c11821d4
EZ
11892011-08-26 Eli Zaretskii <eliz@gnu.org>
1190
1191 * xdisp.c (redisplay_window): Don't force window start if point
1192 will be invisible in the resulting window. (Bug#9324)
1193
0c95fcf7
EZ
11942011-08-25 Eli Zaretskii <eliz@gnu.org>
1195
1196 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1197 the display spec is of the form `(space ...)'.
1198 (handle_display_spec): Return the value returned by
1199 handle_single_display_spec, not just 1 or zero.
1200 (handle_single_display_spec): If the display spec is of the form
1201 `(space ...)', and specifies display in the text area, return 2
1202 rather than 1.
fee65a97 1203 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1204 accurately, and prefer exact match for point under bidi.
1205 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1206
1207 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1208 into disp_prop; all users changed.
1209
1210 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1211 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1212 for the text covered by the display property.
1213
e4ed06f1
CY
12142011-08-25 Chong Yidong <cyd@stupidchicken.com>
1215
1216 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1217 Change return value to nil.
1218 (Frecord_buffer): Delete unused function.
1219
f67cdd7f
EZ
12202011-08-24 Eli Zaretskii <eliz@gnu.org>
1221
5980d4c6
EZ
1222 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1223 buffers, return left-to-right.
8610fe8b
EZ
1224 (set_cursor_from_row): Consider candidate row a win if its glyph
1225 represents a newline and point is on that newline. Fixes cursor
1226 positioning on the newline at EOL of R2L text within L2R
1227 paragraph, and vice versa.
1228 (try_cursor_movement): Check continued rows, in addition to
1229 continuation rows. Fixes unwarranted scroll when point enters a
1230 continued line of R2L text within an L2R paragraph, or vice versa.
1231 (cursor_row_p): Consider the case of point being equal to
1232 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1233 from the end of a short line to the beginning of a continued line
1234 of R2L text within L2R paragraph.
1235 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1236 composed characters.
5980d4c6 1237
f67cdd7f
EZ
1238 * bidi.c (bidi_check_type): Use xassert.
1239 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1240 members.
1241
bca633fb
EZ
12422011-08-23 Eli Zaretskii <eliz@gnu.org>
1243
1244 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1245 a character.
1246
4a5885a7
CY
12472011-08-23 Chong Yidong <cyd@stupidchicken.com>
1248
1249 * nsfont.m (ns_otf_to_script): Fix typo.
1250
0902a04e
KH
12512011-08-22 Kenichi Handa <handa@m17n.org>
1252
1253 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1254 extra slot even if the purpose is char-code-property-table.
1255
1a2e6670
EZ
12562011-08-23 Eli Zaretskii <eliz@gnu.org>
1257
8ddde651
EZ
1258 * xdisp.c (redisplay_window): When computing centering_position,
1259 account for the height of the header line. (Bug#8874)
1260
425cc014
EZ
1261 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1262 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1263 candidate is selected by the mouse, and that candidate has a
1264 composed character under the mouse.
1265
1a2e6670
EZ
1266 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1267 coordinates reported by pos-visible-in-window-p for a composed
1268 character in column zero.
1269
8b76d6f8
SM
12702011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1271
1272 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1273
dac347dd
EZ
12742011-08-22 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1277 consider it a hit if to_charpos is anywhere in the range of the
1278 composed buffer positions.
1279
e013fb34
CY
12802011-08-22 Chong Yidong <cyd@stupidchicken.com>
1281
1282 * image.c (gif_load): Don't assume that each subimage has the same
1283 dimensions as the base image. Handle disposal method that is
1284 "undefined" by the gif spec (Bug#9335).
1285
bd1ba3e8
CY
12862011-08-20 Chong Yidong <cyd@stupidchicken.com>
1287
1288 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1289 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1290
54a1215b
EZ
12912011-08-19 Eli Zaretskii <eliz@gnu.org>
1292
823564e5
EZ
1293 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1294 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1295 from an Org mode buffer to a Speedbar frame.
1296
54a1215b
EZ
1297 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1298 a composition, take its buffer position from IT->cmp_it.charpos.
1299 Fixes cursor positioning at the beginning of a line that begins
1300 with a composed character.
1301
9778ebcc
EZ
13022011-08-18 Eli Zaretskii <eliz@gnu.org>
1303
0be6ee06
EZ
1304 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1305 character bidirectional type, use STRONG_L instead. Fixes crashes
1306 in a buffer produced by `describe-categories'.
1307
9778ebcc
EZ
1308 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1309 members before the level stack, so they would be saved and
1310 restored when copying iterator state. Fixes incorrect reordering
1311 around TABs covered by display properties.
1312
156bffbe
AS
13132011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1314
6b02f655 1315 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1316
72ad093b
CY
13172011-08-17 Chong Yidong <cyd@stupidchicken.com>
1318
1319 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1320 (internal_condition_case_2, internal_condition_case_n):
1321 Remove unnecessary aborts (Bug#9081).
72ad093b 1322
35774242
EZ
13232011-08-17 Eli Zaretskii <eliz@gnu.org>
1324
1325 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1326 has no `load' handler, try opening the file locally. (Bug#9311)
1327
db76dd85
KB
13282011-08-16 Ken Brown <kbrown@cornell.edu>
1329
1330 * gmalloc.c: Expand comment.
1331
b215eee5
EZ
13322011-08-16 Eli Zaretskii <eliz@gnu.org>
1333
1334 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1335 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1336
a4579d33
KB
13372011-08-16 Ken Brown <kbrown@cornell.edu>
1338
1339 Fix memory allocation problems in Cygwin build (Bug#9273).
1340
1341 * unexcw.c ( __malloc_initialized): Declare external variable.
1342 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1343
8b76d6f8
SM
1344 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1345 New variables.
a4579d33
KB
1346 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1347 dumped emacs.
1348 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1349 in the static heap.
1350 [CYGWIN] (special_realloc): New function.
1351 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1352 requests to realloc storage in the static heap.
1353
3ebec551
PE
13542011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 * bidi.c (bidi_initialize): Remove unused local.
1357
9fd8be00
EZ
13582011-08-15 Eli Zaretskii <eliz@gnu.org>
1359
6b02f655
SM
1360 * bidimirror.h:
1361 * biditype.h: Remove file.
1362 * makefile.w32-in ($(BLD)/bidi.$(O)):
1363 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1364
1365 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1366
1367 * chartab.c: Improve commentary for the uniprop_table API.
1368
32413314
EZ
1369 * bidi.c (bidi_paragraph_init): Support zero value of
1370 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1371 (bidi_initialize): Use uniprop_table instead of including
1372 biditype.h and bidimirror.h.
32413314 1373
9fd8be00
EZ
1374 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1375 coordinates of the iterator when restoring from ppos_it.
1376 (Bug#9296)
1377
5cf2b69b
KH
13782011-08-14 Kenichi Handa <handa@m17n.org>
1379
1380 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1381 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1382
daf17d00
EZ
13832011-08-14 Eli Zaretskii <eliz@gnu.org>
1384
1385 * xdisp.c (move_it_in_display_line_to): Don't invoke
1386 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1387 ppos_it. Fixes vertical cursor motion when line beginning is
1388 covered by an image. (Bug#9296)
1389
08e3161a
JD
13902011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1391
1392 * nsterm.h (ns_run_ascript): Declare.
1393 (NSAPP_DATA2_RUNASSCRIPT): Define.
1394
1395 * nsfns.m (as_script, as_result, as_status): New static variables.
1396 (ns_run_ascript): New function.
5e617bc2 1397 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1398 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1399 the event loop. Get status from as_status (Bug#7276).
1400
1401 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1402 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1403 the event loop (Bug#7276).
1404
a3720aa2
AS
14052011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1406
1407 * gnutls.c (QCgnutls_bootprop_priority)
1408 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1409 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1410 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1411 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1412 (QCgnutls_bootprop_verify_hostname_error)
1413 (QCgnutls_bootprop_callbacks_verify): Rename from
1414 Qgnutls_bootprop_..., all uses changed.
1415
1416 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1417 uses changed.
1418
0a0d27fb
PE
14192011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1420
19d5c50c
PE
1421 * xfaces.c (Qframe_set_background_mode): Now static.
1422 * dispextern.h (Qframe_set_background_mode): Remove decl.
1423
0a0d27fb
PE
1424 * process.c (Fnetwork_interface_info): Declare local only if needed.
1425
377538cb
JD
14262011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1427
1428 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1429 (Fnetwork_interface_list): Allocate in increments of bytes instead
1430 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1431 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1432 sockaddr.
1433 (struct ifflag_def): notrailers is smart on OSX.
1434 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1435 Get hardware address with getifaddrs if available.
1436
08fff70c
EZ
14372011-08-12 Eli Zaretskii <eliz@gnu.org>
1438
1439 * xdisp.c (iterate_out_of_display_property): xassert that
1440 IT->position is set to within IT->object's boundaries. Break from
1441 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1442 when IT->position is set up wrongly due to some bug.
1443 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1444 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1445 entry. Force push_it to save on the stack the current
1446 buffer/string position, to be restored by pop_it. Fix flags in
1447 the iterator structure wrt the object coming from a display
1448 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1449 properties. (Bug#9284)
1450
7be1c708 14512011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1452
7be1c708
CY
1453 * fontset.c (fontset_get_font_group): Add proper type checks.
1454 (Bug#9172)
aac0c6e3 1455
7be1c708 14562011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1457
7be1c708
CY
1458 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1459 and LC_VERSION_MIN_MACOSX.
1460 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1461 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1462
97bb72a6
EZ
14632011-08-08 Eli Zaretskii <eliz@gnu.org>
1464
1465 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1466 no-display-properties-and-no-overlays under bidi display.
1467 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1468 properties and overlays.
97bb72a6 1469
d5617611
CY
14702011-08-08 Chong Yidong <cyd@stupidchicken.com>
1471
37e11a63
CY
1472 * editfns.c (Fset_time_zone_rule): Document relationship with the
1473 setenv function.
1474
d5617611
CY
1475 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1476 the font entity extracted from the cache (Bug#8109).
1477
58872834
CY
14782011-08-07 Chong Yidong <cyd@stupidchicken.com>
1479
1480 * composite.c (autocmp_chars): Don't reset point. That is done by
1481 restore_point_unwind (Bug#5984).
1482
75bfc667
JL
14832011-08-07 Juri Linkov <juri@jurta.org>
1484
1485 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1486 to show the arg `TIME' instead of `TIMEVAL'.
1487
d1410150
EZ
14882011-08-06 Eli Zaretskii <eliz@gnu.org>
1489
1490 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1491 display property strides EOL and includes a newline, as in
1492 longlines-mode. (Bug#9254)
75b771e4
EZ
1493 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1494 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1495
1496 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1497 is non-zero, even if the data buffer is NULL. Fixes a crash in
1498 vertical-motion with longlines-mode. (Bug#9254)
1499
35928349
EZ
15002011-08-05 Eli Zaretskii <eliz@gnu.org>
1501
ec7cc85b
EZ
1502 * bidi.c <bidi_cache_total_alloc>: Now static.
1503 (bidi_initialize): Initialize bidi_cache_total_alloc.
1504
8b76d6f8 1505 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1506 cache. (Bug#9221)
1507
1508 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1509 amount allocated this far in `bidi_cache_total_alloc'.
1510 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1511 non-zero, only free the data buffer without restoring the cache
1512 contents. All callers changed.
1513
1514 * dispextern.h (bidi_unshelve_cache): Update prototype.
1515
1516 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1517 (move_it_in_display_line, move_it_to)
1518 (move_it_vertically_backward, move_it_by_lines): Replace the call
1519 to xfree to an equivalent call to bidi_unshelve_cache.
1520 (move_it_in_display_line_to): Fix logic of returning
412b6358 1521 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1522
e2e2423b
EZ
15232011-08-05 Eli Zaretskii <eliz@gnu.org>
1524
1525 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1526 came from a string character with a `cursor' property. (Bug#9229)
1527
ae9e757a
JD
15282011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1529
1530 * Makefile.in (LIB_PTHREAD): New variable.
1531 (LIBES): Add LIB_PTHREAD (Bug#9216).
1532
1533 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1534 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1535
213bd7f2
AS
15362011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1537
6b02f655 1538 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1539
99aaf75f
JD
15402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1541
1542 * xterm.c (x_find_topmost_parent): New function.
1543 (x_set_frame_alpha): Find topmost parent window with
1544 x_find_topmost_parent and set the property there also (bug#9181).
1545 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1546
c74e9d86
PE
15472011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1548
1549 * callproc.c (Fcall_process): Avoid vfork clobbering
1550 the local vars buffer, coding_systems, current_dir.
1551
640c8776
SM
15522011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1553
1554 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1555
f26d0e4c
PE
15562011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1557
8a10d76c
PE
1558 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1559 so that it is not optimized away.
1560
f26d0e4c
PE
1561 * xdisp.c (compute_display_string_pos): Remove unused local.
1562
55439c61
EZ
15632011-08-02 Eli Zaretskii <eliz@gnu.org>
1564
1565 Fix slow cursor motion and scrolling in large buffers with
1566 selective display, like Org Mode buffers. (Bug#9218)
1567
1568 * dispextern.h (struct bidi_it): New member disp_prop_p.
1569
1570 * xdisp.c: Remove one-slot cache of display string positions.
1571 (compute_display_string_pos): Accept an additional argument
5e617bc2 1572 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1573 for a display string or property. If found, set DISP_PROP_P
1574 non-zero.
1575
1576 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1577 DISP_PROP_P, and pass it to compute_display_string_pos.
1578 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1579 non-zero. All callers of bidi_fetch_char changed.
1580
fb33fa43
SM
15812011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1582
1583 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1584
b099e063
DM
15852010-12-03 Don March <don@ohspite.net>
1586
1587 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1588 last character M-[char] is translated to ESC [char] (bug#7541).
1589
5cc7f7af
KH
15902011-08-02 Kenichi Handa <handa@m17n.org>
1591
d0fffa3f 1592 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1593
1594 * chartab.c (uniprop_table): Make it non-static.
1595
525d5e6e
EZ
15962011-08-01 Eli Zaretskii <eliz@gnu.org>
1597
1598 * xdisp.c (forward_to_next_line_start): Accept additional argument
1599 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1600 on the newline.
1601 (reseat_at_next_visible_line_start): Use the bidi iterator state
1602 returned by forward_to_next_line_start to restore the state of
1603 it->bidi_it after backing up to previous newline. (Bug#9212)
1604
31011111
AS
16052011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1606
1607 * regex.c (re_comp): Protoize.
1608 (re_exec): Fix return type.
1609 (regexec): Fix type of `ret'. (Bug#9203)
1610
476371c4
PE
16112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1612
e5d76069
PE
1613 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1614 This is needed if max-image-size is a floating-point number.
1615
9a79b20c
AS
16162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1617
1618 * print.c (print_object): Print empty symbol as ##.
1619
1620 * lread.c (read1): Read ## as empty symbol.
1621
d8c2fa78
AA
16222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1623
1624 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1625 setting frame foreground color (Bug#9175).
1626 (x_set_background_color): Likewise.
1627
ffe57a7a
AA
1628 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1629 contents (Bug#9176).
1630 (EmacsTooltip -init): Remove bezels and add shadows to
1631 tooltip windows.
1632
bf3492a5
AA
1633 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1634 or scroll bar (Bug#8470).
1635
d55e9c53
AA
1636 * nsfont.m (nsfont_open): Remove assignment to voffset and
1637 unnecessary vars hshink, expand, hd, full_height, min_height.
1638 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1639
1640 * nsterm.h (nsfont_info): Remove voffset field.
1641
d8c2fa78 16422011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1643
1644 Implement strike-through and overline on NextStep (Bug#8863).
1645
1646 * nsfont.m (nsfont_open): Use underline position provided by font,
1647 instead of hard-coded value of 2.
1648 (nsfont_draw): Call ns_draw_text_decoration instead.
1649
1650 * nsterm.h: Add declaration for ns_draw_text_decoration.
1651
1652 * nsterm.m (ns_draw_text_decoration): New function for drawing
1653 underline, overline, and strike-through.
1654 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1655 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1656 accommodate underlining, etc.
4843aac3 1657
4cc60b9b
EZ
16582011-07-28 Eli Zaretskii <eliz@gnu.org>
1659
bc7ece87
EZ
1660 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1661 default.
4cc60b9b 1662
476371c4
PE
16632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1664
66606eea
PE
1665 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1666 Without this fix, if a signal arrives just after memory fills up,
1667 'malloc' might be invoked reentrantly.
1668
476371c4
PE
1669 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1670 In other words, assume that every image size is allowed, on non-X
1671 hosts. This assumption is probably wrong, but it lets Emacs compile.
1672
f3fcc40d
AS
16732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1674
1675 * regex.c (re_iswctype): Convert return values to boolean.
1676
350c992f
EZ
16772011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1678
1679 * xdisp.c (compute_display_string_pos): Don't use cached display
1680 string position if the buffer had its restriction changed.
1681 (Bug#9184)
1682
5266b4bb
PE
16832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1686
2573a837 16872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1688
41f55ccd 1689 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1690
39e378da
PE
1691 * bidi.c: Integer size and overflow fixes.
1692 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1693 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1694 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1695 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1696 (bidi_find_other_level_edge):
1697 Use ptrdiff_t instead of EMACS_INT where either will do.
1698 This works better on 32-bit hosts configured --with-wide-int.
1699 (bidi_cache_ensure_space): Check for size-calculation overflow.
1700 Use % rather than repeated addition, for better worst-case speed.
1701 Don't set bidi_cache_size until after xrealloc returns, because it
1702 might not return.
1703 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1704 (bidi_cache_ensure_space): Also check that the bidi cache size
1705 does not exceed that of the largest Lisp string or buffer. See Eli
1706 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1707
5e927815
PE
1708 * alloc.c (__malloc_size_t): Remove.
1709 All uses replaced by size_t. See Andreas Schwab's note
1710 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1711
ca4aa935
PE
1712 * image.c: Improve checking for integer overflow.
1713 (check_image_size): Assume that f is nonnull, since
1714 it is always nonnull in practice. This is one less thing to
1715 worry about when checking for integer overflow later.
1716 (x_check_image_size): New function, which checks for integer
1717 overflow issues inside X.
1718 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1719 This removes the need for a memory_full check.
1720 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1721 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1722 (xbm_read_bitmap_data): Change locals back to 'int', since
1723 their values must fit in 'int'.
1724 (xpm_load_image, png_load, tiff_load):
1725 Invoke x_create_x_image_and_pixmap earlier,
1726 to avoid much needless work if the image is too large.
1727 (tiff_load): Treat overly large images as if
1728 x_create_x_image_and_pixmap failed, not as malloc failures.
1729 (gs_load): Use x_check_image_size.
1730
5f8f9cc2
PE
1731 * gtkutil.c: Omit integer casts.
1732 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1733 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1734
5adf60bc
PE
1735 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1736
c8907a93
PE
1737 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1738 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1739 would wrongly return t on a 64-bit host.
1740
e3c25c68
PE
1741 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1742 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1743 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1744 and therefore cause GCC to emit a bogus diagnostic in some cases.
1745
3f791afe
PE
1746 * image.c: Integer signedness and overflow and related fixes.
1747 This is not an exhaustive set of fixes, but it's time to
1748 record what I've got.
1749 (lookup_pixel_color, check_image_size): Remove redundant decls.
1750 (check_image_size): Don't assume that arbitrary EMACS_INT values
1751 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1752 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1753 (tiff_load, imagemagick_load_image):
1754 Check for overflow in size calculations.
1755 (x_create_x_image_and_pixmap): Remove unnecessary test for
1756 xmalloc returning NULL; that can't happen.
1757 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1758 (xpm_color_bucket): Use better integer hashing function.
1759 (xpm_cache_color): Don't possibly over-allocate memory.
1760 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1761 (gif_memory_source):
1762 Use ptrdiff_t, not int or size_t, to record sizes.
1763 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1764 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1765 either works, as we prefer signed integers.
1766 (tiff_read_from_memory, tiff_write_from_memory):
1767 Return tsize_t, not size_t, since that's what the TIFF API wants.
1768 (tiff_read_from_memory): Don't fail simply because the read would
1769 go past EOF; instead, return a short read.
1770 (tiff_load): Omit no-longer-needed casts.
1771 (Fimagemagick_types): Don't assume size fits into 'int'.
1772
3cc5a532
PE
1773 Improve hashing quality when configured --with-wide-int.
1774 * fns.c (hash_string): New function, taken from sxhash_string.
1775 Do not discard information about ASCII character case; this
1776 discarding is no longer needed.
1777 (sxhash-string): Use it. Change sig to match it. Caller changed.
1778 * lisp.h: Declare it.
1779 * lread.c (hash_string): Remove, since we now use fns.c's version.
1780 The fns.c version returns a wider integer if --with-wide-int is
1781 specified, so this should help the quality of the hashing a bit.
1782
b312a492
PE
1783 * emacs.c: Integer overflow minor fix.
1784 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1785 Define only if GNU_LINUX.
1786 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1787
dfd153ae
PE
1788 * dispnew.c: Integer signedness and overflow fixes.
1789 Remove unnecessary forward decls, that were a maintenance hassle.
1790 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1791 All uses changed.
1792 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1793 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1794 (prepare_desired_row, line_draw_cost):
1795 Use int, not unsigned, where either works.
1796 (save_current_matrix, restore_current_matrix):
1797 Use ptrdiff_t, not size_t, where either works.
1798 (init_display): Check for overflow more accurately, and without
1799 relying on undefined behavior.
1800
a81d11a3
PE
1801 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1802 Remove, replacing with the new symbols in lisp.h. All uses changed.
1803 * fileio.c (make_temp_name):
1804 * filelock.c (lock_file_1, lock_file):
1805 * xdisp.c (message_dolog):
1806 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1807 Use pMd etc. instead.
1808 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1809 replacing the pWIDE etc. symbols removed from editfns.c.
1810
3300e6fd
PE
1811 * keyboard.h (num_input_events): Now uintmax_t.
1812 This is (very slightly) less likely to mess up due to wraparound.
1813 All uses changed.
1814
fd05c7e9
PE
1815 * buffer.c: Integer signedness fixes.
1816 (alloc_buffer_text, enlarge_buffer_text):
1817 Use ptrdiff_t rather than size_t when either will do, as we prefer
1818 signed integers.
1819
903fe15d
PE
1820 * alloc.c: Integer signedness and overflow fixes.
1821 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1822 (__malloc_size_t): Default to size_t, not to int.
1823 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1824 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1825 Prefer ptrdiff_t to size_t when either would do, as we prefer
1826 signed integers.
1827 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1828 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1829 Now const. Initialize with values that are in range even if char
1830 is signed.
1831 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1832 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1833 These functions do the right thing with sizes > 2**32.
1834 (check_depth): Now ptrdiff_t, not int.
1835 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1836 Adjust to new way of storing sizes. Check for size overflow bugs
1837 in rest of code.
1838 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1839 slightly wrong anyway, as it missed one instance of
1840 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1841 (refill_memory_reserve): Omit needless cast to size_t.
1842 (mark_object_loop_halt): Mark as externally visible.
1843
ac82cc6a
PE
1844 * xselect.c: Integer signedness and overflow fixes.
1845 (Fx_register_dnd_atom, x_handle_dnd_message):
1846 Use ptrdiff_t, not size_t, since we prefer signed.
1847 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1848 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1849 x_dnd_atoms_size and x_dnd_atoms_length.
1850
c2d1e36d
PE
1851 * doprnt.c: Prefer signed to unsigned when either works.
1852 * eval.c (verror):
1853 * doprnt.c (doprnt):
1854 * lisp.h (doprnt):
1855 * xdisp.c (vmessage):
1856 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1857 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1858 prefer signed arithmetic to avoid comparison confusion.
1859 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1860 but is a bit tricky.
1861
0e926e56
PE
1862 Assume freestanding C89 headers, string.h, stdlib.h.
1863 * data.c, doprnt.c, floatfns.c, print.c:
1864 Include float.h unconditionally.
1865 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1866 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1867 * regex.c: Likewise for stddef.h, string.h.
1868 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1869 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1870 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1871 (STDC_HEADERS): Remove obsolete defines.
1872 * sysdep.c: Include limits.h unconditionally.
1873
9cfdb3ec
PE
1874 Assume support for memcmp, memcpy, memmove, memset.
1875 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1876 * regex.c (memcmp, memcpy):
1877 Remove; we assume C89 now.
1878
1879 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1880 (__malloc_safe_bcopy): Remove; no longer needed.
1881
cf950e6b 1882 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1883 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1884 well either way, and we prefer signed to unsigned.
1885
dbf38e02
LMI
18862011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1887
1888 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1889 closes the connection while we're reading (bug#9182).
1890
d6f0886c 18912011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1892
d6f0886c
JD
1893 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1894 are specified (Bug#9168).
24e0f6b1 1895
2eb1f9e6
PE
18962011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1899 Found by GCC static checking and --with-wide-int on a 32-bit host.
1900
22381272 19012011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1902
1903 * xdisp.c (compute_display_string_pos): Fix logic of caching
1904 previous display string position. Initialize cached_prev_pos to
1905 -1. Fixes slow-down at the beginning of a buffer.
1906
f25e39b4
EZ
19072011-07-24 Eli Zaretskii <eliz@gnu.org>
1908
1909 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1910 for attrs[LFACE_FONTSET_INDEX].
1911
04c4b52e
PE
19122011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 * xml.c (parse_region): Remove unused local
1915 that was recently introduced.
1916
c1734fbd
EZ
19172011-07-23 Eli Zaretskii <eliz@gnu.org>
1918
be18c5a5
EZ
1919 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1920 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1921
c1734fbd
EZ
1922 * xdisp.c (move_it_in_display_line_to): Record the best matching
1923 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1924 exit if none of the characters scanned was an exact match.
1925 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1926 when exact match is impossible due to invisible text, and the
1927 lines are truncated.
1928
a258d627
JD
19292011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1930
1931 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1932 for OSX >= 10.7.
1933
b6d5a689
EZ
19342011-07-22 Eli Zaretskii <eliz@gnu.org>
1935
0f74f785
EZ
1936 Fix a significant slow-down of cursor motion with C-n, C-p,
1937 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1938 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1939 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1940 (next_element_from_buffer): Call compute_stop_pos_backwards to
1941 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1942 base_level_stop.
1943 (reseat): Don't look for prev_stop, as that could mean a very long
1944 run.
1945 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1946 <cached_disp_overlay_modiff>: Cache for last found display string
1947 position.
551918c1 1948 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1949 about the same buffer in the same area of character positions, and
1950 the buffer wasn't changed since the time the display string
1951 position was cached.
551918c1 1952
b2d0c91a
EZ
19532011-07-22 Eli Zaretskii <eliz@gnu.org>
1954
1955 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1956 is an integer, which is important for empty lines. (Bug#9149)
1957
043604ee
CY
19582011-07-22 Chong Yidong <cyd@stupidchicken.com>
1959
1960 * frame.c (Fmodify_frame_parameters): In tty case, update the
1961 default face if necessary (Bug#4238).
1962
da4adb04
CY
19632011-07-21 Chong Yidong <cyd@stupidchicken.com>
1964
1965 * editfns.c (Fstring_to_char): No need to explain what a character
1966 is in the docstring (Bug#6576).
1967
9abd0532
LMI
19682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1969
1970 * xml.c (parse_region): Make sure we always return a tree.
1971
36881d16
HK
19722011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1973
1974 * xml.c (parse_region): If a document contains only comments,
1975 return that, too.
1976
1e98674d
LMI
19772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978
1979 * xml.c (make_dom): Return comments, too.
1980
590bd467
PE
19812011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 Port to OpenBSD.
1984 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1985 and the surrounding thread.
1986 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1987 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1988 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1989 timer goes off.
1990 * s/openbsd.h (BROKEN_SIGIO): Define.
1991 * unexelf.c (unexec) [__OpenBSD__]:
1992 Don't update the .mdebug section of the Alpha COFF symbol table.
1993
f41628b2
LMI
19942011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1995
1996 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1997 (bug#8460).
1998
b59b67c5
PE
19992011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2000
15e3a074
PE
2001 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2002 This fixes some race conditions on the permissions of any newly
2003 created file.
2004
41bed37d
PE
2005 * alloc.c (valid_pointer_p): Use pipe, not open.
2006 This fixes some permissions issues when debugging.
2007
b59b67c5
PE
2008 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2009 If fchown fails to set both uid and gid, try to set just gid,
2010 as that is sometimes allowed. Adjust the file's mode to eliminate
2011 setuid or setgid bits that are inappropriate if fchown fails.
2012
925a6be7
SM
20132011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2014
2015 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2016 to compare Lisp_Objects.
2017 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2018 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2019 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2020
52968808
AS
20212011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2022
0a6a104b
AS
2023 * lread.c (read_integer): Unread even EOF character.
2024 (read1): Likewise. Properly record start position of symbol.
2025
52968808
AS
2026 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2027 symbol character follows.
2028
9e381cdd
PE
20292011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2030
2031 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2032 This works around a problem with the previous change to Fcopy_file.
2033 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2034 and without this change, GCC might complain about discarding
2035 fchown's return value.
2036
b5641435
JB
20372011-07-16 Juanma Barranquero <lekktu@gmail.com>
2038
2039 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2040
a8031457
PE
20412011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2042
2043 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2044
dd889327
LMI
20452011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2046
750c33f7
LMI
2047 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2048 it's used from the C level.
2049
dd889327
LMI
2050 * process.c: Use the same condition for POLL_FOR_INPUT in both
2051 keyboard.c and process.c (bug#1858).
2052
87e86684
LM
20532011-07-09 Lawrence Mitchell <wence@gmx.li>
2054
2055 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2056 (Fgnutls_boot): Use it.
2057
64348f40
AS
20582011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2059
2060 * doc.c (Fsubstitute_command_keys): Revert last change.
2061
1d698799
LMI
20622011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2063
f863868c
LMI
2064 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2065 quotes the next character, and doesn't affect other longer
2066 sequences (bug#8935).
2067
1d698799
LMI
2068 * lread.c (syms_of_lread): Clarify that is isn't only
2069 `eval-buffer' and `eval-defun' that's affected by
2070 `lexical-binding' (bug#8460).
2071
aa4b6df6
EZ
20722011-07-15 Eli Zaretskii <eliz@gnu.org>
2073
2074 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2075 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2076
5d856da6
PE
20772011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2078
ad6042bb
PE
2079 Fix minor problems found by static checking.
2080 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2081 (elsz): Now a signed constant, not a size_t var. We prefer signed
2082 types to unsigned, to avoid integer comparison confusion. Without
2083 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2084 "cannot optimize loop, the loop counter may overflow", a symptom
2085 of the confusion.
f00bbb22 2086 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2087 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2088
6468f31c
LMI
20892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2090
49080b10
LMI
2091 * search.c (Fre_search_backward): Mention `case-fold-search' in
2092 all the re_search_* functions (bug#8138).
2093
6468f31c
LMI
2094 * keyboard.c (Fopen_dribble_file): Document when the file is
2095 closed (bug#8056).
2096
c965adc5
EZ
20972011-07-14 Eli Zaretskii <eliz@gnu.org>
2098
df9733bf
EZ
2099 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2100 bidi_cache_idx.
2101
0bb23927
EZ
2102 Support bidi reordering of display and overlay strings.
2103 * xdisp.c (compute_display_string_pos)
2104 (compute_display_string_end): Accept additional argument STRING.
2105 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2106 (reseat_to_string): Initialize bidi_it->string.s and
2107 bidi_it->string.schars.
2108 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2109 NULL (avoids a crash in bidi_paragraph_init).
2110 Initialize itb.string.lstring.
0bb23927
EZ
2111 (init_iterator): Call bidi_init_it only of a valid
2112 buffer position was specified. Initialize paragraph_embedding to
2113 L2R.
2114 (reseat_to_string): Initialize the bidi iterator.
2115 (display_string): If we need to ignore text properties of
2116 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2117 original value of -1 will not work with bidi.)
2118 (compute_display_string_pos): First arg is now struct
2119 `text_pos *'; all callers changed. Support display properties on
2120 Lisp strings.
2121 (compute_display_string_end): Support display properties on Lisp
2122 strings.
2123 (init_iterator, reseat_1, reseat_to_string): Initialize the
2124 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2125 when iterating on a string not from display properties).
640c8776
SM
2126 (compute_display_string_pos, compute_display_string_end):
2127 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2128 arrow keys.
2129 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2130 base_level_stop; instead, set base_level_stop to BEGV.
2131 Fixes crashes in vertical-motion.
0bb23927
EZ
2132 (next_element_from_buffer): Improve commentary for when
2133 the iterator is before prev_stop.
2134 (init_iterator): Initialize bidi_p from the default value of
2135 bidi-display-reordering, not from buffer-local value. Use the
2136 buffer-local value only if initializing for buffer iteration.
2137 (handle_invisible_prop): Support invisible properties on strings
2138 that are being bidi-reordered.
2139 (set_iterator_to_next): Support bidi reordering of C strings and
2140 Lisp strings.
2141 (next_element_from_string): Support bidi reordering of Lisp
2142 strings.
2143 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2144 (display_string): Support display of R2L glyph rows.
2145 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2146 (init_iterator): Don't initialize it->bidi_p for strings
2147 here.
2148 (reseat_to_string): Initialize it->bidi_p for strings here.
2149 (next_element_from_string, next_element_from_c_string)
2150 (next_element_from_buffer): Add xassert's for correspondence
2151 between IT's object being iterated and it->bidi_it.string
2152 structure.
2153 (face_before_or_after_it_pos): Support bidi iteration.
2154 (next_element_from_c_string): Handle the case of the first string
2155 character that is not the first one in the visual order.
2156 (get_visually_first_element): New function, refactored from common
2157 parts of next_element_from_buffer, next_element_from_string, and
2158 next_element_from_c_string.
2159 (tool_bar_lines_needed, redisplay_tool_bar)
2160 (display_menu_bar): Force left-to-right direction. Add a FIXME
2161 comment for making that be controlled by a user option.
2162 (push_it, pop_it): Save and restore the state of the
2163 bidi iterator. Save and restore the bidi_p flag.
2164 (pop_it): Iterate out of display property for string iteration as
2165 well.
2166 (iterate_out_of_display_property): Support iteration over strings.
2167 (handle_single_display_spec): Set up it->bidi_it for iteration
2168 over a display string, and call bidi_init_it.
2169 (handle_single_display_spec, next_overlay_string)
2170 (get_overlay_strings_1, push_display_prop): Set up the bidi
2171 iterator for displaying display or overlay strings.
2172 (forward_to_next_line_start): Don't use the shortcut if
2173 bidi-iterating.
2174 (back_to_previous_visible_line_start): If handle_display_prop
2175 pushed the iterator stack, restore the internal state of the bidi
2176 iterator by calling bidi_pop_it same number of times.
2177 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2178 and we are bidi-iterating, don't decrement the iterator position;
2179 instead, set the first_elt flag in the bidi iterator, to produce
2180 the same effect.
2181 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2182 (push_display_prop): xassert that we are iterating a buffer.
2183 (push_it, pop_it): Save and restore paragraph_embedding member.
2184 (handle_single_display_spec, next_overlay_string)
2185 (get_overlay_strings_1, reseat_1, reseat_to_string)
2186 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2187 correctly. Don't assume unibyte strings are not bidi-reordered.
2188 (compute_display_string_pos)
2189 (compute_display_string_end): Fix handling the case of C string.
2190 (push_it, pop_it): Save and restore from_disp_prop_p.
2191 (handle_single_display_spec, push_display_prop): Set the
2192 from_disp_prop_p flag.
2193 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2194 (pop_it): Call iterate_out_of_display_property only if we are
2195 popping after iteration over a string that came from a display
2196 property. Fix a typo in popping stretch info. Add an assertion
2197 for verifying that the iterator position is in sync with the bidi
2198 iterator.
2199 (handle_single_display_spec, get_overlay_strings_1)
2200 (push_display_prop): Fix initialization of paragraph direction for
2201 string when that of the parent object is not yet determined.
2202 (reseat_1): Call bidi_init_it to resync the bidi
2203 iterator with IT's position. (Bug#7616)
2204 (find_row_edges): If ROW->start.pos gives position
2205 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2206 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2207 Reset the from_disp_prop_p flag.
2208 (SAVE_IT, RESTORE_IT): New macros.
2209 (pos_visible_p, face_before_or_after_it_pos)
2210 (back_to_previous_visible_line_start)
2211 (move_it_in_display_line_to, move_it_in_display_line)
2212 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2213 (try_scrolling, redisplay_window, display_line): Use them when
2214 saving a temporary copy of the iterator and restoring it back.
2215 (back_to_previous_visible_line_start, reseat_1)
2216 (init_iterator): Empty the bidi cache "stack".
2217 (move_it_in_display_line_to): If iterator ended up at
2218 EOL, but we never saw any buffer positions smaller than
2219 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2220 motion in bidi-reordered lines.
2221 (move_it_in_display_line_to): Record prev_method and prev_pos
2222 immediately before the call to set_iterator_to_next. Fixes cursor
2223 motion in bidi-reordered lines with stretch glyphs and strings
2224 displayed in margins. (Bug#8133) (Bug#8867)
2225 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2226 TO_CHARPOS.
640c8776
SM
2227 (pos_visible_p): Support positions in bidi-reordered lines.
2228 Save and restore bidi cache.
0bb23927
EZ
2229
2230 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2231 (bidi_paragraph_info): Delete unused struct.
2232 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2233 (bidi_cache_start): New variable.
2234 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2235 to zero.
2236 (bidi_cache_fetch_state, bidi_cache_search)
2237 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2238 (bidi_cache_find, bidi_peek_at_next_level)
2239 (bidi_level_of_next_char, bidi_find_other_level_edge)
2240 (bidi_move_to_visually_next): Compare cache index with
2241 bidi_cache_start rather than with zero.
2242 (bidi_fetch_char): Accept new argument STRING; all callers
2243 changed. Support iteration over a string. Support strings with
2244 display properties. Support unibyte strings. Fix the type of
2245 `len' according to what STRING_CHAR_AND_LENGTH expects.
2246 (bidi_paragraph_init, bidi_resolve_explicit_1)
2247 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2248 (bidi_level_of_next_char, bidi_move_to_visually_next):
2249 Support iteration over a string.
0bb23927
EZ
2250 (bidi_set_sor_type, bidi_resolve_explicit_1)
2251 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2252 can now be zero (for strings); special values 0 and -1 were
2253 changed to -1 and -2, respectively.
2254 (bidi_char_at_pos): New function.
2255 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2256 Call it instead of FETCH_MULTIBYTE_CHAR.
2257 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2258 initialized to valid values.
2259 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2260 values.
2261 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2262 the test for valid cached positions. Fix the logic for looking up
2263 the sentinel state in the cache. GCPRO the Lisp string we are
2264 iterating.
2265 (bidi_push_it, bidi_pop_it): New functions.
2266 (bidi_initialize): Initialize the bidi cache start stack pointer.
2267 (bidi_cache_ensure_space): New function, refactored from part of
2268 bidi_cache_iterator_state. Don't assume the required size is just
2269 one BIDI_CACHE_CHUNK away.
2270 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2271 (bidi_count_bytes, bidi_char_at_pos): New functions.
2272 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2273 always valid if bidi_cache_idx is valid.
2274 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2275 is valid if it's going to be used.
2276 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2277 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2278 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2279 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2280 (bidi_find_other_level_edge, bidi_cache_start_stack):
2281 All variables related to cache indices are now EMACS_INT.
c965adc5 2282
0bb23927
EZ
2283 * dispextern.h (struct bidi_string_data): New structure.
2284 (struct bidi_it): New member `string'. Make flag members be 1-bit
2285 fields, and put them last in the struct.
640c8776
SM
2286 (compute_display_string_pos, compute_display_string_end):
2287 Update prototypes.
0bb23927
EZ
2288 (bidi_push_it, bidi_pop_it): Add prototypes.
2289 (struct iterator_stack_entry): New members bidi_p,
2290 paragraph_embedding, and from_disp_prop_p.
2291 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2292 (bidi_shelve_cache, bidi_unshelve_cache):
2293 Declare prototypes.
0bb23927
EZ
2294
2295 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2296 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2297 and vector-like objects.
2298
2299 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2300 cache around display iteration.
2301
2302 * window.c (Fwindow_end, window_scroll_pixel_based)
2303 (displayed_window_lines, Frecenter): Save and restore the bidi
2304 cache around display iteration.
2305
3bbd2265
LMI
23062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2307
2308 * editfns.c (Fdelete_region): Clarify the use of the named
2309 parameters (bug#6788).
2310
adc47434
MR
23112011-07-14 Martin Rudalics <rudalics@gmx.at>
2312
2313 * indent.c (Fvertical_motion): Set and restore w->pointm when
2314 saving and restoring the window's buffer (Bug#9006).
2315
837c31f8
LMI
23162011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2317
2318 * editfns.c (Fstring_to_char): Clarify just what is returned
2319 (bug#6576). Text by Eli Zaretskii.
2320
ac389d0c
JB
23212011-07-13 Juanma Barranquero <lekktu@gmail.com>
2322
2323 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2324
0be0ce47
EZ
23252011-07-13 Eli Zaretskii <eliz@gnu.org>
2326
2327 * buffer.c (mmap_find): Fix a typo.
2328
cd18e7e3
JB
23292011-07-13 Johan Bockgård <bojohan@gnu.org>
2330
2331 Fix execution of x selection hooks.
2332 * xselect.c (Qx_lost_selection_functions)
2333 (Qx_sent_selection_functions): New vars.
2334 (syms_of_xselect): DEFSYM them.
2335 (x_handle_selection_request): Pass Qx_sent_selection_functions
2336 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2337 (x_handle_selection_clear,x_clear_frame_selections):
2338 Pass Qx_lost_selection_functions rather than
2339 Vx_lost_selection_functions to Frun_hook_with_args.
2340
47ea7f44
PE
23412011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2342
ac389d0c 2343 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2344 The old code sometimes used this field without initializing it.
2345
47ea7f44
PE
2346 * alloc.c (gc_sweep): Don't read past end of array.
2347 In theory, the old code could also have corrupted Emacs internals,
2348 though it'd be very unlikely.
2349
bc985c87
AS
23502011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2351
2352 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2353 argument. (Bug#4026)
bc985c87 2354
0cf34688
LMI
23552011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2356
b3dadd76
LMI
2357 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2358 key" (bug#4257).
2359
0cf34688
LMI
2360 * window.c (Fset_window_start): Doc fix (bug#4199).
2361 (Fset_window_hscroll): Ditto.
2362
270768cd
PE
23632011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2364
077e3dda 2365 Fix minor new problems caught by GCC 4.6.1.
270768cd 2366 * term.c (init_tty): Remove unused local.
490011a6 2367 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2368 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2369 not used otherwise.
270768cd 2370
b1f58454
CY
23712011-07-12 Chong Yidong <cyd@stupidchicken.com>
2372
2373 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2374
22b9578d
LMI
23752011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2376
6e70ab07
LMI
2377 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2378 are the mini-buffer and the echo area (bug#3320).
2379
22b9578d
LMI
2380 * term.c (init_tty): Remove support for supdup, c10 and perq
2381 terminals, which are no longer supported (bug#1482).
2382
8974cc9f
JB
23832011-07-10 Johan Bockgård <bojohan@gnu.org>
2384
2385 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2386
a560d974
JD
23872011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2388
2389 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2390 for non-popups (Bug#3642).
2391
1dae0f0a
AS
23922011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2393
268c2c36 2394 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2395 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2396 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2397 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2398 * data.c (fmod): Likewise.
2399 * dispnew.c (swap_glyphs_in_rows): Likewise.
2400 * emacs.c (memory_warning_signal): Likewise.
2401 * floatfns.c (float_error): Likewise.
2402 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2403 (otf_open, font_otf_capability, generate_otf_features)
2404 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2405 Likewise.
2406 * image.c (pbm_read_file): Likewise.
2407 * indent.c (string_display_width): Likewise.
2408 * intervals.c (check_for_interval, search_for_interval)
2409 (inc_interval_count, count_intervals, root_interval)
2410 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2411 * lread.c (defalias): Likewise.
268c2c36 2412 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2413 * regex.c (set_image_of_range_1, set_image_of_range)
2414 (regex_grow_registers): Likewise.
2415 * sysdep.c (strerror): Likewise.
2416 * termcap.c (valid_filename_p, tprint, main): Likewise.
2417 * tparam.c (main): Likewise.
2418 * unexhp9k800.c (run_time_remap, save_data_space)
2419 (update_file_ptrs, read_header, write_header, calculate_checksum)
2420 (copy_file, copy_rest, display_header): Likewise.
2421 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2422 Likewise.
2423 * xdisp.c (check_it): Likewise.
2424 * xfaces.c (register_color, unregister_color, unregister_colors):
2425 Likewise.
2426 * xfns.c (print_fontset_result): Likewise.
2427 * xrdb.c (member, fatal, main): Likewise.
2428
99033785
PE
24292011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 Fix minor problems found by static checking (Bug#9031).
2432 * chartab.c (char_table_set_range, map_sub_char_table):
2433 Remove unused locals.
2434 (uniprop_table): Now static.
2435 * composite.c (_work_char): Remove unused static var.
2436
9cb2ac56
JB
24372011-07-09 Juanma Barranquero <lekktu@gmail.com>
2438
2439 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2440
f25661f0
JD
24412011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2442
2443 * gtkutil.c (qttip_cb): Remove code without function.
2444
8278c4fe
EZ
24452011-07-09 Eli Zaretskii <eliz@gnu.org>
2446
2447 * w32.c (pthread_sigmask): New stub.
2448
1692ae2d 24492011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2450
8a6ebd58 2451 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2452 sigprocmask is portable only for single-threaded applications, and
2453 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2454 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2455 (LIBES): Use it.
2456 * callproc.c (Fcall_process):
2457 * process.c (create_process):
2458 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2459 Use pthread_sigmask, not sigprocmask.
123403e4 2460
1b854618
JD
24612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2462
2463 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2464 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2465 wrong (Bug#8591).
2466
3fe4b549
JD
24672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2468
0ce7e563
JD
2469 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2470 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2471 (xg_hide_tooltip): Fix comment.
2472
3fe4b549
JD
2473 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2474 in registerServicesMenuSendTypes.
2475 (validRequestorForSendType): Don't check ns_return_types.
2476
2477 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2478 ns_return_type.
2479
5df75e47
JR
24802011-07-08 Jason Rumney <jasonr@gnu.org>
2481
2482 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2483 frame struct members of non-existent frames (Bug#6284).
2484
699c10bd
JD
24852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2486
4393663b
JD
2487 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2488 variable firstTime not needed on OSX >= 10.6.
2489 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2490 >= 10.5. Use setKnobProportion, setDoubleValue.
2491
2492 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2493 (MAC_OS_X_VERSION_10_5): Define if not defined.
2494 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2495 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2496 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2497
2498 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2499 cString and lossyCString on OSX >= 10.4
2500
2501 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2502 sizeToFit on OSX >= 10.2.
2503
2504 * nsimage.m (allocInitFromFile): Don't use deprecated method
2505 bestRepresentationForDevice on OSX >= 10.6.
2506
2507 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2508 to avoid warning.
2509
2510 * emacs.c: Declare unexec_init_emacs_zone.
2511
a63e0781
JD
2512 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2513
699c10bd
JD
2514 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2515
2516 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2517 on svcsMenu (Bug#8842).
2518
2519 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2520 ns_return_types.
2521 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2522
2523 * nsterm.m (QUTF8_STRING): Declare.
2524 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2525 (validRequestorForSendType): Return type is (id).
2526 Change indexOfObjectIdenticalTo to indexOfObject.
2527 Check if we have local selection before returning self (Bug#8842).
2528 (writeSelectionToPasteboard): Put local selection into paste board
2529 if we have a local selection (Bug#8842).
2530 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2531
2532 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2533 (ns_get_local_selection): Declare.
2534
54e10184
LMI
25352011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2536
9888ff71
LMI
2537 * keymap.c (describe_map_tree): Don't insert a double newline at
2538 the end of the buffer (bug#1169) and return whether we inserted
2539 something.
2540
54e10184
LMI
2541 * callint.c (Fcall_interactively): Change "reading args" to
2542 "providing args" to try to clarify what it does (bug#1010).
2543
15fa4783
KH
25442011-07-07 Kenichi Handa <handa@m17n.org>
2545
2546 * composite.c (composition_compute_stop_pos): Ignore a static
2547 composition starting before CHARPOS (Bug#8915).
2548
2549 * xdisp.c (handle_composition_prop): Likewise.
2550
a8815b00
EZ
25512011-07-07 Eli Zaretskii <eliz@gnu.org>
2552
2553 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2554 (Bug#9015)
2555
ef7b981d 25562011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2557
2558 * character.h (unicode_category_t): New enum type.
2559
2560 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2561 (Qchar_code_property_table): New variable.
2562 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2563 (UNIPROP_COMPRESSED_FORM_P): New macros.
2564 (char_table_ascii): Uncompress the compressed values.
2565 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2566 Uncompress the compressed values.
ac389d0c 2567 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2568 (char_table_ref_and_range): Uncompress the compressed values.
2569 (sub_char_table_set): New arg is_uniprop. Callers changed.
2570 Uncompress the compressed values.
2571 (sub_char_table_set_range): Args changed. Callers changed.
2572 (char_table_set_range): Adjuted for the above change.
2573 (map_sub_char_table): Delete args default_val and parent. Add arg
2574 top. Give decoded values to a Lisp function.
640c8776 2575 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2576 values to a Lisp function. Gcpro more variables.
2577 (uniprop_table_uncompress)
2578 (uniprop_decode_value_run_length): New functions.
2579 (uniprop_decoder, uniprop_decoder_count): New variables.
2580 (uniprop_get_decoder, uniprop_encode_value_character)
2581 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2582 New functions.
2583 (uniprop_encoder, uniprop_encoder_count): New variables.
2584 (uniprop_get_encoder, uniprop_table)
2585 (Funicode_property_table_internal, Fget_unicode_property_internal)
2586 (Fput_unicode_property_internal): New functions.
2587 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2588 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2589 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2590 char-code-property-alist.
2591
640c8776 2592 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2593 Vunicode_category_table.
2594
640c8776 2595 * font.c (font_range): Adjust for the change of
c805dec0
KH
2596 Vunicode_category_table.
2597
76b397fb
DN
25982011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2599
2600 * m/iris4d.h: Remove file, move contents ...
2601 * s/irix6-5.h: ... here.
2602
22b4128e
PE
26032011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2606 * alloc.c (mark_buffer):
2607 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2608 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2609 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2610 This isn't true in general, and it's particularly not true
2611 if Emacs is configured with --with-wide-int.
2612 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2613 New macros, used in the buffer.c change.
2614
869795d6
JD
26152011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2616
2617 * xsettings.c: Use both GConf and GSettings if both are available.
2618 (store_config_changed_event): Add comment.
2619 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2620 (store_tool_bar_style_changed): New functions.
5e617bc2 2621 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2622 (struct xsettings): Move font inside HAVE_XFT.
2623 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2624 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2625 Move inside HAVE_XFT.
640c8776 2626 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2627 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2628 also.
2629 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2630 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2631 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2632 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2633 (parse_settings): Move check for font inside HAVE_XFT.
2634 (read_settings, apply_xft_settings): Add comment.
2635 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2636 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2637 call store_font_name_changed.
2638 (xft_settings_event): Add comment.
2639 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2640 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2641 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2642 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2643 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2644 (xsettings_get_system_font, xsettings_get_system_normal_font):
2645 Add comment.
869795d6 2646
d8ed26bd
PE
26472011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 Random fixes. E.g., (random) never returned negative values.
2650 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2651 subseconds part to the entropy, as that's a bit more random.
2652 Prefer signed to unsigned, since the signedness doesn't matter and
2653 in general we prefer signed. When given a limit, use a
2654 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2655 latter isn't right if USE_2_TAGS_FOR_INTS.
2656 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2657 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2658
cabf1cac
SM
26592011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2660
2661 * textprop.c (text_property_stickiness):
2662 Obey Vtext_property_default_nonsticky.
2663 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2664 * w32fns.c (syms_of_w32fns):
2665 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2666
6e9b2be9
PE
26672011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2668
2669 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2670 This is more efficient than Ffile_directory_p and avoids a minor race.
2671
90186c68
LMI
26722011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2673
7c301272
LMI
2674 * buffer.c (Foverlay_put): Say what the return value is
2675 (bug#7835).
2676
c4f2d8d4
LMI
2677 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2678 is a directory before asking whether to use the file name
2679 (bug#7564).
ad637907
LMI
2680 (barf_or_query_if_file_exists): Make the "File is a directory"
2681 error be more correct.
c4f2d8d4 2682
90186c68
LMI
2683 * fns.c (Frequire): Remove the mention of the .gz files, since
2684 that's installation-specific, but keep the mention of
2685 `get-load-suffixes'.
2686
da64016e
PE
26872011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2690 Report string overflow if the output is too long.
2691
7d47b580
JB
26922011-07-04 Juanma Barranquero <lekktu@gmail.com>
2693
a555cb87
JB
2694 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2695 (syms_of_gnutls): Remove duplicate DEFSYM for
2696 Qgnutls_bootprop_verify_hostname_error, an error for
2697 Qgnutls_bootprop_verify_error (which is no longer used).
2698
7d47b580
JB
2699 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2700 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2701 Also (re)move comments that are misplaced or no longer relevant.
2702
1e49bfab
LMI
27032011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2704
2705 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2706
1485f4c0
CY
27072011-07-03 Chong Yidong <cyd@stupidchicken.com>
2708
2709 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2710 and background color parameters if they have been changed.
2711
a9ab721e
LMI
27122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2713
2714 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2715
cf7cff57
PE
27162011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2717
2e13213d
PE
2718 * xsettings.c (SYSTEM_FONT): Define only when used.
2719 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2720
cf7cff57
PE
2721 * keymap.c (access_keymap_1): Now static.
2722
7a8e04f7
CY
27232011-07-02 Chong Yidong <cyd@stupidchicken.com>
2724
2725 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2726 leave any prefix arg for the up event (Bug#1586).
2727
61352f62
LMI
27282011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2729
69bb1ef7
LMI
2730 * lread.c (syms_of_lread): Mention single symbols defined by
2731 `defvar' or `defconst' (bug#7154).
2732
61352f62 2733 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2734 (Frequire): Mention get-load-suffixes.
61352f62 2735
28545e04
MR
27362011-07-02 Martin Rudalics <rudalics@gmx.at>
2737
2738 * window.h (window): Remove clone_number slot.
2739 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2740 Remove.
2741 (make_parent_window, make_window, saved_window)
2742 (Fset_window_configuration, save_window_save): Don't deal with
2743 clone numbers.
2744 * buffer.c (Qclone_number): Remove declaration.
2745 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2746
3349e122
SM
27472011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2748
2749 Add multiple inheritance to keymaps.
2750 * keymap.c (Fmake_composed_keymap): New function.
2751 (Fset_keymap_parent): Simplify.
2752 (fix_submap_inheritance): Remove.
2753 (access_keymap_1): New function extracted from access_keymap to handle
2754 embedded parents and handle lists of maps.
2755 (access_keymap): Use it.
2756 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2757 (Fcopy_keymap): Handle embedded parents.
2758 (Fcommand_remapping, define_as_prefix): Simplify.
2759 (Fkey_binding): Simplify.
2760 (syms_of_keymap): Move minibuffer-local-completion-map,
2761 minibuffer-local-filename-completion-map,
2762 minibuffer-local-must-match-map, and
2763 minibuffer-local-filename-must-match-map to Elisp.
2764 (syms_of_keymap): Defsubr make-composed-keymap.
2765 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2766 (parse_menu_item): Trivial simplification.
2767
3279eb87
GM
27682011-07-01 Glenn Morris <rgm@gnu.org>
2769
2770 * Makefile.in (SETTINGS_LIBS): Fix typo.
2771
4550efdf
KI
27722011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2773
2774 * coding.c (Fencode_coding_string): Record the last coding system
2775 used, as the function doc string says (bug#8738).
2776
0949d2b6
JD
27772011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2778
2779 * xsettings.c (store_monospaced_changed): Take new font as arg and
2780 check for change against current_mono_font.
2781 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2782 (emacs_settings_constructor, emacs_settings_get_property)
2783 (emacs_settings_set_property, emacs_settings_class_init)
2784 (emacs_settings_init, gsettings_obj): Remove.
2785 (something_changedCB): New function for HAVE_GSETTINGS.
2786 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2787 with value as argument.
2788 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2789 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2790 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2791 "changed".
2792
2793 * xgselect.c: Add defined (HAVE_GSETTINGS).
2794 (xgselect_initialize): Ditto.
2795
2796 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2797 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2798 xg_select.
2799
bbc6b304
PE
28002011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 * eval.c (struct backtrace): Simplify and port the data structure.
2803 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2804 signed bit field, as this assumption is not portable and it makes
2805 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2806 "char debug_on_exit : 1" as this is not portable either; instead,
2807 use the portable "unsigned int debug_on_exit : 1". Remove unused
2808 member evalargs. Remove obsolete comments about cc bombing out.
2809
9851bfc5
JD
28102011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2811
51bb811f 2812 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2813 Let HAVE_GSETTINGS override HAVE_GCONF.
2814 (store_monospaced_changed): New function.
2815 (EMACS_SETTINGS): A new type derived from GObject to handle
2816 GSettings notifications.
2817 (emacs_settings_constructor, emacs_settings_get_property)
2818 (emacs_settings_set_property, emacs_settings_class_init):
2819 New functions.
2820 (gsettings_client, gsettings_obj): New variables.
2821 (GSETTINGS_SCHEMA): New define.
2822 (something_changedCB): Call store_monospaced_changed.
2823 (init_gsettings): New function.
2824 (xsettings_initialize): Call init_gsettings.
2825 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2826 to NULL.
2827
640c8776 2828 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2829 GCONF_CFLAGS/LIBS.
2830
5386012d
MR
28312011-06-29 Martin Rudalics <rudalics@gmx.at>
2832
2833 * window.c (resize_root_window, grow_mini_window)
2834 (shrink_mini_window): Rename Qresize_root_window to
2835 Qwindow_resize_root_window and Qresize_root_window_vertically to
2836 Qwindow_resize_root_window_vertically.
2837
f13e0b08
PE
28382011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2841
94515237
JB
28422011-06-27 Juanma Barranquero <lekktu@gmail.com>
2843
2844 * makefile.w32-in: Redesign dependencies so they reflect more
2845 clearly which files are directly included by each source file,
2846 and not through other includes.
2847
e43b6e43
MR
28482011-06-27 Martin Rudalics <rudalics@gmx.at>
2849
2850 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2851 (sort_overlays, overlay_strings): When an overlay's clone number
2852 matches the window's clone number process the overlay even if
2853 the overlay's window property doesn't match the current window.
2854
d68443dc
MR
2855 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2856 (Fwindow_hchild): Rename to Fwindow_left_child.
2857 (Fwindow_next): Rename to Fwindow_next_sibling.
2858 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2859 (resize_window_check): Rename to window_resize_check.
2860 (resize_window_apply): Rename to window_resize_apply.
2861 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2862 (Fdelete_other_windows_internal, resize_frame_windows)
2863 (Fsplit_window_internal, Fdelete_window_internal)
2864 (grow_mini_window, shrink_mini_window)
2865 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2866
c7e73be5
JD
28672011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2868
2869 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2870 (emacs_fixed_set_min_size): Remove.
2871 (emacs_fixed_new): Take frame as argument.
2872
2873 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2874 (_EmacsFixedPrivate): Remove minwidth/height.
2875 Add struct frame *f.
2876 (emacs_fixed_init): Initialize priv->f.
2877 (get_parent_class, emacs_fixed_set_min_size): Remove.
2878 (emacs_fixed_new): Set priv->f to argument.
2879 (emacs_fixed_get_preferred_width)
2880 (emacs_fixed_get_preferred_height): Use min_width/height from
2881 frames size_hint to set minimum and natural (Bug#8919).
2882 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2883 and use min_width/height from frames size_hint to set
2884 min_width/height (Bug#8919).
2885
2886 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2887 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2888 Fix indentation.
c7e73be5 2889
cf99dcf8
EZ
28902011-06-26 Eli Zaretskii <eliz@gnu.org>
2891
2892 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2893 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2894 called at ZV.
2895
029529ac
CY
28962011-06-26 Chong Yidong <cyd@stupidchicken.com>
2897
2898 * process.c (wait_reading_process_output): Bypass select if
2899 waiting for a cell while ignoring keyboard input, and input is
2900 pending. Suggested by Jan Djärv (Bug#8869).
2901
7a7ef429
PE
29022011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2903
2904 Use gnulib's dup2 module instead of rolling our own.
2905 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2906
11fdef7d 29072011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2908
2909 * dispnew.c (scrolling_window): Before scrolling, turn off a
2910 mouse-highlight in the window being scrolled.
2911
cd3520a4
JB
29122011-06-24 Juanma Barranquero <lekktu@gmail.com>
2913
2914 Move DEFSYM to lisp.h and use everywhere.
2915
2916 * character.h (DEFSYM): Move declaration...
2917 * lisp.h (DEFSYM): ...here.
2918
2919 * gnutls.c:
2920 * minibuf.c:
2921 * w32menu.c:
2922 * w32proc.c:
2923 * w32select.c: Don't include character.h.
2924
2925 * alloc.c (syms_of_alloc):
2926 * buffer.c (syms_of_buffer):
2927 * bytecode.c (syms_of_bytecode):
2928 * callint.c (syms_of_callint):
2929 * casefiddle.c (syms_of_casefiddle):
2930 * casetab.c (init_casetab_once):
2931 * category.c (init_category_once, syms_of_category):
2932 * ccl.c (syms_of_ccl):
2933 * cmds.c (syms_of_cmds):
2934 * composite.c (syms_of_composite):
2935 * dbusbind.c (syms_of_dbusbind):
2936 * dired.c (syms_of_dired):
2937 * dispnew.c (syms_of_display):
2938 * doc.c (syms_of_doc):
2939 * editfns.c (syms_of_editfns):
2940 * emacs.c (syms_of_emacs):
2941 * eval.c (syms_of_eval):
2942 * fileio.c (syms_of_fileio):
2943 * fns.c (syms_of_fns):
2944 * frame.c (syms_of_frame):
2945 * fringe.c (syms_of_fringe):
2946 * insdel.c (syms_of_insdel):
2947 * keymap.c (syms_of_keymap):
2948 * lread.c (init_obarray, syms_of_lread):
2949 * macros.c (syms_of_macros):
2950 * msdos.c (syms_of_msdos):
2951 * print.c (syms_of_print):
2952 * process.c (syms_of_process):
2953 * search.c (syms_of_search):
2954 * sound.c (syms_of_sound):
2955 * syntax.c (init_syntax_once, syms_of_syntax):
2956 * terminal.c (syms_of_terminal):
2957 * textprop.c (syms_of_textprop):
2958 * undo.c (syms_of_undo):
2959 * w32.c (globals_of_w32):
2960 * window.c (syms_of_window):
2961 * xdisp.c (syms_of_xdisp):
2962 * xfaces.c (syms_of_xfaces):
2963 * xfns.c (syms_of_xfns):
2964 * xmenu.c (syms_of_xmenu):
2965 * xsettings.c (syms_of_xsettings):
2966 * xterm.c (syms_of_xterm): Use DEFSYM.
2967
4228cf16
TZ
29682011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2969
cd3520a4 2970 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2971
7fcccf1e
PE
29722011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2973
7efb4e0e
PE
2974 Integer and buffer overflow fixes (Bug#8873).
2975
ff5844ad
PE
2976 * print.c (printchar, strout): Check for string overflow.
2977 (PRINTPREPARE, printchar, strout):
2978 Don't set size unless allocation succeeds.
2979
90532f02
PE
2980 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2981 for sizes. Check for string overflow more accurately.
2982 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2983
6d84508d
PE
2984 * macros.c: Integer and buffer overflow fixes.
2985 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2986 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2987 Use ptrdiff_t, not int, for sizes.
2988 Don't increment bufsize until after realloc succeeds.
2989 Check for size-calculation overflow.
2990 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2991
437b2cb4
PE
2992 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2993
8b9ac8b4
PE
2994 * lread.c: Integer overflow fixes.
2995 (read_integer): Radix is now EMACS_INT, not int,
2996 to improve quality of diagnostics for out-of-range radices.
2997 Calculate buffer size correctly for out-of-range radices.
2998 (read1): Check for integer overflow in radices, and in
2999 read-circle numbers.
82cb60d3
PE
3000 (read_escape): Avoid int overflow.
3001 (Fload, openp, read_buffer_size, read1)
3002 (substitute_object_recurse, read_vector, read_list, map_obarray):
3003 Use ptrdiff_t, not int, for sizes.
3004 (read1): Use EMACS_INT, not int, for sizes.
20270765 3005 Check for size overflow.
8b9ac8b4 3006
7fcccf1e
PE
3007 * image.c (cache_image): Check for size arithmetic overflow.
3008
bfbbd7e7
PE
3009 * lread.c: Integer overflow issues.
3010 (saved_doc_string_size, saved_doc_string_length)
3011 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3012 Now ptrdiff_t, not int.
3013 (read1): Don't assume doc string length fits in int. Check for
3014 out-of-range doc string lengths.
3015 (read_list): Don't assume file position fits in int.
39019e54 3016 (read_escape): Check for hex character overflow.
bfbbd7e7 3017
4e323265
LL
30182011-06-22 Leo Liu <sdl.web@gmail.com>
3019
3020 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3021 Move to minibuffer.el.
3022
85fece3e
PE
30232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3024
20b84ce9 3025 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3026 The following patches are for when GLYPH_DEBUG && !XASSERT.
3027 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3028 * dispnew.c (flush_stdout):
3029 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3030 Mark as externally visible.
3031 * dispnew.c (check_window_matrix_pointers): Now static.
3032 * dispnew.c (window_to_frame_vpos):
3033 * xfns.c (unwind_create_frame):
3034 * xterm.c (x_check_font): Remove unused local.
3035 * scroll.c (CHECK_BOUNDS):
3036 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3037 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3038 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3039 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3040 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3041 Now static.
3042 (debug_method_add): Use va_list and vsprintf rather than relying
3043 on undefined behavior with wrong number of arguments.
3044 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3045 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3046 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3047 since we're not interested in debugging glyphs with old libraries.
3048 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3049 GCC 4.6.0's static checking.
3050
0766b489
PE
30512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3052
31fd4b32
PE
3053 Integer overflow and signedness fixes (Bug#8873).
3054 A few related buffer overrun fixes, too.
3055
b79e8648
PE
3056 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3057
0766b489
PE
3058 * dispextern.h (struct face.stipple):
3059 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3060 (x_bitmap_mask, x_allocate_bitmap_record)
3061 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3062 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3063 (x_create_bitmap_from_xpm_data):
3064 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3065 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3066 (.bitmaps_last):
3067 * xfaces.c (load_pixmap):
3068 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3069 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3070 (.bitmaps_last, struct x_output.icon_bitmap):
3071 Use ptrdiff_t, not int, for bitmap indexes.
3072 (x_allocate_bitmap_record): Check for size overflow.
3073 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3074
b081724f
PE
3075 Use ptrdiff_t, not int, for overlay counts.
3076 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3077 * editfns.c (overlays_around, get_pos_property):
3078 * textprop.c (get_char_property_and_overlay):
3079 * xdisp.c (next_overlay_change, note_mouse_highlight):
3080 * xfaces.c (face_at_buffer_position):
21514da7
PE
3081 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3082 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3083 (Fnext_overlay_change, Fprevious_overlay_change)
3084 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3085 Use ptrdiff_t, not int, for sizes.
21514da7 3086 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3087
3de73e5e
PE
3088 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3089
2606c57b
PE
3090 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3091 (x_session_initialize): Do not assume string length fits in int.
3092
aaafe47a
PE
3093 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3094 This is unlikely, but can occur if DPI is outlandish.
3095
2674ddc8 3096 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3097 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3098
28154962
PE
3099 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3100 * xrdb.c (magic_file_p, search_magic_path):
3101 Omit last arg SUFFIX; it was always 0. All callers changed.
3102 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3103
7de51af5
PE
3104 * xfont.c (xfont_match): Avoid need for strlen.
3105
25ed6cc3
PE
3106 * xfns.c: Don't assume strlen fits in int.
3107 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3108
4eab31dd
PE
3109 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3110 not unsigned long, as we prefer signed integers. All callers changed.
3111 Detect integer overflow in repeat count.
3112 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3113 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3114
171e2a58
PE
3115 * termcap.c: Don't assume sizes fit in int and never overflow.
3116 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3117 (gobble_line): Check for size-calculation overflow.
3118
ad39faca 3119 * minibuf.c (Fread_buffer):
6e5bb2dc 3120 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3121 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3122 Don't assume string length fits in int.
3123
52c61c22 3124 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3125 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3126
b5b8c9e5
PE
3127 * font.c: Don't assume string length fits in int.
3128 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3129 Use ptrdiff_t, not int.
ccd6111c
PE
3130 (font_intern_prop): Don't assume string length fits in int.
3131 Don't assume integer property fits in fixnum.
3132 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3133
882f0d81 3134 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3135 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3136 Reformulate so as not to need the command string.
3137 Invoke gzip -cd rather than gunzip, as it's more portable.
3138 (lock_info_type, lock_file_1, lock_file):
3139 Don't assume pid_t and time_t fit in unsigned long.
3140 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3141 (current_lock_owner): Prefer signed type for sizes.
3142 Use memcpy, not strncpy, where memcpy is what is really wanted.
3143 Don't assume (via atoi) that time_t and pid_t fit in int.
3144 Check for time_t and/or pid_t out of range, e.g., via a network share.
3145 Don't alloca where an auto var works fine.
3146
93f4cf88
PE
3147 * fileio.c: Fix some integer overflow issues.
3148 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3149 Don't assume string length fits in int.
3150 (directory_file_name): Don't assume string length fits in long.
3151 (make_temp_name): Don't assume pid fits in int, or that its print
3152 length is less than 20.
3153
f3e92b69
PE
3154 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3155
1bfdaf10
PE
3156 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3157
35016e9a
PE
3158 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3159
3d1e65a1
PE
3160 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3161 We prefer signed integers, even for size calculations.
3162
0b963a93
PE
3163 * emacs.c: Don't assume string length fits in 'int'.
3164 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3165 (main): Don't invoke strlen when not needed.
3166
573f4b54
PE
3167 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3168 (XD_DEBUG_MESSAGE): Don't waste a byte.
3169
989f33ba
PE
3170 * callproc.c (getenv_internal_1, getenv_internal)
3171 (Fgetenv_internal):
965d34eb
PE
3172 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3173
e4d29b33
PE
3174 * lread.c (invalid_syntax): Omit length argument.
3175 All uses changed. This doesn't fix a bug, but it simplifies the
3176 code away from its former Hollerith-constant appearance, and it's
3177 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3178 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3179
eb49b136
PE
3180 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3181 This didn't break anything, but it didn't help either.
3182 It's confusing to put a bogus integer in a place where the actual
3183 value does not matter.
9f62aeb1 3184 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3185 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3186
15375a22
PE
3187 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3188 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3189 implementation.
b61cc01c
PE
3190 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3191 We prefer signed types, and the value cannot exceed the EMACS_INT
3192 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3193 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3194 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3195 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3196
53b2623d
PE
3197 * indent.c (sane_tab_width): New function.
3198 (current_column, scan_for_column, Findent_to, position_indentation)
3199 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3200 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3201
51cab52b 3202 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3203
f2ed8a70
PE
3204 * lisp.h (lint_assume): New macro.
3205 * composite.c (composition_gstring_put_cache):
3206 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3207
abe80cc6
PE
3208 * editfns.c, insdel.c:
3209 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3210
b02c740e
PE
3211 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3212
ebc96716
PE
3213 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3214
b4e50fa0 3215 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3216 Use much-faster test for byte-length change.
311d5d7c 3217 Don't assume string byte-length fits in 'int'.
a4cf38e4 3218 Check that character arg fits in 'int'.
85461888 3219 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3220
c0c1ee9f
PE
3221 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3222
a498d7f4
PE
3223 * fns.c (concat): Catch string overflow earlier.
3224 Do not rely on integer wraparound.
3225
51cab52b
PE
3226 * dispextern.h (struct it.overlay_strings_charpos)
3227 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3228 * xdisp.c (forward_to_next_line_start)
3229 (back_to_previous_visible_line_start)
3230 (reseat_at_next_visible_line_start, next_element_from_buffer):
3231 Don't arbitrarily truncate the value of 'selective' to int.
3232
76031fad
PE
3233 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3234
5eb55db9
PE
3235 * composite.c: Don't truncate sizes to 'int'.
3236 (composition_gstring_p, composition_reseat_it)
3237 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3238 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3239 not EMACS_UINT, for indexes.
5eb55db9 3240
0703a717
PE
3241 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3242
d6202519
PE
3243 * buffer.c: Include <verify.h>.
3244 (struct sortvec.priority, struct sortstr.priority):
8961a454 3245 Now EMACS_INT, not int.
c20998a7 3246 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3247 (struct sortstr.size, record_overlay_string)
3248 (struct sortstrlist.size, struct sortlist.used):
3249 Don't truncate size to int.
3250 (record_overlay_string): Check for size-calculation overflow.
d6202519 3251 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3252
d5a19415
JM
32532011-06-22 Jim Meyering <meyering@redhat.com>
3254
029529ac 3255 Don't leak an XBM-image-sized buffer
d5a19415
JM
3256 * image.c (xbm_load): Free the image buffer after using it.
3257
a9041e6c
PE
32582011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 Port to Sun C.
3261 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3262 that Sun C diagnosed.
3263 * fns.c (secure_hash): Fix pointer signedness issue.
3264 * intervals.c (static_offset_intervals): New function.
3265 (offset_intervals): Use it.
3266
7f3f739f
LL
32672011-06-21 Leo Liu <sdl.web@gmail.com>
3268
3269 * deps.mk (fns.o):
3270 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3271 sha512.h.
3272
3273 * fns.c (secure_hash): Rename from crypto_hash_function and change
3274 the first arg to accept symbols.
5b66d427 3275 (Fsecure_hash): New primitive.
7f3f739f
LL
3276 (syms_of_fns): New symbols.
3277
76147d94
DD
32782011-06-20 Deniz Dogan <deniz@dogan.se>
3279
3280 * process.c (Fset_process_buffer): Clarify return value in
3281 docstring.
3282
7d7d0045
CY
32832011-06-18 Chong Yidong <cyd@stupidchicken.com>
3284
3285 * dispnew.c (add_window_display_history): Use BVAR.
3286
3287 * xdisp.c (debug_method_add): Use BVAR.
3288 (check_window_end, dump_glyph_matrix, dump_glyph)
3289 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3290
3291 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3292 Likewise.
3293
3294 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3295 check till after the cache is created in init_frame_faces.
3296
ff2bc410
SM
32972011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3298
3299 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3300
28177add
PE
33012011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3302
dd3482fe
PE
3303 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3304 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3305 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3306
393d71f3 3307 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3308 * fileio.c (Finsert_file_contents):
3309 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3310 Remove the old (too-loose) buffer overflow checks.
3311 They weren't needed, since make_gap checks for buffer overflow.
3312 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3313 The old code merely checked for Emacs fixnum overflow, and relied
3314 on undefined (wraparound) behavior. The new code avoids undefined
3315 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3316
2e6813b0 3317 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3318 Tune. Don't use wider integers than needed. Don't use alloca.
3319 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3320
599a9e4f
PE
3321 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3322
99561444
PE
3323 * insdel.c, lisp.h (buffer_overflow): New function.
3324 (insert_from_buffer_1, replace_range, replace_range_2):
3325 * insdel.c (make_gap_larger):
3326 * editfns.c (Finsert_char):
3327 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3328
28177add
PE
3329 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3330
e69dafad
PE
33312011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3332
a7af7fde 3333 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3334
b1c46f02
PE
3335 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3336 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3337
e69dafad
PE
3338 * fileio.c: Don't assume EMACS_INT fits in off_t.
3339 (emacs_lseek): New static function.
3340 (Finsert_file_contents, Fwrite_region): Use it.
3341 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3342
566684ea
PE
3343 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3344
e6966cd6
PE
3345 * fns.c: Don't overflow int when computing a list length.
3346 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3347 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3348 truncation on 64-bit hosts. Check for QUIT every
3349 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3350 faster and is responsive enough.
3351 (Flength): Report an error instead of overflowing an integer.
3352 (Fsafe_length): Return a float if the value is not representable
3353 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3354 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3355 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3356
dd0b0efb
PE
3357 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3358 (header_size, word_size): New constants.
3359 (allocate_vectorlike): Don't check size overflow here.
3360 (allocate_vector): Check it here instead, since this is the only
3361 caller of allocate_vectorlike that could cause overflow.
3362 Check that the new vector's length is representable as a fixnum.
3363
86fe5cfe
PE
3364 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3365 The previous code was bogus. For example, next_almost_prime (32)
3366 returned 39, which is undesirable as it is a multiple of 3; and
3367 next_almost_prime (24) returned 25, which is a multiple of 5 so
3368 why was the code bothering to check for multiples of 7?
3369
80e88859
PE
3370 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3371
4a2f0ad6
PE
3372 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3373
f66c7cf8
PE
3374 Variadic C functions now count arguments with ptrdiff_t.
3375 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3376 Back then I didn't know that the Emacs coding style prefers signed int.
3377 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3378 were being counted with int, which may truncate counts on 64-bit
3379 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3380 * lisp.h (struct Lisp_Subr.function.aMANY)
3381 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3382 Arg counts are now ptrdiff_t, not size_t.
3383 All variadic functions and their callers changed accordingly.
3384 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3385 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3386 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3387 * callint.c (Fcall_interactively): Check arg count for overflow,
3388 to avoid potential buffer overrun. Use signed char, not 'int',
3389 for 'varies' array, so that we needn't bother to check its size
3390 calculation for overflow.
3391 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3392 * eval.c (apply_lambda):
3393 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3394 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3395 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3396
a1759b76
PE
3397 * callint.c (Fcall_interactively): Don't use index var as event count.
3398
d96be9fc
PE
3399 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3400 * mem-limits.h (SIZE): Remove; no longer used.
3401
a690a978 3402 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3403
578c21e6
PE
3404 Remove unnecessary casts.
3405 * xterm.c (x_term_init):
3406 * xfns.c (x_set_border_pixel):
3407 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3408 These aren't needed now that we assume ANSI C.
3409
96f53c6c
PE
3410 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3411 It's more likely to cause problems (due to unsigned overflow)
3412 than to cure them.
3413
83c77d31
PE
3414 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3415
ee2079f1
PE
3416 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3417
6da65536
PE
3418 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3419
7147c4a4
PE
3420 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3421
193e32d9
PE
3422 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3423
e5533da6
PE
3424 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3425
9910e595
PE
3426 GLYPH_CODE_FACE returns EMACS_INT, not int.
3427 * dispextern.h (merge_faces):
3428 * xfaces.c (merge_faces):
01103c44
PE
3429 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3430 Don't assume EMACS_INT fits in int.
9910e595 3431
2638320e
PE
3432 * character.h (CHAR_VALID_P): Remove unused parameter.
3433 * fontset.c, lisp.h, xdisp.c: All uses changed.
3434
045eb8d9
PE
3435 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3436
c1f134b5
PE
3437 * fns.c (concat): Minor tuning based on overflow analysis.
3438 This doesn't fix any bugs. Use int to hold character, instead
3439 of constantly refetching from Emacs object. Use XFASTINT, not
3440 XINT, for value known to be a character. Don't bother comparing
3441 a single byte to 0400, as it's always less.
3442
395fcb93 3443 * floatfns.c (Fexpt):
327eeec8
PE
3444 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3445
abbd3d23
PE
3446 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3447 for characters.
3448
684a03ef
PE
3449 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3450
0fed43f3
PE
3451 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3452 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3453 incorrectly succeed when S was a string, because 4294967386 was
3454 truncated before it was used.
3455
8fd02eb7
PE
3456 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3457 Otherwise, an out-of-range integer could cause undefined behavior
3458 on a 64-bit host.
3459
f8c86b69
PE
3460 * composite.c: Use int, not EMACS_INT, for characters.
3461 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3462 EMACS_INT, for values that are known to be in character range.
3463 This doesn't fix any bugs but is the usual style inside Emacs and
3464 may generate better code on 32-bit machines.
3465
34206dd2
PE
3466 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3467 This is for reasons similar to the recent CHAR_STRING fix.
3468 * charset.c (Fencode_char): Check that character arg is actually
3469 a character. Pass an int to ENCODE_CHAR.
3470 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3471 wider than 'int', as a compile-time check to prevent future regressions
3472 in this area.
3473
c5958d4c 3474 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3475
3476 Make sure a 64-bit char is never passed to CHAR_STRING.
3477 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3478 by silently ignoring the top 32 bits, allowing some values
3479 that were far too large to be valid characters.
3480 * character.h: Include <verify.h>.
3481 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3482 arguments are no wider than unsigned, as a compile-time check
3483 to prevent future regressions in this area.
3484 * data.c (Faset):
01103c44 3485 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3486 (Fsubst_char_in_region):
3487 * fns.c (concat):
3488 * xdisp.c (decode_mode_spec_coding):
3489 Adjust to CHAR_STRING's new requirement.
3490 * editfns.c (Finsert_char, Fsubst_char_in_region):
3491 * fns.c (concat): Check that character args are actually
3492 characters. Without this test, these functions did the wrong
3493 thing with wildly out-of-range values on 64-bit hosts.
3494
d37ca623
PE
3495 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3496 These casts should not be needed on 32-bit hosts, either.
3497 * keyboard.c (read_char):
3498 * lread.c (Fload): Remove casts to unsigned.
3499
ea204efb
PE
3500 * lisp.h (UNSIGNED_CMP): New macro.
3501 This fixes comparison bugs on 64-bit hosts.
3502 (ASCII_CHAR_P): Use it.
3503 * casefiddle.c (casify_object):
01103c44 3504 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3505 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3506 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3507 * dispextern.h (FACE_FROM_ID):
3508 * keyboard.c (read_char): Use UNSIGNED_CMP.
3509
41cb286c
PE
3510 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3511 not to EMACS_INT, to avoid GCC warning.
3512
4a1b9832
PE
3513 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3514
55daad71
PE
3515 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3516 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3517 isn't needed on 32-bit machines.
8f95c75c 3518
01103c44
PE
3519 * buffer.c (Fgenerate_new_buffer_name):
3520 Use EMACS_INT for count, not int.
0ceccced 3521 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3522
3523 * data.c (Qcompiled_function): Now static.
3524
c6f072e7
PE
3525 * window.c (window_body_lines): Now static.
3526
20ce5912
PE
3527 * image.c (gif_load): Rename local to avoid shadowing.
3528
9c4c5f81
PE
3529 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3530 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3531 * alloc.c (make_save_value): Integer argument is now of type
3532 ptrdiff_t, not int.
3533 (mark_object): Use ptrdiff_t, not int.
3534 * lisp.h (pD): New macro.
3535 * print.c (print_object): Use it.
3536
c0c5c8ae
PE
3537 * alloc.c: Use EMACS_INT, not int, to count objects.
3538 (total_conses, total_markers, total_symbols, total_vector_size)
3539 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3540 (total_free_floats, total_floats, total_free_intervals)
3541 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3542 Now EMACS_INT, not int. All uses changed.
3543 (Fgarbage_collect): Compute overall total using a double, so that
3544 integer overflow is less likely to be a problem. Check for overflow
3545 when converting back to an integer.
5a25e253
PE
3546 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3547 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3548 These were 'int' variables that could overflow on 64-bit hosts;
3549 they were never used, so remove them instead of repairing them.
211a0b2a 3550 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3551 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3552 Previously, this ceilinged at INT_MAX, but that doesn't work on
3553 64-bit machines.
e46bb31a 3554 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3555
c78baabf 3556 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3557 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3558 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3559 when a (possibly-narrower) signed value would do just as well.
3560 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3561
c9d624c6
PE
3562 * alloc.c: Catch some string size overflows that we were missing.
3563 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3564 for convenience in STRING_BYTES_MAX.
3565 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3566 The definition here is exact; the one in lisp.h was approximate.
3567 (allocate_string_data): Check for string overflow. This catches
3568 some instances we weren't catching before. Also, it catches
3569 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3570 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3571 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3572
c9d624c6
PE
3573 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3574 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3575 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3576
353032ce
PE
3577 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3578
2bccce07
PE
3579 * alloc.c (Fmake_string): Check for out-of-range init.
3580
0ac30604
SM
35812011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3582
3583 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3584
c195f2de
JD
35852011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3586
3587 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3588 xg_get_default_scrollbar_width.
3589
3590 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3591 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3592 (style_changed_cb): Call update_theme_scrollbar_width and call
3593 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3594 all frames (Bug#8505).
3595 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3596 Call gtk_window_set_resizable if HAVE_GTK3.
3597 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3598 and height if HAVE_GTK3 (Bug#8505).
3599 (scroll_bar_width_for_theme): New variable.
3600 (update_theme_scrollbar_width): New function.
3601 (xg_get_default_scrollbar_width): Move code to
3602 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3603 (xg_initialize): Call update_theme_scrollbar_width.
3604
3605 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3606
3607 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3608
e10ac9f1
MR
36092011-06-12 Martin Rudalics <rudalics@gmx.at>
3610
3611 * frame.c (make_frame): Call other_buffer_safely instead of
3612 other_buffer.
3613
3614 * window.c (temp_output_buffer_show): Call display_buffer with
3615 second argument Vtemp_buffer_show_specifiers and reset latter
3616 immediately after the call.
3617 (Vtemp_buffer_show_specifiers): New variable.
3618 (auto_window_vscroll_p, next_screen_context_lines)
3619 (Vscroll_preserve_screen_position): Remove leading asterisks from
3620 doc-strings.
3621
2d3c217e 36222011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3623
7b7f97e8 3624 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3625 * buffer.c (Qclone_number): Remove for now, as it's unused.
3626 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3627 (record_buffer): Remove unused local.
3628 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3629 (set_frame_buffer_list): Remove; unused.
3630 * frame.h (other_visible_frames): Remove decl.
3631 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3632 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3633 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3634 if HAVE_GPM.
3635 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3636 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3637 Define only if HAVE_GPM.
3638 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3639 (update_hints_inhibit): Remove; never set. All uses removed.
3640 * widgetprv.h (emacsFrameClassRec): Remove decl.
3641 * window.c (delete_deletable_window): Now returns void, since it
3642 wasn't returning anything.
3643 (compare_window_configurations): Remove unused locals.
3644 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3645 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3646 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3647 the same widths as pointers. This follows up on the 2011-05-06 patch.
3648 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3649 * xterm.h: Likewise.
3650 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3651
1384b89e
JB
36522011-06-12 Juanma Barranquero <lekktu@gmail.com>
3653
3654 * makefile.w32-in: Update dependencies.
3655 (LISP_H): Add lib/intprops.h.
3656
1100a63c
CY
36572011-06-11 Chong Yidong <cyd@stupidchicken.com>
3658
3659 * image.c (gif_load): Add animation frame delay to the metadata.
3660 (syms_of_image): Use DEFSYM. New symbol `delay'.
3661
6198ccd0
MR
36622011-06-11 Martin Rudalics <rudalics@gmx.at>
3663
3664 * window.c (delete_deletable_window): Re-add.
3665 (Fset_window_configuration): Rewrite to handle dead buffers and
3666 consequently deletable windows.
3667 (window_tree, Fwindow_tree): Remove. Supply functionality in
3668 window.el.
3669 (compare_window_configurations): Simplify code.
3670
b6e3633c
AS
36712011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3672
1ab0dee5
AS
3673 * image.c (imagemagick_load_image): Fix type mismatch.
3674 (Fimagemagick_types): Likewise.
3675
b6e3633c
AS
3676 * window.h (replace_buffer_in_windows): Declare.
3677
9397e56f
MR
36782011-06-11 Martin Rudalics <rudalics@gmx.at>
3679
3680 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3681 Qclone_number. Remove external declaration of Qdelete_window.
3682 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3683 code.
640c8776
SM
3684 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3685 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3686 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3687 buffer list implementation.
3688 (other_buffer_safely): New function.
3689 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3690 calls to replace_buffer_in_windows and
3691 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3692 if allowed.
3693 (record_buffer): Inhibit quitting and rewrite using quittable
3694 functions. Run Qbuffer_list_update_hook if allowed.
3695 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3696 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3697 Move switch-to-buffer to window.el.
9397e56f
MR
3698 (bury-buffer): Move to window.el.
3699 (Vbuffer_list_update_hook): New variable.
3700
3701 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3702 section.
3703
3704 * window.h (resize_frame_windows): Move up in code.
3705 (Fwindow_frame): Remove EXFUN.
3706 (replace_buffer_in_all_windows): Remove prototype.
3707 (replace_buffer_in_windows_safely): Add prototype.
3708
3709 * window.c: Declare Qdelete_window static again. Move down
3710 declaration of select_count.
3711 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3712 (Fother_window): Move to window.el.
3713 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3714 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3715 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3716 window.el.
3717 (replace_buffer_in_windows): Implement by calling
3718 Qreplace_buffer_in_windows.
3719 (replace_buffer_in_all_windows): Remove with some functionality
3720 moved into replace_buffer_in_windows_safely.
3721 (replace_buffer_in_windows_safely): New function.
3722 (select_window_norecord, select_frame_norecord): Move in front
3723 of run_window_configuration_change_hook. Remove now obsolete
3724 declarations.
640c8776
SM
3725 (Fset_window_buffer): Rewrite doc-string.
3726 Call Qrecord_window_buffer.
9397e56f
MR
3727 (keys_of_window): Move binding for other-window to window.el.
3728
b50691aa
CY
37292011-06-11 Chong Yidong <cyd@stupidchicken.com>
3730
3731 * dispextern.h (struct image): Replace data member, whose int_val
3732 and ptr_val fields were not used by anything, with a single
3733 lisp_val object.
3734
3735 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3736 (gif_clear_image, gif_load, imagemagick_load_image)
3737 (gs_clear_image, gs_load): Callers changed.
3738
3f754b86
PE
37392011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3740
cca69397
PE
3741 * buffer.h: Include <time.h>, for time_t.
3742 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3743
109e28d0
PE
3744 Fix minor problems found by static checking.
3745
60737f02
PE
3746 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3747
4b66faf3
PE
3748 Make identifiers static if they are not used in other modules.
3749 * data.c (Qcompiled_function, Qframe, Qvector):
3750 * image.c (QimageMagick, Qsvg):
3751 * minibuf.c (Qmetadata):
3752 * window.c (resize_window_check, resize_root_window): Now static.
3753 * window.h (resize_window_check, resize_root_window): Remove decls.
3754
109e28d0
PE
3755 * window.c (window_deletion_count, delete_deletable_window):
3756 Remove; unused.
46a4ce9e
PE
3757 (window_body_lines): Now static.
3758 (Fdelete_other_windows_internal): Mark vars as initialized.
3759 Make sure 'resize_failed' is initialized.
3760 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3761 (resize_window_apply): Remove unused local.
3762 * window.h (delete_deletable_window): Remove decl.
3763
109e28d0 3764 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3765 (imagemagick_load_image): Fix pointer signedness problem by changing
3766 last arg from unsigned char * to char *. All uses changed.
3767 Also, fix a local for similar reasons.
3768 Remove unused locals. Remove locals to avoid shadowing.
3769 (fn_rsvg_handle_free): Remove; unused.
3770 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3771 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3772
3f754b86
PE
3773 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3774
2547adb1
CY
37752011-06-10 Chong Yidong <cyd@stupidchicken.com>
3776
3777 * image.c (gif_load): Fix omitted cast error introduced by
3778 2011-06-06 change.
3779
2c8e37d4
MR
37802011-06-10 Martin Rudalics <rudalics@gmx.at>
3781
3782 * window.h (resize_proportionally, orig_total_lines)
3783 (orig_top_line): Remove from window structure.
3784 (set_window_height, set_window_width, change_window_heights)
3785 (Fdelete_window): Remove prototypes.
3786 (resize_frame_windows): Remove duplicate declaration.
3787
440a42e3
EZ
37882011-06-10 Eli Zaretskii <eliz@gnu.org>
3789
3790 * window.h (resize_frame_windows, resize_window_check)
3791 (delete_deletable_window, resize_root_window)
3792 (resize_frame_windows): Declare prototypes.
3793
3794 * window.c (resize_window_apply): Make definition be "static" to
3795 match the prototype.
3796
562dd5e9
MR
37972011-06-10 Martin Rudalics <rudalics@gmx.at>
3798
3799 * window.c: Remove declarations of Qwindow_size_fixed,
3800 window_min_size_1, window_min_size_2, window_min_size,
3801 size_window, window_fixed_size_p, enlarge_window, delete_window.
3802 Remove static from declaration of Qdelete_window, it's
3803 temporarily needed by Fbury_buffer.
3804 (replace_window): Don't assign orig_top_line and
3805 orig_total_lines.
3806 (Fdelete_window, delete_window): Remove. Window deletion is
3807 handled by window.el.
640c8776
SM
3808 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3809 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3810 (Fdelete_other_windows): Remove. Deleting other windows is
3811 handled by window.el.
3812 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3813 handled in window.el.
3814 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3815 Window minimum sizes are handled in window.el.
3816 (shrink_windows, size_window, set_window_height)
3817 (set_window_width, change_window_heights, window_height)
3818 (window_width, CURBEG, CURSIZE, enlarge_window)
3819 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3820 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3821 handled in window.el.
3822 (make_dummy_parent): Rename to make_parent_window and give it a
3823 second argument horflag.
3824 (make_window): Don't set resize_proportionally any more.
3825 (Fsplit_window): Remove. Windows are split in window.el.
3826 (save_restore_action, save_restore_orig_size)
3827 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3828 Resize mini windows in window.el.
3829 (grow_mini_window, shrink_mini_window): Implement by calling
3830 Qresize_root_window_vertically, resize_window_check and
3831 resize_window_apply.
640c8776
SM
3832 (saved_window, Fset_window_configuration, save_window_save):
3833 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3834 resize_proportionally.
3835 (window_min_height, window_min_width): Move to window.el.
3836 (keys_of_window): Move bindings for delete-other-windows,
3837 split-window, delete-window and enlarge-window to window.el.
3838
3839 * buffer.c: Temporarily extern Qdelete_window.
3840 (Fbury_buffer): Temporarily call Qdelete_window instead of
3841 Fdelete_window (Fbury_buffer will move to window.el soon).
3842
3843 * frame.c (set_menu_bar_lines_1): Remove code handling
3844 orig_top_line and orig_total_lines.
3845
3846 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3847 set_window_height but set heights directly.
3848 (change_frame_size_1): Use resize_frame_windows.
3849
3850 * xdisp.c (init_xdisp): Don't use set_window_height but set
3851 heights directly.
3852
640c8776
SM
3853 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3854 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3855 run_window_configuration_change_hook.
3856
3857 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3858 instead of change_window_heights and run
3859 run_window_configuration_change_hook.
3860
1a13852e
MR
38612011-06-09 Martin Rudalics <rudalics@gmx.at>
3862
3863 * window.c (replace_window): Rename second argument REPLACEMENT to
3864 NEW. New third argument SETFLAG. Rewrite.
3865 (delete_window, make_dummy_parent): Call replace_window with
3866 third argument 1.
3867 (window_list_1): Move down in code.
3868 (run_window_configuration_change_hook): Move set_buffer part
3869 before select_frame_norecord part in order to unwind correctly.
3870 Rename count1 to count.
3871 (recombine_windows, delete_deletable_window, resize_root_window)
3872 (Fdelete_other_windows_internal)
3873 (Frun_window_configuration_change_hook, make_parent_window)
3874 (resize_window_check, resize_window_apply, Fresize_window_apply)
3875 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3876 (Fdelete_window_internal, Fresize_mini_window_internal):
3877 New functions.
1a13852e
MR
3878 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3879
f3d1777e
MR
38802011-06-08 Martin Rudalics <rudalics@gmx.at>
3881
496e208e
MR
3882 * window.h (window): Add some new members to window structure -
3883 normal_lines, normal_cols, new_total, new_normal, clone_number,
3884 splits, nest, prev_buffers, next_buffers.
3885 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3886 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3887
f3d1777e
MR
3888 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3889 Remove.
496e208e
MR
3890 (make_dummy_parent): Set new members of windows structure.
3891 (make_window): Move down in code. Handle new members of window
3892 structure.
3893 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3894 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3895 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3896 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3897 (Fset_window_next_buffers, Fset_window_clone_number):
3898 New functions.
496e208e
MR
3899 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3900 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3901 Doc-string fixes.
3902 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3903 Argument WINDOW can be now internal window too.
3904 (Fwindow_use_time): Move up in code.
3905 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3906 Rewrite doc-string.
3907 (Fset_window_configuration, saved_window)
3908 (Fcurrent_window_configuration, save_window_save): Handle new
3909 members of window structure.
b9e809c2
MR
3910 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3911 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3912 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3913 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3914 Qget_mru_window, Qresize_root_window,
3915 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3916 Qauto_buffer_name; staticpro them.
f3d1777e 3917
abde8f8c
MR
39182011-06-07 Martin Rudalics <rudalics@gmx.at>
3919
3920 * window.c (Fwindow_total_size, Fwindow_left_column)
3921 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3922 (Fwindow_list_1): New functions.
3923 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3924 (Fwindow_width, Fscroll_left, Fscroll_right):
3925 Use window_body_cols instead of window_box_text_cols.
3926 (delete_window, Fset_window_configuration):
3927 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3928 (delete_all_subwindows): Take a window as argument and not a
3929 structure. Rewrite.
190b47e6
MR
3930 (window_loop): Remove handling of GET_LRU_WINDOW and
3931 GET_LARGEST_WINDOW.
3932 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3933
3934 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3935 window_box_text_cols. delete_all_subwindows now takes a
3936 Lisp_Object as argument.
abde8f8c 3937
640c8776
SM
3938 * indent.c (compute_motion, Fcompute_motion):
3939 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3940
fa8a67e6
MR
3941 * frame.c (delete_frame): Call delete_all_subwindows with root
3942 window as argument.
3943
a54e3482
DC
39442011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3945
3946 * fns.c (Fputhash): Document return value.
3947
60002bf5
CY
39482011-06-06 Chong Yidong <cyd@stupidchicken.com>
3949
3950 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3951
0c671da6 39522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3953
b862a52a 3954 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3955
be44ca6c
PE
3956 Check for overflow when converting integer to cons and back.
3957 * charset.c (Fdefine_charset_internal, Fdecode_char):
3958 Use cons_to_unsigned to catch overflow.
3959 (Fencode_char): Use INTEGER_TO_CONS.
3960 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3961 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3962 * data.c (long_to_cons, cons_to_long): Remove.
3963 (cons_to_unsigned, cons_to_signed): New functions.
3964 These signal an error for invalid or out-of-range values.
3965 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3966 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3967 * font.c (Ffont_variation_glyphs):
3968 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3969 * lisp.h: Include <intprops.h>.
3970 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3971 (cons_to_signed, cons_to_unsigned): New decls.
3972 (long_to_cons, cons_to_long): Remove decls.
3973 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3974 (Fprimitive_undo): Use CONS_TO_INTEGER.
3975 * xfns.c (Fx_window_property): Likewise.
3976 * xselect.c: Include <limits.h>.
3977 (x_own_selection, selection_data_to_lisp_data):
3978 Use INTEGER_TO_CONS.
3979 (x_handle_selection_request, x_handle_selection_clear)
3980 (x_get_foreign_selection, Fx_disown_selection_internal)
3981 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3982 (lisp_data_to_selection_data): Use cons_to_unsigned.
3983 (x_fill_property_data): Use cons_to_signed.
3984 Report values out of range.
3985
d1f3d2af
PE
3986 Check for buffer and string overflow more precisely.
3987 * buffer.h (BUF_BYTES_MAX): New macro.
3988 * lisp.h (STRING_BYTES_MAX): New macro.
3989 * alloc.c (Fmake_string):
3990 * character.c (string_escape_byte8):
3991 * coding.c (coding_alloc_by_realloc):
3992 * doprnt.c (doprnt):
3993 * editfns.c (Fformat):
3994 * eval.c (verror):
3995 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3996 since they may not be the same number.
3997 * editfns.c (Finsert_char):
3998 * fileio.c (Finsert_file_contents):
3999 Likewise for BUF_BYTES_MAX.
4000
dd52fcea
PE
4001 * image.c: Use ptrdiff_t, not int, for sizes.
4002 (slurp_file): Switch from int to ptrdiff_t.
4003 All uses changed.
4004 (slurp_file): Check that file size fits in both size_t (for
4005 malloc) and ptrdiff_t (for sanity and safety).
4006
7f9bbdbb
PE
4007 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4008 if b->modtime has its maximal value.
4009
dfe18f82
PE
4010 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4011
84acfcf0
PE
4012 Don't assume time_t can fit into int.
4013 * buffer.h (struct buffer.modtime): Now time_t, not int.
4014 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4015 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4016
ccd9a01a
PE
4017 Minor fixes for signed vs unsigned integers.
4018 * character.h (MAYBE_UNIFY_CHAR):
4019 * charset.c (maybe_unify_char):
4020 * keyboard.c (read_char, reorder_modifiers):
4021 XINT -> XFASTINT, since the integer must be nonnegative.
4022 * ftfont.c (ftfont_spec_pattern):
4023 * keymap.c (access_keymap, silly_event_symbol_error):
4024 XUINT -> XFASTINT, since the integer must be nonnegative.
4025 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4026 since it makes no difference and we prefer signed.
4027 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4028 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4029 nonnegative.
4030
d6d100dd
SM
40312011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4032
4033 * window.h (Fwindow_frame): Declare.
4034
2b6148e4
PE
40352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4038 (SPARE_MEMORY): Always define.
4039 (LARGE_REQUEST): Remove.
4040 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4041
f230ecc9
MR
40422011-06-06 Martin Rudalics <rudalics@gmx.at>
4043
727e958e
MR
4044 * lisp.h: Move EXFUNS for Fframe_root_window,
4045 Fframe_first_window and Fset_frame_selected_window to window.h.
4046
4047 * window.h: Move EXFUNS for Fframe_root_window,
4048 Fframe_first_window and Fset_frame_selected_window here from
4049 lisp.h.
4050
4051 * frame.c (Fwindow_frame, Fframe_first_window)
4052 (Fframe_root_window, Fframe_selected_window)
4053 (Fset_frame_selected_window): Move to window.c.
4054 (Factive_minibuffer_window): Move to minibuf.c.
4055 (Fother_visible_frames_p): New function.
4056
4057 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4058
f230ecc9
MR
4059 * window.c (decode_window, decode_any_window): Move up in code.
4060 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4061 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4062 (Fwindow_buffer): Move up and rewrite doc-string.
4063 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4064 (Fwindow_prev): New functions.
727e958e
MR
4065 (Fwindow_frame): Move here from frame.c. Accept any window as
4066 argument.
4067 (Fframe_root_window, Fframe_first_window)
4068 (Fframe_selected_window): Move here from frame.c. Accept frame
4069 or arbitrary window as argument. Update doc-strings.
4070 (Fminibuffer_window): Move up in code.
4071 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4072 (Fset_frame_selected_window): Move here from frame.c.
4073 Marginal rewrite.
727e958e
MR
4074 (Fselected_window, select_window, Fselect_window): Move up in
4075 code. Minor doc-string fixes.
f230ecc9 4076
4d09bcf6
PE
40772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4078
4079 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4080 Do not assume that spare memory exists; that assumption is valid
4081 only if SYSTEM_MALLOC.
4082 (LARGE_REQUEST): New macro, so that the issue of large requests
4083 is separated from the issue of spare memory.
4084
810928a2
AS
40852011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4086
172418ad
AS
4087 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4088 format. (Bug#8806)
4089
43f862f7
AS
4090 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4091
810928a2
AS
4092 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4093 before statements.
4094
a059fe24
JD
40952011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4096
4097 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4098
4099 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4100
4101 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4102 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4103
989bf368
JB
41042011-06-05 Juanma Barranquero <lekktu@gmail.com>
4105
4106 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4107
4b80f674
CY
41082011-06-04 Chong Yidong <cyd@stupidchicken.com>
4109
4110 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4111 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4112 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4113 New error handlers.
4b80f674
CY
4114 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4115 Obey Vx_select_enable_clipboard_manager. Catch errors in
4116 x_clipboard_manager_save (Bug#8779).
4117 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4118 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4119
99a33b77 41202011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4121
4122 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4123
99a33b77 41242011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4125
4126 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4127 in the current matrix if keep_current_p is non-zero.
4128
8264569d
EZ
41292011-06-04 Eli Zaretskii <eliz@gnu.org>
4130
4131 * bidi.c (bidi_level_of_next_char): Fix last change.
4132
57f97249
EZ
41332011-06-03 Eli Zaretskii <eliz@gnu.org>
4134
fec2107c 4135 Support bidi reordering of text covered by display properties.
57f97249 4136
fec2107c
EZ
4137 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4138 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4139 (bidi_cache_search, bidi_cache_iterator_state)
4140 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4141 (bidi_level_of_next_char, bidi_move_to_visually_next):
4142 Support character positions inside a run of characters covered by a
fec2107c
EZ
4143 display string.
4144 (bidi_paragraph_init, bidi_resolve_explicit_1)
4145 (bidi_level_of_next_char): Call bidi_fetch_char and
4146 bidi_fetch_char_advance instead of FETCH_CHAR and
4147 FETCH_CHAR_ADVANCE.
4148 (bidi_init_it): Initialize new members.
4149 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4150 definitions.
4151 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4152 instead of using explicit *_CHAR codes.
d6d100dd
SM
4153 (bidi_resolve_explicit, bidi_resolve_weak):
4154 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4155 bidirectional text is supported only in multibyte buffers.
4156 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4157 it to initialize the frame_window_p member of struct bidi_it.
4158 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4159 (bidi_resolve_explicit, bidi_resolve_weak)
4160 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4161 bidi_it->nchars is non-positive.
4162 (bidi_level_of_next_char): Don't try to lookup the cache for the
4163 next/previous character if nothing is cached there yet, or if we
4164 were just reseat()'ed to a new position.
c40e2fb2 4165
0e14fe90
EZ
4166 * xdisp.c (set_cursor_from_row): Set start and stop points
4167 according to the row's direction when priming the loop that looks
4168 for the glyph on which to display cursor.
4169 (single_display_spec_intangible_p): Function deleted.
4170 (display_prop_intangible_p): Reimplement to call
4171 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4172 Accept 3 additional arguments needed by handle_display_spec.
4173 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4174 values: lists, `(when COND...)' forms, etc.
4175 (single_display_spec_string_p): Support property values that are
4176 lists with the argument STRING its top-level element.
4177 (display_prop_string_p): Fix the condition for processing a
4178 property that is a list to be consistent with handle_display_spec.
fec2107c 4179 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4180 last portion of handle_display_prop.
4181 (compute_display_string_pos): Accept additional argument
4182 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4183 value of a `display' property is a "replacing spec".
4184 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4185 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4186 the display property, but just return a value indicating whether
4187 the display property will replace the characters it covers.
4188 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4189 frame_window_p members of struct bidi_it.
d6d100dd
SM
4190 (compute_display_string_pos, compute_display_string_end):
4191 New functions.
fec2107c
EZ
4192 (push_it): Accept second argument POSITION, where pop_it should
4193 jump to continue iteration.
4194 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4195
fec2107c
EZ
4196 * keyboard.c (adjust_point_for_property): Adjust the call to
4197 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4198
4199 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4200 (bidi_init_it): Update prototypes.
4201 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4202 (compute_display_string_pos, compute_display_string_end):
4203 Declare prototypes.
fec2107c
EZ
4204 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4205 EMACS_INT.
fc6f18ce 4206
40087514 42072011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4208
57f53182
PE
4209 Malloc failure behavior now depends on size of allocation.
4210 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4211 * lisp.h: Change signatures accordingly.
4212 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4213 All callers changed. (Bug#8762)
4214
4215 * gnutls.c: Use Emacs's memory allocators.
4216 Without this change, the gnutls library would invoke malloc etc.
4217 directly, which causes problems on non-SYNC_INPUT hosts, and which
4218 runs afoul of improving memory_full behavior. (Bug#8761)
4219 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4220 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4221 xfree instead of the default malloc, realloc, free.
4222 (Fgnutls_boot): No need to check for memory allocation failure,
4223 since xmalloc does that for us.
4224
ac32cd99 4225 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4226 * category.c (hash_get_category_set):
4227 * ccl.c (ccl_driver):
4228 * charset.c (Fdefine_charset_internal):
4229 * charset.h (struct charset.hash_index):
4230 * composite.c (get_composition_id, gstring_lookup_cache)
4231 (composition_gstring_put_cache):
4232 * composite.h (struct composition.hash_index):
4233 * dispextern.h (struct image.hash):
4234 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4235 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4236 (hashfn_equal, hashfn_user_defined, make_hash_table)
4237 (maybe_resize_hash_table, hash_lookup, hash_put)
4238 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4239 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4240 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4241 * image.c (make_image, search_image_cache, lookup_image)
4242 (xpm_put_color_table_h):
4243 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4244 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4245 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4246 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4247 * alloc.c (allocate_vectorlike):
4248 Check for overflow in vector size calculations.
4249 * ccl.c (ccl_driver):
4250 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4251 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4252 need to be updated by these changes.
40087514
PE
4253 * fns.c (make_hash_table, maybe_resize_hash_table):
4254 Check for integer overflow with large hash tables.
0de4bb68
PE
4255 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4256 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4257 (SXHASH_REDUCE): New macro.
4258 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4259 Use it instead of discarding useful hash info with large hash values.
4260 (sxhash_float): New function.
4261 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4262 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4263 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4264 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4265 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4266 Adjust signatures to match updated version of code.
4267 (consing_since_gc): Now EMACS_INT, since a single hash table can
4268 use more than INT_MAX bytes.
4269
698d32e2
DN
42702011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4271
4272 Make it possible to build with GCC-4.6+ -O2 -flto.
4273
4274 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4275
fd6fa53f
SM
42762011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4277
4278 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4279 Call minibuffer-inactive-mode.
4280
864db017
JB
42812011-05-31 Juanma Barranquero <lekktu@gmail.com>
4282
4283 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4284 Update dependencies.
4285
2ad0baf4
DN
42862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4287
4288 * data.c (init_data): Remove code for UTS, this system is not
4289 supported anymore.
4290
4fcc2638
DN
42912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4292
4293 Don't force ./temacs to start in terminal mode.
4294
4295 * frame.c (make_initial_frame): Initialize faces in all cases, not
4296 only when CANNOT_DUMP is defined.
4297 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4298
c56e0fd5
DN
42992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4300
4301 * dispnew.c (add_window_display_history): Use const for the string
4302 pointer. Remove declaration, not needed.
4303
333d54da 43042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4305
55d4c1b2 4306 Use 'inline', not 'INLINE'.
333d54da 4307 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4308 * alloc.c, fontset.c (INLINE): Remove.
4309 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4310 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4311 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4312 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4313 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4314
738db178
DN
43152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4316
4317 Make it possible to run ./temacs.
4318
4319 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4320 syms_of_callproc does the same thing. Remove test for
4321 "initialized", do it in the caller.
4322 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4323
620c53a6
SM
43242011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4325
4326 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4327 (read_minibuf): Use get_minibuffer.
4328 (syms_of_minibuf): Use DEFSYM.
4329 (Qmetadata): New var.
4330 * data.c (Qbuffer): Don't make it static.
4331 (syms_of_data): Use DEFSYM.
4332
e003a292
PE
43332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4334
4335 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4336 (CCL_CODE_MIN): New macro.
4337
ed008a6d
PE
43382011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4339
3687c2ef
PE
4340 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4341
ed008a6d
PE
4342 * eval.c (Qdebug): Now static.
4343 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4344 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4345 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4346
d66c4c7c
CY
43472011-05-29 Chong Yidong <cyd@stupidchicken.com>
4348
4349 * image.c: Various fixes to ImageMagick code comments.
4350 (Fimagemagick_types): Doc fix.
4351
5fbc2025
PE
43522011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4353
0196f88a
PE
4354 Minor fixes prompted by GCC 4.6.0 warnings.
4355
4356 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4357
5fbc2025
PE
4358 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4359 (x_clipboard_manager_save_all): Move extern decl to ...
4360 * xterm.h: ... here, so that it can be checked for consistency.
4361
1dd3c2d9
CY
43622011-05-29 Chong Yidong <cyd@stupidchicken.com>
4363
4364 * xselect.c (x_clipboard_manager_save_frame)
4365 (x_clipboard_manager_save_all): New functions.
4366 (Fx_clipboard_manager_save): Lisp function deleted.
4367
4368 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4369 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4370
4371 * xterm.h: Update prototype.
4372
5ba6571d
WX
43732011-05-28 William Xu <william.xwl@gmail.com>
4374
4375 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4376 exiting (Bug#8239).
4377
3eaff834
JM
43782011-05-28 Jim Meyering <meyering@redhat.com>
4379
e1900994 4380 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4381 * fns.c (to_uchar): Define.
4382 (crypto_hash_function): Use it to convert some newly-signed
4383 variables to unsigned, to avoid sign-extension bugs. For example,
4384 without this change, (md5 "truc") would evaluate to
4385 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4386 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4387 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4388
0f6990a7
PE
43892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 Integer overflow fixes.
c8a9ca5a 4392
08686060
PE
4393 * dbusbind.c: Serial number integer overflow fixes.
4394 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4395 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4396 to hold a serial number that is too large for a fixnum.
4397 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4398 Check for serial numbers out of range. Decode any serial number
59568bf0 4399 that was so large that it became a float. (Bug#8722)
08686060 4400
2d1fc3c7
PE
4401 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4402 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4403 Use XFASTINT rather than XUINT when numbers are nonnegative.
4404 (xd_append_arg, Fdbus_method_return_internal):
4405 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4406 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4407 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4408 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4409 (Bug#8722)
2d1fc3c7 4410
c8a9ca5a
PE
4411 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4412
519e1d69
PE
4413 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4414
30569699
PE
4415 ccl: add integer overflow checks
4416 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4417 (IN_INT_RANGE): New macros.
4418 (ccl_driver): Use them to check for integer overflow when
4419 decoding a CCL program. Many of the new checks are whether XINT (x)
4420 fits in int; it doesn't always, on 64-bit hosts. The new version
4421 doesn't catch all possible integer overflows, but it's an
847044ea 4422 improvement. (Bug#8719)
30569699 4423
c11285dc
PE
4424 * alloc.c (make_event_array): Use XINT, not XUINT.
4425 There's no need for unsigned here.
4426
fdccd48e
PE
4427 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4428 This follows up to the 2011-05-06 change that substituted uintptr_t
4429 for EMACS_INT. This case wasn't caught back then.
4430
37910ab2
PE
4431 Rework Fformat to avoid integer overflow issues.
4432 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4433 now (part of C89). Include <verify.h>.
4434 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4435 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4436 (Fformat): Avoid the prepass trying to compute sizes; it was only
4437 approximate and thus did not catch overflow reliably. Instead, walk
4438 through the format just once, formatting and computing sizes as we go,
4439 checking for integer overflow at every step, and allocating a larger
4440 buffer as needed. Keep track separately whether the format is
4441 multibyte. Keep only the most-recently calculated precision, rather
4442 than them all. Record whether each argument has been converted to
4443 string. Use EMACS_INT, not int, for byte and char and arg counts.
4444 Support field widths and precisions larger than INT_MAX. Avoid
4445 sprintf's undefined behavior with conversion specifications such as %#d
4446 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4447 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4448 formatting out-of-range floating point numbers with int
9173deec 4449 formats. (Bug#8668)
37910ab2 4450
2e6578fb
PE
4451 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4452
0ae6bdee
PE
4453 * data.c: Avoid integer truncation in expressions involving floats.
4454 * data.c: Include <intprops.h>.
4455 (arith_driver): When there's an integer overflow in an expression
4456 involving floating point, convert the integers to floating point
4457 so that the resulting value does not suffer from catastrophic
4458 integer truncation. For example, on a 64-bit host (* 4
4459 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4460 Do not rely on undefined behavior after integer overflow.
4461
de883a70
PE
4462 merge count_size_as_multibyte, parse_str_to_multibyte
4463 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4464 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4465 Check for integer overflow.
4466 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4467 since it's now a duplicate of the other. This is more of
4468 a character than a buffer op, so better that it's in character.c.
4469 * fns.c, print.c: Adjust to above changes.
4470
2ff916cb
PE
44712011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4472
4473 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4474
f1b54466
PE
44752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4476
fb1ac845
PE
4477 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4478 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4479 (x_clipboard_manager_save): Now static.
4480 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4481
f1b54466
PE
4482 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4483 (crypto_hash_function): Now static.
4484 Fix pointer signedness problems. Avoid unnecessary initializations.
4485
a9f737ee
CY
44862011-05-27 Chong Yidong <cyd@stupidchicken.com>
4487
4488 * termhooks.h (Vselection_alist): Make it terminal-local.
4489
4490 * terminal.c (create_terminal): Initialize it.
4491
4492 * xselect.c: Support for clipboard managers.
4493 (Vselection_alist): Move to termhooks.h as terminal-local var.
4494 (LOCAL_SELECTION): New macro.
4495 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4496 (symbol_to_x_atom): Remove gratuitous arg.
4497 (x_handle_selection_request, lisp_data_to_selection_data)
4498 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4499 (x_own_selection, x_get_local_selection, x_convert_selection):
4500 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4501 (some_frame_on_display): Delete unused function.
4502 (Fx_own_selection_internal, Fx_get_selection_internal)
4503 (Fx_disown_selection_internal, Fx_selection_owner_p)
4504 (Fx_selection_exists_p): New optional frame arg.
4505 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4506 (x_handle_selection_clear): Don't treat other terminals with the
4507 same keyboard specially. Use the terminal-local Vselection_alist.
4508 (x_clear_frame_selections): Use Frun_hook_with_args.
4509
4510 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4511
4512 * xterm.h: Add support for those atoms.
4513
e067f0c1
CY
45142011-05-26 Chong Yidong <cyd@stupidchicken.com>
4515
4516 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4517 (converted_selections, conversion_fail_tag): New global variables.
4518 (x_selection_request_lisp_error): Free the above.
4519 (x_get_local_selection): Remove unnecessary code.
4520 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4521 of converted selections stored in converted_selections.
4522 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4523 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4524 (x_convert_selection): New function.
4525 (x_handle_selection_event): Simplify.
4526 (x_get_foreign_selection): Don't ignore incoming requests while
4527 waiting for an answer; this will fail when we implement
4528 SAVE_TARGETS, and seems unnecessary anyway.
4529 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4530 (Vx_sent_selection_functions): Doc fix.
4531
0f4aebc0
LL
45322011-05-26 Leo Liu <sdl.web@gmail.com>
4533
4534 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4535
e61124cd
YM
45362011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4537
4538 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4539
4540 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4541 for fringe update if it has periodic bitmap.
ac389d0c 4542 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4543 and fringe_bitmap_periodic_p.
4544
4545 * fringe.c (get_fringe_bitmap_data): New function.
4546 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4547 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4548 row. Mark glyph row for fringe update if periodicity changed.
4549
4550 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4551 for fringe update unless it has periodic bitmap.
4552
f16d9837
KH
45532011-05-25 Kenichi Handa <handa@m17n.org>
4554
4555 * xdisp.c (get_next_display_element): Set correct it->face_id for
4556 a static composition.
4557
e1b90ef6
LL
45582011-05-24 Leo Liu <sdl.web@gmail.com>
4559
4560 * deps.mk (fns.o):
4561 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4562
4563 * fns.c (crypto_hash_function, Fsha1): New function.
4564 (Fmd5): Use crypto_hash_function.
4565 (syms_of_fns): Add Ssha1.
4566
7400048f
PE
45672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * gnutls.c: Remove unused macros.
4570 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4571 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4572 Remove macros that are defined and never used.
4573 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4574
abb71cf4
CY
45752011-05-22 Chong Yidong <cyd@stupidchicken.com>
4576
4577 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4578 (Fx_get_selection_internal): Minor cleanup.
4579 (Fx_own_selection_internal): Rename arguments for consistency with
4580 select.el.
4581
6307db39
PE
45822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4583
4584 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4585
f3d4e0a4
CY
45862011-05-22 Chong Yidong <cyd@stupidchicken.com>
4587
4588 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4589
4d8ade89
YM
45902011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4591
4592 * dispnew.c (scrolling_window): Don't exclude the case that the
4593 last enabled row in the desired matrix touches the bottom boundary.
4594
32078c8d
GM
45952011-05-21 Glenn Morris <rgm@gnu.org>
4596
4597 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4598 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4599 and add some more files.
32078c8d 4600
7285dc67
EZ
46012011-05-20 Eli Zaretskii <eliz@gnu.org>
4602
4603 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4604 report_file_error introduced by the change from 2011-05-07.
4605
89d1bd22
PE
46062011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4607
4608 * systime.h (Time): Define only if emacs is defined.
4609 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4610 where the include path doesn't have X11/X.h by default. See
4611 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4612
e23640bb 46132011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4614
4615 * composite.c (find_automatic_composition): Fix previous change.
4616
b9704ad9
GM
46172011-05-20 Glenn Morris <rgm@gnu.org>
4618
4619 * lisp.mk: New file, split from Makefile.in.
4620 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4621 (shortlisp): Remove.
4622 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4623
4a720484
GM
46242011-05-19 Glenn Morris <rgm@gnu.org>
4625
4626 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4627 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4628 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4629 (lisp): Set the order to that of loadup.el.
4630 (shortlisp): Make it a copy of $lisp.
4631 (SOME_MACHINE_LISP): Remove.
4632 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4633 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4634
a28d4396
KH
46352011-05-18 Kenichi Handa <handa@m17n.org>
4636
4637 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4638 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4639 (find_automatic_composition): Mostly rewrite for efficiency.
4640
a2b1fa8e
JB
46412011-05-18 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * makefile.w32-in: Update dependencies.
4644
8e1f5610
CS
46452011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4646
4647 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4648 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4649
7025ee00 46502011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4651
cdfa6eab
PE
4652 Fix some integer overflow issues, such as string length overflow.
4653
06d6db33
PE
4654 * insdel.c (count_size_as_multibyte): Check for string overflow.
4655
2b4560a8
PE
4656 * character.c (lisp_string_width): Check for string overflow.
4657 Use EMACS_INT, not int, for string indexes and lengths; in
4658 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4659 the resulting string length overflows an EMACS_INT; instead,
4660 report a string overflow if no precision given. When checking for
4661 precision exhaustion, use a check that cannot possibly have
4662 integer overflow. (Bug#8675)
4663 * character.h (lisp_string_width): Adjust to new signature.
4664
cb93f9be
PE
4665 * alloc.c (string_overflow): New function.
4666 (Fmake_string): Use it. This doesn't change behavior, but saves
4667 a few bytes and will simplify future changes.
4668 * character.c (string_escape_byte8): Likewise.
4669 * lisp.h (string_overflow): New decl.
4670
1a1f3366
PE
4671 Fixups, following up to the user-interface timestamp change.
4672 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4673 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4674 * msdos.c (mouse_get_pos): Likewise.
4675 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4676 * w32gui.h (Time): Define by including "systime.h" rather than by
4677 declaring it ourselves. (Bug#8664)
4678
d4e3e4d3
PE
4679 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4680 * image.c (clear_image_cache): Likewise.
4681
f6a24d19
PE
4682 * term.c (term_mouse_position): Don't assume time_t wraparound.
4683
08dc5ae6
PE
4684 Be more systematic about user-interface timestamps.
4685 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4686 and sometimes 'EMACS_UINT', to represent these timestamps.
4687 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4688 This makes the code easier to follow, and makes it easier to catch
4689 integer overflow bugs such as Bug#8664.
4690 * frame.c (Fmouse_position, Fmouse_pixel_position):
4691 Use Time, not unsigned long, for user-interface timestamps.
4692 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4693 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4694 * keyboard.h (last_event_timestamp): Likewise.
4695 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4696 * menu.h (xmenu_show): Likewise.
4697 * term.c (term_mouse_position): Likewise.
4698 * termhooks.h (struct input_event.timestamp): Likewise.
4699 (struct terminal.mouse_position_hook): Likewise.
4700 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4701 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4702 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4703 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4704 what it was before.
4705 * menu.h, termhooks.h: Include "systime.h", for Time.
4706
8e55734a
PE
4707 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4708 Don't assume that the difference between two unsigned long values
4709 can fit into an integer. At this point, we know button_down_time
4710 <= event->timestamp, so the difference must be nonnegative, so
4711 there's no need to cast the result if double-click-time is
4712 nonnegative, as it should be; check that it's nonnegative, just in
4713 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4714 apart (about 25 days). (Bug#8664)
8e55734a 4715
841f1b75 4716 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4717 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4718
3e26f69c
PE
4719 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4720 that always fit in int. Use a sentinel instead of a counter, to
4721 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4722 * frame.h (struct frame): Use int for menu_bar_items_used
4723 instead of EMACS_INT, since it always fits in int.
3e26f69c 4724
5cc152c0
PE
4725 * menu.c (grow_menu_items): Check for int overflow.
4726
d89eb65e
PE
4727 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4728
5235bd3e
PE
4729 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4730 Before, the code was not consistent. These values cannot exceed
4731 2**31 - 1 so there's no need to make them unsigned.
4732 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4733 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4734 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4735 as modifiers.
4736 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4737
bc827e23
PE
4738 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4739 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4740 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4741 presumably because the widths might not match.
4742
78eb494e
PE
4743 * window.c (size_window): Avoid needless test at loop start.
4744
04f2d78b
CB
47452011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4746
4747 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4748
d2fc7e3d 47492011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4750
4751 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4752
d2fc7e3d 47532011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4754
4755 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4756 `width' to `bar_area_x' and `bar_area_width', respectively.
4757 (x_scroll_run): Take account of fringe background extension.
4758
04f2d78b
CB
4759 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4760 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4761 `bar_area_width', respectively.
4762 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4763 background extension.
4764
79b70037
GM
47652011-05-10 Jim Meyering <meyering@redhat.com>
4766
4767 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4768
2f142cc5
JB
47692011-05-10 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * image.c (Finit_image_library): Return t for built-in image types,
4772 like pbm and xbm. (Bug#8640)
4773
57679c86
AS
47742011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4775
4776 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4777
888c9e86
EZ
47782011-05-07 Eli Zaretskii <eliz@gnu.org>
4779
b0512a1d
EZ
4780 * w32console.c (Fset_screen_color): Doc fix.
4781 (Fget_screen_color): New function.
4782 (syms_of_ntterm): Defsubr it.
4783
7285dc67
EZ
4784 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4785 unlink the temporary file if Fcall_process didn't create it in the
4786 first place.
4787 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4788 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4789 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4790 cue to call_process_cleanup not to close that handle.
4791
4d3fcc8e
BK
47922011-05-07 Ben Key <bkey76@gmail.com>
4793
4794 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4795 one of two shell specific rules, either bootstrap-temacs-CMD or
4796 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4797 to the previous implementation of the bootstrap-temacs rule.
4798 The bootstrap-temacs-CMD rule is similar to the previous
4799 implementation of the bootstrap-temacs rule except that it
4800 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4801 variable.
4802
4803 These changes, along with some changes to nt/configure.bat,
4804 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4805 earlier fix to add support for --cflags and --ldflags options
4806 that include quotes so that it works whether make uses cmd or
4807 sh as the shell.
4808
b4289b64
MA
48092011-05-06 Michael Albinus <michael.albinus@gmx.de>
4810
4811 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4812 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4813 is a constant.
4814 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4815 a string. Handle both cases.
4816 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4817 (Fdbus_register_method): Use Qinvalid_function.
4818
af4c0e28
JB
48192011-05-06 Juanma Barranquero <lekktu@gmail.com>
4820
4821 * makefile.w32-in: Update dependencies.
4822 (LISP_H): Add inttypes.h and stdin.h.
4823 (PROCESS_H): Add unistd.h.
4824
c51453d9
EZ
48252011-05-06 Eli Zaretskii <eliz@gnu.org>
4826
4827 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4828 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4829
8ff0ac3c 48302011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4831
4c4b566b
PE
4832 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4833
aab2b9b5
PE
4834 * term.c (vfatal): Remove stray call to va_end.
4835 It's not needed and the C Standard doesn't allow it here anyway.
4836
c378da0b
PE
4837 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4838 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4839
288b08c7
PE
4840 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4841 bytes.
4842
e3601888
PE
4843 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4844
db6c0e74
PE
4845 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4846
dd5963ea
PE
4847 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4848
88c9450f
PE
4849 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4850
2f9442b8
PE
4851 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4852
c032b5f8
PE
4853 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4854 * charset.c (Fdefine_charset_internal): Don't initialize
4855 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4856 32-bit int (Bug#8600).
a108c10b
PE
4857
4858 * lread.c (read_integer): Be more consistent with string-to-number.
4859 Use string_to_number to do the actual conversion; this avoids
4860 rounding errors and fixes some other screwups. Without this fix,
4861 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4862 (digit_to_number): Move earlier, for benefit of read_integer.
4863 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4864 not a digit in any supported base. (Bug#8602)
a108c10b 4865
ad5f9eea
PE
4866 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4867
aec1708a
PE
4868 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4869 to match comment at start of function. This also removes a
4870 GCC warning about overflow in a 32+64-bit port.
4871
47be4ab5
PE
4872 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4873
371cac43
PE
4874 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4875 Reported by Stefan Monnier in
4876 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4877 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4878 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4879
d01a7826
PE
4880 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4881 (EMACS_UINTPTR): Likewise, with uintptr_t.
4882
7fd47d5c
PE
4883 * lisp.h: Prefer 64-bit EMACS_INT if available.
4884 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4885 on 32-bit hosts that have 64-bit int, so that they can access
4886 large files.
122b0c86
PE
4887 However, temporarily disable this change unless the temporary
4888 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4889
8727937b
PE
4890 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4891
8ac068ac
PE
4892 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4893 This removes an assumption that EMACS_INT and long are the same
4894 width as pointers. The assumption is true for Emacs porting targets
4895 now, but we want to make other targets possible.
4896 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4897 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4898 In the rest of the code, change types of integers that hold casted
4899 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4900 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4901 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4902 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4903 No need to cast type when ORing.
4904 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4905 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4906 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4907 assume EMACS_INT is the same width as char *.
4908 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4909 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4910 Remove no-longer-needed casts.
4911 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4912 (xg_tool_bar_help_callback, xg_make_tool_item):
4913 Use EMACS_INTPTR to hold an integer
4914 that will be cast to void *; this can avoid a GCC warning
4915 if EMACS_INT is not the same width as void *.
4916 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4917 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4918 (current_message_1, set_message_1):
4919 Use a local to convert to proper width without a cast.
4920 * xmenu.c (dialog_selection_callback): Likewise.
4921
ede49d71
PE
4922 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4923 Also, don't assume VALBITS / RAND_BITS is less than 5,
4924 and don't rely on undefined behavior when shifting a 1 left into
4925 the sign bit.
4926 * lisp.h (get_random): Change signature to match.
4927
2f30ecd0
PE
4928 * lread.c (hash_string): Use size_t, not int, for hash computation.
4929 Normally we prefer signed values; but hashing is special, because
4930 it's better to use unsigned division on hash table sizes so that
4931 the remainder is nonnegative. Also, size_t is the natural width
4932 for hashing into memory. The previous code used 'int', which doesn't
4933 retain enough info to hash well into very large tables.
4934 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4935
2a866e7b
PE
4936 * dbusbind.c: Don't possibly lose pointer info when converting.
4937 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4938 Use XPNTR rather than XHASH, so that the high-order bits of
4939 the pointer aren't lost when converting through void *.
4940
51639eac
PE
4941 * eval.c (Fautoload): Don't double-shift a pointer.
4942
92394119
PE
4943 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4944
dbdb9a7c
JB
49452011-05-06 Juanma Barranquero <lekktu@gmail.com>
4946
4947 * gnutls.c (DEF_GNUTLS_FN):
4948 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4949
db7a0b4f
AS
49502011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4951
4952 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4953 marker. (Bug#8610)
4954
f7ff1b0f 49552011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4956
4957 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4958 New version that can reserve upto 2GB of heap space.
4959
f7ff1b0f 49602011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4961
4962 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4963
639c109b
TZ
49642011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4965
4966 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4967 `gnutls_certificate_set_x509_key_file'.
4968
d2127135
JB
49692011-05-05 Juanma Barranquero <lekktu@gmail.com>
4970
4971 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4972 Update dependencies.
4973
e968f4f3
JB
49742011-05-04 Juanma Barranquero <lekktu@gmail.com>
4975
4976 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4977 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4978 Remove unused parameter `fildes'.
4979 * process.c (read_process_output, send_process): Don't pass it.
4980
84d358f0
JB
49812011-05-04 Juanma Barranquero <lekktu@gmail.com>
4982
4983 Fix previous change: the library cache is defined in w32.c.
4984 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4985 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4986
0898ca10
JB
49872011-05-04 Juanma Barranquero <lekktu@gmail.com>
4988
4989 Implement dynamic loading of GnuTLS on Windows.
4990
4991 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4992 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4993 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4994 Declare.
4995
4996 * gnutls.c (Qgnutls_dll): Define.
4997 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4998 (gnutls_*): Declare function pointers.
4999 (init_gnutls_functions): New function to initialize function pointers.
5000 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5001 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5002 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5003 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5004 (emacs_gnutls_write, emacs_gnutls_read)
5005 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5006 (Fgnutls_available_p): New function.
5007 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5008 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5009 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5010
5011 * image.c: Include w32.h.
5012 (Vimage_type_cache): Delete.
5013 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5014 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5015 (w32_delayed_load): Move to w32.c.
5016
5017 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5018
5019 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5020 (w32_delayed_load): Move from image.c. When loading a library, record
5021 its filename in the :loaded-from property of the library id.
5022 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5023 Initialize and staticpro them.
5024 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5025
5026 * process.c: Include lisp.h before w32.h, not after.
5027 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5028 instead of gnutls_record_check_pending.
5029
5030 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5031
ff4de4aa
TZ
50322011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5033
5034 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5035 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5036 as passed in.
5037
abe95abb
JD
50382011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5039
5040 * xterm.c (x_set_frame_alpha): Do not set property on anything
5041 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5042
e16e55d4
JB
50432011-05-02 Juanma Barranquero <lekktu@gmail.com>
5044
5045 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5046
bafcf6a5
JB
50472011-05-02 Juanma Barranquero <lekktu@gmail.com>
5048
5049 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5050 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5051 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5052 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5053 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5054 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5055 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5056 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5057 (Qgnutls_bootprop_callbacks_verify): Make static.
5058
e7a6747f
AS
50592011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5060
19ed11ba
AS
5061 * callproc.c: Indentation fixup.
5062
e7a6747f 5063 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5064 (wait_for_termination, interruptible_wait_for_termination):
5065 Move after wait_for_termination_1.
e7a6747f 5066
1ef14cb4
LMI
50672011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5068
5069 * sysdep.c (interruptible_wait_for_termination): New function
5070 which is like wait_for_termination, but allows keyboard
5071 interruptions.
5072
5073 * callproc.c (Fcall_process): Add (:file "file") as an option for
5074 the STDOUT buffer.
5075 (Fcall_process_region): Ditto.
5076
330d880c
EZ
50772011-04-30 Eli Zaretskii <eliz@gnu.org>
5078
8db90b73
EZ
5079 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5080 rather than `XVECTOR (FOO)->size'.
5081
330d880c
EZ
5082 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5083 inttypes.h, as a gnulib replacement is used if it not available in
5084 system headers.
5085
15cbd324
EZ
50862011-04-21 Eli Zaretskii <eliz@gnu.org>
5087
5088 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5089 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5090 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5091
5092 * coding.c (coding_alloc_by_realloc): Error out if destination
5093 will grow beyond MOST_POSITIVE_FIXNUM.
5094 (decode_coding_emacs_mule): Abort if there isn't enough place in
5095 charbuf for the composition carryover bytes. Reserve an extra
5096 space for up to 2 characters produced in a loop.
5097 (decode_coding_iso_2022): Abort if there isn't enough place in
5098 charbuf for the composition carryover bytes.
5099
51002011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5101
ae940cca
EZ
5102 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5103 aborting when %lld or %lll format is passed.
5104 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5105 %llo or %llx format is passed. (Bug#8545)
5106
03ab8921
EZ
5107 * window.c (window_scroll_line_based): Use a marker instead of
5108 simple variables to record original value of point. (Bug#7952)
5109
afda1437
EZ
5110 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5111 produced by %s or %c overflows available buffer space. (Bug#8545)
5112
f76dee0c
PE
51132011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5114
5115 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5116 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5117
fdc5744d
JB
51182011-04-28 Juanma Barranquero <lekktu@gmail.com>
5119
5120 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5121
638f053a
JB
51222011-04-28 Juanma Barranquero <lekktu@gmail.com>
5123
5124 * keyboard.c (Qdelayed_warnings_hook): Define.
5125 (command_loop_1): Run `delayed-warnings-hook'
5126 if Vdelayed_warnings_list is non-nil.
5127 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5128 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5129
d178f871
EZ
51302011-04-28 Eli Zaretskii <eliz@gnu.org>
5131
5132 * doprnt.c (doprnt): Don't return value smaller than the buffer
5133 size if the message was truncated. (Bug#8545).
5134
b124fd93
JB
51352011-04-28 Juanma Barranquero <lekktu@gmail.com>
5136
5137 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5138 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5139
e810457d
PE
51402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5141
5142 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5143
ea51cceb
JB
51442011-04-27 Juanma Barranquero <lekktu@gmail.com>
5145
5146 * makefile.w32-in: Update dependencies.
5147
94dcfacf
EZ
51482011-04-27 Eli Zaretskii <eliz@gnu.org>
5149
5150 Improve `doprnt' and its usage. (Bug#8545)
5151 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5152 `format_end'. Remove support for %l as a conversion specifier.
5153 Don't use xrealloc. Improve diagnostics when the %l size modifier
5154 is used. Update the commentary.
5155
5156 * eval.c (verror): Simplify calculation of size_t.
5157
5158 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5159 messages.
5160
f61f41d7
PE
51612011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5162
5163 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5164 change.
5165
96fb4434
PE
51662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5167
5168 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5169 This makes this file independent of the recent pseudovector change.
5170
671875da 51712011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5172
69e9b5a3
PE
5173 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5174
b5f869a7 5175 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5176 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5177 Remove unused local.
c8926152 5178 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5179
841a1577 5180 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5181 GCC 4.6.0 optimizes based on type-based alias analysis.
5182 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5183 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5184 != &v->size, and therefore "v->size = 1; b->size = 2; return
5185 v->size;" must therefore return 1. This assumption is incorrect
5186 for Emacs, since it type-puns struct Lisp_Vector * with many other
5187 types. To fix this problem, this patch adds a new type struct
f904488f 5188 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5189 and pseudovectors, and helps optimizing compilers not get fooled
5190 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5191 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5192 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5193 the size member.
eab3844f
PE
5194 (XSETPVECTYPE): Rewrite in terms of new macro.
5195 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5196 This is a bit clearer, and further avoids the possibility of
5197 undesirable aliasing.
5198 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5199 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5200 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5201 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5202 (ASIZE): Now uses header.size rather than size.
5203 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5204 to avoid the hassle of writing XVECTOR (foo)->header.size.
5205 (struct vectorlike_header): New type.
eab3844f
PE
5206 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5207 object, to help avoid aliasing.
5208 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5209 (SUBRP): Likewise, since Lisp_Subr is a special case.
5210 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5211 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5212 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5213 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5214 changed to be "header.size" and "header.next".
5215 * buffer.h (struct buffer): Likewise.
5216 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5217 * frame.h (struct frame): Likewise.
5218 * process.h (struct Lisp_Process): Likewise.
5219 * termhooks.h (struct terminal): Likewise.
5220 * window.c (struct save_window_data, struct saved_window): Likewise.
5221 * window.h (struct window): Likewise.
5222 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5223 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5224 * buffer.c (init_buffer_once): Likewise.
5225 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5226 special case.
5227 * process.c (Fformat_network_address): Use local var for size,
5228 for brevity.
5229
0df1eac5
PE
5230 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5231
847ab9d1 5232 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5233 * data.c (atof): Remove decl; no longer used or needed.
5234 (digit_to_number): Move to lread.c.
5235 (Fstring_to_number): Use new string_to_number function, to be
5236 consistent with how the Lisp reader treats infinities and NaNs.
5237 Do not assume that floating-point numbers represent EMACS_INT
5238 without losing information; this is not true on most 64-bit hosts.
5239 Avoid double-rounding errors, by insisting on integers when
5240 parsing non-base-10 numbers, as the documentation specifies.
5241 * lisp.h (string_to_number): New decl, replacing ...
5242 (isfloat_string): Remove.
bc0a5c13 5243 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5244 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5245 appears to have been a coding error. Similarly, do not accept
5246 strings like +-1e0 as floating point numbers. Do not report
5247 overflow for integer overflows unless the base is not 10 which
5248 means we have no simple and reliable way to continue.
5249 Break out the floating-point parsing into a new
5250 function string_to_number, so that Fstring_to_number parses
5251 floating point numbers consistently with the Lisp reader.
04f2d78b 5252 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5253 (E_CHAR, EXP_INT): Remove, replacing with ...
5254 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5255 (string_to_number): New function, replacing isfloat_string.
5256 This function checks for valid syntax and produces the resulting
5257 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5258 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5259 so that overflow for non-base-10 numbers is reported only when
5260 there's no portable and simple way to convert to floating point.
452f4150 5261
67769ffc
PE
5262 * textprop.c (set_text_properties_1): Rewrite for clarity,
5263 and to avoid GCC warning about integer overflow.
5264
c20db43f
PE
5265 * intervals.h (struct interval): Use EMACS_INT for members
5266 where EMACS_UINT might cause problems. See
5267 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5268 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5269 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5270 All uses changed.
37aa2f85
PE
5271 (offset_intervals): Tell GCC not to worry about length overflow
5272 when negating a negative length.
c20db43f 5273
2538aa2f
PE
5274 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5275 (overrun_check_free): Likewise.
5276
f2d3008d
PE
5277 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5278 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5279 word size.
5280
ec8df744
PE
5281 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5282 (gnutls_make_error): Rename local to avoid shadowing.
5283 (gnutls_emacs_global_deinit): ifdef out; not used.
5284 (Fgnutls_boot): Use const for pointer to readonly storage.
5285 Comment out unused local. Fix pointer signedness problems.
5286
640ee02d
PE
5287 * lread.c (openp): Don't stuff size_t into an 'int'.
5288 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5289 about possible signed overflow.
5290
6048fb2a
PE
5291 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5292 (GDK_KEY_g): Don't define if already defined.
5293 (xg_prepare_tooltip): Avoid pointer signedness problem.
5294 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5295
fa3c87e1
PE
5296 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5297 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5298
2172544b
PE
5299 * xfns.c (Fx_window_property): Simplify a bit,
5300 to make a bit faster and to avoid GCC 4.6.0 warning.
5301 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5302
9b821a21
PE
5303 * fns.c (internal_equal): Don't assume size_t fits in int.
5304
3c616cfa
PE
5305 * alloc.c (compact_small_strings): Tighten assertion a little.
5306
c2982e87
PE
5307 Replace pEd with more-general pI, and fix some printf arg casts.
5308 * lisp.h (pI): New macro, generalizing old pEd macro to other
5309 conversion specifiers. For example, use "...%"pI"d..." rather
5310 than "...%"pEd"...".
5311 (pEd): Remove. All uses replaced with similar uses of pI.
5312 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5313 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5314 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5315 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5316 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5317 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5318 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5319 64-bit hosts.
5320 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5321 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5322 * print.c (safe_debug_print, print_object): Likewise.
5323 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5324 to int.
6f04d126
PE
5325 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5326 avoiding the 0 flag, which is not portable.
c2982e87
PE
5327 * process.c (Fmake_network_process): Use pI to avoid cast.
5328 * region-cache.c (pp_cache): Likewise.
5329 * xdisp.c (decode_mode_spec): Likewise.
5330 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5331 behavior on 64-bit hosts with printf arg.
6f04d126 5332 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5333 (x_stop_queuing_selection_requests): Likewise.
5334 (x_get_window_property): Don't truncate byte count to an 'int'
5335 when tracing.
0b432f21 5336
5e073ec7
PE
5337 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5338 here, since it parses constructs like leading '-' and spaces,
5339 which are not wanted; and it overflows with large numbers.
5340 Instead, simply match F[0-9]+, which is what is wanted anyway.
5341
36372bf9
PE
5342 * alloc.c: Remove unportable assumptions about struct layout.
5343 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5344 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5345 (allocate_vectorlike, make_pure_vector): Use the new macros,
5346 plus offsetof, to remove unportable assumptions about struct layout.
5347 These assumptions hold on all porting targets that I know of, but
5348 they are not guaranteed, they're easy to remove, and removing them
5349 makes further changes easier.
5350
0b432f21
PE
5351 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5352 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5353 (string_overrun_cookie): Now const. Use initializers that
5354 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5355 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5356 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5357 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5358 multiple of sizeof (EMACS_INT); it need not be, if
5359 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5360 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5361
895009e1
JB
53622011-04-26 Juanma Barranquero <lekktu@gmail.com>
5363
5364 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5365
6a7a1b0b
TZ
53662011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5367
5368 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5369 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5370 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5371
841a1577 53722011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5373
5374 * lisp.h (Qdebug): List symbol.
895009e1 5375 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5376 * keyboard.c (debug-on-event): New variable.
5377 (handle_user_signal): Break into debugger when debug-on-event
5378 matches the current signal symbol.
5379
f2d3ba6f
DN
53802011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5381
5382 * alloc.c (check_sblock, check_string_bytes)
5383 (check_string_free_list): Convert to standard C.
5384
42ce4c63
TZ
53852011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5386
5387 * w32.c (emacs_gnutls_push): Fix typo.
5388
825cd63c
EZ
53892011-04-25 Eli Zaretskii <eliz@gnu.org>
5390
fb11d64d
EZ
5391 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5392 "cast to pointer from integer of different size".
5393
825cd63c
EZ
5394 Improve doprnt and its use in verror. (Bug#8545)
5395 * doprnt.c (doprnt): Document the set of format control sequences
5396 supported by the function. Use SAFE_ALLOCA instead of always
5397 using `alloca'.
5398
5399 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5400 is one byte too soon. Don't use xrealloc; instead xfree and
5401 xmalloc anew.
5402
e061a11b
TZ
54032011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5404
5405 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5406 callbacks stage.
5407
5408 * gnutls.c: Renamed global_initialized to
5409 gnutls_global_initialized. Added internals for the
5410 :verify-hostname-error, :verify-error, and :verify-flags
5411 parameters of `gnutls-boot' and documented those parameters in the
5412 docstring. Start callback support.
9173deec
JB
5413 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5414 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5415 on error. Return error code.
e061a11b
TZ
5416 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5417 (emacs_gnutls_read): Likewise.
5418 (Fgnutls_boot): Return handshake error code.
5419 (emacs_gnutls_handle_error): New function.
5420 (wsaerror_to_errno): Likewise.
5421
5422 * w32.h (emacs_gnutls_pull): Add prototype.
5423 (emacs_gnutls_push): Likewise.
5424
5425 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5426 (emacs_gnutls_push): Likewise.
5427
54282011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5429
5430 * process.c (wait_reading_process_output): Check if GnuTLS
5431 buffered some data internally if no FDs are set for TLS
5432 connections.
5433
5434 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5435 (LIBS): Link to USER_LIBS.
5436 ($(BLD)/gnutls.$(0)): New target.
5437
fa6996bc
EZ
54382011-04-24 Eli Zaretskii <eliz@gnu.org>
5439
eb35682e
EZ
5440 * xdisp.c (handle_single_display_spec): Rename the
5441 display_replaced_before_p argument into display_replaced_p, to
5442 make it consistent with the commentary. Fix typos in the
5443 commentary.
5444
e2ad650c
EZ
5445 * textprop.c (syms_of_textprop): Remove dead code.
5446 (copy_text_properties): Delete obsolete commentary about an
5447 interface that was deleted long ago. Fix typos in the description
5448 of arguments.
5449
1b2de274
EZ
5450 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5451 to changes in oldXMenu/XMenu.h from 2011-04-16.
5452 <menu_help_message, prev_menu_help_message>: Constify.
5453 (IT_menu_make_room): menu->help_text is now `const char **';
5454 adjust.
5455
5456 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5457 to changes in oldXMenu/XMenu.h from 2011-04-16.
5458 (struct XMenu): Declare `help_text' `const char **'.
5459
5460 * xfaces.c <Qunspecified>: Make extern again.
5461
5462 * syntax.c: Include sys/types.h before including regex.h, as
5463 required by Posix.
5464
762b15be
EZ
5465 * doc.c (get_doc_string): Improve the format passed to `error'.
5466
5467 * doprnt.c (doprnt): Improve commentary.
5468
5469 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5470
5471 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5472 them with etags.
5473
f1052e5d
EZ
5474 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5475 changes in globals.h immediately force recompilation.
762b15be
EZ
5476 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5477 $(CURDIR)/s/ms-w32.h.
5478 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5479
fa6996bc
EZ
5480 * character.c (Fchar_direction): Function deleted.
5481 (syms_of_character): Don't defsubr it.
5482 <char-direction-table>: Deleted.
5483
e6c3da20
EZ
54842011-04-23 Eli Zaretskii <eliz@gnu.org>
5485
5486 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5487 * doprnt.c: Include limits.h.
5488 (SIZE_MAX): New macro.
04f2d78b
CB
5489 (doprnt): Return a size_t value. 2nd arg is now size_t.
5490 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5491 Improve overflow protection. Support `l' modifier for integer
5492 conversions. Support %l conversion. Don't assume an EMACS_INT
5493 argument for integer conversions and for %c.
5494
5495 * lisp.h (doprnt): Restore prototype.
5496
5497 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5498 $(SRC)/character.h.
5499
5500 * Makefile.in (base_obj): Add back doprnt.o.
5501
5502 * deps.mk (doprnt.o): Add back prerequisites.
5503 (callint.o): Depend on character.h.
5504
5505 * eval.c (internal_lisp_condition_case): Include the handler
5506 representation in the error message.
5507 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5508 when breaking from the loop.
5509
5510 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5511
5512 * callint.c (Fcall_interactively): When displaying error message
5513 about invalid control letter, pass the character's codepoint, not
5514 a pointer to its multibyte form. Improve display of the character
5515 in octal and display also its hex code.
5516
5517 * character.c (char_string): Use %x to display the (unsigned)
5518 codepoint of an invalid character, to avoid displaying a bogus
5519 negative value.
5520
5521 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5522 `error', not SYMBOL_NAME itself.
5523
5524 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5525 character arguments to `error'.
5526
5527 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5528 to `error' in error message about FINAL_CHAR argument. Make sure
5529 FINAL_CHAR is a character, and use %c when it is passed as
5530 argument to `error'.
5531
4ffd0d6b 55322011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5533
5534 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5535
5536 * w32.c: Include <time.h>.
5537 (sys_localtime): New function.
5538
4ffd0d6b 55392011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5540
5541 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5542
4ffd0d6b 5543 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5544
4ffd0d6b 55452011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5546
4ffd0d6b
GM
5547 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5548 zombies (Bug#8467).
aac0c6e3 5549
04c56954
EZ
55502011-04-19 Eli Zaretskii <eliz@gnu.org>
5551
5552 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5553 gl_state.e_property when gl_state.object is Qt.
5554
5555 * insdel.c (make_gap_larger): Remove limitation of buffer size
5556 to <= INT_MAX.
5557
16a43933
CY
55582011-04-18 Chong Yidong <cyd@stupidchicken.com>
5559
5560 * xdisp.c (lookup_glyphless_char_display)
5561 (produce_glyphless_glyph): Handle cons cell entry in
5562 glyphless-char-display.
5563 (Vglyphless_char_display): Document it.
5564
5565 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5566 glyphless-char-display.
5567
4581706e
CY
55682011-04-17 Chong Yidong <cyd@stupidchicken.com>
5569
5570 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5571
5572 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5573
5574 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5575 definition for no-X builds.
5576
4887c6e2 55772011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5578
fd35b6f9
PE
5579 Static checks with GCC 4.6.0 and non-default toolkits.
5580
5c1ccb01
PE
5581 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5582
006c5daa
PE
5583 * process.c (keyboard_bit_set): Define only if SIGIO.
5584 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5585 (send_process): Repair possible setjmp clobbering.
5586
efc736d3
PE
5587 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5588
4e2fe2e6
PE
5589 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5590
f97334a2
PE
5591 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5592
4e75f29d
PE
5593 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5594 Define only if needed.
5595
90efadd1
PE
5596 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5597 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5598 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5599
3c647824
PE
5600 * dispextern.h (struct redisplay_interface): Rename param
5601 to avoid shadowing.
e264f262 5602 * termhooks.h (struct terminal): Likewise.
761383f4 5603 * xterm.c (xembed_send_message): Likewise.
3c647824 5604
b58c5c4a
PE
5605 * insdel.c (make_gap_smaller): Define only if
5606 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5607
cad59032
PE
5608 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5609 it.
5610
c339dc2e
PE
5611 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5612 so that we aren't warned about unused symbols.
5613
91a3e27b
PE
5614 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5615
399c71d3 5616 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5617
8ffc96f5
PE
5618 * xfns.c (x_real_positions): Mark locals as initialized.
5619
eef9bc79
PE
5620 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5621
098db9dd
PE
5622 * xterm.c: Fix problems found by static analysis with other toolkits.
5623 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5624 (x_dispatch_event): Declare static if USE_GTK, and
5625 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5626 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5627 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5628 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5629 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5630
eb18f6cc
PE
5631 * xmenu.c (menu_help_callback): Pointer type fixes.
5632 Use const pointers when pointing at readonly data. Avoid pointer
5633 signedness clashes.
5634 (FALSE): Remove unused macro.
5635 (update_frame_menubar): Remove unused decl.
5636
1fe72bf8
PE
5637 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5638
60d9e1db
PE
5639 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5640 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5641 (single_menu_item): Rename local to avoid shadowing.
5642
39261c26
PE
5643 * keyboard.c (make_lispy_event): Remove unused local var.
5644
018c5e19
PE
5645 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5646 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5647
63d2b86e
PE
5648 * bitmaps: Change bitmaps from unsigned char back to the X11
5649 compatible char. Avoid the old compiler warnings about
5650 out-of-range initializers by using, for example, '\xab' rather
5651 than 0xab.
5652
aefd87e1
PE
5653 * xgselect.c (xgselect_initialize): Check vs interface
5654 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5655
bf501fb9
PE
5656 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5657
e9829fdf
PE
5658 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5659 to read-only memory.
5660
1086c095
PE
5661 * fns.c (vector): Remove; this old hack is no longer needed.
5662
2baccd04 5663 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5664 Remove unused var.
dde42981 5665 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5666
72391843 5667 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5668
436c16df 5669 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5670 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5671 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5672
92bb796d 5673 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5674 (x_term_init): Remove local to avoid shadowing.
92bb796d 5675
764430a3 5676 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5677
5678 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5679 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5680
d1dfb56c
EZ
56812011-04-16 Eli Zaretskii <eliz@gnu.org>
5682
c4354cb4
EZ
5683 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5684
d1dfb56c
EZ
5685 Fix regex.c, syntax.c and friends for buffers > 2GB.
5686 * syntax.h (struct gl_state_s): Declare character position members
5687 EMACS_INT.
5688
5689 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5690
04f2d78b
CB
5691 * textprop.c (verify_interval_modification, interval_of):
5692 Declare arguments EMACS_INT.
d1dfb56c
EZ
5693
5694 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5695 EMACS_INT.
5696
5697 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5698
5699 * indent.c (Fvertical_motion): Local variable it_start is now
5700 EMACS_INT.
5701
5702 * regex.c (re_match, re_match_2, re_match_2_internal)
5703 (bcmp_translate, regcomp, regexec, print_double_string)
5704 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5705 (re_compile_pattern, re_exec): Declare arguments and local
5706 variables `size_t' and `ssize_t' and return values `regoff_t', as
5707 appropriate.
5708 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5709 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5710 <compile_stack_type>: `size' and `avail' are now `size_t'.
5711
5712 * regex.h <regoff_t>: Use ssize_t, not int.
5713 (re_search, re_search_2, re_match, re_match_2): Arguments that
5714 specify buffer/string position and length are now ssize_t and
5715 size_t. Return type is regoff_t.
5716
613052cd
BK
57172011-04-16 Ben Key <bkey76@gmail.com>
5718
5719 * nsfont.m: Fixed bugs in ns_get_family and
5720 ns_descriptor_to_entity that were caused by using free to
5721 deallocate memory blocks that were allocated by xmalloc (via
5722 xstrdup). This caused Emacs to crash when compiled with
5723 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5724 --enable-checking=xmallocoverrun). xfree is now used to
5725 deallocate these memory blocks.
5726
4170f62f 57272011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5728
71b41406
PE
5729 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5730
9587a89d
PE
5731 emacs_write: Accept and return EMACS_INT for sizes.
5732 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5733 et seq.
5734 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5735 Accept and return EMACS_INT.
5736 (emacs_gnutls_write): Return the number of bytes written on
5737 partial writes.
5738 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5739 (emacs_read, emacs_write): Remove check for negative size, as the
5740 Emacs source code has been audited now.
9587a89d
PE
5741 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5742 (emacs_read, emacs_write): Use it.
273a5f82
PE
5743 * process.c (send_process): Adjust to the new signatures of
5744 emacs_write and emacs_gnutls_write. Do not attempt to store
5745 a byte offset into an 'int'; it might overflow.
9587a89d 5746 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5747
3e047f51
PE
5748 * sound.c: Don't assume sizes fit in 'int'.
5749 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5750 Return EMACS_INT, not int.
3e047f51 5751 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5752 Accept EMACS_INT, not int.
5753 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5754 record read return values.
5755
cc39a9db
BK
57562011-04-15 Ben Key <bkey76@gmail.com>
5757
c9d0ec6d
JB
5758 * keyboard.c (Qundefined): Don't declare static since it is used
5759 in nsfns.m.
5760 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5761 static since they are used in nsfont.m.
cc39a9db 5762
6c60eb9f
SM
57632011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5764
5765 * process.c (Qprocessp): Don't declare static.
5766 * lisp.h (Qprocessp): Declare again.
5767
7990b61a
JB
57682011-04-15 Juanma Barranquero <lekktu@gmail.com>
5769
5770 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5771
5d4cb038
PE
57722011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5773
8bd7b830 5774 Improve C-level modularity by making more things 'static'.
cd64ea1d 5775
e3b27b31
PE
5776 Don't publish debugger-only interfaces to other modules.
5777 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5778 (verify_bytepos, count_markers): Move decls to the only modules
5779 that need them.
5780 * region-cache.h (pp_cache): Likewise.
5781 * window.h (check_all_windows): Likewise.
5782 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5783
5d4cb038
PE
5784 * sysdep.c (croak): Now static, if
5785 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5786 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5787
5788 * alloc.c (refill_memory_reserve): Now static if
5789 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5790 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5791
e87b6180
PE
5792 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5793 Define only if USE_LUCID.
5794
ac64929e
PE
5795 * xrdb.c (x_customization_string, x_rm_string): Now static.
5796
6f37259d
PE
5797 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5798 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5799
1683e3ab
PE
5800 * xdisp.c (draw_row_with_mouse_face): Now static.
5801 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5802
de9c2632
PE
5803 * window.h (check_all_windows): Mark externally visible.
5804
2b96acb7
PE
5805 * window.c (window_deletion_count): Now static.
5806
5807 * undo.c: Make symbols static if they're not exported.
5808 (last_undo_buffer, last_boundary_position, pending_boundary):
5809 Now static.
5810
50436f33
PE
5811 * textprop.c (interval_insert_behind_hooks): Now static.
5812 (interval_insert_in_front_hooks): Likewise.
5813
64520e5c
PE
5814 * term.c: Make symbols static if they're not exported.
5815 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5816 (max_frame_lines, tty_set_terminal_modes):
5817 (tty_reset_terminal_modes, tty_turn_off_highlight):
5818 (get_tty_terminal): Now static.
5819 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5820 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5821 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5822 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5823 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5824
1fa53021
PE
5825 * sysdep.c: Make symbols static if they're not exported.
5826 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5827 Now static.
5828 (sigprocmask_set, full_mask): Remove; unused.
5829 (wait_debugging): Mark as visible.
5830 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5831 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5832
d4b43b22
PE
5833 * syntax.c (syntax_temp): Define only if !__GNUC__.
5834
b7c513d0
PE
5835 * sound.c (current_sound_device, current_sound): Now static.
5836
989b29ad
PE
5837 * search.c (searchbufs, searchbuf_head): Now static.
5838
13a55a78
PE
5839 * scroll.c (scroll_cost): Remove; unused.
5840 * dispextern.h (scroll_cost): Remove decl.
5841
de68a1fc
PE
5842 * region-cache.h (pp_cache): Mark as externally visible.
5843
40ccffa6
PE
5844 * process.c: Make symbols static if they're not exported.
5845 (process_tick, update_tick, create_process, chan_process):
5846 (Vprocess_alist, proc_buffered_char, datagram_access):
5847 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5848 (deactivate_process): Mark defn as static, as well as decl.
5849 * lisp.h (create_process): Remove decl.
5850 * process.h (chan_process, Vprocess_alist): Remove decls.
5851
ad64fc97
PE
5852 * print.c: Make symbols static if they're not exported.
5853 (print_depth, new_backquote_output, being_printed, print_buffer):
5854 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5855 (print_interval, print_number_index, initial_stderr_stream):
5856 Now static.
5857 * lisp.h (Fprinc): Remove decl.
5858 (debug_output_compilation_hack): Mark as externally visible.
5859
adddb265
PE
5860 * sysdep.c (croak): Move decl from here to syssignal.h.
5861 * syssignal.h (croak): Put it here, so the API can be checked when
5862 'croak' is called from dissociate_if_controlling_tty.
5863
1717ede2
PE
5864 * minibuf.c: Make symbols static if they're not exported.
5865 (minibuf_save_list, choose_minibuf_frame): Now static.
5866 * lisp.h (choose_minibuf_frame): Remove decl.
5867
fa5fb2bc
PE
5868 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5869
1e3890d1
PE
5870 * lread.c: Make symbols static if they're not exported.
5871 (read_objects, initial_obarray, oblookup_last_bucket_number):
5872 Now static.
5873 (make_symbol): Remove; unused.
5874 * lisp.h (initial_obarray, make_symbol): Remove decls.
5875
8a1414fa
PE
5876 * keyboard.c: Make symbols static if they're not exported.
5877 (single_kboard, recent_keys_index, total_keys, recent_keys):
5878 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5879 (this_single_command_key_start, echoing, last_auto_save):
5880 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5881 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5882 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5883 (Vlispy_mouse_stem, double_click_count):
5884 Now static.
5885 (force_auto_save_soon): Define only if SIGDANGER.
5886 (ignore_mouse_drag_p): Now static if
5887 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5888 (print_help): Remove; unused.
5889 (stop_character, last_timer_event): Mark as externally visible.
5890 * keyboard.h (ignore_mouse_drag_p): Declare only if
5891 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5892 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5893 * lisp.h (echoing): Remove decl.
5894 (force_auto_save_soon): Declare only if SIGDANGER.
5895 * xdisp.c (redisplay_window): Simplify code, to make it more
5896 obvious that ignore_mouse_drag_p is not accessed if !defined
5897 USE_GTK && !defined HAVE_NS.
5898
93ea6e8f
PE
5899 * intervals.c: Make symbols static if they're not exported.
5900 (merge_properties_sticky, merge_interval_right, delete_interval):
5901 Now static.
5902 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5903
77382fcc
PE
5904 * insdel.c: Make symbols static if they're not exported.
5905 However, leave prepare_to_modify_buffer alone. It's never
5906 called from outside this function, but that appears to be a bug.
5907 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5908 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5909 (adjust_after_replace_noundo): Remove; unused.
5910 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5911 (signal_before_change): Remove decls.
77382fcc 5912
9306c32e
PE
5913 * indent.c (val_compute_motion, val_vmotion): Now static.
5914
cd44d2eb
PE
5915 * image.c: Make symbols static if they're not exported.
5916 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5917 if USE_GTK.
5918 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5919 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5920
ad9a7a06
PE
5921 * fringe.c (standard_bitmaps): Now static.
5922 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5923
81626931
PE
5924 * frame.c: Make symbols static if they're not exported.
5925 (x_report_frame_params, make_terminal_frame): Now static.
5926 (get_frame_param): Now static, unless HAVE_NS.
5927 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5928 (x_get_resource_string): Remove; not used.
5929 * frame.h (make_terminal_frame, x_report_frame_params):
5930 (x_get_resource_string); Remove decls.
5931 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5932 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5933
239f9db9
PE
5934 * font.c, fontset.c: Make symbols static if they're not exported.
5935 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5936 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5937 * font.c (font_close_object): Now static.
5938 * font.h (font_close_object): Remove.
5939 * fontset.c (FONTSET_OBJLIST): Remove.
5940 (free_realized_fontset) #if-0 the body, which does nothing.
5941 (face_suitable_for_char_p): #if-0, as it's never called.
5942 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5943 * xfaces.c (face_at_string_position):
5944 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5945 since 0 is always ASCII.
5946
dfcf3579
PE
5947 * fns.c (weak_hash_tables): Now static.
5948
5045092b
PE
5949 * fileio.c: Make symbols static if they're not exported.
5950 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5951 (Vwrite_region_annotation_buffers): Now static.
5952
57a96f5c
PE
5953 * eval.c: Make symbols static if they're not exported.
5954 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5955 * lisp.h (backtrace_list): Remove decl.
5956
35f08c38
PE
5957 * emacs.c: Make symbols static if they're not exported.
5958 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5959 (fatal_error_code, fatal_error_signal_hook, standard_args):
5960 Now static.
5961 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5962 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5963 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5964 * lisp.h (fatal_error_signal_hook): Remove decl.
5965 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5966
f44bd759
PE
5967 * editfns.c: Move a (normally-unused) function to its only use.
5968 * editfns.c, lisp.h (get_operating_system_release): Remove.
5969 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5970 worth the hassle of breaking this out.
5971
b532497d
PE
5972 * xterm.c: Make symbols static if they're not exported.
5973 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5974 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5975 (x_destroy_window, x_delete_display):
5976 Now static.
5977 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5978 (x_mouse_leave): Remove; unused.
5979 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5980 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5981 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5982 Remove decls.
5983 (x_mouse_leave): Declare only if WINDOWSNT.
5984 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5985 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5986 USE_X_TOOLKIT.
5987
1675728f
PE
5988 * ftxfont.c: Make symbols static if they're not exported.
5989 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5990 HAVE_FREETYPE.
5991 * font.h (ftxfont_driver): Likewise.
5992
e4cebfca
PE
5993 * xfns.c: Make symbols static if they're not exported.
5994 (x_last_font_name, x_display_info_for_name):
5995 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5996 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5997 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5998 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5999 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6000 (last_show_tip_args): Now static.
6001 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6002 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6003 (x_screen_planes): Remove; unused.
6004 * dispextern.h (x_screen_planes): Remove decl.
6005
5bf46f05
PE
6006 * dispnew.c: Make symbols static if they're not exported.
6007 * dispextern.h (redraw_garbaged_frames, scrolling):
6008 (increment_row_positions): Remove.
6009 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6010 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6011 Now static.
6012 (redraw_garbaged_frames): Remove; unused.
6013
435f4c28
PE
6014 * xfaces.c: Make symbols static if they're not exported.
6015 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6016 Remove decls.
6017 * xterm.h (defined_color): Remove decls.
6018 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6019 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6020 (menu_face_changed_default, defined_color, free_realized_face):
6021 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6022 (ascii_face_of_lisp_face): Remove; unused.
6023
8524aef3
PE
6024 * xdisp.c: Make symbols static if they're not exported.
6025 * dispextern.h (scratch_glyph_row, window_box_edges):
6026 (glyph_to_pixel_coords, set_cursor_from_row):
6027 (get_next_display_element, set_iterator_to_next):
6028 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6029 (show_mouse_face): Remove decls
6030 * frame.h (message_buf_print): Likewise.
6031 * lisp.h (pop_message, set_message, check_point_in_composition):
6032 Likewise.
6033 * xterm.h (set_vertical_scroll_bar): Likewise.
6034 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6035 (message_buf_print, scratch_glyph_row, displayed_buffer):
6036 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6037 (get_next_display_element, show_mouse_face, window_box_edges):
6038 (frame_to_window_pixel_xy, check_point_in_composition):
6039 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6040 (glyph_to_pixel_coords): Remove; unused.
6041
16390cd2
PE
6042 * dired.c (file_name_completion): Now static.
6043
6044 * dbusbind.c (xd_in_read_queued_messages): Now static.
6045
a25f4dfa
PE
6046 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6047 * data.c (circular_list_error): Remove.
6048
14a9c8df
PE
6049 * commands.h (last_point_position, last_point_position_buffer):
6050 (last_point_position_window): Remove decls.
6051 * keyboard.c: Make these variables static.
6052
04f2d78b
CB
6053 * coding.h (coding, code_convert_region, encode_coding_gap):
6054 Remove decls.
74ab6df5
PE
6055 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6056 (iso_code_class, detect_coding, code_convert_region): Now static.
6057 (encode_coding_gap): Remove; unused.
6058
38dfbee1
PE
6059 * chartab.c (chartab_chars, chartab_bits): Now static.
6060
a2cb4e63
PE
6061 * charset.h (charset_iso_8859_1): Remove decl.
6062 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6063 Now static.
6064
127198fd
PE
6065 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6066 * ccl.c (Vccl_program_table): Now static.
6067 (check_ccl_update): Remove; unused.
6068
d85b608f
PE
6069 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6070 * category.h: ... from here.
6071 * category.c (check_category_table, set_category_set): Now static.
6072
31cd66f3
PE
6073 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6074 * lisp.h: Remove these decls.
6075
c358e587
PE
6076 * buffer.c (buffer_count): Remove unused var.
6077
e78aecca
PE
6078 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6079 so that it's not optimized away.
6080 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6081 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6082 exported only to the debugger.
6083
e192d7d3 6084 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6085 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6086
92470028
PE
6087 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6088 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6089 was inaccessible from Lisp.
6090 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6091 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6092
244ed907
PE
6093 alloc.c: Import and export fewer symbols, and remove unused items.
6094 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6095 is defined.
6096 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6097 it's not optimized away by whole-program optimization.
6098 (message_enable_multibyte, free_misc): Remove.
6099 (catchlist, handlerlist, mark_backtrace):
6100 Declare only if BYTE_MARK_STACK.
6101 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6102 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6103 (message_enable_multibyte): Remove decl.
6104 (free_misc, interval_free_list, float_block, float_block_index):
6105 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6106 (cons_free_list, last_marked_index):
6107 Now static.
6108 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6109 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6110 (mark_backtrace): Define only if BYTE_MARK_STACK.
6111 * xdisp.c (message_enable_multibyte): Now static.
6112
61c2b50e 6113 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6114 This makes it easier for human readers (and static analyzers)
6115 to see whether these variables are used from other modules.
6116 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6117 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6118 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6119 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6120 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6121 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6122 * xmenu.c, xselect.c:
6123 Declare Q* vars static if they are not used in other modules.
6124 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6125 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6126 Remove decls of unexported vars.
6127 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6128
95c82688
PE
6129 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6130
16a97296
PE
6131 Make Emacs functions such as Fatom 'static' by default.
6132 This makes it easier for human readers (and static analyzers)
6133 to see whether these functions can be called from other modules.
6134 DEFUN now defines a static function. To make the function external
6135 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6136 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6137 (Finit_image_library):
16a97296
PE
6138 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6139 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6140 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6141 Remove decls, since these functions are now static.
6142 (Funintern, Fget_internal_run_time): New decls, since these functions
6143 were already external.
95c82688 6144
16a97296
PE
6145 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6146 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6147 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6148 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6149 * keyboard.c, keymap.c, lread.c:
6150 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6151 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6152 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6153 Mark functions with DEFUE instead of DEFUN,
6154 if they are used in other modules.
6155 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6156 decls for now-static functions.
6157 * buffer.h (Fdelete_overlay): Remove decl.
6158 * callproc.c (Fgetenv_internal): Mark as internal.
6159 * composite.c (Fremove_list_of_text_properties): Remove decl.
6160 (Fcomposition_get_gstring): New forward static decl.
6161 * composite.h (Fcomposite_get_gstring): Remove decl.
6162 * dired.c (Ffile_attributes): New forward static decl.
6163 * doc.c (Fdocumntation_property): New forward static decl.
6164 * eval.c (Ffetch_bytecode): New forward static decl.
6165 (Funintern): Remove extern decl; now in .h file where it belongs.
6166 * fileio.c (Fmake_symbolic_link): New forward static decl.
6167 * image.c (Finit_image_library): New forward static decl.
6168 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6169 * intervals.h (Fprevious_property_change):
6170 (Fremove_list_of_text_properties): Remove decls.
6171 * keyboard.c (Fthis_command_keys): Remove decl.
6172 (Fcommand_execute): New forward static decl.
6173 * keymap.c (Flookup_key): New forward static decl.
6174 (Fcopy_keymap): Now static.
6175 * keymap.h (Flookup_key): Remove decl.
6176 * process.c (Fget_process): New forward static decl.
6177 (Fprocess_datagram_address): Mark as internal.
6178 * syntax.c (Fsyntax_table_p): New forward static decl.
6179 (skip_chars): Remove duplicate decl.
6180 * textprop.c (Fprevious_property_change): New forward static decl.
6181 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6182 Now internal.
6183 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6184 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6185
785bbd42
PE
6186 * editfns.c (Fformat): Remove unreachable code.
6187
8b913b57
AS
61882011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6189
6190 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6191 change. (Bug#8496)
6192
a6744a35
EZ
61932011-04-13 Eli Zaretskii <eliz@gnu.org>
6194
6195 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6196 when at ZV. (Bug#8487)
6197
e7974947
AS
61982011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6199
baad03f0
AS
6200 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6201 (Bug#8437)
6202 * keyboard.c (parse_tool_bar_item): Likewise.
6203 * sound.c (sound_cleanup, alsa_close): Likewise.
6204 * termcap.c (tgetent): Likewise.
6205 * xfns.c (x_default_font_parameter): Likewise.
6206 * xsettings.c (read_and_apply_settings): Likewise.
6207
e7974947
AS
6208 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6209 (overrun_check_free): Protoize.
6210
28272684
PE
62112011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6212
6213 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6214 since callers should never pass a negative size.
6215 Change the signature to match that of plain 'read' and 'write'; see
6216 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6217 * lisp.h: Update prototypes of emacs_write and emacs_read.
6218
11997c76
EZ
62192011-04-11 Eli Zaretskii <eliz@gnu.org>
6220
6221 * xdisp.c (redisplay_window): Don't try to determine the character
6222 position of the scroll margin if the window start point w->startp
e896f03c 6223 is outside the buffer's accessible region. (Bug#8468)
11997c76 6224
8a2cbd72
EZ
62252011-04-10 Eli Zaretskii <eliz@gnu.org>
6226
6227 Fix write-region and its subroutines for buffers > 2GB.
6228 * fileio.c (a_write, e_write): Modify declaration of arguments and
6229 local variables to support buffers larger than 2GB.
6230 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6231
6232 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6233 argument, local variables, and return value.
6234
6235 * lisp.h: Update prototypes of emacs_write and emacs_read.
6236
6237 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6238
4073e537 62392011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6240
1ebfdcb6
PE
6241 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6242
b2ded58d
PE
6243 Fix more problems found by GCC 4.6.0's static checks.
6244
7d66342c
PE
6245 * xdisp.c (vmessage): Use a better test for character truncation.
6246
bbf47d44
PE
6247 * charset.c (load_charset_map): <, not <=, for optimization,
6248 and to avoid potential problems with integer overflow.
9248994d 6249 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6250 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6251 * editfns.c (Fformat): Likewise.
1e69125e 6252 * syntax.c (skip_chars): Likewise.
3befa583 6253
e3019616
PE
6254 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6255 This also lets GCC 4.6.0 generate slightly better loop code.
6256
becfa255
PE
6257 * callint.c (Fcall_interactively): <, not <=, for optimization.
6258 (Fcall_interactively): Count the number of arguments produced,
6259 not the number of arguments given. This is simpler and lets GCC
6260 4.6.0 generate slightly better code.
6261
dae0cd48
PE
6262 * ftfont.c: Distingish more carefully between FcChar8 and char.
6263 The previous code passed unsigned char * to a functions like
6264 strlen and xstrcasecmp that expect char *, which does not
6265 conform to the C standard.
6266 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6267 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6268 char * when the C standard requires it.
6269
76032d70
PE
6270 * keyboard.c (read_char): Remove unused var.
6271
eb3f1cc8
PE
6272 * eval.c: Port to Windows vsnprintf (Bug#8435).
6273 Include <limits.h>.
6274 (SIZE_MAX): Define if the headers do not.
6275 (verror): Do not give up if vsnprintf returns a negative count.
6276 Instead, grow the buffer. This ports to Windows vsnprintf, which
6277 does not conform to C99. Problem reported by Eli Zaretskii.
6278 Also, simplify the allocation scheme, by avoiding the need for
6279 calling realloc, and removing the ALLOCATED variable.
6280
70476b54
PE
6281 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6282
12020a9e
PE
6283 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6284 But keep the doprint source code for now, as we might revamp it
6285 and use it again (Bug#8435).
ea6c7ae6
PE
6286 * lisp.h (doprnt): Remove.
6287 * Makefile.in (base_obj): Remove doprnt.o.
6288 * deps.mk (doprnt.o): Remove.
6289
5fdb398c
PE
6290 error: Print 32- and 64-bit integers portably (Bug#8435).
6291 Without this change, on typical 64-bit hosts error ("...%d...", N)
6292 was used to print both 32- and 64-bit integers N, which relied on
6293 undefined behavior.
6294 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6295 New macro.
6296 * lisp.h (error, verror): Mark as printf-like functions.
6297 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6298 Report overflow in size calculations when allocating printf buffer.
6299 Do not truncate output string at its first null byte.
6300 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6301 Truncate the output at a character boundary, since vsnprintf does not
6302 do that.
6303 * charset.c (check_iso_charset_parameter): Convert internal
6304 character to string before calling 'error', since %c now has the
6305 printf meaning.
6306 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6307 overflow when computing char to be passed to 'error'. Do not
6308 pass Lisp_Object to 'error'; pass the integer instead.
6309 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6310 formatted with plain %d.
6311
b189fa66
PE
6312 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6313
bff87ef0
PE
6314 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6315
7e2cac20
PE
6316 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6317
ce4d90b5
PE
6318 * xterm.c (x_catch_errors): Remove duplicate declaration.
6319
266c9547
PE
6320 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6321
79c49ad2
PE
6322 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6323
368f4090
JM
63242011-04-10 Jim Meyering <meyering@redhat.com>
6325
6326 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6327 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6328 return ssize_t not "int", and use size_t as the buffer length.
6329 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6330 * gnutls.h: Update declarations.
6331 * process.c (read_process_output): Use ssize_t, to match.
6332 (send_process): Likewise.
6333
a32d4040
CY
63342011-04-09 Chong Yidong <cyd@stupidchicken.com>
6335
6336 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6337
8546720e 63382011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6339
04f2d78b
CB
6340 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6341 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6342
8546720e
GM
6343 * xterm.c (handle_one_xevent):
6344 * xmenu.c (create_and_show_popup_menu):
6345 * xselect.c (x_decline_selection_request)
6346 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6347
0a2f5c1a 63482011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6349
6350 Fix some uses of `int' instead of EMACS_INT.
6351 * search.c (string_match_1, fast_string_match)
6352 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6353 (scan_buffer, find_next_newline_no_quit)
6354 (find_before_next_newline, search_command, Freplace_match)
6355 (Fmatch_data): Make some `int' variables be EMACS_INT.
6356
6357 * xdisp.c (display_count_lines): 3rd argument and return value now
6358 EMACS_INT. All callers changed.
6359 (pint2hrstr): Last argument is now EMACS_INT.
6360
6361 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6362 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6363 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6364 (decode_coding_utf_16, decode_coding_emacs_mule)
6365 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6366 (decode_coding_ccl, decode_coding_charset)
6367 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6368 (decode_coding_iso_2022, decode_coding_emacs_mule)
6369 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6370 <char_offset, last_offset>: Declare EMACS_INT.
6371 (encode_coding_utf_8, encode_coding_utf_16)
6372 (encode_coding_emacs_mule, encode_invocation_designation)
6373 (encode_designation_at_bol, encode_coding_iso_2022)
6374 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6375 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6376 Declare EMACS_INT.
6377 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6378 (encode_invocation_designation): Last argument P_NCHARS is now
6379 EMACS_INT.
6380 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6381 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6382
6383 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6384 All users changed.
6385
6386 * ccl.c (Fccl_execute_on_string): Declare some variables
6387 EMACS_INT.
6388
8546720e 63892011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6390
6391 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6392
4e19a977
CS
63932011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6394
6395 * process.c (Fformat_network_address): Doc fix.
6396
87302331
R
63972011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6398
6399 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6400
cbb59342
CY
64012011-04-08 Chong Yidong <cyd@stupidchicken.com>
6402
6403 * keyboard.c (read_char): Call Lisp function help-form-show,
6404 instead of using internal_with_output_to_temp_buffer.
6405 (Qhelp_form_show): New var.
e0d38eeb 6406 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6407
6408 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6409
6410 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6411
e67a13ab
CY
64122011-04-06 Chong Yidong <cyd@stupidchicken.com>
6413
04f2d78b
CB
6414 * process.c (Flist_processes): Remove to Lisp.
6415 (list_processes_1): Delete.
e67a13ab 6416
973f782d
EZ
64172011-04-06 Eli Zaretskii <eliz@gnu.org>
6418
7c106b1e
EZ
6419 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6420
973f782d
EZ
6421 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6422
41cf7d1a 64232011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6424
ca23cc88
PE
6425 Fix more problems found by GCC 4.6.0's static checks.
6426
f390e2d5
PE
6427 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6428
42eea0d0
PE
6429 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6430
b69769da 6431 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6432
f9541e84
PE
6433 * xdisp.c (vmessage): Mark as a printf-like function.
6434
13841b55
PE
6435 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6436
c136c10f
PE
6437 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6438
5e2d4a30
PE
6439 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6440 printf-like functions.
6441 (tiff_load): Add casts to remove these marks before passing them
6442 to system-supplied API.
6443
583f48b9
PE
6444 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6445
b25d760e
PE
6446 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6447 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6448 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6449 directly, rather than having caller test rule sign. This avoids
6450 some unnecessary tests.
6451 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6452 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6453 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6454
bc7b6697 6455 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6456 (xfont_open): Avoid unnecessary tests.
bc7b6697 6457
27ccc379
PE
6458 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6459
dcd5c89a
PE
6460 * composite.h, composite.c (composition_gstring_put_cache):
6461 Use EMACS_INT, not int, for length.
6462
b13a45c6
PE
6463 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6464 breaking out part of COMPOSITION_DECODE_RULE.
6465 (COMPOSITION_DECODE_RULE): Use it.
6466 * composite.c (get_composition_id): Remove unused local vars,
6467 by using the new macro.
6468
1e792e4d
PE
6469 * textprop.c (set_text_properties_1): Change while to do-while,
6470 since the condition is always true at first.
6471
dc6c6455 6472 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6473 (interval_deletion_adjustment): Return unsigned value.
6474 All uses changed.
dc6c6455 6475
aba7731a
PE
6476 * process.c (list_processes_1, create_pty, read_process_output):
6477 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6478 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6479 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6480 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6481 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6482
fdfc4bf3
PE
6483 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6484
fca8fe46 6485 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6486 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6487
06a0259a 6488 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6489 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6490 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6491
e7b9e80f
PE
6492 * print.c (print_error_message): Avoid int overflow.
6493
56201685
PE
6494 * font.c (font_list_entities): Redo for clarity,
6495 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6496
78834453 6497 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6498 (font_score): Avoid potential overflow in diff calculation.
78834453 6499
0bc0b309 6500 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6501 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6502
e610eaca
PE
6503 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6504
b895abce
PE
6505 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6506 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6507 can always succeed if overflow has undefined behavior.
6508
1f1d9321 6509 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6510 (wordify): Omit three unnecessary tests.
1f1d9321 6511
c59478bc
PE
6512 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6513 All callers changed. This avoids the need for an unused var.
6514
79b73827
PE
6515 * casefiddle.c (casify_region): Remove var that is set but not used.
6516
a4db5dfe
PE
6517 * dired.c (file_name_completion): Remove var that is set but not used.
6518
43aae36e
PE
6519 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6520
2a47c44d 6521 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6522 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6523
a37c69bf
PE
6524 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6525 Check for integer overflow on size calculations.
6526
328ab8e7
PE
6527 * buffer.c (Fprevious_overlay_change): Remove var that is set
6528 but not used.
6529
e5a2a5cb
PE
6530 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6531 Remove vars that are set but not used.
8d84a6eb 6532 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6533 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6534
a60e5f68
PE
6535 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6536
f661cb61 6537 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6538 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6539
f0397f5a
PE
6540 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6541 that are set but not used.
6542
8664db06 6543 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6544 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6545
6abdaa4a
PE
6546 * xselect.c (x_get_local_selection, x_handle_property_notify):
6547 Remove vars that are set but not used.
6548
0ce7538d 6549 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6550 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6551
9ae848fc
PE
6552 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6553 Remove var that is set but not used.
0b918413
PE
6554 (scroll_bar_windows_size): Now size_t, not int.
6555 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6556 Check for overflow.
9ae848fc 6557
a5a62657
PE
6558 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6559 (map_tty_color) [!defined MSDOS]: Likewise.
6560
5c5cdd39
PE
6561 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6562
66ebf983
PE
6563 * coding.c: Remove vars that are set but not used.
6564 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6565 All callers changed.
6566 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6567 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6568 (decode_coding_charset): Remove vars that are set but not used.
6569
1be4d761
PE
6570 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6571 that is set but not used.
6572
47553fa8
PE
6573 * print.c (print_object): Remove var that is set but not used.
6574
1f7196bf 6575 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6576 The gnulib version avoids calling malloc in the usual case,
6577 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6578 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6579 * filelock.c (current_lock_owner): Likewise.
6580 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6581 * sysdep.c: Include allocator.h, careadlinkat.h.
6582 (emacs_no_realloc_allocator): New static constant.
6583 (emacs_readlink): New function.
fdb61804
PE
6584 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6585 ../lib/careadlinkat.h.
d1fdcab7 6586
f84c17c7
SM
65872011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6588
6589 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6590 first non-nil return value).
6591
ef3862ad
JD
65922011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6593
6594 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6595 if not defined (Bug#8403).
6596
376a7006
JB
65972011-04-02 Juanma Barranquero <lekktu@gmail.com>
6598
6599 * xdisp.c (display_count_lines): Remove parameter `start',
6600 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6601 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6602 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6603 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6604 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6605 and thereabouts. All callers changed.
6606 (get_per_char_metric): Remove parameter `f', unused since
6607 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6608
6ca3801d
JM
66092011-04-02 Jim Meyering <meyering@redhat.com>
6610
6611 do not dereference NULL upon failed strdup
6612 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6613 (ns_get_family): Likewise.
6614
d8e2b5ba
JB
66152011-04-02 Juanma Barranquero <lekktu@gmail.com>
6616
6617 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6618
8c74fcbd
JD
66192011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6620
6621 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6622 later (Bug#8403).
6623
7200d79c
SM
66242011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6625
03408648 6626 Add lexical binding.
7200d79c 6627
03408648
SM
6628 * window.c (Ftemp_output_buffer_show): New fun.
6629 (Fsave_window_excursion):
6630 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6631
6632 * lread.c (lisp_file_lexically_bound_p): New function.
6633 (Fload): Bind Qlexical_binding.
6634 (readevalloop): Remove `evalfun' arg.
6635 Bind Qinternal_interpreter_environment.
6636 (Feval_buffer): Bind Qlexical_binding.
6637 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6638 Mark as dynamic.
6639 (syms_of_lread): Declare `lexical-binding'.
6640
6641 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6642
6643 * keyboard.c (eval_dyn): New fun.
6644 (menu_item_eval_property): Use it.
ca105506
SM
6645
6646 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6647
03408648
SM
6648 * fns.c (concat, mapcar1): Accept byte-code-functions.
6649
6650 * eval.c (Fsetq): Handle lexical vars.
6651 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6652 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6653 (FletX, Flet): Obey lexical binding.
6654 (Fcommandp): Handle closures.
6655 (Feval): New `lexical' arg.
6656 (eval_sub): New function extracted from Feval. Use it almost
6657 everywhere where Feval was used. Look up vars in lexical env.
6658 Handle closures.
6659 (Ffunctionp): Move from subr.el.
6660 (Ffuncall): Handle closures.
6661 (apply_lambda): Remove `eval_flags'.
6662 (funcall_lambda): Handle closures and new byte-code-functions.
6663 (Fspecial_variable_p): New function.
6664 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6665 but without exporting it to Lisp.
23aba0ea 6666
23aba0ea 6667 * doc.c (Fdocumentation, store_function_docstring):
03408648 6668 * data.c (Finteractive_form): Handle closures.
23aba0ea 6669
03408648
SM
6670 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6671 interactive spec.
ba83908c 6672
04f2d78b
CB
6673 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6674 New byte-codes.
03408648
SM
6675 (exec_byte_code): New function extracted from Fbyte_code to handle new
6676 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6677
03408648 6678 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6679
03408648 6680 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6681
e2abce01
JB
66822011-03-31 Juanma Barranquero <lekktu@gmail.com>
6683
6684 * xdisp.c (redisplay_internal): Fix prototype.
6685
63696a73 66862011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6687
63696a73 6688 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6689 (try_scrolling): Use it when setting scroll_limit.
6690 Limit scrolling to 100 screen lines.
63696a73
EZ
6691 (redisplay_window): Even when falling back on "recentering",
6692 position point in the window according to scroll-conservatively,
6693 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6694
6695 (try_scrolling): When point is above the window, allow searching
6696 as far as scroll_max, or one screenful, to compute vertical
6697 distance from PT to the scroll margin position. This prevents
6698 try_scrolling from unnecessarily failing when
6699 scroll-conservatively is set to a value slightly larger than the
6700 window height. Clean up the case of PT below the margin at bottom
6701 of window: scroll_max can no longer be INT_MAX. When aggressive
6702 scrolling is in use, don't let point enter the opposite scroll
6703 margin as result of the scroll.
6704 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6705 threshold of 100 lines for never-recentering scrolling.
6706
e4cc2dfc
JB
67072011-03-31 Juanma Barranquero <lekktu@gmail.com>
6708
6709 * dispextern.h (move_it_by_lines):
6710 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6711 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6712 (message_log_check_duplicate): Remove parameters `prev_bol' and
6713 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6714 (redisplay_internal): Remove parameter `preserve_echo_area',
6715 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6716
6717 * indent.c (Fvertical_motion):
6718 * window.c (window_scroll_pixel_based, Frecenter):
6719 Don't pass `need_y_p' to `move_it_by_lines'.
6720
1c470562
SM
67212011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6722
44f230aa
SM
6723 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6724 steal a few bits to be more compact.
6725 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6726 Remove unneeded casts.
6727
1c470562
SM
6728 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6729
888adce9
ZK
67302011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6731
6732 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6733 binding" message (bug#7967).
6734
f838ed7b
PE
67352011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6736
77861b95
PE
6737 Fix more problems found by GCC 4.6.0's static checks.
6738
de6dbc14
PE
6739 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6740 Remove unused local var.
6741
f838ed7b
PE
6742 * editfns.c (Fmessage_box): Remove unused local var.
6743
792c7b2b
PE
6744 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6745 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6746 Omit unused local vars.
c499e557 6747 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6748 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6749 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6750 Omit unused local var.
6751
ba0165e1
PE
6752 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6753 Don't assume string length fits in int.
32ad8845 6754 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6755 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6756
3c59b4c9
PE
6757 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6758 instead of alloca (Bug#8344).
6759
a3eed478 6760 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6761 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6762
eb4d412d
PE
6763 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6764
1658b401
PE
6765 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6766 concerns.
6767
6768 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6769
6770 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6771
9a2c6e05
PE
6772 * keyboard.c (syms_of_keyboard): Use the same style as later
6773 in this function when indexing through an array. This also
6774 works around GCC bug 48267.
6775
03d0a109
PE
6776 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6777
44f730c8
PE
6778 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6779
fe75f926
PE
6780 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6781 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6782
ffa8c828
PE
6783 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6784 This avoids undefined behavior on integer overflow, and is a bit
6785 more convenient anyway since it is compared to a size_t variable.
6786
c5101a77
PE
6787 Variadic C functions now count arguments with size_t, not int.
6788 This avoids an unnecessary limitation on 64-bit machines, which
6789 caused (substring ...) to crash on large vectors (Bug#8344).
6790 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6791 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6792 All variadic functions and their callers changed accordingly.
c5101a77
PE
6793 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6794 * data.c (arith_driver, float_arith_driver): Likewise.
6795 * editfns.c (general_insert_function): Likewise.
6796 * eval.c (struct backtrace.nargs, interactive_p)
6797 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6798 (funcall_lambda, mark_backtrace): Likewise.
6799 * fns.c (concat): Likewise.
6800 * frame.c (x_set_frame_parameters): Likewise.
6801 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6802 0 if not found, not -1. All callers changed.
6803
dd3f25f7
PE
6804 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6805 (stack_copy_size): Now size_t, not int.
6806 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6807
461c2ab9
JB
68082011-03-28 Juanma Barranquero <lekktu@gmail.com>
6809
6810 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6811 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6812 All callers changed.
6813
6814 * lisp.h (multibyte_char_to_unibyte):
6815 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6816 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6817 * character.h (CHAR_TO_BYTE8):
6818 * cmds.c (internal_self_insert):
6819 * editfns.c (general_insert_function):
6820 * keymap.c (push_key_description):
6821 * search.c (Freplace_match):
6822 * xdisp.c (message_dolog, set_message_1): All callers changed.
6823
f6d62986
SM
68242011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6825
6826 * keyboard.c (safe_run_hook_funcall): New function.
6827 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6828 don't set the hook to nil, but remove the offending function instead.
6829 (Qcommand_hook_internal): Remove, unused.
6830 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6831 Vcommand_hook_internal.
6832
6833 * eval.c (enum run_hooks_condition): Remove.
6834 (funcall_nil, funcall_not): New functions.
6835 (run_hook_with_args): Call each function through a `funcall' argument.
6836 Remove `cond' argument, now redundant.
6837 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6838 (Frun_hook_with_args_until_failure): Adjust accordingly.
6839 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6840
1db5b1ad
JB
68412011-03-28 Juanma Barranquero <lekktu@gmail.com>
6842
6843 * dispextern.h (string_buffer_position): Remove declaration.
6844
6845 * print.c (strout): Remove parameter `multibyte', unused since
6846 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6847
6848 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6849 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6850 All callers changed.
6851
6852 * w32.c (_wsa_errlist): Use braces for struct initializers.
6853
6854 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6855 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6856 All callers changed.
6857 (string_buffer_position): Likewise. Also, make static (it's never
6858 used outside xdisp.c).
6859 (cursor_row_p): Remove parameter `w', unused since
6860 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6861 (decode_mode_spec): Remove parameter `precision', introduced during
6862 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6863 All callers changed.
6864
5ffb62aa
JD
68652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6866
6867 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6868
461c2ab9 68692011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6870
6871 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6872 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6873 (ns_update_auto_hide_menu_bar): New functions.
6874 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6875 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6876 ns_constrain_all_frames.
6877 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6878 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6879
5c380ffb
JD
68802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6881
6882 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6883
9af30bdf
GM
68842011-03-27 Glenn Morris <rgm@gnu.org>
6885
6886 * syssignal.h: Replace RETSIGTYPE with void.
6887 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6888 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6889 Replace SIGTYPE with void everywhere.
6890 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6891 * s/template.h (SIGTYPE): Remove commented out definition.
6892
e2abce01
JB
68932011-03-26 Eli Zaretskii <eliz@gnu.org>
6894
6895 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6896 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6897
f868cd8a
JB
68982011-03-26 Juanma Barranquero <lekktu@gmail.com>
6899
59eb0929
JB
6900 * w32.c (read_unc_volume): Use parameter `henum', instead of
6901 global variable `wget_enum_handle'.
6902
6903 * keymap.c (describe_vector): Remove parameters `indices' and
6904 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6905 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6906
f868cd8a
JB
6907 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6908
6909 * keyboard.c (timer_check): Remove parameter `do_it_now',
6910 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6911 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6912 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6913
6914 * keyboard.c (read_char):
6915 * w32menu.c (w32_menu_display_help):
6916 * xmenu.c (show_help_event, menu_help_callback):
6917 Adjust calls to `show_help_echo'.
6918
6919 * gtkutil.c (xg_maybe_add_timer):
6920 * keyboard.c (readable_events):
6921 * process.c (wait_reading_process_output):
6922 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6923
6924 * insdel.c (adjust_markers_gap_motion):
6925 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6926 (gap_left, gap_right): Don't call it.
6927
2ecf6fdb
CY
69282011-03-25 Chong Yidong <cyd@stupidchicken.com>
6929
6930 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6931 incurred during fontification.
6932
6b1f9ba4
JB
69332011-03-25 Juanma Barranquero <lekktu@gmail.com>
6934
6935 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6936 (DEFVAR_PER_BUFFER): Don't pass it.
6937
6938 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6939 (scrolling_window): Don't pass it.
6940
0f4a96b5
JB
69412011-03-25 Juanma Barranquero <lekktu@gmail.com>
6942
6943 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6944
6945 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6946 and `suffix'.
6947 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6948 of variables specific to SELinux and computation of `encoded_absname'.
6949
6950 * image.c (XPutPixel): Remove unused variable `height'.
6951
6952 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6953
6954 * unexw32.c (get_section_info): Remove unused variable `section'.
6955
6956 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6957 (system_process_attributes): Remove unused variable `sess'.
6958 (sys_read): Remove unused variable `err'.
6959
6960 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6961 (w32_wnd_proc): Remove unused variable `isdead'.
6962 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6963 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6964 (x_create_tip_frame): Remove unused variable `tem'.
6965
6966 * w32inevt.c (w32_console_read_socket):
6967 Remove unused variable `no_events'.
6968
6969 * w32term.c (x_draw_composite_glyph_string_foreground):
6970 Remove unused variable `width'.
6971
1149507c
JB
69722011-03-24 Juanma Barranquero <lekktu@gmail.com>
6973
6974 * w32term.c (x_set_glyph_string_clipping):
6975 Don't pass uninitialized region to CombineRgn.
6976
9c88f339
JB
69772011-03-23 Juanma Barranquero <lekktu@gmail.com>
6978
6979 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6980 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6981 (Fx_close_connection): Remove unused variable `i'.
6982
6983 * w32font.c (w32font_draw): Return number of glyphs.
6984 (w32font_open_internal): Remove unused variable `i'.
6985 (w32font_driver): Add missing initializer.
6986
6987 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6988 (fill_in_menu): Remove unused variable `items_added'.
6989
6990 * w32term.c (last_mouse_press_frame): Remove static global variable.
6991 (w32_clip_to_row): Remove unused variable `f'.
6992 (x_delete_terminal): Remove unused variable `i'.
6993
6994 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6995 (NOTHING): Remove unused static global variable.
6996 (uniscribe_check_otf): Remove unused variable `table'.
6997 (uniscribe_font_driver): Add missing initializers.
6998
dee091a3
JD
69992011-03-23 Julien Danjou <julien@danjou.info>
7000
7001 * term.c (Fsuspend_tty, Fresume_tty):
7002 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7003 * window.c (temp_output_buffer_show):
7004 * insdel.c (signal_before_change):
7005 * frame.c (Fhandle_switch_frame):
7006 * fileio.c (Fdo_auto_save):
7007 * emacs.c (Fkill_emacs):
7008 * editfns.c (save_excursion_restore):
7009 * cmds.c (internal_self_insert):
7010 * callint.c (Fcall_interactively):
7011 * buffer.c (Fkill_all_local_variables):
7012 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7013 Use Frun_hooks.
0f4a96b5 7014 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7015 unconditionnaly since it does the check itself.
7016
2c520ab5 70172011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7018
c9c49752
PE
7019 Fix more problems found by GCC 4.5.2's static checks.
7020
8abc3f12
PE
7021 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7022 the first time through the loop, since we know p0 < p1 then.
7023 This also avoids a gcc -Wstrict-overflow warning.
7024
a2d26660
PE
7025 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7026 leading to a memory leak, possible in functions like
7027 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7028 of objects (Bug#8318).
a2d26660 7029
916c72e9
PE
7030 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7031 that could (at least in theory) be that large.
7032
19ab8a18
PE
7033 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7034 This is less likely to overflow, and avoids undefined behavior if
7035 overflow does occur. All callers changed. Use strtoul to scan
7036 for the unsigned long integer.
b7cbbd6f
PE
7037 (pint2hrstr): Simplify and tune code slightly.
7038 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7039
f0641eff
PE
7040 * scroll.c (do_scrolling): Work around GCC bug 48228.
7041 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7042
7f650bb9
PE
7043 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7044 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7045 (validate_x_resource_name): Simplify count usage.
7046 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7047
37dd57d1
PE
7048 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7049 fail (Bug#8306).
81e56e61 7050
699979fc 7051 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7052
401bf9b4
PE
7053 * process.c (Fmake_network_process): Use socklen_t, not int,
7054 where POSIX says socklen_t is required in portable programs.
7055 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7056 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7057 (Fmake_network_process, server_accept_connection):
7058 (wait_reading_process_output, read_process_output):
7059 Likewise.
7060
b93aacde
PE
7061 * process.c: Rename or move locals to avoid shadowing.
7062 (list_processes_1, Fmake_network_process):
7063 (read_process_output_error_handler, exec_sentinel_error_handler):
7064 Rename or move locals.
4dc343ee 7065 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7066 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7067 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7068 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7069 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7070
af8a867c 7071 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7072 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7073 Include tparam.h instead, since it declares them.
af8a867c
PE
7074 * cm.h (PC): Remove extern decl; tparam.h now does this.
7075 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7076 * terminfo.c: Include tparam.h, to check interfaces.
7077 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7078 (tparam): Adjust signature to match interface in tparam.h;
7079 this removes some undefined behavior. Check that outstring and len
7080 are zero, which they always are with Emacs.
7081 * tparam.h (PC, BC, UP): New extern decls.
7082
0248044d 7083 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7084 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7085
8ff096c1 7086 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7087 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7088 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7089 (ftfont_list): Remove unused local.
49eaafba
PE
7090 (get_adstyle_property, ftfont_pattern_entity):
7091 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7092 Rename locals to avoid shadowing.
8ff096c1 7093
e2be39f6
PE
7094 * xfont.c (xfont_list_family): Mark var as initialized.
7095
c9735e30
PE
7096 * xml.c (make_dom): Now static.
7097
8f5201ae
PE
7098 * composite.c (composition_compute_stop_pos): Rename local to
7099 avoid shadowing.
b246f932
PE
7100 (composition_reseat_it): Remove unused locals.
7101 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7102 (composition_update_it): Mark var as initialized.
11b61122
PE
7103 (find_automatic_composition): Mark vars as initialized,
7104 with a FIXME (Bug#8290).
8f5201ae 7105
760fbc2c
PE
7106 character.h: Rename locals to avoid shadowing.
7107 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7108 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7109 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7110 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7111 to avoid shadowing.
7112
ff08eb85
PE
7113 * textprop.c (property_change_between_p): Remove; unused.
7114
fc7bf025
PE
7115 * intervals.c (interval_start_pos): Now static.
7116
235d7abc
PE
7117 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7118
44f230aa
SM
7119 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7120 Rename locals to avoid shadowing.
3e7d6594 7121
50060332
PE
7122 * sound.c (wav_play, au_play, Fplay_sound_internal):
7123 Fix pointer signedness.
d01f234b 7124 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7125 (wav_play): Initialize a variable to 0, to prevent undefined
7126 behavior (Bug#8278).
50060332 7127
c4fc4e30
PE
7128 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7129
918436ed
PE
7130 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7131
c939f91b
PE
7132 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7133 clobbering (Bug#8298).
b9c7f648
PE
7134 * sysdep.c (sys_subshell): Likewise.
7135 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7136
6bd8c144
PE
7137 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7138 This should get cleaned up, so that child_setup has the
7139 same signature on all platforms.
7140
7710357c 7141 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7142 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7143
c59da222
CY
71442011-03-22 Chong Yidong <cyd@stupidchicken.com>
7145
7146 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7147 not to be necessary, and produces flickering.
7148
66b87493
GM
71492011-03-20 Glenn Morris <rgm@gnu.org>
7150
7151 * config.in: Remove file.
7152
45b6f6d5
JB
71532011-03-20 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7156 are now in src/globals.h.
7157 (syms_of_minibuf): Remove spurious & from previous change.
7158
3ec03f7e
LL
71592011-03-20 Leo <sdl.web@gmail.com>
7160
7161 * minibuf.c (completing-read-function): New variable.
7162 (completing-read-default): Rename from completing-read.
7163 (completing-read): Call completing-read-function.
7164
b14e3e21
CY
71652011-03-19 Juanma Barranquero <lekktu@gmail.com>
7166
7167 * xfaces.c (Fx_load_color_file):
7168 Read color file from absolute filename (bug#8250).
7169
f2b726e6
JB
71702011-03-19 Juanma Barranquero <lekktu@gmail.com>
7171
7172 * makefile.w32-in: Update dependencies.
7173
09f6ff02
EZ
71742011-03-17 Eli Zaretskii <eliz@gnu.org>
7175
7176 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7177
29a6015a
PE
71782011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7179
a3a6c54e
PE
7180 Fix more problems found by GCC 4.5.2's static checks.
7181
b766f867
PE
7182 * process.c (make_serial_process_unwind, send_process_trap):
7183 (sigchld_handler): Now static.
7184
be02381c
PE
7185 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7186 That way, the code declares only the vars that it needs.
7187 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7188 * s/cygwin.h (PTY_ITERATION): Likewise.
7189 * s/darwin.h (PTY_ITERATION): Likewise.
7190 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7191
57048744
PE
7192 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7193 * process.c (allocate_pty): Don't declare stb unless it's needed.
7194
7914961c 7195 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7196 (CONSTANTLIM): Remove; unused.
7197 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7198 Define only if needed.
7914961c 7199
b3967b18
PE
7200 * unexelf.c (unexec): Name an expression,
7201 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7202 Use a different way to cause a compilation error if anyone uses
7203 n rather than nn, a way that does not involve shadowing.
73366a00 7204 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7205
29a6015a
PE
7206 * deps.mk (unexalpha.o): Remove; unused.
7207
43cfc33e 7208 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7209 * unexec.h: New file.
ce701a33
PE
7210 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7211 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7212 Depend on unexec.h.
7213 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7214 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7215 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7216 Change as necessary to match prototype in unexec.h.
ce701a33 7217
01f44d5a
PE
7218 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7219 shadowing.
4f63c6bb 7220 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7221
a6670b0b
PE
7222 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7223 Rename locals to avoid shadowing.
7224
cef2010d 7225 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7226 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7227
d4d7173a
PE
7228 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7229
f08b802a
PE
7230 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7231 warning when compiling print.c.
7232
3ddb0639
PE
7233 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7234 instead of using an uninitialized var.
5ad03b97 7235 (font_sort_entities): Mark var as initialized.
3ddb0639 7236
170a2692
PE
7237 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7238
e663c700
PE
7239 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7240 pointers to constants.
89bc529a 7241 (font_parse_fcname): Remove unused vars.
7b81e2d0 7242 (font_delete_unmatched): Now static.
ea838e10 7243 (font_get_spec): Remove; unused.
13a547c6
PE
7244 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7245 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7246 Rename or move locals to avoid shadowing.
e663c700 7247
2a80c887 7248 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7249 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7250
1384fa33 7251 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7252 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7253
8b2c52e9
PE
7254 * alloc.c (mark_backtrace): Move decl from here ...
7255 * lisp.h: ... to here, so that it can be checked.
7256
475545b5 7257 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7258 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7259 (lisp_indirect_variable): Name an expression,
7260 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7261 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7262
b1349114 7263 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7264 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7265 Use const pointer when appropriate.
b1349114 7266
a2928364
PE
7267 * lisp.h (get_system_name, get_operating_system_release):
7268 Move decls here, to check interfaces.
7269 * process.c (get_operating_system_release): Move decl to lisp.h.
7270 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7271 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7272 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7273 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7274 (Fformat_time_string, Fencode_time, Finsert_char):
7275 (Ftranslate_region_internal, Fformat):
7276 Rename or remove local vars to avoid shadowing.
9710023e 7277 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7278
a415e694
PE
7279 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7280 avoid shadowing.
7281
8ef4622d
PE
7282 * lisp.h (eassert): Check that the argument compiles, even if
7283 ENABLE_CHECKING is not defined.
7284
946f9a5b
PE
7285 * data.c (Findirect_variable): Name an expression, to avoid
7286 gcc -Wbad-function-cast warning.
112396d6 7287 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7288 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7289 (Fmake_variable_buffer_local, Fmake_local_variable):
7290 Mark variables as initialized.
52746918 7291 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7292
e5aab7e7 7293 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7294 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7295 Rename locals to avoid shadowing.
dff45157
PE
7296 (mark_stack): Move local variables into the #ifdef region where
7297 they're used.
7bc26fdb
PE
7298 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7299 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7300 needed otherwise.
7301 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7302 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7303 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7304
e5aab7e7
PE
7305 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7306 avoids undefined behavior in theory.
7307
4da60324
PE
7308 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7309
88043301
PE
7310 Use functions, not macros, for up- and down-casing (Bug#8254).
7311 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7312 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7313 to use the following functions instead of these macros.
7314 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7315 EMACS_INT, since callers assume the returned value fits in int.
7316 (upcase1): Likewise, for UPCASE_TABLE.
7317 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7318 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7319 the race-condition problem in the old DOWNCASE.
88043301 7320
19ed5445
PE
7321 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7322 Rename locals to avoid shadowing.
7323 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7324 (regex_compile, re_search_2, re_match_2_internal):
7325 Remove unused local vars.
952db0d7
PE
7326 (FREE_VAR): Rewrite so as not to use empty "else",
7327 which gcc can warn about.
da053e48 7328 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7329 (RETALLOC_IF): Define only if needed.
7330 (WORDCHAR_P): Likewise. This one is never needed, but is used
7331 only in a comment talking about a compiler bug, so put inside
7332 the #if 0 of that comment.
7333 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7334 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7335 Remove; unused.
19ed5445 7336
1f3561e4 7337 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7338 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7339 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7340
ded6f8f7
PE
7341 * search.c (simple_search): Remove unused var.
7342
dbd37a95
PE
7343 * dired.c (compile_pattern): Move decl from here ...
7344 * lisp.h: ... to here, so that it can be checked.
7345 (struct re_registers): New forward decl.
7346
7e47afad
PE
7347 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7348
85f24f61
PE
7349 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7350 All uses changed.
7351 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7352 Rename locals to avoid shadowing.
5671df8f 7353 (Fvertical_motion): Mark locals as initialized.
85f24f61 7354
181aa2be 7355 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7356 (casify_region): Mark local as initialized.
181aa2be 7357
930d429c
PE
7358 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7359
7082eac6
PE
7360 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7361 New macros, so that the caller can use some names other than
7362 gcpro1, gcpro2, etc.
7363 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7364 of the new macros.
7365 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7366 argument, for consistency with GCPRO2_VAR, etc: it is now the
7367 prefix of the variable, not the variable itself. All uses
7368 changed.
38b2c076
PE
7369 * dired.c (directory_files_internal, file_name_completion):
7370 Rename locals to avoid shadowing.
7371
15206ed9
PE
7372 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7373 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7374 dired.c's scmp function, had undefined behavior.
7375 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7376 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7377 * buffer.h: ... to here, because these macros use current_buffer,
7378 and the new implementation with inline functions needs to have
7379 current_buffer in scope now, rather than later when the macros
7380 are used.
7381 (downcase, upcase1): New static inline functions.
7382 (DOWNCASE, UPCASE1): Reimplement using these functions.
7383 This avoids undefined behavior in expressions like
7384 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7385 from race conditions in accessing the global variables
7386 case_temp1 and case_temp2.
7387 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7388 * lisp.h (case_temp1, case_temp2): Remove their decls.
7389 * character.h (ASCII_CHAR_P): Move from here ...
7390 * lisp.h: ... to here, so that the inline functions mentioned
7391 above can use them.
7392
4a6bea26
PE
7393 * dired.c (directory_files_internal_unwind): Now static.
7394
f14b7e14
PE
7395 * fileio.c (file_name_as_directory, directory_file_name):
7396 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7397 Now static.
2893f146
PE
7398 (file_name_as_directory): Use const pointers when appropriate.
7399 (Fexpand_file_name): Likewise. In particular, newdir might
7400 point at constant storage, so make it a const pointer.
fd4ead52 7401 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7402 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7403 signedness issues.
f839df0c
PE
7404 (Fset_file_times, Finsert_file_contents, auto_save_error):
7405 Rename locals to avoid shadowing.
f14b7e14 7406
5716756e 7407 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7408 (Ftry_completion, Fall_completions): Rename or remove locals
7409 to avoid shadowing.
5716756e 7410
b4c3046a
PE
7411 * marker.c (bytepos_to_charpos): Remove; unused.
7412
b45db522
PE
7413 * lisp.h (verify_bytepos, count_markers): New decls,
7414 so that gcc does not warn that these functions aren't declared.
7415
85876d07
PE
7416 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7417 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7418 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7419 (copy_text): Remove unused local var.
85876d07 7420
03d78a21 7421 * filelock.c (within_one_second): Now static.
b3dd38ab 7422 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7423
5df8f01b
PE
7424 * buffer.c (fix_overlays_before): Mark locals as initialized.
7425 (fix_start_end_in_overlays): Likewise. This function should be
7426 simplified by using pointers-to-pointers, but that's a different
7427 matter.
b1d876f1 7428 (switch_to_buffer_1): Now static.
8f54f30a
PE
7429 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7430 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7431
a70072c9 7432 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7433 Fix pointer signedness issue.
edced198
PE
7434 (sys_subshell): Mark local as volatile if checking for lint,
7435 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7436 (MAXPATHLEN): Define only if needed.
a70072c9 7437
a0977c44
PE
7438 * process.c (serial_open, serial_configure): Move decls from here ...
7439 * systty.h: ... to here, so that they can be checked.
7440
a884fdcc
PE
7441 * fns.c (get_random, seed_random): Move extern decls from here ...
7442 * lisp.h: ... to here, so that they can be checked.
7443
604efe86 7444 * sysdep.c (reset_io): Now static.
b8950c94 7445 (wait_for_termination_signal): Remove; unused.
604efe86 7446
38fc62d9
PE
7447 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7448 (copy_keymap_item, append_key, push_text_char_description):
7449 Now static.
1004a21a 7450 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7451 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7452 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7453 (describe_map_tree):
7454 Rename locals to avoid shadowing.
38fc62d9 7455
2f2650da
PE
7456 * keyboard.c: Declare functions static if they are not used elsewhere.
7457 (echo_char, echo_dash, cmd_error, top_level_2):
7458 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7459 (read_char, kbd_buffer_get_event, make_lispy_position):
7460 (make_lispy_event, make_lispy_movement, apply_modifiers):
7461 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7462 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7463 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7464 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7465 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7466
a053e86c 7467 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7468 (mark_kboards): Move decl here ...
7469 * alloc.c (mark_kboards): ... from here.
a053e86c 7470
4752793e
PE
7471 * lisp.h (force_auto_save_soon): New decl.
7472
74f10ca7 7473 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7474 (DEFINE_DUMMY_FUNCTION): New macro.
7475 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7476 Use it.
c03cd23f
PE
7477 (main): Add casts to avoid warnings
7478 if GCC considers string literals to be constants.
74f10ca7 7479
022e70d4
PE
7480 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7481
59d6fe83
PE
7482 * dbusbind.c: Pointer signedness fixes.
7483 (xd_signature, xd_append_arg, xd_initialize):
7484 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7485 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7486 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7487 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7488
78320123
PE
7489 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7490 if GCC considers string literals to be constants.
49cebcca 7491 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7492
35ac2a97
SM
74932011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7494
fb103ca9
SM
7495 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7496 (print_preprocess, print_object): New macro to fix last change.
7497
35ac2a97
SM
7498 * print.c (print_preprocess): Don't forget font objects.
7499
62973b41
JB
75002011-03-16 Juanma Barranquero <lekktu@gmail.com>
7501
7502 * emacs.c (USAGE3): Doc fixes.
7503
0e48bb22
AS
75042011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7505
7506 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7507 structure.
7508
7684e57b
JB
75092011-03-14 Juanma Barranquero <lekktu@gmail.com>
7510
7511 * lisp.h (VWindow_system, Qfile_name_history):
7512 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7513 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7514 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7515
7516 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7517 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7518
7519 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7520 * w32console.c (detect_input_pending, read_input_pending)
7521 (encode_terminal_code):
7522 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7523 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7524 (w32_system_caret_y, Qfile_name_history):
7525 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7526 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7527 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7528 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7529 * w32proc.c (Qlocal, report_file_error):
7530 * w32term.c (Vwindow_system, updating_frame):
7531 * w32uniscribe.c (initialized, uniscribe_font_driver):
7532 Remove unneeded extern declarations.
7533
2aa46d6c
CY
75342011-03-14 Chong Yidong <cyd@stupidchicken.com>
7535
c96bbc66 7536 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7537
cffc6f3b
CY
75382011-03-13 Chong Yidong <cyd@stupidchicken.com>
7539
7540 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7541 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7542 These macros can no longer be used for assignment.
7543
44f230aa
SM
7544 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7545 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7546 (record_buffer_markers, fetch_buffer_markers): New functions for
7547 recording and fetching special buffer markers.
7548 (set_buffer_internal_1, set_buffer_temp): Use them.
7549
7550 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7551
7552 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7553
7554 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7555 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7556
7557 * xdisp.c (hscroll_window_tree):
7558 (reconsider_clip_changes): Use PT instead of BUF_PT.
7559
d251f04b
EZ
75602011-03-13 Eli Zaretskii <eliz@gnu.org>
7561
7562 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7563 $(EMACS_ROOT)/lib/intprops.h.
7564
f0c77cd1
PE
75652011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7566
3eca4629
PE
7567 Fix more problems found by GCC 4.5.2's static checks.
7568
7c86ee98
PE
7569 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7570 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7571 (xg_free_frame_widgets): Make it clear that a local variable is
7572 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7573 (gdk_window_get_screen): Make it clear that this macro is needed
7574 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7575 (int_gtk_range_get_value): New function, which avoids a diagnostic
7576 from gcc -Wbad-function-cast.
7577 (xg_set_toolkit_scroll_bar_thumb): Use it.
7578 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7579 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7580 (get_utf8_string, xg_get_file_with_chooser):
7581 Rename locals to avoid shadowing.
7582 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7583
41729b81
PE
7584 * xgselect.c (xg_select): Remove unused var.
7585
f0c77cd1
PE
7586 * image.c (four_corners_best): Mark locals as initialized.
7587 (gif_load): Initialize transparent_p to zero (Bug#8238).
7588 Mark another local as initialized.
ec6cf4c6 7589 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7590
ce0ad53d 7591 * image.c (clear_image_cache): Now static.
d5d5a617 7592 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7593 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7594 (x_edge_detection): Remove unnecessary cast that
7595 gcc -Wbad-function-cast diagnoses.
2037898d 7596 (gif_load): Fix pointer signedness.
6ae141d6
PE
7597 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7598 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7599
33383987 76002011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7601
d32df629
PE
7602 Improve quality of tests for time stamp overflow.
7603 For example, without this patch (encode-time 0 0 0 1 1
7604 1152921504606846976) returns the obviously-bogus value (-948597
7605 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7606 reports time overflow. See
7607 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7608 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7609 * editfns.c: Include limits.h and intprops.h.
7610 (TIME_T_MIN, TIME_T_MAX): New macros.
7611 (time_overflow): Move earlier, to before first use.
7612 (hi_time, lo_time): New functions, for an accurate test for
7613 out-of-range times.
7614 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7615 (Fget_internal_run_time): Don't assume time_t fits in int.
7616 (make_time): Use list2 instead of Fcons twice.
7617 (Fdecode_time): More accurate test for out-of-range times.
7618 (check_tm_member): New function.
7619 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7620 (lisp_time_argument): Don't rely on undefined left-shift and
7621 right-shift behavior when checking for time stamp overflow.
8be6f318 7622
fe31d94c
PE
7623 * editfns.c (time_overflow): New function, refactoring common code.
7624 (Fformat_time_string, Fdecode_time, Fencode_time):
7625 (Fcurrent_time_string): Use it.
7626
8be6f318
PE
7627 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7628 * dired.c (make_time): Move to ...
7629 * editfns.c (make_time): ... here.
7630 * systime.h: Note the move.
7631
09d9db2c 76322011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7633
126bc0dc
YM
7634 * fringe.c (update_window_fringes): Remove unused variables.
7635
c47cbdfd
YM
7636 * unexmacosx.c (copy_data_segment): Also copy __got section.
7637 (Bug#8223)
7638
7ac80be9
EZ
76392011-03-12 Eli Zaretskii <eliz@gnu.org>
7640
c96bbc66 7641 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7642 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7643 Constify `char *' arguments and their references according to
7644 prototypes in tparam.h.
7645
ecb0f94d 7646 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7647
7ac80be9
EZ
7648 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7649 Adapt all references accordingly.
7650
7651 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7652
ef1fd07e
TT
76532011-03-11 Tom Tromey <tromey@redhat.com>
7654
7655 * buffer.c (syms_of_buffer): Remove obsolete comment.
7656
7ef4b50c
EZ
76572011-03-11 Eli Zaretskii <eliz@gnu.org>
7658
7659 * termhooks.h (encode_terminal_code): Declare prototype.
7660
7661 * msdos.c (encode_terminal_code): Don't declare prototype.
7662
7663 * term.c (encode_terminal_code): Now external again, used by
7664 w32console.c and msdos.c.
7665
44f230aa
SM
7666 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7667 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7668
4b1ec863 76692011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7670
1714f52b 7671 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7672
4b1ec863
PE
7673 * fringe.c (update_window_fringes): Mark locals as initialized
7674 (Bug#8227).
7675 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7676
524c7aa6
PE
7677 * alloc.c (mark_fringe_data): Move decl from here ...
7678 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7679 to check its interface.
7680 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7681
a5c0af81 7682 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7683 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7684 (fontset_font): Mark local as initialized.
a9a06e0b 7685 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7686
b4716021
PE
7687 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7688
811e9bac 7689 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7690 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7691 (x_own_selection, Fx_disown_selection_internal): Rename locals
7692 to avoid shadowing.
7693 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7694
7e3ab302
PE
7695 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7696 so that the caller can use some name other than gcpro1.
7697 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7698 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7699 (Fx_backspace_delete_keys_p):
7700 Use them to avoid shadowing, and rename vars to avoid shadowing.
7701 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7702 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7703 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7704 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7705 Remove unused locals.
7e3ab302
PE
7706 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7707 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7708 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7709 macros.
f78faa98 7710
e2b13473
PE
7711 * xterm.h (x_mouse_leave): New decl.
7712
77f23912
PE
7713 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7714 Remove unused functions.
cdf4ba58
PE
7715 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7716 (x_calc_absolute_position): Now static.
7411c686 7717 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7718 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7719 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7720 unless they are used.
38d0b34a
PE
7721 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7722 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7723 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7724 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7725 (x_error_catcher, x_connection_closed, x_error_handler):
7726 (x_error_quitter, xembed_send_message, x_iconify_frame):
7727 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7728 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7729 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7730
44f230aa
SM
7731 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7732 Rename or move locals to avoid shadowing.
6b463e58 7733 (tty_defined_color, merge_face_heights): Now static.
5967d051 7734 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7735 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7736 does not deduce is never used uninitialized.
73719eba
PE
7737 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7738 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7739
426994c3 7740 * terminal.c (store_terminal_param): Now static.
5489860b 7741
032f1620 7742 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7743 (set_frame_menubar): Remove unused local.
d4323972 7744 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7745 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7746 since they might point to immutable storage.
281585b0
PE
7747 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7748 since it's unused otherwise.
032f1620 7749
367c19e5 7750 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7751 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7752 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7753 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7754 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7755 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7756 does not deduce are never used uninitialized.
70739cbe 7757
07b48fa9
PE
7758 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7759
8868a238 7760 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7761 * window.c (window_loop, size_window):
7762 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7763
7e5cf297 7764 * window.c (display_buffer): Now static.
d6550a9f
PE
7765 (size_window): Mark variables that gcc -Wuninitialized
7766 does not deduce are never used uninitialized.
a586633d
PE
7767 * window.h (check_all_windows): New decl, to forestall
7768 gcc -Wmissing-prototypes diagnostic.
5b555da1 7769 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7770
f6095868
PE
7771 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7772 shadowing.
7773 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7774 Include <limits.h>.
7775 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7776 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7777 (load_charset_map): Mark variables that gcc -Wuninitialized
7778 does not deduce are never used uninitialized.
53df7c11 7779 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7780
f38b440c
PE
7781 * coding.c (coding_set_source, coding_set_destination):
7782 Use "else { /* comment */ }" rather than "else /* comment */;"
7783 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7784 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7785 a block, when the outer 'i' will do.
7786 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7787 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7788 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7789 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7790 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7791 Rename locals to avoid shadowing.
7792 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7793 * coding.c (emacs_mule_char, encode_invocation_designation):
7794 Now static, since they're not used elsewhere.
413bb2db 7795 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7796 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7797 (decode_coding_emacs_mule): Mark variables that gcc
7798 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7799 (detect_coding_iso_2022): Initialize a local variable that might
7800 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7801 this initialization is needed. (Bug#8211)
5f58e762
PE
7802 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7803 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7804 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7805 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7806 Remove unused macros.
f38b440c 7807
232b38b9 7808 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7809 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7810 * character.c (string_count_byte8): Likewise.
232b38b9 7811
fb90da1b
PE
7812 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7813 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7814
fb93dbc2
PE
7815 * chartab.c (copy_sub_char_table): Now static, since it's not used
7816 elsewhere.
5c156ace
PE
7817 (sub_char_table_ref_and_range, char_table_ref_and_range):
7818 Rename locals to avoid shadowing.
bbcd0949 7819 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7820
7d3b3862 7821 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7822 (BIDI_BOB): Remove unused macro.
7d3b3862 7823
6be7d3da
PE
7824 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7825 deduce are never used uninitialized.
c2ed9c8b 7826 * term.c (encode_terminal_code): Likewise.
6be7d3da 7827
75f8807f 7828 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7829
50938595
PE
7830 * tparam.h: New file.
7831 * term.c, tparam.h: Include it.
7832 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7833 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7834 Move these decls to tparam.h, and make them agree with what
7835 is actually in tparam.c. The previous trick of using incompatible
7836 decls in different modules does not conform to the C standard.
7837 All callers of tparam changed to use tparam's actual API.
7838 * tparam.c (tparam1, tparam, tgoto):
7839 Use const pointers where appropriate.
7840
fbceeba2
PE
7841 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7842 * cm.h (struct cm): Likewise.
7843 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7844 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7845 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7846 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7847 (turn_on_face, init_tty): Likewise.
7848 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7849
7f3f1250
PE
7850 * term.c (term_mouse_position): Rename local to avoid shadowing.
7851
e6ca6543
PE
7852 * alloc.c (mark_ttys): Move decl from here ...
7853 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7854
c40f8d15
AS
78552011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7856
7857 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7858
cfe0661d
JB
78592011-03-09 Juanma Barranquero <lekktu@gmail.com>
7860
7861 * search.c (compile_pattern_1): Remove argument regp, unused since
7862 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7863 (compile_pattern): Don't pass it.
7864
0afb4571
J
78652011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7866
7867 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7868 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7869 for ! HAVE_GTK3.
7870 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7871
7872 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7873
7874 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7875 gdk_window_get_screen, gdk_window_get_geometry,
7876 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7877 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7878 (xg_get_pixbuf_from_pixmap): New function.
7879 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7880 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7881 Call xg_get_pixbuf_from_pixmap instead of
7882 gdk_pixbuf_get_from_drawable.
7883 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7884 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7885 (xg_check_special_colors): Use GtkStyleContext and its functions
7886 for HAVE_GTK3.
7887 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7888 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7889 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7890 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7891 Call gtk_widget_get_preferred_size.
0afb4571
J
7892 (xg_frame_resized): gdk_window_get_geometry only takes 5
7893 parameters.
44f230aa
SM
7894 (xg_win_to_widget, xg_event_is_for_menubar):
7895 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7896 (xg_set_widget_bg): New function.
7897 (delete_cb): New function.
895009e1 7898 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7899 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7900 (xg_set_background_color): Call xg_set_widget_bg.
7901 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7902 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7903 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7904 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7905 if ! HAVE_GTK3.
7906 (update_frame_tool_bar): Call gtk_widget_hide.
7907 (xg_initialize): Use GDK_KEY_g.
7908
7909 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7910 if ! HAVE_GTK3
7911 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7912
7913 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7914 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7915 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7916
1c2cc4ef
JB
79172011-03-08 Juanma Barranquero <lekktu@gmail.com>
7918
7919 * w32xfns.c (select_palette): Check success of RealizePalette against
7920 GDI_ERROR, not zero.
7921
33383987 7922See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7923
7924;; Local Variables:
7925;; coding: utf-8
aac0c6e3
MR
7926;; End:
7927
33383987 7928 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7929
7930 This file is part of GNU Emacs.
7931
7932 GNU Emacs is free software: you can redistribute it and/or modify
7933 it under the terms of the GNU General Public License as published by
7934 the Free Software Foundation, either version 3 of the License, or
7935 (at your option) any later version.
7936
7937 GNU Emacs is distributed in the hope that it will be useful,
7938 but WITHOUT ANY WARRANTY; without even the implied warranty of
7939 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7940 GNU General Public License for more details.
7941
7942 You should have received a copy of the GNU General Public License
7943 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.