* lisp/emacs-lisp/package.el (package-archives): Doc fix re riskiness.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2bf26180
GM
12011-12-06 Glenn Morris <rgm@gnu.org>
2
3 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4 as an error, not just -1. (Bug#10217)
5
3a6ad4f0
CY
62011-12-05 Chong Yidong <cyd@gnu.org>
7
8 * keyboard.c (process_special_events): New function.
9 (swallow_events, Finput_pending_p): Use it (Bug#10195).
10
75a3b399
PE
112011-12-05 Paul Eggert <eggert@cs.ucla.edu>
12
13 * coding.c (encode_designation_at_bol): Don't use uninitialized
14 local variable (Bug#9318).
15
c3c9e25e
KH
162011-12-05 Kenichi Handa <handa@m17n.org>
17
18 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
19 return Qnil (Bug#8046, Bug#10193).
20
5eb05ea3
KH
212011-12-05 Kenichi Handa <handa@m17n.org>
22
23 * coding.c (encode_designation_at_bol): New args charbuf_end and
24 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
25 (coding_set_source): Return how many bytes coding->source was
26 relocated.
27 (coding_set_destination): Return how many bytes
28 coding->destination was relocated.
29 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
30 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
31
322011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
33
34 * coding.c (CODING_CHAR_CHARSET_P): New macro.
35 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
36 macro (Bug#9318).
37
382011-12-05 Andreas Schwab <schwab@linux-m68k.org>
39
40 The following changes are to fix Bug#9318.
41
a79703f5 42 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
43 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
44 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 45 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 46
7dbda6df
JB
472011-12-05 Juanma Barranquero <lekktu@gmail.com>
48
49 * lisp.h (process_quit_flag): Fix external declaration.
50
6d5eb5b0
SM
512011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
52
53 Don't macro-inline non-performance-critical code.
54 * eval.c (process_quit_flag): New function.
55 * lisp.h (QUIT): Use it.
56
a0c3fad0
JD
572011-12-04 Jan Djärv <jan.h.d@swipnet.se>
58
59 * nsfns.m (get_geometry_from_preferences): New function.
60 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
61
6c07aac2
AS
622011-12-04 Andreas Schwab <schwab@linux-m68k.org>
63
64 * emacs.c (Qkill_emacs): Define.
65 (syms_of_emacs): Initialize it.
66 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
67 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
68 (quit_throw_to_read_char): Add parameter `from_signal'.
69 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
70 * lisp.h (QUIT): Call Fkill_emacs if requested.
71
c052ead4
JD
722011-12-03 Jan Djärv <jan.h.d@swipnet.se>
73
74 * widget.c (update_wm_hints): Return if wmshell is null.
75 (widget_update_wm_size_hints): New function.
76
77 * widget.h (widget_update_wm_size_hints): Declare.
78
79 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
80 widget_update_wm_size_hints (Bug#10104).
81
9e49252b
EZ
822011-12-03 Eli Zaretskii <eliz@gnu.org>
83
84 * xdisp.c (handle_invisible_prop): If the invisible text ends just
85 before a newline, prepare the bidi iterator for consuming the
86 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 87 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 88
02b16839
JL
892011-12-02 Juri Linkov <juri@jurta.org>
90
91 * search.c (Fword_search_regexp): New Lisp function created from
92 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
93 (Fword_search_backward, Fword_search_forward)
94 (Fword_search_backward_lax, Fword_search_forward_lax):
95 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
96 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
97
0068070e
SM
982011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
99
100 * fileio.c (Finsert_file_contents): Move after-change-function call
101 to before the "handled:" label, since all "goto handled" appear in
102 cases where the *-change-functions have already been properly called
103 (bug#10117).
104
3360a3fc
AS
1052011-12-01 Andreas Schwab <schwab@linux-m68k.org>
106
107 * keyboard.c (interrupt_signal): Don't call kill-emacs when
108 waiting for input. (Bug#10169)
109
73d6c093
EZ
1102011-11-30 Eli Zaretskii <eliz@gnu.org>
111
112 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
113 verifies glyph row's hash code--we have just reallocated the
114 glyphs, so their contents can be complete garbage. (Bug#10164)
115
febe6bea
JB
1162011-11-30 Juanma Barranquero <lekktu@gmail.com>
117
118 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
119
801a4313
EZ
1202011-11-30 Eli Zaretskii <eliz@gnu.org>
121
122 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
123 attributes are tested _before_ calling verify_row_hash, to protect
124 against GCC re-ordering of the tests. (Bug#10164)
125
2b56b87e
JD
1262011-11-29 Jan Djärv <jan.h.d@swipnet.se>
127
128 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
129
130 * xterm.c (handle_one_xevent): Only set async_visible and friends
131 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 132 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
133 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
134
dbf31225
PE
1352011-11-28 Paul Eggert <eggert@cs.ucla.edu>
136
137 Remove GCPRO-related macros that exist only to avoid shadowing locals.
138 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
139 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
140 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
141 All uses changed to use GCPRO1 etc.
142 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
143 Revert to old implementation (i.e., before 2011-03-11).
144
1305621b
YM
1452011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
146
147 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
148 of scroll runs so as to avoid assigning disabled bogus rows and
149 unnecessary graphics copy operations.
150
8c9afb46
EZ
1512011-11-27 Eli Zaretskii <eliz@gnu.org>
152
153 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
154 (snprintf) [_MSC_VER]: Redirect to _snprintf.
155 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
156 (malloc, free, realloc, calloc): Redirect to e_* only when
157 compiling Emacs.
158
159 * lisp.h (GCTYPEBITS): Move before first use.
160 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
161 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
162 this macro definition.
163
164 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
165 _MSC_VER.
166
54e9e3bf
JD
1672011-11-27 Jan Djärv <jan.h.d@swipnet.se>
168
6d5eb5b0
SM
169 * gtkutil.c (xg_create_frame_widgets):
170 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
171 present with Gtk+ 2.0.
172
83aca1cb
PE
1732011-11-26 Paul Eggert <eggert@cs.ucla.edu>
174
175 * fileio.c (Finsert_file_contents): Undo previous change; see
176 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
177
5b76caa4
PE
1782011-11-26 Paul Eggert <eggert@cs.ucla.edu>
179
180 Rename locals to avoid shadowing.
181 * fileio.c (Finsert_file_contents):
182 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
183 * process.c (wait_reading_process_output):
184 Rename inner 'proc' to 'p' to avoid shadowing.
185 Indent for consistency with usual Emacs style.
186
8c535114
EZ
1872011-11-25 Eli Zaretskii <eliz@gnu.org>
188
189 * xdisp.c (redisplay_window): If cursor row is not fully visible
190 after recentering, and scroll-conservatively is set to a large
191 number, scroll window by a few more lines to make the cursor fully
192 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
193 (start_display): Don't move to the next line if the display should
194 start at a newline that is part of a display vector or an overlay
195 string. (Bug#10119)
8c535114 196
fa4fdb5c
JL
1972011-11-24 Juri Linkov <juri@jurta.org>
198
199 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
200 after the `MagickPingImage' call. (Bug#10112)
201
90ec88df
CY
2022011-11-23 Chong Yidong <cyd@gnu.org>
203
204 * window.c (Fcoordinates_in_window_p): Accept only live windows.
205
56e2e794
MR
2062011-11-23 Martin Rudalics <rudalics@gmx.at>
207
208 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
209 making another buffer current. (Bug#10114)
210
b6e64c41
GM
2112011-11-23 Glenn Morris <rgm@gnu.org>
212
213 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
214
6b21de18
CY
2152011-11-23 Chong Yidong <cyd@gnu.org>
216
217 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
218 using it (Bug#5984).
219
b12cd789
EZ
2202011-11-22 Eli Zaretskii <eliz@gnu.org>
221
222 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
223 and header-lines, as they don't have one computed for them.
224 (Bug#10098)
225
226 * .gdbinit (prow): Make displayed values more self-explaining.
227 Add row's hash code.
228
261b6fd4
LMI
2292011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
230
231 * process.c (wait_reading_process_output): Fix asynchrounous
232 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 233 (wait_reading_process_output): Add comment and URL.
261b6fd4 234
e7cfd277
JD
2352011-11-21 Jan Djärv <jan.h.d@swipnet.se>
236
237 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
238
a9b9b7f5
CY
2392011-11-21 Chong Yidong <cyd@gnu.org>
240
241 * window.c (Fnext_window, Fprevious_window): Doc fix.
242
b0d15b4f
SM
2432011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
244
245 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
246
fe7a3057
JB
2472011-11-20 Juanma Barranquero <lekktu@gmail.com>
248
249 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
250
d2999b1a
MR
2512011-11-20 Martin Rudalics <rudalics@gmx.at>
252
253 * window.c (Fset_window_combination_limit): Rename argument
254 STATUS to LIMIT.
255 (Vwindow_combination_limit): Remove "status" from doc-string.
256
d5ff9cd0
AS
2572011-11-20 Andreas Schwab <schwab@linux-m68k.org>
258
259 * m/ibms390.h: Remove.
260 * m/ibms390x.h: Don't include "ibms390.h".
261
a5bb9bd3
SM
2622011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
263
264 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
265 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
266
cd1181db
JB
2672011-11-20 Juanma Barranquero <lekktu@gmail.com>
268
269 * casetab.c (Fset_case_table):
270 * charset.c (Fcharset_after): Fix typos.
271
615a3b8d 2722011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 273
17e845af
PE
274 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
275 Otherwise, valgrind does not work on some platforms.
276 Problem reported by Andreas Schwab in
6a0bf43d
PE
277 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
278 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
279 is set, removing the need for VIRT_ADDRESS_VARIES.
280 (PURE_P): Use a more-efficient implementation that needs just one
281 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
282 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
283 to 4 (xorl, subq, cmpq, setbe).
284 * alloc.c (pure): Always extern now, since that's the
285 VIRT_ADDR_VARIES behavior.
286 (PURE_POINTER_P): Use a single comparison, not two, for
287 consistency with the new puresize.h.
288 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
289 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
290 Remove VIRT_ADDR_VARIES no longer needed.
291
f8fe6f96
EZ
2922011-11-19 Eli Zaretskii <eliz@gnu.org>
293
294 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
295 (erase_phys_cursor, update_window_cursor, show_mouse_face)
296 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
297 behave as if the cursor position were at the window margin.
298
299 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
300 and the cursor position is out of bounds, behave as if the cursor
301 position were at the window margin. (Bug#10075)
302
df05a53c
CY
3032011-11-18 Chong Yidong <cyd@gnu.org>
304
305 * window.c (Fwindow_combination_limit): Make first argument
306 non-optional, since it is meaningless for live windows like the
307 selected window.
308
2071918e
DA
3092011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
310
311 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
312
b50a28de
SM
3132011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
314
315 * intervals.c: Fix grafting over the whole buffer (bug#10071).
316 (graft_intervals_into_buffer): Simplify.
317
015137db
EZ
3182011-11-18 Eli Zaretskii <eliz@gnu.org>
319
320 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
321 hash values of the two rows.
322 (copy_row_except_pointers): Preserve the used[] arrays and the
323 hash values of the two rows. (Bug#10035)
68c95424 324 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
325
326 * xdisp.c (row_hash): New function, body extracted from
327 compute_line_metrics.
328 (compute_line_metrics): Call row_hash, instead of computing the
329 hash code inline.
330
331 * dispnew.c (verify_row_hash): Call row_hash for computing the
332 hash code of a row, instead of duplicating code from xdisp.c.
333
334 * dispextern.h (row_hash): Add prototype.
335
a2addb04
TH
3362011-11-18 Tassilo Horn <tassilo@member.fsf.org>
337
338 * frame.c (delete_frame): Don't delete the terminal when the last
339 X frame is closed if emacs is built with GTK toolkit.
340
df85d315
JB
3412011-11-17 Juanma Barranquero <lekktu@gmail.com>
342
343 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
344
a0c2d0ae
MR
3452011-11-17 Martin Rudalics <rudalics@gmx.at>
346
347 * window.c (Vwindow_splits): Rename to
348 Vwindow_combination_resize. Suggested by Juri Linkov.
349 (Fsplit_window_internal): Use Vwindow_combination_resize instead
350 of Vwindow_splits.
351
58179cce
JB
3522011-11-16 Juanma Barranquero <lekktu@gmail.com>
353
7877f373
JB
354 * nsfns.m (Fns_font_name):
355 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 356
b6f67890
MR
3572011-11-16 Martin Rudalics <rudalics@gmx.at>
358
359 * window.h (window): Rename slot "nest" to "combination_limit".
360 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
361 (Fset_window_nest): Rename to Fset_window_combination_limit.
362 (Vwindow_nest): Rename to Vwindow_combination_limit.
363 (recombine_windows, make_parent_window, make_window)
364 (Fsplit_window_internal, saved_window)
365 (Fset_window_configuration, save_window_save): Rename all
366 occurrences of window_nest to window_combination_limit.
367
c7015153
JB
3682011-11-15 Juanma Barranquero <lekktu@gmail.com>
369
370 * image.c (imagemagick_load_image): Fix typo.
371
322ad6ec
EZ
3722011-11-14 Eli Zaretskii <eliz@gnu.org>
373
374 * xdisp.c (display_line): Move the call to
375 highlight_trailing_whitespace before the call to
376 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
377 faces of all the glyphs to compute ROW's hash value.
378 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 379
f067b8ec
JB
3802011-11-14 Juanma Barranquero <lekktu@gmail.com>
381
382 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
383 just return (bug#10044).
384
1e5b2111
EZ
3852011-11-12 Eli Zaretskii <eliz@gnu.org>
386
7ef3cbd5
EZ
387 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
388 with user-defined heap size. Bump the default size of the temacs
389 heap to 27MB, to avoid memory warning when running temacs.
390 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
391
1e5b2111
EZ
392 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
393 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
394 (verify_row_hash) [XASSERTS]: New function.
395 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
396 that the hash value of glyph rows is correct.
1e5b2111 397
89d61221
MR
3982011-11-12 Martin Rudalics <rudalics@gmx.at>
399
400 * window.h (window): Remove splits slot.
401 * window.c (Fwindow_splits, Fset_window_splits): Remove.
402 (Fdelete_other_windows_internal, make_parent_window)
403 (make_window, Fsplit_window_internal, Fdelete_window_internal)
404 (Fset_window_configuration, save_window_save): Don't deal with
405 split status of windows.
406 (saved_window): Remove splits slot.
407 (Vwindow_splits): Rewrite doc-string.
408
97f18cc8
JD
4092011-11-11 Jan Djärv <jan.h.d@swipnet.se>
410
411 * xfns.c (unwind_create_frame):
412 * nsfns.m (unwind_create_frame):
413 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
414 Vframe_list (Bug#9999).
415
22a648b4
DA
4162011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
417
0b381c7e 418 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 419
659afede
KH
4202011-11-11 Kenichi Handa <handa@m17n.org>
421
422 * callproc.c (Fcall_process): Set the member dst_multibyte of
423 process_coding.
424
9ac0394b
KH
4252011-11-11 Johan Bockgård <bojohan@gnu.org>
426
427 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
428 avoid a crash (bug#9496).
429
2fbdc249
CY
4302011-11-09 Chong Yidong <cyd@gnu.org>
431
432 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
433 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
434
ac6b1f81
PE
4352011-11-08 Paul Eggert <eggert@cs.ucla.edu>
436
437 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
438
09db192c
PE
4392011-11-08 Paul Eggert <eggert@cs.ucla.edu>
440
441 Avoid some portability problems by eschewing 'extern inline' functions.
442 The trivial performance wins aren't worth the portability hassles; see
443 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
444 et seq.
445 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
446 (window_box_width, window_box_left, window_box_left_offset)
447 (window_box_right, window_box_right_offset): Undo previous change,
448 by removing the "extern"s.
449 * intervals.c (adjust_intervals_for_insertion)
450 (adjust_intervals_for_deletion): Undo previous change,
451 making these static again.
452 (offset_intervals, temp_set_point_both, temp_set_point)
453 (copy_intervals_to_string): No longer inline.
454 * xdisp.c (window_text_bottom_y, window_box_width)
455 (window_box_height, window_box_left_offset)
456 (window_box_right_offset, window_box_left, window_box_right)
457 (window_box): No longer inline.
458
105216ed
CY
4592011-11-08 Chong Yidong <cyd@gnu.org>
460
461 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
462 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
463 Signal an error if not a live window.
105216ed
CY
464 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
465 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
466
ae9e237f
JB
4672011-11-07 Juanma Barranquero <lekktu@gmail.com>
468
469 * lisp.h (syms_of_abbrev): Remove declaration.
470 Reported by CHENG Gao <chenggao@royau.me>.
471
c7aa8333
EZ
4722011-11-07 Eli Zaretskii <eliz@gnu.org>
473
474 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
475 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
476 of temacs in GUI mode.
477
be7f5545
MR
4782011-11-07 Martin Rudalics <rudalics@gmx.at>
479
480 * window.h: Declare delete_all_child_windows instead of
481 delete_all_subwindows.
482 * window.c (Fwindow_nest, Fset_window_nest)
483 (Fset_window_new_total, Fset_window_new_normal)
484 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
485 (delete_all_subwindows): Rename to delete_all_child_windows.
486 (Fdelete_other_windows_internal, Fset_window_configuration):
487 Call delete_all_child_windows instead of delete_all_subwindows.
488 * frame.c (delete_frame): Call delete_all_child_windows instead
489 of delete_all_subwindows.
490
ca78dc43
PE
4912011-11-07 Paul Eggert <eggert@cs.ucla.edu>
492
493 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
494 This is also needed for porting to any host where GC_MARK_STACK is
495 not GC_MAKE_GCPROS_NOOPS.
496 (which_symbols): Use it.
497
a0241d01
KH
4982011-11-07 Kenichi Handa <handa@m17n.org>
499
500 * coding.c (coding_set_destination): Check coding->src_pos only
501 when coding->src_object is a buffer (bug#9910).
502
503 * process.c (send_process): Set the member src_multibyte of coding
504 to 0 (bug#9911) when sending a unibyte text.
505
506 * callproc.c (Fcall_process): Set the member src_multibyte of
507 process_coding to 0 (bug#9912).
508
a64bfdfa 5092011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
510
511 * xmenu.c (cleanup_widget_value_tree): New function.
512 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
513 calling free_menubar_widget_value_tree directly (Bug#9830).
514
cb41b32a
PE
5152011-11-06 Paul Eggert <eggert@cs.ucla.edu>
516
517 Fix some portability problems with 'inline'.
518 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
519 (window_box_width, window_box_left, window_box_left_offset)
520 (window_box_right, window_box_right_offset): Declare extern.
521 Otherwise, these inline functions do not conform to C99 and
522 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
523 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
524 * intervals.c (adjust_intervals_for_insertion)
525 (adjust_intervals_for_deletion): Now extern, because otherwise the
526 extern inline functions 'offset_intervals' couldn't refer to it.
527 (static_offset_intervals): Remove.
528 (offset_intervals): Rewrite using the old contents of
529 static_offset_intervals. The old version didn't conform to C99
530 because an extern inline function contained a reference to an
531 identifier with static linkage.
532
b7041366
AS
5332011-11-06 Andreas Schwab <schwab@linux-m68k.org>
534
535 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
536 GC.
537
88a37c4d
EZ
5382011-11-06 Eli Zaretskii <eliz@gnu.org>
539
540 * xdisp.c (init_iterator, reseat_to_string): Don't set the
541 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
542 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
543 return Qleft_to_right.
544
49745b39
CY
5452011-11-06 Chong Yidong <cyd@gnu.org>
546
547 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
548 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
549 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
550 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
551 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
552 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
553 (Fwindow_vscroll): Doc fix.
554 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
555 argument, since it makes no sense to pass a live window and for
556 consistency with window-child.
557
1f05cd82
CS
5582011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
559
560 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
561 support MSVC.
562
22610910
JR
5632011-11-05 Jason Rumney <jasonr@gnu.org>
564
565 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
566 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
567 fonts (Bug#6029).
568 (add_font_entity_to_list): Fix logic errors in mixed boolean and
569 bitwise arithmetic preventing use of unicode-sip and non-truetype
570 opentype fonts.
571
a06776b2
EZ
5722011-11-05 Eli Zaretskii <eliz@gnu.org>
573
3ad924ba
EZ
574 * s/ms-w32.h (fstat, stat, utime): Move redirections to
575 "emacs"-only part.
576
a06776b2
EZ
577 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
578 initialization code to keep similarity to xfns.c after changes
579 from 2011-11-05.
580
c9e7db78
JD
5812011-11-05 Jan Djärv <jan.h.d@swipnet.se>
582
a97f8f3f
JD
583 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
584 (unwind_create_frame): New function (Bug#9943).
585 (Fx_create_frame): Restructure code to be more similar to the one in
586 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
587 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
588 Move terminal->reference_count++ just before making the frame official
589 (Bug#9943).
590
591 * nsterm.m (x_free_frame_resources): New function.
592 (x_destroy_window): Move code to x_free_frame_resources.
593
c9e7db78 594 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
595 (Fx_create_frame, x_create_tip_frame):
596 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
597 official. Move initialization of image_cache_refcount and
598 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
599
a6fc3b5c
EZ
6002011-11-05 Eli Zaretskii <eliz@gnu.org>
601
602 Support MSVC build with newer versions of Visual Studio.
603 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
604 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
605 nt/gmake.defs.
606
607 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
608 which are not supported by MSVC.
609 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
610 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
611 bitfields.
612 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
613 types in bitfields.
614 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
615
616 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
617
58179cce 6182011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
619
620 Support MSVC build with newer versions of Visual Studio.
621 * w32.c: Don't include w32api.h for MSVC.
622 (init_environment) [_MSC_VER]: Call sys_access, not _access.
623
624 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
625 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
626 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
627 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
628 e_* cousins.
629 (alloca) [_MSC_VER]: Define to _alloca.
630
631 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
632
633 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
634
a58c13ed
EZ
6352011-11-04 Eli Zaretskii <eliz@gnu.org>
636
637 * xdisp.c (note_mouse_highlight): If either of
638 previous/next-single-property-change returns nil, treat that as
639 the beginning or the end of the buffer. (Bug#9955)
640
fe0b6370
JD
6412011-11-04 Jan Djärv <jan.h.d@swipnet.se>
642
a58c13ed 643 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
644 label is not null (Bug#9951).
645 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
646 may be NULL.
647
89bd5ee1
EZ
6482011-11-04 Eli Zaretskii <eliz@gnu.org>
649
650 * window.c (Fwindow_body_size): Mention in the doc string that the
651 return value is in frame's canonical units. (Bug#9949)
652
84c3edb9
EZ
6532011-11-03 Eli Zaretskii <eliz@gnu.org>
654
4e2fb5c7
EZ
655 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
656
84c3edb9 657 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 658 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 659 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 660
bc17a887
EZ
6612011-11-01 Eli Zaretskii <eliz@gnu.org>
662
663 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
664 Don't stop backward scan on the continuation glyph, even though
665 its CHARPOS is positive.
6d5eb5b0
SM
666 (mouse_face_from_buffer_pos, note_mouse_highlight):
667 Rename cover_string to disp_string.
bc17a887 668
4ee88440
MR
6692011-11-01 Martin Rudalics <rudalics@gmx.at>
670
671 * window.c (temp_output_buffer_show): Don't use
672 Vtemp_buffer_show_specifiers.
673 (Vtemp_buffer_show_specifiers): Remove unused variable.
674
c2ff3c02
EZ
6752011-10-30 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
678 past the beginning of the current glyph matrix.
679
58179cce 6802011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
681
682 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
683 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
684 HAVE_GTK3 (Bug#9869).
b77a6a7f 685
3b574623
JD
686 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
687 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
688
b77a6a7f
JD
689 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
690
691 * xterm.c: Declare x_handle_net_wm_state to return int.
692 (handle_one_xevent): Check if we are iconified but don't have
693 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
694 (get_current_wm_state): Return non-zero if not hidden,
695 check for _NET_WM_STATE_HIDDEN (Bug#9893).
696 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
697 (x_handle_net_wm_state): Return what get_current_wm_state returns.
698 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
699
196e41e4
PE
7002011-10-29 Paul Eggert <eggert@cs.ucla.edu>
701
702 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
703 so that this new function doesn't get optimized away by a
704 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
705
021f2e1a
AS
7062011-10-29 Andreas Schwab <schwab@linux-m68k.org>
707
708 * frame.h (MOUSE_HL_INFO): Remove excess parens.
709
8b058d44
EZ
7102011-10-29 Eli Zaretskii <eliz@gnu.org>
711
712 Fix the `xbytecode' command.
713 * .gdbinit (xprintbytestr): New command.
b50a28de 714 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
715 (xbytecode): Print the byte-code string as well.
716
4452fb80
EZ
7172011-10-29 Kim Storm <storm@cua.dk>
718
8b058d44
EZ
719 * alloc.c (which_symbols): New function.
720
21b72067
AS
7212011-10-29 Andreas Schwab <schwab@linux-m68k.org>
722
723 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
724 line. (Bug#9903)
725
83ed7b5c
GM
7262011-10-29 Glenn Morris <rgm@gnu.org>
727
728 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
729 Not clear what it was for, and it causes various bugs. (Bug#9839)
730
5a7a728b
EZ
7312011-10-28 Eli Zaretskii <eliz@gnu.org>
732
733 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
734 possible random value that matches one of those tested as
735 condition to clear the mouse face.
736
d3d0842f
CY
7372011-10-28 Chong Yidong <cyd@gnu.org>
738
739 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
740
31b39d13
DN
7412011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
742
743 * window.c (make_window): Initialize phys_cursor_on_p.
744
9aba6043
SM
7452011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
746
747 * lisp.h (struct Lisp_Symbol): Update comments.
748
c20992f4
JB
7492011-10-28 Juanma Barranquero <lekktu@gmail.com>
750
751 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
752
db4f02f2
EZ
7532011-10-28 Eli Zaretskii <eliz@gnu.org>
754
755 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
756 <oslsachem@gmail.com> for helping to debug this.
757
758 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
759 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
760 (g_b_init_get_glyph_outline_w): New static variables.
761 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
762 (GetGlyphOutlineW_Proc): New typedefs.
763 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
764 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
765 New functions.
766 (w32font_open_internal, compute_metrics):
767 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
768 instead of calling the "wide" APIs directly.
769
770 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
771
772 * w32.h (syms_of_w32font): Add prototype.
773
87e68db4
JB
7742011-10-27 Juanma Barranquero <lekktu@gmail.com>
775
776 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
777 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
778 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
779 (Fmove_to_window_line): Doc fix.
780
435c1d67
CY
7812011-10-27 Chong Yidong <cyd@gnu.org>
782
783 * process.c (make_process): Set gnutls_state to NULL.
784
785 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
786 non-NULL, regardless of GNUTLS_INITSTAGE.
787 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
788 an error. Set process slots as soon as we allocate them.
789
790 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
791
9c6c6f49
CY
7922011-10-27 Chong Yidong <cyd@gnu.org>
793
9aba6043
SM
794 * gnutls.c (emacs_gnutls_deinit): New function.
795 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
796 (Fgnutls_deinit, Fgnutls_boot): Use it.
797
798 * process.c (make_process): Initialize GnuTLS credentials to NULL.
799 (deactivate_process): Call emacs_gnutls_deinit.
800
657d08d3
JB
8012011-10-27 Juanma Barranquero <lekktu@gmail.com>
802
803 * image.c (x_create_x_image_and_pixmap):
804 * w32.c (sys_rename, w32_delayed_load):
805 * w32font.c (fill_in_logfont):
806 * w32reg.c (x_get_string_resource): Silence compiler warnings.
807
5430d399
JB
8082011-10-26 Juanma Barranquero <lekktu@gmail.com>
809
810 * w32fns.c (w32_default_color_map): New function,
811 extracted from Fw32_default_color_map.
a7ef684b 812 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 813
fe0055fa
PE
8142011-10-25 Paul Eggert <eggert@cs.ucla.edu>
815
816 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
817
e6346438
SM
8182011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
819
820 * keyboard.c (test_undefined): New function (bug#9751).
821 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
822
e112cc37
ET
8232011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
824
825 * sysdep.c (init_sys_modes): Fix the check for the controlling
826 terminal (Bug#6649).
827
7b5d6677
EZ
8282011-10-20 Eli Zaretskii <eliz@gnu.org>
829
830 * dispextern.h (struct bidi_it): New member next_en_type.
831
832 * bidi.c (bidi_line_init): Initialize the next_en_type member.
833 (bidi_resolve_explicit_1): When next_en_pos is valid for the
834 current character, check also for next_en_type being WEAK_EN.
835 (bidi_resolve_weak): Don't enter the expensive loop if the current
836 position is before next_en_pos. Record the bidi type of the first
837 non-ET, non-BN character we find, in addition to its position.
838 (bidi_level_of_next_char): Invalidate next_en_type when
839 next_en_pos is over-stepped.
840
7da0b018
PE
8412011-10-20 Paul Eggert <eggert@cs.ucla.edu>
842
843 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
844 * editfns.c: Rewrite current-time-zone so that it invokes
845 the equivalent of (format-time-string "%Z") to get the time zone name.
846 This fixes a bug when the time zone name contains characters that
847 need converting from the system time locale to Emacs internal format.
848 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
849 that patch fixed format-time-string to do the conversion, but
850 I forgot to fix current-time-zone.
851 (format_time_string): New function, containing most of
852 what Fformat_time_string used to contain.
853 (Fformat_time_string): Rewrite in terms of format_time_string.
854 This doesn't change this function's behavior.
855 (current-time-zone): Rewrite to use format_time_string.
856 This fixes the bug reported by Michael Schierl in
857 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
858 Jason Rumney's 2007-06-07 change worked around this bug, but
859 didn't fix it.
860 * systime.h (tzname, timezone): Remove no-longer-used declarations.
861
8547b010
EZ
8622011-10-19 Eli Zaretskii <eliz@gnu.org>
863
864 * xdisp.c (start_display): If the character at POS is displayed
865 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
866 (try_window_reusing_current_matrix): If a line ends in a display
867 vector or the next line starts in a display vector, continue
868 redrawing the window even though the character position of
869 start_row was reached.
8547b010
EZ
870 (Bug#9771, part 2)
871
4e948d15
CY
8722011-10-18 Chong Yidong <cyd@gnu.org>
873
874 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
875 with nobreak-char-display too.
876
4787455f
EZ
8772011-10-18 Eli Zaretskii <eliz@gnu.org>
878
879 Fix part 3 of bug#9771.
880 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
881 (bidi_resolve_neutral): Don't enter the expensive loop looking for
882 non-neutral characters if the current character is a paragraph
883 separator (a.k.a. Newline). This avoids running the same
884 expensive loop twice, once when we consume the preceding newline
885 and the other time when the line actually needs to be displayed.
886 Avoid the loop when we see neutrals on the base embedding level
887 following a character whose directionality is the same as the
888 paragraph's. This avoids running the expensive loop when a line
889 ends in a long sequence of neutrals, like control characters.
890 Add assertion against STRONG_AL type. Slightly rearrange code
891 that determines the type of a neutral given the first non-neutral
892 that follows it.
893 (bidi_level_of_next_char): Set next_en_pos to zero when
894 invalidating its info.
895
2c91f553
EZ
8962011-10-17 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (push_display_prop): Determine whether to record string
899 or buffer position by IT->string, not by IT->method. Allow
900 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
901 (move_it_vertically_backward): Don't look for character position
902 immediately after the newline when in a continuation line.
903 (Bug#9771, part 1)
2c91f553 904
c7b08b0d
MR
9052011-10-15 Martin Rudalics <rudalics@gmx.at>
906
907 * window.c (coordinates_in_window): Rewrite and delabelize
908 vertical border check. (Bug#5357) (Bug#9618)
909
6b02f655
SM
9102011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
911
912 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
913 errors in XSetWindowBorder (bug#9310).
914
81d40c92
DA
9152011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
916
917 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
918 avoid crash when xmalloc overrun checking is enabled.
919
d4172c3b
EZ
9202011-10-13 Eli Zaretskii <eliz@gnu.org>
921
922 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
923 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
924 cursor motion with <left> and <right> arrow keys.
925
926 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
927 some callers set that themselves.
928
b00eea75
EZ
9292011-10-12 Eli Zaretskii <eliz@gnu.org>
930
931 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
932 display string and the previous row comes from the same string and
933 is empty. (Bug#9739) (Bug#9738)
934
8fe012c4
SM
9352011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 * doc.c (get_doc_string): Encode file name (bug#9735).
938
0074aef2
EZ
9392011-10-12 Eli Zaretskii <eliz@gnu.org>
940
79beb178
EZ
941 * bidi.c (bidi_level_of_next_char):
942 * xdisp.c (get_visually_first_element): Remove old incorrect
943 comments regarding the Unicode Line Separator character.
944
0074aef2
EZ
945 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
946
6e4b3fbe
DA
9472011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
948
949 * alloc.c (Fgc_status): Do not access beyond zombies array
950 boundary if nzombies > MAX_ZOMBIES.
951 * alloc.c (dump_zombies): Add missing format specifier.
952
0324f3af
PE
9532011-10-12 Paul Eggert <eggert@cs.ucla.edu>
954
b5525cac
PE
955 * xdisp.c (set_cursor_from_row): Simplify conditionals,
956 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
957
0324f3af
PE
958 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
959 Some packages use them to denote characters with modifiers.
960
e9b5f888
AS
9612011-10-11 Andreas Schwab <schwab@linux-m68k.org>
962
963 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
964 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
965 matching a pp-number. Rename parameter var to var1.
966
127827c0
SM
9672011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
968
969 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
970
c8fd3bd0
GM
9712011-10-08 Glenn Morris <rgm@gnu.org>
972
973 * callint.c (Fcall_interactively): Give a more explicit error for the
974 'c' case with a non-character input. (Bug#8479)
975
352ec8ff
EZ
9762011-10-08 Eli Zaretskii <eliz@gnu.org>
977
03669ccb
EZ
978 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
979 lines.
7061c986
EZ
980 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
981 lines that are hscrolled on the left.
03669ccb 982
352ec8ff
EZ
983 * dispnew.c (buffer_posn_from_coords): Account for a possible
984 presence of header-line. (Bug#4426)
985
a66cfb1c
SM
9862011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
987
6b02f655
SM
988 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
989 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 990
7c5ee88e
PE
9912011-10-07 Paul Eggert <eggert@cs.ucla.edu>
992
993 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
994 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
995 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
996 this makes Emacs dump core during garbage collection on rare
997 occasions. sizeof is obviously inferior to offsetof here, so
998 stick with offsetof.
999 (GC_POINTER_ALIGNMENT): New macro.
1000 (mark_memory): Omit 3rd (offset) arg; caller changed.
1001 Don't assume EMACS_INT alignment is the same as pointer alignment.
1002
df1bbe5b
SM
10032011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1004
1005 * keyboard.c (read_key_sequence_remapped): New var.
1006 (read_key_sequence): Compute remapping in the right buffer.
1007 (command_loop_1): Use read_key_sequence's remapping directly.
1008
51553db6
SM
10092011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1010
32c1fffd
SM
1011 * dired.c (file_name_completion): Don't expand file name.
1012 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1013 before checking file name handler.
1014
51553db6
SM
1015 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1016 they've been requested explicitly (bug#9591).
1017
b6bd1599 10182011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1019
1020 * keymap.c (Fsingle_key_description): Use make_specified_string
1021 instead of build_string to build string from push_key_description.
1022 (Bug#5193)
1023
f701dc2a
PE
10242011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1025
4222c55d
PE
1026 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1027 This fixes a Y2038 bug on 64-bit hosts.
1028 * buffer.c (reset_buffer):
1029 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1030 (Fclear_buffer_auto_save_failure):
1031 Use 0, not -1, to represent an unset failure time, since time_t
1032 might not be signed.
1033
f701dc2a
PE
1034 Remove dependency on glibc malloc internals.
1035 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1036 Move back here from lisp.h, but with their new implementations.
1037 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1038 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1039 * charset.c (charset_table_init): New static var.
1040 (syms_of_charset): Use it instead of xmalloc. This removes a
1041 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1042 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1043 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1044 Move back to alloc.c.
1045 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1046 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1047
9ceebf39
JD
10482011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1049
1050 * nsterm.m (windowDidResize): Call x_set_window_size only when
1051 ns_in_resize is true. Otherwise set pixelwidth/height and
1052 call change_frame_size (Bug#9628).
1053
cb993c58
PE
10542011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1055
3930c88b
PE
1056 Port --enable-checking=all to Fedora 14 x86-64.
1057 * charset.c (syms_of_charset): Also account for glibc malloc's
1058 internal overhead when calculating the initial malloc maximum.
1059
cb993c58
PE
1060 Port --enable-checking=all to Fedora 14 x86.
1061 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1062 Move to lisp.h.
1063 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1064 (overrun_check_realloc, overrun_check_free):
1065 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1066 That way, xmalloc returns a properly-aligned pointer even if
1067 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1068 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1069 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1070 into account when calculating the initial malloc maximum.
1071 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1072 Move here from alloc.c, so that charset.c can use it too.
1073 Properly align; the old code wasn't right for common 32-bit hosts
1074 when configured with --enable-checking=all.
1075 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1076 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1077
31bed486
EZ
10782011-09-29 Eli Zaretskii <eliz@gnu.org>
1079
04c70788 1080 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1081 use EDOM.
1082
fbcaa2f3
EZ
10832011-09-28 Eli Zaretskii <eliz@gnu.org>
1084
1085 * xdisp.c (compute_display_string_end): If there's no display
1086 string at CHARPOS, return -1.
1087
1088 * bidi.c (bidi_fetch_char): When compute_display_string_end
1089 returns a negative value, treat the character as a normal
1090 character not covered by a display string. (Bug#9624)
1091
a239d4e9
JB
10922011-09-28 Juanma Barranquero <lekktu@gmail.com>
1093
1094 * lread.c (Fread_from_string): Fix typo in docstring.
1095
88652fd5
EZ
10962011-09-27 Eli Zaretskii <eliz@gnu.org>
1097
1098 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1099 newline, reseat the iterator instead of bidi-iterating there one
1100 character at a time. (Bug#9610)
32c1fffd
SM
1101 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1102 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1103
ed497dd4
AS
11042011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1105
1106 * lread.c (readevalloop): Use correct code for NBSP.
1107 (read1): Likewise. (Bug#9608)
1108
b2bf61aa
MA
11092011-09-25 Michael Albinus <michael.albinus@gmx.de>
1110
1111 * dbusbind.c (Fdbus_register_signal): When service is not
1112 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1113
32bbb17c
GM
11142011-09-25 Glenn Morris <rgm@gnu.org>
1115
1116 * buffer.c (truncate-lines): Doc fix.
1117
94e0933e
CY
11182011-09-24 Chong Yidong <cyd@stupidchicken.com>
1119
1120 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1121 (Fset_window_next_buffers): Doc fix.
1122
cddde921
GM
11232011-09-24 Glenn Morris <rgm@gnu.org>
1124
1125 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1126
1260aef1
PE
11272011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1128
25b4bfa0
PE
1129 Fix minor problems found by static checking.
1130 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1131 * indent.c (Fvertical_motion): Fix == vs = typo.
1132
e3cbd34b
EZ
11332011-09-24 Eli Zaretskii <eliz@gnu.org>
1134
a66cfb1c
SM
1135 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1136 Default value is now t. Doc fix.
6bf7006f 1137
e3cbd34b 1138 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1139 logic when moving up, not only when moving down. Fix the
e3cbd34b 1140 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1141 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1142
1143 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1144 CHARPOS is covered by a display string which includes newlines.
1145 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1146 is covered by a display string with embedded newlines.
1147
a3de0cbd
MA
11482011-09-24 Michael Albinus <michael.albinus@gmx.de>
1149
1150 * dbusbind.c (Fdbus_register_signal): Add match rule to
1151 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1152 (Fdbus_register_method, Vdbus_registered_objects_table):
1153 Fix docstring.
a3de0cbd 1154
b260039d
JM
11552011-09-24 Jim Meyering <meyering@redhat.com>
1156
32c1fffd 1157 do not ignore write error for any output size
b260039d
JM
1158 The previous change was incomplete.
1159 While it makes emacs --batch detect the vast majority of stdout
1160 write failures, errors were still ignored whenever the output size is
1161 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1162 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1163 && echo FAIL: ignored write error
1164 FAIL: ignored write error
1165 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1166 && echo FAIL: ignored write error
1167 FAIL: ignored write error
1168 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1169
8eca8a7c
AS
11702011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1171
1172 * emacs.c (Fkill_emacs): In noninteractive mode exit
1173 non-successfully if a write error occurred on stdout. (Bug#9574)
1174
3341db62
EZ
11752011-09-21 Eli Zaretskii <eliz@gnu.org>
1176
1177 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1178 the xassert test.
1179
1180 * dispextern.h (struct it): Update the comment documenting what
1181 can it->OBJECT be.
1182
8c203dbf
EZ
11832011-09-20 Eli Zaretskii <eliz@gnu.org>
1184
1185 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1186 a display string, extend search for cursor position to end of row.
1187 (find_row_edges): If the row ends in a newline from a display
1188 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1189 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1190 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1191 non-empty line. Fixes confusing cursor motion with arrow keys at
1192 the beginning of a line that starts with whitespace.
8c203dbf 1193
a4824228
LMI
11942011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1195
1196 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1197 (bug#9493).
1198
33ed493b
CY
11992011-09-18 Chong Yidong <cyd@stupidchicken.com>
1200
1201 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1202 boolean (Bug#9154).
1203
56cd55c8
EZ
12042011-09-18 Eli Zaretskii <eliz@gnu.org>
1205
1206 * xdisp.c (display_line): Record maximum and minimum buffer
1207 positions even if no glyphs were produced (e.g., by a zero-width
1208 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1209 buffer positions that will be removed from the glyph row because
1210 they don't fit.
c02dcedf
EZ
1211 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1212 column is beyond frame width: don't subtract 1 "pixel" when
1213 computing width of the stretch.
3e62b7e0
EZ
1214 (reseat_at_next_visible_line_start): Undo the change made on
1215 2011-09-17 that saved paragraph information and restored it after
1216 the call to `reseat'. (Bug#9545)
56cd55c8 1217
5ed99d36 12182011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1219
1220 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1221 and turn window cursor on if cleared (Bug#9415).
1222
5ed99d36 12232011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1224
1225 * search.c (boyer_moore): Take unibyte characters from pattern
1226 literally. (Bug#9458)
1227
9bade7b2
EZ
12282011-09-18 Eli Zaretskii <eliz@gnu.org>
1229
1230 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1231
e5e9d610
PE
12322011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1233
87e4427a
PE
1234 Fix minor problem found by static checking.
1235 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1236 initialized, to pacify gcc -Wuninitialized.
1237
e5e9d610
PE
1238 * fileio.c: Report proper errno when syscall falls.
1239 (Finsert_file_contents): Save and restore errno,
1240 so that report_file_error outputs the correct diagnostic.
1241 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1242
a1674f0b
EZ
12432011-09-18 Eli Zaretskii <eliz@gnu.org>
1244
1245 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1246
fbfb6dd4
EZ
12472011-09-17 Eli Zaretskii <eliz@gnu.org>
1248
1249 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1250 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1251
bb187662
EZ
12522011-09-17 Eli Zaretskii <eliz@gnu.org>
1253
1137e8b8 1254 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1255 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1256
1257 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1258 (bidi_find_paragraph_start): Search back for paragraph beginning
1259 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1260 (bidi_move_to_visually_next): Only trigger paragraph-related
1261 computations when the last character is a newline or at EOB, not
1262 just any NEUTRAL_B. (Bug#9470)
1263
bb187662
EZ
1264 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1265 truncated lines if point is covered by a display string. (Bug#9524)
1266
2e621251
PE
12672011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1270 (cons_to_x_long): New function.
1271 (lisp_data_to_selection_data): Use it. Correct the test for
1272 short-versus-long data; it was negated. Break out of vector
1273 loop, for efficiency, when a long datum is discovered.
1274
91a15bc6
SM
12752011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1276
1277 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1278
b41c3a35
EZ
12792011-09-16 Eli Zaretskii <eliz@gnu.org>
1280
1281 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1282 GCC PR/17406) by declaring this function with external scope.
1283
7812ba2d
PE
12842011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1287 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1288
cf7edc2a
AS
12892011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1290
1291 * editfns.c (Fformat): Correctly handle text properties on "%%".
1292
bd01620e
EZ
12932011-09-15 Eli Zaretskii <eliz@gnu.org>
1294
1295 * xterm.c (x_draw_composite_glyph_string_foreground):
1296 * w32term.c (x_draw_composite_glyph_string_foreground):
1297 * term.c (encode_terminal_code):
1298 * composite.c (composition_update_it, get_composition_id):
1299 * xdisp.c (get_next_display_element)
1300 (fill_composite_glyph_string): Add comments about special meaning
1301 of TAB characters in a composition.
1302
a02719a3
PE
13032011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1306 This occurs when processing a multibyte format.
1307 Problem reported by Wolfgang Jenker.
a02719a3 1308
72589a3c
JB
13092011-09-15 Johan Bockgård <bojohan@gnu.org>
1310
1311 * xdisp.c (try_cursor_movement): Only check for exact match if
1312 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1313
1c14176c
PE
13142011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 Remove unused external symbols.
1317 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1318 * xdisp.c (calc_pixel_width_or_height): Now static.
1319 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1320 * indent.c (check_display_width):
1321 * w32term.c: Fix comment to match code.
1322 * xterm.c, xterm.h (x_catching_errors): Remove.
1323
d2eea5b5
PE
13242011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 * xselect.c: Use signed conversions more consistently (Bug#9498).
1327 (selection_data_to_lisp_data): Assume incoming selection data are
1328 signed integers, not unsigned. This is to be consistent with
1329 outgoing selection data, which was modified to use signed integers
1330 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1331 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1332 expects long, not unsigned long.
1333
46888499
EZ
13342011-09-14 Eli Zaretskii <eliz@gnu.org>
1335
1336 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1337 computation of loop end. Reported by Johan Bockgård
1338 <bojohan@gnu.org>.
1339
ef8ef9fb
CY
13402011-09-13 Chong Yidong <cyd@stupidchicken.com>
1341
1342 * frame.c (Fother_visible_frames_p): Function deleted.
1343
fa819fed
EZ
13442011-09-12 Eli Zaretskii <eliz@gnu.org>
1345
1346 * indent.c (compute_motion): Process display vector front to back
1347 rather than the other way around. (Bug#2496)
1348
2ba8e008
SM
13492011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1350
1351 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1352
20f53c69
CY
13532011-09-11 Chong Yidong <cyd@stupidchicken.com>
1354
1355 * minibuf.c (Fread_from_minibuffer): Doc fix.
1356
d562d7a4
EZ
13572011-09-11 Eli Zaretskii <eliz@gnu.org>
1358
1359 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1360 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1361
1c4d7f3d
LMI
13622011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1363
1364 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1365 value for non-existent files.
1366
b885bf36
EZ
13672011-09-11 Eli Zaretskii <eliz@gnu.org>
1368
1369 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1370 set its "size" to -1. This will set the modtime_size field of
1371 the corresponding buffer to -1, which is what
1372 verify-visited-file-modtime expects for files that do not exist.
1373 (Bug#9139)
1374
6612f0bf
PE
13752011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1376
1377 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1378 here ...
1379 * lisp.h: ... from here. push_key_description is no longer
1380 defined in keyboard.c, so its declaration should not be in
1381 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1382 logically belongs with push_key_description.
1383
dfb3f755
PE
13842011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 * buffer.h: Include <sys/types.h> instead of <time.h>.
1387 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1388 Problem reported by Herbert J. Skuhra.
1389
3134906c
LMI
13902011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1391
1392 * xml.c (parse_region): Make the parsing work for
1393 non-comment-starting XML files again (bug#9144).
1394
8d903f4e
AS
13952011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1396
1397 * image.c (gif_load): Fix calculation of bottom and right corner.
1398 (Bug#9468)
1399
80ad64f4
EZ
14002011-09-10 Eli Zaretskii <eliz@gnu.org>
1401
1402 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1403 redisplay in small windows.
1404
208a048d
EZ
14052011-09-09 Eli Zaretskii <eliz@gnu.org>
1406
1407 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1408
9b1c252e
MR
14092011-09-08 Martin Rudalics <rudalics@gmx.at>
1410
1411 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1412 Operate on live windows only.
1413
2949f33b
JB
14142011-09-08 Juanma Barranquero <lekktu@gmail.com>
1415
1416 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1417
e08dcafd
EZ
14182011-09-07 Eli Zaretskii <eliz@gnu.org>
1419
1420 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1421 only under bidi iteration.
1422
115b96bd
JD
14232011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1424
1425 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1426
c8199d0f
PE
14272011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1428
1429 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1430 Without this fix, the command to link temacs failed due to an
1431 undefined symbol __builtin_isnan. This is because
1432 /usr/include/iso/math_c99.h #defines isnan(x) to
1433 __builtin_isnan(x), but the bundled gcc, which identifies itself
1434 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1435 a __builtin_isnan.
1436 * floatfns.c (isnan): #undef, and then #define to a clone of
1437 what's in data.c.
1438 (Fisnan): Always define, since it's always available now.
1439 (syms_of_floatfns): Always define isnan at the Lisp level.
1440
e39b275c 14412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1442
1443 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1444
b2db44d9 14452011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1446
f4af5137 1447 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1448 The previous code assumed that file offsets (off_t values) fit in
1449 EMACS_INT variables, which is not true on typical 32-bit hosts.
1450 The code messed up by falsely reporting buffer overflow in cases
1451 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1452 when "big" contains more than 2**29 bytes, even though this
1453 inserts just one byte and does not overflow the buffer.
1454 (Finsert_file_contents): Store file offsets as off_t
1455 values, not as EMACS_INT values. Check for overflow when
1456 converting between EMACS_INT and off_t. When checking for
1457 buffer overflow or for overlap, take the offsets into account.
1458 Don't use EMACS_INT for small values where int suffices.
1459 When checking for overlap, fix a typo: ZV was used where
1460 ZV_BYTE was intended.
1461 (Fwrite_region): Don't assume off_t fits into 'long'.
1462 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1463
ecfc0a49
MA
14642011-09-05 Michael Albinus <michael.albinus@gmx.de>
1465
1466 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1467
6511acf2 14682011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1469
0999621a 1470 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1471
1472 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1473 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1474 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1475 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1476 (modify_event_symbol): Do not assume that the length of
1477 name_alist_or_stem is safe to alloca and fits in int.
1478 (Fexecute_extended_command): Likewise for function name and binding.
1479 (Frecursion_depth): Wrap around reliably on integer overflow.
1480 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1481 since some callers pass EMACS_INT values.
1482 (Fsingle_key_description): Don't crash if symbol name contains more
1483 than MAX_ALLOCA bytes.
1484 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1485 (get_minibuffer): Arg is now EMACS_INT, not int.
1486 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1487 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1488 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1489
2be7d702
PE
1490 * dbusbind.c (signature_cat): New function.
1491 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1492 Do not overrun buffer; instead, report string overflow.
1493
9d1df220
PE
1494 * dispnew.c (add_window_display_history): Don't overrun buffer.
1495 Truncate instead; this is OK since it's just a log.
1496
33ef5c64
PE
1497 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1498 even if the time zone offset is outlandishly large.
1499 Don't mishandle offset == INT_MIN.
1500
66c6fdd5
PE
1501 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1502 when creating daemon; the previous buffer-overflow check was incorrect.
1503
d749b01b
PE
1504 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1505 which has the guts of the old verror function.
1506
b5cd1905
PE
1507 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1508 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1509
6e1a67fb
PE
1510 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1511 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1512 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1513 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1514 length of string rather than counting it via multiple sprintfs;
1515 that's simpler and more reliable.
c21721cc
PE
1516 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1517 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1518 sprintf, in case result does not fit in int.
1519
c57b67fc
PE
1520 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1521 (fontset_from_font): Print it.
1522
8a401434
PE
1523 * frame.c (tty_frame_count): Now printmax_t, not int.
1524 (make_terminal_frame, set_term_frame_name): Print it.
1525 (x_report_frame_params): In X, window IDs are unsigned long,
1526 not signed long, so print them as unsigned.
1527 (validate_x_resource_name): Check for implausibly long names,
1528 and don't assume name length fits in 'int'.
1529 (x_get_resource_string): Don't blindly alloca invocation name;
1530 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1531 not fit in int.
1532
6e1a67fb
PE
1533 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1534 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1535 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1536
0df02bf3
PE
1537 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1538 Use esprintf, not sprintf, in case result does not fit in int.
1539
48e30793
PE
1540 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1541 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1542 it as a large positive number.
1543 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1544 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1545
a66ff6d8
PE
1546 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1547 in case result does not fit in int.
1548
aca216ff
PE
1549 * print.c (float_to_string): Detect width overflow more reliably.
1550 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1551 buffer overrun. Don't assume list length fits in 'int'. Treat
1552 print length of 0 as 0, not as infinity; to be consistent with other
1553 uses of print length in this function. Don't overflow print length
1554 index. Don't assume hash table size fits in 'long', or that
1555 vectorlike size fits in 'unsigned long'.
1556
31c286f7
PE
1557 * process.c (make_process): Use printmax_t, not int, to format
1558 process-name gensyms.
1559
55e5faa1
PE
1560 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1561
80f2e268
PE
1562 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1563 to avoid potential buffer overrun.
1564
670741ab
PE
1565 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1566 if X resource line is longer than 512 bytes.
1567
b7163a50
PE
1568 * xfns.c (x_window): Make sprintf buffer a bit bigger
1569 to avoid potential buffer overrun.
1570
ae58ff1f
PE
1571 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1572
c43c8a6a
PE
1573 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1574
3f8236f4
PE
15752011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1576
53e9fe90 1577 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1578 Without these, Emacs silently mishandles large integers sometimes.
1579 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1580 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1581
6511acf2
PE
1582 * xdisp.c (try_window_id): Check Emacs fixnum range before
1583 converting to 'int'.
806add1d 1584
6511acf2 1585 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1586 Check that an Emacs fixnum is in range before assigning it to 'int'.
1587 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1588 values converted from Emacs fixnums.
1589 (Frecenter): Don't wrap around a line count if it is out of 'int'
1590 range; instead, treat it as an extreme value.
1591 (Fset_window_configuration, compare_window_configurations):
1592 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1593
6511acf2
PE
1594 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1595 that can exceed INT_MAX. Check that EMACS_INT value is in range
1596 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1597 (match_limit): Don't assume that a fixnum can fit in 'int'.
1598
6511acf2 1599 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1600 exceed INT_MAX.
1601
6511acf2 1602 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1603 (Fvertical_motion): Don't wrap around LINES values that don't fit
1604 in 'int'. Instead, treat them as extreme values. This is good
1605 enough for windows, which can't have more than INT_MAX lines anyway.
1606
fcb901a7
LMI
16072011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1608
0f2f6b6d
LMI
1609 * Require libxml/parser.h to avoid compilation warning.
1610
fcb901a7
LMI
1611 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1612
1613 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1614 since this reportedly can destroy thread storage.
1615
6e20a0d4
CY
16162011-08-30 Chong Yidong <cyd@stupidchicken.com>
1617
1618 * syntax.c (find_defun_start): Update all cache variables if
1619 exiting early (Bug#9401).
1620
148ae00e
EZ
16212011-08-30 Eli Zaretskii <eliz@gnu.org>
1622
f6cfbd8f
EZ
1623 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1624
148ae00e
EZ
1625 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1626 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1627 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1628
1629 * term.c (tty_append_glyph): New function.
1630 (produce_stretch_glyph): Static function and its prototype deleted.
1631
a66cfb1c
SM
1632 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1633 Add prototypes.
148ae00e 1634
c4a07a4c
PE
16352011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1638 when checking :margin (Bug#9390).
1639 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1640 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1641 so that the name doesn't mislead. All uses changed.
1642
6bc8cd65
JB
16432011-08-28 Johan Bockgård <bojohan@gnu.org>
1644
1645 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1646 set_tty_hooks.
1647
dca4927e
EZ
16482011-08-27 Eli Zaretskii <eliz@gnu.org>
1649
1650 * xdisp.c (move_it_to): Don't bail out early when reaching
1651 position beyond to_charpos, if we are scanning backwards.
1652 (move_it_vertically_backward): When DY == 0, make sure we get to
1653 the first character in the line after the newline.
1654
f2cad773
PE
16552011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1658 (ccl_driver): Do not generate an out-of-range pointer.
1659 (Fccl_execute_on_string): Remove unnecessary check for
1660 integer overflow, noted by Stefan Monnier in
1661 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1662 Remove a FIXME that didn't need fixing.
1663 Simplify the newly-introduced buffer reallocation code.
1664
0cae2cdb
JB
16652011-08-27 Juanma Barranquero <lekktu@gmail.com>
1666
1667 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1668
5fc295a4 16692011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1670
70c60eb2 1671 Integer and memory overflow issues (Bug#9196).
726e0ab1 1672
d31850da
PE
1673 * doc.c (get_doc_string): Rework so that
1674 get_doc_string_buffer_size is the actual buffer size, rather than
1675 being 1 less than the actual buffer size; this makes xpalloc more
1676 convenient.
1677
a69fbedb
PE
1678 * image.c (x_allocate_bitmap_record, cache_image):
1679 * xselect.c (Fx_register_dnd_atom):
1680 Simplify previous changes by using xpalloc.
1681
fe5c5d37
PE
1682 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1683 since either will do and ptrdiff_t is convenient with xpalloc.
1684
0065d054
PE
1685 * charset.c (charset_table_size)
1686 (struct charset_sort_data.priority): Now ptrdiff_t.
1687 (charset_compare): Don't overflow if priorities differ greatly.
1688 (Fsort_charsets): Don't assume list length fits in int.
1689 Check for size-calculation overflow when allocating sort data.
1690 (syms_of_charset): Allocate an initial charset table that is
1691 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1692
1693 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1694
1695 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1696 The actual value is always <= INT_MAX, and leaving it unsigned made
1697 overflow checking harder.
1698
1699 * dispextern.h (struct glyph_matrix.rows_allocated)
1700 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1701 with xpalloc. The values are still always <= INT_MAX.
1702
1703 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1704
1705 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1706 (SAFE_NALLOCA): New macro.
1707
1708 * region-cache.c (struct boundary.pos, find_cache_boundary)
1709 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1710 (set_cache_region, invalidate_region_cache)
1711 (revalidate_region_cache, know_region_cache, region_cache_forward)
1712 (region_cache_backward, pp_cache):
1713 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1714 so that ptrdiff_t * can be passed to xpalloc.
1715 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1716 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1717 (pp_cache): Don't assume cache_len fits in int.
1718 * region-cache.h: Adjust extern decls to match.
1719
1720 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1721 EMACS_INT, since either will do, for xpalloc.
1722
1723 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1724 (xnmalloc, xnrealloc, xpalloc): New functions.
1725
726e0ab1
PE
1726 * bidi.c (bidi_shelve_header_size): New constant.
1727 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1728 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1729
51f30bc5 1730 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1731 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1732 (overlay_strings):
1733 Don't update size of array until after memory allocation succeeds,
1734 because xmalloc/xrealloc may not return.
0065d054
PE
1735 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1736 now that we have proper integer overflow checking.
1737 (record_overlay_string, overlay_strings): Catch overflows when
1738 calculating size of overlay_str_buf.
726e0ab1 1739
0065d054
PE
1740 * callproc.c (Fcall_process): Check for size overflow when
1741 calculating size of args2.
1742 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1743 Normally we prefer signed values, but sticking with ptrdiff_t would
1744 require adding more-complicated checks.
726e0ab1
PE
1745
1746 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1747 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1748 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1749 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1750
1751 * character.c (Fstring): Check for size-calculation overflow.
1752
1753 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1754 unnecessary integer overflow. Check for size overflow.
1755 (encode_coding_object): Don't update size until xmalloc succeeds.
1756
1757 * composite.c (get_composition_id): Check for overflow in glyph
1758 length calculations.
1759
1760 Integer and memory overflow fixes for display code.
1761 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1762 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1763 (scrolling_window): Check for overflow in size calculations.
1764 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1765 Don't assume glyph table len fits in int.
1766 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1767 (row_table_size): Now ptrdiff_t, not int.
1768 (scrolling_window): Avoid overflow in size calculations.
1769 Don't update size until allocation succeeds.
1770 * fns.c (concat): Check for overflow in size calculations.
1771 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1772 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1773 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1774
1775 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1776 (get_doc_string): Check for size calculation overflow.
1777 Don't update size until allocation succeeds.
1778 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1779 EMACS_INT, where ptrdiff_t will do.
1780 (Fsubstitute_command_keys): Check for string overflow.
1781
1782 * editfns.c (set_time_zone_rule): Don't assume environment length
1783 fits in int.
1784 (message_length): Now ptrdiff_t, not int.
1785 (Fmessage_box): Don't update size until allocation succeeds.
1786 Don't assume message length fits in int.
1787 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1788
0065d054
PE
1789 * emacs.c (main): Do not reallocate argv, since there is a null at
1790 the end that can be overwritten, and this way there's no need to
1791 worry about size-calculation overflow.
1792 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1793
1794 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1795 alloc succeeds.
1796 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1797
1798 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1799 (x_set_scroll_bar_width, x_figure_window_size):
1800 Check for integer overflow.
1801 (x_set_alpha): Do not assume XINT fits in int.
1802
1803 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1804 This is for the members text_lines, text_cols, total_lines, total_cols,
1805 where the system imposes an 'int' limit.
1806
1807 * fringe.c (Fdefine_fringe_bitmap):
1808 Don't update size until alloc works.
1809
1810 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1811 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1812
1813 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1814 Check for size-calculation overflow.
1815 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1816 do, as we prefer signed integers.
1817 (id_to_widget.max_size, id_to_widget.used)
1818 (xg_store_widget_in_map, xg_remove_widget_from_map)
1819 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1820 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1821 Use and return ptrdiff_t, not int.
1822 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1823 * gtkutil.h: Change prototypes to match the above.
1824
1825 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1826 are duplicate now that they've been promoted to lisp.h.
1827 (x_allocate_bitmap_record, x_alloc_image_color)
1828 (make_image_cache, cache_image, xpm_load):
1829 Don't update size until alloc is done.
1830 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1831 (x_detect_edges):
3256efce 1832 Check for size calculation overflow.
726e0ab1
PE
1833 (ct_colors_allocated_max): New constant.
1834 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1835 overflow.
3256efce 1836
726e0ab1
PE
1837 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1838 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1839 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1840 Use ptrdiff_t, not int, to count maps.
1841 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1842 calculations. Don't update size until allocation succeeds.
1843 Redo calculations to avoid overflow.
726e0ab1
PE
1844 * keyboard.h: Change prototypes to match the above.
1845
1846 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1847 to count maps.
1848 (current_minor_maps): Check for size calculation overflow.
1849 * keymap.h: Change prototypes to match the above.
1850
1851 * lread.c (read1, init_obarray): Don't update size until alloc done.
1852
1853 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1854 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1855
726e0ab1
PE
1856 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1857 Now ptrdiff_t, not int.
1858 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1859 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1860
1861 * process.c (Fnetwork_interface_list): Check for overflow
1862 in size calculation.
1863
1864 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1865
1866 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1867 overflow. Don't bother calling xmalloc when xrealloc will do.
1868
1869 * search.c (Freplace_match): Check for size calculation overflow.
1870 (Fset_match_data): Don't assume list lengths fit in 'int'.
1871
1872 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1873 for command line length. Do not attempt to address one before the
1874 beginning of an array, as that's not portable.
1875
1876 * term.c (max_frame_lines): Remove; unused.
1877 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1878 not int.
1879 (encode_terminal_code, calculate_costs): Check for size
1880 calculation overflow.
1881 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1882 table lengths and related sizes. Don't update size until alloc
1883 done. Redo calculations to avoid overflow.
1884 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1885
1886 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1887 subtracting pointers.
1888 (gobble_line): Check for overflow more carefully. Don't update size
1889 until alloc done.
1890
1891 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1892 Don't update size until alloc done.
1893 Redo size calculations to avoid overflow.
1894 Check for size calculation overflow.
0065d054 1895 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1896
1897 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1898 Use ptrdiff_t, not int, for sizes.
1899 (store_mode_line_noprop_char): Don't update size until alloc done.
1900
0065d054
PE
1901 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1902 Use ptrdiff_t, not int, for sizes.
1903 (Finternal_make_lisp_face, cache_face):
1904 Check for size calculation overflow.
1905 (cache_face): Treat size calculation overflows as if they were
1906 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1907
1908 * xfns.c (x_encode_text, x_set_name_internal)
1909 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1910 sizes, since they can exceed INT_MAX in size. Check for size
1911 calculation overflow.
1912
0065d054
PE
1913 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1914 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1915 Don't update size until alloc done.
1916
0065d054 1917 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1918 as sprintf is limited to int lengths.
1d526e2f 1919
252c5ee1
PE
1920 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1921 (X_LONG_MIN): New macros.
864d7ce7
PE
1922 Use them to make the following changes clearer.
1923 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1924 This change doesn't affect the value now, but it may help remind
1925 future maintainers not to raise the value too much later.
1926 (SELECTION_QUANTUM): Remove, replacing with ...
1927 (selection_quantum): ... new function, which avoids overflow.
1928 All uses changed.
1929 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1930 assumption that selection length fits in 'int'.
1931 (x_reply_selection_request, x_handle_selection_request)
1932 (x_get_window_property, receive_incremental_selection)
1933 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1934 (lisp_data_to_selection_data, clean_local_selection_data):
1935 Use ptrdiff_t, not int, to record length of selection.
1936 (x_reply_selection_request, x_get_window_property)
1937 (receive_incremental_selection, x_property_data_to_lisp):
1938 Redo calculations to avoid overflow.
1939 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1940 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1941 something.
1942 (x_get_window_property, receive_incremental_selection)
1943 (lisp_data_to_selection_data, x_property_data_to_lisp):
1944 Check for size-calculation overflow.
1945 (x_get_window_property, receive_incremental_selection)
1946 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1947 Don't store size until memory allocation succeeds.
1948 (x_get_window_property): Plug memory leak on memory exhaustion.
1949 Don't double-block input; malloc is safe here. Don't assume 2**34
1950 - 4 fits in unsigned long. Add an xassert to check
1951 XGetWindowProperty overflow. Be more careful about overflow
1952 calculations, and distinguish size from memory overflow better.
1953 (receive_incremental_selection): When tracing, don't assume
1954 unsigned int is less than INT_MAX.
1955 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1956 harmful) conversions of unsigned short to int.
1957 (lisp_data_to_selection_data): Don't assume that integers
1958 in the range -65535 through -1 fit in an X unsigned short.
1959 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1960 result parameters unless successful. Rely on cons_to_unsigned
1961 to report problems with elements; the old code wasn't right anyway.
1962 (x_check_property_data): Check for int overflow; we cannot use
1963 a wider type due to X limits.
1964 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1965
726e0ab1 1966 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1967
0065d054
PE
1968 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1969 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1970 (x_color_cells): Don't store size until memory allocation succeeds.
1971 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1972 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1973 (x_term_init): Don't assume length fits in int (sprintf is limited
1974 to int size).
bc18e09d 1975
ebfa62c0
PE
1976 Use ptrdiff_t for composition IDs.
1977 * character.c (lisp_string_width):
1978 * composite.c (composition_table_size, n_compositions)
1979 (get_composition_id, composition_gstring_from_id):
1980 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1981 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1982 * window.c (Frecenter):
1983 Use ptrdiff_t, not int, for composition IDs.
1984 * composite.c (get_composition_id): Check for integer overflow.
1985 * composite.h: Adjust prototypes to match the above changes.
1986
d3411f89
PE
1987 Use ptrdiff_t for hash table indexes.
1988 * category.c (hash_get_category_set):
1989 * ccl.c (ccl_driver):
1990 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1991 * coding.c (coding_system_charset_list, detect_coding_system):
1992 * coding.h (struct coding_system.id):
1993 * composite.c (get_composition_id, gstring_lookup_cache):
1994 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1995 * image.c (xpm_get_color_table_h):
1996 * lisp.h (hash_lookup, hash_put):
1997 * minibuf.c (Ftest_completion):
1998 Use ptrdiff_t for hash table indexes, not int (which is too
1999 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2000 32-bit --with-wide-int hosts).
2001
e097a6fa
PE
2002 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2003 Add a FIXME comment about memory leaks.
2004 (syms_of_charset): Don't assume xmalloc returns.
2005
5637687f
PE
2006 Don't assume that stated character widths fit in int.
2007 * character.c (Fchar_width, c_string_width, lisp_string_width):
2008 * character.h (CHAR_WIDTH):
2009 * indent.c (MULTIBYTE_BYTES_WIDTH):
2010 Use sanitize_char_width to avoid undefined and/or bad behavior
2011 with outlandish widths.
a66cfb1c 2012 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2013 now that we have two such functions. All uses changed.
2014 (sanitize_char_width): New inline function.
2015
a2271ba2
PE
2016 Don't assume that tab-width fits in int.
2017 * character.h (sanitize_width): New inline function.
2018 (SANE_TAB_WIDTH): New macro.
2019 (ASCII_CHAR_WIDTH): Use it.
2020 * indent.c (sane_tab_width): Remove. All uses replaced by
2021 SANE_TAB_WIDTH (current_buffer).
2022 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2023
18c52557
PE
2024 * fileio.c: Integer overflow issues with file modes.
2025 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2026
caeeedc1
PE
2027 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2028 Remove unreachable code.
2029 (read_hex, load_charset_map_from_file): Check for integer overflow.
2030
50849c52
PE
2031 * xterm.c: don't go over XClientMessageEvent limit
2032 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2033 (x_send_scroll_bar_event): Likewise. Check that the size does not
2034 exceed limits imposed by XClientMessageEvent, as well as the usual
2035 ptrdiff_t and size_t limits.
2036
b13995db
PE
2037 * keyboard.c: Overflow, signedness and related fixes.
2038 (make_lispy_movement): Use same integer type in forward decl
2039 that is used in the definition.
2040 (read_key_sequence, keyremap_step):
2041 Change bufsize argument back to int, undoing my 2011-03-30 change.
2042 We prefer signed types, and int is wide enough here.
2043 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2044 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2045 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2046 length, not size_t. Use ptrdiff_t for index, not int.
2047 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2048 possibility of integer overflow.
2049
13464394
PE
2050 Overflow, signedness and related fixes for images.
2051
2052 * dispextern.h (struct it.stack[0].u.image.image_id)
2053 (struct_it.image_id, struct image.id, struct image_cache.size)
2054 (struct image_cache.used, struct image_cache.ref_count):
2055 * gtkutil.c (update_frame_tool_bar):
2056 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2057 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2058 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2059 * nsmenu.m (update_frame_tool_bar):
2060 * xdisp.c (calc_pixel_width_or_height):
2061 * xfns.c (image_cache_refcount):
2062 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2063 on typical 64-bit hosts.
2064
2065 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2066 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2067 Omit unnecessary casts to int.
2068 (parse_image_spec): Check that integers fall into 'int' range
2069 when the callers expect that.
2070 (image_ascent): Redo ascent calculation to avoid int overflow.
2071 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2072 (lookup_image): Remove unnecessary tests.
2073 (xbm_image_p): Locals are now of int, not EMACS_INT,
2074 since parse_image_check makes sure they fit into int.
2075 (png_load, gif_load, svg_load_image):
2076 Prefer int to unsigned where either will do.
2077 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2078 old tiff_error_handler and tiff_warning_handler.
2079 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2080 stack buffer overflows. It uses only the features of vsnprintf
2081 that are common to both POSIX and native Microsoft.
2082 (tiff_error_handler, tiff_warning_handler): Use it.
2083 (tiff_load, gif_load, imagemagick_load_image):
2084 Don't assume :index value fits in 'int'.
2085 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2086 (imagemagick_load_image): Check that crop parameters fit into
2087 the integer types that MagickCropImage accepts. Don't assume
2088 Vimagemagick_render_type has a nonnegative value. Don't assume
2089 size_t fits in 'long'.
2090 (gs_load): Use printmax_t to print the widest integers possible.
2091 Check for integer overflow when computing image height and width.
2092
c11821d4
EZ
20932011-08-26 Eli Zaretskii <eliz@gnu.org>
2094
2095 * xdisp.c (redisplay_window): Don't force window start if point
2096 will be invisible in the resulting window. (Bug#9324)
2097
0c95fcf7
EZ
20982011-08-25 Eli Zaretskii <eliz@gnu.org>
2099
2100 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2101 the display spec is of the form `(space ...)'.
2102 (handle_display_spec): Return the value returned by
2103 handle_single_display_spec, not just 1 or zero.
2104 (handle_single_display_spec): If the display spec is of the form
2105 `(space ...)', and specifies display in the text area, return 2
2106 rather than 1.
fee65a97 2107 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2108 accurately, and prefer exact match for point under bidi.
2109 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2110
2111 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2112 into disp_prop; all users changed.
2113
2114 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2115 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2116 for the text covered by the display property.
2117
e4ed06f1
CY
21182011-08-25 Chong Yidong <cyd@stupidchicken.com>
2119
2120 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2121 Change return value to nil.
2122 (Frecord_buffer): Delete unused function.
2123
f67cdd7f
EZ
21242011-08-24 Eli Zaretskii <eliz@gnu.org>
2125
5980d4c6
EZ
2126 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2127 buffers, return left-to-right.
8610fe8b
EZ
2128 (set_cursor_from_row): Consider candidate row a win if its glyph
2129 represents a newline and point is on that newline. Fixes cursor
2130 positioning on the newline at EOL of R2L text within L2R
2131 paragraph, and vice versa.
2132 (try_cursor_movement): Check continued rows, in addition to
2133 continuation rows. Fixes unwarranted scroll when point enters a
2134 continued line of R2L text within an L2R paragraph, or vice versa.
2135 (cursor_row_p): Consider the case of point being equal to
2136 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2137 from the end of a short line to the beginning of a continued line
2138 of R2L text within L2R paragraph.
2139 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2140 composed characters.
5980d4c6 2141
f67cdd7f
EZ
2142 * bidi.c (bidi_check_type): Use xassert.
2143 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2144 members.
2145
bca633fb
EZ
21462011-08-23 Eli Zaretskii <eliz@gnu.org>
2147
2148 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2149 a character.
2150
4a5885a7
CY
21512011-08-23 Chong Yidong <cyd@stupidchicken.com>
2152
2153 * nsfont.m (ns_otf_to_script): Fix typo.
2154
0902a04e
KH
21552011-08-22 Kenichi Handa <handa@m17n.org>
2156
2157 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2158 extra slot even if the purpose is char-code-property-table.
2159
1a2e6670
EZ
21602011-08-23 Eli Zaretskii <eliz@gnu.org>
2161
8ddde651
EZ
2162 * xdisp.c (redisplay_window): When computing centering_position,
2163 account for the height of the header line. (Bug#8874)
2164
425cc014
EZ
2165 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2166 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2167 candidate is selected by the mouse, and that candidate has a
2168 composed character under the mouse.
2169
1a2e6670
EZ
2170 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2171 coordinates reported by pos-visible-in-window-p for a composed
2172 character in column zero.
2173
8b76d6f8
SM
21742011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2175
2176 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2177
dac347dd
EZ
21782011-08-22 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2181 consider it a hit if to_charpos is anywhere in the range of the
2182 composed buffer positions.
2183
e013fb34
CY
21842011-08-22 Chong Yidong <cyd@stupidchicken.com>
2185
2186 * image.c (gif_load): Don't assume that each subimage has the same
2187 dimensions as the base image. Handle disposal method that is
2188 "undefined" by the gif spec (Bug#9335).
2189
bd1ba3e8
CY
21902011-08-20 Chong Yidong <cyd@stupidchicken.com>
2191
2192 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2193 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2194
54a1215b
EZ
21952011-08-19 Eli Zaretskii <eliz@gnu.org>
2196
823564e5
EZ
2197 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2198 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2199 from an Org mode buffer to a Speedbar frame.
2200
54a1215b
EZ
2201 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2202 a composition, take its buffer position from IT->cmp_it.charpos.
2203 Fixes cursor positioning at the beginning of a line that begins
2204 with a composed character.
2205
9778ebcc
EZ
22062011-08-18 Eli Zaretskii <eliz@gnu.org>
2207
0be6ee06
EZ
2208 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2209 character bidirectional type, use STRONG_L instead. Fixes crashes
2210 in a buffer produced by `describe-categories'.
2211
9778ebcc
EZ
2212 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2213 members before the level stack, so they would be saved and
2214 restored when copying iterator state. Fixes incorrect reordering
2215 around TABs covered by display properties.
2216
156bffbe
AS
22172011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2218
6b02f655 2219 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2220
72ad093b
CY
22212011-08-17 Chong Yidong <cyd@stupidchicken.com>
2222
2223 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2224 (internal_condition_case_2, internal_condition_case_n):
2225 Remove unnecessary aborts (Bug#9081).
72ad093b 2226
35774242
EZ
22272011-08-17 Eli Zaretskii <eliz@gnu.org>
2228
2229 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2230 has no `load' handler, try opening the file locally. (Bug#9311)
2231
db76dd85
KB
22322011-08-16 Ken Brown <kbrown@cornell.edu>
2233
2234 * gmalloc.c: Expand comment.
2235
b215eee5
EZ
22362011-08-16 Eli Zaretskii <eliz@gnu.org>
2237
2238 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2239 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2240
a4579d33
KB
22412011-08-16 Ken Brown <kbrown@cornell.edu>
2242
2243 Fix memory allocation problems in Cygwin build (Bug#9273).
2244
2245 * unexcw.c ( __malloc_initialized): Declare external variable.
2246 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2247
8b76d6f8
SM
2248 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2249 New variables.
a4579d33
KB
2250 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2251 dumped emacs.
2252 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2253 in the static heap.
2254 [CYGWIN] (special_realloc): New function.
2255 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2256 requests to realloc storage in the static heap.
2257
3ebec551
PE
22582011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 * bidi.c (bidi_initialize): Remove unused local.
2261
9fd8be00
EZ
22622011-08-15 Eli Zaretskii <eliz@gnu.org>
2263
6b02f655
SM
2264 * bidimirror.h:
2265 * biditype.h: Remove file.
2266 * makefile.w32-in ($(BLD)/bidi.$(O)):
2267 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2268
2269 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2270
2271 * chartab.c: Improve commentary for the uniprop_table API.
2272
32413314
EZ
2273 * bidi.c (bidi_paragraph_init): Support zero value of
2274 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2275 (bidi_initialize): Use uniprop_table instead of including
2276 biditype.h and bidimirror.h.
32413314 2277
9fd8be00
EZ
2278 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2279 coordinates of the iterator when restoring from ppos_it.
2280 (Bug#9296)
2281
5cf2b69b
KH
22822011-08-14 Kenichi Handa <handa@m17n.org>
2283
2284 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2285 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2286
daf17d00
EZ
22872011-08-14 Eli Zaretskii <eliz@gnu.org>
2288
2289 * xdisp.c (move_it_in_display_line_to): Don't invoke
2290 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2291 ppos_it. Fixes vertical cursor motion when line beginning is
2292 covered by an image. (Bug#9296)
2293
08e3161a
JD
22942011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2295
2296 * nsterm.h (ns_run_ascript): Declare.
2297 (NSAPP_DATA2_RUNASSCRIPT): Define.
2298
2299 * nsfns.m (as_script, as_result, as_status): New static variables.
2300 (ns_run_ascript): New function.
5e617bc2 2301 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2302 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2303 the event loop. Get status from as_status (Bug#7276).
2304
2305 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2306 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2307 the event loop (Bug#7276).
2308
a3720aa2
AS
23092011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2310
2311 * gnutls.c (QCgnutls_bootprop_priority)
2312 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2313 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2314 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2315 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2316 (QCgnutls_bootprop_verify_hostname_error)
2317 (QCgnutls_bootprop_callbacks_verify): Rename from
2318 Qgnutls_bootprop_..., all uses changed.
2319
2320 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2321 uses changed.
2322
0a0d27fb
PE
23232011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2324
19d5c50c
PE
2325 * xfaces.c (Qframe_set_background_mode): Now static.
2326 * dispextern.h (Qframe_set_background_mode): Remove decl.
2327
0a0d27fb
PE
2328 * process.c (Fnetwork_interface_info): Declare local only if needed.
2329
377538cb
JD
23302011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2331
2332 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2333 (Fnetwork_interface_list): Allocate in increments of bytes instead
2334 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2335 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2336 sockaddr.
2337 (struct ifflag_def): notrailers is smart on OSX.
2338 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2339 Get hardware address with getifaddrs if available.
2340
08fff70c
EZ
23412011-08-12 Eli Zaretskii <eliz@gnu.org>
2342
2343 * xdisp.c (iterate_out_of_display_property): xassert that
2344 IT->position is set to within IT->object's boundaries. Break from
2345 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2346 when IT->position is set up wrongly due to some bug.
2347 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2348 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2349 entry. Force push_it to save on the stack the current
2350 buffer/string position, to be restored by pop_it. Fix flags in
2351 the iterator structure wrt the object coming from a display
2352 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2353 properties. (Bug#9284)
2354
7be1c708 23552011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2356
7be1c708
CY
2357 * fontset.c (fontset_get_font_group): Add proper type checks.
2358 (Bug#9172)
aac0c6e3 2359
7be1c708 23602011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2361
7be1c708
CY
2362 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2363 and LC_VERSION_MIN_MACOSX.
2364 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2365 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2366
97bb72a6
EZ
23672011-08-08 Eli Zaretskii <eliz@gnu.org>
2368
2369 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2370 no-display-properties-and-no-overlays under bidi display.
2371 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2372 properties and overlays.
97bb72a6 2373
d5617611
CY
23742011-08-08 Chong Yidong <cyd@stupidchicken.com>
2375
37e11a63
CY
2376 * editfns.c (Fset_time_zone_rule): Document relationship with the
2377 setenv function.
2378
d5617611
CY
2379 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2380 the font entity extracted from the cache (Bug#8109).
2381
58872834
CY
23822011-08-07 Chong Yidong <cyd@stupidchicken.com>
2383
2384 * composite.c (autocmp_chars): Don't reset point. That is done by
2385 restore_point_unwind (Bug#5984).
2386
75bfc667
JL
23872011-08-07 Juri Linkov <juri@jurta.org>
2388
2389 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2390 to show the arg `TIME' instead of `TIMEVAL'.
2391
d1410150
EZ
23922011-08-06 Eli Zaretskii <eliz@gnu.org>
2393
2394 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2395 display property strides EOL and includes a newline, as in
2396 longlines-mode. (Bug#9254)
75b771e4
EZ
2397 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2398 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2399
2400 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2401 is non-zero, even if the data buffer is NULL. Fixes a crash in
2402 vertical-motion with longlines-mode. (Bug#9254)
2403
35928349
EZ
24042011-08-05 Eli Zaretskii <eliz@gnu.org>
2405
ec7cc85b
EZ
2406 * bidi.c <bidi_cache_total_alloc>: Now static.
2407 (bidi_initialize): Initialize bidi_cache_total_alloc.
2408
8b76d6f8 2409 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2410 cache. (Bug#9221)
2411
2412 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2413 amount allocated this far in `bidi_cache_total_alloc'.
2414 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2415 non-zero, only free the data buffer without restoring the cache
2416 contents. All callers changed.
2417
2418 * dispextern.h (bidi_unshelve_cache): Update prototype.
2419
2420 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2421 (move_it_in_display_line, move_it_to)
2422 (move_it_vertically_backward, move_it_by_lines): Replace the call
2423 to xfree to an equivalent call to bidi_unshelve_cache.
2424 (move_it_in_display_line_to): Fix logic of returning
412b6358 2425 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2426
e2e2423b
EZ
24272011-08-05 Eli Zaretskii <eliz@gnu.org>
2428
2429 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2430 came from a string character with a `cursor' property. (Bug#9229)
2431
ae9e757a
JD
24322011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2433
2434 * Makefile.in (LIB_PTHREAD): New variable.
2435 (LIBES): Add LIB_PTHREAD (Bug#9216).
2436
2437 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2438 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2439
213bd7f2
AS
24402011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2441
6b02f655 2442 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2443
99aaf75f
JD
24442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2445
2446 * xterm.c (x_find_topmost_parent): New function.
2447 (x_set_frame_alpha): Find topmost parent window with
2448 x_find_topmost_parent and set the property there also (bug#9181).
2449 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2450
c74e9d86
PE
24512011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 * callproc.c (Fcall_process): Avoid vfork clobbering
2454 the local vars buffer, coding_systems, current_dir.
2455
640c8776
SM
24562011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2457
2458 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2459
f26d0e4c
PE
24602011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2461
8a10d76c
PE
2462 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2463 so that it is not optimized away.
2464
f26d0e4c
PE
2465 * xdisp.c (compute_display_string_pos): Remove unused local.
2466
55439c61
EZ
24672011-08-02 Eli Zaretskii <eliz@gnu.org>
2468
2469 Fix slow cursor motion and scrolling in large buffers with
2470 selective display, like Org Mode buffers. (Bug#9218)
2471
2472 * dispextern.h (struct bidi_it): New member disp_prop_p.
2473
2474 * xdisp.c: Remove one-slot cache of display string positions.
2475 (compute_display_string_pos): Accept an additional argument
5e617bc2 2476 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2477 for a display string or property. If found, set DISP_PROP_P
2478 non-zero.
2479
2480 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2481 DISP_PROP_P, and pass it to compute_display_string_pos.
2482 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2483 non-zero. All callers of bidi_fetch_char changed.
2484
fb33fa43
SM
24852011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2486
2487 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2488
b099e063
DM
24892010-12-03 Don March <don@ohspite.net>
2490
2491 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2492 last character M-[char] is translated to ESC [char] (bug#7541).
2493
5cc7f7af
KH
24942011-08-02 Kenichi Handa <handa@m17n.org>
2495
d0fffa3f 2496 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2497
2498 * chartab.c (uniprop_table): Make it non-static.
2499
525d5e6e
EZ
25002011-08-01 Eli Zaretskii <eliz@gnu.org>
2501
2502 * xdisp.c (forward_to_next_line_start): Accept additional argument
2503 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2504 on the newline.
2505 (reseat_at_next_visible_line_start): Use the bidi iterator state
2506 returned by forward_to_next_line_start to restore the state of
2507 it->bidi_it after backing up to previous newline. (Bug#9212)
2508
31011111
AS
25092011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2510
2511 * regex.c (re_comp): Protoize.
2512 (re_exec): Fix return type.
2513 (regexec): Fix type of `ret'. (Bug#9203)
2514
476371c4
PE
25152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2516
e5d76069
PE
2517 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2518 This is needed if max-image-size is a floating-point number.
2519
9a79b20c
AS
25202011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2521
2522 * print.c (print_object): Print empty symbol as ##.
2523
2524 * lread.c (read1): Read ## as empty symbol.
2525
d8c2fa78
AA
25262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2527
2528 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2529 setting frame foreground color (Bug#9175).
2530 (x_set_background_color): Likewise.
2531
ffe57a7a
AA
2532 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2533 contents (Bug#9176).
2534 (EmacsTooltip -init): Remove bezels and add shadows to
2535 tooltip windows.
2536
bf3492a5
AA
2537 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2538 or scroll bar (Bug#8470).
2539
d55e9c53
AA
2540 * nsfont.m (nsfont_open): Remove assignment to voffset and
2541 unnecessary vars hshink, expand, hd, full_height, min_height.
2542 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2543
2544 * nsterm.h (nsfont_info): Remove voffset field.
2545
d8c2fa78 25462011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2547
2548 Implement strike-through and overline on NextStep (Bug#8863).
2549
2550 * nsfont.m (nsfont_open): Use underline position provided by font,
2551 instead of hard-coded value of 2.
2552 (nsfont_draw): Call ns_draw_text_decoration instead.
2553
2554 * nsterm.h: Add declaration for ns_draw_text_decoration.
2555
2556 * nsterm.m (ns_draw_text_decoration): New function for drawing
2557 underline, overline, and strike-through.
2558 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2559 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2560 accommodate underlining, etc.
4843aac3 2561
4cc60b9b
EZ
25622011-07-28 Eli Zaretskii <eliz@gnu.org>
2563
bc7ece87
EZ
2564 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2565 default.
4cc60b9b 2566
476371c4
PE
25672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2568
66606eea
PE
2569 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2570 Without this fix, if a signal arrives just after memory fills up,
2571 'malloc' might be invoked reentrantly.
2572
476371c4
PE
2573 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2574 In other words, assume that every image size is allowed, on non-X
2575 hosts. This assumption is probably wrong, but it lets Emacs compile.
2576
f3fcc40d
AS
25772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2578
2579 * regex.c (re_iswctype): Convert return values to boolean.
2580
350c992f
EZ
25812011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2582
2583 * xdisp.c (compute_display_string_pos): Don't use cached display
2584 string position if the buffer had its restriction changed.
2585 (Bug#9184)
2586
5266b4bb
PE
25872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2590
2573a837 25912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2592
41f55ccd 2593 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2594
39e378da
PE
2595 * bidi.c: Integer size and overflow fixes.
2596 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2597 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2598 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2599 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2600 (bidi_find_other_level_edge):
2601 Use ptrdiff_t instead of EMACS_INT where either will do.
2602 This works better on 32-bit hosts configured --with-wide-int.
2603 (bidi_cache_ensure_space): Check for size-calculation overflow.
2604 Use % rather than repeated addition, for better worst-case speed.
2605 Don't set bidi_cache_size until after xrealloc returns, because it
2606 might not return.
2607 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2608 (bidi_cache_ensure_space): Also check that the bidi cache size
2609 does not exceed that of the largest Lisp string or buffer. See Eli
2610 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2611
5e927815
PE
2612 * alloc.c (__malloc_size_t): Remove.
2613 All uses replaced by size_t. See Andreas Schwab's note
2614 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2615
ca4aa935
PE
2616 * image.c: Improve checking for integer overflow.
2617 (check_image_size): Assume that f is nonnull, since
2618 it is always nonnull in practice. This is one less thing to
2619 worry about when checking for integer overflow later.
2620 (x_check_image_size): New function, which checks for integer
2621 overflow issues inside X.
2622 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2623 This removes the need for a memory_full check.
2624 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2625 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2626 (xbm_read_bitmap_data): Change locals back to 'int', since
2627 their values must fit in 'int'.
2628 (xpm_load_image, png_load, tiff_load):
2629 Invoke x_create_x_image_and_pixmap earlier,
2630 to avoid much needless work if the image is too large.
2631 (tiff_load): Treat overly large images as if
2632 x_create_x_image_and_pixmap failed, not as malloc failures.
2633 (gs_load): Use x_check_image_size.
2634
5f8f9cc2
PE
2635 * gtkutil.c: Omit integer casts.
2636 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2637 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2638
5adf60bc
PE
2639 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2640
c8907a93
PE
2641 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2642 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2643 would wrongly return t on a 64-bit host.
2644
e3c25c68
PE
2645 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2646 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2647 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2648 and therefore cause GCC to emit a bogus diagnostic in some cases.
2649
3f791afe
PE
2650 * image.c: Integer signedness and overflow and related fixes.
2651 This is not an exhaustive set of fixes, but it's time to
2652 record what I've got.
2653 (lookup_pixel_color, check_image_size): Remove redundant decls.
2654 (check_image_size): Don't assume that arbitrary EMACS_INT values
2655 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2656 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2657 (tiff_load, imagemagick_load_image):
2658 Check for overflow in size calculations.
2659 (x_create_x_image_and_pixmap): Remove unnecessary test for
2660 xmalloc returning NULL; that can't happen.
2661 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2662 (xpm_color_bucket): Use better integer hashing function.
2663 (xpm_cache_color): Don't possibly over-allocate memory.
2664 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2665 (gif_memory_source):
2666 Use ptrdiff_t, not int or size_t, to record sizes.
2667 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2668 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2669 either works, as we prefer signed integers.
2670 (tiff_read_from_memory, tiff_write_from_memory):
2671 Return tsize_t, not size_t, since that's what the TIFF API wants.
2672 (tiff_read_from_memory): Don't fail simply because the read would
2673 go past EOF; instead, return a short read.
2674 (tiff_load): Omit no-longer-needed casts.
2675 (Fimagemagick_types): Don't assume size fits into 'int'.
2676
3cc5a532
PE
2677 Improve hashing quality when configured --with-wide-int.
2678 * fns.c (hash_string): New function, taken from sxhash_string.
2679 Do not discard information about ASCII character case; this
2680 discarding is no longer needed.
2681 (sxhash-string): Use it. Change sig to match it. Caller changed.
2682 * lisp.h: Declare it.
2683 * lread.c (hash_string): Remove, since we now use fns.c's version.
2684 The fns.c version returns a wider integer if --with-wide-int is
2685 specified, so this should help the quality of the hashing a bit.
2686
b312a492
PE
2687 * emacs.c: Integer overflow minor fix.
2688 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2689 Define only if GNU_LINUX.
2690 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2691
dfd153ae
PE
2692 * dispnew.c: Integer signedness and overflow fixes.
2693 Remove unnecessary forward decls, that were a maintenance hassle.
2694 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2695 All uses changed.
2696 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2697 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2698 (prepare_desired_row, line_draw_cost):
2699 Use int, not unsigned, where either works.
2700 (save_current_matrix, restore_current_matrix):
2701 Use ptrdiff_t, not size_t, where either works.
2702 (init_display): Check for overflow more accurately, and without
2703 relying on undefined behavior.
2704
a81d11a3
PE
2705 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2706 Remove, replacing with the new symbols in lisp.h. All uses changed.
2707 * fileio.c (make_temp_name):
2708 * filelock.c (lock_file_1, lock_file):
2709 * xdisp.c (message_dolog):
2710 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2711 Use pMd etc. instead.
2712 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2713 replacing the pWIDE etc. symbols removed from editfns.c.
2714
3300e6fd
PE
2715 * keyboard.h (num_input_events): Now uintmax_t.
2716 This is (very slightly) less likely to mess up due to wraparound.
2717 All uses changed.
2718
fd05c7e9
PE
2719 * buffer.c: Integer signedness fixes.
2720 (alloc_buffer_text, enlarge_buffer_text):
2721 Use ptrdiff_t rather than size_t when either will do, as we prefer
2722 signed integers.
2723
903fe15d
PE
2724 * alloc.c: Integer signedness and overflow fixes.
2725 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2726 (__malloc_size_t): Default to size_t, not to int.
2727 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2728 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2729 Prefer ptrdiff_t to size_t when either would do, as we prefer
2730 signed integers.
2731 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2732 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2733 Now const. Initialize with values that are in range even if char
2734 is signed.
2735 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2736 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2737 These functions do the right thing with sizes > 2**32.
2738 (check_depth): Now ptrdiff_t, not int.
2739 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2740 Adjust to new way of storing sizes. Check for size overflow bugs
2741 in rest of code.
2742 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2743 slightly wrong anyway, as it missed one instance of
2744 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2745 (refill_memory_reserve): Omit needless cast to size_t.
2746 (mark_object_loop_halt): Mark as externally visible.
2747
ac82cc6a
PE
2748 * xselect.c: Integer signedness and overflow fixes.
2749 (Fx_register_dnd_atom, x_handle_dnd_message):
2750 Use ptrdiff_t, not size_t, since we prefer signed.
2751 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2752 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2753 x_dnd_atoms_size and x_dnd_atoms_length.
2754
c2d1e36d
PE
2755 * doprnt.c: Prefer signed to unsigned when either works.
2756 * eval.c (verror):
2757 * doprnt.c (doprnt):
2758 * lisp.h (doprnt):
2759 * xdisp.c (vmessage):
2760 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2761 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2762 prefer signed arithmetic to avoid comparison confusion.
2763 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2764 but is a bit tricky.
2765
0e926e56
PE
2766 Assume freestanding C89 headers, string.h, stdlib.h.
2767 * data.c, doprnt.c, floatfns.c, print.c:
2768 Include float.h unconditionally.
2769 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2770 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2771 * regex.c: Likewise for stddef.h, string.h.
2772 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2773 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2774 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2775 (STDC_HEADERS): Remove obsolete defines.
2776 * sysdep.c: Include limits.h unconditionally.
2777
9cfdb3ec
PE
2778 Assume support for memcmp, memcpy, memmove, memset.
2779 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2780 * regex.c (memcmp, memcpy):
2781 Remove; we assume C89 now.
2782
2783 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2784 (__malloc_safe_bcopy): Remove; no longer needed.
2785
cf950e6b 2786 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2787 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2788 well either way, and we prefer signed to unsigned.
2789
dbf38e02
LMI
27902011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2791
2792 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2793 closes the connection while we're reading (bug#9182).
2794
d6f0886c 27952011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2796
d6f0886c
JD
2797 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2798 are specified (Bug#9168).
24e0f6b1 2799
2eb1f9e6
PE
28002011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2803 Found by GCC static checking and --with-wide-int on a 32-bit host.
2804
22381272 28052011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2806
2807 * xdisp.c (compute_display_string_pos): Fix logic of caching
2808 previous display string position. Initialize cached_prev_pos to
2809 -1. Fixes slow-down at the beginning of a buffer.
2810
f25e39b4
EZ
28112011-07-24 Eli Zaretskii <eliz@gnu.org>
2812
2813 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2814 for attrs[LFACE_FONTSET_INDEX].
2815
04c4b52e
PE
28162011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2817
2818 * xml.c (parse_region): Remove unused local
2819 that was recently introduced.
2820
c1734fbd
EZ
28212011-07-23 Eli Zaretskii <eliz@gnu.org>
2822
be18c5a5
EZ
2823 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2824 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2825
c1734fbd
EZ
2826 * xdisp.c (move_it_in_display_line_to): Record the best matching
2827 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2828 exit if none of the characters scanned was an exact match.
2829 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2830 when exact match is impossible due to invisible text, and the
2831 lines are truncated.
2832
a258d627
JD
28332011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2834
2835 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2836 for OSX >= 10.7.
2837
b6d5a689
EZ
28382011-07-22 Eli Zaretskii <eliz@gnu.org>
2839
0f74f785
EZ
2840 Fix a significant slow-down of cursor motion with C-n, C-p,
2841 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2842 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2843 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2844 (next_element_from_buffer): Call compute_stop_pos_backwards to
2845 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2846 base_level_stop.
2847 (reseat): Don't look for prev_stop, as that could mean a very long
2848 run.
2849 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2850 <cached_disp_overlay_modiff>: Cache for last found display string
2851 position.
551918c1 2852 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2853 about the same buffer in the same area of character positions, and
2854 the buffer wasn't changed since the time the display string
2855 position was cached.
551918c1 2856
b2d0c91a
EZ
28572011-07-22 Eli Zaretskii <eliz@gnu.org>
2858
2859 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2860 is an integer, which is important for empty lines. (Bug#9149)
2861
043604ee
CY
28622011-07-22 Chong Yidong <cyd@stupidchicken.com>
2863
2864 * frame.c (Fmodify_frame_parameters): In tty case, update the
2865 default face if necessary (Bug#4238).
2866
da4adb04
CY
28672011-07-21 Chong Yidong <cyd@stupidchicken.com>
2868
2869 * editfns.c (Fstring_to_char): No need to explain what a character
2870 is in the docstring (Bug#6576).
2871
9abd0532
LMI
28722011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2873
2874 * xml.c (parse_region): Make sure we always return a tree.
2875
36881d16
HK
28762011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2877
2878 * xml.c (parse_region): If a document contains only comments,
2879 return that, too.
2880
1e98674d
LMI
28812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2882
2883 * xml.c (make_dom): Return comments, too.
2884
590bd467
PE
28852011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 Port to OpenBSD.
2888 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2889 and the surrounding thread.
2890 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2891 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2892 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2893 timer goes off.
2894 * s/openbsd.h (BROKEN_SIGIO): Define.
2895 * unexelf.c (unexec) [__OpenBSD__]:
2896 Don't update the .mdebug section of the Alpha COFF symbol table.
2897
f41628b2
LMI
28982011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2899
2900 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2901 (bug#8460).
2902
b59b67c5
PE
29032011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2904
15e3a074
PE
2905 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2906 This fixes some race conditions on the permissions of any newly
2907 created file.
2908
41bed37d
PE
2909 * alloc.c (valid_pointer_p): Use pipe, not open.
2910 This fixes some permissions issues when debugging.
2911
b59b67c5
PE
2912 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2913 If fchown fails to set both uid and gid, try to set just gid,
2914 as that is sometimes allowed. Adjust the file's mode to eliminate
2915 setuid or setgid bits that are inappropriate if fchown fails.
2916
925a6be7
SM
29172011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2918
2919 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2920 to compare Lisp_Objects.
2921 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2922 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2923 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2924
52968808
AS
29252011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2926
0a6a104b
AS
2927 * lread.c (read_integer): Unread even EOF character.
2928 (read1): Likewise. Properly record start position of symbol.
2929
52968808
AS
2930 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2931 symbol character follows.
2932
9e381cdd
PE
29332011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2934
2935 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2936 This works around a problem with the previous change to Fcopy_file.
2937 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2938 and without this change, GCC might complain about discarding
2939 fchown's return value.
2940
b5641435
JB
29412011-07-16 Juanma Barranquero <lekktu@gmail.com>
2942
2943 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2944
a8031457
PE
29452011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2946
2947 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2948
dd889327
LMI
29492011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2950
750c33f7
LMI
2951 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2952 it's used from the C level.
2953
dd889327
LMI
2954 * process.c: Use the same condition for POLL_FOR_INPUT in both
2955 keyboard.c and process.c (bug#1858).
2956
87e86684
LM
29572011-07-09 Lawrence Mitchell <wence@gmx.li>
2958
2959 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2960 (Fgnutls_boot): Use it.
2961
64348f40
AS
29622011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2963
2964 * doc.c (Fsubstitute_command_keys): Revert last change.
2965
1d698799
LMI
29662011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2967
f863868c
LMI
2968 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2969 quotes the next character, and doesn't affect other longer
2970 sequences (bug#8935).
2971
1d698799
LMI
2972 * lread.c (syms_of_lread): Clarify that is isn't only
2973 `eval-buffer' and `eval-defun' that's affected by
2974 `lexical-binding' (bug#8460).
2975
aa4b6df6
EZ
29762011-07-15 Eli Zaretskii <eliz@gnu.org>
2977
2978 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2979 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2980
5d856da6
PE
29812011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2982
ad6042bb
PE
2983 Fix minor problems found by static checking.
2984 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2985 (elsz): Now a signed constant, not a size_t var. We prefer signed
2986 types to unsigned, to avoid integer comparison confusion. Without
2987 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2988 "cannot optimize loop, the loop counter may overflow", a symptom
2989 of the confusion.
f00bbb22 2990 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2991 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2992
6468f31c
LMI
29932011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2994
49080b10
LMI
2995 * search.c (Fre_search_backward): Mention `case-fold-search' in
2996 all the re_search_* functions (bug#8138).
2997
6468f31c
LMI
2998 * keyboard.c (Fopen_dribble_file): Document when the file is
2999 closed (bug#8056).
3000
c965adc5
EZ
30012011-07-14 Eli Zaretskii <eliz@gnu.org>
3002
df9733bf
EZ
3003 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3004 bidi_cache_idx.
3005
0bb23927
EZ
3006 Support bidi reordering of display and overlay strings.
3007 * xdisp.c (compute_display_string_pos)
3008 (compute_display_string_end): Accept additional argument STRING.
3009 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3010 (reseat_to_string): Initialize bidi_it->string.s and
3011 bidi_it->string.schars.
3012 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3013 NULL (avoids a crash in bidi_paragraph_init).
3014 Initialize itb.string.lstring.
0bb23927
EZ
3015 (init_iterator): Call bidi_init_it only of a valid
3016 buffer position was specified. Initialize paragraph_embedding to
3017 L2R.
3018 (reseat_to_string): Initialize the bidi iterator.
3019 (display_string): If we need to ignore text properties of
3020 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3021 original value of -1 will not work with bidi.)
3022 (compute_display_string_pos): First arg is now struct
3023 `text_pos *'; all callers changed. Support display properties on
3024 Lisp strings.
3025 (compute_display_string_end): Support display properties on Lisp
3026 strings.
3027 (init_iterator, reseat_1, reseat_to_string): Initialize the
3028 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3029 when iterating on a string not from display properties).
640c8776
SM
3030 (compute_display_string_pos, compute_display_string_end):
3031 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3032 arrow keys.
3033 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3034 base_level_stop; instead, set base_level_stop to BEGV.
3035 Fixes crashes in vertical-motion.
0bb23927
EZ
3036 (next_element_from_buffer): Improve commentary for when
3037 the iterator is before prev_stop.
3038 (init_iterator): Initialize bidi_p from the default value of
3039 bidi-display-reordering, not from buffer-local value. Use the
3040 buffer-local value only if initializing for buffer iteration.
3041 (handle_invisible_prop): Support invisible properties on strings
3042 that are being bidi-reordered.
3043 (set_iterator_to_next): Support bidi reordering of C strings and
3044 Lisp strings.
3045 (next_element_from_string): Support bidi reordering of Lisp
3046 strings.
3047 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3048 (display_string): Support display of R2L glyph rows.
3049 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3050 (init_iterator): Don't initialize it->bidi_p for strings
3051 here.
3052 (reseat_to_string): Initialize it->bidi_p for strings here.
3053 (next_element_from_string, next_element_from_c_string)
3054 (next_element_from_buffer): Add xassert's for correspondence
3055 between IT's object being iterated and it->bidi_it.string
3056 structure.
3057 (face_before_or_after_it_pos): Support bidi iteration.
3058 (next_element_from_c_string): Handle the case of the first string
3059 character that is not the first one in the visual order.
3060 (get_visually_first_element): New function, refactored from common
3061 parts of next_element_from_buffer, next_element_from_string, and
3062 next_element_from_c_string.
3063 (tool_bar_lines_needed, redisplay_tool_bar)
3064 (display_menu_bar): Force left-to-right direction. Add a FIXME
3065 comment for making that be controlled by a user option.
3066 (push_it, pop_it): Save and restore the state of the
3067 bidi iterator. Save and restore the bidi_p flag.
3068 (pop_it): Iterate out of display property for string iteration as
3069 well.
3070 (iterate_out_of_display_property): Support iteration over strings.
3071 (handle_single_display_spec): Set up it->bidi_it for iteration
3072 over a display string, and call bidi_init_it.
3073 (handle_single_display_spec, next_overlay_string)
3074 (get_overlay_strings_1, push_display_prop): Set up the bidi
3075 iterator for displaying display or overlay strings.
3076 (forward_to_next_line_start): Don't use the shortcut if
3077 bidi-iterating.
3078 (back_to_previous_visible_line_start): If handle_display_prop
3079 pushed the iterator stack, restore the internal state of the bidi
3080 iterator by calling bidi_pop_it same number of times.
3081 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3082 and we are bidi-iterating, don't decrement the iterator position;
3083 instead, set the first_elt flag in the bidi iterator, to produce
3084 the same effect.
3085 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3086 (push_display_prop): xassert that we are iterating a buffer.
3087 (push_it, pop_it): Save and restore paragraph_embedding member.
3088 (handle_single_display_spec, next_overlay_string)
3089 (get_overlay_strings_1, reseat_1, reseat_to_string)
3090 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3091 correctly. Don't assume unibyte strings are not bidi-reordered.
3092 (compute_display_string_pos)
3093 (compute_display_string_end): Fix handling the case of C string.
3094 (push_it, pop_it): Save and restore from_disp_prop_p.
3095 (handle_single_display_spec, push_display_prop): Set the
3096 from_disp_prop_p flag.
3097 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3098 (pop_it): Call iterate_out_of_display_property only if we are
3099 popping after iteration over a string that came from a display
3100 property. Fix a typo in popping stretch info. Add an assertion
3101 for verifying that the iterator position is in sync with the bidi
3102 iterator.
3103 (handle_single_display_spec, get_overlay_strings_1)
3104 (push_display_prop): Fix initialization of paragraph direction for
3105 string when that of the parent object is not yet determined.
3106 (reseat_1): Call bidi_init_it to resync the bidi
3107 iterator with IT's position. (Bug#7616)
3108 (find_row_edges): If ROW->start.pos gives position
3109 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3110 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3111 Reset the from_disp_prop_p flag.
3112 (SAVE_IT, RESTORE_IT): New macros.
3113 (pos_visible_p, face_before_or_after_it_pos)
3114 (back_to_previous_visible_line_start)
3115 (move_it_in_display_line_to, move_it_in_display_line)
3116 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3117 (try_scrolling, redisplay_window, display_line): Use them when
3118 saving a temporary copy of the iterator and restoring it back.
3119 (back_to_previous_visible_line_start, reseat_1)
3120 (init_iterator): Empty the bidi cache "stack".
3121 (move_it_in_display_line_to): If iterator ended up at
3122 EOL, but we never saw any buffer positions smaller than
3123 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3124 motion in bidi-reordered lines.
3125 (move_it_in_display_line_to): Record prev_method and prev_pos
3126 immediately before the call to set_iterator_to_next. Fixes cursor
3127 motion in bidi-reordered lines with stretch glyphs and strings
3128 displayed in margins. (Bug#8133) (Bug#8867)
3129 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3130 TO_CHARPOS.
640c8776
SM
3131 (pos_visible_p): Support positions in bidi-reordered lines.
3132 Save and restore bidi cache.
0bb23927
EZ
3133
3134 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3135 (bidi_paragraph_info): Delete unused struct.
3136 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3137 (bidi_cache_start): New variable.
3138 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3139 to zero.
3140 (bidi_cache_fetch_state, bidi_cache_search)
3141 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3142 (bidi_cache_find, bidi_peek_at_next_level)
3143 (bidi_level_of_next_char, bidi_find_other_level_edge)
3144 (bidi_move_to_visually_next): Compare cache index with
3145 bidi_cache_start rather than with zero.
3146 (bidi_fetch_char): Accept new argument STRING; all callers
3147 changed. Support iteration over a string. Support strings with
3148 display properties. Support unibyte strings. Fix the type of
3149 `len' according to what STRING_CHAR_AND_LENGTH expects.
3150 (bidi_paragraph_init, bidi_resolve_explicit_1)
3151 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3152 (bidi_level_of_next_char, bidi_move_to_visually_next):
3153 Support iteration over a string.
0bb23927
EZ
3154 (bidi_set_sor_type, bidi_resolve_explicit_1)
3155 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3156 can now be zero (for strings); special values 0 and -1 were
3157 changed to -1 and -2, respectively.
3158 (bidi_char_at_pos): New function.
3159 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3160 Call it instead of FETCH_MULTIBYTE_CHAR.
3161 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3162 initialized to valid values.
3163 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3164 values.
3165 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3166 the test for valid cached positions. Fix the logic for looking up
3167 the sentinel state in the cache. GCPRO the Lisp string we are
3168 iterating.
3169 (bidi_push_it, bidi_pop_it): New functions.
3170 (bidi_initialize): Initialize the bidi cache start stack pointer.
3171 (bidi_cache_ensure_space): New function, refactored from part of
3172 bidi_cache_iterator_state. Don't assume the required size is just
3173 one BIDI_CACHE_CHUNK away.
3174 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3175 (bidi_count_bytes, bidi_char_at_pos): New functions.
3176 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3177 always valid if bidi_cache_idx is valid.
3178 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3179 is valid if it's going to be used.
3180 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3181 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3182 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3183 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3184 (bidi_find_other_level_edge, bidi_cache_start_stack):
3185 All variables related to cache indices are now EMACS_INT.
c965adc5 3186
0bb23927
EZ
3187 * dispextern.h (struct bidi_string_data): New structure.
3188 (struct bidi_it): New member `string'. Make flag members be 1-bit
3189 fields, and put them last in the struct.
640c8776
SM
3190 (compute_display_string_pos, compute_display_string_end):
3191 Update prototypes.
0bb23927
EZ
3192 (bidi_push_it, bidi_pop_it): Add prototypes.
3193 (struct iterator_stack_entry): New members bidi_p,
3194 paragraph_embedding, and from_disp_prop_p.
3195 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3196 (bidi_shelve_cache, bidi_unshelve_cache):
3197 Declare prototypes.
0bb23927
EZ
3198
3199 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3200 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3201 and vector-like objects.
3202
3203 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3204 cache around display iteration.
3205
3206 * window.c (Fwindow_end, window_scroll_pixel_based)
3207 (displayed_window_lines, Frecenter): Save and restore the bidi
3208 cache around display iteration.
3209
3bbd2265
LMI
32102011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3211
3212 * editfns.c (Fdelete_region): Clarify the use of the named
3213 parameters (bug#6788).
3214
adc47434
MR
32152011-07-14 Martin Rudalics <rudalics@gmx.at>
3216
3217 * indent.c (Fvertical_motion): Set and restore w->pointm when
3218 saving and restoring the window's buffer (Bug#9006).
3219
837c31f8
LMI
32202011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3221
3222 * editfns.c (Fstring_to_char): Clarify just what is returned
3223 (bug#6576). Text by Eli Zaretskii.
3224
ac389d0c
JB
32252011-07-13 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3228
0be0ce47
EZ
32292011-07-13 Eli Zaretskii <eliz@gnu.org>
3230
3231 * buffer.c (mmap_find): Fix a typo.
3232
cd18e7e3
JB
32332011-07-13 Johan Bockgård <bojohan@gnu.org>
3234
3235 Fix execution of x selection hooks.
3236 * xselect.c (Qx_lost_selection_functions)
3237 (Qx_sent_selection_functions): New vars.
3238 (syms_of_xselect): DEFSYM them.
3239 (x_handle_selection_request): Pass Qx_sent_selection_functions
3240 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3241 (x_handle_selection_clear,x_clear_frame_selections):
3242 Pass Qx_lost_selection_functions rather than
3243 Vx_lost_selection_functions to Frun_hook_with_args.
3244
47ea7f44
PE
32452011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3246
ac389d0c 3247 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3248 The old code sometimes used this field without initializing it.
3249
47ea7f44
PE
3250 * alloc.c (gc_sweep): Don't read past end of array.
3251 In theory, the old code could also have corrupted Emacs internals,
3252 though it'd be very unlikely.
3253
bc985c87
AS
32542011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3255
3256 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3257 argument. (Bug#4026)
bc985c87 3258
0cf34688
LMI
32592011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3260
b3dadd76
LMI
3261 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3262 key" (bug#4257).
3263
0cf34688
LMI
3264 * window.c (Fset_window_start): Doc fix (bug#4199).
3265 (Fset_window_hscroll): Ditto.
3266
270768cd
PE
32672011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3268
077e3dda 3269 Fix minor new problems caught by GCC 4.6.1.
270768cd 3270 * term.c (init_tty): Remove unused local.
490011a6 3271 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3272 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3273 not used otherwise.
270768cd 3274
b1f58454
CY
32752011-07-12 Chong Yidong <cyd@stupidchicken.com>
3276
3277 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3278
22b9578d
LMI
32792011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3280
6e70ab07
LMI
3281 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3282 are the mini-buffer and the echo area (bug#3320).
3283
22b9578d
LMI
3284 * term.c (init_tty): Remove support for supdup, c10 and perq
3285 terminals, which are no longer supported (bug#1482).
3286
8974cc9f
JB
32872011-07-10 Johan Bockgård <bojohan@gnu.org>
3288
3289 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3290
a560d974
JD
32912011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3292
3293 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3294 for non-popups (Bug#3642).
3295
1dae0f0a
AS
32962011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3297
268c2c36 3298 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3299 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3300 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3301 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3302 * data.c (fmod): Likewise.
3303 * dispnew.c (swap_glyphs_in_rows): Likewise.
3304 * emacs.c (memory_warning_signal): Likewise.
3305 * floatfns.c (float_error): Likewise.
3306 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3307 (otf_open, font_otf_capability, generate_otf_features)
3308 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3309 Likewise.
3310 * image.c (pbm_read_file): Likewise.
3311 * indent.c (string_display_width): Likewise.
3312 * intervals.c (check_for_interval, search_for_interval)
3313 (inc_interval_count, count_intervals, root_interval)
3314 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3315 * lread.c (defalias): Likewise.
268c2c36 3316 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3317 * regex.c (set_image_of_range_1, set_image_of_range)
3318 (regex_grow_registers): Likewise.
3319 * sysdep.c (strerror): Likewise.
3320 * termcap.c (valid_filename_p, tprint, main): Likewise.
3321 * tparam.c (main): Likewise.
3322 * unexhp9k800.c (run_time_remap, save_data_space)
3323 (update_file_ptrs, read_header, write_header, calculate_checksum)
3324 (copy_file, copy_rest, display_header): Likewise.
3325 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3326 Likewise.
3327 * xdisp.c (check_it): Likewise.
3328 * xfaces.c (register_color, unregister_color, unregister_colors):
3329 Likewise.
3330 * xfns.c (print_fontset_result): Likewise.
3331 * xrdb.c (member, fatal, main): Likewise.
3332
99033785
PE
33332011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3334
3335 Fix minor problems found by static checking (Bug#9031).
3336 * chartab.c (char_table_set_range, map_sub_char_table):
3337 Remove unused locals.
3338 (uniprop_table): Now static.
3339 * composite.c (_work_char): Remove unused static var.
3340
9cb2ac56
JB
33412011-07-09 Juanma Barranquero <lekktu@gmail.com>
3342
3343 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3344
f25661f0
JD
33452011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3346
3347 * gtkutil.c (qttip_cb): Remove code without function.
3348
8278c4fe
EZ
33492011-07-09 Eli Zaretskii <eliz@gnu.org>
3350
3351 * w32.c (pthread_sigmask): New stub.
3352
1692ae2d 33532011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3354
8a6ebd58 3355 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3356 sigprocmask is portable only for single-threaded applications, and
3357 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3358 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3359 (LIBES): Use it.
3360 * callproc.c (Fcall_process):
3361 * process.c (create_process):
3362 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3363 Use pthread_sigmask, not sigprocmask.
123403e4 3364
1b854618
JD
33652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3366
3367 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3368 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3369 wrong (Bug#8591).
3370
3fe4b549
JD
33712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3372
0ce7e563
JD
3373 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3374 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3375 (xg_hide_tooltip): Fix comment.
3376
3fe4b549
JD
3377 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3378 in registerServicesMenuSendTypes.
3379 (validRequestorForSendType): Don't check ns_return_types.
3380
3381 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3382 ns_return_type.
3383
5df75e47
JR
33842011-07-08 Jason Rumney <jasonr@gnu.org>
3385
22610910
JR
3386 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3387 SH_SHOW for hidden windows (Bug#5482).
3388
5df75e47
JR
3389 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3390 frame struct members of non-existent frames (Bug#6284).
3391
699c10bd
JD
33922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3393
4393663b
JD
3394 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3395 variable firstTime not needed on OSX >= 10.6.
3396 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3397 >= 10.5. Use setKnobProportion, setDoubleValue.
3398
3399 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3400 (MAC_OS_X_VERSION_10_5): Define if not defined.
3401 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3402 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3403 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3404
3405 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3406 cString and lossyCString on OSX >= 10.4
3407
58179cce 3408 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3409 sizeToFit on OSX >= 10.2.
3410
3411 * nsimage.m (allocInitFromFile): Don't use deprecated method
3412 bestRepresentationForDevice on OSX >= 10.6.
3413
3414 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3415 to avoid warning.
3416
3417 * emacs.c: Declare unexec_init_emacs_zone.
3418
a63e0781
JD
3419 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3420
699c10bd
JD
3421 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3422
3423 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3424 on svcsMenu (Bug#8842).
3425
3426 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3427 ns_return_types.
3428 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3429
3430 * nsterm.m (QUTF8_STRING): Declare.
3431 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3432 (validRequestorForSendType): Return type is (id).
3433 Change indexOfObjectIdenticalTo to indexOfObject.
3434 Check if we have local selection before returning self (Bug#8842).
3435 (writeSelectionToPasteboard): Put local selection into paste board
3436 if we have a local selection (Bug#8842).
3437 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3438
3439 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3440 (ns_get_local_selection): Declare.
3441
54e10184
LMI
34422011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3443
9888ff71
LMI
3444 * keymap.c (describe_map_tree): Don't insert a double newline at
3445 the end of the buffer (bug#1169) and return whether we inserted
3446 something.
3447
54e10184
LMI
3448 * callint.c (Fcall_interactively): Change "reading args" to
3449 "providing args" to try to clarify what it does (bug#1010).
3450
15fa4783
KH
34512011-07-07 Kenichi Handa <handa@m17n.org>
3452
3453 * composite.c (composition_compute_stop_pos): Ignore a static
3454 composition starting before CHARPOS (Bug#8915).
3455
3456 * xdisp.c (handle_composition_prop): Likewise.
3457
a8815b00
EZ
34582011-07-07 Eli Zaretskii <eliz@gnu.org>
3459
3460 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3461 (Bug#9015)
3462
ef7b981d 34632011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3464
3465 * character.h (unicode_category_t): New enum type.
3466
3467 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3468 (Qchar_code_property_table): New variable.
3469 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3470 (UNIPROP_COMPRESSED_FORM_P): New macros.
3471 (char_table_ascii): Uncompress the compressed values.
3472 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3473 Uncompress the compressed values.
ac389d0c 3474 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3475 (char_table_ref_and_range): Uncompress the compressed values.
3476 (sub_char_table_set): New arg is_uniprop. Callers changed.
3477 Uncompress the compressed values.
3478 (sub_char_table_set_range): Args changed. Callers changed.
3479 (char_table_set_range): Adjuted for the above change.
3480 (map_sub_char_table): Delete args default_val and parent. Add arg
3481 top. Give decoded values to a Lisp function.
640c8776 3482 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3483 values to a Lisp function. Gcpro more variables.
3484 (uniprop_table_uncompress)
3485 (uniprop_decode_value_run_length): New functions.
3486 (uniprop_decoder, uniprop_decoder_count): New variables.
3487 (uniprop_get_decoder, uniprop_encode_value_character)
3488 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3489 New functions.
3490 (uniprop_encoder, uniprop_encoder_count): New variables.
3491 (uniprop_get_encoder, uniprop_table)
3492 (Funicode_property_table_internal, Fget_unicode_property_internal)
3493 (Fput_unicode_property_internal): New functions.
3494 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3495 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3496 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3497 char-code-property-alist.
3498
640c8776 3499 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3500 Vunicode_category_table.
3501
640c8776 3502 * font.c (font_range): Adjust for the change of
c805dec0
KH
3503 Vunicode_category_table.
3504
76b397fb
DN
35052011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3506
3507 * m/iris4d.h: Remove file, move contents ...
3508 * s/irix6-5.h: ... here.
3509
22b4128e
PE
35102011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3511
3512 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3513 * alloc.c (mark_buffer):
3514 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3515 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3516 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3517 This isn't true in general, and it's particularly not true
3518 if Emacs is configured with --with-wide-int.
3519 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3520 New macros, used in the buffer.c change.
3521
869795d6
JD
35222011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3523
3524 * xsettings.c: Use both GConf and GSettings if both are available.
3525 (store_config_changed_event): Add comment.
3526 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3527 (store_tool_bar_style_changed): New functions.
5e617bc2 3528 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3529 (struct xsettings): Move font inside HAVE_XFT.
3530 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3531 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3532 Move inside HAVE_XFT.
640c8776 3533 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3534 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3535 also.
3536 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3537 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3538 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3539 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3540 (parse_settings): Move check for font inside HAVE_XFT.
3541 (read_settings, apply_xft_settings): Add comment.
3542 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3543 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3544 call store_font_name_changed.
3545 (xft_settings_event): Add comment.
3546 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3547 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3548 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3549 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3550 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3551 (xsettings_get_system_font, xsettings_get_system_normal_font):
3552 Add comment.
869795d6 3553
d8ed26bd
PE
35542011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 Random fixes. E.g., (random) never returned negative values.
3557 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3558 subseconds part to the entropy, as that's a bit more random.
3559 Prefer signed to unsigned, since the signedness doesn't matter and
3560 in general we prefer signed. When given a limit, use a
3561 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3562 latter isn't right if USE_2_TAGS_FOR_INTS.
3563 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3564 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3565
cabf1cac
SM
35662011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3567
3568 * textprop.c (text_property_stickiness):
3569 Obey Vtext_property_default_nonsticky.
3570 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3571 * w32fns.c (syms_of_w32fns):
3572 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3573
6e9b2be9
PE
35742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3577 This is more efficient than Ffile_directory_p and avoids a minor race.
3578
90186c68
LMI
35792011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580
7c301272
LMI
3581 * buffer.c (Foverlay_put): Say what the return value is
3582 (bug#7835).
3583
c4f2d8d4
LMI
3584 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3585 is a directory before asking whether to use the file name
3586 (bug#7564).
ad637907
LMI
3587 (barf_or_query_if_file_exists): Make the "File is a directory"
3588 error be more correct.
c4f2d8d4 3589
90186c68
LMI
3590 * fns.c (Frequire): Remove the mention of the .gz files, since
3591 that's installation-specific, but keep the mention of
3592 `get-load-suffixes'.
3593
da64016e
PE
35942011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3595
3596 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3597 Report string overflow if the output is too long.
3598
7d47b580
JB
35992011-07-04 Juanma Barranquero <lekktu@gmail.com>
3600
a555cb87
JB
3601 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3602 (syms_of_gnutls): Remove duplicate DEFSYM for
3603 Qgnutls_bootprop_verify_hostname_error, an error for
3604 Qgnutls_bootprop_verify_error (which is no longer used).
3605
7d47b580
JB
3606 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3607 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3608 Also (re)move comments that are misplaced or no longer relevant.
3609
1e49bfab
LMI
36102011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3611
3612 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3613
1485f4c0
CY
36142011-07-03 Chong Yidong <cyd@stupidchicken.com>
3615
3616 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3617 and background color parameters if they have been changed.
3618
a9ab721e
LMI
36192011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3620
3621 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3622
cf7cff57
PE
36232011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3624
2e13213d
PE
3625 * xsettings.c (SYSTEM_FONT): Define only when used.
3626 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3627
cf7cff57
PE
3628 * keymap.c (access_keymap_1): Now static.
3629
7a8e04f7
CY
36302011-07-02 Chong Yidong <cyd@stupidchicken.com>
3631
3632 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3633 leave any prefix arg for the up event (Bug#1586).
3634
61352f62
LMI
36352011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3636
69bb1ef7
LMI
3637 * lread.c (syms_of_lread): Mention single symbols defined by
3638 `defvar' or `defconst' (bug#7154).
3639
61352f62 3640 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3641 (Frequire): Mention get-load-suffixes.
61352f62 3642
28545e04
MR
36432011-07-02 Martin Rudalics <rudalics@gmx.at>
3644
3645 * window.h (window): Remove clone_number slot.
3646 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3647 Remove.
3648 (make_parent_window, make_window, saved_window)
3649 (Fset_window_configuration, save_window_save): Don't deal with
3650 clone numbers.
3651 * buffer.c (Qclone_number): Remove declaration.
3652 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3653
3349e122
SM
36542011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3655
3656 Add multiple inheritance to keymaps.
3657 * keymap.c (Fmake_composed_keymap): New function.
3658 (Fset_keymap_parent): Simplify.
3659 (fix_submap_inheritance): Remove.
3660 (access_keymap_1): New function extracted from access_keymap to handle
3661 embedded parents and handle lists of maps.
3662 (access_keymap): Use it.
3663 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3664 (Fcopy_keymap): Handle embedded parents.
3665 (Fcommand_remapping, define_as_prefix): Simplify.
3666 (Fkey_binding): Simplify.
3667 (syms_of_keymap): Move minibuffer-local-completion-map,
3668 minibuffer-local-filename-completion-map,
3669 minibuffer-local-must-match-map, and
3670 minibuffer-local-filename-must-match-map to Elisp.
3671 (syms_of_keymap): Defsubr make-composed-keymap.
3672 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3673 (parse_menu_item): Trivial simplification.
3674
3279eb87
GM
36752011-07-01 Glenn Morris <rgm@gnu.org>
3676
3677 * Makefile.in (SETTINGS_LIBS): Fix typo.
3678
4550efdf
KI
36792011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3680
3681 * coding.c (Fencode_coding_string): Record the last coding system
3682 used, as the function doc string says (bug#8738).
3683
0949d2b6
JD
36842011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3685
3686 * xsettings.c (store_monospaced_changed): Take new font as arg and
3687 check for change against current_mono_font.
3688 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3689 (emacs_settings_constructor, emacs_settings_get_property)
3690 (emacs_settings_set_property, emacs_settings_class_init)
3691 (emacs_settings_init, gsettings_obj): Remove.
3692 (something_changedCB): New function for HAVE_GSETTINGS.
3693 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3694 with value as argument.
3695 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3696 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3697 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3698 "changed".
3699
3700 * xgselect.c: Add defined (HAVE_GSETTINGS).
3701 (xgselect_initialize): Ditto.
3702
3703 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3704 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3705 xg_select.
3706
bbc6b304
PE
37072011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3708
3709 * eval.c (struct backtrace): Simplify and port the data structure.
3710 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3711 signed bit field, as this assumption is not portable and it makes
3712 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3713 "char debug_on_exit : 1" as this is not portable either; instead,
3714 use the portable "unsigned int debug_on_exit : 1". Remove unused
3715 member evalargs. Remove obsolete comments about cc bombing out.
3716
9851bfc5
JD
37172011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3718
51bb811f 3719 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3720 Let HAVE_GSETTINGS override HAVE_GCONF.
3721 (store_monospaced_changed): New function.
3722 (EMACS_SETTINGS): A new type derived from GObject to handle
3723 GSettings notifications.
3724 (emacs_settings_constructor, emacs_settings_get_property)
3725 (emacs_settings_set_property, emacs_settings_class_init):
3726 New functions.
3727 (gsettings_client, gsettings_obj): New variables.
3728 (GSETTINGS_SCHEMA): New define.
3729 (something_changedCB): Call store_monospaced_changed.
3730 (init_gsettings): New function.
3731 (xsettings_initialize): Call init_gsettings.
3732 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3733 to NULL.
3734
640c8776 3735 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3736 GCONF_CFLAGS/LIBS.
3737
5386012d
MR
37382011-06-29 Martin Rudalics <rudalics@gmx.at>
3739
3740 * window.c (resize_root_window, grow_mini_window)
3741 (shrink_mini_window): Rename Qresize_root_window to
3742 Qwindow_resize_root_window and Qresize_root_window_vertically to
3743 Qwindow_resize_root_window_vertically.
3744
f13e0b08
PE
37452011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3748
94515237
JB
37492011-06-27 Juanma Barranquero <lekktu@gmail.com>
3750
3751 * makefile.w32-in: Redesign dependencies so they reflect more
3752 clearly which files are directly included by each source file,
3753 and not through other includes.
3754
e43b6e43
MR
37552011-06-27 Martin Rudalics <rudalics@gmx.at>
3756
3757 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3758 (sort_overlays, overlay_strings): When an overlay's clone number
3759 matches the window's clone number process the overlay even if
3760 the overlay's window property doesn't match the current window.
3761
d68443dc
MR
3762 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3763 (Fwindow_hchild): Rename to Fwindow_left_child.
3764 (Fwindow_next): Rename to Fwindow_next_sibling.
3765 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3766 (resize_window_check): Rename to window_resize_check.
3767 (resize_window_apply): Rename to window_resize_apply.
3768 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3769 (Fdelete_other_windows_internal, resize_frame_windows)
3770 (Fsplit_window_internal, Fdelete_window_internal)
3771 (grow_mini_window, shrink_mini_window)
3772 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3773
c7e73be5
JD
37742011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3775
3776 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3777 (emacs_fixed_set_min_size): Remove.
3778 (emacs_fixed_new): Take frame as argument.
3779
3780 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3781 (_EmacsFixedPrivate): Remove minwidth/height.
3782 Add struct frame *f.
3783 (emacs_fixed_init): Initialize priv->f.
3784 (get_parent_class, emacs_fixed_set_min_size): Remove.
3785 (emacs_fixed_new): Set priv->f to argument.
3786 (emacs_fixed_get_preferred_width)
3787 (emacs_fixed_get_preferred_height): Use min_width/height from
3788 frames size_hint to set minimum and natural (Bug#8919).
3789 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3790 and use min_width/height from frames size_hint to set
3791 min_width/height (Bug#8919).
3792
3793 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3794 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3795 Fix indentation.
c7e73be5 3796
cf99dcf8
EZ
37972011-06-26 Eli Zaretskii <eliz@gnu.org>
3798
3799 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3800 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3801 called at ZV.
3802
029529ac
CY
38032011-06-26 Chong Yidong <cyd@stupidchicken.com>
3804
3805 * process.c (wait_reading_process_output): Bypass select if
3806 waiting for a cell while ignoring keyboard input, and input is
3807 pending. Suggested by Jan Djärv (Bug#8869).
3808
7a7ef429
PE
38092011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3810
3811 Use gnulib's dup2 module instead of rolling our own.
3812 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3813
11fdef7d 38142011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3815
3816 * dispnew.c (scrolling_window): Before scrolling, turn off a
3817 mouse-highlight in the window being scrolled.
3818
cd3520a4
JB
38192011-06-24 Juanma Barranquero <lekktu@gmail.com>
3820
3821 Move DEFSYM to lisp.h and use everywhere.
3822
3823 * character.h (DEFSYM): Move declaration...
3824 * lisp.h (DEFSYM): ...here.
3825
3826 * gnutls.c:
3827 * minibuf.c:
3828 * w32menu.c:
3829 * w32proc.c:
3830 * w32select.c: Don't include character.h.
3831
3832 * alloc.c (syms_of_alloc):
3833 * buffer.c (syms_of_buffer):
3834 * bytecode.c (syms_of_bytecode):
3835 * callint.c (syms_of_callint):
3836 * casefiddle.c (syms_of_casefiddle):
3837 * casetab.c (init_casetab_once):
3838 * category.c (init_category_once, syms_of_category):
3839 * ccl.c (syms_of_ccl):
3840 * cmds.c (syms_of_cmds):
3841 * composite.c (syms_of_composite):
3842 * dbusbind.c (syms_of_dbusbind):
3843 * dired.c (syms_of_dired):
3844 * dispnew.c (syms_of_display):
3845 * doc.c (syms_of_doc):
3846 * editfns.c (syms_of_editfns):
3847 * emacs.c (syms_of_emacs):
3848 * eval.c (syms_of_eval):
3849 * fileio.c (syms_of_fileio):
3850 * fns.c (syms_of_fns):
3851 * frame.c (syms_of_frame):
3852 * fringe.c (syms_of_fringe):
3853 * insdel.c (syms_of_insdel):
3854 * keymap.c (syms_of_keymap):
3855 * lread.c (init_obarray, syms_of_lread):
3856 * macros.c (syms_of_macros):
3857 * msdos.c (syms_of_msdos):
3858 * print.c (syms_of_print):
3859 * process.c (syms_of_process):
3860 * search.c (syms_of_search):
3861 * sound.c (syms_of_sound):
3862 * syntax.c (init_syntax_once, syms_of_syntax):
3863 * terminal.c (syms_of_terminal):
3864 * textprop.c (syms_of_textprop):
3865 * undo.c (syms_of_undo):
3866 * w32.c (globals_of_w32):
3867 * window.c (syms_of_window):
3868 * xdisp.c (syms_of_xdisp):
3869 * xfaces.c (syms_of_xfaces):
3870 * xfns.c (syms_of_xfns):
3871 * xmenu.c (syms_of_xmenu):
3872 * xsettings.c (syms_of_xsettings):
3873 * xterm.c (syms_of_xterm): Use DEFSYM.
3874
4228cf16
TZ
38752011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3876
cd3520a4 3877 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3878
7fcccf1e
PE
38792011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3880
7efb4e0e
PE
3881 Integer and buffer overflow fixes (Bug#8873).
3882
ff5844ad
PE
3883 * print.c (printchar, strout): Check for string overflow.
3884 (PRINTPREPARE, printchar, strout):
3885 Don't set size unless allocation succeeds.
3886
90532f02
PE
3887 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3888 for sizes. Check for string overflow more accurately.
3889 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3890
6d84508d
PE
3891 * macros.c: Integer and buffer overflow fixes.
3892 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3893 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3894 Use ptrdiff_t, not int, for sizes.
3895 Don't increment bufsize until after realloc succeeds.
3896 Check for size-calculation overflow.
3897 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3898
437b2cb4
PE
3899 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3900
8b9ac8b4
PE
3901 * lread.c: Integer overflow fixes.
3902 (read_integer): Radix is now EMACS_INT, not int,
3903 to improve quality of diagnostics for out-of-range radices.
3904 Calculate buffer size correctly for out-of-range radices.
3905 (read1): Check for integer overflow in radices, and in
3906 read-circle numbers.
82cb60d3
PE
3907 (read_escape): Avoid int overflow.
3908 (Fload, openp, read_buffer_size, read1)
3909 (substitute_object_recurse, read_vector, read_list, map_obarray):
3910 Use ptrdiff_t, not int, for sizes.
3911 (read1): Use EMACS_INT, not int, for sizes.
20270765 3912 Check for size overflow.
8b9ac8b4 3913
7fcccf1e
PE
3914 * image.c (cache_image): Check for size arithmetic overflow.
3915
bfbbd7e7
PE
3916 * lread.c: Integer overflow issues.
3917 (saved_doc_string_size, saved_doc_string_length)
3918 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3919 Now ptrdiff_t, not int.
3920 (read1): Don't assume doc string length fits in int. Check for
3921 out-of-range doc string lengths.
3922 (read_list): Don't assume file position fits in int.
39019e54 3923 (read_escape): Check for hex character overflow.
bfbbd7e7 3924
4e323265
LL
39252011-06-22 Leo Liu <sdl.web@gmail.com>
3926
3927 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3928 Move to minibuffer.el.
3929
85fece3e
PE
39302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3931
20b84ce9 3932 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3933 The following patches are for when GLYPH_DEBUG && !XASSERT.
3934 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3935 * dispnew.c (flush_stdout):
3936 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3937 Mark as externally visible.
3938 * dispnew.c (check_window_matrix_pointers): Now static.
3939 * dispnew.c (window_to_frame_vpos):
3940 * xfns.c (unwind_create_frame):
3941 * xterm.c (x_check_font): Remove unused local.
3942 * scroll.c (CHECK_BOUNDS):
3943 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3944 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3945 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3946 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3947 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3948 Now static.
3949 (debug_method_add): Use va_list and vsprintf rather than relying
3950 on undefined behavior with wrong number of arguments.
3951 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3952 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3953 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3954 since we're not interested in debugging glyphs with old libraries.
3955 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3956 GCC 4.6.0's static checking.
3957
0766b489
PE
39582011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3959
31fd4b32
PE
3960 Integer overflow and signedness fixes (Bug#8873).
3961 A few related buffer overrun fixes, too.
3962
b79e8648
PE
3963 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3964
0766b489
PE
3965 * dispextern.h (struct face.stipple):
3966 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3967 (x_bitmap_mask, x_allocate_bitmap_record)
3968 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3969 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3970 (x_create_bitmap_from_xpm_data):
3971 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3972 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3973 (.bitmaps_last):
3974 * xfaces.c (load_pixmap):
3975 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3976 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3977 (.bitmaps_last, struct x_output.icon_bitmap):
3978 Use ptrdiff_t, not int, for bitmap indexes.
3979 (x_allocate_bitmap_record): Check for size overflow.
3980 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3981
b081724f
PE
3982 Use ptrdiff_t, not int, for overlay counts.
3983 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3984 * editfns.c (overlays_around, get_pos_property):
3985 * textprop.c (get_char_property_and_overlay):
3986 * xdisp.c (next_overlay_change, note_mouse_highlight):
3987 * xfaces.c (face_at_buffer_position):
21514da7
PE
3988 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3989 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3990 (Fnext_overlay_change, Fprevious_overlay_change)
3991 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3992 Use ptrdiff_t, not int, for sizes.
21514da7 3993 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3994
3de73e5e
PE
3995 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3996
2606c57b
PE
3997 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3998 (x_session_initialize): Do not assume string length fits in int.
3999
aaafe47a
PE
4000 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4001 This is unlikely, but can occur if DPI is outlandish.
4002
2674ddc8 4003 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4004 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4005
28154962
PE
4006 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4007 * xrdb.c (magic_file_p, search_magic_path):
4008 Omit last arg SUFFIX; it was always 0. All callers changed.
4009 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4010
7de51af5
PE
4011 * xfont.c (xfont_match): Avoid need for strlen.
4012
25ed6cc3
PE
4013 * xfns.c: Don't assume strlen fits in int.
4014 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4015
4eab31dd
PE
4016 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4017 not unsigned long, as we prefer signed integers. All callers changed.
4018 Detect integer overflow in repeat count.
4019 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4020 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4021
171e2a58
PE
4022 * termcap.c: Don't assume sizes fit in int and never overflow.
4023 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4024 (gobble_line): Check for size-calculation overflow.
4025
ad39faca 4026 * minibuf.c (Fread_buffer):
6e5bb2dc 4027 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4028 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4029 Don't assume string length fits in int.
4030
52c61c22 4031 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4032 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4033
b5b8c9e5
PE
4034 * font.c: Don't assume string length fits in int.
4035 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4036 Use ptrdiff_t, not int.
ccd6111c
PE
4037 (font_intern_prop): Don't assume string length fits in int.
4038 Don't assume integer property fits in fixnum.
4039 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4040
882f0d81 4041 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4042 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4043 Reformulate so as not to need the command string.
4044 Invoke gzip -cd rather than gunzip, as it's more portable.
4045 (lock_info_type, lock_file_1, lock_file):
4046 Don't assume pid_t and time_t fit in unsigned long.
4047 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4048 (current_lock_owner): Prefer signed type for sizes.
4049 Use memcpy, not strncpy, where memcpy is what is really wanted.
4050 Don't assume (via atoi) that time_t and pid_t fit in int.
4051 Check for time_t and/or pid_t out of range, e.g., via a network share.
4052 Don't alloca where an auto var works fine.
4053
93f4cf88
PE
4054 * fileio.c: Fix some integer overflow issues.
4055 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4056 Don't assume string length fits in int.
4057 (directory_file_name): Don't assume string length fits in long.
4058 (make_temp_name): Don't assume pid fits in int, or that its print
4059 length is less than 20.
4060
f3e92b69
PE
4061 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4062
1bfdaf10
PE
4063 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4064
35016e9a
PE
4065 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4066
3d1e65a1
PE
4067 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4068 We prefer signed integers, even for size calculations.
4069
0b963a93
PE
4070 * emacs.c: Don't assume string length fits in 'int'.
4071 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4072 (main): Don't invoke strlen when not needed.
4073
573f4b54
PE
4074 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4075 (XD_DEBUG_MESSAGE): Don't waste a byte.
4076
989f33ba
PE
4077 * callproc.c (getenv_internal_1, getenv_internal)
4078 (Fgetenv_internal):
965d34eb
PE
4079 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4080
e4d29b33
PE
4081 * lread.c (invalid_syntax): Omit length argument.
4082 All uses changed. This doesn't fix a bug, but it simplifies the
4083 code away from its former Hollerith-constant appearance, and it's
4084 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4085 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4086
eb49b136
PE
4087 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4088 This didn't break anything, but it didn't help either.
4089 It's confusing to put a bogus integer in a place where the actual
4090 value does not matter.
9f62aeb1 4091 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4092 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4093
15375a22
PE
4094 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4095 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4096 implementation.
b61cc01c
PE
4097 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4098 We prefer signed types, and the value cannot exceed the EMACS_INT
4099 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4100 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4101 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4102 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4103
53b2623d
PE
4104 * indent.c (sane_tab_width): New function.
4105 (current_column, scan_for_column, Findent_to, position_indentation)
4106 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4107 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4108
51cab52b 4109 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4110
f2ed8a70
PE
4111 * lisp.h (lint_assume): New macro.
4112 * composite.c (composition_gstring_put_cache):
4113 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4114
abe80cc6
PE
4115 * editfns.c, insdel.c:
4116 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4117
b02c740e
PE
4118 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4119
ebc96716
PE
4120 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4121
b4e50fa0 4122 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4123 Use much-faster test for byte-length change.
311d5d7c 4124 Don't assume string byte-length fits in 'int'.
a4cf38e4 4125 Check that character arg fits in 'int'.
85461888 4126 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4127
c0c1ee9f
PE
4128 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4129
a498d7f4
PE
4130 * fns.c (concat): Catch string overflow earlier.
4131 Do not rely on integer wraparound.
4132
51cab52b
PE
4133 * dispextern.h (struct it.overlay_strings_charpos)
4134 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4135 * xdisp.c (forward_to_next_line_start)
4136 (back_to_previous_visible_line_start)
4137 (reseat_at_next_visible_line_start, next_element_from_buffer):
4138 Don't arbitrarily truncate the value of 'selective' to int.
4139
76031fad
PE
4140 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4141
5eb55db9
PE
4142 * composite.c: Don't truncate sizes to 'int'.
4143 (composition_gstring_p, composition_reseat_it)
4144 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4145 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4146 not EMACS_UINT, for indexes.
5eb55db9 4147
0703a717
PE
4148 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4149
d6202519
PE
4150 * buffer.c: Include <verify.h>.
4151 (struct sortvec.priority, struct sortstr.priority):
8961a454 4152 Now EMACS_INT, not int.
c20998a7 4153 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4154 (struct sortstr.size, record_overlay_string)
4155 (struct sortstrlist.size, struct sortlist.used):
4156 Don't truncate size to int.
4157 (record_overlay_string): Check for size-calculation overflow.
d6202519 4158 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4159
d5a19415
JM
41602011-06-22 Jim Meyering <meyering@redhat.com>
4161
029529ac 4162 Don't leak an XBM-image-sized buffer
d5a19415
JM
4163 * image.c (xbm_load): Free the image buffer after using it.
4164
a9041e6c
PE
41652011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4166
4167 Port to Sun C.
4168 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4169 that Sun C diagnosed.
4170 * fns.c (secure_hash): Fix pointer signedness issue.
4171 * intervals.c (static_offset_intervals): New function.
4172 (offset_intervals): Use it.
4173
7f3f739f
LL
41742011-06-21 Leo Liu <sdl.web@gmail.com>
4175
4176 * deps.mk (fns.o):
4177 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4178 sha512.h.
4179
4180 * fns.c (secure_hash): Rename from crypto_hash_function and change
4181 the first arg to accept symbols.
5b66d427 4182 (Fsecure_hash): New primitive.
7f3f739f
LL
4183 (syms_of_fns): New symbols.
4184
76147d94
DD
41852011-06-20 Deniz Dogan <deniz@dogan.se>
4186
4187 * process.c (Fset_process_buffer): Clarify return value in
4188 docstring.
4189
7d7d0045
CY
41902011-06-18 Chong Yidong <cyd@stupidchicken.com>
4191
4192 * dispnew.c (add_window_display_history): Use BVAR.
4193
4194 * xdisp.c (debug_method_add): Use BVAR.
4195 (check_window_end, dump_glyph_matrix, dump_glyph)
4196 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4197
4198 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4199 Likewise.
4200
4201 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4202 check till after the cache is created in init_frame_faces.
4203
ff2bc410
SM
42042011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4205
4206 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4207
28177add
PE
42082011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4209
dd3482fe
PE
4210 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4211 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4212 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4213
393d71f3 4214 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4215 * fileio.c (Finsert_file_contents):
4216 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4217 Remove the old (too-loose) buffer overflow checks.
4218 They weren't needed, since make_gap checks for buffer overflow.
4219 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4220 The old code merely checked for Emacs fixnum overflow, and relied
4221 on undefined (wraparound) behavior. The new code avoids undefined
4222 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4223
2e6813b0 4224 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4225 Tune. Don't use wider integers than needed. Don't use alloca.
4226 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4227
599a9e4f
PE
4228 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4229
99561444
PE
4230 * insdel.c, lisp.h (buffer_overflow): New function.
4231 (insert_from_buffer_1, replace_range, replace_range_2):
4232 * insdel.c (make_gap_larger):
4233 * editfns.c (Finsert_char):
4234 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4235
28177add
PE
4236 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4237
e69dafad
PE
42382011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4239
a7af7fde 4240 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4241
b1c46f02
PE
4242 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4243 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4244
e69dafad
PE
4245 * fileio.c: Don't assume EMACS_INT fits in off_t.
4246 (emacs_lseek): New static function.
4247 (Finsert_file_contents, Fwrite_region): Use it.
4248 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4249
566684ea
PE
4250 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4251
e6966cd6
PE
4252 * fns.c: Don't overflow int when computing a list length.
4253 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4254 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4255 truncation on 64-bit hosts. Check for QUIT every
4256 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4257 faster and is responsive enough.
4258 (Flength): Report an error instead of overflowing an integer.
4259 (Fsafe_length): Return a float if the value is not representable
4260 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4261 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4262 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4263
dd0b0efb
PE
4264 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4265 (header_size, word_size): New constants.
4266 (allocate_vectorlike): Don't check size overflow here.
4267 (allocate_vector): Check it here instead, since this is the only
4268 caller of allocate_vectorlike that could cause overflow.
4269 Check that the new vector's length is representable as a fixnum.
4270
86fe5cfe
PE
4271 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4272 The previous code was bogus. For example, next_almost_prime (32)
4273 returned 39, which is undesirable as it is a multiple of 3; and
4274 next_almost_prime (24) returned 25, which is a multiple of 5 so
4275 why was the code bothering to check for multiples of 7?
4276
80e88859
PE
4277 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4278
4a2f0ad6
PE
4279 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4280
f66c7cf8
PE
4281 Variadic C functions now count arguments with ptrdiff_t.
4282 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4283 Back then I didn't know that the Emacs coding style prefers signed int.
4284 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4285 were being counted with int, which may truncate counts on 64-bit
4286 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4287 * lisp.h (struct Lisp_Subr.function.aMANY)
4288 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4289 Arg counts are now ptrdiff_t, not size_t.
4290 All variadic functions and their callers changed accordingly.
4291 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4292 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4293 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4294 * callint.c (Fcall_interactively): Check arg count for overflow,
4295 to avoid potential buffer overrun. Use signed char, not 'int',
4296 for 'varies' array, so that we needn't bother to check its size
4297 calculation for overflow.
4298 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4299 * eval.c (apply_lambda):
4300 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4301 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4302 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4303
a1759b76
PE
4304 * callint.c (Fcall_interactively): Don't use index var as event count.
4305
d96be9fc
PE
4306 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4307 * mem-limits.h (SIZE): Remove; no longer used.
4308
a690a978 4309 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4310
578c21e6
PE
4311 Remove unnecessary casts.
4312 * xterm.c (x_term_init):
4313 * xfns.c (x_set_border_pixel):
4314 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4315 These aren't needed now that we assume ANSI C.
4316
96f53c6c
PE
4317 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4318 It's more likely to cause problems (due to unsigned overflow)
4319 than to cure them.
4320
83c77d31
PE
4321 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4322
ee2079f1
PE
4323 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4324
6da65536
PE
4325 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4326
7147c4a4
PE
4327 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4328
193e32d9
PE
4329 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4330
e5533da6
PE
4331 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4332
9910e595
PE
4333 GLYPH_CODE_FACE returns EMACS_INT, not int.
4334 * dispextern.h (merge_faces):
4335 * xfaces.c (merge_faces):
01103c44
PE
4336 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4337 Don't assume EMACS_INT fits in int.
9910e595 4338
2638320e
PE
4339 * character.h (CHAR_VALID_P): Remove unused parameter.
4340 * fontset.c, lisp.h, xdisp.c: All uses changed.
4341
045eb8d9
PE
4342 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4343
c1f134b5
PE
4344 * fns.c (concat): Minor tuning based on overflow analysis.
4345 This doesn't fix any bugs. Use int to hold character, instead
4346 of constantly refetching from Emacs object. Use XFASTINT, not
4347 XINT, for value known to be a character. Don't bother comparing
4348 a single byte to 0400, as it's always less.
4349
395fcb93 4350 * floatfns.c (Fexpt):
327eeec8
PE
4351 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4352
abbd3d23
PE
4353 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4354 for characters.
4355
684a03ef
PE
4356 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4357
0fed43f3
PE
4358 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4359 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4360 incorrectly succeed when S was a string, because 4294967386 was
4361 truncated before it was used.
4362
8fd02eb7
PE
4363 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4364 Otherwise, an out-of-range integer could cause undefined behavior
4365 on a 64-bit host.
4366
f8c86b69
PE
4367 * composite.c: Use int, not EMACS_INT, for characters.
4368 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4369 EMACS_INT, for values that are known to be in character range.
4370 This doesn't fix any bugs but is the usual style inside Emacs and
4371 may generate better code on 32-bit machines.
4372
34206dd2
PE
4373 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4374 This is for reasons similar to the recent CHAR_STRING fix.
4375 * charset.c (Fencode_char): Check that character arg is actually
4376 a character. Pass an int to ENCODE_CHAR.
4377 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4378 wider than 'int', as a compile-time check to prevent future regressions
4379 in this area.
4380
c5958d4c 4381 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4382
4383 Make sure a 64-bit char is never passed to CHAR_STRING.
4384 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4385 by silently ignoring the top 32 bits, allowing some values
4386 that were far too large to be valid characters.
4387 * character.h: Include <verify.h>.
4388 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4389 arguments are no wider than unsigned, as a compile-time check
4390 to prevent future regressions in this area.
4391 * data.c (Faset):
01103c44 4392 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4393 (Fsubst_char_in_region):
4394 * fns.c (concat):
4395 * xdisp.c (decode_mode_spec_coding):
4396 Adjust to CHAR_STRING's new requirement.
4397 * editfns.c (Finsert_char, Fsubst_char_in_region):
4398 * fns.c (concat): Check that character args are actually
4399 characters. Without this test, these functions did the wrong
4400 thing with wildly out-of-range values on 64-bit hosts.
4401
d37ca623
PE
4402 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4403 These casts should not be needed on 32-bit hosts, either.
4404 * keyboard.c (read_char):
4405 * lread.c (Fload): Remove casts to unsigned.
4406
ea204efb
PE
4407 * lisp.h (UNSIGNED_CMP): New macro.
4408 This fixes comparison bugs on 64-bit hosts.
4409 (ASCII_CHAR_P): Use it.
4410 * casefiddle.c (casify_object):
01103c44 4411 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4412 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4413 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4414 * dispextern.h (FACE_FROM_ID):
4415 * keyboard.c (read_char): Use UNSIGNED_CMP.
4416
41cb286c
PE
4417 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4418 not to EMACS_INT, to avoid GCC warning.
4419
4a1b9832
PE
4420 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4421
55daad71
PE
4422 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4423 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4424 isn't needed on 32-bit machines.
8f95c75c 4425
01103c44
PE
4426 * buffer.c (Fgenerate_new_buffer_name):
4427 Use EMACS_INT for count, not int.
0ceccced 4428 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4429
4430 * data.c (Qcompiled_function): Now static.
4431
c6f072e7
PE
4432 * window.c (window_body_lines): Now static.
4433
20ce5912
PE
4434 * image.c (gif_load): Rename local to avoid shadowing.
4435
9c4c5f81
PE
4436 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4437 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4438 * alloc.c (make_save_value): Integer argument is now of type
4439 ptrdiff_t, not int.
4440 (mark_object): Use ptrdiff_t, not int.
4441 * lisp.h (pD): New macro.
4442 * print.c (print_object): Use it.
4443
c0c5c8ae
PE
4444 * alloc.c: Use EMACS_INT, not int, to count objects.
4445 (total_conses, total_markers, total_symbols, total_vector_size)
4446 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4447 (total_free_floats, total_floats, total_free_intervals)
4448 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4449 Now EMACS_INT, not int. All uses changed.
4450 (Fgarbage_collect): Compute overall total using a double, so that
4451 integer overflow is less likely to be a problem. Check for overflow
4452 when converting back to an integer.
5a25e253
PE
4453 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4454 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4455 These were 'int' variables that could overflow on 64-bit hosts;
4456 they were never used, so remove them instead of repairing them.
211a0b2a 4457 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4458 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4459 Previously, this ceilinged at INT_MAX, but that doesn't work on
4460 64-bit machines.
e46bb31a 4461 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4462
c78baabf 4463 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4464 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4465 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4466 when a (possibly-narrower) signed value would do just as well.
4467 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4468
c9d624c6
PE
4469 * alloc.c: Catch some string size overflows that we were missing.
4470 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4471 for convenience in STRING_BYTES_MAX.
4472 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4473 The definition here is exact; the one in lisp.h was approximate.
4474 (allocate_string_data): Check for string overflow. This catches
4475 some instances we weren't catching before. Also, it catches
4476 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4477 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4478 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4479
c9d624c6
PE
4480 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4481 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4482 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4483
353032ce
PE
4484 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4485
2bccce07
PE
4486 * alloc.c (Fmake_string): Check for out-of-range init.
4487
0ac30604
SM
44882011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4489
4490 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4491
c195f2de
JD
44922011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4493
4494 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4495 xg_get_default_scrollbar_width.
4496
4497 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4498 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4499 (style_changed_cb): Call update_theme_scrollbar_width and call
4500 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4501 all frames (Bug#8505).
4502 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4503 Call gtk_window_set_resizable if HAVE_GTK3.
4504 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4505 and height if HAVE_GTK3 (Bug#8505).
4506 (scroll_bar_width_for_theme): New variable.
4507 (update_theme_scrollbar_width): New function.
4508 (xg_get_default_scrollbar_width): Move code to
4509 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4510 (xg_initialize): Call update_theme_scrollbar_width.
4511
4512 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4513
4514 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4515
e10ac9f1
MR
45162011-06-12 Martin Rudalics <rudalics@gmx.at>
4517
4518 * frame.c (make_frame): Call other_buffer_safely instead of
4519 other_buffer.
4520
4521 * window.c (temp_output_buffer_show): Call display_buffer with
4522 second argument Vtemp_buffer_show_specifiers and reset latter
4523 immediately after the call.
4524 (Vtemp_buffer_show_specifiers): New variable.
4525 (auto_window_vscroll_p, next_screen_context_lines)
4526 (Vscroll_preserve_screen_position): Remove leading asterisks from
4527 doc-strings.
4528
2d3c217e 45292011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4530
7b7f97e8 4531 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4532 * buffer.c (Qclone_number): Remove for now, as it's unused.
4533 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4534 (record_buffer): Remove unused local.
4535 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4536 (set_frame_buffer_list): Remove; unused.
4537 * frame.h (other_visible_frames): Remove decl.
4538 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4539 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4540 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4541 if HAVE_GPM.
4542 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4543 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4544 Define only if HAVE_GPM.
4545 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4546 (update_hints_inhibit): Remove; never set. All uses removed.
4547 * widgetprv.h (emacsFrameClassRec): Remove decl.
4548 * window.c (delete_deletable_window): Now returns void, since it
4549 wasn't returning anything.
4550 (compare_window_configurations): Remove unused locals.
4551 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4552 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4553 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4554 the same widths as pointers. This follows up on the 2011-05-06 patch.
4555 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4556 * xterm.h: Likewise.
4557 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4558
1384b89e
JB
45592011-06-12 Juanma Barranquero <lekktu@gmail.com>
4560
4561 * makefile.w32-in: Update dependencies.
4562 (LISP_H): Add lib/intprops.h.
4563
1100a63c
CY
45642011-06-11 Chong Yidong <cyd@stupidchicken.com>
4565
4566 * image.c (gif_load): Add animation frame delay to the metadata.
4567 (syms_of_image): Use DEFSYM. New symbol `delay'.
4568
6198ccd0
MR
45692011-06-11 Martin Rudalics <rudalics@gmx.at>
4570
4571 * window.c (delete_deletable_window): Re-add.
4572 (Fset_window_configuration): Rewrite to handle dead buffers and
4573 consequently deletable windows.
4574 (window_tree, Fwindow_tree): Remove. Supply functionality in
4575 window.el.
4576 (compare_window_configurations): Simplify code.
4577
b6e3633c
AS
45782011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4579
1ab0dee5
AS
4580 * image.c (imagemagick_load_image): Fix type mismatch.
4581 (Fimagemagick_types): Likewise.
4582
b6e3633c
AS
4583 * window.h (replace_buffer_in_windows): Declare.
4584
9397e56f
MR
45852011-06-11 Martin Rudalics <rudalics@gmx.at>
4586
4587 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4588 Qclone_number. Remove external declaration of Qdelete_window.
4589 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4590 code.
640c8776
SM
4591 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4592 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4593 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4594 buffer list implementation.
4595 (other_buffer_safely): New function.
4596 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4597 calls to replace_buffer_in_windows and
4598 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4599 if allowed.
4600 (record_buffer): Inhibit quitting and rewrite using quittable
4601 functions. Run Qbuffer_list_update_hook if allowed.
4602 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4603 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4604 Move switch-to-buffer to window.el.
9397e56f
MR
4605 (bury-buffer): Move to window.el.
4606 (Vbuffer_list_update_hook): New variable.
4607
4608 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4609 section.
4610
4611 * window.h (resize_frame_windows): Move up in code.
4612 (Fwindow_frame): Remove EXFUN.
4613 (replace_buffer_in_all_windows): Remove prototype.
4614 (replace_buffer_in_windows_safely): Add prototype.
4615
4616 * window.c: Declare Qdelete_window static again. Move down
4617 declaration of select_count.
4618 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4619 (Fother_window): Move to window.el.
4620 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4621 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4622 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4623 window.el.
4624 (replace_buffer_in_windows): Implement by calling
4625 Qreplace_buffer_in_windows.
4626 (replace_buffer_in_all_windows): Remove with some functionality
4627 moved into replace_buffer_in_windows_safely.
4628 (replace_buffer_in_windows_safely): New function.
4629 (select_window_norecord, select_frame_norecord): Move in front
4630 of run_window_configuration_change_hook. Remove now obsolete
4631 declarations.
640c8776
SM
4632 (Fset_window_buffer): Rewrite doc-string.
4633 Call Qrecord_window_buffer.
9397e56f
MR
4634 (keys_of_window): Move binding for other-window to window.el.
4635
b50691aa
CY
46362011-06-11 Chong Yidong <cyd@stupidchicken.com>
4637
4638 * dispextern.h (struct image): Replace data member, whose int_val
4639 and ptr_val fields were not used by anything, with a single
4640 lisp_val object.
4641
4642 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4643 (gif_clear_image, gif_load, imagemagick_load_image)
4644 (gs_clear_image, gs_load): Callers changed.
4645
3f754b86
PE
46462011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4647
cca69397
PE
4648 * buffer.h: Include <time.h>, for time_t.
4649 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4650
109e28d0
PE
4651 Fix minor problems found by static checking.
4652
60737f02
PE
4653 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4654
4b66faf3
PE
4655 Make identifiers static if they are not used in other modules.
4656 * data.c (Qcompiled_function, Qframe, Qvector):
4657 * image.c (QimageMagick, Qsvg):
4658 * minibuf.c (Qmetadata):
4659 * window.c (resize_window_check, resize_root_window): Now static.
4660 * window.h (resize_window_check, resize_root_window): Remove decls.
4661
109e28d0
PE
4662 * window.c (window_deletion_count, delete_deletable_window):
4663 Remove; unused.
46a4ce9e
PE
4664 (window_body_lines): Now static.
4665 (Fdelete_other_windows_internal): Mark vars as initialized.
4666 Make sure 'resize_failed' is initialized.
4667 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4668 (resize_window_apply): Remove unused local.
4669 * window.h (delete_deletable_window): Remove decl.
4670
109e28d0 4671 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4672 (imagemagick_load_image): Fix pointer signedness problem by changing
4673 last arg from unsigned char * to char *. All uses changed.
4674 Also, fix a local for similar reasons.
4675 Remove unused locals. Remove locals to avoid shadowing.
4676 (fn_rsvg_handle_free): Remove; unused.
4677 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4678 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4679
3f754b86
PE
4680 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4681
2547adb1
CY
46822011-06-10 Chong Yidong <cyd@stupidchicken.com>
4683
4684 * image.c (gif_load): Fix omitted cast error introduced by
4685 2011-06-06 change.
4686
2c8e37d4
MR
46872011-06-10 Martin Rudalics <rudalics@gmx.at>
4688
4689 * window.h (resize_proportionally, orig_total_lines)
4690 (orig_top_line): Remove from window structure.
4691 (set_window_height, set_window_width, change_window_heights)
4692 (Fdelete_window): Remove prototypes.
4693 (resize_frame_windows): Remove duplicate declaration.
4694
440a42e3
EZ
46952011-06-10 Eli Zaretskii <eliz@gnu.org>
4696
4697 * window.h (resize_frame_windows, resize_window_check)
4698 (delete_deletable_window, resize_root_window)
4699 (resize_frame_windows): Declare prototypes.
4700
4701 * window.c (resize_window_apply): Make definition be "static" to
4702 match the prototype.
4703
562dd5e9
MR
47042011-06-10 Martin Rudalics <rudalics@gmx.at>
4705
4706 * window.c: Remove declarations of Qwindow_size_fixed,
4707 window_min_size_1, window_min_size_2, window_min_size,
4708 size_window, window_fixed_size_p, enlarge_window, delete_window.
4709 Remove static from declaration of Qdelete_window, it's
4710 temporarily needed by Fbury_buffer.
4711 (replace_window): Don't assign orig_top_line and
4712 orig_total_lines.
4713 (Fdelete_window, delete_window): Remove. Window deletion is
4714 handled by window.el.
640c8776
SM
4715 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4716 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4717 (Fdelete_other_windows): Remove. Deleting other windows is
4718 handled by window.el.
4719 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4720 handled in window.el.
4721 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4722 Window minimum sizes are handled in window.el.
4723 (shrink_windows, size_window, set_window_height)
4724 (set_window_width, change_window_heights, window_height)
4725 (window_width, CURBEG, CURSIZE, enlarge_window)
4726 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4727 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4728 handled in window.el.
4729 (make_dummy_parent): Rename to make_parent_window and give it a
4730 second argument horflag.
4731 (make_window): Don't set resize_proportionally any more.
4732 (Fsplit_window): Remove. Windows are split in window.el.
4733 (save_restore_action, save_restore_orig_size)
4734 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4735 Resize mini windows in window.el.
4736 (grow_mini_window, shrink_mini_window): Implement by calling
4737 Qresize_root_window_vertically, resize_window_check and
4738 resize_window_apply.
640c8776
SM
4739 (saved_window, Fset_window_configuration, save_window_save):
4740 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4741 resize_proportionally.
4742 (window_min_height, window_min_width): Move to window.el.
4743 (keys_of_window): Move bindings for delete-other-windows,
4744 split-window, delete-window and enlarge-window to window.el.
4745
4746 * buffer.c: Temporarily extern Qdelete_window.
4747 (Fbury_buffer): Temporarily call Qdelete_window instead of
4748 Fdelete_window (Fbury_buffer will move to window.el soon).
4749
4750 * frame.c (set_menu_bar_lines_1): Remove code handling
4751 orig_top_line and orig_total_lines.
4752
4753 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4754 set_window_height but set heights directly.
4755 (change_frame_size_1): Use resize_frame_windows.
4756
4757 * xdisp.c (init_xdisp): Don't use set_window_height but set
4758 heights directly.
4759
640c8776
SM
4760 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4761 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4762 run_window_configuration_change_hook.
4763
4764 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4765 instead of change_window_heights and run
4766 run_window_configuration_change_hook.
4767
1a13852e
MR
47682011-06-09 Martin Rudalics <rudalics@gmx.at>
4769
4770 * window.c (replace_window): Rename second argument REPLACEMENT to
4771 NEW. New third argument SETFLAG. Rewrite.
4772 (delete_window, make_dummy_parent): Call replace_window with
4773 third argument 1.
4774 (window_list_1): Move down in code.
4775 (run_window_configuration_change_hook): Move set_buffer part
4776 before select_frame_norecord part in order to unwind correctly.
4777 Rename count1 to count.
4778 (recombine_windows, delete_deletable_window, resize_root_window)
4779 (Fdelete_other_windows_internal)
4780 (Frun_window_configuration_change_hook, make_parent_window)
4781 (resize_window_check, resize_window_apply, Fresize_window_apply)
4782 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4783 (Fdelete_window_internal, Fresize_mini_window_internal):
4784 New functions.
1a13852e
MR
4785 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4786
f3d1777e
MR
47872011-06-08 Martin Rudalics <rudalics@gmx.at>
4788
496e208e
MR
4789 * window.h (window): Add some new members to window structure -
4790 normal_lines, normal_cols, new_total, new_normal, clone_number,
4791 splits, nest, prev_buffers, next_buffers.
4792 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4793 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4794
f3d1777e
MR
4795 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4796 Remove.
496e208e
MR
4797 (make_dummy_parent): Set new members of windows structure.
4798 (make_window): Move down in code. Handle new members of window
4799 structure.
4800 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4801 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4802 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4803 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4804 (Fset_window_next_buffers, Fset_window_clone_number):
4805 New functions.
496e208e
MR
4806 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4807 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4808 Doc-string fixes.
4809 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4810 Argument WINDOW can be now internal window too.
4811 (Fwindow_use_time): Move up in code.
4812 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4813 Rewrite doc-string.
4814 (Fset_window_configuration, saved_window)
4815 (Fcurrent_window_configuration, save_window_save): Handle new
4816 members of window structure.
b9e809c2
MR
4817 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4818 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4819 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4820 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4821 Qget_mru_window, Qresize_root_window,
4822 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4823 Qauto_buffer_name; staticpro them.
f3d1777e 4824
abde8f8c
MR
48252011-06-07 Martin Rudalics <rudalics@gmx.at>
4826
4827 * window.c (Fwindow_total_size, Fwindow_left_column)
4828 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4829 (Fwindow_list_1): New functions.
4830 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4831 (Fwindow_width, Fscroll_left, Fscroll_right):
4832 Use window_body_cols instead of window_box_text_cols.
4833 (delete_window, Fset_window_configuration):
4834 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4835 (delete_all_subwindows): Take a window as argument and not a
4836 structure. Rewrite.
190b47e6
MR
4837 (window_loop): Remove handling of GET_LRU_WINDOW and
4838 GET_LARGEST_WINDOW.
4839 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4840
4841 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4842 window_box_text_cols. delete_all_subwindows now takes a
4843 Lisp_Object as argument.
abde8f8c 4844
640c8776
SM
4845 * indent.c (compute_motion, Fcompute_motion):
4846 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4847
fa8a67e6
MR
4848 * frame.c (delete_frame): Call delete_all_subwindows with root
4849 window as argument.
4850
a54e3482
DC
48512011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4852
4853 * fns.c (Fputhash): Document return value.
4854
60002bf5
CY
48552011-06-06 Chong Yidong <cyd@stupidchicken.com>
4856
4857 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4858
0c671da6 48592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4860
b862a52a 4861 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4862
be44ca6c
PE
4863 Check for overflow when converting integer to cons and back.
4864 * charset.c (Fdefine_charset_internal, Fdecode_char):
4865 Use cons_to_unsigned to catch overflow.
4866 (Fencode_char): Use INTEGER_TO_CONS.
4867 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4868 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4869 * data.c (long_to_cons, cons_to_long): Remove.
4870 (cons_to_unsigned, cons_to_signed): New functions.
4871 These signal an error for invalid or out-of-range values.
4872 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4873 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4874 * font.c (Ffont_variation_glyphs):
4875 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4876 * lisp.h: Include <intprops.h>.
4877 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4878 (cons_to_signed, cons_to_unsigned): New decls.
4879 (long_to_cons, cons_to_long): Remove decls.
4880 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4881 (Fprimitive_undo): Use CONS_TO_INTEGER.
4882 * xfns.c (Fx_window_property): Likewise.
4883 * xselect.c: Include <limits.h>.
4884 (x_own_selection, selection_data_to_lisp_data):
4885 Use INTEGER_TO_CONS.
4886 (x_handle_selection_request, x_handle_selection_clear)
4887 (x_get_foreign_selection, Fx_disown_selection_internal)
4888 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4889 (lisp_data_to_selection_data): Use cons_to_unsigned.
4890 (x_fill_property_data): Use cons_to_signed.
4891 Report values out of range.
4892
d1f3d2af
PE
4893 Check for buffer and string overflow more precisely.
4894 * buffer.h (BUF_BYTES_MAX): New macro.
4895 * lisp.h (STRING_BYTES_MAX): New macro.
4896 * alloc.c (Fmake_string):
4897 * character.c (string_escape_byte8):
4898 * coding.c (coding_alloc_by_realloc):
4899 * doprnt.c (doprnt):
4900 * editfns.c (Fformat):
4901 * eval.c (verror):
4902 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4903 since they may not be the same number.
4904 * editfns.c (Finsert_char):
4905 * fileio.c (Finsert_file_contents):
4906 Likewise for BUF_BYTES_MAX.
4907
dd52fcea
PE
4908 * image.c: Use ptrdiff_t, not int, for sizes.
4909 (slurp_file): Switch from int to ptrdiff_t.
4910 All uses changed.
4911 (slurp_file): Check that file size fits in both size_t (for
4912 malloc) and ptrdiff_t (for sanity and safety).
4913
7f9bbdbb
PE
4914 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4915 if b->modtime has its maximal value.
4916
dfe18f82
PE
4917 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4918
84acfcf0
PE
4919 Don't assume time_t can fit into int.
4920 * buffer.h (struct buffer.modtime): Now time_t, not int.
4921 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4922 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4923
ccd9a01a
PE
4924 Minor fixes for signed vs unsigned integers.
4925 * character.h (MAYBE_UNIFY_CHAR):
4926 * charset.c (maybe_unify_char):
4927 * keyboard.c (read_char, reorder_modifiers):
4928 XINT -> XFASTINT, since the integer must be nonnegative.
4929 * ftfont.c (ftfont_spec_pattern):
4930 * keymap.c (access_keymap, silly_event_symbol_error):
4931 XUINT -> XFASTINT, since the integer must be nonnegative.
4932 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4933 since it makes no difference and we prefer signed.
4934 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4935 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4936 nonnegative.
4937
d6d100dd
SM
49382011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4939
4940 * window.h (Fwindow_frame): Declare.
4941
2b6148e4
PE
49422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4943
4944 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4945 (SPARE_MEMORY): Always define.
4946 (LARGE_REQUEST): Remove.
4947 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4948
f230ecc9
MR
49492011-06-06 Martin Rudalics <rudalics@gmx.at>
4950
727e958e
MR
4951 * lisp.h: Move EXFUNS for Fframe_root_window,
4952 Fframe_first_window and Fset_frame_selected_window to window.h.
4953
4954 * window.h: Move EXFUNS for Fframe_root_window,
4955 Fframe_first_window and Fset_frame_selected_window here from
4956 lisp.h.
4957
4958 * frame.c (Fwindow_frame, Fframe_first_window)
4959 (Fframe_root_window, Fframe_selected_window)
4960 (Fset_frame_selected_window): Move to window.c.
4961 (Factive_minibuffer_window): Move to minibuf.c.
4962 (Fother_visible_frames_p): New function.
4963
4964 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4965
f230ecc9
MR
4966 * window.c (decode_window, decode_any_window): Move up in code.
4967 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4968 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4969 (Fwindow_buffer): Move up and rewrite doc-string.
4970 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4971 (Fwindow_prev): New functions.
727e958e
MR
4972 (Fwindow_frame): Move here from frame.c. Accept any window as
4973 argument.
4974 (Fframe_root_window, Fframe_first_window)
4975 (Fframe_selected_window): Move here from frame.c. Accept frame
4976 or arbitrary window as argument. Update doc-strings.
4977 (Fminibuffer_window): Move up in code.
4978 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4979 (Fset_frame_selected_window): Move here from frame.c.
4980 Marginal rewrite.
727e958e
MR
4981 (Fselected_window, select_window, Fselect_window): Move up in
4982 code. Minor doc-string fixes.
f230ecc9 4983
4d09bcf6
PE
49842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4985
4986 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4987 Do not assume that spare memory exists; that assumption is valid
4988 only if SYSTEM_MALLOC.
4989 (LARGE_REQUEST): New macro, so that the issue of large requests
4990 is separated from the issue of spare memory.
4991
810928a2
AS
49922011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4993
172418ad
AS
4994 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4995 format. (Bug#8806)
4996
43f862f7
AS
4997 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4998
810928a2
AS
4999 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5000 before statements.
5001
a059fe24
JD
50022011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5003
5004 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5005
5006 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5007
5008 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5009 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5010
989bf368
JB
50112011-06-05 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5014
4b80f674
CY
50152011-06-04 Chong Yidong <cyd@stupidchicken.com>
5016
5017 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5018 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5019 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5020 New error handlers.
4b80f674
CY
5021 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5022 Obey Vx_select_enable_clipboard_manager. Catch errors in
5023 x_clipboard_manager_save (Bug#8779).
5024 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5025 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5026
99a33b77 50272011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5028
5029 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5030
99a33b77 50312011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5032
5033 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5034 in the current matrix if keep_current_p is non-zero.
5035
8264569d
EZ
50362011-06-04 Eli Zaretskii <eliz@gnu.org>
5037
5038 * bidi.c (bidi_level_of_next_char): Fix last change.
5039
57f97249
EZ
50402011-06-03 Eli Zaretskii <eliz@gnu.org>
5041
fec2107c 5042 Support bidi reordering of text covered by display properties.
57f97249 5043
fec2107c
EZ
5044 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5045 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5046 (bidi_cache_search, bidi_cache_iterator_state)
5047 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5048 (bidi_level_of_next_char, bidi_move_to_visually_next):
5049 Support character positions inside a run of characters covered by a
fec2107c
EZ
5050 display string.
5051 (bidi_paragraph_init, bidi_resolve_explicit_1)
5052 (bidi_level_of_next_char): Call bidi_fetch_char and
5053 bidi_fetch_char_advance instead of FETCH_CHAR and
5054 FETCH_CHAR_ADVANCE.
5055 (bidi_init_it): Initialize new members.
5056 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5057 definitions.
5058 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5059 instead of using explicit *_CHAR codes.
d6d100dd
SM
5060 (bidi_resolve_explicit, bidi_resolve_weak):
5061 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5062 bidirectional text is supported only in multibyte buffers.
5063 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5064 it to initialize the frame_window_p member of struct bidi_it.
5065 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5066 (bidi_resolve_explicit, bidi_resolve_weak)
5067 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5068 bidi_it->nchars is non-positive.
5069 (bidi_level_of_next_char): Don't try to lookup the cache for the
5070 next/previous character if nothing is cached there yet, or if we
5071 were just reseat()'ed to a new position.
c40e2fb2 5072
0e14fe90
EZ
5073 * xdisp.c (set_cursor_from_row): Set start and stop points
5074 according to the row's direction when priming the loop that looks
5075 for the glyph on which to display cursor.
5076 (single_display_spec_intangible_p): Function deleted.
5077 (display_prop_intangible_p): Reimplement to call
5078 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5079 Accept 3 additional arguments needed by handle_display_spec.
5080 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5081 values: lists, `(when COND...)' forms, etc.
5082 (single_display_spec_string_p): Support property values that are
5083 lists with the argument STRING its top-level element.
5084 (display_prop_string_p): Fix the condition for processing a
5085 property that is a list to be consistent with handle_display_spec.
fec2107c 5086 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5087 last portion of handle_display_prop.
5088 (compute_display_string_pos): Accept additional argument
5089 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5090 value of a `display' property is a "replacing spec".
5091 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5092 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5093 the display property, but just return a value indicating whether
5094 the display property will replace the characters it covers.
5095 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5096 frame_window_p members of struct bidi_it.
d6d100dd
SM
5097 (compute_display_string_pos, compute_display_string_end):
5098 New functions.
fec2107c
EZ
5099 (push_it): Accept second argument POSITION, where pop_it should
5100 jump to continue iteration.
5101 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5102
fec2107c
EZ
5103 * keyboard.c (adjust_point_for_property): Adjust the call to
5104 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5105
5106 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5107 (bidi_init_it): Update prototypes.
5108 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5109 (compute_display_string_pos, compute_display_string_end):
5110 Declare prototypes.
fec2107c
EZ
5111 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5112 EMACS_INT.
fc6f18ce 5113
40087514 51142011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5115
57f53182
PE
5116 Malloc failure behavior now depends on size of allocation.
5117 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5118 * lisp.h: Change signatures accordingly.
5119 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5120 All callers changed. (Bug#8762)
5121
5122 * gnutls.c: Use Emacs's memory allocators.
5123 Without this change, the gnutls library would invoke malloc etc.
5124 directly, which causes problems on non-SYNC_INPUT hosts, and which
5125 runs afoul of improving memory_full behavior. (Bug#8761)
5126 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5127 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5128 xfree instead of the default malloc, realloc, free.
5129 (Fgnutls_boot): No need to check for memory allocation failure,
5130 since xmalloc does that for us.
5131
ac32cd99 5132 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5133 * category.c (hash_get_category_set):
5134 * ccl.c (ccl_driver):
5135 * charset.c (Fdefine_charset_internal):
5136 * charset.h (struct charset.hash_index):
5137 * composite.c (get_composition_id, gstring_lookup_cache)
5138 (composition_gstring_put_cache):
5139 * composite.h (struct composition.hash_index):
5140 * dispextern.h (struct image.hash):
5141 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5142 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5143 (hashfn_equal, hashfn_user_defined, make_hash_table)
5144 (maybe_resize_hash_table, hash_lookup, hash_put)
5145 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5146 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5147 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5148 * image.c (make_image, search_image_cache, lookup_image)
5149 (xpm_put_color_table_h):
5150 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5151 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5152 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5153 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5154 * alloc.c (allocate_vectorlike):
5155 Check for overflow in vector size calculations.
5156 * ccl.c (ccl_driver):
5157 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5158 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5159 need to be updated by these changes.
40087514
PE
5160 * fns.c (make_hash_table, maybe_resize_hash_table):
5161 Check for integer overflow with large hash tables.
0de4bb68
PE
5162 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5163 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5164 (SXHASH_REDUCE): New macro.
5165 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5166 Use it instead of discarding useful hash info with large hash values.
5167 (sxhash_float): New function.
5168 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5169 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5170 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5171 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5172 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5173 Adjust signatures to match updated version of code.
5174 (consing_since_gc): Now EMACS_INT, since a single hash table can
5175 use more than INT_MAX bytes.
5176
698d32e2
DN
51772011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5178
5179 Make it possible to build with GCC-4.6+ -O2 -flto.
5180
5181 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5182
fd6fa53f
SM
51832011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5184
5185 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5186 Call minibuffer-inactive-mode.
5187
864db017
JB
51882011-05-31 Juanma Barranquero <lekktu@gmail.com>
5189
5190 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5191 Update dependencies.
5192
2ad0baf4
DN
51932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5194
5195 * data.c (init_data): Remove code for UTS, this system is not
5196 supported anymore.
5197
4fcc2638
DN
51982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5199
5200 Don't force ./temacs to start in terminal mode.
5201
5202 * frame.c (make_initial_frame): Initialize faces in all cases, not
5203 only when CANNOT_DUMP is defined.
5204 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5205
c56e0fd5
DN
52062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5207
5208 * dispnew.c (add_window_display_history): Use const for the string
5209 pointer. Remove declaration, not needed.
5210
333d54da 52112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5212
55d4c1b2 5213 Use 'inline', not 'INLINE'.
333d54da 5214 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5215 * alloc.c, fontset.c (INLINE): Remove.
5216 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5217 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5218 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5219 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5220 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5221
738db178
DN
52222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5223
5224 Make it possible to run ./temacs.
5225
5226 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5227 syms_of_callproc does the same thing. Remove test for
5228 "initialized", do it in the caller.
5229 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5230
620c53a6
SM
52312011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5232
5233 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5234 (read_minibuf): Use get_minibuffer.
5235 (syms_of_minibuf): Use DEFSYM.
5236 (Qmetadata): New var.
5237 * data.c (Qbuffer): Don't make it static.
5238 (syms_of_data): Use DEFSYM.
5239
e003a292
PE
52402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5241
5242 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5243 (CCL_CODE_MIN): New macro.
5244
ed008a6d
PE
52452011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5246
3687c2ef
PE
5247 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5248
ed008a6d
PE
5249 * eval.c (Qdebug): Now static.
5250 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5251 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5252 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5253
d66c4c7c
CY
52542011-05-29 Chong Yidong <cyd@stupidchicken.com>
5255
5256 * image.c: Various fixes to ImageMagick code comments.
5257 (Fimagemagick_types): Doc fix.
5258
5fbc2025
PE
52592011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5260
0196f88a
PE
5261 Minor fixes prompted by GCC 4.6.0 warnings.
5262
5263 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5264
5fbc2025
PE
5265 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5266 (x_clipboard_manager_save_all): Move extern decl to ...
5267 * xterm.h: ... here, so that it can be checked for consistency.
5268
1dd3c2d9
CY
52692011-05-29 Chong Yidong <cyd@stupidchicken.com>
5270
5271 * xselect.c (x_clipboard_manager_save_frame)
5272 (x_clipboard_manager_save_all): New functions.
5273 (Fx_clipboard_manager_save): Lisp function deleted.
5274
5275 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5276 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5277
5278 * xterm.h: Update prototype.
5279
5ba6571d
WX
52802011-05-28 William Xu <william.xwl@gmail.com>
5281
5282 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5283 exiting (Bug#8239).
5284
3eaff834
JM
52852011-05-28 Jim Meyering <meyering@redhat.com>
5286
e1900994 5287 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5288 * fns.c (to_uchar): Define.
5289 (crypto_hash_function): Use it to convert some newly-signed
5290 variables to unsigned, to avoid sign-extension bugs. For example,
5291 without this change, (md5 "truc") would evaluate to
5292 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5293 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5294 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5295
0f6990a7
PE
52962011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 Integer overflow fixes.
c8a9ca5a 5299
08686060
PE
5300 * dbusbind.c: Serial number integer overflow fixes.
5301 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5302 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5303 to hold a serial number that is too large for a fixnum.
5304 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5305 Check for serial numbers out of range. Decode any serial number
59568bf0 5306 that was so large that it became a float. (Bug#8722)
08686060 5307
2d1fc3c7
PE
5308 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5309 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5310 Use XFASTINT rather than XUINT when numbers are nonnegative.
5311 (xd_append_arg, Fdbus_method_return_internal):
5312 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5313 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5314 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5315 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5316 (Bug#8722)
2d1fc3c7 5317
c8a9ca5a
PE
5318 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5319
519e1d69
PE
5320 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5321
30569699
PE
5322 ccl: add integer overflow checks
5323 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5324 (IN_INT_RANGE): New macros.
5325 (ccl_driver): Use them to check for integer overflow when
5326 decoding a CCL program. Many of the new checks are whether XINT (x)
5327 fits in int; it doesn't always, on 64-bit hosts. The new version
5328 doesn't catch all possible integer overflows, but it's an
847044ea 5329 improvement. (Bug#8719)
30569699 5330
c11285dc
PE
5331 * alloc.c (make_event_array): Use XINT, not XUINT.
5332 There's no need for unsigned here.
5333
fdccd48e
PE
5334 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5335 This follows up to the 2011-05-06 change that substituted uintptr_t
5336 for EMACS_INT. This case wasn't caught back then.
5337
37910ab2
PE
5338 Rework Fformat to avoid integer overflow issues.
5339 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5340 now (part of C89). Include <verify.h>.
5341 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5342 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5343 (Fformat): Avoid the prepass trying to compute sizes; it was only
5344 approximate and thus did not catch overflow reliably. Instead, walk
5345 through the format just once, formatting and computing sizes as we go,
5346 checking for integer overflow at every step, and allocating a larger
5347 buffer as needed. Keep track separately whether the format is
5348 multibyte. Keep only the most-recently calculated precision, rather
5349 than them all. Record whether each argument has been converted to
5350 string. Use EMACS_INT, not int, for byte and char and arg counts.
5351 Support field widths and precisions larger than INT_MAX. Avoid
5352 sprintf's undefined behavior with conversion specifications such as %#d
5353 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5354 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5355 formatting out-of-range floating point numbers with int
9173deec 5356 formats. (Bug#8668)
37910ab2 5357
2e6578fb
PE
5358 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5359
0ae6bdee
PE
5360 * data.c: Avoid integer truncation in expressions involving floats.
5361 * data.c: Include <intprops.h>.
5362 (arith_driver): When there's an integer overflow in an expression
5363 involving floating point, convert the integers to floating point
5364 so that the resulting value does not suffer from catastrophic
5365 integer truncation. For example, on a 64-bit host (* 4
5366 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5367 Do not rely on undefined behavior after integer overflow.
5368
de883a70
PE
5369 merge count_size_as_multibyte, parse_str_to_multibyte
5370 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5371 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5372 Check for integer overflow.
5373 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5374 since it's now a duplicate of the other. This is more of
5375 a character than a buffer op, so better that it's in character.c.
5376 * fns.c, print.c: Adjust to above changes.
5377
2ff916cb
PE
53782011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5379
5380 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5381
f1b54466
PE
53822011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5383
fb1ac845
PE
5384 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5385 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5386 (x_clipboard_manager_save): Now static.
5387 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5388
f1b54466
PE
5389 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5390 (crypto_hash_function): Now static.
5391 Fix pointer signedness problems. Avoid unnecessary initializations.
5392
a9f737ee
CY
53932011-05-27 Chong Yidong <cyd@stupidchicken.com>
5394
5395 * termhooks.h (Vselection_alist): Make it terminal-local.
5396
5397 * terminal.c (create_terminal): Initialize it.
5398
5399 * xselect.c: Support for clipboard managers.
5400 (Vselection_alist): Move to termhooks.h as terminal-local var.
5401 (LOCAL_SELECTION): New macro.
5402 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5403 (symbol_to_x_atom): Remove gratuitous arg.
5404 (x_handle_selection_request, lisp_data_to_selection_data)
5405 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5406 (x_own_selection, x_get_local_selection, x_convert_selection):
5407 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5408 (some_frame_on_display): Delete unused function.
5409 (Fx_own_selection_internal, Fx_get_selection_internal)
5410 (Fx_disown_selection_internal, Fx_selection_owner_p)
5411 (Fx_selection_exists_p): New optional frame arg.
5412 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5413 (x_handle_selection_clear): Don't treat other terminals with the
5414 same keyboard specially. Use the terminal-local Vselection_alist.
5415 (x_clear_frame_selections): Use Frun_hook_with_args.
5416
5417 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5418
5419 * xterm.h: Add support for those atoms.
5420
e067f0c1
CY
54212011-05-26 Chong Yidong <cyd@stupidchicken.com>
5422
5423 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5424 (converted_selections, conversion_fail_tag): New global variables.
5425 (x_selection_request_lisp_error): Free the above.
5426 (x_get_local_selection): Remove unnecessary code.
5427 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5428 of converted selections stored in converted_selections.
5429 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5430 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5431 (x_convert_selection): New function.
5432 (x_handle_selection_event): Simplify.
5433 (x_get_foreign_selection): Don't ignore incoming requests while
5434 waiting for an answer; this will fail when we implement
5435 SAVE_TARGETS, and seems unnecessary anyway.
5436 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5437 (Vx_sent_selection_functions): Doc fix.
5438
0f4aebc0
LL
54392011-05-26 Leo Liu <sdl.web@gmail.com>
5440
5441 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5442
e61124cd
YM
54432011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5444
5445 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5446
5447 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5448 for fringe update if it has periodic bitmap.
ac389d0c 5449 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5450 and fringe_bitmap_periodic_p.
5451
5452 * fringe.c (get_fringe_bitmap_data): New function.
5453 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5454 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5455 row. Mark glyph row for fringe update if periodicity changed.
5456
5457 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5458 for fringe update unless it has periodic bitmap.
5459
f16d9837
KH
54602011-05-25 Kenichi Handa <handa@m17n.org>
5461
5462 * xdisp.c (get_next_display_element): Set correct it->face_id for
5463 a static composition.
5464
e1b90ef6
LL
54652011-05-24 Leo Liu <sdl.web@gmail.com>
5466
5467 * deps.mk (fns.o):
5468 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5469
5470 * fns.c (crypto_hash_function, Fsha1): New function.
5471 (Fmd5): Use crypto_hash_function.
5472 (syms_of_fns): Add Ssha1.
5473
7400048f
PE
54742011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5475
5476 * gnutls.c: Remove unused macros.
5477 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5478 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5479 Remove macros that are defined and never used.
5480 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5481
abb71cf4
CY
54822011-05-22 Chong Yidong <cyd@stupidchicken.com>
5483
5484 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5485 (Fx_get_selection_internal): Minor cleanup.
5486 (Fx_own_selection_internal): Rename arguments for consistency with
5487 select.el.
5488
6307db39
PE
54892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5490
5491 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5492
f3d4e0a4
CY
54932011-05-22 Chong Yidong <cyd@stupidchicken.com>
5494
5495 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5496
4d8ade89
YM
54972011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5498
5499 * dispnew.c (scrolling_window): Don't exclude the case that the
5500 last enabled row in the desired matrix touches the bottom boundary.
5501
32078c8d
GM
55022011-05-21 Glenn Morris <rgm@gnu.org>
5503
5504 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5505 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5506 and add some more files.
32078c8d 5507
7285dc67
EZ
55082011-05-20 Eli Zaretskii <eliz@gnu.org>
5509
5510 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5511 report_file_error introduced by the change from 2011-05-07.
5512
89d1bd22
PE
55132011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5514
5515 * systime.h (Time): Define only if emacs is defined.
5516 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5517 where the include path doesn't have X11/X.h by default. See
5518 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5519
e23640bb 55202011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5521
5522 * composite.c (find_automatic_composition): Fix previous change.
5523
b9704ad9
GM
55242011-05-20 Glenn Morris <rgm@gnu.org>
5525
5526 * lisp.mk: New file, split from Makefile.in.
5527 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5528 (shortlisp): Remove.
5529 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5530
4a720484
GM
55312011-05-19 Glenn Morris <rgm@gnu.org>
5532
5533 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5534 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5535 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5536 (lisp): Set the order to that of loadup.el.
5537 (shortlisp): Make it a copy of $lisp.
5538 (SOME_MACHINE_LISP): Remove.
5539 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5540 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5541
a28d4396
KH
55422011-05-18 Kenichi Handa <handa@m17n.org>
5543
5544 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5545 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5546 (find_automatic_composition): Mostly rewrite for efficiency.
5547
a2b1fa8e
JB
55482011-05-18 Juanma Barranquero <lekktu@gmail.com>
5549
5550 * makefile.w32-in: Update dependencies.
5551
8e1f5610
CS
55522011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5553
5554 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5555 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5556
7025ee00 55572011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5558
cdfa6eab
PE
5559 Fix some integer overflow issues, such as string length overflow.
5560
06d6db33
PE
5561 * insdel.c (count_size_as_multibyte): Check for string overflow.
5562
2b4560a8
PE
5563 * character.c (lisp_string_width): Check for string overflow.
5564 Use EMACS_INT, not int, for string indexes and lengths; in
5565 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5566 the resulting string length overflows an EMACS_INT; instead,
5567 report a string overflow if no precision given. When checking for
5568 precision exhaustion, use a check that cannot possibly have
5569 integer overflow. (Bug#8675)
5570 * character.h (lisp_string_width): Adjust to new signature.
5571
cb93f9be
PE
5572 * alloc.c (string_overflow): New function.
5573 (Fmake_string): Use it. This doesn't change behavior, but saves
5574 a few bytes and will simplify future changes.
5575 * character.c (string_escape_byte8): Likewise.
5576 * lisp.h (string_overflow): New decl.
5577
1a1f3366
PE
5578 Fixups, following up to the user-interface timestamp change.
5579 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5580 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5581 * msdos.c (mouse_get_pos): Likewise.
5582 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5583 * w32gui.h (Time): Define by including "systime.h" rather than by
5584 declaring it ourselves. (Bug#8664)
5585
d4e3e4d3
PE
5586 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5587 * image.c (clear_image_cache): Likewise.
5588
f6a24d19
PE
5589 * term.c (term_mouse_position): Don't assume time_t wraparound.
5590
08dc5ae6
PE
5591 Be more systematic about user-interface timestamps.
5592 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5593 and sometimes 'EMACS_UINT', to represent these timestamps.
5594 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5595 This makes the code easier to follow, and makes it easier to catch
5596 integer overflow bugs such as Bug#8664.
5597 * frame.c (Fmouse_position, Fmouse_pixel_position):
5598 Use Time, not unsigned long, for user-interface timestamps.
5599 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5600 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5601 * keyboard.h (last_event_timestamp): Likewise.
5602 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5603 * menu.h (xmenu_show): Likewise.
5604 * term.c (term_mouse_position): Likewise.
5605 * termhooks.h (struct input_event.timestamp): Likewise.
5606 (struct terminal.mouse_position_hook): Likewise.
5607 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5608 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5609 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5610 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5611 what it was before.
5612 * menu.h, termhooks.h: Include "systime.h", for Time.
5613
8e55734a
PE
5614 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5615 Don't assume that the difference between two unsigned long values
5616 can fit into an integer. At this point, we know button_down_time
5617 <= event->timestamp, so the difference must be nonnegative, so
5618 there's no need to cast the result if double-click-time is
5619 nonnegative, as it should be; check that it's nonnegative, just in
5620 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5621 apart (about 25 days). (Bug#8664)
8e55734a 5622
841f1b75 5623 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5624 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5625
3e26f69c
PE
5626 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5627 that always fit in int. Use a sentinel instead of a counter, to
5628 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5629 * frame.h (struct frame): Use int for menu_bar_items_used
5630 instead of EMACS_INT, since it always fits in int.
3e26f69c 5631
5cc152c0
PE
5632 * menu.c (grow_menu_items): Check for int overflow.
5633
d89eb65e
PE
5634 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5635
5235bd3e
PE
5636 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5637 Before, the code was not consistent. These values cannot exceed
5638 2**31 - 1 so there's no need to make them unsigned.
5639 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5640 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5641 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5642 as modifiers.
5643 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5644
bc827e23
PE
5645 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5646 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5647 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5648 presumably because the widths might not match.
5649
78eb494e
PE
5650 * window.c (size_window): Avoid needless test at loop start.
5651
04f2d78b
CB
56522011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5653
5654 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5655
d2fc7e3d 56562011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5657
5658 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5659
d2fc7e3d 56602011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5661
5662 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5663 `width' to `bar_area_x' and `bar_area_width', respectively.
5664 (x_scroll_run): Take account of fringe background extension.
5665
04f2d78b
CB
5666 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5667 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5668 `bar_area_width', respectively.
5669 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5670 background extension.
5671
79b70037
GM
56722011-05-10 Jim Meyering <meyering@redhat.com>
5673
5674 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5675
2f142cc5
JB
56762011-05-10 Juanma Barranquero <lekktu@gmail.com>
5677
5678 * image.c (Finit_image_library): Return t for built-in image types,
5679 like pbm and xbm. (Bug#8640)
5680
57679c86
AS
56812011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5682
5683 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5684
888c9e86
EZ
56852011-05-07 Eli Zaretskii <eliz@gnu.org>
5686
b0512a1d
EZ
5687 * w32console.c (Fset_screen_color): Doc fix.
5688 (Fget_screen_color): New function.
5689 (syms_of_ntterm): Defsubr it.
5690
7285dc67
EZ
5691 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5692 unlink the temporary file if Fcall_process didn't create it in the
5693 first place.
5694 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5695 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5696 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5697 cue to call_process_cleanup not to close that handle.
5698
4d3fcc8e
BK
56992011-05-07 Ben Key <bkey76@gmail.com>
5700
5701 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5702 one of two shell specific rules, either bootstrap-temacs-CMD or
5703 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5704 to the previous implementation of the bootstrap-temacs rule.
5705 The bootstrap-temacs-CMD rule is similar to the previous
5706 implementation of the bootstrap-temacs rule except that it
5707 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5708 variable.
5709
5710 These changes, along with some changes to nt/configure.bat,
5711 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5712 earlier fix to add support for --cflags and --ldflags options
5713 that include quotes so that it works whether make uses cmd or
5714 sh as the shell.
5715
b4289b64
MA
57162011-05-06 Michael Albinus <michael.albinus@gmx.de>
5717
5718 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5719 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5720 is a constant.
5721 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5722 a string. Handle both cases.
5723 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5724 (Fdbus_register_method): Use Qinvalid_function.
5725
af4c0e28
JB
57262011-05-06 Juanma Barranquero <lekktu@gmail.com>
5727
5728 * makefile.w32-in: Update dependencies.
5729 (LISP_H): Add inttypes.h and stdin.h.
5730 (PROCESS_H): Add unistd.h.
5731
c51453d9
EZ
57322011-05-06 Eli Zaretskii <eliz@gnu.org>
5733
5734 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5735 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5736
8ff0ac3c 57372011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5738
4c4b566b
PE
5739 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5740
aab2b9b5
PE
5741 * term.c (vfatal): Remove stray call to va_end.
5742 It's not needed and the C Standard doesn't allow it here anyway.
5743
c378da0b
PE
5744 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5745 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5746
288b08c7
PE
5747 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5748 bytes.
5749
e3601888
PE
5750 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5751
db6c0e74
PE
5752 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5753
dd5963ea
PE
5754 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5755
88c9450f
PE
5756 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5757
2f9442b8
PE
5758 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5759
c032b5f8
PE
5760 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5761 * charset.c (Fdefine_charset_internal): Don't initialize
5762 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5763 32-bit int (Bug#8600).
a108c10b
PE
5764
5765 * lread.c (read_integer): Be more consistent with string-to-number.
5766 Use string_to_number to do the actual conversion; this avoids
5767 rounding errors and fixes some other screwups. Without this fix,
5768 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5769 (digit_to_number): Move earlier, for benefit of read_integer.
5770 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5771 not a digit in any supported base. (Bug#8602)
a108c10b 5772
ad5f9eea
PE
5773 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5774
aec1708a
PE
5775 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5776 to match comment at start of function. This also removes a
5777 GCC warning about overflow in a 32+64-bit port.
5778
47be4ab5
PE
5779 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5780
371cac43
PE
5781 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5782 Reported by Stefan Monnier in
5783 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5784 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5785 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5786
d01a7826
PE
5787 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5788 (EMACS_UINTPTR): Likewise, with uintptr_t.
5789
7fd47d5c
PE
5790 * lisp.h: Prefer 64-bit EMACS_INT if available.
5791 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5792 on 32-bit hosts that have 64-bit int, so that they can access
5793 large files.
122b0c86
PE
5794 However, temporarily disable this change unless the temporary
5795 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5796
8727937b
PE
5797 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5798
8ac068ac
PE
5799 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5800 This removes an assumption that EMACS_INT and long are the same
5801 width as pointers. The assumption is true for Emacs porting targets
5802 now, but we want to make other targets possible.
5803 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5804 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5805 In the rest of the code, change types of integers that hold casted
5806 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5807 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5808 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5809 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5810 No need to cast type when ORing.
5811 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5812 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5813 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5814 assume EMACS_INT is the same width as char *.
5815 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5816 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5817 Remove no-longer-needed casts.
5818 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5819 (xg_tool_bar_help_callback, xg_make_tool_item):
5820 Use EMACS_INTPTR to hold an integer
5821 that will be cast to void *; this can avoid a GCC warning
5822 if EMACS_INT is not the same width as void *.
5823 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5824 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5825 (current_message_1, set_message_1):
5826 Use a local to convert to proper width without a cast.
5827 * xmenu.c (dialog_selection_callback): Likewise.
5828
ede49d71
PE
5829 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5830 Also, don't assume VALBITS / RAND_BITS is less than 5,
5831 and don't rely on undefined behavior when shifting a 1 left into
5832 the sign bit.
5833 * lisp.h (get_random): Change signature to match.
5834
2f30ecd0
PE
5835 * lread.c (hash_string): Use size_t, not int, for hash computation.
5836 Normally we prefer signed values; but hashing is special, because
5837 it's better to use unsigned division on hash table sizes so that
5838 the remainder is nonnegative. Also, size_t is the natural width
5839 for hashing into memory. The previous code used 'int', which doesn't
5840 retain enough info to hash well into very large tables.
5841 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5842
2a866e7b
PE
5843 * dbusbind.c: Don't possibly lose pointer info when converting.
5844 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5845 Use XPNTR rather than XHASH, so that the high-order bits of
5846 the pointer aren't lost when converting through void *.
5847
51639eac
PE
5848 * eval.c (Fautoload): Don't double-shift a pointer.
5849
92394119
PE
5850 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5851
dbdb9a7c
JB
58522011-05-06 Juanma Barranquero <lekktu@gmail.com>
5853
5854 * gnutls.c (DEF_GNUTLS_FN):
5855 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5856
db7a0b4f
AS
58572011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5858
5859 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5860 marker. (Bug#8610)
5861
f7ff1b0f 58622011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5863
5864 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5865 New version that can reserve upto 2GB of heap space.
5866
f7ff1b0f 58672011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5868
5869 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5870
639c109b
TZ
58712011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5872
5873 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5874 `gnutls_certificate_set_x509_key_file'.
5875
d2127135
JB
58762011-05-05 Juanma Barranquero <lekktu@gmail.com>
5877
5878 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5879 Update dependencies.
5880
e968f4f3
JB
58812011-05-04 Juanma Barranquero <lekktu@gmail.com>
5882
5883 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5884 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5885 Remove unused parameter `fildes'.
5886 * process.c (read_process_output, send_process): Don't pass it.
5887
84d358f0
JB
58882011-05-04 Juanma Barranquero <lekktu@gmail.com>
5889
5890 Fix previous change: the library cache is defined in w32.c.
5891 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5892 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5893
0898ca10
JB
58942011-05-04 Juanma Barranquero <lekktu@gmail.com>
5895
5896 Implement dynamic loading of GnuTLS on Windows.
5897
5898 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5899 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5900 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5901 Declare.
5902
5903 * gnutls.c (Qgnutls_dll): Define.
5904 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5905 (gnutls_*): Declare function pointers.
5906 (init_gnutls_functions): New function to initialize function pointers.
5907 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5908 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5909 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5910 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5911 (emacs_gnutls_write, emacs_gnutls_read)
5912 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5913 (Fgnutls_available_p): New function.
5914 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5915 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5916 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5917
5918 * image.c: Include w32.h.
5919 (Vimage_type_cache): Delete.
5920 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5921 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5922 (w32_delayed_load): Move to w32.c.
5923
5924 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5925
5926 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5927 (w32_delayed_load): Move from image.c. When loading a library, record
5928 its filename in the :loaded-from property of the library id.
5929 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5930 Initialize and staticpro them.
5931 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5932
5933 * process.c: Include lisp.h before w32.h, not after.
5934 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5935 instead of gnutls_record_check_pending.
5936
5937 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5938
ff4de4aa
TZ
59392011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5940
5941 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5942 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5943 as passed in.
5944
abe95abb
JD
59452011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5946
5947 * xterm.c (x_set_frame_alpha): Do not set property on anything
5948 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5949
e16e55d4
JB
59502011-05-02 Juanma Barranquero <lekktu@gmail.com>
5951
5952 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5953
bafcf6a5
JB
59542011-05-02 Juanma Barranquero <lekktu@gmail.com>
5955
5956 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5957 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5958 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5959 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5960 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5961 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5962 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5963 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5964 (Qgnutls_bootprop_callbacks_verify): Make static.
5965
e7a6747f
AS
59662011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5967
19ed11ba
AS
5968 * callproc.c: Indentation fixup.
5969
e7a6747f 5970 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5971 (wait_for_termination, interruptible_wait_for_termination):
5972 Move after wait_for_termination_1.
e7a6747f 5973
1ef14cb4
LMI
59742011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5975
5976 * sysdep.c (interruptible_wait_for_termination): New function
5977 which is like wait_for_termination, but allows keyboard
5978 interruptions.
5979
5980 * callproc.c (Fcall_process): Add (:file "file") as an option for
5981 the STDOUT buffer.
5982 (Fcall_process_region): Ditto.
5983
330d880c
EZ
59842011-04-30 Eli Zaretskii <eliz@gnu.org>
5985
8db90b73
EZ
5986 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5987 rather than `XVECTOR (FOO)->size'.
5988
330d880c
EZ
5989 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5990 inttypes.h, as a gnulib replacement is used if it not available in
5991 system headers.
5992
15cbd324
EZ
59932011-04-21 Eli Zaretskii <eliz@gnu.org>
5994
5995 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5996 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5997 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5998
5999 * coding.c (coding_alloc_by_realloc): Error out if destination
6000 will grow beyond MOST_POSITIVE_FIXNUM.
6001 (decode_coding_emacs_mule): Abort if there isn't enough place in
6002 charbuf for the composition carryover bytes. Reserve an extra
6003 space for up to 2 characters produced in a loop.
6004 (decode_coding_iso_2022): Abort if there isn't enough place in
6005 charbuf for the composition carryover bytes.
6006
60072011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6008
ae940cca
EZ
6009 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6010 aborting when %lld or %lll format is passed.
6011 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6012 %llo or %llx format is passed. (Bug#8545)
6013
03ab8921
EZ
6014 * window.c (window_scroll_line_based): Use a marker instead of
6015 simple variables to record original value of point. (Bug#7952)
6016
afda1437
EZ
6017 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6018 produced by %s or %c overflows available buffer space. (Bug#8545)
6019
f76dee0c
PE
60202011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6021
6022 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6023 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6024
fdc5744d
JB
60252011-04-28 Juanma Barranquero <lekktu@gmail.com>
6026
6027 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6028
638f053a
JB
60292011-04-28 Juanma Barranquero <lekktu@gmail.com>
6030
6031 * keyboard.c (Qdelayed_warnings_hook): Define.
6032 (command_loop_1): Run `delayed-warnings-hook'
6033 if Vdelayed_warnings_list is non-nil.
6034 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6035 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6036
d178f871
EZ
60372011-04-28 Eli Zaretskii <eliz@gnu.org>
6038
6039 * doprnt.c (doprnt): Don't return value smaller than the buffer
6040 size if the message was truncated. (Bug#8545).
6041
b124fd93
JB
60422011-04-28 Juanma Barranquero <lekktu@gmail.com>
6043
6044 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6045 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6046
e810457d
PE
60472011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6048
6049 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6050
ea51cceb
JB
60512011-04-27 Juanma Barranquero <lekktu@gmail.com>
6052
6053 * makefile.w32-in: Update dependencies.
6054
94dcfacf
EZ
60552011-04-27 Eli Zaretskii <eliz@gnu.org>
6056
6057 Improve `doprnt' and its usage. (Bug#8545)
6058 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6059 `format_end'. Remove support for %l as a conversion specifier.
6060 Don't use xrealloc. Improve diagnostics when the %l size modifier
6061 is used. Update the commentary.
6062
6063 * eval.c (verror): Simplify calculation of size_t.
6064
6065 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6066 messages.
6067
f61f41d7
PE
60682011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6069
6070 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6071 change.
6072
96fb4434
PE
60732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6074
6075 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6076 This makes this file independent of the recent pseudovector change.
6077
671875da 60782011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6079
69e9b5a3
PE
6080 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6081
b5f869a7 6082 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6083 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6084 Remove unused local.
c8926152 6085 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6086
841a1577 6087 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6088 GCC 4.6.0 optimizes based on type-based alias analysis.
6089 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6090 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6091 != &v->size, and therefore "v->size = 1; b->size = 2; return
6092 v->size;" must therefore return 1. This assumption is incorrect
6093 for Emacs, since it type-puns struct Lisp_Vector * with many other
6094 types. To fix this problem, this patch adds a new type struct
f904488f 6095 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6096 and pseudovectors, and helps optimizing compilers not get fooled
6097 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6098 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6099 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6100 the size member.
eab3844f
PE
6101 (XSETPVECTYPE): Rewrite in terms of new macro.
6102 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6103 This is a bit clearer, and further avoids the possibility of
6104 undesirable aliasing.
6105 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6106 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6107 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6108 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6109 (ASIZE): Now uses header.size rather than size.
6110 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6111 to avoid the hassle of writing XVECTOR (foo)->header.size.
6112 (struct vectorlike_header): New type.
eab3844f
PE
6113 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6114 object, to help avoid aliasing.
6115 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6116 (SUBRP): Likewise, since Lisp_Subr is a special case.
6117 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6118 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6119 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6120 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6121 changed to be "header.size" and "header.next".
6122 * buffer.h (struct buffer): Likewise.
6123 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6124 * frame.h (struct frame): Likewise.
6125 * process.h (struct Lisp_Process): Likewise.
6126 * termhooks.h (struct terminal): Likewise.
6127 * window.c (struct save_window_data, struct saved_window): Likewise.
6128 * window.h (struct window): Likewise.
6129 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6130 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6131 * buffer.c (init_buffer_once): Likewise.
6132 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6133 special case.
6134 * process.c (Fformat_network_address): Use local var for size,
6135 for brevity.
6136
0df1eac5
PE
6137 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6138
847ab9d1 6139 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6140 * data.c (atof): Remove decl; no longer used or needed.
6141 (digit_to_number): Move to lread.c.
6142 (Fstring_to_number): Use new string_to_number function, to be
6143 consistent with how the Lisp reader treats infinities and NaNs.
6144 Do not assume that floating-point numbers represent EMACS_INT
6145 without losing information; this is not true on most 64-bit hosts.
6146 Avoid double-rounding errors, by insisting on integers when
6147 parsing non-base-10 numbers, as the documentation specifies.
6148 * lisp.h (string_to_number): New decl, replacing ...
6149 (isfloat_string): Remove.
bc0a5c13 6150 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6151 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6152 appears to have been a coding error. Similarly, do not accept
6153 strings like +-1e0 as floating point numbers. Do not report
6154 overflow for integer overflows unless the base is not 10 which
6155 means we have no simple and reliable way to continue.
6156 Break out the floating-point parsing into a new
6157 function string_to_number, so that Fstring_to_number parses
6158 floating point numbers consistently with the Lisp reader.
04f2d78b 6159 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6160 (E_CHAR, EXP_INT): Remove, replacing with ...
6161 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6162 (string_to_number): New function, replacing isfloat_string.
6163 This function checks for valid syntax and produces the resulting
6164 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6165 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6166 so that overflow for non-base-10 numbers is reported only when
6167 there's no portable and simple way to convert to floating point.
452f4150 6168
67769ffc
PE
6169 * textprop.c (set_text_properties_1): Rewrite for clarity,
6170 and to avoid GCC warning about integer overflow.
6171
c20db43f
PE
6172 * intervals.h (struct interval): Use EMACS_INT for members
6173 where EMACS_UINT might cause problems. See
6174 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6175 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6176 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6177 All uses changed.
37aa2f85
PE
6178 (offset_intervals): Tell GCC not to worry about length overflow
6179 when negating a negative length.
c20db43f 6180
2538aa2f
PE
6181 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6182 (overrun_check_free): Likewise.
6183
f2d3008d
PE
6184 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6185 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6186 word size.
6187
ec8df744
PE
6188 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6189 (gnutls_make_error): Rename local to avoid shadowing.
6190 (gnutls_emacs_global_deinit): ifdef out; not used.
6191 (Fgnutls_boot): Use const for pointer to readonly storage.
6192 Comment out unused local. Fix pointer signedness problems.
6193
640ee02d
PE
6194 * lread.c (openp): Don't stuff size_t into an 'int'.
6195 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6196 about possible signed overflow.
6197
6048fb2a
PE
6198 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6199 (GDK_KEY_g): Don't define if already defined.
6200 (xg_prepare_tooltip): Avoid pointer signedness problem.
6201 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6202
fa3c87e1
PE
6203 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6204 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6205
2172544b
PE
6206 * xfns.c (Fx_window_property): Simplify a bit,
6207 to make a bit faster and to avoid GCC 4.6.0 warning.
6208 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6209
9b821a21
PE
6210 * fns.c (internal_equal): Don't assume size_t fits in int.
6211
3c616cfa
PE
6212 * alloc.c (compact_small_strings): Tighten assertion a little.
6213
c2982e87
PE
6214 Replace pEd with more-general pI, and fix some printf arg casts.
6215 * lisp.h (pI): New macro, generalizing old pEd macro to other
6216 conversion specifiers. For example, use "...%"pI"d..." rather
6217 than "...%"pEd"...".
6218 (pEd): Remove. All uses replaced with similar uses of pI.
6219 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6220 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6221 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6222 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6223 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6224 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6225 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6226 64-bit hosts.
6227 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6228 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6229 * print.c (safe_debug_print, print_object): Likewise.
6230 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6231 to int.
6f04d126
PE
6232 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6233 avoiding the 0 flag, which is not portable.
c2982e87
PE
6234 * process.c (Fmake_network_process): Use pI to avoid cast.
6235 * region-cache.c (pp_cache): Likewise.
6236 * xdisp.c (decode_mode_spec): Likewise.
6237 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6238 behavior on 64-bit hosts with printf arg.
6f04d126 6239 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6240 (x_stop_queuing_selection_requests): Likewise.
6241 (x_get_window_property): Don't truncate byte count to an 'int'
6242 when tracing.
0b432f21 6243
5e073ec7
PE
6244 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6245 here, since it parses constructs like leading '-' and spaces,
6246 which are not wanted; and it overflows with large numbers.
6247 Instead, simply match F[0-9]+, which is what is wanted anyway.
6248
36372bf9
PE
6249 * alloc.c: Remove unportable assumptions about struct layout.
6250 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6251 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6252 (allocate_vectorlike, make_pure_vector): Use the new macros,
6253 plus offsetof, to remove unportable assumptions about struct layout.
6254 These assumptions hold on all porting targets that I know of, but
6255 they are not guaranteed, they're easy to remove, and removing them
6256 makes further changes easier.
6257
0b432f21
PE
6258 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6259 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6260 (string_overrun_cookie): Now const. Use initializers that
6261 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6262 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6263 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6264 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6265 multiple of sizeof (EMACS_INT); it need not be, if
6266 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6267 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6268
895009e1
JB
62692011-04-26 Juanma Barranquero <lekktu@gmail.com>
6270
6271 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6272
6a7a1b0b
TZ
62732011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6274
6275 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6276 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6277 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6278
841a1577 62792011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6280
6281 * lisp.h (Qdebug): List symbol.
895009e1 6282 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6283 * keyboard.c (debug-on-event): New variable.
6284 (handle_user_signal): Break into debugger when debug-on-event
6285 matches the current signal symbol.
6286
f2d3ba6f
DN
62872011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6288
6289 * alloc.c (check_sblock, check_string_bytes)
6290 (check_string_free_list): Convert to standard C.
6291
42ce4c63
TZ
62922011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6293
6294 * w32.c (emacs_gnutls_push): Fix typo.
6295
825cd63c
EZ
62962011-04-25 Eli Zaretskii <eliz@gnu.org>
6297
fb11d64d
EZ
6298 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6299 "cast to pointer from integer of different size".
6300
825cd63c
EZ
6301 Improve doprnt and its use in verror. (Bug#8545)
6302 * doprnt.c (doprnt): Document the set of format control sequences
6303 supported by the function. Use SAFE_ALLOCA instead of always
6304 using `alloca'.
6305
6306 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6307 is one byte too soon. Don't use xrealloc; instead xfree and
6308 xmalloc anew.
6309
e061a11b
TZ
63102011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6311
6312 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6313 callbacks stage.
6314
6315 * gnutls.c: Renamed global_initialized to
6316 gnutls_global_initialized. Added internals for the
6317 :verify-hostname-error, :verify-error, and :verify-flags
6318 parameters of `gnutls-boot' and documented those parameters in the
6319 docstring. Start callback support.
9173deec
JB
6320 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6321 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6322 on error. Return error code.
e061a11b
TZ
6323 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6324 (emacs_gnutls_read): Likewise.
6325 (Fgnutls_boot): Return handshake error code.
6326 (emacs_gnutls_handle_error): New function.
6327 (wsaerror_to_errno): Likewise.
6328
6329 * w32.h (emacs_gnutls_pull): Add prototype.
6330 (emacs_gnutls_push): Likewise.
6331
6332 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6333 (emacs_gnutls_push): Likewise.
6334
63352011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6336
6337 * process.c (wait_reading_process_output): Check if GnuTLS
6338 buffered some data internally if no FDs are set for TLS
6339 connections.
6340
6341 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6342 (LIBS): Link to USER_LIBS.
6343 ($(BLD)/gnutls.$(0)): New target.
6344
fa6996bc
EZ
63452011-04-24 Eli Zaretskii <eliz@gnu.org>
6346
eb35682e
EZ
6347 * xdisp.c (handle_single_display_spec): Rename the
6348 display_replaced_before_p argument into display_replaced_p, to
6349 make it consistent with the commentary. Fix typos in the
6350 commentary.
6351
e2ad650c
EZ
6352 * textprop.c (syms_of_textprop): Remove dead code.
6353 (copy_text_properties): Delete obsolete commentary about an
6354 interface that was deleted long ago. Fix typos in the description
6355 of arguments.
6356
1b2de274
EZ
6357 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6358 to changes in oldXMenu/XMenu.h from 2011-04-16.
6359 <menu_help_message, prev_menu_help_message>: Constify.
6360 (IT_menu_make_room): menu->help_text is now `const char **';
6361 adjust.
6362
6363 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6364 to changes in oldXMenu/XMenu.h from 2011-04-16.
6365 (struct XMenu): Declare `help_text' `const char **'.
6366
6367 * xfaces.c <Qunspecified>: Make extern again.
6368
6369 * syntax.c: Include sys/types.h before including regex.h, as
6370 required by Posix.
6371
762b15be
EZ
6372 * doc.c (get_doc_string): Improve the format passed to `error'.
6373
6374 * doprnt.c (doprnt): Improve commentary.
6375
6376 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6377
6378 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6379 them with etags.
6380
f1052e5d
EZ
6381 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6382 changes in globals.h immediately force recompilation.
762b15be
EZ
6383 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6384 $(CURDIR)/s/ms-w32.h.
6385 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6386
fa6996bc
EZ
6387 * character.c (Fchar_direction): Function deleted.
6388 (syms_of_character): Don't defsubr it.
6389 <char-direction-table>: Deleted.
6390
e6c3da20
EZ
63912011-04-23 Eli Zaretskii <eliz@gnu.org>
6392
6393 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6394 * doprnt.c: Include limits.h.
6395 (SIZE_MAX): New macro.
04f2d78b
CB
6396 (doprnt): Return a size_t value. 2nd arg is now size_t.
6397 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6398 Improve overflow protection. Support `l' modifier for integer
6399 conversions. Support %l conversion. Don't assume an EMACS_INT
6400 argument for integer conversions and for %c.
6401
6402 * lisp.h (doprnt): Restore prototype.
6403
6404 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6405 $(SRC)/character.h.
6406
6407 * Makefile.in (base_obj): Add back doprnt.o.
6408
6409 * deps.mk (doprnt.o): Add back prerequisites.
6410 (callint.o): Depend on character.h.
6411
6412 * eval.c (internal_lisp_condition_case): Include the handler
6413 representation in the error message.
6414 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6415 when breaking from the loop.
6416
6417 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6418
6419 * callint.c (Fcall_interactively): When displaying error message
6420 about invalid control letter, pass the character's codepoint, not
6421 a pointer to its multibyte form. Improve display of the character
6422 in octal and display also its hex code.
6423
6424 * character.c (char_string): Use %x to display the (unsigned)
6425 codepoint of an invalid character, to avoid displaying a bogus
6426 negative value.
6427
6428 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6429 `error', not SYMBOL_NAME itself.
6430
6431 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6432 character arguments to `error'.
6433
6434 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6435 to `error' in error message about FINAL_CHAR argument. Make sure
6436 FINAL_CHAR is a character, and use %c when it is passed as
6437 argument to `error'.
6438
4ffd0d6b 64392011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6440
6441 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6442
6443 * w32.c: Include <time.h>.
6444 (sys_localtime): New function.
6445
4ffd0d6b 64462011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6447
6448 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6449
4ffd0d6b 6450 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6451
4ffd0d6b 64522011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6453
4ffd0d6b
GM
6454 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6455 zombies (Bug#8467).
aac0c6e3 6456
04c56954
EZ
64572011-04-19 Eli Zaretskii <eliz@gnu.org>
6458
6459 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6460 gl_state.e_property when gl_state.object is Qt.
6461
6462 * insdel.c (make_gap_larger): Remove limitation of buffer size
6463 to <= INT_MAX.
6464
16a43933
CY
64652011-04-18 Chong Yidong <cyd@stupidchicken.com>
6466
6467 * xdisp.c (lookup_glyphless_char_display)
6468 (produce_glyphless_glyph): Handle cons cell entry in
6469 glyphless-char-display.
6470 (Vglyphless_char_display): Document it.
6471
6472 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6473 glyphless-char-display.
6474
4581706e
CY
64752011-04-17 Chong Yidong <cyd@stupidchicken.com>
6476
6477 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6478
6479 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6480
6481 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6482 definition for no-X builds.
6483
4887c6e2 64842011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6485
fd35b6f9
PE
6486 Static checks with GCC 4.6.0 and non-default toolkits.
6487
5c1ccb01
PE
6488 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6489
006c5daa
PE
6490 * process.c (keyboard_bit_set): Define only if SIGIO.
6491 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6492 (send_process): Repair possible setjmp clobbering.
6493
efc736d3
PE
6494 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6495
4e2fe2e6
PE
6496 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6497
f97334a2
PE
6498 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6499
4e75f29d
PE
6500 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6501 Define only if needed.
6502
90efadd1
PE
6503 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6504 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6505 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6506
3c647824
PE
6507 * dispextern.h (struct redisplay_interface): Rename param
6508 to avoid shadowing.
e264f262 6509 * termhooks.h (struct terminal): Likewise.
761383f4 6510 * xterm.c (xembed_send_message): Likewise.
3c647824 6511
b58c5c4a
PE
6512 * insdel.c (make_gap_smaller): Define only if
6513 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6514
cad59032
PE
6515 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6516 it.
6517
c339dc2e
PE
6518 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6519 so that we aren't warned about unused symbols.
6520
91a3e27b
PE
6521 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6522
399c71d3 6523 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6524
8ffc96f5
PE
6525 * xfns.c (x_real_positions): Mark locals as initialized.
6526
eef9bc79
PE
6527 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6528
098db9dd
PE
6529 * xterm.c: Fix problems found by static analysis with other toolkits.
6530 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6531 (x_dispatch_event): Declare static if USE_GTK, and
6532 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6533 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6534 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6535 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6536 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6537
eb18f6cc
PE
6538 * xmenu.c (menu_help_callback): Pointer type fixes.
6539 Use const pointers when pointing at readonly data. Avoid pointer
6540 signedness clashes.
6541 (FALSE): Remove unused macro.
6542 (update_frame_menubar): Remove unused decl.
6543
1fe72bf8
PE
6544 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6545
60d9e1db
PE
6546 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6547 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6548 (single_menu_item): Rename local to avoid shadowing.
6549
39261c26
PE
6550 * keyboard.c (make_lispy_event): Remove unused local var.
6551
018c5e19
PE
6552 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6553 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6554
63d2b86e
PE
6555 * bitmaps: Change bitmaps from unsigned char back to the X11
6556 compatible char. Avoid the old compiler warnings about
6557 out-of-range initializers by using, for example, '\xab' rather
6558 than 0xab.
6559
aefd87e1
PE
6560 * xgselect.c (xgselect_initialize): Check vs interface
6561 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6562
bf501fb9
PE
6563 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6564
e9829fdf
PE
6565 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6566 to read-only memory.
6567
1086c095
PE
6568 * fns.c (vector): Remove; this old hack is no longer needed.
6569
2baccd04 6570 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6571 Remove unused var.
dde42981 6572 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6573
72391843 6574 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6575
436c16df 6576 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6577 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6578 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6579
92bb796d 6580 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6581 (x_term_init): Remove local to avoid shadowing.
92bb796d 6582
764430a3 6583 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6584
6585 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6586 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6587
d1dfb56c
EZ
65882011-04-16 Eli Zaretskii <eliz@gnu.org>
6589
c4354cb4
EZ
6590 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6591
d1dfb56c
EZ
6592 Fix regex.c, syntax.c and friends for buffers > 2GB.
6593 * syntax.h (struct gl_state_s): Declare character position members
6594 EMACS_INT.
6595
6596 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6597
04f2d78b
CB
6598 * textprop.c (verify_interval_modification, interval_of):
6599 Declare arguments EMACS_INT.
d1dfb56c
EZ
6600
6601 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6602 EMACS_INT.
6603
6604 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6605
6606 * indent.c (Fvertical_motion): Local variable it_start is now
6607 EMACS_INT.
6608
6609 * regex.c (re_match, re_match_2, re_match_2_internal)
6610 (bcmp_translate, regcomp, regexec, print_double_string)
6611 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6612 (re_compile_pattern, re_exec): Declare arguments and local
6613 variables `size_t' and `ssize_t' and return values `regoff_t', as
6614 appropriate.
6615 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6616 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6617 <compile_stack_type>: `size' and `avail' are now `size_t'.
6618
6619 * regex.h <regoff_t>: Use ssize_t, not int.
6620 (re_search, re_search_2, re_match, re_match_2): Arguments that
6621 specify buffer/string position and length are now ssize_t and
6622 size_t. Return type is regoff_t.
6623
613052cd
BK
66242011-04-16 Ben Key <bkey76@gmail.com>
6625
6626 * nsfont.m: Fixed bugs in ns_get_family and
6627 ns_descriptor_to_entity that were caused by using free to
6628 deallocate memory blocks that were allocated by xmalloc (via
6629 xstrdup). This caused Emacs to crash when compiled with
6630 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6631 --enable-checking=xmallocoverrun). xfree is now used to
6632 deallocate these memory blocks.
6633
4170f62f 66342011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6635
71b41406
PE
6636 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6637
9587a89d
PE
6638 emacs_write: Accept and return EMACS_INT for sizes.
6639 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6640 et seq.
6641 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6642 Accept and return EMACS_INT.
6643 (emacs_gnutls_write): Return the number of bytes written on
6644 partial writes.
6645 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6646 (emacs_read, emacs_write): Remove check for negative size, as the
6647 Emacs source code has been audited now.
9587a89d
PE
6648 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6649 (emacs_read, emacs_write): Use it.
273a5f82
PE
6650 * process.c (send_process): Adjust to the new signatures of
6651 emacs_write and emacs_gnutls_write. Do not attempt to store
6652 a byte offset into an 'int'; it might overflow.
9587a89d 6653 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6654
3e047f51
PE
6655 * sound.c: Don't assume sizes fit in 'int'.
6656 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6657 Return EMACS_INT, not int.
3e047f51 6658 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6659 Accept EMACS_INT, not int.
6660 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6661 record read return values.
6662
cc39a9db
BK
66632011-04-15 Ben Key <bkey76@gmail.com>
6664
c9d0ec6d
JB
6665 * keyboard.c (Qundefined): Don't declare static since it is used
6666 in nsfns.m.
6667 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6668 static since they are used in nsfont.m.
cc39a9db 6669
6c60eb9f
SM
66702011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6671
6672 * process.c (Qprocessp): Don't declare static.
6673 * lisp.h (Qprocessp): Declare again.
6674
7990b61a
JB
66752011-04-15 Juanma Barranquero <lekktu@gmail.com>
6676
6677 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6678
5d4cb038
PE
66792011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6680
8bd7b830 6681 Improve C-level modularity by making more things 'static'.
cd64ea1d 6682
e3b27b31
PE
6683 Don't publish debugger-only interfaces to other modules.
6684 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6685 (verify_bytepos, count_markers): Move decls to the only modules
6686 that need them.
6687 * region-cache.h (pp_cache): Likewise.
6688 * window.h (check_all_windows): Likewise.
6689 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6690
5d4cb038
PE
6691 * sysdep.c (croak): Now static, if
6692 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6693 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6694
6695 * alloc.c (refill_memory_reserve): Now static if
6696 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6697 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6698
e87b6180
PE
6699 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6700 Define only if USE_LUCID.
6701
ac64929e
PE
6702 * xrdb.c (x_customization_string, x_rm_string): Now static.
6703
6f37259d
PE
6704 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6705 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6706
1683e3ab
PE
6707 * xdisp.c (draw_row_with_mouse_face): Now static.
6708 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6709
de9c2632
PE
6710 * window.h (check_all_windows): Mark externally visible.
6711
2b96acb7
PE
6712 * window.c (window_deletion_count): Now static.
6713
6714 * undo.c: Make symbols static if they're not exported.
6715 (last_undo_buffer, last_boundary_position, pending_boundary):
6716 Now static.
6717
50436f33
PE
6718 * textprop.c (interval_insert_behind_hooks): Now static.
6719 (interval_insert_in_front_hooks): Likewise.
6720
64520e5c
PE
6721 * term.c: Make symbols static if they're not exported.
6722 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6723 (max_frame_lines, tty_set_terminal_modes):
6724 (tty_reset_terminal_modes, tty_turn_off_highlight):
6725 (get_tty_terminal): Now static.
6726 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6727 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6728 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6729 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6730 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6731
1fa53021
PE
6732 * sysdep.c: Make symbols static if they're not exported.
6733 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6734 Now static.
6735 (sigprocmask_set, full_mask): Remove; unused.
6736 (wait_debugging): Mark as visible.
6737 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6738 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6739
d4b43b22
PE
6740 * syntax.c (syntax_temp): Define only if !__GNUC__.
6741
b7c513d0
PE
6742 * sound.c (current_sound_device, current_sound): Now static.
6743
989b29ad
PE
6744 * search.c (searchbufs, searchbuf_head): Now static.
6745
13a55a78
PE
6746 * scroll.c (scroll_cost): Remove; unused.
6747 * dispextern.h (scroll_cost): Remove decl.
6748
de68a1fc
PE
6749 * region-cache.h (pp_cache): Mark as externally visible.
6750
40ccffa6
PE
6751 * process.c: Make symbols static if they're not exported.
6752 (process_tick, update_tick, create_process, chan_process):
6753 (Vprocess_alist, proc_buffered_char, datagram_access):
6754 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6755 (deactivate_process): Mark defn as static, as well as decl.
6756 * lisp.h (create_process): Remove decl.
6757 * process.h (chan_process, Vprocess_alist): Remove decls.
6758
ad64fc97
PE
6759 * print.c: Make symbols static if they're not exported.
6760 (print_depth, new_backquote_output, being_printed, print_buffer):
6761 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6762 (print_interval, print_number_index, initial_stderr_stream):
6763 Now static.
6764 * lisp.h (Fprinc): Remove decl.
6765 (debug_output_compilation_hack): Mark as externally visible.
6766
adddb265
PE
6767 * sysdep.c (croak): Move decl from here to syssignal.h.
6768 * syssignal.h (croak): Put it here, so the API can be checked when
6769 'croak' is called from dissociate_if_controlling_tty.
6770
1717ede2
PE
6771 * minibuf.c: Make symbols static if they're not exported.
6772 (minibuf_save_list, choose_minibuf_frame): Now static.
6773 * lisp.h (choose_minibuf_frame): Remove decl.
6774
fa5fb2bc
PE
6775 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6776
1e3890d1
PE
6777 * lread.c: Make symbols static if they're not exported.
6778 (read_objects, initial_obarray, oblookup_last_bucket_number):
6779 Now static.
6780 (make_symbol): Remove; unused.
6781 * lisp.h (initial_obarray, make_symbol): Remove decls.
6782
8a1414fa
PE
6783 * keyboard.c: Make symbols static if they're not exported.
6784 (single_kboard, recent_keys_index, total_keys, recent_keys):
6785 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6786 (this_single_command_key_start, echoing, last_auto_save):
6787 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6788 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6789 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6790 (Vlispy_mouse_stem, double_click_count):
6791 Now static.
6792 (force_auto_save_soon): Define only if SIGDANGER.
6793 (ignore_mouse_drag_p): Now static if
6794 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6795 (print_help): Remove; unused.
6796 (stop_character, last_timer_event): Mark as externally visible.
6797 * keyboard.h (ignore_mouse_drag_p): Declare only if
6798 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6799 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6800 * lisp.h (echoing): Remove decl.
6801 (force_auto_save_soon): Declare only if SIGDANGER.
6802 * xdisp.c (redisplay_window): Simplify code, to make it more
6803 obvious that ignore_mouse_drag_p is not accessed if !defined
6804 USE_GTK && !defined HAVE_NS.
6805
93ea6e8f
PE
6806 * intervals.c: Make symbols static if they're not exported.
6807 (merge_properties_sticky, merge_interval_right, delete_interval):
6808 Now static.
6809 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6810
77382fcc
PE
6811 * insdel.c: Make symbols static if they're not exported.
6812 However, leave prepare_to_modify_buffer alone. It's never
6813 called from outside this function, but that appears to be a bug.
6814 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6815 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6816 (adjust_after_replace_noundo): Remove; unused.
6817 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6818 (signal_before_change): Remove decls.
77382fcc 6819
9306c32e
PE
6820 * indent.c (val_compute_motion, val_vmotion): Now static.
6821
cd44d2eb
PE
6822 * image.c: Make symbols static if they're not exported.
6823 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6824 if USE_GTK.
6825 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6826 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6827
ad9a7a06
PE
6828 * fringe.c (standard_bitmaps): Now static.
6829 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6830
81626931
PE
6831 * frame.c: Make symbols static if they're not exported.
6832 (x_report_frame_params, make_terminal_frame): Now static.
6833 (get_frame_param): Now static, unless HAVE_NS.
6834 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6835 (x_get_resource_string): Remove; not used.
6836 * frame.h (make_terminal_frame, x_report_frame_params):
6837 (x_get_resource_string); Remove decls.
6838 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6839 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6840
239f9db9
PE
6841 * font.c, fontset.c: Make symbols static if they're not exported.
6842 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6843 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6844 * font.c (font_close_object): Now static.
6845 * font.h (font_close_object): Remove.
6846 * fontset.c (FONTSET_OBJLIST): Remove.
6847 (free_realized_fontset) #if-0 the body, which does nothing.
6848 (face_suitable_for_char_p): #if-0, as it's never called.
6849 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6850 * xfaces.c (face_at_string_position):
6851 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6852 since 0 is always ASCII.
6853
dfcf3579
PE
6854 * fns.c (weak_hash_tables): Now static.
6855
5045092b
PE
6856 * fileio.c: Make symbols static if they're not exported.
6857 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6858 (Vwrite_region_annotation_buffers): Now static.
6859
57a96f5c
PE
6860 * eval.c: Make symbols static if they're not exported.
6861 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6862 * lisp.h (backtrace_list): Remove decl.
6863
35f08c38
PE
6864 * emacs.c: Make symbols static if they're not exported.
6865 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6866 (fatal_error_code, fatal_error_signal_hook, standard_args):
6867 Now static.
6868 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6869 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6870 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6871 * lisp.h (fatal_error_signal_hook): Remove decl.
6872 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6873
f44bd759
PE
6874 * editfns.c: Move a (normally-unused) function to its only use.
6875 * editfns.c, lisp.h (get_operating_system_release): Remove.
6876 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6877 worth the hassle of breaking this out.
6878
b532497d
PE
6879 * xterm.c: Make symbols static if they're not exported.
6880 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6881 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6882 (x_destroy_window, x_delete_display):
6883 Now static.
6884 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6885 (x_mouse_leave): Remove; unused.
6886 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6887 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6888 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6889 Remove decls.
6890 (x_mouse_leave): Declare only if WINDOWSNT.
6891 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6892 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6893 USE_X_TOOLKIT.
6894
1675728f
PE
6895 * ftxfont.c: Make symbols static if they're not exported.
6896 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6897 HAVE_FREETYPE.
6898 * font.h (ftxfont_driver): Likewise.
6899
e4cebfca
PE
6900 * xfns.c: Make symbols static if they're not exported.
6901 (x_last_font_name, x_display_info_for_name):
6902 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6903 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6904 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6905 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6906 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6907 (last_show_tip_args): Now static.
6908 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6909 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6910 (x_screen_planes): Remove; unused.
6911 * dispextern.h (x_screen_planes): Remove decl.
6912
5bf46f05
PE
6913 * dispnew.c: Make symbols static if they're not exported.
6914 * dispextern.h (redraw_garbaged_frames, scrolling):
6915 (increment_row_positions): Remove.
6916 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6917 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6918 Now static.
6919 (redraw_garbaged_frames): Remove; unused.
6920
435f4c28
PE
6921 * xfaces.c: Make symbols static if they're not exported.
6922 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6923 Remove decls.
6924 * xterm.h (defined_color): Remove decls.
6925 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6926 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6927 (menu_face_changed_default, defined_color, free_realized_face):
6928 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6929 (ascii_face_of_lisp_face): Remove; unused.
6930
8524aef3
PE
6931 * xdisp.c: Make symbols static if they're not exported.
6932 * dispextern.h (scratch_glyph_row, window_box_edges):
6933 (glyph_to_pixel_coords, set_cursor_from_row):
6934 (get_next_display_element, set_iterator_to_next):
6935 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6936 (show_mouse_face): Remove decls
6937 * frame.h (message_buf_print): Likewise.
6938 * lisp.h (pop_message, set_message, check_point_in_composition):
6939 Likewise.
6940 * xterm.h (set_vertical_scroll_bar): Likewise.
6941 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6942 (message_buf_print, scratch_glyph_row, displayed_buffer):
6943 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6944 (get_next_display_element, show_mouse_face, window_box_edges):
6945 (frame_to_window_pixel_xy, check_point_in_composition):
6946 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6947 (glyph_to_pixel_coords): Remove; unused.
6948
16390cd2
PE
6949 * dired.c (file_name_completion): Now static.
6950
6951 * dbusbind.c (xd_in_read_queued_messages): Now static.
6952
a25f4dfa
PE
6953 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6954 * data.c (circular_list_error): Remove.
6955
14a9c8df
PE
6956 * commands.h (last_point_position, last_point_position_buffer):
6957 (last_point_position_window): Remove decls.
6958 * keyboard.c: Make these variables static.
6959
04f2d78b
CB
6960 * coding.h (coding, code_convert_region, encode_coding_gap):
6961 Remove decls.
74ab6df5
PE
6962 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6963 (iso_code_class, detect_coding, code_convert_region): Now static.
6964 (encode_coding_gap): Remove; unused.
6965
38dfbee1
PE
6966 * chartab.c (chartab_chars, chartab_bits): Now static.
6967
a2cb4e63
PE
6968 * charset.h (charset_iso_8859_1): Remove decl.
6969 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6970 Now static.
6971
127198fd
PE
6972 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6973 * ccl.c (Vccl_program_table): Now static.
6974 (check_ccl_update): Remove; unused.
6975
d85b608f
PE
6976 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6977 * category.h: ... from here.
6978 * category.c (check_category_table, set_category_set): Now static.
6979
31cd66f3
PE
6980 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6981 * lisp.h: Remove these decls.
6982
c358e587
PE
6983 * buffer.c (buffer_count): Remove unused var.
6984
e78aecca
PE
6985 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6986 so that it's not optimized away.
6987 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6988 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6989 exported only to the debugger.
6990
e192d7d3 6991 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6992 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6993
92470028
PE
6994 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6995 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6996 was inaccessible from Lisp.
6997 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6998 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6999
244ed907
PE
7000 alloc.c: Import and export fewer symbols, and remove unused items.
7001 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7002 is defined.
7003 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7004 it's not optimized away by whole-program optimization.
7005 (message_enable_multibyte, free_misc): Remove.
7006 (catchlist, handlerlist, mark_backtrace):
7007 Declare only if BYTE_MARK_STACK.
7008 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7009 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7010 (message_enable_multibyte): Remove decl.
7011 (free_misc, interval_free_list, float_block, float_block_index):
7012 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7013 (cons_free_list, last_marked_index):
7014 Now static.
7015 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7016 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7017 (mark_backtrace): Define only if BYTE_MARK_STACK.
7018 * xdisp.c (message_enable_multibyte): Now static.
7019
61c2b50e 7020 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7021 This makes it easier for human readers (and static analyzers)
7022 to see whether these variables are used from other modules.
7023 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7024 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7025 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7026 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7027 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7028 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7029 * xmenu.c, xselect.c:
7030 Declare Q* vars static if they are not used in other modules.
7031 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7032 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7033 Remove decls of unexported vars.
7034 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7035
95c82688
PE
7036 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7037
16a97296
PE
7038 Make Emacs functions such as Fatom 'static' by default.
7039 This makes it easier for human readers (and static analyzers)
7040 to see whether these functions can be called from other modules.
7041 DEFUN now defines a static function. To make the function external
7042 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7043 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7044 (Finit_image_library):
16a97296
PE
7045 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7046 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7047 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7048 Remove decls, since these functions are now static.
7049 (Funintern, Fget_internal_run_time): New decls, since these functions
7050 were already external.
95c82688 7051
16a97296
PE
7052 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7053 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7054 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7055 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7056 * keyboard.c, keymap.c, lread.c:
7057 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7058 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7059 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7060 Mark functions with DEFUE instead of DEFUN,
7061 if they are used in other modules.
7062 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7063 decls for now-static functions.
7064 * buffer.h (Fdelete_overlay): Remove decl.
7065 * callproc.c (Fgetenv_internal): Mark as internal.
7066 * composite.c (Fremove_list_of_text_properties): Remove decl.
7067 (Fcomposition_get_gstring): New forward static decl.
7068 * composite.h (Fcomposite_get_gstring): Remove decl.
7069 * dired.c (Ffile_attributes): New forward static decl.
7070 * doc.c (Fdocumntation_property): New forward static decl.
7071 * eval.c (Ffetch_bytecode): New forward static decl.
7072 (Funintern): Remove extern decl; now in .h file where it belongs.
7073 * fileio.c (Fmake_symbolic_link): New forward static decl.
7074 * image.c (Finit_image_library): New forward static decl.
7075 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7076 * intervals.h (Fprevious_property_change):
7077 (Fremove_list_of_text_properties): Remove decls.
7078 * keyboard.c (Fthis_command_keys): Remove decl.
7079 (Fcommand_execute): New forward static decl.
7080 * keymap.c (Flookup_key): New forward static decl.
7081 (Fcopy_keymap): Now static.
7082 * keymap.h (Flookup_key): Remove decl.
7083 * process.c (Fget_process): New forward static decl.
7084 (Fprocess_datagram_address): Mark as internal.
7085 * syntax.c (Fsyntax_table_p): New forward static decl.
7086 (skip_chars): Remove duplicate decl.
7087 * textprop.c (Fprevious_property_change): New forward static decl.
7088 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7089 Now internal.
7090 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7091 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7092
785bbd42
PE
7093 * editfns.c (Fformat): Remove unreachable code.
7094
8b913b57
AS
70952011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7096
7097 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7098 change. (Bug#8496)
7099
a6744a35
EZ
71002011-04-13 Eli Zaretskii <eliz@gnu.org>
7101
7102 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7103 when at ZV. (Bug#8487)
7104
e7974947
AS
71052011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7106
baad03f0
AS
7107 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7108 (Bug#8437)
7109 * keyboard.c (parse_tool_bar_item): Likewise.
7110 * sound.c (sound_cleanup, alsa_close): Likewise.
7111 * termcap.c (tgetent): Likewise.
7112 * xfns.c (x_default_font_parameter): Likewise.
7113 * xsettings.c (read_and_apply_settings): Likewise.
7114
e7974947
AS
7115 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7116 (overrun_check_free): Protoize.
7117
28272684
PE
71182011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7119
7120 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7121 since callers should never pass a negative size.
7122 Change the signature to match that of plain 'read' and 'write'; see
7123 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7124 * lisp.h: Update prototypes of emacs_write and emacs_read.
7125
11997c76
EZ
71262011-04-11 Eli Zaretskii <eliz@gnu.org>
7127
7128 * xdisp.c (redisplay_window): Don't try to determine the character
7129 position of the scroll margin if the window start point w->startp
e896f03c 7130 is outside the buffer's accessible region. (Bug#8468)
11997c76 7131
8a2cbd72
EZ
71322011-04-10 Eli Zaretskii <eliz@gnu.org>
7133
7134 Fix write-region and its subroutines for buffers > 2GB.
7135 * fileio.c (a_write, e_write): Modify declaration of arguments and
7136 local variables to support buffers larger than 2GB.
7137 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7138
7139 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7140 argument, local variables, and return value.
7141
7142 * lisp.h: Update prototypes of emacs_write and emacs_read.
7143
7144 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7145
4073e537 71462011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7147
1ebfdcb6
PE
7148 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7149
b2ded58d
PE
7150 Fix more problems found by GCC 4.6.0's static checks.
7151
7d66342c
PE
7152 * xdisp.c (vmessage): Use a better test for character truncation.
7153
bbf47d44
PE
7154 * charset.c (load_charset_map): <, not <=, for optimization,
7155 and to avoid potential problems with integer overflow.
9248994d 7156 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7157 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7158 * editfns.c (Fformat): Likewise.
1e69125e 7159 * syntax.c (skip_chars): Likewise.
3befa583 7160
e3019616
PE
7161 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7162 This also lets GCC 4.6.0 generate slightly better loop code.
7163
becfa255
PE
7164 * callint.c (Fcall_interactively): <, not <=, for optimization.
7165 (Fcall_interactively): Count the number of arguments produced,
7166 not the number of arguments given. This is simpler and lets GCC
7167 4.6.0 generate slightly better code.
7168
dae0cd48
PE
7169 * ftfont.c: Distingish more carefully between FcChar8 and char.
7170 The previous code passed unsigned char * to a functions like
7171 strlen and xstrcasecmp that expect char *, which does not
7172 conform to the C standard.
7173 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7174 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7175 char * when the C standard requires it.
7176
76032d70
PE
7177 * keyboard.c (read_char): Remove unused var.
7178
eb3f1cc8
PE
7179 * eval.c: Port to Windows vsnprintf (Bug#8435).
7180 Include <limits.h>.
7181 (SIZE_MAX): Define if the headers do not.
7182 (verror): Do not give up if vsnprintf returns a negative count.
7183 Instead, grow the buffer. This ports to Windows vsnprintf, which
7184 does not conform to C99. Problem reported by Eli Zaretskii.
7185 Also, simplify the allocation scheme, by avoiding the need for
7186 calling realloc, and removing the ALLOCATED variable.
7187
70476b54
PE
7188 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7189
12020a9e
PE
7190 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7191 But keep the doprint source code for now, as we might revamp it
7192 and use it again (Bug#8435).
ea6c7ae6
PE
7193 * lisp.h (doprnt): Remove.
7194 * Makefile.in (base_obj): Remove doprnt.o.
7195 * deps.mk (doprnt.o): Remove.
7196
5fdb398c
PE
7197 error: Print 32- and 64-bit integers portably (Bug#8435).
7198 Without this change, on typical 64-bit hosts error ("...%d...", N)
7199 was used to print both 32- and 64-bit integers N, which relied on
7200 undefined behavior.
7201 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7202 New macro.
7203 * lisp.h (error, verror): Mark as printf-like functions.
7204 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7205 Report overflow in size calculations when allocating printf buffer.
7206 Do not truncate output string at its first null byte.
7207 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7208 Truncate the output at a character boundary, since vsnprintf does not
7209 do that.
7210 * charset.c (check_iso_charset_parameter): Convert internal
7211 character to string before calling 'error', since %c now has the
7212 printf meaning.
7213 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7214 overflow when computing char to be passed to 'error'. Do not
7215 pass Lisp_Object to 'error'; pass the integer instead.
7216 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7217 formatted with plain %d.
7218
b189fa66
PE
7219 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7220
bff87ef0
PE
7221 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7222
7e2cac20
PE
7223 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7224
ce4d90b5
PE
7225 * xterm.c (x_catch_errors): Remove duplicate declaration.
7226
266c9547
PE
7227 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7228
79c49ad2
PE
7229 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7230
368f4090
JM
72312011-04-10 Jim Meyering <meyering@redhat.com>
7232
7233 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7234 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7235 return ssize_t not "int", and use size_t as the buffer length.
7236 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7237 * gnutls.h: Update declarations.
7238 * process.c (read_process_output): Use ssize_t, to match.
7239 (send_process): Likewise.
7240
a32d4040
CY
72412011-04-09 Chong Yidong <cyd@stupidchicken.com>
7242
7243 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7244
8546720e 72452011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7246
04f2d78b
CB
7247 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7248 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7249
8546720e
GM
7250 * xterm.c (handle_one_xevent):
7251 * xmenu.c (create_and_show_popup_menu):
7252 * xselect.c (x_decline_selection_request)
7253 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7254
0a2f5c1a 72552011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7256
7257 Fix some uses of `int' instead of EMACS_INT.
7258 * search.c (string_match_1, fast_string_match)
7259 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7260 (scan_buffer, find_next_newline_no_quit)
7261 (find_before_next_newline, search_command, Freplace_match)
7262 (Fmatch_data): Make some `int' variables be EMACS_INT.
7263
7264 * xdisp.c (display_count_lines): 3rd argument and return value now
7265 EMACS_INT. All callers changed.
7266 (pint2hrstr): Last argument is now EMACS_INT.
7267
7268 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7269 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7270 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7271 (decode_coding_utf_16, decode_coding_emacs_mule)
7272 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7273 (decode_coding_ccl, decode_coding_charset)
7274 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7275 (decode_coding_iso_2022, decode_coding_emacs_mule)
7276 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7277 <char_offset, last_offset>: Declare EMACS_INT.
7278 (encode_coding_utf_8, encode_coding_utf_16)
7279 (encode_coding_emacs_mule, encode_invocation_designation)
7280 (encode_designation_at_bol, encode_coding_iso_2022)
7281 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7282 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7283 Declare EMACS_INT.
7284 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7285 (encode_invocation_designation): Last argument P_NCHARS is now
7286 EMACS_INT.
7287 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7288 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7289
7290 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7291 All users changed.
7292
7293 * ccl.c (Fccl_execute_on_string): Declare some variables
7294 EMACS_INT.
7295
8546720e 72962011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7297
7298 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7299
4e19a977
CS
73002011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7301
7302 * process.c (Fformat_network_address): Doc fix.
7303
87302331
R
73042011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7305
ee7683eb 7306 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7307
cbb59342
CY
73082011-04-08 Chong Yidong <cyd@stupidchicken.com>
7309
7310 * keyboard.c (read_char): Call Lisp function help-form-show,
7311 instead of using internal_with_output_to_temp_buffer.
7312 (Qhelp_form_show): New var.
e0d38eeb 7313 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7314
7315 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7316
7317 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7318
e67a13ab
CY
73192011-04-06 Chong Yidong <cyd@stupidchicken.com>
7320
04f2d78b
CB
7321 * process.c (Flist_processes): Remove to Lisp.
7322 (list_processes_1): Delete.
e67a13ab 7323
973f782d
EZ
73242011-04-06 Eli Zaretskii <eliz@gnu.org>
7325
7c106b1e
EZ
7326 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7327
973f782d
EZ
7328 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7329
41cf7d1a 73302011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7331
ca23cc88
PE
7332 Fix more problems found by GCC 4.6.0's static checks.
7333
f390e2d5
PE
7334 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7335
42eea0d0
PE
7336 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7337
b69769da 7338 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7339
f9541e84
PE
7340 * xdisp.c (vmessage): Mark as a printf-like function.
7341
13841b55
PE
7342 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7343
c136c10f
PE
7344 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7345
5e2d4a30
PE
7346 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7347 printf-like functions.
7348 (tiff_load): Add casts to remove these marks before passing them
7349 to system-supplied API.
7350
583f48b9
PE
7351 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7352
b25d760e
PE
7353 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7354 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7355 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7356 directly, rather than having caller test rule sign. This avoids
7357 some unnecessary tests.
7358 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7359 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7360 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7361
bc7b6697 7362 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7363 (xfont_open): Avoid unnecessary tests.
bc7b6697 7364
27ccc379
PE
7365 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7366
dcd5c89a
PE
7367 * composite.h, composite.c (composition_gstring_put_cache):
7368 Use EMACS_INT, not int, for length.
7369
b13a45c6
PE
7370 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7371 breaking out part of COMPOSITION_DECODE_RULE.
7372 (COMPOSITION_DECODE_RULE): Use it.
7373 * composite.c (get_composition_id): Remove unused local vars,
7374 by using the new macro.
7375
1e792e4d
PE
7376 * textprop.c (set_text_properties_1): Change while to do-while,
7377 since the condition is always true at first.
7378
dc6c6455 7379 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7380 (interval_deletion_adjustment): Return unsigned value.
7381 All uses changed.
dc6c6455 7382
aba7731a
PE
7383 * process.c (list_processes_1, create_pty, read_process_output):
7384 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7385 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7386 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7387 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7388 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7389
fdfc4bf3
PE
7390 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7391
fca8fe46 7392 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7393 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7394
06a0259a 7395 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7396 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7397 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7398
e7b9e80f
PE
7399 * print.c (print_error_message): Avoid int overflow.
7400
56201685
PE
7401 * font.c (font_list_entities): Redo for clarity,
7402 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7403
78834453 7404 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7405 (font_score): Avoid potential overflow in diff calculation.
78834453 7406
0bc0b309 7407 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7408 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7409
e610eaca
PE
7410 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7411
b895abce
PE
7412 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7413 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7414 can always succeed if overflow has undefined behavior.
7415
1f1d9321 7416 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7417 (wordify): Omit three unnecessary tests.
1f1d9321 7418
c59478bc
PE
7419 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7420 All callers changed. This avoids the need for an unused var.
7421
79b73827
PE
7422 * casefiddle.c (casify_region): Remove var that is set but not used.
7423
a4db5dfe
PE
7424 * dired.c (file_name_completion): Remove var that is set but not used.
7425
43aae36e
PE
7426 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7427
2a47c44d 7428 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7429 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7430
a37c69bf
PE
7431 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7432 Check for integer overflow on size calculations.
7433
328ab8e7
PE
7434 * buffer.c (Fprevious_overlay_change): Remove var that is set
7435 but not used.
7436
e5a2a5cb
PE
7437 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7438 Remove vars that are set but not used.
8d84a6eb 7439 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7440 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7441
a60e5f68
PE
7442 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7443
f661cb61 7444 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7445 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7446
f0397f5a
PE
7447 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7448 that are set but not used.
7449
8664db06 7450 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7451 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7452
6abdaa4a
PE
7453 * xselect.c (x_get_local_selection, x_handle_property_notify):
7454 Remove vars that are set but not used.
7455
0ce7538d 7456 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7457 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7458
9ae848fc
PE
7459 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7460 Remove var that is set but not used.
0b918413
PE
7461 (scroll_bar_windows_size): Now size_t, not int.
7462 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7463 Check for overflow.
9ae848fc 7464
a5a62657
PE
7465 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7466 (map_tty_color) [!defined MSDOS]: Likewise.
7467
5c5cdd39
PE
7468 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7469
66ebf983
PE
7470 * coding.c: Remove vars that are set but not used.
7471 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7472 All callers changed.
7473 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7474 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7475 (decode_coding_charset): Remove vars that are set but not used.
7476
1be4d761
PE
7477 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7478 that is set but not used.
7479
47553fa8
PE
7480 * print.c (print_object): Remove var that is set but not used.
7481
1f7196bf 7482 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7483 The gnulib version avoids calling malloc in the usual case,
7484 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7485 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7486 * filelock.c (current_lock_owner): Likewise.
7487 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7488 * sysdep.c: Include allocator.h, careadlinkat.h.
7489 (emacs_no_realloc_allocator): New static constant.
7490 (emacs_readlink): New function.
fdb61804
PE
7491 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7492 ../lib/careadlinkat.h.
d1fdcab7 7493
f84c17c7
SM
74942011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7495
7496 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7497 first non-nil return value).
7498
ef3862ad
JD
74992011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7500
7501 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7502 if not defined (Bug#8403).
7503
376a7006
JB
75042011-04-02 Juanma Barranquero <lekktu@gmail.com>
7505
7506 * xdisp.c (display_count_lines): Remove parameter `start',
7507 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7508 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7509 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7510 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7511 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7512 and thereabouts. All callers changed.
7513 (get_per_char_metric): Remove parameter `f', unused since
7514 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7515
6ca3801d
JM
75162011-04-02 Jim Meyering <meyering@redhat.com>
7517
7518 do not dereference NULL upon failed strdup
7519 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7520 (ns_get_family): Likewise.
7521
d8e2b5ba
JB
75222011-04-02 Juanma Barranquero <lekktu@gmail.com>
7523
7524 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7525
8c74fcbd
JD
75262011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7527
7528 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7529 later (Bug#8403).
7530
7200d79c
SM
75312011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7532
03408648 7533 Add lexical binding.
7200d79c 7534
03408648
SM
7535 * window.c (Ftemp_output_buffer_show): New fun.
7536 (Fsave_window_excursion):
7537 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7538
7539 * lread.c (lisp_file_lexically_bound_p): New function.
7540 (Fload): Bind Qlexical_binding.
7541 (readevalloop): Remove `evalfun' arg.
7542 Bind Qinternal_interpreter_environment.
7543 (Feval_buffer): Bind Qlexical_binding.
7544 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7545 Mark as dynamic.
7546 (syms_of_lread): Declare `lexical-binding'.
7547
7548 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7549
7550 * keyboard.c (eval_dyn): New fun.
7551 (menu_item_eval_property): Use it.
ca105506
SM
7552
7553 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7554
03408648
SM
7555 * fns.c (concat, mapcar1): Accept byte-code-functions.
7556
7557 * eval.c (Fsetq): Handle lexical vars.
7558 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7559 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7560 (FletX, Flet): Obey lexical binding.
7561 (Fcommandp): Handle closures.
7562 (Feval): New `lexical' arg.
7563 (eval_sub): New function extracted from Feval. Use it almost
7564 everywhere where Feval was used. Look up vars in lexical env.
7565 Handle closures.
7566 (Ffunctionp): Move from subr.el.
7567 (Ffuncall): Handle closures.
7568 (apply_lambda): Remove `eval_flags'.
7569 (funcall_lambda): Handle closures and new byte-code-functions.
7570 (Fspecial_variable_p): New function.
7571 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7572 but without exporting it to Lisp.
23aba0ea 7573
23aba0ea 7574 * doc.c (Fdocumentation, store_function_docstring):
03408648 7575 * data.c (Finteractive_form): Handle closures.
23aba0ea 7576
03408648
SM
7577 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7578 interactive spec.
ba83908c 7579
04f2d78b
CB
7580 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7581 New byte-codes.
03408648
SM
7582 (exec_byte_code): New function extracted from Fbyte_code to handle new
7583 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7584
03408648 7585 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7586
03408648 7587 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7588
e2abce01
JB
75892011-03-31 Juanma Barranquero <lekktu@gmail.com>
7590
7591 * xdisp.c (redisplay_internal): Fix prototype.
7592
63696a73 75932011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7594
63696a73 7595 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7596 (try_scrolling): Use it when setting scroll_limit.
7597 Limit scrolling to 100 screen lines.
63696a73
EZ
7598 (redisplay_window): Even when falling back on "recentering",
7599 position point in the window according to scroll-conservatively,
7600 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7601
7602 (try_scrolling): When point is above the window, allow searching
7603 as far as scroll_max, or one screenful, to compute vertical
7604 distance from PT to the scroll margin position. This prevents
7605 try_scrolling from unnecessarily failing when
7606 scroll-conservatively is set to a value slightly larger than the
7607 window height. Clean up the case of PT below the margin at bottom
7608 of window: scroll_max can no longer be INT_MAX. When aggressive
7609 scrolling is in use, don't let point enter the opposite scroll
7610 margin as result of the scroll.
7611 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7612 threshold of 100 lines for never-recentering scrolling.
7613
e4cc2dfc
JB
76142011-03-31 Juanma Barranquero <lekktu@gmail.com>
7615
7616 * dispextern.h (move_it_by_lines):
7617 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7618 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7619 (message_log_check_duplicate): Remove parameters `prev_bol' and
7620 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7621 (redisplay_internal): Remove parameter `preserve_echo_area',
7622 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7623
7624 * indent.c (Fvertical_motion):
7625 * window.c (window_scroll_pixel_based, Frecenter):
7626 Don't pass `need_y_p' to `move_it_by_lines'.
7627
1c470562
SM
76282011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7629
44f230aa
SM
7630 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7631 steal a few bits to be more compact.
7632 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7633 Remove unneeded casts.
7634
1c470562
SM
7635 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7636
888adce9
ZK
76372011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7638
7639 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7640 binding" message (bug#7967).
7641
f838ed7b
PE
76422011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7643
77861b95
PE
7644 Fix more problems found by GCC 4.6.0's static checks.
7645
de6dbc14
PE
7646 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7647 Remove unused local var.
7648
f838ed7b
PE
7649 * editfns.c (Fmessage_box): Remove unused local var.
7650
792c7b2b
PE
7651 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7652 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7653 Omit unused local vars.
c499e557 7654 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7655 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7656 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7657 Omit unused local var.
7658
ba0165e1
PE
7659 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7660 Don't assume string length fits in int.
32ad8845 7661 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7662 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7663
3c59b4c9
PE
7664 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7665 instead of alloca (Bug#8344).
7666
a3eed478 7667 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7668 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7669
eb4d412d
PE
7670 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7671
1658b401
PE
7672 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7673 concerns.
7674
7675 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7676
7677 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7678
9a2c6e05
PE
7679 * keyboard.c (syms_of_keyboard): Use the same style as later
7680 in this function when indexing through an array. This also
7681 works around GCC bug 48267.
7682
03d0a109
PE
7683 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7684
44f730c8
PE
7685 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7686
fe75f926
PE
7687 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7688 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7689
ffa8c828
PE
7690 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7691 This avoids undefined behavior on integer overflow, and is a bit
7692 more convenient anyway since it is compared to a size_t variable.
7693
c5101a77
PE
7694 Variadic C functions now count arguments with size_t, not int.
7695 This avoids an unnecessary limitation on 64-bit machines, which
7696 caused (substring ...) to crash on large vectors (Bug#8344).
7697 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7698 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7699 All variadic functions and their callers changed accordingly.
c5101a77
PE
7700 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7701 * data.c (arith_driver, float_arith_driver): Likewise.
7702 * editfns.c (general_insert_function): Likewise.
7703 * eval.c (struct backtrace.nargs, interactive_p)
7704 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7705 (funcall_lambda, mark_backtrace): Likewise.
7706 * fns.c (concat): Likewise.
7707 * frame.c (x_set_frame_parameters): Likewise.
7708 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7709 0 if not found, not -1. All callers changed.
7710
dd3f25f7
PE
7711 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7712 (stack_copy_size): Now size_t, not int.
7713 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7714
461c2ab9
JB
77152011-03-28 Juanma Barranquero <lekktu@gmail.com>
7716
7717 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7718 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7719 All callers changed.
7720
7721 * lisp.h (multibyte_char_to_unibyte):
7722 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7723 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7724 * character.h (CHAR_TO_BYTE8):
7725 * cmds.c (internal_self_insert):
7726 * editfns.c (general_insert_function):
7727 * keymap.c (push_key_description):
7728 * search.c (Freplace_match):
7729 * xdisp.c (message_dolog, set_message_1): All callers changed.
7730
f6d62986
SM
77312011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7732
7733 * keyboard.c (safe_run_hook_funcall): New function.
7734 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7735 don't set the hook to nil, but remove the offending function instead.
7736 (Qcommand_hook_internal): Remove, unused.
7737 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7738 Vcommand_hook_internal.
7739
7740 * eval.c (enum run_hooks_condition): Remove.
7741 (funcall_nil, funcall_not): New functions.
7742 (run_hook_with_args): Call each function through a `funcall' argument.
7743 Remove `cond' argument, now redundant.
7744 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7745 (Frun_hook_with_args_until_failure): Adjust accordingly.
7746 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7747
1db5b1ad
JB
77482011-03-28 Juanma Barranquero <lekktu@gmail.com>
7749
7750 * dispextern.h (string_buffer_position): Remove declaration.
7751
7752 * print.c (strout): Remove parameter `multibyte', unused since
7753 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7754
7755 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7756 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7757 All callers changed.
7758
7759 * w32.c (_wsa_errlist): Use braces for struct initializers.
7760
7761 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7762 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7763 All callers changed.
7764 (string_buffer_position): Likewise. Also, make static (it's never
7765 used outside xdisp.c).
7766 (cursor_row_p): Remove parameter `w', unused since
7767 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7768 (decode_mode_spec): Remove parameter `precision', introduced during
7769 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7770 All callers changed.
7771
5ffb62aa
JD
77722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7773
7774 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7775
461c2ab9 77762011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7777
7778 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7779 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7780 (ns_update_auto_hide_menu_bar): New functions.
7781 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7782 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7783 ns_constrain_all_frames.
7784 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7785 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7786
5c380ffb
JD
77872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7788
7789 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7790
9af30bdf
GM
77912011-03-27 Glenn Morris <rgm@gnu.org>
7792
7793 * syssignal.h: Replace RETSIGTYPE with void.
7794 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7795 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7796 Replace SIGTYPE with void everywhere.
7797 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7798 * s/template.h (SIGTYPE): Remove commented out definition.
7799
e2abce01
JB
78002011-03-26 Eli Zaretskii <eliz@gnu.org>
7801
7802 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7803 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7804
f868cd8a
JB
78052011-03-26 Juanma Barranquero <lekktu@gmail.com>
7806
59eb0929
JB
7807 * w32.c (read_unc_volume): Use parameter `henum', instead of
7808 global variable `wget_enum_handle'.
7809
7810 * keymap.c (describe_vector): Remove parameters `indices' and
7811 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7812 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7813
f868cd8a
JB
7814 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7815
7816 * keyboard.c (timer_check): Remove parameter `do_it_now',
7817 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7818 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7819 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7820
7821 * keyboard.c (read_char):
7822 * w32menu.c (w32_menu_display_help):
7823 * xmenu.c (show_help_event, menu_help_callback):
7824 Adjust calls to `show_help_echo'.
7825
7826 * gtkutil.c (xg_maybe_add_timer):
7827 * keyboard.c (readable_events):
7828 * process.c (wait_reading_process_output):
7829 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7830
7831 * insdel.c (adjust_markers_gap_motion):
7832 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7833 (gap_left, gap_right): Don't call it.
7834
2ecf6fdb
CY
78352011-03-25 Chong Yidong <cyd@stupidchicken.com>
7836
7837 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7838 incurred during fontification.
7839
6b1f9ba4
JB
78402011-03-25 Juanma Barranquero <lekktu@gmail.com>
7841
7842 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7843 (DEFVAR_PER_BUFFER): Don't pass it.
7844
7845 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7846 (scrolling_window): Don't pass it.
7847
0f4a96b5
JB
78482011-03-25 Juanma Barranquero <lekktu@gmail.com>
7849
7850 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7851
7852 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7853 and `suffix'.
7854 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7855 of variables specific to SELinux and computation of `encoded_absname'.
7856
7857 * image.c (XPutPixel): Remove unused variable `height'.
7858
7859 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7860
7861 * unexw32.c (get_section_info): Remove unused variable `section'.
7862
7863 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7864 (system_process_attributes): Remove unused variable `sess'.
7865 (sys_read): Remove unused variable `err'.
7866
7867 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7868 (w32_wnd_proc): Remove unused variable `isdead'.
7869 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7870 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7871 (x_create_tip_frame): Remove unused variable `tem'.
7872
7873 * w32inevt.c (w32_console_read_socket):
7874 Remove unused variable `no_events'.
7875
7876 * w32term.c (x_draw_composite_glyph_string_foreground):
7877 Remove unused variable `width'.
7878
1149507c
JB
78792011-03-24 Juanma Barranquero <lekktu@gmail.com>
7880
7881 * w32term.c (x_set_glyph_string_clipping):
7882 Don't pass uninitialized region to CombineRgn.
7883
9c88f339
JB
78842011-03-23 Juanma Barranquero <lekktu@gmail.com>
7885
7886 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7887 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7888 (Fx_close_connection): Remove unused variable `i'.
7889
7890 * w32font.c (w32font_draw): Return number of glyphs.
7891 (w32font_open_internal): Remove unused variable `i'.
7892 (w32font_driver): Add missing initializer.
7893
7894 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7895 (fill_in_menu): Remove unused variable `items_added'.
7896
7897 * w32term.c (last_mouse_press_frame): Remove static global variable.
7898 (w32_clip_to_row): Remove unused variable `f'.
7899 (x_delete_terminal): Remove unused variable `i'.
7900
7901 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7902 (NOTHING): Remove unused static global variable.
7903 (uniscribe_check_otf): Remove unused variable `table'.
7904 (uniscribe_font_driver): Add missing initializers.
7905
dee091a3
JD
79062011-03-23 Julien Danjou <julien@danjou.info>
7907
7908 * term.c (Fsuspend_tty, Fresume_tty):
7909 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7910 * window.c (temp_output_buffer_show):
7911 * insdel.c (signal_before_change):
7912 * frame.c (Fhandle_switch_frame):
7913 * fileio.c (Fdo_auto_save):
7914 * emacs.c (Fkill_emacs):
7915 * editfns.c (save_excursion_restore):
7916 * cmds.c (internal_self_insert):
7917 * callint.c (Fcall_interactively):
7918 * buffer.c (Fkill_all_local_variables):
7919 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7920 Use Frun_hooks.
0f4a96b5 7921 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7922 unconditionally since it does the check itself.
dee091a3 7923
2c520ab5 79242011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7925
c9c49752
PE
7926 Fix more problems found by GCC 4.5.2's static checks.
7927
8abc3f12
PE
7928 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7929 the first time through the loop, since we know p0 < p1 then.
7930 This also avoids a gcc -Wstrict-overflow warning.
7931
a2d26660
PE
7932 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7933 leading to a memory leak, possible in functions like
7934 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7935 of objects (Bug#8318).
a2d26660 7936
916c72e9
PE
7937 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7938 that could (at least in theory) be that large.
7939
19ab8a18
PE
7940 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7941 This is less likely to overflow, and avoids undefined behavior if
7942 overflow does occur. All callers changed. Use strtoul to scan
7943 for the unsigned long integer.
b7cbbd6f
PE
7944 (pint2hrstr): Simplify and tune code slightly.
7945 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7946
f0641eff
PE
7947 * scroll.c (do_scrolling): Work around GCC bug 48228.
7948 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7949
7f650bb9
PE
7950 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7951 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7952 (validate_x_resource_name): Simplify count usage.
7953 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7954
37dd57d1
PE
7955 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7956 fail (Bug#8306).
81e56e61 7957
699979fc 7958 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7959
401bf9b4
PE
7960 * process.c (Fmake_network_process): Use socklen_t, not int,
7961 where POSIX says socklen_t is required in portable programs.
7962 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7963 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7964 (Fmake_network_process, server_accept_connection):
7965 (wait_reading_process_output, read_process_output):
7966 Likewise.
7967
b93aacde
PE
7968 * process.c: Rename or move locals to avoid shadowing.
7969 (list_processes_1, Fmake_network_process):
7970 (read_process_output_error_handler, exec_sentinel_error_handler):
7971 Rename or move locals.
4dc343ee 7972 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7973 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7974 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7975 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7976 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7977
af8a867c 7978 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7979 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7980 Include tparam.h instead, since it declares them.
af8a867c
PE
7981 * cm.h (PC): Remove extern decl; tparam.h now does this.
7982 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7983 * terminfo.c: Include tparam.h, to check interfaces.
7984 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7985 (tparam): Adjust signature to match interface in tparam.h;
7986 this removes some undefined behavior. Check that outstring and len
7987 are zero, which they always are with Emacs.
7988 * tparam.h (PC, BC, UP): New extern decls.
7989
0248044d 7990 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7991 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7992
8ff096c1 7993 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7994 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7995 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7996 (ftfont_list): Remove unused local.
49eaafba
PE
7997 (get_adstyle_property, ftfont_pattern_entity):
7998 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7999 Rename locals to avoid shadowing.
8ff096c1 8000
e2be39f6
PE
8001 * xfont.c (xfont_list_family): Mark var as initialized.
8002
c9735e30
PE
8003 * xml.c (make_dom): Now static.
8004
8f5201ae
PE
8005 * composite.c (composition_compute_stop_pos): Rename local to
8006 avoid shadowing.
b246f932
PE
8007 (composition_reseat_it): Remove unused locals.
8008 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8009 (composition_update_it): Mark var as initialized.
11b61122
PE
8010 (find_automatic_composition): Mark vars as initialized,
8011 with a FIXME (Bug#8290).
8f5201ae 8012
760fbc2c
PE
8013 character.h: Rename locals to avoid shadowing.
8014 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8015 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8016 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8017 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8018 to avoid shadowing.
8019
ff08eb85
PE
8020 * textprop.c (property_change_between_p): Remove; unused.
8021
fc7bf025
PE
8022 * intervals.c (interval_start_pos): Now static.
8023
235d7abc
PE
8024 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8025
44f230aa
SM
8026 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8027 Rename locals to avoid shadowing.
3e7d6594 8028
50060332
PE
8029 * sound.c (wav_play, au_play, Fplay_sound_internal):
8030 Fix pointer signedness.
d01f234b 8031 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8032 (wav_play): Initialize a variable to 0, to prevent undefined
8033 behavior (Bug#8278).
50060332 8034
c4fc4e30
PE
8035 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8036
918436ed
PE
8037 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8038
c939f91b
PE
8039 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8040 clobbering (Bug#8298).
b9c7f648
PE
8041 * sysdep.c (sys_subshell): Likewise.
8042 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8043
6bd8c144
PE
8044 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8045 This should get cleaned up, so that child_setup has the
8046 same signature on all platforms.
8047
7710357c 8048 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8049 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8050
c59da222
CY
80512011-03-22 Chong Yidong <cyd@stupidchicken.com>
8052
8053 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8054 not to be necessary, and produces flickering.
8055
66b87493
GM
80562011-03-20 Glenn Morris <rgm@gnu.org>
8057
8058 * config.in: Remove file.
8059
45b6f6d5
JB
80602011-03-20 Juanma Barranquero <lekktu@gmail.com>
8061
8062 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8063 are now in src/globals.h.
8064 (syms_of_minibuf): Remove spurious & from previous change.
8065
3ec03f7e
LL
80662011-03-20 Leo <sdl.web@gmail.com>
8067
8068 * minibuf.c (completing-read-function): New variable.
8069 (completing-read-default): Rename from completing-read.
8070 (completing-read): Call completing-read-function.
8071
b14e3e21
CY
80722011-03-19 Juanma Barranquero <lekktu@gmail.com>
8073
8074 * xfaces.c (Fx_load_color_file):
8075 Read color file from absolute filename (bug#8250).
8076
f2b726e6
JB
80772011-03-19 Juanma Barranquero <lekktu@gmail.com>
8078
8079 * makefile.w32-in: Update dependencies.
8080
09f6ff02
EZ
80812011-03-17 Eli Zaretskii <eliz@gnu.org>
8082
8083 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8084
29a6015a
PE
80852011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8086
a3a6c54e
PE
8087 Fix more problems found by GCC 4.5.2's static checks.
8088
b766f867
PE
8089 * process.c (make_serial_process_unwind, send_process_trap):
8090 (sigchld_handler): Now static.
8091
be02381c
PE
8092 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8093 That way, the code declares only the vars that it needs.
8094 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8095 * s/cygwin.h (PTY_ITERATION): Likewise.
8096 * s/darwin.h (PTY_ITERATION): Likewise.
8097 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8098
57048744
PE
8099 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8100 * process.c (allocate_pty): Don't declare stb unless it's needed.
8101
7914961c 8102 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8103 (CONSTANTLIM): Remove; unused.
8104 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8105 Define only if needed.
7914961c 8106
b3967b18
PE
8107 * unexelf.c (unexec): Name an expression,
8108 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8109 Use a different way to cause a compilation error if anyone uses
8110 n rather than nn, a way that does not involve shadowing.
73366a00 8111 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8112
29a6015a
PE
8113 * deps.mk (unexalpha.o): Remove; unused.
8114
43cfc33e 8115 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8116 * unexec.h: New file.
ce701a33
PE
8117 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8118 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8119 Depend on unexec.h.
8120 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8121 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8122 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8123 Change as necessary to match prototype in unexec.h.
ce701a33 8124
01f44d5a
PE
8125 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8126 shadowing.
4f63c6bb 8127 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8128
a6670b0b
PE
8129 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8130 Rename locals to avoid shadowing.
8131
cef2010d 8132 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8133 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8134
d4d7173a
PE
8135 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8136
f08b802a
PE
8137 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8138 warning when compiling print.c.
8139
3ddb0639
PE
8140 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8141 instead of using an uninitialized var.
5ad03b97 8142 (font_sort_entities): Mark var as initialized.
3ddb0639 8143
170a2692
PE
8144 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8145
e663c700
PE
8146 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8147 pointers to constants.
89bc529a 8148 (font_parse_fcname): Remove unused vars.
7b81e2d0 8149 (font_delete_unmatched): Now static.
ea838e10 8150 (font_get_spec): Remove; unused.
13a547c6
PE
8151 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8152 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8153 Rename or move locals to avoid shadowing.
e663c700 8154
2a80c887 8155 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8156 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8157
1384fa33 8158 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8159 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8160
8b2c52e9
PE
8161 * alloc.c (mark_backtrace): Move decl from here ...
8162 * lisp.h: ... to here, so that it can be checked.
8163
475545b5 8164 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8165 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8166 (lisp_indirect_variable): Name an expression,
8167 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8168 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8169
b1349114 8170 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8171 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8172 Use const pointer when appropriate.
b1349114 8173
a2928364
PE
8174 * lisp.h (get_system_name, get_operating_system_release):
8175 Move decls here, to check interfaces.
8176 * process.c (get_operating_system_release): Move decl to lisp.h.
8177 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8178 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8179 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8180 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8181 (Fformat_time_string, Fencode_time, Finsert_char):
8182 (Ftranslate_region_internal, Fformat):
8183 Rename or remove local vars to avoid shadowing.
9710023e 8184 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8185
a415e694
PE
8186 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8187 avoid shadowing.
8188
8ef4622d
PE
8189 * lisp.h (eassert): Check that the argument compiles, even if
8190 ENABLE_CHECKING is not defined.
8191
946f9a5b
PE
8192 * data.c (Findirect_variable): Name an expression, to avoid
8193 gcc -Wbad-function-cast warning.
112396d6 8194 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8195 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8196 (Fmake_variable_buffer_local, Fmake_local_variable):
8197 Mark variables as initialized.
52746918 8198 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8199
e5aab7e7 8200 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8201 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8202 Rename locals to avoid shadowing.
dff45157
PE
8203 (mark_stack): Move local variables into the #ifdef region where
8204 they're used.
7bc26fdb
PE
8205 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8206 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8207 needed otherwise.
8208 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8209 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8210 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8211
e5aab7e7
PE
8212 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8213 avoids undefined behavior in theory.
8214
4da60324
PE
8215 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8216
88043301
PE
8217 Use functions, not macros, for up- and down-casing (Bug#8254).
8218 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8219 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8220 to use the following functions instead of these macros.
8221 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8222 EMACS_INT, since callers assume the returned value fits in int.
8223 (upcase1): Likewise, for UPCASE_TABLE.
8224 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8225 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8226 the race-condition problem in the old DOWNCASE.
88043301 8227
19ed5445
PE
8228 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8229 Rename locals to avoid shadowing.
8230 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8231 (regex_compile, re_search_2, re_match_2_internal):
8232 Remove unused local vars.
952db0d7
PE
8233 (FREE_VAR): Rewrite so as not to use empty "else",
8234 which gcc can warn about.
da053e48 8235 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8236 (RETALLOC_IF): Define only if needed.
8237 (WORDCHAR_P): Likewise. This one is never needed, but is used
8238 only in a comment talking about a compiler bug, so put inside
8239 the #if 0 of that comment.
8240 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8241 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8242 Remove; unused.
19ed5445 8243
1f3561e4 8244 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8245 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8246 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8247
ded6f8f7
PE
8248 * search.c (simple_search): Remove unused var.
8249
dbd37a95
PE
8250 * dired.c (compile_pattern): Move decl from here ...
8251 * lisp.h: ... to here, so that it can be checked.
8252 (struct re_registers): New forward decl.
8253
7e47afad
PE
8254 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8255
85f24f61
PE
8256 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8257 All uses changed.
8258 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8259 Rename locals to avoid shadowing.
5671df8f 8260 (Fvertical_motion): Mark locals as initialized.
85f24f61 8261
181aa2be 8262 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8263 (casify_region): Mark local as initialized.
181aa2be 8264
930d429c
PE
8265 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8266
7082eac6
PE
8267 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8268 New macros, so that the caller can use some names other than
8269 gcpro1, gcpro2, etc.
8270 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8271 of the new macros.
8272 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8273 argument, for consistency with GCPRO2_VAR, etc: it is now the
8274 prefix of the variable, not the variable itself. All uses
8275 changed.
38b2c076
PE
8276 * dired.c (directory_files_internal, file_name_completion):
8277 Rename locals to avoid shadowing.
8278
15206ed9
PE
8279 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8280 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8281 dired.c's scmp function, had undefined behavior.
8282 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8283 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8284 * buffer.h: ... to here, because these macros use current_buffer,
8285 and the new implementation with inline functions needs to have
8286 current_buffer in scope now, rather than later when the macros
8287 are used.
8288 (downcase, upcase1): New static inline functions.
8289 (DOWNCASE, UPCASE1): Reimplement using these functions.
8290 This avoids undefined behavior in expressions like
8291 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8292 from race conditions in accessing the global variables
8293 case_temp1 and case_temp2.
8294 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8295 * lisp.h (case_temp1, case_temp2): Remove their decls.
8296 * character.h (ASCII_CHAR_P): Move from here ...
8297 * lisp.h: ... to here, so that the inline functions mentioned
8298 above can use them.
8299
4a6bea26
PE
8300 * dired.c (directory_files_internal_unwind): Now static.
8301
f14b7e14
PE
8302 * fileio.c (file_name_as_directory, directory_file_name):
8303 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8304 Now static.
2893f146
PE
8305 (file_name_as_directory): Use const pointers when appropriate.
8306 (Fexpand_file_name): Likewise. In particular, newdir might
8307 point at constant storage, so make it a const pointer.
fd4ead52 8308 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8309 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8310 signedness issues.
f839df0c
PE
8311 (Fset_file_times, Finsert_file_contents, auto_save_error):
8312 Rename locals to avoid shadowing.
f14b7e14 8313
5716756e 8314 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8315 (Ftry_completion, Fall_completions): Rename or remove locals
8316 to avoid shadowing.
5716756e 8317
b4c3046a
PE
8318 * marker.c (bytepos_to_charpos): Remove; unused.
8319
b45db522
PE
8320 * lisp.h (verify_bytepos, count_markers): New decls,
8321 so that gcc does not warn that these functions aren't declared.
8322
85876d07
PE
8323 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8324 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8325 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8326 (copy_text): Remove unused local var.
85876d07 8327
03d78a21 8328 * filelock.c (within_one_second): Now static.
b3dd38ab 8329 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8330
5df8f01b
PE
8331 * buffer.c (fix_overlays_before): Mark locals as initialized.
8332 (fix_start_end_in_overlays): Likewise. This function should be
8333 simplified by using pointers-to-pointers, but that's a different
8334 matter.
b1d876f1 8335 (switch_to_buffer_1): Now static.
8f54f30a
PE
8336 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8337 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8338
a70072c9 8339 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8340 Fix pointer signedness issue.
edced198
PE
8341 (sys_subshell): Mark local as volatile if checking for lint,
8342 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8343 (MAXPATHLEN): Define only if needed.
a70072c9 8344
a0977c44
PE
8345 * process.c (serial_open, serial_configure): Move decls from here ...
8346 * systty.h: ... to here, so that they can be checked.
8347
a884fdcc
PE
8348 * fns.c (get_random, seed_random): Move extern decls from here ...
8349 * lisp.h: ... to here, so that they can be checked.
8350
604efe86 8351 * sysdep.c (reset_io): Now static.
b8950c94 8352 (wait_for_termination_signal): Remove; unused.
604efe86 8353
38fc62d9
PE
8354 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8355 (copy_keymap_item, append_key, push_text_char_description):
8356 Now static.
1004a21a 8357 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8358 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8359 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8360 (describe_map_tree):
8361 Rename locals to avoid shadowing.
38fc62d9 8362
2f2650da
PE
8363 * keyboard.c: Declare functions static if they are not used elsewhere.
8364 (echo_char, echo_dash, cmd_error, top_level_2):
8365 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8366 (read_char, kbd_buffer_get_event, make_lispy_position):
8367 (make_lispy_event, make_lispy_movement, apply_modifiers):
8368 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8369 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8370 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8371 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8372 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8373
a053e86c 8374 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8375 (mark_kboards): Move decl here ...
8376 * alloc.c (mark_kboards): ... from here.
a053e86c 8377
4752793e
PE
8378 * lisp.h (force_auto_save_soon): New decl.
8379
74f10ca7 8380 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8381 (DEFINE_DUMMY_FUNCTION): New macro.
8382 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8383 Use it.
c03cd23f
PE
8384 (main): Add casts to avoid warnings
8385 if GCC considers string literals to be constants.
74f10ca7 8386
022e70d4
PE
8387 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8388
59d6fe83
PE
8389 * dbusbind.c: Pointer signedness fixes.
8390 (xd_signature, xd_append_arg, xd_initialize):
8391 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8392 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8393 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8394 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8395
78320123
PE
8396 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8397 if GCC considers string literals to be constants.
49cebcca 8398 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8399
35ac2a97
SM
84002011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8401
fb103ca9
SM
8402 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8403 (print_preprocess, print_object): New macro to fix last change.
8404
35ac2a97
SM
8405 * print.c (print_preprocess): Don't forget font objects.
8406
62973b41
JB
84072011-03-16 Juanma Barranquero <lekktu@gmail.com>
8408
8409 * emacs.c (USAGE3): Doc fixes.
8410
0e48bb22
AS
84112011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8412
8413 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8414 structure.
8415
7684e57b
JB
84162011-03-14 Juanma Barranquero <lekktu@gmail.com>
8417
8418 * lisp.h (VWindow_system, Qfile_name_history):
8419 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8420 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8421 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8422
8423 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8424 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8425
8426 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8427 * w32console.c (detect_input_pending, read_input_pending)
8428 (encode_terminal_code):
8429 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8430 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8431 (w32_system_caret_y, Qfile_name_history):
8432 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8433 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8434 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8435 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8436 * w32proc.c (Qlocal, report_file_error):
8437 * w32term.c (Vwindow_system, updating_frame):
8438 * w32uniscribe.c (initialized, uniscribe_font_driver):
8439 Remove unneeded extern declarations.
8440
2aa46d6c
CY
84412011-03-14 Chong Yidong <cyd@stupidchicken.com>
8442
c96bbc66 8443 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8444
cffc6f3b
CY
84452011-03-13 Chong Yidong <cyd@stupidchicken.com>
8446
8447 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8448 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8449 These macros can no longer be used for assignment.
8450
44f230aa
SM
8451 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8452 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8453 (record_buffer_markers, fetch_buffer_markers): New functions for
8454 recording and fetching special buffer markers.
8455 (set_buffer_internal_1, set_buffer_temp): Use them.
8456
8457 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8458
8459 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8460
8461 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8462 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8463
8464 * xdisp.c (hscroll_window_tree):
8465 (reconsider_clip_changes): Use PT instead of BUF_PT.
8466
d251f04b
EZ
84672011-03-13 Eli Zaretskii <eliz@gnu.org>
8468
8469 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8470 $(EMACS_ROOT)/lib/intprops.h.
8471
f0c77cd1
PE
84722011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8473
3eca4629
PE
8474 Fix more problems found by GCC 4.5.2's static checks.
8475
7c86ee98
PE
8476 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8477 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8478 (xg_free_frame_widgets): Make it clear that a local variable is
8479 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8480 (gdk_window_get_screen): Make it clear that this macro is needed
8481 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8482 (int_gtk_range_get_value): New function, which avoids a diagnostic
8483 from gcc -Wbad-function-cast.
8484 (xg_set_toolkit_scroll_bar_thumb): Use it.
8485 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8486 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8487 (get_utf8_string, xg_get_file_with_chooser):
8488 Rename locals to avoid shadowing.
8489 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8490
41729b81
PE
8491 * xgselect.c (xg_select): Remove unused var.
8492
f0c77cd1
PE
8493 * image.c (four_corners_best): Mark locals as initialized.
8494 (gif_load): Initialize transparent_p to zero (Bug#8238).
8495 Mark another local as initialized.
ec6cf4c6 8496 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8497
ce0ad53d 8498 * image.c (clear_image_cache): Now static.
d5d5a617 8499 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8500 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8501 (x_edge_detection): Remove unnecessary cast that
8502 gcc -Wbad-function-cast diagnoses.
2037898d 8503 (gif_load): Fix pointer signedness.
6ae141d6
PE
8504 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8505 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8506
33383987 85072011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8508
d32df629
PE
8509 Improve quality of tests for time stamp overflow.
8510 For example, without this patch (encode-time 0 0 0 1 1
8511 1152921504606846976) returns the obviously-bogus value (-948597
8512 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8513 reports time overflow. See
8514 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8515 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8516 * editfns.c: Include limits.h and intprops.h.
8517 (TIME_T_MIN, TIME_T_MAX): New macros.
8518 (time_overflow): Move earlier, to before first use.
8519 (hi_time, lo_time): New functions, for an accurate test for
8520 out-of-range times.
8521 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8522 (Fget_internal_run_time): Don't assume time_t fits in int.
8523 (make_time): Use list2 instead of Fcons twice.
8524 (Fdecode_time): More accurate test for out-of-range times.
8525 (check_tm_member): New function.
8526 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8527 (lisp_time_argument): Don't rely on undefined left-shift and
8528 right-shift behavior when checking for time stamp overflow.
8be6f318 8529
fe31d94c
PE
8530 * editfns.c (time_overflow): New function, refactoring common code.
8531 (Fformat_time_string, Fdecode_time, Fencode_time):
8532 (Fcurrent_time_string): Use it.
8533
8be6f318
PE
8534 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8535 * dired.c (make_time): Move to ...
8536 * editfns.c (make_time): ... here.
8537 * systime.h: Note the move.
8538
09d9db2c 85392011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8540
126bc0dc
YM
8541 * fringe.c (update_window_fringes): Remove unused variables.
8542
c47cbdfd
YM
8543 * unexmacosx.c (copy_data_segment): Also copy __got section.
8544 (Bug#8223)
8545
7ac80be9
EZ
85462011-03-12 Eli Zaretskii <eliz@gnu.org>
8547
c96bbc66 8548 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8549 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8550 Constify `char *' arguments and their references according to
8551 prototypes in tparam.h.
8552
ecb0f94d 8553 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8554
7ac80be9
EZ
8555 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8556 Adapt all references accordingly.
8557
8558 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8559
ef1fd07e
TT
85602011-03-11 Tom Tromey <tromey@redhat.com>
8561
8562 * buffer.c (syms_of_buffer): Remove obsolete comment.
8563
7ef4b50c
EZ
85642011-03-11 Eli Zaretskii <eliz@gnu.org>
8565
8566 * termhooks.h (encode_terminal_code): Declare prototype.
8567
8568 * msdos.c (encode_terminal_code): Don't declare prototype.
8569
8570 * term.c (encode_terminal_code): Now external again, used by
8571 w32console.c and msdos.c.
8572
44f230aa
SM
8573 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8574 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8575
4b1ec863 85762011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8577
1714f52b 8578 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8579
4b1ec863
PE
8580 * fringe.c (update_window_fringes): Mark locals as initialized
8581 (Bug#8227).
8582 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8583
524c7aa6
PE
8584 * alloc.c (mark_fringe_data): Move decl from here ...
8585 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8586 to check its interface.
8587 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8588
a5c0af81 8589 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8590 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8591 (fontset_font): Mark local as initialized.
a9a06e0b 8592 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8593
b4716021
PE
8594 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8595
811e9bac 8596 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8597 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8598 (x_own_selection, Fx_disown_selection_internal): Rename locals
8599 to avoid shadowing.
8600 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8601
7e3ab302
PE
8602 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8603 so that the caller can use some name other than gcpro1.
8604 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8605 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8606 (Fx_backspace_delete_keys_p):
8607 Use them to avoid shadowing, and rename vars to avoid shadowing.
8608 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8609 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8610 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8611 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8612 Remove unused locals.
7e3ab302
PE
8613 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8614 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8615 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8616 macros.
f78faa98 8617
e2b13473
PE
8618 * xterm.h (x_mouse_leave): New decl.
8619
77f23912
PE
8620 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8621 Remove unused functions.
cdf4ba58
PE
8622 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8623 (x_calc_absolute_position): Now static.
7411c686 8624 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8625 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8626 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8627 unless they are used.
38d0b34a
PE
8628 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8629 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8630 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8631 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8632 (x_error_catcher, x_connection_closed, x_error_handler):
8633 (x_error_quitter, xembed_send_message, x_iconify_frame):
8634 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8635 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8636 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8637
44f230aa
SM
8638 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8639 Rename or move locals to avoid shadowing.
6b463e58 8640 (tty_defined_color, merge_face_heights): Now static.
5967d051 8641 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8642 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8643 does not deduce is never used uninitialized.
73719eba
PE
8644 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8645 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8646
426994c3 8647 * terminal.c (store_terminal_param): Now static.
5489860b 8648
032f1620 8649 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8650 (set_frame_menubar): Remove unused local.
d4323972 8651 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8652 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8653 since they might point to immutable storage.
281585b0
PE
8654 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8655 since it's unused otherwise.
032f1620 8656
367c19e5 8657 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8658 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8659 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8660 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8661 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8662 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8663 does not deduce are never used uninitialized.
70739cbe 8664
07b48fa9
PE
8665 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8666
8868a238 8667 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8668 * window.c (window_loop, size_window):
8669 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8670
7e5cf297 8671 * window.c (display_buffer): Now static.
d6550a9f
PE
8672 (size_window): Mark variables that gcc -Wuninitialized
8673 does not deduce are never used uninitialized.
a586633d
PE
8674 * window.h (check_all_windows): New decl, to forestall
8675 gcc -Wmissing-prototypes diagnostic.
5b555da1 8676 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8677
f6095868
PE
8678 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8679 shadowing.
8680 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8681 Include <limits.h>.
8682 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8683 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8684 (load_charset_map): Mark variables that gcc -Wuninitialized
8685 does not deduce are never used uninitialized.
53df7c11 8686 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8687
f38b440c
PE
8688 * coding.c (coding_set_source, coding_set_destination):
8689 Use "else { /* comment */ }" rather than "else /* comment */;"
8690 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8691 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8692 a block, when the outer 'i' will do.
8693 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8694 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8695 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8696 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8697 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8698 Rename locals to avoid shadowing.
8699 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8700 * coding.c (emacs_mule_char, encode_invocation_designation):
8701 Now static, since they're not used elsewhere.
413bb2db 8702 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8703 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8704 (decode_coding_emacs_mule): Mark variables that gcc
8705 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8706 (detect_coding_iso_2022): Initialize a local variable that might
8707 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8708 this initialization is needed. (Bug#8211)
5f58e762
PE
8709 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8710 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8711 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8712 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8713 Remove unused macros.
f38b440c 8714
232b38b9 8715 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8716 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8717 * character.c (string_count_byte8): Likewise.
232b38b9 8718
fb90da1b
PE
8719 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8720 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8721
fb93dbc2
PE
8722 * chartab.c (copy_sub_char_table): Now static, since it's not used
8723 elsewhere.
5c156ace
PE
8724 (sub_char_table_ref_and_range, char_table_ref_and_range):
8725 Rename locals to avoid shadowing.
bbcd0949 8726 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8727
7d3b3862 8728 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8729 (BIDI_BOB): Remove unused macro.
7d3b3862 8730
6be7d3da
PE
8731 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8732 deduce are never used uninitialized.
c2ed9c8b 8733 * term.c (encode_terminal_code): Likewise.
6be7d3da 8734
75f8807f 8735 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8736
50938595
PE
8737 * tparam.h: New file.
8738 * term.c, tparam.h: Include it.
8739 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8740 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8741 Move these decls to tparam.h, and make them agree with what
8742 is actually in tparam.c. The previous trick of using incompatible
8743 decls in different modules does not conform to the C standard.
8744 All callers of tparam changed to use tparam's actual API.
8745 * tparam.c (tparam1, tparam, tgoto):
8746 Use const pointers where appropriate.
8747
fbceeba2
PE
8748 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8749 * cm.h (struct cm): Likewise.
8750 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8751 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8752 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8753 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8754 (turn_on_face, init_tty): Likewise.
8755 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8756
7f3f1250
PE
8757 * term.c (term_mouse_position): Rename local to avoid shadowing.
8758
e6ca6543
PE
8759 * alloc.c (mark_ttys): Move decl from here ...
8760 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8761
c40f8d15
AS
87622011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8763
8764 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8765
cfe0661d
JB
87662011-03-09 Juanma Barranquero <lekktu@gmail.com>
8767
8768 * search.c (compile_pattern_1): Remove argument regp, unused since
8769 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8770 (compile_pattern): Don't pass it.
8771
0afb4571
J
87722011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8773
8774 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8775 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8776 for ! HAVE_GTK3.
8777 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8778
8779 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8780
8781 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8782 gdk_window_get_screen, gdk_window_get_geometry,
8783 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8784 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8785 (xg_get_pixbuf_from_pixmap): New function.
8786 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8787 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8788 Call xg_get_pixbuf_from_pixmap instead of
8789 gdk_pixbuf_get_from_drawable.
8790 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8791 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8792 (xg_check_special_colors): Use GtkStyleContext and its functions
8793 for HAVE_GTK3.
8794 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8795 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8796 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8797 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8798 Call gtk_widget_get_preferred_size.
0afb4571
J
8799 (xg_frame_resized): gdk_window_get_geometry only takes 5
8800 parameters.
44f230aa
SM
8801 (xg_win_to_widget, xg_event_is_for_menubar):
8802 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8803 (xg_set_widget_bg): New function.
8804 (delete_cb): New function.
895009e1 8805 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8806 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8807 (xg_set_background_color): Call xg_set_widget_bg.
8808 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8809 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8810 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8811 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8812 if ! HAVE_GTK3.
8813 (update_frame_tool_bar): Call gtk_widget_hide.
8814 (xg_initialize): Use GDK_KEY_g.
8815
8816 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8817 if ! HAVE_GTK3
8818 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8819
8820 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8821 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8822 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8823
1c2cc4ef
JB
88242011-03-08 Juanma Barranquero <lekktu@gmail.com>
8825
8826 * w32xfns.c (select_palette): Check success of RealizePalette against
8827 GDI_ERROR, not zero.
8828
33383987 8829See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8830
8831;; Local Variables:
8832;; coding: utf-8
aac0c6e3
MR
8833;; End:
8834
33383987 8835 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8836
8837 This file is part of GNU Emacs.
8838
8839 GNU Emacs is free software: you can redistribute it and/or modify
8840 it under the terms of the GNU General Public License as published by
8841 the Free Software Foundation, either version 3 of the License, or
8842 (at your option) any later version.
8843
8844 GNU Emacs is distributed in the hope that it will be useful,
8845 but WITHOUT ANY WARRANTY; without even the implied warranty of
8846 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8847 GNU General Public License for more details.
8848
8849 You should have received a copy of the GNU General Public License
8850 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.