apropos.el doc fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
97f18cc8
JD
12011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2
3 * xfns.c (unwind_create_frame):
4 * nsfns.m (unwind_create_frame):
5 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6 Vframe_list (Bug#9999).
7
22a648b4
DA
82011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
9
10 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
11
659afede
KH
122011-11-11 Kenichi Handa <handa@m17n.org>
13
14 * callproc.c (Fcall_process): Set the member dst_multibyte of
15 process_coding.
16
9ac0394b
KH
172011-11-11 Johan Bockgård <bojohan@gnu.org>
18
19 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
20 avoid a crash (bug#9496).
21
2fbdc249
CY
222011-11-09 Chong Yidong <cyd@gnu.org>
23
24 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
25 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
26
ac6b1f81
PE
272011-11-08 Paul Eggert <eggert@cs.ucla.edu>
28
29 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
30
09db192c
PE
312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
32
33 Avoid some portability problems by eschewing 'extern inline' functions.
34 The trivial performance wins aren't worth the portability hassles; see
35 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
36 et seq.
37 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
38 (window_box_width, window_box_left, window_box_left_offset)
39 (window_box_right, window_box_right_offset): Undo previous change,
40 by removing the "extern"s.
41 * intervals.c (adjust_intervals_for_insertion)
42 (adjust_intervals_for_deletion): Undo previous change,
43 making these static again.
44 (offset_intervals, temp_set_point_both, temp_set_point)
45 (copy_intervals_to_string): No longer inline.
46 * xdisp.c (window_text_bottom_y, window_box_width)
47 (window_box_height, window_box_left_offset)
48 (window_box_right_offset, window_box_left, window_box_right)
49 (window_box): No longer inline.
50
105216ed
CY
512011-11-08 Chong Yidong <cyd@gnu.org>
52
53 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
54 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
55 an error if not a live window.
56 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
57 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
58
ae9e237f
JB
592011-11-07 Juanma Barranquero <lekktu@gmail.com>
60
61 * lisp.h (syms_of_abbrev): Remove declaration.
62 Reported by CHENG Gao <chenggao@royau.me>.
63
c7aa8333
EZ
642011-11-07 Eli Zaretskii <eliz@gnu.org>
65
66 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
67 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
68 of temacs in GUI mode.
69
be7f5545
MR
702011-11-07 Martin Rudalics <rudalics@gmx.at>
71
72 * window.h: Declare delete_all_child_windows instead of
73 delete_all_subwindows.
74 * window.c (Fwindow_nest, Fset_window_nest)
75 (Fset_window_new_total, Fset_window_new_normal)
76 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
77 (delete_all_subwindows): Rename to delete_all_child_windows.
78 (Fdelete_other_windows_internal, Fset_window_configuration):
79 Call delete_all_child_windows instead of delete_all_subwindows.
80 * frame.c (delete_frame): Call delete_all_child_windows instead
81 of delete_all_subwindows.
82
ca78dc43
PE
832011-11-07 Paul Eggert <eggert@cs.ucla.edu>
84
85 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
86 This is also needed for porting to any host where GC_MARK_STACK is
87 not GC_MAKE_GCPROS_NOOPS.
88 (which_symbols): Use it.
89
a0241d01
KH
902011-11-07 Kenichi Handa <handa@m17n.org>
91
92 * coding.c (coding_set_destination): Check coding->src_pos only
93 when coding->src_object is a buffer (bug#9910).
94
95 * process.c (send_process): Set the member src_multibyte of coding
96 to 0 (bug#9911) when sending a unibyte text.
97
98 * callproc.c (Fcall_process): Set the member src_multibyte of
99 process_coding to 0 (bug#9912).
100
a64bfdfa 1012011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
102
103 * xmenu.c (cleanup_widget_value_tree): New function.
104 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
105 calling free_menubar_widget_value_tree directly (Bug#9830).
106
cb41b32a
PE
1072011-11-06 Paul Eggert <eggert@cs.ucla.edu>
108
109 Fix some portability problems with 'inline'.
110 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
111 (window_box_width, window_box_left, window_box_left_offset)
112 (window_box_right, window_box_right_offset): Declare extern.
113 Otherwise, these inline functions do not conform to C99 and
114 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
115 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
116 * intervals.c (adjust_intervals_for_insertion)
117 (adjust_intervals_for_deletion): Now extern, because otherwise the
118 extern inline functions 'offset_intervals' couldn't refer to it.
119 (static_offset_intervals): Remove.
120 (offset_intervals): Rewrite using the old contents of
121 static_offset_intervals. The old version didn't conform to C99
122 because an extern inline function contained a reference to an
123 identifier with static linkage.
124
b7041366
AS
1252011-11-06 Andreas Schwab <schwab@linux-m68k.org>
126
127 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
128 GC.
129
88a37c4d
EZ
1302011-11-06 Eli Zaretskii <eliz@gnu.org>
131
132 * xdisp.c (init_iterator, reseat_to_string): Don't set the
133 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
134 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
135 return Qleft_to_right.
136
49745b39
CY
1372011-11-06 Chong Yidong <cyd@gnu.org>
138
139 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
140 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
141 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
142 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
143 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
144 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
145 (Fwindow_vscroll): Doc fix.
146 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
147 argument, since it makes no sense to pass a live window and for
148 consistency with window-child.
149
1f05cd82
CS
1502011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
151
152 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
153 support MSVC.
154
22610910
JR
1552011-11-05 Jason Rumney <jasonr@gnu.org>
156
157 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
158 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
159 fonts (Bug#6029).
160 (add_font_entity_to_list): Fix logic errors in mixed boolean and
161 bitwise arithmetic preventing use of unicode-sip and non-truetype
162 opentype fonts.
163
a06776b2
EZ
1642011-11-05 Eli Zaretskii <eliz@gnu.org>
165
3ad924ba
EZ
166 * s/ms-w32.h (fstat, stat, utime): Move redirections to
167 "emacs"-only part.
168
a06776b2
EZ
169 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
170 initialization code to keep similarity to xfns.c after changes
171 from 2011-11-05.
172
c9e7db78
JD
1732011-11-05 Jan Djärv <jan.h.d@swipnet.se>
174
a97f8f3f
JD
175 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
176 (unwind_create_frame): New function (Bug#9943).
177 (Fx_create_frame): Restructure code to be more similar to the one in
178 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
179 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
180 Move terminal->reference_count++ just before making the frame official
181 (Bug#9943).
182
183 * nsterm.m (x_free_frame_resources): New function.
184 (x_destroy_window): Move code to x_free_frame_resources.
185
c9e7db78
JD
186 * xfns.c (unwind_create_frame): Fix comment.
187 (Fx_create_frame, x_create_tip_frame): Move
188 terminal->reference_count++ just before making the frame
189 official. Move initialization of image_cache_refcount and
190 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
191
a6fc3b5c
EZ
1922011-11-05 Eli Zaretskii <eliz@gnu.org>
193
194 Support MSVC build with newer versions of Visual Studio.
195 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
196 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
197 nt/gmake.defs.
198
199 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
200 which are not supported by MSVC.
201 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
202 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
203 bitfields.
204 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
205 types in bitfields.
206 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
207
208 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
209
2102011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
211
212 Support MSVC build with newer versions of Visual Studio.
213 * w32.c: Don't include w32api.h for MSVC.
214 (init_environment) [_MSC_VER]: Call sys_access, not _access.
215
216 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
217 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
218 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
219 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
220 e_* cousins.
221 (alloca) [_MSC_VER]: Define to _alloca.
222
223 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
224
225 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
226
a58c13ed
EZ
2272011-11-04 Eli Zaretskii <eliz@gnu.org>
228
229 * xdisp.c (note_mouse_highlight): If either of
230 previous/next-single-property-change returns nil, treat that as
231 the beginning or the end of the buffer. (Bug#9955)
232
fe0b6370
JD
2332011-11-04 Jan Djärv <jan.h.d@swipnet.se>
234
a58c13ed 235 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
236 label is not null (Bug#9951).
237 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
238 may be NULL.
239
89bd5ee1
EZ
2402011-11-04 Eli Zaretskii <eliz@gnu.org>
241
242 * window.c (Fwindow_body_size): Mention in the doc string that the
243 return value is in frame's canonical units. (Bug#9949)
244
84c3edb9
EZ
2452011-11-03 Eli Zaretskii <eliz@gnu.org>
246
4e2fb5c7
EZ
247 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
248
84c3edb9 249 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 250 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 251 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 252
bc17a887
EZ
2532011-11-01 Eli Zaretskii <eliz@gnu.org>
254
255 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
256 Don't stop backward scan on the continuation glyph, even though
257 its CHARPOS is positive.
26b46e51
EZ
258 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
259 cover_string to disp_string.
bc17a887 260
4ee88440
MR
2612011-11-01 Martin Rudalics <rudalics@gmx.at>
262
263 * window.c (temp_output_buffer_show): Don't use
264 Vtemp_buffer_show_specifiers.
265 (Vtemp_buffer_show_specifiers): Remove unused variable.
266
c2ff3c02
EZ
2672011-10-30 Eli Zaretskii <eliz@gnu.org>
268
269 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
270 past the beginning of the current glyph matrix.
271
6e56383b
JD
2722011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
273
274 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
275 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
276 HAVE_GTK3 (Bug#9869).
b77a6a7f 277
3b574623
JD
278 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
279 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
280
b77a6a7f
JD
281 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
282
283 * xterm.c: Declare x_handle_net_wm_state to return int.
284 (handle_one_xevent): Check if we are iconified but don't have
285 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
286 (get_current_wm_state): Return non-zero if not hidden,
287 check for _NET_WM_STATE_HIDDEN (Bug#9893).
288 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
289 (x_handle_net_wm_state): Return what get_current_wm_state returns.
290 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
291
196e41e4
PE
2922011-10-29 Paul Eggert <eggert@cs.ucla.edu>
293
294 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
295 so that this new function doesn't get optimized away by a
296 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
297
021f2e1a
AS
2982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
299
300 * frame.h (MOUSE_HL_INFO): Remove excess parens.
301
8b058d44
EZ
3022011-10-29 Eli Zaretskii <eliz@gnu.org>
303
304 Fix the `xbytecode' command.
305 * .gdbinit (xprintbytestr): New command.
306 (xwhichsymbols): Renamed from `which'; all callers changed.
307 (xbytecode): Print the byte-code string as well.
308
4452fb80
EZ
3092011-10-29 Kim Storm <storm@cua.dk>
310
8b058d44
EZ
311 * alloc.c (which_symbols): New function.
312
21b72067
AS
3132011-10-29 Andreas Schwab <schwab@linux-m68k.org>
314
315 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
316 line. (Bug#9903)
317
83ed7b5c
GM
3182011-10-29 Glenn Morris <rgm@gnu.org>
319
320 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
321 Not clear what it was for, and it causes various bugs. (Bug#9839)
322
5a7a728b
EZ
3232011-10-28 Eli Zaretskii <eliz@gnu.org>
324
325 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
326 possible random value that matches one of those tested as
327 condition to clear the mouse face.
328
d3d0842f
CY
3292011-10-28 Chong Yidong <cyd@gnu.org>
330
331 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
332
31b39d13
DN
3332011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
334
335 * window.c (make_window): Initialize phys_cursor_on_p.
336
9aba6043
SM
3372011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
338
339 * lisp.h (struct Lisp_Symbol): Update comments.
340
c20992f4
JB
3412011-10-28 Juanma Barranquero <lekktu@gmail.com>
342
343 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
344
db4f02f2
EZ
3452011-10-28 Eli Zaretskii <eliz@gnu.org>
346
347 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
348 <oslsachem@gmail.com> for helping to debug this.
349
350 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
351 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
352 (g_b_init_get_glyph_outline_w): New static variables.
353 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
354 (GetGlyphOutlineW_Proc): New typedefs.
355 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
356 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
357 New functions.
358 (w32font_open_internal, compute_metrics):
359 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
360 instead of calling the "wide" APIs directly.
361
362 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
363
364 * w32.h (syms_of_w32font): Add prototype.
365
87e68db4
JB
3662011-10-27 Juanma Barranquero <lekktu@gmail.com>
367
368 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
369 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
370 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
371 (Fmove_to_window_line): Doc fix.
372
435c1d67
CY
3732011-10-27 Chong Yidong <cyd@gnu.org>
374
375 * process.c (make_process): Set gnutls_state to NULL.
376
377 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
378 non-NULL, regardless of GNUTLS_INITSTAGE.
379 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
380 an error. Set process slots as soon as we allocate them.
381
382 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
383
9c6c6f49
CY
3842011-10-27 Chong Yidong <cyd@gnu.org>
385
9aba6043
SM
386 * gnutls.c (emacs_gnutls_deinit): New function.
387 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
388 (Fgnutls_deinit, Fgnutls_boot): Use it.
389
390 * process.c (make_process): Initialize GnuTLS credentials to NULL.
391 (deactivate_process): Call emacs_gnutls_deinit.
392
657d08d3
JB
3932011-10-27 Juanma Barranquero <lekktu@gmail.com>
394
395 * image.c (x_create_x_image_and_pixmap):
396 * w32.c (sys_rename, w32_delayed_load):
397 * w32font.c (fill_in_logfont):
398 * w32reg.c (x_get_string_resource): Silence compiler warnings.
399
5430d399
JB
4002011-10-26 Juanma Barranquero <lekktu@gmail.com>
401
402 * w32fns.c (w32_default_color_map): New function,
403 extracted from Fw32_default_color_map.
a7ef684b 404 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 405
fe0055fa
PE
4062011-10-25 Paul Eggert <eggert@cs.ucla.edu>
407
408 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
409
e6346438
SM
4102011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
411
412 * keyboard.c (test_undefined): New function (bug#9751).
413 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
414
e112cc37
ET
4152011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
416
417 * sysdep.c (init_sys_modes): Fix the check for the controlling
418 terminal (Bug#6649).
419
7b5d6677
EZ
4202011-10-20 Eli Zaretskii <eliz@gnu.org>
421
422 * dispextern.h (struct bidi_it): New member next_en_type.
423
424 * bidi.c (bidi_line_init): Initialize the next_en_type member.
425 (bidi_resolve_explicit_1): When next_en_pos is valid for the
426 current character, check also for next_en_type being WEAK_EN.
427 (bidi_resolve_weak): Don't enter the expensive loop if the current
428 position is before next_en_pos. Record the bidi type of the first
429 non-ET, non-BN character we find, in addition to its position.
430 (bidi_level_of_next_char): Invalidate next_en_type when
431 next_en_pos is over-stepped.
432
7da0b018
PE
4332011-10-20 Paul Eggert <eggert@cs.ucla.edu>
434
435 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
436 * editfns.c: Rewrite current-time-zone so that it invokes
437 the equivalent of (format-time-string "%Z") to get the time zone name.
438 This fixes a bug when the time zone name contains characters that
439 need converting from the system time locale to Emacs internal format.
440 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
441 that patch fixed format-time-string to do the conversion, but
442 I forgot to fix current-time-zone.
443 (format_time_string): New function, containing most of
444 what Fformat_time_string used to contain.
445 (Fformat_time_string): Rewrite in terms of format_time_string.
446 This doesn't change this function's behavior.
447 (current-time-zone): Rewrite to use format_time_string.
448 This fixes the bug reported by Michael Schierl in
449 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
450 Jason Rumney's 2007-06-07 change worked around this bug, but
451 didn't fix it.
452 * systime.h (tzname, timezone): Remove no-longer-used declarations.
453
8547b010
EZ
4542011-10-19 Eli Zaretskii <eliz@gnu.org>
455
456 * xdisp.c (start_display): If the character at POS is displayed
457 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
458 (try_window_reusing_current_matrix): If a line ends in a display
459 vector or the next line starts in a display vector, continue
460 redrawing the window even though the character position of
461 start_row was reached.
8547b010
EZ
462 (Bug#9771, part 2)
463
4e948d15
CY
4642011-10-18 Chong Yidong <cyd@gnu.org>
465
466 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
467 with nobreak-char-display too.
468
4787455f
EZ
4692011-10-18 Eli Zaretskii <eliz@gnu.org>
470
471 Fix part 3 of bug#9771.
472 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
473 (bidi_resolve_neutral): Don't enter the expensive loop looking for
474 non-neutral characters if the current character is a paragraph
475 separator (a.k.a. Newline). This avoids running the same
476 expensive loop twice, once when we consume the preceding newline
477 and the other time when the line actually needs to be displayed.
478 Avoid the loop when we see neutrals on the base embedding level
479 following a character whose directionality is the same as the
480 paragraph's. This avoids running the expensive loop when a line
481 ends in a long sequence of neutrals, like control characters.
482 Add assertion against STRONG_AL type. Slightly rearrange code
483 that determines the type of a neutral given the first non-neutral
484 that follows it.
485 (bidi_level_of_next_char): Set next_en_pos to zero when
486 invalidating its info.
487
2c91f553
EZ
4882011-10-17 Eli Zaretskii <eliz@gnu.org>
489
490 * xdisp.c (push_display_prop): Determine whether to record string
491 or buffer position by IT->string, not by IT->method. Allow
492 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
493 (move_it_vertically_backward): Don't look for character position
494 immediately after the newline when in a continuation line.
495 (Bug#9771, part 1)
2c91f553 496
c7b08b0d
MR
4972011-10-15 Martin Rudalics <rudalics@gmx.at>
498
499 * window.c (coordinates_in_window): Rewrite and delabelize
500 vertical border check. (Bug#5357) (Bug#9618)
501
6b02f655
SM
5022011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
503
504 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
505 errors in XSetWindowBorder (bug#9310).
506
81d40c92
DA
5072011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
508
509 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
510 avoid crash when xmalloc overrun checking is enabled.
511
d4172c3b
EZ
5122011-10-13 Eli Zaretskii <eliz@gnu.org>
513
514 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
515 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
516 cursor motion with <left> and <right> arrow keys.
517
518 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
519 some callers set that themselves.
520
b00eea75
EZ
5212011-10-12 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
524 display string and the previous row comes from the same string and
525 is empty. (Bug#9739) (Bug#9738)
526
8fe012c4
SM
5272011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
528
529 * doc.c (get_doc_string): Encode file name (bug#9735).
530
0074aef2
EZ
5312011-10-12 Eli Zaretskii <eliz@gnu.org>
532
79beb178
EZ
533 * bidi.c (bidi_level_of_next_char):
534 * xdisp.c (get_visually_first_element): Remove old incorrect
535 comments regarding the Unicode Line Separator character.
536
0074aef2
EZ
537 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
538
6e4b3fbe
DA
5392011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
540
541 * alloc.c (Fgc_status): Do not access beyond zombies array
542 boundary if nzombies > MAX_ZOMBIES.
543 * alloc.c (dump_zombies): Add missing format specifier.
544
0324f3af
PE
5452011-10-12 Paul Eggert <eggert@cs.ucla.edu>
546
b5525cac
PE
547 * xdisp.c (set_cursor_from_row): Simplify conditionals,
548 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
549
0324f3af
PE
550 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
551 Some packages use them to denote characters with modifiers.
552
e9b5f888
AS
5532011-10-11 Andreas Schwab <schwab@linux-m68k.org>
554
555 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
556 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
557 matching a pp-number. Rename parameter var to var1.
558
127827c0
SM
5592011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
562
c8fd3bd0
GM
5632011-10-08 Glenn Morris <rgm@gnu.org>
564
565 * callint.c (Fcall_interactively): Give a more explicit error for the
566 'c' case with a non-character input. (Bug#8479)
567
352ec8ff
EZ
5682011-10-08 Eli Zaretskii <eliz@gnu.org>
569
03669ccb
EZ
570 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
571 lines.
7061c986
EZ
572 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
573 lines that are hscrolled on the left.
03669ccb 574
352ec8ff
EZ
575 * dispnew.c (buffer_posn_from_coords): Account for a possible
576 presence of header-line. (Bug#4426)
577
a66cfb1c
SM
5782011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
579
6b02f655
SM
580 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
581 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 582
7c5ee88e
PE
5832011-10-07 Paul Eggert <eggert@cs.ucla.edu>
584
585 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
586 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
587 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
588 this makes Emacs dump core during garbage collection on rare
589 occasions. sizeof is obviously inferior to offsetof here, so
590 stick with offsetof.
591 (GC_POINTER_ALIGNMENT): New macro.
592 (mark_memory): Omit 3rd (offset) arg; caller changed.
593 Don't assume EMACS_INT alignment is the same as pointer alignment.
594
df1bbe5b
SM
5952011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
596
597 * keyboard.c (read_key_sequence_remapped): New var.
598 (read_key_sequence): Compute remapping in the right buffer.
599 (command_loop_1): Use read_key_sequence's remapping directly.
600
51553db6
SM
6012011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
602
32c1fffd
SM
603 * dired.c (file_name_completion): Don't expand file name.
604 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
605 before checking file name handler.
606
51553db6
SM
607 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
608 they've been requested explicitly (bug#9591).
609
b6bd1599 6102011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
611
612 * keymap.c (Fsingle_key_description): Use make_specified_string
613 instead of build_string to build string from push_key_description.
614 (Bug#5193)
615
f701dc2a
PE
6162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
617
4222c55d
PE
618 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
619 This fixes a Y2038 bug on 64-bit hosts.
620 * buffer.c (reset_buffer):
621 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
622 (Fclear_buffer_auto_save_failure):
623 Use 0, not -1, to represent an unset failure time, since time_t
624 might not be signed.
625
f701dc2a
PE
626 Remove dependency on glibc malloc internals.
627 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
628 Move back here from lisp.h, but with their new implementations.
629 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
630 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
631 * charset.c (charset_table_init): New static var.
632 (syms_of_charset): Use it instead of xmalloc. This removes a
633 dependency on glibc malloc internals. See Eli Zaretskii's comment in
634 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
635 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
636 Move back to alloc.c.
637 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
638 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
639
9ceebf39
JD
6402011-09-30 Jan Djärv <jan.h.d@swipnet.se>
641
642 * nsterm.m (windowDidResize): Call x_set_window_size only when
643 ns_in_resize is true. Otherwise set pixelwidth/height and
644 call change_frame_size (Bug#9628).
645
cb993c58
PE
6462011-09-30 Paul Eggert <eggert@cs.ucla.edu>
647
3930c88b
PE
648 Port --enable-checking=all to Fedora 14 x86-64.
649 * charset.c (syms_of_charset): Also account for glibc malloc's
650 internal overhead when calculating the initial malloc maximum.
651
cb993c58
PE
652 Port --enable-checking=all to Fedora 14 x86.
653 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
654 Move to lisp.h.
655 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
656 (overrun_check_realloc, overrun_check_free):
657 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
658 That way, xmalloc returns a properly-aligned pointer even if
659 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
660 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
661 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
662 into account when calculating the initial malloc maximum.
663 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
664 Move here from alloc.c, so that charset.c can use it too.
665 Properly align; the old code wasn't right for common 32-bit hosts
666 when configured with --enable-checking=all.
667 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
668 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
669
31bed486
EZ
6702011-09-29 Eli Zaretskii <eliz@gnu.org>
671
04c70788 672 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
673 use EDOM.
674
fbcaa2f3
EZ
6752011-09-28 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (compute_display_string_end): If there's no display
678 string at CHARPOS, return -1.
679
680 * bidi.c (bidi_fetch_char): When compute_display_string_end
681 returns a negative value, treat the character as a normal
682 character not covered by a display string. (Bug#9624)
683
a239d4e9
JB
6842011-09-28 Juanma Barranquero <lekktu@gmail.com>
685
686 * lread.c (Fread_from_string): Fix typo in docstring.
687
88652fd5
EZ
6882011-09-27 Eli Zaretskii <eliz@gnu.org>
689
690 * xdisp.c (handle_invisible_prop): If invisible text ends on a
691 newline, reseat the iterator instead of bidi-iterating there one
692 character at a time. (Bug#9610)
32c1fffd
SM
693 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
694 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 695
ed497dd4
AS
6962011-09-27 Andreas Schwab <schwab@linux-m68k.org>
697
698 * lread.c (readevalloop): Use correct code for NBSP.
699 (read1): Likewise. (Bug#9608)
700
b2bf61aa
MA
7012011-09-25 Michael Albinus <michael.albinus@gmx.de>
702
703 * dbusbind.c (Fdbus_register_signal): When service is not
704 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
705
32bbb17c
GM
7062011-09-25 Glenn Morris <rgm@gnu.org>
707
708 * buffer.c (truncate-lines): Doc fix.
709
94e0933e
CY
7102011-09-24 Chong Yidong <cyd@stupidchicken.com>
711
712 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
713 (Fset_window_next_buffers): Doc fix.
714
cddde921
GM
7152011-09-24 Glenn Morris <rgm@gnu.org>
716
717 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
718
1260aef1
PE
7192011-09-24 Paul Eggert <eggert@cs.ucla.edu>
720
25b4bfa0
PE
721 Fix minor problems found by static checking.
722 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
723 * indent.c (Fvertical_motion): Fix == vs = typo.
724
e3cbd34b
EZ
7252011-09-24 Eli Zaretskii <eliz@gnu.org>
726
a66cfb1c
SM
727 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
728 Default value is now t. Doc fix.
6bf7006f 729
e3cbd34b 730 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 731 logic when moving up, not only when moving down. Fix the
e3cbd34b 732 confusing name and values of the it_overshoot_expected variable;
32c1fffd 733 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
734
735 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
736 CHARPOS is covered by a display string which includes newlines.
737 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
738 is covered by a display string with embedded newlines.
739
a3de0cbd
MA
7402011-09-24 Michael Albinus <michael.albinus@gmx.de>
741
742 * dbusbind.c (Fdbus_register_signal): Add match rule to
743 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
744 (Fdbus_register_method, Vdbus_registered_objects_table):
745 Fix docstring.
a3de0cbd 746
b260039d
JM
7472011-09-24 Jim Meyering <meyering@redhat.com>
748
32c1fffd 749 do not ignore write error for any output size
b260039d
JM
750 The previous change was incomplete.
751 While it makes emacs --batch detect the vast majority of stdout
752 write failures, errors were still ignored whenever the output size is
753 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
754 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
755 && echo FAIL: ignored write error
756 FAIL: ignored write error
757 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
758 && echo FAIL: ignored write error
759 FAIL: ignored write error
760 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
761
8eca8a7c
AS
7622011-09-23 Andreas Schwab <schwab@linux-m68k.org>
763
764 * emacs.c (Fkill_emacs): In noninteractive mode exit
765 non-successfully if a write error occurred on stdout. (Bug#9574)
766
3341db62
EZ
7672011-09-21 Eli Zaretskii <eliz@gnu.org>
768
769 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
770 the xassert test.
771
772 * dispextern.h (struct it): Update the comment documenting what
773 can it->OBJECT be.
774
8c203dbf
EZ
7752011-09-20 Eli Zaretskii <eliz@gnu.org>
776
777 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
778 a display string, extend search for cursor position to end of row.
779 (find_row_edges): If the row ends in a newline from a display
780 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
781 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
782 (Fcurrent_bidi_paragraph_direction): Fix search for previous
783 non-empty line. Fixes confusing cursor motion with arrow keys at
784 the beginning of a line that starts with whitespace.
8c203dbf 785
a4824228
LMI
7862011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
787
788 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
789 (bug#9493).
790
33ed493b
CY
7912011-09-18 Chong Yidong <cyd@stupidchicken.com>
792
793 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
794 boolean (Bug#9154).
795
56cd55c8
EZ
7962011-09-18 Eli Zaretskii <eliz@gnu.org>
797
798 * xdisp.c (display_line): Record maximum and minimum buffer
799 positions even if no glyphs were produced (e.g., by a zero-width
800 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
801 buffer positions that will be removed from the glyph row because
802 they don't fit.
c02dcedf
EZ
803 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
804 column is beyond frame width: don't subtract 1 "pixel" when
805 computing width of the stretch.
3e62b7e0
EZ
806 (reseat_at_next_visible_line_start): Undo the change made on
807 2011-09-17 that saved paragraph information and restored it after
808 the call to `reseat'. (Bug#9545)
56cd55c8 809
5ed99d36 8102011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
811
812 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
813 and turn window cursor on if cleared (Bug#9415).
814
5ed99d36 8152011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
816
817 * search.c (boyer_moore): Take unibyte characters from pattern
818 literally. (Bug#9458)
819
9bade7b2
EZ
8202011-09-18 Eli Zaretskii <eliz@gnu.org>
821
822 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
823
e5e9d610
PE
8242011-09-18 Paul Eggert <eggert@cs.ucla.edu>
825
87e4427a
PE
826 Fix minor problem found by static checking.
827 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
828 initialized, to pacify gcc -Wuninitialized.
829
e5e9d610
PE
830 * fileio.c: Report proper errno when syscall falls.
831 (Finsert_file_contents): Save and restore errno,
832 so that report_file_error outputs the correct diagnostic.
833 (Fwrite_region) [CLASH_DETECTION]: Likewise.
834
a1674f0b
EZ
8352011-09-18 Eli Zaretskii <eliz@gnu.org>
836
837 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
838
fbfb6dd4
EZ
8392011-09-17 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
842 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
843
bb187662
EZ
8442011-09-17 Eli Zaretskii <eliz@gnu.org>
845
1137e8b8 846 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 847 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
848
849 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
850 (bidi_find_paragraph_start): Search back for paragraph beginning
851 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
852 (bidi_move_to_visually_next): Only trigger paragraph-related
853 computations when the last character is a newline or at EOB, not
854 just any NEUTRAL_B. (Bug#9470)
855
bb187662
EZ
856 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
857 truncated lines if point is covered by a display string. (Bug#9524)
858
2e621251
PE
8592011-09-16 Paul Eggert <eggert@cs.ucla.edu>
860
861 * xselect.c: Relax test for outgoing X longs (Bug#9498).
862 (cons_to_x_long): New function.
863 (lisp_data_to_selection_data): Use it. Correct the test for
864 short-versus-long data; it was negated. Break out of vector
865 loop, for efficiency, when a long datum is discovered.
866
91a15bc6
SM
8672011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
868
869 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
870
b41c3a35
EZ
8712011-09-16 Eli Zaretskii <eliz@gnu.org>
872
873 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
874 GCC PR/17406) by declaring this function with external scope.
875
7812ba2d
PE
8762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
877
878 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
879 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
880
cf7edc2a
AS
8812011-09-15 Andreas Schwab <schwab@linux-m68k.org>
882
883 * editfns.c (Fformat): Correctly handle text properties on "%%".
884
bd01620e
EZ
8852011-09-15 Eli Zaretskii <eliz@gnu.org>
886
887 * xterm.c (x_draw_composite_glyph_string_foreground):
888 * w32term.c (x_draw_composite_glyph_string_foreground):
889 * term.c (encode_terminal_code):
890 * composite.c (composition_update_it, get_composition_id):
891 * xdisp.c (get_next_display_element)
892 (fill_composite_glyph_string): Add comments about special meaning
893 of TAB characters in a composition.
894
a02719a3
PE
8952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
896
897 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
898 This occurs when processing a multibyte format.
899 Problem reported by Wolfgang Jenker.
a02719a3 900
72589a3c
JB
9012011-09-15 Johan Bockgård <bojohan@gnu.org>
902
903 * xdisp.c (try_cursor_movement): Only check for exact match if
904 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
905
1c14176c
PE
9062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
907
908 Remove unused external symbols.
909 * dispextern.h (calc_pixel_width_or_height): Remove decl.
910 * xdisp.c (calc_pixel_width_or_height): Now static.
911 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
912 * indent.c (check_display_width):
913 * w32term.c: Fix comment to match code.
914 * xterm.c, xterm.h (x_catching_errors): Remove.
915
d2eea5b5
PE
9162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
917
918 * xselect.c: Use signed conversions more consistently (Bug#9498).
919 (selection_data_to_lisp_data): Assume incoming selection data are
920 signed integers, not unsigned. This is to be consistent with
921 outgoing selection data, which was modified to use signed integers
922 in as part of the fix to Bug#9196 in response to Jan D.'s comment
923 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
924 expects long, not unsigned long.
925
46888499
EZ
9262011-09-14 Eli Zaretskii <eliz@gnu.org>
927
928 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
929 computation of loop end. Reported by Johan Bockgård
930 <bojohan@gnu.org>.
931
ef8ef9fb
CY
9322011-09-13 Chong Yidong <cyd@stupidchicken.com>
933
934 * frame.c (Fother_visible_frames_p): Function deleted.
935
fa819fed
EZ
9362011-09-12 Eli Zaretskii <eliz@gnu.org>
937
938 * indent.c (compute_motion): Process display vector front to back
939 rather than the other way around. (Bug#2496)
940
2ba8e008
SM
9412011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
942
943 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
944
20f53c69
CY
9452011-09-11 Chong Yidong <cyd@stupidchicken.com>
946
947 * minibuf.c (Fread_from_minibuffer): Doc fix.
948
d562d7a4
EZ
9492011-09-11 Eli Zaretskii <eliz@gnu.org>
950
951 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
952 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
953
1c4d7f3d
LMI
9542011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
955
956 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
957 value for non-existent files.
958
b885bf36
EZ
9592011-09-11 Eli Zaretskii <eliz@gnu.org>
960
961 * fileio.c (Finsert_file_contents): If the file cannot be opened,
962 set its "size" to -1. This will set the modtime_size field of
963 the corresponding buffer to -1, which is what
964 verify-visited-file-modtime expects for files that do not exist.
965 (Bug#9139)
966
6612f0bf
PE
9672011-09-11 Paul Eggert <eggert@cs.ucla.edu>
968
969 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
970 here ...
971 * lisp.h: ... from here. push_key_description is no longer
972 defined in keyboard.c, so its declaration should not be in
973 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
974 logically belongs with push_key_description.
975
dfb3f755
PE
9762011-09-10 Paul Eggert <eggert@cs.ucla.edu>
977
978 * buffer.h: Include <sys/types.h> instead of <time.h>.
979 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
980 Problem reported by Herbert J. Skuhra.
981
3134906c
LMI
9822011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
983
984 * xml.c (parse_region): Make the parsing work for
985 non-comment-starting XML files again (bug#9144).
986
8d903f4e
AS
9872011-09-10 Andreas Schwab <schwab@linux-m68k.org>
988
989 * image.c (gif_load): Fix calculation of bottom and right corner.
990 (Bug#9468)
991
80ad64f4
EZ
9922011-09-10 Eli Zaretskii <eliz@gnu.org>
993
994 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
995 redisplay in small windows.
996
208a048d
EZ
9972011-09-09 Eli Zaretskii <eliz@gnu.org>
998
999 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1000
9b1c252e
MR
10012011-09-08 Martin Rudalics <rudalics@gmx.at>
1002
1003 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1004 Operate on live windows only.
1005
2949f33b
JB
10062011-09-08 Juanma Barranquero <lekktu@gmail.com>
1007
1008 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1009
e08dcafd
EZ
10102011-09-07 Eli Zaretskii <eliz@gnu.org>
1011
1012 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1013 only under bidi iteration.
1014
115b96bd
JD
10152011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1016
1017 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1018
c8199d0f
PE
10192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1022 Without this fix, the command to link temacs failed due to an
1023 undefined symbol __builtin_isnan. This is because
1024 /usr/include/iso/math_c99.h #defines isnan(x) to
1025 __builtin_isnan(x), but the bundled gcc, which identifies itself
1026 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1027 a __builtin_isnan.
1028 * floatfns.c (isnan): #undef, and then #define to a clone of
1029 what's in data.c.
1030 (Fisnan): Always define, since it's always available now.
1031 (syms_of_floatfns): Always define isnan at the Lisp level.
1032
e39b275c 10332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1034
1035 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1036
b2db44d9 10372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1038
f4af5137 1039 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1040 The previous code assumed that file offsets (off_t values) fit in
1041 EMACS_INT variables, which is not true on typical 32-bit hosts.
1042 The code messed up by falsely reporting buffer overflow in cases
1043 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1044 when "big" contains more than 2**29 bytes, even though this
1045 inserts just one byte and does not overflow the buffer.
1046 (Finsert_file_contents): Store file offsets as off_t
1047 values, not as EMACS_INT values. Check for overflow when
1048 converting between EMACS_INT and off_t. When checking for
1049 buffer overflow or for overlap, take the offsets into account.
1050 Don't use EMACS_INT for small values where int suffices.
1051 When checking for overlap, fix a typo: ZV was used where
1052 ZV_BYTE was intended.
1053 (Fwrite_region): Don't assume off_t fits into 'long'.
1054 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1055
ecfc0a49
MA
10562011-09-05 Michael Albinus <michael.albinus@gmx.de>
1057
1058 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1059
6511acf2 10602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1061
0999621a 1062 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1063
1064 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1065 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1066 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1067 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1068 (modify_event_symbol): Do not assume that the length of
1069 name_alist_or_stem is safe to alloca and fits in int.
1070 (Fexecute_extended_command): Likewise for function name and binding.
1071 (Frecursion_depth): Wrap around reliably on integer overflow.
1072 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1073 since some callers pass EMACS_INT values.
1074 (Fsingle_key_description): Don't crash if symbol name contains more
1075 than MAX_ALLOCA bytes.
1076 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1077 (get_minibuffer): Arg is now EMACS_INT, not int.
1078 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1079 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1080 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1081
2be7d702
PE
1082 * dbusbind.c (signature_cat): New function.
1083 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1084 Do not overrun buffer; instead, report string overflow.
1085
9d1df220
PE
1086 * dispnew.c (add_window_display_history): Don't overrun buffer.
1087 Truncate instead; this is OK since it's just a log.
1088
33ef5c64
PE
1089 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1090 even if the time zone offset is outlandishly large.
1091 Don't mishandle offset == INT_MIN.
1092
66c6fdd5
PE
1093 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1094 when creating daemon; the previous buffer-overflow check was incorrect.
1095
d749b01b
PE
1096 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1097 which has the guts of the old verror function.
1098
b5cd1905
PE
1099 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1100 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1101
6e1a67fb
PE
1102 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1103 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1104 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1105 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1106 length of string rather than counting it via multiple sprintfs;
1107 that's simpler and more reliable.
c21721cc
PE
1108 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1109 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1110 sprintf, in case result does not fit in int.
1111
c57b67fc
PE
1112 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1113 (fontset_from_font): Print it.
1114
8a401434
PE
1115 * frame.c (tty_frame_count): Now printmax_t, not int.
1116 (make_terminal_frame, set_term_frame_name): Print it.
1117 (x_report_frame_params): In X, window IDs are unsigned long,
1118 not signed long, so print them as unsigned.
1119 (validate_x_resource_name): Check for implausibly long names,
1120 and don't assume name length fits in 'int'.
1121 (x_get_resource_string): Don't blindly alloca invocation name;
1122 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1123 not fit in int.
1124
6e1a67fb
PE
1125 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1126 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1127 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1128
0df02bf3
PE
1129 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1130 Use esprintf, not sprintf, in case result does not fit in int.
1131
48e30793
PE
1132 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1133 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1134 it as a large positive number.
1135 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1136 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1137
a66ff6d8
PE
1138 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1139 in case result does not fit in int.
1140
aca216ff
PE
1141 * print.c (float_to_string): Detect width overflow more reliably.
1142 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1143 buffer overrun. Don't assume list length fits in 'int'. Treat
1144 print length of 0 as 0, not as infinity; to be consistent with other
1145 uses of print length in this function. Don't overflow print length
1146 index. Don't assume hash table size fits in 'long', or that
1147 vectorlike size fits in 'unsigned long'.
1148
31c286f7
PE
1149 * process.c (make_process): Use printmax_t, not int, to format
1150 process-name gensyms.
1151
55e5faa1
PE
1152 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1153
80f2e268
PE
1154 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1155 to avoid potential buffer overrun.
1156
670741ab
PE
1157 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1158 if X resource line is longer than 512 bytes.
1159
b7163a50
PE
1160 * xfns.c (x_window): Make sprintf buffer a bit bigger
1161 to avoid potential buffer overrun.
1162
ae58ff1f
PE
1163 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1164
c43c8a6a
PE
1165 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1166
3f8236f4
PE
11672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1168
53e9fe90 1169 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1170 Without these, Emacs silently mishandles large integers sometimes.
1171 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1172 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1173
6511acf2
PE
1174 * xdisp.c (try_window_id): Check Emacs fixnum range before
1175 converting to 'int'.
806add1d 1176
6511acf2 1177 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1178 Check that an Emacs fixnum is in range before assigning it to 'int'.
1179 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1180 values converted from Emacs fixnums.
1181 (Frecenter): Don't wrap around a line count if it is out of 'int'
1182 range; instead, treat it as an extreme value.
1183 (Fset_window_configuration, compare_window_configurations):
1184 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1185
6511acf2
PE
1186 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1187 that can exceed INT_MAX. Check that EMACS_INT value is in range
1188 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1189 (match_limit): Don't assume that a fixnum can fit in 'int'.
1190
6511acf2 1191 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1192 exceed INT_MAX.
1193
6511acf2 1194 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1195 (Fvertical_motion): Don't wrap around LINES values that don't fit
1196 in 'int'. Instead, treat them as extreme values. This is good
1197 enough for windows, which can't have more than INT_MAX lines anyway.
1198
fcb901a7
LMI
11992011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1200
0f2f6b6d
LMI
1201 * Require libxml/parser.h to avoid compilation warning.
1202
fcb901a7
LMI
1203 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1204
1205 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1206 since this reportedly can destroy thread storage.
1207
6e20a0d4
CY
12082011-08-30 Chong Yidong <cyd@stupidchicken.com>
1209
1210 * syntax.c (find_defun_start): Update all cache variables if
1211 exiting early (Bug#9401).
1212
148ae00e
EZ
12132011-08-30 Eli Zaretskii <eliz@gnu.org>
1214
f6cfbd8f
EZ
1215 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1216
148ae00e
EZ
1217 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1218 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1219 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1220
1221 * term.c (tty_append_glyph): New function.
1222 (produce_stretch_glyph): Static function and its prototype deleted.
1223
a66cfb1c
SM
1224 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1225 Add prototypes.
148ae00e 1226
c4a07a4c
PE
12272011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1230 when checking :margin (Bug#9390).
1231 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1232 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1233 so that the name doesn't mislead. All uses changed.
1234
6bc8cd65
JB
12352011-08-28 Johan Bockgård <bojohan@gnu.org>
1236
1237 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1238 set_tty_hooks.
1239
dca4927e
EZ
12402011-08-27 Eli Zaretskii <eliz@gnu.org>
1241
1242 * xdisp.c (move_it_to): Don't bail out early when reaching
1243 position beyond to_charpos, if we are scanning backwards.
1244 (move_it_vertically_backward): When DY == 0, make sure we get to
1245 the first character in the line after the newline.
1246
f2cad773
PE
12472011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1250 (ccl_driver): Do not generate an out-of-range pointer.
1251 (Fccl_execute_on_string): Remove unnecessary check for
1252 integer overflow, noted by Stefan Monnier in
1253 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1254 Remove a FIXME that didn't need fixing.
1255 Simplify the newly-introduced buffer reallocation code.
1256
0cae2cdb
JB
12572011-08-27 Juanma Barranquero <lekktu@gmail.com>
1258
1259 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1260
5fc295a4 12612011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1262
70c60eb2 1263 Integer and memory overflow issues (Bug#9196).
726e0ab1 1264
d31850da
PE
1265 * doc.c (get_doc_string): Rework so that
1266 get_doc_string_buffer_size is the actual buffer size, rather than
1267 being 1 less than the actual buffer size; this makes xpalloc more
1268 convenient.
1269
a69fbedb
PE
1270 * image.c (x_allocate_bitmap_record, cache_image):
1271 * xselect.c (Fx_register_dnd_atom):
1272 Simplify previous changes by using xpalloc.
1273
fe5c5d37
PE
1274 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1275 since either will do and ptrdiff_t is convenient with xpalloc.
1276
0065d054
PE
1277 * charset.c (charset_table_size)
1278 (struct charset_sort_data.priority): Now ptrdiff_t.
1279 (charset_compare): Don't overflow if priorities differ greatly.
1280 (Fsort_charsets): Don't assume list length fits in int.
1281 Check for size-calculation overflow when allocating sort data.
1282 (syms_of_charset): Allocate an initial charset table that is
1283 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1284
1285 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1286
1287 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1288 The actual value is always <= INT_MAX, and leaving it unsigned made
1289 overflow checking harder.
1290
1291 * dispextern.h (struct glyph_matrix.rows_allocated)
1292 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1293 with xpalloc. The values are still always <= INT_MAX.
1294
1295 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1296
1297 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1298 (SAFE_NALLOCA): New macro.
1299
1300 * region-cache.c (struct boundary.pos, find_cache_boundary)
1301 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1302 (set_cache_region, invalidate_region_cache)
1303 (revalidate_region_cache, know_region_cache, region_cache_forward)
1304 (region_cache_backward, pp_cache):
1305 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1306 so that ptrdiff_t * can be passed to xpalloc.
1307 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1308 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1309 (pp_cache): Don't assume cache_len fits in int.
1310 * region-cache.h: Adjust extern decls to match.
1311
1312 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1313 EMACS_INT, since either will do, for xpalloc.
1314
1315 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1316 (xnmalloc, xnrealloc, xpalloc): New functions.
1317
726e0ab1
PE
1318 * bidi.c (bidi_shelve_header_size): New constant.
1319 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1320 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1321
51f30bc5 1322 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1323 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1324 (overlay_strings):
1325 Don't update size of array until after memory allocation succeeds,
1326 because xmalloc/xrealloc may not return.
0065d054
PE
1327 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1328 now that we have proper integer overflow checking.
1329 (record_overlay_string, overlay_strings): Catch overflows when
1330 calculating size of overlay_str_buf.
726e0ab1 1331
0065d054
PE
1332 * callproc.c (Fcall_process): Check for size overflow when
1333 calculating size of args2.
1334 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1335 Normally we prefer signed values, but sticking with ptrdiff_t would
1336 require adding more-complicated checks.
726e0ab1
PE
1337
1338 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1339 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1340 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1341 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1342
1343 * character.c (Fstring): Check for size-calculation overflow.
1344
1345 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1346 unnecessary integer overflow. Check for size overflow.
1347 (encode_coding_object): Don't update size until xmalloc succeeds.
1348
1349 * composite.c (get_composition_id): Check for overflow in glyph
1350 length calculations.
1351
1352 Integer and memory overflow fixes for display code.
1353 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1354 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1355 (scrolling_window): Check for overflow in size calculations.
1356 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1357 Don't assume glyph table len fits in int.
1358 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1359 (row_table_size): Now ptrdiff_t, not int.
1360 (scrolling_window): Avoid overflow in size calculations.
1361 Don't update size until allocation succeeds.
1362 * fns.c (concat): Check for overflow in size calculations.
1363 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1364 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1365 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1366
1367 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1368 (get_doc_string): Check for size calculation overflow.
1369 Don't update size until allocation succeeds.
1370 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1371 EMACS_INT, where ptrdiff_t will do.
1372 (Fsubstitute_command_keys): Check for string overflow.
1373
1374 * editfns.c (set_time_zone_rule): Don't assume environment length
1375 fits in int.
1376 (message_length): Now ptrdiff_t, not int.
1377 (Fmessage_box): Don't update size until allocation succeeds.
1378 Don't assume message length fits in int.
1379 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1380
0065d054
PE
1381 * emacs.c (main): Do not reallocate argv, since there is a null at
1382 the end that can be overwritten, and this way there's no need to
1383 worry about size-calculation overflow.
1384 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1385
1386 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1387 alloc succeeds.
1388 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1389
1390 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1391 (x_set_scroll_bar_width, x_figure_window_size):
1392 Check for integer overflow.
1393 (x_set_alpha): Do not assume XINT fits in int.
1394
1395 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1396 This is for the members text_lines, text_cols, total_lines, total_cols,
1397 where the system imposes an 'int' limit.
1398
1399 * fringe.c (Fdefine_fringe_bitmap):
1400 Don't update size until alloc works.
1401
1402 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1403 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1404
1405 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1406 Check for size-calculation overflow.
1407 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1408 do, as we prefer signed integers.
1409 (id_to_widget.max_size, id_to_widget.used)
1410 (xg_store_widget_in_map, xg_remove_widget_from_map)
1411 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1412 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1413 Use and return ptrdiff_t, not int.
1414 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1415 * gtkutil.h: Change prototypes to match the above.
1416
1417 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1418 are duplicate now that they've been promoted to lisp.h.
1419 (x_allocate_bitmap_record, x_alloc_image_color)
1420 (make_image_cache, cache_image, xpm_load):
1421 Don't update size until alloc is done.
1422 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1423 (x_detect_edges):
3256efce 1424 Check for size calculation overflow.
726e0ab1
PE
1425 (ct_colors_allocated_max): New constant.
1426 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1427 overflow.
3256efce 1428
726e0ab1
PE
1429 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1430 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1431 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1432 Use ptrdiff_t, not int, to count maps.
1433 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1434 calculations. Don't update size until allocation succeeds.
1435 Redo calculations to avoid overflow.
726e0ab1
PE
1436 * keyboard.h: Change prototypes to match the above.
1437
1438 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1439 to count maps.
1440 (current_minor_maps): Check for size calculation overflow.
1441 * keymap.h: Change prototypes to match the above.
1442
1443 * lread.c (read1, init_obarray): Don't update size until alloc done.
1444
1445 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1446 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1447
726e0ab1
PE
1448 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1449 Now ptrdiff_t, not int.
1450 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1451 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1452
1453 * process.c (Fnetwork_interface_list): Check for overflow
1454 in size calculation.
1455
1456 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1457
1458 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1459 overflow. Don't bother calling xmalloc when xrealloc will do.
1460
1461 * search.c (Freplace_match): Check for size calculation overflow.
1462 (Fset_match_data): Don't assume list lengths fit in 'int'.
1463
1464 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1465 for command line length. Do not attempt to address one before the
1466 beginning of an array, as that's not portable.
1467
1468 * term.c (max_frame_lines): Remove; unused.
1469 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1470 not int.
1471 (encode_terminal_code, calculate_costs): Check for size
1472 calculation overflow.
1473 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1474 table lengths and related sizes. Don't update size until alloc
1475 done. Redo calculations to avoid overflow.
1476 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1477
1478 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1479 subtracting pointers.
1480 (gobble_line): Check for overflow more carefully. Don't update size
1481 until alloc done.
1482
1483 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1484 Don't update size until alloc done.
1485 Redo size calculations to avoid overflow.
1486 Check for size calculation overflow.
0065d054 1487 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1488
1489 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1490 Use ptrdiff_t, not int, for sizes.
1491 (store_mode_line_noprop_char): Don't update size until alloc done.
1492
0065d054
PE
1493 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1494 Use ptrdiff_t, not int, for sizes.
1495 (Finternal_make_lisp_face, cache_face):
1496 Check for size calculation overflow.
1497 (cache_face): Treat size calculation overflows as if they were
1498 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1499
1500 * xfns.c (x_encode_text, x_set_name_internal)
1501 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1502 sizes, since they can exceed INT_MAX in size. Check for size
1503 calculation overflow.
1504
0065d054
PE
1505 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1506 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1507 Don't update size until alloc done.
1508
0065d054 1509 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1510 as sprintf is limited to int lengths.
1d526e2f 1511
252c5ee1
PE
1512 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1513 (X_LONG_MIN): New macros.
864d7ce7
PE
1514 Use them to make the following changes clearer.
1515 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1516 This change doesn't affect the value now, but it may help remind
1517 future maintainers not to raise the value too much later.
1518 (SELECTION_QUANTUM): Remove, replacing with ...
1519 (selection_quantum): ... new function, which avoids overflow.
1520 All uses changed.
1521 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1522 assumption that selection length fits in 'int'.
1523 (x_reply_selection_request, x_handle_selection_request)
1524 (x_get_window_property, receive_incremental_selection)
1525 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1526 (lisp_data_to_selection_data, clean_local_selection_data):
1527 Use ptrdiff_t, not int, to record length of selection.
1528 (x_reply_selection_request, x_get_window_property)
1529 (receive_incremental_selection, x_property_data_to_lisp):
1530 Redo calculations to avoid overflow.
1531 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1532 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1533 something.
1534 (x_get_window_property, receive_incremental_selection)
1535 (lisp_data_to_selection_data, x_property_data_to_lisp):
1536 Check for size-calculation overflow.
1537 (x_get_window_property, receive_incremental_selection)
1538 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1539 Don't store size until memory allocation succeeds.
1540 (x_get_window_property): Plug memory leak on memory exhaustion.
1541 Don't double-block input; malloc is safe here. Don't assume 2**34
1542 - 4 fits in unsigned long. Add an xassert to check
1543 XGetWindowProperty overflow. Be more careful about overflow
1544 calculations, and distinguish size from memory overflow better.
1545 (receive_incremental_selection): When tracing, don't assume
1546 unsigned int is less than INT_MAX.
1547 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1548 harmful) conversions of unsigned short to int.
1549 (lisp_data_to_selection_data): Don't assume that integers
1550 in the range -65535 through -1 fit in an X unsigned short.
1551 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1552 result parameters unless successful. Rely on cons_to_unsigned
1553 to report problems with elements; the old code wasn't right anyway.
1554 (x_check_property_data): Check for int overflow; we cannot use
1555 a wider type due to X limits.
1556 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1557
726e0ab1 1558 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1559
0065d054
PE
1560 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1561 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1562 (x_color_cells): Don't store size until memory allocation succeeds.
1563 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1564 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1565 (x_term_init): Don't assume length fits in int (sprintf is limited
1566 to int size).
bc18e09d 1567
ebfa62c0
PE
1568 Use ptrdiff_t for composition IDs.
1569 * character.c (lisp_string_width):
1570 * composite.c (composition_table_size, n_compositions)
1571 (get_composition_id, composition_gstring_from_id):
1572 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1573 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1574 * window.c (Frecenter):
1575 Use ptrdiff_t, not int, for composition IDs.
1576 * composite.c (get_composition_id): Check for integer overflow.
1577 * composite.h: Adjust prototypes to match the above changes.
1578
d3411f89
PE
1579 Use ptrdiff_t for hash table indexes.
1580 * category.c (hash_get_category_set):
1581 * ccl.c (ccl_driver):
1582 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1583 * coding.c (coding_system_charset_list, detect_coding_system):
1584 * coding.h (struct coding_system.id):
1585 * composite.c (get_composition_id, gstring_lookup_cache):
1586 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1587 * image.c (xpm_get_color_table_h):
1588 * lisp.h (hash_lookup, hash_put):
1589 * minibuf.c (Ftest_completion):
1590 Use ptrdiff_t for hash table indexes, not int (which is too
1591 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1592 32-bit --with-wide-int hosts).
1593
e097a6fa
PE
1594 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1595 Add a FIXME comment about memory leaks.
1596 (syms_of_charset): Don't assume xmalloc returns.
1597
5637687f
PE
1598 Don't assume that stated character widths fit in int.
1599 * character.c (Fchar_width, c_string_width, lisp_string_width):
1600 * character.h (CHAR_WIDTH):
1601 * indent.c (MULTIBYTE_BYTES_WIDTH):
1602 Use sanitize_char_width to avoid undefined and/or bad behavior
1603 with outlandish widths.
a66cfb1c 1604 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1605 now that we have two such functions. All uses changed.
1606 (sanitize_char_width): New inline function.
1607
a2271ba2
PE
1608 Don't assume that tab-width fits in int.
1609 * character.h (sanitize_width): New inline function.
1610 (SANE_TAB_WIDTH): New macro.
1611 (ASCII_CHAR_WIDTH): Use it.
1612 * indent.c (sane_tab_width): Remove. All uses replaced by
1613 SANE_TAB_WIDTH (current_buffer).
1614 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1615
18c52557
PE
1616 * fileio.c: Integer overflow issues with file modes.
1617 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1618
caeeedc1
PE
1619 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1620 Remove unreachable code.
1621 (read_hex, load_charset_map_from_file): Check for integer overflow.
1622
50849c52
PE
1623 * xterm.c: don't go over XClientMessageEvent limit
1624 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1625 (x_send_scroll_bar_event): Likewise. Check that the size does not
1626 exceed limits imposed by XClientMessageEvent, as well as the usual
1627 ptrdiff_t and size_t limits.
1628
b13995db
PE
1629 * keyboard.c: Overflow, signedness and related fixes.
1630 (make_lispy_movement): Use same integer type in forward decl
1631 that is used in the definition.
1632 (read_key_sequence, keyremap_step):
1633 Change bufsize argument back to int, undoing my 2011-03-30 change.
1634 We prefer signed types, and int is wide enough here.
1635 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1636 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1637 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1638 length, not size_t. Use ptrdiff_t for index, not int.
1639 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1640 possibility of integer overflow.
1641
13464394
PE
1642 Overflow, signedness and related fixes for images.
1643
1644 * dispextern.h (struct it.stack[0].u.image.image_id)
1645 (struct_it.image_id, struct image.id, struct image_cache.size)
1646 (struct image_cache.used, struct image_cache.ref_count):
1647 * gtkutil.c (update_frame_tool_bar):
1648 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1649 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1650 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1651 * nsmenu.m (update_frame_tool_bar):
1652 * xdisp.c (calc_pixel_width_or_height):
1653 * xfns.c (image_cache_refcount):
1654 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1655 on typical 64-bit hosts.
1656
1657 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1658 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1659 Omit unnecessary casts to int.
1660 (parse_image_spec): Check that integers fall into 'int' range
1661 when the callers expect that.
1662 (image_ascent): Redo ascent calculation to avoid int overflow.
1663 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1664 (lookup_image): Remove unnecessary tests.
1665 (xbm_image_p): Locals are now of int, not EMACS_INT,
1666 since parse_image_check makes sure they fit into int.
1667 (png_load, gif_load, svg_load_image):
1668 Prefer int to unsigned where either will do.
1669 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1670 old tiff_error_handler and tiff_warning_handler.
1671 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1672 stack buffer overflows. It uses only the features of vsnprintf
1673 that are common to both POSIX and native Microsoft.
1674 (tiff_error_handler, tiff_warning_handler): Use it.
1675 (tiff_load, gif_load, imagemagick_load_image):
1676 Don't assume :index value fits in 'int'.
1677 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1678 (imagemagick_load_image): Check that crop parameters fit into
1679 the integer types that MagickCropImage accepts. Don't assume
1680 Vimagemagick_render_type has a nonnegative value. Don't assume
1681 size_t fits in 'long'.
1682 (gs_load): Use printmax_t to print the widest integers possible.
1683 Check for integer overflow when computing image height and width.
1684
c11821d4
EZ
16852011-08-26 Eli Zaretskii <eliz@gnu.org>
1686
1687 * xdisp.c (redisplay_window): Don't force window start if point
1688 will be invisible in the resulting window. (Bug#9324)
1689
0c95fcf7
EZ
16902011-08-25 Eli Zaretskii <eliz@gnu.org>
1691
1692 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1693 the display spec is of the form `(space ...)'.
1694 (handle_display_spec): Return the value returned by
1695 handle_single_display_spec, not just 1 or zero.
1696 (handle_single_display_spec): If the display spec is of the form
1697 `(space ...)', and specifies display in the text area, return 2
1698 rather than 1.
fee65a97 1699 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1700 accurately, and prefer exact match for point under bidi.
1701 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1702
1703 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1704 into disp_prop; all users changed.
1705
1706 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1707 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1708 for the text covered by the display property.
1709
e4ed06f1
CY
17102011-08-25 Chong Yidong <cyd@stupidchicken.com>
1711
1712 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1713 Change return value to nil.
1714 (Frecord_buffer): Delete unused function.
1715
f67cdd7f
EZ
17162011-08-24 Eli Zaretskii <eliz@gnu.org>
1717
5980d4c6
EZ
1718 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1719 buffers, return left-to-right.
8610fe8b
EZ
1720 (set_cursor_from_row): Consider candidate row a win if its glyph
1721 represents a newline and point is on that newline. Fixes cursor
1722 positioning on the newline at EOL of R2L text within L2R
1723 paragraph, and vice versa.
1724 (try_cursor_movement): Check continued rows, in addition to
1725 continuation rows. Fixes unwarranted scroll when point enters a
1726 continued line of R2L text within an L2R paragraph, or vice versa.
1727 (cursor_row_p): Consider the case of point being equal to
1728 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1729 from the end of a short line to the beginning of a continued line
1730 of R2L text within L2R paragraph.
1731 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1732 composed characters.
5980d4c6 1733
f67cdd7f
EZ
1734 * bidi.c (bidi_check_type): Use xassert.
1735 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1736 members.
1737
bca633fb
EZ
17382011-08-23 Eli Zaretskii <eliz@gnu.org>
1739
1740 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1741 a character.
1742
4a5885a7
CY
17432011-08-23 Chong Yidong <cyd@stupidchicken.com>
1744
1745 * nsfont.m (ns_otf_to_script): Fix typo.
1746
0902a04e
KH
17472011-08-22 Kenichi Handa <handa@m17n.org>
1748
1749 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1750 extra slot even if the purpose is char-code-property-table.
1751
1a2e6670
EZ
17522011-08-23 Eli Zaretskii <eliz@gnu.org>
1753
8ddde651
EZ
1754 * xdisp.c (redisplay_window): When computing centering_position,
1755 account for the height of the header line. (Bug#8874)
1756
425cc014
EZ
1757 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1758 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1759 candidate is selected by the mouse, and that candidate has a
1760 composed character under the mouse.
1761
1a2e6670
EZ
1762 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1763 coordinates reported by pos-visible-in-window-p for a composed
1764 character in column zero.
1765
8b76d6f8
SM
17662011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1767
1768 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1769
dac347dd
EZ
17702011-08-22 Eli Zaretskii <eliz@gnu.org>
1771
1772 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1773 consider it a hit if to_charpos is anywhere in the range of the
1774 composed buffer positions.
1775
e013fb34
CY
17762011-08-22 Chong Yidong <cyd@stupidchicken.com>
1777
1778 * image.c (gif_load): Don't assume that each subimage has the same
1779 dimensions as the base image. Handle disposal method that is
1780 "undefined" by the gif spec (Bug#9335).
1781
bd1ba3e8
CY
17822011-08-20 Chong Yidong <cyd@stupidchicken.com>
1783
1784 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1785 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1786
54a1215b
EZ
17872011-08-19 Eli Zaretskii <eliz@gnu.org>
1788
823564e5
EZ
1789 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1790 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1791 from an Org mode buffer to a Speedbar frame.
1792
54a1215b
EZ
1793 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1794 a composition, take its buffer position from IT->cmp_it.charpos.
1795 Fixes cursor positioning at the beginning of a line that begins
1796 with a composed character.
1797
9778ebcc
EZ
17982011-08-18 Eli Zaretskii <eliz@gnu.org>
1799
0be6ee06
EZ
1800 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1801 character bidirectional type, use STRONG_L instead. Fixes crashes
1802 in a buffer produced by `describe-categories'.
1803
9778ebcc
EZ
1804 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1805 members before the level stack, so they would be saved and
1806 restored when copying iterator state. Fixes incorrect reordering
1807 around TABs covered by display properties.
1808
156bffbe
AS
18092011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1810
6b02f655 1811 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1812
72ad093b
CY
18132011-08-17 Chong Yidong <cyd@stupidchicken.com>
1814
1815 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1816 (internal_condition_case_2, internal_condition_case_n):
1817 Remove unnecessary aborts (Bug#9081).
72ad093b 1818
35774242
EZ
18192011-08-17 Eli Zaretskii <eliz@gnu.org>
1820
1821 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1822 has no `load' handler, try opening the file locally. (Bug#9311)
1823
db76dd85
KB
18242011-08-16 Ken Brown <kbrown@cornell.edu>
1825
1826 * gmalloc.c: Expand comment.
1827
b215eee5
EZ
18282011-08-16 Eli Zaretskii <eliz@gnu.org>
1829
1830 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1831 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1832
a4579d33
KB
18332011-08-16 Ken Brown <kbrown@cornell.edu>
1834
1835 Fix memory allocation problems in Cygwin build (Bug#9273).
1836
1837 * unexcw.c ( __malloc_initialized): Declare external variable.
1838 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1839
8b76d6f8
SM
1840 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1841 New variables.
a4579d33
KB
1842 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1843 dumped emacs.
1844 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1845 in the static heap.
1846 [CYGWIN] (special_realloc): New function.
1847 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1848 requests to realloc storage in the static heap.
1849
3ebec551
PE
18502011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 * bidi.c (bidi_initialize): Remove unused local.
1853
9fd8be00
EZ
18542011-08-15 Eli Zaretskii <eliz@gnu.org>
1855
6b02f655
SM
1856 * bidimirror.h:
1857 * biditype.h: Remove file.
1858 * makefile.w32-in ($(BLD)/bidi.$(O)):
1859 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1860
1861 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1862
1863 * chartab.c: Improve commentary for the uniprop_table API.
1864
32413314
EZ
1865 * bidi.c (bidi_paragraph_init): Support zero value of
1866 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1867 (bidi_initialize): Use uniprop_table instead of including
1868 biditype.h and bidimirror.h.
32413314 1869
9fd8be00
EZ
1870 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1871 coordinates of the iterator when restoring from ppos_it.
1872 (Bug#9296)
1873
5cf2b69b
KH
18742011-08-14 Kenichi Handa <handa@m17n.org>
1875
1876 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1877 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1878
daf17d00
EZ
18792011-08-14 Eli Zaretskii <eliz@gnu.org>
1880
1881 * xdisp.c (move_it_in_display_line_to): Don't invoke
1882 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1883 ppos_it. Fixes vertical cursor motion when line beginning is
1884 covered by an image. (Bug#9296)
1885
08e3161a
JD
18862011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1887
1888 * nsterm.h (ns_run_ascript): Declare.
1889 (NSAPP_DATA2_RUNASSCRIPT): Define.
1890
1891 * nsfns.m (as_script, as_result, as_status): New static variables.
1892 (ns_run_ascript): New function.
5e617bc2 1893 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1894 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1895 the event loop. Get status from as_status (Bug#7276).
1896
1897 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1898 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1899 the event loop (Bug#7276).
1900
a3720aa2
AS
19012011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1902
1903 * gnutls.c (QCgnutls_bootprop_priority)
1904 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1905 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1906 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1907 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1908 (QCgnutls_bootprop_verify_hostname_error)
1909 (QCgnutls_bootprop_callbacks_verify): Rename from
1910 Qgnutls_bootprop_..., all uses changed.
1911
1912 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1913 uses changed.
1914
0a0d27fb
PE
19152011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1916
19d5c50c
PE
1917 * xfaces.c (Qframe_set_background_mode): Now static.
1918 * dispextern.h (Qframe_set_background_mode): Remove decl.
1919
0a0d27fb
PE
1920 * process.c (Fnetwork_interface_info): Declare local only if needed.
1921
377538cb
JD
19222011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1923
1924 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1925 (Fnetwork_interface_list): Allocate in increments of bytes instead
1926 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1927 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1928 sockaddr.
1929 (struct ifflag_def): notrailers is smart on OSX.
1930 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1931 Get hardware address with getifaddrs if available.
1932
08fff70c
EZ
19332011-08-12 Eli Zaretskii <eliz@gnu.org>
1934
1935 * xdisp.c (iterate_out_of_display_property): xassert that
1936 IT->position is set to within IT->object's boundaries. Break from
1937 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1938 when IT->position is set up wrongly due to some bug.
1939 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1940 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1941 entry. Force push_it to save on the stack the current
1942 buffer/string position, to be restored by pop_it. Fix flags in
1943 the iterator structure wrt the object coming from a display
1944 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1945 properties. (Bug#9284)
1946
7be1c708 19472011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1948
7be1c708
CY
1949 * fontset.c (fontset_get_font_group): Add proper type checks.
1950 (Bug#9172)
aac0c6e3 1951
7be1c708 19522011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1953
7be1c708
CY
1954 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1955 and LC_VERSION_MIN_MACOSX.
1956 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1957 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1958
97bb72a6
EZ
19592011-08-08 Eli Zaretskii <eliz@gnu.org>
1960
1961 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1962 no-display-properties-and-no-overlays under bidi display.
1963 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1964 properties and overlays.
97bb72a6 1965
d5617611
CY
19662011-08-08 Chong Yidong <cyd@stupidchicken.com>
1967
37e11a63
CY
1968 * editfns.c (Fset_time_zone_rule): Document relationship with the
1969 setenv function.
1970
d5617611
CY
1971 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1972 the font entity extracted from the cache (Bug#8109).
1973
58872834
CY
19742011-08-07 Chong Yidong <cyd@stupidchicken.com>
1975
1976 * composite.c (autocmp_chars): Don't reset point. That is done by
1977 restore_point_unwind (Bug#5984).
1978
75bfc667
JL
19792011-08-07 Juri Linkov <juri@jurta.org>
1980
1981 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1982 to show the arg `TIME' instead of `TIMEVAL'.
1983
d1410150
EZ
19842011-08-06 Eli Zaretskii <eliz@gnu.org>
1985
1986 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1987 display property strides EOL and includes a newline, as in
1988 longlines-mode. (Bug#9254)
75b771e4
EZ
1989 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1990 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1991
1992 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1993 is non-zero, even if the data buffer is NULL. Fixes a crash in
1994 vertical-motion with longlines-mode. (Bug#9254)
1995
35928349
EZ
19962011-08-05 Eli Zaretskii <eliz@gnu.org>
1997
ec7cc85b
EZ
1998 * bidi.c <bidi_cache_total_alloc>: Now static.
1999 (bidi_initialize): Initialize bidi_cache_total_alloc.
2000
8b76d6f8 2001 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2002 cache. (Bug#9221)
2003
2004 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2005 amount allocated this far in `bidi_cache_total_alloc'.
2006 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2007 non-zero, only free the data buffer without restoring the cache
2008 contents. All callers changed.
2009
2010 * dispextern.h (bidi_unshelve_cache): Update prototype.
2011
2012 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2013 (move_it_in_display_line, move_it_to)
2014 (move_it_vertically_backward, move_it_by_lines): Replace the call
2015 to xfree to an equivalent call to bidi_unshelve_cache.
2016 (move_it_in_display_line_to): Fix logic of returning
412b6358 2017 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2018
e2e2423b
EZ
20192011-08-05 Eli Zaretskii <eliz@gnu.org>
2020
2021 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2022 came from a string character with a `cursor' property. (Bug#9229)
2023
ae9e757a
JD
20242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2025
2026 * Makefile.in (LIB_PTHREAD): New variable.
2027 (LIBES): Add LIB_PTHREAD (Bug#9216).
2028
2029 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2030 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2031
213bd7f2
AS
20322011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2033
6b02f655 2034 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2035
99aaf75f
JD
20362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2037
2038 * xterm.c (x_find_topmost_parent): New function.
2039 (x_set_frame_alpha): Find topmost parent window with
2040 x_find_topmost_parent and set the property there also (bug#9181).
2041 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2042
c74e9d86
PE
20432011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * callproc.c (Fcall_process): Avoid vfork clobbering
2046 the local vars buffer, coding_systems, current_dir.
2047
640c8776
SM
20482011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2049
2050 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2051
f26d0e4c
PE
20522011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2053
8a10d76c
PE
2054 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2055 so that it is not optimized away.
2056
f26d0e4c
PE
2057 * xdisp.c (compute_display_string_pos): Remove unused local.
2058
55439c61
EZ
20592011-08-02 Eli Zaretskii <eliz@gnu.org>
2060
2061 Fix slow cursor motion and scrolling in large buffers with
2062 selective display, like Org Mode buffers. (Bug#9218)
2063
2064 * dispextern.h (struct bidi_it): New member disp_prop_p.
2065
2066 * xdisp.c: Remove one-slot cache of display string positions.
2067 (compute_display_string_pos): Accept an additional argument
5e617bc2 2068 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2069 for a display string or property. If found, set DISP_PROP_P
2070 non-zero.
2071
2072 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2073 DISP_PROP_P, and pass it to compute_display_string_pos.
2074 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2075 non-zero. All callers of bidi_fetch_char changed.
2076
fb33fa43
SM
20772011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2078
2079 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2080
b099e063
DM
20812010-12-03 Don March <don@ohspite.net>
2082
2083 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2084 last character M-[char] is translated to ESC [char] (bug#7541).
2085
5cc7f7af
KH
20862011-08-02 Kenichi Handa <handa@m17n.org>
2087
d0fffa3f 2088 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2089
2090 * chartab.c (uniprop_table): Make it non-static.
2091
525d5e6e
EZ
20922011-08-01 Eli Zaretskii <eliz@gnu.org>
2093
2094 * xdisp.c (forward_to_next_line_start): Accept additional argument
2095 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2096 on the newline.
2097 (reseat_at_next_visible_line_start): Use the bidi iterator state
2098 returned by forward_to_next_line_start to restore the state of
2099 it->bidi_it after backing up to previous newline. (Bug#9212)
2100
31011111
AS
21012011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2102
2103 * regex.c (re_comp): Protoize.
2104 (re_exec): Fix return type.
2105 (regexec): Fix type of `ret'. (Bug#9203)
2106
476371c4
PE
21072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2108
e5d76069
PE
2109 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2110 This is needed if max-image-size is a floating-point number.
2111
9a79b20c
AS
21122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * print.c (print_object): Print empty symbol as ##.
2115
2116 * lread.c (read1): Read ## as empty symbol.
2117
d8c2fa78
AA
21182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2119
2120 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2121 setting frame foreground color (Bug#9175).
2122 (x_set_background_color): Likewise.
2123
ffe57a7a
AA
2124 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2125 contents (Bug#9176).
2126 (EmacsTooltip -init): Remove bezels and add shadows to
2127 tooltip windows.
2128
bf3492a5
AA
2129 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2130 or scroll bar (Bug#8470).
2131
d55e9c53
AA
2132 * nsfont.m (nsfont_open): Remove assignment to voffset and
2133 unnecessary vars hshink, expand, hd, full_height, min_height.
2134 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2135
2136 * nsterm.h (nsfont_info): Remove voffset field.
2137
d8c2fa78 21382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2139
2140 Implement strike-through and overline on NextStep (Bug#8863).
2141
2142 * nsfont.m (nsfont_open): Use underline position provided by font,
2143 instead of hard-coded value of 2.
2144 (nsfont_draw): Call ns_draw_text_decoration instead.
2145
2146 * nsterm.h: Add declaration for ns_draw_text_decoration.
2147
2148 * nsterm.m (ns_draw_text_decoration): New function for drawing
2149 underline, overline, and strike-through.
2150 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2151 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2152 accommodate underlining, etc.
4843aac3 2153
4cc60b9b
EZ
21542011-07-28 Eli Zaretskii <eliz@gnu.org>
2155
bc7ece87
EZ
2156 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2157 default.
4cc60b9b 2158
476371c4
PE
21592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2160
66606eea
PE
2161 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2162 Without this fix, if a signal arrives just after memory fills up,
2163 'malloc' might be invoked reentrantly.
2164
476371c4
PE
2165 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2166 In other words, assume that every image size is allowed, on non-X
2167 hosts. This assumption is probably wrong, but it lets Emacs compile.
2168
f3fcc40d
AS
21692011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2170
2171 * regex.c (re_iswctype): Convert return values to boolean.
2172
350c992f
EZ
21732011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2174
2175 * xdisp.c (compute_display_string_pos): Don't use cached display
2176 string position if the buffer had its restriction changed.
2177 (Bug#9184)
2178
5266b4bb
PE
21792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2182
2573a837 21832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2184
41f55ccd 2185 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2186
39e378da
PE
2187 * bidi.c: Integer size and overflow fixes.
2188 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2189 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2190 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2191 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2192 (bidi_find_other_level_edge):
2193 Use ptrdiff_t instead of EMACS_INT where either will do.
2194 This works better on 32-bit hosts configured --with-wide-int.
2195 (bidi_cache_ensure_space): Check for size-calculation overflow.
2196 Use % rather than repeated addition, for better worst-case speed.
2197 Don't set bidi_cache_size until after xrealloc returns, because it
2198 might not return.
2199 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2200 (bidi_cache_ensure_space): Also check that the bidi cache size
2201 does not exceed that of the largest Lisp string or buffer. See Eli
2202 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2203
5e927815
PE
2204 * alloc.c (__malloc_size_t): Remove.
2205 All uses replaced by size_t. See Andreas Schwab's note
2206 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2207
ca4aa935
PE
2208 * image.c: Improve checking for integer overflow.
2209 (check_image_size): Assume that f is nonnull, since
2210 it is always nonnull in practice. This is one less thing to
2211 worry about when checking for integer overflow later.
2212 (x_check_image_size): New function, which checks for integer
2213 overflow issues inside X.
2214 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2215 This removes the need for a memory_full check.
2216 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2217 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2218 (xbm_read_bitmap_data): Change locals back to 'int', since
2219 their values must fit in 'int'.
2220 (xpm_load_image, png_load, tiff_load):
2221 Invoke x_create_x_image_and_pixmap earlier,
2222 to avoid much needless work if the image is too large.
2223 (tiff_load): Treat overly large images as if
2224 x_create_x_image_and_pixmap failed, not as malloc failures.
2225 (gs_load): Use x_check_image_size.
2226
5f8f9cc2
PE
2227 * gtkutil.c: Omit integer casts.
2228 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2229 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2230
5adf60bc
PE
2231 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2232
c8907a93
PE
2233 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2234 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2235 would wrongly return t on a 64-bit host.
2236
e3c25c68
PE
2237 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2238 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2239 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2240 and therefore cause GCC to emit a bogus diagnostic in some cases.
2241
3f791afe
PE
2242 * image.c: Integer signedness and overflow and related fixes.
2243 This is not an exhaustive set of fixes, but it's time to
2244 record what I've got.
2245 (lookup_pixel_color, check_image_size): Remove redundant decls.
2246 (check_image_size): Don't assume that arbitrary EMACS_INT values
2247 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2248 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2249 (tiff_load, imagemagick_load_image):
2250 Check for overflow in size calculations.
2251 (x_create_x_image_and_pixmap): Remove unnecessary test for
2252 xmalloc returning NULL; that can't happen.
2253 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2254 (xpm_color_bucket): Use better integer hashing function.
2255 (xpm_cache_color): Don't possibly over-allocate memory.
2256 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2257 (gif_memory_source):
2258 Use ptrdiff_t, not int or size_t, to record sizes.
2259 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2260 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2261 either works, as we prefer signed integers.
2262 (tiff_read_from_memory, tiff_write_from_memory):
2263 Return tsize_t, not size_t, since that's what the TIFF API wants.
2264 (tiff_read_from_memory): Don't fail simply because the read would
2265 go past EOF; instead, return a short read.
2266 (tiff_load): Omit no-longer-needed casts.
2267 (Fimagemagick_types): Don't assume size fits into 'int'.
2268
3cc5a532
PE
2269 Improve hashing quality when configured --with-wide-int.
2270 * fns.c (hash_string): New function, taken from sxhash_string.
2271 Do not discard information about ASCII character case; this
2272 discarding is no longer needed.
2273 (sxhash-string): Use it. Change sig to match it. Caller changed.
2274 * lisp.h: Declare it.
2275 * lread.c (hash_string): Remove, since we now use fns.c's version.
2276 The fns.c version returns a wider integer if --with-wide-int is
2277 specified, so this should help the quality of the hashing a bit.
2278
b312a492
PE
2279 * emacs.c: Integer overflow minor fix.
2280 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2281 Define only if GNU_LINUX.
2282 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2283
dfd153ae
PE
2284 * dispnew.c: Integer signedness and overflow fixes.
2285 Remove unnecessary forward decls, that were a maintenance hassle.
2286 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2287 All uses changed.
2288 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2289 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2290 (prepare_desired_row, line_draw_cost):
2291 Use int, not unsigned, where either works.
2292 (save_current_matrix, restore_current_matrix):
2293 Use ptrdiff_t, not size_t, where either works.
2294 (init_display): Check for overflow more accurately, and without
2295 relying on undefined behavior.
2296
a81d11a3
PE
2297 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2298 Remove, replacing with the new symbols in lisp.h. All uses changed.
2299 * fileio.c (make_temp_name):
2300 * filelock.c (lock_file_1, lock_file):
2301 * xdisp.c (message_dolog):
2302 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2303 Use pMd etc. instead.
2304 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2305 replacing the pWIDE etc. symbols removed from editfns.c.
2306
3300e6fd
PE
2307 * keyboard.h (num_input_events): Now uintmax_t.
2308 This is (very slightly) less likely to mess up due to wraparound.
2309 All uses changed.
2310
fd05c7e9
PE
2311 * buffer.c: Integer signedness fixes.
2312 (alloc_buffer_text, enlarge_buffer_text):
2313 Use ptrdiff_t rather than size_t when either will do, as we prefer
2314 signed integers.
2315
903fe15d
PE
2316 * alloc.c: Integer signedness and overflow fixes.
2317 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2318 (__malloc_size_t): Default to size_t, not to int.
2319 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2320 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2321 Prefer ptrdiff_t to size_t when either would do, as we prefer
2322 signed integers.
2323 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2324 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2325 Now const. Initialize with values that are in range even if char
2326 is signed.
2327 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2328 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2329 These functions do the right thing with sizes > 2**32.
2330 (check_depth): Now ptrdiff_t, not int.
2331 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2332 Adjust to new way of storing sizes. Check for size overflow bugs
2333 in rest of code.
2334 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2335 slightly wrong anyway, as it missed one instance of
2336 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2337 (refill_memory_reserve): Omit needless cast to size_t.
2338 (mark_object_loop_halt): Mark as externally visible.
2339
ac82cc6a
PE
2340 * xselect.c: Integer signedness and overflow fixes.
2341 (Fx_register_dnd_atom, x_handle_dnd_message):
2342 Use ptrdiff_t, not size_t, since we prefer signed.
2343 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2344 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2345 x_dnd_atoms_size and x_dnd_atoms_length.
2346
c2d1e36d
PE
2347 * doprnt.c: Prefer signed to unsigned when either works.
2348 * eval.c (verror):
2349 * doprnt.c (doprnt):
2350 * lisp.h (doprnt):
2351 * xdisp.c (vmessage):
2352 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2353 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2354 prefer signed arithmetic to avoid comparison confusion.
2355 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2356 but is a bit tricky.
2357
0e926e56
PE
2358 Assume freestanding C89 headers, string.h, stdlib.h.
2359 * data.c, doprnt.c, floatfns.c, print.c:
2360 Include float.h unconditionally.
2361 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2362 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2363 * regex.c: Likewise for stddef.h, string.h.
2364 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2365 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2366 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2367 (STDC_HEADERS): Remove obsolete defines.
2368 * sysdep.c: Include limits.h unconditionally.
2369
9cfdb3ec
PE
2370 Assume support for memcmp, memcpy, memmove, memset.
2371 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2372 * regex.c (memcmp, memcpy):
2373 Remove; we assume C89 now.
2374
2375 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2376 (__malloc_safe_bcopy): Remove; no longer needed.
2377
cf950e6b 2378 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2379 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2380 well either way, and we prefer signed to unsigned.
2381
dbf38e02
LMI
23822011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2383
2384 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2385 closes the connection while we're reading (bug#9182).
2386
d6f0886c 23872011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2388
d6f0886c
JD
2389 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2390 are specified (Bug#9168).
24e0f6b1 2391
2eb1f9e6
PE
23922011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2395 Found by GCC static checking and --with-wide-int on a 32-bit host.
2396
22381272 23972011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2398
2399 * xdisp.c (compute_display_string_pos): Fix logic of caching
2400 previous display string position. Initialize cached_prev_pos to
2401 -1. Fixes slow-down at the beginning of a buffer.
2402
f25e39b4
EZ
24032011-07-24 Eli Zaretskii <eliz@gnu.org>
2404
2405 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2406 for attrs[LFACE_FONTSET_INDEX].
2407
04c4b52e
PE
24082011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 * xml.c (parse_region): Remove unused local
2411 that was recently introduced.
2412
c1734fbd
EZ
24132011-07-23 Eli Zaretskii <eliz@gnu.org>
2414
be18c5a5
EZ
2415 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2416 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2417
c1734fbd
EZ
2418 * xdisp.c (move_it_in_display_line_to): Record the best matching
2419 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2420 exit if none of the characters scanned was an exact match.
2421 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2422 when exact match is impossible due to invisible text, and the
2423 lines are truncated.
2424
a258d627
JD
24252011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2426
2427 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2428 for OSX >= 10.7.
2429
b6d5a689
EZ
24302011-07-22 Eli Zaretskii <eliz@gnu.org>
2431
0f74f785
EZ
2432 Fix a significant slow-down of cursor motion with C-n, C-p,
2433 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2434 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2435 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2436 (next_element_from_buffer): Call compute_stop_pos_backwards to
2437 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2438 base_level_stop.
2439 (reseat): Don't look for prev_stop, as that could mean a very long
2440 run.
2441 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2442 <cached_disp_overlay_modiff>: Cache for last found display string
2443 position.
551918c1 2444 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2445 about the same buffer in the same area of character positions, and
2446 the buffer wasn't changed since the time the display string
2447 position was cached.
551918c1 2448
b2d0c91a
EZ
24492011-07-22 Eli Zaretskii <eliz@gnu.org>
2450
2451 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2452 is an integer, which is important for empty lines. (Bug#9149)
2453
043604ee
CY
24542011-07-22 Chong Yidong <cyd@stupidchicken.com>
2455
2456 * frame.c (Fmodify_frame_parameters): In tty case, update the
2457 default face if necessary (Bug#4238).
2458
da4adb04
CY
24592011-07-21 Chong Yidong <cyd@stupidchicken.com>
2460
2461 * editfns.c (Fstring_to_char): No need to explain what a character
2462 is in the docstring (Bug#6576).
2463
9abd0532
LMI
24642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2465
2466 * xml.c (parse_region): Make sure we always return a tree.
2467
36881d16
HK
24682011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2469
2470 * xml.c (parse_region): If a document contains only comments,
2471 return that, too.
2472
1e98674d
LMI
24732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2474
2475 * xml.c (make_dom): Return comments, too.
2476
590bd467
PE
24772011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2478
2479 Port to OpenBSD.
2480 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2481 and the surrounding thread.
2482 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2483 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2484 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2485 timer goes off.
2486 * s/openbsd.h (BROKEN_SIGIO): Define.
2487 * unexelf.c (unexec) [__OpenBSD__]:
2488 Don't update the .mdebug section of the Alpha COFF symbol table.
2489
f41628b2
LMI
24902011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2491
2492 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2493 (bug#8460).
2494
b59b67c5
PE
24952011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2496
15e3a074
PE
2497 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2498 This fixes some race conditions on the permissions of any newly
2499 created file.
2500
41bed37d
PE
2501 * alloc.c (valid_pointer_p): Use pipe, not open.
2502 This fixes some permissions issues when debugging.
2503
b59b67c5
PE
2504 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2505 If fchown fails to set both uid and gid, try to set just gid,
2506 as that is sometimes allowed. Adjust the file's mode to eliminate
2507 setuid or setgid bits that are inappropriate if fchown fails.
2508
925a6be7
SM
25092011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2510
2511 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2512 to compare Lisp_Objects.
2513 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2514 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2515 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2516
52968808
AS
25172011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2518
0a6a104b
AS
2519 * lread.c (read_integer): Unread even EOF character.
2520 (read1): Likewise. Properly record start position of symbol.
2521
52968808
AS
2522 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2523 symbol character follows.
2524
9e381cdd
PE
25252011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2528 This works around a problem with the previous change to Fcopy_file.
2529 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2530 and without this change, GCC might complain about discarding
2531 fchown's return value.
2532
b5641435
JB
25332011-07-16 Juanma Barranquero <lekktu@gmail.com>
2534
2535 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2536
a8031457
PE
25372011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2538
2539 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2540
dd889327
LMI
25412011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2542
750c33f7
LMI
2543 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2544 it's used from the C level.
2545
dd889327
LMI
2546 * process.c: Use the same condition for POLL_FOR_INPUT in both
2547 keyboard.c and process.c (bug#1858).
2548
87e86684
LM
25492011-07-09 Lawrence Mitchell <wence@gmx.li>
2550
2551 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2552 (Fgnutls_boot): Use it.
2553
64348f40
AS
25542011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2555
2556 * doc.c (Fsubstitute_command_keys): Revert last change.
2557
1d698799
LMI
25582011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2559
f863868c
LMI
2560 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2561 quotes the next character, and doesn't affect other longer
2562 sequences (bug#8935).
2563
1d698799
LMI
2564 * lread.c (syms_of_lread): Clarify that is isn't only
2565 `eval-buffer' and `eval-defun' that's affected by
2566 `lexical-binding' (bug#8460).
2567
aa4b6df6
EZ
25682011-07-15 Eli Zaretskii <eliz@gnu.org>
2569
2570 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2571 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2572
5d856da6
PE
25732011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2574
ad6042bb
PE
2575 Fix minor problems found by static checking.
2576 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2577 (elsz): Now a signed constant, not a size_t var. We prefer signed
2578 types to unsigned, to avoid integer comparison confusion. Without
2579 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2580 "cannot optimize loop, the loop counter may overflow", a symptom
2581 of the confusion.
f00bbb22 2582 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2583 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2584
6468f31c
LMI
25852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2586
49080b10
LMI
2587 * search.c (Fre_search_backward): Mention `case-fold-search' in
2588 all the re_search_* functions (bug#8138).
2589
6468f31c
LMI
2590 * keyboard.c (Fopen_dribble_file): Document when the file is
2591 closed (bug#8056).
2592
c965adc5
EZ
25932011-07-14 Eli Zaretskii <eliz@gnu.org>
2594
df9733bf
EZ
2595 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2596 bidi_cache_idx.
2597
0bb23927
EZ
2598 Support bidi reordering of display and overlay strings.
2599 * xdisp.c (compute_display_string_pos)
2600 (compute_display_string_end): Accept additional argument STRING.
2601 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2602 (reseat_to_string): Initialize bidi_it->string.s and
2603 bidi_it->string.schars.
2604 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2605 NULL (avoids a crash in bidi_paragraph_init).
2606 Initialize itb.string.lstring.
0bb23927
EZ
2607 (init_iterator): Call bidi_init_it only of a valid
2608 buffer position was specified. Initialize paragraph_embedding to
2609 L2R.
2610 (reseat_to_string): Initialize the bidi iterator.
2611 (display_string): If we need to ignore text properties of
2612 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2613 original value of -1 will not work with bidi.)
2614 (compute_display_string_pos): First arg is now struct
2615 `text_pos *'; all callers changed. Support display properties on
2616 Lisp strings.
2617 (compute_display_string_end): Support display properties on Lisp
2618 strings.
2619 (init_iterator, reseat_1, reseat_to_string): Initialize the
2620 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2621 when iterating on a string not from display properties).
640c8776
SM
2622 (compute_display_string_pos, compute_display_string_end):
2623 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2624 arrow keys.
2625 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2626 base_level_stop; instead, set base_level_stop to BEGV.
2627 Fixes crashes in vertical-motion.
0bb23927
EZ
2628 (next_element_from_buffer): Improve commentary for when
2629 the iterator is before prev_stop.
2630 (init_iterator): Initialize bidi_p from the default value of
2631 bidi-display-reordering, not from buffer-local value. Use the
2632 buffer-local value only if initializing for buffer iteration.
2633 (handle_invisible_prop): Support invisible properties on strings
2634 that are being bidi-reordered.
2635 (set_iterator_to_next): Support bidi reordering of C strings and
2636 Lisp strings.
2637 (next_element_from_string): Support bidi reordering of Lisp
2638 strings.
2639 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2640 (display_string): Support display of R2L glyph rows.
2641 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2642 (init_iterator): Don't initialize it->bidi_p for strings
2643 here.
2644 (reseat_to_string): Initialize it->bidi_p for strings here.
2645 (next_element_from_string, next_element_from_c_string)
2646 (next_element_from_buffer): Add xassert's for correspondence
2647 between IT's object being iterated and it->bidi_it.string
2648 structure.
2649 (face_before_or_after_it_pos): Support bidi iteration.
2650 (next_element_from_c_string): Handle the case of the first string
2651 character that is not the first one in the visual order.
2652 (get_visually_first_element): New function, refactored from common
2653 parts of next_element_from_buffer, next_element_from_string, and
2654 next_element_from_c_string.
2655 (tool_bar_lines_needed, redisplay_tool_bar)
2656 (display_menu_bar): Force left-to-right direction. Add a FIXME
2657 comment for making that be controlled by a user option.
2658 (push_it, pop_it): Save and restore the state of the
2659 bidi iterator. Save and restore the bidi_p flag.
2660 (pop_it): Iterate out of display property for string iteration as
2661 well.
2662 (iterate_out_of_display_property): Support iteration over strings.
2663 (handle_single_display_spec): Set up it->bidi_it for iteration
2664 over a display string, and call bidi_init_it.
2665 (handle_single_display_spec, next_overlay_string)
2666 (get_overlay_strings_1, push_display_prop): Set up the bidi
2667 iterator for displaying display or overlay strings.
2668 (forward_to_next_line_start): Don't use the shortcut if
2669 bidi-iterating.
2670 (back_to_previous_visible_line_start): If handle_display_prop
2671 pushed the iterator stack, restore the internal state of the bidi
2672 iterator by calling bidi_pop_it same number of times.
2673 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2674 and we are bidi-iterating, don't decrement the iterator position;
2675 instead, set the first_elt flag in the bidi iterator, to produce
2676 the same effect.
2677 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2678 (push_display_prop): xassert that we are iterating a buffer.
2679 (push_it, pop_it): Save and restore paragraph_embedding member.
2680 (handle_single_display_spec, next_overlay_string)
2681 (get_overlay_strings_1, reseat_1, reseat_to_string)
2682 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2683 correctly. Don't assume unibyte strings are not bidi-reordered.
2684 (compute_display_string_pos)
2685 (compute_display_string_end): Fix handling the case of C string.
2686 (push_it, pop_it): Save and restore from_disp_prop_p.
2687 (handle_single_display_spec, push_display_prop): Set the
2688 from_disp_prop_p flag.
2689 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2690 (pop_it): Call iterate_out_of_display_property only if we are
2691 popping after iteration over a string that came from a display
2692 property. Fix a typo in popping stretch info. Add an assertion
2693 for verifying that the iterator position is in sync with the bidi
2694 iterator.
2695 (handle_single_display_spec, get_overlay_strings_1)
2696 (push_display_prop): Fix initialization of paragraph direction for
2697 string when that of the parent object is not yet determined.
2698 (reseat_1): Call bidi_init_it to resync the bidi
2699 iterator with IT's position. (Bug#7616)
2700 (find_row_edges): If ROW->start.pos gives position
2701 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2702 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2703 Reset the from_disp_prop_p flag.
2704 (SAVE_IT, RESTORE_IT): New macros.
2705 (pos_visible_p, face_before_or_after_it_pos)
2706 (back_to_previous_visible_line_start)
2707 (move_it_in_display_line_to, move_it_in_display_line)
2708 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2709 (try_scrolling, redisplay_window, display_line): Use them when
2710 saving a temporary copy of the iterator and restoring it back.
2711 (back_to_previous_visible_line_start, reseat_1)
2712 (init_iterator): Empty the bidi cache "stack".
2713 (move_it_in_display_line_to): If iterator ended up at
2714 EOL, but we never saw any buffer positions smaller than
2715 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2716 motion in bidi-reordered lines.
2717 (move_it_in_display_line_to): Record prev_method and prev_pos
2718 immediately before the call to set_iterator_to_next. Fixes cursor
2719 motion in bidi-reordered lines with stretch glyphs and strings
2720 displayed in margins. (Bug#8133) (Bug#8867)
2721 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2722 TO_CHARPOS.
640c8776
SM
2723 (pos_visible_p): Support positions in bidi-reordered lines.
2724 Save and restore bidi cache.
0bb23927
EZ
2725
2726 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2727 (bidi_paragraph_info): Delete unused struct.
2728 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2729 (bidi_cache_start): New variable.
2730 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2731 to zero.
2732 (bidi_cache_fetch_state, bidi_cache_search)
2733 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2734 (bidi_cache_find, bidi_peek_at_next_level)
2735 (bidi_level_of_next_char, bidi_find_other_level_edge)
2736 (bidi_move_to_visually_next): Compare cache index with
2737 bidi_cache_start rather than with zero.
2738 (bidi_fetch_char): Accept new argument STRING; all callers
2739 changed. Support iteration over a string. Support strings with
2740 display properties. Support unibyte strings. Fix the type of
2741 `len' according to what STRING_CHAR_AND_LENGTH expects.
2742 (bidi_paragraph_init, bidi_resolve_explicit_1)
2743 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2744 (bidi_level_of_next_char, bidi_move_to_visually_next):
2745 Support iteration over a string.
0bb23927
EZ
2746 (bidi_set_sor_type, bidi_resolve_explicit_1)
2747 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2748 can now be zero (for strings); special values 0 and -1 were
2749 changed to -1 and -2, respectively.
2750 (bidi_char_at_pos): New function.
2751 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2752 Call it instead of FETCH_MULTIBYTE_CHAR.
2753 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2754 initialized to valid values.
2755 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2756 values.
2757 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2758 the test for valid cached positions. Fix the logic for looking up
2759 the sentinel state in the cache. GCPRO the Lisp string we are
2760 iterating.
2761 (bidi_push_it, bidi_pop_it): New functions.
2762 (bidi_initialize): Initialize the bidi cache start stack pointer.
2763 (bidi_cache_ensure_space): New function, refactored from part of
2764 bidi_cache_iterator_state. Don't assume the required size is just
2765 one BIDI_CACHE_CHUNK away.
2766 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2767 (bidi_count_bytes, bidi_char_at_pos): New functions.
2768 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2769 always valid if bidi_cache_idx is valid.
2770 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2771 is valid if it's going to be used.
2772 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2773 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2774 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2775 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2776 (bidi_find_other_level_edge, bidi_cache_start_stack):
2777 All variables related to cache indices are now EMACS_INT.
c965adc5 2778
0bb23927
EZ
2779 * dispextern.h (struct bidi_string_data): New structure.
2780 (struct bidi_it): New member `string'. Make flag members be 1-bit
2781 fields, and put them last in the struct.
640c8776
SM
2782 (compute_display_string_pos, compute_display_string_end):
2783 Update prototypes.
0bb23927
EZ
2784 (bidi_push_it, bidi_pop_it): Add prototypes.
2785 (struct iterator_stack_entry): New members bidi_p,
2786 paragraph_embedding, and from_disp_prop_p.
2787 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2788 (bidi_shelve_cache, bidi_unshelve_cache):
2789 Declare prototypes.
0bb23927
EZ
2790
2791 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2792 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2793 and vector-like objects.
2794
2795 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2796 cache around display iteration.
2797
2798 * window.c (Fwindow_end, window_scroll_pixel_based)
2799 (displayed_window_lines, Frecenter): Save and restore the bidi
2800 cache around display iteration.
2801
3bbd2265
LMI
28022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2803
2804 * editfns.c (Fdelete_region): Clarify the use of the named
2805 parameters (bug#6788).
2806
adc47434
MR
28072011-07-14 Martin Rudalics <rudalics@gmx.at>
2808
2809 * indent.c (Fvertical_motion): Set and restore w->pointm when
2810 saving and restoring the window's buffer (Bug#9006).
2811
837c31f8
LMI
28122011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2813
2814 * editfns.c (Fstring_to_char): Clarify just what is returned
2815 (bug#6576). Text by Eli Zaretskii.
2816
ac389d0c
JB
28172011-07-13 Juanma Barranquero <lekktu@gmail.com>
2818
2819 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2820
0be0ce47
EZ
28212011-07-13 Eli Zaretskii <eliz@gnu.org>
2822
2823 * buffer.c (mmap_find): Fix a typo.
2824
cd18e7e3
JB
28252011-07-13 Johan Bockgård <bojohan@gnu.org>
2826
2827 Fix execution of x selection hooks.
2828 * xselect.c (Qx_lost_selection_functions)
2829 (Qx_sent_selection_functions): New vars.
2830 (syms_of_xselect): DEFSYM them.
2831 (x_handle_selection_request): Pass Qx_sent_selection_functions
2832 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2833 (x_handle_selection_clear,x_clear_frame_selections):
2834 Pass Qx_lost_selection_functions rather than
2835 Vx_lost_selection_functions to Frun_hook_with_args.
2836
47ea7f44
PE
28372011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2838
ac389d0c 2839 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2840 The old code sometimes used this field without initializing it.
2841
47ea7f44
PE
2842 * alloc.c (gc_sweep): Don't read past end of array.
2843 In theory, the old code could also have corrupted Emacs internals,
2844 though it'd be very unlikely.
2845
bc985c87
AS
28462011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2847
2848 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2849 argument. (Bug#4026)
bc985c87 2850
0cf34688
LMI
28512011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2852
b3dadd76
LMI
2853 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2854 key" (bug#4257).
2855
0cf34688
LMI
2856 * window.c (Fset_window_start): Doc fix (bug#4199).
2857 (Fset_window_hscroll): Ditto.
2858
270768cd
PE
28592011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2860
077e3dda 2861 Fix minor new problems caught by GCC 4.6.1.
270768cd 2862 * term.c (init_tty): Remove unused local.
490011a6 2863 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2864 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2865 not used otherwise.
270768cd 2866
b1f58454
CY
28672011-07-12 Chong Yidong <cyd@stupidchicken.com>
2868
2869 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2870
22b9578d
LMI
28712011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2872
6e70ab07
LMI
2873 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2874 are the mini-buffer and the echo area (bug#3320).
2875
22b9578d
LMI
2876 * term.c (init_tty): Remove support for supdup, c10 and perq
2877 terminals, which are no longer supported (bug#1482).
2878
8974cc9f
JB
28792011-07-10 Johan Bockgård <bojohan@gnu.org>
2880
2881 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2882
a560d974
JD
28832011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2884
2885 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2886 for non-popups (Bug#3642).
2887
1dae0f0a
AS
28882011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2889
268c2c36 2890 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2891 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2892 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2893 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2894 * data.c (fmod): Likewise.
2895 * dispnew.c (swap_glyphs_in_rows): Likewise.
2896 * emacs.c (memory_warning_signal): Likewise.
2897 * floatfns.c (float_error): Likewise.
2898 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2899 (otf_open, font_otf_capability, generate_otf_features)
2900 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2901 Likewise.
2902 * image.c (pbm_read_file): Likewise.
2903 * indent.c (string_display_width): Likewise.
2904 * intervals.c (check_for_interval, search_for_interval)
2905 (inc_interval_count, count_intervals, root_interval)
2906 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2907 * lread.c (defalias): Likewise.
268c2c36 2908 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2909 * regex.c (set_image_of_range_1, set_image_of_range)
2910 (regex_grow_registers): Likewise.
2911 * sysdep.c (strerror): Likewise.
2912 * termcap.c (valid_filename_p, tprint, main): Likewise.
2913 * tparam.c (main): Likewise.
2914 * unexhp9k800.c (run_time_remap, save_data_space)
2915 (update_file_ptrs, read_header, write_header, calculate_checksum)
2916 (copy_file, copy_rest, display_header): Likewise.
2917 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2918 Likewise.
2919 * xdisp.c (check_it): Likewise.
2920 * xfaces.c (register_color, unregister_color, unregister_colors):
2921 Likewise.
2922 * xfns.c (print_fontset_result): Likewise.
2923 * xrdb.c (member, fatal, main): Likewise.
2924
99033785
PE
29252011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2926
2927 Fix minor problems found by static checking (Bug#9031).
2928 * chartab.c (char_table_set_range, map_sub_char_table):
2929 Remove unused locals.
2930 (uniprop_table): Now static.
2931 * composite.c (_work_char): Remove unused static var.
2932
9cb2ac56
JB
29332011-07-09 Juanma Barranquero <lekktu@gmail.com>
2934
2935 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2936
f25661f0
JD
29372011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2938
2939 * gtkutil.c (qttip_cb): Remove code without function.
2940
8278c4fe
EZ
29412011-07-09 Eli Zaretskii <eliz@gnu.org>
2942
2943 * w32.c (pthread_sigmask): New stub.
2944
1692ae2d 29452011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2946
8a6ebd58 2947 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2948 sigprocmask is portable only for single-threaded applications, and
2949 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2950 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2951 (LIBES): Use it.
2952 * callproc.c (Fcall_process):
2953 * process.c (create_process):
2954 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2955 Use pthread_sigmask, not sigprocmask.
123403e4 2956
1b854618
JD
29572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2958
2959 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2960 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2961 wrong (Bug#8591).
2962
3fe4b549
JD
29632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2964
0ce7e563
JD
2965 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2966 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2967 (xg_hide_tooltip): Fix comment.
2968
3fe4b549
JD
2969 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2970 in registerServicesMenuSendTypes.
2971 (validRequestorForSendType): Don't check ns_return_types.
2972
2973 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2974 ns_return_type.
2975
5df75e47
JR
29762011-07-08 Jason Rumney <jasonr@gnu.org>
2977
22610910
JR
2978 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2979 SH_SHOW for hidden windows (Bug#5482).
2980
5df75e47
JR
2981 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2982 frame struct members of non-existent frames (Bug#6284).
2983
699c10bd
JD
29842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2985
4393663b
JD
2986 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2987 variable firstTime not needed on OSX >= 10.6.
2988 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2989 >= 10.5. Use setKnobProportion, setDoubleValue.
2990
2991 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2992 (MAC_OS_X_VERSION_10_5): Define if not defined.
2993 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2994 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2995 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2996
2997 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2998 cString and lossyCString on OSX >= 10.4
2999
3000 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3001 sizeToFit on OSX >= 10.2.
3002
3003 * nsimage.m (allocInitFromFile): Don't use deprecated method
3004 bestRepresentationForDevice on OSX >= 10.6.
3005
3006 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3007 to avoid warning.
3008
3009 * emacs.c: Declare unexec_init_emacs_zone.
3010
a63e0781
JD
3011 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3012
699c10bd
JD
3013 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3014
3015 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3016 on svcsMenu (Bug#8842).
3017
3018 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3019 ns_return_types.
3020 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3021
3022 * nsterm.m (QUTF8_STRING): Declare.
3023 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3024 (validRequestorForSendType): Return type is (id).
3025 Change indexOfObjectIdenticalTo to indexOfObject.
3026 Check if we have local selection before returning self (Bug#8842).
3027 (writeSelectionToPasteboard): Put local selection into paste board
3028 if we have a local selection (Bug#8842).
3029 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3030
3031 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3032 (ns_get_local_selection): Declare.
3033
54e10184
LMI
30342011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3035
9888ff71
LMI
3036 * keymap.c (describe_map_tree): Don't insert a double newline at
3037 the end of the buffer (bug#1169) and return whether we inserted
3038 something.
3039
54e10184
LMI
3040 * callint.c (Fcall_interactively): Change "reading args" to
3041 "providing args" to try to clarify what it does (bug#1010).
3042
15fa4783
KH
30432011-07-07 Kenichi Handa <handa@m17n.org>
3044
3045 * composite.c (composition_compute_stop_pos): Ignore a static
3046 composition starting before CHARPOS (Bug#8915).
3047
3048 * xdisp.c (handle_composition_prop): Likewise.
3049
a8815b00
EZ
30502011-07-07 Eli Zaretskii <eliz@gnu.org>
3051
3052 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3053 (Bug#9015)
3054
ef7b981d 30552011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3056
3057 * character.h (unicode_category_t): New enum type.
3058
3059 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3060 (Qchar_code_property_table): New variable.
3061 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3062 (UNIPROP_COMPRESSED_FORM_P): New macros.
3063 (char_table_ascii): Uncompress the compressed values.
3064 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3065 Uncompress the compressed values.
ac389d0c 3066 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3067 (char_table_ref_and_range): Uncompress the compressed values.
3068 (sub_char_table_set): New arg is_uniprop. Callers changed.
3069 Uncompress the compressed values.
3070 (sub_char_table_set_range): Args changed. Callers changed.
3071 (char_table_set_range): Adjuted for the above change.
3072 (map_sub_char_table): Delete args default_val and parent. Add arg
3073 top. Give decoded values to a Lisp function.
640c8776 3074 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3075 values to a Lisp function. Gcpro more variables.
3076 (uniprop_table_uncompress)
3077 (uniprop_decode_value_run_length): New functions.
3078 (uniprop_decoder, uniprop_decoder_count): New variables.
3079 (uniprop_get_decoder, uniprop_encode_value_character)
3080 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3081 New functions.
3082 (uniprop_encoder, uniprop_encoder_count): New variables.
3083 (uniprop_get_encoder, uniprop_table)
3084 (Funicode_property_table_internal, Fget_unicode_property_internal)
3085 (Fput_unicode_property_internal): New functions.
3086 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3087 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3088 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3089 char-code-property-alist.
3090
640c8776 3091 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3092 Vunicode_category_table.
3093
640c8776 3094 * font.c (font_range): Adjust for the change of
c805dec0
KH
3095 Vunicode_category_table.
3096
76b397fb
DN
30972011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3098
3099 * m/iris4d.h: Remove file, move contents ...
3100 * s/irix6-5.h: ... here.
3101
22b4128e
PE
31022011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3105 * alloc.c (mark_buffer):
3106 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3107 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3108 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3109 This isn't true in general, and it's particularly not true
3110 if Emacs is configured with --with-wide-int.
3111 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3112 New macros, used in the buffer.c change.
3113
869795d6
JD
31142011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3115
3116 * xsettings.c: Use both GConf and GSettings if both are available.
3117 (store_config_changed_event): Add comment.
3118 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3119 (store_tool_bar_style_changed): New functions.
5e617bc2 3120 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3121 (struct xsettings): Move font inside HAVE_XFT.
3122 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3123 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3124 Move inside HAVE_XFT.
640c8776 3125 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3126 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3127 also.
3128 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3129 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3130 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3131 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3132 (parse_settings): Move check for font inside HAVE_XFT.
3133 (read_settings, apply_xft_settings): Add comment.
3134 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3135 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3136 call store_font_name_changed.
3137 (xft_settings_event): Add comment.
3138 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3139 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3140 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3141 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3142 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3143 (xsettings_get_system_font, xsettings_get_system_normal_font):
3144 Add comment.
869795d6 3145
d8ed26bd
PE
31462011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3147
3148 Random fixes. E.g., (random) never returned negative values.
3149 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3150 subseconds part to the entropy, as that's a bit more random.
3151 Prefer signed to unsigned, since the signedness doesn't matter and
3152 in general we prefer signed. When given a limit, use a
3153 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3154 latter isn't right if USE_2_TAGS_FOR_INTS.
3155 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3156 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3157
cabf1cac
SM
31582011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3159
3160 * textprop.c (text_property_stickiness):
3161 Obey Vtext_property_default_nonsticky.
3162 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3163 * w32fns.c (syms_of_w32fns):
3164 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3165
6e9b2be9
PE
31662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3169 This is more efficient than Ffile_directory_p and avoids a minor race.
3170
90186c68
LMI
31712011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3172
7c301272
LMI
3173 * buffer.c (Foverlay_put): Say what the return value is
3174 (bug#7835).
3175
c4f2d8d4
LMI
3176 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3177 is a directory before asking whether to use the file name
3178 (bug#7564).
ad637907
LMI
3179 (barf_or_query_if_file_exists): Make the "File is a directory"
3180 error be more correct.
c4f2d8d4 3181
90186c68
LMI
3182 * fns.c (Frequire): Remove the mention of the .gz files, since
3183 that's installation-specific, but keep the mention of
3184 `get-load-suffixes'.
3185
da64016e
PE
31862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3187
3188 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3189 Report string overflow if the output is too long.
3190
7d47b580
JB
31912011-07-04 Juanma Barranquero <lekktu@gmail.com>
3192
a555cb87
JB
3193 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3194 (syms_of_gnutls): Remove duplicate DEFSYM for
3195 Qgnutls_bootprop_verify_hostname_error, an error for
3196 Qgnutls_bootprop_verify_error (which is no longer used).
3197
7d47b580
JB
3198 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3199 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3200 Also (re)move comments that are misplaced or no longer relevant.
3201
1e49bfab
LMI
32022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3203
3204 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3205
1485f4c0
CY
32062011-07-03 Chong Yidong <cyd@stupidchicken.com>
3207
3208 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3209 and background color parameters if they have been changed.
3210
a9ab721e
LMI
32112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3212
3213 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3214
cf7cff57
PE
32152011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3216
2e13213d
PE
3217 * xsettings.c (SYSTEM_FONT): Define only when used.
3218 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3219
cf7cff57
PE
3220 * keymap.c (access_keymap_1): Now static.
3221
7a8e04f7
CY
32222011-07-02 Chong Yidong <cyd@stupidchicken.com>
3223
3224 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3225 leave any prefix arg for the up event (Bug#1586).
3226
61352f62
LMI
32272011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3228
69bb1ef7
LMI
3229 * lread.c (syms_of_lread): Mention single symbols defined by
3230 `defvar' or `defconst' (bug#7154).
3231
61352f62 3232 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3233 (Frequire): Mention get-load-suffixes.
61352f62 3234
28545e04
MR
32352011-07-02 Martin Rudalics <rudalics@gmx.at>
3236
3237 * window.h (window): Remove clone_number slot.
3238 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3239 Remove.
3240 (make_parent_window, make_window, saved_window)
3241 (Fset_window_configuration, save_window_save): Don't deal with
3242 clone numbers.
3243 * buffer.c (Qclone_number): Remove declaration.
3244 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3245
3349e122
SM
32462011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3247
3248 Add multiple inheritance to keymaps.
3249 * keymap.c (Fmake_composed_keymap): New function.
3250 (Fset_keymap_parent): Simplify.
3251 (fix_submap_inheritance): Remove.
3252 (access_keymap_1): New function extracted from access_keymap to handle
3253 embedded parents and handle lists of maps.
3254 (access_keymap): Use it.
3255 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3256 (Fcopy_keymap): Handle embedded parents.
3257 (Fcommand_remapping, define_as_prefix): Simplify.
3258 (Fkey_binding): Simplify.
3259 (syms_of_keymap): Move minibuffer-local-completion-map,
3260 minibuffer-local-filename-completion-map,
3261 minibuffer-local-must-match-map, and
3262 minibuffer-local-filename-must-match-map to Elisp.
3263 (syms_of_keymap): Defsubr make-composed-keymap.
3264 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3265 (parse_menu_item): Trivial simplification.
3266
3279eb87
GM
32672011-07-01 Glenn Morris <rgm@gnu.org>
3268
3269 * Makefile.in (SETTINGS_LIBS): Fix typo.
3270
4550efdf
KI
32712011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3272
3273 * coding.c (Fencode_coding_string): Record the last coding system
3274 used, as the function doc string says (bug#8738).
3275
0949d2b6
JD
32762011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3277
3278 * xsettings.c (store_monospaced_changed): Take new font as arg and
3279 check for change against current_mono_font.
3280 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3281 (emacs_settings_constructor, emacs_settings_get_property)
3282 (emacs_settings_set_property, emacs_settings_class_init)
3283 (emacs_settings_init, gsettings_obj): Remove.
3284 (something_changedCB): New function for HAVE_GSETTINGS.
3285 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3286 with value as argument.
3287 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3288 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3289 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3290 "changed".
3291
3292 * xgselect.c: Add defined (HAVE_GSETTINGS).
3293 (xgselect_initialize): Ditto.
3294
3295 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3296 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3297 xg_select.
3298
bbc6b304
PE
32992011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 * eval.c (struct backtrace): Simplify and port the data structure.
3302 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3303 signed bit field, as this assumption is not portable and it makes
3304 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3305 "char debug_on_exit : 1" as this is not portable either; instead,
3306 use the portable "unsigned int debug_on_exit : 1". Remove unused
3307 member evalargs. Remove obsolete comments about cc bombing out.
3308
9851bfc5
JD
33092011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3310
51bb811f 3311 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3312 Let HAVE_GSETTINGS override HAVE_GCONF.
3313 (store_monospaced_changed): New function.
3314 (EMACS_SETTINGS): A new type derived from GObject to handle
3315 GSettings notifications.
3316 (emacs_settings_constructor, emacs_settings_get_property)
3317 (emacs_settings_set_property, emacs_settings_class_init):
3318 New functions.
3319 (gsettings_client, gsettings_obj): New variables.
3320 (GSETTINGS_SCHEMA): New define.
3321 (something_changedCB): Call store_monospaced_changed.
3322 (init_gsettings): New function.
3323 (xsettings_initialize): Call init_gsettings.
3324 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3325 to NULL.
3326
640c8776 3327 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3328 GCONF_CFLAGS/LIBS.
3329
5386012d
MR
33302011-06-29 Martin Rudalics <rudalics@gmx.at>
3331
3332 * window.c (resize_root_window, grow_mini_window)
3333 (shrink_mini_window): Rename Qresize_root_window to
3334 Qwindow_resize_root_window and Qresize_root_window_vertically to
3335 Qwindow_resize_root_window_vertically.
3336
f13e0b08
PE
33372011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3338
3339 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3340
94515237
JB
33412011-06-27 Juanma Barranquero <lekktu@gmail.com>
3342
3343 * makefile.w32-in: Redesign dependencies so they reflect more
3344 clearly which files are directly included by each source file,
3345 and not through other includes.
3346
e43b6e43
MR
33472011-06-27 Martin Rudalics <rudalics@gmx.at>
3348
3349 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3350 (sort_overlays, overlay_strings): When an overlay's clone number
3351 matches the window's clone number process the overlay even if
3352 the overlay's window property doesn't match the current window.
3353
d68443dc
MR
3354 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3355 (Fwindow_hchild): Rename to Fwindow_left_child.
3356 (Fwindow_next): Rename to Fwindow_next_sibling.
3357 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3358 (resize_window_check): Rename to window_resize_check.
3359 (resize_window_apply): Rename to window_resize_apply.
3360 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3361 (Fdelete_other_windows_internal, resize_frame_windows)
3362 (Fsplit_window_internal, Fdelete_window_internal)
3363 (grow_mini_window, shrink_mini_window)
3364 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3365
c7e73be5
JD
33662011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3367
3368 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3369 (emacs_fixed_set_min_size): Remove.
3370 (emacs_fixed_new): Take frame as argument.
3371
3372 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3373 (_EmacsFixedPrivate): Remove minwidth/height.
3374 Add struct frame *f.
3375 (emacs_fixed_init): Initialize priv->f.
3376 (get_parent_class, emacs_fixed_set_min_size): Remove.
3377 (emacs_fixed_new): Set priv->f to argument.
3378 (emacs_fixed_get_preferred_width)
3379 (emacs_fixed_get_preferred_height): Use min_width/height from
3380 frames size_hint to set minimum and natural (Bug#8919).
3381 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3382 and use min_width/height from frames size_hint to set
3383 min_width/height (Bug#8919).
3384
3385 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3386 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3387 Fix indentation.
c7e73be5 3388
cf99dcf8
EZ
33892011-06-26 Eli Zaretskii <eliz@gnu.org>
3390
3391 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3392 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3393 called at ZV.
3394
029529ac
CY
33952011-06-26 Chong Yidong <cyd@stupidchicken.com>
3396
3397 * process.c (wait_reading_process_output): Bypass select if
3398 waiting for a cell while ignoring keyboard input, and input is
3399 pending. Suggested by Jan Djärv (Bug#8869).
3400
7a7ef429
PE
34012011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 Use gnulib's dup2 module instead of rolling our own.
3404 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3405
11fdef7d 34062011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3407
3408 * dispnew.c (scrolling_window): Before scrolling, turn off a
3409 mouse-highlight in the window being scrolled.
3410
cd3520a4
JB
34112011-06-24 Juanma Barranquero <lekktu@gmail.com>
3412
3413 Move DEFSYM to lisp.h and use everywhere.
3414
3415 * character.h (DEFSYM): Move declaration...
3416 * lisp.h (DEFSYM): ...here.
3417
3418 * gnutls.c:
3419 * minibuf.c:
3420 * w32menu.c:
3421 * w32proc.c:
3422 * w32select.c: Don't include character.h.
3423
3424 * alloc.c (syms_of_alloc):
3425 * buffer.c (syms_of_buffer):
3426 * bytecode.c (syms_of_bytecode):
3427 * callint.c (syms_of_callint):
3428 * casefiddle.c (syms_of_casefiddle):
3429 * casetab.c (init_casetab_once):
3430 * category.c (init_category_once, syms_of_category):
3431 * ccl.c (syms_of_ccl):
3432 * cmds.c (syms_of_cmds):
3433 * composite.c (syms_of_composite):
3434 * dbusbind.c (syms_of_dbusbind):
3435 * dired.c (syms_of_dired):
3436 * dispnew.c (syms_of_display):
3437 * doc.c (syms_of_doc):
3438 * editfns.c (syms_of_editfns):
3439 * emacs.c (syms_of_emacs):
3440 * eval.c (syms_of_eval):
3441 * fileio.c (syms_of_fileio):
3442 * fns.c (syms_of_fns):
3443 * frame.c (syms_of_frame):
3444 * fringe.c (syms_of_fringe):
3445 * insdel.c (syms_of_insdel):
3446 * keymap.c (syms_of_keymap):
3447 * lread.c (init_obarray, syms_of_lread):
3448 * macros.c (syms_of_macros):
3449 * msdos.c (syms_of_msdos):
3450 * print.c (syms_of_print):
3451 * process.c (syms_of_process):
3452 * search.c (syms_of_search):
3453 * sound.c (syms_of_sound):
3454 * syntax.c (init_syntax_once, syms_of_syntax):
3455 * terminal.c (syms_of_terminal):
3456 * textprop.c (syms_of_textprop):
3457 * undo.c (syms_of_undo):
3458 * w32.c (globals_of_w32):
3459 * window.c (syms_of_window):
3460 * xdisp.c (syms_of_xdisp):
3461 * xfaces.c (syms_of_xfaces):
3462 * xfns.c (syms_of_xfns):
3463 * xmenu.c (syms_of_xmenu):
3464 * xsettings.c (syms_of_xsettings):
3465 * xterm.c (syms_of_xterm): Use DEFSYM.
3466
4228cf16
TZ
34672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3468
cd3520a4 3469 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3470
7fcccf1e
PE
34712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3472
7efb4e0e
PE
3473 Integer and buffer overflow fixes (Bug#8873).
3474
ff5844ad
PE
3475 * print.c (printchar, strout): Check for string overflow.
3476 (PRINTPREPARE, printchar, strout):
3477 Don't set size unless allocation succeeds.
3478
90532f02
PE
3479 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3480 for sizes. Check for string overflow more accurately.
3481 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3482
6d84508d
PE
3483 * macros.c: Integer and buffer overflow fixes.
3484 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3485 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3486 Use ptrdiff_t, not int, for sizes.
3487 Don't increment bufsize until after realloc succeeds.
3488 Check for size-calculation overflow.
3489 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3490
437b2cb4
PE
3491 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3492
8b9ac8b4
PE
3493 * lread.c: Integer overflow fixes.
3494 (read_integer): Radix is now EMACS_INT, not int,
3495 to improve quality of diagnostics for out-of-range radices.
3496 Calculate buffer size correctly for out-of-range radices.
3497 (read1): Check for integer overflow in radices, and in
3498 read-circle numbers.
82cb60d3
PE
3499 (read_escape): Avoid int overflow.
3500 (Fload, openp, read_buffer_size, read1)
3501 (substitute_object_recurse, read_vector, read_list, map_obarray):
3502 Use ptrdiff_t, not int, for sizes.
3503 (read1): Use EMACS_INT, not int, for sizes.
20270765 3504 Check for size overflow.
8b9ac8b4 3505
7fcccf1e
PE
3506 * image.c (cache_image): Check for size arithmetic overflow.
3507
bfbbd7e7
PE
3508 * lread.c: Integer overflow issues.
3509 (saved_doc_string_size, saved_doc_string_length)
3510 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3511 Now ptrdiff_t, not int.
3512 (read1): Don't assume doc string length fits in int. Check for
3513 out-of-range doc string lengths.
3514 (read_list): Don't assume file position fits in int.
39019e54 3515 (read_escape): Check for hex character overflow.
bfbbd7e7 3516
4e323265
LL
35172011-06-22 Leo Liu <sdl.web@gmail.com>
3518
3519 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3520 Move to minibuffer.el.
3521
85fece3e
PE
35222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3523
20b84ce9 3524 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3525 The following patches are for when GLYPH_DEBUG && !XASSERT.
3526 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3527 * dispnew.c (flush_stdout):
3528 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3529 Mark as externally visible.
3530 * dispnew.c (check_window_matrix_pointers): Now static.
3531 * dispnew.c (window_to_frame_vpos):
3532 * xfns.c (unwind_create_frame):
3533 * xterm.c (x_check_font): Remove unused local.
3534 * scroll.c (CHECK_BOUNDS):
3535 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3536 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3537 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3538 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3539 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3540 Now static.
3541 (debug_method_add): Use va_list and vsprintf rather than relying
3542 on undefined behavior with wrong number of arguments.
3543 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3544 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3545 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3546 since we're not interested in debugging glyphs with old libraries.
3547 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3548 GCC 4.6.0's static checking.
3549
0766b489
PE
35502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3551
31fd4b32
PE
3552 Integer overflow and signedness fixes (Bug#8873).
3553 A few related buffer overrun fixes, too.
3554
b79e8648
PE
3555 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3556
0766b489
PE
3557 * dispextern.h (struct face.stipple):
3558 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3559 (x_bitmap_mask, x_allocate_bitmap_record)
3560 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3561 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3562 (x_create_bitmap_from_xpm_data):
3563 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3564 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3565 (.bitmaps_last):
3566 * xfaces.c (load_pixmap):
3567 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3568 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3569 (.bitmaps_last, struct x_output.icon_bitmap):
3570 Use ptrdiff_t, not int, for bitmap indexes.
3571 (x_allocate_bitmap_record): Check for size overflow.
3572 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3573
b081724f
PE
3574 Use ptrdiff_t, not int, for overlay counts.
3575 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3576 * editfns.c (overlays_around, get_pos_property):
3577 * textprop.c (get_char_property_and_overlay):
3578 * xdisp.c (next_overlay_change, note_mouse_highlight):
3579 * xfaces.c (face_at_buffer_position):
21514da7
PE
3580 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3581 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3582 (Fnext_overlay_change, Fprevious_overlay_change)
3583 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3584 Use ptrdiff_t, not int, for sizes.
21514da7 3585 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3586
3de73e5e
PE
3587 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3588
2606c57b
PE
3589 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3590 (x_session_initialize): Do not assume string length fits in int.
3591
aaafe47a
PE
3592 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3593 This is unlikely, but can occur if DPI is outlandish.
3594
2674ddc8 3595 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3596 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3597
28154962
PE
3598 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3599 * xrdb.c (magic_file_p, search_magic_path):
3600 Omit last arg SUFFIX; it was always 0. All callers changed.
3601 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3602
7de51af5
PE
3603 * xfont.c (xfont_match): Avoid need for strlen.
3604
25ed6cc3
PE
3605 * xfns.c: Don't assume strlen fits in int.
3606 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3607
4eab31dd
PE
3608 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3609 not unsigned long, as we prefer signed integers. All callers changed.
3610 Detect integer overflow in repeat count.
3611 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3612 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3613
171e2a58
PE
3614 * termcap.c: Don't assume sizes fit in int and never overflow.
3615 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3616 (gobble_line): Check for size-calculation overflow.
3617
ad39faca 3618 * minibuf.c (Fread_buffer):
6e5bb2dc 3619 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3620 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3621 Don't assume string length fits in int.
3622
52c61c22 3623 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3624 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3625
b5b8c9e5
PE
3626 * font.c: Don't assume string length fits in int.
3627 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3628 Use ptrdiff_t, not int.
ccd6111c
PE
3629 (font_intern_prop): Don't assume string length fits in int.
3630 Don't assume integer property fits in fixnum.
3631 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3632
882f0d81 3633 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3634 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3635 Reformulate so as not to need the command string.
3636 Invoke gzip -cd rather than gunzip, as it's more portable.
3637 (lock_info_type, lock_file_1, lock_file):
3638 Don't assume pid_t and time_t fit in unsigned long.
3639 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3640 (current_lock_owner): Prefer signed type for sizes.
3641 Use memcpy, not strncpy, where memcpy is what is really wanted.
3642 Don't assume (via atoi) that time_t and pid_t fit in int.
3643 Check for time_t and/or pid_t out of range, e.g., via a network share.
3644 Don't alloca where an auto var works fine.
3645
93f4cf88
PE
3646 * fileio.c: Fix some integer overflow issues.
3647 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3648 Don't assume string length fits in int.
3649 (directory_file_name): Don't assume string length fits in long.
3650 (make_temp_name): Don't assume pid fits in int, or that its print
3651 length is less than 20.
3652
f3e92b69
PE
3653 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3654
1bfdaf10
PE
3655 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3656
35016e9a
PE
3657 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3658
3d1e65a1
PE
3659 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3660 We prefer signed integers, even for size calculations.
3661
0b963a93
PE
3662 * emacs.c: Don't assume string length fits in 'int'.
3663 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3664 (main): Don't invoke strlen when not needed.
3665
573f4b54
PE
3666 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3667 (XD_DEBUG_MESSAGE): Don't waste a byte.
3668
989f33ba
PE
3669 * callproc.c (getenv_internal_1, getenv_internal)
3670 (Fgetenv_internal):
965d34eb
PE
3671 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3672
e4d29b33
PE
3673 * lread.c (invalid_syntax): Omit length argument.
3674 All uses changed. This doesn't fix a bug, but it simplifies the
3675 code away from its former Hollerith-constant appearance, and it's
3676 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3677 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3678
eb49b136
PE
3679 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3680 This didn't break anything, but it didn't help either.
3681 It's confusing to put a bogus integer in a place where the actual
3682 value does not matter.
9f62aeb1 3683 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3684 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3685
15375a22
PE
3686 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3687 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3688 implementation.
b61cc01c
PE
3689 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3690 We prefer signed types, and the value cannot exceed the EMACS_INT
3691 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3692 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3693 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3694 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3695
53b2623d
PE
3696 * indent.c (sane_tab_width): New function.
3697 (current_column, scan_for_column, Findent_to, position_indentation)
3698 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3699 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3700
51cab52b 3701 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3702
f2ed8a70
PE
3703 * lisp.h (lint_assume): New macro.
3704 * composite.c (composition_gstring_put_cache):
3705 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3706
abe80cc6
PE
3707 * editfns.c, insdel.c:
3708 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3709
b02c740e
PE
3710 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3711
ebc96716
PE
3712 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3713
b4e50fa0 3714 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3715 Use much-faster test for byte-length change.
311d5d7c 3716 Don't assume string byte-length fits in 'int'.
a4cf38e4 3717 Check that character arg fits in 'int'.
85461888 3718 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3719
c0c1ee9f
PE
3720 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3721
a498d7f4
PE
3722 * fns.c (concat): Catch string overflow earlier.
3723 Do not rely on integer wraparound.
3724
51cab52b
PE
3725 * dispextern.h (struct it.overlay_strings_charpos)
3726 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3727 * xdisp.c (forward_to_next_line_start)
3728 (back_to_previous_visible_line_start)
3729 (reseat_at_next_visible_line_start, next_element_from_buffer):
3730 Don't arbitrarily truncate the value of 'selective' to int.
3731
76031fad
PE
3732 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3733
5eb55db9
PE
3734 * composite.c: Don't truncate sizes to 'int'.
3735 (composition_gstring_p, composition_reseat_it)
3736 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3737 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3738 not EMACS_UINT, for indexes.
5eb55db9 3739
0703a717
PE
3740 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3741
d6202519
PE
3742 * buffer.c: Include <verify.h>.
3743 (struct sortvec.priority, struct sortstr.priority):
8961a454 3744 Now EMACS_INT, not int.
c20998a7 3745 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3746 (struct sortstr.size, record_overlay_string)
3747 (struct sortstrlist.size, struct sortlist.used):
3748 Don't truncate size to int.
3749 (record_overlay_string): Check for size-calculation overflow.
d6202519 3750 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3751
d5a19415
JM
37522011-06-22 Jim Meyering <meyering@redhat.com>
3753
029529ac 3754 Don't leak an XBM-image-sized buffer
d5a19415
JM
3755 * image.c (xbm_load): Free the image buffer after using it.
3756
a9041e6c
PE
37572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3758
3759 Port to Sun C.
3760 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3761 that Sun C diagnosed.
3762 * fns.c (secure_hash): Fix pointer signedness issue.
3763 * intervals.c (static_offset_intervals): New function.
3764 (offset_intervals): Use it.
3765
7f3f739f
LL
37662011-06-21 Leo Liu <sdl.web@gmail.com>
3767
3768 * deps.mk (fns.o):
3769 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3770 sha512.h.
3771
3772 * fns.c (secure_hash): Rename from crypto_hash_function and change
3773 the first arg to accept symbols.
5b66d427 3774 (Fsecure_hash): New primitive.
7f3f739f
LL
3775 (syms_of_fns): New symbols.
3776
76147d94
DD
37772011-06-20 Deniz Dogan <deniz@dogan.se>
3778
3779 * process.c (Fset_process_buffer): Clarify return value in
3780 docstring.
3781
7d7d0045
CY
37822011-06-18 Chong Yidong <cyd@stupidchicken.com>
3783
3784 * dispnew.c (add_window_display_history): Use BVAR.
3785
3786 * xdisp.c (debug_method_add): Use BVAR.
3787 (check_window_end, dump_glyph_matrix, dump_glyph)
3788 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3789
3790 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3791 Likewise.
3792
3793 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3794 check till after the cache is created in init_frame_faces.
3795
ff2bc410
SM
37962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3797
3798 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3799
28177add
PE
38002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3801
dd3482fe
PE
3802 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3803 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3804 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3805
393d71f3 3806 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3807 * fileio.c (Finsert_file_contents):
3808 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3809 Remove the old (too-loose) buffer overflow checks.
3810 They weren't needed, since make_gap checks for buffer overflow.
3811 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3812 The old code merely checked for Emacs fixnum overflow, and relied
3813 on undefined (wraparound) behavior. The new code avoids undefined
3814 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3815
2e6813b0 3816 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3817 Tune. Don't use wider integers than needed. Don't use alloca.
3818 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3819
599a9e4f
PE
3820 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3821
99561444
PE
3822 * insdel.c, lisp.h (buffer_overflow): New function.
3823 (insert_from_buffer_1, replace_range, replace_range_2):
3824 * insdel.c (make_gap_larger):
3825 * editfns.c (Finsert_char):
3826 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3827
28177add
PE
3828 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3829
e69dafad
PE
38302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3831
a7af7fde 3832 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3833
b1c46f02
PE
3834 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3835 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3836
e69dafad
PE
3837 * fileio.c: Don't assume EMACS_INT fits in off_t.
3838 (emacs_lseek): New static function.
3839 (Finsert_file_contents, Fwrite_region): Use it.
3840 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3841
566684ea
PE
3842 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3843
e6966cd6
PE
3844 * fns.c: Don't overflow int when computing a list length.
3845 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3846 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3847 truncation on 64-bit hosts. Check for QUIT every
3848 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3849 faster and is responsive enough.
3850 (Flength): Report an error instead of overflowing an integer.
3851 (Fsafe_length): Return a float if the value is not representable
3852 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3853 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3854 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3855
dd0b0efb
PE
3856 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3857 (header_size, word_size): New constants.
3858 (allocate_vectorlike): Don't check size overflow here.
3859 (allocate_vector): Check it here instead, since this is the only
3860 caller of allocate_vectorlike that could cause overflow.
3861 Check that the new vector's length is representable as a fixnum.
3862
86fe5cfe
PE
3863 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3864 The previous code was bogus. For example, next_almost_prime (32)
3865 returned 39, which is undesirable as it is a multiple of 3; and
3866 next_almost_prime (24) returned 25, which is a multiple of 5 so
3867 why was the code bothering to check for multiples of 7?
3868
80e88859
PE
3869 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3870
4a2f0ad6
PE
3871 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3872
f66c7cf8
PE
3873 Variadic C functions now count arguments with ptrdiff_t.
3874 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3875 Back then I didn't know that the Emacs coding style prefers signed int.
3876 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3877 were being counted with int, which may truncate counts on 64-bit
3878 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3879 * lisp.h (struct Lisp_Subr.function.aMANY)
3880 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3881 Arg counts are now ptrdiff_t, not size_t.
3882 All variadic functions and their callers changed accordingly.
3883 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3884 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3885 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3886 * callint.c (Fcall_interactively): Check arg count for overflow,
3887 to avoid potential buffer overrun. Use signed char, not 'int',
3888 for 'varies' array, so that we needn't bother to check its size
3889 calculation for overflow.
3890 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3891 * eval.c (apply_lambda):
3892 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3893 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3894 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3895
a1759b76
PE
3896 * callint.c (Fcall_interactively): Don't use index var as event count.
3897
d96be9fc
PE
3898 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3899 * mem-limits.h (SIZE): Remove; no longer used.
3900
a690a978 3901 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3902
578c21e6
PE
3903 Remove unnecessary casts.
3904 * xterm.c (x_term_init):
3905 * xfns.c (x_set_border_pixel):
3906 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3907 These aren't needed now that we assume ANSI C.
3908
96f53c6c
PE
3909 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3910 It's more likely to cause problems (due to unsigned overflow)
3911 than to cure them.
3912
83c77d31
PE
3913 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3914
ee2079f1
PE
3915 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3916
6da65536
PE
3917 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3918
7147c4a4
PE
3919 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3920
193e32d9
PE
3921 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3922
e5533da6
PE
3923 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3924
9910e595
PE
3925 GLYPH_CODE_FACE returns EMACS_INT, not int.
3926 * dispextern.h (merge_faces):
3927 * xfaces.c (merge_faces):
01103c44
PE
3928 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3929 Don't assume EMACS_INT fits in int.
9910e595 3930
2638320e
PE
3931 * character.h (CHAR_VALID_P): Remove unused parameter.
3932 * fontset.c, lisp.h, xdisp.c: All uses changed.
3933
045eb8d9
PE
3934 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3935
c1f134b5
PE
3936 * fns.c (concat): Minor tuning based on overflow analysis.
3937 This doesn't fix any bugs. Use int to hold character, instead
3938 of constantly refetching from Emacs object. Use XFASTINT, not
3939 XINT, for value known to be a character. Don't bother comparing
3940 a single byte to 0400, as it's always less.
3941
395fcb93 3942 * floatfns.c (Fexpt):
327eeec8
PE
3943 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3944
abbd3d23
PE
3945 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3946 for characters.
3947
684a03ef
PE
3948 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3949
0fed43f3
PE
3950 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3951 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3952 incorrectly succeed when S was a string, because 4294967386 was
3953 truncated before it was used.
3954
8fd02eb7
PE
3955 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3956 Otherwise, an out-of-range integer could cause undefined behavior
3957 on a 64-bit host.
3958
f8c86b69
PE
3959 * composite.c: Use int, not EMACS_INT, for characters.
3960 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3961 EMACS_INT, for values that are known to be in character range.
3962 This doesn't fix any bugs but is the usual style inside Emacs and
3963 may generate better code on 32-bit machines.
3964
34206dd2
PE
3965 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3966 This is for reasons similar to the recent CHAR_STRING fix.
3967 * charset.c (Fencode_char): Check that character arg is actually
3968 a character. Pass an int to ENCODE_CHAR.
3969 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3970 wider than 'int', as a compile-time check to prevent future regressions
3971 in this area.
3972
c5958d4c 3973 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3974
3975 Make sure a 64-bit char is never passed to CHAR_STRING.
3976 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3977 by silently ignoring the top 32 bits, allowing some values
3978 that were far too large to be valid characters.
3979 * character.h: Include <verify.h>.
3980 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3981 arguments are no wider than unsigned, as a compile-time check
3982 to prevent future regressions in this area.
3983 * data.c (Faset):
01103c44 3984 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3985 (Fsubst_char_in_region):
3986 * fns.c (concat):
3987 * xdisp.c (decode_mode_spec_coding):
3988 Adjust to CHAR_STRING's new requirement.
3989 * editfns.c (Finsert_char, Fsubst_char_in_region):
3990 * fns.c (concat): Check that character args are actually
3991 characters. Without this test, these functions did the wrong
3992 thing with wildly out-of-range values on 64-bit hosts.
3993
d37ca623
PE
3994 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3995 These casts should not be needed on 32-bit hosts, either.
3996 * keyboard.c (read_char):
3997 * lread.c (Fload): Remove casts to unsigned.
3998
ea204efb
PE
3999 * lisp.h (UNSIGNED_CMP): New macro.
4000 This fixes comparison bugs on 64-bit hosts.
4001 (ASCII_CHAR_P): Use it.
4002 * casefiddle.c (casify_object):
01103c44 4003 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4004 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4005 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4006 * dispextern.h (FACE_FROM_ID):
4007 * keyboard.c (read_char): Use UNSIGNED_CMP.
4008
41cb286c
PE
4009 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4010 not to EMACS_INT, to avoid GCC warning.
4011
4a1b9832
PE
4012 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4013
55daad71
PE
4014 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4015 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4016 isn't needed on 32-bit machines.
8f95c75c 4017
01103c44
PE
4018 * buffer.c (Fgenerate_new_buffer_name):
4019 Use EMACS_INT for count, not int.
0ceccced 4020 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4021
4022 * data.c (Qcompiled_function): Now static.
4023
c6f072e7
PE
4024 * window.c (window_body_lines): Now static.
4025
20ce5912
PE
4026 * image.c (gif_load): Rename local to avoid shadowing.
4027
9c4c5f81
PE
4028 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4029 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4030 * alloc.c (make_save_value): Integer argument is now of type
4031 ptrdiff_t, not int.
4032 (mark_object): Use ptrdiff_t, not int.
4033 * lisp.h (pD): New macro.
4034 * print.c (print_object): Use it.
4035
c0c5c8ae
PE
4036 * alloc.c: Use EMACS_INT, not int, to count objects.
4037 (total_conses, total_markers, total_symbols, total_vector_size)
4038 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4039 (total_free_floats, total_floats, total_free_intervals)
4040 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4041 Now EMACS_INT, not int. All uses changed.
4042 (Fgarbage_collect): Compute overall total using a double, so that
4043 integer overflow is less likely to be a problem. Check for overflow
4044 when converting back to an integer.
5a25e253
PE
4045 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4046 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4047 These were 'int' variables that could overflow on 64-bit hosts;
4048 they were never used, so remove them instead of repairing them.
211a0b2a 4049 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4050 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4051 Previously, this ceilinged at INT_MAX, but that doesn't work on
4052 64-bit machines.
e46bb31a 4053 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4054
c78baabf 4055 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4056 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4057 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4058 when a (possibly-narrower) signed value would do just as well.
4059 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4060
c9d624c6
PE
4061 * alloc.c: Catch some string size overflows that we were missing.
4062 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4063 for convenience in STRING_BYTES_MAX.
4064 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4065 The definition here is exact; the one in lisp.h was approximate.
4066 (allocate_string_data): Check for string overflow. This catches
4067 some instances we weren't catching before. Also, it catches
4068 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4069 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4070 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4071
c9d624c6
PE
4072 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4073 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4074 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4075
353032ce
PE
4076 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4077
2bccce07
PE
4078 * alloc.c (Fmake_string): Check for out-of-range init.
4079
0ac30604
SM
40802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4081
4082 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4083
c195f2de
JD
40842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4085
4086 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4087 xg_get_default_scrollbar_width.
4088
4089 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4090 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4091 (style_changed_cb): Call update_theme_scrollbar_width and call
4092 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4093 all frames (Bug#8505).
4094 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4095 Call gtk_window_set_resizable if HAVE_GTK3.
4096 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4097 and height if HAVE_GTK3 (Bug#8505).
4098 (scroll_bar_width_for_theme): New variable.
4099 (update_theme_scrollbar_width): New function.
4100 (xg_get_default_scrollbar_width): Move code to
4101 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4102 (xg_initialize): Call update_theme_scrollbar_width.
4103
4104 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4105
4106 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4107
e10ac9f1
MR
41082011-06-12 Martin Rudalics <rudalics@gmx.at>
4109
4110 * frame.c (make_frame): Call other_buffer_safely instead of
4111 other_buffer.
4112
4113 * window.c (temp_output_buffer_show): Call display_buffer with
4114 second argument Vtemp_buffer_show_specifiers and reset latter
4115 immediately after the call.
4116 (Vtemp_buffer_show_specifiers): New variable.
4117 (auto_window_vscroll_p, next_screen_context_lines)
4118 (Vscroll_preserve_screen_position): Remove leading asterisks from
4119 doc-strings.
4120
2d3c217e 41212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4122
7b7f97e8 4123 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4124 * buffer.c (Qclone_number): Remove for now, as it's unused.
4125 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4126 (record_buffer): Remove unused local.
4127 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4128 (set_frame_buffer_list): Remove; unused.
4129 * frame.h (other_visible_frames): Remove decl.
4130 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4131 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4132 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4133 if HAVE_GPM.
4134 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4135 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4136 Define only if HAVE_GPM.
4137 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4138 (update_hints_inhibit): Remove; never set. All uses removed.
4139 * widgetprv.h (emacsFrameClassRec): Remove decl.
4140 * window.c (delete_deletable_window): Now returns void, since it
4141 wasn't returning anything.
4142 (compare_window_configurations): Remove unused locals.
4143 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4144 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4145 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4146 the same widths as pointers. This follows up on the 2011-05-06 patch.
4147 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4148 * xterm.h: Likewise.
4149 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4150
1384b89e
JB
41512011-06-12 Juanma Barranquero <lekktu@gmail.com>
4152
4153 * makefile.w32-in: Update dependencies.
4154 (LISP_H): Add lib/intprops.h.
4155
1100a63c
CY
41562011-06-11 Chong Yidong <cyd@stupidchicken.com>
4157
4158 * image.c (gif_load): Add animation frame delay to the metadata.
4159 (syms_of_image): Use DEFSYM. New symbol `delay'.
4160
6198ccd0
MR
41612011-06-11 Martin Rudalics <rudalics@gmx.at>
4162
4163 * window.c (delete_deletable_window): Re-add.
4164 (Fset_window_configuration): Rewrite to handle dead buffers and
4165 consequently deletable windows.
4166 (window_tree, Fwindow_tree): Remove. Supply functionality in
4167 window.el.
4168 (compare_window_configurations): Simplify code.
4169
b6e3633c
AS
41702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4171
1ab0dee5
AS
4172 * image.c (imagemagick_load_image): Fix type mismatch.
4173 (Fimagemagick_types): Likewise.
4174
b6e3633c
AS
4175 * window.h (replace_buffer_in_windows): Declare.
4176
9397e56f
MR
41772011-06-11 Martin Rudalics <rudalics@gmx.at>
4178
4179 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4180 Qclone_number. Remove external declaration of Qdelete_window.
4181 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4182 code.
640c8776
SM
4183 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4184 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4185 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4186 buffer list implementation.
4187 (other_buffer_safely): New function.
4188 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4189 calls to replace_buffer_in_windows and
4190 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4191 if allowed.
4192 (record_buffer): Inhibit quitting and rewrite using quittable
4193 functions. Run Qbuffer_list_update_hook if allowed.
4194 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4195 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4196 Move switch-to-buffer to window.el.
9397e56f
MR
4197 (bury-buffer): Move to window.el.
4198 (Vbuffer_list_update_hook): New variable.
4199
4200 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4201 section.
4202
4203 * window.h (resize_frame_windows): Move up in code.
4204 (Fwindow_frame): Remove EXFUN.
4205 (replace_buffer_in_all_windows): Remove prototype.
4206 (replace_buffer_in_windows_safely): Add prototype.
4207
4208 * window.c: Declare Qdelete_window static again. Move down
4209 declaration of select_count.
4210 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4211 (Fother_window): Move to window.el.
4212 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4213 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4214 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4215 window.el.
4216 (replace_buffer_in_windows): Implement by calling
4217 Qreplace_buffer_in_windows.
4218 (replace_buffer_in_all_windows): Remove with some functionality
4219 moved into replace_buffer_in_windows_safely.
4220 (replace_buffer_in_windows_safely): New function.
4221 (select_window_norecord, select_frame_norecord): Move in front
4222 of run_window_configuration_change_hook. Remove now obsolete
4223 declarations.
640c8776
SM
4224 (Fset_window_buffer): Rewrite doc-string.
4225 Call Qrecord_window_buffer.
9397e56f
MR
4226 (keys_of_window): Move binding for other-window to window.el.
4227
b50691aa
CY
42282011-06-11 Chong Yidong <cyd@stupidchicken.com>
4229
4230 * dispextern.h (struct image): Replace data member, whose int_val
4231 and ptr_val fields were not used by anything, with a single
4232 lisp_val object.
4233
4234 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4235 (gif_clear_image, gif_load, imagemagick_load_image)
4236 (gs_clear_image, gs_load): Callers changed.
4237
3f754b86
PE
42382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4239
cca69397
PE
4240 * buffer.h: Include <time.h>, for time_t.
4241 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4242
109e28d0
PE
4243 Fix minor problems found by static checking.
4244
60737f02
PE
4245 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4246
4b66faf3
PE
4247 Make identifiers static if they are not used in other modules.
4248 * data.c (Qcompiled_function, Qframe, Qvector):
4249 * image.c (QimageMagick, Qsvg):
4250 * minibuf.c (Qmetadata):
4251 * window.c (resize_window_check, resize_root_window): Now static.
4252 * window.h (resize_window_check, resize_root_window): Remove decls.
4253
109e28d0
PE
4254 * window.c (window_deletion_count, delete_deletable_window):
4255 Remove; unused.
46a4ce9e
PE
4256 (window_body_lines): Now static.
4257 (Fdelete_other_windows_internal): Mark vars as initialized.
4258 Make sure 'resize_failed' is initialized.
4259 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4260 (resize_window_apply): Remove unused local.
4261 * window.h (delete_deletable_window): Remove decl.
4262
109e28d0 4263 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4264 (imagemagick_load_image): Fix pointer signedness problem by changing
4265 last arg from unsigned char * to char *. All uses changed.
4266 Also, fix a local for similar reasons.
4267 Remove unused locals. Remove locals to avoid shadowing.
4268 (fn_rsvg_handle_free): Remove; unused.
4269 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4270 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4271
3f754b86
PE
4272 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4273
2547adb1
CY
42742011-06-10 Chong Yidong <cyd@stupidchicken.com>
4275
4276 * image.c (gif_load): Fix omitted cast error introduced by
4277 2011-06-06 change.
4278
2c8e37d4
MR
42792011-06-10 Martin Rudalics <rudalics@gmx.at>
4280
4281 * window.h (resize_proportionally, orig_total_lines)
4282 (orig_top_line): Remove from window structure.
4283 (set_window_height, set_window_width, change_window_heights)
4284 (Fdelete_window): Remove prototypes.
4285 (resize_frame_windows): Remove duplicate declaration.
4286
440a42e3
EZ
42872011-06-10 Eli Zaretskii <eliz@gnu.org>
4288
4289 * window.h (resize_frame_windows, resize_window_check)
4290 (delete_deletable_window, resize_root_window)
4291 (resize_frame_windows): Declare prototypes.
4292
4293 * window.c (resize_window_apply): Make definition be "static" to
4294 match the prototype.
4295
562dd5e9
MR
42962011-06-10 Martin Rudalics <rudalics@gmx.at>
4297
4298 * window.c: Remove declarations of Qwindow_size_fixed,
4299 window_min_size_1, window_min_size_2, window_min_size,
4300 size_window, window_fixed_size_p, enlarge_window, delete_window.
4301 Remove static from declaration of Qdelete_window, it's
4302 temporarily needed by Fbury_buffer.
4303 (replace_window): Don't assign orig_top_line and
4304 orig_total_lines.
4305 (Fdelete_window, delete_window): Remove. Window deletion is
4306 handled by window.el.
640c8776
SM
4307 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4308 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4309 (Fdelete_other_windows): Remove. Deleting other windows is
4310 handled by window.el.
4311 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4312 handled in window.el.
4313 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4314 Window minimum sizes are handled in window.el.
4315 (shrink_windows, size_window, set_window_height)
4316 (set_window_width, change_window_heights, window_height)
4317 (window_width, CURBEG, CURSIZE, enlarge_window)
4318 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4319 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4320 handled in window.el.
4321 (make_dummy_parent): Rename to make_parent_window and give it a
4322 second argument horflag.
4323 (make_window): Don't set resize_proportionally any more.
4324 (Fsplit_window): Remove. Windows are split in window.el.
4325 (save_restore_action, save_restore_orig_size)
4326 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4327 Resize mini windows in window.el.
4328 (grow_mini_window, shrink_mini_window): Implement by calling
4329 Qresize_root_window_vertically, resize_window_check and
4330 resize_window_apply.
640c8776
SM
4331 (saved_window, Fset_window_configuration, save_window_save):
4332 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4333 resize_proportionally.
4334 (window_min_height, window_min_width): Move to window.el.
4335 (keys_of_window): Move bindings for delete-other-windows,
4336 split-window, delete-window and enlarge-window to window.el.
4337
4338 * buffer.c: Temporarily extern Qdelete_window.
4339 (Fbury_buffer): Temporarily call Qdelete_window instead of
4340 Fdelete_window (Fbury_buffer will move to window.el soon).
4341
4342 * frame.c (set_menu_bar_lines_1): Remove code handling
4343 orig_top_line and orig_total_lines.
4344
4345 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4346 set_window_height but set heights directly.
4347 (change_frame_size_1): Use resize_frame_windows.
4348
4349 * xdisp.c (init_xdisp): Don't use set_window_height but set
4350 heights directly.
4351
640c8776
SM
4352 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4353 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4354 run_window_configuration_change_hook.
4355
4356 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4357 instead of change_window_heights and run
4358 run_window_configuration_change_hook.
4359
1a13852e
MR
43602011-06-09 Martin Rudalics <rudalics@gmx.at>
4361
4362 * window.c (replace_window): Rename second argument REPLACEMENT to
4363 NEW. New third argument SETFLAG. Rewrite.
4364 (delete_window, make_dummy_parent): Call replace_window with
4365 third argument 1.
4366 (window_list_1): Move down in code.
4367 (run_window_configuration_change_hook): Move set_buffer part
4368 before select_frame_norecord part in order to unwind correctly.
4369 Rename count1 to count.
4370 (recombine_windows, delete_deletable_window, resize_root_window)
4371 (Fdelete_other_windows_internal)
4372 (Frun_window_configuration_change_hook, make_parent_window)
4373 (resize_window_check, resize_window_apply, Fresize_window_apply)
4374 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4375 (Fdelete_window_internal, Fresize_mini_window_internal):
4376 New functions.
1a13852e
MR
4377 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4378
f3d1777e
MR
43792011-06-08 Martin Rudalics <rudalics@gmx.at>
4380
496e208e
MR
4381 * window.h (window): Add some new members to window structure -
4382 normal_lines, normal_cols, new_total, new_normal, clone_number,
4383 splits, nest, prev_buffers, next_buffers.
4384 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4385 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4386
f3d1777e
MR
4387 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4388 Remove.
496e208e
MR
4389 (make_dummy_parent): Set new members of windows structure.
4390 (make_window): Move down in code. Handle new members of window
4391 structure.
4392 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4393 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4394 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4395 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4396 (Fset_window_next_buffers, Fset_window_clone_number):
4397 New functions.
496e208e
MR
4398 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4399 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4400 Doc-string fixes.
4401 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4402 Argument WINDOW can be now internal window too.
4403 (Fwindow_use_time): Move up in code.
4404 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4405 Rewrite doc-string.
4406 (Fset_window_configuration, saved_window)
4407 (Fcurrent_window_configuration, save_window_save): Handle new
4408 members of window structure.
b9e809c2
MR
4409 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4410 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4411 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4412 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4413 Qget_mru_window, Qresize_root_window,
4414 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4415 Qauto_buffer_name; staticpro them.
f3d1777e 4416
abde8f8c
MR
44172011-06-07 Martin Rudalics <rudalics@gmx.at>
4418
4419 * window.c (Fwindow_total_size, Fwindow_left_column)
4420 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4421 (Fwindow_list_1): New functions.
4422 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4423 (Fwindow_width, Fscroll_left, Fscroll_right):
4424 Use window_body_cols instead of window_box_text_cols.
4425 (delete_window, Fset_window_configuration):
4426 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4427 (delete_all_subwindows): Take a window as argument and not a
4428 structure. Rewrite.
190b47e6
MR
4429 (window_loop): Remove handling of GET_LRU_WINDOW and
4430 GET_LARGEST_WINDOW.
4431 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4432
4433 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4434 window_box_text_cols. delete_all_subwindows now takes a
4435 Lisp_Object as argument.
abde8f8c 4436
640c8776
SM
4437 * indent.c (compute_motion, Fcompute_motion):
4438 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4439
fa8a67e6
MR
4440 * frame.c (delete_frame): Call delete_all_subwindows with root
4441 window as argument.
4442
a54e3482
DC
44432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4444
4445 * fns.c (Fputhash): Document return value.
4446
60002bf5
CY
44472011-06-06 Chong Yidong <cyd@stupidchicken.com>
4448
4449 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4450
0c671da6 44512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4452
b862a52a 4453 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4454
be44ca6c
PE
4455 Check for overflow when converting integer to cons and back.
4456 * charset.c (Fdefine_charset_internal, Fdecode_char):
4457 Use cons_to_unsigned to catch overflow.
4458 (Fencode_char): Use INTEGER_TO_CONS.
4459 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4460 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4461 * data.c (long_to_cons, cons_to_long): Remove.
4462 (cons_to_unsigned, cons_to_signed): New functions.
4463 These signal an error for invalid or out-of-range values.
4464 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4465 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4466 * font.c (Ffont_variation_glyphs):
4467 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4468 * lisp.h: Include <intprops.h>.
4469 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4470 (cons_to_signed, cons_to_unsigned): New decls.
4471 (long_to_cons, cons_to_long): Remove decls.
4472 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4473 (Fprimitive_undo): Use CONS_TO_INTEGER.
4474 * xfns.c (Fx_window_property): Likewise.
4475 * xselect.c: Include <limits.h>.
4476 (x_own_selection, selection_data_to_lisp_data):
4477 Use INTEGER_TO_CONS.
4478 (x_handle_selection_request, x_handle_selection_clear)
4479 (x_get_foreign_selection, Fx_disown_selection_internal)
4480 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4481 (lisp_data_to_selection_data): Use cons_to_unsigned.
4482 (x_fill_property_data): Use cons_to_signed.
4483 Report values out of range.
4484
d1f3d2af
PE
4485 Check for buffer and string overflow more precisely.
4486 * buffer.h (BUF_BYTES_MAX): New macro.
4487 * lisp.h (STRING_BYTES_MAX): New macro.
4488 * alloc.c (Fmake_string):
4489 * character.c (string_escape_byte8):
4490 * coding.c (coding_alloc_by_realloc):
4491 * doprnt.c (doprnt):
4492 * editfns.c (Fformat):
4493 * eval.c (verror):
4494 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4495 since they may not be the same number.
4496 * editfns.c (Finsert_char):
4497 * fileio.c (Finsert_file_contents):
4498 Likewise for BUF_BYTES_MAX.
4499
dd52fcea
PE
4500 * image.c: Use ptrdiff_t, not int, for sizes.
4501 (slurp_file): Switch from int to ptrdiff_t.
4502 All uses changed.
4503 (slurp_file): Check that file size fits in both size_t (for
4504 malloc) and ptrdiff_t (for sanity and safety).
4505
7f9bbdbb
PE
4506 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4507 if b->modtime has its maximal value.
4508
dfe18f82
PE
4509 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4510
84acfcf0
PE
4511 Don't assume time_t can fit into int.
4512 * buffer.h (struct buffer.modtime): Now time_t, not int.
4513 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4514 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4515
ccd9a01a
PE
4516 Minor fixes for signed vs unsigned integers.
4517 * character.h (MAYBE_UNIFY_CHAR):
4518 * charset.c (maybe_unify_char):
4519 * keyboard.c (read_char, reorder_modifiers):
4520 XINT -> XFASTINT, since the integer must be nonnegative.
4521 * ftfont.c (ftfont_spec_pattern):
4522 * keymap.c (access_keymap, silly_event_symbol_error):
4523 XUINT -> XFASTINT, since the integer must be nonnegative.
4524 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4525 since it makes no difference and we prefer signed.
4526 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4527 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4528 nonnegative.
4529
d6d100dd
SM
45302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4531
4532 * window.h (Fwindow_frame): Declare.
4533
2b6148e4
PE
45342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4535
4536 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4537 (SPARE_MEMORY): Always define.
4538 (LARGE_REQUEST): Remove.
4539 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4540
f230ecc9
MR
45412011-06-06 Martin Rudalics <rudalics@gmx.at>
4542
727e958e
MR
4543 * lisp.h: Move EXFUNS for Fframe_root_window,
4544 Fframe_first_window and Fset_frame_selected_window to window.h.
4545
4546 * window.h: Move EXFUNS for Fframe_root_window,
4547 Fframe_first_window and Fset_frame_selected_window here from
4548 lisp.h.
4549
4550 * frame.c (Fwindow_frame, Fframe_first_window)
4551 (Fframe_root_window, Fframe_selected_window)
4552 (Fset_frame_selected_window): Move to window.c.
4553 (Factive_minibuffer_window): Move to minibuf.c.
4554 (Fother_visible_frames_p): New function.
4555
4556 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4557
f230ecc9
MR
4558 * window.c (decode_window, decode_any_window): Move up in code.
4559 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4560 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4561 (Fwindow_buffer): Move up and rewrite doc-string.
4562 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4563 (Fwindow_prev): New functions.
727e958e
MR
4564 (Fwindow_frame): Move here from frame.c. Accept any window as
4565 argument.
4566 (Fframe_root_window, Fframe_first_window)
4567 (Fframe_selected_window): Move here from frame.c. Accept frame
4568 or arbitrary window as argument. Update doc-strings.
4569 (Fminibuffer_window): Move up in code.
4570 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4571 (Fset_frame_selected_window): Move here from frame.c.
4572 Marginal rewrite.
727e958e
MR
4573 (Fselected_window, select_window, Fselect_window): Move up in
4574 code. Minor doc-string fixes.
f230ecc9 4575
4d09bcf6
PE
45762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4577
4578 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4579 Do not assume that spare memory exists; that assumption is valid
4580 only if SYSTEM_MALLOC.
4581 (LARGE_REQUEST): New macro, so that the issue of large requests
4582 is separated from the issue of spare memory.
4583
810928a2
AS
45842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4585
172418ad
AS
4586 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4587 format. (Bug#8806)
4588
43f862f7
AS
4589 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4590
810928a2
AS
4591 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4592 before statements.
4593
a059fe24
JD
45942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4595
4596 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4597
4598 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4599
4600 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4601 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4602
989bf368
JB
46032011-06-05 Juanma Barranquero <lekktu@gmail.com>
4604
4605 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4606
4b80f674
CY
46072011-06-04 Chong Yidong <cyd@stupidchicken.com>
4608
4609 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4610 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4611 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4612 New error handlers.
4b80f674
CY
4613 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4614 Obey Vx_select_enable_clipboard_manager. Catch errors in
4615 x_clipboard_manager_save (Bug#8779).
4616 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4617 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4618
99a33b77 46192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4620
4621 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4622
99a33b77 46232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4624
4625 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4626 in the current matrix if keep_current_p is non-zero.
4627
8264569d
EZ
46282011-06-04 Eli Zaretskii <eliz@gnu.org>
4629
4630 * bidi.c (bidi_level_of_next_char): Fix last change.
4631
57f97249
EZ
46322011-06-03 Eli Zaretskii <eliz@gnu.org>
4633
fec2107c 4634 Support bidi reordering of text covered by display properties.
57f97249 4635
fec2107c
EZ
4636 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4637 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4638 (bidi_cache_search, bidi_cache_iterator_state)
4639 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4640 (bidi_level_of_next_char, bidi_move_to_visually_next):
4641 Support character positions inside a run of characters covered by a
fec2107c
EZ
4642 display string.
4643 (bidi_paragraph_init, bidi_resolve_explicit_1)
4644 (bidi_level_of_next_char): Call bidi_fetch_char and
4645 bidi_fetch_char_advance instead of FETCH_CHAR and
4646 FETCH_CHAR_ADVANCE.
4647 (bidi_init_it): Initialize new members.
4648 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4649 definitions.
4650 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4651 instead of using explicit *_CHAR codes.
d6d100dd
SM
4652 (bidi_resolve_explicit, bidi_resolve_weak):
4653 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4654 bidirectional text is supported only in multibyte buffers.
4655 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4656 it to initialize the frame_window_p member of struct bidi_it.
4657 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4658 (bidi_resolve_explicit, bidi_resolve_weak)
4659 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4660 bidi_it->nchars is non-positive.
4661 (bidi_level_of_next_char): Don't try to lookup the cache for the
4662 next/previous character if nothing is cached there yet, or if we
4663 were just reseat()'ed to a new position.
c40e2fb2 4664
0e14fe90
EZ
4665 * xdisp.c (set_cursor_from_row): Set start and stop points
4666 according to the row's direction when priming the loop that looks
4667 for the glyph on which to display cursor.
4668 (single_display_spec_intangible_p): Function deleted.
4669 (display_prop_intangible_p): Reimplement to call
4670 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4671 Accept 3 additional arguments needed by handle_display_spec.
4672 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4673 values: lists, `(when COND...)' forms, etc.
4674 (single_display_spec_string_p): Support property values that are
4675 lists with the argument STRING its top-level element.
4676 (display_prop_string_p): Fix the condition for processing a
4677 property that is a list to be consistent with handle_display_spec.
fec2107c 4678 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4679 last portion of handle_display_prop.
4680 (compute_display_string_pos): Accept additional argument
4681 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4682 value of a `display' property is a "replacing spec".
4683 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4684 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4685 the display property, but just return a value indicating whether
4686 the display property will replace the characters it covers.
4687 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4688 frame_window_p members of struct bidi_it.
d6d100dd
SM
4689 (compute_display_string_pos, compute_display_string_end):
4690 New functions.
fec2107c
EZ
4691 (push_it): Accept second argument POSITION, where pop_it should
4692 jump to continue iteration.
4693 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4694
fec2107c
EZ
4695 * keyboard.c (adjust_point_for_property): Adjust the call to
4696 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4697
4698 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4699 (bidi_init_it): Update prototypes.
4700 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4701 (compute_display_string_pos, compute_display_string_end):
4702 Declare prototypes.
fec2107c
EZ
4703 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4704 EMACS_INT.
fc6f18ce 4705
40087514 47062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4707
57f53182
PE
4708 Malloc failure behavior now depends on size of allocation.
4709 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4710 * lisp.h: Change signatures accordingly.
4711 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4712 All callers changed. (Bug#8762)
4713
4714 * gnutls.c: Use Emacs's memory allocators.
4715 Without this change, the gnutls library would invoke malloc etc.
4716 directly, which causes problems on non-SYNC_INPUT hosts, and which
4717 runs afoul of improving memory_full behavior. (Bug#8761)
4718 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4719 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4720 xfree instead of the default malloc, realloc, free.
4721 (Fgnutls_boot): No need to check for memory allocation failure,
4722 since xmalloc does that for us.
4723
ac32cd99 4724 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4725 * category.c (hash_get_category_set):
4726 * ccl.c (ccl_driver):
4727 * charset.c (Fdefine_charset_internal):
4728 * charset.h (struct charset.hash_index):
4729 * composite.c (get_composition_id, gstring_lookup_cache)
4730 (composition_gstring_put_cache):
4731 * composite.h (struct composition.hash_index):
4732 * dispextern.h (struct image.hash):
4733 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4734 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4735 (hashfn_equal, hashfn_user_defined, make_hash_table)
4736 (maybe_resize_hash_table, hash_lookup, hash_put)
4737 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4738 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4739 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4740 * image.c (make_image, search_image_cache, lookup_image)
4741 (xpm_put_color_table_h):
4742 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4743 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4744 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4745 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4746 * alloc.c (allocate_vectorlike):
4747 Check for overflow in vector size calculations.
4748 * ccl.c (ccl_driver):
4749 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4750 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4751 need to be updated by these changes.
40087514
PE
4752 * fns.c (make_hash_table, maybe_resize_hash_table):
4753 Check for integer overflow with large hash tables.
0de4bb68
PE
4754 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4755 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4756 (SXHASH_REDUCE): New macro.
4757 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4758 Use it instead of discarding useful hash info with large hash values.
4759 (sxhash_float): New function.
4760 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4761 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4762 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4763 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4764 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4765 Adjust signatures to match updated version of code.
4766 (consing_since_gc): Now EMACS_INT, since a single hash table can
4767 use more than INT_MAX bytes.
4768
698d32e2
DN
47692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4770
4771 Make it possible to build with GCC-4.6+ -O2 -flto.
4772
4773 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4774
fd6fa53f
SM
47752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4776
4777 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4778 Call minibuffer-inactive-mode.
4779
864db017
JB
47802011-05-31 Juanma Barranquero <lekktu@gmail.com>
4781
4782 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4783 Update dependencies.
4784
2ad0baf4
DN
47852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4786
4787 * data.c (init_data): Remove code for UTS, this system is not
4788 supported anymore.
4789
4fcc2638
DN
47902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4791
4792 Don't force ./temacs to start in terminal mode.
4793
4794 * frame.c (make_initial_frame): Initialize faces in all cases, not
4795 only when CANNOT_DUMP is defined.
4796 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4797
c56e0fd5
DN
47982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4799
4800 * dispnew.c (add_window_display_history): Use const for the string
4801 pointer. Remove declaration, not needed.
4802
333d54da 48032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4804
55d4c1b2 4805 Use 'inline', not 'INLINE'.
333d54da 4806 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4807 * alloc.c, fontset.c (INLINE): Remove.
4808 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4809 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4810 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4811 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4812 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4813
738db178
DN
48142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4815
4816 Make it possible to run ./temacs.
4817
4818 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4819 syms_of_callproc does the same thing. Remove test for
4820 "initialized", do it in the caller.
4821 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4822
620c53a6
SM
48232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4824
4825 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4826 (read_minibuf): Use get_minibuffer.
4827 (syms_of_minibuf): Use DEFSYM.
4828 (Qmetadata): New var.
4829 * data.c (Qbuffer): Don't make it static.
4830 (syms_of_data): Use DEFSYM.
4831
e003a292
PE
48322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4833
4834 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4835 (CCL_CODE_MIN): New macro.
4836
ed008a6d
PE
48372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4838
3687c2ef
PE
4839 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4840
ed008a6d
PE
4841 * eval.c (Qdebug): Now static.
4842 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4843 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4844 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4845
d66c4c7c
CY
48462011-05-29 Chong Yidong <cyd@stupidchicken.com>
4847
4848 * image.c: Various fixes to ImageMagick code comments.
4849 (Fimagemagick_types): Doc fix.
4850
5fbc2025
PE
48512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4852
0196f88a
PE
4853 Minor fixes prompted by GCC 4.6.0 warnings.
4854
4855 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4856
5fbc2025
PE
4857 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4858 (x_clipboard_manager_save_all): Move extern decl to ...
4859 * xterm.h: ... here, so that it can be checked for consistency.
4860
1dd3c2d9
CY
48612011-05-29 Chong Yidong <cyd@stupidchicken.com>
4862
4863 * xselect.c (x_clipboard_manager_save_frame)
4864 (x_clipboard_manager_save_all): New functions.
4865 (Fx_clipboard_manager_save): Lisp function deleted.
4866
4867 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4868 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4869
4870 * xterm.h: Update prototype.
4871
5ba6571d
WX
48722011-05-28 William Xu <william.xwl@gmail.com>
4873
4874 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4875 exiting (Bug#8239).
4876
3eaff834
JM
48772011-05-28 Jim Meyering <meyering@redhat.com>
4878
e1900994 4879 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4880 * fns.c (to_uchar): Define.
4881 (crypto_hash_function): Use it to convert some newly-signed
4882 variables to unsigned, to avoid sign-extension bugs. For example,
4883 without this change, (md5 "truc") would evaluate to
4884 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4885 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4886 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4887
0f6990a7
PE
48882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4889
4890 Integer overflow fixes.
c8a9ca5a 4891
08686060
PE
4892 * dbusbind.c: Serial number integer overflow fixes.
4893 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4894 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4895 to hold a serial number that is too large for a fixnum.
4896 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4897 Check for serial numbers out of range. Decode any serial number
59568bf0 4898 that was so large that it became a float. (Bug#8722)
08686060 4899
2d1fc3c7
PE
4900 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4901 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4902 Use XFASTINT rather than XUINT when numbers are nonnegative.
4903 (xd_append_arg, Fdbus_method_return_internal):
4904 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4905 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4906 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4907 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4908 (Bug#8722)
2d1fc3c7 4909
c8a9ca5a
PE
4910 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4911
519e1d69
PE
4912 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4913
30569699
PE
4914 ccl: add integer overflow checks
4915 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4916 (IN_INT_RANGE): New macros.
4917 (ccl_driver): Use them to check for integer overflow when
4918 decoding a CCL program. Many of the new checks are whether XINT (x)
4919 fits in int; it doesn't always, on 64-bit hosts. The new version
4920 doesn't catch all possible integer overflows, but it's an
847044ea 4921 improvement. (Bug#8719)
30569699 4922
c11285dc
PE
4923 * alloc.c (make_event_array): Use XINT, not XUINT.
4924 There's no need for unsigned here.
4925
fdccd48e
PE
4926 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4927 This follows up to the 2011-05-06 change that substituted uintptr_t
4928 for EMACS_INT. This case wasn't caught back then.
4929
37910ab2
PE
4930 Rework Fformat to avoid integer overflow issues.
4931 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4932 now (part of C89). Include <verify.h>.
4933 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4934 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4935 (Fformat): Avoid the prepass trying to compute sizes; it was only
4936 approximate and thus did not catch overflow reliably. Instead, walk
4937 through the format just once, formatting and computing sizes as we go,
4938 checking for integer overflow at every step, and allocating a larger
4939 buffer as needed. Keep track separately whether the format is
4940 multibyte. Keep only the most-recently calculated precision, rather
4941 than them all. Record whether each argument has been converted to
4942 string. Use EMACS_INT, not int, for byte and char and arg counts.
4943 Support field widths and precisions larger than INT_MAX. Avoid
4944 sprintf's undefined behavior with conversion specifications such as %#d
4945 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4946 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4947 formatting out-of-range floating point numbers with int
9173deec 4948 formats. (Bug#8668)
37910ab2 4949
2e6578fb
PE
4950 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4951
0ae6bdee
PE
4952 * data.c: Avoid integer truncation in expressions involving floats.
4953 * data.c: Include <intprops.h>.
4954 (arith_driver): When there's an integer overflow in an expression
4955 involving floating point, convert the integers to floating point
4956 so that the resulting value does not suffer from catastrophic
4957 integer truncation. For example, on a 64-bit host (* 4
4958 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4959 Do not rely on undefined behavior after integer overflow.
4960
de883a70
PE
4961 merge count_size_as_multibyte, parse_str_to_multibyte
4962 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4963 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4964 Check for integer overflow.
4965 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4966 since it's now a duplicate of the other. This is more of
4967 a character than a buffer op, so better that it's in character.c.
4968 * fns.c, print.c: Adjust to above changes.
4969
2ff916cb
PE
49702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4971
4972 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4973
f1b54466
PE
49742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4975
fb1ac845
PE
4976 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4977 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4978 (x_clipboard_manager_save): Now static.
4979 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4980
f1b54466
PE
4981 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4982 (crypto_hash_function): Now static.
4983 Fix pointer signedness problems. Avoid unnecessary initializations.
4984
a9f737ee
CY
49852011-05-27 Chong Yidong <cyd@stupidchicken.com>
4986
4987 * termhooks.h (Vselection_alist): Make it terminal-local.
4988
4989 * terminal.c (create_terminal): Initialize it.
4990
4991 * xselect.c: Support for clipboard managers.
4992 (Vselection_alist): Move to termhooks.h as terminal-local var.
4993 (LOCAL_SELECTION): New macro.
4994 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4995 (symbol_to_x_atom): Remove gratuitous arg.
4996 (x_handle_selection_request, lisp_data_to_selection_data)
4997 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4998 (x_own_selection, x_get_local_selection, x_convert_selection):
4999 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5000 (some_frame_on_display): Delete unused function.
5001 (Fx_own_selection_internal, Fx_get_selection_internal)
5002 (Fx_disown_selection_internal, Fx_selection_owner_p)
5003 (Fx_selection_exists_p): New optional frame arg.
5004 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5005 (x_handle_selection_clear): Don't treat other terminals with the
5006 same keyboard specially. Use the terminal-local Vselection_alist.
5007 (x_clear_frame_selections): Use Frun_hook_with_args.
5008
5009 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5010
5011 * xterm.h: Add support for those atoms.
5012
e067f0c1
CY
50132011-05-26 Chong Yidong <cyd@stupidchicken.com>
5014
5015 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5016 (converted_selections, conversion_fail_tag): New global variables.
5017 (x_selection_request_lisp_error): Free the above.
5018 (x_get_local_selection): Remove unnecessary code.
5019 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5020 of converted selections stored in converted_selections.
5021 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5022 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5023 (x_convert_selection): New function.
5024 (x_handle_selection_event): Simplify.
5025 (x_get_foreign_selection): Don't ignore incoming requests while
5026 waiting for an answer; this will fail when we implement
5027 SAVE_TARGETS, and seems unnecessary anyway.
5028 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5029 (Vx_sent_selection_functions): Doc fix.
5030
0f4aebc0
LL
50312011-05-26 Leo Liu <sdl.web@gmail.com>
5032
5033 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5034
e61124cd
YM
50352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5036
5037 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5038
5039 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5040 for fringe update if it has periodic bitmap.
ac389d0c 5041 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5042 and fringe_bitmap_periodic_p.
5043
5044 * fringe.c (get_fringe_bitmap_data): New function.
5045 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5046 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5047 row. Mark glyph row for fringe update if periodicity changed.
5048
5049 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5050 for fringe update unless it has periodic bitmap.
5051
f16d9837
KH
50522011-05-25 Kenichi Handa <handa@m17n.org>
5053
5054 * xdisp.c (get_next_display_element): Set correct it->face_id for
5055 a static composition.
5056
e1b90ef6
LL
50572011-05-24 Leo Liu <sdl.web@gmail.com>
5058
5059 * deps.mk (fns.o):
5060 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5061
5062 * fns.c (crypto_hash_function, Fsha1): New function.
5063 (Fmd5): Use crypto_hash_function.
5064 (syms_of_fns): Add Ssha1.
5065
7400048f
PE
50662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5067
5068 * gnutls.c: Remove unused macros.
5069 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5070 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5071 Remove macros that are defined and never used.
5072 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5073
abb71cf4
CY
50742011-05-22 Chong Yidong <cyd@stupidchicken.com>
5075
5076 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5077 (Fx_get_selection_internal): Minor cleanup.
5078 (Fx_own_selection_internal): Rename arguments for consistency with
5079 select.el.
5080
6307db39
PE
50812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5082
5083 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5084
f3d4e0a4
CY
50852011-05-22 Chong Yidong <cyd@stupidchicken.com>
5086
5087 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5088
4d8ade89
YM
50892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5090
5091 * dispnew.c (scrolling_window): Don't exclude the case that the
5092 last enabled row in the desired matrix touches the bottom boundary.
5093
32078c8d
GM
50942011-05-21 Glenn Morris <rgm@gnu.org>
5095
5096 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5097 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5098 and add some more files.
32078c8d 5099
7285dc67
EZ
51002011-05-20 Eli Zaretskii <eliz@gnu.org>
5101
5102 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5103 report_file_error introduced by the change from 2011-05-07.
5104
89d1bd22
PE
51052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5106
5107 * systime.h (Time): Define only if emacs is defined.
5108 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5109 where the include path doesn't have X11/X.h by default. See
5110 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5111
e23640bb 51122011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5113
5114 * composite.c (find_automatic_composition): Fix previous change.
5115
b9704ad9
GM
51162011-05-20 Glenn Morris <rgm@gnu.org>
5117
5118 * lisp.mk: New file, split from Makefile.in.
5119 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5120 (shortlisp): Remove.
5121 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5122
4a720484
GM
51232011-05-19 Glenn Morris <rgm@gnu.org>
5124
5125 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5126 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5127 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5128 (lisp): Set the order to that of loadup.el.
5129 (shortlisp): Make it a copy of $lisp.
5130 (SOME_MACHINE_LISP): Remove.
5131 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5132 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5133
a28d4396
KH
51342011-05-18 Kenichi Handa <handa@m17n.org>
5135
5136 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5137 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5138 (find_automatic_composition): Mostly rewrite for efficiency.
5139
a2b1fa8e
JB
51402011-05-18 Juanma Barranquero <lekktu@gmail.com>
5141
5142 * makefile.w32-in: Update dependencies.
5143
8e1f5610
CS
51442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5145
5146 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5147 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5148
7025ee00 51492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5150
cdfa6eab
PE
5151 Fix some integer overflow issues, such as string length overflow.
5152
06d6db33
PE
5153 * insdel.c (count_size_as_multibyte): Check for string overflow.
5154
2b4560a8
PE
5155 * character.c (lisp_string_width): Check for string overflow.
5156 Use EMACS_INT, not int, for string indexes and lengths; in
5157 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5158 the resulting string length overflows an EMACS_INT; instead,
5159 report a string overflow if no precision given. When checking for
5160 precision exhaustion, use a check that cannot possibly have
5161 integer overflow. (Bug#8675)
5162 * character.h (lisp_string_width): Adjust to new signature.
5163
cb93f9be
PE
5164 * alloc.c (string_overflow): New function.
5165 (Fmake_string): Use it. This doesn't change behavior, but saves
5166 a few bytes and will simplify future changes.
5167 * character.c (string_escape_byte8): Likewise.
5168 * lisp.h (string_overflow): New decl.
5169
1a1f3366
PE
5170 Fixups, following up to the user-interface timestamp change.
5171 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5172 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5173 * msdos.c (mouse_get_pos): Likewise.
5174 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5175 * w32gui.h (Time): Define by including "systime.h" rather than by
5176 declaring it ourselves. (Bug#8664)
5177
d4e3e4d3
PE
5178 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5179 * image.c (clear_image_cache): Likewise.
5180
f6a24d19
PE
5181 * term.c (term_mouse_position): Don't assume time_t wraparound.
5182
08dc5ae6
PE
5183 Be more systematic about user-interface timestamps.
5184 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5185 and sometimes 'EMACS_UINT', to represent these timestamps.
5186 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5187 This makes the code easier to follow, and makes it easier to catch
5188 integer overflow bugs such as Bug#8664.
5189 * frame.c (Fmouse_position, Fmouse_pixel_position):
5190 Use Time, not unsigned long, for user-interface timestamps.
5191 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5192 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5193 * keyboard.h (last_event_timestamp): Likewise.
5194 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5195 * menu.h (xmenu_show): Likewise.
5196 * term.c (term_mouse_position): Likewise.
5197 * termhooks.h (struct input_event.timestamp): Likewise.
5198 (struct terminal.mouse_position_hook): Likewise.
5199 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5200 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5201 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5202 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5203 what it was before.
5204 * menu.h, termhooks.h: Include "systime.h", for Time.
5205
8e55734a
PE
5206 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5207 Don't assume that the difference between two unsigned long values
5208 can fit into an integer. At this point, we know button_down_time
5209 <= event->timestamp, so the difference must be nonnegative, so
5210 there's no need to cast the result if double-click-time is
5211 nonnegative, as it should be; check that it's nonnegative, just in
5212 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5213 apart (about 25 days). (Bug#8664)
8e55734a 5214
841f1b75 5215 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5216 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5217
3e26f69c
PE
5218 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5219 that always fit in int. Use a sentinel instead of a counter, to
5220 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5221 * frame.h (struct frame): Use int for menu_bar_items_used
5222 instead of EMACS_INT, since it always fits in int.
3e26f69c 5223
5cc152c0
PE
5224 * menu.c (grow_menu_items): Check for int overflow.
5225
d89eb65e
PE
5226 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5227
5235bd3e
PE
5228 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5229 Before, the code was not consistent. These values cannot exceed
5230 2**31 - 1 so there's no need to make them unsigned.
5231 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5232 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5233 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5234 as modifiers.
5235 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5236
bc827e23
PE
5237 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5238 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5239 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5240 presumably because the widths might not match.
5241
78eb494e
PE
5242 * window.c (size_window): Avoid needless test at loop start.
5243
04f2d78b
CB
52442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5245
5246 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5247
d2fc7e3d 52482011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5249
5250 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5251
d2fc7e3d 52522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5253
5254 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5255 `width' to `bar_area_x' and `bar_area_width', respectively.
5256 (x_scroll_run): Take account of fringe background extension.
5257
04f2d78b
CB
5258 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5259 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5260 `bar_area_width', respectively.
5261 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5262 background extension.
5263
79b70037
GM
52642011-05-10 Jim Meyering <meyering@redhat.com>
5265
5266 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5267
2f142cc5
JB
52682011-05-10 Juanma Barranquero <lekktu@gmail.com>
5269
5270 * image.c (Finit_image_library): Return t for built-in image types,
5271 like pbm and xbm. (Bug#8640)
5272
57679c86
AS
52732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5274
5275 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5276
888c9e86
EZ
52772011-05-07 Eli Zaretskii <eliz@gnu.org>
5278
b0512a1d
EZ
5279 * w32console.c (Fset_screen_color): Doc fix.
5280 (Fget_screen_color): New function.
5281 (syms_of_ntterm): Defsubr it.
5282
7285dc67
EZ
5283 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5284 unlink the temporary file if Fcall_process didn't create it in the
5285 first place.
5286 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5287 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5288 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5289 cue to call_process_cleanup not to close that handle.
5290
4d3fcc8e
BK
52912011-05-07 Ben Key <bkey76@gmail.com>
5292
5293 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5294 one of two shell specific rules, either bootstrap-temacs-CMD or
5295 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5296 to the previous implementation of the bootstrap-temacs rule.
5297 The bootstrap-temacs-CMD rule is similar to the previous
5298 implementation of the bootstrap-temacs rule except that it
5299 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5300 variable.
5301
5302 These changes, along with some changes to nt/configure.bat,
5303 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5304 earlier fix to add support for --cflags and --ldflags options
5305 that include quotes so that it works whether make uses cmd or
5306 sh as the shell.
5307
b4289b64
MA
53082011-05-06 Michael Albinus <michael.albinus@gmx.de>
5309
5310 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5311 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5312 is a constant.
5313 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5314 a string. Handle both cases.
5315 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5316 (Fdbus_register_method): Use Qinvalid_function.
5317
af4c0e28
JB
53182011-05-06 Juanma Barranquero <lekktu@gmail.com>
5319
5320 * makefile.w32-in: Update dependencies.
5321 (LISP_H): Add inttypes.h and stdin.h.
5322 (PROCESS_H): Add unistd.h.
5323
c51453d9
EZ
53242011-05-06 Eli Zaretskii <eliz@gnu.org>
5325
5326 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5327 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5328
8ff0ac3c 53292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5330
4c4b566b
PE
5331 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5332
aab2b9b5
PE
5333 * term.c (vfatal): Remove stray call to va_end.
5334 It's not needed and the C Standard doesn't allow it here anyway.
5335
c378da0b
PE
5336 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5337 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5338
288b08c7
PE
5339 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5340 bytes.
5341
e3601888
PE
5342 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5343
db6c0e74
PE
5344 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5345
dd5963ea
PE
5346 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5347
88c9450f
PE
5348 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5349
2f9442b8
PE
5350 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5351
c032b5f8
PE
5352 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5353 * charset.c (Fdefine_charset_internal): Don't initialize
5354 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5355 32-bit int (Bug#8600).
a108c10b
PE
5356
5357 * lread.c (read_integer): Be more consistent with string-to-number.
5358 Use string_to_number to do the actual conversion; this avoids
5359 rounding errors and fixes some other screwups. Without this fix,
5360 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5361 (digit_to_number): Move earlier, for benefit of read_integer.
5362 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5363 not a digit in any supported base. (Bug#8602)
a108c10b 5364
ad5f9eea
PE
5365 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5366
aec1708a
PE
5367 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5368 to match comment at start of function. This also removes a
5369 GCC warning about overflow in a 32+64-bit port.
5370
47be4ab5
PE
5371 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5372
371cac43
PE
5373 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5374 Reported by Stefan Monnier in
5375 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5376 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5377 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5378
d01a7826
PE
5379 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5380 (EMACS_UINTPTR): Likewise, with uintptr_t.
5381
7fd47d5c
PE
5382 * lisp.h: Prefer 64-bit EMACS_INT if available.
5383 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5384 on 32-bit hosts that have 64-bit int, so that they can access
5385 large files.
122b0c86
PE
5386 However, temporarily disable this change unless the temporary
5387 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5388
8727937b
PE
5389 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5390
8ac068ac
PE
5391 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5392 This removes an assumption that EMACS_INT and long are the same
5393 width as pointers. The assumption is true for Emacs porting targets
5394 now, but we want to make other targets possible.
5395 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5396 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5397 In the rest of the code, change types of integers that hold casted
5398 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5399 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5400 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5401 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5402 No need to cast type when ORing.
5403 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5404 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5405 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5406 assume EMACS_INT is the same width as char *.
5407 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5408 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5409 Remove no-longer-needed casts.
5410 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5411 (xg_tool_bar_help_callback, xg_make_tool_item):
5412 Use EMACS_INTPTR to hold an integer
5413 that will be cast to void *; this can avoid a GCC warning
5414 if EMACS_INT is not the same width as void *.
5415 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5416 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5417 (current_message_1, set_message_1):
5418 Use a local to convert to proper width without a cast.
5419 * xmenu.c (dialog_selection_callback): Likewise.
5420
ede49d71
PE
5421 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5422 Also, don't assume VALBITS / RAND_BITS is less than 5,
5423 and don't rely on undefined behavior when shifting a 1 left into
5424 the sign bit.
5425 * lisp.h (get_random): Change signature to match.
5426
2f30ecd0
PE
5427 * lread.c (hash_string): Use size_t, not int, for hash computation.
5428 Normally we prefer signed values; but hashing is special, because
5429 it's better to use unsigned division on hash table sizes so that
5430 the remainder is nonnegative. Also, size_t is the natural width
5431 for hashing into memory. The previous code used 'int', which doesn't
5432 retain enough info to hash well into very large tables.
5433 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5434
2a866e7b
PE
5435 * dbusbind.c: Don't possibly lose pointer info when converting.
5436 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5437 Use XPNTR rather than XHASH, so that the high-order bits of
5438 the pointer aren't lost when converting through void *.
5439
51639eac
PE
5440 * eval.c (Fautoload): Don't double-shift a pointer.
5441
92394119
PE
5442 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5443
dbdb9a7c
JB
54442011-05-06 Juanma Barranquero <lekktu@gmail.com>
5445
5446 * gnutls.c (DEF_GNUTLS_FN):
5447 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5448
db7a0b4f
AS
54492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5450
5451 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5452 marker. (Bug#8610)
5453
f7ff1b0f 54542011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5455
5456 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5457 New version that can reserve upto 2GB of heap space.
5458
f7ff1b0f 54592011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5460
5461 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5462
639c109b
TZ
54632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5464
5465 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5466 `gnutls_certificate_set_x509_key_file'.
5467
d2127135
JB
54682011-05-05 Juanma Barranquero <lekktu@gmail.com>
5469
5470 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5471 Update dependencies.
5472
e968f4f3
JB
54732011-05-04 Juanma Barranquero <lekktu@gmail.com>
5474
5475 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5476 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5477 Remove unused parameter `fildes'.
5478 * process.c (read_process_output, send_process): Don't pass it.
5479
84d358f0
JB
54802011-05-04 Juanma Barranquero <lekktu@gmail.com>
5481
5482 Fix previous change: the library cache is defined in w32.c.
5483 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5484 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5485
0898ca10
JB
54862011-05-04 Juanma Barranquero <lekktu@gmail.com>
5487
5488 Implement dynamic loading of GnuTLS on Windows.
5489
5490 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5491 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5492 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5493 Declare.
5494
5495 * gnutls.c (Qgnutls_dll): Define.
5496 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5497 (gnutls_*): Declare function pointers.
5498 (init_gnutls_functions): New function to initialize function pointers.
5499 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5500 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5501 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5502 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5503 (emacs_gnutls_write, emacs_gnutls_read)
5504 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5505 (Fgnutls_available_p): New function.
5506 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5507 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5508 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5509
5510 * image.c: Include w32.h.
5511 (Vimage_type_cache): Delete.
5512 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5513 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5514 (w32_delayed_load): Move to w32.c.
5515
5516 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5517
5518 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5519 (w32_delayed_load): Move from image.c. When loading a library, record
5520 its filename in the :loaded-from property of the library id.
5521 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5522 Initialize and staticpro them.
5523 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5524
5525 * process.c: Include lisp.h before w32.h, not after.
5526 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5527 instead of gnutls_record_check_pending.
5528
5529 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5530
ff4de4aa
TZ
55312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5532
5533 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5534 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5535 as passed in.
5536
abe95abb
JD
55372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5538
5539 * xterm.c (x_set_frame_alpha): Do not set property on anything
5540 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5541
e16e55d4
JB
55422011-05-02 Juanma Barranquero <lekktu@gmail.com>
5543
5544 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5545
bafcf6a5
JB
55462011-05-02 Juanma Barranquero <lekktu@gmail.com>
5547
5548 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5549 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5550 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5551 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5552 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5553 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5554 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5555 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5556 (Qgnutls_bootprop_callbacks_verify): Make static.
5557
e7a6747f
AS
55582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5559
19ed11ba
AS
5560 * callproc.c: Indentation fixup.
5561
e7a6747f 5562 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5563 (wait_for_termination, interruptible_wait_for_termination):
5564 Move after wait_for_termination_1.
e7a6747f 5565
1ef14cb4
LMI
55662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5567
5568 * sysdep.c (interruptible_wait_for_termination): New function
5569 which is like wait_for_termination, but allows keyboard
5570 interruptions.
5571
5572 * callproc.c (Fcall_process): Add (:file "file") as an option for
5573 the STDOUT buffer.
5574 (Fcall_process_region): Ditto.
5575
330d880c
EZ
55762011-04-30 Eli Zaretskii <eliz@gnu.org>
5577
8db90b73
EZ
5578 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5579 rather than `XVECTOR (FOO)->size'.
5580
330d880c
EZ
5581 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5582 inttypes.h, as a gnulib replacement is used if it not available in
5583 system headers.
5584
15cbd324
EZ
55852011-04-21 Eli Zaretskii <eliz@gnu.org>
5586
5587 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5588 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5589 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5590
5591 * coding.c (coding_alloc_by_realloc): Error out if destination
5592 will grow beyond MOST_POSITIVE_FIXNUM.
5593 (decode_coding_emacs_mule): Abort if there isn't enough place in
5594 charbuf for the composition carryover bytes. Reserve an extra
5595 space for up to 2 characters produced in a loop.
5596 (decode_coding_iso_2022): Abort if there isn't enough place in
5597 charbuf for the composition carryover bytes.
5598
55992011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5600
ae940cca
EZ
5601 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5602 aborting when %lld or %lll format is passed.
5603 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5604 %llo or %llx format is passed. (Bug#8545)
5605
03ab8921
EZ
5606 * window.c (window_scroll_line_based): Use a marker instead of
5607 simple variables to record original value of point. (Bug#7952)
5608
afda1437
EZ
5609 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5610 produced by %s or %c overflows available buffer space. (Bug#8545)
5611
f76dee0c
PE
56122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5613
5614 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5615 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5616
fdc5744d
JB
56172011-04-28 Juanma Barranquero <lekktu@gmail.com>
5618
5619 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5620
638f053a
JB
56212011-04-28 Juanma Barranquero <lekktu@gmail.com>
5622
5623 * keyboard.c (Qdelayed_warnings_hook): Define.
5624 (command_loop_1): Run `delayed-warnings-hook'
5625 if Vdelayed_warnings_list is non-nil.
5626 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5627 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5628
d178f871
EZ
56292011-04-28 Eli Zaretskii <eliz@gnu.org>
5630
5631 * doprnt.c (doprnt): Don't return value smaller than the buffer
5632 size if the message was truncated. (Bug#8545).
5633
b124fd93
JB
56342011-04-28 Juanma Barranquero <lekktu@gmail.com>
5635
5636 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5637 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5638
e810457d
PE
56392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5640
5641 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5642
ea51cceb
JB
56432011-04-27 Juanma Barranquero <lekktu@gmail.com>
5644
5645 * makefile.w32-in: Update dependencies.
5646
94dcfacf
EZ
56472011-04-27 Eli Zaretskii <eliz@gnu.org>
5648
5649 Improve `doprnt' and its usage. (Bug#8545)
5650 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5651 `format_end'. Remove support for %l as a conversion specifier.
5652 Don't use xrealloc. Improve diagnostics when the %l size modifier
5653 is used. Update the commentary.
5654
5655 * eval.c (verror): Simplify calculation of size_t.
5656
5657 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5658 messages.
5659
f61f41d7
PE
56602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5661
5662 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5663 change.
5664
96fb4434
PE
56652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5666
5667 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5668 This makes this file independent of the recent pseudovector change.
5669
671875da 56702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5671
69e9b5a3
PE
5672 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5673
b5f869a7 5674 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5675 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5676 Remove unused local.
c8926152 5677 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5678
841a1577 5679 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5680 GCC 4.6.0 optimizes based on type-based alias analysis.
5681 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5682 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5683 != &v->size, and therefore "v->size = 1; b->size = 2; return
5684 v->size;" must therefore return 1. This assumption is incorrect
5685 for Emacs, since it type-puns struct Lisp_Vector * with many other
5686 types. To fix this problem, this patch adds a new type struct
f904488f 5687 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5688 and pseudovectors, and helps optimizing compilers not get fooled
5689 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5690 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5691 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5692 the size member.
eab3844f
PE
5693 (XSETPVECTYPE): Rewrite in terms of new macro.
5694 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5695 This is a bit clearer, and further avoids the possibility of
5696 undesirable aliasing.
5697 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5698 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5699 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5700 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5701 (ASIZE): Now uses header.size rather than size.
5702 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5703 to avoid the hassle of writing XVECTOR (foo)->header.size.
5704 (struct vectorlike_header): New type.
eab3844f
PE
5705 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5706 object, to help avoid aliasing.
5707 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5708 (SUBRP): Likewise, since Lisp_Subr is a special case.
5709 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5710 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5711 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5712 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5713 changed to be "header.size" and "header.next".
5714 * buffer.h (struct buffer): Likewise.
5715 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5716 * frame.h (struct frame): Likewise.
5717 * process.h (struct Lisp_Process): Likewise.
5718 * termhooks.h (struct terminal): Likewise.
5719 * window.c (struct save_window_data, struct saved_window): Likewise.
5720 * window.h (struct window): Likewise.
5721 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5722 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5723 * buffer.c (init_buffer_once): Likewise.
5724 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5725 special case.
5726 * process.c (Fformat_network_address): Use local var for size,
5727 for brevity.
5728
0df1eac5
PE
5729 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5730
847ab9d1 5731 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5732 * data.c (atof): Remove decl; no longer used or needed.
5733 (digit_to_number): Move to lread.c.
5734 (Fstring_to_number): Use new string_to_number function, to be
5735 consistent with how the Lisp reader treats infinities and NaNs.
5736 Do not assume that floating-point numbers represent EMACS_INT
5737 without losing information; this is not true on most 64-bit hosts.
5738 Avoid double-rounding errors, by insisting on integers when
5739 parsing non-base-10 numbers, as the documentation specifies.
5740 * lisp.h (string_to_number): New decl, replacing ...
5741 (isfloat_string): Remove.
bc0a5c13 5742 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5743 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5744 appears to have been a coding error. Similarly, do not accept
5745 strings like +-1e0 as floating point numbers. Do not report
5746 overflow for integer overflows unless the base is not 10 which
5747 means we have no simple and reliable way to continue.
5748 Break out the floating-point parsing into a new
5749 function string_to_number, so that Fstring_to_number parses
5750 floating point numbers consistently with the Lisp reader.
04f2d78b 5751 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5752 (E_CHAR, EXP_INT): Remove, replacing with ...
5753 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5754 (string_to_number): New function, replacing isfloat_string.
5755 This function checks for valid syntax and produces the resulting
5756 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5757 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5758 so that overflow for non-base-10 numbers is reported only when
5759 there's no portable and simple way to convert to floating point.
452f4150 5760
67769ffc
PE
5761 * textprop.c (set_text_properties_1): Rewrite for clarity,
5762 and to avoid GCC warning about integer overflow.
5763
c20db43f
PE
5764 * intervals.h (struct interval): Use EMACS_INT for members
5765 where EMACS_UINT might cause problems. See
5766 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5767 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5768 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5769 All uses changed.
37aa2f85
PE
5770 (offset_intervals): Tell GCC not to worry about length overflow
5771 when negating a negative length.
c20db43f 5772
2538aa2f
PE
5773 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5774 (overrun_check_free): Likewise.
5775
f2d3008d
PE
5776 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5777 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5778 word size.
5779
ec8df744
PE
5780 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5781 (gnutls_make_error): Rename local to avoid shadowing.
5782 (gnutls_emacs_global_deinit): ifdef out; not used.
5783 (Fgnutls_boot): Use const for pointer to readonly storage.
5784 Comment out unused local. Fix pointer signedness problems.
5785
640ee02d
PE
5786 * lread.c (openp): Don't stuff size_t into an 'int'.
5787 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5788 about possible signed overflow.
5789
6048fb2a
PE
5790 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5791 (GDK_KEY_g): Don't define if already defined.
5792 (xg_prepare_tooltip): Avoid pointer signedness problem.
5793 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5794
fa3c87e1
PE
5795 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5796 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5797
2172544b
PE
5798 * xfns.c (Fx_window_property): Simplify a bit,
5799 to make a bit faster and to avoid GCC 4.6.0 warning.
5800 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5801
9b821a21
PE
5802 * fns.c (internal_equal): Don't assume size_t fits in int.
5803
3c616cfa
PE
5804 * alloc.c (compact_small_strings): Tighten assertion a little.
5805
c2982e87
PE
5806 Replace pEd with more-general pI, and fix some printf arg casts.
5807 * lisp.h (pI): New macro, generalizing old pEd macro to other
5808 conversion specifiers. For example, use "...%"pI"d..." rather
5809 than "...%"pEd"...".
5810 (pEd): Remove. All uses replaced with similar uses of pI.
5811 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5812 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5813 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5814 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5815 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5816 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5817 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5818 64-bit hosts.
5819 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5820 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5821 * print.c (safe_debug_print, print_object): Likewise.
5822 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5823 to int.
6f04d126
PE
5824 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5825 avoiding the 0 flag, which is not portable.
c2982e87
PE
5826 * process.c (Fmake_network_process): Use pI to avoid cast.
5827 * region-cache.c (pp_cache): Likewise.
5828 * xdisp.c (decode_mode_spec): Likewise.
5829 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5830 behavior on 64-bit hosts with printf arg.
6f04d126 5831 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5832 (x_stop_queuing_selection_requests): Likewise.
5833 (x_get_window_property): Don't truncate byte count to an 'int'
5834 when tracing.
0b432f21 5835
5e073ec7
PE
5836 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5837 here, since it parses constructs like leading '-' and spaces,
5838 which are not wanted; and it overflows with large numbers.
5839 Instead, simply match F[0-9]+, which is what is wanted anyway.
5840
36372bf9
PE
5841 * alloc.c: Remove unportable assumptions about struct layout.
5842 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5843 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5844 (allocate_vectorlike, make_pure_vector): Use the new macros,
5845 plus offsetof, to remove unportable assumptions about struct layout.
5846 These assumptions hold on all porting targets that I know of, but
5847 they are not guaranteed, they're easy to remove, and removing them
5848 makes further changes easier.
5849
0b432f21
PE
5850 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5851 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5852 (string_overrun_cookie): Now const. Use initializers that
5853 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5854 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5855 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5856 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5857 multiple of sizeof (EMACS_INT); it need not be, if
5858 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5859 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5860
895009e1
JB
58612011-04-26 Juanma Barranquero <lekktu@gmail.com>
5862
5863 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5864
6a7a1b0b
TZ
58652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5866
5867 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5868 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5869 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5870
841a1577 58712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5872
5873 * lisp.h (Qdebug): List symbol.
895009e1 5874 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5875 * keyboard.c (debug-on-event): New variable.
5876 (handle_user_signal): Break into debugger when debug-on-event
5877 matches the current signal symbol.
5878
f2d3ba6f
DN
58792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5880
5881 * alloc.c (check_sblock, check_string_bytes)
5882 (check_string_free_list): Convert to standard C.
5883
42ce4c63
TZ
58842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5885
5886 * w32.c (emacs_gnutls_push): Fix typo.
5887
825cd63c
EZ
58882011-04-25 Eli Zaretskii <eliz@gnu.org>
5889
fb11d64d
EZ
5890 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5891 "cast to pointer from integer of different size".
5892
825cd63c
EZ
5893 Improve doprnt and its use in verror. (Bug#8545)
5894 * doprnt.c (doprnt): Document the set of format control sequences
5895 supported by the function. Use SAFE_ALLOCA instead of always
5896 using `alloca'.
5897
5898 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5899 is one byte too soon. Don't use xrealloc; instead xfree and
5900 xmalloc anew.
5901
e061a11b
TZ
59022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5903
5904 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5905 callbacks stage.
5906
5907 * gnutls.c: Renamed global_initialized to
5908 gnutls_global_initialized. Added internals for the
5909 :verify-hostname-error, :verify-error, and :verify-flags
5910 parameters of `gnutls-boot' and documented those parameters in the
5911 docstring. Start callback support.
9173deec
JB
5912 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5913 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5914 on error. Return error code.
e061a11b
TZ
5915 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5916 (emacs_gnutls_read): Likewise.
5917 (Fgnutls_boot): Return handshake error code.
5918 (emacs_gnutls_handle_error): New function.
5919 (wsaerror_to_errno): Likewise.
5920
5921 * w32.h (emacs_gnutls_pull): Add prototype.
5922 (emacs_gnutls_push): Likewise.
5923
5924 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5925 (emacs_gnutls_push): Likewise.
5926
59272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5928
5929 * process.c (wait_reading_process_output): Check if GnuTLS
5930 buffered some data internally if no FDs are set for TLS
5931 connections.
5932
5933 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5934 (LIBS): Link to USER_LIBS.
5935 ($(BLD)/gnutls.$(0)): New target.
5936
fa6996bc
EZ
59372011-04-24 Eli Zaretskii <eliz@gnu.org>
5938
eb35682e
EZ
5939 * xdisp.c (handle_single_display_spec): Rename the
5940 display_replaced_before_p argument into display_replaced_p, to
5941 make it consistent with the commentary. Fix typos in the
5942 commentary.
5943
e2ad650c
EZ
5944 * textprop.c (syms_of_textprop): Remove dead code.
5945 (copy_text_properties): Delete obsolete commentary about an
5946 interface that was deleted long ago. Fix typos in the description
5947 of arguments.
5948
1b2de274
EZ
5949 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5950 to changes in oldXMenu/XMenu.h from 2011-04-16.
5951 <menu_help_message, prev_menu_help_message>: Constify.
5952 (IT_menu_make_room): menu->help_text is now `const char **';
5953 adjust.
5954
5955 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5956 to changes in oldXMenu/XMenu.h from 2011-04-16.
5957 (struct XMenu): Declare `help_text' `const char **'.
5958
5959 * xfaces.c <Qunspecified>: Make extern again.
5960
5961 * syntax.c: Include sys/types.h before including regex.h, as
5962 required by Posix.
5963
762b15be
EZ
5964 * doc.c (get_doc_string): Improve the format passed to `error'.
5965
5966 * doprnt.c (doprnt): Improve commentary.
5967
5968 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5969
5970 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5971 them with etags.
5972
f1052e5d
EZ
5973 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5974 changes in globals.h immediately force recompilation.
762b15be
EZ
5975 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5976 $(CURDIR)/s/ms-w32.h.
5977 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5978
fa6996bc
EZ
5979 * character.c (Fchar_direction): Function deleted.
5980 (syms_of_character): Don't defsubr it.
5981 <char-direction-table>: Deleted.
5982
e6c3da20
EZ
59832011-04-23 Eli Zaretskii <eliz@gnu.org>
5984
5985 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5986 * doprnt.c: Include limits.h.
5987 (SIZE_MAX): New macro.
04f2d78b
CB
5988 (doprnt): Return a size_t value. 2nd arg is now size_t.
5989 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5990 Improve overflow protection. Support `l' modifier for integer
5991 conversions. Support %l conversion. Don't assume an EMACS_INT
5992 argument for integer conversions and for %c.
5993
5994 * lisp.h (doprnt): Restore prototype.
5995
5996 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5997 $(SRC)/character.h.
5998
5999 * Makefile.in (base_obj): Add back doprnt.o.
6000
6001 * deps.mk (doprnt.o): Add back prerequisites.
6002 (callint.o): Depend on character.h.
6003
6004 * eval.c (internal_lisp_condition_case): Include the handler
6005 representation in the error message.
6006 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6007 when breaking from the loop.
6008
6009 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6010
6011 * callint.c (Fcall_interactively): When displaying error message
6012 about invalid control letter, pass the character's codepoint, not
6013 a pointer to its multibyte form. Improve display of the character
6014 in octal and display also its hex code.
6015
6016 * character.c (char_string): Use %x to display the (unsigned)
6017 codepoint of an invalid character, to avoid displaying a bogus
6018 negative value.
6019
6020 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6021 `error', not SYMBOL_NAME itself.
6022
6023 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6024 character arguments to `error'.
6025
6026 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6027 to `error' in error message about FINAL_CHAR argument. Make sure
6028 FINAL_CHAR is a character, and use %c when it is passed as
6029 argument to `error'.
6030
4ffd0d6b 60312011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6032
6033 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6034
6035 * w32.c: Include <time.h>.
6036 (sys_localtime): New function.
6037
4ffd0d6b 60382011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6039
6040 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6041
4ffd0d6b 6042 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6043
4ffd0d6b 60442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6045
4ffd0d6b
GM
6046 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6047 zombies (Bug#8467).
aac0c6e3 6048
04c56954
EZ
60492011-04-19 Eli Zaretskii <eliz@gnu.org>
6050
6051 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6052 gl_state.e_property when gl_state.object is Qt.
6053
6054 * insdel.c (make_gap_larger): Remove limitation of buffer size
6055 to <= INT_MAX.
6056
16a43933
CY
60572011-04-18 Chong Yidong <cyd@stupidchicken.com>
6058
6059 * xdisp.c (lookup_glyphless_char_display)
6060 (produce_glyphless_glyph): Handle cons cell entry in
6061 glyphless-char-display.
6062 (Vglyphless_char_display): Document it.
6063
6064 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6065 glyphless-char-display.
6066
4581706e
CY
60672011-04-17 Chong Yidong <cyd@stupidchicken.com>
6068
6069 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6070
6071 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6072
6073 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6074 definition for no-X builds.
6075
4887c6e2 60762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6077
fd35b6f9
PE
6078 Static checks with GCC 4.6.0 and non-default toolkits.
6079
5c1ccb01
PE
6080 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6081
006c5daa
PE
6082 * process.c (keyboard_bit_set): Define only if SIGIO.
6083 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6084 (send_process): Repair possible setjmp clobbering.
6085
efc736d3
PE
6086 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6087
4e2fe2e6
PE
6088 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6089
f97334a2
PE
6090 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6091
4e75f29d
PE
6092 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6093 Define only if needed.
6094
90efadd1
PE
6095 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6096 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6097 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6098
3c647824
PE
6099 * dispextern.h (struct redisplay_interface): Rename param
6100 to avoid shadowing.
e264f262 6101 * termhooks.h (struct terminal): Likewise.
761383f4 6102 * xterm.c (xembed_send_message): Likewise.
3c647824 6103
b58c5c4a
PE
6104 * insdel.c (make_gap_smaller): Define only if
6105 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6106
cad59032
PE
6107 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6108 it.
6109
c339dc2e
PE
6110 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6111 so that we aren't warned about unused symbols.
6112
91a3e27b
PE
6113 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6114
399c71d3 6115 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6116
8ffc96f5
PE
6117 * xfns.c (x_real_positions): Mark locals as initialized.
6118
eef9bc79
PE
6119 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6120
098db9dd
PE
6121 * xterm.c: Fix problems found by static analysis with other toolkits.
6122 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6123 (x_dispatch_event): Declare static if USE_GTK, and
6124 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6125 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6126 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6127 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6128 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6129
eb18f6cc
PE
6130 * xmenu.c (menu_help_callback): Pointer type fixes.
6131 Use const pointers when pointing at readonly data. Avoid pointer
6132 signedness clashes.
6133 (FALSE): Remove unused macro.
6134 (update_frame_menubar): Remove unused decl.
6135
1fe72bf8
PE
6136 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6137
60d9e1db
PE
6138 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6139 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6140 (single_menu_item): Rename local to avoid shadowing.
6141
39261c26
PE
6142 * keyboard.c (make_lispy_event): Remove unused local var.
6143
018c5e19
PE
6144 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6145 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6146
63d2b86e
PE
6147 * bitmaps: Change bitmaps from unsigned char back to the X11
6148 compatible char. Avoid the old compiler warnings about
6149 out-of-range initializers by using, for example, '\xab' rather
6150 than 0xab.
6151
aefd87e1
PE
6152 * xgselect.c (xgselect_initialize): Check vs interface
6153 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6154
bf501fb9
PE
6155 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6156
e9829fdf
PE
6157 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6158 to read-only memory.
6159
1086c095
PE
6160 * fns.c (vector): Remove; this old hack is no longer needed.
6161
2baccd04 6162 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6163 Remove unused var.
dde42981 6164 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6165
72391843 6166 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6167
436c16df 6168 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6169 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6170 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6171
92bb796d 6172 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6173 (x_term_init): Remove local to avoid shadowing.
92bb796d 6174
764430a3 6175 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6176
6177 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6178 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6179
d1dfb56c
EZ
61802011-04-16 Eli Zaretskii <eliz@gnu.org>
6181
c4354cb4
EZ
6182 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6183
d1dfb56c
EZ
6184 Fix regex.c, syntax.c and friends for buffers > 2GB.
6185 * syntax.h (struct gl_state_s): Declare character position members
6186 EMACS_INT.
6187
6188 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6189
04f2d78b
CB
6190 * textprop.c (verify_interval_modification, interval_of):
6191 Declare arguments EMACS_INT.
d1dfb56c
EZ
6192
6193 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6194 EMACS_INT.
6195
6196 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6197
6198 * indent.c (Fvertical_motion): Local variable it_start is now
6199 EMACS_INT.
6200
6201 * regex.c (re_match, re_match_2, re_match_2_internal)
6202 (bcmp_translate, regcomp, regexec, print_double_string)
6203 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6204 (re_compile_pattern, re_exec): Declare arguments and local
6205 variables `size_t' and `ssize_t' and return values `regoff_t', as
6206 appropriate.
6207 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6208 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6209 <compile_stack_type>: `size' and `avail' are now `size_t'.
6210
6211 * regex.h <regoff_t>: Use ssize_t, not int.
6212 (re_search, re_search_2, re_match, re_match_2): Arguments that
6213 specify buffer/string position and length are now ssize_t and
6214 size_t. Return type is regoff_t.
6215
613052cd
BK
62162011-04-16 Ben Key <bkey76@gmail.com>
6217
6218 * nsfont.m: Fixed bugs in ns_get_family and
6219 ns_descriptor_to_entity that were caused by using free to
6220 deallocate memory blocks that were allocated by xmalloc (via
6221 xstrdup). This caused Emacs to crash when compiled with
6222 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6223 --enable-checking=xmallocoverrun). xfree is now used to
6224 deallocate these memory blocks.
6225
4170f62f 62262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6227
71b41406
PE
6228 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6229
9587a89d
PE
6230 emacs_write: Accept and return EMACS_INT for sizes.
6231 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6232 et seq.
6233 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6234 Accept and return EMACS_INT.
6235 (emacs_gnutls_write): Return the number of bytes written on
6236 partial writes.
6237 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6238 (emacs_read, emacs_write): Remove check for negative size, as the
6239 Emacs source code has been audited now.
9587a89d
PE
6240 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6241 (emacs_read, emacs_write): Use it.
273a5f82
PE
6242 * process.c (send_process): Adjust to the new signatures of
6243 emacs_write and emacs_gnutls_write. Do not attempt to store
6244 a byte offset into an 'int'; it might overflow.
9587a89d 6245 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6246
3e047f51
PE
6247 * sound.c: Don't assume sizes fit in 'int'.
6248 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6249 Return EMACS_INT, not int.
3e047f51 6250 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6251 Accept EMACS_INT, not int.
6252 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6253 record read return values.
6254
cc39a9db
BK
62552011-04-15 Ben Key <bkey76@gmail.com>
6256
c9d0ec6d
JB
6257 * keyboard.c (Qundefined): Don't declare static since it is used
6258 in nsfns.m.
6259 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6260 static since they are used in nsfont.m.
cc39a9db 6261
6c60eb9f
SM
62622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6263
6264 * process.c (Qprocessp): Don't declare static.
6265 * lisp.h (Qprocessp): Declare again.
6266
7990b61a
JB
62672011-04-15 Juanma Barranquero <lekktu@gmail.com>
6268
6269 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6270
5d4cb038
PE
62712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6272
8bd7b830 6273 Improve C-level modularity by making more things 'static'.
cd64ea1d 6274
e3b27b31
PE
6275 Don't publish debugger-only interfaces to other modules.
6276 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6277 (verify_bytepos, count_markers): Move decls to the only modules
6278 that need them.
6279 * region-cache.h (pp_cache): Likewise.
6280 * window.h (check_all_windows): Likewise.
6281 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6282
5d4cb038
PE
6283 * sysdep.c (croak): Now static, if
6284 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6285 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6286
6287 * alloc.c (refill_memory_reserve): Now static if
6288 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6289 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6290
e87b6180
PE
6291 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6292 Define only if USE_LUCID.
6293
ac64929e
PE
6294 * xrdb.c (x_customization_string, x_rm_string): Now static.
6295
6f37259d
PE
6296 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6297 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6298
1683e3ab
PE
6299 * xdisp.c (draw_row_with_mouse_face): Now static.
6300 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6301
de9c2632
PE
6302 * window.h (check_all_windows): Mark externally visible.
6303
2b96acb7
PE
6304 * window.c (window_deletion_count): Now static.
6305
6306 * undo.c: Make symbols static if they're not exported.
6307 (last_undo_buffer, last_boundary_position, pending_boundary):
6308 Now static.
6309
50436f33
PE
6310 * textprop.c (interval_insert_behind_hooks): Now static.
6311 (interval_insert_in_front_hooks): Likewise.
6312
64520e5c
PE
6313 * term.c: Make symbols static if they're not exported.
6314 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6315 (max_frame_lines, tty_set_terminal_modes):
6316 (tty_reset_terminal_modes, tty_turn_off_highlight):
6317 (get_tty_terminal): Now static.
6318 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6319 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6320 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6321 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6322 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6323
1fa53021
PE
6324 * sysdep.c: Make symbols static if they're not exported.
6325 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6326 Now static.
6327 (sigprocmask_set, full_mask): Remove; unused.
6328 (wait_debugging): Mark as visible.
6329 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6330 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6331
d4b43b22
PE
6332 * syntax.c (syntax_temp): Define only if !__GNUC__.
6333
b7c513d0
PE
6334 * sound.c (current_sound_device, current_sound): Now static.
6335
989b29ad
PE
6336 * search.c (searchbufs, searchbuf_head): Now static.
6337
13a55a78
PE
6338 * scroll.c (scroll_cost): Remove; unused.
6339 * dispextern.h (scroll_cost): Remove decl.
6340
de68a1fc
PE
6341 * region-cache.h (pp_cache): Mark as externally visible.
6342
40ccffa6
PE
6343 * process.c: Make symbols static if they're not exported.
6344 (process_tick, update_tick, create_process, chan_process):
6345 (Vprocess_alist, proc_buffered_char, datagram_access):
6346 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6347 (deactivate_process): Mark defn as static, as well as decl.
6348 * lisp.h (create_process): Remove decl.
6349 * process.h (chan_process, Vprocess_alist): Remove decls.
6350
ad64fc97
PE
6351 * print.c: Make symbols static if they're not exported.
6352 (print_depth, new_backquote_output, being_printed, print_buffer):
6353 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6354 (print_interval, print_number_index, initial_stderr_stream):
6355 Now static.
6356 * lisp.h (Fprinc): Remove decl.
6357 (debug_output_compilation_hack): Mark as externally visible.
6358
adddb265
PE
6359 * sysdep.c (croak): Move decl from here to syssignal.h.
6360 * syssignal.h (croak): Put it here, so the API can be checked when
6361 'croak' is called from dissociate_if_controlling_tty.
6362
1717ede2
PE
6363 * minibuf.c: Make symbols static if they're not exported.
6364 (minibuf_save_list, choose_minibuf_frame): Now static.
6365 * lisp.h (choose_minibuf_frame): Remove decl.
6366
fa5fb2bc
PE
6367 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6368
1e3890d1
PE
6369 * lread.c: Make symbols static if they're not exported.
6370 (read_objects, initial_obarray, oblookup_last_bucket_number):
6371 Now static.
6372 (make_symbol): Remove; unused.
6373 * lisp.h (initial_obarray, make_symbol): Remove decls.
6374
8a1414fa
PE
6375 * keyboard.c: Make symbols static if they're not exported.
6376 (single_kboard, recent_keys_index, total_keys, recent_keys):
6377 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6378 (this_single_command_key_start, echoing, last_auto_save):
6379 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6380 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6381 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6382 (Vlispy_mouse_stem, double_click_count):
6383 Now static.
6384 (force_auto_save_soon): Define only if SIGDANGER.
6385 (ignore_mouse_drag_p): Now static if
6386 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6387 (print_help): Remove; unused.
6388 (stop_character, last_timer_event): Mark as externally visible.
6389 * keyboard.h (ignore_mouse_drag_p): Declare only if
6390 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6391 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6392 * lisp.h (echoing): Remove decl.
6393 (force_auto_save_soon): Declare only if SIGDANGER.
6394 * xdisp.c (redisplay_window): Simplify code, to make it more
6395 obvious that ignore_mouse_drag_p is not accessed if !defined
6396 USE_GTK && !defined HAVE_NS.
6397
93ea6e8f
PE
6398 * intervals.c: Make symbols static if they're not exported.
6399 (merge_properties_sticky, merge_interval_right, delete_interval):
6400 Now static.
6401 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6402
77382fcc
PE
6403 * insdel.c: Make symbols static if they're not exported.
6404 However, leave prepare_to_modify_buffer alone. It's never
6405 called from outside this function, but that appears to be a bug.
6406 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6407 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6408 (adjust_after_replace_noundo): Remove; unused.
6409 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6410 (signal_before_change): Remove decls.
77382fcc 6411
9306c32e
PE
6412 * indent.c (val_compute_motion, val_vmotion): Now static.
6413
cd44d2eb
PE
6414 * image.c: Make symbols static if they're not exported.
6415 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6416 if USE_GTK.
6417 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6418 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6419
ad9a7a06
PE
6420 * fringe.c (standard_bitmaps): Now static.
6421 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6422
81626931
PE
6423 * frame.c: Make symbols static if they're not exported.
6424 (x_report_frame_params, make_terminal_frame): Now static.
6425 (get_frame_param): Now static, unless HAVE_NS.
6426 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6427 (x_get_resource_string): Remove; not used.
6428 * frame.h (make_terminal_frame, x_report_frame_params):
6429 (x_get_resource_string); Remove decls.
6430 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6431 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6432
239f9db9
PE
6433 * font.c, fontset.c: Make symbols static if they're not exported.
6434 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6435 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6436 * font.c (font_close_object): Now static.
6437 * font.h (font_close_object): Remove.
6438 * fontset.c (FONTSET_OBJLIST): Remove.
6439 (free_realized_fontset) #if-0 the body, which does nothing.
6440 (face_suitable_for_char_p): #if-0, as it's never called.
6441 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6442 * xfaces.c (face_at_string_position):
6443 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6444 since 0 is always ASCII.
6445
dfcf3579
PE
6446 * fns.c (weak_hash_tables): Now static.
6447
5045092b
PE
6448 * fileio.c: Make symbols static if they're not exported.
6449 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6450 (Vwrite_region_annotation_buffers): Now static.
6451
57a96f5c
PE
6452 * eval.c: Make symbols static if they're not exported.
6453 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6454 * lisp.h (backtrace_list): Remove decl.
6455
35f08c38
PE
6456 * emacs.c: Make symbols static if they're not exported.
6457 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6458 (fatal_error_code, fatal_error_signal_hook, standard_args):
6459 Now static.
6460 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6461 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6462 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6463 * lisp.h (fatal_error_signal_hook): Remove decl.
6464 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6465
f44bd759
PE
6466 * editfns.c: Move a (normally-unused) function to its only use.
6467 * editfns.c, lisp.h (get_operating_system_release): Remove.
6468 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6469 worth the hassle of breaking this out.
6470
b532497d
PE
6471 * xterm.c: Make symbols static if they're not exported.
6472 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6473 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6474 (x_destroy_window, x_delete_display):
6475 Now static.
6476 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6477 (x_mouse_leave): Remove; unused.
6478 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6479 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6480 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6481 Remove decls.
6482 (x_mouse_leave): Declare only if WINDOWSNT.
6483 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6484 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6485 USE_X_TOOLKIT.
6486
1675728f
PE
6487 * ftxfont.c: Make symbols static if they're not exported.
6488 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6489 HAVE_FREETYPE.
6490 * font.h (ftxfont_driver): Likewise.
6491
e4cebfca
PE
6492 * xfns.c: Make symbols static if they're not exported.
6493 (x_last_font_name, x_display_info_for_name):
6494 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6495 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6496 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6497 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6498 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6499 (last_show_tip_args): Now static.
6500 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6501 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6502 (x_screen_planes): Remove; unused.
6503 * dispextern.h (x_screen_planes): Remove decl.
6504
5bf46f05
PE
6505 * dispnew.c: Make symbols static if they're not exported.
6506 * dispextern.h (redraw_garbaged_frames, scrolling):
6507 (increment_row_positions): Remove.
6508 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6509 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6510 Now static.
6511 (redraw_garbaged_frames): Remove; unused.
6512
435f4c28
PE
6513 * xfaces.c: Make symbols static if they're not exported.
6514 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6515 Remove decls.
6516 * xterm.h (defined_color): Remove decls.
6517 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6518 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6519 (menu_face_changed_default, defined_color, free_realized_face):
6520 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6521 (ascii_face_of_lisp_face): Remove; unused.
6522
8524aef3
PE
6523 * xdisp.c: Make symbols static if they're not exported.
6524 * dispextern.h (scratch_glyph_row, window_box_edges):
6525 (glyph_to_pixel_coords, set_cursor_from_row):
6526 (get_next_display_element, set_iterator_to_next):
6527 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6528 (show_mouse_face): Remove decls
6529 * frame.h (message_buf_print): Likewise.
6530 * lisp.h (pop_message, set_message, check_point_in_composition):
6531 Likewise.
6532 * xterm.h (set_vertical_scroll_bar): Likewise.
6533 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6534 (message_buf_print, scratch_glyph_row, displayed_buffer):
6535 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6536 (get_next_display_element, show_mouse_face, window_box_edges):
6537 (frame_to_window_pixel_xy, check_point_in_composition):
6538 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6539 (glyph_to_pixel_coords): Remove; unused.
6540
16390cd2
PE
6541 * dired.c (file_name_completion): Now static.
6542
6543 * dbusbind.c (xd_in_read_queued_messages): Now static.
6544
a25f4dfa
PE
6545 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6546 * data.c (circular_list_error): Remove.
6547
14a9c8df
PE
6548 * commands.h (last_point_position, last_point_position_buffer):
6549 (last_point_position_window): Remove decls.
6550 * keyboard.c: Make these variables static.
6551
04f2d78b
CB
6552 * coding.h (coding, code_convert_region, encode_coding_gap):
6553 Remove decls.
74ab6df5
PE
6554 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6555 (iso_code_class, detect_coding, code_convert_region): Now static.
6556 (encode_coding_gap): Remove; unused.
6557
38dfbee1
PE
6558 * chartab.c (chartab_chars, chartab_bits): Now static.
6559
a2cb4e63
PE
6560 * charset.h (charset_iso_8859_1): Remove decl.
6561 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6562 Now static.
6563
127198fd
PE
6564 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6565 * ccl.c (Vccl_program_table): Now static.
6566 (check_ccl_update): Remove; unused.
6567
d85b608f
PE
6568 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6569 * category.h: ... from here.
6570 * category.c (check_category_table, set_category_set): Now static.
6571
31cd66f3
PE
6572 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6573 * lisp.h: Remove these decls.
6574
c358e587
PE
6575 * buffer.c (buffer_count): Remove unused var.
6576
e78aecca
PE
6577 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6578 so that it's not optimized away.
6579 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6580 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6581 exported only to the debugger.
6582
e192d7d3 6583 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6584 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6585
92470028
PE
6586 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6587 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6588 was inaccessible from Lisp.
6589 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6590 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6591
244ed907
PE
6592 alloc.c: Import and export fewer symbols, and remove unused items.
6593 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6594 is defined.
6595 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6596 it's not optimized away by whole-program optimization.
6597 (message_enable_multibyte, free_misc): Remove.
6598 (catchlist, handlerlist, mark_backtrace):
6599 Declare only if BYTE_MARK_STACK.
6600 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6601 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6602 (message_enable_multibyte): Remove decl.
6603 (free_misc, interval_free_list, float_block, float_block_index):
6604 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6605 (cons_free_list, last_marked_index):
6606 Now static.
6607 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6608 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6609 (mark_backtrace): Define only if BYTE_MARK_STACK.
6610 * xdisp.c (message_enable_multibyte): Now static.
6611
61c2b50e 6612 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6613 This makes it easier for human readers (and static analyzers)
6614 to see whether these variables are used from other modules.
6615 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6616 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6617 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6618 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6619 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6620 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6621 * xmenu.c, xselect.c:
6622 Declare Q* vars static if they are not used in other modules.
6623 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6624 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6625 Remove decls of unexported vars.
6626 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6627
95c82688
PE
6628 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6629
16a97296
PE
6630 Make Emacs functions such as Fatom 'static' by default.
6631 This makes it easier for human readers (and static analyzers)
6632 to see whether these functions can be called from other modules.
6633 DEFUN now defines a static function. To make the function external
6634 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6635 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6636 (Finit_image_library):
16a97296
PE
6637 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6638 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6639 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6640 Remove decls, since these functions are now static.
6641 (Funintern, Fget_internal_run_time): New decls, since these functions
6642 were already external.
95c82688 6643
16a97296
PE
6644 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6645 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6646 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6647 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6648 * keyboard.c, keymap.c, lread.c:
6649 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6650 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6651 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6652 Mark functions with DEFUE instead of DEFUN,
6653 if they are used in other modules.
6654 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6655 decls for now-static functions.
6656 * buffer.h (Fdelete_overlay): Remove decl.
6657 * callproc.c (Fgetenv_internal): Mark as internal.
6658 * composite.c (Fremove_list_of_text_properties): Remove decl.
6659 (Fcomposition_get_gstring): New forward static decl.
6660 * composite.h (Fcomposite_get_gstring): Remove decl.
6661 * dired.c (Ffile_attributes): New forward static decl.
6662 * doc.c (Fdocumntation_property): New forward static decl.
6663 * eval.c (Ffetch_bytecode): New forward static decl.
6664 (Funintern): Remove extern decl; now in .h file where it belongs.
6665 * fileio.c (Fmake_symbolic_link): New forward static decl.
6666 * image.c (Finit_image_library): New forward static decl.
6667 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6668 * intervals.h (Fprevious_property_change):
6669 (Fremove_list_of_text_properties): Remove decls.
6670 * keyboard.c (Fthis_command_keys): Remove decl.
6671 (Fcommand_execute): New forward static decl.
6672 * keymap.c (Flookup_key): New forward static decl.
6673 (Fcopy_keymap): Now static.
6674 * keymap.h (Flookup_key): Remove decl.
6675 * process.c (Fget_process): New forward static decl.
6676 (Fprocess_datagram_address): Mark as internal.
6677 * syntax.c (Fsyntax_table_p): New forward static decl.
6678 (skip_chars): Remove duplicate decl.
6679 * textprop.c (Fprevious_property_change): New forward static decl.
6680 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6681 Now internal.
6682 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6683 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6684
785bbd42
PE
6685 * editfns.c (Fformat): Remove unreachable code.
6686
8b913b57
AS
66872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6688
6689 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6690 change. (Bug#8496)
6691
a6744a35
EZ
66922011-04-13 Eli Zaretskii <eliz@gnu.org>
6693
6694 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6695 when at ZV. (Bug#8487)
6696
e7974947
AS
66972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6698
baad03f0
AS
6699 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6700 (Bug#8437)
6701 * keyboard.c (parse_tool_bar_item): Likewise.
6702 * sound.c (sound_cleanup, alsa_close): Likewise.
6703 * termcap.c (tgetent): Likewise.
6704 * xfns.c (x_default_font_parameter): Likewise.
6705 * xsettings.c (read_and_apply_settings): Likewise.
6706
e7974947
AS
6707 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6708 (overrun_check_free): Protoize.
6709
28272684
PE
67102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6711
6712 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6713 since callers should never pass a negative size.
6714 Change the signature to match that of plain 'read' and 'write'; see
6715 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6716 * lisp.h: Update prototypes of emacs_write and emacs_read.
6717
11997c76
EZ
67182011-04-11 Eli Zaretskii <eliz@gnu.org>
6719
6720 * xdisp.c (redisplay_window): Don't try to determine the character
6721 position of the scroll margin if the window start point w->startp
e896f03c 6722 is outside the buffer's accessible region. (Bug#8468)
11997c76 6723
8a2cbd72
EZ
67242011-04-10 Eli Zaretskii <eliz@gnu.org>
6725
6726 Fix write-region and its subroutines for buffers > 2GB.
6727 * fileio.c (a_write, e_write): Modify declaration of arguments and
6728 local variables to support buffers larger than 2GB.
6729 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6730
6731 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6732 argument, local variables, and return value.
6733
6734 * lisp.h: Update prototypes of emacs_write and emacs_read.
6735
6736 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6737
4073e537 67382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6739
1ebfdcb6
PE
6740 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6741
b2ded58d
PE
6742 Fix more problems found by GCC 4.6.0's static checks.
6743
7d66342c
PE
6744 * xdisp.c (vmessage): Use a better test for character truncation.
6745
bbf47d44
PE
6746 * charset.c (load_charset_map): <, not <=, for optimization,
6747 and to avoid potential problems with integer overflow.
9248994d 6748 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6749 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6750 * editfns.c (Fformat): Likewise.
1e69125e 6751 * syntax.c (skip_chars): Likewise.
3befa583 6752
e3019616
PE
6753 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6754 This also lets GCC 4.6.0 generate slightly better loop code.
6755
becfa255
PE
6756 * callint.c (Fcall_interactively): <, not <=, for optimization.
6757 (Fcall_interactively): Count the number of arguments produced,
6758 not the number of arguments given. This is simpler and lets GCC
6759 4.6.0 generate slightly better code.
6760
dae0cd48
PE
6761 * ftfont.c: Distingish more carefully between FcChar8 and char.
6762 The previous code passed unsigned char * to a functions like
6763 strlen and xstrcasecmp that expect char *, which does not
6764 conform to the C standard.
6765 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6766 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6767 char * when the C standard requires it.
6768
76032d70
PE
6769 * keyboard.c (read_char): Remove unused var.
6770
eb3f1cc8
PE
6771 * eval.c: Port to Windows vsnprintf (Bug#8435).
6772 Include <limits.h>.
6773 (SIZE_MAX): Define if the headers do not.
6774 (verror): Do not give up if vsnprintf returns a negative count.
6775 Instead, grow the buffer. This ports to Windows vsnprintf, which
6776 does not conform to C99. Problem reported by Eli Zaretskii.
6777 Also, simplify the allocation scheme, by avoiding the need for
6778 calling realloc, and removing the ALLOCATED variable.
6779
70476b54
PE
6780 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6781
12020a9e
PE
6782 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6783 But keep the doprint source code for now, as we might revamp it
6784 and use it again (Bug#8435).
ea6c7ae6
PE
6785 * lisp.h (doprnt): Remove.
6786 * Makefile.in (base_obj): Remove doprnt.o.
6787 * deps.mk (doprnt.o): Remove.
6788
5fdb398c
PE
6789 error: Print 32- and 64-bit integers portably (Bug#8435).
6790 Without this change, on typical 64-bit hosts error ("...%d...", N)
6791 was used to print both 32- and 64-bit integers N, which relied on
6792 undefined behavior.
6793 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6794 New macro.
6795 * lisp.h (error, verror): Mark as printf-like functions.
6796 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6797 Report overflow in size calculations when allocating printf buffer.
6798 Do not truncate output string at its first null byte.
6799 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6800 Truncate the output at a character boundary, since vsnprintf does not
6801 do that.
6802 * charset.c (check_iso_charset_parameter): Convert internal
6803 character to string before calling 'error', since %c now has the
6804 printf meaning.
6805 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6806 overflow when computing char to be passed to 'error'. Do not
6807 pass Lisp_Object to 'error'; pass the integer instead.
6808 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6809 formatted with plain %d.
6810
b189fa66
PE
6811 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6812
bff87ef0
PE
6813 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6814
7e2cac20
PE
6815 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6816
ce4d90b5
PE
6817 * xterm.c (x_catch_errors): Remove duplicate declaration.
6818
266c9547
PE
6819 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6820
79c49ad2
PE
6821 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6822
368f4090
JM
68232011-04-10 Jim Meyering <meyering@redhat.com>
6824
6825 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6826 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6827 return ssize_t not "int", and use size_t as the buffer length.
6828 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6829 * gnutls.h: Update declarations.
6830 * process.c (read_process_output): Use ssize_t, to match.
6831 (send_process): Likewise.
6832
a32d4040
CY
68332011-04-09 Chong Yidong <cyd@stupidchicken.com>
6834
6835 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6836
8546720e 68372011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6838
04f2d78b
CB
6839 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6840 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6841
8546720e
GM
6842 * xterm.c (handle_one_xevent):
6843 * xmenu.c (create_and_show_popup_menu):
6844 * xselect.c (x_decline_selection_request)
6845 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6846
0a2f5c1a 68472011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6848
6849 Fix some uses of `int' instead of EMACS_INT.
6850 * search.c (string_match_1, fast_string_match)
6851 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6852 (scan_buffer, find_next_newline_no_quit)
6853 (find_before_next_newline, search_command, Freplace_match)
6854 (Fmatch_data): Make some `int' variables be EMACS_INT.
6855
6856 * xdisp.c (display_count_lines): 3rd argument and return value now
6857 EMACS_INT. All callers changed.
6858 (pint2hrstr): Last argument is now EMACS_INT.
6859
6860 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6861 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6862 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6863 (decode_coding_utf_16, decode_coding_emacs_mule)
6864 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6865 (decode_coding_ccl, decode_coding_charset)
6866 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6867 (decode_coding_iso_2022, decode_coding_emacs_mule)
6868 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6869 <char_offset, last_offset>: Declare EMACS_INT.
6870 (encode_coding_utf_8, encode_coding_utf_16)
6871 (encode_coding_emacs_mule, encode_invocation_designation)
6872 (encode_designation_at_bol, encode_coding_iso_2022)
6873 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6874 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6875 Declare EMACS_INT.
6876 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6877 (encode_invocation_designation): Last argument P_NCHARS is now
6878 EMACS_INT.
6879 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6880 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6881
6882 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6883 All users changed.
6884
6885 * ccl.c (Fccl_execute_on_string): Declare some variables
6886 EMACS_INT.
6887
8546720e 68882011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6889
6890 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6891
4e19a977
CS
68922011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6893
6894 * process.c (Fformat_network_address): Doc fix.
6895
87302331
R
68962011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6897
6898 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6899
cbb59342
CY
69002011-04-08 Chong Yidong <cyd@stupidchicken.com>
6901
6902 * keyboard.c (read_char): Call Lisp function help-form-show,
6903 instead of using internal_with_output_to_temp_buffer.
6904 (Qhelp_form_show): New var.
e0d38eeb 6905 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6906
6907 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6908
6909 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6910
e67a13ab
CY
69112011-04-06 Chong Yidong <cyd@stupidchicken.com>
6912
04f2d78b
CB
6913 * process.c (Flist_processes): Remove to Lisp.
6914 (list_processes_1): Delete.
e67a13ab 6915
973f782d
EZ
69162011-04-06 Eli Zaretskii <eliz@gnu.org>
6917
7c106b1e
EZ
6918 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6919
973f782d
EZ
6920 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6921
41cf7d1a 69222011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6923
ca23cc88
PE
6924 Fix more problems found by GCC 4.6.0's static checks.
6925
f390e2d5
PE
6926 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6927
42eea0d0
PE
6928 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6929
b69769da 6930 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6931
f9541e84
PE
6932 * xdisp.c (vmessage): Mark as a printf-like function.
6933
13841b55
PE
6934 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6935
c136c10f
PE
6936 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6937
5e2d4a30
PE
6938 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6939 printf-like functions.
6940 (tiff_load): Add casts to remove these marks before passing them
6941 to system-supplied API.
6942
583f48b9
PE
6943 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6944
b25d760e
PE
6945 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6946 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6947 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6948 directly, rather than having caller test rule sign. This avoids
6949 some unnecessary tests.
6950 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6951 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6952 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6953
bc7b6697 6954 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6955 (xfont_open): Avoid unnecessary tests.
bc7b6697 6956
27ccc379
PE
6957 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6958
dcd5c89a
PE
6959 * composite.h, composite.c (composition_gstring_put_cache):
6960 Use EMACS_INT, not int, for length.
6961
b13a45c6
PE
6962 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6963 breaking out part of COMPOSITION_DECODE_RULE.
6964 (COMPOSITION_DECODE_RULE): Use it.
6965 * composite.c (get_composition_id): Remove unused local vars,
6966 by using the new macro.
6967
1e792e4d
PE
6968 * textprop.c (set_text_properties_1): Change while to do-while,
6969 since the condition is always true at first.
6970
dc6c6455 6971 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6972 (interval_deletion_adjustment): Return unsigned value.
6973 All uses changed.
dc6c6455 6974
aba7731a
PE
6975 * process.c (list_processes_1, create_pty, read_process_output):
6976 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6977 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6978 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6979 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6980 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6981
fdfc4bf3
PE
6982 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6983
fca8fe46 6984 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6985 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6986
06a0259a 6987 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6988 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6989 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6990
e7b9e80f
PE
6991 * print.c (print_error_message): Avoid int overflow.
6992
56201685
PE
6993 * font.c (font_list_entities): Redo for clarity,
6994 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6995
78834453 6996 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6997 (font_score): Avoid potential overflow in diff calculation.
78834453 6998
0bc0b309 6999 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7000 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7001
e610eaca
PE
7002 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7003
b895abce
PE
7004 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7005 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7006 can always succeed if overflow has undefined behavior.
7007
1f1d9321 7008 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7009 (wordify): Omit three unnecessary tests.
1f1d9321 7010
c59478bc
PE
7011 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7012 All callers changed. This avoids the need for an unused var.
7013
79b73827
PE
7014 * casefiddle.c (casify_region): Remove var that is set but not used.
7015
a4db5dfe
PE
7016 * dired.c (file_name_completion): Remove var that is set but not used.
7017
43aae36e
PE
7018 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7019
2a47c44d 7020 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7021 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7022
a37c69bf
PE
7023 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7024 Check for integer overflow on size calculations.
7025
328ab8e7
PE
7026 * buffer.c (Fprevious_overlay_change): Remove var that is set
7027 but not used.
7028
e5a2a5cb
PE
7029 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7030 Remove vars that are set but not used.
8d84a6eb 7031 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7032 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7033
a60e5f68
PE
7034 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7035
f661cb61 7036 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7037 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7038
f0397f5a
PE
7039 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7040 that are set but not used.
7041
8664db06 7042 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7043 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7044
6abdaa4a
PE
7045 * xselect.c (x_get_local_selection, x_handle_property_notify):
7046 Remove vars that are set but not used.
7047
0ce7538d 7048 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7049 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7050
9ae848fc
PE
7051 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7052 Remove var that is set but not used.
0b918413
PE
7053 (scroll_bar_windows_size): Now size_t, not int.
7054 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7055 Check for overflow.
9ae848fc 7056
a5a62657
PE
7057 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7058 (map_tty_color) [!defined MSDOS]: Likewise.
7059
5c5cdd39
PE
7060 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7061
66ebf983
PE
7062 * coding.c: Remove vars that are set but not used.
7063 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7064 All callers changed.
7065 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7066 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7067 (decode_coding_charset): Remove vars that are set but not used.
7068
1be4d761
PE
7069 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7070 that is set but not used.
7071
47553fa8
PE
7072 * print.c (print_object): Remove var that is set but not used.
7073
1f7196bf 7074 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7075 The gnulib version avoids calling malloc in the usual case,
7076 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7077 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7078 * filelock.c (current_lock_owner): Likewise.
7079 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7080 * sysdep.c: Include allocator.h, careadlinkat.h.
7081 (emacs_no_realloc_allocator): New static constant.
7082 (emacs_readlink): New function.
fdb61804
PE
7083 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7084 ../lib/careadlinkat.h.
d1fdcab7 7085
f84c17c7
SM
70862011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7087
7088 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7089 first non-nil return value).
7090
ef3862ad
JD
70912011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7092
7093 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7094 if not defined (Bug#8403).
7095
376a7006
JB
70962011-04-02 Juanma Barranquero <lekktu@gmail.com>
7097
7098 * xdisp.c (display_count_lines): Remove parameter `start',
7099 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7100 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7101 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7102 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7103 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7104 and thereabouts. All callers changed.
7105 (get_per_char_metric): Remove parameter `f', unused since
7106 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7107
6ca3801d
JM
71082011-04-02 Jim Meyering <meyering@redhat.com>
7109
7110 do not dereference NULL upon failed strdup
7111 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7112 (ns_get_family): Likewise.
7113
d8e2b5ba
JB
71142011-04-02 Juanma Barranquero <lekktu@gmail.com>
7115
7116 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7117
8c74fcbd
JD
71182011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7119
7120 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7121 later (Bug#8403).
7122
7200d79c
SM
71232011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7124
03408648 7125 Add lexical binding.
7200d79c 7126
03408648
SM
7127 * window.c (Ftemp_output_buffer_show): New fun.
7128 (Fsave_window_excursion):
7129 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7130
7131 * lread.c (lisp_file_lexically_bound_p): New function.
7132 (Fload): Bind Qlexical_binding.
7133 (readevalloop): Remove `evalfun' arg.
7134 Bind Qinternal_interpreter_environment.
7135 (Feval_buffer): Bind Qlexical_binding.
7136 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7137 Mark as dynamic.
7138 (syms_of_lread): Declare `lexical-binding'.
7139
7140 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7141
7142 * keyboard.c (eval_dyn): New fun.
7143 (menu_item_eval_property): Use it.
ca105506
SM
7144
7145 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7146
03408648
SM
7147 * fns.c (concat, mapcar1): Accept byte-code-functions.
7148
7149 * eval.c (Fsetq): Handle lexical vars.
7150 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7151 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7152 (FletX, Flet): Obey lexical binding.
7153 (Fcommandp): Handle closures.
7154 (Feval): New `lexical' arg.
7155 (eval_sub): New function extracted from Feval. Use it almost
7156 everywhere where Feval was used. Look up vars in lexical env.
7157 Handle closures.
7158 (Ffunctionp): Move from subr.el.
7159 (Ffuncall): Handle closures.
7160 (apply_lambda): Remove `eval_flags'.
7161 (funcall_lambda): Handle closures and new byte-code-functions.
7162 (Fspecial_variable_p): New function.
7163 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7164 but without exporting it to Lisp.
23aba0ea 7165
23aba0ea 7166 * doc.c (Fdocumentation, store_function_docstring):
03408648 7167 * data.c (Finteractive_form): Handle closures.
23aba0ea 7168
03408648
SM
7169 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7170 interactive spec.
ba83908c 7171
04f2d78b
CB
7172 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7173 New byte-codes.
03408648
SM
7174 (exec_byte_code): New function extracted from Fbyte_code to handle new
7175 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7176
03408648 7177 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7178
03408648 7179 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7180
e2abce01
JB
71812011-03-31 Juanma Barranquero <lekktu@gmail.com>
7182
7183 * xdisp.c (redisplay_internal): Fix prototype.
7184
63696a73 71852011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7186
63696a73 7187 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7188 (try_scrolling): Use it when setting scroll_limit.
7189 Limit scrolling to 100 screen lines.
63696a73
EZ
7190 (redisplay_window): Even when falling back on "recentering",
7191 position point in the window according to scroll-conservatively,
7192 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7193
7194 (try_scrolling): When point is above the window, allow searching
7195 as far as scroll_max, or one screenful, to compute vertical
7196 distance from PT to the scroll margin position. This prevents
7197 try_scrolling from unnecessarily failing when
7198 scroll-conservatively is set to a value slightly larger than the
7199 window height. Clean up the case of PT below the margin at bottom
7200 of window: scroll_max can no longer be INT_MAX. When aggressive
7201 scrolling is in use, don't let point enter the opposite scroll
7202 margin as result of the scroll.
7203 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7204 threshold of 100 lines for never-recentering scrolling.
7205
e4cc2dfc
JB
72062011-03-31 Juanma Barranquero <lekktu@gmail.com>
7207
7208 * dispextern.h (move_it_by_lines):
7209 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7210 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7211 (message_log_check_duplicate): Remove parameters `prev_bol' and
7212 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7213 (redisplay_internal): Remove parameter `preserve_echo_area',
7214 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7215
7216 * indent.c (Fvertical_motion):
7217 * window.c (window_scroll_pixel_based, Frecenter):
7218 Don't pass `need_y_p' to `move_it_by_lines'.
7219
1c470562
SM
72202011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7221
44f230aa
SM
7222 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7223 steal a few bits to be more compact.
7224 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7225 Remove unneeded casts.
7226
1c470562
SM
7227 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7228
888adce9
ZK
72292011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7230
7231 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7232 binding" message (bug#7967).
7233
f838ed7b
PE
72342011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7235
77861b95
PE
7236 Fix more problems found by GCC 4.6.0's static checks.
7237
de6dbc14
PE
7238 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7239 Remove unused local var.
7240
f838ed7b
PE
7241 * editfns.c (Fmessage_box): Remove unused local var.
7242
792c7b2b
PE
7243 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7244 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7245 Omit unused local vars.
c499e557 7246 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7247 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7248 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7249 Omit unused local var.
7250
ba0165e1
PE
7251 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7252 Don't assume string length fits in int.
32ad8845 7253 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7254 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7255
3c59b4c9
PE
7256 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7257 instead of alloca (Bug#8344).
7258
a3eed478 7259 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7260 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7261
eb4d412d
PE
7262 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7263
1658b401
PE
7264 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7265 concerns.
7266
7267 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7268
7269 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7270
9a2c6e05
PE
7271 * keyboard.c (syms_of_keyboard): Use the same style as later
7272 in this function when indexing through an array. This also
7273 works around GCC bug 48267.
7274
03d0a109
PE
7275 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7276
44f730c8
PE
7277 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7278
fe75f926
PE
7279 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7280 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7281
ffa8c828
PE
7282 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7283 This avoids undefined behavior on integer overflow, and is a bit
7284 more convenient anyway since it is compared to a size_t variable.
7285
c5101a77
PE
7286 Variadic C functions now count arguments with size_t, not int.
7287 This avoids an unnecessary limitation on 64-bit machines, which
7288 caused (substring ...) to crash on large vectors (Bug#8344).
7289 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7290 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7291 All variadic functions and their callers changed accordingly.
c5101a77
PE
7292 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7293 * data.c (arith_driver, float_arith_driver): Likewise.
7294 * editfns.c (general_insert_function): Likewise.
7295 * eval.c (struct backtrace.nargs, interactive_p)
7296 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7297 (funcall_lambda, mark_backtrace): Likewise.
7298 * fns.c (concat): Likewise.
7299 * frame.c (x_set_frame_parameters): Likewise.
7300 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7301 0 if not found, not -1. All callers changed.
7302
dd3f25f7
PE
7303 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7304 (stack_copy_size): Now size_t, not int.
7305 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7306
461c2ab9
JB
73072011-03-28 Juanma Barranquero <lekktu@gmail.com>
7308
7309 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7310 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7311 All callers changed.
7312
7313 * lisp.h (multibyte_char_to_unibyte):
7314 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7315 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7316 * character.h (CHAR_TO_BYTE8):
7317 * cmds.c (internal_self_insert):
7318 * editfns.c (general_insert_function):
7319 * keymap.c (push_key_description):
7320 * search.c (Freplace_match):
7321 * xdisp.c (message_dolog, set_message_1): All callers changed.
7322
f6d62986
SM
73232011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7324
7325 * keyboard.c (safe_run_hook_funcall): New function.
7326 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7327 don't set the hook to nil, but remove the offending function instead.
7328 (Qcommand_hook_internal): Remove, unused.
7329 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7330 Vcommand_hook_internal.
7331
7332 * eval.c (enum run_hooks_condition): Remove.
7333 (funcall_nil, funcall_not): New functions.
7334 (run_hook_with_args): Call each function through a `funcall' argument.
7335 Remove `cond' argument, now redundant.
7336 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7337 (Frun_hook_with_args_until_failure): Adjust accordingly.
7338 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7339
1db5b1ad
JB
73402011-03-28 Juanma Barranquero <lekktu@gmail.com>
7341
7342 * dispextern.h (string_buffer_position): Remove declaration.
7343
7344 * print.c (strout): Remove parameter `multibyte', unused since
7345 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7346
7347 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7348 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7349 All callers changed.
7350
7351 * w32.c (_wsa_errlist): Use braces for struct initializers.
7352
7353 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7354 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7355 All callers changed.
7356 (string_buffer_position): Likewise. Also, make static (it's never
7357 used outside xdisp.c).
7358 (cursor_row_p): Remove parameter `w', unused since
7359 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7360 (decode_mode_spec): Remove parameter `precision', introduced during
7361 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7362 All callers changed.
7363
5ffb62aa
JD
73642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7365
7366 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7367
461c2ab9 73682011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7369
7370 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7371 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7372 (ns_update_auto_hide_menu_bar): New functions.
7373 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7374 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7375 ns_constrain_all_frames.
7376 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7377 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7378
5c380ffb
JD
73792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7380
7381 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7382
9af30bdf
GM
73832011-03-27 Glenn Morris <rgm@gnu.org>
7384
7385 * syssignal.h: Replace RETSIGTYPE with void.
7386 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7387 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7388 Replace SIGTYPE with void everywhere.
7389 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7390 * s/template.h (SIGTYPE): Remove commented out definition.
7391
e2abce01
JB
73922011-03-26 Eli Zaretskii <eliz@gnu.org>
7393
7394 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7395 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7396
f868cd8a
JB
73972011-03-26 Juanma Barranquero <lekktu@gmail.com>
7398
59eb0929
JB
7399 * w32.c (read_unc_volume): Use parameter `henum', instead of
7400 global variable `wget_enum_handle'.
7401
7402 * keymap.c (describe_vector): Remove parameters `indices' and
7403 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7404 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7405
f868cd8a
JB
7406 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7407
7408 * keyboard.c (timer_check): Remove parameter `do_it_now',
7409 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7410 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7411 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7412
7413 * keyboard.c (read_char):
7414 * w32menu.c (w32_menu_display_help):
7415 * xmenu.c (show_help_event, menu_help_callback):
7416 Adjust calls to `show_help_echo'.
7417
7418 * gtkutil.c (xg_maybe_add_timer):
7419 * keyboard.c (readable_events):
7420 * process.c (wait_reading_process_output):
7421 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7422
7423 * insdel.c (adjust_markers_gap_motion):
7424 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7425 (gap_left, gap_right): Don't call it.
7426
2ecf6fdb
CY
74272011-03-25 Chong Yidong <cyd@stupidchicken.com>
7428
7429 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7430 incurred during fontification.
7431
6b1f9ba4
JB
74322011-03-25 Juanma Barranquero <lekktu@gmail.com>
7433
7434 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7435 (DEFVAR_PER_BUFFER): Don't pass it.
7436
7437 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7438 (scrolling_window): Don't pass it.
7439
0f4a96b5
JB
74402011-03-25 Juanma Barranquero <lekktu@gmail.com>
7441
7442 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7443
7444 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7445 and `suffix'.
7446 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7447 of variables specific to SELinux and computation of `encoded_absname'.
7448
7449 * image.c (XPutPixel): Remove unused variable `height'.
7450
7451 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7452
7453 * unexw32.c (get_section_info): Remove unused variable `section'.
7454
7455 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7456 (system_process_attributes): Remove unused variable `sess'.
7457 (sys_read): Remove unused variable `err'.
7458
7459 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7460 (w32_wnd_proc): Remove unused variable `isdead'.
7461 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7462 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7463 (x_create_tip_frame): Remove unused variable `tem'.
7464
7465 * w32inevt.c (w32_console_read_socket):
7466 Remove unused variable `no_events'.
7467
7468 * w32term.c (x_draw_composite_glyph_string_foreground):
7469 Remove unused variable `width'.
7470
1149507c
JB
74712011-03-24 Juanma Barranquero <lekktu@gmail.com>
7472
7473 * w32term.c (x_set_glyph_string_clipping):
7474 Don't pass uninitialized region to CombineRgn.
7475
9c88f339
JB
74762011-03-23 Juanma Barranquero <lekktu@gmail.com>
7477
7478 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7479 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7480 (Fx_close_connection): Remove unused variable `i'.
7481
7482 * w32font.c (w32font_draw): Return number of glyphs.
7483 (w32font_open_internal): Remove unused variable `i'.
7484 (w32font_driver): Add missing initializer.
7485
7486 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7487 (fill_in_menu): Remove unused variable `items_added'.
7488
7489 * w32term.c (last_mouse_press_frame): Remove static global variable.
7490 (w32_clip_to_row): Remove unused variable `f'.
7491 (x_delete_terminal): Remove unused variable `i'.
7492
7493 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7494 (NOTHING): Remove unused static global variable.
7495 (uniscribe_check_otf): Remove unused variable `table'.
7496 (uniscribe_font_driver): Add missing initializers.
7497
dee091a3
JD
74982011-03-23 Julien Danjou <julien@danjou.info>
7499
7500 * term.c (Fsuspend_tty, Fresume_tty):
7501 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7502 * window.c (temp_output_buffer_show):
7503 * insdel.c (signal_before_change):
7504 * frame.c (Fhandle_switch_frame):
7505 * fileio.c (Fdo_auto_save):
7506 * emacs.c (Fkill_emacs):
7507 * editfns.c (save_excursion_restore):
7508 * cmds.c (internal_self_insert):
7509 * callint.c (Fcall_interactively):
7510 * buffer.c (Fkill_all_local_variables):
7511 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7512 Use Frun_hooks.
0f4a96b5 7513 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7514 unconditionnaly since it does the check itself.
7515
2c520ab5 75162011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7517
c9c49752
PE
7518 Fix more problems found by GCC 4.5.2's static checks.
7519
8abc3f12
PE
7520 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7521 the first time through the loop, since we know p0 < p1 then.
7522 This also avoids a gcc -Wstrict-overflow warning.
7523
a2d26660
PE
7524 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7525 leading to a memory leak, possible in functions like
7526 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7527 of objects (Bug#8318).
a2d26660 7528
916c72e9
PE
7529 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7530 that could (at least in theory) be that large.
7531
19ab8a18
PE
7532 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7533 This is less likely to overflow, and avoids undefined behavior if
7534 overflow does occur. All callers changed. Use strtoul to scan
7535 for the unsigned long integer.
b7cbbd6f
PE
7536 (pint2hrstr): Simplify and tune code slightly.
7537 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7538
f0641eff
PE
7539 * scroll.c (do_scrolling): Work around GCC bug 48228.
7540 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7541
7f650bb9
PE
7542 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7543 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7544 (validate_x_resource_name): Simplify count usage.
7545 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7546
37dd57d1
PE
7547 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7548 fail (Bug#8306).
81e56e61 7549
699979fc 7550 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7551
401bf9b4
PE
7552 * process.c (Fmake_network_process): Use socklen_t, not int,
7553 where POSIX says socklen_t is required in portable programs.
7554 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7555 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7556 (Fmake_network_process, server_accept_connection):
7557 (wait_reading_process_output, read_process_output):
7558 Likewise.
7559
b93aacde
PE
7560 * process.c: Rename or move locals to avoid shadowing.
7561 (list_processes_1, Fmake_network_process):
7562 (read_process_output_error_handler, exec_sentinel_error_handler):
7563 Rename or move locals.
4dc343ee 7564 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7565 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7566 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7567 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7568 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7569
af8a867c 7570 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7571 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7572 Include tparam.h instead, since it declares them.
af8a867c
PE
7573 * cm.h (PC): Remove extern decl; tparam.h now does this.
7574 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7575 * terminfo.c: Include tparam.h, to check interfaces.
7576 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7577 (tparam): Adjust signature to match interface in tparam.h;
7578 this removes some undefined behavior. Check that outstring and len
7579 are zero, which they always are with Emacs.
7580 * tparam.h (PC, BC, UP): New extern decls.
7581
0248044d 7582 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7583 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7584
8ff096c1 7585 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7586 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7587 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7588 (ftfont_list): Remove unused local.
49eaafba
PE
7589 (get_adstyle_property, ftfont_pattern_entity):
7590 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7591 Rename locals to avoid shadowing.
8ff096c1 7592
e2be39f6
PE
7593 * xfont.c (xfont_list_family): Mark var as initialized.
7594
c9735e30
PE
7595 * xml.c (make_dom): Now static.
7596
8f5201ae
PE
7597 * composite.c (composition_compute_stop_pos): Rename local to
7598 avoid shadowing.
b246f932
PE
7599 (composition_reseat_it): Remove unused locals.
7600 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7601 (composition_update_it): Mark var as initialized.
11b61122
PE
7602 (find_automatic_composition): Mark vars as initialized,
7603 with a FIXME (Bug#8290).
8f5201ae 7604
760fbc2c
PE
7605 character.h: Rename locals to avoid shadowing.
7606 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7607 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7608 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7609 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7610 to avoid shadowing.
7611
ff08eb85
PE
7612 * textprop.c (property_change_between_p): Remove; unused.
7613
fc7bf025
PE
7614 * intervals.c (interval_start_pos): Now static.
7615
235d7abc
PE
7616 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7617
44f230aa
SM
7618 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7619 Rename locals to avoid shadowing.
3e7d6594 7620
50060332
PE
7621 * sound.c (wav_play, au_play, Fplay_sound_internal):
7622 Fix pointer signedness.
d01f234b 7623 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7624 (wav_play): Initialize a variable to 0, to prevent undefined
7625 behavior (Bug#8278).
50060332 7626
c4fc4e30
PE
7627 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7628
918436ed
PE
7629 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7630
c939f91b
PE
7631 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7632 clobbering (Bug#8298).
b9c7f648
PE
7633 * sysdep.c (sys_subshell): Likewise.
7634 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7635
6bd8c144
PE
7636 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7637 This should get cleaned up, so that child_setup has the
7638 same signature on all platforms.
7639
7710357c 7640 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7641 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7642
c59da222
CY
76432011-03-22 Chong Yidong <cyd@stupidchicken.com>
7644
7645 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7646 not to be necessary, and produces flickering.
7647
66b87493
GM
76482011-03-20 Glenn Morris <rgm@gnu.org>
7649
7650 * config.in: Remove file.
7651
45b6f6d5
JB
76522011-03-20 Juanma Barranquero <lekktu@gmail.com>
7653
7654 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7655 are now in src/globals.h.
7656 (syms_of_minibuf): Remove spurious & from previous change.
7657
3ec03f7e
LL
76582011-03-20 Leo <sdl.web@gmail.com>
7659
7660 * minibuf.c (completing-read-function): New variable.
7661 (completing-read-default): Rename from completing-read.
7662 (completing-read): Call completing-read-function.
7663
b14e3e21
CY
76642011-03-19 Juanma Barranquero <lekktu@gmail.com>
7665
7666 * xfaces.c (Fx_load_color_file):
7667 Read color file from absolute filename (bug#8250).
7668
f2b726e6
JB
76692011-03-19 Juanma Barranquero <lekktu@gmail.com>
7670
7671 * makefile.w32-in: Update dependencies.
7672
09f6ff02
EZ
76732011-03-17 Eli Zaretskii <eliz@gnu.org>
7674
7675 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7676
29a6015a
PE
76772011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7678
a3a6c54e
PE
7679 Fix more problems found by GCC 4.5.2's static checks.
7680
b766f867
PE
7681 * process.c (make_serial_process_unwind, send_process_trap):
7682 (sigchld_handler): Now static.
7683
be02381c
PE
7684 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7685 That way, the code declares only the vars that it needs.
7686 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7687 * s/cygwin.h (PTY_ITERATION): Likewise.
7688 * s/darwin.h (PTY_ITERATION): Likewise.
7689 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7690
57048744
PE
7691 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7692 * process.c (allocate_pty): Don't declare stb unless it's needed.
7693
7914961c 7694 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7695 (CONSTANTLIM): Remove; unused.
7696 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7697 Define only if needed.
7914961c 7698
b3967b18
PE
7699 * unexelf.c (unexec): Name an expression,
7700 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7701 Use a different way to cause a compilation error if anyone uses
7702 n rather than nn, a way that does not involve shadowing.
73366a00 7703 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7704
29a6015a
PE
7705 * deps.mk (unexalpha.o): Remove; unused.
7706
43cfc33e 7707 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7708 * unexec.h: New file.
ce701a33
PE
7709 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7710 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7711 Depend on unexec.h.
7712 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7713 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7714 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7715 Change as necessary to match prototype in unexec.h.
ce701a33 7716
01f44d5a
PE
7717 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7718 shadowing.
4f63c6bb 7719 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7720
a6670b0b
PE
7721 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7722 Rename locals to avoid shadowing.
7723
cef2010d 7724 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7725 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7726
d4d7173a
PE
7727 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7728
f08b802a
PE
7729 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7730 warning when compiling print.c.
7731
3ddb0639
PE
7732 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7733 instead of using an uninitialized var.
5ad03b97 7734 (font_sort_entities): Mark var as initialized.
3ddb0639 7735
170a2692
PE
7736 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7737
e663c700
PE
7738 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7739 pointers to constants.
89bc529a 7740 (font_parse_fcname): Remove unused vars.
7b81e2d0 7741 (font_delete_unmatched): Now static.
ea838e10 7742 (font_get_spec): Remove; unused.
13a547c6
PE
7743 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7744 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7745 Rename or move locals to avoid shadowing.
e663c700 7746
2a80c887 7747 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7748 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7749
1384fa33 7750 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7751 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7752
8b2c52e9
PE
7753 * alloc.c (mark_backtrace): Move decl from here ...
7754 * lisp.h: ... to here, so that it can be checked.
7755
475545b5 7756 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7757 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7758 (lisp_indirect_variable): Name an expression,
7759 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7760 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7761
b1349114 7762 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7763 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7764 Use const pointer when appropriate.
b1349114 7765
a2928364
PE
7766 * lisp.h (get_system_name, get_operating_system_release):
7767 Move decls here, to check interfaces.
7768 * process.c (get_operating_system_release): Move decl to lisp.h.
7769 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7770 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7771 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7772 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7773 (Fformat_time_string, Fencode_time, Finsert_char):
7774 (Ftranslate_region_internal, Fformat):
7775 Rename or remove local vars to avoid shadowing.
9710023e 7776 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7777
a415e694
PE
7778 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7779 avoid shadowing.
7780
8ef4622d
PE
7781 * lisp.h (eassert): Check that the argument compiles, even if
7782 ENABLE_CHECKING is not defined.
7783
946f9a5b
PE
7784 * data.c (Findirect_variable): Name an expression, to avoid
7785 gcc -Wbad-function-cast warning.
112396d6 7786 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7787 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7788 (Fmake_variable_buffer_local, Fmake_local_variable):
7789 Mark variables as initialized.
52746918 7790 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7791
e5aab7e7 7792 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7793 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7794 Rename locals to avoid shadowing.
dff45157
PE
7795 (mark_stack): Move local variables into the #ifdef region where
7796 they're used.
7bc26fdb
PE
7797 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7798 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7799 needed otherwise.
7800 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7801 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7802 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7803
e5aab7e7
PE
7804 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7805 avoids undefined behavior in theory.
7806
4da60324
PE
7807 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7808
88043301
PE
7809 Use functions, not macros, for up- and down-casing (Bug#8254).
7810 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7811 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7812 to use the following functions instead of these macros.
7813 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7814 EMACS_INT, since callers assume the returned value fits in int.
7815 (upcase1): Likewise, for UPCASE_TABLE.
7816 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7817 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7818 the race-condition problem in the old DOWNCASE.
88043301 7819
19ed5445
PE
7820 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7821 Rename locals to avoid shadowing.
7822 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7823 (regex_compile, re_search_2, re_match_2_internal):
7824 Remove unused local vars.
952db0d7
PE
7825 (FREE_VAR): Rewrite so as not to use empty "else",
7826 which gcc can warn about.
da053e48 7827 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7828 (RETALLOC_IF): Define only if needed.
7829 (WORDCHAR_P): Likewise. This one is never needed, but is used
7830 only in a comment talking about a compiler bug, so put inside
7831 the #if 0 of that comment.
7832 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7833 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7834 Remove; unused.
19ed5445 7835
1f3561e4 7836 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7837 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7838 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7839
ded6f8f7
PE
7840 * search.c (simple_search): Remove unused var.
7841
dbd37a95
PE
7842 * dired.c (compile_pattern): Move decl from here ...
7843 * lisp.h: ... to here, so that it can be checked.
7844 (struct re_registers): New forward decl.
7845
7e47afad
PE
7846 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7847
85f24f61
PE
7848 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7849 All uses changed.
7850 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7851 Rename locals to avoid shadowing.
5671df8f 7852 (Fvertical_motion): Mark locals as initialized.
85f24f61 7853
181aa2be 7854 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7855 (casify_region): Mark local as initialized.
181aa2be 7856
930d429c
PE
7857 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7858
7082eac6
PE
7859 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7860 New macros, so that the caller can use some names other than
7861 gcpro1, gcpro2, etc.
7862 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7863 of the new macros.
7864 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7865 argument, for consistency with GCPRO2_VAR, etc: it is now the
7866 prefix of the variable, not the variable itself. All uses
7867 changed.
38b2c076
PE
7868 * dired.c (directory_files_internal, file_name_completion):
7869 Rename locals to avoid shadowing.
7870
15206ed9
PE
7871 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7872 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7873 dired.c's scmp function, had undefined behavior.
7874 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7875 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7876 * buffer.h: ... to here, because these macros use current_buffer,
7877 and the new implementation with inline functions needs to have
7878 current_buffer in scope now, rather than later when the macros
7879 are used.
7880 (downcase, upcase1): New static inline functions.
7881 (DOWNCASE, UPCASE1): Reimplement using these functions.
7882 This avoids undefined behavior in expressions like
7883 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7884 from race conditions in accessing the global variables
7885 case_temp1 and case_temp2.
7886 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7887 * lisp.h (case_temp1, case_temp2): Remove their decls.
7888 * character.h (ASCII_CHAR_P): Move from here ...
7889 * lisp.h: ... to here, so that the inline functions mentioned
7890 above can use them.
7891
4a6bea26
PE
7892 * dired.c (directory_files_internal_unwind): Now static.
7893
f14b7e14
PE
7894 * fileio.c (file_name_as_directory, directory_file_name):
7895 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7896 Now static.
2893f146
PE
7897 (file_name_as_directory): Use const pointers when appropriate.
7898 (Fexpand_file_name): Likewise. In particular, newdir might
7899 point at constant storage, so make it a const pointer.
fd4ead52 7900 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7901 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7902 signedness issues.
f839df0c
PE
7903 (Fset_file_times, Finsert_file_contents, auto_save_error):
7904 Rename locals to avoid shadowing.
f14b7e14 7905
5716756e 7906 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7907 (Ftry_completion, Fall_completions): Rename or remove locals
7908 to avoid shadowing.
5716756e 7909
b4c3046a
PE
7910 * marker.c (bytepos_to_charpos): Remove; unused.
7911
b45db522
PE
7912 * lisp.h (verify_bytepos, count_markers): New decls,
7913 so that gcc does not warn that these functions aren't declared.
7914
85876d07
PE
7915 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7916 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7917 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7918 (copy_text): Remove unused local var.
85876d07 7919
03d78a21 7920 * filelock.c (within_one_second): Now static.
b3dd38ab 7921 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7922
5df8f01b
PE
7923 * buffer.c (fix_overlays_before): Mark locals as initialized.
7924 (fix_start_end_in_overlays): Likewise. This function should be
7925 simplified by using pointers-to-pointers, but that's a different
7926 matter.
b1d876f1 7927 (switch_to_buffer_1): Now static.
8f54f30a
PE
7928 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7929 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7930
a70072c9 7931 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7932 Fix pointer signedness issue.
edced198
PE
7933 (sys_subshell): Mark local as volatile if checking for lint,
7934 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7935 (MAXPATHLEN): Define only if needed.
a70072c9 7936
a0977c44
PE
7937 * process.c (serial_open, serial_configure): Move decls from here ...
7938 * systty.h: ... to here, so that they can be checked.
7939
a884fdcc
PE
7940 * fns.c (get_random, seed_random): Move extern decls from here ...
7941 * lisp.h: ... to here, so that they can be checked.
7942
604efe86 7943 * sysdep.c (reset_io): Now static.
b8950c94 7944 (wait_for_termination_signal): Remove; unused.
604efe86 7945
38fc62d9
PE
7946 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7947 (copy_keymap_item, append_key, push_text_char_description):
7948 Now static.
1004a21a 7949 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7950 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7951 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7952 (describe_map_tree):
7953 Rename locals to avoid shadowing.
38fc62d9 7954
2f2650da
PE
7955 * keyboard.c: Declare functions static if they are not used elsewhere.
7956 (echo_char, echo_dash, cmd_error, top_level_2):
7957 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7958 (read_char, kbd_buffer_get_event, make_lispy_position):
7959 (make_lispy_event, make_lispy_movement, apply_modifiers):
7960 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7961 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7962 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7963 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7964 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7965
a053e86c 7966 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7967 (mark_kboards): Move decl here ...
7968 * alloc.c (mark_kboards): ... from here.
a053e86c 7969
4752793e
PE
7970 * lisp.h (force_auto_save_soon): New decl.
7971
74f10ca7 7972 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7973 (DEFINE_DUMMY_FUNCTION): New macro.
7974 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7975 Use it.
c03cd23f
PE
7976 (main): Add casts to avoid warnings
7977 if GCC considers string literals to be constants.
74f10ca7 7978
022e70d4
PE
7979 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7980
59d6fe83
PE
7981 * dbusbind.c: Pointer signedness fixes.
7982 (xd_signature, xd_append_arg, xd_initialize):
7983 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7984 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7985 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7986 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7987
78320123
PE
7988 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7989 if GCC considers string literals to be constants.
49cebcca 7990 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7991
35ac2a97
SM
79922011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7993
fb103ca9
SM
7994 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7995 (print_preprocess, print_object): New macro to fix last change.
7996
35ac2a97
SM
7997 * print.c (print_preprocess): Don't forget font objects.
7998
62973b41
JB
79992011-03-16 Juanma Barranquero <lekktu@gmail.com>
8000
8001 * emacs.c (USAGE3): Doc fixes.
8002
0e48bb22
AS
80032011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8004
8005 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8006 structure.
8007
7684e57b
JB
80082011-03-14 Juanma Barranquero <lekktu@gmail.com>
8009
8010 * lisp.h (VWindow_system, Qfile_name_history):
8011 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8012 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8013 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8014
8015 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8016 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8017
8018 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8019 * w32console.c (detect_input_pending, read_input_pending)
8020 (encode_terminal_code):
8021 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8022 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8023 (w32_system_caret_y, Qfile_name_history):
8024 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8025 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8026 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8027 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8028 * w32proc.c (Qlocal, report_file_error):
8029 * w32term.c (Vwindow_system, updating_frame):
8030 * w32uniscribe.c (initialized, uniscribe_font_driver):
8031 Remove unneeded extern declarations.
8032
2aa46d6c
CY
80332011-03-14 Chong Yidong <cyd@stupidchicken.com>
8034
c96bbc66 8035 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8036
cffc6f3b
CY
80372011-03-13 Chong Yidong <cyd@stupidchicken.com>
8038
8039 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8040 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8041 These macros can no longer be used for assignment.
8042
44f230aa
SM
8043 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8044 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8045 (record_buffer_markers, fetch_buffer_markers): New functions for
8046 recording and fetching special buffer markers.
8047 (set_buffer_internal_1, set_buffer_temp): Use them.
8048
8049 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8050
8051 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8052
8053 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8054 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8055
8056 * xdisp.c (hscroll_window_tree):
8057 (reconsider_clip_changes): Use PT instead of BUF_PT.
8058
d251f04b
EZ
80592011-03-13 Eli Zaretskii <eliz@gnu.org>
8060
8061 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8062 $(EMACS_ROOT)/lib/intprops.h.
8063
f0c77cd1
PE
80642011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8065
3eca4629
PE
8066 Fix more problems found by GCC 4.5.2's static checks.
8067
7c86ee98
PE
8068 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8069 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8070 (xg_free_frame_widgets): Make it clear that a local variable is
8071 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8072 (gdk_window_get_screen): Make it clear that this macro is needed
8073 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8074 (int_gtk_range_get_value): New function, which avoids a diagnostic
8075 from gcc -Wbad-function-cast.
8076 (xg_set_toolkit_scroll_bar_thumb): Use it.
8077 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8078 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8079 (get_utf8_string, xg_get_file_with_chooser):
8080 Rename locals to avoid shadowing.
8081 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8082
41729b81
PE
8083 * xgselect.c (xg_select): Remove unused var.
8084
f0c77cd1
PE
8085 * image.c (four_corners_best): Mark locals as initialized.
8086 (gif_load): Initialize transparent_p to zero (Bug#8238).
8087 Mark another local as initialized.
ec6cf4c6 8088 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8089
ce0ad53d 8090 * image.c (clear_image_cache): Now static.
d5d5a617 8091 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8092 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8093 (x_edge_detection): Remove unnecessary cast that
8094 gcc -Wbad-function-cast diagnoses.
2037898d 8095 (gif_load): Fix pointer signedness.
6ae141d6
PE
8096 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8097 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8098
33383987 80992011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8100
d32df629
PE
8101 Improve quality of tests for time stamp overflow.
8102 For example, without this patch (encode-time 0 0 0 1 1
8103 1152921504606846976) returns the obviously-bogus value (-948597
8104 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8105 reports time overflow. See
8106 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8107 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8108 * editfns.c: Include limits.h and intprops.h.
8109 (TIME_T_MIN, TIME_T_MAX): New macros.
8110 (time_overflow): Move earlier, to before first use.
8111 (hi_time, lo_time): New functions, for an accurate test for
8112 out-of-range times.
8113 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8114 (Fget_internal_run_time): Don't assume time_t fits in int.
8115 (make_time): Use list2 instead of Fcons twice.
8116 (Fdecode_time): More accurate test for out-of-range times.
8117 (check_tm_member): New function.
8118 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8119 (lisp_time_argument): Don't rely on undefined left-shift and
8120 right-shift behavior when checking for time stamp overflow.
8be6f318 8121
fe31d94c
PE
8122 * editfns.c (time_overflow): New function, refactoring common code.
8123 (Fformat_time_string, Fdecode_time, Fencode_time):
8124 (Fcurrent_time_string): Use it.
8125
8be6f318
PE
8126 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8127 * dired.c (make_time): Move to ...
8128 * editfns.c (make_time): ... here.
8129 * systime.h: Note the move.
8130
09d9db2c 81312011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8132
126bc0dc
YM
8133 * fringe.c (update_window_fringes): Remove unused variables.
8134
c47cbdfd
YM
8135 * unexmacosx.c (copy_data_segment): Also copy __got section.
8136 (Bug#8223)
8137
7ac80be9
EZ
81382011-03-12 Eli Zaretskii <eliz@gnu.org>
8139
c96bbc66 8140 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8141 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8142 Constify `char *' arguments and their references according to
8143 prototypes in tparam.h.
8144
ecb0f94d 8145 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8146
7ac80be9
EZ
8147 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8148 Adapt all references accordingly.
8149
8150 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8151
ef1fd07e
TT
81522011-03-11 Tom Tromey <tromey@redhat.com>
8153
8154 * buffer.c (syms_of_buffer): Remove obsolete comment.
8155
7ef4b50c
EZ
81562011-03-11 Eli Zaretskii <eliz@gnu.org>
8157
8158 * termhooks.h (encode_terminal_code): Declare prototype.
8159
8160 * msdos.c (encode_terminal_code): Don't declare prototype.
8161
8162 * term.c (encode_terminal_code): Now external again, used by
8163 w32console.c and msdos.c.
8164
44f230aa
SM
8165 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8166 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8167
4b1ec863 81682011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8169
1714f52b 8170 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8171
4b1ec863
PE
8172 * fringe.c (update_window_fringes): Mark locals as initialized
8173 (Bug#8227).
8174 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8175
524c7aa6
PE
8176 * alloc.c (mark_fringe_data): Move decl from here ...
8177 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8178 to check its interface.
8179 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8180
a5c0af81 8181 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8182 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8183 (fontset_font): Mark local as initialized.
a9a06e0b 8184 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8185
b4716021
PE
8186 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8187
811e9bac 8188 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8189 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8190 (x_own_selection, Fx_disown_selection_internal): Rename locals
8191 to avoid shadowing.
8192 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8193
7e3ab302
PE
8194 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8195 so that the caller can use some name other than gcpro1.
8196 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8197 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8198 (Fx_backspace_delete_keys_p):
8199 Use them to avoid shadowing, and rename vars to avoid shadowing.
8200 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8201 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8202 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8203 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8204 Remove unused locals.
7e3ab302
PE
8205 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8206 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8207 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8208 macros.
f78faa98 8209
e2b13473
PE
8210 * xterm.h (x_mouse_leave): New decl.
8211
77f23912
PE
8212 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8213 Remove unused functions.
cdf4ba58
PE
8214 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8215 (x_calc_absolute_position): Now static.
7411c686 8216 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8217 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8218 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8219 unless they are used.
38d0b34a
PE
8220 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8221 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8222 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8223 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8224 (x_error_catcher, x_connection_closed, x_error_handler):
8225 (x_error_quitter, xembed_send_message, x_iconify_frame):
8226 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8227 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8228 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8229
44f230aa
SM
8230 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8231 Rename or move locals to avoid shadowing.
6b463e58 8232 (tty_defined_color, merge_face_heights): Now static.
5967d051 8233 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8234 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8235 does not deduce is never used uninitialized.
73719eba
PE
8236 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8237 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8238
426994c3 8239 * terminal.c (store_terminal_param): Now static.
5489860b 8240
032f1620 8241 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8242 (set_frame_menubar): Remove unused local.
d4323972 8243 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8244 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8245 since they might point to immutable storage.
281585b0
PE
8246 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8247 since it's unused otherwise.
032f1620 8248
367c19e5 8249 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8250 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8251 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8252 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8253 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8254 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8255 does not deduce are never used uninitialized.
70739cbe 8256
07b48fa9
PE
8257 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8258
8868a238 8259 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8260 * window.c (window_loop, size_window):
8261 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8262
7e5cf297 8263 * window.c (display_buffer): Now static.
d6550a9f
PE
8264 (size_window): Mark variables that gcc -Wuninitialized
8265 does not deduce are never used uninitialized.
a586633d
PE
8266 * window.h (check_all_windows): New decl, to forestall
8267 gcc -Wmissing-prototypes diagnostic.
5b555da1 8268 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8269
f6095868
PE
8270 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8271 shadowing.
8272 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8273 Include <limits.h>.
8274 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8275 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8276 (load_charset_map): Mark variables that gcc -Wuninitialized
8277 does not deduce are never used uninitialized.
53df7c11 8278 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8279
f38b440c
PE
8280 * coding.c (coding_set_source, coding_set_destination):
8281 Use "else { /* comment */ }" rather than "else /* comment */;"
8282 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8283 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8284 a block, when the outer 'i' will do.
8285 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8286 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8287 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8288 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8289 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8290 Rename locals to avoid shadowing.
8291 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8292 * coding.c (emacs_mule_char, encode_invocation_designation):
8293 Now static, since they're not used elsewhere.
413bb2db 8294 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8295 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8296 (decode_coding_emacs_mule): Mark variables that gcc
8297 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8298 (detect_coding_iso_2022): Initialize a local variable that might
8299 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8300 this initialization is needed. (Bug#8211)
5f58e762
PE
8301 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8302 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8303 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8304 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8305 Remove unused macros.
f38b440c 8306
232b38b9 8307 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8308 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8309 * character.c (string_count_byte8): Likewise.
232b38b9 8310
fb90da1b
PE
8311 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8312 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8313
fb93dbc2
PE
8314 * chartab.c (copy_sub_char_table): Now static, since it's not used
8315 elsewhere.
5c156ace
PE
8316 (sub_char_table_ref_and_range, char_table_ref_and_range):
8317 Rename locals to avoid shadowing.
bbcd0949 8318 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8319
7d3b3862 8320 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8321 (BIDI_BOB): Remove unused macro.
7d3b3862 8322
6be7d3da
PE
8323 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8324 deduce are never used uninitialized.
c2ed9c8b 8325 * term.c (encode_terminal_code): Likewise.
6be7d3da 8326
75f8807f 8327 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8328
50938595
PE
8329 * tparam.h: New file.
8330 * term.c, tparam.h: Include it.
8331 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8332 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8333 Move these decls to tparam.h, and make them agree with what
8334 is actually in tparam.c. The previous trick of using incompatible
8335 decls in different modules does not conform to the C standard.
8336 All callers of tparam changed to use tparam's actual API.
8337 * tparam.c (tparam1, tparam, tgoto):
8338 Use const pointers where appropriate.
8339
fbceeba2
PE
8340 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8341 * cm.h (struct cm): Likewise.
8342 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8343 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8344 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8345 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8346 (turn_on_face, init_tty): Likewise.
8347 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8348
7f3f1250
PE
8349 * term.c (term_mouse_position): Rename local to avoid shadowing.
8350
e6ca6543
PE
8351 * alloc.c (mark_ttys): Move decl from here ...
8352 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8353
c40f8d15
AS
83542011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8355
8356 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8357
cfe0661d
JB
83582011-03-09 Juanma Barranquero <lekktu@gmail.com>
8359
8360 * search.c (compile_pattern_1): Remove argument regp, unused since
8361 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8362 (compile_pattern): Don't pass it.
8363
0afb4571
J
83642011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8365
8366 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8367 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8368 for ! HAVE_GTK3.
8369 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8370
8371 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8372
8373 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8374 gdk_window_get_screen, gdk_window_get_geometry,
8375 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8376 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8377 (xg_get_pixbuf_from_pixmap): New function.
8378 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8379 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8380 Call xg_get_pixbuf_from_pixmap instead of
8381 gdk_pixbuf_get_from_drawable.
8382 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8383 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8384 (xg_check_special_colors): Use GtkStyleContext and its functions
8385 for HAVE_GTK3.
8386 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8387 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8388 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8389 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8390 Call gtk_widget_get_preferred_size.
0afb4571
J
8391 (xg_frame_resized): gdk_window_get_geometry only takes 5
8392 parameters.
44f230aa
SM
8393 (xg_win_to_widget, xg_event_is_for_menubar):
8394 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8395 (xg_set_widget_bg): New function.
8396 (delete_cb): New function.
895009e1 8397 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8398 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8399 (xg_set_background_color): Call xg_set_widget_bg.
8400 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8401 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8402 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8403 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8404 if ! HAVE_GTK3.
8405 (update_frame_tool_bar): Call gtk_widget_hide.
8406 (xg_initialize): Use GDK_KEY_g.
8407
8408 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8409 if ! HAVE_GTK3
8410 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8411
8412 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8413 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8414 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8415
1c2cc4ef
JB
84162011-03-08 Juanma Barranquero <lekktu@gmail.com>
8417
8418 * w32xfns.c (select_palette): Check success of RealizePalette against
8419 GDI_ERROR, not zero.
8420
33383987 8421See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8422
8423;; Local Variables:
8424;; coding: utf-8
aac0c6e3
MR
8425;; End:
8426
33383987 8427 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8428
8429 This file is part of GNU Emacs.
8430
8431 GNU Emacs is free software: you can redistribute it and/or modify
8432 it under the terms of the GNU General Public License as published by
8433 the Free Software Foundation, either version 3 of the License, or
8434 (at your option) any later version.
8435
8436 GNU Emacs is distributed in the hope that it will be useful,
8437 but WITHOUT ANY WARRANTY; without even the implied warranty of
8438 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8439 GNU General Public License for more details.
8440
8441 You should have received a copy of the GNU General Public License
8442 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.