Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0065d054 12011-08-05 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2
726e0ab1
PE
3 Integer and memory overflow issues.
4
0065d054
PE
5 * charset.c (charset_table_size)
6 (struct charset_sort_data.priority): Now ptrdiff_t.
7 (charset_compare): Don't overflow if priorities differ greatly.
8 (Fsort_charsets): Don't assume list length fits in int.
9 Check for size-calculation overflow when allocating sort data.
10 (syms_of_charset): Allocate an initial charset table that is
11 just under 64 KiB, to avoid problems with glibc malloc and mmap.
12
13 * cmds.c (internal_self_insert): Check for size-calculation overflow.
14
15 * composite.h (struct composition.glyph_len): Now int, not unsigned.
16 The actual value is always <= INT_MAX, and leaving it unsigned made
17 overflow checking harder.
18
19 * dispextern.h (struct glyph_matrix.rows_allocated)
20 (struct face_cache.size): Now ptrdiff_t, for convenience in use
21 with xpalloc. The values are still always <= INT_MAX.
22
23 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
24
25 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
26 (SAFE_NALLOCA): New macro.
27
28 * region-cache.c (struct boundary.pos, find_cache_boundary)
29 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
30 (set_cache_region, invalidate_region_cache)
31 (revalidate_region_cache, know_region_cache, region_cache_forward)
32 (region_cache_backward, pp_cache):
33 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
34 so that ptrdiff_t * can be passed to xpalloc.
35 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
36 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
37 (pp_cache): Don't assume cache_len fits in int.
38 * region-cache.h: Adjust extern decls to match.
39
40 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
41 EMACS_INT, since either will do, for xpalloc.
42
43 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
44 (xnmalloc, xnrealloc, xpalloc): New functions.
45
726e0ab1
PE
46 * bidi.c (bidi_shelve_header_size): New constant.
47 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
48 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
49
50 * buffer.c (overlays_at, overlays_in, record_overlay_string)
51 (overlay_strings):
52 Don't update size of array until after memory allocation succeeds,
53 because xmalloc/xrealloc may not return.
0065d054
PE
54 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
55 now that we have proper integer overflow checking.
56 (record_overlay_string, overlay_strings): Catch overflows when
57 calculating size of overlay_str_buf.
726e0ab1 58
0065d054
PE
59 * callproc.c (Fcall_process): Check for size overflow when
60 calculating size of args2.
61 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
62 Normally we prefer signed values, but sticking with ptrdiff_t would
63 require adding more-complicated checks.
726e0ab1
PE
64
65 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
66 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
67 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 68 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
69
70 * character.c (Fstring): Check for size-calculation overflow.
71
72 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
73 unnecessary integer overflow. Check for size overflow.
74 (encode_coding_object): Don't update size until xmalloc succeeds.
75
76 * composite.c (get_composition_id): Check for overflow in glyph
77 length calculations.
78
79 Integer and memory overflow fixes for display code.
80 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
81 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
82 (scrolling_window): Check for overflow in size calculations.
83 (line_draw_cost, realloc_glyph_pool, add_row_entry):
84 Don't assume glyph table len fits in int.
85 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
86 (row_table_size): Now ptrdiff_t, not int.
87 (scrolling_window): Avoid overflow in size calculations.
88 Don't update size until allocation succeeds.
89 * fns.c (concat): Check for overflow in size calculations.
90 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
91 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
92 (NEXT_ALMOST_PRIME_LIMIT): New constant.
93
94 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
95 (get_doc_string): Check for size calculation overflow.
96 Don't update size until allocation succeeds.
97 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
98 EMACS_INT, where ptrdiff_t will do.
99 (Fsubstitute_command_keys): Check for string overflow.
100
101 * editfns.c (set_time_zone_rule): Don't assume environment length
102 fits in int.
103 (message_length): Now ptrdiff_t, not int.
104 (Fmessage_box): Don't update size until allocation succeeds.
105 Don't assume message length fits in int.
106 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
107
0065d054
PE
108 * emacs.c (main): Do not reallocate argv, since there is a null at
109 the end that can be overwritten, and this way there's no need to
110 worry about size-calculation overflow.
111 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
112
113 * eval.c (init_eval_once, grow_specpdl): Don't update size until
114 alloc succeeds.
115 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
116
117 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
118 (x_set_scroll_bar_width, x_figure_window_size):
119 Check for integer overflow.
120 (x_set_alpha): Do not assume XINT fits in int.
121
122 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
123 This is for the members text_lines, text_cols, total_lines, total_cols,
124 where the system imposes an 'int' limit.
125
126 * fringe.c (Fdefine_fringe_bitmap):
127 Don't update size until alloc works.
128
129 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
130 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
131
132 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
133 Check for size-calculation overflow.
134 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
135 do, as we prefer signed integers.
136 (id_to_widget.max_size, id_to_widget.used)
137 (xg_store_widget_in_map, xg_remove_widget_from_map)
138 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
139 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
140 Use and return ptrdiff_t, not int.
141 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
142 * gtkutil.h: Change prototypes to match the above.
143
144 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
145 are duplicate now that they've been promoted to lisp.h.
146 (x_allocate_bitmap_record, x_alloc_image_color)
147 (make_image_cache, cache_image, xpm_load):
148 Don't update size until alloc is done.
149 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
150 (x_detect_edges):
3256efce 151 Check for size calculation overflow.
726e0ab1
PE
152 (ct_colors_allocated_max): New constant.
153 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
154 overflow.
3256efce 155
726e0ab1
PE
156 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
157 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
158 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
159 Use ptrdiff_t, not int, to count maps.
160 (read_char_minibuf_menu_prompt): Check for overflow in size
161 calculations. Don't update size until allocation succeeds. Redo
162 calculations to avoid overflow.
163 * keyboard.h: Change prototypes to match the above.
164
165 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
166 to count maps.
167 (current_minor_maps): Check for size calculation overflow.
168 * keymap.h: Change prototypes to match the above.
169
170 * lread.c (read1, init_obarray): Don't update size until alloc done.
171
172 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
173 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
174
726e0ab1
PE
175 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
176 Now ptrdiff_t, not int.
177 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
178 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
179
180 * process.c (Fnetwork_interface_list): Check for overflow
181 in size calculation.
182
183 * region-cache.c (move_cache_gap): Check for size calculation overflow.
184
185 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
186 overflow. Don't bother calling xmalloc when xrealloc will do.
187
188 * search.c (Freplace_match): Check for size calculation overflow.
189 (Fset_match_data): Don't assume list lengths fit in 'int'.
190
191 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
192 for command line length. Do not attempt to address one before the
193 beginning of an array, as that's not portable.
194
195 * term.c (max_frame_lines): Remove; unused.
196 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
197 not int.
198 (encode_terminal_code, calculate_costs): Check for size
199 calculation overflow.
200 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
201 table lengths and related sizes. Don't update size until alloc
202 done. Redo calculations to avoid overflow.
203 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
204
205 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
206 subtracting pointers.
207 (gobble_line): Check for overflow more carefully. Don't update size
208 until alloc done.
209
210 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
211 Don't update size until alloc done.
212 Redo size calculations to avoid overflow.
213 Check for size calculation overflow.
0065d054 214 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
215
216 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
217 Use ptrdiff_t, not int, for sizes.
218 (store_mode_line_noprop_char): Don't update size until alloc done.
219
0065d054
PE
220 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
221 Use ptrdiff_t, not int, for sizes.
222 (Finternal_make_lisp_face, cache_face):
223 Check for size calculation overflow.
224 (cache_face): Treat size calculation overflows as if they were
225 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
226
227 * xfns.c (x_encode_text, x_set_name_internal)
228 (Fx_change_window_property): Use ptrdiff_t, not int, to count
229 sizes, since they can exceed INT_MAX in size. Check for size
230 calculation overflow.
231
0065d054
PE
232 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
233 (xg_select): Check for size calculation overflow.
726e0ab1
PE
234 Don't update size until alloc done.
235
0065d054 236 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 237 as sprintf is limited to int lengths.
1d526e2f 238
726e0ab1 239 * xselect.c (X_LONG_SIZE, X_USHRT_MAX, X_ULONG_MAX): New macros.
864d7ce7
PE
240 Use them to make the following changes clearer.
241 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
242 This change doesn't affect the value now, but it may help remind
243 future maintainers not to raise the value too much later.
244 (SELECTION_QUANTUM): Remove, replacing with ...
245 (selection_quantum): ... new function, which avoids overflow.
246 All uses changed.
247 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
248 assumption that selection length fits in 'int'.
249 (x_reply_selection_request, x_handle_selection_request)
250 (x_get_window_property, receive_incremental_selection)
251 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
252 (lisp_data_to_selection_data, clean_local_selection_data):
253 Use ptrdiff_t, not int, to record length of selection.
254 (x_reply_selection_request, x_get_window_property)
255 (receive_incremental_selection, x_property_data_to_lisp):
256 Redo calculations to avoid overflow.
257 (x_reply_selection_request): When sending hint, ceiling it at
258 X_ULONG_MAX rather than relying on wraparound overflow to send
259 something.
260 (x_get_window_property, receive_incremental_selection)
261 (lisp_data_to_selection_data, x_property_data_to_lisp):
262 Check for size-calculation overflow.
263 (x_get_window_property, receive_incremental_selection)
264 (lisp_data_to_selection_data, Fx_register_dnd_atom):
265 Don't store size until memory allocation succeeds.
266 (x_get_window_property): Plug memory leak on memory exhaustion.
267 Don't double-block input; malloc is safe here. Don't assume 2**34
268 - 4 fits in unsigned long. Add an xassert to check
269 XGetWindowProperty overflow. Be more careful about overflow
270 calculations, and distinguish size from memory overflow better.
271 (receive_incremental_selection): When tracing, don't assume
272 unsigned int is less than INT_MAX.
273 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
274 harmful) conversions of unsigned short to int.
275 (lisp_data_to_selection_data): Don't assume that integers
276 in the range -65535 through -1 fit in an X unsigned short.
277 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
278 result parameters unless successful. Rely on cons_to_unsigned
279 to report problems with elements; the old code wasn't right anyway.
280 (x_check_property_data): Check for int overflow; we cannot use
281 a wider type due to X limits.
282 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
283
726e0ab1 284 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 285
0065d054
PE
286 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
287 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
288 (x_color_cells): Don't store size until memory allocation succeeds.
289 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 290 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
291 (x_term_init): Don't assume length fits in int (sprintf is limited
292 to int size).
bc18e09d 293
ebfa62c0
PE
294 Use ptrdiff_t for composition IDs.
295 * character.c (lisp_string_width):
296 * composite.c (composition_table_size, n_compositions)
297 (get_composition_id, composition_gstring_from_id):
298 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
299 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
300 * window.c (Frecenter):
301 Use ptrdiff_t, not int, for composition IDs.
302 * composite.c (get_composition_id): Check for integer overflow.
303 * composite.h: Adjust prototypes to match the above changes.
304
d3411f89
PE
305 Use ptrdiff_t for hash table indexes.
306 * category.c (hash_get_category_set):
307 * ccl.c (ccl_driver):
308 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
309 * coding.c (coding_system_charset_list, detect_coding_system):
310 * coding.h (struct coding_system.id):
311 * composite.c (get_composition_id, gstring_lookup_cache):
312 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
313 * image.c (xpm_get_color_table_h):
314 * lisp.h (hash_lookup, hash_put):
315 * minibuf.c (Ftest_completion):
316 Use ptrdiff_t for hash table indexes, not int (which is too
317 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
318 32-bit --with-wide-int hosts).
319
e097a6fa
PE
320 * charset.c (Fdefine_charset_internal): Check for integer overflow.
321 Add a FIXME comment about memory leaks.
322 (syms_of_charset): Don't assume xmalloc returns.
323
5637687f
PE
324 Don't assume that stated character widths fit in int.
325 * character.c (Fchar_width, c_string_width, lisp_string_width):
326 * character.h (CHAR_WIDTH):
327 * indent.c (MULTIBYTE_BYTES_WIDTH):
328 Use sanitize_char_width to avoid undefined and/or bad behavior
329 with outlandish widths.
330 * character.h (sanitize_tab_width): Renamed from sanitize_width,
331 now that we have two such functions. All uses changed.
332 (sanitize_char_width): New inline function.
333
a2271ba2
PE
334 Don't assume that tab-width fits in int.
335 * character.h (sanitize_width): New inline function.
336 (SANE_TAB_WIDTH): New macro.
337 (ASCII_CHAR_WIDTH): Use it.
338 * indent.c (sane_tab_width): Remove. All uses replaced by
339 SANE_TAB_WIDTH (current_buffer).
340 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
341
18c52557
PE
342 * fileio.c: Integer overflow issues with file modes.
343 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
344
caeeedc1
PE
345 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
346 Remove unreachable code.
347 (read_hex, load_charset_map_from_file): Check for integer overflow.
348
50849c52
PE
349 * xterm.c: don't go over XClientMessageEvent limit
350 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
351 (x_send_scroll_bar_event): Likewise. Check that the size does not
352 exceed limits imposed by XClientMessageEvent, as well as the usual
353 ptrdiff_t and size_t limits.
354
b13995db
PE
355 * keyboard.c: Overflow, signedness and related fixes.
356 (make_lispy_movement): Use same integer type in forward decl
357 that is used in the definition.
358 (read_key_sequence, keyremap_step):
359 Change bufsize argument back to int, undoing my 2011-03-30 change.
360 We prefer signed types, and int is wide enough here.
361 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
362 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
363 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
364 length, not size_t. Use ptrdiff_t for index, not int.
365 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
366 possibility of integer overflow.
367
13464394
PE
368 Overflow, signedness and related fixes for images.
369
370 * dispextern.h (struct it.stack[0].u.image.image_id)
371 (struct_it.image_id, struct image.id, struct image_cache.size)
372 (struct image_cache.used, struct image_cache.ref_count):
373 * gtkutil.c (update_frame_tool_bar):
374 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
375 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
376 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
377 * nsmenu.m (update_frame_tool_bar):
378 * xdisp.c (calc_pixel_width_or_height):
379 * xfns.c (image_cache_refcount):
380 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
381 on typical 64-bit hosts.
382
383 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
384 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
385 Omit unnecessary casts to int.
386 (parse_image_spec): Check that integers fall into 'int' range
387 when the callers expect that.
388 (image_ascent): Redo ascent calculation to avoid int overflow.
389 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
390 (lookup_image): Remove unnecessary tests.
391 (xbm_image_p): Locals are now of int, not EMACS_INT,
392 since parse_image_check makes sure they fit into int.
393 (png_load, gif_load, svg_load_image):
394 Prefer int to unsigned where either will do.
395 (tiff_handler): New function, combining the cores of the
396 old tiff_error_handler and tiff_warning_handler. This
397 function is rewritten to use vsnprintf and thereby avoid
398 stack buffer overflows. It uses only the features of vsnprintf
399 that are common to both POSIX and native Microsoft.
400 (tiff_error_handler, tiff_warning_handler): Use it.
401 (tiff_load, gif_load, imagemagick_load_image):
402 Don't assume :index value fits in 'int'.
403 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
404 (imagemagick_load_image): Check that crop parameters fit into
405 the integer types that MagickCropImage accepts. Don't assume
406 Vimagemagick_render_type has a nonnegative value. Don't assume
407 size_t fits in 'long'.
408 (gs_load): Use printmax_t to print the widest integers possible.
409 Check for integer overflow when computing image height and width.
410
35928349
EZ
4112011-08-05 Eli Zaretskii <eliz@gnu.org>
412
ec7cc85b
EZ
413 * bidi.c <bidi_cache_total_alloc>: Now static.
414 (bidi_initialize): Initialize bidi_cache_total_alloc.
415
35928349
EZ
416 *xdisp.c (display_line): Release buffer allocated for shelved bidi
417 cache. (Bug#9221)
418
419 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
420 amount allocated this far in `bidi_cache_total_alloc'.
421 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
422 non-zero, only free the data buffer without restoring the cache
423 contents. All callers changed.
424
425 * dispextern.h (bidi_unshelve_cache): Update prototype.
426
427 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
428 (move_it_in_display_line, move_it_to)
429 (move_it_vertically_backward, move_it_by_lines): Replace the call
430 to xfree to an equivalent call to bidi_unshelve_cache.
431 (move_it_in_display_line_to): Fix logic of returning
412b6358 432 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 433
e2e2423b
EZ
4342011-08-05 Eli Zaretskii <eliz@gnu.org>
435
436 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
437 came from a string character with a `cursor' property. (Bug#9229)
438
ae9e757a
JD
4392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
440
441 * Makefile.in (LIB_PTHREAD): New variable.
442 (LIBES): Add LIB_PTHREAD (Bug#9216).
443
444 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
445 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
446
213bd7f2
AS
4472011-08-04 Andreas Schwab <schwab@linux-m68k.org>
448
449 * regex.c (re_iswctype): Remove some redundant boolean
450 conversions.
451
99aaf75f
JD
4522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
453
454 * xterm.c (x_find_topmost_parent): New function.
455 (x_set_frame_alpha): Find topmost parent window with
456 x_find_topmost_parent and set the property there also (bug#9181).
457 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
458
c74e9d86
PE
4592011-08-04 Paul Eggert <eggert@cs.ucla.edu>
460
461 * callproc.c (Fcall_process): Avoid vfork clobbering
462 the local vars buffer, coding_systems, current_dir.
463
640c8776
SM
4642011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
465
466 * keymap.c (Fmake_composed_keymap): Move to subr.el.
467
f26d0e4c
PE
4682011-08-03 Paul Eggert <eggert@cs.ucla.edu>
469
8a10d76c
PE
470 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
471 so that it is not optimized away.
472
f26d0e4c
PE
473 * xdisp.c (compute_display_string_pos): Remove unused local.
474
55439c61
EZ
4752011-08-02 Eli Zaretskii <eliz@gnu.org>
476
477 Fix slow cursor motion and scrolling in large buffers with
478 selective display, like Org Mode buffers. (Bug#9218)
479
480 * dispextern.h (struct bidi_it): New member disp_prop_p.
481
482 * xdisp.c: Remove one-slot cache of display string positions.
483 (compute_display_string_pos): Accept an additional argument
484 DISP_PROP_P; callers changed. Scan at most 5K characters forward
485 for a display string or property. If found, set DISP_PROP_P
486 non-zero.
487
488 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
489 DISP_PROP_P, and pass it to compute_display_string_pos.
490 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
491 non-zero. All callers of bidi_fetch_char changed.
492
fb33fa43
SM
4932011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
494
495 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
496
b099e063
DM
4972010-12-03 Don March <don@ohspite.net>
498
499 * keymap.c (Fdefine_key): Fix non-prefix key error message when
500 last character M-[char] is translated to ESC [char] (bug#7541).
501
5cc7f7af
KH
5022011-08-02 Kenichi Handa <handa@m17n.org>
503
d0fffa3f 504 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
505
506 * chartab.c (uniprop_table): Make it non-static.
507
525d5e6e
EZ
5082011-08-01 Eli Zaretskii <eliz@gnu.org>
509
510 * xdisp.c (forward_to_next_line_start): Accept additional argument
511 BIDI_IT_PREV, and store into it the state of the bidi iterator had
512 on the newline.
513 (reseat_at_next_visible_line_start): Use the bidi iterator state
514 returned by forward_to_next_line_start to restore the state of
515 it->bidi_it after backing up to previous newline. (Bug#9212)
516
31011111
AS
5172011-07-30 Andreas Schwab <schwab@linux-m68k.org>
518
519 * regex.c (re_comp): Protoize.
520 (re_exec): Fix return type.
521 (regexec): Fix type of `ret'. (Bug#9203)
522
e5d76069
PE
5232011-07-29 Paul Eggert <eggert@cs.ucla.edu>
524
525 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
526 This is needed if max-image-size is a floating-point number.
527
9a79b20c
AS
5282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
529
530 * print.c (print_object): Print empty symbol as ##.
531
532 * lread.c (read1): Read ## as empty symbol.
533
d8c2fa78
AA
5342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
535
536 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
537 setting frame foreground color (Bug#9175).
538 (x_set_background_color): Likewise.
539
ffe57a7a
AA
540 * nsmenu.m (-setText): Size tooltip dimensions precisely to
541 contents (Bug#9176).
542 (EmacsTooltip -init): Remove bezels and add shadows to
543 tooltip windows.
544
bf3492a5
AA
545 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
546 or scroll bar (Bug#8470).
547
d55e9c53
AA
548 * nsfont.m (nsfont_open): Remove assignment to voffset and
549 unnecessary vars hshink, expand, hd, full_height, min_height.
550 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
551
552 * nsterm.h (nsfont_info): Remove voffset field.
553
d8c2fa78 5542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
555
556 Implement strike-through and overline on NextStep (Bug#8863).
557
558 * nsfont.m (nsfont_open): Use underline position provided by font,
559 instead of hard-coded value of 2.
560 (nsfont_draw): Call ns_draw_text_decoration instead.
561
562 * nsterm.h: Add declaration for ns_draw_text_decoration.
563
564 * nsterm.m (ns_draw_text_decoration): New function for drawing
565 underline, overline, and strike-through.
566 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
567 ns_draw_text_decoration. Change treatment of cursor drawing to
568 accomodate underlining, etc.
569
4cc60b9b
EZ
5702011-07-28 Eli Zaretskii <eliz@gnu.org>
571
bc7ece87
EZ
572 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
573 default.
4cc60b9b 574
476371c4
PE
5752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
576
66606eea
PE
577 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
578 Without this fix, if a signal arrives just after memory fills up,
579 'malloc' might be invoked reentrantly.
580
476371c4
PE
581 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
582 In other words, assume that every image size is allowed, on non-X
583 hosts. This assumption is probably wrong, but it lets Emacs compile.
584
f3fcc40d
AS
5852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
586
587 * regex.c (re_iswctype): Convert return values to boolean.
588
350c992f
EZ
5892011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
590
591 * xdisp.c (compute_display_string_pos): Don't use cached display
592 string position if the buffer had its restriction changed.
593 (Bug#9184)
594
5266b4bb
PE
5952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
596
597 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
598
2573a837 5992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 600
41f55ccd 601 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 602
39e378da
PE
603 * bidi.c: Integer size and overflow fixes.
604 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
605 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
606 (bidi_cache_find_level_change, bidi_cache_ensure_space)
607 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
608 (bidi_find_other_level_edge):
609 Use ptrdiff_t instead of EMACS_INT where either will do.
610 This works better on 32-bit hosts configured --with-wide-int.
611 (bidi_cache_ensure_space): Check for size-calculation overflow.
612 Use % rather than repeated addition, for better worst-case speed.
613 Don't set bidi_cache_size until after xrealloc returns, because it
614 might not return.
615 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
616 (bidi_cache_ensure_space): Also check that the bidi cache size
617 does not exceed that of the largest Lisp string or buffer. See Eli
618 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 619
5e927815
PE
620 * alloc.c (__malloc_size_t): Remove.
621 All uses replaced by size_t. See Andreas Schwab's note
622 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
623
ca4aa935
PE
624 * image.c: Improve checking for integer overflow.
625 (check_image_size): Assume that f is nonnull, since
626 it is always nonnull in practice. This is one less thing to
627 worry about when checking for integer overflow later.
628 (x_check_image_size): New function, which checks for integer
629 overflow issues inside X.
630 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
631 This removes the need for a memory_full check.
632 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
633 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
634 (xbm_read_bitmap_data): Change locals back to 'int', since
635 their values must fit in 'int'.
636 (xpm_load_image, png_load, tiff_load):
637 Invoke x_create_x_image_and_pixmap earlier,
638 to avoid much needless work if the image is too large.
639 (tiff_load): Treat overly large images as if
640 x_create_x_image_and_pixmap failed, not as malloc failures.
641 (gs_load): Use x_check_image_size.
642
5f8f9cc2
PE
643 * gtkutil.c: Omit integer casts.
644 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
645 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
646
5adf60bc
PE
647 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
648
c8907a93
PE
649 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
650 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
651 would wrongly return t on a 64-bit host.
652
e3c25c68
PE
653 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
654 The plain *_OVERFLOW macros run afoul of GCC bug 49705
655 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
656 and therefore cause GCC to emit a bogus diagnostic in some cases.
657
3f791afe
PE
658 * image.c: Integer signedness and overflow and related fixes.
659 This is not an exhaustive set of fixes, but it's time to
660 record what I've got.
661 (lookup_pixel_color, check_image_size): Remove redundant decls.
662 (check_image_size): Don't assume that arbitrary EMACS_INT values
663 fit in 'int', or that arbitrary 'double' values fit in 'int'.
664 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
665 (tiff_load, imagemagick_load_image):
666 Check for overflow in size calculations.
667 (x_create_x_image_and_pixmap): Remove unnecessary test for
668 xmalloc returning NULL; that can't happen.
669 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
670 (xpm_color_bucket): Use better integer hashing function.
671 (xpm_cache_color): Don't possibly over-allocate memory.
672 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
673 (gif_memory_source):
674 Use ptrdiff_t, not int or size_t, to record sizes.
675 (png_load): Don't assume values greater than 2**31 fit in 'int'.
676 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
677 either works, as we prefer signed integers.
678 (tiff_read_from_memory, tiff_write_from_memory):
679 Return tsize_t, not size_t, since that's what the TIFF API wants.
680 (tiff_read_from_memory): Don't fail simply because the read would
681 go past EOF; instead, return a short read.
682 (tiff_load): Omit no-longer-needed casts.
683 (Fimagemagick_types): Don't assume size fits into 'int'.
684
3cc5a532
PE
685 Improve hashing quality when configured --with-wide-int.
686 * fns.c (hash_string): New function, taken from sxhash_string.
687 Do not discard information about ASCII character case; this
688 discarding is no longer needed.
689 (sxhash-string): Use it. Change sig to match it. Caller changed.
690 * lisp.h: Declare it.
691 * lread.c (hash_string): Remove, since we now use fns.c's version.
692 The fns.c version returns a wider integer if --with-wide-int is
693 specified, so this should help the quality of the hashing a bit.
694
b312a492
PE
695 * emacs.c: Integer overflow minor fix.
696 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
697 Define only if GNU_LINUX.
698 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
699
dfd153ae
PE
700 * dispnew.c: Integer signedness and overflow fixes.
701 Remove unnecessary forward decls, that were a maintenance hassle.
702 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
703 All uses changed.
704 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
705 (scrolling_window): Use ptrdiff_t, not int, for byte count.
706 (prepare_desired_row, line_draw_cost):
707 Use int, not unsigned, where either works.
708 (save_current_matrix, restore_current_matrix):
709 Use ptrdiff_t, not size_t, where either works.
710 (init_display): Check for overflow more accurately, and without
711 relying on undefined behavior.
712
a81d11a3
PE
713 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
714 Remove, replacing with the new symbols in lisp.h. All uses changed.
715 * fileio.c (make_temp_name):
716 * filelock.c (lock_file_1, lock_file):
717 * xdisp.c (message_dolog):
718 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
719 Use pMd etc. instead.
720 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
721 replacing the pWIDE etc. symbols removed from editfns.c.
722
3300e6fd
PE
723 * keyboard.h (num_input_events): Now uintmax_t.
724 This is (very slightly) less likely to mess up due to wraparound.
725 All uses changed.
726
fd05c7e9
PE
727 * buffer.c: Integer signedness fixes.
728 (alloc_buffer_text, enlarge_buffer_text):
729 Use ptrdiff_t rather than size_t when either will do, as we prefer
730 signed integers.
731
903fe15d
PE
732 * alloc.c: Integer signedness and overflow fixes.
733 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
734 (__malloc_size_t): Default to size_t, not to int.
735 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
736 (Fgarbage_collect, mark_object_loop_halt, mark_object):
737 Prefer ptrdiff_t to size_t when either would do, as we prefer
738 signed integers.
739 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
740 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
741 Now const. Initialize with values that are in range even if char
742 is signed.
743 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
744 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
745 These functions do the right thing with sizes > 2**32.
746 (check_depth): Now ptrdiff_t, not int.
747 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
748 Adjust to new way of storing sizes. Check for size overflow bugs
749 in rest of code.
750 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
751 slightly wrong anyway, as it missed one instance of
752 XMALLOC_OVERRUN_CHECK_OVERHEAD.
753 (refill_memory_reserve): Omit needless cast to size_t.
754 (mark_object_loop_halt): Mark as externally visible.
755
ac82cc6a
PE
756 * xselect.c: Integer signedness and overflow fixes.
757 (Fx_register_dnd_atom, x_handle_dnd_message):
758 Use ptrdiff_t, not size_t, since we prefer signed.
759 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
760 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
761 x_dnd_atoms_size and x_dnd_atoms_length.
762
c2d1e36d
PE
763 * doprnt.c: Prefer signed to unsigned when either works.
764 * eval.c (verror):
765 * doprnt.c (doprnt):
766 * lisp.h (doprnt):
767 * xdisp.c (vmessage):
768 Use ptrdiff_t, not size_t, when using or implementing doprnt,
769 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
770 prefer signed arithmetic to avoid comparison confusion.
771 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
772 but is a bit tricky.
773
0e926e56
PE
774 Assume freestanding C89 headers, string.h, stdlib.h.
775 * data.c, doprnt.c, floatfns.c, print.c:
776 Include float.h unconditionally.
777 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
778 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
779 * regex.c: Likewise for stddef.h, string.h.
780 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
781 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
782 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
783 (STDC_HEADERS): Remove obsolete defines.
784 * sysdep.c: Include limits.h unconditionally.
785
9cfdb3ec
PE
786 Assume support for memcmp, memcpy, memmove, memset.
787 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
788 * regex.c (memcmp, memcpy):
789 Remove; we assume C89 now.
790
791 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
792 (__malloc_safe_bcopy): Remove; no longer needed.
793
cf950e6b 794 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
795 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
796 well either way, and we prefer signed to unsigned.
797
dbf38e02
LMI
7982011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
799
800 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
801 closes the connection while we're reading (bug#9182).
802
d6f0886c
JD
8032011-07-25 Jan Djärv <jan.h.d@swipnet.se>
804
805 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
806 are specified (Bug#9168).
807
2eb1f9e6
PE
8082011-07-25 Paul Eggert <eggert@cs.ucla.edu>
809
810 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
811 Found by GCC static checking and --with-wide-int on a 32-bit host.
812
22381272 8132011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
814
815 * xdisp.c (compute_display_string_pos): Fix logic of caching
816 previous display string position. Initialize cached_prev_pos to
817 -1. Fixes slow-down at the beginning of a buffer.
818
f25e39b4
EZ
8192011-07-24 Eli Zaretskii <eliz@gnu.org>
820
821 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
822 for attrs[LFACE_FONTSET_INDEX].
823
04c4b52e
PE
8242011-07-23 Paul Eggert <eggert@cs.ucla.edu>
825
826 * xml.c (parse_region): Remove unused local
827 that was recently introduced.
828
c1734fbd
EZ
8292011-07-23 Eli Zaretskii <eliz@gnu.org>
830
be18c5a5
EZ
831 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
832 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
833
c1734fbd
EZ
834 * xdisp.c (move_it_in_display_line_to): Record the best matching
835 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
836 exit if none of the characters scanned was an exact match.
837 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
838 when exact match is impossible due to invisible text, and the
839 lines are truncated.
840
a258d627
JD
8412011-07-23 Jan Djärv <jan.h.d@swipnet.se>
842
843 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
844 for OSX >= 10.7.
845
b6d5a689
EZ
8462011-07-22 Eli Zaretskii <eliz@gnu.org>
847
0f74f785
EZ
848 Fix a significant slow-down of cursor motion with C-n, C-p,
849 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
850 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 851 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
852 (next_element_from_buffer): Call compute_stop_pos_backwards to
853 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
854 base_level_stop.
855 (reseat): Don't look for prev_stop, as that could mean a very long
856 run.
857 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
858 <cached_disp_overlay_modiff>: Cache for last found display string
859 position.
551918c1 860 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
861 about the same buffer in the same area of character positions, and
862 the buffer wasn't changed since the time the display string
863 position was cached.
551918c1 864
b2d0c91a
EZ
8652011-07-22 Eli Zaretskii <eliz@gnu.org>
866
867 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
868 is an integer, which is important for empty lines. (Bug#9149)
869
043604ee
CY
8702011-07-22 Chong Yidong <cyd@stupidchicken.com>
871
872 * frame.c (Fmodify_frame_parameters): In tty case, update the
873 default face if necessary (Bug#4238).
874
da4adb04
CY
8752011-07-21 Chong Yidong <cyd@stupidchicken.com>
876
877 * editfns.c (Fstring_to_char): No need to explain what a character
878 is in the docstring (Bug#6576).
879
9abd0532
LMI
8802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
881
882 * xml.c (parse_region): Make sure we always return a tree.
883
36881d16
HK
8842011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
885
886 * xml.c (parse_region): If a document contains only comments,
887 return that, too.
888
1e98674d
LMI
8892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
890
891 * xml.c (make_dom): Return comments, too.
892
590bd467
PE
8932011-07-19 Paul Eggert <eggert@cs.ucla.edu>
894
895 Port to OpenBSD.
896 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
897 and the surrounding thread.
898 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
899 rather than fgets, and retry after EINTR. Otherwise, 'emacs
900 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
901 timer goes off.
902 * s/openbsd.h (BROKEN_SIGIO): Define.
903 * unexelf.c (unexec) [__OpenBSD__]:
904 Don't update the .mdebug section of the Alpha COFF symbol table.
905
f41628b2
LMI
9062011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
907
908 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
909 (bug#8460).
910
b59b67c5
PE
9112011-07-18 Paul Eggert <eggert@cs.ucla.edu>
912
15e3a074
PE
913 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
914 This fixes some race conditions on the permissions of any newly
915 created file.
916
41bed37d
PE
917 * alloc.c (valid_pointer_p): Use pipe, not open.
918 This fixes some permissions issues when debugging.
919
b59b67c5
PE
920 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
921 If fchown fails to set both uid and gid, try to set just gid,
922 as that is sometimes allowed. Adjust the file's mode to eliminate
923 setuid or setgid bits that are inappropriate if fchown fails.
924
925a6be7
SM
9252011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
926
927 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
928 to compare Lisp_Objects.
929 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
930 global_gnutls_log_level, don't mistake it for a Lisp_Object.
931 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
932
52968808
AS
9332011-07-17 Andreas Schwab <schwab@linux-m68k.org>
934
0a6a104b
AS
935 * lread.c (read_integer): Unread even EOF character.
936 (read1): Likewise. Properly record start position of symbol.
937
52968808
AS
938 * lread.c (read1): Read `#:' as empty uninterned symbol if no
939 symbol character follows.
940
9e381cdd
PE
9412011-07-17 Paul Eggert <eggert@cs.ucla.edu>
942
943 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
944 This works around a problem with the previous change to Fcopy_file.
945 Recent glibc declares fchown with __attribute__((warn_unused_result)),
946 and without this change, GCC might complain about discarding
947 fchown's return value.
948
b5641435
JB
9492011-07-16 Juanma Barranquero <lekktu@gmail.com>
950
951 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
952
a8031457
PE
9532011-07-16 Paul Eggert <eggert@cs.ucla.edu>
954
955 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
956
dd889327
LMI
9572011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
958
750c33f7
LMI
959 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
960 it's used from the C level.
961
dd889327
LMI
962 * process.c: Use the same condition for POLL_FOR_INPUT in both
963 keyboard.c and process.c (bug#1858).
964
87e86684
LM
9652011-07-09 Lawrence Mitchell <wence@gmx.li>
966
967 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
968 (Fgnutls_boot): Use it.
969
64348f40
AS
9702011-07-15 Andreas Schwab <schwab@linux-m68k.org>
971
972 * doc.c (Fsubstitute_command_keys): Revert last change.
973
1d698799
LMI
9742011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
975
f863868c
LMI
976 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
977 quotes the next character, and doesn't affect other longer
978 sequences (bug#8935).
979
1d698799
LMI
980 * lread.c (syms_of_lread): Clarify that is isn't only
981 `eval-buffer' and `eval-defun' that's affected by
982 `lexical-binding' (bug#8460).
983
aa4b6df6
EZ
9842011-07-15 Eli Zaretskii <eliz@gnu.org>
985
986 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
987 bidi redisplay when a line includes both an image and is
988 truncated.
989
5d856da6
PE
9902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
991
ad6042bb
PE
992 Fix minor problems found by static checking.
993 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
994 (elsz): Now a signed constant, not a size_t var. We prefer signed
995 types to unsigned, to avoid integer comparison confusion. Without
996 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
997 "cannot optimize loop, the loop counter may overflow", a symptom
998 of the confusion.
f00bbb22 999 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1000 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1001
6468f31c
LMI
10022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1003
49080b10
LMI
1004 * search.c (Fre_search_backward): Mention `case-fold-search' in
1005 all the re_search_* functions (bug#8138).
1006
6468f31c
LMI
1007 * keyboard.c (Fopen_dribble_file): Document when the file is
1008 closed (bug#8056).
1009
c965adc5
EZ
10102011-07-14 Eli Zaretskii <eliz@gnu.org>
1011
df9733bf
EZ
1012 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1013 bidi_cache_idx.
1014
0bb23927
EZ
1015 Support bidi reordering of display and overlay strings.
1016 * xdisp.c (compute_display_string_pos)
1017 (compute_display_string_end): Accept additional argument STRING.
1018 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1019 (reseat_to_string): Initialize bidi_it->string.s and
1020 bidi_it->string.schars.
1021 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1022 NULL (avoids a crash in bidi_paragraph_init).
1023 Initialize itb.string.lstring.
0bb23927
EZ
1024 (init_iterator): Call bidi_init_it only of a valid
1025 buffer position was specified. Initialize paragraph_embedding to
1026 L2R.
1027 (reseat_to_string): Initialize the bidi iterator.
1028 (display_string): If we need to ignore text properties of
1029 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1030 original value of -1 will not work with bidi.)
1031 (compute_display_string_pos): First arg is now struct
1032 `text_pos *'; all callers changed. Support display properties on
1033 Lisp strings.
1034 (compute_display_string_end): Support display properties on Lisp
1035 strings.
1036 (init_iterator, reseat_1, reseat_to_string): Initialize the
1037 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1038 when iterating on a string not from display properties).
640c8776
SM
1039 (compute_display_string_pos, compute_display_string_end):
1040 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1041 arrow keys.
1042 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1043 base_level_stop; instead, set base_level_stop to BEGV.
1044 Fixes crashes in vertical-motion.
0bb23927
EZ
1045 (next_element_from_buffer): Improve commentary for when
1046 the iterator is before prev_stop.
1047 (init_iterator): Initialize bidi_p from the default value of
1048 bidi-display-reordering, not from buffer-local value. Use the
1049 buffer-local value only if initializing for buffer iteration.
1050 (handle_invisible_prop): Support invisible properties on strings
1051 that are being bidi-reordered.
1052 (set_iterator_to_next): Support bidi reordering of C strings and
1053 Lisp strings.
1054 (next_element_from_string): Support bidi reordering of Lisp
1055 strings.
1056 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1057 (display_string): Support display of R2L glyph rows.
1058 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1059 (init_iterator): Don't initialize it->bidi_p for strings
1060 here.
1061 (reseat_to_string): Initialize it->bidi_p for strings here.
1062 (next_element_from_string, next_element_from_c_string)
1063 (next_element_from_buffer): Add xassert's for correspondence
1064 between IT's object being iterated and it->bidi_it.string
1065 structure.
1066 (face_before_or_after_it_pos): Support bidi iteration.
1067 (next_element_from_c_string): Handle the case of the first string
1068 character that is not the first one in the visual order.
1069 (get_visually_first_element): New function, refactored from common
1070 parts of next_element_from_buffer, next_element_from_string, and
1071 next_element_from_c_string.
1072 (tool_bar_lines_needed, redisplay_tool_bar)
1073 (display_menu_bar): Force left-to-right direction. Add a FIXME
1074 comment for making that be controlled by a user option.
1075 (push_it, pop_it): Save and restore the state of the
1076 bidi iterator. Save and restore the bidi_p flag.
1077 (pop_it): Iterate out of display property for string iteration as
1078 well.
1079 (iterate_out_of_display_property): Support iteration over strings.
1080 (handle_single_display_spec): Set up it->bidi_it for iteration
1081 over a display string, and call bidi_init_it.
1082 (handle_single_display_spec, next_overlay_string)
1083 (get_overlay_strings_1, push_display_prop): Set up the bidi
1084 iterator for displaying display or overlay strings.
1085 (forward_to_next_line_start): Don't use the shortcut if
1086 bidi-iterating.
1087 (back_to_previous_visible_line_start): If handle_display_prop
1088 pushed the iterator stack, restore the internal state of the bidi
1089 iterator by calling bidi_pop_it same number of times.
1090 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1091 and we are bidi-iterating, don't decrement the iterator position;
1092 instead, set the first_elt flag in the bidi iterator, to produce
1093 the same effect.
1094 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1095 (push_display_prop): xassert that we are iterating a buffer.
1096 (push_it, pop_it): Save and restore paragraph_embedding member.
1097 (handle_single_display_spec, next_overlay_string)
1098 (get_overlay_strings_1, reseat_1, reseat_to_string)
1099 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1100 correctly. Don't assume unibyte strings are not bidi-reordered.
1101 (compute_display_string_pos)
1102 (compute_display_string_end): Fix handling the case of C string.
1103 (push_it, pop_it): Save and restore from_disp_prop_p.
1104 (handle_single_display_spec, push_display_prop): Set the
1105 from_disp_prop_p flag.
1106 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1107 (pop_it): Call iterate_out_of_display_property only if we are
1108 popping after iteration over a string that came from a display
1109 property. Fix a typo in popping stretch info. Add an assertion
1110 for verifying that the iterator position is in sync with the bidi
1111 iterator.
1112 (handle_single_display_spec, get_overlay_strings_1)
1113 (push_display_prop): Fix initialization of paragraph direction for
1114 string when that of the parent object is not yet determined.
1115 (reseat_1): Call bidi_init_it to resync the bidi
1116 iterator with IT's position. (Bug#7616)
1117 (find_row_edges): If ROW->start.pos gives position
1118 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1119 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1120 Reset the from_disp_prop_p flag.
1121 (SAVE_IT, RESTORE_IT): New macros.
1122 (pos_visible_p, face_before_or_after_it_pos)
1123 (back_to_previous_visible_line_start)
1124 (move_it_in_display_line_to, move_it_in_display_line)
1125 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1126 (try_scrolling, redisplay_window, display_line): Use them when
1127 saving a temporary copy of the iterator and restoring it back.
1128 (back_to_previous_visible_line_start, reseat_1)
1129 (init_iterator): Empty the bidi cache "stack".
1130 (move_it_in_display_line_to): If iterator ended up at
1131 EOL, but we never saw any buffer positions smaller than
1132 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1133 motion in bidi-reordered lines.
1134 (move_it_in_display_line_to): Record prev_method and prev_pos
1135 immediately before the call to set_iterator_to_next. Fixes cursor
1136 motion in bidi-reordered lines with stretch glyphs and strings
1137 displayed in margins. (Bug#8133) (Bug#8867)
1138 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1139 TO_CHARPOS.
640c8776
SM
1140 (pos_visible_p): Support positions in bidi-reordered lines.
1141 Save and restore bidi cache.
0bb23927
EZ
1142
1143 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1144 (bidi_paragraph_info): Delete unused struct.
1145 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1146 (bidi_cache_start): New variable.
1147 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1148 to zero.
1149 (bidi_cache_fetch_state, bidi_cache_search)
1150 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1151 (bidi_cache_find, bidi_peek_at_next_level)
1152 (bidi_level_of_next_char, bidi_find_other_level_edge)
1153 (bidi_move_to_visually_next): Compare cache index with
1154 bidi_cache_start rather than with zero.
1155 (bidi_fetch_char): Accept new argument STRING; all callers
1156 changed. Support iteration over a string. Support strings with
1157 display properties. Support unibyte strings. Fix the type of
1158 `len' according to what STRING_CHAR_AND_LENGTH expects.
1159 (bidi_paragraph_init, bidi_resolve_explicit_1)
1160 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1161 (bidi_level_of_next_char, bidi_move_to_visually_next):
1162 Support iteration over a string.
0bb23927
EZ
1163 (bidi_set_sor_type, bidi_resolve_explicit_1)
1164 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1165 can now be zero (for strings); special values 0 and -1 were
1166 changed to -1 and -2, respectively.
1167 (bidi_char_at_pos): New function.
1168 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1169 Call it instead of FETCH_MULTIBYTE_CHAR.
1170 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1171 initialized to valid values.
1172 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1173 values.
1174 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1175 the test for valid cached positions. Fix the logic for looking up
1176 the sentinel state in the cache. GCPRO the Lisp string we are
1177 iterating.
1178 (bidi_push_it, bidi_pop_it): New functions.
1179 (bidi_initialize): Initialize the bidi cache start stack pointer.
1180 (bidi_cache_ensure_space): New function, refactored from part of
1181 bidi_cache_iterator_state. Don't assume the required size is just
1182 one BIDI_CACHE_CHUNK away.
1183 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1184 (bidi_count_bytes, bidi_char_at_pos): New functions.
1185 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1186 always valid if bidi_cache_idx is valid.
1187 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1188 is valid if it's going to be used.
1189 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1190 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1191 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1192 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1193 (bidi_find_other_level_edge, bidi_cache_start_stack):
1194 All variables related to cache indices are now EMACS_INT.
c965adc5 1195
0bb23927
EZ
1196 * dispextern.h (struct bidi_string_data): New structure.
1197 (struct bidi_it): New member `string'. Make flag members be 1-bit
1198 fields, and put them last in the struct.
640c8776
SM
1199 (compute_display_string_pos, compute_display_string_end):
1200 Update prototypes.
0bb23927
EZ
1201 (bidi_push_it, bidi_pop_it): Add prototypes.
1202 (struct iterator_stack_entry): New members bidi_p,
1203 paragraph_embedding, and from_disp_prop_p.
1204 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1205 (bidi_shelve_cache, bidi_unshelve_cache):
1206 Declare prototypes.
0bb23927
EZ
1207
1208 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1209 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1210 and vector-like objects.
1211
1212 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1213 cache around display iteration.
1214
1215 * window.c (Fwindow_end, window_scroll_pixel_based)
1216 (displayed_window_lines, Frecenter): Save and restore the bidi
1217 cache around display iteration.
1218
3bbd2265
LMI
12192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1220
1221 * editfns.c (Fdelete_region): Clarify the use of the named
1222 parameters (bug#6788).
1223
adc47434
MR
12242011-07-14 Martin Rudalics <rudalics@gmx.at>
1225
1226 * indent.c (Fvertical_motion): Set and restore w->pointm when
1227 saving and restoring the window's buffer (Bug#9006).
1228
837c31f8
LMI
12292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1230
1231 * editfns.c (Fstring_to_char): Clarify just what is returned
1232 (bug#6576). Text by Eli Zaretskii.
1233
ac389d0c
JB
12342011-07-13 Juanma Barranquero <lekktu@gmail.com>
1235
1236 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1237
0be0ce47
EZ
12382011-07-13 Eli Zaretskii <eliz@gnu.org>
1239
1240 * buffer.c (mmap_find): Fix a typo.
1241
cd18e7e3
JB
12422011-07-13 Johan Bockgård <bojohan@gnu.org>
1243
1244 Fix execution of x selection hooks.
1245 * xselect.c (Qx_lost_selection_functions)
1246 (Qx_sent_selection_functions): New vars.
1247 (syms_of_xselect): DEFSYM them.
1248 (x_handle_selection_request): Pass Qx_sent_selection_functions
1249 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1250 (x_handle_selection_clear,x_clear_frame_selections):
1251 Pass Qx_lost_selection_functions rather than
1252 Vx_lost_selection_functions to Frun_hook_with_args.
1253
47ea7f44
PE
12542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1255
ac389d0c 1256 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1257 The old code sometimes used this field without initializing it.
1258
47ea7f44
PE
1259 * alloc.c (gc_sweep): Don't read past end of array.
1260 In theory, the old code could also have corrupted Emacs internals,
1261 though it'd be very unlikely.
1262
bc985c87
AS
12632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1264
1265 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1266 argument. (Bug#4026)
bc985c87 1267
0cf34688
LMI
12682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1269
b3dadd76
LMI
1270 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1271 key" (bug#4257).
1272
0cf34688
LMI
1273 * window.c (Fset_window_start): Doc fix (bug#4199).
1274 (Fset_window_hscroll): Ditto.
1275
270768cd
PE
12762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1277
077e3dda 1278 Fix minor new problems caught by GCC 4.6.1.
270768cd 1279 * term.c (init_tty): Remove unused local.
490011a6 1280 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1281 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1282 not used otherwise.
270768cd 1283
b1f58454
CY
12842011-07-12 Chong Yidong <cyd@stupidchicken.com>
1285
1286 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1287
22b9578d
LMI
12882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1289
6e70ab07
LMI
1290 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1291 are the mini-buffer and the echo area (bug#3320).
1292
22b9578d
LMI
1293 * term.c (init_tty): Remove support for supdup, c10 and perq
1294 terminals, which are no longer supported (bug#1482).
1295
8974cc9f
JB
12962011-07-10 Johan Bockgård <bojohan@gnu.org>
1297
1298 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1299
a560d974
JD
13002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1301
1302 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1303 for non-popups (Bug#3642).
1304
1dae0f0a
AS
13052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1306
268c2c36 1307 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1308 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1309 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1310 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1311 * data.c (fmod): Likewise.
1312 * dispnew.c (swap_glyphs_in_rows): Likewise.
1313 * emacs.c (memory_warning_signal): Likewise.
1314 * floatfns.c (float_error): Likewise.
1315 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1316 (otf_open, font_otf_capability, generate_otf_features)
1317 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1318 Likewise.
1319 * image.c (pbm_read_file): Likewise.
1320 * indent.c (string_display_width): Likewise.
1321 * intervals.c (check_for_interval, search_for_interval)
1322 (inc_interval_count, count_intervals, root_interval)
1323 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1324 * lread.c (defalias): Likewise.
268c2c36 1325 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1326 * regex.c (set_image_of_range_1, set_image_of_range)
1327 (regex_grow_registers): Likewise.
1328 * sysdep.c (strerror): Likewise.
1329 * termcap.c (valid_filename_p, tprint, main): Likewise.
1330 * tparam.c (main): Likewise.
1331 * unexhp9k800.c (run_time_remap, save_data_space)
1332 (update_file_ptrs, read_header, write_header, calculate_checksum)
1333 (copy_file, copy_rest, display_header): Likewise.
1334 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1335 Likewise.
1336 * xdisp.c (check_it): Likewise.
1337 * xfaces.c (register_color, unregister_color, unregister_colors):
1338 Likewise.
1339 * xfns.c (print_fontset_result): Likewise.
1340 * xrdb.c (member, fatal, main): Likewise.
1341
99033785
PE
13422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 Fix minor problems found by static checking (Bug#9031).
1345 * chartab.c (char_table_set_range, map_sub_char_table):
1346 Remove unused locals.
1347 (uniprop_table): Now static.
1348 * composite.c (_work_char): Remove unused static var.
1349
9cb2ac56
JB
13502011-07-09 Juanma Barranquero <lekktu@gmail.com>
1351
1352 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1353
f25661f0
JD
13542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1355
1356 * gtkutil.c (qttip_cb): Remove code without function.
1357
8278c4fe
EZ
13582011-07-09 Eli Zaretskii <eliz@gnu.org>
1359
1360 * w32.c (pthread_sigmask): New stub.
1361
1692ae2d 13622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1363
8a6ebd58 1364 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1365 sigprocmask is portable only for single-threaded applications, and
1366 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1367 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1368 (LIBES): Use it.
1369 * callproc.c (Fcall_process):
1370 * process.c (create_process):
1371 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1372 Use pthread_sigmask, not sigprocmask.
123403e4 1373
1b854618
JD
13742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1375
1376 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1377 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1378 wrong (Bug#8591).
1379
3fe4b549
JD
13802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1381
0ce7e563
JD
1382 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1383 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1384 (xg_hide_tooltip): Fix comment.
1385
3fe4b549
JD
1386 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1387 in registerServicesMenuSendTypes.
1388 (validRequestorForSendType): Don't check ns_return_types.
1389
1390 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1391 ns_return_type.
1392
5df75e47
JR
13932011-07-08 Jason Rumney <jasonr@gnu.org>
1394
1395 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1396 frame struct members of non-existent frames (Bug#6284).
1397
699c10bd
JD
13982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1399
4393663b
JD
1400 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1401 variable firstTime not needed on OSX >= 10.6.
1402 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1403 >= 10.5. Use setKnobProportion, setDoubleValue.
1404
1405 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1406 (MAC_OS_X_VERSION_10_5): Define if not defined.
1407 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1408 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1409 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1410
1411 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1412 cString and lossyCString on OSX >= 10.4
1413
1414 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1415 sizeToFit on OSX >= 10.2.
1416
1417 * nsimage.m (allocInitFromFile): Don't use deprecated method
1418 bestRepresentationForDevice on OSX >= 10.6.
1419
1420 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1421 to avoid warning.
1422
1423 * emacs.c: Declare unexec_init_emacs_zone.
1424
a63e0781
JD
1425 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1426
699c10bd
JD
1427 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1428
1429 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1430 on svcsMenu (Bug#8842).
1431
1432 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1433 ns_return_types.
1434 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1435
1436 * nsterm.m (QUTF8_STRING): Declare.
1437 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1438 (validRequestorForSendType): Return type is (id).
1439 Change indexOfObjectIdenticalTo to indexOfObject.
1440 Check if we have local selection before returning self (Bug#8842).
1441 (writeSelectionToPasteboard): Put local selection into paste board
1442 if we have a local selection (Bug#8842).
1443 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1444
1445 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1446 (ns_get_local_selection): Declare.
1447
54e10184
LMI
14482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1449
9888ff71
LMI
1450 * keymap.c (describe_map_tree): Don't insert a double newline at
1451 the end of the buffer (bug#1169) and return whether we inserted
1452 something.
1453
54e10184
LMI
1454 * callint.c (Fcall_interactively): Change "reading args" to
1455 "providing args" to try to clarify what it does (bug#1010).
1456
15fa4783
KH
14572011-07-07 Kenichi Handa <handa@m17n.org>
1458
1459 * composite.c (composition_compute_stop_pos): Ignore a static
1460 composition starting before CHARPOS (Bug#8915).
1461
1462 * xdisp.c (handle_composition_prop): Likewise.
1463
a8815b00
EZ
14642011-07-07 Eli Zaretskii <eliz@gnu.org>
1465
1466 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1467 (Bug#9015)
1468
ef7b981d 14692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1470
1471 * character.h (unicode_category_t): New enum type.
1472
1473 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1474 (Qchar_code_property_table): New variable.
1475 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1476 (UNIPROP_COMPRESSED_FORM_P): New macros.
1477 (char_table_ascii): Uncompress the compressed values.
1478 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1479 Uncompress the compressed values.
ac389d0c 1480 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1481 (char_table_ref_and_range): Uncompress the compressed values.
1482 (sub_char_table_set): New arg is_uniprop. Callers changed.
1483 Uncompress the compressed values.
1484 (sub_char_table_set_range): Args changed. Callers changed.
1485 (char_table_set_range): Adjuted for the above change.
1486 (map_sub_char_table): Delete args default_val and parent. Add arg
1487 top. Give decoded values to a Lisp function.
640c8776 1488 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1489 values to a Lisp function. Gcpro more variables.
1490 (uniprop_table_uncompress)
1491 (uniprop_decode_value_run_length): New functions.
1492 (uniprop_decoder, uniprop_decoder_count): New variables.
1493 (uniprop_get_decoder, uniprop_encode_value_character)
1494 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1495 New functions.
1496 (uniprop_encoder, uniprop_encoder_count): New variables.
1497 (uniprop_get_encoder, uniprop_table)
1498 (Funicode_property_table_internal, Fget_unicode_property_internal)
1499 (Fput_unicode_property_internal): New functions.
1500 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1501 Sunicode_property_table_internal, Sget_unicode_property_internal,
1502 and Sput_unicode_property_internal. Defvar_lisp
1503 char-code-property-alist.
1504
640c8776 1505 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1506 Vunicode_category_table.
1507
640c8776 1508 * font.c (font_range): Adjust for the change of
c805dec0
KH
1509 Vunicode_category_table.
1510
76b397fb
DN
15112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1512
1513 * m/iris4d.h: Remove file, move contents ...
1514 * s/irix6-5.h: ... here.
1515
22b4128e
PE
15162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1517
1518 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1519 * alloc.c (mark_buffer):
1520 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1521 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1522 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1523 This isn't true in general, and it's particularly not true
1524 if Emacs is configured with --with-wide-int.
1525 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1526 New macros, used in the buffer.c change.
1527
869795d6
JD
15282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1529
1530 * xsettings.c: Use both GConf and GSettings if both are available.
1531 (store_config_changed_event): Add comment.
1532 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1533 (store_tool_bar_style_changed): New functions.
1534 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1535 (struct xsettings): Move font inside HAVE_XFT.
1536 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1537 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1538 Move inside HAVE_XFT.
640c8776 1539 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1540 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1541 also.
1542 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1543 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1544 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1545 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1546 (parse_settings): Move check for font inside HAVE_XFT.
1547 (read_settings, apply_xft_settings): Add comment.
1548 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1549 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1550 call store_font_name_changed.
1551 (xft_settings_event): Add comment.
1552 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1553 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1554 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1555 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1556 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1557 (xsettings_get_system_font, xsettings_get_system_normal_font):
1558 Add comment.
869795d6 1559
d8ed26bd
PE
15602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 Random fixes. E.g., (random) never returned negative values.
1563 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1564 subseconds part to the entropy, as that's a bit more random.
1565 Prefer signed to unsigned, since the signedness doesn't matter and
1566 in general we prefer signed. When given a limit, use a
1567 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1568 latter isn't right if USE_2_TAGS_FOR_INTS.
1569 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1570 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1571
cabf1cac
SM
15722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1573
1574 * textprop.c (text_property_stickiness):
1575 Obey Vtext_property_default_nonsticky.
1576 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1577 * w32fns.c (syms_of_w32fns):
1578 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1579
6e9b2be9
PE
15802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1583 This is more efficient than Ffile_directory_p and avoids a minor race.
1584
90186c68
LMI
15852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1586
7c301272
LMI
1587 * buffer.c (Foverlay_put): Say what the return value is
1588 (bug#7835).
1589
c4f2d8d4
LMI
1590 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1591 is a directory before asking whether to use the file name
1592 (bug#7564).
ad637907
LMI
1593 (barf_or_query_if_file_exists): Make the "File is a directory"
1594 error be more correct.
c4f2d8d4 1595
90186c68
LMI
1596 * fns.c (Frequire): Remove the mention of the .gz files, since
1597 that's installation-specific, but keep the mention of
1598 `get-load-suffixes'.
1599
da64016e
PE
16002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1603 Report string overflow if the output is too long.
1604
7d47b580
JB
16052011-07-04 Juanma Barranquero <lekktu@gmail.com>
1606
a555cb87
JB
1607 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1608 (syms_of_gnutls): Remove duplicate DEFSYM for
1609 Qgnutls_bootprop_verify_hostname_error, an error for
1610 Qgnutls_bootprop_verify_error (which is no longer used).
1611
7d47b580
JB
1612 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1613 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1614 Also (re)move comments that are misplaced or no longer relevant.
1615
1e49bfab
LMI
16162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1617
1618 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1619
1485f4c0
CY
16202011-07-03 Chong Yidong <cyd@stupidchicken.com>
1621
1622 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1623 and background color parameters if they have been changed.
1624
a9ab721e
LMI
16252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1626
1627 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1628
cf7cff57
PE
16292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1630
2e13213d
PE
1631 * xsettings.c (SYSTEM_FONT): Define only when used.
1632 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1633
cf7cff57
PE
1634 * keymap.c (access_keymap_1): Now static.
1635
7a8e04f7
CY
16362011-07-02 Chong Yidong <cyd@stupidchicken.com>
1637
1638 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1639 leave any prefix arg for the up event (Bug#1586).
1640
61352f62
LMI
16412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1642
69bb1ef7
LMI
1643 * lread.c (syms_of_lread): Mention single symbols defined by
1644 `defvar' or `defconst' (bug#7154).
1645
61352f62 1646 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1647 (Frequire): Mention get-load-suffixes.
61352f62 1648
28545e04
MR
16492011-07-02 Martin Rudalics <rudalics@gmx.at>
1650
1651 * window.h (window): Remove clone_number slot.
1652 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1653 Remove.
1654 (make_parent_window, make_window, saved_window)
1655 (Fset_window_configuration, save_window_save): Don't deal with
1656 clone numbers.
1657 * buffer.c (Qclone_number): Remove declaration.
1658 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1659
3349e122
SM
16602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1661
1662 Add multiple inheritance to keymaps.
1663 * keymap.c (Fmake_composed_keymap): New function.
1664 (Fset_keymap_parent): Simplify.
1665 (fix_submap_inheritance): Remove.
1666 (access_keymap_1): New function extracted from access_keymap to handle
1667 embedded parents and handle lists of maps.
1668 (access_keymap): Use it.
1669 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1670 (Fcopy_keymap): Handle embedded parents.
1671 (Fcommand_remapping, define_as_prefix): Simplify.
1672 (Fkey_binding): Simplify.
1673 (syms_of_keymap): Move minibuffer-local-completion-map,
1674 minibuffer-local-filename-completion-map,
1675 minibuffer-local-must-match-map, and
1676 minibuffer-local-filename-must-match-map to Elisp.
1677 (syms_of_keymap): Defsubr make-composed-keymap.
1678 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1679 (parse_menu_item): Trivial simplification.
1680
3279eb87
GM
16812011-07-01 Glenn Morris <rgm@gnu.org>
1682
1683 * Makefile.in (SETTINGS_LIBS): Fix typo.
1684
4550efdf
KI
16852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1686
1687 * coding.c (Fencode_coding_string): Record the last coding system
1688 used, as the function doc string says (bug#8738).
1689
0949d2b6
JD
16902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1691
1692 * xsettings.c (store_monospaced_changed): Take new font as arg and
1693 check for change against current_mono_font.
1694 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1695 (emacs_settings_constructor, emacs_settings_get_property)
1696 (emacs_settings_set_property, emacs_settings_class_init)
1697 (emacs_settings_init, gsettings_obj): Remove.
1698 (something_changedCB): New function for HAVE_GSETTINGS.
1699 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1700 with value as argument.
1701 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1702 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1703 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1704 "changed".
1705
1706 * xgselect.c: Add defined (HAVE_GSETTINGS).
1707 (xgselect_initialize): Ditto.
1708
1709 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1710 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1711 xg_select.
1712
bbc6b304
PE
17132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 * eval.c (struct backtrace): Simplify and port the data structure.
1716 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1717 signed bit field, as this assumption is not portable and it makes
1718 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1719 "char debug_on_exit : 1" as this is not portable either; instead,
1720 use the portable "unsigned int debug_on_exit : 1". Remove unused
1721 member evalargs. Remove obsolete comments about cc bombing out.
1722
9851bfc5
JD
17232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1724
51bb811f 1725 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1726 Let HAVE_GSETTINGS override HAVE_GCONF.
1727 (store_monospaced_changed): New function.
1728 (EMACS_SETTINGS): A new type derived from GObject to handle
1729 GSettings notifications.
1730 (emacs_settings_constructor, emacs_settings_get_property)
1731 (emacs_settings_set_property, emacs_settings_class_init):
1732 New functions.
1733 (gsettings_client, gsettings_obj): New variables.
1734 (GSETTINGS_SCHEMA): New define.
1735 (something_changedCB): Call store_monospaced_changed.
1736 (init_gsettings): New function.
1737 (xsettings_initialize): Call init_gsettings.
1738 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1739 to NULL.
1740
640c8776 1741 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1742 GCONF_CFLAGS/LIBS.
1743
5386012d
MR
17442011-06-29 Martin Rudalics <rudalics@gmx.at>
1745
1746 * window.c (resize_root_window, grow_mini_window)
1747 (shrink_mini_window): Rename Qresize_root_window to
1748 Qwindow_resize_root_window and Qresize_root_window_vertically to
1749 Qwindow_resize_root_window_vertically.
1750
f13e0b08
PE
17512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1752
1753 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1754
94515237
JB
17552011-06-27 Juanma Barranquero <lekktu@gmail.com>
1756
1757 * makefile.w32-in: Redesign dependencies so they reflect more
1758 clearly which files are directly included by each source file,
1759 and not through other includes.
1760
e43b6e43
MR
17612011-06-27 Martin Rudalics <rudalics@gmx.at>
1762
1763 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1764 (sort_overlays, overlay_strings): When an overlay's clone number
1765 matches the window's clone number process the overlay even if
1766 the overlay's window property doesn't match the current window.
1767
d68443dc
MR
1768 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1769 (Fwindow_hchild): Rename to Fwindow_left_child.
1770 (Fwindow_next): Rename to Fwindow_next_sibling.
1771 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1772 (resize_window_check): Rename to window_resize_check.
1773 (resize_window_apply): Rename to window_resize_apply.
1774 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1775 (Fdelete_other_windows_internal, resize_frame_windows)
1776 (Fsplit_window_internal, Fdelete_window_internal)
1777 (grow_mini_window, shrink_mini_window)
1778 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1779
c7e73be5
JD
17802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1781
1782 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1783 (emacs_fixed_set_min_size): Remove.
1784 (emacs_fixed_new): Take frame as argument.
1785
1786 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1787 (_EmacsFixedPrivate): Remove minwidth/height.
1788 Add struct frame *f.
1789 (emacs_fixed_init): Initialize priv->f.
1790 (get_parent_class, emacs_fixed_set_min_size): Remove.
1791 (emacs_fixed_new): Set priv->f to argument.
1792 (emacs_fixed_get_preferred_width)
1793 (emacs_fixed_get_preferred_height): Use min_width/height from
1794 frames size_hint to set minimum and natural (Bug#8919).
1795 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1796 and use min_width/height from frames size_hint to set
1797 min_width/height (Bug#8919).
1798
1799 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1800 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1801 Fix indentation.
c7e73be5 1802
cf99dcf8
EZ
18032011-06-26 Eli Zaretskii <eliz@gnu.org>
1804
1805 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1806 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1807 called at ZV.
1808
029529ac
CY
18092011-06-26 Chong Yidong <cyd@stupidchicken.com>
1810
1811 * process.c (wait_reading_process_output): Bypass select if
1812 waiting for a cell while ignoring keyboard input, and input is
1813 pending. Suggested by Jan Djärv (Bug#8869).
1814
7a7ef429
PE
18152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 Use gnulib's dup2 module instead of rolling our own.
1818 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1819
11fdef7d 18202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1821
1822 * dispnew.c (scrolling_window): Before scrolling, turn off a
1823 mouse-highlight in the window being scrolled.
1824
cd3520a4
JB
18252011-06-24 Juanma Barranquero <lekktu@gmail.com>
1826
1827 Move DEFSYM to lisp.h and use everywhere.
1828
1829 * character.h (DEFSYM): Move declaration...
1830 * lisp.h (DEFSYM): ...here.
1831
1832 * gnutls.c:
1833 * minibuf.c:
1834 * w32menu.c:
1835 * w32proc.c:
1836 * w32select.c: Don't include character.h.
1837
1838 * alloc.c (syms_of_alloc):
1839 * buffer.c (syms_of_buffer):
1840 * bytecode.c (syms_of_bytecode):
1841 * callint.c (syms_of_callint):
1842 * casefiddle.c (syms_of_casefiddle):
1843 * casetab.c (init_casetab_once):
1844 * category.c (init_category_once, syms_of_category):
1845 * ccl.c (syms_of_ccl):
1846 * cmds.c (syms_of_cmds):
1847 * composite.c (syms_of_composite):
1848 * dbusbind.c (syms_of_dbusbind):
1849 * dired.c (syms_of_dired):
1850 * dispnew.c (syms_of_display):
1851 * doc.c (syms_of_doc):
1852 * editfns.c (syms_of_editfns):
1853 * emacs.c (syms_of_emacs):
1854 * eval.c (syms_of_eval):
1855 * fileio.c (syms_of_fileio):
1856 * fns.c (syms_of_fns):
1857 * frame.c (syms_of_frame):
1858 * fringe.c (syms_of_fringe):
1859 * insdel.c (syms_of_insdel):
1860 * keymap.c (syms_of_keymap):
1861 * lread.c (init_obarray, syms_of_lread):
1862 * macros.c (syms_of_macros):
1863 * msdos.c (syms_of_msdos):
1864 * print.c (syms_of_print):
1865 * process.c (syms_of_process):
1866 * search.c (syms_of_search):
1867 * sound.c (syms_of_sound):
1868 * syntax.c (init_syntax_once, syms_of_syntax):
1869 * terminal.c (syms_of_terminal):
1870 * textprop.c (syms_of_textprop):
1871 * undo.c (syms_of_undo):
1872 * w32.c (globals_of_w32):
1873 * window.c (syms_of_window):
1874 * xdisp.c (syms_of_xdisp):
1875 * xfaces.c (syms_of_xfaces):
1876 * xfns.c (syms_of_xfns):
1877 * xmenu.c (syms_of_xmenu):
1878 * xsettings.c (syms_of_xsettings):
1879 * xterm.c (syms_of_xterm): Use DEFSYM.
1880
4228cf16
TZ
18812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1882
cd3520a4 1883 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1884
7fcccf1e
PE
18852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1886
7efb4e0e
PE
1887 Integer and buffer overflow fixes (Bug#8873).
1888
ff5844ad
PE
1889 * print.c (printchar, strout): Check for string overflow.
1890 (PRINTPREPARE, printchar, strout):
1891 Don't set size unless allocation succeeds.
1892
90532f02
PE
1893 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1894 for sizes. Check for string overflow more accurately.
1895 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1896
6d84508d
PE
1897 * macros.c: Integer and buffer overflow fixes.
1898 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1899 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1900 Use ptrdiff_t, not int, for sizes.
1901 Don't increment bufsize until after realloc succeeds.
1902 Check for size-calculation overflow.
1903 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1904
437b2cb4
PE
1905 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1906
8b9ac8b4
PE
1907 * lread.c: Integer overflow fixes.
1908 (read_integer): Radix is now EMACS_INT, not int,
1909 to improve quality of diagnostics for out-of-range radices.
1910 Calculate buffer size correctly for out-of-range radices.
1911 (read1): Check for integer overflow in radices, and in
1912 read-circle numbers.
82cb60d3
PE
1913 (read_escape): Avoid int overflow.
1914 (Fload, openp, read_buffer_size, read1)
1915 (substitute_object_recurse, read_vector, read_list, map_obarray):
1916 Use ptrdiff_t, not int, for sizes.
1917 (read1): Use EMACS_INT, not int, for sizes.
20270765 1918 Check for size overflow.
8b9ac8b4 1919
7fcccf1e
PE
1920 * image.c (cache_image): Check for size arithmetic overflow.
1921
bfbbd7e7
PE
1922 * lread.c: Integer overflow issues.
1923 (saved_doc_string_size, saved_doc_string_length)
1924 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1925 Now ptrdiff_t, not int.
1926 (read1): Don't assume doc string length fits in int. Check for
1927 out-of-range doc string lengths.
1928 (read_list): Don't assume file position fits in int.
39019e54 1929 (read_escape): Check for hex character overflow.
bfbbd7e7 1930
4e323265
LL
19312011-06-22 Leo Liu <sdl.web@gmail.com>
1932
1933 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1934 Move to minibuffer.el.
1935
85fece3e
PE
19362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1937
20b84ce9 1938 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1939 The following patches are for when GLYPH_DEBUG && !XASSERT.
1940 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1941 * dispnew.c (flush_stdout):
1942 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1943 Mark as externally visible.
1944 * dispnew.c (check_window_matrix_pointers): Now static.
1945 * dispnew.c (window_to_frame_vpos):
1946 * xfns.c (unwind_create_frame):
1947 * xterm.c (x_check_font): Remove unused local.
1948 * scroll.c (CHECK_BOUNDS):
1949 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1950 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1951 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1952 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1953 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1954 Now static.
1955 (debug_method_add): Use va_list and vsprintf rather than relying
1956 on undefined behavior with wrong number of arguments.
1957 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1958 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1959 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1960 since we're not interested in debugging glyphs with old libraries.
1961 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1962 GCC 4.6.0's static checking.
1963
0766b489
PE
19642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1965
31fd4b32
PE
1966 Integer overflow and signedness fixes (Bug#8873).
1967 A few related buffer overrun fixes, too.
1968
b79e8648
PE
1969 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1970
0766b489
PE
1971 * dispextern.h (struct face.stipple):
1972 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1973 (x_bitmap_mask, x_allocate_bitmap_record)
1974 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1975 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1976 (x_create_bitmap_from_xpm_data):
1977 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1978 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1979 (.bitmaps_last):
1980 * xfaces.c (load_pixmap):
1981 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1982 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1983 (.bitmaps_last, struct x_output.icon_bitmap):
1984 Use ptrdiff_t, not int, for bitmap indexes.
1985 (x_allocate_bitmap_record): Check for size overflow.
1986 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1987
b081724f
PE
1988 Use ptrdiff_t, not int, for overlay counts.
1989 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1990 * editfns.c (overlays_around, get_pos_property):
1991 * textprop.c (get_char_property_and_overlay):
1992 * xdisp.c (next_overlay_change, note_mouse_highlight):
1993 * xfaces.c (face_at_buffer_position):
21514da7
PE
1994 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1995 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1996 (Fnext_overlay_change, Fprevious_overlay_change)
1997 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1998 Use ptrdiff_t, not int, for sizes.
21514da7 1999 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2000
3de73e5e
PE
2001 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2002
2606c57b
PE
2003 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2004 (x_session_initialize): Do not assume string length fits in int.
2005
aaafe47a
PE
2006 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2007 This is unlikely, but can occur if DPI is outlandish.
2008
2674ddc8 2009 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2010 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2011
28154962
PE
2012 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2013 * xrdb.c (magic_file_p, search_magic_path):
2014 Omit last arg SUFFIX; it was always 0. All callers changed.
2015 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2016
7de51af5
PE
2017 * xfont.c (xfont_match): Avoid need for strlen.
2018
25ed6cc3
PE
2019 * xfns.c: Don't assume strlen fits in int.
2020 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2021
4eab31dd
PE
2022 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2023 not unsigned long, as we prefer signed integers. All callers changed.
2024 Detect integer overflow in repeat count.
2025 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2026 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2027
171e2a58
PE
2028 * termcap.c: Don't assume sizes fit in int and never overflow.
2029 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2030 (gobble_line): Check for size-calculation overflow.
2031
ad39faca 2032 * minibuf.c (Fread_buffer):
6e5bb2dc 2033 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2034 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2035 Don't assume string length fits in int.
2036
52c61c22 2037 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2038 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2039
b5b8c9e5
PE
2040 * font.c: Don't assume string length fits in int.
2041 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2042 Use ptrdiff_t, not int.
ccd6111c
PE
2043 (font_intern_prop): Don't assume string length fits in int.
2044 Don't assume integer property fits in fixnum.
2045 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2046
882f0d81 2047 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2048 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2049 Reformulate so as not to need the command string.
2050 Invoke gzip -cd rather than gunzip, as it's more portable.
2051 (lock_info_type, lock_file_1, lock_file):
2052 Don't assume pid_t and time_t fit in unsigned long.
2053 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2054 (current_lock_owner): Prefer signed type for sizes.
2055 Use memcpy, not strncpy, where memcpy is what is really wanted.
2056 Don't assume (via atoi) that time_t and pid_t fit in int.
2057 Check for time_t and/or pid_t out of range, e.g., via a network share.
2058 Don't alloca where an auto var works fine.
2059
93f4cf88
PE
2060 * fileio.c: Fix some integer overflow issues.
2061 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2062 Don't assume string length fits in int.
2063 (directory_file_name): Don't assume string length fits in long.
2064 (make_temp_name): Don't assume pid fits in int, or that its print
2065 length is less than 20.
2066
f3e92b69
PE
2067 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2068
1bfdaf10
PE
2069 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2070
35016e9a
PE
2071 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2072
3d1e65a1
PE
2073 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2074 We prefer signed integers, even for size calculations.
2075
0b963a93
PE
2076 * emacs.c: Don't assume string length fits in 'int'.
2077 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2078 (main): Don't invoke strlen when not needed.
2079
573f4b54
PE
2080 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2081 (XD_DEBUG_MESSAGE): Don't waste a byte.
2082
989f33ba
PE
2083 * callproc.c (getenv_internal_1, getenv_internal)
2084 (Fgetenv_internal):
965d34eb
PE
2085 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2086
e4d29b33
PE
2087 * lread.c (invalid_syntax): Omit length argument.
2088 All uses changed. This doesn't fix a bug, but it simplifies the
2089 code away from its former Hollerith-constant appearance, and it's
2090 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2091 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2092
eb49b136
PE
2093 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2094 This didn't break anything, but it didn't help either.
2095 It's confusing to put a bogus integer in a place where the actual
2096 value does not matter.
9f62aeb1 2097 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2098 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2099
15375a22
PE
2100 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2101 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2102 implementation.
b61cc01c
PE
2103 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2104 We prefer signed types, and the value cannot exceed the EMACS_INT
2105 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2106 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2107 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2108 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2109
53b2623d
PE
2110 * indent.c (sane_tab_width): New function.
2111 (current_column, scan_for_column, Findent_to, position_indentation)
2112 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2113 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2114
51cab52b 2115 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2116
f2ed8a70
PE
2117 * lisp.h (lint_assume): New macro.
2118 * composite.c (composition_gstring_put_cache):
2119 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2120
abe80cc6
PE
2121 * editfns.c, insdel.c:
2122 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2123
b02c740e
PE
2124 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2125
ebc96716
PE
2126 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2127
b4e50fa0 2128 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2129 Use much-faster test for byte-length change.
311d5d7c 2130 Don't assume string byte-length fits in 'int'.
a4cf38e4 2131 Check that character arg fits in 'int'.
85461888 2132 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2133
c0c1ee9f
PE
2134 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2135
a498d7f4
PE
2136 * fns.c (concat): Catch string overflow earlier.
2137 Do not rely on integer wraparound.
2138
51cab52b
PE
2139 * dispextern.h (struct it.overlay_strings_charpos)
2140 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2141 * xdisp.c (forward_to_next_line_start)
2142 (back_to_previous_visible_line_start)
2143 (reseat_at_next_visible_line_start, next_element_from_buffer):
2144 Don't arbitrarily truncate the value of 'selective' to int.
2145
76031fad
PE
2146 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2147
5eb55db9
PE
2148 * composite.c: Don't truncate sizes to 'int'.
2149 (composition_gstring_p, composition_reseat_it)
2150 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2151 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2152 not EMACS_UINT, for indexes.
5eb55db9 2153
0703a717
PE
2154 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2155
d6202519
PE
2156 * buffer.c: Include <verify.h>.
2157 (struct sortvec.priority, struct sortstr.priority):
8961a454 2158 Now EMACS_INT, not int.
c20998a7 2159 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2160 (struct sortstr.size, record_overlay_string)
2161 (struct sortstrlist.size, struct sortlist.used):
2162 Don't truncate size to int.
2163 (record_overlay_string): Check for size-calculation overflow.
d6202519 2164 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2165
d5a19415
JM
21662011-06-22 Jim Meyering <meyering@redhat.com>
2167
029529ac 2168 Don't leak an XBM-image-sized buffer
d5a19415
JM
2169 * image.c (xbm_load): Free the image buffer after using it.
2170
a9041e6c
PE
21712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2172
2173 Port to Sun C.
2174 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2175 that Sun C diagnosed.
2176 * fns.c (secure_hash): Fix pointer signedness issue.
2177 * intervals.c (static_offset_intervals): New function.
2178 (offset_intervals): Use it.
2179
7f3f739f
LL
21802011-06-21 Leo Liu <sdl.web@gmail.com>
2181
2182 * deps.mk (fns.o):
2183 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2184 sha512.h.
2185
2186 * fns.c (secure_hash): Rename from crypto_hash_function and change
2187 the first arg to accept symbols.
5b66d427 2188 (Fsecure_hash): New primitive.
7f3f739f
LL
2189 (syms_of_fns): New symbols.
2190
76147d94
DD
21912011-06-20 Deniz Dogan <deniz@dogan.se>
2192
2193 * process.c (Fset_process_buffer): Clarify return value in
2194 docstring.
2195
7d7d0045
CY
21962011-06-18 Chong Yidong <cyd@stupidchicken.com>
2197
2198 * dispnew.c (add_window_display_history): Use BVAR.
2199
2200 * xdisp.c (debug_method_add): Use BVAR.
2201 (check_window_end, dump_glyph_matrix, dump_glyph)
2202 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2203
2204 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2205 Likewise.
2206
2207 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2208 check till after the cache is created in init_frame_faces.
2209
ff2bc410
SM
22102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2211
2212 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2213
28177add
PE
22142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2215
dd3482fe
PE
2216 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2217 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2218 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2219
393d71f3 2220 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2221 * fileio.c (Finsert_file_contents):
2222 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2223 Remove the old (too-loose) buffer overflow checks.
2224 They weren't needed, since make_gap checks for buffer overflow.
2225 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2226 The old code merely checked for Emacs fixnum overflow, and relied
2227 on undefined (wraparound) behavior. The new code avoids undefined
2228 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2229
2e6813b0 2230 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2231 Tune. Don't use wider integers than needed. Don't use alloca.
2232 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2233
599a9e4f
PE
2234 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2235
99561444
PE
2236 * insdel.c, lisp.h (buffer_overflow): New function.
2237 (insert_from_buffer_1, replace_range, replace_range_2):
2238 * insdel.c (make_gap_larger):
2239 * editfns.c (Finsert_char):
2240 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2241
28177add
PE
2242 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2243
e69dafad
PE
22442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2245
a7af7fde 2246 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2247
b1c46f02
PE
2248 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2249 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2250
e69dafad
PE
2251 * fileio.c: Don't assume EMACS_INT fits in off_t.
2252 (emacs_lseek): New static function.
2253 (Finsert_file_contents, Fwrite_region): Use it.
2254 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2255
566684ea
PE
2256 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2257
e6966cd6
PE
2258 * fns.c: Don't overflow int when computing a list length.
2259 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2260 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2261 truncation on 64-bit hosts. Check for QUIT every
2262 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2263 faster and is responsive enough.
2264 (Flength): Report an error instead of overflowing an integer.
2265 (Fsafe_length): Return a float if the value is not representable
2266 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2267 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2268 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2269
dd0b0efb
PE
2270 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2271 (header_size, word_size): New constants.
2272 (allocate_vectorlike): Don't check size overflow here.
2273 (allocate_vector): Check it here instead, since this is the only
2274 caller of allocate_vectorlike that could cause overflow.
2275 Check that the new vector's length is representable as a fixnum.
2276
86fe5cfe
PE
2277 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2278 The previous code was bogus. For example, next_almost_prime (32)
2279 returned 39, which is undesirable as it is a multiple of 3; and
2280 next_almost_prime (24) returned 25, which is a multiple of 5 so
2281 why was the code bothering to check for multiples of 7?
2282
80e88859
PE
2283 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2284
4a2f0ad6
PE
2285 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2286
f66c7cf8
PE
2287 Variadic C functions now count arguments with ptrdiff_t.
2288 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2289 Back then I didn't know that the Emacs coding style prefers signed int.
2290 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2291 were being counted with int, which may truncate counts on 64-bit
2292 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2293 * lisp.h (struct Lisp_Subr.function.aMANY)
2294 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2295 Arg counts are now ptrdiff_t, not size_t.
2296 All variadic functions and their callers changed accordingly.
2297 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2298 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2299 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2300 * callint.c (Fcall_interactively): Check arg count for overflow,
2301 to avoid potential buffer overrun. Use signed char, not 'int',
2302 for 'varies' array, so that we needn't bother to check its size
2303 calculation for overflow.
2304 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2305 * eval.c (apply_lambda):
2306 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2307 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2308 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2309
a1759b76
PE
2310 * callint.c (Fcall_interactively): Don't use index var as event count.
2311
d96be9fc
PE
2312 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2313 * mem-limits.h (SIZE): Remove; no longer used.
2314
a690a978 2315 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2316
578c21e6
PE
2317 Remove unnecessary casts.
2318 * xterm.c (x_term_init):
2319 * xfns.c (x_set_border_pixel):
2320 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2321 These aren't needed now that we assume ANSI C.
2322
96f53c6c
PE
2323 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2324 It's more likely to cause problems (due to unsigned overflow)
2325 than to cure them.
2326
83c77d31
PE
2327 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2328
ee2079f1
PE
2329 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2330
6da65536
PE
2331 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2332
7147c4a4
PE
2333 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2334
193e32d9
PE
2335 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2336
e5533da6
PE
2337 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2338
9910e595
PE
2339 GLYPH_CODE_FACE returns EMACS_INT, not int.
2340 * dispextern.h (merge_faces):
2341 * xfaces.c (merge_faces):
01103c44
PE
2342 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2343 Don't assume EMACS_INT fits in int.
9910e595 2344
2638320e
PE
2345 * character.h (CHAR_VALID_P): Remove unused parameter.
2346 * fontset.c, lisp.h, xdisp.c: All uses changed.
2347
045eb8d9
PE
2348 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2349
c1f134b5
PE
2350 * fns.c (concat): Minor tuning based on overflow analysis.
2351 This doesn't fix any bugs. Use int to hold character, instead
2352 of constantly refetching from Emacs object. Use XFASTINT, not
2353 XINT, for value known to be a character. Don't bother comparing
2354 a single byte to 0400, as it's always less.
2355
395fcb93 2356 * floatfns.c (Fexpt):
327eeec8
PE
2357 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2358
abbd3d23
PE
2359 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2360 for characters.
2361
684a03ef
PE
2362 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2363
0fed43f3
PE
2364 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2365 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2366 incorrectly succeed when S was a string, because 4294967386 was
2367 truncated before it was used.
2368
8fd02eb7
PE
2369 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2370 Otherwise, an out-of-range integer could cause undefined behavior
2371 on a 64-bit host.
2372
f8c86b69
PE
2373 * composite.c: Use int, not EMACS_INT, for characters.
2374 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2375 EMACS_INT, for values that are known to be in character range.
2376 This doesn't fix any bugs but is the usual style inside Emacs and
2377 may generate better code on 32-bit machines.
2378
34206dd2
PE
2379 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2380 This is for reasons similar to the recent CHAR_STRING fix.
2381 * charset.c (Fencode_char): Check that character arg is actually
2382 a character. Pass an int to ENCODE_CHAR.
2383 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2384 wider than 'int', as a compile-time check to prevent future regressions
2385 in this area.
2386
c5958d4c 2387 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2388
2389 Make sure a 64-bit char is never passed to CHAR_STRING.
2390 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2391 by silently ignoring the top 32 bits, allowing some values
2392 that were far too large to be valid characters.
2393 * character.h: Include <verify.h>.
2394 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2395 arguments are no wider than unsigned, as a compile-time check
2396 to prevent future regressions in this area.
2397 * data.c (Faset):
01103c44 2398 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2399 (Fsubst_char_in_region):
2400 * fns.c (concat):
2401 * xdisp.c (decode_mode_spec_coding):
2402 Adjust to CHAR_STRING's new requirement.
2403 * editfns.c (Finsert_char, Fsubst_char_in_region):
2404 * fns.c (concat): Check that character args are actually
2405 characters. Without this test, these functions did the wrong
2406 thing with wildly out-of-range values on 64-bit hosts.
2407
d37ca623
PE
2408 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2409 These casts should not be needed on 32-bit hosts, either.
2410 * keyboard.c (read_char):
2411 * lread.c (Fload): Remove casts to unsigned.
2412
ea204efb
PE
2413 * lisp.h (UNSIGNED_CMP): New macro.
2414 This fixes comparison bugs on 64-bit hosts.
2415 (ASCII_CHAR_P): Use it.
2416 * casefiddle.c (casify_object):
01103c44 2417 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2418 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2419 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2420 * dispextern.h (FACE_FROM_ID):
2421 * keyboard.c (read_char): Use UNSIGNED_CMP.
2422
41cb286c
PE
2423 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2424 not to EMACS_INT, to avoid GCC warning.
2425
4a1b9832
PE
2426 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2427
55daad71
PE
2428 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2429 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2430 isn't needed on 32-bit machines.
8f95c75c 2431
01103c44
PE
2432 * buffer.c (Fgenerate_new_buffer_name):
2433 Use EMACS_INT for count, not int.
0ceccced 2434 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2435
2436 * data.c (Qcompiled_function): Now static.
2437
c6f072e7
PE
2438 * window.c (window_body_lines): Now static.
2439
20ce5912
PE
2440 * image.c (gif_load): Rename local to avoid shadowing.
2441
9c4c5f81
PE
2442 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2443 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2444 * alloc.c (make_save_value): Integer argument is now of type
2445 ptrdiff_t, not int.
2446 (mark_object): Use ptrdiff_t, not int.
2447 * lisp.h (pD): New macro.
2448 * print.c (print_object): Use it.
2449
c0c5c8ae
PE
2450 * alloc.c: Use EMACS_INT, not int, to count objects.
2451 (total_conses, total_markers, total_symbols, total_vector_size)
2452 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2453 (total_free_floats, total_floats, total_free_intervals)
2454 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2455 Now EMACS_INT, not int. All uses changed.
2456 (Fgarbage_collect): Compute overall total using a double, so that
2457 integer overflow is less likely to be a problem. Check for overflow
2458 when converting back to an integer.
5a25e253
PE
2459 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2460 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2461 These were 'int' variables that could overflow on 64-bit hosts;
2462 they were never used, so remove them instead of repairing them.
211a0b2a 2463 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2464 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2465 Previously, this ceilinged at INT_MAX, but that doesn't work on
2466 64-bit machines.
e46bb31a 2467 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2468
c78baabf 2469 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2470 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2471 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2472 when a (possibly-narrower) signed value would do just as well.
2473 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2474
c9d624c6
PE
2475 * alloc.c: Catch some string size overflows that we were missing.
2476 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2477 for convenience in STRING_BYTES_MAX.
2478 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2479 The definition here is exact; the one in lisp.h was approximate.
2480 (allocate_string_data): Check for string overflow. This catches
2481 some instances we weren't catching before. Also, it catches
2482 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2483 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2484 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2485
c9d624c6
PE
2486 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2487 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2488 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2489
353032ce
PE
2490 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2491
2bccce07
PE
2492 * alloc.c (Fmake_string): Check for out-of-range init.
2493
0ac30604
SM
24942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2495
2496 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2497
c195f2de
JD
24982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2499
2500 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2501 xg_get_default_scrollbar_width.
2502
2503 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2504 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2505 (style_changed_cb): Call update_theme_scrollbar_width and call
2506 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2507 all frames (Bug#8505).
2508 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2509 Call gtk_window_set_resizable if HAVE_GTK3.
2510 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2511 and height if HAVE_GTK3 (Bug#8505).
2512 (scroll_bar_width_for_theme): New variable.
2513 (update_theme_scrollbar_width): New function.
2514 (xg_get_default_scrollbar_width): Move code to
2515 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2516 (xg_initialize): Call update_theme_scrollbar_width.
2517
2518 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2519
2520 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2521
e10ac9f1
MR
25222011-06-12 Martin Rudalics <rudalics@gmx.at>
2523
2524 * frame.c (make_frame): Call other_buffer_safely instead of
2525 other_buffer.
2526
2527 * window.c (temp_output_buffer_show): Call display_buffer with
2528 second argument Vtemp_buffer_show_specifiers and reset latter
2529 immediately after the call.
2530 (Vtemp_buffer_show_specifiers): New variable.
2531 (auto_window_vscroll_p, next_screen_context_lines)
2532 (Vscroll_preserve_screen_position): Remove leading asterisks from
2533 doc-strings.
2534
2d3c217e 25352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2536
7b7f97e8 2537 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2538 * buffer.c (Qclone_number): Remove for now, as it's unused.
2539 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2540 (record_buffer): Remove unused local.
2541 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2542 (set_frame_buffer_list): Remove; unused.
2543 * frame.h (other_visible_frames): Remove decl.
2544 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2545 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2546 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2547 if HAVE_GPM.
2548 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2549 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2550 Define only if HAVE_GPM.
2551 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2552 (update_hints_inhibit): Remove; never set. All uses removed.
2553 * widgetprv.h (emacsFrameClassRec): Remove decl.
2554 * window.c (delete_deletable_window): Now returns void, since it
2555 wasn't returning anything.
2556 (compare_window_configurations): Remove unused locals.
2557 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2558 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2559 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2560 the same widths as pointers. This follows up on the 2011-05-06 patch.
2561 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2562 * xterm.h: Likewise.
2563 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2564
1384b89e
JB
25652011-06-12 Juanma Barranquero <lekktu@gmail.com>
2566
2567 * makefile.w32-in: Update dependencies.
2568 (LISP_H): Add lib/intprops.h.
2569
1100a63c
CY
25702011-06-11 Chong Yidong <cyd@stupidchicken.com>
2571
2572 * image.c (gif_load): Add animation frame delay to the metadata.
2573 (syms_of_image): Use DEFSYM. New symbol `delay'.
2574
6198ccd0
MR
25752011-06-11 Martin Rudalics <rudalics@gmx.at>
2576
2577 * window.c (delete_deletable_window): Re-add.
2578 (Fset_window_configuration): Rewrite to handle dead buffers and
2579 consequently deletable windows.
2580 (window_tree, Fwindow_tree): Remove. Supply functionality in
2581 window.el.
2582 (compare_window_configurations): Simplify code.
2583
b6e3633c
AS
25842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2585
1ab0dee5
AS
2586 * image.c (imagemagick_load_image): Fix type mismatch.
2587 (Fimagemagick_types): Likewise.
2588
b6e3633c
AS
2589 * window.h (replace_buffer_in_windows): Declare.
2590
9397e56f
MR
25912011-06-11 Martin Rudalics <rudalics@gmx.at>
2592
2593 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2594 Qclone_number. Remove external declaration of Qdelete_window.
2595 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2596 code.
640c8776
SM
2597 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2598 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2599 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2600 buffer list implementation.
2601 (other_buffer_safely): New function.
2602 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2603 calls to replace_buffer_in_windows and
2604 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2605 if allowed.
2606 (record_buffer): Inhibit quitting and rewrite using quittable
2607 functions. Run Qbuffer_list_update_hook if allowed.
2608 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2609 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2610 Move switch-to-buffer to window.el.
9397e56f
MR
2611 (bury-buffer): Move to window.el.
2612 (Vbuffer_list_update_hook): New variable.
2613
2614 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2615 section.
2616
2617 * window.h (resize_frame_windows): Move up in code.
2618 (Fwindow_frame): Remove EXFUN.
2619 (replace_buffer_in_all_windows): Remove prototype.
2620 (replace_buffer_in_windows_safely): Add prototype.
2621
2622 * window.c: Declare Qdelete_window static again. Move down
2623 declaration of select_count.
2624 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2625 (Fother_window): Move to window.el.
2626 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2627 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2628 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2629 window.el.
2630 (replace_buffer_in_windows): Implement by calling
2631 Qreplace_buffer_in_windows.
2632 (replace_buffer_in_all_windows): Remove with some functionality
2633 moved into replace_buffer_in_windows_safely.
2634 (replace_buffer_in_windows_safely): New function.
2635 (select_window_norecord, select_frame_norecord): Move in front
2636 of run_window_configuration_change_hook. Remove now obsolete
2637 declarations.
640c8776
SM
2638 (Fset_window_buffer): Rewrite doc-string.
2639 Call Qrecord_window_buffer.
9397e56f
MR
2640 (keys_of_window): Move binding for other-window to window.el.
2641
b50691aa
CY
26422011-06-11 Chong Yidong <cyd@stupidchicken.com>
2643
2644 * dispextern.h (struct image): Replace data member, whose int_val
2645 and ptr_val fields were not used by anything, with a single
2646 lisp_val object.
2647
2648 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2649 (gif_clear_image, gif_load, imagemagick_load_image)
2650 (gs_clear_image, gs_load): Callers changed.
2651
3f754b86
PE
26522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2653
cca69397
PE
2654 * buffer.h: Include <time.h>, for time_t.
2655 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2656
109e28d0
PE
2657 Fix minor problems found by static checking.
2658
60737f02
PE
2659 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2660
4b66faf3
PE
2661 Make identifiers static if they are not used in other modules.
2662 * data.c (Qcompiled_function, Qframe, Qvector):
2663 * image.c (QimageMagick, Qsvg):
2664 * minibuf.c (Qmetadata):
2665 * window.c (resize_window_check, resize_root_window): Now static.
2666 * window.h (resize_window_check, resize_root_window): Remove decls.
2667
109e28d0
PE
2668 * window.c (window_deletion_count, delete_deletable_window):
2669 Remove; unused.
46a4ce9e
PE
2670 (window_body_lines): Now static.
2671 (Fdelete_other_windows_internal): Mark vars as initialized.
2672 Make sure 'resize_failed' is initialized.
2673 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2674 (resize_window_apply): Remove unused local.
2675 * window.h (delete_deletable_window): Remove decl.
2676
109e28d0 2677 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2678 (imagemagick_load_image): Fix pointer signedness problem by changing
2679 last arg from unsigned char * to char *. All uses changed.
2680 Also, fix a local for similar reasons.
2681 Remove unused locals. Remove locals to avoid shadowing.
2682 (fn_rsvg_handle_free): Remove; unused.
2683 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2684 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2685
3f754b86
PE
2686 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2687
2547adb1
CY
26882011-06-10 Chong Yidong <cyd@stupidchicken.com>
2689
2690 * image.c (gif_load): Fix omitted cast error introduced by
2691 2011-06-06 change.
2692
2c8e37d4
MR
26932011-06-10 Martin Rudalics <rudalics@gmx.at>
2694
2695 * window.h (resize_proportionally, orig_total_lines)
2696 (orig_top_line): Remove from window structure.
2697 (set_window_height, set_window_width, change_window_heights)
2698 (Fdelete_window): Remove prototypes.
2699 (resize_frame_windows): Remove duplicate declaration.
2700
440a42e3
EZ
27012011-06-10 Eli Zaretskii <eliz@gnu.org>
2702
2703 * window.h (resize_frame_windows, resize_window_check)
2704 (delete_deletable_window, resize_root_window)
2705 (resize_frame_windows): Declare prototypes.
2706
2707 * window.c (resize_window_apply): Make definition be "static" to
2708 match the prototype.
2709
562dd5e9
MR
27102011-06-10 Martin Rudalics <rudalics@gmx.at>
2711
2712 * window.c: Remove declarations of Qwindow_size_fixed,
2713 window_min_size_1, window_min_size_2, window_min_size,
2714 size_window, window_fixed_size_p, enlarge_window, delete_window.
2715 Remove static from declaration of Qdelete_window, it's
2716 temporarily needed by Fbury_buffer.
2717 (replace_window): Don't assign orig_top_line and
2718 orig_total_lines.
2719 (Fdelete_window, delete_window): Remove. Window deletion is
2720 handled by window.el.
640c8776
SM
2721 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2722 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2723 (Fdelete_other_windows): Remove. Deleting other windows is
2724 handled by window.el.
2725 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2726 handled in window.el.
2727 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2728 Window minimum sizes are handled in window.el.
2729 (shrink_windows, size_window, set_window_height)
2730 (set_window_width, change_window_heights, window_height)
2731 (window_width, CURBEG, CURSIZE, enlarge_window)
2732 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2733 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2734 handled in window.el.
2735 (make_dummy_parent): Rename to make_parent_window and give it a
2736 second argument horflag.
2737 (make_window): Don't set resize_proportionally any more.
2738 (Fsplit_window): Remove. Windows are split in window.el.
2739 (save_restore_action, save_restore_orig_size)
2740 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2741 Resize mini windows in window.el.
2742 (grow_mini_window, shrink_mini_window): Implement by calling
2743 Qresize_root_window_vertically, resize_window_check and
2744 resize_window_apply.
640c8776
SM
2745 (saved_window, Fset_window_configuration, save_window_save):
2746 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2747 resize_proportionally.
2748 (window_min_height, window_min_width): Move to window.el.
2749 (keys_of_window): Move bindings for delete-other-windows,
2750 split-window, delete-window and enlarge-window to window.el.
2751
2752 * buffer.c: Temporarily extern Qdelete_window.
2753 (Fbury_buffer): Temporarily call Qdelete_window instead of
2754 Fdelete_window (Fbury_buffer will move to window.el soon).
2755
2756 * frame.c (set_menu_bar_lines_1): Remove code handling
2757 orig_top_line and orig_total_lines.
2758
2759 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2760 set_window_height but set heights directly.
2761 (change_frame_size_1): Use resize_frame_windows.
2762
2763 * xdisp.c (init_xdisp): Don't use set_window_height but set
2764 heights directly.
2765
640c8776
SM
2766 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2767 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2768 run_window_configuration_change_hook.
2769
2770 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2771 instead of change_window_heights and run
2772 run_window_configuration_change_hook.
2773
1a13852e
MR
27742011-06-09 Martin Rudalics <rudalics@gmx.at>
2775
2776 * window.c (replace_window): Rename second argument REPLACEMENT to
2777 NEW. New third argument SETFLAG. Rewrite.
2778 (delete_window, make_dummy_parent): Call replace_window with
2779 third argument 1.
2780 (window_list_1): Move down in code.
2781 (run_window_configuration_change_hook): Move set_buffer part
2782 before select_frame_norecord part in order to unwind correctly.
2783 Rename count1 to count.
2784 (recombine_windows, delete_deletable_window, resize_root_window)
2785 (Fdelete_other_windows_internal)
2786 (Frun_window_configuration_change_hook, make_parent_window)
2787 (resize_window_check, resize_window_apply, Fresize_window_apply)
2788 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2789 (Fdelete_window_internal, Fresize_mini_window_internal):
2790 New functions.
1a13852e
MR
2791 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2792
f3d1777e
MR
27932011-06-08 Martin Rudalics <rudalics@gmx.at>
2794
496e208e
MR
2795 * window.h (window): Add some new members to window structure -
2796 normal_lines, normal_cols, new_total, new_normal, clone_number,
2797 splits, nest, prev_buffers, next_buffers.
2798 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2799 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2800
f3d1777e
MR
2801 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2802 Remove.
496e208e
MR
2803 (make_dummy_parent): Set new members of windows structure.
2804 (make_window): Move down in code. Handle new members of window
2805 structure.
2806 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2807 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2808 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2809 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2810 (Fset_window_next_buffers, Fset_window_clone_number):
2811 New functions.
496e208e
MR
2812 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2813 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2814 Doc-string fixes.
2815 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2816 Argument WINDOW can be now internal window too.
2817 (Fwindow_use_time): Move up in code.
2818 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2819 Rewrite doc-string.
2820 (Fset_window_configuration, saved_window)
2821 (Fcurrent_window_configuration, save_window_save): Handle new
2822 members of window structure.
b9e809c2
MR
2823 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2824 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2825 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2826 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2827 Qget_mru_window, Qresize_root_window,
2828 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2829 Qauto_buffer_name; staticpro them.
f3d1777e 2830
abde8f8c
MR
28312011-06-07 Martin Rudalics <rudalics@gmx.at>
2832
2833 * window.c (Fwindow_total_size, Fwindow_left_column)
2834 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2835 (Fwindow_list_1): New functions.
2836 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2837 (Fwindow_width, Fscroll_left, Fscroll_right):
2838 Use window_body_cols instead of window_box_text_cols.
2839 (delete_window, Fset_window_configuration):
2840 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2841 (delete_all_subwindows): Take a window as argument and not a
2842 structure. Rewrite.
190b47e6
MR
2843 (window_loop): Remove handling of GET_LRU_WINDOW and
2844 GET_LARGEST_WINDOW.
2845 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2846
2847 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2848 window_box_text_cols. delete_all_subwindows now takes a
2849 Lisp_Object as argument.
abde8f8c 2850
640c8776
SM
2851 * indent.c (compute_motion, Fcompute_motion):
2852 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2853
fa8a67e6
MR
2854 * frame.c (delete_frame): Call delete_all_subwindows with root
2855 window as argument.
2856
a54e3482
DC
28572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2858
2859 * fns.c (Fputhash): Document return value.
2860
60002bf5
CY
28612011-06-06 Chong Yidong <cyd@stupidchicken.com>
2862
2863 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2864
0c671da6 28652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2866
b862a52a 2867 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2868
be44ca6c
PE
2869 Check for overflow when converting integer to cons and back.
2870 * charset.c (Fdefine_charset_internal, Fdecode_char):
2871 Use cons_to_unsigned to catch overflow.
2872 (Fencode_char): Use INTEGER_TO_CONS.
2873 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2874 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2875 * data.c (long_to_cons, cons_to_long): Remove.
2876 (cons_to_unsigned, cons_to_signed): New functions.
2877 These signal an error for invalid or out-of-range values.
2878 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2879 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2880 * font.c (Ffont_variation_glyphs):
2881 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2882 * lisp.h: Include <intprops.h>.
2883 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2884 (cons_to_signed, cons_to_unsigned): New decls.
2885 (long_to_cons, cons_to_long): Remove decls.
2886 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2887 (Fprimitive_undo): Use CONS_TO_INTEGER.
2888 * xfns.c (Fx_window_property): Likewise.
2889 * xselect.c: Include <limits.h>.
2890 (x_own_selection, selection_data_to_lisp_data):
2891 Use INTEGER_TO_CONS.
2892 (x_handle_selection_request, x_handle_selection_clear)
2893 (x_get_foreign_selection, Fx_disown_selection_internal)
2894 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2895 (lisp_data_to_selection_data): Use cons_to_unsigned.
2896 (x_fill_property_data): Use cons_to_signed.
2897 Report values out of range.
2898
d1f3d2af
PE
2899 Check for buffer and string overflow more precisely.
2900 * buffer.h (BUF_BYTES_MAX): New macro.
2901 * lisp.h (STRING_BYTES_MAX): New macro.
2902 * alloc.c (Fmake_string):
2903 * character.c (string_escape_byte8):
2904 * coding.c (coding_alloc_by_realloc):
2905 * doprnt.c (doprnt):
2906 * editfns.c (Fformat):
2907 * eval.c (verror):
2908 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2909 since they may not be the same number.
2910 * editfns.c (Finsert_char):
2911 * fileio.c (Finsert_file_contents):
2912 Likewise for BUF_BYTES_MAX.
2913
dd52fcea
PE
2914 * image.c: Use ptrdiff_t, not int, for sizes.
2915 (slurp_file): Switch from int to ptrdiff_t.
2916 All uses changed.
2917 (slurp_file): Check that file size fits in both size_t (for
2918 malloc) and ptrdiff_t (for sanity and safety).
2919
7f9bbdbb
PE
2920 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2921 if b->modtime has its maximal value.
2922
dfe18f82
PE
2923 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2924
84acfcf0
PE
2925 Don't assume time_t can fit into int.
2926 * buffer.h (struct buffer.modtime): Now time_t, not int.
2927 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2928 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2929
ccd9a01a
PE
2930 Minor fixes for signed vs unsigned integers.
2931 * character.h (MAYBE_UNIFY_CHAR):
2932 * charset.c (maybe_unify_char):
2933 * keyboard.c (read_char, reorder_modifiers):
2934 XINT -> XFASTINT, since the integer must be nonnegative.
2935 * ftfont.c (ftfont_spec_pattern):
2936 * keymap.c (access_keymap, silly_event_symbol_error):
2937 XUINT -> XFASTINT, since the integer must be nonnegative.
2938 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2939 since it makes no difference and we prefer signed.
2940 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2941 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2942 nonnegative.
2943
d6d100dd
SM
29442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2945
2946 * window.h (Fwindow_frame): Declare.
2947
2b6148e4
PE
29482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2951 (SPARE_MEMORY): Always define.
2952 (LARGE_REQUEST): Remove.
2953 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2954
f230ecc9
MR
29552011-06-06 Martin Rudalics <rudalics@gmx.at>
2956
727e958e
MR
2957 * lisp.h: Move EXFUNS for Fframe_root_window,
2958 Fframe_first_window and Fset_frame_selected_window to window.h.
2959
2960 * window.h: Move EXFUNS for Fframe_root_window,
2961 Fframe_first_window and Fset_frame_selected_window here from
2962 lisp.h.
2963
2964 * frame.c (Fwindow_frame, Fframe_first_window)
2965 (Fframe_root_window, Fframe_selected_window)
2966 (Fset_frame_selected_window): Move to window.c.
2967 (Factive_minibuffer_window): Move to minibuf.c.
2968 (Fother_visible_frames_p): New function.
2969
2970 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2971
f230ecc9
MR
2972 * window.c (decode_window, decode_any_window): Move up in code.
2973 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2974 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2975 (Fwindow_buffer): Move up and rewrite doc-string.
2976 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2977 (Fwindow_prev): New functions.
727e958e
MR
2978 (Fwindow_frame): Move here from frame.c. Accept any window as
2979 argument.
2980 (Fframe_root_window, Fframe_first_window)
2981 (Fframe_selected_window): Move here from frame.c. Accept frame
2982 or arbitrary window as argument. Update doc-strings.
2983 (Fminibuffer_window): Move up in code.
2984 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2985 (Fset_frame_selected_window): Move here from frame.c.
2986 Marginal rewrite.
727e958e
MR
2987 (Fselected_window, select_window, Fselect_window): Move up in
2988 code. Minor doc-string fixes.
f230ecc9 2989
4d09bcf6
PE
29902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2993 Do not assume that spare memory exists; that assumption is valid
2994 only if SYSTEM_MALLOC.
2995 (LARGE_REQUEST): New macro, so that the issue of large requests
2996 is separated from the issue of spare memory.
2997
810928a2
AS
29982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2999
172418ad
AS
3000 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3001 format. (Bug#8806)
3002
43f862f7
AS
3003 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3004
810928a2
AS
3005 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3006 before statements.
3007
a059fe24
JD
30082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3009
3010 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3011
3012 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3013
3014 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3015 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3016
989bf368
JB
30172011-06-05 Juanma Barranquero <lekktu@gmail.com>
3018
3019 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3020
4b80f674
CY
30212011-06-04 Chong Yidong <cyd@stupidchicken.com>
3022
3023 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3024 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3025 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3026 New error handlers.
4b80f674
CY
3027 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3028 Obey Vx_select_enable_clipboard_manager. Catch errors in
3029 x_clipboard_manager_save (Bug#8779).
3030 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3031 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3032
99a33b77 30332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3034
3035 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3036
99a33b77 30372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3038
3039 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3040 in the current matrix if keep_current_p is non-zero.
3041
8264569d
EZ
30422011-06-04 Eli Zaretskii <eliz@gnu.org>
3043
3044 * bidi.c (bidi_level_of_next_char): Fix last change.
3045
57f97249
EZ
30462011-06-03 Eli Zaretskii <eliz@gnu.org>
3047
fec2107c 3048 Support bidi reordering of text covered by display properties.
57f97249 3049
fec2107c
EZ
3050 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3051 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3052 (bidi_cache_search, bidi_cache_iterator_state)
3053 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3054 (bidi_level_of_next_char, bidi_move_to_visually_next):
3055 Support character positions inside a run of characters covered by a
fec2107c
EZ
3056 display string.
3057 (bidi_paragraph_init, bidi_resolve_explicit_1)
3058 (bidi_level_of_next_char): Call bidi_fetch_char and
3059 bidi_fetch_char_advance instead of FETCH_CHAR and
3060 FETCH_CHAR_ADVANCE.
3061 (bidi_init_it): Initialize new members.
3062 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3063 definitions.
3064 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3065 instead of using explicit *_CHAR codes.
d6d100dd
SM
3066 (bidi_resolve_explicit, bidi_resolve_weak):
3067 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3068 bidirectional text is supported only in multibyte buffers.
3069 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3070 it to initialize the frame_window_p member of struct bidi_it.
3071 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3072 (bidi_resolve_explicit, bidi_resolve_weak)
3073 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3074 bidi_it->nchars is non-positive.
3075 (bidi_level_of_next_char): Don't try to lookup the cache for the
3076 next/previous character if nothing is cached there yet, or if we
3077 were just reseat()'ed to a new position.
c40e2fb2 3078
0e14fe90
EZ
3079 * xdisp.c (set_cursor_from_row): Set start and stop points
3080 according to the row's direction when priming the loop that looks
3081 for the glyph on which to display cursor.
3082 (single_display_spec_intangible_p): Function deleted.
3083 (display_prop_intangible_p): Reimplement to call
3084 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3085 Accept 3 additional arguments needed by handle_display_spec.
3086 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3087 values: lists, `(when COND...)' forms, etc.
3088 (single_display_spec_string_p): Support property values that are
3089 lists with the argument STRING its top-level element.
3090 (display_prop_string_p): Fix the condition for processing a
3091 property that is a list to be consistent with handle_display_spec.
fec2107c 3092 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3093 last portion of handle_display_prop.
3094 (compute_display_string_pos): Accept additional argument
3095 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3096 value of a `display' property is a "replacing spec".
3097 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3098 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3099 the display property, but just return a value indicating whether
3100 the display property will replace the characters it covers.
3101 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3102 frame_window_p members of struct bidi_it.
d6d100dd
SM
3103 (compute_display_string_pos, compute_display_string_end):
3104 New functions.
fec2107c
EZ
3105 (push_it): Accept second argument POSITION, where pop_it should
3106 jump to continue iteration.
3107 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3108
fec2107c
EZ
3109 * keyboard.c (adjust_point_for_property): Adjust the call to
3110 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3111
3112 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3113 (bidi_init_it): Update prototypes.
3114 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3115 (compute_display_string_pos, compute_display_string_end):
3116 Declare prototypes.
fec2107c
EZ
3117 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3118 EMACS_INT.
fc6f18ce 3119
40087514 31202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3121
57f53182
PE
3122 Malloc failure behavior now depends on size of allocation.
3123 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3124 * lisp.h: Change signatures accordingly.
3125 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3126 All callers changed. (Bug#8762)
3127
3128 * gnutls.c: Use Emacs's memory allocators.
3129 Without this change, the gnutls library would invoke malloc etc.
3130 directly, which causes problems on non-SYNC_INPUT hosts, and which
3131 runs afoul of improving memory_full behavior. (Bug#8761)
3132 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3133 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3134 xfree instead of the default malloc, realloc, free.
3135 (Fgnutls_boot): No need to check for memory allocation failure,
3136 since xmalloc does that for us.
3137
ac32cd99 3138 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3139 * category.c (hash_get_category_set):
3140 * ccl.c (ccl_driver):
3141 * charset.c (Fdefine_charset_internal):
3142 * charset.h (struct charset.hash_index):
3143 * composite.c (get_composition_id, gstring_lookup_cache)
3144 (composition_gstring_put_cache):
3145 * composite.h (struct composition.hash_index):
3146 * dispextern.h (struct image.hash):
3147 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3148 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3149 (hashfn_equal, hashfn_user_defined, make_hash_table)
3150 (maybe_resize_hash_table, hash_lookup, hash_put)
3151 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3152 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3153 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3154 * image.c (make_image, search_image_cache, lookup_image)
3155 (xpm_put_color_table_h):
3156 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3157 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3158 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3159 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3160 * alloc.c (allocate_vectorlike):
3161 Check for overflow in vector size calculations.
3162 * ccl.c (ccl_driver):
3163 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3164 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3165 need to be updated by these changes.
40087514
PE
3166 * fns.c (make_hash_table, maybe_resize_hash_table):
3167 Check for integer overflow with large hash tables.
0de4bb68
PE
3168 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3169 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3170 (SXHASH_REDUCE): New macro.
3171 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3172 Use it instead of discarding useful hash info with large hash values.
3173 (sxhash_float): New function.
3174 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3175 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3176 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3177 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3178 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3179 Adjust signatures to match updated version of code.
3180 (consing_since_gc): Now EMACS_INT, since a single hash table can
3181 use more than INT_MAX bytes.
3182
698d32e2
DN
31832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3184
3185 Make it possible to build with GCC-4.6+ -O2 -flto.
3186
3187 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3188
fd6fa53f
SM
31892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3190
3191 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3192 Call minibuffer-inactive-mode.
3193
864db017
JB
31942011-05-31 Juanma Barranquero <lekktu@gmail.com>
3195
3196 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3197 Update dependencies.
3198
2ad0baf4
DN
31992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3200
3201 * data.c (init_data): Remove code for UTS, this system is not
3202 supported anymore.
3203
4fcc2638
DN
32042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3205
3206 Don't force ./temacs to start in terminal mode.
3207
3208 * frame.c (make_initial_frame): Initialize faces in all cases, not
3209 only when CANNOT_DUMP is defined.
3210 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3211
c56e0fd5
DN
32122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3213
3214 * dispnew.c (add_window_display_history): Use const for the string
3215 pointer. Remove declaration, not needed.
3216
333d54da 32172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3218
55d4c1b2 3219 Use 'inline', not 'INLINE'.
333d54da 3220 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3221 * alloc.c, fontset.c (INLINE): Remove.
3222 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3223 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3224 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3225 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3226 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3227
738db178
DN
32282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3229
3230 Make it possible to run ./temacs.
3231
3232 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3233 syms_of_callproc does the same thing. Remove test for
3234 "initialized", do it in the caller.
3235 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3236
620c53a6
SM
32372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3238
3239 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3240 (read_minibuf): Use get_minibuffer.
3241 (syms_of_minibuf): Use DEFSYM.
3242 (Qmetadata): New var.
3243 * data.c (Qbuffer): Don't make it static.
3244 (syms_of_data): Use DEFSYM.
3245
e003a292
PE
32462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3249 (CCL_CODE_MIN): New macro.
3250
ed008a6d
PE
32512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3252
3687c2ef
PE
3253 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3254
ed008a6d
PE
3255 * eval.c (Qdebug): Now static.
3256 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3257 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3258 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3259
d66c4c7c
CY
32602011-05-29 Chong Yidong <cyd@stupidchicken.com>
3261
3262 * image.c: Various fixes to ImageMagick code comments.
3263 (Fimagemagick_types): Doc fix.
3264
5fbc2025
PE
32652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3266
0196f88a
PE
3267 Minor fixes prompted by GCC 4.6.0 warnings.
3268
3269 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3270
5fbc2025
PE
3271 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3272 (x_clipboard_manager_save_all): Move extern decl to ...
3273 * xterm.h: ... here, so that it can be checked for consistency.
3274
1dd3c2d9
CY
32752011-05-29 Chong Yidong <cyd@stupidchicken.com>
3276
3277 * xselect.c (x_clipboard_manager_save_frame)
3278 (x_clipboard_manager_save_all): New functions.
3279 (Fx_clipboard_manager_save): Lisp function deleted.
3280
3281 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3282 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3283
3284 * xterm.h: Update prototype.
3285
5ba6571d
WX
32862011-05-28 William Xu <william.xwl@gmail.com>
3287
3288 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3289 exiting (Bug#8239).
3290
3eaff834
JM
32912011-05-28 Jim Meyering <meyering@redhat.com>
3292
e1900994 3293 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3294 * fns.c (to_uchar): Define.
3295 (crypto_hash_function): Use it to convert some newly-signed
3296 variables to unsigned, to avoid sign-extension bugs. For example,
3297 without this change, (md5 "truc") would evaluate to
3298 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3299 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3300 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3301
0f6990a7
PE
33022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3303
3304 Integer overflow fixes.
c8a9ca5a 3305
08686060
PE
3306 * dbusbind.c: Serial number integer overflow fixes.
3307 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3308 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3309 to hold a serial number that is too large for a fixnum.
3310 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3311 Check for serial numbers out of range. Decode any serial number
59568bf0 3312 that was so large that it became a float. (Bug#8722)
08686060 3313
2d1fc3c7
PE
3314 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3315 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3316 Use XFASTINT rather than XUINT when numbers are nonnegative.
3317 (xd_append_arg, Fdbus_method_return_internal):
3318 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3319 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3320 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3321 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3322 (Bug#8722)
2d1fc3c7 3323
c8a9ca5a
PE
3324 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3325
519e1d69
PE
3326 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3327
30569699
PE
3328 ccl: add integer overflow checks
3329 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3330 (IN_INT_RANGE): New macros.
3331 (ccl_driver): Use them to check for integer overflow when
3332 decoding a CCL program. Many of the new checks are whether XINT (x)
3333 fits in int; it doesn't always, on 64-bit hosts. The new version
3334 doesn't catch all possible integer overflows, but it's an
847044ea 3335 improvement. (Bug#8719)
30569699 3336
c11285dc
PE
3337 * alloc.c (make_event_array): Use XINT, not XUINT.
3338 There's no need for unsigned here.
3339
fdccd48e
PE
3340 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3341 This follows up to the 2011-05-06 change that substituted uintptr_t
3342 for EMACS_INT. This case wasn't caught back then.
3343
37910ab2
PE
3344 Rework Fformat to avoid integer overflow issues.
3345 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3346 now (part of C89). Include <verify.h>.
3347 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3348 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3349 (Fformat): Avoid the prepass trying to compute sizes; it was only
3350 approximate and thus did not catch overflow reliably. Instead, walk
3351 through the format just once, formatting and computing sizes as we go,
3352 checking for integer overflow at every step, and allocating a larger
3353 buffer as needed. Keep track separately whether the format is
3354 multibyte. Keep only the most-recently calculated precision, rather
3355 than them all. Record whether each argument has been converted to
3356 string. Use EMACS_INT, not int, for byte and char and arg counts.
3357 Support field widths and precisions larger than INT_MAX. Avoid
3358 sprintf's undefined behavior with conversion specifications such as %#d
3359 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3360 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3361 formatting out-of-range floating point numbers with int
9173deec 3362 formats. (Bug#8668)
37910ab2 3363
2e6578fb
PE
3364 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3365
0ae6bdee
PE
3366 * data.c: Avoid integer truncation in expressions involving floats.
3367 * data.c: Include <intprops.h>.
3368 (arith_driver): When there's an integer overflow in an expression
3369 involving floating point, convert the integers to floating point
3370 so that the resulting value does not suffer from catastrophic
3371 integer truncation. For example, on a 64-bit host (* 4
3372 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3373 Do not rely on undefined behavior after integer overflow.
3374
de883a70
PE
3375 merge count_size_as_multibyte, parse_str_to_multibyte
3376 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3377 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3378 Check for integer overflow.
3379 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3380 since it's now a duplicate of the other. This is more of
3381 a character than a buffer op, so better that it's in character.c.
3382 * fns.c, print.c: Adjust to above changes.
3383
2ff916cb
PE
33842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3385
3386 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3387
f1b54466
PE
33882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3389
fb1ac845
PE
3390 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3391 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3392 (x_clipboard_manager_save): Now static.
3393 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3394
f1b54466
PE
3395 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3396 (crypto_hash_function): Now static.
3397 Fix pointer signedness problems. Avoid unnecessary initializations.
3398
a9f737ee
CY
33992011-05-27 Chong Yidong <cyd@stupidchicken.com>
3400
3401 * termhooks.h (Vselection_alist): Make it terminal-local.
3402
3403 * terminal.c (create_terminal): Initialize it.
3404
3405 * xselect.c: Support for clipboard managers.
3406 (Vselection_alist): Move to termhooks.h as terminal-local var.
3407 (LOCAL_SELECTION): New macro.
3408 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3409 (symbol_to_x_atom): Remove gratuitous arg.
3410 (x_handle_selection_request, lisp_data_to_selection_data)
3411 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3412 (x_own_selection, x_get_local_selection, x_convert_selection):
3413 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3414 (some_frame_on_display): Delete unused function.
3415 (Fx_own_selection_internal, Fx_get_selection_internal)
3416 (Fx_disown_selection_internal, Fx_selection_owner_p)
3417 (Fx_selection_exists_p): New optional frame arg.
3418 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3419 (x_handle_selection_clear): Don't treat other terminals with the
3420 same keyboard specially. Use the terminal-local Vselection_alist.
3421 (x_clear_frame_selections): Use Frun_hook_with_args.
3422
3423 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3424
3425 * xterm.h: Add support for those atoms.
3426
e067f0c1
CY
34272011-05-26 Chong Yidong <cyd@stupidchicken.com>
3428
3429 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3430 (converted_selections, conversion_fail_tag): New global variables.
3431 (x_selection_request_lisp_error): Free the above.
3432 (x_get_local_selection): Remove unnecessary code.
3433 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3434 of converted selections stored in converted_selections.
3435 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3436 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3437 (x_convert_selection): New function.
3438 (x_handle_selection_event): Simplify.
3439 (x_get_foreign_selection): Don't ignore incoming requests while
3440 waiting for an answer; this will fail when we implement
3441 SAVE_TARGETS, and seems unnecessary anyway.
3442 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3443 (Vx_sent_selection_functions): Doc fix.
3444
0f4aebc0
LL
34452011-05-26 Leo Liu <sdl.web@gmail.com>
3446
3447 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3448
e61124cd
YM
34492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3450
3451 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3452
3453 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3454 for fringe update if it has periodic bitmap.
ac389d0c 3455 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3456 and fringe_bitmap_periodic_p.
3457
3458 * fringe.c (get_fringe_bitmap_data): New function.
3459 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3460 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3461 row. Mark glyph row for fringe update if periodicity changed.
3462
3463 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3464 for fringe update unless it has periodic bitmap.
3465
f16d9837
KH
34662011-05-25 Kenichi Handa <handa@m17n.org>
3467
3468 * xdisp.c (get_next_display_element): Set correct it->face_id for
3469 a static composition.
3470
e1b90ef6
LL
34712011-05-24 Leo Liu <sdl.web@gmail.com>
3472
3473 * deps.mk (fns.o):
3474 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3475
3476 * fns.c (crypto_hash_function, Fsha1): New function.
3477 (Fmd5): Use crypto_hash_function.
3478 (syms_of_fns): Add Ssha1.
3479
7400048f
PE
34802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 * gnutls.c: Remove unused macros.
3483 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3484 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3485 Remove macros that are defined and never used.
3486 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3487
abb71cf4
CY
34882011-05-22 Chong Yidong <cyd@stupidchicken.com>
3489
3490 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3491 (Fx_get_selection_internal): Minor cleanup.
3492 (Fx_own_selection_internal): Rename arguments for consistency with
3493 select.el.
3494
6307db39
PE
34952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3496
3497 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3498
f3d4e0a4
CY
34992011-05-22 Chong Yidong <cyd@stupidchicken.com>
3500
3501 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3502
4d8ade89
YM
35032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3504
3505 * dispnew.c (scrolling_window): Don't exclude the case that the
3506 last enabled row in the desired matrix touches the bottom boundary.
3507
32078c8d
GM
35082011-05-21 Glenn Morris <rgm@gnu.org>
3509
3510 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3511 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3512 and add some more files.
32078c8d 3513
7285dc67
EZ
35142011-05-20 Eli Zaretskii <eliz@gnu.org>
3515
3516 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3517 report_file_error introduced by the change from 2011-05-07.
3518
89d1bd22
PE
35192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 * systime.h (Time): Define only if emacs is defined.
3522 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3523 where the include path doesn't have X11/X.h by default. See
3524 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3525
e23640bb 35262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3527
3528 * composite.c (find_automatic_composition): Fix previous change.
3529
b9704ad9
GM
35302011-05-20 Glenn Morris <rgm@gnu.org>
3531
3532 * lisp.mk: New file, split from Makefile.in.
3533 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3534 (shortlisp): Remove.
3535 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3536
4a720484
GM
35372011-05-19 Glenn Morris <rgm@gnu.org>
3538
3539 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3540 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3541 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3542 (lisp): Set the order to that of loadup.el.
3543 (shortlisp): Make it a copy of $lisp.
3544 (SOME_MACHINE_LISP): Remove.
3545 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3546 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3547
a28d4396
KH
35482011-05-18 Kenichi Handa <handa@m17n.org>
3549
3550 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3551 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3552 (find_automatic_composition): Mostly rewrite for efficiency.
3553
a2b1fa8e
JB
35542011-05-18 Juanma Barranquero <lekktu@gmail.com>
3555
3556 * makefile.w32-in: Update dependencies.
3557
8e1f5610
CS
35582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3559
3560 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3561 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3562
7025ee00 35632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3564
cdfa6eab
PE
3565 Fix some integer overflow issues, such as string length overflow.
3566
06d6db33
PE
3567 * insdel.c (count_size_as_multibyte): Check for string overflow.
3568
2b4560a8
PE
3569 * character.c (lisp_string_width): Check for string overflow.
3570 Use EMACS_INT, not int, for string indexes and lengths; in
3571 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3572 the resulting string length overflows an EMACS_INT; instead,
3573 report a string overflow if no precision given. When checking for
3574 precision exhaustion, use a check that cannot possibly have
3575 integer overflow. (Bug#8675)
3576 * character.h (lisp_string_width): Adjust to new signature.
3577
cb93f9be
PE
3578 * alloc.c (string_overflow): New function.
3579 (Fmake_string): Use it. This doesn't change behavior, but saves
3580 a few bytes and will simplify future changes.
3581 * character.c (string_escape_byte8): Likewise.
3582 * lisp.h (string_overflow): New decl.
3583
1a1f3366
PE
3584 Fixups, following up to the user-interface timestamp change.
3585 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3586 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3587 * msdos.c (mouse_get_pos): Likewise.
3588 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3589 * w32gui.h (Time): Define by including "systime.h" rather than by
3590 declaring it ourselves. (Bug#8664)
3591
d4e3e4d3
PE
3592 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3593 * image.c (clear_image_cache): Likewise.
3594
f6a24d19
PE
3595 * term.c (term_mouse_position): Don't assume time_t wraparound.
3596
08dc5ae6
PE
3597 Be more systematic about user-interface timestamps.
3598 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3599 and sometimes 'EMACS_UINT', to represent these timestamps.
3600 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3601 This makes the code easier to follow, and makes it easier to catch
3602 integer overflow bugs such as Bug#8664.
3603 * frame.c (Fmouse_position, Fmouse_pixel_position):
3604 Use Time, not unsigned long, for user-interface timestamps.
3605 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3606 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3607 * keyboard.h (last_event_timestamp): Likewise.
3608 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3609 * menu.h (xmenu_show): Likewise.
3610 * term.c (term_mouse_position): Likewise.
3611 * termhooks.h (struct input_event.timestamp): Likewise.
3612 (struct terminal.mouse_position_hook): Likewise.
3613 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3614 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3615 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3616 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3617 what it was before.
3618 * menu.h, termhooks.h: Include "systime.h", for Time.
3619
8e55734a
PE
3620 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3621 Don't assume that the difference between two unsigned long values
3622 can fit into an integer. At this point, we know button_down_time
3623 <= event->timestamp, so the difference must be nonnegative, so
3624 there's no need to cast the result if double-click-time is
3625 nonnegative, as it should be; check that it's nonnegative, just in
3626 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3627 apart (about 25 days). (Bug#8664)
8e55734a 3628
841f1b75 3629 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3630 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3631
3e26f69c
PE
3632 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3633 that always fit in int. Use a sentinel instead of a counter, to
3634 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3635 * frame.h (struct frame): Use int for menu_bar_items_used
3636 instead of EMACS_INT, since it always fits in int.
3e26f69c 3637
5cc152c0
PE
3638 * menu.c (grow_menu_items): Check for int overflow.
3639
d89eb65e
PE
3640 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3641
5235bd3e
PE
3642 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3643 Before, the code was not consistent. These values cannot exceed
3644 2**31 - 1 so there's no need to make them unsigned.
3645 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3646 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3647 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3648 as modifiers.
3649 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3650
bc827e23
PE
3651 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3652 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3653 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3654 presumably because the widths might not match.
3655
78eb494e
PE
3656 * window.c (size_window): Avoid needless test at loop start.
3657
04f2d78b
CB
36582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3659
3660 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3661
d2fc7e3d 36622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3663
3664 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3665
d2fc7e3d 36662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3667
3668 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3669 `width' to `bar_area_x' and `bar_area_width', respectively.
3670 (x_scroll_run): Take account of fringe background extension.
3671
04f2d78b
CB
3672 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3673 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3674 `bar_area_width', respectively.
3675 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3676 background extension.
3677
79b70037
GM
36782011-05-10 Jim Meyering <meyering@redhat.com>
3679
3680 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3681
2f142cc5
JB
36822011-05-10 Juanma Barranquero <lekktu@gmail.com>
3683
3684 * image.c (Finit_image_library): Return t for built-in image types,
3685 like pbm and xbm. (Bug#8640)
3686
57679c86
AS
36872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3688
3689 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3690
888c9e86
EZ
36912011-05-07 Eli Zaretskii <eliz@gnu.org>
3692
b0512a1d
EZ
3693 * w32console.c (Fset_screen_color): Doc fix.
3694 (Fget_screen_color): New function.
3695 (syms_of_ntterm): Defsubr it.
3696
7285dc67
EZ
3697 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3698 unlink the temporary file if Fcall_process didn't create it in the
3699 first place.
3700 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3701 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3702 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3703 cue to call_process_cleanup not to close that handle.
3704
4d3fcc8e
BK
37052011-05-07 Ben Key <bkey76@gmail.com>
3706
3707 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3708 one of two shell specific rules, either bootstrap-temacs-CMD or
3709 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3710 to the previous implementation of the bootstrap-temacs rule.
3711 The bootstrap-temacs-CMD rule is similar to the previous
3712 implementation of the bootstrap-temacs rule except that it
3713 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3714 variable.
3715
3716 These changes, along with some changes to nt/configure.bat,
3717 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3718 earlier fix to add support for --cflags and --ldflags options
3719 that include quotes so that it works whether make uses cmd or
3720 sh as the shell.
3721
b4289b64
MA
37222011-05-06 Michael Albinus <michael.albinus@gmx.de>
3723
3724 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3725 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3726 is a constant.
3727 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3728 a string. Handle both cases.
3729 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3730 (Fdbus_register_method): Use Qinvalid_function.
3731
af4c0e28
JB
37322011-05-06 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * makefile.w32-in: Update dependencies.
3735 (LISP_H): Add inttypes.h and stdin.h.
3736 (PROCESS_H): Add unistd.h.
3737
c51453d9
EZ
37382011-05-06 Eli Zaretskii <eliz@gnu.org>
3739
3740 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3741 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3742
8ff0ac3c 37432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3744
4c4b566b
PE
3745 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3746
aab2b9b5
PE
3747 * term.c (vfatal): Remove stray call to va_end.
3748 It's not needed and the C Standard doesn't allow it here anyway.
3749
c378da0b
PE
3750 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3751 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3752
288b08c7
PE
3753 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3754 bytes.
3755
e3601888
PE
3756 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3757
db6c0e74
PE
3758 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3759
dd5963ea
PE
3760 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3761
88c9450f
PE
3762 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3763
2f9442b8
PE
3764 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3765
c032b5f8
PE
3766 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3767 * charset.c (Fdefine_charset_internal): Don't initialize
3768 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3769 32-bit int (Bug#8600).
a108c10b
PE
3770
3771 * lread.c (read_integer): Be more consistent with string-to-number.
3772 Use string_to_number to do the actual conversion; this avoids
3773 rounding errors and fixes some other screwups. Without this fix,
3774 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3775 (digit_to_number): Move earlier, for benefit of read_integer.
3776 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3777 not a digit in any supported base. (Bug#8602)
a108c10b 3778
ad5f9eea
PE
3779 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3780
aec1708a
PE
3781 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3782 to match comment at start of function. This also removes a
3783 GCC warning about overflow in a 32+64-bit port.
3784
47be4ab5
PE
3785 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3786
371cac43
PE
3787 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3788 Reported by Stefan Monnier in
3789 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3790 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3791 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3792
d01a7826
PE
3793 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3794 (EMACS_UINTPTR): Likewise, with uintptr_t.
3795
7fd47d5c
PE
3796 * lisp.h: Prefer 64-bit EMACS_INT if available.
3797 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3798 on 32-bit hosts that have 64-bit int, so that they can access
3799 large files.
122b0c86
PE
3800 However, temporarily disable this change unless the temporary
3801 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3802
8727937b
PE
3803 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3804
8ac068ac
PE
3805 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3806 This removes an assumption that EMACS_INT and long are the same
3807 width as pointers. The assumption is true for Emacs porting targets
3808 now, but we want to make other targets possible.
3809 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3810 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3811 In the rest of the code, change types of integers that hold casted
3812 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3813 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3814 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3815 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3816 No need to cast type when ORing.
3817 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3818 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3819 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3820 assume EMACS_INT is the same width as char *.
3821 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3822 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3823 Remove no-longer-needed casts.
3824 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3825 (xg_tool_bar_help_callback, xg_make_tool_item):
3826 Use EMACS_INTPTR to hold an integer
3827 that will be cast to void *; this can avoid a GCC warning
3828 if EMACS_INT is not the same width as void *.
3829 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3830 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3831 (current_message_1, set_message_1):
3832 Use a local to convert to proper width without a cast.
3833 * xmenu.c (dialog_selection_callback): Likewise.
3834
ede49d71
PE
3835 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3836 Also, don't assume VALBITS / RAND_BITS is less than 5,
3837 and don't rely on undefined behavior when shifting a 1 left into
3838 the sign bit.
3839 * lisp.h (get_random): Change signature to match.
3840
2f30ecd0
PE
3841 * lread.c (hash_string): Use size_t, not int, for hash computation.
3842 Normally we prefer signed values; but hashing is special, because
3843 it's better to use unsigned division on hash table sizes so that
3844 the remainder is nonnegative. Also, size_t is the natural width
3845 for hashing into memory. The previous code used 'int', which doesn't
3846 retain enough info to hash well into very large tables.
3847 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3848
2a866e7b
PE
3849 * dbusbind.c: Don't possibly lose pointer info when converting.
3850 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3851 Use XPNTR rather than XHASH, so that the high-order bits of
3852 the pointer aren't lost when converting through void *.
3853
51639eac
PE
3854 * eval.c (Fautoload): Don't double-shift a pointer.
3855
92394119
PE
3856 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3857
dbdb9a7c
JB
38582011-05-06 Juanma Barranquero <lekktu@gmail.com>
3859
3860 * gnutls.c (DEF_GNUTLS_FN):
3861 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3862
db7a0b4f
AS
38632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3864
3865 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3866 marker. (Bug#8610)
3867
f7ff1b0f 38682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3869
3870 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3871 New version that can reserve upto 2GB of heap space.
3872
f7ff1b0f 38732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3874
3875 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3876
639c109b
TZ
38772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3878
3879 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3880 `gnutls_certificate_set_x509_key_file'.
3881
d2127135
JB
38822011-05-05 Juanma Barranquero <lekktu@gmail.com>
3883
3884 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3885 Update dependencies.
3886
e968f4f3
JB
38872011-05-04 Juanma Barranquero <lekktu@gmail.com>
3888
3889 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3890 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3891 Remove unused parameter `fildes'.
3892 * process.c (read_process_output, send_process): Don't pass it.
3893
84d358f0
JB
38942011-05-04 Juanma Barranquero <lekktu@gmail.com>
3895
3896 Fix previous change: the library cache is defined in w32.c.
3897 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3898 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3899
0898ca10
JB
39002011-05-04 Juanma Barranquero <lekktu@gmail.com>
3901
3902 Implement dynamic loading of GnuTLS on Windows.
3903
3904 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3905 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3906 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3907 Declare.
3908
3909 * gnutls.c (Qgnutls_dll): Define.
3910 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3911 (gnutls_*): Declare function pointers.
3912 (init_gnutls_functions): New function to initialize function pointers.
3913 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3914 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3915 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3916 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3917 (emacs_gnutls_write, emacs_gnutls_read)
3918 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3919 (Fgnutls_available_p): New function.
3920 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3921 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3922 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3923
3924 * image.c: Include w32.h.
3925 (Vimage_type_cache): Delete.
3926 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3927 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3928 (w32_delayed_load): Move to w32.c.
3929
3930 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3931
3932 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3933 (w32_delayed_load): Move from image.c. When loading a library, record
3934 its filename in the :loaded-from property of the library id.
3935 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3936 Initialize and staticpro them.
3937 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3938
3939 * process.c: Include lisp.h before w32.h, not after.
3940 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3941 instead of gnutls_record_check_pending.
3942
3943 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3944
ff4de4aa
TZ
39452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3946
3947 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3948 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3949 as passed in.
3950
abe95abb
JD
39512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3952
3953 * xterm.c (x_set_frame_alpha): Do not set property on anything
3954 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3955
e16e55d4
JB
39562011-05-02 Juanma Barranquero <lekktu@gmail.com>
3957
3958 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3959
bafcf6a5
JB
39602011-05-02 Juanma Barranquero <lekktu@gmail.com>
3961
3962 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3963 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3964 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3965 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3966 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3967 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3968 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3969 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3970 (Qgnutls_bootprop_callbacks_verify): Make static.
3971
e7a6747f
AS
39722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3973
19ed11ba
AS
3974 * callproc.c: Indentation fixup.
3975
e7a6747f 3976 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3977 (wait_for_termination, interruptible_wait_for_termination):
3978 Move after wait_for_termination_1.
e7a6747f 3979
1ef14cb4
LMI
39802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3981
3982 * sysdep.c (interruptible_wait_for_termination): New function
3983 which is like wait_for_termination, but allows keyboard
3984 interruptions.
3985
3986 * callproc.c (Fcall_process): Add (:file "file") as an option for
3987 the STDOUT buffer.
3988 (Fcall_process_region): Ditto.
3989
330d880c
EZ
39902011-04-30 Eli Zaretskii <eliz@gnu.org>
3991
8db90b73
EZ
3992 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3993 rather than `XVECTOR (FOO)->size'.
3994
330d880c
EZ
3995 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3996 inttypes.h, as a gnulib replacement is used if it not available in
3997 system headers.
3998
15cbd324
EZ
39992011-04-21 Eli Zaretskii <eliz@gnu.org>
4000
4001 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4002 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4003 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4004
4005 * coding.c (coding_alloc_by_realloc): Error out if destination
4006 will grow beyond MOST_POSITIVE_FIXNUM.
4007 (decode_coding_emacs_mule): Abort if there isn't enough place in
4008 charbuf for the composition carryover bytes. Reserve an extra
4009 space for up to 2 characters produced in a loop.
4010 (decode_coding_iso_2022): Abort if there isn't enough place in
4011 charbuf for the composition carryover bytes.
4012
40132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4014
ae940cca
EZ
4015 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4016 aborting when %lld or %lll format is passed.
4017 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4018 %llo or %llx format is passed. (Bug#8545)
4019
03ab8921
EZ
4020 * window.c (window_scroll_line_based): Use a marker instead of
4021 simple variables to record original value of point. (Bug#7952)
4022
afda1437
EZ
4023 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4024 produced by %s or %c overflows available buffer space. (Bug#8545)
4025
f76dee0c
PE
40262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4027
4028 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4029 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4030
fdc5744d
JB
40312011-04-28 Juanma Barranquero <lekktu@gmail.com>
4032
4033 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4034
638f053a
JB
40352011-04-28 Juanma Barranquero <lekktu@gmail.com>
4036
4037 * keyboard.c (Qdelayed_warnings_hook): Define.
4038 (command_loop_1): Run `delayed-warnings-hook'
4039 if Vdelayed_warnings_list is non-nil.
4040 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4041 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4042
d178f871
EZ
40432011-04-28 Eli Zaretskii <eliz@gnu.org>
4044
4045 * doprnt.c (doprnt): Don't return value smaller than the buffer
4046 size if the message was truncated. (Bug#8545).
4047
b124fd93
JB
40482011-04-28 Juanma Barranquero <lekktu@gmail.com>
4049
4050 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4051 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4052
e810457d
PE
40532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4054
4055 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4056
ea51cceb
JB
40572011-04-27 Juanma Barranquero <lekktu@gmail.com>
4058
4059 * makefile.w32-in: Update dependencies.
4060
94dcfacf
EZ
40612011-04-27 Eli Zaretskii <eliz@gnu.org>
4062
4063 Improve `doprnt' and its usage. (Bug#8545)
4064 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4065 `format_end'. Remove support for %l as a conversion specifier.
4066 Don't use xrealloc. Improve diagnostics when the %l size modifier
4067 is used. Update the commentary.
4068
4069 * eval.c (verror): Simplify calculation of size_t.
4070
4071 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4072 messages.
4073
f61f41d7
PE
40742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4075
4076 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4077 change.
4078
96fb4434
PE
40792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4080
4081 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4082 This makes this file independent of the recent pseudovector change.
4083
671875da 40842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4085
69e9b5a3
PE
4086 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4087
b5f869a7 4088 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4089 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4090 Remove unused local.
c8926152 4091 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4092
841a1577 4093 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4094 GCC 4.6.0 optimizes based on type-based alias analysis.
4095 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4096 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4097 != &v->size, and therefore "v->size = 1; b->size = 2; return
4098 v->size;" must therefore return 1. This assumption is incorrect
4099 for Emacs, since it type-puns struct Lisp_Vector * with many other
4100 types. To fix this problem, this patch adds a new type struct
f904488f 4101 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4102 and pseudovectors, and helps optimizing compilers not get fooled
4103 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4104 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4105 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4106 the size member.
eab3844f
PE
4107 (XSETPVECTYPE): Rewrite in terms of new macro.
4108 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4109 This is a bit clearer, and further avoids the possibility of
4110 undesirable aliasing.
4111 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4112 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4113 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4114 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4115 (ASIZE): Now uses header.size rather than size.
4116 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4117 to avoid the hassle of writing XVECTOR (foo)->header.size.
4118 (struct vectorlike_header): New type.
eab3844f
PE
4119 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4120 object, to help avoid aliasing.
4121 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4122 (SUBRP): Likewise, since Lisp_Subr is a special case.
4123 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4124 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4125 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4126 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4127 changed to be "header.size" and "header.next".
4128 * buffer.h (struct buffer): Likewise.
4129 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4130 * frame.h (struct frame): Likewise.
4131 * process.h (struct Lisp_Process): Likewise.
4132 * termhooks.h (struct terminal): Likewise.
4133 * window.c (struct save_window_data, struct saved_window): Likewise.
4134 * window.h (struct window): Likewise.
4135 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4136 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4137 * buffer.c (init_buffer_once): Likewise.
4138 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4139 special case.
4140 * process.c (Fformat_network_address): Use local var for size,
4141 for brevity.
4142
0df1eac5
PE
4143 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4144
847ab9d1 4145 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4146 * data.c (atof): Remove decl; no longer used or needed.
4147 (digit_to_number): Move to lread.c.
4148 (Fstring_to_number): Use new string_to_number function, to be
4149 consistent with how the Lisp reader treats infinities and NaNs.
4150 Do not assume that floating-point numbers represent EMACS_INT
4151 without losing information; this is not true on most 64-bit hosts.
4152 Avoid double-rounding errors, by insisting on integers when
4153 parsing non-base-10 numbers, as the documentation specifies.
4154 * lisp.h (string_to_number): New decl, replacing ...
4155 (isfloat_string): Remove.
bc0a5c13 4156 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4157 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4158 appears to have been a coding error. Similarly, do not accept
4159 strings like +-1e0 as floating point numbers. Do not report
4160 overflow for integer overflows unless the base is not 10 which
4161 means we have no simple and reliable way to continue.
4162 Break out the floating-point parsing into a new
4163 function string_to_number, so that Fstring_to_number parses
4164 floating point numbers consistently with the Lisp reader.
04f2d78b 4165 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4166 (E_CHAR, EXP_INT): Remove, replacing with ...
4167 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4168 (string_to_number): New function, replacing isfloat_string.
4169 This function checks for valid syntax and produces the resulting
4170 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4171 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4172 so that overflow for non-base-10 numbers is reported only when
4173 there's no portable and simple way to convert to floating point.
452f4150 4174
67769ffc
PE
4175 * textprop.c (set_text_properties_1): Rewrite for clarity,
4176 and to avoid GCC warning about integer overflow.
4177
c20db43f
PE
4178 * intervals.h (struct interval): Use EMACS_INT for members
4179 where EMACS_UINT might cause problems. See
4180 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4181 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4182 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4183 All uses changed.
37aa2f85
PE
4184 (offset_intervals): Tell GCC not to worry about length overflow
4185 when negating a negative length.
c20db43f 4186
2538aa2f
PE
4187 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4188 (overrun_check_free): Likewise.
4189
f2d3008d
PE
4190 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4191 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4192 word size.
4193
ec8df744
PE
4194 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4195 (gnutls_make_error): Rename local to avoid shadowing.
4196 (gnutls_emacs_global_deinit): ifdef out; not used.
4197 (Fgnutls_boot): Use const for pointer to readonly storage.
4198 Comment out unused local. Fix pointer signedness problems.
4199
640ee02d
PE
4200 * lread.c (openp): Don't stuff size_t into an 'int'.
4201 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4202 about possible signed overflow.
4203
6048fb2a
PE
4204 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4205 (GDK_KEY_g): Don't define if already defined.
4206 (xg_prepare_tooltip): Avoid pointer signedness problem.
4207 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4208
fa3c87e1
PE
4209 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4210 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4211
2172544b
PE
4212 * xfns.c (Fx_window_property): Simplify a bit,
4213 to make a bit faster and to avoid GCC 4.6.0 warning.
4214 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4215
9b821a21
PE
4216 * fns.c (internal_equal): Don't assume size_t fits in int.
4217
3c616cfa
PE
4218 * alloc.c (compact_small_strings): Tighten assertion a little.
4219
c2982e87
PE
4220 Replace pEd with more-general pI, and fix some printf arg casts.
4221 * lisp.h (pI): New macro, generalizing old pEd macro to other
4222 conversion specifiers. For example, use "...%"pI"d..." rather
4223 than "...%"pEd"...".
4224 (pEd): Remove. All uses replaced with similar uses of pI.
4225 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4226 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4227 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4228 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4229 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4230 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4231 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4232 64-bit hosts.
4233 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4234 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4235 * print.c (safe_debug_print, print_object): Likewise.
4236 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4237 to int.
6f04d126
PE
4238 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4239 avoiding the 0 flag, which is not portable.
c2982e87
PE
4240 * process.c (Fmake_network_process): Use pI to avoid cast.
4241 * region-cache.c (pp_cache): Likewise.
4242 * xdisp.c (decode_mode_spec): Likewise.
4243 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4244 behavior on 64-bit hosts with printf arg.
6f04d126 4245 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4246 (x_stop_queuing_selection_requests): Likewise.
4247 (x_get_window_property): Don't truncate byte count to an 'int'
4248 when tracing.
0b432f21 4249
5e073ec7
PE
4250 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4251 here, since it parses constructs like leading '-' and spaces,
4252 which are not wanted; and it overflows with large numbers.
4253 Instead, simply match F[0-9]+, which is what is wanted anyway.
4254
36372bf9
PE
4255 * alloc.c: Remove unportable assumptions about struct layout.
4256 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4257 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4258 (allocate_vectorlike, make_pure_vector): Use the new macros,
4259 plus offsetof, to remove unportable assumptions about struct layout.
4260 These assumptions hold on all porting targets that I know of, but
4261 they are not guaranteed, they're easy to remove, and removing them
4262 makes further changes easier.
4263
0b432f21
PE
4264 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4265 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4266 (string_overrun_cookie): Now const. Use initializers that
4267 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4268 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4269 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4270 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4271 multiple of sizeof (EMACS_INT); it need not be, if
4272 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4273 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4274
895009e1
JB
42752011-04-26 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4278
6a7a1b0b
TZ
42792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4280
4281 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4282 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4283 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4284
841a1577 42852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4286
4287 * lisp.h (Qdebug): List symbol.
895009e1 4288 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4289 * keyboard.c (debug-on-event): New variable.
4290 (handle_user_signal): Break into debugger when debug-on-event
4291 matches the current signal symbol.
4292
f2d3ba6f
DN
42932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4294
4295 * alloc.c (check_sblock, check_string_bytes)
4296 (check_string_free_list): Convert to standard C.
4297
42ce4c63
TZ
42982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4299
4300 * w32.c (emacs_gnutls_push): Fix typo.
4301
825cd63c
EZ
43022011-04-25 Eli Zaretskii <eliz@gnu.org>
4303
fb11d64d
EZ
4304 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4305 "cast to pointer from integer of different size".
4306
825cd63c
EZ
4307 Improve doprnt and its use in verror. (Bug#8545)
4308 * doprnt.c (doprnt): Document the set of format control sequences
4309 supported by the function. Use SAFE_ALLOCA instead of always
4310 using `alloca'.
4311
4312 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4313 is one byte too soon. Don't use xrealloc; instead xfree and
4314 xmalloc anew.
4315
e061a11b
TZ
43162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4317
4318 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4319 callbacks stage.
4320
4321 * gnutls.c: Renamed global_initialized to
4322 gnutls_global_initialized. Added internals for the
4323 :verify-hostname-error, :verify-error, and :verify-flags
4324 parameters of `gnutls-boot' and documented those parameters in the
4325 docstring. Start callback support.
9173deec
JB
4326 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4327 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4328 on error. Return error code.
e061a11b
TZ
4329 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4330 (emacs_gnutls_read): Likewise.
4331 (Fgnutls_boot): Return handshake error code.
4332 (emacs_gnutls_handle_error): New function.
4333 (wsaerror_to_errno): Likewise.
4334
4335 * w32.h (emacs_gnutls_pull): Add prototype.
4336 (emacs_gnutls_push): Likewise.
4337
4338 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4339 (emacs_gnutls_push): Likewise.
4340
43412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4342
4343 * process.c (wait_reading_process_output): Check if GnuTLS
4344 buffered some data internally if no FDs are set for TLS
4345 connections.
4346
4347 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4348 (LIBS): Link to USER_LIBS.
4349 ($(BLD)/gnutls.$(0)): New target.
4350
fa6996bc
EZ
43512011-04-24 Eli Zaretskii <eliz@gnu.org>
4352
eb35682e
EZ
4353 * xdisp.c (handle_single_display_spec): Rename the
4354 display_replaced_before_p argument into display_replaced_p, to
4355 make it consistent with the commentary. Fix typos in the
4356 commentary.
4357
e2ad650c
EZ
4358 * textprop.c (syms_of_textprop): Remove dead code.
4359 (copy_text_properties): Delete obsolete commentary about an
4360 interface that was deleted long ago. Fix typos in the description
4361 of arguments.
4362
1b2de274
EZ
4363 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4364 to changes in oldXMenu/XMenu.h from 2011-04-16.
4365 <menu_help_message, prev_menu_help_message>: Constify.
4366 (IT_menu_make_room): menu->help_text is now `const char **';
4367 adjust.
4368
4369 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4370 to changes in oldXMenu/XMenu.h from 2011-04-16.
4371 (struct XMenu): Declare `help_text' `const char **'.
4372
4373 * xfaces.c <Qunspecified>: Make extern again.
4374
4375 * syntax.c: Include sys/types.h before including regex.h, as
4376 required by Posix.
4377
762b15be
EZ
4378 * doc.c (get_doc_string): Improve the format passed to `error'.
4379
4380 * doprnt.c (doprnt): Improve commentary.
4381
4382 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4383
4384 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4385 them with etags.
4386
f1052e5d
EZ
4387 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4388 changes in globals.h immediately force recompilation.
762b15be
EZ
4389 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4390 $(CURDIR)/s/ms-w32.h.
4391 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4392
fa6996bc
EZ
4393 * character.c (Fchar_direction): Function deleted.
4394 (syms_of_character): Don't defsubr it.
4395 <char-direction-table>: Deleted.
4396
e6c3da20
EZ
43972011-04-23 Eli Zaretskii <eliz@gnu.org>
4398
4399 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4400 * doprnt.c: Include limits.h.
4401 (SIZE_MAX): New macro.
04f2d78b
CB
4402 (doprnt): Return a size_t value. 2nd arg is now size_t.
4403 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4404 Improve overflow protection. Support `l' modifier for integer
4405 conversions. Support %l conversion. Don't assume an EMACS_INT
4406 argument for integer conversions and for %c.
4407
4408 * lisp.h (doprnt): Restore prototype.
4409
4410 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4411 $(SRC)/character.h.
4412
4413 * Makefile.in (base_obj): Add back doprnt.o.
4414
4415 * deps.mk (doprnt.o): Add back prerequisites.
4416 (callint.o): Depend on character.h.
4417
4418 * eval.c (internal_lisp_condition_case): Include the handler
4419 representation in the error message.
4420 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4421 when breaking from the loop.
4422
4423 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4424
4425 * callint.c (Fcall_interactively): When displaying error message
4426 about invalid control letter, pass the character's codepoint, not
4427 a pointer to its multibyte form. Improve display of the character
4428 in octal and display also its hex code.
4429
4430 * character.c (char_string): Use %x to display the (unsigned)
4431 codepoint of an invalid character, to avoid displaying a bogus
4432 negative value.
4433
4434 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4435 `error', not SYMBOL_NAME itself.
4436
4437 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4438 character arguments to `error'.
4439
4440 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4441 to `error' in error message about FINAL_CHAR argument. Make sure
4442 FINAL_CHAR is a character, and use %c when it is passed as
4443 argument to `error'.
4444
4ffd0d6b 44452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4446
4447 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4448
4449 * w32.c: Include <time.h>.
4450 (sys_localtime): New function.
4451
4ffd0d6b 44522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4453
4454 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4455
4ffd0d6b 4456 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4457
4ffd0d6b 44582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4459
4ffd0d6b
GM
4460 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4461 zombies (Bug#8467).
aac0c6e3 4462
04c56954
EZ
44632011-04-19 Eli Zaretskii <eliz@gnu.org>
4464
4465 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4466 gl_state.e_property when gl_state.object is Qt.
4467
4468 * insdel.c (make_gap_larger): Remove limitation of buffer size
4469 to <= INT_MAX.
4470
16a43933
CY
44712011-04-18 Chong Yidong <cyd@stupidchicken.com>
4472
4473 * xdisp.c (lookup_glyphless_char_display)
4474 (produce_glyphless_glyph): Handle cons cell entry in
4475 glyphless-char-display.
4476 (Vglyphless_char_display): Document it.
4477
4478 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4479 glyphless-char-display.
4480
4581706e
CY
44812011-04-17 Chong Yidong <cyd@stupidchicken.com>
4482
4483 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4484
4485 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4486
4487 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4488 definition for no-X builds.
4489
4887c6e2 44902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4491
fd35b6f9
PE
4492 Static checks with GCC 4.6.0 and non-default toolkits.
4493
5c1ccb01
PE
4494 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4495
006c5daa
PE
4496 * process.c (keyboard_bit_set): Define only if SIGIO.
4497 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4498 (send_process): Repair possible setjmp clobbering.
4499
efc736d3
PE
4500 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4501
4e2fe2e6
PE
4502 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4503
f97334a2
PE
4504 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4505
4e75f29d
PE
4506 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4507 Define only if needed.
4508
90efadd1
PE
4509 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4510 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4511 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4512
3c647824
PE
4513 * dispextern.h (struct redisplay_interface): Rename param
4514 to avoid shadowing.
e264f262 4515 * termhooks.h (struct terminal): Likewise.
761383f4 4516 * xterm.c (xembed_send_message): Likewise.
3c647824 4517
b58c5c4a
PE
4518 * insdel.c (make_gap_smaller): Define only if
4519 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4520
cad59032
PE
4521 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4522 it.
4523
c339dc2e
PE
4524 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4525 so that we aren't warned about unused symbols.
4526
91a3e27b
PE
4527 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4528
399c71d3 4529 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4530
8ffc96f5
PE
4531 * xfns.c (x_real_positions): Mark locals as initialized.
4532
eef9bc79
PE
4533 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4534
098db9dd
PE
4535 * xterm.c: Fix problems found by static analysis with other toolkits.
4536 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4537 (x_dispatch_event): Declare static if USE_GTK, and
4538 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4539 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4540 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4541 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4542 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4543
eb18f6cc
PE
4544 * xmenu.c (menu_help_callback): Pointer type fixes.
4545 Use const pointers when pointing at readonly data. Avoid pointer
4546 signedness clashes.
4547 (FALSE): Remove unused macro.
4548 (update_frame_menubar): Remove unused decl.
4549
1fe72bf8
PE
4550 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4551
60d9e1db
PE
4552 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4553 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4554 (single_menu_item): Rename local to avoid shadowing.
4555
39261c26
PE
4556 * keyboard.c (make_lispy_event): Remove unused local var.
4557
018c5e19
PE
4558 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4559 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4560
63d2b86e
PE
4561 * bitmaps: Change bitmaps from unsigned char back to the X11
4562 compatible char. Avoid the old compiler warnings about
4563 out-of-range initializers by using, for example, '\xab' rather
4564 than 0xab.
4565
aefd87e1
PE
4566 * xgselect.c (xgselect_initialize): Check vs interface
4567 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4568
bf501fb9
PE
4569 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4570
e9829fdf
PE
4571 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4572 to read-only memory.
4573
1086c095
PE
4574 * fns.c (vector): Remove; this old hack is no longer needed.
4575
2baccd04 4576 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4577 Remove unused var.
dde42981 4578 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4579
72391843 4580 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4581
436c16df 4582 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4583 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4584 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4585
92bb796d 4586 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4587 (x_term_init): Remove local to avoid shadowing.
92bb796d 4588
764430a3 4589 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4590
4591 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4592 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4593
d1dfb56c
EZ
45942011-04-16 Eli Zaretskii <eliz@gnu.org>
4595
c4354cb4
EZ
4596 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4597
d1dfb56c
EZ
4598 Fix regex.c, syntax.c and friends for buffers > 2GB.
4599 * syntax.h (struct gl_state_s): Declare character position members
4600 EMACS_INT.
4601
4602 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4603
04f2d78b
CB
4604 * textprop.c (verify_interval_modification, interval_of):
4605 Declare arguments EMACS_INT.
d1dfb56c
EZ
4606
4607 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4608 EMACS_INT.
4609
4610 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4611
4612 * indent.c (Fvertical_motion): Local variable it_start is now
4613 EMACS_INT.
4614
4615 * regex.c (re_match, re_match_2, re_match_2_internal)
4616 (bcmp_translate, regcomp, regexec, print_double_string)
4617 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4618 (re_compile_pattern, re_exec): Declare arguments and local
4619 variables `size_t' and `ssize_t' and return values `regoff_t', as
4620 appropriate.
4621 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4622 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4623 <compile_stack_type>: `size' and `avail' are now `size_t'.
4624
4625 * regex.h <regoff_t>: Use ssize_t, not int.
4626 (re_search, re_search_2, re_match, re_match_2): Arguments that
4627 specify buffer/string position and length are now ssize_t and
4628 size_t. Return type is regoff_t.
4629
613052cd
BK
46302011-04-16 Ben Key <bkey76@gmail.com>
4631
4632 * nsfont.m: Fixed bugs in ns_get_family and
4633 ns_descriptor_to_entity that were caused by using free to
4634 deallocate memory blocks that were allocated by xmalloc (via
4635 xstrdup). This caused Emacs to crash when compiled with
4636 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4637 --enable-checking=xmallocoverrun). xfree is now used to
4638 deallocate these memory blocks.
4639
4170f62f 46402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4641
71b41406
PE
4642 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4643
9587a89d
PE
4644 emacs_write: Accept and return EMACS_INT for sizes.
4645 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4646 et seq.
4647 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4648 Accept and return EMACS_INT.
4649 (emacs_gnutls_write): Return the number of bytes written on
4650 partial writes.
4651 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4652 (emacs_read, emacs_write): Remove check for negative size, as the
4653 Emacs source code has been audited now.
9587a89d
PE
4654 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4655 (emacs_read, emacs_write): Use it.
273a5f82
PE
4656 * process.c (send_process): Adjust to the new signatures of
4657 emacs_write and emacs_gnutls_write. Do not attempt to store
4658 a byte offset into an 'int'; it might overflow.
9587a89d 4659 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4660
3e047f51
PE
4661 * sound.c: Don't assume sizes fit in 'int'.
4662 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4663 Return EMACS_INT, not int.
3e047f51 4664 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4665 Accept EMACS_INT, not int.
4666 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4667 record read return values.
4668
cc39a9db
BK
46692011-04-15 Ben Key <bkey76@gmail.com>
4670
c9d0ec6d
JB
4671 * keyboard.c (Qundefined): Don't declare static since it is used
4672 in nsfns.m.
4673 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4674 static since they are used in nsfont.m.
cc39a9db 4675
6c60eb9f
SM
46762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4677
4678 * process.c (Qprocessp): Don't declare static.
4679 * lisp.h (Qprocessp): Declare again.
4680
7990b61a
JB
46812011-04-15 Juanma Barranquero <lekktu@gmail.com>
4682
4683 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4684
5d4cb038
PE
46852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4686
8bd7b830 4687 Improve C-level modularity by making more things 'static'.
cd64ea1d 4688
e3b27b31
PE
4689 Don't publish debugger-only interfaces to other modules.
4690 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4691 (verify_bytepos, count_markers): Move decls to the only modules
4692 that need them.
4693 * region-cache.h (pp_cache): Likewise.
4694 * window.h (check_all_windows): Likewise.
4695 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4696
5d4cb038
PE
4697 * sysdep.c (croak): Now static, if
4698 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4699 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4700
4701 * alloc.c (refill_memory_reserve): Now static if
4702 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4703 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4704
e87b6180
PE
4705 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4706 Define only if USE_LUCID.
4707
ac64929e
PE
4708 * xrdb.c (x_customization_string, x_rm_string): Now static.
4709
6f37259d
PE
4710 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4711 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4712
1683e3ab
PE
4713 * xdisp.c (draw_row_with_mouse_face): Now static.
4714 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4715
de9c2632
PE
4716 * window.h (check_all_windows): Mark externally visible.
4717
2b96acb7
PE
4718 * window.c (window_deletion_count): Now static.
4719
4720 * undo.c: Make symbols static if they're not exported.
4721 (last_undo_buffer, last_boundary_position, pending_boundary):
4722 Now static.
4723
50436f33
PE
4724 * textprop.c (interval_insert_behind_hooks): Now static.
4725 (interval_insert_in_front_hooks): Likewise.
4726
64520e5c
PE
4727 * term.c: Make symbols static if they're not exported.
4728 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4729 (max_frame_lines, tty_set_terminal_modes):
4730 (tty_reset_terminal_modes, tty_turn_off_highlight):
4731 (get_tty_terminal): Now static.
4732 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4733 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4734 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4735 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4736 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4737
1fa53021
PE
4738 * sysdep.c: Make symbols static if they're not exported.
4739 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4740 Now static.
4741 (sigprocmask_set, full_mask): Remove; unused.
4742 (wait_debugging): Mark as visible.
4743 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4744 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4745
d4b43b22
PE
4746 * syntax.c (syntax_temp): Define only if !__GNUC__.
4747
b7c513d0
PE
4748 * sound.c (current_sound_device, current_sound): Now static.
4749
989b29ad
PE
4750 * search.c (searchbufs, searchbuf_head): Now static.
4751
13a55a78
PE
4752 * scroll.c (scroll_cost): Remove; unused.
4753 * dispextern.h (scroll_cost): Remove decl.
4754
de68a1fc
PE
4755 * region-cache.h (pp_cache): Mark as externally visible.
4756
40ccffa6
PE
4757 * process.c: Make symbols static if they're not exported.
4758 (process_tick, update_tick, create_process, chan_process):
4759 (Vprocess_alist, proc_buffered_char, datagram_access):
4760 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4761 (deactivate_process): Mark defn as static, as well as decl.
4762 * lisp.h (create_process): Remove decl.
4763 * process.h (chan_process, Vprocess_alist): Remove decls.
4764
ad64fc97
PE
4765 * print.c: Make symbols static if they're not exported.
4766 (print_depth, new_backquote_output, being_printed, print_buffer):
4767 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4768 (print_interval, print_number_index, initial_stderr_stream):
4769 Now static.
4770 * lisp.h (Fprinc): Remove decl.
4771 (debug_output_compilation_hack): Mark as externally visible.
4772
adddb265
PE
4773 * sysdep.c (croak): Move decl from here to syssignal.h.
4774 * syssignal.h (croak): Put it here, so the API can be checked when
4775 'croak' is called from dissociate_if_controlling_tty.
4776
1717ede2
PE
4777 * minibuf.c: Make symbols static if they're not exported.
4778 (minibuf_save_list, choose_minibuf_frame): Now static.
4779 * lisp.h (choose_minibuf_frame): Remove decl.
4780
fa5fb2bc
PE
4781 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4782
1e3890d1
PE
4783 * lread.c: Make symbols static if they're not exported.
4784 (read_objects, initial_obarray, oblookup_last_bucket_number):
4785 Now static.
4786 (make_symbol): Remove; unused.
4787 * lisp.h (initial_obarray, make_symbol): Remove decls.
4788
8a1414fa
PE
4789 * keyboard.c: Make symbols static if they're not exported.
4790 (single_kboard, recent_keys_index, total_keys, recent_keys):
4791 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4792 (this_single_command_key_start, echoing, last_auto_save):
4793 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4794 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4795 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4796 (Vlispy_mouse_stem, double_click_count):
4797 Now static.
4798 (force_auto_save_soon): Define only if SIGDANGER.
4799 (ignore_mouse_drag_p): Now static if
4800 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4801 (print_help): Remove; unused.
4802 (stop_character, last_timer_event): Mark as externally visible.
4803 * keyboard.h (ignore_mouse_drag_p): Declare only if
4804 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4805 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4806 * lisp.h (echoing): Remove decl.
4807 (force_auto_save_soon): Declare only if SIGDANGER.
4808 * xdisp.c (redisplay_window): Simplify code, to make it more
4809 obvious that ignore_mouse_drag_p is not accessed if !defined
4810 USE_GTK && !defined HAVE_NS.
4811
93ea6e8f
PE
4812 * intervals.c: Make symbols static if they're not exported.
4813 (merge_properties_sticky, merge_interval_right, delete_interval):
4814 Now static.
4815 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4816
77382fcc
PE
4817 * insdel.c: Make symbols static if they're not exported.
4818 However, leave prepare_to_modify_buffer alone. It's never
4819 called from outside this function, but that appears to be a bug.
4820 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4821 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4822 (adjust_after_replace_noundo): Remove; unused.
4823 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4824 (signal_before_change): Remove decls.
77382fcc 4825
9306c32e
PE
4826 * indent.c (val_compute_motion, val_vmotion): Now static.
4827
cd44d2eb
PE
4828 * image.c: Make symbols static if they're not exported.
4829 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4830 if USE_GTK.
4831 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4832 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4833
ad9a7a06
PE
4834 * fringe.c (standard_bitmaps): Now static.
4835 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4836
81626931
PE
4837 * frame.c: Make symbols static if they're not exported.
4838 (x_report_frame_params, make_terminal_frame): Now static.
4839 (get_frame_param): Now static, unless HAVE_NS.
4840 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4841 (x_get_resource_string): Remove; not used.
4842 * frame.h (make_terminal_frame, x_report_frame_params):
4843 (x_get_resource_string); Remove decls.
4844 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4845 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4846
239f9db9
PE
4847 * font.c, fontset.c: Make symbols static if they're not exported.
4848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4849 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4850 * font.c (font_close_object): Now static.
4851 * font.h (font_close_object): Remove.
4852 * fontset.c (FONTSET_OBJLIST): Remove.
4853 (free_realized_fontset) #if-0 the body, which does nothing.
4854 (face_suitable_for_char_p): #if-0, as it's never called.
4855 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4856 * xfaces.c (face_at_string_position):
4857 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4858 since 0 is always ASCII.
4859
dfcf3579
PE
4860 * fns.c (weak_hash_tables): Now static.
4861
5045092b
PE
4862 * fileio.c: Make symbols static if they're not exported.
4863 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4864 (Vwrite_region_annotation_buffers): Now static.
4865
57a96f5c
PE
4866 * eval.c: Make symbols static if they're not exported.
4867 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4868 * lisp.h (backtrace_list): Remove decl.
4869
35f08c38
PE
4870 * emacs.c: Make symbols static if they're not exported.
4871 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4872 (fatal_error_code, fatal_error_signal_hook, standard_args):
4873 Now static.
4874 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4875 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4876 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4877 * lisp.h (fatal_error_signal_hook): Remove decl.
4878 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4879
f44bd759
PE
4880 * editfns.c: Move a (normally-unused) function to its only use.
4881 * editfns.c, lisp.h (get_operating_system_release): Remove.
4882 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4883 worth the hassle of breaking this out.
4884
b532497d
PE
4885 * xterm.c: Make symbols static if they're not exported.
4886 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4887 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4888 (x_destroy_window, x_delete_display):
4889 Now static.
4890 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4891 (x_mouse_leave): Remove; unused.
4892 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4893 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4894 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4895 Remove decls.
4896 (x_mouse_leave): Declare only if WINDOWSNT.
4897 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4898 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4899 USE_X_TOOLKIT.
4900
1675728f
PE
4901 * ftxfont.c: Make symbols static if they're not exported.
4902 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4903 HAVE_FREETYPE.
4904 * font.h (ftxfont_driver): Likewise.
4905
e4cebfca
PE
4906 * xfns.c: Make symbols static if they're not exported.
4907 (x_last_font_name, x_display_info_for_name):
4908 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4909 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4910 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4911 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4912 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4913 (last_show_tip_args): Now static.
4914 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4915 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4916 (x_screen_planes): Remove; unused.
4917 * dispextern.h (x_screen_planes): Remove decl.
4918
5bf46f05
PE
4919 * dispnew.c: Make symbols static if they're not exported.
4920 * dispextern.h (redraw_garbaged_frames, scrolling):
4921 (increment_row_positions): Remove.
4922 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4923 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4924 Now static.
4925 (redraw_garbaged_frames): Remove; unused.
4926
435f4c28
PE
4927 * xfaces.c: Make symbols static if they're not exported.
4928 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4929 Remove decls.
4930 * xterm.h (defined_color): Remove decls.
4931 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4932 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4933 (menu_face_changed_default, defined_color, free_realized_face):
4934 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4935 (ascii_face_of_lisp_face): Remove; unused.
4936
8524aef3
PE
4937 * xdisp.c: Make symbols static if they're not exported.
4938 * dispextern.h (scratch_glyph_row, window_box_edges):
4939 (glyph_to_pixel_coords, set_cursor_from_row):
4940 (get_next_display_element, set_iterator_to_next):
4941 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4942 (show_mouse_face): Remove decls
4943 * frame.h (message_buf_print): Likewise.
4944 * lisp.h (pop_message, set_message, check_point_in_composition):
4945 Likewise.
4946 * xterm.h (set_vertical_scroll_bar): Likewise.
4947 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4948 (message_buf_print, scratch_glyph_row, displayed_buffer):
4949 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4950 (get_next_display_element, show_mouse_face, window_box_edges):
4951 (frame_to_window_pixel_xy, check_point_in_composition):
4952 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4953 (glyph_to_pixel_coords): Remove; unused.
4954
16390cd2
PE
4955 * dired.c (file_name_completion): Now static.
4956
4957 * dbusbind.c (xd_in_read_queued_messages): Now static.
4958
a25f4dfa
PE
4959 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4960 * data.c (circular_list_error): Remove.
4961
14a9c8df
PE
4962 * commands.h (last_point_position, last_point_position_buffer):
4963 (last_point_position_window): Remove decls.
4964 * keyboard.c: Make these variables static.
4965
04f2d78b
CB
4966 * coding.h (coding, code_convert_region, encode_coding_gap):
4967 Remove decls.
74ab6df5
PE
4968 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4969 (iso_code_class, detect_coding, code_convert_region): Now static.
4970 (encode_coding_gap): Remove; unused.
4971
38dfbee1
PE
4972 * chartab.c (chartab_chars, chartab_bits): Now static.
4973
a2cb4e63
PE
4974 * charset.h (charset_iso_8859_1): Remove decl.
4975 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4976 Now static.
4977
127198fd
PE
4978 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4979 * ccl.c (Vccl_program_table): Now static.
4980 (check_ccl_update): Remove; unused.
4981
d85b608f
PE
4982 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4983 * category.h: ... from here.
4984 * category.c (check_category_table, set_category_set): Now static.
4985
31cd66f3
PE
4986 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4987 * lisp.h: Remove these decls.
4988
c358e587
PE
4989 * buffer.c (buffer_count): Remove unused var.
4990
e78aecca
PE
4991 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4992 so that it's not optimized away.
4993 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4994 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4995 exported only to the debugger.
4996
e192d7d3 4997 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4998 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4999
92470028
PE
5000 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5001 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5002 was inaccessible from Lisp.
5003 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5004 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5005
244ed907
PE
5006 alloc.c: Import and export fewer symbols, and remove unused items.
5007 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5008 is defined.
5009 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5010 it's not optimized away by whole-program optimization.
5011 (message_enable_multibyte, free_misc): Remove.
5012 (catchlist, handlerlist, mark_backtrace):
5013 Declare only if BYTE_MARK_STACK.
5014 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5015 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5016 (message_enable_multibyte): Remove decl.
5017 (free_misc, interval_free_list, float_block, float_block_index):
5018 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5019 (cons_free_list, last_marked_index):
5020 Now static.
5021 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5022 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5023 (mark_backtrace): Define only if BYTE_MARK_STACK.
5024 * xdisp.c (message_enable_multibyte): Now static.
5025
61c2b50e 5026 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5027 This makes it easier for human readers (and static analyzers)
5028 to see whether these variables are used from other modules.
5029 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5030 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5031 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5032 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5033 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5034 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5035 * xmenu.c, xselect.c:
5036 Declare Q* vars static if they are not used in other modules.
5037 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5038 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5039 Remove decls of unexported vars.
5040 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5041
95c82688
PE
5042 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5043
16a97296
PE
5044 Make Emacs functions such as Fatom 'static' by default.
5045 This makes it easier for human readers (and static analyzers)
5046 to see whether these functions can be called from other modules.
5047 DEFUN now defines a static function. To make the function external
5048 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5049 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5050 (Finit_image_library):
16a97296
PE
5051 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5052 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5053 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5054 Remove decls, since these functions are now static.
5055 (Funintern, Fget_internal_run_time): New decls, since these functions
5056 were already external.
95c82688 5057
16a97296
PE
5058 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5059 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5060 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5061 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5062 * keyboard.c, keymap.c, lread.c:
5063 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5064 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5065 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5066 Mark functions with DEFUE instead of DEFUN,
5067 if they are used in other modules.
5068 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5069 decls for now-static functions.
5070 * buffer.h (Fdelete_overlay): Remove decl.
5071 * callproc.c (Fgetenv_internal): Mark as internal.
5072 * composite.c (Fremove_list_of_text_properties): Remove decl.
5073 (Fcomposition_get_gstring): New forward static decl.
5074 * composite.h (Fcomposite_get_gstring): Remove decl.
5075 * dired.c (Ffile_attributes): New forward static decl.
5076 * doc.c (Fdocumntation_property): New forward static decl.
5077 * eval.c (Ffetch_bytecode): New forward static decl.
5078 (Funintern): Remove extern decl; now in .h file where it belongs.
5079 * fileio.c (Fmake_symbolic_link): New forward static decl.
5080 * image.c (Finit_image_library): New forward static decl.
5081 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5082 * intervals.h (Fprevious_property_change):
5083 (Fremove_list_of_text_properties): Remove decls.
5084 * keyboard.c (Fthis_command_keys): Remove decl.
5085 (Fcommand_execute): New forward static decl.
5086 * keymap.c (Flookup_key): New forward static decl.
5087 (Fcopy_keymap): Now static.
5088 * keymap.h (Flookup_key): Remove decl.
5089 * process.c (Fget_process): New forward static decl.
5090 (Fprocess_datagram_address): Mark as internal.
5091 * syntax.c (Fsyntax_table_p): New forward static decl.
5092 (skip_chars): Remove duplicate decl.
5093 * textprop.c (Fprevious_property_change): New forward static decl.
5094 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5095 Now internal.
5096 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5097 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5098
785bbd42
PE
5099 * editfns.c (Fformat): Remove unreachable code.
5100
8b913b57
AS
51012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5102
5103 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5104 change. (Bug#8496)
5105
a6744a35
EZ
51062011-04-13 Eli Zaretskii <eliz@gnu.org>
5107
5108 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5109 when at ZV. (Bug#8487)
5110
e7974947
AS
51112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5112
baad03f0
AS
5113 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5114 (Bug#8437)
5115 * keyboard.c (parse_tool_bar_item): Likewise.
5116 * sound.c (sound_cleanup, alsa_close): Likewise.
5117 * termcap.c (tgetent): Likewise.
5118 * xfns.c (x_default_font_parameter): Likewise.
5119 * xsettings.c (read_and_apply_settings): Likewise.
5120
e7974947
AS
5121 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5122 (overrun_check_free): Protoize.
5123
28272684
PE
51242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5125
5126 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5127 since callers should never pass a negative size.
5128 Change the signature to match that of plain 'read' and 'write'; see
5129 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5130 * lisp.h: Update prototypes of emacs_write and emacs_read.
5131
11997c76
EZ
51322011-04-11 Eli Zaretskii <eliz@gnu.org>
5133
5134 * xdisp.c (redisplay_window): Don't try to determine the character
5135 position of the scroll margin if the window start point w->startp
e896f03c 5136 is outside the buffer's accessible region. (Bug#8468)
11997c76 5137
8a2cbd72
EZ
51382011-04-10 Eli Zaretskii <eliz@gnu.org>
5139
5140 Fix write-region and its subroutines for buffers > 2GB.
5141 * fileio.c (a_write, e_write): Modify declaration of arguments and
5142 local variables to support buffers larger than 2GB.
5143 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5144
5145 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5146 argument, local variables, and return value.
5147
5148 * lisp.h: Update prototypes of emacs_write and emacs_read.
5149
5150 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5151
4073e537 51522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5153
1ebfdcb6
PE
5154 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5155
b2ded58d
PE
5156 Fix more problems found by GCC 4.6.0's static checks.
5157
7d66342c
PE
5158 * xdisp.c (vmessage): Use a better test for character truncation.
5159
bbf47d44
PE
5160 * charset.c (load_charset_map): <, not <=, for optimization,
5161 and to avoid potential problems with integer overflow.
9248994d 5162 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5163 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5164 * editfns.c (Fformat): Likewise.
1e69125e 5165 * syntax.c (skip_chars): Likewise.
3befa583 5166
e3019616
PE
5167 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5168 This also lets GCC 4.6.0 generate slightly better loop code.
5169
becfa255
PE
5170 * callint.c (Fcall_interactively): <, not <=, for optimization.
5171 (Fcall_interactively): Count the number of arguments produced,
5172 not the number of arguments given. This is simpler and lets GCC
5173 4.6.0 generate slightly better code.
5174
dae0cd48
PE
5175 * ftfont.c: Distingish more carefully between FcChar8 and char.
5176 The previous code passed unsigned char * to a functions like
5177 strlen and xstrcasecmp that expect char *, which does not
5178 conform to the C standard.
5179 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5180 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5181 char * when the C standard requires it.
5182
76032d70
PE
5183 * keyboard.c (read_char): Remove unused var.
5184
eb3f1cc8
PE
5185 * eval.c: Port to Windows vsnprintf (Bug#8435).
5186 Include <limits.h>.
5187 (SIZE_MAX): Define if the headers do not.
5188 (verror): Do not give up if vsnprintf returns a negative count.
5189 Instead, grow the buffer. This ports to Windows vsnprintf, which
5190 does not conform to C99. Problem reported by Eli Zaretskii.
5191 Also, simplify the allocation scheme, by avoiding the need for
5192 calling realloc, and removing the ALLOCATED variable.
5193
70476b54
PE
5194 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5195
12020a9e
PE
5196 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5197 But keep the doprint source code for now, as we might revamp it
5198 and use it again (Bug#8435).
ea6c7ae6
PE
5199 * lisp.h (doprnt): Remove.
5200 * Makefile.in (base_obj): Remove doprnt.o.
5201 * deps.mk (doprnt.o): Remove.
5202
5fdb398c
PE
5203 error: Print 32- and 64-bit integers portably (Bug#8435).
5204 Without this change, on typical 64-bit hosts error ("...%d...", N)
5205 was used to print both 32- and 64-bit integers N, which relied on
5206 undefined behavior.
5207 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5208 New macro.
5209 * lisp.h (error, verror): Mark as printf-like functions.
5210 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5211 Report overflow in size calculations when allocating printf buffer.
5212 Do not truncate output string at its first null byte.
5213 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5214 Truncate the output at a character boundary, since vsnprintf does not
5215 do that.
5216 * charset.c (check_iso_charset_parameter): Convert internal
5217 character to string before calling 'error', since %c now has the
5218 printf meaning.
5219 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5220 overflow when computing char to be passed to 'error'. Do not
5221 pass Lisp_Object to 'error'; pass the integer instead.
5222 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5223 formatted with plain %d.
5224
b189fa66
PE
5225 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5226
bff87ef0
PE
5227 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5228
7e2cac20
PE
5229 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5230
ce4d90b5
PE
5231 * xterm.c (x_catch_errors): Remove duplicate declaration.
5232
266c9547
PE
5233 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5234
79c49ad2
PE
5235 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5236
368f4090
JM
52372011-04-10 Jim Meyering <meyering@redhat.com>
5238
5239 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5240 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5241 return ssize_t not "int", and use size_t as the buffer length.
5242 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5243 * gnutls.h: Update declarations.
5244 * process.c (read_process_output): Use ssize_t, to match.
5245 (send_process): Likewise.
5246
a32d4040
CY
52472011-04-09 Chong Yidong <cyd@stupidchicken.com>
5248
5249 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5250
8546720e 52512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5252
04f2d78b
CB
5253 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5254 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5255
8546720e
GM
5256 * xterm.c (handle_one_xevent):
5257 * xmenu.c (create_and_show_popup_menu):
5258 * xselect.c (x_decline_selection_request)
5259 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5260
0a2f5c1a 52612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5262
5263 Fix some uses of `int' instead of EMACS_INT.
5264 * search.c (string_match_1, fast_string_match)
5265 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5266 (scan_buffer, find_next_newline_no_quit)
5267 (find_before_next_newline, search_command, Freplace_match)
5268 (Fmatch_data): Make some `int' variables be EMACS_INT.
5269
5270 * xdisp.c (display_count_lines): 3rd argument and return value now
5271 EMACS_INT. All callers changed.
5272 (pint2hrstr): Last argument is now EMACS_INT.
5273
5274 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5275 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5276 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5277 (decode_coding_utf_16, decode_coding_emacs_mule)
5278 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5279 (decode_coding_ccl, decode_coding_charset)
5280 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5281 (decode_coding_iso_2022, decode_coding_emacs_mule)
5282 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5283 <char_offset, last_offset>: Declare EMACS_INT.
5284 (encode_coding_utf_8, encode_coding_utf_16)
5285 (encode_coding_emacs_mule, encode_invocation_designation)
5286 (encode_designation_at_bol, encode_coding_iso_2022)
5287 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5288 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5289 Declare EMACS_INT.
5290 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5291 (encode_invocation_designation): Last argument P_NCHARS is now
5292 EMACS_INT.
5293 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5294 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5295
5296 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5297 All users changed.
5298
5299 * ccl.c (Fccl_execute_on_string): Declare some variables
5300 EMACS_INT.
5301
8546720e 53022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5303
5304 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5305
4e19a977
CS
53062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5307
5308 * process.c (Fformat_network_address): Doc fix.
5309
87302331
R
53102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5311
5312 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5313
cbb59342
CY
53142011-04-08 Chong Yidong <cyd@stupidchicken.com>
5315
5316 * keyboard.c (read_char): Call Lisp function help-form-show,
5317 instead of using internal_with_output_to_temp_buffer.
5318 (Qhelp_form_show): New var.
e0d38eeb 5319 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5320
5321 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5322
5323 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5324
e67a13ab
CY
53252011-04-06 Chong Yidong <cyd@stupidchicken.com>
5326
04f2d78b
CB
5327 * process.c (Flist_processes): Remove to Lisp.
5328 (list_processes_1): Delete.
e67a13ab 5329
973f782d
EZ
53302011-04-06 Eli Zaretskii <eliz@gnu.org>
5331
7c106b1e
EZ
5332 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5333
973f782d
EZ
5334 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5335
41cf7d1a 53362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5337
ca23cc88
PE
5338 Fix more problems found by GCC 4.6.0's static checks.
5339
f390e2d5
PE
5340 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5341
42eea0d0
PE
5342 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5343
b69769da 5344 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5345
f9541e84
PE
5346 * xdisp.c (vmessage): Mark as a printf-like function.
5347
13841b55
PE
5348 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5349
c136c10f
PE
5350 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5351
5e2d4a30
PE
5352 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5353 printf-like functions.
5354 (tiff_load): Add casts to remove these marks before passing them
5355 to system-supplied API.
5356
583f48b9
PE
5357 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5358
b25d760e
PE
5359 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5360 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5361 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5362 directly, rather than having caller test rule sign. This avoids
5363 some unnecessary tests.
5364 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5365 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5366 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5367
bc7b6697 5368 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5369 (xfont_open): Avoid unnecessary tests.
bc7b6697 5370
27ccc379
PE
5371 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5372
dcd5c89a
PE
5373 * composite.h, composite.c (composition_gstring_put_cache):
5374 Use EMACS_INT, not int, for length.
5375
b13a45c6
PE
5376 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5377 breaking out part of COMPOSITION_DECODE_RULE.
5378 (COMPOSITION_DECODE_RULE): Use it.
5379 * composite.c (get_composition_id): Remove unused local vars,
5380 by using the new macro.
5381
1e792e4d
PE
5382 * textprop.c (set_text_properties_1): Change while to do-while,
5383 since the condition is always true at first.
5384
dc6c6455 5385 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5386 (interval_deletion_adjustment): Return unsigned value.
5387 All uses changed.
dc6c6455 5388
aba7731a
PE
5389 * process.c (list_processes_1, create_pty, read_process_output):
5390 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5391 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5392 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5393 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5394 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5395
fdfc4bf3
PE
5396 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5397
fca8fe46 5398 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5399 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5400
06a0259a 5401 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5402 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5403 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5404
e7b9e80f
PE
5405 * print.c (print_error_message): Avoid int overflow.
5406
56201685
PE
5407 * font.c (font_list_entities): Redo for clarity,
5408 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5409
78834453 5410 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5411 (font_score): Avoid potential overflow in diff calculation.
78834453 5412
0bc0b309 5413 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5414 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5415
e610eaca
PE
5416 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5417
b895abce
PE
5418 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5419 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5420 can always succeed if overflow has undefined behavior.
5421
1f1d9321 5422 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5423 (wordify): Omit three unnecessary tests.
1f1d9321 5424
c59478bc
PE
5425 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5426 All callers changed. This avoids the need for an unused var.
5427
79b73827
PE
5428 * casefiddle.c (casify_region): Remove var that is set but not used.
5429
a4db5dfe
PE
5430 * dired.c (file_name_completion): Remove var that is set but not used.
5431
43aae36e
PE
5432 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5433
2a47c44d 5434 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5435 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5436
a37c69bf
PE
5437 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5438 Check for integer overflow on size calculations.
5439
328ab8e7
PE
5440 * buffer.c (Fprevious_overlay_change): Remove var that is set
5441 but not used.
5442
e5a2a5cb
PE
5443 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5444 Remove vars that are set but not used.
8d84a6eb 5445 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5446 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5447
a60e5f68
PE
5448 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5449
f661cb61 5450 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5451 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5452
f0397f5a
PE
5453 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5454 that are set but not used.
5455
8664db06 5456 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5457 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5458
6abdaa4a
PE
5459 * xselect.c (x_get_local_selection, x_handle_property_notify):
5460 Remove vars that are set but not used.
5461
0ce7538d 5462 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5463 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5464
9ae848fc
PE
5465 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5466 Remove var that is set but not used.
0b918413
PE
5467 (scroll_bar_windows_size): Now size_t, not int.
5468 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5469 Check for overflow.
9ae848fc 5470
a5a62657
PE
5471 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5472 (map_tty_color) [!defined MSDOS]: Likewise.
5473
5c5cdd39
PE
5474 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5475
66ebf983
PE
5476 * coding.c: Remove vars that are set but not used.
5477 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5478 All callers changed.
5479 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5480 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5481 (decode_coding_charset): Remove vars that are set but not used.
5482
1be4d761
PE
5483 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5484 that is set but not used.
5485
47553fa8
PE
5486 * print.c (print_object): Remove var that is set but not used.
5487
1f7196bf 5488 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5489 The gnulib version avoids calling malloc in the usual case,
5490 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5491 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5492 * filelock.c (current_lock_owner): Likewise.
5493 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5494 * sysdep.c: Include allocator.h, careadlinkat.h.
5495 (emacs_no_realloc_allocator): New static constant.
5496 (emacs_readlink): New function.
fdb61804
PE
5497 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5498 ../lib/careadlinkat.h.
d1fdcab7 5499
f84c17c7
SM
55002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5501
5502 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5503 first non-nil return value).
5504
ef3862ad
JD
55052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5506
5507 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5508 if not defined (Bug#8403).
5509
376a7006
JB
55102011-04-02 Juanma Barranquero <lekktu@gmail.com>
5511
5512 * xdisp.c (display_count_lines): Remove parameter `start',
5513 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5514 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5515 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5516 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5517 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5518 and thereabouts. All callers changed.
5519 (get_per_char_metric): Remove parameter `f', unused since
5520 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5521
6ca3801d
JM
55222011-04-02 Jim Meyering <meyering@redhat.com>
5523
5524 do not dereference NULL upon failed strdup
5525 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5526 (ns_get_family): Likewise.
5527
d8e2b5ba
JB
55282011-04-02 Juanma Barranquero <lekktu@gmail.com>
5529
5530 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5531
8c74fcbd
JD
55322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5533
5534 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5535 later (Bug#8403).
5536
7200d79c
SM
55372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5538
03408648 5539 Add lexical binding.
7200d79c 5540
03408648
SM
5541 * window.c (Ftemp_output_buffer_show): New fun.
5542 (Fsave_window_excursion):
5543 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5544
5545 * lread.c (lisp_file_lexically_bound_p): New function.
5546 (Fload): Bind Qlexical_binding.
5547 (readevalloop): Remove `evalfun' arg.
5548 Bind Qinternal_interpreter_environment.
5549 (Feval_buffer): Bind Qlexical_binding.
5550 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5551 Mark as dynamic.
5552 (syms_of_lread): Declare `lexical-binding'.
5553
5554 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5555
5556 * keyboard.c (eval_dyn): New fun.
5557 (menu_item_eval_property): Use it.
ca105506
SM
5558
5559 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5560
03408648
SM
5561 * fns.c (concat, mapcar1): Accept byte-code-functions.
5562
5563 * eval.c (Fsetq): Handle lexical vars.
5564 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5565 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5566 (FletX, Flet): Obey lexical binding.
5567 (Fcommandp): Handle closures.
5568 (Feval): New `lexical' arg.
5569 (eval_sub): New function extracted from Feval. Use it almost
5570 everywhere where Feval was used. Look up vars in lexical env.
5571 Handle closures.
5572 (Ffunctionp): Move from subr.el.
5573 (Ffuncall): Handle closures.
5574 (apply_lambda): Remove `eval_flags'.
5575 (funcall_lambda): Handle closures and new byte-code-functions.
5576 (Fspecial_variable_p): New function.
5577 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5578 but without exporting it to Lisp.
23aba0ea 5579
23aba0ea 5580 * doc.c (Fdocumentation, store_function_docstring):
03408648 5581 * data.c (Finteractive_form): Handle closures.
23aba0ea 5582
03408648
SM
5583 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5584 interactive spec.
ba83908c 5585
04f2d78b
CB
5586 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5587 New byte-codes.
03408648
SM
5588 (exec_byte_code): New function extracted from Fbyte_code to handle new
5589 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5590
03408648 5591 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5592
03408648 5593 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5594
e2abce01
JB
55952011-03-31 Juanma Barranquero <lekktu@gmail.com>
5596
5597 * xdisp.c (redisplay_internal): Fix prototype.
5598
63696a73 55992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5600
63696a73 5601 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5602 (try_scrolling): Use it when setting scroll_limit.
5603 Limit scrolling to 100 screen lines.
63696a73
EZ
5604 (redisplay_window): Even when falling back on "recentering",
5605 position point in the window according to scroll-conservatively,
5606 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5607
5608 (try_scrolling): When point is above the window, allow searching
5609 as far as scroll_max, or one screenful, to compute vertical
5610 distance from PT to the scroll margin position. This prevents
5611 try_scrolling from unnecessarily failing when
5612 scroll-conservatively is set to a value slightly larger than the
5613 window height. Clean up the case of PT below the margin at bottom
5614 of window: scroll_max can no longer be INT_MAX. When aggressive
5615 scrolling is in use, don't let point enter the opposite scroll
5616 margin as result of the scroll.
5617 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5618 threshold of 100 lines for never-recentering scrolling.
5619
e4cc2dfc
JB
56202011-03-31 Juanma Barranquero <lekktu@gmail.com>
5621
5622 * dispextern.h (move_it_by_lines):
5623 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5624 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5625 (message_log_check_duplicate): Remove parameters `prev_bol' and
5626 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5627 (redisplay_internal): Remove parameter `preserve_echo_area',
5628 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5629
5630 * indent.c (Fvertical_motion):
5631 * window.c (window_scroll_pixel_based, Frecenter):
5632 Don't pass `need_y_p' to `move_it_by_lines'.
5633
1c470562
SM
56342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5635
44f230aa
SM
5636 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5637 steal a few bits to be more compact.
5638 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5639 Remove unneeded casts.
5640
1c470562
SM
5641 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5642
888adce9
ZK
56432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5644
5645 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5646 binding" message (bug#7967).
5647
f838ed7b
PE
56482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5649
77861b95
PE
5650 Fix more problems found by GCC 4.6.0's static checks.
5651
de6dbc14
PE
5652 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5653 Remove unused local var.
5654
f838ed7b
PE
5655 * editfns.c (Fmessage_box): Remove unused local var.
5656
792c7b2b
PE
5657 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5658 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5659 Omit unused local vars.
c499e557 5660 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5661 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5662 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5663 Omit unused local var.
5664
ba0165e1
PE
5665 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5666 Don't assume string length fits in int.
32ad8845 5667 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5668 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5669
3c59b4c9
PE
5670 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5671 instead of alloca (Bug#8344).
5672
a3eed478 5673 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5674 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5675
eb4d412d
PE
5676 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5677
1658b401
PE
5678 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5679 concerns.
5680
5681 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5682
5683 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5684
9a2c6e05
PE
5685 * keyboard.c (syms_of_keyboard): Use the same style as later
5686 in this function when indexing through an array. This also
5687 works around GCC bug 48267.
5688
03d0a109
PE
5689 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5690
44f730c8
PE
5691 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5692
fe75f926
PE
5693 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5694 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5695
ffa8c828
PE
5696 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5697 This avoids undefined behavior on integer overflow, and is a bit
5698 more convenient anyway since it is compared to a size_t variable.
5699
c5101a77
PE
5700 Variadic C functions now count arguments with size_t, not int.
5701 This avoids an unnecessary limitation on 64-bit machines, which
5702 caused (substring ...) to crash on large vectors (Bug#8344).
5703 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5704 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5705 All variadic functions and their callers changed accordingly.
c5101a77
PE
5706 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5707 * data.c (arith_driver, float_arith_driver): Likewise.
5708 * editfns.c (general_insert_function): Likewise.
5709 * eval.c (struct backtrace.nargs, interactive_p)
5710 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5711 (funcall_lambda, mark_backtrace): Likewise.
5712 * fns.c (concat): Likewise.
5713 * frame.c (x_set_frame_parameters): Likewise.
5714 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5715 0 if not found, not -1. All callers changed.
5716
dd3f25f7
PE
5717 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5718 (stack_copy_size): Now size_t, not int.
5719 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5720
461c2ab9
JB
57212011-03-28 Juanma Barranquero <lekktu@gmail.com>
5722
5723 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5724 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5725 All callers changed.
5726
5727 * lisp.h (multibyte_char_to_unibyte):
5728 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5729 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5730 * character.h (CHAR_TO_BYTE8):
5731 * cmds.c (internal_self_insert):
5732 * editfns.c (general_insert_function):
5733 * keymap.c (push_key_description):
5734 * search.c (Freplace_match):
5735 * xdisp.c (message_dolog, set_message_1): All callers changed.
5736
f6d62986
SM
57372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5738
5739 * keyboard.c (safe_run_hook_funcall): New function.
5740 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5741 don't set the hook to nil, but remove the offending function instead.
5742 (Qcommand_hook_internal): Remove, unused.
5743 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5744 Vcommand_hook_internal.
5745
5746 * eval.c (enum run_hooks_condition): Remove.
5747 (funcall_nil, funcall_not): New functions.
5748 (run_hook_with_args): Call each function through a `funcall' argument.
5749 Remove `cond' argument, now redundant.
5750 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5751 (Frun_hook_with_args_until_failure): Adjust accordingly.
5752 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5753
1db5b1ad
JB
57542011-03-28 Juanma Barranquero <lekktu@gmail.com>
5755
5756 * dispextern.h (string_buffer_position): Remove declaration.
5757
5758 * print.c (strout): Remove parameter `multibyte', unused since
5759 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5760
5761 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5762 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5763 All callers changed.
5764
5765 * w32.c (_wsa_errlist): Use braces for struct initializers.
5766
5767 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5768 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5769 All callers changed.
5770 (string_buffer_position): Likewise. Also, make static (it's never
5771 used outside xdisp.c).
5772 (cursor_row_p): Remove parameter `w', unused since
5773 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5774 (decode_mode_spec): Remove parameter `precision', introduced during
5775 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5776 All callers changed.
5777
5ffb62aa
JD
57782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5779
5780 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5781
461c2ab9 57822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5783
5784 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5785 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5786 (ns_update_auto_hide_menu_bar): New functions.
5787 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5788 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5789 ns_constrain_all_frames.
5790 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5791 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5792
5c380ffb
JD
57932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5794
5795 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5796
9af30bdf
GM
57972011-03-27 Glenn Morris <rgm@gnu.org>
5798
5799 * syssignal.h: Replace RETSIGTYPE with void.
5800 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5801 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5802 Replace SIGTYPE with void everywhere.
5803 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5804 * s/template.h (SIGTYPE): Remove commented out definition.
5805
e2abce01
JB
58062011-03-26 Eli Zaretskii <eliz@gnu.org>
5807
5808 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5809 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5810
f868cd8a
JB
58112011-03-26 Juanma Barranquero <lekktu@gmail.com>
5812
59eb0929
JB
5813 * w32.c (read_unc_volume): Use parameter `henum', instead of
5814 global variable `wget_enum_handle'.
5815
5816 * keymap.c (describe_vector): Remove parameters `indices' and
5817 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5818 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5819
f868cd8a
JB
5820 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5821
5822 * keyboard.c (timer_check): Remove parameter `do_it_now',
5823 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5824 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5825 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5826
5827 * keyboard.c (read_char):
5828 * w32menu.c (w32_menu_display_help):
5829 * xmenu.c (show_help_event, menu_help_callback):
5830 Adjust calls to `show_help_echo'.
5831
5832 * gtkutil.c (xg_maybe_add_timer):
5833 * keyboard.c (readable_events):
5834 * process.c (wait_reading_process_output):
5835 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5836
5837 * insdel.c (adjust_markers_gap_motion):
5838 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5839 (gap_left, gap_right): Don't call it.
5840
2ecf6fdb
CY
58412011-03-25 Chong Yidong <cyd@stupidchicken.com>
5842
5843 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5844 incurred during fontification.
5845
6b1f9ba4
JB
58462011-03-25 Juanma Barranquero <lekktu@gmail.com>
5847
5848 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5849 (DEFVAR_PER_BUFFER): Don't pass it.
5850
5851 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5852 (scrolling_window): Don't pass it.
5853
0f4a96b5
JB
58542011-03-25 Juanma Barranquero <lekktu@gmail.com>
5855
5856 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5857
5858 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5859 and `suffix'.
5860 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5861 of variables specific to SELinux and computation of `encoded_absname'.
5862
5863 * image.c (XPutPixel): Remove unused variable `height'.
5864
5865 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5866
5867 * unexw32.c (get_section_info): Remove unused variable `section'.
5868
5869 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5870 (system_process_attributes): Remove unused variable `sess'.
5871 (sys_read): Remove unused variable `err'.
5872
5873 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5874 (w32_wnd_proc): Remove unused variable `isdead'.
5875 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5876 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5877 (x_create_tip_frame): Remove unused variable `tem'.
5878
5879 * w32inevt.c (w32_console_read_socket):
5880 Remove unused variable `no_events'.
5881
5882 * w32term.c (x_draw_composite_glyph_string_foreground):
5883 Remove unused variable `width'.
5884
1149507c
JB
58852011-03-24 Juanma Barranquero <lekktu@gmail.com>
5886
5887 * w32term.c (x_set_glyph_string_clipping):
5888 Don't pass uninitialized region to CombineRgn.
5889
9c88f339
JB
58902011-03-23 Juanma Barranquero <lekktu@gmail.com>
5891
5892 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5893 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5894 (Fx_close_connection): Remove unused variable `i'.
5895
5896 * w32font.c (w32font_draw): Return number of glyphs.
5897 (w32font_open_internal): Remove unused variable `i'.
5898 (w32font_driver): Add missing initializer.
5899
5900 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5901 (fill_in_menu): Remove unused variable `items_added'.
5902
5903 * w32term.c (last_mouse_press_frame): Remove static global variable.
5904 (w32_clip_to_row): Remove unused variable `f'.
5905 (x_delete_terminal): Remove unused variable `i'.
5906
5907 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5908 (NOTHING): Remove unused static global variable.
5909 (uniscribe_check_otf): Remove unused variable `table'.
5910 (uniscribe_font_driver): Add missing initializers.
5911
dee091a3
JD
59122011-03-23 Julien Danjou <julien@danjou.info>
5913
5914 * term.c (Fsuspend_tty, Fresume_tty):
5915 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5916 * window.c (temp_output_buffer_show):
5917 * insdel.c (signal_before_change):
5918 * frame.c (Fhandle_switch_frame):
5919 * fileio.c (Fdo_auto_save):
5920 * emacs.c (Fkill_emacs):
5921 * editfns.c (save_excursion_restore):
5922 * cmds.c (internal_self_insert):
5923 * callint.c (Fcall_interactively):
5924 * buffer.c (Fkill_all_local_variables):
5925 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5926 Use Frun_hooks.
0f4a96b5 5927 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5928 unconditionnaly since it does the check itself.
5929
2c520ab5 59302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5931
c9c49752
PE
5932 Fix more problems found by GCC 4.5.2's static checks.
5933
8abc3f12
PE
5934 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5935 the first time through the loop, since we know p0 < p1 then.
5936 This also avoids a gcc -Wstrict-overflow warning.
5937
a2d26660
PE
5938 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5939 leading to a memory leak, possible in functions like
5940 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5941 of objects (Bug#8318).
a2d26660 5942
916c72e9
PE
5943 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5944 that could (at least in theory) be that large.
5945
19ab8a18
PE
5946 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5947 This is less likely to overflow, and avoids undefined behavior if
5948 overflow does occur. All callers changed. Use strtoul to scan
5949 for the unsigned long integer.
b7cbbd6f
PE
5950 (pint2hrstr): Simplify and tune code slightly.
5951 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5952
f0641eff
PE
5953 * scroll.c (do_scrolling): Work around GCC bug 48228.
5954 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5955
7f650bb9
PE
5956 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5957 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5958 (validate_x_resource_name): Simplify count usage.
5959 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5960
37dd57d1
PE
5961 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5962 fail (Bug#8306).
81e56e61 5963
699979fc 5964 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5965
401bf9b4
PE
5966 * process.c (Fmake_network_process): Use socklen_t, not int,
5967 where POSIX says socklen_t is required in portable programs.
5968 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5969 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5970 (Fmake_network_process, server_accept_connection):
5971 (wait_reading_process_output, read_process_output):
5972 Likewise.
5973
b93aacde
PE
5974 * process.c: Rename or move locals to avoid shadowing.
5975 (list_processes_1, Fmake_network_process):
5976 (read_process_output_error_handler, exec_sentinel_error_handler):
5977 Rename or move locals.
4dc343ee 5978 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5979 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5980 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5981 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5982 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5983
af8a867c 5984 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5985 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5986 Include tparam.h instead, since it declares them.
af8a867c
PE
5987 * cm.h (PC): Remove extern decl; tparam.h now does this.
5988 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5989 * terminfo.c: Include tparam.h, to check interfaces.
5990 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5991 (tparam): Adjust signature to match interface in tparam.h;
5992 this removes some undefined behavior. Check that outstring and len
5993 are zero, which they always are with Emacs.
5994 * tparam.h (PC, BC, UP): New extern decls.
5995
0248044d 5996 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5997 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5998
8ff096c1 5999 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6000 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6001 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6002 (ftfont_list): Remove unused local.
49eaafba
PE
6003 (get_adstyle_property, ftfont_pattern_entity):
6004 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6005 Rename locals to avoid shadowing.
8ff096c1 6006
e2be39f6
PE
6007 * xfont.c (xfont_list_family): Mark var as initialized.
6008
c9735e30
PE
6009 * xml.c (make_dom): Now static.
6010
8f5201ae
PE
6011 * composite.c (composition_compute_stop_pos): Rename local to
6012 avoid shadowing.
b246f932
PE
6013 (composition_reseat_it): Remove unused locals.
6014 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6015 (composition_update_it): Mark var as initialized.
11b61122
PE
6016 (find_automatic_composition): Mark vars as initialized,
6017 with a FIXME (Bug#8290).
8f5201ae 6018
760fbc2c
PE
6019 character.h: Rename locals to avoid shadowing.
6020 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6021 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6022 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6023 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6024 to avoid shadowing.
6025
ff08eb85
PE
6026 * textprop.c (property_change_between_p): Remove; unused.
6027
fc7bf025
PE
6028 * intervals.c (interval_start_pos): Now static.
6029
235d7abc
PE
6030 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6031
44f230aa
SM
6032 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6033 Rename locals to avoid shadowing.
3e7d6594 6034
50060332
PE
6035 * sound.c (wav_play, au_play, Fplay_sound_internal):
6036 Fix pointer signedness.
d01f234b 6037 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6038 (wav_play): Initialize a variable to 0, to prevent undefined
6039 behavior (Bug#8278).
50060332 6040
c4fc4e30
PE
6041 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6042
918436ed
PE
6043 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6044
c939f91b
PE
6045 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6046 clobbering (Bug#8298).
b9c7f648
PE
6047 * sysdep.c (sys_subshell): Likewise.
6048 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6049
6bd8c144
PE
6050 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6051 This should get cleaned up, so that child_setup has the
6052 same signature on all platforms.
6053
7710357c 6054 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6055 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6056
c59da222
CY
60572011-03-22 Chong Yidong <cyd@stupidchicken.com>
6058
6059 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6060 not to be necessary, and produces flickering.
6061
66b87493
GM
60622011-03-20 Glenn Morris <rgm@gnu.org>
6063
6064 * config.in: Remove file.
6065
45b6f6d5
JB
60662011-03-20 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6069 are now in src/globals.h.
6070 (syms_of_minibuf): Remove spurious & from previous change.
6071
3ec03f7e
LL
60722011-03-20 Leo <sdl.web@gmail.com>
6073
6074 * minibuf.c (completing-read-function): New variable.
6075 (completing-read-default): Rename from completing-read.
6076 (completing-read): Call completing-read-function.
6077
b14e3e21
CY
60782011-03-19 Juanma Barranquero <lekktu@gmail.com>
6079
6080 * xfaces.c (Fx_load_color_file):
6081 Read color file from absolute filename (bug#8250).
6082
f2b726e6
JB
60832011-03-19 Juanma Barranquero <lekktu@gmail.com>
6084
6085 * makefile.w32-in: Update dependencies.
6086
09f6ff02
EZ
60872011-03-17 Eli Zaretskii <eliz@gnu.org>
6088
6089 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6090
29a6015a
PE
60912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6092
a3a6c54e
PE
6093 Fix more problems found by GCC 4.5.2's static checks.
6094
b766f867
PE
6095 * process.c (make_serial_process_unwind, send_process_trap):
6096 (sigchld_handler): Now static.
6097
be02381c
PE
6098 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6099 That way, the code declares only the vars that it needs.
6100 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6101 * s/cygwin.h (PTY_ITERATION): Likewise.
6102 * s/darwin.h (PTY_ITERATION): Likewise.
6103 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6104
57048744
PE
6105 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6106 * process.c (allocate_pty): Don't declare stb unless it's needed.
6107
7914961c 6108 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6109 (CONSTANTLIM): Remove; unused.
6110 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6111 Define only if needed.
7914961c 6112
b3967b18
PE
6113 * unexelf.c (unexec): Name an expression,
6114 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6115 Use a different way to cause a compilation error if anyone uses
6116 n rather than nn, a way that does not involve shadowing.
73366a00 6117 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6118
29a6015a
PE
6119 * deps.mk (unexalpha.o): Remove; unused.
6120
43cfc33e 6121 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6122 * unexec.h: New file.
ce701a33
PE
6123 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6124 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6125 Depend on unexec.h.
6126 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6127 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6128 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6129 Change as necessary to match prototype in unexec.h.
ce701a33 6130
01f44d5a
PE
6131 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6132 shadowing.
4f63c6bb 6133 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6134
a6670b0b
PE
6135 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6136 Rename locals to avoid shadowing.
6137
cef2010d 6138 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6139 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6140
d4d7173a
PE
6141 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6142
f08b802a
PE
6143 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6144 warning when compiling print.c.
6145
3ddb0639
PE
6146 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6147 instead of using an uninitialized var.
5ad03b97 6148 (font_sort_entities): Mark var as initialized.
3ddb0639 6149
170a2692
PE
6150 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6151
e663c700
PE
6152 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6153 pointers to constants.
89bc529a 6154 (font_parse_fcname): Remove unused vars.
7b81e2d0 6155 (font_delete_unmatched): Now static.
ea838e10 6156 (font_get_spec): Remove; unused.
13a547c6
PE
6157 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6158 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6159 Rename or move locals to avoid shadowing.
e663c700 6160
2a80c887 6161 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6162 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6163
1384fa33 6164 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6165 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6166
8b2c52e9
PE
6167 * alloc.c (mark_backtrace): Move decl from here ...
6168 * lisp.h: ... to here, so that it can be checked.
6169
475545b5 6170 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6171 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6172 (lisp_indirect_variable): Name an expression,
6173 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6174 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6175
b1349114 6176 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6177 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6178 Use const pointer when appropriate.
b1349114 6179
a2928364
PE
6180 * lisp.h (get_system_name, get_operating_system_release):
6181 Move decls here, to check interfaces.
6182 * process.c (get_operating_system_release): Move decl to lisp.h.
6183 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6184 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6185 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6186 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6187 (Fformat_time_string, Fencode_time, Finsert_char):
6188 (Ftranslate_region_internal, Fformat):
6189 Rename or remove local vars to avoid shadowing.
9710023e 6190 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6191
a415e694
PE
6192 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6193 avoid shadowing.
6194
8ef4622d
PE
6195 * lisp.h (eassert): Check that the argument compiles, even if
6196 ENABLE_CHECKING is not defined.
6197
946f9a5b
PE
6198 * data.c (Findirect_variable): Name an expression, to avoid
6199 gcc -Wbad-function-cast warning.
112396d6 6200 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6201 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6202 (Fmake_variable_buffer_local, Fmake_local_variable):
6203 Mark variables as initialized.
52746918 6204 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6205
e5aab7e7 6206 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6207 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6208 Rename locals to avoid shadowing.
dff45157
PE
6209 (mark_stack): Move local variables into the #ifdef region where
6210 they're used.
7bc26fdb
PE
6211 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6212 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6213 needed otherwise.
6214 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6215 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6216 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6217
e5aab7e7
PE
6218 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6219 avoids undefined behavior in theory.
6220
4da60324
PE
6221 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6222
88043301
PE
6223 Use functions, not macros, for up- and down-casing (Bug#8254).
6224 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6225 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6226 to use the following functions instead of these macros.
6227 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6228 EMACS_INT, since callers assume the returned value fits in int.
6229 (upcase1): Likewise, for UPCASE_TABLE.
6230 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6231 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6232 the race-condition problem in the old DOWNCASE.
88043301 6233
19ed5445
PE
6234 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6235 Rename locals to avoid shadowing.
6236 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6237 (regex_compile, re_search_2, re_match_2_internal):
6238 Remove unused local vars.
952db0d7
PE
6239 (FREE_VAR): Rewrite so as not to use empty "else",
6240 which gcc can warn about.
da053e48 6241 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6242 (RETALLOC_IF): Define only if needed.
6243 (WORDCHAR_P): Likewise. This one is never needed, but is used
6244 only in a comment talking about a compiler bug, so put inside
6245 the #if 0 of that comment.
6246 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6247 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6248 Remove; unused.
19ed5445 6249
1f3561e4 6250 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6251 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6252 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6253
ded6f8f7
PE
6254 * search.c (simple_search): Remove unused var.
6255
dbd37a95
PE
6256 * dired.c (compile_pattern): Move decl from here ...
6257 * lisp.h: ... to here, so that it can be checked.
6258 (struct re_registers): New forward decl.
6259
7e47afad
PE
6260 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6261
85f24f61
PE
6262 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6263 All uses changed.
6264 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6265 Rename locals to avoid shadowing.
5671df8f 6266 (Fvertical_motion): Mark locals as initialized.
85f24f61 6267
181aa2be 6268 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6269 (casify_region): Mark local as initialized.
181aa2be 6270
930d429c
PE
6271 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6272
7082eac6
PE
6273 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6274 New macros, so that the caller can use some names other than
6275 gcpro1, gcpro2, etc.
6276 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6277 of the new macros.
6278 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6279 argument, for consistency with GCPRO2_VAR, etc: it is now the
6280 prefix of the variable, not the variable itself. All uses
6281 changed.
38b2c076
PE
6282 * dired.c (directory_files_internal, file_name_completion):
6283 Rename locals to avoid shadowing.
6284
15206ed9
PE
6285 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6286 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6287 dired.c's scmp function, had undefined behavior.
6288 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6289 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6290 * buffer.h: ... to here, because these macros use current_buffer,
6291 and the new implementation with inline functions needs to have
6292 current_buffer in scope now, rather than later when the macros
6293 are used.
6294 (downcase, upcase1): New static inline functions.
6295 (DOWNCASE, UPCASE1): Reimplement using these functions.
6296 This avoids undefined behavior in expressions like
6297 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6298 from race conditions in accessing the global variables
6299 case_temp1 and case_temp2.
6300 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6301 * lisp.h (case_temp1, case_temp2): Remove their decls.
6302 * character.h (ASCII_CHAR_P): Move from here ...
6303 * lisp.h: ... to here, so that the inline functions mentioned
6304 above can use them.
6305
4a6bea26
PE
6306 * dired.c (directory_files_internal_unwind): Now static.
6307
f14b7e14
PE
6308 * fileio.c (file_name_as_directory, directory_file_name):
6309 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6310 Now static.
2893f146
PE
6311 (file_name_as_directory): Use const pointers when appropriate.
6312 (Fexpand_file_name): Likewise. In particular, newdir might
6313 point at constant storage, so make it a const pointer.
fd4ead52 6314 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6315 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6316 signedness issues.
f839df0c
PE
6317 (Fset_file_times, Finsert_file_contents, auto_save_error):
6318 Rename locals to avoid shadowing.
f14b7e14 6319
5716756e 6320 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6321 (Ftry_completion, Fall_completions): Rename or remove locals
6322 to avoid shadowing.
5716756e 6323
b4c3046a
PE
6324 * marker.c (bytepos_to_charpos): Remove; unused.
6325
b45db522
PE
6326 * lisp.h (verify_bytepos, count_markers): New decls,
6327 so that gcc does not warn that these functions aren't declared.
6328
85876d07
PE
6329 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6330 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6331 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6332 (copy_text): Remove unused local var.
85876d07 6333
03d78a21 6334 * filelock.c (within_one_second): Now static.
b3dd38ab 6335 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6336
5df8f01b
PE
6337 * buffer.c (fix_overlays_before): Mark locals as initialized.
6338 (fix_start_end_in_overlays): Likewise. This function should be
6339 simplified by using pointers-to-pointers, but that's a different
6340 matter.
b1d876f1 6341 (switch_to_buffer_1): Now static.
8f54f30a
PE
6342 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6343 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6344
a70072c9 6345 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6346 Fix pointer signedness issue.
edced198
PE
6347 (sys_subshell): Mark local as volatile if checking for lint,
6348 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6349 (MAXPATHLEN): Define only if needed.
a70072c9 6350
a0977c44
PE
6351 * process.c (serial_open, serial_configure): Move decls from here ...
6352 * systty.h: ... to here, so that they can be checked.
6353
a884fdcc
PE
6354 * fns.c (get_random, seed_random): Move extern decls from here ...
6355 * lisp.h: ... to here, so that they can be checked.
6356
604efe86 6357 * sysdep.c (reset_io): Now static.
b8950c94 6358 (wait_for_termination_signal): Remove; unused.
604efe86 6359
38fc62d9
PE
6360 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6361 (copy_keymap_item, append_key, push_text_char_description):
6362 Now static.
1004a21a 6363 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6364 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6365 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6366 (describe_map_tree):
6367 Rename locals to avoid shadowing.
38fc62d9 6368
2f2650da
PE
6369 * keyboard.c: Declare functions static if they are not used elsewhere.
6370 (echo_char, echo_dash, cmd_error, top_level_2):
6371 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6372 (read_char, kbd_buffer_get_event, make_lispy_position):
6373 (make_lispy_event, make_lispy_movement, apply_modifiers):
6374 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6375 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6376 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6377 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6378 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6379
a053e86c 6380 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6381 (mark_kboards): Move decl here ...
6382 * alloc.c (mark_kboards): ... from here.
a053e86c 6383
4752793e
PE
6384 * lisp.h (force_auto_save_soon): New decl.
6385
74f10ca7 6386 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6387 (DEFINE_DUMMY_FUNCTION): New macro.
6388 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6389 Use it.
c03cd23f
PE
6390 (main): Add casts to avoid warnings
6391 if GCC considers string literals to be constants.
74f10ca7 6392
022e70d4
PE
6393 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6394
59d6fe83
PE
6395 * dbusbind.c: Pointer signedness fixes.
6396 (xd_signature, xd_append_arg, xd_initialize):
6397 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6398 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6399 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6400 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6401
78320123
PE
6402 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6403 if GCC considers string literals to be constants.
49cebcca 6404 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6405
35ac2a97
SM
64062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6407
fb103ca9
SM
6408 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6409 (print_preprocess, print_object): New macro to fix last change.
6410
35ac2a97
SM
6411 * print.c (print_preprocess): Don't forget font objects.
6412
62973b41
JB
64132011-03-16 Juanma Barranquero <lekktu@gmail.com>
6414
6415 * emacs.c (USAGE3): Doc fixes.
6416
0e48bb22
AS
64172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6418
6419 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6420 structure.
6421
7684e57b
JB
64222011-03-14 Juanma Barranquero <lekktu@gmail.com>
6423
6424 * lisp.h (VWindow_system, Qfile_name_history):
6425 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6426 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6427 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6428
6429 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6430 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6431
6432 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6433 * w32console.c (detect_input_pending, read_input_pending)
6434 (encode_terminal_code):
6435 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6436 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6437 (w32_system_caret_y, Qfile_name_history):
6438 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6439 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6440 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6441 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6442 * w32proc.c (Qlocal, report_file_error):
6443 * w32term.c (Vwindow_system, updating_frame):
6444 * w32uniscribe.c (initialized, uniscribe_font_driver):
6445 Remove unneeded extern declarations.
6446
2aa46d6c
CY
64472011-03-14 Chong Yidong <cyd@stupidchicken.com>
6448
c96bbc66 6449 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6450
cffc6f3b
CY
64512011-03-13 Chong Yidong <cyd@stupidchicken.com>
6452
6453 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6454 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6455 These macros can no longer be used for assignment.
6456
44f230aa
SM
6457 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6458 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6459 (record_buffer_markers, fetch_buffer_markers): New functions for
6460 recording and fetching special buffer markers.
6461 (set_buffer_internal_1, set_buffer_temp): Use them.
6462
6463 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6464
6465 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6466
6467 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6468 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6469
6470 * xdisp.c (hscroll_window_tree):
6471 (reconsider_clip_changes): Use PT instead of BUF_PT.
6472
d251f04b
EZ
64732011-03-13 Eli Zaretskii <eliz@gnu.org>
6474
6475 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6476 $(EMACS_ROOT)/lib/intprops.h.
6477
f0c77cd1
PE
64782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6479
3eca4629
PE
6480 Fix more problems found by GCC 4.5.2's static checks.
6481
7c86ee98
PE
6482 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6483 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6484 (xg_free_frame_widgets): Make it clear that a local variable is
6485 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6486 (gdk_window_get_screen): Make it clear that this macro is needed
6487 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6488 (int_gtk_range_get_value): New function, which avoids a diagnostic
6489 from gcc -Wbad-function-cast.
6490 (xg_set_toolkit_scroll_bar_thumb): Use it.
6491 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6492 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6493 (get_utf8_string, xg_get_file_with_chooser):
6494 Rename locals to avoid shadowing.
6495 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6496
41729b81
PE
6497 * xgselect.c (xg_select): Remove unused var.
6498
f0c77cd1
PE
6499 * image.c (four_corners_best): Mark locals as initialized.
6500 (gif_load): Initialize transparent_p to zero (Bug#8238).
6501 Mark another local as initialized.
ec6cf4c6 6502 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6503
ce0ad53d 6504 * image.c (clear_image_cache): Now static.
d5d5a617 6505 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6506 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6507 (x_edge_detection): Remove unnecessary cast that
6508 gcc -Wbad-function-cast diagnoses.
2037898d 6509 (gif_load): Fix pointer signedness.
6ae141d6
PE
6510 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6511 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6512
33383987 65132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6514
d32df629
PE
6515 Improve quality of tests for time stamp overflow.
6516 For example, without this patch (encode-time 0 0 0 1 1
6517 1152921504606846976) returns the obviously-bogus value (-948597
6518 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6519 reports time overflow. See
6520 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6521 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6522 * editfns.c: Include limits.h and intprops.h.
6523 (TIME_T_MIN, TIME_T_MAX): New macros.
6524 (time_overflow): Move earlier, to before first use.
6525 (hi_time, lo_time): New functions, for an accurate test for
6526 out-of-range times.
6527 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6528 (Fget_internal_run_time): Don't assume time_t fits in int.
6529 (make_time): Use list2 instead of Fcons twice.
6530 (Fdecode_time): More accurate test for out-of-range times.
6531 (check_tm_member): New function.
6532 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6533 (lisp_time_argument): Don't rely on undefined left-shift and
6534 right-shift behavior when checking for time stamp overflow.
8be6f318 6535
fe31d94c
PE
6536 * editfns.c (time_overflow): New function, refactoring common code.
6537 (Fformat_time_string, Fdecode_time, Fencode_time):
6538 (Fcurrent_time_string): Use it.
6539
8be6f318
PE
6540 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6541 * dired.c (make_time): Move to ...
6542 * editfns.c (make_time): ... here.
6543 * systime.h: Note the move.
6544
09d9db2c 65452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6546
126bc0dc
YM
6547 * fringe.c (update_window_fringes): Remove unused variables.
6548
c47cbdfd
YM
6549 * unexmacosx.c (copy_data_segment): Also copy __got section.
6550 (Bug#8223)
6551
7ac80be9
EZ
65522011-03-12 Eli Zaretskii <eliz@gnu.org>
6553
c96bbc66 6554 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6555 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6556 Constify `char *' arguments and their references according to
6557 prototypes in tparam.h.
6558
ecb0f94d 6559 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6560
7ac80be9
EZ
6561 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6562 Adapt all references accordingly.
6563
6564 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6565
ef1fd07e
TT
65662011-03-11 Tom Tromey <tromey@redhat.com>
6567
6568 * buffer.c (syms_of_buffer): Remove obsolete comment.
6569
7ef4b50c
EZ
65702011-03-11 Eli Zaretskii <eliz@gnu.org>
6571
6572 * termhooks.h (encode_terminal_code): Declare prototype.
6573
6574 * msdos.c (encode_terminal_code): Don't declare prototype.
6575
6576 * term.c (encode_terminal_code): Now external again, used by
6577 w32console.c and msdos.c.
6578
44f230aa
SM
6579 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6580 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6581
4b1ec863 65822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6583
1714f52b 6584 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6585
4b1ec863
PE
6586 * fringe.c (update_window_fringes): Mark locals as initialized
6587 (Bug#8227).
6588 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6589
524c7aa6
PE
6590 * alloc.c (mark_fringe_data): Move decl from here ...
6591 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6592 to check its interface.
6593 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6594
a5c0af81 6595 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6596 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6597 (fontset_font): Mark local as initialized.
a9a06e0b 6598 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6599
b4716021
PE
6600 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6601
811e9bac 6602 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6603 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6604 (x_own_selection, Fx_disown_selection_internal): Rename locals
6605 to avoid shadowing.
6606 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6607
7e3ab302
PE
6608 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6609 so that the caller can use some name other than gcpro1.
6610 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6611 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6612 (Fx_backspace_delete_keys_p):
6613 Use them to avoid shadowing, and rename vars to avoid shadowing.
6614 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6615 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6616 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6617 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6618 Remove unused locals.
7e3ab302
PE
6619 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6620 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6621 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6622 macros.
f78faa98 6623
e2b13473
PE
6624 * xterm.h (x_mouse_leave): New decl.
6625
77f23912
PE
6626 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6627 Remove unused functions.
cdf4ba58
PE
6628 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6629 (x_calc_absolute_position): Now static.
7411c686 6630 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6631 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6632 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6633 unless they are used.
38d0b34a
PE
6634 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6635 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6636 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6637 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6638 (x_error_catcher, x_connection_closed, x_error_handler):
6639 (x_error_quitter, xembed_send_message, x_iconify_frame):
6640 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6641 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6642 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6643
44f230aa
SM
6644 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6645 Rename or move locals to avoid shadowing.
6b463e58 6646 (tty_defined_color, merge_face_heights): Now static.
5967d051 6647 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6648 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6649 does not deduce is never used uninitialized.
73719eba
PE
6650 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6651 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6652
426994c3 6653 * terminal.c (store_terminal_param): Now static.
5489860b 6654
032f1620 6655 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6656 (set_frame_menubar): Remove unused local.
d4323972 6657 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6658 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6659 since they might point to immutable storage.
281585b0
PE
6660 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6661 since it's unused otherwise.
032f1620 6662
367c19e5 6663 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6664 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6665 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6666 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6667 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6668 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6669 does not deduce are never used uninitialized.
70739cbe 6670
07b48fa9
PE
6671 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6672
8868a238 6673 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6674 * window.c (window_loop, size_window):
6675 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6676
7e5cf297 6677 * window.c (display_buffer): Now static.
d6550a9f
PE
6678 (size_window): Mark variables that gcc -Wuninitialized
6679 does not deduce are never used uninitialized.
a586633d
PE
6680 * window.h (check_all_windows): New decl, to forestall
6681 gcc -Wmissing-prototypes diagnostic.
5b555da1 6682 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6683
f6095868
PE
6684 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6685 shadowing.
6686 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6687 Include <limits.h>.
6688 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6689 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6690 (load_charset_map): Mark variables that gcc -Wuninitialized
6691 does not deduce are never used uninitialized.
53df7c11 6692 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6693
f38b440c
PE
6694 * coding.c (coding_set_source, coding_set_destination):
6695 Use "else { /* comment */ }" rather than "else /* comment */;"
6696 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6697 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6698 a block, when the outer 'i' will do.
6699 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6700 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6701 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6702 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6703 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6704 Rename locals to avoid shadowing.
6705 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6706 * coding.c (emacs_mule_char, encode_invocation_designation):
6707 Now static, since they're not used elsewhere.
413bb2db 6708 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6709 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6710 (decode_coding_emacs_mule): Mark variables that gcc
6711 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6712 (detect_coding_iso_2022): Initialize a local variable that might
6713 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6714 this initialization is needed. (Bug#8211)
5f58e762
PE
6715 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6716 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6717 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6718 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6719 Remove unused macros.
f38b440c 6720
232b38b9 6721 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6722 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6723 * character.c (string_count_byte8): Likewise.
232b38b9 6724
fb90da1b
PE
6725 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6726 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6727
fb93dbc2
PE
6728 * chartab.c (copy_sub_char_table): Now static, since it's not used
6729 elsewhere.
5c156ace
PE
6730 (sub_char_table_ref_and_range, char_table_ref_and_range):
6731 Rename locals to avoid shadowing.
bbcd0949 6732 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6733
7d3b3862 6734 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6735 (BIDI_BOB): Remove unused macro.
7d3b3862 6736
6be7d3da
PE
6737 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6738 deduce are never used uninitialized.
c2ed9c8b 6739 * term.c (encode_terminal_code): Likewise.
6be7d3da 6740
75f8807f 6741 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6742
50938595
PE
6743 * tparam.h: New file.
6744 * term.c, tparam.h: Include it.
6745 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6746 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6747 Move these decls to tparam.h, and make them agree with what
6748 is actually in tparam.c. The previous trick of using incompatible
6749 decls in different modules does not conform to the C standard.
6750 All callers of tparam changed to use tparam's actual API.
6751 * tparam.c (tparam1, tparam, tgoto):
6752 Use const pointers where appropriate.
6753
fbceeba2
PE
6754 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6755 * cm.h (struct cm): Likewise.
6756 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6757 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6758 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6759 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6760 (turn_on_face, init_tty): Likewise.
6761 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6762
7f3f1250
PE
6763 * term.c (term_mouse_position): Rename local to avoid shadowing.
6764
e6ca6543
PE
6765 * alloc.c (mark_ttys): Move decl from here ...
6766 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6767
c40f8d15
AS
67682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6769
6770 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6771
cfe0661d
JB
67722011-03-09 Juanma Barranquero <lekktu@gmail.com>
6773
6774 * search.c (compile_pattern_1): Remove argument regp, unused since
6775 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6776 (compile_pattern): Don't pass it.
6777
0afb4571
J
67782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6779
6780 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6781 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6782 for ! HAVE_GTK3.
6783 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6784
6785 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6786
6787 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6788 gdk_window_get_screen, gdk_window_get_geometry,
6789 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6790 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6791 (xg_get_pixbuf_from_pixmap): New function.
6792 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6793 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6794 Call xg_get_pixbuf_from_pixmap instead of
6795 gdk_pixbuf_get_from_drawable.
6796 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6797 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6798 (xg_check_special_colors): Use GtkStyleContext and its functions
6799 for HAVE_GTK3.
6800 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6801 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6802 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6803 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6804 Call gtk_widget_get_preferred_size.
0afb4571
J
6805 (xg_frame_resized): gdk_window_get_geometry only takes 5
6806 parameters.
44f230aa
SM
6807 (xg_win_to_widget, xg_event_is_for_menubar):
6808 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6809 (xg_set_widget_bg): New function.
6810 (delete_cb): New function.
895009e1 6811 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6812 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6813 (xg_set_background_color): Call xg_set_widget_bg.
6814 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6815 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6816 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6817 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6818 if ! HAVE_GTK3.
6819 (update_frame_tool_bar): Call gtk_widget_hide.
6820 (xg_initialize): Use GDK_KEY_g.
6821
6822 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6823 if ! HAVE_GTK3
6824 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6825
6826 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6827 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6828 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6829
1c2cc4ef
JB
68302011-03-08 Juanma Barranquero <lekktu@gmail.com>
6831
6832 * w32xfns.c (select_palette): Check success of RealizePalette against
6833 GDI_ERROR, not zero.
6834
33383987 6835See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6836
6837;; Local Variables:
6838;; coding: utf-8
aac0c6e3
MR
6839;; End:
6840
33383987 6841 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6842
6843 This file is part of GNU Emacs.
6844
6845 GNU Emacs is free software: you can redistribute it and/or modify
6846 it under the terms of the GNU General Public License as published by
6847 the Free Software Foundation, either version 3 of the License, or
6848 (at your option) any later version.
6849
6850 GNU Emacs is distributed in the hope that it will be useful,
6851 but WITHOUT ANY WARRANTY; without even the implied warranty of
6852 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6853 GNU General Public License for more details.
6854
6855 You should have received a copy of the GNU General Public License
6856 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.